hmp: do not crash on invalid SCSI hotplug
[qemu/ar7.git] / hw / pci-hotplug.c
blob0ca5546fc6be75d58d28bb1251a90e38eb1b6e59
1 /*
2 * QEMU PCI hotplug support
4 * Copyright (c) 2004 Fabrice Bellard
6 * Permission is hereby granted, free of charge, to any person obtaining a copy
7 * of this software and associated documentation files (the "Software"), to deal
8 * in the Software without restriction, including without limitation the rights
9 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10 * copies of the Software, and to permit persons to whom the Software is
11 * furnished to do so, subject to the following conditions:
13 * The above copyright notice and this permission notice shall be included in
14 * all copies or substantial portions of the Software.
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
22 * THE SOFTWARE.
25 #include "hw.h"
26 #include "boards.h"
27 #include "pci.h"
28 #include "net.h"
29 #include "pc.h"
30 #include "monitor.h"
31 #include "scsi.h"
32 #include "virtio-blk.h"
33 #include "qemu-config.h"
34 #include "blockdev.h"
35 #include "error.h"
37 #if defined(TARGET_I386)
38 static PCIDevice *qemu_pci_hot_add_nic(Monitor *mon,
39 const char *devaddr,
40 const char *opts_str)
42 Error *local_err = NULL;
43 QemuOpts *opts;
44 PCIBus *bus;
45 int ret, devfn;
47 bus = pci_get_bus_devfn(&devfn, devaddr);
48 if (!bus) {
49 monitor_printf(mon, "Invalid PCI device address %s\n", devaddr);
50 return NULL;
52 if (!((BusState*)bus)->allow_hotplug) {
53 monitor_printf(mon, "PCI bus doesn't support hotplug\n");
54 return NULL;
57 opts = qemu_opts_parse(qemu_find_opts("net"), opts_str ? opts_str : "", 0);
58 if (!opts) {
59 return NULL;
62 qemu_opt_set(opts, "type", "nic");
64 ret = net_client_init(opts, 0, &local_err);
65 if (error_is_set(&local_err)) {
66 qerror_report_err(local_err);
67 error_free(local_err);
68 return NULL;
70 if (nd_table[ret].devaddr) {
71 monitor_printf(mon, "Parameter addr not supported\n");
72 return NULL;
74 return pci_nic_init(&nd_table[ret], "rtl8139", devaddr);
77 static int scsi_hot_add(Monitor *mon, DeviceState *adapter,
78 DriveInfo *dinfo, int printinfo)
80 SCSIBus *scsibus;
81 SCSIDevice *scsidev;
83 scsibus = (SCSIBus *)
84 object_dynamic_cast(OBJECT(QLIST_FIRST(&adapter->child_bus)),
85 TYPE_SCSI_BUS);
86 if (!scsibus) {
87 error_report("Device is not a SCSI adapter");
88 return -1;
92 * drive_init() tries to find a default for dinfo->unit. Doesn't
93 * work at all for hotplug though as we assign the device to a
94 * specific bus instead of the first bus with spare scsi ids.
96 * Ditch the calculated value and reload from option string (if
97 * specified).
99 dinfo->unit = qemu_opt_get_number(dinfo->opts, "unit", -1);
100 dinfo->bus = scsibus->busnr;
101 scsidev = scsi_bus_legacy_add_drive(scsibus, dinfo->bdrv, dinfo->unit,
102 false, -1);
103 if (!scsidev) {
104 return -1;
106 dinfo->unit = scsidev->id;
108 if (printinfo)
109 monitor_printf(mon, "OK bus %d, unit %d\n",
110 scsibus->busnr, scsidev->id);
111 return 0;
114 int pci_drive_hot_add(Monitor *mon, const QDict *qdict,
115 DriveInfo *dinfo, int type)
117 int dom, pci_bus;
118 unsigned slot;
119 PCIDevice *dev;
120 const char *pci_addr = qdict_get_str(qdict, "pci_addr");
122 switch (type) {
123 case IF_SCSI:
124 if (pci_read_devaddr(mon, pci_addr, &dom, &pci_bus, &slot)) {
125 goto err;
127 dev = pci_find_device(pci_find_root_bus(dom), pci_bus,
128 PCI_DEVFN(slot, 0));
129 if (!dev) {
130 monitor_printf(mon, "no pci device with address %s\n", pci_addr);
131 goto err;
133 if (scsi_hot_add(mon, &dev->qdev, dinfo, 1) != 0) {
134 goto err;
136 break;
137 default:
138 monitor_printf(mon, "Can't hot-add drive to type %d\n", type);
139 goto err;
142 return 0;
143 err:
144 return -1;
147 static PCIDevice *qemu_pci_hot_add_storage(Monitor *mon,
148 const char *devaddr,
149 const char *opts)
151 PCIDevice *dev;
152 DriveInfo *dinfo = NULL;
153 int type = -1;
154 char buf[128];
155 PCIBus *bus;
156 int devfn;
158 if (get_param_value(buf, sizeof(buf), "if", opts)) {
159 if (!strcmp(buf, "scsi"))
160 type = IF_SCSI;
161 else if (!strcmp(buf, "virtio")) {
162 type = IF_VIRTIO;
163 } else {
164 monitor_printf(mon, "type %s not a hotpluggable PCI device.\n", buf);
165 return NULL;
167 } else {
168 monitor_printf(mon, "no if= specified\n");
169 return NULL;
172 if (get_param_value(buf, sizeof(buf), "file", opts)) {
173 dinfo = add_init_drive(opts);
174 if (!dinfo)
175 return NULL;
176 if (dinfo->devaddr) {
177 monitor_printf(mon, "Parameter addr not supported\n");
178 return NULL;
180 } else {
181 dinfo = NULL;
184 bus = pci_get_bus_devfn(&devfn, devaddr);
185 if (!bus) {
186 monitor_printf(mon, "Invalid PCI device address %s\n", devaddr);
187 return NULL;
189 if (!((BusState*)bus)->allow_hotplug) {
190 monitor_printf(mon, "PCI bus doesn't support hotplug\n");
191 return NULL;
194 switch (type) {
195 case IF_SCSI:
196 dev = pci_create(bus, devfn, "lsi53c895a");
197 if (qdev_init(&dev->qdev) < 0)
198 dev = NULL;
199 if (dev && dinfo) {
200 if (scsi_hot_add(mon, &dev->qdev, dinfo, 0) != 0) {
201 qdev_unplug(&dev->qdev, NULL);
202 dev = NULL;
205 break;
206 case IF_VIRTIO:
207 if (!dinfo) {
208 monitor_printf(mon, "virtio requires a backing file/device.\n");
209 return NULL;
211 dev = pci_create(bus, devfn, "virtio-blk-pci");
212 if (qdev_prop_set_drive(&dev->qdev, "drive", dinfo->bdrv) < 0) {
213 qdev_free(&dev->qdev);
214 dev = NULL;
215 break;
217 if (qdev_init(&dev->qdev) < 0)
218 dev = NULL;
219 break;
220 default:
221 dev = NULL;
223 return dev;
226 void pci_device_hot_add(Monitor *mon, const QDict *qdict)
228 PCIDevice *dev = NULL;
229 const char *pci_addr = qdict_get_str(qdict, "pci_addr");
230 const char *type = qdict_get_str(qdict, "type");
231 const char *opts = qdict_get_try_str(qdict, "opts");
233 /* strip legacy tag */
234 if (!strncmp(pci_addr, "pci_addr=", 9)) {
235 pci_addr += 9;
238 if (!opts) {
239 opts = "";
242 if (!strcmp(pci_addr, "auto"))
243 pci_addr = NULL;
245 if (strcmp(type, "nic") == 0) {
246 dev = qemu_pci_hot_add_nic(mon, pci_addr, opts);
247 } else if (strcmp(type, "storage") == 0) {
248 dev = qemu_pci_hot_add_storage(mon, pci_addr, opts);
249 } else {
250 monitor_printf(mon, "invalid type: %s\n", type);
253 if (dev) {
254 monitor_printf(mon, "OK domain %d, bus %d, slot %d, function %d\n",
255 pci_find_domain(dev->bus),
256 pci_bus_num(dev->bus), PCI_SLOT(dev->devfn),
257 PCI_FUNC(dev->devfn));
258 } else
259 monitor_printf(mon, "failed to add %s\n", opts);
261 #endif
263 static int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
265 PCIDevice *d;
266 int dom, bus;
267 unsigned slot;
268 Error *local_err = NULL;
270 if (pci_read_devaddr(mon, pci_addr, &dom, &bus, &slot)) {
271 return -1;
274 d = pci_find_device(pci_find_root_bus(dom), bus, PCI_DEVFN(slot, 0));
275 if (!d) {
276 monitor_printf(mon, "slot %d empty\n", slot);
277 return -1;
280 qdev_unplug(&d->qdev, &local_err);
281 if (error_is_set(&local_err)) {
282 monitor_printf(mon, "%s\n", error_get_pretty(local_err));
283 error_free(local_err);
284 return -1;
287 return 0;
290 void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict)
292 pci_device_hot_remove(mon, qdict_get_str(qdict, "pci_addr"));