scsi: scsi_bus_legacy_handle_cmdline() can fail, fix callers
[qemu.git] / hw / pci-hotplug.c
blob55c9fe3a79484b8387d110f564d32391b6216a53
1 /*
2 * QEMU PCI hotplug support
4 * Copyright (c) 2004 Fabrice Bellard
6 * Permission is hereby granted, free of charge, to any person obtaining a copy
7 * of this software and associated documentation files (the "Software"), to deal
8 * in the Software without restriction, including without limitation the rights
9 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
10 * copies of the Software, and to permit persons to whom the Software is
11 * furnished to do so, subject to the following conditions:
13 * The above copyright notice and this permission notice shall be included in
14 * all copies or substantial portions of the Software.
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
21 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
22 * THE SOFTWARE.
25 #include "hw.h"
26 #include "boards.h"
27 #include "pci.h"
28 #include "net.h"
29 #include "pc.h"
30 #include "monitor.h"
31 #include "scsi.h"
32 #include "virtio-blk.h"
33 #include "qemu-config.h"
35 #if defined(TARGET_I386)
36 static PCIDevice *qemu_pci_hot_add_nic(Monitor *mon,
37 const char *devaddr,
38 const char *opts_str)
40 QemuOpts *opts;
41 PCIBus *bus;
42 int ret, devfn;
44 bus = pci_get_bus_devfn(&devfn, devaddr);
45 if (!bus) {
46 monitor_printf(mon, "Invalid PCI device address %s\n", devaddr);
47 return NULL;
49 if (!((BusState*)bus)->allow_hotplug) {
50 monitor_printf(mon, "PCI bus doesn't support hotplug\n");
51 return NULL;
54 opts = qemu_opts_parse(&qemu_net_opts, opts_str ? opts_str : "", 0);
55 if (!opts) {
56 return NULL;
59 qemu_opt_set(opts, "type", "nic");
61 ret = net_client_init(mon, opts, 0);
62 if (ret < 0)
63 return NULL;
64 if (nd_table[ret].devaddr) {
65 monitor_printf(mon, "Parameter addr not supported\n");
66 return NULL;
68 return pci_nic_init(&nd_table[ret], "rtl8139", devaddr);
71 static int scsi_hot_add(Monitor *mon, DeviceState *adapter,
72 DriveInfo *dinfo, int printinfo)
74 SCSIBus *scsibus;
75 SCSIDevice *scsidev;
77 scsibus = DO_UPCAST(SCSIBus, qbus, QLIST_FIRST(&adapter->child_bus));
78 if (!scsibus || strcmp(scsibus->qbus.info->name, "SCSI") != 0) {
79 error_report("Device is not a SCSI adapter");
80 return -1;
84 * drive_init() tries to find a default for dinfo->unit. Doesn't
85 * work at all for hotplug though as we assign the device to a
86 * specific bus instead of the first bus with spare scsi ids.
88 * Ditch the calculated value and reload from option string (if
89 * specified).
91 dinfo->unit = qemu_opt_get_number(dinfo->opts, "unit", -1);
92 scsidev = scsi_bus_legacy_add_drive(scsibus, dinfo, dinfo->unit);
93 if (!scsidev) {
94 return -1;
96 dinfo->unit = scsidev->id;
98 if (printinfo)
99 monitor_printf(mon, "OK bus %d, unit %d\n",
100 scsibus->busnr, scsidev->id);
101 return 0;
104 void drive_hot_add(Monitor *mon, const QDict *qdict)
106 int dom, pci_bus;
107 unsigned slot;
108 int type;
109 PCIDevice *dev;
110 DriveInfo *dinfo = NULL;
111 const char *pci_addr = qdict_get_str(qdict, "pci_addr");
112 const char *opts = qdict_get_str(qdict, "opts");
114 dinfo = add_init_drive(opts);
115 if (!dinfo)
116 goto err;
117 if (dinfo->devaddr) {
118 monitor_printf(mon, "Parameter addr not supported\n");
119 goto err;
121 type = dinfo->type;
123 switch (type) {
124 case IF_SCSI:
125 if (pci_read_devaddr(mon, pci_addr, &dom, &pci_bus, &slot)) {
126 goto err;
128 dev = pci_find_device(pci_find_root_bus(dom), pci_bus, slot, 0);
129 if (!dev) {
130 monitor_printf(mon, "no pci device with address %s\n", pci_addr);
131 goto err;
133 if (scsi_hot_add(mon, &dev->qdev, dinfo, 1) != 0) {
134 goto err;
136 break;
137 case IF_NONE:
138 monitor_printf(mon, "OK\n");
139 break;
140 default:
141 monitor_printf(mon, "Can't hot-add drive to type %d\n", type);
142 goto err;
144 return;
146 err:
147 if (dinfo)
148 drive_uninit(dinfo);
149 return;
152 static PCIDevice *qemu_pci_hot_add_storage(Monitor *mon,
153 const char *devaddr,
154 const char *opts)
156 PCIDevice *dev;
157 DriveInfo *dinfo = NULL;
158 int type = -1;
159 char buf[128];
160 PCIBus *bus;
161 int devfn;
163 if (get_param_value(buf, sizeof(buf), "if", opts)) {
164 if (!strcmp(buf, "scsi"))
165 type = IF_SCSI;
166 else if (!strcmp(buf, "virtio")) {
167 type = IF_VIRTIO;
168 } else {
169 monitor_printf(mon, "type %s not a hotpluggable PCI device.\n", buf);
170 return NULL;
172 } else {
173 monitor_printf(mon, "no if= specified\n");
174 return NULL;
177 if (get_param_value(buf, sizeof(buf), "file", opts)) {
178 dinfo = add_init_drive(opts);
179 if (!dinfo)
180 return NULL;
181 if (dinfo->devaddr) {
182 monitor_printf(mon, "Parameter addr not supported\n");
183 return NULL;
185 } else {
186 dinfo = NULL;
189 bus = pci_get_bus_devfn(&devfn, devaddr);
190 if (!bus) {
191 monitor_printf(mon, "Invalid PCI device address %s\n", devaddr);
192 return NULL;
194 if (!((BusState*)bus)->allow_hotplug) {
195 monitor_printf(mon, "PCI bus doesn't support hotplug\n");
196 return NULL;
199 switch (type) {
200 case IF_SCSI:
201 dev = pci_create(bus, devfn, "lsi53c895a");
202 if (qdev_init(&dev->qdev) < 0)
203 dev = NULL;
204 if (dev && dinfo) {
205 if (scsi_hot_add(mon, &dev->qdev, dinfo, 0) != 0) {
206 qdev_unplug(&dev->qdev);
207 dev = NULL;
210 break;
211 case IF_VIRTIO:
212 if (!dinfo) {
213 monitor_printf(mon, "virtio requires a backing file/device.\n");
214 return NULL;
216 dev = pci_create(bus, devfn, "virtio-blk-pci");
217 qdev_prop_set_drive(&dev->qdev, "drive", dinfo);
218 if (qdev_init(&dev->qdev) < 0)
219 dev = NULL;
220 break;
221 default:
222 dev = NULL;
224 return dev;
227 void pci_device_hot_add(Monitor *mon, const QDict *qdict)
229 PCIDevice *dev = NULL;
230 const char *pci_addr = qdict_get_str(qdict, "pci_addr");
231 const char *type = qdict_get_str(qdict, "type");
232 const char *opts = qdict_get_try_str(qdict, "opts");
234 /* strip legacy tag */
235 if (!strncmp(pci_addr, "pci_addr=", 9)) {
236 pci_addr += 9;
239 if (!opts) {
240 opts = "";
243 if (!strcmp(pci_addr, "auto"))
244 pci_addr = NULL;
246 if (strcmp(type, "nic") == 0) {
247 dev = qemu_pci_hot_add_nic(mon, pci_addr, opts);
248 } else if (strcmp(type, "storage") == 0) {
249 dev = qemu_pci_hot_add_storage(mon, pci_addr, opts);
250 } else {
251 monitor_printf(mon, "invalid type: %s\n", type);
254 if (dev) {
255 monitor_printf(mon, "OK domain %d, bus %d, slot %d, function %d\n",
256 pci_find_domain(dev->bus),
257 pci_bus_num(dev->bus), PCI_SLOT(dev->devfn),
258 PCI_FUNC(dev->devfn));
259 } else
260 monitor_printf(mon, "failed to add %s\n", opts);
262 #endif
264 int pci_device_hot_remove(Monitor *mon, const char *pci_addr)
266 PCIDevice *d;
267 int dom, bus;
268 unsigned slot;
270 if (pci_read_devaddr(mon, pci_addr, &dom, &bus, &slot)) {
271 return -1;
274 d = pci_find_device(pci_find_root_bus(dom), bus, slot, 0);
275 if (!d) {
276 monitor_printf(mon, "slot %d empty\n", slot);
277 return -1;
279 return qdev_unplug(&d->qdev);
282 void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict)
284 pci_device_hot_remove(mon, qdict_get_str(qdict, "pci_addr"));