Revert "Catalog NOT NULL constraints" and fallout
commit9ce04b50e120275afbc03ca0b80839dde3da8308
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 12 Apr 2023 17:29:21 +0000 (12 19:29 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Wed, 12 Apr 2023 17:29:21 +0000 (12 19:29 +0200)
treec9b815953349fc5bf689799108a2966fec755bf7
parent8e82db97b0a474008d8212a63f34e449a8c50bcd
Revert "Catalog NOT NULL constraints" and fallout

This reverts commit e056c557aef4 and minor later fixes thereof.

There's a few problems in this new feature -- most notably regarding
pg_upgrade behavior, but others as well.  This new feature is not in any
way critical on its own, so instead of scrambling to fix it we revert it
and try again in early 17 with these issues in mind.

Discussion: https://postgr.es/m/3801207.1681057430@sss.pgh.pa.us
42 files changed:
doc/src/sgml/catalogs.sgml
doc/src/sgml/ref/alter_table.sgml
doc/src/sgml/ref/create_table.sgml
src/backend/catalog/heap.c
src/backend/catalog/pg_constraint.c
src/backend/commands/tablecmds.c
src/backend/nodes/outfuncs.c
src/backend/nodes/readfuncs.c
src/backend/optimizer/util/plancat.c
src/backend/parser/gram.y
src/backend/parser/parse_utilcmd.c
src/backend/utils/adt/ruleutils.c
src/bin/pg_dump/common.c
src/bin/pg_dump/pg_backup_archiver.c
src/bin/pg_dump/pg_dump.c
src/bin/pg_dump/pg_dump.h
src/bin/pg_dump/t/002_pg_dump.pl
src/include/catalog/catversion.h
src/include/catalog/heap.h
src/include/catalog/pg_constraint.h
src/include/commands/tablecmds.h
src/include/nodes/parsenodes.h
src/test/modules/test_ddl_deparse/expected/alter_table.out
src/test/modules/test_ddl_deparse/expected/create_table.out
src/test/modules/test_ddl_deparse/test_ddl_deparse.c
src/test/regress/expected/alter_table.out
src/test/regress/expected/cluster.out
src/test/regress/expected/constraints.out
src/test/regress/expected/create_table.out
src/test/regress/expected/event_trigger.out
src/test/regress/expected/foreign_data.out
src/test/regress/expected/foreign_key.out
src/test/regress/expected/indexing.out
src/test/regress/expected/inherit.out
src/test/regress/expected/replica_identity.out
src/test/regress/parallel_schedule
src/test/regress/sql/alter_table.sql
src/test/regress/sql/constraints.sql
src/test/regress/sql/create_table.sql
src/test/regress/sql/indexing.sql
src/test/regress/sql/inherit.sql
src/test/regress/sql/replica_identity.sql