1 /* CFG cleanup for trees.
2 Copyright (C) 2001, 2002, 2003, 2004, 2005, 2006, 2007
3 Free Software Foundation, Inc.
5 This file is part of GCC.
7 GCC is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 3, or (at your option)
12 GCC is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details.
17 You should have received a copy of the GNU General Public License
18 along with GCC; see the file COPYING3. If not see
19 <http://www.gnu.org/licenses/>. */
23 #include "coretypes.h"
28 #include "hard-reg-set.h"
29 #include "basic-block.h"
36 #include "langhooks.h"
37 #include "diagnostic.h"
38 #include "tree-flow.h"
40 #include "tree-dump.h"
41 #include "tree-pass.h"
45 #include "cfglayout.h"
47 #include "tree-ssa-propagate.h"
48 #include "tree-scalar-evolution.h"
50 /* The set of blocks in that at least one of the following changes happened:
51 -- the statement at the end of the block was changed
52 -- the block was newly created
53 -- the set of the predecessors of the block changed
54 -- the set of the successors of the block changed
55 ??? Maybe we could track these changes separately, since they determine
56 what cleanups it makes sense to try on the block. */
57 bitmap cfgcleanup_altered_bbs
;
59 /* Remove any fallthru edge from EV. Return true if an edge was removed. */
62 remove_fallthru_edge (VEC(edge
,gc
) *ev
)
67 FOR_EACH_EDGE (e
, ei
, ev
)
68 if ((e
->flags
& EDGE_FALLTHRU
) != 0)
70 remove_edge_and_dominated_blocks (e
);
77 /* Disconnect an unreachable block in the control expression starting
81 cleanup_control_expr_graph (basic_block bb
, gimple_stmt_iterator gsi
)
85 gimple stmt
= gsi_stmt (gsi
);
88 if (!single_succ_p (bb
))
94 fold_defer_overflow_warnings ();
95 val
= gimple_fold (stmt
);
96 taken_edge
= find_taken_edge (bb
, val
);
99 fold_undefer_and_ignore_overflow_warnings ();
103 /* Remove all the edges except the one that is always executed. */
105 for (ei
= ei_start (bb
->succs
); (e
= ei_safe_edge (ei
)); )
111 fold_undefer_overflow_warnings
112 (true, stmt
, WARN_STRICT_OVERFLOW_CONDITIONAL
);
116 taken_edge
->probability
+= e
->probability
;
117 taken_edge
->count
+= e
->count
;
118 remove_edge_and_dominated_blocks (e
);
125 fold_undefer_and_ignore_overflow_warnings ();
126 if (taken_edge
->probability
> REG_BR_PROB_BASE
)
127 taken_edge
->probability
= REG_BR_PROB_BASE
;
130 taken_edge
= single_succ_edge (bb
);
132 bitmap_set_bit (cfgcleanup_altered_bbs
, bb
->index
);
133 gsi_remove (&gsi
, true);
134 taken_edge
->flags
= EDGE_FALLTHRU
;
139 /* Try to remove superfluous control structures in basic block BB. Returns
140 true if anything changes. */
143 cleanup_control_flow_bb (basic_block bb
)
145 gimple_stmt_iterator gsi
;
149 /* If the last statement of the block could throw and now cannot,
150 we need to prune cfg. */
151 retval
|= gimple_purge_dead_eh_edges (bb
);
153 gsi
= gsi_last_bb (bb
);
157 stmt
= gsi_stmt (gsi
);
159 if (gimple_code (stmt
) == GIMPLE_COND
160 || gimple_code (stmt
) == GIMPLE_SWITCH
)
161 retval
|= cleanup_control_expr_graph (bb
, gsi
);
162 else if (gimple_code (stmt
) == GIMPLE_GOTO
163 && TREE_CODE (gimple_goto_dest (stmt
)) == ADDR_EXPR
164 && (TREE_CODE (TREE_OPERAND (gimple_goto_dest (stmt
), 0))
167 /* If we had a computed goto which has a compile-time determinable
168 destination, then we can eliminate the goto. */
172 basic_block target_block
;
174 /* First look at all the outgoing edges. Delete any outgoing
175 edges which do not go to the right block. For the one
176 edge which goes to the right block, fix up its flags. */
177 label
= TREE_OPERAND (gimple_goto_dest (stmt
), 0);
178 target_block
= label_to_block (label
);
179 for (ei
= ei_start (bb
->succs
); (e
= ei_safe_edge (ei
)); )
181 if (e
->dest
!= target_block
)
182 remove_edge_and_dominated_blocks (e
);
185 /* Turn off the EDGE_ABNORMAL flag. */
186 e
->flags
&= ~EDGE_ABNORMAL
;
188 /* And set EDGE_FALLTHRU. */
189 e
->flags
|= EDGE_FALLTHRU
;
194 bitmap_set_bit (cfgcleanup_altered_bbs
, bb
->index
);
195 bitmap_set_bit (cfgcleanup_altered_bbs
, target_block
->index
);
197 /* Remove the GOTO_EXPR as it is not needed. The CFG has all the
198 relevant information we need. */
199 gsi_remove (&gsi
, true);
203 /* Check for indirect calls that have been turned into
205 else if (is_gimple_call (stmt
)
206 && gimple_call_noreturn_p (stmt
)
207 && remove_fallthru_edge (bb
->succs
))
213 /* Return true if basic block BB does nothing except pass control
214 flow to another block and that we can safely insert a label at
215 the start of the successor block.
217 As a precondition, we require that BB be not equal to
221 tree_forwarder_block_p (basic_block bb
, bool phi_wanted
)
223 gimple_stmt_iterator gsi
;
228 /* BB must have a single outgoing edge. */
229 if (single_succ_p (bb
) != 1
230 /* If PHI_WANTED is false, BB must not have any PHI nodes.
231 Otherwise, BB must have PHI nodes. */
232 || gimple_seq_empty_p (phi_nodes (bb
)) == phi_wanted
233 /* BB may not be a predecessor of EXIT_BLOCK_PTR. */
234 || single_succ (bb
) == EXIT_BLOCK_PTR
235 /* Nor should this be an infinite loop. */
236 || single_succ (bb
) == bb
237 /* BB may not have an abnormal outgoing edge. */
238 || (single_succ_edge (bb
)->flags
& EDGE_ABNORMAL
))
242 gcc_assert (bb
!= ENTRY_BLOCK_PTR
);
245 /* Now walk through the statements backward. We can ignore labels,
246 anything else means this is not a forwarder block. */
247 for (gsi
= gsi_last_bb (bb
); !gsi_end_p (gsi
); gsi_prev (&gsi
))
249 gimple stmt
= gsi_stmt (gsi
);
251 switch (gimple_code (stmt
))
254 if (DECL_NONLOCAL (gimple_label_label (stmt
)))
263 if (find_edge (ENTRY_BLOCK_PTR
, bb
))
269 /* Protect loop latches, headers and preheaders. */
270 if (bb
->loop_father
->header
== bb
)
272 dest
= EDGE_SUCC (bb
, 0)->dest
;
274 if (dest
->loop_father
->header
== dest
)
278 /* If we have an EH edge leaving this block, make sure that the
279 destination of this block has only one predecessor. This ensures
280 that we don't get into the situation where we try to remove two
281 forwarders that go to the same basic block but are handlers for
282 different EH regions. */
283 succ
= single_succ_edge (bb
);
285 FOR_EACH_EDGE (e
, ei
, bb
->preds
)
287 if (e
->flags
& EDGE_EH
)
289 if (!single_pred_p (dest
))
297 /* Return true if BB has at least one abnormal incoming edge. */
300 has_abnormal_incoming_edge_p (basic_block bb
)
305 FOR_EACH_EDGE (e
, ei
, bb
->preds
)
306 if (e
->flags
& EDGE_ABNORMAL
)
312 /* If all the PHI nodes in DEST have alternatives for E1 and E2 and
313 those alternatives are equal in each of the PHI nodes, then return
314 true, else return false. */
317 phi_alternatives_equal (basic_block dest
, edge e1
, edge e2
)
319 int n1
= e1
->dest_idx
;
320 int n2
= e2
->dest_idx
;
321 gimple_stmt_iterator gsi
;
323 for (gsi
= gsi_start_phis (dest
); !gsi_end_p (gsi
); gsi_next (&gsi
))
325 gimple phi
= gsi_stmt (gsi
);
326 tree val1
= gimple_phi_arg_def (phi
, n1
);
327 tree val2
= gimple_phi_arg_def (phi
, n2
);
329 gcc_assert (val1
!= NULL_TREE
);
330 gcc_assert (val2
!= NULL_TREE
);
332 if (!operand_equal_for_phi_arg_p (val1
, val2
))
339 /* Removes forwarder block BB. Returns false if this failed. */
342 remove_forwarder_block (basic_block bb
)
344 edge succ
= single_succ_edge (bb
), e
, s
;
345 basic_block dest
= succ
->dest
;
348 gimple_stmt_iterator gsi
, gsi_to
;
349 bool seen_abnormal_edge
= false;
351 /* We check for infinite loops already in tree_forwarder_block_p.
352 However it may happen that the infinite loop is created
353 afterwards due to removal of forwarders. */
357 /* If the destination block consists of a nonlocal label, do not merge
359 label
= first_stmt (dest
);
361 && gimple_code (label
) == GIMPLE_LABEL
362 && DECL_NONLOCAL (gimple_label_label (label
)))
365 /* If there is an abnormal edge to basic block BB, but not into
366 dest, problems might occur during removal of the phi node at out
367 of ssa due to overlapping live ranges of registers.
369 If there is an abnormal edge in DEST, the problems would occur
370 anyway since cleanup_dead_labels would then merge the labels for
371 two different eh regions, and rest of exception handling code
374 So if there is an abnormal edge to BB, proceed only if there is
375 no abnormal edge to DEST and there are no phi nodes in DEST. */
376 if (has_abnormal_incoming_edge_p (bb
))
378 seen_abnormal_edge
= true;
380 if (has_abnormal_incoming_edge_p (dest
)
381 || !gimple_seq_empty_p (phi_nodes (dest
)))
385 /* If there are phi nodes in DEST, and some of the blocks that are
386 predecessors of BB are also predecessors of DEST, check that the
387 phi node arguments match. */
388 if (!gimple_seq_empty_p (phi_nodes (dest
)))
390 FOR_EACH_EDGE (e
, ei
, bb
->preds
)
392 s
= find_edge (e
->src
, dest
);
396 if (!phi_alternatives_equal (dest
, succ
, s
))
401 /* Redirect the edges. */
402 for (ei
= ei_start (bb
->preds
); (e
= ei_safe_edge (ei
)); )
404 bitmap_set_bit (cfgcleanup_altered_bbs
, e
->src
->index
);
406 if (e
->flags
& EDGE_ABNORMAL
)
408 /* If there is an abnormal edge, redirect it anyway, and
409 move the labels to the new block to make it legal. */
410 s
= redirect_edge_succ_nodup (e
, dest
);
413 s
= redirect_edge_and_branch (e
, dest
);
417 /* Create arguments for the phi nodes, since the edge was not
419 for (gsi
= gsi_start_phis (dest
);
423 gimple phi
= gsi_stmt (gsi
);
424 add_phi_arg (phi
, gimple_phi_arg_def (phi
, succ
->dest_idx
), s
);
429 if (seen_abnormal_edge
)
431 /* Move the labels to the new block, so that the redirection of
432 the abnormal edges works. */
433 gsi_to
= gsi_start_bb (dest
);
434 for (gsi
= gsi_start_bb (bb
); !gsi_end_p (gsi
); )
436 label
= gsi_stmt (gsi
);
437 gcc_assert (gimple_code (label
) == GIMPLE_LABEL
);
438 gsi_remove (&gsi
, false);
439 gsi_insert_before (&gsi_to
, label
, GSI_CONTINUE_LINKING
);
443 bitmap_set_bit (cfgcleanup_altered_bbs
, dest
->index
);
445 /* Update the dominators. */
446 if (dom_info_available_p (CDI_DOMINATORS
))
448 basic_block dom
, dombb
, domdest
;
450 dombb
= get_immediate_dominator (CDI_DOMINATORS
, bb
);
451 domdest
= get_immediate_dominator (CDI_DOMINATORS
, dest
);
454 /* Shortcut to avoid calling (relatively expensive)
455 nearest_common_dominator unless necessary. */
459 dom
= nearest_common_dominator (CDI_DOMINATORS
, domdest
, dombb
);
461 set_immediate_dominator (CDI_DOMINATORS
, dest
, dom
);
464 /* And kill the forwarder block. */
465 delete_basic_block (bb
);
470 /* Split basic blocks on calls in the middle of a basic block that are now
471 known not to return, and remove the unreachable code. */
474 split_bbs_on_noreturn_calls (void)
476 bool changed
= false;
480 /* Detect cases where a mid-block call is now known not to return. */
482 while (VEC_length (gimple
, MODIFIED_NORETURN_CALLS (cfun
)))
484 stmt
= VEC_pop (gimple
, MODIFIED_NORETURN_CALLS (cfun
));
485 bb
= gimple_bb (stmt
);
487 || last_stmt (bb
) == stmt
488 || !gimple_call_noreturn_p (stmt
))
492 split_block (bb
, stmt
);
493 remove_fallthru_edge (bb
->succs
);
499 /* If GIMPLE_OMP_RETURN in basic block BB is unreachable, remove it. */
502 cleanup_omp_return (basic_block bb
)
504 gimple stmt
= last_stmt (bb
);
505 basic_block control_bb
;
508 || gimple_code (stmt
) != GIMPLE_OMP_RETURN
509 || !single_pred_p (bb
))
512 control_bb
= single_pred (bb
);
513 stmt
= last_stmt (control_bb
);
515 if (gimple_code (stmt
) != GIMPLE_OMP_SECTIONS_SWITCH
)
518 /* The block with the control statement normally has two entry edges -- one
519 from entry, one from continue. If continue is removed, return is
520 unreachable, so we remove it here as well. */
521 if (EDGE_COUNT (control_bb
->preds
) == 2)
524 gcc_assert (EDGE_COUNT (control_bb
->preds
) == 1);
525 remove_edge_and_dominated_blocks (single_pred_edge (bb
));
529 /* Tries to cleanup cfg in basic block BB. Returns true if anything
533 cleanup_tree_cfg_bb (basic_block bb
)
537 if (cleanup_omp_return (bb
))
540 retval
= cleanup_control_flow_bb (bb
);
542 /* Forwarder blocks can carry line number information which is
543 useful when debugging, so we only clean them up when
546 && tree_forwarder_block_p (bb
, false)
547 && remove_forwarder_block (bb
))
550 /* Merging the blocks may create new opportunities for folding
551 conditional branches (due to the elimination of single-valued PHI
553 if (single_succ_p (bb
)
554 && can_merge_blocks_p (bb
, single_succ (bb
)))
556 merge_blocks (bb
, single_succ (bb
));
563 /* Iterate the cfg cleanups, while anything changes. */
566 cleanup_tree_cfg_1 (void)
572 retval
|= split_bbs_on_noreturn_calls ();
574 /* Prepare the worklists of altered blocks. */
575 cfgcleanup_altered_bbs
= BITMAP_ALLOC (NULL
);
577 /* During forwarder block cleanup, we may redirect edges out of
578 SWITCH_EXPRs, which can get expensive. So we want to enable
579 recording of edge to CASE_LABEL_EXPR. */
580 start_recording_case_labels ();
582 /* Start by iterating over all basic blocks. We cannot use FOR_EACH_BB,
583 since the basic blocks may get removed. */
584 n
= last_basic_block
;
585 for (i
= NUM_FIXED_BLOCKS
; i
< n
; i
++)
587 bb
= BASIC_BLOCK (i
);
589 retval
|= cleanup_tree_cfg_bb (bb
);
592 /* Now process the altered blocks, as long as any are available. */
593 while (!bitmap_empty_p (cfgcleanup_altered_bbs
))
595 i
= bitmap_first_set_bit (cfgcleanup_altered_bbs
);
596 bitmap_clear_bit (cfgcleanup_altered_bbs
, i
);
597 if (i
< NUM_FIXED_BLOCKS
)
600 bb
= BASIC_BLOCK (i
);
604 retval
|= cleanup_tree_cfg_bb (bb
);
606 /* Rerun split_bbs_on_noreturn_calls, in case we have altered any noreturn
608 retval
|= split_bbs_on_noreturn_calls ();
611 end_recording_case_labels ();
612 BITMAP_FREE (cfgcleanup_altered_bbs
);
617 /* Remove unreachable blocks and other miscellaneous clean up work.
618 Return true if the flowgraph was modified, false otherwise. */
621 cleanup_tree_cfg_noloop (void)
625 timevar_push (TV_TREE_CLEANUP_CFG
);
627 /* Iterate until there are no more cleanups left to do. If any
628 iteration changed the flowgraph, set CHANGED to true.
630 If dominance information is available, there cannot be any unreachable
632 if (!dom_info_available_p (CDI_DOMINATORS
))
634 changed
= delete_unreachable_blocks ();
635 calculate_dominance_info (CDI_DOMINATORS
);
639 #ifdef ENABLE_CHECKING
640 verify_dominators (CDI_DOMINATORS
);
645 changed
|= cleanup_tree_cfg_1 ();
647 gcc_assert (dom_info_available_p (CDI_DOMINATORS
));
650 #ifdef ENABLE_CHECKING
654 timevar_pop (TV_TREE_CLEANUP_CFG
);
656 if (changed
&& current_loops
)
657 loops_state_set (LOOPS_NEED_FIXUP
);
662 /* Repairs loop structures. */
665 repair_loop_structures (void)
667 bitmap changed_bbs
= BITMAP_ALLOC (NULL
);
668 fix_loop_structure (changed_bbs
);
670 /* This usually does nothing. But sometimes parts of cfg that originally
671 were inside a loop get out of it due to edge removal (since they
672 become unreachable by back edges from latch). */
673 if (loops_state_satisfies_p (LOOP_CLOSED_SSA
))
674 rewrite_into_loop_closed_ssa (changed_bbs
, TODO_update_ssa
);
676 BITMAP_FREE (changed_bbs
);
678 #ifdef ENABLE_CHECKING
679 verify_loop_structure ();
683 loops_state_clear (LOOPS_NEED_FIXUP
);
686 /* Cleanup cfg and repair loop structures. */
689 cleanup_tree_cfg (void)
691 bool changed
= cleanup_tree_cfg_noloop ();
693 if (current_loops
!= NULL
694 && loops_state_satisfies_p (LOOPS_NEED_FIXUP
))
695 repair_loop_structures ();
700 /* Merge the PHI nodes at BB into those at BB's sole successor. */
703 remove_forwarder_block_with_phi (basic_block bb
)
705 edge succ
= single_succ_edge (bb
);
706 basic_block dest
= succ
->dest
;
708 basic_block dombb
, domdest
, dom
;
710 /* We check for infinite loops already in tree_forwarder_block_p.
711 However it may happen that the infinite loop is created
712 afterwards due to removal of forwarders. */
716 /* If the destination block consists of a nonlocal label, do not
718 label
= first_stmt (dest
);
720 && gimple_code (label
) == GIMPLE_LABEL
721 && DECL_NONLOCAL (gimple_label_label (label
)))
724 /* Redirect each incoming edge to BB to DEST. */
725 while (EDGE_COUNT (bb
->preds
) > 0)
727 edge e
= EDGE_PRED (bb
, 0), s
;
728 gimple_stmt_iterator gsi
;
730 s
= find_edge (e
->src
, dest
);
733 /* We already have an edge S from E->src to DEST. If S and
734 E->dest's sole successor edge have the same PHI arguments
735 at DEST, redirect S to DEST. */
736 if (phi_alternatives_equal (dest
, s
, succ
))
738 e
= redirect_edge_and_branch (e
, dest
);
739 redirect_edge_var_map_clear (e
);
743 /* PHI arguments are different. Create a forwarder block by
744 splitting E so that we can merge PHI arguments on E to
746 e
= single_succ_edge (split_edge (e
));
749 s
= redirect_edge_and_branch (e
, dest
);
751 /* redirect_edge_and_branch must not create a new edge. */
754 /* Add to the PHI nodes at DEST each PHI argument removed at the
756 for (gsi
= gsi_start_phis (dest
);
760 gimple phi
= gsi_stmt (gsi
);
761 tree def
= gimple_phi_arg_def (phi
, succ
->dest_idx
);
763 if (TREE_CODE (def
) == SSA_NAME
)
765 edge_var_map_vector head
;
769 /* If DEF is one of the results of PHI nodes removed during
770 redirection, replace it with the PHI argument that used
772 head
= redirect_edge_var_map_vector (e
);
773 for (i
= 0; VEC_iterate (edge_var_map
, head
, i
, vm
); ++i
)
775 tree old_arg
= redirect_edge_var_map_result (vm
);
776 tree new_arg
= redirect_edge_var_map_def (vm
);
786 add_phi_arg (phi
, def
, s
);
789 redirect_edge_var_map_clear (e
);
792 /* Update the dominators. */
793 dombb
= get_immediate_dominator (CDI_DOMINATORS
, bb
);
794 domdest
= get_immediate_dominator (CDI_DOMINATORS
, dest
);
797 /* Shortcut to avoid calling (relatively expensive)
798 nearest_common_dominator unless necessary. */
802 dom
= nearest_common_dominator (CDI_DOMINATORS
, domdest
, dombb
);
804 set_immediate_dominator (CDI_DOMINATORS
, dest
, dom
);
806 /* Remove BB since all of BB's incoming edges have been redirected
808 delete_basic_block (bb
);
811 /* This pass merges PHI nodes if one feeds into another. For example,
812 suppose we have the following:
819 # tem_6 = PHI <tem_17(8), tem_23(7)>;
822 # tem_3 = PHI <tem_6(9), tem_2(5)>;
825 Then we merge the first PHI node into the second one like so:
832 # tem_3 = PHI <tem_23(7), tem_2(5), tem_17(8)>;
837 merge_phi_nodes (void)
839 basic_block
*worklist
= XNEWVEC (basic_block
, n_basic_blocks
);
840 basic_block
*current
= worklist
;
843 calculate_dominance_info (CDI_DOMINATORS
);
845 /* Find all PHI nodes that we may be able to merge. */
850 /* Look for a forwarder block with PHI nodes. */
851 if (!tree_forwarder_block_p (bb
, true))
854 dest
= single_succ (bb
);
856 /* We have to feed into another basic block with PHI
858 if (!phi_nodes (dest
)
859 /* We don't want to deal with a basic block with
861 || has_abnormal_incoming_edge_p (bb
))
864 if (!dominated_by_p (CDI_DOMINATORS
, dest
, bb
))
866 /* If BB does not dominate DEST, then the PHI nodes at
867 DEST must be the only users of the results of the PHI
873 gimple_stmt_iterator gsi
;
874 unsigned int dest_idx
= single_succ_edge (bb
)->dest_idx
;
876 /* BB dominates DEST. There may be many users of the PHI
877 nodes in BB. However, there is still a trivial case we
878 can handle. If the result of every PHI in BB is used
879 only by a PHI in DEST, then we can trivially merge the
880 PHI nodes from BB into DEST. */
881 for (gsi
= gsi_start_phis (bb
); !gsi_end_p (gsi
);
884 gimple phi
= gsi_stmt (gsi
);
885 tree result
= gimple_phi_result (phi
);
886 use_operand_p imm_use
;
889 /* If the PHI's result is never used, then we can just
891 if (has_zero_uses (result
))
894 /* Get the single use of the result of this PHI node. */
895 if (!single_imm_use (result
, &imm_use
, &use_stmt
)
896 || gimple_code (use_stmt
) != GIMPLE_PHI
897 || gimple_bb (use_stmt
) != dest
898 || gimple_phi_arg_def (use_stmt
, dest_idx
) != result
)
902 /* If the loop above iterated through all the PHI nodes
903 in BB, then we can merge the PHIs from BB into DEST. */
909 /* Now let's drain WORKLIST. */
910 while (current
!= worklist
)
913 remove_forwarder_block_with_phi (bb
);
921 gate_merge_phi (void)
926 struct gimple_opt_pass pass_merge_phi
=
930 "mergephi", /* name */
931 gate_merge_phi
, /* gate */
932 merge_phi_nodes
, /* execute */
935 0, /* static_pass_number */
936 TV_TREE_MERGE_PHI
, /* tv_id */
937 PROP_cfg
| PROP_ssa
, /* properties_required */
938 0, /* properties_provided */
939 0, /* properties_destroyed */
940 0, /* todo_flags_start */
941 TODO_dump_func
| TODO_ggc_collect
/* todo_flags_finish */