1 /* Predicate aware uninitialized variable warning.
2 Copyright (C) 2001-2017 Free Software Foundation, Inc.
3 Contributed by Xinliang David Li <davidxl@google.com>
5 This file is part of GCC.
7 GCC is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by
9 the Free Software Foundation; either version 3, or (at your option)
12 GCC is distributed in the hope that it will be useful,
13 but WITHOUT ANY WARRANTY; without even the implied warranty of
14 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 GNU General Public License for more details.
17 You should have received a copy of the GNU General Public License
18 along with GCC; see the file COPYING3. If not see
19 <http://www.gnu.org/licenses/>. */
23 #include "coretypes.h"
27 #include "tree-pass.h"
29 #include "gimple-pretty-print.h"
30 #include "diagnostic-core.h"
31 #include "fold-const.h"
32 #include "gimple-iterator.h"
37 /* This implements the pass that does predicate aware warning on uses of
38 possibly uninitialized variables. The pass first collects the set of
39 possibly uninitialized SSA names. For each such name, it walks through
40 all its immediate uses. For each immediate use, it rebuilds the condition
41 expression (the predicate) that guards the use. The predicate is then
42 examined to see if the variable is always defined under that same condition.
43 This is done either by pruning the unrealizable paths that lead to the
44 default definitions or by checking if the predicate set that guards the
45 defining paths is a superset of the use predicate. */
47 /* Max PHI args we can handle in pass. */
48 const unsigned max_phi_args
= 32;
50 /* Pointer set of potentially undefined ssa names, i.e.,
51 ssa names that are defined by phi with operands that
52 are not defined or potentially undefined. */
53 static hash_set
<tree
> *possibly_undefined_names
= 0;
55 /* Bit mask handling macros. */
56 #define MASK_SET_BIT(mask, pos) mask |= (1 << pos)
57 #define MASK_TEST_BIT(mask, pos) (mask & (1 << pos))
58 #define MASK_EMPTY(mask) (mask == 0)
60 /* Returns the first bit position (starting from LSB)
61 in mask that is non zero. Returns -1 if the mask is empty. */
63 get_mask_first_set_bit (unsigned mask
)
69 while ((mask
& (1 << pos
)) == 0)
74 #define MASK_FIRST_SET_BIT(mask) get_mask_first_set_bit (mask)
76 /* Return true if T, an SSA_NAME, has an undefined value. */
78 has_undefined_value_p (tree t
)
80 return (ssa_undefined_value_p (t
)
81 || (possibly_undefined_names
82 && possibly_undefined_names
->contains (t
)));
85 /* Like has_undefined_value_p, but don't return true if TREE_NO_WARNING
86 is set on SSA_NAME_VAR. */
89 uninit_undefined_value_p (tree t
)
91 if (!has_undefined_value_p (t
))
93 if (SSA_NAME_VAR (t
) && TREE_NO_WARNING (SSA_NAME_VAR (t
)))
98 /* Emit warnings for uninitialized variables. This is done in two passes.
100 The first pass notices real uses of SSA names with undefined values.
101 Such uses are unconditionally uninitialized, and we can be certain that
102 such a use is a mistake. This pass is run before most optimizations,
103 so that we catch as many as we can.
105 The second pass follows PHI nodes to find uses that are potentially
106 uninitialized. In this case we can't necessarily prove that the use
107 is really uninitialized. This pass is run after most optimizations,
108 so that we thread as many jumps and possible, and delete as much dead
109 code as possible, in order to reduce false positives. We also look
110 again for plain uninitialized variables, since optimization may have
111 changed conditionally uninitialized to unconditionally uninitialized. */
113 /* Emit a warning for EXPR based on variable VAR at the point in the
114 program T, an SSA_NAME, is used being uninitialized. The exact
115 warning text is in MSGID and DATA is the gimple stmt with info about
116 the location in source code. When DATA is a GIMPLE_PHI, PHIARG_IDX
117 gives which argument of the phi node to take the location from. WC
118 is the warning code. */
121 warn_uninit (enum opt_code wc
, tree t
, tree expr
, tree var
,
122 const char *gmsgid
, void *data
, location_t phiarg_loc
)
124 gimple
*context
= (gimple
*) data
;
125 location_t location
, cfun_loc
;
126 expanded_location xloc
, floc
;
128 /* Ignore COMPLEX_EXPR as initializing only a part of a complex
129 turns in a COMPLEX_EXPR with the not initialized part being
130 set to its previous (undefined) value. */
131 if (is_gimple_assign (context
)
132 && gimple_assign_rhs_code (context
) == COMPLEX_EXPR
)
134 if (!has_undefined_value_p (t
))
137 /* Anonymous SSA_NAMEs shouldn't be uninitialized, but ssa_undefined_value_p
138 can return true if the def stmt of anonymous SSA_NAME is COMPLEX_EXPR
139 created for conversion from scalar to complex. Use the underlying var of
140 the COMPLEX_EXPRs real part in that case. See PR71581. */
141 if (expr
== NULL_TREE
143 && SSA_NAME_VAR (t
) == NULL_TREE
144 && is_gimple_assign (SSA_NAME_DEF_STMT (t
))
145 && gimple_assign_rhs_code (SSA_NAME_DEF_STMT (t
)) == COMPLEX_EXPR
)
147 tree v
= gimple_assign_rhs1 (SSA_NAME_DEF_STMT (t
));
148 if (TREE_CODE (v
) == SSA_NAME
149 && has_undefined_value_p (v
)
150 && zerop (gimple_assign_rhs2 (SSA_NAME_DEF_STMT (t
))))
152 expr
= SSA_NAME_VAR (v
);
157 if (expr
== NULL_TREE
)
160 /* TREE_NO_WARNING either means we already warned, or the front end
161 wishes to suppress the warning. */
163 && (gimple_no_warning_p (context
)
164 || (gimple_assign_single_p (context
)
165 && TREE_NO_WARNING (gimple_assign_rhs1 (context
)))))
166 || TREE_NO_WARNING (expr
))
169 if (context
!= NULL
&& gimple_has_location (context
))
170 location
= gimple_location (context
);
171 else if (phiarg_loc
!= UNKNOWN_LOCATION
)
172 location
= phiarg_loc
;
174 location
= DECL_SOURCE_LOCATION (var
);
175 location
= linemap_resolve_location (line_table
, location
,
176 LRK_SPELLING_LOCATION
, NULL
);
177 cfun_loc
= DECL_SOURCE_LOCATION (cfun
->decl
);
178 xloc
= expand_location (location
);
179 floc
= expand_location (cfun_loc
);
180 if (warning_at (location
, wc
, gmsgid
, expr
))
182 TREE_NO_WARNING (expr
) = 1;
184 if (location
== DECL_SOURCE_LOCATION (var
))
186 if (xloc
.file
!= floc
.file
187 || linemap_location_before_p (line_table
, location
, cfun_loc
)
188 || linemap_location_before_p (line_table
, cfun
->function_end_locus
,
190 inform (DECL_SOURCE_LOCATION (var
), "%qD was declared here", var
);
194 struct check_defs_data
196 /* If we found any may-defs besides must-def clobbers. */
200 /* Callback for walk_aliased_vdefs. */
203 check_defs (ao_ref
*ref
, tree vdef
, void *data_
)
205 check_defs_data
*data
= (check_defs_data
*)data_
;
206 gimple
*def_stmt
= SSA_NAME_DEF_STMT (vdef
);
207 /* If this is a clobber then if it is not a kill walk past it. */
208 if (gimple_clobber_p (def_stmt
))
210 if (stmt_kills_ref_p (def_stmt
, ref
))
214 /* Found a may-def on this path. */
215 data
->found_may_defs
= true;
220 warn_uninitialized_vars (bool warn_possibly_uninitialized
)
222 gimple_stmt_iterator gsi
;
224 unsigned int vdef_cnt
= 0;
225 unsigned int oracle_cnt
= 0;
228 FOR_EACH_BB_FN (bb
, cfun
)
230 basic_block succ
= single_succ (ENTRY_BLOCK_PTR_FOR_FN (cfun
));
231 bool always_executed
= dominated_by_p (CDI_POST_DOMINATORS
, succ
, bb
);
232 for (gsi
= gsi_start_bb (bb
); !gsi_end_p (gsi
); gsi_next (&gsi
))
234 gimple
*stmt
= gsi_stmt (gsi
);
239 if (is_gimple_debug (stmt
))
242 /* We only do data flow with SSA_NAMEs, so that's all we
244 FOR_EACH_SSA_USE_OPERAND (use_p
, stmt
, op_iter
, SSA_OP_USE
)
246 /* BIT_INSERT_EXPR first operand should not be considered
247 a use for the purpose of uninit warnings. */
248 if (gassign
*ass
= dyn_cast
<gassign
*> (stmt
))
250 if (gimple_assign_rhs_code (ass
) == BIT_INSERT_EXPR
251 && use_p
->use
== gimple_assign_rhs1_ptr (ass
))
254 use
= USE_FROM_PTR (use_p
);
256 warn_uninit (OPT_Wuninitialized
, use
, SSA_NAME_VAR (use
),
258 "%qD is used uninitialized in this function", stmt
,
260 else if (warn_possibly_uninitialized
)
261 warn_uninit (OPT_Wmaybe_uninitialized
, use
, SSA_NAME_VAR (use
),
263 "%qD may be used uninitialized in this function",
264 stmt
, UNKNOWN_LOCATION
);
267 /* For limiting the alias walk below we count all
268 vdefs in the function. */
269 if (gimple_vdef (stmt
))
272 if (gimple_assign_load_p (stmt
)
273 && gimple_has_location (stmt
))
275 tree rhs
= gimple_assign_rhs1 (stmt
);
276 tree lhs
= gimple_assign_lhs (stmt
);
277 bool has_bit_insert
= false;
278 use_operand_p luse_p
;
279 imm_use_iterator liter
;
281 if (TREE_NO_WARNING (rhs
))
285 ao_ref_init (&ref
, rhs
);
287 /* Do not warn if the base was marked so or this is a
288 hard register var. */
289 tree base
= ao_ref_base (&ref
);
291 && DECL_HARD_REGISTER (base
))
292 || TREE_NO_WARNING (base
))
295 /* Do not warn if the access is fully outside of the
299 && ((ref
.max_size
== ref
.size
300 && ref
.offset
+ ref
.size
<= 0)
303 && TREE_CODE (DECL_SIZE (base
)) == INTEGER_CST
304 && compare_tree_int (DECL_SIZE (base
),
308 /* Do not warn if the access is then used for a BIT_INSERT_EXPR. */
309 if (TREE_CODE (lhs
) == SSA_NAME
)
310 FOR_EACH_IMM_USE_FAST (luse_p
, liter
, lhs
)
312 gimple
*use_stmt
= USE_STMT (luse_p
);
313 /* BIT_INSERT_EXPR first operand should not be considered
314 a use for the purpose of uninit warnings. */
315 if (gassign
*ass
= dyn_cast
<gassign
*> (use_stmt
))
317 if (gimple_assign_rhs_code (ass
) == BIT_INSERT_EXPR
318 && luse_p
->use
== gimple_assign_rhs1_ptr (ass
))
320 has_bit_insert
= true;
328 /* Limit the walking to a constant number of stmts after
329 we overcommit quadratic behavior for small functions
330 and O(n) behavior. */
331 if (oracle_cnt
> 128 * 128
332 && oracle_cnt
> vdef_cnt
* 2)
334 check_defs_data data
;
335 bool fentry_reached
= false;
336 data
.found_may_defs
= false;
337 use
= gimple_vuse (stmt
);
338 int res
= walk_aliased_vdefs (&ref
, use
,
339 check_defs
, &data
, NULL
,
340 &fentry_reached
, limit
);
347 if (data
.found_may_defs
)
349 /* Do not warn if it can be initialized outside this function.
350 If we did not reach function entry then we found killing
351 clobbers on all paths to entry. */
353 /* ??? We'd like to use ref_may_alias_global_p but that
354 excludes global readonly memory and thus we get bougs
355 warnings from p = cond ? "a" : "b" for example. */
357 || is_global_var (base
)))
360 /* We didn't find any may-defs so on all paths either
361 reached function entry or a killing clobber. */
363 = linemap_resolve_location (line_table
, gimple_location (stmt
),
364 LRK_SPELLING_LOCATION
, NULL
);
367 if (warning_at (location
, OPT_Wuninitialized
,
368 "%qE is used uninitialized in this function",
370 /* ??? This is only effective for decls as in
371 gcc.dg/uninit-B-O0.c. Avoid doing this for
372 maybe-uninit uses as it may hide important
374 TREE_NO_WARNING (rhs
) = 1;
376 else if (warn_possibly_uninitialized
)
377 warning_at (location
, OPT_Wmaybe_uninitialized
,
378 "%qE may be used uninitialized in this function",
387 /* Checks if the operand OPND of PHI is defined by
388 another phi with one operand defined by this PHI,
389 but the rest operands are all defined. If yes,
390 returns true to skip this operand as being
391 redundant. Can be enhanced to be more general. */
394 can_skip_redundant_opnd (tree opnd
, gimple
*phi
)
400 phi_def
= gimple_phi_result (phi
);
401 op_def
= SSA_NAME_DEF_STMT (opnd
);
402 if (gimple_code (op_def
) != GIMPLE_PHI
)
404 n
= gimple_phi_num_args (op_def
);
405 for (i
= 0; i
< n
; ++i
)
407 tree op
= gimple_phi_arg_def (op_def
, i
);
408 if (TREE_CODE (op
) != SSA_NAME
)
410 if (op
!= phi_def
&& uninit_undefined_value_p (op
))
417 /* Returns a bit mask holding the positions of arguments in PHI
418 that have empty (or possibly empty) definitions. */
421 compute_uninit_opnds_pos (gphi
*phi
)
424 unsigned uninit_opnds
= 0;
426 n
= gimple_phi_num_args (phi
);
427 /* Bail out for phi with too many args. */
428 if (n
> max_phi_args
)
431 for (i
= 0; i
< n
; ++i
)
433 tree op
= gimple_phi_arg_def (phi
, i
);
434 if (TREE_CODE (op
) == SSA_NAME
435 && uninit_undefined_value_p (op
)
436 && !can_skip_redundant_opnd (op
, phi
))
438 if (cfun
->has_nonlocal_label
|| cfun
->calls_setjmp
)
440 /* Ignore SSA_NAMEs that appear on abnormal edges
442 if (SSA_NAME_OCCURS_IN_ABNORMAL_PHI (op
))
445 MASK_SET_BIT (uninit_opnds
, i
);
451 /* Find the immediate postdominator PDOM of the specified
452 basic block BLOCK. */
454 static inline basic_block
455 find_pdom (basic_block block
)
457 if (block
== EXIT_BLOCK_PTR_FOR_FN (cfun
))
458 return EXIT_BLOCK_PTR_FOR_FN (cfun
);
461 basic_block bb
= get_immediate_dominator (CDI_POST_DOMINATORS
, block
);
463 return EXIT_BLOCK_PTR_FOR_FN (cfun
);
468 /* Find the immediate DOM of the specified basic block BLOCK. */
470 static inline basic_block
471 find_dom (basic_block block
)
473 if (block
== ENTRY_BLOCK_PTR_FOR_FN (cfun
))
474 return ENTRY_BLOCK_PTR_FOR_FN (cfun
);
477 basic_block bb
= get_immediate_dominator (CDI_DOMINATORS
, block
);
479 return ENTRY_BLOCK_PTR_FOR_FN (cfun
);
484 /* Returns true if BB1 is postdominating BB2 and BB1 is
485 not a loop exit bb. The loop exit bb check is simple and does
486 not cover all cases. */
489 is_non_loop_exit_postdominating (basic_block bb1
, basic_block bb2
)
491 if (!dominated_by_p (CDI_POST_DOMINATORS
, bb2
, bb1
))
494 if (single_pred_p (bb1
) && !single_succ_p (bb2
))
500 /* Find the closest postdominator of a specified BB, which is control
503 static inline basic_block
504 find_control_equiv_block (basic_block bb
)
508 pdom
= find_pdom (bb
);
510 /* Skip the postdominating bb that is also loop exit. */
511 if (!is_non_loop_exit_postdominating (pdom
, bb
))
514 if (dominated_by_p (CDI_DOMINATORS
, pdom
, bb
))
520 #define MAX_NUM_CHAINS 8
521 #define MAX_CHAIN_LEN 5
522 #define MAX_POSTDOM_CHECK 8
523 #define MAX_SWITCH_CASES 40
525 /* Computes the control dependence chains (paths of edges)
526 for DEP_BB up to the dominating basic block BB (the head node of a
527 chain should be dominated by it). CD_CHAINS is pointer to an
528 array holding the result chains. CUR_CD_CHAIN is the current
529 chain being computed. *NUM_CHAINS is total number of chains. The
530 function returns true if the information is successfully computed,
531 return false if there is no control dependence or not computed. */
534 compute_control_dep_chain (basic_block bb
, basic_block dep_bb
,
535 vec
<edge
> *cd_chains
,
537 vec
<edge
> *cur_cd_chain
,
543 bool found_cd_chain
= false;
544 size_t cur_chain_len
= 0;
546 if (EDGE_COUNT (bb
->succs
) < 2)
549 if (*num_calls
> PARAM_VALUE (PARAM_UNINIT_CONTROL_DEP_ATTEMPTS
))
553 /* Could use a set instead. */
554 cur_chain_len
= cur_cd_chain
->length ();
555 if (cur_chain_len
> MAX_CHAIN_LEN
)
558 for (i
= 0; i
< cur_chain_len
; i
++)
560 edge e
= (*cur_cd_chain
)[i
];
561 /* Cycle detected. */
566 FOR_EACH_EDGE (e
, ei
, bb
->succs
)
569 int post_dom_check
= 0;
570 if (e
->flags
& (EDGE_FAKE
| EDGE_ABNORMAL
))
574 cur_cd_chain
->safe_push (e
);
575 while (!is_non_loop_exit_postdominating (cd_bb
, bb
))
579 /* Found a direct control dependence. */
580 if (*num_chains
< MAX_NUM_CHAINS
)
582 cd_chains
[*num_chains
] = cur_cd_chain
->copy ();
585 found_cd_chain
= true;
586 /* Check path from next edge. */
590 /* Now check if DEP_BB is indirectly control dependent on BB. */
591 if (compute_control_dep_chain (cd_bb
, dep_bb
, cd_chains
, num_chains
,
592 cur_cd_chain
, num_calls
))
594 found_cd_chain
= true;
598 cd_bb
= find_pdom (cd_bb
);
600 if (cd_bb
== EXIT_BLOCK_PTR_FOR_FN (cfun
)
601 || post_dom_check
> MAX_POSTDOM_CHECK
)
604 cur_cd_chain
->pop ();
605 gcc_assert (cur_cd_chain
->length () == cur_chain_len
);
607 gcc_assert (cur_cd_chain
->length () == cur_chain_len
);
609 return found_cd_chain
;
612 /* The type to represent a simple predicate. */
618 enum tree_code cond_code
;
622 /* The type to represent a sequence of predicates grouped
623 with .AND. operation. */
625 typedef vec
<pred_info
, va_heap
, vl_ptr
> pred_chain
;
627 /* The type to represent a sequence of pred_chains grouped
628 with .OR. operation. */
630 typedef vec
<pred_chain
, va_heap
, vl_ptr
> pred_chain_union
;
632 /* Converts the chains of control dependence edges into a set of
633 predicates. A control dependence chain is represented by a vector
634 edges. DEP_CHAINS points to an array of dependence chains.
635 NUM_CHAINS is the size of the chain array. One edge in a dependence
636 chain is mapped to predicate expression represented by pred_info
637 type. One dependence chain is converted to a composite predicate that
638 is the result of AND operation of pred_info mapped to each edge.
639 A composite predicate is presented by a vector of pred_info. On
640 return, *PREDS points to the resulting array of composite predicates.
641 *NUM_PREDS is the number of composite predictes. */
644 convert_control_dep_chain_into_preds (vec
<edge
> *dep_chains
,
646 pred_chain_union
*preds
)
648 bool has_valid_pred
= false;
650 if (num_chains
== 0 || num_chains
>= MAX_NUM_CHAINS
)
653 /* Now convert the control dep chain into a set
655 preds
->reserve (num_chains
);
657 for (i
= 0; i
< num_chains
; i
++)
659 vec
<edge
> one_cd_chain
= dep_chains
[i
];
661 has_valid_pred
= false;
662 pred_chain t_chain
= vNULL
;
663 for (j
= 0; j
< one_cd_chain
.length (); j
++)
666 gimple_stmt_iterator gsi
;
667 basic_block guard_bb
;
673 gsi
= gsi_last_bb (guard_bb
);
676 has_valid_pred
= false;
679 cond_stmt
= gsi_stmt (gsi
);
680 if (is_gimple_call (cond_stmt
) && EDGE_COUNT (e
->src
->succs
) >= 2)
681 /* Ignore EH edge. Can add assertion on the other edge's flag. */
683 /* Skip if there is essentially one succesor. */
684 if (EDGE_COUNT (e
->src
->succs
) == 2)
690 FOR_EACH_EDGE (e1
, ei1
, e
->src
->succs
)
692 if (EDGE_COUNT (e1
->dest
->succs
) == 0)
701 if (gimple_code (cond_stmt
) == GIMPLE_COND
)
703 one_pred
.pred_lhs
= gimple_cond_lhs (cond_stmt
);
704 one_pred
.pred_rhs
= gimple_cond_rhs (cond_stmt
);
705 one_pred
.cond_code
= gimple_cond_code (cond_stmt
);
706 one_pred
.invert
= !!(e
->flags
& EDGE_FALSE_VALUE
);
707 t_chain
.safe_push (one_pred
);
708 has_valid_pred
= true;
710 else if (gswitch
*gs
= dyn_cast
<gswitch
*> (cond_stmt
))
712 /* Avoid quadratic behavior. */
713 if (gimple_switch_num_labels (gs
) > MAX_SWITCH_CASES
)
715 has_valid_pred
= false;
718 /* Find the case label. */
721 for (idx
= 0; idx
< gimple_switch_num_labels (gs
); ++idx
)
723 tree tl
= gimple_switch_label (gs
, idx
);
724 if (e
->dest
== label_to_block (CASE_LABEL (tl
)))
735 /* If more than one label reaches this block or the case
736 label doesn't have a single value (like the default one)
741 && !operand_equal_p (CASE_LOW (l
), CASE_HIGH (l
), 0)))
743 has_valid_pred
= false;
746 one_pred
.pred_lhs
= gimple_switch_index (gs
);
747 one_pred
.pred_rhs
= CASE_LOW (l
);
748 one_pred
.cond_code
= EQ_EXPR
;
749 one_pred
.invert
= false;
750 t_chain
.safe_push (one_pred
);
751 has_valid_pred
= true;
755 has_valid_pred
= false;
763 preds
->safe_push (t_chain
);
765 return has_valid_pred
;
768 /* Computes all control dependence chains for USE_BB. The control
769 dependence chains are then converted to an array of composite
770 predicates pointed to by PREDS. PHI_BB is the basic block of
771 the phi whose result is used in USE_BB. */
774 find_predicates (pred_chain_union
*preds
,
778 size_t num_chains
= 0, i
;
780 vec
<edge
> dep_chains
[MAX_NUM_CHAINS
];
781 auto_vec
<edge
, MAX_CHAIN_LEN
+ 1> cur_chain
;
782 bool has_valid_pred
= false;
783 basic_block cd_root
= 0;
785 /* First find the closest bb that is control equivalent to PHI_BB
786 that also dominates USE_BB. */
788 while (dominated_by_p (CDI_DOMINATORS
, use_bb
, cd_root
))
790 basic_block ctrl_eq_bb
= find_control_equiv_block (cd_root
);
791 if (ctrl_eq_bb
&& dominated_by_p (CDI_DOMINATORS
, use_bb
, ctrl_eq_bb
))
792 cd_root
= ctrl_eq_bb
;
797 compute_control_dep_chain (cd_root
, use_bb
, dep_chains
, &num_chains
,
798 &cur_chain
, &num_calls
);
801 = convert_control_dep_chain_into_preds (dep_chains
, num_chains
, preds
);
802 for (i
= 0; i
< num_chains
; i
++)
803 dep_chains
[i
].release ();
804 return has_valid_pred
;
807 /* Computes the set of incoming edges of PHI that have non empty
808 definitions of a phi chain. The collection will be done
809 recursively on operands that are defined by phis. CD_ROOT
810 is the control dependence root. *EDGES holds the result, and
811 VISITED_PHIS is a pointer set for detecting cycles. */
814 collect_phi_def_edges (gphi
*phi
, basic_block cd_root
,
815 auto_vec
<edge
> *edges
,
816 hash_set
<gimple
*> *visited_phis
)
822 if (visited_phis
->add (phi
))
825 n
= gimple_phi_num_args (phi
);
826 for (i
= 0; i
< n
; i
++)
828 opnd_edge
= gimple_phi_arg_edge (phi
, i
);
829 opnd
= gimple_phi_arg_def (phi
, i
);
831 if (TREE_CODE (opnd
) != SSA_NAME
)
833 if (dump_file
&& (dump_flags
& TDF_DETAILS
))
835 fprintf (dump_file
, "\n[CHECK] Found def edge %d in ", (int) i
);
836 print_gimple_stmt (dump_file
, phi
, 0);
838 edges
->safe_push (opnd_edge
);
842 gimple
*def
= SSA_NAME_DEF_STMT (opnd
);
844 if (gimple_code (def
) == GIMPLE_PHI
845 && dominated_by_p (CDI_DOMINATORS
, gimple_bb (def
), cd_root
))
846 collect_phi_def_edges (as_a
<gphi
*> (def
), cd_root
, edges
,
848 else if (!uninit_undefined_value_p (opnd
))
850 if (dump_file
&& (dump_flags
& TDF_DETAILS
))
852 fprintf (dump_file
, "\n[CHECK] Found def edge %d in ",
854 print_gimple_stmt (dump_file
, phi
, 0);
856 edges
->safe_push (opnd_edge
);
862 /* For each use edge of PHI, computes all control dependence chains.
863 The control dependence chains are then converted to an array of
864 composite predicates pointed to by PREDS. */
867 find_def_preds (pred_chain_union
*preds
, gphi
*phi
)
869 size_t num_chains
= 0, i
, n
;
870 vec
<edge
> dep_chains
[MAX_NUM_CHAINS
];
871 auto_vec
<edge
, MAX_CHAIN_LEN
+ 1> cur_chain
;
872 auto_vec
<edge
> def_edges
;
873 bool has_valid_pred
= false;
874 basic_block phi_bb
, cd_root
= 0;
876 phi_bb
= gimple_bb (phi
);
877 /* First find the closest dominating bb to be
878 the control dependence root. */
879 cd_root
= find_dom (phi_bb
);
883 hash_set
<gimple
*> visited_phis
;
884 collect_phi_def_edges (phi
, cd_root
, &def_edges
, &visited_phis
);
886 n
= def_edges
.length ();
890 for (i
= 0; i
< n
; i
++)
896 opnd_edge
= def_edges
[i
];
897 prev_nc
= num_chains
;
898 compute_control_dep_chain (cd_root
, opnd_edge
->src
, dep_chains
,
899 &num_chains
, &cur_chain
, &num_calls
);
901 /* Now update the newly added chains with
902 the phi operand edge: */
903 if (EDGE_COUNT (opnd_edge
->src
->succs
) > 1)
905 if (prev_nc
== num_chains
&& num_chains
< MAX_NUM_CHAINS
)
906 dep_chains
[num_chains
++] = vNULL
;
907 for (j
= prev_nc
; j
< num_chains
; j
++)
908 dep_chains
[j
].safe_push (opnd_edge
);
913 = convert_control_dep_chain_into_preds (dep_chains
, num_chains
, preds
);
914 for (i
= 0; i
< num_chains
; i
++)
915 dep_chains
[i
].release ();
916 return has_valid_pred
;
919 /* Dumps the predicates (PREDS) for USESTMT. */
922 dump_predicates (gimple
*usestmt
, pred_chain_union preds
, const char *msg
)
925 pred_chain one_pred_chain
= vNULL
;
926 fprintf (dump_file
, "%s", msg
);
927 print_gimple_stmt (dump_file
, usestmt
, 0);
928 fprintf (dump_file
, "is guarded by :\n\n");
929 size_t num_preds
= preds
.length ();
930 /* Do some dumping here: */
931 for (i
= 0; i
< num_preds
; i
++)
935 one_pred_chain
= preds
[i
];
936 np
= one_pred_chain
.length ();
938 for (j
= 0; j
< np
; j
++)
940 pred_info one_pred
= one_pred_chain
[j
];
942 fprintf (dump_file
, " (.NOT.) ");
943 print_generic_expr (dump_file
, one_pred
.pred_lhs
);
944 fprintf (dump_file
, " %s ", op_symbol_code (one_pred
.cond_code
));
945 print_generic_expr (dump_file
, one_pred
.pred_rhs
);
947 fprintf (dump_file
, " (.AND.) ");
949 fprintf (dump_file
, "\n");
951 if (i
< num_preds
- 1)
952 fprintf (dump_file
, "(.OR.)\n");
954 fprintf (dump_file
, "\n\n");
958 /* Destroys the predicate set *PREDS. */
961 destroy_predicate_vecs (pred_chain_union
*preds
)
965 size_t n
= preds
->length ();
966 for (i
= 0; i
< n
; i
++)
967 (*preds
)[i
].release ();
971 /* Computes the 'normalized' conditional code with operand
972 swapping and condition inversion. */
974 static enum tree_code
975 get_cmp_code (enum tree_code orig_cmp_code
, bool swap_cond
, bool invert
)
977 enum tree_code tc
= orig_cmp_code
;
980 tc
= swap_tree_comparison (orig_cmp_code
);
982 tc
= invert_tree_comparison (tc
, false);
999 /* Returns true if VAL falls in the range defined by BOUNDARY and CMPC, i.e.
1000 all values in the range satisfies (x CMPC BOUNDARY) == true. */
1003 is_value_included_in (tree val
, tree boundary
, enum tree_code cmpc
)
1005 bool inverted
= false;
1009 /* Only handle integer constant here. */
1010 if (TREE_CODE (val
) != INTEGER_CST
|| TREE_CODE (boundary
) != INTEGER_CST
)
1013 is_unsigned
= TYPE_UNSIGNED (TREE_TYPE (val
));
1015 if (cmpc
== GE_EXPR
|| cmpc
== GT_EXPR
|| cmpc
== NE_EXPR
)
1017 cmpc
= invert_tree_comparison (cmpc
, false);
1023 if (cmpc
== EQ_EXPR
)
1024 result
= tree_int_cst_equal (val
, boundary
);
1025 else if (cmpc
== LT_EXPR
)
1026 result
= tree_int_cst_lt (val
, boundary
);
1029 gcc_assert (cmpc
== LE_EXPR
);
1030 result
= tree_int_cst_le (val
, boundary
);
1035 if (cmpc
== EQ_EXPR
)
1036 result
= tree_int_cst_equal (val
, boundary
);
1037 else if (cmpc
== LT_EXPR
)
1038 result
= tree_int_cst_lt (val
, boundary
);
1041 gcc_assert (cmpc
== LE_EXPR
);
1042 result
= (tree_int_cst_equal (val
, boundary
)
1043 || tree_int_cst_lt (val
, boundary
));
1053 /* Returns true if PRED is common among all the predicate
1054 chains (PREDS) (and therefore can be factored out).
1055 NUM_PRED_CHAIN is the size of array PREDS. */
1058 find_matching_predicate_in_rest_chains (pred_info pred
,
1059 pred_chain_union preds
,
1060 size_t num_pred_chains
)
1065 if (num_pred_chains
== 1)
1068 for (i
= 1; i
< num_pred_chains
; i
++)
1071 pred_chain one_chain
= preds
[i
];
1072 n
= one_chain
.length ();
1073 for (j
= 0; j
< n
; j
++)
1075 pred_info pred2
= one_chain
[j
];
1076 /* Can relax the condition comparison to not
1077 use address comparison. However, the most common
1078 case is that multiple control dependent paths share
1079 a common path prefix, so address comparison should
1082 if (operand_equal_p (pred2
.pred_lhs
, pred
.pred_lhs
, 0)
1083 && operand_equal_p (pred2
.pred_rhs
, pred
.pred_rhs
, 0)
1084 && pred2
.invert
== pred
.invert
)
1096 /* Forward declaration. */
1097 static bool is_use_properly_guarded (gimple
*use_stmt
,
1100 unsigned uninit_opnds
,
1101 pred_chain_union
*def_preds
,
1102 hash_set
<gphi
*> *visited_phis
);
1104 /* Returns true if all uninitialized opnds are pruned. Returns false
1105 otherwise. PHI is the phi node with uninitialized operands,
1106 UNINIT_OPNDS is the bitmap of the uninitialize operand positions,
1107 FLAG_DEF is the statement defining the flag guarding the use of the
1108 PHI output, BOUNDARY_CST is the const value used in the predicate
1109 associated with the flag, CMP_CODE is the comparison code used in
1110 the predicate, VISITED_PHIS is the pointer set of phis visited, and
1111 VISITED_FLAG_PHIS is the pointer to the pointer set of flag definitions
1117 flag_1 = phi <0, 1> // (1)
1118 var_1 = phi <undef, some_val>
1122 flag_2 = phi <0, flag_1, flag_1> // (2)
1123 var_2 = phi <undef, var_1, var_1>
1130 Because some flag arg in (1) is not constant, if we do not look into the
1131 flag phis recursively, it is conservatively treated as unknown and var_1
1132 is thought to be flowed into use at (3). Since var_1 is potentially
1133 uninitialized a false warning will be emitted.
1134 Checking recursively into (1), the compiler can find out that only some_val
1135 (which is defined) can flow into (3) which is OK. */
1138 prune_uninit_phi_opnds (gphi
*phi
, unsigned uninit_opnds
, gphi
*flag_def
,
1139 tree boundary_cst
, enum tree_code cmp_code
,
1140 hash_set
<gphi
*> *visited_phis
,
1141 bitmap
*visited_flag_phis
)
1145 for (i
= 0; i
< MIN (max_phi_args
, gimple_phi_num_args (flag_def
)); i
++)
1149 if (!MASK_TEST_BIT (uninit_opnds
, i
))
1152 flag_arg
= gimple_phi_arg_def (flag_def
, i
);
1153 if (!is_gimple_constant (flag_arg
))
1155 gphi
*flag_arg_def
, *phi_arg_def
;
1157 unsigned uninit_opnds_arg_phi
;
1159 if (TREE_CODE (flag_arg
) != SSA_NAME
)
1161 flag_arg_def
= dyn_cast
<gphi
*> (SSA_NAME_DEF_STMT (flag_arg
));
1165 phi_arg
= gimple_phi_arg_def (phi
, i
);
1166 if (TREE_CODE (phi_arg
) != SSA_NAME
)
1169 phi_arg_def
= dyn_cast
<gphi
*> (SSA_NAME_DEF_STMT (phi_arg
));
1173 if (gimple_bb (phi_arg_def
) != gimple_bb (flag_arg_def
))
1176 if (!*visited_flag_phis
)
1177 *visited_flag_phis
= BITMAP_ALLOC (NULL
);
1179 tree phi_result
= gimple_phi_result (flag_arg_def
);
1180 if (bitmap_bit_p (*visited_flag_phis
, SSA_NAME_VERSION (phi_result
)))
1183 bitmap_set_bit (*visited_flag_phis
,
1184 SSA_NAME_VERSION (gimple_phi_result (flag_arg_def
)));
1186 /* Now recursively prune the uninitialized phi args. */
1187 uninit_opnds_arg_phi
= compute_uninit_opnds_pos (phi_arg_def
);
1188 if (!prune_uninit_phi_opnds
1189 (phi_arg_def
, uninit_opnds_arg_phi
, flag_arg_def
, boundary_cst
,
1190 cmp_code
, visited_phis
, visited_flag_phis
))
1193 phi_result
= gimple_phi_result (flag_arg_def
);
1194 bitmap_clear_bit (*visited_flag_phis
, SSA_NAME_VERSION (phi_result
));
1198 /* Now check if the constant is in the guarded range. */
1199 if (is_value_included_in (flag_arg
, boundary_cst
, cmp_code
))
1204 /* Now that we know that this undefined edge is not
1205 pruned. If the operand is defined by another phi,
1206 we can further prune the incoming edges of that
1207 phi by checking the predicates of this operands. */
1209 opnd
= gimple_phi_arg_def (phi
, i
);
1210 opnd_def
= SSA_NAME_DEF_STMT (opnd
);
1211 if (gphi
*opnd_def_phi
= dyn_cast
<gphi
*> (opnd_def
))
1214 unsigned uninit_opnds2
= compute_uninit_opnds_pos (opnd_def_phi
);
1215 if (!MASK_EMPTY (uninit_opnds2
))
1217 pred_chain_union def_preds
= vNULL
;
1219 opnd_edge
= gimple_phi_arg_edge (phi
, i
);
1220 ok
= is_use_properly_guarded (phi
,
1226 destroy_predicate_vecs (&def_preds
);
1239 /* A helper function that determines if the predicate set
1240 of the use is not overlapping with that of the uninit paths.
1241 The most common senario of guarded use is in Example 1:
1254 The real world examples are usually more complicated, but similar
1255 and usually result from inlining:
1257 bool init_func (int * x)
1269 if (!init_func (&x))
1276 Another possible use scenario is in the following trivial example:
1288 Predicate analysis needs to compute the composite predicate:
1290 1) 'x' use predicate: (n > 0) .AND. (m < 2)
1291 2) 'x' default value (non-def) predicate: .NOT. (n > 0)
1292 (the predicate chain for phi operand defs can be computed
1293 starting from a bb that is control equivalent to the phi's
1294 bb and is dominating the operand def.)
1296 and check overlapping:
1297 (n > 0) .AND. (m < 2) .AND. (.NOT. (n > 0))
1300 This implementation provides framework that can handle
1301 scenarios. (Note that many simple cases are handled properly
1302 without the predicate analysis -- this is due to jump threading
1303 transformation which eliminates the merge point thus makes
1304 path sensitive analysis unnecessary.)
1306 PHI is the phi node whose incoming (undefined) paths need to be
1307 pruned, and UNINIT_OPNDS is the bitmap holding uninit operand
1308 positions. VISITED_PHIS is the pointer set of phi stmts being
1312 use_pred_not_overlap_with_undef_path_pred (pred_chain_union preds
,
1313 gphi
*phi
, unsigned uninit_opnds
,
1314 hash_set
<gphi
*> *visited_phis
)
1317 gimple
*flag_def
= 0;
1318 tree boundary_cst
= 0;
1319 enum tree_code cmp_code
;
1320 bool swap_cond
= false;
1321 bool invert
= false;
1322 pred_chain the_pred_chain
= vNULL
;
1323 bitmap visited_flag_phis
= NULL
;
1324 bool all_pruned
= false;
1325 size_t num_preds
= preds
.length ();
1327 gcc_assert (num_preds
> 0);
1328 /* Find within the common prefix of multiple predicate chains
1329 a predicate that is a comparison of a flag variable against
1331 the_pred_chain
= preds
[0];
1332 n
= the_pred_chain
.length ();
1333 for (i
= 0; i
< n
; i
++)
1335 tree cond_lhs
, cond_rhs
, flag
= 0;
1337 pred_info the_pred
= the_pred_chain
[i
];
1339 invert
= the_pred
.invert
;
1340 cond_lhs
= the_pred
.pred_lhs
;
1341 cond_rhs
= the_pred
.pred_rhs
;
1342 cmp_code
= the_pred
.cond_code
;
1344 if (cond_lhs
!= NULL_TREE
&& TREE_CODE (cond_lhs
) == SSA_NAME
1345 && cond_rhs
!= NULL_TREE
&& is_gimple_constant (cond_rhs
))
1347 boundary_cst
= cond_rhs
;
1350 else if (cond_rhs
!= NULL_TREE
&& TREE_CODE (cond_rhs
) == SSA_NAME
1351 && cond_lhs
!= NULL_TREE
&& is_gimple_constant (cond_lhs
))
1353 boundary_cst
= cond_lhs
;
1361 flag_def
= SSA_NAME_DEF_STMT (flag
);
1366 if ((gimple_code (flag_def
) == GIMPLE_PHI
)
1367 && (gimple_bb (flag_def
) == gimple_bb (phi
))
1368 && find_matching_predicate_in_rest_chains (the_pred
, preds
,
1378 /* Now check all the uninit incoming edge has a constant flag value
1379 that is in conflict with the use guard/predicate. */
1380 cmp_code
= get_cmp_code (cmp_code
, swap_cond
, invert
);
1382 if (cmp_code
== ERROR_MARK
)
1385 all_pruned
= prune_uninit_phi_opnds
1386 (phi
, uninit_opnds
, as_a
<gphi
*> (flag_def
), boundary_cst
, cmp_code
,
1387 visited_phis
, &visited_flag_phis
);
1389 if (visited_flag_phis
)
1390 BITMAP_FREE (visited_flag_phis
);
1395 /* The helper function returns true if two predicates X1 and X2
1396 are equivalent. It assumes the expressions have already
1397 properly re-associated. */
1400 pred_equal_p (pred_info x1
, pred_info x2
)
1402 enum tree_code c1
, c2
;
1403 if (!operand_equal_p (x1
.pred_lhs
, x2
.pred_lhs
, 0)
1404 || !operand_equal_p (x1
.pred_rhs
, x2
.pred_rhs
, 0))
1408 if (x1
.invert
!= x2
.invert
1409 && TREE_CODE_CLASS (x2
.cond_code
) == tcc_comparison
)
1410 c2
= invert_tree_comparison (x2
.cond_code
, false);
1417 /* Returns true if the predication is testing !=. */
1420 is_neq_relop_p (pred_info pred
)
1423 return ((pred
.cond_code
== NE_EXPR
&& !pred
.invert
)
1424 || (pred
.cond_code
== EQ_EXPR
&& pred
.invert
));
1427 /* Returns true if pred is of the form X != 0. */
1430 is_neq_zero_form_p (pred_info pred
)
1432 if (!is_neq_relop_p (pred
) || !integer_zerop (pred
.pred_rhs
)
1433 || TREE_CODE (pred
.pred_lhs
) != SSA_NAME
)
1438 /* The helper function returns true if two predicates X1
1439 is equivalent to X2 != 0. */
1442 pred_expr_equal_p (pred_info x1
, tree x2
)
1444 if (!is_neq_zero_form_p (x1
))
1447 return operand_equal_p (x1
.pred_lhs
, x2
, 0);
1450 /* Returns true of the domain of single predicate expression
1451 EXPR1 is a subset of that of EXPR2. Returns false if it
1452 can not be proved. */
1455 is_pred_expr_subset_of (pred_info expr1
, pred_info expr2
)
1457 enum tree_code code1
, code2
;
1459 if (pred_equal_p (expr1
, expr2
))
1462 if ((TREE_CODE (expr1
.pred_rhs
) != INTEGER_CST
)
1463 || (TREE_CODE (expr2
.pred_rhs
) != INTEGER_CST
))
1466 if (!operand_equal_p (expr1
.pred_lhs
, expr2
.pred_lhs
, 0))
1469 code1
= expr1
.cond_code
;
1471 code1
= invert_tree_comparison (code1
, false);
1472 code2
= expr2
.cond_code
;
1474 code2
= invert_tree_comparison (code2
, false);
1476 if ((code1
== EQ_EXPR
|| code1
== BIT_AND_EXPR
) && code2
== BIT_AND_EXPR
)
1477 return (wi::to_wide (expr1
.pred_rhs
)
1478 == (wi::to_wide (expr1
.pred_rhs
) & wi::to_wide (expr2
.pred_rhs
)));
1480 if (code1
!= code2
&& code2
!= NE_EXPR
)
1483 if (is_value_included_in (expr1
.pred_rhs
, expr2
.pred_rhs
, code2
))
1489 /* Returns true if the domain of PRED1 is a subset
1490 of that of PRED2. Returns false if it can not be proved so. */
1493 is_pred_chain_subset_of (pred_chain pred1
, pred_chain pred2
)
1495 size_t np1
, np2
, i1
, i2
;
1497 np1
= pred1
.length ();
1498 np2
= pred2
.length ();
1500 for (i2
= 0; i2
< np2
; i2
++)
1503 pred_info info2
= pred2
[i2
];
1504 for (i1
= 0; i1
< np1
; i1
++)
1506 pred_info info1
= pred1
[i1
];
1507 if (is_pred_expr_subset_of (info1
, info2
))
1519 /* Returns true if the domain defined by
1520 one pred chain ONE_PRED is a subset of the domain
1521 of *PREDS. It returns false if ONE_PRED's domain is
1522 not a subset of any of the sub-domains of PREDS
1523 (corresponding to each individual chains in it), even
1524 though it may be still be a subset of whole domain
1525 of PREDS which is the union (ORed) of all its subdomains.
1526 In other words, the result is conservative. */
1529 is_included_in (pred_chain one_pred
, pred_chain_union preds
)
1532 size_t n
= preds
.length ();
1534 for (i
= 0; i
< n
; i
++)
1536 if (is_pred_chain_subset_of (one_pred
, preds
[i
]))
1543 /* Compares two predicate sets PREDS1 and PREDS2 and returns
1544 true if the domain defined by PREDS1 is a superset
1545 of PREDS2's domain. N1 and N2 are array sizes of PREDS1 and
1546 PREDS2 respectively. The implementation chooses not to build
1547 generic trees (and relying on the folding capability of the
1548 compiler), but instead performs brute force comparison of
1549 individual predicate chains (won't be a compile time problem
1550 as the chains are pretty short). When the function returns
1551 false, it does not necessarily mean *PREDS1 is not a superset
1552 of *PREDS2, but mean it may not be so since the analysis can
1553 not prove it. In such cases, false warnings may still be
1557 is_superset_of (pred_chain_union preds1
, pred_chain_union preds2
)
1560 pred_chain one_pred_chain
= vNULL
;
1562 n2
= preds2
.length ();
1564 for (i
= 0; i
< n2
; i
++)
1566 one_pred_chain
= preds2
[i
];
1567 if (!is_included_in (one_pred_chain
, preds1
))
1574 /* Returns true if TC is AND or OR. */
1577 is_and_or_or_p (enum tree_code tc
, tree type
)
1579 return (tc
== BIT_IOR_EXPR
1580 || (tc
== BIT_AND_EXPR
1581 && (type
== 0 || TREE_CODE (type
) == BOOLEAN_TYPE
)));
1584 /* Returns true if X1 is the negate of X2. */
1587 pred_neg_p (pred_info x1
, pred_info x2
)
1589 enum tree_code c1
, c2
;
1590 if (!operand_equal_p (x1
.pred_lhs
, x2
.pred_lhs
, 0)
1591 || !operand_equal_p (x1
.pred_rhs
, x2
.pred_rhs
, 0))
1595 if (x1
.invert
== x2
.invert
)
1596 c2
= invert_tree_comparison (x2
.cond_code
, false);
1603 /* 1) ((x IOR y) != 0) AND (x != 0) is equivalent to (x != 0);
1604 2) (X AND Y) OR (!X AND Y) is equivalent to Y;
1605 3) X OR (!X AND Y) is equivalent to (X OR Y);
1606 4) ((x IAND y) != 0) || (x != 0 AND y != 0)) is equivalent to
1608 5) (X AND Y) OR (!X AND Z) OR (!Y AND Z) is equivalent to
1611 PREDS is the predicate chains, and N is the number of chains. */
1613 /* Helper function to implement rule 1 above. ONE_CHAIN is
1614 the AND predication to be simplified. */
1617 simplify_pred (pred_chain
*one_chain
)
1620 bool simplified
= false;
1621 pred_chain s_chain
= vNULL
;
1623 n
= one_chain
->length ();
1625 for (i
= 0; i
< n
; i
++)
1627 pred_info
*a_pred
= &(*one_chain
)[i
];
1629 if (!a_pred
->pred_lhs
)
1631 if (!is_neq_zero_form_p (*a_pred
))
1634 gimple
*def_stmt
= SSA_NAME_DEF_STMT (a_pred
->pred_lhs
);
1635 if (gimple_code (def_stmt
) != GIMPLE_ASSIGN
)
1637 if (gimple_assign_rhs_code (def_stmt
) == BIT_IOR_EXPR
)
1639 for (j
= 0; j
< n
; j
++)
1641 pred_info
*b_pred
= &(*one_chain
)[j
];
1643 if (!b_pred
->pred_lhs
)
1645 if (!is_neq_zero_form_p (*b_pred
))
1648 if (pred_expr_equal_p (*b_pred
, gimple_assign_rhs1 (def_stmt
))
1649 || pred_expr_equal_p (*b_pred
, gimple_assign_rhs2 (def_stmt
)))
1651 /* Mark a_pred for removal. */
1652 a_pred
->pred_lhs
= NULL
;
1653 a_pred
->pred_rhs
= NULL
;
1664 for (i
= 0; i
< n
; i
++)
1666 pred_info
*a_pred
= &(*one_chain
)[i
];
1667 if (!a_pred
->pred_lhs
)
1669 s_chain
.safe_push (*a_pred
);
1672 one_chain
->release ();
1673 *one_chain
= s_chain
;
1676 /* The helper function implements the rule 2 for the
1679 2) (X AND Y) OR (!X AND Y) is equivalent to Y. */
1682 simplify_preds_2 (pred_chain_union
*preds
)
1685 bool simplified
= false;
1686 pred_chain_union s_preds
= vNULL
;
1688 /* (X AND Y) OR (!X AND Y) is equivalent to Y.
1689 (X AND Y) OR (X AND !Y) is equivalent to X. */
1691 n
= preds
->length ();
1692 for (i
= 0; i
< n
; i
++)
1695 pred_chain
*a_chain
= &(*preds
)[i
];
1697 if (a_chain
->length () != 2)
1703 for (j
= 0; j
< n
; j
++)
1705 pred_chain
*b_chain
;
1711 b_chain
= &(*preds
)[j
];
1712 if (b_chain
->length () != 2)
1718 if (pred_equal_p (x
, x2
) && pred_neg_p (y
, y2
))
1721 a_chain
->release ();
1722 b_chain
->release ();
1723 b_chain
->safe_push (x
);
1727 if (pred_neg_p (x
, x2
) && pred_equal_p (y
, y2
))
1730 a_chain
->release ();
1731 b_chain
->release ();
1732 b_chain
->safe_push (y
);
1738 /* Now clean up the chain. */
1741 for (i
= 0; i
< n
; i
++)
1743 if ((*preds
)[i
].is_empty ())
1745 s_preds
.safe_push ((*preds
)[i
]);
1755 /* The helper function implements the rule 2 for the
1758 3) x OR (!x AND y) is equivalent to x OR y. */
1761 simplify_preds_3 (pred_chain_union
*preds
)
1764 bool simplified
= false;
1766 /* Now iteratively simplify X OR (!X AND Z ..)
1767 into X OR (Z ...). */
1769 n
= preds
->length ();
1773 for (i
= 0; i
< n
; i
++)
1776 pred_chain
*a_chain
= &(*preds
)[i
];
1778 if (a_chain
->length () != 1)
1783 for (j
= 0; j
< n
; j
++)
1785 pred_chain
*b_chain
;
1792 b_chain
= &(*preds
)[j
];
1793 if (b_chain
->length () < 2)
1796 for (k
= 0; k
< b_chain
->length (); k
++)
1799 if (pred_neg_p (x
, x2
))
1801 b_chain
->unordered_remove (k
);
1811 /* The helper function implements the rule 4 for the
1814 2) ((x AND y) != 0) OR (x != 0 AND y != 0) is equivalent to
1815 (x != 0 ANd y != 0). */
1818 simplify_preds_4 (pred_chain_union
*preds
)
1821 bool simplified
= false;
1822 pred_chain_union s_preds
= vNULL
;
1825 n
= preds
->length ();
1826 for (i
= 0; i
< n
; i
++)
1829 pred_chain
*a_chain
= &(*preds
)[i
];
1831 if (a_chain
->length () != 1)
1836 if (!is_neq_zero_form_p (z
))
1839 def_stmt
= SSA_NAME_DEF_STMT (z
.pred_lhs
);
1840 if (gimple_code (def_stmt
) != GIMPLE_ASSIGN
)
1843 if (gimple_assign_rhs_code (def_stmt
) != BIT_AND_EXPR
)
1846 for (j
= 0; j
< n
; j
++)
1848 pred_chain
*b_chain
;
1854 b_chain
= &(*preds
)[j
];
1855 if (b_chain
->length () != 2)
1860 if (!is_neq_zero_form_p (x2
) || !is_neq_zero_form_p (y2
))
1863 if ((pred_expr_equal_p (x2
, gimple_assign_rhs1 (def_stmt
))
1864 && pred_expr_equal_p (y2
, gimple_assign_rhs2 (def_stmt
)))
1865 || (pred_expr_equal_p (x2
, gimple_assign_rhs2 (def_stmt
))
1866 && pred_expr_equal_p (y2
, gimple_assign_rhs1 (def_stmt
))))
1869 a_chain
->release ();
1875 /* Now clean up the chain. */
1878 for (i
= 0; i
< n
; i
++)
1880 if ((*preds
)[i
].is_empty ())
1882 s_preds
.safe_push ((*preds
)[i
]);
1893 /* This function simplifies predicates in PREDS. */
1896 simplify_preds (pred_chain_union
*preds
, gimple
*use_or_def
, bool is_use
)
1899 bool changed
= false;
1901 if (dump_file
&& dump_flags
& TDF_DETAILS
)
1903 fprintf (dump_file
, "[BEFORE SIMPLICATION -- ");
1904 dump_predicates (use_or_def
, *preds
, is_use
? "[USE]:\n" : "[DEF]:\n");
1907 for (i
= 0; i
< preds
->length (); i
++)
1908 simplify_pred (&(*preds
)[i
]);
1910 n
= preds
->length ();
1917 if (simplify_preds_2 (preds
))
1920 /* Now iteratively simplify X OR (!X AND Z ..)
1921 into X OR (Z ...). */
1922 if (simplify_preds_3 (preds
))
1925 if (simplify_preds_4 (preds
))
1933 /* This is a helper function which attempts to normalize predicate chains
1934 by following UD chains. It basically builds up a big tree of either IOR
1935 operations or AND operations, and convert the IOR tree into a
1936 pred_chain_union or BIT_AND tree into a pred_chain.
1946 then _t != 0 will be normalized into a pred_chain_union
1948 (_2 RELOP1 _1) OR (_5 RELOP2 _4) OR (_8 RELOP3 _7) OR (_0 != 0)
1958 then _t != 0 will be normalized into a pred_chain:
1959 (_2 RELOP1 _1) AND (_5 RELOP2 _4) AND (_8 RELOP3 _7) AND (_0 != 0)
1963 /* This is a helper function that stores a PRED into NORM_PREDS. */
1966 push_pred (pred_chain_union
*norm_preds
, pred_info pred
)
1968 pred_chain pred_chain
= vNULL
;
1969 pred_chain
.safe_push (pred
);
1970 norm_preds
->safe_push (pred_chain
);
1973 /* A helper function that creates a predicate of the form
1974 OP != 0 and push it WORK_LIST. */
1977 push_to_worklist (tree op
, vec
<pred_info
, va_heap
, vl_ptr
> *work_list
,
1978 hash_set
<tree
> *mark_set
)
1980 if (mark_set
->contains (op
))
1985 arg_pred
.pred_lhs
= op
;
1986 arg_pred
.pred_rhs
= integer_zero_node
;
1987 arg_pred
.cond_code
= NE_EXPR
;
1988 arg_pred
.invert
= false;
1989 work_list
->safe_push (arg_pred
);
1992 /* A helper that generates a pred_info from a gimple assignment
1993 CMP_ASSIGN with comparison rhs. */
1996 get_pred_info_from_cmp (gimple
*cmp_assign
)
1999 n_pred
.pred_lhs
= gimple_assign_rhs1 (cmp_assign
);
2000 n_pred
.pred_rhs
= gimple_assign_rhs2 (cmp_assign
);
2001 n_pred
.cond_code
= gimple_assign_rhs_code (cmp_assign
);
2002 n_pred
.invert
= false;
2006 /* Returns true if the PHI is a degenerated phi with
2007 all args with the same value (relop). In that case, *PRED
2008 will be updated to that value. */
2011 is_degenerated_phi (gimple
*phi
, pred_info
*pred_p
)
2018 n
= gimple_phi_num_args (phi
);
2019 op0
= gimple_phi_arg_def (phi
, 0);
2021 if (TREE_CODE (op0
) != SSA_NAME
)
2024 def0
= SSA_NAME_DEF_STMT (op0
);
2025 if (gimple_code (def0
) != GIMPLE_ASSIGN
)
2027 if (TREE_CODE_CLASS (gimple_assign_rhs_code (def0
)) != tcc_comparison
)
2029 pred0
= get_pred_info_from_cmp (def0
);
2031 for (i
= 1; i
< n
; ++i
)
2035 tree op
= gimple_phi_arg_def (phi
, i
);
2037 if (TREE_CODE (op
) != SSA_NAME
)
2040 def
= SSA_NAME_DEF_STMT (op
);
2041 if (gimple_code (def
) != GIMPLE_ASSIGN
)
2043 if (TREE_CODE_CLASS (gimple_assign_rhs_code (def
)) != tcc_comparison
)
2045 pred
= get_pred_info_from_cmp (def
);
2046 if (!pred_equal_p (pred
, pred0
))
2054 /* Normalize one predicate PRED
2055 1) if PRED can no longer be normlized, put it into NORM_PREDS.
2056 2) otherwise if PRED is of the form x != 0, follow x's definition
2057 and put normalized predicates into WORK_LIST. */
2060 normalize_one_pred_1 (pred_chain_union
*norm_preds
,
2061 pred_chain
*norm_chain
,
2063 enum tree_code and_or_code
,
2064 vec
<pred_info
, va_heap
, vl_ptr
> *work_list
,
2065 hash_set
<tree
> *mark_set
)
2067 if (!is_neq_zero_form_p (pred
))
2069 if (and_or_code
== BIT_IOR_EXPR
)
2070 push_pred (norm_preds
, pred
);
2072 norm_chain
->safe_push (pred
);
2076 gimple
*def_stmt
= SSA_NAME_DEF_STMT (pred
.pred_lhs
);
2078 if (gimple_code (def_stmt
) == GIMPLE_PHI
2079 && is_degenerated_phi (def_stmt
, &pred
))
2080 work_list
->safe_push (pred
);
2081 else if (gimple_code (def_stmt
) == GIMPLE_PHI
&& and_or_code
== BIT_IOR_EXPR
)
2084 n
= gimple_phi_num_args (def_stmt
);
2086 /* If we see non zero constant, we should punt. The predicate
2087 * should be one guarding the phi edge. */
2088 for (i
= 0; i
< n
; ++i
)
2090 tree op
= gimple_phi_arg_def (def_stmt
, i
);
2091 if (TREE_CODE (op
) == INTEGER_CST
&& !integer_zerop (op
))
2093 push_pred (norm_preds
, pred
);
2098 for (i
= 0; i
< n
; ++i
)
2100 tree op
= gimple_phi_arg_def (def_stmt
, i
);
2101 if (integer_zerop (op
))
2104 push_to_worklist (op
, work_list
, mark_set
);
2107 else if (gimple_code (def_stmt
) != GIMPLE_ASSIGN
)
2109 if (and_or_code
== BIT_IOR_EXPR
)
2110 push_pred (norm_preds
, pred
);
2112 norm_chain
->safe_push (pred
);
2114 else if (gimple_assign_rhs_code (def_stmt
) == and_or_code
)
2116 /* Avoid splitting up bit manipulations like x & 3 or y | 1. */
2117 if (is_gimple_min_invariant (gimple_assign_rhs2 (def_stmt
)))
2119 /* But treat x & 3 as condition. */
2120 if (and_or_code
== BIT_AND_EXPR
)
2123 n_pred
.pred_lhs
= gimple_assign_rhs1 (def_stmt
);
2124 n_pred
.pred_rhs
= gimple_assign_rhs2 (def_stmt
);
2125 n_pred
.cond_code
= and_or_code
;
2126 n_pred
.invert
= false;
2127 norm_chain
->safe_push (n_pred
);
2132 push_to_worklist (gimple_assign_rhs1 (def_stmt
), work_list
, mark_set
);
2133 push_to_worklist (gimple_assign_rhs2 (def_stmt
), work_list
, mark_set
);
2136 else if (TREE_CODE_CLASS (gimple_assign_rhs_code (def_stmt
))
2139 pred_info n_pred
= get_pred_info_from_cmp (def_stmt
);
2140 if (and_or_code
== BIT_IOR_EXPR
)
2141 push_pred (norm_preds
, n_pred
);
2143 norm_chain
->safe_push (n_pred
);
2147 if (and_or_code
== BIT_IOR_EXPR
)
2148 push_pred (norm_preds
, pred
);
2150 norm_chain
->safe_push (pred
);
2154 /* Normalize PRED and store the normalized predicates into NORM_PREDS. */
2157 normalize_one_pred (pred_chain_union
*norm_preds
, pred_info pred
)
2159 vec
<pred_info
, va_heap
, vl_ptr
> work_list
= vNULL
;
2160 enum tree_code and_or_code
= ERROR_MARK
;
2161 pred_chain norm_chain
= vNULL
;
2163 if (!is_neq_zero_form_p (pred
))
2165 push_pred (norm_preds
, pred
);
2169 gimple
*def_stmt
= SSA_NAME_DEF_STMT (pred
.pred_lhs
);
2170 if (gimple_code (def_stmt
) == GIMPLE_ASSIGN
)
2171 and_or_code
= gimple_assign_rhs_code (def_stmt
);
2172 if (and_or_code
!= BIT_IOR_EXPR
&& and_or_code
!= BIT_AND_EXPR
)
2174 if (TREE_CODE_CLASS (and_or_code
) == tcc_comparison
)
2176 pred_info n_pred
= get_pred_info_from_cmp (def_stmt
);
2177 push_pred (norm_preds
, n_pred
);
2180 push_pred (norm_preds
, pred
);
2184 work_list
.safe_push (pred
);
2185 hash_set
<tree
> mark_set
;
2187 while (!work_list
.is_empty ())
2189 pred_info a_pred
= work_list
.pop ();
2190 normalize_one_pred_1 (norm_preds
, &norm_chain
, a_pred
, and_or_code
,
2191 &work_list
, &mark_set
);
2193 if (and_or_code
== BIT_AND_EXPR
)
2194 norm_preds
->safe_push (norm_chain
);
2196 work_list
.release ();
2200 normalize_one_pred_chain (pred_chain_union
*norm_preds
, pred_chain one_chain
)
2202 vec
<pred_info
, va_heap
, vl_ptr
> work_list
= vNULL
;
2203 hash_set
<tree
> mark_set
;
2204 pred_chain norm_chain
= vNULL
;
2207 for (i
= 0; i
< one_chain
.length (); i
++)
2209 work_list
.safe_push (one_chain
[i
]);
2210 mark_set
.add (one_chain
[i
].pred_lhs
);
2213 while (!work_list
.is_empty ())
2215 pred_info a_pred
= work_list
.pop ();
2216 normalize_one_pred_1 (0, &norm_chain
, a_pred
, BIT_AND_EXPR
, &work_list
,
2220 norm_preds
->safe_push (norm_chain
);
2221 work_list
.release ();
2224 /* Normalize predicate chains PREDS and returns the normalized one. */
2226 static pred_chain_union
2227 normalize_preds (pred_chain_union preds
, gimple
*use_or_def
, bool is_use
)
2229 pred_chain_union norm_preds
= vNULL
;
2230 size_t n
= preds
.length ();
2233 if (dump_file
&& dump_flags
& TDF_DETAILS
)
2235 fprintf (dump_file
, "[BEFORE NORMALIZATION --");
2236 dump_predicates (use_or_def
, preds
, is_use
? "[USE]:\n" : "[DEF]:\n");
2239 for (i
= 0; i
< n
; i
++)
2241 if (preds
[i
].length () != 1)
2242 normalize_one_pred_chain (&norm_preds
, preds
[i
]);
2245 normalize_one_pred (&norm_preds
, preds
[i
][0]);
2246 preds
[i
].release ();
2252 fprintf (dump_file
, "[AFTER NORMALIZATION -- ");
2253 dump_predicates (use_or_def
, norm_preds
,
2254 is_use
? "[USE]:\n" : "[DEF]:\n");
2257 destroy_predicate_vecs (&preds
);
2261 /* Return TRUE if PREDICATE can be invalidated by any individual
2262 predicate in WORKLIST. */
2265 can_one_predicate_be_invalidated_p (pred_info predicate
,
2266 pred_chain use_guard
)
2268 for (size_t i
= 0; i
< use_guard
.length (); ++i
)
2270 /* NOTE: This is a very simple check, and only understands an
2271 exact opposite. So, [i == 0] is currently only invalidated
2272 by [.NOT. i == 0] or [i != 0]. Ideally we should also
2273 invalidate with say [i > 5] or [i == 8]. There is certainly
2274 room for improvement here. */
2275 if (pred_neg_p (predicate
, use_guard
[i
]))
2281 /* Return TRUE if all predicates in UNINIT_PRED are invalidated by
2282 USE_GUARD being true. */
2285 can_chain_union_be_invalidated_p (pred_chain_union uninit_pred
,
2286 pred_chain use_guard
)
2288 if (uninit_pred
.is_empty ())
2290 for (size_t i
= 0; i
< uninit_pred
.length (); ++i
)
2292 pred_chain c
= uninit_pred
[i
];
2293 for (size_t j
= 0; j
< c
.length (); ++j
)
2294 if (!can_one_predicate_be_invalidated_p (c
[j
], use_guard
))
2300 /* Return TRUE if none of the uninitialized operands in UNINT_OPNDS
2301 can actually happen if we arrived at a use for PHI.
2303 PHI_USE_GUARDS are the guard conditions for the use of the PHI. */
2306 uninit_uses_cannot_happen (gphi
*phi
, unsigned uninit_opnds
,
2307 pred_chain_union phi_use_guards
)
2309 unsigned phi_args
= gimple_phi_num_args (phi
);
2310 if (phi_args
> max_phi_args
)
2313 /* PHI_USE_GUARDS are OR'ed together. If we have more than one
2314 possible guard, there's no way of knowing which guard was true.
2315 Since we need to be absolutely sure that the uninitialized
2316 operands will be invalidated, bail. */
2317 if (phi_use_guards
.length () != 1)
2320 /* Look for the control dependencies of all the uninitialized
2321 operands and build guard predicates describing them. */
2322 pred_chain_union uninit_preds
;
2324 for (unsigned i
= 0; i
< phi_args
; ++i
)
2326 if (!MASK_TEST_BIT (uninit_opnds
, i
))
2329 edge e
= gimple_phi_arg_edge (phi
, i
);
2330 vec
<edge
> dep_chains
[MAX_NUM_CHAINS
];
2331 auto_vec
<edge
, MAX_CHAIN_LEN
+ 1> cur_chain
;
2332 size_t num_chains
= 0;
2335 /* Build the control dependency chain for uninit operand `i'... */
2336 uninit_preds
= vNULL
;
2337 if (!compute_control_dep_chain (find_dom (e
->src
),
2338 e
->src
, dep_chains
, &num_chains
,
2339 &cur_chain
, &num_calls
))
2344 /* ...and convert it into a set of predicates. */
2345 convert_control_dep_chain_into_preds (dep_chains
, num_chains
,
2347 for (size_t j
= 0; j
< num_chains
; ++j
)
2348 dep_chains
[j
].release ();
2349 simplify_preds (&uninit_preds
, NULL
, false);
2350 uninit_preds
= normalize_preds (uninit_preds
, NULL
, false);
2352 /* Can the guard for this uninitialized operand be invalidated
2354 if (!can_chain_union_be_invalidated_p (uninit_preds
, phi_use_guards
[0]))
2360 destroy_predicate_vecs (&uninit_preds
);
2364 /* Computes the predicates that guard the use and checks
2365 if the incoming paths that have empty (or possibly
2366 empty) definition can be pruned/filtered. The function returns
2367 true if it can be determined that the use of PHI's def in
2368 USE_STMT is guarded with a predicate set not overlapping with
2369 predicate sets of all runtime paths that do not have a definition.
2371 Returns false if it is not or it can not be determined. USE_BB is
2372 the bb of the use (for phi operand use, the bb is not the bb of
2373 the phi stmt, but the src bb of the operand edge).
2375 UNINIT_OPNDS is a bit vector. If an operand of PHI is uninitialized, the
2376 corresponding bit in the vector is 1. VISITED_PHIS is a pointer
2377 set of phis being visited.
2379 *DEF_PREDS contains the (memoized) defining predicate chains of PHI.
2380 If *DEF_PREDS is the empty vector, the defining predicate chains of
2381 PHI will be computed and stored into *DEF_PREDS as needed.
2383 VISITED_PHIS is a pointer set of phis being visited. */
2386 is_use_properly_guarded (gimple
*use_stmt
,
2389 unsigned uninit_opnds
,
2390 pred_chain_union
*def_preds
,
2391 hash_set
<gphi
*> *visited_phis
)
2394 pred_chain_union preds
= vNULL
;
2395 bool has_valid_preds
= false;
2396 bool is_properly_guarded
= false;
2398 if (visited_phis
->add (phi
))
2401 phi_bb
= gimple_bb (phi
);
2403 if (is_non_loop_exit_postdominating (use_bb
, phi_bb
))
2406 has_valid_preds
= find_predicates (&preds
, phi_bb
, use_bb
);
2408 if (!has_valid_preds
)
2410 destroy_predicate_vecs (&preds
);
2414 /* Try to prune the dead incoming phi edges. */
2416 = use_pred_not_overlap_with_undef_path_pred (preds
, phi
, uninit_opnds
,
2419 /* We might be able to prove that if the control dependencies
2420 for UNINIT_OPNDS are true, that the control dependencies for
2421 USE_STMT can never be true. */
2422 if (!is_properly_guarded
)
2423 is_properly_guarded
|= uninit_uses_cannot_happen (phi
, uninit_opnds
,
2426 if (is_properly_guarded
)
2428 destroy_predicate_vecs (&preds
);
2432 if (def_preds
->is_empty ())
2434 has_valid_preds
= find_def_preds (def_preds
, phi
);
2436 if (!has_valid_preds
)
2438 destroy_predicate_vecs (&preds
);
2442 simplify_preds (def_preds
, phi
, false);
2443 *def_preds
= normalize_preds (*def_preds
, phi
, false);
2446 simplify_preds (&preds
, use_stmt
, true);
2447 preds
= normalize_preds (preds
, use_stmt
, true);
2449 is_properly_guarded
= is_superset_of (*def_preds
, preds
);
2451 destroy_predicate_vecs (&preds
);
2452 return is_properly_guarded
;
2455 /* Searches through all uses of a potentially
2456 uninitialized variable defined by PHI and returns a use
2457 statement if the use is not properly guarded. It returns
2458 NULL if all uses are guarded. UNINIT_OPNDS is a bitvector
2459 holding the position(s) of uninit PHI operands. WORKLIST
2460 is the vector of candidate phis that may be updated by this
2461 function. ADDED_TO_WORKLIST is the pointer set tracking
2462 if the new phi is already in the worklist. */
2465 find_uninit_use (gphi
*phi
, unsigned uninit_opnds
,
2466 vec
<gphi
*> *worklist
,
2467 hash_set
<gphi
*> *added_to_worklist
)
2470 use_operand_p use_p
;
2472 imm_use_iterator iter
;
2473 pred_chain_union def_preds
= vNULL
;
2476 phi_result
= gimple_phi_result (phi
);
2478 FOR_EACH_IMM_USE_FAST (use_p
, iter
, phi_result
)
2482 use_stmt
= USE_STMT (use_p
);
2483 if (is_gimple_debug (use_stmt
))
2486 if (gphi
*use_phi
= dyn_cast
<gphi
*> (use_stmt
))
2487 use_bb
= gimple_phi_arg_edge (use_phi
,
2488 PHI_ARG_INDEX_FROM_USE (use_p
))->src
;
2490 use_bb
= gimple_bb (use_stmt
);
2492 hash_set
<gphi
*> visited_phis
;
2493 if (is_use_properly_guarded (use_stmt
, use_bb
, phi
, uninit_opnds
,
2494 &def_preds
, &visited_phis
))
2497 if (dump_file
&& (dump_flags
& TDF_DETAILS
))
2499 fprintf (dump_file
, "[CHECK]: Found unguarded use: ");
2500 print_gimple_stmt (dump_file
, use_stmt
, 0);
2502 /* Found one real use, return. */
2503 if (gimple_code (use_stmt
) != GIMPLE_PHI
)
2509 /* Found a phi use that is not guarded,
2510 add the phi to the worklist. */
2511 if (!added_to_worklist
->add (as_a
<gphi
*> (use_stmt
)))
2513 if (dump_file
&& (dump_flags
& TDF_DETAILS
))
2515 fprintf (dump_file
, "[WORKLIST]: Update worklist with phi: ");
2516 print_gimple_stmt (dump_file
, use_stmt
, 0);
2519 worklist
->safe_push (as_a
<gphi
*> (use_stmt
));
2520 possibly_undefined_names
->add (phi_result
);
2524 destroy_predicate_vecs (&def_preds
);
2528 /* Look for inputs to PHI that are SSA_NAMEs that have empty definitions
2529 and gives warning if there exists a runtime path from the entry to a
2530 use of the PHI def that does not contain a definition. In other words,
2531 the warning is on the real use. The more dead paths that can be pruned
2532 by the compiler, the fewer false positives the warning is. WORKLIST
2533 is a vector of candidate phis to be examined. ADDED_TO_WORKLIST is
2534 a pointer set tracking if the new phi is added to the worklist or not. */
2537 warn_uninitialized_phi (gphi
*phi
, vec
<gphi
*> *worklist
,
2538 hash_set
<gphi
*> *added_to_worklist
)
2540 unsigned uninit_opnds
;
2541 gimple
*uninit_use_stmt
= 0;
2546 /* Don't look at virtual operands. */
2547 if (virtual_operand_p (gimple_phi_result (phi
)))
2550 uninit_opnds
= compute_uninit_opnds_pos (phi
);
2552 if (MASK_EMPTY (uninit_opnds
))
2555 if (dump_file
&& (dump_flags
& TDF_DETAILS
))
2557 fprintf (dump_file
, "[CHECK]: examining phi: ");
2558 print_gimple_stmt (dump_file
, phi
, 0);
2561 /* Now check if we have any use of the value without proper guard. */
2562 uninit_use_stmt
= find_uninit_use (phi
, uninit_opnds
,
2563 worklist
, added_to_worklist
);
2565 /* All uses are properly guarded. */
2566 if (!uninit_use_stmt
)
2569 phiarg_index
= MASK_FIRST_SET_BIT (uninit_opnds
);
2570 uninit_op
= gimple_phi_arg_def (phi
, phiarg_index
);
2571 if (SSA_NAME_VAR (uninit_op
) == NULL_TREE
)
2573 if (gimple_phi_arg_has_location (phi
, phiarg_index
))
2574 loc
= gimple_phi_arg_location (phi
, phiarg_index
);
2576 loc
= UNKNOWN_LOCATION
;
2577 warn_uninit (OPT_Wmaybe_uninitialized
, uninit_op
, SSA_NAME_VAR (uninit_op
),
2578 SSA_NAME_VAR (uninit_op
),
2579 "%qD may be used uninitialized in this function",
2580 uninit_use_stmt
, loc
);
2584 gate_warn_uninitialized (void)
2586 return warn_uninitialized
|| warn_maybe_uninitialized
;
2591 const pass_data pass_data_late_warn_uninitialized
=
2593 GIMPLE_PASS
, /* type */
2594 "uninit", /* name */
2595 OPTGROUP_NONE
, /* optinfo_flags */
2596 TV_NONE
, /* tv_id */
2597 PROP_ssa
, /* properties_required */
2598 0, /* properties_provided */
2599 0, /* properties_destroyed */
2600 0, /* todo_flags_start */
2601 0, /* todo_flags_finish */
2604 class pass_late_warn_uninitialized
: public gimple_opt_pass
2607 pass_late_warn_uninitialized (gcc::context
*ctxt
)
2608 : gimple_opt_pass (pass_data_late_warn_uninitialized
, ctxt
)
2611 /* opt_pass methods: */
2612 opt_pass
*clone () { return new pass_late_warn_uninitialized (m_ctxt
); }
2613 virtual bool gate (function
*) { return gate_warn_uninitialized (); }
2614 virtual unsigned int execute (function
*);
2616 }; // class pass_late_warn_uninitialized
2619 pass_late_warn_uninitialized::execute (function
*fun
)
2623 vec
<gphi
*> worklist
= vNULL
;
2625 calculate_dominance_info (CDI_DOMINATORS
);
2626 calculate_dominance_info (CDI_POST_DOMINATORS
);
2627 /* Re-do the plain uninitialized variable check, as optimization may have
2628 straightened control flow. Do this first so that we don't accidentally
2629 get a "may be" warning when we'd have seen an "is" warning later. */
2630 warn_uninitialized_vars (/*warn_possibly_uninitialized=*/1);
2632 timevar_push (TV_TREE_UNINIT
);
2634 possibly_undefined_names
= new hash_set
<tree
>;
2635 hash_set
<gphi
*> added_to_worklist
;
2637 /* Initialize worklist */
2638 FOR_EACH_BB_FN (bb
, fun
)
2639 for (gsi
= gsi_start_phis (bb
); !gsi_end_p (gsi
); gsi_next (&gsi
))
2641 gphi
*phi
= gsi
.phi ();
2644 n
= gimple_phi_num_args (phi
);
2646 /* Don't look at virtual operands. */
2647 if (virtual_operand_p (gimple_phi_result (phi
)))
2650 for (i
= 0; i
< n
; ++i
)
2652 tree op
= gimple_phi_arg_def (phi
, i
);
2653 if (TREE_CODE (op
) == SSA_NAME
&& uninit_undefined_value_p (op
))
2655 worklist
.safe_push (phi
);
2656 added_to_worklist
.add (phi
);
2657 if (dump_file
&& (dump_flags
& TDF_DETAILS
))
2659 fprintf (dump_file
, "[WORKLIST]: add to initial list: ");
2660 print_gimple_stmt (dump_file
, phi
, 0);
2667 while (worklist
.length () != 0)
2670 cur_phi
= worklist
.pop ();
2671 warn_uninitialized_phi (cur_phi
, &worklist
, &added_to_worklist
);
2674 worklist
.release ();
2675 delete possibly_undefined_names
;
2676 possibly_undefined_names
= NULL
;
2677 free_dominance_info (CDI_POST_DOMINATORS
);
2678 timevar_pop (TV_TREE_UNINIT
);
2685 make_pass_late_warn_uninitialized (gcc::context
*ctxt
)
2687 return new pass_late_warn_uninitialized (ctxt
);
2691 execute_early_warn_uninitialized (void)
2693 /* Currently, this pass runs always but
2694 execute_late_warn_uninitialized only runs with optimization. With
2695 optimization we want to warn about possible uninitialized as late
2696 as possible, thus don't do it here. However, without
2697 optimization we need to warn here about "may be uninitialized". */
2698 calculate_dominance_info (CDI_POST_DOMINATORS
);
2700 warn_uninitialized_vars (/*warn_possibly_uninitialized=*/!optimize
);
2702 /* Post-dominator information can not be reliably updated. Free it
2705 free_dominance_info (CDI_POST_DOMINATORS
);
2711 const pass_data pass_data_early_warn_uninitialized
=
2713 GIMPLE_PASS
, /* type */
2714 "*early_warn_uninitialized", /* name */
2715 OPTGROUP_NONE
, /* optinfo_flags */
2716 TV_TREE_UNINIT
, /* tv_id */
2717 PROP_ssa
, /* properties_required */
2718 0, /* properties_provided */
2719 0, /* properties_destroyed */
2720 0, /* todo_flags_start */
2721 0, /* todo_flags_finish */
2724 class pass_early_warn_uninitialized
: public gimple_opt_pass
2727 pass_early_warn_uninitialized (gcc::context
*ctxt
)
2728 : gimple_opt_pass (pass_data_early_warn_uninitialized
, ctxt
)
2731 /* opt_pass methods: */
2732 virtual bool gate (function
*) { return gate_warn_uninitialized (); }
2733 virtual unsigned int execute (function
*)
2735 return execute_early_warn_uninitialized ();
2738 }; // class pass_early_warn_uninitialized
2743 make_pass_early_warn_uninitialized (gcc::context
*ctxt
)
2745 return new pass_early_warn_uninitialized (ctxt
);