PR c++/90884 - stray note with -Wctor-dtor-privacy.
[official-gcc.git] / gcc / cp / ChangeLog
blobad353142a2fc2fb5f354f7be678a2aa00d0d6e31
1 2019-06-14  Marek Polacek  <polacek@redhat.com>
3         PR c++/90884 - stray note with -Wctor-dtor-privacy.
4         * class.c (maybe_warn_about_overly_private_class): Guard the call to
5         inform.
7 2019-06-12  Jason Merrill  <jason@redhat.com>
9         PR c++/85552 - wrong instantiation of dtor for DMI.
10         * typeck2.c (digest_nsdmi_init): Set tf_no_cleanup for direct-init.
12 2019-06-13  Paolo Carlini  <paolo.carlini@oracle.com>
14         * decl.c (grokdeclarator): Use id_loc in five additional places
15         in the last part of the function.
17 2019-06-13  Paolo Carlini  <paolo.carlini@oracle.com>
19         * decl.c (grokdeclarator): Move further up the declaration of
20         id_loc, use it immediately, update its value after the loop
21         over declarator, use it again in the final part of function;
22         improve locations of error messages about multiple data types
23         and conflicting specifiers.
25 2019-06-13  Richard Biener  <rguenther@suse.de>
27         PR c++/90801
28         * typeck2.c (split_nonconstant_init_1): Properly count
29         num_split_elts, optimize single constructor elt removal.
31 2019-06-12  Marek Polacek  <polacek@redhat.com>
33         PR c++/66999 - 'this' captured by reference.
34         * parser.c (cp_parser_lambda_introducer): Reject `&this'.  Use
35         cp_lexer_nth_token_is instead of cp_lexer_peek_nth_token.
37         PR c++/90825 - endless recursion when evaluating sizeof.
38         PR c++/90832 - endless recursion when evaluating sizeof.
39         * constexpr.c (cxx_eval_constant_expression): Don't recurse on the
40         result of fold_sizeof_expr if is returns a SIZEOF_EXPR.
41         * typeck.c (cxx_sizeof_expr): Only return a SIZEOF_EXPR if the operand
42         is instantiation-dependent.
44         PR c++/90736 - bogus error with alignof.
45         * constexpr.c (adjust_temp_type): Use cv_unqualified type.
47 2019-06-11  Matthew Beliveau  <mbelivea@redhat.com>
49         PR c++/90449 - add -Winaccessible-base option.
50         * class.c (warn_about_ambiguous_bases): Changed name to:
51         maybe_warn_about_inaccessible_bases.
52         (maybe_warn_about_inaccessible_bases):  Implemented new
53         Winaccessible-base warning option for both direct and virtual
54         base warnings.
55         (layout_class_type): Call to warn_about_ambiguous_bases changed to fit
56         new name.
58 2019-06-11  Richard Biener  <rguenther@suse.de>
60         PR c++/90801
61         * typeck2.c (split_nonconstant_init_1): Avoid ordered remove
62         from CONSTRUCTOR by marking to remove elements and doing all
63         of them in a O(n) scan.
65 2019-06-11  Jakub Jelinek  <jakub@redhat.com>
67         PR c++/90810
68         * init.c (constant_value_1): Handle VECTOR_CST DECL_INITIAL for
69         !DECL_INITIALIZED_BY_CONSTANT_EXPRESSION_P decls like CONSTRUCTOR.
71 2019-06-11  Martin Liska  <mliska@suse.cz>
73         PR c++/87847
74         * pt.c (init_template_processing): Disable hash table
75         sanitization for decl_specializations and type_specializations.
77 2019-06-10  Jason Merrill  <jason@redhat.com>
79         * constexpr.c (free_constructor): New.
80         (cxx_eval_call_expression): Free parameter value CONSTRUCTORs.
82         * constexpr.c (unshare_constructor): Only unshare if T is itself a
83         CONSTRUCTOR.
84         (cxx_eval_call_expression): Don't call it on the result here.
86         Reduce constexpr_call memory consumption.
87         * constexpr.c (cxx_bind_parameters_in_call): Use TREE_VEC rather
88         than TREE_LIST.
89         (constexpr_call_hasher::equal, cxx_bind_parameters_in_call)
90         (cxx_eval_call_expression): Adjust.
92 2019-06-10  Jakub Jelinek  <jakub@redhat.com>
94         * parser.c (cp_parser_omp_clause_reduction): Don't sorry_at on inscan
95         reductions.
96         (cp_parser_omp_scan_loop_body): New function.
97         (cp_parser_omp_for_loop): Call cp_parser_omp_scan_loop_body if there
98         are inscan reduction clauses.
99         (cp_parser_pragma): Reject PRAGMA_OMP_SCAN.
100         * semantics.c (finish_omp_clauses): Reject mixing inscan with
101         non-inscan reductions on the same construct, or inscan reductions with
102         ordered or schedule clauses, or inscan array reductions.
103         * pt.c (tsubst_omp_clauses): Handle OMP_CLAUSE_{IN,EX}CLUSIVE.
104         (tsubst_expr): Handle OMP_SCAN.
106 2019-06-07  Jason Merrill  <jason@redhat.com>
108         * constexpr.c (cxx_eval_constant_expression): Call
109         STRIP_ANY_LOCATION_WRAPPER early.
110         [CONVERT_EXPR]: Don't build anything for conversion to void.
111         [ADDR_EXPR]: ggc_free unused ADDR_EXPR.
113 2019-06-05  Martin Sebor  <msebor@redhat.com>
115         PR c/90737
116         * typeck.c (maybe_warn_about_returning_address_of_local): Only
117         consider functions returning pointers as candidates for
118         -Wreturn-local-addr.
120 2019-06-05  Paolo Carlini  <paolo.carlini@oracle.com>
122         * decl.c (smallest_type_location): New.
123         (check_special_function_return_type): Use it.
124         (grokdeclarator): Lkewise.
126 2019-06-05  Paolo Carlini  <paolo.carlini@oracle.com>
128         * decl.c (grokdeclarator): Use locations[ds_friend]
129         in one place.
131 2019-06-05  Martin Sebor  <msebor@redhat.com>
133         * call.c (build_conditional_expr_1): Adjust quoting and hyphenation.
134         (convert_like_real): Same.
135         (convert_arg_to_ellipsis): Same.
136         * constexpr.c (diag_array_subscript): Same.
137         * constraint.cc (diagnose_trait_expression): Same.
138         * cvt.c (ocp_convert): Same.
139         * decl.c (start_decl): Same.
140         (check_for_uninitialized_const_var): Same.
141         (grokfndecl): Same.
142         (check_special_function_return_type): Same.
143         (finish_enum_value_list): Same.
144         (start_preparsed_function): Same.
145         * parser.c (cp_parser_decl_specifier_seq): Same.
146         * typeck.c (cp_build_binary_op): Same.
147         (build_static_cast_1): Same.
149 2019-06-04  Nina Dinka Ranns  <dinka.ranns@gmail.com>
151         PR c++/63149 - Wrong auto deduction from braced-init-list.
152         * pt.c (listify_autos): use non cv qualified auto_node in
153         std::initializer_list<auto>.
155 2019-06-04  Paolo Carlini  <paolo.carlini@oracle.com>
157         * decl.c (grokdeclarator): Use declarator->id_loc in two
158         additional places.
160 2019-06-04  Nathan Sidwell  <nathan@acm.org>
162         * name-lookup.c (lookup_type_scope_1): Reimplement, handle local
163         and namespace scopes separately.
165 2019-06-04  Harald van Dijk  <harald@gigawatt.nl>
167         PR c++/60531 - Wrong error about unresolved overloaded function
168         * typeck.c (cp_build_binary_op): See if overload can be resolved.
169         (cp_build_unary_op): Ditto.
171 2019-06-04  Jason Merrill  <jason@redhat.com>
173         Reduce accumulated garbage in constexpr evaluation.
174         * constexpr.c (cxx_eval_call_expression): ggc_free any bindings we
175         don't save.
176         (cxx_eval_increment_expression): ggc_free the MODIFY_EXPR after
177         evaluating it.
179 2019-06-04  Jakub Jelinek  <jakub@redhat.com>
181         * cp-tree.h (CP_OMP_CLAUSE_INFO): Allow for any clauses up to _condvar_
182         instead of only up to linear.
184 2019-06-03  Paolo Carlini  <paolo.carlini@oracle.com>
186         * parser.c (cp_parser_unqualified_id): Use build_min_nt_loc in
187         five places.
189 2019-06-01  Ville Voutilainen  <ville.voutilainen@gmail.com>
191         PR c++/85254
192         * class.c (fixup_type_variants): Handle CLASSTYPE_FINAL.
194 2019-05-31  Nathan Sidwell  <nathan@acm.org>
196         * cp-tree.h (IDENTIFIER_LAMBDA_P): New.
197         (TYPE_ANON_P): New.
198         (LAMBDA_TYPE_P, TYPE_UNNAMED_P):  Likewise.
199         (LAMBDANAME_PREFIX, LAMBDANAME_FORMAT): Delete.
200         (make_lambda_name): Don't declare.
201         * error.c (dump_aggr_type): Check for lambdas before other
202         anonymous names.
203         * lambda.c (begin_lambda_type): Use make_anon_name.
204         * cp-lang.c (cxx_dwarf_name): Lambda names smell anonymous.
205         * mangle.c (write_local_name): Likewise.
206         * name-lookup.c (lambda_cnt, make_lambda_name): Delete.
208 2019-05-30  Marek Polacek  <polacek@redhat.com>
210         * cp-tree.h (TYPE_HAS_NONTRIVIAL_DESTRUCTOR): Fix a typo.
212 2019-05-31  Paolo Carlini  <paolo.carlini@oracle.com>
214         * decl.c (grokdeclarator): Use declarator->id_loc in five
215         error_at calls.
217 2019-05-29  Jakub Jelinek  <jakub@redhat.com>
219         PR c++/90598
220         * tree.c (lvalue_kind): Return clk_none for expressions with
221         with VOID_TYPE_P.
223 2019-05-29  Paolo Carlini  <paolo.carlini@oracle.com>
225         PR c++/89875
226         * parser.c (cp_parser_sizeof_operand): When the type-id production
227         did not work out commit to the tentative parse.
229 2019-05-29  Jakub Jelinek  <jakub@redhat.com>
231         P1091R3 - Extending structured bindings to be more like var decls
232         P1381R1 - Reference capture of structured bindings
233         * decl.c (cp_maybe_mangle_decomp): Handle TREE_STATIC decls even at
234         function scope.
235         (cp_finish_decomp): Copy over various decl properties from decl to
236         v[i] in the tuple case.
237         (grokdeclarator): Allow static, thread_local and __thread for C++2a
238         and use pedwarn instead of error for older standard revisions.
239         Make other structured binding diagnostic messages more i18n friendly.
241 2019-05-28  Nathan Sidwell  <nathan@acm.org>
243         * decl.c (duplicate_decls): Assert a template newdecl has no
244         specializations.
246 2019-05-28  Marek Polacek  <polacek@redhat.com>
248         PR c++/90548 - ICE with generic lambda and empty pack.
249         * pt.c (tsubst_copy_and_build): Handle pack expansion properly.
251 2019-05-28  Nathan Sidwell  <nathan@acm.org>
253         * cp-tree.h (make_anon_name): Drop declaration.
254         (TYPE_UNNAMED_P): Use IDENTIFIER_ANON_P.
255         * cp-lang.c (cxx_dwarf_name): Likewise.
256         * class.c (find_flexarrays): Likewise.
257         * decl.c (name_unnamed_type, xref_tag_1): Likewise.
258         * error.c (dump_aggr_type): Likewise.
259         * pt.c (push_template_decl_real): Likewise.
260         * name-lookup.c (consider_binding_level): Likewise.
261         (anon_cnt, make_anon_name): Delete.
263 2019-05-25  Marek Polacek  <polacek@redhat.com>
265         PR c++/90572 - wrong disambiguation in friend declaration.
266         * parser.c (cp_parser_constructor_declarator_p): Don't allow missing
267         typename for friend declarations.
269 2019-05-23  Jonathan Wakely  <jwakely@redhat.com>
271         * cp-tree.h (CP_AGGREGATE_TYPE_P): Fix whitespace.
273         * init.c (std_placement_new_fn_p): Remove outdated TODO comment that
274         was resolved by r254694.
276 2019-05-22  Jason Merrill  <jason@redhat.com>
278         PR c++/20408 - unnecessary code for empty struct.
279         * call.c (build_call_a): Use simple_empty_class_p.
281         PR c++/86485 - -Wmaybe-unused with empty class ?:
282         * cp-gimplify.c (simple_empty_class_p): Also true for MODIFY_EXPR.
284 2019-05-21  Paolo Carlini  <paolo.carlini@oracle.com>
286         * parser.c (cp_parser_template_declaration_after_parameters): Use
287         DECL_SOURCE_LOCATION in literal operator template errors.
289 2019-05-21  Paolo Carlini  <paolo.carlini@oracle.com>
291         PR c++/67184
292         PR c++/69445
293         * call.c (build_over_call): Devirtualize when the final overrider
294         comes from the base.
296 2019-05-21  Nathan Sidwell  <nathan@acm.org>
298         * name-lookup.c (do_nonmember_using_decl): Drop INSERT_P
299         parameter.  Document.
300         (finish_nonmember_using_decl): Adjust do_nonmember_using_decl
301         calls.  Remove stray FIXME comment.
303         * name-lookup.h (struct cp_binding_level): Drop usings field.
304         (finish_namespace_using_decl, finish_local_using_decl): Replace with ...
305         (finish_nonmember_using_decl): ... this.
306         * name-lookup.c (push_using_decl_1, push_using_decl):
307         (do_nonmember_using_decl): ... here.  Add INSERT_P arg.  Reimplement.
308         (validate_nonmember_using_decl, finish_namespace_using_decl)
309         (finish_local_using_decl): Replace with ...
310         (finish_nonmember_using_decl): ... this.  Drop DECL parm.
311         * parser.c (cp_parser_using_declaration): Don't do lookup here.
312         * pt.c (tsubst_expr): Do not do using decl lookup here.
314 2019-05-21  Eric Botcazou  <ebotcazou@adacore.com>
316         * decl2.c (cpp_check) <IS_ASSIGNMENT_OPERATOR>: New case.
318 2019-05-20  Marek Polacek  <polacek@redhat.com>
320         CWG 2094 - volatile scalars are trivially copyable.
321         PR c++/85679
322         * tree.c (trivially_copyable_p): Don't check CP_TYPE_VOLATILE_P for
323         scalar types.
325 2019-05-20  Marek Polacek  <polacek@redhat.com>
327         * pt.c (convert_template_argument): Add a diagnostic for the
328         [temp.arg]/2 ambiguity case.
330         * name-lookup.c (finish_using_directive): Don't issue inform() if the
331         warning didn't trigger.  Add quoting.  Tweak the inform message.
333 2019-05-20  Paolo Carlini  <paolo.carlini@oracle.com>
335         * cp-tree.h: Remove remnants of CONV_NONCONVERTING.
337 2019-05-20  Nathan Sidwell  <nathan@acm.org>
339         * name-lookup.c (finish_namespace_using_directive)
340         (finish_local_using_directive): Merge to ...
341         (finish_using_directive): ... here.  Handle both contexts.
342         * name-lookup.h (finish_namespace_using_directive)
343         (finish_local_using_directive): Replace with ...
344         (finish_using_directive): ... this.
345         * parser.c (cp_parser_using_directive): Adjust.
346         * pt.c (tsubst_expr): Likewise.
348         * cp-tree.h (struct lang_decl_ns): Remove usings field.
349         (DECL_NAMESPACE_USING): Delete.
350         * name-lookup.c (name_lookup::search_usings): Use namespace's
351         binding scope.
352         (name_lookup::queue_namespae): Likewise.
353         (finish_namespace_using_directive, push_namespace): Likewise.
354         (has_using_namespace_std_directive): Just search the entire
355         binding stack.
357 2019-05-20  Jonathan Wakely  <jwakely@redhat.com>
359         PR c++/90532 Ensure __is_constructible(T[]) is false
360         * method.c (is_xible_helper): Return error_mark_node for construction
361         of an array of unknown bound.
363 2019-05-17  Thomas Schwinge  <thomas@codesourcery.com>
365         PR c++/89433
366         * parser.c (cp_finalize_oacc_routine): Rework checking if already
367         marked with an OpenACC 'routine' directive.
369         PR c++/89433
370         * parser.c (cp_parser_oacc_routine)
371         (cp_parser_late_parsing_oacc_routine): Normalize order of clauses.
372         (cp_finalize_oacc_routine): Call oacc_verify_routine_clauses.
374         PR c++/89433
375         * parser.c (cp_finalize_oacc_routine): Refer to OpenACC 'routine'
376         clauses from "omp declare target" attribute.
378 2019-05-16  Martin Sebor  <msebor@redhat.com>
380         * call.c (print_z_candidate): Wrap diagnostic text in a gettext
381         macro.  Adjust.
382         (print_z_candidates): Same.
383         (build_conditional_expr_1): Quote keywords, operators, and types
384         in diagnostics.
385         (build_op_delete_call): Same.
386         (maybe_print_user_conv_context): Wrap diagnostic text in a gettext
387         macro.
388         (convert_like_real): Same.
389         (convert_arg_to_ellipsis): Quote keywords, operators, and types
390         in diagnostics.
391         (build_over_call): Same.
392         (joust): Break up an overlong line.  Wrap diagnostic text in a gettext
393         macro.
394         * constexpr.c (cxx_eval_check_shift_p): Spell out >= in English.
395         (cxx_eval_constant_expression): Quote keywords, operators, and types
396         in diagnostics.
397         (potential_constant_expression_1): Same.
398         * cp-gimplify.c (cp_genericize_r): Same.
399         * cvt.c (maybe_warn_nodiscard): Quote keywords, operators, and types
400         in diagnostics.
401         (type_promotes_to): Same.
402         * decl.c (check_previous_goto_1): Same.
403         (check_goto): Same.
404         (start_decl): Same.
405         (cp_finish_decl): Avoid parenthesizing a sentence for consistency.
406         (grok_op_properties): Quote keywords, operators, and types
407         in diagnostics.
408         * decl2.c (grokfield): Same.
409         (coerce_delete_type): Same.
410         * except.c (is_admissible_throw_operand_or_catch_parameter): Same.
411         * friend.c (do_friend): Quote C++ tokens.
412         * init.c (build_new_1): Quote keywords, operators, and types
413         in diagnostics.
414         (build_vec_delete_1): Same.
415         (build_delete): Same.
416         * lex.c (parse_strconst_pragma): Same.
417         (handle_pragma_implementation): Same.
418         (unqualified_fn_lookup_error): Same.
419         * mangle.c (write_type): Same.
420         * method.c (defaulted_late_check): Avoid two consecutive punctuators.
421         * name-lookup.c (cp_binding_level_debug): Remove a trailing newline.
422         (pop_everything): Same.
423         * parser.c (cp_lexer_start_debugging): Quote a macro name.
424         in a diagnostic
425         (cp_lexer_stop_debugging): Same.
426         (cp_parser_userdef_numeric_literal): Quote a C++ header name
427         in a diagnostic.
428         (cp_parser_nested_name_specifier_opt): Quote keywords, operators,
429         and types in diagnostics.
430         (cp_parser_question_colon_clause): Same.
431         (cp_parser_asm_definition): Same.
432         (cp_parser_init_declarator): Same.
433         (cp_parser_template_declaration_after_parameters): Avoid capitalizing
434         a sentence in a diagnostic.
435         (cp_parser_omp_declare_reduction): Quote keywords, operators, and types
436         in diagnostics.
437         (cp_parser_transaction): Same.
438         * pt.c (maybe_process_partial_specialization): Replace second call
439         to permerror with inform for consistency with other uses.
440         (expand_integer_pack): Quote keywords, operators, and types
441         in diagnostics.
442         * rtti.c (get_typeid): Quote keywords, operators, and types
443         in diagnostics.
444         (build_dynamic_cast_1): Same.
445         * semantics.c (finish_asm_stmt): Same.
446         (finish_label_decl): Same.
447         (finish_bases): Same.
448         (finish_offsetof): Same.
449         (cp_check_omp_declare_reduction): Same.
450         (finish_decltype_type): Same.
451         * tree.c (handle_init_priority_attribute): Same.  Add detail
452         to diagnostics.
453         (maybe_warn_zero_as_null_pointer_constant): Same.
454         * typeck.c (cp_build_binary_op): Quote keywords, operators, and types
455         in diagnostics.
456         (cp_build_unary_op): Same.
457         (check_for_casting_away_constness): Same.
458         (build_static_cast): Same.
459         (build_const_cast_1): Same.
460         (maybe_warn_about_returning_address_of_local): Same.
461         (check_return_expr): Same.
462         * typeck2.c (abstract_virtuals_error_sfinae): Same.
463         (digest_init_r): Replace a tab with spaces in a diagnostic.
464         (build_functional_cast): Quote keywords, operators, and types
465         in diagnostics.
467 2019-05-15  Jakub Jelinek  <jakub@redhat.com>
469         PR debug/90197
470         * cp-gimplify.c (genericize_cp_loop): Emit a DEBUG_BEGIN_STMT
471         before the condition (or if missing or constant non-zero at the end
472         of the loop.  Emit a DEBUG_BEGIN_STMT before the increment expression
473         if any.  Don't call protected_set_expr_location on incr if it already
474         has a location.
476 2019-05-15  Marek Polacek  <polacek@redhat.com>
478         CWG 2096 - constraints on literal unions.
479         * class.c (check_field_decls): Initialize booleans directly.  A union
480         is literal if at least one of its non-static data members is of
481         non-volatile literal type.
483 2019-05-15  Paolo Carlini  <paolo.carlini@oracle.com>
485         * cp-tree.h (REFERENCE_VLA_OK): Remove.
486         * lambda.c (build_capture_proxy): Remove use of the above.
488 2019-05-15  Paolo Carlini  <paolo.carlini@oracle.com>
490         * call.c (perform_overload_resolution, build_new_method_call_1):
491         Use OVL_P; remove redundant TEMPLATE_DECL checks.
492         * decl.c (grokfndecl): Likewise.
493         * mangle.c (write_expression): Likewise.
494         * parser.c (cp_parser_template_id): Likewise.
495         * pt.c (resolve_overloaded_unification, type_dependent_expression_p):
496         Likewise.
497         * search.c (build_baselink): Likewise.
498         * tree.c (is_overloaded_fn, dependent_name, maybe_get_fns): Likewise.
500 2019-05-14  Paolo Carlini  <paolo.carlini@oracle.com>
502         PR preprocessor/90382
503         * decl.c (grokdeclarator): Fix value assigned to typespec_loc, use
504         min_location.
506 2019-05-13  Jason Merrill  <jason@redhat.com>
508         Use releasing_vec more broadly.
509         * cp-tree.h (struct releasing_vec): Replace get_ref method with
510         operator&.
511         (vec_safe_push, vec_safe_reserve, vec_safe_length, vec_safe_splice):
512         Forwarding functions for releasing_vec.
513         (release_tree_vector): Declare but don't define.
514         * call.c (build_op_delete_call, build_temp, call_copy_ctor)
515         (perform_direct_initialization_if_possible): Use releasing_vec.
516         * constexpr.c (cxx_eval_vec_init_1, cxx_eval_store_expression):
517         Likewise.
518         * cp-gimplify.c (cp_fold): Likewise.
519         * cvt.c (force_rvalue, ocp_convert): Likewise.
520         * decl.c (get_tuple_decomp_init): Likewise.
521         * except.c (build_throw): Likewise.
522         * init.c (perform_member_init, expand_default_init): Likewise.
523         * method.c (do_build_copy_assign, locate_fn_flags): Likewise.
524         * parser.c (cp_parser_userdef_char_literal)
525         (cp_parser_userdef_numeric_literal)
526         (cp_parser_userdef_string_literal)
527         (cp_parser_perform_range_for_lookup)
528         (cp_parser_range_for_member_function, cp_parser_omp_for_loop)
529         (cp_parser_omp_for_loop_init): Likewise.
530         * pt.c (tsubst_copy_and_build, do_class_deduction): Likewise.
531         * semantics.c (calculate_direct_bases, calculate_bases)
532         (finish_omp_barrier, finish_omp_flush, finish_omp_taskwait)
533         (finish_omp_taskyield, finish_omp_cancel)
534         (finish_omp_cancellation_point): Likewise.
535         * tree.c (build_vec_init_elt, strip_typedefs, strip_typedefs_expr)
536         (build_min_non_dep_op_overload): Likewise.
537         * typeck.c (build_function_call_vec, cp_build_function_call_nary)
538         (cp_build_modify_expr): Likewise.
539         * typeck2.c (build_functional_cast): Likewise.
541 2019-05-11  Paolo Carlini  <paolo.carlini@oracle.com>
543         * typeck.c (cp_build_function_call_vec): When mark_used fails
544         unconditionally return error_mark_node.
546 2019-05-10  Paolo Carlini  <paolo.carlini@oracle.com>
548         * decl.c (grokvardecl): Use an accurate location in error message
549         about main as a global variable.
551 2019-05-10  Paolo Carlini  <paolo.carlini@oracle.com>
553         * call.c (build_call_a): Use FUNC_OR_METHOD_TYPE_P.
554         * cp-gimplify.c (cp_fold): Likewise.
555         * cp-objcp-common.c (cp_type_dwarf_attribute): Likewise.
556         * cp-tree.h (TYPE_OBJ_P, TYPE_PTROBV_P): Likewise.
557         * cvt.c (perform_qualification_conversions): Likewise.
558         * decl.c (grokdeclarator): Likewise.
559         * decl2.c (build_memfn_type): Likewise.
560         * mangle.c (canonicalize_for_substitution, write_type): Likewise.
561         * parser.c (cp_parser_omp_declare_reduction): Likewise.
562         * pt.c (check_explicit_specialization, uses_deducible_template_parms,
563         check_cv_quals_for_unify, dependent_type_p_r): Likewise.
564         * rtti.c (ptr_initializer): Likewise.
565         * semantics.c (finish_asm_stmt, finish_offsetof,
566         cp_check_omp_declare_reduction): Likewise.
567         * tree.c (cp_build_qualified_type_real,
568         cp_build_type_attribute_variant, cxx_type_hash_eq,
569         cxx_copy_lang_qualifiers, cp_free_lang_data): Likewise.
570         * typeck.c (structural_comptypes, convert_arguments,
571         cp_build_addr_expr_1, unary_complex_lvalue, cp_build_c_cast,
572         cp_build_modify_expr, comp_ptr_ttypes_real, type_memfn_rqual):
573         Likewise.
575 2019-05-10  Marek Polacek  <polacek@redhat.com>
577         PR c++/78010 - bogus -Wsuggest-override warning on final function.
578         * class.c (check_for_override): Don't warn for final functions.
580 2019-05-10  Jakub Jelinek  <jakub@redhat.com>
582         PR pch/90326
583         * config-lang.in (gtfiles): Remove c-family/c-lex.c, add
584         c-family/c-cppbuiltin.c.
586 2019-05-09  Paolo Carlini  <paolo.carlini@oracle.com>
588         PR c++/90382
589         Revert:
590         2018-04-26  Paolo Carlini  <paolo.carlini@oracle.com>
592         * decl.c (grokdeclarator): Fix value assigned to typespec_loc, use
593         min_location.
595 2019-05-08  Nathan Sidwell  <nathan@acm.org>
597         Kill DECL_SAVED_FUNCTION_DATA .
598         * cp-tree.h (language_function): Remove x_auto_return_pattern.
599         (current_function_auto_return_pattern): Delete.
600         (lang_decl_fn): Replace saved_language_function with
601         saved_auto_return type.
602         (DECL_SAVED_FUNCTION_DATA): Delete.
603         (DECL_SAVED_AUTO_RETURN_TYPE): New.
604         (FNDECL_USED_AUTO): Correct documentation.
605         * decl.c (duplicate_decls): Adjust AUTO return handling.
606         (start_preparsed_function): Replace
607         current_function_auto_return_pattern with
608         DECL_SAVED_AUTO_RETURN_TYPE.  Remove DECL_SAVED_FUNCTION_DATA
609         zapping.
610         (finish_function): Likewise.
611         (save_function_data): Delete.
612         (fndecl_declared_return_type): Reimplement.
613         * mangle.c (write_unqualified_name): Use DECL_SAVED_AUTO_RETURN_TYPE.
614         * method.c (make_thunk, make_alias_for): Likewise.
615         * parser.c (cp_parser_jump_statement): Likewise.
616         * pt.c (do_auto_deduction): Likewise.
617         * typeck.c (check_return_expr): Likewise.
619 2019-05-06  Jason Merrill  <jason@redhat.com>
621         PR c++/90171 - reorganize usual_deallocation_fn_p
622         * call.c (struct dealloc_info): New.
623         (usual_deallocation_fn_p): Take a dealloc_info*.
624         (aligned_deallocation_fn_p, sized_deallocation_fn_p): Remove.
625         (build_op_delete_call): Adjust.
627 2019-05-07  Jason Merrill  <jason@redhat.com>
629         PR c++/86485 - -Wmaybe-unused with empty class ?:
630         * typeck.c (build_static_cast_1): Use cp_build_addr_expr.
632         * pt.c (type_dependent_expression_p): A non-type template parm with
633         a placeholder type is type-dependent.
635 2019-05-06  Marek Polacek  <polacek@redhat.com>
637         PR c++/90265 - ICE with generic lambda.
638         * pt.c (tsubst_copy_and_build): Use a dedicated variable for the last
639         element in the vector.
641 2019-05-03  Martin Liska  <mliska@suse.cz>
643         * call.c (build_aggr_conv): Use is_empty instead of
644         elements () == 0 (and similar usages).
645         * parser.c (cp_parser_lambda_introducer): Likewise.
647 2019-05-02  Nathan Sidwell  <nathan@acm.org>
649         * semantics.c (finish_id_expression_1): Remove unreachable code.
651 2019-05-01  Nathan Sidwell  <nathan@acm.org>
653         * name-lookup.h (get_class_binding_direct): Change final arg to
654         bool.
655         (get_class_binding): Likewise.
656         * name-lookup.c (get_class_binding_direct): Replace TYPE_OR_FNS
657         arg with WANT_TYPE bool.  Simplify.
658         (get_class_binding): Adjust final arg.
659         * decl.c (reshape_init_class): Adjust get_class_binding calls.
661 2019-04-30  Nathan Sidwell  <nathan@acm.org>
663         * cp-objcp-common.c (cp_common_init_ts): Use MARK_TS_EXP for _EXPR
664         nodes.  Call c_common_init_ts.
666 2019-04-29  Nathan Sidwell  <nathan@acm.org>
668         * decl.c (duplicate_decls): Add whitespace, move comments into
669         conditional blocks.
670         * method.c (explain_implicit_non_constexpr): Refactor.
671         * pt.c (check_explicit_specialization): Fix indentation.
672         * semantics.c (process_outer_var_ref): Reformat.
673         (finish_id_expression_1): Use STRIP_TEMPLATE.
675 2019-04-26  Jonathan Wakely  <jwakely@redhat.com>
677         PR c++/90243 - orphaned note in uninstantiated constexpr function
678         * decl.c (check_for_uninitialized_const_var): Suppress notes if no
679         error was shown.
681 2019-04-26  Paolo Carlini  <paolo.carlini@oracle.com>
683         PR c++/90173
684         * decl.c (grokdeclarator): Set type to error_mark_node
685         upon error about template placeholder type non followed
686         by a simple declarator-id.
688 2019-04-26  Paolo Carlini  <paolo.carlini@oracle.com>
690         * decl.c (grokdeclarator): Fix value assigned to typespec_loc, use
691         min_location.
693 2019-04-24  Jason Merrill  <jason@redhat.com>
695         PR c++/90227 - error with template parameter packs.
696         * pt.c (coerce_template_parms): Do add empty pack when
697         require_all_args.
699 2019-04-24  Richard Biener  <rguenther@suse.de>
701         * call.c (null_ptr_cst_p): Order checks according to expensiveness.
702         (conversion_null_warnings): Likewise.
703         * typeck.c (same_type_ignoring_top_level_qualifiers_p): Return
704         early if type1 == type2.
706 2019-04-22  Jason Merrill  <jason@redhat.com>
708         PR c++/87366 - wrong error with alias template.
709         * typeck.c (structural_comptypes): When comparing_specializations,
710         aliases are unequal.
711         (comptypes): When comparing_specializations, do structural
712         comparison.
714 2019-04-19  Jason Merrill  <jason@redhat.com>
716         PR c++/90190 - CTAD with list-constructor.
717         * pt.c (do_class_deduction): Don't try the single element deduction
718         if the single element is also a braced list.
720         PR c++/90171 - ICE with destroying delete with size_t parm.
721         * call.c (sized_deallocation_fn_p): New.  Use it instead of
722         second_parm_is_size_t in most cases.
723         (second_parm_is_size_t): Don't check for aligned.
725 2019-04-19  Paolo Carlini  <paolo.carlini@oracle.com>
727         PR c++/89900
728         * pt.c (fn_type_unification): When handling null explicit
729         arguments do not special case non-parameter packs.
731 2019-04-19  Jakub Jelinek  <jakub@redhat.com>
733         PR c++/90138
734         * pt.c (process_template_parm): Set decl to pushdecl result.  If
735         !is_non_type, also set parm to that.
737         PR c/89888
738         * decl.c (struct cp_switch): Remove outside_range_p member.
739         (push_switch): Don't clear it.
740         (pop_switch): Adjust c_do_switch_warnings caller.
741         (finish_case_label): Adjust c_add_case_label caller.
743         PR c++/90108
744         * decl.c (duplicate_decls): If remove is main variant and
745         DECL_ORIGINAL_TYPE is some other type, remove a DECL_ORIGINAL_TYPE
746         variant that has newdecl as TYPE_NAME if any.
748 2019-04-18  Jason Merrill  <jason@redhat.com>
750         PR c++/87554 - ICE with extern template and reference member.
751         * decl.c (cp_finish_decl): Don't set DECL_INITIAL of external vars.
753 2019-04-17  Jason Merrill  <jason@redhat.com>
755         PR c++/90047 - ICE with enable_if alias template.
756         * pt.c (tsubst_decl) [TYPE_DECL]: Don't put an erroneous decl in the
757         hash table when we're in SFINAE context.
759 2019-04-17  Marek Polacek  <polacek@redhat.com>
761         PR c++/90124 - bogus error with incomplete type in decltype.
762         * typeck.c (build_class_member_access_expr): Check
763         cp_unevaluated_operand.
765 2019-04-12  Jakub Jelinek  <jakub@redhat.com>
767         PR c/89933
768         * decl.c (duplicate_decls): When newdecl's type is its main variant,
769         don't try to remove it from the variant list, but instead assert
770         it has no variants.
772 2019-04-12  Martin Sebor  <msebor@redhat.com>
774         PR c/88383
775         PR c/89288
776         * parser.c (cp_parser_has_attribute_expression): Handle assignment
777         expressions.
779 2019-04-12  Jason Merrill  <jason@redhat.com>
781         * call.c (null_member_pointer_value_p): Handle an empty CONSTRUCTOR
782         of PMF type.
784 2019-04-12  Marek Polacek  <polacek@redhat.com>
786         * except.c (build_noexcept_spec): Use build_converted_constant_bool_expr
787         instead of perform_implicit_conversion_flags.
789         PR c++/87603 - constexpr functions are no longer noexcept.
790         * constexpr.c (is_sub_constant_expr): Remove unused function.
791         * cp-tree.h (is_sub_constant_expr): Remove declaration.
792         * except.c (check_noexcept_r): Don't consider a call to a constexpr
793         function noexcept.
795 2019-04-11  Jakub Jelinek  <jakub@redhat.com>
797         PR translation/90035
798         * parser.h (struct cp_parser): Add
799         type_definition_forbidden_message_arg member.
800         * parser.c (cp_debug_parser): Print it.
801         (cp_parser_check_type_definition): Pass
802         parser->type_definition_forbidden_message_arg as second argument to
803         error.
804         (cp_parser_has_attribute_expression, cp_parser_sizeof_operand): Set
805         parser->type_definition_forbidden_message_arg and use G_() with
806         %qs for parser->type_definition_forbidden_message instead of
807         building untranslatable message using concat.
809 2019-04-09  Jakub Jelinek  <jakub@redhat.com>
811         PR translation/90011
812         * typeck2.c (check_narrowing): Remove trailing space from diagnostics.
814 2019-04-08  Marek Polacek  <polacek@redhat.com>
816         * typeck2.c (digest_init_r): Don't condition the object slicing warning
817         on flag_checking.
819 2019-04-08  Paolo Carlini  <paolo.carlini@oracle.com>
821         PR c++/89914
822         * semantics.c (trait_expr_value): Don't use TYPE_NOTHROW_P
823         when maybe_instantiate_noexcept fails.
824         (classtype_has_nothrow_assign_or_copy_p): Likewise.
825         * method.c (implicitly_declare_fn): Avoid passing error_mark_node
826         to build_exception_variant.
828 2019-04-05  Marek Polacek  <polacek@redhat.com>
830         PR c++/87145 - bogus error converting class type in template arg list.
831         * pt.c (convert_nontype_argument): Don't call
832         build_converted_constant_expr if it could involve calling a conversion
833         function with a instantiation-dependent constructor as its argument.
835 2019-04-05  Martin Sebor  <msebor@redhat.com>
837         PR bootstrap/89980
838         * decl.c (reshape_init_array_1): Avoid treating empty strings
839         as zeros in array initializers.
840         Use trivial_type_p () instead of TYPE_HAS_TRIVIAL_DFLT().
842 2019-04-04  Jason Merrill  <jason@redhat.com>
844         PR c++/89948 - ICE with break in statement-expr.
845         * constexpr.c (cxx_eval_statement_list): Jumping out of a
846         statement-expr is non-constant.
848 2019-04-04  Jason Merrill  <jason@redhat.com>
850         PR c++/89966 - error with non-type auto tparm.
851         * pt.c (do_auto_deduction): Clear tf_partial.
853 2019-04-04  Jason Merrill  <jason@redhat.com>
855         PR c++/86986 - ICE with TTP with parameter pack.
856         * pt.c (coerce_template_parameter_pack): Only look at the type of a
857         non-type parameter pack.
858         (fixed_parameter_pack_p_1): Don't recurse into the type of a
859         non-type parameter pack.
860         (coerce_template_template_parms): Call add_outermost_template_args.
862 2019-04-04  Martin Sebor  <msebor@redhat.com>
864         PR c++/89974
865         PR c++/89878
866         PR c++/89833
867         PR c++/47488
868         * decl.c (reshape_init_array_1): Strip trailing zero-initializers
869         from arrays of trivial type and known size.
870         * mangle.c (write_expression): Convert braced initializer lists
871         to STRING_CSTs.
872         (write_expression): Trim trailing zero-initializers from arrays
873         of trivial type.
874         (write_template_arg_literal): Mangle strings the same as braced
875         initializer lists.
877 2019-04-03  Jason Merrill  <jason@redhat.com>
879         PR c++/81866 - ICE with member template and default targ.
880         * pt.c (tsubst_template_decl): Handle getting a type from
881         retrieve_specialization.
883         PR c++/86586 - -fcompare-debug=-Wsign-compare.
884         * typeck.c (cp_build_binary_op): Don't fold for -Wsign-compare.
886         PR c++/89331 - ICE with offsetof in incomplete class.
887         * semantics.c (finish_offsetof): Handle error_mark_node.
888         * typeck.c (build_class_member_access_expr): Call
889         complete_type_or_maybe_complain before converting to base.
891         PR c++/89917 - ICE with lambda in variadic mem-init.
892         * pt.c (make_pack_expansion): Change type_pack_expansion_p to false.
894 2019-04-01  Jason Merrill  <jason@redhat.com>
896         PR c++/86946 - ICE with function call in template argument.
897         DR 1321
898         * pt.c (iterative_hash_template_arg) [CALL_EXPR]: Use
899         dependent_name.
901 2019-04-01  Paolo Carlini  <paolo.carlini@oracle.com>
903         PR c++/62207
904         * pt.c (tsubst_copy): Deal with lookup_name not returing a variable.
906 2019-03-31  Marek Polacek  <polacek@redhat.com>
908         PR c++/89852 - ICE with C++11 functional cast with { }.
909         * constexpr.c (fold_non_dependent_expr_template): New static function
910         broken out of...
911         (fold_non_dependent_expr): ...here.
912         (fold_non_dependent_init): New function.
913         * cp-tree.h (fold_non_dependent_init): Declare.
914         * typeck2.c (massage_init_elt): Call fold_non_dependent_init instead
915         of fold_non_dependent_expr.  Don't call maybe_constant_init.
917 2019-03-30  Jason Merrill  <jason@redhat.com>
919         PR c++/89744 - ICE with specialization of member class template.
920         * pt.c (lookup_template_class_1): If the partial instantiation is
921         explicitly specialized, adjust.
922         (maybe_process_partial_specialization): Also adjust
923         CLASSTYPE_TI_ARGS.
925 2019-03-29  Jakub Jelinek  <jakub@redhat.com>
927         PR sanitizer/89869
928         * typeck.c: Include gimplify.h.
929         (cp_build_modify_expr) <case COND_EXPR>: Unshare rhs before using it
930         for second time.  Formatting fixes.
932 2019-03-29  Marek Polacek  <polacek@redhat.com>
934         PR c++/89876 - ICE with deprecated conversion.
935         * call.c (convert_like_real): Only give warnings with tf_warning.
937 2019-03-28  Marek Polacek  <polacek@redhat.com>
939         PR c++/89612 - ICE with member friend template with noexcept.
940         * pt.c (maybe_instantiate_noexcept): For function templates, use their
941         template result (function decl).  Don't set up local specializations.
942         Temporarily turn on processing_template_decl.  Update the template type
943         too.
945         PR c++/89836 - bool constant expression and explicit conversions.
946         * call.c (build_converted_constant_expr_internal): New function,
947         renamed from...
948         (build_converted_constant_expr): ...this.  New.
949         (build_converted_constant_bool_expr): New.
950         * cp-tree.h (build_converted_constant_bool_expr): Declare.
951         * decl.c (build_explicit_specifier): Call
952         build_converted_constant_bool_expr.
954 2019-03-28  Jakub Jelinek  <jakub@redhat.com>
956         PR c++/89785
957         * constexpr.c (struct check_for_return_continue_data): New type.
958         (check_for_return_continue): New function.
959         (potential_constant_expression_1) <case SWITCH_STMT>: Walk
960         SWITCH_STMT_BODY to find RETURN_EXPRs or CONTINUE_STMTs not nested
961         in loop bodies and set *jump_target to that if found.
963 2019-03-27  Jason Merrill  <jason@redhat.com>
965         PR c++/89831 - error with qualified-id in const member function.
966         * semantics.c (finish_non_static_data_member): Use object cv-quals
967         in scoped case, too.
969         PR c++/89421 - ICE with lambda in template parameter list.
970         * parser.c (cp_parser_lambda_expression): Also reject a lambda in a
971         template parameter list before C++20.
972         * pt.c (type_dependent_expression_p): True for LAMBDA_EXPR.
973         * semantics.c (begin_class_definition): Restore error about defining
974         non-lambda class in template parm list.
976 2019-03-26  Jason Merrill  <jason@redhat.com>
978         PR c++/86932 - missed SFINAE with empty pack.
979         * pt.c (coerce_template_parms): Don't add an empty pack if
980         tf_partial.
981         (fn_type_unification): Pass tf_partial to coerce_template_parms.
983         PR c++/86429 - constexpr variable in lambda.
984         PR c++/82643
985         PR c++/87327
986         * constexpr.c (cxx_eval_constant_expression): In a lambda function,
987         try evaluating the captured variable directly.
989 2019-03-26  Jakub Jelinek  <jakub@redhat.com>
991         PR c++/89796
992         * semantics.c (finish_omp_atomic): Add warning_sentinel for
993         -Wunused-value around finish_expr_stmt call.
995 2019-03-25  Paolo Carlini  <paolo.carlini@oracle.com>
997         PR c++/84661
998         PR c++/85013
999         * parser.c (cp_parser_binary_expression): Don't call cp_fully_fold
1000         to undo the disabling of warnings.
1002 2019-03-25  Jason Merrill  <jason@redhat.com>
1004         PR c++/87748 - substitution failure error with decltype.
1005         * pt.c (most_specialized_partial_spec): Clear
1006         processing_template_decl.
1008 2019-03-25  Marek Polacek  <polacek@redhat.com>
1010         PR c++/89214 - ICE when initializing aggregates with bases.
1011         * typeck2.c (digest_init_r): Warn about object slicing instead of
1012         crashing.
1014         PR c++/89705 - ICE with reference binding with conversion function.
1015         * call.c (reference_binding): If the result of the conversion function
1016         is a prvalue of non-class type, use the cv-unqualified type.
1018 2019-03-25  Nathan Sidwell  <nathan@acm.org>
1020         * lambda.c (maybe_add_lambda_conv_op): Don't add to comdat group.
1022 2019-03-22  Jakub Jelinek  <jakub@redhat.com>
1024         PR c++/60702
1025         * cp-tree.h (get_tls_wrapper_fn): Remove declaration.
1026         (maybe_get_tls_wrapper_call): Declare.
1027         * decl2.c (get_tls_wrapper_fn): Make static.
1028         (maybe_get_tls_wrapper_call): New function.
1029         * typeck.c (build_class_member_access_expr): Handle accesses to TLS
1030         variables.
1031         * semantics.c (finish_qualified_id_expr): Likewise.
1032         (finish_id_expression_1): Use maybe_get_tls_wrapper_call.
1033         * pt.c (tsubst_copy_and_build): Likewise.
1035         PR c++/87481
1036         * constexpr.c (struct constexpr_ctx): Add constexpr_ops_count member.
1037         (cxx_eval_constant_expression): When not skipping, not constant class
1038         or location wrapper, increment *ctx->constexpr_ops_count and if it is
1039         above constexpr_loop_nest_limit, diagnose failure.
1040         (cxx_eval_outermost_constant_expr): Add constexpr_ops_count and
1041         initialize ctx.constexpr_ops_count to its address.
1042         (is_sub_constant_expr): Likewise.
1044 2019-03-21  Jakub Jelinek  <jakub@redhat.com>
1046         PR c++/71446
1047         * call.c (filed_in_pset): Change pset from hash_set<tree> * to
1048         hash_set<tree, true> &, adjust uses accordingly.
1049         (build_aggr_conv): Change pset from hash_set<tree> *
1050         to hash_set<tree, true>.  Replace goto fail; with return NULL;,
1051         adjust pset uses.
1053         PR c++/89767
1054         * parser.c (cp_parser_lambda_introducer): Add ids and first_capture_id
1055         variables, check for duplicates in this function.
1056         * lambda.c (add_capture): Don't check for duplicates nor use
1057         IDENTIFIER_MARKED.
1058         (register_capture_members): Don't clear IDENTIFIER_MARKED here.
1060 2019-03-21  Paolo Carlini  <paolo.carlini@oracle.com>
1062         PR c++/89571
1063         * method.c (after_nsdmi_defaulted_late_checks): Avoid passing
1064         error_mark_node to comp_except_specs.
1066 2019-03-20  Jason Merrill  <jason@redhat.com>
1068         PR c++/87480 - decltype of member access in default template arg
1069         * pt.c (type_unification_real): Accept a dependent result in
1070         template context.
1072 2019-03-19  Martin Sebor  <msebor@redhat.com>
1074         PR tree-optimization/89688
1075         * typeck2.c (store_init_value): Call braced_lists_to_string for more
1076         kinds of initializers.
1078 2019-03-18  Jason Merrill  <jason@redhat.com>
1080         PR c++/89630 - ICE with dependent using-decl as template arg.
1081         * tree.c (cp_tree_equal): Always return false for USING_DECL.
1083         PR c++/89761 - ICE with sizeof... in pack expansion.
1084         * pt.c (argument_pack_element_is_expansion_p): Handle
1085         ARGUMENT_PACK_SELECT.
1087         PR c++/89640 - GNU attributes on lambda.
1088         * parser.c (cp_parser_lambda_declarator_opt): Allow GNU attributes.
1090         PR c++/89682 - wrong access error in default argument.
1091         * pt.c (tsubst_default_argument): Don't defer access checks.
1093 2019-03-18  Paolo Carlini  <paolo.carlini@oracle.com>
1095         PR c++/85014
1096         * semantics.c (finish_non_static_data_member): Check return value
1097         of context_for_name_lookup and immediately return error_mark_node
1098         if isn't a type.
1100 2019-03-17  Jason Merrill  <jason@redhat.com>
1102         PR c++/89571 - ICE with ill-formed noexcept on constructor.
1103         * pt.c (maybe_instantiate_noexcept): Only return false if defaulted.
1104         (regenerate_decl_from_template): Use it for noexcept-specs.
1106 2019-03-14  Jason Merrill  <jason@redhat.com>
1108         * parser.c (cp_parser_decl_specifier_seq): Support C++20
1109         concept-definition syntax without 'bool'.
1111 2019-03-14  Jakub Jelinek  <jakub@redhat.com>
1113         PR c++/89512
1114         * semantics.c (finish_qualified_id_expr): Reject variable templates.
1116         PR c++/89652
1117         * constexpr.c (struct constexpr_ctx): Change save_exprs type from
1118         hash_set<tree> to vec<tree>.
1119         (cxx_eval_call_expression): Adjust for save_exprs being a vec instead
1120         of hash_set.
1121         (cxx_eval_loop_expr): Likewise.  Truncate the vector after each
1122         removal of SAVE_EXPRs from values.
1123         (cxx_eval_constant_expression) <case SAVE_EXPR>: Call safe_push
1124         method on save_exprs instead of add.
1126 2019-03-13  Jason Merrill  <jason@redhat.com>
1128         PR c++/86521 - C++17 copy elision in initialization by constructor.
1129         * call.c (joust_maybe_elide_copy): New.
1130         (joust): Call it.
1132 2019-03-13  Marek Polacek  <polacek@redhat.com>
1134         PR c++/88979 - further P0634 fix for constructors.
1135         * parser.c (cp_parser_decl_specifier_seq): Pass flags to
1136         cp_parser_constructor_declarator_p.
1137         (cp_parser_direct_declarator): Allow missing typename for constructor
1138         parameters.
1139         (cp_parser_constructor_declarator_p): Add FLAGS parameter.  Pass it to
1140         cp_parser_type_specifier.
1142         PR c++/89686 - mixing init-capture and simple-capture in lambda.
1143         * parser.c (cp_parser_lambda_introducer): Give error when combining
1144         init-capture and simple-capture.
1146         PR c++/89660 - bogus error with -Wredundant-move.
1147         * typeck.c (maybe_warn_pessimizing_move): Only accept (T &) &arg
1148         as the std::move's argument.  Don't call convert_for_initialization
1149         when warn_redundant_move isn't on.
1151 2019-03-11  Jason Merrill  <jason@redhat.com>
1153         PR c++/86521 - wrong overload resolution with ref-qualifiers.
1154         * call.c (build_user_type_conversion_1): Don't use a conversion to a
1155         reference of the wrong rvalueness for direct binding.
1157 2019-03-11  Martin Liska  <mliska@suse.cz>
1159         * cvt.c (build_expr_type_conversion): Wrap apostrophes
1160         in gcc internal format with %'.
1161         * decl.c (check_no_redeclaration_friend_default_args): Likewise.
1162         (grokfndecl): Likewise.
1163         * name-lookup.c (do_pushtag): Likewise.
1164         * pt.c (unify_parameter_deduction_failure): Likewise.
1165         (unify_template_deduction_failure): Likewise.
1167 2019-03-11  Martin Liska  <mliska@suse.cz>
1169         * call.c (convert_arg_to_ellipsis): Wrap an option name
1170         in a string format message and fix GNU coding style.
1171         (build_over_call): Likewise.
1172         * class.c (check_field_decl): Likewise.
1173         (layout_nonempty_base_or_field): Likewise.
1174         * constexpr.c (cxx_eval_loop_expr): Likewise.
1175         * cvt.c (type_promotes_to): Likewise.
1176         * decl.c (cxx_init_decl_processing): Likewise.
1177         (mark_inline_variable): Likewise.
1178         (grokdeclarator): Likewise.
1179         * decl2.c (record_mangling): Likewise.
1180         * error.c (maybe_warn_cpp0x): Likewise.
1181         * except.c (doing_eh): Likewise.
1182         * mangle.c (maybe_check_abi_tags): Likewise.
1183         * parser.c (cp_parser_diagnose_invalid_type_name): Likewise.
1184         (cp_parser_userdef_numeric_literal): Likewise.
1185         (cp_parser_primary_expression): Likewise.
1186         (cp_parser_unqualified_id): Likewise.
1187         (cp_parser_pseudo_destructor_name): Likewise.
1188         (cp_parser_builtin_offsetof): Likewise.
1189         (cp_parser_lambda_expression): Likewise.
1190         (cp_parser_lambda_introducer): Likewise.
1191         (cp_parser_lambda_declarator_opt): Likewise.
1192         (cp_parser_selection_statement): Likewise.
1193         (cp_parser_init_statement): Likewise.
1194         (cp_parser_decomposition_declaration): Likewise.
1195         (cp_parser_function_specifier_opt): Likewise.
1196         (cp_parser_static_assert): Likewise.
1197         (cp_parser_simple_type_specifier): Likewise.
1198         (cp_parser_namespace_definition): Likewise.
1199         (cp_parser_using_declaration): Likewise.
1200         (cp_parser_ctor_initializer_opt_and_function_body): Likewise.
1201         (cp_parser_initializer_list): Likewise.
1202         (cp_parser_type_parameter_key): Likewise.
1203         (cp_parser_member_declaration): Likewise.
1204         (cp_parser_try_block): Likewise.
1205         (cp_parser_std_attribute_spec): Likewise.
1206         (cp_parser_requires_clause_opt): Likewise.
1207         * pt.c (check_template_variable): Likewise.
1208         (check_default_tmpl_args): Likewise.
1209         (push_tinst_level_loc): Likewise.
1210         (instantiate_pending_templates): Likewise.
1211         (invalid_nontype_parm_type_p): Likewise.
1212         * repo.c (get_base_filename): Likewise.
1213         * rtti.c (typeid_ok_p): Likewise.
1214         (build_dynamic_cast_1): Likewise.
1215         * tree.c (maybe_warn_parm_abi): Likewise.
1217 2019-03-08  Jakub Jelinek  <jakub@redhat.com>
1219         PR other/80058
1220         * parser.c (cp_parser_template_declaration_after_parameters): Avoid
1221         one space before " at the end of line and another after " on another
1222         line in a string literal.
1224         PR tree-optimization/89550
1225         * semantics.c (maybe_convert_cond): Only set TREE_NO_WARNING if
1226         warning_at returned true.
1227         * decl2.c (c_parse_final_cleanups): Likewise.
1228         * typeck.c (convert_for_assignment): Likewise.
1229         * decl.c (finish_function): Likewise.
1231         PR c++/89585
1232         * parser.c (cp_parser_asm_definition): Just warn instead of error
1233         on volatile qualifier outside of function body.
1235         PR c++/89599
1236         * constexpr.c (potential_constant_expression_1): Reject
1237         REINTERPRET_CAST_P NOP_EXPRs.
1239         PR c++/89622
1240         * call.c (joust): Call print_z_candidate only if pedwarn returned
1241         true.
1243 2019-03-07  Jason Merrill  <jason@redhat.com>
1245         PR c++/88123 - lambda and using-directive.
1246         * name-lookup.c (op_unqualified_lookup)
1247         (maybe_save_operator_binding, discard_operator_bindings)
1248         (push_operator_bindings): New.
1249         * typeck.c (build_x_binary_op, build_x_unary_op): Call
1250         maybe_save_operator_binding.
1251         * decl.c (start_preparsed_function): Call push_operator_bindings.
1252         * tree.c (cp_free_lang_data): Call discard_operator_bindings.
1254         PR c++/88820 - ICE with CTAD and member template used in DMI.
1255         * pt.c (do_class_deduction): Handle parm used as its own arg.
1257 2019-03-07  Jakub Jelinek  <jakub@redhat.com>
1259         PR c++/89585
1260         * parser.c (cp_parser_asm_definition): Parse asm qualifiers even
1261         at toplevel, but diagnose them.
1263 2019-03-06  Jason Merrill  <jason@redhat.com>
1265         PR c++/89381 - implicit copy and using-declaration.
1266         * class.c (classtype_has_move_assign_or_move_ctor_p): Don't consider
1267         op= brought in by a using-declaration.
1269 2019-03-06  Jakub Jelinek  <jakub@redhat.com>
1271         PR c++/87148
1272         * init.c (build_value_init_noctor): Ignore flexible array members.
1274 2019-03-06  Jason Merrill  <jason@redhat.com>
1276         PR c++/89576 - if constexpr of lambda capture.
1277         * semantics.c (maybe_convert_cond): Do convert a non-dependent
1278         condition in a template.
1279         * typeck.c (condition_conversion): Handle being called in a
1280         template.
1282 2019-03-06  Marek Polacek  <polacek@redhat.com>
1284         PR c++/87378 - bogus -Wredundant-move warning.
1285         * typeck.c (maybe_warn_pessimizing_move): See if the maybe-rvalue
1286         overload resolution would actually succeed.
1288 2019-03-05  Jason Merrill  <jason@redhat.com>
1290         * class.c (is_really_empty_class): Add ignore_vptr parm.
1291         (trivial_default_constructor_is_constexpr): Pass it.
1292         * call.c (build_over_call): Pass it.
1293         * constexpr.c (cxx_eval_constant_expression): Pass it instead of
1294         checking TYPE_POLYMORPHIC_P.
1295         (cxx_eval_component_reference, potential_constant_expression_1):
1296         Pass it.
1297         * cp-gimplify.c (simple_empty_class_p): Pass it.
1298         * init.c (expand_aggr_init_1): Pass it.
1300 2019-03-04  Paolo Carlini  <paolo.carlini@oracle.com>
1302         PR c++/84605
1303         * parser.c (cp_parser_class_head): Reject TYPE_BEING_DEFINED too.
1305 2019-03-04  Jakub Jelinek  <jakub@redhat.com>
1307         PR c++/71446
1308         * call.c (field_in_pset): New function.
1309         (build_aggr_conv): Handle CONSTRUCTOR_IS_DESIGNATED_INIT correctly.
1311 2019-03-02  Jakub Jelinek  <jakub@redhat.com>
1313         PR c++/71446
1314         * cp-tree.h (CONSTRUCTOR_IS_DESIGNATED_INIT): Define.
1315         * parser.c (cp_parser_braced_list): Adjust cp_parser_initializer_list
1316         caller, set CONSTRUCTOR_IS_DESIGNATED_INIT.
1317         (cp_parser_initializer_list): Add designated parameter, set *designated
1318         to a bool whether any designators were parsed.
1319         * decl.c (reshape_init): Copy over CONSTRUCTOR_IS_DESIGNATED_INIT if
1320         needed.
1321         * pt.c (tsubst_copy_and_build): Likewise.
1322         * call.c (implicit_conversion): If CONSTRUCTOR_IS_DESIGNATED_INIT,
1323         don't call build_list_conv, nor build_complex_conv, nor attempt to
1324         convert a single element initializer to scalar.
1326 2019-03-01  Marek Polacek  <polacek@redhat.com>
1328         PR c++/89537 - missing location for error with non-static member fn.
1329         * call.c (resolve_args): Use EXPR_LOCATION.
1330         * typeck.c (build_class_member_access_expr): Use input_location.
1332         PR c++/89532 - ICE with incomplete type in decltype.
1333         * semantics.c (finish_compound_literal): Return error_mark_node
1334         if digest_init_flags returns error_mark_node.
1336 2019-03-01  Jakub Jelinek  <jakub@redhat.com>
1338         Implement P1002R1, Try-catch blocks in constexpr functions
1339         PR c++/89513
1340         * parser.c (cp_parser_ctor_initializer_opt_and_function_body):
1341         Diagnose constexpr ctor or function with function-try-block with
1342         pedwarn for c++17 and earlier.  Formatting fix.
1343         (cp_parser_try_block): Use pedwarn instead of error and only for
1344         c++17 and earlier when try block appears in constexpr function.
1345         * constexpr.c (build_constexpr_constructor_member_initializers):
1346         Handle TRY_BLOCK here instead of erroring on it.
1348 2019-02-28  Jason Merrill  <jason@redhat.com>
1350         PR c++/88183 - ICE with .* fold-expression.
1351         * pt.c (fold_expression) [DOTSTAR_EXPR]: Remove special handling.
1353         PR c++/86969 - ICE with constexpr if and recursive generic lambdas.
1354         * class.c, lambda.c, pt.c: Revert earlier change.
1355         * lambda.c (add_capture): Don't special-case capture of dependent
1356         VLA.
1358         * name-lookup.c (print_binding_level): Print this_entity.
1360 2019-02-27  Marek Polacek  <polacek@redhat.com>
1362         PR c++/88857 - ICE with value-initialization of argument in template.
1363         * call.c (convert_like_real): Don't call build_value_init in template.
1365 2019-02-27  Jason Merrill  <jason@redhat.com>
1367         PR c++/86969 - ICE with constexpr if and recursive generic lambdas.
1368         * semantics.c (process_outer_var_ref): Do capture dependent vars.
1369         * class.c (finish_struct): Only add TAG_DEFN if T is in
1370         current_function_decl.
1371         * lambda.c (vla_capture_type): Force the capture type out into the
1372         lambda's enclosing function.
1373         (add_capture): Pass in the lambda.
1374         * pt.c (tsubst_lambda_expr): complete_type a VLA capture type.
1376 2019-02-27  Marek Polacek  <polacek@redhat.com>
1378         PR c++/89511 - ICE with using-declaration and unscoped enumerator.
1379         * parser.c (cp_parser_using_declaration): For an unscoped enum
1380         only use its context if it's not a function declaration.
1382 2019-02-27  Paolo Carlini  <paolo.carlini@oracle.com>
1384         PR c++/89488
1385         * method.c (process_subob_fn): When maybe_instantiate_noexcept
1386         returns false don't call merge_exception_specifiers.
1388 2019-02-27  Paolo Carlini  <paolo.carlini@oracle.com>
1390         PR c++/88987
1391         * parser.c (cp_parser_noexcept_specification_opt): Return NULL_TREE
1392         for a non-constant parsed expression.
1394 2019-02-26  Jakub Jelinek  <jakub@redhat.com>
1396         PR c++/89481
1397         * constexpr.c (cxx_eval_store_expression): When changing active union
1398         member, set no_zero_init.
1400 2019-02-23  Marek Polacek  <polacek@redhat.com>
1402         PR c++/88294 - ICE with non-constant noexcept-specifier.
1403         * pt.c (maybe_instantiate_noexcept): Set up the list of local
1404         specializations.  Set current_class_{ptr,ref}.
1406 2019-02-22  David Malcolm  <dmalcolm@redhat.com>
1408         PR c++/89390
1409         * parser.c (cp_parser_unqualified_id): Capture and use locations
1410         for destructors.
1412 2019-02-22  Marek Polacek  <polacek@redhat.com>
1414         PR c++/89420 - ICE with CAST_EXPR in explicit-specifier.
1415         * decl.c (build_explicit_specifier): Don't check
1416         processing_template_decl.  Call instantiation_dependent_expression_p
1417         instead of value_dependent_expression_p.  Call
1418         instantiate_non_dependent_expr_sfinae before
1419         build_converted_constant_expr instead of calling
1420         instantiate_non_dependent_expr after it.  Add
1421         processing_template_decl_sentinel.
1423 2019-02-22  Thomas Schwinge  <thomas@codesourcery.com>
1425         * parser.c (cp_parser_oacc_simple_clause): Remove parser formal
1426         parameter, move loc formal parameter to the front.  Adjust all
1427         users.
1428         (cp_parser_oacc_shape_clause): Add loc formal parameter.  Adjust
1429         all users.
1431 2019-02-21  Jason Merrill  <jason@redhat.com>
1433         PR c++/87685 - generic lambda 'this' capture error.
1434         * lambda.c (lambda_expr_this_capture): Change add_capture_p to int.
1435         (maybe_generic_this_capture): Pass -1.
1437         PR c++/88394 - ICE with VLA init-capture.
1438         * lambda.c (is_normal_capture_proxy): Check DECL_CAPTURED_VARIABLE.
1440         PR c++/88869 - C++17 ICE with CTAD and explicit specialization.
1441         * pt.c (do_class_deduction): Don't include explicit specialization
1442         args in outer_args.
1444         PR c++/89422 - ICE with -g and lambda in default arg in template.
1445         * pt.c (tsubst_function_decl): SET_DECL_FRIEND_CONTEXT sooner.
1447 2019-02-21  Jason Merrill  <jason@redhat.com>
1449         PR c++/88419 - C++17 ICE with class template arg deduction.
1450         * pt.c (make_template_placeholder): Set TYPE_CANONICAL after
1451         CLASS_PLACEHOLDER_TEMPLATE.
1453 2019-02-21  Jakub Jelinek  <jakub@redhat.com>
1455         PR c++/89285
1456         * constexpr.c (struct constexpr_fundef): Add parms and result members.
1457         (retrieve_constexpr_fundef): Adjust for the above change.
1458         (register_constexpr_fundef): Save constexpr body with copy_fn,
1459         temporarily set DECL_CONTEXT on DECL_RESULT before that.
1460         (get_fundef_copy): Change FUN argument to FUNDEF with
1461         constexpr_fundef * type, grab body and parms/result out of
1462         constexpr_fundef struct and temporarily change it for copy_fn calls
1463         too.
1464         (cxx_eval_builtin_function_call): For __builtin_FUNCTION temporarily
1465         adjust current_function_decl from ctx->call context.  Test
1466         !potential_constant_expression instead of !is_constant_expression.
1467         (cxx_bind_parameters_in_call): Grab parameters from new_call.  Undo
1468         convert_for_arg_passing changes for TREE_ADDRESSABLE type passing.
1469         (cxx_eval_call_expression): Adjust get_fundef_copy caller.
1470         (cxx_eval_conditional_expression): For IF_STMT, allow then or else
1471         operands to be NULL.
1472         (label_matches): Handle BREAK_STMT and CONTINUE_STMT.
1473         (cxx_eval_loop_expr): Add support for FOR_STMT, WHILE_STMT and DO_STMT.
1474         (cxx_eval_switch_expr): Add support for SWITCH_STMT.
1475         (cxx_eval_constant_expression): Handle IF_STMT, FOR_STMT, WHILE_STMT,
1476         DO_STMT, CONTINUE_STMT, SWITCH_STMT, BREAK_STMT and CONTINUE_STMT.
1477         For SIZEOF_EXPR, recurse on the result of fold_sizeof_expr.  Ignore
1478         DECL_EXPR with USING_DECL operand.
1479         * lambda.c (maybe_add_lambda_conv_op): Build thisarg using
1480         build_int_cst to make it a valid constant expression.
1482 2019-02-20  Jason Merrill  <jason@redhat.com>
1484         PR c++/88690 - C++17 ICE with empty base in aggregate.
1485         * typeck2.c (process_init_constructor_record): Skip trivial
1486         initialization of an empty base.
1488 2019-02-21  Richard Biener  <rguenther@suse.de>
1490         PR middle-end/89392
1491         * vtable-class-hierarchy.c (vtv_generate_init_routine): Do not
1492         make symtab process new functions here.
1494 2019-02-20  Jason Merrill  <jason@redhat.com>
1496         PR c++/87921 - wrong error with inline static data member.
1497         * decl2.c (finish_static_data_member_decl): Don't set DECL_IN_AGGR_P
1498         for a non-template inline variable.  Do nothing for an
1499         already-instantiated variable.
1500         (c_parse_final_cleanups): Check DECL_IN_AGGR_P without
1501         DECL_INLINE_VAR_P.
1502         * decl.c (check_initializer): Likewise.
1503         (make_rtl_for_nonlocal_decl): Likewise.
1504         * pt.c (instantiate_decl): Likewise.
1505         * typeck2.c (store_init_value): Likewise.
1507 2019-02-20  Jakub Jelinek  <jakub@redhat.com>
1509         PR c++/89403
1510         * decl2.c (c_parse_final_cleanups): Move TREE_ASM_WRITTEN setting
1511         for flag_syntax_only from here...
1512         * semantics.c (expand_or_defer_fn_1): ... here.
1514         PR c++/89405
1515         * decl.c (maybe_commonize_var): When clearing TREE_PUBLIC and
1516         DECL_COMMON, set DECL_INTERFACE_KNOWN.
1518         PR c++/89336
1519         * constexpr.c (cxx_eval_store_expression): Diagnose changing of active
1520         union member for -std=c++17 and earlier.
1522 2019-02-19  Jason Merrill  <jason@redhat.com>
1524         PR c++/87513 - 'sorry' mangling PMF template-id.
1525         * mangle.c (write_expression): Handle SCOPE_REF to BASELINK.
1527 2019-02-19  Jason Merrill  <jason@redhat.com>
1529         PR c++/88380 - wrong-code with flexible array and NSDMI.
1530         * typeck2.c (process_init_constructor_record): Skip flexarrays.
1532 2019-02-20  will wray  <wjwray@gmail.com>
1534         PR c++/88572 - wrong handling of braces on scalar init.
1535         * decl.c (reshape_init_r): Allow braces around scalar initializer
1536         within aggregate init.  Reject double braced-init of scalar
1537         variable.
1539 2019-02-20  Paolo Carlini  <paolo.carlini@oracle.com>
1541         PR c++/84536
1542         * pt.c (tsubst_init): Diagnose an initializer expanding to an
1543         empty list of expressions; tweak wrt dependent types.
1544         (regenerate_decl_from_template): For VAR_DECLs call tsubst_init
1545         instead of tsubst_expr.
1547 2019-02-19  Jason Merrill  <jason@redhat.com>
1549         PR c++/88368 - wrong 'use of deleted function'
1550         * method.c (walk_field_subobs): Remember errors from get_nsdmi.
1551         (get_defaulted_eh_spec): Call push_tinst_level.
1552         * pt.c (maybe_instantiate_noexcept): Keep error_mark_node.
1553         * typeck2.c (merge_exception_specifiers): Handle error_mark_node.
1555 2019-02-19  Chung-Lin Tang <cltang@codesourcery.com>
1557         PR c/87924
1558         * parser.c (cp_parser_oacc_clause_wait): Add representation of wait
1559         clause without argument as 'wait (GOMP_ASYNC_NOVAL)', adjust comments.
1561 2019-02-19  Jakub Jelinek  <jakub@redhat.com>
1563         PR c++/89387
1564         * lambda.c (maybe_generic_this_capture): Don't check
1565         DECL_NONSTATIC_MEMBER_FUNCTION_P on USING_DECLs.
1567         PR c++/89391
1568         * typeck.c (build_reinterpret_cast_1): Don't handle void to
1569         && conversion go through build_target_expr_with_type.
1571         PR c++/89390
1572         * error.c (qualified_name_lookup_error): Only call
1573         suggest_alternative_in_scoped_enum if name is IDENTIFIER_NODE.
1575 2019-02-19  Tom Honermann  <tom@honermann.net>
1577         * name-lookup.c (get_std_name_hint): Added u8string as a name hint.
1579 2019-02-18  Jason Merrill  <jason@redhat.com>
1581         PR c++/89336 - multiple stores in constexpr stmt.
1582         * constexpr.c (cxx_eval_store_expression): Preevaluate scalar or
1583         assigned value.
1585         * pt.c (check_explicit_specialization): If the declarator is a
1586         template-id, only check whether the arguments are dependent.
1588         Improve duplicate [[likely]] diagnostic.
1589         * parser.c (cp_parser_statement): Make attrs_loc a range.  Pass it
1590         to process_stmt_hotness_attribute.
1591         * cp-gimplify.c (process_stmt_hotness_attribute): Take attrs_loc.
1592         (genericize_if_stmt): Use likely/unlikely instead of predictor_name.
1594 2019-02-17  Marek Polacek  <polacek@redhat.com>
1596         PR c++/89217 - ICE with list-initialization in range-based for loop.
1597         * constexpr.c (unshare_constructor): No longer static.
1598         * cp-tree.h (unshare_constructor): Declare.
1599         * semantics.c (finish_compound_literal): When dealing with a
1600         non-dependent expression in a template, return the original
1601         expression.  Pass LOOKUP_NO_NARROWING to digest_init_flags.
1603 2019-02-13  Marek Polacek  <polacek@redhat.com>
1605         PR c++/89297 - ICE with OVERLOAD in template.
1606         * semantics.c (finish_compound_literal): Call
1607         instantiate_non_dependent_expr_sfinae.
1609 2019-02-13  Alexandre Oliva <aoliva@redhat.com>
1611         PR c++/86379
1612         * cp-tree.h (USING_DECL_SCOPE): Use result rather than type.
1613         * name-lookup.c (strip_using_decl): Use USING_DECL_SCOPE.
1614         * search.c (protected_accessible_p): Follow USING_DECL_DECLS.
1615         (shared_member_p): Likewise.
1616         (lookup_member): Likewise.
1617         * decl.c (grok_special_member_properties): Skip USING_DECLs.
1618         * semantics.c (finish_omp_declare_simd_methods): Likewise.
1619         (finish_qualified_id_expr): Do not call shared_member_p with
1620         a dependent expr.
1622         PR c++/87322
1623         * pt.c (tsubst_lambda_expr): Avoid duplicate tsubsting.
1624         Move cp_evaluated resetting before signature tsubsting.
1625         (gen_elem_of_pack_expansion_instantiation): Separate local
1626         specializations per index.
1628 2019-02-13  David Malcolm  <dmalcolm@redhat.com>
1630         PR c++/89036
1631         * class.c (add_method): Drop destructor assertion.
1633 2019-02-13  Paolo Carlini  <paolo.carlini@oracle.com>
1635         PR c++/88986
1636         * decl.c (make_typename_type): Allow for TYPE_PACK_EXPANSION as
1637         context (the first argument).
1638         * pt.c (tsubst, case TYPENAME_TYPE): Handle TYPE_PACK_EXPANSION
1639         as context.
1641 2019-02-12  Jason Merrill  <jason@redhat.com>
1643         PR c++/89144 - link error with constexpr initializer_list.
1644         * call.c (convert_like_real) [ck_list]: Don't allocate a temporary
1645         array for an empty list.
1646         * typeck2.c (store_init_value): Don't use cxx_constant_init in a
1647         template.
1649 2019-02-11  Jason Merrill  <jason@redhat.com>
1651         PR c++/89241 - ICE with __func__ in lambda in template.
1652         * pt.c (enclosing_instantiation_of): Also check
1653         instantiated_lambda_fn_p for the template context.
1655 2019-02-11  Marek Polacek  <polacek@redhat.com>
1657         PR c++/89212 - ICE converting nullptr to pointer-to-member-function.
1658         * pt.c (tsubst_copy_and_build) <case CONSTRUCTOR>: Return early for
1659         null member pointer value.
1661 2019-02-11  Jakub Jelinek  <jakub@redhat.com>
1663         PR c++/88977
1664         * pt.c (convert_nontype_argument): Pass true as manifestly_const_eval
1665         to maybe_constant_value calls.
1667 2019-02-11  Marek Polacek  <polacek@redhat.com>
1669         * typeck2.c (digest_init_r): Remove commented code.
1671 2019-02-11  Martin Sebor  <msebor@redhat.com>
1673         PR c++/87996
1674         * decl.c (compute_array_index_type_loc): Preserve signed sizes
1675         for diagnostics.  Call valid_array_size_p instead of error.
1676         * init.c (build_new_1): Compute size for diagnostic.  Call
1677         invalid_array_size_error
1678         (build_new): Call valid_array_size_p instead of error.
1680 2019-02-07  Alexandre Oliva <aoliva@redhat.com>
1682         PR c++/86218
1683         * call.c (compare_ics): Deal with ck_aggr in either cs.
1685 2019-02-06  David Malcolm  <dmalcolm@redhat.com>
1687         PR c++/71302
1688         * call.c (get_location_for_expr_unwinding_for_system_header): New
1689         function.
1690         (conversion_null_warnings): Use it when getting locations for
1691         EXPR, effectively adding a call to
1692         get_location_for_expr_unwinding_for_system_header for
1693         -Wconversion-null and making use of EXPR_LOCATION for
1694         -Wzero-as-null-pointer-constant.
1696 2019-02-05  Jakub Jelinek  <jakub@redhat.com>
1698         PR c++/89187
1699         * optimize.c (maybe_thunk_body): Clear TREE_ADDRESSABLE on
1700         PARM_DECLs of the thunk.
1701         * lambda.c (maybe_add_lambda_conv_op): Likewise.
1703 2019-02-05  Marek Polacek  <polacek@redhat.com>
1705         PR c++/89158 - by-value capture of constexpr variable broken.
1706         * call.c (convert_like_real) <case ck_user>: Call mark_exp_read
1707         instead of mark_rvalue_use.
1709 2019-02-05  Alexandre Oliva <aoliva@redhat.com>
1711         PR c++/87770
1712         * pt.c (instantiates_primary_template_p): New.
1713         (type_dependent_expression_p): Use it.
1715 2019-02-01  Jason Merrill  <jason@redhat.com>
1717         PR c++/88761 - ICE with reference capture of constant.
1718         * lambda.c (mark_const_cap_r): Do walk subtrees of DECL_EXPR for
1719         non-proxy decls.
1721 2019-02-01  Marek Polacek  <polacek@redhat.com>
1723         PR c++/88325 - ICE with invalid out-of-line template member definition.
1724         * parser.c (cp_parser_class_name): Don't call make_typename_type
1725         for overloads.
1727 2019-02-01  Jakub Jelinek  <jakub@redhat.com>
1729         PR c++/87175
1730         * parser.c (cp_parser_gnu_attributes_opt): Set ok to false
1731         if require_open failed.
1733 2019-01-31  Marek Polacek  <polacek@redhat.com>
1735         PR c++/89083, c++/80864 - ICE with list initialization in template.
1736         * constexpr.c (adjust_temp_type): Use copy_node and change the type
1737         instead of using build_constructor.
1738         * decl.c (reshape_init_r): Don't reshape a digested initializer.
1739         Return the initializer for COMPOUND_LITERAL_P.
1741         PR c++/88983 - ICE with switch in constexpr function.
1742         * constexpr.c (cxx_eval_switch_expr): Use SWITCH_COND and SWITCH_BODY.
1743         (cxx_eval_constant_expression) <case COND_EXPR>: Don't look for the
1744         label in the else branch if we found it in the then branch.
1746 2019-01-30  Jason Merrill  <jason@redhat.com>
1748         PR c++/88752 - ICE with lambda and constexpr if.
1749         * cp-tree.h (LAMBDA_EXPR_INSTANTIATED): New.
1750         * pt.c (tsubst_lambda_expr): Set it.
1751         (instantiated_lambda_fn_p): Check it.
1752         (enclosing_instantiation_of): Use it.
1754 2019-01-31  Jakub Jelinek  <jakub@redhat.com>
1756         PR libstdc++/88170
1757         * cxx-pretty-print.c (pp_cxx_enumeration_constant): Print always as
1758         a C cast in pp_c_flag_gnu_v3 mode.
1760 2019-01-30  Jakub Jelinek  <jakub@redhat.com>
1762         PR c++/88988
1763         * lambda.c (is_capture_proxy): Don't return true for
1764         DECL_OMP_PRIVATIZED_MEMBER artificial vars.
1766 2019-01-30  Marek Polacek  <polacek@redhat.com>
1768         PR c++/89119 - ICE with value-initialization in template.
1769         * pt.c (tsubst_copy_and_build): Handle RANGE_EXPR.
1771 2019-01-29  Jason Merrill  <jason@redhat.com>
1773         PR c++/86943 - wrong code converting lambda to function pointer.
1774         * lambda.c (maybe_add_lambda_conv_op): Use a template-id in the
1775         call.  Only forward parms for decltype.
1776         * pt.c (tsubst_copy_and_build) [CALL_EXPR]: Handle CALL_FROM_THUNK_P
1777         specially.
1778         * typeck.c (check_return_expr): Don't mess with a thunk call.
1780 2019-01-28  Jason Merrill  <jason@redhat.com>
1782         PR c++/89089 - ICE with [[no_unique_address]].
1783         PR c++/88865 - wrong layout with [[no_unique_address]].
1784         * class.c (check_field_decls): A potentially-overlapping field makes
1785         the class non-layout-POD, but not non-empty.
1786         (end_of_class): Always consider empty data members.
1787         (layout_class_type): Set DECL_SIZE for empty fields.
1789 2019-01-28  Marek Polacek  <polacek@redhat.com>
1791         PR c++/88358 - name wrongly treated as type.
1792         * parser.c (cp_parser_direct_declarator): Don't assume a qualified-id
1793         in parameter-list is a type if the function's declarator-id is not
1794         qualified.
1796 2019-01-27  Marek Polacek  <polacek@redhat.com>
1798         PR c++/88815 - narrowing conversion lost in decltype.
1799         PR c++/78244 - narrowing conversion in template not detected.
1800         * cp-tree.h (CONSTRUCTOR_IS_DEPENDENT): New.
1801         * pt.c (instantiation_dependent_r): Consider a CONSTRUCTOR with
1802         CONSTRUCTOR_IS_DEPENDENT instantiation-dependent.
1803         * semantics.c (finish_compound_literal): When the compound literal
1804         isn't instantiation-dependent and the type isn't type-dependent,
1805         fall back to the normal processing.  Set CONSTRUCTOR_IS_DEPENDENT.
1807         PR c++/89024 - ICE with incomplete enum type.
1808         * call.c (standard_conversion): When converting an
1809         ARITHMETIC_TYPE_P to an incomplete type, return NULL.
1810         
1811 2019-01-25  Paolo Carlini  <paolo.carlini@oracle.com>
1813         PR c++/88969
1814         * call.c (build_op_delete_call): Implement 7.6.2.5/(10.1).
1815         * decl2.c (coerce_delete_type): Use build_pointer_type instead
1816         of TYPE_POINTER_TO.
1818 2019-01-24  Jason Merrill  <jason@redhat.com>
1820         PR c++/89001 - mangling of reference temporaries
1821         * cp-tree.h (struct saved_scope): Add ref_temp_count.
1822         (current_ref_temp_count): New macro.
1823         * mangle.c (mangle_ref_init_variable): Use it.
1824         * typeck2.c (store_init_value): Clear it.
1825         * call.c (make_temporary_var_for_ref_to_temp): Copy public and
1826         comdat.
1828 2019-01-24  Jakub Jelinek  <jakub@redhat.com>
1830         PR c++/88976
1831         * semantics.c (finish_omp_cancel): Diagnose more than one if
1832         on #pragma omp cancel with different modifiers.  Use
1833         maybe_convert_cond when not in template or build_x_binary_op
1834         otherwise.
1836 2019-01-23  Marek Polacek  <polacek@redhat.com>
1838         PR c++/88757 - qualified name treated wrongly as type.
1839         * parser.c (cp_parser_direct_declarator): Don't treat qualified-ids
1840         in parameter-list as types if name lookup for declarator-id didn't
1841         find one or more function templates.
1843 2019-01-23  Jakub Jelinek  <jakub@redhat.com>
1845         PR c/44715
1846         * cp-gimplify.c (genericize_cp_loop): Call begin_bc_block only
1847         after genericizing cond and incr expressions.
1849         PR c++/88984
1850         * cp-gimplify.c (genericize_switch_stmt): Move cond genericization
1851         before the begin_bc_block call.
1853 2019-01-21  Jason Merrill  <jason@redhat.com>
1855         PR c++/87893 - constexpr ctor ICE on ARM.
1856         PR c++/88293 - ICE with comma expression.
1857         * constexpr.c (initialized_type): Don't shortcut non-void type.
1858         Handle COMPOUND_EXPR.
1859         (cxx_eval_outermost_constant_expr): Return early for void type.
1861 2019-01-21  Jakub Jelinek  <jakub@redhat.com>
1863         PR c++/88949
1864         * optimize.c (cxx_copy_decl): New function.
1865         (clone_body): Use it instead of copy_decl_no_change.
1867         PR sanitizer/88901
1868         * typeck.c (cp_build_binary_op): Don't instrument
1869         SANITIZE_POINTER_COMPARE if processing_template_decl.
1870         (pointer_diff): Similarly for SANITIZE_POINTER_SUBTRACT.
1872 2019-01-18  Jason Merrill  <jason@redhat.com>
1874         PR c++/88875 - error with explicit list constructor.
1875         * call.c (reference_binding): Don't modify EXPR.  Set
1876         need_temporary_p on the ck_user conversion for a temporary.
1877         (convert_like_real): Check it.
1879 2019-01-18  H.J. Lu  <hongjiu.lu@intel.com>
1881         PR c/51628
1882         PR c/88664
1883         * call.c (convert_for_arg_passing): Upate the
1884         warn_for_address_or_pointer_of_packed_member call.
1885         * typeck.c (convert_for_assignment): Likewise.
1887 2019-01-17  Jason Merrill  <jason@redhat.com>
1889         PR c++/86205 - ICE with ?: of throw and template-id.
1890         * pt.c (resolve_nondeduced_context_or_error): Split out from...
1891         * typeck.c (decay_conversion): ...here.
1892         * call.c (build_conditional_expr_1): Use it.
1894         PR c++/86740, ICE with constexpr if and nested generic lambdas.
1895         * tree.c (cp_walk_subtrees): Handle LAMBDA_EXPR.
1897 2019-01-17  Paolo Carlini  <paolo.carlini@oracle.com>
1899         * decl.c (grokdeclarator): Use typespec_loc in error messages
1900         about 'auto' and trailing return type.
1902 2019-01-17  David Malcolm  <dmalcolm@redhat.com>
1904         PR c++/88699
1905         * class.c (add_method): Don't use DECL_DESTRUCTOR_P on
1906         USING_DECLs.
1908 2019-01-17  Nathan Sidwell  <nathan@acm.org>
1910         PR c++/86610
1911         * semantics.c (process_outer_var_ref): Only skip dependent types
1912         in templates.
1914 2019-01-17  Alexandre Oliva <aoliva@redhat.com>
1916         PR c++/87768
1917         * cp-tree.h (saved_scope): Add suppress_location_wrappers.
1918         * name-lookup.c (do_push_to_top_level): Save and reset it.
1919         (do_pop_from_top_level): Restore it.
1921         PR c++/86648
1922         * pt.c (make_template_placeholder): Use auto_identifier.
1923         (is_auto): Drop CLASS_PLACEHOLDER_TEMPLATE test.
1924         * error.c (dump_type): Handle template placeholders.
1925         * cxx-pretty-print.c (pp_cx_unqualified_id): Likewise.
1927         PR c++/88146
1928         * cvt.c (convert_to_void): Handle all cdtor calls as if
1929         returning void.
1931 2019-01-16  Paolo Carlini  <paolo.carlini@oracle.com>
1933         * decl.c (grokdeclarator): Use locations[ds_storage_class] in
1934         error messages about ill-formed uses of mutable.
1936 2019-01-16  Marek Polacek  <polacek@redhat.com>
1938         PR c++/78244 - narrowing conversion in template not detected.
1939         * call.c (perform_implicit_conversion_flags): Set
1940         IMPLICIT_CONV_EXPR_BRACED_INIT.
1941         * cp-tree.h (IMPLICIT_CONV_EXPR_BRACED_INIT): New.
1942         * pt.c (tsubst_copy_and_build): Use it.
1944 2019-01-15  David Malcolm  <dmalcolm@redhat.com>
1946         PR c++/88795
1947         * pt.c (build_deduction_guide): Bail out if tsubst_arg_types
1948         fails.
1950 2019-01-15  Paolo Carlini  <paolo.carlini@oracle.com>
1952         * decl.c (start_decl): Improve error location.
1953         * decl2.c (grokfield): Likewise.
1955 2019-01-15  Paolo Carlini  <paolo.carlini@oracle.com>
1957         * decl.c (grokdeclarator): Move further up the location_t loc
1958         declaration and use the location when building a TYPE_DECL for
1959         a typedef name.
1960         * decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in the error
1961         about an ill-formed bit-field as typedef.
1963 2019-01-14  Marek Polacek  <polacek@redhat.com>
1965         PR c++/88830 - ICE with abstract class.
1966         * decl2.c (maybe_emit_vtables): Check CLASSTYPE_LAZY_DESTRUCTOR.
1967         Fix formatting.
1969         PR c++/88825 - ICE with bogus function return type deduction.
1970         * typeck.c (can_do_nrvo_p): Check error_mark_node.
1972 2019-01-14  Tom Honermann  <tom@honermann.net>
1974         Implement P0482R5, char8_t: A type for UTF-8 characters and strings
1975         * cvt.c (type_promotes_to): Handle char8_t promotion.
1976         * decl.c (grokdeclarator): Handle invalid type specifier
1977         combinations involving char8_t.
1978         * lex.c (init_reswords): Add char8_t as a reserved word.
1979         * mangle.c (write_builtin_type): Add name mangling for char8_t (Du).
1980         * parser.c (cp_keyword_starts_decl_specifier_p)
1981         (cp_parser_simple_type_specifier): Recognize char8_t as a simple
1982         type specifier.
1983         (cp_parser_string_literal): Use char8_array_type_node for the type
1984         of CPP_UTF8STRING.
1985         (cp_parser_set_decl_spec_type): Tolerate char8_t typedefs in system
1986         headers.
1987         * rtti.c (emit_support_tinfos): type_info support for char8_t.
1988         * tree.c (char_type_p): Recognize char8_t as a character type.
1989         * typeck.c (string_conv_p): Handle conversions of u8 string
1990         literals of char8_t type.
1991         (check_literal_operator_args): Handle UDLs with u8 string literals
1992         of char8_t type.
1993         * typeck2.c (ordinary_char_type_p): New.
1994         (digest_init_r): Disallow initializing a char array with a u8 string
1995         literal.
1997 2019-01-14  Martin Liska  <mliska@suse.cz>
1999         PR gcov-profile/88263
2000         * decl2.c (get_tls_wrapper_fn): Use DECL_SOURCE_LOCATION
2001         as location of the TLS wrapper.
2003 2019-01-12  Paolo Carlini  <paolo.carlini@oracle.com>
2005         * decl.c (cp_finish_decl): Improve error location.
2006         * decl2.c (grokfield): Likewise, improve two locations.
2008 2019-01-11  Marek Polacek  <polacek@redhat.com>
2010         PR c++/88692, c++/87882 - -Wredundant-move false positive with *this.
2011         * typeck.c (maybe_warn_pessimizing_move): Return if ARG isn't
2012         ADDR_EXPR.
2014 2019-01-11  Jason Merrill  <jason@redhat.com>
2016         PR c++/88312 - pack expansion of decltype.
2017         * pt.c (instantiation_dependent_r): A template non-type parameter
2018         pack is instantiation-dependent.
2020 2019-01-11  Jason Merrill  <jason@redhat.com>
2022         PR c++/88613 - ICE with use of const var in lambda.
2023         * expr.c (mark_use): Fix location wrapper handling.
2024         * cp-gimplify.c (cp_fold_maybe_rvalue): Call mark_rvalue_use.
2026 2019-01-11  Tobias Burnus  <burnus@net-b.de>
2028         PR C++/88114
2029         * decl2.c (maybe_emit_vtables): If needed, generate code for
2030         the destructor of an abstract class.
2031         (mark_used): Update comment for older function-name change.
2033 2019-01-11  Paolo Carlini  <paolo.carlini@oracle.com>
2035         * decl.c (start_decl): Improve error location.
2036         (grokdeclarator): Likewise, improve two locations.
2038 2019-01-09  Sandra Loosemore  <sandra@codesourcery.com>
2040         PR other/16615
2042         * cp-tree.h: Mechanically replace "can not" with "cannot".
2043         * parser.c: Likewise.
2044         * pt.c: Likewise.
2046 2019-01-08  Paolo Carlini  <paolo.carlini@oracle.com>
2048         * decl.c (grok_reference_init): Improve error location.
2049         (grokdeclarator): Likewise, improve two locations.
2051 2019-01-08  Marek Polacek  <polacek@redhat.com>
2053         PR c++/88538 - braced-init-list in template-argument-list.
2054         * parser.c (cp_parser_template_argument): Handle braced-init-list when
2055         in C++20.
2057         PR c++/88548 - this accepted in static member functions.
2058         * parser.c (cp_debug_parser): Adjust printing of
2059         local_variables_forbidden_p.
2060         (cp_parser_new): Set local_variables_forbidden_p to 0 rather than false.
2061         (cp_parser_primary_expression): When checking
2062         local_variables_forbidden_p, use THIS_FORBIDDEN or
2063         LOCAL_VARS_FORBIDDEN.
2064         (cp_parser_lambda_body): Update the type of
2065         local_variables_forbidden_p.  Set it to 0 rather than false.
2066         (cp_parser_condition): Adjust call to cp_parser_declarator.
2067         (cp_parser_explicit_instantiation): Likewise.
2068         (cp_parser_init_declarator): Likewise.
2069         (cp_parser_declarator): New parameter.  Use it.
2070         (cp_parser_direct_declarator): New parameter.  Use it to set
2071         local_variables_forbidden_p.  Adjust call to cp_parser_declarator.
2072         (cp_parser_type_id_1): Adjust call to cp_parser_declarator.
2073         (cp_parser_parameter_declaration): Likewise.
2074         (cp_parser_default_argument): Update the type of
2075         local_variables_forbidden_p.  Set it to LOCAL_VARS_AND_THIS_FORBIDDEN
2076         rather than true.
2077         (cp_parser_member_declaration): Tell cp_parser_declarator if we saw
2078         'static' or 'friend'.
2079         (cp_parser_exception_declaration): Adjust call to cp_parser_declarator.
2080         (cp_parser_late_parsing_default_args): Update the type of
2081         local_variables_forbidden_p.  Set it to LOCAL_VARS_AND_THIS_FORBIDDEN
2082         rather than true.
2083         (cp_parser_cache_defarg): Adjust call to cp_parser_declarator.
2084         (cp_parser_objc_class_ivars): Likewise.
2085         (cp_parser_objc_struct_declaration): Likewise.
2086         (cp_parser_omp_for_loop_init): Likewise.
2087         * parser.h (cp_parser): Change the type of local_variables_forbidden_p
2088         to unsigned char.
2089         (LOCAL_VARS_FORBIDDEN, LOCAL_VARS_AND_THIS_FORBIDDEN, THIS_FORBIDDEN):
2090         Define.
2092 2019-01-08  Paolo Carlini  <paolo.carlini@oracle.com>
2094         * decl.c (start_decl): Improve permerror location.
2096 2019-01-08  Jonathan Wakely  <jwakely@redhat.com>
2097             Jakub Jelinek  <jakub@redhat.com>
2099         PR c++/88554
2100         * decl.c (finish_function): For -Wreturn-type don't add a return *this;
2101         fixit hint if current_class_ref is NULL.  Use a single if instead of
2102         two nested ones.
2104 2019-01-07  Paolo Carlini  <paolo.carlini@oracle.com>
2106         * decl.c (start_decl): Improve two error_at locations.
2107         (expand_static_init): Likewise.
2109 2019-01-07  Marek Polacek  <polacek@redhat.com>
2111         PR c++/88741 - wrong error with initializer-string.
2112         * decl.c (cp_complete_array_type): Strip any location wrappers.
2114 2019-01-07  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2116         PR c++/88261
2117         PR c++/69338
2118         PR c++/69696
2119         PR c++/69697
2120         * cp-tree.h (LOOKUP_ALLOW_FLEXARRAY_INIT): New flag value.
2121         * typeck2.c (digest_init_r): Raise an error for non-static
2122         initialization of a flexible array member.
2123         (process_init_constructor, massage_init_elt,
2124         process_init_constructor_array, process_init_constructor_record,
2125         process_init_constructor_union, process_init_constructor): Add the
2126         flags parameter and pass it thru.
2127         (store_init_value): Pass LOOKUP_ALLOW_FLEXARRAY_INIT parameter to
2128         digest_init_flags for static decls.
2130 2019-01-07  Jakub Jelinek  <jakub@redhat.com>
2132         PR c++/85052
2133         * cp-tree.h (cp_build_vec_convert): Declare.
2134         * parser.c (cp_parser_postfix_expression): Parse
2135         __builtin_convertvector.
2136         * constexpr.c: Include fold-const-call.h.
2137         (cxx_eval_internal_function): Handle IFN_VEC_CONVERT.
2138         (potential_constant_expression_1): Likewise.
2139         * semantics.c (cp_build_vec_convert): New function.
2140         * pt.c (tsubst_copy_and_build): Handle CALL_EXPR to
2141         IFN_VEC_CONVERT.
2143 2019-01-03  Jakub Jelinek  <jakub@redhat.com>
2145         PR c++/88636
2146         * decl.c (builtin_function_1): Return result of pushdecl_top_level
2147         or pushdecl rather than decl.
2149 2019-01-03  Paolo Carlini  <paolo.carlini@oracle.com>
2151         * tree.c (handle_nodiscard_attribute): Improve warning location.
2153 2019-01-02  Marek Polacek  <polacek@redhat.com>
2155         PR c++/88612 - ICE with -Waddress-of-packed-member.
2156         * call.c (convert_for_arg_passing): Only give warnings with tf_warning.
2157         * typeck.c (convert_for_assignment): Likewise.
2159         PR c++/88631 - CTAD failing for value-initialization.
2160         * typeck2.c (build_functional_cast): Try deducing the template
2161         arguments even if there are no arguments to deduce from.
2163 2019-01-01  Jakub Jelinek  <jakub@redhat.com>
2165         Update copyright years.
2167 Copyright (C) 2019 Free Software Foundation, Inc.
2169 Copying and distribution of this file, with or without modification,
2170 are permitted in any medium without royalty provided the copyright
2171 notice and this notice are preserved.