2 GCC MAINTAINER INFORMATION
3 ==========================
5 If you are having some problem with a system header that is either
6 broken by the manufacturer, or is broken by the fixinclude process,
7 then you will need to alter or add information to the include fix
8 definitions file, ``inclhack.def''. Please also send relevant
9 information to gcc-bugs@gcc.gnu.org, gcc-patches@gcc.gnu.org and,
10 please, to me: bkorb@gnu.org.
12 To make your fix, you will need to do several things:
14 1. Obtain access to the AutoGen program on some platform. It does
15 not have to be your build platform, but it is more convenient.
17 2. Edit "inclhack.def" to reflect the changes you need to make.
18 See below for information on how to make those changes.
20 3. Run the "genfixes" shell script to produce a new copy of
23 4. Rebuild the compiler and check the header causing the issue.
24 Make sure it is now properly handled. Add tests to the
25 "test_text" entry(ies) that validate your fix. This will
26 help ensure that future fixes won't negate your work.
27 Do *NOT* specify test text for "wrap" or "replacement" fixes.
28 There is no real possibility that these fixes will fail.
29 If they do, you will surely know straight away.
31 NOTE: "test_text" is interpreted by the shell as it gets
32 copied into the test header. THEREFORE you must quote
33 dollar sign characters and back quotes -- unless you mean
34 for them to be interpreted by the shell.
36 e.g. the math_huge_val_from_dbl_max test_text needs to
37 put text into both float.h and math.h, so it includes a
38 back-quoted script to add text to float.h.
40 5. Go into the fixincludes build directory and type, "make check".
41 You are guaranteed to have issues printed out as a result.
42 Look at the diffs produced. Make sure you have not clobbered
43 the proper functioning of a different fix. Make sure your
44 fix is properly tested and it does what it is supposed to do.
46 6. Now that you have the right things happening, synchronize the
47 $(srcdir)/tests/base directory with the $(builddir)/tests/res
48 directory. The output of "make check" will be some diffs that
49 should give you some hints about what to do.
51 7. Rerun "make check" and verify that there are no issues left.
54 MAKING CHANGES TO INCLHACK.DEF
55 ==============================
57 0. If you are not the fixincludes maintainer, please send that
58 person email about any changes you may want to make. Thanks!
60 1. Every fix must have a "hackname" that is compatible with C syntax
61 for variable names and is unique without regard to alphabetic case.
62 Please keep them alphabetical by this name. :-)
64 2. If the problem is known to exist only in certain files, then
65 identify the files with "files = " entries. If you use fnmatch(3C)
66 wild card characters in a "files" entry, be certain that the first
67 "files" entry has no such character. Otherwise, the "make check"
68 machinery will attempt to create files with those characters in the
69 name. That is inconvenient.
71 3. It is relatively expensive to fire off a process to fix a source
72 file, therefore write apply tests to avoid unnecessary fix
73 processes. The preferred apply tests are "select", "bypass", "mach"
74 "sum", and "c-test" because they are performed internally:
76 * select - Run a regex on the contents of the file being considered.
77 All such regex-es must match. Matching is done with
78 extended regular expressions.
80 * bypass - Run a regex on the contents of the file being considered.
81 No such regex may match.
83 * sum - Select a specific version of a file that has a matching
84 check sum. The BSD version of checksum ["sum(1BSD)"]
85 is used. Each "sum" entry should contain exactly three
86 space separated tokens: the sum, some number and the
87 basename of the file. The "some number" is ignored.
88 If there are multiple "sum" entries, only one needs to
89 match in order to pass. For example:
91 sum = '1234 3 foobar.h';
93 specifies that the "foobar.h" header in any directory
94 will match if it has the checksum 1234.
96 * c_test - call a function in fixtests.c. See that file.
98 * files - the "fnmatch" pattern of the file(s) to examine for
99 the issue. There may be several copies of this attribute.
100 If the header lives in a /usr/include subdirectory, be
101 sure to include that subdirectory in the name. e.g. net/if.h
103 * mach - Match the output of config.guess against a series of fnmatch
104 patterns. It must match at least one of the patterns, unless
105 "not-machine" has also been specified. In that case, the
106 config.guess output must not match any of the patterns.
108 The next test is relatively slow because it must be handled in a
109 separate shell process. Some platforms do not support server shells,
110 so the whole process is even slower and more cumbersome there.
112 * test - These should be arguments to the program, "/bin/test".
113 You may perform multiple commands, if you enclose them
114 in backquotes and echo out valid test arguments. For
115 example, you might echo out '0 -eq 1' if you want a false
116 result, or '0 -eq 0' for a true result.
118 These tests are required to:
120 1. Be positive for all header files that require the fix.
124 2. Be negative as often as possible whenever the fix is not
125 required, avoiding the process overhead.
129 3. The expression is as simple as possible to both
130 process and understand by people. :-)
132 Please take advantage of the fact AutoGen will glue
133 together string fragments. It helps. Also take note
134 that double quote strings and single quote strings have
135 different formation rules. Double quote strings are a
136 tiny superset of ANSI-C string syntax. Single quote
137 strings follow shell single quote string formation
138 rules, except that the backslash is processed before
139 '\\', '\'' and '#' characters (using C character syntax).
141 Each test must pass or the fix is not applied. For example,
142 all "select" expressions must be found and not one "bypass"
143 selection may be found.
145 Examples of test specifications:
147 hackname = broken_assert_stdio;
150 bypass = "include.*stdio.h";
152 The ``broken_assert_stdio'' fix will be applied only to a file
153 named "assert.h" if it contains the string "stderr" _and_ it
154 does _not_ contain the expression "include.*stdio.h".
156 hackname = no_double_slash;
157 c_test = "double_slash";
159 The ``no_double_slash'' fix will be applied if the
160 ``double_slash_test()'' function says to. See ``fixtests.c''
161 for documentation on how to include new functions into that
164 4. There are currently four methods of fixing a file:
166 1. a series of sed expressions. Each will be an individual
167 "-e" argument to a single invocation of sed. Unless you
168 need to use multiple or complex sed expressions, please
169 use the "replacement text" method instead.
171 2. a shell script. These scripts are _required_ to read all
172 of stdin in order to avoid pipe stalls. They may choose to
175 3. Replacement text. If the replacement is empty, then no
176 fix is applied. Otherwise, the replacement text is
177 written to the output file and no further fixes are
178 applied. If you really want a no-op file, replace the
181 Replacement text "fixes" must be first in this file!!
183 4. A C language subroutine method for both tests and fixes.
184 See ``fixtests.c'' for instructions on writing C-language
185 applicability tests and ``fixfixes.c'' for C-language fixing.
186 These files also contain tables that describe the currently
187 implemented fixes and tests.
189 If at all possible, you should try to use one of the C language
190 fixes as it is far more efficient. There are currently five
191 such fixes, three of which are very special purpose:
193 i) char_macro_def - This function repairs the definition of an
194 ioctl macro that presumes CPP macro substitution within
195 pairs of single quote characters.
197 ii) char_macro_use - This function repairs the usage of ioctl
198 macros that no longer can wrap an argument with single quotes.
200 iii) machine_name - This function will look at "#if", "#ifdef",
201 "#ifndef" and "#elif" directive lines and replace the first
202 occurrence of a non-reserved name that is traditionally
203 pre-defined by the native compiler.
205 The next two are for general use:
207 iv) wrap - wraps the entire file with "#ifndef", "#define" and
208 "#endif" self-exclusionary text. It also, optionally, inserts
209 a prolog after the "#define" and an epilog just before the
210 "#endif". You can use this for a fix as follows:
213 c_fix_arg = "/* prolog text */";
214 c_fix_arg = "/* epilog text */";
216 If you want an epilog without a prolog, set the first "c_fix_arg"
217 to the empty string. Both or the second "c_fix_arg"s may be
218 omitted and the file will still be wrapped.
220 THERE IS A SPECIAL EXCEPTION TO THIS, HOWEVER:
222 If the regular expression '#if.*__need' is found, then it is
223 assumed that the file needs to be read and interpreted more
224 than once. However, the prolog and epilog text (if any) will
227 v) format - Replaces text selected with a regular expression with
228 a specialized formating string. The formatting works as follows:
229 The format text is copied to the output until a '%' character
230 is found. If the character after the '%' is another '%', then
231 one '%' is output and processing continues. If the following
232 character is not a digit, then the '%' and that character are
233 copied and processing continues. Finally, if the '%' *is*
234 followed by a digit, that digit is used as an index into the
235 regmatch_t array to replace the two characters with the matched
236 text. i.e.: "%0" is replaced by the full matching text, "%1"
237 is the first matching sub-expression, etc.
239 This is used as follows:
242 c_fix_arg = "#ifndef %1\n%0\n#endif";
243 c_fix_arg = "#define[ \t]+([A-Z][A-Z0-9a-z_]*).*";
245 This would wrap a one line #define inside of a "#ifndef"/"#endif"
246 pair. The second "c_fix_arg" may be omitted *IF* there is at least
247 one select clause and the first one identifies the text you wish to
248 reformat. It will then be used as the second "c_fix_arg". You may
249 delete the selected text by supplying an empty string for the
250 replacement format (the first "c_fix_arg").
252 Note: In general, a format c_fix may be used in place of one
253 sed expression. However, it will need to be rewritten by
256 sed = 's@^#if __GNUC__ == 2 && __GNUC_MINOR__ >= 7$'
257 '@& || __GNUC__ >= 3@';
259 may be rewritten using a format c_fix as:
262 c_fix_arg = '%0 || __GNUC__ >= 3';
263 c_fix_arg = '^#if __GNUC__ == 2 && __GNUC_MINOR__ >= 7$';
265 Multiple sed substitution expressions probably ought to remain sed
266 expressions in order to maintain clarity. Also note that if the
267 second sed expression is the same as the first select expression,
268 then you may omit the second c_fix_arg. The select expression will
269 be picked up and used in its absence.
274 hackname = AAA_ki_iface;
275 replace; /* empty replacement -> no fixing the file */
277 When this ``fix'' is invoked, it will prevent any fixes
282 hackname = AAB_svr4_no_varargs;
283 replace = "/* This file was generated by fixincludes. */\n"
284 "#ifndef _SYS_VARARGS_H\n"
285 "#define _SYS_VARARGS_H\n\n"
288 "#include <stdarg.h>\n"
290 "#include <varargs.h>\n"
293 "#endif /* _SYS_VARARGS_H */\n";
295 When this ``fix'' is invoked, the replacement text will be
296 emitted into the replacement include file. No further fixes
301 hackname = hpux11_fabsf;
303 select = "^[ \t]*#[ \t]*define[ \t]+fabsf\\(.*";
304 bypass = "__cplusplus";
307 c_fix_arg = "#ifndef __cplusplus\n%0\n#endif";
310 "# define fabsf(x) ((float)fabs((double)(float)(x)))\n";
312 This fix will ensure that the #define for fabs is wrapped
313 with C++ protection, providing the header is not already
320 The brute force method is, of course, to configure and build
321 GCC. But you can also:
323 cd ${top_builddir}/gcc
324 rm -rf include-fixed/ stmp-fixinc
327 I would really recommend, however:
329 cd ${top_builddir}/fixincludes
332 To do this, you *must* have autogen installed on your system.
333 The "check" step will proceed to construct a shell script that
334 will exercise all the fixes, using the sample test_text
335 provided with each fix. Once done, the changes made will
336 be compared against the changes saved in the source directory.
337 If you are changing the tests or fixes, the change will likely