2 * This file is part of MPlayer.
4 * MPlayer is free software; you can redistribute it and/or modify
5 * it under the terms of the GNU General Public License as published by
6 * the Free Software Foundation; either version 2 of the License, or
7 * (at your option) any later version.
9 * MPlayer is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
14 * You should have received a copy of the GNU General Public License along
15 * with MPlayer; if not, write to the Free Software Foundation, Inc.,
16 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
26 #include "subopt-helper.h"
27 #include "video_out.h"
28 #include "video_out_internal.h"
29 #include "font_load.h"
32 #include "gl_common.h"
34 #include "fastmemcpy.h"
35 #include "libass/ass.h"
36 #include "libass/ass_mp.h"
38 static const vo_info_t info
=
42 "Arpad Gereoffy <arpi@esp-team.scene.hu>",
46 const LIBVO_EXTERN(gl
)
49 static int gl_vinfo
= 0;
50 static HGLRC gl_context
= 0;
51 #define update_xinerama_info w32_update_xinerama_info
52 #define vo_init vo_w32_init
53 #define vo_window vo_w32_window
55 static XVisualInfo
*gl_vinfo
= NULL
;
56 static GLXContext gl_context
= 0;
57 static int wsGLXAttrib
[] = { GLX_RGBA
,
66 static int scaled_osd
;
67 //! How many parts the OSD may consist of at most
68 #define MAX_OSD_PARTS 20
70 static GLuint osdtex
[MAX_OSD_PARTS
];
72 //! Alpha textures for OSD
73 static GLuint osdatex
[MAX_OSD_PARTS
];
75 static GLuint
*eosdtex
;
76 #define LARGE_EOSD_TEX_SIZE 512
77 #define TINYTEX_SIZE 16
78 #define TINYTEX_COLS (LARGE_EOSD_TEX_SIZE/TINYTEX_SIZE)
79 #define TINYTEX_MAX (TINYTEX_COLS*TINYTEX_COLS)
80 #define SMALLTEX_SIZE 32
81 #define SMALLTEX_COLS (LARGE_EOSD_TEX_SIZE/SMALLTEX_SIZE)
82 #define SMALLTEX_MAX (SMALLTEX_COLS*SMALLTEX_COLS)
83 static GLuint largeeosdtex
[2];
84 //! Display lists that draw the OSD parts
85 static GLuint osdDispList
[MAX_OSD_PARTS
];
87 static GLuint osdaDispList
[MAX_OSD_PARTS
];
89 static GLuint eosdDispList
;
90 //! How many parts the OSD currently consists of
92 static int eosdtexCnt
;
95 static int use_aspect
;
100 static float filter_strength
;
101 static int yuvconvtype
;
102 static int use_rectangle
;
103 static int err_shown
;
104 static uint32_t image_width
;
105 static uint32_t image_height
;
106 static uint32_t image_format
;
107 static int many_fmts
;
109 static int force_pbo
;
110 static int mesa_buffer
;
111 static int use_glFinish
;
112 static int swap_interval
;
113 static GLenum gl_target
;
114 static GLint gl_texfmt
;
115 static GLenum gl_format
;
116 static GLenum gl_type
;
117 static GLuint gl_buffer
;
118 static GLuint gl_buffer_uv
[2];
119 static int gl_buffersize
;
120 static int gl_buffersize_uv
;
121 static void *gl_bufferptr
;
122 static void *gl_bufferptr_uv
[2];
123 static int mesa_buffersize
;
124 static void *mesa_bufferptr
;
125 static GLuint fragprog
;
126 static GLuint default_texs
[22];
127 static char *custom_prog
;
128 static char *custom_tex
;
129 static int custom_tlin
;
130 static int custom_trect
;
132 static int int_pause
;
133 static int eq_bri
= 0;
134 static int eq_cont
= 0;
135 static int eq_sat
= 0;
136 static int eq_hue
= 0;
137 static int eq_rgamma
= 0;
138 static int eq_ggamma
= 0;
139 static int eq_bgamma
= 0;
141 static int texture_width
;
142 static int texture_height
;
143 static int mpi_flipped
;
144 static int vo_flipped
;
145 static int ass_border_x
, ass_border_y
;
147 static unsigned int slice_height
= 1;
149 static void redraw(void);
151 static void resize(int x
,int y
){
152 mp_msg(MSGT_VO
, MSGL_V
, "[gl] Resize: %dx%d\n",x
,y
);
154 int top
= 0, left
= 0, w
= x
, h
= y
;
155 geometry(&top
, &left
, &w
, &h
, vo_screenwidth
, vo_screenheight
);
156 glViewport(top
, left
, w
, h
);
158 glViewport( 0, 0, x
, y
);
160 glMatrixMode(GL_PROJECTION
);
162 ass_border_x
= ass_border_y
= 0;
163 if (vo_fs
&& use_aspect
) {
165 GLdouble scale_x
, scale_y
;
166 aspect(&new_w
, &new_h
, A_ZOOM
);
168 new_w
+= vo_panscan_x
;
169 new_h
+= vo_panscan_y
;
170 scale_x
= (GLdouble
)new_w
/ (GLdouble
)x
;
171 scale_y
= (GLdouble
)new_h
/ (GLdouble
)y
;
172 glScaled(scale_x
, scale_y
, 1);
173 ass_border_x
= (vo_screenwidth
- new_w
) / 2;
174 ass_border_y
= (vo_screenheight
- new_h
) / 2;
176 glOrtho(0, image_width
, image_height
, 0, -1,1);
178 glMatrixMode(GL_MODELVIEW
);
182 #ifdef CONFIG_FREETYPE
183 // adjust font size to display size
186 vo_osd_changed(OSDTYPE_OSD
);
188 glClear(GL_COLOR_BUFFER_BIT
);
192 static void texSize(int w
, int h
, int *texw
, int *texh
) {
194 *texw
= w
; *texh
= h
;
203 if (mesa_buffer
) *texw
= (*texw
+ 63) & ~63;
204 else if (ati_hack
) *texw
= (*texw
+ 511) & ~511;
207 //! maximum size of custom fragment program
208 #define MAX_CUSTOM_PROG_SIZE (1024 * 1024)
209 static void update_yuvconv(void) {
210 float bri
= eq_bri
/ 100.0;
211 float cont
= (eq_cont
+ 100) / 100.0;
212 float hue
= eq_hue
/ 100.0 * 3.1415927;
213 float sat
= (eq_sat
+ 100) / 100.0;
214 float rgamma
= exp(log(8.0) * eq_rgamma
/ 100.0);
215 float ggamma
= exp(log(8.0) * eq_ggamma
/ 100.0);
216 float bgamma
= exp(log(8.0) * eq_bgamma
/ 100.0);
217 gl_conversion_params_t params
= {gl_target
, yuvconvtype
,
218 bri
, cont
, hue
, sat
, rgamma
, ggamma
, bgamma
,
219 texture_width
, texture_height
, filter_strength
};
220 glSetupYUVConversion(¶ms
);
222 FILE *f
= fopen(custom_prog
, "r");
224 mp_msg(MSGT_VO
, MSGL_WARN
,
225 "[gl] Could not read customprog %s\n", custom_prog
);
227 char *prog
= calloc(1, MAX_CUSTOM_PROG_SIZE
+ 1);
228 fread(prog
, 1, MAX_CUSTOM_PROG_SIZE
, f
);
230 loadGPUProgram(GL_FRAGMENT_PROGRAM
, prog
);
233 ProgramEnvParameter4f(GL_FRAGMENT_PROGRAM
, 0,
234 1.0 / texture_width
, 1.0 / texture_height
,
235 texture_width
, texture_height
);
238 FILE *f
= fopen(custom_tex
, "r");
240 mp_msg(MSGT_VO
, MSGL_WARN
,
241 "[gl] Could not read customtex %s\n", custom_tex
);
243 int width
, height
, maxval
;
244 ActiveTexture(GL_TEXTURE3
);
245 if (glCreatePPMTex(custom_trect
?GL_TEXTURE_RECTANGLE
:GL_TEXTURE_2D
, 0,
246 custom_tlin
?GL_LINEAR
:GL_NEAREST
,
247 f
, &width
, &height
, &maxval
))
248 ProgramEnvParameter4f(GL_FRAGMENT_PROGRAM
, 1,
249 1.0 / width
, 1.0 / height
, width
, height
);
251 mp_msg(MSGT_VO
, MSGL_WARN
,
252 "[gl] Error parsing customtex %s\n", custom_tex
);
254 ActiveTexture(GL_TEXTURE0
);
260 * \brief remove all OSD textures and display-lists, thus clearing it.
262 static void clearOSD(void) {
266 glDeleteTextures(osdtexCnt
, osdtex
);
268 glDeleteTextures(osdtexCnt
, osdatex
);
269 for (i
= 0; i
< osdtexCnt
; i
++)
270 glDeleteLists(osdaDispList
[i
], 1);
272 for (i
= 0; i
< osdtexCnt
; i
++)
273 glDeleteLists(osdDispList
[i
], 1);
278 * \brief remove textures, display list and free memory used by EOSD
280 static void clearEOSD(void) {
282 glDeleteLists(eosdDispList
, 1);
285 glDeleteTextures(eosdtexCnt
, eosdtex
);
291 static void do_render_osd(int);
293 static inline int is_tinytex(ass_image_t
*i
, int tinytexcur
) {
294 return i
->w
< TINYTEX_SIZE
&& i
->h
< TINYTEX_SIZE
&& tinytexcur
< TINYTEX_MAX
;
297 static inline int is_smalltex(ass_image_t
*i
, int smalltexcur
) {
298 return i
->w
< SMALLTEX_SIZE
&& i
->h
< SMALLTEX_SIZE
&& smalltexcur
< SMALLTEX_MAX
;
301 static inline void tinytex_pos(int tinytexcur
, int *x
, int *y
) {
302 *x
= (tinytexcur
% TINYTEX_COLS
) * TINYTEX_SIZE
;
303 *y
= (tinytexcur
/ TINYTEX_COLS
) * TINYTEX_SIZE
;
306 static inline void smalltex_pos(int smalltexcur
, int *x
, int *y
) {
307 *x
= (smalltexcur
% SMALLTEX_COLS
) * SMALLTEX_SIZE
;
308 *y
= (smalltexcur
/ SMALLTEX_COLS
) * SMALLTEX_SIZE
;
312 * \brief construct display list from ass image list
313 * \param img image list to create OSD from.
314 * A value of NULL has the same effect as clearEOSD()
316 static void genEOSD(mp_eosd_images_t
*imgs
) {
321 GLint scale_type
= scaled_osd
? GL_LINEAR
: GL_NEAREST
;
322 ass_image_t
*img
= imgs
->imgs
;
325 if (imgs
->changed
== 0) // there are elements, but they are unchanged
327 if (img
&& imgs
->changed
== 1) // there are elements, but they just moved
333 if (!largeeosdtex
[0]) {
334 glGenTextures(2, largeeosdtex
);
335 BindTexture(gl_target
, largeeosdtex
[0]);
336 glCreateClearTex(gl_target
, GL_ALPHA
, GL_ALPHA
, GL_UNSIGNED_BYTE
, scale_type
, LARGE_EOSD_TEX_SIZE
, LARGE_EOSD_TEX_SIZE
, 0);
337 BindTexture(gl_target
, largeeosdtex
[1]);
338 glCreateClearTex(gl_target
, GL_ALPHA
, GL_ALPHA
, GL_UNSIGNED_BYTE
, scale_type
, LARGE_EOSD_TEX_SIZE
, LARGE_EOSD_TEX_SIZE
, 0);
340 for (i
= img
; i
; i
= i
->next
)
342 if (i
->w
<= 0 || i
->h
<= 0 || i
->stride
< i
->w
)
344 if (is_tinytex(i
, tinytexcur
))
346 else if (is_smalltex(i
, smalltexcur
))
351 mp_msg(MSGT_VO
, MSGL_DBG2
, "EOSD counts (tiny, small, all): %i, %i, %i\n",
352 tinytexcur
, smalltexcur
, eosdtexCnt
);
354 eosdtex
= calloc(eosdtexCnt
, sizeof(GLuint
));
355 glGenTextures(eosdtexCnt
, eosdtex
);
357 tinytexcur
= smalltexcur
= 0;
358 for (i
= img
, curtex
= eosdtex
; i
; i
= i
->next
) {
360 if (i
->w
<= 0 || i
->h
<= 0 || i
->stride
< i
->w
) {
361 mp_msg(MSGT_VO
, MSGL_V
, "Invalid dimensions OSD for part!\n");
364 if (is_tinytex(i
, tinytexcur
)) {
365 tinytex_pos(tinytexcur
, &x
, &y
);
366 BindTexture(gl_target
, largeeosdtex
[0]);
368 } else if (is_smalltex(i
, smalltexcur
)) {
369 smalltex_pos(smalltexcur
, &x
, &y
);
370 BindTexture(gl_target
, largeeosdtex
[1]);
373 texSize(i
->w
, i
->h
, &sx
, &sy
);
374 BindTexture(gl_target
, *curtex
++);
375 glCreateClearTex(gl_target
, GL_ALPHA
, GL_ALPHA
, GL_UNSIGNED_BYTE
, scale_type
, sx
, sy
, 0);
377 glUploadTex(gl_target
, GL_ALPHA
, GL_UNSIGNED_BYTE
, i
->bitmap
, i
->stride
,
378 x
, y
, i
->w
, i
->h
, 0);
380 eosdDispList
= glGenLists(1);
382 glNewList(eosdDispList
, GL_COMPILE
);
383 tinytexcur
= smalltexcur
= 0;
384 for (i
= img
, curtex
= eosdtex
; i
; i
= i
->next
) {
386 if (i
->w
<= 0 || i
->h
<= 0 || i
->stride
< i
->w
)
388 glColor4ub(i
->color
>> 24, (i
->color
>> 16) & 0xff, (i
->color
>> 8) & 0xff, 255 - (i
->color
& 0xff));
389 if (is_tinytex(i
, tinytexcur
)) {
390 tinytex_pos(tinytexcur
, &x
, &y
);
391 sx
= sy
= LARGE_EOSD_TEX_SIZE
;
392 BindTexture(gl_target
, largeeosdtex
[0]);
394 } else if (is_smalltex(i
, smalltexcur
)) {
395 smalltex_pos(smalltexcur
, &x
, &y
);
396 sx
= sy
= LARGE_EOSD_TEX_SIZE
;
397 BindTexture(gl_target
, largeeosdtex
[1]);
400 texSize(i
->w
, i
->h
, &sx
, &sy
);
401 BindTexture(gl_target
, *curtex
++);
403 glDrawTex(i
->dst_x
, i
->dst_y
, i
->w
, i
->h
, x
, y
, i
->w
, i
->h
, sx
, sy
, use_rectangle
== 1, 0, 0);
406 BindTexture(gl_target
, 0);
410 * \brief uninitialize OpenGL context, freeing textures, buffers etc.
412 static void uninitGl(void) {
414 if (DeletePrograms
&& fragprog
)
415 DeletePrograms(1, &fragprog
);
417 while (default_texs
[i
] != 0)
420 glDeleteTextures(i
, default_texs
);
425 glDeleteTextures(2, largeeosdtex
);
427 if (DeleteBuffers
&& gl_buffer
)
428 DeleteBuffers(1, &gl_buffer
);
429 gl_buffer
= 0; gl_buffersize
= 0;
431 if (DeleteBuffers
&& gl_buffer_uv
[0])
432 DeleteBuffers(2, gl_buffer_uv
);
433 gl_buffer_uv
[0] = gl_buffer_uv
[1] = 0; gl_buffersize_uv
= 0;
434 gl_bufferptr_uv
[0] = gl_bufferptr_uv
[1] = 0;
437 FreeMemoryMESA(mDisplay
, mScreen
, mesa_bufferptr
);
439 mesa_bufferptr
= NULL
;
443 static void autodetectGlExtensions(void) {
444 const char *extensions
= glGetString(GL_EXTENSIONS
);
445 const char *vendor
= glGetString(GL_VENDOR
);
446 const char *version
= glGetString(GL_VERSION
);
447 int is_ati
= strstr(vendor
, "ATI") != NULL
;
448 int ati_broken_pbo
= 0;
449 if (is_ati
&& strncmp(version
, "2.1.", 4) == 0) {
450 int ver
= atoi(version
+ 4);
451 mp_msg(MSGT_VO
, MSGL_V
, "[gl] Detected ATI driver version: %i\n", ver
);
452 ati_broken_pbo
= ver
&& ver
< 8395;
454 if (ati_hack
== -1) ati_hack
= ati_broken_pbo
;
455 if (force_pbo
== -1) force_pbo
= strstr(extensions
, "_pixel_buffer_object") ? is_ati
: 0;
456 if (use_rectangle
== -1) use_rectangle
= strstr(extensions
, "_texture_non_power_of_two") ? 0 : 0;
457 if (is_ati
&& (lscale
== 1 || lscale
== 2 || cscale
== 1 || cscale
== 2))
458 mp_msg(MSGT_VO
, MSGL_WARN
, "[gl] Selected scaling mode may be broken on ATI cards.\n"
459 "Tell _them_ to fix GL_REPEAT if you have issues.\n");
460 mp_msg(MSGT_VO
, MSGL_V
, "[gl] Settings after autodetection: ati-hack = %i, force-pbo = %i, rectangle = %i\n",
461 ati_hack
, force_pbo
, use_rectangle
);
465 * \brief Initialize a (new or reused) OpenGL context.
466 * set global gl-related variables to their default values
468 static int initGl(uint32_t d_width
, uint32_t d_height
) {
469 autodetectGlExtensions();
470 texSize(image_width
, image_height
, &texture_width
, &texture_height
);
473 glDisable(GL_DEPTH_TEST
);
474 glDepthMask(GL_FALSE
);
475 glDisable(GL_CULL_FACE
);
477 glDrawBuffer(vo_doublebuffering
?GL_BACK
:GL_FRONT
);
478 glTexEnvi(GL_TEXTURE_ENV
, GL_TEXTURE_ENV_MODE
, GL_MODULATE
);
480 mp_msg(MSGT_VO
, MSGL_V
, "[gl] Creating %dx%d texture...\n",
481 texture_width
, texture_height
);
483 if (image_format
== IMGFMT_YV12
) {
485 glGenTextures(21, default_texs
);
486 default_texs
[21] = 0;
487 for (i
= 0; i
< 7; i
++) {
488 ActiveTexture(GL_TEXTURE1
+ i
);
489 BindTexture(GL_TEXTURE_2D
, default_texs
[i
]);
490 BindTexture(GL_TEXTURE_RECTANGLE
, default_texs
[i
+ 7]);
491 BindTexture(GL_TEXTURE_3D
, default_texs
[i
+ 14]);
493 ActiveTexture(GL_TEXTURE1
);
494 glCreateClearTex(gl_target
, gl_texfmt
, gl_format
, gl_type
, GL_LINEAR
,
495 texture_width
/ 2, texture_height
/ 2, 128);
496 ActiveTexture(GL_TEXTURE2
);
497 glCreateClearTex(gl_target
, gl_texfmt
, gl_format
, gl_type
, GL_LINEAR
,
498 texture_width
/ 2, texture_height
/ 2, 128);
500 case YUV_CONVERSION_FRAGMENT_LOOKUP
:
501 case YUV_CONVERSION_FRAGMENT_POW
:
502 case YUV_CONVERSION_FRAGMENT
:
503 if (!GenPrograms
|| !BindProgram
) {
504 mp_msg(MSGT_VO
, MSGL_ERR
, "[gl] fragment program functions missing!\n");
507 GenPrograms(1, &fragprog
);
508 BindProgram(GL_FRAGMENT_PROGRAM
, fragprog
);
511 ActiveTexture(GL_TEXTURE0
);
512 BindTexture(gl_target
, 0);
515 glCreateClearTex(gl_target
, gl_texfmt
, gl_format
, gl_type
, GL_LINEAR
,
516 texture_width
, texture_height
, 0);
518 resize(d_width
, d_height
);
520 glClearColor( 0.0f
,0.0f
,0.0f
,0.0f
);
521 glClear( GL_COLOR_BUFFER_BIT
);
522 if (SwapInterval
&& swap_interval
>= 0)
523 SwapInterval(swap_interval
);
527 /* connect to server, create and map window,
528 * allocate colors and (shared) memory
531 config(uint32_t width
, uint32_t height
, uint32_t d_width
, uint32_t d_height
, uint32_t flags
, char *title
, uint32_t format
)
533 image_height
= height
;
535 image_format
= format
;
536 glFindFormat(format
, NULL
, &gl_texfmt
, &gl_format
, &gl_type
);
538 vo_flipped
= !!(flags
& VOFLAG_FLIPPING
);
541 if (!vo_w32_config(d_width
, d_height
, flags
))
545 XVisualInfo
*vinfo
=glXChooseVisual( mDisplay
,mScreen
,wsGLXAttrib
);
548 mp_msg(MSGT_VO
, MSGL_ERR
, "[gl] no GLX support present\n");
552 vo_x11_create_vo_window(vinfo
, vo_dx
, vo_dy
, d_width
, d_height
, flags
,
553 XCreateColormap(mDisplay
, mRootWin
, vinfo
->visual
, AllocNone
),
561 setGlWindow(&gl_vinfo
, &gl_context
, vo_window
);
562 initGl(vo_dwidth
, vo_dheight
);
567 static void check_events(void)
569 int e
=vo_check_events();
570 if(e
&VO_EVENT_RESIZE
) resize(vo_dwidth
,vo_dheight
);
571 if(e
&VO_EVENT_EXPOSE
&& int_pause
) redraw();
575 * Creates the textures and the display list needed for displaying
577 * Callback function for vo_draw_text().
579 static void create_osd_texture(int x0
, int y0
, int w
, int h
,
580 unsigned char *src
, unsigned char *srca
,
583 // initialize to 8 to avoid special-casing on alignment
585 GLint scale_type
= scaled_osd
? GL_LINEAR
: GL_NEAREST
;
587 if (w
<= 0 || h
<= 0 || stride
< w
) {
588 mp_msg(MSGT_VO
, MSGL_V
, "Invalid dimensions OSD for part!\n");
591 texSize(w
, h
, &sx
, &sy
);
593 if (osdtexCnt
>= MAX_OSD_PARTS
) {
594 mp_msg(MSGT_VO
, MSGL_ERR
, "Too many OSD parts, contact the developers!\n");
598 // create Textures for OSD part
599 glGenTextures(1, &osdtex
[osdtexCnt
]);
600 BindTexture(gl_target
, osdtex
[osdtexCnt
]);
601 glCreateClearTex(gl_target
, GL_LUMINANCE
, GL_LUMINANCE
, GL_UNSIGNED_BYTE
, scale_type
, sx
, sy
, 0);
602 glUploadTex(gl_target
, GL_LUMINANCE
, GL_UNSIGNED_BYTE
, src
, stride
,
606 glGenTextures(1, &osdatex
[osdtexCnt
]);
607 BindTexture(gl_target
, osdatex
[osdtexCnt
]);
608 glCreateClearTex(gl_target
, GL_ALPHA
, GL_ALPHA
, GL_UNSIGNED_BYTE
, scale_type
, sx
, sy
, 0);
611 char *tmp
= malloc(stride
* h
);
612 // convert alpha from weird MPlayer scale.
613 // in-place is not possible since it is reused for future OSDs
614 for (i
= h
* stride
- 1; i
>= 0; i
--)
616 glUploadTex(gl_target
, GL_ALPHA
, GL_UNSIGNED_BYTE
, tmp
, stride
,
622 BindTexture(gl_target
, 0);
624 // Create a list for rendering this OSD part
626 osdaDispList
[osdtexCnt
] = glGenLists(1);
627 glNewList(osdaDispList
[osdtexCnt
], GL_COMPILE
);
629 BindTexture(gl_target
, osdatex
[osdtexCnt
]);
630 glDrawTex(x0
, y0
, w
, h
, 0, 0, w
, h
, sx
, sy
, use_rectangle
== 1, 0, 0);
633 osdDispList
[osdtexCnt
] = glGenLists(1);
634 glNewList(osdDispList
[osdtexCnt
], GL_COMPILE
);
636 BindTexture(gl_target
, osdtex
[osdtexCnt
]);
637 glDrawTex(x0
, y0
, w
, h
, 0, 0, w
, h
, sx
, sy
, use_rectangle
== 1, 0, 0);
643 static void draw_osd(void)
645 if (!use_osd
) return;
646 if (vo_osd_changed(0)) {
649 osd_w
= scaled_osd
? image_width
: vo_dwidth
;
650 osd_h
= scaled_osd
? image_height
: vo_dheight
;
651 vo_draw_text_ext(osd_w
, osd_h
, ass_border_x
, ass_border_y
, ass_border_x
, ass_border_y
,
652 image_width
, image_height
, create_osd_texture
);
654 if (vo_doublebuffering
) do_render_osd(1);
657 static void do_render(void) {
658 // glEnable(GL_TEXTURE_2D);
659 // glBindTexture(GL_TEXTURE_2D, texture_id);
662 if (image_format
== IMGFMT_YV12
)
663 glEnableYUVConversion(gl_target
, yuvconvtype
);
664 glDrawTex(0, 0, image_width
, image_height
,
665 0, 0, image_width
, image_height
,
666 texture_width
, texture_height
,
667 use_rectangle
== 1, image_format
== IMGFMT_YV12
,
668 mpi_flipped
^ vo_flipped
);
669 if (image_format
== IMGFMT_YV12
)
670 glDisableYUVConversion(gl_target
, yuvconvtype
);
674 * \param type bit 0: render OSD, bit 1: render EOSD
676 static void do_render_osd(int type
) {
677 if (((type
& 1) && osdtexCnt
> 0) || ((type
& 2) && eosdDispList
)) {
678 // set special rendering parameters
680 glMatrixMode(GL_PROJECTION
);
683 glOrtho(0, vo_dwidth
, vo_dheight
, 0, -1, 1);
686 if ((type
& 2) && eosdDispList
) {
687 glBlendFunc(GL_SRC_ALPHA
, GL_ONE_MINUS_SRC_ALPHA
);
688 glCallList(eosdDispList
);
690 if ((type
& 1) && osdtexCnt
> 0) {
691 glColor4ub((osd_color
>> 16) & 0xff, (osd_color
>> 8) & 0xff, osd_color
& 0xff, 0xff - (osd_color
>> 24));
694 glBlendFunc(GL_ZERO
, GL_ONE_MINUS_SRC_ALPHA
);
695 glCallLists(osdtexCnt
, GL_UNSIGNED_INT
, osdaDispList
);
697 glBlendFunc(GL_SRC_ALPHA
, GL_ONE
);
698 glCallLists(osdtexCnt
, GL_UNSIGNED_INT
, osdDispList
);
700 // set rendering parameters back to defaults
704 BindTexture(gl_target
, 0);
708 static void flip_page(void) {
709 if (vo_doublebuffering
) {
710 if (use_glFinish
) glFinish();
712 if (vo_fs
&& use_aspect
)
713 glClear(GL_COLOR_BUFFER_BIT
);
717 if (use_glFinish
) glFinish();
722 static void redraw(void) {
723 if (vo_doublebuffering
) { do_render(); do_render_osd(3); }
727 //static inline uint32_t draw_slice_x11(uint8_t *src[], uint32_t slice_num)
728 static int draw_slice(uint8_t *src
[], int stride
[], int w
,int h
,int x
,int y
)
730 mpi_flipped
= stride
[0] < 0;
731 glUploadTex(gl_target
, gl_format
, gl_type
, src
[0], stride
[0],
732 x
, y
, w
, h
, slice_height
);
733 if (image_format
== IMGFMT_YV12
) {
734 ActiveTexture(GL_TEXTURE1
);
735 glUploadTex(gl_target
, gl_format
, gl_type
, src
[1], stride
[1],
736 x
/ 2, y
/ 2, w
/ 2, h
/ 2, slice_height
);
737 ActiveTexture(GL_TEXTURE2
);
738 glUploadTex(gl_target
, gl_format
, gl_type
, src
[2], stride
[2],
739 x
/ 2, y
/ 2, w
/ 2, h
/ 2, slice_height
);
740 ActiveTexture(GL_TEXTURE0
);
745 static uint32_t get_image(mp_image_t
*mpi
) {
747 if (!GenBuffers
|| !BindBuffer
|| !BufferData
|| !MapBuffer
) {
749 mp_msg(MSGT_VO
, MSGL_ERR
, "[gl] extensions missing for dr\n"
750 "Expect a _major_ speed penalty\n");
754 if (mpi
->flags
& MP_IMGFLAG_READABLE
) return VO_FALSE
;
755 if (mpi
->type
!= MP_IMGTYPE_STATIC
&& mpi
->type
!= MP_IMGTYPE_TEMP
&&
756 (mpi
->type
!= MP_IMGTYPE_NUMBERED
|| mpi
->number
))
758 if (mesa_buffer
) mpi
->width
= texture_width
;
760 mpi
->width
= texture_width
;
761 mpi
->height
= texture_height
;
763 mpi
->stride
[0] = mpi
->width
* mpi
->bpp
/ 8;
764 needed_size
= mpi
->stride
[0] * mpi
->height
;
767 if (mesa_bufferptr
&& needed_size
> mesa_buffersize
) {
768 FreeMemoryMESA(mDisplay
, mScreen
, mesa_bufferptr
);
769 mesa_bufferptr
= NULL
;
772 mesa_bufferptr
= AllocateMemoryMESA(mDisplay
, mScreen
, needed_size
, 0, 0, 0);
773 mesa_buffersize
= needed_size
;
775 mpi
->planes
[0] = mesa_bufferptr
;
778 GenBuffers(1, &gl_buffer
);
779 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, gl_buffer
);
780 if (needed_size
> gl_buffersize
) {
781 gl_buffersize
= needed_size
;
782 BufferData(GL_PIXEL_UNPACK_BUFFER
, gl_buffersize
,
783 NULL
, GL_DYNAMIC_DRAW
);
786 gl_bufferptr
= MapBuffer(GL_PIXEL_UNPACK_BUFFER
, GL_WRITE_ONLY
);
787 mpi
->planes
[0] = gl_bufferptr
;
788 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, 0);
790 if (!mpi
->planes
[0]) {
792 mp_msg(MSGT_VO
, MSGL_ERR
, "[gl] could not acquire buffer for dr\n"
793 "Expect a _major_ speed penalty\n");
797 if (mpi
->imgfmt
== IMGFMT_YV12
) {
799 mpi
->flags
|= MP_IMGFLAG_COMMON_STRIDE
| MP_IMGFLAG_COMMON_PLANE
;
800 mpi
->stride
[0] = mpi
->width
;
801 mpi
->planes
[1] = mpi
->planes
[0] + mpi
->stride
[0] * mpi
->height
;
802 mpi
->stride
[1] = mpi
->width
>> 1;
803 mpi
->planes
[2] = mpi
->planes
[1] + mpi
->stride
[1] * (mpi
->height
>> 1);
804 mpi
->stride
[2] = mpi
->width
>> 1;
805 if (ati_hack
&& !mesa_buffer
) {
806 mpi
->flags
&= ~MP_IMGFLAG_COMMON_PLANE
;
807 if (!gl_buffer_uv
[0]) GenBuffers(2, gl_buffer_uv
);
808 if (mpi
->stride
[1] * mpi
->height
> gl_buffersize_uv
) {
809 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, gl_buffer_uv
[0]);
810 BufferData(GL_PIXEL_UNPACK_BUFFER
, mpi
->stride
[1] * mpi
->height
,
811 NULL
, GL_DYNAMIC_DRAW
);
812 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, gl_buffer_uv
[1]);
813 BufferData(GL_PIXEL_UNPACK_BUFFER
, mpi
->stride
[1] * mpi
->height
,
814 NULL
, GL_DYNAMIC_DRAW
);
815 gl_buffersize_uv
= mpi
->stride
[1] * mpi
->height
;
817 if (!gl_bufferptr_uv
[0]) {
818 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, gl_buffer_uv
[0]);
819 gl_bufferptr_uv
[0] = MapBuffer(GL_PIXEL_UNPACK_BUFFER
, GL_WRITE_ONLY
);
820 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, gl_buffer_uv
[1]);
821 gl_bufferptr_uv
[1] = MapBuffer(GL_PIXEL_UNPACK_BUFFER
, GL_WRITE_ONLY
);
823 mpi
->planes
[1] = gl_bufferptr_uv
[0];
824 mpi
->planes
[2] = gl_bufferptr_uv
[1];
827 mpi
->flags
|= MP_IMGFLAG_DIRECT
;
831 static void clear_border(uint8_t *dst
, int start
, int stride
, int height
, int full_height
, int value
) {
832 int right_border
= stride
- start
;
833 int bottom_border
= full_height
- height
;
835 memset(dst
+ start
, value
, right_border
);
839 if (bottom_border
> 0)
840 memset(dst
, value
, stride
* bottom_border
);
843 static uint32_t draw_image(mp_image_t
*mpi
) {
844 int slice
= slice_height
;
846 unsigned char *planes
[3];
847 mp_image_t mpi2
= *mpi
;
848 int w
= mpi
->w
, h
= mpi
->h
;
849 if (mpi
->flags
& MP_IMGFLAG_DRAW_CALLBACK
)
851 mpi2
.flags
= 0; mpi2
.type
= MP_IMGTYPE_TEMP
;
852 mpi2
.width
= mpi2
.w
; mpi2
.height
= mpi2
.h
;
853 if (force_pbo
&& !(mpi
->flags
& MP_IMGFLAG_DIRECT
) && !gl_bufferptr
&& get_image(&mpi2
) == VO_TRUE
) {
854 int bpp
= mpi
->imgfmt
== IMGFMT_YV12
? 8 : mpi
->bpp
;
855 memcpy_pic(mpi2
.planes
[0], mpi
->planes
[0], mpi
->w
* bpp
/ 8, mpi
->h
, mpi2
.stride
[0], mpi
->stride
[0]);
856 if (mpi
->imgfmt
== IMGFMT_YV12
) {
857 memcpy_pic(mpi2
.planes
[1], mpi
->planes
[1], mpi
->w
>> 1, mpi
->h
>> 1, mpi2
.stride
[1], mpi
->stride
[1]);
858 memcpy_pic(mpi2
.planes
[2], mpi
->planes
[2], mpi
->w
>> 1, mpi
->h
>> 1, mpi2
.stride
[2], mpi
->stride
[2]);
860 if (ati_hack
) { // since we have to do a full upload we need to clear the borders
861 clear_border(mpi2
.planes
[0], mpi
->w
* bpp
/ 8, mpi2
.stride
[0], mpi
->h
, mpi2
.height
, 0);
862 if (mpi
->imgfmt
== IMGFMT_YV12
) {
863 clear_border(mpi2
.planes
[1], mpi
->w
>> 1, mpi2
.stride
[1], mpi
->h
>> 1, mpi2
.height
>> 1, 128);
864 clear_border(mpi2
.planes
[2], mpi
->w
>> 1, mpi2
.stride
[2], mpi
->h
>> 1, mpi2
.height
>> 1, 128);
869 stride
[0] = mpi
->stride
[0]; stride
[1] = mpi
->stride
[1]; stride
[2] = mpi
->stride
[2];
870 planes
[0] = mpi
->planes
[0]; planes
[1] = mpi
->planes
[1]; planes
[2] = mpi
->planes
[2];
871 mpi_flipped
= stride
[0] < 0;
872 if (mpi
->flags
& MP_IMGFLAG_DIRECT
) {
874 glPixelStorei(GL_UNPACK_CLIENT_STORAGE_APPLE
, 1);
877 intptr_t base
= (intptr_t)planes
[0];
878 if (ati_hack
) { w
= texture_width
; h
= texture_height
; }
880 base
+= (mpi
->h
- 1) * stride
[0];
884 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, gl_buffer
);
885 UnmapBuffer(GL_PIXEL_UNPACK_BUFFER
);
887 if (!(mpi
->flags
& MP_IMGFLAG_COMMON_PLANE
))
888 planes
[0] = planes
[1] = planes
[2] = NULL
;
890 slice
= 0; // always "upload" full texture
892 glUploadTex(gl_target
, gl_format
, gl_type
, planes
[0], stride
[0],
893 mpi
->x
, mpi
->y
, w
, h
, slice
);
894 if (mpi
->imgfmt
== IMGFMT_YV12
) {
895 if ((mpi
->flags
& MP_IMGFLAG_DIRECT
) && !(mpi
->flags
& MP_IMGFLAG_COMMON_PLANE
)) {
896 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, gl_buffer_uv
[0]);
897 UnmapBuffer(GL_PIXEL_UNPACK_BUFFER
);
898 gl_bufferptr_uv
[0] = NULL
;
900 ActiveTexture(GL_TEXTURE1
);
901 glUploadTex(gl_target
, gl_format
, gl_type
, planes
[1], stride
[1],
902 mpi
->x
/ 2, mpi
->y
/ 2, w
/ 2, h
/ 2, slice
);
903 if ((mpi
->flags
& MP_IMGFLAG_DIRECT
) && !(mpi
->flags
& MP_IMGFLAG_COMMON_PLANE
)) {
904 BindBuffer(GL_PIXEL_UNPACK_BUFFER
, gl_buffer_uv
[1]);
905 UnmapBuffer(GL_PIXEL_UNPACK_BUFFER
);
906 gl_bufferptr_uv
[1] = NULL
;
908 ActiveTexture(GL_TEXTURE2
);
909 glUploadTex(gl_target
, gl_format
, gl_type
, planes
[2], stride
[2],
910 mpi
->x
/ 2, mpi
->y
/ 2, w
/ 2, h
/ 2, slice
);
911 ActiveTexture(GL_TEXTURE0
);
913 if (mpi
->flags
& MP_IMGFLAG_DIRECT
) {
914 if (mesa_buffer
) glPixelStorei(GL_UNPACK_CLIENT_STORAGE_APPLE
, 0);
915 else BindBuffer(GL_PIXEL_UNPACK_BUFFER
, 0);
918 if (vo_doublebuffering
) do_render();
923 draw_frame(uint8_t *src
[])
929 query_format(uint32_t format
)
931 int caps
= VFCAP_CSP_SUPPORTED
| VFCAP_CSP_SUPPORTED_BY_HW
|
933 VFCAP_HWSCALE_UP
| VFCAP_HWSCALE_DOWN
| VFCAP_ACCEPT_STRIDE
;
935 caps
|= VFCAP_OSD
| VFCAP_EOSD
| (scaled_osd
? 0 : VFCAP_EOSD_UNSCALED
);
936 if (format
== IMGFMT_RGB24
|| format
== IMGFMT_RGBA
)
938 if (use_yuv
&& format
== IMGFMT_YV12
)
940 // HACK, otherwise we get only b&w with some filters (e.g. -vf eq)
941 // ideally MPlayer should be fixed instead not to use Y800 when it has the choice
942 if (!use_yuv
&& (format
== IMGFMT_Y8
|| format
== IMGFMT_Y800
))
944 if (!use_ycbcr
&& (format
== IMGFMT_UYVY
|| format
== IMGFMT_YUY2
))
947 glFindFormat(format
, NULL
, NULL
, NULL
, NULL
))
956 if (!vo_config_count
) return;
958 releaseGlContext(&gl_vinfo
, &gl_context
);
959 if (custom_prog
) free(custom_prog
);
961 if (custom_tex
) free(custom_tex
);
966 static const opt_t subopts
[] = {
967 {"manyfmts", OPT_ARG_BOOL
, &many_fmts
, NULL
},
968 {"osd", OPT_ARG_BOOL
, &use_osd
, NULL
},
969 {"scaled-osd", OPT_ARG_BOOL
, &scaled_osd
, NULL
},
970 {"aspect", OPT_ARG_BOOL
, &use_aspect
, NULL
},
971 {"ycbcr", OPT_ARG_BOOL
, &use_ycbcr
, NULL
},
972 {"slice-height", OPT_ARG_INT
, &slice_height
, (opt_test_f
)int_non_neg
},
973 {"rectangle", OPT_ARG_INT
, &use_rectangle
,(opt_test_f
)int_non_neg
},
974 {"yuv", OPT_ARG_INT
, &use_yuv
, (opt_test_f
)int_non_neg
},
975 {"lscale", OPT_ARG_INT
, &lscale
, (opt_test_f
)int_non_neg
},
976 {"cscale", OPT_ARG_INT
, &cscale
, (opt_test_f
)int_non_neg
},
977 {"filter-strength", OPT_ARG_FLOAT
, &filter_strength
, NULL
},
978 {"ati-hack", OPT_ARG_BOOL
, &ati_hack
, NULL
},
979 {"force-pbo", OPT_ARG_BOOL
, &force_pbo
, NULL
},
980 {"mesa-buffer", OPT_ARG_BOOL
, &mesa_buffer
, NULL
},
981 {"glfinish", OPT_ARG_BOOL
, &use_glFinish
, NULL
},
982 {"swapinterval", OPT_ARG_INT
, &swap_interval
,NULL
},
983 {"customprog", OPT_ARG_MSTRZ
,&custom_prog
, NULL
},
984 {"customtex", OPT_ARG_MSTRZ
,&custom_tex
, NULL
},
985 {"customtlin", OPT_ARG_BOOL
, &custom_tlin
, NULL
},
986 {"customtrect", OPT_ARG_BOOL
, &custom_trect
, NULL
},
987 {"osdcolor", OPT_ARG_INT
, &osd_color
, NULL
},
991 static int preinit(const char *arg
)
1002 filter_strength
= 0.5;
1014 osd_color
= 0xffffff;
1015 if (subopt_parse(arg
, subopts
) != 0) {
1016 mp_msg(MSGT_VO
, MSGL_FATAL
,
1017 "\n-vo gl command line help:\n"
1018 "Example: mplayer -vo gl:slice-height=4\n"
1021 " Disable extended color formats for OpenGL 1.2 and later\n"
1022 " slice-height=<0-...>\n"
1023 " Slice size for texture transfer, 0 for whole image\n"
1025 " Do not use OpenGL OSD code\n"
1027 " Render OSD at movie resolution and scale it\n"
1029 " Do not do aspect scaling\n"
1030 " rectangle=<0,1,2>\n"
1031 " 0: use power-of-two textures\n"
1032 " 1: use texture_rectangle\n"
1033 " 2: use texture_non_power_of_two\n"
1035 " Workaround ATI bug with PBOs\n"
1037 " Force use of PBO even if this involves an extra memcpy\n"
1039 " Call glFinish() before swapping buffers\n"
1040 " swapinterval=<n>\n"
1041 " Interval in displayed frames between to buffer swaps.\n"
1042 " 1 is equivalent to enable VSYNC, 0 to disable VSYNC.\n"
1043 " Requires GLX_SGI_swap_control support to work.\n"
1045 " 0: use software YUV to RGB conversion.\n"
1046 " 1: use register combiners (nVidia only, for older cards).\n"
1047 " 2: use fragment program.\n"
1048 " 3: use fragment program with gamma correction.\n"
1049 " 4: use fragment program with gamma correction via lookup.\n"
1050 " 5: use ATI-specific method (for older cards).\n"
1051 " 6: use lookup via 3D texture.\n"
1053 " 0: use standard bilinear scaling for luma.\n"
1054 " 1: use improved bicubic scaling for luma.\n"
1055 " 2: use cubic in X, linear in Y direction scaling for luma.\n"
1056 " 3: as 1 but without using a lookup texture.\n"
1057 " 4: experimental unsharp masking (sharpening).\n"
1058 " 5: experimental unsharp masking (sharpening) with larger radius.\n"
1060 " as lscale but for chroma (2x slower with little visible effect).\n"
1061 " filter-strength=<value>\n"
1062 " set the effect strength for some lscale/cscale filters\n"
1063 " customprog=<filename>\n"
1064 " use a custom YUV conversion program\n"
1065 " customtex=<filename>\n"
1066 " use a custom YUV conversion lookup texture\n"
1068 " use GL_NEAREST scaling for customtex texture\n"
1070 " use texture_rectangle for customtex texture\n"
1071 " osdcolor=<0xAARRGGBB>\n"
1072 " use the given color for the OSD\n"
1074 " also try to use the GL_MESA_ycbcr_texture extension\n"
1078 if (use_rectangle
== 1)
1079 gl_target
= GL_TEXTURE_RECTANGLE
;
1081 gl_target
= GL_TEXTURE_2D
;
1082 yuvconvtype
= use_yuv
| lscale
<< YUV_LUM_SCALER_SHIFT
| cscale
<< YUV_CHROM_SCALER_SHIFT
;
1084 mp_msg(MSGT_VO
, MSGL_INFO
, "[gl] using extended formats. "
1085 "Use -vo gl:nomanyfmts if playback fails.\n");
1086 mp_msg(MSGT_VO
, MSGL_V
, "[gl] Using %d as slice height "
1087 "(0 means image height).\n", slice_height
);
1088 if (!vo_init()) return -1; // Can't open X11
1093 #define MASK_ALL_YUV (~(1 << YUV_CONVERSION_NONE))
1094 #define MASK_NOT_COMBINERS (~((1 << YUV_CONVERSION_NONE) | (1 << YUV_CONVERSION_COMBINERS) | (1 << YUV_CONVERSION_COMBINERS_ATI)))
1095 #define MASK_GAMMA_SUPPORT (MASK_NOT_COMBINERS & ~(1 << YUV_CONVERSION_FRAGMENT))
1097 static const struct {
1102 {"brightness", &eq_bri
, MASK_NOT_COMBINERS
},
1103 {"contrast", &eq_cont
, MASK_NOT_COMBINERS
},
1104 {"saturation", &eq_sat
, MASK_ALL_YUV
},
1105 {"hue", &eq_hue
, MASK_ALL_YUV
},
1106 {"gamma", &eq_rgamma
, MASK_GAMMA_SUPPORT
},
1107 {"red_gamma", &eq_rgamma
, MASK_GAMMA_SUPPORT
},
1108 {"green_gamma", &eq_ggamma
, MASK_GAMMA_SUPPORT
},
1109 {"blue_gamma", &eq_bgamma
, MASK_GAMMA_SUPPORT
},
1113 static int control(uint32_t request
, void *data
)
1118 int_pause
= (request
== VOCTRL_PAUSE
);
1120 case VOCTRL_QUERY_FORMAT
:
1121 return query_format(*(uint32_t*)data
);
1122 case VOCTRL_GET_IMAGE
:
1123 return get_image(data
);
1124 case VOCTRL_DRAW_IMAGE
:
1125 return draw_image(data
);
1126 case VOCTRL_DRAW_EOSD
:
1130 if (vo_doublebuffering
) do_render_osd(2);
1132 case VOCTRL_GET_EOSD_RES
:
1134 mp_eosd_res_t
*r
= data
;
1135 r
->mt
= r
->mb
= r
->ml
= r
->mr
= 0;
1136 if (scaled_osd
) {r
->w
= image_width
; r
->h
= image_height
;}
1138 r
->w
= vo_screenwidth
; r
->h
= vo_screenheight
;
1139 r
->ml
= r
->mr
= ass_border_x
;
1140 r
->mt
= r
->mb
= ass_border_y
;
1142 r
->w
= vo_dwidth
; r
->h
= vo_dheight
;
1149 case VOCTRL_FULLSCREEN
:
1151 resize(vo_dwidth
, vo_dheight
);
1155 resize(vo_dwidth
, vo_dheight
);
1157 case VOCTRL_GET_PANSCAN
:
1158 if (!use_aspect
) return VO_NOTIMPL
;
1160 case VOCTRL_SET_PANSCAN
:
1161 if (!use_aspect
) return VO_NOTIMPL
;
1162 resize(vo_dwidth
, vo_dheight
);
1164 case VOCTRL_GET_EQUALIZER
:
1165 if (image_format
== IMGFMT_YV12
) {
1166 struct voctrl_get_equalizer_args
*args
= data
;
1168 for (i
= 0; eq_map
[i
].name
; i
++)
1169 if (strcmp(args
->name
, eq_map
[i
].name
) == 0) break;
1170 if (!(eq_map
[i
].supportmask
& (1 << use_yuv
)))
1172 *args
->valueptr
= *eq_map
[i
].value
;
1176 case VOCTRL_SET_EQUALIZER
:
1177 if (image_format
== IMGFMT_YV12
) {
1178 struct voctrl_set_equalizer_args
*args
= data
;
1180 for (i
= 0; eq_map
[i
].name
; i
++)
1181 if (strcmp(args
->name
, eq_map
[i
].name
) == 0) break;
1182 if (!(eq_map
[i
].supportmask
& (1 << use_yuv
)))
1184 *eq_map
[i
].value
= args
->value
;
1189 case VOCTRL_UPDATE_SCREENINFO
:
1190 update_xinerama_info();
1192 case VOCTRL_REDRAW_OSD
:
1193 if (vo_doublebuffering
)
1196 if (vo_doublebuffering
)