| commit | 20571d6f6870dab84624cc6b6fbac82cde204f16 | |
| author | Uoti Urpala <uau@glyph.nonexistent.invalid> | |
| Thu, 2 Oct 2008 02:01:36 +0000 (2 05:01 +0300) | ||
| committer | Uoti Urpala <uau@glyph.nonexistent.invalid> | |
| Thu, 2 Oct 2008 02:15:35 +0000 (2 05:15 +0300) | ||
| tree | c092f9492adae3d18d66015612b00c11e44f2cb2 | treesnapshot (tar.gz zip) |
| parent | c765db84a3954100cc9ccdbc3a668dc349077ae0 | commitdiff |
Revert "add outdir sub-option to vo png"
This reverts commit 22322409ddb527ac855ba71d10dadcb9da415f81.
The reverted commit had at least the following problems:
- It adds a lot of filesystem handling code to an individual VO.
- The added code is duplicated from vo_jpeg.c.
- The added code has exit_player() calls. A VO should not exit the
whole program. Even if vo_jpeg still has those calls they are a bug
that shouldn't spread elsewhere.
- The functionality benefit of automatic directory creation is
questionable. It was probably only included in vo_jpeg because of
the option to automatically create multiple subdirectories (though
the utility of that is also questionable); vo_png does not have that.
This reverts commit 22322409ddb527ac855ba71d10dadcb9da415f81.
The reverted commit had at least the following problems:
- It adds a lot of filesystem handling code to an individual VO.
- The added code is duplicated from vo_jpeg.c.
- The added code has exit_player() calls. A VO should not exit the
whole program. Even if vo_jpeg still has those calls they are a bug
that shouldn't spread elsewhere.
- The functionality benefit of automatic directory creation is
questionable. It was probably only included in vo_jpeg because of
the option to automatically create multiple subdirectories (though
the utility of that is also questionable); vo_png does not have that.
| DOCS/man/en/mplayer.1 | diffblobblamehistory | |
| DOCS/man/fr/mplayer.1 | diffblobblamehistory | |
| libvo/vo_png.c | diffblobblamehistory |