| commit | 36956720f7a3e854b467bf6dbd7aedd8d142e1ae | |
| author | Jay Krell <jay.krell@cornell.edu> | |
| Thu, 9 Aug 2018 05:52:56 +0000 (8 22:52 -0700) | ||
| committer | GitHub <noreply@github.com> | |
| Thu, 9 Aug 2018 05:52:56 +0000 (8 22:52 -0700) | ||
| tree | fa7c9e5574b264ec18d1630ad455245852bff62c | treesnapshot (tar.gz zip) |
| parent | 14d20074ffb298cc396916328897eac7f5f8c077 | commitdiff |
[cxx] Port complex math to small portable C and C++. (#9821)
* [cxx] Port complex math to small portable C and C++ with the only dependency being hypot and non-complex math, and small preexisting code we already had for msvc.
I.e. we already had two versions, with varying portability.
Use one of them, adding about three lines to it.
There was some debate back and forth about macros/renames here.
This version significantly reduces line damage and is much easier to read.
Doing the rename as a separate step may still be advisable, to erase any doubt as to portable semantics, i.e. namespace isolation.
Mono style divergence is also left unfixed to avoid further line damage.
i.e. consider `double_complex` => `MonoComplex`.
`mono_double_complex_` => `mono_complex_`.
* [cxx] Port complex math to small portable C and C++ with the only dependency being hypot and non-complex math, and small preexisting code we already had for msvc.
I.e. we already had two versions, with varying portability.
Use one of them, adding about three lines to it.
There was some debate back and forth about macros/renames here.
This version significantly reduces line damage and is much easier to read.
Doing the rename as a separate step may still be advisable, to erase any doubt as to portable semantics, i.e. namespace isolation.
Mono style divergence is also left unfixed to avoid further line damage.
i.e. consider `double_complex` => `MonoComplex`.
`mono_double_complex_` => `mono_complex_`.