| commit | 14d20074ffb298cc396916328897eac7f5f8c077 | |
| author | Katelyn Gadd <kg@luminance.org> | |
| Thu, 9 Aug 2018 00:52:37 +0000 (8 17:52 -0700) | ||
| committer | Alexander Köplinger <alex.koeplinger@outlook.com> | |
| Thu, 9 Aug 2018 00:52:37 +0000 (9 02:52 +0200) | ||
| tree | 62244a3aa5ae6c678b4ce0fa69b438c5fb8f6ccd | treesnapshot (tar.gz zip) |
| parent | bd50f070bd693f64b2ceede91f9470ba0deb0aa1 | commitdiff |
Move to generating msbuild choose elements to get if-else selection behavior for sources in projects so that we don't get erroneous duplicate files in cases where there are both profile and host platform criteria (#9952)
A recent commit revealed that in cases where we select based on a mix of host platform and profile, genproj csproj files can end up with duplicate sources because the existing <ItemGroup Condition= approach could make multiple groups match for a given compile when we really just want one.
This PR changes to generating a cascade of msbuild <Choose> elements, which give if-else selection to ensure that we only ever build a single set of files.
A recent commit revealed that in cases where we select based on a mix of host platform and profile, genproj csproj files can end up with duplicate sources because the existing <ItemGroup Condition= approach could make multiple groups match for a given compile when we really just want one.
This PR changes to generating a cascade of msbuild <Choose> elements, which give if-else selection to ensure that we only ever build a single set of files.
351 files changed: