1 2009-11-23 Marek Safar <marek.safar@gmail.com>
3 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
5 2009-11-23 Marek Safar <marek.safar@gmail.com>
7 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
8 cleanup some obsolete code.
10 2009-11-20 Marek Safar <marek.safar@gmail.com>
12 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
15 2009-11-20 Marek Safar <marek.safar@gmail.com>
17 * *.cs: Resolved expressions are never resolved again, this helps to
18 uncover some not easy to find bugs and improve the performance.
20 2009-11-19 Marek Safar <marek.safar@gmail.com>
22 * *.cs: Made constant expressions fully compatible with any other
25 2009-11-19 Marek Safar <marek.safar@gmail.com>
27 * *.cs: DoResolve is a worker method and has to be protected.
29 2009-11-18 Marek Safar <marek.safar@gmail.com>
31 * *.cs: More context specific handling.
33 2009-11-17 Marek Safar <marek.safar@gmail.com>
35 * *.cs: More context specific handling.
37 2009-11-16 Marek Safar <marek.safar@gmail.com>
39 * dynamic.cs, class.cs: Removed few fixed user types conversions.
41 * symbolwriter.cs: Uses public ILOffset.
43 2009-11-13 Marek Safar <marek.safar@gmail.com>
46 * generic.cs: Another missing TypeToCoreType, still too many to fix.
48 2009-11-13 Marek Safar <marek.safar@gmail.com>
52 * class.cs, delegate.cs, enum.cs: Constants have to be available
53 for parameters resolve.
55 2009-11-12 Marek Safar <marek.safar@gmail.com>
57 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
60 2009-11-12 Marek Safar <marek.safar@gmail.com>
62 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
63 with a statically known candidate set.
65 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
67 * generic.cs: Made type inflation for generic constraint checks
68 recursive. This fixes BGO #553655.
70 2009-11-11 Marek Safar <marek.safar@gmail.com>
72 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
75 2009-11-10 Marek Safar <marek.safar@gmail.com>
77 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
78 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
79 attribute.cs: Add some dynamic error checking.
81 2009-11-07 Marek Safar <marek.safar@gmail.com>
85 * expression.cs: Fixed mixed version of expression tree anonymous
88 2009-11-06 Marek Safar <marek.safar@gmail.com>
92 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
93 expression tree version of anonymous type with members declaration.
95 2009-11-05 Marek Safar <marek.safar@gmail.com>
97 * parameter.cs: Handle nullable parameter default expression.
99 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
100 class.cs, attribute.cs: Check for wrong dynamic arguments.
102 2009-11-05 Marek Safar <marek.safar@gmail.com>
104 * statement.cs: Dynamic statements.
106 2009-11-04 Marek Safar <marek.safar@gmail.com>
108 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
109 Compound assignments over dynamic type.
111 2009-11-03 Marek Safar <marek.safar@gmail.com>
113 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
114 constructor arguments.
116 2009-10-30 Marek Safar <marek.safar@gmail.com>
118 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
119 codegen.cs: Unary mutator on dynamic member access expression.
121 2009-10-29 Marek Safar <marek.safar@gmail.com>
123 A fix for bug #550580
124 * convert.cs: Don't eliminate explicit precission casts.
126 2009-10-28 Marek Safar <marek.safar@gmail.com>
128 A fix for bug #550404
130 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
131 expression.cs, statement.cs, ecore.cs: Quote any nested expression
134 2009-10-27 Marek Safar <marek.safar@gmail.com>
136 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
139 * class.cs: Allow nullable binary user operators.
141 2009-10-26 Marek Safar <marek.safar@gmail.com>
143 * expression.cs: Move binary expression optimization at the end of
146 2009-10-23 Marek Safar <marek.safar@gmail.com>
148 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
149 Separate NullConstant from NullLiteral.
151 2009-10-23 Marek Safar <marek.safar@gmail.com>
153 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
154 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
155 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
156 ModuleContainer. Add common unclosed member check routine.
158 2009-10-22 Marek Safar <marek.safar@gmail.com>
160 * argument.cs: Use literal flag for real literals only.
162 * dynamic.cs: Use correct return type for custom delegates.
164 2009-10-22 Marek Safar <marek.safar@gmail.com>
166 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
169 2009-10-22 Marek Safar <marek.safar@gmail.com>
171 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
173 2009-10-21 Marek Safar <marek.safar@gmail.com>
175 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
178 2009-10-21 Marek Safar <marek.safar@gmail.com>
180 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
183 2009-10-20 Marek Safar <marek.safar@gmail.com>
185 * argument.cs, dynamic.cs, expression.cs: Latest API update.
187 2009-10-19 Marek Safar <marek.safar@gmail.com>
189 * typemanager.cs, expression.cs: Dynamic array initializer.
191 2009-10-16 Marek Safar <marek.safar@gmail.com>
193 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
196 2009-10-16 Marek Safar <marek.safar@gmail.com>
198 A fix for bug #493523, #507067
199 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
200 standard nullable conversion using underlying standard conversion
201 and not full conversion.
203 2009-10-15 Marek Safar <marek.safar@gmail.com>
205 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
206 type in VerifyArgumentsCompat.
208 2009-10-15 Marek Safar <marek.safar@gmail.com>
210 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
211 Reject variable used with type arguments.
213 2009-10-14 Marek Safar <marek.safar@gmail.com>
215 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
216 Implement dynamic expressions assignment.
218 2009-10-14 Marek Safar <marek.safar@gmail.com>
220 * expression.cs: Build underlying expression when resolving unary
223 2009-10-14 Marek Safar <marek.safar@gmail.com>
225 * expression.cs: Emit enum array initializer using binary blob.
227 2009-10-08 Marek Safar <marek.safar@gmail.com>
229 * typemanager.cs, constant.cs: Optimize decimal constants which fit
232 2009-10-07 Marek Safar <marek.safar@gmail.com>
234 * typemanager.cs: Reset object_type.
236 * assign: Made SimpleAssign public.
238 2009-10-06 Marek Safar <marek.safar@gmail.com>
240 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
241 invocation assembly to IsThisOrFriendAssembly.
243 2009-10-05 Marek Safar <marek.safar@gmail.com>
245 * expression.cs: Equality comparison of generic parameter with
248 2009-10-05 Marek Safar <marek.safar@gmail.com>
250 A fix for bug #543570
251 * generic.cs: Import predefined constraints correctly.
253 2009-10-02 Marek Safar <marek.safar@gmail.com>
255 * ecore.cs: Don't crash on overloads with optional paremeters where
256 arguments count overflows.
258 * parameter.cs: Import optional parameter constants using optional
261 2009-10-01 Marek Safar <marek.safar@gmail.com>
263 * Makefile: Default is gmcs compiler.
265 2009-10-01 Marek Safar <marek.safar@gmail.com>
267 * cs-parser.jay: Fixed few NRE.
269 2009-10-01 Marek Safar <marek.safar@gmail.com>
271 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
273 2009-09-30 Marek Safar <marek.safar@gmail.com>
275 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
276 ShimExpression, ImplicitCast.
278 2009-09-30 Marek Safar <marek.safar@gmail.com>
280 A fix for bug #542959
281 * delegate.cs: Emit correct delegate instance variable when there
282 are static and non-static overloads.
284 2009-09-29 Marek Safar <marek.safar@gmail.com>
286 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
287 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
289 2009-09-28 Marek Safar <marek.safar@gmail.com>
291 A fix for bug #542487
292 * ecore.cs: Resolve extension methods hidden by properties.
294 2009-09-25 Marek Safar <marek.safar@gmail.com>
296 * expression.cs, ecore.cs: More dynamic binary expressions.
298 2009-09-22 Marek Safar <marek.safar@gmail.com>
300 * nullable.cs, expression.cs: Fixed null lifted conversion for
301 bitwise enum operations.
303 2009-09-22 Marek Safar <marek.safar@gmail.com>
305 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
306 values in checked context.
308 2009-09-22 Marek Safar <marek.safar@gmail.com>
310 * expression.cs, ecore.cs: Fixed array index constant conversion.
312 2009-09-20 Miguel de Icaza <miguel@novell.com>
314 * expression.cs: Do not crash when MemberLookup returns something
315 that is not a MemberExpr here. Report error 582 instead.
319 2009-09-18 Marek Safar <marek.safar@gmail.com>
321 * decl.cs, class.cs: Check protected property accessors.
323 2009-09-18 Marek Safar <marek.safar@gmail.com>
325 * dynamic.cs, assign.cs: Dynamic compound assignment.
327 2009-09-17 Marek Safar <marek.safar@gmail.com>
329 * expression.cs: Fixed compound assignment explicit conversion.
331 2009-09-17 Marek Safar <marek.safar@gmail.com>
333 * expression.cs, ecore.cs: Cannot infer variables from method group.
335 2009-09-16 Marek Safar <marek.safar@gmail.com>
337 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
338 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
339 codegen.cs: Dynamic binary operations scaffolding.
341 2009-09-15 Marek Safar <marek.safar@gmail.com>
343 * expression.cs: Fixes nullable promotion for enum type variables.
345 2009-09-11 Marek Safar <marek.safar@gmail.com>
347 * driver.cs, dynamic.cs: Reset more static variables.
349 2009-09-11 Marek Safar <marek.safar@gmail.com>
351 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
352 driver.cs: Introduced Expression::MakeExpression.
354 2009-09-11 Marek Safar <marek.safar@gmail.com>
356 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
358 2009-09-09 Marek Safar <marek.safar@gmail.com>
360 * eval.cs, report.cs: Use Console.Out for all eval error or warning
363 2009-09-09 Marek Safar <marek.safar@gmail.com>
365 A fix for bug #518707
366 * expression.cs (Is): Optimize only generic parameter type
367 expression probing value type generic parameter.
369 2009-09-09 Marek Safar <marek.safar@gmail.com>
371 A fix for bug #532571
372 * ecore.cs: Check for simple name type arguments used with
375 2009-09-08 Marek Safar <marek.safar@gmail.com>
377 A fix for bug #497421
378 * generic.cs (CheckConstraint): Don't use buildin types to check for
379 parameterless constructor.
381 2009-09-08 Marek Safar <marek.safar@gmail.com>
383 A fix for bug #537402
384 * generic.cs (CheckConstraint): Correctly inflate generic type
385 arguments when checking generic method.
387 2009-09-08 Marek Safar <marek.safar@gmail.com>
389 A fix for bug #536463
390 * decl.cs (AddToContainer): Don't report collision between explicit
391 and parameterless non-explicit members.
393 2009-09-08 Marek Safar <marek.safar@gmail.com>
395 * eval.cs: Reset more static stuff.
397 2009-09-07 Marek Safar <marek.safar@gmail.com>
399 A fix for bug #324625
400 * expression.cs, ecore.cs: Create nested generic type expression
401 using declaring and not current type.
403 2009-09-07 Marek Safar <marek.safar@gmail.com>
405 * *.cs: Changed Report class to accept various output printers and
406 be an instance class. An expression resolver can now use different
407 message reporter for each call and Report.Error can safely throw
408 an exception. Part of ongoing work to turn mcs into proper library.
410 2009-09-04 Marek Safar <marek.safar@gmail.com>
412 * statement.cs, ecore.cs: Removed error reporting from emit code.
414 2009-09-04 Marek Safar <marek.safar@gmail.com>
416 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
418 2009-09-03 Marek Safar <marek.safar@gmail.com>
420 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
421 parser checks out of constructors.
423 2009-09-02 Marek Safar <marek.safar@gmail.com>
425 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
427 2009-09-02 Marek Safar <marek.safar@gmail.com>
429 A fix for bug #535448
430 * anonymous.cs, class.cs: Copy return label between all contexts.
432 2009-09-02 Marek Safar <marek.safar@gmail.com>
434 A fix for bug #535395
435 * namespace.cs: Resolve context can be null.
437 2009-08-25 Marek Safar <marek.safar@gmail.com>
439 A fix for bug #533912
440 * generic.cs: Use correct context for constraints resolving.
442 2009-08-25 Marek Safar <marek.safar@gmail.com>
444 A fix for bug #532630
445 * driver.cs: Trim conditional symbols.
447 2009-08-25 Marek Safar <marek.safar@gmail.com>
449 * context.cs: New file.
451 * *.exe.sources, *.csproj: Updated.
453 2009-08-25 Marek Safar <marek.safar@gmail.com>
455 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
456 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
457 IMembercontext, some small cleanups.
459 2009-08-24 Marek Safar <marek.safar@gmail.com>
461 * *.cs: Split ResolveContext and EmitContext.
463 2009-08-24 Marek Safar <marek.safar@gmail.com>
465 * *.cs: Only ResolveContext implements IMemberContext.
467 2009-08-21 Marek Safar <marek.safar@gmail.com>
469 * *.cs: Renamed IResolveContext to IMemberContext.
471 2009-08-21 Marek Safar <marek.safar@gmail.com>
473 * *.cs: Detached ResolveContext from EmitContext.
475 2009-08-21 Marek Safar <marek.safar@gmail.com>
477 * codegen.cs: Moved flow-analysis to BlockContext.
479 2009-08-21 Marek Safar <marek.safar@gmail.com>
481 * *.cs: Detached BlockContext from EmitContext.
483 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
485 * statement.cs: avoid nullref when the return value of GetEnumerator()
486 does not contain any MoveNext() method.
488 2009-08-19 Marek Safar <marek.safar@gmail.com>
490 * *.cs: Removed IResolveContext::GenericDeclContainer.
492 2009-08-19 Marek Safar <marek.safar@gmail.com>
494 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
496 2009-08-19 Marek Safar <marek.safar@gmail.com>
498 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
499 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
501 2009-08-18 Marek Safar <marek.safar@gmail.com>
503 * *.cs: Removed boolean fields from EmitContext.
505 2009-08-18 Marek Safar <marek.safar@gmail.com>
507 * *.cs: Add IResolveContext::IsStatic.
509 2009-08-18 Marek Safar <marek.safar@gmail.com>
511 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
513 2009-08-17 Marek Safar <marek.safar@gmail.com>
515 * *.cs: Removed DeclContainer from EmitContext.
517 2009-08-17 Marek Safar <marek.safar@gmail.com>
519 * *.cs: Add IResolveContext::CurrentTypeParameters.
521 2009-08-14 Marek Safar <marek.safar@gmail.com>
523 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
525 2009-08-14 Marek Safar <marek.safar@gmail.com>
527 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
528 codegen.cs: Add IResolveContext::LookupExtensionMethod.
530 2009-08-13 Marek Safar <marek.safar@gmail.com>
532 * decl.cs: Look in PartialContainer for parent type parameters.
534 2009-08-13 Marek Safar <marek.safar@gmail.com>
536 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
537 codegen.cs: Add IResolveContext::LookupTypeParameter.
539 2009-08-13 Marek Safar <marek.safar@gmail.com>
541 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
542 Moved resolved logic from Emit to Resolve.
544 2009-08-13 Marek Safar <marek.safar@gmail.com>
546 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
547 codegen.cs: Reworked atttributes handling of ResolveContext.
549 2009-08-12 Marek Safar <marek.safar@gmail.com>
551 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
552 LookupNamespaceOrType to ResolveContext.
554 2009-08-12 Marek Safar <marek.safar@gmail.com>
556 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
557 class.cs: Removed unused parameters and methods.
559 2009-08-11 Marek Safar <marek.safar@gmail.com>
561 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
562 codegen.cs: Finding the best common type of a set of expressions for
565 2009-08-07 Marek Safar <marek.safar@gmail.com>
567 * dynamic.cs, expression.cs: More dynamic conversions.
569 2009-08-06 Miguel de Icaza <miguel@novell.com>
571 * generic.cs: This loop was incorrect, it was increment ii, but
572 checking for `i'. This was a change introduced to fix #327497,
575 * class.cs: Catch another case for cs0533 error, fixes #324782.
577 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
579 * typemanager.cs (GetGenericArguments): SRE returns null for
580 generic methods on type builder instances if they are not generic
581 themselves. For example, for Foo<int>::Bar() it returns null, but
582 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
584 2009-08-05 Marek Safar <marek.safar@gmail.com>
586 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
587 delegate.cs: Work on dynamic binding.
589 2009-08-04 Marek Safar <marek.safar@gmail.com>
591 A second fix for bug #525342
592 * class.cs: Attach partial method attributes to method
595 2009-08-03 Marek Safar <marek.safar@gmail.com>
597 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
600 * rootcontext.cs: Default to langversion v4.
602 2009-08-03 Marek Safar <marek.safar@gmail.com>
604 * pending.cs: Check return type before member info is set.
606 2009-08-03 Marek Safar <marek.safar@gmail.com>
608 * anonymous.cs: Fully initialize generic hoisted field expression.
610 2009-08-02 Miguel de Icaza <miguel@novell.com>
612 * cs-parser.jay: Flag variables declared on the interactive shell
613 as used to prevent the 168 warning about local variable not being
616 2009-07-31 Marek Safar <marek.safar@gmail.com>
618 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
619 attribute.cs: Emit dynamic export attribute.
621 2009-07-30 Marek Safar <marek.safar@gmail.com>
623 * expression.cs: More verifier work.
625 2009-07-29 Marek Safar <marek.safar@gmail.com>
627 * nullable.cs: Fixed SRE crash during corlib compilation.
629 2009-07-29 Marek Safar <marek.safar@gmail.com>
631 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
632 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
633 More TypeManager.TypeToCoreType needed.
635 2009-07-29 Marek Safar <marek.safar@gmail.com>
637 * anonymous.cs: Update after recent SRE fixes.
639 2009-07-28 Marek Safar <marek.safar@gmail.com>
641 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
642 version of GetFieldHandle for fields of generic types.
644 2009-07-27 Marek Safar <marek.safar@gmail.com>
646 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
647 ecore.cs: Add TypeManager.IsDynamicType,
648 PredefinedAttributes.Dynamic.
650 2009-07-27 Marek Safar <marek.safar@gmail.com>
652 A fix for bug #415375
653 * expression.cs: Fixed object and reference type parameter
656 2009-07-27 Marek Safar <marek.safar@gmail.com>
658 A fix for bug #525342
659 * class.cs: Attach partial method attributes to method
662 2009-07-24 Marek Safar <marek.safar@gmail.com>
664 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
667 2009-07-24 Marek Safar <marek.safar@gmail.com>
669 * anonymous.cs (MutateField): Add imported types handling.
671 2009-07-23 Marek Safar <marek.safar@gmail.com>
673 * expression.cs, delegate.cs: Moved arguments resolve into their
674 counterparts expressions. Removed argument resolve from
675 CollectionElementInitializer.
677 2009-07-23 Marek Safar <marek.safar@gmail.com>
679 A fix for bug #523683
680 * convert.cs, delegate.cs: Use common overload mechanism for method
681 group conversion check.
683 2009-07-22 Marek Safar <marek.safar@gmail.com>
685 A fix for bug #523899
686 * generics.cs: Exact type inference with other bound types.
688 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
690 Don't complain when the same type is implemented by the output
691 assembly as well as multiple referenced assemblies
692 * namespace.cs (RootNamespace.LookupTypeReflection): Add
693 'must_be_unique' flag.
694 (GlobalRootNamespace): Update to changes.
695 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
696 already have a type in hand.
698 2009-07-22 Marek Safar <marek.safar@gmail.com>
700 * expression.cs: More verifier instrumentation.
702 * statement.cs: Do proper throw expression conversion.
704 2009-07-22 Marek Safar <marek.safar@gmail.com>
706 A fix for bug #522789
707 * expression.cs: Mutate invocation return type.
709 2009-07-16 Marek Safar <marek.safar@gmail.com>
711 * anonymous.cs: Split assignable and readonly generated variable
714 2009-07-16 Marek Safar <marek.safar@gmail.com>
716 A fix for bug #521671
717 * statement.cs: Fixed crash when checking missing type.
719 2009-07-16 Marek Safar <marek.safar@gmail.com>
721 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
722 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
723 class.cs, driver.cs: Work on dynamic binding.
725 * dynamic.cs: New file.
727 * *.sources, *.proj: Updated.
729 2009-07-15 Marek Safar <marek.safar@gmail.com>
731 * expression.cs (Conditional): Avoid double Resolve.
733 2009-07-13 Marcus Griep <marcus@griep.us>
735 * ecore.cs: Fix obscure bug with resolving members of interfaces
736 that hide parent interface members. Fixes bug #444388 and corrects
739 2009-07-13 Marek Safar <marek.safar@gmail.com>
741 * expression.cs (LocalVariableReference): Bounce resolve.
743 2009-07-10 Marek Safar <marek.safar@gmail.com>
745 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
746 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
749 * support.cs: New dynamic type wrapper.
751 2009-07-08 Marek Safar <marek.safar@gmail.com>
753 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
754 typed local variable.
756 2009-07-06 Marek Safar <marek.safar@gmail.com>
758 A fix for bug #519005
759 * anonymous.cs: Use null_type as no return type placeholder.
761 2009-07-02 Marek Safar <marek.safar@gmail.com>
763 * generic.cs: Handle type inference of identical type parameters
764 with different bounds.
766 2009-07-01 Marek Safar <marek.safar@gmail.com>
768 * expression.cs, class.cs: Events variance.
770 * cs-parser.jay: Interface events error messages.
772 2009-07-01 Marek Safar <marek.safar@gmail.com>
774 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
776 2009-06-29 Marek Safar <marek.safar@gmail.com>
778 * parameter.cs, convert.cs, expression.cs, class.cs: Default
779 parameter expression can be value-type New.
781 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
783 2009-06-26 Marek Safar <marek.safar@gmail.com>
785 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
786 Implemented C# 4.0 named arguments.
788 2009-06-24 Marek Safar <marek.safar@gmail.com>
790 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
791 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
792 parameter modifier. Also fixes bug #515497.
794 2009-06-24 Marek Safar <marek.safar@gmail.com>
796 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
797 arguments expression to be implemented.
799 *.sources: Add argument.cs
801 2009-06-23 Marek Safar <marek.safar@gmail.com>
803 * parameter.cs: Moved GetParameterIndexByName to base class.
805 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
806 unused AType. Use argument's version of GetExpressionTree.
808 2009-06-22 Marek Safar <marek.safar@gmail.com>
810 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
813 2009-06-17 Marek Safar <marek.safar@gmail.com>
815 A fix for bug #514096
816 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
818 2009-06-17 Marek Safar <marek.safar@gmail.com>
820 * expression.cs: The first multi-dimensional array nested array
821 initializers was not checked.
823 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
825 2009-06-17 Marek Safar <marek.safar@gmail.com>
827 A fix for bug #513400
828 * nullable.cs (EmitEquality): Operands emit could be simplified for
829 built-in types when we now emit user operators differently.
831 2009-06-16 Marek Safar <marek.safar@gmail.com>
833 * ecore.cs: Report inaccessible delegate methods correctly.
835 2009-06-16 Marek Safar <marek.safar@gmail.com>
837 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
838 cs-parser.jay: Implemented C# 4.0 optional parameters.
840 2009-06-16 Marek Safar <marek.safar@gmail.com>
842 * driver.cs: Removed broken DefineManifestResource.
844 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
846 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
847 Use $(BOOTSTRAP_PROFILE) instead.
849 2009-06-12 Jb Evain <jbevain@novell.com>
851 * rootcontext.cs: add a Platform field.
852 * driver.cs: handle /platform.
853 * codegen.cs: pass the proper flags according to
854 the platform when saving the assembly.
856 2009-06-11 Marek Safar <marek.safar@gmail.com>
858 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
859 Add optional parameters grammar.
861 2009-06-10 Marek Safar <marek.safar@gmail.com>
863 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
864 driver.cs: Split lang version and metadata version.
866 2009-06-10 Marek Safar <marek.safar@gmail.com>
868 * decl.cs: Better overload ctor collision error message.
870 2009-06-05 Jb Evain <jbevain@novell.com>
872 * driver.cs (EmbededResource): avoid using an internal method
873 in gmcs to embed manifest resources.
875 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
877 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
878 the compiler from older mono versions (like moon's bots)
880 2009-06-04 Marek Safar <marek.safar@gmail.com>
882 * namespace.cs (LookupTypeReflection): Ignore collisions between
885 2009-06-04 Marek Safar <marek.safar@gmail.com>
887 * codegen.cs: Enabled generic type forwarders.
889 2009-06-04 Marek Safar <marek.safar@gmail.com>
891 * dmcs.*: Add another version of SRE compiler.
893 2009-06-03 Marek Safar <marek.safar@gmail.com>
895 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
896 generic-mcs.cs: Fixed variant type conversions.
898 2009-06-02 Marek Safar <marek.safar@gmail.com>
900 A fix for bug #507863
901 * codegen.cs: Fixes a crash on invalid string value attribute.
903 2009-06-01 Marek Safar <marek.safar@gmail.com>
905 A fix for bug #508334
906 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
907 cs-parser.jay: Fully import __arglist modifier.
909 2009-05-29 Marek Safar <marek.safar@gmail.com>
911 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
912 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
913 actually work with closed generic types.
915 2009-05-27 Alan McGovern <amcgovern@novell.com>
917 * class.cs, decl.cs, delegate.cs, parameter.cs:
918 Fix the build by replacing the use of 'var' with the actual type.
920 2009-05-27 Marek Safar <marek.safar@gmail.com>
922 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
923 cs-parser.jay, generic-mcs.cs: Report wrong variant types
926 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
929 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
930 Marek Safar <marek.safar@gmail.com>
932 A fix for bug #377509
933 * parameter.cs: Use predefined and not empty name for implicit
936 2009-05-21 Marek Safar <marek.safar@gmail.com>
938 * class.cs: Don't report wrong warnings for event fields.
940 2009-05-21 Marek Safar <marek.safar@gmail.com>
942 A fix for bug #504667
943 * class.cs: Check for static class using parent container instead of
946 2009-05-08 Marek Safar <marek.safar@gmail.com>
948 A fix for bug #496922
949 * expression.cs: Always use temporary variable when using object
952 2009-04-28 Marek Safar <marek.safar@gmail.com>
954 A fix for bug #495112
955 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
958 2009-04-27 Miguel de Icaza <miguel@novell.com>
960 * driver.cs: Add a flag to work as a replacement for CSC in VS.
962 2009-04-24 Miguel de Icaza <miguel@novell.com>
964 * complete.cs: No idea how gonzalo got a null in the list, but
967 2009-04-24 Miguel de Icaza <miguel@novell.com>
969 * complete.cs (CompletionElementInitializer): New completion class
970 to support completing inside a C# 3 element initializer, so this
971 allows completion for Silverlight situations where it is very
974 new TextBlock () { Fo<TAB>
976 (CompletionSimpleName): Expose the prefix that was
977 passed to the simple name.
979 * cs-parser.jay (object_or_collection_initializer): Add support
980 for element_initializers.
982 * expression.cs (CollectionOrObjectInitializers.DoResolve):
983 special case completion expressions as this method aggressively
984 collects data before it operates, and errors were being thrown
985 earlier than we were able to complete.
987 2009-04-23 Miguel de Icaza <miguel@novell.com>
989 * eval.cs: Make getcompletions silent and enable debugging output
990 if the -v option is passed.
992 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
993 Consider looking up the namespace that matches the prefix being
996 This is part of the support for allowing completions like:
997 `System.Co<TAB>' to complete to System.Console.
999 * complete.cs (CompletionSimpleName.AppendResults): Make this
1002 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1004 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1005 COMPLETE_COMPLETION as internal.
1007 2009-04-17 Miguel de Icaza <miguel@novell.com>
1009 * complete.cs: Include namespace resolution in simple names as
1010 well as global types and types in the using scope in the
1013 * namespace.cs: Supporting infrastrcture to provide completions
1014 based on the current using scope.
1016 * eval.cs: Introduce an entry point that allows for initialization
1017 to return a list of the files passed on the command line.
1019 2009-04-14 Marek Safar <marek.safar@gmail.com>
1021 A fix for bug #494243
1022 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1024 2009-04-13 Marek Safar <marek.safar@gmail.com>
1026 A fix for bug #493887
1027 * statement.cs: Don't skip string multi-section with default or
1028 null label when populating string hashtable.
1030 2009-04-06 Marek Safar <marek.safar@gmail.com>
1032 A fix for bug #492329
1033 * expression.cs (New): Load variable when assigning type parameter
1036 2009-04-06 Marek Safar <marek.safar@gmail.com>
1038 A fix for bug #488960
1039 * decl.cs: Compare MVAR types using non-null values.
1041 2009-03-27 Marek Safar <marek.safar@gmail.com>
1043 * typemanager.cs, expression.cs: Removed unused nullable checks.
1045 2009-03-27 Marek Safar <marek.safar@gmail.com>
1047 * *.cs: Removed some gmcs conditionals.
1049 2009-03-26 Marek Safar <marek.safar@gmail.com>
1051 * generic.cs, support.cs: Moved generics stuff out of support.cs
1053 2009-03-24 Marek Safar <marek.safar@gmail.com>
1055 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1058 2009-03-23 Marek Safar <marek.safar@gmail.com>
1060 * attribute.cs: Consider all members for error reporting when
1061 checking named arguments.
1063 2009-03-23 Marek Safar <marek.safar@gmail.com>
1065 A fix for bug #487625
1066 * namespace.cs: Use a warning for all predefined type conflicts.
1068 2009-03-23 Marek Safar <marek.safar@gmail.com>
1070 A fix for bug #485706
1071 * statement.cs: Explicitly type catch type argument to pass verifier
1074 2009-03-22 Miguel de Icaza <miguel@novell.com>
1076 Initial support to provide code completion facilities to consumers
1077 of the evaluator API.
1079 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1080 support the completion engine. When we reach the end of the
1081 input stream instead of returning EOF, when this flag is true the
1082 tokenizer instead produces:
1084 One GENERATE_COMPLETION token: this token then must be
1085 handled in the grammar at every point where the user
1086 would likely request a completion.
1088 As many COMPLETE_COMPLETION tokens as necessary. These
1089 tokens are generated to assist the parser in unwinding and
1090 producing a valid parse tree.
1092 The parser rules do not have to be perfect, the parser needs to be
1093 augmented with judicious use of GENERATE_COMPLETION tokens to
1094 improve the areas where we can provide completion and the parser
1095 needs to add support for COMPLETE_COMPLETION tokens in productions
1098 It is common to not have enough support for COMPLETE_COMPLETION
1099 under certain rules and that even if we generated the
1100 GENERATE_COMPLETION token that the resulting tree will be invalid
1101 due to the missing rules that support COMPLETE_COMPLETION.
1103 The final EOF token is produced by having the parser notify the
1104 tokenizer when it reaches the root production that the next token
1107 * support.cs (CompletionResult): New Exception. This exception
1108 is thrown to return the completion results when one of the special
1109 completion expressions is reached.
1111 This exception is thrown by the completing ExpressionStatements
1112 classes that live in complete.cs
1114 * complete.cs (CompletingExpression): a new base class for
1115 completing expressions. This derives from the
1116 ExpressionStatement class and not from Expression as it allows
1117 completion to happen not only where expressions are expected in
1118 the grammar, but also where statements are expected.
1120 (CompletionSimpleName): A new class used to provide completions
1121 for SimpleNames. This currently only resolves to local
1122 variables from the evaluator context (GetVars call).
1124 (CompletionMemberAccess): Implements support for completing member
1127 * cs-parser.jay: Add support for completion in a few places.
1129 * eval.cs (GetCompletions): New public API for the evaluator that
1130 returns a list of possible completions given the input. The
1131 return value is an array of completions
1133 * anonymous.cs (Compatible): If the exception thrown from the
1134 resolved expression is a CompletionResult exception let that one
1135 through instead of printing a diagnostic error in the try/catch.
1137 2009-03-22 Miguel de Icaza <miguel@novell.com>
1141 * driver.cs (Main): Use Environment.Exit to quit quickly and
1142 prevent the compiler from doing the usual wait for helper thread
1145 This is to prevent a slowdown that was reported by Gonzalo on
1148 2009-03-19 Marek Safar <marek.safar@gmail.com>
1150 * ecore.cs: Load build-in types directly instead of accessing
1153 2009-03-18 Marek Safar <marek.safar@gmail.com>
1155 * ecore.cs: Always use unbox.any when available.
1157 2009-03-18 Marek Safar <marek.safar@gmail.com>
1159 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1161 2009-03-17 Marek Safar <marek.safar@gmail.com>
1163 * generic.cs: Removed obsolete version of type inference.
1165 2009-03-16 Marek Safar <marek.safar@gmail.com>
1167 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1168 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1169 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1170 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1172 2009-03-11 Marek Safar <marek.safar@gmail.com>
1174 A fix for bug #482996
1175 * anonymous.cs: Make sure we are not infering return type when
1176 checking type compatibility.
1178 2009-03-11 Marek Safar <marek.safar@gmail.com>
1180 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1181 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1182 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1183 attributes in their own structure. Needed when accessing their
1184 properties before they are resolved.
1186 2009-03-09 Marek Safar <marek.safar@gmail.com>
1188 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1189 hashtable (~10x faster).
1191 * driver.cs: Removed wrong Reset.
1193 2009-03-08 Marek Safar <marek.safar@gmail.com>
1195 * class.cs: Use correct common base type for unmanaged delayed
1198 * rootcontext.cs: Wrap unhandled exception.
1200 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1202 Make SeekableStreamReader self-tuning and arbitrarily seekable
1203 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1205 (SeekableStreamReader.Position.set): Use it. Simplify logic
1206 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1207 buffer size when the stream needs to be re-read from the beginning.
1209 2009-03-05 Marek Safar <marek.safar@gmail.com>
1211 A fix for bug #480100
1212 * parameter.cs: A parameter is not hoisted when used directly as ET.
1214 2009-03-04 Marek Safar <marek.safar@gmail.com>
1216 * statement.cs: Fixed an issue when using variable is of interface
1219 2009-03-03 Marek Safar <marek.safar@gmail.com>
1221 A fix for bug #480319
1222 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1224 2009-03-03 Marek Safar <marek.safar@gmail.com>
1226 A fix for bug #480867
1227 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1228 expression to have no valid type.
1230 2009-03-03 Marek Safar <marek.safar@gmail.com>
1232 A fix for bug #481258
1233 * class.cs: Set extension method flag in partial container.
1235 2009-03-03 Marek Safar <marek.safar@gmail.com>
1237 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1239 * attribute.cs: Add sanity check.
1241 2009-02-27 Marek Safar <marek.safar@gmail.com>
1243 * class.cs: Add external constructor error.
1245 2009-02-26 Marek Safar <marek.safar@gmail.com>
1247 A fix for bug #475354
1248 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1249 correctly user defined nullable equality operators.
1251 2009-02-25 Marek Safar <marek.safar@gmail.com>
1253 A fix for bug #479532
1254 * expression.cs: Implement NewInitialize::AddressOf.
1256 2009-02-25 Marek Safar <marek.safar@gmail.com>
1258 A fix for bug #413633
1259 * expression.cs: Iterate all base class-constraint types.
1261 2009-02-24 Marek Safar <marek.safar@gmail.com>
1263 A fix for bug #479209
1264 * literal.cs: Mutate null underlying type.
1266 2009-02-24 Marek Safar <marek.safar@gmail.com>
1268 A fix for bug #476295
1269 * convert.cs: Avoid wrapping implicitly convertible reference type.
1271 2009-02-23 Marek Safar <marek.safar@gmail.com>
1273 * iterators.cs: Create MemberName correctly.
1275 2009-02-23 Marek Safar <marek.safar@gmail.com>
1277 A fix for bug #478655
1278 * literal.cs: Check also underlying null type conversion.
1280 2009-02-21 Marek Safar <marek.safar@gmail.com>
1282 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1284 2009-02-20 Marek Safar <marek.safar@gmail.com>
1286 A fix for bug #477447
1287 * statement.cs: Add reference to correct parent storey when this
1288 is accessible from deep children storey (more than 1 level).
1290 2009-02-19 Marek Safar <marek.safar@gmail.com>
1292 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1293 * class.cs: Define base type members before setting up member cache.
1295 2009-02-18 Marek Safar <marek.safar@gmail.com>
1297 A fix for bug #477378
1298 * nullable.cs, expression.cs, statement.cs: More precise null type
1301 2009-02-18 Marek Safar <marek.safar@gmail.com>
1303 A fix for bug #472805
1304 * typemanager.cs, namespace.cs: Import only visible extension method
1307 2009-02-18 Marek Safar <marek.safar@gmail.com>
1309 A fix for bug #476895
1310 * attribute.cs: Use correct resolve context for attribute type.
1312 2009-02-18 Marek Safar <marek.safar@gmail.com>
1314 A fix for bug #476266
1315 * anonymous.cs: Mutate multi-dimensional arrays.
1317 2009-02-18 Marek Safar <marek.safar@gmail.com>
1319 A fix for bug #476400
1320 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1322 2009-02-18 Marek Safar <marek.safar@gmail.com>
1324 A fix for bug #476811
1325 * generics.cs: Fixed null-literal check.
1327 2009-02-17 Marek Safar <marek.safar@gmail.com>
1329 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1330 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1331 messing with static variables.
1333 2009-02-16 Marek Safar <marek.safar@gmail.com>
1335 A fix for bug #475965
1336 * generics.cs: Check generic parameter type after extracting from
1339 2009-02-16 Marek Safar <marek.safar@gmail.com>
1341 A fix for bug #475823
1342 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1345 2009-02-14 Marek Safar <marek.safar@gmail.com>
1347 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1348 Simplified event field definition using backing field and not
1349 field builder directly.
1351 * expression.cs (EmitLdArg): Optimize fast paths.
1353 2009-02-13 Marek Safar <marek.safar@gmail.com>
1355 A fix for bug #475327
1356 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1358 2009-02-13 Marek Safar <marek.safar@gmail.com>
1360 A fix for bug #475342
1361 * cs-parser.jay: Using 'super' instead of 'base' to call base
1362 constructor crashes compiler.
1364 2009-02-13 Marek Safar <marek.safar@gmail.com>
1366 A fix for bug #475354
1367 * expression.cs (Constantify): Add nullable types.
1369 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1371 2009-02-12 Marek Safar <marek.safar@gmail.com>
1373 A fix for bug #475246
1374 * expression.cs: More broken flowanalysis hacking needed.
1376 2009-02-12 Marek Safar <marek.safar@gmail.com>
1378 * attribute.cs: Compare only ref/out array modifiers.
1380 2009-02-11 Marek Safar <marek.safar@gmail.com>
1382 * statement.cs: Use member cache when looking for foreach members.
1384 2009-02-11 Marek Safar <marek.safar@gmail.com>
1386 * expression.cs: Don't expose internal initializer types.
1388 * statement.cs: Check also explicit conversions for goto case.
1390 2009-02-11 Marek Safar <marek.safar@gmail.com>
1392 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1394 2009-02-10 Marek Safar <marek.safar@gmail.com>
1396 * *.cs: Replace null-type with NullLiteral where appropriate.
1398 2009-02-09 Marek Safar <marek.safar@gmail.com>
1400 * expression.cs: Initializer of reference argument use temporary
1401 variable to be verifiable.
1403 * parameter.cs: Share EmitLdArg.
1405 2009-02-09 Marek Safar <marek.safar@gmail.com>
1407 A fix for bug #473559
1408 * class.cs: Fixed: Not reporting error about nested class with the
1411 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1413 Contributed under the MIT/X11 license.
1415 * generic.cs: Added VerifyVariantTypeParameters which performs new
1416 variance verification logic. The old logic, based on the spec, was
1417 wrong because the spec is full of LIES!
1419 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1421 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1424 * ecore.cs: Added calls to the new variance verification logic.
1427 * delegate.cs: Removed calls to the old variance verification logic.
1429 2009-02-06 Marek Safar <marek.safar@gmail.com>
1431 * delegate.cs: Use cached Invoke method directly.
1433 2009-02-06 Marek Safar <marek.safar@gmail.com>
1435 * expression.cs: Emit expression tree for hoisted variable access.
1437 2009-02-04 Marek Safar <marek.safar@gmail.com>
1439 * namespace.cs: Add better extension class check.
1441 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1443 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1445 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1447 This patch adds initial generic variance support to the compiler.
1448 It is contributed under the MIT/X11 license.
1450 * typemanager.cs: Modified ImplementsInterface to check variance.
1451 Added VerifyVariantTypeParameters which checks the specified type to see
1452 if it uses a variant type parameter as a type argument (which is not
1453 allowed). Added IsVariantOf which determins if the first type is a
1454 variant of the second. NOTE: This only supports reference types at
1455 the moment to conform with the current level of VM support. When the
1456 VM supports value types, this will follow step.
1458 * generic.cs: Added the Variance enum. Added a Variance property to
1459 TypeParameter and added variance support to definition phase. Added a
1460 Variance property to TypeParameterName. Also check to make sure that
1461 no variant types appear in generic method parameters.
1463 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1464 keywords if the langversion supports it.
1466 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1467 that variant types are only used in legal positions. Also added
1468 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1471 * decl.cs: Construct TypeParameter with the variance information.
1473 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1474 and ImplicitConversionStandard.
1476 * rootcontext.cs: Added new "Future" language version.
1478 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1479 type parameters are not used as type arguments in interface inheritance.
1480 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1481 parameters are not used as method return types. In MemberBase.
1482 ResolveMemberType, ensure that variant type parameters are not used
1483 as type arguments. Also call VerifyNoVariantTypeParameters on every
1484 set of parameters which are resolved.
1486 * delegate.cs: Modified Delegate.Define to ensure that variant
1487 parameters are not used as type arguments and that a contravariant
1488 parameter is not used as the return type. Also call
1489 VerifyNoVariantTypeParameters on the delegate parameters.
1491 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1492 to specify generic variance.
1494 * driver.cs: Added support for LanguageVersion.Future in the form of
1495 "-langversion:future".
1497 * generic-mcs.cs: Stubbed out new members in generic.cs.
1499 2009-02-03 Marek Safar <marek.safar@gmail.com>
1501 * class.cs, generic.cs: Emit type parameter constraints for nested
1504 2009-02-02 Marek Safar <marek.safar@gmail.com>
1506 A fix for bug #471213
1507 * class.cs: Avoid emitting backing field for abstract event fields.
1509 2009-02-01 Marek Safar <marek.safar@gmail.com>
1511 A fix for bug #359731
1512 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1515 2009-01-30 Marek Safar <marek.safar@gmail.com>
1517 A fix for bug #470767
1518 * statement.cs: Introduced BlockScopeExpression, needed when
1519 expression tree conversion has to emit scope variables.
1521 2009-01-29 Marek Safar <marek.safar@gmail.com>
1523 * class.cs: Remove duplicate CallingConvention.
1525 2009-01-29 Marek Safar <marek.safar@gmail.com>
1527 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1528 when I finally found the right naming convention.
1530 2009-01-29 Marek Safar <marek.safar@gmail.com>
1532 * cs-tokenizer.cs: Put back different open parens optimization.
1534 2009-01-28 Marek Safar <marek.safar@gmail.com>
1536 A fix for bug #470227
1537 * cs-tokenizer.cs: Remove too agressive parser optimization.
1539 2009-01-28 Marek Safar <marek.safar@gmail.com>
1541 A fix for bug #324319
1542 * class.cs: Remove too early base type resolve.
1544 2009-01-27 Marek Safar <marek.safar@gmail.com>
1546 A fix for bug #324319
1547 * ecore.cs: Explicitly type null when assigning to type argument to
1548 make pass verifier check.
1550 2009-01-27 Marek Safar <marek.safar@gmail.com>
1552 * anonymous.cs: Fixed recent regression when initializing captured
1555 2009-01-26 Marek Safar <marek.safar@gmail.com>
1557 A fix for bug #469019
1558 * anonymous.cs: Use all parent type parameters when instantiating
1559 nested generic storey.
1561 2009-01-26 Marek Safar <marek.safar@gmail.com>
1563 * expression.cs: Check for null instance methodgroup expression.
1565 2009-01-26 Marek Safar <marek.safar@gmail.com>
1567 A fix for bug #469244
1568 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1569 instance inside a conditional expression.
1571 2009-01-23 Marek Safar <marek.safar@gmail.com>
1573 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1574 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1575 GetElementType and HasElementType. IsValueType clean up.
1577 2009-01-23 Marek Safar <marek.safar@gmail.com>
1579 * nullable.cs: Use common EmitCall.
1581 * expression.cs: Emit constraint. for virtual calls only.
1583 2009-01-23 Marek Safar <marek.safar@gmail.com>
1585 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1586 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1587 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1590 2009-01-22 Jb Evain <jbevain@novell.com>
1592 * anonymous.cs: make anonymous types' ToString implementation
1593 match what csc outputs.
1595 2009-01-21 Marek Safar <marek.safar@gmail.com>
1597 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1600 2009-01-17 Marek Safar <marek.safar@gmail.com>
1602 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1605 2009-01-16 Marek Safar <marek.safar@gmail.com>
1607 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1610 2009-01-15 Marek Safar <marek.safar@gmail.com>
1612 A fix for bug #466634
1613 * statement.cs: Add reference for nested storey when only this
1616 2009-01-15 Marek Safar <marek.safar@gmail.com>
1618 A fix for bug #466474
1619 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1622 2009-01-15 Marek Safar <marek.safar@gmail.com>
1624 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1625 Fixed nested stories parent referencing process. Also fixes #463985.
1627 2009-01-06 Marek Safar <marek.safar@gmail.com>
1629 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1630 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1631 implementation. Also fixes #463108.
1633 2009-01-05 Marek Safar <marek.safar@gmail.com>
1635 A fix for bug #416109
1636 * decl.cs: Issue correct CLSAttribute warning location.
1638 2009-01-05 Marek Safar <marek.safar@gmail.com>
1640 A fix for bug #456775
1641 * attribute.cs: Use attribute owner scope when resolving attribute
1644 2009-01-05 Marek Safar <marek.safar@gmail.com>
1646 A fix for bug #457257
1647 * decl.cs: Fixed incorrect member declaring type comparison.
1649 2009-01-05 Marek Safar <marek.safar@gmail.com>
1651 A fix for bug #460896
1652 * driver.cs: Handle /RES resources as embeddable.
1654 2009-01-05 Marek Safar <marek.safar@gmail.com>
1656 A fix for bug #462515
1657 * ecore.cs: Report inacessible members upwards.
1659 2009-01-05 Marek Safar <marek.safar@gmail.com>
1661 A fix for bug #463190, #463192
1662 * decl.cs, namespace.cs: Also import internal extension classes.
1664 2009-01-04 Marek Safar <marek.safar@gmail.com>
1666 A fix for bug #463415
1667 * generic.cs: Use right index for RemoveDependentTypes.
1669 2009-01-02 Marek Safar <marek.safar@gmail.com>
1671 A fix for bug #463196
1672 * expression.cs: Fixed enum to null comparison.
1674 2009-01-02 Marek Safar <marek.safar@gmail.com>
1676 A fix for bug #463121
1677 * nullable.cs: Fixed nullable user equality operator comparison.
1679 2009-01-02 Marek Safar <marek.safar@gmail.com>
1681 A fix for bug #462950
1682 * class.cs, decl.cs: Use full explicit name when defining automatic
1683 property backing field.
1685 2009-01-02 Marek Safar <marek.safar@gmail.com>
1687 A fix for bug #462592
1688 * pending.cs: Emit type arguments for generic proxy method.
1690 2008-12-30 Marek Safar <marek.safar@gmail.com>
1692 * expression.cs (As): Mutate all type arguments.
1694 2008-12-29 Marek Safar <marek.safar@gmail.com>
1696 A fix for bug #462622
1697 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1700 2008-12-29 Marek Safar <marek.safar@gmail.com>
1702 A fix for bug #450782
1703 * ecore.cs: Consider more variables of form V.I to be fixed.
1705 2008-12-29 Marek Safar <marek.safar@gmail.com>
1707 A fix for bug #460712
1708 * typemanager.cs: Core types could be imported.
1710 2008-12-28 Marek Safar <marek.safar@gmail.com>
1712 A fix for bugs #460847, #460772, #458049, #457339, #447807
1713 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
1714 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
1715 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
1716 user lambdas used inside query clauses.
1718 2008-12-18 Marek Safar <marek.safar@gmail.com>
1720 A fix for bug #460229
1721 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
1723 2008-12-18 Marek Safar <marek.safar@gmail.com>
1725 A fix for bug #459952
1726 * decl.cs, namespace.cs: Use common CheckAccessLevel.
1728 2008-12-18 Marek Safar <marek.safar@gmail.com>
1730 A fix for bug #459630
1731 * convert.cs: Enum to valuetype conversion is not allowed.
1733 2008-12-18 Marek Safar <marek.safar@gmail.com>
1735 A fix for bug #457087
1736 * generic.cs: Don't crash when constraint comes from type
1739 2008-12-16 Marek Safar <marek.safar@gmail.com>
1741 A fix for bug #459221
1742 * anonymous.cs, statement.cs: Delay only captured this
1745 2008-12-12 Marek Safar <marek.safar@gmail.com>
1747 A fix for bug #457489
1748 * anonymous.cs, statement.cs: Split anonymous storey instantiation
1749 and initialization to capture scope initializers correctly.
1751 2008-12-11 Marek Safar <marek.safar@gmail.com>
1753 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
1754 ParameterReference refactoring.
1756 2008-12-03 Marek Safar <marek.safar@gmail.com>
1758 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
1759 to be imported from any assembly.
1761 2008-12-03 Marek Safar <marek.safar@gmail.com>
1763 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
1764 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
1765 from anonymous method and lambda expression.
1767 2008-12-01 Marek Safar <marek.safar@gmail.com>
1769 A fix for bug #448560
1770 * expression.cs (As): Box any generic type arguments to be
1773 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1775 Add tripwire for implicit conversion bugs
1776 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
1778 (MethodGroupExpr.OverloadResolve): Add sanity check between
1779 IsApplicable and VerifyArgumentsCompat.
1780 (VerifyArgumentsCompat): Report CS1501 where appropriate.
1782 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1784 Fix build break in System.Data_test
1785 * convert.cs (ImplicitConversionExists): Move NullLiteral
1787 (ImplicitStandardConversionExists): ... here.
1789 2008-11-28 Marek Safar <marek.safar@gmail.com>
1791 * literal.cs: Emit correctly explicit null to nullable cast.
1793 2008-11-28 Marek Safar <marek.safar@gmail.com>
1795 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
1798 2008-11-28 Marek Safar <marek.safar@gmail.com>
1800 A fix for bug #449005
1801 * convert.cs, nullable.cs: Use only one implicit nullable
1804 2008-11-27 Marek Safar <marek.safar@gmail.com>
1806 * convert.cs, literal.cs: More Convert cleanup is needed.
1808 2008-11-27 Marek Safar <marek.safar@gmail.com>
1810 * decl.cs, class.cs: Fixed misleading error message.
1812 2008-11-26 Marek Safar <marek.safar@gmail.com>
1814 A fix for bug #449005
1815 * nullable.cs (EmitEquality): Disable optimization for user operator
1818 2008-11-25 Marek Safar <marek.safar@gmail.com>
1820 A fix for bug #447027
1821 * anonymous.cs (HoistedVariable): Cache also outer access to deal
1822 with context variables stored as expression instances.
1824 2008-11-25 Marek Safar <marek.safar@gmail.com>
1826 A fix for bug #447027
1827 * delegate.cs: Fixed delegate VerifyMethod logic.
1829 2008-11-24 Marek Safar <marek.safar@gmail.com>
1831 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
1834 2008-11-21 Marek Safar <marek.safar@gmail.com>
1836 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
1837 member type resolve to follow normal flow, instead of random
1840 2008-11-21 Marek Safar <marek.safar@gmail.com>
1842 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
1845 2008-11-21 Marek Safar <marek.safar@gmail.com>
1847 * const.cs: Emit decimal array constant as literal.
1849 2008-11-20 Marek Safar <marek.safar@gmail.com>
1851 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
1853 2008-11-19 Marek Safar <marek.safar@gmail.com>
1855 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
1856 into real property (saves 8 MB for corlib compilation).
1858 2008-11-19 Marek Safar <marek.safar@gmail.com>
1860 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
1861 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
1862 generic-mcs.cs: Small cleanup of TypeArguments.
1864 2008-11-18 Marek Safar <marek.safar@gmail.com>
1866 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
1867 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
1868 of ConstructedType expression, renamed to GenericTypeExpr.
1870 2008-11-17 Marek Safar <marek.safar@gmail.com>
1872 A fix for bug #445303
1873 * location.cs (IsConditionalDefined): Handle undefined global
1876 2008-11-17 Marek Safar <marek.safar@gmail.com>
1878 A fix for bug #444678
1879 * expression.cs (TryReduceConstant): Always create new constant
1882 2008-11-17 Marek Safar <marek.safar@gmail.com>
1884 A fix for bug #444673
1885 * ecore.cs: Ignore open generic types when used as generic type
1888 2008-11-17 Marek Safar <marek.safar@gmail.com>
1890 A fix for bug #445458
1891 * expression.cs, cs-parser.jay: Don't crash when an expression
1894 2008-11-17 Marek Safar <marek.safar@gmail.com>
1896 A fix for bug #445464
1897 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
1898 inside unbound type.
1900 2008-11-14 Jb Evain <jbevain@novell.com>
1902 * driver.cs: ignore empty -nowarn argument such as
1903 the one in -nowarn:12,13,,.
1905 2008-11-13 Marek Safar <marek.safar@gmail.com>
1907 A fix for bug #444271
1908 * anonymous.cs: Rescan parent storeys when best candidate was
1911 2008-11-13 Marek Safar <marek.safar@gmail.com>
1913 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
1914 useless UnboundTypeExpression.
1916 * attribute.cs: Do check obsolete attribute on generic types.
1918 2008-11-12 Marek Safar <marek.safar@gmail.com>
1920 A fix for bugs #425680, #400139
1921 * ecore.cs, expression.cs: Trying to do some almost_matched_members
1924 2008-11-11 Marek Safar <marek.safar@gmail.com>
1926 A fix for bug #435747
1927 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
1928 compound value types assignment. Few micro optimizations added.
1930 2008-11-10 Marek Safar <marek.safar@gmail.com>
1932 A fix for bug #442610
1933 * anonymous.cs (MutateConstructor): More SRE hacking.
1935 2008-11-10 Marek Safar <marek.safar@gmail.com>
1937 A fix for bug #442579
1938 * ecore.cs: Also initialize expanded form of a method with 1 params
1941 2008-11-06 Marek Safar <marek.safar@gmail.com>
1943 * expression.cs (UnaryMutator): Do early l-side check.
1945 2008-11-05 Miguel de Icaza <miguel@novell.com>
1947 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
1948 Init, otherwise we would crash later on when checking for friend
1951 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
1952 Otherwise we never get any meaningful information as to what
1955 2008-11-05 Marek Safar <marek.safar@gmail.com>
1957 A fix for bug #436318
1958 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
1960 2008-11-05 Miguel de Icaza <miguel@novell.com>
1962 * namespace.cs: Turns out that it was a really bad idea to hide
1963 the errors for namespaces not found here in eval mode.
1965 * eval.cs: When we process using clauses, only enter those into
1966 the list of valid using clauses after they have been validated.
1968 The above change gives the proper semantics: it does not
1969 senselessly report the same errors with broken using statements by
1970 never storing them in the first place when they are invalid.
1972 2008-11-05 Marek Safar <marek.safar@gmail.com>
1974 A fix for bug #421839
1975 * cs-parser.jay: Remove expression from coalesce rule to force lower
1976 priority than the assignment operator.
1978 2008-11-05 Marek Safar <marek.safar@gmail.com>
1980 A fix for bug #437875
1981 * nullable.cs: Compile correctly method group operand used with null
1982 coalescing operator.
1984 2008-11-04 Marek Safar <marek.safar@gmail.com>
1986 A fix for bug #434589
1987 * expression.cs (Binary): Ignore lifted conversions when at least
1988 one operand is of reference type.
1990 2008-11-04 Marek Safar <marek.safar@gmail.com>
1992 * cs-parser.jay: Better syntax error report.
1994 2008-11-03 Marek Safar <marek.safar@gmail.com>
1996 A fix for bug #436792
1997 * cs-parser.jay: Use GetLocation to access location.
1999 2008-11-03 Marek Safar <marek.safar@gmail.com>
2001 A fix for bug #440774
2002 * cs-parser.jay: Also set current_array_type when parsing local
2005 2008-11-03 Marek Safar <marek.safar@gmail.com>
2007 A fix for bug #440785
2008 * expression.cs (As): Don't resolve self modifing expression
2011 2008-11-03 Marek Safar <marek.safar@gmail.com>
2013 A fix for bug #439447
2014 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2016 2008-11-03 Marek Safar <marek.safar@gmail.com>
2018 A fix for bug #437571
2019 * cs-parser.jay: Fixes internal error for invalid expression
2022 2008-10-17 Marek Safar <marek.safar@gmail.com>
2024 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2026 2008-10-17 Marek Safar <marek.safar@gmail.com>
2028 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2030 2008-10-17 Marek Safar <marek.safar@gmail.com>
2032 * cs-tokenizer.cs: More precise cast parsing.
2034 2008-10-16 Martin Baulig <martin@ximian.com>
2036 * anonymous.cs (AnonymousMethodStorey): Put back the
2037 `hoisted_locals' hashtable and use it in EmitType().
2039 2008-10-15 Marek Safar <marek.safar@gmail.com>
2041 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2042 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2045 2008-10-14 Marek Safar <marek.safar@gmail.com>
2047 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2049 2008-10-14 Marek Safar <marek.safar@gmail.com>
2051 * statement.cs: Mutate scope initializers.
2053 2008-10-14 Marek Safar <marek.safar@gmail.com>
2055 * expression.cs: Use typeless value for This constant.
2057 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2059 2008-10-14 Marek Safar <marek.safar@gmail.com>
2061 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2064 2008-10-13 Marek Safar <marek.safar@gmail.com>
2066 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2069 2008-10-13 Marek Safar <marek.safar@gmail.com>
2071 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2072 parser and tokenizer. Fixes many ambiguities including #433258.
2074 2008-10-10 Marek Safar <marek.safar@gmail.com>
2076 * cs-parser.jay: Fixed missing accessor recovery.
2078 2008-10-10 Marek Safar <marek.safar@gmail.com>
2080 A fix for bug #433701
2081 * expression.cs: Better error message.
2083 2008-10-10 Marek Safar <marek.safar@gmail.com>
2085 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2087 * Makefile: Disabled unused debug symbols.
2089 Also fixes: #320556, #321097, #321656, #321876, #351316
2091 2008-10-09 Miguel de Icaza <miguel@novell.com>
2093 * eval.cs: rename "<interactive>" to "{interactive}", to work
2094 around a requirement in the compiler that this be a valid
2095 filename, and in Windows it is not (433886).
2097 2008-10-09 Marek Safar <marek.safar@gmail.com>
2099 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2101 2008-10-08 Marek Safar <marek.safar@gmail.com>
2103 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2104 cs-parser.jay: Generic type declaration and type arguments cleanup.
2106 2008-10-05 Marek Safar <marek.safar@gmail.com>
2108 * cs-parser.jay: Allow parsing weird array creation construct.
2110 2008-10-05 Marek Safar <marek.safar@gmail.com>
2112 * cs-parser.jay: Conflicts reduction.
2114 2008-10-04 Marek Safar <marek.safar@gmail.com>
2116 * cs-parser.jay: Conflicts reduction.
2118 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2121 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2122 property. Add a 'count' hint about the use of the shared vector.
2123 Ensure that we don't leak out dirty bits.
2124 (UsageVector.MergeChild): Throw away information about variables
2126 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2128 2008-10-03 Marek Safar <marek.safar@gmail.com>
2130 A fix for bug #431746
2131 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2132 parameters when iterator is created.
2134 2008-10-03 Marek Safar <marek.safar@gmail.com>
2136 A fix for bug #431827
2137 * expression.cs: Fixed right based pointer arithmetic operations
2140 2008-10-03 Marek Safar <marek.safar@gmail.com>
2142 A fix for bug #353779
2143 * assign.cs, expression.cs: Fixed compound assignment conversions.
2145 2008-10-02 Marek Safar <marek.safar@gmail.com>
2147 A fix for bug #375262
2148 * statement.cs: Refactor ArrayForeach to be usable with string
2149 indexer. Optimized single dimentional arrays foreach.
2151 2008-10-02 Marek Safar <marek.safar@gmail.com>
2153 A fix for bug #431255
2154 * anonymous.cs, expression.cs: Removed broken optimization.
2156 2008-10-01 Marek Safar <marek.safar@gmail.com>
2158 * anonymous.cs: Use full type parameters of parent generic
2159 containers. Removed unnecessary AddParentStoreyReference call.
2161 2008-10-01 Marek Safar <marek.safar@gmail.com>
2163 A fix for bug #324702
2164 * class.cs: Use better shorter names for explicit interface member
2167 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2169 2008-10-01 Marek Safar <marek.safar@gmail.com>
2171 * expression.cs: Use new interface to check fixed expression.
2173 2008-10-01 Marek Safar <marek.safar@gmail.com>
2175 A fix for bug #421101
2176 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2177 interface to check for fixed fixed-buffers.
2179 2008-10-01 Marek Safar <marek.safar@gmail.com>
2181 A fix for bug #429264
2182 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2184 * delegate.cs: Removed unnecessary casts.
2186 2008-09-30 Marek Safar <marek.safar@gmail.com>
2188 A fix for bug #352151
2189 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2190 class.cs: Fixed already defined explicit interface members check.
2192 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2194 cs-tokenizer.cs: Fix typo.
2196 2008-09-28 Miguel de Icaza <miguel@novell.com>
2198 * eval.cs (InteractiveBase): The quit command now just sets a
2199 flag, instead of calling Environment.Exit(), it is milder on
2202 CompiledMethod is now in Mono.CSharp, not nested inside
2203 the Evaluator, it was inconvenient to use.
2205 2008-09-27 Miguel de Icaza <miguel@novell.com>
2207 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2208 code to be invoked without having to reparse.
2210 2008-09-27 Miguel de Icaza <miguel@novell.com>
2212 * ecore.cs: The recent changes to FieldExpr broke this as well.
2213 Fixes LINQ queries in the interactive shell.
2215 * Multiple files: indentation fixing for the Mono coding
2216 guidelines for the switch statement.
2218 * eval.cs: Make the Evaluator API thread safe.
2220 2008-09-26 Marek Safar <marek.safar@gmail.com>
2222 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2223 constructor parsing.
2225 2008-09-26 Marek Safar <marek.safar@gmail.com>
2227 A fix for bug #325326
2228 * statement.cs: Check possible mistaken empty statement using
2229 explicit blocks only.
2231 2008-09-25 Miguel de Icaza <miguel@novell.com>
2233 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2234 RootNamespace.ComputeNamespaces to update the internal list of
2235 namespaces, this is no longer done for us.
2237 (InteractiveBase): Use the Evaluator APIs instead of calling into
2240 2008-09-25 Marek Safar <marek.safar@gmail.com>
2242 A fix for bug #429264
2243 * expression.cs: Missing mutator for access to multidimensional
2246 2008-09-25 Marek Safar <marek.safar@gmail.com>
2248 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2251 * driver.cs: Missing input argument check.
2253 2008-09-25 Marek Safar <marek.safar@gmail.com>
2255 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2256 expression.cs, statement.cs, rootcontext.cs, class.cs,
2257 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2260 2008-09-24 Miguel de Icaza <miguel@novell.com>
2262 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2263 fully constructed FieldExpr, fixes the regression introduced in
2266 * ecore.cs, expression.cs: Plug back the eclass initialization as
2267 otherwise it regresses `csharp'.
2269 2008-09-24 Marek Safar <marek.safar@gmail.com>
2271 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2272 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2273 phase to resolve phase. It resolves problems with expression trees
2274 and fixes bugs #323796, #325156.
2276 2008-09-23 Marek Safar <marek.safar@gmail.com>
2278 * codegen.cs: Report better error when symbol writer is missing.
2280 2008-09-23 Marek Safar <marek.safar@gmail.com>
2282 * codegen.cs: Set .NET symbol writer.
2284 * decl.cs: Guard against null generic arguments.
2286 * report.cs: Don't report exactly same additional details.
2288 2008-09-22 Marek Safar <marek.safar@gmail.com>
2290 A fix for bug #324917
2291 * cs-parser.jay: Add missing multidimensional non-expression type
2294 2008-09-22 Marek Safar <marek.safar@gmail.com>
2296 A fix for bug #428191
2297 * anonymous.cs: Create an outer generic fields also for non-storey
2300 2008-09-22 Marek Safar <marek.safar@gmail.com>
2302 A fix for bug #378294
2303 * class.cs: Make fixed size buffers gmcs feature only.
2305 2008-09-22 Marek Safar <marek.safar@gmail.com>
2307 A fix for bug #355622, #324993
2308 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2311 2008-09-19 Marek Safar <marek.safar@gmail.com>
2313 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2316 2008-09-19 Marek Safar <marek.safar@gmail.com>
2318 A fix for bug #416110
2319 * generic.cs: Struct constraint results in default ctor and
2320 ValueType base type constraint to be set.
2322 2008-09-19 Marek Safar <marek.safar@gmail.com>
2324 A fix for bug #423791
2325 * generic.cs: Fixed params output type type-inference.
2327 2008-09-19 Marek Safar <marek.safar@gmail.com>
2329 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2331 2008-09-19 Marek Safar <marek.safar@gmail.com>
2333 * cs-tokenizer.cs: Don't break on extra partial modifier.
2335 2008-09-19 Marek Safar <marek.safar@gmail.com>
2337 A fix for bug #427592
2338 * generic.cs: Use common parameter resolve method.
2340 2008-09-18 Marek Safar <marek.safar@gmail.com>
2342 A fix for bug #414758
2343 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2346 2008-09-18 Marek Safar <marek.safar@gmail.com>
2348 * driver.cs, namespace.cs: Read types and namespaces after all
2349 requested assemblies are loaded, fixes issues with System.Core
2350 auto-reference, and #419888.
2352 2008-09-18 Marek Safar <marek.safar@gmail.com>
2354 A fix for bug #417705
2355 * cs-parser.jay: Fixed as/is operator expression split.
2357 2008-09-18 Marek Safar <marek.safar@gmail.com>
2359 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2360 Fixed expression tree representation of empty new expression and
2361 new initializer expression.
2363 2008-09-18 Miguel de Icaza <miguel@novell.com>
2365 * eval.cs: Remove warning, keep reference to driver around.
2367 * Hide fields that do not need to be public.
2369 2008-09-17 Marek Safar <marek.safar@gmail.com>
2371 A fix for bug #426385
2372 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2373 conversion for array elements.
2375 2008-09-17 Marek Safar <marek.safar@gmail.com>
2377 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2378 void parsing conflicts.
2380 2008-09-15 Marek Safar <marek.safar@gmail.com>
2382 A fix for bug #425601
2383 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2384 System.Core only when there is no custom ExtensionAttribute
2387 2008-09-15 Miguel de Icaza <miguel@novell.com>
2389 * namespace.cs: Do not report CS0246 (name
2391 2008-09-12 Marek Safar <marek.safar@gmail.com>
2393 A fix for bug #425669
2394 * generic.cs: Don't cache generic static anonymous method
2397 2008-09-12 Marek Safar <marek.safar@gmail.com>
2399 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2400 conflicting constraints.
2402 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2404 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2407 2008-09-12 Marek Safar <marek.safar@gmail.com>
2409 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2410 to null pointer conversion fixes.
2412 2008-09-11 Marek Safar <marek.safar@gmail.com>
2414 * cs-parser.jay, expression.cs: An implicitly typed local variable
2415 declarator cannot use an array initializer.
2417 2008-09-11 Marek Safar <marek.safar@gmail.com>
2419 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2421 2008-09-11 Marek Safar <marek.safar@gmail.com>
2423 * generic.cs (InflatedConstraints): Don't crash when constraints
2426 * cs-parser.jay: const_declarator is a block.
2428 * constant.cs: Check for not allowed NaN conversions.
2430 2008-09-10 Miguel de Icaza <miguel@novell.com>
2432 * driver.cs: Drop --shell argument, the compiler is no longer a
2435 * eval.cs: Move most of the code that deals with evaluation into
2436 this file and document the public API from repl.cs
2438 * repl.cs: Remove from here.
2440 2008-09-10 Marek Safar <marek.safar@gmail.com>
2442 A fix for bug #424684
2443 * generic.cs: Generic class constraints must come first.
2445 2008-09-09 Miguel de Icaza <miguel@novell.com>
2447 * cs-parser.jay: Improve error reporting for syntax errors in
2448 statements and expressions, we now report the expected tokens
2449 instead of reporting the useless "; expected".
2451 Drop the strings from the token declaration, it turns out that
2452 they did not do what I thought they did. Instead they were adding
2453 two sets of tokens to the tables.
2455 2008-09-09 Marek Safar <marek.safar@gmail.com>
2457 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2458 delegate.cs: Share special type check.
2460 2008-09-09 Marek Safar <marek.safar@gmail.com>
2462 A fix for bug #423981
2463 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2465 2008-09-09 Marek Safar <marek.safar@gmail.com>
2467 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2470 2008-09-09 Marek Safar <marek.safar@gmail.com>
2472 A fix for bugs: #324750, #335946
2473 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2474 lookup rule to determine ?-based tokens.
2476 2008-09-08 Miguel de Icaza <miguel@novell.com>
2478 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2479 expressions (like event adding or removing) end up here, so we
2480 need to treat those as statements.
2482 Add LoadAssembly method.
2484 2008-09-04 Miguel de Icaza <miguel@novell.com>
2486 * repl.cs: Add Time method.
2488 2008-09-05 Marek Safar <marek.safar@gmail.com>
2490 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2492 2008-09-05 Miguel de Icaza <miguel@novell.com>
2494 * repl.cs: Add workaround for old compilers.
2496 2008-09-04 Jb Evain <jbevain@novell.com>
2498 * repl.cs (PrettyPrint): pretty print everything that
2499 implements IDictionary, as well as IEnumerables. Also,
2500 add a quit helper property.
2502 2008-09-04 Marek Safar <marek.safar@gmail.com>
2504 * constant.cs: Better error reporting for decimal literals.
2506 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2509 2008-09-04 Marek Safar <marek.safar@gmail.com>
2510 Miguel de Icaza <miguel@novell.com>
2512 A fix for bug #422951
2513 * assign.cs (Assign.DoResolve): Perform the type conversions
2514 checks before we attempt to initialize `New' initializers.
2516 2008-09-04 Marek Safar <marek.safar@gmail.com>
2518 A fix for bug #422853
2519 * delegate.cs (DelegateCreation): Add special handling for
2520 EmptyExpression.Null instance expression which is just another
2521 hack for undecided member instance exression.
2523 2008-09-04 Marek Safar <marek.safar@gmail.com>
2525 * expression.cs, ecore.cs: Emit full expression tree for reduced
2528 2008-09-04 Marek Safar <marek.safar@gmail.com>
2530 * expression.cs (This): Guard against multi-resolving.
2532 * ecore.cs, statement.cs (Throw): Simplified.
2534 * flowanalysis.cs: Also verify event fields.
2536 2008-09-04 Miguel de Icaza <miguel@novell.com>
2538 * assign.cs (Assign.DoResolve): Perform the type conversions
2539 checks before we attempt to initialize `New' initializers.
2541 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2543 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2546 * repl.cs: Update help.
2548 2008-09-03 Miguel de Icaza <miguel@novell.com>
2550 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2551 handling of the default config handling, including the special
2552 treatment of System.Core assembly.
2554 Fixes the REPL processing for LINQ.
2556 2008-09-03 Marek Safar <marek.safar@gmail.com>
2558 A fix for bug #422507
2559 * expression.cs (UnboxCast): Add missing child expression mutator.
2561 2008-09-03 Marek Safar <marek.safar@gmail.com>
2563 * driver.cs: Don't self reference System.Core assembly.
2565 2008-09-03 Marek Safar <marek.safar@gmail.com>
2567 A fix for bug #422507
2568 * expression.cs (StringConcat): Add missing type mutator.
2570 2008-09-03 Marek Safar <marek.safar@gmail.com>
2572 * generic.cs (TypeInferenceContext): Follow equality rule for
2573 constructed type lower bound type inference.
2575 2008-09-02 Miguel de Icaza <miguel@novell.com>
2577 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2578 <dblank@cs.brynmawr.edu> which updates the cursor position on
2581 2008-09-02 Marek Safar <marek.safar@gmail.com>
2583 A fix for bug #367145
2584 * driver.cs: Fixed import of extension methods when using -noconfig
2587 2008-09-02 Marek Safar <marek.safar@gmail.com>
2589 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2590 version from non-generic implementation instead.
2592 2008-09-01 Marek Safar <marek.safar@gmail.com>
2594 A fix for bug #418908
2595 * class.cs: Use AddScopeStatement for field initializers.
2597 2008-09-01 Marek Safar <marek.safar@gmail.com>
2599 A fix for bug #415385
2600 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2602 2008-09-01 Marek Safar <marek.safar@gmail.com>
2604 A fix for bug #421736
2605 * iterators.cs: Don't crash on unreachable iterators.
2607 2008-09-01 Marek Safar <marek.safar@gmail.com>
2609 A fix for bug #421628
2610 * parameter.cs, attribute.cs: Clone also parameter attributes.
2612 2008-08-30 Miguel de Icaza <miguel@novell.com>
2614 * namespace.cs (LookupType): In EvalMode, try to replace
2615 the TypeBuilder from our cache with a Type as Reflection.Emit does
2616 not like to mix code from older assemblies emitted and new
2619 This sounds like a serious Mono bug that prevents multiple
2620 assemblies to be generated and consumed at the same time.
2622 * cs-parser.jay (push_current_class): Do not make interactive
2623 classes internal or private, make them public as we currently
2624 generate each new class in a new assembly.
2626 2008-08-29 Miguel de Icaza <miguel@novell.com>
2628 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2629 remove types that are entered into the global namespace during
2630 parsing so that we can remove them on failure.
2632 * cs-parser.jay: Parsing: we now keep track of types that are
2633 entered into global variables and queue those in case the parsing
2636 This happens in a few situations: during partial-input, we invoke
2637 the parser repeatedly for example with the string "class X", this
2638 would cause X to be registed, and we need to remove this
2639 registration so that another parse attempt later with say "class X {"
2640 would actually work.
2642 Additionally, if there is an error in the resolution phase, for
2643 example: "class X : NonExistant {}" th
2645 * cs-parser.jay: Be more precise with the errors being raised,
2646 instead of flagging all exceptions during parsing to be attributed
2647 to the parsing process, distinguish those from errors happening in
2648 the actions and hint that using -v would produce the actual
2651 * repl.cs: Do not load all compiler references on each reset,
2652 doing the partial reset takes care of this.
2654 2008-08-28 Miguel de Icaza <miguel@novell.com>
2656 * repl.cs: Add support for loading all the files from
2657 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2660 Introduce a micro-parser that is able to deambiguate on its input
2661 whether we are dealing with a compilation unit (namespace, class,
2662 interface, struct, delegate) declaration or a statement. This
2663 allows both declarations and statements to be entered.
2665 Set history size by default to 300 lines.
2667 Instead of distinguishing based on the parser.InteractiveResult,
2668 have only two cases: statements were parsed, or a compilation unit
2669 was. Always pull the Using statement additions from the
2670 compilation unit parse.
2672 * cs-tokenizer.cs: Rename tokens to better describe their intent
2673 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2675 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2676 EvalMode is used to trigger the lookup of global variables while
2677 StatementMode is used turn variable declarations into static
2680 * getline.cs: Allow history size to be set.
2682 2008-08-29 Marek Safar <marek.safar@gmail.com>
2684 A fix for bug #360755
2685 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2687 2008-08-29 Marek Safar <marek.safar@gmail.com>
2689 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2691 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2692 member name, it is too confusing
2694 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2696 * rootcontext.cs: Finally default to warning level 4.
2698 2008-08-28 Marek Safar <marek.safar@gmail.com>
2700 * class.cs (CheckBase): Ignore overloaded operators.
2702 2008-08-28 Marek Safar <marek.safar@gmail.com>
2704 A fix for bug #420830
2705 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
2707 2008-08-28 Marek Safar <marek.safar@gmail.com>
2709 A fix for bug #420832
2710 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
2712 2008-08-28 Marek Safar <marek.safar@gmail.com>
2714 A fix for bug #420386
2715 * nullables.cs: Fixed logic of nullable user comparison operators involving
2718 2008-08-28 Marek Safar <marek.safar@gmail.com>
2720 * attribute (IsClsCompliant): Use FALSE value for pointer types.
2722 2008-08-27 Miguel de Icaza <miguel@novell.com>
2724 * repl.cs: Add support for aborting the running code with C-c.
2726 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
2728 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
2730 2008-08-27 Miguel de Icaza <miguel@novell.com>
2732 * cs-parser.jay (interactive_statement_list): A new set of rules
2733 for hosting statements that uses the "interactive_" prefix.
2735 * repl.cs: Add support for parsing `using' as a statement or as a
2736 directive. Deambiguating before passing this to the parser.
2738 We need to distinguish statement_expressions that occur at the
2739 toplevel vs those that occur embedded into expressions.
2741 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
2742 that fixes the cursor key handling, and a history bug.
2744 2008-08-26 Miguel de Icaza <miguel@novell.com>
2746 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
2747 limitations in Console, instead the 2.0 bootstrap libraries now
2748 include the Console bits.
2750 Also, remove the use of Nullables from getline.cs
2754 Interactive support for the C# compiler. Use gmcs --shell to
2755 enter a read-eval-print loop shell.
2757 Docs: http://www.mono-project.com/CsharpRepl
2759 * sources: include repl.cs here and getline.cs for gmcs.exe,
2760 everything else is getline.cs impaired.
2762 * Makefile: when bootstrapping pass a special flag
2763 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
2764 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
2765 This distinguishes those two cases.
2767 * repl.cs: Support for a read-eval-print loop. Will be soon
2768 refactored into eval support and then REPL on top of it.
2770 * ecore.cs: If a simplename lookup fails, before erroring out,
2771 if we are in EvalMode to resolve the name to a declaration in the
2774 This means that variable declarations that happened in previous
2775 classes (as repl puts every statement in a separate class) are
2776 made visible in this way.
2778 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
2779 triggered an error due to the end of file being reached. This is
2780 used to do multi-line input, and notify the caller that the user
2781 needs to provide more text before a successful parse.
2783 Add new grammar rules after the INTERACTIVE_PARSER token is seen
2784 to drive the evaluation with a custom wrapper.
2786 * driver.cs: Add support for --shell, and refactor some code to be
2789 * namespace.cs: Add support for serializing the contents of the
2790 namespaces and reloading them.
2792 * getline.cs: A managed implementation of ReadLine under
2793 X11/Apache2 license terms. Easy to embed in other applications as
2796 * namespace.cs: Add some functions to save and restore the
2799 * rootcontext.cs: New public field.
2801 * cs-tokenizer.cs: Add support for one of the possible characters
2802 we introduce into the token stream.
2804 This patch does not affect the regular tokenization process, the
2805 only performance hit would happen if there is an invalid character
2806 on the input string.
2808 * support.cs: Move isatty helper routine here.
2810 * codegen.cs: Small cleanup, and add a mechanism to initialize the
2811 code generator for in-memory assemblies.
2813 2008-08-26 Marek Safar <marek.safar@gmail.com>
2815 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
2816 parameter cannot be always used as a type.
2818 2008-08-21 Marek Safar <marek.safar@gmail.com>
2820 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
2822 2008-08-21 Marek Safar <marek.safar@gmail.com>
2824 * convert.cs: Implement explicit array to IList<T> conversion.
2826 2008-08-20 Marek Safar <marek.safar@gmail.com>
2828 A fix for bug #362740
2829 * cs-tokenizer.cs: Handle UTF-16 surrogates.
2831 2008-08-20 Marek Safar <marek.safar@gmail.com>
2833 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
2834 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
2835 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
2836 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
2837 handling to use just one type of infrastructure and deal with generics
2840 2008-07-23 Martin Baulig <martin@ximian.com>
2842 *** Merged this from trunk revision 108527 ***
2845 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
2846 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
2849 2008-08-15 Marek Safar <marek.safar@gmail.com>
2851 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
2854 2008-08-15 Marek Safar <marek.safar@gmail.com>
2856 * delegate.cs: Fixed compiler crash when creating delegate using partial
2859 * typemanager.cs: MulticastDelegate is not a delegate.
2861 2008-08-14 Marek Safar <marek.safar@gmail.com>
2863 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
2866 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
2868 * cs-parser.jay (type): Allow 'var' in mcs too.
2869 (local_variable_type): Likewise.
2871 2008-08-14 Marek Safar <marek.safar@gmail.com>
2873 * driver.cs: Removed broken -noconfig variants.
2875 2008-08-14 Marek Safar <marek.safar@gmail.com>
2877 A fix for bug #417078
2878 * expression.cs: Emit correctly left side pointer operators.
2880 2008-08-13 Marek Safar <marek.safar@gmail.com>
2882 * generic.cs, lambda.cs: Inflate method generic arguments only.
2884 2008-08-12 Marek Safar <marek.safar@gmail.com>
2886 * class.cs: Fixed struct layout check regression.
2888 2008-08-12 Marek Safar <marek.safar@gmail.com>
2890 * cs-parser.jay, enum.cs: Simplified enum parsing.
2892 * decl.cs: Check all type parameters conflicts.
2894 * expression.cs, statement.cs, attribute.cs: More expression checks.
2896 2008-08-11 Marek Safar <marek.safar@gmail.com>
2898 * generic.cs: Add type inference types restriction.
2900 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
2901 anonymous.cs, expression.cs: Allocate less accessor parameters.
2903 2008-08-08 Marek Safar <marek.safar@gmail.com>
2905 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
2908 2008-08-08 Marek Safar <marek.safar@gmail.com>
2910 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
2912 2008-08-07 Marek Safar <marek.safar@gmail.com>
2914 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
2915 Also fixes #362146 and #381592.
2917 2008-08-07 Marek Safar <marek.safar@gmail.com>
2919 * ecore.cs: Reduced constant cannot be used as an attribute value.
2921 * cs-parser.jay: Base expression has to be a type.
2923 * expression.cs (Conditional): Uses ReducedExpression.
2925 2008-08-06 Marek Safar <marek.safar@gmail.com>
2927 A fix for bug #376826
2928 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
2929 address of hoisted local variable or parameter cannot be taken.
2931 2008-08-05 Marek Safar <marek.safar@gmail.com>
2933 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
2934 anonymous method inside checked/unchecked expression.
2936 2008-08-05 Marek Safar <marek.safar@gmail.com>
2938 * typemanager.cs (IsEqual): Guard against null.
2940 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
2941 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
2942 routine. Fixed few misleading conversion errors.
2944 2008-08-04 Marek Safar <marek.safar@gmail.com>
2946 * class.cs: Consider generics when checking cycles in struct layout.
2948 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
2950 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
2952 2008-08-04 Marek Safar <marek.safar@gmail.com>
2954 A fix for bug #414165
2955 * anonymous.cs: Use same anonymous implementation method for all anonymous
2958 2008-08-04 Marek Safar <marek.safar@gmail.com>
2960 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
2963 2008-08-04 Marek Safar <marek.safar@gmail.com>
2965 * cs-parser.jay: Typeof argument has to be a type expression.
2967 * namespace.cs: Check alias and namespace definitions collisions.
2969 * class.cs, pending.cs: Moved explicit interface accessor implementation
2972 * delegate.cs, expression.cs: Verify special name invocations.
2974 2008-08-01 Marek Safar <marek.safar@gmail.com>
2976 * cs-parser.jay: Don't choke on empty generic type arguments.
2978 * cs-tokenizer.cs: Handle escaped preprocessor directives.
2980 * expression.cs, ecore.cs: Minor expressions bugs.
2982 2008-08-01 Marek Safar <marek.safar@gmail.com>
2984 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
2985 and added more error handling.
2987 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
2989 * modifiers.cs, enum.cs: Fixed.
2991 2008-07-31 Jb Evain <jbevain@novell.com>
2993 * driver.cs: remove -pkg ability of smcs.
2995 2008-07-30 Marek Safar <marek.safar@gmail.com>
2997 * statement.cs (Switch): Correctly set empty default target for single
3000 2008-07-30 Marek Safar <marek.safar@gmail.com>
3002 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3003 string switch statement implementation to use string dictionary which
3004 significantly (2-8x) improves performance of generated code.
3006 2008-07-29 Marek Safar <marek.safar@gmail.com>
3008 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3009 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3011 2008-07-29 Marek Safar <marek.safar@gmail.com>
3013 A fix for bug #412595
3014 * typemanager.cs, convert.cs, expression.cs: Some types are never
3015 convertible to each other.
3017 2008-07-29 Marek Safar <marek.safar@gmail.com>
3019 * nullable.cs (CreateNullConstant): An error messages update.
3021 2008-07-29 Marek Safar <marek.safar@gmail.com>
3023 A fix for bug #412595
3024 * cfold.cs: Don't cast undefined bool constant.
3026 2008-07-29 Martin Baulig <martin@ximian.com>
3029 (SymbolWriter.Reset): New public static method.
3032 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3034 2008-07-28 Marek Safar <marek.safar@gmail.com>
3036 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3038 * expression.cs (ElementAccess): Exact size allocation.
3040 2008-07-26 Marek Safar <marek.safar@gmail.com>
3042 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3044 2008-07-25 Marek Safar <marek.safar@gmail.com>
3046 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3048 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3051 2008-07-25 Marek Safar <marek.safar@gmail.com>
3053 A fix for bug #412217
3054 * assign.cs: Mutate also assignment type.
3056 2008-07-25 Marek Safar <marek.safar@gmail.com>
3058 A fix for bug #323644
3059 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3062 2008-07-25 Marek Safar <marek.safar@gmail.com>
3064 A fix for bug #412134
3065 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3066 non-enumerable operands when overloading equality or bitwise operators.
3068 2008-07-25 Marek Safar <marek.safar@gmail.com>
3070 * anonymous.cs: Cache closed generic anonymous method delegates.
3072 2008-07-24 Marek Safar <marek.safar@gmail.com>
3074 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3075 anonymous.cs, statement.cs: Always emit anonymous method as static method
3076 when is instance free. Use nesting for nested anynomous methods blocks.
3078 2008-07-23 Marek Safar <marek.safar@gmail.com>
3080 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3083 2008-07-23 Marek Safar <marek.safar@gmail.com>
3085 * expression.cs: Removed MakeSimpleCall.
3087 2008-07-23 Marek Safar <marek.safar@gmail.com>
3089 A fix for bug #323012
3090 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3091 Base method implementing interface has to be public.
3093 2008-07-23 Marek Safar <marek.safar@gmail.com>
3095 * cs-parser.jay: Don't break on missing argument.
3097 2008-07-22 Marek Safar <marek.safar@gmail.com>
3099 A fix for bug #320993
3100 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3101 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3103 2008-07-22 Marek Safar <marek.safar@gmail.com>
3105 A fix for bug #320748
3106 * convert.cs: Implicit user operators cannot convert to interfaces
3108 2008-07-22 Marek Safar <marek.safar@gmail.com>
3110 A fix for bug #312686
3111 * driver.cs: Ignore empty assembly references.
3113 2008-07-22 Marek Safar <marek.safar@gmail.com>
3115 A fix for bug #387040
3116 * ecore.cs: Skip constrains check for an explicit implementation.
3118 2008-07-21 Marek Safar <marek.safar@gmail.com>
3120 A fix for bug #409045
3121 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3122 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3123 identifiers are file specific unless passed as input arguments.
3125 2008-07-21 Marek Safar <marek.safar@gmail.com>
3127 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3128 to emit UnmanagedMarshal data under 2.0 profile.
3130 2008-07-21 Marek Safar <marek.safar@gmail.com>
3132 A fix for bug #410369
3133 * parameter.cs: Clone correctly ParamsParameter.
3135 2008-07-21 Marek Safar <marek.safar@gmail.com>
3137 * expression.cs (Argument): Always report type for type based expressions
3140 2008-07-18 Marek Safar <marek.safar@gmail.com>
3142 A fix for bug #410666
3143 * anonymous.cs: Correctly initialize generic storey reference.
3145 2008-07-18 Marek Safar <marek.safar@gmail.com>
3147 * convert.cs: Don't box same type arguments.
3149 2008-07-18 Marek Safar <marek.safar@gmail.com>
3151 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3152 Finished missing generic type mutators.
3154 2008-07-18 Marek Safar <marek.safar@gmail.com>
3156 * iterators.cs, statement.cs: Finished statements CloneTo.
3158 2008-07-18 Marek Safar <marek.safar@gmail.com>
3160 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3162 * expression.cs: Emit optimized default value expressions in expression tree
3165 2008-07-18 Marek Safar <marek.safar@gmail.com>
3167 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3169 2008-07-17 Marek Safar <marek.safar@gmail.com>
3171 A fix for bug #367536
3172 * cs-parser.jay: Check static constructor of generic types for an access
3175 2008-07-17 Marek Safar <marek.safar@gmail.com>
3177 A fix for bug #353800
3178 * lambda.cs: Emit ret for contextual statements.
3180 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3181 up emitting redundant ret for all anonymous methods with return.
3183 2008-07-17 Marek Safar <marek.safar@gmail.com>
3185 A fix for bug #365188
3186 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3187 create anonymous method storey in unreachable block.
3189 2008-07-17 Marek Safar <marek.safar@gmail.com>
3191 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3192 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3193 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3194 statement.cs: Fixed relevant defects found by Gendarme.
3196 2008-07-17 Marek Safar <marek.safar@gmail.com>
3198 A fix for bug #325291
3199 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3200 statement.cs: Replaced IAnonymousHost with top level block flag.
3202 2008-07-17 Marek Safar <marek.safar@gmail.com>
3204 * cs-parser.jay: Clean up unused open_parens.
3206 2008-07-17 Marek Safar <marek.safar@gmail.com>
3208 * ecore.cs: Custom error message for a range variable assignment.
3210 2008-07-16 Marek Safar <marek.safar@gmail.com>
3212 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3215 2008-07-16 Marek Safar <marek.safar@gmail.com>
3217 * literal.cs: Null literal is of object type.
3219 2008-07-16 Marek Safar <marek.safar@gmail.com>
3221 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3222 expression of nullable equality comparison.
3224 2008-07-15 Marek Safar <marek.safar@gmail.com>
3226 * expression.cs(PointerArithmetic): Removed redundant assignment.
3228 2008-07-15 Marek Safar <marek.safar@gmail.com>
3230 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3232 2008-07-14 Marek Safar <marek.safar@gmail.com>
3234 A fix for bug #408361
3235 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3236 they are replaced by GetMethod.
3238 2008-07-14 Marek Safar <marek.safar@gmail.com>
3240 A fix for bug #408721 by jeremie.laval@gmail.com
3241 * expression.cs (Indirection): Implemented CloneTo.
3243 2008-07-14 Marek Safar <marek.safar@gmail.com>
3245 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3248 2008-07-14 Marek Safar <marek.safar@gmail.com>
3250 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3252 2008-07-11 Marek Safar <marek.safar@gmail.com>
3254 * linq.cs: Reset tranparent parameter counter in probing mode.
3256 2008-07-11 Marek Safar <marek.safar@gmail.com>
3258 * anonymous.cs: Mutate anonymous method type.
3260 2008-07-11 Marek Safar <marek.safar@gmail.com>
3262 * ecore.cs, anonymous.cs: Mutate field expressions.
3264 2008-07-10 Marek Safar <marek.safar@gmail.com>
3266 A fix for bug #369670
3267 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3269 2008-07-10 Marek Safar <marek.safar@gmail.com>
3271 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3273 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3276 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3277 only one '>', and finds a '>>', abort the generic lookahead.
3279 2008-07-10 Marek Safar <marek.safar@gmail.com>
3281 A fix for bug #319902
3282 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3284 2008-07-10 Marek Safar <marek.safar@gmail.com>
3286 A fix for bug #406371
3287 * statement.cs: Moved EmitSymbolInfo to Block.
3289 2008-07-09 Marek Safar <marek.safar@gmail.com>
3291 * ecore.cs: Report better error for extension method overload failures.
3293 2008-07-09 Marek Safar <marek.safar@gmail.com>
3295 * expression.cs (Is): No need to box reference values.
3297 2008-07-09 Marek Safar <marek.safar@gmail.com>
3299 * class.cs: Use event resolve context when initializing CreateEmitContext.
3301 2008-07-09 Marek Safar <marek.safar@gmail.com>
3303 A fix for bug #394436
3304 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3305 method used inside expression trees. Added more LINQ to expression tree
3308 2008-07-08 Marek Safar <marek.safar@gmail.com>
3310 A fix for bug #378189, #370577
3311 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3314 2008-07-08 Marek Safar <marek.safar@gmail.com>
3316 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3319 2008-07-08 Marek Safar <marek.safar@gmail.com>
3321 A fix for bug #406702
3322 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3324 2008-07-07 Marek Safar <marek.safar@gmail.com>
3326 A fix for bug #406648
3327 * cs-parser.jay: Report nullable use in mcs for some cases.
3329 2008-07-07 Marek Safar <marek.safar@gmail.com>
3331 * ecore.cs: Improved argument mismatch error messages.
3333 2008-07-07 Marek Safar <marek.safar@gmail.com>
3335 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3337 2008-07-07 Marek Safar <marek.safar@gmail.com>
3339 * expression.cs (TypeOf): Mutate type argument.
3341 2008-07-04 Marek Safar <marek.safar@gmail.com>
3343 * class.cs: Report missing partial modifier for correct type.
3345 2008-07-04 Marek Safar <marek.safar@gmail.com>
3347 * ecore.cs, expression.cs (VariableReference): Variable property is
3350 2008-07-04 Marek Safar <marek.safar@gmail.com>
3352 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3354 2008-07-04 Marek Safar <marek.safar@gmail.com>
3356 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3359 2008-07-04 Marek Safar <marek.safar@gmail.com>
3361 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3362 anonymous method storey to an instance method when only "this" is hoisted.
3364 2008-07-03 Marek Safar <marek.safar@gmail.com>
3366 A fix for bug #321615
3367 * expression.cs: Pointer comparisons use unsigned operator.
3369 2008-07-03 Marek Safar <marek.safar@gmail.com>
3371 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3373 2008-07-02 Marek Safar <marek.safar@gmail.com>
3375 A fix for bug #404905
3376 * class.cs: Always initialize local unsafe variables.
3378 2008-06-30 Marek Safar <marek.safar@gmail.com>
3380 A fix for bug #396987
3381 * expression.cs (NewInitialize): Clear local temporary variable for next run
3383 2008-06-27 Marek Safar <marek.safar@gmail.com>
3385 A fix for bug #401020
3386 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3388 2008-06-27 Marek Safar <marek.safar@gmail.com>
3390 A fix for bug #398319
3391 * cs-parser.jay: Implemented undocumented base access expression inside
3394 2008-06-26 Marek Safar <marek.safar@gmail.com>
3396 A fix for bug #404227
3397 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3399 2008-06-26 Marek Safar <marek.safar@gmail.com>
3401 A fix for bug #404227
3402 * convert.cs: Fixed explicit array to interface cast.
3404 2008-06-26 Marek Safar <marek.safar@gmail.com>
3406 A fix for bug #403894
3407 * delegate.cs: Mutate DelegateInvocation type.
3409 2008-06-26 Marek Safar <marek.safar@gmail.com>
3411 A fix for bug #379348
3412 * delegate.cs: Box a load of generic parameters.
3414 2008-06-26 Marek Safar <marek.safar@gmail.com>
3416 * expression.cs: Add an array creation arguments mutate.
3418 2008-06-26 Marek Safar <marek.safar@gmail.com>
3420 A fix for bug #386068
3421 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3424 2008-06-25 Marek Safar <marek.safar@gmail.com>
3426 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3429 2008-06-25 Marek Safar <marek.safar@gmail.com>
3431 A fix for bug #403518
3432 * delegate.cs: Type correctly anonymous method new invocation.
3434 2008-06-24 Marek Safar <marek.safar@gmail.com>
3436 A fix for bug #394826
3437 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3440 2008-06-24 Marek Safar <marek.safar@gmail.com>
3442 A fix for bug #394826
3443 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3446 2008-06-24 Marek Safar <marek.safar@gmail.com>
3448 * class.cs: Clone indexer parameters for localized capturing.
3450 2008-06-24 Marek Safar <marek.safar@gmail.com>
3452 A fix for bug #402379
3453 * expression.cs: Don't crash when an object initializer resolve fails.
3455 2008-06-24 Marek Safar <marek.safar@gmail.com>
3457 A fix for bug #402888
3458 * expression.cs: Mutate conditional expression.
3460 2008-06-24 Marek Safar <marek.safar@gmail.com>
3462 A fix for bug #401012
3463 * class.cs: Keep StructLayout in shared container.
3465 2008-06-24 Marek Safar <marek.safar@gmail.com>
3467 A fix for bug #400438
3468 * decl.cs, class.cs: Only properties can be automatically implemented.
3470 2008-06-24 Marek Safar <marek.safar@gmail.com>
3472 * statement.cs (ChangeToIterator): Copy also labels.
3474 2008-06-23 Marek Safar <marek.safar@gmail.com>
3476 * ecore.cs: Pass type argument details to parent extension method.
3478 2008-06-23 Marek Safar <marek.safar@gmail.com>
3480 A fix for bug #375966
3481 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3483 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3485 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3487 2008-06-22 Marek Safar <marek.safar@gmail.com>
3489 A fix for bug #394347
3490 * anonymous.cs: Cache compatible delegates as compatibility check produces
3491 a new method every time.
3493 2008-06-20 Marek Safar <marek.safar@gmail.com>
3495 * anonymous.cs: Propagate storey reference for single references.
3497 2008-06-20 Marek Safar <marek.safar@gmail.com>
3499 A fix for bug #387615
3500 * assign.cs, expression.cs: Correctly clone compound assignment.
3502 2008-06-19 Marek Safar <marek.safar@gmail.com>
3504 A fix for bug #359611, #359604
3505 * anonymous.cs: Mutate all types of hoisted parameters.
3507 2008-06-19 Marek Safar <marek.safar@gmail.com>
3509 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3510 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3511 expression.cs, codegen.cs, statement.cs
3513 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3514 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3516 ** Anonymous methods, lambda expressions rewrite **
3518 Anonymous expressions are now resolved when an explicit block is resolved
3519 and they don't require any registration procedure anymore. Further,
3520 anonymous methods are defined when explicit block is emitted which allows
3521 better control of whole process and opens possibilities for more
3522 optimizations as well as alternative to reverse whole process.
3524 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3525 process consistent and to correctly emit hoisted generic methods when they
3526 have at least 1 hoisted variable.
3528 2008-06-17 Martin Baulig <martin@ximian.com>
3530 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3532 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3533 virtual property; check it in Emit().
3534 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3536 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3538 (Indexer.Define): Likewise.
3540 2008-06-17 Marek Safar <marek.safar@gmail.com>
3542 * convert.cs: Don't use IsInterface on type arguments.
3544 * delegate.cs: DelegateInvocation uses MethodInfo.
3546 * parameter.cs: Removed IsTypeParameter.
3548 * generic-mcs.cs: More missing stuff.
3550 2008-06-16 Martin Baulig <martin@ximian.com>
3553 (Modifiers.DEBUGGER_HIDDEN): New public const.
3556 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3559 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3560 (AbstractPropertyEventMethod): Likewise.
3561 (Constructor.Emit): Likewise.
3562 (SourceMethod.SetCompilerGenerated): Removed.
3564 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3568 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3569 if we're an `IteratorHost'.
3570 (AnonymousMethodMethod..ctor): Don't set
3571 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3574 2008-06-16 Marek Safar <marek.safar@gmail.com>
3576 * statement.cs: Clean-up foreach statements.
3578 2008-06-12 Marek Safar <marek.safar@gmail.com>
3580 * class.cs: Stop using public method which should not exist
3581 (MethodBuilder.SetGenericMethodSignature).
3583 2008-06-11 Martin Baulig <martin@ximian.com>
3586 (Location.LookupFile): Add `CompilationUnit' argument; when given
3587 a relative file name, make it relative to the directory the .cs
3588 file is located in instead of using the current directory.
3590 2008-06-11 Martin Baulig <martin@ximian.com>
3593 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3594 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3595 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3596 (SourceMethod.SetCompilerGenerated): Likewise.
3598 2008-06-11 Marek Safar <marek.safar@gmail.com>
3600 * codegen.cs, driver: Only write symbol file when it's asked for.
3602 2008-06-11 Marek Safar <marek.safar@gmail.com>
3604 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3606 2008-06-10 Martin Baulig <martin@ximian.com>
3608 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3610 2008-06-09 Marek Safar <marek.safar@gmail.com>
3612 A fix for bug #316290
3613 * expression.cs: Include decimal operators in predefined table.
3615 * parameters.cs: More readonlyness.
3617 2008-06-09 Marek Safar <marek.safar@gmail.com>
3619 A fix for bug #397213
3620 * cs-parser.jay: One more missing current_local_parameters reset.
3622 2008-06-09 Marek Safar <marek.safar@gmail.com>
3624 A fix for bug #396633
3625 * class.cs: Host backing field in partial container.
3627 2008-06-09 Marek Safar <marek.safar@gmail.com>
3629 A fix for bug #397068
3630 * expression.cs: Check both operand types when predefined operator is used.
3632 2008-06-05 Martin Baulig <martin@ximian.com>
3634 Merged the `debugger-kahalo' branch.
3637 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3638 we're an iterator method.
3639 (SourceMethod): Reflect latest symbol writer changes;
3640 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3641 now `start_row' and `end_row'.
3642 (Constructor.Emit): Fix the logic whether to emit symbol information.
3644 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3648 (CompilationUnit): New public class; derives from `SourceFile'.
3649 (SourceFileEntry.DefineSymbolInfo): New public method.
3650 (SourceFileEntry.SetChecksum): New public method.
3651 (Location): Encode hidden line numbers by using `column == 255';
3652 the .ctor now accepts `column == -1' to mark a hidden line number.
3653 (Location.Hidden): New public property.
3654 (Location.CheckPoint): Add `CompilationUnit'.
3655 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3656 (Location.Push): Add `CompilationUnit compile_unit' argument.
3657 (Location.CompilationUnit): New public property.
3660 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3662 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3664 * driver.cs: `SourceFile' -> `CompilationUnit'.
3666 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3668 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3670 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3674 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3675 new symbol writer API to also pass the file.
3677 2008-06-05 Marek Safar <marek.safar@gmail.com>
3679 * statement.cs: Emit catch variable assignment using variable expression.
3681 2008-06-05 Marek Safar <marek.safar@gmail.com>
3683 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3684 with other variable types.
3686 2008-06-04 Marek Safar <marek.safar@gmail.com>
3688 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3689 GetLength method emit, it breaks resolve rules.
3691 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3692 Marek Safar <marek.safar@gmail.com>
3694 A fix for bug #395542
3695 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3698 2008-06-02 Marek Safar <marek.safar@gmail.com>
3700 A fix for bug #395287
3701 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
3703 2008-05-31 Marek Safar <marek.safar@gmail.com>
3705 A fix for bug #395845
3706 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
3707 non-nullable parameter type.
3709 2008-05-31 Marek Safar <marek.safar@gmail.com>
3711 * class.cs: Handle contructor initializer as a statement in top-level block.
3713 2008-05-30 Marek Safar <marek.safar@gmail.com>
3715 * attribute.cs: Don't mix old and new corlib types when emitting corlib
3716 security attributes.
3718 2008-05-24 Marek Safar <marek.safar@gmail.com>
3720 * ecore.cs, expression.cs: Small IVariable refactoring.
3722 2008-05-22 Marek Safar <marek.safar@gmail.com>
3724 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
3726 2008-05-21 Marek Safar <marek.safar@gmail.com>
3728 * cs-parser.jay: Removed redundant catch type check.
3730 2008-05-21 Marek Safar <marek.safar@gmail.com>
3732 A fix for bug #390372
3733 * nullable.cs: Set correct return type.
3735 2008-05-21 Marek Safar <marek.safar@gmail.com>
3737 A fix for bug #391062
3738 * typemanager.cs: Fixed crash when comparing null types.
3740 2008-05-21 Marek Safar <marek.safar@gmail.com>
3742 A fix for bug #391871
3743 * cs-parser.jay: Better error handling for invalid catch type.
3745 2008-05-20 Marek Safar <marek.safar@gmail.com>
3747 A fix for bug #392155
3748 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
3750 2008-05-15 Marek Safar <marek.safar@gmail.com>
3752 A fix for bug #390666
3753 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
3756 2008-05-15 Marek Safar <marek.safar@gmail.com>
3758 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
3761 2008-05-13 Marek Safar <marek.safar@gmail.com>
3763 A fix for bug #389625
3764 * delegate.cs, generic.cs: Some progress on method group return type
3767 2008-05-13 Marek Safar <marek.safar@gmail.com>
3769 A fix for bug #378419
3770 * namespace.cs: Inspect also parent namespaces not only namespace entries.
3772 2008-05-12 Marek Safar <marek.safar@gmail.com>
3774 * class.cs (Constructor): Added IsCompilerGenerated.
3776 2008-05-12 Marek Safar <marek.safar@gmail.com>
3778 * expression.cs: Enum binary operators can accept non-enum operand only when
3779 is implicitly convertible to underlying type.
3781 2008-05-12 Marek Safar <marek.safar@gmail.com>
3783 A fix for bug #389272
3784 * support.cs: Workaround System.InvalidOperationException for enums.
3786 2008-05-12 Marek Safar <marek.safar@gmail.com>
3788 A fix for bug #389073
3789 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
3791 2008-05-10 Marek Safar <marek.safar@gmail.com>
3793 * driver.cs: Split Parse.
3795 * location.cs (LookupFile): Uses string.Empty.
3797 2008-05-07 Marek Safar <marek.safar@gmail.com>
3799 * expression.cs, parameter.cs: Small ParameterReference clean up.
3801 2008-05-07 Marek Safar <marek.safar@gmail.com>
3803 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
3804 hack. Fixes #387502.
3806 2008-05-06 Martin Baulig <martin@ximian.com>
3808 * class.cs (Constructor.Emit): Fix the logic whether to emit
3811 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
3814 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
3815 InvalidOperationException when the iterator is before the start or
3818 2008-05-06 Marek Safar <marek.safar@gmail.com>
3820 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
3821 when left is nullable type.
3823 2008-05-06 Marek Safar <marek.safar@gmail.com>
3825 A fix for bug #386628
3826 * expression.cs (LocalVariableReference): Continue in resolving when
3827 variable is not assigned.
3829 2008-05-05 Marek Safar <marek.safar@gmail.com>
3831 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
3832 nullable operations.
3834 2008-05-04 Marek Safar <marek.safar@gmail.com>
3836 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
3837 it saves many redundant temporary variables for nullable operations.
3839 2008-05-03 Marek Safar <marek.safar@gmail.com>
3841 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
3843 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
3846 * nullable.cs: Constant coalescing operator optimizations.
3848 2008-05-03 Marek Safar <marek.safar@gmail.com>
3850 * constant.cs: Use unsigned conversion for values which are unsigned only.
3852 2008-05-03 Marek Safar <marek.safar@gmail.com>
3854 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
3855 coalescing operator as it should be.
3857 2008-05-02 Marek Safar <marek.safar@gmail.com>
3859 A fix for bug #371016
3860 * expression.cs: All predefined delegate operators require implicit method
3863 2008-05-02 Marek Safar <marek.safar@gmail.com>
3865 * constant.cs: Emit long constant as uint when fits the range.
3867 * convert.cs, expression.cs: Fixed few unsafe conversions.
3869 2008-05-02 Marek Safar <marek.safar@gmail.com>
3871 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
3873 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
3876 * convert.cs (ImplicitNumericConversion): Don't modify the type of
3878 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
3880 2008-05-01 Marek Safar <marek.safar@gmail.com>
3882 * constant.cs, literal.cs: IsLiteral property for error reporting.
3884 * ecore.cs, expression.cs: Implemented Property expression.
3886 2008-05-01 Marek Safar <marek.safar@gmail.com>
3888 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
3890 * nullable.cs: Implemented nullable coalescing null operator.
3892 * ecore.cs, expression.cs: Expression trees work.
3894 2008-05-01 Marek Safar <marek.safar@gmail.com>
3896 * ecore.cs: CreateExpressionTree is finally abstract.
3898 * expression.cs, linq.cs: Updated.
3900 2008-05-01 Marek Safar <marek.safar@gmail.com>
3902 * expression.cs, ecore.cs: Block base access expression inside expression
3905 2008-05-01 Marek Safar <marek.safar@gmail.com>
3907 A fix for bug #385058
3908 * expression.cs: User-defined operator implementations always take
3909 precedence over predefined operator implementations.
3911 2008-04-30 Marek Safar <marek.safar@gmail.com>
3913 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
3914 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
3915 expression tree conversions.
3917 2008-04-30 Marek Safar <marek.safar@gmail.com>
3919 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
3920 operators method details to Operator class.
3922 2008-04-30 Marek Safar <marek.safar@gmail.com>
3924 * anonymous.cs: Pass unsafe flags to anonymous container.
3926 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
3927 inside expression tree.
3929 2008-04-29 Martin Baulig <martin@ximian.com>
3931 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
3932 (Tokenizer.PopPosition): Also restore the `line'.
3934 2008-04-29 Marek Safar <marek.safar@gmail.com>
3936 * delegate.cs: Implemented Invoke expression.
3938 2008-04-29 Marek Safar <marek.safar@gmail.com>
3940 * expression.cs: Fixed equality reference comparison regression.
3942 2008-04-29 Marek Safar <marek.safar@gmail.com>
3944 * ecore.cs: Clean up EmptyCast hack.
3946 * expression.cs, nullable.cs: Implemented enum binary and unary operations
3947 using correct conversion rules. Also fixes #383993.
3949 2008-04-28 Martin Baulig <martin@ximian.com>
3951 * class.cs (Constructor.Emit): Don't emit debugging information
3952 for generated default .ctor's.
3954 2008-04-28 Marek Safar <marek.safar@gmail.com>
3956 * convert.cs: Empty-cast ushort to int conversion.
3958 2008-04-28 Marek Safar <marek.safar@gmail.com>
3960 A fix for bug #384191
3961 * ecore.cs, expression.cs: Fixed expression cloning.
3963 2008-04-28 Marek Safar <marek.safar@gmail.com>
3965 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
3967 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
3969 Fix #381559, test-638.cs, test-639.cs
3970 * assign.cs (CompoundAssign.Helper): New wrapper.
3971 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
3973 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
3974 Pass unconverted expressions to the params array creation expression.
3975 (FieldExpr.EmitAssign): Don't special-case StringConcat.
3976 (PropertyExpr.EmitAssign): Likewise.
3977 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
3978 element if it is of kind CompoundAssign.Helper.
3979 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
3980 first before anything else.
3981 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
3982 (ArrayAccess.LoadArrayAndArguments): Simplify.
3984 2008-04-27 Marek Safar <marek.safar@gmail.com>
3986 * expression.cs: Fixed cloning of typeof(void).
3988 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
3990 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
3991 (Assign.Emit): Likewise. Move it to ...
3992 (CompoundAssign.DoResolve): ... here and ...
3993 (CompoundAssign.Emit): ... here.
3994 (EventAddOrRemove): New helper to handle += and -= on events, and
3995 avoid the use of BinaryDelegates.
3996 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
3997 (EventExpr.EmitAddOrRemove): Improve.
3998 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4000 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4001 create VarExprs for 'foo.bar.var'.
4002 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4003 is a highly inappropriate name for its functionality.
4005 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4007 Simplify handling of multiple assignments
4008 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4010 (SimpleAssign): New. Class to be used for normal assignments.
4011 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4012 * expression.cs, parameter.cs, statement.cs: Likewise.
4014 2008-04-25 Marek Safar <marek.safar@gmail.com>
4016 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4017 for incompatible underlying types, more to come, uff.
4019 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4022 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4023 Handle 'leave_copy'.
4025 2008-04-25 Marek Safar <marek.safar@gmail.com>
4027 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4029 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4031 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4032 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4033 * statement.cs (While, Do, For): Allow test to have side effects.
4034 (For.DoEmit): Always emit InitStatement.
4037 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4038 Always create SideEffectConstant.
4039 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4040 of type EnumConstant.
4042 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4043 Handle 'right' being SideEffectConstant of type 'bool'.
4045 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4046 Use left.EmitBranchable instead of open coding it, so as to
4047 improve optimization opportunities.
4049 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4051 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4053 (Expression.EmitSideEffect): Document.
4055 2008-04-23 Marek Safar <marek.safar@gmail.com>
4057 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4059 2008-04-23 Marek Safar <marek.safar@gmail.com>
4061 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4063 2008-04-23 Marek Safar <marek.safar@gmail.com>
4065 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4066 conversion to expression tree.
4068 2008-04-23 Marek Safar <marek.safar@gmail.com>
4070 * ecore.cs: Removed unused expression.
4072 2008-04-22 Marek Safar <marek.safar@gmail.com>
4074 * expression.cs: Implemented NegateChecked and New expressions.
4076 2008-04-22 Marek Safar <marek.safar@gmail.com>
4078 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4080 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4083 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4084 needing final 'ret' instruction.
4086 2008-04-22 Marek Safar <marek.safar@gmail.com>
4088 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4090 2008-04-21 Marek Safar <marek.safar@gmail.com>
4092 * expression.cs: Emit ldnull and not null expression as an instance argument
4093 of static method expression calls.
4095 2008-04-21 Marek Safar <marek.safar@gmail.com>
4097 A fix for bug #378200
4098 * expression.cs: Fixed crash when creating parameterless expression tree
4101 2008-04-21 Marek Safar <marek.safar@gmail.com>
4103 A fix for bug #375297
4104 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4107 2008-04-21 Marek Safar <marek.safar@gmail.com>
4109 A fix for bug #377596
4110 * decl.cs, class.cs: Emit delegate type argument attributes.
4112 2008-04-21 Marek Safar <marek.safar@gmail.com>
4114 A fix for bug #365314
4115 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4117 2008-04-21 Marek Safar <marek.safar@gmail.com>
4119 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4122 2008-04-21 Marek Safar <marek.safar@gmail.com>
4124 * generic.cs (TypeParameter): Removed redundant location.
4126 2008-04-19 Marek Safar <marek.safar@gmail.com>
4128 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4129 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4130 FullNamedExpression in all declaration type expression, statements will come
4133 2008-04-18 Marek Safar <marek.safar@gmail.com>
4135 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4136 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4138 2008-04-18 Marek Safar <marek.safar@gmail.com>
4140 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4143 2008-04-17 Marek Safar <marek.safar@gmail.com>
4145 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4148 2008-04-17 Marek Safar <marek.safar@gmail.com>
4150 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4154 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4156 Hook up 'EmitSideEffect'
4157 * constant.cs (Constant.EmitSideEffect): New.
4158 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4159 (SideEffectConstant.EmitSideEffect): New.
4160 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4161 unconditional branch in EmitBranchable.
4162 (FieldExpr.EmitBranchable): New.
4163 * expression.cs (Unary.EmitSideEffect): New.
4164 (Binary.EmitSideEffect): New.
4165 (VariableReference.EmitSideEffect): New. Do nothing.
4167 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4169 Introduce 'EmitSideEffect'
4170 * ecore.cs (Expression.EmitSideEffect): New.
4171 (TypeCast): Rename from EmptyCast.
4173 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4174 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4175 * convert.cs, nullable.cs: Update to changes.
4177 2008-04-16 Marek Safar <marek.safar@gmail.com>
4179 * class.cs, cs-parser.jay: Early check for base types expression.
4181 2008-04-16 Marek Safar <marek.safar@gmail.com>
4183 * decl.cs (MemberName): Declare PrettyName as obsolete.
4185 2008-04-16 Marek Safar <marek.safar@gmail.com>
4187 * namespace.cs: Use MemberName comparison.
4189 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4192 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4194 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4195 (MemberName.FullyQualifiedName): New. Provides the functionality
4196 that users assume FullName would have.
4197 * ecore.cs, namespace.cs: Update to changes.
4199 * statement.cs (Using.assign): Make into ExpressionStatement.
4200 (Using.EmitPreTryBody): Simplify.
4202 2008-04-16 Marek Safar <marek.safar@gmail.com>
4204 * report.cs: ColorFormat is protected.
4206 * rootcontext.cs: Unused fields clean-up.
4208 * namespace.cs: Made UsingEntry name private.
4210 2008-04-16 Marek Safar <marek.safar@gmail.com>
4212 * cs-tokenizer.cs, location.cs: Removed unused field.
4214 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4215 Raja R Harinath <harinath@hurrynot.org>
4218 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4219 (SideEffectConstant.side_effect): Rename from 'right'.
4220 (SideEffectConstant..ctor): Normalize 'side_effect'.
4221 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4222 value of this constant.
4223 * cfold.cs: Update to changes.
4225 2008-04-15 Marek Safar <marek.safar@gmail.com>
4227 * cs-paser.jay: Removed unused variable.
4229 * driver.cs: Made Compile instance method.
4231 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4233 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4235 2008-04-15 Marek Safar <marek.safar@gmail.com>
4237 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4239 2008-04-13 Jb Evain <jbevain@novell.com>
4241 * namespace.cs: update the System.Core fullname for 2.1
4242 * driver.cs: update the list of required assemblies for 2.1.
4243 Merged from the Moonlight 2 branch.
4245 2008-04-11 Marek Safar <marek.safar@gmail.com>
4247 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4248 types and user defined operators. User operators arguments has to be checked
4249 for null value before invocation, which also means no operator is called
4250 when any argument is not convertible to unwrapped nullable type.
4252 2008-04-09 Marek Safar <marek.safar@gmail.com>
4254 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4255 of Unary expressions to follow operator overloading rules precisely.
4256 Also fixes #321794, #323794
4258 2008-04-08 Marek Safar <marek.safar@gmail.com>
4260 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4263 2008-04-08 Marek Safar <marek.safar@gmail.com>
4265 * expression.cs, ecore.cs: Implemented MemberInit expression.
4267 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4269 Fix mono/tests/exception4.cs
4270 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4271 ec.NeedReturnLabel () rather emitting a 'nop'.
4273 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4275 (TryCatch.SomeCodeFollows): Likewise.
4276 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4277 for 'break', 'continue' and 'return' statements inside a try.
4278 We're fairly sure that the generated IL stream will have more
4279 instructions textually following the try.
4280 (FlowBranchingTryCatch): Likewise.
4282 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4283 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4286 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4287 wrapper -- forward everything to CollectionForeach.
4288 (CollectionForeach.NonDisposableWrapper): New.
4289 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4290 instead of a pop + branch to end.
4292 2008-04-07 Marek Safar <marek.safar@gmail.com>
4294 A fix for bug #377485
4295 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4296 Propagate location for extension method groups. Report conversion failure at
4299 2008-04-07 Marek Safar <marek.safar@gmail.com>
4301 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4302 ListInit and Field expressions.
4304 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4306 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4307 Since $PC is always -1 inside the body of MoveNext, the fault
4309 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4310 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4311 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4313 The denouement! Fix #324708
4314 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4315 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4316 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4317 'finally' inside the finally clause.
4319 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4320 inside an iterator. Don't emit the body of the 'finally' inside
4321 the finally clause yet.
4323 Use the ResumableStatement infrastructure for MoveNext ()
4324 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4325 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4326 'old_resume_points'. Move dispatcher upfront.
4327 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4328 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4329 in an enumerator. This encodes the main fix in this patch series
4330 -- we can only jump into the first instruction of a try from the
4331 outside, but we want to emit try/finally regions in iterators and
4332 resume in the middle of them.
4334 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4336 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4337 of NeedReturnLabel here.
4339 Introduce a common point for emitting try/finally to IL
4340 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4341 features of the various subclasses, which are now driven by ...
4342 (ExceptionStatement.EmitPreTryBody): ... this and ...
4343 (ExceptionStatement.EmitTryBody): ... this and the original
4345 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4346 Remove DoEmit and update to follow above protocol.
4348 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4349 of the dispatcher are the same, skip emitting the 'switch'.
4350 * iterator.cs (Iterator.EmitDispose): Update to changes.
4352 Clean up handling of 'using' statement
4353 * statement.cs (UsingTemporary): New. Carved out of ...
4354 (Using): ... this. Simplify drastically. Handle exactly
4356 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4357 or Using as appropriate. If there are multiple variable declared,
4358 create nested Using statements.
4359 (resource_acquisition): Kill.
4361 * statement.cs (ExceptionStatement.EmitForDispose): Use
4362 EmitFinallyBody, not EmitFinally.
4364 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4365 * iterator.cs: Update to changes.
4367 Start using the ResumableStatement infrastructure
4368 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4369 (ResumableStatement.EmitForDispose): New.
4370 (ExceptionStatement): Override them.
4371 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4372 EmitForDispose to create the body of the Dispose method. Don't
4375 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4376 * statement.cs (Toplevel.AddResumePoint): ... here.
4377 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4378 * flowanalysis.cs (FlowBranchingIterator): New.
4379 * codegen.cs (EmitContext): Update to changes.
4381 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4382 (Iterator.old_resume_points): Rename from 'resume_points'.
4383 (Iterator.MoveNextStatement): Remove unused class.
4385 New infrastructure for try/finally in iterators (still unused)
4386 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4387 (FlowBranchingToplevel.AddResumePoint): Hook into
4388 ToplevelBlock.AddResumePoint.
4389 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4390 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4391 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4392 resume points and assign program-counter values.
4393 (ExceptionBlock.AddResumePoint): Collect resume points for
4394 de-muxer at the top of try block.
4395 * iterators.cs (Yield.CheckContext): Simplify.
4396 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4398 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4400 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4401 argument to an ExitStatement.
4402 (FlowBranchingException): Refactor saved origins code.
4403 * statement.cs (ExitStatement): Update to cahges.
4404 * iterator.cs (YieldBreak): Likewise.
4406 * statement.cs (ResumableStatement): New. Common base class for
4407 YieldReturn and ExceptionStatement.
4408 (ExitStatement): New. Common base class for Return and YieldBreak.
4409 (Return): Update to changes.
4410 * iterator.cs (YieldBreak): Likewise.
4411 * lambda.cs (ContextualReturn): Likewise.
4414 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4415 emit a meaningful error message.
4417 Fix #324765, #319508
4418 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4419 (VariableInfo.SetAssigned): Set it.
4420 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4421 determine if CS0219 or CS0168 is appropriate. Don't use
4422 flow-analysis information.
4423 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4424 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4425 (EmitContext.EndFlowBranching): ... this.
4427 2008-04-03 Marek Safar <marek.safar@gmail.com>
4429 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4431 2008-04-03 Marek Safar <marek.safar@gmail.com>
4433 A fix for bug #376508
4434 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4435 ImplicitConversionExists.
4437 2008-04-03 Marek Safar <marek.safar@gmail.com>
4439 * expression.cs (Binary): Added remaining binary operators to expression
4442 * nullable.cs: Optimize shift with null argument.
4444 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4446 Fix minor IL regression
4447 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4448 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4449 * cs-parser.jay (try_statement): Update to changes.
4451 * statement.cs (TryFinally.need_exc_block): Delete.
4452 (TryFinally): Update to changes.
4454 Now all ExceptionStatements are unconditional
4455 * statement.cs (CollectionForeach.DisposableWrapper): New.
4456 Extract out the try/finally code into a new wrapper.
4457 (CollectionForeach.Resolve): Use it to simplify the code.
4459 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4461 Start at simplifying ExceptionStatement semantics a bit
4462 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4463 * cs-parser.jay (try_statement): Update to changes.
4464 (opt_catch_clauses): Remove.
4465 * flowanalysis.cs: Update to changes.
4466 (FlowBranching.BranchingType.TryCatch): New.
4467 (FlowBranchingTryCatch): New.
4469 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4470 (FlowBranching.CreateBranching): Update to changes.
4471 (FlowBranchingBlock.AddSibling): Add sanity check.
4472 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4475 * iterators.cs (Iterator.MarkFinally): Remove.
4476 * statement.cs (ExceptionStatement): Update to changes.
4478 Add support for skipping over finally blocks at runtime. First
4479 in a series to fix #324708
4480 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4481 (Iterator.EmitMoveNext): Initialize it.
4482 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4483 branch over the body of the 'finally' clause.
4485 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4487 Avoid lopsided use of Foo/DoFoo names
4488 * statement.cs (ExpressionStatement.EmitFinallyBody):
4489 Rename from EmitFinally.
4490 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4491 * iterator.cs: Update to changes.
4493 2008-04-02 Marek Safar <marek.safar@gmail.com>
4495 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4496 based on UserOperatorCall. More binary nullable operators clean up.
4498 2008-04-02 Martin Baulig <martin@ximian.com>
4500 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4502 2008-04-02 Marek Safar <marek.safar@gmail.com>
4504 * nullable.cs: Merge user and empty conversions when lifting expression
4507 * expression.cs (StringConcat): Implemented expression tree representation.
4509 2008-04-01 Marek Safar <marek.safar@gmail.com>
4511 * nullable.cs: When lifting null literal and a user operator exists, no call
4514 2008-04-01 Marek Safar <marek.safar@gmail.com>
4516 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4519 2008-04-01 Marek Safar <marek.safar@gmail.com>
4521 * nullable.cs, expression.cs: Use namespace instead heavily nested
4522 monster abstract class.
4524 2008-04-01 Marek Safar <marek.safar@gmail.com>
4526 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4527 lifting of null literal and user operators. Clean up of some temporary
4530 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4532 Fix #368224, test-629.cs
4533 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4534 if it crossed an unwind-protect boundary.
4535 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4536 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4537 inside an unwind-protected region.
4538 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4539 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4540 'leave' instead of a 'br' if unwind-protected.
4541 (Iterator.EmitYieldBreak): Likewise.
4543 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4545 * driver.cs: Only define versioninfo resources if no win32 resource
4548 2008-03-28 Marek Safar <marek.safar@gmail.com>
4550 A fix for bug #372375
4551 * convert.cs: Fixed boxing of nullable types.
4553 2008-03-28 Marek Safar <marek.safar@gmail.com>
4555 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4558 2008-03-28 Marek Safar <marek.safar@gmail.com>
4560 A fix for bug #374619
4561 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4563 2008-03-27 Marek Safar <marek.safar@gmail.com>
4565 * lambda.cs: Check return type only for invocation.
4567 2008-03-27 Marek Safar <marek.safar@gmail.com>
4569 A fix for bug #374214
4570 * ecore.cs: Correctly report argument type mismatch.
4572 2008-03-27 Marek Safar <marek.safar@gmail.com>
4574 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4575 and not rely on broken IsEnum.
4577 2008-03-27 Marek Safar <marek.safar@gmail.com>
4579 * nullable.cs: New file, extracted from generic.cs.
4581 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4583 2008-03-27 Marek Safar <marek.safar@gmail.com>
4585 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4586 predefined comparison operators and null literals.
4588 * report.cs: New warning ID.
4590 2008-03-25 Marek Safar <marek.safar@gmail.com>
4592 A fix for bug #370577
4593 * lambda.cs: Check return type too.
4595 2008-03-25 Marek Safar <marek.safar@gmail.com>
4597 A fix for bug #372846
4598 * class.cs: Automatic properties can be declared as unsafe.
4600 2008-03-20 Marek Safar <marek.safar@gmail.com>
4602 * location.cs: Use string based concatenation.
4604 * expression.cs: LiftedBinaryOperator is gmcs only.
4606 2008-03-20 Marek Safar <marek.safar@gmail.com>
4608 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4609 conversions rules and expression trees.
4611 2008-03-19 Marek Safar <marek.safar@gmail.com>
4613 * delegate.cs: Use extension method source as delegate target.
4615 2008-03-19 Marek Safar <marek.safar@gmail.com>
4617 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4618 binary operations to be purely based on binary operations and optimized
4619 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4620 and other ET refactoring.
4622 * typemanager.cs: Fixed warning.
4624 2008-03-17 Marek Safar <marek.safar@gmail.com>
4626 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4628 * symbolwriter.cs: Fixed.
4630 2008-03-17 Marek Safar <marek.safar@gmail.com>
4632 * anonymous.cs, driver.cs: Reset anonymous types counters.
4634 2008-03-17 Marek Safar <marek.safar@gmail.com>
4636 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4638 * class.cs: Use fullname for all type member definitions.
4640 2008-02-19 Martin Baulig <martin@ximian.com>
4643 (IMethodData.EmitExtraSymbolInfo): New interface method.
4644 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4645 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4646 interface method here as an empty public virtual method.
4649 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4650 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4651 CodeGen.SymbolWriter.SetRealMethodName().
4653 2008-02-18 Martin Baulig <martin@ximian.com>
4656 (ScopeInfo.EmitType): Override this and emit debugging
4657 information for captured variables.
4658 (RootScopeInfo.EmitType): Override this and emit symbol
4659 information for a captured `this'.
4661 2008-02-15 Martin Baulig <martin@ximian.com>
4663 * iterators.cs: Emit debugging info.
4666 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4667 (EmitContext.OmitDebuggingInfo): New public property.
4670 (While): Override Emit() and don't emit symbol info there; do it
4671 inside DoEmit() instead.
4672 (Block.Emit): Omit symbol information while emitting the scope
4673 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4675 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4676 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4677 .ctor to make `IsIterator' work.
4679 2008-03-14 Martin Baulig <martin@ximian.com>
4681 * symbolwriter.cs: Added the new symbol writer function from the
4682 debugger's `terrania' branch; temporarily enclose them inside
4683 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4686 2008-03-14 Martin Baulig <martin@ximian.com>
4689 (SymbolWriter): Make this a public static class.
4692 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4693 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4695 2008-03-14 Marek Safar <marek.safar@gmail.com>
4697 A fix for bug #370577
4698 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4701 2008-03-14 Marek Safar <marek.safar@gmail.com>
4703 * typemanager.cs (CSharpName): Made 250 times faster.
4705 2008-03-13 Marek Safar <marek.safar@gmail.com>
4707 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
4709 2008-03-12 Marek Safar <marek.safar@gmail.com>
4711 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
4712 crash when predefined field does not exist.
4714 2008-03-12 Marek Safar <marek.safar@gmail.com>
4716 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
4718 2008-03-12 Marek Safar <marek.safar@gmail.com>
4720 * class.cs (FixedField): Don't crash when contructors are missing.
4722 2008-03-11 Marek Safar <marek.safar@gmail.com>
4724 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
4725 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
4726 check internal types accessibility for internal and external types.
4727 Replaced EnumToUnderlying by GetEnumUnderlyingType.
4729 2008-03-11 Marek Safar <marek.safar@gmail.com>
4731 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
4732 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
4733 attribute.cs, statement: Use corect instance of predefined types (work
4734 related to #364674).
4736 2008-03-07 Marek Safar <marek.safar@gmail.com>
4738 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
4740 2008-03-07 Marek Safar <marek.safar@gmail.com>
4742 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
4743 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
4744 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
4745 predefined types clean up, delayed predefined types members initialization
4746 (work related to #364674).
4748 2008-03-05 Marek Safar <marek.safar@gmail.com>
4750 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
4752 2008-03-05 Marek Safar <marek.safar@gmail.com>
4754 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
4755 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
4756 predefined types clean up (work related to #364674).
4758 2008-03-04 Marek Safar <marek.safar@gmail.com>
4760 * ecore.cs: Print an error message instead of throwing exception.
4762 2008-03-04 Marek Safar <marek.safar@gmail.com>
4764 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
4765 expression.cs, statement.cs: Unififed null literal representation.
4767 2008-03-03 Marek Safar <marek.safar@gmail.com>
4769 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
4770 expression.cs: Refactored binary operators resolve phase and improved speed.
4771 The nullable code is still missing and won't work correctly, more fixes
4774 It also fixes #323726, #324312, #324248, and many other unreported issues.
4776 2008-02-29 Zoltan Varga <vargaz@gmail.com>
4778 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
4781 2008-02-27 Marek Safar <marek.safar@gmail.com>
4783 * ecore.cs: Clean-up and split BetterConversion.
4785 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
4788 * enum.cs (EnumMember.Value): Only access 'value' if
4789 ResolveValue says it's ok.
4790 (EnumMember.DoResolveValue): Don't set prev_member.value.
4791 (Enum.GetDefinition): Reverse arguments of Equals --
4792 EnumMember.Value can return 'null'.
4794 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
4796 2008-02-22 Marek Safar <marek.safar@gmail.com>
4798 * generic.cs, expression.cs: More ongoing work on expression trees.
4800 2008-02-21 Marek Safar <marek.safar@gmail.com>
4802 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
4803 handle missing matches when mutiple operators exist.
4805 2008-02-20 Marek Safar <marek.safar@gmail.com>
4807 A fix for bug #363218
4808 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
4811 2008-02-20 Marek Safar <marek.safar@gmail.com>
4813 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
4814 update. This time to deal correctly with SideEffectConstant expression used
4815 as an argument for another constant folding.
4817 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
4819 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
4822 2008-02-19 Marek Safar <marek.safar@gmail.com>
4824 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
4826 2008-02-19 Marek Safar <marek.safar@gmail.com>
4828 A fix for bug #328136
4829 * expression.cs: Do not fold immediately LogicalAnd operators when the left
4830 side is a false constant, because we still need to evaluate the right-hand
4833 * statement.cs (If): Emit two types of boolean constants (simple constant,
4834 side-effect constant).
4836 2008-02-19 Marek Safar <marek.safar@gmail.com>
4838 * constant.cs (SideEffectConstant): Don't emit boolean constant.
4840 * expression.cs: Fold immediately LogicalAnd operators when both sides are
4843 2008-02-18 Marek Safar <marek.safar@gmail.com>
4845 A fix for bug #361457
4846 * ecore.cs (IsApplicable): Params methods have lower priority.
4848 * support.cs: Return correct parameter modifier for params types.
4850 2008-02-18 Marek Safar <marek.safar@gmail.com>
4852 * generic.cs (TypeParameter): Cache attribute target name.
4854 * support.cs: Removed unused variable.
4856 * typemanager.cs: Removed debugging leftover.
4858 * ecore.cs: Use local type instead of a property;
4860 * class.cs (VerifyMembers): Consider also parent to test whether type member
4863 * expression.cs (FullMethodDesc): Removed.
4865 * attribute.cs (IsValidArgumentType): Made static.
4867 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
4869 Cleanup to be more readable.
4870 * Makefile (GMCS_PROFILE): Remove.
4871 (COMPILER_NAME): New helper.
4873 2008-02-15 Miguel de Icaza <miguel@novell.com>
4875 * cs-tokenizer.cs: if a conditional expression happens inside a
4876 (...) this also means that we do not need to de-ambiguate between
4877 an parenthesized expression and a cast.
4881 * constant.cs (SideEffectConstant): a constant value that happens
4882 to have a side effect.
4884 Fixes the build regressions introduced by the fix for #359789
4886 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
4888 * expression.cs (Conditional.Emit): when emitting the ternary
4889 operator, use local variables to generate code verifiable code.
4891 The verifier cannot infer that the type on stack before the
4892 stloc.0 is executed is of type ParentB. This happens because the
4893 stack merge algorithm uses only parent types when deciding which
4894 is the common type. This is described in Part III 1.8.1.3 of ECMA
4897 This code compiled with mcs is not verifiable under MS. The MS
4898 verifier picks the first common interface of Foo and Bar, which is
4899 wrong, but doesn't use a full join type of the 2 interfaces.
4901 CSC uses a clever hack to compile such code in a verifiable
4902 way. It stores the intermediate values in a local variable with
4907 2008-02-14 Miguel de Icaza <miguel@novell.com>
4909 * expression.cs: Do not fold BitwiseAnd operators when the left
4910 side is a false constant, because we still need to evaluate the
4915 * support.cs: Instead of throwing an InternalErrorException when
4916 the position of the stream is outside the boundary of our buffer,
4917 reset the state of the reader, and restart the reading from the
4918 beginning of the file.
4920 2008-02-14 Marek Safar <marek.safar@gmail.com>
4922 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
4924 2008-02-14 Marek Safar <marek.safar@gmail.com>
4926 A fix for bug #361686
4927 * decl.cs: A protected types used inside a private class which parents
4928 derives from the protected class are accessible.
4930 2008-02-13 Marek Safar <marek.safar@gmail.com>
4932 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
4933 the parameterless constructor.
4935 2008-02-13 Marek Safar <marek.safar@gmail.com>
4937 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
4938 lookup methods to use standard member cache when doing member lookup.
4940 2008-02-12 Marek Safar <marek.safar@gmail.com>
4942 * driver.cs: Don't report full path for referenced module as assembly error.
4944 2008-02-12 Marek Safar <marek.safar@gmail.com>
4946 * Makefile: Fixed `qh' target to work on all machines.
4948 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
4949 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
4950 and HasElementType with TypeManager implementation.
4952 2008-02-08 Marek Safar <marek.safar@gmail.com>
4954 A fix for bugs #325134, #359749
4955 * expression.cs, ecore.cs: Try to resolve an extension method even if the
4956 first binds point to non-method member expression.
4958 2008-02-08 Marek Safar <marek.safar@gmail.com>
4960 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
4962 2008-02-08 Marek Safar <marek.safar@gmail.com>
4964 A fix for bugs #321394, #323028
4965 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
4966 Reworked naive IsAccessibleAs implementation to handle nested types.
4968 2008-02-05 Jb Evain <jbevain@novell.com>
4970 * class.cs: use generic type comparison for parameters
4973 2008-02-05 Marek Safar <marek.safar@gmail.com>
4975 A fix for bug #325372
4976 * class.cs: Use generic type comparison when testing method signatures.
4978 2008-02-05 Marek Safar <marek.safar@gmail.com>
4980 A fix for bug #357047
4981 * ecore.cs: Applied C# 3.0 changes to better conversion.
4983 2008-02-05 Marek Safar <marek.safar@gmail.com>
4985 A fix for bug #358374
4986 * cs-parser.jay: Correctly set modifiers for all constructor types.
4988 2008-02-04 Marek Safar <marek.safar@gmail.com>
4990 A fix for bug #355251
4991 * generic.cs: Added base class constraint based type inference.
4993 2008-02-01 Marek Safar <marek.safar@gmail.com>
4995 A fix for bug #357255
4996 * decl.cs: One more missing visibility check.
4998 2008-02-01 Marek Safar <marek.safar@gmail.com>
5000 * support.cs: Fixed broken return.
5002 2008-01-25 Marek Safar <marek.safar@gmail.com>
5004 * report.cs: Correctly reset warnings count after probing.
5006 2008-01-25 Martin Baulig <martin@ximian.com>
5009 (NamespaceEntry.SymbolFileID): Make this work again after
5010 MemberName.ToString() is gone.
5012 2008-01-25 Marek Safar <marek.safar@gmail.com>
5014 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5017 2008-01-25 Marek Safar <marek.safar@gmail.com>
5019 * generic.cs: Use full implicit conversion for type inference fixing.
5021 2008-01-24 Marek Safar <marek.safar@gmail.com>
5023 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5024 Fixed user operator conversions.
5026 2008-01-24 Marek Safar <marek.safar@gmail.com>
5028 * generic.cs: Do nullable type to null comparison optimization during
5031 2008-01-24 Marek Safar <marek.safar@gmail.com>
5033 A fix for bug #355163
5034 * generic.cs: Enabled l-value resolve on nullable expressions.
5036 2008-01-24 Marek Safar <marek.safar@gmail.com>
5038 A fix for bug #353986
5039 * class.cs: Ingore static ctors with parameters for any further checks.
5041 2008-01-24 Marek Safar <marek.safar@gmail.com>
5043 A fix for bug #354310
5044 * namespace.cs: Removed redundant check.
5046 2008-01-24 Marek Safar <marek.safar@gmail.com>
5048 A fix for bug #354928
5049 * expression.cs: ElementInitializers can be resolved only once.
5051 2008-01-24 Marek Safar <marek.safar@gmail.com>
5053 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5054 Condition expressions.
5056 2008-01-23 Marek Safar <marek.safar@gmail.com>
5058 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5060 2008-01-22 Marek Safar <marek.safar@gmail.com>
5062 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5065 * generic.cs: Implemented coalesce expression.
5067 2008-01-22 Marek Safar <marek.safar@gmail.com>
5069 A fix for bug #355145
5070 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5071 expression tree type inference.
5073 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5076 * expression.cs (Binary.IsUnsignedType): Fix typo.
5078 2008-01-22 Marek Safar <marek.safar@gmail.com>
5080 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5082 2008-01-22 Marek Safar <marek.safar@gmail.com>
5084 A fix for bug #355161
5085 * ecore.cs, expression.cs: Wider range of extension method supported
5088 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5090 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5091 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5094 2008-01-22 Marek Safar <marek.safar@gmail.com>
5096 A fix for bug #355148
5097 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5099 2008-01-22 Miguel de Icaza <miguel@novell.com>
5101 * expression.cs (CreateExpressionTree): Add support for or and
5102 logical or, and indent following the coding conventions.
5104 * typemanager.cs (LinqExpression): renamed from
5105 ExpressionTreeManager, for a shorter name.
5107 Use TypeManager.CoreLookupType to lookup types from our core
5108 assemblies and turn those into "Type" variables.
5110 Consumers that previously used "Namespace" and "Type" from this
5111 class should instead use the TypeExpression which is a type that
5112 is fully resolved (without involving the regular C# resolution
5115 This typically looks like this:
5117 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5118 new MemberAccess (texpr, name, type_arguments, loc)
5120 This avoids the problem in: #355178
5122 2008-01-21 Marek Safar <marek.safar@gmail.com>
5124 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5125 feature in parser only as we do in other cases.
5127 2008-01-21 Marek Safar <marek.safar@gmail.com>
5129 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5130 typemanager.cs: A refactoring of params arguments to reuse existing
5131 expressions (params -> array initializer) to emit params argument instead
5132 of specialized handling.
5133 It was required by expression tree implementation and it has other benefits
5134 as well, we now apply same optimization for params arguments as we do for
5137 2008-01-18 Marek Safar <marek.safar@gmail.com>
5139 A fix for bug #353526
5140 * generic.cs: A type inference of params arguments may not required any
5141 temporary array creation.
5143 2008-01-18 Marek Safar <marek.safar@gmail.com>
5145 A fix for bug #353534
5146 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5147 supported for delegates only.
5149 2008-01-18 Marek Safar <marek.safar@gmail.com>
5151 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5152 type for more than 1 candidates.
5154 2008-01-18 Marek Safar <marek.safar@gmail.com>
5156 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5159 2008-01-16 Marek Safar <marek.safar@gmail.com>
5161 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5162 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5163 operator) expressions.
5165 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5167 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5168 not accessed from the generated IL.
5170 2008-01-14 Marek Safar <marek.safar@gmail.com>
5172 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5173 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5174 statement.cs: The first expression tree implementation drop, mostly
5175 infrastructure work.
5177 2008-01-14 Marek Safar <marek.safar@gmail.com>
5179 * ecore.cs (IsNestedChild): Refactored.
5181 2008-01-11 Marek Safar <marek.safar@gmail.com>
5183 * lambda.cs: Don't use a cast on unknown expression statement.
5185 2008-01-10 Geoff Norton <gnorton@novell.com>
5187 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5190 2008-01-09 Marek Safar <marek.safar@gmail.com>
5192 * doc.cs: Report better /doc crash details.
5194 2008-01-09 Marek Safar <marek.safar@gmail.com>
5196 A fix for bug #352536
5197 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5199 2008-01-08 Marek Safar <marek.safar@gmail.com>
5201 A fix for bug #352287
5202 * ecore.cs, expression.cs: Do `this' access checking in all member access
5205 2008-01-08 Marek Safar <marek.safar@gmail.com>
5207 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5209 * report.cs: Reset message stacks.
5211 2008-01-08 Marek Safar <marek.safar@gmail.com>
5213 * generic.cs (InferInPhases): Correctly calculate params position.
5215 2008-01-08 Marek Safar <marek.safar@gmail.com>
5217 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5220 2008-01-07 Marek Safar <marek.safar@gmail.com>
5222 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5224 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5226 * driver.cs: Updated --help option.
5228 2008-01-07 Marek Safar <marek.safar@gmail.com>
5230 * generic.cs (InferParamsTypeArguments): Removed.
5231 (InferInPhases): Add params type inference.
5232 (LowerBoundInference): Fixed scoring mechanism.
5234 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5236 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5238 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5239 byte array for unsigned "baked" assemblies.
5241 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5243 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5244 array for assemblies that are not strongnamed.
5246 2008-01-04 Marek Safar <marek.safar@gmail.com>
5248 A fix for bug #351481
5249 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5250 declaring type for nested generic types.
5252 2008-01-04 Marek Safar <marek.safar@gmail.com>
5254 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5255 instead of ToString.
5257 2008-01-03 Marek Safar <marek.safar@gmail.com>
5259 A fix for bug #351047
5260 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5261 null and structs only when equality and inequality operators are defined
5262 either as an user-operators or predefined operators.
5264 2008-01-03 Marek Safar <marek.safar@gmail.com>
5266 A fix for bug #351047
5267 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5269 2008-01-03 Marek Safar <marek.safar@gmail.com>
5271 A fix for bug #351257
5272 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5274 2008-01-03 Marek Safar <marek.safar@gmail.com>
5276 A fix for bug #351157
5277 * class.cs (Using): Fixed yet another broken cloning.
5279 (Block): Put back more sensible default value for statements.
5281 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5283 * codegen.cs: Allow AssemblyVersion with only major version component.
5286 2007-12-29 Marek Safar <marek.safar@gmail.com>
5288 A fix for bug #324654
5289 * class.cs: Use FullName property as member name.
5291 2007-12-28 Marek Safar <marek.safar@gmail.com>
5293 A fix for bug #342117
5294 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5295 constructor constraint.
5297 2007-12-28 Marek Safar <marek.safar@gmail.com>
5299 A fix for bug #338273
5300 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5303 2007-12-28 Marek Safar <marek.safar@gmail.com>
5305 A fix for bug #350839
5306 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5308 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5310 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5313 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5315 * statement.cs: Changed some Hashtables to use HybridDictionaries
5316 instead. It was observed that some HashTables only contained a few
5317 items in the vast majority of cases. Since HybridDictionary is
5318 more efficient on small sets (<10 elements), "known_variables"
5319 from class ExplicitBlock as well as "labels" and "constants " from
5320 class Block were changed to HybridDictionaries.
5322 Atsai results: (56216kb->54987kb)
5324 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5327 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5329 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5332 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5334 * expression.cs: foreach loop to for loop, saved on allocation of
5335 enumerator (59333kb->59141kb)
5337 * statement.cs. Changed foreach loops to for loops, saved on
5338 allocation of enumerator (59141kb->59006kb)
5340 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5341 when constructed with no specified capacity. This was causing a
5342 few ArrayLists to allocate more memory than they would potentially
5343 need in the Block class and MemberCache class. Setting the
5344 ArrayLists to construct with a capacity of 1 saves some
5345 memory. (56216kb->55585kb)
5347 2007-12-27 Marek Safar <marek.safar@gmail.com>
5349 A fix for bug #347189 (2nd issue)
5350 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5353 2007-12-27 Miguel de Icaza <miguel@novell.com>
5355 * report.cs: Do not use colors if stdout and stderr are not a
5358 2007-12-27 Marek Safar <marek.safar@gmail.com>
5360 A fix for bug #346998
5361 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5364 2007-12-27 Marek Safar <marek.safar@gmail.com>
5366 A fix for bug #343465
5367 * class.cs: Explicit method name for nested types uses dots only.
5369 2007-12-27 Marek Safar <marek.safar@gmail.com>
5371 A fix for bug #343707
5372 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5374 2007-12-27 Marek Safar <marek.safar@gmail.com>
5376 * ecore.cs: Report type inference errors only when arguments count matches
5379 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5381 * expression.cs, report.cs: New warning.
5383 * typemanager.cs: Catch anonymous method type too.
5385 2007-12-23 Marek Safar <marek.safar@gmail.com>
5387 A fix for bug #346379
5388 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5390 2007-12-23 Marek Safar <marek.safar@gmail.com>
5392 A fix for bug #347359
5393 * expression.cs (Invocation): Don't resolve already resolved expression.
5395 2007-12-23 Marek Safar <marek.safar@gmail.com>
5397 A fix for bug #347189
5398 * class.cs (FixedField): Use non-dependent code only in the define phase.
5400 2007-12-23 Marek Safar <marek.safar@gmail.com>
5402 A fix for bug #348076
5403 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5405 2007-12-22 Marek Safar <marek.safar@gmail.com>
5407 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5408 discovered extension methods.
5410 2007-12-22 Marek Safar <marek.safar@gmail.com>
5412 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5415 2007-12-21 Miguel de Icaza <miguel@novell.com>
5417 * report.cs (ErrorMessage): Add support for using colors on
5418 terminals that support it.
5420 2007-12-21 Marek Safar <marek.safar@gmail.com>
5422 * ecore.cs: Use information about expanded params for error reporting.
5424 2007-12-21 Marek Safar <marek.safar@gmail.com>
5426 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5427 and logic for params overloads.
5429 2007-12-15 Miguel de Icaza <miguel@novell.com>
5431 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5432 as this is also created from the parser. Fixes #349034
5434 2007-12-12 Miguel de Icaza <miguel@novell.com>
5436 * statement.cs (Throw.CloneTo): it is valid to have empty
5437 expressions for throw.
5439 2007-12-03 Marek Safar <marek.safar@gmail.com>
5441 * cs-parser.jay: Set delegate constraint parsing region correctly.
5443 2007-12-03 Marek Safar <marek.safar@gmail.com>
5445 A fix for bug #345467
5446 * typemanager.cs (IsEqual): Compare generic parameters position only.
5448 2007-11-28 Marek Safar <marek.safar@gmail.com>
5450 * expression.cs (BaseAccess): Type arguments can be null.
5452 2007-11-27 Raja R Harinath <harinath@gmail.com>
5454 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5455 consistent even when an error has occured.
5456 (Switch.Resolve): Likewise.
5458 2007-11-22 Marek Safar <marek.safar@gmail.com>
5460 A fix for bug #334505
5461 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5464 2007-11-22 Marek Safar <marek.safar@gmail.com>
5466 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5467 refactorings required to resolve extension methods correctly when mixing
5468 generics and non-generics members.
5470 2007-11-20 Marek Safar <marek.safar@gmail.com>
5472 A fix for bug #342584
5473 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5476 2007-11-19 Marek Safar <marek.safar@gmail.com>
5478 A fix for bug #342512
5479 * delegate.cs: Use delegate argument expression when is available. Don't
5480 emit virtual call when class is sealed.
5482 2007-11-16 Marek Safar <marek.safar@gmail.com>
5484 A fix for bug #325423
5485 * assign.cs (FieldInitializer): Use resolved expression for emit.
5487 * class.cs: Print less confusing error message.
5489 2007-11-16 Marek Safar <marek.safar@gmail.com>
5491 * cs-tokenizer.cs: Removed GMCS ifdefs.
5493 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5496 * cs-parser.jay: Disabled nullable check.
5498 * generic-mcs: Copied more generic stuff.
5500 2007-11-16 Marek Safar <marek.safar@gmail.com>
5502 * gcs-parser.jay: Merged to cs-parser.jay.
5504 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5505 * *.csproj, *.sources: Updated to use only jay parser file.
5507 2007-11-16 Marek Safar <marek.safar@gmail.com>
5509 * gcs-parser.jay: Added nullable and default expression feature checks.
5511 2007-11-16 Marek Safar <marek.safar@gmail.com>
5513 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5514 it fixes many TODOs and hidden bugs.
5516 * expression: Removed duplicate error check.
5518 2007-11-15 Marek Safar <marek.safar@gmail.com>
5520 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5521 implicitly type local variable only when it is used in a declaration.
5523 2007-11-15 Marek Safar <marek.safar@gmail.com>
5525 * attribute.cs: Use CS0612 for empty strings.
5527 2007-11-14 Marek Safar <marek.safar@gmail.com>
5529 * lambda.cs, statement.cs: Contextual return may act as a statement.
5531 2007-11-14 Marek Safar <marek.safar@gmail.com>
5533 A fix for a regression cause by #324222
5534 * class.cs: Don't report unused even when it implements an interface.
5536 2007-11-13 Marek Safar <marek.safar@gmail.com>
5538 A fix for bug #341205
5539 * ecore.cs, expression.cs: Method group expression cannot do static
5540 method access with an instance reference check before overloading takes
5543 2007-11-13 Marek Safar <marek.safar@gmail.com>
5545 A fix for bug #325359
5546 * class.cs: Use predictable name for automatically generated property.
5548 2007-11-12 Marek Safar <marek.safar@gmail.com>
5550 A fix for bug #324996
5551 * expression.cs (Is): Handle case where D is nullable and T is not
5554 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5556 2007-11-12 Marek Safar <marek.safar@gmail.com>
5558 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5559 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5560 Flush small error reporting changes.
5562 2007-11-09 Marek Safar <marek.safar@gmail.com>
5564 A fix for bug #324996
5565 * expression.cs: Rewrote Is expression implementation to work with
5566 generics, nullable types, anonymous method. A const result expression
5567 uses existing infrastructure instead of custom not fully-featured one.
5569 2007-11-08 Marek Safar <marek.safar@gmail.com>
5571 A fix for bug #340202
5572 * class.cs: Consider generics for volatile field.
5574 2007-11-08 Marek Safar <marek.safar@gmail.com>
5576 A fix for bug #335594
5577 * expression.cs: Use conversion rules when handling string addition.
5579 2007-11-07 Marek Safar <marek.safar@gmail.com>
5581 A fix for bug #336651
5582 * expression.cs: Fixed a crash when probing is on.
5584 2007-11-07 Marek Safar <marek.safar@gmail.com>
5586 A fix for bug #324242
5587 * covert.cs: Added a conversion from any nullable-type with an
5588 underlying enum-type to the type System.Enum.
5590 2007-11-07 Marek Safar <marek.safar@gmail.com>
5592 A fix for bug #324222
5593 * class.cs: Report all non-used event fields.
5595 2007-11-07 Marek Safar <marek.safar@gmail.com>
5597 A fix for bug #325161
5598 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5599 qualifier for generic types.
5601 2007-11-07 Marek Safar <marek.safar@gmail.com>
5603 A fix for bug #322971
5604 * expression.cs, ecore.cs: Added intermediate result value check for
5607 2007-11-07 Marek Safar <marek.safar@gmail.com>
5609 A fix for bug #324754
5610 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5611 when it was requested.
5613 2007-11-07 Marek Safar <marek.safar@gmail.com>
5615 A fix for bug #325101
5616 * expression.cs: Do type not value comparison for `is' expression.
5618 2007-11-07 Marek Safar <marek.safar@gmail.com>
5620 A fix for bug #320236
5621 * convert.cs: Don't apply user conversion on underlying target type.
5623 2007-11-06 Marek Safar <marek.safar@gmail.com>
5625 * expression.cs: Don't use unresolved expression for error reporting.
5627 2007-11-06 Marek Safar <marek.safar@gmail.com>
5629 A fix for bugs #337712, #324490
5630 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5631 overloading resolution too.
5633 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5634 the process consistent and more robust.
5636 * expression.cs, linq.cs, report.cs: Update.
5638 2007-11-02 Marek Safar <marek.safar@gmail.com>
5640 A fix for bug #332909
5641 * attribute.cs: Resolve attributes in correct context using error
5644 * rootcontext.cs: Define Obsolete attribute members as core members.
5646 2007-11-02 Marek Safar <marek.safar@gmail.com>
5648 * statement.cs: Removed unused methods.
5650 2007-10-31 Wade Berrier <wberrier@novell.com>
5652 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5653 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5656 2007-10-31 Marek Safar <marek.safar@gmail.com>
5658 A fix for bug #338102
5659 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5660 methods registered as non-generics.
5662 2007-10-31 Marek Safar <marek.safar@gmail.com>
5664 A fix for bugs #337712, #324490
5665 * delegate.cs: Delegate covariance and contravariance is not allowed for
5668 2007-10-31 Marek Safar <marek.safar@gmail.com>
5670 A fix for bug #337719
5671 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5674 2007-10-30 Marek Safar <marek.safar@gmail.com>
5676 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5678 2007-10-29 Marek Safar <marek.safar@gmail.com>
5680 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5683 2007-10-29 Raja R Harinath <rharinath@novell.com>
5685 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5687 2007-10-29 Marek Safar <marek.safar@gmail.com>
5689 A fix for bug #334652
5690 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5691 extension methods when we have not found the best candidate in normal
5694 2007-10-27 Marek Safar <marek.safar@gmail.com>
5696 * AssemblyInfo.cs: Keep up-to-date.
5698 2007-10-27 Marek Safar <marek.safar@gmail.com>
5700 * Makefile: Fixed generics compiler name.
5702 2007-10-27 Marek Safar <marek.safar@gmail.com>
5704 * lambda.test: removed, lambda parsing is done differently.
5706 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
5708 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
5710 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
5712 2007-10-27 Marek Safar <marek.safar@gmail.com>
5714 * Makefile, *.sources : All C# compilers are in mcs folder.
5716 * *.cs: Use existing 2_1 define for smcs.
5718 2007-10-26 Marek Safar <marek.safar@gmail.com>
5720 A fix for bug #335847
5721 * assign.cs, expression.cs: Couple of changes to avoid creating a
5722 temporary variable for each object initializer assignment statement. It
5723 simplifies struct initialization too, otherwise two temporary variables
5725 Implemented optimization of redundant default element initializers.
5727 2007-10-25 Marek Safar <marek.safar@gmail.com>
5729 A fix for bug #336766
5730 * expression.cs (Class.CheckBase): Use generic name when method is
5733 2007-10-25 Marek Safar <marek.safar@gmail.com>
5735 A fix for bug #334737
5736 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
5737 variable and not variable argument for prepared copies.
5739 2007-10-24 Marek Safar <marek.safar@gmail.com>
5741 A fix for bug #325110
5742 * class.cs, expression.cs, attribute.cs: Use open generic method when
5743 checking conditional attribute.
5745 2007-10-24 Marek Safar <marek.safar@gmail.com>
5747 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
5748 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
5749 FeatureIsNotAvailable.
5751 2007-10-24 Marek Safar <marek.safar@gmail.com>
5753 ** C# 3.0 Partial methods
5755 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
5756 methods support. Because of member cache issue with generics only
5757 non-generics partial methods are fully supported.
5759 2007-10-23 Marek Safar <marek.safar@gmail.com>
5761 * class.cs, decl.cs: Rewrote member overloads check to cope with
5762 generics and to use member cache for member checking. It also improves
5763 performance and fixes remaining overloads issues.
5765 2007-10-20 Marek Safar <marek.safar@gmail.com>
5767 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
5768 roottypes.cs, typemanager.cs:
5770 A member cache creation logic changed to add members immediately and
5771 not rely on fallback. The member cache is now only prefered way
5772 how to access and find type declaration members. It saves 5 MB of memory
5773 during MWF compilation and makes code ready for more optimizations and
5774 clean-ups, it's also a pre-requirement for partial methods.
5776 2007-10-18 Raja R Harinath <harinath@gmail.com>
5778 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
5779 handling for generic parameters.
5781 2007-10-15 Marek Safar <marek.safar@gmail.com>
5783 * class.cs (FixedField): Removed redundant volatile check.
5785 2007-10-15 Marek Safar <marek.safar@gmail.com>
5787 * class.cs, decl.cs: Fixed overload members verification to do only one
5788 check per possible collision.
5790 2007-10-13 Marek Safar <marek.safar@gmail.com>
5792 A fix for bug #325478
5793 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
5794 and create only one disposable flags container.
5796 2007-10-12 Marek Safar <marek.safar@gmail.com>
5798 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
5799 * statement.cs (Fixed): Fixed variables cloning.
5801 2007-10-12 Marek Safar <marek.safar@gmail.com>
5803 A fix for bug #333342
5804 * class.cs (EventField): Don't mark value type event as synchronized.
5806 2007-10-12 Marek Safar <marek.safar@gmail.com>
5808 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
5809 inference to identify best candidate method correctly.
5810 (ProperyExpr): A range variable is read only and cannot be modified.
5812 2007-10-11 Marek Safar <marek.safar@gmail.com>
5814 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
5815 logic to identify best candidate method correctly.
5817 2007-10-11 Marek Safar <marek.safar@gmail.com>
5819 * location.cs (Equals, GetHashCode): Removed.
5821 2007-10-11 Marek Safar <marek.safar@gmail.com>
5823 * report.cs: Implemented message recorder. It is used mainly for lambda
5824 expressions to capture otherwise swallowed error messages.
5826 * anonymous.cs, lambda.cs.cs: Do full parameters check.
5828 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
5830 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
5832 * expression.cs (MemberAccess): Always report lookup failure.
5834 * location.cs: Implemented Equals, GetHashCode.
5836 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
5838 2007-10-10 Jb Evain <jbevain@novell.com>
5840 * codegen.cs: re-enable assembly version check.
5842 2007-10-09 Marek Safar <marek.safar@gmail.com>
5844 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
5847 * namespace.cs (UsingAlias): Do correct version check.
5849 2007-10-08 Marek Safar <marek.safar@gmail.com>
5851 * expresison.cs, ecore.cs: Issue extension method error message when
5854 * rootcontext.cs: Added ISO_2 compiler mode option.
5856 2007-10-08 Marek Safar <marek.safar@gmail.com>
5858 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
5861 2007-10-08 Marek Safar <marek.safar@gmail.com>
5863 * attribute.cs (GetString, GetBoolean): Work with both literal and
5866 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
5867 Moved method overload specific methods to MethodGroupExpr.
5869 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
5870 it should be less memory consuming.
5872 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
5874 * codegen.cs: remove the assembly version check until the buildbot is
5877 2007-10-07 Jb Evain <jbevain@novell.com>
5879 * attribute.cs (Attribute.GetString): if the value
5880 expression is a StringConstant, return its string value.
5882 2007-10-07 Jb Evain <jbevain@novell.com>
5884 * typemanager.cs: add `assembly_version_attribute_type`.
5885 * codegen.cs: on attribute emission, check that the
5886 AssemblyVersionAttribute doesn't overflow.
5888 2007-10-05 Marek Safar <marek.safar@gmail.com>
5890 A fix for bug #324677
5891 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
5892 parent container of a scope container with currently resolved one.
5894 2007-10-05 Marek Safar <marek.safar@gmail.com>
5896 A fix for bug #325534
5897 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
5900 2007-10-05 Marek Safar <marek.safar@gmail.com>
5902 A fix for bug #327504
5903 * class.cs (Operator.Define): Refactored implicit and explicit user
5904 operator conversion rules.
5906 2007-10-05 Marek Safar <marek.safar@gmail.com>
5908 A fix for bug #327520
5909 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
5911 2007-10-04 Marek Safar <marek.safar@gmail.com>
5913 A fix for bug #328022
5914 * class.cs (MethodData.Define): Use correct method to check whether
5915 a method implementents an accessor.
5917 2007-10-04 Marek Safar <marek.safar@gmail.com>
5919 A fix for bug #330069
5920 * statement.cs (Fixed.Resolve): Read the first array element only when
5921 an array is instantiated.
5923 2007-10-04 Marek Safar <marek.safar@gmail.com>
5925 * expression.cs, assign.cs, generics.cs: Print correct operator when
5926 compound assignment is used.
5928 2007-10-04 Marek Safar <marek.safar@gmail.com>
5930 A fix for bug #325841
5931 * expression.cs (ArrayAccess): Use full argument cloning only for
5932 string compound concatenation.
5934 2007-10-03 Marek Safar <marek.safar@gmail.com>
5936 A fix for bug #328774
5937 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
5939 (PropertyExpr.EmitAssign): Fixed string concatenation compound
5942 2007-10-03 Raja R Harinath <rharinath@novell.com>
5945 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
5946 Event accessibility checks here. Remove some bogus code that
5947 accidently made GenericMethods work.
5948 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
5950 2007-09-25 Marek Safar <marek.safar@gmail.com>
5952 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
5954 * statement.cs (Block): Refactored AddVariable to allow error handling
5957 * generic.cs: New stub.
5959 2007-09-23 Marek Safar <marek.safar@gmail.com>
5961 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
5964 2007-09-17 Marek Safar <marek.safar@gmail.com>
5966 * class.cs: Use partial container to record whether any partial part
5967 contains static field initializer and therefore default contructor has
5970 2007-09-14 Marek Safar <marek.safar@gmail.com>
5972 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
5973 mono-list when only one of two partial parts has defined accessibility
5976 2007-09-14 Marek Safar <marek.safar@gmail.com>
5978 A fix for bug #82845
5980 * class.cs (TypeContainer): Set correct resolve context for all field
5983 2007-09-13 Marek Safar <marek.safar@gmail.com>
5985 * assign.cs: Fixed a crash when field is resolved twice with an error.
5987 * codegen.cs: Changed InFieldInitializer to be flag.
5989 * anonymous.cs, ecore.cs, expression.cs: Update after
5990 IsInFieldInitializer rename.
5992 * const.cs: Removed unused parameter.
5994 * class.cs: Changed the way how we resolve and emit field initializers.
5995 The field initilizers have to have access to contructor block to emit
5996 compiler generated code.
5998 2007-09-13 Marek Safar <marek.safar@gmail.com>
6000 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6001 generics use TypeContainer instead.
6003 2007-09-12 Marek Safar <marek.safar@gmail.com>
6005 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6007 * lambda.cs (ResolveParameters): Use more powerful
6008 InflateGenericArgument.
6010 * parameters.cs: Better exception message.
6012 2007-09-10 Marek Safar <marek.safar@gmail.com>
6014 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6015 correct expression block type.
6017 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6019 * expression.cs (Invocation): Extracted method group resolve to
6022 2007-09-07 Marek Safar <marek.safar@gmail.com>
6024 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6025 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6027 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6028 generic extension methods.
6030 2007-09-06 Marek Safar <marek.safar@gmail.com>
6032 A fix for bug #82676 (Do I get it right now?)
6033 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6034 object before a standard conversion is applied.
6036 2007-09-06 Marek Safar <marek.safar@gmail.com>
6038 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6041 2007-09-05 Marek Safar <marek.safar@gmail.com>
6043 A fix for bug #82676
6044 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6045 non-generic interface types.
6047 2007-09-05 Marek Safar <marek.safar@gmail.com>
6049 A fix for bug #82690
6050 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6052 2007-09-05 Marek Safar <marek.safar@gmail.com>
6054 A fix for bug #82571
6055 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6056 modifier for container based methods.
6058 2007-09-05 Marek Safar <marek.safar@gmail.com>
6060 A fix for bug #82676
6061 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6062 any interface-type T means to any of interface type T.
6064 2007-09-04 Marek Safar <marek.safar@gmail.com>
6066 * namespace.cs: We have 2 versions of System.Core assembly.
6068 2007-09-04 Marek Safar <marek.safar@gmail.com>
6070 A fix for bug #82652
6071 * class.cs (Class.GetClassBases): Compare types and not expressions.
6073 2007-09-04 Marek Safar <marek.safar@gmail.com>
6075 A fix for bug #82620
6076 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6077 actually never worked before.
6078 (IndexerAccess): Emit prepared arguments before they are modified.
6080 2007-09-04 Marek Safar <marek.safar@gmail.com>
6082 A fix for bug #82563
6083 * assign.cs: Revert wrong fix.
6085 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6087 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6088 Instead of ldelema/stdind we have to use temporary variables to handle
6089 cases like String.Concat (params string[]).
6091 2007-08-31 Marek Safar <marek.safar@gmail.com>
6093 * class.cs: EmitAttributes to Emit rename.
6095 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6097 (MemberCore.HasClsCompliantAttribute): Don't depend on
6098 GetClsCompliantAttributeValue execution.
6100 2007-08-31 Marek Safar <marek.safar@gmail.com>
6102 * anonymous.cs: Use shorter type prefix.
6104 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6107 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6108 variables when probing is on.
6110 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6111 unresolved variables.
6112 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6113 handle transparent identifiers.
6115 2007-08-26 Marek Safar <marek.safar@gmail.com>
6117 * attribute.cs (IsClsCompliant): Add nullable types test.
6119 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6121 * doc.cs : catch other types of exception than XmlException to
6122 report CS1570. Fixed bug #82565.
6124 2007-08-23 Marek Safar <marek.safar@gmail.com>
6126 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6127 The number of delegate parameters has to match.
6128 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6131 2007-08-21 Marek Safar <marek.safar@gmail.com>
6133 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6134 to fix problem with private arguments.
6136 2007-08-20 Marek Safar <marek.safar@gmail.com>
6138 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6140 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6142 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6143 empty. Add cloning suport.
6145 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6147 2007-08-20 Marek Safar <marek.safar@gmail.com>
6149 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6150 to create EmptyCast. It handles EmptyConstantCast specialization for
6153 2007-08-18 Marek Safar <marek.safar@gmail.com>
6155 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6156 (EmitArrayArgument): One routine for array arguments.
6157 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6159 2007-08-17 Marek Safar <marek.safar@gmail.com>
6161 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6163 2007-08-17 Marek Safar <marek.safar@gmail.com>
6165 * anonymous.cs: MemberLookupFinal update.
6167 * class.cs (ConstructorInitializer): Is expression based.
6169 * delegate.cs: MethodGroupExpr update.
6171 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6173 (Error_MemberLookupFailed): Customizable error override.
6174 (MethodGroupExpr): Keep queried type for later usage.
6175 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6178 * expression.cs: Error_MemberLookupFailed refactoring.
6179 (New.DoResolve): Resolve as much as possible.
6180 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6181 customization for invalid member types.
6183 * statement.cs: MethodGroupExpr update.
6185 2007-08-16 Marek Safar <marek.safar@gmail.com>
6187 * modifier.cs (Check): Check all modifiers and not only accessibility
6190 2007-08-16 Marek Safar <marek.safar@gmail.com>
6192 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6193 type and not an expression.
6195 2007-08-16 Marek Safar <marek.safar@gmail.com>
6197 * statement.cs (Catch.Clone): Type and variable can be null.
6199 2007-08-16 Marek Safar <marek.safar@gmail.com>
6201 A fix for bug #81979
6202 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6203 I am really not sure whether this is the best fix.
6205 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6208 2007-08-14 Marek Safar <marek.safar@gmail.com>
6210 ** C# 3.0 Object and collection initializers (major re-write)
6212 * assign.cs (DoResolve): Initializers are not assign related.
6214 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6215 used during collection or object initialization.
6217 * expression.cs (Error_InvalidArguments): Add initializers specific
6218 messages. More will come later because it requires some general
6220 (New.DoResolve): Better error handling for unsafe types.
6221 (EmptyExpressionStatement): New class.
6222 (ElementInitializer): An object initializer expression.
6223 (CollectionElementInitializer): A collection initializer expression.
6224 (CollectionOrObjectInitializers): A block of object or collection
6226 (NewInitialize): New expression with element/object initializers.
6228 * statement.cs: Reverted object/collection initializer hacks.
6230 * typemanager.cs (CSharpName): Filter __arglist type.
6232 2007-08-09 Marek Safar <marek.safar@gmail.com>
6234 ** C# 3.0 Anonymous Types (update to the latest standard)
6236 * expression.cs (Binary.ResolveOperator): Threat all null based types
6238 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6239 (AnonymousTypeParameter): Updated.
6241 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6242 (AnonymousTypeClass): New anonymous type container.
6244 * class.cs (AddField): Return operation result.
6246 * generic.cs: Another empty TypeArguments overload.
6248 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6249 are stored at top of normal hierarchy.
6251 * typemanager.cs (CSharpName): Filter anonymous types.
6253 2007-08-09 Marek Safar <marek.safar@gmail.com>
6255 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6256 as single Concat call. How could we miss that :-(
6258 2007-08-08 Marek Safar <marek.safar@gmail.com>
6260 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6262 2007-08-07 Miguel de Icaza <miguel@novell.com>
6264 * expression.cs: Fix the previous commit, the creation of the
6265 arguments array list needs also to be conditional on the arguments
6268 * class.cs: Add a little bit of help to help narrow down problems.
6270 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6271 not try to copy in that case.
6273 * driver.cs: When building SMCS, include a new different set of
6274 default assemblies here. Do this here so we can control whether
6275 to include the default assemblies with /noconfig.
6277 2007-08-03 Marek Safar <marek.safar@gmail.com>
6279 A fix for bug #81979
6280 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6283 2007-08-03 Marek Safar <marek.safar@gmail.com>
6285 A fix for bug #82300
6287 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6288 we are in probing scope.
6290 2007-08-03 Marek Safar <marek.safar@gmail.com>
6292 A fix for bug #82301
6294 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6295 (Statement.CloneTo): Clone and not map children blocks.
6297 2007-08-03 Marek Safar <marek.safar@gmail.com>
6299 A fix for bug #82299
6301 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6304 * statement.cs (Statement.CloneTo): Clone variables before statements
6305 to allow remaping of local variables.
6307 2007-08-03 Marek Safar <marek.safar@gmail.com>
6309 A fix for bug #82296
6312 * report.cs: Log crash details for future clone problems.
6314 * statement.cs (Return.Clone): Don't clone non-existent expression.
6316 2007-08-03 Raja R Harinath <harinath@gmail.com>
6318 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6319 (Class.AddBasesForPart): Move CS0537 check here from ...
6320 * cs-parser.jay (class_declaration): ... here. Move calling of
6321 'AddBasesForPart' to ...
6322 (class_bases): ... here.
6323 (struct_declaration, interface_declaration): Update to changes.
6325 2007-08-02 Marek Safar <marek.safar@gmail.com>
6327 A fix for bug #81923
6329 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6330 conversion is allowed.
6332 2007-08-02 Marek Safar <marek.safar@gmail.com>
6334 A fix for bug #81564
6336 * ecore.cs (EventExpr): Add IsBase handling.
6338 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6341 2007-08-02 Raja R Harinath <harinath@gmail.com>
6343 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6344 * cs-parser.jay: Some whitespace cleanups.
6345 (current_delegate): New.
6347 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6348 a dummy code block, and use 'type_name' instead of 'member_name'.
6349 (interface_declaration, class_declaration): Likewise.
6350 (delegate_declaration): Likewise. Rearrange slightly and use
6352 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6353 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6355 2007-08-02 Marek Safar <marek.safar@gmail.com>
6357 A fix for bug #82039
6359 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6362 * typemanager.cs (CSharpName): Split to string overload.
6364 2007-08-02 Marek Safar <marek.safar@gmail.com>
6367 * report.cs: Updated warning CS0472.
6369 2007-08-01 Marek Safar <marek.safar@gmail.com>
6371 A fix for bug #82181
6373 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6375 2007-08-01 Marek Safar <marek.safar@gmail.com>
6377 A fix for bug #82277
6378 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6380 2007-08-01 Marek Safar <marek.safar@gmail.com>
6382 ** C# 3.0 Type Inference (major bits are working)
6384 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6385 (.ImplicitStandardConversionExists): Uses compatible.
6386 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6387 (.InferReturnType): New method.
6388 (.Compatible): Refactored.
6389 (.ResolveParameters): Uses factory to create resolved parameters.
6390 (.CompatibleMethod): Add probing mode support.
6391 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6392 clearly distinguish between 2 different operations.
6393 (LambdaMethod): Moved to lambda.cs.
6394 (AnonymousMethod): Removed unused fields and methods.
6395 (AnonymousDelegate): Simplified.
6397 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6399 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6401 * delegate.cs (Delegate): New mehods to reduce code duplication.
6402 (.GetConstructor): New method.
6403 (.GetInvokeMethod): New method.
6404 (DelegateCreation): Updated.
6406 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6408 (OverloadResolve): Made probing little bit faster.
6410 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6413 * generic.cs (TypeInferenceContext): Dummy implementation.
6415 * iterators.cs: Updated after Resolve/Define rename.
6417 * lambda.cs (LambdaExpression)
6418 (.ResolveParameters): Handles both type of arguments and type inference too.
6420 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6421 (InflateTypes): Updated.
6423 * support.cs (InflateTypes): Changed signature and updated.
6425 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6426 (MemberLookup_FindMembers): More MS tricks.
6427 (GetParameterData): Ditto.
6428 (GetDelegateParameters): Uses quick path for dynamic types.
6430 2007-08-01 Marek Safar <marek.safar@gmail.com>
6432 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6435 2007-07-31 Marek Safar <marek.safar@gmail.com>
6437 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6440 2007-07-26 Jb Evain <jbevain@novell.com>
6442 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6443 which takes a boolean 'report_errors', similar to the GetMethod.
6444 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6445 in .net 2.1, do not report errors here.
6447 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6448 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6449 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6452 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6453 of the type InternalsVisibleToAttribute before the first call
6454 to CoreLookupType which is allowed to fail (third boolean parameter
6455 to true). Because, during the resolution for a type that is not
6456 immediately found, we try to check if the type is not defined in
6457 a friend assembly, and to do so, we need the
6458 InternalVisibleToAttribute.
6460 2007-07-23 Miguel de Icaza <miguel@novell.com>
6462 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6463 feature that allows structs to be compared against null and inline
6464 the result as true or false.
6466 Notice that the same code is not permitted inside a generic block
6467 of code that would do:
6469 class Foo<T> where T : struct {
6476 It is only allowed if the type of T is not bound (no where
6477 clause). In my opinion, this CSC 2 behavior is broken but people
6478 seem to be using it (IronRuby does, a few bug reports on bugzilla
6479 have it and some people have complained about it).
6481 All of the users that depend on this behavior have code that is
6484 * report.cs (Warning, Error): make these take object arguments,
6485 not strings, as that allows us to take advantage of Format.
6487 2007-07-20 William Holmes <billholmes54@gmail.com>
6489 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6490 Left member variable for the Count.
6491 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6492 MemberName.CountTypeArguments to avoid a NRE.
6494 This code is contributed under the MIT X11 license
6496 2007-07-18 Marek Safar <marek.safar@gmail.com>
6498 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6500 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6502 * doc.cs : generic method arguments are written as ``x while generic
6503 type arguments are `x. Combined with the previous change, fixed bug
6506 2007-07-18 Raja R Harinath <rharinath@novell.com>
6509 * expression.cs (Binary.ResolveOperator): When converting
6510 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6512 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6514 * doc.cs : when T: or whatever x: is specified, it does not really
6515 check the doc comment's syntax correctness. Fixed bug #82006.
6517 2007-07-18 Marek Safar <marek.safar@gmail.com>
6519 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6520 LambdaExpression better.
6522 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6524 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6526 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6527 as it can be generated.
6529 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6532 * lambda.cs (LambdaExpression): Refactored to share same code with
6533 AnonymousMethodExpression.
6535 2007-07-17 Marek Safar <marek.safar@gmail.com>
6537 * anonymous.cs (MakeName): Include host name for easier debugging.
6538 (LambdaMethod): New class for lambda spcecific stuff.
6540 * attribute.cs: Set EmitContext return type.
6542 * class.cs: Set EmitContext return type.
6544 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6545 with null/void meaning.
6547 * iterators.cs (ContainerType): Implemented.
6549 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6551 * statement.cs (Return): Updated to lambda expressions.
6552 (Block.CloneTo): Parent can be null.
6554 2007-07-13 Marek Safar <marek.safar@gmail.com>
6556 A fix for bug #81917
6557 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6559 * class.cs (FixedField): Check whether field is in unsafe scope.
6561 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6562 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6564 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6567 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6569 2007-07-13 Marek Safar <marek.safar@gmail.com>
6571 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6572 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6575 2007-07-13 Marek Safar <marek.safar@gmail.com>
6577 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6579 2007-07-13 Marek Safar <marek.safar@gmail.com>
6581 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6582 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6584 * codegen.cs(EmitContext): Add ProbingMode flag.
6586 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6588 * driver.cs: For now set both warning values.
6590 * ecore.cs (SimpleName): Name is readonly.
6591 (MethodGroup.OverloadResolve): One quick path for probing.
6593 * expression.cs (Unary): Set Oper r/o.
6594 (Binary): Set Oper r/o.
6595 (ParameterReference): Set few instance variables as r/o.
6596 (ParameterReference.DoResolveBase): Don't capture aruments when
6598 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6599 (Arglist): arguments are private.
6600 (SizeOf): type is private and r/o.
6601 (MemberAccess): arguments are private.
6603 * report.cs: Enhanced reporting on/off capabilities.
6605 * lambda.cs: Uses ec.IsInProbingMode.
6606 (ContextualReturn): Derives from return.
6608 * rootcontext.cs: For now set both warning values.
6610 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6612 (Return.Resolve): Don't die immediately.
6613 (Block.Resolve): Speed-up probing.
6614 (Block.CloneTo): Clone only child blocks.
6616 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6618 * iterators.cs: reverted Miguel's latest change (r81925) as it
6619 breaks the build in System.
6621 2007-07-13 Miguel de Icaza <miguel@novell.com>
6623 * iterators.cs (Yield.CheckContext): Check for the iterator type
6624 also here as we can call into Yield even in codepaths that are not
6626 (MethodOrOperator is the only path that was checked).
6628 In addition to the standard check, use a more specific check for
6629 constructors to report a more verbose error.
6631 2007-07-12 Miguel de Icaza <miguel@novell.com>
6633 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6634 report the warning and continue
6636 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6637 values on the stack on the call to Emit. Use EmitStatement if
6638 possible, or using Emit + Pop if not possible. Fixes #82064
6640 2007-07-12 Raja R Harinath <rharinath@novell.com>
6642 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6643 avoid try...finally in some cases.
6645 2007-07-10 Marek Safar <marek.safar@gmail.com>
6647 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6649 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6650 instead of method. Re-use standard error handling.
6651 (ConstructorInitializer.Emit): Simplified.
6653 * delegate.cs: Updated after Invocation.EmitCall change.
6655 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6656 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6657 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6658 method and don't permanently changing input arguments.
6659 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6660 is resolved it has one of the candidates is the best one which is later
6661 used to emit. Removed a few unused method.
6662 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6664 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6665 (Binary.ResolveOperator): Ditto.
6666 (ConditionalLogicalOperator.DoResolve): Ditto.
6667 (Invocation): Uses method group.
6668 (Invocation.DoResolve): Simplified.
6669 (Invocation.EmitCall): Removed useless is_static.
6670 (Invocation.Emit): Delegate to method group.
6671 (Invocation.EmitStatement): Simplified.
6672 (New): Uses method group.
6673 (MemberAccess.DoResolve): Don't destroy original expression.
6675 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6677 2007-07-04 Marek Safar <marek.safar@gmail.com>
6679 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6682 * lambda.cs: Add custom error message type.
6684 2007-07-03 Marek Safar <marek.safar@gmail.com>
6686 * lambda.cs: Simplified little bit.
6688 * parameter.cs: Introduced ImplicitLambdaParameter.
6689 (Parameters.CreateFullyResolved): New factory instead of ctor.
6693 * delegate.cs: Updated parameter creation.
6695 2007-07-03 Marek Safar <marek.safar@gmail.com>
6697 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6700 * generic.cs: Synchronized with gmcs.
6702 2007-07-03 Marek Safar <marek.safar@gmail.com>
6704 * class.cs (Indexer): Check return type as soon as possible.
6706 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6709 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
6711 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
6713 * parameter.cs (Parameter): Use expression type when it is available.
6715 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
6716 method modifier for the first parameter only.
6718 2007-06-24 Marek Safar <marek.safar@gmail.com>
6720 A fix for bug #81938
6721 * typemanager.cs (ChangeType): Fixed couple of char conversions.
6723 * constant.cs: Tide up an exception message.
6725 2007-06-22 Marek Safar <marek.safar@gmail.com>
6727 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
6728 an uninitialized variable is used.
6730 * expression.cs (LocalVariableReference.DoResolve): Ditto.
6732 2007-06-22 Marek Safar <marek.safar@gmail.com>
6734 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
6735 not found error handling.
6737 * expression.cs (ArrayCreation): Removed redundant fields and little bit
6739 (ArrayCreation.ResolveArrayElement): To be ready to customization.
6740 (ArrayCreation.DoResolve): Simplified.
6741 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
6742 its own resolve process.
6743 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
6745 2007-06-20 Marek Safar <marek.safar@gmail.com>
6747 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
6750 2007-06-20 Marek Safar <marek.safar@gmail.com>
6752 * cs-tokenizer.cs: Removed var related stuff.
6754 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
6755 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
6756 a type and a keyword at same time.
6758 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
6761 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
6762 implicitly typed arrays, more changes will follow.
6764 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
6766 2007-06-19 Marek Safar <marek.safar@gmail.com>
6768 * ecore.cs (VarExpr): Removed Handled field.
6770 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
6771 build-in assign functionality.
6772 (ForEach.Resolve): Removed all implicitly typed local variable code and
6774 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
6775 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
6777 2007-06-18 Marek Safar <marek.safar@gmail.com>
6779 * assign.cs: Removed implicitly typed local variable check.
6781 * expression.cs (LocalVariableReference.DoResolve): Add check for self
6782 referencing implicitly typed local variable.
6783 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
6786 * statement.cs (Fixed): Removed unsupported implicitly typed local
6789 2007-06-15 Marek Safar <marek.safar@gmail.com>
6791 * decl.cs (MemberName): Moved all Unbound stuff to parser.
6793 2007-06-14 Marek Safar <marek.safar@gmail.com>
6795 A fix for bugs #81855 and #76274
6796 * attribute.cs (AttachTo): Always set owner for global attributes to
6799 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
6802 * cs-parser.jay: Assembly and module attributes must precede all other
6803 elements except using clauses and extern alias declarations.
6805 2007-06-13 Marek Safar <marek.safar@gmail.com>
6807 A fix for bug #81748
6809 * expression.cs: More checks for non ISO-1 features.
6811 2007-06-12 Marek Safar <marek.safar@gmail.com>
6813 A fix for bug #81807
6814 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
6815 present inside switch statement and it is required by nullable check.
6817 2007-06-12 Marek Safar <marek.safar@gmail.com>
6819 A fix for bug #81840
6820 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
6821 when type matching fails.
6823 * namespace.cs: Tiny error message change.
6825 2007-06-12 Marek Safar <marek.safar@gmail.com>
6827 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
6828 reporting. Added automatic property check.
6830 * class.cs: Updated after CheckAbstractAndExtern relocation.
6831 (AEventPropertyAccessor.GetSignatureForError): Customized.
6833 2007-06-11 Marek Safar <marek.safar@gmail.com>
6835 * class.cs (DefineBaseTypes): Base type can be undefined.
6837 * ecore.cs (TypeLookup): Minor refactoring.
6838 (DoResolveAsTypeStep): Removed redundant check.
6840 * namespace.cs (Lookup): Removed redundant check.
6842 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
6843 ResolveAsTypeTerminal step.
6844 (BootstrapCorlib_*): Simplified.
6845 (PopulateCoreType): Core types can be now external.
6847 2007-06-07 Marek Safar <marek.safar@gmail.com>
6849 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
6851 (InferTypeArguments): Infers anonymous expression type arguments.
6852 (Compatible): Split to Compatible and InferTypeArguments.
6854 * lambda.cs: Updated.
6856 2007-06-08 Marek Safar <marek.safar@gmail.com>
6858 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
6860 2007-06-07 Raja R Harinath <harinath@gmail.com>
6862 Fix #80477, cs0135-2.cs, cs0135-3.cs
6863 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
6864 names to the "known" variables list.
6865 (Block.CheckInvariantMeaningInBlock): Handle the fact the
6866 parameter names are also "known".
6867 (Block.CheckError136): Remove.
6868 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
6871 2007-06-07 Marek Safar <marek.safar@gmail.com>
6873 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
6875 2007-06-06 Marek Safar <marek.safar@gmail.com>
6877 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
6878 internal error not an user error.
6880 * expression.cs (IsApplicable): Refactored to make debugging easier.
6882 * support.cs: More tricks for non-mono runtimes.
6884 * typemanager.cs (CoreLookupType): Made public.
6885 (InitSystemCore): All linq specific stuff moved to linq.cs
6887 2007-06-05 Marek Safar <marek.safar@gmail.com>
6889 * typemanager.cs (CSharpSignature): One more missing build-in types
6891 More tricks for non-mono runtime.
6893 2007-06-05 Raja R Harinath <harinath@gmail.com>
6895 * statement.cs (Block.CheckError136_InParents): Remove.
6896 (Block.AddVariable): Use GetParameterInfo instead.
6897 (ToplevelBlock.ProcessArguments): Likewise.
6899 2007-06-04 Raja R Harinath <rharinath@novell.com>
6901 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
6903 (ToplevelBlock.GetParameterInfo): Split out of ...
6904 (ToplevelBlock.GetParameterRefernce): ... this.
6905 (ToplevelBlock.ParameterMap): Remove.
6906 * expression.cs (ParameterReference): Update to use
6907 ToplevelParameterInfo.
6909 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
6912 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
6913 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
6915 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
6916 (ToplevelBlock.ProcessParameters) ... here.
6917 (ToplevelBlock..ctor): Invoke it.
6919 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
6922 * statement.cs (IKnownVariable): New interface.
6923 (LocalInfo): Implement it.
6924 (ToplevelParameterInfo): New class.
6925 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
6926 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
6927 GetKnownVariableInfo.
6929 2007-06-03 Raja R Harinath <harinath@gmail.com>
6931 Partly speed up CS0136 error checks.
6932 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
6933 'recurse' parameter.
6934 (Block.DoCheckError136): Only check errors in parameters. Move
6935 local variable checks ...
6936 (Block.AddVariable): ... here, and ...
6937 (ToplevelBlock.ResolveMeta): ... here.
6939 2007-06-02 Raja R Harinath <harinath@gmail.com>
6941 * statement.cs (Block.IsChildOf): Remove.
6943 * statement.cs (Statement.Clone): Move special case code ...
6944 (Block.CloneTo): ... here.
6946 2007-05-29 Raja R Harinath <rharinath@novell.com>
6948 * statement.cs (ToplevelBlock.container): Remove field. It's
6949 redundant with 'Parent'.
6950 (ToplevelBlock.ContainerBlock): Remove accessor.
6951 (ToplevelBlock..ctor): Update to changes. Register anonymous
6952 child with parent here, ...
6953 * cs-parser.jay (end_anonymous): ... not here. Don't modify
6955 (start_anonymous): Don't save current_block.
6956 (top_current_block): Remove.
6958 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
6959 (Block.Resolve): Update to changes.
6960 (Block..ctor): Move setting of "correct" 'Toplevel'
6961 and 'Explicit' fields to ...
6962 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
6964 2007-05-27 Raja R Harinath <harinath@gmail.com>
6967 * statement.cs (Block.Implicit): Remove.
6968 (Block): Update to changes.
6969 * flowanalysis.cs: Likewise.
6971 Mildly speed up CheckInvariantMeaningInBlock
6972 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
6973 Recursively call AddKnownVariable to all enclosing blocks.
6974 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
6975 Remove recursive calls.
6976 (Block): Update to changes.
6978 New ExplicitBlock invariants
6979 * statement.cs (Block.Explicit): New field. It points to the
6980 immediately enclosing non-implicit block.
6981 (Block..ctor): Maintain the invariant.
6982 * cs-parser.jay: Take advantage of invariant.
6984 Introduce ExplicitBlock
6985 * statement.cs (ExplicitBlock): New.
6986 (ToplevelBlock): Derive from it.
6987 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
6989 (Block.Implicit): Update to changes.
6990 * cs-parser.jay: Update to changes.
6993 * codegen.cs (EmitContext.IsLastStatement): Remove.
6994 * statement.cs (Block.DoEmit): Update to changes.
6996 2007-05-25 Raja R Harinath <rharinath@novell.com>
6998 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
6999 modifying current_block directly.
7001 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7003 * class.cs: Implemented automatic properties (C# 3.0)
7004 Thanks to Marek for the help.
7006 2007-05-23 Raja R Harinath <rharinath@novell.com>
7008 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7009 variable as assigned, note also that all its components are
7011 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7013 2007-05-19 Marek Safar <marek.safar@gmail.com>
7015 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7016 member is marked as compiler generated.
7018 * decl.cs (MemberCore): Refactored ModFlags into property.
7020 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7021 (Check): Check only accessibility modifiers.
7023 2007-05-18 Raja R Harinath <rharinath@novell.com>
7025 Track all assignable slots in one bit array
7026 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7027 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7028 logic from VariableMap constructor here. Use the same 'offset'
7029 variable that's later used for computing offsets of local
7031 * flowanalysis.cs (UsageVector.parameters): Remove.
7032 (UsageVector): Update to changes.
7033 (VariableMap): Remove.
7035 Avoid creating ParameterMap in every block
7036 * statement.cs (Block.ParameterMap): Move ...
7037 (ToplevelBlock.ParameterMap): ... here.
7038 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7040 * flowanalysis.cs (FlowBranching.param_map): Remove.
7041 (FlowBranching.UsageVector): Update to changes.
7042 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7044 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7046 * expression.cs (ParameterReference): Distinguish between block
7047 where parameter was referenced and declared.
7049 2007-05-18 Marek Safar <marek.safar@gmail.com>
7051 * flowanalysis.cs, statement.cs: Put back improved error handling.
7053 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7057 Imporved object and collection initialization (C# 3.0).
7059 2007-05-15 Marek Safar <marek.safar@gmail.com>
7061 A fix for bug #81380
7062 * expression.cs (Is.DoResolve): Only value types have constant `is'
7065 2007-05-15 Raja R Harinath <rharinath@novell.com>
7067 * statement.cs (ToplevelBlock.child): Remove.
7069 2007-05-15 Raja R Harinath <harinath@gmail.com>
7071 Rationalize ResolveMeta: refactoring
7072 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7073 out constant handling code into ...
7074 (Block.DoResolveConstants): ... this.
7076 Rationalize ResolveMeta: kill local_map
7077 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7078 (Block.AssignableSlots): New.
7079 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7080 for locals -- move code from VariableMap here. Avoid unnecessary
7082 * flowanalysis.cs (FlowBranching.local_map): Remove.
7083 (FlowBranching..ctor): Use Block.AssignableSlots.
7084 (VariableMap): Remove unused constructors.
7086 2007-05-11 Raja R Harinath <rharinath@novell.com>
7088 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7090 2007-05-11 Marek Safar <marek.safar@gmail.com>
7092 * typemanager.cs (IsFriendAssembly): Should not be called for building
7095 2007-05-09 Marek Safar <marek.safar@gmail.com>
7097 * literal.cs (NullConstant): Print null in all cases.
7099 * expression.cs (Binary.ResolveOperator): Implemented delegate
7100 comparison based on C# 2.0 changes.
7102 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7104 This code is contributed under the MIT X11 license
7106 The following enables support for several C# 3.0 language features:
7108 * cs-tokenizer.cs: Added support for the "var" keyword.
7110 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7111 Added VarExpr class to facilitate type inferencing.
7113 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7114 to support anonymous types.
7116 * assign.cs: Added support for type inferencing and initialization.
7118 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7120 * expression.cs: Added implicit array support to ArrayCreation.
7121 Added 5 types and 1 interface:
7123 IInitializable Implementing classes can inject initializing
7124 statements after object instantiation.
7126 Initializer Stores data for object initialization.
7128 AnonymousType An expression for anonymous types.
7130 AnonymousTypeParameter Stores data about an anonymous type's field.
7132 NewInitialize An expression for object initialization.
7134 CollectionInitialize An expression for collection initialization.
7136 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7139 2007-05-06 Marek Safar <marek.safar@gmail.com>
7141 A fix for bug #81500
7142 * cs-tokenizer.cs: Add special handling for coalescing operator.
7144 2007-05-06 Marek Safar <marek.safar@gmail.com>
7146 A fix for bug #81529
7147 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7148 its value from base class until it is redefined.
7150 2007-05-02 Raja R Harinath <rharinath@novell.com>
7152 Fix regression in cs0631-3.cs
7153 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7154 fallback. Make error fallback catch more cases.
7156 2007-05-01 Miguel de Icaza <miguel@novell.com>
7158 * cs-parser.jay: Allow parameters in operator declarations to have
7161 2007-04-27 Miguel de Icaza <miguel@novell.com>
7163 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7166 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7167 inside the ContextualReturn, it does not have to be an
7168 ExpressionStatement.
7170 2007-04-24 Miguel de Icaza <miguel@novell.com>
7172 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7175 2007-04-23 Miguel de Icaza <miguel@novell.com>
7177 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7178 method in two methods: ResolveNoDefine and Resolve.
7180 ResolveNoDefine will stop just after ResolveTopBlock has been
7183 Resolve will then continue by creating a method and issuing the
7184 call to method.Define ().
7186 (AnonymousMethod): Split and implement the new Resolve and
7187 ResolveNoDefine as well.
7189 * lambda.cs (LambdaExpression): Split the anonymous method
7190 resolution code into a separate routine (CoreCompatibilityTest)
7191 from DoCompatibleTest.
7193 (LambdaExpression.TryBuild): New method, this method tries to
7194 build the LambdaExpression with the given set of types to be used
7195 as the types for the various parameters of the lambda expression.
7197 If the compilation succeed with the given types, the infered type
7198 of the Anonymous method is returned, otherwise null is returned.
7200 2007-04-23 Marek Safar <marek.safar@gmail.com>
7202 A fix for bug #81414
7203 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7205 2007-04-22 Miguel de Icaza <miguel@novell.com>
7207 * cs-tokenizer.cs: Change various identifiers here from the
7208 camelCasing to the recommended Linux-like style for instance
7209 variables from the Coding Guidelines.
7211 2007-04-19 Martin Baulig <martin@ximian.com>
7214 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7215 System.Enum to System.ValueType.
7217 2007-04-13 Martin Baulig <martin@ximian.com>
7219 Rewrote implicit reference conversions. We need to distinguish
7220 between implicit reference conversions (13.1.4) and implicit
7221 boxing conversions (13.1.5).
7223 According to the spec, there's an an implicit conversion
7224 "From a one-dimensional array-type S[] to IList<T> and base
7225 interfaces of this interface, provided there is an implicit
7226 reference conversion from S to T." Note that this does not
7227 include boxing conversions.
7230 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7231 (Convert.ImplicitReferenceConversion): Split into
7232 ImplicitReferenceConversionCore() and
7233 ImplicitBoxingConversionExist().
7234 (Convert.ImplicitReferenceConversionExists): Use the new
7235 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7237 2007-04-12 Martin Baulig <martin@ximian.com>
7239 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7240 `TypeManager.null_type' checks up to the top of the method.
7242 2007-04-11 Marek Safar <marek.safar@gmail.com>
7244 A fix for bug #81350
7245 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7248 2007-04-11 Martin Baulig <martin@ximian.com>
7250 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7251 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7252 to make this work for generic classes; fixes #79561.
7254 2007-04-11 Martin Baulig <martin@ximian.com>
7256 * expression.cs (As): Add support for nullable types; fixes #79371.
7258 2007-04-11 Martin Baulig <martin@ximian.com>
7260 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7261 `type.FullName' is null; fixes #80243.
7263 2007-04-11 Martin Baulig <martin@ximian.com>
7265 * expression.cs (Invocation.IsApplicable): Don't modify the method
7266 if type inference succeeded, but the method was not applicable.
7269 2007-04-10 Marek Safar <marek.safar@gmail.com>
7271 A fix for bug #81324
7272 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7273 internal and external namespaces containers.
7275 2007-04-10 Martin Baulig <martin@ximian.com>
7277 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7278 TypeManager.DropGenericMethodArguments() so we also call
7279 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7281 2007-04-10 Martin Baulig <martin@ximian.com>
7283 * iterators.cs (Iterator.CreateIterator): Don't crash if
7284 `method.ReturnType' is null. This happens if something went wrong
7285 while resolving that typ (we already reported an error in this case).
7287 2007-04-10 Martin Baulig <martin@ximian.com>
7289 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7290 generic interfaces; report the CS0144 directly.
7292 2007-04-10 Martin Baulig <martin@ximian.com>
7294 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7295 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7297 2007-04-10 Martin Baulig <martin@ximian.com>
7299 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7301 2007-04-09 Raja R Harinath <rharinath@novell.com>
7304 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7305 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7308 * statement.cs (For.Resolve): If resolution fails, use
7311 2007-04-08 Marek Safar <marek.safar@gmail.com>
7313 * anonymous.cs (MakeName): Make faster and zero-based.
7314 (VerifyExplicitParameterCompatibility): Back to mode where generic
7315 parameter is ignored.
7316 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7318 * class.cs (EmitType): Method can emit another new method.
7320 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7322 * driver.cs: Updated.
7324 * lambda.cs: Reuse predefined empty parameters.
7326 * parameter.cs: Updated
7328 * support.cs: Implemented InflateTypes.
7330 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7331 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7333 2007-04-03 Martin Baulig <martin@ximian.com>
7337 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7338 version of TypeManager.IsOverride() which also works with generic
7341 2007-04-03 Martin Baulig <martin@ximian.com>
7346 (Convert.ExplicitReferenceConversion): We need to cast when
7347 converting from IList<T> to S[].
7349 2007-04-01 Marek Safar <marek.safar@gmail.com>
7351 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7354 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7356 2007-03-31 Marek Safar <marek.safar@gmail.com>
7358 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7359 argument and return type inferring.
7361 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7362 (ReturnType): Turned to property.
7364 * statement.cs (Return): Implemented return type inferring.
7366 * support.cs (ReflectionParameters): Use local types if possible.
7368 2007-03-30 Raja R Harinath <rharinath@novell.com>
7370 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7371 (FlowBranching.UsageVector): Update to changes.
7373 Prepare to kill 'Reachability'
7374 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7375 argument of constructor.
7377 2007-03-29 Raja R Harinath <rharinath@novell.com>
7379 Prepare to kill 'Reachability'
7380 * flowanalysis.cs (UsageVector.is_unreachable): New.
7381 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7382 'reachability', and verify they're consistent.
7385 * expression.cs (New.EmitStatement): Handle type parameters here too.
7387 2007-03-29 Martin Baulig <martin@ximian.com>
7392 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7393 CompilerGeneratedClass.
7394 (ScopeInfo.EmitScopeInstance): Make this protected.
7395 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7396 `ec.CurrentAnonymousMethod.Scope == Scope'.
7398 * statement.cs (Block.ScopeInfo): Make this a property.
7400 2007-03-27 Raja R Harinath <harinath@gmail.com>
7402 Prepare to kill 'Reachability'
7403 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7404 (FlowBranching.UsageVector.Reachability): Remove property.
7405 (FlowBranching.UsageVector.IsUnreachable): New property.
7406 (FlowBranching.UsageVector.ResetBarrier): New.
7407 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7408 * codegen.cs, statement.cs: Update to changes.
7410 2007-03-27 Martin Baulig <martin@ximian.com>
7415 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7418 2007-03-26 Raja R Harinath <rharinath@novell.com>
7420 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7421 instead of TriState. Remove all mention of TriState.
7423 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7424 replaced by a boolean. Add boolean 'is_unreachable' field, check
7425 and maintain invariants.
7427 2007-03-25 Marek Safar <marek.safar@gmail.com>
7429 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7431 2007-03-25 Marek Safar <marek.safar@gmail.com>
7433 * expression.cs: Stop using obsolete 2.0 opcodes.
7435 2007-03-25 Marek Safar <marek.safar@gmail.com>
7437 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7438 one of the latests Martin's fixes.
7440 2007-03-23 Miguel de Icaza <miguel@novell.com>
7442 * expression.cs: On BigEndian systems, swap the bytes, temporary
7443 solution until we get a new bitconverter class.
7445 2007-03-23 Martin Baulig <martin@ximian.com>
7449 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7450 "Method" and "Method`1". Normally, a cache lookup is done on the
7451 "Method" form (ie. without the generic arity), but this one makes
7452 lookups on the full form work as well.
7454 2007-03-22 Raja R Harinath <rharinath@novell.com>
7456 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7459 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7461 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7462 ordered_member_list, to TypeBuilder to store members to be defined
7463 in the order they were parsed in.
7464 - ordered_explicit_member_list contains all properties indexers
7465 and methods that are defined as explicit implementation of an
7466 interface or base class.
7467 - ordered_member_list contains all properties indexers and methods
7468 that are not defined as explicit implementation of an interface
7471 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7472 functionality in these removed classes has been replaced with
7473 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7474 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7476 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7477 to CheckForDuplications inside GetMethod and SetMethod Define Method
7478 to handle method property and indexer name conflicts.
7482 All code is contributed under the MIT/X11 license.
7484 2007-03-20 Martin Baulig <martin@ximian.com>
7486 * class.cs (TypeContainer.Interfaces): Removed; they're now
7487 included in `TypeContainer.Types'.
7489 2007-03-20 Martin Baulig <martin@ximian.com>
7491 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7493 * class.cs (TypeContainer.CreateType): New public method. This is
7494 now called before DefineType() to create the TypeBuilders.
7495 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7496 has already been created by CreateType().
7497 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7498 don't resolve our base classes here; this has been moved into
7499 DefineBaseTypes(). We're now called from CreateType().
7500 (TypeContainer.DefineBaseTypes): New private method; resolve our
7501 base classes here. We're now called from DefineType().
7504 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7505 our types first to create all the TypeBuilders. After that, call
7506 TypeContainer.DefineType() on all the types which'll resolve their
7507 base classes and setup the resolve order.
7509 2007-03-20 Martin Baulig <martin@ximian.com>
7511 * class.cs (TypeContainer.Enums): Removed; they're now included in
7512 `TypeContainer.Types'.
7514 2007-03-20 Martin Baulig <martin@ximian.com>
7517 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7518 (TypeContainer.DoResolveMembers): Call DefineType() on our
7519 `compiler_generated' classes; moved here from DefineNestedTypes().
7522 (RootContext.ResolveTree): Call ResolveMembers() on all
7523 TypeContainer's in the `type_container_resolve_order'.
7525 2007-03-19 Marek Safar <marek.safar@gmail.com>
7527 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7529 2007-03-17 Marek Safar <marek.safar@gmail.com>
7531 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7532 implementation flags.
7534 2007-03-17 Marek Safar <marek.safar@gmail.com>
7536 * class.cs: More optimizations for type parameters.
7538 2007-03-15 Marek Safar <marek.safar@gmail.com>
7540 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7542 * ecore.cs, parameter.cs: More common code for both corlibs.
7544 * typemanager.cs (IsGenericMethod): Simplified.
7546 2007-03-15 Raja R Harinath <rharinath@novell.com>
7548 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7550 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7552 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7553 unconditionally. Simplify explanation.
7554 (Try.Resolve, Using.Resolve): Likewise.
7556 2007-03-15 Martin Baulig <martin@ximian.com>
7560 * decl.cs (DeclSpace): If we're a partial class, use our
7561 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7563 2007-03-15 Raja R Harinath <rharinath@novell.com>
7565 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7567 (FlowBranching.UsageVector): Update to changes.
7568 (FlowBranching.MergeSiblings): Likewise.
7569 * statement.cs: Likewise.
7571 2007-03-15 Martin Baulig <martin@ximian.com>
7576 (MemberCache): Added a special .ctor for type parameters.
7579 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7582 2007-03-09 Martin Baulig <martin@ximian.com>
7584 * enum.cs (Enum): Make this a TypeContainer.
7585 (EnumMember): Derive from `Const'.
7588 (Const.DoResolveValue): New protected virtual method; move most of
7589 the functionality of ResolveValue() here so we can override it in
7591 (Const.CreateConstantReference): Make this virtual.
7593 * class.cs (Kind): Add `Kind.Enum'.
7594 (TypeContainer.Emit): Don't emit the enums here; they're already
7595 in the `RootContext.typecontainer_resolve_order'.
7597 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7598 here; they're already in the `typecontainer_resolve_order'.
7600 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7601 TypeManager.DropGenericTypeArguments().
7604 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7605 (TypeManager.IsEnumType): Likewise.
7606 (TypeManager.EnumToUnderlying): Likewise.
7607 (TypeManager.IsEqual): Add support for enums.
7609 2007-03-12 Raja R Harinath <rharinath@novell.com>
7611 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7612 DefaultParameterValueAttribute to be undefined, say if System.dll
7615 2007-03-11 Marek Safar <marek.safar@gmail.com>
7617 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7620 2007-03-10 Marek Safar <marek.safar@gmail.com>
7622 * class.cs, parameter.cs: Unified parameters verification.
7624 2007-03-08 Martin Baulig <martin@ximian.com>
7626 * cs-parser.jay (constructor_header): Pass the location to the
7627 newly created TopLevelBlock.
7629 2007-03-07 Martin Baulig <martin@ximian.com>
7631 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7633 2007-03-06 Miguel de Icaza <miguel@novell.com>
7635 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7636 with the changes from David, fixes the build.
7638 2007-03-05 David Mitchell <dmitchell@logos.com>
7640 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7641 and its base interfaces to a one-dimensional array type S[],
7642 provided there is an implicit or explicit reference conversion
7645 2007-03-03 Marek Safar <marek.safar@gmail.com>
7647 * cs-tokenizer.cs: Implemented basic linq grammar.
7649 * driver.cs: Set linq lang version on demand.
7651 2007-02-26 Marek Safar <marek.safar@gmail.com>
7653 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7655 2007-02-25 Marek Safar <marek.safar@gmail.com>
7657 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7660 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7662 Check property and event extern attributes.
7664 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7667 2007-02-24 Marek Safar <marek.safar@gmail.com>
7669 A fix for bug #80407
7670 * ecore.cs: Don't report ambiguity error when methods have same parent.
7672 2007-02-23 Marek Safar <marek.safar@gmail.com>
7674 A fix for bug #80878
7675 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7677 2007-02-22 Marek Safar <marek.safar@gmail.com>
7679 * attribute.cs: Enable ExtensionAttribute presence test.
7681 2007-02-22 Marek Safar <marek.safar@gmail.com>
7683 * class.cs: Warn about missing GetHashCode only when Equals is override.
7685 * decl.cs: Check accessibility of type arguments.
7687 * typemanager.cs: Correctly report nullable array.
7689 2007-02-20 Marek Safar <marek.safar@gmail.com>
7691 * class.cs, report.cs: Capture more details when things go wrong.
7693 2007-02-20 Marek Safar <marek.safar@gmail.com>
7695 A fix for bug #80650
7696 * cs-parser.jay: Anonymous container starts at constructor declaration
7697 and not at block beginning because it has to be usable in constructor
7700 * statement.cs: Use context location and not block one for error reporting.
7702 2007-02-18 Marek Safar <marek.safar@gmail.com>
7704 A fix for bug #78712
7705 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
7708 2007-02-18 Marek Safar <marek.safar@gmail.com>
7710 A fix for bug #80493 by Atsushi Enomoto
7711 * cs-parser.jay: Ignore invalid attribute target.
7713 2007-02-18 Marek Safar <marek.safar@gmail.com>
7715 * cs-tokenizer.cs: Ignore '\0' as white space character.
7717 2007-02-17 Miguel de Icaza <miguel@novell.com>
7719 * cs-parser.jay: Add support for lambda expressions to the mcs
7722 * lambda.cs: Only clone when we are probing, not on the final call
7723 (Compatible is the final call).
7725 * statement.cs (CloneContext): Introduce class to provide block
7726 remapping during clone.
7728 All statements Clone themselves now.
7730 (Clone): special handling for blocks, when we clone a block, we
7731 register the block inside this routine, as children of the block
7732 might trigger a lookup.
7734 * expression.cs: Add support for CloneContext in all expressions.
7736 2007-02-17 Marek Safar <marek.safar@gmail.com>
7738 A fix for bug #80493
7739 * statement.cs: Report ambiguous warning when interfaces are not related.
7741 2007-02-15 Marek Safar <marek.safar@gmail.com>
7743 C# 3.0 extension methods.
7745 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
7746 cannot be used directly.
7748 * class.cs (Class.Emit): Emit extension attribute if any class method
7749 is extension method.
7750 (Method.Define): Add basic extension method validation conditions.
7751 (Method.Emit): Emit extension attribute for method.
7753 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
7754 extension method exists. Currently we follow same approach as Microsoft
7755 does, emit even if a method or a class are private but this can change
7758 * cs-parser.jay: Add handling of `this' keyword in method parameters
7761 * decl.cs (DeclSpace.IsStaticClass): New property.
7762 (MemberCache.FindExtensionMethods): Looks for extension methods with
7763 defined name and extension type.
7765 * doc.cs: Updated after OverloadResolve changes.
7767 * driver.cs: Add new soft reference to System.Core.dll.
7769 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
7770 (ExtensionMethodGroupExpr): Represents group of extension methods.
7772 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
7773 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
7774 to MethodGroupExpr and made non-static for easier customization.
7775 (Invocation.DoResolve): Add extension method lookup when no standard
7777 (MemberAccess.DoResolve): Try extension methods if no member exists.
7779 * modifiers.cs: Add METHOD_EXTENSION modifier.
7781 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
7782 as well as candidate extension type.
7783 (ComputeNamespaces): When assembly constains extension methods registers
7785 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
7786 extension method lookup.
7787 (Namespace.LookupExtensionMethod): Looks for extension method in this
7789 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
7790 find a method which matches name and extensionType.
7792 * parameter.cs (Parameter): Add This modifer.
7793 (HasExtensionMethodModifier): New property.
7794 (Resolve): Add extension parameter check.
7795 (ModFlags): turned to property to exclude this modifier as it is not real
7797 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
7799 * support.cs (ParameterData): Add ExtensionMethodType.
7800 (ReflectionParameters): Implemented ExtensionMethodType interface property.
7802 * typemanager.cs: Add type and ctor extension attribute type.
7804 2007-02-15 Miguel de Icaza <miguel@novell.com>
7806 * report.cs (DisableErrors, EnableErrors): used to prevent error
7807 output when we are "trying" to compile various methods with
7810 * ecore.cs (Expression): Add Clone method that calls the virtual
7811 CloneTo method. The current CloneTo method in Expression throws
7812 an exception so we can track down all the places where this must
7813 be implemented (not using abstract, because that would be a lot of
7814 up-front-work before we can start testing the implementation
7817 Important: we only need Clone capabilities for expressions created
7818 by the parser, as the expressions we will be cloning are
7819 expressions in the pre-resolved state. This vastly simplifies
7822 (SimpleName): Add CloneTo that does nothing.
7823 (EmptyCast): Add CloneTo.
7825 * expression.cs (Binary): Implement CloneTo.
7826 (Invocation.IsApplicable): Store the current ec in
7827 EmitContext.TempEc and restore it on return. This is used so we
7828 do not have to sprinkle hundres of methods with an extra
7829 EmitContext, we know that the only user is the lambda expression
7830 ImplicitConversionExists code.
7832 (Argument): Add Cloning capabilities.
7833 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
7834 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
7835 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
7836 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
7837 IndexerAccess): Add Clone capability.
7839 (LocalVariableReference, This): TODO: needs cloned Block mapping.
7841 (Argument): Add cloning capability.
7843 * assign.cs (Assign): Implement CloneTo.
7845 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
7847 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
7848 version by calling Convert with the EmitContext (that we are
7849 currently storing in ec, this is not great, but will do for now,
7850 to avoid passing EmitContext parameters to hundreds of functions
7851 that do not need them now).
7853 (SetExpression): Remove, it is not needed.
7855 (ContextualReturn): Implement CloneTo.
7857 * statement.cs (Statement): Implement cloning infrastructure,
7858 similar to expressions.
7860 (Block): Partial implementation of Clone for statements.
7862 (Return): Implement clone.
7864 * constant.cs (Constant.CloneTo): New method, does nothing.
7866 * codegen.cs (TempEc): Add a static EmitContext as a temporary
7867 solution, until we decide how to exactly do this.
7869 2007-02-14 Marek Safar <marek.safar@gmail.com>
7871 A fix for bug #80493
7872 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
7873 a property is override we need to use second accessor.
7875 2007-02-13 Marek Safar <marek.safar@gmail.com>
7877 A fix for bug #80418
7878 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
7881 2007-02-13 Marek Safar <marek.safar@gmail.com>
7883 Another fix for bug #80749
7884 * pending.cs: Abstract class has priority over interfaces.
7886 2007-02-13 Marek Safar <marek.safar@gmail.com>
7888 Another fix for bug #80749
7889 * pending.cs: Abstract class has priority over interfaces.
7891 2007-02-13 Marek Safar <marek.safar@gmail.com>
7893 Another fix for bug #80749
7894 * pending.cs: Abstract class has priority over interfaces.
7896 2007-02-13 Marek Safar <marek.safar@gmail.com>
7898 Another fix for bug #80749
7899 * pending.cs: Abstract class has priority over interfaces.
7901 2007-02-13 Marek Safar <marek.safar@gmail.com>
7903 * class.cs Better error message.
7905 * driver.cs: Add shorter versions of -optimize option.
7907 2007-02-13 Martin Baulig <martin@ximian.com>
7909 * class.cs (Constructor.Emit): Check the return value of
7910 ec.ResolveTopBlock() and return on error.
7912 2007-02-13 Raja R Harinath <rharinath@novell.com>
7914 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
7915 message to fix error message regression.
7917 2007-02-12 Marek Safar <marek.safar@gmail.com>
7919 * delegate.cs: Delegate creation expression cannot be of Nullable type.
7921 2007-02-12 Marek Safar <marek.safar@gmail.com>
7923 A fix for bug #80749
7924 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
7925 its parent container.
7927 * class.cs (DefineFieldInitializers): Each initializer can has different
7930 * const.cs: Updated.
7932 2007-02-11 Miguel de Icaza <miguel@novell.com>
7934 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
7935 now all the heavy lifting to check that embedded statements or
7936 expressions have the right form is done in the ContextualReturn.
7938 (ContextualReturn): New class.
7940 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
7941 method that can be invoked to report 201, so we do not replicate
7944 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
7946 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
7947 treating tabs as spaces.
7949 2007-02-09 Marek Safar <marek.safar@gmail.com>
7951 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
7952 * assign.cs: Use full implicit conversion for right side check.
7954 2007-02-09 Marek Safar <marek.safar@gmail.com>
7956 * statement.cs (Switch): Switch over boolean type is not standardized.
7958 2007-02-08 Marek Safar <marek.safar@gmail.com>
7960 A fix for bug #80755
7961 * decl.cs (FindBaseEvent): Don't use method cache for events.
7963 2007-02-07 Marek Safar <marek.safar@gmail.com>
7965 * cs-parser.jay: Better syntax error handling.
7967 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
7968 instead of underlying type value.
7970 2007-02-06 Marek Safar <marek.safar@gmail.com>
7972 * driver.cs: Check define identifier before is registered.
7974 * namespace.cs: Use existing error message.
7976 * report.cs: New warning.
7978 2007-02-06 Marek Safar <marek.safar@gmail.com>
7980 A fix for bug #80742
7981 * expression.cs: Delegate Invoke method can be called directly.
7983 2007-02-06 Marek Safar <marek.safar@gmail.com>
7985 A fix for bug #80676
7986 * class.cs (IsEntryPoint): The Main method can have params modifier.
7988 2007-02-04 Miguel de Icaza <miguel@novell.com>
7990 * parameter.cs (Parameter, Parameters): Add Clone method.
7992 * anonymous.cs (Compatible): Turn method into virtual method, so
7993 LambdaExpression can implement a different behavior.
7995 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
7996 out the basic checking here, so it can be used by
7999 * lambda.cs: Introduce "Compatible" function that will do the
8002 2007-02-02 Marek Safar <marek.safar@gmail.com>
8004 * attribute.cs: Unified one error message.
8006 * class.cs (Class): Use type attributes and not properties to test static
8008 (IsEntryPoint): Don's pass local variable.
8010 * convert.cs: Removed duplicate check.
8012 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8014 * driver.cs: Don't crash when soft reference does not exist.
8016 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8017 (UsingEntry): Removed redundant allocation.
8019 * parameter.cs: Add fast path for type parameters.
8021 * support.cs: Don't allocate attribute when it's not used.
8023 2007-01-30 Miguel de Icaza <miguel@novell.com>
8026 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8027 this into a virtual method, so we can override it in LambdaExpression.
8029 * driver.cs: Improve diagnostics in case of failure.
8031 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8032 write a function that is slightly more complex and that parses:
8034 type identifier [, type identifier]* )
8036 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8039 (canEmpty ? i >= 0 : i > 0)
8041 2007-01-30 Raja R Harinath <rharinath@novell.com>
8043 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8044 exception on possibly valid code.
8046 2007-01-29 Raja R Harinath <rharinath@novell.com>
8048 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8050 (parse_opt_type_arguments): Remove. It's almost the same as
8052 (parse_namespace_or_typename): Use parse_less_than.
8054 2007-01-28 Miguel de Icaza <miguel@novell.com>
8056 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8057 this bug took a few hours to find, because the state saved and
8058 restored by PushPosition and PopPosition was ignoring the state of
8059 parse_generic_less_than.
8061 I can also now remove the handling of OP_LT and OP_GT, this solves
8064 * cs-tokenizer.cs: store the location for the ARROW token, we use
8067 (PushPosition, PopPosition): save/restore also `current_token',
8068 restore `parse_generic_less_than' (was missing).
8070 (parse_opt_type_arguments): use parse_type, not
8071 parse_namespace_or_typename to parse types.
8073 * lambda.cs: Empty new file, will eventually have the lambda
8074 expression implementation.
8076 * lambda.test: used to test the internal tokenizer.
8078 * report.cs (FeatureIsNotISO1): Rename from
8079 FeatureIsNotStandardized, because it was about the language level
8080 (1 vs 2) it was not about standarization.
8082 (FeatureRequiresLINQ): New.
8084 * support.cs (SeekableStreamReader): Only require that the reader
8085 is a TextReader, not a StreamReader, so we can plug StringReader.
8087 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8088 given position in the input stream the following tokens can be
8089 parsed as a type followed by an identifier.
8091 (is_punct): after a '(' if parse_type_and_parameter returns true,
8092 then return a special token OPEN_PARENS_LAMBDA which is used to
8093 avoid reduce/reduce errors in the grammar for the
8094 lambda_expression rules.
8096 (parse_type): implement a type parser inside the
8097 tokenizer, the parser only returns true or false depending on
8098 whether the input at a given position can be parsed as a type.
8100 (peek_token): new method used during type parsing.
8102 2007-01-28 Raja R Harinath <rharinath@novell.com>
8105 * anonymous.cs (ScopeInfo.InflateParameters): New.
8106 (AnonymousContainer.Resolve): Use it to redirect types of
8107 delegate parameters.
8109 2007-01-27 Raja R Harinath <rharinath@novell.com>
8112 * expression.cs (Error_InvalidArguments): Don't use two different
8113 messages for CS1503. Use ExtraInformation and
8114 SymbolRelatedToPreviousError instead.
8117 * decl.cs (DeclSpace.initialize_type_params): Don't access
8118 'type_params' of a partial class directly.
8120 2007-01-26 Miguel de Icaza <miguel@novell.com>
8122 * constant.cs: Removed a handful of out-of-range checks that were
8125 2007-01-25 Marek Safar <marek.safar@gmail.com>
8127 * expression.cs (CheckUselessComparison): Add additional check for char
8130 * namespace.cs: Fixed typo.
8132 2007-01-23 Miguel de Icaza <miguel@novell.com>
8134 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8135 gone, instead we inline the test, preventing the needless casts to
8136 longs, ulongs and doubles for the parameters, avoiding calls to
8137 methods that overchecked stuff, and instead inlined things
8140 2007-01-20 Marek Safar <marek.safar@gmail.com>
8142 * cs-parser.jay: Better parameter error handling.
8144 2007-01-17 Marek Safar <marek.safar@gmail.com>
8146 A fix for bug #80368, #80522
8147 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8148 whether array initializer contains constants only.
8149 (ArrayCreation.Emit): Use better formula to decide when
8150 are array initializers for static initialization.
8151 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8152 have to emit even constants otherwise they are pre-initialized.
8154 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8155 Raja R Harinath <rharinath@novell.com>
8157 Fix emit order of 'get' vs. 'set'.
8158 * support.cs (Accessors): New.
8159 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8160 Note the order in which accessors are declared in the source.
8161 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8162 Refactored from Property.Define and Indexer.Define.
8163 (PropertyBase.DefineAccessors): New helper that calls the above in
8164 appropriate order as noted by the parser.
8165 (Property.Define, Indexer.Define): Update to changes.
8166 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8168 2007-01-17 Raja R Harinath <rharinath@novell.com>
8170 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8171 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8172 there's an implicit conversion from the current type to the target
8173 type before converting the underlying constant.
8175 2007-01-16 Marek Safar <marek.safar@gmail.com>
8177 * const.cs (ResolveValue): Updated after constant conversion was made more
8180 * constant.cs (GetAttributableValue): constant to object conversion is
8181 used for attributes only.
8182 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8183 constant conversions.
8184 (LongConstant.ConvertImplicitly): Ditto.
8186 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8187 (ImplicitConversionStandard): Handle constant conversion as extra step.
8188 It solves the issue when constant conversion was called indirectly like
8189 inside array initializer and constant folding was skipped.
8191 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8194 * statement.cs(ImplicitConversionStandard): Updated after constant
8195 conversion was made more generic.
8197 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8199 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8200 Constraints, solves the problem where the compiler incorrectly
8201 reported that a type parameter was not constrained to a class (Bug
8204 2007-01-14 Marek Habersack <grendello@gmail.com>
8206 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8208 2007-01-14 Marek Safar <marek.safar@gmail.com>
8210 A fix for bug #80368
8211 * assign.cs (FieldInitializer): New class implements field
8212 initializer statement.
8214 * attribute.cs: Update after FieldMember rename.
8216 * class.cs (PropertyBasedMember): New common class for property based
8218 (InterfaceMemberBase): New base class for all members which can be used as
8219 an interface members.
8220 (MethodCore): Moved really common code to InterfaceMemberBase.
8221 (Method.Define): Equal and GetHasCode detection is relevant for methods
8223 (MethodData.Define): Don't assume that public event implements an
8224 interface automatically.
8225 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8227 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8228 (FieldMember): Merged with FieldBase.
8229 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8230 event extern modifier can be used.
8231 (EventField.EventFieldAccessor): Moved event field specific code here.
8232 (Event.AllowedModifiers): Even event can be extern.
8233 (Event.FindOutBaseMethod): New override specific to events.
8234 (Indexer.parameters): Reintroduce parameters because base class holds
8235 only properties common data.
8236 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8237 need do extra parameters check.
8239 * const.cs: Update after FieldMember rename.
8241 * decl.cs (MemberCache.FindBaseEvent): New method.
8243 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8244 to reflect that indexer is now derived from PropertyBased.
8246 * ecore.cs (GetMemberType): Made public.
8247 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8250 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8252 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8253 (RegisterEvent): Removed.
8254 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8255 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8257 2007-01-11 Raja R Harinath <rharinath@novell.com>
8260 * statement.cs (CollectionForeach.TryType): Prefer generic
8261 GetEnumerator over non-generic variant. Fix code to follow comments.
8263 2007-01-09 Raja R Harinath <rharinath@novell.com>
8266 * support.cs (ReflectionParameter): Don't use an invalid index on
8267 the generic parameter data.
8269 2007-01-08 Miguel de Icaza <miguel@novell.com>
8271 * driver.cs: Just add a tiny bit of infrastructure.
8273 2007-01-02 Marek Safar <marek.safar@gmail.com>
8275 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8276 where field type is struct from current assembly.
8278 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8281 2007-01-02 Marek Safar <marek.safar@gmail.com>
8283 A fix for bug #80381
8284 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8287 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8289 (Namespace.LookupType): Always use core types from corlib when speficied.
8291 * report.cs: A new warning.
8293 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8294 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8295 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8297 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8298 (InitCoreTypes): Set expression type of object_type and value_type
8299 immediately after lookup.
8301 2007-01-01 Miguel de Icaza <miguel@novell.com>
8303 * cs-tokenizer.cs: Accept Pc class characters (Connector
8304 Punctuation) as valid identifiers. Fixes #78259
8306 * expression.cs (Invocation.DoResolve): Moved the check for the
8307 use of `this' for doing method calls to the Invocation resolution
8308 step, after overload resolution has taken place instead of doing
8309 the check at the low-level `This.DoResolve' level.
8311 The `This.DoResolve'(appens before overload resolution, so it has
8312 no way of knowing if the method that will be called will be
8313 instace or static, triggering an erroneous report for cs0188 (Bug
8316 We now do the check for instance method invocations after we know
8317 what method will be called.
8319 (This.CheckThisUsage): Move the actual use of this structure
8320 checking into its own method and expose it.
8322 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8325 Exceptions: Null.ConvertImplicitly,
8326 Constant.ImplicitConversionRequired as there are too many call
8327 sites for passing the ec.
8329 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8330 EmitContext, if the value is null, then we do not try to provide
8331 the extra information from the error (If a userdefined conversion
8332 exists, as UserDefinedConversion requires a non null-EmitContext).
8336 2006-12-30 Raja R Harinath <rharinath@novell.com>
8338 * flowanalysis.cs (MyBitVector): Document some invariants.
8339 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8340 introduced below, and add a couple of others,
8342 2006-12-30 Marek Safar <marek.safar@gmail.com>
8344 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8345 GetPropertyFromAccessor and GetEventFromAccessor.
8347 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8348 overrides non-obsolete one.
8349 (Indexer.Define): Error message has been moved to the parser.
8351 * cs-parser.jay: Better syntax errors handling.
8353 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8354 when an invocation has no arguments.
8356 * ecore.cs: Removed not used caching.
8358 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8361 * report.cs: Add a new warning.
8363 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8365 * typemanager.cs (enumeration_type): Removed.
8366 (CSharpSignature): Reuses IsSpecialMethod.
8367 (IsEqual): Hack for MS BCL.
8368 (GetPropertyFromAccessor): New method.
8369 (GetEventFromAccessor): New method.
8370 (IsSpecialMethod): Fixed to handle more cases.
8372 2006-12-30 Marek Safar <marek.safar@gmail.com>
8374 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8375 Made white spaces array static.
8377 * ecore.cs (RemoveGenericArity): Optimized.
8379 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8381 (MyBitVector.initialize_vector): Simplified.
8383 2006-12-22 Miguel de Icaza <miguel@novell.com>
8385 * ecore.cs: Am not entirely happy with this hack, but it seems to
8386 address the issue in 80257 (a small test case for
8389 I set the MethodGroupExpr.Type to an internal compiler type
8390 (itself in this case) to force the resolution to take place. Why
8391 it does not take place with a null is beyond me.
8393 2006-12-20 Marek Safar <marek.safar@gmail.com>
8395 A fix for bug #80288
8396 * expression.cs (ResolveOperator): Consider user defined conversion for
8397 logical and operator too.
8398 (EmitBranchable): Optimization for logical and when full constant folding
8399 could not be applied but one operand is constant.
8401 2006-12-19 Marek Safar <marek.safar@gmail.com>
8403 * class.cs (GetClassBases): Write 5 times every day, will never use
8404 FullName for error reporting.
8406 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8408 2006-12-19 Martin Baulig <martin@ximian.com>
8410 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8411 the symbol file info here.
8413 2006-12-18 Marek Safar <marek.safar@gmail.com>
8415 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8416 of `elseif' is taking then following sections are not taking.
8417 Fixes an issue reported on mono mailing list.
8419 2006-12-18 Marek Safar <marek.safar@gmail.com>
8421 A fix for bug #80300
8422 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8423 a caller is not taking.
8425 2006-12-18 Raja R Harinath <rharinath@novell.com>
8427 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8428 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8429 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8430 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8431 * class.cs: Update to changes.
8433 2006-12-17 Marek Safar <marek.safar@gmail.com>
8435 A fix for bug #79934
8436 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8439 * class.cs (ResolveMembers): Register an iterator in current container and
8442 2006-12-16 Raja R Harinath <rharinath@novell.com>
8445 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8446 satisfy a params annotated parameter.
8448 2006-12-16 Marek Safar <marek.safar@gmail.com>
8450 A fix for bug #77014
8451 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8452 paramters correctly and not rely on hacks in Parameters class.
8453 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8455 (Invocation.VerifyArgumentsCompat): Ditto.
8456 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8459 * parameter.cs (HasParams): Don't assume that params is the last one.
8461 * support.cs (ReflectionParameters.ctor): Look for params attribute
8463 (ReflectionParameters.ParameterType): Removed hack when we returned last
8464 parameter for out of range parameters.
8465 (ParameterName, ParameterModifier): Ditto.
8467 2006-12-14 Marek Safar <marek.safar@gmail.com>
8469 A fix for bug #79987
8470 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8471 when assembly is not CLS compliant but type is. I have no idea why is this
8474 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8476 2006-12-13 Miguel de Icaza <miguel@novell.com>
8478 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8479 in struct constructors, they are basically no-ops.
8481 2006-12-12 Marek Safar <marek.safar@gmail.com>
8483 * cs-tokenizer.cs (Position): Save preprocessor status too.
8485 2006-12-12 Marek Safar <marek.safar@gmail.com>
8487 A fix for bug #77794
8488 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8490 2006-12-12 Marek Safar <marek.safar@gmail.com>
8492 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8494 (pp_expr): Report error for an invalid expression.
8495 (handle_preprocessing_directive): Simplified; add more error checking.
8497 2006-12-11 Marek Safar <marek.safar@gmail.com>
8499 A fix for bug #74939
8500 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8501 directives handling.
8503 2006-12-10 Marek Safar <marek.safar@gmail.com>
8505 A fix for bugs #80093, and #75984
8506 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8507 logic, it seems to me as it worked before "by coincidence".
8508 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8509 (cleanup): Enabled endif check.
8511 2006-12-09 Marek Safar <marek.safar@gmail.com>
8513 A fix for bug #80162
8514 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8515 enumerators are never ambiguous.
8517 2006-12-08 Raja R Harinath <rharinath@novell.com>
8520 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8522 2006-12-06 Marek Safar <marek.safar@gmail.com>
8524 A fix for bug #80144
8525 * class.cs (EventProperty.Define): Explicit implementation means
8526 that an even is used.
8528 2006-12-06 Marek Safar <marek.safar@gmail.com>
8530 Fixes the operators implementation (part II)
8532 * cfold.cs (DoConstantNumericPromotions): Renamed to
8533 DoBinaryNumericPromotions and simplified.
8534 (BinaryFold): Couple of conversion fixes; simplified.
8536 * constant.cs, ecore.cs, literal.cs
8537 (ToType): Renamed to ConvertImplicitly.
8538 (Reduce): Renamed to ConvertExplicitly.
8540 * class.cs, convert.cs: Updated.
8542 * expression.cs: TryReduce doesn't throw an exception.
8544 2006-12-01 Marek Safar <marek.safar@gmail.com>
8546 A fix for bug #80108
8547 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8550 2006-11-30 Marek Safar <marek.safar@gmail.com>
8552 Fixes unary operators implementation (part I)
8555 * cfold.cs (Error_CompileTimeOverflow): Made internal
8557 * const.cs (IConstant): Changed to use reference to constant and
8558 not constant itself.
8559 Updated IConstant implementations.
8561 * constant.cs (CreateConstant): New factory method.
8562 Updated IConstant implementation.
8564 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8566 * ecore.cs: Updated to use CreateConstantReference.
8568 * enum.cs: Reflects IConstant changes.
8570 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8572 * literal.cs (NullConstant): Change to be independently usable.
8574 2006-11-29 Martin Baulig <martin@ximian.com>
8576 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8577 we need to emit the scope initializer before calling the base .ctor.
8579 * anonymous.cs: Merged back from the new anonymous methods branch.
8580 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8582 * expression.cs (ParameterReference.DoResolveBase): Create a
8583 "normal" ScopeInfo when capturing parameters rather than using the
8584 root scope; this makes things work with anonymous methods having
8588 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8590 2006-11-22 Marek Safar <marek.safar@gmail.com>
8592 A fix for bug #79987
8593 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8594 check to a base class.
8595 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8596 only when assembly has missing attribute.
8597 * report.cs: Update.
8599 2006-11-21 Marek Safar <marek.safar@gmail.com>
8601 * cs-tokenizer.cs: Merged with gmcs version.
8603 2006-11-20 Marek Safar <marek.safar@gmail.com>
8606 * cs-parser.jay: Better error message when partial keyword is misplaced.
8608 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8610 A fix for bug #79810
8611 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8612 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8613 a RuntimeWrappedException by default.
8615 2006-11-18 Marek Safar <marek.safar@gmail.com>
8617 A fix for bug #79843
8618 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8620 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8622 2006-11-18 Marek Safar <marek.safar@gmail.com>
8624 * driver.cs, namespace.cs: Uses faster IndexOf version.
8626 2006-11-17 Marek Safar <marek.safar@gmail.com>
8628 A fix for bug #79941
8629 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8631 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8632 even if internal name is different.
8633 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8634 (UserDefinedConversion): Simplified as the operators cannot be internal.
8635 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8637 (MethodLookup): Replaced EmitContext with parentType.
8638 * expression.cs: Updated.
8640 2006-11-09 Raja R Harinath <rharinath@novell.com>
8642 * driver.cs (BadAssembly): Handle all the ugliness of
8643 DefineDynamicAssembly.
8645 2006-11-08 Raja R Harinath <rharinath@novell.com>
8647 Address parts of #58244 -- most of what's left is in the runtime
8648 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8649 CS1509 error checks, and handle them for all assembly loads, not
8650 just the first invocation.
8651 (LoadModule): Likewise. Move handling of 'adder_method' ...
8652 * codegen.cs (AssemblyClass.AddModule): ... here.
8654 2006-11-02 Marek Safar <marek.safar@gmail.com>
8656 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8657 IEnumerable<T> is ambiguous.
8659 2006-10-31 Marek Safar <marek.safar@gmail.com>
8661 A fix for bug #67689
8662 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8663 GetEnumerator is ambiguous.
8665 * report.cs: Add new warning.
8667 2006-10-29 Marek Safar <marek.safar@gmail.com>
8669 A fix for bug #78602
8670 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8671 to protected member can be nested type.
8673 2006-10-28 Marek Safar <marek.safar@gmail.com>
8675 A fix for bug #78965
8676 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8677 to protected member must derive from current type.
8679 2006-10-27 Marek Safar <marek.safar@gmail.com>
8681 assign.cs: Reuses error method.
8683 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8684 instead of type for constants.
8685 (Expression.Error_ValueAssignment): Common error method.
8687 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8690 2006-10-27 Marek Safar <marek.safar@gmail.com>
8692 A fix for bug #79081
8693 * expression.cs (MemberAccess.DoResolve): Check nested type
8696 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8698 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8700 2006-10-26 Marek Safar <marek.safar@gmail.com>
8702 A fix for bug #76591
8703 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
8705 2006-10-26 Marek Safar <marek.safar@gmail.com>
8707 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
8708 type forwarder of the same type multiple times.
8710 2006-10-26 Raja R Harinath <rharinath@novell.com>
8713 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
8714 instance as an rvalue, even when we later resolve as an lvalue.
8716 2006-10-25 Martin Baulig <martin@ximian.com>
8718 * anonymous.cs: Fix #79673.
8720 2006-10-24 Marek Safar <marek.safar@seznam.cz>
8722 A fix for bug #79666
8723 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
8724 ignored when is optimized (= default value) as its value is already set.
8726 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8728 A fix for bug #79724
8729 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
8730 TypeContainer for type lookup.
8732 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8734 A fix for bug #79231
8735 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
8736 * expression.cs (OverloadResolve): Always convert type name for
8738 (ResolveNamespaceOrType): Don't confuse a nested type with any
8741 2006-10-18 Martin Baulig <martin@ximian.com>
8743 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
8745 2006-10-17 Miguel de Icaza <miguel@novell.com>
8747 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
8748 an int32, but requesting an int64 from the conversion
8750 2006-10-12 Martin Baulig <martin@ximian.com>
8753 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
8755 2006-10-12 Martin Baulig <martin@ximian.com>
8758 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
8760 2006-10-11 Miguel de Icaza <miguel@novell.com>
8762 * convert.cs: Remove broken code: I was doing the "Existance"
8763 tests for Implicit conversions.
8765 2006-10-10 Miguel de Icaza <miguel@novell.com>
8767 * convert.cs: Added one missing case in
8768 ImplicitStandardConversionExists uint64 to intptr.
8772 * typemanager.cs (uintptr_type): another core known type.
8774 * ecore.cs (OperatorCast): routine used to do cast operations that
8775 depend on op_Explicit. We could change some of the Decimal
8776 conversions to use this.
8778 This one has a probe mechanism that checks both types for an op_
8779 which it coudl be used to eliminate two classes: CastToDecimal
8780 and CastFromDecimal.
8782 * convert.cs: Implement the conversions documented in #59800
8784 2006-10-10 Martin Baulig <martin@ximian.com>
8786 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
8787 before RootScope.ResolveMembers().
8789 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
8790 `CurrentType' if appropriate.
8792 2006-10-09 Marek Safar <marek.safar@seznam.cz>
8794 A fix for bug #78568
8795 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
8796 when contains binary operators.
8797 * cs-parser.jay: Updated.
8799 2006-10-09 Martin Baulig <martin@ximian.com>
8802 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
8803 moved that into Define() and also do the other type parameter
8804 checks there. Fixes #79094. Added gtest-292.cs.
8807 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
8808 since that doesn't include type parameters; don't use `Ldelema'
8809 for type parameters. Fixes #78980. Added gtest-293.cs.
8811 2006-10-08 Marek Safar <marek.safar@seznam.cz>
8814 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
8815 conversion is allowed.
8817 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8819 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
8820 error reporting when no error occurs.
8822 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8824 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
8827 2006-10-06 Raja R Harinath <rharinath@novell.com>
8830 * class.cs (DefineTypeBuilder): Check circular dependencies before
8831 setting the parent of the TypeBuilder.
8832 (CheckRecursiveDefinition): Don't use 'BaseType', since
8833 it may not be valid until after DefineTypeBuilder. Use
8834 'base_type' instead.
8836 2006-10-04 Martin Baulig <martin@ximian.com>
8838 Merged the Anonymous Methods patch.
8840 * anonymous.cs, iterators.cs: The new anonymous methods code.
8842 * statement.cs (Variable): New public abstract class.
8843 (LocalInfo.Variable): New public property.
8844 (LocalInfo.ResolveVariable): New public method.
8845 (Block.Flags): Add `IsIterator'.
8846 (Block.AddVariable): Improved the CS0136 check.
8847 (Block.AnonymousChildren): New public property.
8848 (Block.AddAnonymousChild): New public method.
8849 (ToplevelBlock): Update to use the new anonymous method framework.
8850 (ToplevelBlock.ctor): `container' is now a `Block' and not a
8851 `ToplevelBlock'; this is required to correctly implement the
8853 (Fixed, Using): Use `TemporaryVariable' instead of directly
8854 creating the `LocalBuilder'.
8856 * parameter.cs (Parameter.ResolveVariable): New public method.
8857 (Parameters.ResolveVariable): Likewise.
8859 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
8861 * class.cs (TypeContainer): Replaced the `iterators' list and
8862 corresponding methods with a list of `CompilerGeneratedClass'es.
8863 (TypeContainer.ResolveMembers): New public method.
8864 (Method): `IIteratorContainer' has been replaced by
8867 * expression.cs (VariableReference): New public abstract base
8868 class for `LocalVariableReference', `ParameterReference' and
8871 * codegen.cs (EmitContext): Removed `capture_context',
8872 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
8873 (EmitContext.EmitThis): Removed.
8875 * cs-parser.jay: Replace `iterator_container' with
8878 2006-10-04 Martin Baulig <martin@ximian.com>
8880 * generic.cs (GenericMethod): Don't make this abstract.
8881 (Constraints.Clone): Added dummy implementation.
8883 2006-10-04 Raja R Harinath <harinath@gmail.com>
8886 * namespace.cs (LookForAnyGenericType): Avoid nullref on
8887 'declspaces'. Avoid allocating arrays willy-nilly.
8890 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
8891 cases out of the switch.
8893 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8895 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
8896 message when non-generic type is used with the type arguments.
8897 * expression.cs: Updated.
8899 2006-09-28 Raja R Harinath <rharinath@novell.com>
8902 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
8903 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8904 Change semantics slightly. Don't insist on having only one
8905 temporary EmptyExpression -- just throttle the creation of new ones.
8908 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
8909 non-interfaces too. If no methods are found, don't try to create
8912 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8914 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
8917 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
8918 us produce better error message.
8920 2006-09-27 Marek Safar <marek.safar@seznam.cz>
8922 * expression.cs (Binary.ResolveOperator): Warn about a side effect
8923 of the `|' operator.
8925 * report.cs: A new warning added.
8927 2006-09-27 Martin Baulig <martin@ximian.com>
8929 * generic.cs (GenericMethod): Don't make this abstract.
8931 2006-09-27 Martin Baulig <martin@ximian.com>
8934 (InternalErrorException): Added overloaded ctor taking a params array.
8936 2006-09-26 Marek Safar <marek.safar@seznam.cz>
8938 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
8939 Fixed the cases when same error was reported twice.
8941 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
8942 now report symbol information.
8944 2006-09-25 Martin Baulig <martin@ximian.com>
8946 * class.cs: Completely unified with the gmcs version.
8948 2006-09-25 Martin Baulig <martin@ximian.com>
8950 * typemanager.cs (TypeManager.IsNullableType): New public function.
8951 (TypeManager.IsNullableTypeOf): Likewise.
8952 (TypeManager.IsNullableValueType): Likewise.
8954 * class.cs (MethodCore): Added the `GenericMethod' argument from
8955 gmcs and also unified all classes derived from `MethodCore' with gmcs.
8957 2006-09-24 Raja R Harinath <harinath@gmail.com>
8959 * convert.cs: Unify with gmcs version.
8961 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8963 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
8964 verify them as well.
8966 * report.cs: New warning.
8968 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8970 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
8971 for anonymous block with out argument.
8973 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8975 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
8976 not used private events only.
8978 2006-09-23 Marek Safar <marek.safar@seznam.cz>
8980 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
8982 * const.cs (Const.Define): Check for constant type.
8983 (Const.IsConstantTypeValid): Looks for valid constant types.
8985 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
8987 * ecore.cs (EmptyConstantCast): New common class for all constant based
8990 * expression.cs (Is.DoResolve): Handle null constant especially.
8991 (New.DoResolve): Check for new void().
8992 (MemberAccess.DoResolve): Cope with all kind of nulls.
8994 * literal.cs (NullConstant): Uses EmptyConstantCast.
8995 (NullDefault): Based on EmptyConstantCast.
8996 (NullLiteral): Uses EmptyConstantCast.
8998 * statement.cs (Block.ResolveMeta): Check for constant type.
9000 2006-09-22 Martin Baulig <martin@ximian.com>
9002 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9004 2006-09-22 Raja R Harinath <rharinath@novell.com>
9006 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9010 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9011 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9014 2006-09-22 Martin Baulig <martin@ximian.com>
9016 * ecore.cs: Merged with the gmcs version.
9018 * generic.cs (ConstructedType): New dummy class.
9019 (TypeArguments): Don't make this abstract.
9022 (TypeManager.IsGenericTypeDefinition): New method.
9023 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9025 2006-09-22 Raja R Harinath <rharinath@novell.com>
9027 * expression.cs (ComposedCast): Check for arrays of TypedReference
9028 before creating the type, not after.
9030 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9032 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9033 after ToType change.
9035 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9036 when constant must be implicitly convertible.
9038 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9040 * ecore.cs (NullCast): Derives from NullConstant.
9042 * expression.cs (Is.DoResolve): Removed useless variables.
9043 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9044 (New.Constantify): Add enum support.
9045 (MemberAccess.DoResolve): Add warning when accessing null constant or
9048 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9051 * literal.cs (NullConstant): New abstract class with common
9052 functionality for all null specializations.
9053 (NullDefault): Represents default(X) when result can be
9055 (NullLiteral): Updated.
9057 * report.cs: Add new warning.
9059 2006-09-21 Martin Baulig <martin@ximian.com>
9061 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9063 2006-09-21 Martin Baulig <martin@ximian.com>
9065 * generic.cs (GenericConstraints): New dummy class.
9066 (Constraints): Likewise.
9067 (TypeParameter): Likewise.
9068 (TypeParameterName): Likewise.
9069 (GenericMethod): Likewise.
9071 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9073 * decl.cs: Merged with the gmcs version.
9075 2006-09-21 Raja R Harinath <rharinath@novell.com>
9077 * generic.cs (TypeParameter): Implement IMemberContainer.
9078 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9080 * rootcontext.cs: Unify with gmcs version.
9082 * report.cs: Unify with gmcs version.
9083 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9084 from gmcs/generics.cs.
9085 * generics.cs (TypeParameter): New dummy class.
9087 * support.cs: Unify with gmcs version.
9089 2006-09-20 Raja R Harinath <rharinath@novell.com>
9091 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9092 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9094 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9095 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9096 * mcs.exe.sources: Add generic.cs.
9098 * codegen.cs: Unify with gmcs version.
9100 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9101 (EmitContext): Add GenericDeclContainer implementation.
9102 * decl.cs (MemberCore, DeclSpace): Likewise.
9103 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9105 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9106 MCS TypeManager has a corresponding dummy method.
9108 2006-09-19 Martin Baulig <martin@ximian.com>
9110 * expression.cs: Completely merged with the gmcs version.
9112 2006-09-19 Martin Baulig <martin@ximian.com>
9114 * expression.cs (Invocation): Merged with the gmcs version.
9115 (ArrayAccess.GetStoreOpcode): Likewise.
9117 2006-09-19 Martin Baulig <martin@ximian.com>
9120 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9121 (TypeManager.IsGenericMethodDefinition): Likewise.
9123 2006-09-19 Martin Baulig <martin@ximian.com>
9126 (TypeManager.IsEqual): Moved the gmcs implementation here.
9127 (TypeManager.DropGenericTypeArguments): Likewise.
9128 (TypeManager.DropGenericMethodArguments): Likewise.
9129 (TypeManager.GetTypeArguments): Moved here from gmcs.
9130 (TypeManager.HasGenericArguments): Likewise.
9132 2006-09-19 Martin Baulig <martin@ximian.com>
9134 * expression.cs (Binary): Merged with the gmcs version.
9136 2006-09-19 Martin Baulig <martin@ximian.com>
9138 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9140 2006-09-19 Martin Baulig <martin@ximian.com>
9142 * typemanager.cs: Merged with the gmcs version.
9144 2006-09-16 Raja R Harinath <rharinath@novell.com>
9146 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9147 * driver.cs: Likewise.
9149 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9152 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9153 only if parent type is class.
9154 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9157 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9160 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9162 * typemanager.cs(CSharpName): Converts NullType to null.
9164 2006-09-15 Martin Baulig <martin@ximian.com>
9167 (TypeManager.GetMethodName): Added mcs implementation.
9168 (TypeManager.IsEqual): Likewise.
9171 (SimpleName.RemoveGenericArity): Added dummy implementation.
9173 * pending.cs: Merged with the gmcs version.
9175 2006-09-15 Martin Baulig <martin@ximian.com>
9177 * statement.cs: Merge with the gmcs version.
9179 2006-09-15 Martin Baulig <martin@ximian.com>
9181 * statement.cs (Switch): Merge with the gmcs implementation
9182 (without nullables), which is newer.
9184 2006-09-15 Martin Baulig <martin@ximian.com>
9186 * statement.cs (Block.Variables): Make this public.
9187 (ToplevelBlock.Parameters): Make this a property.
9188 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9190 2006-09-15 Martin Baulig <martin@ximian.com>
9192 * namespace.cs: Merge with the gmcs version.
9194 2006-09-15 Martin Baulig <martin@ximian.com>
9196 * decl.cs (MemberName): Minor code cleanups.
9198 2006-09-15 Martin Baulig <martin@ximian.com>
9200 * parameter.cs: Merge with the gmcs version.
9202 2006-09-15 Martin Baulig <martin@ximian.com>
9204 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9205 and an error in mcs.
9207 2006-09-15 Martin Baulig <martin@ximian.com>
9209 * flowanalysis.cs: Merged from GMCS; added the generics code into
9210 a `GMCS_SOURCE' conditional so we can share this file.
9212 2006-09-08 Martin Baulig <martin@ximian.com>
9214 * typemanager.cs (TypeManager.interlocked_type): New public field.
9215 (TypeManager.int_interlocked_compare-exchange): New public field.
9216 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9217 enumerator types here and call InitGenericCoreTypes().
9218 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9219 after calling InitEnumUnderlyingTypes().
9222 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9223 `classes_second_stage'.
9225 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9227 * assign.cs, ecore.cs, expression.cs: Share error message text.
9228 * class.cs (FieldMember.Define): Check for varible of static type.
9229 * driver.cs (LoadAssembly): Uses error output for errors.
9230 * statement.cs: Updated.
9232 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9234 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9237 2006-09-07 Martin Baulig <martin@ximian.com>
9240 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9242 2006-08-29 Miguel de Icaza <miguel@novell.com>
9244 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9246 2006-08-17 Miguel de Icaza <miguel@novell.com>
9248 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9249 #52019 and #79064, the use of the \uXXXX sequence in source code
9250 to represent unicode characters.
9252 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9254 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9256 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9258 2006-08-13 Miguel de Icaza <miguel@novell.com>
9260 * assign.cs: Catch attempts to assign to a method groups in += and
9263 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9266 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9268 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9270 * class.cs (Method.Define): Issue a warning when generic method looks like
9272 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9275 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9277 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9279 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9280 search all base interfaces as a member can be ambiguous.
9281 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9282 Constructor member type filter.
9283 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9284 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9285 reporting for returned memberinfos.
9286 * report.cs: Updated.
9287 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9288 version to work on all runtimes.
9289 (TypeManager.RealMemberLookup): Removed members filtering.
9291 2006-08-08 Raja R Harinath <rharinath@novell.com>
9293 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9294 (PropertyExpr.EmitAssign): Likewise.
9295 * expression.cs (Indirection.EmitAssign): Likewise.
9296 (LocalVariableReference.EmitAssign): Likewise.
9297 (ParameterReference.EmitAssign): Likewise.
9298 (Invocation.EmitArguments): Likewise.
9299 (ArrayAccess.EmitAssign): Likewise.
9300 (IndexerAccess.EmitAssign): Likewise.
9301 (This.EmitAssign): Likewise.
9302 (ConditionalLogicalOperator.Emit): Likewise.
9305 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9306 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9307 leave it in after returning it.
9308 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9310 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9312 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9315 2006-08-03 Raja R Harinath <rharinath@novell.com>
9317 Fix cs0146-3.cs and cs0146-4.cs.
9318 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9319 enclosing types don't depend on the current type.
9321 2006-08-02 Raja R Harinath <rharinath@novell.com>
9324 * class.cs (TypeContainer.DoDefineMembers): Use
9325 FindBaseMemberWithSameName on Parent, since we're interested in
9326 whether we hide inherited members or not.
9327 (FindBaseMemberWithSameName): Make slightly more robust.
9329 Fix the non-generic testcase from #77396
9330 * decl.cs (DeclSpace.DeclContainer): Remove override.
9332 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9333 declspaces for doppelgangers too.
9334 (UsingEntry): Implement IResolveContext.
9335 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9336 'this' as the resolve context.
9337 (LocalAliasEntry): Likewise.
9339 Implement parts of #77403
9340 * roottypes.cs (RootDeclSpace): New. Used to represent the
9341 toplevel declaration space. Each namespace declaration introduces
9342 a "partial" root declaretion space.
9343 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9344 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9345 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9346 from 'current_namespace.SlaveDeclSpace'.
9347 (namespace_declaration): Likewise.
9348 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9349 check. It can't happen now.
9350 * decl.cs (DeclSpace.LookupType): Likewise.
9351 * driver.cs (MainDriver): Sanity check.
9353 2006-08-01 Raja R Harinath <rharinath@novell.com>
9355 * decl.cs (DeclSpace.FindNestedType): Remove.
9356 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9357 LookupTypeContainer to get the container of the nested type.
9358 * class.cs (TypeContainer.FindNestedType): Make non-override.
9360 2006-07-31 Raja R Harinath <rharinath@novell.com>
9362 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9363 * class.cs (TypeContainer.PartialContainer): ... here.
9364 (TypeContainer.AddBasesForPart): New helper.
9365 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9367 * cs-parser.jay (current_class): Convert to DeclSpace.
9368 (struct_declaration, interface_declaration, class_declaration):
9369 Use AddBasesForPart instead of .Bases directly.
9370 * const.cs, iterators.cs: Update to changes.
9372 2006-07-28 Raja R Harinath <rharinath@novell.com>
9374 * class.cs (TypeContainer.AddMemberType): Rename from
9376 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9377 (AddTypeContainer): New. Combine AddClassOrStruct and
9379 (AddPartial): Update. Add 'is_partial' argument.
9380 * roottypes.cs: Update to changes.
9381 * cs-parser.jay (push_current_class): New helper for handling
9382 current_container and current_class.
9383 (struct_declaration, interface_declaration, class_declaration):
9386 2006-07-26 Raja R Harinath <rharinath@novell.com>
9388 * roottypes.cs: Rename from tree.cs.
9390 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9391 * tree.cs (Tree, ITreeDump): Remove types.
9392 * rootcontext.cs (tree, Tree): Remove fields.
9393 (root, ToplevelTypes): New.
9394 * *.cs: Update to rename.
9396 * tree.cs (Tree.RecordDecl): Remove.
9397 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9399 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9401 2006-07-23 Raja R Harinath <harinath@gmail.com>
9403 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9404 DoFlowAnalysis and OmitStructFlowAnalysis here.
9405 (ec.With): Rename from WithUnsafe and generalize.
9406 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9407 (ec.WithFlowAnalyis): New.
9408 * ecore.cs, expression.cs, statement.cs: Update.
9410 2006-07-22 Raja R Harinath <harinath@gmail.com>
9412 * statement.cs (Block.ResolveMeta): Simplify slightly.
9414 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9415 multiple boolean fields. Convert InUnsafe, constant_check_state,
9416 check_state to flags.
9417 (CheckState, ConstantCheckState): Update.
9418 (InUnsafe): New read-only property.
9419 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9421 (WithUnsafe): New helper similar to WithCheckState.
9422 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9423 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9425 2006-07-21 Raja R Harinath <rharinath@novell.com>
9427 Make comparisons use the same IL irrespective of whether they're
9428 in a 'checked' or 'unchecked' context: one of the issues in #78899
9429 * codegen.cs (EmitContext.CheckState): Make read-only property.
9430 (EmitContext.ConstantCheckState): Likewise.
9431 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9432 helper that implement a save/restore stack for CheckState
9433 values. This is the only way to change check-state.
9434 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9435 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9436 (CheckedExpr.EmitBranchable): New forwarding method.
9437 (UnCheckedExpr): Likewise.
9438 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9439 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9440 (Checked.Resolve, checked.DoEmit): Likewise.
9442 2006-07-20 Miguel de Icaza <miguel@novell.com>
9444 * anonymous.cs: Cache the resolved anonymous delegate, and return
9445 this so that the ResolveTopBlock is only triggered once, not
9448 Currently we trigger ResolvetopBlock twice due to a first pass of
9449 argument check compatibility, and a second pass that does the
9452 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9454 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9456 * rootcontext.cs (Reset): Add helper_classes.
9458 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9461 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9464 2006-07-13 Miguel de Icaza <miguel@novell.com>
9466 * statement.cs (Lock): Handle expressions of type
9467 TypeManager.null_type specially. Fixes #78770
9469 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9471 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9474 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9476 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9477 for accessors as well.
9478 * ecore.cs (EventExpr): Add AccessorTable.
9480 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9483 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9484 for CS0122 where appropriate.
9485 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9487 (Filter): Assembly can be null in the case of top level attributes.
9489 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9493 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9494 is done at global level.
9496 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9498 A fix for #77002, Implemented TypeForwarder support.
9500 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9501 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9502 * typemanager.cs (): Add type_forwarder_attr_type.
9504 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9506 * report.cs: Add CS0469 warning.
9508 2006-06-21 Martin Baulig <martin@ximian.com>
9510 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9511 the `try'-block, so we also report CS0016 etc. there.
9513 2006-06-21 Martin Baulig <martin@ximian.com>
9516 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9518 2006-06-21 Martin Baulig <martin@ximian.com>
9520 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9521 also report CS1686 for parameters.
9523 2006-06-21 Martin Baulig <martin@ximian.com>
9525 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9526 instead of an error if the value is not implicitly convertible to
9527 the switch types; fixes #77964.
9529 2006-06-21 Raja R Harinath <rharinath@novell.com>
9532 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9533 FieldBuilder is null.
9536 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9537 'left' and 'right' before error-checking.
9539 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9541 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9543 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9544 (FieldExpr.DoResolve): likewise.
9545 (PropertyExpr.InstanceResolve): likewise.
9546 (EventExpr.InstanceResolve): likewise.
9548 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9550 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9551 attribute applicable tests for attribute argument.
9553 2006-06-02 Raja R Harinath <rharinath@novell.com>
9556 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9557 (Binary.OverloadResolve_PredefinedIntegral): New.
9558 (Binary.OverloadResolve_PredefinedFloating): New.
9559 (Binary.OverloadResolve_PredefinedString): New.
9560 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9561 Follow the standard more closely, and treat numeric promotions in
9562 terms of overload resolution.
9563 (Binary.CheckShiftArguments): Simplify.
9565 2006-06-01 Raja R Harinath <rharinath@novell.com>
9567 * flowanalysis.cs (MyBitVector): Simplify representation.
9568 (MyBitVector.Clone): Avoid allocating BitArray.
9569 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9570 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9571 (*): Update. Change all references to MyBitVector.And and
9572 MyBitVector.Or to &= and |=.
9574 2006-05-29 Raja R Harinath <rharinath@novell.com>
9577 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9578 to param arguments too.
9580 2006-05-26 Miguel de Icaza <miguel@novell.com>
9582 * cs-parser.jay: Catch another parsing form for arglist being
9583 followed by other arguments. Fixes #78313.
9585 2006-05-24 Raja R Harinath <rharinath@novell.com>
9587 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9588 checking of out parameters to ...
9589 (FlowBranchingToplevel.Merge): ... here.
9590 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9591 set, propagate the origin upward, and only complain if there was
9593 (FlowBranchingException.AddContinueOrigin): Likewise.
9594 (FlowBranchingException.AddReturnOrigin): Likewise.
9595 (FlowBranchingException.AddGotoOrigin): Likewise.
9597 2006-05-23 Raja R Harinath <rharinath@novell.com>
9599 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9600 unreachable, skip it.
9601 (FlowBranchingException.Merge): Always propagate jumps, even if
9602 the finally block renders subsequent code unreachable.
9604 2006-05-18 Raja R Harinath <rharinath@novell.com>
9607 * statement.cs (Goto.Resolve): Move responsibility for resolving
9608 'goto' to FlowBranching.AddGotoOrigin.
9609 (Goto.SetResolvedTarget): New. Callback to set the
9610 LabeledStatement that's the target of the goto.
9611 (Goto.DoEmit): Use Leave instead of Br when crossing an
9612 unwind-protect boundary.
9613 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9614 LookupLabel and adjust to new semantics.
9615 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9616 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9617 Goto.SetResolvedTarget to update target.
9618 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9619 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9620 AddBreakOrigin & co. Delay propagation until ...
9621 (FlowBranchingException.Merge): ... this.
9623 * statement.cs (Block.Resolve): Always depend on flow-branching to
9624 determine unreachability. Kill workaround that originally emitted
9625 only one statement after an "unreachable" label (see infloop in
9628 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9629 This is still "wrong", but anything better would probably need a
9630 multi-pass algorithm.
9631 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9632 usage vector. Force current usage vector to be reachable, to
9633 optimistically signify backward jumps.
9634 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9636 (FlowBranchingLabeled.Merge): New. If no backward jump was
9637 detected, return the original salted-away usage vector instead,
9638 updated with appropriate changes. Print unreachable warning if
9640 * statement.cs (Block.Resolve): Don't print unreachable warning on
9641 a labeled statement.
9643 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9645 * driver.cs: Pass filename without path to AssemblyBuilder's
9646 AddResourceFile. Fixes bug #78407.
9648 2006-05-17 Raja R Harinath <rharinath@novell.com>
9650 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9651 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9652 (FlowBranching.MergeChild): Overwrite
9653 reachability information from Labeled branchings too.
9655 2006-05-16 Raja R Harinath <rharinath@novell.com>
9657 * statement.cs (Goto.Resolve): Merge jump origins here ...
9658 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9660 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9661 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9662 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9663 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9665 * statement.cs (Goto.Resolve): ... not here.
9666 (Goto.Emit): Remove CS1632 check.
9668 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9670 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9673 2006-05-11 Raja R Harinath <rharinath@novell.com>
9675 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9676 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9677 (FlowBranchingException.Label): Likewise.
9679 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9681 (MyBitVector.Or): Use it to avoid losing information (Count).
9682 (FlowBranching.MergeOrigins): Likewise.
9684 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9685 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9686 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9687 (UsageVector.ToString): Simplify.
9688 (UsageVector.MergeSiblings): Move here from ...
9689 (FlowBranching.Merge): ... here.
9690 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9693 2006-05-10 Raja R Harinath <rharinath@novell.com>
9695 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9696 null bitvector is treated as all-true.
9698 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9699 (MyBitVector): Rationalize invariants. 'vector != null' implies
9700 that we have our own copy of the bitvector. Otherwise,
9701 'InheritsFrom == null' implies all inherited bits are true.
9703 2006-05-09 Marek Safar <marek.safar@seznam.cz>
9705 * statement.cs (LocalInfo): Add IsConstant.
9706 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
9707 local variable for constants.
9709 2006-05-09 Raja R Harinath <rharinath@novell.com>
9711 * flowanalysis.cs (MyBitVector.Empty): New.
9712 (MyBitVector): Don't allow InheritedFrom to be null.
9713 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
9714 (UsageVector, FlowBranching): Update to changes.
9716 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
9717 recursion. The 'Parent == null' condition isn't sufficient for
9719 (FlowBranching.AddBreakOrigin): Likewise.
9720 (FlowBranching.AddContinueOrigin): Likewise.
9721 (FlowBranching.AddReturnOrigin): Likewise.
9722 (FlowBranching.StealFinallyClauses): Likewise.
9723 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
9724 (FlowBranching.CheckOutParameters): Likewise.
9725 (FlowBranchingToplevel): Terminate all the above recursions here.
9726 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
9727 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
9729 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
9731 (FlowBranchingToplevel): New. Empty for now.
9732 (FlowBranching.MergeTopBlock): Update.
9733 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
9734 branching for the anonymous delegate.
9735 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
9737 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
9738 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
9739 information at the start of the merge. Reorganize.
9741 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9743 * class.cs (MethodData.Define): Method cannot implement interface accessor.
9745 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9747 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
9748 to newly introduced ctor.
9750 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
9751 message to one place.
9752 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
9755 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9757 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
9759 * ecore.cs (Expression.ResolveAsConstant): Updated.
9761 * statement.cs (ResolveMeta): Updated.
9763 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9765 * cs-parser.jay: __arglist cannot be used in initializer.
9767 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9770 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
9773 2006-05-05 Raja R Harinath <rharinath@novell.com>
9775 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
9776 (LabeledStatement): Add 'name' parameter.
9777 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
9778 (Block.AddLabel): Update to changes.
9779 * cs-parser.jay (labeled_statement): Likewise.
9781 * flowanalysis.cs (BranchingType.Labeled): New.
9782 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
9783 (FlowBranchingLabeled): New. Does nothing for now, but will
9784 eventually handle 'goto' flows.
9785 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
9786 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
9787 that's terminated ...
9788 (Block.Resolve): ... here.
9790 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
9791 (UsageVector.MergeFinallyOrigins): Likewise.
9792 (FlowBranching.InTryOrCatch): Likewise.
9793 (FlowBranching.AddFinallyVector): Likewise.
9794 (FlowBranchingException): Update to changes.
9797 * statement.cs (Return.Resolve): Move error checking to ...
9798 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
9799 (FlowBranchingException): Handle return origins like break and
9801 (FlowBranching.UsageVector.CheckOutParameters): Remove.
9803 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9806 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
9809 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9812 * class.cs (MethodData.Define): Do public accessor check only when method
9813 implements an interface.
9815 2006-05-04 Raja R Harinath <rharinath@novell.com>
9817 Remove special handling of 'break'
9818 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
9819 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
9820 (UsageVector.Break): Remove.
9821 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
9823 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
9825 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
9826 UsageVector.Breaks (). Don't set NeedsReturnLabel.
9828 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9831 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
9832 be the interface member.
9834 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9837 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
9838 for emitting small (int) values.
9840 2006-05-03 Raja R Harinath <rharinath@novell.com>
9843 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
9844 control-flow passes through the 'finally' after merging-in all the
9845 control-flows from 'try' and the 'catch' clauses.
9847 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
9848 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
9849 always true at the only non-recursive entry point.
9850 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
9851 FlowBranchingBreakable.
9852 (FlowBranchingLoop): Remove.
9853 * statement.cs (Return.DoResolve): Update to changes.
9856 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
9857 (FlowBranching.CreateBranching): Handle it: create a
9858 FlowBranchingContinuable.
9859 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
9860 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
9861 except that it handles the 'continue' command.
9862 (FlowBranching.UsageVector.MergeOrigins): Rename from
9864 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
9865 except that it overrides AddContinueOrigin.
9866 (FlowBranchingException): Override AddContinueOrigin, similar to
9868 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
9869 Create a new branching around the embedded statement.
9870 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
9871 control flow after the embedded statement.
9872 (Continue.Resolve): Move all error checking to AddContinueOrigin.
9874 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
9875 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
9876 FlowBranchingBreakable.
9877 (FlowBranchingSwitch): Remove.
9880 * statement.cs (Break.Resolve): Simplify. Move responsibility for
9881 error reporting to ...
9882 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
9883 Rename from 'AddBreakVector'. Add new location argument. Return
9884 a bool indicating whether the 'break' crosses an unwind-protect.
9885 (FlowBranchingException.AddBreakOrigin): Add.
9886 (FlowBranchingException.Merge): Propagate 'break's to surrounding
9887 flowbranching after updating with the effects of the 'finally'
9889 (FlowBranchingBreakable): New common base class for
9890 FlowBranchingLoop and FlowBranchingSwitch.
9892 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
9894 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
9896 2006-05-02 Raja R Harinath <rharinath@novell.com>
9898 * statement.cs (Do.Resolve): If the loop is infinite, set the
9900 (While.Resolve, For.Resolve): Set a barrier after the embedded
9901 statement. There's no direct control flow that goes from the end
9902 of the embedded statement to the end of the loop.
9903 * flowanalysis.cs (FlowBranching.Infinite): Remove.
9904 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
9905 above ensure that the reachability is correctly computed.
9907 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
9908 (UsageVector.MergeBreakOrigins): If the current path is
9909 unreachable, treat it as if all parameters/locals are initialized.
9910 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
9911 infinite loops before merging-in break origins.
9913 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
9914 (Reachability.Reachable): Split part into ...
9915 (Reachability.Unreachable): ... this. Simplify.
9916 (Reachability.IsUnreachable): Use 'Unreachable' instead.
9918 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
9919 (Reachability.SetThrowsSometimes): Likewise.
9920 (FlowBranchingBlock.MergeTopBlock): Don't compare against
9921 TriState.Always, use corresponding property.
9922 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
9923 (Block.Resolve): Likewise. Remove some redundant checks.
9925 2006-05-02 Raja R Harinath <harinath@gmail.com>
9927 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
9928 (Reachability.Meet): Don't bother checking AlwaysThrows --
9929 barrier is always set.
9930 (FlowBranchingBlock.Merge): Likewise.
9932 2006-05-01 Raja R Harinath <harinath@gmail.com>
9934 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
9935 checks for unreachable.
9937 2006-05-01 Marek Safar <marek.safar@seznam.cz>
9940 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
9942 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
9943 whether field is really assigned.
9945 2006-04-30 Raja R Harinath <harinath@gmail.com>
9947 * flowanalysis.cs (Reachability): Make 4-argument constructor
9949 (Reachability.Meet): Rename from 'And'. Remove static variant.
9950 (Reachability.Always): Rename from the highly misleading
9951 'Reachability.Never'.
9952 (FlowBranching.Merge): Update to changes. Mark an impossible
9953 situation with a 'throw'.
9954 (*): Update to changes.
9956 2006-04-29 Raja R Harinath <harinath@gmail.com>
9958 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
9960 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
9961 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
9962 (*): Update to changes.
9963 * statement.cs: Update to changes.
9965 2006-04-28 Marek Safar <marek.safar@seznam.cz>
9968 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
9970 2006-04-28 Raja R Harinath <harinath@gmail.com>
9972 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
9975 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
9976 argument to two arguments: an usage-vector and a bool. Move call
9977 to FlowBranching.Merge () ...
9978 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
9980 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
9981 handling of loop and switch reachability to ...
9982 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
9984 2006-04-27 Raja R Harinath <harinath@gmail.com>
9986 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
9987 handling to FlowBranchingLoop.InLoop.
9988 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
9990 2006-04-26 Marek Safar <marek.safar@seznam.cz>
9993 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
9994 anonymous method is allowed from AnonymousContainer here.
9996 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
9998 2006-04-24 Raja R Harinath <rharinath@novell.com>
10001 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10003 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10006 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10007 (DoubleConstant.Reduce): Ditto.
10009 2006-04-23 Raja R Harinath <rharinath@novell.com>
10011 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10012 Remove 'lvalue_right_side' argument. Move parts to ...
10013 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10014 (LocalVariable.DoResolveLValue): ... these.
10016 2006-04-21 Raja R Harinath <rharinath@novell.com>
10019 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10020 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10021 (LocalVariableReference.DoResolveBase): Use it to implement new
10023 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10024 (Argument.Resolve): Simplify. Move CS1510 check ...
10025 * ecore.cs (Expression.ResolveLValue): ... here.
10026 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10027 (PropertyExpr.DoResolveLValue): Likewise.
10028 (FieldExpr.Report_AssignToReadonly): Likewise.
10029 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10030 LValueMemberAccess or LValueMemberOutAccess on instance depending
10032 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10033 DoResolve as appropriate.
10035 2006-04-20 Raja R Harinath <rharinath@novell.com>
10038 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10039 implicit conversions on 'out' and 'ref' arguments.
10041 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10042 improve clarity. Remove dead code.
10045 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10046 (Catch.Resolve): Resolve VarBlock if it exists.
10048 2006-04-19 Miguel de Icaza <miguel@novell.com>
10050 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10051 twice, this was some residual code, the enumerator was emitted
10052 properly in the two branche of if later.
10054 2006-04-19 Raja R Harinath <rharinath@novell.com>
10056 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10057 cast is never an lvalue.
10058 (Cast.DoResolve, Cast.ResolveRest): Combine.
10059 (Argument.Emit): Simplify slightly. Move 'Expr is
10060 IMemoryLocation' check ...
10061 (Argument.Resolve): ... here.
10062 (Argument.Error_LValueRequired): Remove. Inline into only user.
10064 Simplifications. Fix cs0191-2.cs
10065 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10066 CS1649 and CS1651 to ...
10067 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10068 the actual selection of the error code and message to a lookup
10069 table. Add a dummy return value to simplify callsites.
10070 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10071 readonly fields of other instances of the same type. Move CS0197
10073 * expression.cs (Argument.Resolve): ... here. Simplify code.
10074 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10075 resolution of an out or ref argument. The code simplification
10076 above uses this invariant.
10078 2006-04-18 Raja R Harinath <rharinath@novell.com>
10080 Possibly fix #77752. Fix cs1690-[4-7].cs.
10081 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10082 CheckMarshallByRefAccess. Drop parameter.
10083 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10085 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10086 InstanceExpression.
10087 * report.cs (AllWarnings): Add CS1690.
10088 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10089 for ref access too.
10090 (LocalVariableReference.DoResolveBase): Update.
10092 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10094 * class.cs (MethodOrOperator): Moved common parts from method class.
10095 detect obsolete attributes.
10096 (Method.Define): Simplified as it reuses code from base.
10097 (Constructor.ValidAttributeTargets): Fixed issue found during
10099 (Destructor.ValidAttributeTargets): Fixed issue found during
10101 (Operator): Finished refactoring set off by #78020. Operator class is now
10102 ordinary method class.
10104 * anonymous.cs: Updated.
10106 * decl.cs (DeclSpace): Add IsGeneric
10108 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10110 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10112 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10114 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10115 detect obsolete attributes.
10116 (Method.CreateEmitContext): Moved to MethodOrOperator.
10118 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10121 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10122 customized exception to make crash detection easier.
10123 (MethodOrOperator): Started to work on new base class for methods and
10125 (Method): Derives from MethodOrOperator.
10126 (Constructor.Emit): Emits its own attributes.
10127 (AbstractPropertyEventMethod.Emit): Ditto.
10128 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10130 (Operator.Emit): It's temporary more tricky than should be.
10132 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10134 * report.cs (InternalErrorException): Add ctor with inner exception.
10136 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10139 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10142 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10145 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10148 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10150 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10151 attribute is present and Guid not.
10152 (Interface.ApplyAttributeBuilder): Ditto.
10154 * attribute.cs: Add error message.
10156 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10160 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10161 sources (it's composite) so hold them in extra array as they are used in
10162 Emit phase only. It worked in the previous versions by mistake.
10163 (Attribute.Emit): Emit attribute for more owners when exist.
10165 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10166 it has now different behaviour.
10168 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10170 * constant.cs (Constant.IsDefaultInitializer): New method.
10172 * class.cs: Updated.
10174 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10175 re-initialize default values. It saves KBs almost for every assembly.
10176 Thanks Zoltan for the idea.
10177 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10178 (ArrayCreation.DoResolve): Resolve only once.
10179 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10180 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10182 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10184 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10187 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10189 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10190 in an embedded statement too.
10192 2006-04-01 Raja R Harinath <rharinath@novell.com>
10195 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10197 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10201 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10204 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10206 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10208 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10211 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10212 LocalTemporary change.
10214 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10216 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10217 initializers optimization.
10218 (ClassOrStruct.TypeAttr): Moved from modifiers.
10219 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10220 (FieldBase.ResolveInitializer): Resolves initializer.
10221 (FieldBase.HasDefaultInitializer): New property.
10223 * cs-parser.jay: Removed message.
10225 * expression.cs (CompilerGeneratedThis): New specialization.
10227 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10229 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10231 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10233 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10235 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10236 be now EnumConstants only.
10238 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10240 * attribute.cs, driver.cs: Reset more caches.
10242 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10244 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10246 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10248 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10249 for easier reuse. Updated all overrides.
10250 (IntegralConstant): New base class for all integral constants.
10251 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10252 of the constant range, report custom error.
10253 (UIntConstant.Reduce): Fixed uint conversion.
10255 * ecore.cs, literal.cs: Reduce updates.
10257 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10261 * class.cs (Constructor.Define): Removed extra if for default ctors.
10262 A patch from Atsushi Enomoto.
10264 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10266 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10267 GetAttributableValue.
10269 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10272 * convert.cs (ImplicitConversionRequired): Error message moved to
10275 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10276 automatic implicit conversion of an output value.
10277 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10279 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10281 (TypeOf.GetAttributableValue): Add extra handling for object type.
10283 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10284 special error message.
10286 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10288 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10290 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10291 compatible with MS runtime.
10293 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10295 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10296 attribute arguments here.
10298 * class.cs (Indexer.Define): The check was moved to attribute class.
10300 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10302 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10303 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10306 2006-03-22 Raja R Harinath <rharinath@novell.com>
10308 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10309 mcs to keep code differences small.
10310 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10311 * typemanager.cs (parameter_default_value_attribute_type): New.
10312 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10315 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10317 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10319 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10321 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10323 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10326 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10328 * doc-bootstrap.cs : fix build.
10330 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10332 * expression.cs (StringConcat.Append): Issue a warning when empty string
10333 is going to append.
10335 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10337 * assign.cs (CompoundAssign.ResolveSource): Removed.
10339 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10342 * class.cs (TypeContainer.FindMethods): Removed.
10343 (TypeContainer.CheckMemberUsage): Made static.
10345 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10347 * constant.cs (CheckRange): Removed unused type argument.
10348 (CheckUnsigned): Removed unused type argument.
10350 * cs-parser.jay: Updated after MemberAccess clean up.
10351 Uses Length for empty string test.
10353 * cs-tokenizer.cs: Uses Length for empty string test.
10354 (IsCastToken): Made static.
10355 (is_hex): Made static.
10356 (real_type_suffix): Made static.
10358 * decl.cs (SetupCache): Made static.
10359 (OnGenerateDocComment): Removed unused ds argument.
10361 * delegate.cs (VerifyDelegate): Removed unused argument.
10363 * doc.cs: Uses Length for empty string test.
10365 * driver.cs: Uses Length for empty string test.
10367 * enum.cs (IsValidEnumType): Made static
10369 * expression.cs (EnumLiftUp): Removed unused argument.
10370 (ResolveMethodGroup): Ditto.
10371 (BetterConversion): Ditto.
10372 (GetVarargsTypes): Ditto.
10373 (UpdateIndices): Ditto.
10374 (ValidateInitializers): Ditto.
10375 (MemberAccess.ctor): Ditto.
10376 (GetIndexersForType): Ditto.
10378 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10380 * iterators.cs: Updated after MemberAccess clean up.
10382 * location.cs: Uses Length for empty string test.
10384 * namespace.cs: Uses Length for empty string test.
10386 * report.cs (CheckWarningCode): Made static.
10388 * statement.cs (LabeledStatement): Removed unused argument.
10390 * typemanager.cs (FilterNone): Removed.
10392 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10394 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10397 * class.cs: Updated.
10399 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10401 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10403 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10407 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10408 reporting, it's more tricky than I thought.
10410 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10414 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10416 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10417 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10418 Add more error reporting; Fixed issue with params.
10420 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10422 * cs-parser.jay: AnonymousMethod requires host container.
10424 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10426 2006-03-18 Raja R Harinath <harinath@gmail.com>
10428 * class.cs: Change 'TypeContainer ds' constructor argument to
10429 'DeclSpace parent'. Some classes were missed below due to
10430 different naming convention.
10432 * class.cs (MemberCore.Parent): Delete. This makes the
10433 ParentContainer changes below enforceable by the compiler.
10435 Treat pointers to enclosing declaration space as 'DeclSpace', not
10437 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10438 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10440 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10442 (Block.AddThisVariable): Likewise.
10443 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10444 (AbstractPropertyEventMethod.Emit): Likewise.
10445 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10446 (GetMethod.Define, SetMethod.Define): Likewise.
10447 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10448 (DelegateMethod.EmitMethod): Likewise.
10450 Fix regression test-partial-13.cs.
10451 Rationalize use of PartialContainer. Ensure that the partial
10452 class semantics can be tied to type-correctness, i.e., any
10453 violation will cause a compile error.
10454 * class.cs, const.cs: Access all fields that belong to class
10455 TypeContainer via ParentContainer. Arguments of EmitContexts and
10456 Resolve()-like functions still use 'Parent'.
10458 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10459 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10460 (PropertyMethod.CheckModifiers): Remove unused argument.
10461 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10464 2006-03-17 Raja R Harinath <harinath@gmail.com>
10466 Make semantics of PartialContainer simpler.
10467 * decl.cs (DeclSpace.IsPartial): Remove.
10468 * class.cs (TypeContainer.IsPartial): Likewise.
10469 (TypeContainer..ctor): Set PartialContainer to point to self.
10470 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10471 (TypeContainer.FindNestedType): Likewise.
10472 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10474 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10476 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10478 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10480 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10483 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10485 * class.cs (Operator.Define): An error for base conversion was not
10486 reported correctly.
10488 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10490 * iterator.cs : yield break is allowed in try statement which has
10491 catch clauses. Fixed bug #77767.
10493 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10495 A fix for #77593, #77574.
10497 * class.cs (MethodCore.CheckBase): Another if for operator.
10499 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10501 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10504 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10505 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10508 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10511 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10512 Updated after another emitcontext usage was clean up. It should help us to
10513 synchronize with gmcs easier.
10515 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10519 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10520 (Event.Define): ditto
10521 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10523 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10524 Removed redundant code and set NewSlot for Invoke method too.
10526 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10527 (Parameters.MergeGenerated): New method. Use this method when you merge
10528 compiler generated argument with user arguments.
10530 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10532 * attribute.cs (ResolveAsTypeTerminal): Removed.
10534 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10535 specialization for predefined types; 30% speed up.
10536 Finally placed obsolete check to right place.
10537 (Expression.ResolveType): Removed.
10539 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10540 Updated after ResolveType was removed.
10542 * expression.cs (Cast.ctor): Check void cast.
10543 (Binary.ResolveAsTypeTerminal): Is never type.
10544 (Conditional.ResolveAsTypeTerminal): Is never type.
10546 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10548 2006-03-01 Raja R Harinath <rharinath@novell.com>
10551 * expression.cs (ParameterReference.DoResolveBase): Change return
10553 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10557 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10560 * typemanager.cs (GetFullNameSignature): Don't nullref on
10561 protected accessors.
10563 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10565 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10566 these two separated members to simplify the code.
10567 (Attribute.Resolve): Refactored to use new fields and methods.
10568 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10569 implemented obsolete attribute checking.
10570 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10571 implemented obsolete checking again. It look line never ending quest ;-)
10572 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10574 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10576 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10578 *class.cs (Property.Define): Add RegisterProperty call.
10580 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10581 argument groups (only 2).
10583 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10584 encoding expression to arguments.
10585 (Expression.ExprClassToResolveFlags): Just turned to property.
10587 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10588 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10589 optimized as well as implemented support for zero-length attributes.
10591 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10592 Add caching of PropertyInfo's.
10594 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10596 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10597 error multiple times.
10599 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10601 New partial class implementation.
10602 A fix for #77027, #77029, #77403
10604 * attribute.cs (Attributable): Made attributes protected.
10606 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10607 the replacements of ClassPart and PartialContainer.
10608 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10609 (TypeContainer.AddInterface): Ditto.
10610 (TypeContainer.AddPartial): The main method for partial classes. It checks
10611 for errors and merges ModFlags and attributes. At the end class is added to
10612 partial_parts list.
10613 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10615 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10616 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10617 from the rest of partial classes.
10618 (TypeContainer.GetClassBases): Simplified.
10619 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10621 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10622 (TypeContainer.HasExplicitLayout): Uses Flags now.
10623 (PartialContainer): Removed.
10624 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10625 (StaticClass): Was merged with Class.
10626 (Class.GetClassBases): class and static class bases are verified here.
10627 (Class.TypeAttr): Added static attributes when class is static.
10628 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10629 (MemberBase): In some cases we need to call parent container for partial
10630 class. It should be eliminated but it's not easy now.
10632 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10634 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10635 partial classed to accumulate class comments.
10636 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10638 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10640 * driver.cs (MainDriver): Tree.GetDecl was removed.
10642 * modifiers.cs (Modifiers): Add partial modifier.
10644 * tree.cs (Tree.decl): Removed.
10645 (RootTypes): Started to use this class more often for root types
10648 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10652 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10653 external interface does not have an attribute.
10655 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10657 Another prerequisites for new partial classs implementation.
10659 * attribute.cs (Attribute.Equal): Implemented.
10660 (Attribute.Emit): Changed as attributes can be applied more than twice.
10661 (Attributes.Emit): Check for duplicate attributes here.
10663 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10664 as a parameter, clean-up.
10666 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10670 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10671 contains obsolete attribute check which can in some cases look for base
10672 type of current class which is not initialized yet.
10673 (TypeContainer.BaseType): Replacement of ptype.
10675 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10677 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10679 First of prerequisites for new partial classs implemention.
10681 * attribute.cs (Attributable): Extended by ResolveContext;
10682 Attributes finally have correct context for resolving in all cases.
10683 (AttachTo): Attribute owner is assigned here.
10685 * codegen.cs (IResolveContext): Introduce new interface to hold
10686 all information needed in resolving phase.
10687 (EmitContext): Implements IResolveContext; more clean-up needed here.
10689 * decl.cs (MemberCore): Implemented IResolveContext.
10691 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10692 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10693 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10694 Refactored to use new IResolveContext instead of EmitContext; cleanup
10696 2006-02-06 Miguel de Icaza <miguel@novell.com>
10698 * codegen.cs (EmitScopeInitFromBlock): check here the
10699 capture_context, there is no need to make two calls to the
10702 * anonymous.cs: Add some debugging messages that might help me
10703 track other instances of this problem in the future (the
10704 regression of test 467).
10706 * cs-parser.jay: track the variable block, as we need to initalize
10707 any captured variables declared in this block for the "catch"
10708 portion of the "Try" statement.
10710 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
10711 scope initialization for captured variables.
10713 Also, move the emit for the variables after the block location has
10716 2006-02-06 Marek Safar <marek.safar@seznam.cz>
10718 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
10720 2006-02-02 Miguel de Icaza <miguel@novell.com>
10722 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
10723 commit yesterday, the initialization for the roots is necessary.
10724 What is not necessary is the scope activation.
10726 2006-02-02 Raja R Harinath <rharinath@novell.com>
10728 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
10729 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
10731 (Argument.Resolve): Remove CS0206 checks.
10733 2006-02-01 Miguel de Icaza <miguel@novell.com>
10735 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
10736 scopes for all the roots, the scopes will now be emitted when the
10737 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
10739 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
10740 code. This reduces a lot of existing cruft.
10742 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
10743 that the ScopeInfo is generated as we enter the scope, not at the
10744 time of use, which is what we used to do before.
10746 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
10747 every time a Block is about to be emitted if we have a
10750 2006-02-01 Raja R Harinath <rharinath@novell.com>
10752 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
10754 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
10756 * typemanager.cs (cons_param_array_attribute): Make private.
10757 (Reset): Set it to null.
10758 (InitCoreHelpers): Don't initialize it.
10759 (ConsParamArrayAttribute): New. Initialize it as needed.
10760 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
10762 2006-01-31 Miguel de Icaza <miguel@novell.com>
10764 * expression.cs: There might be errors reported during the
10765 selection of applicable methods. If there are errors, do not
10766 continue execution as it will lead the compiler to crash.
10768 2006-01-30 Miguel de Icaza <miguel@novell.com>
10770 * expression.cs: Member access is not allowed on anonymous
10771 methods. Fixes #77402.
10773 2006-01-30 Raja R Harinath <rharinath@novell.com>
10776 * cs-parser.jay (VariableDeclaration): Don't set
10777 current_array_type to null.
10778 (field_declaration, event_declaration, declaration_statement):
10779 Set it to null here.
10781 2006-01-28 Raja R Harinath <harinath@gmail.com>
10783 * typemanager.cs (GenericParameterPosition): New.
10786 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
10788 * doc.cs : To process "include" elements, first we should create
10789 another list than XmlNodeList, because it could result in node
10790 removal, which could result in that the XmlNodeList gives up
10791 yielding next node.
10793 (Also made code identical to gmcs again.)
10795 2006-01-25 Miguel de Icaza <miguel@novell.com>
10797 * ecore.cs: Introduce an error report that we were not catching
10798 before, if not silent, we must report the error. Gonzalo ran into
10801 2006-01-23 Miguel de Icaza <miguel@novell.com>
10803 A fix for bug: #76957
10805 * iterators.cs (MoveNextMethod.CreateMethodHost): call
10806 ComputeMethodHost before creating the method, this is a new
10809 * anonymous.cs (AnonymousContainer): Now we track all the scopes
10810 that this method references (RegisterScope). The actual scope
10811 where the method is hosted is computed with the ComputeMethodHost
10812 before we create the method.
10814 Moved the Deepest routine here.
10816 (AnonymousContainer.ComputeMethodHost): New routine used to
10817 compute the proper ScopeInfo that will host the anonymous method.
10819 (ScopeInfo): Deal with multiple roots. The problem was that we
10820 did not have a unique root where all ScopeInfos could be hanged
10821 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
10824 Remove AdjustMethodScope which is now computed at the end. Remove
10825 LinkScope which did a partial link, instead link all ScopeInfos
10826 before code generation from the new "LinkScopes" routine.
10828 Simplify all the Add* routines as they no longer need to maintain
10829 the tree, they just need to record that they are using variables
10832 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
10833 routines to produce the forest of ScopeInfo trees.
10835 * class.cs (TypeContainer.AppendMethod): This is just like
10836 AddMethod, but ensures that an interface implementation method
10837 (IEnumerable.XXX) is not inserted at the beginning of the queue of
10838 methods, but at the end.
10840 We use this functionality to ensure that the generated MoveNext
10841 method in the iterator class is resolved/emitted before the
10842 enumerator methods created.
10844 This is required because the MoveNext method computes the right
10845 ScopeInfo for the method. And the other methods will eventually
10846 need to resolve and fetch information computed from the anonymous
10849 2006-01-21 Raja R Harinath <harinath@gmail.com>
10850 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10852 Fix rest of #76995.
10853 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
10854 the 'aliases' hash.
10855 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
10856 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
10858 2006-01-18 Raja R Harinath <rharinath@novell.com>
10860 Fix #76656, cs0231-2.cs.
10861 * cs-parser.jay (formal_parameter_list): Make error case catch
10863 (parenthesized_expression_0): Add CS1026 check.
10864 (invocation_expression): Remove unused { $$ = lexer.Location }.
10866 2006-01-17 Raja R Harinath <rharinath@novell.com>
10869 * cs-parser.jay (statement_expression): Don't list out the
10870 individual statement-expressions. Convert syntax error into
10873 2006-01-16 Raja R Harinath <rharinath@novell.com>
10876 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
10877 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
10878 CheckIntermediateModification.
10879 (FieldExpr.DoResolve): Add new two-argument version that
10880 allows us to resolve the InstanceExpression as an lvalue.
10881 The one-argument variant is now just a wrapper.
10882 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
10883 Resolve the lhs as an lvalue if the it has a value type.
10884 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
10885 from Assign.DoResolve.
10886 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
10887 resolved as an lvalue.
10888 (PropertyExpr.DoResolve): Update.
10889 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
10890 has a value type. Move CS1612 check here from
10891 CheckIntermediateModification.
10892 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
10893 * expression.cs (EmptyExpression.OutAccess): New. Used as the
10894 'right_side' of a ResolveLValue on an 'out' argument.
10895 (EmptyExpression.LValueMemberAccess): New. Used as the
10896 'right_side' of a propagated ResolveLValue on a value type.
10897 (LocalVariableReference.DoResolveBase): Recognize
10898 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
10900 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
10901 EmptyExpression.Null.
10903 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
10905 * typemanager.cs : added IsGenericParameter(). In mcs it always
10907 * doc.cs : for generic parameters, use GenericParameterPosition,
10910 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
10912 * expression.cs: Fix Console.WriteLine ((this = x).foo);
10914 2006-01-12 Miguel de Icaza <miguel@novell.com>
10916 This fixes the problem where we used ldfld instead of ldflda to
10917 load the "THIS" pointer on captured parameters, when THIS is a
10918 value type. See bug #77205.
10920 * iterators.cs (CapturedThisReference.Emit): Pass false to
10921 EmitThis (we do not need the address).
10923 * codegen.cs (EmitThis): it needs to know whether we need the
10924 address of `this' or not. This is used by value types.
10926 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
10927 every other call passes false.
10929 2006-01-12 Raja R Harinath <rharinath@novell.com>
10932 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
10934 * expression.cs (Invocation.OverloadResolve): Update.
10935 (Invocation.DoResolve): Avoid double resolution of invocation.
10937 2006-01-11 Raja R Harinath <rharinath@novell.com>
10940 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
10941 unary negation of floating point types as 0-expr; negation cannot
10942 overflow in floating point types.
10945 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
10946 on operands of 'void' type.
10949 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
10950 and ExclusiveOr for boolean constants too.
10952 2006-01-09 Raja R Harinath <rharinath@novell.com>
10955 * expression.cs (Invocation.OverloadResolve): Replace reflected
10956 override methods with their base virtual methods, rather than
10957 skipping over them.
10958 * typemanager.cs (TypeManager.GetOverride): New.
10960 2006-01-05 Jb Evain <jbevain@gmail.com>
10962 * class.cs (Property.Define, Indexer.Define): do not tag the
10963 properties as SpecialName | RTSpecialName.
10965 2006-01-04 Miguel de Icaza <miguel@novell.com>
10967 * class.cs (MethodCore.IsDuplicateImplementation): This method was
10968 doing a low-level comparission of parameter types. It was lacking
10969 a check for __argslist.
10971 2005-12-30 Miguel de Icaza <miguel@novell.com>
10973 * expression.cs (ParameterReference.DoResolveBase): Allow
10974 reference parameters if they are local to this block.
10976 This allows the ref and out parameters of a delegate to be used in
10977 an anonymous method, for example:
10979 delegate void set (out int x);
10981 set s = delegate (out int x){
10985 This is used by functionality introduced late in the C# language.
10987 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
10988 method that take ref and out parameters.
10990 Fixes #77119 which was a late change in the spec.
10992 2005-12-23 Miguel de Icaza <miguel@novell.com>
10994 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
10995 parent if its the same scope. Fixes #77060.
10997 2005-12-21 Miguel de Icaza <miguel@novell.com>
10999 * driver.cs: Report the case of no source files and no -out:
11002 2005-12-20 Raja R Harinath <rharinath@novell.com>
11005 * expression.cs (ComposedCast.GetSignatureForError): Define.
11007 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11011 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11012 ListDictionary, to contain the ExternAliasEntry entries (in
11013 addition to the NamespaceEntry.aliases hashtable). This field is
11014 shared between the original entry and its doppelganger (bodyless
11016 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11017 extern_aliases field.
11018 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11019 lookup in extern_aliases.
11021 2005-12-16 Raja R Harinath <rharinath@novell.com>
11024 * class.cs (TypeContainer.Mark_HasEquals): New.
11025 (TypeContainer.Mark_HasGetHashCode): New.
11026 (ClassPart): Override them.
11027 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11030 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11031 'parent' argument to the base constructor.
11033 Remove all mention of TypeContainer from decl.cs.
11034 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11035 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11036 (DeclSpace.DeclSpace): Likewise.
11037 (DeclSpace.DefineMembers): Remove unused argument.
11038 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11039 debugging check -- we don't care if the debug code throws an
11040 InvalidCastException instead of an InternalErrorException.
11041 * class.cs (TypeContainer.DefineMembers): Update to changes.
11042 (TypeContainer.DoDefineMembers): Likewise.
11043 (TypeContainer.GetMethods): Likewise.
11044 (PropertyMember.Define): Likewise.
11045 (MemberBase.Parent): New property that forwards to
11046 MemberCore.Parent, but ensures that we get a TypeContainer.
11047 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11048 (RootContext.PopulateTypes): Likewise. Remove special case code
11049 for !RootContext.StdLib: DefineMembers is idempotent.
11051 2005-12-14 Miguel de Icaza <miguel@novell.com>
11053 * convert.cs (ExplicitConversionCore): Check the return value from
11054 ExplicitConversionCore which can return null on failure. Fixes #76914
11056 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11058 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11060 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11062 * doc.cs : The search for referenced namespace was insufficient to
11063 get global one as it used to do. Fixed bug #76965.
11065 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11067 * doc.cs : check name in cref in the last phase that whether it is
11070 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11072 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11075 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11077 * doc.cs : so it turned out that we cannot skip override check for
11078 interface members. Fixed bug #76954.
11080 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11082 * cs-tokenizer.cs : fixed bug #75984:
11083 - #warning and #error should not be handled when the source line
11085 - #line is not checked strictly when the source line is disabled.
11086 - #define and #undef is on the other hand checked strictly at any
11089 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11091 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11094 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11096 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11098 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11099 event initializers.
11100 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11101 (FieldBase.Initializer): Initializer is now optional.
11102 (EventField.Define): Only event field can have initializer.
11104 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11106 * const.cs (Const): Reuse initializer.
11108 * cs-parser.jay: Updated after FieldBase changes.
11109 Added current_array_type to simplify array initializers.
11111 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11113 * expression.cs, iterators.cs: Updated.
11115 * namespace.cs (NamespaceEntry): Made UsingFound private.
11117 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11119 * parameterCollection.cs: Obsolete, removed.
11120 * parser.cs: Obsolete, removed.
11122 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11125 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11127 * enum.cs (Enum.Define): Set obsolete context here.
11129 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11132 - FindDocumentedMember() now expects 1) paramList as null
11133 when "we don't have to check the number of parameters" and
11134 2) Type.EmptyTypes when "there is no arguments".
11135 - Introduced FoundMember struct to hold the exact type which was
11136 used to find the documented member (the above change broke
11137 test-xml-044; it might be better just to use DeclaringType than
11138 what MS does, like this change does, but it depends on usage.)
11140 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11142 * doc.cs : documented member might be from DeclaringType for nested
11143 types. Fixed bug #76782.
11145 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11147 * anonymous.cs: Have the param code handle leaving copies on the
11148 stack etc. Allows anonymous params to take part in the assignment
11149 code (++, +=, etc). Fixes bug #76550
11151 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11152 it down to the anon code.
11154 * iterators.cs: Use dummy var here
11156 * codegen.cs: Handle new vars
11158 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11161 * class.cs (MethodData.Define): Set proper Obsolete context.
11163 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11165 (FieldExpr.DoResolve): Ditto.
11167 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11170 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11171 parent is not obsolete.
11173 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11175 * doc.cs : (FindDocumentedMember) find parameterless members first
11176 and get CS0419 in the early stage. Fixed first case of bug #76727.
11178 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11181 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11182 no error was reported.
11184 *expression.cs (Binary.DoResolve): left can be null.
11186 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11189 * class.cs (MethodData.Emit): Parameters should be labeled first.
11191 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11194 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11196 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11198 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11200 * class.cs (MethodCore): Parameter clean up.
11201 (IMethodData): Added ParameterInfo.
11202 (MethodData): Parameter clean up.
11203 (Indexer.Define): Parameter clean up.
11215 * typemanager.cs: Parameter clean up.
11217 * delegate.cs (Define): Get rid of duplicated code.
11219 * expression.cs (ParameterReference): Removed useless parameters
11221 (Invocation): Ditto.
11223 * parameter.cs (ParamsParameter): New class, params specialization.
11224 (ArglistParameter): Attemp to separate arglist.
11225 (Parameter): Refactored to be reusable and faster.
11226 (Parameter.Modifier): Made understandable.
11227 (Parameters): Changed to be used as a class for `this' assembly
11228 parameters. Refactored to use new specialized classes.
11230 * support.cs (ParameterData): Added Types property.
11231 (InternalParameters): Deleted.
11233 2005-08-20 Martin Baulig <martin@ximian.com>
11235 Merging this patch from GMCS to fix #75867.
11237 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11238 scope if we don't already have it.
11240 2005-11-17 Martin Baulig <martin@ximian.com>
11243 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11244 inherit the scope from our parent. Fixes #76653.
11246 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11248 * doc.cs : the previous patch does not actually fix the bug.
11249 PropertyInfo override check is now implemented and really fixed it.
11250 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11252 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11254 * doc.cs : apply "override filter" also to properties.
11257 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11259 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11260 no need to check overrides. For classes, omit those results from
11261 interfaces since they must exist in the class. Fixed bug #76726.
11263 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11265 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11266 with different parameters. Fixed the second problem in #76685.
11268 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11270 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11271 get expected 'protected' access in CheckValidFamilyAccess()).
11274 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11276 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11277 Fixed bug #76705. CS1569 was incorrectly commented out.
11279 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11281 * doc.cs : use Invocation.IsOverride() to do real override check.
11282 * expression.cs : made Invocation.IsOverride() internal.
11284 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11286 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11287 TypeBuilder.FindMembers() and filter overriden base members out.
11290 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11292 * doc.cs : ref/out parameters are represented as '@' (instead of
11293 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11295 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11297 * doc.cs : when there was no '.' in cref to methods in doc comment,
11298 then parameters were missing in the output. Fixed bug #76691.
11300 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11302 * driver.cs : don't output docs when there is an error.
11305 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11308 Now it should detect indexers. Fixed primary concern in bug #76685.
11309 Fixed CS0419 message to not show the identical member signature in
11312 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11314 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11315 instead of Type.FindMembers() since it does not handle events.
11318 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11320 * codegen.cs: Fixed typo (speficied -> specified).
11322 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11325 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11327 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11329 * attribute.cs: Changed error message.
11331 * cs-tokenizer.cs: One more check.
11333 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11335 * statement.cs (Block.Resolve): Ignore empty statement.
11337 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11339 * report.cs: Made error/warning methods more strict to avoid
11342 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11343 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11344 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11345 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11347 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11349 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11350 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11352 * class.cs (TypeContainer.IsComImport): New property.
11353 (Constructor.Define): Create proper ctor for ComImport types.
11355 * expression.cs (New.CheckComImport): Fixed.
11357 2005-11-07 Miguel de Icaza <miguel@novell.com>
11359 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11360 that a parameter has been captured does not mean that we do not
11361 have to do the rest of the processing. This fixes the second part
11362 of #76592. If there was another anonymous method capturing
11363 values in the past, the Scope would never be set for the second
11364 method that captured the same parameter.
11366 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11367 properly manipulate the stack. Second part of fix for #76592.
11369 * expression.cs (New): Add support for invoking "new" on
11370 interfaces that have been flagged with the ComImport attribute and
11371 the CoClass. Fixes #76637
11373 * statement.cs (Try.DoEmit): When a variable is captured, do not
11374 try to emit the vi.LocalBuilder variable as it has been captured.
11375 Create a temporary variable and store the results on the
11376 FieldBuilder. Fixes #76642
11378 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11380 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11382 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11384 * expression.cs (Binary.DoResolve): Added && optimalization.
11386 * typemanager.cs (AddUserType): Removed useless argument.
11388 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11390 * statement.cs (Block.variables): Uses ListDictionary.
11392 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11395 * class.cs (PartialContainer.EmitType): Customized to emit
11396 security attributes.
11397 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11398 for partial classes.
11400 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11403 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11404 access has to be fixed.
11406 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11408 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11411 * ecore.cs (NullCast.Reduce): Implemented.
11413 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11416 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11418 (Foreach.Resolve): Catch null properly.
11420 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11422 * cs-tokenizer.cs: Warning text fix.
11424 * driver.cs: AllWarningNumbers exposed on public interface.
11426 * report.cs (): Reviewed warning numbers.
11427 (IsValidWarning): Use binary search.
11429 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11431 * driver.cs: Implemeted resource visibility.
11432 (Resources): New class for code sharing between /res: and
11435 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11438 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11441 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11444 * ecore.cs (NullCast): Child is contant only.
11446 * literal.cs (NullLiteral.Reduce): null can be converted to any
11449 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11451 * driver.cs: Use Encoding.Default as default code page instead
11454 2005-10-27 Raja R Harinath <rharinath@novell.com>
11457 * expression.cs (Invocation.Error_InvalidArguments): Handle
11458 __arglist parameters.
11459 (Invocation.VerifyArgumentsCompat): Likewise.
11460 * support.cs (ReflectionParameters.GetSignatureForError): Print
11461 __arglist parameters.
11462 (InternalParamters.GetSignatureForError): Likewise.
11463 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11465 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11467 * attribute.cs (GetPropertyValue): Made public.
11469 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11471 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11473 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11476 * driver.cs: Reflect method name change.
11478 * statement.cs (Try.Resolve): Warn when try has both general
11479 exception handlers.
11481 * typemanager.cs: runtime_compatibility_attr_type new predefined
11484 2005-10-26 Raja R Harinath <harinath@gmail.com>
11487 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11488 treat it as an empty parameter list.
11490 2005-10-26 Raja R Harinath <rharinath@novell.com>
11493 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11494 ResolveAsTypeStep silent.
11495 * statement.cs (Block.AddConstant): Mark block as used.
11496 (Block.ResolveMeta): Avoid piling on error messages
11497 if a constant initializer resolution fails.
11499 2005-10-25 Raja R Harinath <rharinath@novell.com>
11501 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11503 (NamespaceEntry.VerifyAllUsing): New.
11504 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11505 behaviour. Delegates actual resolution of alias to ...
11506 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11507 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11509 * driver.cs (Driver.MainDriver): Update.
11511 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11512 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11514 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11516 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11517 RootNamespace.DefineNamespacesForAll.
11519 2005-10-24 Raja R Harinath <harinath@gmail.com>
11521 * typemanager.cs (assemblies, external_aliases, modules)
11522 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11523 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11524 overhead. Move resposibility ...
11525 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11526 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11528 2005-10-23 Raja R Harinath <harinath@gmail.com>
11530 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11531 cached_namespaces. Improve usage.
11532 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11533 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11534 Move from GlobalRootNamespace and simplify.
11535 (RootNamespace.Global): Make instance variable.
11536 (RootNamespace.RootNamespace): Add "alias name" parameter.
11537 (GlobalRootNamespace): Simplify drastically.
11538 (Namespace.Lookup): Don't use GetNamespace.
11539 * typemanager.cs (GetRootNamespace): Rename from
11540 ComputeNamespaceForAlias.
11541 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11543 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11545 * anonymous.cs (AnonymousContainer): Don't crash when container
11548 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11550 * expression.cs (Binary.DoResolve): Warn when comparing same
11553 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11556 * expression.cs (Binary.DoResolve): It looks like there are no
11557 convetsion rules in enum context.
11559 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11561 Add support for extern alias qualifiers.
11562 * typemanager.cs: Move some LookupTypeReflection code
11563 to namespace.cs, to have cleaner code. Added some methods
11564 to help us keep track of the extern aliased references.
11565 * driver.cs: Add suport for extern alias assemblies on command
11566 line and check for their warnings/errors. Also keep track of the
11567 extern aliased assemblies.
11568 * namespace.cs: Move the global functionality of Namespace
11569 to GlobalRootNamespace/RootNamespace. Now the global namespace
11570 is GlobalRootNamespace.Globa. Also the code moved from
11571 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11572 Finally added LocalAliasEntry (AliasEntry before) and
11573 ExternAliasEntry, to handle alias statements.
11574 * cs-parser.jay: Add support in the grammar for extern alias
11576 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11577 Update callings to Namespace (now in GlobalRootNamespace).
11579 2005-10-18 Raja R Harinath <rharinath@novell.com>
11582 * class.cs (TypeContainer.DefineType): Move updating of
11583 topological sort earlier in the code.
11584 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11586 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11589 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11591 * constant.cs (Constant.TryReduce): Moved from Cast class.
11592 (Reduce): Made little bit more OO and fixed missing conversions.
11594 * ecore.cs (Reduce): Implemented.
11595 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11597 * literal.cs (Reduce): Implemented.
11599 * class.cs: Reverted Miguel's wrong commit.
11601 2005-10-14 Miguel de Icaza <miguel@novell.com>
11603 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11605 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11607 * cs-parser.jay, expression.cs : CS0214 was missing error location
11608 for constants. Fixed bug #76404.
11610 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11613 * convert.cs (ExplicitConversionCore): Fixed object->enum
11616 2005-10-10 Raja R Harinath <rharinath@novell.com>
11618 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11619 InstanceExpression.
11620 (PropertyExpr.EmitCall): Likewise.
11621 * expression.cs (Invocation.EmitArguments): Handle case where
11623 (Invocation.EmitCall): Avoid allocating temporary variable if
11624 there are no arguments.
11626 2005-10-07 Raja R Harinath <rharinath@novell.com>
11629 * convert.cs (ImplicitConversionStandard): Move conversion of
11630 void* to arbitrary pointer types ...
11631 (ExplicitConversionStandard): .. here.
11632 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11633 error to always print typenames.
11635 2005-10-07 Raja R Harinath <rharinath@novell.com>
11637 * convert.cs (GetConversionOperator): Rename from
11638 GetConversionOperators. Move operator selection code from ...
11639 (UserDefinedConversion): ... here.
11641 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11643 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11646 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11648 * assign.cs (Assign.DoResolve): Error method changed.
11650 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11652 * const.cs (ResolveValue): Reset in_transit immediately.
11654 * constant.cs: Error method changed.
11656 * convert.cs: Removed useless location parameter.
11657 (ExplicitNumericConversion): Don't do double enum check.
11658 (ExplicitConversionCore): Renamed from ExplicitConversion.
11659 (ExplicitUnsafe): Extracted from ExplicitConversion.
11660 (ExplicitConversion): Uses for error reporting.
11662 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11664 (ResolveBoolean): Uses common error method.
11665 (CastToDecimal): Get rid of ec.
11666 (CastFromDecimal): Optimized.
11667 (ConvCast): Get rid of ec.
11669 * enum.cs (ResolveValue): Reset in_transit immediately.
11670 (Emit): Return after first error.
11672 * expression.cs: Convert changes.
11674 * literal.cs: Error method changed.
11676 * statement.cs: Error method changed.
11678 2005-10-03 Raja R Harinath <rharinath@novell.com>
11680 * support.cs (SeekableStreamReader.Position): Don't error out when
11681 the requested position is just beyond the end of the current
11684 2005-09-28 Raja R Harinath <rharinath@novell.com>
11686 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11687 try to keep in sync with the byte count of the underlying Stream.
11688 However, this limits us to a window size of 2048 characters: i.e.,
11689 the maximum lookahead of our lexer/parser can be 2048 characters.
11691 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11694 * driver.cs: Fix compilation files with full root path.
11696 2005-09-25 Miguel de Icaza <miguel@novell.com>
11698 * report.cs (SymbolRelatedToPreviousError): Format the output so
11699 it does not use an open parenthesis that is never closed.
11701 * driver.cs: Follow coding guidelines
11703 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11706 * const.cs (Const.ResolveValue): Check for assigning non-null
11707 value to reference type.
11709 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11711 * anonymous.cs: Implemented ExprClassName.
11713 * assign.cs (Assign.DoResolve): Don't chrash when type is not
11716 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
11719 * class.cs (StaticClass.DefineContainerMembers): Report protected
11722 * codegen.cs: if(ed) PRODUCTION.
11724 * convert.cs (Error_CannotImplicitConversion): Better error
11727 * cs-parser.jay: More error checks.
11729 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
11731 * driver.cs (CSCParseOption): Enabled wrong option check.
11733 * ecore.cs (Expression.ExprClassName): Turned to property.
11734 (MemberExpr.CheckIntermediateModification): For checking boxed
11735 value types modification.
11737 * statement.cs (Fixed.Resolve): Expression type must be
11738 convertible to fixed type.
11739 (CollectionForeach.GetEnumeratorFilter,TryType):
11740 Small refactoring for easier error checking.
11742 2005-09-26 Marek Safar <marek.safar@seznam.cz>
11744 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
11747 * class.cs (GeneratedBaseInitializer): New class for customization
11748 compiler generated initializers.
11749 (MemberBase.DoDefine): Check Obsolete attribute here.
11750 (FieldMember.DoDefine): Ditto.
11752 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
11755 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
11756 (MemberCore.GetObsoleteAttribute): Removed argument.
11757 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
11758 (MemberCore.CheckObsoleteType): New helper.
11762 * statement.cs: Updates after MemberCore changes.
11764 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
11765 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
11767 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
11768 obsolete attribute for compiler construct.
11769 (As.DoResolve): Cache result.
11771 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
11773 2005-09-26 Raja R Harinath <rharinath@novell.com>
11776 * expression.cs (This.VerifyFixed): In a value type T, the type of
11777 'this' is T&, iow, 'this' is either an out or ref parameter. In a
11778 value type R, 'this' is treated as a value parameter.
11780 2005-09-22 Miguel de Icaza <miguel@novell.com>
11782 * statement.cs (Lock): Use the TemporaryVariable class instead of
11783 manually using local variables as those do not work when variables
11786 * ecore.cs: Moved the TemporaryVariable class from being a nested
11787 class inside Foreach to be a public class that can be employed in
11790 2005-09-19 Marek Safar <marek.safar@seznam.cz>
11792 * cs-parser.jay: interface_accessors replaced by
11793 accessor_declarations.
11795 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
11798 * statement.cs (GotoCase.Resolve): Convert null constant to
11800 (SwitchLabel.ResolveAndReduce): Ditto.
11801 (SwitchLabel.NullStringCase): Custom null stamp.
11802 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
11804 typemanager.cs (CSharpSignature): Don't skip first argument
11807 2005-09-18 Miguel de Icaza <miguel@novell.com>
11809 * driver.cs: Set InEmacs based on the environment variable EMACS.
11811 * location.cs (InEmacs): in this mode, do not report column
11812 location as it confuses Emacs.
11814 2005-09-16 Marek Safar <marek.safar@seznam.cz>
11816 * cfold.cs, constant.cs, convert.cs, ecore.cs,
11817 expression.cs, iterators.cs, literal.cs: Store constants and
11820 * class.cs (MemberBase.ShortName): Pass location.
11822 * cs-parser.jay: Some location fixes.
11824 * ecore.cs (Expression.Location): Made virtual.
11826 2005-09-05 Miguel de Icaza <miguel@novell.com>
11828 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
11829 if the underlying types are the same, otherwise we need to produce
11830 code that will do the proper cast.
11832 This was exposed by Marek's constant rewrite which produced
11833 invalid code for the call site:
11835 enum X : long { a }
11836 void Method (X v) {}
11840 This fixes test-49.cs
11842 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11844 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
11845 Type/Object should be allowed as well. Fixed bug #75968.
11847 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11849 * expression.cs : (Binary.DoResolve): when one is enum constant and
11850 another is constant 0, then return enum one *as enum type*.
11853 2005-09-02 Raja R Harinath <rharinath@novell.com>
11855 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
11859 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
11860 flow-branching for LocalVariableReferences in case we were invoked
11861 from a MemberAccess.
11862 * expression.cs (LocalVariableReference.VerifyAssigned): New.
11864 (LocalVariableReference.DoResolveBase): ... this.
11865 (MemberAccess.Resolve): Do the check that was disabled during
11868 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11871 (PartialContainer.Create): check abstract/sealed/static strictly
11872 but abstract/sealed can exist only at one side. Fixed bug #75883.
11874 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
11877 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
11878 specified, don't default to UnmanagedType.I4.
11880 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11882 * expression.cs : conditional operator should check possibly
11883 incorrect assign expression. Fixed bug #75946.
11885 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11887 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
11888 Reverting the change. gmcs is much complex than mcs on this matter.
11890 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11892 * cs-tokenizer.cs : To read another token ahead of the actual
11893 consumption, use new SavedToken and cache token instead of moving
11894 back the stream with SeekableStreamReader (it seemed problematic).
11896 driver.cs : Thus use StreamReader directly.
11897 * support.cs : Thus removed SeekableStreamReader.
11899 2005-08-30 Raja R Harinath <rharinath@novell.com>
11902 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
11903 (ScopeInfo.EmitScopeType): Use it to construct field names from
11904 names of captured locals.
11907 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
11908 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
11909 Pass 'target_type' to BoxedCast. Don't default to 'object'.
11910 (ExplicitConversion): Remove enum cases already handled by
11911 implicit conversion. Move implicit conversion check to the beginning.
11912 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
11913 * expression.cs (ArrayCreation.EmitDynamicInitializers):
11914 Don't treat System.Enum as a struct.
11916 2005-08-30 Jb Evain <jbevain@gmail.com>
11918 * attribute.cs: handles as expression in parameters.
11920 2005-08-30 Raja R Harinath <rharinath@novell.com>
11923 * class.cs (TypeContainer.VerifyClsName): Don't use a
11924 PartialContainer when verifying CLS compliance.
11925 (AbstractPropertyEventMethod): Set Parent here, ...
11926 (PropertyMethod): ... not here.
11928 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
11930 * attribute.cs : escaped attribute name should not be allowed to be
11931 resolved (e.g. @class as classAttribute). Fixed bug #75930.
11933 2005-08-29 Raja R Harinath <rharinath@novell.com>
11936 * convert.cs (ImplicitStandardConversionExists): Allow zero also
11937 when converting a long constant to unsigned long.
11938 * expression.cs (Invocation.OverloadResolve): Add sanity check to
11939 detect where IsApplicable and VerifyArgumentsCompat disagree.
11941 2005-08-29 Raja R Harinath <rharinath@novell.com>
11942 and Carlos Alberto Cortez <carlos@unixmexico.org>
11945 * class.cs (TypeContainer.CanElideInitializer): New helper.
11946 (TypeContainer.EmitFieldInitializers): Use it to determine if we
11947 can safely emitting the initializer of a field.
11949 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11951 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
11952 allowed inside a switch (without loop). Fixed bug #75433.
11954 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
11956 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
11957 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
11959 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11961 * driver.cs : kinda reverting the default encoding changes (not exact
11962 revert since I noticed that "codepage:reset" might not work fine).
11964 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11966 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
11967 Location. Now getter and setter store location correctly.
11968 (errors/cs0111-12.cs now reports the expected location.)
11970 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11972 * driver.cs : Use default encoding on the environment.
11973 Removed (now that) extra parameter for SeekableStreamReader.
11974 * support.cs : (SeekableStreamReader) third .ctor() argument for
11975 StreamReader is not required (always true). preamble size could
11976 be acquired in simpler and safe way.
11978 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
11980 * cs-parser.jay: report CS0642 at warning level 3
11981 and report CS0642 for an if else statement also
11982 fixes bug #74745. Patch by John Luke (and a bit
11984 Removed extra CS0642 warning check for "while",
11986 * statement.cs: In Block.Resolve(), CS0642 check
11987 is reimplemented to check a sequence of an empty
11988 statement and a block.
11990 Both fix bug #66777.
11992 2005-08-24 Marek Safar <marek.safar@seznam.cz>
11994 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
11995 detection until I fix it.
11997 * cs-tokenizer.cs: Changed error message.
11999 * cs-parser.jay: Fixed 2 error locations.
12001 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12002 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12005 * enum.cs (GetSignatureForError): Fixed.
12007 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12011 * typemanager.cs (RegisterProperty): Removed.
12013 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12015 2005-08-24 Raja R Harinath <rharinath@novell.com>
12018 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12019 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12021 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12023 * expression.cs : tiny fix is required for not warning positive ulong.
12026 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12028 * expression.cs : add CS0652 check for constant and integral
12029 expression. Fixed bug #53974.
12031 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12033 * expression.cs : in DoNumericPromotions(), check if there is implicit
12034 conversion overload for string (to check CS0034). Fixed bug #52492.
12036 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12038 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12040 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12042 * ecore.cs : report location when it is *not* Null.
12044 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12050 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12051 correctly. Fixed bug #75721.
12053 2005-08-23 Raja R Harinath <rharinath@novell.com>
12055 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12056 loop that performs 'min (pos, char_count)'.
12059 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12060 converted value in Operator.OnesComplement.
12062 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12064 * anonymous.cs: If the anon method is pulled into a helper class,
12065 it needs to be `internal' not `private'. Fixes runtime behavior on
12068 2005-08-20 Martin Baulig <martin@ximian.com>
12070 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12071 scope if we don't already have it.
12073 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12074 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12077 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12080 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12081 is a partial class.
12083 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12085 The big constants rewrite
12086 Fix #75746, #75685 and more
12087 As a side effect saved 1MB for MWF ;-)
12089 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12090 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12091 enum based for corlib compilation.
12093 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12096 * class.cs (FixedField.Define): Use ResolveAsConstant.
12098 * const.cs (IConstant): Interface constants and enums.
12099 (Const.ResolveValue): New method for constant resolvning.
12100 (ExternalConstant): Constants from imported assemblies.
12102 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12103 conversion; like enums.
12104 (Constant.ToType): Converts this constant to different type.
12105 (Constant.Increment): Adds 1.
12107 * convert.cs (ImplicitConversionRequired): Simplified.
12109 * cs-parser.jay: Create EnumMember directly.
12111 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12113 * doc.cs (GenerateEnumDocComment): Removed.
12115 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12116 (ConvertIntLiteral): Removed.
12117 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12119 * enum.cs (EnumMember): Implement IConstant.
12120 (Enum.IsValidEnumConstant): Removed.
12121 (Enum.GetNextDefaultValue): Removed.
12122 (Enum.FindMembers): Updated.
12123 (Enum.GenerateDocComment): Iterate enum members.
12125 * expression.cs (Cast.TryReduce): Handle enums correctly.
12126 (New.Constantify): Made public.
12127 (MemberAccess.DoResolve): Removed contant specific if(s).
12129 * literal.cs (NullLiteral): Implement new abstract methods.
12131 * statement.cs (GotoCase.Resolve): Use new constant methods.
12132 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12134 * typemanager.cs (LookupEnum): Removed.
12135 (IsEnumType): Fixed to work with corlib.
12136 (RegisterConstant): Removed.
12137 (LookupConstant): Removed.
12138 (GetConstant): Changed to work with IConstant.
12140 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12142 * location.cs : Fixed overflown (>255) column number.
12144 2005-08-03 Raja R Harinath <rharinath@novell.com>
12146 First cut of the qualified-alias-member feature.
12147 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12149 * cs-parser.jay (DOUBLE_COLON): New token.
12150 (namespace_or_type_name): Add rule for recognizing
12151 qualified-alias-members.
12152 (primary_expression): Likewise.
12153 (element_access): Allow QualifiedAliasMember as a possible
12154 type-bearing expression.
12155 (local_variable_type, local_variable_pointer_type): Likewise.
12156 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12157 aliases in the current and enclosing namespace declarations.
12158 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12159 * decl.cs (MemberName.is_double_colon): New.
12160 (MemberName.MemberName): Add new constructor for alias-member.
12161 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12162 * expression.cs (QualifiedAliasMember): New expression type.
12164 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12166 * location.cs : it borked when no argument was specified.
12168 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12170 * location.cs : tiny ToString() format fix.
12172 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12174 * statement.cs : oops, it was missing.
12176 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12178 A set of fixes for precise line/column location.
12181 "token" field now holds a file/line "delta", a line number offset
12182 from the segment, and a column number. See also:
12183 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12184 December/009508.html
12185 Removed static IsNull. Use instance IsNull property instead.
12186 * cs-tokenizer.cs :
12187 For some tokens it stores Location. For Identifier it stores
12188 LocatedToken which is a pair of string name and location.
12189 Column numbers are adjusted only at getChar().
12191 Use Location.ToString() for reporting (it now contains column).
12193 Largely modified to use LocatedToken instead of
12194 string (IDENTIFIER), and to acquire Location from some tokens.
12195 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12196 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12198 Now MemberName holds Location. DeclSpace.ctor() receives Location
12199 as a parameter. Removed extra parameters to all derived classes.
12200 Replaced Location.IsNull() with instance property.
12201 * assign.cs, expression.cs :
12202 Added .ctor() overload that omits Location.
12204 Added "nameEscaped" flag that indicates the identifier was escaped
12205 in the source file. This fixes bug #57047.
12207 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12209 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12210 New method, looking for lo-case imported cls type.
12212 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12215 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12217 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12219 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12220 all_imported_types.
12221 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12223 Optimized to save 3.5 MB for SWF compilation.
12225 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12227 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12228 (PartialContainer.Create): Moved logic AddToContainer.
12229 (PartialContainer.MarkForDuplicationCheck): Shares name.
12231 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12234 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12236 (Namespace.GetSignatureForError): New method.
12238 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12239 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12241 2005-08-01 Raja R Harinath <rharinath@novell.com>
12244 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12245 member lookup rather than qualifier_type, since qualifier_type can
12248 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12250 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12253 2005-07-31 Miguel de Icaza <miguel@novell.com>
12255 * statement.cs: Copy the local exception into the exception
12256 captured local. Fixes 75674
12258 2005-07-31 Raja R Harinath <harinath@gmail.com>
12261 * expression.cs (Invocation.OverloadResolve): Don't report error
12262 CS1501 if error CS1502 has been reported.
12263 (New.DoResolve): Delegate CS1501 reporting to
12264 Invocation.OverloadResolve.
12267 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12268 invariant-meaning-in-block property in an enclosing block if
12271 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12273 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12274 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12275 (Switch.CheckSwitch): Just save 50kb for SWF.
12277 2005-07-27 Martin Baulig <martin@ximian.com>
12279 * anonymous.cs (CaptureContext.AddField): Added
12280 `AnonymousContainer am' argument; compute its toplevel scope if
12281 it's not already computed. Fixes #75649.
12283 2005-07-26 Raja R Harinath <rharinath@novell.com>
12286 * class.cs (Constructor.Emit): Reset block to null if the block
12289 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12291 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12293 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12295 * class.cs (MethodData.Define): Check whether accessor implementing
12296 interface is public.
12298 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12300 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12303 * namespace.cs (LookupType): Moved same type check to...
12305 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12306 with the same name.
12308 2005-07-21 Raja R Harinath <rharinath@novell.com>
12310 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12311 already found a typebuilder.
12312 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12313 MemberNames, not strings.
12315 * const.cs (Error_ExpressionMustBeConst):
12316 Rename from Error_EpressionMustBeConst.
12317 * const.cs, class.cs, statement.cd: Update.
12319 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12323 * const.cs (Const.LookupConstantValue): Report missing contant expression
12325 (Error_EpressionMustBeConstant): Only one error method.
12327 * class.cs, statement.c: Updated.
12329 2005-07-20 Raja R Harinath <rharinath@novell.com>
12331 * statement.cs (Block.Flags): Add back HasVarargs.
12332 (Block.flags): Make protected.
12333 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12335 * typemanager.cs (types, typecontainers, user_types): Remove.
12336 (UserTypes, TypeContainers): Likewise.
12337 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12338 (CleanUp, Reset): Update.
12339 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12340 (GetNestedType): Use Type.GetNestedType.
12341 (CoreLookupType): Take two arguments, the namespace and the
12342 basename of the type. Update to use the Namespace.Lookup
12344 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12345 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12346 string concatenation and substring matches.
12347 * class.cs, enum.cs, delegate.cs: Update to changes.
12349 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12351 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12352 Expression and made virtual.
12354 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12355 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12357 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12359 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12362 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12365 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12368 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12369 AssemblyCultureAttribute is not used on executable.
12372 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12374 2005-07-16 Raja R Harinath <rharinath@novell.com>
12377 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12378 New. Reports CS0252/CS0253.
12379 Mostly taken from preliminary patch by Duncak Mak.
12380 (Binary.DoResolveOperator): Store results of operator lookup.
12381 Use them to detect if we need to warn about unintended reference
12384 2005-07-15 Raja R Harinath <rharinath@novell.com>
12387 * namespace.cs (Namespace.Lookup): Add back location parameter.
12388 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12389 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12391 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12392 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12393 (Namespace.LookupType): ... this.
12394 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12396 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12397 purported to handle pointers.
12398 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12401 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12403 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12406 2005-07-15 Raja R Harinath <rharinath@novell.com>
12408 * namespace.cs (Namespace.Lookup): Drop location parameter.
12409 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12410 (NamespaceEntry.Lookup): ... this.
12411 (NamespaceEntry.Error_AmbiguousTypeReference):
12412 Move here from DeclSpace.
12413 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12415 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12416 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12417 Move to NamespaceEntry.
12418 * delegate.cs, expression.cs: Update to changes.
12420 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12422 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12423 CheckAttributeType and refactored.
12424 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12425 ResolveAsTypeTerminal error handling.
12426 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12428 (GetSignatureForError): Print errors in same way.
12431 * codegen.cs: Reflect attribute GetSignatureForError change.
12434 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12436 * namespace.cs (UsingEntry): Refactored to make fields private.
12439 statement.cs: Error_UnexpectedKind has extra parameter.
12441 2005-07-14 Raja R Harinath <rharinath@novell.com>
12443 * ecore.cs (IAlias): Remove.
12444 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12445 that implement the interface.
12446 * namespace.cs (Namespace): Likewise.
12447 (Namespace.declspaces): Renamed from 'defined_names'.
12448 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12449 DeclSpace instead of an IAlias.
12450 * tree.cs (Tree.AddDecl): Update.
12452 2005-07-12 Raja R Harinath <rharinath@novell.com>
12454 * statement.cs (Block.Flags); Remove HasVarargs.
12455 (Block.HasVarargs): Move to ToplevelBlock.
12456 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12457 (Block.Variables): Make protected. Initialize variable hashtable
12459 (Block.AddVariable): Update.
12460 (Block.Resolve): Update to changes.
12461 (ToplevelBlock.HasVarargs): New boolean.
12462 (ToplevelBlock.ThisVariable): Move here from Block.
12463 (ToplevelBlock.AddThisVariable): Likewise.
12464 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12465 * expression.cs (This.ResolveBase): Update to changes.
12466 (ArglistAccess.DoResolve): Likewise.
12468 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12471 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12473 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12474 not used and not used & assigned.
12475 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12477 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12480 * expression.cs (Is.DoResolve): null is never provided type.
12482 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12485 * cs-parser.jay: Less strict event error rule to catch more errors.
12487 2005-07-08 Martin Baulig <martin@ximian.com>
12489 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12490 gettter (allowed) or setter (not allowed).
12492 * class.cs (Accessor): Implement IIteratorContainer.
12493 (Accessor.Yields): New public field.
12494 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12495 per-accessor basis.
12498 (get_accessor_declaration, set_accessor_declaration): Set the
12499 `yields' flag on the accessor, not the property.
12500 (property_declaration): Do the iterators check on a per-accessor
12501 basis and not for the whole property.
12503 2005-07-08 Martin Baulig <martin@ximian.com>
12505 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12506 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12508 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12511 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12512 (ExtractSecurityPermissionSet): Cope with self referencing security
12513 attributes properly.
12515 * driver.cs (SetOutputFile): Made public property OutputFile.
12517 2005-07-07 Raja R Harinath <rharinath@novell.com>
12520 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12521 has_nonstatic_fields. Make into a FieldBase pointer.
12522 (TypeContainer.AddField): Add CS0282 check.
12523 (TypeContainer.EmitType): Update.
12525 2005-07-06 Miguel de Icaza <miguel@novell.com>
12527 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12528 compare if they start with __.
12530 2005-07-06 Raja R Harinath <rharinath@novell.com>
12532 * statement.cs (Switch.SwitchGoverningType): Only look at
12533 UserCasts that don't need implicit standard conversions to one of
12534 the allowed switch types (Fixes test-322.cs).
12535 (LocalInfo.Resolve): Re-enable sanity-test.
12537 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12539 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12541 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12543 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12545 2005-07-06 Raja R Harinath <rharinath@novell.com>
12548 * ecore.cs (SimpleName.GetSignatureForError): Add.
12549 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12550 (MemberAccess.GetSignatureForError): Add.
12552 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12554 The big error and warning messages review.
12584 * typemanager.cs: Updated.
12586 * class.cs: (MethodCore.SetYields): Moved here to share.
12587 (PropertyMethod.Define): Moved iterator setup here.
12589 * iterators.cs: Add orig_method to have full access to parent
12592 2005-07-05 Raja R Harinath <rharinath@novell.com>
12594 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12595 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12596 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12597 variable of struct type.
12598 * expression.cs (Unary.ResolveOperator): Update to change.
12599 (Indirection.VerifyFixed): Likewise.
12600 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12601 (ParameterReference.VerifyFixed): Value parameters are fixed.
12602 (This.VerifyFixed): Treat 'this' as a value parameter.
12603 * statement.cs (LocalInfo.IsFixed): Remove.
12605 2005-07-01 Martin Baulig <martin@ximian.com>
12607 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12608 `ec.EmitThis ()' to get the correct scope.
12610 2005-07-01 Martin Baulig <martin@ximian.com>
12612 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12613 instance is a ParameterReference; fixes #75299.
12615 2005-07-01 Martin Baulig <martin@ximian.com>
12617 Reverted Marek's latest patch (r46725):
12618 - it contains structural changes which are neither mentioned in
12619 the ChangeLog nor explained anywhere; for example the additional
12620 argument of EmitContext's and Iterator's .ctor's and the
12621 TypeContainer.DefineMembers() change.
12622 - structural changes like this should go in in seperate patches
12623 and not be hidden in a huge patch which just seems to affect
12624 warnings and errors.
12625 a big and hard to understand patch.
12626 - it breaks iterators and causes regressions, for instance in
12629 2005-06-30 Raja R Harinath <rharinath@novell.com>
12632 * expression.cs (Indexers.map): Remove.
12633 (Indexers.Append): Filter out inaccessible setters and getters.
12634 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12637 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12638 Refactored from ...
12639 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12640 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12641 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12642 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12644 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12647 * class.cs (FieldBase.GetInitializerExpression): One more field
12650 2005-06-28 Miguel de Icaza <miguel@novell.com>
12652 * pending.cs: Do not define a proxy if the base method is virtual,
12653 it will be picked up by the runtime (bug 75270).
12655 2005-06-08 Martin Baulig <martin@ximian.com>
12657 The big Iterators rewrite :-)
12659 * iterators.cs: Rewrite this to use the anonymous methods framework.
12661 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12662 before the TypeContainers; see 2test-21.cs.
12665 (TypeContainer.DefineType): Don't create a new EmitContext if we
12666 already have one (this only happens if we're an Iterator).
12667 (TypeContainer.Define): Also call Define() on all our iterators.
12668 (Method.CreateEmitContext): Added support for iterators.
12671 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12672 (AnonymousContainer.CreateMethodHost): Moved here from
12673 AnonymousMethod and made abstract.
12674 (AnonymousContainer.CreateScopeType): New abstract method.
12675 (AnonymousContainer.IsIterator): New public property.
12676 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12677 get the ScopeTypeBuilder rather than manually defining it here.
12678 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12681 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12682 before RootContext.DefineTypes().
12684 * codegen.cs (EmitContext.RemapToProxy): Removed.
12685 (EmitContext.CurrentAnonymousMethod): Changed type from
12686 AnonymousMethod -> AnonymousContainer.
12687 (EmitContext.ResolveTopBlock): Protect from being called twice.
12688 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12689 (EmitContext.EmitThis): Removed the iterators hacks; use the
12690 anonymous methods framework for that.
12693 (ToplevelBlock.Container): Make this a property, not a field.
12694 (ToplevelBlock.ReParent): New public method; move the
12695 ToplevelBlock into a new container.
12696 (Foreach.TemporaryVariable): Simplify.
12698 2005-06-05 Martin Baulig <martin@ximian.com>
12700 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12701 (Block.AddTemporaryVariable): New public method; creates a new
12702 `LocalInfo' for a temporary variable.
12703 (Block.EmitMeta): Create the LocalBuilders for all the temporary
12705 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
12706 non-iterator variables.
12708 2005-06-05 Martin Baulig <martin@ximian.com>
12710 * statement.cs (Foreach.TemporaryVariable): Create the
12711 LocalBuilder in the Emit phase and not in Resolve since in some
12712 situations, we don't have an ILGenerator during Resolve; see
12713 2test-19.cs for an example.
12715 2005-06-04 Martin Baulig <martin@ximian.com>
12717 **** Merged r45395 from GCS ****
12719 The big Foreach rewrite - Part II.
12721 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
12722 with `PropertyInfo ienumerator_getcurrent'.
12724 * codegen.cs (VariableStorage): Removed.
12727 (Foreach): Derive from Statement, not ExceptionStatement.
12728 (Foreach.CollectionForeach): New nested class. Moved all the code
12729 dealing with collection foreach here.
12730 (Foreach.ForeachHelperMethods): Removed.
12731 (Foreach.TemporaryVariable): Implement IMemoryLocation.
12733 2005-05-23 Martin Baulig <martin@ximian.com>
12735 * statement.cs (Try.DoResolve): Don't create a `finally' if we
12736 don't need to. Fix #75014.
12738 2005-05-20 Martin Baulig <martin@ximian.com>
12740 Merged r44808 from GMCS.
12742 * class.cs (TypeContainer.CircularDepException): Removed.
12743 (TypeContainer.DefineType): Removed the `InTransit' stuff.
12744 (TypeContainer.CheckRecursiveDefinition): Check for circular class
12745 (CS0146) and interface (CS0529) dependencies here.
12747 2005-06-21 Raja R Harinath <rharinath@novell.com>
12749 * expression.cs (Invocation.EmitCall): Fix initialization
12750 'this_call' to reflect current behaviour. Fix indentation.
12752 * convert.cs (FindMostEncompassedType): Add two trivial special
12753 cases (number_of_types == 0 || number_of_types == 1).
12754 (FindMostEncompasingType): Likewise.
12756 2005-06-17 Raja R Harinath <rharinath@novell.com>
12758 Some cleanups preparing for the fix of #75283.
12759 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
12761 (EventExpr.InstanceResolve): Likewise.
12762 (EventExpr.DoResolve): Remove redundant checks.
12764 2005-06-10 Duncan Mak <duncan@novell.com>
12766 * cs-tokenizer.cs (process_directives): New flag for controlling
12767 the processing of preprocessor directives.
12768 (x_token): After seeing a '#', return Token.NONE instead of going
12769 to handle_preprocessing_directive() when not processing
12770 directives. This avoids unnecessary processing during the token peek in
12775 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
12776 the existing error reporting methods instead of Report.Error.
12778 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
12779 after Raja's rewrite.
12781 2005-06-08 Miguel de Icaza <miguel@novell.com>
12783 * class.cs: Small fix.
12785 2005-06-08 Raja R Harinath <rharinath@novell.com>
12788 * class.cs (GetPartialBases): Fix return value check of
12789 part.GetClassBases.
12791 2005-06-07 Raja R Harinath <rharinath@novell.com>
12793 Ensure that partial classes are registered in their enclosing
12794 namespace. Initial part of fix of #75160.
12795 * tree.cs (Tree.RecordDecl): Add new namespace argument.
12796 Register declspace with namespace here, not in
12797 DeclSpace.RecordDecl.
12798 * cs-parser.jay: Pass namespace to RecordDecl.
12799 * class.cs (PartialContainer.Create): Likewise.
12800 (ClassPart.DefineType): New sanity-check. Throws an exception if
12802 * decl.cs (Declspace.RecordDecl): Remove.
12803 * namespace.cs (NamespaceEntry.DefineName): Remove.
12805 2005-06-06 Marek Safar <marek.safar@seznam.cz>
12807 * rootcontext.cs: Reset TargetExt as well.
12809 2005-06-03 Raja R Harinath <rharinath@novell.com>
12811 * ecore.cs (Expression.Resolve): Emit CS0654 error when
12812 -langversion:ISO-1.
12814 2005-06-02 Raja R Harinath <rharinath@novell.com>
12816 Fix #75080, cs0119.cs.
12817 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
12819 (Expression.Resolve): ... this. Use it. Remove bogus code
12820 allowing ExprClass.Type and ExprClass.Namespace for
12821 ResolveFlags.VariableOrValue.
12822 (Expression.Resolve) [1-argument variant]: Change default resolve
12823 flags based on language version.
12824 (Expression.Error_UnexpectedKind): Use a simple string array
12825 rather than an ArrayList.
12826 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
12827 not ExprClass.Type.
12828 (TypeOfVoid.DoResolve): Likewise.
12829 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
12830 flags argument -- it always has the same value.
12832 2005-05-31 Raja R Harinath <rharinath@novell.com>
12835 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
12836 Use it in the error message.
12837 * assign.cs, expression.cs, statement.cs: Update.
12839 2005-05-30 Raja R Harinath <rharinath@novell.com>
12842 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
12843 the "almostMatchedMember" case too.
12844 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
12845 that failed the accessibility checks to 'almost_match'.
12847 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
12849 * attribute.cs: Use internal MethodBuilder methods to set
12850 ExactSpelling and SetLastError on PInvoke methods, instead
12851 of passing them via charset. Fixes #75060.
12853 2005-05-27 Raja R Harinath <rharinath@novell.com>
12855 * parameter.cs (Parameter): Remove TODO comment.
12856 (Parameter.DefineParameter): Remove Location parameter.
12857 (Parameters.LabelParameters): Likewise.
12858 * class.cs (Constructor.Emit): Update to change.
12859 (MethodData.Emit): Likewise.
12860 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
12861 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
12863 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
12866 Removed Parameters.Location and added Parameter.Location instead.
12867 Removed Location parameter from Emit() and GetSignature().
12874 Modified all related calls.
12876 2005-05-26 Raja R Harinath <rharinath@novell.com>
12878 Improve user-defined conversion handling.
12879 * convert.cs (GetConversionOperators): Rewrite. Return only the
12880 applicable operators.
12881 (AddConversionOperators): New. Helper for GetConversionOperators.
12882 (FindMostEncompassedType, FindMostEncompassingType): Verify that
12883 there is only one most encompassed/encompassing type.
12884 (FindMostSpecificSource, FindMostSpecificTarget): Remove
12885 "applicable operator" handling.
12886 (UserConversion): Move cache here from GetConversionOperators.
12887 Directly cache the chosen operator, rather than the whole
12889 (ExplicitNumericConversion): Fix buggy implementation of Decimal
12890 case. Allow conversion of decimal to sbyte and byte too.
12891 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
12892 New static methods. Used to avoid allocating EmptyExpressions in
12895 2005-05-24 Duncan Mak <duncan@novell.com>
12897 * ecore.cs (CastFromDecimal): New class for casting a decimal to
12898 another class, used in Convert.ExplicitNumericConversion.
12899 (CastToDecimal): New class, similar to above, but casts to
12900 System.Decimal, used in Convert.ImplicitNumericConversion and also
12901 in explicit convesion from double/float to decimal.
12903 * convert.cs (ImplicitNumericConversion): Handle implicit
12904 conversions to System.Decimal.
12905 (ExplicitNumericConversion): handle explicit conversions to
12910 2005-05-20 Miguel de Icaza <miguel@novell.com>
12912 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
12913 know the type at this stage, just break through. Fixes #75008
12915 2005-05-19 Martin Baulig <martin@ximian.com>
12918 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
12919 to disable error reporting.
12921 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
12922 here since we don't want to report an error; see the new test-336.cs.
12924 2005-05-19 Raja R Harinath <rharinath@novell.com>
12926 * statement.cs (ToplevelBlock.GetParameterReference)
12927 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
12928 Move here from class Block.
12929 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
12930 * expression.cs (ParameterReference.DoResolveBase): Likewise.
12932 2005-05-18 Martin Baulig <martin@ximian.com>
12937 (FlowBranching.Reachability): Add non-static public And() and Or()
12939 (FlowBranchingSwitch): New class; do the `break_origins' thing
12940 like in FlowBranchingLoop.
12941 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
12942 reachability, not just locals and parameters.
12943 (FlowBranching.MergeChild): Remove some of the hacks for loop and
12944 switch; MergeBreakOrigins() now takes care of that.
12946 2005-05-18 Martin Baulig <martin@ximian.com>
12948 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12949 a loop and may leave it, reset the barrier; fixes #74974.
12951 2005-05-17 Marek Safar <marek.safar@seznam.cz>
12953 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
12956 * cs-parser.jay: Catch more lexical errors.
12958 * report.cs: Add one more Error method.
12961 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
12963 2005-05-17 Martin Baulig <martin@ximian.com>
12965 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
12968 2005-05-16 Raja R Harinath <rharinath@novell.com>
12970 Fix test-382.cs. Emit values of decimal constants.
12971 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
12973 (TypeContainer.AddField): ... this.
12974 (TypeContainer.EmitFieldInitializers): Allow the list of fields
12975 with initializers to include 'Const's.
12976 (ClassPart.RegisterFieldForInitialization): Forward to
12978 * const.cs (Const.Const): Pass initializer to base class.
12979 (Const.Define): In case of decimal constants, register them for
12980 initialization in a static constructor.
12982 2005-05-14 Martin Baulig <martin@ximian.com>
12984 * statement.cs (Block.Resolve): Correctly handle unreachable code;
12985 do not call ResolveUnreachable() on unreachable statements in
12986 here, see the comment in the source code.
12988 2005-05-13 Raja R Harinath <rharinath@novell.com>
12991 * expression.cs (BinaryResolveOperator): If one of the operands of
12992 an equality comparison is 'null' and the other is a pointer type,
12993 convert the null to a NullPointer.
12994 * convert.cs (ImplicitReferenceConversion): If the expression is a
12995 NullLiteral and the target type is a pointer type, return a
12996 NullPointer instead.
12997 (ImplicitConversionStandard): Likewise.
12999 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13001 * cs-parser.jay: Set readonly context based on special constructs.
13003 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13004 readonly variable error handling.
13006 * rootcontext.cs (EmitCode): Don't verify members when error
13009 * statement.cs (LocalInfo): Add reaodnly context information.
13010 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13012 2005-05-13 Raja R Harinath <rharinath@novell.com>
13014 * statement.cs (Block.Resolve): Revert change below. Modify fix
13015 for #74041 to initialize 'resolved' to false only for explicit
13016 blocks. Fixes #74873.
13018 2005-05-12 Raja R Harinath <harinath@gmail.com>
13021 * typemanager.cs (unmanaged_enclosing_types): New.
13022 (IsUnmanagedType): Avoid infloops by using
13023 'unmanaged_enclosing_types' to talk with recursive invocations.
13025 2005-05-13 Martin Baulig <martin@ximian.com>
13027 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13028 instance variable, not a local. Fix #74873.
13029 (Block.ResolveUnreachable): Set it to true here.
13031 2005-05-11 Duncan Mak <duncan@novell.com>
13033 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13034 continuing to process for 'arg'.
13035 (handle_preprocessing_directive): Check the argument of the #endif
13036 directive and report error CS1025 if there are any trailing
13039 According to the C# spec, having even whitespace after the #endif
13040 directive is illegal; however, because we call arg.TrimEnd ()
13041 beforehand, we have the same behavior as csc, allowing whitespace
13042 after the directive.
13046 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13050 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13051 (Constructor.GetObsoleteAttribute): Implemented correctly.
13053 2005-05-10 Martin Baulig <martin@ximian.com>
13055 * support.cs (ReflectionParameters.ParameterModifier): Use
13056 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13057 and `ParameterAttributes.In'. Fixes #74884.
13059 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13061 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13063 * expression.cs (Argument.GetParameterModifier): Turned to property.
13064 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13066 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13069 2005-05-09 Raja R Harinath <rharinath@novell.com>
13072 * decl.cs (MemberCache.AddMethods): Register override methods,
13073 rather than non-override methods.
13074 * typemanager.cs (RegisterOverride): New.
13075 (IsOverride): Update.
13077 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13081 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13082 recursive declaration.
13084 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13086 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13088 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13090 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13092 2005-05-05 Raja R Harinath <rharinath@novell.com>
13095 * decl.cs (DeclSpace.FamilyAccessible):
13096 Use TypeManager.IsNestedFamilyAccessible.
13098 Fix reopened #64812.
13099 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13102 2005-05-04 Raja R Harinath <rharinath@novell.com>
13103 Abin Thomas <projectmonokochi@rediffmail.com>
13104 Anoob V E <projectmonokochi@rediffmail.com>
13105 Harilal P R <projectmonokochi@rediffmail.com>
13108 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13109 allow access to all static members.
13111 2005-05-04 Martin Baulig <martin@ximian.com>
13113 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13115 2005-05-04 Martin Baulig <martin@ximian.com>
13119 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13120 section at the end; make things work if `default' is not the last
13123 2005-05-04 Martin Baulig <martin@ximian.com>
13127 * statement.cs (Switch): Replaced the `got_default' field with a
13128 `default_section' one.
13129 (Switch.CheckSwitch): Set `default_section' here.
13130 (Switch.Resolve): If we're a constant switch and the constant is
13131 not found, use the default section.
13133 2005-05-03 Martin Baulig <martin@ximian.com>
13135 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13137 * statement.cs (Foreach.ArrayForeach): New nested class.
13138 (Foreach.TemporaryVariable): New nested class.
13139 (Foreach.EmitArrayForeach): Removed; this is now in the new
13140 ArrayForeach class.
13142 2005-05-03 Raja R Harinath <rharinath@novell.com>
13144 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13146 (VerifyPendingMethods): Revert change below.
13148 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13149 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13150 that used to trigger warning -28. Remove warning -28.
13151 * expression.cs (Invocation.OverloadResolve): Use
13152 TypeManager.IsOverride to distinguish override methods.
13155 * pending.cs (VerifyPendingMethods): If a base type implements the
13156 requested interface, don't bother checking individual methods of
13157 the base type. As a side-effect, this prevents the creation of
13158 unnecessary proxies.
13160 2005-05-02 Martin Baulig <martin@ximian.com>
13164 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13165 Also `And' the locals if the old vector is null.
13166 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13167 null; in this case we basically reset all the variables.
13169 2005-05-02 Martin Baulig <martin@ximian.com>
13173 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13174 Added `FlowBranching branching' argument; always `and' the
13175 variables instead of `or'ing them unless we're an infinite loop.
13177 * statement.cs (While.Resolve): Create a new sibling unless we're
13180 2005-05-02 Martin Baulig <martin@ximian.com>
13184 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13185 arguments; use it instead of creating a new TopLevelBlock.
13186 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13187 our ConstructorInitializer.
13190 (TopLevelBlock.TopLevelBranching): New public property.
13191 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13192 and create our `TopLevelBranching'.
13194 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13195 anonymous method host, use `block.TopLevelBranching' rather than
13196 creating a new branching.
13198 2005-04-20 Miguel de Icaza <miguel@novell.com>
13200 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13201 a ScopeInfo, if any of the current children is a child of the new
13202 entry, move those children there.
13204 2005-04-30 Martin Baulig <martin@ximian.com>
13206 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13207 at the beginning of a SwitchSection. Fix #73335.
13209 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13212 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13214 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13215 (FieldExpr.DoResolve): Obsolete members are ignored for field
13218 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13220 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13221 of arrays detection.
13223 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13225 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13227 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13230 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13232 * cs-parser.jay: Use the prefered version of -unsafe in error
13235 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13237 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13240 2005-04-20 John Luke <john.luke@gmail.com>
13242 * driver.cs: fix typo in error message, --outout to --output
13244 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13246 * codegen.cs (InRefOutArgumentResolving): New field.
13248 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13249 fields outside contructor.
13251 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13253 2005-04-19 Miguel de Icaza <miguel@novell.com>
13255 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13256 parameter code was not completed ever, so it was not as up-to-date
13257 as local variables. Must finish it.
13259 The bug fix was to compare the Toplevel of the block, not the
13260 current block. Thanks for Ben for pointing this out.
13262 2005-04-19 Raja R Harinath <rharinath@novell.com>
13264 * decl.cs (AddMethods): Use the declaring type of the problem
13265 method to determine if we want to squash a warning.
13267 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13269 * attribute.cs: Removed debug output.
13271 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13273 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13276 2005-04-18 Raja R Harinath <rharinath@novell.com>
13279 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13280 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13281 all null comparisons against reference types.
13283 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13286 * class.cs (TypeContainer.CircularDepException) New nested
13288 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13289 (TypeContainer.DefineType): Removed error, reset InTransit before
13291 (Class.DefineType): Throw exception when is in Transit.
13292 Catch exception and report error.
13293 (Struct.DefineType): Throw exception when is in Transit.
13294 Catch exception and report error.
13295 (Interface.DefineType): Throw exception when is in Transit.
13296 Catch exception and report error.
13298 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13299 handle nested exception handlers.
13301 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13304 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13305 InFinally and InCatch storage.
13307 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13308 (Catch.Resolve): Set and Restore ec.InCatch.
13309 (Try.Resolve): Set and Restore ec.InFinally.
13310 (Try.HasCatch): True when try has catch.
13312 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13314 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13315 for the same event member, so exclude such cases from warning 419.
13318 2005-04-16 Miguel de Icaza <miguel@novell.com>
13320 * expression.cs (Binary.ResolveOperator): Apply patch from John
13321 Luke to fix bug 59864: operators &, | and ^ on enumerations
13322 require that the same enum type on both sides.
13324 * driver.cs: Add warnings to old flag usage, this is to assist
13325 people who produce Makefiles and hope that the Makefiles will be
13328 * class.cs (TypeContainer.EmitType): Moved the definition of the
13329 special $PRIVATE$ field from the resolve phase to the Emit phase.
13330 During resolve we do not know if we are a struct with
13331 HasExplicitLayout, we know this only after the attributes for the
13334 Set the FieldOffset to zero on the dummy field that we create for
13335 the class. Fixes 74590.
13337 2005-04-16 Raja R Harinath <rharinath@novell.com>
13340 * ecore.cs (PropertyExpr.resolved): New.
13341 (DoResolve): Use it to handle a case of double resolution here.
13342 Handle a case of identical-name-and-type-name.
13343 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13344 resolution by storing the results of expression resolution back
13345 into the "probes" array.
13347 2005-04-15 Raja R Harinath <rharinath@novell.com>
13349 Fix cs0208-7.cs and cs0208-8.cs.
13350 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13351 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13352 error reporting to point out the reason a struct is not unmanaged.
13354 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13356 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13357 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13359 2005-04-13 Raja R Harinath <rharinath@novell.com>
13362 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13363 IdenticalNameAndTypeName here.
13364 (EventExpr.InstanceResolve): Likewise.
13366 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13368 C# 2.0 DefaultCharSetAttribute implementation
13370 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13371 which allows us to set GlobalNamespace for every resolve.
13372 (Attribute.ResolveArguments): Cut from Resolve.
13373 (Attribute.GetCharSetValue): Returns CharSet named argument.
13374 (Attribute.DefinePInvokeMethod): Gets default charset from
13376 (GlobalAttribute.ResolveAsTypeStep): Override.
13377 (GlobalAttribute.ResolveArguments): Override.
13379 * class.cs (TypeAttr): Is protected.
13381 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13382 (ModuleClass.DefaultCharSetType): New memeber.
13383 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13385 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13386 charset from module.
13388 * delegate.cs (TypeAttr): Override.
13389 (Delegate.DefineType): Use this TypeAttr.
13391 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13392 at very early stage (before types are defined) to resolve model
13393 module attributes. It will probably not work with corlib but it
13396 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13397 charset from module.
13399 * typemanager.cs (default_charset_type): New type.
13401 2005-04-13 Raja R Harinath <rharinath@novell.com>
13403 * decl.cs (MemberCache.AddMethods): Don't warn if
13404 System.Object.Finalize has buggy MethodAttributes.
13406 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13409 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13411 * doc.cs : detect ambiguous reference to overloaded members.
13412 Fixed bug #71603. MS 1.1 csc does not detect it.
13414 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13416 * doc.cs : delegates must not be referenced with parameters.
13419 2005-04-12 Miguel de Icaza <miguel@novell.com>
13421 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13423 2005-04-10 Miguel de Icaza <miguel@novell.com>
13425 * driver.cs (MainDriver): Stop processing if the CLS stage found
13428 (CompilerCallableEntryPoint.InvokeCompiler): Always
13429 reset after execution; Take a TextWriter argument for the
13432 * report.cs: Use the error stream instead of hardcoding stderr.
13434 2005-04-09 Miguel de Icaza <miguel@novell.com>
13436 * class.cs: Reduce code paths to test, too small of an
13437 optimization to make it worth the extra testing. Always perform
13440 2005-04-08 Raja R Harinath <rharinath@novell.com>
13443 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13444 operators that had errors reported on them.
13446 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13448 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13450 (Attribute.Resolve): Add named argument type checking.
13452 * class.cs (FixedField.Define): Use IsPrimitiveType
13454 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13456 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13457 unsafe parameter types.
13459 * statement.cs (Using.ResolveExpression): Add better error description.
13461 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13463 2005-04-08 Raja R Harinath <rharinath@novell.com>
13466 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13467 AttributeUsageAttribute in the emitcontext of the attribute class,
13468 not in the emitcontext of the attributable entity it was attached to.
13469 * cs-parser.jay: Use 'current_class', not 'current_container',
13470 when creating a GlobalAttribute.
13472 2005-04-08 Alp Toker <alp@atoker.com>
13474 * pending.cs: The fix to #58413 failed to compile methods implementing
13475 interfaces with/without params modifiers and vice versa, even though
13476 params modifiers aren't part of the signature. Make the modifier check
13477 less strict as in csc.
13479 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13480 Anoob V E <projectmonokochi@rediffmail.com>
13481 Harilal P R <projectmonokochi@rediffmail.com>
13484 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13485 modifiers of pending methods.
13486 (PendingImplementation.PendingImplementation): Initialize it.
13487 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13488 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13489 with ParameterData. Add check for modifiers.
13490 * class.cs (MethodData.Define): Update to changes.
13492 2005-04-07 Raja R Harinath <rharinath@novell.com>
13494 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13496 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13498 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13501 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13504 * typemanager.cs: Registered RequiredAttributeAttribute.
13506 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13508 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13509 Warning CS0169 is back at level 3.
13510 (IMethodData.SetMemberIsUsed): New method.
13512 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13513 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13515 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13517 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13519 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13522 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13525 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13526 to avoid the problems with nested types.
13528 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13529 Anoob V.E <projectmonokochi@rediffmail.com>
13530 Harilal P.R <projectmonokochi@rediffmail.com>
13531 Raja R Harinath <rharinath@novell.com>
13534 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13536 * typemanager (GetConstructor): Make public.
13538 2005-04-05 John Luke <john.luke@gmail.com>
13539 Raja R Harinath <rharinath@novell.com>
13542 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13543 struct too. Return false quicker in a few cases.
13544 (VerifyUnManaged): Use it.
13546 2005-04-05 Raja R Harinath <rharinath@novell.com>
13549 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13550 not 'unreachable_seen'.
13552 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13554 * attribute.cs (Attribute.GetValue): Removed unused.
13556 * codegen.cs (CodeGen.TrimExt): Removed unused.
13558 * cs-parser.jay (output): Removed unused.
13560 * cs-tokenizer.cs (hex_digits): Removed unused.
13562 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13564 * expression.cs (Indirection.LoadExprValue): Removed unused.
13565 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13567 * iterators.cs (Iterator.param_types): Removed unused.
13569 * statement.cs (Goto.block): Removed unused.
13570 (ToplevelBlock.did): Removed unused.
13571 (Switch.ResolveConstantSwitch): Removed unused.
13573 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13575 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13578 2005-04-01 Raja R Harinath <rharinath@novell.com>
13580 Fix #74232 and cs0208-3.cs.
13581 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13582 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13583 unmanaged type. Don't use FieldBuilders when 't' is a
13584 TypeBuilder. Use ModFlags and MemberType fields.
13585 * class.cs (MemberBase.member_type): Rename from MemberType.
13586 (MemberBase.MemberType): New property. Determines member_type on
13588 (MemberBase.DoDefine): Don't initialize MemberType here.
13589 (FieldMember.Define): Likewise.
13591 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13594 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13595 Attributes are emitted there.
13597 2005-04-01 Raja R Harinath <rharinath@novell.com>
13599 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13600 keyword in 'partial enum' too.
13601 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13603 Report from Kamil Skalski <nazgul@omega.pl>.
13606 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13607 have partial containers too.
13609 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13610 in block' checks to Block.CheckInvariantMeaningInBlock.
13611 * statement.cs (Block.GetKnownVariableInfo): Make private.
13612 (Block.IsVariableUsedInChildBlock): Remove.
13613 (Block.IsVariableUsedInBlock): Likewise.
13614 (Block.CheckInvariantMeaningInBlock): New. Show location of
13615 conflicting declaration.
13616 (Block.AddVariable): Make error messages less long-winded and more
13617 specific. Show location of conflicting declaration.
13618 * parameter.cs (Parameters.Location): New readonly property.
13620 2005-03-31 Raja R Harinath <rharinath@novell.com>
13622 Clean up semantics of invoking ResolveMemberAccess.
13623 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13624 can have an instance, ensure that we pass in a non-TypeExpression
13625 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13626 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13627 argument. Update to changes and simplify.
13628 (FieldExpr.Emitinstance): Remove CS0120 check.
13629 (PropertyExpr.EmitInstance): Likewise.
13630 * expression.cs (Argument.Resolve): Likewise.
13631 (Invocation.DoResolve): Update to changes in semantics of
13632 InstanceExpression.
13634 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13637 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13640 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13642 2005-03-31 Raja R Harinath <rharinath@novell.com>
13644 Fix difference in behaviour with commandline invocation.
13645 * driver.cs (Driver.Reset): New.
13646 (CompilerCallableEntryPoint): Call it.
13648 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13649 variable" warnings if the boolean expression failed to resolve.
13651 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13653 * attribute.cs: Fix the union of several permissions when some of them
13654 are unrestricted (so the result isn't an unrestricted permission set).
13657 2005-03-30 Raja R Harinath <rharinath@novell.com>
13659 * ecore.cs (MemberExpr): New class. Convert from interface
13661 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13662 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13664 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13665 (MethodGroupExpr.IsExplicitImpl): Remove.
13666 (Expression.GetFieldFromEvent): Remove.
13667 (SimpleName.MemberStaticCheck): Remove.
13668 (SimpleName.DoSimpleNameResolve): Update to changes.
13669 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13670 (MemberAccess.IdenticalNameAndTypeName): Remove.
13671 (MemberAccess.error176): Move to MemberExpr.
13672 (MemberAccess.DoResolve): Update to changes.
13673 (BaseAccess.DoResolve): Likewise.
13675 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13677 C# 2.0 Conditional attribute class implementation
13679 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13680 Analyzes class whether it has attribute which has ConditionalAttribute
13681 and its condition is not defined.
13683 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13684 (Class.IsExcluded): New method. Search for at least one defined
13685 condition in ConditionalAttribute of attribute class.
13687 2005-03-30 Raja R Harinath <rharinath@novell.com>
13689 * ecore.cs (PropertyExpr): Derive from Expression, not
13690 ExpressionStatement.
13691 (PropertyExpr.EmitStatement): Remove.
13693 2005-03-29 Raja R Harinath <rharinath@novell.com>
13696 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13697 internal field "value__" of an enum be private. The examples for
13698 "value__" that I found on MSDN all used FieldAttributes.Private.
13700 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13701 Don't mention IL method attribute names.
13703 Fix #47991. Remove a TODO.
13704 * statement.cs (Block.Toplevel): Make into a field.
13705 (Block.Parameters): Move into ToplevelBlock.
13706 (Block.known_variables): Rename from child_variable_names.
13707 (Block.Block): Remove variants that take Parameters. Initialize
13708 'Toplevel' with the immediately surrounding toplevel block.
13709 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
13710 LocalInfo parameter.
13711 (Block.GetKnownVariableInfo): New.
13712 (Block.IsVariableNameUsedInChildBlock): Update.
13713 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
13714 the block, even though it may not be in scope.
13715 (Block.AddVariable): Remove Parameters parameter. Use
13716 Toplevel.Parameters instead.
13717 (Block.AddConstant): Remove Parameters parameter.
13718 (Block.GetParameterReference): Update to use Toplevel.Parameters.
13719 (Block.IsParamaterReference): Likewise.
13720 (Block.IsLocalParameter): Likewise. Simplify a lot.
13721 (ToplevelBlock.Parameters): New. Moved from Block.
13722 (ToplevelBlock.ToplevelBlock): Update to changes. Always
13723 initialize Parameters to a non-null value.
13724 * cs-parser.jay: Update to changes.
13725 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
13726 simple names that mean different things in the same block. Use
13727 Block.IsVariableNameUsedInBlock.
13729 2005-03-28 Raja R Harinath <rharinath@novell.com>
13731 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
13732 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
13733 GetTypeHandle. It is possible for a reflected type to derive from
13734 a TypeBuilder (e.g., int[] derives from the TypeBuilder
13735 System.Array during mscorlib compilation).
13736 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
13737 contain a method_hash, don't create one either. Don't create a
13738 deep copy of the base cache's method_hash.
13739 (MemberCache.SetupCache): Rename back from DeepCopy.
13740 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
13741 already initialized. If we see an override function, add its
13742 underlying base virtual function to the member_hash too.
13744 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
13746 2005-03-26 Raja R Harinath <harinath@acm.org>
13749 * assign.cs (Assign.DoResolve): When the RHS of an assignment
13750 fails to resolve, ensure that the LHS is still resolved as an
13753 2005-03-25 Raja R Harinath <harinath@acm.org>
13755 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
13757 (Enum.current_ec): Remove.
13758 (Enum.LookupEnumValue): Remove EmitContext argument.
13759 Just uses the one created during DefineType.
13760 (Enum.FindMembers): Update.
13761 * expression.cs (MemberAccess.DoResolve): Update.
13763 2005-03-22 Marek Safar <marek.safar@seznam.cz>
13765 * assign.cs (Assign.DoResolve): Check for CS1717 when
13766 source and target are same (uses Equals).
13768 * expression.cs (LocalVariableReference, ParameterReference,
13769 This): Implemented Equals, GetHashCode.
13771 * statement.cs (Block.GetParameterReference): Removed useless
13774 2005-03-22 Raja R Harinath <rharinath@novell.com>
13777 * statement.cs (Block.AddVariable): Ensure that we skip implicit
13778 blocks before deciding whether the error is cs0136 or cs0128.
13780 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
13781 (using_alias_directive, using_namespace_directive): Pass
13782 MemberName, not an expression to Namespace.UsingAlias and
13784 (MakeName): Use the MemberName of the namespace.
13785 * namespace.cs (Namespace.MemberName): New.
13786 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
13787 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
13789 * decl.cs (MemberName.Name): Make readonly.
13790 (MemberName.FromDotted): New "constructor".
13791 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
13792 (MemberCore.Name): Compute from MemberName on demand.
13793 (MemberCore.SetMemberName): Provide a way to change the
13795 (MemberCore.AddToContainer): Don't take a fullname parameter.
13796 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
13797 fully qualified name of the container to the member name.
13798 (TypeContainer.AddToTypeContainer): Use a fully qualified name
13799 only if the type is a member of the root container.
13800 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
13801 MemberName.Left rather than searching for an embedded ".".
13802 (PartialContainer.CreatePart): Update to changes in RootContext.
13803 (MemberBase.ShortName): Turn into a property. Use
13804 MemberCore.SetMemberName.
13805 (MemberBase.ExplicitInterfaceName): Remove.
13806 (MemberBase.UpdateMemberName): Remove.
13807 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
13808 (PropertyBase.SetMemberName): New override.
13809 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
13810 (Tree.GetDecl): New.
13811 (Tree.AllDecls): Rename from Decls.
13812 * attribute.cs, enum.cs, report.cs: Update to changes.
13813 * driver.cs (MainDriver): Use MemberName.FromDotted on
13814 RootContext.MainClass.
13816 2005-03-21 Marek Safar <marek.safar@seznam.cz>
13818 * class.cs (FixedField.Define): Check for CS1664 and more sanity
13821 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
13823 2005-03-18 Marek Safar <marek.safar@seznam.cz>
13825 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
13826 property accessor modifiers.
13828 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
13829 fixed buffer attribute (CS1716).
13830 (PropertyMethod.HasCustomAccessModifier): When property accessor
13831 has custom modifier.
13833 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
13835 (PropertyExpr.DoResolveLValue): Add CS0272.
13837 2005-03-17 Miguel de Icaza <miguel@novell.com>
13839 * convert.cs: When converting to a pointer, use the proper Conv.U
13840 or Conv.I depending on the source data type.
13842 * cs-tokenizer.cs: Make the size for large decimal constants,
13845 2005-03-17 Martin Baulig <martin@ximian.com>
13847 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
13848 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
13850 2005-03-17 Martin Baulig <martin@ximian.com>
13852 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
13853 to bool so we can return an error condition.
13854 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
13857 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
13859 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
13862 2005-03-16 Raja R Harinath <rharinath@novell.com>
13864 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
13865 Refactor to avoid traversing the list of assemblies, and to avoid
13866 string concatenation.
13867 * typemanager.cs (guid_attr_type): Remove.
13868 (negative_hits, pointers, references): Remove hashes.
13870 (GetConstructedType): New. Uses type_hash to handle constructed
13871 types (arrays, references, pointers).
13872 (GetReferenceType, GetPointerType): Use it.
13873 (GetNestedType): New. Uses type_hash to handle nested types of
13875 (LookupType, LookupTypeDirect): Remove.
13876 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
13877 'types' hash and LookupTypeReflection directly.
13878 (params_string, params_object): Use GetConstructedType.
13879 * namespace.cs (Namespace.cached_types): New. Cache of reflected
13881 (Namespace.Lookup): Use cached_types.
13882 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
13883 provided by old TypeManager.LookupType.
13884 * rootcontext.cs (MakeFQN): Remove.
13885 * decl.cs (DeclSpace.MakeFQN): Likewise.
13886 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
13887 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13888 TypeManager.GetConstructedType.
13889 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
13891 2005-03-15 Marek Safar <marek.safar@seznam.cz>
13893 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
13896 * cs-parser.jay: Reports CS1527 for any namespace element.
13898 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
13901 * expression.cs (ParameterReference.IsAssigned): Changed error to
13903 (Error_WrongNumArguments): Moved CS0245 detection here.
13905 * statement.cs (Return.Resolve): Add CS1622 report.
13907 2005-03-11 Marek Safar <marek.safar@seznam.cz>
13909 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
13911 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
13913 * attribute.cs expression.cs: Get rid of some allocations.
13915 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
13917 * doc.cs : just eliminate the latest change.
13919 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13921 * doc.cs : commented out the latest change. It breaks xml-030.cs
13923 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13925 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
13926 fail. So invoke CreateType() in FindDocumentedType().
13928 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13930 * cs-tokenizer.cs : added IsKeyword().
13931 * doc.cs : Detect keyword incorrectly used as identifier.
13932 Allow identifiers prefixed by @.
13934 2005-03-10 Marek Safar <marek.safar@seznam.cz>
13936 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
13937 It caused exception in namespace resolving (again!).
13939 * class.cs (Class.ctor): Removed exit.
13940 (PropertyMethod.ctor): ditto.
13942 * codegen.cs (Codegen.Reset): Reset static data.
13943 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
13945 * cs-tokenizer.cs (Cleanup): Removed.
13947 * driver.cs (GetSystemDir): Rewrote to one line command.
13948 It caused problem with unloaded dynamic modules.
13949 (UnixParseOption): Removed Exit.
13950 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
13951 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
13952 Now can be mcs used as library.
13954 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
13957 * location.cs (Reset): Reset static data.
13959 * namespace.cs (Reset): Reset static data.
13961 * report.cs (Report.Reset): Reset static data.
13963 * rootcontext.cs (RootContext.Reset): Reset static data.
13965 * tree.cs (RootTypes.ctor): Use Location.Null
13967 * typemanager.cs (TypeManager.Reset): Reset static data.
13968 (CoreLookupType): Removed Exit.
13969 (TypeHandle.Reset): Reset static data.
13971 2005-03-10 Raja R Harinath <rharinath@novell.com>
13974 * typemanager.cs (ComputeNamespaces): Import namespaces from
13975 referenced modules too.
13977 2005-03-09 Raja R Harinath <rharinath@novell.com>
13979 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
13982 2005-03-09 Raja R Harinath <rharinath@novell.com>
13984 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
13985 enclosing DeclSpace. This ensures that a name-lookup populates
13986 more caches and there are fewer 'TypeExpression's. Carve out
13987 nested type lookup into ...
13988 (LookupNestedTypeInHierarchy): ... this.
13990 2005-03-09 Raja R Harinath <rharinath@novell.com>
13992 Clean up a few partial-class semantics.
13993 Fixes test-357.cs and cs1618-2.cs.
13994 * cs-parser.jay (struct_declaration): Use 'current_class' as
13995 parent of newly-created struct. Remove call to Register ().
13996 Use 'pop_current_class' to complete handing the current struct.
13997 (interface_declaration): Likewise.
13998 (class_declaration): Likewise.
13999 (enum_declaration): Use 'current_class' as parent of newly created
14001 (delegate_declaration): Likewise.
14002 (pop_current_class): New function. This is used to handle closing
14003 up the 'current_class' and 'current_container', and pointing them
14004 to the enclosing class/container.
14005 (CSharpParser): Initialize 'current_class' too.
14006 * decl.cs (MemberCore): Add check for invariant: a partial
14007 container is not a parsed entity, and thus does not enclose any
14009 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14010 (DeclSpace.BaseTypeExpr): Use it.
14011 (DeclSpace.LookupType): Add check for invariant.
14012 * class.cs (TypeContainer): Add check for invariant: a nested
14013 class should have the same NamespaceEntry as its enclosing class.
14014 (TypeContainer.EmitFieldInitializers): Make virtual.
14015 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14017 (TypeContainer.Register): Remove.
14018 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14019 null. Use TypeResolveEmitContext for resolving base types and
14020 interfaces. Move initialization of Parts.TypeBuilder here from
14022 (TypeContainer.DefineNestedTypes): ... here.
14023 (PartialContainer): Take a Namespace not a NamespaceEntry.
14024 (PartialContainer.Create): Don't use Register. Call the
14025 appropriate Add... function directly.
14026 (ClassPart): Take both the PartialContainer and the enclosing
14027 class as constructor arguments.
14028 (ClassPart.EmitFieldInitializers): Override.
14029 (ClassPart.PartFindNestedTypes): Remove.
14030 (FieldBase.GetInitializerExpression): Resolve the initializer
14031 expression in the emit context of the enclosing class.
14032 * tree.cs (RootTypes): Remove Register ().
14034 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14036 * cs-parser.jay: Removed CS0134.
14038 * driver.cs: Removed CS1901.
14040 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14041 for predefined types.
14043 2005-03-07 Duncan Mak <duncan@novell.com>
14045 * codegen.cs (Save): Catch UnauthorizedAccessException as
14046 well. Fixes bug #73454.
14048 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14050 * cs-tokenizer.cs (xtoken): Add CS1035.
14052 * class.cs (MethodData.Define): Add CS0683.
14053 (FieldMember.ctor): Add CS0681.
14055 2005-03-07 Raja R Harinath <rharinath@novell.com>
14057 * ecore.cs (SimpleName.DoResolve): Rename from
14058 SimpleName.DoResolveAllowStatic.
14059 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14060 Pass 'intermediate' flag to MemberStaticCheck.
14061 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14062 of "intermediate" lookups via MemberAccess.
14063 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14064 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14066 2005-03-07 Raja R Harinath <rharinath@novell.com>
14069 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14070 slipped in because of variable names that are identical to a
14071 builtin type's BCL equivalent ('string String;', 'int Int32;').
14072 (PropertyExpr.EmitInstance): Likewise.
14074 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14076 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14078 * report.cs (warning_ignore_table): Made public.
14080 2005-03-04 Raja R Harinath <rharinath@novell.com>
14083 * class.cs (MethodData.Emit): Pass 'container' to
14084 container.GetObsoleteAttribute instead of 'container.Parent'.
14086 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14088 * cs-parser.jay: Add 1534 error test.
14090 * iterators.cs (Yield.CheckContext): Add error 1629.
14091 (Iterator.ctor): Save unsafe modifier.
14092 (MoveNextMethod.DoEmit): Restore unsafe context.
14094 * namespace.cs (UsingAlias): Better error message.
14096 2005-03-03 Dan Winship <danw@novell.com>
14098 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14099 the warning message [#73219]
14101 2005-03-03 Raja R Harinath <rharinath@novell.com>
14103 Fix compile with MCS 1.0.0.0.
14104 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14105 w_restore to not depend on string constant folding.
14107 2005-03-03 Raja R Harinath <rharinath@novell.com>
14109 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14110 CS0246 check to users who passed 'silent = false'.
14111 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14113 (SimpleName.SimpleNameResolve): Update.
14114 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14115 (MemberAccess.IdenticalNameAndTypeName): Update.
14116 * doc.cs (FindDocumentedTypeNonArray): Update.
14118 2005-03-03 Raja R Harinath <rharinath@novell.com>
14120 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14121 * parameters.cs (ComputeAndDefineParameters): Remove.
14122 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14123 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14124 Use GetParameterInfo.
14126 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14128 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14130 2005-03-02 Raja R Harinath <rharinath@novell.com>
14132 Unify DeclSpace.LookupType and DeclSpace.FindType.
14133 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14134 is in charge of defining nested types on demand.
14135 (DeclSpace.LookupType): Use it when the current_type is a
14136 TypeBuilder. Use LookupTypeDirect for reflected types.
14137 (DeclSpace.FindType): Remove.
14138 (DeclSpace.LookupInterfaceOrClass): Likewise.
14139 (DeclSpace.DefineTypeAndParents): Likewise.
14140 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14141 DeclSpace.LookupType.
14142 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14143 * typemanager.cs (LookupType): Simplify.
14144 (AddUserType): Remove type from negative_hits.
14145 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14146 * class.cs (TypeContainer.FindMembers): Move handling of nested
14148 (TypeContainer.FindMembers_NestedTypes): ... here.
14149 (TypeContainer.FindNestedType): Implement override.
14150 (ClassPart.FindNestedType): Delegate to PartialContainer.
14151 (ClassPart.PartFindNestedType): Looks up the nested types of the
14154 2005-03-02 Martin Baulig <martin@ximian.com>
14156 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14157 static constructor in static classes.
14159 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14161 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14162 sizeParamIndex is not specified.
14164 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14167 * report.cs (WarningMessage.IsEnabled): Missing null check.
14169 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14171 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14172 in the fields and not in the properties.
14174 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14176 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14179 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14181 * attribute.cs: Small refactoring (improved robustness).
14182 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14183 (ValidateGuid): Removed.
14184 (Resolve): Removed referenced to above mentioned.
14185 (GetAttributeUsage): Made private and changed to work without
14187 (GetIndexerAttributeValue): Don't crash.
14188 (GetConditionalAttributeValue): Ditto.
14189 (GetClsCompliantAttributeValue): Ditto.
14190 (ExtractSecurityPermissionSet): All attributes exceptions are
14192 (GetPropertyValue): New helper.
14193 (GetMethodImplOptions): New method.
14194 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14195 some missing properties.
14197 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14198 (Method.ApplyAttributeBuilder): Updated.
14200 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14203 2005-02-28 Raja R Harinath <rharinath@novell.com>
14206 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14207 non-simple types (array, pointer, reference).
14209 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14211 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14213 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14215 (Method.CheckBase): Catch wrong destructor here.
14216 (MethodData.Define): Add errors 550, 668.
14218 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14220 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14222 * pending.cs (VerifyPendingMethods): Add error 551.
14224 * typemanager.cs (CSharpName): Next error report helper.
14226 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14228 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14229 attributes. Removed useless attribute double check.
14230 It saves almost 2MBs for corlib.
14232 2005-02-25 Raja R Harinath <rharinath@novell.com>
14235 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14236 called twice in case of error.
14238 2005-02-23 Chris Toshok <toshok@ximian.com>
14240 Fix compiler portions of #72827.
14241 * statement.cs (Block.Emit): call Begin/EndScope on the
14242 EmitContext instead of the ILGenerator.
14244 * codegen.cs (EmitContext.BeginScope): new method, call
14245 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14247 (EmitContext.BeginScope): same, but EndScope and CloseScope
14249 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14250 offset and call the superclass's OpenScope(int) with it.
14251 (SymbolWriter.CloseScope): get the current il
14252 offset and call superclass's CloseScope(int) with it.
14254 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14256 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14257 CS1677 for out and ref as well.
14259 * class.cs (Method.Define): Add error CS1599 detection.
14261 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14263 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14265 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14267 * support.cs.cs (ModifierDesc): New helper method.
14269 2005-02-23 Raja R Harinath <rharinath@novell.com>
14270 Abin Thomas <projectmonokochi@rediffmail.com>
14271 Anoob V E <projectmonokochi@rediffmail.com>
14272 Harilal P R <projectmonokochi@rediffmail.com>
14274 Fix #57851, #72718.
14275 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14276 MemberLookup (used for error reporting) actually returns a result.
14277 Fix error report number (122, not 112).
14279 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14280 Anoob V E <projectmonokochi@rediffmail.com>
14281 Harilal P R <projectmonokochi@rediffmail.com>
14284 * pending.cs (PendingImplementation.GetAbstractMethods):
14285 Find NonPublic members too.
14287 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14289 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14292 * class.cs (MethodCore.CheckMethodAgainstBase):
14293 Add error 239 report.
14295 2005-02-21 Raja R Harinath <rharinath@novell.com>
14298 * expression.cs (Invocation.IsApplicable): Make public.
14299 (Invocation.IsParamsMethodApplicable): Likewise.
14300 * delegate.cs (Delegate.VerifyApplicability): Don't use
14301 Invocation.VerifyArgumentCompat for parameter applicability
14302 testing. Use Invocation.IsApplicable and
14303 Invocation.IsParamsMethodApplicable.
14305 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14307 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14309 * class.cs (Operator.Define): Add error 217 report.
14311 2005-02-21 Raja R Harinath <rharinath@novell.com>
14313 * namespace.cs (UsingEntry.Resolve): Undo change below.
14315 2005-02-21 Raja R Harinath <rharinath@novell.com>
14318 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14319 disable the error message when the extended MemberLookup also
14321 (Expression.MemberLookupFinal): Update.
14322 (SimpleName.DoSimpleNameResolve): Update.
14323 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14324 Don't use MemberLookupFinal.
14325 (New.DoResolve): Update.
14326 (BaseAccess.CommonResolve): Update.
14328 2005-02-21 Raja R Harinath <rharinath@novell.com>
14331 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14332 occured previously, don't resolve again.
14334 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14337 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14338 argument. Call ResolveAttributeUsage for unresolved.
14339 when types doesn't match ctor arguments.
14341 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14342 for nested attribute classes.
14343 (Class.attribute_usage): Removed.
14344 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14345 for attribute class.
14347 * ecore.cs (IsAttribute): Removed.
14349 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14351 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14353 (attribute_types): Removed.
14354 (EmitCode): Global attributes are emited as the latest.
14356 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14358 * class.cs (EmitFieldInitializers): Don't emit field initializer
14359 for default values when optimilization is on.
14361 * constant.cs (Constant.IsDefaultValue): New property.
14363 * driver.cs: Add /optimize handling.
14367 * literal.cs: Implement new IsDefaultValue property.
14369 * rootcontext.cs (Optimize): New field, holds /optimize option.
14371 2005-02-18 Raja R Harinath <rharinath@novell.com>
14373 Fix crasher in re-opened #72347.
14374 * namespace.cs (Namespace.Lookup): Return null if
14375 DeclSpace.DefineType returns null.
14378 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14380 2005-02-18 Raja R Harinath <rharinath@novell.com>
14382 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14383 now returns null if it cannot resolve to an lvalue.
14384 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14385 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14386 returned null. Remove check for SimpleName.
14387 (EventExpr.DoResolveLValue): New.
14388 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14389 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14391 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14392 avoid CS0131 error.
14393 (Unary.ResolveOperator): Move CS0211 check ...
14394 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14396 (Unary.DoResolveLValue): Simplify.
14397 (AddressOf.DoResolveLValue): New.
14398 (ArrayAccess.DoResolveLValue): New.
14400 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14402 * attribute.cs (Attribute.Resolve): Add arguments casting for
14403 when types doesn't match ctor arguments.
14405 2005-02-16 Raja R Harinath <rharinath@novell.com>
14407 Fix parts of #63202.
14408 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14409 lookup of operator in base type. Ensure that all checks happen
14410 when the operator resolves to an "op_..." method.
14412 2005-02-15 Raja R Harinath <rharinath@novell.com>
14415 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14416 'ignore_cs0104' parameter. Pass it to ...
14417 (NamespaceEntry.Lookup): ... this.
14418 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14419 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14420 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14421 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14422 Update. Request that cs0104 errors be ignored.
14423 (ComposedCast.ResolveAsTypeStep): Update.
14425 2005-02-14 Raja R Harinath <rharinath@novell.com>
14428 * expression.cs (Invocation.BetterFunction): Remove support for
14429 comparing virtual functions and their overrides.
14430 (Invocation.IsOverride): New.
14431 (Invocation.OverloadResolve): Don't consider 'override' functions
14432 during candidate selection. Store them in a lookaside list.
14433 If the selected method is a 'virtual' function, use the list to
14434 find any overrides that are closer to the LHS type.
14436 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14438 * expression.cs (New.DoResolve): Add complex core type reduction.
14439 (New.Constantify): Converts complex core type syntax like 'new int ()'
14440 to simple constant.
14442 2005-02-14 Raja R Harinath <rharinath@novell.com>
14444 * decl.cs (EntryType.EntryType): New constructor to create an
14445 updated copy of a cache entry.
14446 (MemberCache.AddMethods): Use it.
14447 (MemberCache.ClearDeclaredOnly): Remove.
14448 (MemberCache.MemberCache): Update.
14450 2005-02-11 Miguel de Icaza <miguel@novell.com>
14452 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14453 variable. This one is represents the actual low-level declaration
14454 of the method, as opposed to the semantic level `IsStatic'.
14456 An anonymous method which is hosted into a static method might be
14457 actually an instance method. IsStatic would reflect the
14458 container, while MethodIsStatic represents the actual code
14461 * expression.cs (ParameterReference): Use the new MethodIsStatic
14462 instead of IsStatic.
14464 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14465 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14466 set on the current EmitContext.
14468 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14469 resolve our casted expression as an LValue. This triggers the
14470 proper LValue processing that is later required by Assign.
14474 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14476 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14478 C# 2.0 Fixed buffer implementation
14480 * anonymous.cs: Update after RegisterHelperClass renaming.
14482 * attribute.cs (AttributeTester.fixed_buffer_cache):
14483 Cache of external fixed buffers.
14484 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14485 implementation if field is fixed buffer else null.
14488 (TypeContainer.AddField): Accept FieldMember instead of Field.
14489 (FieldBase.IsFieldClsCompliant): Extracted code from
14490 VerifyClsCompliance descendant customization.
14491 (FixedField): New class handles fixed buffer fields.
14492 (FixedFieldExternal): Keeps information about imported fixed
14494 (IFixedField): Make access to internal or external fixed buffer
14497 * cs-parser.jay: Add fixed buffer parsing.
14499 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14502 * expression.cs (Indirection): Extended implementation to accept
14503 fixed buffer field.
14504 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14505 (ElementAccess.MakePointerAccess): Get type as parameter.
14506 (DoResolve): Add fixed buffer field expression conversion.
14507 (DoResolveLValue): Ditto.
14508 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14509 (ArrayPtr): Derives from FixedBufferPtr.
14510 (ArrayPtr.Emit): Add extra emit for array elements.
14512 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14514 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14515 for compiler generated types.
14516 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14518 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14519 and consume less memory.
14520 (Fixed.Resolve): Add fixed buffer case.
14522 * typemanager.cs (compiler_generated_attr_ctor,
14523 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14524 (HasElementType): Add our own implementation to work on every
14527 2005-02-11 Miguel de Icaza <miguel@novell.com>
14529 * anonymous.cs (CaptureContext): Track whether `this' has been
14532 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14533 only captured `this' if it was implicitly done (instance
14534 methods/variables were used).
14536 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14537 `this' must be captured.
14539 2005-01-30 Miguel de Icaza <miguel@novell.com>
14541 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14542 is null it means that there has been no need to capture anything,
14543 so we just create a sibling.
14545 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14547 Just a partial fix. The other half is fairly elusive.
14549 2005-02-10 Raja R Harinath <rharinath@novell.com>
14551 Fix #52586, cs0121-4.cs.
14552 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14553 and return a hashtable.
14554 (MemberCache.ClearDeclaredOnly): New.
14555 (MemberCache.MemberCache): Update to change. Make a deep copy of
14556 the method_hash of a base type too.
14557 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14558 type methods. Overwrite entries with the same MethodHandle so
14559 that the ReflectedType is correct. The process leaves in base
14560 virtual functions and their overrides as distinct entries.
14561 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14562 matters since it was boxed in a ArrayList before.
14563 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14565 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14566 case of a virtual function and its override (choose the overload
14568 (Invocation.OverloadResolve): Avoid 'override' members during
14569 'applicable_type' calculation.
14571 2005-02-09 Raja R Harinath <rharinath@novell.com>
14573 Combine two near-redundant caches.
14574 * typemanager.cs (method_params): Rename from method_internal_params.
14575 (TypeManager.GetParameterData): New. Replace
14576 Invocation.GetParameterData.
14577 (TypeManager.LookupParametersByBuilder): Remove.
14578 * expression.cs (Invocation.method_parameter_cache): Remove.
14579 (Invocation.GetParameterData): Remove.
14581 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14584 2005-02-08 Raja R Harinath <rharinath@novell.com>
14587 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14588 TypeManager.multicast_delegate_type is null, resolve it by looking
14589 up "System.MulticastDelegate".
14590 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14592 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14593 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14594 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14597 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14598 (LabeledStatement.AddReference): New. Set 'referenced'.
14599 (Goto.Resolve): Use it.
14601 2005-02-05 John Luke <john.luke@gmail.com>
14603 * driver.cs: remove duplicate -doc line in Usage ()
14605 2005-02-04 Raja R Harinath <rharinath@novell.com>
14607 * location.cs (Location.AddFile): Fix CS2002 error report.
14609 2005-02-02 Martin Baulig <martin@ximian.com>
14611 * delegate.cs (Delegate.DefineType): Report an internal error if
14612 TypeManager.multicast_delegate_type is null. See bug #72015 for
14615 2005-02-02 Raja R Harinath <rharinath@novell.com>
14617 Fix a crasher in a variant of #31984.
14618 * const.cs (Constant.CheckBase): New override that defers the
14619 new-or-override check in case the base type hasn't been populated
14621 (Constant.Define): Ensure the new-or-override check is performed.
14623 2005-02-01 Duncan Mak <duncan@ximian.com>
14625 * const.cs (LookupConstantValue): Check that `ce' is not null
14626 before calling GetValue ().
14628 2005-02-01 Raja R Harinath <rharinath@novell.com>
14630 Fix test-334.cs (#69519).
14631 * cs-parser.jay (using_alias_directive): Pass in an expression to
14632 NamespaceEntry.UsingAlias.
14633 (using_namespace_directive): Pass in an expression to
14634 NamespaceEntry.Using.
14635 (namespace_name): Don't flatten to a string.
14636 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14637 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14639 (NamespaceEntry.UsingEntry): Likewise.
14640 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14642 (NamespaceEntry.LookupForUsing): Remove.
14643 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14645 (NamespaceEntry.Lookup): Remove support for dotted names.
14647 2005-02-01 Raja R Harinath <rharinath@novell.com>
14649 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14651 (NamespaceEntry.ImplicitParent): Compute on demand.
14652 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14653 parallels the current.
14654 (NamespaceEntry.LookupForUsing): Use it.
14655 (NamespaceEntry.Lookup): If the current namespace-entry is
14656 implicit, don't search aliases and using tables.
14658 2005-02-01 Raja R Harinath <rharinath@novell.com>
14661 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14663 (TypeContainer.BaseCache): Compute on demand.
14664 (TypeContainer.FindMembers): Define constants and types if they're
14665 not already created.
14666 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14668 * const.cs (Constant.Define): Make idempotent.
14670 2005-01-29 Miguel de Icaza <miguel@novell.com>
14672 * pending.cs: Produce better code (no nops produced by using Ldarg
14675 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14676 i - 1' it should be arg + 1.
14680 2005-01-28 Raja R Harinath <rharinath@novell.com>
14682 * attribute.cs (Attribute.CheckAttributeType): Make private
14684 (Attribute.ResolveType): Make virtual.
14685 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14686 handling of RootContext.Tree.Types.
14688 2005-01-27 Raja R Harinath <rharinath@novell.com>
14690 Update attribute-handling to use the SimpleName/MemberAccess
14692 * cs-parser.jay (attribute): Pass in an expression to the
14693 constructors of Attribute and GlobalAttribute.
14694 * attribute.cs (Attribute): Take an expression for the name.
14695 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14696 passed in attribute name expression.
14697 (Attribute.CheckAttributeType): Use it.
14698 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14699 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14700 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14701 argument to prevent error messages if the lookup fails.
14703 2005-01-27 Marek Safar <marek.safar@seznam.cz>
14705 * expression.cs (Indirection): Implemented IVariable interface
14706 to support indirection in AddressOf operator.
14707 (PointerArithmetic.Emit): Add optimalization for case where
14708 result can be precomputed.
14710 2005-01-26 Martin Baulig <martin@ximian.com>
14712 * class.cs (TypeContainer.AttributeTargets): Return the correct
14713 AttributeTargets depending on our `Kind' instead of throwing an
14714 exception; fixes #71632.
14716 2005-01-26 Marek Safar <marek.safar@seznam.cz>
14719 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
14722 2005-01-25 Raja R Harinath <rharinath@novell.com>
14725 * expression.cs (MemberAccess.DoResolve): Don't complain with
14726 cs0572 when the LHS of a member access has identical name and type
14729 2005-01-25 Marek Safar <marek.safar@seznam.cz>
14732 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
14734 Create custom PermissionSet only for PermissionSetAttribute.
14736 2005-01-24 Marek Safar <marek.safar@seznam.cz>
14739 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
14740 delegates in static class.
14742 2005-01-24 Martin Baulig <martin@ximian.com>
14744 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14745 merging an implicit block, just use its reachability.
14747 * statement.cs (Block.Resolve): Make the unreachable code check
14748 work wrt. implicit blocks; see test-337 from #63842.
14750 2005-01-21 Alp Toker <alp@atoker.com>
14752 * cs-parser.jay: destructor_declaration's container is PartialContainer
14753 not Class when partial types are used, so use Kind prop instead of
14756 2005-01-22 Miguel de Icaza <miguel@ximian.com>
14758 * cs-parser.jay: Improve error reporting when an interface
14759 declares new types.
14761 2005-01-20 Dick Porter <dick@ximian.com>
14763 * support.cs: SeekableStreamReader fix from Sandor Dobos
14764 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
14765 chars are read. Fixes bug 70369.
14767 2005-01-20 Raja R Harinath <rharinath@novell.com>
14769 * cs-parser.jay (catch_clause): Simplify current_block handling
14772 2005-01-17 Miguel de Icaza <miguel@ximian.com>
14774 * convert.cs (ImplicitStandardConversionExists): Synchronize the
14775 code with ImplicitStandardConversion to handle the implicit
14776 conversion of method groups into valid delegate invocations.
14778 The problem is that in parameter handling we were using this code
14779 path. Fixes bug #64698
14781 2005-01-19 Raja R Harinath <rharinath@novell.com>
14783 * cs-parser.jay: Fix several infelicities.
14784 - Avoid assigning to the parser value stack. Code like
14785 '$3 = null' is unclean. Synthesize a value for the code block
14787 - Avoid using oob_stack for storing location information. Use ...
14788 (_mark_): ... this. New (empty) rule. Saves the current location
14790 (foreach_statement): Avoid using oob_stack for current_block
14791 handling. Use technique used in for_statement and
14792 using_statement. Synthesize a value for the code block to store
14793 additional intermediate information.
14795 2005-01-13 Miguel de Icaza <miguel@ximian.com>
14797 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
14798 of a different type is only allowed to private fields of a
14799 containing type, not on fields of a base class.
14801 See test-174.cs and error cs0122-9.cs
14803 2005-01-13 Raja R Harinath <rharinath@novell.com>
14805 Fix test-335.cs (bug #58126).
14806 * cs-parser.jay (argument): Split out non-expression parts of the
14807 rule into 'non_simple_argument'.
14808 (invocation_expression): Support parenthesized invocations with
14809 multiple arguments, and with single non-simple arguments.
14811 2005-01-13 Raja R Harinath <rharinath@novell.com>
14813 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
14816 2005-01-12 Raja R Harinath <rharinath@novell.com>
14818 Fix cs0038-1.cs, cs1640-6.cs.
14819 * ecore.cs (Expression.Resolve): Remove special-case for
14820 SimpleName in error-handling.
14821 (Expression.almostMatchedMembers): Relax access permission to
14823 (Expression.MemberLookupFailed): Handle duplicates in
14824 almostMatchedMembers list.
14825 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
14826 * expression.cs (New.DoResolve): Report CS1540 for more cases.
14827 * typemanager.cs (GetFullNameSignature): Use the MethodBase
14828 overload if the passed in MemberInfo is a MethodBase.
14830 2005-01-12 Marek Safar <marek.safar@seznam.cz>
14833 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
14834 for non-CAS & merge permission sets properly.
14836 2005-01-11 Raja R Harinath <rharinath@novell.com>
14838 Improve standard-compliance of simple name and member access
14839 resolution. Fixes bugs #52697, #57200, #67520, #69519.
14840 * ecore.cs (FullNamedExpression): New abstract base class
14841 for Namespaces and TypeExpressions.
14842 (ResolveFlags.SimpleName): Remove.
14843 (SimpleName): Remove support for dotted names.
14844 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
14845 DeclSpace.FindType and DeclSpace.LookupType.
14846 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
14847 (Expression.ExprClassName): Make member function.
14848 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
14849 a namespace. Remove creation of dotted "SimpleName"s.
14850 (MemberAccess.DoResolve): Likewise.
14851 * decl.cs (DeclSpace.Cache): Make private.
14852 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
14853 (DeclSpace.FindType): Update.
14854 (DeclSpace.LookupType): Move here from RootContext. Return a
14855 FullNamedExpression.
14856 * namespace.cs (Namespace): Derive from FullNamedExpression
14857 so that it can be part of expression resolution.
14858 (Namespace.Lookup): Return an FullNamedExpression.
14859 (NamespaceEntry.LookupAlias): Lookup aliases only in current
14861 * rootcontext.cs (NamespaceLookup): Remove.
14862 (LookupType): Move to DeclSpace.
14863 * attribute.cs (CheckAttributeType): Update.
14864 * doc.cs (FindDocumentedType): Remove allowAlias argument.
14865 (FindDocumentedTypeNonArray): Likewise.
14867 2005-01-11 Raja R Harinath <rharinath@novell.com>
14869 Fix cs0509.cs, cs1632.cs.
14870 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
14871 is the same as IsInterface.
14872 (TypeContainer.GetClassBases): Likewise.
14873 * statement.cs (LabeledStatement.ig): New field.
14874 (LabeledStatement.LabelTarget): Save ILGenerator which created the
14876 (LabeledStatement.DoEmit): Check that the label was created with
14877 the same ILGenerator.
14879 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14882 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
14883 accessors to its properties.
14885 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
14886 from accessors to property.
14888 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14891 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
14892 only for overrides.
14894 2005-01-08 Miguel de Icaza <miguel@ximian.com>
14896 * attribute.cs: Check for null and empty strings.
14898 I have lost another battle to Paolo.
14900 2005-01-07 Marek Safar <marek.safar@seznam.cz>
14903 * class.cs (PropertyMethod): Set Parent field in ctors.
14904 (SetMethod.InternalParameters): Add unsafe switch hack.
14905 Override MarkForDuplicationCheck where it is appropriate.
14907 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
14908 It says whether container allows members with the same name.
14909 Base default is no.
14910 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
14911 Removed is_method parameter.
14913 2005-01-06 Duncan Mak <duncan@ximian.com>
14915 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
14916 because the previous change led to incorrect reporting of CS1032
14917 ("Cannot define/undefine preprocessor symbols after first token in
14918 file"). Instead of using `tokens_seen' as the only flag that
14919 triggers CS1040, introduce `comments_seen'. This new flag is used
14920 to signify having seen comments on the current line, so it is
14921 unset after a newline.
14923 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14925 * doc.cs : When searching for a type, find nested type too.
14926 This fixes bug #71040.
14928 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14931 - Warn missing member comment on those classes which also does not
14932 have doc comments. Fixed bug #71041.
14933 - Don't warn missing doc comment on default constructor.
14936 2005-01-06 Duncan Mak <duncan@ximian.com>
14938 * cs-tokenizer.cs (xtoken): After handling traditional C-style
14939 comments, set `tokens_seen' to true. This allows us to detect
14940 misplaced preprocessor directives (i.e. not at the beginning of
14941 the a line, nor after whitespaces). In that case, report error
14942 CS1040. This fixes bug #56460.
14944 * cs-parser.jay (interface_member_declaration): Add checks for
14945 IsExplicitImpl, and report CS0541 error if an interface member is
14946 defined as an explicit interface declaration.
14948 2005-01-06 Marek Safar <marek.safar@seznam.cz>
14951 * class.cs (PropertyMethod): Set Parent field in ctors.
14952 (SetMethod.InternalParameters): Add unsafe switch hack.
14954 * decl.cs (MemberCore.Parent): Cannot be readonly.
14956 2005-01-06 Raja R Harinath <rharinath@novell.com>
14958 * decl.cs (DeclSpace.ResolveType): Remove.
14959 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
14960 Merge in code from ...
14961 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
14962 * class.cs, enum.cs: Update to changes.
14964 2005-01-06 Miguel de Icaza <miguel@ximian.com>
14966 * anonymous.cs: Ensure that we init the scope of our parent if it
14967 has not been initialized yet.
14969 2004-12-30 Duncan Mak <duncan@ximian.com>
14971 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
14972 if field.FieldBuilder is null. Fixes #70758.
14974 * convert.cs: Fixed some typos and updated some of the comments.
14975 (ImplicitStandardConversionExists):
14976 (TryImplicitIntConversion): If `target_type' is an interface and
14977 the type of `ic' implements this interface, return true or a new
14978 BoxedCast instead of null. This fixes #70468.
14980 2004-12-29 Duncan Mak <duncan@ximian.com>
14982 * expression.cs (Argument.Emit): Check that Expr is
14983 IMemoryLocation before casting to it, and report CS1510 otherwise.
14987 2004-12-21 Ben Maurer <bmaurer@ximian.com>
14989 * statement.cs (Block.ThisVariable): remove the recursion here, to
14990 make the --profile more sane.
14992 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
14994 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
14995 assembly, by JB Evain.
14997 2004-12-17 Raja R Harinath <rharinath@novell.com>
14999 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15000 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15001 "parent" refers to enclosing type/class. "base" refers to superclass.
15003 2004-12-17 Raja R Harinath <rharinath@novell.com>
15005 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15006 Ensure that we only have GlobalAttributes.
15007 * attribute.cs (Attribute.Emit): Make non-virtual.
15008 (GlobalAttribute.Emit): Remove.
15009 (Attribute.Resolve): Make virtual.
15010 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15011 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15012 the argument. Don't create one.
15013 (Attribute.GetObsoleteAttribute): Likewise.
15014 (Attribute.GetClsCompliantAttributeValue): Likewise.
15015 * class.cs, decl.cs: Update to changes.
15017 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15019 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15021 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15023 * statement.cs (Foreach.Resolve): Add error 186 report.
15025 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15027 * expression.cs (Conditional.DoResolve): Add warning 429.
15029 * statement.cs (If.Resolve): Add warning 665.
15031 2004-12-16 Raja R Harinath <rharinath@novell.com>
15033 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15034 except when in the parser, and in GlobalAttribute.
15035 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15036 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15037 RootContext.Tree.Types.NamespaceEntry once work is done.
15038 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15039 and resets RootContext.Tree.Types.NamespaceEntry.
15041 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15043 * cs-parser.jay: Don't create a block for every variable.
15045 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15047 * location.cs: Provide extra information.
15049 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15050 variables from the captured environment, it is the ldarg_0.
15052 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15054 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15057 * class.cs: Changed warning level for 169 to avoid developer
15058 displeasure from warning flooding. It will be changed back when they
15059 fix most of current BCL warnings.
15061 * RootContext.cs: Pushed default WarningLevel to 3.
15063 * statement.cs: Removed unused variable.
15065 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15067 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15068 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15069 Add error 502 report.
15070 (StaticClass.DefineType): Add error 441 report.
15071 (Class.AllowedModifiersProp): New virtual property as temporary
15072 extension to AllowedModifiers.
15073 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15074 to share implementation with StaticClass and don't call virtual
15077 * driver.cs (MainDriver): Add error 1558 test.
15079 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15080 report. Moved error 36 test here.
15082 * statement.cs (Throw.Resolve): Add error 724 report.
15084 * typemanager.cs: Add out_attribute_type core type.
15086 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15088 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15090 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15092 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15095 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15097 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15098 Add error 3023 report.
15099 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15101 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15104 2004-12-12 John Luke <john.luke@gmail.com>
15106 * driver.cs (AddArgs): take -- into account when
15107 adding arguments, fixes bug 65710
15109 2004-12-12 Martin Baulig <martin@ximian.com>
15111 * expression.cs (Unary.TryReduceNegative): Added support for
15112 SByteConstant and ByteConstant.
15113 (Unary.Reduce): Check error values from TryReduceNegative().
15115 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15117 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15118 and report exception as error 182.
15120 2004-12-10 Raja R Harinath <rharinath@novell.com>
15122 * driver.cs (Main): Fix message when there are warnings.
15124 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15126 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15128 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15130 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15131 Reduced number of warnings.
15133 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15135 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15137 * driver.cs: Removed message.
15139 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15141 2004-12-08 <vargaz@freemail.hu>
15143 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15145 2004-12-08 Martin Baulig <martin@ximian.com>
15147 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15148 instead of a CS3002 for properties and indexer.
15150 2004-12-08 Martin Baulig <martin@ximian.com>
15152 * decl.cs (MemberName.ToString): Make this work again.
15154 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15156 * attribute.cs (Resolve): Add error 591 detection.
15158 * class.cs (FieldMember.Define): Add error 1547 detection.
15159 (Indexer.Define): Add error 620 detection.
15160 (Operator.Define): Add error 590 detection.
15162 * ecore.cs: Missing argument for error 79.
15164 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15167 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15170 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15173 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15175 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15176 Some operator comments were suppressed.
15177 * doc.cs : Implicit/explicit operator name in doc comments are like
15178 "op_Explicit(type)~returnType", so added suffix handling.
15180 2004-12-07 Martin Baulig <martin@ximian.com>
15183 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15184 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15185 (DeclSpace.ec): New protected field; store the EmitContext here.
15186 (DeclSpace.EmitContext): New public property; moved here from
15188 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15191 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15192 (Enum.Emit): Don't create a new EmitContext.
15194 * delegate.cs (Delegate.DefineType): Always create the
15197 * iterators.cs (Iterators.DefineIterator): Create a new
15198 EmitContext and store it in `ec'.
15200 2004-08-24 Martin Baulig <martin@ximian.com>
15203 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15204 this for accessibility checks.
15205 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15206 IsNestedFamilyAccessible.
15207 (TypeManager.IsSubclassOf): New method, do what the name actually
15210 2004-12-06 Raja R Harinath <rharinath@novell.com>
15212 Fix crash on cs0657-17.cs.
15213 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15214 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15215 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15216 the case where the NamespaceEntry gets overwritten.
15218 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15220 Fixed #69195, #56821
15221 * ecore.cs (ResolveBoolean): Tiny refactoring.
15223 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15224 of right expression resolving when left is false constant and
15225 operator is LogicalAnd OR true constant and operator is LogicalOr.
15227 * statement.cs (ResolveUnreachable): Always reports warning.
15229 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15231 * class.cs: Distinguish between 1721 and 1722 (just a little help
15232 for the programmer).
15234 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15236 * delegate.cs: Only allow this on new versions of the language.
15238 2004-12-02 Duncan Mak <duncan@ximian.com>
15240 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15242 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15243 here as a static method. Take an additional bool out parameter
15244 `must_do_cs1540_check' for signaling to InstanceResolve.
15245 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15246 member field from PropertyExpr class and made it an argument of
15247 the method instead.
15248 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15249 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15250 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15251 and `remove_accessor' as well as InstanceResolve: report CS0122
15256 2004-12-03 Raja R Harinath <rharinath@novell.com>
15258 Fix test-327.cs, test-328.cs, and put in early infrastructure
15259 for eventually fixing #52697.
15260 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15261 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15262 from other methods.
15263 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15264 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15265 (VerifyUsing, error246): Update.
15266 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15267 'NamespaceEntry.LookupNamespaceOrType'.
15269 2004-12-03 Martin Baulig <martin@ximian.com>
15271 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15272 method as our child, call AnonymousMethod.Compatible() on it.
15274 2004-12-03 Raja R Harinath <rharinath@novell.com>
15276 Disable XML documentation support in 'basic' profile.
15277 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15278 Redirect XmlElement to System.Object.
15279 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15280 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15281 * mcs.exe.sources: Add doc-bootstrap.cs.
15282 * doc-bootstrap.cs: New file. Contains empty stub implementation
15285 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15287 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15288 comments are allowed.
15290 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15292 * delegate.cs: Add checks for subtypes in paramaters and return values
15293 in VerifyMethod () to add support for Covariance/Contravariance
15296 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15298 * report.cs: Remove extra closing parenthesis.
15300 * convert.cs (Error_CannotImplicitConversion): If the name of the
15301 types are the same, provide some extra information.
15303 * class.cs (FieldBase): Use an unused bit field from the field to
15304 encode the `has_offset' property from the FieldMember. This saves
15305 a couple of Ks on bootstrap compilation.
15307 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15308 method as our child, return the AnonymousMethod resolved
15311 * expression.cs (New.DoResolve): Allow return values from
15312 NewDelegate to also include AnonymousMethods.
15316 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15319 * attribute.cs (Resolve): Improved implementation of params
15320 attribute arguments.
15322 * support.cs (ParameterData): Add HasParams to be faster.
15324 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15326 all things are for /doc support:
15328 * doc.cs: new file that supports XML documentation generation.
15329 * mcs.exe.sources: added doc.cs.
15331 Handle /doc command line option.
15332 Report error 2006 instead of 5 for missing file name for /doc.
15333 Generate XML documentation when required, after type resolution.
15335 Added support for picking up documentation (/// and /** ... */),
15336 including a new XmlCommentState enumeration.
15338 Added lines to fill Documentation element for field, constant,
15339 property, indexer, method, constructor, destructor, operator, event
15340 and class, struct, interface, delegate, enum.
15341 Added lines to warn incorrect comment.
15343 Added Documentation field (passed only when /doc was specified).
15345 Added DocComment, DocCommentHeader, GenerateDocComment() and
15346 OnGenerateDocComment() and some supporting private members for
15347 /doc feature to MemberCore.
15349 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15351 Added overriden DocCommentHeader.
15353 Added overriden DocCommentHeader and GenerateDocComment().
15355 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15357 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15358 unwrapping the enumeration values, chain to
15359 DoConstantNumericPromotions again, so we can promote things to the
15360 fundamental types (takes care of enums that are bytes, sbytes).
15364 2004-12-01 Raja R Harinath <rharinath@novell.com>
15366 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15367 Fix long-standing bug in type-lookup. Use FindType instead of
15368 LookupType when ec.ResolvingTypeTree.
15369 (Attribute.ResolveType, Attribute.Resolve)
15370 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15372 (Attributes.Search): Remove internal version. Update.
15373 (Attributes.SearchMulti): Update.
15374 (Attributes.GetClsCompliantAttribute): Remove.
15375 (Attributes.GetIndexerNameAttribute): Remove.
15376 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15377 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15378 * class.cs (Indexer.Define): Likewise.
15380 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15383 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15384 MarshallByReference members access.
15386 * expression.cs: Use CheckMarshallByRefAccess;
15387 Better error CS0197 message.
15389 * report.cs: Print whole related error message.
15391 2004-11-30 Raja R Harinath <rharinath@novell.com>
15393 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15394 the current directory to help debugging.
15396 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15398 * class (GetClassBases): Better error 60 report.
15399 (EventProperty): Disabled warning 67 detection.
15401 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15404 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15406 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15409 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15412 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15414 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15416 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15418 * attribute.cs (Attribute.Resolve): Refine error reporting and
15419 report a cs0117 if the identifier does not exist, to distinguish
15420 from 0617 which is a miss-use of the actual identifier.
15422 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15423 between cs0070 and cs0079.
15425 * class.cs (MemberBase.DoDefine): When reporting a wrong
15426 accessibility level, we use MethodCore to compare instead of
15427 Method (this was a regression in some refactoring effort).
15429 So now we correctly report cs0056 again.
15431 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15432 testing the target_type (which was known to be object_type) and
15433 not the source type (which is anonymous_method).
15435 Fixed reporting of error cs1660.
15437 * expression.cs (UserCast.Source): Expose the underlying cast.
15439 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15440 allowed types to find a match to int32 first (most common).
15442 In addition, it ignores any ImplicitUserConversions that did an
15443 internal implicit conversion (as the switch statement allows only
15444 one integral conversion to exist).
15446 * class.cs (PartialContainer.Create): rename `name' to
15447 `member_name' for clarity. Then replace the string calls with a
15448 call to MemberName.GetPartialName, as now using
15449 MemberName.ToString is an error (this is due to the side effects
15450 it had, that were fixed in the past).
15452 This will restore the error reporting on a number of partial class
15453 errors that were missusing this (and getting an exception as a
15454 results, which is now just a plain textual warning, because
15455 yyparse debug output would crash otherwise).
15457 2004-11-26 Raja R Harinath <rharinath@novell.com>
15459 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15461 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15463 * rootcontext.cs (LookupType): Make sure to cache lookups that
15464 don't give us a negative result. This saves about 5% of corlib
15467 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15469 * report.cs (AbstractMessage.Print): messages are sent to stderr
15471 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15472 non-interface in the list of interfaces (at this point, either
15473 parent was properly set, or a base class is being listed in the
15474 interfaces section).
15476 This flags error 1722, and resolves the crash from bug 69259.
15478 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15480 * statement.cs (Using.EmitExpressionFinally): make this work right
15481 for valuetypes. Fixes 69926.
15483 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15485 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15486 converted to an enum" here, before we try to change the underlying
15487 type. This code exists, but it is a different code path than the
15488 one used while encoding constants.
15490 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15491 old bug: when converting from the null literal to a pointer,
15492 return an EmptyCast, not the NullLiteral.
15494 This fixes #69921, the recent null_type changes probably made this
15495 bug more prominent.
15497 (ImplicitReferenceConversionExists): In addition, resynchronized
15498 the code here, so it matches the same code in
15499 ImplicitReferenceConversionExists for the `from any class-type S
15500 to any interface-type T'.
15503 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15505 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15507 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15509 * cs-parser.jay: Use verbosity accordingly.
15511 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15513 * expression.cs (Unary.ResolveOperator): Do not report warning;
15514 AddressOf reads from variable.
15516 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15518 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15522 * attribute.cs (Attributable): Removed CheckTargets.
15523 (Attributes.Emit): Explicit attribute targets are tested here.
15525 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15526 not enabled for interfaces.
15528 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15529 (GetAssemblyName): Ouch next bug there.
15531 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15533 * expression.cs: Error 275 added.
15535 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15537 Fix bug #69177 (Implemented decimal constant support)
15539 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15540 (BinaryFold): Add DecimalConstant.
15542 * const.cs (Define): Decimal constant
15544 (ChangeType): Add decimal type handling.
15545 (LookupConstantValue): Don't set value for decimal type but
15546 emit DecimalConstantAttribute. Needed for constant optimization.
15548 * constant.cs (ToDecimal): New method.
15549 (ConvertToDecimal): New method.
15550 (IntConstant): Implemented ConvertToDecimal.
15551 (DecimalConstant.Emit): Emit optimized version for decimals in
15554 * expression.cs (ResolveOperator): Changed order of constant
15555 reduction to work correctly with native types which have
15556 overloaded operators.
15557 (ResolveMemberAccess): Extract constant value from attribute
15560 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15562 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15563 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15564 (ChangeType): Decimal is special.
15565 (TypeToCoreType): Add decimal type.
15567 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15569 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15572 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15574 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15577 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15579 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15581 * pending.cs (PendingImplementation): Grab only interfaces.
15583 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15585 * statement.cs (ForeachHelperMethods): Add location member and
15586 error 202 detection.
15588 2004-11-19 Raja R Harinath <rharinath@novell.com>
15590 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15591 automatically handled by executable.make.
15592 (PROGRAM): Make profile-specific.
15594 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15596 * expression.cs (DoResolveBase): Fixed wrong warning for out
15599 2004-11-18 Martin Baulig <martin@ximian.com>
15601 Merged latest changes into gmcs. Please keep this comment in
15602 here, it makes it easier for me to see what changed in MCS since
15603 the last time I merged.
15605 2004-11-17 Raja R Harinath <rharinath@novell.com>
15607 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15608 (TypeHandle.GetMemberCache): New.
15609 (TypeHandle.TypeHandle): Update.
15610 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15611 (TypeManager.LookupParentInterfacesCache):
15612 Rename from LookupInterfaceCache. Optimize slightly.
15613 (TypeManager.MemberLookup_FindMembers): Update.
15614 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15615 multi-type variant.
15616 (AddCacheContents): Rename from AddHashtable.
15617 * class.cs (TypeContainer.parent_container): Remove.
15618 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15619 (TypeContainer.DoDefineMembers): Don't initialize it.
15620 Update to name changes.
15622 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15624 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15625 that factors the code to check access modifiers on override.
15627 (PropertyBase): Use the code here.
15629 Patch from Lluis S'anchez, fixes bug #69361.
15631 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15633 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15634 routine that is used to report the use of a captured variable
15635 whose address has been taken.
15637 There are two checks: one when variables are being captured and
15638 the other check is when the address of a variable is taken.
15640 (because an anonymous methods might be resolved before *or* after
15641 the address has been taken) and
15643 * expression.cs (Conditional.DoResolve): Remove the special
15644 casing that Martin added to trueExpr and falseExpr being both
15645 NullLiteral. We get the right behavior now just by introducing
15646 the null_type into the compiler.
15648 * convert.cs (ExplicitConversion): Change the code to use
15649 null_type instead of testing `expr is NullLiteral'.
15650 (ImplicitConversionStandard): use null_type too.
15651 (ImplicitReferenceConversionExists): use null_type too.
15652 (ImplicitReferenceConversion): use null_type too.
15654 * literal.cs: The type of `NullLiteral' is now null_type instead
15656 (Resolve): Set the type here.
15658 * typemanager.cs: Introduce null_type.
15660 2004-11-17 Martin Baulig <martin@ximian.com>
15662 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15663 direction, like FindMembers() does. Fixes #69546, testcase is in
15666 2004-11-16 Martin Baulig <martin@ximian.com>
15668 This is based on a patch from Marek Safar, see bug #69082.
15669 Fixes bugs #63705 and #67130.
15671 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15672 method; create a MemberCache for an interface type and cache the
15675 * decl.cs (IMemberContainer.ParentContainer): Removed.
15676 (IMemberContainer.ParentCache): New property.
15677 (MemberCache.SetupCacheForInterface): Removed.
15678 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15679 to create a cache for an interface's "parent".
15681 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15684 2004-11-16 Martin Baulig <martin@ximian.com>
15686 Merged back from gmcs; these changes already went into gmcs a
15687 couple of weeks ago.
15690 (TypeManager.AddUserType): Removed the `ifaces' argument.
15691 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15693 (TypeManager.AddUserInterface): Removed.
15694 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15696 (TypeManager.GetInterfaces): Likewise.
15697 (TypeManager.GetExplicitInterfaces): Likewise.
15699 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15701 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15702 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
15704 2004-11-14 Ben Maurer <bmaurer@ximian.com>
15706 * statement.cs: Avoid adding bools to a hashtable.
15708 2004-11-07 Miguel de Icaza <miguel@ximian.com>
15710 * expression.cs (Invocation.OverloadResolve): Flag error if we are
15711 calling an unsafe method from a safe location.
15713 2004-11-06 Marek Safar <marek.safar@seznam.cz>
15716 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
15718 2004-11-06 Miguel de Icaza <miguel@ximian.com>
15720 * namespace.cs (VerifyUsing): use GetPartialName instead of
15723 2004-11-05 Miguel de Icaza <miguel@ximian.com>
15725 * statement.cs (Return.Resolve): Fix regression in typo: if
15726 `in_exc', we have to request a NeedReturnLabel, this was a typo
15727 introduced in the anonymous method check-in. Fixes #69131.
15729 * Indexers were using the ShortName when defining themselves,
15730 causing a regression in the compiler bootstrap when applying the
15731 patch from 2004-11-02 (first part), now they use their full name
15732 and the bug is gone.
15734 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
15736 * driver.cs: Strip the path from the names of embedded resources. Fixes
15739 2004-11-04 Raja R Harinath <rharinath@novell.com>
15741 Fix error message regression: cs0104-2.cs.
15742 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
15743 (AliasEntry.Resolve): Update.
15744 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
15746 (RootContext.LookupType): Update.
15748 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
15750 * cs-parser.jay: Add support for handling accessor modifiers
15751 * class: Add support port accessor modifiers and error checking,
15752 define PropertyMethod.Define as virtual (not abstract anymore)
15753 * ecore.cs: Add checking for proeprties access with access modifiers
15754 * iterators.cs: Modify Accessor constructor call based in the modified
15756 2004-11-02 Ben Maurer <bmaurer@ximian.com>
15758 * expression.cs (StringConcat): Handle being called twice,
15759 as when we have a concat in a field init with more than two
15762 2004-11-02 Miguel de Icaza <miguel@ximian.com>
15764 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
15765 special case explicit implementations, we should always produce
15766 the .property or .event declaration.
15768 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
15769 since it will not return correct data if people use this
15770 unresolved in the presence of using statements (see test-313).
15772 * class.cs (MethodData.Define): If we are an explicit interface
15773 implementation, set the method name to the full name of the
15774 interface plus the name of the method.
15776 Notice that using the method.MethodName.GetFullName() does not
15777 work, as it will only contain the name as declared on the source
15778 file (it can be a shorthand in the presence of using statements)
15779 and not the fully qualifed type name, for example:
15783 class D : ICloneable {
15784 object ICloneable.Clone () {
15788 Would produce a method called `ICloneable.Clone' instead of
15789 `System.ICloneable.Clone'.
15791 * namespace.cs (Alias.Resolve): Use GetPartialName.
15793 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15795 * cs-parser.jay: Add error 1055 report.
15797 2004-11-01 Miguel de Icaza <miguel@ximian.com>
15799 * assign.cs (Assign.DoResolve): Only do the transform of
15800 assignment into a New if the types are compatible, if not, fall
15801 through and let the implicit code deal with the errors and with
15802 the necessary conversions.
15804 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15806 * cs-parser.jay: Add error 1031 report.
15808 * cs-tokenizer.cs: Add location for error 1038.
15810 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15812 * cs-parser.jay: Add error 1016 report.
15814 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15816 * cs-parser.jay: Add errors 1575,1611 report.
15818 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15820 * cs-parser.jay: Add error 1001 report.
15822 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15825 * attribute.cs (GetMarshal): Add method argument for
15826 caller identification.
15828 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
15829 agument for GetMarshal and RuntimeMissingSupport.
15831 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15833 * attribute.cs (ExtractSecurityPermissionSet): Removed
15834 TypeManager.code_access_permission_type.
15836 * typemanager.cs: Removed TypeManager.code_access_permission_type.
15838 2004-10-27 Miguel de Icaza <miguel@ximian.com>
15840 * expression.cs (LocalVariableReference.DoResolveLValue): Check
15841 for obsolete use of a variable here. Fixes regression on errors
15842 cs0619-25 and cs0619-26.
15844 2004-10-27 Marek Safar <marek.safar@seznam.cz>
15846 Fix #62358, implemented security attribute encoding.
15848 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
15849 Tests permitted SecurityAction for assembly or other types.
15850 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
15851 data from SecurityPermissionAttribute to PermisionSet class.
15853 * class.cs (ApplyAttributeBuilder): Added special handling
15854 for System.Security.Permissions.SecurityAttribute based types.
15856 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
15857 special handling for System.Security.Permissions.SecurityAttribute
15860 * enum.cs (ApplyAttributeBuilder): Added special handling
15861 for System.Security.Permissions.SecurityAttribute based types.
15863 * parameter.cs (ApplyAttributeBuilder): Added special handling
15864 for System.Security.Permissions.SecurityAttribute based types.
15866 * rootcontext.cs: Next 2 core types.
15868 * typemanager.cs (TypeManager.security_permission_attr_type):
15869 Built in type for the SecurityPermission Attribute.
15870 (code_access_permission_type): Build in type.
15872 2004-10-17 Miguel de Icaza <miguel@ximian.com>
15874 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
15875 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
15876 all of this information into
15877 EmitContext.EmitCapturedVariableInstance.
15879 * codegen.cs (EmitCapturedVariableInstance): move here the
15880 funcionality of emitting an ldarg.0 in the presence of a
15881 remapping. This centralizes the instance emit code.
15883 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
15884 then emit a load of this: it means that we have reached the
15885 topmost ScopeInfo: the one that contains the pointer to the
15886 instance of the class hosting the anonymous method.
15888 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
15889 captures to the topmost CaptureContext.
15891 2004-10-12 Miguel de Icaza <miguel@ximian.com>
15893 * expression.cs (LocalVariableReference): Move the knowledge about
15894 the iterators into codegen's EmitCapturedVariableInstance.
15896 2004-10-11 Miguel de Icaza <miguel@ximian.com>
15898 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
15899 all code paths return a value from an anonymous method (it is the
15900 same as the 161 error, but for anonymous methods).
15902 2004-10-08 Miguel de Icaza <miguel@ximian.com>
15904 The introduction of anonymous methods in the compiler changed
15905 various ways of doing things in the compiler. The most
15906 significant one is the hard split between the resolution phase
15907 and the emission phases of the compiler.
15909 For instance, routines that referenced local variables no
15910 longer can safely create temporary variables during the
15911 resolution phase: they must do so from the emission phase,
15912 since the variable might have been "captured", hence access to
15913 it can not be done with the local-variable operations from the runtime.
15917 (Block.Flags): New flag `IsTopLevel' to indicate that this block
15918 is a toplevel block.
15920 (ToplevelBlock): A new kind of Block, these are the blocks that
15921 are created by the parser for all toplevel method bodies. These
15922 include methods, accessors and anonymous methods.
15924 These contain some extra information not found in regular blocks:
15925 A pointer to an optional CaptureContext (for tracking captured
15926 local variables and parameters). A pointer to the parent
15929 (Return.Resolve): Catch missmatches when returning a value from an
15930 anonymous method (error 1662).
15931 Invoke NeedReturnLabel from the Resolve phase instead of the emit
15934 (Break.Resolve): ditto.
15936 (SwitchLabel): instead of defining the labels during the
15937 resolution phase, we now turned the public ILLabel and ILLabelCode
15938 labels into methods called GetILLabelCode() and GetILLabel() that
15939 only define the label during the Emit phase.
15941 (GotoCase): Track the SwitchLabel instead of the computed label
15942 (its contained therein). Emit the code by using
15943 SwitchLabel.GetILLabelCode ().
15945 (LocalInfo.Flags.Captured): A new flag has been introduce to track
15946 whether the Local has been captured or not.
15948 (LocalInfo.IsCaptured): New property, used to tell whether the
15949 local has been captured.
15951 * anonymous.cs: Vastly updated to contain the anonymous method
15954 The main classes here are: CaptureContext which tracks any
15955 captured information for a toplevel block and ScopeInfo used to
15956 track the activation frames for various local variables.
15958 Each toplevel block has an optional capture context associated
15959 with it. When a method contains an anonymous method both the
15960 toplevel method and the anonymous method will create a capture
15961 context. When variables or parameters are captured, they are
15962 recorded on the CaptureContext that owns them, for example:
15966 MyDelegate d = delegate {
15971 Here `a' will be recorded as captured on the toplevel
15972 CapturedContext, the inner captured context will not have anything
15973 (it will only have data if local variables or parameters from it
15974 are captured in a nested anonymous method.
15976 The ScopeInfo is used to track the activation frames for local
15977 variables, for example:
15979 for (int i = 0; i < 10; i++)
15980 for (int j = 0; j < 10; j++){
15981 MyDelegate d = delegate {
15986 At runtime this captures a single captured variable `i', but it
15987 captures 10 different versions of the variable `j'. The variable
15988 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
15989 recorded on a child.
15991 The toplevel ScopeInfo will also track information like the `this'
15992 pointer if instance variables were referenced (this is necessary
15993 as the anonymous method lives inside a nested class in the host
15994 type of the method).
15996 (AnonymousMethod): Expanded to track the Toplevel, implement
15997 `AnonymousMethod.Compatible' to tell whether an anonymous method
15998 can be converted to a target delegate type.
16000 The routine now also produces the anonymous method content
16002 (AnonymousDelegate): A helper class that derives from
16003 DelegateCreation, this is used to generate the code necessary to
16004 produce the delegate for the anonymous method that was created.
16006 * assign.cs: API adjustments for new changes in
16007 Convert.ImplicitStandardConversionExists.
16009 * class.cs: Adjustments to cope with the fact that now toplevel
16010 blocks are of type `ToplevelBlock'.
16012 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16013 insteda of standard blocks.
16015 Flag errors if params arguments are passed to anonymous methods.
16017 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16018 `CurrentAnonymousMethod' which points to the current Anonymous
16019 Method. The variable points to the AnonymousMethod class that
16020 holds the code being compiled. It is set in the new EmitContext
16021 created for the anonymous method.
16023 (EmitContext.Phase): Introduce a variable and an enumeration to
16024 assist in enforcing some rules about when and where we are allowed
16025 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16026 only one that enfonces this right now).
16028 (EmitContext.HaveCaptureInfo): new helper method that returns
16029 whether we have a CapturedContext initialized.
16031 (EmitContext.CaptureVariable): New method used to register that a
16032 LocalInfo must be flagged for capturing.
16034 (EmitContext.CapturedParameter): New method used to register that a
16035 parameters must be flagged for capturing.
16037 (EmitContext.CapturedField): New method used to register that a
16038 field must be flagged for capturing.
16040 (EmitContext.HaveCapturedVariables,
16041 EmitContext.HaveCapturedFields): Return whether there are captured
16042 variables or fields.
16044 (EmitContext.EmitMethodHostInstance): This is used to emit the
16045 instance for the anonymous method. The instance might be null
16046 (static methods), this (for anonymous methods that capture nothing
16047 and happen to live side-by-side with the current method body) or a
16048 more complicated expression if the method has a CaptureContext.
16050 (EmitContext.EmitTopBlock): Routine that drives the emission of
16051 code: it will first resolve the top block, then emit any metadata
16052 and then emit the code. The split is done so that we can extract
16053 any anonymous methods and flag any captured variables/parameters.
16055 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16056 during this phase, the ILGenerator should not be used as labels
16057 and local variables declared here might not be accessible to any
16058 code that is part of an anonymous method.
16060 Exceptions to this include the temporary variables that are
16061 created by some statements internally for holding temporary
16064 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16067 (EmitContext.TemporaryReturn): This method is typically called
16068 from the Emit phase, and its the only place where we allow the
16069 ReturnLabel to be defined other than the EmitMeta. The reason is
16070 that otherwise we would have to duplicate a lot of logic in the
16071 Resolve phases of various methods that today is on the Emit
16074 (EmitContext.NeedReturnLabel): This no longer creates the label,
16075 as the ILGenerator is not valid during the resolve phase.
16077 (EmitContext.EmitThis): Extended the knowledge in this class to
16078 work in anonymous methods in addition to iterators.
16080 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16081 code is necessary on the stack to access the instance to a local
16082 variable (the variable will be accessed as a field).
16084 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16085 EmitContext.EmitAddressOfParameter): Routines to support
16086 parameters (not completed at this point).
16088 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16089 will also remove the parameters.
16091 * convert.cs (Convert): Define a `ConstantEC' which points to a
16092 null. This is just to prefity some code that uses
16093 ImplicitStandardConversion code and do not have an EmitContext
16096 The idea is to flag explicitly that at that point in time, it is
16097 known that the conversion will not trigger the delegate checking
16098 code in implicit conversions (which requires a valid
16101 Everywhere: pass new EmitContext parameter since
16102 ImplicitStandardConversionExists now requires it to check for
16103 anonymous method conversions.
16105 (Convert.ImplicitStandardConversionExists): If the type of an
16106 expression is the anonymous_method_type, and the type is a
16107 delegate, we invoke the AnonymousMethod.Compatible method to check
16108 whether an implicit conversion is possible.
16110 (Convert.ImplicitConversionStandard): Only do implicit method
16111 group conversions if the language level is not ISO_1.
16113 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16114 MethodInfo for the Invoke method. used by Delegate and
16117 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16118 method conversions if the target type is a delegate.
16120 Removed extra debugging nops.
16122 (LocalVariableReference): Turn the `local_info' into a public
16125 Add `prepared' field, the same hack used for FieldExprs to cope
16126 with composed assignments, as Local variables do not necessarily
16127 operate purely on the stack as they used to: they can be captured
16130 Add `temp' for a temporary result, like fields.
16132 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16134 It now copes with Local variables that are captured and emits the
16135 proper instance variable to load it from a field in the captured
16138 (ParameterReference.DoResolveBase): During the resolve phase,
16139 capture parameters if we are in an anonymous method.
16141 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16142 anonymous method, use the EmitContext helper routines to emit the
16143 parameter reference.
16145 * iterators.cs: Set RemapToProxy to true/false during the
16148 * parameters.cs (GetParameterByName): New helper method.
16150 * typemanager.cs (anonymous_method_type) a new type that
16151 represents an anonyous method. This is always an internal type,
16152 used as a fencepost to test against the anonymous-methodness of an
16155 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16157 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16159 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16161 2004-10-18 Martin Baulig <martin@ximian.com>
16163 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16164 `Type' directly, but call ResolveType() on it.
16165 (Catch.Resolve): Likewise.
16166 (Foreach.Resolve): Likewise.
16168 2004-10-18 Martin Baulig <martin@ximian.com>
16170 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16171 `Type' directly, but call ResolveType() on it.
16172 (Probe.DoResolve): Likewise.
16173 (ArrayCreation.LookupType): Likewise.
16174 (TypeOf.DoResolve): Likewise.
16175 (SizeOf.DoResolve): Likewise.
16177 2004-10-18 Martin Baulig <martin@ximian.com>
16179 * expression.cs (Invocation.BetterFunction): Put back
16180 TypeManager.TypeToCoreType().
16182 2004-10-18 Raja R Harinath <rharinath@novell.com>
16184 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16187 2004-10-18 Martin Baulig <martin@ximian.com>
16189 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16190 `Type' directly, but call ResolveType() on it.
16192 2004-10-18 Martin Baulig <martin@ximian.com>
16194 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16195 `Type' directly, but call ResolveType() on it.
16196 (MemberBase.DoDefine): Likewise.
16198 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16199 `Type' directly, but call ResolveType() on it.
16200 (ComposedCast.DoResolveAsTypeStep): Likewise.
16202 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16203 `Type' directly, but call ResolveType() on it.
16205 2004-10-17 John Luke <john.luke@gmail.com>
16207 * class.cs (Operator.GetSignatureForError): use CSharpName
16209 * parameter.cs (Parameter.GetSignatureForError): Returns
16210 correct name even if was not defined.
16212 2004-10-13 Raja R Harinath <rharinath@novell.com>
16215 * class.cs (TypeContainer.EmitContext): New property.
16216 (DefineNestedTypes): Create an emitcontext for each part.
16217 (MethodCore.DoDefineParameters): Use container's emitcontext.
16218 Pass type array to InternalParameters.
16219 (MemberBase.DoDefine): Use container's emitcontext.
16220 (FieldMember.Define): Likewise.
16221 (Event.Define): Likewise.
16222 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16223 Pass type array to InternalParameters.
16224 (SetIndexerMethod.GetParameterInfo): Likewise.
16225 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16226 * delegate.cs (Define): Pass emitcontext to
16227 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16228 array to InternalParameters.
16229 * expression.cs (ParameterReference.DoResolveBase): Pass
16230 emitcontext to GetParameterInfo.
16231 (ComposedCast.DoResolveAsTypeStep): Remove check on
16232 ec.ResolvingTypeTree.
16233 * parameter.cs (Parameter.Resolve): Change argument to
16234 EmitContext. Use ResolveAsTypeTerminal.
16235 (Parameter.GetSignature): Change argument to EmitContext.
16236 (Parameters.ComputeSignature): Likewise.
16237 (Parameters.ComputeParameterTypes): Likewise.
16238 (Parameters.GetParameterInfo): Likewise.
16239 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16240 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16241 * support.cs (InternalParameters..ctor): Remove variant that takes
16243 * typemanager.cs (system_intptr_expr): New.
16244 (InitExpressionTypes): Initialize it.
16246 2004-10-12 Chris Toshok <toshok@ximian.com>
16248 * cs-parser.jay: fix location for try_statement and catch_clause.
16250 2004-10-11 Martin Baulig <martin@ximian.com>
16252 * report.cs: Don't make --fatal abort on warnings, we have
16253 -warnaserror for that.
16255 2004-10-07 Raja R Harinath <rharinath@novell.com>
16257 More DeclSpace.ResolveType avoidance.
16258 * decl.cs (MemberCore.InUnsafe): New property.
16259 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16260 with newly created EmitContext.
16261 (FieldMember.Define): Likewise.
16262 * delegate.cs (Delegate.Define): Likewise.
16263 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16264 only if normal name-lookup fails.
16265 (TypeExpr.DoResolve): Enable error-checking.
16266 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16267 (SizeOf.DoResolve): Likewise.
16268 (ComposedCast.DoResolveAsTypeStep): Likewise.
16269 (StackAlloc.DoResolve): Likewise.
16270 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16271 (Block.Unsafe): New property.
16272 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16273 (Unsafe): Set 'unsafe' flag of contained block.
16274 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16275 (Fixed.Resolve): Likewise.
16276 (Catch.Resolve): Likewise.
16277 (Using.ResolveLocalVariableDecls): Likewise.
16278 (Foreach.Resolve): Likewise.
16280 2004-10-05 John Luke <john.luke@gmail.com>
16282 * cs-parser.jay: add location to error CS0175
16284 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16286 * ecore.cs (Expression.Constantity): Add support for turning null
16289 * const.cs (Const.Define): Allow constants to be reference types
16290 as long as the value is Null.
16292 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16294 * namespace.cs (NamespaceEntry.Using): No matter which warning
16295 level is set, check if this namespace name has already been added.
16297 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16299 * expression.cs: reftype [!=]= null should always use br[true,false].
16302 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16305 * attribute.cs: Enum conversion moved to
16306 GetAttributeArgumentExpression to be applied to the all
16309 2004-10-01 Raja R Harinath <rharinath@novell.com>
16311 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16312 * class.c (TypeContainer.DefineType): Flag error if
16313 base types aren't accessible due to access permissions.
16314 * decl.cs (DeclSpace.ResolveType): Move logic to
16315 Expression.ResolveAsTypeTerminal.
16316 (DeclSpace.ResolveTypeExpr): Thin layer over
16317 Expression.ResolveAsTypeTerminal.
16318 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16319 Refactor code into NestedAccess. Use it.
16320 (DeclSpace.NestedAccess): New.
16321 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16322 argument to silence errors. Check access permissions.
16323 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16324 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16325 (Cast.DoResolve): Likewise.
16326 (New.DoResolve): Likewise.
16327 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16328 (TypeOf.DoResolve): Likewise.
16330 * expression.cs (Invocation.BetterConversion): Return the Type of
16331 the better conversion. Implement section 14.4.2.3 more faithfully.
16332 (Invocation.BetterFunction): Make boolean. Make correspondence to
16333 section 14.4.2.2 explicit.
16334 (Invocation.OverloadResolve): Update.
16335 (Invocation): Remove is_base field.
16336 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16337 (Invocation.Emit): Likewise.
16339 2004-09-27 Raja R Harinath <rharinath@novell.com>
16341 * README: Update to changes.
16343 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16345 * cs-parser.jay: Reverted 642 warning fix.
16347 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16350 * decl.cs (FindMemberWithSameName): Indexer can have more than
16353 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16355 * expression.cs (LocalVariableReference.DoResolveLValue):
16356 Do not report warning 219 for out values.
16357 (EmptyExpression.Null): New member to avoid extra allocations.
16359 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16361 * cs-parser.jay: Fix wrong warning 642 report.
16363 * cs-tokenizer.cs (CheckNextToken): New helper;
16364 Inspect next character if is same as expected.
16366 2004-09-23 Martin Baulig <martin@ximian.com>
16368 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16369 (Convert.ImplicitReferenceConversionExists): Likewise.
16371 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16373 * class.cs (Operator.Define): Add error 448 and 559 report.
16375 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16377 * class.cs (MemberBase.IsTypePermitted): New protected
16378 method for checking error CS0610.
16380 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16382 * class.cs (TypeContainer.HasExplicitLayout): New property
16383 Returns whether container has StructLayout attribute set Explicit.
16384 (FieldMember): New abstract class for consts and fields.
16385 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16386 (Field): Reuse FieldMember.
16388 * const.cs (Const): Reuse FieldMember.
16390 * rootcontext.cs: EmitConstants call moved to class.
16392 2004-09-22 Martin Baulig <martin@ximian.com>
16394 Thanks to Peter Sestoft for this bug report.
16396 * expression.cs (Conditional): If both the `trueExpr' and the
16397 `falseExpr' is a NullLiteral, return a NullLiteral.
16399 2004-09-22 Martin Baulig <martin@ximian.com>
16401 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16402 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16403 for the "get_Current" call.
16405 2004-09-22 Martin Baulig <martin@ximian.com>
16407 Marek and me just fixed one of our oldest bugs: #28562 :-)
16409 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16411 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16412 we're an EnumConstant, just return that.
16413 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16414 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16415 to get the value which'll actually be written into the attribute.
16416 However, we have to use GetValue() to access the attribute's value
16419 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16421 * constant.cs (Constant.IsNegative): New abstract property
16424 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16425 (StackAlloc.DoResolve): Reused IsNegative.
16427 2004-09-21 Martin Baulig <martin@ximian.com>
16429 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16430 if we're used in an iterator, we may be called from different
16433 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16434 we actually have an exception block.
16436 2004-09-20 John Luke <jluke@cfl.rr.com>
16438 * class.cs, cs-parser.jay: Improve the error report for 1520:
16439 report the actual line where the error happens, not where the
16440 class was declared.
16442 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16443 Pass location information that was available elsewhere.
16445 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16447 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16448 runtime to delay sign assemblies.
16450 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16452 * cs-parser.jay: Do not report the stack trace, this is barely
16455 2004-08-22 John Luke <john.luke@gmail.com>
16457 * driver.cs : check that a resource id is not already used
16458 before adding it, report CS1508 if it is, bug #63637
16460 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16462 * ecore.cs: Removed dead code.
16464 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16466 * class.cs: Do not report warning CS0067 on the interfaces.
16468 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16470 * cs-parser.jay: Add error 504 report.
16472 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16474 * rootcontext.cs: WarningLevel is 4 by default now.
16476 * statement.cs (Fixed.Resolve): Do not null
16479 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16482 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16483 deep search when property is not virtual.
16484 (PropertyExpr.ResolveAccessors): Make one call for both
16487 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16490 * statement.cs: Error 152 report constains also location.
16492 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16495 * const.cs: Explicitly set constant as static.
16497 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16500 * cs-parser.jay: Add error 1017 report.
16502 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16504 Fixed bug #59980, #64224
16505 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16507 * typemanager.cs (IsSpecialMethod): Simplified
16509 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16511 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16512 condition with better params.
16514 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16517 * attribute.cs (Resolve): Property has to have both
16520 2004-09-14 Martin Baulig <martin@ximian.com>
16522 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16524 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16527 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16528 called and is obsolete then this member suppress message
16529 when call is inside next [Obsolete] method or type.
16531 * expression.cs: Use TestObsoleteMethodUsage member.
16533 2004-09-14 Martin Baulig <martin@ximian.com>
16535 * cs-parser.jay: Sync a bit with the GMCS version.
16537 2004-09-14 Martin Baulig <martin@ximian.com>
16539 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16540 (CSharpParser.yacc_verbose_flag): New public field.
16542 * genericparser.cs: Removed.
16544 2004-09-14 Raja R Harinath <rharinath@novell.com>
16546 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16548 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16550 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16552 2004-09-10 Martin Baulig <martin@ximian.com>
16554 Backported my MemberName changes from GMCS into MCS.
16556 - we are now using a special `MemberName' class instead of using
16557 strings; in GMCS, the `MemberName' also contains the type
16560 - changed the grammar rules a bit:
16561 * the old `member_name' is now a `namespace_or_type_name':
16562 The rule is that we use `namespace_or_type_name' everywhere
16563 where we expect either a "member name" (GetEnumerator) or a
16564 "member name" with an explicit interface name
16565 (IEnumerable.GetEnumerator).
16566 In GMCS, the explicit interface name may include type arguments
16567 (IEnumerable<T>.GetEnumerator).
16568 * we use `member_name' instead of just `IDENTIFIER' for
16570 The rule is that we use `member_name' wherever a member may
16571 have type parameters in GMCS.
16573 * decl.cs (MemberName): New public class.
16574 (MemberCore.MemberName): New public readonly field.
16575 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16576 (DeclSpace): Likewise.
16578 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16579 * enum.cs (Enum.ctor): Likewise.
16581 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16583 (AliasEntry.ctor): Take a MemberName, not an Expression.
16584 (AliasEntry.UsingAlias): Likewise.
16586 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16587 (IMethodData.MemberName): Changed type from string to MemberName.
16588 (MemberBase.ExplicitInterfaceName): Likewise.
16589 (AbstractPropertyEventMethod.SetupName): Make this private.
16590 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16591 argument; compute the member name here.
16592 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16593 on the `member.MemberName' and the `prefix'.
16595 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16597 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16598 thus, we get a `MemberName' instead of a `string'. These
16599 declarations may have type parameters in GMCS.
16600 (interface_method_declaration, delegate_declaration): Likewise.
16601 (class_declaration, interface_declaration): Likewise.
16602 (method_header): Use `namespace_or_type_name' instead of
16603 `member_name'. We may be an explicit interface implementation.
16604 (property_declaration, event_declaration): Likewise.
16605 (member_name): This is now just an `IDENTIFIER', not a
16606 `namespace_or_type_name'.
16607 (type_name, interface_type): Removed.
16608 (namespace_or_type_name): Return a MemberName, not an Expression.
16609 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16610 call GetTypeExpression() on the MemberName to get an expression.
16611 (IndexerDeclaration.interface_type): Changed type from string to
16613 (MakeName): Operate on MemberName's instead of string's.
16615 2004-09-13 Raja R Harinath <rharinath@novell.com>
16618 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16619 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16620 lookup to avoid symbols introduced by 'using'.
16621 * rootcontext.cs (NamespaceLookup): Update.
16623 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16625 * class.cs (TypeContainer.DoDefineMembers): Do not call
16626 DefineDefaultConstructor for static classes.
16628 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16630 * attribute.cs (Attribute.Resolve): Add error 653 report.
16632 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16634 (Method.ApplyAttributeBuilder): Add error 685 report.
16635 (Operator.Define): Add error 564 report.
16637 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16639 * expression.cs (Invocation.DoResolve): Add error
16640 245 and 250 report.
16642 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16645 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16647 * class.cs (ConstructorInitializer.Resolve):
16648 Wrong error number (515->516).
16650 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16652 * class.cs (Indexer.Define): Add error 631 report.
16654 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16656 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16658 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16660 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16662 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16664 * cs-parser.jay: Added error CS0241 report.
16666 2004-09-10 Raja R Harinath <rharinath@novell.com>
16668 * cs-parser.jay (fixed_statement): Introduce a scope for the
16669 declaration in the 'fixed' statement.
16671 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16673 * cs-parser.jay: Added CS0230 error report.
16675 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16677 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16679 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16681 * expression.cs (Argument.Resolve): Added error CS0192 and
16684 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16686 C# 2.0 #pragma warning feature
16688 * cs-tokenizer.cs (PreProcessPragma): New method;
16689 Handles #pragma directive.
16691 * report.cs (WarningRegions): New class; Support
16692 class for #pragma warning directive. It tests whether
16693 warning is enabled for a given line.
16695 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16697 * const.cs: Add more descriptive error report, tahnks to
16700 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16702 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
16704 2004-09-07 Miguel de Icaza <miguel@ximian.com>
16706 * expression.cs: Apply patch from Ben: Remove dead code from
16707 ArrayCreation, and remove the TurnintoConstant call in const.cs,
16708 as that code just threw an exception anwyays.
16710 * const.cs: Remove the call to the turnintoconstant, for details
16713 * literal.cs: The type of the null-literal is the null type; So
16714 we use a placeholder type (literal.cs:System.Null, defined here)
16717 * expression.cs (Conditional.DoResolve): Remove some old code that
16718 is no longer needed, conversions have been fixed.
16720 (ArrayCreationExpression.DoResolve): Return false if we fail to
16721 resolve the inner expression.
16723 2004-09-07 Raja R Harinath <rharinath@novell.com>
16726 * cs-parser.jay (delegate_declaration): Record a delegate
16727 declaration as a type declaration.
16728 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
16730 2004-09-06 Miguel de Icaza <miguel@ximian.com>
16732 * parameter.cs: Do not crash if the type can not be resolved.
16734 * expression.cs: Report errors with unsafe pointers, fixes #64896
16736 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
16738 * expression.cs: Pointer arith always needs to do a conv.i
16739 if the operand is a long. fix 65320
16741 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16743 Fixed cs0619-37.cs, cs0619-38.cs
16745 * enum.cs (GetObsoleteAttribute): Removed.
16747 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
16748 on Enum member is double staged. The first is tested member
16751 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16753 Fixed #56986, #63631, #65231
16755 * class.cs: (TypeContainer.AddToMemberContainer): New method,
16756 adds member to name container.
16757 (TypeContainer.AddToTypeContainer): New method, adds type to
16759 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
16760 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
16761 AddOperator): Simplified by reusing AddToMemberContainer.
16762 (TypeContainer.UserDefinedStaticConstructor): Changed to property
16764 (Method.CheckForDuplications): Fixed implementation to test all
16766 (MemberBase): Detection whether member is explicit interface
16767 implementation is now in constructor.
16768 (MemberBase.UpdateMemberName): Handles IndexerName.
16769 (Accessor): Changed to keep also location information.
16770 (AbstractPropertyEventMethod): Is derived from MemberCore.
16771 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
16772 will be emited or not.
16773 (PropertyBase.AreAccessorsDuplicateImplementation):
16774 Tests whether accessors are not in collision with some method.
16775 (Operator): Is derived from MethodCore to simplify common
16778 * decl.cs (Flags.TestMethodDuplication): Test for duplication
16780 (DeclSpace.AddToContainer): Adds the member to defined_names
16781 table. It tests for duplications and enclosing name conflicts.
16783 * enum.cs (EnumMember): Clean up to reuse the base structures
16785 2004-09-03 Martin Baulig <martin@ximian.com>
16787 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
16788 into TypeContainer, to make partial classes work again.
16790 2004-09-03 Martin Baulig <martin@ximian.com>
16792 * rootcontext.cs (RootContext.V2): Removed.
16794 2004-03-23 Martin Baulig <martin@ximian.com>
16796 * expression.cs (Invocation.OverloadResolve): Added `bool
16797 may_fail' argument and use it instead of the Location.IsNull() hack.
16799 2004-09-03 Martin Baulig <martin@ximian.com>
16801 Merged latest changes into gmcs. Please keep this comment in
16802 here, it makes it easier for me to see what changed in MCS since
16803 the last time I merged.
16805 2004-09-03 Raja R Harinath <rharinath@novell.com>
16808 * expression.cs (BetterConversion): Don't allow either conversion
16809 to be null. Remove redundant implicit conversion test when 'q ==
16810 null' -- when this function is invoked, we already know that the
16811 implicit conversion exists.
16812 (BetterFunction): Assume that 'best' is non-null. Remove
16813 redundant reimplementation of IsApplicable when 'best' is null.
16814 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
16815 number of arguments.
16816 (IsAncestralType): Extract from OverloadResolve.
16817 (OverloadResolve): Make robust to the MethodGroupExpr being
16818 unsorted. Implement all the logic of Section 14.5.5.1, and
16819 support overloading of methods from multiple applicable types.
16820 Clean up logic somewhat. Don't pass null methods to BetterFunction.
16822 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
16823 (RealError, Warning): Append type of report to related symbol.
16825 2004-09-03 Marek Safar <marek.safar@seznam.cz>
16827 * enum.cs: Fixed CLS-Compliance checks for enum members.
16828 Error tests cs3008-8.cs, cs3014-8.cs
16830 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16832 Fixed bug #62342, #63102
16833 * class.cs: ImplementIndexer uses member.IsExplicitImpl
16834 like ImplementMethod.
16836 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16838 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16841 2004-09-02 Martin Baulig <martin@ximian.com>
16843 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
16844 TypeManager.GetArgumentTypes() rather than calling GetParameters()
16847 2004-09-01 Marek Safar <marek.safar@seznam.cz>
16849 C# 2.0 Static classes implemented
16851 * class.cs (TypeContainer): instance_constructors,
16852 initialized_fields, initialized_static_fields,
16853 default_constructor, base_inteface_types are protected to be
16854 accessible from StaticClass.
16855 (TypeContainer.DefineDefaultConstructor): New virtual method
16856 for custom default constructor generating
16857 (StaticClass): New class to handle "Static classes" feature.
16859 * cs-parser.jay: Handle static keyword on class like instance
16862 * driver.cs: Added "/langversion" command line switch with two
16863 options (iso-1, default).
16865 2004-08-31 Marek Safar <marek.safar@seznam.cz>
16867 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
16869 2004-08-31 Miguel de Icaza <miguel@ximian.com>
16871 * delegate.cs: Style.
16873 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
16875 * delegate.cs: Add seperate instance expr field for miguel.
16877 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16879 * PointerArithmetic (Resolve): make sure we are not doing
16880 pointer arith on void*. Also, make sure we are resolved
16881 by not setting eclass until resolve.
16883 All callers: Make sure that PointerArithmetic gets resolved.
16885 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16887 * ArrayCreation (LookupType): If the type does not resolve
16888 to an array, give an error.
16890 2004-08-27 Marek Safar <marek.safar@seznam.cz>
16892 * statement.cs (Try.Resolve): Fixed bug #64222
16894 2004-08-27 Martin Baulig <martin@ximian.com>
16897 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
16900 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16902 * ecore.cs (Constantify): Get underlying type via
16903 System.Enum.GetUnderlyingType to avoid StackOverflow on the
16904 Windows in special cases.
16906 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16908 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
16909 for obtaining also private methods.
16910 (GetRemoveMethod): Used GetRemoveMethod (true)
16911 for obtaining also private methods.
16913 2004-08-24 Martin Baulig <martin@ximian.com>
16915 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
16916 MethodAttributes.HideBySig for operators.
16918 2004-08-23 Martin Baulig <martin@ximian.com>
16920 Back to the old error reporting system :-)
16922 * report.cs (Message): Removed.
16923 (Report.MessageData, ErrorData, WarningData): Removed.
16924 (Report.Error, Warning): Back to the old system.
16926 2004-08-23 Martin Baulig <martin@ximian.com>
16928 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
16930 * class.cs (TypeContainer.ParentContainer): New public virtual
16931 method; replaces the explicit interface implementation.
16932 (ClassPart.ParentContainer): Override.
16934 2004-08-23 Martin Baulig <martin@ximian.com>
16936 * statement.cs (Switch): Added support for constant switches; see
16937 #59428 or test-285.cs.
16939 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16942 * statement.cs (GetEnumeratorFilter): Removed useless
16943 logic because C# specs is strict. GetEnumerator must be
16946 2004-08-22 Martin Baulig <martin@ximian.com>
16948 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
16949 a switch and may break, reset the barrier. Fixes #59867.
16951 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16953 CLS-Compliance speed up (~5% for corlib)
16955 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
16956 New method. Tests container for CLS-Compliant names
16958 * class.cs (TypeContainer.VerifyClsName): New method.
16959 Checks whether container name is CLS Compliant.
16960 (Constructor): Implements IMethodData.
16962 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
16963 low-case table for CLS Compliance test.
16964 (MemberCache.VerifyClsParameterConflict): New method.
16965 Checks method parameters for CS3006 error.
16967 * enum.cs (EnumMember): Is derived from MemberCore.
16968 (Enum.VerifyClsName): Optimized for better performance.
16970 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16972 * report.cs: Renamed Error_T to Error and changed all
16975 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16977 * class.cs (TypeContainer.IndexerArrayList): New inner class
16978 container for indexers.
16979 (TypeContainer.DefaultIndexerName): New constant for default
16980 indexer name. Replaced all "Item" with this constant.
16981 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
16983 * typemanager.cs (TypeManager.default_member_ctor): Cache here
16984 DefaultMemberAttribute constructor.
16986 2004-08-05 Martin Baulig <martin@ximian.com>
16988 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
16991 2004-08-05 Marek Safar <marek.safar@seznam.cz>
16993 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
16994 multi platforms problem.
16996 * compiler.csproj: Included shared files.
16998 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17000 Fix bug 60333, 55971 in the more general way
17001 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17002 Added arg_type argument for constant conversion.
17003 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17005 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17008 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17009 OperatorArrayList, MethodCoreArrayList for typecontainer
17010 containers. Changed class member types to these new types.
17011 (MethodArrayList.DefineMembers): Added test for CS0659.
17013 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17015 * cfold.cs: Synchronize the folding with the code in expression.cs
17016 Binary.DoNumericPromotions for uint operands.
17018 * attribute.cs: Revert patch from Raja, it introduced a regression
17019 while building Blam-1.2.1 (hard to isolate a test case).
17021 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17025 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17027 (MethodCore.parent_method): New member. The method we're overriding
17028 if this is an override method.
17029 (MethodCore.CheckBase): Moved from Method class and made common.
17030 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17032 (MethodCore.CheckForDuplications): New abstract method. For custom
17033 member duplication search in a container
17034 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17035 method and its return type.
17036 (Event.conflict_symbol): New member. Symbol with same name in the
17040 (MemberCache.FindMemberWithSameName): New method. The method
17041 is looking for conflict with inherited symbols.
17043 2004-08-04 Martin Baulig <martin@ximian.com>
17045 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17047 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17049 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17051 * report.cs (Message): New enum for better error, warning reference in
17053 (MessageData): New inner abstract class. It generally handles printing of
17054 error and warning messages.
17055 Removed unused Error, Warning, Message methods.
17057 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17059 Fix for cs0592-8.cs test
17061 (Attributable.ValidAttributeTargets): Made public.
17062 (Attribute.ExplicitTarget): New member for explicit target value.
17063 (Attribute.CheckTargets): Now we translate explicit attribute
17064 target to Target here.
17066 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17068 * ecore.cs (MethodGroupExpr): new IsBase property.
17070 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17072 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17073 rather than an instance expr.
17075 (DelegateCreation.Emit): Use the method group rather than
17076 the instance expression. Also, if you have base.Foo as the
17077 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17079 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17081 (NewDelegate.DoResolve): Only check for the existance of Invoke
17082 if the method is going to be needed. Use MethodGroupExpr.
17084 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17086 * expression.cs: For pointer arith., make sure to use
17087 the size of the type, not the size of the pointer to
17090 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17093 * class.cs (Class): Added error CS0502 test.
17095 2004-08-03 John Luke <jluke@cfl.rr.com>
17096 Raja R Harinath <rharinath@novell.com>
17099 * attribute.cs (Attribute.complained_before): New flag.
17100 (Attribute.ResolveType, Attribute.Resolve),
17101 (Attribute.DefinePInvokeMethod): Set it.
17102 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17104 2004-08-03 Martin Baulig <martin@ximian.com>
17106 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17107 use a user-defined operator; we still need to do numeric
17108 promotions in case one argument is a builtin type and the other
17109 one has an implicit conversion to that type. Fixes #62322.
17111 2004-08-02 Martin Baulig <martin@ximian.com>
17113 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17114 (LocalInfo.IsThis): New public property.
17115 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17117 2004-08-01 Martin Baulig <martin@ximian.com>
17119 * class.cs (TypeContainer.GetClassBases): Don't set the default
17120 here since we may get called from GetPartialBases().
17121 (TypeContainer.DefineType): If GetClassBases() didn't return a
17122 parent, use the default one.
17124 2004-07-30 Duncan Mak <duncan@ximian.com>
17126 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17128 2004-07-30 Martin Baulig <martin@ximian.com>
17130 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17132 * class.cs (SourceMethod): New public class, derive from the
17133 symbol writer's ISourceMethod.
17134 (Method): Use the new symbol writer API.
17136 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17137 as argument and use the new symbol writer.
17140 (SourceFile): Implement the symbol writer's ISourceFile.
17141 (Location.SymbolDocument): Removed.
17142 (Location.SourceFile): New public property.
17144 * symbolwriter.cs: Use the new symbol writer API.
17146 2004-07-30 Raja R Harinath <rharinath@novell.com>
17148 * Makefile (install-local): Remove. Functionality moved to
17151 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17153 * Makefile: Install mcs.exe.config file together with mcs.exe.
17154 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17155 correct runtime version.
17157 2004-07-25 Martin Baulig <martin@ximian.com>
17160 (TypeContainer.RegisterOrder): Removed, this was unused.
17161 (TypeContainer, interface_order): Removed.
17162 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17163 TypeContainer as argument since we can also be called with a
17164 `PartialContainer' for a partial class/struct/interface.
17165 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17166 of checking whether we're an `Interface' - we could be a
17167 `PartialContainer'.
17168 (PartialContainer.Register): Override; call
17169 AddClass()/AddStruct()/AddInterface() on our parent.
17171 * cs-parser.jay (interface_member_declaration): Add things to the
17172 `current_container', not the `current_class'.
17174 * rootcontext.cs (RegisterOrder): The overloaded version which
17175 takes an `Interface' was unused, removed.
17177 * typemanager.cs (TypeManager.LookupInterface): Return a
17178 `TypeContainer', not an `Interface'.
17179 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17180 contain a `PartialContainer' for an interface, so check it's
17181 `Kind' to figure out what it is.
17183 2004-07-25 Martin Baulig <martin@ximian.com>
17185 * class.cs (Class.DefaultTypeAttributes): New public constant.
17186 (Struct.DefaultTypeAttributes): Likewise.
17187 (Interface.DefaultTypeAttributes): Likewise.
17188 (PartialContainer.TypeAttr): Override this and add the
17189 DefaultTypeAttributes.
17191 2004-07-25 Martin Baulig <martin@ximian.com>
17193 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17194 we can just use the `Parent' field instead.
17196 2004-07-25 Martin Baulig <martin@ximian.com>
17198 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17200 2004-07-25 Martin Baulig <martin@ximian.com>
17202 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17203 our parts before defining any methods.
17204 (TypeContainer.VerifyImplements): Make this virtual.
17205 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17206 on our PartialContainer.
17208 2004-07-25 Martin Baulig <martin@ximian.com>
17210 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17212 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17213 argument, we can just use the `Parent' field instead.
17216 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17217 (MemberBase.DoDefine): Likewise.
17219 2004-07-24 Martin Baulig <martin@ximian.com>
17221 * decl.cs (MemberCore.Parent): New public field.
17222 (DeclSpace.Parent): Moved to MemberCore.
17224 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17225 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17227 (FieldBase, Field, Operator): Likewise.
17228 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17229 (EventField, Event): Likewise.
17231 2004-07-23 Martin Baulig <martin@ximian.com>
17233 * class.cs (PartialContainer): New public class.
17234 (ClassPart): New public class.
17235 (TypeContainer): Added support for partial classes.
17236 (TypeContainer.GetClassBases): Splitted some of the functionality
17237 out into GetNormalBases() and GetPartialBases().
17239 * cs-tokenizer.cs (Token.PARTIAL): New token.
17240 (Tokenizer.consume_identifier): Added some hacks to recognize
17241 `partial', but only if it's immediately followed by `class',
17242 `struct' or `interface'.
17244 * cs-parser.jay: Added support for partial clases.
17246 2004-07-23 Martin Baulig <martin@ximian.com>
17248 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17249 a `DeclSpace' and also made it readonly.
17250 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17251 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17252 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17254 * cs-parser.jay: Pass the `current_class', not the
17255 `current_container' (at the moment, this is still the same thing)
17256 to a new Method, Property, Event, Indexer or Constructor.
17258 2004-07-23 Martin Baulig <martin@ximian.com>
17260 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17261 and removed the `current_interface' one.
17262 (struct_declaration, class_declaration, interface_declaration):
17263 Set `current_class' to the newly created class/struct/interface;
17264 set their `Bases' and call Register() before parsing their body.
17266 2004-07-23 Martin Baulig <martin@ximian.com>
17268 * class.cs (Kind): New public enum.
17269 (TypeContainer): Made this class abstract.
17270 (TypeContainer.Kind): New public readonly field.
17271 (TypeContainer.CheckDef): New public method; moved here from
17273 (TypeContainer.Register): New public abstract method.
17274 (TypeContainer.GetPendingImplementations): New public abstract
17276 (TypeContainer.GetClassBases): Removed the `is_class' and
17277 `is_iface' parameters.
17278 (TypeContainer.DefineNestedTypes): Formerly known as
17280 (ClassOrStruct): Made this class abstract.
17282 * tree.cs (RootTypes): New public type.
17284 2004-07-20 Martin Baulig <martin@ximian.com>
17286 * tree.cs (Tree.RecordNamespace): Removed.
17287 (Tree.Namespaces): Removed.
17289 * rootcontext.cs (RootContext.IsNamespace): Removed.
17291 * cs-parser.jay (namespace_declaration): Just create a new
17292 NamespaceEntry here.
17294 2004-07-20 Martin Baulig <martin@ximian.com>
17296 * statement.cs (ExceptionStatement): New abstract class. This is
17297 now used as a base class for everyone who's using `finally'.
17298 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17299 our local variables before using them.
17301 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17302 virtual method. This is used by Yield.Resolve() to "steal" an
17303 outer block's `finally' clauses.
17304 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17307 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17308 version which takes an ExceptionStatement. This version must be
17309 used to create exception branchings.
17312 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17313 (Iterator.EmitMoveNext): Added exception support; protect the
17314 block with a `fault' clause, properly handle 'finally' clauses.
17315 (Iterator.EmitDispose): Run all the `finally' clauses here.
17317 2004-07-20 Martin Baulig <martin@ximian.com>
17319 * iterator.cs: This is the first of a set of changes in the
17320 iterator code. Match the spec more closely: if we're an
17321 IEnumerable, then GetEnumerator() must be called. The first time
17322 GetEnumerator() is called, it returns the current instance; all
17323 subsequent invocations (if any) must create a copy.
17325 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17327 * expression.cs: Resolve the constant expression before returning
17330 2004-07-19 Martin Baulig <martin@ximian.com>
17332 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17333 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17334 the return type of the new EmitContext.
17336 2004-07-18 Martin Baulig <martin@ximian.com>
17338 * class.cs (Property.Define): Fix iterators.
17340 * iterators.cs (Iterator.Define): Moved the
17341 `container.AddInterator (this)' call here from the .ctor; only do
17342 it if we resolved successfully.
17344 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17346 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17347 `true' for preprocessing directives that we parse. The return
17348 value indicates whether we should return to regular tokenizing or
17349 not, not whether it was parsed successfully.
17351 In the past if we were in: #if false ... #line #endif, we would
17352 resume parsing after `#line'. See bug 61604.
17354 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17355 building: IsEnumType should return true only for enums, not for
17356 enums or System.Enum itself. This fixes #61593.
17358 Likely what happened is that corlib was wrong: mcs depended on
17359 this bug in some places. The bug got fixed, we had to add the
17360 hack, which caused bug 61593.
17362 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17363 that was a workaround for the older conditions.
17365 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17367 * assign.cs: IAssignMethod has a new interface, as documented
17368 inline. All assignment code now uses this new api.
17370 * ecore.cs, expression.cs: All classes which implement
17371 IAssignMethod now use the new interface.
17373 * expression.cs (Invocation): add a hack to EmitCall so that
17374 IndexerAccess can be the target of a compound assignment without
17375 evaluating its arguments twice.
17377 * statement.cs: Handle changes in Invocation api.
17379 2004-07-16 Martin Baulig <martin@ximian.com>
17381 * iterators.cs: Rewrote this. We're now using one single Proxy
17382 class for both the IEnumerable and the IEnumerator interface and
17383 `Iterator' derives from Class so we can use the high-level API.
17385 * class.cs (TypeContainer.AddIterator): New method.
17386 (TypeContainer.DoDefineType): New protected virtual method, which
17387 is called from DefineType().
17388 (TypeContainer.DoDefineMembers): Call DefineType() and
17389 DefineMembers() on all our iterators.
17390 (TypeContainer.Emit): Call Emit() on all our iterators.
17391 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17393 * codegen.cs (EmitContext.CurrentIterator): New public field.
17395 2004-07-15 Martin Baulig <martin@ximian.com>
17398 (TypeManager.not_supported_exception_type): New type.
17400 2004-07-14 Martin Baulig <martin@ximian.com>
17402 * iterators.cs: Use real error numbers.
17404 2004-07-14 Martin Baulig <martin@ximian.com>
17406 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17407 requires this to be a System.Collection.IEnumerable and not a
17408 class implementing that interface.
17409 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17411 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17413 * class.cs: Fixed previous fix, it broke some error tests.
17415 2004-07-12 Martin Baulig <martin@ximian.com>
17417 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17420 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17422 * assign.cs (LocalTemporary): Add new argument: is_address,If
17423 `is_address' is true, then the value that we store is the address
17424 to the real value, and not the value itself.
17426 * ecore.cs (PropertyExpr): use the new local temporary
17427 stuff to allow us to handle X.Y += z (where X is a struct)
17429 2004-07-08 Martin Baulig <martin@ximian.com>
17431 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17432 not always return, just like we're doing in Using.Resolve().
17434 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17436 * cs-parser.jay (fixed_statement): flag this as Pinned.
17438 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17440 * typemanager.cs (TypeManager): Removed MakePinned method, this
17441 mechanism is replaced with the .NET 2.x compatible mechanism of
17442 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17444 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17445 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17446 `IsFixed' property which has a different meaning.
17448 2004-07-02 Raja R Harinath <rharinath@novell.com>
17450 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17451 visible from inside a nested class, not just the names of the
17452 immediately enclosing class.
17453 Fix for bug #60730.
17455 2004-06-24 Raja R Harinath <rharinath@novell.com>
17457 * expression.cs (BetterConversion): Remove buggy special-case
17458 handling of "implicit constant expression conversions". At this
17459 point, we already know that the conversion is possible -- we're
17460 only checking to see which is better.
17462 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17464 * cs-parser.jay: Added error CS0210 test.
17466 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17468 * cs-parser.jay: Added error CS0134 test.
17470 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17473 * cs-parser.jay: Added error CS0145 test.
17475 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17477 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17479 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17481 * expression.cs (StackAlloc.Resolve): The argument may not
17482 be a constant; deal with this case.
17484 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17486 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17487 GetIndexerAttributeValue.
17488 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17490 * class.cs (Indexer.Define): Added error tests for CS0415,
17493 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17495 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17498 2004-06-23 Martin Baulig <martin@ximian.com>
17500 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17501 neither return nor throw, reset the barrier as well. Fixes #60457.
17503 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17505 * class.cs : EventAttributes is now set to None by default.
17506 This fixes bug #60459.
17508 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17511 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17512 Don't throw exception but return null (it's sufficient now).
17514 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17516 * typemanager.cs (GetArgumentTypes): Faster implementation.
17518 2004-06-18 Martin Baulig <martin@ximian.com>
17520 * attribute.cs (Attribute.Resolve): Check whether we're an
17521 EmptyCast which a Constant child. Fixes #60333.
17523 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17525 * statement.cs (EmitCollectionForeach): Account for the fact that
17526 not all valuetypes are in areas which we can take the address of.
17527 For these variables, we store to a temporary variable. Also, make
17528 sure that we dont emit a `callvirt' on a valuetype method.
17530 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17532 * expression.cs (StackAlloc.DoReSolve): Added test for
17533 negative parameter (CS0247).
17535 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17538 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17540 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17543 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17546 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17548 Fix bug #58254 & cs1555.cs, cs1556.cs
17549 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17551 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17553 * cs-parser.jay: Added error CS1669 test for indexers.
17555 2004-06-11 Martin Baulig <martin@ximian.com>
17557 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17558 call this twice: for params and varargs methods.
17560 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17563 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17565 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17567 * attribute.cs (Attribute.GetValidTargets): Made public.
17570 (AbstractPropertyEventMethod): New class for better code sharing.
17571 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17573 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17575 2004-06-11 Raja R Harinath <rharinath@novell.com>
17578 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17579 that the call to Resolve is part of a MemberAccess.
17580 (Expression.Resolve): Use it for SimpleName resolution.
17581 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17582 Add 'intermediate' boolean argument.
17583 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17584 error message when the SimpleName can be resolved ambiguously
17585 between an expression and a type.
17586 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17588 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17589 call on the left-side.
17591 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17594 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17596 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17598 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17600 2004-06-11 Martin Baulig <martin@ximian.com>
17602 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17603 varargs methods if applicable.
17605 2004-06-11 Martin Baulig <martin@ximian.com>
17607 * expression.cs (Invocation.EmitCall): Don't use
17608 `method.CallingConvention == CallingConventions.VarArgs' since the
17609 method could also have `CallingConventions.HasThis'.
17611 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17613 * class.cs (Event.GetSignatureForError): Implemented.
17614 Fixed crash in error test cs3010.cs
17616 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17618 * cs-tokenizer.cs: Change the way we track __arglist to be
17619 consistent with the other keywords.
17621 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17623 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17626 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17628 * codegen.cs: Check that all referenced assemblies have a strongname
17629 before strongnaming the compiled assembly. If not report error CS1577.
17630 Fix bug #56563. Patch by Jackson Harper.
17631 * typemanager.cs: Added a method to return all referenced assemblies.
17632 Fix bug #56563. Patch by Jackson Harper.
17634 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17637 (Method.ApplyAttributeBuilder): Moved and added conditional
17638 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17641 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17643 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17646 * class.cs: (EventField.attribute_targets): Changed default target.
17648 2004-06-08 Martin Baulig <martin@ximian.com>
17650 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17652 2004-06-08 Martin Baulig <martin@ximian.com>
17654 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17656 2004-06-07 Martin Baulig <martin@ximian.com>
17658 Added support for varargs methods.
17660 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17663 * cs-parser.jay: Added support for `__arglist'.
17665 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17667 * expression.cs (Argument.AType): Added `ArgList'.
17668 (Invocation): Added support for varargs methods.
17669 (ArglistAccess): New public class.
17670 (Arglist): New public class.
17672 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17674 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17675 a method's top-level block if the method has varargs.
17677 * support.cs (ReflectionParameters, InternalParameters): Added
17678 support for varargs methods.
17680 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17682 * class.cs: Provide location in indexer error report.
17684 * driver.cs: Use standard names.
17686 * namespace.cs: Catch the use of using after a namespace has been
17687 declared also on using aliases.
17689 2004-06-03 Raja R Harinath <rharinath@novell.com>
17692 * typemanager.cs (closure_private_ok, closure_invocation_type)
17693 (closure_qualifier_type, closure_invocation_assembly)
17694 (FilterWithClosure): Move to ...
17695 (Closure): New internal nested class.
17696 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17697 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17698 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17699 (MemberLookup, MemberLookupFailed): Use it.
17700 * expression.cs (New.DoResolve): Treat the lookup for the
17701 constructor as being qualified by the 'new'ed type.
17702 (Indexers.GetIndexersForTypeOrInterface): Update.
17704 2004-06-03 Marek Safar <marek.safar@seznam.cz>
17707 (GetConditionalAttributeValue): New method. Returns
17708 condition of ConditionalAttribute.
17709 (SearchMulti): New method. Returns all attributes of type 't'.
17710 Use it when attribute is AllowMultiple = true.
17711 (IsConditionalMethodExcluded): New method.
17714 (Method.IsExcluded): Implemented. Returns true if method has conditional
17715 attribute and the conditions is not defined (method is excluded).
17716 (IMethodData): Extended interface for ConditionalAttribute support.
17717 (PropertyMethod.IsExcluded): Implemented.
17720 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
17723 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
17726 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
17728 * expression.cs (ArrayCreationExpression): Make this just an
17729 `expression'. It can't be a statement, so the code here was
17732 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17735 * typemanager.cs (GetFullNameSignature): New method for
17738 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17741 * class.cs (MemberBase.GetSignatureForError): New virtual method.
17742 Use this method when MethodBuilder is null.
17743 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
17744 Added test for error CS0626 (MONO reports error for this situation).
17745 (IMethodData.GetSignatureForError): Extended interface.
17747 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17750 (AttributeTester.GetObsoleteAttribute): Returns instance of
17751 ObsoleteAttribute when type is obsolete.
17754 (TypeContainer.VerifyObsoleteAttribute): Override.
17755 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
17756 (MethodCode.VerifyObsoleteAttribute): Override.
17757 (MemberBase.VerifyObsoleteAttribute): Override.
17760 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
17761 and report proper error.
17764 Delegate.VerifyObsoleteAttribute): Override.
17767 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
17768 and report proper error.
17769 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
17772 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
17776 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
17777 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
17778 Added test for ObsoleteAttribute.
17781 (Catch): Derived from Statement.
17783 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17785 Fixed bug #59071 & cs0160.cs
17787 * statement.cs (Try.Resolve): Check here whether order of catch
17788 clauses matches their dependencies.
17790 2004-05-31 Miguel de Icaza <miguel@ximian.com>
17792 * Reverted patch to namespace.cs (Use lookuptypedirect). This
17793 caused a regression: #59343. Referencing nested classes from an
17794 assembly stopped working.
17796 2004-05-31 Martin Baulig <martin@ximian.com>
17798 MCS is now frozen for beta 2.
17800 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17802 * convert.cs: add a trivial cache for overload operator resolution.
17804 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17806 * decl.cs: If possible, use lookuptypedirect here. We can only do
17807 this if there is no `.' after the namespace. Avoids using
17808 LookupType, which does lots of slow processing.
17809 (FindNestedType) New method, does what it says :-).
17810 * namespace.cs: use LookupTypeDirect.
17811 * rootcontext.cs: use membercache, if possible.
17812 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
17814 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17817 According to the spec,
17819 In a member access of the form E.I, if E is a single identifier,
17820 and if the meaning of E as a simple-name (§7.5.2) is a constant,
17821 field, property, localvariable, or parameter with the same type as
17822 the meaning of E as a type-name (§3.8), then both possible
17823 meanings of E are permitted.
17825 We did not check that E as a simple-name had the same type as E as
17828 This trivial check gives us 5-7% on bootstrap time.
17830 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17832 * expression.cs (Invocation.OverloadResolve): Avoid the
17833 use of hashtables and boxing here by allocating on demand.
17835 2004-05-30 Martin Baulig <martin@ximian.com>
17837 * rootcontext.cs (RootContext.LookupType): Don't cache things if
17838 we're doing a silent lookup. Don't try to lookup nested types in
17839 TypeManager.object_type (thanks to Ben Maurer).
17841 2004-05-30 Martin Baulig <martin@ximian.com>
17843 Committing a patch from Ben Maurer.
17845 * rootcontext.cs (RootContext.LookupType): Cache negative results.
17847 2004-05-29 Martin Baulig <martin@ximian.com>
17849 * class.cs (IMethodData.ShouldIgnore): New method.
17851 * typemanager.cs (TypeManager.MethodFlags): Don't take a
17852 `Location' argument, we don't need it anywhere. Use
17853 `IMethodData.ShouldIgnore ()' instead of
17854 `MethodData.GetMethodFlags ()'.
17855 (TypeManager.AddMethod): Removed.
17856 (TypeManager.AddMethod2): Renamed to AddMethod.
17858 2004-05-29 Martin Baulig <martin@ximian.com>
17860 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
17862 * convert.cs (Convert.ImplicitReferenceConversion): If we're
17863 converting from a class type S to an interface type and we already
17864 have an object on the stack, don't box it again. Fixes #52578.
17866 2004-05-29 Martin Baulig <martin@ximian.com>
17868 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17869 Added support for `params' parameters. Fixes #59267.
17871 2004-05-29 Martin Baulig <martin@ximian.com>
17873 * literal.cs (NullPointer): Provide a private .ctor which sets
17874 `type' to TypeManager.object_type. Fixes #59048.
17876 2004-05-29 Martin Baulig <martin@ximian.com>
17878 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
17879 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
17881 * ecore.cs (EventExpr.instance_expr): Make the field private.
17883 2004-05-26 Marek Safar <marek.safar@seznam.cz>
17885 Fixed bug #50080 & cs0214-2.cs
17886 * expression.cs (Cast.DoResolve): Check unsafe context here.
17888 * statement.cs (Resolve.DoResolve): Likewise.
17890 2004-05-26 Martin Baulig <martin@ximian.com>
17892 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
17894 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
17895 (RootContext.LookupType): Pass down the `silent' flag.
17897 2004-05-25 Martin Baulig <martin@ximian.com>
17900 (MethodGroupExpr.IdenticalTypeName): New public property.
17901 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
17902 expression actually refers to a type.
17904 2004-05-25 Martin Baulig <martin@ximian.com>
17906 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
17907 for #56176 and made it actually work.
17909 2004-05-25 Martin Baulig <martin@ximian.com>
17911 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
17912 (FieldExpr, PropertyExpr): Override and implement
17913 CacheTemporaries. Fixes #52279.
17915 2004-05-25 Miguel de Icaza <miguel@ximian.com>
17917 * location.cs: In the new compiler listing a file twice is a
17918 warning, not an error.
17920 2004-05-24 Martin Baulig <martin@ximian.com>
17922 * enum.cs (Enum.DefineType): For the `BaseType' to be a
17923 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
17925 2004-05-24 Martin Baulig <martin@ximian.com>
17927 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
17928 walking the `using' list. Fixes #53921.
17930 2004-05-24 Martin Baulig <martin@ximian.com>
17932 * const.cs (Const.LookupConstantValue): Added support for
17933 EmptyCast's; fixes #55251.
17935 2004-05-24 Martin Baulig <martin@ximian.com>
17937 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
17938 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
17939 which does the CS0135 check. The reason is that we first need to
17940 check whether the variable actually exists.
17942 2004-05-24 Martin Baulig <martin@ximian.com>
17944 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
17945 than RootContext.LookupType() to find the explicit interface
17946 type. Fixes #58584.
17948 2004-05-24 Raja R Harinath <rharinath@novell.com>
17950 * Makefile: Simplify. Use executable.make.
17951 * mcs.exe.sources: New file. List of sources of mcs.exe.
17953 2004-05-24 Anders Carlsson <andersca@gnome.org>
17957 Use the invariant culture when doing String.Compare for CLS case
17960 2004-05-23 Martin Baulig <martin@ximian.com>
17962 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
17963 don't have any dots. Fixes #52622, added cs0246-8.cs.
17965 * namespace.cs (NamespaceEntry.Lookup): Likewise.
17967 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17969 * class.cs (MemberBase.Define): Reuse MemberType member for
17970 resolved type. Other methods can use it too.
17972 2004-05-23 Martin Baulig <martin@ximian.com>
17974 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
17975 the variable also exists in the current block (otherwise, we need
17976 to report a CS0103). Fixes #58670.
17978 2004-05-23 Martin Baulig <martin@ximian.com>
17980 * flowanalysis.cs (Reachability.Reachable): Compute this
17981 on-the-fly rather than storing it as a field.
17983 2004-05-23 Martin Baulig <martin@ximian.com>
17985 * flowanalysis.cs (Reachability.And): Manually compute the
17986 resulting `barrier' from the reachability.
17988 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17991 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
17992 instance of ObsoleteAttribute when symbol is obsolete.
17995 (IMethodData): Extended interface for ObsoleteAttribute support.
17997 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17999 * attribute.cs: Fix bug #55970
18001 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18005 (GetObsoleteAttribute): New method. Creates the instance of
18007 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18008 ObsoleteAttribute when member is obsolete.
18009 (AttributeTester.Report_ObsoleteMessage): Common method for
18010 Obsolete error/warning reporting.
18013 (TypeContainer.base_classs_type): New member for storing parent type.
18016 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18017 for this MemberCore.
18019 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18021 * attribute.cs, const.cs: Fix bug #58590
18023 2004-05-21 Martin Baulig <martin@ximian.com>
18025 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18026 out parameters if the end of the method is unreachable. Fixes
18029 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18031 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18032 Hari was right, why extra method.
18034 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18036 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18038 2004-05-20 Martin Baulig <martin@ximian.com>
18040 Merged this back from gmcs to keep the differences to a minumum.
18042 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18043 instead of a Declspace.
18044 (Attribute.ResolveType): Likewise.
18045 (Attributes.Search): Likewise.
18046 (Attributes.Contains): Likewise.
18047 (Attributes.GetClsCompliantAttribute): Likewise.
18049 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18051 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18054 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18056 Fix bug #58688 (MCS does not report error when the same attribute
18059 * attribute.cs (Attribute.Emit): Distinction between null and default.
18061 2004-05-19 Raja R Harinath <rharinath@novell.com>
18063 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18064 of a top-level attribute without an attribute target.
18065 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18067 (Attribute.Conditional_GetConditionName),
18068 (Attribute.Obsolete_GetObsoleteMessage): Update.
18069 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18070 part of ScanForIndexerName.
18071 (Attribute.CanIgnoreInvalidAttribute): New function.
18072 (Attribute.ScanForIndexerName): Move to ...
18073 (Attributes.ScanForIndexerName): ... here.
18074 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18075 (Attributes.Search): New internal variant that can choose not to
18076 complain if types aren't resolved. The original signature now
18078 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18079 complaints suppressed.
18080 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18081 only if it not useful.
18082 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18083 top-level for attributes that are shared between the assembly
18084 and a top-level class.
18085 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18086 * class.cs: Update to reflect changes.
18087 (DefineIndexers): Fuse loops.
18088 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18089 a couple more variants of attribute names.
18091 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18093 Fix bug #52585 (Implemented explicit attribute declaration)
18096 (Attributable.ValidAttributeTargets): New abstract method. It gets
18097 list of valid attribute targets for explicit target declaration.
18098 (Attribute.Target): It holds target itself.
18099 (AttributeSection): Removed.
18100 (Attribute.CheckTargets): New method. It checks whether attribute
18101 target is valid for the current element.
18104 (EventProperty): New class. For events that are declared like
18105 property (with add and remove accessors).
18106 (EventField): New class. For events that are declared like field.
18109 * cs-parser.jay: Implemented explicit attribute target declaration.
18111 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18112 Override ValidAttributeTargets.
18115 (ReturnParameter): Class for applying custom attributes on
18117 (ParameterAtribute): New class. Class for applying custom
18118 attributes on the parameter type.
18120 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18122 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18125 (Method): Allow UNSAFE here.
18127 * modifiers.cs: Support unsafe reporting.
18129 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18131 * decl.cs: Fix bug #58478.
18133 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18135 * statement.cs: When checking for unreachable code on an EmptyStatement,
18136 set the location. Fixes bug #58488.
18138 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18140 * driver.cs: Add -pkg handling.
18142 From Gonzalo: UseShelLExecute=false
18144 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18147 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18149 (Attribute.IsClsCompliaceRequired): Moved to base for better
18151 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18152 when attribute is AttributeUsageAttribute.
18153 (Attribute.GetValidTargets): Simplified.
18154 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18155 attribute for this type.
18156 (Attribute.ApplyAttributes): Method renamed to Emit and make
18158 (GlobalAttributeSection): New class for special handling of global
18159 attributes (assembly, module).
18160 (AttributeSection.Emit): New method.
18162 * class.cs: Implemented Attributable abstract methods.
18163 (MethodCore.LabelParameters): Moved to Parameter class.
18164 (Accessor): Is back simple class.
18165 (PropertyMethod): Implemented Attributable abstract class.
18166 (DelegateMethod): Implemented Attributable abstract class.
18167 (Event): New constructor for disctintion between normal Event
18168 and Event with accessors.
18170 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18172 * codegen.cs, const.cs, decl.cs, delegate.cs:
18173 (CommonAssemblyModulClass): Implemented Attributable abstract class
18176 * enum.cs: Implement IAttributeSupport interface.
18177 (EnumMember): New class for emum members. Implemented Attributable
18181 (ParameterBase): Is abstract.
18182 (ReturnParameter): New class for easier [return:] attribute handling.
18184 * typemanager.cs: Removed builder_to_attr.
18186 2004-05-11 Raja R Harinath <rharinath@novell.com>
18189 * attribute.cs (Attribute.GetPositionalValue): New function.
18190 * class.cs (TypeContainer.VerifyMembers): New function.
18191 (TypeContainer.Emit): Use it.
18192 (ClassOrStruct): New base class for Class and Struct.
18193 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18194 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18196 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18197 then each non-static field should have a FieldOffset attribute.
18198 Otherwise, none of the fields should have a FieldOffset attribute.
18199 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18200 and FieldOffset attributes.
18201 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18202 (TypeManager.field_offset_attribute_type): New core types.
18203 (TypeManager.InitCoreTypes): Initialize them.
18205 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18207 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18208 Return correct type.
18211 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18213 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18214 be implicitly converted to ulong.
18216 * expression.cs: The logic for allowing operator &, | and ^ worked
18217 was wrong, it worked before because we did not report an error in
18218 an else branch. Fixes 57895.
18220 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18221 allow volatile fields to be reference types.
18223 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18225 * driver.cs: Add support for /debug-
18227 2004-05-07 Raja R Harinath <rharinath@novell.com>
18229 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18230 Add a 'complain' parameter to silence errors.
18231 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18232 silently overlooked type-resolutions.
18233 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18234 to reflect changes.
18235 (Attributes.Search): New function.
18236 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18237 (Attributes.GetAttributeFullName): Remove hack.
18238 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18239 Update to reflect changes.
18240 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18241 Use Attributes.Search instead of nested loops.
18243 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18246 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18247 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18248 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18250 * report.cs: (Report.Warning): Renamed to Warning_T because of
18251 parameter collision.
18253 2004-05-05 Raja R Harinath <rharinath@novell.com>
18255 * expression.cs (MemberAccess.ResolveMemberAccess):
18256 Exit with non-zero status after Report.Error.
18257 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18259 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18261 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18263 * support.cs: Don't hang when the file is empty.
18265 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18267 * support.cs: In SeekableStreamReader, compute the preamble size of the
18268 underlying stream. Position changes should take into account that initial
18271 2004-05-03 Todd Berman <tberman@sevenl.net>
18273 * driver.cs: remove unused GetSysVersion function.
18275 2004-05-03 Todd Berman <tberman@sevenl.net>
18277 * driver.cs: Remove the hack from saturday, as well as the hack
18278 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18279 link_paths to get that bit proper.
18281 2004-05-01 Todd Berman <tberman@sevenl.net>
18283 * driver.cs: Try a LoadFrom before a Load, this checks the current
18284 path. This is currently a bug in mono that is be fixed, however, this
18285 provides a workaround for now. This will be removed when the bug
18288 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18290 * CryptoConvert.cs: Updated to latest version. Fix issue with
18291 incomplete key pairs (#57941).
18293 2004-05-01 Todd Berman <tberman@sevenl.net>
18295 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18298 2004-04-30 Jackson Harper <jackson@ximian.com>
18300 * codegen.cs: Open keys readonly.
18302 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18304 * typemanager.cs: don't report cyclic struct layout when a struct
18305 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18306 which has 2 Pango.Rectangle fields.
18308 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18310 * expression.cs: Handle IntPtr comparisons with IL code
18311 rather than a method call.
18313 2004-04-29 Martin Baulig <martin@ximian.com>
18315 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18316 the list of PropertyInfo's in class hierarchy and find the
18317 accessor. Fixes #56013.
18319 2004-04-29 Martin Baulig <martin@ximian.com>
18321 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18323 2004-04-29 Martin Baulig <martin@ximian.com>
18325 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18327 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18329 2004-04-29 Martin Baulig <martin@ximian.com>
18331 * class.cs (ConstructorInitializer.Resolve): Check whether the
18332 parent .ctor is accessible. Fixes #52146.
18334 2004-04-29 Martin Baulig <martin@ximian.com>
18336 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18338 * statement.cs (Using.EmitLocalVariableDecls): Use
18339 TypeManager.idisposable_type, not typeof (IDisposable).
18340 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18342 2004-04-29 Martin Baulig <martin@ximian.com>
18344 * class.cs (Event.Define): Don't emit the field and don't set
18345 RTSpecialName and SpecialName for events on interfaces. Fixes
18348 2004-04-29 Raja R Harinath <rharinath@novell.com>
18350 Refactor Attribute.ApplyAttributes.
18351 * attribute.cs (Attributable): New base class for objects that can
18352 have Attributes applied on them.
18353 (Attribute): Make AttributeUsage fields public.
18354 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18355 (Attribute.IsInternalCall): New property.
18356 (Attribute.UsageAttr): Convert to a public read-only property.
18357 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18358 (Attribute.ResolveType, Attribute.Resolve)
18359 (Attribute.ScanForIndexerName): Update to reflect changes.
18360 (Attribute.CheckAttributeTarget): Re-format.
18361 (Attribute.ApplyAttributes): Refactor, to various
18362 Attributable.ApplyAttributeBuilder methods.
18363 * decl.cs (MemberCore): Make Attributable.
18364 * class.cs (Accessor): Make Attributable.
18365 (MethodData.ApplyAttributes): Use proper attribute types, not
18367 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18368 (TypeContainer.ApplyAttributeBuilder)
18369 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18370 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18371 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18372 (Operator.ApplyAttributeBuilder): New factored-out methods.
18373 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18374 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18375 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18376 * parameter.cs (ParameterBase): New Attributable base class
18377 that can also represent Return types.
18378 (Parameter): Update to the changes.
18380 2004-04-29 Jackson Harper <jackson@ximian.com>
18382 * driver.cs: Prefer the corlib system version when looking for
18383 assemblies in the GAC. This is still a hack, but its a better hack
18386 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18388 * decl.cs, enum.cs: Improved error 3005 reporting.
18390 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18391 (related_symbols): New private member for list of symbols
18392 related to reported error/warning.
18394 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18396 2004-04-29 Martin Baulig <martin@ximian.com>
18398 * ecore.cs (Expression.Constantify): If we're an enum and
18399 TypeManager.TypeToCoreType() doesn't give us another type, use
18400 t.UnderlyingSystemType. Fixes #56178.
18402 2004-04-29 Martin Baulig <martin@ximian.com>
18404 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18405 interfaces and for each interface, only add members directly
18406 declared in that interface. Fixes #53255.
18408 2004-04-28 Martin Baulig <martin@ximian.com>
18410 * expression.cs (ConditionalLogicalOperator): Use a temporary
18411 variable for `left' to avoid that we evaluate it more than once;
18414 2004-04-28 Martin Baulig <martin@ximian.com>
18416 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18419 2004-04-28 Martin Baulig <martin@ximian.com>
18421 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18424 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18425 whether the type is not void (CS1547).
18427 2004-04-28 Martin Baulig <martin@ximian.com>
18429 * expression.cs (Unary.DoResolveLValue): Override this and report
18430 CS0131 for anything but Operator.Indirection.
18432 2004-04-28 Martin Baulig <martin@ximian.com>
18434 Committing a patch from Ben Maurer; see bug #50820.
18436 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18439 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18442 2004-04-28 Martin Baulig <martin@ximian.com>
18444 Committing a patch from Ben Maurer; see bug #50820.
18446 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18449 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18452 2004-04-28 Martin Baulig <martin@ximian.com>
18454 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18455 (Block.AddLabel): Call DoLookupLabel() to only search in the
18458 2004-04-28 Martin Baulig <martin@ximian.com>
18460 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18461 comparing StringConstants and NullLiterals in Equality and Inequality.
18463 2004-04-28 Jackson Harper <jackson@ximian.com>
18465 * driver.cs: Attempt to load referenced assemblies from the
18466 GAC. This is the quick and dirty version of this method that
18467 doesnt take into account versions and just takes the first
18468 canidate found. Will be good enough for now as we will not have more
18469 then one version installed into the GAC until I update this method.
18471 2004-04-28 Martin Baulig <martin@ximian.com>
18473 * typemanager.cs (TypeManager.CheckStructCycles): New public
18474 static method to check for cycles in the struct layout.
18476 * rootcontext.cs (RootContext.PopulateTypes): Call
18477 TypeManager.CheckStructCycles() for each TypeContainer.
18478 [Note: We only need to visit each type once.]
18480 2004-04-28 Martin Baulig <martin@ximian.com>
18482 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18484 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18485 success and added `out object value'. Use a `bool resolved' field
18486 to check whether we've already been called rather than
18487 `ConstantValue != null' since this breaks for NullLiterals.
18489 2004-04-28 Raja R Harinath <rharinath@novell.com>
18491 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18492 setting of this flag, since the 'set' method may be non-public.
18494 2004-04-28 Raja R Harinath <rharinath@novell.com>
18496 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18497 check on current_vector.Block.
18499 2004-04-27 Martin Baulig <martin@ximian.com>
18501 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18502 a field initializer. Fixes #56459.
18504 2004-04-27 Martin Baulig <martin@ximian.com>
18506 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18507 we're not attempting to use an indexer. Fixes #52154.
18509 2004-04-27 Martin Baulig <martin@ximian.com>
18511 * statement.cs (Return): Don't create a return label if we don't
18512 need it; reverts my change from January 20th. Thanks to Ben
18515 2004-04-27 Martin Baulig <martin@ximian.com>
18517 According to the spec, `goto' can only leave a nested scope, but
18520 * statement.cs (Block.LookupLabel): Only lookup in the current
18521 block, don't recurse into parent or child blocks.
18522 (Block.AddLabel): Check in parent and child blocks, report
18523 CS0140/CS0158 if we find a duplicate.
18524 (Block): Removed this indexer for label lookups.
18525 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18526 this already does the error reporting for us.
18529 (FlowBranching.UsageVector.Block): New public variable; may be null.
18530 (FlowBranching.CreateSibling): Added `Block' argument.
18531 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18532 label for the target of a `goto' and check whether we're not
18533 leaving a `finally'.
18535 2004-04-27 Martin Baulig <martin@ximian.com>
18537 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18538 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18541 2004-04-27 Martin Baulig <martin@ximian.com>
18543 * statement.cs (Block.AddLabel): Also check for implicit blocks
18544 and added a CS0158 check.
18546 2004-04-27 Martin Baulig <martin@ximian.com>
18548 * flowanalysis.cs (FlowBranchingLoop): New class.
18549 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18550 UsageVector's instead of an ArrayList.
18551 (FlowBranching.Label): Likewise.
18552 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18553 (FlowBranching.AddBreakVector): New method.
18555 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18557 * attribute.cs: Small regression fix: only convert the type if we
18558 the type is different, fixes System.Drawing build.
18560 2004-04-27 Martin Baulig <martin@ximian.com>
18562 * attribute.cs (Attribute.Resolve): If we have a constant value
18563 for a named field or property, implicity convert it to the correct
18566 2004-04-27 Raja R Harinath <rharinath@novell.com>
18568 * statement.cs (Block.Block): Implicit blocks share
18569 'child_variable_names' fields with parent blocks.
18570 (Block.AddChildVariableNames): Remove.
18571 (Block.AddVariable): Mark variable as "used by a child block" in
18572 every surrounding block.
18573 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18574 been used in a child block, complain about violation of "Invariant
18575 meaning in blocks" rule.
18576 * cs-parser.jay (declare_local_variables): Don't use
18577 AddChildVariableNames.
18578 (foreach_statement): Don't create an implicit block: 'foreach'
18579 introduces a scope.
18581 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18583 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18584 converting from 0L to ulong. Fixes 57522.
18586 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18588 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18589 derived class hides via 'new' keyword field from base class (test-242.cs).
18590 TODO: Handle this in the more general way.
18592 * class.cs (CheckBase): Ditto.
18594 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18596 * decl.cs (caching_flags): New member for storing cached values
18598 (MemberCore.Flags): New enum where bit flags for caching_flags
18600 (MemberCore.cls_compliance): Moved to caching_flags.
18601 (DeclSpace.Created): Moved to caching_flags.
18603 * class.cs: Use caching_flags instead of DeclSpace.Created
18605 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18607 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18608 if we are only a derived class, not a nested class.
18610 * typemanager.cs: Same as above, but do this at the MemberLookup
18611 level (used by field and methods, properties are handled in
18612 PropertyExpr). Allow for the qualified access if we are a nested
18615 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18617 * class.cs: Refactoring.
18618 (IMethodData): New inteface; Holds links to parent members
18619 to avoid member duplication (reduced memory allocation).
18620 (Method): Implemented IMethodData interface.
18621 (PropertyBase): New inner classes for get/set methods.
18622 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18623 (Event): New inner classes for add/remove methods.
18624 (Event.DelegateMethod): Implemented IMethodData interface.
18626 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18627 EmitContext (related to class.cs refactoring).
18629 2004-04-21 Raja R Harinath <rharinath@novell.com>
18631 * delegate.cs (Delegate.VerifyApplicability): If the number of
18632 arguments are the same as the number of parameters, first try to
18633 verify applicability ignoring any 'params' modifier on the last
18637 2004-04-16 Raja R Harinath <rharinath@novell.com>
18639 * class.cs (TypeContainer.AddIndexer): Use
18640 'ExplicitInterfaceName' to determine if interface name was
18641 explicitly specified. 'InterfaceType' is not initialized at this time.
18642 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18643 Indexers array is already in the required order. Initialize
18644 'IndexerName' only if there are normal indexers.
18645 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18646 (TypeContainer.Emit): Emit DefaultMember attribute only if
18647 IndexerName is initialized.
18650 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18652 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18655 2004-04-15 Raja R Harinath <rharinath@novell.com>
18657 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18661 * attribute.cs (Attribute.Resolve): Check for duplicate named
18665 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18667 * iterators.cs (MarkYield): track whether we are in an exception,
18668 and generate code accordingly. Use a temporary value to store the
18669 result for our state.
18671 I had ignored a bit the interaction of try/catch with iterators
18672 since their behavior was not entirely obvious, but now it is
18673 possible to verify that our behavior is the same as MS .NET 2.0
18677 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18679 * iterators.cs: Avoid creating temporaries if there is no work to
18682 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18683 Enumerations, use TypeManager.EnumToUnderlying and call
18686 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18689 (This.Emit): Use EmitContext.EmitThis to emit our
18692 (This.EmitAssign): Ditto.
18694 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18695 codepaths, we will move all the functionality into
18698 (FieldExpr.EmitAssign): Ditto.
18700 This fixes several hidden bugs that I uncovered while doing a code
18701 review of this today.
18703 * codegen.cs (EmitThis): reworked so the semantics are more clear
18704 and also support value types "this" instances.
18706 * iterators.cs: Changed so that for iterators in value types, we
18707 do not pass the value type as a parameter.
18709 Initialization of the enumerator helpers is now done in the caller
18710 instead of passing the parameters to the constructors and having
18711 the constructor set the fields.
18713 The fields have now `assembly' visibility instead of private.
18715 2004-04-11 Miguel de Icaza <miguel@ximian.com>
18717 * expression.cs (Argument.Resolve): Check if fields passed as ref
18718 or out are contained in a MarshalByRefObject.
18720 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
18721 another compiler type.
18723 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
18725 * class.cs (Indexer.Define): use the new name checking method.
18726 Also, return false on an error.
18727 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
18728 (is_identifier_[start/part]_character): make static.
18730 2004-04-10 Miguel de Icaza <miguel@ximian.com>
18732 * expression.cs (Binary.ResolveOperator): Do no append strings
18733 twice: since we can be invoked more than once (array evaluation)
18734 on the same concatenation, take care of this here. Based on a fix
18735 from Ben (bug #56454)
18737 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
18739 * codegen.cs: Fix another case where CS1548 must be reported (when
18740 delay-sign isn't specified and no private is available #56564). Fix
18741 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
18742 error when MCS is used on the MS runtime and we need to delay-sign
18743 (which seems unsupported by AssemblyBuilder - see #56621).
18745 2004-04-08 Marek Safar <marek.safar@seznam.cz>
18747 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
18748 (TypeManager.ComputeNamespaces): Faster implementation for
18751 * compiler.csproj: Updated AssemblyName to mcs.
18753 2004-04-07 Miguel de Icaza <miguel@ximian.com>
18755 * rootcontext.cs: Add new types to the boot resolution.
18757 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
18758 MulticastDelegate is not allowed.
18760 * typemanager.cs: Add new types to lookup: System.TypedReference
18763 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
18764 check for TypedReference or ArgIterator, they are not allowed.
18766 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
18767 makes us properly catch 1510 in some conditions (see bug 56016 for
18770 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
18772 * CryptoConvert.cs: update from corlib version
18775 2004-04-05 Miguel de Icaza <miguel@ximian.com>
18777 * class.cs (Indexer.Define): Check indexername declaration
18779 2004-04-05 Marek Safar <marek.safar@seznam.cz>
18781 * attribute.cs (IsClsCompliant): Fixed problem with handling
18782 all three states (compliant, not-compliant, undetected).
18784 2004-03-30 Marek Safar <marek.safar@seznam.cz>
18786 * attribute.cs (Attribute): Location is now public.
18787 (Resolve): Store resolved arguments (pos_values) in attribute class.
18788 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
18789 (GetClsCompliantAttributeValue): New method that gets
18790 CLSCompliantAttribute value.
18791 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
18792 if exists else null.
18793 (AttributeTester): New class for CLS-Compliant verification routines.
18795 * class.cs (Emit): Add CLS-Compliant verification.
18796 (Method.GetSignatureForError): Implemented.
18797 (Constructor.GetSignatureForError): Implemented
18798 (Constructor.HasCompliantArgs): Returns if constructor has
18799 CLS-Compliant arguments.
18800 (Constructor.Emit): Override.
18801 (Construcor.IsIdentifierClsCompliant): New method; For constructors
18802 is needed to test only parameters.
18803 (FieldBase.GetSignatureForError): Implemented.
18804 (TypeContainer): New member for storing base interfaces.
18805 (TypeContainer.FindMembers): Search in base interfaces too.
18807 * codegen.cs (GetClsComplianceAttribute): New method that gets
18808 assembly or module CLSCompliantAttribute value.
18809 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
18811 (ModuleClass.Emit): Add error 3012 test.
18813 * const.cs (Emit): Override and call base for CLS-Compliant tests.
18815 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
18816 state for all decl types.
18817 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
18818 if CLS-Compliant tests are required.
18819 (IsClsCompliaceRequired): New method. Analyze whether code
18820 must be CLS-Compliant.
18821 (IsExposedFromAssembly): New method. Returns true when MemberCore
18822 is exposed from assembly.
18823 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
18824 value or gets cached value.
18825 (HasClsCompliantAttribute): New method. Returns true if MemberCore
18826 is explicitly marked with CLSCompliantAttribute.
18827 (IsIdentifierClsCompliant): New abstract method. This method is
18828 used to testing error 3005.
18829 (IsIdentifierAndParamClsCompliant): New method. Common helper method
18830 for identifier and parameters CLS-Compliant testing.
18831 (VerifyClsCompliance): New method. The main virtual method for
18832 CLS-Compliant verifications.
18833 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
18834 null. I don't know why is null (too many public members !).
18835 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
18836 and get value of first CLSCompliantAttribute that found.
18838 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
18839 (VerifyClsCompliance): Override and add extra tests.
18841 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
18842 clscheck- disable CLS-Compliant verification event if assembly is has
18843 CLSCompliantAttribute(true).
18845 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
18846 ApllyAttribute is now called in emit section as in the other cases.
18847 Possible future Emit integration.
18848 (IsIdentifierClsCompliant): New override.
18849 (VerifyClsCompliance): New override.
18850 (GetEnumeratorName): Returns full enum name.
18852 * parameter.cs (GetSignatureForError): Implemented.
18854 * report.cs (WarningData): New struct for Warning message information.
18855 (LocationOfPreviousError): New method.
18856 (Warning): New method. Reports warning based on the warning table.
18857 (Error_T): New method. Reports error based on the error table.
18859 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
18860 verifications are done here.
18862 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
18864 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
18865 CLSCompliantAttribute.
18866 (all_imported_types): New member holds all imported types from other
18868 (LoadAllImportedTypes): New method fills static table with exported types
18869 from all referenced assemblies.
18870 (Modules): New property returns all assembly modules.
18872 2004-03-30 Miguel de Icaza <miguel@ximian.com>
18874 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
18875 throwing a parser error.
18877 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
18878 which removes the hardcoded get_/set_ prefixes for properties, as
18879 IL allows for the properties to be named something else.
18883 * expression.cs: Do not override operand before we know if it is
18884 non-null. Fix 56207
18886 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18888 * typemanager.cs: support for pinned variables.
18890 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18892 * decl.cs, typemanager.cs: Avoid using an arraylist
18893 as a buffer if there is only one result set.
18895 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18897 * expression.cs: Make sure you cant call a static method
18898 with an instance expression, bug #56174.
18900 2004-03-29 Miguel de Icaza <miguel@ximian.com>
18902 * class.cs (IsDuplicateImplementation): Improve error reporting to
18903 flag 663 (method only differs in parameter modifier).
18905 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
18906 in preprocessor directives.
18908 * location.cs (LookupFile): Allow for the empty path.
18910 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
18911 better approach for some of that patch, but its failing with the
18912 CharSet enumeration. For now try/catch will do.
18914 * typemanager.cs: Do not crash if a struct does not have fields.
18917 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18919 * expression.cs: cs0213, cant fix a fixed expression.
18922 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18924 * cs-parser.jay: detect invalid embeded statements gracefully.
18927 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18929 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
18932 the invocation type may not be a subclass of the tye of the item/
18933 The type of the item must be a subclass of the invocation item.
18938 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
18940 * attribute.cs: Added methods to get a string and a bool from an
18941 attribute. Required to information from AssemblyKeyFileAttribute,
18942 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
18943 * codegen.cs: Modified AssemblyName creation to include support for
18944 strongnames. Catch additional exceptions to report them as CS1548.
18945 * compiler.csproj: Updated include CryptoConvert.cs.
18946 * compiler.csproj.user: Removed file - user specific configuration.
18947 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
18948 Mono.Security assembly. The original class is maintained and tested in
18949 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
18950 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
18951 like CSC 8.0 (C# v2) supports.
18952 * Makefile: Added CryptoConvert.cs to mcs sources.
18953 * rootcontext.cs: Added new options for strongnames.
18955 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
18957 * driver.cs: For --expect-error, report error code `2'
18958 if the program compiled with no errors, error code `1' if
18959 it compiled with an error other than the one expected.
18961 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
18963 * compiler.csproj: Updated for Visual Studio .NET 2003.
18964 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
18965 * compiler.sln: Updated for Visual Studio .NET 2003.
18967 2004-03-24 Ravi Pratap M <ravi@ximian.com>
18969 * expression.cs: Fix bug #47234. We basically need to apply the
18970 rule that we prefer the conversion of null to a reference type
18971 when faced with a conversion to 'object' (csc behaviour).
18973 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18975 * statement.cs: Shorter form for foreach, eliminates
18976 a local variable. r=Martin.
18978 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18980 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
18981 checks if we can use brtrue/brfalse to test for 0.
18982 * expression.cs: use the above in the test for using brtrue/brfalse.
18983 cleanup code a bit.
18985 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18987 * expression.cs: Rewrite string concat stuff. Benefits:
18989 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
18990 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
18991 rather than a concat chain.
18993 * typemanager.cs: Add lookups for more concat overloads.
18995 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18997 * expression.cs: Emit shorter il code for array init.
19014 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19016 * statement.cs: Before, two switch blocks would be merged if the
19017 total size of the blocks (end_item - begin_item + 1) was less than
19018 two times the combined sizes of the blocks.
19020 Now, it will only merge if after the merge at least half of the
19025 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19027 * class.cs : csc build fix for GetMethods(). See bug #52503.
19029 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19031 * expression.cs: Make sure fp comparisons work with NaN.
19032 This fixes bug #54303. Mig approved this patch a long
19033 time ago, but we were not able to test b/c the runtime
19036 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19038 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19040 2004-03-19 Martin Baulig <martin@ximian.com>
19042 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19043 error here and not in our caller.
19045 2004-03-19 Martin Baulig <martin@ximian.com>
19047 * interface.cs: Completely killed this file.
19048 (Interface): We're now a TypeContainer and live in class.cs.
19050 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19051 argument; we're now also called for interfaces.
19052 (TypeContainer.DefineMembers): Allow this method being called
19054 (TypeContainer.GetMethods): New public method; formerly known as
19055 Interface.GetMethod(). This is used by PendingImplementation.
19056 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19057 it's now private and non-static.
19058 (Interface): Moved this here; it's now implemented similar to
19060 (Method, Property, Event, Indexer): Added `bool is_interface'
19061 argument to their .ctor's.
19062 (MemberBase.IsInterface): New public field.
19064 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19065 instances instead of InterfaceMethod, InterfaceProperty, etc.
19066 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19067 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19069 2004-03-19 Martin Baulig <martin@ximian.com>
19071 * class.cs (MethodCore.IsDuplicateImplementation): New private
19072 method which does the CS0111 checking.
19073 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19074 Use IsDuplicateImplementation().
19076 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19078 * decl.cs (FindMemberToOverride): New method to find the correct
19079 method or property to override in the base class.
19081 - Make Method/Property use the above method to find the
19082 version in the base class.
19083 - Remove the InheritableMemberSignatureCompare as it is now
19086 This patch makes large code bases much faster to compile, as it is
19087 O(n) rather than O(n^2) to do this validation.
19089 Also, it fixes bug 52458 which is that nested classes are not
19090 taken into account when finding the base class member.
19092 Reviewed/Approved by Martin.
19094 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19096 * interface.cs: In all interface classes removed redundant
19097 member initialization.
19099 2004-03-16 Martin Baulig <martin@ximian.com>
19101 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19103 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19105 * decl.cs (DefineTypeAndParents): New helper method to define a
19106 type's containers before the type itself is defined; This is a
19107 bug exposed by the recent changes to Windows.Forms when an
19108 implemented interface was defined inside a class that had not been
19111 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19113 (Check): Loop correctly to report errors modifiers
19114 (UNSAFE was not in the loop, since it was the same as TOP).
19116 * interface.cs: Every interface member now takes a ModFlags,
19117 instead of a "is_new" bool, which we set on the base MemberCore.
19119 Every place where we called "UnsafeOk" in the interface, now we
19120 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19121 the unsafe settings from the member declaration instead of the
19122 container interface.
19124 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19126 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19127 `set_indexer_name' to the pending bits (one per type).
19129 We fixed a bug today that was picking the wrong method to
19130 override, since for properties the existing InterfaceMethod code
19131 basically ignored the method name. Now we make sure that the
19132 method name is one of the valid indexer names.
19134 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19136 * support.cs (SeekableStreamReader): Keep track of stream byte
19137 positions and don't mix them with character offsets to the buffer.
19139 Patch from Gustavo Giráldez
19141 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19143 * interface.cs (InterfaceSetGetBase): Removed double member
19144 initialization, base class does it as well.
19146 2004-03-13 Martin Baulig <martin@ximian.com>
19148 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19149 when compiling corlib.
19151 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19153 * convert.cs (ExplicitConversion): We were reporting an error on
19154 certain conversions (object_type source to a value type, when the
19155 expression was `null') before we had a chance to pass it through
19156 the user defined conversions.
19158 * driver.cs: Replace / and \ in resource specifications to dots.
19161 * class.cs: Add check for duplicate operators. Fixes 52477
19163 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19165 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19166 that are in the middle of the statements, not only at the end.
19169 * class.cs (TypeContainer.AddField): No longer set the
19170 `HaveStaticConstructor' flag, now we call it
19171 `UserDefineStaticConstructor' to diferentiate the slightly
19172 semantic difference.
19174 The situation is that we were not adding BeforeFieldInit (from
19175 Modifiers.TypeAttr) to classes that could have it.
19176 BeforeFieldInit should be set to classes that have no static
19181 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19183 And most importantly Zoltan's comment:
19185 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19187 "I think beforefieldinit means 'it's ok to initialize the type sometime
19188 before its static fields are used', i.e. initialization does not need
19189 to be triggered by the first access to the type. Setting this flag
19190 helps the JIT to compile better code, since it can run the static
19191 constructor at JIT time, and does not need to generate code to call it
19192 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19193 this flag for lots of classes like String.
19195 csc sets this flag if the type does not have an explicit static
19196 constructor. The reasoning seems to be that if there are only static
19197 initalizers for a type, and no static constructor, then the programmer
19198 does not care when this initialization happens, so beforefieldinit
19201 This bug prevents the AOT compiler from being usable, since it
19202 generates so many calls to mono_runtime_class_init that the AOT code
19203 is much slower than the JITted code. The JITted code is faster,
19204 because it does not generate these calls if the vtable is type is
19205 already initialized, which is true in the majority of cases. But the
19206 AOT compiler can't do this."
19208 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19210 * class.cs (MethodData.Emit): Refactor the code so symbolic
19211 information is generated for destructors; For some reasons we
19212 were taking a code path that did not generate symbolic information
19215 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19217 * class.cs: Create a Constructor.CheckBase method that
19218 takes care of all validation type code. The method
19219 contains some code that was moved from Define.
19221 It also includes new code that checks for duplicate ctors.
19222 This fixes bug #55148.
19224 2004-03-09 Joshua Tauberer <tauberer@for.net>
19226 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19227 a { ... }-style array creation invokes EmitStaticInitializers
19228 which is not good for reference-type arrays. String, decimal
19229 and now null constants (NullCast) are not counted toward
19230 static initializers.
19232 2004-03-05 Martin Baulig <martin@ximian.com>
19234 * location.cs (SourceFile.HasLineDirective): New public field;
19235 specifies whether the file contains or is referenced by a "#line"
19237 (Location.DefineSymbolDocuments): Ignore source files which
19238 either contain or are referenced by a "#line" directive.
19240 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19242 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19243 direct access to our parent, so check the method inline there.
19245 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19247 * expression.cs (Invocation.EmitCall): Miguel's last commit
19248 caused a regression. If you had:
19253 In Foo the implict this would be null.
19255 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19257 * expression.cs (Invocation.EmitCall): If the method is not
19258 virtual, do not emit a CallVirt to it, use Call.
19260 * typemanager.cs (GetFullNameSignature): Improve the method to
19261 cope with ".ctor" and replace it with the type name.
19263 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19264 as an argument the ConstructorBuilder where it is being defined,
19265 to catch the recursive constructor invocations.
19267 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19269 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19270 routines to check if a type is an enumerable/enumerator allow
19271 classes that implement the IEnumerable or IEnumerator interfaces.
19273 * class.cs (Property, Operator): Implement IIteratorContainer, and
19274 implement SetYields.
19276 (Property.Define): Do the block swapping for get_methods in the
19277 context of iterators. We need to check if Properties also
19278 include indexers or not.
19280 (Operator): Assign the Block before invoking the
19281 OperatorMethod.Define, so we can trigger the Iterator code
19284 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19285 Property and Operator classes are not created when we parse the
19286 declarator but until we have the block completed, so we use a
19287 singleton SimpleIteratorContainer.Simple to flag whether the
19288 SetYields has been invoked.
19290 We propagate this setting then to the Property or the Operator to
19291 allow the `yield' to function.
19293 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19295 * codegen.cs: Implemented attribute support for modules.
19296 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19297 Assembly/Module functionality.
19299 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19300 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19301 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19303 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19305 * interface.cs (FindMembers): The operation is performed on all base
19306 interfaces and not only on the first. It is required for future CLS Compliance patch.
19308 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19310 * statement.cs, codegen.cs:
19311 This patch deals with patterns such as:
19313 public class List : IEnumerable {
19315 public MyEnumerator GetEnumerator () {
19316 return new MyEnumerator(this);
19319 IEnumerator IEnumerable.GetEnumerator () {
19323 public struct MyEnumerator : IEnumerator {
19328 Before, there were a few things we did wrong:
19329 1) we would emit callvirt on a struct, which is illegal
19330 2) we emited ldarg when we needed to emit ldarga
19331 3) we would mistakenly call the interface methods on an enumerator
19332 type that derived from IEnumerator and was in another assembly. For example:
19334 public class MyEnumerator : IEnumerator
19336 Would have the interface methods called, even if there were public impls of the
19337 method. In a struct, this lead to invalid IL code.
19339 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19341 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19344 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19346 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19348 * cs-parser.jay: Fix small regression: we were not testing V2
19349 compiler features correctly.
19351 * interface.cs: If the emit context is null, then create one
19353 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19355 * decl.cs (GetSignatureForError): New virtual method to get full name
19356 for error messages.
19358 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19359 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19361 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19362 Duplicated members and code in these classes has been removed.
19363 Better encapsulation in these classes.
19365 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19367 * assign.cs (Assign.DoResolve): When dealing with compound
19368 assignments, there is a new rule in ECMA C# 2.4 (might have been
19369 there before, but it is documented here) that states that in:
19373 If b is of type int, and the `op' is a shift-operator, then the
19374 above is evaluated as:
19378 * expression.cs (Binary.ResolveOperator): Instead of testing for
19379 int/uint/long/ulong, try to implicitly convert to any of those
19380 types and use that in pointer arithmetic.
19382 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19383 method to print information for from the type, not from the
19384 null-method we were given.
19386 2004-02-01 Duncan Mak <duncan@ximian.com>
19388 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19389 parsing for cmd, fixes bug #53694.
19391 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19393 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19394 in the member name duplication tests. Property and operator name duplication
19395 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19397 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19399 * interface.cs (PopulateMethod): Fixed crash when interface method
19400 returns not existing type (error test cs0246-3.cs).
19402 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19404 * cs-parser.jay (interface_accessors): Re-write actions to also
19405 store attributes attached to get and set methods. Fix spelling
19408 (inteface_property_declaration): Modify accordingly.
19410 (InterfaceAccessorInfo): New helper class to store information to pass
19411 around between rules that use interface_accessors.
19413 * interface.cs (Emit): Apply attributes on the get and set
19414 accessors of properties and indexers too.
19416 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19417 right MethodBuilder when applying attributes to the get and set accessors.
19419 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19421 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19423 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19425 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19427 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19429 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19430 changes that treat `yield' specially when present before `break'
19431 or `return' tokens.
19433 * cs-tokenizer.cs: yield is no longer a keyword.
19435 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19437 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19438 setting for default constructors.
19439 For default constructors are almost every time set wrong Modifier. The
19440 generated IL code has been alright. But inside mcs this values was
19441 wrong and this was reason why several of my CLS Compliance tests
19444 2004-01-22 Martin Baulig <martin@ximian.com>
19446 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19447 not a QualifiedIdentifier. This is what `type_name_expression'
19448 was previously doing.
19449 (type_name_expression): Removed; the code is now in
19450 `namespace_or_type_name'.
19451 (qualified_identifier): Removed, use `namespace_or_type_name'
19453 (QualifiedIdentifier): Removed this class.
19455 2004-01-22 Martin Baulig <martin@ximian.com>
19457 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19458 not a string as alias name.
19460 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19462 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19463 #52730 bug, and instead compute correctly the need to use a
19464 temporary variable when requesting an address based on the
19465 static/instace modified of the field and the constructor.
19467 2004-01-21 Martin Baulig <martin@ximian.com>
19469 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19470 class and namespace before looking up aliases. Fixes #52517.
19472 2004-01-21 Martin Baulig <martin@ximian.com>
19474 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19475 assinged in a 'try'; fixes exception4.cs.
19477 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19478 * class.cs : Implemented parameter-less constructor for TypeContainer
19480 * decl.cs: Attributes are now stored here. New property OptAttributes
19482 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19484 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19486 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19488 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19489 (CSharpSignature): New method for indexer and property signature.
19491 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19493 * pending.cs (IsVirtualFilter): Faster implementation.
19495 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19497 * typemanager.cs: Avoid inclusion of same assembly more than once.
19499 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19501 * cs-parser.jay: Fixed problem where the last assembly attribute
19502 has been applied also to following declaration (class, struct, etc.)
19504 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19506 * class.cs: Added error CS0538, CS0539 reporting.
19507 Fixed crash on Microsoft runtime when field type is void.
19509 * cs-parser.jay: Added error CS0537 reporting.
19511 * pending.cs: Added error CS0535 reporting.
19512 Improved error report for errors CS0536, CS0534.
19514 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19516 Merge a few bits from the Anonymous Method MCS tree.
19518 * statement.cs (ToplevelBlock): New class for toplevel methods,
19519 will hold anonymous methods, lifted variables.
19521 * cs-parser.jay: Create toplevel blocks for delegates and for
19522 regular blocks of code.
19524 2004-01-20 Martin Baulig <martin@ximian.com>
19526 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19527 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19528 and `NeedExplicitReturn'; added `IsLastStatement'.
19529 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19530 have a `ReturnLabel' or we're not unreachable.
19532 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19533 child's reachability; don't just override ours with it. Fixes
19534 #58058 (lluis's example).
19535 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19536 InFinally(), InLoop(), InSwitch() and
19537 BreakCrossesTryCatchBoundary() methods.
19539 * statement.cs (Return): Do all error checking in Resolve().
19540 Unless we are the last statement in a top-level block, always
19541 create a return label and jump to it.
19542 (Break, Continue): Do all error checking in Resolve(); also make
19543 sure we aren't leaving a `finally'.
19544 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19545 statement in a top-level block.
19546 (Block.Flags): Added `IsDestructor'.
19547 (Block.IsDestructor): New public property.
19549 2004-01-20 Martin Baulig <martin@ximian.com>
19551 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19553 2004-01-20 Martin Baulig <martin@ximian.com>
19555 * statement.cs (Statement.ResolveUnreachable): New public method.
19556 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19557 (Block.Resolve): Resolve unreachable statements.
19559 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19561 * expression.cs: We need to fix the case where we do
19562 not have a temp variable here.
19564 * assign.cs: Only expression compound assignments need
19565 temporary variables.
19567 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19569 * flowanalysis.cs: Reduce memory allocation in a few ways:
19570 - A block with no variables should not allocate a bit
19572 - A method with no out parameters does not need any tracking
19573 for assignment of the parameters, so we need not allocate
19576 public readonly Type[] VariableTypes;
19577 public readonly string[] VariableNames;
19578 Are redundant. The data is already stored in the variable
19579 map, so we need not allocate another array for it.
19580 - We need to add alot of checks for if (params | locals) == null
19581 due to the first two changes.
19583 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19585 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19586 implement IMemoryLocation, we store a copy on a local variable and
19587 take the address of it. Patch from Benjamin Jemlich
19589 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19590 to use a special "type_name_expression" rule which reduces the
19591 number of "QualifiedIdentifier" classes created, and instead
19592 directly creates MemberAccess expressions.
19594 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19596 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19597 that fixes #52853. Null literal assignment to ValueType
19599 * class.cs (MethodData.Emit): Instead of checking the name of the
19600 method to determine if its a destructor, create a new derived
19601 class from Method called Destructor, and test for that.
19603 * cs-parser.jay: Create a Destructor object instead of a Method.
19605 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19609 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19611 * expression.cs (Binary.ResolveOperator): Perform an implicit
19612 conversion from MethodGroups to their delegate types on the
19613 Addition operation.
19615 * delegate.cs: Introduce a new class DelegateCreation that is the
19616 base class for `NewDelegate' and `ImplicitDelegateCreation',
19617 factor some code in here.
19619 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19620 conversion from MethodGroups to compatible delegate types.
19622 * ecore.cs (Expression.Resolve): Do not flag error 654
19623 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19624 we allow conversions from MethodGroups to delegate types now.
19626 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19627 assignments in v2 either.
19629 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19631 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19632 static read-only fields in ctors.
19634 Applied patch from Benjamin Jemlich
19636 * expression.cs (UnaryMutator): Avoid leaking local variables.
19638 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19640 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19641 here to return true, as they can be used like this:
19643 (XXX) int.MEMBER ()
19645 Fixed 49836 and all the other dups
19647 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19649 * driver.cs: Implement /win32res and /win32icon.
19651 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19653 * cs-parser.jay: Add a rule to improve error handling for the
19654 common mistake of placing modifiers after the type.
19656 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19658 * cs-parser.jay (interface_event_declaration): Catch
19659 initialization of events on interfaces, and report cs0068
19661 * cs-parser.jay (interface_event_declaration): Catch
19662 initialization of events.
19664 * ecore.cs: Better report missing constructors.
19666 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19667 the error reporting done in the wrong place. Fix.
19669 * expression.cs (Binary.ResolveOperator): Catch the
19670 operator + (E x, E y) error earlier, and later allow for implicit
19671 conversions in operator +/- (E e, U x) from U to the underlying
19674 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19675 52596, if the container class is abstract, the default constructor
19676 is protected otherwise its public (before, we were always public).
19678 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19681 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19682 Jemlich that fixes bug #52597, MCS was generating invalid code for
19683 idisposable structs. Thanks to Ben for following up with this
19686 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19688 * driver.cs: Allow assemblies without code to be generated, fixes
19691 2004-01-07 Nick Drochak <ndrochak@gol.com>
19693 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19695 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19697 * cs-parser.jay: Add rules to improve error reporting if fields or
19698 methods are declared at the namespace level (error 116)
19700 * Add rules to catch event add/remove
19702 2004-01-04 David Sheldon <dave-mono@earth.li>
19704 * expression.cs: Added matching ")" to error message for
19707 2004-01-03 Todd Berman <tberman@gentoo.org>
19709 * ecore.cs, attribute.cs:
19710 Applying fix from #52429.
19712 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19714 * ecore.cs, expression.cs, statement.cs:
19715 Total rewrite of how we handle branching. We
19716 now handle complex boolean expressions with fewer
19717 jumps. As well if (x == 0) no longer emits a ceq.
19719 if (x is Foo) is much faster now, because we generate
19722 Overall, we get a pretty big improvement on our benchmark
19723 tests. The code we generate is smaller and more readable.
19725 I did a full two-stage bootstrap. The patch was reviewed
19726 by Martin and Miguel.
19728 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19730 * cs-parser.jay: Make primary_expression not take a QI.
19731 we dont need this because the member_access rule covers
19732 us here. So we replace the rule with just IDENTIFIER.
19734 This has two good effects. First, we remove a s/r conflict.
19735 Second, we allocate many fewer QualifiedIdentifier objects.
19737 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19739 * attribute.cs: Handle MarshalAs attributes as pseudo, and
19740 set the correct information via SRE. This prevents
19741 hanging on the MS runtime. Fixes #29374.
19743 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19745 * convert.cs: correctly handle conversions to value types
19746 from Enum and ValueType as unboxing conversions.
19748 Fixes bug #52569. Patch by Benjamin Jemlich.
19750 2004-01-02 Ravi Pratap <ravi@ximian.com>
19752 * expression.cs (BetterConversion): Prefer int -> uint
19753 over int -> ulong (csc's behaviour). This fixed bug #52046.
19755 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
19757 * decl.cs (MemberCache.FindMembers): now returns a
19760 * typemanager.cs: In general, go with with ^^.
19761 (CopyNewMethods): take an IList.
19762 (RealMemberLookup): Only allocate an arraylist
19763 if we copy from two sets of methods.
19765 This change basically does two things:
19766 1) Fewer array lists allocated due to CopyNewMethods.
19767 2) the explicit cast in MemberList costed ALOT.
19769 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
19771 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
19772 a hashtable to avoid needless string allocations when an identifier is
19773 used more than once (the common case).
19775 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19777 * pending.cs: MS's TypeBuilder.GetInterfaces ()
19778 is broken, it will not return anything. So, we
19779 have to use the information we have in mcs to
19782 * typemanager.cs: Add a cache for GetInterfaces,
19783 since this will now be used more often (due to ^^)
19785 (GetExplicitInterfaces) New method that gets the
19786 declared, not effective, interfaces on a type
19787 builder (eg, if you have interface IFoo, interface
19788 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
19791 This patch makes MCS able to bootstrap itself on
19794 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19796 * expression.cs: Remove the Nop's that Miguel put
19799 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19801 * report.cs, codegen.cs: Give the real stack trace to
19802 the error when an exception is thrown.
19804 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19806 * decl.cs: only allocate hashtables for ifaces if
19809 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19811 * expression.cs: fix the error from cs0121-2.cs
19812 (a parent interface has two child interfaces that
19813 have a function with the same name and 0 params
19814 and the function is called through the parent).
19816 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
19818 * class.cs, rootcontext.cs, typmanager.cs: do not
19821 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
19823 * codegen.cs: remove stack for the ec flow branching.
19824 It is already a linked list, so no need.
19826 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
19828 * Makefile: Allow custom profiler here.
19830 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19832 * typemanager.cs (LookupType):
19833 - Use a static char [], because split takes
19834 a param array for args, so it was allocating
19836 - Do not store true in a hashtable, it boxes.
19838 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19840 * flowanalysis.cs: bytify common enums.
19842 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19844 * modifiers.cs: Add a new set of flags for the
19845 flags allowed on explicit interface impls.
19846 * cs-parser.jay: catch the use of modifiers in
19847 interfaces correctly.
19848 * class.cs: catch private void IFoo.Blah ().
19850 All related to bug #50572.
19852 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19854 * decl.cs: Rewrite the consistant accessability checking.
19855 Accessability is not linear, it must be implemented in
19856 a tableish way. Fixes #49704.
19858 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19860 * expression.cs: Handle negation in a checked context.
19861 We must use subtraction from zero. Fixes #38674.
19863 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19865 * class.cs: Ignore static void main in DLLs.
19866 * rootcontext.cs: Handle the target type here,
19867 since we are have to access it from class.cs
19868 * driver.cs: account for the above.
19870 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19872 * report.cs: Give line numbers and files if available.
19874 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
19876 * driver.cs: Implement /addmodule.
19878 * typemanager.cs: Change 'modules' field so it now contains Modules not
19881 2003-12-20 Martin Baulig <martin@ximian.com>
19883 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
19884 (FieldBase.IsAssigned): Removed this field.
19885 (FieldBase.SetAssigned): New public method.
19886 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
19888 2003-12-20 Martin Baulig <martin@ximian.com>
19890 * expression.cs (LocalVariableReference.DoResolve): Don't set
19891 `vi.Used' if we're called from DoResolveLValue().
19893 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
19894 returns the usage vector it just merged into the current one -
19895 pass this one to UsageWarning().
19896 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
19897 of the `EmitContext', don't call this recursively on our children.
19899 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
19901 * driver.cs: Implement /target:module.
19903 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
19905 * support.cs (CharArrayHashtable): New helper class.
19907 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
19908 char arrays, not strings, so we can avoid creating a string in
19909 consume_identifier if the identifier is a keyword.
19911 2003-12-16 Martin Baulig <martin@ximian.com>
19913 * statement.cs (LocalInfo.Assigned): Removed this property.
19914 (LocalInfo.Flags): Removed `Assigned'.
19915 (LocalInfo.IsAssigned): New public method; takes the EmitContext
19916 and uses flow analysis.
19917 (Block.UsageWarning): Made this method private.
19918 (Block.Resolve): Call UsageWarning() if appropriate.
19920 * expression.cs (LocalVariableReference.DoResolve): Always set
19921 LocalInfo.Used here.
19923 2003-12-13 Martin Baulig <martin@ximian.com>
19925 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
19926 any value here; we're now using flow analysis to figure out
19927 whether a statement/block returns a value.
19929 2003-12-13 Martin Baulig <martin@ximian.com>
19931 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
19933 (FlowBranching.MergeFinally): Don't call
19934 `branching.CheckOutParameters()' here, this is called in
19936 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
19937 when adding the `finally' vector.
19939 2003-12-13 Martin Baulig <martin@ximian.com>
19942 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
19943 actually work and also fix #48962.
19945 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
19947 * decl.cs: Do not check System.Object for nested types,
19948 since we know it does not have any. Big bang for buck:
19951 Run 1: 8.35 seconds
19952 Run 2: 8.32 seconds
19953 corlib: 17.99 seconds
19955 Run 1: 8.17 seconds
19956 Run 2: 8.17 seconds
19957 corlib: 17.39 seconds
19959 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
19961 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
19962 time we are returning 0 members, so we save alot here.
19964 2003-12-11 Martin Baulig <martin@ximian.com>
19966 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
19967 `MergeChild()', also just take the `FlowBranching' as argument;
19968 call Merge() on it and return the result.
19969 (FlowBranching.Merge): We don't need to do anything if we just
19972 2003-12-11 Martin Baulig <martin@ximian.com>
19974 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
19975 them in an `ArrayList' to reduce memory usage. Thanks to Ben
19976 Maurer for this idea.
19978 2003-12-11 Martin Baulig <martin@ximian.com>
19980 * flowanalysis.cs (MergeResult): This class is now gone; we now
19981 use the `UsageVector' for this. The reason for this is that if a
19982 branching just has one sibling, we don't need to "merge" them at
19983 all - that's the next step to do.
19984 (FlowBranching.Merge): We now return a `UsageVector' instead of a
19987 2003-12-11 Martin Baulig <martin@ximian.com>
19989 Reworked flow analyis and made it more precise and bug-free. The
19990 most important change is that we're now using a special `Reachability'
19991 class instead of having "magic" meanings of `FlowReturns'. I'll
19992 do some more cleanups and optimizations and also add some more
19993 documentation this week.
19995 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
19996 largely reworked this class.
19997 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
19998 the new `Reachability' class instead of having "magic" values here.
19999 (FlowBranching): We're now using an instance of `Reachability'
20000 instead of having separate `Returns', `Breaks' etc. fields.
20002 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20003 based on flow analysis; ignore the return value of block.Emit ().
20005 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20007 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20008 if they are private.
20010 2003-12-09 Martin Baulig <martin@ximian.com>
20012 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20013 call them directly on the UsageVector.
20015 2003-12-09 Martin Baulig <martin@ximian.com>
20017 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20018 Changed return type from `FlowReturns' to `Reachability'.
20020 2003-12-09 Martin Baulig <martin@ximian.com>
20022 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20023 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20024 `Reachable' fields with a single `Reachability' one.
20026 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20028 * class.cs (FindMembers): Remove foreach's.
20033 Run 1: 8.74 seconds
20034 Run 2: 8.71 seconds
20037 Run 1: 8.64 seconds
20038 Run 2: 8.58 seconds
20041 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20046 This patch does a few things:
20047 1. EmptyStatement is now a singleton, so it is never reallocated.
20048 2. All blah is EmptyStatement constructs have been changed to
20049 blah == EmptyStatement.Value, which is much faster and valid
20050 now that EmptyStatement is a singleton.
20051 3. When resolving a block, rather than allocating a new array for
20052 the non-empty statements, empty statements are replaced with
20053 EmptyStatement.Value
20054 4. Some recursive functions have been made non-recursive.
20055 Mainly the performance impact is from (3), however (1) and (2) are needed for
20056 this to work. (4) does not make a big difference in normal situations, however
20057 it makes the profile look saner.
20062 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20063 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20064 Total memory allocated: 56397 KB
20067 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20068 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20069 Total memory allocated: 55666 KB
20071 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20073 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20074 than the hashtable in a hashtable version
20076 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20077 we always end up concating a string. This results in a huge perf
20078 loss, because many strings have to be tracked by the GC. In this
20079 patch, we first use a hashtable that works with two keys, so that
20080 the strings do not need to be concat'ed.
20084 Run 1: 8.74 seconds
20085 Run 2: 8.71 seconds
20088 Run 1: 8.65 seconds
20089 Run 2: 8.56 seconds
20091 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20093 * Makefile: Add a new target `do-time' that does a quick and simple
20094 profile, leaving easy to parse output.
20096 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20098 * codegen.cs (Init): Create the dynamic assembly with
20099 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20101 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20103 * support.cs: Make the PtrHashtable use only one
20104 instance of its comparer.
20106 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20108 * typemanager.cs: Fix lookup of GetNamespaces.
20110 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20112 * expression.cs: Removed redundant line.
20114 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20115 ArrayLists, use for loops with bounds.
20117 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20120 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20121 arraylists, use for loop with bounds.
20123 The above three changes give us a 0.071 second performance
20124 improvement out of 3.294 seconds down to 3.223. On my machine
20125 the above changes reduced the memory usage by 1,387 KB during
20126 compiler bootstrap.
20128 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20129 QualifiedIdentifiers. Before we created a new string through
20130 concatenation, and mostly later on, the result would be
20131 manipulated by DecomposeQI through string manipulation.
20133 This reduced the compiler memory usage for bootstrapping from
20134 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20135 compile times in 0.05 seconds.
20137 2003-11-28 Dick Porter <dick@ximian.com>
20139 * support.cs: Do string compares with the Invariant culture.
20147 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20148 the comparison is done with the Invariant culture.
20150 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20152 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20153 GetEnumerator method.
20155 (ProbeCollectionType): Iterate starting at the most specific type
20156 upwards looking for a GetEnumerator
20158 * expression.cs: Shift count can be up to 31 for int/uint and 63
20161 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20163 * statement.cs (Block.LookupLabel): Also look for the label on the
20164 children blocks. Use a hash table to keep track of visited
20167 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20168 we actually did transform the other operand, otherwise fall back
20169 to the common codepath that casts to long.
20171 * cs-tokenizer.cs: Use the same code pattern as the int case.
20172 Maybe I should do the parsing myself, and avoid depending on the
20173 Parse routines to get this done.
20175 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20177 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20178 which fixes bug 51347. This time test it.
20180 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20181 attributes for example can not tell the difference between these.
20182 The difference was only a syntax feature of the language.
20184 * attribute.cs: Apply attributes to delegates.
20186 * delegate.cs: Call the apply attributes method.
20188 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20190 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20191 comparing 0 vs Byte.MinValue, not the value
20193 (ImplicitConversionRequired): When reporting a conversion error,
20194 use error 31 to print out the constant error instead of the
20197 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20198 which fixes bug 51347.
20200 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20202 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20203 which fixes the -warnaserror command line option.
20205 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20207 * cfold.cs (DoNumericPromotions): During constant folding of
20208 additions on UIntConstant, special case intconstants with
20209 IntConstants like we do on the expression binary operator.
20211 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20213 * convert.cs (ImplicitReferenceConversion): We were missing a case
20214 (System.Enum are not value types or class types, so we need to
20215 classify them separatedly).
20217 * driver.cs: We do not support error 2007.
20219 2003-11-12 Jackson Harper <jackson@ximian.com>
20221 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20222 system directory. Also use the full file name so users can
20223 libraries names mscorlib-o-tron.dll in a non system dir.
20225 2003-11-10 Martin Baulig <martin@ximian.com>
20227 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20228 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20229 calling `ResolveType()' on them, directly assign their `Type'.
20231 2003-11-08 Martin Baulig <martin@ximian.com>
20233 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20234 return value and the `out parent' parameter.
20235 (TypeContainer.DefineType): Moved the CS0644 check into
20236 GetClassBases(). Don't pass the interface types to the
20237 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20238 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20240 * ecore.cs (TypeExpr.IsAttribute): New property.
20241 (TypeExpr.GetInterfaces): New method.
20243 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20244 TypeExpr instead of a Type.
20245 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20246 (Interface.DefineType): Don't pass the interface types to the
20247 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20248 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20250 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20251 instead of a `Type[]'.
20252 (TypeManager.RegisterBuilder): Likewise.
20253 (TypeManager.AddUserInterface): Likewise.
20254 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20255 `Type[]' and also return a `TypeExpr[]'.
20256 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20258 2003-11-08 Martin Baulig <martin@ximian.com>
20260 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20263 2003-11-08 Martin Baulig <martin@ximian.com>
20265 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20266 TypeManager.ResolveExpressionTypes().
20268 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20269 instead of an Expression.
20270 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20271 (TypeExpression): New public class; formerly known as `TypeExpr'.
20273 * expression.cs (ComposedCast): Derive from TypeExpr.
20275 * typemanager.cs (TypeManager.system_*_expr): These are now
20276 TypExpr's instead of Expression's.
20277 (TypeManager.ResolveExpressionTypes): New public static function;
20278 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20281 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20283 * expression.cs (New.DoResolve): Do not dereference value that
20284 might be a null return.
20286 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20287 sure that the constant value has the right type. Fixes an
20288 unreported bug, similar to 50425.
20290 * const.cs (Const.LookupConstantValue): Call
20291 ImplicitStandardConversionExists before doing a conversion to
20292 avoid havng the TypeManager.ChangeType do conversions.
20294 Reduced the number of casts used
20296 (Const.ChangeType): New routine to enable reuse of the constant
20297 type changing code from statement.
20299 * typemanager.cs (ChangeType): Move common initialization to
20300 static global variables.
20304 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20305 every value type to go through, even if it was void. Fix that.
20307 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20308 character of the define, and the is_identifier_part_character for
20309 the rest of the string.
20311 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20313 * expression.cs (UnaryMutator.EmitCode): When I updated
20314 LocalVariableReference.DoResolve, I overdid it, and dropped an
20315 optimization done on local variable references.
20317 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20319 * ecore.cs: Convert the return from Ldlen into an int.
20321 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20323 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20324 the accessibility, this is a special case for toplevel non-public
20325 classes (internal for instance).
20327 2003-10-20 Nick Drochak <ndrochak@gol.com>
20329 * ecore.cs: Fix typo and build. Needed another right paren.
20331 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20333 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20334 `internal' case regular and protected, but not allowing protected
20335 to be evaluated later. Bug 49840
20337 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20339 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20340 to kb.Nlast, and not the kb.nFirst to isolate the switch
20343 Extract the underlying type, so enumerations of long/ulong are
20344 treated like long/ulong.
20346 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20348 * expression.cs (New): Overload the meaning of RequestedType to
20349 track the possible creation of the NewDelegate type, since
20350 DoResolve is invoked more than once for new constructors on field
20353 See bugs: #48800 and #37014
20355 * cs-parser.jay (declare_local_constants): Take an arraylist
20356 instead of a single constant.
20358 (local_constant_declaration): It should take a
20359 constant_declarators, not a constant_declarator. Fixes 49487
20361 * convert.cs: Fix error report.
20363 2003-10-13 Jackson Harper <jackson@ximian.com>
20365 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20368 2003-10-09 Martin Baulig <martin@ximian.com>
20370 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20372 (MethodCore.DoDefineParameters): Removed the TypeContainer
20373 argument; use the DeclSpace which was passed to the .ctor instead.
20374 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20375 TypeContainer; we only need a DeclSpace here.
20377 2003-10-09 Martin Baulig <martin@ximian.com>
20379 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20381 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20382 EmitContext's .ctor.
20384 2003-10-09 Martin Baulig <martin@ximian.com>
20386 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20387 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20388 AsAccessible(), moved them as well.
20390 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20392 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20394 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20396 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20398 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20399 generation for >=, as spotted by Paolo, bug 48679.
20400 Patch from David Waite.
20402 * cs-tokenizer.cs: Add handling for #pragma.
20404 * cs-parser.jay: Allow for both yield and yield return in the
20405 syntax. The anti-cobolization of C# fight will go on!
20407 * class.cs (TypeBuilder.DefineType): Catch error condition here
20408 (Parent.DefineType erroring out and returning null).
20410 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20411 coping with enumerations variables, we were mistakenly processing
20412 them as a regular value type instead of built-in types. Fixes the
20415 * typemanager.cs (IsBuiltinOrEnum): New method.
20417 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20419 * cs-parser.jay: Upgrade: yield now needs the return clause.
20421 2003-09-19 Martin Baulig <martin@ximian.com>
20423 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20424 `MemberCache parent' argument. Normally, an interface doesn't
20425 have a parent type except System.Object, but we use this in gmcs
20426 for generic type parameters.
20428 2003-09-18 Martin Baulig <martin@ximian.com>
20430 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20431 on `type.IsInterface'; don't check whether the type has a parent
20432 to determine whether it's an interface.
20434 2003-09-15 Martin Baulig <martin@ximian.com>
20436 * class.cs (TypeContainer.DefineType): Added an error flag to
20437 avoid reporting duplicate CS0146's ("class definition is
20440 * driver.cs (Driver.MainDriver): Abort if
20441 RootContext.ResolveTree() reported any errors.
20443 2003-09-07 Martin Baulig <martin@ximian.com>
20445 * report.cs (Error, Warning): Added overloaded versions which take
20446 a `params object[] args' and call String.Format().
20448 2003-09-07 Martin Baulig <martin@ximian.com>
20450 * decl.cs (DeclSpace..ctor): Don't call
20451 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20452 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20453 (DeclSpace.RecordDecl): New method.
20455 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20457 2003-09-02 Ravi Pratap <ravi@ximian.com>
20459 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20460 value attributes to be applied to ParameterBuilders.
20462 * class.cs (MethodCore.LabelParameters): Make static and more
20463 generic so that it can be used from other places - like interface
20464 methods, for instance.
20466 * interface.cs (Interface.Emit): Call LabelParameters before
20467 emitting attributes on the InterfaceMethod.
20469 2003-08-26 Martin Baulig <martin@ximian.com>
20471 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20472 resolving aliases; fixes #47927.
20474 2003-08-26 Martin Baulig <martin@ximian.com>
20476 * statement.cs (Using.DoResolve): This is internally emitting a
20477 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20478 do not always return. Fixes #47681.
20480 2003-08-26 Martin Baulig <martin@ximian.com>
20482 * decl.cs (MemberCore): Moved WarningNotHiding(),
20483 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20485 (AdditionResult): Make this nested in DeclSpace.
20486 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20487 argument; call NamespaceEntry.Define() unless we're nested in a
20490 * namespace.cs (Namespace.DefineName): New public function. This
20491 is called from DeclSpace's .ctor to add
20492 (Namespace.Lookup): Include DeclSpaces in the lookup.
20494 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20496 * const.cs (Const): Derive from MemberBase, not MemberCore.
20498 2003-08-25 Martin Baulig <martin@ximian.com>
20500 * convert.cs (Convert.ExplicitReferenceConversion): When
20501 converting from an interface type to a class, unbox if the target
20502 type is a struct type. Fixes #47822.
20504 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20506 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20509 2003-08-22 Martin Baulig <martin@ximian.com>
20511 * class.cs (TypeManager.DefineType): When defining a nested type,
20512 call DefineType() on our parent; fixes #47801.
20514 2003-08-22 Martin Baulig <martin@ximian.com>
20516 * class.cs (MethodData.Define): While checking if a method is an
20517 interface implementation, improve the test a bit more to fix #47654.
20519 2003-08-22 Martin Baulig <martin@ximian.com>
20521 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20522 correctly; fixes #47722.
20524 2003-08-22 Martin Baulig <martin@ximian.com>
20526 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20527 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20529 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20531 2003-08-22 Martin Baulig <martin@ximian.com>
20533 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20534 can only be assigned in static constructors. Fixes #47161.
20536 2003-08-22 Martin Baulig <martin@ximian.com>
20538 Rewrote and improved the flow analysis code.
20540 * flowbranching.cs (FlowBranching): Make this class abstract.
20541 (FlowBranching.CreateBranching): New static function to create a
20542 new flow branching.
20543 (FlowBranchingBlock, FlowBranchingException): New classes.
20544 (FlowBranching.UsageVector.Type): New public readonly field.
20545 (FlowBranching.UsageVector.Breaks): Removed the setter.
20546 (FlowBranching.UsageVector.Returns): Removed the setter.
20547 (FlowBranching.UsageVector): Added Break(), Return(),
20548 NeverReachable() and Throw() methods to modify the reachability.
20549 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20550 done by FlowBranching.Merge().
20551 (FlowBranching.UsageVector.MergeChild): New method; merges the
20552 merge result into the current vector.
20553 (FlowBranching.Merge): New abstract method to merge a branching.
20555 2003-08-12 Martin Baulig <martin@ximian.com>
20557 * expression.cs (Indirection.CacheTemporaries): Create the
20558 LocalTemporary with the pointer type, not its element type.
20560 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20562 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20563 token was a keyword or not.
20565 Add `error' options where an IDENTIFIER was expected; Provide
20566 CheckToken and CheckIdentifierToken convenience error reporting
20569 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20571 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20572 NameSpaceEntry NameSpaceEntry.
20574 (LookupInterfaceOrClass): Avoid creating a full qualified name
20575 from namespace and name: avoid doing lookups when we know the
20576 namespace is non-existant. Use new Tree.LookupByNamespace which
20577 looks up DeclSpaces based on their namespace, name pair.
20579 * driver.cs: Provide a new `parser verbose' to display the
20580 exception thrown during parsing. This is turned off by default
20581 now, so the output of a failure from mcs is more graceful.
20583 * namespace.cs: Track all the namespaces defined in a hashtable
20586 (IsNamespace): New method
20588 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20590 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20591 we know that we need to concatenate (full typename can never be
20596 * statement.cs: Use a bitfield; Do not initialize to null things
20597 which are done by the constructor by default.
20599 * cs-parser.jay: bug fix, parameter was 4, not 3.
20601 * expression.cs: Just use the property;
20603 * statement.cs: No need for GetVariableInfo method.
20605 2003-08-08 Martin Baulig <martin@ximian.com>
20607 * flowanalysis.cs (FlowReturns): This is now nested in the
20608 `FlowBranching' class.
20609 (MyBitVector): Moved this here from statement.cs.
20610 (FlowBranching.SiblingType): New enum type.
20611 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20613 2003-08-07 Martin Baulig <martin@ximian.com>
20615 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20616 `FlowBranching' class and called `BranchingType'.
20618 2003-08-07 Martin Baulig <martin@ximian.com>
20620 * flowanalysis.cs: Moved all the control flow analysis code into
20623 2003-08-07 Martin Baulig <martin@ximian.com>
20625 * assign.cs (Assign.DoResolve): `target' must either be an
20626 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20629 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20631 * expression.cs (BinaryMethod): This kind of expression is created by the
20632 Binary class if it determines that the operator has to be handled
20635 (BinaryDelegate): This kind of expression is created if we are
20636 dealing with a + or - operator on delegates.
20638 (Binary): remove method, argumetns, and DelegateOperator: when
20639 dealing with methods,
20641 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20643 * statement.cs (Block): use bitfields for the three extra booleans
20644 we had in use. Remove unused topblock parameter.
20646 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20648 * assign.cs: Drop extra unneeded tests.
20650 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20652 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20654 * statement.cs (Foreach): Use VariableStorage instead of
20657 * codegen.cs (VariableStorage): New class used by clients that
20658 require a variable stored: locals or fields for variables that
20659 need to live across yield.
20661 Maybe provide a convenience api for EmitThis+EmitLoad?
20663 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20666 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20668 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20669 RemapParameterLValue): New methods that are used to turn a
20670 precomputed FieldInfo into an expression like this:
20674 The idea is to use this instead of making LocalVariableReference
20675 have more than one meaning.
20677 * cs-parser.jay: Add error production to BASE.
20679 * ecore.cs: Deal with TypeManager.GetField returning null, which
20680 is now a valid return value.
20682 (FieldExprNoAddress): New expression for Fields whose address can
20685 * expression.cs (LocalVariableReference): During the resolve
20686 phases, create new expressions if we are in a remapping context.
20687 Remove code that dealt with remapping here.
20689 (ParameterReference): same.
20691 (ProxyInstance): New expression, like the `This' expression, but
20692 it is born fully resolved. We know what we are doing, so remove
20693 the errors that are targeted to user-provided uses of `this'.
20695 * statement.cs (Foreach): our variable is now stored as an
20696 Expression; During resolution, follow the protocol, dont just
20697 assume it will return this.
20699 2003-08-06 Martin Baulig <martin@ximian.com>
20701 * support.cs (SeekableStreamReader.cs): New public class.
20703 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
20704 SeekableStreamReader instead of the normal StreamReader.
20706 2003-08-04 Martin Baulig <martin@ximian.com>
20708 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
20709 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
20710 deambiguate casts and delegate invocations.
20711 (parenthesized_expression): Use the new tokens to ensure this is
20712 not a cast of method invocation.
20714 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
20715 when reading a `)' and Deambiguate_CloseParens () was previously
20718 * expression.cs (ParenthesizedExpression): New class. This is
20719 just used for the CS0075 test.
20720 (Binary.DoResolve): Check for CS0075.
20722 2003-07-29 Ravi Pratap <ravi@ximian.com>
20724 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
20725 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
20726 reference comparison.
20728 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
20729 examine the ReturnType for equality - this is necessary in the
20730 cases of implicit and explicit operators whose signature also
20731 includes the return type.
20733 2003-07-26 Miguel de Icaza <miguel@ximian.com>
20735 * namespace.cs: Cache the result of the namespace computation,
20736 instead of computing it every time.
20738 2003-07-24 Miguel de Icaza <miguel@ximian.com>
20740 * decl.cs: Use a global arraylist that we reuse over invocations
20741 to avoid excesive memory consumption. Reduces memory usage on an
20742 mcs compile by one meg (45 average).
20744 * typemanager.cs (LookupTypeReflection): In .NET pointers are
20745 private, work around that.
20747 2003-07-23 Miguel de Icaza <miguel@ximian.com>
20749 * literal.cs (IntLiteral): Define Zero and One static literals.
20751 * cs-parser.jay (integer_literal): use static literals to reduce
20752 memory usage for the most used literals (0, 1 and -1). 211kb
20753 reduced in memory usage.
20755 Replace all calls to `new ArrayList' with `new
20756 ArrayList(4)' which is a good average number for most allocations,
20757 and also requires only 16 bytes of memory for its buffer by
20760 This reduced MCS memory usage in seven megabytes for the RSS after
20763 2003-07-28 Ravi Pratap <ravi@ximian.com>
20765 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
20766 handle params methods the correct way by forming only one
20767 applicable set with params and normal methods in them. Earlier we
20768 were looking at params methods only if we found no normal methods
20769 which was not the correct thing to do.
20771 (Invocation.BetterFunction): Take separate arguments indicating
20772 when candidate and the best method are params methods in their
20775 This fixes bugs #43367 and #46199.
20777 * attribute.cs: Documentation updates.
20779 (CheckAttribute): Rename to CheckAttributeTarget.
20780 (GetValidPlaces): Rename to GetValidTargets.
20782 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
20783 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
20787 2003-07-28 Martin Baulig <martin@ximian.com>
20789 * class.cs (TypeContainer.DefineMembers): Use the base type's full
20790 name when looking up the base class of a nested class. Fixes #46977.
20792 2003-07-26 Martin Baulig <martin@ximian.com>
20794 * expression.cs (Indexers.Indexer): New nested struct; contains
20795 getter, setter and the indexer's type.
20796 (Indexers.Properties): This is now an ArrayList of
20797 Indexers.Indexer's.
20798 (IndexerAccess.DoResolveLValue): Correctly set the type if the
20799 indexer doesn't have any getters.
20801 * assign.cs (Assign.DoResolve): Also do the implicit conversions
20802 for embedded property and indexer assignments.
20804 2003-07-26 Martin Baulig <martin@ximian.com>
20806 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
20807 preprocessor directive is not the first non-whitespace character
20810 2003-07-26 Martin Baulig <martin@ximian.com>
20812 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
20813 namespace parsing, follow the spec more closely.
20815 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
20816 NamespaceEntry.Lookup().
20818 2003-07-25 Martin Baulig <martin@ximian.com>
20820 * MethodCore.cs (OverridesSomething): New public field; it's set
20821 from TypeContainer.DefineMembers if this method overrides
20822 something (which doesn't need to be a method). Fix #39462.
20824 2003-07-25 Ravi Pratap <ravi@ximian.com>
20826 * typemanager.cs (GetMembers): Ensure that the list of members is
20827 reversed. This keeps things in sync.
20829 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
20830 find an AttributeUsage attribute.
20832 * expression.cs (Invocation.OverloadResolve): Perform the check
20833 which disallows Invoke to be directly called on a Delegate.
20835 (Error_InvokeOnDelegate): Report error cs1533.
20837 2003-07-25 Martin Baulig <martin@ximian.com>
20839 * expression.cs (Indexers.GetIndexersForType): Only look in the
20840 interface hierarchy if the requested type is already an
20841 interface. Fixes #46788 while keeping #46502 fixed.
20843 2003-07-25 Martin Baulig <martin@ximian.com>
20845 * class.cs (TypeContainer.DefineMembers): Check whether all
20846 readonly fields have been assigned and report warning CS0649 if
20849 * statement.cs (LocalInfo.IsFixed): Always return true if this is
20852 2003-07-24 Ravi Pratap <ravi@ximian.com>
20854 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
20855 returned from GetMethods to make things consistent with the
20856 assumptions MCS makes about ordering of methods.
20858 This should comprehensively fix bug #45127 and it does :-)
20860 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
20861 ordering is actually reverse.
20863 * Clean up some debug messages I left lying around.
20865 * interface.cs (Populate*): Get rid of code which emits attributes
20866 since the stage in which we emit attributes is the 'Emit' stage,
20867 not the define stage.
20869 (Emit): Move attribute emission for interface members here.
20871 2003-07-22 Ravi Pratap <ravi@ximian.com>
20873 * expression.cs (Invocation.OverloadResolve): Follow the spec more
20874 closely: we eliminate methods in base types when we have an
20875 applicable method in a top-level type.
20877 Please see section 14.5.5.1 for an exact description of what goes
20880 This fixes bug #45127 and a host of other related to corlib compilation.
20882 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
20883 array is the method corresponding to the top-level type (this is
20884 because of the changes made to icall.c) so we change this
20887 (MethodGroupExpr.Name): This too.
20889 * typemanager.cs (GetElementType): New method which does the right
20890 thing when compiling corlib.
20892 * everywhere: Make use of the above in the relevant places.
20894 2003-07-22 Martin Baulig <martin@ximian.com>
20896 * cs-parser.jay (invocation_expression): Moved
20897 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
20898 `cast_expression', but create a InvocationOrCast which later
20899 resolves to either an Invocation or a Cast.
20901 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
20902 method; call this before EmitStatement() to make sure that this
20903 expression can be used as a statement.
20905 * expression.cs (InvocationOrCast): New class; resolves to either
20906 an Invocation or a Cast.
20908 * statement.cs (StatementExpression): Call ResolveStatement() on
20909 the ExpressionStatement before emitting it.
20911 2003-07-21 Martin Baulig <martin@ximian.com>
20913 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
20914 `ref' and `out' attributes match; fixes #46220.
20915 (MemberAccess.ResolveMemberAccess): You can't reference a type
20916 through an expression; fixes #33180.
20917 (Indexers.GetIndexersForType): Don't return the indexers from
20918 interfaces the class implements; fixes #46502.
20920 2003-07-21 Martin Baulig <martin@ximian.com>
20922 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
20923 CS0661 checks; fixes bug #30442.
20925 2003-07-21 Martin Baulig <martin@ximian.com>
20927 * decl.cs (AdditionResult): Added `Error'.
20929 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
20931 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
20932 makes cs0031.cs actually work.
20934 2003-07-20 Martin Baulig <martin@ximian.com>
20936 * namespace.cs: Fixed that bug which caused a crash when compiling
20937 the debugger's GUI.
20939 2003-07-20 Miguel de Icaza <miguel@ximian.com>
20941 * typemanager.cs (LookupTypeReflection): Never expose types which
20942 are NotPublic, NestedPrivate, NestedAssembly, or
20943 NestedFamANDAssem. We used to return these, and later do a check
20944 that would report a meaningful error, but the problem is that we
20945 would not get the real match, if there was a name override.
20947 2003-07-18 Miguel de Icaza <miguel@ximian.com>
20949 * namespace.cs (Namespace, Name): Do not compute the namespace
20950 name dynamically, compute it in the constructor. This reduced
20951 memory usage by 1697 KB.
20953 * driver.cs: Use --pause to pause at the end.
20955 2003-07-17 Peter Williams <peter@newton.cx>
20957 * Makefile: Change the name of the test target so that it doesn't
20958 conflict with the recursive test target.
20960 2003-07-17 Miguel de Icaza <miguel@ximian.com>
20962 * expression.cs (LocalVariableReference.Emit, EmitAssign,
20963 AddressOf): Do not use EmitThis, that was wrong, use the actual
20966 2003-07-15 Miguel de Icaza <miguel@ximian.com>
20968 * class.cs (MethodData.Define): While checking if a method is an
20969 interface implementation, improve the test: If we are not public
20970 (use new test here: use the computed MethodAttributes directly,
20971 instead of the parsed modifier flags) check if the `implementing'
20972 method comes from an interface or not.
20974 * pending.cs (VerifyPendingMethods): Slightly better error
20977 * makefile: add test target that does the mcs bootstrap.
20979 2003-07-16 Ravi Pratap <ravi@ximian.com>
20981 * interface.cs (Define): Do nothing here since there are no
20982 members to populate etc. Move the attribute emission out of here
20983 since this was just totally the wrong place to put it. Attribute
20984 application happens during the 'Emit' phase, not in the 'Define'
20987 (Emit): Add this method and move the attribute emission here
20989 * rootcontext.cs (EmitCode): Call the Emit method on interface
20992 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20994 * expression.cs (OverloadResolve): Report error only if Location
20995 is not 'Null' which means that there was a probe going on.
20997 2003-07-14 Martin Baulig <martin@ximian.com>
20999 * expression.cs (ConditionalLogicalOperator): New public class to
21000 implement user defined conditional logical operators.
21001 This is section 14.11.2 in the spec and bug #40505.
21003 2003-07-14 Martin Baulig <martin@ximian.com>
21005 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21007 2003-07-14 Martin Baulig <martin@ximian.com>
21009 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21011 * ecore.cs (IVariable.VerifyFixed): New interface method.
21013 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21014 operator, check whether the variable is actually fixed. Fixes bug
21015 #36055. Set a variable definitely assigned when taking its
21016 address as required by the spec.
21018 * statement.cs (LocalInfo.IsFixed): New field.
21019 (LocalInfo.MakePinned): Set `IsFixed' to true.
21021 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21023 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21024 for .ctors, ensure that we only ask for members declared in the
21025 attribute type (BindingFlags.DeclaredOnly).
21029 * expression.cs (Error_WrongNumArguments): Report error 1501
21030 correctly the way CSC does.
21032 2003-07-13 Martin Baulig <martin@ximian.com>
21034 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21035 lookup on the fully qualified name, to make things like "X.X" work
21036 where "X.X" is a fully qualified type name, but we also have a
21037 namespace "X" in the using list. Fixes #41975.
21039 2003-07-13 Martin Baulig <martin@ximian.com>
21041 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21042 function. If we're a CompoundAssign, we need to create an embedded
21043 CompoundAssign, not an embedded Assign.
21044 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21047 2003-07-13 Martin Baulig <martin@ximian.com>
21049 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21050 work to fix bug #46088.
21052 2003-07-13 Ravi Pratap <ravi@ximian.com>
21054 * class.cs (Operator.Emit): Do not emit attributes here - it is
21055 taken care of by the Method class that we delegate too. This takes
21056 care of bug #45876.
21058 2003-07-10 Martin Baulig <martin@ximian.com>
21060 * expression.cs (TypeOfVoid): New class.
21061 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21063 2003-07-10 Martin Baulig <martin@ximian.com>
21065 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21068 2003-07-10 Martin Baulig <martin@ximian.com>
21070 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21071 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21073 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21075 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21077 2003-07-10 Martin Baulig <martin@ximian.com>
21079 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21080 of decimal. Fixes #42850.
21082 NOTE: I also fixed the created byte blob, but this doesn't work on
21083 the MS runtime and csc never produces any byte blobs for decimal
21086 2003-07-10 Martin Baulig <martin@ximian.com>
21088 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21089 structs; fixes #32068.
21090 (Block.AddChildVariableNames): Fixed #44302.
21092 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21094 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21096 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21098 * attribute.cs: And this test is onger needed.
21100 2003-07-08 Martin Baulig <martin@ximian.com>
21102 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21103 inaccessible types. Fixes #36313.
21105 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21107 * namespace.cs (NamespaceEntry): Create implicit entries for all
21108 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21109 implicit entries for N1.N2 and N1.
21111 2003-07-08 Martin Baulig <martin@ximian.com>
21113 Rewrote the handling of namespaces to fix a lot of the issues
21114 wrt. `using' aliases etc.
21116 * namespace.cs (Namespace): Splitted this class into a
21117 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21119 * typemanager.cs (TypeManager.IsNamespace): Removed.
21120 (TypeManager.ComputeNamespaces): Only compute namespaces from
21121 loaded assemblies here, not the namespaces from the assembly we're
21122 currently compiling.
21124 2003-07-08 Martin Baulig <martin@ximian.com>
21126 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21128 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21130 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21133 I thought about the memory savings here, but LookupTypeReflection
21134 is used under already very constrained scenarios. Compiling
21135 corlib or mcs only exposes one hit, so it would not really reduce
21136 any memory consumption.
21138 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21140 * typemanager.cs: fixes bug #45889 by only adding public types from
21141 other assemblies to the list of known types.
21143 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21145 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21146 on the type we resolved.
21148 2003-07-05 Martin Baulig <martin@ximian.com>
21150 * pending.cs (PendingImplementation.ParentImplements): Don't
21151 create the proxy if the parent is abstract.
21153 * class.cs (TypeContainer.DefineIndexers): Process explicit
21154 interface implementations first. Fixes #37714.
21156 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21158 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21159 defined recursively; but since we modify the input parameters
21160 (left is set to `this' temporarily), we reset this value if the
21161 left_is_explicit is false, which gives the original semantics to
21164 * literal.cs (NullPointer): new class used to represent a null
21165 literal in a pointer context.
21167 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21168 type is a pointer, use a NullPointer object instead of a
21169 NullLiteral. Closes 43687
21171 (ExplicitConversion): Convert pointer values using
21172 the conv opcode to the proper type.
21174 * ecore.cs (New): change ValueTypeVariable property into a method,
21175 that returns whether the valuetype is suitable for being used.
21177 * expression.cs (Binary.DoNumericPromotions): Only return if we
21178 the int constant was a valid uint, and we can return both left and
21179 right as uints. If not, we continue processing, to trigger the
21180 type conversion. This fixes 39018.
21182 * statement.cs (Block.EmitMeta): During constant resolution, set
21183 the CurrentBlock property on the emitcontext, so that we resolve
21184 constants propertly.
21186 2003-07-02 Martin Baulig <martin@ximian.com>
21188 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21189 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21191 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21192 than emitting it here.
21194 * statement.cs: Fixed some more flow analysis bugs.
21196 2003-07-02 Martin Baulig <martin@ximian.com>
21198 * class.cs (MethodData.Define): When implementing interface
21199 methods, set Final unless we're Virtual.
21201 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21202 check work for interface methods.
21204 2003-07-01 Martin Baulig <martin@ximian.com>
21206 * ecore.cs (EmitContext.This): Replaced this property with a
21207 GetThis() method which takes a Location argument. This ensures
21208 that we get the correct error location for a CS0188.
21210 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21212 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21213 ImplicitStandardConversion.
21215 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21217 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21219 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21222 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21224 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21227 (MethodData.Define): Turn off initlocals for unsafe methods.
21229 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21231 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21232 complete; Fixes #37521.
21234 * delegate.cs: Use Modifiers.TypeAttr to compute the
21235 TypeAttributes, instead of rolling our own. This makes the flags
21236 correct for the delegates.
21238 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21240 * class.cs (Constructor.Define): Set the private flag for static
21241 constructors as well.
21243 * cs-parser.jay (statement_expression): Set the return value to
21244 null, to avoid a crash when we catch an error.
21246 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21248 * cs-parser.jay: Applied patch from Jackson that adds support for
21249 extern and unsafe modifiers to destructor declarations.
21251 * expression.cs: Report error 21 if the user is trying to index a
21254 * driver.cs: Add an error message, suggested by the bug report.
21256 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21257 if we do not have a ": this ()" constructor initializer. Fixes 45149
21259 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21261 * namespace.cs: Add some information to reduce FAQs.
21263 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21265 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21266 underlying enumeration types. Fixes #43915.
21268 * expression.cs: Treat ushort/short as legal values to be used in
21269 bitwise operations.
21271 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21273 * delegate.cs: transfer custom attributes for paramenters from
21274 the delegate declaration to Invoke and BeginInvoke.
21276 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21278 * attribute.cs: handle custom marshalers and emit marshal info
21281 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21283 * makefile.gnu: Added anonymous.cs to the compiler sources.
21285 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21287 * iterators.cs: Change the name of the proxy class to include two
21290 * cs-parser.jay: Update grammar to include anonymous methods.
21292 * anonymous.cs: new file.
21294 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21296 * class.cs (Field.Define): Add missing test for pointers and
21299 2003-05-27 Ravi Pratap <ravi@ximian.com>
21301 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21302 we use the stobj opcode.
21304 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21305 since it wasn't the correct fix.
21307 It still is puzzling that we are required to use stobj for IntPtr
21308 which seems to be a ValueType.
21310 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21312 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21313 during regular simple name resolution. Now, the trick is that
21314 instead of returning for processing the simplename, we do a
21315 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21316 contextual lookup type). If a match is found, return that, if
21317 not, return for further composition.
21319 This fixes long-standing 30485.
21321 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21322 using the address to initialize an object, do an Stobj instead of
21323 using the regular Stelem.
21325 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21326 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21327 Because if we are a BaseIndexerAccess that value will be true.
21330 * statement.cs (GotoCase.Resolve): Return after reporting an
21331 error, do not attempt to continue.
21333 * expression.cs (PointerArithmetic.Emit): If our operand is a
21334 long, convert our constants to match the operand before
21335 multiplying. Convert to I type before adding. Fixes 43670.
21337 2003-05-14 Ravi Pratap <ravi@ximian.com>
21339 * enum.cs (ImplicitConversionExists) : Rename to
21340 ImplicitEnumConversionExists to remove ambiguity.
21342 * ecore.cs (NullCast): New type of cast expression class which
21343 basically is very similar to EmptyCast with the difference being
21344 it still is a constant since it is used only to cast a null to
21346 (eg. (string) null)
21348 * convert.cs (ImplicitReferenceConversion): When casting a null
21349 literal, we return a NullCast.
21351 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21352 should be around anymore.
21354 The renaming (reported was slightly wrong). Corrections:
21356 ConvertImplicitStandard -> ImplicitConversionStandard
21357 ConvertExplicitStandard -> ExplicitConversionStandard
21359 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21360 before passing them in !
21362 * convert.cs (ImplicitConversionStandard): When comparing for
21363 equal expr and target types, ensure that expr is not a
21366 In general, we must not be checking (expr_type ==
21367 target_type) in the top level conversion methods
21368 (ImplicitConversion, ExplicitConversion etc). This checking is
21369 done in the methods that they delegate to.
21371 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21373 * convert.cs: Move Error_CannotConvertType,
21374 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21375 ImplicitNumericConversion, ImplicitConversionExists,
21376 ImplicitUserConversionExists, StandardConversionExists,
21377 FindMostEncompassedType, FindMostSpecificSource,
21378 FindMostSpecificTarget, ImplicitUserConversion,
21379 ExplicitUserConversion, GetConversionOperators,
21380 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21381 TryImplicitIntConversion, Error_CannotConvertImplicit,
21382 ConvertImplicitRequired, ConvertNumericExplicit,
21383 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21384 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21387 Perform the following renames:
21389 StandardConversionExists -> ImplicitStandardConversionExists
21390 ConvertImplicit -> ImplicitConversion
21391 ConvertImplicitStandard -> ImplicitStandardConversion
21392 TryImplicitIntConversion -> ImplicitIntConversion
21393 ConvertImplicitRequired -> ImplicitConversionRequired
21394 ConvertNumericExplicit -> ExplicitNumericConversion
21395 ConvertReferenceExplicit -> ExplicitReferenceConversion
21396 ConvertExplicit -> ExplicitConversion
21397 ConvertExplicitStandard -> ExplicitStandardConversion
21399 2003-05-19 Martin Baulig <martin@ximian.com>
21401 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21402 (TypeInfo): Added support for structs having structs as fields.
21404 * ecore.cs (FieldExpr): Implement IVariable.
21405 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21406 VariableInfo for the field.
21408 2003-05-18 Martin Baulig <martin@ximian.com>
21410 * expression.cs (This.DoResolve): Report a CS0027 if we're
21411 emitting a field initializer.
21413 2003-05-18 Martin Baulig <martin@ximian.com>
21415 * expression.cs (This.ResolveBase): New public function.
21416 (This.DoResolve): Check for CS0188.
21418 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21421 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21422 `instance_expression' to null if we don't have any non-static
21425 2003-05-18 Martin Baulig <martin@ximian.com>
21427 Reworked the way how local variables and parameters are handled by
21428 the flow analysis code.
21430 * statement.cs (TypeInfo, VariableMap): New public classes.
21431 (VariableInfo): New public class. This is now responsible for
21432 checking whether a variable has been assigned. It is used for
21433 parameters and local variables.
21434 (Block.EmitMeta): Take the InternalParameters as argument; compute
21435 the layout of the flow vectors here.
21436 (Block.LocalMap, Block.ParameterMap): New public properties.
21437 (FlowBranching): The .ctor doesn't get the InternalParameters
21438 anymore since Block.EmitMeta() now computes the layout of the flow
21440 (MyStructInfo): This class is now known as `StructInfo' and nested
21441 in `TypeInfo'; we don't access this directly anymore.
21443 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21444 property and removed IsAssigned(), IsFieldAssigned(),
21445 SetAssigned() and SetFieldAssigned(); we now call them on the
21446 VariableInfo so we don't need to duplicate this code everywhere.
21448 * expression.cs (ParameterReference): Added `Block block' argument
21450 (LocalVariableReference, ParameterReference, This): The new
21451 VariableInfo class is now responsible for all the definite
21454 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21455 IsParameterAssigned, SetParameterAssigned): Removed.
21457 2003-05-18 Martin Baulig <martin@ximian.com>
21459 * typemanager.cs (InitCoreTypes): Try calling
21460 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21461 the 3-args-version. Corlib now also needs our `void_type'.
21462 (GetMethod): Added overloaded version which takes an optional
21463 `bool report_errors' to allow lookups of optional methods.
21465 2003-05-12 Martin Baulig <martin@ximian.com>
21467 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21468 only used for locals and not for parameters.
21470 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21472 * support.cs (InternalParameters.ParameterType): Return the
21473 ExternalType of the parameter.
21475 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21478 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21480 * class.cs (MethodData.Define): Do not set the `newslot' on
21481 interface members, if they are also flagged as "override".
21483 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21484 better code for ++i and i++. This only works for static fields
21485 and local variables.
21487 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21488 want to pull the DeclSpace out of the builder_to_declspace instead
21489 of the TypeBuilder (like in TypeContainer.FindMembers).
21491 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21492 instead of LookupTypeContainer. Fixes the crash on .NET for
21493 looking up interface members.
21495 * const.cs: Create our own emit context during the Definition
21496 stage, so that constants are evaluated in the proper context, when
21497 a recursive definition happens.
21499 2003-05-11 Martin Baulig <martin@ximian.com>
21501 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21502 new block for a switch section.
21503 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21504 the adding/lookup in the switch block. Fixes #39828.
21506 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21508 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21509 functionality: I needed to convert the data after I had performed
21510 the add/sub operation into the operands type size.
21512 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21513 pass the type for the box operation, otherwise the resulting
21514 object would have been of type object.
21516 (BoxedCast): Add constructor to specify the type to box as.
21518 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21520 * iterators.cs: I was reusing the `count' variable inadvertently,
21521 take steps to not allow this to happen.
21523 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21525 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21526 by creating an array at the point where the params starts and
21527 putting all those arguments there, then adjusting the size of the
21530 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21532 * expression.cs (New.AddressOf): Implement interface
21533 IMemoryLocation. This is used when the `new' operator is used in
21534 the context of an invocation to a method on a value type.
21536 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21539 * namespace.cs: Also check the using aliases here.
21541 * driver.cs: Move the test for using validity after the types have
21542 been entered, so we do a single pass that also includes the using
21545 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21546 in the regular case. CreateSiblingForFinally is doing extra
21549 * attribute.cs (GetAttributeArgumentExpression): Store the result
21550 on an out value, and use the return value to indicate failure
21551 instead of using null (which is a valid return for Constant.GetValue).
21553 * statement.cs: Perform the analysis flow for the increment
21554 portion after the statement, because this will be the real flow of
21555 execution. Fixes #42385
21557 * codegen.cs (EmitContext.EmitArgument,
21558 EmitContext.EmitStoreArgument): New helper functions when the
21559 RemapToProxy flag is set.
21561 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21564 Add support for remapping parameters.
21566 * iterators.cs: Propagate parameter values; Store parameter
21567 values in the proxy classes.
21569 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21571 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21572 need a proxy reference; I do not know what I was thinking
21574 * cs-parser.jay (constructor_initializer): catch another error,
21575 and display nice message.
21577 (field_declaration): catch void field declaration
21578 to flag a better error.
21580 * class.cs (MemberBase.CheckBase): Report an error instead of a
21581 warning if a new protected member is declared in a struct.
21582 (Field.Define): catch the error of readonly/volatile.
21584 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21586 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21587 volatile variable is taken
21589 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21591 * statement.cs (Fixed.Resolve): Report an error if we are not in
21594 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21596 * typemanager.cs: reuse the code that handles type clashes for
21597 delegates and enumerations.
21599 * class.cs (Report28): Always report.
21601 * expression.cs (EncodeAsAttribute): Allow nulls here.
21603 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21605 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21606 the functionality for testing whether an expression is valid for
21607 an attribute here. Also handle the case of arrays of elements
21610 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21611 encoding a linear array into an array of objects that are suitable
21612 to be passed to an CustomAttributeBuilder.
21614 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21616 * ecore.cs: (FieldExpr): Handle field remapping here.
21618 * iteratators.cs: Pass the instance variable (if the method is an
21619 instance method) to the constructors, so we can access the field
21620 variables on the class.
21622 TODO: Test this with structs. I think the THIS variable on
21623 structs might have to be a pointer, and not a refenrece
21625 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21627 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21628 local variables to fields in a proxy class.
21630 * iterators.cs (PopulateProxy): Rename our internal fields to
21632 Create a <THIS> field if we are an instance method, so we can
21633 reference our parent container variables.
21634 (MapVariable): Called back from the EmitContext code to enter a
21635 new variable to field mapping into the proxy class (we just create
21639 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21640 for using the remapped locals to fields.
21642 I placed the code here, because that gives the same semantics to
21643 local variables, and only changes the Emit code.
21645 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21646 statements inside iterators.
21647 (VariableInfo): Add a FieldBuilder for the cases when we are
21648 remapping local variables to fields in a proxy class
21650 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21651 current_block != null.
21653 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21654 not cope with strings, as it has been moved to the
21655 TableSwitchEmit. Fixed bug in switch generation.
21657 * expression.cs (New.DoResolve): Provide more context for the user
21658 when reporting an error.
21660 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21663 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21664 check the permissions for it. Note than in a type-resolution
21665 context the check was already present in DeclSpace.ResolveType,
21666 but was missing from the MemberAccess.
21668 (ArrayCreation.CheckIndices): warn if the user has
21669 more nested levels of expressions, but there are no more
21670 dimensions specified. Avoids crash on bug 41906.
21672 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21674 * statement.cs (Block): replace Implicit bool, for a generic
21676 New flag: `Unchecked'. This is used during the EmitMeta phase
21677 (which is out-of-line with the regular Resolve/Emit process for a
21678 statement, as this is done ahead of time, but still gets a chance
21679 to call constant resolve).
21681 (Block.Flags): new enum for adding a new flag.
21683 (Block.EmitMeta): track the state of unchecked.
21685 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21686 to enable constant resolution to work there as well.
21688 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21690 * typemanager.cs (ienumerable_type): Also look up
21691 System.Collections.IEnumerable.
21693 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21695 TODO: Test more than one conditional per method.
21697 * class.cs (Indexer.Define): Report the location where the user is
21698 referencing the unsupported feature.
21700 (MethodData): Overload the use of `conditionals' to
21701 minimize the creation of needless ArrayLists. This saves roughly
21702 212kb on my machine.
21704 (Method): Implement the new IIteratorContainer interface.
21705 (Method.SetYields): Implement the method by setting the ModFlags
21706 to contain METHOD_YIELDS.
21708 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
21709 which just got set to null.
21711 * iterators.cs: New file.
21713 (Yield, YieldBreak): New statements.
21715 * statement.cs (Return.Resolve): Flag an error if we are used in
21716 an iterator method.
21718 * codegen.cs (InIterator): New flag set if the code is being
21719 compiled in an iterator method.
21721 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
21722 internal modifier, and we just use it to avoid adding extra
21723 fields, as this is seldom used.
21725 * cs-parser.jay: Add yield_statement (yield and yield break).
21727 * driver.cs: New flag -v2 to turn on version 2 features.
21729 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
21730 hashtable when v2 is enabled.
21732 2003-04-20 Miguel de Icaza <miguel@ximian.com>
21734 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
21735 there is already a namespace defined with this name.
21737 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
21738 people upgraded their corlibs.
21740 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
21741 always use fully qualified types, no need to use the compiler
21744 (TypeManager.IsNamespace): Use binarysearch.
21746 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
21747 AddDelegate): I did not quite use the new IsValid API properly: I
21748 have to pass the short-name and the fullname. I was passing only
21749 the basename instead of the fullname sometimes.
21751 (TypeContainer.DefineType): call NamespaceClash.
21753 * interface.cs (Interface.DefineType): use NamespaceClash before
21756 * delegate.cs (Delegate.DefineType): use NamespaceClash before
21759 * enum.cs: (Enum.DefineType): use NamespaceClash before
21762 * typemanager.cs (: 3-line patch that gives us some tasty 11%
21763 speed increase. First, use the negative_hits cache when we get a
21764 negative. Second, add the type with its full original name
21765 instead of the new . and + encoded name (reflection uses + to
21766 separate type from a nested type). Use LookupTypeReflection
21767 directly which bypasses the type->name hashtable (that we already
21768 know does not contain the type.
21770 * decl.cs (DeclSpace.ResolveTypeExpr): track the
21771 location/container type.
21773 * driver.cs: When passing utf8, use directly the UTF8Encoding.
21775 2003-04-19 Miguel de Icaza <miguel@ximian.com>
21777 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
21779 * delegate.cs (NewDelegate.Resolve): Test whether an instance
21780 method is being referenced in the method group from a static
21781 context, and report error 120 if so.
21783 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
21786 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
21787 is created, we create the A namespace).
21789 * cs-parser.jay: A namespace also introduces a DeclarationFound.
21792 2003-04-18 Miguel de Icaza <miguel@ximian.com>
21794 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
21795 invocation to ModuleBuilder.GetType with the same values will
21796 return a new type instance, so we need to cache its return
21799 * expression.cs (Binary.ResolveOperator): Only allow the compare
21800 operators on enums if they are of the same type.
21802 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
21803 types of ValueType on their own case. Before we were giving them
21804 the same treatment as objects.
21806 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
21807 fullname. Short name is used to compare against container name.
21808 Fullname is used to check against defined namespace names.
21810 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
21811 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
21813 (Method.CheckBase): Call parent.
21814 (MemberBase.CheckBase): Check for protected members on sealed
21816 (PropertyBase.CheckBase): Call parent.
21817 (Field.Define): Call parent.
21819 * report.cs: Negative error codes are now mapped to 8000 - code,
21820 so that the display is render more nicely.
21822 * typemanager.cs: Do not use try/catch, instead report a regular
21825 (GetPointerType, GetReferenceType): These methods provide
21826 mechanisms to obtain the T* and T& from a T. We had the code
21827 previously scattered around the code base, and it also used
21828 TypeManager.LookupType that would go through plenty of caches.
21829 This one goes directly to the type source.
21831 In some places we did the Type.GetType followed by
21832 ModuleBuilder.GetType, but not in others, so this unifies the
21833 processing as well.
21835 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
21836 statements now that we have namespace information.
21838 * typemanager.cs (IsNamespace): New method, returns whether the
21839 string presented is a namespace or not.
21841 (ComputeNamespaces): New public entry point, computes the list of
21842 available namespaces, using the GetNamespaces API call in Mono, or
21843 the slower version in MS.NET.
21845 Now before we start the semantic analysis phase, we have a
21846 complete list of namespaces including everything that the user has
21849 Deleted old code to cache namespaces in .nsc files.
21851 2003-04-17 Miguel de Icaza <miguel@ximian.com>
21853 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
21854 class/struct location definition Location for the implicit
21855 constructor location.
21857 (Operator.Define): Use the location of the operator for the
21858 implicit Method definition.
21860 (Constructor.Emit): use the constructor location for the implicit
21861 base initializer constructor.
21863 * ecore.cs: Remove ITypeExpression. This interface is now gone,
21864 and the Expression class now contains two new methods:
21866 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
21867 isolate type lookup from the rest of the resolution process.
21869 Since we use Expressions to hold type definitions due to the way
21870 we parse the input we have historically overloaded Resolve to
21871 perform the Type lookups if a special flag is passed. Now this is
21872 eliminated and two methods take their place.
21874 The differences in the two methods between xStep and xTerminal is
21875 that xStep is involved in our current lookup system that uses
21876 SimpleNames to compose a name, while xTerminal is used just to
21877 catch the case where the simplename lookup failed.
21879 2003-04-16 Miguel de Icaza <miguel@ximian.com>
21881 * expression.cs (ResolveMemberAccess): Remove redundant code.
21882 TypeExpr expressions are always born fully resolved.
21884 * interface.cs (PopulateMethod): Do not lookup the types twice.
21885 We were doing it once during SemanticAnalysis and once during
21888 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
21889 in local variable type definitions, were being returned as a
21890 SimpleName (we decomposed everything into a string), that is
21891 because primary_expression was being used instead of a type in the
21892 grammar (reduce/reduce conflicts).
21894 The part that was wrong is that we converted the expression into a
21895 string (an oversimplification in one hand, compounded with primary
21896 expressions doing string concatenation).
21902 Would return "A.B.C[]" as a SimpleName. This stopped things like
21903 using clauses from working on this particular context. And a type
21904 was being matched directly against "A.B.C[]".
21906 We now use the correct approach, and allow for ComposedCast to be
21907 part of the unary expression. So the "A.B.C []" become a composed
21908 cast of "A.B.C" (as a nested group of MemberAccess with a
21909 SimpleName at the end) plus the rank composition "[]".
21913 2003-04-10 Miguel de Icaza <miguel@ximian.com>
21915 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
21916 for the access level checking.
21918 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
21919 `TypeContainer container', because I kept getting confused when I
21920 was debugging this code.
21922 * expression.cs (Indexers): Instead of tracking getters/setters,
21923 we now track them in parallel. We create one arraylist less, but
21924 most importantly it is possible now for the LValue code to find a
21925 matching get for a set.
21927 (IndexerAccess.DoResolveLValue): Update the code.
21928 GetIndexersForType has been modified already to extract all the
21929 indexers from a type. The code assumed it did not.
21931 Also make the code set the correct return type for the indexer.
21932 This was fixed a long time ago for properties, but was missing for
21933 indexers. It used to be void_type.
21935 (Binary.Emit): Test first for doubles instead of
21936 floats, as they are more common.
21938 (Binary.EmitBranchable): Use the .un version of the branch opcodes
21939 when dealing with floats and the <=, >= operators. This fixes bug
21942 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
21943 to load the array value by emitting a load on the foreach variable
21944 type. This was incorrect.
21946 We now emit the code to load an element using the the array
21947 variable type, and then we emit the conversion operator.
21951 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
21953 * attribute.cs: Avoid allocation of ArrayLists in the common case.
21955 2003-04-09 Miguel de Icaza <miguel@ximian.com>
21957 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
21958 test for protection before we test for signatures.
21960 (MethodSignature.ToString): implement.
21962 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
21963 to the case where we reduced into a LongConstant.
21965 * decl.cs (CheckAccessLevel): If the type is an array, we can not
21966 depend on whether the information is acurrate, because the
21967 Microsoft runtime will always claim that the array type is public,
21968 regardless of the real state.
21970 If the type is a pointer, another problem happens: the type is
21971 reported as non-public in Microsoft.
21973 In both cases we have to call CheckAccessLevel recursively with
21974 the underlying type as the argument to be tested.
21976 2003-04-08 Miguel de Icaza <miguel@ximian.com>
21978 * assign.cs (Assign.Emit): If we are dealing with a compound
21979 assignment expression, we should use the code path that stores the
21980 intermediate result in a temporary value. This fixes #40903.
21982 *expression.cs (Indirection.ToString): Provide ToString method for
21985 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
21987 * class.cs: Null out fields holding references to Block objects so
21988 they can be garbage collected.
21990 * expression.cs (OverloadResolve): Remove unused local.
21992 2003-04-07 Martin Baulig <martin@ximian.com>
21994 * codegen.cs (EmitContext.CurrentFile): New public field.
21995 (EmitContext.Mark): Use the CurrentFile to check whether the
21996 location is in the correct file.
21997 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
21999 2003-04-07 Martin Baulig <martin@ximian.com>
22001 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22003 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22004 location. [FIXME: The location argument which gets passed to this
22005 method is sometimes wrong!]
22007 2003-04-07 Nick Drochak <ndrochak@gol.com>
22009 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22011 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22013 * expression.cs (Indirection.EmitAssign): We were using the
22014 temporary, but returning immediately instead of continuing the
22017 2003-04-06 Martin Baulig <martin@ximian.com>
22019 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22020 if it's a nested child, but also deriving from the outer class.
22023 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22024 nested child, but also deriving from the outer class. See
22026 (FilterWithClosure): We may access private members of the outer
22027 class if we're a nested child and deriving from the outer class.
22028 (RealMemberLookup): Only set `closure_private_ok' if the
22029 `original_bf' contained BindingFlags.NonPublic.
22031 2003-04-05 Martin Baulig <martin@ximian.com>
22033 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22035 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22037 * class.cs (Event.Define): Do not allow abstract events to have
22040 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22042 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22043 block in event declarations.
22045 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22046 value type, get its address.
22048 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22049 leaving a class on the stack instead of a boolean value (int
22050 0/1). Change the code so we compare against null, and then the
22051 result against zero.
22053 * class.cs (TypeContainer.GetClassBases): We were checking for the
22054 parent class being sealed too late.
22056 * expression.cs (Binary.Emit): For <= and >= when dealing with
22057 floating point values, use cgt.un and clt.un instead of cgt and
22060 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22062 * statement.cs: Apply the same optimization as MS: skip the
22063 GetEnumerator returning an IEnumerator, and use the one returning a
22064 CharEnumerator instead. This allows us to avoid the try-finally block
22067 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22069 * cs-parser.jay: Attributes cannot be applied to
22070 namespaces. Fixes #40473
22072 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22075 (Add*): check if the name is valid using the full name for constants,
22076 fields, properties and events.
22078 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22080 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22081 char constants to be part of the enumeration.
22083 * expression.cs (Conditional.DoResolve): Add support for operator
22084 true. Implements the missing functionality from 14.12
22086 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22087 operator true/false as required by the spec.
22089 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22090 implicit conversion to boolean.
22092 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22093 also one where the type implements `operator true'.
22095 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22096 get an expression that will invoke operator true based on an
22099 (GetConversionOperators): Removed the hack that called op_True
22102 (Expression.ResolveBoolean): Move this from Statement.
22104 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22106 * ecore.cs (FieldExpr): do not allow initialization of initonly
22107 fields on derived classes
22109 2003-03-13 Martin Baulig <martin@ximian.com>
22111 * statement.cs (Block.Emit): Call ig.BeginScope() and
22112 ig.EndScope() when compiling with debugging info; call
22113 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22115 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22117 * expression.cs (Indexers): Do not construct immediately, allow
22118 for new members to be appended as we go. Fixes 38143
22120 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22122 * expression.cs: save/restore context when resolving an unchecked
22125 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22127 * cfold.cs: Catch division by zero in modulus operator during
22130 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22132 * interface.cs (Interface.DefineMembers): Avoid defining members
22135 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22137 * driver.cs: handle the +/- options for -noconfig
22139 * statement.cs (Unckeched.Resolve): Also track the state of
22140 unchecked in the Resolve phase.
22142 2003-02-27 Martin Baulig <martin@ximian.com>
22144 * ecore.cs (Expression.MemberLookup): Don't create a
22145 MethodGroupExpr for something which is not a method. Fixes #38291.
22147 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22149 * class.cs (MemberBase.CheckParameters): Also check that the type
22150 is unmanaged if it is a pointer.
22152 * expression.cs (SizeOf.Resolve): Add location information.
22154 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22155 a managed type is declared.
22157 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22158 parameter modifiers as well. Fixes bug 38606
22160 * class.cs: Very sad. Am backing out the speed up changes
22161 introduced by the ArrayList -> Array in the TypeContainer, as they
22162 were not actually that much faster, and introduced a bug (no error
22163 reports on duplicated methods).
22165 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22166 source first, this will guarantee that we have a valid expression
22167 before calling in lower levels functions that will require a
22168 resolved object. Then use this original_source in the
22169 target.ResolveLValue instead of the original source that was
22172 Another change. Use target.Resolve instead of LValueResolve.
22173 Although we are resolving for LValues, we will let the Assign code
22174 take care of that (it will be called again from Resolve). This
22175 basically allows code like this:
22177 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22178 class Y { void A (X x) { x [0] += o; }
22180 The problem was that the indexer was trying to resolve for
22181 set_Item (idx, object o) and never finding one. The real set_Item
22182 was set_Item (idx, X). By delaying the process we get the right
22187 2003-02-23 Martin Baulig <martin@ximian.com>
22189 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22190 while calling DoEmit ().
22192 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22193 source files; if you use the #line directive inside a method, the
22194 compiler stops emitting line numbers for the debugger until it
22195 reaches the end of the method or another #line directive which
22196 restores the original file.
22198 2003-02-23 Martin Baulig <martin@ximian.com>
22200 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22202 2003-02-23 Martin Baulig <martin@ximian.com>
22204 * statement.cs (Block.AddChildVariableNames): We need to call this
22205 recursively, not just for our immediate children.
22207 2003-02-23 Martin Baulig <martin@ximian.com>
22209 * class.cs (Event.Define): Always make the field private, like csc does.
22211 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22212 actually work, fixes bug #37521.
22214 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22216 * delegate.cs: When creating the various temporary "Parameters"
22217 classes, make sure that we call the ComputeAndDefineParameterTypes
22218 on those new parameters (just like we do with the formal ones), to
22219 allow them to be resolved in the context of the DeclSpace.
22221 This fixes the bug that Dick observed in Bugzilla #38530.
22223 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22225 * expression.cs (ResolveMemberAccess): When resolving a constant,
22226 do not attempt to pull a constant if the value was not able to
22227 generate a valid constant.
22229 * const.cs (LookupConstantValue): Do not report more errors than required.
22231 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22233 * expression.cs: fixes bug #38328.
22235 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22237 * class.cs: Changed all the various members that can be part of a
22238 class from being an ArrayList to be an Array of the right type.
22239 During the DefineType type_list, interface_list, delegate_list and
22240 enum_list are turned into types, interfaces, delegates and enums
22243 And during the member population, indexer_list, event_list,
22244 constant_list, field_list, instance_constructor_list, method_list,
22245 operator_list and property_list are turned into their real arrays.
22247 Although we could probably perform this operation earlier, for
22248 good error reporting we need to keep the lists and remove the
22249 lists for longer than required.
22251 This optimization was triggered by Paolo profiling the compiler
22252 speed on the output of `gen-sample-program.pl' perl script.
22254 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22255 not crash in methods like MemberLookupFailed that use this field.
22257 This problem arises when the compiler fails to resolve a type
22258 during interface type definition for example.
22260 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22262 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22263 inherit from System.Object, so we have to stop at null, not only
22264 when reaching System.Object.
22266 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22268 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22269 DeclaredOnly because the parent indexer might have had a different
22270 name, but did not loop until the top of the hierarchy was reached.
22272 The problem this one fixes is 35492: when a class implemented an
22273 indexer from an interface, we were getting the interface method
22274 (which was abstract) and we were flagging an error (can not invoke
22277 This also keeps bug 33089 functioning, and test-148 functioning.
22279 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22280 out if a method is special is to see if it is declared in a
22281 property or event, or whether it is one of the predefined operator
22282 names. This should fix correctly #36804.
22284 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22286 The goal here is to remove the dependency on EmptyCast.Peel ().
22287 Killing it completely.
22289 The problem is that currently in a number of places where
22290 constants are expected, we have to "probe" for an EmptyCast, and
22291 Peel, which is not the correct thing to do, as this will be
22292 repetitive and will likely lead to errors.
22294 The idea is to remove any EmptyCasts that are used in casts that
22295 can be reduced to constants, so we only have to cope with
22298 This bug hunt was triggered by Bug 37363 and the desire to remove
22299 the duplicate pattern where we were "peeling" emptycasts to check
22300 whether they were constants. Now constants will always be
22303 * ecore.cs: Use an enumconstant here instead of wrapping with
22306 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22307 throwing me off. By handling this we can get rid of a few hacks.
22309 * statement.cs (Switch): Removed Peel() code.
22311 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22313 * class.cs: Location information for error 508
22315 * expression.cs (New.DoResolve): Add a guard against double
22316 resolution of an expression.
22318 The New DoResolve might be called twice when initializing field
22319 expressions (see EmitFieldInitializers, the call to
22320 GetInitializerExpression will perform a resolve on the expression,
22321 and later the assign will trigger another resolution
22323 This leads to bugs (#37014)
22325 * delegate.cs: The signature for EndInvoke should contain any ref
22326 or out parameters as well. We were not doing this in the past.
22328 * class.cs (Field.Define): Do not overwrite the type definition
22329 inside the `volatile' group. Turns out that volatile enumerations
22330 were changing the type here to perform a validity test, which
22333 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22335 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22336 and structs, we do not want to load the instance variable
22338 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22339 enum_type has to be handled like an object reference (implicit
22340 conversions exists from this to object), but the regular IsClass
22341 and IsValueType tests will never return true for this one.
22343 Also we use TypeManager.IsValueType instead of type.IsValueType,
22344 just for consistency with the rest of the code (this is only
22345 needed if we ever use the construct exposed by test-180.cs inside
22346 corlib, which we dont today).
22348 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22350 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22353 2003-02-09 Martin Baulig <martin@ximian.com>
22355 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22356 (Namespace.DefineNamespaces): New static public method; this is
22357 called when we're compiling with debugging to add all namespaces
22358 to the symbol file.
22360 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22361 pass it to the Namespace's .ctor.
22363 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22364 and MethodBase arguments; pass the namespace ID to the symwriter;
22365 pass the MethodBase instead of the token to the symwriter.
22366 (SymbolWriter.DefineNamespace): New method to add a namespace to
22369 2003-02-09 Martin Baulig <martin@ximian.com>
22371 * symbolwriter.cs: New file. This is a wrapper around
22372 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22373 methods here in near future.
22375 2003-02-09 Martin Baulig <martin@ximian.com>
22377 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22378 ILGenerator.MarkSequencePoint() which are actually used by the
22381 2003-02-09 Martin Baulig <martin@ximian.com>
22383 * location.cs (SourceFile): New public sealed class. This
22384 contains the name and an index which is used in the location's token.
22385 (Location): Reserve an appropriate number of bits in the token for
22386 the source file instead of walking over that list, this gives us a
22387 really huge performance improvement when compiling with debugging.
22389 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22390 `SourceFile' argument instead of a string.
22391 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22392 but don't parse/tokenize here, we need to generate the list of all
22393 source files before we do that.
22394 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22397 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22398 instead of a string.
22400 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22403 2003-02-09 Martin Baulig <martin@ximian.com>
22405 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22406 filename on `#line default'.
22408 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22410 * statement.cs: don't clear the pinned var when the fixed statement
22411 returns from the method (fixes bug#37752).
22413 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22415 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22418 2003-02-07 Martin Baulig <martin@ximian.com>
22420 * driver.cs: Removed the `--debug-args' command line argument.
22422 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22423 automatically by the AsssemblyBuilder.
22424 (CodeGen.InitializeSymbolWriter): We don't need to call any
22425 initialization function on the symbol writer anymore. This method
22426 doesn't take any arguments.
22428 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22430 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22431 from referenced assemblies as well.
22433 2003-02-02 Martin Baulig <martin@ximian.com>
22435 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22437 2003-02-02 Martin Baulig <martin@ximian.com>
22439 * class.cs (Constructor.Emit): Open the symbol writer before
22440 emitting the constructor initializer.
22441 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22442 single-stepping through constructor initializers.
22444 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22446 * class.cs: Handle error 549: do not allow virtual methods in
22449 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22451 * decl.cs: Check access levels when resolving types
22453 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22455 * statement.cs: Add parameters and locals set in catch blocks that might
22456 return to set vector
22458 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22460 * class.cs (Operator): Set the SpecialName flags for operators.
22462 * expression.cs (Invocation.DoResolve): Only block calls to
22463 accessors and operators on SpecialName methods.
22465 (Cast.TryReduce): Handle conversions from char constants.
22468 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22470 * statement.cs: small memory and time optimization in FlowBranching.
22472 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22474 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22475 problem that the last fix but in the other sid (Set).
22477 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22478 access when there is no indexer in the hierarchy.
22480 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22482 * class.cs: Combine some if statements.
22484 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22486 * driver.cs: fixed bug #37187.
22488 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22490 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22491 any indexer, it's needed to build a list with all the indexers in the
22492 hierarchy (AllGetters), else we have problems. Fixes #35653.
22494 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22496 * class.cs (MethodData.Define): It is wrong for an interface
22497 implementation to be static in both cases: explicit and implicit.
22498 We were only handling this in one case.
22500 Improve the if situation there to not have negations.
22502 * class.cs (Field.Define): Turns out that we do not need to check
22503 the unsafe bit on field definition, only on usage. Remove the test.
22505 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22507 * driver.cs: use assembly.Location instead of Codebase (the latest
22508 patch made mcs fail when using MS assemblies).
22510 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22512 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22513 get the path to *corlib.dll.
22515 2003-01-21 Nick Drochak <ndrochak@gol.com>
22519 * typemanager.cs: Remove compiler warnings
22521 2003-01-20 Duncan Mak <duncan@ximian.com>
22523 * AssemblyInfo.cs: Bump the version number to 0.19.
22525 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22527 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22529 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22531 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22533 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22535 * cs-parser.jay: Small fix: we were not comparing the constructor
22536 name correctly. Thanks to Zoltan for the initial pointer.
22538 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22540 * cs-tokenizer.cs: Set file name when specified with #line
22542 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22544 * cs-parser.jay: Only perform the constructor checks here if we
22545 are named like the class; This will help provider a better
22546 error. The constructor path is taken when a type definition is
22547 not found, but most likely the user forgot to add the type, so
22548 report that rather than the constructor error.
22550 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22552 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22555 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22557 * cs-parser.jay: Add cleanup call.
22559 2003-01-13 Duncan Mak <duncan@ximian.com>
22561 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22562 consistent with other methods.
22564 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22566 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22568 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22570 * attribute.cs: only set GuidAttr to true when we have a
22573 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22577 * typemanager.cs: fixes to allow mcs compile corlib with the new
22578 Type.IsSubclassOf fix.
22580 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22582 * expression.cs (LocalVariableReference.DoResolve): Classify a
22583 constant as a value, not as a variable. Also, set the type for
22586 * cs-parser.jay (fixed_statement): take a type instead of a
22587 pointer_type, so we can produce a better error message later.
22589 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22592 (For.DoEmit): Make inifinite loops have a
22593 non-conditional branch back.
22595 (Fixed.DoEmit): First populate the pinned variables, then emit the
22596 statement, then clear the variables. Before I was emitting the
22597 code once for each fixed piece.
22600 2003-01-08 Martin Baulig <martin@ximian.com>
22602 * statement.cs (FlowBranching.MergeChild): A break in a
22603 SWITCH_SECTION does not leave a loop. Fixes #36155.
22605 2003-01-08 Martin Baulig <martin@ximian.com>
22607 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22608 lives in the same number space than `param_map'. Fixes #36154.
22610 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22612 * cs-parser.jay (constructor_declaration): Set the
22613 Constructor.ModFlags before probing for it. This makes the
22614 compiler report 514, 515 and 132 (the code was there, but got
22617 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22618 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22619 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22621 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22623 * enum.cs: create the enum static fields using the enum type.
22625 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22627 * class.cs: don't try to create the ParamBuilder for the return
22628 type if it's not needed (and handle it breaking for the ms runtime
22631 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22633 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22635 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22637 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22638 the command. This showed up while compiling the JANET source
22639 code, which used \r as its only newline separator.
22641 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22643 * class.cs (Method.Define): If we are an operator (because it
22644 reuses our code), then set the SpecialName and HideBySig. #36128
22646 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22648 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22649 exception, report error 120 `object reference required'.
22651 * driver.cs: Add --pause option, used during to measure the size
22652 of the process as it goes with --timestamp.
22654 * expression.cs (Invocation.DoResolve): Do not allow methods with
22655 SpecialName to be invoked.
22657 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22659 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22660 number before adding it.
22662 2002-12-21 Ravi Pratap <ravi@ximian.com>
22664 * ecore.cs (StandardImplicitConversion): When in an unsafe
22665 context, we allow conversion between void * to any other pointer
22666 type. This fixes bug #35973.
22668 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22670 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22671 is not thrown when extensionless outputs are used
22673 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22675 * rootcontext.cs: fixed compilation of corlib.
22677 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22679 * attribute.cs (Attributes.Contains): Add new method.
22681 * class.cs (MethodCore.LabelParameters): if the parameter is an
22682 `out' parameter, check that no attribute `[In]' has been passed.
22684 * enum.cs: Handle the `value__' name in an enumeration.
22686 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22688 * decl.cs: Added special case to allow overrides on "protected
22691 2002-12-18 Ravi Pratap <ravi@ximian.com>
22693 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22694 since it makes much more sense.
22696 (Attributes.ctor): Don't require a Location parameter.
22698 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22700 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22701 since we already have that information per attribute.
22703 * everywhere : make appropriate changes.
22705 * class.cs (LabelParameters): Write the code which actually
22706 applies attributes to the return type. We can't do this on the MS
22707 .NET runtime so we flag a warning in the case an exception is
22710 2002-12-18 Miguel de Icaza <miguel@ximian.com>
22712 * const.cs: Handle implicit null conversions here too.
22714 2002-12-17 Ravi Pratap <ravi@ximian.com>
22716 * class.cs (MethodCore.LabelParameters): Remove the extra
22717 Type [] parameter since it is completely unnecessary. Instead
22718 pass in the method's attributes so that we can extract
22719 the "return" attribute.
22721 2002-12-17 Miguel de Icaza <miguel@ximian.com>
22723 * cs-parser.jay (parse): Use Report.Error to flag errors instead
22724 of ignoring it and letting the compile continue.
22726 * typemanager.cs (ChangeType): use an extra argument to return an
22727 error condition instead of throwing an exception.
22729 2002-12-15 Miguel de Icaza <miguel@ximian.com>
22731 * expression.cs (Unary.TryReduce): mimic the code for the regular
22732 code path. Perform an implicit cast in the cases where we can
22733 implicitly convert to one of the integral types, and then reduce
22734 based on that constant. This fixes bug #35483.
22736 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22738 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
22740 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22742 * namespace.cs: fixed bug #35489.
22744 2002-12-12 Miguel de Icaza <miguel@ximian.com>
22746 * class.cs: Remove some dead code.
22748 * cs-parser.jay: Estimate the number of methods needed
22749 (RootContext.MethodCount);
22751 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
22752 numbers instead of StringBuilders.
22754 * support.cs (PtrHashtable): Add constructor with initial size;
22755 We can now reduce reallocations of the method table.
22757 2002-12-10 Ravi Pratap <ravi@ximian.com>
22759 * attribute.cs (ApplyAttributes): Keep track of the emitted
22760 attributes on a per-target basis. This fixes bug #35413.
22762 2002-12-10 Miguel de Icaza <miguel@ximian.com>
22764 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
22765 default to the Windows 1252 encoding.
22767 (UnixParseOption): Support version, thanks to Alp for the missing
22770 * AssemblyInfo.cs: Add nice assembly information.
22772 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
22775 * cs-parser.jay: Allow a trailing comma before the close bracked
22776 in the attribute_section production.
22778 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
22779 address of the instance was being taken, I will take this out,
22780 because we take the address of the object immediately here.
22782 2002-12-09 Ravi Pratap <ravi@ximian.com>
22784 * typemanager.cs (AreMultipleAllowed): Take care of the most
22785 obvious case where attribute type is not in the current assembly -
22788 2002-12-08 Miguel de Icaza <miguel@ximian.com>
22790 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
22791 definitions, instead of doing that afterwards.
22793 Also we use a nice little hack, depending on the constructor, we
22794 know if we are a "composed" name or a simple name. Hence, we
22795 avoid the IndexOf test, and we avoid
22797 * codegen.cs: Add code to assist in a bug reporter to track down
22798 the source of a compiler crash.
22800 2002-12-07 Ravi Pratap <ravi@ximian.com>
22802 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
22803 types have been emitted for a given element and flag an error
22804 if something which does not have AllowMultiple set is used more
22807 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
22808 attribute types and their corresponding AllowMultiple properties
22810 (AreMultipleAllowed): Check the property for a given type.
22812 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
22813 property in the case we have a TypeContainer.
22815 (Attributes.AddAttribute): Detect duplicates and just skip on
22816 adding them. This trivial fix catches a pretty gross error in our
22817 attribute emission - global attributes were being emitted twice!
22819 Bugzilla bug #33187 is now fixed.
22821 2002-12-06 Miguel de Icaza <miguel@ximian.com>
22823 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
22824 instead of pp_and).
22826 * expression.cs (Binary.ResolveOperator): I can only use the
22827 Concat (string, string, string) and Concat (string, string,
22828 string, string) if the child is actually a concatenation of
22831 2002-12-04 Miguel de Icaza <miguel@ximian.com>
22833 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
22834 context where we need a 2-character lookahead.
22836 * pending.cs (PendingImplementation): Rework so we can keep track
22837 of interface types all the time, and flag those which were
22838 implemented by parents as optional.
22840 2002-12-03 Miguel de Icaza <miguel@ximian.com>
22842 * expression.cs (Binary.ResolveOperator): Use
22843 String.Concat(string,string,string) or
22844 String.Concat(string,string,string,string) when possible.
22846 * typemanager: More helper methods.
22849 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
22851 * pending.cs: remove the bogus return from GetMissingInterfaces()
22852 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
22854 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22856 * namespace.cs: avoid duplicated 'using xxx' being added to
22857 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
22858 when we get more than one 'using' statement for the same namespace.
22859 Report a CS0105 warning for it.
22861 2002-11-30 Miguel de Icaza <miguel@ximian.com>
22863 * cs-tokenizer.cs (consume_identifier): use read directly, instead
22864 of calling getChar/putback, uses internal knowledge of it.
22866 (xtoken): Reorder tokenizer so most common patterns are checked
22867 first. This reduces the compilation time in another 5% (from 8.11s
22868 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
22870 The parsing time is 22% of the compilation in mcs, and from that
22871 64% is spent on the tokenization process.
22873 I tried using a binary search for keywords, but this is slower
22874 than the hashtable. Another option would be to do a couple of
22877 * Not use a StringBuilder, instead use an array of chars,
22878 with a set value. Notice that this way we could catch
22879 the 645 error without having to do it *afterwards*.
22881 * We could write a hand-parser to avoid the hashtable
22882 compares altogether.
22884 The identifier consumption process takes 37% of the tokenization
22885 time. Another 15% is spent on is_number. 56% of the time spent
22886 on is_number is spent on Int64.Parse:
22888 * We could probably choose based on the string length to
22889 use Int32.Parse or Int64.Parse and avoid all the 64-bit
22892 Another 3% is spend on wrapping `xtoken' in the `token' function.
22894 Handle 0xa0 as whitespace (#34752)
22896 2002-11-26 Miguel de Icaza <miguel@ximian.com>
22898 * typemanager.cs (IsCLRType): New routine to tell whether a type
22899 is one of the builtin types.
22901 Maybe it needs to use TypeCodes to be faster. Maybe we could use
22902 typecode in more places instead of doing pointer comparissions.
22903 We could leverage some knowledge about the way the typecodes are
22906 New code to cache namespaces in assemblies, it is currently not
22907 invoked, to be used soon.
22909 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
22911 * expression.cs (Binary.ResolveOperator): specially handle
22912 strings, and do not perform user-defined operator overloading for
22915 2002-11-24 Miguel de Icaza <miguel@ximian.com>
22917 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
22918 internalcall as it is a pretty simple operation; Avoid whenever
22919 possible to call Char.IsLetter.
22921 (consume_identifier): Cut by half the number of
22922 hashtable calls by merging the is_keyword and GetKeyword behavior.
22924 Do not short-circuit, because if we do, we
22925 report errors (ie, #if false && true would produce an invalid
22929 2002-11-24 Martin Baulig <martin@ximian.com>
22931 * expression.cs (Cast.TryReduce): If we're in checked syntax,
22932 check constant ranges and report a CS0221. Fixes #33186.
22934 2002-11-24 Martin Baulig <martin@ximian.com>
22936 * cs-parser.jay: Make this work for uninitialized variable
22937 declarations in the `for' initializer. Fixes #32416.
22939 2002-11-24 Martin Baulig <martin@ximian.com>
22941 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
22942 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
22944 2002-11-24 Martin Baulig <martin@ximian.com>
22946 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
22947 argument; if true, we also check for user-defined conversions.
22948 This is only needed if both arguments are of a user-defined type.
22949 Fixes #30443, added test-175.cs.
22950 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
22952 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
22954 2002-11-24 Martin Baulig <martin@ximian.com>
22956 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
22957 function to get the store opcode.
22958 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
22959 only emit the Ldelema if the store opcode is Stobj. You must run
22960 both test-34 and test-167 to test this. Fixes #34529.
22962 2002-11-23 Martin Baulig <martin@ximian.com>
22964 * ecore.cs (Expression.MemberLookup): Added additional
22965 `qualifier_type' argument which is used when we're being called
22966 from MemberAccess.DoResolve() and null if we're called from a
22968 (Expression.MemberLookupFailed): New method to report errors; this
22969 does the CS1540 check and reports the correct error message.
22971 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
22972 argument for the CS1540 check and redone the way how we're dealing
22973 with private members. See the comment in the source code for details.
22974 (FilterWithClosure): Reverted this back to revision 1.197; renamed
22975 `closure_start_type' to `closure_qualifier_type' and check whether
22976 it's not null. It was not this filter being broken, it was just
22977 being called with the wrong arguments.
22979 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
22980 and pass it the correct `qualifier_type'; this also does the error
22983 2002-11-22 Miguel de Icaza <miguel@ximian.com>
22985 * expression.cs (Invocation.EmitParams): If the we are dealing
22986 with a non-built-in value type, load its address as well.
22988 (ArrayCreation): Use a a pretty constant instead
22989 of the hardcoded value 2. Use 6 instead of 2 for the number of
22990 static initializers.
22992 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
22993 because they are not really value types, just glorified integers.
22995 * driver.cs: Do not append .exe, the CSC compiler does not do it.
22997 * ecore.cs: Remove redundant code for enumerations, make them use
22998 the same code path as everything else, fixes the casting issue
22999 with enumerations in Windows.Forms.
23001 * attribute.cs: Do only cast to string if it is a string, the
23002 validation happens later.
23004 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23005 people upgrade their corlibs.
23007 * ecore.cs: Oops, enumerations were not following the entire code path
23009 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23011 * typemanager.cs (FilterWithClosure): Commented out the test for
23012 1540 in typemanager.cs, as it has problems when accessing
23013 protected methods from a parent class (see test-174.cs).
23015 * attribute.cs (Attribute.ValidateGuid): new method.
23016 (Attribute.Resolve): Use above.
23018 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23020 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23022 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23023 handling for enumerations, as we only needed the TypeContainer
23024 functionality to begin with (this is required for the fix below to
23025 work for enums that reference constants in a container class for
23028 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23030 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23031 a valid TypeBuilder to perform lookups on.o
23033 * class.cs (InheritableMemberSignatureCompare): Use true in the
23034 call to GetGetMethod and GetSetMethod, because we are comparing
23035 the signature, and we need to get the methods *even* if they are
23038 (PropertyBase.CheckBase): ditto.
23040 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23041 GotoCase.Resolve): Use Peel on EmpytCasts.
23043 * ecore.cs (EmptyCast): drop child, add Peel method.
23045 2002-11-17 Martin Baulig <martin@ximian.com>
23047 * ecore.cs (EmptyCast.Child): New public property.
23049 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23050 label resolved to an EmptyCast. Fixes #34162.
23051 (GotoCase.Resolve): Likewise.
23052 (Block.EmitMeta): Likewise.
23054 2002-11-17 Martin Baulig <martin@ximian.com>
23056 * expression.cs (Invocation.BetterConversion): Prefer int over
23057 uint; short over ushort; long over ulong for integer literals.
23058 Use ImplicitConversionExists instead of StandardConversionExists
23059 since we also need to check for user-defined implicit conversions.
23060 Fixes #34165. Added test-173.cs.
23062 2002-11-16 Martin Baulig <martin@ximian.com>
23064 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23065 with the `true' and `false' literals. Fixes #33151.
23067 2002-11-16 Martin Baulig <martin@ximian.com>
23069 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23070 October 22nd; don't do the cs1540 check for static members.
23072 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23073 now using our own filter here and doing the cs1540 check again.
23075 2002-11-16 Martin Baulig <martin@ximian.com>
23077 * support.cs (InternalParameters): Don't crash if we don't have
23078 any fixed parameters. Fixes #33532.
23080 2002-11-16 Martin Baulig <martin@ximian.com>
23082 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23083 when looking up static methods to make this work on Windows.
23086 2002-11-16 Martin Baulig <martin@ximian.com>
23088 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23089 a setter rather than using PropertyInfo.CanWrite.
23091 2002-11-15 Nick Drochak <ndrochak@gol.com>
23093 * class.cs: Allow acces to block member by subclasses. Fixes build
23096 2002-11-14 Martin Baulig <martin@ximian.com>
23098 * class.cs (Constructor.Emit): Added the extern/block check.
23101 2002-11-14 Martin Baulig <martin@ximian.com>
23103 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23104 iteration while looking for indexers, this is needed because the
23105 indexer may have a different name in our base classes. Fixed the
23106 error reporting (no indexers at all, not get accessor, no
23107 overloaded match). Fixes bug #33089.
23108 (IndexerAccess.DoResolveLValue): Likewise.
23110 2002-11-14 Martin Baulig <martin@ximian.com>
23112 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23113 indexers. Fixes the first part of bug #33089.
23114 (MethodSignature.InheritableMemberSignatureCompare): Added support
23117 2002-11-13 Ravi Pratap <ravi@ximian.com>
23119 * attribute.cs (Attribute.Resolve): Catch the
23120 NullReferenceException and report it since it isn't supposed to
23123 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23125 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23126 LogicalOr and LogicalAnd that can benefit from recursively
23127 handling EmitBranchable. The code now should be nice for Paolo.
23129 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23131 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23132 the Type lookups, as we perform quite a number of lookups on
23133 non-Types. This can be removed once we can deterministically tell
23134 whether we have a type or a namespace in advance.
23136 But this might require special hacks from our corlib.
23140 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23141 and double which avoids a conversion from an integer to a double.
23143 * expression.cs: tiny optimization, avoid calling IsConstant,
23144 because it effectively performs the lookup twice.
23146 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23148 But a bogus return here to keep the semantics of the old code
23149 until the Mono runtime is fixed.
23151 * pending.cs (GetMissingInterfaces): New method used to remove all
23152 the interfaces that are already implemented by our parent
23153 classes from the list of pending methods.
23155 * interface.cs: Add checks for calls after ResolveTypeExpr.
23157 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23159 * class.cs (Class.Emit): Report warning 67: event not used if the
23160 warning level is beyond 3.
23162 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23163 being a NullLiteral.
23165 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23168 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23169 path that might fail if a type can not be resolved.
23171 * expression.cs (Binary.Emit): Emit unsigned versions of the
23174 * driver.cs: use error 5.
23176 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23178 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23180 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23182 * cs-parser.jay (switch_section): A beautiful patch from Martin
23183 Baulig that fixed 33094.
23185 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23187 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23188 Check whether the base is abstract and report an error if so.
23190 * expression.cs (IndexerAccess.DoResolveLValue,
23191 IndexerAccess.DoResolve): ditto.
23193 (Invocation.DoResolve): ditto.
23195 (Invocation.FullMethodDesc): Improve the report string.
23197 * statement.cs (Block): Eliminate IsVariableDefined as it is
23198 basically just a wrapper for GetVariableInfo.
23200 * ecore.cs (SimpleName): Use new
23202 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23203 type, as we return the actual parameter ref/unref state on a
23206 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23208 * support.cs: Return proper flags REF/OUT fixing the previous
23211 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23212 not used to mean `ref' but `ref or out' in ParameterReference
23214 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23215 full type signature instead of calling TypeManger.CSharpName
23218 * support.cs (InternalParameters.ParameterDesc): Do not compare
23219 directly to the modflags, because REF/OUT will actually be bitsets
23222 * delegate.cs (VerifyMethod): Check also the modifiers.
23224 * cs-tokenizer.cs: Fix bug where floating point values with an
23225 exponent where a sign was missing was ignored.
23227 * driver.cs: Allow multiple assemblies to be specified in a single
23230 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23232 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23233 because identifiers after a parenthesis would end up in this kind
23234 of production, and we needed to desamiguate it for having casts
23237 (UserDefinedType *) xxx
23239 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23241 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23242 we should set on the Bindingflags.NonPublic, but not turn on
23243 private_ok. private_ok controls whether a Private member is
23244 returned (this is chekced on the filter routine), while the
23245 BindingFlags.NonPublic just controls whether private/protected
23246 will be allowed. This fixes the problem part of the problem of
23247 private properties being allowed to be used in derived classes.
23249 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23250 so we can call the children DoResolveLValue method (this will
23251 properly signal errors on lvalue assignments to base properties)
23253 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23254 getter are null, and we have a property info, we know that this
23255 happened because the lookup failed, so we report an error 122 for
23256 protection level violation.
23258 We also silently return if setter and getter are null in the
23259 resolve functions, this condition only happens if we have flagged
23260 the error before. This is the other half of the problem.
23262 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23263 not have accessibility information, that is why we were returning
23264 true in the filter function in typemanager.cs.
23266 To properly report 122 (property is inaccessible because of its
23267 protection level) correctly, we report this error in ResolveAccess
23268 by failing if both the setter and the getter are lacking (ie, the
23271 DoResolve and DoLResolve have been modified to check for both
23272 setter/getter being null and returning silently, the reason being
23273 that I did not want to put the knowledge about this error in upper
23276 int old = Report.Errors;
23277 x = new PropertyExpr (...);
23278 if (old != Report.Errors)
23283 So the property expr is returned, but it is invalid, so the error
23284 will be flagged during the resolve process.
23286 * class.cs: Remove InheritablePropertySignatureCompare from the
23287 class, as we no longer depend on the property signature to compute
23288 whether it is possible to implement a method or not.
23290 The reason is that calling PropertyInfo.GetGetMethod will return
23291 null (in .NET, in Mono it works, and we should change this), in
23292 cases where the Get Method does not exist in that particular
23297 class X { public virtual int A { get { return 1; } } }
23299 class Z : Y { public override int A { get { return 2; } } }
23301 Would fail in Z because the parent (Y) would not have the property
23302 defined. So we avoid this completely now (because the alternative
23303 fix was ugly and slow), and we now depend exclusively on the
23306 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23307 reference method, instead of using the property.
23309 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23310 routines are gone now.
23312 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23313 names, they were incorrectly named.
23315 * cs-tokenizer.cs: Return are more gentle token on failure.
23317 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23318 had an out-of-sync index variable, which caused it to remove from
23319 the list of pending methods the wrong method sometimes.
23321 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23323 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23324 CanWrite, because those refer to this particular instance of the
23325 property, and do not take into account the fact that we can
23326 override single members of a property.
23328 Constructor requires an EmitContext. The resolution process does
23329 not happen here, but we need to compute the accessors before,
23330 because the resolution does not always happen for properties.
23332 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23333 subclass, before we did not update this flag, but we did update
23336 (GetAccessors): Drop this routine, as it did not work in the
23337 presence of partially overwritten set/get methods.
23339 Notice that this broke the cs1540 detection, but that will require
23342 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23346 * driver.cs: issue a warning instead of an error if we don't support
23347 debugging for the platform. Also ignore a couple of errors that may
23348 arise when trying to write the symbols. Undo my previous patch.
23350 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23352 * driver.cs: ignore /debug switch except for Unix platforms.
23354 2002-10-23 Nick Drochak <ndrochak@gol.com>
23356 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23358 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23360 * driver.cs: Do not make mcs-debug conditional, so we do not break
23361 builds that use it.
23363 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23364 review this patch. But basically after all the children variables
23365 have been merged, the value of "Breaks" was not being set to
23366 new_breaks for Switch blocks. I think that it should be set after
23367 it has executed. Currently I set this to the value of new_breaks,
23368 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23369 conservative, but I do not understand this code very well.
23371 I did not break anything in the build, so that is good ;-)
23373 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23375 2002-10-20 Mark Crichton <crichton@gimp.org>
23377 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23379 2002-10-20 Nick Drochak <ndrochak@gol.com>
23381 * cfold.cs: Fixed compile blocker.
23383 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23385 * driver.cs: I was chekcing the key, not the file.
23387 2002-10-19 Ravi Pratap <ravi@ximian.com>
23389 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23390 message that we were generating - we just need to silently return
23393 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23395 * class.cs (Event.Define): Change my previous commit, as this
23396 breaks the debugger. This is a temporary hack, as it seems like
23397 the compiler is generating events incorrectly to begin with.
23399 * expression.cs (Binary.ResolveOperator): Added support for
23400 "U operator - (E x, E y)"
23402 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23405 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23406 init-only variables, but this path did not take into account that
23407 there might be also instance readonly variables. Correct this
23410 This fixes bug 32253
23412 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23415 * driver.cs: Change the extension for modules to `netmodule'
23417 * cs-parser.jay: Improved slightly the location tracking for
23418 the debugger symbols.
23420 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23421 modifiers that were specified instead of the hardcoded value
23422 (FamAndAssem). This was basically ignoring the static modifier,
23423 and others. Fixes 32429.
23425 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23426 fixed a bug in the process (32476)
23428 * expression.cs (ArrayAccess.EmitAssign): Patch from
23429 hwang_rob@yahoo.ca that fixes bug 31834.3
23431 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23433 * driver.cs: Make the module extension .netmodule.
23435 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23437 * driver.cs: Report an error if the resource file is not found
23438 instead of crashing.
23440 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23441 false, like Emit does.
23443 2002-10-16 Nick Drochak <ndrochak@gol.com>
23445 * typemanager.cs: Remove unused private member. Also reported mcs
23446 bug to report this as a warning like csc.
23448 2002-10-15 Martin Baulig <martin@gnome.org>
23450 * statement.cs (Statement.Emit): Made this a virtual method; emits
23451 the line number info and calls DoEmit().
23452 (Statement.DoEmit): New protected abstract method, formerly knows
23453 as Statement.Emit().
23455 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23457 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23459 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23460 have fixed a remaining problem: not every AddXXXX was adding a
23461 fully qualified name.
23463 Now everyone registers a fully qualified name in the DeclSpace as
23464 being defined instead of the partial name.
23466 Downsides: we are slower than we need to be due to the excess
23467 copies and the names being registered this way.
23469 The reason for this is that we currently depend (on the corlib
23470 bootstrap for instance) that types are fully qualified, because
23471 we dump all the types in the namespace, and we should really have
23472 types inserted into the proper namespace, so we can only store the
23473 basenames in the defined_names array.
23475 2002-10-10 Martin Baulig <martin@gnome.org>
23477 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23478 from bug #31834, see the bug report for a testcase which is
23481 2002-10-10 Martin Baulig <martin@gnome.org>
23483 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23484 flow analysis code for this.
23486 * statement.cs (Do, While, For): Tell the flow analysis code about
23488 (FlowBranching.UsageVector): Added support for infinite loops.
23489 (Block.Resolve): Moved the dead code elimination here and use flow
23492 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23494 * class.cs (Field.Define): Catch cycles on struct type
23497 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23498 fields if the fields are static. We only need to check instance
23501 * expression.cs (As.DoResolve): Test for reference type.
23503 * statement.cs (Using.ResolveExpression): Use
23504 ConvertImplicitRequired, not ConvertImplicit which reports an
23506 (Using.ResolveLocalVariableDecls): ditto.
23508 * expression.cs (Binary.ResolveOperator): Report errors in a few
23509 places where we had to.
23511 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23513 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23515 * expression.cs: Use StoreFromPtr instead of extracting the type
23516 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23518 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23519 an enumeration value to a System.Enum, but System.Enum is not a
23520 value type, but an class type, so we need to box.
23522 (Expression.ConvertExplicit): One codepath could return
23523 errors but not flag them. Fix this. Fixes #31853
23525 * parameter.cs (Resolve): Do not allow void as a parameter type.
23527 2002-10-06 Martin Baulig <martin@gnome.org>
23529 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23530 if it's a class type and not a struct. Fixes #31815.
23532 2002-10-06 Martin Baulig <martin@gnome.org>
23534 * statement.cs: Reworked the flow analysis code a bit to make it
23535 usable for dead code elimination.
23537 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23539 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23541 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23543 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23544 to fix the test 165, will investigate deeper.
23546 2002-10-04 Martin Baulig <martin@gnome.org>
23548 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23549 finally blocks actually work.
23550 (Try.Resolve): We don't need to create a sibling for `finally' if
23551 there is no finally block.
23553 2002-10-04 Martin Baulig <martin@gnome.org>
23555 * class.cs (Constructor.Define): The default accessibility for a
23556 non-default constructor is private, not public.
23558 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23560 * class.cs (Constructor): Make AllowedModifiers public, add
23563 * cs-parser.jay: Perform the modifiers test here, as the
23564 constructor for the Constructor class usually receives a zero
23565 because of the way we create it (first we create, later we
23566 customize, and we were never checking the modifiers).
23568 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23569 is a version of LookupTypeReflection that includes the type-name
23570 cache. This can be used as a fast path for functions that know
23571 the fully qualified name and are only calling into *.GetType() to
23572 obtain a composed type.
23574 This is also used by TypeManager.LookupType during its type
23577 (LookupType): We now also track the real type name, as sometimes
23578 we can get a quey for the real type name from things like
23579 ComposedCast. This fixes bug 31422.
23581 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23582 complete type fullname, it does not have to go through the type
23583 resolution system to obtain the composed version of the type (for
23584 obtaining arrays or pointers).
23586 (Conditional.Emit): Use the EmitBoolExpression to
23587 generate nicer code, as requested by Paolo.
23589 (ArrayCreation.CheckIndices): Use the patch from
23590 hwang_rob@yahoo.ca to validate the array initializers.
23592 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23594 * class.cs (ConstructorInitializer.Emit): simplify code by using
23595 Invocation.EmitCall, and at the same time, fix the bugs in calling
23596 parent constructors that took variable arguments.
23598 * ecore.cs (Expression.ConvertNumericExplicit,
23599 Expression.ImplicitNumericConversion): Remove the code that
23600 manually wrapped decimal (InternalTypeConstructor call is now gone
23603 * expression.cs (Cast.TryReduce): Also handle decimal types when
23604 trying to perform a constant fold on the type.
23606 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23608 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23609 that only turned off an error report, and did nothing else.
23611 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23613 * driver.cs: Handle and ignore /fullpaths
23615 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23617 * expression.cs (Binary.ResolveOperator): Catch the case where
23618 DoNumericPromotions returns true,
23620 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23622 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23624 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23627 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23629 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23630 conversion exists, but it is also required that the conversion be
23631 performed. This manifested in "(Type64Enum) 2".
23633 * class.cs (TypeManager.AddMethod): The fix is not to change
23634 AddEnum, because that one was using a fully qualified name (every
23635 DeclSpace derivative does), but to change the AddMethod routine
23636 that was using an un-namespaced name. This now correctly reports
23637 the duplicated name.
23639 Revert patch until I can properly fix it. The issue
23640 is that we have a shared Type space across all namespaces
23641 currently, which is wrong.
23643 Options include making the Namespace a DeclSpace, and merge
23644 current_namespace/current_container in the parser.
23646 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23648 * cs-parser.jay: Improve error reporting when we get a different
23649 kind of expression in local_variable_type and
23650 local_variable_pointer_type.
23652 Propagate this to avoid missleading errors being reported.
23654 * ecore.cs (ImplicitReferenceConversion): treat
23655 TypeManager.value_type as a target just like object_type. As
23660 Is valid, and needs to result in the int 1 being boxed before it
23661 is assigned to the value type v.
23663 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23664 to validate the enumeration name.
23666 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23667 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23668 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23670 * ecore.cs (TryImplicitIntConversion): When doing an
23671 implicit-enumeration-conversion, check if the type is 64-bits and
23672 perform a conversion before passing to EnumConstant.
23674 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23676 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23677 report ambiguous type references. Unlike the MS version, we
23678 report what the ambiguity is. Innovation at work ;-)
23680 (DeclSpace.FindType): Require a location argument to
23681 display when we display an ambiguous error.
23683 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23685 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23687 * expression.cs (EmitDynamicInitializers): Apply patch from
23688 hwang_rob@yahoo.ca that fixes the order in which we emit our
23691 2002-09-21 Martin Baulig <martin@gnome.org>
23693 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23694 delegate takes no arguments.
23696 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23698 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23701 * expression.cs: Extract the underlying type.
23703 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
23705 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
23707 2002-09-19 Miguel de Icaza <miguel@ximian.com>
23709 * class.cs (TypeContainer.DefineType): We can not use the nice
23710 PackingSize with the size set to 1 DefineType method, because it
23711 will not allow us to define the interfaces that the struct
23714 This completes the fixing of bug 27287
23716 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
23717 means also structs. This fixes part of the problem.
23718 (Expresion.ImplicitReferenceConversionExists): ditto.
23720 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
23721 error if there were no errors reported during the type lookup
23722 process, to avoid duplicates or redundant errors. Without this
23723 you would get an ambiguous errors plus a type not found. We have
23724 beaten the user enough with the first error.
23726 (DeclSparce.FindType): Emit a warning if we have an ambiguous
23729 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
23730 during the resolution process, stop the lookup, this avoids
23731 repeated error reports (same error twice).
23733 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
23735 * typemanager.cs (LookupType): Redo the type lookup code to match
23736 the needs of System.Reflection.
23738 The issue is that System.Reflection requires references to nested
23739 types to begin with a "+" sign instead of a dot. So toplevel
23740 types look like: "NameSpace.TopLevelClass", and nested ones look
23741 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
23744 2002-09-19 Martin Baulig <martin@gnome.org>
23746 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
23747 says that a method always returns or always throws an exception,
23748 don't report the CS0161.
23750 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
23751 set `Returns = new_returns'.
23753 2002-09-19 Martin Baulig <martin@gnome.org>
23755 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
23756 to an enum constant, check for a CS0176.
23758 2002-09-18 Miguel de Icaza <miguel@ximian.com>
23760 * class.cs (TypeContainer.CheckPairedOperators): Now we check
23761 for operators that must be in pairs and report errors.
23763 * ecore.cs (SimpleName.DoResolveType): During the initial type
23764 resolution process, when we define types recursively, we must
23765 check first for types in our current scope before we perform
23766 lookups in the enclosing scopes.
23768 * expression.cs (MakeByteBlob): Handle Decimal blobs.
23770 (Invocation.VerifyArgumentsCompat): Call
23771 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
23772 I thought we were supposed to always call this, but there are a
23773 few places in the code where we dont do it.
23775 2002-09-17 Miguel de Icaza <miguel@ximian.com>
23777 * driver.cs: Add support in -linkres and -resource to specify the
23778 name of the identifier.
23780 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23782 * ecore.cs (StandardConversionExists): Sync with the conversion
23783 code: allow anything-* to void* conversions.
23785 (FindMostSpecificSource): Use an Expression argument
23786 instead of a Type, because we might be handed over a Literal which
23787 gets a few more implicit conversions that plain types do not. So
23788 this information was being lost.
23790 Also, we drop the temporary type-holder expression when not
23793 2002-09-17 Martin Baulig <martin@gnome.org>
23795 * class.cs (PropertyBase.CheckBase): Don't check the base class if
23796 this is an explicit interface implementation.
23798 2002-09-17 Martin Baulig <martin@gnome.org>
23800 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
23801 different `IndexerName' attributes.
23803 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
23804 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
23805 virtual CommonResolve().
23807 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23809 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
23810 and convert that to the UnderlyingType.
23812 * statement.cs (Foreach.Resolve): Indexers are just like variables
23813 or PropertyAccesses.
23815 * cs-tokenizer.cs (consume_string): Track line numbers and columns
23816 inside quoted strings, we were not doing this before.
23818 2002-09-16 Martin Baulig <martin@gnome.org>
23820 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
23821 resolve it. This is needed for the definite assignment check of the
23822 instance expression, fixes bug #29846.
23823 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
23825 2002-09-16 Nick Drochak <ndrochak@gol.com>
23827 * parameter.cs: Fix compile error. Cannot reference static member
23828 from an instance object. Is this an mcs bug?
23830 2002-09-14 Martin Baulig <martin@gnome.org>
23832 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
23833 multiple times. Fixes bug #30295, added test-166.cs.
23835 2002-09-14 Martin Baulig <martin@gnome.org>
23837 * statement.cs (Block.Emit): Don't emit unreachable code.
23838 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
23839 `break' statements.
23840 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
23842 2002-09-14 Martin Baulig <martin@gnome.org>
23844 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
23847 2002-09-14 Martin Baulig <martin@gnome.org>
23849 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
23850 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
23851 be false on the ms runtime.
23853 2002-09-13 Martin Baulig <martin@gnome.org>
23855 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
23856 the CS0038 error message.
23858 2002-09-12 Miguel de Icaza <miguel@ximian.com>
23860 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
23861 constant inside, return it.
23863 2002-09-12 Martin Baulig <martin@gnome.org>
23865 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
23866 implicit conversion can be done between enum types.
23868 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
23869 check whether an implicit conversion to the current enum's UnderlyingType
23870 exists and report an error if not.
23872 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
23873 without debugging support.
23875 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
23876 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
23878 2002-09-12 Martin Baulig <martin@gnome.org>
23880 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
23882 * ecore.cs (IMemberExpr.DeclaringType): New property.
23883 (SimpleName.SimpleNameResolve): Check whether we're accessing a
23884 nonstatic member of an outer type (CS0038).
23886 2002-09-11 Miguel de Icaza <miguel@ximian.com>
23888 * driver.cs: Activate the using-error detector at warning level
23889 4 (at least for MS-compatible APIs).
23891 * namespace.cs (VerifyUsing): Small buglett fix.
23893 * pending.cs (PendingImplementation): pass the container pointer.
23895 * interface.cs (GetMethods): Allow for recursive definition. Long
23896 term, I would like to move every type to support recursive
23897 definitions, not the current ordering mechanism that we have right
23900 The situation is this: Attributes are handled before interfaces,
23901 so we can apply attributes to interfaces. But some attributes
23902 implement interfaces, we will now handle the simple cases
23903 (recursive definitions will just get an error).
23905 * parameter.cs: Only invalidate types at the end if we fail to
23908 2002-09-09 Martin Baulig <martin@gnome.org>
23910 * ecore.cs (PropertyExpr.Emit): Also check for
23911 TypeManager.system_int_array_get_length so this'll also work when
23912 compiling corlib. Fixes #30003.
23914 2002-09-09 Martin Baulig <martin@gnome.org>
23916 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
23917 and throw an exception if we can't get the type's size. Fixed #30040,
23920 2002-09-09 Martin Baulig <martin@gnome.org>
23922 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
23924 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
23925 context. Fixes bug #30027.
23927 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
23928 virtual functions. Fixes bug #30043, added test-164.cs.
23930 2002-09-08 Ravi Pratap <ravi@ximian.com>
23932 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
23934 2002-09-08 Nick Drochak <ndrochak@gol.com>
23936 * driver.cs: Use an object to get the windows codepage since it's not a
23939 2002-09-08 Miguel de Icaza <miguel@ximian.com>
23941 * statement.cs (For.Emit): for infinite loops (test == null)
23942 return whether there is a break inside, not always "true".
23944 * namespace.cs (UsingEntry): New struct to hold the name of the
23945 using definition, the location where it is defined, and whether it
23946 has been used in a successful type lookup.
23948 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
23953 2002-09-06 Ravi Pratap <ravi@ximian.com>
23955 * attribute.cs : Fix incorrect code which relied on catching
23956 a NullReferenceException to detect a null being passed in
23957 where an object was expected.
23959 2002-09-06 Miguel de Icaza <miguel@ximian.com>
23961 * statement.cs (Try): flag the catch variable as assigned
23963 * expression.cs (Cast): Simplified by using ResolveType instead of
23964 manually resolving.
23966 * statement.cs (Catch): Fix bug by using ResolveType.
23968 2002-09-06 Ravi Pratap <ravi@ximian.com>
23970 * expression.cs (BetterConversion): Special case for when we have
23971 a NullLiteral as the argument and we have to choose between string
23972 and object types - we choose string the way csc does.
23974 * attribute.cs (Attribute.Resolve): Catch the
23975 NullReferenceException and report error #182 since the Mono
23976 runtime no more has the bug and having this exception raised means
23977 we tried to select a constructor which takes an object and is
23980 2002-09-05 Ravi Pratap <ravi@ximian.com>
23982 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
23983 message (1502, 1503) when we can't locate a method after overload
23984 resolution. This is much more informative and closes the bug
23987 * interface.cs (PopulateMethod): Return if there are no argument
23988 types. Fixes a NullReferenceException bug.
23990 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
23991 expressions too. Previously we were checking only in one place for
23992 positional arguments leaving out named arguments.
23994 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
23995 type to the enum type is not allowed. Remove code corresponding to
23998 (ConvertNumericExplicit): Allow explicit conversions from
23999 the underlying type to enum type. This precisely follows the spec
24000 and closes a bug filed by Gonzalo.
24002 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24005 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24007 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24009 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24010 it was important that we stored the right value after the
24011 reduction in `converted'.
24013 2002-09-04 Martin Baulig <martin@gnome.org>
24015 * location.cs (Location.SymbolDocument): Use full pathnames for the
24018 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24020 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24021 of the expression resolve mechanism, because that will catch the
24022 SimpleName error failures.
24024 (Conditional): If we can not resolve the
24025 expression, return, do not crash.
24027 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24030 (location): display token name instead of its number.
24032 2002-08-28 Martin Baulig <martin@gnome.org>
24034 * expression.cs (Binary.ResolveOperator): Don't silently return
24035 but return an error if an operator cannot be applied between two
24038 2002-08-28 Martin Baulig <martin@gnome.org>
24040 * class.cs (Constructor.Define): Set the permission attributes
24041 correctly instead of making all constructors public.
24043 2002-08-28 Martin Baulig <martin@gnome.org>
24045 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24046 for private members before reporting a CS0103; if we find anything,
24049 2002-08-28 Martin Baulig <martin@gnome.org>
24051 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24052 to check whether `closure_start_type == closure_invocation_type',
24053 we also need to check whether `m.DeclaringType == closure_invocation_type'
24054 before bypassing the permission checks. We might be accessing
24055 protected/private members from the base class.
24056 (TypeManager.RealMemberLookup): Only set private_ok if private
24057 members were requested via BindingFlags.NonPublic.
24059 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24061 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24062 MethodGroupExpr.IsExplicitImpl if appropriate.
24063 (Invocation.DoResolve): Don't report the CS0120 for explicit
24064 interface implementations.
24066 2002-08-27 Martin Baulig <martin@gnome.org>
24068 * expression.cs (Invocation.DoResolve): If this is a static
24069 method and we don't have an InstanceExpression, we must report
24072 2002-08-25 Martin Baulig <martin@gnome.org>
24074 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24075 `==' between a valuetype and an object.
24077 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24079 * ecore.cs (TypeExpr): Provide a ToString method.
24081 2002-08-24 Martin Baulig <martin@gnome.org>
24083 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24084 now called proggie.dbg and it's a binary file.
24086 2002-08-23 Martin Baulig <martin@gnome.org>
24088 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24090 2002-08-23 Martin Baulig <martin@gnome.org>
24092 * struct.cs (MyStructInfo.ctor): Make this work with empty
24093 structs; it's not allowed to use foreach() on null.
24095 2002-08-23 Martin Baulig <martin@gnome.org>
24097 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24098 writer the full pathname of the generated assembly.
24100 2002-08-23 Martin Baulig <martin@gnome.org>
24102 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24103 A `finally' block never returns or breaks; improved handling of
24106 2002-08-23 Martin Baulig <martin@gnome.org>
24108 * statement.cs (Throw.Resolve): Allow `throw null'.
24110 2002-08-23 Martin Baulig <martin@gnome.org>
24112 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24113 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24114 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24115 MemberLookup would return a wrong event if this is an explicit
24116 interface implementation and the class has an event with the same
24119 2002-08-23 Martin Baulig <martin@gnome.org>
24121 * statement.cs (Block.AddChildVariableNames): New public method.
24122 (Block.AddChildVariableName): Likewise.
24123 (Block.IsVariableNameUsedInChildBlock): Likewise.
24124 (Block.AddVariable): Check whether a variable name has already
24125 been used in a child block.
24127 * cs-parser.jay (declare_local_variables): Mark all variable names
24128 from the current block as being used in a child block in the
24131 2002-08-23 Martin Baulig <martin@gnome.org>
24133 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24134 find the symbol writer.
24136 * driver.cs: csc also allows the arguments to /define being
24137 separated by commas, not only by semicolons.
24139 2002-08-23 Martin Baulig <martin@gnome.org>
24141 * interface.cs (Interface.GetMembers): Added static check for events.
24143 2002-08-15 Martin Baulig <martin@gnome.org>
24145 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24146 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24148 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24149 why the MethodData.EmitDestructor() change was necessary.
24151 2002-08-20 Martin Baulig <martin@gnome.org>
24153 * class.cs (TypeContainer.FindMembers): Added static check for events.
24155 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24157 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24158 use Type.GetEvents(), not Type.FindMembers().
24160 2002-08-20 Martin Baulig <martin@gnome.org>
24162 * decl.cs (MemberCache): Added a special method cache which will
24163 be used for method-only searched. This ensures that a method
24164 search will return a MethodInfo with the correct ReflectedType for
24167 2002-08-20 Martin Baulig <martin@gnome.org>
24169 * decl.cs (DeclSpace.FindMembers): Made this public.
24171 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24173 * delegate.cs: fixed build on windows.
24174 [FIXME: Filed as bug #29150: MCS must report these errors.]
24176 2002-08-19 Ravi Pratap <ravi@ximian.com>
24178 * ecore.cs (StandardConversionExists): Return a false
24179 if we are trying to convert the void type to anything else
24180 since that is not allowed.
24182 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24183 we flag error 70 in the event an event is trying to be accessed
24184 directly from outside the declaring type.
24186 2002-08-20 Martin Baulig <martin@gnome.org>
24188 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24189 MemberCache from typemanager.cs to decl.cs.
24191 2002-08-19 Martin Baulig <martin@gnome.org>
24193 * class.cs (TypeContainer): Implement IMemberContainer.
24194 (TypeContainer.DefineMembers): Create the MemberCache.
24195 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24196 return public members if BindingFlags.Public was given, check
24197 whether members are static.
24199 2002-08-16 Martin Baulig <martin@gnome.org>
24201 * decl.cs (DeclSpace.Define): Splitted this in Define and
24202 DefineMembers. DefineMembers is called first and initializes the
24205 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24206 DefineMembers() on all our DeclSpaces.
24208 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24209 but call DefineMembers() on all nested interfaces. We call their
24210 Define() in our new Define() function.
24212 * interface.cs (Interface): Implement IMemberContainer.
24213 (Interface.Define): Moved all code except the attribute stuf to
24215 (Interface.DefineMembers): Initialize the member cache.
24217 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24218 need this anymore since we can use MemberCache.FindMembers directly.
24220 2002-08-19 Martin Baulig <martin@gnome.org>
24222 * typemanager.cs (MemberCache): When creating the cache for an
24223 interface type, add all inherited members.
24224 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24225 to `out bool used_cache' and documented it.
24226 (TypeManager.MemberLookup): If we already used the cache in the first
24227 iteration, we don't need to do the interfaces check.
24229 2002-08-19 Martin Baulig <martin@gnome.org>
24231 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24232 here from IMemberFinder and don't implement this interface anymore.
24233 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24235 * typemanager.cs (IMemberFinder): This interface is now only used by
24236 classes which actually support the member cache.
24237 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24238 since we only put DeclSpaces into this Hashtable.
24239 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24240 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24242 2002-08-16 Martin Baulig <martin@gnome.org>
24244 * typemanager.cs (ICachingMemberFinder): Removed.
24245 (IMemberFinder.MemberCache): New property.
24246 (TypeManager.FindMembers): Merged this with RealFindMembers().
24247 This function will never be called from TypeManager.MemberLookup()
24248 so we can't use the cache here, just the IMemberFinder.
24249 (TypeManager.MemberLookup_FindMembers): Check whether the
24250 IMemberFinder has a MemberCache and call the cache's FindMembers
24252 (MemberCache): Rewrote larger parts of this yet another time and
24253 cleaned it up a bit.
24255 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24257 * driver.cs (LoadArgs): Support quoting.
24259 (Usage): Show the CSC-like command line arguments.
24261 Improved a few error messages.
24263 2002-08-15 Martin Baulig <martin@gnome.org>
24265 * typemanager.cs (IMemberContainer.Type): New property.
24266 (IMemberContainer.IsInterface): New property.
24268 The following changes are conditional to BROKEN_RUNTIME, which is
24269 defined at the top of the file.
24271 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24272 class'es members, but add all members from TypeHandle.ObjectType
24273 if we're an interface.
24274 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24275 is the current type.
24276 (MemberCache.CacheEntry.Container): Removed this field.
24277 (TypeHandle.GetMembers): Include inherited members.
24279 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24281 * typemanager.cs: fixed compilation and added a comment on a field that
24284 2002-08-15 Martin Baulig <martin@gnome.org>
24286 * class.cs (ConstructorInitializer.Resolve): In the
24287 Expression.MemberLookup call, use the queried_type as
24290 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24291 declared' attribute, it's always true.
24292 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24293 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24294 temporary wrapper for FindMembers which tells MemberLookup whether
24295 members from the base classes are included in the return value.
24296 This will go away soon.
24297 (TypeManager.MemberLookup): Use this temporary hack here; once the
24298 new MemberCache is completed, we don't need to do the DeclaredOnly
24299 looping here anymore since the MemberCache will take care of this.
24300 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24301 (MemberCache): When creating the MemberCache for a class, get
24302 members from the current class and all its base classes.
24303 (MemberCache.CacheEntry.Container): New field. This is a
24304 temporary hack until the Mono runtime is fixed to distinguish
24305 between ReflectedType and DeclaringType. It allows us to use MCS
24306 with both the MS runtime and the unfixed Mono runtime without
24307 problems and without accecting performance.
24308 (MemberCache.SearchMembers): The DeclaredOnly looping from
24309 TypeManager.MemberLookup is now done here.
24311 2002-08-14 Martin Baulig <martin@gnome.org>
24313 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24314 Type.GetFields on dynamic types but get the fields from the
24315 corresponding TypeContainer.
24316 (MyStructInfo.GetStructInfo): Added check for enum types.
24318 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24319 (MemberList.SyncRoot): Implemented.
24320 (TypeManager.FilterWithClosure): No need to check permissions if
24321 closure_start_type == closure_invocation_type, don't crash if
24322 closure_invocation_type is null.
24324 2002-08-13 Martin Baulig <martin@gnome.org>
24326 Rewrote TypeContainer.FindMembers to use a member cache. This
24327 gives us a speed increase of about 35% for the self-hosting MCS
24328 build and of about 15-20% for the class libs (both on GNU/Linux).
24330 * report.cs (Timer): New class to get enhanced profiling. This
24331 whole class is "TIMER" conditional since it remarkably slows down
24334 * class.cs (MemberList): New class. This is an IList wrapper
24335 which we're now using instead of passing MemberInfo[]'s around to
24336 avoid copying this array unnecessarily.
24337 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24338 (ICachingMemberFinder, IMemberContainer): New interface.
24339 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24340 has already been checked, otherwise use it for the name comparision.
24341 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24342 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24343 if possible. Returns a MemberList, not a MemberInfo [].
24344 (TypeHandle): New class, implements IMemberContainer. We create
24345 one instance of this class per type, it contains a MemberCache
24346 which is used to do the member lookups.
24347 (MemberCache): New class. Each instance of this class contains
24348 all members of a type and a name-based hash table.
24349 (MemberCache.FindMembers): This is our new member lookup
24350 function. First, it looks up all members of the requested name in
24351 the hash table. Then, it walks this list and sorts out all
24352 applicable members and returns them.
24354 2002-08-13 Martin Baulig <martin@gnome.org>
24356 In addition to a nice code cleanup, this gives us a performance
24357 increase of about 1.4% on GNU/Linux - not much, but it's already
24358 half a second for the self-hosting MCS compilation.
24360 * typemanager.cs (IMemberFinder): New interface. It is used by
24361 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24362 Enum, Delegate or Interface.
24363 (TypeManager.finder_to_member_finder): New PtrHashtable.
24364 (TypeManager.finder_to_container): Removed.
24365 (TypeManager.finder_to_delegate): Removed.
24366 (TypeManager.finder_to_interface): Removed.
24367 (TypeManager.finder_to_enum): Removed.
24369 * interface.cs (Interface): Implement IMemberFinder.
24371 * delegate.cs (Delegate): Implement IMemberFinder.
24373 * enum.cs (Enum): Implement IMemberFinder.
24375 * class.cs (TypeContainer): Implement IMemberFinder.
24377 2002-08-12 Martin Baulig <martin@gnome.org>
24379 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24381 2002-08-12 Martin Baulig <martin@gnome.org>
24383 * ecore.cs (ITypeExpression): New interface for expressions which
24385 (TypeExpression): Renamed to TypeLookupExpression.
24386 (Expression.DoResolve): If we're doing a types-only lookup, the
24387 expression must implement the ITypeExpression interface and we
24388 call DoResolveType() on it.
24389 (SimpleName): Implement the new ITypeExpression interface.
24390 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24391 hack, the situation that we're only looking up types can't happen
24392 anymore when this method is called. Moved the type lookup code to
24393 DoResolveType() and call it.
24394 (SimpleName.DoResolveType): This ITypeExpression interface method
24395 is now doing the types-only lookup.
24396 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24397 (ResolveFlags): Added MaskExprClass.
24399 * expression.cs (MemberAccess): Implement the ITypeExpression
24401 (MemberAccess.DoResolve): Added support for a types-only lookup
24402 when we're called via ITypeExpression.DoResolveType().
24403 (ComposedCast): Implement the ITypeExpression interface.
24405 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24406 Expression.Resolve() with ResolveFlags.Type instead.
24408 2002-08-12 Martin Baulig <martin@gnome.org>
24410 * interface.cs (Interface.Define): Apply attributes.
24412 * attribute.cs (Attribute.ApplyAttributes): Added support for
24413 interface attributes.
24415 2002-08-11 Martin Baulig <martin@gnome.org>
24417 * statement.cs (Block.Emit): Only check the "this" variable if we
24418 do not always throw an exception.
24420 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24421 whether the property has a set accessor.
24423 2002-08-11 Martin Baulig <martin@gnome.org>
24425 Added control flow analysis support for structs.
24427 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24428 with control flow analysis turned off.
24429 (IVariable): New interface.
24430 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24431 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24432 (FieldExpr.DoResolve): Resolve the instance expression with flow
24433 analysis turned off and do the definite assignment check after the
24434 resolving when we know what the expression will resolve to.
24436 * expression.cs (LocalVariableReference, ParameterReference):
24437 Implement the new IVariable interface, only call the flow analysis
24438 code if ec.DoFlowAnalysis is true.
24439 (This): Added constructor which takes a Block argument. Implement
24440 the new IVariable interface.
24441 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24442 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24443 This does the definite assignment checks for struct members.
24445 * class.cs (Constructor.Emit): If this is a non-static `struct'
24446 constructor which doesn't have any initializer, call
24447 Block.AddThisVariable() to tell the flow analysis code that all
24448 struct elements must be initialized before control returns from
24451 * statement.cs (MyStructInfo): New public class.
24452 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24453 argument to this indexer. If non-zero, check an individual struct
24454 member, not the whole struct.
24455 (FlowBranching.CheckOutParameters): Check struct members.
24456 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24457 overloaded versions of these methods which take an additional
24458 `int field_idx' argument to check struct members.
24459 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24460 overloaded versions of these methods which take an additional
24461 `string field_name' argument to check struct member.s
24462 (VariableInfo): Implement the IVariable interface.
24463 (VariableInfo.StructInfo): New public property. Returns the
24464 MyStructInfo instance of the variable if it's a struct or null.
24465 (Block.AddThisVariable): New public method. This is called from
24466 Constructor.Emit() for non-static `struct' constructor which do
24467 not have any initializer. It creates a special variable for the
24468 "this" instance variable which will be checked by the flow
24469 analysis code to ensure that all of the struct's fields are
24470 initialized before control returns from the constructor.
24471 (UsageVector): Added support for struct members. If a
24472 variable/parameter is a struct with N members, we reserve a slot
24473 in the usage vector for each member. A struct is considered fully
24474 initialized if either the struct itself (slot 0) or all its
24475 members are initialized.
24477 2002-08-08 Martin Baulig <martin@gnome.org>
24479 * driver.cs (Driver.MainDriver): Only report an error CS5001
24480 if there were no compilation errors.
24482 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24483 `UnsafeContext' property to determine whether the parent is in
24484 unsafe context rather than checking the parent's ModFlags:
24485 classes nested in an unsafe class are unsafe as well.
24487 2002-08-08 Martin Baulig <martin@gnome.org>
24489 * statement.cs (UsageVector.MergeChildren): Distinguish between
24490 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24491 we return. Added test17() and test18() to test-154.cs.
24493 2002-08-08 Martin Baulig <martin@gnome.org>
24495 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24496 Family access, make sure the invoking type isn't a subclass of the
24497 queried type (that'd be a CS1540).
24499 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24500 this method which takes an additional `Type invocation_type'.
24502 * expression.cs (BaseAccess.DoResolve): Use the base type as
24503 invocation and query type.
24504 (MemberAccess.DoResolve): If the lookup failed and we're about to
24505 report a CS0122, try a lookup with the ec.ContainerType - if this
24506 succeeds, we must report a CS1540.
24508 2002-08-08 Martin Baulig <martin@gnome.org>
24510 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24511 (MethodGroupExpr): Implement the IMemberExpr interface.
24513 * expression (MemberAccess.ResolveMemberAccess): No need to have
24514 any special code for MethodGroupExprs anymore, they're now
24517 2002-08-08 Martin Baulig <martin@gnome.org>
24519 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24520 Family, FamANDAssem and FamORAssem permissions.
24521 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24523 2002-08-08 Martin Baulig <martin@gnome.org>
24525 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24526 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24529 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24531 * driver.cs: implemented /resource option to embed managed resources.
24533 2002-08-07 Martin Baulig <martin@gnome.org>
24535 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24536 (FieldBase.HasFieldInitializer): New public property.
24537 (FieldBase.GetInitializerExpression): New public method. Resolves and
24538 returns the field initializer and makes sure it is only resolved once.
24539 (TypeContainer.EmitFieldInitializers): Call
24540 FieldBase.GetInitializerExpression to get the initializer, this ensures
24541 that it isn't resolved multiple times.
24543 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24544 the resolving process (SimpleName/MemberLookup) that we're currently
24545 emitting a field initializer (which must not access any instance members,
24546 this is an error CS0236).
24548 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24549 argument, if the `IsFieldInitializer' flag is set, we must report and
24550 error CS0236 and not an error CS0120.
24552 2002-08-07 Martin Baulig <martin@gnome.org>
24554 * ecore.cs (IMemberExpr): New public interface.
24555 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24556 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24557 if the expression is an IMemberExpr.
24559 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24560 to be null, implicitly default to `this' if we're non-static in
24561 this case. Simplified the code a lot by using the new IMemberExpr
24562 interface. Also fixed bug #28176 here.
24564 2002-08-06 Martin Baulig <martin@gnome.org>
24566 * cs-parser.jay (SimpleLookup): Removed. We need to create
24567 ParameterReferences during semantic analysis so that we can do a
24568 type-only search when resolving Cast, TypeOf and SizeOf.
24569 (block): Pass the `current_local_parameters' to the Block's
24572 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24573 argument to the constructor.
24574 (ConstructorInitializer.Resolve): Create a temporary implicit
24575 block with the parameters.
24577 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24578 references here if we aren't doing a type-only search.
24580 * statement.cs (Block): Added constructor which takes a
24581 `Parameters parameters' argument.
24582 (Block.Parameters): New public property.
24584 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24585 to `Parameters' and made it public readonly.
24587 2002-08-06 Martin Baulig <martin@gnome.org>
24589 * ecore.cs (Expression.Warning): Made this public as well.
24591 * report.cs (Report.Debug): Print the contents of collections.
24593 2002-08-06 Martin Baulig <martin@gnome.org>
24595 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24596 used to tell Resolve() which kinds of expressions it may return.
24597 (Expression.Resolve): Added overloaded version of this method which
24598 takes a `ResolveFlags flags' argument. This can be used to tell
24599 Resolve() which kinds of expressions it may return. Reports a
24601 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24602 ResolveFlags.SimpleName.
24603 (Expression.Error118): Added overloaded version of this method which
24604 takes a `ResolveFlags flags' argument. It uses the flags to determine
24605 which kinds of expressions are allowed.
24607 * expression.cs (Argument.ResolveMethodGroup): New public method.
24608 Resolves an argument, but allows a MethodGroup to be returned.
24609 This is used when invoking a delegate.
24611 * TODO: Updated a bit.
24613 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24615 Fixed compilation with csc.
24617 * ecore.cs: Expression.Error made public. Is this correct? Should
24618 Warning be made public too?
24620 * expression.cs: use ea.Location instead of ea.loc.
24621 [FIXME: Filed as bug #28607: MCS must report these errors.]
24623 2002-08-06 Martin Baulig <martin@gnome.org>
24625 * ecore.cs (Expression.loc): Moved the location here instead of
24626 duplicating it in all derived classes.
24627 (Expression.Location): New public property.
24628 (Expression.Error, Expression.Warning): Made them non-static and
24629 removed the location argument.
24630 (Expression.Warning): Added overloaded version which takes an
24631 `int level' argument.
24632 (Expression.Error118): Make this non-static and removed the
24633 expression and location arguments.
24634 (TypeExpr): Added location argument to the constructor.
24636 * expression.cs (StaticCallExpr): Added location argument to
24638 (Indirection, PointerArithmetic): Likewise.
24639 (CheckedExpr, UnCheckedExpr): Likewise.
24640 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24641 (StringPtr): Likewise.
24644 2002-08-05 Martin Baulig <martin@gnome.org>
24646 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24648 * assign.cs (Assign.DoResolve): Check whether the source
24649 expression is a value or variable.
24651 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24652 while resolving the corresponding blocks.
24654 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24655 an error, don't silently return null.
24657 * statement.cs (Block.AddVariable): Do the error reporting here
24658 and distinguish between CS0128 and CS0136.
24659 (Block.DoResolve): Report all unused labels (warning CS0164).
24660 (LabeledStatement): Pass the location to the constructor.
24661 (LabeledStatement.HasBeenReferenced): New property.
24662 (LabeledStatement.Resolve): Set it to true here.
24664 * statement.cs (Return.Emit): Return success even after reporting
24665 a type mismatch error (CS0126 or CS0127), this is what csc does and
24666 it avoids confusing the users with any consecutive errors.
24668 2002-08-05 Martin Baulig <martin@gnome.org>
24670 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24672 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24674 * expression.cs (MemberAccess.DoResolve): Silently return if an
24675 error has already been reported.
24677 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24678 error has already been reported.
24680 2002-08-05 Martin Baulig <martin@gnome.org>
24682 * statement.cs (UsageVector): Only initialize the `parameters'
24683 vector if we actually have any "out" parameters.
24685 2002-08-05 Martin Baulig <martin@gnome.org>
24687 * expression.cs (Binary.ResolveOperator): When combining delegates,
24688 they must have the same type.
24690 2002-08-05 Martin Baulig <martin@gnome.org>
24692 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24693 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24694 work with the ms runtime and we also don't need it: if we're a
24695 PropertyBuilder and not in the `indexer_arguments' hash, then we
24696 are a property and not an indexer.
24698 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24699 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24700 since the latter one doesn't work with the ms runtime.
24702 2002-08-03 Martin Baulig <martin@gnome.org>
24704 Fixed bugs #27998 and #22735.
24706 * class.cs (Method.IsOperator): New public field.
24707 (Method.CheckBase): Report CS0111 if there's already a method
24708 with the same parameters in the current class. Report CS0508 when
24709 attempting to change the return type of an inherited method.
24710 (MethodData.Emit): Report CS0179 if a method doesn't have a body
24711 and it's not marked abstract or extern.
24712 (PropertyBase): New abstract base class for Property and Indexer.
24713 (PropertyBase.CheckBase): Moved here from Property and made it work
24715 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
24716 the same so we can reuse it there.
24717 (Property, Indexer): Derive from PropertyBase.
24718 (MethodSignature.inheritable_property_signature_filter): New delegate
24719 to find properties and indexers.
24721 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
24722 argument and improved error reporting.
24724 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
24725 EmptyReadOnlyParameters and made it a property.
24727 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
24728 version of this method which takes a `PropertyInfo indexer'.
24729 (TypeManager.RegisterIndexer): New method.
24731 * class.cs: Added myself as author of this file :-)
24733 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24735 * class.cs: fixed compilation on windoze.
24737 2002-08-03 Martin Baulig <martin@gnome.org>
24739 * interface.cs (Interface.GetInterfaceBases): Check whether all
24740 base interfaces are at least as accessible than the current one.
24742 * class.cs (TypeContainer.GetClassBases): Check whether base types
24743 are at least as accessible than the current type.
24744 (TypeContainer.AsAccessible): Implemented and made non-static.
24745 (MemberBase.CheckParameters): Report errors if the accessibility
24748 * delegate.cs (Delegate.Delegate): The default visibility is
24749 internal for top-level types and private for nested types.
24750 (Delegate.Define): Report errors if the accessibility checks fail.
24752 * enum.cs (Enum.Enum): The default visibility is internal for
24753 top-level types and private for nested types.
24754 (Enum.DefineType): Compute the correct visibility.
24756 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
24757 function which takes a `bool is_toplevel' instead of a TypeContainer.
24759 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
24762 2002-08-02 Martin Baulig <martin@gnome.org>
24764 * expression.cs (LocalVariableReferenc): Added constructor which
24765 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
24766 (LocalVariableReference.IsReadOnly): New property.
24767 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
24768 variable is readonly, use our own readonly flag to do this; you can
24769 use the new constructor to get a writable reference to a read-only
24772 * cs-parser.jay (foreach_statement, using_statement): Get a writable
24773 reference to the local variable.
24775 2002-08-01 Miguel de Icaza <miguel@ximian.com>
24777 * rootcontext.cs (ResolveCore): Also include System.Exception
24779 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
24780 we reach an EmptyStatement.
24782 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
24785 * expression.cs (Binary.ResolveOperator): Check error result in
24788 use brtrue/brfalse directly and avoid compares to null.
24790 2002-08-02 Martin Baulig <martin@gnome.org>
24792 * class.cs (TypeContainer.Define): Define all nested interfaces here.
24793 Fixes bug #28407, added test-155.cs.
24795 2002-08-01 Martin Baulig <martin@gnome.org>
24797 * class.cs (Event.EmitDefaultMethod): Make this work with static
24798 events. Fixes #28311, added verify-3.cs.
24800 2002-08-01 Martin Baulig <martin@gnome.org>
24802 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
24803 `is_disposable' fields.
24804 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
24805 `hm.is_disposable' if we're using the collection pattern.
24806 (Foreach.EmitCollectionForeach): Use the correct type for the
24807 enumerator's local variable, only emit the try/finally block if
24808 necessary (fixes #27713).
24810 2002-08-01 Martin Baulig <martin@gnome.org>
24812 * ecore.cs (Expression.report118): Renamed to Error118 and made
24815 * statement.cs (Throw.Resolve): Check whether the expression is of
24816 the correct type (CS0118) and whether the type derives from
24817 System.Exception (CS0155).
24818 (Catch.Resolve): New method. Do the type lookup here and check
24819 whether it derives from System.Exception (CS0155).
24820 (Catch.CatchType, Catch.IsGeneral): New public properties.
24822 * typemanager.cs (TypeManager.exception_type): Added.
24824 2002-07-31 Miguel de Icaza <miguel@ximian.com>
24826 * driver.cs: Updated About function.
24828 2002-07-31 Martin Baulig <martin@gnome.org>
24830 Implemented Control Flow Analysis.
24832 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
24833 (EmitContext.CurrentBranching): Added.
24834 (EmitContext.StartFlowBranching): Added.
24835 (EmitContext.EndFlowBranching): Added.
24836 (EmitContext.KillFlowBranching): Added.
24837 (EmitContext.IsVariableAssigned): Added.
24838 (EmitContext.SetVariableAssigned): Added.
24839 (EmitContext.IsParameterAssigned): Added.
24840 (EmitContext.SetParameterAssigned): Added.
24841 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
24842 Added control flow analysis stuff here.
24844 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
24845 resolve the expression as lvalue.
24846 (LocalVariableReference.DoResolve): Check whether the variable has
24847 already been assigned.
24848 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
24849 the parameter as assigned here.
24850 (ParameterReference.DoResolve): Check whether the parameter has already
24852 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
24853 expression as lvalue.
24855 * statement.cs (FlowBranching): New class for the flow analysis code.
24856 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
24857 (LabeledStatement.IsDefined): New public property.
24858 (LabeledStatement.AddUsageVector): New public method to tell flow
24859 analyis that the label may be reached via a forward jump.
24860 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
24862 (VariableInfo.Number): New public field. This is used by flow analysis
24863 to number all locals of a block.
24864 (Block.CountVariables): New public property. This is the number of
24865 local variables in this block (including the locals from all parent
24867 (Block.EmitMeta): Number all the variables.
24869 * statement.cs: Added flow analysis support to all classes.
24871 2002-07-31 Martin Baulig <martin@gnome.org>
24873 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
24874 To get debugging messages, compile mcs with /define:MCS_DEBUG and
24875 then use this argument.
24877 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
24879 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
24880 use this to specify /define options.
24882 2002-07-29 Martin Baulig <martin@gnome.org>
24884 * statement.cs (Fixed): Moved all code that does variable lookups
24885 and resolvings from Emit to Resolve.
24887 * statement.cs (For): Moved all code that does variable lookups
24888 and resolvings from Emit to Resolve.
24890 * statement.cs (Using): Moved all code that does variable lookups
24891 and resolvings from Emit to Resolve.
24893 2002-07-29 Martin Baulig <martin@gnome.org>
24895 * attribute.cs (Attribute.Resolve): Explicitly catch a
24896 System.NullReferenceException when creating the
24897 CustromAttributeBuilder and report a different warning message.
24899 2002-07-29 Martin Baulig <martin@gnome.org>
24901 * support.cs (ParameterData.ParameterName): Added method to
24902 get the name of a parameter.
24904 * typemanager.cs (TypeManager.IsValueType): New public method.
24906 2002-07-29 Martin Baulig <martin@gnome.org>
24908 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
24909 is a flag which specifies that it's either ref or out.
24910 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
24911 the out parameter to `out Parameter.Modifier mod', also set the
24912 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
24914 * support.cs (InternalParameters.ParameterModifier): Distinguish
24915 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24916 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24918 * expression.cs (Argument.GetParameterModifier): Distinguish
24919 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24920 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24922 2002-07-29 Martin Baulig <martin@gnome.org>
24924 * expression.cs (ParameterReference.ParameterReference): Added
24925 `Location loc' argument to the constructor.
24927 * cs-parser.jay: Pass location to ParameterReference.
24929 2002-07-28 Miguel de Icaza <miguel@ximian.com>
24931 * statement.cs (Try): Initialize the location.
24933 * cs-parser.jay: pass location to Try.
24935 * expression.cs (Unary.Reduce): Change the prototype to return
24936 whether a constant fold could be performed or not. The result is
24937 returned in an out parameters. In the case of Indirection and
24938 AddressOf, we want to perform the full tests.
24940 2002-07-26 Miguel de Icaza <miguel@ximian.com>
24942 * statement.cs (Statement.Emit): Flag dead code.
24944 2002-07-27 Andrew Birkett <andy@nobugs.org>
24946 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
24948 2002-07-27 Martin Baulig <martin@gnome.org>
24950 * class.cs (MethodData.Define): Put back call to
24951 TypeManager.AddMethod(), accidentally commented this out.
24953 * report.cs (Debug): New public method to print debugging information,
24954 this is `[Conditional ("DEBUG")]'.
24956 2002-07-26 Martin Baulig <martin@gnome.org>
24958 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
24959 (switch_statement): Push the current_block to the switch_stack and
24960 pop it again when we're done with the switch.
24961 (switch_section): The new block is a child of the current_block.
24962 Fixes bug #24007, added test-152.cs.
24964 2002-07-27 Martin Baulig <martin@gnome.org>
24966 * expression.cs (Invocation.EmitArguments): When calling a varargs
24967 function with only its fixed arguments, we need to pass an empty
24970 2002-07-27 Martin Baulig <martin@gnome.org>
24972 Mono 0.13 has been released.
24974 2002-07-25 Miguel de Icaza <miguel@ximian.com>
24976 * driver.cs: Rename --resource to --linkres, because that is what
24977 we do currently, we dont support --resource yet.
24979 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
24981 2002-07-25 Martin Baulig <martin@gnome.org>
24983 * class.cs (MethodData): New public class. This is a `method builder'
24984 class for a method or one accessor of a Property/Indexer/Event.
24985 (MethodData.GetMethodFlags): Moved here from MemberBase.
24986 (MethodData.ApplyAttributes): Likewise.
24987 (MethodData.ApplyObsoleteAttribute): Likewise.
24988 (MethodData.ApplyConditionalAttribute): Likewise.
24989 (MethodData.ApplyDllImportAttribute): Likewise.
24990 (MethodData.CheckAbstractAndExternal): Likewise.
24991 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
24992 (MethodData.Emit): Formerly known as Method.Emit().
24993 (MemberBase): Moved everything which was specific to a single
24994 accessor/method to MethodData.
24995 (Method): Create a new MethodData and call Define() and Emit() on it.
24996 (Property, Indexer, Event): Create a new MethodData objects for each
24997 accessor and call Define() and Emit() on them.
24999 2002-07-25 Martin Baulig <martin@gnome.org>
25001 Made MethodCore derive from MemberBase to reuse the code from there.
25002 MemberBase now also checks for attributes.
25004 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25005 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25007 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25008 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25009 (MemberBase.ApplyAttributes): New virtual method; applies the
25010 attributes to a method or accessor.
25011 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25012 (MemberBase.ApplyConditionalAttribute): Likewise.
25013 (MemberBase.ApplyDllImportAttribute): Likewise.
25014 (MemberBase.CheckAbstractAndExternal): Likewise.
25015 (MethodCore.ParameterTypes): This is now a property instead of a
25016 method, it's initialized from DoDefineParameters().
25017 (MethodCore.ParameterInfo): Removed the set accessor.
25018 (MethodCore.DoDefineParameters): New protected virtual method to
25019 initialize ParameterTypes and ParameterInfo.
25020 (Method.GetReturnType): We can now simply return the MemberType.
25021 (Method.GetMethodFlags): Override the MemberBase version and add
25022 the conditional flags.
25023 (Method.CheckBase): Moved some code from Define() here, call
25024 DoDefineParameters() here.
25025 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25026 here to avoid some larger code duplication.
25027 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25028 ensure that abstract and external accessors don't declare a body.
25030 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25031 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25032 lookup in the attribute's parent classes, so we need to abort as soon
25033 as we found the first match.
25034 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25035 the attribute has no arguments.
25037 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25040 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25042 * cs-parser.jay: reverted previous patch.
25044 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25046 * cs-parser.jay: fixed bug #22119.
25048 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25050 * attribute.cs: fixed compilation. The error was:
25051 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25052 be assigned to before control leaves the current method."
25053 [FIXME: Filed as bug #28186: MCS must report this error.]
25055 2002-07-25 Martin Baulig <martin@gnome.org>
25057 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25058 method to pull the condition name ouf of a Conditional attribute.
25059 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25060 the obsolete message and error flag out of an Obsolete attribute.
25062 * class.cs (Method.GetMethodFlags): New public method to get the
25063 TypeManager.MethodFlags for this method.
25064 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25066 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25067 if we're overriding a virtual function, set the new private variable
25068 `parent_method'; call the new TypeManager.AddMethod().
25070 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25071 the MethodBuilder and the Method in a PtrHashtable.
25072 (TypeManager.builder_to_method): Added for this purpose.
25073 (TypeManager.MethodFlags): Added IsObsoleteError.
25074 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25075 Obsolete and Conditional arguments in MethodBuilders. If we discover
25076 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25077 the message from the attribute.
25079 2002-07-24 Martin Baulig <martin@gnome.org>
25081 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25082 preprocessor directives, ensure that the argument to #define/#undef is
25083 exactly one identifier and that it's actually an identifier.
25085 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25088 2002-07-24 Martin Baulig <martin@gnome.org>
25090 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25091 initialize it to TypeManager.object_type in the constructor.
25092 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25093 of the `hm.get_current' method if we're using the collection pattern.
25094 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25095 for the explicit conversion to make it work when we're using the collection
25096 pattern and the `Current' property has a different return type than `object'.
25099 2002-07-24 Martin Baulig <martin@gnome.org>
25101 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25102 does not match, but don't report any errors. This method is called in
25103 order for all methods in a MethodGroupExpr until a matching method is
25104 found, so we don't want to bail out if the first method doesn't match.
25105 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25106 matches, report the 123. Fixes #28070.
25108 2002-07-24 Martin Baulig <martin@gnome.org>
25110 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25111 TypeManager.TypeToCoreType() to the top of the method so the
25112 following equality checks will work. Fixes #28107.
25114 2002-07-24 Martin Baulig <martin@gnome.org>
25116 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25117 operand is of type uint, and the other operand is of type sbyte,
25118 short or int, the operands are converted to type long." -
25119 Actually do what this comment already told us. Fixes bug #28106,
25122 2002-07-24 Martin Baulig <martin@gnome.org>
25124 * class.cs (MethodBase): New abstract class. This is now a base
25125 class for Property, Indexer and Event to avoid some code duplication
25126 in their Define() and DefineMethods() methods.
25127 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25128 generic methods for Define() and DefineMethods().
25129 (FieldBase): Derive from MemberBase, not MemberCore.
25130 (Property): Derive from MemberBase, not MemberCore.
25131 (Property.DefineMethod): Moved all the code from this method to the
25132 new MethodBase.DefineAccessor(), just call it with appropriate
25134 (Property.Define): Call the new Property.DoDefine(), this does some
25135 sanity checks and we don't need to duplicate the code everywhere.
25136 (Event): Derive from MemberBase, not MemberCore.
25137 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25138 accessors, this will also make them work with interface events.
25139 (Indexer): Derive from MemberBase, not MemberCore.
25140 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25141 (Indexer.Define): Use the new MethodBase functions.
25143 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25144 argument to the constructor.
25145 (Interface.FindMembers): Added support for interface events.
25146 (Interface.PopluateEvent): Implemented.
25148 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25150 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25152 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25153 but this is required to check for a method name being the same as
25154 the containing class.
25158 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25160 * interface.cs: initialize variable.
25162 2002-07-23 Martin Baulig <martin@gnome.org>
25164 Implemented the IndexerName attribute in interfaces.
25166 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25167 name if this is an explicit interface implementation.
25168 (Indexer.InterfaceIndexerName): New public variable. If we're
25169 implementing an interface indexer, this is the IndexerName in that
25170 interface. Otherwise, it's the IndexerName.
25171 (Indexer.DefineMethod): If we're implementing interface indexer,
25172 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25173 and Pending.ImplementIndexer methods.
25174 (Indexer.Define): Also define the PropertyBuilder if we're
25175 implementing an interface indexer and this is neither an explicit
25176 interface implementation nor do the IndexerName match the one in
25179 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25180 If a method is defined here, then we always need to create a proxy
25181 for it. This is used when implementing interface indexers.
25182 (Pending.IsInterfaceIndexer): New public method.
25183 (Pending.ImplementIndexer): New public method.
25184 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25185 This is used when implementing interface indexers to define a proxy
25187 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25188 define a proxy if necessary.
25190 * interface.cs (Interface.IndexerName): New public variable.
25191 (Interface.PopulateIndexer): Set the IndexerName.
25192 (Interface.DefineIndexers): New private method. Populate all the
25193 indexers and make sure their IndexerNames match.
25195 * typemanager.cs (IndexerPropertyName): Added support for interface
25198 2002-07-22 Martin Baulig <martin@gnome.org>
25200 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25201 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25202 ret if HasReturnLabel.
25203 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25206 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25207 and set the ec.LoopBeginTryCatchLevel.
25208 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25209 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25210 the current ec.TryCatchLevel, the branch goes out of an exception
25211 block. In this case, we need to use Leave and not Br.
25213 2002-07-22 Martin Baulig <martin@gnome.org>
25215 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25216 block unless the block does not always return or it is contained in
25217 another try { ... } catch { ... } block. Fixes bug #26506.
25218 Added verify-1.cs to the test suite.
25220 2002-07-22 Martin Baulig <martin@gnome.org>
25222 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25223 then we do not always return. Fixes bug #24985.
25225 2002-07-22 Martin Baulig <martin@gnome.org>
25227 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25228 lookup on a per-class level; ie. walk up the class hierarchy until we
25229 found at least one applicable method, then choose the best among them.
25230 Fixes bug #24463 and test-29.cs.
25232 2002-07-22 Martin Baulig <martin@gnome.org>
25234 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25235 return types of the methods. The return type is not part of the
25236 signature and we must not check it to make the `new' modifier work.
25237 Fixes bug #27999, also added test-147.cs.
25238 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25240 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25241 on the method's return type.
25243 2002-07-21 Martin Baulig <martin@gnome.org>
25245 * assign.cs: Make this work if the rightmost source is a constant and
25246 we need to do an implicit type conversion. Also adding a few more tests
25247 to test-38.cs which should have caught this.
25249 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25250 target in the makefile for this. The makefile.gnu is primarily intended
25251 for end-users who don't want to debug the compiler.
25253 2002-07-21 Martin Baulig <martin@gnome.org>
25255 * assign.cs: Improved the Assign class so it can now handle embedded
25256 assignments (X = Y = Z = something). As a side-effect this'll now also
25257 consume less local variables. test-38.cs now passes with MCS, added
25258 a few new test cases to that test.
25260 2002-07-20 Martin Baulig <martin@gnome.org>
25262 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25263 instructions. Fixes bug #27977, also added test-146.cs.
25265 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25267 * cs-tokenizer.cs: fixed getHex ().
25269 2002-07-19 Martin Baulig <martin@gnome.org>
25271 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25272 not Type.GetType() to lookup the array type. This is needed when
25273 we're constructing an array of a user-defined type.
25274 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25275 single-dimensional arrays, but also for single-dimensial arrays of
25278 2002-07-19 Martin Baulig <martin@gnome.org>
25280 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25281 this function is called, it's not allowed to share LocalBuilders
25282 among ILGenerators.
25284 2002-07-19 Martin Baulig <martin@gnome.org>
25286 * expression.cs (Argument.Resolve): Report an error 118 when trying
25287 to pass a type as argument.
25289 2002-07-18 Martin Baulig <martin@gnome.org>
25291 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25292 Conv_R_Un for the signed `long' type.
25294 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25296 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25297 `expr' for the temporary result, as that will fail if we do
25298 multiple resolves on the same expression.
25300 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25302 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25303 ec.TypeContainer for looking up aliases.
25305 * class.cs (TypeContainer): Remove LookupAlias from here.
25307 * decl.cs (DeclSpace); Move here.
25309 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25311 * class.cs (FindMembers): Only call filter if the constructor
25312 bulider is not null.
25314 Also handle delegates in `NestedTypes' now. Now we will perform
25315 type lookups using the standard resolution process. This also
25318 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25319 This uses Expressions (the limited kind that can be parsed by the
25320 tree) instead of strings.
25322 * expression.cs (ComposedCast.ToString): Implement, used to flag
25323 errors since now we have to render expressions.
25325 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25328 * ecore.cs (SimpleName.ToString): ditto.
25330 * cs-parser.jay: Instead of using strings to assemble types, use
25331 Expressions to assemble the type (using SimpleName, ComposedCast,
25332 MemberAccess). This should fix the type lookups in declarations,
25333 because we were using a different code path for this.
25335 * statement.cs (Block.Resolve): Continue processing statements
25336 even when there is an error.
25338 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25340 * class.cs (Event.Define): Also remove the `remove' method from
25341 the list of pending items.
25343 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25344 generate more compact code.
25346 2002-07-17 Martin Baulig <martin@gnome.org>
25348 * const.cs (Const.LookupConstantValue): Add support for constant
25349 `unchecked' and `checked' expressions.
25350 Also adding test case test-140.cs for this.
25352 2002-07-17 Martin Baulig <martin@gnome.org>
25354 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25355 check whether mi.ReturnType implements the IEnumerator interface; the
25356 `==' and the IsAssignableFrom() will fail in this situation.
25358 2002-07-16 Ravi Pratap <ravi@ximian.com>
25360 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25363 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25365 * expression.cs: fixed bug #27811.
25367 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25369 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25370 Molaro: when we are a ref, the value already contains a pointer
25371 value, do not take the address of it.
25373 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25374 * removed mb-parser.jay and mb-tokenizer.cs
25376 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25378 * expression.cs: check against the building corlib void type.
25380 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25382 * ecore.cs: fix for valuetype static readonly fields: when
25383 initializing them, we need their address, not the address of a copy.
25385 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25387 * typemanager.cs: register also enum_type in corlib.
25389 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25391 * class.cs: allow calling this (but not base) initializers in structs.
25393 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25395 * ecore.cs: make sure we compare against the building base types
25398 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25400 * typemanager.cs: fix TypeToCoreType() to handle void and object
25401 (corlib gets no more typerefs after this change).
25403 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25405 * expression.cs (ArrayCreation.EmitArrayArguments): use
25406 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25408 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25409 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25410 array indexes, the runtime actually forbids them.
25412 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25413 for array arguments here.
25415 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25416 instead of the default for ValueTypes.
25418 (New.DoEmit): Use IsValueType instead of
25419 IsSubclassOf (value_type)
25420 (New.DoResolve): ditto.
25421 (Invocation.EmitCall): ditto.
25423 * assign.cs (Assign): ditto.
25425 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25426 Statements *are* currently doing part of their resolution during
25429 Expressions do always resolve during resolve, but statements are
25430 only required to propagate resolution to their children.
25432 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25434 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25436 (LoadAssembly): Do not add the dll if it is already specified
25438 (MainDriver): Add the System directory to the link path at the end,
25439 after all the other -L arguments.
25441 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25442 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25443 ldelem.u1) and using the opposite for sbytes.
25445 This fixes Digger, and we can finally run it.
25447 * driver.cs (UnixParseOption): Move the option parsing here.
25448 (CSCParseOption): Implement CSC-like parsing of options.
25450 We now support both modes of operation, the old Unix way, and the
25451 new CSC-like way. This should help those who wanted to make cross
25452 platform makefiles.
25454 The only thing broken is that /r:, /reference: and /lib: are not
25455 implemented, because I want to make those have the same semantics
25456 as the CSC compiler has, and kill once and for all the confussion
25457 around this. Will be doing this tomorrow.
25459 * statement.cs (Unsafe.Resolve): The state is checked during
25460 resolve, not emit, so we have to set the flags for IsUnsfe here.
25462 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25464 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25465 not catch the Error_ObjectRefRequired in SimpleName (as it is
25466 possible to have a class/instance variable name that later gets
25467 deambiguated), we have to check this here.
25469 2002-07-10 Ravi Pratap <ravi@ximian.com>
25471 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25472 make static and put into Expression.
25474 (Event.Define): Register the private field of the event with the
25475 TypeManager so that GetFieldFromEvent can get at it.
25477 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25478 keep track of the private field associated with an event which
25481 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25484 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25486 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25488 * expression.cs (Binary.EmitBranchable): this routine emits the
25489 Binary expression in a branchable context. This basically means:
25490 we need to branch somewhere, not just get the value on the stack.
25492 This works together with Statement.EmitBoolExpression.
25494 * statement.cs (Statement.EmitBoolExpression): Use
25497 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25499 * statement.cs (For): Reduce the number of jumps in loops.
25501 (For): Implement loop inversion for the For statement.
25503 (Break): We can be breaking out of a Try/Catch controlled section
25504 (foreach might have an implicit try/catch clause), so we need to
25505 use Leave instead of Br.
25507 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25508 now). If the instace expression supports IMemoryLocation, we use
25509 the AddressOf method from the IMemoryLocation to extract the
25510 address instead of emitting the instance.
25512 This showed up with `This', as we were emitting the instance
25513 always (Emit) instead of the Address of This. Particularly
25514 interesting when This is a value type, as we dont want the Emit
25515 effect (which was to load the object).
25517 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25519 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25521 * statement.cs (Checked): Set the CheckedState during the resolve
25522 process too, as the ConvCast operations track the checked state on
25523 the resolve process, and not emit.
25525 * cs-parser.jay (namespace_member_declaration): Flag that we have
25526 found a declaration when we do. This is used to flag error 1529
25528 * driver.cs: Report ok when we display the help only.
25530 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25532 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25534 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25536 * cs-tokenizer.cs (define): We also have to track locally the
25537 defines. AllDefines is just used for the Conditional Attribute,
25538 but we also need the local defines for the current source code.
25540 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25542 * statement.cs (While, For, Do): These loops can exit through a
25543 Break statement, use this information to tell whether the
25544 statement is the last piece of code.
25546 (Break): Flag that we break.
25548 * codegen.cs (EmitContexts): New `Breaks' state variable.
25550 2002-07-03 Martin Baulig <martin@gnome.org>
25552 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25553 modifiers in method declarations in structs. Otherwise, you won't
25554 be able to override things like Object.Equals().
25556 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25558 * class.cs (Method, Property, Indexer): Do not allow the public
25559 modifier to be used in explicit interface implementations.
25561 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25562 override modifiers in method declarations in structs
25564 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25566 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25567 integer or real overflow, report an error
25569 2002-07-02 Martin Baulig <martin@gnome.org>
25571 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25572 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25573 to tell the runtime about our newly created System.Object and
25574 System.ValueType types.
25576 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25578 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25579 struct instead of Ldarg/Starg.
25581 2002-07-02 Martin Baulig <martin@gnome.org>
25583 * expression.cs (Indirection.Indirection): Call
25584 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25586 2002-07-02 Martin Baulig <martin@gnome.org>
25588 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25589 ValueType, call TypeManager.TypeToCoreType() on it.
25590 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25591 the OpCodes.Newarr argument.
25593 2002-07-02 Martin Baulig <martin@gnome.org>
25595 * expression.cs (Invocation.EmitCall): When compiling corlib,
25596 replace all calls to the system's System.Array type to calls to
25597 the newly created one.
25599 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25600 System.Array methods.
25601 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25602 from the system's System.Array type which must be replaced.
25604 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25606 * typemanager.cs: load unverifiable_code_ctor so we can build
25607 corlib using the correct type. Avoid using GetTypeCode() with
25609 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25610 TypeManager.object_type to allow building corlib.
25612 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25614 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25616 2002-07-01 Martin Baulig <martin@gnome.org>
25618 * class.cs: Make the last change actually work, we need to check
25619 whether `ifaces != null' to avoid a crash.
25621 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25623 * class.cs: when we build structs without fields that implement
25624 interfaces, we need to add the interfaces separately, since there is
25625 no API to both set the size and add the interfaces at type creation
25628 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25630 * expression.cs: the dimension arguments to the array constructors
25631 need to be converted if they are a long.
25633 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25635 * class.cs: don't emit ldarg.0 if there is no parent constructor
25636 (fixes showstopper for corlib).
25638 2002-06-29 Martin Baulig <martin@gnome.org>
25640 MCS now compiles corlib on GNU/Linux :-)
25642 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25643 ie. check for MethodImplOptions.InternalCall.
25645 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25646 and TypeManager.attribute_type are null, so we must explicitly check
25647 whether parent is not null to find out whether it's an attribute type.
25648 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25649 and SetBuilder, not only if the property is neither abstract nor external.
25650 This is necessary to set the MethodImplOptions on the accessor methods.
25651 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25652 SetBuilder, see Property.Emit().
25654 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25655 populate "System.Object", "System.ValueType" and "System.Attribute" since
25656 they've already been populated from BootCorlib_PopulateCoreTypes().
25658 2002-06-29 Martin Baulig <martin@gnome.org>
25660 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25661 is the NullLiteral, we also need to make sure that target_type is not
25664 2002-06-29 Martin Baulig <martin@gnome.org>
25666 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25667 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25668 before calling BootstrapCorlib_ResolveDelegate ().
25670 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25672 * statement.cs: fixed build-breaker. All tests passed ok.
25674 2002-06-27 Martin Baulig <martin@gnome.org>
25676 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25677 for System.Decimal when compiling corlib.
25679 2002-06-27 Martin Baulig <martin@gnome.org>
25681 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25682 switch blocks which contain nothing but a default clause.
25684 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25686 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25688 2002-06-27 Martin Baulig <martin@gnome.org>
25690 * ecore.cs (PropertyExpr.PropertyExpr): Call
25691 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25693 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25694 is already a TypeBuilder.
25696 2002-06-27 Martin Baulig <martin@gnome.org>
25698 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25699 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25700 the "from an array-type to System.Array" case. This makes it work
25701 when compiling corlib.
25703 2002-06-27 Martin Baulig <martin@gnome.org>
25705 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
25706 non-static PropertyExpr, set its InstanceExpression. This makes
25707 the `ICollection.Count' property work in System/Array.cs.
25709 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
25711 * driver.cs: Made error handling more consistent. Errors now
25712 tracked by Report class, so many methods which used to return int
25713 now return void. Main() now prints success/failure and
25714 errors/warnings message.
25716 Renamed '--probe' compiler argument to '--expect-error'. Removed
25717 the magic number return values (123 and 124). Now, if the
25718 expected error occurs, the compiler exits with success (exit value
25719 0). If the compilation completes without seeing that particular
25720 error, the compiler exits with failure (exit value 1). The
25721 makefile in mcs/errors has been changed to handle the new behaviour.
25723 * report.cs: Made 'expected error' number a property and renamed
25724 it from 'Probe' to 'ExpectedError'.
25726 * genericparser.cs: Removed error handling support, since it is
25727 now all done by Report class.
25729 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
25730 class, so parse() no longer returns an int.
25732 * namespace.cs: Use Report.Error instead of GenericParser.error
25734 2002-06-22 Miguel de Icaza <miguel@ximian.com>
25736 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
25737 TypeContainer.AddOperator): At the front of the list put the
25738 explicit implementations, so they get resolved/defined first.
25740 2002-06-21 Miguel de Icaza <miguel@ximian.com>
25742 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
25743 interface type is implemented by this TypeContainer. Used during
25744 explicit interface implementation.
25746 (Property.Define, Indexer.Define, Method.Define): Validate that
25747 the given interface in the explicit implementation is one of the
25748 base classes for the containing type.
25750 Also if we are explicitly implementing an interface, but there is
25751 no match in the pending implementation table, report an error.
25753 (Property.Define): Only define the property if we are
25754 not explicitly implementing a property from an interface. Use the
25755 correct name also for those properties (the same CSC uses,
25756 although that is really not needed).
25758 (Property.Emit): Do not emit attributes for explicitly implemented
25759 properties, as there is no TypeBuilder.
25761 (Indexer.Emit): ditto.
25763 Hiding then means that we do not really *implement* a pending
25764 implementation, which makes code fail.
25766 2002-06-22 Martin Baulig <martin@gnome.org>
25768 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
25769 the return value of Object.GetType(). [FIXME: we need to do this whenever
25770 we get a type back from the reflection library].
25772 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
25774 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
25776 2002-06-20 Miguel de Icaza <miguel@ximian.com>
25778 * attribute.cs: Return null if we can not look up the type.
25780 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
25781 the interface types found.
25783 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
25784 interface types found.
25786 * typemanager.cs (GetInterfaces): Make this routine returns alll
25787 the interfaces and work around the lame differences between
25788 System.Type and System.Reflection.Emit.TypeBuilder in the results
25789 result for GetInterfaces.
25791 (ExpandInterfaces): Given an array of interface types, expand and
25792 eliminate repeated ocurrences of an interface. This expands in
25793 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
25796 2002-06-21 Martin Baulig <martin@gnome.org>
25798 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
25801 2002-06-21 Martin Baulig <martin@gnome.org>
25803 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
25804 and called with one of the core types, return the corresponding typebuilder for
25807 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
25810 2002-06-21 Martin Baulig <martin@gnome.org>
25812 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
25813 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
25814 (Expression.ConvertReferenceExplicit): Likewise.
25816 * expression.cs (ElementAccess.DoResolve): Likewise.
25817 (ElementAccess.DoResolveLValue): Likewise.
25819 2002-06-10 Martin Baulig <martin@gnome.org>
25821 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
25822 add the "value" parameter to the parameter list.
25824 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
25827 2002-06-19 Miguel de Icaza <miguel@ximian.com>
25829 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
25830 the argument to an int, uint, long or ulong, per the spec. Also
25831 catch negative constants in array creation.
25833 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
25835 * class.cs: do not allow the same interface to appear twice in
25836 the definition list.
25838 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
25840 * ecore.cs: don't use ldlen with System.Array.
25842 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
25844 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
25846 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
25848 * modifiers.cs: produce correct field attributes for protected
25849 internal. Easy fix so miguel can work on ther harder stuff:-)
25851 2002-06-18 Miguel de Icaza <miguel@ximian.com>
25853 * pending.cs: New file. Move the code from class.cs here.
25854 Support clearning the pending flag for all methods (when not doing
25855 explicit interface implementation).
25857 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
25859 * rootcontext.cs: added a couple more types needed to bootstrap.
25861 2002-06-17 Miguel de Icaza <miguel@ximian.com>
25863 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
25864 constructor in the type, instead of any constructor in the type
25865 hierarchy. Thanks to Paolo for finding this bug (it showed up as
25866 a bug in the Mono runtime when applying the params attribute).
25868 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25869 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
25871 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
25873 * expression.cs (Unary.ResolveOperator): Use TypeManager
25874 to resolve the type.
25876 2002-06-13 Ravi Pratap <ravi@ximian.com>
25878 * cs-parser.jay (enum_member_declaration): Pass in the attributes
25881 * enum.cs (AddEnumMember): Add support to store the attributes associated
25882 with each member too.
25884 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
25885 field builders too - this takes care of the enum member case.
25887 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
25889 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
25890 address-of operator on both value types and pointers.
25892 2002-06-10 Martin Baulig <martin@gnome.org>
25894 * interface.cs (Interface.PopulateIndexer): Add the indexer's
25895 PropertyBuilder to the `property_builders' list.
25897 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
25898 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
25899 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
25900 find any indexers which are inherited from an interface.
25902 2002-06-09 Martin Baulig <martin@gnome.org>
25904 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
25905 the same type as the constant if necessary. There's also a test-130.cs
25908 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
25910 * typemanager.cs (TypeManager.ChangeType): Previously known as
25911 Enum.ChangeEnumType().
25913 2002-06-09 Martin Baulig <martin@gnome.org>
25915 * expression.cs (Cast.TryReduce): Added support for consts.
25917 2002-06-08 Ravi Pratap <ravi@ximian.com>
25919 * class.cs (Accessor): Hold attributes information so we can pass
25922 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
25923 Modify to pass in attributes attached to the methods.
25925 (add_accessor_declaration, remove_accessor_declaration): Ditto.
25927 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
25928 to handle the Accessor kind :-)
25930 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
25932 2002-06-08 Martin Baulig <martin@gnome.org>
25934 * expression.cs (Unary.TryReduceNegative): Added support for
25937 2002-06-08 Martin Baulig <martin@gnome.org>
25939 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
25940 name can't be found in the `defined_names' - the caller will do a
25941 MemberLookup in this case and thus find methods in System.Enum
25942 such as Enum.IsDefined().
25944 2002-06-08 Martin Baulig <martin@gnome.org>
25946 * enum.cs (Enum.ChangeEnumType): This is a custom version of
25947 Convert.ChangeType() which works with TypeBuilder created types.
25948 (Enum.LookupEnumValue, Enum.Define): Use it here.
25950 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
25951 `TypeBuilder.BaseType != null' check.
25952 (TypeContainer.FindMembers): Only lookup parent members if we
25953 actually have a parent.
25954 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
25955 (ConstructorInitializer.Resolve): Likewise.
25957 * interface.cs (Interface.FindMembers): Added
25958 `TypeBuilder.BaseType != null' check.
25960 * rootcontext.cs (RootContext.ResolveCore): Added
25961 "System.Runtime.CompilerServices.IndexerNameAttribute" to
25962 classes_second_stage.
25964 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
25965 debug_type and trace_type when compiling with --nostdlib.
25967 2002-06-07 Martin Baulig <martin@gnome.org>
25969 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
25970 (AddField): Set it to true when adding a non-static field.
25971 (DefineType): Use `have_nonstatic_fields' to find out whether we
25972 have non-static fields, not `Fields != null'.
25974 2002-06-02 Miguel de Icaza <miguel@ximian.com>
25976 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
25977 dereferencing a null on the static-field code path)
25979 2002-05-30 Martin Baulig <martin@gnome.org>
25981 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
25982 to take command line arguments. Use reflection to call the new
25983 custom `Initialize' function on the symbol writer and pass it the
25984 command line arguments.
25986 * driver.cs (--debug-args): New command line argument to pass command
25987 line arguments to the symbol writer.
25989 2002-05-28 Miguel de Icaza <miguel@ximian.com>
25991 * assign.cs (DoResolve): Forgot to do the implicit conversion to
25992 the target type for indexers and properties. Thanks to Joe for
25995 2002-05-27 Miguel de Icaza <miguel@ximian.com>
25997 * typemanager.cs (MethodFlags): returns the method flags
25998 (Obsolete/ShouldIgnore) that control warning emission and whether
25999 the invocation should be made, or ignored.
26001 * expression.cs (Invocation.Emit): Remove previous hack, we should
26002 not do this on matching a base type, we should do this based on an attribute
26004 Only emit calls to System.Diagnostics.Debug and
26005 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26006 on the command line.
26008 * rootcontext.cs: Global settings for tracing and debugging.
26010 * cs-tokenizer.cs (define): New utility function to track
26011 defines. Set the global settings for TRACE and DEBUG if found.
26013 2002-05-25 Ravi Pratap <ravi@ximian.com>
26015 * interface.cs (Populate*): Pass in the TypeContainer as well as
26016 the DeclSpace as parameters so that we can create EmitContexts and
26017 then use that to apply attributes etc.
26019 (PopulateMethod, PopulateEvent, PopulateProperty)
26020 (PopulateIndexer): Apply attributes everywhere.
26022 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26025 (ApplyAttributes): Update accordingly.
26027 We now apply interface attributes for all members too.
26029 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26031 * class.cs (Indexer.Define); Correctly check if we are explicit
26032 implementation (instead of checking the Name for a ".", we
26033 directly look up if the InterfaceType was specified).
26035 Delay the creation of the PropertyBuilder.
26037 Only create the PropertyBuilder if we are not an explicit
26038 interface implementation. This means that explicit interface
26039 implementation members do not participate in regular function
26040 lookups, and hence fixes another major ambiguity problem in
26041 overload resolution (that was the visible effect).
26043 (DefineMethod): Return whether we are doing an interface
26046 * typemanager.cs: Temporary hack until we get attributes in
26047 interfaces (Ravi is working on that) and we get IndexerName
26048 support in interfaces.
26050 * interface.cs: Register the indexers as properties.
26052 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26053 warning, I have verified that this is a bug in the .NET runtime
26054 (JavaScript suffers of the same problem).
26056 * typemanager.cs (MemberLookup): When looking up members for
26057 interfaces, the parent of an interface is the implicit
26058 System.Object (so we succeed in searches of Object methods in an
26059 interface method invocation. Example: IEnumerable x; x.ToString
26062 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26064 * class.cs (Event): Events should also register if they do
26065 implement the methods that an interface requires.
26067 * typemanager.cs (MemberLookup); use the new GetInterfaces
26070 (GetInterfaces): The code used to lookup interfaces for a type is
26071 used in more than one place, factor it here.
26073 * driver.cs: Track the errors at the bottom of the file, we kept
26076 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26077 instance if the method we are calling is static!
26079 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26081 * attribute.cs (ApplyAttributes): Make this function filter out
26082 the IndexerName attribute (as that attribute in reality is never
26083 applied) and return the string constant for the IndexerName
26086 * class.cs (TypeContainer.Emit): Validate that all the indexers
26087 have the same IndexerName attribute, and if so, set the
26088 DefaultName attribute on the class.
26090 * typemanager.cs: The return value might contain other stuff (not
26091 only methods). For instance, consider a method with an "Item"
26092 property and an Item method.
26094 * class.cs: If there is a problem with the parameter types,
26097 2002-05-24 Ravi Pratap <ravi@ximian.com>
26099 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26100 looks at user defined conversion after making a call to
26101 StandardConversionExists - we need this for overload resolution.
26103 * expression.cs : Update accordingly the various method calls.
26105 This fixes 2 bugs filed against implicit user defined conversions
26107 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26109 * statement.cs: Track the result of the assignment.
26111 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26113 * expression.cs (MemberAccess): Improved error reporting for
26114 inaccessible members.
26116 2002-05-22 Martin Baulig <martin@gnome.org>
26118 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26119 itself with debugging support.
26121 2002-05-22 Martin Baulig <martin@gnome.org>
26123 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26124 Removed, this isn't needed anymore.
26126 2002-05-20 Martin Baulig <martin@gnome.org>
26128 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26129 be underlying type for an enum.
26131 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26133 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26134 that splits out the loading of just the core types.
26136 * rootcontext.cs (ResolveCore): Split the struct resolution in
26137 two, so we can load the enumeration underlying types before any
26140 * expression.cs (Is): Bandaid until we fix properly Switch (see
26141 bug #24985 for details).
26143 * typemanager.cs (ImplementsInterface): The hashtable will contain
26144 a null if there are no interfaces implemented.
26146 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26148 * cs-parser.jay (indexer_declarator): It is fine to have array
26151 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26153 * typemanager.cs: (RegisterBuilder): New function used to register
26154 TypeBuilders that implement interfaces. Since
26155 TypeBuilder.GetInterfaces (as usual) does not work with lame
26157 (AddUserType): register interfaces.
26159 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26160 dealing with TypeBuilder. Also, arrays are showing up as
26161 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26162 methods can not be invoked on them!
26164 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26165 (ImplicitReferenceConversionExists): Split out from
26166 StandardConversionExists.
26168 * expression.cs (As): We were only implementing one of the three
26169 cases for the as operator. We now implement them all.
26170 (Is): Implement the various other cases for Is as well.
26172 * typemanager.cs (CACHE): New define used to control if we want or
26173 not the FindMembers cache. Seems to have a negative impact on
26174 performance currently
26176 (MemberLookup): Nested types have full acess to
26177 enclosing type members
26179 Remove code that coped with instance/static returns for events, we
26180 now catch this in RealFindMembers.
26182 (RealFindMembers): only perform static lookup if the instance
26183 lookup did not return a type or an event.
26185 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26187 * assign.cs (CompoundAssign): We pass more semantic information
26188 now to Compound Assignments than we did before: now we have all
26189 the information at hand, and now we resolve the target *before* we
26190 do the expression expansion, which allows the "CacheValue" method
26191 to have the effect we intended (before, a [x] += 1 would generate
26192 two differen ArrayAccess expressions from the ElementAccess,
26193 during the resolution process).
26195 (CompoundAssign.DoResolve): Resolve target and original_source here.
26197 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26199 * expression.cs (ArrayAccess): dropped debugging information.
26201 * typemanager.cs: Small bug fix: I was always returning i_members,
26202 instead of one of i_members or s_members (depending on which had
26205 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26206 method is invoked before any code generation takes place, and it
26207 is a mechanism to inform that the expression will be invoked more
26208 than once, and that the method should use temporary values to
26209 avoid having side effects
26211 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26213 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26216 * expression.cs (Indirection, ArrayAccess): Add support for
26217 CacheTemporaries in these two bad boys.
26219 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26220 ldobj or ldind_ref.
26221 (StoreFromPtr): Handle stobj as well.
26223 * expression.cs (UnaryMutator): Share more code.
26225 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26226 down: I was not tracking the Filter function as well, which
26227 was affecting the results of the cache.
26229 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26231 * attribute.cs: Remove the hack to handle the CharSet property on
26234 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26236 * attribute.cs (DoResolve): More uglyness, we now only try to
26237 resolve the attribute partially, to extract the CharSet
26238 information (only if we are a StructLayout attribute). Otherwise
26240 (GetExtraTypeInfo): Add some code to conditionally kill in the
26241 future this. I am more and more convinced that the .NET
26242 framework has special code to handle the attribute setting on
26245 * expression.cs (IsParamsMethodApplicable): Revert my previous
26246 foreach change here, it was wrong.
26248 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26250 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26251 (pp_expr): do not abort on unknown input, just return.
26252 (eval): abort if there are pending chars.
26254 * attribute.cs (Attribute.Resolve): Positional parameters are
26255 optional. Deal with that case.
26257 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26258 the Ansi/Unicode/Auto information for the type.
26260 (TypeContainer.DefineType): instantiate the EmitContext here, as
26261 we will be using it during the type definition (to resolve
26262 attributes) and during the emit phase.
26264 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26265 to pull type information out of the attributes
26267 (Attribute.Resolve): track the constructor builder, and allow for
26268 multiple invocations (structs and classes will use this).
26270 * ecore.cs (MemberLookupFinal): new version with all the
26271 parameters customizable.
26273 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26274 constructors. Return if the result value is null (as the error
26275 would have been flagged already by MemberLookupFinal)
26277 Do not allow instances of abstract classes or interfaces to be
26280 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26281 We have to compare the assembly property here when dealing with
26282 FamANDAssem and Assembly access modifiers, because we might be
26283 creating an assembly from *modules* (that means that we are not
26284 getting TypeBuilders for types defined in other modules that are
26285 part of this assembly).
26287 (Method.Emit): If the method is marked abstract and has a body,
26290 (TypeContainer.DefineMembers): If both the defined member and the
26291 parent name match are methods, then do not emit any warnings: let
26292 the Method.Define routine take care of flagging warnings. But if
26293 there is a mismatch (method overrides something else, or method is
26294 overriwritten by something, then emit warning).
26296 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26297 set to null, this means `do not check for the return type on the
26300 (Method.Define): set the return type for the method signature to
26301 null, so that we get methods with the same name and parameters and
26302 different return types. This is used to flag warning 114 (you are
26303 hiding a method, and you probably want to use the new/override
26306 * typemanager.cs (MemberLookup): Implemented proper access
26307 control, closing a long standing set of bug reports. The problem
26308 was that the Framework only has two bits: Public and NonPublic,
26309 and NonPublic includes private and protected methods, but we need
26310 to enforce the FamANDAssem, FamOrAssem and Family.
26312 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26314 * statement.cs (GotoCase): Return true: Ammounts to giving up
26315 knowledge on whether we return or not, and letting the other case
26316 be responsible for it.
26318 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26320 * driver.cs: Do not load directories for each file processed, only
26321 do it if there is a pattern.
26323 * ecore.cs: Report readonly assigns here as well, as we might have
26324 been resolved only by MemberAccess.
26326 (SimpleName.SimpleNameResolve): Also be useful for LValue
26327 resolution. We need this to propagate assign to local readonly variables
26329 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26330 do not want to reuse potential criteria memory.
26332 * class.cs (MyEventBuilder): Set reflected_type;
26334 * ecore.cs (Constantify): Added support for constifying bools.
26336 (RootContext.LookupType): Added a cache for values looked up in
26337 the declaration space.
26339 * typemanager.cs (FindMembers): Now is a front-end to
26340 RealFindMembers, and provides a two-level hashtable-based cache to
26343 15% performance improvement: from 22.5 to 19.2 seconds.
26345 * expression.cs (IsParamsMethodApplicable): use foreach.
26346 (Invocation.DoResolve): ditto.
26347 (New.DoResolve): ditto.
26348 (ArrayCreation.DoResolve): ditto.
26350 * ecore.cs (FindMostEncompassingType): use foreach.
26352 * delegate.cs (NewDelegate.DoResolve): Use foreach
26354 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26355 (RemoveMethods): use foreach.
26357 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26358 nested foreach statements instead of for, and also break out of
26359 the inner loop once a match is found.
26361 (Invocation.OverloadResolve): Use foreach, simplify the code.
26363 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26365 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26366 we actually unwrap the expression to allow for extra information
26369 * expression.cs: Use Shr_Un on unsigned operations.
26371 2002-05-08 Ravi Pratap <ravi@ximian.com>
26373 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26374 applicable operators was not being considered correctly. This closes
26375 the bug Miguel reported.
26377 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26379 * attribute.cs: check that the type derives from System.Attribute
26380 and report the correct error in that case (moved the duplicate code to
26381 its own method, too).
26383 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26385 * attribute.cs: lookup attribute type name as the spec says: first the
26386 bare attribute name and then name + "Attribute" (nant compiles with
26387 mcs after this fix).
26389 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26391 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26392 Because of the way we parse things, we should try to see if a
26393 UIntConstant can fit in an integer.
26395 2002-05-07 Ravi Pratap <ravi@ximian.com>
26397 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26398 when we are in an explicit context.
26400 (ConvertReferenceExplicit): When converting from Iface type S to Class
26401 T make sure the rules are implemented as an OR.
26403 * parameter.cs (ParameterType): Make it a property for now although the
26404 purpose really isn't anything immediate.
26406 * expression.cs (Is*Applicable): Do better checking on the parameter type
26407 of a ref/out parameter. The ones from the system assemblies are already
26408 marked with the correct type so we don't need to do any correction.
26410 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26411 the object type is standard too so include that.
26413 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26415 * ecore.cs (StandardConversionExists): Augment with missing code:
26416 deal with IntConstant, LongConstants and Enumerations.
26418 * assign.cs: Report the error, instead of failing silently
26420 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26421 typecontainer that they are declared, because the
26422 typecontainer/namespace will have the list of using clauses that
26423 need to be applied.
26425 Assembly Attributes were escaping the normal registration
26428 (EmitCode): Apply attributes within an EmitContext that represents
26429 the container they were declared on.
26431 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26433 2002-05-06 Ravi Pratap <ravi@ximian.com>
26435 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26436 Revamp completely - make much cleaner as we now operate only
26439 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26440 to implement the logic detailed in the spec more correctly.
26442 (UserDefinedConversion): Update accordingly.
26444 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26446 * statement.cs: Return flow analysis information up.
26448 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26451 (token): Do not consume an extra character before calling
26454 2002-05-06 Piers Haken <piersh@friskit.com>
26456 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26458 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26460 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26461 EmitContext during the instance constructor initializer
26462 resolution, to stop access to instance variables.
26464 This is mandated by the spec, last paragraph of the `constructor
26465 initializers' section.
26467 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26469 * cs-parser.jay, class.cs (Accessor): new class used to represent
26470 an accessor (get or set). In the past we used `null' to represent
26471 a missing accessor. But this is ambiguous because there was no
26472 way to tell in abstract indexers/properties if one of them was
26475 Now there is a way of addressing that.
26477 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26478 instead of FindMembers.
26480 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26481 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26483 * attribute.cs: Treat indexers and properties as the same in terms
26484 of applying attributes
26486 * ecore.cs (FindMostEncompassedType): Use statically initialized
26487 EmptyExpressions()s like we do elsewhere to avoid creating useless
26488 objects (and we take this out of the tight loop).
26490 (GetConversionOperators): Move the code to extract the actual
26491 operators to a separate routine to clean things up.
26493 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26495 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26496 events are always registered FieldBuilders.
26498 * class.cs (FieldBase): New class shared by Fields
26500 * delegate.cs: If we are a toplevel delegate, use our full name.
26501 If we are a nested delegate, then only use our tail name.
26503 2002-05-02 Ravi Pratap <ravi@ximian.com>
26505 * expression.cs (IsApplicable): Ensure that we add the "&" to
26506 ref/out types before comparing it with the type of the argument.
26508 (IsParamsMethodApplicable): Ditto.
26510 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26513 * delegate.cs : Handle the case when we have more than one applicable
26514 method. Flag an error only when we finish checking all.
26516 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26518 * expression.cs: Add support for boolean static initializers.
26520 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26522 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26524 * parameter.cs (ComputeParameterTypes,
26525 ComputeAndDefineParameterTypes): Better error handling: now we
26526 clear the `types' cache if we fail during any of the type lookups.
26527 We also return the status code correctly to our caller
26529 * delegate.cs: If we fail to define a delegate, abort the extra
26532 * expression.cs (Binary.ResolveOperator): for
26533 operator==(object,object) and operator !=(object, object) we also
26534 have to verify that there is an implicit conversion from one to
26537 (ArrayAccess.DoResolve): Array Access can operate on
26540 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26542 * assign.cs (CompoundAssign): A new class used as a "flag" that
26543 the assignment actually is happening as part of a compound
26544 assignment operator.
26546 During compound assignment, a few new rules exist to enable things
26553 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26554 to the type of x) if y is implicitly convertible to the type of x,
26555 and the operator is a builtin operator and the return type of the
26556 operator is explicitly convertible to the type of x.
26558 * rootcontext.cs: Reset warning level to 2. 4 catches various
26559 "interesting" features in mcs, we must clean this up at some
26560 point, but currently am trying to kill other bugs ;-)
26562 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26563 in container classes as well.
26565 * expression.cs (Binary.ResolveOperator): Handle string case
26566 before anything else (as operator overloading does emit an error
26567 before doing anything else).
26569 This code could go away when we move to a table driven model, but
26570 i could not come up with a good plan last night.
26572 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26574 * typemanager.cs (CSharpName): reimplementation using regex.
26575 * class.cs: added null check for fields in Emit
26576 * rootcontext.cs: set warninglevel to 4
26578 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26580 * typemanager.cs (CSharpName): reimplemented with Lupus
26583 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26585 * statement.cs (If): correclty implement Resolve, because we were
26586 not catching sem errors in there. The same process is needed
26588 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26591 (Statement.Warning_DeadCodeFound): Factorize code.
26592 (While): Report dead code here too.
26594 (Statement): Added Resolve virtual method to allow
26595 for resolution split from the emit code.
26597 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26599 * statement.cs (EmitBoolExpression): No longer try to resolve the
26601 (MakeBoolean): New utility function that resolve, implicitly
26602 converts to boolean and tags the expression.
26605 (If, Do): Implement dead code elimination.
26606 (While): Implement loop inversion
26608 (Do, While, For, If): Resolve the expression prior to calling our
26611 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26614 - added method Report28 (warning: program has more than one entry point)
26615 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26616 - modified method Method.Define, the part at the end of the method
26618 * rootcontext.cs: added static public Location EntryPointLocation;
26620 * ../errors/cs0028.cs : Add test case for the above warning.
26623 - modified method CSharpName to allow arrays of primitive type to
26624 be printed nicely (e.g. instead of System.Int32[][] it now prints
26626 - added method CSharpSignature: returns the signature of a method
26627 in string format to be used in reporting errors, warnings, etc.
26629 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26632 2002-04-26 Ravi Pratap <ravi@ximian.com>
26634 * delegate.cs (Define): Fix extremely silly bug where I was
26635 setting the type of the 'object' parameter of the BeginInvoke
26636 method to System.IAsyncResult instead of System.Object ;-)
26638 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26640 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26643 (Constructor.Emit): return if we fail to initialize the
26644 constructor. Another door closed!
26646 * expression.cs (New.DoResolve): Improve error message (from -6 to
26647 1501). Use DeclaredOnly lookup to find the exact constructor.
26649 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26650 loop. This is useful.
26652 * cs-parser.jay: Adjust the default parameters so that destructors
26653 have the proper signature.
26655 2002-04-26 Martin Baulig <martin@gnome.org>
26657 * driver.cs (LoadAssembly): If `assembly' contains any characters
26658 which are only valid in path names and not in assembly names
26659 (currently slash, backslash and point), use Assembly.LoadFrom ()
26660 instead of Assembly.Load () on the `assembly' (before iteration
26661 over the link_paths).
26663 2002-04-26 Martin Baulig <martin@gnome.org>
26665 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26667 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26669 * class.cs (Property): use the new typemanager.MemberLookup
26671 (TypeContainer.MemberLookup): Implement using the
26672 TypeManager.MemberLookup now.
26674 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26675 and return MemberInfos, so that these can be used without an
26676 EmitContext (what we had before).
26678 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26680 * expression.cs: Fix the case where the argument to params if the
26681 type of the params. I omitted handling this before. Fixed
26683 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26685 * driver.cs: Call BootCorlib_PopulateCoreType
26687 * class.cs (Property.CheckBase): Check for properties only, not
26690 * interface.cs: Temporary hack: try/catch around the
26691 CustomAttributeBuilder, because I am getting an exception that I
26694 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26695 types whose definitions are required to be there (attributes are
26696 defined before standard types).
26698 Compute definitions as we boot the various types, as they are used
26699 immediately (value_type class will need object_type, but if we do
26700 not initialize object_type, we will pass a null, which will let
26701 the runtime pick the System.Object from the existing corlib, which
26702 is not what we want).
26704 2002-04-22 Patrik Torstensson <totte@labs2.com>
26706 * cs-tokenizer.cs: fixed a number of trim() issues.
26708 2002-04-22 Ravi Pratap <ravi@ximian.com>
26710 * expression.cs (Argument.Type): Ensure that we return the correct
26711 type when we have out or ref parameters [in which case we
26714 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26716 * class.cs (Property, Indexer): Allow extern modifier in there.
26718 * typemanager.cs (InitBaseTypes): Initializes object_type and
26719 value_type, since those will be used early on during the bootstrap
26720 process to compile corlib.
26722 (InitCoreTypes): Move code from here to InitBaseTypes.
26724 2002-04-21 Miguel de Icaza <miguel@ximian.com>
26726 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
26727 single-dimension arrays as using the ldlen opcode.
26729 Daniel Lewis discovered this optimization.
26731 * typemanager.cs: Add signature for System.Array::get_Length
26733 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26735 * statement.cs: report the error when the foreach does not apply to an
26736 array nor a collection.
26738 2002-04-19 Miguel de Icaza <miguel@ximian.com>
26740 * expression.cs: Add implicit conversions to the operator ~.
26742 * constant.cs (DecimalConstant.Emit): Emit decimal value.
26744 * typemanager.cs: Locate the decimal constructor.
26746 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26748 * attribute.cs: use the new property of TypeOf.
26749 * expression.cs: added 'get' property around typearg.
26751 These changes fix a build breaker reported by NickD. Is this the
26752 correct way to fix? If not, please, revert my changes and make it
26755 2002-04-17 Miguel de Icaza <miguel@ximian.com>
26757 * attribute.cs: Add support for typeof in attribute invocations.
26758 I am not sure that this is right though.
26760 2002-04-14 Duncan Mak <duncan@ximian.com>
26762 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
26763 Binary.Operator.Division case.
26765 2002-04-13 Ravi Pratap <ravi@ximian.com>
26767 * class.cs (DefineType): Ensure that we do a proper check on
26768 attribute types and also register it with the TypeManager.
26770 (TypeContainer.Targets): The default for attribute types is
26771 AttributeTargets.All.
26773 * attribute.cs (ApplyAttributes): Registering the attribute type
26774 is done elsewhere, not when we discover we have a Usage attribute.
26776 2002-04-12 Ravi Pratap <ravi@ximian.com>
26778 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
26779 and get rid of is_delegate parameter.
26781 * everywhere : update.
26783 2002-04-12 Ravi Pratap <ravi@ximian.com>
26785 * cs-parser.jay (compilation_unit): Revamp completely to use
26786 some new ideas that I got from Rhys' grammar to solve the problems
26787 with assembly level attributes.
26789 (outer_declaration): New grammar production.
26791 (attribute_sections): Add.
26793 (opt_attributes): Base on attribute_sections
26795 (namespace_declaration): Allow opt_attributes to tackle the case
26796 when we have assembly level attributes - we are clever in this
26799 * attribute.cs (ApplyAttributes): Do not worry about assembly
26800 attributes in the non-global context.
26802 * rootcontext.cs (AddGlobalAttributes): Go back to using this
26803 instead of SetGlobalAttributes.
26805 * class.cs, rootcontext.cs : Ensure we define and generate
26806 attribute types before anything else.
26808 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
26809 and flag the new error -20 for the case when the attribute type
26810 does not have valid targets specified. csc does not catch this.
26812 * ../errors/errors.txt : update for error # -20
26814 2002-04-11 Ravi Pratap <ravi@ximian.com>
26816 * support.cs (InternalParameters.ParameterModifier): Do some null
26817 checking and return sane values.
26819 * class.cs (Method.Define): If we are a PInvoke method, ensure
26820 that we are static and extern. Report error # 601
26822 * ../errors/cs0601.cs : Add test case for the above error.
26824 2002-04-07 Ravi Pratap <ravi@ximian.com>
26826 * rootcontext.cs (attribute_types): We need to keep type of
26827 all attribute types separately and emit code for them first.
26829 (RegisterAttribute) : Implement.
26831 * class.cs (DefineType): Check if the current Type is a custom
26832 attribute type and register it accordingly.
26834 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
26835 adding the first attribute twice and rename to
26837 (SetGlobalAttributes): this.
26839 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
26842 * attribute.cs (ApplyAttributes): Take an additional argument telling us
26843 if we are processing global arguments. Hmm, I am unsure of this.
26845 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26847 * expression.cs: added static array of strings to avoid calling
26848 Enum.ToString () for Operator in Binary. Significant recover of
26851 2002-04-10 Miguel de Icaza <miguel@ximian.com>
26853 * class.cs (FindMembers): Allow the Builders of the various
26854 members to be null. If they are skip them. This only happens
26855 during the PInvoke declaration.
26857 2002-04-09 Miguel de Icaza <miguel@ximian.com>
26859 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
26860 failure, so we do not keep going afterwards.
26862 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
26863 wanted to pass `false' as the `is_delegate' argument. If this is
26864 the case, why not use delegate_type == null to mean `is_delegate =
26865 false' and anything else as is_delegate = true.
26867 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
26869 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
26870 code for the section, not the beginning of the tests.
26872 2002-04-08 Miguel de Icaza <miguel@ximian.com>
26874 * cfold.cs: Handle operator + (Enum x, Underlying x)
26876 * expression.cs (Binary): same. Warn about errors where we have
26877 Enum/Enum in operator + as well.
26879 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
26882 - added support for switch(bool)
26883 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
26884 - add TableSwitchEmit() to handle table-based switch statements
26886 2002-04-05 Ravi Pratap <ravi@ximian.com>
26888 * expression.cs (Invocation.OverloadResolve): Factor out code which
26889 does parameter compatibility checking with arguments so that we can
26890 re-use the code even from Delegate.VerifyApplicability
26892 (VerifyArgumentsCompat): Move above code here.
26894 * delegate.cs (VerifyApplicability): Get rid of duplicate code
26895 and instead make a call to the above method.
26897 2002-03-31 Ravi Pratap <ravi@ximian.com>
26899 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
26900 We use it to keep track of classes which are attribute types.
26902 2002-04-02 Miguel de Icaza <miguel@ximian.com>
26904 * delegate.cs (Delegate.Define): Correctly define the types in the
26905 presence of fixed and array parameters.
26907 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
26910 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
26911 include NonPublic after the first iteration.
26913 * class.cs (Indexer.CheckBase): Only check if both parents are
26916 * cs-parser.jay (accessor_body): If empty, set to null.
26918 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
26919 same code path here to resolve constants names that we did have in
26920 MemberAccess.DoResolve. There is too much code duplicated here.
26922 2002-04-01 Miguel de Icaza <miguel@ximian.com>
26924 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
26926 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
26929 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
26930 tokens, numbers and strings.
26932 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
26935 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
26936 asyncronous parameters and the regular parameters.
26938 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
26939 specify the target directory.
26941 * expression.cs: (This.DoResolve): Simplify
26942 (As.Emit): Optimize, do not generate IsInst if the expression is
26943 always of the given type.
26945 (Is.DoResolve): Bug fix, we were reporting both always/never for
26948 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
26949 creating too many unnecessary arrays.
26951 2002-03-31 Miguel de Icaza <miguel@ximian.com>
26953 * class.cs (EmitFieldInitializer): Use Assign expression to assign
26954 fields instead of rolling our own initializer. Takes care of all
26955 implicit conversions, and drops unnecessary static checks/argument.
26957 2002-03-31 Dick Porter <dick@ximian.com>
26959 * driver.cs: use the GetDirectories() return values properly, and
26960 use "/" as path separator.
26962 2002-03-30 Miguel de Icaza <miguel@ximian.com>
26964 * expression.cs (Unary): Optimize - - expr into expr.
26965 (Binary): Optimize a + (-b) into a -b.
26967 * codegen.cs (CodeGen): Made all methods static.
26969 2002-03-29 Miguel de Icaza <miguel@ximian.com>
26973 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
26974 TypeBuilder property.
26976 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
26979 * tree.cs: Removed the various RecordXXXX, and replaced with a
26980 single RecordDecl. Removed all the accessor methods, and just
26981 left a single access point Type
26983 * enum.cs: Rename DefineEnum to DefineType.
26985 * decl.cs: New abstract method `DefineType' used to unify the
26986 Defines for Enumerations, Interfaces, TypeContainers and
26989 (FindType): Moved LookupInterfaceOrClass here. Moved the
26990 LookupBaseClasses method that used to live in class.cs and
26991 interface.cs here, and renamed to FindType.
26993 * delegate.cs: Implement DefineType. Take advantage of the
26994 refactored pattern for locating the parent builder without taking
26995 the parent_builder argument (which we know does not work if we are
26996 nested, and triggering a toplevel definition).
26998 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27000 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27001 accessibility of a member has changed during override and report
27004 * class.cs (Method.Define, Property.Define): Only complain on
27005 overrides if the method is private, any other accessibility is
27006 fine (and since we just checked the permission is the same, we are
27009 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27010 and elif are processed always. The other pre-processing
27011 directives are only processed if we are "taking" the path
27013 2002-03-29 Martin Baulig <martin@gnome.org>
27015 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27016 current location is not Null.
27018 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27019 a separate method so we can profile it.
27021 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27022 `span.Seconds' are just seconds, but no minutes or hours.
27023 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27025 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27027 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27028 Remove the gratuitous set of Final:
27030 // If an interface implementation, then we can set Final.
27031 if (((flags & MethodAttributes.Abstract) == 0) &&
27032 implementing.DeclaringType.IsInterface)
27033 flags |= MethodAttributes.Final;
27035 I do not know what I was smoking when I used that.
27038 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27039 step into fixing the name resolution issues for delegates and
27040 unifying the toplevel name resolution.
27042 2002-03-28 Martin Baulig <martin@gnome.org>
27044 * class.cs (Method.Emit): If we have a symbol writer, call its
27045 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27046 tell it about the current method.
27048 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27049 writer that we're going to emit the first byte of IL code for a new
27050 statement (a new source line).
27051 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27052 EmitContext.Mark() before emitting any code.
27054 * location.cs (SymbolDocument): Return null when we're Null.
27056 * statement.cs (Statement): Moved the `Location loc' variable here.
27057 (Statement.EmitBoolExpression): If we have a symbol writer, call
27058 ec.Mark() before emitting any code to tell it that we're at the
27059 beginning of a new statement.
27060 (StatementExpression): Added `Location' argument to the constructor.
27061 (Block): Added public readonly variable `StartLocation' and public
27062 variable `EndLocation'. The latter is to be set using SetEndLocation().
27063 (Block): Added constructor which takes a start and end location.
27064 (Block.SetEndLocation): New method. This sets the end location.
27065 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27066 local variables we create.
27067 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27068 each statement and do also mark the begin and end of the block.
27070 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27071 tell it the current lexer.Location, use Location.Null for the end of the
27073 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27074 current block, set its end location using SetEndLocation().
27075 (statement_expression): StatementExpression constructor now takes the
27076 lexer.Location as additional argument.
27077 (for_statement, declare_local_variables): Likewise.
27078 (declare_local_variables): When creating a new implicit block, use the
27079 new Block constructor and pass it the lexer.Location.
27081 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27083 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27084 members also on the parent interfaces recursively.
27086 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27088 * report.cs: Use new formats, since Gonzalo finished the missing
27091 * expression.cs (Binary.ResolveOperator): added missing operator|
27092 operator& and operator^ for bool/bool.
27094 * cs-parser.jay: CheckDef now takes a Location argument that is
27095 used to report errors more precisly (instead of reporting the end
27096 of a definition, we try to track something which is a lot closer
27097 to the source of the problem).
27099 * cs-tokenizer.cs: Track global token use, so we can properly flag
27100 the use of #define/#undef after the first token has been seen.
27102 Also, rename the reportXXXX to Error_DescriptiveName
27104 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27105 TypeContainer, so that Enum and Interface can use this too.
27107 * class.cs (TypeContainer.LookupInterfaceOrClass,
27108 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27109 `builder' argument. Typically this was used to pass the parent
27110 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27113 The problem is that a nested class could trigger the definition of
27114 a toplevel class, and the builder would be obviously wrong in that
27117 So we drop this argument, and we compute dynamically the
27118 TypeBuilder/ModuleBuilder (the correct information was available
27119 to us anyways from DeclSpace.Parent)
27121 * interface.cs (Interface.DefineInterface): Drop builder
27122 parameter cleanup like class.cs
27124 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27127 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27130 (Try.Emit): Propagate the returns value from the statement.
27132 (Return.Emit): Even if we are leavning
27134 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27136 * modifiers.cs: Fix the computation of MethodAttributes flags.
27138 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27140 * driver.cs: allow compilation of files that start with '/'.
27141 Add a default case when checking the argument of --target.
27143 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27145 * interface.cs: Implement the same search algorithm for types in
27146 the interface code.
27148 * delegate.cs: Do not allow multiple definition.
27150 * Recovered ChangeLog that got accidentally amputated
27152 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27154 * rootcontext.cs: Load manually enum to allow core classes to
27155 contain enumerations.
27157 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27158 Update to new static methods in TypeManager.
27160 * typemanager.cs (GetMethod, GetConstructor): Use our
27161 implementation of FindMembers to find the members, since during
27162 corlib compilation, the types are TypeBuilders and GetMethod and
27163 GetConstructor do not work.
27165 Make all methods in TypeManager static.
27167 (InitCodeHelpers): Split the functionality from
27168 the InitCodeTypes function.
27170 * driver.cs: Call InitCodeHelpers after we have populated the
27173 * cs-parser.jay (delegate_declaration): we did not used to compute
27174 the delegate name correctly for void delegates.
27176 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27178 * rootcontext.cs (RootContext): Init the interface_resolve_order
27179 and type_container_resolve_order always.
27181 (ResolveCore, BootstrapCorlib_ResolveClass,
27182 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27183 compiler when compiling with --nostdlib
27185 * class.cs (TypeContainer.DefineType): Check that our parent is
27186 not null. This test is most important when we are bootstraping
27189 * codegen.cs: Split out the symbol writing code.
27191 2002-03-25 Martin Baulig <martin@gnome.org>
27193 * driver.cs (-g): Made -g an alias for --debug.
27195 2002-03-24 Martin Baulig <martin@gnome.org>
27197 * codegen.cs (SymbolWriter): New public variable. Returns the
27198 current symbol writer.
27199 (CodeGen): Added `bool want_debugging_support' argument to the
27200 constructor. If true, tell the ModuleBuild that we want debugging
27201 support and ask it for the ISymbolWriter.
27202 (Save): If we have a symbol writer, call it's Close() method after
27203 saving the assembly.
27205 * driver.c (--debug): New command line argument to create a
27206 debugger information file.
27208 * location.cs (SymbolDocument): New public property. Returns an
27209 ISymbolDocumentWriter object for the current source file or null
27210 if we don't have a symbol writer.
27212 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27214 * driver.cs (LoadAssembly): Correctly return when all the paths
27215 have been tried and not before.
27217 * statement.cs (Switch.Emit): return the actual coverage for this
27218 statement (returns/not-returns)
27220 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27221 switch of the statement if we are the last switch section. That
27222 kills two problems: try/catch problems (we used to emit an empty
27223 nop at the end) and switch statements where all branches would
27226 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27228 * driver.cs: Add default assemblies (the equivalent to the
27229 Microsoft CSC.RSP file)
27231 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27232 also update tokens_seen and set it to false.
27234 * driver.cs: Implement --recurse for Mike.
27236 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27237 correctly splitting out the paths.
27239 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27241 * interface.cs (Interface.PopulateProperty): Instead of using
27242 `parent' as the declaration space for the set parameters, use
27245 * support.cs (InternalParameters): InternalParameters constructor
27246 takes a DeclSpace instead of a TypeContainer.
27248 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27249 types are being initialized, load the address of it before calling
27252 (New): Provide a mechanism to disable the generation of local
27253 value type temporaries when the caller will be providing us with
27254 an address to store it.
27256 (ArrayCreation.EmitDynamicInitializers): Use it.
27258 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27260 * expression.cs (Invocation.EmitArguments): Only probe for array
27261 property if there is more than one argument. Sorry about that.
27263 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27264 empty param arrays.
27266 * class.cs (Method.LabelParameters): Fix incorrect code path that
27267 prevented the `ParamArrayAttribute' from being applied to the
27270 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27272 * support.cs (ReflectionParameters): Correctly compute whether the
27273 last argument is a params array. Fixes the problem with
27276 * typemanager.cs: Make the assemblies array always be non-null
27277 (empty, but non-null)
27279 * tree.cs (RecordDecl): New function that abstracts the recording
27280 of names. This reports error 101, and provides a pointer to the
27281 previous declaration. Fixes a crash in the compiler.
27283 * cs-parser.jay (constructor_declaration): Update to new grammar,
27284 and provide a constructor_body that can be empty.
27286 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27288 * driver.cs: Add support for --resources.
27290 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27291 Make all types for the various array helper methods be integer.
27293 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27294 CheckState to ConvCast.
27296 (ConvCast): Now it takes a `checked' state argument, to avoid
27297 depending on the emit context for the conversion, and just using
27298 the resolve time setting.
27300 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27301 instead of Invocation.EmitArguments. We do not emit the original
27302 arguments, instead we emit those which have been converted to
27303 unsigned int expressions.
27305 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27307 * codegen.cs: ditto.
27309 * expression.cs (LocalVariableReference): Drop the use of the
27310 Store function that depended on the variable index.
27312 * statement.cs (VariableInfo): Drop the `Idx' property from this
27313 class, as this is not taking into account the indexes for
27314 temporaries tat we generate during the execution, getting the
27317 * class.cs: First emit class initializers, then call the parent
27320 * expression.cs (Binary): Fix opcode emision.
27321 (UnaryMutator.EmitCode): Support checked code generation
27323 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27324 matches for events for both the Static and Instance scans,
27325 pointing to the same element. Fix that.
27327 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27329 * rootcontext.cs (ResolveTree): Always set the
27330 interface_resolve_order, because nested interfaces will be calling
27333 * class.cs (GetInterfaceOrClass): Track the same resolution
27334 process used by TypeManager.LookupType. This fixes the nested
27335 type lookups in class declarations (separate path from
27338 (TypeContainer.DefineType): Also define nested interfaces.
27339 (TypeContainer.RegisterOrder): New public function used to
27340 register the order in which child interfaces need to be closed.
27342 Nested interfaces need to be closed after their parents have been
27345 * interface.cs (InterfaceAttr): Put all the logic for computing
27346 the interface attribute here.
27348 (DefineInterface): Register our interface order with the
27349 RootContext or with the TypeContainer depending on the case.
27351 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27353 * cs-parser.jay: rework foreach statement to work with the new
27354 changes to the policy on SimpleNames.
27356 * report.cs: support Stacktrace on warnings as well.
27358 * makefile: drop --unsafe and /unsafe from the compile.
27360 2002-03-13 Ravi Pratap <ravi@ximian.com>
27362 * ecore.cs (StandardConversionExists): Modify to take an Expression
27363 as the first parameter. Ensure we do null -> reference type conversion
27366 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27367 temporary Expression objects.
27369 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27371 * interface.cs: workaround bug in method overloading resolution
27372 (there is already a bugzilla bug for it).
27374 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27376 We could also solve this problem by having a separate path for
27377 performing type lookups, instead of DoResolve, we could have a
27378 ResolveType entry point, and only participating pieces of the
27379 production (simplename, deref, array) would implement this.
27381 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27382 signal SimpleName to only resolve type names and not attempt to
27383 resolve anything else.
27385 * expression.cs (Cast): Set the flag.
27387 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27389 * class.cs: Only report 108 if there is no `new' modifier.
27391 * cs-parser.jay: rework foreach statement to work with the new
27392 changes to the policy on SimpleNames.
27394 * report.cs: support Stacktrace on warnings as well.
27396 * makefile: drop --unsafe and /unsafe from the compile.
27398 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27400 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27401 lookups here, instead of doing that at parse time. This means
27402 that our grammar will not introduce `LocalVariableReferences' as
27403 expressions at this point. That solves the problem of code like
27407 static void Main ()
27411 This is only half the fix. The full fix requires parameters to
27412 also be handled in this way.
27414 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27415 makes the use more obvious of the DeclSpace. The
27416 ec.TypeContainer.TypeBuilder is now only used to pull the
27417 TypeBuilder for it.
27419 My theory is that I can get rid of the TypeBuilder completely from
27420 the EmitContext, and have typecasts where it is used (from
27421 DeclSpace to where it matters).
27423 The only pending problem is that the code that implements Aliases
27424 is on TypeContainer, and probably should go in DeclSpace.
27426 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27427 lookups here, instead of doing that at parse time. This means
27428 that our grammar will not introduce `LocalVariableReferences' as
27429 expressions at this point. That solves the problem of code like
27433 static void Main ()
27437 This is only half the fix. The full fix requires parameters to
27438 also be handled in this way.
27440 * class.cs (Property.DefineMethod): When implementing an interface
27441 method, set newslot, when implementing an abstract method, do not
27442 set the flag (before we tried never setting it, or always setting
27443 it, which is the difference).
27444 (Indexer.DefineMethod): same.
27445 (Method.DefineMethod): same.
27447 * ecore.cs: Only set the status used flag if we get back a Field.
27449 * attribute.cs: Temporary hack, so Paolo can keep working.
27451 2002-03-08 Ravi Pratap <ravi@ximian.com>
27453 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27454 the unmanaged type in the case we have a MarshalAs attribute.
27456 (Resolve): Handle the case when we are parsing the special MarshalAs
27457 attribute [we need to store the unmanaged type to use later]
27459 * typemanager.cs (marshal_as_attr_type): Built in type for the
27460 MarshalAs Attribute.
27462 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27463 on parameters and accordingly set the marshalling info.
27465 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27467 * class.cs: Optimizing slightly by removing redundant code after
27468 we switched to the `NoTypes' return value.
27469 (Property.DefineMethod): use NoTypes here too.
27471 This fixes the bug I introduced in my last batch of changes.
27473 2002-03-05 Ravi Pratap <ravi@ximian.com>
27475 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27477 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27478 Enums since those are types too.
27480 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27482 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27483 thanks to a call during the lookup process.
27485 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27487 * statement.cs (Foreach): Lots of work to accomodate a particular
27488 kind of foreach statement that I had not kept in mind. It is
27489 possible to have foreachs on classes that provide a GetEnumerator
27490 method that return objects that implement the "pattern" for using
27491 a foreach, there is no need to support GetEnumerator
27494 This is needed to compile nant.
27496 * decl.cs: Only report 114 if the member is not `Finalize' and if
27497 the warning level is at least 2.
27499 * class.cs: Moved the compare function from Method to
27502 (MethodSignature.InheritableMemberSignatureCompare): Add new
27503 filter function that is used to extract inheritable methods from a
27506 (Method.Define): Use the new `inheritable_method_signature_filter'
27509 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27512 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27514 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27516 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27518 * expression.cs: Pass location information to
27519 ConvertImplicitStandard.
27521 * class.cs: Added debugging code to track return values from
27524 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27526 * expression.cs (Is.DoResolve): If either side of the `is' is an
27527 interface, do not flag the warning.
27529 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27532 * report.cs: Allow for --fatal to be used with --probe.
27534 * typemanager.cs (NoTypes): Move the definition for the empty Type
27537 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27539 (TypeContainer.DefineProxy): New function used to proxy to parent
27540 implementations when implementing interfaces.
27541 (TypeContainer.ParentImplements): used to lookup if our parent
27542 implements a public function that is required by an interface.
27543 (TypeContainer.VerifyPendingMethods): Hook this up.
27545 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27546 `modules' and `assemblies' arraylists into arrays. We only grow
27547 these are the very early start up of the program, so this improves
27548 the speedof LookupType (nicely measured).
27550 * expression.cs (MakeByteBlob): Replaced unsafe code with
27551 BitConverter, as suggested by Paolo.
27553 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27554 folding of string concatenation, but if either side is a string,
27555 and the other is not, then return null, and let the runtime use
27556 the concatenation on the string plus the object (using
27557 `Object.ToString').
27559 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27561 Constant Folding has been implemented now.
27563 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27564 the error instead on types that are not supported in one's
27567 * constant.cs (Constant and all children): New set of functions to
27568 perform implict and explicit conversions.
27570 * ecore.cs (EnumConstant): Implement the new functions to perform
27571 conversion by proxying to the child expression.
27573 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27574 own separate setting that can not be turned off from the command
27575 line using --unchecked or --checked and is only controlled using
27576 the checked/unchecked statements and expressions. This setting is
27577 used by the constant folder to flag errors.
27579 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27580 ConstantCheckState as well.
27582 During Resolve, they also have to flag the state, because the
27583 constant folder runs completely in the Resolve phase.
27585 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27588 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27590 * cfold.cs: New file, this file contains the constant folder.
27592 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27593 argument to track whether we are using the resulting address to
27594 load or store a value and provide better error messages.
27596 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27597 new AddressOf arguments.
27599 * statement.cs (Foreach.EmitCollectionForeach): Update
27601 * expression.cs (Argument.Emit): Call AddressOf with proper
27602 arguments to track usage.
27604 (New.DoEmit): Call AddressOf with new arguments.
27606 (Unary.Emit): Adjust AddressOf call.
27608 2002-03-01 Ravi Pratap <ravi@ximian.com>
27610 * cs-parser.jay (member_access): Change the case for pre-defined types
27611 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27614 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27617 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27618 essentially like methods and apply attributes like MethodImplOptions to them too.
27620 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27623 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27624 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27627 * Update code everywhere accordingly.
27629 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27631 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27633 2002-02-28 Ravi Pratap <ravi@ximian.com>
27635 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27636 try performing lookups against those instead of jumping straight into using
27637 the 'using' clauses.
27639 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27641 (LookupType): Perform lookups in implicit parents too.
27643 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27644 sequence as RootContext.LookupType.
27646 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27647 the various cases of namespace lookups into this method.
27649 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27651 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27652 in positional arguments)
27654 * class.cs (Operator): Update the AllowedModifiers to contain
27657 * cs-parser.jay: Update operator declaration to allow for the
27658 operator body to be empty.
27660 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27663 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27665 * class.cs (Method.Emit): Label parameters.
27667 * driver.cs: Return 1 or 0 as the program exit code.
27669 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27671 * expression.cs: Special case the `null' object when trying to
27672 auto-compute the type, as anything can be explicitly converted to
27675 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27676 spotting this Paolo.
27678 (Expression.ImplicitNumericConversion): Perform comparissions of
27679 the type using the underlying type in the case of an enumeration
27680 rather than using the enumeration type for the compare.
27682 Cope with the underlying == type case, which is not possible to
27685 (Expression.ConvertNumericExplicit): Perform comparissions of
27686 the type using the underlying type in the case of an enumeration
27687 rather than using the enumeration type for the compare.
27689 * driver.cs: If the user does not supply an extension, assume .exe
27691 * cs-parser.jay (if_statement): Rewrote so that we can track the
27692 location for the if statement.
27694 * expression.cs (Binary.ConstantFold): Only concat strings when
27695 the operation is "+", not everything ;-)
27697 * statement.cs (Statement.EmitBoolExpression): Take a location
27699 (If, While, Do): Track location.
27701 * expression.cs (Binary.ResolveOperator): In the object + string
27702 case, I was missing a call to ConvertImplicit
27704 2002-02-25 Ravi Pratap <ravi@ximian.com>
27706 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
27707 Location arguments. Ensure we use RootContext.LookupType to do our work
27708 and not try to do a direct Type.GetType and ModuleBuilder.GetType
27710 * interface.cs (PopulateMethod): Handle the type of the parameter being
27713 * expression.cs (Invocation.BetterFunction): Handle the case when we
27714 have a params method with no fixed arguments and a call is made with no
27717 2002-02-25 Miguel de Icaza <miguel@ximian.com>
27719 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
27720 the verbatim-string-literal
27722 * support.cs (InternalParameters.ParameterModifier): handle null
27724 (InternalParameters.ParameterType): ditto.
27726 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
27727 duplicating the name of the variable parameter.
27728 (GetParameterByName): Fix bug where we were not looking up array
27729 paramters if they were the only present (thanks Paolo!).
27730 (GetParameterInfo): We only have an empty set of types if both
27731 fixed and array are set to null.
27732 (GetParameterInfo-idx): Handle FixedParameter == null
27734 * cs-parser.jay: Handle the case where there is no catch
27735 statements (missing null test).
27737 2002-02-22 Miguel de Icaza <miguel@ximian.com>
27739 * driver.cs (MainDriver): Be conservative on our command line
27742 Catch DirectoryNotFoundException when calling GetFiles.
27744 (SplitPathAndPattern): Used to split the input specification into
27745 a path and a pattern that we can feed to Directory.GetFiles.
27747 2002-02-21 Miguel de Icaza <miguel@ximian.com>
27749 * statement.cs (Fixed): Implement the last case of the Fixed
27750 statement (string handling).
27752 * expression.cs (StringPtr): New class used to return a char * to
27753 a string; Used by the Fixed statement.
27755 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
27757 * expression.cs (Binary.ResolveOperator): Remove redundant
27758 MemberLookup pn parent type.
27759 Optimize union call, we do not need a union if the types are the same.
27760 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
27763 Specialize the use of MemberLookup everywhere, instead of using
27764 the default settings.
27766 (StackAlloc): Implement stackalloc keyword.
27768 * cs-parser.jay: Add rule to parse stackalloc.
27770 * driver.cs: Handle /h, /help, /?
27772 * expression.cs (MakeByteBlob): Removed the hacks we had in place
27773 before we supported unsafe code.
27775 * makefile: add --unsafe to the self compilation of mcs.
27777 2002-02-20 Miguel de Icaza <miguel@ximian.com>
27779 * expression.cs (PointerArithmetic): New class that is used to
27780 perform pointer arithmetic.
27781 (Binary.Resolve): Handle pointer arithmetic
27782 Handle pointer comparission.
27783 (ArrayPtr): Utility expression class that is used to take the
27784 address of an array.
27786 (ElementAccess): Implement array access for pointers
27788 * statement.cs (Fixed): Implement fixed statement for arrays, we
27789 are missing one more case before we are done.
27791 * expression.cs (Indirection): Implement EmitAssign and set the
27792 ExprClass to Variable. This allows pointer dereferences to be
27793 treated as variables, and to have values assigned to them.
27795 * ecore.cs (Expression.StoreFromPtr): New utility function to
27796 store values dereferencing.
27798 2002-02-20 Ravi Pratap <ravi@ximian.com>
27800 * expression.cs (Binary.ResolveOperator): Ensure that we are
27801 not trying to operate on a void type - this fixes the reported
27804 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
27805 the parent implementation is sealed.
27807 * ../errors/cs0239.cs : Add.
27809 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
27811 * typemanager.cs (unverifiable_code_type): Corresponds to
27812 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
27813 which have unsafe code in them.
27815 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
27818 2002-02-19 Miguel de Icaza <miguel@ximian.com>
27820 * cs-tokenizer.cs: Add support for @"litreal strings"
27822 Make tokenizer accept pre-processor directives
27823 on any column (remove the old C-like limitation).
27825 * rootcontext.cs (EmitCode): Emit any global attributes.
27826 (AddGlobalAttributes): Used to keep track of assembly attributes.
27828 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
27830 * cs-parser.jay: Add support for global attributes.
27832 2002-02-17 Miguel de Icaza <miguel@ximian.com>
27834 * expression.cs (Indirection): New helper class. Unary will
27835 create Indirection classes to be able to implement the
27836 IMemoryLocation interface on it.
27838 2002-02-16 Miguel de Icaza <miguel@ximian.com>
27840 * cs-parser.jay (fixed_statement): reference the right statement.
27842 * statement.cs (Fixed.Emit): Finish implementing the fixed
27843 statement for the &x case.
27845 2002-02-14 Miguel de Icaza <miguel@ximian.com>
27847 * class.cs (Property.Define, Method.Define): Remove newslot when
27850 * modifiers.cs: My use of NewSlot when `Abstract' was set was
27851 wrong. NewSlot should only be used if the `new' keyword is present.
27853 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
27854 locating our system dir. Sorry about this.
27856 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27858 * driver.cs (GetSystemDir): Compute correctly the location of our
27859 system assemblies. I was using the compiler directory instead of
27860 the library directory.
27862 2002-02-13 Ravi Pratap <ravi@ximian.com>
27864 * expression.cs (BetterFunction): Put back in what Miguel commented out
27865 since it is the correct fix. The problem is elsewhere ;-)
27867 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
27868 parameters of the parms method are themselves compatible or not !
27870 (StandardConversionExists): Fix very dangerous bug where we were forgetting
27871 to check that a class implements an interface before saying that an implicit
27872 conversion was allowed. Use ImplementsInterface to do the checking.
27874 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27876 * class.cs (Method.Define): Track whether we are an explicit
27877 implementation or not. And only call DefineMethodOverride if we
27878 are an explicit implementation.
27880 (Property.DefineMethod): Ditto.
27882 2002-02-11 Ravi Pratap <ravi@ximian.com>
27884 * expression.cs (BetterFunction): Catch hideous bug which was
27885 preventing us from detecting ambiguous calls due to implicit casts i.e
27888 2002-01-29 Miguel de Icaza <miguel@ximian.com>
27890 * support.cs (Pair): Remove un-needed method. I figured why I was
27891 getting the error in cs-parser.jay, the variable in a foreach loop
27892 is readonly, and the compiler does not really treat this as a variable.
27894 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
27895 instead of EQUALS in grammar.
27897 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
27899 * expression.cs (Unary.DoResolve): Check whether the argument is
27902 2002-01-28 Miguel de Icaza <miguel@ximian.com>
27904 * support.cs: Api for Pair to set a value. Despite the fact that
27905 the variables are public the MS C# compiler refuses to compile
27906 code that accesses the field if the variable is part of a foreach
27909 * statement.cs (Fixed): Begin implementation of the fixed
27912 (Block.AddVariable): Return the VariableInfo on success and null
27913 on failure instead of true/false.
27915 * cs-parser.jay (foreach): Catch errors on variables already
27916 defined (we were ignoring this value before) and properly unwind
27917 the block hierarchy
27919 (fixed_statement): grammar for the fixed statement.
27921 2002-01-25 Miguel de Icaza <miguel@ximian.com>
27923 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
27924 pointer types to be incretemented.
27926 (SizeOf): Implement.
27928 * cs-parser.jay (pointer_member_access): Implement
27929 expr->IDENTIFIER production.
27931 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
27932 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
27935 (Unary): Implement indirection.
27937 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
27938 use in non-unsafe context).
27940 (SimpleName.DoResolve): Check for pointers in field access on safe
27943 (Expression.LoadFromPtr): Factor the load-indirect code in this
27944 function. This was duplicated in UnboxCast and ParameterReference
27946 2002-01-24 Miguel de Icaza <miguel@ximian.com>
27948 * expression.cs (ComposedCast): report an error if a pointer cast
27949 is used in a safe region.
27951 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
27952 pointer type casts in unsafe context.
27954 * codegen.cs (EmitContext): Set up IsUnsafe.
27956 * cs-parser.jay (non_expression_type): Add productions for pointer
27959 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
27960 code. We should not use force into static mode if the method is
27961 not virtual. Fixes bug in MIS
27963 * statement.cs (Do.Emit, While.Emit, For.Emit,
27964 Statement.EmitBoolExpression): Add support to Do and While to
27965 propagate infinite loop as `I do return' semantics.
27967 Improve the For case to also test for boolean constants.
27969 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
27970 to the list of attributes we can add.
27972 Remove `EmitContext' argument.
27974 * class.cs (Method.Define): Apply parameter attributes.
27975 (Constructor.Define): Apply parameter attributes.
27976 (MethodCore.LabelParameters): Move here the core of labeling
27979 * support.cs (ReflectionParameters.ParameterModifier,
27980 InternalParameters.ParameterModifier): Use IsByRef on the type and
27981 only return the OUT bit for these parameters instead of in/out/ref
27984 This is because I miss-understood things. The ParameterInfo.IsIn
27985 and IsOut represent whether the parameter has the [In] and [Out]
27988 2002-01-22 Miguel de Icaza <miguel@ximian.com>
27990 * ecore.cs (FieldExpr.Emit): Release temporaries.
27992 * assign.cs (LocalTemporary.Release): new function.
27994 * codegen.cs (EmitContext.GetTemporaryStorage,
27995 EmitContext.FreeTemporaryStorage): Rework the way we deal with
27996 temporary storage. Now we can "put back" localbuilders when we
27999 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28001 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28002 need to make a copy of the variable to generate verifiable code.
28004 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28006 * driver.cs: Compute dynamically the system directory.
28008 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28009 Slower, but more generally useful. Used by the abstract
28010 registering implementation.
28012 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28013 the rules for the special rule on Type/instances. First check if
28014 we have the same name, and if so, try that special static path
28015 rather than the instance path.
28017 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28019 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28022 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28023 Enum, ValueType, Delegate or Array for non-corlib compiles.
28025 * cs-tokenizer.cs: Catch long identifiers (645)
28027 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28030 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28031 fix, we were returning too early, so we were not registering
28032 pending methods from abstract classes.
28034 Do not register pending methods if the class is abstract.
28036 * expression.cs (Conditional.DoResolve): Report circular implicit
28037 conversions when we neecd to compute it for conditional
28040 (Is.DoResolve): If the expression is always of the provided type,
28041 flag warning 183. If the expression can not ever be of the
28042 provided type flag warning 184.
28044 * class.cs: Catch 169 as well.
28046 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28049 2002-01-18 Nick Drochak <ndrochak@gol.com>
28051 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28053 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28055 * interface.cs: (PopulateMethod): Check for pointers being defined
28056 only if the unsafe context is active.
28057 (PopulateProperty): ditto.
28058 (PopulateIndexer): ditto.
28060 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28061 specified. If pointers are present, make sure that they are
28062 present in an unsafe context.
28063 (Constructor, Constructor.Define): ditto.
28064 (Field, Field.Define): ditto.
28065 (Property, Property.Define): ditto.
28066 (Event, Event.Define): ditto.
28068 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28069 hashtable if there are classes or structs defined.
28071 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28072 code, as the constant resolution moved.
28074 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28075 the metadata, so we can flag error 133.
28077 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28078 pointer is being declared in an unsafe context.
28080 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28082 * modifiers.cs (Modifiers.Check): Require a Location argument.
28083 Report error 227 for Unsafe use.
28085 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28087 * statement.cs (For.Emit): If the test is null, then report that
28088 we do `return', as we wont reach anything afterwards.
28090 (Switch.SwitchGoverningType): Track the expression that matched
28093 * driver.cs: Allow negative numbers as an error code to flag.
28095 * cs-parser.jay: Handle 1551.
28097 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28099 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28101 * cs-parser.jay: Report 1518 (type declaration can only contain
28102 class, struct, interface, enum or delegate)
28104 (switch_label): Report 1523 (keywords `case' or `default' must
28107 (opt_switch_sections): Report 1522 (empty switch)
28109 * driver.cs: Report 1515 (response file specified multiple times)
28110 Report 1516 (Source file specified multiple times).
28112 * expression.cs (Argument.Resolve): Signal 1510
28114 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28115 access not allowed in static code)
28117 2002-01-11 Ravi Pratap <ravi@ximian.com>
28119 * typemanager.cs (IsPointerType): Utility method which we are going
28122 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28123 the object type, so we take care of that.
28125 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28127 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28128 added to non-params parameters :-)
28130 * typemanager.cs (CSharpName): Include 'void' type too.
28132 (void_ptr_type): Include in the set of core types.
28134 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28137 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28140 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28141 completely forgotten about it.
28143 2002-01-10 Ravi Pratap <ravi@ximian.com>
28145 * cs-parser.jay (pointer_type): Add. This begins our implementation
28146 of parsing rules for unsafe code.
28148 (unsafe_statement): Implement.
28150 (embedded_statement): Modify to include the above.
28152 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28154 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28155 if the current context is an unsafe one.
28157 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28158 are handled differently, we need separate rules for them.
28160 (local_variable_declaration): Update to use local_variable_pointer_type
28161 to allow variable declarations of unmanaged pointer types.
28163 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28164 in unsafe contexts.
28166 * ../errors/cs0214.cs : Add.
28168 2002-01-16 Nick Drochak <ndrochak@gol.com>
28170 * makefile: remove 'response' file when cleaning.
28172 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28174 * cs-parser.jay: Report 1524.
28176 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28178 * typemanager.cs (RegisterMethod): drop checking if we have
28179 registered this from here
28181 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28183 * class.cs (Method.EmitDestructor): Implement calling our base
28186 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28187 value of InFinally.
28189 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28190 this routine and will wrap the call in a try/catch block. Deal
28193 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28195 * ecore.cs (Expression.MemberLookup): instead of taking a
28196 parameter `same_type' that was used to tell whether we could
28197 access private members we compute our containing type from the
28200 (FieldExpr): Added partial support for volatile fields. This does
28201 not work for volatile fields exposed from assemblies, as I can not
28202 figure out how to extract the modreq from it.
28204 Updated all the source files to use this.
28206 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28207 because it is referenced by MemberLookup very often.
28209 2002-01-09 Ravi Pratap <ravi@ximian.com>
28211 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28212 TypeBuilder.GetCustomAttributes to retrieve what we need.
28214 Get rid of redundant default_member_attr_type as this is the same as
28215 default_member_type which already exists.
28217 * interface.cs, attribute.cs : Update accordingly.
28219 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28221 * typemanager.cs: Enable IndexerPropertyName again. It does not
28222 work for TYpeBuilders though. Ravi, can you please fix this?
28224 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28226 * expression.cs (Argument.Emit): Handle the case of ref objects
28227 being passed to ref functions;
28229 (ParameterReference.EmitLoad): Loads the content of the pointer
28230 without dereferencing.
28232 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28234 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28236 2002-01-08 Ravi Pratap <ravi@ximian.com>
28238 * class.cs (Indexer.DefineMethod): Incorporate the interface
28239 type in the name of the method if we are doing explicit interface
28242 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28244 (BetterConversion): Fix extremely trivial bug where we were referring to
28245 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28248 * ../errors/bug16.cs : Add although we have fixed it.
28250 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28252 * expression.cs (BaseIndexer): Begin implementation.
28254 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28256 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28257 production directly to remove a shift/reduce, and implement
28258 explicit interface implementation.
28260 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28261 after a floating point suffix.
28263 * expression.cs (DoNumericPromotions): Improved the conversion for
28264 uint/uint. If we have a constant, we avoid doing a typecast to a
28267 * class.cs (Indexer): Implement explicit interface implementation
28270 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28272 * class.cs: make the default instance constructor public and hidebysig.
28274 2001-01-03 Ravi Pratap <ravi@ximian.com>
28276 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28277 so we can call it from elsewhere.
28279 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28280 we emit it internally if the class has a defined indexer; otherwise the user
28281 emits it by decorating the class definition with the DefaultMemberAttribute.
28283 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28284 attribute is not used on a type which defines an indexer.
28286 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28287 character when we skip whitespace.
28289 * ../errors/cs0646.cs : Add.
28291 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28293 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28296 * makefile: Add practical target `mcs3.exe' which builds the third
28297 generation compiler.
28299 * expression.cs (New): Fix structures constructor calling.
28301 * class.cs (Property, Method, Indexer): Emit Final flag on the
28302 method if we are an interface implementation and we are not
28305 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28306 whether this property is referencing a `base' method.
28308 * expression.cs (Invocation.EmitCall): take an extra argument:
28309 is_base, this is used to determine whether the `call' or
28310 `callvirt' opcode should be used.
28313 * delegate.cs: update EmitCall.
28315 * class.cs (Method.Define): Set NewSlot for the cases where we are
28316 not implementing an interface method.
28318 (Property.Define): ditto.
28320 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28322 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28323 'r'. Allows mcs to parse itself fully.
28325 2002-01-02 Ravi Pratap <ravi@ximian.com>
28327 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28328 of the number of initializers that require the InitializeArray method.
28330 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28331 update the above field where necessary.
28333 (MakeByteBlob): Update accordingly.
28335 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28338 (EmitDynamicInitializers): Update in accordance with the new optimization.
28340 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28341 same OpCode applies.
28343 * cs-parser.jay : Fix some glaring errors I introduced.
28345 2002-01-01 Ravi Pratap <ravi@ximian.com>
28347 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28348 so that we can check for name clashes there too.
28350 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28351 for interface indexers.
28353 * interfaces.cs (Define): Emit the default member attribute.
28355 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28356 variable was being referred to while setting the value ;-)
28358 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28360 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28361 byte-by-byte information when we know the data is zero.
28363 Make the block always a multiple of 4, because
28364 DefineInitializedData has a bug.
28366 * assign.cs: Fix, we should assign from the temporary, not from
28369 * expression.cs (MakeByteBlob): Fix my incorrect code.
28371 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28373 * typemanager.cs (EnumToUnderlying): This function is used to get
28374 the underlying type from an enumeration, because it does not
28377 * constant.cs: Use the I4_S form for values between -128 and 127.
28379 * statement.cs (Block.LookupLabel): Looks up a label.
28380 (Block): Drop support for labeled blocks.
28382 (LabeledStatement): New kind of statement that represents a label
28385 (Goto): Finally implement this bad boy.
28387 * cs-parser.jay: Update to reflect new mechanism to implement
28390 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28392 * codegen.cs (EmitContext.This): a codegen property that keeps the
28393 a single instance of this instead of creating many different this
28396 * delegate.cs (Delegate.DoResolve): Update to use the property;
28398 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28400 * expression.cs (BaseAccess.DoResolve): Ditto.
28402 2001-12-29 Ravi Pratap <ravi@ximian.com>
28404 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28405 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28407 (InitCoreTypes): Update accordingly.
28409 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28410 so we can quickly store the state.
28412 (ApplyAttributes): Set the correct implementation flags
28413 for InternalCall methods.
28415 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28417 * expression.cs (EmitCall): if a method is not virtual, then do
28418 not use callvirt on it.
28420 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28421 user defined stuff) requires the use of stobj, which takes an
28422 address on the stack instead of an array and an index. So emit
28423 the Ldelema operation for it.
28425 (EmitStoreOpcode): Use stobj for valuetypes.
28427 (UnaryMutator.EmitCode): Use the right 1 value depending on
28428 whether we are dealing with int64/uint64, float or doubles.
28430 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28431 constructors that I implemented last night.
28433 (Constructor.IsDefault): Fix to work properly for static
28436 * cs-parser.jay (CheckDef): report method signature errors.
28437 Update error number 103 to be 132.
28439 * decl.cs: New AdditionResult enumeration value: MethodExists.
28440 Although we do this check for methods later on in the semantic
28441 analysis, catching repeated default constructors is so easy that
28442 we catch these here.
28444 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28447 (ParameterReference.EmitAssign, Emit): handle
28450 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28451 (ArrayAccess.EmitStoreOpcode): ditto.
28453 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28455 * expression.cs (MakeByteBlob): Complete all the missing types
28456 (uint, short, ushort, byte, sbyte)
28458 * class.cs: Only init instance field initializers on instance
28461 Rename `constructors' to instance_constructors.
28463 (TypeContainer.AddConstructor): Only add constructors to the list
28464 if it is not static.
28466 Make sure that we handle default_static_constructor independently
28467 everywhere where we handle instance_constructors
28469 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28471 * class.cs: Do not lookup or create a base initializer for a
28472 static constructor.
28474 (ConstructorInitializer.Resolve): use the proper type to lookup
28477 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28479 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28482 * decl.cs: CloseType is now an virtual method, the default
28483 implementation just closes this type.
28485 2001-12-28 Ravi Pratap <ravi@ximian.com>
28487 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28488 to PreserveSig by default. Also emit HideBySig on such methods.
28490 Basically, set the defaults to standard values.
28492 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28493 argument, if candidate is better, it can't be worse than the best !
28495 (Invocation): Re-write bits to differentiate between methods being
28496 applicable in their expanded form and their normal form - for params
28499 Get rid of use_standard everywhere as only standard conversions are allowed
28500 in overload resolution.
28502 More spec conformance.
28504 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28506 * driver.cs: Add --timestamp, to see where the compiler spends
28509 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28510 `this' in static code.
28512 (SimpleName.DoResolve): Implement in terms of a helper function
28513 that allows static-references to be passed upstream to
28516 (Expression.ResolveWithSimpleName): Resolve specially simple
28517 names when called by MemberAccess to implement the special
28520 (Expression.ImplicitReferenceConversion): Handle conversions from
28521 Null to reference types before others, as Null's type is
28524 * expression.cs (Invocation.EmitCall): Handle the special case of
28525 calling methods declared on a reference type from a ValueType
28526 (Base classes System.Object and System.Enum)
28528 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28529 the left hand side is a TypeExpr, not on every enumeration.
28531 (Binary.Resolve): If types are reference types, then do a cast to
28532 object on operators != and == of both arguments.
28534 * typemanager.cs (FindMembers): Extract instance and static
28535 members if requested.
28537 * interface.cs (PopulateProperty): Use void_type instead of null
28538 as the return type for the setter method.
28540 (PopulateIndexer): ditto.
28542 2001-12-27 Ravi Pratap <ravi@ximian.com>
28544 * support.cs (ReflectionParameters): Fix minor bug where we
28545 were examining the wrong parameter for the ParamArray attribute.
28547 Cope with requests for the type of the parameter at position
28548 greater than the params parameter's. We now return the element
28549 type of the params array as that makes more sense.
28551 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28552 accordingly as we no longer have to extract the element type
28555 (Invocation.OverloadResolve): Update.
28557 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28559 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28560 against IEnumerator, test whether the return value is a descendant
28561 of the IEnumerator interface.
28563 * class.cs (Indexer.Define): Use an auxiliary method to implement
28564 the other bits of the method definition. Begin support for
28565 explicit interface implementation.
28567 (Property.DefineMethod): Use TypeManager.void_type instead of null
28568 for an empty return value.
28570 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28572 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28573 dealing with a FieldExpr which is composed of a FieldBuilder, in
28574 the code path we did extract the constant, but we should have
28575 obtained the underlying value to be able to cast it (otherwise we
28576 end up in an infinite loop, this is what Ravi was running into).
28578 (ArrayCreation.UpdateIndices): Arrays might be empty.
28580 (MemberAccess.ResolveMemberAccess): Add support for section
28581 14.5.4.1 that deals with the special case of E.I when E is a type
28582 and something else, that I can be a reference to a static member.
28584 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28585 handle a particular array type to create byte blobs, it is just
28586 something we dont generate byteblobs for.
28588 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28591 * location.cs (Push): remove the key from the hashtable that we
28592 are about to add. This happens for empty files.
28594 * driver.cs: Dispose files after we have parsed them.
28596 (tokenize): new function that only runs the tokenizer on its
28597 input, for speed testing.
28599 2001-12-26 Ravi Pratap <ravi@ximian.com>
28601 * class.cs (Event.Define): Define the private field only if there
28602 are no accessors defined.
28604 * expression.cs (ResolveMemberAccess): If there is no associated
28605 field with the event, that means we have an event defined with its
28606 own accessors and we should flag error cs0070 since transforming
28607 ourselves into a field is not valid in that case.
28609 * ecore.cs (SimpleName.DoResolve): Same as above.
28611 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28612 and charset to sane values.
28614 2001-12-25 Ravi Pratap <ravi@ximian.com>
28616 * assign.cs (DoResolve): Perform check on events only if they
28617 are being accessed outside the declaring type.
28619 * cs-parser.jay (event_declarations): Update rules to correctly
28620 set the type of the implicit parameter etc.
28622 (add_accessor, remove_accessor): Set current local parameters.
28624 * expression.cs (Binary): For delegate addition and subtraction,
28625 cast the return value from the method into the appropriate delegate
28628 2001-12-24 Ravi Pratap <ravi@ximian.com>
28630 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28631 of these as the workaround is unnecessary.
28633 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28634 delegate data - none of that is needed at all.
28636 Re-write bits to extract the instance expression and the delegate method
28639 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28642 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28643 of attaching attributes instead of duplicating code everywhere.
28645 * everywhere : Update code to do attribute emission using the above method.
28647 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28649 * expression.cs (IsParamsMethodApplicable): if there are not
28650 parameters, return immediately.
28652 * ecore.cs: The 0 literal can be implicity converted to an enum
28655 (SimpleName.DoResolve): First lookup the type, then lookup the
28658 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28659 want to get its address. If the InstanceExpression is not
28660 addressable, store the result in a temporary variable, then get
28663 * codegen.cs: Only display 219 errors on warning level or above.
28665 * expression.cs (ArrayAccess): Make it implement the
28666 IMemoryLocation interface.
28668 (Binary.DoResolve): handle the operator == (object a, object b)
28669 and operator != (object a, object b) without incurring into a
28670 BoxedCast (because 5 != o should never be performed).
28672 Handle binary enumerator operators.
28674 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28675 value type, otherwise use Ldelem_ref.
28677 Use precomputed names;
28679 (AddressOf): Implement address of
28681 * cs-parser.jay (labeled_statement): Fix recursive block
28682 addition by reworking the production.
28684 * expression.cs (New.DoEmit): New has a special case:
28686 If we are dealing with a ValueType, we have a few
28687 situations to deal with:
28689 * The target of New is a ValueType variable, that is
28690 easy, we just pass this as the variable reference
28692 * The target of New is being passed as an argument,
28693 to a boxing operation or a function that takes a
28696 In this case, we need to create a temporary variable
28697 that is the argument of New.
28700 2001-12-23 Ravi Pratap <ravi@ximian.com>
28702 * rootcontext.cs (LookupType): Check that current_type is not null before
28703 going about looking at nested types.
28705 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
28706 not implement the IAssignMethod interface any more.
28708 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
28709 where we tranform them into FieldExprs if they are being resolved from within
28710 the declaring type.
28712 * ecore.cs (SimpleName.DoResolve): Do the same here.
28714 * assign.cs (DoResolve, Emit): Clean up code considerably.
28716 * ../errors/bug10.cs : Add.
28718 * ../errors/cs0070.cs : Add.
28720 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
28722 * assign.cs : Get rid of EventIsLocal everywhere.
28724 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28726 * ecore.cs (ConvertIntLiteral): finished the implementation.
28728 * statement.cs (SwitchLabel): Convert the value we are using as a
28729 key before looking up the table.
28731 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28733 * codegen.cs (EmitTopBlock): Require a Location argument now.
28735 * cs-parser.jay (constructor_declarator): We need to setup
28736 current_local_parameters before we parse the
28737 opt_constructor_initializer, to allow the variables to be bound
28738 to the constructor arguments.
28740 * rootcontext.cs (LookupType): First lookup nested classes in our
28741 class and our parents before we go looking outside our class.
28743 * expression.cs (ConstantFold): Extract/debox the values at the
28746 * rootcontext.cs (EmitCode): Resolve the constants first before we
28747 resolve the types. This is not really needed, but it helps debugging.
28749 * statement.cs: report location.
28751 * cs-parser.jay: pass location to throw statement.
28753 * driver.cs: Small bug fix.
28755 * report.cs: Updated format to be 4-zero filled digits.
28757 2001-12-22 Ravi Pratap <ravi@ximian.com>
28759 * expression.cs (CheckIndices): Fix minor bug where the wrong
28760 variable was being referred to ;-)
28762 (DoEmit): Do not call EmitStaticInitializers when the
28763 underlying type is System.Object.
28765 2001-12-21 Ravi Pratap <ravi@ximian.com>
28767 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
28768 and do the usual workaround for SRE.
28770 * class.cs (MyEventBuilder.EventType): New member to get at the type
28771 of the event, quickly.
28773 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
28775 * assign.cs (Assign.DoResolve): Handle the case when the target
28776 is an EventExpr and perform the necessary checks.
28778 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
28781 (SimpleName.MemberStaticCheck): Include check for EventExpr.
28783 (EventExpr): Set the type in the constructor itself since we
28784 are meant to be born fully resolved.
28786 (EventExpr.Define): Revert code I wrote earlier.
28788 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
28789 instance expression is null. The instance expression is a This in that case
28790 or a null, depending on whether it is a static method or not.
28792 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
28793 refers to more than one method.
28795 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
28796 and accordingly flag errors.
28798 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28800 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
28802 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28804 * location.cs (ToString): Provide useful rutine.
28806 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28808 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
28809 objects, return the actual integral boxed.
28811 * statement.cs (SwitchLabel): define an ILLabel for each
28814 (Switch.CheckSwitch): If the value is a Literal, extract
28815 the underlying literal.
28817 Also in the unused hashtable we had, add the SwitchLabel so we can
28818 quickly look this value up.
28820 * constant.cs: Implement a bunch of new constants. Rewrite
28821 Literal based on this. Made changes everywhere to adapt to this.
28823 * expression.cs (Expression.MakeByteBlob): Optimize routine by
28824 dereferencing array only once, and also copes with enumrations.
28826 bytes are two bytes wide, not one.
28828 (Cast): Perform constant conversions.
28830 * ecore.cs (TryImplicitIntConversion): Return literals instead of
28831 wrappers to the literals here.
28833 * expression.cs (DoNumericPromotions): long literals can converted
28834 to ulong implicity (this is taken care of elsewhere, but I was
28835 missing this spot).
28837 * ecore.cs (Expression.Literalize): Make the return type Literal,
28838 to improve type checking.
28840 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
28842 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28844 * literal.cs: Revert code from ravi that checked the bounds. The
28845 bounds are sane by the definition of the type itself.
28847 * typemanager.cs: Fix implementation of ImplementsInterface. We
28848 need to actually look up in our parent hierarchy for interfaces
28851 * const.cs: Use the underlying type for enumerations
28853 * delegate.cs: Compute the basename for the delegate creation,
28854 that should fix the delegate test case, and restore the correct
28855 Type Lookup semantics in rootcontext
28857 * rootcontext.cs: Revert Ravi's last patch. The correct way of
28858 referencing a nested type with the Reflection API is using the "+"
28861 * cs-parser.jay: Do not require EOF token at the end.
28863 2001-12-20 Ravi Pratap <ravi@ximian.com>
28865 * rootcontext.cs (LookupType): Concatenate type names with
28866 a '.' instead of a '+' The test suite passes again.
28868 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
28869 field of the enumeration.
28871 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
28872 the case when the member is an EventExpr.
28874 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
28875 static has an associated instance expression.
28877 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
28879 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
28881 * class.cs (Event.Define): Register event and perform appropriate checks
28884 We define the Add and Remove methods even if the use provides none because
28885 in that case, we provide default implementations ourselves.
28887 Define a private field of the type of the event. This is done by the CSC compiler
28888 and we should be doing it too ;-)
28890 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
28891 More methods we use in code we generate.
28893 (multicast_delegate_type, delegate_type): Two separate types since the distinction
28896 (InitCoreTypes): Update accordingly for the above.
28898 * class.cs (Event.Emit): Generate code for default accessors that we provide
28900 (EmitDefaultMethod): Do the job in the above.
28902 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
28905 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28907 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
28908 builders even if we were missing one.
28910 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
28911 pass the Basename as our class name instead of the Name. The
28912 basename will be correctly composed for us.
28914 * parameter.cs (Paramters): Now takes a Location argument.
28916 * decl.cs (DeclSpace.LookupType): Removed convenience function and
28917 make all the code call directly LookupType in RootContext and take
28918 this chance to pass the Location information everywhere.
28920 * Everywhere: pass Location information.
28922 2001-12-19 Miguel de Icaza <miguel@ximian.com>
28924 * class.cs (Constructor.Define): Updated way of detecting the
28925 length of the parameters.
28927 (TypeContainer.DefineType): Use basename as the type name for
28930 (TypeContainer.Define): Do not recursively define types here, as
28931 definition is taken care in order by the RootContext.
28933 * tree.cs: Keep track of namespaces in a per-file basis.
28935 * parameter.cs (Parameter.ComputeSignature): Update to use
28938 (Parameters.GetSignature): ditto.
28940 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
28941 instead of a TypeContainer.
28943 (Interface.SemanticAnalysis): Use `this' instead of our parent to
28944 resolve names. Because we need to be resolve in our context, not
28947 * driver.cs: Implement response files.
28949 * class.cs (TypeContainer.DefineType): If we are defined, do not
28950 redefine ourselves.
28952 (Event.Emit): Emit the code for add/remove handlers.
28953 (Event.Define): Save the MethodBuilders for add/remove.
28955 * typemanager.cs: Use pair here too.
28957 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
28958 DictionaryEntry requires the first argument to be non-null.
28960 (enum_declaration): Compute full name for registering the
28963 (delegate_declaration): Instead of using
28964 formal_parameter_list, use opt_formal_parameter_list as the list
28967 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
28968 (EventParsing): New property that controls whether `add' and
28969 `remove' are returned as tokens or identifiers (for events);
28971 2001-12-19 Ravi Pratap <ravi@ximian.com>
28973 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
28974 use MyEventBuilder only and let it wrap the real builder for us.
28976 (MyEventBuilder): Revamp constructor etc.
28978 Implement all operations that we perform on EventBuilder in precisely the same
28981 (FindMembers): Update to use the EventBuilder member.
28983 (Event.Emit): Update accordingly.
28985 2001-12-18 Ravi Pratap <ravi@ximian.com>
28987 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
28988 by calling the appropriate methods.
28990 (GetCustomAttributes): Make stubs as they cannot possibly do anything
28993 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
28995 2001-12-17 Ravi Pratap <ravi@ximian.com>
28997 * delegate.cs (Delegate.Populate): Check that the return type
28998 and various parameters types are indeed accessible.
29000 * class.cs (Constructor.Define): Same here.
29002 (Field.Define): Ditto.
29004 (Event.Define): Ditto.
29006 (Operator.Define): Check that the underlying Method defined itself
29007 correctly - so it's MethodBuilder should not be null.
29009 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29010 expression happens to be null.
29012 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29013 members but as of now we don't seem to be able to do anything really useful with it.
29015 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29016 not the EventBuilder.
29018 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29020 * cs-tokenizer.cs: Add support for defines.
29021 Add support for #if, #elif, #else, #endif
29023 (eval_var): evaluates a variable.
29024 (eval): stubbed for evaluating functions.
29026 * cs-parser.jay: Pass the defines information
29028 * driver.cs: Add --define command line option.
29030 * decl.cs: Move MemberCore here.
29032 Make it the base class for DeclSpace. This allows us to catch and
29033 report 108 and 109 for everything now.
29035 * class.cs (TypeContainer.Define): Extract all the members
29036 before populating and emit the warning 108 (new keyword required
29037 to override) instead of having each member implement this.
29039 (MemberCore.Define): New abstract method, we will be using this in
29040 the warning reporting engine in Populate.
29042 (Operator.Define): Adjust to new MemberCore protocol.
29044 * const.cs (Const): This does not derive from Expression, it is a
29045 temporary object we use to create fields, it is a MemberCore.
29047 * class.cs (Method.Define): Allow the entry point to be in a
29050 * driver.cs: Rewrite the argument handler to clean it up a bit.
29052 * rootcontext.cs: Made it just an auxiliary namespace feature by
29053 making everything static.
29055 * driver.cs: Adapt code to use RootContext type name instead of
29058 * delegate.cs: Remove RootContext argument.
29060 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29063 * class.cs (Event.Define): The lookup can fail.
29065 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29067 * expression.cs: Resolve the this instance before invoking the code.
29069 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29071 * cs-parser.jay: Add a production in element_access that allows
29072 the thing to become a "type" reference. This way we can parse
29073 things like "(string [])" as a type.
29075 Note that this still does not handle the more complex rules of
29079 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29081 * ecore.cs: (CopyNewMethods): new utility function used to
29082 assemble the list of methods from running FindMembers.
29084 (MemberLookup): Rework FindMembers so that
29086 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29088 * class.cs (TypeContainer): Remove Delegates who fail to be
29091 * delegate.cs (Populate): Verify that we dont get null return
29092 values. TODO: Check for AsAccessible.
29094 * cs-parser.jay: Use basename to emit error 574 (destructor should
29095 have the same name as container class), not the full name.
29097 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29098 possible representation.
29100 Also implements integer type suffixes U and L.
29102 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29104 * expression.cs (ArrayCreation.DoResolve): We need to do the
29105 argument resolution *always*.
29107 * decl.cs: Make this hold the namespace. Hold the root context as
29109 (LookupType): Move here.
29111 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29113 * location.cs (Row, Name): Fixed the code, it was always returning
29114 references to the first file.
29116 * interface.cs: Register properties defined through interfaces.
29118 * driver.cs: Add support for globbing on the command line
29120 * class.cs (Field): Make it derive from MemberCore as well.
29123 2001-12-15 Ravi Pratap <ravi@ximian.com>
29125 * class.cs (Event::Define): Check that the type of the event is a delegate
29126 type else flag error #66.
29128 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29131 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29132 values of EntryPoint, CharSet etc etc.
29134 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29136 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29137 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29138 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29139 which needs this to do its work.
29141 * ../errors/cs0066.cs : Add.
29143 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29145 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29148 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29149 clears out the parameters field.
29150 (MemberSignatureCompare): Cleanup
29152 (MemberCore): New base class used to share code between MethodCore
29155 (RegisterRequiredImplementations) BindingFlags.Public requires
29156 either BindingFlags.Instace or Static. Use instance here.
29158 (Property): Refactored code to cope better with the full spec.
29160 * parameter.cs (GetParameterInfo): Return an empty array instead
29163 * class.cs (Property): Abstract or extern properties have no bodies.
29165 * parameter.cs (GetParameterInfo): return a zero-sized array.
29167 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29168 method modifier validation to the typecontainer so we can reuse
29169 this on properties.
29171 (MethodCore.ParameterTypes): return an empty sized array of types.
29173 (Property.Define): Test property modifier validity.
29175 Add tests for sealed/override too.
29177 (Method.Emit): abstract or extern methods have no bodies.
29179 2001-12-14 Ravi Pratap <ravi@ximian.com>
29181 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29184 (Method::Define, ::Emit): Modify accordingly.
29186 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29188 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29190 * makefile: Pass in /unsafe.
29192 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29194 * class.cs (MakeKey): Kill routine.
29196 * class.cs (TypeContainer.Define): Correctly define explicit
29197 method implementations (they require the full interface name plus
29200 * typemanager.cs: Deply the PtrHashtable here and stop using the
29201 lame keys. Things work so much better.
29203 This of course broke everyone who depended on `RegisterMethod' to
29204 do the `test for existance' test. This has to be done elsewhere.
29206 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29207 the object stupid Equals method (because, that like fails all over
29208 the place). We still do not use it.
29210 * class.cs (TypeContainer.SetRequiredInterface,
29211 TypeContainer.RequireMethods): Killed these two routines and moved
29212 all the functionality to RegisterRequiredImplementations.
29214 (TypeContainer.RegisterRequiredImplementations): This routine now
29215 registers all the implementations required in an array for the
29216 interfaces and abstract methods. We use an array of structures
29217 which can be computed ahead of time to reduce memory usage and we
29218 also assume that lookups are cheap as most classes will not
29219 implement too many interfaces.
29221 We also avoid creating too many MethodSignatures.
29223 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29224 clear the "pending" bit if we find that there are problems with
29227 (TypeContainer.VerifyPendingMethods): Update to report errors of
29228 methods that look like implementations but are not.
29230 (TypeContainer.Define): Add support for explicit interface method
29233 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29235 * typemanager.cs: Keep track of the parameters here instead of
29236 being a feature of the TypeContainer.
29238 * class.cs: Drop the registration of parameters here, as
29239 InterfaceMethods are also interface declarations.
29241 * delegate.cs: Register methods with the TypeManager not only with
29242 the TypeContainer. This code was buggy.
29244 * interface.cs: Full registation here.
29246 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29248 * expression.cs: Remove reducer for binary expressions, it can not
29251 * const.cs: Put here the code that used to go into constant.cs
29253 * constant.cs: Put here the code for constants, this is a new base
29254 class for Literals.
29256 * literal.cs: Make Literal derive from Constant.
29258 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29260 * statement.cs (Return.Emit): Report error 157 if the user
29261 attempts to return from a finally block.
29263 (Return.Emit): Instead of emitting a return, jump to the end of
29266 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29267 LocalBuilder to store the result of the function. ReturnLabel is
29268 the target where we jump.
29271 2001-12-09 Radek Doulik <rodo@ximian.com>
29273 * cs-parser.jay: remember alias in current namespace
29275 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29278 * class.cs (LookupAlias): lookup alias in my_namespace
29280 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29282 (LookupAlias): lookup alias in this and if needed in parent
29285 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29289 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29290 making things static. I need this to avoid passing the
29291 TypeContainer when calling ParameterType.
29293 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29294 that did string manipulation to compute the type and then call
29295 GetType. Use Parameter.ParameterType instead.
29297 * cs-tokenizer.cs: Consume the suffix for floating values.
29299 * expression.cs (ParameterReference): figure out whether this is a
29300 reference parameter or not. Kill an extra variable by computing
29301 the arg_idx during emission.
29303 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29304 function that returns whether a parameter is an out/ref value or not.
29306 (Parameter.ParameterType): The type of the parameter (base,
29307 without ref/out applied).
29309 (Parameter.Resolve): Perform resolution here.
29310 (Parameter.ExternalType): The full type (with ref/out applied).
29312 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29313 support for expressions on the using statement.
29315 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29317 * statement.cs (Using.EmitLocalVariableDecls): Split the
29318 localvariable handling of the using statement.
29320 (Block.EmitMeta): Keep track of variable count across blocks. We
29321 were reusing slots on separate branches of blocks.
29323 (Try.Emit): Emit the general code block, we were not emitting it.
29325 Check the type of the declaration to be an IDisposable or
29326 something that can be implicity converted to it.
29328 Emit conversions if required.
29330 * ecore.cs (EmptyExpression): New utility class.
29331 (Expression.ImplicitConversionExists): New utility function.
29333 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29335 * statement.cs (Using): Implement.
29337 * expression.cs (LocalVariableReference): Support read only variables.
29339 * statement.cs: Remove the explicit emit for the Leave opcode.
29340 (VariableInfo): Add a readonly field.
29342 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29344 * ecore.cs (ConvCast): new class used to encapsulate the various
29345 explicit integer conversions that works in both checked and
29346 unchecked contexts.
29348 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29349 properly generate the overflow opcodes.
29351 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29353 * statement.cs: The correct type for the EmptyExpression is the
29354 element_type, not the variable type. Ravi pointed this out.
29356 2001-12-04 Ravi Pratap <ravi@ximian.com>
29358 * class.cs (Method::Define): Handle PInvoke methods specially
29359 by using DefinePInvokeMethod instead of the usual one.
29361 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29362 above to do the task of extracting information and defining the method.
29364 2001-12-04 Ravi Pratap <ravi@ximian.com>
29366 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29367 of the condition for string type.
29369 (Emit): Move that here.
29371 (ArrayCreation::CheckIndices): Keep string literals in their expression
29374 (EmitDynamicInitializers): Handle strings appropriately.
29376 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29378 * codegen.cs (EmitContext): Replace multiple variables with a
29379 single pointer to the current Switch statement.
29381 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29384 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29388 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29391 (Foreach.Emit): Foreach on arrays was not setting
29392 up the loop variables (for break/continue).
29394 (GotoCase): Semi-implented.
29396 2001-12-03 Ravi Pratap <ravi@ximian.com>
29398 * attribute.cs (CheckAttribute): Handle system attributes by using
29399 Attribute.GetAttributes to examine information we need.
29401 (GetValidPlaces): Same here.
29403 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29405 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29407 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29409 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29411 (Method::Emit): Handle the case when we are a PInvoke method.
29413 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29415 * expression.cs: Use ResolveWithSimpleName on compound names.
29417 2001-12-02 Ravi Pratap <ravi@ximian.com>
29419 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29420 before trying to reduce it.
29422 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29424 * constant.cs (LookupConstantValue): Implement.
29426 (EmitConstant): Use the above in emitting the constant.
29428 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29429 that are user-defined by doing a LookupConstantValue on them.
29431 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29434 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29436 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29438 (BaseAccess.DoResolve): Implement.
29440 (MemberAccess.DoResolve): Split this routine into a
29441 ResolveMemberAccess routine that can be used independently
29443 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29445 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29446 As that share bits of the implementation. Is returns a boolean,
29447 while As returns the Type that is being probed.
29449 2001-12-01 Ravi Pratap <ravi@ximian.com>
29451 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29452 instead of a Literal - much easier.
29454 (EnumInTransit): Remove - utterly useless :-)
29456 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29458 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29460 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29461 chain when we have no associated expression.
29463 2001-11-30 Ravi Pratap <ravi@ximian.com>
29465 * constant.cs (Define): Use Location while reporting the errror.
29467 Also emit a warning when 'new' is used and there is no inherited
29470 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29473 (LookupEnumValue): Implement to lookup an enum member's value and define it
29476 (Populate): Re-write accordingly to use the above routine.
29478 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29480 * expression.cs (This): Fix prototype for DoResolveLValue to
29481 override the base class DoResolveLValue.
29483 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29486 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29487 (we need to load the address of the field here). This fixes
29490 (FieldExpr.DoResolveLValue): Call the DoResolve
29491 function to initialize the Instance expression.
29493 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29494 correctly the GetEnumerator operation on a value type.
29496 * cs-parser.jay: Add more simple parsing error catches.
29498 * statement.cs (Switch): Add support for string switches.
29499 Handle null specially.
29501 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29503 2001-11-28 Ravi Pratap <ravi@ximian.com>
29505 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29507 (declare_local_constant): New helper function.
29509 * statement.cs (AddConstant): Keep a separate record of constants
29511 (IsConstant): Implement to determine if a variable is a constant.
29513 (GetConstantExpression): Implement.
29515 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29517 * statement.cs (IsVariableDefined): Re-write.
29519 2001-11-27 Ravi Pratap <ravi@ximian.com>
29521 * class.cs (TypeContainer::FindMembers): Look for constants
29522 in the case when we are looking for MemberTypes.Field
29524 * expression.cs (MemberAccess::DoResolve): Check that in the
29525 case we are a FieldExpr and a Literal, we are not being accessed
29526 by an instance reference.
29528 * cs-parser.jay (local_constant_declaration): Implement.
29530 (declaration_statement): Implement for constant declarations.
29532 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29534 * statement.cs (Switch): Catch double defaults.
29536 (Switch): More work on the switch() statement
29537 implementation. It works for integral values now, need to finish
29541 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29543 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29544 integer literals into other integer literals. To be used by
29547 2001-11-24 Ravi Pratap <ravi@ximian.com>
29549 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29552 (EmitDynamicInitializers): Cope with the above since we extract data
29553 directly from ArrayData now.
29555 (ExpectInitializers): Keep track of whether initializers are mandatory
29558 (Bounds): Make it a hashtable to prevent the same dimension being
29559 recorded for every element in that dimension.
29561 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29564 Also fix bug which was causing the indices to be emitted in the reverse
29567 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29569 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29570 unfinished. They do not work, because the underlying code is
29573 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29575 * cs-parser.jay: Remove bogus fixme.
29577 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29578 on Switch statement.
29580 2001-11-23 Ravi Pratap <ravi@ximian.com>
29582 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29585 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29586 parameter. Apparently, any expression is allowed.
29588 (ValidateInitializers): Update accordingly.
29590 (CheckIndices): Fix some tricky bugs thanks to recursion.
29592 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29593 I was being completely brain-dead.
29595 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29596 and re-write acordingly.
29598 (DelegateInvocation): Re-write accordingly.
29600 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29602 (MakeByteBlob): Handle types more correctly.
29604 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29605 initialization from expressions but it is incomplete because I am a complete
29608 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29610 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29611 on If. Basically, we have to return `true' (ie, we do return to
29612 our caller) only if both branches of the if return.
29614 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29615 short-circuit operators, handle them as short circuit operators.
29617 (Cast.DoResolve): Resolve type.
29618 (Cast.Cast): Take an expression as the target type.
29620 * cs-parser.jay (cast_expression): Remove old hack that only
29621 allowed a limited set of types to be handled. Now we take a
29622 unary_expression and we resolve to a type during semantic
29625 Use the grammar productions from Rhys to handle casts (this is
29626 not complete like Rhys syntax yet, we fail to handle that corner
29627 case that C# has regarding (-x), but we will get there.
29629 2001-11-22 Ravi Pratap <ravi@ximian.com>
29631 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29632 field which is an array type.
29634 * cs-parser.jay (declare_local_variables): Support array initialization too.
29636 * typemanager.cs (MakeKey): Implement.
29638 (everywhere): Use the above appropriately.
29640 * cs-parser.jay (for_statement): Update for array initialization while
29641 declaring variables.
29643 * ecore.cs : The error message was correct, it's the variable's names that
29644 were misleading ;-) Make the code more readable.
29646 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29647 the correct type etc.
29649 (ConvertExplicit): Handle Enum types by examining the underlying type.
29651 2001-11-21 Ravi Pratap <ravi@ximian.com>
29653 * parameter.cs (GetCallingConvention): Always return
29654 CallingConventions.Standard for now.
29656 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29658 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29659 and `r' after calling DoNumericPromotions.
29661 * ecore.cs: Fix error message (the types were in the wrong order).
29663 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29664 BindingFlags.Instance as well
29666 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29667 implicit int literal conversion in an empty cast so that we
29668 propagate the right type upstream.
29670 (UnboxCast): new class used to unbox value types.
29671 (Expression.ConvertExplicit): Add explicit type conversions done
29674 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29675 the target type before applying the implicit LongLiterals to ULong
29678 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29680 * cs-parser.jay (for_statement): Reworked the way For works: now
29681 we declare manually any variables that are introduced in
29682 for_initializer to solve the problem of having out-of-band code
29683 emition (that is what got for broken).
29685 (declaration_statement): Perform the actual variable declaration
29686 that used to be done in local_variable_declaration here.
29688 (local_variable_declaration): Do not declare anything, just pass
29689 the information on a DictionaryEntry
29691 2001-11-20 Ravi Pratap <ravi@ximian.com>
29693 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29694 re-write of the logic to now make it recursive.
29696 (UpdateIndices): Re-write accordingly.
29698 Store element data in a separate ArrayData list in the above methods.
29700 (MakeByteBlob): Implement to dump the array data into a byte array.
29702 2001-11-19 Ravi Pratap <ravi@ximian.com>
29704 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
29707 * constant.cs (Define): Implement.
29709 (EmitConstant): Re-write fully.
29711 Pass in location info.
29713 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
29716 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
29717 DictionaryEntry since we need location info too.
29719 (constant_declaration): Update accordingly.
29721 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
29722 code into another method : UpdateIndices.
29724 2001-11-18 Ravi Pratap <ravi@ximian.com>
29726 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
29727 some type checking etc.
29729 2001-11-17 Ravi Pratap <ravi@ximian.com>
29731 * expression.cs (ArrayCreation::ValidateInitializers): Implement
29732 bits to provide dimension info if the user skips doing that.
29734 Update second constructor to store the rank correctly.
29736 2001-11-16 Ravi Pratap <ravi@ximian.com>
29738 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
29739 and try to implement.
29741 * ../errors/cs0150.cs : Add.
29743 * ../errors/cs0178.cs : Add.
29745 2001-11-16 Miguel de Icaza <miguel@ximian.com>
29747 * statement.cs: Implement foreach on multi-dimensional arrays.
29749 * parameter.cs (Parameters.GetParameterByName): Also lookup the
29750 name of the params argument.
29752 * expression.cs: Use EmitStoreOpcode to get the right opcode while
29753 initializing the array.
29755 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
29756 we can use this elsewhere.
29758 * statement.cs: Finish implementation of foreach for single
29761 * cs-parser.jay: Use an out-of-band stack to pass information
29762 around, I wonder why I need this.
29764 foreach_block: Make the new foreach_block the current_block.
29766 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
29767 function used to return a static Parameters structure. Used for
29768 empty parameters, as those are created very frequently.
29770 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
29772 2001-11-15 Ravi Pratap <ravi@ximian.com>
29774 * interface.cs : Default modifier is private, not public. The
29775 make verify test passes again.
29777 2001-11-15 Ravi Pratap <ravi@ximian.com>
29779 * support.cs (ReflectionParameters): Fix logic to determine
29780 whether the last parameter is a params one. Test 9 passes again.
29782 * delegate.cs (Populate): Register the builders we define with
29783 RegisterParameterForBuilder. Test 19 passes again.
29785 * cs-parser.jay (property_declaration): Reference $6 instead
29786 of $$ to get at the location.
29788 (indexer_declaration): Similar stuff.
29790 (attribute): Ditto.
29792 * class.cs (Property): Register parameters for the Get and Set methods
29793 if they exist. Test 23 passes again.
29795 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
29796 call to EmitArguments as we are sure there aren't any params arguments.
29797 Test 32 passes again.
29799 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
29800 IndexOutOfRangeException.
29802 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
29803 Test 33 now passes again.
29805 2001-11-15 Miguel de Icaza <miguel@ximian.com>
29807 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
29808 broke a bunch of things. Will have to come up with a better way
29809 of tracking locations.
29811 * statement.cs: Implemented foreach for single dimension arrays.
29813 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29815 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
29816 an error. This removes the lookup from the critical path.
29818 * cs-parser.jay: Removed use of temporary_loc, which is completely
29821 2001-11-14 Miguel de Icaza <miguel@ximian.com>
29823 * support.cs (ReflectionParameters.ParameterModifier): Report
29824 whether the argument is a PARAMS argument or not.
29826 * class.cs: Set the attribute `ParamArrayAttribute' on the
29827 parameter argument.
29829 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
29830 and cons_param_array_attribute (ConstructorInfo for
29831 ParamArrayAttribute).,
29833 * codegen.cs: Emit the return using the `Return' statement, that
29834 way we can report the error correctly for missing return values.
29836 * class.cs (Method.Emit): Clean up.
29838 * expression.cs (Argument.Resolve): Take another argument: the
29839 location where this argument is used. Notice that this is not
29840 part of the "Argument" class as to reduce the size of the
29841 structure (we know the approximate location anyways).
29843 Test if the argument is a variable-reference, if not, then
29844 complain with a 206.
29846 (Argument.Emit): Emit addresses of variables.
29848 (Argument.FullDesc): Simplify.
29850 (Invocation.DoResolve): Update for Argument.Resolve.
29852 (ElementAccess.DoResolve): ditto.
29854 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
29855 method should be virtual, as this method is always virtual.
29857 (NewDelegate.DoResolve): Update for Argument.Resolve.
29859 * class.cs (ConstructorInitializer.DoResolve): ditto.
29861 * attribute.cs (Attribute.Resolve): ditto.
29863 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29865 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
29867 * expression.cs (ParameterReference): Drop IStackStorage and implement
29868 IAssignMethod instead.
29870 (LocalVariableReference): ditto.
29872 * ecore.cs (FieldExpr): Drop IStackStorage and implement
29873 IAssignMethod instead.
29875 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29877 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
29878 enumerations that are used in heavily used structures derive from
29879 byte in a laughable and pathetic attempt to reduce memory usage.
29880 This is the kind of pre-optimzations that you should not do at
29881 home without adult supervision.
29883 * expression.cs (UnaryMutator): New class, used to handle ++ and
29884 -- separatedly from the other unary operators. Cleans up the
29885 code, and kills the ExpressionStatement dependency in Unary.
29887 (Unary): Removed `method' and `Arguments' from this class, making
29888 it smaller, and moving it all to SimpleCall, so I can reuse this
29889 code in other locations and avoid creating a lot of transient data
29890 strucutres when not required.
29892 * cs-parser.jay: Adjust for new changes.
29894 2001-11-11 Miguel de Icaza <miguel@ximian.com>
29896 * enum.cs (Enum.Populate): If there is a failure during
29899 * cs-parser.jay (opt_enum_base): we used to catch type errors
29900 here, but this is really incorrect. The type error should be
29901 catched during semantic analysis.
29903 2001-12-11 Ravi Pratap <ravi@ximian.com>
29905 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
29906 current_local_parameters as expected since I, in my stupidity, had forgotten
29909 * attribute.cs (GetValidPlaces): Fix stupid bug.
29911 * class.cs (Method::Emit): Perform check on applicability of attributes.
29913 (Constructor::Emit): Ditto.
29915 (Field::Emit): Ditto.
29917 (Field.Location): Store location information.
29919 (Property, Event, Indexer, Operator): Ditto.
29921 * cs-parser.jay (field_declaration): Pass in location for each field.
29923 * ../errors/cs0592.cs : Add.
29925 2001-11-12 Ravi Pratap <ravi@ximian.com>
29927 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
29929 (InitCoreTypes): Update accordingly.
29931 (RegisterAttrType, LookupAttr): Implement.
29933 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
29934 info about the same.
29936 (Resolve): Update to populate the above as necessary.
29938 (Error592): Helper.
29940 (GetValidPlaces): Helper to the above.
29942 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
29944 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
29946 2001-11-12 Ravi Pratap <ravi@ximian.com>
29948 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
29950 * ../errors/cs0617.cs : Add.
29952 2001-11-11 Ravi Pratap <ravi@ximian.com>
29954 * enum.cs (Emit): Rename to Populate to be more consistent with what
29955 we expect it to do and when exactly it is called.
29957 * class.cs, rootcontext.cs : Update accordingly.
29959 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
29960 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
29962 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
29964 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
29965 of a fieldinfo using the above, when dealing with a FieldBuilder.
29967 2001-11-10 Ravi Pratap <ravi@ximian.com>
29969 * ../errors/cs0031.cs : Add.
29971 * ../errors/cs1008.cs : Add.
29973 * ../errrors/cs0543.cs : Add.
29975 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
29978 (FindMembers): Implement.
29980 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
29981 enums and delegates too.
29983 (enum_types): Rename to builder_to_enum.
29985 (delegate_types): Rename to builder_to_delegate.
29987 * delegate.cs (FindMembers): Implement.
29989 2001-11-09 Ravi Pratap <ravi@ximian.com>
29991 * typemanager.cs (IsEnumType): Implement.
29993 * enum.cs (Emit): Re-write parts to account for the underlying type
29994 better and perform checking etc.
29996 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
29997 of the underlying type.
29999 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30002 * enum.cs (error31): Helper to report error #31.
30004 * cs-parser.jay (enum_declaration): Store location of each member too.
30006 * enum.cs (member_to_location): New hashtable.
30008 (AddEnumMember): Update location hashtable.
30010 (Emit): Use the location of each member while reporting errors.
30012 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30014 * cs-parser.jay: A for_initializer if is a
30015 local_variable_declaration really ammount to have an implicit
30016 block with the variable declaration and no initializer for for.
30018 * statement.cs (For.Emit): Cope with null initializers.
30020 This fixes the infinite loop on for initializers.
30022 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30024 * enum.cs: More cleanup.
30026 * ecore.cs: Remove dead code.
30028 * class.cs (Property.Emit): More simplification.
30029 (Event.Emit): ditto.
30031 Reworked to have less levels of indentation.
30033 2001-11-08 Ravi Pratap <ravi@ximian.com>
30035 * class.cs (Property): Emit attributes.
30045 * enum.cs (Emit): Ditto.
30047 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30050 * class.cs (Field, Event, etc.): Move attribute generation into the
30051 Emit method everywhere.
30053 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30054 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30055 as we had no way of defining nested enums !
30057 * rootcontext.cs : Adjust code accordingly.
30059 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30061 2001-11-07 Ravi Pratap <ravi@ximian.com>
30063 * expression.cs (EvalConstantExpression): Move into ecore.cs
30065 * enum.cs (Enum): Rename some members and make them public and readonly
30066 according to our convention.
30068 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30071 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30073 (Enum::Emit): Write a simple version for now which doesn't try to compute
30074 expressions. I shall modify this to be more robust in just a while.
30076 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30078 (TypeContainer::CloseType): Create the Enum types too.
30080 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30082 * expression.cs (EvalConstantExpression): Get rid of completely.
30084 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30085 user-defined values and other cases.
30087 (IsValidEnumLiteral): Helper function.
30089 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30090 out there in the case we had a literal FieldExpr.
30092 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30094 (Literalize): Revamp a bit to take two arguments.
30096 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30098 2001-11-06 Ravi Pratap <ravi@ximian.com>
30100 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30102 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30104 (Resolve): Use the above to ensure we have proper initializers.
30106 2001-11-05 Ravi Pratap <ravi@ximian.com>
30108 * expression.cs (Expression::EvalConstantExpression): New method to
30109 evaluate constant expressions.
30111 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30113 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30115 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30118 (Binary.ResolveOperator): Handle operator != (object a, object b)
30119 and operator == (object a, object b);
30121 (Binary.DoNumericPromotions): Indicate whether the numeric
30122 promotion was possible.
30124 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30127 Made the ArrayAccess implement interface IAssignMethod instead of
30128 IStackStore as the order in which arguments are passed reflects
30131 * assign.cs: Instead of using expr.ExprClass to select the way of
30132 assinging, probe for the IStackStore/IAssignMethod interfaces.
30134 * typemanager.cs: Load InitializeArray definition.
30136 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30137 static data that can be used to initialize arrays.
30139 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30141 * expression.cs: Handle operator== and operator!= for booleans.
30143 (Conditioal.Reduce): Implement reducer for the ?: operator.
30145 (Conditional.Resolve): Implement dead code elimination.
30147 (Binary.Resolve): Catch string literals and return a new
30148 concatenated string.
30150 (Unary.Reduce): Implement reduction of unary expressions.
30152 * ecore.cs: Split out the expression core handling here.
30154 (Expression.Reduce): New method used to perform constant folding
30155 and CSE. This is needed to support constant-expressions.
30157 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30158 targets, and optimize for !x.
30160 2001-11-04 Ravi Pratap <ravi@ximian.com>
30162 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30163 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30164 set custom atttributes.
30166 * literal.cs (Literal::GetValue): New abstract method to return the actual
30167 value of the literal, cast as an object.
30169 (*Literal): Implement GetValue method.
30171 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30172 expressions to the arraylist but objects of type Argument.
30174 * class.cs (TypeContainer::Emit): Emit our attributes too.
30176 (Method::Emit, Constructor::Emit): Ditto.
30178 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30179 to be ignoring earlier.
30181 2001-11-03 Ravi Pratap <ravi@ximian.com>
30183 * attribute.cs (AttributeSection::Define): Implement to do the business
30184 of constructing a CustomAttributeBuilder.
30186 (Attribute): New trivial class. Increases readability of code.
30188 * cs-parser.jay : Update accordingly.
30190 (positional_argument_list, named_argument_list, named_argument): New rules
30192 (attribute_arguments): Use the above so that we are more correct.
30194 2001-11-02 Ravi Pratap <ravi@ximian.com>
30196 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30197 to perform all checks for a method with a params parameter.
30199 (Invocation::OverloadResolve): Update to use the above method and therefore
30200 cope correctly with params method invocations.
30202 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30205 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30206 constructors in our parent too because we can't afford to miss out on
30209 * attribute.cs (AttributeSection): New name for the class Attribute
30211 Other trivial changes to improve readability.
30213 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30214 use the new class names.
30216 2001-11-01 Ravi Pratap <ravi@ximian.com>
30218 * class.cs (Method::Define): Complete definition for params types too
30220 (Indexer::Define): Ditto.
30222 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30223 Cope everywhere with a request for info about the array parameter.
30225 2001-11-01 Ravi Pratap <ravi@ximian.com>
30227 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30229 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30230 local_variable_type to extract the string corresponding to the type.
30232 (local_variable_type): Fixup the action to use the new helper method.
30234 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30237 * expression.cs : Clean out code which uses the above.
30239 2001-10-31 Ravi Pratap <ravi@ximian.com>
30241 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30242 and bale out if necessary by returning a false.
30244 (RegisterProperty): Ditto.
30246 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30247 and print out appropriate error messages.
30249 * interface.cs (everywhere): Ditto.
30251 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30252 location to constructor.
30254 * class.cs (Property, Event, Indexer): Update accordingly.
30256 * ../errors/cs111.cs : Added.
30258 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30259 of a method, as laid down by the spec.
30261 (Invocation::OverloadResolve): Use the above method.
30263 2001-10-31 Ravi Pratap <ravi@ximian.com>
30265 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30266 now take a TypeContainer and a Parameters object.
30268 (ParameterData): Modify return type of ParameterModifier method to be
30269 Parameter.Modifier and not a string.
30271 (ReflectionParameters, InternalParameters): Update accordingly.
30273 * expression.cs (Argument::GetParameterModifier): Same here.
30275 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30276 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30277 symbol in it at all so maybe this is only for now.
30279 2001-10-30 Ravi Pratap <ravi@ximian.com>
30281 * support.cs (InternalParameters): Constructor now takes an extra argument
30282 which is the actual Parameters class.
30284 (ParameterDesc): Update to provide info on ref/out modifiers.
30286 * class.cs (everywhere): Update call to InternalParameters to pass in
30287 the second argument too.
30289 * support.cs (ParameterData): Add ParameterModifier, which is a method
30290 to return the modifier info [ref/out etc]
30292 (InternalParameters, ReflectionParameters): Implement the above.
30294 * expression.cs (Argument::ParameterModifier): Similar function to return
30295 info about the argument's modifiers.
30297 (Invocation::OverloadResolve): Update to take into account matching modifiers
30300 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30301 a new SetFormalParameters object which we pass to InternalParameters.
30303 2001-10-30 Ravi Pratap <ravi@ximian.com>
30305 * expression.cs (NewArray): Merge into the ArrayCreation class.
30307 2001-10-29 Ravi Pratap <ravi@ximian.com>
30309 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30310 NewUserdefinedArray into one as there wasn't much of a use in having
30313 * expression.cs (Argument): Change field's name to ArgType from Type.
30315 (Type): New readonly property which returns the proper type, taking into
30316 account ref/out modifiers.
30318 (everywhere): Adjust code accordingly for the above.
30320 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30321 whether we are emitting for a ref or out parameter.
30323 * expression.cs (Argument::Emit): Use the above field to set the state.
30325 (LocalVariableReference::Emit): Update to honour the flag and emit the
30328 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30330 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30332 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30334 (ReflectionParameters, InternalParameters): Implement the above method.
30336 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30339 (Invocation::FullMethodDesc): Ditto.
30341 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30343 * cs-parser.jay: Add extra production for the second form of array
30346 * expression.cs (ArrayCreation): Update to reflect the above
30349 * Small changes to prepare for Array initialization.
30351 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30353 * typemanager.cs (ImplementsInterface): interface might be null;
30354 Deal with this problem;
30356 Also, we do store negative hits on the cache (null values), so use
30357 this instead of calling t.GetInterfaces on the type everytime.
30359 2001-10-28 Ravi Pratap <ravi@ximian.com>
30361 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30363 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30364 split functionality out into different classes.
30366 (New::FormArrayType): Move into NewBuiltinArray.
30368 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30371 (NewBuiltinArray): New class to handle creation of built-in arrays.
30373 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30374 account creation of one-dimensional arrays.
30376 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30378 (NewUserdefinedArray::DoResolve): Implement.
30380 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30382 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30383 we maintain inside the TypeManager. This is necessary to perform lookups on the
30386 (LookupType): Update to perform GetType on the module builders too.
30388 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30390 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30392 2001-10-23 Ravi Pratap <ravi@ximian.com>
30394 * expression.cs (New::DoResolve): Implement guts of array creation.
30396 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30398 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30400 * expression.cs: Fix bug I introduced lsat night that broke
30403 (Expression.Resolve): Report a 246 error (can not resolve name)
30404 if we find a SimpleName in the stream.
30406 (Expression.ResolveLValue): Ditto.
30408 (Expression.ResolveWithSimpleName): This function is a variant of
30409 ResolveName, this one allows SimpleNames to be returned without a
30410 warning. The only consumer of SimpleNames is MemberAccess
30412 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30414 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30415 might arrive here. I have my doubts that this is correct.
30417 * statement.cs (Lock): Implement lock statement.
30419 * cs-parser.jay: Small fixes to support `lock' and `using'
30421 * cs-tokenizer.cs: Remove extra space
30423 * driver.cs: New flag --checked, allows to turn on integer math
30426 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30427 Threading.Monitor.Exit
30429 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30431 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30432 Expression Class to be IndexerAccess.
30434 Notice that Indexer::DoResolve sets the eclass to Value.
30436 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30438 * class.cs (TypeContainer::Emit): Emit code for indexers.
30440 * assign.cs (IAssignMethod): New interface implemented by Indexers
30441 and Properties for handling assignment.
30443 (Assign::Emit): Simplify and reuse code.
30445 * expression.cs (IndexerAccess, PropertyExpr): Implement
30446 IAssignMethod, clean up old code.
30448 2001-10-22 Ravi Pratap <ravi@ximian.com>
30450 * typemanager.cs (ImplementsInterface): New method to determine if a type
30451 implements a given interface. Provides a nice cache too.
30453 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30456 (ConvertReferenceExplicit): Ditto.
30458 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30459 various methods, with correct names etc.
30461 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30462 Operator.UnaryNegation.
30464 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30465 we have a unary plus or minus operator.
30467 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30470 * everywhere : update accordingly.
30472 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30475 * class.cs (Method::Define): For the case where we are implementing a method
30476 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30477 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30479 2001-10-21 Ravi Pratap <ravi@ximian.com>
30481 * interface.cs (FindMembers): Implement to work around S.R.E
30484 * typemanager.cs (IsInterfaceType): Implement.
30486 (FindMembers): Update to handle interface types too.
30488 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30489 use IsAssignableFrom as that is not correct - it doesn't work.
30491 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30492 and accordingly override EmitStatement.
30494 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30495 using the correct logic :-)
30497 2001-10-19 Ravi Pratap <ravi@ximian.com>
30499 * ../errors/cs-11.cs : Add to demonstrate error -11
30501 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30503 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30504 then pass this as a hint to ResolveLValue.
30506 * expression.cs (FieldExpr): Add Location information
30508 (FieldExpr::LValueResolve): Report assignment to readonly
30511 (Expression::ExprClassFromMemberInfo): Pass location information.
30513 (Expression::ResolveLValue): Add new method that resolves an
30516 (Expression::DoResolveLValue): Default invocation calls
30519 (Indexers): New class used to keep track of indexers in a given
30522 (IStackStore): Renamed from LValue, as it did not really describe
30523 what this did. Also ResolveLValue is gone from this interface and
30524 now is part of Expression.
30526 (ElementAccess): Depending on the element access type
30528 * typemanager.cs: Add `indexer_name_type' as a Core type
30529 (System.Runtime.CompilerServices.IndexerNameAttribute)
30531 * statement.cs (Goto): Take a location.
30533 2001-10-18 Ravi Pratap <ravi@ximian.com>
30535 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30536 if two delegates are compatible.
30538 (NewDelegate::DoResolve): Update to take care of the case when
30539 we instantiate a delegate from another delegate.
30541 * typemanager.cs (FindMembers): Don't even try to look up members
30542 of Delegate types for now.
30544 2001-10-18 Ravi Pratap <ravi@ximian.com>
30546 * delegate.cs (NewDelegate): New class to take care of delegate
30549 * expression.cs (New): Split the delegate related code out into
30550 the NewDelegate class.
30552 * delegate.cs (DelegateInvocation): New class to handle delegate
30555 * expression.cs (Invocation): Split out delegate related code into
30556 the DelegateInvocation class.
30558 2001-10-17 Ravi Pratap <ravi@ximian.com>
30560 * expression.cs (New::DoResolve): Implement delegate creation fully
30561 and according to the spec.
30563 (New::DoEmit): Update to handle delegates differently.
30565 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30566 because of which we were printing out arguments in reverse order !
30568 * delegate.cs (VerifyMethod): Implement to check if the given method
30569 matches the delegate.
30571 (FullDelegateDesc): Implement.
30573 (VerifyApplicability): Implement.
30575 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30576 delegate invocations too.
30578 (Invocation::Emit): Ditto.
30580 * ../errors/cs1593.cs : Added.
30582 * ../errors/cs1594.cs : Added.
30584 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30586 2001-10-16 Ravi Pratap <ravi@ximian.com>
30588 * typemanager.cs (intptr_type): Core type for System.IntPtr
30590 (InitCoreTypes): Update for the same.
30592 (iasyncresult_type, asynccallback_type): Ditto.
30594 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30597 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30600 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30601 the builders for the 4 members of a delegate type :-)
30603 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30606 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30608 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30610 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30612 * statement.cs (Break::Emit): Implement.
30613 (Continue::Emit): Implement.
30615 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30616 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30617 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30618 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30621 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30622 properties that track the label for the current loop (begin of the
30623 loop and end of the loop).
30625 2001-10-15 Ravi Pratap <ravi@ximian.com>
30627 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30628 use of emitting anything at all.
30630 * class.cs, rootcontext.cs : Get rid of calls to the same.
30632 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30634 (Populate): Define the constructor correctly and set the implementation
30637 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30640 (AddDelegateType): Implement.
30642 (IsDelegateType): Implement helper method.
30644 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30646 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30647 and accordingly handle it.
30649 * delegate.cs (Populate): Take TypeContainer argument.
30650 Implement bits to define the Invoke method. However, I still haven't figured out
30651 how to take care of the native int bit :-(
30653 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30654 Qualify the name of the delegate, not its return type !
30656 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30659 (StandardConversionExists): Checking for array types turns out to be recursive.
30661 (ConvertReferenceExplicit): Implement array conversion.
30663 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30665 2001-10-12 Ravi Pratap <ravi@ximian.com>
30667 * cs-parser.jay (delegate_declaration): Store the fully qualified
30668 name as it is a type declaration.
30670 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30673 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30674 as TypeContainer::DefineType.
30676 (Populate): Method in which all the definition of the various methods (Invoke)
30679 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30682 (CloseDelegate): Finally creates the delegate.
30684 * class.cs (TypeContainer::DefineType): Update to define delegates.
30685 (Populate, Emit and CloseType): Do the same thing here too.
30687 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30688 delegates in all these operations.
30690 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30692 * expression.cs: LocalTemporary: a new expression used to
30693 reference a temporary that has been created.
30695 * assign.cs: Handle PropertyAccess back here, so that we can
30696 provide the proper semantic access to properties.
30698 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30699 a few more explicit conversions.
30701 * modifiers.cs: `NEW' modifier maps to HideBySig.
30703 * expression.cs (PropertyExpr): Make this into an
30704 ExpressionStatement, and support the EmitStatement code path.
30706 Perform get/set error checking, clean up the interface.
30708 * assign.cs: recognize PropertyExprs as targets, and if so, turn
30709 them into toplevel access objects.
30711 2001-10-12 Miguel de Icaza <miguel@ximian.com>
30713 * expression.cs: PropertyExpr::PropertyExpr: use work around the
30716 * typemanager.cs: Keep track here of our PropertyBuilders again to
30717 work around lameness in SRE.
30719 2001-10-11 Miguel de Icaza <miguel@ximian.com>
30721 * expression.cs (LValue::LValueResolve): New method in the
30722 interface, used to perform a second resolution pass for LValues.
30724 (This::DoResolve): Catch the use of this in static methods.
30726 (This::LValueResolve): Implement.
30728 (This::Store): Remove warning, assigning to `this' in structures
30731 (Invocation::Emit): Deal with invocation of
30732 methods on value types. We need to pass the address to structure
30733 methods rather than the object itself. (The equivalent code to
30734 emit "this" for structures leaves the entire structure on the
30735 stack instead of a pointer to it).
30737 (ParameterReference::DoResolve): Compute the real index for the
30738 argument based on whether the method takes or not a `this' pointer
30739 (ie, the method is static).
30741 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
30742 value types returned from functions when we need to invoke a
30743 method on the sturcture.
30746 2001-10-11 Ravi Pratap <ravi@ximian.com>
30748 * class.cs (TypeContainer::DefineType): Method to actually do the business of
30749 defining the type in the Modulebuilder or Typebuilder. This is to take
30750 care of nested types which need to be defined on the TypeBuilder using
30751 DefineNestedMethod.
30753 (TypeContainer::GetClassBases): Implement. Essentially the code from the
30754 methods in RootContext, only ported to be part of TypeContainer.
30756 (TypeContainer::GetInterfaceOrClass): Ditto.
30758 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
30760 * interface.cs (Interface::DefineInterface): New method. Does exactly
30761 what RootContext.CreateInterface did earlier, only it takes care of nested types
30764 (Interface::GetInterfaces): Move from RootContext here and port.
30766 (Interface::GetInterfaceByName): Same here.
30768 * rootcontext.cs (ResolveTree): Re-write.
30770 (PopulateTypes): Re-write.
30772 * class.cs (TypeContainer::Populate): Populate nested types too.
30773 (TypeContainer::Emit): Emit nested members too.
30775 * typemanager.cs (AddUserType): Do not make use of the FullName property,
30776 instead just use the name argument passed in as it is already fully
30779 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
30780 to TypeContainer mapping to see if a type is user-defined.
30782 * class.cs (TypeContainer::CloseType): Implement.
30784 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
30785 the default constructor.
30787 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
30790 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
30792 * interface.cs (CloseType): Create the type here.
30794 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
30797 Remove all the methods which are now in TypeContainer.
30799 2001-10-10 Ravi Pratap <ravi@ximian.com>
30801 * delegate.cs (Define): Re-write bits to define the delegate
30804 2001-10-10 Miguel de Icaza <miguel@ximian.com>
30806 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
30808 * expression.cs (ImplicitReferenceConversion): handle null as well
30809 as a source to convert to any reference type.
30811 * statement.cs (Return): Perform any implicit conversions to
30812 expected return type.
30814 Validate use of return statement.
30816 * codegen.cs (EmitContext): Pass the expected return type here.
30818 * class.cs (Method, Constructor, Property): Pass expected return
30819 type to EmitContext.
30821 2001-10-09 Miguel de Icaza <miguel@ximian.com>
30823 * expression.cs: Make DoResolve take an EmitContext instead of a
30826 Replaced `l' and `location' for `loc', for consistency.
30828 (Error, Warning): Remove unneeded Tc argument.
30830 * assign.cs, literal.cs, constant.cs: Update to new calling
30833 * codegen.cs: EmitContext now contains a flag indicating whether
30834 code is being generated in a static method or not.
30836 * cs-parser.jay: DecomposeQI, new function that replaces the old
30837 QualifiedIdentifier. Now we always decompose the assembled
30838 strings from qualified_identifier productions into a group of
30841 2001-10-08 Miguel de Icaza <miguel@ximian.com>
30843 * rootcontext.cs: Deal with field-less struct types correctly now
30844 by passing the size option to Define Type.
30846 * class.cs: Removed hack that created one static field.
30848 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30850 * statement.cs: Moved most of the code generation here.
30852 2001-10-09 Ravi Pratap <ravi@ximian.com>
30854 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
30857 (ElementAccess): Remove useless bits for now - keep checks as the spec
30860 2001-10-08 Ravi Pratap <ravi@ximian.com>
30862 * expression.cs (ElementAccess::DoResolve): Remove my crap code
30863 and start performing checks according to the spec.
30865 2001-10-07 Ravi Pratap <ravi@ximian.com>
30867 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
30868 rank_specifiers instead.
30870 (rank_specifiers): Change the order in which the rank specifiers are stored
30872 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
30874 * expression.cs (ElementAccess): Implement the LValue interface too.
30876 2001-10-06 Ravi Pratap <ravi@ximian.com>
30878 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
30879 except that user defined conversions are not included.
30881 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
30882 perform the conversion of the return type, if necessary.
30884 (New::DoResolve): Check whether we are creating an array or an object
30885 and accordingly do the needful.
30887 (New::Emit): Same here.
30889 (New::DoResolve): Implement guts of array creation.
30891 (New::FormLookupType): Helper function.
30893 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30895 * codegen.cs: Removed most of the code generation here, and move the
30896 corresponding code generation bits to the statement classes.
30898 Added support for try/catch/finalize and throw.
30900 * cs-parser.jay: Added support for try/catch/finalize.
30902 * class.cs: Catch static methods having the flags override,
30903 virtual or abstract.
30905 * expression.cs (UserCast): This user cast was not really doing
30906 what it was supposed to do. Which is to be born in fully resolved
30907 state. Parts of the resolution were being performed at Emit time!
30911 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30913 * expression.cs: Implicity convert the result from UserCast.
30915 2001-10-05 Ravi Pratap <ravi@ximian.com>
30917 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
30918 prevented it from working correctly.
30920 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
30921 merely ConvertImplicit.
30923 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30925 * typemanager.cs: Make the LookupTypeContainer function static,
30926 and not per-instance.
30928 * class.cs: Make static FindMembers (the one that takes a Type
30931 * codegen.cs: Add EmitForeach here.
30933 * cs-parser.jay: Make foreach a toplevel object instead of the
30934 inline expansion, as we need to perform semantic analysis on it.
30936 2001-10-05 Ravi Pratap <ravi@ximian.com>
30938 * expression.cs (Expression::ImplicitUserConversion): Rename to
30939 UserDefinedConversion.
30941 (Expression::UserDefinedConversion): Take an extra argument specifying
30942 whether we look for explicit user conversions too.
30944 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
30946 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
30948 (ExplicitUserConversion): Make it a call to UserDefinedConversion
30949 with the appropriate arguments.
30951 * cs-parser.jay (cast_expression): Record location too.
30953 * expression.cs (Cast): Record location info.
30955 (Expression::ConvertExplicit): Take location argument.
30957 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
30958 to determine if we are doing explicit conversions.
30960 (UserCast::Emit): Update accordingly.
30962 (Expression::ConvertExplicit): Report an error if everything fails.
30964 * ../errors/cs0030.cs : Add.
30966 2001-10-04 Miguel de Icaza <miguel@ximian.com>
30968 * modifiers.cs: If the ABSTRACT keyword is present, also set the
30969 virtual and newslot bits.
30971 * class.cs (TypeContainer::RegisterRequiredImplementations):
30972 Record methods we need.
30974 (TypeContainer::MakeKey): Helper function to make keys for
30975 MethodBases, since the Methodbase key is useless.
30977 (TypeContainer::Populate): Call RegisterRequiredImplementations
30978 before defining the methods.
30980 Create a mapping for method_builders_to_methods ahead of time
30981 instead of inside a tight loop.
30983 (::RequireMethods): Accept an object as the data to set into the
30984 hashtable so we can report interface vs abstract method mismatch.
30986 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30988 * report.cs: Make all of it static.
30990 * rootcontext.cs: Drop object_type and value_type computations, as
30991 we have those in the TypeManager anyways.
30993 Drop report instance variable too, now it is a global.
30995 * driver.cs: Use try/catch on command line handling.
30997 Add --probe option to debug the error reporting system with a test
31000 * report.cs: Add support for exiting program when a probe
31001 condition is reached.
31003 2001-10-03 Ravi Pratap <ravi@ximian.com>
31005 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31006 we do a forcible conversion regardless of type, to check if
31007 ForceConversion returns a null.
31009 (Binary::error19): Use location to report error.
31011 (Unary::error23): Use location here too.
31013 * ../errors/cs0019.cs : Check in.
31015 * ../errors/cs0023.cs : Check in.
31017 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31018 case of a non-null MethodInfo object with a length of 0 !
31020 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31021 an applicable member - according to the spec :-)
31022 Also fix logic to find members in base types.
31024 (Unary::ResolveOperator): Same here.
31026 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31027 as I was getting thoroughly confused between this and error19 :-)
31029 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31030 (::FindMostEncompassedType): Implement.
31031 (::FindMostEncompassingType): Implement.
31032 (::StandardConversionExists): Implement.
31034 (UserImplicitCast): Re-vamp. We now need info about most specific
31035 source and target types so that we can do the necessary conversions.
31037 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31038 mathematical union with no duplicates.
31040 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31042 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31043 in order from base classes to child classes, so that we can in
31044 child classes look up in our parent for method names and
31045 attributes (required for handling abstract, virtual, new, override
31046 constructs: we need to instrospect our base class, and if we dont
31047 populate the classes in order, the introspection might be
31048 incorrect. For example, a method could query its parent before
31049 the parent has any methods and would determine that the parent has
31050 no abstract methods (while it could have had them)).
31052 (RootContext::CreateType): Record the order in which we define the
31055 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31057 * class.cs (TypeContainer::Populate): Also method definitions can
31058 fail now, keep track of this.
31060 (TypeContainer::FindMembers): Implement support for
31061 DeclaredOnly/noDeclaredOnly flag.
31063 (Constructor::Emit) Return the ConstructorBuilder.
31065 (Method::Emit) Return the MethodBuilder.
31066 Check for abstract or virtual methods to be public.
31068 * rootcontext.cs (RootContext::CreateType): Register all the
31069 abstract methods required for the class to be complete and the
31070 interface methods that must be implemented.
31072 * cs-parser.jay: Report error 501 (method requires body if it is
31073 not marked abstract or extern).
31075 * expression.cs (TypeOf::Emit): Implement.
31077 * typemanager.cs: runtime_handle_type, new global type.
31079 * class.cs (Property::Emit): Generate code for properties.
31081 2001-10-02 Ravi Pratap <ravi@ximian.com>
31083 * expression.cs (Unary::ResolveOperator): Find operators on base type
31084 too - we now conform exactly to the spec.
31086 (Binary::ResolveOperator): Same here.
31088 * class.cs (Operator::Define): Fix minor quirk in the tests.
31090 * ../errors/cs0215.cs : Added.
31092 * ../errors/cs0556.cs : Added.
31094 * ../errors/cs0555.cs : Added.
31096 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31098 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31099 single integer which is really efficient
31101 2001-10-01 Ravi Pratap <ravi@ximian.com>
31103 * expression.cs (Expression::ImplicitUserConversion): Use location
31104 even in the case when we are examining True operators.
31106 * class.cs (Operator::Define): Perform extensive checks to conform
31107 with the rules for operator overloading in the spec.
31109 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31110 some of the other conversions mentioned in the spec.
31112 * typemanager.cs (array_type): New static member for the System.Array built-in
31115 (cloneable_interface): For System.ICloneable interface.
31117 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31118 we start resolving the tree and populating types.
31120 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31122 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31124 * expression.cs (Expression::ExprClassFromMemberInfo,
31125 Expression::Literalize): Create literal expressions from
31126 FieldInfos which are literals.
31128 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31129 type casts, because they were wrong. The test suite in tests
31132 (ImplicitNumericConversion): ushort to ulong requires a widening
31135 Int32 constant to long requires widening cast as well.
31137 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31138 for integers because the type on the stack is not i4.
31140 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31142 * expression.cs (report118): require location argument.
31144 * parameter.cs: Do not dereference potential null value.
31146 * class.cs: Catch methods that lack the `new' keyword when
31147 overriding a name. Report warnings when `new' is used without
31148 anything being there to override.
31150 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31152 * class.cs: Only add constructor to hashtable if it is non-null
31153 (as now constructors can fail on define).
31155 (TypeManager, Class, Struct): Take location arguments.
31157 Catch field instance initialization in structs as errors.
31159 accepting_filter: a new filter for FindMembers that is static so
31160 that we dont create an instance per invocation.
31162 (Constructor::Define): Catch errors where a struct constructor is
31165 * cs-parser.jay: Pass location information for various new
31168 * delegate.cs (Delegate): take a location argument.
31170 * driver.cs: Do not call EmitCode if there were problesm in the
31171 Definition of the types, as many Builders wont be there.
31173 * decl.cs (Decl::Decl): Require a location argument.
31175 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31176 into integers, and find the most appropiate integer for it.
31178 * literal.cs: Implement ULongLiteral.
31180 * rootcontext.cs: Provide better information about the location of
31181 failure when CreateType fails.
31183 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31185 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31188 * expression.cs (Binary::CheckShiftArguments): Add missing type
31190 (Binary::ResolveOperator): Add type to the logical and and logical
31191 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31194 (Binary::DoNumericPromotions): In the case where either argument
31195 is ulong (and most signed types combined with ulong cause an
31196 error) perform implicit integer constant conversions as well.
31198 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31200 * expression.cs (UserImplicitCast): Method should always be
31202 (Invocation::BetterConversion): Simplified test for IntLiteral.
31204 (Expression::ImplicitNumericConversion): Split this routine out.
31205 Put the code that performs implicit constant integer conversions
31208 (Expression::Resolve): Become a wrapper around DoResolve so we can
31209 check eclass and type being set after resolve.
31211 (Invocation::Badness): Remove this dead function
31213 (Binary::ResolveOperator): Do not compute the expensive argumnets
31214 unless we have a union for it.
31216 (Probe::Emit): Is needs to do an isinst and then
31217 compare against null.
31219 (::CanConvert): Added Location argument. If the Location argument
31220 is null (Location.Null), then we do not report errors. This is
31221 used by the `probe' mechanism of the Explicit conversion. We do
31222 not want to generate an error for something that the user
31223 explicitly requested to be casted. But the pipeline for an
31224 explicit cast first tests for potential implicit casts.
31226 So for now, if the Location is null, it means `Probe only' to
31227 avoid adding another argument. Might have to revise this
31230 (ClassCast): New class used to type cast objects into arbitrary
31231 classes (used in Explicit Reference Conversions).
31233 Implement `as' as well.
31235 Reverted all the patches from Ravi below: they were broken:
31237 * The use of `level' as a mechanism to stop recursive
31238 invocations is wrong. That was there just to catch the
31239 bug with a strack trace but not as a way of addressing
31242 To fix the problem we have to *understand* what is going
31243 on and the interactions and come up with a plan, not
31244 just get things going.
31246 * The use of the type conversion cache that I proposed
31247 last night had an open topic: How does this work across
31248 protection domains. A user defined conversion might not
31249 be public in the location where we are applying the
31250 conversion, a different conversion might be selected
31251 (ie, private A->B (better) but public B->A (worse),
31252 inside A, A->B applies, but outside it, B->A will
31255 * On top of that (ie, even if the above is solved),
31256 conversions in a cache need to be abstract. Ie, `To
31257 convert from an Int to a Short use an OpcodeCast', not
31258 `To convert from an Int to a Short use the OpcodeCast on
31259 the variable 5' (which is what this patch was doing).
31261 2001-09-28 Ravi Pratap <ravi@ximian.com>
31263 * expression.cs (Invocation::ConversionExists): Re-write to use
31264 the conversion cache
31266 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31267 cache all conversions done, not just user-defined ones.
31269 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31270 to determine if a conversion exists instead of acutually trying to
31271 perform the conversion. It's faster too.
31273 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31274 and only then attempt the implicit conversion.
31276 2001-09-28 Ravi Pratap <ravi@ximian.com>
31278 * expression.cs (ConvertImplicit): Use a cache for conversions
31279 already found. Check level of recursion and bail out if necessary.
31281 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31283 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31284 Export standard methods that we expect for string operations.
31286 * statement.cs (Block::UsageWarning): Track usage of variables and
31287 report the errors for not used variables.
31289 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31292 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31294 * codegen.cs: remove unnneded code
31296 * expression.cs: Removed BuiltinTypeAccess class
31298 Fix the order in which implicit conversions are
31301 The previous fixed dropped support for boxed conversions (adding a
31302 test to the test suite now)
31304 (UserImplicitCast::CanConvert): Remove test for source being null,
31305 that code is broken. We should not feed a null to begin with, if
31306 we do, then we should track the bug where the problem originates
31307 and not try to cover it up here.
31309 Return a resolved expression of type UserImplicitCast on success
31310 rather than true/false. Ravi: this is what I was talking about,
31311 the pattern is to use a static method as a "constructor" for
31314 Also, do not create arguments until the very last minute,
31315 otherwise we always create the arguments even for lookups that
31316 will never be performed.
31318 (UserImplicitCast::Resolve): Eliminate, objects of type
31319 UserImplicitCast are born in a fully resolved state.
31321 * typemanager.cs (InitCoreTypes): Init also value_type
31322 (System.ValueType).
31324 * expression.cs (Cast::Resolve): First resolve the child expression.
31326 (LValue): Add new method AddressOf to be used by
31329 Change the argument of Store to take an EmitContext instead of an
31330 ILGenerator, because things like FieldExpr need to be able to call
31331 their children expression to generate the instance code.
31333 (Expression::Error, Expression::Warning): Sugar functions for
31336 (Expression::MemberLookup): Accept a TypeContainer instead of a
31337 Report as the first argument.
31339 (Expression::ResolvePrimary): Killed. I still want to improve
31340 this as currently the code is just not right.
31342 (Expression::ResolveMemberAccess): Simplify, but it is still
31345 (Unary::Resolve): Catch errors in AddressOf operators.
31347 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31348 index to a byte for the short-version, or the compiler will choose
31349 the wrong Emit call, which generates the wrong data.
31351 (ParameterReference::Emit, ::Store): same.
31353 (FieldExpr::AddressOf): Implement.
31355 * typemanager.cs: TypeManager: made public variable instead of
31358 * driver.cs: document --fatal.
31360 * report.cs (ErrorMessage, WarningMessage): new names for the old
31361 Error and Warning classes.
31363 * cs-parser.jay (member_access): Turn built-in access to types
31364 into a normal simplename
31366 2001-09-27 Ravi Pratap <ravi@ximian.com>
31368 * expression.cs (Invocation::BetterConversion): Fix to cope
31369 with q being null, since this was introducing a bug.
31371 * expression.cs (ConvertImplicit): Do built-in conversions first.
31373 2001-09-27 Ravi Pratap <ravi@ximian.com>
31375 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31377 2001-09-27 Ravi Pratap <ravi@ximian.com>
31379 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31380 I had introduced long ago (what's new ?).
31382 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31383 the work of all the checking.
31384 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31385 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31387 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31388 that is the right way.
31390 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31391 overloading resolution. Use everywhere instead of cutting and pasting code.
31393 (Binary::ResolveOperator): Use MakeUnionSet.
31395 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31396 we have to convert to bool types. Not complete yet.
31398 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31400 * typemanager.cs (TypeManager::CSharpName): support ushort.
31402 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31403 to provide an expression that performsn an implicit constant int
31404 conversion (section 6.1.6).
31405 (Expression::ConvertImplicitRequired): Reworked to include
31406 implicit constant expression conversions.
31408 (Expression::ConvertNumericExplicit): Finished.
31410 (Invocation::Emit): If InstanceExpression is null, then it means
31411 that we perform a call on this.
31413 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31415 * expression.cs (Unary::Emit): Remove some dead code.
31416 (Probe): Implement Resolve and Emit for `is'.
31417 (Expression::ConvertImplicitRequired): Attempt to do constant
31418 expression conversions here. Maybe should be moved to
31419 ConvertImplicit, but I am not sure.
31420 (Expression::ImplicitLongConstantConversionPossible,
31421 Expression::ImplicitIntConstantConversionPossible): New functions
31422 that tell whether is it possible to apply an implicit constant
31423 expression conversion.
31425 (ConvertNumericExplicit): Started work on explicit numeric
31428 * cs-parser.jay: Update operator constants.
31430 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31431 (Parameters::GetSignature): Hook up VerifyArgs here.
31432 (Parameters::VerifyArgs): Verifies that no two arguments have the
31435 * class.cs (Operator): Update the operator names to reflect the
31436 ones that the spec expects (as we are just stringizing the
31439 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31440 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31441 previous usage did only work for our methods.
31442 (Expression::ConvertImplicit): Handle decimal implicit numeric
31443 conversions as well.
31444 (Expression::InternalTypeConstructor): Used to invoke constructors
31445 on internal types for default promotions.
31447 (Unary::Emit): Implement special handling for the pre/post
31448 increment/decrement for overloaded operators, as they need to have
31449 the same semantics as the other operators.
31451 (Binary::ResolveOperator): ditto.
31452 (Invocation::ConversionExists): ditto.
31453 (UserImplicitCast::Resolve): ditto.
31455 2001-09-26 Ravi Pratap <ravi@ximian.com>
31457 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31458 operator, return after emitting body. Regression tests pass again !
31460 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31461 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31462 (Invocation::OverloadResolve): Ditto.
31463 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31465 * everywhere : update calls to the above methods accordingly.
31467 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31469 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31471 * expression.cs (ExpressionStatement): New base class used for
31472 expressions that can appear in statements, so that we can provide
31473 an alternate path to generate expression that do not leave a value
31476 (Expression::Emit, and all the derivatives): We no longer return
31477 whether a value is left on the stack or not. Every expression
31478 after being emitted leaves a single value on the stack.
31480 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31481 facilties of ExpressionStatement if possible.
31483 * cs-parser.jay: Update statement_expression.
31485 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31487 * driver.cs: Change the wording of message
31489 2001-09-25 Ravi Pratap <ravi@ximian.com>
31491 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31492 the type of the expression to the return type of the method if
31493 we have an overloaded operator match ! The regression tests pass again !
31494 (Unary::ResolveOperator): Ditto.
31496 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31497 to find "op_Implicit", not "implicit" ;-)
31498 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31499 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31501 * everywhere : Correct calls to the above accordingly.
31503 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31504 (ConvertImplicit): Do user-defined conversion if it exists.
31506 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31508 * assign.cs: track location.
31509 (Resolve): Use implicit conversions on assignment.
31511 * literal.cs: Oops. Not good, Emit of short access values should
31512 pass (Bytes) or the wrong argument will be selected.
31514 * expression.cs (Unary::Emit): Emit code for -expr.
31516 (Unary::ResolveOperator): Handle `Substract' for non-constants
31517 (substract from zero from the non-constants).
31518 Deal with Doubles as well.
31520 (Expression::ConvertImplicitRequired): New routine that reports an
31521 error if no implicit conversion exists.
31523 (Invocation::OverloadResolve): Store the converted implicit
31524 expressions if we make them
31526 2001-09-24 Ravi Pratap <ravi@ximian.com>
31528 * class.cs (ConstructorInitializer): Take a Location argument.
31529 (ConstructorBaseInitializer): Same here.
31530 (ConstructorThisInitializer): Same here.
31532 * cs-parser.jay : Update all calls accordingly.
31534 * expression.cs (Unary, Binary, New): Take location argument.
31535 Update accordingly everywhere.
31537 * cs-parser.jay : Update all calls to the above to take a location
31540 * class.cs : Ditto.
31542 2001-09-24 Ravi Pratap <ravi@ximian.com>
31544 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31545 (Invocation::BetterConversion): Same here
31546 (Invocation::ConversionExists): Ditto.
31548 (Invocation::ConversionExists): Implement.
31550 2001-09-22 Ravi Pratap <ravi@ximian.com>
31552 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31553 Also take an additional TypeContainer argument.
31555 * All over : Pass in TypeContainer as argument to OverloadResolve.
31557 * typemanager.cs (CSharpName): Update to check for the string type and return
31560 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31563 2001-09-21 Ravi Pratap <ravi@ximian.com>
31565 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31566 (Invocation::BetterFunction): Implement.
31567 (Invocation::BetterConversion): Implement.
31568 (Invocation::ConversionExists): Skeleton, no implementation yet.
31570 Okay, things work fine !
31572 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31574 * typemanager.cs: declare and load enum_type, delegate_type and
31577 * expression.cs (Expression::Emit): Now emit returns a value that
31578 tells whether a value is left on the stack or not. This strategy
31579 might be reveted tomorrow with a mechanism that would address
31580 multiple assignments.
31581 (Expression::report118): Utility routine to report mismatches on
31584 (Unary::Report23): Report impossible type/operator combination
31587 (Unary::IsIncrementableNumber): Whether the type can be
31588 incremented or decremented with add.
31589 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31591 (Unary::ResolveOperator): Implement ++, !, ~,
31593 (Invocation::Emit): Deal with new Emit convetion.
31595 * All Expression derivatives: Updated their Emit method to return
31596 whether they leave values on the stack or not.
31598 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31599 stack for expressions that are statements.
31601 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31603 * expression.cs (LValue): New interface. Must be implemented by
31605 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31608 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31609 interface for generating code, simplifies the code.
31611 2001-09-20 Ravi Pratap <ravi@ximian.com>
31613 * expression.cs (everywhere): Comment out return statements in ::Resolve
31614 methods to avoid the warnings.
31616 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31618 * driver.cs (parse): Report error 2001 if we can not open the
31621 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31624 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31627 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31628 otherwise nested blocks end up with the same index.
31630 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31632 * expression.cs: Instead of having FIXMEs in the Resolve
31633 functions, throw exceptions so it is obvious that we are facing a
31636 * cs-parser.jay (invocation_expression): Pass Location information.
31638 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31639 Use a basename for those routines because .NET does not like paths
31642 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31645 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31647 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31648 are loading the correct data types (throws an exception if not).
31649 (TypeManager::InitCoreTypes): Use CoreLookupType
31651 * expression.cs (Unary::ResolveOperator): return the child
31652 expression for expressions which are just +expr.
31653 (Unary::ResolveOperator): Return negative literals for -LITERAL
31654 expressions (otherwise they are Unary {Literal}).
31655 (Invocation::Badness): Take into account `Implicit constant
31656 expression conversions'.
31658 * literal.cs (LongLiteral): Implement long literal class.
31659 (IntLiteral): export the `Value' of the intliteral.
31661 2001-09-19 Ravi Pratap <ravi@ximian.com>
31663 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31665 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31666 instead of 'Operator'
31668 * expression.cs (Binary::ResolveOperator): Update accordingly.
31669 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31672 * cs-parser.jay (unary_expression): Update to use the new names.
31674 * gen-treedump.cs (GetUnary): Same here.
31676 * expression.cs (Unary::Resolve): Implement.
31677 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31678 operators are found instead of making noise ;-)
31679 (Unary::ResolveOperator): New method to do precisely the same thing which
31680 Binary::ResolveOperator does for Binary expressions.
31681 (Unary.method, .Arguments): Add.
31682 (Unary::OperName): Implement.
31683 (Unary::ForceConversion): Copy and Paste !
31685 * class.cs (Operator::Define): Fix a small bug for the case when we have
31688 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31689 for the inbuilt operators. Only overloading works for now ;-)
31691 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31693 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31694 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31696 * expression.cs (This::Emit): Implement.
31697 (This::Resolve): Implement.
31698 (TypeOf:Resolve): Implement.
31699 (Expression::ResolveSimpleName): Add an implicit this to instance
31701 (MemberAccess::Resolve): Deal with Parameters and Fields.
31702 Bind instance variable to Field expressions.
31703 (FieldExpr::Instance): New field used to track the expression that
31704 represents the object instance.
31705 (FieldExpr::Resolve): Track potential errors from MemberLookup not
31707 (FieldExpr::Emit): Implement.
31709 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
31710 the last instruction contains a return opcode to avoid generating
31711 the last `ret' instruction (this generates correct code, and it is
31712 nice to pass the peverify output).
31714 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
31715 initializer for static and instance variables.
31716 (Constructor::Emit): Allow initializer to be null in the case of
31717 static constructors. Only emit initializer for instance
31720 (TypeContainer::FindMembers): Return a null array if there are no
31723 Also fix the code for the MemberTypes.Method branch, as it was not
31724 scanning that for operators (or tried to access null variables before).
31726 * assign.cs (Assign::Emit): Handle instance and static fields.
31730 * driver.cs: Stop compilation if there are parse errors.
31732 * cs-parser.jay (constructor_declaration): Provide default base
31733 initializer for non-static constructors.
31734 (constructor_declarator): Do not provide a default base
31735 initializers if none was specified.
31736 Catch the fact that constructors should not have parameters.
31738 * class.cs: Do not emit parent class initializers for static
31739 constructors, that should be flagged as an error.
31741 2001-09-18 Ravi Pratap <ravi@ximian.com>
31743 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
31744 Move back code into TypeContainer::Populate.
31746 2001-09-18 Ravi Pratap <ravi@ximian.com>
31748 * class.cs (TypeContainer::AddConstructor): Fix the check to
31749 compare against Name, not Basename.
31750 (Operator::OpType): Change Plus and Minus to Add and Subtract.
31752 * cs-parser.jay : Update accordingly.
31754 * class.cs (TypeContainer::FindMembers): For the case where we are searching
31755 for methods, don't forget to look into the operators too.
31756 (RegisterMethodBuilder): Helper method to take care of this for
31757 methods, constructors and operators.
31758 (Operator::Define): Completely revamp.
31759 (Operator.OperatorMethod, MethodName): New fields.
31760 (TypeContainer::Populate): Move the registering of builders into
31761 RegisterMethodBuilder.
31762 (Operator::Emit): Re-write.
31764 * expression.cs (Binary::Emit): Comment out code path to emit method
31765 invocation stuff for the case when we have a user defined operator. I am
31766 just not able to get it right !
31768 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31770 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
31773 (Expression::MemberLookup): Provide a version that allows to
31774 specify the MemberTypes and BindingFlags.
31776 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
31777 so it was not fetching variable information from outer blocks.
31779 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
31780 Beforefieldinit as it was buggy.
31782 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
31783 that Ravi put here.
31785 * class.cs (Constructor::Emit): Only emit if block is not null.
31786 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
31787 deal with this by semantically definining it as if the user had
31790 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
31791 constructors as we now "emit" them at a higher level.
31793 (TypeContainer::DefineDefaultConstructor): Used to define the
31794 default constructors if none was provided.
31796 (ConstructorInitializer): Add methods Resolve and Emit.
31798 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
31800 2001-09-17 Ravi Pratap <ravi@ximian.com>
31802 * class.cs (TypeContainer::EmitDefaultConstructor): Register
31803 the default constructor builder with our hashtable for methodbuilders
31806 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
31807 and argument_count is 0 in which case we have a match.
31808 (Binary::ResolveOperator): More null checking and miscellaneous coding
31811 2001-09-17 Ravi Pratap <ravi@ximian.com>
31813 * rootcontext.cs (IsNameSpace): Compare against null.
31815 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
31817 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
31818 and Unary::Operator.
31820 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
31823 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
31824 we have overloaded operators.
31825 (Binary::ResolveOperator): Implement the part which does the operator overload
31828 * class.cs (Operator::Emit): Implement.
31829 (TypeContainer::Emit): Emit the operators we have too.
31831 * expression.cs (Binary::Emit): Update to emit the appropriate code for
31832 the case when we have a user-defined operator.
31834 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31836 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
31838 2001-09-16 Ravi Pratap <ravi@ximian.com>
31840 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
31841 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
31842 (Constructor::Emit): Implement.
31843 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
31844 if we have no work to do.
31845 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
31848 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
31849 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
31851 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
31854 2001-09-15 Ravi Pratap <ravi@ximian.com>
31856 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
31858 (Tree::RecordNamespace): Method to do what the name says ;-)
31859 (Tree::Namespaces): Property to get at the namespaces hashtable.
31861 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
31864 * rootcontext.cs (IsNamespace): Fixed it :-)
31866 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31868 * class.cs (TypeContainer::FindMembers): Add support for
31870 (MethodCore): New class that encapsulates both the shared aspects
31871 of a Constructor and a Method.
31872 (Method, Constructor): Factored pieces into MethodCore.
31874 * driver.cs: Added --fatal which makes errors throw exceptions.
31875 Load System assembly as well as part of the standard library.
31877 * report.cs: Allow throwing exceptions on errors for debugging.
31879 * modifiers.cs: Do not use `parent', instead use the real type
31880 container to evaluate permission settings.
31882 * class.cs: Put Ravi's patch back in. He is right, and we will
31883 have to cope with the
31885 2001-09-14 Ravi Pratap <ravi@ximian.com>
31887 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
31888 FamORAssem, not FamANDAssem.
31890 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31892 * driver.cs: Added --parse option that only parses its input files
31895 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
31896 incorrect. IsTopLevel is not used to tell whether an object is
31897 root_types or not (that can be achieved by testing this ==
31898 root_types). But to see if this is a top-level *class* (not
31899 necessarly our "toplevel" container).
31901 2001-09-14 Ravi Pratap <ravi@ximian.com>
31903 * enum.cs (Enum::Define): Modify to call the Lookup method on the
31904 parent instead of a direct call to GetType.
31906 2001-09-14 Ravi Pratap <ravi@ximian.com>
31908 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
31909 Modifiers.TypeAttr. This should just be a call to that method.
31911 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
31912 object so that we can determine if we are top-level or not.
31914 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
31917 * enum.cs (Enum::Define): Ditto.
31919 * modifiers.cs (FieldAttr): Re-write.
31921 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
31922 (TypeContainer::HaveStaticConstructor): New property to provide access
31923 to precisely that info.
31925 * modifiers.cs (MethodAttr): Re-write.
31926 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
31928 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
31929 of top-level types as claimed.
31931 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31933 * expression.cs (MemberLookup): Fruitless attempt to lookup
31934 constructors. Maybe I need to emit default constructors? That
31935 might be it (currently .NET emits this for me automatically).
31936 (Invocation::OverloadResolve): Cope with Arguments == null.
31937 (Invocation::EmitArguments): new function, shared by the new
31938 constructor and us.
31939 (Invocation::Emit): Handle static and instance methods. Emit
31940 proper call instruction for virtual or non-virtual invocations.
31941 (New::Emit): Implement.
31942 (New::Resolve): Implement.
31943 (MemberAccess:Resolve): Implement.
31944 (MethodGroupExpr::InstanceExpression): used conforming to the spec
31945 to track instances.
31946 (FieldExpr::Resolve): Set type.
31948 * support.cs: Handle empty arguments.
31950 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
31951 SimpleLookup): Auxiliary routines to help parse a qualifier
31954 Update qualifier_identifier rule.
31956 * codegen.cs: Removed debugging messages.
31958 * class.cs: Make this a global thing, this acts just as a "key" to
31959 objects that we might have around.
31961 (Populate): Only initialize method_builders_to_methods once.
31963 * expression.cs (PropertyExpr): Initialize type from the
31966 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
31967 Resolve pattern. Attempt to implicitly convert value to boolean.
31970 * expression.cs: Set the type for the int32/int32 argument case.
31971 (Binary::ResolveOperator): Set the return type to boolean for
31972 comparission operators
31974 * typemanager.cs: Remove debugging print code.
31976 (Invocation::Resolve): resolve type.
31978 * class.cs: Allocate a MemberInfo of the correct size, as the code
31979 elsewhere depends on the test to reflect the correct contents.
31981 (Method::) Keep track of parameters, due to System.Reflection holes
31983 (TypeContainer::Populate): Keep track of MethodBuilders to Method
31986 (TypeContainer::FindMembers): Use ArrayList and then copy an array
31987 of the exact size and return that.
31989 (Class::LookupMethodByBuilder): New function that maps
31990 MethodBuilders to its methods. Required to locate the information
31991 on methods because System.Reflection bit us again.
31993 * support.cs: New file, contains an interface ParameterData and
31994 two implementations: ReflectionParameters and InternalParameters
31995 used to access Parameter information. We will need to grow this
31998 * expression.cs (Invocation::GetParameterData): implement a cache
31999 and a wrapper around the ParameterData creation for methods.
32000 (Invocation::OverloadResolve): Use new code.
32002 2001-09-13 Ravi Pratap <ravi@ximian.com>
32004 * class.cs (TypeContainer::EmitField): Remove and move into
32005 (Field::Define): here and modify accordingly.
32006 (Field.FieldBuilder): New member.
32007 (TypeContainer::Populate): Update accordingly.
32008 (TypeContainer::FindMembers): Implement.
32010 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32012 * statement.cs: (VariableInfo::VariableType): New field to be
32013 initialized with the full type once it is resolved.
32015 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32017 * parameter.cs (GetParameterInfo): Use a type cache to compute
32018 things only once, and to reuse this information
32020 * expression.cs (LocalVariableReference::Emit): Implement.
32021 (OpcodeCast::Emit): fix.
32023 (ParameterReference::Resolve): Implement.
32024 (ParameterReference::Emit): Implement.
32026 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32027 that are expressions need to stay as Expressions.
32029 * typemanager.cs (CSharpName): Returns the C# name of a type if
32032 * expression.cs (Expression::ConvertImplicit): New function that
32033 implements implicit type conversions.
32035 (Expression::ImplicitReferenceConversion): Implements implicit
32036 reference conversions.
32038 (EmptyCast): New type for transparent casts.
32040 (OpcodeCast): New type for casts of types that are performed with
32041 a sequence of bytecodes.
32043 (BoxedCast): New type used for casting value types into reference
32044 types. Emits a box opcode.
32046 (Binary::DoNumericPromotions): Implements numeric promotions of
32047 and computation of the Binary::Type.
32049 (Binary::EmitBranchable): Optimization.
32051 (Binary::Emit): Implement code emission for expressions.
32053 * typemanager.cs (TypeManager): Added two new core types: sbyte
32056 2001-09-12 Ravi Pratap <ravi@ximian.com>
32058 * class.cs (TypeContainer::FindMembers): Method which does exactly
32059 what Type.FindMembers does, only we don't have to use reflection. No
32060 implementation yet.
32062 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32063 typecontainer objects as we need to get at them.
32064 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32066 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32067 typecontainer object.
32069 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32070 of just a Report object.
32072 2001-09-11 Ravi Pratap <ravi@ximian.com>
32074 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32076 (TypeContainer::Populate): Now define the delegates of the type too.
32077 (TypeContainer.Delegates): Property to access the list of delegates defined
32080 * delegates.cs (Delegate::Define): Implement partially.
32082 * modifiers.cs (TypeAttr): Handle more flags.
32084 2001-09-11 Ravi Pratap <ravi@ximian.com>
32086 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32088 (Operator::Define): Re-write logic to get types by using the LookupType method
32089 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32090 (Indexer::Define): Ditto.
32091 (Event::Define): Ditto.
32092 (Property::Define): Ditto.
32094 2001-09-10 Ravi Pratap <ravi@ximian.com>
32096 * class.cs (TypeContainer::Populate): Now define operators too.
32097 (TypeContainer.Operators): New property to access the list of operators
32099 (Operator.OperatorMethodBuilder): New member to hold the method builder
32100 for the operator we are defining.
32101 (Operator::Define): Implement.
32103 2001-09-10 Ravi Pratap <ravi@ximian.com>
32105 * class.cs (Event::Define): Make the prefixes of the accessor methods
32106 addOn_ and removeOn_
32108 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32109 of the location being passed in too. Ideally, this should go later since all
32110 error reporting should be done through the Report object.
32112 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32113 (Populate): Iterate thru the indexers we have and define them too.
32114 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32115 for the get and set accessors.
32116 (Indexer::Define): Implement.
32118 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32120 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32121 my previous implementation, did not work.
32123 * typemanager.cs: Add a couple of missing types (the longs).
32125 * literal.cs: Use TypeManager.bool_type instead of getting it.
32127 * expression.cs (EventExpr): New kind of expressions.
32128 (Expressio::ExprClassFromMemberInfo): finish
32130 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32132 * assign.cs: Emit stores to static fields differently.
32134 2001-09-08 Ravi Pratap <ravi@ximian.com>
32136 * Merge in changes and adjust code to tackle conflicts. Backed out my
32137 code in Assign::Resolve ;-)
32139 2001-09-08 Ravi Pratap <ravi@ximian.com>
32141 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32142 instead Report.Error and also pass in the location.
32143 (CSharpParser::Lexer): New readonly property to return the reference
32144 to the Tokenizer object.
32145 (declare_local_variables): Use Report.Error with location instead of plain
32149 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32150 (Operator.CheckBinaryOperator): Ditto.
32152 * cs-parser.jay (operator_declarator): Update accordingly.
32154 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32155 (CheckBinaryOperator): Same here.
32157 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32158 on the name without any prefixes of namespace names etc. This is because we
32159 already might have something already fully qualified like
32160 'System.Console.WriteLine'
32162 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32164 2001-09-07 Ravi Pratap <ravi@ximian.com>
32166 * cs-tokenizer.cs (location): Return a string which also contains
32169 * expression.cs (ElementAccess): New class for expressions of the
32170 type 'element access.'
32171 (BaseAccess): New class for expressions of the type 'base access.'
32172 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32175 * cs-parser.jay (element_access): Implement action.
32176 (base_access): Implement actions.
32177 (checked_expression, unchecked_expression): Implement.
32179 * cs-parser.jay (local_variable_type): Correct and implement.
32180 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32182 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32184 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32185 name and the specifiers.
32187 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32189 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32190 making them all public ;-)
32192 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32195 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32197 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32199 (FieldExpr, PropertyExprs): New resolved expressions.
32200 (SimpleName::MemberStaticCheck): Perform static checks for access
32201 to non-static fields on static methods. Maybe this should be
32202 generalized for MemberAccesses.
32203 (SimpleName::ResolveSimpleName): More work on simple name
32206 * cs-parser.jay (primary_expression/qualified_identifier): track
32207 the parameter index.
32209 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32210 (EmitContext::EmitBoolExpression): Chain to expression generation
32211 instead of temporary hack.
32212 (::EmitStatementExpression): Put generic expression code generation.
32214 * assign.cs (Assign::Emit): Implement variable assignments to
32215 local variables, parameters and fields.
32217 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32219 * statement.cs (Block::GetVariableInfo): New method, returns the
32220 VariableInfo for a variable name in a block.
32221 (Block::GetVariableType): Implement in terms of GetVariableInfo
32223 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32224 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32226 2001-09-06 Ravi Pratap <ravi@ximian.com>
32228 * cs-parser.jay (operator_declaration): Continue on my quest : update
32229 to take attributes argument.
32230 (event_declaration): Ditto.
32231 (enum_declaration): Ditto.
32232 (indexer_declaration): Ditto.
32234 * class.cs (Operator::Operator): Update constructor accordingly.
32235 (Event::Event): Ditto.
32237 * delegate.cs (Delegate::Delegate): Same here.
32239 * enum.cs (Enum::Enum): Same here.
32241 2001-09-05 Ravi Pratap <ravi@ximian.com>
32243 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32245 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32247 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32248 being passed around as an arraylist.
32249 (Attributes::AddAttribute): Method to add attribute sections.
32251 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32252 (struct_declaration): Update accordingly.
32253 (constant_declaration): Update.
32254 (field_declaration): Update.
32255 (method_header): Update.
32256 (fixed_parameter): Update.
32257 (parameter_array): Ditto.
32258 (property_declaration): Ditto.
32259 (destructor_declaration): Ditto.
32261 * class.cs (Struct::Struct): Update constructors accordingly.
32262 (Class::Class): Ditto.
32263 (Field::Field): Ditto.
32264 (Method::Method): Ditto.
32265 (Property::Property): Ditto.
32266 (TypeContainer::OptAttribute): update property's return type.
32268 * interface.cs (Interface.opt_attributes): New member.
32269 (Interface::Interface): Update to take the extra Attributes argument.
32271 * parameter.cs (Parameter::Parameter): Ditto.
32273 * constant.cs (Constant::Constant): Ditto.
32275 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32276 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32277 the attributes as a parameter.
32278 (InterfaceProperty): Update constructor call.
32279 (InterfaceEvent): Ditto.
32280 (InterfaceMethod): Ditto.
32281 (InterfaceIndexer): Ditto.
32283 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32284 pass the attributes too.
32285 (interface_event_declaration): Ditto.
32286 (interface_property_declaration): Ditto.
32287 (interface_method_declaration): Ditto.
32288 (interface_declaration): Ditto.
32290 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32292 * class.cs (Method::Define): Track the "static Main" definition to
32293 create an entry point.
32295 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32296 EntryPoint if we find it.
32298 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32299 (EmitContext::ig): Make this variable public.
32301 * driver.cs: Make the default output file be the first file name
32302 with the .exe extension.
32304 Detect empty compilations
32306 Handle various kinds of output targets. Handle --target and
32307 rename -t to --dumper.
32309 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32310 methods inherited from Expression return now an Expression. This
32311 will is used during the tree rewriting as we resolve them during
32314 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32315 the spec. Missing entirely is the information about
32316 accessability of elements of it.
32318 (Expression::ExprClassFromMemberInfo): New constructor for
32319 Expressions that creates a fully initialized Expression based on
32320 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32323 (Invocation::Resolve): Begin implementing resolution of invocations.
32325 * literal.cs (StringLiteral): Implement Emit.
32327 2001-09-05 Ravi Pratap <ravi@ximian.com>
32329 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32332 2001-09-04 Ravi Pratap <ravi@ximian.com>
32334 * cs-parser.jay (attribute_arguments): Implement actions.
32335 (attribute): Fix bug in production. Implement action.
32336 (attribute_list): Implement.
32337 (attribute_target): Implement.
32338 (attribute_target_specifier, opt_target_specifier): Implement
32339 (CheckAttributeTarget): New method to check if the attribute target
32341 (attribute_section): Implement.
32342 (opt_attributes): Implement.
32344 * attribute.cs : New file to handle attributes.
32345 (Attribute): Class to hold attribute info.
32347 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32348 (attribute_section): Modify production to use 2 different rules to
32349 achieve the same thing. 1 s/r conflict down !
32350 Clean out commented, useless, non-reducing dimension_separator rules.
32352 * class.cs (TypeContainer.attributes): New member to hold list
32353 of attributes for a type.
32354 (Struct::Struct): Modify to take one more argument, the attribute list.
32355 (Class::Class): Ditto.
32356 (Field::Field): Ditto.
32357 (Method::Method): Ditto.
32358 (Property::Property): Ditto.
32360 * cs-parser.jay (struct_declaration): Update constructor call to
32361 pass in the attributes too.
32362 (class_declaration): Ditto.
32363 (constant_declaration): Ditto.
32364 (field_declaration): Ditto.
32365 (method_header): Ditto.
32366 (fixed_parameter): Ditto.
32367 (parameter_array): Ditto.
32368 (property_declaration): Ditto.
32370 * constant.cs (Constant::Constant): Update constructor similarly.
32371 Use System.Collections.
32373 * parameter.cs (Parameter::Parameter): Update as above.
32375 2001-09-02 Ravi Pratap <ravi@ximian.com>
32377 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32378 (TypeContainer.delegates): New member to hold list of delegates.
32380 * cs-parser.jay (delegate_declaration): Implement the action correctly
32381 this time as I seem to be on crack ;-)
32383 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32385 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32386 tell whether an identifier represents a namespace.
32388 * expression.cs (NamespaceExpr): A namespace expression, used only
32389 temporarly during expression resolution.
32390 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32391 utility functions to resolve names on expressions.
32393 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32395 * codegen.cs: Add hook for StatementExpressions.
32397 * class.cs: Fix inverted test for static flag in methods.
32399 2001-09-02 Ravi Pratap <ravi@ximian.com>
32401 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32402 to make it coincide with MS' number.
32403 (Operator::CheckBinaryOperator): Ditto.
32405 * ../errors/errors.txt : Remove error numbers added earlier.
32407 * ../errors/cs1019.cs : Test case for error # 1019
32409 * ../errros/cs1020.cs : Test case for error # 1020
32411 * cs-parser.jay : Clean out commented cruft.
32412 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32413 used anywhere - non-reducing rule.
32414 (namespace_declarations): Non-reducing rule - comment out.
32416 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32417 with TypeContainer::AddEnum.
32419 * delegate.cs : New file for delegate handling classes.
32420 (Delegate): Class for declaring delegates.
32422 * makefile : Update.
32424 * cs-parser.jay (delegate_declaration): Implement.
32426 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32428 * class.cs (Event::Define): Implement.
32429 (Event.EventBuilder): New member.
32431 * class.cs (TypeContainer::Populate): Update to define all enums and events
32433 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32434 readonly fields for all these cases ?
32436 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32438 * class.cs (Property): Revamp to use the convention of making fields readonly.
32439 Accordingly modify code elsewhere.
32441 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32442 the Define method of the Property class.
32444 * class.cs : Clean up applied patch and update references to variables etc. Fix
32446 (TypeContainer::Populate): Update to define all the properties we have. Also
32447 define all enumerations.
32449 * enum.cs (Define): Implement.
32451 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32453 * cs-parser.jay (overloadable_operator): The semantic value is an
32454 enum of the Operator class.
32455 (operator_declarator): Implement actions.
32456 (operator_declaration): Implement.
32458 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32459 validity of definitions.
32460 (Operator::CheckBinaryOperator): Static method to check for binary operators
32461 (TypeContainer::AddOperator): New method to add an operator to a type.
32463 * cs-parser.jay (indexer_declaration): Added line to actually call the
32464 AddIndexer method so it gets added ;-)
32466 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32467 already taken care of by the MS compiler ?
32469 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32471 * class.cs (Operator): New class for operator declarations.
32472 (Operator::OpType): Enum for the various operators.
32474 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32476 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32477 ostensibly handle this in semantic analysis.
32479 * cs-parser.jay (general_catch_clause): Comment out
32480 (specific_catch_clauses, specific_catch_clause): Ditto.
32481 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32482 (catch_args, opt_catch_args): New productions.
32483 (catch_clause): Rewrite to use the new productions above
32484 (catch_clauses): Modify accordingly.
32485 (opt_catch_clauses): New production to use in try_statement
32486 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32487 and re-write the code in the actions to extract the specific and
32488 general catch clauses by being a little smart ;-)
32490 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32491 Hooray, try and catch statements parse fine !
32493 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32495 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32496 string from the hashtable of variables.
32498 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32499 I end up making that mistake ;-)
32500 (catch_clauses): Fixed gross error which made Key and Value of the
32501 DictionaryEntry the same : $1 !!
32503 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32505 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32507 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32508 when the add and remove accessors are specified.
32510 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32512 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32513 information about indexer_declarator.
32514 (indexer_declarator): Implement actions.
32515 (parsing_indexer): New local boolean used to keep track of whether
32516 we are parsing indexers or properties. This is necessary because
32517 implicit_parameters come into picture even for the get accessor in the
32518 case of an indexer.
32519 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32521 * class.cs (Indexer): New class for indexer declarations.
32522 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32523 (TypeContainer::indexers): New member to hold list of indexers for the
32526 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32528 * cs-parser.jay (add_accessor_declaration): Implement action.
32529 (remove_accessor_declaration): Implement action.
32530 (event_accessors_declaration): Implement
32531 (variable_declarators): swap statements for first rule - trivial.
32533 * class.cs (Event): New class to hold information about event
32535 (TypeContainer::AddEvent): New method to add an event to a type
32536 (TypeContainer::events): New member to hold list of events.
32538 * cs-parser.jay (event_declaration): Implement actions.
32540 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32542 * cs-parser.jay (dim_separators): Implement. Make it a string
32543 concatenating all the commas together, just as they appear.
32544 (opt_dim_separators): Modify accordingly
32545 (rank_specifiers): Update accordingly. Basically do the same
32546 thing - instead, collect the brackets here.
32547 (opt_rank_sepcifiers): Modify accordingly.
32548 (array_type): Modify to actually return the complete type string
32549 instead of ignoring the rank_specifiers.
32550 (expression_list): Implement to collect the expressions
32551 (variable_initializer): Implement. We make it a list of expressions
32552 essentially so that we can handle the array_initializer case neatly too.
32553 (variable_initializer_list): Implement.
32554 (array_initializer): Make it a list of variable_initializers
32555 (opt_array_initializer): Modify accordingly.
32557 * expression.cs (New::NType): Add enumeration to help us
32558 keep track of whether we have an object/delegate creation
32559 or an array creation.
32560 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32561 members to hold data about array creation.
32562 (New:New): Modify to update NewType
32563 (New:New): New Overloaded contructor for the array creation
32566 * cs-parser.jay (array_creation_expression): Implement to call
32567 the overloaded New constructor.
32569 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32571 * class.cs (TypeContainer::Constructors): Return member
32572 constructors instead of returning null.
32574 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32576 * typemanager.cs (InitCoreTypes): Initialize the various core
32577 types after we have populated the type manager with the user
32578 defined types (this distinction will be important later while
32579 compiling corlib.dll)
32581 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32582 on Expression Classification. Now all expressions have a method
32583 `Resolve' and a method `Emit'.
32585 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32586 generation from working. Also add some temporary debugging
32589 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32591 * codegen.cs: Lots of code generation pieces. This is only the
32592 beginning, will continue tomorrow with more touches of polish. We
32593 handle the fundamentals of if, while, do, for, return. Others are
32594 trickier and I need to start working on invocations soon.
32596 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32599 * codegen.cs (EmitContext): New struct, used during code
32600 emission to keep a context. Most of the code generation will be
32603 * cs-parser.jay: Add embedded blocks to the list of statements of
32604 this block. So code generation proceeds in a top down fashion.
32606 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32608 * statement.cs: Add support for multiple child blocks.
32610 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32612 * codegen.cs (EmitCode): New function, will emit the code for a
32613 Block of code given a TypeContainer and its ILGenerator.
32615 * statement.cs (Block): Standard public readonly optimization.
32616 (Block::Block constructors): Link children.
32617 (Block::Child): Child Linker.
32618 (Block::EmitVariables): Emits IL variable declarations.
32620 * class.cs: Drop support for MethodGroups here, delay until
32622 (Method::): Applied the same simplification that I did before, and
32623 move from Properties to public readonly fields.
32624 (Method::ParameterTypes): Returns the parameter types for the
32625 function, and implements a cache that will be useful later when I
32626 do error checking and the semantic analysis on the methods is
32628 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32629 and made a method, optional argument tells whether this is a class
32630 or a structure to apply the `has-this' bit.
32631 (Method::GetCallingConvention): Implement, returns the calling
32633 (Method::Define): Defines the type, a second pass is performed
32634 later to populate the methods.
32636 (Constructor::ParameterTypes): implement a cache similar to the
32637 one on Method::ParameterTypes, useful later when we do semantic
32640 (TypeContainer::EmitMethod): New method. Emits methods.
32642 * expression.cs: Removed MethodGroup class from here.
32644 * parameter.cs (Parameters::GetCallingConvention): new method.
32646 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32648 * class.cs (TypeContainer::Populate): Drop RootContext from the
32651 (Constructor::CallingConvention): Returns the calling convention.
32652 (Constructor::ParameterTypes): Returns the constructor parameter
32655 (TypeContainer::AddConstructor): Keep track of default constructor
32656 and the default static constructor.
32658 (Constructor::) Another class that starts using `public readonly'
32659 instead of properties.
32661 (Constructor::IsDefault): Whether this is a default constructor.
32663 (Field::) use readonly public fields instead of properties also.
32665 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32666 track of static constructors; If none is used, turn on
32667 BeforeFieldInit in the TypeAttributes.
32669 * cs-parser.jay (opt_argument_list): now the return can be null
32670 for the cases where there are no arguments.
32672 (constructor_declarator): If there is no implicit `base' or
32673 `this', then invoke the default parent constructor.
32675 * modifiers.cs (MethodAttr): New static function maps a set of
32676 modifiers flags into a MethodAttributes enum
32677 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32678 MethodAttr, TypeAttr to represent the various mappings where the
32679 modifiers are used.
32680 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32682 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32684 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32687 * interface.cs (PopulateIndexer): Implemented the code generator
32688 for interface indexers.
32690 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32692 * interface.cs (InterfaceMemberBase): Now we track the new status
32695 (PopulateProperty): Implement property population. Woohoo! Got
32696 Methods and Properties going today.
32698 Removed all the properties for interfaces, and replaced them with
32699 `public readonly' fields.
32701 2001-08-16 Miguel de Icaza <miguel@ximian.com>
32703 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
32704 initialize their hashtables/arraylists only when they are needed
32705 instead of doing this always.
32707 * parameter.cs: Handle refs and out parameters.
32709 * cs-parser.jay: Use an ArrayList to construct the arguments
32710 instead of the ParameterCollection, and then cast that to a
32713 * parameter.cs: Drop the use of ParameterCollection and use
32714 instead arrays of Parameters.
32716 (GetParameterInfo): Use the Type, not the Name when resolving
32719 2001-08-13 Miguel de Icaza <miguel@ximian.com>
32721 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
32722 and instead use public readonly fields.
32724 * class.cs: Put back walking code for type containers.
32726 2001-08-11 Miguel de Icaza <miguel@ximian.com>
32728 * class.cs (MakeConstant): Code to define constants.
32730 * rootcontext.cs (LookupType): New function. Used to locate types
32733 2001-08-08 Miguel de Icaza <miguel@ximian.com>
32735 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
32736 this System.Reflection code is. Kudos to Microsoft
32738 * typemanager.cs: Implement a type cache and avoid loading all
32739 types at boot time. Wrap in LookupType the internals. This made
32740 the compiler so much faster. Wow. I rule!
32742 * driver.cs: Make sure we always load mscorlib first (for
32743 debugging purposes, nothing really important).
32745 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
32746 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
32748 * rootcontext.cs: Lookup types on their namespace; Lookup types
32749 on namespaces that have been imported using the `using' keyword.
32751 * class.cs (TypeContainer::TypeAttr): Virtualize.
32752 (Class::TypeAttr): Return attributes suitable for this bad boy.
32753 (Struct::TypeAttr): ditto.
32754 Handle nested classes.
32755 (TypeContainer::) Remove all the type visiting code, it is now
32756 replaced with the rootcontext.cs code
32758 * rootcontext.cs (GetClassBases): Added support for structs.
32760 2001-08-06 Miguel de Icaza <miguel@ximian.com>
32762 * interface.cs, statement.cs, class.cs, parameter.cs,
32763 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
32764 Drop use of TypeRefs, and use strings instead.
32766 2001-08-04 Miguel de Icaza <miguel@ximian.com>
32770 * class.cs (Struct::Struct): set the SEALED flags after
32771 checking the modifiers.
32772 (TypeContainer::TypeAttr): new property, returns the
32773 TypeAttributes for a class.
32775 * cs-parser.jay (type_list): Oops, list production was creating a
32776 new list of base types.
32778 * rootcontext.cs (StdLib): New property.
32779 (GetInterfaceTypeByName): returns an interface by type name, and
32780 encapsulates error handling here.
32781 (GetInterfaces): simplified.
32782 (ResolveTree): Encapsulated all the tree resolution here.
32783 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
32786 * driver.cs: Add support for --nostdlib, to avoid loading the
32787 default assemblies.
32788 (Main): Do not put tree resolution here.
32790 * rootcontext.cs: Beginning of the class resolution.
32792 2001-08-03 Miguel de Icaza <miguel@ximian.com>
32794 * rootcontext.cs: Provide better error reporting.
32796 * cs-parser.jay (interface_base): set our $$ to be interfaces.
32798 * rootcontext.cs (CreateInterface): Handle the case where there
32799 are no parent interfaces.
32801 (CloseTypes): Routine to flush types at the end.
32802 (CreateInterface): Track types.
32803 (GetInterfaces): Returns an array of Types from the list of
32804 defined interfaces.
32806 * typemanager.c (AddUserType): Mechanism to track user types (puts
32807 the type on the global type hash, and allows us to close it at the
32810 2001-08-02 Miguel de Icaza <miguel@ximian.com>
32812 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
32813 RecordInterface instead.
32815 * cs-parser.jay: Updated to reflect changes above.
32817 * decl.cs (Definition): Keep track of the TypeBuilder type that
32818 represents this type here. Not sure we will use it in the long
32819 run, but wont hurt for now.
32821 * driver.cs: Smaller changes to accomodate the new code.
32823 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
32826 * rootcontext.cs (CreateInterface): New method, used to create
32827 the System.TypeBuilder type for interfaces.
32828 (ResolveInterfaces): new entry point to resolve the interface
32830 (CodeGen): Property, used to keep track of the code generator.
32832 2001-07-26 Miguel de Icaza <miguel@ximian.com>
32834 * cs-parser.jay: Add a second production for delegate_declaration
32837 (enum_body): Put an opt_comma here instead of putting it on
32838 enum_body or enum_member_declarations so we can handle trailing
32839 commas on enumeration members. Gets rid of a shift/reduce.
32841 (type_list): Need a COMMA in the middle.
32843 (indexer_declaration): Tell tokenizer to recognize get/set
32845 * Remove old targets.
32847 * Re-add the parser target.
32849 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32851 * cs-parser.jay: Add precendence rules for a number of operators
32852 ot reduce the number of shift/reduce conflicts in the grammar.
32854 2001-07-17 Miguel de Icaza <miguel@ximian.com>
32856 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
32859 Get rid of old crufty code.
32861 * rootcontext.cs: Use this to keep track of the parsed
32862 representation and the defined types available to the program.
32864 * gen-treedump.cs: adjust for new convention.
32866 * type.cs: Split out the type manager, and the assembly builder
32869 * typemanager.cs: the type manager will live here now.
32871 * cil-codegen.cs: And the code generator here.
32873 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
32875 * makefile: Fixed up for easy making.
32877 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32879 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
32882 (unary_expression): Expand pre_increment_expression and
32883 post_decrement_expression to reduce a shift/reduce.
32885 2001-07-11 Simon Cozens
32887 * cs-tokenizer.cs: Hex numbers should begin with a 0.
32889 Improve allow_keyword_as_indent name.
32891 2001-06-19 Miguel de Icaza <miguel@ximian.com>
32893 * Adjustments for Beta2.
32895 2001-06-13 Miguel de Icaza <miguel@ximian.com>
32897 * decl.cs: Added `Define' abstract method.
32898 (InTransit): new property, used to catch recursive definitions.
32900 * interface.cs: Implement `Define'.
32902 * modifiers.cs: Map Modifiers.constants to
32903 System.Reflection.TypeAttribute flags.
32905 * class.cs: Keep track of types and user-defined types.
32906 (BuilderInit): New method for creating an assembly
32907 (ResolveType): New function to launch the resolution process, only
32908 used by interfaces for now.
32910 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
32911 that are inserted into the name space.
32913 2001-06-08 Miguel de Icaza <miguel@ximian.com>
32915 * ARGH. I have screwed up my tree so many times due to the use of
32916 rsync rather than using CVS. Going to fix this at once.
32918 * driver.cs: Objetify driver. Load assemblies, use assemblies to
32921 2001-06-07 Miguel de Icaza <miguel@ximian.com>
32923 * Experiment successful: Use System.Type rather that our own
32926 2001-05-25 Miguel de Icaza <miguel@ximian.com>
32928 * cs-parser.jay: Removed nsAliases from here.
32930 Use new namespaces, handle `using XXX;'
32932 * namespace.cs: Reimplemented namespace handling, use a recursive
32933 definition of the class. Now we can keep track of using clauses
32934 and catch invalid using clauses.
32936 2001-05-24 Miguel de Icaza <miguel@ximian.com>
32938 * gen-treedump.cs: Adapted for all the renaming.
32940 * expression.cs (Expression): this class now has a Type property
32941 which returns an expression Type.
32943 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
32944 `Type', as this has a different meaning now in the base
32946 2001-05-22 Miguel de Icaza <miguel@ximian.com>
32948 * interface.cs, class.cs: Removed from all the sources the
32949 references to signature computation, as we can not do method
32950 signature computation during the parsing time, as we are not
32951 trying to solve at that point distinguishing:
32955 void a (NS.Blah x) {}
32958 Which depending on the context might be valid or not, as we do not
32959 know if Blah is the same thing as NS.Blah at that point.
32961 * Redid everything so the code uses TypeRefs now instead of
32962 Types. TypeRefs are just temporary type placeholders, that need
32963 to be resolved. They initially have a pointer to a string and the
32964 current scope in which they are used. This is used later by the
32965 compiler to resolve the reference to an actual Type.
32967 * DeclSpace is no longer a CIR.Type, and neither are
32968 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
32969 are all DeclSpaces, but no Types.
32971 * type.cs (TypeRefManager): This implements the TypeRef manager,
32972 which keeps track of all the types that need to be resolved after
32973 the parsing has finished.
32975 2001-05-13 Miguel de Icaza <miguel@ximian.com>
32977 * ARGH. We are going to have to store `foreach' as a class rather
32978 than resolving it, as we need to verify error 1579 after name
32979 resolution. *OR* we could keep a flag that says `This request to
32980 IEnumerator comes from a foreach statement' which we can then use
32981 to generate the error.
32983 2001-05-10 Miguel de Icaza <miguel@ximian.com>
32985 * class.cs (TypeContainer.AddMethod): we now add methods to the
32986 MethodGroup instead of the method hashtable.
32988 * expression.cs: Add MethodGroup abstraction, which gets us one
32989 step closer to the specification in the way we handle method
32992 * cs-parser.jay (primary_expression): qualified_identifier now
32993 tried to match up an identifier to a local variable reference or
32994 to a parameter reference.
32996 current_local_parameters is now a parser global variable that
32997 points to the current parameters for the block, used during name
33000 (property_declaration): Now creates an implicit `value' argument to
33003 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33005 * parameter.cs: Do not use `param' arguments as part of the
33006 signature, per the spec.
33008 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33010 * decl.cs: Base class for classes, structs and interfaces. This
33011 is the "Declaration Space"
33013 * cs-parser.jay: Use CheckDef for checking declaration errors
33014 instead of having one on each function.
33016 * class.cs: Factor out some code for handling error handling in
33017 accordance to the "Declarations" section in the "Basic Concepts"
33018 chapter in the ECMA C# spec.
33020 * interface.cs: Make all interface member classes derive from
33021 InterfaceMemberBase.
33023 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33025 * Many things: all interfaces are parsed and generated in
33026 gen-treedump. Support for member variables, constructors,
33027 destructors, properties, constants is there.
33029 Beginning of the IL backend, but very little done, just there for
33032 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33034 * cs-parser.jay: Fix labeled statement.
33036 * cs-tokenizer.cs (escape): Escape " and ' always.
33037 ref_line, ref_name: keep track of the line/filename as instructed
33038 by #line by the compiler.
33041 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33043 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33044 to match the values in System.CodeDOM.
33046 Divid renamed to Divide.
33048 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33050 (Statements.set): remove.
33052 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33055 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33056 falseStatements always have valid values.
33058 * cs-parser.jay: Use System.CodeDOM now.