1 2010-06-03 Marek Safar <marek.safar@gmail.com>
4 * parameter.cs, property.cs, cs-parser.jay: Use independent implicit
5 parameters for explicit event accessors. Anonymous method capturing
6 won't otherwise work for event implicit parameter.
8 2010-06-02 Marek Safar <marek.safar@gmail.com>
11 * nullable.cs, expression.cs, statement.cs, method.cs, ecore.cs:
12 Ignore overrides for base overload resolution as for non-base
13 expressions and convert the best candidate to closest override
16 2010-06-01 Marek Safar <marek.safar@gmail.com>
19 * generic.cs, convert.cs: Recursively check effective base interface
21 2010-06-01 Marek Safar <marek.safar@gmail.com>
23 * statement.cs: Handle nullable types and type parameters in using
24 statement, avoid boxing value types. Also fixes #571010
26 2010-06-01 Marek Safar <marek.safar@gmail.com>
28 * convert.cs, expression.cs: Emit unbox for underlying nullable
31 2010-05-29 Marek Safar <marek.safar@gmail.com>
34 * expression.cs: Don't use branch optimization for types bigger than
37 2010-05-28 Marek Safar <marek.safar@gmail.com>
40 * import.cs: Check private modifier correctly.
42 2010-05-28 Marek Safar <marek.safar@gmail.com>
45 * ecore.cs: Don't ignore override methods when looking for base
48 2010-05-27 Marek Safar <marek.safar@gmail.com>
50 A fix for bugs #608007, #572540, #566130, #476358
52 * generic.cs, linq.cs, expression.cs, statement.cs, cs-parser.jay:
53 More tricky refactoring of implicit linq blocks.
55 2010-05-25 Marek Safar <marek.safar@gmail.com>
57 * linq.cs, cs-parser.jay: Keep location for all linq clauses.
59 2010-05-25 Marek Safar <marek.safar@gmail.com>
61 * context.cs, expression.cs, cs-parser.jay: Don't store current
62 block in This expression (it's too early for linq blocks).
64 2010-05-21 Marek Safar <marek.safar@gmail.com>
66 * expression.cs: Use constrained prefix more broadly to avoid boxing.
68 2010-05-20 Marek Safar <marek.safar@gmail.com>
71 * nullable.cs: Don't double wrap same expression.
73 2010-05-20 Marek Safar <marek.safar@gmail.com>
76 * anonymous.cs: Any issued error in probing mode means no match.
78 2010-05-20 Marek Safar <marek.safar@gmail.com>
80 * expression.cs: Search for base indexer using the closest match
83 2010-05-20 Marek Safar <marek.safar@gmail.com>
86 * method.cs: Set override constraints using unexpanded interface
89 2010-05-20 Marek Safar <marek.safar@gmail.com>
92 * ecore.cs: Include secondary extension method lookup in probing
95 2010-05-19 Marek Safar <marek.safar@gmail.com>
98 * typespec.cs (MayBecomeEqualGenericTypes): Recursively check
101 2010-05-19 Marek Safar <marek.safar@gmail.com>
103 A fix for bug #515801
104 * pending.cs: Advance counter correctly.
106 2010-05-19 Marek Safar <marek.safar@gmail.com>
108 A fix for bug #480139
109 * method.cs, pending.cs: Indexer override uses base name.
111 2010-05-19 Marek Safar <marek.safar@gmail.com>
113 A fix for bug #424064
114 * generic.cs: Replace original with inflated type parameter on
117 2010-05-19 Marek Safar <marek.safar@gmail.com>
119 A fix for bug #359733
120 * parameter.cs: Extension attribute can be defined in each assembly.
122 2010-05-18 Marek Safar <marek.safar@gmail.com>
124 A fix for bug #446507
125 * method.cs: Only one method can implement an interface.
127 2010-05-18 Marek Safar <marek.safar@gmail.com>
129 A fix for bug #594905
130 * convert.cs, constant.cs, expression.cs, literal.cs, ecore.cs:
131 Typed null can be used as a source for expression methods.
133 2010-05-18 Marek Safar <marek.safar@gmail.com>
135 A fix for bug #606551
136 * namespace.cs: Using directive imports only types and not nested
139 2010-05-17 Marek Safar <marek.safar@gmail.com>
141 * typespec.cs, expression.cs, statement.cs, ecore.cs, complete.cs,
142 delegate.cs: Member instance is resolved after member overload
143 definitely resolves static/instance property of member expression.
144 Fixes #545047, #358848, #456605, #460016, #603299
146 2010-05-12 Marek Safar <marek.safar@gmail.com>
148 A fix for bug #604981
149 * generic.cs, decl.cs, anonymous.cs: Reset more type arguments
150 details for nested anonymous methods stories.
152 2010-05-11 Marek Safar <marek.safar@gmail.com>
154 A fix for bug #604735
155 * namespace.cs: Don't report namespace collision.
157 2010-05-11 Marek Safar <marek.safar@gmail.com>
159 A fix for bug #604748
160 * class.cs, typespec.cs: Search full imported attribute hierarchy
163 2010-05-11 Marek Safar <marek.safar@gmail.com>
165 * namespace.cs: Ignore missing dependencies failure at
168 2010-05-11 Marek Safar <marek.safar@gmail.com>
170 A fix for bug #604640
171 * namespace.cs: Don't resolve using constraints too early.
173 2010-05-11 Marek Safar <marek.safar@gmail.com>
175 A fix for bug #604239
176 * generic.cs: Copy partial type constraints to partial container.
178 2010-05-10 Marek Safar <marek.safar@gmail.com>
180 A fix for bug #557210
181 * import.cs: Relax underlying enum field rules.
183 2010-05-10 Marek Safar <marek.safar@gmail.com>
185 A fix for bug #603476
186 * property.cs: Implement IParametersMember for indexer accessors.
188 2010-05-07 Marek Safar <marek.safar@gmail.com>
190 A fix for bug #601141
191 * class.cs: Update all partial modifiers.
193 2010-05-06 Marek Safar <marek.safar@gmail.com>
195 A fix for bug #601708
196 * method.cs, membercache.cs: Destructors cannot be hidden.
198 2010-05-06 Marek Safar <marek.safar@gmail.com>
200 A fix for bug #602551
201 * class.cs: Resursive reference of type definition is allowed.
203 2010-05-06 Marek Safar <marek.safar@gmail.com>
205 * anonymous.cs: Mutate cached storey instance types too.
207 2010-05-06 Marek Safar <marek.safar@gmail.com>
209 A fix for bug #602443
210 * convert.cs: Explicit enum conversion cannot involve user operators
212 2010-05-05 Miguel de Icaza <miguel@novell.com>
214 * class.cs (TypeContainer.DefineBaseTypes)
215 (TypeContainer.CheckRecursiveDefinition): check for the iface not
216 being null, as we could have failed resolution and crashed;
219 * cs-parser.jay: Productions to catch common mistakes when other
220 punctuation operators are used instead of comma. Fixes 571702
222 2010-05-05 Marek Safar <marek.safar@gmail.com>
224 * anonymous.cs: Mutate correct set of constraints.
226 2010-05-05 Marek Safar <marek.safar@gmail.com>
228 A fix for bug #602842
229 * expression.cs: Resolve all array bound arguments.
231 2010-05-05 Marek Safar <marek.safar@gmail.com>
233 * import.cs: Don't import private fields.
235 2010-04-30 Marek Safar <marek.safar@gmail.com>
237 Partially based on patch by <sami.lamti@gmail.com>
239 * eval.cs, ecore.cs: Fixed eval show methods.
241 2010-04-30 Marek Safar <marek.safar@gmail.com>
243 * generic.cs, delegate.cs: Implement output type inference of
244 methodgroup now when the specification was cleared at least little
247 2010-04-29 Marek Safar <marek.safar@gmail.com>
249 A fix for bug #575611
250 * class.cs: Fix recursive unmanaged recursice sruct check.
252 2010-04-29 Marek Safar <marek.safar@gmail.com>
254 A fix for bug #479776
255 * expression.cs: Implement typeof unbounded nested generic types.
257 2010-04-29 Marek Safar <marek.safar@gmail.com>
259 A fix for bug #474953
260 * class.cs: Fix valid recursive base type definition.
262 2010-04-29 Marek Safar <marek.safar@gmail.com>
264 A fix for bug #421737
265 * convert.cs, expression.cs: A boxing conversion exists from a
266 nullable-type to a reference type, if a boxing conversion exists
267 from the underlying non-nullable-value-type to the reference type.
269 2010-04-29 Marek Safar <marek.safar@gmail.com>
271 A fix for bug #376875
272 * import.cs: Import volatile modifier.
274 2010-04-29 Marek Safar <marek.safar@gmail.com>
276 A fix for bug #372412
277 * typespec.cs, expression.cs, codegen.cs: Emit readonly prefix for
280 2010-04-29 Marek Safar <marek.safar@gmail.com>
282 A fix for bug #568955
283 * statements.cs: Handle recursive scope initializers.
285 2010-04-28 Marek Safar <marek.safar@gmail.com>
287 A fix for bug #566511
288 * anonymous.cs: Always get inflated version of hoisted variable
289 on generic type definition.
291 2010-04-28 Marek Safar <marek.safar@gmail.com>
293 * import.cs, membercache.cs: Relax rules for valid properties.
295 2010-04-28 Marek Safar <marek.safar@gmail.com>
297 * import.cs: Intern arrays used in generic arguments.
299 2010-04-28 Marek Safar <marek.safar@gmail.com>
301 A fix for bug #600398
302 * convert.cs: Actually use effective base type for the comparison.
304 2010-04-28 Marek Safar <marek.safar@gmail.com>
306 A fix for bug #600326
307 * ecore.cs: Pass arity to base member lookup.
309 2010-04-28 Marek Safar <marek.safar@gmail.com>
311 A fix for bug #573385
312 * expression.cs: MemberAccess is of generic type based on right
315 2010-05-28 Marek Safar <marek.safar@gmail.com>
317 * cs-tokenizer.cs: Made tab size configurable.
319 2010-05-27 Marek Safar <marek.safar@gmail.com>
321 * attribute.cs: Ensure Obsolete members are defined before doing
324 2010-05-27 Marek Safar <marek.safar@gmail.com>
326 * visit.cs: Add DOM visitor skeleton.
330 2010-05-27 Marek Safar <marek.safar@gmail.com>
332 * attribute.cs, codegen.cs: Drop COMPILER_ACCESS hack.
334 2010-05-27 Marek Safar <marek.safar@gmail.com>
336 * *.cs: Major rewrite of compiler internals to better work with
337 unmodified System.Reflection.Emit. Some of the key changes are
338 - TypeSpec replaces reflection specific System.Type.
339 - All Type(TypeSpec) operations are now done in compiler therefore
340 no dependency on SRE to inflate generic members and types or to
341 query unclosed types.
342 - MemberCache is now the only and full hierarchical topology.
343 - Generic constraints are implemented properly.
344 - And as a bonus compilation is on average 30% faster.
346 2010-04-15 Jb Evain <jbevain@novell.com>
348 * dmcs.exe.config: update the runtime version to .net 4.0 RTM.
350 2010-04-12 Marek Safar <marek.safar@gmail.com>
352 * expression.cs, attribute.cs, parameter.cs: More attribute type
355 2010-04-12 Marek Safar <marek.safar@gmail.com>
357 A fix for bug #593342
359 * generic.cs, parameter.cs, argument.cs, field.cs, property.cs,
360 decl.cs, roottypes.cs, constant.cs, nullable.cs, expression.cs,
361 method.cs, ecore.cs, class.cs, delegate.cs, attribute.cs,
362 codegen.cs: Add custom attribute encoder to deal with unfinished
363 types and easier corlib bootstrap from its own types.
365 2010-03-26 Marek Safar <marek.safar@gmail.com>
367 * cs-parser.jay: Report invalid constraint types.
369 2010-03-16 Jb Evain <jbevain@novell.com>
371 * Makefile: rename the net_2_1 profile to moonlight.
373 2010-03-11 Marek Safar <marek.safar@gmail.com>
375 * statement.cs, cs-parser.jay: Use correct location for empty
378 2010-03-11 Marek Safar <marek.safar@gmail.com>
380 * cs-parser.jay: Disable Location from expression.
382 * generic.cs: Check constraints for overrides in the parser.
384 2010-03-09 Marek Safar <marek.safar@gmail.com>
386 * cs-parser.jay (GetLocation): Use an expression when available.
388 2010-03-04 Marek Safar <marek.safar@gmail.com>
390 A fix for bug #582579
391 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
393 2010-03-04 Marek Safar <marek.safar@gmail.com>
395 A patch by kornelpal@gmail.com
397 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
398 compiler generated classes sealed by default. Emit and close top
399 level compiler generated classes as well.
401 * support.cs: Use RuntimeHelpers.GetHashCode.
403 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
405 * Makefile: We need to use the internal bootstrapping gmcs for
406 net_2_1_bootstrap too now.
408 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
410 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
412 2010-03-02 Marek Safar <marek.safar@gmail.com>
414 * cs-tokenizer.cs: Missed few locations in previous fix.
416 2010-03-02 Marek Safar <marek.safar@gmail.com>
418 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
419 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
420 Report correct location for operator errors.
422 2010-03-02 Marek Safar <marek.safar@gmail.com>
424 * typemanager.cs (IsDynamicType): Don't check external types when
425 the attribute is not external.
427 2010-02-24 Marek Safar <marek.safar@gmail.com>
429 A fix for bug #582579
430 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
433 2010-02-24 Marek Safar <marek.safar@gmail.com>
435 A fix for bug #581804
436 * ecore.cs: Fixed type comparison.
438 2010-02-08 Miguel de Icaza <miguel@novell.com>
440 * namespace.cs (CompletionGetTypesStartingWith): Do not include
441 private types in the completion results.
443 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
446 2010-02-17 Marek Safar <marek.safar@gmail.com>
448 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
451 2010-02-14 Miguel de Icaza <miguel@novell.com>
453 * eval.cs: Do not do the report printer dance unless the user has
454 set the DescribeTypes feature.
456 2010-02-10 Marek Safar <marek.safar@gmail.com>
458 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
460 2010-02-08 Marek Safar <marek.safar@gmail.com>
462 A fix for bug #577029
463 * anonymous.cs: Fixed TypeBuilder* check.
465 2010-02-06 Miguel de Icaza <miguel@novell.com>
467 * eval.cs (CompileBlock): Also undo if there are problems during
468 semantic analysis, fixes various cases where invalid C# code would
469 be reported, but the internal changes would not be undone.
471 2010-02-03 Miguel de Icaza <miguel@novell.com>
473 * driver.cs: Change the --fatal flag to allow a number to be
474 passed, this ignores the first N fatal errors. Useful to debug
475 errors that do not happen on the first hit.
477 * cs-parser.jay (invocation_expression): accept both the
478 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
479 inside an invocation.
481 * driver.cs: Expose FatalErrors.
483 * eval.cs: Initialize the printer's Fatal property from the
484 Driver's FatalError flag, this allows csharp --fatal to work
487 Add support for calling Describe (typeof (TYPE)) if the expression
490 2010-02-02 Marek Safar <marek.safar@gmail.com>
492 A fix for bug #574991
493 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
496 2010-02-02 Marek Safar <marek.safar@gmail.com>
498 A fix for bug #575986
499 * expression.cs: Don't mutate typeof type definitions.
501 2010-01-28 Marek Safar <marek.safar@gmail.com>
503 * decl.cs: Use only one set of modifiers.
505 2010-01-26 Marek Safar <marek.safar@gmail.com>
507 A fix for bug #573329
508 * eval.cs: Don't disable error reporting completely on silent mode.
510 2010-01-25 Marek Safar <marek.safar@gmail.com>
512 A fix for bug #573312
513 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
514 pointer index of unknown size types greater than 2.
516 2010-01-15 Marek Safar <marek.safar@gmail.com>
518 * *.cs: Use only 1 member kind enum.
520 2010-01-15 Marek Safar <marek.safar@gmail.com>
522 * *.cs: Add event specification.
524 2010-01-14 Marek Safar <marek.safar@gmail.com>
526 * membercache.cs: Extracted from decl.cs.
528 * *.cs: Put more infrastructure in place.
530 2010-01-13 Marek Safar <marek.safar@gmail.com>
532 * *.cs: Add property specification, unused yet.
534 2010-01-13 Marek Safar <marek.safar@gmail.com>
536 * property.cs: Move all property based declarations into a new file.
538 2010-01-13 Marek Safar <marek.safar at gmail.com>
540 * expression.cs (Conditional): Resolve reduced expression.
542 2010-01-13 Marek Safar <marek.safar at gmail.com>
544 * *.cs: Introduced non-generic method specification.
546 2010-01-07 Marek Safar <marek.safar@gmail.com>
548 * method.cs: Move all method based declarations into a new file.
550 2010-01-07 Marek Safar <marek.safar@gmail.com>
552 * *.cs: Extract field specification.
554 2009-12-17 Marek Safar <marek.safar@gmail.com>
556 * field.cs: Extracted from class.cs
558 2009-12-15 Marek Safar <marek.safar@gmail.com>
560 * attribute.cs (GetFixedBuffer): Work on field definition only.
562 2009-12-15 Marek Safar <marek.safar@gmail.com>
564 * *.cs: Clean up NET_4_0 conditional where possible.
566 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
568 support.cs (DynamicType): Assembly property returns the assembly builder.
569 This is required due to how compiler context works in corlib.
571 2009-12-14 Marek Safar <marek.safar@gmail.com>
573 A fix for bug #564376
574 * assign.cs (LocalTemporary): Removed no longer needed special
577 2009-12-11 Marek Safar <marek.safar@gmail.com>
579 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
580 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
581 enum for easier debugging.
583 2009-12-10 Marek Safar <marek.safar@gmail.com>
585 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
588 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
591 2009-12-10 Marek Safar <marek.safar@gmail.com>
593 * cs-parser.jay, statement.cs: Handle parser error in code
596 2009-12-10 Marek Safar <marek.safar@gmail.com>
598 * ecore.cs: Ignore base imported methods when they are already
601 * eval.cs: Handle non-existent keys.
603 * report.cs, driver.cs: Make fatal work with console printer only.
605 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
607 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
609 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
611 * typemanager.cs: Add MakeGenericMethod that checks if the method
612 is really the generic method definition.
614 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
615 to inflate generic methods.
617 2009-12-08 Marek Safar <marek.safar@gmail.com>
619 A fix for bug #561149
620 * anonymous.cs: Use actual type parameters when checking for generic
623 2009-12-08 Marek Safar <marek.safar@gmail.com>
625 A fix for bug #561369
626 * expression.cs (DoNumericPromotion): Fixed typo.
628 2009-12-08 Marek Safar <marek.safar@gmail.com>
630 *.cs: Moving to generics world.
632 cs-parser.jay: Removed current_array_type.
634 2009-12-07 Marek Safar <marek.safar@gmail.com>
636 *.cs: Moving to generics world.
638 2009-12-04 Marek Safar <marek.safar@gmail.com>
640 *.cs: Moving to generics world (day 2).
642 2009-12-03 Marek Safar <marek.safar@gmail.com>
644 *.cs: Moving to generics world.
646 2009-12-02 Marek Safar <marek.safar@gmail.com>
648 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
649 Encode dynamic type attribute for elements where attributes cannot
652 2009-12-01 Marek Safar <marek.safar@gmail.com>
654 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
657 2009-12-01 Marek Safar <marek.safar@gmail.com>
659 A fix for bug #360455
660 * class.cs: Never report a unused warning for generic events to
661 workaround wrong expression type.
663 2009-11-30 Marek Safar <marek.safar@gmail.com>
665 A fix for bug #558305
666 * decl.cs, class.cs: Check partial method definitions using correct
669 2009-11-30 Marek Safar <marek.safar@gmail.com>
671 * argument.cs: Don't cache rarely used dynamic flag.
673 2009-11-27 Marek Safar <marek.safar@gmail.com>
675 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
677 2009-11-27 Marek Safar <marek.safar@gmail.com>
679 * ecore.cs (SimpleName): Removed no longer needed in_transit as
680 Resolve is now non-reentrant (saves ~0.6MB for corlib).
682 2009-11-26 Marek Safar <marek.safar@gmail.com>
684 A fix for bug #545081
685 * decl.cs: Check private nested types of nested types recursively.
687 2009-11-26 Marek Safar <marek.safar@gmail.com>
689 A fix for bug #558305
690 * location.cs: Ignore self referencing #line directive
692 2009-11-26 Marek Safar <marek.safar@gmail.com>
694 A fix for bug #558292
695 * class.cs: Allow single unsafe fixed buffer fields.
697 2009-11-26 Marek Safar <marek.safar@gmail.com>
699 * expression: Optimize few more zero-based operations.
701 2009-11-26 Marek Safar <marek.safar@gmail.com>
703 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
704 avoids boxing of literal values.
706 2009-11-26 Marek Safar <marek.safar@gmail.com>
708 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
709 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
710 codegen.cs: LocatedToken redesing to avoid excessive allocation and
711 boxing (saves ~7MB for corlib). Also fixes presise token location.
713 2009-11-25 Marek Safar <marek.safar@gmail.com>
715 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
718 2009-11-24 Marek Safar <marek.safar@gmail.com>
720 * expression.cs: Lower static array initializer barrier.
722 * support.cs, driver.cs: Share reader buffer.
724 2009-11-23 Marek Safar <marek.safar@gmail.com>
726 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
728 2009-11-23 Marek Safar <marek.safar@gmail.com>
730 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
731 cleanup some obsolete code.
733 2009-11-20 Marek Safar <marek.safar@gmail.com>
735 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
738 2009-11-20 Marek Safar <marek.safar@gmail.com>
740 * *.cs: Resolved expressions are never resolved again, this helps to
741 uncover some not easy to find bugs and improve the performance.
743 2009-11-19 Marek Safar <marek.safar@gmail.com>
745 * *.cs: Made constant expressions fully compatible with any other
748 2009-11-19 Marek Safar <marek.safar@gmail.com>
750 * *.cs: DoResolve is a worker method and has to be protected.
752 2009-11-18 Marek Safar <marek.safar@gmail.com>
754 * *.cs: More context specific handling.
756 2009-11-17 Marek Safar <marek.safar@gmail.com>
758 * *.cs: More context specific handling.
760 2009-11-16 Marek Safar <marek.safar@gmail.com>
762 * dynamic.cs, class.cs: Removed few fixed user types conversions.
764 * symbolwriter.cs: Uses public ILOffset.
766 2009-11-13 Marek Safar <marek.safar@gmail.com>
768 A fix for bug #553650
769 * generic.cs: Another missing TypeToCoreType, still too many to fix.
771 2009-11-13 Marek Safar <marek.safar@gmail.com>
773 A fix for bug #555170
775 * class.cs, delegate.cs, enum.cs: Constants have to be available
776 for parameters resolve.
778 2009-11-12 Marek Safar <marek.safar@gmail.com>
780 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
783 2009-11-12 Marek Safar <marek.safar@gmail.com>
785 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
786 with a statically known candidate set.
788 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
790 * generic.cs: Made type inflation for generic constraint checks
791 recursive. This fixes BGO #553655.
793 2009-11-11 Marek Safar <marek.safar@gmail.com>
795 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
798 2009-11-10 Marek Safar <marek.safar@gmail.com>
800 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
801 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
802 attribute.cs: Add some dynamic error checking.
804 2009-11-07 Marek Safar <marek.safar@gmail.com>
806 A fix for bug #553465
808 * expression.cs: Fixed mixed version of expression tree anonymous
811 2009-11-06 Marek Safar <marek.safar@gmail.com>
813 A fix for bug #553031
815 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
816 expression tree version of anonymous type with members declaration.
818 2009-11-05 Marek Safar <marek.safar@gmail.com>
820 * parameter.cs: Handle nullable parameter default expression.
822 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
823 class.cs, attribute.cs: Check for wrong dynamic arguments.
825 2009-11-05 Marek Safar <marek.safar@gmail.com>
827 * statement.cs: Dynamic statements.
829 2009-11-04 Marek Safar <marek.safar@gmail.com>
831 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
832 Compound assignments over dynamic type.
834 2009-11-03 Marek Safar <marek.safar@gmail.com>
836 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
837 constructor arguments.
839 2009-10-30 Marek Safar <marek.safar@gmail.com>
841 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
842 codegen.cs: Unary mutator on dynamic member access expression.
844 2009-10-29 Marek Safar <marek.safar@gmail.com>
846 A fix for bug #550580
847 * convert.cs: Don't eliminate explicit precission casts.
849 2009-10-28 Marek Safar <marek.safar@gmail.com>
851 A fix for bug #550404
853 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
854 expression.cs, statement.cs, ecore.cs: Quote any nested expression
857 2009-10-27 Marek Safar <marek.safar@gmail.com>
859 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
862 * class.cs: Allow nullable binary user operators.
864 2009-10-26 Marek Safar <marek.safar@gmail.com>
866 * expression.cs: Move binary expression optimization at the end of
869 2009-10-23 Marek Safar <marek.safar@gmail.com>
871 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
872 Separate NullConstant from NullLiteral.
874 2009-10-23 Marek Safar <marek.safar@gmail.com>
876 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
877 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
878 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
879 ModuleContainer. Add common unclosed member check routine.
881 2009-10-22 Marek Safar <marek.safar@gmail.com>
883 * argument.cs: Use literal flag for real literals only.
885 * dynamic.cs: Use correct return type for custom delegates.
887 2009-10-22 Marek Safar <marek.safar@gmail.com>
889 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
892 2009-10-22 Marek Safar <marek.safar@gmail.com>
894 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
896 2009-10-21 Marek Safar <marek.safar@gmail.com>
898 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
901 2009-10-21 Marek Safar <marek.safar@gmail.com>
903 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
906 2009-10-20 Marek Safar <marek.safar@gmail.com>
908 * argument.cs, dynamic.cs, expression.cs: Latest API update.
910 2009-10-19 Marek Safar <marek.safar@gmail.com>
912 * typemanager.cs, expression.cs: Dynamic array initializer.
914 2009-10-16 Marek Safar <marek.safar@gmail.com>
916 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
919 2009-10-16 Marek Safar <marek.safar@gmail.com>
921 A fix for bug #493523, #507067
922 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
923 standard nullable conversion using underlying standard conversion
924 and not full conversion.
926 2009-10-15 Marek Safar <marek.safar@gmail.com>
928 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
929 type in VerifyArgumentsCompat.
931 2009-10-15 Marek Safar <marek.safar@gmail.com>
933 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
934 Reject variable used with type arguments.
936 2009-10-14 Marek Safar <marek.safar@gmail.com>
938 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
939 Implement dynamic expressions assignment.
941 2009-10-14 Marek Safar <marek.safar@gmail.com>
943 * expression.cs: Build underlying expression when resolving unary
946 2009-10-14 Marek Safar <marek.safar@gmail.com>
948 * expression.cs: Emit enum array initializer using binary blob.
950 2009-10-08 Marek Safar <marek.safar@gmail.com>
952 * typemanager.cs, constant.cs: Optimize decimal constants which fit
955 2009-10-07 Marek Safar <marek.safar@gmail.com>
957 * typemanager.cs: Reset object_type.
959 * assign: Made SimpleAssign public.
961 2009-10-06 Marek Safar <marek.safar@gmail.com>
963 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
964 invocation assembly to IsThisOrFriendAssembly.
966 2009-10-05 Marek Safar <marek.safar@gmail.com>
968 * expression.cs: Equality comparison of generic parameter with
971 2009-10-05 Marek Safar <marek.safar@gmail.com>
973 A fix for bug #543570
974 * generic.cs: Import predefined constraints correctly.
976 2009-10-02 Marek Safar <marek.safar@gmail.com>
978 * ecore.cs: Don't crash on overloads with optional paremeters where
979 arguments count overflows.
981 * parameter.cs: Import optional parameter constants using optional
984 2009-10-01 Marek Safar <marek.safar@gmail.com>
986 * Makefile: Default is gmcs compiler.
988 2009-10-01 Marek Safar <marek.safar@gmail.com>
990 * cs-parser.jay: Fixed few NRE.
992 2009-10-01 Marek Safar <marek.safar@gmail.com>
994 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
996 2009-09-30 Marek Safar <marek.safar@gmail.com>
998 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
999 ShimExpression, ImplicitCast.
1001 2009-09-30 Marek Safar <marek.safar@gmail.com>
1003 A fix for bug #542959
1004 * delegate.cs: Emit correct delegate instance variable when there
1005 are static and non-static overloads.
1007 2009-09-29 Marek Safar <marek.safar@gmail.com>
1009 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
1010 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
1012 2009-09-28 Marek Safar <marek.safar@gmail.com>
1014 A fix for bug #542487
1015 * ecore.cs: Resolve extension methods hidden by properties.
1017 2009-09-25 Marek Safar <marek.safar@gmail.com>
1019 * expression.cs, ecore.cs: More dynamic binary expressions.
1021 2009-09-22 Marek Safar <marek.safar@gmail.com>
1023 * nullable.cs, expression.cs: Fixed null lifted conversion for
1024 bitwise enum operations.
1026 2009-09-22 Marek Safar <marek.safar@gmail.com>
1028 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
1029 values in checked context.
1031 2009-09-22 Marek Safar <marek.safar@gmail.com>
1033 * expression.cs, ecore.cs: Fixed array index constant conversion.
1035 2009-09-20 Miguel de Icaza <miguel@novell.com>
1037 * expression.cs: Do not crash when MemberLookup returns something
1038 that is not a MemberExpr here. Report error 582 instead.
1042 2009-09-18 Marek Safar <marek.safar@gmail.com>
1044 * decl.cs, class.cs: Check protected property accessors.
1046 2009-09-18 Marek Safar <marek.safar@gmail.com>
1048 * dynamic.cs, assign.cs: Dynamic compound assignment.
1050 2009-09-17 Marek Safar <marek.safar@gmail.com>
1052 * expression.cs: Fixed compound assignment explicit conversion.
1054 2009-09-17 Marek Safar <marek.safar@gmail.com>
1056 * expression.cs, ecore.cs: Cannot infer variables from method group.
1058 2009-09-16 Marek Safar <marek.safar@gmail.com>
1060 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
1061 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
1062 codegen.cs: Dynamic binary operations scaffolding.
1064 2009-09-15 Marek Safar <marek.safar@gmail.com>
1066 * expression.cs: Fixes nullable promotion for enum type variables.
1068 2009-09-11 Marek Safar <marek.safar@gmail.com>
1070 * driver.cs, dynamic.cs: Reset more static variables.
1072 2009-09-11 Marek Safar <marek.safar@gmail.com>
1074 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
1075 driver.cs: Introduced Expression::MakeExpression.
1077 2009-09-11 Marek Safar <marek.safar@gmail.com>
1079 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
1081 2009-09-09 Marek Safar <marek.safar@gmail.com>
1083 * eval.cs, report.cs: Use Console.Out for all eval error or warning
1086 2009-09-09 Marek Safar <marek.safar@gmail.com>
1088 A fix for bug #518707
1089 * expression.cs (Is): Optimize only generic parameter type
1090 expression probing value type generic parameter.
1092 2009-09-09 Marek Safar <marek.safar@gmail.com>
1094 A fix for bug #532571
1095 * ecore.cs: Check for simple name type arguments used with
1098 2009-09-08 Marek Safar <marek.safar@gmail.com>
1100 A fix for bug #497421
1101 * generic.cs (CheckConstraint): Don't use buildin types to check for
1102 parameterless constructor.
1104 2009-09-08 Marek Safar <marek.safar@gmail.com>
1106 A fix for bug #537402
1107 * generic.cs (CheckConstraint): Correctly inflate generic type
1108 arguments when checking generic method.
1110 2009-09-08 Marek Safar <marek.safar@gmail.com>
1112 A fix for bug #536463
1113 * decl.cs (AddToContainer): Don't report collision between explicit
1114 and parameterless non-explicit members.
1116 2009-09-08 Marek Safar <marek.safar@gmail.com>
1118 * eval.cs: Reset more static stuff.
1120 2009-09-07 Marek Safar <marek.safar@gmail.com>
1122 A fix for bug #324625
1123 * expression.cs, ecore.cs: Create nested generic type expression
1124 using declaring and not current type.
1126 2009-09-07 Marek Safar <marek.safar@gmail.com>
1128 * *.cs: Changed Report class to accept various output printers and
1129 be an instance class. An expression resolver can now use different
1130 message reporter for each call and Report.Error can safely throw
1131 an exception. Part of ongoing work to turn mcs into proper library.
1133 2009-09-04 Marek Safar <marek.safar@gmail.com>
1135 * statement.cs, ecore.cs: Removed error reporting from emit code.
1137 2009-09-04 Marek Safar <marek.safar@gmail.com>
1139 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
1141 2009-09-03 Marek Safar <marek.safar@gmail.com>
1143 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
1144 parser checks out of constructors.
1146 2009-09-02 Marek Safar <marek.safar@gmail.com>
1148 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
1150 2009-09-02 Marek Safar <marek.safar@gmail.com>
1152 A fix for bug #535448
1153 * anonymous.cs, class.cs: Copy return label between all contexts.
1155 2009-09-02 Marek Safar <marek.safar@gmail.com>
1157 A fix for bug #535395
1158 * namespace.cs: Resolve context can be null.
1160 2009-08-25 Marek Safar <marek.safar@gmail.com>
1162 A fix for bug #533912
1163 * generic.cs: Use correct context for constraints resolving.
1165 2009-08-25 Marek Safar <marek.safar@gmail.com>
1167 A fix for bug #532630
1168 * driver.cs: Trim conditional symbols.
1170 2009-08-25 Marek Safar <marek.safar@gmail.com>
1172 * context.cs: New file.
1174 * *.exe.sources, *.csproj: Updated.
1176 2009-08-25 Marek Safar <marek.safar@gmail.com>
1178 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
1179 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
1180 IMembercontext, some small cleanups.
1182 2009-08-24 Marek Safar <marek.safar@gmail.com>
1184 * *.cs: Split ResolveContext and EmitContext.
1186 2009-08-24 Marek Safar <marek.safar@gmail.com>
1188 * *.cs: Only ResolveContext implements IMemberContext.
1190 2009-08-21 Marek Safar <marek.safar@gmail.com>
1192 * *.cs: Renamed IResolveContext to IMemberContext.
1194 2009-08-21 Marek Safar <marek.safar@gmail.com>
1196 * *.cs: Detached ResolveContext from EmitContext.
1198 2009-08-21 Marek Safar <marek.safar@gmail.com>
1200 * codegen.cs: Moved flow-analysis to BlockContext.
1202 2009-08-21 Marek Safar <marek.safar@gmail.com>
1204 * *.cs: Detached BlockContext from EmitContext.
1206 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
1208 * statement.cs: avoid nullref when the return value of GetEnumerator()
1209 does not contain any MoveNext() method.
1211 2009-08-19 Marek Safar <marek.safar@gmail.com>
1213 * *.cs: Removed IResolveContext::GenericDeclContainer.
1215 2009-08-19 Marek Safar <marek.safar@gmail.com>
1217 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
1219 2009-08-19 Marek Safar <marek.safar@gmail.com>
1221 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
1222 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
1224 2009-08-18 Marek Safar <marek.safar@gmail.com>
1226 * *.cs: Removed boolean fields from EmitContext.
1228 2009-08-18 Marek Safar <marek.safar@gmail.com>
1230 * *.cs: Add IResolveContext::IsStatic.
1232 2009-08-18 Marek Safar <marek.safar@gmail.com>
1234 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
1236 2009-08-17 Marek Safar <marek.safar@gmail.com>
1238 * *.cs: Removed DeclContainer from EmitContext.
1240 2009-08-17 Marek Safar <marek.safar@gmail.com>
1242 * *.cs: Add IResolveContext::CurrentTypeParameters.
1244 2009-08-14 Marek Safar <marek.safar@gmail.com>
1246 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
1248 2009-08-14 Marek Safar <marek.safar@gmail.com>
1250 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
1251 codegen.cs: Add IResolveContext::LookupExtensionMethod.
1253 2009-08-13 Marek Safar <marek.safar@gmail.com>
1255 * decl.cs: Look in PartialContainer for parent type parameters.
1257 2009-08-13 Marek Safar <marek.safar@gmail.com>
1259 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
1260 codegen.cs: Add IResolveContext::LookupTypeParameter.
1262 2009-08-13 Marek Safar <marek.safar@gmail.com>
1264 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
1265 Moved resolved logic from Emit to Resolve.
1267 2009-08-13 Marek Safar <marek.safar@gmail.com>
1269 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
1270 codegen.cs: Reworked atttributes handling of ResolveContext.
1272 2009-08-12 Marek Safar <marek.safar@gmail.com>
1274 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
1275 LookupNamespaceOrType to ResolveContext.
1277 2009-08-12 Marek Safar <marek.safar@gmail.com>
1279 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
1280 class.cs: Removed unused parameters and methods.
1282 2009-08-11 Marek Safar <marek.safar@gmail.com>
1284 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
1285 codegen.cs: Finding the best common type of a set of expressions for
1288 2009-08-07 Marek Safar <marek.safar@gmail.com>
1290 * dynamic.cs, expression.cs: More dynamic conversions.
1292 2009-08-06 Miguel de Icaza <miguel@novell.com>
1294 * generic.cs: This loop was incorrect, it was increment ii, but
1295 checking for `i'. This was a change introduced to fix #327497,
1298 * class.cs: Catch another case for cs0533 error, fixes #324782.
1300 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
1302 * typemanager.cs (GetGenericArguments): SRE returns null for
1303 generic methods on type builder instances if they are not generic
1304 themselves. For example, for Foo<int>::Bar() it returns null, but
1305 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
1307 2009-08-05 Marek Safar <marek.safar@gmail.com>
1309 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
1310 delegate.cs: Work on dynamic binding.
1312 2009-08-04 Marek Safar <marek.safar@gmail.com>
1314 A second fix for bug #525342
1315 * class.cs: Attach partial method attributes to method
1318 2009-08-03 Marek Safar <marek.safar@gmail.com>
1320 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
1323 * rootcontext.cs: Default to langversion v4.
1325 2009-08-03 Marek Safar <marek.safar@gmail.com>
1327 * pending.cs: Check return type before member info is set.
1329 2009-08-03 Marek Safar <marek.safar@gmail.com>
1331 * anonymous.cs: Fully initialize generic hoisted field expression.
1333 2009-08-02 Miguel de Icaza <miguel@novell.com>
1335 * cs-parser.jay: Flag variables declared on the interactive shell
1336 as used to prevent the 168 warning about local variable not being
1339 2009-07-31 Marek Safar <marek.safar@gmail.com>
1341 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
1342 attribute.cs: Emit dynamic export attribute.
1344 2009-07-30 Marek Safar <marek.safar@gmail.com>
1346 * expression.cs: More verifier work.
1348 2009-07-29 Marek Safar <marek.safar@gmail.com>
1350 * nullable.cs: Fixed SRE crash during corlib compilation.
1352 2009-07-29 Marek Safar <marek.safar@gmail.com>
1354 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
1355 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
1356 More TypeManager.TypeToCoreType needed.
1358 2009-07-29 Marek Safar <marek.safar@gmail.com>
1360 * anonymous.cs: Update after recent SRE fixes.
1362 2009-07-28 Marek Safar <marek.safar@gmail.com>
1364 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1365 version of GetFieldHandle for fields of generic types.
1367 2009-07-27 Marek Safar <marek.safar@gmail.com>
1369 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1370 ecore.cs: Add TypeManager.IsDynamicType,
1371 PredefinedAttributes.Dynamic.
1373 2009-07-27 Marek Safar <marek.safar@gmail.com>
1375 A fix for bug #415375
1376 * expression.cs: Fixed object and reference type parameter
1379 2009-07-27 Marek Safar <marek.safar@gmail.com>
1381 A fix for bug #525342
1382 * class.cs: Attach partial method attributes to method
1385 2009-07-24 Marek Safar <marek.safar@gmail.com>
1387 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1390 2009-07-24 Marek Safar <marek.safar@gmail.com>
1392 * anonymous.cs (MutateField): Add imported types handling.
1394 2009-07-23 Marek Safar <marek.safar@gmail.com>
1396 * expression.cs, delegate.cs: Moved arguments resolve into their
1397 counterparts expressions. Removed argument resolve from
1398 CollectionElementInitializer.
1400 2009-07-23 Marek Safar <marek.safar@gmail.com>
1402 A fix for bug #523683
1403 * convert.cs, delegate.cs: Use common overload mechanism for method
1404 group conversion check.
1406 2009-07-22 Marek Safar <marek.safar@gmail.com>
1408 A fix for bug #523899
1409 * generics.cs: Exact type inference with other bound types.
1411 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1413 Don't complain when the same type is implemented by the output
1414 assembly as well as multiple referenced assemblies
1415 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1416 'must_be_unique' flag.
1417 (GlobalRootNamespace): Update to changes.
1418 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1419 already have a type in hand.
1421 2009-07-22 Marek Safar <marek.safar@gmail.com>
1423 * expression.cs: More verifier instrumentation.
1425 * statement.cs: Do proper throw expression conversion.
1427 2009-07-22 Marek Safar <marek.safar@gmail.com>
1429 A fix for bug #522789
1430 * expression.cs: Mutate invocation return type.
1432 2009-07-16 Marek Safar <marek.safar@gmail.com>
1434 * anonymous.cs: Split assignable and readonly generated variable
1437 2009-07-16 Marek Safar <marek.safar@gmail.com>
1439 A fix for bug #521671
1440 * statement.cs: Fixed crash when checking missing type.
1442 2009-07-16 Marek Safar <marek.safar@gmail.com>
1444 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1445 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1446 class.cs, driver.cs: Work on dynamic binding.
1448 * dynamic.cs: New file.
1450 * *.sources, *.proj: Updated.
1452 2009-07-15 Marek Safar <marek.safar@gmail.com>
1454 * expression.cs (Conditional): Avoid double Resolve.
1456 2009-07-13 Marcus Griep <marcus@griep.us>
1458 * ecore.cs: Fix obscure bug with resolving members of interfaces
1459 that hide parent interface members. Fixes bug #444388 and corrects
1462 2009-07-13 Marek Safar <marek.safar@gmail.com>
1464 * expression.cs (LocalVariableReference): Bounce resolve.
1466 2009-07-10 Marek Safar <marek.safar@gmail.com>
1468 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1469 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1472 * support.cs: New dynamic type wrapper.
1474 2009-07-08 Marek Safar <marek.safar@gmail.com>
1476 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1477 typed local variable.
1479 2009-07-06 Marek Safar <marek.safar@gmail.com>
1481 A fix for bug #519005
1482 * anonymous.cs: Use null_type as no return type placeholder.
1484 2009-07-02 Marek Safar <marek.safar@gmail.com>
1486 * generic.cs: Handle type inference of identical type parameters
1487 with different bounds.
1489 2009-07-01 Marek Safar <marek.safar@gmail.com>
1491 * expression.cs, class.cs: Events variance.
1493 * cs-parser.jay: Interface events error messages.
1495 2009-07-01 Marek Safar <marek.safar@gmail.com>
1497 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1499 2009-06-29 Marek Safar <marek.safar@gmail.com>
1501 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1502 parameter expression can be value-type New.
1504 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1506 2009-06-26 Marek Safar <marek.safar@gmail.com>
1508 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1509 Implemented C# 4.0 named arguments.
1511 2009-06-24 Marek Safar <marek.safar@gmail.com>
1513 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1514 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1515 parameter modifier. Also fixes bug #515497.
1517 2009-06-24 Marek Safar <marek.safar@gmail.com>
1519 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1520 arguments expression to be implemented.
1522 *.sources: Add argument.cs
1524 2009-06-23 Marek Safar <marek.safar@gmail.com>
1526 * parameter.cs: Moved GetParameterIndexByName to base class.
1528 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1529 unused AType. Use argument's version of GetExpressionTree.
1531 2009-06-22 Marek Safar <marek.safar@gmail.com>
1533 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1536 2009-06-17 Marek Safar <marek.safar@gmail.com>
1538 A fix for bug #514096
1539 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1541 2009-06-17 Marek Safar <marek.safar@gmail.com>
1543 * expression.cs: The first multi-dimensional array nested array
1544 initializers was not checked.
1546 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1548 2009-06-17 Marek Safar <marek.safar@gmail.com>
1550 A fix for bug #513400
1551 * nullable.cs (EmitEquality): Operands emit could be simplified for
1552 built-in types when we now emit user operators differently.
1554 2009-06-16 Marek Safar <marek.safar@gmail.com>
1556 * ecore.cs: Report inaccessible delegate methods correctly.
1558 2009-06-16 Marek Safar <marek.safar@gmail.com>
1560 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1561 cs-parser.jay: Implemented C# 4.0 optional parameters.
1563 2009-06-16 Marek Safar <marek.safar@gmail.com>
1565 * driver.cs: Removed broken DefineManifestResource.
1567 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1569 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1570 Use $(BOOTSTRAP_PROFILE) instead.
1572 2009-06-12 Jb Evain <jbevain@novell.com>
1574 * rootcontext.cs: add a Platform field.
1575 * driver.cs: handle /platform.
1576 * codegen.cs: pass the proper flags according to
1577 the platform when saving the assembly.
1579 2009-06-11 Marek Safar <marek.safar@gmail.com>
1581 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1582 Add optional parameters grammar.
1584 2009-06-10 Marek Safar <marek.safar@gmail.com>
1586 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1587 driver.cs: Split lang version and metadata version.
1589 2009-06-10 Marek Safar <marek.safar@gmail.com>
1591 * decl.cs: Better overload ctor collision error message.
1593 2009-06-05 Jb Evain <jbevain@novell.com>
1595 * driver.cs (EmbededResource): avoid using an internal method
1596 in gmcs to embed manifest resources.
1598 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1600 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1601 the compiler from older mono versions (like moon's bots)
1603 2009-06-04 Marek Safar <marek.safar@gmail.com>
1605 * namespace.cs (LookupTypeReflection): Ignore collisions between
1608 2009-06-04 Marek Safar <marek.safar@gmail.com>
1610 * codegen.cs: Enabled generic type forwarders.
1612 2009-06-04 Marek Safar <marek.safar@gmail.com>
1614 * dmcs.*: Add another version of SRE compiler.
1616 2009-06-03 Marek Safar <marek.safar@gmail.com>
1618 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1619 generic-mcs.cs: Fixed variant type conversions.
1621 2009-06-02 Marek Safar <marek.safar@gmail.com>
1623 A fix for bug #507863
1624 * codegen.cs: Fixes a crash on invalid string value attribute.
1626 2009-06-01 Marek Safar <marek.safar@gmail.com>
1628 A fix for bug #508334
1629 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1630 cs-parser.jay: Fully import __arglist modifier.
1632 2009-05-29 Marek Safar <marek.safar@gmail.com>
1634 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1635 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1636 actually work with closed generic types.
1638 2009-05-27 Alan McGovern <amcgovern@novell.com>
1640 * class.cs, decl.cs, delegate.cs, parameter.cs:
1641 Fix the build by replacing the use of 'var' with the actual type.
1643 2009-05-27 Marek Safar <marek.safar@gmail.com>
1645 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1646 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1649 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1652 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1653 Marek Safar <marek.safar@gmail.com>
1655 A fix for bug #377509
1656 * parameter.cs: Use predefined and not empty name for implicit
1659 2009-05-21 Marek Safar <marek.safar@gmail.com>
1661 * class.cs: Don't report wrong warnings for event fields.
1663 2009-05-21 Marek Safar <marek.safar@gmail.com>
1665 A fix for bug #504667
1666 * class.cs: Check for static class using parent container instead of
1669 2009-05-08 Marek Safar <marek.safar@gmail.com>
1671 A fix for bug #496922
1672 * expression.cs: Always use temporary variable when using object
1675 2009-04-28 Marek Safar <marek.safar@gmail.com>
1677 A fix for bug #495112
1678 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1681 2009-04-27 Miguel de Icaza <miguel@novell.com>
1683 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1685 2009-04-24 Miguel de Icaza <miguel@novell.com>
1687 * complete.cs: No idea how gonzalo got a null in the list, but
1690 2009-04-24 Miguel de Icaza <miguel@novell.com>
1692 * complete.cs (CompletionElementInitializer): New completion class
1693 to support completing inside a C# 3 element initializer, so this
1694 allows completion for Silverlight situations where it is very
1697 new TextBlock () { Fo<TAB>
1699 (CompletionSimpleName): Expose the prefix that was
1700 passed to the simple name.
1702 * cs-parser.jay (object_or_collection_initializer): Add support
1703 for element_initializers.
1705 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1706 special case completion expressions as this method aggressively
1707 collects data before it operates, and errors were being thrown
1708 earlier than we were able to complete.
1710 2009-04-23 Miguel de Icaza <miguel@novell.com>
1712 * eval.cs: Make getcompletions silent and enable debugging output
1713 if the -v option is passed.
1715 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1716 Consider looking up the namespace that matches the prefix being
1719 This is part of the support for allowing completions like:
1720 `System.Co<TAB>' to complete to System.Console.
1722 * complete.cs (CompletionSimpleName.AppendResults): Make this
1725 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1727 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1728 COMPLETE_COMPLETION as internal.
1730 2009-04-17 Miguel de Icaza <miguel@novell.com>
1732 * complete.cs: Include namespace resolution in simple names as
1733 well as global types and types in the using scope in the
1736 * namespace.cs: Supporting infrastrcture to provide completions
1737 based on the current using scope.
1739 * eval.cs: Introduce an entry point that allows for initialization
1740 to return a list of the files passed on the command line.
1742 2009-04-14 Marek Safar <marek.safar@gmail.com>
1744 A fix for bug #494243
1745 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1747 2009-04-13 Marek Safar <marek.safar@gmail.com>
1749 A fix for bug #493887
1750 * statement.cs: Don't skip string multi-section with default or
1751 null label when populating string hashtable.
1753 2009-04-06 Marek Safar <marek.safar@gmail.com>
1755 A fix for bug #492329
1756 * expression.cs (New): Load variable when assigning type parameter
1759 2009-04-06 Marek Safar <marek.safar@gmail.com>
1761 A fix for bug #488960
1762 * decl.cs: Compare MVAR types using non-null values.
1764 2009-03-27 Marek Safar <marek.safar@gmail.com>
1766 * typemanager.cs, expression.cs: Removed unused nullable checks.
1768 2009-03-27 Marek Safar <marek.safar@gmail.com>
1770 * *.cs: Removed some gmcs conditionals.
1772 2009-03-26 Marek Safar <marek.safar@gmail.com>
1774 * generic.cs, support.cs: Moved generics stuff out of support.cs
1776 2009-03-24 Marek Safar <marek.safar@gmail.com>
1778 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1781 2009-03-23 Marek Safar <marek.safar@gmail.com>
1783 * attribute.cs: Consider all members for error reporting when
1784 checking named arguments.
1786 2009-03-23 Marek Safar <marek.safar@gmail.com>
1788 A fix for bug #487625
1789 * namespace.cs: Use a warning for all predefined type conflicts.
1791 2009-03-23 Marek Safar <marek.safar@gmail.com>
1793 A fix for bug #485706
1794 * statement.cs: Explicitly type catch type argument to pass verifier
1797 2009-03-22 Miguel de Icaza <miguel@novell.com>
1799 Initial support to provide code completion facilities to consumers
1800 of the evaluator API.
1802 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1803 support the completion engine. When we reach the end of the
1804 input stream instead of returning EOF, when this flag is true the
1805 tokenizer instead produces:
1807 One GENERATE_COMPLETION token: this token then must be
1808 handled in the grammar at every point where the user
1809 would likely request a completion.
1811 As many COMPLETE_COMPLETION tokens as necessary. These
1812 tokens are generated to assist the parser in unwinding and
1813 producing a valid parse tree.
1815 The parser rules do not have to be perfect, the parser needs to be
1816 augmented with judicious use of GENERATE_COMPLETION tokens to
1817 improve the areas where we can provide completion and the parser
1818 needs to add support for COMPLETE_COMPLETION tokens in productions
1821 It is common to not have enough support for COMPLETE_COMPLETION
1822 under certain rules and that even if we generated the
1823 GENERATE_COMPLETION token that the resulting tree will be invalid
1824 due to the missing rules that support COMPLETE_COMPLETION.
1826 The final EOF token is produced by having the parser notify the
1827 tokenizer when it reaches the root production that the next token
1830 * support.cs (CompletionResult): New Exception. This exception
1831 is thrown to return the completion results when one of the special
1832 completion expressions is reached.
1834 This exception is thrown by the completing ExpressionStatements
1835 classes that live in complete.cs
1837 * complete.cs (CompletingExpression): a new base class for
1838 completing expressions. This derives from the
1839 ExpressionStatement class and not from Expression as it allows
1840 completion to happen not only where expressions are expected in
1841 the grammar, but also where statements are expected.
1843 (CompletionSimpleName): A new class used to provide completions
1844 for SimpleNames. This currently only resolves to local
1845 variables from the evaluator context (GetVars call).
1847 (CompletionMemberAccess): Implements support for completing member
1850 * cs-parser.jay: Add support for completion in a few places.
1852 * eval.cs (GetCompletions): New public API for the evaluator that
1853 returns a list of possible completions given the input. The
1854 return value is an array of completions
1856 * anonymous.cs (Compatible): If the exception thrown from the
1857 resolved expression is a CompletionResult exception let that one
1858 through instead of printing a diagnostic error in the try/catch.
1860 2009-03-22 Miguel de Icaza <miguel@novell.com>
1864 * driver.cs (Main): Use Environment.Exit to quit quickly and
1865 prevent the compiler from doing the usual wait for helper thread
1868 This is to prevent a slowdown that was reported by Gonzalo on
1871 2009-03-19 Marek Safar <marek.safar@gmail.com>
1873 * ecore.cs: Load build-in types directly instead of accessing
1876 2009-03-18 Marek Safar <marek.safar@gmail.com>
1878 * ecore.cs: Always use unbox.any when available.
1880 2009-03-18 Marek Safar <marek.safar@gmail.com>
1882 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1884 2009-03-17 Marek Safar <marek.safar@gmail.com>
1886 * generic.cs: Removed obsolete version of type inference.
1888 2009-03-16 Marek Safar <marek.safar@gmail.com>
1890 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1891 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1892 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1893 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1895 2009-03-11 Marek Safar <marek.safar@gmail.com>
1897 A fix for bug #482996
1898 * anonymous.cs: Make sure we are not infering return type when
1899 checking type compatibility.
1901 2009-03-11 Marek Safar <marek.safar@gmail.com>
1903 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1904 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1905 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1906 attributes in their own structure. Needed when accessing their
1907 properties before they are resolved.
1909 2009-03-09 Marek Safar <marek.safar@gmail.com>
1911 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1912 hashtable (~10x faster).
1914 * driver.cs: Removed wrong Reset.
1916 2009-03-08 Marek Safar <marek.safar@gmail.com>
1918 * class.cs: Use correct common base type for unmanaged delayed
1921 * rootcontext.cs: Wrap unhandled exception.
1923 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1925 Make SeekableStreamReader self-tuning and arbitrarily seekable
1926 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1928 (SeekableStreamReader.Position.set): Use it. Simplify logic
1929 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1930 buffer size when the stream needs to be re-read from the beginning.
1932 2009-03-05 Marek Safar <marek.safar@gmail.com>
1934 A fix for bug #480100
1935 * parameter.cs: A parameter is not hoisted when used directly as ET.
1937 2009-03-04 Marek Safar <marek.safar@gmail.com>
1939 * statement.cs: Fixed an issue when using variable is of interface
1942 2009-03-03 Marek Safar <marek.safar@gmail.com>
1944 A fix for bug #480319
1945 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1947 2009-03-03 Marek Safar <marek.safar@gmail.com>
1949 A fix for bug #480867
1950 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1951 expression to have no valid type.
1953 2009-03-03 Marek Safar <marek.safar@gmail.com>
1955 A fix for bug #481258
1956 * class.cs: Set extension method flag in partial container.
1958 2009-03-03 Marek Safar <marek.safar@gmail.com>
1960 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1962 * attribute.cs: Add sanity check.
1964 2009-02-27 Marek Safar <marek.safar@gmail.com>
1966 * class.cs: Add external constructor error.
1968 2009-02-26 Marek Safar <marek.safar@gmail.com>
1970 A fix for bug #475354
1971 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1972 correctly user defined nullable equality operators.
1974 2009-02-25 Marek Safar <marek.safar@gmail.com>
1976 A fix for bug #479532
1977 * expression.cs: Implement NewInitialize::AddressOf.
1979 2009-02-25 Marek Safar <marek.safar@gmail.com>
1981 A fix for bug #413633
1982 * expression.cs: Iterate all base class-constraint types.
1984 2009-02-24 Marek Safar <marek.safar@gmail.com>
1986 A fix for bug #479209
1987 * literal.cs: Mutate null underlying type.
1989 2009-02-24 Marek Safar <marek.safar@gmail.com>
1991 A fix for bug #476295
1992 * convert.cs: Avoid wrapping implicitly convertible reference type.
1994 2009-02-23 Marek Safar <marek.safar@gmail.com>
1996 * iterators.cs: Create MemberName correctly.
1998 2009-02-23 Marek Safar <marek.safar@gmail.com>
2000 A fix for bug #478655
2001 * literal.cs: Check also underlying null type conversion.
2003 2009-02-21 Marek Safar <marek.safar@gmail.com>
2005 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
2007 2009-02-20 Marek Safar <marek.safar@gmail.com>
2009 A fix for bug #477447
2010 * statement.cs: Add reference to correct parent storey when this
2011 is accessible from deep children storey (more than 1 level).
2013 2009-02-19 Marek Safar <marek.safar@gmail.com>
2015 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
2016 * class.cs: Define base type members before setting up member cache.
2018 2009-02-18 Marek Safar <marek.safar@gmail.com>
2020 A fix for bug #477378
2021 * nullable.cs, expression.cs, statement.cs: More precise null type
2024 2009-02-18 Marek Safar <marek.safar@gmail.com>
2026 A fix for bug #472805
2027 * typemanager.cs, namespace.cs: Import only visible extension method
2030 2009-02-18 Marek Safar <marek.safar@gmail.com>
2032 A fix for bug #476895
2033 * attribute.cs: Use correct resolve context for attribute type.
2035 2009-02-18 Marek Safar <marek.safar@gmail.com>
2037 A fix for bug #476266
2038 * anonymous.cs: Mutate multi-dimensional arrays.
2040 2009-02-18 Marek Safar <marek.safar@gmail.com>
2042 A fix for bug #476400
2043 * statement.cs, expression.cs: Removed wrong Dispose optimization.
2045 2009-02-18 Marek Safar <marek.safar@gmail.com>
2047 A fix for bug #476811
2048 * generics.cs: Fixed null-literal check.
2050 2009-02-17 Marek Safar <marek.safar@gmail.com>
2052 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
2053 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
2054 messing with static variables.
2056 2009-02-16 Marek Safar <marek.safar@gmail.com>
2058 A fix for bug #475965
2059 * generics.cs: Check generic parameter type after extracting from
2062 2009-02-16 Marek Safar <marek.safar@gmail.com>
2064 A fix for bug #475823
2065 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
2068 2009-02-14 Marek Safar <marek.safar@gmail.com>
2070 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
2071 Simplified event field definition using backing field and not
2072 field builder directly.
2074 * expression.cs (EmitLdArg): Optimize fast paths.
2076 2009-02-13 Marek Safar <marek.safar@gmail.com>
2078 A fix for bug #475327
2079 * expression.cs (ArrayCreation): Don't mutate values optimized away.
2081 2009-02-13 Marek Safar <marek.safar@gmail.com>
2083 A fix for bug #475342
2084 * cs-parser.jay: Using 'super' instead of 'base' to call base
2085 constructor crashes compiler.
2087 2009-02-13 Marek Safar <marek.safar@gmail.com>
2089 A fix for bug #475354
2090 * expression.cs (Constantify): Add nullable types.
2092 * const.cs (EmitDecimalConstant): Avoid explicit cast.
2094 2009-02-12 Marek Safar <marek.safar@gmail.com>
2096 A fix for bug #475246
2097 * expression.cs: More broken flowanalysis hacking needed.
2099 2009-02-12 Marek Safar <marek.safar@gmail.com>
2101 * attribute.cs: Compare only ref/out array modifiers.
2103 2009-02-11 Marek Safar <marek.safar@gmail.com>
2105 * statement.cs: Use member cache when looking for foreach members.
2107 2009-02-11 Marek Safar <marek.safar@gmail.com>
2109 * expression.cs: Don't expose internal initializer types.
2111 * statement.cs: Check also explicit conversions for goto case.
2113 2009-02-11 Marek Safar <marek.safar@gmail.com>
2115 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
2117 2009-02-10 Marek Safar <marek.safar@gmail.com>
2119 * *.cs: Replace null-type with NullLiteral where appropriate.
2121 2009-02-09 Marek Safar <marek.safar@gmail.com>
2123 * expression.cs: Initializer of reference argument use temporary
2124 variable to be verifiable.
2126 * parameter.cs: Share EmitLdArg.
2128 2009-02-09 Marek Safar <marek.safar@gmail.com>
2130 A fix for bug #473559
2131 * class.cs: Fixed: Not reporting error about nested class with the
2134 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
2136 Contributed under the MIT/X11 license.
2138 * generic.cs: Added VerifyVariantTypeParameters which performs new
2139 variance verification logic. The old logic, based on the spec, was
2140 wrong because the spec is full of LIES!
2142 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
2144 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
2147 * ecore.cs: Added calls to the new variance verification logic.
2150 * delegate.cs: Removed calls to the old variance verification logic.
2152 2009-02-06 Marek Safar <marek.safar@gmail.com>
2154 * delegate.cs: Use cached Invoke method directly.
2156 2009-02-06 Marek Safar <marek.safar@gmail.com>
2158 * expression.cs: Emit expression tree for hoisted variable access.
2160 2009-02-04 Marek Safar <marek.safar@gmail.com>
2162 * namespace.cs: Add better extension class check.
2164 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
2166 * generic.cs: Fixed typeo (TypeParameter.Variacne).
2168 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
2170 This patch adds initial generic variance support to the compiler.
2171 It is contributed under the MIT/X11 license.
2173 * typemanager.cs: Modified ImplementsInterface to check variance.
2174 Added VerifyVariantTypeParameters which checks the specified type to see
2175 if it uses a variant type parameter as a type argument (which is not
2176 allowed). Added IsVariantOf which determins if the first type is a
2177 variant of the second. NOTE: This only supports reference types at
2178 the moment to conform with the current level of VM support. When the
2179 VM supports value types, this will follow step.
2181 * generic.cs: Added the Variance enum. Added a Variance property to
2182 TypeParameter and added variance support to definition phase. Added a
2183 Variance property to TypeParameterName. Also check to make sure that
2184 no variant types appear in generic method parameters.
2186 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
2187 keywords if the langversion supports it.
2189 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
2190 that variant types are only used in legal positions. Also added
2191 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
2194 * decl.cs: Construct TypeParameter with the variance information.
2196 * convert.cs: Checks variance in ImplicitReferenceConversionExists
2197 and ImplicitConversionStandard.
2199 * rootcontext.cs: Added new "Future" language version.
2201 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
2202 type parameters are not used as type arguments in interface inheritance.
2203 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
2204 parameters are not used as method return types. In MemberBase.
2205 ResolveMemberType, ensure that variant type parameters are not used
2206 as type arguments. Also call VerifyNoVariantTypeParameters on every
2207 set of parameters which are resolved.
2209 * delegate.cs: Modified Delegate.Define to ensure that variant
2210 parameters are not used as type arguments and that a contravariant
2211 parameter is not used as the return type. Also call
2212 VerifyNoVariantTypeParameters on the delegate parameters.
2214 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
2215 to specify generic variance.
2217 * driver.cs: Added support for LanguageVersion.Future in the form of
2218 "-langversion:future".
2220 * generic-mcs.cs: Stubbed out new members in generic.cs.
2222 2009-02-03 Marek Safar <marek.safar@gmail.com>
2224 * class.cs, generic.cs: Emit type parameter constraints for nested
2227 2009-02-02 Marek Safar <marek.safar@gmail.com>
2229 A fix for bug #471213
2230 * class.cs: Avoid emitting backing field for abstract event fields.
2232 2009-02-01 Marek Safar <marek.safar@gmail.com>
2234 A fix for bug #359731
2235 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
2238 2009-01-30 Marek Safar <marek.safar@gmail.com>
2240 A fix for bug #470767
2241 * statement.cs: Introduced BlockScopeExpression, needed when
2242 expression tree conversion has to emit scope variables.
2244 2009-01-29 Marek Safar <marek.safar@gmail.com>
2246 * class.cs: Remove duplicate CallingConvention.
2248 2009-01-29 Marek Safar <marek.safar@gmail.com>
2250 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
2251 when I finally found the right naming convention.
2253 2009-01-29 Marek Safar <marek.safar@gmail.com>
2255 * cs-tokenizer.cs: Put back different open parens optimization.
2257 2009-01-28 Marek Safar <marek.safar@gmail.com>
2259 A fix for bug #470227
2260 * cs-tokenizer.cs: Remove too agressive parser optimization.
2262 2009-01-28 Marek Safar <marek.safar@gmail.com>
2264 A fix for bug #324319
2265 * class.cs: Remove too early base type resolve.
2267 2009-01-27 Marek Safar <marek.safar@gmail.com>
2269 A fix for bug #324319
2270 * ecore.cs: Explicitly type null when assigning to type argument to
2271 make pass verifier check.
2273 2009-01-27 Marek Safar <marek.safar@gmail.com>
2275 * anonymous.cs: Fixed recent regression when initializing captured
2278 2009-01-26 Marek Safar <marek.safar@gmail.com>
2280 A fix for bug #469019
2281 * anonymous.cs: Use all parent type parameters when instantiating
2282 nested generic storey.
2284 2009-01-26 Marek Safar <marek.safar@gmail.com>
2286 * expression.cs: Check for null instance methodgroup expression.
2288 2009-01-26 Marek Safar <marek.safar@gmail.com>
2290 A fix for bug #469244
2291 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
2292 instance inside a conditional expression.
2294 2009-01-23 Marek Safar <marek.safar@gmail.com>
2296 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
2297 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
2298 GetElementType and HasElementType. IsValueType clean up.
2300 2009-01-23 Marek Safar <marek.safar@gmail.com>
2302 * nullable.cs: Use common EmitCall.
2304 * expression.cs: Emit constraint. for virtual calls only.
2306 2009-01-23 Marek Safar <marek.safar@gmail.com>
2308 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
2309 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
2310 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
2313 2009-01-22 Jb Evain <jbevain@novell.com>
2315 * anonymous.cs: make anonymous types' ToString implementation
2316 match what csc outputs.
2318 2009-01-21 Marek Safar <marek.safar@gmail.com>
2320 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
2323 2009-01-17 Marek Safar <marek.safar@gmail.com>
2325 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
2328 2009-01-16 Marek Safar <marek.safar@gmail.com>
2330 * nullable.cs (LiftedBinaryOperator): Check for all possible null
2333 2009-01-15 Marek Safar <marek.safar@gmail.com>
2335 A fix for bug #466634
2336 * statement.cs: Add reference for nested storey when only this
2339 2009-01-15 Marek Safar <marek.safar@gmail.com>
2341 A fix for bug #466474
2342 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
2345 2009-01-15 Marek Safar <marek.safar@gmail.com>
2347 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
2348 Fixed nested stories parent referencing process. Also fixes #463985.
2350 2009-01-06 Marek Safar <marek.safar@gmail.com>
2352 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
2353 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
2354 implementation. Also fixes #463108.
2356 2009-01-05 Marek Safar <marek.safar@gmail.com>
2358 A fix for bug #416109
2359 * decl.cs: Issue correct CLSAttribute warning location.
2361 2009-01-05 Marek Safar <marek.safar@gmail.com>
2363 A fix for bug #456775
2364 * attribute.cs: Use attribute owner scope when resolving attribute
2367 2009-01-05 Marek Safar <marek.safar@gmail.com>
2369 A fix for bug #457257
2370 * decl.cs: Fixed incorrect member declaring type comparison.
2372 2009-01-05 Marek Safar <marek.safar@gmail.com>
2374 A fix for bug #460896
2375 * driver.cs: Handle /RES resources as embeddable.
2377 2009-01-05 Marek Safar <marek.safar@gmail.com>
2379 A fix for bug #462515
2380 * ecore.cs: Report inacessible members upwards.
2382 2009-01-05 Marek Safar <marek.safar@gmail.com>
2384 A fix for bug #463190, #463192
2385 * decl.cs, namespace.cs: Also import internal extension classes.
2387 2009-01-04 Marek Safar <marek.safar@gmail.com>
2389 A fix for bug #463415
2390 * generic.cs: Use right index for RemoveDependentTypes.
2392 2009-01-02 Marek Safar <marek.safar@gmail.com>
2394 A fix for bug #463196
2395 * expression.cs: Fixed enum to null comparison.
2397 2009-01-02 Marek Safar <marek.safar@gmail.com>
2399 A fix for bug #463121
2400 * nullable.cs: Fixed nullable user equality operator comparison.
2402 2009-01-02 Marek Safar <marek.safar@gmail.com>
2404 A fix for bug #462950
2405 * class.cs, decl.cs: Use full explicit name when defining automatic
2406 property backing field.
2408 2009-01-02 Marek Safar <marek.safar@gmail.com>
2410 A fix for bug #462592
2411 * pending.cs: Emit type arguments for generic proxy method.
2413 2008-12-30 Marek Safar <marek.safar@gmail.com>
2415 * expression.cs (As): Mutate all type arguments.
2417 2008-12-29 Marek Safar <marek.safar@gmail.com>
2419 A fix for bug #462622
2420 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2423 2008-12-29 Marek Safar <marek.safar@gmail.com>
2425 A fix for bug #450782
2426 * ecore.cs: Consider more variables of form V.I to be fixed.
2428 2008-12-29 Marek Safar <marek.safar@gmail.com>
2430 A fix for bug #460712
2431 * typemanager.cs: Core types could be imported.
2433 2008-12-28 Marek Safar <marek.safar@gmail.com>
2435 A fix for bugs #460847, #460772, #458049, #457339, #447807
2436 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2437 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2438 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2439 user lambdas used inside query clauses.
2441 2008-12-18 Marek Safar <marek.safar@gmail.com>
2443 A fix for bug #460229
2444 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2446 2008-12-18 Marek Safar <marek.safar@gmail.com>
2448 A fix for bug #459952
2449 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2451 2008-12-18 Marek Safar <marek.safar@gmail.com>
2453 A fix for bug #459630
2454 * convert.cs: Enum to valuetype conversion is not allowed.
2456 2008-12-18 Marek Safar <marek.safar@gmail.com>
2458 A fix for bug #457087
2459 * generic.cs: Don't crash when constraint comes from type
2462 2008-12-16 Marek Safar <marek.safar@gmail.com>
2464 A fix for bug #459221
2465 * anonymous.cs, statement.cs: Delay only captured this
2468 2008-12-12 Marek Safar <marek.safar@gmail.com>
2470 A fix for bug #457489
2471 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2472 and initialization to capture scope initializers correctly.
2474 2008-12-11 Marek Safar <marek.safar@gmail.com>
2476 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2477 ParameterReference refactoring.
2479 2008-12-03 Marek Safar <marek.safar@gmail.com>
2481 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2482 to be imported from any assembly.
2484 2008-12-03 Marek Safar <marek.safar@gmail.com>
2486 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2487 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2488 from anonymous method and lambda expression.
2490 2008-12-01 Marek Safar <marek.safar@gmail.com>
2492 A fix for bug #448560
2493 * expression.cs (As): Box any generic type arguments to be
2496 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2498 Add tripwire for implicit conversion bugs
2499 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2501 (MethodGroupExpr.OverloadResolve): Add sanity check between
2502 IsApplicable and VerifyArgumentsCompat.
2503 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2505 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2507 Fix build break in System.Data_test
2508 * convert.cs (ImplicitConversionExists): Move NullLiteral
2510 (ImplicitStandardConversionExists): ... here.
2512 2008-11-28 Marek Safar <marek.safar@gmail.com>
2514 * literal.cs: Emit correctly explicit null to nullable cast.
2516 2008-11-28 Marek Safar <marek.safar@gmail.com>
2518 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2521 2008-11-28 Marek Safar <marek.safar@gmail.com>
2523 A fix for bug #449005
2524 * convert.cs, nullable.cs: Use only one implicit nullable
2527 2008-11-27 Marek Safar <marek.safar@gmail.com>
2529 * convert.cs, literal.cs: More Convert cleanup is needed.
2531 2008-11-27 Marek Safar <marek.safar@gmail.com>
2533 * decl.cs, class.cs: Fixed misleading error message.
2535 2008-11-26 Marek Safar <marek.safar@gmail.com>
2537 A fix for bug #449005
2538 * nullable.cs (EmitEquality): Disable optimization for user operator
2541 2008-11-25 Marek Safar <marek.safar@gmail.com>
2543 A fix for bug #447027
2544 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2545 with context variables stored as expression instances.
2547 2008-11-25 Marek Safar <marek.safar@gmail.com>
2549 A fix for bug #447027
2550 * delegate.cs: Fixed delegate VerifyMethod logic.
2552 2008-11-24 Marek Safar <marek.safar@gmail.com>
2554 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2557 2008-11-21 Marek Safar <marek.safar@gmail.com>
2559 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2560 member type resolve to follow normal flow, instead of random
2563 2008-11-21 Marek Safar <marek.safar@gmail.com>
2565 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2568 2008-11-21 Marek Safar <marek.safar@gmail.com>
2570 * const.cs: Emit decimal array constant as literal.
2572 2008-11-20 Marek Safar <marek.safar@gmail.com>
2574 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2576 2008-11-19 Marek Safar <marek.safar@gmail.com>
2578 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2579 into real property (saves 8 MB for corlib compilation).
2581 2008-11-19 Marek Safar <marek.safar@gmail.com>
2583 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2584 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2585 generic-mcs.cs: Small cleanup of TypeArguments.
2587 2008-11-18 Marek Safar <marek.safar@gmail.com>
2589 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2590 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2591 of ConstructedType expression, renamed to GenericTypeExpr.
2593 2008-11-17 Marek Safar <marek.safar@gmail.com>
2595 A fix for bug #445303
2596 * location.cs (IsConditionalDefined): Handle undefined global
2599 2008-11-17 Marek Safar <marek.safar@gmail.com>
2601 A fix for bug #444678
2602 * expression.cs (TryReduceConstant): Always create new constant
2605 2008-11-17 Marek Safar <marek.safar@gmail.com>
2607 A fix for bug #444673
2608 * ecore.cs: Ignore open generic types when used as generic type
2611 2008-11-17 Marek Safar <marek.safar@gmail.com>
2613 A fix for bug #445458
2614 * expression.cs, cs-parser.jay: Don't crash when an expression
2617 2008-11-17 Marek Safar <marek.safar@gmail.com>
2619 A fix for bug #445464
2620 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2621 inside unbound type.
2623 2008-11-14 Jb Evain <jbevain@novell.com>
2625 * driver.cs: ignore empty -nowarn argument such as
2626 the one in -nowarn:12,13,,.
2628 2008-11-13 Marek Safar <marek.safar@gmail.com>
2630 A fix for bug #444271
2631 * anonymous.cs: Rescan parent storeys when best candidate was
2634 2008-11-13 Marek Safar <marek.safar@gmail.com>
2636 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2637 useless UnboundTypeExpression.
2639 * attribute.cs: Do check obsolete attribute on generic types.
2641 2008-11-12 Marek Safar <marek.safar@gmail.com>
2643 A fix for bugs #425680, #400139
2644 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2647 2008-11-11 Marek Safar <marek.safar@gmail.com>
2649 A fix for bug #435747
2650 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2651 compound value types assignment. Few micro optimizations added.
2653 2008-11-10 Marek Safar <marek.safar@gmail.com>
2655 A fix for bug #442610
2656 * anonymous.cs (MutateConstructor): More SRE hacking.
2658 2008-11-10 Marek Safar <marek.safar@gmail.com>
2660 A fix for bug #442579
2661 * ecore.cs: Also initialize expanded form of a method with 1 params
2664 2008-11-06 Marek Safar <marek.safar@gmail.com>
2666 * expression.cs (UnaryMutator): Do early l-side check.
2668 2008-11-05 Miguel de Icaza <miguel@novell.com>
2670 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2671 Init, otherwise we would crash later on when checking for friend
2674 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2675 Otherwise we never get any meaningful information as to what
2678 2008-11-05 Marek Safar <marek.safar@gmail.com>
2680 A fix for bug #436318
2681 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2683 2008-11-05 Miguel de Icaza <miguel@novell.com>
2685 * namespace.cs: Turns out that it was a really bad idea to hide
2686 the errors for namespaces not found here in eval mode.
2688 * eval.cs: When we process using clauses, only enter those into
2689 the list of valid using clauses after they have been validated.
2691 The above change gives the proper semantics: it does not
2692 senselessly report the same errors with broken using statements by
2693 never storing them in the first place when they are invalid.
2695 2008-11-05 Marek Safar <marek.safar@gmail.com>
2697 A fix for bug #421839
2698 * cs-parser.jay: Remove expression from coalesce rule to force lower
2699 priority than the assignment operator.
2701 2008-11-05 Marek Safar <marek.safar@gmail.com>
2703 A fix for bug #437875
2704 * nullable.cs: Compile correctly method group operand used with null
2705 coalescing operator.
2707 2008-11-04 Marek Safar <marek.safar@gmail.com>
2709 A fix for bug #434589
2710 * expression.cs (Binary): Ignore lifted conversions when at least
2711 one operand is of reference type.
2713 2008-11-04 Marek Safar <marek.safar@gmail.com>
2715 * cs-parser.jay: Better syntax error report.
2717 2008-11-03 Marek Safar <marek.safar@gmail.com>
2719 A fix for bug #436792
2720 * cs-parser.jay: Use GetLocation to access location.
2722 2008-11-03 Marek Safar <marek.safar@gmail.com>
2724 A fix for bug #440774
2725 * cs-parser.jay: Also set current_array_type when parsing local
2728 2008-11-03 Marek Safar <marek.safar@gmail.com>
2730 A fix for bug #440785
2731 * expression.cs (As): Don't resolve self modifing expression
2734 2008-11-03 Marek Safar <marek.safar@gmail.com>
2736 A fix for bug #439447
2737 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2739 2008-11-03 Marek Safar <marek.safar@gmail.com>
2741 A fix for bug #437571
2742 * cs-parser.jay: Fixes internal error for invalid expression
2745 2008-10-17 Marek Safar <marek.safar@gmail.com>
2747 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2749 2008-10-17 Marek Safar <marek.safar@gmail.com>
2751 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2753 2008-10-17 Marek Safar <marek.safar@gmail.com>
2755 * cs-tokenizer.cs: More precise cast parsing.
2757 2008-10-16 Martin Baulig <martin@ximian.com>
2759 * anonymous.cs (AnonymousMethodStorey): Put back the
2760 `hoisted_locals' hashtable and use it in EmitType().
2762 2008-10-15 Marek Safar <marek.safar@gmail.com>
2764 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2765 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2768 2008-10-14 Marek Safar <marek.safar@gmail.com>
2770 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2772 2008-10-14 Marek Safar <marek.safar@gmail.com>
2774 * statement.cs: Mutate scope initializers.
2776 2008-10-14 Marek Safar <marek.safar@gmail.com>
2778 * expression.cs: Use typeless value for This constant.
2780 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2782 2008-10-14 Marek Safar <marek.safar@gmail.com>
2784 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2787 2008-10-13 Marek Safar <marek.safar@gmail.com>
2789 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2792 2008-10-13 Marek Safar <marek.safar@gmail.com>
2794 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2795 parser and tokenizer. Fixes many ambiguities including #433258.
2797 2008-10-10 Marek Safar <marek.safar@gmail.com>
2799 * cs-parser.jay: Fixed missing accessor recovery.
2801 2008-10-10 Marek Safar <marek.safar@gmail.com>
2803 A fix for bug #433701
2804 * expression.cs: Better error message.
2806 2008-10-10 Marek Safar <marek.safar@gmail.com>
2808 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2810 * Makefile: Disabled unused debug symbols.
2812 Also fixes: #320556, #321097, #321656, #321876, #351316
2814 2008-10-09 Miguel de Icaza <miguel@novell.com>
2816 * eval.cs: rename "<interactive>" to "{interactive}", to work
2817 around a requirement in the compiler that this be a valid
2818 filename, and in Windows it is not (433886).
2820 2008-10-09 Marek Safar <marek.safar@gmail.com>
2822 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2824 2008-10-08 Marek Safar <marek.safar@gmail.com>
2826 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2827 cs-parser.jay: Generic type declaration and type arguments cleanup.
2829 2008-10-05 Marek Safar <marek.safar@gmail.com>
2831 * cs-parser.jay: Allow parsing weird array creation construct.
2833 2008-10-05 Marek Safar <marek.safar@gmail.com>
2835 * cs-parser.jay: Conflicts reduction.
2837 2008-10-04 Marek Safar <marek.safar@gmail.com>
2839 * cs-parser.jay: Conflicts reduction.
2841 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2844 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2845 property. Add a 'count' hint about the use of the shared vector.
2846 Ensure that we don't leak out dirty bits.
2847 (UsageVector.MergeChild): Throw away information about variables
2849 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2851 2008-10-03 Marek Safar <marek.safar@gmail.com>
2853 A fix for bug #431746
2854 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2855 parameters when iterator is created.
2857 2008-10-03 Marek Safar <marek.safar@gmail.com>
2859 A fix for bug #431827
2860 * expression.cs: Fixed right based pointer arithmetic operations
2863 2008-10-03 Marek Safar <marek.safar@gmail.com>
2865 A fix for bug #353779
2866 * assign.cs, expression.cs: Fixed compound assignment conversions.
2868 2008-10-02 Marek Safar <marek.safar@gmail.com>
2870 A fix for bug #375262
2871 * statement.cs: Refactor ArrayForeach to be usable with string
2872 indexer. Optimized single dimentional arrays foreach.
2874 2008-10-02 Marek Safar <marek.safar@gmail.com>
2876 A fix for bug #431255
2877 * anonymous.cs, expression.cs: Removed broken optimization.
2879 2008-10-01 Marek Safar <marek.safar@gmail.com>
2881 * anonymous.cs: Use full type parameters of parent generic
2882 containers. Removed unnecessary AddParentStoreyReference call.
2884 2008-10-01 Marek Safar <marek.safar@gmail.com>
2886 A fix for bug #324702
2887 * class.cs: Use better shorter names for explicit interface member
2890 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2892 2008-10-01 Marek Safar <marek.safar@gmail.com>
2894 * expression.cs: Use new interface to check fixed expression.
2896 2008-10-01 Marek Safar <marek.safar@gmail.com>
2898 A fix for bug #421101
2899 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2900 interface to check for fixed fixed-buffers.
2902 2008-10-01 Marek Safar <marek.safar@gmail.com>
2904 A fix for bug #429264
2905 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2907 * delegate.cs: Removed unnecessary casts.
2909 2008-09-30 Marek Safar <marek.safar@gmail.com>
2911 A fix for bug #352151
2912 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2913 class.cs: Fixed already defined explicit interface members check.
2915 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2917 cs-tokenizer.cs: Fix typo.
2919 2008-09-28 Miguel de Icaza <miguel@novell.com>
2921 * eval.cs (InteractiveBase): The quit command now just sets a
2922 flag, instead of calling Environment.Exit(), it is milder on
2925 CompiledMethod is now in Mono.CSharp, not nested inside
2926 the Evaluator, it was inconvenient to use.
2928 2008-09-27 Miguel de Icaza <miguel@novell.com>
2930 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2931 code to be invoked without having to reparse.
2933 2008-09-27 Miguel de Icaza <miguel@novell.com>
2935 * ecore.cs: The recent changes to FieldExpr broke this as well.
2936 Fixes LINQ queries in the interactive shell.
2938 * Multiple files: indentation fixing for the Mono coding
2939 guidelines for the switch statement.
2941 * eval.cs: Make the Evaluator API thread safe.
2943 2008-09-26 Marek Safar <marek.safar@gmail.com>
2945 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2946 constructor parsing.
2948 2008-09-26 Marek Safar <marek.safar@gmail.com>
2950 A fix for bug #325326
2951 * statement.cs: Check possible mistaken empty statement using
2952 explicit blocks only.
2954 2008-09-25 Miguel de Icaza <miguel@novell.com>
2956 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2957 RootNamespace.ComputeNamespaces to update the internal list of
2958 namespaces, this is no longer done for us.
2960 (InteractiveBase): Use the Evaluator APIs instead of calling into
2963 2008-09-25 Marek Safar <marek.safar@gmail.com>
2965 A fix for bug #429264
2966 * expression.cs: Missing mutator for access to multidimensional
2969 2008-09-25 Marek Safar <marek.safar@gmail.com>
2971 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2974 * driver.cs: Missing input argument check.
2976 2008-09-25 Marek Safar <marek.safar@gmail.com>
2978 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2979 expression.cs, statement.cs, rootcontext.cs, class.cs,
2980 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2983 2008-09-24 Miguel de Icaza <miguel@novell.com>
2985 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2986 fully constructed FieldExpr, fixes the regression introduced in
2989 * ecore.cs, expression.cs: Plug back the eclass initialization as
2990 otherwise it regresses `csharp'.
2992 2008-09-24 Marek Safar <marek.safar@gmail.com>
2994 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2995 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2996 phase to resolve phase. It resolves problems with expression trees
2997 and fixes bugs #323796, #325156.
2999 2008-09-23 Marek Safar <marek.safar@gmail.com>
3001 * codegen.cs: Report better error when symbol writer is missing.
3003 2008-09-23 Marek Safar <marek.safar@gmail.com>
3005 * codegen.cs: Set .NET symbol writer.
3007 * decl.cs: Guard against null generic arguments.
3009 * report.cs: Don't report exactly same additional details.
3011 2008-09-22 Marek Safar <marek.safar@gmail.com>
3013 A fix for bug #324917
3014 * cs-parser.jay: Add missing multidimensional non-expression type
3017 2008-09-22 Marek Safar <marek.safar@gmail.com>
3019 A fix for bug #428191
3020 * anonymous.cs: Create an outer generic fields also for non-storey
3023 2008-09-22 Marek Safar <marek.safar@gmail.com>
3025 A fix for bug #378294
3026 * class.cs: Make fixed size buffers gmcs feature only.
3028 2008-09-22 Marek Safar <marek.safar@gmail.com>
3030 A fix for bug #355622, #324993
3031 * assign.cs, const.cs, class.cs: Create new EmitContext for each
3034 2008-09-19 Marek Safar <marek.safar@gmail.com>
3036 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
3039 2008-09-19 Marek Safar <marek.safar@gmail.com>
3041 A fix for bug #416110
3042 * generic.cs: Struct constraint results in default ctor and
3043 ValueType base type constraint to be set.
3045 2008-09-19 Marek Safar <marek.safar@gmail.com>
3047 A fix for bug #423791
3048 * generic.cs: Fixed params output type type-inference.
3050 2008-09-19 Marek Safar <marek.safar@gmail.com>
3052 * cs-parser.jay, expression.cs: Fixed few expression crashes.
3054 2008-09-19 Marek Safar <marek.safar@gmail.com>
3056 * cs-tokenizer.cs: Don't break on extra partial modifier.
3058 2008-09-19 Marek Safar <marek.safar@gmail.com>
3060 A fix for bug #427592
3061 * generic.cs: Use common parameter resolve method.
3063 2008-09-18 Marek Safar <marek.safar@gmail.com>
3065 A fix for bug #414758
3066 * expression.cs, ecore.cs: Fixed crash when accessing non-static
3069 2008-09-18 Marek Safar <marek.safar@gmail.com>
3071 * driver.cs, namespace.cs: Read types and namespaces after all
3072 requested assemblies are loaded, fixes issues with System.Core
3073 auto-reference, and #419888.
3075 2008-09-18 Marek Safar <marek.safar@gmail.com>
3077 A fix for bug #417705
3078 * cs-parser.jay: Fixed as/is operator expression split.
3080 2008-09-18 Marek Safar <marek.safar@gmail.com>
3082 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
3083 Fixed expression tree representation of empty new expression and
3084 new initializer expression.
3086 2008-09-18 Miguel de Icaza <miguel@novell.com>
3088 * eval.cs: Remove warning, keep reference to driver around.
3090 * Hide fields that do not need to be public.
3092 2008-09-17 Marek Safar <marek.safar@gmail.com>
3094 A fix for bug #426385
3095 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
3096 conversion for array elements.
3098 2008-09-17 Marek Safar <marek.safar@gmail.com>
3100 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
3101 void parsing conflicts.
3103 2008-09-15 Marek Safar <marek.safar@gmail.com>
3105 A fix for bug #425601
3106 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
3107 System.Core only when there is no custom ExtensionAttribute
3110 2008-09-15 Miguel de Icaza <miguel@novell.com>
3112 * namespace.cs: Do not report CS0246 (name
3114 2008-09-12 Marek Safar <marek.safar@gmail.com>
3116 A fix for bug #425669
3117 * generic.cs: Don't cache generic static anonymous method
3120 2008-09-12 Marek Safar <marek.safar@gmail.com>
3122 * generic.cs, class.cs, delegate.cs: Check recursive inherited
3123 conflicting constraints.
3125 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
3127 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
3130 2008-09-12 Marek Safar <marek.safar@gmail.com>
3132 * literal.cs, convert.cs, expression.cs, statement.cs: More null
3133 to null pointer conversion fixes.
3135 2008-09-11 Marek Safar <marek.safar@gmail.com>
3137 * cs-parser.jay, expression.cs: An implicitly typed local variable
3138 declarator cannot use an array initializer.
3140 2008-09-11 Marek Safar <marek.safar@gmail.com>
3142 * cs-parser.jay: Reduced number of printed tokens, add sorting.
3144 2008-09-11 Marek Safar <marek.safar@gmail.com>
3146 * generic.cs (InflatedConstraints): Don't crash when constraints
3149 * cs-parser.jay: const_declarator is a block.
3151 * constant.cs: Check for not allowed NaN conversions.
3153 2008-09-10 Miguel de Icaza <miguel@novell.com>
3155 * driver.cs: Drop --shell argument, the compiler is no longer a
3158 * eval.cs: Move most of the code that deals with evaluation into
3159 this file and document the public API from repl.cs
3161 * repl.cs: Remove from here.
3163 2008-09-10 Marek Safar <marek.safar@gmail.com>
3165 A fix for bug #424684
3166 * generic.cs: Generic class constraints must come first.
3168 2008-09-09 Miguel de Icaza <miguel@novell.com>
3170 * cs-parser.jay: Improve error reporting for syntax errors in
3171 statements and expressions, we now report the expected tokens
3172 instead of reporting the useless "; expected".
3174 Drop the strings from the token declaration, it turns out that
3175 they did not do what I thought they did. Instead they were adding
3176 two sets of tokens to the tables.
3178 2008-09-09 Marek Safar <marek.safar@gmail.com>
3180 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
3181 delegate.cs: Share special type check.
3183 2008-09-09 Marek Safar <marek.safar@gmail.com>
3185 A fix for bug #423981
3186 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
3188 2008-09-09 Marek Safar <marek.safar@gmail.com>
3190 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
3193 2008-09-09 Marek Safar <marek.safar@gmail.com>
3195 A fix for bugs: #324750, #335946
3196 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
3197 lookup rule to determine ?-based tokens.
3199 2008-09-08 Miguel de Icaza <miguel@novell.com>
3201 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
3202 expressions (like event adding or removing) end up here, so we
3203 need to treat those as statements.
3205 Add LoadAssembly method.
3207 2008-09-04 Miguel de Icaza <miguel@novell.com>
3209 * repl.cs: Add Time method.
3211 2008-09-05 Marek Safar <marek.safar@gmail.com>
3213 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
3215 2008-09-05 Miguel de Icaza <miguel@novell.com>
3217 * repl.cs: Add workaround for old compilers.
3219 2008-09-04 Jb Evain <jbevain@novell.com>
3221 * repl.cs (PrettyPrint): pretty print everything that
3222 implements IDictionary, as well as IEnumerables. Also,
3223 add a quit helper property.
3225 2008-09-04 Marek Safar <marek.safar@gmail.com>
3227 * constant.cs: Better error reporting for decimal literals.
3229 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
3232 2008-09-04 Marek Safar <marek.safar@gmail.com>
3233 Miguel de Icaza <miguel@novell.com>
3235 A fix for bug #422951
3236 * assign.cs (Assign.DoResolve): Perform the type conversions
3237 checks before we attempt to initialize `New' initializers.
3239 2008-09-04 Marek Safar <marek.safar@gmail.com>
3241 A fix for bug #422853
3242 * delegate.cs (DelegateCreation): Add special handling for
3243 EmptyExpression.Null instance expression which is just another
3244 hack for undecided member instance exression.
3246 2008-09-04 Marek Safar <marek.safar@gmail.com>
3248 * expression.cs, ecore.cs: Emit full expression tree for reduced
3251 2008-09-04 Marek Safar <marek.safar@gmail.com>
3253 * expression.cs (This): Guard against multi-resolving.
3255 * ecore.cs, statement.cs (Throw): Simplified.
3257 * flowanalysis.cs: Also verify event fields.
3259 2008-09-04 Miguel de Icaza <miguel@novell.com>
3261 * assign.cs (Assign.DoResolve): Perform the type conversions
3262 checks before we attempt to initialize `New' initializers.
3264 * repl.cs (PrettyPrint): Add Hashtable prettyprint
3266 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
3269 * repl.cs: Update help.
3271 2008-09-03 Miguel de Icaza <miguel@novell.com>
3273 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
3274 handling of the default config handling, including the special
3275 treatment of System.Core assembly.
3277 Fixes the REPL processing for LINQ.
3279 2008-09-03 Marek Safar <marek.safar@gmail.com>
3281 A fix for bug #422507
3282 * expression.cs (UnboxCast): Add missing child expression mutator.
3284 2008-09-03 Marek Safar <marek.safar@gmail.com>
3286 * driver.cs: Don't self reference System.Core assembly.
3288 2008-09-03 Marek Safar <marek.safar@gmail.com>
3290 A fix for bug #422507
3291 * expression.cs (StringConcat): Add missing type mutator.
3293 2008-09-03 Marek Safar <marek.safar@gmail.com>
3295 * generic.cs (TypeInferenceContext): Follow equality rule for
3296 constructed type lower bound type inference.
3298 2008-09-02 Miguel de Icaza <miguel@novell.com>
3300 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
3301 <dblank@cs.brynmawr.edu> which updates the cursor position on
3304 2008-09-02 Marek Safar <marek.safar@gmail.com>
3306 A fix for bug #367145
3307 * driver.cs: Fixed import of extension methods when using -noconfig
3310 2008-09-02 Marek Safar <marek.safar@gmail.com>
3312 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
3313 version from non-generic implementation instead.
3315 2008-09-01 Marek Safar <marek.safar@gmail.com>
3317 A fix for bug #418908
3318 * class.cs: Use AddScopeStatement for field initializers.
3320 2008-09-01 Marek Safar <marek.safar@gmail.com>
3322 A fix for bug #415385
3323 * ecore.cs, convert.cs: Do method group conversion for equal group types.
3325 2008-09-01 Marek Safar <marek.safar@gmail.com>
3327 A fix for bug #421736
3328 * iterators.cs: Don't crash on unreachable iterators.
3330 2008-09-01 Marek Safar <marek.safar@gmail.com>
3332 A fix for bug #421628
3333 * parameter.cs, attribute.cs: Clone also parameter attributes.
3335 2008-08-30 Miguel de Icaza <miguel@novell.com>
3337 * namespace.cs (LookupType): In EvalMode, try to replace
3338 the TypeBuilder from our cache with a Type as Reflection.Emit does
3339 not like to mix code from older assemblies emitted and new
3342 This sounds like a serious Mono bug that prevents multiple
3343 assemblies to be generated and consumed at the same time.
3345 * cs-parser.jay (push_current_class): Do not make interactive
3346 classes internal or private, make them public as we currently
3347 generate each new class in a new assembly.
3349 2008-08-29 Miguel de Icaza <miguel@novell.com>
3351 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
3352 remove types that are entered into the global namespace during
3353 parsing so that we can remove them on failure.
3355 * cs-parser.jay: Parsing: we now keep track of types that are
3356 entered into global variables and queue those in case the parsing
3359 This happens in a few situations: during partial-input, we invoke
3360 the parser repeatedly for example with the string "class X", this
3361 would cause X to be registed, and we need to remove this
3362 registration so that another parse attempt later with say "class X {"
3363 would actually work.
3365 Additionally, if there is an error in the resolution phase, for
3366 example: "class X : NonExistant {}" th
3368 * cs-parser.jay: Be more precise with the errors being raised,
3369 instead of flagging all exceptions during parsing to be attributed
3370 to the parsing process, distinguish those from errors happening in
3371 the actions and hint that using -v would produce the actual
3374 * repl.cs: Do not load all compiler references on each reset,
3375 doing the partial reset takes care of this.
3377 2008-08-28 Miguel de Icaza <miguel@novell.com>
3379 * repl.cs: Add support for loading all the files from
3380 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3383 Introduce a micro-parser that is able to deambiguate on its input
3384 whether we are dealing with a compilation unit (namespace, class,
3385 interface, struct, delegate) declaration or a statement. This
3386 allows both declarations and statements to be entered.
3388 Set history size by default to 300 lines.
3390 Instead of distinguishing based on the parser.InteractiveResult,
3391 have only two cases: statements were parsed, or a compilation unit
3392 was. Always pull the Using statement additions from the
3393 compilation unit parse.
3395 * cs-tokenizer.cs: Rename tokens to better describe their intent
3396 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3398 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3399 EvalMode is used to trigger the lookup of global variables while
3400 StatementMode is used turn variable declarations into static
3403 * getline.cs: Allow history size to be set.
3405 2008-08-29 Marek Safar <marek.safar@gmail.com>
3407 A fix for bug #360755
3408 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3410 2008-08-29 Marek Safar <marek.safar@gmail.com>
3412 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3414 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3415 member name, it is too confusing
3417 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3419 * rootcontext.cs: Finally default to warning level 4.
3421 2008-08-28 Marek Safar <marek.safar@gmail.com>
3423 * class.cs (CheckBase): Ignore overloaded operators.
3425 2008-08-28 Marek Safar <marek.safar@gmail.com>
3427 A fix for bug #420830
3428 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3430 2008-08-28 Marek Safar <marek.safar@gmail.com>
3432 A fix for bug #420832
3433 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3435 2008-08-28 Marek Safar <marek.safar@gmail.com>
3437 A fix for bug #420386
3438 * nullables.cs: Fixed logic of nullable user comparison operators involving
3441 2008-08-28 Marek Safar <marek.safar@gmail.com>
3443 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3445 2008-08-27 Miguel de Icaza <miguel@novell.com>
3447 * repl.cs: Add support for aborting the running code with C-c.
3449 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3451 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3453 2008-08-27 Miguel de Icaza <miguel@novell.com>
3455 * cs-parser.jay (interactive_statement_list): A new set of rules
3456 for hosting statements that uses the "interactive_" prefix.
3458 * repl.cs: Add support for parsing `using' as a statement or as a
3459 directive. Deambiguating before passing this to the parser.
3461 We need to distinguish statement_expressions that occur at the
3462 toplevel vs those that occur embedded into expressions.
3464 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3465 that fixes the cursor key handling, and a history bug.
3467 2008-08-26 Miguel de Icaza <miguel@novell.com>
3469 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3470 limitations in Console, instead the 2.0 bootstrap libraries now
3471 include the Console bits.
3473 Also, remove the use of Nullables from getline.cs
3477 Interactive support for the C# compiler. Use gmcs --shell to
3478 enter a read-eval-print loop shell.
3480 Docs: http://www.mono-project.com/CsharpRepl
3482 * sources: include repl.cs here and getline.cs for gmcs.exe,
3483 everything else is getline.cs impaired.
3485 * Makefile: when bootstrapping pass a special flag
3486 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3487 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3488 This distinguishes those two cases.
3490 * repl.cs: Support for a read-eval-print loop. Will be soon
3491 refactored into eval support and then REPL on top of it.
3493 * ecore.cs: If a simplename lookup fails, before erroring out,
3494 if we are in EvalMode to resolve the name to a declaration in the
3497 This means that variable declarations that happened in previous
3498 classes (as repl puts every statement in a separate class) are
3499 made visible in this way.
3501 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3502 triggered an error due to the end of file being reached. This is
3503 used to do multi-line input, and notify the caller that the user
3504 needs to provide more text before a successful parse.
3506 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3507 to drive the evaluation with a custom wrapper.
3509 * driver.cs: Add support for --shell, and refactor some code to be
3512 * namespace.cs: Add support for serializing the contents of the
3513 namespaces and reloading them.
3515 * getline.cs: A managed implementation of ReadLine under
3516 X11/Apache2 license terms. Easy to embed in other applications as
3519 * namespace.cs: Add some functions to save and restore the
3522 * rootcontext.cs: New public field.
3524 * cs-tokenizer.cs: Add support for one of the possible characters
3525 we introduce into the token stream.
3527 This patch does not affect the regular tokenization process, the
3528 only performance hit would happen if there is an invalid character
3529 on the input string.
3531 * support.cs: Move isatty helper routine here.
3533 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3534 code generator for in-memory assemblies.
3536 2008-08-26 Marek Safar <marek.safar@gmail.com>
3538 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3539 parameter cannot be always used as a type.
3541 2008-08-21 Marek Safar <marek.safar@gmail.com>
3543 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3545 2008-08-21 Marek Safar <marek.safar@gmail.com>
3547 * convert.cs: Implement explicit array to IList<T> conversion.
3549 2008-08-20 Marek Safar <marek.safar@gmail.com>
3551 A fix for bug #362740
3552 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3554 2008-08-20 Marek Safar <marek.safar@gmail.com>
3556 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3557 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3558 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3559 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3560 handling to use just one type of infrastructure and deal with generics
3563 2008-07-23 Martin Baulig <martin@ximian.com>
3565 *** Merged this from trunk revision 108527 ***
3568 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3569 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3572 2008-08-15 Marek Safar <marek.safar@gmail.com>
3574 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3577 2008-08-15 Marek Safar <marek.safar@gmail.com>
3579 * delegate.cs: Fixed compiler crash when creating delegate using partial
3582 * typemanager.cs: MulticastDelegate is not a delegate.
3584 2008-08-14 Marek Safar <marek.safar@gmail.com>
3586 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3589 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3591 * cs-parser.jay (type): Allow 'var' in mcs too.
3592 (local_variable_type): Likewise.
3594 2008-08-14 Marek Safar <marek.safar@gmail.com>
3596 * driver.cs: Removed broken -noconfig variants.
3598 2008-08-14 Marek Safar <marek.safar@gmail.com>
3600 A fix for bug #417078
3601 * expression.cs: Emit correctly left side pointer operators.
3603 2008-08-13 Marek Safar <marek.safar@gmail.com>
3605 * generic.cs, lambda.cs: Inflate method generic arguments only.
3607 2008-08-12 Marek Safar <marek.safar@gmail.com>
3609 * class.cs: Fixed struct layout check regression.
3611 2008-08-12 Marek Safar <marek.safar@gmail.com>
3613 * cs-parser.jay, enum.cs: Simplified enum parsing.
3615 * decl.cs: Check all type parameters conflicts.
3617 * expression.cs, statement.cs, attribute.cs: More expression checks.
3619 2008-08-11 Marek Safar <marek.safar@gmail.com>
3621 * generic.cs: Add type inference types restriction.
3623 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3624 anonymous.cs, expression.cs: Allocate less accessor parameters.
3626 2008-08-08 Marek Safar <marek.safar@gmail.com>
3628 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3631 2008-08-08 Marek Safar <marek.safar@gmail.com>
3633 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3635 2008-08-07 Marek Safar <marek.safar@gmail.com>
3637 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3638 Also fixes #362146 and #381592.
3640 2008-08-07 Marek Safar <marek.safar@gmail.com>
3642 * ecore.cs: Reduced constant cannot be used as an attribute value.
3644 * cs-parser.jay: Base expression has to be a type.
3646 * expression.cs (Conditional): Uses ReducedExpression.
3648 2008-08-06 Marek Safar <marek.safar@gmail.com>
3650 A fix for bug #376826
3651 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3652 address of hoisted local variable or parameter cannot be taken.
3654 2008-08-05 Marek Safar <marek.safar@gmail.com>
3656 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3657 anonymous method inside checked/unchecked expression.
3659 2008-08-05 Marek Safar <marek.safar@gmail.com>
3661 * typemanager.cs (IsEqual): Guard against null.
3663 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3664 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3665 routine. Fixed few misleading conversion errors.
3667 2008-08-04 Marek Safar <marek.safar@gmail.com>
3669 * class.cs: Consider generics when checking cycles in struct layout.
3671 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3673 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3675 2008-08-04 Marek Safar <marek.safar@gmail.com>
3677 A fix for bug #414165
3678 * anonymous.cs: Use same anonymous implementation method for all anonymous
3681 2008-08-04 Marek Safar <marek.safar@gmail.com>
3683 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3686 2008-08-04 Marek Safar <marek.safar@gmail.com>
3688 * cs-parser.jay: Typeof argument has to be a type expression.
3690 * namespace.cs: Check alias and namespace definitions collisions.
3692 * class.cs, pending.cs: Moved explicit interface accessor implementation
3695 * delegate.cs, expression.cs: Verify special name invocations.
3697 2008-08-01 Marek Safar <marek.safar@gmail.com>
3699 * cs-parser.jay: Don't choke on empty generic type arguments.
3701 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3703 * expression.cs, ecore.cs: Minor expressions bugs.
3705 2008-08-01 Marek Safar <marek.safar@gmail.com>
3707 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3708 and added more error handling.
3710 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3712 * modifiers.cs, enum.cs: Fixed.
3714 2008-07-31 Jb Evain <jbevain@novell.com>
3716 * driver.cs: remove -pkg ability of smcs.
3718 2008-07-30 Marek Safar <marek.safar@gmail.com>
3720 * statement.cs (Switch): Correctly set empty default target for single
3723 2008-07-30 Marek Safar <marek.safar@gmail.com>
3725 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3726 string switch statement implementation to use string dictionary which
3727 significantly (2-8x) improves performance of generated code.
3729 2008-07-29 Marek Safar <marek.safar@gmail.com>
3731 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3732 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3734 2008-07-29 Marek Safar <marek.safar@gmail.com>
3736 A fix for bug #412595
3737 * typemanager.cs, convert.cs, expression.cs: Some types are never
3738 convertible to each other.
3740 2008-07-29 Marek Safar <marek.safar@gmail.com>
3742 * nullable.cs (CreateNullConstant): An error messages update.
3744 2008-07-29 Marek Safar <marek.safar@gmail.com>
3746 A fix for bug #412595
3747 * cfold.cs: Don't cast undefined bool constant.
3749 2008-07-29 Martin Baulig <martin@ximian.com>
3752 (SymbolWriter.Reset): New public static method.
3755 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3757 2008-07-28 Marek Safar <marek.safar@gmail.com>
3759 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3761 * expression.cs (ElementAccess): Exact size allocation.
3763 2008-07-26 Marek Safar <marek.safar@gmail.com>
3765 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3767 2008-07-25 Marek Safar <marek.safar@gmail.com>
3769 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3771 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3774 2008-07-25 Marek Safar <marek.safar@gmail.com>
3776 A fix for bug #412217
3777 * assign.cs: Mutate also assignment type.
3779 2008-07-25 Marek Safar <marek.safar@gmail.com>
3781 A fix for bug #323644
3782 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3785 2008-07-25 Marek Safar <marek.safar@gmail.com>
3787 A fix for bug #412134
3788 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3789 non-enumerable operands when overloading equality or bitwise operators.
3791 2008-07-25 Marek Safar <marek.safar@gmail.com>
3793 * anonymous.cs: Cache closed generic anonymous method delegates.
3795 2008-07-24 Marek Safar <marek.safar@gmail.com>
3797 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3798 anonymous.cs, statement.cs: Always emit anonymous method as static method
3799 when is instance free. Use nesting for nested anynomous methods blocks.
3801 2008-07-23 Marek Safar <marek.safar@gmail.com>
3803 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3806 2008-07-23 Marek Safar <marek.safar@gmail.com>
3808 * expression.cs: Removed MakeSimpleCall.
3810 2008-07-23 Marek Safar <marek.safar@gmail.com>
3812 A fix for bug #323012
3813 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3814 Base method implementing interface has to be public.
3816 2008-07-23 Marek Safar <marek.safar@gmail.com>
3818 * cs-parser.jay: Don't break on missing argument.
3820 2008-07-22 Marek Safar <marek.safar@gmail.com>
3822 A fix for bug #320993
3823 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3824 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3826 2008-07-22 Marek Safar <marek.safar@gmail.com>
3828 A fix for bug #320748
3829 * convert.cs: Implicit user operators cannot convert to interfaces
3831 2008-07-22 Marek Safar <marek.safar@gmail.com>
3833 A fix for bug #312686
3834 * driver.cs: Ignore empty assembly references.
3836 2008-07-22 Marek Safar <marek.safar@gmail.com>
3838 A fix for bug #387040
3839 * ecore.cs: Skip constrains check for an explicit implementation.
3841 2008-07-21 Marek Safar <marek.safar@gmail.com>
3843 A fix for bug #409045
3844 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3845 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3846 identifiers are file specific unless passed as input arguments.
3848 2008-07-21 Marek Safar <marek.safar@gmail.com>
3850 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3851 to emit UnmanagedMarshal data under 2.0 profile.
3853 2008-07-21 Marek Safar <marek.safar@gmail.com>
3855 A fix for bug #410369
3856 * parameter.cs: Clone correctly ParamsParameter.
3858 2008-07-21 Marek Safar <marek.safar@gmail.com>
3860 * expression.cs (Argument): Always report type for type based expressions
3863 2008-07-18 Marek Safar <marek.safar@gmail.com>
3865 A fix for bug #410666
3866 * anonymous.cs: Correctly initialize generic storey reference.
3868 2008-07-18 Marek Safar <marek.safar@gmail.com>
3870 * convert.cs: Don't box same type arguments.
3872 2008-07-18 Marek Safar <marek.safar@gmail.com>
3874 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3875 Finished missing generic type mutators.
3877 2008-07-18 Marek Safar <marek.safar@gmail.com>
3879 * iterators.cs, statement.cs: Finished statements CloneTo.
3881 2008-07-18 Marek Safar <marek.safar@gmail.com>
3883 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3885 * expression.cs: Emit optimized default value expressions in expression tree
3888 2008-07-18 Marek Safar <marek.safar@gmail.com>
3890 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3892 2008-07-17 Marek Safar <marek.safar@gmail.com>
3894 A fix for bug #367536
3895 * cs-parser.jay: Check static constructor of generic types for an access
3898 2008-07-17 Marek Safar <marek.safar@gmail.com>
3900 A fix for bug #353800
3901 * lambda.cs: Emit ret for contextual statements.
3903 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3904 up emitting redundant ret for all anonymous methods with return.
3906 2008-07-17 Marek Safar <marek.safar@gmail.com>
3908 A fix for bug #365188
3909 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3910 create anonymous method storey in unreachable block.
3912 2008-07-17 Marek Safar <marek.safar@gmail.com>
3914 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3915 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3916 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3917 statement.cs: Fixed relevant defects found by Gendarme.
3919 2008-07-17 Marek Safar <marek.safar@gmail.com>
3921 A fix for bug #325291
3922 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3923 statement.cs: Replaced IAnonymousHost with top level block flag.
3925 2008-07-17 Marek Safar <marek.safar@gmail.com>
3927 * cs-parser.jay: Clean up unused open_parens.
3929 2008-07-17 Marek Safar <marek.safar@gmail.com>
3931 * ecore.cs: Custom error message for a range variable assignment.
3933 2008-07-16 Marek Safar <marek.safar@gmail.com>
3935 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3938 2008-07-16 Marek Safar <marek.safar@gmail.com>
3940 * literal.cs: Null literal is of object type.
3942 2008-07-16 Marek Safar <marek.safar@gmail.com>
3944 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3945 expression of nullable equality comparison.
3947 2008-07-15 Marek Safar <marek.safar@gmail.com>
3949 * expression.cs(PointerArithmetic): Removed redundant assignment.
3951 2008-07-15 Marek Safar <marek.safar@gmail.com>
3953 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3955 2008-07-14 Marek Safar <marek.safar@gmail.com>
3957 A fix for bug #408361
3958 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3959 they are replaced by GetMethod.
3961 2008-07-14 Marek Safar <marek.safar@gmail.com>
3963 A fix for bug #408721 by jeremie.laval@gmail.com
3964 * expression.cs (Indirection): Implemented CloneTo.
3966 2008-07-14 Marek Safar <marek.safar@gmail.com>
3968 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3971 2008-07-14 Marek Safar <marek.safar@gmail.com>
3973 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3975 2008-07-11 Marek Safar <marek.safar@gmail.com>
3977 * linq.cs: Reset tranparent parameter counter in probing mode.
3979 2008-07-11 Marek Safar <marek.safar@gmail.com>
3981 * anonymous.cs: Mutate anonymous method type.
3983 2008-07-11 Marek Safar <marek.safar@gmail.com>
3985 * ecore.cs, anonymous.cs: Mutate field expressions.
3987 2008-07-10 Marek Safar <marek.safar@gmail.com>
3989 A fix for bug #369670
3990 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3992 2008-07-10 Marek Safar <marek.safar@gmail.com>
3994 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3996 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3999 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
4000 only one '>', and finds a '>>', abort the generic lookahead.
4002 2008-07-10 Marek Safar <marek.safar@gmail.com>
4004 A fix for bug #319902
4005 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
4007 2008-07-10 Marek Safar <marek.safar@gmail.com>
4009 A fix for bug #406371
4010 * statement.cs: Moved EmitSymbolInfo to Block.
4012 2008-07-09 Marek Safar <marek.safar@gmail.com>
4014 * ecore.cs: Report better error for extension method overload failures.
4016 2008-07-09 Marek Safar <marek.safar@gmail.com>
4018 * expression.cs (Is): No need to box reference values.
4020 2008-07-09 Marek Safar <marek.safar@gmail.com>
4022 * class.cs: Use event resolve context when initializing CreateEmitContext.
4024 2008-07-09 Marek Safar <marek.safar@gmail.com>
4026 A fix for bug #394436
4027 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
4028 method used inside expression trees. Added more LINQ to expression tree
4031 2008-07-08 Marek Safar <marek.safar@gmail.com>
4033 A fix for bug #378189, #370577
4034 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
4037 2008-07-08 Marek Safar <marek.safar@gmail.com>
4039 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
4042 2008-07-08 Marek Safar <marek.safar@gmail.com>
4044 A fix for bug #406702
4045 * anonymous.cs: Always park anonymous method in the nearest parent storey.
4047 2008-07-07 Marek Safar <marek.safar@gmail.com>
4049 A fix for bug #406648
4050 * cs-parser.jay: Report nullable use in mcs for some cases.
4052 2008-07-07 Marek Safar <marek.safar@gmail.com>
4054 * ecore.cs: Improved argument mismatch error messages.
4056 2008-07-07 Marek Safar <marek.safar@gmail.com>
4058 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
4060 2008-07-07 Marek Safar <marek.safar@gmail.com>
4062 * expression.cs (TypeOf): Mutate type argument.
4064 2008-07-04 Marek Safar <marek.safar@gmail.com>
4066 * class.cs: Report missing partial modifier for correct type.
4068 2008-07-04 Marek Safar <marek.safar@gmail.com>
4070 * ecore.cs, expression.cs (VariableReference): Variable property is
4073 2008-07-04 Marek Safar <marek.safar@gmail.com>
4075 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
4077 2008-07-04 Marek Safar <marek.safar@gmail.com>
4079 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
4082 2008-07-04 Marek Safar <marek.safar@gmail.com>
4084 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
4085 anonymous method storey to an instance method when only "this" is hoisted.
4087 2008-07-03 Marek Safar <marek.safar@gmail.com>
4089 A fix for bug #321615
4090 * expression.cs: Pointer comparisons use unsigned operator.
4092 2008-07-03 Marek Safar <marek.safar@gmail.com>
4094 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
4096 2008-07-02 Marek Safar <marek.safar@gmail.com>
4098 A fix for bug #404905
4099 * class.cs: Always initialize local unsafe variables.
4101 2008-06-30 Marek Safar <marek.safar@gmail.com>
4103 A fix for bug #396987
4104 * expression.cs (NewInitialize): Clear local temporary variable for next run
4106 2008-06-27 Marek Safar <marek.safar@gmail.com>
4108 A fix for bug #401020
4109 * ecore.cs: Both types and modifiers have to match for ref and out arguments
4111 2008-06-27 Marek Safar <marek.safar@gmail.com>
4113 A fix for bug #398319
4114 * cs-parser.jay: Implemented undocumented base access expression inside
4117 2008-06-26 Marek Safar <marek.safar@gmail.com>
4119 A fix for bug #404227
4120 * cs-parser.jay: Parse namespace declaration using qualified identifier.
4122 2008-06-26 Marek Safar <marek.safar@gmail.com>
4124 A fix for bug #404227
4125 * convert.cs: Fixed explicit array to interface cast.
4127 2008-06-26 Marek Safar <marek.safar@gmail.com>
4129 A fix for bug #403894
4130 * delegate.cs: Mutate DelegateInvocation type.
4132 2008-06-26 Marek Safar <marek.safar@gmail.com>
4134 A fix for bug #379348
4135 * delegate.cs: Box a load of generic parameters.
4137 2008-06-26 Marek Safar <marek.safar@gmail.com>
4139 * expression.cs: Add an array creation arguments mutate.
4141 2008-06-26 Marek Safar <marek.safar@gmail.com>
4143 A fix for bug #386068
4144 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
4147 2008-06-25 Marek Safar <marek.safar@gmail.com>
4149 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
4152 2008-06-25 Marek Safar <marek.safar@gmail.com>
4154 A fix for bug #403518
4155 * delegate.cs: Type correctly anonymous method new invocation.
4157 2008-06-24 Marek Safar <marek.safar@gmail.com>
4159 A fix for bug #394826
4160 * anonymous.cs: Fully qualify members when resolving anonymous type internal
4163 2008-06-24 Marek Safar <marek.safar@gmail.com>
4165 A fix for bug #394826
4166 * anonymous.cs, iterators.cs: Construct generic storey only when is really
4169 2008-06-24 Marek Safar <marek.safar@gmail.com>
4171 * class.cs: Clone indexer parameters for localized capturing.
4173 2008-06-24 Marek Safar <marek.safar@gmail.com>
4175 A fix for bug #402379
4176 * expression.cs: Don't crash when an object initializer resolve fails.
4178 2008-06-24 Marek Safar <marek.safar@gmail.com>
4180 A fix for bug #402888
4181 * expression.cs: Mutate conditional expression.
4183 2008-06-24 Marek Safar <marek.safar@gmail.com>
4185 A fix for bug #401012
4186 * class.cs: Keep StructLayout in shared container.
4188 2008-06-24 Marek Safar <marek.safar@gmail.com>
4190 A fix for bug #400438
4191 * decl.cs, class.cs: Only properties can be automatically implemented.
4193 2008-06-24 Marek Safar <marek.safar@gmail.com>
4195 * statement.cs (ChangeToIterator): Copy also labels.
4197 2008-06-23 Marek Safar <marek.safar@gmail.com>
4199 * ecore.cs: Pass type argument details to parent extension method.
4201 2008-06-23 Marek Safar <marek.safar@gmail.com>
4203 A fix for bug #375966
4204 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
4206 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
4208 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
4210 2008-06-22 Marek Safar <marek.safar@gmail.com>
4212 A fix for bug #394347
4213 * anonymous.cs: Cache compatible delegates as compatibility check produces
4214 a new method every time.
4216 2008-06-20 Marek Safar <marek.safar@gmail.com>
4218 * anonymous.cs: Propagate storey reference for single references.
4220 2008-06-20 Marek Safar <marek.safar@gmail.com>
4222 A fix for bug #387615
4223 * assign.cs, expression.cs: Correctly clone compound assignment.
4225 2008-06-19 Marek Safar <marek.safar@gmail.com>
4227 A fix for bug #359611, #359604
4228 * anonymous.cs: Mutate all types of hoisted parameters.
4230 2008-06-19 Marek Safar <marek.safar@gmail.com>
4232 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
4233 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
4234 expression.cs, codegen.cs, statement.cs
4236 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
4237 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
4239 ** Anonymous methods, lambda expressions rewrite **
4241 Anonymous expressions are now resolved when an explicit block is resolved
4242 and they don't require any registration procedure anymore. Further,
4243 anonymous methods are defined when explicit block is emitted which allows
4244 better control of whole process and opens possibilities for more
4245 optimizations as well as alternative to reverse whole process.
4247 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
4248 process consistent and to correctly emit hoisted generic methods when they
4249 have at least 1 hoisted variable.
4251 2008-06-17 Martin Baulig <martin@ximian.com>
4253 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
4255 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
4256 virtual property; check it in Emit().
4257 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
4259 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
4261 (Indexer.Define): Likewise.
4263 2008-06-17 Marek Safar <marek.safar@gmail.com>
4265 * convert.cs: Don't use IsInterface on type arguments.
4267 * delegate.cs: DelegateInvocation uses MethodInfo.
4269 * parameter.cs: Removed IsTypeParameter.
4271 * generic-mcs.cs: More missing stuff.
4273 2008-06-16 Martin Baulig <martin@ximian.com>
4276 (Modifiers.DEBUGGER_HIDDEN): New public const.
4279 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
4282 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
4283 (AbstractPropertyEventMethod): Likewise.
4284 (Constructor.Emit): Likewise.
4285 (SourceMethod.SetCompilerGenerated): Removed.
4287 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
4291 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
4292 if we're an `IteratorHost'.
4293 (AnonymousMethodMethod..ctor): Don't set
4294 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
4297 2008-06-16 Marek Safar <marek.safar@gmail.com>
4299 * statement.cs: Clean-up foreach statements.
4301 2008-06-12 Marek Safar <marek.safar@gmail.com>
4303 * class.cs: Stop using public method which should not exist
4304 (MethodBuilder.SetGenericMethodSignature).
4306 2008-06-11 Martin Baulig <martin@ximian.com>
4309 (Location.LookupFile): Add `CompilationUnit' argument; when given
4310 a relative file name, make it relative to the directory the .cs
4311 file is located in instead of using the current directory.
4313 2008-06-11 Martin Baulig <martin@ximian.com>
4316 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
4317 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
4318 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
4319 (SourceMethod.SetCompilerGenerated): Likewise.
4321 2008-06-11 Marek Safar <marek.safar@gmail.com>
4323 * codegen.cs, driver: Only write symbol file when it's asked for.
4325 2008-06-11 Marek Safar <marek.safar@gmail.com>
4327 * codegen.cs: Don't use assembly writer error handling for symbol writer.
4329 2008-06-10 Martin Baulig <martin@ximian.com>
4331 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
4333 2008-06-09 Marek Safar <marek.safar@gmail.com>
4335 A fix for bug #316290
4336 * expression.cs: Include decimal operators in predefined table.
4338 * parameters.cs: More readonlyness.
4340 2008-06-09 Marek Safar <marek.safar@gmail.com>
4342 A fix for bug #397213
4343 * cs-parser.jay: One more missing current_local_parameters reset.
4345 2008-06-09 Marek Safar <marek.safar@gmail.com>
4347 A fix for bug #396633
4348 * class.cs: Host backing field in partial container.
4350 2008-06-09 Marek Safar <marek.safar@gmail.com>
4352 A fix for bug #397068
4353 * expression.cs: Check both operand types when predefined operator is used.
4355 2008-06-05 Martin Baulig <martin@ximian.com>
4357 Merged the `debugger-kahalo' branch.
4360 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
4361 we're an iterator method.
4362 (SourceMethod): Reflect latest symbol writer changes;
4363 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4364 now `start_row' and `end_row'.
4365 (Constructor.Emit): Fix the logic whether to emit symbol information.
4367 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4371 (CompilationUnit): New public class; derives from `SourceFile'.
4372 (SourceFileEntry.DefineSymbolInfo): New public method.
4373 (SourceFileEntry.SetChecksum): New public method.
4374 (Location): Encode hidden line numbers by using `column == 255';
4375 the .ctor now accepts `column == -1' to mark a hidden line number.
4376 (Location.Hidden): New public property.
4377 (Location.CheckPoint): Add `CompilationUnit'.
4378 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4379 (Location.Push): Add `CompilationUnit compile_unit' argument.
4380 (Location.CompilationUnit): New public property.
4383 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4385 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4387 * driver.cs: `SourceFile' -> `CompilationUnit'.
4389 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4391 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4393 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4397 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4398 new symbol writer API to also pass the file.
4400 2008-06-05 Marek Safar <marek.safar@gmail.com>
4402 * statement.cs: Emit catch variable assignment using variable expression.
4404 2008-06-05 Marek Safar <marek.safar@gmail.com>
4406 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4407 with other variable types.
4409 2008-06-04 Marek Safar <marek.safar@gmail.com>
4411 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4412 GetLength method emit, it breaks resolve rules.
4414 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4415 Marek Safar <marek.safar@gmail.com>
4417 A fix for bug #395542
4418 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4421 2008-06-02 Marek Safar <marek.safar@gmail.com>
4423 A fix for bug #395287
4424 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4426 2008-05-31 Marek Safar <marek.safar@gmail.com>
4428 A fix for bug #395845
4429 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4430 non-nullable parameter type.
4432 2008-05-31 Marek Safar <marek.safar@gmail.com>
4434 * class.cs: Handle contructor initializer as a statement in top-level block.
4436 2008-05-30 Marek Safar <marek.safar@gmail.com>
4438 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4439 security attributes.
4441 2008-05-24 Marek Safar <marek.safar@gmail.com>
4443 * ecore.cs, expression.cs: Small IVariable refactoring.
4445 2008-05-22 Marek Safar <marek.safar@gmail.com>
4447 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4449 2008-05-21 Marek Safar <marek.safar@gmail.com>
4451 * cs-parser.jay: Removed redundant catch type check.
4453 2008-05-21 Marek Safar <marek.safar@gmail.com>
4455 A fix for bug #390372
4456 * nullable.cs: Set correct return type.
4458 2008-05-21 Marek Safar <marek.safar@gmail.com>
4460 A fix for bug #391062
4461 * typemanager.cs: Fixed crash when comparing null types.
4463 2008-05-21 Marek Safar <marek.safar@gmail.com>
4465 A fix for bug #391871
4466 * cs-parser.jay: Better error handling for invalid catch type.
4468 2008-05-20 Marek Safar <marek.safar@gmail.com>
4470 A fix for bug #392155
4471 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4473 2008-05-15 Marek Safar <marek.safar@gmail.com>
4475 A fix for bug #390666
4476 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4479 2008-05-15 Marek Safar <marek.safar@gmail.com>
4481 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4484 2008-05-13 Marek Safar <marek.safar@gmail.com>
4486 A fix for bug #389625
4487 * delegate.cs, generic.cs: Some progress on method group return type
4490 2008-05-13 Marek Safar <marek.safar@gmail.com>
4492 A fix for bug #378419
4493 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4495 2008-05-12 Marek Safar <marek.safar@gmail.com>
4497 * class.cs (Constructor): Added IsCompilerGenerated.
4499 2008-05-12 Marek Safar <marek.safar@gmail.com>
4501 * expression.cs: Enum binary operators can accept non-enum operand only when
4502 is implicitly convertible to underlying type.
4504 2008-05-12 Marek Safar <marek.safar@gmail.com>
4506 A fix for bug #389272
4507 * support.cs: Workaround System.InvalidOperationException for enums.
4509 2008-05-12 Marek Safar <marek.safar@gmail.com>
4511 A fix for bug #389073
4512 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4514 2008-05-10 Marek Safar <marek.safar@gmail.com>
4516 * driver.cs: Split Parse.
4518 * location.cs (LookupFile): Uses string.Empty.
4520 2008-05-07 Marek Safar <marek.safar@gmail.com>
4522 * expression.cs, parameter.cs: Small ParameterReference clean up.
4524 2008-05-07 Marek Safar <marek.safar@gmail.com>
4526 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4527 hack. Fixes #387502.
4529 2008-05-06 Martin Baulig <martin@ximian.com>
4531 * class.cs (Constructor.Emit): Fix the logic whether to emit
4534 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4537 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4538 InvalidOperationException when the iterator is before the start or
4541 2008-05-06 Marek Safar <marek.safar@gmail.com>
4543 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4544 when left is nullable type.
4546 2008-05-06 Marek Safar <marek.safar@gmail.com>
4548 A fix for bug #386628
4549 * expression.cs (LocalVariableReference): Continue in resolving when
4550 variable is not assigned.
4552 2008-05-05 Marek Safar <marek.safar@gmail.com>
4554 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4555 nullable operations.
4557 2008-05-04 Marek Safar <marek.safar@gmail.com>
4559 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4560 it saves many redundant temporary variables for nullable operations.
4562 2008-05-03 Marek Safar <marek.safar@gmail.com>
4564 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4566 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4569 * nullable.cs: Constant coalescing operator optimizations.
4571 2008-05-03 Marek Safar <marek.safar@gmail.com>
4573 * constant.cs: Use unsigned conversion for values which are unsigned only.
4575 2008-05-03 Marek Safar <marek.safar@gmail.com>
4577 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4578 coalescing operator as it should be.
4580 2008-05-02 Marek Safar <marek.safar@gmail.com>
4582 A fix for bug #371016
4583 * expression.cs: All predefined delegate operators require implicit method
4586 2008-05-02 Marek Safar <marek.safar@gmail.com>
4588 * constant.cs: Emit long constant as uint when fits the range.
4590 * convert.cs, expression.cs: Fixed few unsafe conversions.
4592 2008-05-02 Marek Safar <marek.safar@gmail.com>
4594 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4596 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4599 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4601 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4603 2008-05-01 Marek Safar <marek.safar@gmail.com>
4605 * constant.cs, literal.cs: IsLiteral property for error reporting.
4607 * ecore.cs, expression.cs: Implemented Property expression.
4609 2008-05-01 Marek Safar <marek.safar@gmail.com>
4611 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4613 * nullable.cs: Implemented nullable coalescing null operator.
4615 * ecore.cs, expression.cs: Expression trees work.
4617 2008-05-01 Marek Safar <marek.safar@gmail.com>
4619 * ecore.cs: CreateExpressionTree is finally abstract.
4621 * expression.cs, linq.cs: Updated.
4623 2008-05-01 Marek Safar <marek.safar@gmail.com>
4625 * expression.cs, ecore.cs: Block base access expression inside expression
4628 2008-05-01 Marek Safar <marek.safar@gmail.com>
4630 A fix for bug #385058
4631 * expression.cs: User-defined operator implementations always take
4632 precedence over predefined operator implementations.
4634 2008-04-30 Marek Safar <marek.safar@gmail.com>
4636 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4637 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4638 expression tree conversions.
4640 2008-04-30 Marek Safar <marek.safar@gmail.com>
4642 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4643 operators method details to Operator class.
4645 2008-04-30 Marek Safar <marek.safar@gmail.com>
4647 * anonymous.cs: Pass unsafe flags to anonymous container.
4649 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4650 inside expression tree.
4652 2008-04-29 Martin Baulig <martin@ximian.com>
4654 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4655 (Tokenizer.PopPosition): Also restore the `line'.
4657 2008-04-29 Marek Safar <marek.safar@gmail.com>
4659 * delegate.cs: Implemented Invoke expression.
4661 2008-04-29 Marek Safar <marek.safar@gmail.com>
4663 * expression.cs: Fixed equality reference comparison regression.
4665 2008-04-29 Marek Safar <marek.safar@gmail.com>
4667 * ecore.cs: Clean up EmptyCast hack.
4669 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4670 using correct conversion rules. Also fixes #383993.
4672 2008-04-28 Martin Baulig <martin@ximian.com>
4674 * class.cs (Constructor.Emit): Don't emit debugging information
4675 for generated default .ctor's.
4677 2008-04-28 Marek Safar <marek.safar@gmail.com>
4679 * convert.cs: Empty-cast ushort to int conversion.
4681 2008-04-28 Marek Safar <marek.safar@gmail.com>
4683 A fix for bug #384191
4684 * ecore.cs, expression.cs: Fixed expression cloning.
4686 2008-04-28 Marek Safar <marek.safar@gmail.com>
4688 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4690 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4692 Fix #381559, test-638.cs, test-639.cs
4693 * assign.cs (CompoundAssign.Helper): New wrapper.
4694 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4696 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4697 Pass unconverted expressions to the params array creation expression.
4698 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4699 (PropertyExpr.EmitAssign): Likewise.
4700 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4701 element if it is of kind CompoundAssign.Helper.
4702 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4703 first before anything else.
4704 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4705 (ArrayAccess.LoadArrayAndArguments): Simplify.
4707 2008-04-27 Marek Safar <marek.safar@gmail.com>
4709 * expression.cs: Fixed cloning of typeof(void).
4711 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4713 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4714 (Assign.Emit): Likewise. Move it to ...
4715 (CompoundAssign.DoResolve): ... here and ...
4716 (CompoundAssign.Emit): ... here.
4717 (EventAddOrRemove): New helper to handle += and -= on events, and
4718 avoid the use of BinaryDelegates.
4719 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4720 (EventExpr.EmitAddOrRemove): Improve.
4721 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4723 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4724 create VarExprs for 'foo.bar.var'.
4725 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4726 is a highly inappropriate name for its functionality.
4728 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4730 Simplify handling of multiple assignments
4731 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4733 (SimpleAssign): New. Class to be used for normal assignments.
4734 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4735 * expression.cs, parameter.cs, statement.cs: Likewise.
4737 2008-04-25 Marek Safar <marek.safar@gmail.com>
4739 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4740 for incompatible underlying types, more to come, uff.
4742 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4745 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4746 Handle 'leave_copy'.
4748 2008-04-25 Marek Safar <marek.safar@gmail.com>
4750 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4752 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4754 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4755 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4756 * statement.cs (While, Do, For): Allow test to have side effects.
4757 (For.DoEmit): Always emit InitStatement.
4760 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4761 Always create SideEffectConstant.
4762 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4763 of type EnumConstant.
4765 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4766 Handle 'right' being SideEffectConstant of type 'bool'.
4768 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4769 Use left.EmitBranchable instead of open coding it, so as to
4770 improve optimization opportunities.
4772 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4774 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4776 (Expression.EmitSideEffect): Document.
4778 2008-04-23 Marek Safar <marek.safar@gmail.com>
4780 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4782 2008-04-23 Marek Safar <marek.safar@gmail.com>
4784 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4786 2008-04-23 Marek Safar <marek.safar@gmail.com>
4788 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4789 conversion to expression tree.
4791 2008-04-23 Marek Safar <marek.safar@gmail.com>
4793 * ecore.cs: Removed unused expression.
4795 2008-04-22 Marek Safar <marek.safar@gmail.com>
4797 * expression.cs: Implemented NegateChecked and New expressions.
4799 2008-04-22 Marek Safar <marek.safar@gmail.com>
4801 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4803 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4806 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4807 needing final 'ret' instruction.
4809 2008-04-22 Marek Safar <marek.safar@gmail.com>
4811 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4813 2008-04-21 Marek Safar <marek.safar@gmail.com>
4815 * expression.cs: Emit ldnull and not null expression as an instance argument
4816 of static method expression calls.
4818 2008-04-21 Marek Safar <marek.safar@gmail.com>
4820 A fix for bug #378200
4821 * expression.cs: Fixed crash when creating parameterless expression tree
4824 2008-04-21 Marek Safar <marek.safar@gmail.com>
4826 A fix for bug #375297
4827 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4830 2008-04-21 Marek Safar <marek.safar@gmail.com>
4832 A fix for bug #377596
4833 * decl.cs, class.cs: Emit delegate type argument attributes.
4835 2008-04-21 Marek Safar <marek.safar@gmail.com>
4837 A fix for bug #365314
4838 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4840 2008-04-21 Marek Safar <marek.safar@gmail.com>
4842 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4845 2008-04-21 Marek Safar <marek.safar@gmail.com>
4847 * generic.cs (TypeParameter): Removed redundant location.
4849 2008-04-19 Marek Safar <marek.safar@gmail.com>
4851 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4852 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4853 FullNamedExpression in all declaration type expression, statements will come
4856 2008-04-18 Marek Safar <marek.safar@gmail.com>
4858 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4859 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4861 2008-04-18 Marek Safar <marek.safar@gmail.com>
4863 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4866 2008-04-17 Marek Safar <marek.safar@gmail.com>
4868 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4871 2008-04-17 Marek Safar <marek.safar@gmail.com>
4873 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4877 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4879 Hook up 'EmitSideEffect'
4880 * constant.cs (Constant.EmitSideEffect): New.
4881 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4882 (SideEffectConstant.EmitSideEffect): New.
4883 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4884 unconditional branch in EmitBranchable.
4885 (FieldExpr.EmitBranchable): New.
4886 * expression.cs (Unary.EmitSideEffect): New.
4887 (Binary.EmitSideEffect): New.
4888 (VariableReference.EmitSideEffect): New. Do nothing.
4890 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4892 Introduce 'EmitSideEffect'
4893 * ecore.cs (Expression.EmitSideEffect): New.
4894 (TypeCast): Rename from EmptyCast.
4896 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4897 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4898 * convert.cs, nullable.cs: Update to changes.
4900 2008-04-16 Marek Safar <marek.safar@gmail.com>
4902 * class.cs, cs-parser.jay: Early check for base types expression.
4904 2008-04-16 Marek Safar <marek.safar@gmail.com>
4906 * decl.cs (MemberName): Declare PrettyName as obsolete.
4908 2008-04-16 Marek Safar <marek.safar@gmail.com>
4910 * namespace.cs: Use MemberName comparison.
4912 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4915 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4917 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4918 (MemberName.FullyQualifiedName): New. Provides the functionality
4919 that users assume FullName would have.
4920 * ecore.cs, namespace.cs: Update to changes.
4922 * statement.cs (Using.assign): Make into ExpressionStatement.
4923 (Using.EmitPreTryBody): Simplify.
4925 2008-04-16 Marek Safar <marek.safar@gmail.com>
4927 * report.cs: ColorFormat is protected.
4929 * rootcontext.cs: Unused fields clean-up.
4931 * namespace.cs: Made UsingEntry name private.
4933 2008-04-16 Marek Safar <marek.safar@gmail.com>
4935 * cs-tokenizer.cs, location.cs: Removed unused field.
4937 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4938 Raja R Harinath <harinath@hurrynot.org>
4941 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4942 (SideEffectConstant.side_effect): Rename from 'right'.
4943 (SideEffectConstant..ctor): Normalize 'side_effect'.
4944 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4945 value of this constant.
4946 * cfold.cs: Update to changes.
4948 2008-04-15 Marek Safar <marek.safar@gmail.com>
4950 * cs-paser.jay: Removed unused variable.
4952 * driver.cs: Made Compile instance method.
4954 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4956 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4958 2008-04-15 Marek Safar <marek.safar@gmail.com>
4960 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4962 2008-04-13 Jb Evain <jbevain@novell.com>
4964 * namespace.cs: update the System.Core fullname for 2.1
4965 * driver.cs: update the list of required assemblies for 2.1.
4966 Merged from the Moonlight 2 branch.
4968 2008-04-11 Marek Safar <marek.safar@gmail.com>
4970 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4971 types and user defined operators. User operators arguments has to be checked
4972 for null value before invocation, which also means no operator is called
4973 when any argument is not convertible to unwrapped nullable type.
4975 2008-04-09 Marek Safar <marek.safar@gmail.com>
4977 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4978 of Unary expressions to follow operator overloading rules precisely.
4979 Also fixes #321794, #323794
4981 2008-04-08 Marek Safar <marek.safar@gmail.com>
4983 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4986 2008-04-08 Marek Safar <marek.safar@gmail.com>
4988 * expression.cs, ecore.cs: Implemented MemberInit expression.
4990 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4992 Fix mono/tests/exception4.cs
4993 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4994 ec.NeedReturnLabel () rather emitting a 'nop'.
4996 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4998 (TryCatch.SomeCodeFollows): Likewise.
4999 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
5000 for 'break', 'continue' and 'return' statements inside a try.
5001 We're fairly sure that the generated IL stream will have more
5002 instructions textually following the try.
5003 (FlowBranchingTryCatch): Likewise.
5005 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
5006 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
5009 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
5010 wrapper -- forward everything to CollectionForeach.
5011 (CollectionForeach.NonDisposableWrapper): New.
5012 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
5013 instead of a pop + branch to end.
5015 2008-04-07 Marek Safar <marek.safar@gmail.com>
5017 A fix for bug #377485
5018 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
5019 Propagate location for extension method groups. Report conversion failure at
5022 2008-04-07 Marek Safar <marek.safar@gmail.com>
5024 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
5025 ListInit and Field expressions.
5027 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
5029 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
5030 Since $PC is always -1 inside the body of MoveNext, the fault
5032 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
5033 * statement.cs (ExceptionStatement.emit_finally): Likewise.
5034 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
5036 The denouement! Fix #324708
5037 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
5038 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
5039 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
5040 'finally' inside the finally clause.
5042 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
5043 inside an iterator. Don't emit the body of the 'finally' inside
5044 the finally clause yet.
5046 Use the ResumableStatement infrastructure for MoveNext ()
5047 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
5048 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
5049 'old_resume_points'. Move dispatcher upfront.
5050 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
5051 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
5052 in an enumerator. This encodes the main fix in this patch series
5053 -- we can only jump into the first instruction of a try from the
5054 outside, but we want to emit try/finally regions in iterators and
5055 resume in the middle of them.
5057 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
5059 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
5060 of NeedReturnLabel here.
5062 Introduce a common point for emitting try/finally to IL
5063 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
5064 features of the various subclasses, which are now driven by ...
5065 (ExceptionStatement.EmitPreTryBody): ... this and ...
5066 (ExceptionStatement.EmitTryBody): ... this and the original
5068 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
5069 Remove DoEmit and update to follow above protocol.
5071 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
5072 of the dispatcher are the same, skip emitting the 'switch'.
5073 * iterator.cs (Iterator.EmitDispose): Update to changes.
5075 Clean up handling of 'using' statement
5076 * statement.cs (UsingTemporary): New. Carved out of ...
5077 (Using): ... this. Simplify drastically. Handle exactly
5079 * cs-parser.jay (using_statement): Split. Create UsingTemporary
5080 or Using as appropriate. If there are multiple variable declared,
5081 create nested Using statements.
5082 (resource_acquisition): Kill.
5084 * statement.cs (ExceptionStatement.EmitForDispose): Use
5085 EmitFinallyBody, not EmitFinally.
5087 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
5088 * iterator.cs: Update to changes.
5090 Start using the ResumableStatement infrastructure
5091 * statement.cs (ResumeableStatement.PrepareForDispose): New.
5092 (ResumableStatement.EmitForDispose): New.
5093 (ExceptionStatement): Override them.
5094 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
5095 EmitForDispose to create the body of the Dispose method. Don't
5098 * iterator.cs (Iterator.AddResumePoint): Move here from ...
5099 * statement.cs (Toplevel.AddResumePoint): ... here.
5100 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
5101 * flowanalysis.cs (FlowBranchingIterator): New.
5102 * codegen.cs (EmitContext): Update to changes.
5104 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
5105 (Iterator.old_resume_points): Rename from 'resume_points'.
5106 (Iterator.MoveNextStatement): Remove unused class.
5108 New infrastructure for try/finally in iterators (still unused)
5109 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
5110 (FlowBranchingToplevel.AddResumePoint): Hook into
5111 ToplevelBlock.AddResumePoint.
5112 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
5113 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
5114 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
5115 resume points and assign program-counter values.
5116 (ExceptionBlock.AddResumePoint): Collect resume points for
5117 de-muxer at the top of try block.
5118 * iterators.cs (Yield.CheckContext): Simplify.
5119 (Yield.Resolve): Use FlowBranching.AddResumePoint.
5121 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
5123 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
5124 argument to an ExitStatement.
5125 (FlowBranchingException): Refactor saved origins code.
5126 * statement.cs (ExitStatement): Update to cahges.
5127 * iterator.cs (YieldBreak): Likewise.
5129 * statement.cs (ResumableStatement): New. Common base class for
5130 YieldReturn and ExceptionStatement.
5131 (ExitStatement): New. Common base class for Return and YieldBreak.
5132 (Return): Update to changes.
5133 * iterator.cs (YieldBreak): Likewise.
5134 * lambda.cs (ContextualReturn): Likewise.
5137 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
5138 emit a meaningful error message.
5140 Fix #324765, #319508
5141 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
5142 (VariableInfo.SetAssigned): Set it.
5143 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
5144 determine if CS0219 or CS0168 is appropriate. Don't use
5145 flow-analysis information.
5146 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
5147 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
5148 (EmitContext.EndFlowBranching): ... this.
5150 2008-04-03 Marek Safar <marek.safar@gmail.com>
5152 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
5154 2008-04-03 Marek Safar <marek.safar@gmail.com>
5156 A fix for bug #376508
5157 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
5158 ImplicitConversionExists.
5160 2008-04-03 Marek Safar <marek.safar@gmail.com>
5162 * expression.cs (Binary): Added remaining binary operators to expression
5165 * nullable.cs: Optimize shift with null argument.
5167 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
5169 Fix minor IL regression
5170 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
5171 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
5172 * cs-parser.jay (try_statement): Update to changes.
5174 * statement.cs (TryFinally.need_exc_block): Delete.
5175 (TryFinally): Update to changes.
5177 Now all ExceptionStatements are unconditional
5178 * statement.cs (CollectionForeach.DisposableWrapper): New.
5179 Extract out the try/finally code into a new wrapper.
5180 (CollectionForeach.Resolve): Use it to simplify the code.
5182 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
5184 Start at simplifying ExceptionStatement semantics a bit
5185 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
5186 * cs-parser.jay (try_statement): Update to changes.
5187 (opt_catch_clauses): Remove.
5188 * flowanalysis.cs: Update to changes.
5189 (FlowBranching.BranchingType.TryCatch): New.
5190 (FlowBranchingTryCatch): New.
5192 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
5193 (FlowBranching.CreateBranching): Update to changes.
5194 (FlowBranchingBlock.AddSibling): Add sanity check.
5195 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
5198 * iterators.cs (Iterator.MarkFinally): Remove.
5199 * statement.cs (ExceptionStatement): Update to changes.
5201 Add support for skipping over finally blocks at runtime. First
5202 in a series to fix #324708
5203 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
5204 (Iterator.EmitMoveNext): Initialize it.
5205 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
5206 branch over the body of the 'finally' clause.
5208 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
5210 Avoid lopsided use of Foo/DoFoo names
5211 * statement.cs (ExpressionStatement.EmitFinallyBody):
5212 Rename from EmitFinally.
5213 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
5214 * iterator.cs: Update to changes.
5216 2008-04-02 Marek Safar <marek.safar@gmail.com>
5218 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
5219 based on UserOperatorCall. More binary nullable operators clean up.
5221 2008-04-02 Martin Baulig <martin@ximian.com>
5223 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
5225 2008-04-02 Marek Safar <marek.safar@gmail.com>
5227 * nullable.cs: Merge user and empty conversions when lifting expression
5230 * expression.cs (StringConcat): Implemented expression tree representation.
5232 2008-04-01 Marek Safar <marek.safar@gmail.com>
5234 * nullable.cs: When lifting null literal and a user operator exists, no call
5237 2008-04-01 Marek Safar <marek.safar@gmail.com>
5239 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
5242 2008-04-01 Marek Safar <marek.safar@gmail.com>
5244 * nullable.cs, expression.cs: Use namespace instead heavily nested
5245 monster abstract class.
5247 2008-04-01 Marek Safar <marek.safar@gmail.com>
5249 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
5250 lifting of null literal and user operators. Clean up of some temporary
5253 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
5255 Fix #368224, test-629.cs
5256 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
5257 if it crossed an unwind-protect boundary.
5258 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
5259 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
5260 inside an unwind-protected region.
5261 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
5262 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
5263 'leave' instead of a 'br' if unwind-protected.
5264 (Iterator.EmitYieldBreak): Likewise.
5266 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
5268 * driver.cs: Only define versioninfo resources if no win32 resource
5271 2008-03-28 Marek Safar <marek.safar@gmail.com>
5273 A fix for bug #372375
5274 * convert.cs: Fixed boxing of nullable types.
5276 2008-03-28 Marek Safar <marek.safar@gmail.com>
5278 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
5281 2008-03-28 Marek Safar <marek.safar@gmail.com>
5283 A fix for bug #374619
5284 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
5286 2008-03-27 Marek Safar <marek.safar@gmail.com>
5288 * lambda.cs: Check return type only for invocation.
5290 2008-03-27 Marek Safar <marek.safar@gmail.com>
5292 A fix for bug #374214
5293 * ecore.cs: Correctly report argument type mismatch.
5295 2008-03-27 Marek Safar <marek.safar@gmail.com>
5297 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
5298 and not rely on broken IsEnum.
5300 2008-03-27 Marek Safar <marek.safar@gmail.com>
5302 * nullable.cs: New file, extracted from generic.cs.
5304 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
5306 2008-03-27 Marek Safar <marek.safar@gmail.com>
5308 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
5309 predefined comparison operators and null literals.
5311 * report.cs: New warning ID.
5313 2008-03-25 Marek Safar <marek.safar@gmail.com>
5315 A fix for bug #370577
5316 * lambda.cs: Check return type too.
5318 2008-03-25 Marek Safar <marek.safar@gmail.com>
5320 A fix for bug #372846
5321 * class.cs: Automatic properties can be declared as unsafe.
5323 2008-03-20 Marek Safar <marek.safar@gmail.com>
5325 * location.cs: Use string based concatenation.
5327 * expression.cs: LiftedBinaryOperator is gmcs only.
5329 2008-03-20 Marek Safar <marek.safar@gmail.com>
5331 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
5332 conversions rules and expression trees.
5334 2008-03-19 Marek Safar <marek.safar@gmail.com>
5336 * delegate.cs: Use extension method source as delegate target.
5338 2008-03-19 Marek Safar <marek.safar@gmail.com>
5340 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
5341 binary operations to be purely based on binary operations and optimized
5342 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
5343 and other ET refactoring.
5345 * typemanager.cs: Fixed warning.
5347 2008-03-17 Marek Safar <marek.safar@gmail.com>
5349 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
5351 * symbolwriter.cs: Fixed.
5353 2008-03-17 Marek Safar <marek.safar@gmail.com>
5355 * anonymous.cs, driver.cs: Reset anonymous types counters.
5357 2008-03-17 Marek Safar <marek.safar@gmail.com>
5359 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
5361 * class.cs: Use fullname for all type member definitions.
5363 2008-02-19 Martin Baulig <martin@ximian.com>
5366 (IMethodData.EmitExtraSymbolInfo): New interface method.
5367 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5368 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5369 interface method here as an empty public virtual method.
5372 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5373 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5374 CodeGen.SymbolWriter.SetRealMethodName().
5376 2008-02-18 Martin Baulig <martin@ximian.com>
5379 (ScopeInfo.EmitType): Override this and emit debugging
5380 information for captured variables.
5381 (RootScopeInfo.EmitType): Override this and emit symbol
5382 information for a captured `this'.
5384 2008-02-15 Martin Baulig <martin@ximian.com>
5386 * iterators.cs: Emit debugging info.
5389 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5390 (EmitContext.OmitDebuggingInfo): New public property.
5393 (While): Override Emit() and don't emit symbol info there; do it
5394 inside DoEmit() instead.
5395 (Block.Emit): Omit symbol information while emitting the scope
5396 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5398 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5399 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5400 .ctor to make `IsIterator' work.
5402 2008-03-14 Martin Baulig <martin@ximian.com>
5404 * symbolwriter.cs: Added the new symbol writer function from the
5405 debugger's `terrania' branch; temporarily enclose them inside
5406 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5409 2008-03-14 Martin Baulig <martin@ximian.com>
5412 (SymbolWriter): Make this a public static class.
5415 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5416 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5418 2008-03-14 Marek Safar <marek.safar@gmail.com>
5420 A fix for bug #370577
5421 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5424 2008-03-14 Marek Safar <marek.safar@gmail.com>
5426 * typemanager.cs (CSharpName): Made 250 times faster.
5428 2008-03-13 Marek Safar <marek.safar@gmail.com>
5430 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5432 2008-03-12 Marek Safar <marek.safar@gmail.com>
5434 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5435 crash when predefined field does not exist.
5437 2008-03-12 Marek Safar <marek.safar@gmail.com>
5439 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5441 2008-03-12 Marek Safar <marek.safar@gmail.com>
5443 * class.cs (FixedField): Don't crash when contructors are missing.
5445 2008-03-11 Marek Safar <marek.safar@gmail.com>
5447 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5448 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5449 check internal types accessibility for internal and external types.
5450 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5452 2008-03-11 Marek Safar <marek.safar@gmail.com>
5454 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5455 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5456 attribute.cs, statement: Use corect instance of predefined types (work
5457 related to #364674).
5459 2008-03-07 Marek Safar <marek.safar@gmail.com>
5461 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5463 2008-03-07 Marek Safar <marek.safar@gmail.com>
5465 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5466 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5467 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5468 predefined types clean up, delayed predefined types members initialization
5469 (work related to #364674).
5471 2008-03-05 Marek Safar <marek.safar@gmail.com>
5473 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5475 2008-03-05 Marek Safar <marek.safar@gmail.com>
5477 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5478 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5479 predefined types clean up (work related to #364674).
5481 2008-03-04 Marek Safar <marek.safar@gmail.com>
5483 * ecore.cs: Print an error message instead of throwing exception.
5485 2008-03-04 Marek Safar <marek.safar@gmail.com>
5487 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5488 expression.cs, statement.cs: Unififed null literal representation.
5490 2008-03-03 Marek Safar <marek.safar@gmail.com>
5492 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5493 expression.cs: Refactored binary operators resolve phase and improved speed.
5494 The nullable code is still missing and won't work correctly, more fixes
5497 It also fixes #323726, #324312, #324248, and many other unreported issues.
5499 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5501 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5504 2008-02-27 Marek Safar <marek.safar@gmail.com>
5506 * ecore.cs: Clean-up and split BetterConversion.
5508 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5511 * enum.cs (EnumMember.Value): Only access 'value' if
5512 ResolveValue says it's ok.
5513 (EnumMember.DoResolveValue): Don't set prev_member.value.
5514 (Enum.GetDefinition): Reverse arguments of Equals --
5515 EnumMember.Value can return 'null'.
5517 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5519 2008-02-22 Marek Safar <marek.safar@gmail.com>
5521 * generic.cs, expression.cs: More ongoing work on expression trees.
5523 2008-02-21 Marek Safar <marek.safar@gmail.com>
5525 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5526 handle missing matches when mutiple operators exist.
5528 2008-02-20 Marek Safar <marek.safar@gmail.com>
5530 A fix for bug #363218
5531 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5534 2008-02-20 Marek Safar <marek.safar@gmail.com>
5536 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5537 update. This time to deal correctly with SideEffectConstant expression used
5538 as an argument for another constant folding.
5540 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5542 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5545 2008-02-19 Marek Safar <marek.safar@gmail.com>
5547 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5549 2008-02-19 Marek Safar <marek.safar@gmail.com>
5551 A fix for bug #328136
5552 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5553 side is a false constant, because we still need to evaluate the right-hand
5556 * statement.cs (If): Emit two types of boolean constants (simple constant,
5557 side-effect constant).
5559 2008-02-19 Marek Safar <marek.safar@gmail.com>
5561 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5563 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5566 2008-02-18 Marek Safar <marek.safar@gmail.com>
5568 A fix for bug #361457
5569 * ecore.cs (IsApplicable): Params methods have lower priority.
5571 * support.cs: Return correct parameter modifier for params types.
5573 2008-02-18 Marek Safar <marek.safar@gmail.com>
5575 * generic.cs (TypeParameter): Cache attribute target name.
5577 * support.cs: Removed unused variable.
5579 * typemanager.cs: Removed debugging leftover.
5581 * ecore.cs: Use local type instead of a property;
5583 * class.cs (VerifyMembers): Consider also parent to test whether type member
5586 * expression.cs (FullMethodDesc): Removed.
5588 * attribute.cs (IsValidArgumentType): Made static.
5590 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5592 Cleanup to be more readable.
5593 * Makefile (GMCS_PROFILE): Remove.
5594 (COMPILER_NAME): New helper.
5596 2008-02-15 Miguel de Icaza <miguel@novell.com>
5598 * cs-tokenizer.cs: if a conditional expression happens inside a
5599 (...) this also means that we do not need to de-ambiguate between
5600 an parenthesized expression and a cast.
5604 * constant.cs (SideEffectConstant): a constant value that happens
5605 to have a side effect.
5607 Fixes the build regressions introduced by the fix for #359789
5609 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5611 * expression.cs (Conditional.Emit): when emitting the ternary
5612 operator, use local variables to generate code verifiable code.
5614 The verifier cannot infer that the type on stack before the
5615 stloc.0 is executed is of type ParentB. This happens because the
5616 stack merge algorithm uses only parent types when deciding which
5617 is the common type. This is described in Part III 1.8.1.3 of ECMA
5620 This code compiled with mcs is not verifiable under MS. The MS
5621 verifier picks the first common interface of Foo and Bar, which is
5622 wrong, but doesn't use a full join type of the 2 interfaces.
5624 CSC uses a clever hack to compile such code in a verifiable
5625 way. It stores the intermediate values in a local variable with
5630 2008-02-14 Miguel de Icaza <miguel@novell.com>
5632 * expression.cs: Do not fold BitwiseAnd operators when the left
5633 side is a false constant, because we still need to evaluate the
5638 * support.cs: Instead of throwing an InternalErrorException when
5639 the position of the stream is outside the boundary of our buffer,
5640 reset the state of the reader, and restart the reading from the
5641 beginning of the file.
5643 2008-02-14 Marek Safar <marek.safar@gmail.com>
5645 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5647 2008-02-14 Marek Safar <marek.safar@gmail.com>
5649 A fix for bug #361686
5650 * decl.cs: A protected types used inside a private class which parents
5651 derives from the protected class are accessible.
5653 2008-02-13 Marek Safar <marek.safar@gmail.com>
5655 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5656 the parameterless constructor.
5658 2008-02-13 Marek Safar <marek.safar@gmail.com>
5660 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5661 lookup methods to use standard member cache when doing member lookup.
5663 2008-02-12 Marek Safar <marek.safar@gmail.com>
5665 * driver.cs: Don't report full path for referenced module as assembly error.
5667 2008-02-12 Marek Safar <marek.safar@gmail.com>
5669 * Makefile: Fixed `qh' target to work on all machines.
5671 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5672 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5673 and HasElementType with TypeManager implementation.
5675 2008-02-08 Marek Safar <marek.safar@gmail.com>
5677 A fix for bugs #325134, #359749
5678 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5679 first binds point to non-method member expression.
5681 2008-02-08 Marek Safar <marek.safar@gmail.com>
5683 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5685 2008-02-08 Marek Safar <marek.safar@gmail.com>
5687 A fix for bugs #321394, #323028
5688 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5689 Reworked naive IsAccessibleAs implementation to handle nested types.
5691 2008-02-05 Jb Evain <jbevain@novell.com>
5693 * class.cs: use generic type comparison for parameters
5696 2008-02-05 Marek Safar <marek.safar@gmail.com>
5698 A fix for bug #325372
5699 * class.cs: Use generic type comparison when testing method signatures.
5701 2008-02-05 Marek Safar <marek.safar@gmail.com>
5703 A fix for bug #357047
5704 * ecore.cs: Applied C# 3.0 changes to better conversion.
5706 2008-02-05 Marek Safar <marek.safar@gmail.com>
5708 A fix for bug #358374
5709 * cs-parser.jay: Correctly set modifiers for all constructor types.
5711 2008-02-04 Marek Safar <marek.safar@gmail.com>
5713 A fix for bug #355251
5714 * generic.cs: Added base class constraint based type inference.
5716 2008-02-01 Marek Safar <marek.safar@gmail.com>
5718 A fix for bug #357255
5719 * decl.cs: One more missing visibility check.
5721 2008-02-01 Marek Safar <marek.safar@gmail.com>
5723 * support.cs: Fixed broken return.
5725 2008-01-25 Marek Safar <marek.safar@gmail.com>
5727 * report.cs: Correctly reset warnings count after probing.
5729 2008-01-25 Martin Baulig <martin@ximian.com>
5732 (NamespaceEntry.SymbolFileID): Make this work again after
5733 MemberName.ToString() is gone.
5735 2008-01-25 Marek Safar <marek.safar@gmail.com>
5737 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5740 2008-01-25 Marek Safar <marek.safar@gmail.com>
5742 * generic.cs: Use full implicit conversion for type inference fixing.
5744 2008-01-24 Marek Safar <marek.safar@gmail.com>
5746 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5747 Fixed user operator conversions.
5749 2008-01-24 Marek Safar <marek.safar@gmail.com>
5751 * generic.cs: Do nullable type to null comparison optimization during
5754 2008-01-24 Marek Safar <marek.safar@gmail.com>
5756 A fix for bug #355163
5757 * generic.cs: Enabled l-value resolve on nullable expressions.
5759 2008-01-24 Marek Safar <marek.safar@gmail.com>
5761 A fix for bug #353986
5762 * class.cs: Ingore static ctors with parameters for any further checks.
5764 2008-01-24 Marek Safar <marek.safar@gmail.com>
5766 A fix for bug #354310
5767 * namespace.cs: Removed redundant check.
5769 2008-01-24 Marek Safar <marek.safar@gmail.com>
5771 A fix for bug #354928
5772 * expression.cs: ElementInitializers can be resolved only once.
5774 2008-01-24 Marek Safar <marek.safar@gmail.com>
5776 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5777 Condition expressions.
5779 2008-01-23 Marek Safar <marek.safar@gmail.com>
5781 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5783 2008-01-22 Marek Safar <marek.safar@gmail.com>
5785 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5788 * generic.cs: Implemented coalesce expression.
5790 2008-01-22 Marek Safar <marek.safar@gmail.com>
5792 A fix for bug #355145
5793 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5794 expression tree type inference.
5796 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5799 * expression.cs (Binary.IsUnsignedType): Fix typo.
5801 2008-01-22 Marek Safar <marek.safar@gmail.com>
5803 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5805 2008-01-22 Marek Safar <marek.safar@gmail.com>
5807 A fix for bug #355161
5808 * ecore.cs, expression.cs: Wider range of extension method supported
5811 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5813 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5814 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5817 2008-01-22 Marek Safar <marek.safar@gmail.com>
5819 A fix for bug #355148
5820 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5822 2008-01-22 Miguel de Icaza <miguel@novell.com>
5824 * expression.cs (CreateExpressionTree): Add support for or and
5825 logical or, and indent following the coding conventions.
5827 * typemanager.cs (LinqExpression): renamed from
5828 ExpressionTreeManager, for a shorter name.
5830 Use TypeManager.CoreLookupType to lookup types from our core
5831 assemblies and turn those into "Type" variables.
5833 Consumers that previously used "Namespace" and "Type" from this
5834 class should instead use the TypeExpression which is a type that
5835 is fully resolved (without involving the regular C# resolution
5838 This typically looks like this:
5840 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5841 new MemberAccess (texpr, name, type_arguments, loc)
5843 This avoids the problem in: #355178
5845 2008-01-21 Marek Safar <marek.safar@gmail.com>
5847 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5848 feature in parser only as we do in other cases.
5850 2008-01-21 Marek Safar <marek.safar@gmail.com>
5852 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5853 typemanager.cs: A refactoring of params arguments to reuse existing
5854 expressions (params -> array initializer) to emit params argument instead
5855 of specialized handling.
5856 It was required by expression tree implementation and it has other benefits
5857 as well, we now apply same optimization for params arguments as we do for
5860 2008-01-18 Marek Safar <marek.safar@gmail.com>
5862 A fix for bug #353526
5863 * generic.cs: A type inference of params arguments may not required any
5864 temporary array creation.
5866 2008-01-18 Marek Safar <marek.safar@gmail.com>
5868 A fix for bug #353534
5869 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5870 supported for delegates only.
5872 2008-01-18 Marek Safar <marek.safar@gmail.com>
5874 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5875 type for more than 1 candidates.
5877 2008-01-18 Marek Safar <marek.safar@gmail.com>
5879 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5882 2008-01-16 Marek Safar <marek.safar@gmail.com>
5884 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5885 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5886 operator) expressions.
5888 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5890 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5891 not accessed from the generated IL.
5893 2008-01-14 Marek Safar <marek.safar@gmail.com>
5895 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5896 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5897 statement.cs: The first expression tree implementation drop, mostly
5898 infrastructure work.
5900 2008-01-14 Marek Safar <marek.safar@gmail.com>
5902 * ecore.cs (IsNestedChild): Refactored.
5904 2008-01-11 Marek Safar <marek.safar@gmail.com>
5906 * lambda.cs: Don't use a cast on unknown expression statement.
5908 2008-01-10 Geoff Norton <gnorton@novell.com>
5910 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5913 2008-01-09 Marek Safar <marek.safar@gmail.com>
5915 * doc.cs: Report better /doc crash details.
5917 2008-01-09 Marek Safar <marek.safar@gmail.com>
5919 A fix for bug #352536
5920 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5922 2008-01-08 Marek Safar <marek.safar@gmail.com>
5924 A fix for bug #352287
5925 * ecore.cs, expression.cs: Do `this' access checking in all member access
5928 2008-01-08 Marek Safar <marek.safar@gmail.com>
5930 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5932 * report.cs: Reset message stacks.
5934 2008-01-08 Marek Safar <marek.safar@gmail.com>
5936 * generic.cs (InferInPhases): Correctly calculate params position.
5938 2008-01-08 Marek Safar <marek.safar@gmail.com>
5940 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5943 2008-01-07 Marek Safar <marek.safar@gmail.com>
5945 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5947 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5949 * driver.cs: Updated --help option.
5951 2008-01-07 Marek Safar <marek.safar@gmail.com>
5953 * generic.cs (InferParamsTypeArguments): Removed.
5954 (InferInPhases): Add params type inference.
5955 (LowerBoundInference): Fixed scoring mechanism.
5957 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5959 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5961 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5962 byte array for unsigned "baked" assemblies.
5964 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5966 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5967 array for assemblies that are not strongnamed.
5969 2008-01-04 Marek Safar <marek.safar@gmail.com>
5971 A fix for bug #351481
5972 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5973 declaring type for nested generic types.
5975 2008-01-04 Marek Safar <marek.safar@gmail.com>
5977 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5978 instead of ToString.
5980 2008-01-03 Marek Safar <marek.safar@gmail.com>
5982 A fix for bug #351047
5983 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5984 null and structs only when equality and inequality operators are defined
5985 either as an user-operators or predefined operators.
5987 2008-01-03 Marek Safar <marek.safar@gmail.com>
5989 A fix for bug #351047
5990 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5992 2008-01-03 Marek Safar <marek.safar@gmail.com>
5994 A fix for bug #351257
5995 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5997 2008-01-03 Marek Safar <marek.safar@gmail.com>
5999 A fix for bug #351157
6000 * class.cs (Using): Fixed yet another broken cloning.
6002 (Block): Put back more sensible default value for statements.
6004 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
6006 * codegen.cs: Allow AssemblyVersion with only major version component.
6009 2007-12-29 Marek Safar <marek.safar@gmail.com>
6011 A fix for bug #324654
6012 * class.cs: Use FullName property as member name.
6014 2007-12-28 Marek Safar <marek.safar@gmail.com>
6016 A fix for bug #342117
6017 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
6018 constructor constraint.
6020 2007-12-28 Marek Safar <marek.safar@gmail.com>
6022 A fix for bug #338273
6023 * class.cs (ProbertyBase): Access modifier checks are required for overrides
6026 2007-12-28 Marek Safar <marek.safar@gmail.com>
6028 A fix for bug #350839
6029 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
6031 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6033 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6036 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6038 * statement.cs: Changed some Hashtables to use HybridDictionaries
6039 instead. It was observed that some HashTables only contained a few
6040 items in the vast majority of cases. Since HybridDictionary is
6041 more efficient on small sets (<10 elements), "known_variables"
6042 from class ExplicitBlock as well as "labels" and "constants " from
6043 class Block were changed to HybridDictionaries.
6045 Atsai results: (56216kb->54987kb)
6047 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
6050 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
6052 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
6055 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
6057 * expression.cs: foreach loop to for loop, saved on allocation of
6058 enumerator (59333kb->59141kb)
6060 * statement.cs. Changed foreach loops to for loops, saved on
6061 allocation of enumerator (59141kb->59006kb)
6063 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
6064 when constructed with no specified capacity. This was causing a
6065 few ArrayLists to allocate more memory than they would potentially
6066 need in the Block class and MemberCache class. Setting the
6067 ArrayLists to construct with a capacity of 1 saves some
6068 memory. (56216kb->55585kb)
6070 2007-12-27 Marek Safar <marek.safar@gmail.com>
6072 A fix for bug #347189 (2nd issue)
6073 * expression.cs (MemberAccess): Nested type can be found in base non-generic
6076 2007-12-27 Miguel de Icaza <miguel@novell.com>
6078 * report.cs: Do not use colors if stdout and stderr are not a
6081 2007-12-27 Marek Safar <marek.safar@gmail.com>
6083 A fix for bug #346998
6084 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
6087 2007-12-27 Marek Safar <marek.safar@gmail.com>
6089 A fix for bug #343465
6090 * class.cs: Explicit method name for nested types uses dots only.
6092 2007-12-27 Marek Safar <marek.safar@gmail.com>
6094 A fix for bug #343707
6095 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
6097 2007-12-27 Marek Safar <marek.safar@gmail.com>
6099 * ecore.cs: Report type inference errors only when arguments count matches
6102 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
6104 * expression.cs, report.cs: New warning.
6106 * typemanager.cs: Catch anonymous method type too.
6108 2007-12-23 Marek Safar <marek.safar@gmail.com>
6110 A fix for bug #346379
6111 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
6113 2007-12-23 Marek Safar <marek.safar@gmail.com>
6115 A fix for bug #347359
6116 * expression.cs (Invocation): Don't resolve already resolved expression.
6118 2007-12-23 Marek Safar <marek.safar@gmail.com>
6120 A fix for bug #347189
6121 * class.cs (FixedField): Use non-dependent code only in the define phase.
6123 2007-12-23 Marek Safar <marek.safar@gmail.com>
6125 A fix for bug #348076
6126 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
6128 2007-12-22 Marek Safar <marek.safar@gmail.com>
6130 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
6131 discovered extension methods.
6133 2007-12-22 Marek Safar <marek.safar@gmail.com>
6135 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
6138 2007-12-21 Miguel de Icaza <miguel@novell.com>
6140 * report.cs (ErrorMessage): Add support for using colors on
6141 terminals that support it.
6143 2007-12-21 Marek Safar <marek.safar@gmail.com>
6145 * ecore.cs: Use information about expanded params for error reporting.
6147 2007-12-21 Marek Safar <marek.safar@gmail.com>
6149 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
6150 and logic for params overloads.
6152 2007-12-15 Miguel de Icaza <miguel@novell.com>
6154 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
6155 as this is also created from the parser. Fixes #349034
6157 2007-12-12 Miguel de Icaza <miguel@novell.com>
6159 * statement.cs (Throw.CloneTo): it is valid to have empty
6160 expressions for throw.
6162 2007-12-03 Marek Safar <marek.safar@gmail.com>
6164 * cs-parser.jay: Set delegate constraint parsing region correctly.
6166 2007-12-03 Marek Safar <marek.safar@gmail.com>
6168 A fix for bug #345467
6169 * typemanager.cs (IsEqual): Compare generic parameters position only.
6171 2007-11-28 Marek Safar <marek.safar@gmail.com>
6173 * expression.cs (BaseAccess): Type arguments can be null.
6175 2007-11-27 Raja R Harinath <harinath@gmail.com>
6177 * statement.cs (Block.Resolve): Ensure flow-branching tree is
6178 consistent even when an error has occured.
6179 (Switch.Resolve): Likewise.
6181 2007-11-22 Marek Safar <marek.safar@gmail.com>
6183 A fix for bug #334505
6184 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
6187 2007-11-22 Marek Safar <marek.safar@gmail.com>
6189 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
6190 refactorings required to resolve extension methods correctly when mixing
6191 generics and non-generics members.
6193 2007-11-20 Marek Safar <marek.safar@gmail.com>
6195 A fix for bug #342584
6196 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
6199 2007-11-19 Marek Safar <marek.safar@gmail.com>
6201 A fix for bug #342512
6202 * delegate.cs: Use delegate argument expression when is available. Don't
6203 emit virtual call when class is sealed.
6205 2007-11-16 Marek Safar <marek.safar@gmail.com>
6207 A fix for bug #325423
6208 * assign.cs (FieldInitializer): Use resolved expression for emit.
6210 * class.cs: Print less confusing error message.
6212 2007-11-16 Marek Safar <marek.safar@gmail.com>
6214 * cs-tokenizer.cs: Removed GMCS ifdefs.
6216 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
6219 * cs-parser.jay: Disabled nullable check.
6221 * generic-mcs: Copied more generic stuff.
6223 2007-11-16 Marek Safar <marek.safar@gmail.com>
6225 * gcs-parser.jay: Merged to cs-parser.jay.
6227 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
6228 * *.csproj, *.sources: Updated to use only jay parser file.
6230 2007-11-16 Marek Safar <marek.safar@gmail.com>
6232 * gcs-parser.jay: Added nullable and default expression feature checks.
6234 2007-11-16 Marek Safar <marek.safar@gmail.com>
6236 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
6237 it fixes many TODOs and hidden bugs.
6239 * expression: Removed duplicate error check.
6241 2007-11-15 Marek Safar <marek.safar@gmail.com>
6243 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
6244 implicitly type local variable only when it is used in a declaration.
6246 2007-11-15 Marek Safar <marek.safar@gmail.com>
6248 * attribute.cs: Use CS0612 for empty strings.
6250 2007-11-14 Marek Safar <marek.safar@gmail.com>
6252 * lambda.cs, statement.cs: Contextual return may act as a statement.
6254 2007-11-14 Marek Safar <marek.safar@gmail.com>
6256 A fix for a regression cause by #324222
6257 * class.cs: Don't report unused even when it implements an interface.
6259 2007-11-13 Marek Safar <marek.safar@gmail.com>
6261 A fix for bug #341205
6262 * ecore.cs, expression.cs: Method group expression cannot do static
6263 method access with an instance reference check before overloading takes
6266 2007-11-13 Marek Safar <marek.safar@gmail.com>
6268 A fix for bug #325359
6269 * class.cs: Use predictable name for automatically generated property.
6271 2007-11-12 Marek Safar <marek.safar@gmail.com>
6273 A fix for bug #324996
6274 * expression.cs (Is): Handle case where D is nullable and T is not
6277 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
6279 2007-11-12 Marek Safar <marek.safar@gmail.com>
6281 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
6282 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
6283 Flush small error reporting changes.
6285 2007-11-09 Marek Safar <marek.safar@gmail.com>
6287 A fix for bug #324996
6288 * expression.cs: Rewrote Is expression implementation to work with
6289 generics, nullable types, anonymous method. A const result expression
6290 uses existing infrastructure instead of custom not fully-featured one.
6292 2007-11-08 Marek Safar <marek.safar@gmail.com>
6294 A fix for bug #340202
6295 * class.cs: Consider generics for volatile field.
6297 2007-11-08 Marek Safar <marek.safar@gmail.com>
6299 A fix for bug #335594
6300 * expression.cs: Use conversion rules when handling string addition.
6302 2007-11-07 Marek Safar <marek.safar@gmail.com>
6304 A fix for bug #336651
6305 * expression.cs: Fixed a crash when probing is on.
6307 2007-11-07 Marek Safar <marek.safar@gmail.com>
6309 A fix for bug #324242
6310 * covert.cs: Added a conversion from any nullable-type with an
6311 underlying enum-type to the type System.Enum.
6313 2007-11-07 Marek Safar <marek.safar@gmail.com>
6315 A fix for bug #324222
6316 * class.cs: Report all non-used event fields.
6318 2007-11-07 Marek Safar <marek.safar@gmail.com>
6320 A fix for bug #325161
6321 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
6322 qualifier for generic types.
6324 2007-11-07 Marek Safar <marek.safar@gmail.com>
6326 A fix for bug #322971
6327 * expression.cs, ecore.cs: Added intermediate result value check for
6330 2007-11-07 Marek Safar <marek.safar@gmail.com>
6332 A fix for bug #324754
6333 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
6334 when it was requested.
6336 2007-11-07 Marek Safar <marek.safar@gmail.com>
6338 A fix for bug #325101
6339 * expression.cs: Do type not value comparison for `is' expression.
6341 2007-11-07 Marek Safar <marek.safar@gmail.com>
6343 A fix for bug #320236
6344 * convert.cs: Don't apply user conversion on underlying target type.
6346 2007-11-06 Marek Safar <marek.safar@gmail.com>
6348 * expression.cs: Don't use unresolved expression for error reporting.
6350 2007-11-06 Marek Safar <marek.safar@gmail.com>
6352 A fix for bugs #337712, #324490
6353 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
6354 overloading resolution too.
6356 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
6357 the process consistent and more robust.
6359 * expression.cs, linq.cs, report.cs: Update.
6361 2007-11-02 Marek Safar <marek.safar@gmail.com>
6363 A fix for bug #332909
6364 * attribute.cs: Resolve attributes in correct context using error
6367 * rootcontext.cs: Define Obsolete attribute members as core members.
6369 2007-11-02 Marek Safar <marek.safar@gmail.com>
6371 * statement.cs: Removed unused methods.
6373 2007-10-31 Wade Berrier <wberrier@novell.com>
6375 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6376 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6379 2007-10-31 Marek Safar <marek.safar@gmail.com>
6381 A fix for bug #338102
6382 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6383 methods registered as non-generics.
6385 2007-10-31 Marek Safar <marek.safar@gmail.com>
6387 A fix for bugs #337712, #324490
6388 * delegate.cs: Delegate covariance and contravariance is not allowed for
6391 2007-10-31 Marek Safar <marek.safar@gmail.com>
6393 A fix for bug #337719
6394 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6397 2007-10-30 Marek Safar <marek.safar@gmail.com>
6399 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6401 2007-10-29 Marek Safar <marek.safar@gmail.com>
6403 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6406 2007-10-29 Raja R Harinath <rharinath@novell.com>
6408 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6410 2007-10-29 Marek Safar <marek.safar@gmail.com>
6412 A fix for bug #334652
6413 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6414 extension methods when we have not found the best candidate in normal
6417 2007-10-27 Marek Safar <marek.safar@gmail.com>
6419 * AssemblyInfo.cs: Keep up-to-date.
6421 2007-10-27 Marek Safar <marek.safar@gmail.com>
6423 * Makefile: Fixed generics compiler name.
6425 2007-10-27 Marek Safar <marek.safar@gmail.com>
6427 * lambda.test: removed, lambda parsing is done differently.
6429 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6431 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6433 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6435 2007-10-27 Marek Safar <marek.safar@gmail.com>
6437 * Makefile, *.sources : All C# compilers are in mcs folder.
6439 * *.cs: Use existing 2_1 define for smcs.
6441 2007-10-26 Marek Safar <marek.safar@gmail.com>
6443 A fix for bug #335847
6444 * assign.cs, expression.cs: Couple of changes to avoid creating a
6445 temporary variable for each object initializer assignment statement. It
6446 simplifies struct initialization too, otherwise two temporary variables
6448 Implemented optimization of redundant default element initializers.
6450 2007-10-25 Marek Safar <marek.safar@gmail.com>
6452 A fix for bug #336766
6453 * expression.cs (Class.CheckBase): Use generic name when method is
6456 2007-10-25 Marek Safar <marek.safar@gmail.com>
6458 A fix for bug #334737
6459 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6460 variable and not variable argument for prepared copies.
6462 2007-10-24 Marek Safar <marek.safar@gmail.com>
6464 A fix for bug #325110
6465 * class.cs, expression.cs, attribute.cs: Use open generic method when
6466 checking conditional attribute.
6468 2007-10-24 Marek Safar <marek.safar@gmail.com>
6470 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6471 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6472 FeatureIsNotAvailable.
6474 2007-10-24 Marek Safar <marek.safar@gmail.com>
6476 ** C# 3.0 Partial methods
6478 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6479 methods support. Because of member cache issue with generics only
6480 non-generics partial methods are fully supported.
6482 2007-10-23 Marek Safar <marek.safar@gmail.com>
6484 * class.cs, decl.cs: Rewrote member overloads check to cope with
6485 generics and to use member cache for member checking. It also improves
6486 performance and fixes remaining overloads issues.
6488 2007-10-20 Marek Safar <marek.safar@gmail.com>
6490 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6491 roottypes.cs, typemanager.cs:
6493 A member cache creation logic changed to add members immediately and
6494 not rely on fallback. The member cache is now only prefered way
6495 how to access and find type declaration members. It saves 5 MB of memory
6496 during MWF compilation and makes code ready for more optimizations and
6497 clean-ups, it's also a pre-requirement for partial methods.
6499 2007-10-18 Raja R Harinath <harinath@gmail.com>
6501 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6502 handling for generic parameters.
6504 2007-10-15 Marek Safar <marek.safar@gmail.com>
6506 * class.cs (FixedField): Removed redundant volatile check.
6508 2007-10-15 Marek Safar <marek.safar@gmail.com>
6510 * class.cs, decl.cs: Fixed overload members verification to do only one
6511 check per possible collision.
6513 2007-10-13 Marek Safar <marek.safar@gmail.com>
6515 A fix for bug #325478
6516 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6517 and create only one disposable flags container.
6519 2007-10-12 Marek Safar <marek.safar@gmail.com>
6521 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6522 * statement.cs (Fixed): Fixed variables cloning.
6524 2007-10-12 Marek Safar <marek.safar@gmail.com>
6526 A fix for bug #333342
6527 * class.cs (EventField): Don't mark value type event as synchronized.
6529 2007-10-12 Marek Safar <marek.safar@gmail.com>
6531 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6532 inference to identify best candidate method correctly.
6533 (ProperyExpr): A range variable is read only and cannot be modified.
6535 2007-10-11 Marek Safar <marek.safar@gmail.com>
6537 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6538 logic to identify best candidate method correctly.
6540 2007-10-11 Marek Safar <marek.safar@gmail.com>
6542 * location.cs (Equals, GetHashCode): Removed.
6544 2007-10-11 Marek Safar <marek.safar@gmail.com>
6546 * report.cs: Implemented message recorder. It is used mainly for lambda
6547 expressions to capture otherwise swallowed error messages.
6549 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6551 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6553 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6555 * expression.cs (MemberAccess): Always report lookup failure.
6557 * location.cs: Implemented Equals, GetHashCode.
6559 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6561 2007-10-10 Jb Evain <jbevain@novell.com>
6563 * codegen.cs: re-enable assembly version check.
6565 2007-10-09 Marek Safar <marek.safar@gmail.com>
6567 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6570 * namespace.cs (UsingAlias): Do correct version check.
6572 2007-10-08 Marek Safar <marek.safar@gmail.com>
6574 * expresison.cs, ecore.cs: Issue extension method error message when
6577 * rootcontext.cs: Added ISO_2 compiler mode option.
6579 2007-10-08 Marek Safar <marek.safar@gmail.com>
6581 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6584 2007-10-08 Marek Safar <marek.safar@gmail.com>
6586 * attribute.cs (GetString, GetBoolean): Work with both literal and
6589 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6590 Moved method overload specific methods to MethodGroupExpr.
6592 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6593 it should be less memory consuming.
6595 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6597 * codegen.cs: remove the assembly version check until the buildbot is
6600 2007-10-07 Jb Evain <jbevain@novell.com>
6602 * attribute.cs (Attribute.GetString): if the value
6603 expression is a StringConstant, return its string value.
6605 2007-10-07 Jb Evain <jbevain@novell.com>
6607 * typemanager.cs: add `assembly_version_attribute_type`.
6608 * codegen.cs: on attribute emission, check that the
6609 AssemblyVersionAttribute doesn't overflow.
6611 2007-10-05 Marek Safar <marek.safar@gmail.com>
6613 A fix for bug #324677
6614 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6615 parent container of a scope container with currently resolved one.
6617 2007-10-05 Marek Safar <marek.safar@gmail.com>
6619 A fix for bug #325534
6620 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6623 2007-10-05 Marek Safar <marek.safar@gmail.com>
6625 A fix for bug #327504
6626 * class.cs (Operator.Define): Refactored implicit and explicit user
6627 operator conversion rules.
6629 2007-10-05 Marek Safar <marek.safar@gmail.com>
6631 A fix for bug #327520
6632 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6634 2007-10-04 Marek Safar <marek.safar@gmail.com>
6636 A fix for bug #328022
6637 * class.cs (MethodData.Define): Use correct method to check whether
6638 a method implementents an accessor.
6640 2007-10-04 Marek Safar <marek.safar@gmail.com>
6642 A fix for bug #330069
6643 * statement.cs (Fixed.Resolve): Read the first array element only when
6644 an array is instantiated.
6646 2007-10-04 Marek Safar <marek.safar@gmail.com>
6648 * expression.cs, assign.cs, generics.cs: Print correct operator when
6649 compound assignment is used.
6651 2007-10-04 Marek Safar <marek.safar@gmail.com>
6653 A fix for bug #325841
6654 * expression.cs (ArrayAccess): Use full argument cloning only for
6655 string compound concatenation.
6657 2007-10-03 Marek Safar <marek.safar@gmail.com>
6659 A fix for bug #328774
6660 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6662 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6665 2007-10-03 Raja R Harinath <rharinath@novell.com>
6668 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6669 Event accessibility checks here. Remove some bogus code that
6670 accidently made GenericMethods work.
6671 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6673 2007-09-25 Marek Safar <marek.safar@gmail.com>
6675 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6677 * statement.cs (Block): Refactored AddVariable to allow error handling
6680 * generic.cs: New stub.
6682 2007-09-23 Marek Safar <marek.safar@gmail.com>
6684 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6687 2007-09-17 Marek Safar <marek.safar@gmail.com>
6689 * class.cs: Use partial container to record whether any partial part
6690 contains static field initializer and therefore default contructor has
6693 2007-09-14 Marek Safar <marek.safar@gmail.com>
6695 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6696 mono-list when only one of two partial parts has defined accessibility
6699 2007-09-14 Marek Safar <marek.safar@gmail.com>
6701 A fix for bug #82845
6703 * class.cs (TypeContainer): Set correct resolve context for all field
6706 2007-09-13 Marek Safar <marek.safar@gmail.com>
6708 * assign.cs: Fixed a crash when field is resolved twice with an error.
6710 * codegen.cs: Changed InFieldInitializer to be flag.
6712 * anonymous.cs, ecore.cs, expression.cs: Update after
6713 IsInFieldInitializer rename.
6715 * const.cs: Removed unused parameter.
6717 * class.cs: Changed the way how we resolve and emit field initializers.
6718 The field initilizers have to have access to contructor block to emit
6719 compiler generated code.
6721 2007-09-13 Marek Safar <marek.safar@gmail.com>
6723 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6724 generics use TypeContainer instead.
6726 2007-09-12 Marek Safar <marek.safar@gmail.com>
6728 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6730 * lambda.cs (ResolveParameters): Use more powerful
6731 InflateGenericArgument.
6733 * parameters.cs: Better exception message.
6735 2007-09-10 Marek Safar <marek.safar@gmail.com>
6737 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6738 correct expression block type.
6740 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6742 * expression.cs (Invocation): Extracted method group resolve to
6745 2007-09-07 Marek Safar <marek.safar@gmail.com>
6747 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6748 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6750 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6751 generic extension methods.
6753 2007-09-06 Marek Safar <marek.safar@gmail.com>
6755 A fix for bug #82676 (Do I get it right now?)
6756 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6757 object before a standard conversion is applied.
6759 2007-09-06 Marek Safar <marek.safar@gmail.com>
6761 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6764 2007-09-05 Marek Safar <marek.safar@gmail.com>
6766 A fix for bug #82676
6767 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6768 non-generic interface types.
6770 2007-09-05 Marek Safar <marek.safar@gmail.com>
6772 A fix for bug #82690
6773 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6775 2007-09-05 Marek Safar <marek.safar@gmail.com>
6777 A fix for bug #82571
6778 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6779 modifier for container based methods.
6781 2007-09-05 Marek Safar <marek.safar@gmail.com>
6783 A fix for bug #82676
6784 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6785 any interface-type T means to any of interface type T.
6787 2007-09-04 Marek Safar <marek.safar@gmail.com>
6789 * namespace.cs: We have 2 versions of System.Core assembly.
6791 2007-09-04 Marek Safar <marek.safar@gmail.com>
6793 A fix for bug #82652
6794 * class.cs (Class.GetClassBases): Compare types and not expressions.
6796 2007-09-04 Marek Safar <marek.safar@gmail.com>
6798 A fix for bug #82620
6799 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6800 actually never worked before.
6801 (IndexerAccess): Emit prepared arguments before they are modified.
6803 2007-09-04 Marek Safar <marek.safar@gmail.com>
6805 A fix for bug #82563
6806 * assign.cs: Revert wrong fix.
6808 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6810 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6811 Instead of ldelema/stdind we have to use temporary variables to handle
6812 cases like String.Concat (params string[]).
6814 2007-08-31 Marek Safar <marek.safar@gmail.com>
6816 * class.cs: EmitAttributes to Emit rename.
6818 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6820 (MemberCore.HasClsCompliantAttribute): Don't depend on
6821 GetClsCompliantAttributeValue execution.
6823 2007-08-31 Marek Safar <marek.safar@gmail.com>
6825 * anonymous.cs: Use shorter type prefix.
6827 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6830 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6831 variables when probing is on.
6833 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6834 unresolved variables.
6835 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6836 handle transparent identifiers.
6838 2007-08-26 Marek Safar <marek.safar@gmail.com>
6840 * attribute.cs (IsClsCompliant): Add nullable types test.
6842 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6844 * doc.cs : catch other types of exception than XmlException to
6845 report CS1570. Fixed bug #82565.
6847 2007-08-23 Marek Safar <marek.safar@gmail.com>
6849 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6850 The number of delegate parameters has to match.
6851 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6854 2007-08-21 Marek Safar <marek.safar@gmail.com>
6856 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6857 to fix problem with private arguments.
6859 2007-08-20 Marek Safar <marek.safar@gmail.com>
6861 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6863 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6865 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6866 empty. Add cloning suport.
6868 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6870 2007-08-20 Marek Safar <marek.safar@gmail.com>
6872 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6873 to create EmptyCast. It handles EmptyConstantCast specialization for
6876 2007-08-18 Marek Safar <marek.safar@gmail.com>
6878 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6879 (EmitArrayArgument): One routine for array arguments.
6880 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6882 2007-08-17 Marek Safar <marek.safar@gmail.com>
6884 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6886 2007-08-17 Marek Safar <marek.safar@gmail.com>
6888 * anonymous.cs: MemberLookupFinal update.
6890 * class.cs (ConstructorInitializer): Is expression based.
6892 * delegate.cs: MethodGroupExpr update.
6894 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6896 (Error_MemberLookupFailed): Customizable error override.
6897 (MethodGroupExpr): Keep queried type for later usage.
6898 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6901 * expression.cs: Error_MemberLookupFailed refactoring.
6902 (New.DoResolve): Resolve as much as possible.
6903 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6904 customization for invalid member types.
6906 * statement.cs: MethodGroupExpr update.
6908 2007-08-16 Marek Safar <marek.safar@gmail.com>
6910 * modifier.cs (Check): Check all modifiers and not only accessibility
6913 2007-08-16 Marek Safar <marek.safar@gmail.com>
6915 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6916 type and not an expression.
6918 2007-08-16 Marek Safar <marek.safar@gmail.com>
6920 * statement.cs (Catch.Clone): Type and variable can be null.
6922 2007-08-16 Marek Safar <marek.safar@gmail.com>
6924 A fix for bug #81979
6925 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6926 I am really not sure whether this is the best fix.
6928 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6931 2007-08-14 Marek Safar <marek.safar@gmail.com>
6933 ** C# 3.0 Object and collection initializers (major re-write)
6935 * assign.cs (DoResolve): Initializers are not assign related.
6937 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6938 used during collection or object initialization.
6940 * expression.cs (Error_InvalidArguments): Add initializers specific
6941 messages. More will come later because it requires some general
6943 (New.DoResolve): Better error handling for unsafe types.
6944 (EmptyExpressionStatement): New class.
6945 (ElementInitializer): An object initializer expression.
6946 (CollectionElementInitializer): A collection initializer expression.
6947 (CollectionOrObjectInitializers): A block of object or collection
6949 (NewInitialize): New expression with element/object initializers.
6951 * statement.cs: Reverted object/collection initializer hacks.
6953 * typemanager.cs (CSharpName): Filter __arglist type.
6955 2007-08-09 Marek Safar <marek.safar@gmail.com>
6957 ** C# 3.0 Anonymous Types (update to the latest standard)
6959 * expression.cs (Binary.ResolveOperator): Threat all null based types
6961 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6962 (AnonymousTypeParameter): Updated.
6964 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6965 (AnonymousTypeClass): New anonymous type container.
6967 * class.cs (AddField): Return operation result.
6969 * generic.cs: Another empty TypeArguments overload.
6971 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6972 are stored at top of normal hierarchy.
6974 * typemanager.cs (CSharpName): Filter anonymous types.
6976 2007-08-09 Marek Safar <marek.safar@gmail.com>
6978 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6979 as single Concat call. How could we miss that :-(
6981 2007-08-08 Marek Safar <marek.safar@gmail.com>
6983 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6985 2007-08-07 Miguel de Icaza <miguel@novell.com>
6987 * expression.cs: Fix the previous commit, the creation of the
6988 arguments array list needs also to be conditional on the arguments
6991 * class.cs: Add a little bit of help to help narrow down problems.
6993 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6994 not try to copy in that case.
6996 * driver.cs: When building SMCS, include a new different set of
6997 default assemblies here. Do this here so we can control whether
6998 to include the default assemblies with /noconfig.
7000 2007-08-03 Marek Safar <marek.safar@gmail.com>
7002 A fix for bug #81979
7003 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
7006 2007-08-03 Marek Safar <marek.safar@gmail.com>
7008 A fix for bug #82300
7010 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
7011 we are in probing scope.
7013 2007-08-03 Marek Safar <marek.safar@gmail.com>
7015 A fix for bug #82301
7017 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
7018 (Statement.CloneTo): Clone and not map children blocks.
7020 2007-08-03 Marek Safar <marek.safar@gmail.com>
7022 A fix for bug #82299
7024 * expression.cs (LocalVariableReference.CloneTo): Remap local info
7027 * statement.cs (Statement.CloneTo): Clone variables before statements
7028 to allow remaping of local variables.
7030 2007-08-03 Marek Safar <marek.safar@gmail.com>
7032 A fix for bug #82296
7035 * report.cs: Log crash details for future clone problems.
7037 * statement.cs (Return.Clone): Don't clone non-existent expression.
7039 2007-08-03 Raja R Harinath <harinath@gmail.com>
7041 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
7042 (Class.AddBasesForPart): Move CS0537 check here from ...
7043 * cs-parser.jay (class_declaration): ... here. Move calling of
7044 'AddBasesForPart' to ...
7045 (class_bases): ... here.
7046 (struct_declaration, interface_declaration): Update to changes.
7048 2007-08-02 Marek Safar <marek.safar@gmail.com>
7050 A fix for bug #81923
7052 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
7053 conversion is allowed.
7055 2007-08-02 Marek Safar <marek.safar@gmail.com>
7057 A fix for bug #81564
7059 * ecore.cs (EventExpr): Add IsBase handling.
7061 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
7064 2007-08-02 Raja R Harinath <harinath@gmail.com>
7066 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
7067 * cs-parser.jay: Some whitespace cleanups.
7068 (current_delegate): New.
7070 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
7071 a dummy code block, and use 'type_name' instead of 'member_name'.
7072 (interface_declaration, class_declaration): Likewise.
7073 (delegate_declaration): Likewise. Rearrange slightly and use
7075 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
7076 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
7078 2007-08-02 Marek Safar <marek.safar@gmail.com>
7080 A fix for bug #82039
7082 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
7085 * typemanager.cs (CSharpName): Split to string overload.
7087 2007-08-02 Marek Safar <marek.safar@gmail.com>
7090 * report.cs: Updated warning CS0472.
7092 2007-08-01 Marek Safar <marek.safar@gmail.com>
7094 A fix for bug #82181
7096 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
7098 2007-08-01 Marek Safar <marek.safar@gmail.com>
7100 A fix for bug #82277
7101 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
7103 2007-08-01 Marek Safar <marek.safar@gmail.com>
7105 ** C# 3.0 Type Inference (major bits are working)
7107 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
7108 (.ImplicitStandardConversionExists): Uses compatible.
7109 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
7110 (.InferReturnType): New method.
7111 (.Compatible): Refactored.
7112 (.ResolveParameters): Uses factory to create resolved parameters.
7113 (.CompatibleMethod): Add probing mode support.
7114 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
7115 clearly distinguish between 2 different operations.
7116 (LambdaMethod): Moved to lambda.cs.
7117 (AnonymousMethod): Removed unused fields and methods.
7118 (AnonymousDelegate): Simplified.
7120 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
7122 * convert. cs (ImplicitConversionStandard): Compatible works differently.
7124 * delegate.cs (Delegate): New mehods to reduce code duplication.
7125 (.GetConstructor): New method.
7126 (.GetInvokeMethod): New method.
7127 (DelegateCreation): Updated.
7129 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
7131 (OverloadResolve): Made probing little bit faster.
7133 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
7136 * generic.cs (TypeInferenceContext): Dummy implementation.
7138 * iterators.cs: Updated after Resolve/Define rename.
7140 * lambda.cs (LambdaExpression)
7141 (.ResolveParameters): Handles both type of arguments and type inference too.
7143 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
7144 (InflateTypes): Updated.
7146 * support.cs (InflateTypes): Changed signature and updated.
7148 * typemanager.cs (LookupMemberCache): Better dynamic type check.
7149 (MemberLookup_FindMembers): More MS tricks.
7150 (GetParameterData): Ditto.
7151 (GetDelegateParameters): Uses quick path for dynamic types.
7153 2007-08-01 Marek Safar <marek.safar@gmail.com>
7155 * class.cs (MethodData.Define): EmitContext is required for generic stuff
7158 2007-07-31 Marek Safar <marek.safar@gmail.com>
7160 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
7163 2007-07-26 Jb Evain <jbevain@novell.com>
7165 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
7166 which takes a boolean 'report_errors', similar to the GetMethod.
7167 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
7168 in .net 2.1, do not report errors here.
7170 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
7171 System.Runtime.CompilerServices.RequiredAttributeAttribute and
7172 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
7175 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
7176 of the type InternalsVisibleToAttribute before the first call
7177 to CoreLookupType which is allowed to fail (third boolean parameter
7178 to true). Because, during the resolution for a type that is not
7179 immediately found, we try to check if the type is not defined in
7180 a friend assembly, and to do so, we need the
7181 InternalVisibleToAttribute.
7183 2007-07-23 Miguel de Icaza <miguel@novell.com>
7185 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
7186 feature that allows structs to be compared against null and inline
7187 the result as true or false.
7189 Notice that the same code is not permitted inside a generic block
7190 of code that would do:
7192 class Foo<T> where T : struct {
7199 It is only allowed if the type of T is not bound (no where
7200 clause). In my opinion, this CSC 2 behavior is broken but people
7201 seem to be using it (IronRuby does, a few bug reports on bugzilla
7202 have it and some people have complained about it).
7204 All of the users that depend on this behavior have code that is
7207 * report.cs (Warning, Error): make these take object arguments,
7208 not strings, as that allows us to take advantage of Format.
7210 2007-07-20 William Holmes <billholmes54@gmail.com>
7212 * decl.cs: Changed MemberName.CountTypeArguments to also check the
7213 Left member variable for the Count.
7214 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
7215 MemberName.CountTypeArguments to avoid a NRE.
7217 This code is contributed under the MIT X11 license
7219 2007-07-18 Marek Safar <marek.safar@gmail.com>
7221 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
7223 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7225 * doc.cs : generic method arguments are written as ``x while generic
7226 type arguments are `x. Combined with the previous change, fixed bug
7229 2007-07-18 Raja R Harinath <rharinath@novell.com>
7232 * expression.cs (Binary.ResolveOperator): When converting
7233 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
7235 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
7237 * doc.cs : when T: or whatever x: is specified, it does not really
7238 check the doc comment's syntax correctness. Fixed bug #82006.
7240 2007-07-18 Marek Safar <marek.safar@gmail.com>
7242 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
7243 LambdaExpression better.
7245 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
7247 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
7249 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
7250 as it can be generated.
7252 * expression.cs (Invocation.Error_InvalidArguments): Show correct
7255 * lambda.cs (LambdaExpression): Refactored to share same code with
7256 AnonymousMethodExpression.
7258 2007-07-17 Marek Safar <marek.safar@gmail.com>
7260 * anonymous.cs (MakeName): Include host name for easier debugging.
7261 (LambdaMethod): New class for lambda spcecific stuff.
7263 * attribute.cs: Set EmitContext return type.
7265 * class.cs: Set EmitContext return type.
7267 * codegen.cs (EmitContext): Return type cannot be null to stop messing
7268 with null/void meaning.
7270 * iterators.cs (ContainerType): Implemented.
7272 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
7274 * statement.cs (Return): Updated to lambda expressions.
7275 (Block.CloneTo): Parent can be null.
7277 2007-07-13 Marek Safar <marek.safar@gmail.com>
7279 A fix for bug #81917
7280 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
7282 * class.cs (FixedField): Check whether field is in unsafe scope.
7284 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
7285 (FieldExpr.Emit): Fixed buffers cannot be volatile.
7287 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
7290 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
7292 2007-07-13 Marek Safar <marek.safar@gmail.com>
7294 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
7295 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
7298 2007-07-13 Marek Safar <marek.safar@gmail.com>
7300 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
7302 2007-07-13 Marek Safar <marek.safar@gmail.com>
7304 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
7305 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
7307 * codegen.cs(EmitContext): Add ProbingMode flag.
7309 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
7311 * driver.cs: For now set both warning values.
7313 * ecore.cs (SimpleName): Name is readonly.
7314 (MethodGroup.OverloadResolve): One quick path for probing.
7316 * expression.cs (Unary): Set Oper r/o.
7317 (Binary): Set Oper r/o.
7318 (ParameterReference): Set few instance variables as r/o.
7319 (ParameterReference.DoResolveBase): Don't capture aruments when
7321 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
7322 (Arglist): arguments are private.
7323 (SizeOf): type is private and r/o.
7324 (MemberAccess): arguments are private.
7326 * report.cs: Enhanced reporting on/off capabilities.
7328 * lambda.cs: Uses ec.IsInProbingMode.
7329 (ContextualReturn): Derives from return.
7331 * rootcontext.cs: For now set both warning values.
7333 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
7335 (Return.Resolve): Don't die immediately.
7336 (Block.Resolve): Speed-up probing.
7337 (Block.CloneTo): Clone only child blocks.
7339 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
7341 * iterators.cs: reverted Miguel's latest change (r81925) as it
7342 breaks the build in System.
7344 2007-07-13 Miguel de Icaza <miguel@novell.com>
7346 * iterators.cs (Yield.CheckContext): Check for the iterator type
7347 also here as we can call into Yield even in codepaths that are not
7349 (MethodOrOperator is the only path that was checked).
7351 In addition to the standard check, use a more specific check for
7352 constructors to report a more verbose error.
7354 2007-07-12 Miguel de Icaza <miguel@novell.com>
7356 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
7357 report the warning and continue
7359 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
7360 values on the stack on the call to Emit. Use EmitStatement if
7361 possible, or using Emit + Pop if not possible. Fixes #82064
7363 2007-07-12 Raja R Harinath <rharinath@novell.com>
7365 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7366 avoid try...finally in some cases.
7368 2007-07-10 Marek Safar <marek.safar@gmail.com>
7370 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7372 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7373 instead of method. Re-use standard error handling.
7374 (ConstructorInitializer.Emit): Simplified.
7376 * delegate.cs: Updated after Invocation.EmitCall change.
7378 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7379 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7380 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7381 method and don't permanently changing input arguments.
7382 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7383 is resolved it has one of the candidates is the best one which is later
7384 used to emit. Removed a few unused method.
7385 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7387 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7388 (Binary.ResolveOperator): Ditto.
7389 (ConditionalLogicalOperator.DoResolve): Ditto.
7390 (Invocation): Uses method group.
7391 (Invocation.DoResolve): Simplified.
7392 (Invocation.EmitCall): Removed useless is_static.
7393 (Invocation.Emit): Delegate to method group.
7394 (Invocation.EmitStatement): Simplified.
7395 (New): Uses method group.
7396 (MemberAccess.DoResolve): Don't destroy original expression.
7398 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7400 2007-07-04 Marek Safar <marek.safar@gmail.com>
7402 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7405 * lambda.cs: Add custom error message type.
7407 2007-07-03 Marek Safar <marek.safar@gmail.com>
7409 * lambda.cs: Simplified little bit.
7411 * parameter.cs: Introduced ImplicitLambdaParameter.
7412 (Parameters.CreateFullyResolved): New factory instead of ctor.
7416 * delegate.cs: Updated parameter creation.
7418 2007-07-03 Marek Safar <marek.safar@gmail.com>
7420 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7423 * generic.cs: Synchronized with gmcs.
7425 2007-07-03 Marek Safar <marek.safar@gmail.com>
7427 * class.cs (Indexer): Check return type as soon as possible.
7429 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7432 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7434 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7436 * parameter.cs (Parameter): Use expression type when it is available.
7438 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7439 method modifier for the first parameter only.
7441 2007-06-24 Marek Safar <marek.safar@gmail.com>
7443 A fix for bug #81938
7444 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7446 * constant.cs: Tide up an exception message.
7448 2007-06-22 Marek Safar <marek.safar@gmail.com>
7450 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7451 an uninitialized variable is used.
7453 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7455 2007-06-22 Marek Safar <marek.safar@gmail.com>
7457 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7458 not found error handling.
7460 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7462 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7463 (ArrayCreation.DoResolve): Simplified.
7464 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7465 its own resolve process.
7466 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7468 2007-06-20 Marek Safar <marek.safar@gmail.com>
7470 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7473 2007-06-20 Marek Safar <marek.safar@gmail.com>
7475 * cs-tokenizer.cs: Removed var related stuff.
7477 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7478 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7479 a type and a keyword at same time.
7481 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7484 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7485 implicitly typed arrays, more changes will follow.
7487 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7489 2007-06-19 Marek Safar <marek.safar@gmail.com>
7491 * ecore.cs (VarExpr): Removed Handled field.
7493 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7494 build-in assign functionality.
7495 (ForEach.Resolve): Removed all implicitly typed local variable code and
7497 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7498 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7500 2007-06-18 Marek Safar <marek.safar@gmail.com>
7502 * assign.cs: Removed implicitly typed local variable check.
7504 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7505 referencing implicitly typed local variable.
7506 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7509 * statement.cs (Fixed): Removed unsupported implicitly typed local
7512 2007-06-15 Marek Safar <marek.safar@gmail.com>
7514 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7516 2007-06-14 Marek Safar <marek.safar@gmail.com>
7518 A fix for bugs #81855 and #76274
7519 * attribute.cs (AttachTo): Always set owner for global attributes to
7522 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7525 * cs-parser.jay: Assembly and module attributes must precede all other
7526 elements except using clauses and extern alias declarations.
7528 2007-06-13 Marek Safar <marek.safar@gmail.com>
7530 A fix for bug #81748
7532 * expression.cs: More checks for non ISO-1 features.
7534 2007-06-12 Marek Safar <marek.safar@gmail.com>
7536 A fix for bug #81807
7537 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7538 present inside switch statement and it is required by nullable check.
7540 2007-06-12 Marek Safar <marek.safar@gmail.com>
7542 A fix for bug #81840
7543 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7544 when type matching fails.
7546 * namespace.cs: Tiny error message change.
7548 2007-06-12 Marek Safar <marek.safar@gmail.com>
7550 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7551 reporting. Added automatic property check.
7553 * class.cs: Updated after CheckAbstractAndExtern relocation.
7554 (AEventPropertyAccessor.GetSignatureForError): Customized.
7556 2007-06-11 Marek Safar <marek.safar@gmail.com>
7558 * class.cs (DefineBaseTypes): Base type can be undefined.
7560 * ecore.cs (TypeLookup): Minor refactoring.
7561 (DoResolveAsTypeStep): Removed redundant check.
7563 * namespace.cs (Lookup): Removed redundant check.
7565 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7566 ResolveAsTypeTerminal step.
7567 (BootstrapCorlib_*): Simplified.
7568 (PopulateCoreType): Core types can be now external.
7570 2007-06-07 Marek Safar <marek.safar@gmail.com>
7572 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7574 (InferTypeArguments): Infers anonymous expression type arguments.
7575 (Compatible): Split to Compatible and InferTypeArguments.
7577 * lambda.cs: Updated.
7579 2007-06-08 Marek Safar <marek.safar@gmail.com>
7581 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7583 2007-06-07 Raja R Harinath <harinath@gmail.com>
7585 Fix #80477, cs0135-2.cs, cs0135-3.cs
7586 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7587 names to the "known" variables list.
7588 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7589 parameter names are also "known".
7590 (Block.CheckError136): Remove.
7591 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7594 2007-06-07 Marek Safar <marek.safar@gmail.com>
7596 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7598 2007-06-06 Marek Safar <marek.safar@gmail.com>
7600 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7601 internal error not an user error.
7603 * expression.cs (IsApplicable): Refactored to make debugging easier.
7605 * support.cs: More tricks for non-mono runtimes.
7607 * typemanager.cs (CoreLookupType): Made public.
7608 (InitSystemCore): All linq specific stuff moved to linq.cs
7610 2007-06-05 Marek Safar <marek.safar@gmail.com>
7612 * typemanager.cs (CSharpSignature): One more missing build-in types
7614 More tricks for non-mono runtime.
7616 2007-06-05 Raja R Harinath <harinath@gmail.com>
7618 * statement.cs (Block.CheckError136_InParents): Remove.
7619 (Block.AddVariable): Use GetParameterInfo instead.
7620 (ToplevelBlock.ProcessArguments): Likewise.
7622 2007-06-04 Raja R Harinath <rharinath@novell.com>
7624 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7626 (ToplevelBlock.GetParameterInfo): Split out of ...
7627 (ToplevelBlock.GetParameterRefernce): ... this.
7628 (ToplevelBlock.ParameterMap): Remove.
7629 * expression.cs (ParameterReference): Update to use
7630 ToplevelParameterInfo.
7632 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7635 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7636 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7638 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7639 (ToplevelBlock.ProcessParameters) ... here.
7640 (ToplevelBlock..ctor): Invoke it.
7642 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7645 * statement.cs (IKnownVariable): New interface.
7646 (LocalInfo): Implement it.
7647 (ToplevelParameterInfo): New class.
7648 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7649 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7650 GetKnownVariableInfo.
7652 2007-06-03 Raja R Harinath <harinath@gmail.com>
7654 Partly speed up CS0136 error checks.
7655 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7656 'recurse' parameter.
7657 (Block.DoCheckError136): Only check errors in parameters. Move
7658 local variable checks ...
7659 (Block.AddVariable): ... here, and ...
7660 (ToplevelBlock.ResolveMeta): ... here.
7662 2007-06-02 Raja R Harinath <harinath@gmail.com>
7664 * statement.cs (Block.IsChildOf): Remove.
7666 * statement.cs (Statement.Clone): Move special case code ...
7667 (Block.CloneTo): ... here.
7669 2007-05-29 Raja R Harinath <rharinath@novell.com>
7671 * statement.cs (ToplevelBlock.container): Remove field. It's
7672 redundant with 'Parent'.
7673 (ToplevelBlock.ContainerBlock): Remove accessor.
7674 (ToplevelBlock..ctor): Update to changes. Register anonymous
7675 child with parent here, ...
7676 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7678 (start_anonymous): Don't save current_block.
7679 (top_current_block): Remove.
7681 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7682 (Block.Resolve): Update to changes.
7683 (Block..ctor): Move setting of "correct" 'Toplevel'
7684 and 'Explicit' fields to ...
7685 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7687 2007-05-27 Raja R Harinath <harinath@gmail.com>
7690 * statement.cs (Block.Implicit): Remove.
7691 (Block): Update to changes.
7692 * flowanalysis.cs: Likewise.
7694 Mildly speed up CheckInvariantMeaningInBlock
7695 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7696 Recursively call AddKnownVariable to all enclosing blocks.
7697 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7698 Remove recursive calls.
7699 (Block): Update to changes.
7701 New ExplicitBlock invariants
7702 * statement.cs (Block.Explicit): New field. It points to the
7703 immediately enclosing non-implicit block.
7704 (Block..ctor): Maintain the invariant.
7705 * cs-parser.jay: Take advantage of invariant.
7707 Introduce ExplicitBlock
7708 * statement.cs (ExplicitBlock): New.
7709 (ToplevelBlock): Derive from it.
7710 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7712 (Block.Implicit): Update to changes.
7713 * cs-parser.jay: Update to changes.
7716 * codegen.cs (EmitContext.IsLastStatement): Remove.
7717 * statement.cs (Block.DoEmit): Update to changes.
7719 2007-05-25 Raja R Harinath <rharinath@novell.com>
7721 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7722 modifying current_block directly.
7724 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7726 * class.cs: Implemented automatic properties (C# 3.0)
7727 Thanks to Marek for the help.
7729 2007-05-23 Raja R Harinath <rharinath@novell.com>
7731 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7732 variable as assigned, note also that all its components are
7734 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7736 2007-05-19 Marek Safar <marek.safar@gmail.com>
7738 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7739 member is marked as compiler generated.
7741 * decl.cs (MemberCore): Refactored ModFlags into property.
7743 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7744 (Check): Check only accessibility modifiers.
7746 2007-05-18 Raja R Harinath <rharinath@novell.com>
7748 Track all assignable slots in one bit array
7749 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7750 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7751 logic from VariableMap constructor here. Use the same 'offset'
7752 variable that's later used for computing offsets of local
7754 * flowanalysis.cs (UsageVector.parameters): Remove.
7755 (UsageVector): Update to changes.
7756 (VariableMap): Remove.
7758 Avoid creating ParameterMap in every block
7759 * statement.cs (Block.ParameterMap): Move ...
7760 (ToplevelBlock.ParameterMap): ... here.
7761 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7763 * flowanalysis.cs (FlowBranching.param_map): Remove.
7764 (FlowBranching.UsageVector): Update to changes.
7765 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7767 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7769 * expression.cs (ParameterReference): Distinguish between block
7770 where parameter was referenced and declared.
7772 2007-05-18 Marek Safar <marek.safar@gmail.com>
7774 * flowanalysis.cs, statement.cs: Put back improved error handling.
7776 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7780 Imporved object and collection initialization (C# 3.0).
7782 2007-05-15 Marek Safar <marek.safar@gmail.com>
7784 A fix for bug #81380
7785 * expression.cs (Is.DoResolve): Only value types have constant `is'
7788 2007-05-15 Raja R Harinath <rharinath@novell.com>
7790 * statement.cs (ToplevelBlock.child): Remove.
7792 2007-05-15 Raja R Harinath <harinath@gmail.com>
7794 Rationalize ResolveMeta: refactoring
7795 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7796 out constant handling code into ...
7797 (Block.DoResolveConstants): ... this.
7799 Rationalize ResolveMeta: kill local_map
7800 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7801 (Block.AssignableSlots): New.
7802 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7803 for locals -- move code from VariableMap here. Avoid unnecessary
7805 * flowanalysis.cs (FlowBranching.local_map): Remove.
7806 (FlowBranching..ctor): Use Block.AssignableSlots.
7807 (VariableMap): Remove unused constructors.
7809 2007-05-11 Raja R Harinath <rharinath@novell.com>
7811 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7813 2007-05-11 Marek Safar <marek.safar@gmail.com>
7815 * typemanager.cs (IsFriendAssembly): Should not be called for building
7818 2007-05-09 Marek Safar <marek.safar@gmail.com>
7820 * literal.cs (NullConstant): Print null in all cases.
7822 * expression.cs (Binary.ResolveOperator): Implemented delegate
7823 comparison based on C# 2.0 changes.
7825 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7827 This code is contributed under the MIT X11 license
7829 The following enables support for several C# 3.0 language features:
7831 * cs-tokenizer.cs: Added support for the "var" keyword.
7833 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7834 Added VarExpr class to facilitate type inferencing.
7836 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7837 to support anonymous types.
7839 * assign.cs: Added support for type inferencing and initialization.
7841 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7843 * expression.cs: Added implicit array support to ArrayCreation.
7844 Added 5 types and 1 interface:
7846 IInitializable Implementing classes can inject initializing
7847 statements after object instantiation.
7849 Initializer Stores data for object initialization.
7851 AnonymousType An expression for anonymous types.
7853 AnonymousTypeParameter Stores data about an anonymous type's field.
7855 NewInitialize An expression for object initialization.
7857 CollectionInitialize An expression for collection initialization.
7859 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7862 2007-05-06 Marek Safar <marek.safar@gmail.com>
7864 A fix for bug #81500
7865 * cs-tokenizer.cs: Add special handling for coalescing operator.
7867 2007-05-06 Marek Safar <marek.safar@gmail.com>
7869 A fix for bug #81529
7870 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7871 its value from base class until it is redefined.
7873 2007-05-02 Raja R Harinath <rharinath@novell.com>
7875 Fix regression in cs0631-3.cs
7876 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7877 fallback. Make error fallback catch more cases.
7879 2007-05-01 Miguel de Icaza <miguel@novell.com>
7881 * cs-parser.jay: Allow parameters in operator declarations to have
7884 2007-04-27 Miguel de Icaza <miguel@novell.com>
7886 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7889 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7890 inside the ContextualReturn, it does not have to be an
7891 ExpressionStatement.
7893 2007-04-24 Miguel de Icaza <miguel@novell.com>
7895 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7898 2007-04-23 Miguel de Icaza <miguel@novell.com>
7900 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7901 method in two methods: ResolveNoDefine and Resolve.
7903 ResolveNoDefine will stop just after ResolveTopBlock has been
7906 Resolve will then continue by creating a method and issuing the
7907 call to method.Define ().
7909 (AnonymousMethod): Split and implement the new Resolve and
7910 ResolveNoDefine as well.
7912 * lambda.cs (LambdaExpression): Split the anonymous method
7913 resolution code into a separate routine (CoreCompatibilityTest)
7914 from DoCompatibleTest.
7916 (LambdaExpression.TryBuild): New method, this method tries to
7917 build the LambdaExpression with the given set of types to be used
7918 as the types for the various parameters of the lambda expression.
7920 If the compilation succeed with the given types, the infered type
7921 of the Anonymous method is returned, otherwise null is returned.
7923 2007-04-23 Marek Safar <marek.safar@gmail.com>
7925 A fix for bug #81414
7926 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7928 2007-04-22 Miguel de Icaza <miguel@novell.com>
7930 * cs-tokenizer.cs: Change various identifiers here from the
7931 camelCasing to the recommended Linux-like style for instance
7932 variables from the Coding Guidelines.
7934 2007-04-19 Martin Baulig <martin@ximian.com>
7937 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7938 System.Enum to System.ValueType.
7940 2007-04-13 Martin Baulig <martin@ximian.com>
7942 Rewrote implicit reference conversions. We need to distinguish
7943 between implicit reference conversions (13.1.4) and implicit
7944 boxing conversions (13.1.5).
7946 According to the spec, there's an an implicit conversion
7947 "From a one-dimensional array-type S[] to IList<T> and base
7948 interfaces of this interface, provided there is an implicit
7949 reference conversion from S to T." Note that this does not
7950 include boxing conversions.
7953 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7954 (Convert.ImplicitReferenceConversion): Split into
7955 ImplicitReferenceConversionCore() and
7956 ImplicitBoxingConversionExist().
7957 (Convert.ImplicitReferenceConversionExists): Use the new
7958 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7960 2007-04-12 Martin Baulig <martin@ximian.com>
7962 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7963 `TypeManager.null_type' checks up to the top of the method.
7965 2007-04-11 Marek Safar <marek.safar@gmail.com>
7967 A fix for bug #81350
7968 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7971 2007-04-11 Martin Baulig <martin@ximian.com>
7973 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7974 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7975 to make this work for generic classes; fixes #79561.
7977 2007-04-11 Martin Baulig <martin@ximian.com>
7979 * expression.cs (As): Add support for nullable types; fixes #79371.
7981 2007-04-11 Martin Baulig <martin@ximian.com>
7983 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7984 `type.FullName' is null; fixes #80243.
7986 2007-04-11 Martin Baulig <martin@ximian.com>
7988 * expression.cs (Invocation.IsApplicable): Don't modify the method
7989 if type inference succeeded, but the method was not applicable.
7992 2007-04-10 Marek Safar <marek.safar@gmail.com>
7994 A fix for bug #81324
7995 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7996 internal and external namespaces containers.
7998 2007-04-10 Martin Baulig <martin@ximian.com>
8000 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
8001 TypeManager.DropGenericMethodArguments() so we also call
8002 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
8004 2007-04-10 Martin Baulig <martin@ximian.com>
8006 * iterators.cs (Iterator.CreateIterator): Don't crash if
8007 `method.ReturnType' is null. This happens if something went wrong
8008 while resolving that typ (we already reported an error in this case).
8010 2007-04-10 Martin Baulig <martin@ximian.com>
8012 * expression.cs (New.DoResolve): Don't call CheckComImport() on
8013 generic interfaces; report the CS0144 directly.
8015 2007-04-10 Martin Baulig <martin@ximian.com>
8017 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
8018 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
8020 2007-04-10 Martin Baulig <martin@ximian.com>
8022 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
8024 2007-04-09 Raja R Harinath <rharinath@novell.com>
8027 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
8028 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
8031 * statement.cs (For.Resolve): If resolution fails, use
8034 2007-04-08 Marek Safar <marek.safar@gmail.com>
8036 * anonymous.cs (MakeName): Make faster and zero-based.
8037 (VerifyExplicitParameterCompatibility): Back to mode where generic
8038 parameter is ignored.
8039 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
8041 * class.cs (EmitType): Method can emit another new method.
8043 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
8045 * driver.cs: Updated.
8047 * lambda.cs: Reuse predefined empty parameters.
8049 * parameter.cs: Updated
8051 * support.cs: Implemented InflateTypes.
8053 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
8054 (InitSystemCore): Introduced to isolate 3.0 dependencies.
8056 2007-04-03 Martin Baulig <martin@ximian.com>
8060 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
8061 version of TypeManager.IsOverride() which also works with generic
8064 2007-04-03 Martin Baulig <martin@ximian.com>
8069 (Convert.ExplicitReferenceConversion): We need to cast when
8070 converting from IList<T> to S[].
8072 2007-04-01 Marek Safar <marek.safar@gmail.com>
8074 * decl.cs (FindExtensionMethods): Consider all candidates with same name
8077 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
8079 2007-03-31 Marek Safar <marek.safar@gmail.com>
8081 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
8082 argument and return type inferring.
8084 * codegen.cs (InferReturnType): Flag whether return can be inferred.
8085 (ReturnType): Turned to property.
8087 * statement.cs (Return): Implemented return type inferring.
8089 * support.cs (ReflectionParameters): Use local types if possible.
8091 2007-03-30 Raja R Harinath <rharinath@novell.com>
8093 * flowanalysis.cs (FlowBranching.Reachability): Remove.
8094 (FlowBranching.UsageVector): Update to changes.
8096 Prepare to kill 'Reachability'
8097 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
8098 argument of constructor.
8100 2007-03-29 Raja R Harinath <rharinath@novell.com>
8102 Prepare to kill 'Reachability'
8103 * flowanalysis.cs (UsageVector.is_unreachable): New.
8104 (UsageVector): Update to maintain 'is_unreachable' in parallel to
8105 'reachability', and verify they're consistent.
8108 * expression.cs (New.EmitStatement): Handle type parameters here too.
8110 2007-03-29 Martin Baulig <martin@ximian.com>
8115 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
8116 CompilerGeneratedClass.
8117 (ScopeInfo.EmitScopeInstance): Make this protected.
8118 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
8119 `ec.CurrentAnonymousMethod.Scope == Scope'.
8121 * statement.cs (Block.ScopeInfo): Make this a property.
8123 2007-03-27 Raja R Harinath <harinath@gmail.com>
8125 Prepare to kill 'Reachability'
8126 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
8127 (FlowBranching.UsageVector.Reachability): Remove property.
8128 (FlowBranching.UsageVector.IsUnreachable): New property.
8129 (FlowBranching.UsageVector.ResetBarrier): New.
8130 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
8131 * codegen.cs, statement.cs: Update to changes.
8133 2007-03-27 Martin Baulig <martin@ximian.com>
8138 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
8141 2007-03-26 Raja R Harinath <rharinath@novell.com>
8143 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
8144 instead of TriState. Remove all mention of TriState.
8146 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
8147 replaced by a boolean. Add boolean 'is_unreachable' field, check
8148 and maintain invariants.
8150 2007-03-25 Marek Safar <marek.safar@gmail.com>
8152 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
8154 2007-03-25 Marek Safar <marek.safar@gmail.com>
8156 * expression.cs: Stop using obsolete 2.0 opcodes.
8158 2007-03-25 Marek Safar <marek.safar@gmail.com>
8160 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
8161 one of the latests Martin's fixes.
8163 2007-03-23 Miguel de Icaza <miguel@novell.com>
8165 * expression.cs: On BigEndian systems, swap the bytes, temporary
8166 solution until we get a new bitconverter class.
8168 2007-03-23 Martin Baulig <martin@ximian.com>
8172 * decl.cs (MemberCache.AddMembers): Add generic methods both as
8173 "Method" and "Method`1". Normally, a cache lookup is done on the
8174 "Method" form (ie. without the generic arity), but this one makes
8175 lookups on the full form work as well.
8177 2007-03-22 Raja R Harinath <rharinath@novell.com>
8179 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
8182 2007-03-20 Bill Holmes <billholmes54@gmail.com>
8184 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
8185 ordered_member_list, to TypeBuilder to store members to be defined
8186 in the order they were parsed in.
8187 - ordered_explicit_member_list contains all properties indexers
8188 and methods that are defined as explicit implementation of an
8189 interface or base class.
8190 - ordered_member_list contains all properties indexers and methods
8191 that are not defined as explicit implementation of an interface
8194 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
8195 functionality in these removed classes has been replaced with
8196 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
8197 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
8199 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
8200 to CheckForDuplications inside GetMethod and SetMethod Define Method
8201 to handle method property and indexer name conflicts.
8205 All code is contributed under the MIT/X11 license.
8207 2007-03-20 Martin Baulig <martin@ximian.com>
8209 * class.cs (TypeContainer.Interfaces): Removed; they're now
8210 included in `TypeContainer.Types'.
8212 2007-03-20 Martin Baulig <martin@ximian.com>
8214 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
8216 * class.cs (TypeContainer.CreateType): New public method. This is
8217 now called before DefineType() to create the TypeBuilders.
8218 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
8219 has already been created by CreateType().
8220 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
8221 don't resolve our base classes here; this has been moved into
8222 DefineBaseTypes(). We're now called from CreateType().
8223 (TypeContainer.DefineBaseTypes): New private method; resolve our
8224 base classes here. We're now called from DefineType().
8227 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
8228 our types first to create all the TypeBuilders. After that, call
8229 TypeContainer.DefineType() on all the types which'll resolve their
8230 base classes and setup the resolve order.
8232 2007-03-20 Martin Baulig <martin@ximian.com>
8234 * class.cs (TypeContainer.Enums): Removed; they're now included in
8235 `TypeContainer.Types'.
8237 2007-03-20 Martin Baulig <martin@ximian.com>
8240 (TypeContainer.DefineType): Don't call ResolveMembers() here.
8241 (TypeContainer.DoResolveMembers): Call DefineType() on our
8242 `compiler_generated' classes; moved here from DefineNestedTypes().
8245 (RootContext.ResolveTree): Call ResolveMembers() on all
8246 TypeContainer's in the `type_container_resolve_order'.
8248 2007-03-19 Marek Safar <marek.safar@gmail.com>
8250 * class.cs: Use corlib to handle InternalMethodImplAttribute.
8252 2007-03-17 Marek Safar <marek.safar@gmail.com>
8254 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
8255 implementation flags.
8257 2007-03-17 Marek Safar <marek.safar@gmail.com>
8259 * class.cs: More optimizations for type parameters.
8261 2007-03-15 Marek Safar <marek.safar@gmail.com>
8263 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
8265 * ecore.cs, parameter.cs: More common code for both corlibs.
8267 * typemanager.cs (IsGenericMethod): Simplified.
8269 2007-03-15 Raja R Harinath <rharinath@novell.com>
8271 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8273 * statement.cs, iterators.cs, lambda.cs: Update to changes.
8275 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
8276 unconditionally. Simplify explanation.
8277 (Try.Resolve, Using.Resolve): Likewise.
8279 2007-03-15 Martin Baulig <martin@ximian.com>
8283 * decl.cs (DeclSpace): If we're a partial class, use our
8284 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
8286 2007-03-15 Raja R Harinath <rharinath@novell.com>
8288 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
8290 (FlowBranching.UsageVector): Update to changes.
8291 (FlowBranching.MergeSiblings): Likewise.
8292 * statement.cs: Likewise.
8294 2007-03-15 Martin Baulig <martin@ximian.com>
8299 (MemberCache): Added a special .ctor for type parameters.
8302 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
8305 2007-03-09 Martin Baulig <martin@ximian.com>
8307 * enum.cs (Enum): Make this a TypeContainer.
8308 (EnumMember): Derive from `Const'.
8311 (Const.DoResolveValue): New protected virtual method; move most of
8312 the functionality of ResolveValue() here so we can override it in
8314 (Const.CreateConstantReference): Make this virtual.
8316 * class.cs (Kind): Add `Kind.Enum'.
8317 (TypeContainer.Emit): Don't emit the enums here; they're already
8318 in the `RootContext.typecontainer_resolve_order'.
8320 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
8321 here; they're already in the `typecontainer_resolve_order'.
8323 * ecore.cs (EnumConstant.ConvertImplicitly): Add
8324 TypeManager.DropGenericTypeArguments().
8327 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
8328 (TypeManager.IsEnumType): Likewise.
8329 (TypeManager.EnumToUnderlying): Likewise.
8330 (TypeManager.IsEqual): Add support for enums.
8332 2007-03-12 Raja R Harinath <rharinath@novell.com>
8334 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
8335 DefaultParameterValueAttribute to be undefined, say if System.dll
8338 2007-03-11 Marek Safar <marek.safar@gmail.com>
8340 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
8343 2007-03-10 Marek Safar <marek.safar@gmail.com>
8345 * class.cs, parameter.cs: Unified parameters verification.
8347 2007-03-08 Martin Baulig <martin@ximian.com>
8349 * cs-parser.jay (constructor_header): Pass the location to the
8350 newly created TopLevelBlock.
8352 2007-03-07 Martin Baulig <martin@ximian.com>
8354 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
8356 2007-03-06 Miguel de Icaza <miguel@novell.com>
8358 * convert.cs (ExplicitReferenceConversionExists): Sync this method
8359 with the changes from David, fixes the build.
8361 2007-03-05 David Mitchell <dmitchell@logos.com>
8363 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8364 and its base interfaces to a one-dimensional array type S[],
8365 provided there is an implicit or explicit reference conversion
8368 2007-03-03 Marek Safar <marek.safar@gmail.com>
8370 * cs-tokenizer.cs: Implemented basic linq grammar.
8372 * driver.cs: Set linq lang version on demand.
8374 2007-02-26 Marek Safar <marek.safar@gmail.com>
8376 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8378 2007-02-25 Marek Safar <marek.safar@gmail.com>
8380 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8383 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8385 Check property and event extern attributes.
8387 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8390 2007-02-24 Marek Safar <marek.safar@gmail.com>
8392 A fix for bug #80407
8393 * ecore.cs: Don't report ambiguity error when methods have same parent.
8395 2007-02-23 Marek Safar <marek.safar@gmail.com>
8397 A fix for bug #80878
8398 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8400 2007-02-22 Marek Safar <marek.safar@gmail.com>
8402 * attribute.cs: Enable ExtensionAttribute presence test.
8404 2007-02-22 Marek Safar <marek.safar@gmail.com>
8406 * class.cs: Warn about missing GetHashCode only when Equals is override.
8408 * decl.cs: Check accessibility of type arguments.
8410 * typemanager.cs: Correctly report nullable array.
8412 2007-02-20 Marek Safar <marek.safar@gmail.com>
8414 * class.cs, report.cs: Capture more details when things go wrong.
8416 2007-02-20 Marek Safar <marek.safar@gmail.com>
8418 A fix for bug #80650
8419 * cs-parser.jay: Anonymous container starts at constructor declaration
8420 and not at block beginning because it has to be usable in constructor
8423 * statement.cs: Use context location and not block one for error reporting.
8425 2007-02-18 Marek Safar <marek.safar@gmail.com>
8427 A fix for bug #78712
8428 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8431 2007-02-18 Marek Safar <marek.safar@gmail.com>
8433 A fix for bug #80493 by Atsushi Enomoto
8434 * cs-parser.jay: Ignore invalid attribute target.
8436 2007-02-18 Marek Safar <marek.safar@gmail.com>
8438 * cs-tokenizer.cs: Ignore '\0' as white space character.
8440 2007-02-17 Miguel de Icaza <miguel@novell.com>
8442 * cs-parser.jay: Add support for lambda expressions to the mcs
8445 * lambda.cs: Only clone when we are probing, not on the final call
8446 (Compatible is the final call).
8448 * statement.cs (CloneContext): Introduce class to provide block
8449 remapping during clone.
8451 All statements Clone themselves now.
8453 (Clone): special handling for blocks, when we clone a block, we
8454 register the block inside this routine, as children of the block
8455 might trigger a lookup.
8457 * expression.cs: Add support for CloneContext in all expressions.
8459 2007-02-17 Marek Safar <marek.safar@gmail.com>
8461 A fix for bug #80493
8462 * statement.cs: Report ambiguous warning when interfaces are not related.
8464 2007-02-15 Marek Safar <marek.safar@gmail.com>
8466 C# 3.0 extension methods.
8468 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8469 cannot be used directly.
8471 * class.cs (Class.Emit): Emit extension attribute if any class method
8472 is extension method.
8473 (Method.Define): Add basic extension method validation conditions.
8474 (Method.Emit): Emit extension attribute for method.
8476 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8477 extension method exists. Currently we follow same approach as Microsoft
8478 does, emit even if a method or a class are private but this can change
8481 * cs-parser.jay: Add handling of `this' keyword in method parameters
8484 * decl.cs (DeclSpace.IsStaticClass): New property.
8485 (MemberCache.FindExtensionMethods): Looks for extension methods with
8486 defined name and extension type.
8488 * doc.cs: Updated after OverloadResolve changes.
8490 * driver.cs: Add new soft reference to System.Core.dll.
8492 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8493 (ExtensionMethodGroupExpr): Represents group of extension methods.
8495 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8496 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8497 to MethodGroupExpr and made non-static for easier customization.
8498 (Invocation.DoResolve): Add extension method lookup when no standard
8500 (MemberAccess.DoResolve): Try extension methods if no member exists.
8502 * modifiers.cs: Add METHOD_EXTENSION modifier.
8504 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8505 as well as candidate extension type.
8506 (ComputeNamespaces): When assembly constains extension methods registers
8508 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8509 extension method lookup.
8510 (Namespace.LookupExtensionMethod): Looks for extension method in this
8512 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8513 find a method which matches name and extensionType.
8515 * parameter.cs (Parameter): Add This modifer.
8516 (HasExtensionMethodModifier): New property.
8517 (Resolve): Add extension parameter check.
8518 (ModFlags): turned to property to exclude this modifier as it is not real
8520 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8522 * support.cs (ParameterData): Add ExtensionMethodType.
8523 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8525 * typemanager.cs: Add type and ctor extension attribute type.
8527 2007-02-15 Miguel de Icaza <miguel@novell.com>
8529 * report.cs (DisableErrors, EnableErrors): used to prevent error
8530 output when we are "trying" to compile various methods with
8533 * ecore.cs (Expression): Add Clone method that calls the virtual
8534 CloneTo method. The current CloneTo method in Expression throws
8535 an exception so we can track down all the places where this must
8536 be implemented (not using abstract, because that would be a lot of
8537 up-front-work before we can start testing the implementation
8540 Important: we only need Clone capabilities for expressions created
8541 by the parser, as the expressions we will be cloning are
8542 expressions in the pre-resolved state. This vastly simplifies
8545 (SimpleName): Add CloneTo that does nothing.
8546 (EmptyCast): Add CloneTo.
8548 * expression.cs (Binary): Implement CloneTo.
8549 (Invocation.IsApplicable): Store the current ec in
8550 EmitContext.TempEc and restore it on return. This is used so we
8551 do not have to sprinkle hundres of methods with an extra
8552 EmitContext, we know that the only user is the lambda expression
8553 ImplicitConversionExists code.
8555 (Argument): Add Cloning capabilities.
8556 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8557 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8558 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8559 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8560 IndexerAccess): Add Clone capability.
8562 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8564 (Argument): Add cloning capability.
8566 * assign.cs (Assign): Implement CloneTo.
8568 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8570 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8571 version by calling Convert with the EmitContext (that we are
8572 currently storing in ec, this is not great, but will do for now,
8573 to avoid passing EmitContext parameters to hundreds of functions
8574 that do not need them now).
8576 (SetExpression): Remove, it is not needed.
8578 (ContextualReturn): Implement CloneTo.
8580 * statement.cs (Statement): Implement cloning infrastructure,
8581 similar to expressions.
8583 (Block): Partial implementation of Clone for statements.
8585 (Return): Implement clone.
8587 * constant.cs (Constant.CloneTo): New method, does nothing.
8589 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8590 solution, until we decide how to exactly do this.
8592 2007-02-14 Marek Safar <marek.safar@gmail.com>
8594 A fix for bug #80493
8595 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8596 a property is override we need to use second accessor.
8598 2007-02-13 Marek Safar <marek.safar@gmail.com>
8600 A fix for bug #80418
8601 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8604 2007-02-13 Marek Safar <marek.safar@gmail.com>
8606 Another fix for bug #80749
8607 * pending.cs: Abstract class has priority over interfaces.
8609 2007-02-13 Marek Safar <marek.safar@gmail.com>
8611 Another fix for bug #80749
8612 * pending.cs: Abstract class has priority over interfaces.
8614 2007-02-13 Marek Safar <marek.safar@gmail.com>
8616 Another fix for bug #80749
8617 * pending.cs: Abstract class has priority over interfaces.
8619 2007-02-13 Marek Safar <marek.safar@gmail.com>
8621 Another fix for bug #80749
8622 * pending.cs: Abstract class has priority over interfaces.
8624 2007-02-13 Marek Safar <marek.safar@gmail.com>
8626 * class.cs Better error message.
8628 * driver.cs: Add shorter versions of -optimize option.
8630 2007-02-13 Martin Baulig <martin@ximian.com>
8632 * class.cs (Constructor.Emit): Check the return value of
8633 ec.ResolveTopBlock() and return on error.
8635 2007-02-13 Raja R Harinath <rharinath@novell.com>
8637 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8638 message to fix error message regression.
8640 2007-02-12 Marek Safar <marek.safar@gmail.com>
8642 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8644 2007-02-12 Marek Safar <marek.safar@gmail.com>
8646 A fix for bug #80749
8647 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8648 its parent container.
8650 * class.cs (DefineFieldInitializers): Each initializer can has different
8653 * const.cs: Updated.
8655 2007-02-11 Miguel de Icaza <miguel@novell.com>
8657 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8658 now all the heavy lifting to check that embedded statements or
8659 expressions have the right form is done in the ContextualReturn.
8661 (ContextualReturn): New class.
8663 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8664 method that can be invoked to report 201, so we do not replicate
8667 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8669 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8670 treating tabs as spaces.
8672 2007-02-09 Marek Safar <marek.safar@gmail.com>
8674 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8675 * assign.cs: Use full implicit conversion for right side check.
8677 2007-02-09 Marek Safar <marek.safar@gmail.com>
8679 * statement.cs (Switch): Switch over boolean type is not standardized.
8681 2007-02-08 Marek Safar <marek.safar@gmail.com>
8683 A fix for bug #80755
8684 * decl.cs (FindBaseEvent): Don't use method cache for events.
8686 2007-02-07 Marek Safar <marek.safar@gmail.com>
8688 * cs-parser.jay: Better syntax error handling.
8690 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8691 instead of underlying type value.
8693 2007-02-06 Marek Safar <marek.safar@gmail.com>
8695 * driver.cs: Check define identifier before is registered.
8697 * namespace.cs: Use existing error message.
8699 * report.cs: New warning.
8701 2007-02-06 Marek Safar <marek.safar@gmail.com>
8703 A fix for bug #80742
8704 * expression.cs: Delegate Invoke method can be called directly.
8706 2007-02-06 Marek Safar <marek.safar@gmail.com>
8708 A fix for bug #80676
8709 * class.cs (IsEntryPoint): The Main method can have params modifier.
8711 2007-02-04 Miguel de Icaza <miguel@novell.com>
8713 * parameter.cs (Parameter, Parameters): Add Clone method.
8715 * anonymous.cs (Compatible): Turn method into virtual method, so
8716 LambdaExpression can implement a different behavior.
8718 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8719 out the basic checking here, so it can be used by
8722 * lambda.cs: Introduce "Compatible" function that will do the
8725 2007-02-02 Marek Safar <marek.safar@gmail.com>
8727 * attribute.cs: Unified one error message.
8729 * class.cs (Class): Use type attributes and not properties to test static
8731 (IsEntryPoint): Don's pass local variable.
8733 * convert.cs: Removed duplicate check.
8735 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8737 * driver.cs: Don't crash when soft reference does not exist.
8739 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8740 (UsingEntry): Removed redundant allocation.
8742 * parameter.cs: Add fast path for type parameters.
8744 * support.cs: Don't allocate attribute when it's not used.
8746 2007-01-30 Miguel de Icaza <miguel@novell.com>
8749 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8750 this into a virtual method, so we can override it in LambdaExpression.
8752 * driver.cs: Improve diagnostics in case of failure.
8754 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8755 write a function that is slightly more complex and that parses:
8757 type identifier [, type identifier]* )
8759 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8762 (canEmpty ? i >= 0 : i > 0)
8764 2007-01-30 Raja R Harinath <rharinath@novell.com>
8766 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8767 exception on possibly valid code.
8769 2007-01-29 Raja R Harinath <rharinath@novell.com>
8771 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8773 (parse_opt_type_arguments): Remove. It's almost the same as
8775 (parse_namespace_or_typename): Use parse_less_than.
8777 2007-01-28 Miguel de Icaza <miguel@novell.com>
8779 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8780 this bug took a few hours to find, because the state saved and
8781 restored by PushPosition and PopPosition was ignoring the state of
8782 parse_generic_less_than.
8784 I can also now remove the handling of OP_LT and OP_GT, this solves
8787 * cs-tokenizer.cs: store the location for the ARROW token, we use
8790 (PushPosition, PopPosition): save/restore also `current_token',
8791 restore `parse_generic_less_than' (was missing).
8793 (parse_opt_type_arguments): use parse_type, not
8794 parse_namespace_or_typename to parse types.
8796 * lambda.cs: Empty new file, will eventually have the lambda
8797 expression implementation.
8799 * lambda.test: used to test the internal tokenizer.
8801 * report.cs (FeatureIsNotISO1): Rename from
8802 FeatureIsNotStandardized, because it was about the language level
8803 (1 vs 2) it was not about standarization.
8805 (FeatureRequiresLINQ): New.
8807 * support.cs (SeekableStreamReader): Only require that the reader
8808 is a TextReader, not a StreamReader, so we can plug StringReader.
8810 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8811 given position in the input stream the following tokens can be
8812 parsed as a type followed by an identifier.
8814 (is_punct): after a '(' if parse_type_and_parameter returns true,
8815 then return a special token OPEN_PARENS_LAMBDA which is used to
8816 avoid reduce/reduce errors in the grammar for the
8817 lambda_expression rules.
8819 (parse_type): implement a type parser inside the
8820 tokenizer, the parser only returns true or false depending on
8821 whether the input at a given position can be parsed as a type.
8823 (peek_token): new method used during type parsing.
8825 2007-01-28 Raja R Harinath <rharinath@novell.com>
8828 * anonymous.cs (ScopeInfo.InflateParameters): New.
8829 (AnonymousContainer.Resolve): Use it to redirect types of
8830 delegate parameters.
8832 2007-01-27 Raja R Harinath <rharinath@novell.com>
8835 * expression.cs (Error_InvalidArguments): Don't use two different
8836 messages for CS1503. Use ExtraInformation and
8837 SymbolRelatedToPreviousError instead.
8840 * decl.cs (DeclSpace.initialize_type_params): Don't access
8841 'type_params' of a partial class directly.
8843 2007-01-26 Miguel de Icaza <miguel@novell.com>
8845 * constant.cs: Removed a handful of out-of-range checks that were
8848 2007-01-25 Marek Safar <marek.safar@gmail.com>
8850 * expression.cs (CheckUselessComparison): Add additional check for char
8853 * namespace.cs: Fixed typo.
8855 2007-01-23 Miguel de Icaza <miguel@novell.com>
8857 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8858 gone, instead we inline the test, preventing the needless casts to
8859 longs, ulongs and doubles for the parameters, avoiding calls to
8860 methods that overchecked stuff, and instead inlined things
8863 2007-01-20 Marek Safar <marek.safar@gmail.com>
8865 * cs-parser.jay: Better parameter error handling.
8867 2007-01-17 Marek Safar <marek.safar@gmail.com>
8869 A fix for bug #80368, #80522
8870 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8871 whether array initializer contains constants only.
8872 (ArrayCreation.Emit): Use better formula to decide when
8873 are array initializers for static initialization.
8874 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8875 have to emit even constants otherwise they are pre-initialized.
8877 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8878 Raja R Harinath <rharinath@novell.com>
8880 Fix emit order of 'get' vs. 'set'.
8881 * support.cs (Accessors): New.
8882 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8883 Note the order in which accessors are declared in the source.
8884 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8885 Refactored from Property.Define and Indexer.Define.
8886 (PropertyBase.DefineAccessors): New helper that calls the above in
8887 appropriate order as noted by the parser.
8888 (Property.Define, Indexer.Define): Update to changes.
8889 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8891 2007-01-17 Raja R Harinath <rharinath@novell.com>
8893 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8894 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8895 there's an implicit conversion from the current type to the target
8896 type before converting the underlying constant.
8898 2007-01-16 Marek Safar <marek.safar@gmail.com>
8900 * const.cs (ResolveValue): Updated after constant conversion was made more
8903 * constant.cs (GetAttributableValue): constant to object conversion is
8904 used for attributes only.
8905 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8906 constant conversions.
8907 (LongConstant.ConvertImplicitly): Ditto.
8909 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8910 (ImplicitConversionStandard): Handle constant conversion as extra step.
8911 It solves the issue when constant conversion was called indirectly like
8912 inside array initializer and constant folding was skipped.
8914 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8917 * statement.cs(ImplicitConversionStandard): Updated after constant
8918 conversion was made more generic.
8920 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8922 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8923 Constraints, solves the problem where the compiler incorrectly
8924 reported that a type parameter was not constrained to a class (Bug
8927 2007-01-14 Marek Habersack <grendello@gmail.com>
8929 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8931 2007-01-14 Marek Safar <marek.safar@gmail.com>
8933 A fix for bug #80368
8934 * assign.cs (FieldInitializer): New class implements field
8935 initializer statement.
8937 * attribute.cs: Update after FieldMember rename.
8939 * class.cs (PropertyBasedMember): New common class for property based
8941 (InterfaceMemberBase): New base class for all members which can be used as
8942 an interface members.
8943 (MethodCore): Moved really common code to InterfaceMemberBase.
8944 (Method.Define): Equal and GetHasCode detection is relevant for methods
8946 (MethodData.Define): Don't assume that public event implements an
8947 interface automatically.
8948 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8950 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8951 (FieldMember): Merged with FieldBase.
8952 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8953 event extern modifier can be used.
8954 (EventField.EventFieldAccessor): Moved event field specific code here.
8955 (Event.AllowedModifiers): Even event can be extern.
8956 (Event.FindOutBaseMethod): New override specific to events.
8957 (Indexer.parameters): Reintroduce parameters because base class holds
8958 only properties common data.
8959 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8960 need do extra parameters check.
8962 * const.cs: Update after FieldMember rename.
8964 * decl.cs (MemberCache.FindBaseEvent): New method.
8966 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8967 to reflect that indexer is now derived from PropertyBased.
8969 * ecore.cs (GetMemberType): Made public.
8970 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8973 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8975 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8976 (RegisterEvent): Removed.
8977 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8978 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8980 2007-01-11 Raja R Harinath <rharinath@novell.com>
8983 * statement.cs (CollectionForeach.TryType): Prefer generic
8984 GetEnumerator over non-generic variant. Fix code to follow comments.
8986 2007-01-09 Raja R Harinath <rharinath@novell.com>
8989 * support.cs (ReflectionParameter): Don't use an invalid index on
8990 the generic parameter data.
8992 2007-01-08 Miguel de Icaza <miguel@novell.com>
8994 * driver.cs: Just add a tiny bit of infrastructure.
8996 2007-01-02 Marek Safar <marek.safar@gmail.com>
8998 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8999 where field type is struct from current assembly.
9001 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
9004 2007-01-02 Marek Safar <marek.safar@gmail.com>
9006 A fix for bug #80381
9007 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
9010 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
9012 (Namespace.LookupType): Always use core types from corlib when speficied.
9014 * report.cs: A new warning.
9016 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
9017 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
9018 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
9020 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
9021 (InitCoreTypes): Set expression type of object_type and value_type
9022 immediately after lookup.
9024 2007-01-01 Miguel de Icaza <miguel@novell.com>
9026 * cs-tokenizer.cs: Accept Pc class characters (Connector
9027 Punctuation) as valid identifiers. Fixes #78259
9029 * expression.cs (Invocation.DoResolve): Moved the check for the
9030 use of `this' for doing method calls to the Invocation resolution
9031 step, after overload resolution has taken place instead of doing
9032 the check at the low-level `This.DoResolve' level.
9034 The `This.DoResolve'(appens before overload resolution, so it has
9035 no way of knowing if the method that will be called will be
9036 instace or static, triggering an erroneous report for cs0188 (Bug
9039 We now do the check for instance method invocations after we know
9040 what method will be called.
9042 (This.CheckThisUsage): Move the actual use of this structure
9043 checking into its own method and expose it.
9045 * Everywhere that called Error_ValueCannotBeConverted: pass a new
9048 Exceptions: Null.ConvertImplicitly,
9049 Constant.ImplicitConversionRequired as there are too many call
9050 sites for passing the ec.
9052 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
9053 EmitContext, if the value is null, then we do not try to provide
9054 the extra information from the error (If a userdefined conversion
9055 exists, as UserDefinedConversion requires a non null-EmitContext).
9059 2006-12-30 Raja R Harinath <rharinath@novell.com>
9061 * flowanalysis.cs (MyBitVector): Document some invariants.
9062 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
9063 introduced below, and add a couple of others,
9065 2006-12-30 Marek Safar <marek.safar@gmail.com>
9067 * attribute.cs (GetMethodObsoleteAttribute): Uses new
9068 GetPropertyFromAccessor and GetEventFromAccessor.
9070 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
9071 overrides non-obsolete one.
9072 (Indexer.Define): Error message has been moved to the parser.
9074 * cs-parser.jay: Better syntax errors handling.
9076 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
9077 when an invocation has no arguments.
9079 * ecore.cs: Removed not used caching.
9081 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
9084 * report.cs: Add a new warning.
9086 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
9088 * typemanager.cs (enumeration_type): Removed.
9089 (CSharpSignature): Reuses IsSpecialMethod.
9090 (IsEqual): Hack for MS BCL.
9091 (GetPropertyFromAccessor): New method.
9092 (GetEventFromAccessor): New method.
9093 (IsSpecialMethod): Fixed to handle more cases.
9095 2006-12-30 Marek Safar <marek.safar@gmail.com>
9097 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
9098 Made white spaces array static.
9100 * ecore.cs (RemoveGenericArity): Optimized.
9102 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
9104 (MyBitVector.initialize_vector): Simplified.
9106 2006-12-22 Miguel de Icaza <miguel@novell.com>
9108 * ecore.cs: Am not entirely happy with this hack, but it seems to
9109 address the issue in 80257 (a small test case for
9112 I set the MethodGroupExpr.Type to an internal compiler type
9113 (itself in this case) to force the resolution to take place. Why
9114 it does not take place with a null is beyond me.
9116 2006-12-20 Marek Safar <marek.safar@gmail.com>
9118 A fix for bug #80288
9119 * expression.cs (ResolveOperator): Consider user defined conversion for
9120 logical and operator too.
9121 (EmitBranchable): Optimization for logical and when full constant folding
9122 could not be applied but one operand is constant.
9124 2006-12-19 Marek Safar <marek.safar@gmail.com>
9126 * class.cs (GetClassBases): Write 5 times every day, will never use
9127 FullName for error reporting.
9129 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
9131 2006-12-19 Martin Baulig <martin@ximian.com>
9133 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
9134 the symbol file info here.
9136 2006-12-18 Marek Safar <marek.safar@gmail.com>
9138 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
9139 of `elseif' is taking then following sections are not taking.
9140 Fixes an issue reported on mono mailing list.
9142 2006-12-18 Marek Safar <marek.safar@gmail.com>
9144 A fix for bug #80300
9145 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
9146 a caller is not taking.
9148 2006-12-18 Raja R Harinath <rharinath@novell.com>
9150 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
9151 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
9152 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
9153 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
9154 * class.cs: Update to changes.
9156 2006-12-17 Marek Safar <marek.safar@gmail.com>
9158 A fix for bug #79934
9159 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
9162 * class.cs (ResolveMembers): Register an iterator in current container and
9165 2006-12-16 Raja R Harinath <rharinath@novell.com>
9168 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
9169 satisfy a params annotated parameter.
9171 2006-12-16 Marek Safar <marek.safar@gmail.com>
9173 A fix for bug #77014
9174 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
9175 paramters correctly and not rely on hacks in Parameters class.
9176 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
9178 (Invocation.VerifyArgumentsCompat): Ditto.
9179 (Invocation.EmitArguments): Changed to correctly emit params arguments at
9182 * parameter.cs (HasParams): Don't assume that params is the last one.
9184 * support.cs (ReflectionParameters.ctor): Look for params attribute
9186 (ReflectionParameters.ParameterType): Removed hack when we returned last
9187 parameter for out of range parameters.
9188 (ParameterName, ParameterModifier): Ditto.
9190 2006-12-14 Marek Safar <marek.safar@gmail.com>
9192 A fix for bug #79987
9193 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
9194 when assembly is not CLS compliant but type is. I have no idea why is this
9197 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
9199 2006-12-13 Miguel de Icaza <miguel@novell.com>
9201 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
9202 in struct constructors, they are basically no-ops.
9204 2006-12-12 Marek Safar <marek.safar@gmail.com>
9206 * cs-tokenizer.cs (Position): Save preprocessor status too.
9208 2006-12-12 Marek Safar <marek.safar@gmail.com>
9210 A fix for bug #77794
9211 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
9213 2006-12-12 Marek Safar <marek.safar@gmail.com>
9215 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
9217 (pp_expr): Report error for an invalid expression.
9218 (handle_preprocessing_directive): Simplified; add more error checking.
9220 2006-12-11 Marek Safar <marek.safar@gmail.com>
9222 A fix for bug #74939
9223 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
9224 directives handling.
9226 2006-12-10 Marek Safar <marek.safar@gmail.com>
9228 A fix for bugs #80093, and #75984
9229 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
9230 logic, it seems to me as it worked before "by coincidence".
9231 (xtoken): Simplified to use reworked handle_preprocessing_directive.
9232 (cleanup): Enabled endif check.
9234 2006-12-09 Marek Safar <marek.safar@gmail.com>
9236 A fix for bug #80162
9237 * statement.cs (CollectionForeach.TryType): Generics and non-generics
9238 enumerators are never ambiguous.
9240 2006-12-08 Raja R Harinath <rharinath@novell.com>
9243 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
9245 2006-12-06 Marek Safar <marek.safar@gmail.com>
9247 A fix for bug #80144
9248 * class.cs (EventProperty.Define): Explicit implementation means
9249 that an even is used.
9251 2006-12-06 Marek Safar <marek.safar@gmail.com>
9253 Fixes the operators implementation (part II)
9255 * cfold.cs (DoConstantNumericPromotions): Renamed to
9256 DoBinaryNumericPromotions and simplified.
9257 (BinaryFold): Couple of conversion fixes; simplified.
9259 * constant.cs, ecore.cs, literal.cs
9260 (ToType): Renamed to ConvertImplicitly.
9261 (Reduce): Renamed to ConvertExplicitly.
9263 * class.cs, convert.cs: Updated.
9265 * expression.cs: TryReduce doesn't throw an exception.
9267 2006-12-01 Marek Safar <marek.safar@gmail.com>
9269 A fix for bug #80108
9270 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
9273 2006-11-30 Marek Safar <marek.safar@gmail.com>
9275 Fixes unary operators implementation (part I)
9278 * cfold.cs (Error_CompileTimeOverflow): Made internal
9280 * const.cs (IConstant): Changed to use reference to constant and
9281 not constant itself.
9282 Updated IConstant implementations.
9284 * constant.cs (CreateConstant): New factory method.
9285 Updated IConstant implementation.
9287 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
9289 * ecore.cs: Updated to use CreateConstantReference.
9291 * enum.cs: Reflects IConstant changes.
9293 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
9295 * literal.cs (NullConstant): Change to be independently usable.
9297 2006-11-29 Martin Baulig <martin@ximian.com>
9299 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
9300 we need to emit the scope initializer before calling the base .ctor.
9302 * anonymous.cs: Merged back from the new anonymous methods branch.
9303 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
9305 * expression.cs (ParameterReference.DoResolveBase): Create a
9306 "normal" ScopeInfo when capturing parameters rather than using the
9307 root scope; this makes things work with anonymous methods having
9311 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
9313 2006-11-22 Marek Safar <marek.safar@gmail.com>
9315 A fix for bug #79987
9316 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
9317 check to a base class.
9318 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
9319 only when assembly has missing attribute.
9320 * report.cs: Update.
9322 2006-11-21 Marek Safar <marek.safar@gmail.com>
9324 * cs-tokenizer.cs: Merged with gmcs version.
9326 2006-11-20 Marek Safar <marek.safar@gmail.com>
9329 * cs-parser.jay: Better error message when partial keyword is misplaced.
9331 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
9333 A fix for bug #79810
9334 report.cs: CS1058 only applies to 2.0 profile (gmcs).
9335 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
9336 a RuntimeWrappedException by default.
9338 2006-11-18 Marek Safar <marek.safar@gmail.com>
9340 A fix for bug #79843
9341 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
9343 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
9345 2006-11-18 Marek Safar <marek.safar@gmail.com>
9347 * driver.cs, namespace.cs: Uses faster IndexOf version.
9349 2006-11-17 Marek Safar <marek.safar@gmail.com>
9351 A fix for bug #79941
9352 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
9354 (Operator.Define): Implicit/Explicit operator of same type is duplicate
9355 even if internal name is different.
9356 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
9357 (UserDefinedConversion): Simplified as the operators cannot be internal.
9358 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
9360 (MethodLookup): Replaced EmitContext with parentType.
9361 * expression.cs: Updated.
9363 2006-11-09 Raja R Harinath <rharinath@novell.com>
9365 * driver.cs (BadAssembly): Handle all the ugliness of
9366 DefineDynamicAssembly.
9368 2006-11-08 Raja R Harinath <rharinath@novell.com>
9370 Address parts of #58244 -- most of what's left is in the runtime
9371 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9372 CS1509 error checks, and handle them for all assembly loads, not
9373 just the first invocation.
9374 (LoadModule): Likewise. Move handling of 'adder_method' ...
9375 * codegen.cs (AssemblyClass.AddModule): ... here.
9377 2006-11-02 Marek Safar <marek.safar@gmail.com>
9379 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9380 IEnumerable<T> is ambiguous.
9382 2006-10-31 Marek Safar <marek.safar@gmail.com>
9384 A fix for bug #67689
9385 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9386 GetEnumerator is ambiguous.
9388 * report.cs: Add new warning.
9390 2006-10-29 Marek Safar <marek.safar@gmail.com>
9392 A fix for bug #78602
9393 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9394 to protected member can be nested type.
9396 2006-10-28 Marek Safar <marek.safar@gmail.com>
9398 A fix for bug #78965
9399 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9400 to protected member must derive from current type.
9402 2006-10-27 Marek Safar <marek.safar@gmail.com>
9404 assign.cs: Reuses error method.
9406 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9407 instead of type for constants.
9408 (Expression.Error_ValueAssignment): Common error method.
9410 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9413 2006-10-27 Marek Safar <marek.safar@gmail.com>
9415 A fix for bug #79081
9416 * expression.cs (MemberAccess.DoResolve): Check nested type
9419 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9421 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9423 2006-10-26 Marek Safar <marek.safar@gmail.com>
9425 A fix for bug #76591
9426 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9428 2006-10-26 Marek Safar <marek.safar@gmail.com>
9430 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9431 type forwarder of the same type multiple times.
9433 2006-10-26 Raja R Harinath <rharinath@novell.com>
9436 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9437 instance as an rvalue, even when we later resolve as an lvalue.
9439 2006-10-25 Martin Baulig <martin@ximian.com>
9441 * anonymous.cs: Fix #79673.
9443 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9445 A fix for bug #79666
9446 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9447 ignored when is optimized (= default value) as its value is already set.
9449 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9451 A fix for bug #79724
9452 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9453 TypeContainer for type lookup.
9455 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9457 A fix for bug #79231
9458 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9459 * expression.cs (OverloadResolve): Always convert type name for
9461 (ResolveNamespaceOrType): Don't confuse a nested type with any
9464 2006-10-18 Martin Baulig <martin@ximian.com>
9466 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9468 2006-10-17 Miguel de Icaza <miguel@novell.com>
9470 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9471 an int32, but requesting an int64 from the conversion
9473 2006-10-12 Martin Baulig <martin@ximian.com>
9476 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9478 2006-10-12 Martin Baulig <martin@ximian.com>
9481 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9483 2006-10-11 Miguel de Icaza <miguel@novell.com>
9485 * convert.cs: Remove broken code: I was doing the "Existance"
9486 tests for Implicit conversions.
9488 2006-10-10 Miguel de Icaza <miguel@novell.com>
9490 * convert.cs: Added one missing case in
9491 ImplicitStandardConversionExists uint64 to intptr.
9495 * typemanager.cs (uintptr_type): another core known type.
9497 * ecore.cs (OperatorCast): routine used to do cast operations that
9498 depend on op_Explicit. We could change some of the Decimal
9499 conversions to use this.
9501 This one has a probe mechanism that checks both types for an op_
9502 which it coudl be used to eliminate two classes: CastToDecimal
9503 and CastFromDecimal.
9505 * convert.cs: Implement the conversions documented in #59800
9507 2006-10-10 Martin Baulig <martin@ximian.com>
9509 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9510 before RootScope.ResolveMembers().
9512 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9513 `CurrentType' if appropriate.
9515 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9517 A fix for bug #78568
9518 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9519 when contains binary operators.
9520 * cs-parser.jay: Updated.
9522 2006-10-09 Martin Baulig <martin@ximian.com>
9525 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9526 moved that into Define() and also do the other type parameter
9527 checks there. Fixes #79094. Added gtest-292.cs.
9530 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9531 since that doesn't include type parameters; don't use `Ldelema'
9532 for type parameters. Fixes #78980. Added gtest-293.cs.
9534 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9537 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9538 conversion is allowed.
9540 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9542 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9543 error reporting when no error occurs.
9545 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9547 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9550 2006-10-06 Raja R Harinath <rharinath@novell.com>
9553 * class.cs (DefineTypeBuilder): Check circular dependencies before
9554 setting the parent of the TypeBuilder.
9555 (CheckRecursiveDefinition): Don't use 'BaseType', since
9556 it may not be valid until after DefineTypeBuilder. Use
9557 'base_type' instead.
9559 2006-10-04 Martin Baulig <martin@ximian.com>
9561 Merged the Anonymous Methods patch.
9563 * anonymous.cs, iterators.cs: The new anonymous methods code.
9565 * statement.cs (Variable): New public abstract class.
9566 (LocalInfo.Variable): New public property.
9567 (LocalInfo.ResolveVariable): New public method.
9568 (Block.Flags): Add `IsIterator'.
9569 (Block.AddVariable): Improved the CS0136 check.
9570 (Block.AnonymousChildren): New public property.
9571 (Block.AddAnonymousChild): New public method.
9572 (ToplevelBlock): Update to use the new anonymous method framework.
9573 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9574 `ToplevelBlock'; this is required to correctly implement the
9576 (Fixed, Using): Use `TemporaryVariable' instead of directly
9577 creating the `LocalBuilder'.
9579 * parameter.cs (Parameter.ResolveVariable): New public method.
9580 (Parameters.ResolveVariable): Likewise.
9582 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9584 * class.cs (TypeContainer): Replaced the `iterators' list and
9585 corresponding methods with a list of `CompilerGeneratedClass'es.
9586 (TypeContainer.ResolveMembers): New public method.
9587 (Method): `IIteratorContainer' has been replaced by
9590 * expression.cs (VariableReference): New public abstract base
9591 class for `LocalVariableReference', `ParameterReference' and
9594 * codegen.cs (EmitContext): Removed `capture_context',
9595 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9596 (EmitContext.EmitThis): Removed.
9598 * cs-parser.jay: Replace `iterator_container' with
9601 2006-10-04 Martin Baulig <martin@ximian.com>
9603 * generic.cs (GenericMethod): Don't make this abstract.
9604 (Constraints.Clone): Added dummy implementation.
9606 2006-10-04 Raja R Harinath <harinath@gmail.com>
9609 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9610 'declspaces'. Avoid allocating arrays willy-nilly.
9613 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9614 cases out of the switch.
9616 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9618 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9619 message when non-generic type is used with the type arguments.
9620 * expression.cs: Updated.
9622 2006-09-28 Raja R Harinath <rharinath@novell.com>
9625 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9626 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9627 Change semantics slightly. Don't insist on having only one
9628 temporary EmptyExpression -- just throttle the creation of new ones.
9631 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9632 non-interfaces too. If no methods are found, don't try to create
9635 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9637 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9640 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9641 us produce better error message.
9643 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9645 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9646 of the `|' operator.
9648 * report.cs: A new warning added.
9650 2006-09-27 Martin Baulig <martin@ximian.com>
9652 * generic.cs (GenericMethod): Don't make this abstract.
9654 2006-09-27 Martin Baulig <martin@ximian.com>
9657 (InternalErrorException): Added overloaded ctor taking a params array.
9659 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9661 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9662 Fixed the cases when same error was reported twice.
9664 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9665 now report symbol information.
9667 2006-09-25 Martin Baulig <martin@ximian.com>
9669 * class.cs: Completely unified with the gmcs version.
9671 2006-09-25 Martin Baulig <martin@ximian.com>
9673 * typemanager.cs (TypeManager.IsNullableType): New public function.
9674 (TypeManager.IsNullableTypeOf): Likewise.
9675 (TypeManager.IsNullableValueType): Likewise.
9677 * class.cs (MethodCore): Added the `GenericMethod' argument from
9678 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9680 2006-09-24 Raja R Harinath <harinath@gmail.com>
9682 * convert.cs: Unify with gmcs version.
9684 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9686 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9687 verify them as well.
9689 * report.cs: New warning.
9691 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9693 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9694 for anonymous block with out argument.
9696 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9698 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9699 not used private events only.
9701 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9703 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9705 * const.cs (Const.Define): Check for constant type.
9706 (Const.IsConstantTypeValid): Looks for valid constant types.
9708 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9710 * ecore.cs (EmptyConstantCast): New common class for all constant based
9713 * expression.cs (Is.DoResolve): Handle null constant especially.
9714 (New.DoResolve): Check for new void().
9715 (MemberAccess.DoResolve): Cope with all kind of nulls.
9717 * literal.cs (NullConstant): Uses EmptyConstantCast.
9718 (NullDefault): Based on EmptyConstantCast.
9719 (NullLiteral): Uses EmptyConstantCast.
9721 * statement.cs (Block.ResolveMeta): Check for constant type.
9723 2006-09-22 Martin Baulig <martin@ximian.com>
9725 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9727 2006-09-22 Raja R Harinath <rharinath@novell.com>
9729 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9733 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9734 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9737 2006-09-22 Martin Baulig <martin@ximian.com>
9739 * ecore.cs: Merged with the gmcs version.
9741 * generic.cs (ConstructedType): New dummy class.
9742 (TypeArguments): Don't make this abstract.
9745 (TypeManager.IsGenericTypeDefinition): New method.
9746 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9748 2006-09-22 Raja R Harinath <rharinath@novell.com>
9750 * expression.cs (ComposedCast): Check for arrays of TypedReference
9751 before creating the type, not after.
9753 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9755 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9756 after ToType change.
9758 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9759 when constant must be implicitly convertible.
9761 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9763 * ecore.cs (NullCast): Derives from NullConstant.
9765 * expression.cs (Is.DoResolve): Removed useless variables.
9766 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9767 (New.Constantify): Add enum support.
9768 (MemberAccess.DoResolve): Add warning when accessing null constant or
9771 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9774 * literal.cs (NullConstant): New abstract class with common
9775 functionality for all null specializations.
9776 (NullDefault): Represents default(X) when result can be
9778 (NullLiteral): Updated.
9780 * report.cs: Add new warning.
9782 2006-09-21 Martin Baulig <martin@ximian.com>
9784 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9786 2006-09-21 Martin Baulig <martin@ximian.com>
9788 * generic.cs (GenericConstraints): New dummy class.
9789 (Constraints): Likewise.
9790 (TypeParameter): Likewise.
9791 (TypeParameterName): Likewise.
9792 (GenericMethod): Likewise.
9794 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9796 * decl.cs: Merged with the gmcs version.
9798 2006-09-21 Raja R Harinath <rharinath@novell.com>
9800 * generic.cs (TypeParameter): Implement IMemberContainer.
9801 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9803 * rootcontext.cs: Unify with gmcs version.
9805 * report.cs: Unify with gmcs version.
9806 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9807 from gmcs/generics.cs.
9808 * generics.cs (TypeParameter): New dummy class.
9810 * support.cs: Unify with gmcs version.
9812 2006-09-20 Raja R Harinath <rharinath@novell.com>
9814 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9815 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9817 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9818 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9819 * mcs.exe.sources: Add generic.cs.
9821 * codegen.cs: Unify with gmcs version.
9823 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9824 (EmitContext): Add GenericDeclContainer implementation.
9825 * decl.cs (MemberCore, DeclSpace): Likewise.
9826 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9828 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9829 MCS TypeManager has a corresponding dummy method.
9831 2006-09-19 Martin Baulig <martin@ximian.com>
9833 * expression.cs: Completely merged with the gmcs version.
9835 2006-09-19 Martin Baulig <martin@ximian.com>
9837 * expression.cs (Invocation): Merged with the gmcs version.
9838 (ArrayAccess.GetStoreOpcode): Likewise.
9840 2006-09-19 Martin Baulig <martin@ximian.com>
9843 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9844 (TypeManager.IsGenericMethodDefinition): Likewise.
9846 2006-09-19 Martin Baulig <martin@ximian.com>
9849 (TypeManager.IsEqual): Moved the gmcs implementation here.
9850 (TypeManager.DropGenericTypeArguments): Likewise.
9851 (TypeManager.DropGenericMethodArguments): Likewise.
9852 (TypeManager.GetTypeArguments): Moved here from gmcs.
9853 (TypeManager.HasGenericArguments): Likewise.
9855 2006-09-19 Martin Baulig <martin@ximian.com>
9857 * expression.cs (Binary): Merged with the gmcs version.
9859 2006-09-19 Martin Baulig <martin@ximian.com>
9861 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9863 2006-09-19 Martin Baulig <martin@ximian.com>
9865 * typemanager.cs: Merged with the gmcs version.
9867 2006-09-16 Raja R Harinath <rharinath@novell.com>
9869 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9870 * driver.cs: Likewise.
9872 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9875 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9876 only if parent type is class.
9877 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9880 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9883 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9885 * typemanager.cs(CSharpName): Converts NullType to null.
9887 2006-09-15 Martin Baulig <martin@ximian.com>
9890 (TypeManager.GetMethodName): Added mcs implementation.
9891 (TypeManager.IsEqual): Likewise.
9894 (SimpleName.RemoveGenericArity): Added dummy implementation.
9896 * pending.cs: Merged with the gmcs version.
9898 2006-09-15 Martin Baulig <martin@ximian.com>
9900 * statement.cs: Merge with the gmcs version.
9902 2006-09-15 Martin Baulig <martin@ximian.com>
9904 * statement.cs (Switch): Merge with the gmcs implementation
9905 (without nullables), which is newer.
9907 2006-09-15 Martin Baulig <martin@ximian.com>
9909 * statement.cs (Block.Variables): Make this public.
9910 (ToplevelBlock.Parameters): Make this a property.
9911 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9913 2006-09-15 Martin Baulig <martin@ximian.com>
9915 * namespace.cs: Merge with the gmcs version.
9917 2006-09-15 Martin Baulig <martin@ximian.com>
9919 * decl.cs (MemberName): Minor code cleanups.
9921 2006-09-15 Martin Baulig <martin@ximian.com>
9923 * parameter.cs: Merge with the gmcs version.
9925 2006-09-15 Martin Baulig <martin@ximian.com>
9927 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9928 and an error in mcs.
9930 2006-09-15 Martin Baulig <martin@ximian.com>
9932 * flowanalysis.cs: Merged from GMCS; added the generics code into
9933 a `GMCS_SOURCE' conditional so we can share this file.
9935 2006-09-08 Martin Baulig <martin@ximian.com>
9937 * typemanager.cs (TypeManager.interlocked_type): New public field.
9938 (TypeManager.int_interlocked_compare-exchange): New public field.
9939 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9940 enumerator types here and call InitGenericCoreTypes().
9941 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9942 after calling InitEnumUnderlyingTypes().
9945 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9946 `classes_second_stage'.
9948 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9950 * assign.cs, ecore.cs, expression.cs: Share error message text.
9951 * class.cs (FieldMember.Define): Check for varible of static type.
9952 * driver.cs (LoadAssembly): Uses error output for errors.
9953 * statement.cs: Updated.
9955 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9957 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9960 2006-09-07 Martin Baulig <martin@ximian.com>
9963 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9965 2006-08-29 Miguel de Icaza <miguel@novell.com>
9967 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9969 2006-08-17 Miguel de Icaza <miguel@novell.com>
9971 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9972 #52019 and #79064, the use of the \uXXXX sequence in source code
9973 to represent unicode characters.
9975 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9977 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9979 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9981 2006-08-13 Miguel de Icaza <miguel@novell.com>
9983 * assign.cs: Catch attempts to assign to a method groups in += and
9986 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9989 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9991 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9993 * class.cs (Method.Define): Issue a warning when generic method looks like
9995 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9998 2006-08-09 Marek Safar <marek.safar@seznam.cz>
10000 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
10002 * decl.cs (MemberCache.FindMembers): When container is interface we need to
10003 search all base interfaces as a member can be ambiguous.
10004 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
10005 Constructor member type filter.
10006 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
10007 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
10008 reporting for returned memberinfos.
10009 * report.cs: Updated.
10010 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
10011 version to work on all runtimes.
10012 (TypeManager.RealMemberLookup): Removed members filtering.
10014 2006-08-08 Raja R Harinath <rharinath@novell.com>
10016 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
10017 (PropertyExpr.EmitAssign): Likewise.
10018 * expression.cs (Indirection.EmitAssign): Likewise.
10019 (LocalVariableReference.EmitAssign): Likewise.
10020 (ParameterReference.EmitAssign): Likewise.
10021 (Invocation.EmitArguments): Likewise.
10022 (ArrayAccess.EmitAssign): Likewise.
10023 (IndexerAccess.EmitAssign): Likewise.
10024 (This.EmitAssign): Likewise.
10025 (ConditionalLogicalOperator.Emit): Likewise.
10028 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
10029 instead of ArrayList. If the hashtable has a LocalBuilder, don't
10030 leave it in after returning it.
10031 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
10033 2006-08-06 Marek Safar <marek.safar@seznam.cz>
10035 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
10038 2006-08-03 Raja R Harinath <rharinath@novell.com>
10040 Fix cs0146-3.cs and cs0146-4.cs.
10041 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
10042 enclosing types don't depend on the current type.
10044 2006-08-02 Raja R Harinath <rharinath@novell.com>
10047 * class.cs (TypeContainer.DoDefineMembers): Use
10048 FindBaseMemberWithSameName on Parent, since we're interested in
10049 whether we hide inherited members or not.
10050 (FindBaseMemberWithSameName): Make slightly more robust.
10052 Fix the non-generic testcase from #77396
10053 * decl.cs (DeclSpace.DeclContainer): Remove override.
10055 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
10056 declspaces for doppelgangers too.
10057 (UsingEntry): Implement IResolveContext.
10058 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
10059 'this' as the resolve context.
10060 (LocalAliasEntry): Likewise.
10062 Implement parts of #77403
10063 * roottypes.cs (RootDeclSpace): New. Used to represent the
10064 toplevel declaration space. Each namespace declaration introduces
10065 a "partial" root declaretion space.
10066 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
10067 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
10068 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
10069 from 'current_namespace.SlaveDeclSpace'.
10070 (namespace_declaration): Likewise.
10071 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
10072 check. It can't happen now.
10073 * decl.cs (DeclSpace.LookupType): Likewise.
10074 * driver.cs (MainDriver): Sanity check.
10076 2006-08-01 Raja R Harinath <rharinath@novell.com>
10078 * decl.cs (DeclSpace.FindNestedType): Remove.
10079 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
10080 LookupTypeContainer to get the container of the nested type.
10081 * class.cs (TypeContainer.FindNestedType): Make non-override.
10083 2006-07-31 Raja R Harinath <rharinath@novell.com>
10085 * decl.cs (DeclSpace.PartialContainer): Move field from ...
10086 * class.cs (TypeContainer.PartialContainer): ... here.
10087 (TypeContainer.AddBasesForPart): New helper.
10088 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
10090 * cs-parser.jay (current_class): Convert to DeclSpace.
10091 (struct_declaration, interface_declaration, class_declaration):
10092 Use AddBasesForPart instead of .Bases directly.
10093 * const.cs, iterators.cs: Update to changes.
10095 2006-07-28 Raja R Harinath <rharinath@novell.com>
10097 * class.cs (TypeContainer.AddMemberType): Rename from
10098 AddToTypeContainer.
10099 (TypeContainer.AddMember): Rename from AddToMemberContainer.
10100 (AddTypeContainer): New. Combine AddClassOrStruct and
10102 (AddPartial): Update. Add 'is_partial' argument.
10103 * roottypes.cs: Update to changes.
10104 * cs-parser.jay (push_current_class): New helper for handling
10105 current_container and current_class.
10106 (struct_declaration, interface_declaration, class_declaration):
10109 2006-07-26 Raja R Harinath <rharinath@novell.com>
10111 * roottypes.cs: Rename from tree.cs.
10113 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
10114 * tree.cs (Tree, ITreeDump): Remove types.
10115 * rootcontext.cs (tree, Tree): Remove fields.
10116 (root, ToplevelTypes): New.
10117 * *.cs: Update to rename.
10119 * tree.cs (Tree.RecordDecl): Remove.
10120 (RootTypes.AddToTypeContainer): Record the toplevel type in its
10122 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
10124 2006-07-23 Raja R Harinath <harinath@gmail.com>
10126 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
10127 DoFlowAnalysis and OmitStructFlowAnalysis here.
10128 (ec.With): Rename from WithUnsafe and generalize.
10129 (ec.WithCheckState): Remove. All users can be handled by 'With'.
10130 (ec.WithFlowAnalyis): New.
10131 * ecore.cs, expression.cs, statement.cs: Update.
10133 2006-07-22 Raja R Harinath <harinath@gmail.com>
10135 * statement.cs (Block.ResolveMeta): Simplify slightly.
10137 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
10138 multiple boolean fields. Convert InUnsafe, constant_check_state,
10139 check_state to flags.
10140 (CheckState, ConstantCheckState): Update.
10141 (InUnsafe): New read-only property.
10142 (FlagsHandle): Rename from CheckStateHandle and convert to handle
10144 (WithUnsafe): New helper similar to WithCheckState.
10145 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
10146 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
10148 2006-07-21 Raja R Harinath <rharinath@novell.com>
10150 Make comparisons use the same IL irrespective of whether they're
10151 in a 'checked' or 'unchecked' context: one of the issues in #78899
10152 * codegen.cs (EmitContext.CheckState): Make read-only property.
10153 (EmitContext.ConstantCheckState): Likewise.
10154 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
10155 helper that implement a save/restore stack for CheckState
10156 values. This is the only way to change check-state.
10157 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
10158 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
10159 (CheckedExpr.EmitBranchable): New forwarding method.
10160 (UnCheckedExpr): Likewise.
10161 * statement.cs (Block.ResolveMeta): Use WithCheckState.
10162 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
10163 (Checked.Resolve, checked.DoEmit): Likewise.
10165 2006-07-20 Miguel de Icaza <miguel@novell.com>
10167 * anonymous.cs: Cache the resolved anonymous delegate, and return
10168 this so that the ResolveTopBlock is only triggered once, not
10171 Currently we trigger ResolvetopBlock twice due to a first pass of
10172 argument check compatibility, and a second pass that does the
10175 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10177 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
10179 * rootcontext.cs (Reset): Add helper_classes.
10181 2006-07-15 Marek Safar <marek.safar@seznam.cz>
10184 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
10187 2006-07-13 Miguel de Icaza <miguel@novell.com>
10189 * statement.cs (Lock): Handle expressions of type
10190 TypeManager.null_type specially. Fixes #78770
10192 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10194 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
10197 2006-07-08 Marek Safar <marek.safar@seznam.cz>
10199 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
10200 for accessors as well.
10201 * ecore.cs (EventExpr): Add AccessorTable.
10203 2006-07-01 Marek Safar <marek.safar@seznam.cz>
10206 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
10207 for CS0122 where appropriate.
10208 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
10210 (Filter): Assembly can be null in the case of top level attributes.
10212 2006-06-25 Marek Safar <marek.safar@seznam.cz>
10216 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
10217 is done at global level.
10219 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10221 A fix for #77002, Implemented TypeForwarder support.
10223 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
10224 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
10225 * typemanager.cs (): Add type_forwarder_attr_type.
10227 2006-06-24 Marek Safar <marek.safar@seznam.cz>
10229 * report.cs: Add CS0469 warning.
10231 2006-06-21 Martin Baulig <martin@ximian.com>
10233 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
10234 the `try'-block, so we also report CS0016 etc. there.
10236 2006-06-21 Martin Baulig <martin@ximian.com>
10239 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
10241 2006-06-21 Martin Baulig <martin@ximian.com>
10243 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
10244 also report CS1686 for parameters.
10246 2006-06-21 Martin Baulig <martin@ximian.com>
10248 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
10249 instead of an error if the value is not implicitly convertible to
10250 the switch types; fixes #77964.
10252 2006-06-21 Raja R Harinath <rharinath@novell.com>
10255 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
10256 FieldBuilder is null.
10259 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
10260 'left' and 'right' before error-checking.
10262 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
10264 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
10266 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
10267 (FieldExpr.DoResolve): likewise.
10268 (PropertyExpr.InstanceResolve): likewise.
10269 (EventExpr.InstanceResolve): likewise.
10271 2006-06-04 Marek Safar <marek.safar@seznam.cz>
10273 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
10274 attribute applicable tests for attribute argument.
10276 2006-06-02 Raja R Harinath <rharinath@novell.com>
10279 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
10280 (Binary.OverloadResolve_PredefinedIntegral): New.
10281 (Binary.OverloadResolve_PredefinedFloating): New.
10282 (Binary.OverloadResolve_PredefinedString): New.
10283 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
10284 Follow the standard more closely, and treat numeric promotions in
10285 terms of overload resolution.
10286 (Binary.CheckShiftArguments): Simplify.
10288 2006-06-01 Raja R Harinath <rharinath@novell.com>
10290 * flowanalysis.cs (MyBitVector): Simplify representation.
10291 (MyBitVector.Clone): Avoid allocating BitArray.
10292 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
10293 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
10294 (*): Update. Change all references to MyBitVector.And and
10295 MyBitVector.Or to &= and |=.
10297 2006-05-29 Raja R Harinath <rharinath@novell.com>
10299 Fix cs0231-[34].cs.
10300 * cs-parser.jay (formal_parameter_list): Extend the pattern below
10301 to param arguments too.
10303 2006-05-26 Miguel de Icaza <miguel@novell.com>
10305 * cs-parser.jay: Catch another parsing form for arglist being
10306 followed by other arguments. Fixes #78313.
10308 2006-05-24 Raja R Harinath <rharinath@novell.com>
10310 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
10311 checking of out parameters to ...
10312 (FlowBranchingToplevel.Merge): ... here.
10313 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
10314 set, propagate the origin upward, and only complain if there was
10316 (FlowBranchingException.AddContinueOrigin): Likewise.
10317 (FlowBranchingException.AddReturnOrigin): Likewise.
10318 (FlowBranchingException.AddGotoOrigin): Likewise.
10320 2006-05-23 Raja R Harinath <rharinath@novell.com>
10322 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
10323 unreachable, skip it.
10324 (FlowBranchingException.Merge): Always propagate jumps, even if
10325 the finally block renders subsequent code unreachable.
10327 2006-05-18 Raja R Harinath <rharinath@novell.com>
10330 * statement.cs (Goto.Resolve): Move responsibility for resolving
10331 'goto' to FlowBranching.AddGotoOrigin.
10332 (Goto.SetResolvedTarget): New. Callback to set the
10333 LabeledStatement that's the target of the goto.
10334 (Goto.DoEmit): Use Leave instead of Br when crossing an
10335 unwind-protect boundary.
10336 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
10337 LookupLabel and adjust to new semantics.
10338 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
10339 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
10340 Goto.SetResolvedTarget to update target.
10341 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
10342 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
10343 AddBreakOrigin & co. Delay propagation until ...
10344 (FlowBranchingException.Merge): ... this.
10346 * statement.cs (Block.Resolve): Always depend on flow-branching to
10347 determine unreachability. Kill workaround that originally emitted
10348 only one statement after an "unreachable" label (see infloop in
10351 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
10352 This is still "wrong", but anything better would probably need a
10353 multi-pass algorithm.
10354 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
10355 usage vector. Force current usage vector to be reachable, to
10356 optimistically signify backward jumps.
10357 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
10359 (FlowBranchingLabeled.Merge): New. If no backward jump was
10360 detected, return the original salted-away usage vector instead,
10361 updated with appropriate changes. Print unreachable warning if
10363 * statement.cs (Block.Resolve): Don't print unreachable warning on
10364 a labeled statement.
10366 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10368 * driver.cs: Pass filename without path to AssemblyBuilder's
10369 AddResourceFile. Fixes bug #78407.
10371 2006-05-17 Raja R Harinath <rharinath@novell.com>
10373 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10374 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10375 (FlowBranching.MergeChild): Overwrite
10376 reachability information from Labeled branchings too.
10378 2006-05-16 Raja R Harinath <rharinath@novell.com>
10380 * statement.cs (Goto.Resolve): Merge jump origins here ...
10381 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10383 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10384 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10385 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10386 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10388 * statement.cs (Goto.Resolve): ... not here.
10389 (Goto.Emit): Remove CS1632 check.
10391 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10393 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10396 2006-05-11 Raja R Harinath <rharinath@novell.com>
10398 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10399 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10400 (FlowBranchingException.Label): Likewise.
10402 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10404 (MyBitVector.Or): Use it to avoid losing information (Count).
10405 (FlowBranching.MergeOrigins): Likewise.
10407 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10408 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10409 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10410 (UsageVector.ToString): Simplify.
10411 (UsageVector.MergeSiblings): Move here from ...
10412 (FlowBranching.Merge): ... here.
10413 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10416 2006-05-10 Raja R Harinath <rharinath@novell.com>
10418 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10419 null bitvector is treated as all-true.
10421 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10422 (MyBitVector): Rationalize invariants. 'vector != null' implies
10423 that we have our own copy of the bitvector. Otherwise,
10424 'InheritsFrom == null' implies all inherited bits are true.
10426 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10428 * statement.cs (LocalInfo): Add IsConstant.
10429 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10430 local variable for constants.
10432 2006-05-09 Raja R Harinath <rharinath@novell.com>
10434 * flowanalysis.cs (MyBitVector.Empty): New.
10435 (MyBitVector): Don't allow InheritedFrom to be null.
10436 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10437 (UsageVector, FlowBranching): Update to changes.
10439 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10440 recursion. The 'Parent == null' condition isn't sufficient for
10442 (FlowBranching.AddBreakOrigin): Likewise.
10443 (FlowBranching.AddContinueOrigin): Likewise.
10444 (FlowBranching.AddReturnOrigin): Likewise.
10445 (FlowBranching.StealFinallyClauses): Likewise.
10446 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10447 (FlowBranching.CheckOutParameters): Likewise.
10448 (FlowBranchingToplevel): Terminate all the above recursions here.
10449 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10450 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10452 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10454 (FlowBranchingToplevel): New. Empty for now.
10455 (FlowBranching.MergeTopBlock): Update.
10456 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10457 branching for the anonymous delegate.
10458 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10460 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10461 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10462 information at the start of the merge. Reorganize.
10464 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10466 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10468 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10470 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10471 to newly introduced ctor.
10473 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10474 message to one place.
10475 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10478 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10480 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10482 * ecore.cs (Expression.ResolveAsConstant): Updated.
10484 * statement.cs (ResolveMeta): Updated.
10486 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10488 * cs-parser.jay: __arglist cannot be used in initializer.
10490 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10493 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10496 2006-05-05 Raja R Harinath <rharinath@novell.com>
10498 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10499 (LabeledStatement): Add 'name' parameter.
10500 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10501 (Block.AddLabel): Update to changes.
10502 * cs-parser.jay (labeled_statement): Likewise.
10504 * flowanalysis.cs (BranchingType.Labeled): New.
10505 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10506 (FlowBranchingLabeled): New. Does nothing for now, but will
10507 eventually handle 'goto' flows.
10508 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10509 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10510 that's terminated ...
10511 (Block.Resolve): ... here.
10513 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10514 (UsageVector.MergeFinallyOrigins): Likewise.
10515 (FlowBranching.InTryOrCatch): Likewise.
10516 (FlowBranching.AddFinallyVector): Likewise.
10517 (FlowBranchingException): Update to changes.
10520 * statement.cs (Return.Resolve): Move error checking to ...
10521 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10522 (FlowBranchingException): Handle return origins like break and
10524 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10526 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10529 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10532 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10535 * class.cs (MethodData.Define): Do public accessor check only when method
10536 implements an interface.
10538 2006-05-04 Raja R Harinath <rharinath@novell.com>
10540 Remove special handling of 'break'
10541 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10542 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10543 (UsageVector.Break): Remove.
10544 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10546 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10548 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10549 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10551 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10554 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10555 be the interface member.
10557 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10560 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10561 for emitting small (int) values.
10563 2006-05-03 Raja R Harinath <rharinath@novell.com>
10566 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10567 control-flow passes through the 'finally' after merging-in all the
10568 control-flows from 'try' and the 'catch' clauses.
10570 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10571 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10572 always true at the only non-recursive entry point.
10573 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10574 FlowBranchingBreakable.
10575 (FlowBranchingLoop): Remove.
10576 * statement.cs (Return.DoResolve): Update to changes.
10579 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10580 (FlowBranching.CreateBranching): Handle it: create a
10581 FlowBranchingContinuable.
10582 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10583 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10584 except that it handles the 'continue' command.
10585 (FlowBranching.UsageVector.MergeOrigins): Rename from
10587 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10588 except that it overrides AddContinueOrigin.
10589 (FlowBranchingException): Override AddContinueOrigin, similar to
10591 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10592 Create a new branching around the embedded statement.
10593 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10594 control flow after the embedded statement.
10595 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10597 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10598 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10599 FlowBranchingBreakable.
10600 (FlowBranchingSwitch): Remove.
10603 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10604 error reporting to ...
10605 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10606 Rename from 'AddBreakVector'. Add new location argument. Return
10607 a bool indicating whether the 'break' crosses an unwind-protect.
10608 (FlowBranchingException.AddBreakOrigin): Add.
10609 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10610 flowbranching after updating with the effects of the 'finally'
10612 (FlowBranchingBreakable): New common base class for
10613 FlowBranchingLoop and FlowBranchingSwitch.
10615 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10616 embedded statement.
10617 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10619 2006-05-02 Raja R Harinath <rharinath@novell.com>
10621 * statement.cs (Do.Resolve): If the loop is infinite, set the
10623 (While.Resolve, For.Resolve): Set a barrier after the embedded
10624 statement. There's no direct control flow that goes from the end
10625 of the embedded statement to the end of the loop.
10626 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10627 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10628 above ensure that the reachability is correctly computed.
10630 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10631 (UsageVector.MergeBreakOrigins): If the current path is
10632 unreachable, treat it as if all parameters/locals are initialized.
10633 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10634 infinite loops before merging-in break origins.
10636 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10637 (Reachability.Reachable): Split part into ...
10638 (Reachability.Unreachable): ... this. Simplify.
10639 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10641 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10642 (Reachability.SetThrowsSometimes): Likewise.
10643 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10644 TriState.Always, use corresponding property.
10645 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10646 (Block.Resolve): Likewise. Remove some redundant checks.
10648 2006-05-02 Raja R Harinath <harinath@gmail.com>
10650 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10651 (Reachability.Meet): Don't bother checking AlwaysThrows --
10652 barrier is always set.
10653 (FlowBranchingBlock.Merge): Likewise.
10655 2006-05-01 Raja R Harinath <harinath@gmail.com>
10657 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10658 checks for unreachable.
10660 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10663 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10665 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10666 whether field is really assigned.
10668 2006-04-30 Raja R Harinath <harinath@gmail.com>
10670 * flowanalysis.cs (Reachability): Make 4-argument constructor
10672 (Reachability.Meet): Rename from 'And'. Remove static variant.
10673 (Reachability.Always): Rename from the highly misleading
10674 'Reachability.Never'.
10675 (FlowBranching.Merge): Update to changes. Mark an impossible
10676 situation with a 'throw'.
10677 (*): Update to changes.
10679 2006-04-29 Raja R Harinath <harinath@gmail.com>
10681 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10682 Remove 'Undefined'.
10683 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10684 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10685 (*): Update to changes.
10686 * statement.cs: Update to changes.
10688 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10691 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10693 2006-04-28 Raja R Harinath <harinath@gmail.com>
10695 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10698 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10699 argument to two arguments: an usage-vector and a bool. Move call
10700 to FlowBranching.Merge () ...
10701 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10703 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10704 handling of loop and switch reachability to ...
10705 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10707 2006-04-27 Raja R Harinath <harinath@gmail.com>
10709 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10710 handling to FlowBranchingLoop.InLoop.
10711 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10713 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10716 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10717 anonymous method is allowed from AnonymousContainer here.
10719 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10721 2006-04-24 Raja R Harinath <rharinath@novell.com>
10724 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10726 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10729 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10730 (DoubleConstant.Reduce): Ditto.
10732 2006-04-23 Raja R Harinath <rharinath@novell.com>
10734 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10735 Remove 'lvalue_right_side' argument. Move parts to ...
10736 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10737 (LocalVariable.DoResolveLValue): ... these.
10739 2006-04-21 Raja R Harinath <rharinath@novell.com>
10742 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10743 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10744 (LocalVariableReference.DoResolveBase): Use it to implement new
10746 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10747 (Argument.Resolve): Simplify. Move CS1510 check ...
10748 * ecore.cs (Expression.ResolveLValue): ... here.
10749 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10750 (PropertyExpr.DoResolveLValue): Likewise.
10751 (FieldExpr.Report_AssignToReadonly): Likewise.
10752 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10753 LValueMemberAccess or LValueMemberOutAccess on instance depending
10755 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10756 DoResolve as appropriate.
10758 2006-04-20 Raja R Harinath <rharinath@novell.com>
10761 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10762 implicit conversions on 'out' and 'ref' arguments.
10764 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10765 improve clarity. Remove dead code.
10768 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10769 (Catch.Resolve): Resolve VarBlock if it exists.
10771 2006-04-19 Miguel de Icaza <miguel@novell.com>
10773 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10774 twice, this was some residual code, the enumerator was emitted
10775 properly in the two branche of if later.
10777 2006-04-19 Raja R Harinath <rharinath@novell.com>
10779 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10780 cast is never an lvalue.
10781 (Cast.DoResolve, Cast.ResolveRest): Combine.
10782 (Argument.Emit): Simplify slightly. Move 'Expr is
10783 IMemoryLocation' check ...
10784 (Argument.Resolve): ... here.
10785 (Argument.Error_LValueRequired): Remove. Inline into only user.
10787 Simplifications. Fix cs0191-2.cs
10788 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10789 CS1649 and CS1651 to ...
10790 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10791 the actual selection of the error code and message to a lookup
10792 table. Add a dummy return value to simplify callsites.
10793 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10794 readonly fields of other instances of the same type. Move CS0197
10796 * expression.cs (Argument.Resolve): ... here. Simplify code.
10797 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10798 resolution of an out or ref argument. The code simplification
10799 above uses this invariant.
10801 2006-04-18 Raja R Harinath <rharinath@novell.com>
10803 Possibly fix #77752. Fix cs1690-[4-7].cs.
10804 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10805 CheckMarshallByRefAccess. Drop parameter.
10806 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10808 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10809 InstanceExpression.
10810 * report.cs (AllWarnings): Add CS1690.
10811 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10812 for ref access too.
10813 (LocalVariableReference.DoResolveBase): Update.
10815 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10817 * class.cs (MethodOrOperator): Moved common parts from method class.
10818 detect obsolete attributes.
10819 (Method.Define): Simplified as it reuses code from base.
10820 (Constructor.ValidAttributeTargets): Fixed issue found during
10822 (Destructor.ValidAttributeTargets): Fixed issue found during
10824 (Operator): Finished refactoring set off by #78020. Operator class is now
10825 ordinary method class.
10827 * anonymous.cs: Updated.
10829 * decl.cs (DeclSpace): Add IsGeneric
10831 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10833 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10835 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10837 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10838 detect obsolete attributes.
10839 (Method.CreateEmitContext): Moved to MethodOrOperator.
10841 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10844 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10845 customized exception to make crash detection easier.
10846 (MethodOrOperator): Started to work on new base class for methods and
10848 (Method): Derives from MethodOrOperator.
10849 (Constructor.Emit): Emits its own attributes.
10850 (AbstractPropertyEventMethod.Emit): Ditto.
10851 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10853 (Operator.Emit): It's temporary more tricky than should be.
10855 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10857 * report.cs (InternalErrorException): Add ctor with inner exception.
10859 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10862 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10865 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10868 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10871 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10873 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10874 attribute is present and Guid not.
10875 (Interface.ApplyAttributeBuilder): Ditto.
10877 * attribute.cs: Add error message.
10879 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10883 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10884 sources (it's composite) so hold them in extra array as they are used in
10885 Emit phase only. It worked in the previous versions by mistake.
10886 (Attribute.Emit): Emit attribute for more owners when exist.
10888 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10889 it has now different behaviour.
10891 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10893 * constant.cs (Constant.IsDefaultInitializer): New method.
10895 * class.cs: Updated.
10897 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10898 re-initialize default values. It saves KBs almost for every assembly.
10899 Thanks Zoltan for the idea.
10900 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10901 (ArrayCreation.DoResolve): Resolve only once.
10902 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10903 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10905 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10907 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10910 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10912 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10913 in an embedded statement too.
10915 2006-04-01 Raja R Harinath <rharinath@novell.com>
10918 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10920 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10924 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10927 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10929 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10931 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10934 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10935 LocalTemporary change.
10937 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10939 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10940 initializers optimization.
10941 (ClassOrStruct.TypeAttr): Moved from modifiers.
10942 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10943 (FieldBase.ResolveInitializer): Resolves initializer.
10944 (FieldBase.HasDefaultInitializer): New property.
10946 * cs-parser.jay: Removed message.
10948 * expression.cs (CompilerGeneratedThis): New specialization.
10950 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10952 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10954 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10956 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10958 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10959 be now EnumConstants only.
10961 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10963 * attribute.cs, driver.cs: Reset more caches.
10965 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10967 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10969 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10971 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10972 for easier reuse. Updated all overrides.
10973 (IntegralConstant): New base class for all integral constants.
10974 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10975 of the constant range, report custom error.
10976 (UIntConstant.Reduce): Fixed uint conversion.
10978 * ecore.cs, literal.cs: Reduce updates.
10980 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10984 * class.cs (Constructor.Define): Removed extra if for default ctors.
10985 A patch from Atsushi Enomoto.
10987 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10989 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10990 GetAttributableValue.
10992 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10995 * convert.cs (ImplicitConversionRequired): Error message moved to
10998 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10999 automatic implicit conversion of an output value.
11000 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
11002 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
11004 (TypeOf.GetAttributableValue): Add extra handling for object type.
11006 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
11007 special error message.
11009 2006-03-25 Marek Safar <marek.safar@seznam.cz>
11011 * class.cs (Constructor.Emit): Don't crash when struct ctor is
11013 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
11014 compatible with MS runtime.
11016 2006-03-23 Marek Safar <marek.safar@seznam.cz>
11018 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
11019 attribute arguments here.
11021 * class.cs (Indexer.Define): The check was moved to attribute class.
11023 2006-03-22 Marek Safar <marek.safar@seznam.cz>
11025 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
11026 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
11029 2006-03-22 Raja R Harinath <rharinath@novell.com>
11031 Support ParameterDefaultValueAttribute in gmcs. Also applied to
11032 mcs to keep code differences small.
11033 * attribute.cs (Attribute.GetParameterDefaultValue): New.
11034 * typemanager.cs (parameter_default_value_attribute_type): New.
11035 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
11038 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11040 * expression.cs (StringConcat.Append): Reverted back to no warning state.
11042 2006-03-21 Marek Safar <marek.safar@seznam.cz>
11044 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
11046 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
11049 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
11051 * doc-bootstrap.cs : fix build.
11053 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11055 * expression.cs (StringConcat.Append): Issue a warning when empty string
11056 is going to append.
11058 2006-03-20 Marek Safar <marek.safar@seznam.cz>
11060 * assign.cs (CompoundAssign.ResolveSource): Removed.
11062 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
11065 * class.cs (TypeContainer.FindMethods): Removed.
11066 (TypeContainer.CheckMemberUsage): Made static.
11068 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
11070 * constant.cs (CheckRange): Removed unused type argument.
11071 (CheckUnsigned): Removed unused type argument.
11073 * cs-parser.jay: Updated after MemberAccess clean up.
11074 Uses Length for empty string test.
11076 * cs-tokenizer.cs: Uses Length for empty string test.
11077 (IsCastToken): Made static.
11078 (is_hex): Made static.
11079 (real_type_suffix): Made static.
11081 * decl.cs (SetupCache): Made static.
11082 (OnGenerateDocComment): Removed unused ds argument.
11084 * delegate.cs (VerifyDelegate): Removed unused argument.
11086 * doc.cs: Uses Length for empty string test.
11088 * driver.cs: Uses Length for empty string test.
11090 * enum.cs (IsValidEnumType): Made static
11092 * expression.cs (EnumLiftUp): Removed unused argument.
11093 (ResolveMethodGroup): Ditto.
11094 (BetterConversion): Ditto.
11095 (GetVarargsTypes): Ditto.
11096 (UpdateIndices): Ditto.
11097 (ValidateInitializers): Ditto.
11098 (MemberAccess.ctor): Ditto.
11099 (GetIndexersForType): Ditto.
11101 * flowanalysis.cs: (MergeFinally): Removed unused argument.
11103 * iterators.cs: Updated after MemberAccess clean up.
11105 * location.cs: Uses Length for empty string test.
11107 * namespace.cs: Uses Length for empty string test.
11109 * report.cs (CheckWarningCode): Made static.
11111 * statement.cs (LabeledStatement): Removed unused argument.
11113 * typemanager.cs (FilterNone): Removed.
11115 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11117 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
11120 * class.cs: Updated.
11122 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11124 * cs-parser.jay.cs: __arglist is not allowed for delegates.
11126 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11130 * expression.cs (VerifyArgumentsCompat): Reverted to double error
11131 reporting, it's more tricky than I thought.
11133 2006-03-18 Marek Safar <marek.safar@seznam.cz>
11137 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
11139 (AnonymousMethod.ImplicitStandardConversionExists): New method.
11140 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
11141 Add more error reporting; Fixed issue with params.
11143 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
11145 * cs-parser.jay: AnonymousMethod requires host container.
11147 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
11149 2006-03-18 Raja R Harinath <harinath@gmail.com>
11151 * class.cs: Change 'TypeContainer ds' constructor argument to
11152 'DeclSpace parent'. Some classes were missed below due to
11153 different naming convention.
11155 * class.cs (MemberCore.Parent): Delete. This makes the
11156 ParentContainer changes below enforceable by the compiler.
11158 Treat pointers to enclosing declaration space as 'DeclSpace', not
11160 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
11161 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
11163 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
11165 (Block.AddThisVariable): Likewise.
11166 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
11167 (AbstractPropertyEventMethod.Emit): Likewise.
11168 (AbstractPropertyEventMethod.EmitMethod): Likewise.
11169 (GetMethod.Define, SetMethod.Define): Likewise.
11170 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
11171 (DelegateMethod.EmitMethod): Likewise.
11173 Fix regression test-partial-13.cs.
11174 Rationalize use of PartialContainer. Ensure that the partial
11175 class semantics can be tied to type-correctness, i.e., any
11176 violation will cause a compile error.
11177 * class.cs, const.cs: Access all fields that belong to class
11178 TypeContainer via ParentContainer. Arguments of EmitContexts and
11179 Resolve()-like functions still use 'Parent'.
11181 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
11182 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
11183 (PropertyMethod.CheckModifiers): Remove unused argument.
11184 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
11187 2006-03-17 Raja R Harinath <harinath@gmail.com>
11189 Make semantics of PartialContainer simpler.
11190 * decl.cs (DeclSpace.IsPartial): Remove.
11191 * class.cs (TypeContainer.IsPartial): Likewise.
11192 (TypeContainer..ctor): Set PartialContainer to point to self.
11193 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
11194 (TypeContainer.FindNestedType): Likewise.
11195 (MemberCore.ParentContainer): Simplify. Remove deprecation.
11197 2006-03-17 Marek Safar <marek.safar@seznam.cz>
11199 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
11201 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11203 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
11206 2006-03-15 Marek Safar <marek.safar@seznam.cz>
11208 * class.cs (Operator.Define): An error for base conversion was not
11209 reported correctly.
11211 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
11213 * iterator.cs : yield break is allowed in try statement which has
11214 catch clauses. Fixed bug #77767.
11216 2006-03-13 Marek Safar <marek.safar@seznam.cz>
11218 A fix for #77593, #77574.
11220 * class.cs (MethodCore.CheckBase): Another if for operator.
11222 2006-03-09 Marek Safar <marek.safar@seznam.cz>
11224 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
11227 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
11228 (DelegateCreation.ImplicitStandardConversionExists): New method for just
11231 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
11234 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
11235 Updated after another emitcontext usage was clean up. It should help us to
11236 synchronize with gmcs easier.
11238 2006-03-04 Marek Safar <marek.safar@seznam.cz>
11242 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
11243 (Event.Define): ditto
11244 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
11246 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
11247 Removed redundant code and set NewSlot for Invoke method too.
11249 * parameter.cs (Parameters.ctor): Add custom, type ctor.
11250 (Parameters.MergeGenerated): New method. Use this method when you merge
11251 compiler generated argument with user arguments.
11253 2006-03-03 Marek Safar <marek.safar@seznam.cz>
11255 * attribute.cs (ResolveAsTypeTerminal): Removed.
11257 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
11258 specialization for predefined types; 30% speed up.
11259 Finally placed obsolete check to right place.
11260 (Expression.ResolveType): Removed.
11262 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
11263 Updated after ResolveType was removed.
11265 * expression.cs (Cast.ctor): Check void cast.
11266 (Binary.ResolveAsTypeTerminal): Is never type.
11267 (Conditional.ResolveAsTypeTerminal): Is never type.
11269 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
11271 2006-03-01 Raja R Harinath <rharinath@novell.com>
11274 * expression.cs (ParameterReference.DoResolveBase): Change return
11276 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
11280 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
11283 * typemanager.cs (GetFullNameSignature): Don't nullref on
11284 protected accessors.
11286 2006-02-27 Marek Safar <marek.safar@seznam.cz>
11288 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
11289 these two separated members to simplify the code.
11290 (Attribute.Resolve): Refactored to use new fields and methods.
11291 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
11292 implemented obsolete attribute checking.
11293 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
11294 implemented obsolete checking again. It look line never ending quest ;-)
11295 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
11297 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
11299 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
11301 *class.cs (Property.Define): Add RegisterProperty call.
11303 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
11304 argument groups (only 2).
11306 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
11307 encoding expression to arguments.
11308 (Expression.ExprClassToResolveFlags): Just turned to property.
11310 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
11311 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
11312 optimized as well as implemented support for zero-length attributes.
11314 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
11315 Add caching of PropertyInfo's.
11317 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11319 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
11320 error multiple times.
11322 2006-02-25 Marek Safar <marek.safar@seznam.cz>
11324 New partial class implementation.
11325 A fix for #77027, #77029, #77403
11327 * attribute.cs (Attributable): Made attributes protected.
11329 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
11330 the replacements of ClassPart and PartialContainer.
11331 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
11332 (TypeContainer.AddInterface): Ditto.
11333 (TypeContainer.AddPartial): The main method for partial classes. It checks
11334 for errors and merges ModFlags and attributes. At the end class is added to
11335 partial_parts list.
11336 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
11338 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
11339 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
11340 from the rest of partial classes.
11341 (TypeContainer.GetClassBases): Simplified.
11342 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
11344 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
11345 (TypeContainer.HasExplicitLayout): Uses Flags now.
11346 (PartialContainer): Removed.
11347 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
11348 (StaticClass): Was merged with Class.
11349 (Class.GetClassBases): class and static class bases are verified here.
11350 (Class.TypeAttr): Added static attributes when class is static.
11351 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
11352 (MemberBase): In some cases we need to call parent container for partial
11353 class. It should be eliminated but it's not easy now.
11355 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
11357 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
11358 partial classed to accumulate class comments.
11359 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
11361 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
11363 * driver.cs (MainDriver): Tree.GetDecl was removed.
11365 * modifiers.cs (Modifiers): Add partial modifier.
11367 * tree.cs (Tree.decl): Removed.
11368 (RootTypes): Started to use this class more often for root types
11371 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11375 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11376 external interface does not have an attribute.
11378 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11380 Another prerequisites for new partial classs implementation.
11382 * attribute.cs (Attribute.Equal): Implemented.
11383 (Attribute.Emit): Changed as attributes can be applied more than twice.
11384 (Attributes.Emit): Check for duplicate attributes here.
11386 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11387 as a parameter, clean-up.
11389 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11393 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11394 contains obsolete attribute check which can in some cases look for base
11395 type of current class which is not initialized yet.
11396 (TypeContainer.BaseType): Replacement of ptype.
11398 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11400 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11402 First of prerequisites for new partial classs implemention.
11404 * attribute.cs (Attributable): Extended by ResolveContext;
11405 Attributes finally have correct context for resolving in all cases.
11406 (AttachTo): Attribute owner is assigned here.
11408 * codegen.cs (IResolveContext): Introduce new interface to hold
11409 all information needed in resolving phase.
11410 (EmitContext): Implements IResolveContext; more clean-up needed here.
11412 * decl.cs (MemberCore): Implemented IResolveContext.
11414 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11415 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11416 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11417 Refactored to use new IResolveContext instead of EmitContext; cleanup
11419 2006-02-06 Miguel de Icaza <miguel@novell.com>
11421 * codegen.cs (EmitScopeInitFromBlock): check here the
11422 capture_context, there is no need to make two calls to the
11425 * anonymous.cs: Add some debugging messages that might help me
11426 track other instances of this problem in the future (the
11427 regression of test 467).
11429 * cs-parser.jay: track the variable block, as we need to initalize
11430 any captured variables declared in this block for the "catch"
11431 portion of the "Try" statement.
11433 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11434 scope initialization for captured variables.
11436 Also, move the emit for the variables after the block location has
11439 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11441 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11443 2006-02-02 Miguel de Icaza <miguel@novell.com>
11445 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11446 commit yesterday, the initialization for the roots is necessary.
11447 What is not necessary is the scope activation.
11449 2006-02-02 Raja R Harinath <rharinath@novell.com>
11451 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11452 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11454 (Argument.Resolve): Remove CS0206 checks.
11456 2006-02-01 Miguel de Icaza <miguel@novell.com>
11458 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11459 scopes for all the roots, the scopes will now be emitted when the
11460 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11462 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11463 code. This reduces a lot of existing cruft.
11465 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11466 that the ScopeInfo is generated as we enter the scope, not at the
11467 time of use, which is what we used to do before.
11469 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11470 every time a Block is about to be emitted if we have a
11473 2006-02-01 Raja R Harinath <rharinath@novell.com>
11475 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11477 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11479 * typemanager.cs (cons_param_array_attribute): Make private.
11480 (Reset): Set it to null.
11481 (InitCoreHelpers): Don't initialize it.
11482 (ConsParamArrayAttribute): New. Initialize it as needed.
11483 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11485 2006-01-31 Miguel de Icaza <miguel@novell.com>
11487 * expression.cs: There might be errors reported during the
11488 selection of applicable methods. If there are errors, do not
11489 continue execution as it will lead the compiler to crash.
11491 2006-01-30 Miguel de Icaza <miguel@novell.com>
11493 * expression.cs: Member access is not allowed on anonymous
11494 methods. Fixes #77402.
11496 2006-01-30 Raja R Harinath <rharinath@novell.com>
11499 * cs-parser.jay (VariableDeclaration): Don't set
11500 current_array_type to null.
11501 (field_declaration, event_declaration, declaration_statement):
11502 Set it to null here.
11504 2006-01-28 Raja R Harinath <harinath@gmail.com>
11506 * typemanager.cs (GenericParameterPosition): New.
11509 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11511 * doc.cs : To process "include" elements, first we should create
11512 another list than XmlNodeList, because it could result in node
11513 removal, which could result in that the XmlNodeList gives up
11514 yielding next node.
11516 (Also made code identical to gmcs again.)
11518 2006-01-25 Miguel de Icaza <miguel@novell.com>
11520 * ecore.cs: Introduce an error report that we were not catching
11521 before, if not silent, we must report the error. Gonzalo ran into
11524 2006-01-23 Miguel de Icaza <miguel@novell.com>
11526 A fix for bug: #76957
11528 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11529 ComputeMethodHost before creating the method, this is a new
11532 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11533 that this method references (RegisterScope). The actual scope
11534 where the method is hosted is computed with the ComputeMethodHost
11535 before we create the method.
11537 Moved the Deepest routine here.
11539 (AnonymousContainer.ComputeMethodHost): New routine used to
11540 compute the proper ScopeInfo that will host the anonymous method.
11542 (ScopeInfo): Deal with multiple roots. The problem was that we
11543 did not have a unique root where all ScopeInfos could be hanged
11544 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11547 Remove AdjustMethodScope which is now computed at the end. Remove
11548 LinkScope which did a partial link, instead link all ScopeInfos
11549 before code generation from the new "LinkScopes" routine.
11551 Simplify all the Add* routines as they no longer need to maintain
11552 the tree, they just need to record that they are using variables
11555 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11556 routines to produce the forest of ScopeInfo trees.
11558 * class.cs (TypeContainer.AppendMethod): This is just like
11559 AddMethod, but ensures that an interface implementation method
11560 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11561 methods, but at the end.
11563 We use this functionality to ensure that the generated MoveNext
11564 method in the iterator class is resolved/emitted before the
11565 enumerator methods created.
11567 This is required because the MoveNext method computes the right
11568 ScopeInfo for the method. And the other methods will eventually
11569 need to resolve and fetch information computed from the anonymous
11572 2006-01-21 Raja R Harinath <harinath@gmail.com>
11573 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11575 Fix rest of #76995.
11576 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11577 the 'aliases' hash.
11578 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11579 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11581 2006-01-18 Raja R Harinath <rharinath@novell.com>
11583 Fix #76656, cs0231-2.cs.
11584 * cs-parser.jay (formal_parameter_list): Make error case catch
11586 (parenthesized_expression_0): Add CS1026 check.
11587 (invocation_expression): Remove unused { $$ = lexer.Location }.
11589 2006-01-17 Raja R Harinath <rharinath@novell.com>
11592 * cs-parser.jay (statement_expression): Don't list out the
11593 individual statement-expressions. Convert syntax error into
11596 2006-01-16 Raja R Harinath <rharinath@novell.com>
11599 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11600 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11601 CheckIntermediateModification.
11602 (FieldExpr.DoResolve): Add new two-argument version that
11603 allows us to resolve the InstanceExpression as an lvalue.
11604 The one-argument variant is now just a wrapper.
11605 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11606 Resolve the lhs as an lvalue if the it has a value type.
11607 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11608 from Assign.DoResolve.
11609 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11610 resolved as an lvalue.
11611 (PropertyExpr.DoResolve): Update.
11612 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11613 has a value type. Move CS1612 check here from
11614 CheckIntermediateModification.
11615 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11616 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11617 'right_side' of a ResolveLValue on an 'out' argument.
11618 (EmptyExpression.LValueMemberAccess): New. Used as the
11619 'right_side' of a propagated ResolveLValue on a value type.
11620 (LocalVariableReference.DoResolveBase): Recognize
11621 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11623 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11624 EmptyExpression.Null.
11626 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11628 * typemanager.cs : added IsGenericParameter(). In mcs it always
11630 * doc.cs : for generic parameters, use GenericParameterPosition,
11633 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11635 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11637 2006-01-12 Miguel de Icaza <miguel@novell.com>
11639 This fixes the problem where we used ldfld instead of ldflda to
11640 load the "THIS" pointer on captured parameters, when THIS is a
11641 value type. See bug #77205.
11643 * iterators.cs (CapturedThisReference.Emit): Pass false to
11644 EmitThis (we do not need the address).
11646 * codegen.cs (EmitThis): it needs to know whether we need the
11647 address of `this' or not. This is used by value types.
11649 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11650 every other call passes false.
11652 2006-01-12 Raja R Harinath <rharinath@novell.com>
11655 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11657 * expression.cs (Invocation.OverloadResolve): Update.
11658 (Invocation.DoResolve): Avoid double resolution of invocation.
11660 2006-01-11 Raja R Harinath <rharinath@novell.com>
11663 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11664 unary negation of floating point types as 0-expr; negation cannot
11665 overflow in floating point types.
11668 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11669 on operands of 'void' type.
11672 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11673 and ExclusiveOr for boolean constants too.
11675 2006-01-09 Raja R Harinath <rharinath@novell.com>
11678 * expression.cs (Invocation.OverloadResolve): Replace reflected
11679 override methods with their base virtual methods, rather than
11680 skipping over them.
11681 * typemanager.cs (TypeManager.GetOverride): New.
11683 2006-01-05 Jb Evain <jbevain@gmail.com>
11685 * class.cs (Property.Define, Indexer.Define): do not tag the
11686 properties as SpecialName | RTSpecialName.
11688 2006-01-04 Miguel de Icaza <miguel@novell.com>
11690 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11691 doing a low-level comparission of parameter types. It was lacking
11692 a check for __argslist.
11694 2005-12-30 Miguel de Icaza <miguel@novell.com>
11696 * expression.cs (ParameterReference.DoResolveBase): Allow
11697 reference parameters if they are local to this block.
11699 This allows the ref and out parameters of a delegate to be used in
11700 an anonymous method, for example:
11702 delegate void set (out int x);
11704 set s = delegate (out int x){
11708 This is used by functionality introduced late in the C# language.
11710 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11711 method that take ref and out parameters.
11713 Fixes #77119 which was a late change in the spec.
11715 2005-12-23 Miguel de Icaza <miguel@novell.com>
11717 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11718 parent if its the same scope. Fixes #77060.
11720 2005-12-21 Miguel de Icaza <miguel@novell.com>
11722 * driver.cs: Report the case of no source files and no -out:
11725 2005-12-20 Raja R Harinath <rharinath@novell.com>
11728 * expression.cs (ComposedCast.GetSignatureForError): Define.
11730 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11734 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11735 ListDictionary, to contain the ExternAliasEntry entries (in
11736 addition to the NamespaceEntry.aliases hashtable). This field is
11737 shared between the original entry and its doppelganger (bodyless
11739 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11740 extern_aliases field.
11741 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11742 lookup in extern_aliases.
11744 2005-12-16 Raja R Harinath <rharinath@novell.com>
11747 * class.cs (TypeContainer.Mark_HasEquals): New.
11748 (TypeContainer.Mark_HasGetHashCode): New.
11749 (ClassPart): Override them.
11750 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11753 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11754 'parent' argument to the base constructor.
11756 Remove all mention of TypeContainer from decl.cs.
11757 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11758 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11759 (DeclSpace.DeclSpace): Likewise.
11760 (DeclSpace.DefineMembers): Remove unused argument.
11761 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11762 debugging check -- we don't care if the debug code throws an
11763 InvalidCastException instead of an InternalErrorException.
11764 * class.cs (TypeContainer.DefineMembers): Update to changes.
11765 (TypeContainer.DoDefineMembers): Likewise.
11766 (TypeContainer.GetMethods): Likewise.
11767 (PropertyMember.Define): Likewise.
11768 (MemberBase.Parent): New property that forwards to
11769 MemberCore.Parent, but ensures that we get a TypeContainer.
11770 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11771 (RootContext.PopulateTypes): Likewise. Remove special case code
11772 for !RootContext.StdLib: DefineMembers is idempotent.
11774 2005-12-14 Miguel de Icaza <miguel@novell.com>
11776 * convert.cs (ExplicitConversionCore): Check the return value from
11777 ExplicitConversionCore which can return null on failure. Fixes #76914
11779 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11781 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11783 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11785 * doc.cs : The search for referenced namespace was insufficient to
11786 get global one as it used to do. Fixed bug #76965.
11788 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11790 * doc.cs : check name in cref in the last phase that whether it is
11793 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11795 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11798 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11800 * doc.cs : so it turned out that we cannot skip override check for
11801 interface members. Fixed bug #76954.
11803 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11805 * cs-tokenizer.cs : fixed bug #75984:
11806 - #warning and #error should not be handled when the source line
11808 - #line is not checked strictly when the source line is disabled.
11809 - #define and #undef is on the other hand checked strictly at any
11812 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11814 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11817 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11819 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11821 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11822 event initializers.
11823 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11824 (FieldBase.Initializer): Initializer is now optional.
11825 (EventField.Define): Only event field can have initializer.
11827 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11829 * const.cs (Const): Reuse initializer.
11831 * cs-parser.jay: Updated after FieldBase changes.
11832 Added current_array_type to simplify array initializers.
11834 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11836 * expression.cs, iterators.cs: Updated.
11838 * namespace.cs (NamespaceEntry): Made UsingFound private.
11840 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11842 * parameterCollection.cs: Obsolete, removed.
11843 * parser.cs: Obsolete, removed.
11845 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11848 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11850 * enum.cs (Enum.Define): Set obsolete context here.
11852 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11855 - FindDocumentedMember() now expects 1) paramList as null
11856 when "we don't have to check the number of parameters" and
11857 2) Type.EmptyTypes when "there is no arguments".
11858 - Introduced FoundMember struct to hold the exact type which was
11859 used to find the documented member (the above change broke
11860 test-xml-044; it might be better just to use DeclaringType than
11861 what MS does, like this change does, but it depends on usage.)
11863 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11865 * doc.cs : documented member might be from DeclaringType for nested
11866 types. Fixed bug #76782.
11868 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11870 * anonymous.cs: Have the param code handle leaving copies on the
11871 stack etc. Allows anonymous params to take part in the assignment
11872 code (++, +=, etc). Fixes bug #76550
11874 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11875 it down to the anon code.
11877 * iterators.cs: Use dummy var here
11879 * codegen.cs: Handle new vars
11881 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11884 * class.cs (MethodData.Define): Set proper Obsolete context.
11886 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11888 (FieldExpr.DoResolve): Ditto.
11890 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11893 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11894 parent is not obsolete.
11896 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11898 * doc.cs : (FindDocumentedMember) find parameterless members first
11899 and get CS0419 in the early stage. Fixed first case of bug #76727.
11901 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11904 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11905 no error was reported.
11907 *expression.cs (Binary.DoResolve): left can be null.
11909 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11912 * class.cs (MethodData.Emit): Parameters should be labeled first.
11914 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11917 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11919 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11921 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11923 * class.cs (MethodCore): Parameter clean up.
11924 (IMethodData): Added ParameterInfo.
11925 (MethodData): Parameter clean up.
11926 (Indexer.Define): Parameter clean up.
11938 * typemanager.cs: Parameter clean up.
11940 * delegate.cs (Define): Get rid of duplicated code.
11942 * expression.cs (ParameterReference): Removed useless parameters
11944 (Invocation): Ditto.
11946 * parameter.cs (ParamsParameter): New class, params specialization.
11947 (ArglistParameter): Attemp to separate arglist.
11948 (Parameter): Refactored to be reusable and faster.
11949 (Parameter.Modifier): Made understandable.
11950 (Parameters): Changed to be used as a class for `this' assembly
11951 parameters. Refactored to use new specialized classes.
11953 * support.cs (ParameterData): Added Types property.
11954 (InternalParameters): Deleted.
11956 2005-08-20 Martin Baulig <martin@ximian.com>
11958 Merging this patch from GMCS to fix #75867.
11960 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11961 scope if we don't already have it.
11963 2005-11-17 Martin Baulig <martin@ximian.com>
11966 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11967 inherit the scope from our parent. Fixes #76653.
11969 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11971 * doc.cs : the previous patch does not actually fix the bug.
11972 PropertyInfo override check is now implemented and really fixed it.
11973 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11975 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11977 * doc.cs : apply "override filter" also to properties.
11980 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11982 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11983 no need to check overrides. For classes, omit those results from
11984 interfaces since they must exist in the class. Fixed bug #76726.
11986 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11988 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11989 with different parameters. Fixed the second problem in #76685.
11991 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11993 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11994 get expected 'protected' access in CheckValidFamilyAccess()).
11997 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11999 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
12000 Fixed bug #76705. CS1569 was incorrectly commented out.
12002 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12004 * doc.cs : use Invocation.IsOverride() to do real override check.
12005 * expression.cs : made Invocation.IsOverride() internal.
12007 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
12009 * doc.cs : use TypeManager.FindMembers() instead of (possible)
12010 TypeBuilder.FindMembers() and filter overriden base members out.
12013 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12015 * doc.cs : ref/out parameters are represented as '@' (instead of
12016 '&' in type FullName). Fixed bug #76630 (additionally crefs).
12018 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12020 * doc.cs : when there was no '.' in cref to methods in doc comment,
12021 then parameters were missing in the output. Fixed bug #76691.
12023 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12025 * driver.cs : don't output docs when there is an error.
12028 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12031 Now it should detect indexers. Fixed primary concern in bug #76685.
12032 Fixed CS0419 message to not show the identical member signature in
12035 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
12037 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
12038 instead of Type.FindMembers() since it does not handle events.
12041 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
12043 * codegen.cs: Fixed typo (speficied -> specified).
12045 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12048 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
12050 2005-11-11 Marek Safar <marek.safar@seznam.cz>
12052 * attribute.cs: Changed error message.
12054 * cs-tokenizer.cs: One more check.
12056 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12058 * statement.cs (Block.Resolve): Ignore empty statement.
12060 2005-11-10 Marek Safar <marek.safar@seznam.cz>
12062 * report.cs: Made error/warning methods more strict to avoid
12065 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
12066 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
12067 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
12068 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
12070 2005-11-08 Marek Safar <marek.safar@seznam.cz>
12072 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
12073 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
12075 * class.cs (TypeContainer.IsComImport): New property.
12076 (Constructor.Define): Create proper ctor for ComImport types.
12078 * expression.cs (New.CheckComImport): Fixed.
12080 2005-11-07 Miguel de Icaza <miguel@novell.com>
12082 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
12083 that a parameter has been captured does not mean that we do not
12084 have to do the rest of the processing. This fixes the second part
12085 of #76592. If there was another anonymous method capturing
12086 values in the past, the Scope would never be set for the second
12087 method that captured the same parameter.
12089 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
12090 properly manipulate the stack. Second part of fix for #76592.
12092 * expression.cs (New): Add support for invoking "new" on
12093 interfaces that have been flagged with the ComImport attribute and
12094 the CoClass. Fixes #76637
12096 * statement.cs (Try.DoEmit): When a variable is captured, do not
12097 try to emit the vi.LocalBuilder variable as it has been captured.
12098 Create a temporary variable and store the results on the
12099 FieldBuilder. Fixes #76642
12101 2005-11-07 Marek Safar <marek.safar@seznam.cz>
12103 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
12105 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
12107 * expression.cs (Binary.DoResolve): Added && optimalization.
12109 * typemanager.cs (AddUserType): Removed useless argument.
12111 2005-11-04 Marek Safar <marek.safar@seznam.cz>
12113 * statement.cs (Block.variables): Uses ListDictionary.
12115 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12118 * class.cs (PartialContainer.EmitType): Customized to emit
12119 security attributes.
12120 (ClassPart.ApplyAttributeBuilder): Transform security attribute
12121 for partial classes.
12123 2005-11-03 Marek Safar <marek.safar@seznam.cz>
12126 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
12127 access has to be fixed.
12129 * typemanager.cs (IsUnmanagedType): Wrong common field type.
12131 2005-11-01 Marek Safar <marek.safar@seznam.cz>
12134 * ecore.cs (NullCast.Reduce): Implemented.
12136 * expression.cs (ArrayCreation.CheckIndices): Correcly check
12139 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
12141 (Foreach.Resolve): Catch null properly.
12143 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12145 * cs-tokenizer.cs: Warning text fix.
12147 * driver.cs: AllWarningNumbers exposed on public interface.
12149 * report.cs (): Reviewed warning numbers.
12150 (IsValidWarning): Use binary search.
12152 2005-10-29 Marek Safar <marek.safar@seznam.cz>
12154 * driver.cs: Implemeted resource visibility.
12155 (Resources): New class for code sharing between /res: and
12158 2005-10-28 Marek Safar <marek.safar@seznam.cz>
12161 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
12164 * convert (Convert.ImplicitReferenceConversion): NullCast holds
12167 * ecore.cs (NullCast): Child is contant only.
12169 * literal.cs (NullLiteral.Reduce): null can be converted to any
12172 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
12174 * driver.cs: Use Encoding.Default as default code page instead
12177 2005-10-27 Raja R Harinath <rharinath@novell.com>
12180 * expression.cs (Invocation.Error_InvalidArguments): Handle
12181 __arglist parameters.
12182 (Invocation.VerifyArgumentsCompat): Likewise.
12183 * support.cs (ReflectionParameters.GetSignatureForError): Print
12184 __arglist parameters.
12185 (InternalParamters.GetSignatureForError): Likewise.
12186 * parameter.cs (Parameters.GetSignatureForError): Likewise.
12188 2005-10-26 Marek Safar <marek.safar@seznam.cz>
12190 * attribute.cs (GetPropertyValue): Made public.
12192 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
12194 Add new property WrapNonExceptionThrows to handle 2.0 assembly
12196 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
12199 * driver.cs: Reflect method name change.
12201 * statement.cs (Try.Resolve): Warn when try has both general
12202 exception handlers.
12204 * typemanager.cs: runtime_compatibility_attr_type new predefined
12207 2005-10-26 Raja R Harinath <harinath@gmail.com>
12210 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
12211 treat it as an empty parameter list.
12213 2005-10-26 Raja R Harinath <rharinath@novell.com>
12216 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
12217 ResolveAsTypeStep silent.
12218 * statement.cs (Block.AddConstant): Mark block as used.
12219 (Block.ResolveMeta): Avoid piling on error messages
12220 if a constant initializer resolution fails.
12222 2005-10-25 Raja R Harinath <rharinath@novell.com>
12224 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
12226 (NamespaceEntry.VerifyAllUsing): New.
12227 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
12228 behaviour. Delegates actual resolution of alias to ...
12229 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
12230 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
12232 * driver.cs (Driver.MainDriver): Update.
12234 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
12235 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
12237 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
12239 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
12240 RootNamespace.DefineNamespacesForAll.
12242 2005-10-24 Raja R Harinath <harinath@gmail.com>
12244 * typemanager.cs (assemblies, external_aliases, modules)
12245 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
12246 (ComputeNamespaces, GetRootNamespace): Remove extra staging
12247 overhead. Move resposibility ...
12248 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
12249 * driver.cs, attribute.cs, codegen.cs: Update to changes.
12251 2005-10-23 Raja R Harinath <harinath@gmail.com>
12253 * namespace.cs (RootNamespace.all_namespaces): Renamed from
12254 cached_namespaces. Improve usage.
12255 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
12256 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
12257 Move from GlobalRootNamespace and simplify.
12258 (RootNamespace.Global): Make instance variable.
12259 (RootNamespace.RootNamespace): Add "alias name" parameter.
12260 (GlobalRootNamespace): Simplify drastically.
12261 (Namespace.Lookup): Don't use GetNamespace.
12262 * typemanager.cs (GetRootNamespace): Rename from
12263 ComputeNamespaceForAlias.
12264 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
12266 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12268 * anonymous.cs (AnonymousContainer): Don't crash when container
12271 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12273 * expression.cs (Binary.DoResolve): Warn when comparing same
12276 2005-10-23 Marek Safar <marek.safar@seznam.cz>
12279 * expression.cs (Binary.DoResolve): It looks like there are no
12280 convetsion rules in enum context.
12282 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
12284 Add support for extern alias qualifiers.
12285 * typemanager.cs: Move some LookupTypeReflection code
12286 to namespace.cs, to have cleaner code. Added some methods
12287 to help us keep track of the extern aliased references.
12288 * driver.cs: Add suport for extern alias assemblies on command
12289 line and check for their warnings/errors. Also keep track of the
12290 extern aliased assemblies.
12291 * namespace.cs: Move the global functionality of Namespace
12292 to GlobalRootNamespace/RootNamespace. Now the global namespace
12293 is GlobalRootNamespace.Globa. Also the code moved from
12294 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
12295 Finally added LocalAliasEntry (AliasEntry before) and
12296 ExternAliasEntry, to handle alias statements.
12297 * cs-parser.jay: Add support in the grammar for extern alias
12299 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
12300 Update callings to Namespace (now in GlobalRootNamespace).
12302 2005-10-18 Raja R Harinath <rharinath@novell.com>
12305 * class.cs (TypeContainer.DefineType): Move updating of
12306 topological sort earlier in the code.
12307 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
12309 2005-10-18 Marek Safar <marek.safar@seznam.cz>
12312 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
12314 * constant.cs (Constant.TryReduce): Moved from Cast class.
12315 (Reduce): Made little bit more OO and fixed missing conversions.
12317 * ecore.cs (Reduce): Implemented.
12318 (Binary.EnumLiftUp): New method to upgrade values to enum values.
12320 * literal.cs (Reduce): Implemented.
12322 * class.cs: Reverted Miguel's wrong commit.
12324 2005-10-14 Miguel de Icaza <miguel@novell.com>
12326 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
12328 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
12330 * cs-parser.jay, expression.cs : CS0214 was missing error location
12331 for constants. Fixed bug #76404.
12333 2005-10-11 Marek Safar <marek.safar@seznam.cz>
12336 * convert.cs (ExplicitConversionCore): Fixed object->enum
12339 2005-10-10 Raja R Harinath <rharinath@novell.com>
12341 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
12342 InstanceExpression.
12343 (PropertyExpr.EmitCall): Likewise.
12344 * expression.cs (Invocation.EmitArguments): Handle case where
12346 (Invocation.EmitCall): Avoid allocating temporary variable if
12347 there are no arguments.
12349 2005-10-07 Raja R Harinath <rharinath@novell.com>
12352 * convert.cs (ImplicitConversionStandard): Move conversion of
12353 void* to arbitrary pointer types ...
12354 (ExplicitConversionStandard): .. here.
12355 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
12356 error to always print typenames.
12358 2005-10-07 Raja R Harinath <rharinath@novell.com>
12360 * convert.cs (GetConversionOperator): Rename from
12361 GetConversionOperators. Move operator selection code from ...
12362 (UserDefinedConversion): ... here.
12364 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12366 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12369 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12371 * assign.cs (Assign.DoResolve): Error method changed.
12373 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12375 * const.cs (ResolveValue): Reset in_transit immediately.
12377 * constant.cs: Error method changed.
12379 * convert.cs: Removed useless location parameter.
12380 (ExplicitNumericConversion): Don't do double enum check.
12381 (ExplicitConversionCore): Renamed from ExplicitConversion.
12382 (ExplicitUnsafe): Extracted from ExplicitConversion.
12383 (ExplicitConversion): Uses for error reporting.
12385 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12387 (ResolveBoolean): Uses common error method.
12388 (CastToDecimal): Get rid of ec.
12389 (CastFromDecimal): Optimized.
12390 (ConvCast): Get rid of ec.
12392 * enum.cs (ResolveValue): Reset in_transit immediately.
12393 (Emit): Return after first error.
12395 * expression.cs: Convert changes.
12397 * literal.cs: Error method changed.
12399 * statement.cs: Error method changed.
12401 2005-10-03 Raja R Harinath <rharinath@novell.com>
12403 * support.cs (SeekableStreamReader.Position): Don't error out when
12404 the requested position is just beyond the end of the current
12407 2005-09-28 Raja R Harinath <rharinath@novell.com>
12409 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12410 try to keep in sync with the byte count of the underlying Stream.
12411 However, this limits us to a window size of 2048 characters: i.e.,
12412 the maximum lookahead of our lexer/parser can be 2048 characters.
12414 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12417 * driver.cs: Fix compilation files with full root path.
12419 2005-09-25 Miguel de Icaza <miguel@novell.com>
12421 * report.cs (SymbolRelatedToPreviousError): Format the output so
12422 it does not use an open parenthesis that is never closed.
12424 * driver.cs: Follow coding guidelines
12426 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12429 * const.cs (Const.ResolveValue): Check for assigning non-null
12430 value to reference type.
12432 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12434 * anonymous.cs: Implemented ExprClassName.
12436 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12439 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12442 * class.cs (StaticClass.DefineContainerMembers): Report protected
12445 * codegen.cs: if(ed) PRODUCTION.
12447 * convert.cs (Error_CannotImplicitConversion): Better error
12450 * cs-parser.jay: More error checks.
12452 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12454 * driver.cs (CSCParseOption): Enabled wrong option check.
12456 * ecore.cs (Expression.ExprClassName): Turned to property.
12457 (MemberExpr.CheckIntermediateModification): For checking boxed
12458 value types modification.
12460 * statement.cs (Fixed.Resolve): Expression type must be
12461 convertible to fixed type.
12462 (CollectionForeach.GetEnumeratorFilter,TryType):
12463 Small refactoring for easier error checking.
12465 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12467 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12470 * class.cs (GeneratedBaseInitializer): New class for customization
12471 compiler generated initializers.
12472 (MemberBase.DoDefine): Check Obsolete attribute here.
12473 (FieldMember.DoDefine): Ditto.
12475 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12478 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12479 (MemberCore.GetObsoleteAttribute): Removed argument.
12480 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12481 (MemberCore.CheckObsoleteType): New helper.
12485 * statement.cs: Updates after MemberCore changes.
12487 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12488 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12490 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12491 obsolete attribute for compiler construct.
12492 (As.DoResolve): Cache result.
12494 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12496 2005-09-26 Raja R Harinath <rharinath@novell.com>
12499 * expression.cs (This.VerifyFixed): In a value type T, the type of
12500 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12501 value type R, 'this' is treated as a value parameter.
12503 2005-09-22 Miguel de Icaza <miguel@novell.com>
12505 * statement.cs (Lock): Use the TemporaryVariable class instead of
12506 manually using local variables as those do not work when variables
12509 * ecore.cs: Moved the TemporaryVariable class from being a nested
12510 class inside Foreach to be a public class that can be employed in
12513 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12515 * cs-parser.jay: interface_accessors replaced by
12516 accessor_declarations.
12518 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12521 * statement.cs (GotoCase.Resolve): Convert null constant to
12523 (SwitchLabel.ResolveAndReduce): Ditto.
12524 (SwitchLabel.NullStringCase): Custom null stamp.
12525 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12527 typemanager.cs (CSharpSignature): Don't skip first argument
12530 2005-09-18 Miguel de Icaza <miguel@novell.com>
12532 * driver.cs: Set InEmacs based on the environment variable EMACS.
12534 * location.cs (InEmacs): in this mode, do not report column
12535 location as it confuses Emacs.
12537 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12539 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12540 expression.cs, iterators.cs, literal.cs: Store constants and
12543 * class.cs (MemberBase.ShortName): Pass location.
12545 * cs-parser.jay: Some location fixes.
12547 * ecore.cs (Expression.Location): Made virtual.
12549 2005-09-05 Miguel de Icaza <miguel@novell.com>
12551 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12552 if the underlying types are the same, otherwise we need to produce
12553 code that will do the proper cast.
12555 This was exposed by Marek's constant rewrite which produced
12556 invalid code for the call site:
12558 enum X : long { a }
12559 void Method (X v) {}
12563 This fixes test-49.cs
12565 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12567 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12568 Type/Object should be allowed as well. Fixed bug #75968.
12570 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12572 * expression.cs : (Binary.DoResolve): when one is enum constant and
12573 another is constant 0, then return enum one *as enum type*.
12576 2005-09-02 Raja R Harinath <rharinath@novell.com>
12578 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12582 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12583 flow-branching for LocalVariableReferences in case we were invoked
12584 from a MemberAccess.
12585 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12587 (LocalVariableReference.DoResolveBase): ... this.
12588 (MemberAccess.Resolve): Do the check that was disabled during
12591 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12594 (PartialContainer.Create): check abstract/sealed/static strictly
12595 but abstract/sealed can exist only at one side. Fixed bug #75883.
12597 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12600 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12601 specified, don't default to UnmanagedType.I4.
12603 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12605 * expression.cs : conditional operator should check possibly
12606 incorrect assign expression. Fixed bug #75946.
12608 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12610 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12611 Reverting the change. gmcs is much complex than mcs on this matter.
12613 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12615 * cs-tokenizer.cs : To read another token ahead of the actual
12616 consumption, use new SavedToken and cache token instead of moving
12617 back the stream with SeekableStreamReader (it seemed problematic).
12619 driver.cs : Thus use StreamReader directly.
12620 * support.cs : Thus removed SeekableStreamReader.
12622 2005-08-30 Raja R Harinath <rharinath@novell.com>
12625 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12626 (ScopeInfo.EmitScopeType): Use it to construct field names from
12627 names of captured locals.
12630 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12631 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12632 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12633 (ExplicitConversion): Remove enum cases already handled by
12634 implicit conversion. Move implicit conversion check to the beginning.
12635 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12636 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12637 Don't treat System.Enum as a struct.
12639 2005-08-30 Jb Evain <jbevain@gmail.com>
12641 * attribute.cs: handles as expression in parameters.
12643 2005-08-30 Raja R Harinath <rharinath@novell.com>
12646 * class.cs (TypeContainer.VerifyClsName): Don't use a
12647 PartialContainer when verifying CLS compliance.
12648 (AbstractPropertyEventMethod): Set Parent here, ...
12649 (PropertyMethod): ... not here.
12651 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12653 * attribute.cs : escaped attribute name should not be allowed to be
12654 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12656 2005-08-29 Raja R Harinath <rharinath@novell.com>
12659 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12660 when converting a long constant to unsigned long.
12661 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12662 detect where IsApplicable and VerifyArgumentsCompat disagree.
12664 2005-08-29 Raja R Harinath <rharinath@novell.com>
12665 and Carlos Alberto Cortez <carlos@unixmexico.org>
12668 * class.cs (TypeContainer.CanElideInitializer): New helper.
12669 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12670 can safely emitting the initializer of a field.
12672 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12674 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12675 allowed inside a switch (without loop). Fixed bug #75433.
12677 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12679 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12680 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12682 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12684 * driver.cs : kinda reverting the default encoding changes (not exact
12685 revert since I noticed that "codepage:reset" might not work fine).
12687 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12689 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12690 Location. Now getter and setter store location correctly.
12691 (errors/cs0111-12.cs now reports the expected location.)
12693 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12695 * driver.cs : Use default encoding on the environment.
12696 Removed (now that) extra parameter for SeekableStreamReader.
12697 * support.cs : (SeekableStreamReader) third .ctor() argument for
12698 StreamReader is not required (always true). preamble size could
12699 be acquired in simpler and safe way.
12701 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12703 * cs-parser.jay: report CS0642 at warning level 3
12704 and report CS0642 for an if else statement also
12705 fixes bug #74745. Patch by John Luke (and a bit
12707 Removed extra CS0642 warning check for "while",
12709 * statement.cs: In Block.Resolve(), CS0642 check
12710 is reimplemented to check a sequence of an empty
12711 statement and a block.
12713 Both fix bug #66777.
12715 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12717 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12718 detection until I fix it.
12720 * cs-tokenizer.cs: Changed error message.
12722 * cs-parser.jay: Fixed 2 error locations.
12724 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12725 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12728 * enum.cs (GetSignatureForError): Fixed.
12730 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12734 * typemanager.cs (RegisterProperty): Removed.
12736 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12738 2005-08-24 Raja R Harinath <rharinath@novell.com>
12741 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12742 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12744 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12746 * expression.cs : tiny fix is required for not warning positive ulong.
12749 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12751 * expression.cs : add CS0652 check for constant and integral
12752 expression. Fixed bug #53974.
12754 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12756 * expression.cs : in DoNumericPromotions(), check if there is implicit
12757 conversion overload for string (to check CS0034). Fixed bug #52492.
12759 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12761 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12763 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12765 * ecore.cs : report location when it is *not* Null.
12767 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12773 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12774 correctly. Fixed bug #75721.
12776 2005-08-23 Raja R Harinath <rharinath@novell.com>
12778 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12779 loop that performs 'min (pos, char_count)'.
12782 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12783 converted value in Operator.OnesComplement.
12785 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12787 * anonymous.cs: If the anon method is pulled into a helper class,
12788 it needs to be `internal' not `private'. Fixes runtime behavior on
12791 2005-08-20 Martin Baulig <martin@ximian.com>
12793 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12794 scope if we don't already have it.
12796 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12797 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12800 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12803 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12804 is a partial class.
12806 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12808 The big constants rewrite
12809 Fix #75746, #75685 and more
12810 As a side effect saved 1MB for MWF ;-)
12812 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12813 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12814 enum based for corlib compilation.
12816 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12819 * class.cs (FixedField.Define): Use ResolveAsConstant.
12821 * const.cs (IConstant): Interface constants and enums.
12822 (Const.ResolveValue): New method for constant resolvning.
12823 (ExternalConstant): Constants from imported assemblies.
12825 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12826 conversion; like enums.
12827 (Constant.ToType): Converts this constant to different type.
12828 (Constant.Increment): Adds 1.
12830 * convert.cs (ImplicitConversionRequired): Simplified.
12832 * cs-parser.jay: Create EnumMember directly.
12834 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12836 * doc.cs (GenerateEnumDocComment): Removed.
12838 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12839 (ConvertIntLiteral): Removed.
12840 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12842 * enum.cs (EnumMember): Implement IConstant.
12843 (Enum.IsValidEnumConstant): Removed.
12844 (Enum.GetNextDefaultValue): Removed.
12845 (Enum.FindMembers): Updated.
12846 (Enum.GenerateDocComment): Iterate enum members.
12848 * expression.cs (Cast.TryReduce): Handle enums correctly.
12849 (New.Constantify): Made public.
12850 (MemberAccess.DoResolve): Removed contant specific if(s).
12852 * literal.cs (NullLiteral): Implement new abstract methods.
12854 * statement.cs (GotoCase.Resolve): Use new constant methods.
12855 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12857 * typemanager.cs (LookupEnum): Removed.
12858 (IsEnumType): Fixed to work with corlib.
12859 (RegisterConstant): Removed.
12860 (LookupConstant): Removed.
12861 (GetConstant): Changed to work with IConstant.
12863 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12865 * location.cs : Fixed overflown (>255) column number.
12867 2005-08-03 Raja R Harinath <rharinath@novell.com>
12869 First cut of the qualified-alias-member feature.
12870 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12872 * cs-parser.jay (DOUBLE_COLON): New token.
12873 (namespace_or_type_name): Add rule for recognizing
12874 qualified-alias-members.
12875 (primary_expression): Likewise.
12876 (element_access): Allow QualifiedAliasMember as a possible
12877 type-bearing expression.
12878 (local_variable_type, local_variable_pointer_type): Likewise.
12879 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12880 aliases in the current and enclosing namespace declarations.
12881 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12882 * decl.cs (MemberName.is_double_colon): New.
12883 (MemberName.MemberName): Add new constructor for alias-member.
12884 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12885 * expression.cs (QualifiedAliasMember): New expression type.
12887 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12889 * location.cs : it borked when no argument was specified.
12891 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12893 * location.cs : tiny ToString() format fix.
12895 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12897 * statement.cs : oops, it was missing.
12899 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12901 A set of fixes for precise line/column location.
12904 "token" field now holds a file/line "delta", a line number offset
12905 from the segment, and a column number. See also:
12906 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12907 December/009508.html
12908 Removed static IsNull. Use instance IsNull property instead.
12909 * cs-tokenizer.cs :
12910 For some tokens it stores Location. For Identifier it stores
12911 LocatedToken which is a pair of string name and location.
12912 Column numbers are adjusted only at getChar().
12914 Use Location.ToString() for reporting (it now contains column).
12916 Largely modified to use LocatedToken instead of
12917 string (IDENTIFIER), and to acquire Location from some tokens.
12918 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12919 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12921 Now MemberName holds Location. DeclSpace.ctor() receives Location
12922 as a parameter. Removed extra parameters to all derived classes.
12923 Replaced Location.IsNull() with instance property.
12924 * assign.cs, expression.cs :
12925 Added .ctor() overload that omits Location.
12927 Added "nameEscaped" flag that indicates the identifier was escaped
12928 in the source file. This fixes bug #57047.
12930 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12932 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12933 New method, looking for lo-case imported cls type.
12935 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12938 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12940 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12942 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12943 all_imported_types.
12944 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12946 Optimized to save 3.5 MB for SWF compilation.
12948 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12950 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12951 (PartialContainer.Create): Moved logic AddToContainer.
12952 (PartialContainer.MarkForDuplicationCheck): Shares name.
12954 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12957 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12959 (Namespace.GetSignatureForError): New method.
12961 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12962 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12964 2005-08-01 Raja R Harinath <rharinath@novell.com>
12967 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12968 member lookup rather than qualifier_type, since qualifier_type can
12971 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12973 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12976 2005-07-31 Miguel de Icaza <miguel@novell.com>
12978 * statement.cs: Copy the local exception into the exception
12979 captured local. Fixes 75674
12981 2005-07-31 Raja R Harinath <harinath@gmail.com>
12984 * expression.cs (Invocation.OverloadResolve): Don't report error
12985 CS1501 if error CS1502 has been reported.
12986 (New.DoResolve): Delegate CS1501 reporting to
12987 Invocation.OverloadResolve.
12990 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12991 invariant-meaning-in-block property in an enclosing block if
12994 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12996 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12997 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12998 (Switch.CheckSwitch): Just save 50kb for SWF.
13000 2005-07-27 Martin Baulig <martin@ximian.com>
13002 * anonymous.cs (CaptureContext.AddField): Added
13003 `AnonymousContainer am' argument; compute its toplevel scope if
13004 it's not already computed. Fixes #75649.
13006 2005-07-26 Raja R Harinath <rharinath@novell.com>
13009 * class.cs (Constructor.Emit): Reset block to null if the block
13012 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13014 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
13016 2005-07-25 Marek Safar <marek.safar@seznam.cz>
13018 * class.cs (MethodData.Define): Check whether accessor implementing
13019 interface is public.
13021 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
13023 2005-07-22 Marek Safar <marek.safar@seznam.cz>
13026 * namespace.cs (LookupType): Moved same type check to...
13028 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
13029 with the same name.
13031 2005-07-21 Raja R Harinath <rharinath@novell.com>
13033 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
13034 already found a typebuilder.
13035 * class.cs (MethodCore.IsDuplicateImplementation): Compare
13036 MemberNames, not strings.
13038 * const.cs (Error_ExpressionMustBeConst):
13039 Rename from Error_EpressionMustBeConst.
13040 * const.cs, class.cs, statement.cd: Update.
13042 2005-07-21 Marek Safar <marek.safar@seznam.cz>
13046 * const.cs (Const.LookupConstantValue): Report missing contant expression
13048 (Error_EpressionMustBeConstant): Only one error method.
13050 * class.cs, statement.c: Updated.
13052 2005-07-20 Raja R Harinath <rharinath@novell.com>
13054 * statement.cs (Block.Flags): Add back HasVarargs.
13055 (Block.flags): Make protected.
13056 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
13058 * typemanager.cs (types, typecontainers, user_types): Remove.
13059 (UserTypes, TypeContainers): Likewise.
13060 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
13061 (CleanUp, Reset): Update.
13062 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
13063 (GetNestedType): Use Type.GetNestedType.
13064 (CoreLookupType): Take two arguments, the namespace and the
13065 basename of the type. Update to use the Namespace.Lookup
13067 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
13068 (RealMemberLookup): Use IsNestedChildOf instead of playing with
13069 string concatenation and substring matches.
13070 * class.cs, enum.cs, delegate.cs: Update to changes.
13072 2005-07-20 Marek Safar <marek.safar@seznam.cz>
13074 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
13075 Expression and made virtual.
13077 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
13078 (ImplicitStandardConversionExists): Fixed `byte' typo ?
13080 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
13082 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
13085 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
13088 2005-07-18 Marek Safar <marek.safar@seznam.cz>
13091 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
13092 AssemblyCultureAttribute is not used on executable.
13095 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
13097 2005-07-16 Raja R Harinath <rharinath@novell.com>
13100 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
13101 New. Reports CS0252/CS0253.
13102 Mostly taken from preliminary patch by Duncak Mak.
13103 (Binary.DoResolveOperator): Store results of operator lookup.
13104 Use them to detect if we need to warn about unintended reference
13107 2005-07-15 Raja R Harinath <rharinath@novell.com>
13110 * namespace.cs (Namespace.Lookup): Add back location parameter.
13111 (Namespace.LookupType): Add CS0436 report. Add location parameter.
13112 * delegate.cs, ecore.cs, expression.cs: Update to changes.
13114 * codegen.cs (EmitContext.DeclSpace): Make readonly.
13115 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
13116 (Namespace.LookupType): ... this.
13117 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
13119 * typemanager.cs (LookupTypeReflection): Remove buggy code that
13120 purported to handle pointers.
13121 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
13124 2005-07-15 Marek Safar <marek.safar@seznam.cz>
13126 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
13129 2005-07-15 Raja R Harinath <rharinath@novell.com>
13131 * namespace.cs (Namespace.Lookup): Drop location parameter.
13132 (NamespaceEntry.LookupAlias): Remove. Merge into ...
13133 (NamespaceEntry.Lookup): ... this.
13134 (NamespaceEntry.Error_AmbiguousTypeReference):
13135 Move here from DeclSpace.
13136 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
13138 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
13139 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
13140 Move to NamespaceEntry.
13141 * delegate.cs, expression.cs: Update to changes.
13143 2005-07-14 Marek Safar <marek.safar@seznam.cz>
13145 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
13146 CheckAttributeType and refactored.
13147 (Attribute.ResolvePossibleAttributeType): Changed to reuse
13148 ResolveAsTypeTerminal error handling.
13149 (ResolveAsTypeTerminal): Introduced because of global attributes extra
13151 (GetSignatureForError): Print errors in same way.
13154 * codegen.cs: Reflect attribute GetSignatureForError change.
13157 * expression.cs: Add silent parameter to ResolveAsTypeStep.
13159 * namespace.cs (UsingEntry): Refactored to make fields private.
13162 statement.cs: Error_UnexpectedKind has extra parameter.
13164 2005-07-14 Raja R Harinath <rharinath@novell.com>
13166 * ecore.cs (IAlias): Remove.
13167 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
13168 that implement the interface.
13169 * namespace.cs (Namespace): Likewise.
13170 (Namespace.declspaces): Renamed from 'defined_names'.
13171 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
13172 DeclSpace instead of an IAlias.
13173 * tree.cs (Tree.AddDecl): Update.
13175 2005-07-12 Raja R Harinath <rharinath@novell.com>
13177 * statement.cs (Block.Flags); Remove HasVarargs.
13178 (Block.HasVarargs): Move to ToplevelBlock.
13179 (Block.ThisVariable, Block.AddThisVariable): Likewise.
13180 (Block.Variables): Make protected. Initialize variable hashtable
13182 (Block.AddVariable): Update.
13183 (Block.Resolve): Update to changes.
13184 (ToplevelBlock.HasVarargs): New boolean.
13185 (ToplevelBlock.ThisVariable): Move here from Block.
13186 (ToplevelBlock.AddThisVariable): Likewise.
13187 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
13188 * expression.cs (This.ResolveBase): Update to changes.
13189 (ArglistAccess.DoResolve): Likewise.
13191 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13194 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
13196 * class.cs (TypeContainer.VerifyMembers): Distinguish between
13197 not used and not used & assigned.
13198 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
13200 2005-07-11 Marek Safar <marek.safar@seznam.cz>
13203 * expression.cs (Is.DoResolve): null is never provided type.
13205 2005-07-08 Marek Safar <marek.safar@seznam.cz>
13208 * cs-parser.jay: Less strict event error rule to catch more errors.
13210 2005-07-08 Martin Baulig <martin@ximian.com>
13212 Fix test-iter-10.cs - distinguish whether we `yield' in a property
13213 gettter (allowed) or setter (not allowed).
13215 * class.cs (Accessor): Implement IIteratorContainer.
13216 (Accessor.Yields): New public field.
13217 (PropertyBase.PropertyMethod.Define): Handle iterators on a
13218 per-accessor basis.
13221 (get_accessor_declaration, set_accessor_declaration): Set the
13222 `yields' flag on the accessor, not the property.
13223 (property_declaration): Do the iterators check on a per-accessor
13224 basis and not for the whole property.
13226 2005-07-08 Martin Baulig <martin@ximian.com>
13228 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
13229 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
13231 2005-07-07 Marek Safar <marek.safar@seznam.cz>
13234 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
13235 (ExtractSecurityPermissionSet): Cope with self referencing security
13236 attributes properly.
13238 * driver.cs (SetOutputFile): Made public property OutputFile.
13240 2005-07-07 Raja R Harinath <rharinath@novell.com>
13243 * class.cs (TypeContainer.first_nonstatic_field): Rename from
13244 has_nonstatic_fields. Make into a FieldBase pointer.
13245 (TypeContainer.AddField): Add CS0282 check.
13246 (TypeContainer.EmitType): Update.
13248 2005-07-06 Miguel de Icaza <miguel@novell.com>
13250 * cs-tokenizer.cs (consume_identifier): Do not create strings to
13251 compare if they start with __.
13253 2005-07-06 Raja R Harinath <rharinath@novell.com>
13255 * statement.cs (Switch.SwitchGoverningType): Only look at
13256 UserCasts that don't need implicit standard conversions to one of
13257 the allowed switch types (Fixes test-322.cs).
13258 (LocalInfo.Resolve): Re-enable sanity-test.
13260 2005-07-06 Marek Safar <marek.safar@seznam.cz>
13262 * cs-tokenizer.cs (consume_identifier): Detect double undescores
13264 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
13266 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
13268 2005-07-06 Raja R Harinath <rharinath@novell.com>
13271 * ecore.cs (SimpleName.GetSignatureForError): Add.
13272 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
13273 (MemberAccess.GetSignatureForError): Add.
13275 2005-07-05 Marek Safar <marek.safar@seznam.cz>
13277 The big error and warning messages review.
13307 * typemanager.cs: Updated.
13309 * class.cs: (MethodCore.SetYields): Moved here to share.
13310 (PropertyMethod.Define): Moved iterator setup here.
13312 * iterators.cs: Add orig_method to have full access to parent
13315 2005-07-05 Raja R Harinath <rharinath@novell.com>
13317 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
13318 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
13319 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
13320 variable of struct type.
13321 * expression.cs (Unary.ResolveOperator): Update to change.
13322 (Indirection.VerifyFixed): Likewise.
13323 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
13324 (ParameterReference.VerifyFixed): Value parameters are fixed.
13325 (This.VerifyFixed): Treat 'this' as a value parameter.
13326 * statement.cs (LocalInfo.IsFixed): Remove.
13328 2005-07-01 Martin Baulig <martin@ximian.com>
13330 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
13331 `ec.EmitThis ()' to get the correct scope.
13333 2005-07-01 Martin Baulig <martin@ximian.com>
13335 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
13336 instance is a ParameterReference; fixes #75299.
13338 2005-07-01 Martin Baulig <martin@ximian.com>
13340 Reverted Marek's latest patch (r46725):
13341 - it contains structural changes which are neither mentioned in
13342 the ChangeLog nor explained anywhere; for example the additional
13343 argument of EmitContext's and Iterator's .ctor's and the
13344 TypeContainer.DefineMembers() change.
13345 - structural changes like this should go in in seperate patches
13346 and not be hidden in a huge patch which just seems to affect
13347 warnings and errors.
13348 a big and hard to understand patch.
13349 - it breaks iterators and causes regressions, for instance in
13352 2005-06-30 Raja R Harinath <rharinath@novell.com>
13355 * expression.cs (Indexers.map): Remove.
13356 (Indexers.Append): Filter out inaccessible setters and getters.
13357 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
13360 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
13361 Refactored from ...
13362 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
13363 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13364 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13365 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13367 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13370 * class.cs (FieldBase.GetInitializerExpression): One more field
13373 2005-06-28 Miguel de Icaza <miguel@novell.com>
13375 * pending.cs: Do not define a proxy if the base method is virtual,
13376 it will be picked up by the runtime (bug 75270).
13378 2005-06-08 Martin Baulig <martin@ximian.com>
13380 The big Iterators rewrite :-)
13382 * iterators.cs: Rewrite this to use the anonymous methods framework.
13384 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13385 before the TypeContainers; see 2test-21.cs.
13388 (TypeContainer.DefineType): Don't create a new EmitContext if we
13389 already have one (this only happens if we're an Iterator).
13390 (TypeContainer.Define): Also call Define() on all our iterators.
13391 (Method.CreateEmitContext): Added support for iterators.
13394 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13395 (AnonymousContainer.CreateMethodHost): Moved here from
13396 AnonymousMethod and made abstract.
13397 (AnonymousContainer.CreateScopeType): New abstract method.
13398 (AnonymousContainer.IsIterator): New public property.
13399 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13400 get the ScopeTypeBuilder rather than manually defining it here.
13401 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13404 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13405 before RootContext.DefineTypes().
13407 * codegen.cs (EmitContext.RemapToProxy): Removed.
13408 (EmitContext.CurrentAnonymousMethod): Changed type from
13409 AnonymousMethod -> AnonymousContainer.
13410 (EmitContext.ResolveTopBlock): Protect from being called twice.
13411 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13412 (EmitContext.EmitThis): Removed the iterators hacks; use the
13413 anonymous methods framework for that.
13416 (ToplevelBlock.Container): Make this a property, not a field.
13417 (ToplevelBlock.ReParent): New public method; move the
13418 ToplevelBlock into a new container.
13419 (Foreach.TemporaryVariable): Simplify.
13421 2005-06-05 Martin Baulig <martin@ximian.com>
13423 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13424 (Block.AddTemporaryVariable): New public method; creates a new
13425 `LocalInfo' for a temporary variable.
13426 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13428 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13429 non-iterator variables.
13431 2005-06-05 Martin Baulig <martin@ximian.com>
13433 * statement.cs (Foreach.TemporaryVariable): Create the
13434 LocalBuilder in the Emit phase and not in Resolve since in some
13435 situations, we don't have an ILGenerator during Resolve; see
13436 2test-19.cs for an example.
13438 2005-06-04 Martin Baulig <martin@ximian.com>
13440 **** Merged r45395 from GCS ****
13442 The big Foreach rewrite - Part II.
13444 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13445 with `PropertyInfo ienumerator_getcurrent'.
13447 * codegen.cs (VariableStorage): Removed.
13450 (Foreach): Derive from Statement, not ExceptionStatement.
13451 (Foreach.CollectionForeach): New nested class. Moved all the code
13452 dealing with collection foreach here.
13453 (Foreach.ForeachHelperMethods): Removed.
13454 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13456 2005-05-23 Martin Baulig <martin@ximian.com>
13458 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13459 don't need to. Fix #75014.
13461 2005-05-20 Martin Baulig <martin@ximian.com>
13463 Merged r44808 from GMCS.
13465 * class.cs (TypeContainer.CircularDepException): Removed.
13466 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13467 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13468 (CS0146) and interface (CS0529) dependencies here.
13470 2005-06-21 Raja R Harinath <rharinath@novell.com>
13472 * expression.cs (Invocation.EmitCall): Fix initialization
13473 'this_call' to reflect current behaviour. Fix indentation.
13475 * convert.cs (FindMostEncompassedType): Add two trivial special
13476 cases (number_of_types == 0 || number_of_types == 1).
13477 (FindMostEncompasingType): Likewise.
13479 2005-06-17 Raja R Harinath <rharinath@novell.com>
13481 Some cleanups preparing for the fix of #75283.
13482 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13484 (EventExpr.InstanceResolve): Likewise.
13485 (EventExpr.DoResolve): Remove redundant checks.
13487 2005-06-10 Duncan Mak <duncan@novell.com>
13489 * cs-tokenizer.cs (process_directives): New flag for controlling
13490 the processing of preprocessor directives.
13491 (x_token): After seeing a '#', return Token.NONE instead of going
13492 to handle_preprocessing_directive() when not processing
13493 directives. This avoids unnecessary processing during the token peek in
13498 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13499 the existing error reporting methods instead of Report.Error.
13501 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13502 after Raja's rewrite.
13504 2005-06-08 Miguel de Icaza <miguel@novell.com>
13506 * class.cs: Small fix.
13508 2005-06-08 Raja R Harinath <rharinath@novell.com>
13511 * class.cs (GetPartialBases): Fix return value check of
13512 part.GetClassBases.
13514 2005-06-07 Raja R Harinath <rharinath@novell.com>
13516 Ensure that partial classes are registered in their enclosing
13517 namespace. Initial part of fix of #75160.
13518 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13519 Register declspace with namespace here, not in
13520 DeclSpace.RecordDecl.
13521 * cs-parser.jay: Pass namespace to RecordDecl.
13522 * class.cs (PartialContainer.Create): Likewise.
13523 (ClassPart.DefineType): New sanity-check. Throws an exception if
13525 * decl.cs (Declspace.RecordDecl): Remove.
13526 * namespace.cs (NamespaceEntry.DefineName): Remove.
13528 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13530 * rootcontext.cs: Reset TargetExt as well.
13532 2005-06-03 Raja R Harinath <rharinath@novell.com>
13534 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13535 -langversion:ISO-1.
13537 2005-06-02 Raja R Harinath <rharinath@novell.com>
13539 Fix #75080, cs0119.cs.
13540 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13542 (Expression.Resolve): ... this. Use it. Remove bogus code
13543 allowing ExprClass.Type and ExprClass.Namespace for
13544 ResolveFlags.VariableOrValue.
13545 (Expression.Resolve) [1-argument variant]: Change default resolve
13546 flags based on language version.
13547 (Expression.Error_UnexpectedKind): Use a simple string array
13548 rather than an ArrayList.
13549 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13550 not ExprClass.Type.
13551 (TypeOfVoid.DoResolve): Likewise.
13552 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13553 flags argument -- it always has the same value.
13555 2005-05-31 Raja R Harinath <rharinath@novell.com>
13558 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13559 Use it in the error message.
13560 * assign.cs, expression.cs, statement.cs: Update.
13562 2005-05-30 Raja R Harinath <rharinath@novell.com>
13565 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13566 the "almostMatchedMember" case too.
13567 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13568 that failed the accessibility checks to 'almost_match'.
13570 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13572 * attribute.cs: Use internal MethodBuilder methods to set
13573 ExactSpelling and SetLastError on PInvoke methods, instead
13574 of passing them via charset. Fixes #75060.
13576 2005-05-27 Raja R Harinath <rharinath@novell.com>
13578 * parameter.cs (Parameter): Remove TODO comment.
13579 (Parameter.DefineParameter): Remove Location parameter.
13580 (Parameters.LabelParameters): Likewise.
13581 * class.cs (Constructor.Emit): Update to change.
13582 (MethodData.Emit): Likewise.
13583 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13584 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13586 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13589 Removed Parameters.Location and added Parameter.Location instead.
13590 Removed Location parameter from Emit() and GetSignature().
13597 Modified all related calls.
13599 2005-05-26 Raja R Harinath <rharinath@novell.com>
13601 Improve user-defined conversion handling.
13602 * convert.cs (GetConversionOperators): Rewrite. Return only the
13603 applicable operators.
13604 (AddConversionOperators): New. Helper for GetConversionOperators.
13605 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13606 there is only one most encompassed/encompassing type.
13607 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13608 "applicable operator" handling.
13609 (UserConversion): Move cache here from GetConversionOperators.
13610 Directly cache the chosen operator, rather than the whole
13612 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13613 case. Allow conversion of decimal to sbyte and byte too.
13614 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13615 New static methods. Used to avoid allocating EmptyExpressions in
13618 2005-05-24 Duncan Mak <duncan@novell.com>
13620 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13621 another class, used in Convert.ExplicitNumericConversion.
13622 (CastToDecimal): New class, similar to above, but casts to
13623 System.Decimal, used in Convert.ImplicitNumericConversion and also
13624 in explicit convesion from double/float to decimal.
13626 * convert.cs (ImplicitNumericConversion): Handle implicit
13627 conversions to System.Decimal.
13628 (ExplicitNumericConversion): handle explicit conversions to
13633 2005-05-20 Miguel de Icaza <miguel@novell.com>
13635 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13636 know the type at this stage, just break through. Fixes #75008
13638 2005-05-19 Martin Baulig <martin@ximian.com>
13641 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13642 to disable error reporting.
13644 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13645 here since we don't want to report an error; see the new test-336.cs.
13647 2005-05-19 Raja R Harinath <rharinath@novell.com>
13649 * statement.cs (ToplevelBlock.GetParameterReference)
13650 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13651 Move here from class Block.
13652 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13653 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13655 2005-05-18 Martin Baulig <martin@ximian.com>
13660 (FlowBranching.Reachability): Add non-static public And() and Or()
13662 (FlowBranchingSwitch): New class; do the `break_origins' thing
13663 like in FlowBranchingLoop.
13664 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13665 reachability, not just locals and parameters.
13666 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13667 switch; MergeBreakOrigins() now takes care of that.
13669 2005-05-18 Martin Baulig <martin@ximian.com>
13671 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13672 a loop and may leave it, reset the barrier; fixes #74974.
13674 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13676 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13679 * cs-parser.jay: Catch more lexical errors.
13681 * report.cs: Add one more Error method.
13684 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13686 2005-05-17 Martin Baulig <martin@ximian.com>
13688 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13691 2005-05-16 Raja R Harinath <rharinath@novell.com>
13693 Fix test-382.cs. Emit values of decimal constants.
13694 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13696 (TypeContainer.AddField): ... this.
13697 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13698 with initializers to include 'Const's.
13699 (ClassPart.RegisterFieldForInitialization): Forward to
13701 * const.cs (Const.Const): Pass initializer to base class.
13702 (Const.Define): In case of decimal constants, register them for
13703 initialization in a static constructor.
13705 2005-05-14 Martin Baulig <martin@ximian.com>
13707 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13708 do not call ResolveUnreachable() on unreachable statements in
13709 here, see the comment in the source code.
13711 2005-05-13 Raja R Harinath <rharinath@novell.com>
13714 * expression.cs (BinaryResolveOperator): If one of the operands of
13715 an equality comparison is 'null' and the other is a pointer type,
13716 convert the null to a NullPointer.
13717 * convert.cs (ImplicitReferenceConversion): If the expression is a
13718 NullLiteral and the target type is a pointer type, return a
13719 NullPointer instead.
13720 (ImplicitConversionStandard): Likewise.
13722 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13724 * cs-parser.jay: Set readonly context based on special constructs.
13726 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13727 readonly variable error handling.
13729 * rootcontext.cs (EmitCode): Don't verify members when error
13732 * statement.cs (LocalInfo): Add reaodnly context information.
13733 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13735 2005-05-13 Raja R Harinath <rharinath@novell.com>
13737 * statement.cs (Block.Resolve): Revert change below. Modify fix
13738 for #74041 to initialize 'resolved' to false only for explicit
13739 blocks. Fixes #74873.
13741 2005-05-12 Raja R Harinath <harinath@gmail.com>
13744 * typemanager.cs (unmanaged_enclosing_types): New.
13745 (IsUnmanagedType): Avoid infloops by using
13746 'unmanaged_enclosing_types' to talk with recursive invocations.
13748 2005-05-13 Martin Baulig <martin@ximian.com>
13750 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13751 instance variable, not a local. Fix #74873.
13752 (Block.ResolveUnreachable): Set it to true here.
13754 2005-05-11 Duncan Mak <duncan@novell.com>
13756 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13757 continuing to process for 'arg'.
13758 (handle_preprocessing_directive): Check the argument of the #endif
13759 directive and report error CS1025 if there are any trailing
13762 According to the C# spec, having even whitespace after the #endif
13763 directive is illegal; however, because we call arg.TrimEnd ()
13764 beforehand, we have the same behavior as csc, allowing whitespace
13765 after the directive.
13769 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13773 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13774 (Constructor.GetObsoleteAttribute): Implemented correctly.
13776 2005-05-10 Martin Baulig <martin@ximian.com>
13778 * support.cs (ReflectionParameters.ParameterModifier): Use
13779 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13780 and `ParameterAttributes.In'. Fixes #74884.
13782 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13784 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13786 * expression.cs (Argument.GetParameterModifier): Turned to property.
13787 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13789 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13792 2005-05-09 Raja R Harinath <rharinath@novell.com>
13795 * decl.cs (MemberCache.AddMethods): Register override methods,
13796 rather than non-override methods.
13797 * typemanager.cs (RegisterOverride): New.
13798 (IsOverride): Update.
13800 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13804 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13805 recursive declaration.
13807 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13809 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13811 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13813 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13815 2005-05-05 Raja R Harinath <rharinath@novell.com>
13818 * decl.cs (DeclSpace.FamilyAccessible):
13819 Use TypeManager.IsNestedFamilyAccessible.
13821 Fix reopened #64812.
13822 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13825 2005-05-04 Raja R Harinath <rharinath@novell.com>
13826 Abin Thomas <projectmonokochi@rediffmail.com>
13827 Anoob V E <projectmonokochi@rediffmail.com>
13828 Harilal P R <projectmonokochi@rediffmail.com>
13831 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13832 allow access to all static members.
13834 2005-05-04 Martin Baulig <martin@ximian.com>
13836 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13838 2005-05-04 Martin Baulig <martin@ximian.com>
13842 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13843 section at the end; make things work if `default' is not the last
13846 2005-05-04 Martin Baulig <martin@ximian.com>
13850 * statement.cs (Switch): Replaced the `got_default' field with a
13851 `default_section' one.
13852 (Switch.CheckSwitch): Set `default_section' here.
13853 (Switch.Resolve): If we're a constant switch and the constant is
13854 not found, use the default section.
13856 2005-05-03 Martin Baulig <martin@ximian.com>
13858 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13860 * statement.cs (Foreach.ArrayForeach): New nested class.
13861 (Foreach.TemporaryVariable): New nested class.
13862 (Foreach.EmitArrayForeach): Removed; this is now in the new
13863 ArrayForeach class.
13865 2005-05-03 Raja R Harinath <rharinath@novell.com>
13867 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13869 (VerifyPendingMethods): Revert change below.
13871 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13872 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13873 that used to trigger warning -28. Remove warning -28.
13874 * expression.cs (Invocation.OverloadResolve): Use
13875 TypeManager.IsOverride to distinguish override methods.
13878 * pending.cs (VerifyPendingMethods): If a base type implements the
13879 requested interface, don't bother checking individual methods of
13880 the base type. As a side-effect, this prevents the creation of
13881 unnecessary proxies.
13883 2005-05-02 Martin Baulig <martin@ximian.com>
13887 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13888 Also `And' the locals if the old vector is null.
13889 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13890 null; in this case we basically reset all the variables.
13892 2005-05-02 Martin Baulig <martin@ximian.com>
13896 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13897 Added `FlowBranching branching' argument; always `and' the
13898 variables instead of `or'ing them unless we're an infinite loop.
13900 * statement.cs (While.Resolve): Create a new sibling unless we're
13903 2005-05-02 Martin Baulig <martin@ximian.com>
13907 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13908 arguments; use it instead of creating a new TopLevelBlock.
13909 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13910 our ConstructorInitializer.
13913 (TopLevelBlock.TopLevelBranching): New public property.
13914 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13915 and create our `TopLevelBranching'.
13917 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13918 anonymous method host, use `block.TopLevelBranching' rather than
13919 creating a new branching.
13921 2005-04-20 Miguel de Icaza <miguel@novell.com>
13923 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13924 a ScopeInfo, if any of the current children is a child of the new
13925 entry, move those children there.
13927 2005-04-30 Martin Baulig <martin@ximian.com>
13929 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13930 at the beginning of a SwitchSection. Fix #73335.
13932 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13935 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13937 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13938 (FieldExpr.DoResolve): Obsolete members are ignored for field
13941 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13943 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13944 of arrays detection.
13946 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13948 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13950 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13953 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13955 * cs-parser.jay: Use the prefered version of -unsafe in error
13958 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13960 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13963 2005-04-20 John Luke <john.luke@gmail.com>
13965 * driver.cs: fix typo in error message, --outout to --output
13967 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13969 * codegen.cs (InRefOutArgumentResolving): New field.
13971 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13972 fields outside contructor.
13974 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13976 2005-04-19 Miguel de Icaza <miguel@novell.com>
13978 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13979 parameter code was not completed ever, so it was not as up-to-date
13980 as local variables. Must finish it.
13982 The bug fix was to compare the Toplevel of the block, not the
13983 current block. Thanks for Ben for pointing this out.
13985 2005-04-19 Raja R Harinath <rharinath@novell.com>
13987 * decl.cs (AddMethods): Use the declaring type of the problem
13988 method to determine if we want to squash a warning.
13990 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13992 * attribute.cs: Removed debug output.
13994 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13996 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13999 2005-04-18 Raja R Harinath <rharinath@novell.com>
14002 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
14003 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
14004 all null comparisons against reference types.
14006 2005-04-18 Marek Safar <marek.safar@seznam.cz>
14009 * class.cs (TypeContainer.CircularDepException) New nested
14011 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
14012 (TypeContainer.DefineType): Removed error, reset InTransit before
14014 (Class.DefineType): Throw exception when is in Transit.
14015 Catch exception and report error.
14016 (Struct.DefineType): Throw exception when is in Transit.
14017 Catch exception and report error.
14018 (Interface.DefineType): Throw exception when is in Transit.
14019 Catch exception and report error.
14021 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
14022 handle nested exception handlers.
14024 * flowanalysis.cs (InTryWithCatch): New method, search for try with
14027 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
14028 InFinally and InCatch storage.
14030 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
14031 (Catch.Resolve): Set and Restore ec.InCatch.
14032 (Try.Resolve): Set and Restore ec.InFinally.
14033 (Try.HasCatch): True when try has catch.
14035 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
14037 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
14038 for the same event member, so exclude such cases from warning 419.
14041 2005-04-16 Miguel de Icaza <miguel@novell.com>
14043 * expression.cs (Binary.ResolveOperator): Apply patch from John
14044 Luke to fix bug 59864: operators &, | and ^ on enumerations
14045 require that the same enum type on both sides.
14047 * driver.cs: Add warnings to old flag usage, this is to assist
14048 people who produce Makefiles and hope that the Makefiles will be
14051 * class.cs (TypeContainer.EmitType): Moved the definition of the
14052 special $PRIVATE$ field from the resolve phase to the Emit phase.
14053 During resolve we do not know if we are a struct with
14054 HasExplicitLayout, we know this only after the attributes for the
14057 Set the FieldOffset to zero on the dummy field that we create for
14058 the class. Fixes 74590.
14060 2005-04-16 Raja R Harinath <rharinath@novell.com>
14063 * ecore.cs (PropertyExpr.resolved): New.
14064 (DoResolve): Use it to handle a case of double resolution here.
14065 Handle a case of identical-name-and-type-name.
14066 * expression.cs (ArrayCreation.CheckIndices): Avoid double
14067 resolution by storing the results of expression resolution back
14068 into the "probes" array.
14070 2005-04-15 Raja R Harinath <rharinath@novell.com>
14072 Fix cs0208-7.cs and cs0208-8.cs.
14073 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
14074 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
14075 error reporting to point out the reason a struct is not unmanaged.
14077 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14079 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
14080 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
14082 2005-04-13 Raja R Harinath <rharinath@novell.com>
14085 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
14086 IdenticalNameAndTypeName here.
14087 (EventExpr.InstanceResolve): Likewise.
14089 2005-04-13 Marek Safar <marek.safar@seznam.cz>
14091 C# 2.0 DefaultCharSetAttribute implementation
14093 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
14094 which allows us to set GlobalNamespace for every resolve.
14095 (Attribute.ResolveArguments): Cut from Resolve.
14096 (Attribute.GetCharSetValue): Returns CharSet named argument.
14097 (Attribute.DefinePInvokeMethod): Gets default charset from
14099 (GlobalAttribute.ResolveAsTypeStep): Override.
14100 (GlobalAttribute.ResolveArguments): Override.
14102 * class.cs (TypeAttr): Is protected.
14104 * codegen.cs (ModuleClass.DefaultCharSet): New member.
14105 (ModuleClass.DefaultCharSetType): New memeber.
14106 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
14108 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
14109 charset from module.
14111 * delegate.cs (TypeAttr): Override.
14112 (Delegate.DefineType): Use this TypeAttr.
14114 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
14115 at very early stage (before types are defined) to resolve model
14116 module attributes. It will probably not work with corlib but it
14119 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
14120 charset from module.
14122 * typemanager.cs (default_charset_type): New type.
14124 2005-04-13 Raja R Harinath <rharinath@novell.com>
14126 * decl.cs (MemberCache.AddMethods): Don't warn if
14127 System.Object.Finalize has buggy MethodAttributes.
14129 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
14132 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14134 * doc.cs : detect ambiguous reference to overloaded members.
14135 Fixed bug #71603. MS 1.1 csc does not detect it.
14137 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
14139 * doc.cs : delegates must not be referenced with parameters.
14142 2005-04-12 Miguel de Icaza <miguel@novell.com>
14144 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
14146 2005-04-10 Miguel de Icaza <miguel@novell.com>
14148 * driver.cs (MainDriver): Stop processing if the CLS stage found
14151 (CompilerCallableEntryPoint.InvokeCompiler): Always
14152 reset after execution; Take a TextWriter argument for the
14155 * report.cs: Use the error stream instead of hardcoding stderr.
14157 2005-04-09 Miguel de Icaza <miguel@novell.com>
14159 * class.cs: Reduce code paths to test, too small of an
14160 optimization to make it worth the extra testing. Always perform
14163 2005-04-08 Raja R Harinath <rharinath@novell.com>
14166 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
14167 operators that had errors reported on them.
14169 2005-04-08 Marek Safar <marek.safar@seznam.cz>
14171 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
14173 (Attribute.Resolve): Add named argument type checking.
14175 * class.cs (FixedField.Define): Use IsPrimitiveType
14177 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
14179 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
14180 unsafe parameter types.
14182 * statement.cs (Using.ResolveExpression): Add better error description.
14184 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
14186 2005-04-08 Raja R Harinath <rharinath@novell.com>
14189 * attribute.cs (Attribute.GetAttributeUsage): Resolve
14190 AttributeUsageAttribute in the emitcontext of the attribute class,
14191 not in the emitcontext of the attributable entity it was attached to.
14192 * cs-parser.jay: Use 'current_class', not 'current_container',
14193 when creating a GlobalAttribute.
14195 2005-04-08 Alp Toker <alp@atoker.com>
14197 * pending.cs: The fix to #58413 failed to compile methods implementing
14198 interfaces with/without params modifiers and vice versa, even though
14199 params modifiers aren't part of the signature. Make the modifier check
14200 less strict as in csc.
14202 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
14203 Anoob V E <projectmonokochi@rediffmail.com>
14204 Harilal P R <projectmonokochi@rediffmail.com>
14207 * pending.cs (TypeAndMethods.mods): New. Store the parameter
14208 modifiers of pending methods.
14209 (PendingImplementation.PendingImplementation): Initialize it.
14210 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
14211 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
14212 with ParameterData. Add check for modifiers.
14213 * class.cs (MethodData.Define): Update to changes.
14215 2005-04-07 Raja R Harinath <rharinath@novell.com>
14217 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
14219 2005-04-07 Marek Safar <marek.safar@seznam.cz>
14221 * class.cs (PropertyMethod.Define): Check private accessor in abstract
14224 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
14227 * typemanager.cs: Registered RequiredAttributeAttribute.
14229 2005-04-06 Marek Safar <marek.safar@seznam.cz>
14231 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
14232 Warning CS0169 is back at level 3.
14233 (IMethodData.SetMemberIsUsed): New method.
14235 * decl.cs (IsUsed): New value; moved from FieldBase.Status
14236 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
14238 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
14240 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
14242 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
14245 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
14248 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
14249 to avoid the problems with nested types.
14251 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
14252 Anoob V.E <projectmonokochi@rediffmail.com>
14253 Harilal P.R <projectmonokochi@rediffmail.com>
14254 Raja R Harinath <rharinath@novell.com>
14257 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
14259 * typemanager (GetConstructor): Make public.
14261 2005-04-05 John Luke <john.luke@gmail.com>
14262 Raja R Harinath <rharinath@novell.com>
14265 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
14266 struct too. Return false quicker in a few cases.
14267 (VerifyUnManaged): Use it.
14269 2005-04-05 Raja R Harinath <rharinath@novell.com>
14272 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
14273 not 'unreachable_seen'.
14275 2005-04-04 Marek Safar <marek.safar@seznam.cz>
14277 * attribute.cs (Attribute.GetValue): Removed unused.
14279 * codegen.cs (CodeGen.TrimExt): Removed unused.
14281 * cs-parser.jay (output): Removed unused.
14283 * cs-tokenizer.cs (hex_digits): Removed unused.
14285 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
14287 * expression.cs (Indirection.LoadExprValue): Removed unused.
14288 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
14290 * iterators.cs (Iterator.param_types): Removed unused.
14292 * statement.cs (Goto.block): Removed unused.
14293 (ToplevelBlock.did): Removed unused.
14294 (Switch.ResolveConstantSwitch): Removed unused.
14296 2005-04-01 Ben Maurer <bmaurer@ximian.com>
14298 * rootcontext.cs: Allow mcs to bootstrap with the compilation
14301 2005-04-01 Raja R Harinath <rharinath@novell.com>
14303 Fix #74232 and cs0208-3.cs.
14304 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
14305 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
14306 unmanaged type. Don't use FieldBuilders when 't' is a
14307 TypeBuilder. Use ModFlags and MemberType fields.
14308 * class.cs (MemberBase.member_type): Rename from MemberType.
14309 (MemberBase.MemberType): New property. Determines member_type on
14311 (MemberBase.DoDefine): Don't initialize MemberType here.
14312 (FieldMember.Define): Likewise.
14314 2005-04-01 Marek Safar <marek.safar@seznam.cz>
14317 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
14318 Attributes are emitted there.
14320 2005-04-01 Raja R Harinath <rharinath@novell.com>
14322 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
14323 keyword in 'partial enum' too.
14324 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
14326 Report from Kamil Skalski <nazgul@omega.pl>.
14329 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
14330 have partial containers too.
14332 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
14333 in block' checks to Block.CheckInvariantMeaningInBlock.
14334 * statement.cs (Block.GetKnownVariableInfo): Make private.
14335 (Block.IsVariableUsedInChildBlock): Remove.
14336 (Block.IsVariableUsedInBlock): Likewise.
14337 (Block.CheckInvariantMeaningInBlock): New. Show location of
14338 conflicting declaration.
14339 (Block.AddVariable): Make error messages less long-winded and more
14340 specific. Show location of conflicting declaration.
14341 * parameter.cs (Parameters.Location): New readonly property.
14343 2005-03-31 Raja R Harinath <rharinath@novell.com>
14345 Clean up semantics of invoking ResolveMemberAccess.
14346 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
14347 can have an instance, ensure that we pass in a non-TypeExpression
14348 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
14349 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
14350 argument. Update to changes and simplify.
14351 (FieldExpr.Emitinstance): Remove CS0120 check.
14352 (PropertyExpr.EmitInstance): Likewise.
14353 * expression.cs (Argument.Resolve): Likewise.
14354 (Invocation.DoResolve): Update to changes in semantics of
14355 InstanceExpression.
14357 2005-03-31 Marek Safar <marek.safar@seznam.cz>
14360 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
14363 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14365 2005-03-31 Raja R Harinath <rharinath@novell.com>
14367 Fix difference in behaviour with commandline invocation.
14368 * driver.cs (Driver.Reset): New.
14369 (CompilerCallableEntryPoint): Call it.
14371 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14372 variable" warnings if the boolean expression failed to resolve.
14374 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14376 * attribute.cs: Fix the union of several permissions when some of them
14377 are unrestricted (so the result isn't an unrestricted permission set).
14380 2005-03-30 Raja R Harinath <rharinath@novell.com>
14382 * ecore.cs (MemberExpr): New class. Convert from interface
14384 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14385 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14387 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14388 (MethodGroupExpr.IsExplicitImpl): Remove.
14389 (Expression.GetFieldFromEvent): Remove.
14390 (SimpleName.MemberStaticCheck): Remove.
14391 (SimpleName.DoSimpleNameResolve): Update to changes.
14392 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14393 (MemberAccess.IdenticalNameAndTypeName): Remove.
14394 (MemberAccess.error176): Move to MemberExpr.
14395 (MemberAccess.DoResolve): Update to changes.
14396 (BaseAccess.DoResolve): Likewise.
14398 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14400 C# 2.0 Conditional attribute class implementation
14402 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14403 Analyzes class whether it has attribute which has ConditionalAttribute
14404 and its condition is not defined.
14406 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14407 (Class.IsExcluded): New method. Search for at least one defined
14408 condition in ConditionalAttribute of attribute class.
14410 2005-03-30 Raja R Harinath <rharinath@novell.com>
14412 * ecore.cs (PropertyExpr): Derive from Expression, not
14413 ExpressionStatement.
14414 (PropertyExpr.EmitStatement): Remove.
14416 2005-03-29 Raja R Harinath <rharinath@novell.com>
14419 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14420 internal field "value__" of an enum be private. The examples for
14421 "value__" that I found on MSDN all used FieldAttributes.Private.
14423 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14424 Don't mention IL method attribute names.
14426 Fix #47991. Remove a TODO.
14427 * statement.cs (Block.Toplevel): Make into a field.
14428 (Block.Parameters): Move into ToplevelBlock.
14429 (Block.known_variables): Rename from child_variable_names.
14430 (Block.Block): Remove variants that take Parameters. Initialize
14431 'Toplevel' with the immediately surrounding toplevel block.
14432 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14433 LocalInfo parameter.
14434 (Block.GetKnownVariableInfo): New.
14435 (Block.IsVariableNameUsedInChildBlock): Update.
14436 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14437 the block, even though it may not be in scope.
14438 (Block.AddVariable): Remove Parameters parameter. Use
14439 Toplevel.Parameters instead.
14440 (Block.AddConstant): Remove Parameters parameter.
14441 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14442 (Block.IsParamaterReference): Likewise.
14443 (Block.IsLocalParameter): Likewise. Simplify a lot.
14444 (ToplevelBlock.Parameters): New. Moved from Block.
14445 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14446 initialize Parameters to a non-null value.
14447 * cs-parser.jay: Update to changes.
14448 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14449 simple names that mean different things in the same block. Use
14450 Block.IsVariableNameUsedInBlock.
14452 2005-03-28 Raja R Harinath <rharinath@novell.com>
14454 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14455 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14456 GetTypeHandle. It is possible for a reflected type to derive from
14457 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14458 System.Array during mscorlib compilation).
14459 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14460 contain a method_hash, don't create one either. Don't create a
14461 deep copy of the base cache's method_hash.
14462 (MemberCache.SetupCache): Rename back from DeepCopy.
14463 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14464 already initialized. If we see an override function, add its
14465 underlying base virtual function to the member_hash too.
14467 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14469 2005-03-26 Raja R Harinath <harinath@acm.org>
14472 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14473 fails to resolve, ensure that the LHS is still resolved as an
14476 2005-03-25 Raja R Harinath <harinath@acm.org>
14478 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14480 (Enum.current_ec): Remove.
14481 (Enum.LookupEnumValue): Remove EmitContext argument.
14482 Just uses the one created during DefineType.
14483 (Enum.FindMembers): Update.
14484 * expression.cs (MemberAccess.DoResolve): Update.
14486 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14488 * assign.cs (Assign.DoResolve): Check for CS1717 when
14489 source and target are same (uses Equals).
14491 * expression.cs (LocalVariableReference, ParameterReference,
14492 This): Implemented Equals, GetHashCode.
14494 * statement.cs (Block.GetParameterReference): Removed useless
14497 2005-03-22 Raja R Harinath <rharinath@novell.com>
14500 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14501 blocks before deciding whether the error is cs0136 or cs0128.
14503 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14504 (using_alias_directive, using_namespace_directive): Pass
14505 MemberName, not an expression to Namespace.UsingAlias and
14507 (MakeName): Use the MemberName of the namespace.
14508 * namespace.cs (Namespace.MemberName): New.
14509 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14510 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14512 * decl.cs (MemberName.Name): Make readonly.
14513 (MemberName.FromDotted): New "constructor".
14514 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14515 (MemberCore.Name): Compute from MemberName on demand.
14516 (MemberCore.SetMemberName): Provide a way to change the
14518 (MemberCore.AddToContainer): Don't take a fullname parameter.
14519 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14520 fully qualified name of the container to the member name.
14521 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14522 only if the type is a member of the root container.
14523 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14524 MemberName.Left rather than searching for an embedded ".".
14525 (PartialContainer.CreatePart): Update to changes in RootContext.
14526 (MemberBase.ShortName): Turn into a property. Use
14527 MemberCore.SetMemberName.
14528 (MemberBase.ExplicitInterfaceName): Remove.
14529 (MemberBase.UpdateMemberName): Remove.
14530 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14531 (PropertyBase.SetMemberName): New override.
14532 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14533 (Tree.GetDecl): New.
14534 (Tree.AllDecls): Rename from Decls.
14535 * attribute.cs, enum.cs, report.cs: Update to changes.
14536 * driver.cs (MainDriver): Use MemberName.FromDotted on
14537 RootContext.MainClass.
14539 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14541 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14544 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14546 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14548 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14549 property accessor modifiers.
14551 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14552 fixed buffer attribute (CS1716).
14553 (PropertyMethod.HasCustomAccessModifier): When property accessor
14554 has custom modifier.
14556 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14558 (PropertyExpr.DoResolveLValue): Add CS0272.
14560 2005-03-17 Miguel de Icaza <miguel@novell.com>
14562 * convert.cs: When converting to a pointer, use the proper Conv.U
14563 or Conv.I depending on the source data type.
14565 * cs-tokenizer.cs: Make the size for large decimal constants,
14568 2005-03-17 Martin Baulig <martin@ximian.com>
14570 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14571 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14573 2005-03-17 Martin Baulig <martin@ximian.com>
14575 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14576 to bool so we can return an error condition.
14577 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14580 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14582 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14585 2005-03-16 Raja R Harinath <rharinath@novell.com>
14587 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14588 Refactor to avoid traversing the list of assemblies, and to avoid
14589 string concatenation.
14590 * typemanager.cs (guid_attr_type): Remove.
14591 (negative_hits, pointers, references): Remove hashes.
14593 (GetConstructedType): New. Uses type_hash to handle constructed
14594 types (arrays, references, pointers).
14595 (GetReferenceType, GetPointerType): Use it.
14596 (GetNestedType): New. Uses type_hash to handle nested types of
14598 (LookupType, LookupTypeDirect): Remove.
14599 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14600 'types' hash and LookupTypeReflection directly.
14601 (params_string, params_object): Use GetConstructedType.
14602 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14604 (Namespace.Lookup): Use cached_types.
14605 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14606 provided by old TypeManager.LookupType.
14607 * rootcontext.cs (MakeFQN): Remove.
14608 * decl.cs (DeclSpace.MakeFQN): Likewise.
14609 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14610 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14611 TypeManager.GetConstructedType.
14612 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14614 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14616 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14619 * cs-parser.jay: Reports CS1527 for any namespace element.
14621 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14624 * expression.cs (ParameterReference.IsAssigned): Changed error to
14626 (Error_WrongNumArguments): Moved CS0245 detection here.
14628 * statement.cs (Return.Resolve): Add CS1622 report.
14630 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14632 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14634 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14636 * attribute.cs expression.cs: Get rid of some allocations.
14638 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14640 * doc.cs : just eliminate the latest change.
14642 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14644 * doc.cs : commented out the latest change. It breaks xml-030.cs
14646 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14648 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14649 fail. So invoke CreateType() in FindDocumentedType().
14651 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14653 * cs-tokenizer.cs : added IsKeyword().
14654 * doc.cs : Detect keyword incorrectly used as identifier.
14655 Allow identifiers prefixed by @.
14657 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14659 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14660 It caused exception in namespace resolving (again!).
14662 * class.cs (Class.ctor): Removed exit.
14663 (PropertyMethod.ctor): ditto.
14665 * codegen.cs (Codegen.Reset): Reset static data.
14666 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14668 * cs-tokenizer.cs (Cleanup): Removed.
14670 * driver.cs (GetSystemDir): Rewrote to one line command.
14671 It caused problem with unloaded dynamic modules.
14672 (UnixParseOption): Removed Exit.
14673 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14674 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14675 Now can be mcs used as library.
14677 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14680 * location.cs (Reset): Reset static data.
14682 * namespace.cs (Reset): Reset static data.
14684 * report.cs (Report.Reset): Reset static data.
14686 * rootcontext.cs (RootContext.Reset): Reset static data.
14688 * tree.cs (RootTypes.ctor): Use Location.Null
14690 * typemanager.cs (TypeManager.Reset): Reset static data.
14691 (CoreLookupType): Removed Exit.
14692 (TypeHandle.Reset): Reset static data.
14694 2005-03-10 Raja R Harinath <rharinath@novell.com>
14697 * typemanager.cs (ComputeNamespaces): Import namespaces from
14698 referenced modules too.
14700 2005-03-09 Raja R Harinath <rharinath@novell.com>
14702 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14705 2005-03-09 Raja R Harinath <rharinath@novell.com>
14707 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14708 enclosing DeclSpace. This ensures that a name-lookup populates
14709 more caches and there are fewer 'TypeExpression's. Carve out
14710 nested type lookup into ...
14711 (LookupNestedTypeInHierarchy): ... this.
14713 2005-03-09 Raja R Harinath <rharinath@novell.com>
14715 Clean up a few partial-class semantics.
14716 Fixes test-357.cs and cs1618-2.cs.
14717 * cs-parser.jay (struct_declaration): Use 'current_class' as
14718 parent of newly-created struct. Remove call to Register ().
14719 Use 'pop_current_class' to complete handing the current struct.
14720 (interface_declaration): Likewise.
14721 (class_declaration): Likewise.
14722 (enum_declaration): Use 'current_class' as parent of newly created
14724 (delegate_declaration): Likewise.
14725 (pop_current_class): New function. This is used to handle closing
14726 up the 'current_class' and 'current_container', and pointing them
14727 to the enclosing class/container.
14728 (CSharpParser): Initialize 'current_class' too.
14729 * decl.cs (MemberCore): Add check for invariant: a partial
14730 container is not a parsed entity, and thus does not enclose any
14732 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14733 (DeclSpace.BaseTypeExpr): Use it.
14734 (DeclSpace.LookupType): Add check for invariant.
14735 * class.cs (TypeContainer): Add check for invariant: a nested
14736 class should have the same NamespaceEntry as its enclosing class.
14737 (TypeContainer.EmitFieldInitializers): Make virtual.
14738 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14740 (TypeContainer.Register): Remove.
14741 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14742 null. Use TypeResolveEmitContext for resolving base types and
14743 interfaces. Move initialization of Parts.TypeBuilder here from
14745 (TypeContainer.DefineNestedTypes): ... here.
14746 (PartialContainer): Take a Namespace not a NamespaceEntry.
14747 (PartialContainer.Create): Don't use Register. Call the
14748 appropriate Add... function directly.
14749 (ClassPart): Take both the PartialContainer and the enclosing
14750 class as constructor arguments.
14751 (ClassPart.EmitFieldInitializers): Override.
14752 (ClassPart.PartFindNestedTypes): Remove.
14753 (FieldBase.GetInitializerExpression): Resolve the initializer
14754 expression in the emit context of the enclosing class.
14755 * tree.cs (RootTypes): Remove Register ().
14757 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14759 * cs-parser.jay: Removed CS0134.
14761 * driver.cs: Removed CS1901.
14763 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14764 for predefined types.
14766 2005-03-07 Duncan Mak <duncan@novell.com>
14768 * codegen.cs (Save): Catch UnauthorizedAccessException as
14769 well. Fixes bug #73454.
14771 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14773 * cs-tokenizer.cs (xtoken): Add CS1035.
14775 * class.cs (MethodData.Define): Add CS0683.
14776 (FieldMember.ctor): Add CS0681.
14778 2005-03-07 Raja R Harinath <rharinath@novell.com>
14780 * ecore.cs (SimpleName.DoResolve): Rename from
14781 SimpleName.DoResolveAllowStatic.
14782 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14783 Pass 'intermediate' flag to MemberStaticCheck.
14784 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14785 of "intermediate" lookups via MemberAccess.
14786 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14787 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14789 2005-03-07 Raja R Harinath <rharinath@novell.com>
14792 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14793 slipped in because of variable names that are identical to a
14794 builtin type's BCL equivalent ('string String;', 'int Int32;').
14795 (PropertyExpr.EmitInstance): Likewise.
14797 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14799 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14801 * report.cs (warning_ignore_table): Made public.
14803 2005-03-04 Raja R Harinath <rharinath@novell.com>
14806 * class.cs (MethodData.Emit): Pass 'container' to
14807 container.GetObsoleteAttribute instead of 'container.Parent'.
14809 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14811 * cs-parser.jay: Add 1534 error test.
14813 * iterators.cs (Yield.CheckContext): Add error 1629.
14814 (Iterator.ctor): Save unsafe modifier.
14815 (MoveNextMethod.DoEmit): Restore unsafe context.
14817 * namespace.cs (UsingAlias): Better error message.
14819 2005-03-03 Dan Winship <danw@novell.com>
14821 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14822 the warning message [#73219]
14824 2005-03-03 Raja R Harinath <rharinath@novell.com>
14826 Fix compile with MCS 1.0.0.0.
14827 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14828 w_restore to not depend on string constant folding.
14830 2005-03-03 Raja R Harinath <rharinath@novell.com>
14832 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14833 CS0246 check to users who passed 'silent = false'.
14834 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14836 (SimpleName.SimpleNameResolve): Update.
14837 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14838 (MemberAccess.IdenticalNameAndTypeName): Update.
14839 * doc.cs (FindDocumentedTypeNonArray): Update.
14841 2005-03-03 Raja R Harinath <rharinath@novell.com>
14843 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14844 * parameters.cs (ComputeAndDefineParameters): Remove.
14845 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14846 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14847 Use GetParameterInfo.
14849 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14851 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14853 2005-03-02 Raja R Harinath <rharinath@novell.com>
14855 Unify DeclSpace.LookupType and DeclSpace.FindType.
14856 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14857 is in charge of defining nested types on demand.
14858 (DeclSpace.LookupType): Use it when the current_type is a
14859 TypeBuilder. Use LookupTypeDirect for reflected types.
14860 (DeclSpace.FindType): Remove.
14861 (DeclSpace.LookupInterfaceOrClass): Likewise.
14862 (DeclSpace.DefineTypeAndParents): Likewise.
14863 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14864 DeclSpace.LookupType.
14865 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14866 * typemanager.cs (LookupType): Simplify.
14867 (AddUserType): Remove type from negative_hits.
14868 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14869 * class.cs (TypeContainer.FindMembers): Move handling of nested
14871 (TypeContainer.FindMembers_NestedTypes): ... here.
14872 (TypeContainer.FindNestedType): Implement override.
14873 (ClassPart.FindNestedType): Delegate to PartialContainer.
14874 (ClassPart.PartFindNestedType): Looks up the nested types of the
14877 2005-03-02 Martin Baulig <martin@ximian.com>
14879 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14880 static constructor in static classes.
14882 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14884 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14885 sizeParamIndex is not specified.
14887 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14890 * report.cs (WarningMessage.IsEnabled): Missing null check.
14892 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14894 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14895 in the fields and not in the properties.
14897 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14899 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14902 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14904 * attribute.cs: Small refactoring (improved robustness).
14905 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14906 (ValidateGuid): Removed.
14907 (Resolve): Removed referenced to above mentioned.
14908 (GetAttributeUsage): Made private and changed to work without
14910 (GetIndexerAttributeValue): Don't crash.
14911 (GetConditionalAttributeValue): Ditto.
14912 (GetClsCompliantAttributeValue): Ditto.
14913 (ExtractSecurityPermissionSet): All attributes exceptions are
14915 (GetPropertyValue): New helper.
14916 (GetMethodImplOptions): New method.
14917 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14918 some missing properties.
14920 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14921 (Method.ApplyAttributeBuilder): Updated.
14923 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14926 2005-02-28 Raja R Harinath <rharinath@novell.com>
14929 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14930 non-simple types (array, pointer, reference).
14932 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14934 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14936 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14938 (Method.CheckBase): Catch wrong destructor here.
14939 (MethodData.Define): Add errors 550, 668.
14941 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14943 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14945 * pending.cs (VerifyPendingMethods): Add error 551.
14947 * typemanager.cs (CSharpName): Next error report helper.
14949 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14951 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14952 attributes. Removed useless attribute double check.
14953 It saves almost 2MBs for corlib.
14955 2005-02-25 Raja R Harinath <rharinath@novell.com>
14958 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14959 called twice in case of error.
14961 2005-02-23 Chris Toshok <toshok@ximian.com>
14963 Fix compiler portions of #72827.
14964 * statement.cs (Block.Emit): call Begin/EndScope on the
14965 EmitContext instead of the ILGenerator.
14967 * codegen.cs (EmitContext.BeginScope): new method, call
14968 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14970 (EmitContext.BeginScope): same, but EndScope and CloseScope
14972 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14973 offset and call the superclass's OpenScope(int) with it.
14974 (SymbolWriter.CloseScope): get the current il
14975 offset and call superclass's CloseScope(int) with it.
14977 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14979 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14980 CS1677 for out and ref as well.
14982 * class.cs (Method.Define): Add error CS1599 detection.
14984 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14986 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14988 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14990 * support.cs.cs (ModifierDesc): New helper method.
14992 2005-02-23 Raja R Harinath <rharinath@novell.com>
14993 Abin Thomas <projectmonokochi@rediffmail.com>
14994 Anoob V E <projectmonokochi@rediffmail.com>
14995 Harilal P R <projectmonokochi@rediffmail.com>
14997 Fix #57851, #72718.
14998 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14999 MemberLookup (used for error reporting) actually returns a result.
15000 Fix error report number (122, not 112).
15002 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
15003 Anoob V E <projectmonokochi@rediffmail.com>
15004 Harilal P R <projectmonokochi@rediffmail.com>
15007 * pending.cs (PendingImplementation.GetAbstractMethods):
15008 Find NonPublic members too.
15010 2005-02-22 Marek Safar <marek.safar@seznam.cz>
15012 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
15015 * class.cs (MethodCore.CheckMethodAgainstBase):
15016 Add error 239 report.
15018 2005-02-21 Raja R Harinath <rharinath@novell.com>
15021 * expression.cs (Invocation.IsApplicable): Make public.
15022 (Invocation.IsParamsMethodApplicable): Likewise.
15023 * delegate.cs (Delegate.VerifyApplicability): Don't use
15024 Invocation.VerifyArgumentCompat for parameter applicability
15025 testing. Use Invocation.IsApplicable and
15026 Invocation.IsParamsMethodApplicable.
15028 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15030 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
15032 * class.cs (Operator.Define): Add error 217 report.
15034 2005-02-21 Raja R Harinath <rharinath@novell.com>
15036 * namespace.cs (UsingEntry.Resolve): Undo change below.
15038 2005-02-21 Raja R Harinath <rharinath@novell.com>
15041 * ecore.cs (Expression.MemberLookupFailed): Add argument to
15042 disable the error message when the extended MemberLookup also
15044 (Expression.MemberLookupFinal): Update.
15045 (SimpleName.DoSimpleNameResolve): Update.
15046 * expression.cs (MemberAccess.ResolveNamespaceOrType):
15047 Don't use MemberLookupFinal.
15048 (New.DoResolve): Update.
15049 (BaseAccess.CommonResolve): Update.
15051 2005-02-21 Raja R Harinath <rharinath@novell.com>
15054 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
15055 occured previously, don't resolve again.
15057 2005-02-21 Marek Safar <marek.safar@seznam.cz>
15060 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
15061 argument. Call ResolveAttributeUsage for unresolved.
15062 when types doesn't match ctor arguments.
15064 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
15065 for nested attribute classes.
15066 (Class.attribute_usage): Removed.
15067 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
15068 for attribute class.
15070 * ecore.cs (IsAttribute): Removed.
15072 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
15074 * rootcontext.cs (RegisterAttribute): Removed, attributes are
15076 (attribute_types): Removed.
15077 (EmitCode): Global attributes are emited as the latest.
15079 2005-02-18 Marek Safar <marek.safar@seznam.cz>
15081 * class.cs (EmitFieldInitializers): Don't emit field initializer
15082 for default values when optimilization is on.
15084 * constant.cs (Constant.IsDefaultValue): New property.
15086 * driver.cs: Add /optimize handling.
15090 * literal.cs: Implement new IsDefaultValue property.
15092 * rootcontext.cs (Optimize): New field, holds /optimize option.
15094 2005-02-18 Raja R Harinath <rharinath@novell.com>
15096 Fix crasher in re-opened #72347.
15097 * namespace.cs (Namespace.Lookup): Return null if
15098 DeclSpace.DefineType returns null.
15101 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
15103 2005-02-18 Raja R Harinath <rharinath@novell.com>
15105 Fix remainder of #63202. Change semantics of DoResolveLValue: it
15106 now returns null if it cannot resolve to an lvalue.
15107 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
15108 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
15109 returned null. Remove check for SimpleName.
15110 (EventExpr.DoResolveLValue): New.
15111 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
15112 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
15114 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
15115 avoid CS0131 error.
15116 (Unary.ResolveOperator): Move CS0211 check ...
15117 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
15119 (Unary.DoResolveLValue): Simplify.
15120 (AddressOf.DoResolveLValue): New.
15121 (ArrayAccess.DoResolveLValue): New.
15123 2005-02-16 Marek Safar <marek.safar@seznam.cz>
15125 * attribute.cs (Attribute.Resolve): Add arguments casting for
15126 when types doesn't match ctor arguments.
15128 2005-02-16 Raja R Harinath <rharinath@novell.com>
15130 Fix parts of #63202.
15131 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
15132 lookup of operator in base type. Ensure that all checks happen
15133 when the operator resolves to an "op_..." method.
15135 2005-02-15 Raja R Harinath <rharinath@novell.com>
15138 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
15139 'ignore_cs0104' parameter. Pass it to ...
15140 (NamespaceEntry.Lookup): ... this.
15141 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
15142 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
15143 (TypeLookupExpression.DoResolveAsTypeStep): Update.
15144 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
15145 Update. Request that cs0104 errors be ignored.
15146 (ComposedCast.ResolveAsTypeStep): Update.
15148 2005-02-14 Raja R Harinath <rharinath@novell.com>
15151 * expression.cs (Invocation.BetterFunction): Remove support for
15152 comparing virtual functions and their overrides.
15153 (Invocation.IsOverride): New.
15154 (Invocation.OverloadResolve): Don't consider 'override' functions
15155 during candidate selection. Store them in a lookaside list.
15156 If the selected method is a 'virtual' function, use the list to
15157 find any overrides that are closer to the LHS type.
15159 2005-02-14 Marek Safar <marek.safar@seznam.cz>
15161 * expression.cs (New.DoResolve): Add complex core type reduction.
15162 (New.Constantify): Converts complex core type syntax like 'new int ()'
15163 to simple constant.
15165 2005-02-14 Raja R Harinath <rharinath@novell.com>
15167 * decl.cs (EntryType.EntryType): New constructor to create an
15168 updated copy of a cache entry.
15169 (MemberCache.AddMethods): Use it.
15170 (MemberCache.ClearDeclaredOnly): Remove.
15171 (MemberCache.MemberCache): Update.
15173 2005-02-11 Miguel de Icaza <miguel@novell.com>
15175 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
15176 variable. This one is represents the actual low-level declaration
15177 of the method, as opposed to the semantic level `IsStatic'.
15179 An anonymous method which is hosted into a static method might be
15180 actually an instance method. IsStatic would reflect the
15181 container, while MethodIsStatic represents the actual code
15184 * expression.cs (ParameterReference): Use the new MethodIsStatic
15185 instead of IsStatic.
15187 * anonymous.cs (AnonymousMethod.Compatible): Pass the
15188 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
15189 set on the current EmitContext.
15191 * expression.cs (Cast): Overload DoResolveLValue so we can pass
15192 resolve our casted expression as an LValue. This triggers the
15193 proper LValue processing that is later required by Assign.
15197 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
15199 2005-02-11 Marek Safar <marek.safar@seznam.cz>
15201 C# 2.0 Fixed buffer implementation
15203 * anonymous.cs: Update after RegisterHelperClass renaming.
15205 * attribute.cs (AttributeTester.fixed_buffer_cache):
15206 Cache of external fixed buffers.
15207 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
15208 implementation if field is fixed buffer else null.
15211 (TypeContainer.AddField): Accept FieldMember instead of Field.
15212 (FieldBase.IsFieldClsCompliant): Extracted code from
15213 VerifyClsCompliance descendant customization.
15214 (FixedField): New class handles fixed buffer fields.
15215 (FixedFieldExternal): Keeps information about imported fixed
15217 (IFixedField): Make access to internal or external fixed buffer
15220 * cs-parser.jay: Add fixed buffer parsing.
15222 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
15225 * expression.cs (Indirection): Extended implementation to accept
15226 fixed buffer field.
15227 (PointerArithmetic.Emit): Get element from fixed buffer as well.
15228 (ElementAccess.MakePointerAccess): Get type as parameter.
15229 (DoResolve): Add fixed buffer field expression conversion.
15230 (DoResolveLValue): Ditto.
15231 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
15232 (ArrayPtr): Derives from FixedBufferPtr.
15233 (ArrayPtr.Emit): Add extra emit for array elements.
15235 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
15237 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
15238 for compiler generated types.
15239 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
15241 * statement.cs (Fixed): Refactored to be easier add fixed buffer
15242 and consume less memory.
15243 (Fixed.Resolve): Add fixed buffer case.
15245 * typemanager.cs (compiler_generated_attr_ctor,
15246 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
15247 (HasElementType): Add our own implementation to work on every
15250 2005-02-11 Miguel de Icaza <miguel@novell.com>
15252 * anonymous.cs (CaptureContext): Track whether `this' has been
15255 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
15256 only captured `this' if it was implicitly done (instance
15257 methods/variables were used).
15259 * codegen.cs (EmitContext.CaptureThis): New method to flag that
15260 `this' must be captured.
15262 2005-01-30 Miguel de Icaza <miguel@novell.com>
15264 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
15265 is null it means that there has been no need to capture anything,
15266 so we just create a sibling.
15268 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
15270 Just a partial fix. The other half is fairly elusive.
15272 2005-02-10 Raja R Harinath <rharinath@novell.com>
15274 Fix #52586, cs0121-4.cs.
15275 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
15276 and return a hashtable.
15277 (MemberCache.ClearDeclaredOnly): New.
15278 (MemberCache.MemberCache): Update to change. Make a deep copy of
15279 the method_hash of a base type too.
15280 (MemberCache.AddMethods): Adapt to having a deep copy of the base
15281 type methods. Overwrite entries with the same MethodHandle so
15282 that the ReflectedType is correct. The process leaves in base
15283 virtual functions and their overrides as distinct entries.
15284 (CacheEntry): Now a class instead of a struct. It shouldn't alter
15285 matters since it was boxed in a ArrayList before.
15286 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
15288 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
15289 case of a virtual function and its override (choose the overload
15291 (Invocation.OverloadResolve): Avoid 'override' members during
15292 'applicable_type' calculation.
15294 2005-02-09 Raja R Harinath <rharinath@novell.com>
15296 Combine two near-redundant caches.
15297 * typemanager.cs (method_params): Rename from method_internal_params.
15298 (TypeManager.GetParameterData): New. Replace
15299 Invocation.GetParameterData.
15300 (TypeManager.LookupParametersByBuilder): Remove.
15301 * expression.cs (Invocation.method_parameter_cache): Remove.
15302 (Invocation.GetParameterData): Remove.
15304 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
15307 2005-02-08 Raja R Harinath <rharinath@novell.com>
15310 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
15311 TypeManager.multicast_delegate_type is null, resolve it by looking
15312 up "System.MulticastDelegate".
15313 * rootcontext.cs (RootContext.ResolveCore): Simplify.
15315 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
15316 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
15317 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
15320 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
15321 (LabeledStatement.AddReference): New. Set 'referenced'.
15322 (Goto.Resolve): Use it.
15324 2005-02-05 John Luke <john.luke@gmail.com>
15326 * driver.cs: remove duplicate -doc line in Usage ()
15328 2005-02-04 Raja R Harinath <rharinath@novell.com>
15330 * location.cs (Location.AddFile): Fix CS2002 error report.
15332 2005-02-02 Martin Baulig <martin@ximian.com>
15334 * delegate.cs (Delegate.DefineType): Report an internal error if
15335 TypeManager.multicast_delegate_type is null. See bug #72015 for
15338 2005-02-02 Raja R Harinath <rharinath@novell.com>
15340 Fix a crasher in a variant of #31984.
15341 * const.cs (Constant.CheckBase): New override that defers the
15342 new-or-override check in case the base type hasn't been populated
15344 (Constant.Define): Ensure the new-or-override check is performed.
15346 2005-02-01 Duncan Mak <duncan@ximian.com>
15348 * const.cs (LookupConstantValue): Check that `ce' is not null
15349 before calling GetValue ().
15351 2005-02-01 Raja R Harinath <rharinath@novell.com>
15353 Fix test-334.cs (#69519).
15354 * cs-parser.jay (using_alias_directive): Pass in an expression to
15355 NamespaceEntry.UsingAlias.
15356 (using_namespace_directive): Pass in an expression to
15357 NamespaceEntry.Using.
15358 (namespace_name): Don't flatten to a string.
15359 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
15360 (NamespaceEntry.AliasEntry.Resolve): Lookup using
15362 (NamespaceEntry.UsingEntry): Likewise.
15363 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15365 (NamespaceEntry.LookupForUsing): Remove.
15366 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15368 (NamespaceEntry.Lookup): Remove support for dotted names.
15370 2005-02-01 Raja R Harinath <rharinath@novell.com>
15372 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15374 (NamespaceEntry.ImplicitParent): Compute on demand.
15375 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15376 parallels the current.
15377 (NamespaceEntry.LookupForUsing): Use it.
15378 (NamespaceEntry.Lookup): If the current namespace-entry is
15379 implicit, don't search aliases and using tables.
15381 2005-02-01 Raja R Harinath <rharinath@novell.com>
15384 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15386 (TypeContainer.BaseCache): Compute on demand.
15387 (TypeContainer.FindMembers): Define constants and types if they're
15388 not already created.
15389 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15391 * const.cs (Constant.Define): Make idempotent.
15393 2005-01-29 Miguel de Icaza <miguel@novell.com>
15395 * pending.cs: Produce better code (no nops produced by using Ldarg
15398 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15399 i - 1' it should be arg + 1.
15403 2005-01-28 Raja R Harinath <rharinath@novell.com>
15405 * attribute.cs (Attribute.CheckAttributeType): Make private
15407 (Attribute.ResolveType): Make virtual.
15408 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15409 handling of RootContext.Tree.Types.
15411 2005-01-27 Raja R Harinath <rharinath@novell.com>
15413 Update attribute-handling to use the SimpleName/MemberAccess
15415 * cs-parser.jay (attribute): Pass in an expression to the
15416 constructors of Attribute and GlobalAttribute.
15417 * attribute.cs (Attribute): Take an expression for the name.
15418 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15419 passed in attribute name expression.
15420 (Attribute.CheckAttributeType): Use it.
15421 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15422 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15423 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15424 argument to prevent error messages if the lookup fails.
15426 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15428 * expression.cs (Indirection): Implemented IVariable interface
15429 to support indirection in AddressOf operator.
15430 (PointerArithmetic.Emit): Add optimalization for case where
15431 result can be precomputed.
15433 2005-01-26 Martin Baulig <martin@ximian.com>
15435 * class.cs (TypeContainer.AttributeTargets): Return the correct
15436 AttributeTargets depending on our `Kind' instead of throwing an
15437 exception; fixes #71632.
15439 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15442 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15445 2005-01-25 Raja R Harinath <rharinath@novell.com>
15448 * expression.cs (MemberAccess.DoResolve): Don't complain with
15449 cs0572 when the LHS of a member access has identical name and type
15452 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15455 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15457 Create custom PermissionSet only for PermissionSetAttribute.
15459 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15462 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15463 delegates in static class.
15465 2005-01-24 Martin Baulig <martin@ximian.com>
15467 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15468 merging an implicit block, just use its reachability.
15470 * statement.cs (Block.Resolve): Make the unreachable code check
15471 work wrt. implicit blocks; see test-337 from #63842.
15473 2005-01-21 Alp Toker <alp@atoker.com>
15475 * cs-parser.jay: destructor_declaration's container is PartialContainer
15476 not Class when partial types are used, so use Kind prop instead of
15479 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15481 * cs-parser.jay: Improve error reporting when an interface
15482 declares new types.
15484 2005-01-20 Dick Porter <dick@ximian.com>
15486 * support.cs: SeekableStreamReader fix from Sandor Dobos
15487 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15488 chars are read. Fixes bug 70369.
15490 2005-01-20 Raja R Harinath <rharinath@novell.com>
15492 * cs-parser.jay (catch_clause): Simplify current_block handling
15495 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15497 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15498 code with ImplicitStandardConversion to handle the implicit
15499 conversion of method groups into valid delegate invocations.
15501 The problem is that in parameter handling we were using this code
15502 path. Fixes bug #64698
15504 2005-01-19 Raja R Harinath <rharinath@novell.com>
15506 * cs-parser.jay: Fix several infelicities.
15507 - Avoid assigning to the parser value stack. Code like
15508 '$3 = null' is unclean. Synthesize a value for the code block
15510 - Avoid using oob_stack for storing location information. Use ...
15511 (_mark_): ... this. New (empty) rule. Saves the current location
15513 (foreach_statement): Avoid using oob_stack for current_block
15514 handling. Use technique used in for_statement and
15515 using_statement. Synthesize a value for the code block to store
15516 additional intermediate information.
15518 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15520 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15521 of a different type is only allowed to private fields of a
15522 containing type, not on fields of a base class.
15524 See test-174.cs and error cs0122-9.cs
15526 2005-01-13 Raja R Harinath <rharinath@novell.com>
15528 Fix test-335.cs (bug #58126).
15529 * cs-parser.jay (argument): Split out non-expression parts of the
15530 rule into 'non_simple_argument'.
15531 (invocation_expression): Support parenthesized invocations with
15532 multiple arguments, and with single non-simple arguments.
15534 2005-01-13 Raja R Harinath <rharinath@novell.com>
15536 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15539 2005-01-12 Raja R Harinath <rharinath@novell.com>
15541 Fix cs0038-1.cs, cs1640-6.cs.
15542 * ecore.cs (Expression.Resolve): Remove special-case for
15543 SimpleName in error-handling.
15544 (Expression.almostMatchedMembers): Relax access permission to
15546 (Expression.MemberLookupFailed): Handle duplicates in
15547 almostMatchedMembers list.
15548 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15549 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15550 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15551 overload if the passed in MemberInfo is a MethodBase.
15553 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15556 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15557 for non-CAS & merge permission sets properly.
15559 2005-01-11 Raja R Harinath <rharinath@novell.com>
15561 Improve standard-compliance of simple name and member access
15562 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15563 * ecore.cs (FullNamedExpression): New abstract base class
15564 for Namespaces and TypeExpressions.
15565 (ResolveFlags.SimpleName): Remove.
15566 (SimpleName): Remove support for dotted names.
15567 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15568 DeclSpace.FindType and DeclSpace.LookupType.
15569 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15570 (Expression.ExprClassName): Make member function.
15571 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15572 a namespace. Remove creation of dotted "SimpleName"s.
15573 (MemberAccess.DoResolve): Likewise.
15574 * decl.cs (DeclSpace.Cache): Make private.
15575 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15576 (DeclSpace.FindType): Update.
15577 (DeclSpace.LookupType): Move here from RootContext. Return a
15578 FullNamedExpression.
15579 * namespace.cs (Namespace): Derive from FullNamedExpression
15580 so that it can be part of expression resolution.
15581 (Namespace.Lookup): Return an FullNamedExpression.
15582 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15584 * rootcontext.cs (NamespaceLookup): Remove.
15585 (LookupType): Move to DeclSpace.
15586 * attribute.cs (CheckAttributeType): Update.
15587 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15588 (FindDocumentedTypeNonArray): Likewise.
15590 2005-01-11 Raja R Harinath <rharinath@novell.com>
15592 Fix cs0509.cs, cs1632.cs.
15593 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15594 is the same as IsInterface.
15595 (TypeContainer.GetClassBases): Likewise.
15596 * statement.cs (LabeledStatement.ig): New field.
15597 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15599 (LabeledStatement.DoEmit): Check that the label was created with
15600 the same ILGenerator.
15602 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15605 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15606 accessors to its properties.
15608 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15609 from accessors to property.
15611 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15614 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15615 only for overrides.
15617 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15619 * attribute.cs: Check for null and empty strings.
15621 I have lost another battle to Paolo.
15623 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15626 * class.cs (PropertyMethod): Set Parent field in ctors.
15627 (SetMethod.InternalParameters): Add unsafe switch hack.
15628 Override MarkForDuplicationCheck where it is appropriate.
15630 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15631 It says whether container allows members with the same name.
15632 Base default is no.
15633 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15634 Removed is_method parameter.
15636 2005-01-06 Duncan Mak <duncan@ximian.com>
15638 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15639 because the previous change led to incorrect reporting of CS1032
15640 ("Cannot define/undefine preprocessor symbols after first token in
15641 file"). Instead of using `tokens_seen' as the only flag that
15642 triggers CS1040, introduce `comments_seen'. This new flag is used
15643 to signify having seen comments on the current line, so it is
15644 unset after a newline.
15646 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15648 * doc.cs : When searching for a type, find nested type too.
15649 This fixes bug #71040.
15651 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15654 - Warn missing member comment on those classes which also does not
15655 have doc comments. Fixed bug #71041.
15656 - Don't warn missing doc comment on default constructor.
15659 2005-01-06 Duncan Mak <duncan@ximian.com>
15661 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15662 comments, set `tokens_seen' to true. This allows us to detect
15663 misplaced preprocessor directives (i.e. not at the beginning of
15664 the a line, nor after whitespaces). In that case, report error
15665 CS1040. This fixes bug #56460.
15667 * cs-parser.jay (interface_member_declaration): Add checks for
15668 IsExplicitImpl, and report CS0541 error if an interface member is
15669 defined as an explicit interface declaration.
15671 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15674 * class.cs (PropertyMethod): Set Parent field in ctors.
15675 (SetMethod.InternalParameters): Add unsafe switch hack.
15677 * decl.cs (MemberCore.Parent): Cannot be readonly.
15679 2005-01-06 Raja R Harinath <rharinath@novell.com>
15681 * decl.cs (DeclSpace.ResolveType): Remove.
15682 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15683 Merge in code from ...
15684 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15685 * class.cs, enum.cs: Update to changes.
15687 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15689 * anonymous.cs: Ensure that we init the scope of our parent if it
15690 has not been initialized yet.
15692 2004-12-30 Duncan Mak <duncan@ximian.com>
15694 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15695 if field.FieldBuilder is null. Fixes #70758.
15697 * convert.cs: Fixed some typos and updated some of the comments.
15698 (ImplicitStandardConversionExists):
15699 (TryImplicitIntConversion): If `target_type' is an interface and
15700 the type of `ic' implements this interface, return true or a new
15701 BoxedCast instead of null. This fixes #70468.
15703 2004-12-29 Duncan Mak <duncan@ximian.com>
15705 * expression.cs (Argument.Emit): Check that Expr is
15706 IMemoryLocation before casting to it, and report CS1510 otherwise.
15710 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15712 * statement.cs (Block.ThisVariable): remove the recursion here, to
15713 make the --profile more sane.
15715 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15717 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15718 assembly, by JB Evain.
15720 2004-12-17 Raja R Harinath <rharinath@novell.com>
15722 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15723 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15724 "parent" refers to enclosing type/class. "base" refers to superclass.
15726 2004-12-17 Raja R Harinath <rharinath@novell.com>
15728 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15729 Ensure that we only have GlobalAttributes.
15730 * attribute.cs (Attribute.Emit): Make non-virtual.
15731 (GlobalAttribute.Emit): Remove.
15732 (Attribute.Resolve): Make virtual.
15733 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15734 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15735 the argument. Don't create one.
15736 (Attribute.GetObsoleteAttribute): Likewise.
15737 (Attribute.GetClsCompliantAttributeValue): Likewise.
15738 * class.cs, decl.cs: Update to changes.
15740 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15742 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15744 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15746 * statement.cs (Foreach.Resolve): Add error 186 report.
15748 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15750 * expression.cs (Conditional.DoResolve): Add warning 429.
15752 * statement.cs (If.Resolve): Add warning 665.
15754 2004-12-16 Raja R Harinath <rharinath@novell.com>
15756 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15757 except when in the parser, and in GlobalAttribute.
15758 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15759 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15760 RootContext.Tree.Types.NamespaceEntry once work is done.
15761 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15762 and resets RootContext.Tree.Types.NamespaceEntry.
15764 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15766 * cs-parser.jay: Don't create a block for every variable.
15768 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15770 * location.cs: Provide extra information.
15772 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15773 variables from the captured environment, it is the ldarg_0.
15775 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15777 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15780 * class.cs: Changed warning level for 169 to avoid developer
15781 displeasure from warning flooding. It will be changed back when they
15782 fix most of current BCL warnings.
15784 * RootContext.cs: Pushed default WarningLevel to 3.
15786 * statement.cs: Removed unused variable.
15788 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15790 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15791 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15792 Add error 502 report.
15793 (StaticClass.DefineType): Add error 441 report.
15794 (Class.AllowedModifiersProp): New virtual property as temporary
15795 extension to AllowedModifiers.
15796 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15797 to share implementation with StaticClass and don't call virtual
15800 * driver.cs (MainDriver): Add error 1558 test.
15802 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15803 report. Moved error 36 test here.
15805 * statement.cs (Throw.Resolve): Add error 724 report.
15807 * typemanager.cs: Add out_attribute_type core type.
15809 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15811 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15813 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15815 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15818 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15820 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15821 Add error 3023 report.
15822 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15824 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15827 2004-12-12 John Luke <john.luke@gmail.com>
15829 * driver.cs (AddArgs): take -- into account when
15830 adding arguments, fixes bug 65710
15832 2004-12-12 Martin Baulig <martin@ximian.com>
15834 * expression.cs (Unary.TryReduceNegative): Added support for
15835 SByteConstant and ByteConstant.
15836 (Unary.Reduce): Check error values from TryReduceNegative().
15838 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15840 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15841 and report exception as error 182.
15843 2004-12-10 Raja R Harinath <rharinath@novell.com>
15845 * driver.cs (Main): Fix message when there are warnings.
15847 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15849 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15851 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15853 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15854 Reduced number of warnings.
15856 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15858 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15860 * driver.cs: Removed message.
15862 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15864 2004-12-08 <vargaz@freemail.hu>
15866 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15868 2004-12-08 Martin Baulig <martin@ximian.com>
15870 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15871 instead of a CS3002 for properties and indexer.
15873 2004-12-08 Martin Baulig <martin@ximian.com>
15875 * decl.cs (MemberName.ToString): Make this work again.
15877 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15879 * attribute.cs (Resolve): Add error 591 detection.
15881 * class.cs (FieldMember.Define): Add error 1547 detection.
15882 (Indexer.Define): Add error 620 detection.
15883 (Operator.Define): Add error 590 detection.
15885 * ecore.cs: Missing argument for error 79.
15887 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15890 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15893 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15896 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15898 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15899 Some operator comments were suppressed.
15900 * doc.cs : Implicit/explicit operator name in doc comments are like
15901 "op_Explicit(type)~returnType", so added suffix handling.
15903 2004-12-07 Martin Baulig <martin@ximian.com>
15906 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15907 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15908 (DeclSpace.ec): New protected field; store the EmitContext here.
15909 (DeclSpace.EmitContext): New public property; moved here from
15911 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15914 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15915 (Enum.Emit): Don't create a new EmitContext.
15917 * delegate.cs (Delegate.DefineType): Always create the
15920 * iterators.cs (Iterators.DefineIterator): Create a new
15921 EmitContext and store it in `ec'.
15923 2004-08-24 Martin Baulig <martin@ximian.com>
15926 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15927 this for accessibility checks.
15928 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15929 IsNestedFamilyAccessible.
15930 (TypeManager.IsSubclassOf): New method, do what the name actually
15933 2004-12-06 Raja R Harinath <rharinath@novell.com>
15935 Fix crash on cs0657-17.cs.
15936 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15937 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15938 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15939 the case where the NamespaceEntry gets overwritten.
15941 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15943 Fixed #69195, #56821
15944 * ecore.cs (ResolveBoolean): Tiny refactoring.
15946 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15947 of right expression resolving when left is false constant and
15948 operator is LogicalAnd OR true constant and operator is LogicalOr.
15950 * statement.cs (ResolveUnreachable): Always reports warning.
15952 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15954 * class.cs: Distinguish between 1721 and 1722 (just a little help
15955 for the programmer).
15957 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15959 * delegate.cs: Only allow this on new versions of the language.
15961 2004-12-02 Duncan Mak <duncan@ximian.com>
15963 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15965 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15966 here as a static method. Take an additional bool out parameter
15967 `must_do_cs1540_check' for signaling to InstanceResolve.
15968 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15969 member field from PropertyExpr class and made it an argument of
15970 the method instead.
15971 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15972 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15973 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15974 and `remove_accessor' as well as InstanceResolve: report CS0122
15979 2004-12-03 Raja R Harinath <rharinath@novell.com>
15981 Fix test-327.cs, test-328.cs, and put in early infrastructure
15982 for eventually fixing #52697.
15983 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15984 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15985 from other methods.
15986 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15987 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15988 (VerifyUsing, error246): Update.
15989 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15990 'NamespaceEntry.LookupNamespaceOrType'.
15992 2004-12-03 Martin Baulig <martin@ximian.com>
15994 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15995 method as our child, call AnonymousMethod.Compatible() on it.
15997 2004-12-03 Raja R Harinath <rharinath@novell.com>
15999 Disable XML documentation support in 'basic' profile.
16000 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
16001 Redirect XmlElement to System.Object.
16002 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
16003 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
16004 * mcs.exe.sources: Add doc-bootstrap.cs.
16005 * doc-bootstrap.cs: New file. Contains empty stub implementation
16008 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
16010 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
16011 comments are allowed.
16013 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16015 * delegate.cs: Add checks for subtypes in paramaters and return values
16016 in VerifyMethod () to add support for Covariance/Contravariance
16019 2004-12-02 Miguel de Icaza <miguel@ximian.com>
16021 * report.cs: Remove extra closing parenthesis.
16023 * convert.cs (Error_CannotImplicitConversion): If the name of the
16024 types are the same, provide some extra information.
16026 * class.cs (FieldBase): Use an unused bit field from the field to
16027 encode the `has_offset' property from the FieldMember. This saves
16028 a couple of Ks on bootstrap compilation.
16030 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
16031 method as our child, return the AnonymousMethod resolved
16034 * expression.cs (New.DoResolve): Allow return values from
16035 NewDelegate to also include AnonymousMethods.
16039 2004-12-02 Marek Safar <marek.safar@seznam.cz>
16042 * attribute.cs (Resolve): Improved implementation of params
16043 attribute arguments.
16045 * support.cs (ParameterData): Add HasParams to be faster.
16047 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
16049 all things are for /doc support:
16051 * doc.cs: new file that supports XML documentation generation.
16052 * mcs.exe.sources: added doc.cs.
16054 Handle /doc command line option.
16055 Report error 2006 instead of 5 for missing file name for /doc.
16056 Generate XML documentation when required, after type resolution.
16058 Added support for picking up documentation (/// and /** ... */),
16059 including a new XmlCommentState enumeration.
16061 Added lines to fill Documentation element for field, constant,
16062 property, indexer, method, constructor, destructor, operator, event
16063 and class, struct, interface, delegate, enum.
16064 Added lines to warn incorrect comment.
16066 Added Documentation field (passed only when /doc was specified).
16068 Added DocComment, DocCommentHeader, GenerateDocComment() and
16069 OnGenerateDocComment() and some supporting private members for
16070 /doc feature to MemberCore.
16072 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
16074 Added overriden DocCommentHeader.
16076 Added overriden DocCommentHeader and GenerateDocComment().
16078 2004-12-01 Miguel de Icaza <miguel@ximian.com>
16080 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
16081 unwrapping the enumeration values, chain to
16082 DoConstantNumericPromotions again, so we can promote things to the
16083 fundamental types (takes care of enums that are bytes, sbytes).
16087 2004-12-01 Raja R Harinath <rharinath@novell.com>
16089 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
16090 Fix long-standing bug in type-lookup. Use FindType instead of
16091 LookupType when ec.ResolvingTypeTree.
16092 (Attribute.ResolveType, Attribute.Resolve)
16093 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
16095 (Attributes.Search): Remove internal version. Update.
16096 (Attributes.SearchMulti): Update.
16097 (Attributes.GetClsCompliantAttribute): Remove.
16098 (Attributes.GetIndexerNameAttribute): Remove.
16099 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
16100 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
16101 * class.cs (Indexer.Define): Likewise.
16103 2004-12-01 Marek Safar <marek.safar@seznam.cz>
16106 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
16107 MarshallByReference members access.
16109 * expression.cs: Use CheckMarshallByRefAccess;
16110 Better error CS0197 message.
16112 * report.cs: Print whole related error message.
16114 2004-11-30 Raja R Harinath <rharinath@novell.com>
16116 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
16117 the current directory to help debugging.
16119 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16121 * class (GetClassBases): Better error 60 report.
16122 (EventProperty): Disabled warning 67 detection.
16124 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16127 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
16129 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
16132 2004-11-29 Marek Safar <marek.safar@seznam.cz>
16135 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
16137 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
16139 2004-11-26 Miguel de Icaza <miguel@ximian.com>
16141 * attribute.cs (Attribute.Resolve): Refine error reporting and
16142 report a cs0117 if the identifier does not exist, to distinguish
16143 from 0617 which is a miss-use of the actual identifier.
16145 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
16146 between cs0070 and cs0079.
16148 * class.cs (MemberBase.DoDefine): When reporting a wrong
16149 accessibility level, we use MethodCore to compare instead of
16150 Method (this was a regression in some refactoring effort).
16152 So now we correctly report cs0056 again.
16154 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
16155 testing the target_type (which was known to be object_type) and
16156 not the source type (which is anonymous_method).
16158 Fixed reporting of error cs1660.
16160 * expression.cs (UserCast.Source): Expose the underlying cast.
16162 * statement.cs (Switch.SwitchGoverningType): Sort the list of
16163 allowed types to find a match to int32 first (most common).
16165 In addition, it ignores any ImplicitUserConversions that did an
16166 internal implicit conversion (as the switch statement allows only
16167 one integral conversion to exist).
16169 * class.cs (PartialContainer.Create): rename `name' to
16170 `member_name' for clarity. Then replace the string calls with a
16171 call to MemberName.GetPartialName, as now using
16172 MemberName.ToString is an error (this is due to the side effects
16173 it had, that were fixed in the past).
16175 This will restore the error reporting on a number of partial class
16176 errors that were missusing this (and getting an exception as a
16177 results, which is now just a plain textual warning, because
16178 yyparse debug output would crash otherwise).
16180 2004-11-26 Raja R Harinath <rharinath@novell.com>
16182 * Makefile (PROGRAM_INSTALL_DIR): Remove.
16184 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16186 * rootcontext.cs (LookupType): Make sure to cache lookups that
16187 don't give us a negative result. This saves about 5% of corlib
16190 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16192 * report.cs (AbstractMessage.Print): messages are sent to stderr
16194 * class.cs (TypeContainer.GetClassBases): It is an error to have a
16195 non-interface in the list of interfaces (at this point, either
16196 parent was properly set, or a base class is being listed in the
16197 interfaces section).
16199 This flags error 1722, and resolves the crash from bug 69259.
16201 2004-11-25 Ben Maurer <bmaurer@ximian.com>
16203 * statement.cs (Using.EmitExpressionFinally): make this work right
16204 for valuetypes. Fixes 69926.
16206 2004-11-25 Miguel de Icaza <miguel@ximian.com>
16208 * const.cs (Const.ChangeType): Cope with the "0 literal can be
16209 converted to an enum" here, before we try to change the underlying
16210 type. This code exists, but it is a different code path than the
16211 one used while encoding constants.
16213 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
16214 old bug: when converting from the null literal to a pointer,
16215 return an EmptyCast, not the NullLiteral.
16217 This fixes #69921, the recent null_type changes probably made this
16218 bug more prominent.
16220 (ImplicitReferenceConversionExists): In addition, resynchronized
16221 the code here, so it matches the same code in
16222 ImplicitReferenceConversionExists for the `from any class-type S
16223 to any interface-type T'.
16226 2004-11-25 Marek Safar <marek.safar@seznam.cz>
16228 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
16230 2004-11-24 Miguel de Icaza <miguel@ximian.com>
16232 * cs-parser.jay: Use verbosity accordingly.
16234 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16236 * expression.cs (Unary.ResolveOperator): Do not report warning;
16237 AddressOf reads from variable.
16239 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
16241 2004-11-24 Marek Safar <marek.safar@seznam.cz>
16245 * attribute.cs (Attributable): Removed CheckTargets.
16246 (Attributes.Emit): Explicit attribute targets are tested here.
16248 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
16249 not enabled for interfaces.
16251 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
16252 (GetAssemblyName): Ouch next bug there.
16254 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
16256 * expression.cs: Error 275 added.
16258 2004-11-23 Marek Safar <marek.safar@seznam.cz>
16260 Fix bug #69177 (Implemented decimal constant support)
16262 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
16263 (BinaryFold): Add DecimalConstant.
16265 * const.cs (Define): Decimal constant
16267 (ChangeType): Add decimal type handling.
16268 (LookupConstantValue): Don't set value for decimal type but
16269 emit DecimalConstantAttribute. Needed for constant optimization.
16271 * constant.cs (ToDecimal): New method.
16272 (ConvertToDecimal): New method.
16273 (IntConstant): Implemented ConvertToDecimal.
16274 (DecimalConstant.Emit): Emit optimized version for decimals in
16277 * expression.cs (ResolveOperator): Changed order of constant
16278 reduction to work correctly with native types which have
16279 overloaded operators.
16280 (ResolveMemberAccess): Extract constant value from attribute
16283 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
16285 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
16286 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
16287 (ChangeType): Decimal is special.
16288 (TypeToCoreType): Add decimal type.
16290 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16292 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
16295 2004-11-22 Marek Safar <marek.safar@seznam.cz>
16297 * class.cs (EventField.ApplyAttributeBuilder): Fix error
16300 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16302 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
16304 * pending.cs (PendingImplementation): Grab only interfaces.
16306 2004-11-19 Marek Safar <marek.safar@seznam.cz>
16308 * statement.cs (ForeachHelperMethods): Add location member and
16309 error 202 detection.
16311 2004-11-19 Raja R Harinath <rharinath@novell.com>
16313 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
16314 automatically handled by executable.make.
16315 (PROGRAM): Make profile-specific.
16317 2004-11-18 Marek Safar <marek.safar@seznam.cz>
16319 * expression.cs (DoResolveBase): Fixed wrong warning for out
16322 2004-11-18 Martin Baulig <martin@ximian.com>
16324 Merged latest changes into gmcs. Please keep this comment in
16325 here, it makes it easier for me to see what changed in MCS since
16326 the last time I merged.
16328 2004-11-17 Raja R Harinath <rharinath@novell.com>
16330 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
16331 (TypeHandle.GetMemberCache): New.
16332 (TypeHandle.TypeHandle): Update.
16333 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
16334 (TypeManager.LookupParentInterfacesCache):
16335 Rename from LookupInterfaceCache. Optimize slightly.
16336 (TypeManager.MemberLookup_FindMembers): Update.
16337 * decl.cs (MemberCache.MemberCache): Set Container to null in the
16338 multi-type variant.
16339 (AddCacheContents): Rename from AddHashtable.
16340 * class.cs (TypeContainer.parent_container): Remove.
16341 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
16342 (TypeContainer.DoDefineMembers): Don't initialize it.
16343 Update to name changes.
16345 2004-11-17 Miguel de Icaza <miguel@ximian.com>
16347 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
16348 that factors the code to check access modifiers on override.
16350 (PropertyBase): Use the code here.
16352 Patch from Lluis S'anchez, fixes bug #69361.
16354 2004-11-15 Miguel de Icaza <miguel@ximian.com>
16356 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
16357 routine that is used to report the use of a captured variable
16358 whose address has been taken.
16360 There are two checks: one when variables are being captured and
16361 the other check is when the address of a variable is taken.
16363 (because an anonymous methods might be resolved before *or* after
16364 the address has been taken) and
16366 * expression.cs (Conditional.DoResolve): Remove the special
16367 casing that Martin added to trueExpr and falseExpr being both
16368 NullLiteral. We get the right behavior now just by introducing
16369 the null_type into the compiler.
16371 * convert.cs (ExplicitConversion): Change the code to use
16372 null_type instead of testing `expr is NullLiteral'.
16373 (ImplicitConversionStandard): use null_type too.
16374 (ImplicitReferenceConversionExists): use null_type too.
16375 (ImplicitReferenceConversion): use null_type too.
16377 * literal.cs: The type of `NullLiteral' is now null_type instead
16379 (Resolve): Set the type here.
16381 * typemanager.cs: Introduce null_type.
16383 2004-11-17 Martin Baulig <martin@ximian.com>
16385 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16386 direction, like FindMembers() does. Fixes #69546, testcase is in
16389 2004-11-16 Martin Baulig <martin@ximian.com>
16391 This is based on a patch from Marek Safar, see bug #69082.
16392 Fixes bugs #63705 and #67130.
16394 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16395 method; create a MemberCache for an interface type and cache the
16398 * decl.cs (IMemberContainer.ParentContainer): Removed.
16399 (IMemberContainer.ParentCache): New property.
16400 (MemberCache.SetupCacheForInterface): Removed.
16401 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16402 to create a cache for an interface's "parent".
16404 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16407 2004-11-16 Martin Baulig <martin@ximian.com>
16409 Merged back from gmcs; these changes already went into gmcs a
16410 couple of weeks ago.
16413 (TypeManager.AddUserType): Removed the `ifaces' argument.
16414 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16416 (TypeManager.AddUserInterface): Removed.
16417 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16419 (TypeManager.GetInterfaces): Likewise.
16420 (TypeManager.GetExplicitInterfaces): Likewise.
16422 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16424 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16425 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16427 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16429 * statement.cs: Avoid adding bools to a hashtable.
16431 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16433 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16434 calling an unsafe method from a safe location.
16436 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16439 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16441 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16443 * namespace.cs (VerifyUsing): use GetPartialName instead of
16446 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16448 * statement.cs (Return.Resolve): Fix regression in typo: if
16449 `in_exc', we have to request a NeedReturnLabel, this was a typo
16450 introduced in the anonymous method check-in. Fixes #69131.
16452 * Indexers were using the ShortName when defining themselves,
16453 causing a regression in the compiler bootstrap when applying the
16454 patch from 2004-11-02 (first part), now they use their full name
16455 and the bug is gone.
16457 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16459 * driver.cs: Strip the path from the names of embedded resources. Fixes
16462 2004-11-04 Raja R Harinath <rharinath@novell.com>
16464 Fix error message regression: cs0104-2.cs.
16465 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16466 (AliasEntry.Resolve): Update.
16467 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16469 (RootContext.LookupType): Update.
16471 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16473 * cs-parser.jay: Add support for handling accessor modifiers
16474 * class: Add support port accessor modifiers and error checking,
16475 define PropertyMethod.Define as virtual (not abstract anymore)
16476 * ecore.cs: Add checking for proeprties access with access modifiers
16477 * iterators.cs: Modify Accessor constructor call based in the modified
16479 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16481 * expression.cs (StringConcat): Handle being called twice,
16482 as when we have a concat in a field init with more than two
16485 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16487 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16488 special case explicit implementations, we should always produce
16489 the .property or .event declaration.
16491 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16492 since it will not return correct data if people use this
16493 unresolved in the presence of using statements (see test-313).
16495 * class.cs (MethodData.Define): If we are an explicit interface
16496 implementation, set the method name to the full name of the
16497 interface plus the name of the method.
16499 Notice that using the method.MethodName.GetFullName() does not
16500 work, as it will only contain the name as declared on the source
16501 file (it can be a shorthand in the presence of using statements)
16502 and not the fully qualifed type name, for example:
16506 class D : ICloneable {
16507 object ICloneable.Clone () {
16511 Would produce a method called `ICloneable.Clone' instead of
16512 `System.ICloneable.Clone'.
16514 * namespace.cs (Alias.Resolve): Use GetPartialName.
16516 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16518 * cs-parser.jay: Add error 1055 report.
16520 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16522 * assign.cs (Assign.DoResolve): Only do the transform of
16523 assignment into a New if the types are compatible, if not, fall
16524 through and let the implicit code deal with the errors and with
16525 the necessary conversions.
16527 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16529 * cs-parser.jay: Add error 1031 report.
16531 * cs-tokenizer.cs: Add location for error 1038.
16533 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16535 * cs-parser.jay: Add error 1016 report.
16537 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16539 * cs-parser.jay: Add errors 1575,1611 report.
16541 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16543 * cs-parser.jay: Add error 1001 report.
16545 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16548 * attribute.cs (GetMarshal): Add method argument for
16549 caller identification.
16551 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16552 agument for GetMarshal and RuntimeMissingSupport.
16554 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16556 * attribute.cs (ExtractSecurityPermissionSet): Removed
16557 TypeManager.code_access_permission_type.
16559 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16561 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16563 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16564 for obsolete use of a variable here. Fixes regression on errors
16565 cs0619-25 and cs0619-26.
16567 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16569 Fix #62358, implemented security attribute encoding.
16571 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16572 Tests permitted SecurityAction for assembly or other types.
16573 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16574 data from SecurityPermissionAttribute to PermisionSet class.
16576 * class.cs (ApplyAttributeBuilder): Added special handling
16577 for System.Security.Permissions.SecurityAttribute based types.
16579 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16580 special handling for System.Security.Permissions.SecurityAttribute
16583 * enum.cs (ApplyAttributeBuilder): Added special handling
16584 for System.Security.Permissions.SecurityAttribute based types.
16586 * parameter.cs (ApplyAttributeBuilder): Added special handling
16587 for System.Security.Permissions.SecurityAttribute based types.
16589 * rootcontext.cs: Next 2 core types.
16591 * typemanager.cs (TypeManager.security_permission_attr_type):
16592 Built in type for the SecurityPermission Attribute.
16593 (code_access_permission_type): Build in type.
16595 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16597 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16598 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16599 all of this information into
16600 EmitContext.EmitCapturedVariableInstance.
16602 * codegen.cs (EmitCapturedVariableInstance): move here the
16603 funcionality of emitting an ldarg.0 in the presence of a
16604 remapping. This centralizes the instance emit code.
16606 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16607 then emit a load of this: it means that we have reached the
16608 topmost ScopeInfo: the one that contains the pointer to the
16609 instance of the class hosting the anonymous method.
16611 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16612 captures to the topmost CaptureContext.
16614 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16616 * expression.cs (LocalVariableReference): Move the knowledge about
16617 the iterators into codegen's EmitCapturedVariableInstance.
16619 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16621 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16622 all code paths return a value from an anonymous method (it is the
16623 same as the 161 error, but for anonymous methods).
16625 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16627 The introduction of anonymous methods in the compiler changed
16628 various ways of doing things in the compiler. The most
16629 significant one is the hard split between the resolution phase
16630 and the emission phases of the compiler.
16632 For instance, routines that referenced local variables no
16633 longer can safely create temporary variables during the
16634 resolution phase: they must do so from the emission phase,
16635 since the variable might have been "captured", hence access to
16636 it can not be done with the local-variable operations from the runtime.
16640 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16641 is a toplevel block.
16643 (ToplevelBlock): A new kind of Block, these are the blocks that
16644 are created by the parser for all toplevel method bodies. These
16645 include methods, accessors and anonymous methods.
16647 These contain some extra information not found in regular blocks:
16648 A pointer to an optional CaptureContext (for tracking captured
16649 local variables and parameters). A pointer to the parent
16652 (Return.Resolve): Catch missmatches when returning a value from an
16653 anonymous method (error 1662).
16654 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16657 (Break.Resolve): ditto.
16659 (SwitchLabel): instead of defining the labels during the
16660 resolution phase, we now turned the public ILLabel and ILLabelCode
16661 labels into methods called GetILLabelCode() and GetILLabel() that
16662 only define the label during the Emit phase.
16664 (GotoCase): Track the SwitchLabel instead of the computed label
16665 (its contained therein). Emit the code by using
16666 SwitchLabel.GetILLabelCode ().
16668 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16669 whether the Local has been captured or not.
16671 (LocalInfo.IsCaptured): New property, used to tell whether the
16672 local has been captured.
16674 * anonymous.cs: Vastly updated to contain the anonymous method
16677 The main classes here are: CaptureContext which tracks any
16678 captured information for a toplevel block and ScopeInfo used to
16679 track the activation frames for various local variables.
16681 Each toplevel block has an optional capture context associated
16682 with it. When a method contains an anonymous method both the
16683 toplevel method and the anonymous method will create a capture
16684 context. When variables or parameters are captured, they are
16685 recorded on the CaptureContext that owns them, for example:
16689 MyDelegate d = delegate {
16694 Here `a' will be recorded as captured on the toplevel
16695 CapturedContext, the inner captured context will not have anything
16696 (it will only have data if local variables or parameters from it
16697 are captured in a nested anonymous method.
16699 The ScopeInfo is used to track the activation frames for local
16700 variables, for example:
16702 for (int i = 0; i < 10; i++)
16703 for (int j = 0; j < 10; j++){
16704 MyDelegate d = delegate {
16709 At runtime this captures a single captured variable `i', but it
16710 captures 10 different versions of the variable `j'. The variable
16711 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16712 recorded on a child.
16714 The toplevel ScopeInfo will also track information like the `this'
16715 pointer if instance variables were referenced (this is necessary
16716 as the anonymous method lives inside a nested class in the host
16717 type of the method).
16719 (AnonymousMethod): Expanded to track the Toplevel, implement
16720 `AnonymousMethod.Compatible' to tell whether an anonymous method
16721 can be converted to a target delegate type.
16723 The routine now also produces the anonymous method content
16725 (AnonymousDelegate): A helper class that derives from
16726 DelegateCreation, this is used to generate the code necessary to
16727 produce the delegate for the anonymous method that was created.
16729 * assign.cs: API adjustments for new changes in
16730 Convert.ImplicitStandardConversionExists.
16732 * class.cs: Adjustments to cope with the fact that now toplevel
16733 blocks are of type `ToplevelBlock'.
16735 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16736 insteda of standard blocks.
16738 Flag errors if params arguments are passed to anonymous methods.
16740 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16741 `CurrentAnonymousMethod' which points to the current Anonymous
16742 Method. The variable points to the AnonymousMethod class that
16743 holds the code being compiled. It is set in the new EmitContext
16744 created for the anonymous method.
16746 (EmitContext.Phase): Introduce a variable and an enumeration to
16747 assist in enforcing some rules about when and where we are allowed
16748 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16749 only one that enfonces this right now).
16751 (EmitContext.HaveCaptureInfo): new helper method that returns
16752 whether we have a CapturedContext initialized.
16754 (EmitContext.CaptureVariable): New method used to register that a
16755 LocalInfo must be flagged for capturing.
16757 (EmitContext.CapturedParameter): New method used to register that a
16758 parameters must be flagged for capturing.
16760 (EmitContext.CapturedField): New method used to register that a
16761 field must be flagged for capturing.
16763 (EmitContext.HaveCapturedVariables,
16764 EmitContext.HaveCapturedFields): Return whether there are captured
16765 variables or fields.
16767 (EmitContext.EmitMethodHostInstance): This is used to emit the
16768 instance for the anonymous method. The instance might be null
16769 (static methods), this (for anonymous methods that capture nothing
16770 and happen to live side-by-side with the current method body) or a
16771 more complicated expression if the method has a CaptureContext.
16773 (EmitContext.EmitTopBlock): Routine that drives the emission of
16774 code: it will first resolve the top block, then emit any metadata
16775 and then emit the code. The split is done so that we can extract
16776 any anonymous methods and flag any captured variables/parameters.
16778 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16779 during this phase, the ILGenerator should not be used as labels
16780 and local variables declared here might not be accessible to any
16781 code that is part of an anonymous method.
16783 Exceptions to this include the temporary variables that are
16784 created by some statements internally for holding temporary
16787 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16790 (EmitContext.TemporaryReturn): This method is typically called
16791 from the Emit phase, and its the only place where we allow the
16792 ReturnLabel to be defined other than the EmitMeta. The reason is
16793 that otherwise we would have to duplicate a lot of logic in the
16794 Resolve phases of various methods that today is on the Emit
16797 (EmitContext.NeedReturnLabel): This no longer creates the label,
16798 as the ILGenerator is not valid during the resolve phase.
16800 (EmitContext.EmitThis): Extended the knowledge in this class to
16801 work in anonymous methods in addition to iterators.
16803 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16804 code is necessary on the stack to access the instance to a local
16805 variable (the variable will be accessed as a field).
16807 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16808 EmitContext.EmitAddressOfParameter): Routines to support
16809 parameters (not completed at this point).
16811 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16812 will also remove the parameters.
16814 * convert.cs (Convert): Define a `ConstantEC' which points to a
16815 null. This is just to prefity some code that uses
16816 ImplicitStandardConversion code and do not have an EmitContext
16819 The idea is to flag explicitly that at that point in time, it is
16820 known that the conversion will not trigger the delegate checking
16821 code in implicit conversions (which requires a valid
16824 Everywhere: pass new EmitContext parameter since
16825 ImplicitStandardConversionExists now requires it to check for
16826 anonymous method conversions.
16828 (Convert.ImplicitStandardConversionExists): If the type of an
16829 expression is the anonymous_method_type, and the type is a
16830 delegate, we invoke the AnonymousMethod.Compatible method to check
16831 whether an implicit conversion is possible.
16833 (Convert.ImplicitConversionStandard): Only do implicit method
16834 group conversions if the language level is not ISO_1.
16836 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16837 MethodInfo for the Invoke method. used by Delegate and
16840 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16841 method conversions if the target type is a delegate.
16843 Removed extra debugging nops.
16845 (LocalVariableReference): Turn the `local_info' into a public
16848 Add `prepared' field, the same hack used for FieldExprs to cope
16849 with composed assignments, as Local variables do not necessarily
16850 operate purely on the stack as they used to: they can be captured
16853 Add `temp' for a temporary result, like fields.
16855 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16857 It now copes with Local variables that are captured and emits the
16858 proper instance variable to load it from a field in the captured
16861 (ParameterReference.DoResolveBase): During the resolve phase,
16862 capture parameters if we are in an anonymous method.
16864 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16865 anonymous method, use the EmitContext helper routines to emit the
16866 parameter reference.
16868 * iterators.cs: Set RemapToProxy to true/false during the
16871 * parameters.cs (GetParameterByName): New helper method.
16873 * typemanager.cs (anonymous_method_type) a new type that
16874 represents an anonyous method. This is always an internal type,
16875 used as a fencepost to test against the anonymous-methodness of an
16878 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16880 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16882 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16884 2004-10-18 Martin Baulig <martin@ximian.com>
16886 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16887 `Type' directly, but call ResolveType() on it.
16888 (Catch.Resolve): Likewise.
16889 (Foreach.Resolve): Likewise.
16891 2004-10-18 Martin Baulig <martin@ximian.com>
16893 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16894 `Type' directly, but call ResolveType() on it.
16895 (Probe.DoResolve): Likewise.
16896 (ArrayCreation.LookupType): Likewise.
16897 (TypeOf.DoResolve): Likewise.
16898 (SizeOf.DoResolve): Likewise.
16900 2004-10-18 Martin Baulig <martin@ximian.com>
16902 * expression.cs (Invocation.BetterFunction): Put back
16903 TypeManager.TypeToCoreType().
16905 2004-10-18 Raja R Harinath <rharinath@novell.com>
16907 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16910 2004-10-18 Martin Baulig <martin@ximian.com>
16912 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16913 `Type' directly, but call ResolveType() on it.
16915 2004-10-18 Martin Baulig <martin@ximian.com>
16917 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16918 `Type' directly, but call ResolveType() on it.
16919 (MemberBase.DoDefine): Likewise.
16921 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16922 `Type' directly, but call ResolveType() on it.
16923 (ComposedCast.DoResolveAsTypeStep): Likewise.
16925 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16926 `Type' directly, but call ResolveType() on it.
16928 2004-10-17 John Luke <john.luke@gmail.com>
16930 * class.cs (Operator.GetSignatureForError): use CSharpName
16932 * parameter.cs (Parameter.GetSignatureForError): Returns
16933 correct name even if was not defined.
16935 2004-10-13 Raja R Harinath <rharinath@novell.com>
16938 * class.cs (TypeContainer.EmitContext): New property.
16939 (DefineNestedTypes): Create an emitcontext for each part.
16940 (MethodCore.DoDefineParameters): Use container's emitcontext.
16941 Pass type array to InternalParameters.
16942 (MemberBase.DoDefine): Use container's emitcontext.
16943 (FieldMember.Define): Likewise.
16944 (Event.Define): Likewise.
16945 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16946 Pass type array to InternalParameters.
16947 (SetIndexerMethod.GetParameterInfo): Likewise.
16948 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16949 * delegate.cs (Define): Pass emitcontext to
16950 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16951 array to InternalParameters.
16952 * expression.cs (ParameterReference.DoResolveBase): Pass
16953 emitcontext to GetParameterInfo.
16954 (ComposedCast.DoResolveAsTypeStep): Remove check on
16955 ec.ResolvingTypeTree.
16956 * parameter.cs (Parameter.Resolve): Change argument to
16957 EmitContext. Use ResolveAsTypeTerminal.
16958 (Parameter.GetSignature): Change argument to EmitContext.
16959 (Parameters.ComputeSignature): Likewise.
16960 (Parameters.ComputeParameterTypes): Likewise.
16961 (Parameters.GetParameterInfo): Likewise.
16962 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16963 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16964 * support.cs (InternalParameters..ctor): Remove variant that takes
16966 * typemanager.cs (system_intptr_expr): New.
16967 (InitExpressionTypes): Initialize it.
16969 2004-10-12 Chris Toshok <toshok@ximian.com>
16971 * cs-parser.jay: fix location for try_statement and catch_clause.
16973 2004-10-11 Martin Baulig <martin@ximian.com>
16975 * report.cs: Don't make --fatal abort on warnings, we have
16976 -warnaserror for that.
16978 2004-10-07 Raja R Harinath <rharinath@novell.com>
16980 More DeclSpace.ResolveType avoidance.
16981 * decl.cs (MemberCore.InUnsafe): New property.
16982 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16983 with newly created EmitContext.
16984 (FieldMember.Define): Likewise.
16985 * delegate.cs (Delegate.Define): Likewise.
16986 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16987 only if normal name-lookup fails.
16988 (TypeExpr.DoResolve): Enable error-checking.
16989 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16990 (SizeOf.DoResolve): Likewise.
16991 (ComposedCast.DoResolveAsTypeStep): Likewise.
16992 (StackAlloc.DoResolve): Likewise.
16993 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16994 (Block.Unsafe): New property.
16995 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16996 (Unsafe): Set 'unsafe' flag of contained block.
16997 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16998 (Fixed.Resolve): Likewise.
16999 (Catch.Resolve): Likewise.
17000 (Using.ResolveLocalVariableDecls): Likewise.
17001 (Foreach.Resolve): Likewise.
17003 2004-10-05 John Luke <john.luke@gmail.com>
17005 * cs-parser.jay: add location to error CS0175
17007 2004-10-04 Miguel de Icaza <miguel@ximian.com>
17009 * ecore.cs (Expression.Constantity): Add support for turning null
17012 * const.cs (Const.Define): Allow constants to be reference types
17013 as long as the value is Null.
17015 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
17017 * namespace.cs (NamespaceEntry.Using): No matter which warning
17018 level is set, check if this namespace name has already been added.
17020 2004-10-03 Ben Maurer <bmaurer@ximian.com>
17022 * expression.cs: reftype [!=]= null should always use br[true,false].
17025 2004-10-03 Marek Safar <marek.safar@seznam.cz>
17028 * attribute.cs: Enum conversion moved to
17029 GetAttributeArgumentExpression to be applied to the all
17032 2004-10-01 Raja R Harinath <rharinath@novell.com>
17034 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
17035 * class.c (TypeContainer.DefineType): Flag error if
17036 base types aren't accessible due to access permissions.
17037 * decl.cs (DeclSpace.ResolveType): Move logic to
17038 Expression.ResolveAsTypeTerminal.
17039 (DeclSpace.ResolveTypeExpr): Thin layer over
17040 Expression.ResolveAsTypeTerminal.
17041 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
17042 Refactor code into NestedAccess. Use it.
17043 (DeclSpace.NestedAccess): New.
17044 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
17045 argument to silence errors. Check access permissions.
17046 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
17047 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
17048 (Cast.DoResolve): Likewise.
17049 (New.DoResolve): Likewise.
17050 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
17051 (TypeOf.DoResolve): Likewise.
17053 * expression.cs (Invocation.BetterConversion): Return the Type of
17054 the better conversion. Implement section 14.4.2.3 more faithfully.
17055 (Invocation.BetterFunction): Make boolean. Make correspondence to
17056 section 14.4.2.2 explicit.
17057 (Invocation.OverloadResolve): Update.
17058 (Invocation): Remove is_base field.
17059 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
17060 (Invocation.Emit): Likewise.
17062 2004-09-27 Raja R Harinath <rharinath@novell.com>
17064 * README: Update to changes.
17066 2004-09-24 Marek Safar <marek.safar@seznam.cz>
17068 * cs-parser.jay: Reverted 642 warning fix.
17070 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17073 * decl.cs (FindMemberWithSameName): Indexer can have more than
17076 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17078 * expression.cs (LocalVariableReference.DoResolveLValue):
17079 Do not report warning 219 for out values.
17080 (EmptyExpression.Null): New member to avoid extra allocations.
17082 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17084 * cs-parser.jay: Fix wrong warning 642 report.
17086 * cs-tokenizer.cs (CheckNextToken): New helper;
17087 Inspect next character if is same as expected.
17089 2004-09-23 Martin Baulig <martin@ximian.com>
17091 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
17092 (Convert.ImplicitReferenceConversionExists): Likewise.
17094 2004-09-23 Marek Safar <marek.safar@seznam.cz>
17096 * class.cs (Operator.Define): Add error 448 and 559 report.
17098 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17100 * class.cs (MemberBase.IsTypePermitted): New protected
17101 method for checking error CS0610.
17103 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17105 * class.cs (TypeContainer.HasExplicitLayout): New property
17106 Returns whether container has StructLayout attribute set Explicit.
17107 (FieldMember): New abstract class for consts and fields.
17108 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
17109 (Field): Reuse FieldMember.
17111 * const.cs (Const): Reuse FieldMember.
17113 * rootcontext.cs: EmitConstants call moved to class.
17115 2004-09-22 Martin Baulig <martin@ximian.com>
17117 Thanks to Peter Sestoft for this bug report.
17119 * expression.cs (Conditional): If both the `trueExpr' and the
17120 `falseExpr' is a NullLiteral, return a NullLiteral.
17122 2004-09-22 Martin Baulig <martin@ximian.com>
17124 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
17125 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
17126 for the "get_Current" call.
17128 2004-09-22 Martin Baulig <martin@ximian.com>
17130 Marek and me just fixed one of our oldest bugs: #28562 :-)
17132 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
17134 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
17135 we're an EnumConstant, just return that.
17136 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
17137 an EnumConstant. In this case, we need to use GetValueAsEnumType()
17138 to get the value which'll actually be written into the attribute.
17139 However, we have to use GetValue() to access the attribute's value
17142 2004-09-22 Marek Safar <marek.safar@seznam.cz>
17144 * constant.cs (Constant.IsNegative): New abstract property
17147 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
17148 (StackAlloc.DoResolve): Reused IsNegative.
17150 2004-09-21 Martin Baulig <martin@ximian.com>
17152 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
17153 if we're used in an iterator, we may be called from different
17156 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
17157 we actually have an exception block.
17159 2004-09-20 John Luke <jluke@cfl.rr.com>
17161 * class.cs, cs-parser.jay: Improve the error report for 1520:
17162 report the actual line where the error happens, not where the
17163 class was declared.
17165 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
17166 Pass location information that was available elsewhere.
17168 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
17170 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
17171 runtime to delay sign assemblies.
17173 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17175 * cs-parser.jay: Do not report the stack trace, this is barely
17178 2004-08-22 John Luke <john.luke@gmail.com>
17180 * driver.cs : check that a resource id is not already used
17181 before adding it, report CS1508 if it is, bug #63637
17183 2004-09-19 Miguel de Icaza <miguel@ximian.com>
17185 * ecore.cs: Removed dead code.
17187 2004-09-18 Marek Safar <marek.safar@seznam.cz>
17189 * class.cs: Do not report warning CS0067 on the interfaces.
17191 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17193 * cs-parser.jay: Add error 504 report.
17195 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17197 * rootcontext.cs: WarningLevel is 4 by default now.
17199 * statement.cs (Fixed.Resolve): Do not null
17202 2004-09-16 Marek Safar <marek.safar@seznam.cz>
17205 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
17206 deep search when property is not virtual.
17207 (PropertyExpr.ResolveAccessors): Make one call for both
17210 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17213 * statement.cs: Error 152 report constains also location.
17215 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17218 * const.cs: Explicitly set constant as static.
17220 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17223 * cs-parser.jay: Add error 1017 report.
17225 2004-09-15 Marek Safar <marek.safar@seznam.cz>
17227 Fixed bug #59980, #64224
17228 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
17230 * typemanager.cs (IsSpecialMethod): Simplified
17232 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17234 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
17235 condition with better params.
17237 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17240 * attribute.cs (Resolve): Property has to have both
17243 2004-09-14 Martin Baulig <martin@ximian.com>
17245 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
17247 2004-09-14 Marek Safar <marek.safar@seznam.cz>
17250 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
17251 called and is obsolete then this member suppress message
17252 when call is inside next [Obsolete] method or type.
17254 * expression.cs: Use TestObsoleteMethodUsage member.
17256 2004-09-14 Martin Baulig <martin@ximian.com>
17258 * cs-parser.jay: Sync a bit with the GMCS version.
17260 2004-09-14 Martin Baulig <martin@ximian.com>
17262 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
17263 (CSharpParser.yacc_verbose_flag): New public field.
17265 * genericparser.cs: Removed.
17267 2004-09-14 Raja R Harinath <rharinath@novell.com>
17269 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
17271 2004-09-13 Marek Safar <marek.safar@seznam.cz>
17273 * class.cs (MethodCore.CheckBase): Fix bug #65757.
17275 2004-09-10 Martin Baulig <martin@ximian.com>
17277 Backported my MemberName changes from GMCS into MCS.
17279 - we are now using a special `MemberName' class instead of using
17280 strings; in GMCS, the `MemberName' also contains the type
17283 - changed the grammar rules a bit:
17284 * the old `member_name' is now a `namespace_or_type_name':
17285 The rule is that we use `namespace_or_type_name' everywhere
17286 where we expect either a "member name" (GetEnumerator) or a
17287 "member name" with an explicit interface name
17288 (IEnumerable.GetEnumerator).
17289 In GMCS, the explicit interface name may include type arguments
17290 (IEnumerable<T>.GetEnumerator).
17291 * we use `member_name' instead of just `IDENTIFIER' for
17293 The rule is that we use `member_name' wherever a member may
17294 have type parameters in GMCS.
17296 * decl.cs (MemberName): New public class.
17297 (MemberCore.MemberName): New public readonly field.
17298 (MemberCore.ctor): Take a `MemberName' argument, not a string.
17299 (DeclSpace): Likewise.
17301 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
17302 * enum.cs (Enum.ctor): Likewise.
17304 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
17306 (AliasEntry.ctor): Take a MemberName, not an Expression.
17307 (AliasEntry.UsingAlias): Likewise.
17309 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
17310 (IMethodData.MemberName): Changed type from string to MemberName.
17311 (MemberBase.ExplicitInterfaceName): Likewise.
17312 (AbstractPropertyEventMethod.SetupName): Make this private.
17313 (AbstractPropertyEventMethod.ctor): Added `string prefix'
17314 argument; compute the member name here.
17315 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
17316 on the `member.MemberName' and the `prefix'.
17318 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
17320 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
17321 thus, we get a `MemberName' instead of a `string'. These
17322 declarations may have type parameters in GMCS.
17323 (interface_method_declaration, delegate_declaration): Likewise.
17324 (class_declaration, interface_declaration): Likewise.
17325 (method_header): Use `namespace_or_type_name' instead of
17326 `member_name'. We may be an explicit interface implementation.
17327 (property_declaration, event_declaration): Likewise.
17328 (member_name): This is now just an `IDENTIFIER', not a
17329 `namespace_or_type_name'.
17330 (type_name, interface_type): Removed.
17331 (namespace_or_type_name): Return a MemberName, not an Expression.
17332 (primary_expression): Use `member_name' instead of `IDENTIFIER';
17333 call GetTypeExpression() on the MemberName to get an expression.
17334 (IndexerDeclaration.interface_type): Changed type from string to
17336 (MakeName): Operate on MemberName's instead of string's.
17338 2004-09-13 Raja R Harinath <rharinath@novell.com>
17341 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
17342 (NamespaceEntry.Lookup): Add new argument to flag if we want the
17343 lookup to avoid symbols introduced by 'using'.
17344 * rootcontext.cs (NamespaceLookup): Update.
17346 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17348 * class.cs (TypeContainer.DoDefineMembers): Do not call
17349 DefineDefaultConstructor for static classes.
17351 2004-09-12 Marek Safar <marek.safar@seznam.cz>
17353 * attribute.cs (Attribute.Resolve): Add error 653 report.
17355 * class.cs (Class.ApplyAttributeBuilder): Add error 641
17357 (Method.ApplyAttributeBuilder): Add error 685 report.
17358 (Operator.Define): Add error 564 report.
17360 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
17362 * expression.cs (Invocation.DoResolve): Add error
17363 245 and 250 report.
17365 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17368 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17370 * class.cs (ConstructorInitializer.Resolve):
17371 Wrong error number (515->516).
17373 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17375 * class.cs (Indexer.Define): Add error 631 report.
17377 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17379 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17381 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17383 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17385 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17387 * cs-parser.jay: Added error CS0241 report.
17389 2004-09-10 Raja R Harinath <rharinath@novell.com>
17391 * cs-parser.jay (fixed_statement): Introduce a scope for the
17392 declaration in the 'fixed' statement.
17394 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17396 * cs-parser.jay: Added CS0230 error report.
17398 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17400 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17402 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17404 * expression.cs (Argument.Resolve): Added error CS0192 and
17407 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17409 C# 2.0 #pragma warning feature
17411 * cs-tokenizer.cs (PreProcessPragma): New method;
17412 Handles #pragma directive.
17414 * report.cs (WarningRegions): New class; Support
17415 class for #pragma warning directive. It tests whether
17416 warning is enabled for a given line.
17418 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17420 * const.cs: Add more descriptive error report, tahnks to
17423 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17425 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17427 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17429 * expression.cs: Apply patch from Ben: Remove dead code from
17430 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17431 as that code just threw an exception anwyays.
17433 * const.cs: Remove the call to the turnintoconstant, for details
17436 * literal.cs: The type of the null-literal is the null type; So
17437 we use a placeholder type (literal.cs:System.Null, defined here)
17440 * expression.cs (Conditional.DoResolve): Remove some old code that
17441 is no longer needed, conversions have been fixed.
17443 (ArrayCreationExpression.DoResolve): Return false if we fail to
17444 resolve the inner expression.
17446 2004-09-07 Raja R Harinath <rharinath@novell.com>
17449 * cs-parser.jay (delegate_declaration): Record a delegate
17450 declaration as a type declaration.
17451 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17453 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17455 * parameter.cs: Do not crash if the type can not be resolved.
17457 * expression.cs: Report errors with unsafe pointers, fixes #64896
17459 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17461 * expression.cs: Pointer arith always needs to do a conv.i
17462 if the operand is a long. fix 65320
17464 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17466 Fixed cs0619-37.cs, cs0619-38.cs
17468 * enum.cs (GetObsoleteAttribute): Removed.
17470 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17471 on Enum member is double staged. The first is tested member
17474 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17476 Fixed #56986, #63631, #65231
17478 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17479 adds member to name container.
17480 (TypeContainer.AddToTypeContainer): New method, adds type to
17482 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17483 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17484 AddOperator): Simplified by reusing AddToMemberContainer.
17485 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17487 (Method.CheckForDuplications): Fixed implementation to test all
17489 (MemberBase): Detection whether member is explicit interface
17490 implementation is now in constructor.
17491 (MemberBase.UpdateMemberName): Handles IndexerName.
17492 (Accessor): Changed to keep also location information.
17493 (AbstractPropertyEventMethod): Is derived from MemberCore.
17494 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17495 will be emited or not.
17496 (PropertyBase.AreAccessorsDuplicateImplementation):
17497 Tests whether accessors are not in collision with some method.
17498 (Operator): Is derived from MethodCore to simplify common
17501 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17503 (DeclSpace.AddToContainer): Adds the member to defined_names
17504 table. It tests for duplications and enclosing name conflicts.
17506 * enum.cs (EnumMember): Clean up to reuse the base structures
17508 2004-09-03 Martin Baulig <martin@ximian.com>
17510 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17511 into TypeContainer, to make partial classes work again.
17513 2004-09-03 Martin Baulig <martin@ximian.com>
17515 * rootcontext.cs (RootContext.V2): Removed.
17517 2004-03-23 Martin Baulig <martin@ximian.com>
17519 * expression.cs (Invocation.OverloadResolve): Added `bool
17520 may_fail' argument and use it instead of the Location.IsNull() hack.
17522 2004-09-03 Martin Baulig <martin@ximian.com>
17524 Merged latest changes into gmcs. Please keep this comment in
17525 here, it makes it easier for me to see what changed in MCS since
17526 the last time I merged.
17528 2004-09-03 Raja R Harinath <rharinath@novell.com>
17531 * expression.cs (BetterConversion): Don't allow either conversion
17532 to be null. Remove redundant implicit conversion test when 'q ==
17533 null' -- when this function is invoked, we already know that the
17534 implicit conversion exists.
17535 (BetterFunction): Assume that 'best' is non-null. Remove
17536 redundant reimplementation of IsApplicable when 'best' is null.
17537 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17538 number of arguments.
17539 (IsAncestralType): Extract from OverloadResolve.
17540 (OverloadResolve): Make robust to the MethodGroupExpr being
17541 unsorted. Implement all the logic of Section 14.5.5.1, and
17542 support overloading of methods from multiple applicable types.
17543 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17545 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17546 (RealError, Warning): Append type of report to related symbol.
17548 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17550 * enum.cs: Fixed CLS-Compliance checks for enum members.
17551 Error tests cs3008-8.cs, cs3014-8.cs
17553 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17555 Fixed bug #62342, #63102
17556 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17557 like ImplementMethod.
17559 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17561 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17564 2004-09-02 Martin Baulig <martin@ximian.com>
17566 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17567 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17570 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17572 C# 2.0 Static classes implemented
17574 * class.cs (TypeContainer): instance_constructors,
17575 initialized_fields, initialized_static_fields,
17576 default_constructor, base_inteface_types are protected to be
17577 accessible from StaticClass.
17578 (TypeContainer.DefineDefaultConstructor): New virtual method
17579 for custom default constructor generating
17580 (StaticClass): New class to handle "Static classes" feature.
17582 * cs-parser.jay: Handle static keyword on class like instance
17585 * driver.cs: Added "/langversion" command line switch with two
17586 options (iso-1, default).
17588 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17590 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17592 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17594 * delegate.cs: Style.
17596 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17598 * delegate.cs: Add seperate instance expr field for miguel.
17600 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17602 * PointerArithmetic (Resolve): make sure we are not doing
17603 pointer arith on void*. Also, make sure we are resolved
17604 by not setting eclass until resolve.
17606 All callers: Make sure that PointerArithmetic gets resolved.
17608 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17610 * ArrayCreation (LookupType): If the type does not resolve
17611 to an array, give an error.
17613 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17615 * statement.cs (Try.Resolve): Fixed bug #64222
17617 2004-08-27 Martin Baulig <martin@ximian.com>
17620 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17623 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17625 * ecore.cs (Constantify): Get underlying type via
17626 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17627 Windows in special cases.
17629 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17631 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17632 for obtaining also private methods.
17633 (GetRemoveMethod): Used GetRemoveMethod (true)
17634 for obtaining also private methods.
17636 2004-08-24 Martin Baulig <martin@ximian.com>
17638 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17639 MethodAttributes.HideBySig for operators.
17641 2004-08-23 Martin Baulig <martin@ximian.com>
17643 Back to the old error reporting system :-)
17645 * report.cs (Message): Removed.
17646 (Report.MessageData, ErrorData, WarningData): Removed.
17647 (Report.Error, Warning): Back to the old system.
17649 2004-08-23 Martin Baulig <martin@ximian.com>
17651 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17653 * class.cs (TypeContainer.ParentContainer): New public virtual
17654 method; replaces the explicit interface implementation.
17655 (ClassPart.ParentContainer): Override.
17657 2004-08-23 Martin Baulig <martin@ximian.com>
17659 * statement.cs (Switch): Added support for constant switches; see
17660 #59428 or test-285.cs.
17662 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17665 * statement.cs (GetEnumeratorFilter): Removed useless
17666 logic because C# specs is strict. GetEnumerator must be
17669 2004-08-22 Martin Baulig <martin@ximian.com>
17671 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17672 a switch and may break, reset the barrier. Fixes #59867.
17674 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17676 CLS-Compliance speed up (~5% for corlib)
17678 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17679 New method. Tests container for CLS-Compliant names
17681 * class.cs (TypeContainer.VerifyClsName): New method.
17682 Checks whether container name is CLS Compliant.
17683 (Constructor): Implements IMethodData.
17685 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17686 low-case table for CLS Compliance test.
17687 (MemberCache.VerifyClsParameterConflict): New method.
17688 Checks method parameters for CS3006 error.
17690 * enum.cs (EnumMember): Is derived from MemberCore.
17691 (Enum.VerifyClsName): Optimized for better performance.
17693 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17695 * report.cs: Renamed Error_T to Error and changed all
17698 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17700 * class.cs (TypeContainer.IndexerArrayList): New inner class
17701 container for indexers.
17702 (TypeContainer.DefaultIndexerName): New constant for default
17703 indexer name. Replaced all "Item" with this constant.
17704 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17706 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17707 DefaultMemberAttribute constructor.
17709 2004-08-05 Martin Baulig <martin@ximian.com>
17711 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17714 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17716 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17717 multi platforms problem.
17719 * compiler.csproj: Included shared files.
17721 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17723 Fix bug 60333, 55971 in the more general way
17724 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17725 Added arg_type argument for constant conversion.
17726 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17728 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17731 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17732 OperatorArrayList, MethodCoreArrayList for typecontainer
17733 containers. Changed class member types to these new types.
17734 (MethodArrayList.DefineMembers): Added test for CS0659.
17736 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17738 * cfold.cs: Synchronize the folding with the code in expression.cs
17739 Binary.DoNumericPromotions for uint operands.
17741 * attribute.cs: Revert patch from Raja, it introduced a regression
17742 while building Blam-1.2.1 (hard to isolate a test case).
17744 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17748 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17750 (MethodCore.parent_method): New member. The method we're overriding
17751 if this is an override method.
17752 (MethodCore.CheckBase): Moved from Method class and made common.
17753 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17755 (MethodCore.CheckForDuplications): New abstract method. For custom
17756 member duplication search in a container
17757 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17758 method and its return type.
17759 (Event.conflict_symbol): New member. Symbol with same name in the
17763 (MemberCache.FindMemberWithSameName): New method. The method
17764 is looking for conflict with inherited symbols.
17766 2004-08-04 Martin Baulig <martin@ximian.com>
17768 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17770 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17772 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17774 * report.cs (Message): New enum for better error, warning reference in
17776 (MessageData): New inner abstract class. It generally handles printing of
17777 error and warning messages.
17778 Removed unused Error, Warning, Message methods.
17780 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17782 Fix for cs0592-8.cs test
17784 (Attributable.ValidAttributeTargets): Made public.
17785 (Attribute.ExplicitTarget): New member for explicit target value.
17786 (Attribute.CheckTargets): Now we translate explicit attribute
17787 target to Target here.
17789 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17791 * ecore.cs (MethodGroupExpr): new IsBase property.
17793 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17795 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17796 rather than an instance expr.
17798 (DelegateCreation.Emit): Use the method group rather than
17799 the instance expression. Also, if you have base.Foo as the
17800 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17802 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17804 (NewDelegate.DoResolve): Only check for the existance of Invoke
17805 if the method is going to be needed. Use MethodGroupExpr.
17807 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17809 * expression.cs: For pointer arith., make sure to use
17810 the size of the type, not the size of the pointer to
17813 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17816 * class.cs (Class): Added error CS0502 test.
17818 2004-08-03 John Luke <jluke@cfl.rr.com>
17819 Raja R Harinath <rharinath@novell.com>
17822 * attribute.cs (Attribute.complained_before): New flag.
17823 (Attribute.ResolveType, Attribute.Resolve),
17824 (Attribute.DefinePInvokeMethod): Set it.
17825 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17827 2004-08-03 Martin Baulig <martin@ximian.com>
17829 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17830 use a user-defined operator; we still need to do numeric
17831 promotions in case one argument is a builtin type and the other
17832 one has an implicit conversion to that type. Fixes #62322.
17834 2004-08-02 Martin Baulig <martin@ximian.com>
17836 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17837 (LocalInfo.IsThis): New public property.
17838 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17840 2004-08-01 Martin Baulig <martin@ximian.com>
17842 * class.cs (TypeContainer.GetClassBases): Don't set the default
17843 here since we may get called from GetPartialBases().
17844 (TypeContainer.DefineType): If GetClassBases() didn't return a
17845 parent, use the default one.
17847 2004-07-30 Duncan Mak <duncan@ximian.com>
17849 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17851 2004-07-30 Martin Baulig <martin@ximian.com>
17853 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17855 * class.cs (SourceMethod): New public class, derive from the
17856 symbol writer's ISourceMethod.
17857 (Method): Use the new symbol writer API.
17859 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17860 as argument and use the new symbol writer.
17863 (SourceFile): Implement the symbol writer's ISourceFile.
17864 (Location.SymbolDocument): Removed.
17865 (Location.SourceFile): New public property.
17867 * symbolwriter.cs: Use the new symbol writer API.
17869 2004-07-30 Raja R Harinath <rharinath@novell.com>
17871 * Makefile (install-local): Remove. Functionality moved to
17874 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17876 * Makefile: Install mcs.exe.config file together with mcs.exe.
17877 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17878 correct runtime version.
17880 2004-07-25 Martin Baulig <martin@ximian.com>
17883 (TypeContainer.RegisterOrder): Removed, this was unused.
17884 (TypeContainer, interface_order): Removed.
17885 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17886 TypeContainer as argument since we can also be called with a
17887 `PartialContainer' for a partial class/struct/interface.
17888 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17889 of checking whether we're an `Interface' - we could be a
17890 `PartialContainer'.
17891 (PartialContainer.Register): Override; call
17892 AddClass()/AddStruct()/AddInterface() on our parent.
17894 * cs-parser.jay (interface_member_declaration): Add things to the
17895 `current_container', not the `current_class'.
17897 * rootcontext.cs (RegisterOrder): The overloaded version which
17898 takes an `Interface' was unused, removed.
17900 * typemanager.cs (TypeManager.LookupInterface): Return a
17901 `TypeContainer', not an `Interface'.
17902 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17903 contain a `PartialContainer' for an interface, so check it's
17904 `Kind' to figure out what it is.
17906 2004-07-25 Martin Baulig <martin@ximian.com>
17908 * class.cs (Class.DefaultTypeAttributes): New public constant.
17909 (Struct.DefaultTypeAttributes): Likewise.
17910 (Interface.DefaultTypeAttributes): Likewise.
17911 (PartialContainer.TypeAttr): Override this and add the
17912 DefaultTypeAttributes.
17914 2004-07-25 Martin Baulig <martin@ximian.com>
17916 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17917 we can just use the `Parent' field instead.
17919 2004-07-25 Martin Baulig <martin@ximian.com>
17921 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17923 2004-07-25 Martin Baulig <martin@ximian.com>
17925 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17926 our parts before defining any methods.
17927 (TypeContainer.VerifyImplements): Make this virtual.
17928 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17929 on our PartialContainer.
17931 2004-07-25 Martin Baulig <martin@ximian.com>
17933 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17935 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17936 argument, we can just use the `Parent' field instead.
17939 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17940 (MemberBase.DoDefine): Likewise.
17942 2004-07-24 Martin Baulig <martin@ximian.com>
17944 * decl.cs (MemberCore.Parent): New public field.
17945 (DeclSpace.Parent): Moved to MemberCore.
17947 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17948 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17950 (FieldBase, Field, Operator): Likewise.
17951 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17952 (EventField, Event): Likewise.
17954 2004-07-23 Martin Baulig <martin@ximian.com>
17956 * class.cs (PartialContainer): New public class.
17957 (ClassPart): New public class.
17958 (TypeContainer): Added support for partial classes.
17959 (TypeContainer.GetClassBases): Splitted some of the functionality
17960 out into GetNormalBases() and GetPartialBases().
17962 * cs-tokenizer.cs (Token.PARTIAL): New token.
17963 (Tokenizer.consume_identifier): Added some hacks to recognize
17964 `partial', but only if it's immediately followed by `class',
17965 `struct' or `interface'.
17967 * cs-parser.jay: Added support for partial clases.
17969 2004-07-23 Martin Baulig <martin@ximian.com>
17971 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17972 a `DeclSpace' and also made it readonly.
17973 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17974 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17975 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17977 * cs-parser.jay: Pass the `current_class', not the
17978 `current_container' (at the moment, this is still the same thing)
17979 to a new Method, Property, Event, Indexer or Constructor.
17981 2004-07-23 Martin Baulig <martin@ximian.com>
17983 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17984 and removed the `current_interface' one.
17985 (struct_declaration, class_declaration, interface_declaration):
17986 Set `current_class' to the newly created class/struct/interface;
17987 set their `Bases' and call Register() before parsing their body.
17989 2004-07-23 Martin Baulig <martin@ximian.com>
17991 * class.cs (Kind): New public enum.
17992 (TypeContainer): Made this class abstract.
17993 (TypeContainer.Kind): New public readonly field.
17994 (TypeContainer.CheckDef): New public method; moved here from
17996 (TypeContainer.Register): New public abstract method.
17997 (TypeContainer.GetPendingImplementations): New public abstract
17999 (TypeContainer.GetClassBases): Removed the `is_class' and
18000 `is_iface' parameters.
18001 (TypeContainer.DefineNestedTypes): Formerly known as
18003 (ClassOrStruct): Made this class abstract.
18005 * tree.cs (RootTypes): New public type.
18007 2004-07-20 Martin Baulig <martin@ximian.com>
18009 * tree.cs (Tree.RecordNamespace): Removed.
18010 (Tree.Namespaces): Removed.
18012 * rootcontext.cs (RootContext.IsNamespace): Removed.
18014 * cs-parser.jay (namespace_declaration): Just create a new
18015 NamespaceEntry here.
18017 2004-07-20 Martin Baulig <martin@ximian.com>
18019 * statement.cs (ExceptionStatement): New abstract class. This is
18020 now used as a base class for everyone who's using `finally'.
18021 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
18022 our local variables before using them.
18024 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
18025 virtual method. This is used by Yield.Resolve() to "steal" an
18026 outer block's `finally' clauses.
18027 (FlowBranchingException): The .ctor now takes an ExceptionStatement
18030 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
18031 version which takes an ExceptionStatement. This version must be
18032 used to create exception branchings.
18035 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
18036 (Iterator.EmitMoveNext): Added exception support; protect the
18037 block with a `fault' clause, properly handle 'finally' clauses.
18038 (Iterator.EmitDispose): Run all the `finally' clauses here.
18040 2004-07-20 Martin Baulig <martin@ximian.com>
18042 * iterator.cs: This is the first of a set of changes in the
18043 iterator code. Match the spec more closely: if we're an
18044 IEnumerable, then GetEnumerator() must be called. The first time
18045 GetEnumerator() is called, it returns the current instance; all
18046 subsequent invocations (if any) must create a copy.
18048 2004-07-19 Miguel de Icaza <miguel@ximian.com>
18050 * expression.cs: Resolve the constant expression before returning
18053 2004-07-19 Martin Baulig <martin@ximian.com>
18055 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
18056 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
18057 the return type of the new EmitContext.
18059 2004-07-18 Martin Baulig <martin@ximian.com>
18061 * class.cs (Property.Define): Fix iterators.
18063 * iterators.cs (Iterator.Define): Moved the
18064 `container.AddInterator (this)' call here from the .ctor; only do
18065 it if we resolved successfully.
18067 2004-07-17 Miguel de Icaza <miguel@ximian.com>
18069 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
18070 `true' for preprocessing directives that we parse. The return
18071 value indicates whether we should return to regular tokenizing or
18072 not, not whether it was parsed successfully.
18074 In the past if we were in: #if false ... #line #endif, we would
18075 resume parsing after `#line'. See bug 61604.
18077 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
18078 building: IsEnumType should return true only for enums, not for
18079 enums or System.Enum itself. This fixes #61593.
18081 Likely what happened is that corlib was wrong: mcs depended on
18082 this bug in some places. The bug got fixed, we had to add the
18083 hack, which caused bug 61593.
18085 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
18086 that was a workaround for the older conditions.
18088 2004-07-16 Ben Maurer <bmaurer@ximian.com>
18090 * assign.cs: IAssignMethod has a new interface, as documented
18091 inline. All assignment code now uses this new api.
18093 * ecore.cs, expression.cs: All classes which implement
18094 IAssignMethod now use the new interface.
18096 * expression.cs (Invocation): add a hack to EmitCall so that
18097 IndexerAccess can be the target of a compound assignment without
18098 evaluating its arguments twice.
18100 * statement.cs: Handle changes in Invocation api.
18102 2004-07-16 Martin Baulig <martin@ximian.com>
18104 * iterators.cs: Rewrote this. We're now using one single Proxy
18105 class for both the IEnumerable and the IEnumerator interface and
18106 `Iterator' derives from Class so we can use the high-level API.
18108 * class.cs (TypeContainer.AddIterator): New method.
18109 (TypeContainer.DoDefineType): New protected virtual method, which
18110 is called from DefineType().
18111 (TypeContainer.DoDefineMembers): Call DefineType() and
18112 DefineMembers() on all our iterators.
18113 (TypeContainer.Emit): Call Emit() on all our iterators.
18114 (TypeContainer.CloseType): Call CloseType() on all our iterators.
18116 * codegen.cs (EmitContext.CurrentIterator): New public field.
18118 2004-07-15 Martin Baulig <martin@ximian.com>
18121 (TypeManager.not_supported_exception_type): New type.
18123 2004-07-14 Martin Baulig <martin@ximian.com>
18125 * iterators.cs: Use real error numbers.
18127 2004-07-14 Martin Baulig <martin@ximian.com>
18129 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
18130 requires this to be a System.Collection.IEnumerable and not a
18131 class implementing that interface.
18132 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
18134 2004-07-13 Marek Safar <marek.safar@seznam.cz>
18136 * class.cs: Fixed previous fix, it broke some error tests.
18138 2004-07-12 Martin Baulig <martin@ximian.com>
18140 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
18143 2004-07-09 Miguel de Icaza <miguel@ximian.com>
18145 * assign.cs (LocalTemporary): Add new argument: is_address,If
18146 `is_address' is true, then the value that we store is the address
18147 to the real value, and not the value itself.
18149 * ecore.cs (PropertyExpr): use the new local temporary
18150 stuff to allow us to handle X.Y += z (where X is a struct)
18152 2004-07-08 Martin Baulig <martin@ximian.com>
18154 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
18155 not always return, just like we're doing in Using.Resolve().
18157 2004-07-07 Miguel de Icaza <miguel@ximian.com>
18159 * cs-parser.jay (fixed_statement): flag this as Pinned.
18161 2004-07-06 Miguel de Icaza <miguel@ximian.com>
18163 * typemanager.cs (TypeManager): Removed MakePinned method, this
18164 mechanism is replaced with the .NET 2.x compatible mechanism of
18165 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
18167 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
18168 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
18169 `IsFixed' property which has a different meaning.
18171 2004-07-02 Raja R Harinath <rharinath@novell.com>
18173 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
18174 visible from inside a nested class, not just the names of the
18175 immediately enclosing class.
18176 Fix for bug #60730.
18178 2004-06-24 Raja R Harinath <rharinath@novell.com>
18180 * expression.cs (BetterConversion): Remove buggy special-case
18181 handling of "implicit constant expression conversions". At this
18182 point, we already know that the conversion is possible -- we're
18183 only checking to see which is better.
18185 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18187 * cs-parser.jay: Added error CS0210 test.
18189 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18191 * cs-parser.jay: Added error CS0134 test.
18193 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18196 * cs-parser.jay: Added error CS0145 test.
18198 2004-06-24 Marek Safar <marek.safar@seznam.cz>
18200 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
18202 2004-06-23 Ben Maurer <bmaurer@ximian.com>
18204 * expression.cs (StackAlloc.Resolve): The argument may not
18205 be a constant; deal with this case.
18207 2004-06-23 Marek Safar <marek.safar@seznam.cz>
18209 * attribute.cs (IndexerName_GetIndexerName): Renamed to
18210 GetIndexerAttributeValue.
18211 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
18213 * class.cs (Indexer.Define): Added error tests for CS0415,
18216 2004-06-23 Miguel de Icaza <miguel@ximian.com>
18218 * attribute.cs (Attribute.Resolve): Keep field code in sync with
18221 2004-06-23 Martin Baulig <martin@ximian.com>
18223 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
18224 neither return nor throw, reset the barrier as well. Fixes #60457.
18226 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
18228 * class.cs : EventAttributes is now set to None by default.
18229 This fixes bug #60459.
18231 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18234 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18235 Don't throw exception but return null (it's sufficient now).
18237 2004-06-18 Marek Safar <marek.safar@seznam.cz>
18239 * typemanager.cs (GetArgumentTypes): Faster implementation.
18241 2004-06-18 Martin Baulig <martin@ximian.com>
18243 * attribute.cs (Attribute.Resolve): Check whether we're an
18244 EmptyCast which a Constant child. Fixes #60333.
18246 2004-06-17 Ben Maurer <bmaurer@ximian.com>
18248 * statement.cs (EmitCollectionForeach): Account for the fact that
18249 not all valuetypes are in areas which we can take the address of.
18250 For these variables, we store to a temporary variable. Also, make
18251 sure that we dont emit a `callvirt' on a valuetype method.
18253 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18255 * expression.cs (StackAlloc.DoReSolve): Added test for
18256 negative parameter (CS0247).
18258 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18261 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
18263 2004-06-15 Marek Safar <marek.safar@seznam.cz>
18266 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
18269 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18271 Fix bug #58254 & cs1555.cs, cs1556.cs
18272 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
18274 2004-06-14 Marek Safar <marek.safar@seznam.cz>
18276 * cs-parser.jay: Added error CS1669 test for indexers.
18278 2004-06-11 Martin Baulig <martin@ximian.com>
18280 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
18281 call this twice: for params and varargs methods.
18283 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18286 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
18288 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18290 * attribute.cs (Attribute.GetValidTargets): Made public.
18293 (AbstractPropertyEventMethod): New class for better code sharing.
18294 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
18296 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
18298 2004-06-11 Raja R Harinath <rharinath@novell.com>
18301 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
18302 that the call to Resolve is part of a MemberAccess.
18303 (Expression.Resolve): Use it for SimpleName resolution.
18304 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
18305 Add 'intermediate' boolean argument.
18306 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
18307 error message when the SimpleName can be resolved ambiguously
18308 between an expression and a type.
18309 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
18311 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
18312 call on the left-side.
18314 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18317 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
18319 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18321 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
18323 2004-06-11 Martin Baulig <martin@ximian.com>
18325 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
18326 varargs methods if applicable.
18328 2004-06-11 Martin Baulig <martin@ximian.com>
18330 * expression.cs (Invocation.EmitCall): Don't use
18331 `method.CallingConvention == CallingConventions.VarArgs' since the
18332 method could also have `CallingConventions.HasThis'.
18334 2004-06-11 Marek Safar <marek.safar@seznam.cz>
18336 * class.cs (Event.GetSignatureForError): Implemented.
18337 Fixed crash in error test cs3010.cs
18339 2004-06-10 Miguel de Icaza <miguel@ximian.com>
18341 * cs-tokenizer.cs: Change the way we track __arglist to be
18342 consistent with the other keywords.
18344 2004-06-09 Miguel de Icaza <miguel@ximian.com>
18346 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
18349 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
18351 * codegen.cs: Check that all referenced assemblies have a strongname
18352 before strongnaming the compiled assembly. If not report error CS1577.
18353 Fix bug #56563. Patch by Jackson Harper.
18354 * typemanager.cs: Added a method to return all referenced assemblies.
18355 Fix bug #56563. Patch by Jackson Harper.
18357 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18360 (Method.ApplyAttributeBuilder): Moved and added conditional
18361 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18364 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18366 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18369 * class.cs: (EventField.attribute_targets): Changed default target.
18371 2004-06-08 Martin Baulig <martin@ximian.com>
18373 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18375 2004-06-08 Martin Baulig <martin@ximian.com>
18377 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18379 2004-06-07 Martin Baulig <martin@ximian.com>
18381 Added support for varargs methods.
18383 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18386 * cs-parser.jay: Added support for `__arglist'.
18388 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18390 * expression.cs (Argument.AType): Added `ArgList'.
18391 (Invocation): Added support for varargs methods.
18392 (ArglistAccess): New public class.
18393 (Arglist): New public class.
18395 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18397 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18398 a method's top-level block if the method has varargs.
18400 * support.cs (ReflectionParameters, InternalParameters): Added
18401 support for varargs methods.
18403 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18405 * class.cs: Provide location in indexer error report.
18407 * driver.cs: Use standard names.
18409 * namespace.cs: Catch the use of using after a namespace has been
18410 declared also on using aliases.
18412 2004-06-03 Raja R Harinath <rharinath@novell.com>
18415 * typemanager.cs (closure_private_ok, closure_invocation_type)
18416 (closure_qualifier_type, closure_invocation_assembly)
18417 (FilterWithClosure): Move to ...
18418 (Closure): New internal nested class.
18419 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18420 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18421 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18422 (MemberLookup, MemberLookupFailed): Use it.
18423 * expression.cs (New.DoResolve): Treat the lookup for the
18424 constructor as being qualified by the 'new'ed type.
18425 (Indexers.GetIndexersForTypeOrInterface): Update.
18427 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18430 (GetConditionalAttributeValue): New method. Returns
18431 condition of ConditionalAttribute.
18432 (SearchMulti): New method. Returns all attributes of type 't'.
18433 Use it when attribute is AllowMultiple = true.
18434 (IsConditionalMethodExcluded): New method.
18437 (Method.IsExcluded): Implemented. Returns true if method has conditional
18438 attribute and the conditions is not defined (method is excluded).
18439 (IMethodData): Extended interface for ConditionalAttribute support.
18440 (PropertyMethod.IsExcluded): Implemented.
18443 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18446 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18449 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18451 * expression.cs (ArrayCreationExpression): Make this just an
18452 `expression'. It can't be a statement, so the code here was
18455 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18458 * typemanager.cs (GetFullNameSignature): New method for
18461 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18464 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18465 Use this method when MethodBuilder is null.
18466 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18467 Added test for error CS0626 (MONO reports error for this situation).
18468 (IMethodData.GetSignatureForError): Extended interface.
18470 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18473 (AttributeTester.GetObsoleteAttribute): Returns instance of
18474 ObsoleteAttribute when type is obsolete.
18477 (TypeContainer.VerifyObsoleteAttribute): Override.
18478 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18479 (MethodCode.VerifyObsoleteAttribute): Override.
18480 (MemberBase.VerifyObsoleteAttribute): Override.
18483 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18484 and report proper error.
18487 Delegate.VerifyObsoleteAttribute): Override.
18490 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18491 and report proper error.
18492 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18495 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18499 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18500 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18501 Added test for ObsoleteAttribute.
18504 (Catch): Derived from Statement.
18506 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18508 Fixed bug #59071 & cs0160.cs
18510 * statement.cs (Try.Resolve): Check here whether order of catch
18511 clauses matches their dependencies.
18513 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18515 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18516 caused a regression: #59343. Referencing nested classes from an
18517 assembly stopped working.
18519 2004-05-31 Martin Baulig <martin@ximian.com>
18521 MCS is now frozen for beta 2.
18523 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18525 * convert.cs: add a trivial cache for overload operator resolution.
18527 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18529 * decl.cs: If possible, use lookuptypedirect here. We can only do
18530 this if there is no `.' after the namespace. Avoids using
18531 LookupType, which does lots of slow processing.
18532 (FindNestedType) New method, does what it says :-).
18533 * namespace.cs: use LookupTypeDirect.
18534 * rootcontext.cs: use membercache, if possible.
18535 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18537 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18540 According to the spec,
18542 In a member access of the form E.I, if E is a single identifier,
18543 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18544 field, property, localvariable, or parameter with the same type as
18545 the meaning of E as a type-name (§3.8), then both possible
18546 meanings of E are permitted.
18548 We did not check that E as a simple-name had the same type as E as
18551 This trivial check gives us 5-7% on bootstrap time.
18553 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18555 * expression.cs (Invocation.OverloadResolve): Avoid the
18556 use of hashtables and boxing here by allocating on demand.
18558 2004-05-30 Martin Baulig <martin@ximian.com>
18560 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18561 we're doing a silent lookup. Don't try to lookup nested types in
18562 TypeManager.object_type (thanks to Ben Maurer).
18564 2004-05-30 Martin Baulig <martin@ximian.com>
18566 Committing a patch from Ben Maurer.
18568 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18570 2004-05-29 Martin Baulig <martin@ximian.com>
18572 * class.cs (IMethodData.ShouldIgnore): New method.
18574 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18575 `Location' argument, we don't need it anywhere. Use
18576 `IMethodData.ShouldIgnore ()' instead of
18577 `MethodData.GetMethodFlags ()'.
18578 (TypeManager.AddMethod): Removed.
18579 (TypeManager.AddMethod2): Renamed to AddMethod.
18581 2004-05-29 Martin Baulig <martin@ximian.com>
18583 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18585 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18586 converting from a class type S to an interface type and we already
18587 have an object on the stack, don't box it again. Fixes #52578.
18589 2004-05-29 Martin Baulig <martin@ximian.com>
18591 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18592 Added support for `params' parameters. Fixes #59267.
18594 2004-05-29 Martin Baulig <martin@ximian.com>
18596 * literal.cs (NullPointer): Provide a private .ctor which sets
18597 `type' to TypeManager.object_type. Fixes #59048.
18599 2004-05-29 Martin Baulig <martin@ximian.com>
18601 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18602 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18604 * ecore.cs (EventExpr.instance_expr): Make the field private.
18606 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18608 Fixed bug #50080 & cs0214-2.cs
18609 * expression.cs (Cast.DoResolve): Check unsafe context here.
18611 * statement.cs (Resolve.DoResolve): Likewise.
18613 2004-05-26 Martin Baulig <martin@ximian.com>
18615 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18617 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18618 (RootContext.LookupType): Pass down the `silent' flag.
18620 2004-05-25 Martin Baulig <martin@ximian.com>
18623 (MethodGroupExpr.IdenticalTypeName): New public property.
18624 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18625 expression actually refers to a type.
18627 2004-05-25 Martin Baulig <martin@ximian.com>
18629 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18630 for #56176 and made it actually work.
18632 2004-05-25 Martin Baulig <martin@ximian.com>
18634 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18635 (FieldExpr, PropertyExpr): Override and implement
18636 CacheTemporaries. Fixes #52279.
18638 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18640 * location.cs: In the new compiler listing a file twice is a
18641 warning, not an error.
18643 2004-05-24 Martin Baulig <martin@ximian.com>
18645 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18646 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18648 2004-05-24 Martin Baulig <martin@ximian.com>
18650 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18651 walking the `using' list. Fixes #53921.
18653 2004-05-24 Martin Baulig <martin@ximian.com>
18655 * const.cs (Const.LookupConstantValue): Added support for
18656 EmptyCast's; fixes #55251.
18658 2004-05-24 Martin Baulig <martin@ximian.com>
18660 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18661 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18662 which does the CS0135 check. The reason is that we first need to
18663 check whether the variable actually exists.
18665 2004-05-24 Martin Baulig <martin@ximian.com>
18667 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18668 than RootContext.LookupType() to find the explicit interface
18669 type. Fixes #58584.
18671 2004-05-24 Raja R Harinath <rharinath@novell.com>
18673 * Makefile: Simplify. Use executable.make.
18674 * mcs.exe.sources: New file. List of sources of mcs.exe.
18676 2004-05-24 Anders Carlsson <andersca@gnome.org>
18680 Use the invariant culture when doing String.Compare for CLS case
18683 2004-05-23 Martin Baulig <martin@ximian.com>
18685 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18686 don't have any dots. Fixes #52622, added cs0246-8.cs.
18688 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18690 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18692 * class.cs (MemberBase.Define): Reuse MemberType member for
18693 resolved type. Other methods can use it too.
18695 2004-05-23 Martin Baulig <martin@ximian.com>
18697 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18698 the variable also exists in the current block (otherwise, we need
18699 to report a CS0103). Fixes #58670.
18701 2004-05-23 Martin Baulig <martin@ximian.com>
18703 * flowanalysis.cs (Reachability.Reachable): Compute this
18704 on-the-fly rather than storing it as a field.
18706 2004-05-23 Martin Baulig <martin@ximian.com>
18708 * flowanalysis.cs (Reachability.And): Manually compute the
18709 resulting `barrier' from the reachability.
18711 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18714 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18715 instance of ObsoleteAttribute when symbol is obsolete.
18718 (IMethodData): Extended interface for ObsoleteAttribute support.
18720 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18722 * attribute.cs: Fix bug #55970
18724 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18728 (GetObsoleteAttribute): New method. Creates the instance of
18730 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18731 ObsoleteAttribute when member is obsolete.
18732 (AttributeTester.Report_ObsoleteMessage): Common method for
18733 Obsolete error/warning reporting.
18736 (TypeContainer.base_classs_type): New member for storing parent type.
18739 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18740 for this MemberCore.
18742 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18744 * attribute.cs, const.cs: Fix bug #58590
18746 2004-05-21 Martin Baulig <martin@ximian.com>
18748 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18749 out parameters if the end of the method is unreachable. Fixes
18752 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18754 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18755 Hari was right, why extra method.
18757 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18759 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18761 2004-05-20 Martin Baulig <martin@ximian.com>
18763 Merged this back from gmcs to keep the differences to a minumum.
18765 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18766 instead of a Declspace.
18767 (Attribute.ResolveType): Likewise.
18768 (Attributes.Search): Likewise.
18769 (Attributes.Contains): Likewise.
18770 (Attributes.GetClsCompliantAttribute): Likewise.
18772 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18774 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18777 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18779 Fix bug #58688 (MCS does not report error when the same attribute
18782 * attribute.cs (Attribute.Emit): Distinction between null and default.
18784 2004-05-19 Raja R Harinath <rharinath@novell.com>
18786 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18787 of a top-level attribute without an attribute target.
18788 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18790 (Attribute.Conditional_GetConditionName),
18791 (Attribute.Obsolete_GetObsoleteMessage): Update.
18792 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18793 part of ScanForIndexerName.
18794 (Attribute.CanIgnoreInvalidAttribute): New function.
18795 (Attribute.ScanForIndexerName): Move to ...
18796 (Attributes.ScanForIndexerName): ... here.
18797 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18798 (Attributes.Search): New internal variant that can choose not to
18799 complain if types aren't resolved. The original signature now
18801 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18802 complaints suppressed.
18803 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18804 only if it not useful.
18805 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18806 top-level for attributes that are shared between the assembly
18807 and a top-level class.
18808 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18809 * class.cs: Update to reflect changes.
18810 (DefineIndexers): Fuse loops.
18811 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18812 a couple more variants of attribute names.
18814 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18816 Fix bug #52585 (Implemented explicit attribute declaration)
18819 (Attributable.ValidAttributeTargets): New abstract method. It gets
18820 list of valid attribute targets for explicit target declaration.
18821 (Attribute.Target): It holds target itself.
18822 (AttributeSection): Removed.
18823 (Attribute.CheckTargets): New method. It checks whether attribute
18824 target is valid for the current element.
18827 (EventProperty): New class. For events that are declared like
18828 property (with add and remove accessors).
18829 (EventField): New class. For events that are declared like field.
18832 * cs-parser.jay: Implemented explicit attribute target declaration.
18834 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18835 Override ValidAttributeTargets.
18838 (ReturnParameter): Class for applying custom attributes on
18840 (ParameterAtribute): New class. Class for applying custom
18841 attributes on the parameter type.
18843 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18845 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18848 (Method): Allow UNSAFE here.
18850 * modifiers.cs: Support unsafe reporting.
18852 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18854 * decl.cs: Fix bug #58478.
18856 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18858 * statement.cs: When checking for unreachable code on an EmptyStatement,
18859 set the location. Fixes bug #58488.
18861 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18863 * driver.cs: Add -pkg handling.
18865 From Gonzalo: UseShelLExecute=false
18867 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18870 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18872 (Attribute.IsClsCompliaceRequired): Moved to base for better
18874 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18875 when attribute is AttributeUsageAttribute.
18876 (Attribute.GetValidTargets): Simplified.
18877 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18878 attribute for this type.
18879 (Attribute.ApplyAttributes): Method renamed to Emit and make
18881 (GlobalAttributeSection): New class for special handling of global
18882 attributes (assembly, module).
18883 (AttributeSection.Emit): New method.
18885 * class.cs: Implemented Attributable abstract methods.
18886 (MethodCore.LabelParameters): Moved to Parameter class.
18887 (Accessor): Is back simple class.
18888 (PropertyMethod): Implemented Attributable abstract class.
18889 (DelegateMethod): Implemented Attributable abstract class.
18890 (Event): New constructor for disctintion between normal Event
18891 and Event with accessors.
18893 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18895 * codegen.cs, const.cs, decl.cs, delegate.cs:
18896 (CommonAssemblyModulClass): Implemented Attributable abstract class
18899 * enum.cs: Implement IAttributeSupport interface.
18900 (EnumMember): New class for emum members. Implemented Attributable
18904 (ParameterBase): Is abstract.
18905 (ReturnParameter): New class for easier [return:] attribute handling.
18907 * typemanager.cs: Removed builder_to_attr.
18909 2004-05-11 Raja R Harinath <rharinath@novell.com>
18912 * attribute.cs (Attribute.GetPositionalValue): New function.
18913 * class.cs (TypeContainer.VerifyMembers): New function.
18914 (TypeContainer.Emit): Use it.
18915 (ClassOrStruct): New base class for Class and Struct.
18916 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18917 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18919 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18920 then each non-static field should have a FieldOffset attribute.
18921 Otherwise, none of the fields should have a FieldOffset attribute.
18922 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18923 and FieldOffset attributes.
18924 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18925 (TypeManager.field_offset_attribute_type): New core types.
18926 (TypeManager.InitCoreTypes): Initialize them.
18928 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18930 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18931 Return correct type.
18934 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18936 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18937 be implicitly converted to ulong.
18939 * expression.cs: The logic for allowing operator &, | and ^ worked
18940 was wrong, it worked before because we did not report an error in
18941 an else branch. Fixes 57895.
18943 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18944 allow volatile fields to be reference types.
18946 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18948 * driver.cs: Add support for /debug-
18950 2004-05-07 Raja R Harinath <rharinath@novell.com>
18952 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18953 Add a 'complain' parameter to silence errors.
18954 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18955 silently overlooked type-resolutions.
18956 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18957 to reflect changes.
18958 (Attributes.Search): New function.
18959 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18960 (Attributes.GetAttributeFullName): Remove hack.
18961 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18962 Update to reflect changes.
18963 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18964 Use Attributes.Search instead of nested loops.
18966 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18969 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18970 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18971 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18973 * report.cs: (Report.Warning): Renamed to Warning_T because of
18974 parameter collision.
18976 2004-05-05 Raja R Harinath <rharinath@novell.com>
18978 * expression.cs (MemberAccess.ResolveMemberAccess):
18979 Exit with non-zero status after Report.Error.
18980 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18982 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18984 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18986 * support.cs: Don't hang when the file is empty.
18988 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18990 * support.cs: In SeekableStreamReader, compute the preamble size of the
18991 underlying stream. Position changes should take into account that initial
18994 2004-05-03 Todd Berman <tberman@sevenl.net>
18996 * driver.cs: remove unused GetSysVersion function.
18998 2004-05-03 Todd Berman <tberman@sevenl.net>
19000 * driver.cs: Remove the hack from saturday, as well as the hack
19001 from jackson (LoadAssemblyFromGac), also adds the CWD to the
19002 link_paths to get that bit proper.
19004 2004-05-01 Todd Berman <tberman@sevenl.net>
19006 * driver.cs: Try a LoadFrom before a Load, this checks the current
19007 path. This is currently a bug in mono that is be fixed, however, this
19008 provides a workaround for now. This will be removed when the bug
19011 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
19013 * CryptoConvert.cs: Updated to latest version. Fix issue with
19014 incomplete key pairs (#57941).
19016 2004-05-01 Todd Berman <tberman@sevenl.net>
19018 * driver.cs: Remove '.' from path_chars, now System.* loads properly
19021 2004-04-30 Jackson Harper <jackson@ximian.com>
19023 * codegen.cs: Open keys readonly.
19025 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19027 * typemanager.cs: don't report cyclic struct layout when a struct
19028 contains 2 or more fields of the same type. Failed for Pango.AttrShape
19029 which has 2 Pango.Rectangle fields.
19031 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
19033 * expression.cs: Handle IntPtr comparisons with IL code
19034 rather than a method call.
19036 2004-04-29 Martin Baulig <martin@ximian.com>
19038 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
19039 the list of PropertyInfo's in class hierarchy and find the
19040 accessor. Fixes #56013.
19042 2004-04-29 Martin Baulig <martin@ximian.com>
19044 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
19046 2004-04-29 Martin Baulig <martin@ximian.com>
19048 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19050 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
19052 2004-04-29 Martin Baulig <martin@ximian.com>
19054 * class.cs (ConstructorInitializer.Resolve): Check whether the
19055 parent .ctor is accessible. Fixes #52146.
19057 2004-04-29 Martin Baulig <martin@ximian.com>
19059 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
19061 * statement.cs (Using.EmitLocalVariableDecls): Use
19062 TypeManager.idisposable_type, not typeof (IDisposable).
19063 (Foreach.EmitCollectionForeach): Added support for valuetypes.
19065 2004-04-29 Martin Baulig <martin@ximian.com>
19067 * class.cs (Event.Define): Don't emit the field and don't set
19068 RTSpecialName and SpecialName for events on interfaces. Fixes
19071 2004-04-29 Raja R Harinath <rharinath@novell.com>
19073 Refactor Attribute.ApplyAttributes.
19074 * attribute.cs (Attributable): New base class for objects that can
19075 have Attributes applied on them.
19076 (Attribute): Make AttributeUsage fields public.
19077 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
19078 (Attribute.IsInternalCall): New property.
19079 (Attribute.UsageAttr): Convert to a public read-only property.
19080 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
19081 (Attribute.ResolveType, Attribute.Resolve)
19082 (Attribute.ScanForIndexerName): Update to reflect changes.
19083 (Attribute.CheckAttributeTarget): Re-format.
19084 (Attribute.ApplyAttributes): Refactor, to various
19085 Attributable.ApplyAttributeBuilder methods.
19086 * decl.cs (MemberCore): Make Attributable.
19087 * class.cs (Accessor): Make Attributable.
19088 (MethodData.ApplyAttributes): Use proper attribute types, not
19090 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
19091 (TypeContainer.ApplyAttributeBuilder)
19092 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
19093 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
19094 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
19095 (Operator.ApplyAttributeBuilder): New factored-out methods.
19096 * const.cs (Const.ApplyAttributeBuilder): Likewise.
19097 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
19098 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
19099 * parameter.cs (ParameterBase): New Attributable base class
19100 that can also represent Return types.
19101 (Parameter): Update to the changes.
19103 2004-04-29 Jackson Harper <jackson@ximian.com>
19105 * driver.cs: Prefer the corlib system version when looking for
19106 assemblies in the GAC. This is still a hack, but its a better hack
19109 2004-04-29 Marek Safar <marek.safar@seznam.cz>
19111 * decl.cs, enum.cs: Improved error 3005 reporting.
19113 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
19114 (related_symbols): New private member for list of symbols
19115 related to reported error/warning.
19117 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
19119 2004-04-29 Martin Baulig <martin@ximian.com>
19121 * ecore.cs (Expression.Constantify): If we're an enum and
19122 TypeManager.TypeToCoreType() doesn't give us another type, use
19123 t.UnderlyingSystemType. Fixes #56178.
19125 2004-04-29 Martin Baulig <martin@ximian.com>
19127 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
19128 interfaces and for each interface, only add members directly
19129 declared in that interface. Fixes #53255.
19131 2004-04-28 Martin Baulig <martin@ximian.com>
19133 * expression.cs (ConditionalLogicalOperator): Use a temporary
19134 variable for `left' to avoid that we evaluate it more than once;
19137 2004-04-28 Martin Baulig <martin@ximian.com>
19139 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
19142 2004-04-28 Martin Baulig <martin@ximian.com>
19144 * statement.cs (LocalInfo.Resolve): Check whether the type is not
19147 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
19148 whether the type is not void (CS1547).
19150 2004-04-28 Martin Baulig <martin@ximian.com>
19152 * expression.cs (Unary.DoResolveLValue): Override this and report
19153 CS0131 for anything but Operator.Indirection.
19155 2004-04-28 Martin Baulig <martin@ximian.com>
19157 Committing a patch from Ben Maurer; see bug #50820.
19159 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19162 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19165 2004-04-28 Martin Baulig <martin@ximian.com>
19167 Committing a patch from Ben Maurer; see bug #50820.
19169 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
19172 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
19175 2004-04-28 Martin Baulig <martin@ximian.com>
19177 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
19178 (Block.AddLabel): Call DoLookupLabel() to only search in the
19181 2004-04-28 Martin Baulig <martin@ximian.com>
19183 * cfold.cs (ConstantFold.BinaryFold): Added special support for
19184 comparing StringConstants and NullLiterals in Equality and Inequality.
19186 2004-04-28 Jackson Harper <jackson@ximian.com>
19188 * driver.cs: Attempt to load referenced assemblies from the
19189 GAC. This is the quick and dirty version of this method that
19190 doesnt take into account versions and just takes the first
19191 canidate found. Will be good enough for now as we will not have more
19192 then one version installed into the GAC until I update this method.
19194 2004-04-28 Martin Baulig <martin@ximian.com>
19196 * typemanager.cs (TypeManager.CheckStructCycles): New public
19197 static method to check for cycles in the struct layout.
19199 * rootcontext.cs (RootContext.PopulateTypes): Call
19200 TypeManager.CheckStructCycles() for each TypeContainer.
19201 [Note: We only need to visit each type once.]
19203 2004-04-28 Martin Baulig <martin@ximian.com>
19205 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
19207 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
19208 success and added `out object value'. Use a `bool resolved' field
19209 to check whether we've already been called rather than
19210 `ConstantValue != null' since this breaks for NullLiterals.
19212 2004-04-28 Raja R Harinath <rharinath@novell.com>
19214 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
19215 setting of this flag, since the 'set' method may be non-public.
19217 2004-04-28 Raja R Harinath <rharinath@novell.com>
19219 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
19220 check on current_vector.Block.
19222 2004-04-27 Martin Baulig <martin@ximian.com>
19224 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
19225 a field initializer. Fixes #56459.
19227 2004-04-27 Martin Baulig <martin@ximian.com>
19229 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
19230 we're not attempting to use an indexer. Fixes #52154.
19232 2004-04-27 Martin Baulig <martin@ximian.com>
19234 * statement.cs (Return): Don't create a return label if we don't
19235 need it; reverts my change from January 20th. Thanks to Ben
19238 2004-04-27 Martin Baulig <martin@ximian.com>
19240 According to the spec, `goto' can only leave a nested scope, but
19243 * statement.cs (Block.LookupLabel): Only lookup in the current
19244 block, don't recurse into parent or child blocks.
19245 (Block.AddLabel): Check in parent and child blocks, report
19246 CS0140/CS0158 if we find a duplicate.
19247 (Block): Removed this indexer for label lookups.
19248 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
19249 this already does the error reporting for us.
19252 (FlowBranching.UsageVector.Block): New public variable; may be null.
19253 (FlowBranching.CreateSibling): Added `Block' argument.
19254 (FlowBranching.LookupLabel): New public virtual method. Lookup a
19255 label for the target of a `goto' and check whether we're not
19256 leaving a `finally'.
19258 2004-04-27 Martin Baulig <martin@ximian.com>
19260 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
19261 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
19264 2004-04-27 Martin Baulig <martin@ximian.com>
19266 * statement.cs (Block.AddLabel): Also check for implicit blocks
19267 and added a CS0158 check.
19269 2004-04-27 Martin Baulig <martin@ximian.com>
19271 * flowanalysis.cs (FlowBranchingLoop): New class.
19272 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
19273 UsageVector's instead of an ArrayList.
19274 (FlowBranching.Label): Likewise.
19275 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
19276 (FlowBranching.AddBreakVector): New method.
19278 2004-04-27 Miguel de Icaza <miguel@ximian.com>
19280 * attribute.cs: Small regression fix: only convert the type if we
19281 the type is different, fixes System.Drawing build.
19283 2004-04-27 Martin Baulig <martin@ximian.com>
19285 * attribute.cs (Attribute.Resolve): If we have a constant value
19286 for a named field or property, implicity convert it to the correct
19289 2004-04-27 Raja R Harinath <rharinath@novell.com>
19291 * statement.cs (Block.Block): Implicit blocks share
19292 'child_variable_names' fields with parent blocks.
19293 (Block.AddChildVariableNames): Remove.
19294 (Block.AddVariable): Mark variable as "used by a child block" in
19295 every surrounding block.
19296 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
19297 been used in a child block, complain about violation of "Invariant
19298 meaning in blocks" rule.
19299 * cs-parser.jay (declare_local_variables): Don't use
19300 AddChildVariableNames.
19301 (foreach_statement): Don't create an implicit block: 'foreach'
19302 introduces a scope.
19304 2004-04-23 Miguel de Icaza <miguel@ximian.com>
19306 * convert.cs (ImplicitNumericConversion): 0 is also positive when
19307 converting from 0L to ulong. Fixes 57522.
19309 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19311 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
19312 derived class hides via 'new' keyword field from base class (test-242.cs).
19313 TODO: Handle this in the more general way.
19315 * class.cs (CheckBase): Ditto.
19317 2004-04-22 Marek Safar <marek.safar@seznam.cz>
19319 * decl.cs (caching_flags): New member for storing cached values
19321 (MemberCore.Flags): New enum where bit flags for caching_flags
19323 (MemberCore.cls_compliance): Moved to caching_flags.
19324 (DeclSpace.Created): Moved to caching_flags.
19326 * class.cs: Use caching_flags instead of DeclSpace.Created
19328 2004-04-21 Miguel de Icaza <miguel@ximian.com>
19330 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
19331 if we are only a derived class, not a nested class.
19333 * typemanager.cs: Same as above, but do this at the MemberLookup
19334 level (used by field and methods, properties are handled in
19335 PropertyExpr). Allow for the qualified access if we are a nested
19338 2004-04-21 Marek Safar <marek.safar@seznam.cz>
19340 * class.cs: Refactoring.
19341 (IMethodData): New inteface; Holds links to parent members
19342 to avoid member duplication (reduced memory allocation).
19343 (Method): Implemented IMethodData interface.
19344 (PropertyBase): New inner classes for get/set methods.
19345 (PropertyBase.PropertyMethod): Implemented IMethodData interface
19346 (Event): New inner classes for add/remove methods.
19347 (Event.DelegateMethod): Implemented IMethodData interface.
19349 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
19350 EmitContext (related to class.cs refactoring).
19352 2004-04-21 Raja R Harinath <rharinath@novell.com>
19354 * delegate.cs (Delegate.VerifyApplicability): If the number of
19355 arguments are the same as the number of parameters, first try to
19356 verify applicability ignoring any 'params' modifier on the last
19360 2004-04-16 Raja R Harinath <rharinath@novell.com>
19362 * class.cs (TypeContainer.AddIndexer): Use
19363 'ExplicitInterfaceName' to determine if interface name was
19364 explicitly specified. 'InterfaceType' is not initialized at this time.
19365 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19366 Indexers array is already in the required order. Initialize
19367 'IndexerName' only if there are normal indexers.
19368 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19369 (TypeContainer.Emit): Emit DefaultMember attribute only if
19370 IndexerName is initialized.
19373 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19375 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19378 2004-04-15 Raja R Harinath <rharinath@novell.com>
19380 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19384 * attribute.cs (Attribute.Resolve): Check for duplicate named
19388 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19390 * iterators.cs (MarkYield): track whether we are in an exception,
19391 and generate code accordingly. Use a temporary value to store the
19392 result for our state.
19394 I had ignored a bit the interaction of try/catch with iterators
19395 since their behavior was not entirely obvious, but now it is
19396 possible to verify that our behavior is the same as MS .NET 2.0
19400 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19402 * iterators.cs: Avoid creating temporaries if there is no work to
19405 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19406 Enumerations, use TypeManager.EnumToUnderlying and call
19409 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19412 (This.Emit): Use EmitContext.EmitThis to emit our
19415 (This.EmitAssign): Ditto.
19417 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19418 codepaths, we will move all the functionality into
19421 (FieldExpr.EmitAssign): Ditto.
19423 This fixes several hidden bugs that I uncovered while doing a code
19424 review of this today.
19426 * codegen.cs (EmitThis): reworked so the semantics are more clear
19427 and also support value types "this" instances.
19429 * iterators.cs: Changed so that for iterators in value types, we
19430 do not pass the value type as a parameter.
19432 Initialization of the enumerator helpers is now done in the caller
19433 instead of passing the parameters to the constructors and having
19434 the constructor set the fields.
19436 The fields have now `assembly' visibility instead of private.
19438 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19440 * expression.cs (Argument.Resolve): Check if fields passed as ref
19441 or out are contained in a MarshalByRefObject.
19443 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19444 another compiler type.
19446 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19448 * class.cs (Indexer.Define): use the new name checking method.
19449 Also, return false on an error.
19450 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19451 (is_identifier_[start/part]_character): make static.
19453 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19455 * expression.cs (Binary.ResolveOperator): Do no append strings
19456 twice: since we can be invoked more than once (array evaluation)
19457 on the same concatenation, take care of this here. Based on a fix
19458 from Ben (bug #56454)
19460 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19462 * codegen.cs: Fix another case where CS1548 must be reported (when
19463 delay-sign isn't specified and no private is available #56564). Fix
19464 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19465 error when MCS is used on the MS runtime and we need to delay-sign
19466 (which seems unsupported by AssemblyBuilder - see #56621).
19468 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19470 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19471 (TypeManager.ComputeNamespaces): Faster implementation for
19474 * compiler.csproj: Updated AssemblyName to mcs.
19476 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19478 * rootcontext.cs: Add new types to the boot resolution.
19480 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19481 MulticastDelegate is not allowed.
19483 * typemanager.cs: Add new types to lookup: System.TypedReference
19486 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19487 check for TypedReference or ArgIterator, they are not allowed.
19489 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19490 makes us properly catch 1510 in some conditions (see bug 56016 for
19493 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19495 * CryptoConvert.cs: update from corlib version
19498 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19500 * class.cs (Indexer.Define): Check indexername declaration
19502 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19504 * attribute.cs (IsClsCompliant): Fixed problem with handling
19505 all three states (compliant, not-compliant, undetected).
19507 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19509 * attribute.cs (Attribute): Location is now public.
19510 (Resolve): Store resolved arguments (pos_values) in attribute class.
19511 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19512 (GetClsCompliantAttributeValue): New method that gets
19513 CLSCompliantAttribute value.
19514 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19515 if exists else null.
19516 (AttributeTester): New class for CLS-Compliant verification routines.
19518 * class.cs (Emit): Add CLS-Compliant verification.
19519 (Method.GetSignatureForError): Implemented.
19520 (Constructor.GetSignatureForError): Implemented
19521 (Constructor.HasCompliantArgs): Returns if constructor has
19522 CLS-Compliant arguments.
19523 (Constructor.Emit): Override.
19524 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19525 is needed to test only parameters.
19526 (FieldBase.GetSignatureForError): Implemented.
19527 (TypeContainer): New member for storing base interfaces.
19528 (TypeContainer.FindMembers): Search in base interfaces too.
19530 * codegen.cs (GetClsComplianceAttribute): New method that gets
19531 assembly or module CLSCompliantAttribute value.
19532 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19534 (ModuleClass.Emit): Add error 3012 test.
19536 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19538 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19539 state for all decl types.
19540 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19541 if CLS-Compliant tests are required.
19542 (IsClsCompliaceRequired): New method. Analyze whether code
19543 must be CLS-Compliant.
19544 (IsExposedFromAssembly): New method. Returns true when MemberCore
19545 is exposed from assembly.
19546 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19547 value or gets cached value.
19548 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19549 is explicitly marked with CLSCompliantAttribute.
19550 (IsIdentifierClsCompliant): New abstract method. This method is
19551 used to testing error 3005.
19552 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19553 for identifier and parameters CLS-Compliant testing.
19554 (VerifyClsCompliance): New method. The main virtual method for
19555 CLS-Compliant verifications.
19556 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19557 null. I don't know why is null (too many public members !).
19558 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19559 and get value of first CLSCompliantAttribute that found.
19561 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19562 (VerifyClsCompliance): Override and add extra tests.
19564 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19565 clscheck- disable CLS-Compliant verification event if assembly is has
19566 CLSCompliantAttribute(true).
19568 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19569 ApllyAttribute is now called in emit section as in the other cases.
19570 Possible future Emit integration.
19571 (IsIdentifierClsCompliant): New override.
19572 (VerifyClsCompliance): New override.
19573 (GetEnumeratorName): Returns full enum name.
19575 * parameter.cs (GetSignatureForError): Implemented.
19577 * report.cs (WarningData): New struct for Warning message information.
19578 (LocationOfPreviousError): New method.
19579 (Warning): New method. Reports warning based on the warning table.
19580 (Error_T): New method. Reports error based on the error table.
19582 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19583 verifications are done here.
19585 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19587 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19588 CLSCompliantAttribute.
19589 (all_imported_types): New member holds all imported types from other
19591 (LoadAllImportedTypes): New method fills static table with exported types
19592 from all referenced assemblies.
19593 (Modules): New property returns all assembly modules.
19595 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19597 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19598 throwing a parser error.
19600 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19601 which removes the hardcoded get_/set_ prefixes for properties, as
19602 IL allows for the properties to be named something else.
19606 * expression.cs: Do not override operand before we know if it is
19607 non-null. Fix 56207
19609 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19611 * typemanager.cs: support for pinned variables.
19613 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19615 * decl.cs, typemanager.cs: Avoid using an arraylist
19616 as a buffer if there is only one result set.
19618 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19620 * expression.cs: Make sure you cant call a static method
19621 with an instance expression, bug #56174.
19623 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19625 * class.cs (IsDuplicateImplementation): Improve error reporting to
19626 flag 663 (method only differs in parameter modifier).
19628 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19629 in preprocessor directives.
19631 * location.cs (LookupFile): Allow for the empty path.
19633 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19634 better approach for some of that patch, but its failing with the
19635 CharSet enumeration. For now try/catch will do.
19637 * typemanager.cs: Do not crash if a struct does not have fields.
19640 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19642 * expression.cs: cs0213, cant fix a fixed expression.
19645 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19647 * cs-parser.jay: detect invalid embeded statements gracefully.
19650 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19652 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19655 the invocation type may not be a subclass of the tye of the item/
19656 The type of the item must be a subclass of the invocation item.
19661 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19663 * attribute.cs: Added methods to get a string and a bool from an
19664 attribute. Required to information from AssemblyKeyFileAttribute,
19665 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19666 * codegen.cs: Modified AssemblyName creation to include support for
19667 strongnames. Catch additional exceptions to report them as CS1548.
19668 * compiler.csproj: Updated include CryptoConvert.cs.
19669 * compiler.csproj.user: Removed file - user specific configuration.
19670 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19671 Mono.Security assembly. The original class is maintained and tested in
19672 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19673 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19674 like CSC 8.0 (C# v2) supports.
19675 * Makefile: Added CryptoConvert.cs to mcs sources.
19676 * rootcontext.cs: Added new options for strongnames.
19678 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19680 * driver.cs: For --expect-error, report error code `2'
19681 if the program compiled with no errors, error code `1' if
19682 it compiled with an error other than the one expected.
19684 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19686 * compiler.csproj: Updated for Visual Studio .NET 2003.
19687 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19688 * compiler.sln: Updated for Visual Studio .NET 2003.
19690 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19692 * expression.cs: Fix bug #47234. We basically need to apply the
19693 rule that we prefer the conversion of null to a reference type
19694 when faced with a conversion to 'object' (csc behaviour).
19696 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19698 * statement.cs: Shorter form for foreach, eliminates
19699 a local variable. r=Martin.
19701 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19703 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19704 checks if we can use brtrue/brfalse to test for 0.
19705 * expression.cs: use the above in the test for using brtrue/brfalse.
19706 cleanup code a bit.
19708 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19710 * expression.cs: Rewrite string concat stuff. Benefits:
19712 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19713 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19714 rather than a concat chain.
19716 * typemanager.cs: Add lookups for more concat overloads.
19718 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19720 * expression.cs: Emit shorter il code for array init.
19737 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19739 * statement.cs: Before, two switch blocks would be merged if the
19740 total size of the blocks (end_item - begin_item + 1) was less than
19741 two times the combined sizes of the blocks.
19743 Now, it will only merge if after the merge at least half of the
19748 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19750 * class.cs : csc build fix for GetMethods(). See bug #52503.
19752 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19754 * expression.cs: Make sure fp comparisons work with NaN.
19755 This fixes bug #54303. Mig approved this patch a long
19756 time ago, but we were not able to test b/c the runtime
19759 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19761 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19763 2004-03-19 Martin Baulig <martin@ximian.com>
19765 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19766 error here and not in our caller.
19768 2004-03-19 Martin Baulig <martin@ximian.com>
19770 * interface.cs: Completely killed this file.
19771 (Interface): We're now a TypeContainer and live in class.cs.
19773 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19774 argument; we're now also called for interfaces.
19775 (TypeContainer.DefineMembers): Allow this method being called
19777 (TypeContainer.GetMethods): New public method; formerly known as
19778 Interface.GetMethod(). This is used by PendingImplementation.
19779 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19780 it's now private and non-static.
19781 (Interface): Moved this here; it's now implemented similar to
19783 (Method, Property, Event, Indexer): Added `bool is_interface'
19784 argument to their .ctor's.
19785 (MemberBase.IsInterface): New public field.
19787 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19788 instances instead of InterfaceMethod, InterfaceProperty, etc.
19789 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19790 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19792 2004-03-19 Martin Baulig <martin@ximian.com>
19794 * class.cs (MethodCore.IsDuplicateImplementation): New private
19795 method which does the CS0111 checking.
19796 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19797 Use IsDuplicateImplementation().
19799 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19801 * decl.cs (FindMemberToOverride): New method to find the correct
19802 method or property to override in the base class.
19804 - Make Method/Property use the above method to find the
19805 version in the base class.
19806 - Remove the InheritableMemberSignatureCompare as it is now
19809 This patch makes large code bases much faster to compile, as it is
19810 O(n) rather than O(n^2) to do this validation.
19812 Also, it fixes bug 52458 which is that nested classes are not
19813 taken into account when finding the base class member.
19815 Reviewed/Approved by Martin.
19817 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19819 * interface.cs: In all interface classes removed redundant
19820 member initialization.
19822 2004-03-16 Martin Baulig <martin@ximian.com>
19824 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19826 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19828 * decl.cs (DefineTypeAndParents): New helper method to define a
19829 type's containers before the type itself is defined; This is a
19830 bug exposed by the recent changes to Windows.Forms when an
19831 implemented interface was defined inside a class that had not been
19834 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19836 (Check): Loop correctly to report errors modifiers
19837 (UNSAFE was not in the loop, since it was the same as TOP).
19839 * interface.cs: Every interface member now takes a ModFlags,
19840 instead of a "is_new" bool, which we set on the base MemberCore.
19842 Every place where we called "UnsafeOk" in the interface, now we
19843 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19844 the unsafe settings from the member declaration instead of the
19845 container interface.
19847 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19849 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19850 `set_indexer_name' to the pending bits (one per type).
19852 We fixed a bug today that was picking the wrong method to
19853 override, since for properties the existing InterfaceMethod code
19854 basically ignored the method name. Now we make sure that the
19855 method name is one of the valid indexer names.
19857 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19859 * support.cs (SeekableStreamReader): Keep track of stream byte
19860 positions and don't mix them with character offsets to the buffer.
19862 Patch from Gustavo Giráldez
19864 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19866 * interface.cs (InterfaceSetGetBase): Removed double member
19867 initialization, base class does it as well.
19869 2004-03-13 Martin Baulig <martin@ximian.com>
19871 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19872 when compiling corlib.
19874 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19876 * convert.cs (ExplicitConversion): We were reporting an error on
19877 certain conversions (object_type source to a value type, when the
19878 expression was `null') before we had a chance to pass it through
19879 the user defined conversions.
19881 * driver.cs: Replace / and \ in resource specifications to dots.
19884 * class.cs: Add check for duplicate operators. Fixes 52477
19886 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19888 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19889 that are in the middle of the statements, not only at the end.
19892 * class.cs (TypeContainer.AddField): No longer set the
19893 `HaveStaticConstructor' flag, now we call it
19894 `UserDefineStaticConstructor' to diferentiate the slightly
19895 semantic difference.
19897 The situation is that we were not adding BeforeFieldInit (from
19898 Modifiers.TypeAttr) to classes that could have it.
19899 BeforeFieldInit should be set to classes that have no static
19904 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19906 And most importantly Zoltan's comment:
19908 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19910 "I think beforefieldinit means 'it's ok to initialize the type sometime
19911 before its static fields are used', i.e. initialization does not need
19912 to be triggered by the first access to the type. Setting this flag
19913 helps the JIT to compile better code, since it can run the static
19914 constructor at JIT time, and does not need to generate code to call it
19915 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19916 this flag for lots of classes like String.
19918 csc sets this flag if the type does not have an explicit static
19919 constructor. The reasoning seems to be that if there are only static
19920 initalizers for a type, and no static constructor, then the programmer
19921 does not care when this initialization happens, so beforefieldinit
19924 This bug prevents the AOT compiler from being usable, since it
19925 generates so many calls to mono_runtime_class_init that the AOT code
19926 is much slower than the JITted code. The JITted code is faster,
19927 because it does not generate these calls if the vtable is type is
19928 already initialized, which is true in the majority of cases. But the
19929 AOT compiler can't do this."
19931 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19933 * class.cs (MethodData.Emit): Refactor the code so symbolic
19934 information is generated for destructors; For some reasons we
19935 were taking a code path that did not generate symbolic information
19938 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19940 * class.cs: Create a Constructor.CheckBase method that
19941 takes care of all validation type code. The method
19942 contains some code that was moved from Define.
19944 It also includes new code that checks for duplicate ctors.
19945 This fixes bug #55148.
19947 2004-03-09 Joshua Tauberer <tauberer@for.net>
19949 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19950 a { ... }-style array creation invokes EmitStaticInitializers
19951 which is not good for reference-type arrays. String, decimal
19952 and now null constants (NullCast) are not counted toward
19953 static initializers.
19955 2004-03-05 Martin Baulig <martin@ximian.com>
19957 * location.cs (SourceFile.HasLineDirective): New public field;
19958 specifies whether the file contains or is referenced by a "#line"
19960 (Location.DefineSymbolDocuments): Ignore source files which
19961 either contain or are referenced by a "#line" directive.
19963 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19965 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19966 direct access to our parent, so check the method inline there.
19968 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19970 * expression.cs (Invocation.EmitCall): Miguel's last commit
19971 caused a regression. If you had:
19976 In Foo the implict this would be null.
19978 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19980 * expression.cs (Invocation.EmitCall): If the method is not
19981 virtual, do not emit a CallVirt to it, use Call.
19983 * typemanager.cs (GetFullNameSignature): Improve the method to
19984 cope with ".ctor" and replace it with the type name.
19986 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19987 as an argument the ConstructorBuilder where it is being defined,
19988 to catch the recursive constructor invocations.
19990 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19992 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19993 routines to check if a type is an enumerable/enumerator allow
19994 classes that implement the IEnumerable or IEnumerator interfaces.
19996 * class.cs (Property, Operator): Implement IIteratorContainer, and
19997 implement SetYields.
19999 (Property.Define): Do the block swapping for get_methods in the
20000 context of iterators. We need to check if Properties also
20001 include indexers or not.
20003 (Operator): Assign the Block before invoking the
20004 OperatorMethod.Define, so we can trigger the Iterator code
20007 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
20008 Property and Operator classes are not created when we parse the
20009 declarator but until we have the block completed, so we use a
20010 singleton SimpleIteratorContainer.Simple to flag whether the
20011 SetYields has been invoked.
20013 We propagate this setting then to the Property or the Operator to
20014 allow the `yield' to function.
20016 2004-02-25 Marek Safar <marek.safar@seznam.cz>
20018 * codegen.cs: Implemented attribute support for modules.
20019 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
20020 Assembly/Module functionality.
20022 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
20023 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
20024 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
20026 2004-02-16 Marek Safar <marek.safar@seznam.cz>
20028 * interface.cs (FindMembers): The operation is performed on all base
20029 interfaces and not only on the first. It is required for future CLS Compliance patch.
20031 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
20033 * statement.cs, codegen.cs:
20034 This patch deals with patterns such as:
20036 public class List : IEnumerable {
20038 public MyEnumerator GetEnumerator () {
20039 return new MyEnumerator(this);
20042 IEnumerator IEnumerable.GetEnumerator () {
20046 public struct MyEnumerator : IEnumerator {
20051 Before, there were a few things we did wrong:
20052 1) we would emit callvirt on a struct, which is illegal
20053 2) we emited ldarg when we needed to emit ldarga
20054 3) we would mistakenly call the interface methods on an enumerator
20055 type that derived from IEnumerator and was in another assembly. For example:
20057 public class MyEnumerator : IEnumerator
20059 Would have the interface methods called, even if there were public impls of the
20060 method. In a struct, this lead to invalid IL code.
20062 2004-02-11 Marek Safar <marek.safar@seznam.cz>
20064 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
20067 * delegate.cs (Define): Fixed crash when delegate type is undefined.
20069 2004-02-11 Miguel de Icaza <miguel@ximian.com>
20071 * cs-parser.jay: Fix small regression: we were not testing V2
20072 compiler features correctly.
20074 * interface.cs: If the emit context is null, then create one
20076 2004-02-09 Marek Safar <marek.safar@seznam.cz>
20078 * decl.cs (GetSignatureForError): New virtual method to get full name
20079 for error messages.
20081 * attribute.cs (IAttributeSupport): New interface for attribute setting.
20082 Now it is possible to rewrite ApplyAttributes method to be less if/else.
20084 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
20085 Duplicated members and code in these classes has been removed.
20086 Better encapsulation in these classes.
20088 2004-02-07 Miguel de Icaza <miguel@ximian.com>
20090 * assign.cs (Assign.DoResolve): When dealing with compound
20091 assignments, there is a new rule in ECMA C# 2.4 (might have been
20092 there before, but it is documented here) that states that in:
20096 If b is of type int, and the `op' is a shift-operator, then the
20097 above is evaluated as:
20101 * expression.cs (Binary.ResolveOperator): Instead of testing for
20102 int/uint/long/ulong, try to implicitly convert to any of those
20103 types and use that in pointer arithmetic.
20105 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
20106 method to print information for from the type, not from the
20107 null-method we were given.
20109 2004-02-01 Duncan Mak <duncan@ximian.com>
20111 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
20112 parsing for cmd, fixes bug #53694.
20114 2004-02-04 Marek Safar <marek.safar@seznam.cz>
20116 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
20117 in the member name duplication tests. Property and operator name duplication
20118 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
20120 2004-02-03 Marek Safar <marek.safar@seznam.cz>
20122 * interface.cs (PopulateMethod): Fixed crash when interface method
20123 returns not existing type (error test cs0246-3.cs).
20125 2004-02-02 Ravi Pratap M <ravi@ximian.com>
20127 * cs-parser.jay (interface_accessors): Re-write actions to also
20128 store attributes attached to get and set methods. Fix spelling
20131 (inteface_property_declaration): Modify accordingly.
20133 (InterfaceAccessorInfo): New helper class to store information to pass
20134 around between rules that use interface_accessors.
20136 * interface.cs (Emit): Apply attributes on the get and set
20137 accessors of properties and indexers too.
20139 * attribute.cs (ApplyAttributes): Modify accordingly to use the
20140 right MethodBuilder when applying attributes to the get and set accessors.
20142 2004-01-31 Miguel de Icaza <miguel@ximian.com>
20144 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
20146 2004-01-26 Miguel de Icaza <miguel@ximian.com>
20148 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
20150 2004-01-25 Miguel de Icaza <miguel@ximian.com>
20152 * cs-parser.jay: Remove YIELD token, instead use the new grammar
20153 changes that treat `yield' specially when present before `break'
20154 or `return' tokens.
20156 * cs-tokenizer.cs: yield is no longer a keyword.
20158 2004-01-23 Marek Safar <marek.safar@seznam.cz>
20160 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
20161 setting for default constructors.
20162 For default constructors are almost every time set wrong Modifier. The
20163 generated IL code has been alright. But inside mcs this values was
20164 wrong and this was reason why several of my CLS Compliance tests
20167 2004-01-22 Martin Baulig <martin@ximian.com>
20169 * cs-parser.jay (namespace_or_type_name): Return an Expression,
20170 not a QualifiedIdentifier. This is what `type_name_expression'
20171 was previously doing.
20172 (type_name_expression): Removed; the code is now in
20173 `namespace_or_type_name'.
20174 (qualified_identifier): Removed, use `namespace_or_type_name'
20176 (QualifiedIdentifier): Removed this class.
20178 2004-01-22 Martin Baulig <martin@ximian.com>
20180 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
20181 not a string as alias name.
20183 2004-01-21 Miguel de Icaza <miguel@ximian.com>
20185 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
20186 #52730 bug, and instead compute correctly the need to use a
20187 temporary variable when requesting an address based on the
20188 static/instace modified of the field and the constructor.
20190 2004-01-21 Martin Baulig <martin@ximian.com>
20192 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
20193 class and namespace before looking up aliases. Fixes #52517.
20195 2004-01-21 Martin Baulig <martin@ximian.com>
20197 * flowanalysis.cs (UsageVector.Merge): Allow variables being
20198 assinged in a 'try'; fixes exception4.cs.
20200 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20201 * class.cs : Implemented parameter-less constructor for TypeContainer
20203 * decl.cs: Attributes are now stored here. New property OptAttributes
20205 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
20207 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
20209 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20211 * typemanager.cs (CSharpSignature): Now reports also inner class name.
20212 (CSharpSignature): New method for indexer and property signature.
20214 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20216 * pending.cs (IsVirtualFilter): Faster implementation.
20218 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20220 * typemanager.cs: Avoid inclusion of same assembly more than once.
20222 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20224 * cs-parser.jay: Fixed problem where the last assembly attribute
20225 has been applied also to following declaration (class, struct, etc.)
20227 2004-01-21 Marek Safar <marek.safar@seznam.cz>
20229 * class.cs: Added error CS0538, CS0539 reporting.
20230 Fixed crash on Microsoft runtime when field type is void.
20232 * cs-parser.jay: Added error CS0537 reporting.
20234 * pending.cs: Added error CS0535 reporting.
20235 Improved error report for errors CS0536, CS0534.
20237 2004-01-20 Miguel de Icaza <miguel@ximian.com>
20239 Merge a few bits from the Anonymous Method MCS tree.
20241 * statement.cs (ToplevelBlock): New class for toplevel methods,
20242 will hold anonymous methods, lifted variables.
20244 * cs-parser.jay: Create toplevel blocks for delegates and for
20245 regular blocks of code.
20247 2004-01-20 Martin Baulig <martin@ximian.com>
20249 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
20250 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
20251 and `NeedExplicitReturn'; added `IsLastStatement'.
20252 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
20253 have a `ReturnLabel' or we're not unreachable.
20255 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
20256 child's reachability; don't just override ours with it. Fixes
20257 #58058 (lluis's example).
20258 (FlowBranching): Added public InTryOrCatch(), InCatch(),
20259 InFinally(), InLoop(), InSwitch() and
20260 BreakCrossesTryCatchBoundary() methods.
20262 * statement.cs (Return): Do all error checking in Resolve().
20263 Unless we are the last statement in a top-level block, always
20264 create a return label and jump to it.
20265 (Break, Continue): Do all error checking in Resolve(); also make
20266 sure we aren't leaving a `finally'.
20267 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
20268 statement in a top-level block.
20269 (Block.Flags): Added `IsDestructor'.
20270 (Block.IsDestructor): New public property.
20272 2004-01-20 Martin Baulig <martin@ximian.com>
20274 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
20276 2004-01-20 Martin Baulig <martin@ximian.com>
20278 * statement.cs (Statement.ResolveUnreachable): New public method.
20279 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
20280 (Block.Resolve): Resolve unreachable statements.
20282 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20284 * expression.cs: We need to fix the case where we do
20285 not have a temp variable here.
20287 * assign.cs: Only expression compound assignments need
20288 temporary variables.
20290 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
20292 * flowanalysis.cs: Reduce memory allocation in a few ways:
20293 - A block with no variables should not allocate a bit
20295 - A method with no out parameters does not need any tracking
20296 for assignment of the parameters, so we need not allocate
20299 public readonly Type[] VariableTypes;
20300 public readonly string[] VariableNames;
20301 Are redundant. The data is already stored in the variable
20302 map, so we need not allocate another array for it.
20303 - We need to add alot of checks for if (params | locals) == null
20304 due to the first two changes.
20306 2004-01-18 Miguel de Icaza <miguel@ximian.com>
20308 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
20309 implement IMemoryLocation, we store a copy on a local variable and
20310 take the address of it. Patch from Benjamin Jemlich
20312 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
20313 to use a special "type_name_expression" rule which reduces the
20314 number of "QualifiedIdentifier" classes created, and instead
20315 directly creates MemberAccess expressions.
20317 2004-01-17 Miguel de Icaza <miguel@ximian.com>
20319 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
20320 that fixes #52853. Null literal assignment to ValueType
20322 * class.cs (MethodData.Emit): Instead of checking the name of the
20323 method to determine if its a destructor, create a new derived
20324 class from Method called Destructor, and test for that.
20326 * cs-parser.jay: Create a Destructor object instead of a Method.
20328 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
20332 2004-01-16 Miguel de Icaza <miguel@ximian.com>
20334 * expression.cs (Binary.ResolveOperator): Perform an implicit
20335 conversion from MethodGroups to their delegate types on the
20336 Addition operation.
20338 * delegate.cs: Introduce a new class DelegateCreation that is the
20339 base class for `NewDelegate' and `ImplicitDelegateCreation',
20340 factor some code in here.
20342 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
20343 conversion from MethodGroups to compatible delegate types.
20345 * ecore.cs (Expression.Resolve): Do not flag error 654
20346 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
20347 we allow conversions from MethodGroups to delegate types now.
20349 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
20350 assignments in v2 either.
20352 2004-01-10 Miguel de Icaza <miguel@ximian.com>
20354 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
20355 static read-only fields in ctors.
20357 Applied patch from Benjamin Jemlich
20359 * expression.cs (UnaryMutator): Avoid leaking local variables.
20361 2004-01-09 Miguel de Icaza <miguel@ximian.com>
20363 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20364 here to return true, as they can be used like this:
20366 (XXX) int.MEMBER ()
20368 Fixed 49836 and all the other dups
20370 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20372 * driver.cs: Implement /win32res and /win32icon.
20374 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20376 * cs-parser.jay: Add a rule to improve error handling for the
20377 common mistake of placing modifiers after the type.
20379 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20381 * cs-parser.jay (interface_event_declaration): Catch
20382 initialization of events on interfaces, and report cs0068
20384 * cs-parser.jay (interface_event_declaration): Catch
20385 initialization of events.
20387 * ecore.cs: Better report missing constructors.
20389 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20390 the error reporting done in the wrong place. Fix.
20392 * expression.cs (Binary.ResolveOperator): Catch the
20393 operator + (E x, E y) error earlier, and later allow for implicit
20394 conversions in operator +/- (E e, U x) from U to the underlying
20397 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20398 52596, if the container class is abstract, the default constructor
20399 is protected otherwise its public (before, we were always public).
20401 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20404 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20405 Jemlich that fixes bug #52597, MCS was generating invalid code for
20406 idisposable structs. Thanks to Ben for following up with this
20409 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20411 * driver.cs: Allow assemblies without code to be generated, fixes
20414 2004-01-07 Nick Drochak <ndrochak@gol.com>
20416 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20418 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20420 * cs-parser.jay: Add rules to improve error reporting if fields or
20421 methods are declared at the namespace level (error 116)
20423 * Add rules to catch event add/remove
20425 2004-01-04 David Sheldon <dave-mono@earth.li>
20427 * expression.cs: Added matching ")" to error message for
20430 2004-01-03 Todd Berman <tberman@gentoo.org>
20432 * ecore.cs, attribute.cs:
20433 Applying fix from #52429.
20435 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20437 * ecore.cs, expression.cs, statement.cs:
20438 Total rewrite of how we handle branching. We
20439 now handle complex boolean expressions with fewer
20440 jumps. As well if (x == 0) no longer emits a ceq.
20442 if (x is Foo) is much faster now, because we generate
20445 Overall, we get a pretty big improvement on our benchmark
20446 tests. The code we generate is smaller and more readable.
20448 I did a full two-stage bootstrap. The patch was reviewed
20449 by Martin and Miguel.
20451 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20453 * cs-parser.jay: Make primary_expression not take a QI.
20454 we dont need this because the member_access rule covers
20455 us here. So we replace the rule with just IDENTIFIER.
20457 This has two good effects. First, we remove a s/r conflict.
20458 Second, we allocate many fewer QualifiedIdentifier objects.
20460 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20462 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20463 set the correct information via SRE. This prevents
20464 hanging on the MS runtime. Fixes #29374.
20466 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20468 * convert.cs: correctly handle conversions to value types
20469 from Enum and ValueType as unboxing conversions.
20471 Fixes bug #52569. Patch by Benjamin Jemlich.
20473 2004-01-02 Ravi Pratap <ravi@ximian.com>
20475 * expression.cs (BetterConversion): Prefer int -> uint
20476 over int -> ulong (csc's behaviour). This fixed bug #52046.
20478 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20480 * decl.cs (MemberCache.FindMembers): now returns a
20483 * typemanager.cs: In general, go with with ^^.
20484 (CopyNewMethods): take an IList.
20485 (RealMemberLookup): Only allocate an arraylist
20486 if we copy from two sets of methods.
20488 This change basically does two things:
20489 1) Fewer array lists allocated due to CopyNewMethods.
20490 2) the explicit cast in MemberList costed ALOT.
20492 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20494 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20495 a hashtable to avoid needless string allocations when an identifier is
20496 used more than once (the common case).
20498 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20500 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20501 is broken, it will not return anything. So, we
20502 have to use the information we have in mcs to
20505 * typemanager.cs: Add a cache for GetInterfaces,
20506 since this will now be used more often (due to ^^)
20508 (GetExplicitInterfaces) New method that gets the
20509 declared, not effective, interfaces on a type
20510 builder (eg, if you have interface IFoo, interface
20511 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20514 This patch makes MCS able to bootstrap itself on
20517 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20519 * expression.cs: Remove the Nop's that Miguel put
20522 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20524 * report.cs, codegen.cs: Give the real stack trace to
20525 the error when an exception is thrown.
20527 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20529 * decl.cs: only allocate hashtables for ifaces if
20532 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20534 * expression.cs: fix the error from cs0121-2.cs
20535 (a parent interface has two child interfaces that
20536 have a function with the same name and 0 params
20537 and the function is called through the parent).
20539 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20541 * class.cs, rootcontext.cs, typmanager.cs: do not
20544 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20546 * codegen.cs: remove stack for the ec flow branching.
20547 It is already a linked list, so no need.
20549 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20551 * Makefile: Allow custom profiler here.
20553 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20555 * typemanager.cs (LookupType):
20556 - Use a static char [], because split takes
20557 a param array for args, so it was allocating
20559 - Do not store true in a hashtable, it boxes.
20561 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20563 * flowanalysis.cs: bytify common enums.
20565 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20567 * modifiers.cs: Add a new set of flags for the
20568 flags allowed on explicit interface impls.
20569 * cs-parser.jay: catch the use of modifiers in
20570 interfaces correctly.
20571 * class.cs: catch private void IFoo.Blah ().
20573 All related to bug #50572.
20575 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20577 * decl.cs: Rewrite the consistant accessability checking.
20578 Accessability is not linear, it must be implemented in
20579 a tableish way. Fixes #49704.
20581 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20583 * expression.cs: Handle negation in a checked context.
20584 We must use subtraction from zero. Fixes #38674.
20586 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20588 * class.cs: Ignore static void main in DLLs.
20589 * rootcontext.cs: Handle the target type here,
20590 since we are have to access it from class.cs
20591 * driver.cs: account for the above.
20593 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20595 * report.cs: Give line numbers and files if available.
20597 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20599 * driver.cs: Implement /addmodule.
20601 * typemanager.cs: Change 'modules' field so it now contains Modules not
20604 2003-12-20 Martin Baulig <martin@ximian.com>
20606 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20607 (FieldBase.IsAssigned): Removed this field.
20608 (FieldBase.SetAssigned): New public method.
20609 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20611 2003-12-20 Martin Baulig <martin@ximian.com>
20613 * expression.cs (LocalVariableReference.DoResolve): Don't set
20614 `vi.Used' if we're called from DoResolveLValue().
20616 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20617 returns the usage vector it just merged into the current one -
20618 pass this one to UsageWarning().
20619 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20620 of the `EmitContext', don't call this recursively on our children.
20622 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20624 * driver.cs: Implement /target:module.
20626 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20628 * support.cs (CharArrayHashtable): New helper class.
20630 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20631 char arrays, not strings, so we can avoid creating a string in
20632 consume_identifier if the identifier is a keyword.
20634 2003-12-16 Martin Baulig <martin@ximian.com>
20636 * statement.cs (LocalInfo.Assigned): Removed this property.
20637 (LocalInfo.Flags): Removed `Assigned'.
20638 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20639 and uses flow analysis.
20640 (Block.UsageWarning): Made this method private.
20641 (Block.Resolve): Call UsageWarning() if appropriate.
20643 * expression.cs (LocalVariableReference.DoResolve): Always set
20644 LocalInfo.Used here.
20646 2003-12-13 Martin Baulig <martin@ximian.com>
20648 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20649 any value here; we're now using flow analysis to figure out
20650 whether a statement/block returns a value.
20652 2003-12-13 Martin Baulig <martin@ximian.com>
20654 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20656 (FlowBranching.MergeFinally): Don't call
20657 `branching.CheckOutParameters()' here, this is called in
20659 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20660 when adding the `finally' vector.
20662 2003-12-13 Martin Baulig <martin@ximian.com>
20665 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20666 actually work and also fix #48962.
20668 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20670 * decl.cs: Do not check System.Object for nested types,
20671 since we know it does not have any. Big bang for buck:
20674 Run 1: 8.35 seconds
20675 Run 2: 8.32 seconds
20676 corlib: 17.99 seconds
20678 Run 1: 8.17 seconds
20679 Run 2: 8.17 seconds
20680 corlib: 17.39 seconds
20682 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20684 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20685 time we are returning 0 members, so we save alot here.
20687 2003-12-11 Martin Baulig <martin@ximian.com>
20689 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20690 `MergeChild()', also just take the `FlowBranching' as argument;
20691 call Merge() on it and return the result.
20692 (FlowBranching.Merge): We don't need to do anything if we just
20695 2003-12-11 Martin Baulig <martin@ximian.com>
20697 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20698 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20699 Maurer for this idea.
20701 2003-12-11 Martin Baulig <martin@ximian.com>
20703 * flowanalysis.cs (MergeResult): This class is now gone; we now
20704 use the `UsageVector' for this. The reason for this is that if a
20705 branching just has one sibling, we don't need to "merge" them at
20706 all - that's the next step to do.
20707 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20710 2003-12-11 Martin Baulig <martin@ximian.com>
20712 Reworked flow analyis and made it more precise and bug-free. The
20713 most important change is that we're now using a special `Reachability'
20714 class instead of having "magic" meanings of `FlowReturns'. I'll
20715 do some more cleanups and optimizations and also add some more
20716 documentation this week.
20718 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20719 largely reworked this class.
20720 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20721 the new `Reachability' class instead of having "magic" values here.
20722 (FlowBranching): We're now using an instance of `Reachability'
20723 instead of having separate `Returns', `Breaks' etc. fields.
20725 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20726 based on flow analysis; ignore the return value of block.Emit ().
20728 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20730 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20731 if they are private.
20733 2003-12-09 Martin Baulig <martin@ximian.com>
20735 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20736 call them directly on the UsageVector.
20738 2003-12-09 Martin Baulig <martin@ximian.com>
20740 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20741 Changed return type from `FlowReturns' to `Reachability'.
20743 2003-12-09 Martin Baulig <martin@ximian.com>
20745 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20746 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20747 `Reachable' fields with a single `Reachability' one.
20749 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20751 * class.cs (FindMembers): Remove foreach's.
20756 Run 1: 8.74 seconds
20757 Run 2: 8.71 seconds
20760 Run 1: 8.64 seconds
20761 Run 2: 8.58 seconds
20764 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20769 This patch does a few things:
20770 1. EmptyStatement is now a singleton, so it is never reallocated.
20771 2. All blah is EmptyStatement constructs have been changed to
20772 blah == EmptyStatement.Value, which is much faster and valid
20773 now that EmptyStatement is a singleton.
20774 3. When resolving a block, rather than allocating a new array for
20775 the non-empty statements, empty statements are replaced with
20776 EmptyStatement.Value
20777 4. Some recursive functions have been made non-recursive.
20778 Mainly the performance impact is from (3), however (1) and (2) are needed for
20779 this to work. (4) does not make a big difference in normal situations, however
20780 it makes the profile look saner.
20785 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20786 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20787 Total memory allocated: 56397 KB
20790 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20791 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20792 Total memory allocated: 55666 KB
20794 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20796 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20797 than the hashtable in a hashtable version
20799 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20800 we always end up concating a string. This results in a huge perf
20801 loss, because many strings have to be tracked by the GC. In this
20802 patch, we first use a hashtable that works with two keys, so that
20803 the strings do not need to be concat'ed.
20807 Run 1: 8.74 seconds
20808 Run 2: 8.71 seconds
20811 Run 1: 8.65 seconds
20812 Run 2: 8.56 seconds
20814 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20816 * Makefile: Add a new target `do-time' that does a quick and simple
20817 profile, leaving easy to parse output.
20819 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20821 * codegen.cs (Init): Create the dynamic assembly with
20822 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20824 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20826 * support.cs: Make the PtrHashtable use only one
20827 instance of its comparer.
20829 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20831 * typemanager.cs: Fix lookup of GetNamespaces.
20833 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20835 * expression.cs: Removed redundant line.
20837 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20838 ArrayLists, use for loops with bounds.
20840 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20843 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20844 arraylists, use for loop with bounds.
20846 The above three changes give us a 0.071 second performance
20847 improvement out of 3.294 seconds down to 3.223. On my machine
20848 the above changes reduced the memory usage by 1,387 KB during
20849 compiler bootstrap.
20851 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20852 QualifiedIdentifiers. Before we created a new string through
20853 concatenation, and mostly later on, the result would be
20854 manipulated by DecomposeQI through string manipulation.
20856 This reduced the compiler memory usage for bootstrapping from
20857 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20858 compile times in 0.05 seconds.
20860 2003-11-28 Dick Porter <dick@ximian.com>
20862 * support.cs: Do string compares with the Invariant culture.
20870 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20871 the comparison is done with the Invariant culture.
20873 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20875 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20876 GetEnumerator method.
20878 (ProbeCollectionType): Iterate starting at the most specific type
20879 upwards looking for a GetEnumerator
20881 * expression.cs: Shift count can be up to 31 for int/uint and 63
20884 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20886 * statement.cs (Block.LookupLabel): Also look for the label on the
20887 children blocks. Use a hash table to keep track of visited
20890 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20891 we actually did transform the other operand, otherwise fall back
20892 to the common codepath that casts to long.
20894 * cs-tokenizer.cs: Use the same code pattern as the int case.
20895 Maybe I should do the parsing myself, and avoid depending on the
20896 Parse routines to get this done.
20898 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20900 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20901 which fixes bug 51347. This time test it.
20903 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20904 attributes for example can not tell the difference between these.
20905 The difference was only a syntax feature of the language.
20907 * attribute.cs: Apply attributes to delegates.
20909 * delegate.cs: Call the apply attributes method.
20911 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20913 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20914 comparing 0 vs Byte.MinValue, not the value
20916 (ImplicitConversionRequired): When reporting a conversion error,
20917 use error 31 to print out the constant error instead of the
20920 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20921 which fixes bug 51347.
20923 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20925 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20926 which fixes the -warnaserror command line option.
20928 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20930 * cfold.cs (DoNumericPromotions): During constant folding of
20931 additions on UIntConstant, special case intconstants with
20932 IntConstants like we do on the expression binary operator.
20934 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20936 * convert.cs (ImplicitReferenceConversion): We were missing a case
20937 (System.Enum are not value types or class types, so we need to
20938 classify them separatedly).
20940 * driver.cs: We do not support error 2007.
20942 2003-11-12 Jackson Harper <jackson@ximian.com>
20944 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20945 system directory. Also use the full file name so users can
20946 libraries names mscorlib-o-tron.dll in a non system dir.
20948 2003-11-10 Martin Baulig <martin@ximian.com>
20950 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20951 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20952 calling `ResolveType()' on them, directly assign their `Type'.
20954 2003-11-08 Martin Baulig <martin@ximian.com>
20956 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20957 return value and the `out parent' parameter.
20958 (TypeContainer.DefineType): Moved the CS0644 check into
20959 GetClassBases(). Don't pass the interface types to the
20960 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20961 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20963 * ecore.cs (TypeExpr.IsAttribute): New property.
20964 (TypeExpr.GetInterfaces): New method.
20966 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20967 TypeExpr instead of a Type.
20968 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20969 (Interface.DefineType): Don't pass the interface types to the
20970 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20971 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20973 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20974 instead of a `Type[]'.
20975 (TypeManager.RegisterBuilder): Likewise.
20976 (TypeManager.AddUserInterface): Likewise.
20977 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20978 `Type[]' and also return a `TypeExpr[]'.
20979 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20981 2003-11-08 Martin Baulig <martin@ximian.com>
20983 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20986 2003-11-08 Martin Baulig <martin@ximian.com>
20988 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20989 TypeManager.ResolveExpressionTypes().
20991 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20992 instead of an Expression.
20993 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20994 (TypeExpression): New public class; formerly known as `TypeExpr'.
20996 * expression.cs (ComposedCast): Derive from TypeExpr.
20998 * typemanager.cs (TypeManager.system_*_expr): These are now
20999 TypExpr's instead of Expression's.
21000 (TypeManager.ResolveExpressionTypes): New public static function;
21001 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
21004 2003-11-06 Miguel de Icaza <miguel@ximian.com>
21006 * expression.cs (New.DoResolve): Do not dereference value that
21007 might be a null return.
21009 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
21010 sure that the constant value has the right type. Fixes an
21011 unreported bug, similar to 50425.
21013 * const.cs (Const.LookupConstantValue): Call
21014 ImplicitStandardConversionExists before doing a conversion to
21015 avoid havng the TypeManager.ChangeType do conversions.
21017 Reduced the number of casts used
21019 (Const.ChangeType): New routine to enable reuse of the constant
21020 type changing code from statement.
21022 * typemanager.cs (ChangeType): Move common initialization to
21023 static global variables.
21027 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
21028 every value type to go through, even if it was void. Fix that.
21030 * cs-tokenizer.cs: Use is_identifier_start_character on the start
21031 character of the define, and the is_identifier_part_character for
21032 the rest of the string.
21034 2003-11-05 Miguel de Icaza <miguel@ximian.com>
21036 * expression.cs (UnaryMutator.EmitCode): When I updated
21037 LocalVariableReference.DoResolve, I overdid it, and dropped an
21038 optimization done on local variable references.
21040 2003-11-04 Miguel de Icaza <miguel@ximian.com>
21042 * ecore.cs: Convert the return from Ldlen into an int.
21044 2003-10-20 Miguel de Icaza <miguel@ximian.com>
21046 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
21047 the accessibility, this is a special case for toplevel non-public
21048 classes (internal for instance).
21050 2003-10-20 Nick Drochak <ndrochak@gol.com>
21052 * ecore.cs: Fix typo and build. Needed another right paren.
21054 2003-10-19 Miguel de Icaza <miguel@ximian.com>
21056 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
21057 `internal' case regular and protected, but not allowing protected
21058 to be evaluated later. Bug 49840
21060 2003-10-15 Miguel de Icaza <miguel@ximian.com>
21062 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
21063 to kb.Nlast, and not the kb.nFirst to isolate the switch
21066 Extract the underlying type, so enumerations of long/ulong are
21067 treated like long/ulong.
21069 2003-10-14 Miguel de Icaza <miguel@ximian.com>
21071 * expression.cs (New): Overload the meaning of RequestedType to
21072 track the possible creation of the NewDelegate type, since
21073 DoResolve is invoked more than once for new constructors on field
21076 See bugs: #48800 and #37014
21078 * cs-parser.jay (declare_local_constants): Take an arraylist
21079 instead of a single constant.
21081 (local_constant_declaration): It should take a
21082 constant_declarators, not a constant_declarator. Fixes 49487
21084 * convert.cs: Fix error report.
21086 2003-10-13 Jackson Harper <jackson@ximian.com>
21088 * typemanager.cs (TypeToCoreType): Add float and double this fixes
21091 2003-10-09 Martin Baulig <martin@ximian.com>
21093 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
21095 (MethodCore.DoDefineParameters): Removed the TypeContainer
21096 argument; use the DeclSpace which was passed to the .ctor instead.
21097 (MethodCore.CheckParameter): Take a DeclSpace instead of a
21098 TypeContainer; we only need a DeclSpace here.
21100 2003-10-09 Martin Baulig <martin@ximian.com>
21102 * class.cs (MethodData): Added additional `DeclSpace ds' argument
21104 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
21105 EmitContext's .ctor.
21107 2003-10-09 Martin Baulig <martin@ximian.com>
21109 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
21110 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
21111 AsAccessible(), moved them as well.
21113 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
21115 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
21117 * cs-parser.jay : Renamed yyName to yyNames related to jay.
21119 2003-10-07 Miguel de Icaza <miguel@ximian.com>
21121 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
21122 generation for >=, as spotted by Paolo, bug 48679.
21123 Patch from David Waite.
21125 * cs-tokenizer.cs: Add handling for #pragma.
21127 * cs-parser.jay: Allow for both yield and yield return in the
21128 syntax. The anti-cobolization of C# fight will go on!
21130 * class.cs (TypeBuilder.DefineType): Catch error condition here
21131 (Parent.DefineType erroring out and returning null).
21133 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21134 coping with enumerations variables, we were mistakenly processing
21135 them as a regular value type instead of built-in types. Fixes the
21138 * typemanager.cs (IsBuiltinOrEnum): New method.
21140 2003-09-30 Miguel de Icaza <miguel@ximian.com>
21142 * cs-parser.jay: Upgrade: yield now needs the return clause.
21144 2003-09-19 Martin Baulig <martin@ximian.com>
21146 * decl.cs (MemberCache.SetupCacheForInterface): Take a
21147 `MemberCache parent' argument. Normally, an interface doesn't
21148 have a parent type except System.Object, but we use this in gmcs
21149 for generic type parameters.
21151 2003-09-18 Martin Baulig <martin@ximian.com>
21153 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
21154 on `type.IsInterface'; don't check whether the type has a parent
21155 to determine whether it's an interface.
21157 2003-09-15 Martin Baulig <martin@ximian.com>
21159 * class.cs (TypeContainer.DefineType): Added an error flag to
21160 avoid reporting duplicate CS0146's ("class definition is
21163 * driver.cs (Driver.MainDriver): Abort if
21164 RootContext.ResolveTree() reported any errors.
21166 2003-09-07 Martin Baulig <martin@ximian.com>
21168 * report.cs (Error, Warning): Added overloaded versions which take
21169 a `params object[] args' and call String.Format().
21171 2003-09-07 Martin Baulig <martin@ximian.com>
21173 * decl.cs (DeclSpace..ctor): Don't call
21174 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
21175 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
21176 (DeclSpace.RecordDecl): New method.
21178 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
21180 2003-09-02 Ravi Pratap <ravi@ximian.com>
21182 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
21183 value attributes to be applied to ParameterBuilders.
21185 * class.cs (MethodCore.LabelParameters): Make static and more
21186 generic so that it can be used from other places - like interface
21187 methods, for instance.
21189 * interface.cs (Interface.Emit): Call LabelParameters before
21190 emitting attributes on the InterfaceMethod.
21192 2003-08-26 Martin Baulig <martin@ximian.com>
21194 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
21195 resolving aliases; fixes #47927.
21197 2003-08-26 Martin Baulig <martin@ximian.com>
21199 * statement.cs (Using.DoResolve): This is internally emitting a
21200 try/finally clause, so we need to set ec.NeedExplicitReturn if we
21201 do not always return. Fixes #47681.
21203 2003-08-26 Martin Baulig <martin@ximian.com>
21205 * decl.cs (MemberCore): Moved WarningNotHiding(),
21206 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
21208 (AdditionResult): Make this nested in DeclSpace.
21209 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
21210 argument; call NamespaceEntry.Define() unless we're nested in a
21213 * namespace.cs (Namespace.DefineName): New public function. This
21214 is called from DeclSpace's .ctor to add
21215 (Namespace.Lookup): Include DeclSpaces in the lookup.
21217 * class.cs (Operator): Derive from MemberBase, not MemberCore.
21219 * const.cs (Const): Derive from MemberBase, not MemberCore.
21221 2003-08-25 Martin Baulig <martin@ximian.com>
21223 * convert.cs (Convert.ExplicitReferenceConversion): When
21224 converting from an interface type to a class, unbox if the target
21225 type is a struct type. Fixes #47822.
21227 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21229 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
21232 2003-08-22 Martin Baulig <martin@ximian.com>
21234 * class.cs (TypeManager.DefineType): When defining a nested type,
21235 call DefineType() on our parent; fixes #47801.
21237 2003-08-22 Martin Baulig <martin@ximian.com>
21239 * class.cs (MethodData.Define): While checking if a method is an
21240 interface implementation, improve the test a bit more to fix #47654.
21242 2003-08-22 Martin Baulig <martin@ximian.com>
21244 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
21245 correctly; fixes #47722.
21247 2003-08-22 Martin Baulig <martin@ximian.com>
21249 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
21250 LocalVariableReference, ensure it's not read-only. Fixes #47536.
21252 * statement.cs (Fixed.DoResolve): Make all variables read-only.
21254 2003-08-22 Martin Baulig <martin@ximian.com>
21256 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
21257 can only be assigned in static constructors. Fixes #47161.
21259 2003-08-22 Martin Baulig <martin@ximian.com>
21261 Rewrote and improved the flow analysis code.
21263 * flowbranching.cs (FlowBranching): Make this class abstract.
21264 (FlowBranching.CreateBranching): New static function to create a
21265 new flow branching.
21266 (FlowBranchingBlock, FlowBranchingException): New classes.
21267 (FlowBranching.UsageVector.Type): New public readonly field.
21268 (FlowBranching.UsageVector.Breaks): Removed the setter.
21269 (FlowBranching.UsageVector.Returns): Removed the setter.
21270 (FlowBranching.UsageVector): Added Break(), Return(),
21271 NeverReachable() and Throw() methods to modify the reachability.
21272 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
21273 done by FlowBranching.Merge().
21274 (FlowBranching.UsageVector.MergeChild): New method; merges the
21275 merge result into the current vector.
21276 (FlowBranching.Merge): New abstract method to merge a branching.
21278 2003-08-12 Martin Baulig <martin@ximian.com>
21280 * expression.cs (Indirection.CacheTemporaries): Create the
21281 LocalTemporary with the pointer type, not its element type.
21283 2003-08-10 Miguel de Icaza <miguel@ximian.com>
21285 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
21286 token was a keyword or not.
21288 Add `error' options where an IDENTIFIER was expected; Provide
21289 CheckToken and CheckIdentifierToken convenience error reporting
21292 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
21294 * decl.cs: Rename `NamespaceEntry Namespace' public field into
21295 NameSpaceEntry NameSpaceEntry.
21297 (LookupInterfaceOrClass): Avoid creating a full qualified name
21298 from namespace and name: avoid doing lookups when we know the
21299 namespace is non-existant. Use new Tree.LookupByNamespace which
21300 looks up DeclSpaces based on their namespace, name pair.
21302 * driver.cs: Provide a new `parser verbose' to display the
21303 exception thrown during parsing. This is turned off by default
21304 now, so the output of a failure from mcs is more graceful.
21306 * namespace.cs: Track all the namespaces defined in a hashtable
21309 (IsNamespace): New method
21311 2003-08-09 Miguel de Icaza <miguel@ximian.com>
21313 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
21314 we know that we need to concatenate (full typename can never be
21319 * statement.cs: Use a bitfield; Do not initialize to null things
21320 which are done by the constructor by default.
21322 * cs-parser.jay: bug fix, parameter was 4, not 3.
21324 * expression.cs: Just use the property;
21326 * statement.cs: No need for GetVariableInfo method.
21328 2003-08-08 Martin Baulig <martin@ximian.com>
21330 * flowanalysis.cs (FlowReturns): This is now nested in the
21331 `FlowBranching' class.
21332 (MyBitVector): Moved this here from statement.cs.
21333 (FlowBranching.SiblingType): New enum type.
21334 (FlowBranching.CreateSibling): Added `SiblingType' argument.
21336 2003-08-07 Martin Baulig <martin@ximian.com>
21338 * flowanalysis.cs (FlowBranchingType): This is now nested in the
21339 `FlowBranching' class and called `BranchingType'.
21341 2003-08-07 Martin Baulig <martin@ximian.com>
21343 * flowanalysis.cs: Moved all the control flow analysis code into
21346 2003-08-07 Martin Baulig <martin@ximian.com>
21348 * assign.cs (Assign.DoResolve): `target' must either be an
21349 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
21352 2003-08-07 Miguel de Icaza <miguel@ximian.com>
21354 * expression.cs (BinaryMethod): This kind of expression is created by the
21355 Binary class if it determines that the operator has to be handled
21358 (BinaryDelegate): This kind of expression is created if we are
21359 dealing with a + or - operator on delegates.
21361 (Binary): remove method, argumetns, and DelegateOperator: when
21362 dealing with methods,
21364 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21366 * statement.cs (Block): use bitfields for the three extra booleans
21367 we had in use. Remove unused topblock parameter.
21369 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21371 * assign.cs: Drop extra unneeded tests.
21373 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21375 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21377 * statement.cs (Foreach): Use VariableStorage instead of
21380 * codegen.cs (VariableStorage): New class used by clients that
21381 require a variable stored: locals or fields for variables that
21382 need to live across yield.
21384 Maybe provide a convenience api for EmitThis+EmitLoad?
21386 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21389 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21391 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21392 RemapParameterLValue): New methods that are used to turn a
21393 precomputed FieldInfo into an expression like this:
21397 The idea is to use this instead of making LocalVariableReference
21398 have more than one meaning.
21400 * cs-parser.jay: Add error production to BASE.
21402 * ecore.cs: Deal with TypeManager.GetField returning null, which
21403 is now a valid return value.
21405 (FieldExprNoAddress): New expression for Fields whose address can
21408 * expression.cs (LocalVariableReference): During the resolve
21409 phases, create new expressions if we are in a remapping context.
21410 Remove code that dealt with remapping here.
21412 (ParameterReference): same.
21414 (ProxyInstance): New expression, like the `This' expression, but
21415 it is born fully resolved. We know what we are doing, so remove
21416 the errors that are targeted to user-provided uses of `this'.
21418 * statement.cs (Foreach): our variable is now stored as an
21419 Expression; During resolution, follow the protocol, dont just
21420 assume it will return this.
21422 2003-08-06 Martin Baulig <martin@ximian.com>
21424 * support.cs (SeekableStreamReader.cs): New public class.
21426 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21427 SeekableStreamReader instead of the normal StreamReader.
21429 2003-08-04 Martin Baulig <martin@ximian.com>
21431 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21432 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21433 deambiguate casts and delegate invocations.
21434 (parenthesized_expression): Use the new tokens to ensure this is
21435 not a cast of method invocation.
21437 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21438 when reading a `)' and Deambiguate_CloseParens () was previously
21441 * expression.cs (ParenthesizedExpression): New class. This is
21442 just used for the CS0075 test.
21443 (Binary.DoResolve): Check for CS0075.
21445 2003-07-29 Ravi Pratap <ravi@ximian.com>
21447 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21448 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21449 reference comparison.
21451 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21452 examine the ReturnType for equality - this is necessary in the
21453 cases of implicit and explicit operators whose signature also
21454 includes the return type.
21456 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21458 * namespace.cs: Cache the result of the namespace computation,
21459 instead of computing it every time.
21461 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21463 * decl.cs: Use a global arraylist that we reuse over invocations
21464 to avoid excesive memory consumption. Reduces memory usage on an
21465 mcs compile by one meg (45 average).
21467 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21468 private, work around that.
21470 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21472 * literal.cs (IntLiteral): Define Zero and One static literals.
21474 * cs-parser.jay (integer_literal): use static literals to reduce
21475 memory usage for the most used literals (0, 1 and -1). 211kb
21476 reduced in memory usage.
21478 Replace all calls to `new ArrayList' with `new
21479 ArrayList(4)' which is a good average number for most allocations,
21480 and also requires only 16 bytes of memory for its buffer by
21483 This reduced MCS memory usage in seven megabytes for the RSS after
21486 2003-07-28 Ravi Pratap <ravi@ximian.com>
21488 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21489 handle params methods the correct way by forming only one
21490 applicable set with params and normal methods in them. Earlier we
21491 were looking at params methods only if we found no normal methods
21492 which was not the correct thing to do.
21494 (Invocation.BetterFunction): Take separate arguments indicating
21495 when candidate and the best method are params methods in their
21498 This fixes bugs #43367 and #46199.
21500 * attribute.cs: Documentation updates.
21502 (CheckAttribute): Rename to CheckAttributeTarget.
21503 (GetValidPlaces): Rename to GetValidTargets.
21505 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21506 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21510 2003-07-28 Martin Baulig <martin@ximian.com>
21512 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21513 name when looking up the base class of a nested class. Fixes #46977.
21515 2003-07-26 Martin Baulig <martin@ximian.com>
21517 * expression.cs (Indexers.Indexer): New nested struct; contains
21518 getter, setter and the indexer's type.
21519 (Indexers.Properties): This is now an ArrayList of
21520 Indexers.Indexer's.
21521 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21522 indexer doesn't have any getters.
21524 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21525 for embedded property and indexer assignments.
21527 2003-07-26 Martin Baulig <martin@ximian.com>
21529 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21530 preprocessor directive is not the first non-whitespace character
21533 2003-07-26 Martin Baulig <martin@ximian.com>
21535 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21536 namespace parsing, follow the spec more closely.
21538 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21539 NamespaceEntry.Lookup().
21541 2003-07-25 Martin Baulig <martin@ximian.com>
21543 * MethodCore.cs (OverridesSomething): New public field; it's set
21544 from TypeContainer.DefineMembers if this method overrides
21545 something (which doesn't need to be a method). Fix #39462.
21547 2003-07-25 Ravi Pratap <ravi@ximian.com>
21549 * typemanager.cs (GetMembers): Ensure that the list of members is
21550 reversed. This keeps things in sync.
21552 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21553 find an AttributeUsage attribute.
21555 * expression.cs (Invocation.OverloadResolve): Perform the check
21556 which disallows Invoke to be directly called on a Delegate.
21558 (Error_InvokeOnDelegate): Report error cs1533.
21560 2003-07-25 Martin Baulig <martin@ximian.com>
21562 * expression.cs (Indexers.GetIndexersForType): Only look in the
21563 interface hierarchy if the requested type is already an
21564 interface. Fixes #46788 while keeping #46502 fixed.
21566 2003-07-25 Martin Baulig <martin@ximian.com>
21568 * class.cs (TypeContainer.DefineMembers): Check whether all
21569 readonly fields have been assigned and report warning CS0649 if
21572 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21575 2003-07-24 Ravi Pratap <ravi@ximian.com>
21577 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21578 returned from GetMethods to make things consistent with the
21579 assumptions MCS makes about ordering of methods.
21581 This should comprehensively fix bug #45127 and it does :-)
21583 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21584 ordering is actually reverse.
21586 * Clean up some debug messages I left lying around.
21588 * interface.cs (Populate*): Get rid of code which emits attributes
21589 since the stage in which we emit attributes is the 'Emit' stage,
21590 not the define stage.
21592 (Emit): Move attribute emission for interface members here.
21594 2003-07-22 Ravi Pratap <ravi@ximian.com>
21596 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21597 closely: we eliminate methods in base types when we have an
21598 applicable method in a top-level type.
21600 Please see section 14.5.5.1 for an exact description of what goes
21603 This fixes bug #45127 and a host of other related to corlib compilation.
21605 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21606 array is the method corresponding to the top-level type (this is
21607 because of the changes made to icall.c) so we change this
21610 (MethodGroupExpr.Name): This too.
21612 * typemanager.cs (GetElementType): New method which does the right
21613 thing when compiling corlib.
21615 * everywhere: Make use of the above in the relevant places.
21617 2003-07-22 Martin Baulig <martin@ximian.com>
21619 * cs-parser.jay (invocation_expression): Moved
21620 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21621 `cast_expression', but create a InvocationOrCast which later
21622 resolves to either an Invocation or a Cast.
21624 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21625 method; call this before EmitStatement() to make sure that this
21626 expression can be used as a statement.
21628 * expression.cs (InvocationOrCast): New class; resolves to either
21629 an Invocation or a Cast.
21631 * statement.cs (StatementExpression): Call ResolveStatement() on
21632 the ExpressionStatement before emitting it.
21634 2003-07-21 Martin Baulig <martin@ximian.com>
21636 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21637 `ref' and `out' attributes match; fixes #46220.
21638 (MemberAccess.ResolveMemberAccess): You can't reference a type
21639 through an expression; fixes #33180.
21640 (Indexers.GetIndexersForType): Don't return the indexers from
21641 interfaces the class implements; fixes #46502.
21643 2003-07-21 Martin Baulig <martin@ximian.com>
21645 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21646 CS0661 checks; fixes bug #30442.
21648 2003-07-21 Martin Baulig <martin@ximian.com>
21650 * decl.cs (AdditionResult): Added `Error'.
21652 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21654 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21655 makes cs0031.cs actually work.
21657 2003-07-20 Martin Baulig <martin@ximian.com>
21659 * namespace.cs: Fixed that bug which caused a crash when compiling
21660 the debugger's GUI.
21662 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21664 * typemanager.cs (LookupTypeReflection): Never expose types which
21665 are NotPublic, NestedPrivate, NestedAssembly, or
21666 NestedFamANDAssem. We used to return these, and later do a check
21667 that would report a meaningful error, but the problem is that we
21668 would not get the real match, if there was a name override.
21670 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21672 * namespace.cs (Namespace, Name): Do not compute the namespace
21673 name dynamically, compute it in the constructor. This reduced
21674 memory usage by 1697 KB.
21676 * driver.cs: Use --pause to pause at the end.
21678 2003-07-17 Peter Williams <peter@newton.cx>
21680 * Makefile: Change the name of the test target so that it doesn't
21681 conflict with the recursive test target.
21683 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21685 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21686 AddressOf): Do not use EmitThis, that was wrong, use the actual
21689 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21691 * class.cs (MethodData.Define): While checking if a method is an
21692 interface implementation, improve the test: If we are not public
21693 (use new test here: use the computed MethodAttributes directly,
21694 instead of the parsed modifier flags) check if the `implementing'
21695 method comes from an interface or not.
21697 * pending.cs (VerifyPendingMethods): Slightly better error
21700 * makefile: add test target that does the mcs bootstrap.
21702 2003-07-16 Ravi Pratap <ravi@ximian.com>
21704 * interface.cs (Define): Do nothing here since there are no
21705 members to populate etc. Move the attribute emission out of here
21706 since this was just totally the wrong place to put it. Attribute
21707 application happens during the 'Emit' phase, not in the 'Define'
21710 (Emit): Add this method and move the attribute emission here
21712 * rootcontext.cs (EmitCode): Call the Emit method on interface
21715 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21717 * expression.cs (OverloadResolve): Report error only if Location
21718 is not 'Null' which means that there was a probe going on.
21720 2003-07-14 Martin Baulig <martin@ximian.com>
21722 * expression.cs (ConditionalLogicalOperator): New public class to
21723 implement user defined conditional logical operators.
21724 This is section 14.11.2 in the spec and bug #40505.
21726 2003-07-14 Martin Baulig <martin@ximian.com>
21728 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21730 2003-07-14 Martin Baulig <martin@ximian.com>
21732 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21734 * ecore.cs (IVariable.VerifyFixed): New interface method.
21736 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21737 operator, check whether the variable is actually fixed. Fixes bug
21738 #36055. Set a variable definitely assigned when taking its
21739 address as required by the spec.
21741 * statement.cs (LocalInfo.IsFixed): New field.
21742 (LocalInfo.MakePinned): Set `IsFixed' to true.
21744 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21746 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21747 for .ctors, ensure that we only ask for members declared in the
21748 attribute type (BindingFlags.DeclaredOnly).
21752 * expression.cs (Error_WrongNumArguments): Report error 1501
21753 correctly the way CSC does.
21755 2003-07-13 Martin Baulig <martin@ximian.com>
21757 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21758 lookup on the fully qualified name, to make things like "X.X" work
21759 where "X.X" is a fully qualified type name, but we also have a
21760 namespace "X" in the using list. Fixes #41975.
21762 2003-07-13 Martin Baulig <martin@ximian.com>
21764 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21765 function. If we're a CompoundAssign, we need to create an embedded
21766 CompoundAssign, not an embedded Assign.
21767 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21770 2003-07-13 Martin Baulig <martin@ximian.com>
21772 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21773 work to fix bug #46088.
21775 2003-07-13 Ravi Pratap <ravi@ximian.com>
21777 * class.cs (Operator.Emit): Do not emit attributes here - it is
21778 taken care of by the Method class that we delegate too. This takes
21779 care of bug #45876.
21781 2003-07-10 Martin Baulig <martin@ximian.com>
21783 * expression.cs (TypeOfVoid): New class.
21784 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21786 2003-07-10 Martin Baulig <martin@ximian.com>
21788 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21791 2003-07-10 Martin Baulig <martin@ximian.com>
21793 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21794 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21796 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21798 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21800 2003-07-10 Martin Baulig <martin@ximian.com>
21802 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21803 of decimal. Fixes #42850.
21805 NOTE: I also fixed the created byte blob, but this doesn't work on
21806 the MS runtime and csc never produces any byte blobs for decimal
21809 2003-07-10 Martin Baulig <martin@ximian.com>
21811 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21812 structs; fixes #32068.
21813 (Block.AddChildVariableNames): Fixed #44302.
21815 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21817 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21819 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21821 * attribute.cs: And this test is onger needed.
21823 2003-07-08 Martin Baulig <martin@ximian.com>
21825 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21826 inaccessible types. Fixes #36313.
21828 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21830 * namespace.cs (NamespaceEntry): Create implicit entries for all
21831 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21832 implicit entries for N1.N2 and N1.
21834 2003-07-08 Martin Baulig <martin@ximian.com>
21836 Rewrote the handling of namespaces to fix a lot of the issues
21837 wrt. `using' aliases etc.
21839 * namespace.cs (Namespace): Splitted this class into a
21840 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21842 * typemanager.cs (TypeManager.IsNamespace): Removed.
21843 (TypeManager.ComputeNamespaces): Only compute namespaces from
21844 loaded assemblies here, not the namespaces from the assembly we're
21845 currently compiling.
21847 2003-07-08 Martin Baulig <martin@ximian.com>
21849 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21851 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21853 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21856 I thought about the memory savings here, but LookupTypeReflection
21857 is used under already very constrained scenarios. Compiling
21858 corlib or mcs only exposes one hit, so it would not really reduce
21859 any memory consumption.
21861 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21863 * typemanager.cs: fixes bug #45889 by only adding public types from
21864 other assemblies to the list of known types.
21866 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21868 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21869 on the type we resolved.
21871 2003-07-05 Martin Baulig <martin@ximian.com>
21873 * pending.cs (PendingImplementation.ParentImplements): Don't
21874 create the proxy if the parent is abstract.
21876 * class.cs (TypeContainer.DefineIndexers): Process explicit
21877 interface implementations first. Fixes #37714.
21879 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21881 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21882 defined recursively; but since we modify the input parameters
21883 (left is set to `this' temporarily), we reset this value if the
21884 left_is_explicit is false, which gives the original semantics to
21887 * literal.cs (NullPointer): new class used to represent a null
21888 literal in a pointer context.
21890 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21891 type is a pointer, use a NullPointer object instead of a
21892 NullLiteral. Closes 43687
21894 (ExplicitConversion): Convert pointer values using
21895 the conv opcode to the proper type.
21897 * ecore.cs (New): change ValueTypeVariable property into a method,
21898 that returns whether the valuetype is suitable for being used.
21900 * expression.cs (Binary.DoNumericPromotions): Only return if we
21901 the int constant was a valid uint, and we can return both left and
21902 right as uints. If not, we continue processing, to trigger the
21903 type conversion. This fixes 39018.
21905 * statement.cs (Block.EmitMeta): During constant resolution, set
21906 the CurrentBlock property on the emitcontext, so that we resolve
21907 constants propertly.
21909 2003-07-02 Martin Baulig <martin@ximian.com>
21911 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21912 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21914 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21915 than emitting it here.
21917 * statement.cs: Fixed some more flow analysis bugs.
21919 2003-07-02 Martin Baulig <martin@ximian.com>
21921 * class.cs (MethodData.Define): When implementing interface
21922 methods, set Final unless we're Virtual.
21924 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21925 check work for interface methods.
21927 2003-07-01 Martin Baulig <martin@ximian.com>
21929 * ecore.cs (EmitContext.This): Replaced this property with a
21930 GetThis() method which takes a Location argument. This ensures
21931 that we get the correct error location for a CS0188.
21933 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21935 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21936 ImplicitStandardConversion.
21938 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21940 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21942 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21945 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21947 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21950 (MethodData.Define): Turn off initlocals for unsafe methods.
21952 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21954 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21955 complete; Fixes #37521.
21957 * delegate.cs: Use Modifiers.TypeAttr to compute the
21958 TypeAttributes, instead of rolling our own. This makes the flags
21959 correct for the delegates.
21961 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21963 * class.cs (Constructor.Define): Set the private flag for static
21964 constructors as well.
21966 * cs-parser.jay (statement_expression): Set the return value to
21967 null, to avoid a crash when we catch an error.
21969 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21971 * cs-parser.jay: Applied patch from Jackson that adds support for
21972 extern and unsafe modifiers to destructor declarations.
21974 * expression.cs: Report error 21 if the user is trying to index a
21977 * driver.cs: Add an error message, suggested by the bug report.
21979 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21980 if we do not have a ": this ()" constructor initializer. Fixes 45149
21982 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21984 * namespace.cs: Add some information to reduce FAQs.
21986 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21988 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21989 underlying enumeration types. Fixes #43915.
21991 * expression.cs: Treat ushort/short as legal values to be used in
21992 bitwise operations.
21994 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21996 * delegate.cs: transfer custom attributes for paramenters from
21997 the delegate declaration to Invoke and BeginInvoke.
21999 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
22001 * attribute.cs: handle custom marshalers and emit marshal info
22004 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
22006 * makefile.gnu: Added anonymous.cs to the compiler sources.
22008 2003-05-28 Miguel de Icaza <miguel@ximian.com>
22010 * iterators.cs: Change the name of the proxy class to include two
22013 * cs-parser.jay: Update grammar to include anonymous methods.
22015 * anonymous.cs: new file.
22017 2003-05-27 Miguel de Icaza <miguel@ximian.com>
22019 * class.cs (Field.Define): Add missing test for pointers and
22022 2003-05-27 Ravi Pratap <ravi@ximian.com>
22024 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
22025 we use the stobj opcode.
22027 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
22028 since it wasn't the correct fix.
22030 It still is puzzling that we are required to use stobj for IntPtr
22031 which seems to be a ValueType.
22033 2003-05-26 Miguel de Icaza <miguel@ximian.com>
22035 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
22036 during regular simple name resolution. Now, the trick is that
22037 instead of returning for processing the simplename, we do a
22038 TypeManager.LookupType (ie, a rooted lookup as opposed to a
22039 contextual lookup type). If a match is found, return that, if
22040 not, return for further composition.
22042 This fixes long-standing 30485.
22044 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
22045 using the address to initialize an object, do an Stobj instead of
22046 using the regular Stelem.
22048 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
22049 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
22050 Because if we are a BaseIndexerAccess that value will be true.
22053 * statement.cs (GotoCase.Resolve): Return after reporting an
22054 error, do not attempt to continue.
22056 * expression.cs (PointerArithmetic.Emit): If our operand is a
22057 long, convert our constants to match the operand before
22058 multiplying. Convert to I type before adding. Fixes 43670.
22060 2003-05-14 Ravi Pratap <ravi@ximian.com>
22062 * enum.cs (ImplicitConversionExists) : Rename to
22063 ImplicitEnumConversionExists to remove ambiguity.
22065 * ecore.cs (NullCast): New type of cast expression class which
22066 basically is very similar to EmptyCast with the difference being
22067 it still is a constant since it is used only to cast a null to
22069 (eg. (string) null)
22071 * convert.cs (ImplicitReferenceConversion): When casting a null
22072 literal, we return a NullCast.
22074 * literal.cs (NullLiteralTyped): Remove - I don't see why this
22075 should be around anymore.
22077 The renaming (reported was slightly wrong). Corrections:
22079 ConvertImplicitStandard -> ImplicitConversionStandard
22080 ConvertExplicitStandard -> ExplicitConversionStandard
22082 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
22083 before passing them in !
22085 * convert.cs (ImplicitConversionStandard): When comparing for
22086 equal expr and target types, ensure that expr is not a
22089 In general, we must not be checking (expr_type ==
22090 target_type) in the top level conversion methods
22091 (ImplicitConversion, ExplicitConversion etc). This checking is
22092 done in the methods that they delegate to.
22094 2003-05-20 Miguel de Icaza <miguel@ximian.com>
22096 * convert.cs: Move Error_CannotConvertType,
22097 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
22098 ImplicitNumericConversion, ImplicitConversionExists,
22099 ImplicitUserConversionExists, StandardConversionExists,
22100 FindMostEncompassedType, FindMostSpecificSource,
22101 FindMostSpecificTarget, ImplicitUserConversion,
22102 ExplicitUserConversion, GetConversionOperators,
22103 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
22104 TryImplicitIntConversion, Error_CannotConvertImplicit,
22105 ConvertImplicitRequired, ConvertNumericExplicit,
22106 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
22107 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
22110 Perform the following renames:
22112 StandardConversionExists -> ImplicitStandardConversionExists
22113 ConvertImplicit -> ImplicitConversion
22114 ConvertImplicitStandard -> ImplicitStandardConversion
22115 TryImplicitIntConversion -> ImplicitIntConversion
22116 ConvertImplicitRequired -> ImplicitConversionRequired
22117 ConvertNumericExplicit -> ExplicitNumericConversion
22118 ConvertReferenceExplicit -> ExplicitReferenceConversion
22119 ConvertExplicit -> ExplicitConversion
22120 ConvertExplicitStandard -> ExplicitStandardConversion
22122 2003-05-19 Martin Baulig <martin@ximian.com>
22124 * statement.cs (TypeInfo.StructInfo): Made this type protected.
22125 (TypeInfo): Added support for structs having structs as fields.
22127 * ecore.cs (FieldExpr): Implement IVariable.
22128 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
22129 VariableInfo for the field.
22131 2003-05-18 Martin Baulig <martin@ximian.com>
22133 * expression.cs (This.DoResolve): Report a CS0027 if we're
22134 emitting a field initializer.
22136 2003-05-18 Martin Baulig <martin@ximian.com>
22138 * expression.cs (This.ResolveBase): New public function.
22139 (This.DoResolve): Check for CS0188.
22141 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
22144 * ecore.cs (MethodGroupExpr.DoResolve): Set the
22145 `instance_expression' to null if we don't have any non-static
22148 2003-05-18 Martin Baulig <martin@ximian.com>
22150 Reworked the way how local variables and parameters are handled by
22151 the flow analysis code.
22153 * statement.cs (TypeInfo, VariableMap): New public classes.
22154 (VariableInfo): New public class. This is now responsible for
22155 checking whether a variable has been assigned. It is used for
22156 parameters and local variables.
22157 (Block.EmitMeta): Take the InternalParameters as argument; compute
22158 the layout of the flow vectors here.
22159 (Block.LocalMap, Block.ParameterMap): New public properties.
22160 (FlowBranching): The .ctor doesn't get the InternalParameters
22161 anymore since Block.EmitMeta() now computes the layout of the flow
22163 (MyStructInfo): This class is now known as `StructInfo' and nested
22164 in `TypeInfo'; we don't access this directly anymore.
22166 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
22167 property and removed IsAssigned(), IsFieldAssigned(),
22168 SetAssigned() and SetFieldAssigned(); we now call them on the
22169 VariableInfo so we don't need to duplicate this code everywhere.
22171 * expression.cs (ParameterReference): Added `Block block' argument
22173 (LocalVariableReference, ParameterReference, This): The new
22174 VariableInfo class is now responsible for all the definite
22177 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
22178 IsParameterAssigned, SetParameterAssigned): Removed.
22180 2003-05-18 Martin Baulig <martin@ximian.com>
22182 * typemanager.cs (InitCoreTypes): Try calling
22183 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
22184 the 3-args-version. Corlib now also needs our `void_type'.
22185 (GetMethod): Added overloaded version which takes an optional
22186 `bool report_errors' to allow lookups of optional methods.
22188 2003-05-12 Martin Baulig <martin@ximian.com>
22190 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
22191 only used for locals and not for parameters.
22193 2003-05-12 Miguel de Icaza <miguel@ximian.com>
22195 * support.cs (InternalParameters.ParameterType): Return the
22196 ExternalType of the parameter.
22198 * parameter.cs (Parameter.ExternalType): drop the two arguments,
22201 2003-05-11 Miguel de Icaza <miguel@ximian.com>
22203 * class.cs (MethodData.Define): Do not set the `newslot' on
22204 interface members, if they are also flagged as "override".
22206 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
22207 better code for ++i and i++. This only works for static fields
22208 and local variables.
22210 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
22211 want to pull the DeclSpace out of the builder_to_declspace instead
22212 of the TypeBuilder (like in TypeContainer.FindMembers).
22214 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
22215 instead of LookupTypeContainer. Fixes the crash on .NET for
22216 looking up interface members.
22218 * const.cs: Create our own emit context during the Definition
22219 stage, so that constants are evaluated in the proper context, when
22220 a recursive definition happens.
22222 2003-05-11 Martin Baulig <martin@ximian.com>
22224 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
22225 new block for a switch section.
22226 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
22227 the adding/lookup in the switch block. Fixes #39828.
22229 2003-05-09 Miguel de Icaza <miguel@ximian.com>
22231 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
22232 functionality: I needed to convert the data after I had performed
22233 the add/sub operation into the operands type size.
22235 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
22236 pass the type for the box operation, otherwise the resulting
22237 object would have been of type object.
22239 (BoxedCast): Add constructor to specify the type to box as.
22241 2003-05-07 Miguel de Icaza <miguel@ximian.com>
22243 * iterators.cs: I was reusing the `count' variable inadvertently,
22244 take steps to not allow this to happen.
22246 2003-05-06 Miguel de Icaza <miguel@ximian.com>
22248 * attribute.cs (Attribute.Resolve): Params attributes are encoded
22249 by creating an array at the point where the params starts and
22250 putting all those arguments there, then adjusting the size of the
22253 2003-05-05 Miguel de Icaza <miguel@ximian.com>
22255 * expression.cs (New.AddressOf): Implement interface
22256 IMemoryLocation. This is used when the `new' operator is used in
22257 the context of an invocation to a method on a value type.
22259 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
22262 * namespace.cs: Also check the using aliases here.
22264 * driver.cs: Move the test for using validity after the types have
22265 been entered, so we do a single pass that also includes the using
22268 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
22269 in the regular case. CreateSiblingForFinally is doing extra
22272 * attribute.cs (GetAttributeArgumentExpression): Store the result
22273 on an out value, and use the return value to indicate failure
22274 instead of using null (which is a valid return for Constant.GetValue).
22276 * statement.cs: Perform the analysis flow for the increment
22277 portion after the statement, because this will be the real flow of
22278 execution. Fixes #42385
22280 * codegen.cs (EmitContext.EmitArgument,
22281 EmitContext.EmitStoreArgument): New helper functions when the
22282 RemapToProxy flag is set.
22284 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
22287 Add support for remapping parameters.
22289 * iterators.cs: Propagate parameter values; Store parameter
22290 values in the proxy classes.
22292 2003-05-04 Miguel de Icaza <miguel@ximian.com>
22294 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
22295 need a proxy reference; I do not know what I was thinking
22297 * cs-parser.jay (constructor_initializer): catch another error,
22298 and display nice message.
22300 (field_declaration): catch void field declaration
22301 to flag a better error.
22303 * class.cs (MemberBase.CheckBase): Report an error instead of a
22304 warning if a new protected member is declared in a struct.
22305 (Field.Define): catch the error of readonly/volatile.
22307 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
22309 (FieldExpr.AddressOf): ditto. Catch error where the address of a
22310 volatile variable is taken
22312 2003-05-02 Miguel de Icaza <miguel@ximian.com>
22314 * statement.cs (Fixed.Resolve): Report an error if we are not in
22317 2003-05-01 Miguel de Icaza <miguel@ximian.com>
22319 * typemanager.cs: reuse the code that handles type clashes for
22320 delegates and enumerations.
22322 * class.cs (Report28): Always report.
22324 * expression.cs (EncodeAsAttribute): Allow nulls here.
22326 2003-04-28 Miguel de Icaza <miguel@ximian.com>
22328 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
22329 the functionality for testing whether an expression is valid for
22330 an attribute here. Also handle the case of arrays of elements
22333 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
22334 encoding a linear array into an array of objects that are suitable
22335 to be passed to an CustomAttributeBuilder.
22337 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
22339 * ecore.cs: (FieldExpr): Handle field remapping here.
22341 * iteratators.cs: Pass the instance variable (if the method is an
22342 instance method) to the constructors, so we can access the field
22343 variables on the class.
22345 TODO: Test this with structs. I think the THIS variable on
22346 structs might have to be a pointer, and not a refenrece
22348 2003-04-27 Miguel de Icaza <miguel@ximian.com>
22350 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
22351 local variables to fields in a proxy class.
22353 * iterators.cs (PopulateProxy): Rename our internal fields to
22355 Create a <THIS> field if we are an instance method, so we can
22356 reference our parent container variables.
22357 (MapVariable): Called back from the EmitContext code to enter a
22358 new variable to field mapping into the proxy class (we just create
22362 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
22363 for using the remapped locals to fields.
22365 I placed the code here, because that gives the same semantics to
22366 local variables, and only changes the Emit code.
22368 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22369 statements inside iterators.
22370 (VariableInfo): Add a FieldBuilder for the cases when we are
22371 remapping local variables to fields in a proxy class
22373 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22374 current_block != null.
22376 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22377 not cope with strings, as it has been moved to the
22378 TableSwitchEmit. Fixed bug in switch generation.
22380 * expression.cs (New.DoResolve): Provide more context for the user
22381 when reporting an error.
22383 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22386 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22387 check the permissions for it. Note than in a type-resolution
22388 context the check was already present in DeclSpace.ResolveType,
22389 but was missing from the MemberAccess.
22391 (ArrayCreation.CheckIndices): warn if the user has
22392 more nested levels of expressions, but there are no more
22393 dimensions specified. Avoids crash on bug 41906.
22395 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22397 * statement.cs (Block): replace Implicit bool, for a generic
22399 New flag: `Unchecked'. This is used during the EmitMeta phase
22400 (which is out-of-line with the regular Resolve/Emit process for a
22401 statement, as this is done ahead of time, but still gets a chance
22402 to call constant resolve).
22404 (Block.Flags): new enum for adding a new flag.
22406 (Block.EmitMeta): track the state of unchecked.
22408 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22409 to enable constant resolution to work there as well.
22411 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22413 * typemanager.cs (ienumerable_type): Also look up
22414 System.Collections.IEnumerable.
22416 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22418 TODO: Test more than one conditional per method.
22420 * class.cs (Indexer.Define): Report the location where the user is
22421 referencing the unsupported feature.
22423 (MethodData): Overload the use of `conditionals' to
22424 minimize the creation of needless ArrayLists. This saves roughly
22425 212kb on my machine.
22427 (Method): Implement the new IIteratorContainer interface.
22428 (Method.SetYields): Implement the method by setting the ModFlags
22429 to contain METHOD_YIELDS.
22431 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22432 which just got set to null.
22434 * iterators.cs: New file.
22436 (Yield, YieldBreak): New statements.
22438 * statement.cs (Return.Resolve): Flag an error if we are used in
22439 an iterator method.
22441 * codegen.cs (InIterator): New flag set if the code is being
22442 compiled in an iterator method.
22444 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22445 internal modifier, and we just use it to avoid adding extra
22446 fields, as this is seldom used.
22448 * cs-parser.jay: Add yield_statement (yield and yield break).
22450 * driver.cs: New flag -v2 to turn on version 2 features.
22452 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22453 hashtable when v2 is enabled.
22455 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22457 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22458 there is already a namespace defined with this name.
22460 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22461 people upgraded their corlibs.
22463 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22464 always use fully qualified types, no need to use the compiler
22467 (TypeManager.IsNamespace): Use binarysearch.
22469 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22470 AddDelegate): I did not quite use the new IsValid API properly: I
22471 have to pass the short-name and the fullname. I was passing only
22472 the basename instead of the fullname sometimes.
22474 (TypeContainer.DefineType): call NamespaceClash.
22476 * interface.cs (Interface.DefineType): use NamespaceClash before
22479 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22482 * enum.cs: (Enum.DefineType): use NamespaceClash before
22485 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22486 speed increase. First, use the negative_hits cache when we get a
22487 negative. Second, add the type with its full original name
22488 instead of the new . and + encoded name (reflection uses + to
22489 separate type from a nested type). Use LookupTypeReflection
22490 directly which bypasses the type->name hashtable (that we already
22491 know does not contain the type.
22493 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22494 location/container type.
22496 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22498 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22500 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22502 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22503 method is being referenced in the method group from a static
22504 context, and report error 120 if so.
22506 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22509 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22510 is created, we create the A namespace).
22512 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22515 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22517 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22518 invocation to ModuleBuilder.GetType with the same values will
22519 return a new type instance, so we need to cache its return
22522 * expression.cs (Binary.ResolveOperator): Only allow the compare
22523 operators on enums if they are of the same type.
22525 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22526 types of ValueType on their own case. Before we were giving them
22527 the same treatment as objects.
22529 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22530 fullname. Short name is used to compare against container name.
22531 Fullname is used to check against defined namespace names.
22533 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22534 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22536 (Method.CheckBase): Call parent.
22537 (MemberBase.CheckBase): Check for protected members on sealed
22539 (PropertyBase.CheckBase): Call parent.
22540 (Field.Define): Call parent.
22542 * report.cs: Negative error codes are now mapped to 8000 - code,
22543 so that the display is render more nicely.
22545 * typemanager.cs: Do not use try/catch, instead report a regular
22548 (GetPointerType, GetReferenceType): These methods provide
22549 mechanisms to obtain the T* and T& from a T. We had the code
22550 previously scattered around the code base, and it also used
22551 TypeManager.LookupType that would go through plenty of caches.
22552 This one goes directly to the type source.
22554 In some places we did the Type.GetType followed by
22555 ModuleBuilder.GetType, but not in others, so this unifies the
22556 processing as well.
22558 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22559 statements now that we have namespace information.
22561 * typemanager.cs (IsNamespace): New method, returns whether the
22562 string presented is a namespace or not.
22564 (ComputeNamespaces): New public entry point, computes the list of
22565 available namespaces, using the GetNamespaces API call in Mono, or
22566 the slower version in MS.NET.
22568 Now before we start the semantic analysis phase, we have a
22569 complete list of namespaces including everything that the user has
22572 Deleted old code to cache namespaces in .nsc files.
22574 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22576 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22577 class/struct location definition Location for the implicit
22578 constructor location.
22580 (Operator.Define): Use the location of the operator for the
22581 implicit Method definition.
22583 (Constructor.Emit): use the constructor location for the implicit
22584 base initializer constructor.
22586 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22587 and the Expression class now contains two new methods:
22589 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22590 isolate type lookup from the rest of the resolution process.
22592 Since we use Expressions to hold type definitions due to the way
22593 we parse the input we have historically overloaded Resolve to
22594 perform the Type lookups if a special flag is passed. Now this is
22595 eliminated and two methods take their place.
22597 The differences in the two methods between xStep and xTerminal is
22598 that xStep is involved in our current lookup system that uses
22599 SimpleNames to compose a name, while xTerminal is used just to
22600 catch the case where the simplename lookup failed.
22602 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22604 * expression.cs (ResolveMemberAccess): Remove redundant code.
22605 TypeExpr expressions are always born fully resolved.
22607 * interface.cs (PopulateMethod): Do not lookup the types twice.
22608 We were doing it once during SemanticAnalysis and once during
22611 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22612 in local variable type definitions, were being returned as a
22613 SimpleName (we decomposed everything into a string), that is
22614 because primary_expression was being used instead of a type in the
22615 grammar (reduce/reduce conflicts).
22617 The part that was wrong is that we converted the expression into a
22618 string (an oversimplification in one hand, compounded with primary
22619 expressions doing string concatenation).
22625 Would return "A.B.C[]" as a SimpleName. This stopped things like
22626 using clauses from working on this particular context. And a type
22627 was being matched directly against "A.B.C[]".
22629 We now use the correct approach, and allow for ComposedCast to be
22630 part of the unary expression. So the "A.B.C []" become a composed
22631 cast of "A.B.C" (as a nested group of MemberAccess with a
22632 SimpleName at the end) plus the rank composition "[]".
22636 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22638 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22639 for the access level checking.
22641 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22642 `TypeContainer container', because I kept getting confused when I
22643 was debugging this code.
22645 * expression.cs (Indexers): Instead of tracking getters/setters,
22646 we now track them in parallel. We create one arraylist less, but
22647 most importantly it is possible now for the LValue code to find a
22648 matching get for a set.
22650 (IndexerAccess.DoResolveLValue): Update the code.
22651 GetIndexersForType has been modified already to extract all the
22652 indexers from a type. The code assumed it did not.
22654 Also make the code set the correct return type for the indexer.
22655 This was fixed a long time ago for properties, but was missing for
22656 indexers. It used to be void_type.
22658 (Binary.Emit): Test first for doubles instead of
22659 floats, as they are more common.
22661 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22662 when dealing with floats and the <=, >= operators. This fixes bug
22665 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22666 to load the array value by emitting a load on the foreach variable
22667 type. This was incorrect.
22669 We now emit the code to load an element using the the array
22670 variable type, and then we emit the conversion operator.
22674 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22676 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22678 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22680 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22681 test for protection before we test for signatures.
22683 (MethodSignature.ToString): implement.
22685 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22686 to the case where we reduced into a LongConstant.
22688 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22689 depend on whether the information is acurrate, because the
22690 Microsoft runtime will always claim that the array type is public,
22691 regardless of the real state.
22693 If the type is a pointer, another problem happens: the type is
22694 reported as non-public in Microsoft.
22696 In both cases we have to call CheckAccessLevel recursively with
22697 the underlying type as the argument to be tested.
22699 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22701 * assign.cs (Assign.Emit): If we are dealing with a compound
22702 assignment expression, we should use the code path that stores the
22703 intermediate result in a temporary value. This fixes #40903.
22705 *expression.cs (Indirection.ToString): Provide ToString method for
22708 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22710 * class.cs: Null out fields holding references to Block objects so
22711 they can be garbage collected.
22713 * expression.cs (OverloadResolve): Remove unused local.
22715 2003-04-07 Martin Baulig <martin@ximian.com>
22717 * codegen.cs (EmitContext.CurrentFile): New public field.
22718 (EmitContext.Mark): Use the CurrentFile to check whether the
22719 location is in the correct file.
22720 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22722 2003-04-07 Martin Baulig <martin@ximian.com>
22724 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22726 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22727 location. [FIXME: The location argument which gets passed to this
22728 method is sometimes wrong!]
22730 2003-04-07 Nick Drochak <ndrochak@gol.com>
22732 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22734 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22736 * expression.cs (Indirection.EmitAssign): We were using the
22737 temporary, but returning immediately instead of continuing the
22740 2003-04-06 Martin Baulig <martin@ximian.com>
22742 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22743 if it's a nested child, but also deriving from the outer class.
22746 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22747 nested child, but also deriving from the outer class. See
22749 (FilterWithClosure): We may access private members of the outer
22750 class if we're a nested child and deriving from the outer class.
22751 (RealMemberLookup): Only set `closure_private_ok' if the
22752 `original_bf' contained BindingFlags.NonPublic.
22754 2003-04-05 Martin Baulig <martin@ximian.com>
22756 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22758 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22760 * class.cs (Event.Define): Do not allow abstract events to have
22763 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22765 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22766 block in event declarations.
22768 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22769 value type, get its address.
22771 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22772 leaving a class on the stack instead of a boolean value (int
22773 0/1). Change the code so we compare against null, and then the
22774 result against zero.
22776 * class.cs (TypeContainer.GetClassBases): We were checking for the
22777 parent class being sealed too late.
22779 * expression.cs (Binary.Emit): For <= and >= when dealing with
22780 floating point values, use cgt.un and clt.un instead of cgt and
22783 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22785 * statement.cs: Apply the same optimization as MS: skip the
22786 GetEnumerator returning an IEnumerator, and use the one returning a
22787 CharEnumerator instead. This allows us to avoid the try-finally block
22790 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22792 * cs-parser.jay: Attributes cannot be applied to
22793 namespaces. Fixes #40473
22795 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22798 (Add*): check if the name is valid using the full name for constants,
22799 fields, properties and events.
22801 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22803 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22804 char constants to be part of the enumeration.
22806 * expression.cs (Conditional.DoResolve): Add support for operator
22807 true. Implements the missing functionality from 14.12
22809 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22810 operator true/false as required by the spec.
22812 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22813 implicit conversion to boolean.
22815 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22816 also one where the type implements `operator true'.
22818 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22819 get an expression that will invoke operator true based on an
22822 (GetConversionOperators): Removed the hack that called op_True
22825 (Expression.ResolveBoolean): Move this from Statement.
22827 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22829 * ecore.cs (FieldExpr): do not allow initialization of initonly
22830 fields on derived classes
22832 2003-03-13 Martin Baulig <martin@ximian.com>
22834 * statement.cs (Block.Emit): Call ig.BeginScope() and
22835 ig.EndScope() when compiling with debugging info; call
22836 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22838 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22840 * expression.cs (Indexers): Do not construct immediately, allow
22841 for new members to be appended as we go. Fixes 38143
22843 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22845 * expression.cs: save/restore context when resolving an unchecked
22848 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22850 * cfold.cs: Catch division by zero in modulus operator during
22853 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22855 * interface.cs (Interface.DefineMembers): Avoid defining members
22858 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22860 * driver.cs: handle the +/- options for -noconfig
22862 * statement.cs (Unckeched.Resolve): Also track the state of
22863 unchecked in the Resolve phase.
22865 2003-02-27 Martin Baulig <martin@ximian.com>
22867 * ecore.cs (Expression.MemberLookup): Don't create a
22868 MethodGroupExpr for something which is not a method. Fixes #38291.
22870 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22872 * class.cs (MemberBase.CheckParameters): Also check that the type
22873 is unmanaged if it is a pointer.
22875 * expression.cs (SizeOf.Resolve): Add location information.
22877 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22878 a managed type is declared.
22880 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22881 parameter modifiers as well. Fixes bug 38606
22883 * class.cs: Very sad. Am backing out the speed up changes
22884 introduced by the ArrayList -> Array in the TypeContainer, as they
22885 were not actually that much faster, and introduced a bug (no error
22886 reports on duplicated methods).
22888 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22889 source first, this will guarantee that we have a valid expression
22890 before calling in lower levels functions that will require a
22891 resolved object. Then use this original_source in the
22892 target.ResolveLValue instead of the original source that was
22895 Another change. Use target.Resolve instead of LValueResolve.
22896 Although we are resolving for LValues, we will let the Assign code
22897 take care of that (it will be called again from Resolve). This
22898 basically allows code like this:
22900 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22901 class Y { void A (X x) { x [0] += o; }
22903 The problem was that the indexer was trying to resolve for
22904 set_Item (idx, object o) and never finding one. The real set_Item
22905 was set_Item (idx, X). By delaying the process we get the right
22910 2003-02-23 Martin Baulig <martin@ximian.com>
22912 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22913 while calling DoEmit ().
22915 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22916 source files; if you use the #line directive inside a method, the
22917 compiler stops emitting line numbers for the debugger until it
22918 reaches the end of the method or another #line directive which
22919 restores the original file.
22921 2003-02-23 Martin Baulig <martin@ximian.com>
22923 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22925 2003-02-23 Martin Baulig <martin@ximian.com>
22927 * statement.cs (Block.AddChildVariableNames): We need to call this
22928 recursively, not just for our immediate children.
22930 2003-02-23 Martin Baulig <martin@ximian.com>
22932 * class.cs (Event.Define): Always make the field private, like csc does.
22934 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22935 actually work, fixes bug #37521.
22937 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22939 * delegate.cs: When creating the various temporary "Parameters"
22940 classes, make sure that we call the ComputeAndDefineParameterTypes
22941 on those new parameters (just like we do with the formal ones), to
22942 allow them to be resolved in the context of the DeclSpace.
22944 This fixes the bug that Dick observed in Bugzilla #38530.
22946 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22948 * expression.cs (ResolveMemberAccess): When resolving a constant,
22949 do not attempt to pull a constant if the value was not able to
22950 generate a valid constant.
22952 * const.cs (LookupConstantValue): Do not report more errors than required.
22954 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22956 * expression.cs: fixes bug #38328.
22958 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22960 * class.cs: Changed all the various members that can be part of a
22961 class from being an ArrayList to be an Array of the right type.
22962 During the DefineType type_list, interface_list, delegate_list and
22963 enum_list are turned into types, interfaces, delegates and enums
22966 And during the member population, indexer_list, event_list,
22967 constant_list, field_list, instance_constructor_list, method_list,
22968 operator_list and property_list are turned into their real arrays.
22970 Although we could probably perform this operation earlier, for
22971 good error reporting we need to keep the lists and remove the
22972 lists for longer than required.
22974 This optimization was triggered by Paolo profiling the compiler
22975 speed on the output of `gen-sample-program.pl' perl script.
22977 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22978 not crash in methods like MemberLookupFailed that use this field.
22980 This problem arises when the compiler fails to resolve a type
22981 during interface type definition for example.
22983 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22985 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22986 inherit from System.Object, so we have to stop at null, not only
22987 when reaching System.Object.
22989 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22991 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22992 DeclaredOnly because the parent indexer might have had a different
22993 name, but did not loop until the top of the hierarchy was reached.
22995 The problem this one fixes is 35492: when a class implemented an
22996 indexer from an interface, we were getting the interface method
22997 (which was abstract) and we were flagging an error (can not invoke
23000 This also keeps bug 33089 functioning, and test-148 functioning.
23002 * typemanager.cs (IsSpecialMethod): The correct way of figuring
23003 out if a method is special is to see if it is declared in a
23004 property or event, or whether it is one of the predefined operator
23005 names. This should fix correctly #36804.
23007 2003-02-15 Miguel de Icaza <miguel@ximian.com>
23009 The goal here is to remove the dependency on EmptyCast.Peel ().
23010 Killing it completely.
23012 The problem is that currently in a number of places where
23013 constants are expected, we have to "probe" for an EmptyCast, and
23014 Peel, which is not the correct thing to do, as this will be
23015 repetitive and will likely lead to errors.
23017 The idea is to remove any EmptyCasts that are used in casts that
23018 can be reduced to constants, so we only have to cope with
23021 This bug hunt was triggered by Bug 37363 and the desire to remove
23022 the duplicate pattern where we were "peeling" emptycasts to check
23023 whether they were constants. Now constants will always be
23026 * ecore.cs: Use an enumconstant here instead of wrapping with
23029 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
23030 throwing me off. By handling this we can get rid of a few hacks.
23032 * statement.cs (Switch): Removed Peel() code.
23034 2003-02-14 Miguel de Icaza <miguel@ximian.com>
23036 * class.cs: Location information for error 508
23038 * expression.cs (New.DoResolve): Add a guard against double
23039 resolution of an expression.
23041 The New DoResolve might be called twice when initializing field
23042 expressions (see EmitFieldInitializers, the call to
23043 GetInitializerExpression will perform a resolve on the expression,
23044 and later the assign will trigger another resolution
23046 This leads to bugs (#37014)
23048 * delegate.cs: The signature for EndInvoke should contain any ref
23049 or out parameters as well. We were not doing this in the past.
23051 * class.cs (Field.Define): Do not overwrite the type definition
23052 inside the `volatile' group. Turns out that volatile enumerations
23053 were changing the type here to perform a validity test, which
23056 2003-02-12 Miguel de Icaza <miguel@ximian.com>
23058 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
23059 and structs, we do not want to load the instance variable
23061 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
23062 enum_type has to be handled like an object reference (implicit
23063 conversions exists from this to object), but the regular IsClass
23064 and IsValueType tests will never return true for this one.
23066 Also we use TypeManager.IsValueType instead of type.IsValueType,
23067 just for consistency with the rest of the code (this is only
23068 needed if we ever use the construct exposed by test-180.cs inside
23069 corlib, which we dont today).
23071 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
23073 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
23076 2003-02-09 Martin Baulig <martin@ximian.com>
23078 * namespace.cs (Namespace..ctor): Added SourceFile argument.
23079 (Namespace.DefineNamespaces): New static public method; this is
23080 called when we're compiling with debugging to add all namespaces
23081 to the symbol file.
23083 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
23084 pass it to the Namespace's .ctor.
23086 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
23087 and MethodBase arguments; pass the namespace ID to the symwriter;
23088 pass the MethodBase instead of the token to the symwriter.
23089 (SymbolWriter.DefineNamespace): New method to add a namespace to
23092 2003-02-09 Martin Baulig <martin@ximian.com>
23094 * symbolwriter.cs: New file. This is a wrapper around
23095 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
23096 methods here in near future.
23098 2003-02-09 Martin Baulig <martin@ximian.com>
23100 * codegen.cs (EmitContext.Mark): Just pass the arguments to
23101 ILGenerator.MarkSequencePoint() which are actually used by the
23104 2003-02-09 Martin Baulig <martin@ximian.com>
23106 * location.cs (SourceFile): New public sealed class. This
23107 contains the name and an index which is used in the location's token.
23108 (Location): Reserve an appropriate number of bits in the token for
23109 the source file instead of walking over that list, this gives us a
23110 really huge performance improvement when compiling with debugging.
23112 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
23113 `SourceFile' argument instead of a string.
23114 (Driver.ProcessFile): Add all the files via Location.AddFile(),
23115 but don't parse/tokenize here, we need to generate the list of all
23116 source files before we do that.
23117 (Driver.ProcessFiles): New static function. Parses/tokenizes all
23120 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
23121 instead of a string.
23123 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
23126 2003-02-09 Martin Baulig <martin@ximian.com>
23128 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
23129 filename on `#line default'.
23131 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
23133 * statement.cs: don't clear the pinned var when the fixed statement
23134 returns from the method (fixes bug#37752).
23136 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
23138 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
23141 2003-02-07 Martin Baulig <martin@ximian.com>
23143 * driver.cs: Removed the `--debug-args' command line argument.
23145 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
23146 automatically by the AsssemblyBuilder.
23147 (CodeGen.InitializeSymbolWriter): We don't need to call any
23148 initialization function on the symbol writer anymore. This method
23149 doesn't take any arguments.
23151 2003-02-03 Miguel de Icaza <miguel@ximian.com>
23153 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
23154 from referenced assemblies as well.
23156 2003-02-02 Martin Baulig <martin@ximian.com>
23158 * class.cs (MethodData.Emit): Generate debugging info for external methods.
23160 2003-02-02 Martin Baulig <martin@ximian.com>
23162 * class.cs (Constructor.Emit): Open the symbol writer before
23163 emitting the constructor initializer.
23164 (ConstructorInitializer.Emit): Call ec.Mark() to allow
23165 single-stepping through constructor initializers.
23167 2003-01-30 Miguel de Icaza <miguel@ximian.com>
23169 * class.cs: Handle error 549: do not allow virtual methods in
23172 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
23174 * decl.cs: Check access levels when resolving types
23176 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
23178 * statement.cs: Add parameters and locals set in catch blocks that might
23179 return to set vector
23181 2003-01-29 Miguel de Icaza <miguel@ximian.com>
23183 * class.cs (Operator): Set the SpecialName flags for operators.
23185 * expression.cs (Invocation.DoResolve): Only block calls to
23186 accessors and operators on SpecialName methods.
23188 (Cast.TryReduce): Handle conversions from char constants.
23191 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
23193 * statement.cs: small memory and time optimization in FlowBranching.
23195 2003-01-28 Pedro Mart <yoros@wanadoo.es>
23197 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
23198 problem that the last fix but in the other sid (Set).
23200 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
23201 access when there is no indexer in the hierarchy.
23203 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
23205 * class.cs: Combine some if statements.
23207 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23209 * driver.cs: fixed bug #37187.
23211 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
23213 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
23214 any indexer, it's needed to build a list with all the indexers in the
23215 hierarchy (AllGetters), else we have problems. Fixes #35653.
23217 2003-01-23 Miguel de Icaza <miguel@ximian.com>
23219 * class.cs (MethodData.Define): It is wrong for an interface
23220 implementation to be static in both cases: explicit and implicit.
23221 We were only handling this in one case.
23223 Improve the if situation there to not have negations.
23225 * class.cs (Field.Define): Turns out that we do not need to check
23226 the unsafe bit on field definition, only on usage. Remove the test.
23228 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23230 * driver.cs: use assembly.Location instead of Codebase (the latest
23231 patch made mcs fail when using MS assemblies).
23233 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
23235 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
23236 get the path to *corlib.dll.
23238 2003-01-21 Nick Drochak <ndrochak@gol.com>
23242 * typemanager.cs: Remove compiler warnings
23244 2003-01-20 Duncan Mak <duncan@ximian.com>
23246 * AssemblyInfo.cs: Bump the version number to 0.19.
23248 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23250 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
23252 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
23254 * class.cs (Constructor::Emit): Emit debugging info for constructors.
23256 2003-01-17 Miguel de Icaza <miguel@ximian.com>
23258 * cs-parser.jay: Small fix: we were not comparing the constructor
23259 name correctly. Thanks to Zoltan for the initial pointer.
23261 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
23263 * cs-tokenizer.cs: Set file name when specified with #line
23265 2003-01-15 Miguel de Icaza <miguel@ximian.com>
23267 * cs-parser.jay: Only perform the constructor checks here if we
23268 are named like the class; This will help provider a better
23269 error. The constructor path is taken when a type definition is
23270 not found, but most likely the user forgot to add the type, so
23271 report that rather than the constructor error.
23273 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
23275 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
23278 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23280 * cs-parser.jay: Add cleanup call.
23282 2003-01-13 Duncan Mak <duncan@ximian.com>
23284 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
23285 consistent with other methods.
23287 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
23289 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
23291 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
23293 * attribute.cs: only set GuidAttr to true when we have a
23296 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23300 * typemanager.cs: fixes to allow mcs compile corlib with the new
23301 Type.IsSubclassOf fix.
23303 2003-01-08 Miguel de Icaza <miguel@ximian.com>
23305 * expression.cs (LocalVariableReference.DoResolve): Classify a
23306 constant as a value, not as a variable. Also, set the type for
23309 * cs-parser.jay (fixed_statement): take a type instead of a
23310 pointer_type, so we can produce a better error message later.
23312 * statement.cs (Fixed.Resolve): Flag types that are not pointers
23315 (For.DoEmit): Make inifinite loops have a
23316 non-conditional branch back.
23318 (Fixed.DoEmit): First populate the pinned variables, then emit the
23319 statement, then clear the variables. Before I was emitting the
23320 code once for each fixed piece.
23323 2003-01-08 Martin Baulig <martin@ximian.com>
23325 * statement.cs (FlowBranching.MergeChild): A break in a
23326 SWITCH_SECTION does not leave a loop. Fixes #36155.
23328 2003-01-08 Martin Baulig <martin@ximian.com>
23330 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
23331 lives in the same number space than `param_map'. Fixes #36154.
23333 2003-01-07 Miguel de Icaza <miguel@ximian.com>
23335 * cs-parser.jay (constructor_declaration): Set the
23336 Constructor.ModFlags before probing for it. This makes the
23337 compiler report 514, 515 and 132 (the code was there, but got
23340 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
23341 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
23342 (GotoCase.Resolve): Set `Returns' to ALWAYS.
23344 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
23346 * enum.cs: create the enum static fields using the enum type.
23348 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
23350 * class.cs: don't try to create the ParamBuilder for the return
23351 type if it's not needed (and handle it breaking for the ms runtime
23354 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
23356 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
23358 2002-12-29 Miguel de Icaza <miguel@ximian.com>
23360 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
23361 the command. This showed up while compiling the JANET source
23362 code, which used \r as its only newline separator.
23364 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23366 * class.cs (Method.Define): If we are an operator (because it
23367 reuses our code), then set the SpecialName and HideBySig. #36128
23369 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23371 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23372 exception, report error 120 `object reference required'.
23374 * driver.cs: Add --pause option, used during to measure the size
23375 of the process as it goes with --timestamp.
23377 * expression.cs (Invocation.DoResolve): Do not allow methods with
23378 SpecialName to be invoked.
23380 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23382 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23383 number before adding it.
23385 2002-12-21 Ravi Pratap <ravi@ximian.com>
23387 * ecore.cs (StandardImplicitConversion): When in an unsafe
23388 context, we allow conversion between void * to any other pointer
23389 type. This fixes bug #35973.
23391 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23393 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23394 is not thrown when extensionless outputs are used
23396 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23398 * rootcontext.cs: fixed compilation of corlib.
23400 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23402 * attribute.cs (Attributes.Contains): Add new method.
23404 * class.cs (MethodCore.LabelParameters): if the parameter is an
23405 `out' parameter, check that no attribute `[In]' has been passed.
23407 * enum.cs: Handle the `value__' name in an enumeration.
23409 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23411 * decl.cs: Added special case to allow overrides on "protected
23414 2002-12-18 Ravi Pratap <ravi@ximian.com>
23416 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23417 since it makes much more sense.
23419 (Attributes.ctor): Don't require a Location parameter.
23421 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23423 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23424 since we already have that information per attribute.
23426 * everywhere : make appropriate changes.
23428 * class.cs (LabelParameters): Write the code which actually
23429 applies attributes to the return type. We can't do this on the MS
23430 .NET runtime so we flag a warning in the case an exception is
23433 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23435 * const.cs: Handle implicit null conversions here too.
23437 2002-12-17 Ravi Pratap <ravi@ximian.com>
23439 * class.cs (MethodCore.LabelParameters): Remove the extra
23440 Type [] parameter since it is completely unnecessary. Instead
23441 pass in the method's attributes so that we can extract
23442 the "return" attribute.
23444 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23446 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23447 of ignoring it and letting the compile continue.
23449 * typemanager.cs (ChangeType): use an extra argument to return an
23450 error condition instead of throwing an exception.
23452 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23454 * expression.cs (Unary.TryReduce): mimic the code for the regular
23455 code path. Perform an implicit cast in the cases where we can
23456 implicitly convert to one of the integral types, and then reduce
23457 based on that constant. This fixes bug #35483.
23459 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23461 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23463 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23465 * namespace.cs: fixed bug #35489.
23467 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23469 * class.cs: Remove some dead code.
23471 * cs-parser.jay: Estimate the number of methods needed
23472 (RootContext.MethodCount);
23474 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23475 numbers instead of StringBuilders.
23477 * support.cs (PtrHashtable): Add constructor with initial size;
23478 We can now reduce reallocations of the method table.
23480 2002-12-10 Ravi Pratap <ravi@ximian.com>
23482 * attribute.cs (ApplyAttributes): Keep track of the emitted
23483 attributes on a per-target basis. This fixes bug #35413.
23485 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23487 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23488 default to the Windows 1252 encoding.
23490 (UnixParseOption): Support version, thanks to Alp for the missing
23493 * AssemblyInfo.cs: Add nice assembly information.
23495 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23498 * cs-parser.jay: Allow a trailing comma before the close bracked
23499 in the attribute_section production.
23501 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23502 address of the instance was being taken, I will take this out,
23503 because we take the address of the object immediately here.
23505 2002-12-09 Ravi Pratap <ravi@ximian.com>
23507 * typemanager.cs (AreMultipleAllowed): Take care of the most
23508 obvious case where attribute type is not in the current assembly -
23511 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23513 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23514 definitions, instead of doing that afterwards.
23516 Also we use a nice little hack, depending on the constructor, we
23517 know if we are a "composed" name or a simple name. Hence, we
23518 avoid the IndexOf test, and we avoid
23520 * codegen.cs: Add code to assist in a bug reporter to track down
23521 the source of a compiler crash.
23523 2002-12-07 Ravi Pratap <ravi@ximian.com>
23525 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23526 types have been emitted for a given element and flag an error
23527 if something which does not have AllowMultiple set is used more
23530 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23531 attribute types and their corresponding AllowMultiple properties
23533 (AreMultipleAllowed): Check the property for a given type.
23535 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23536 property in the case we have a TypeContainer.
23538 (Attributes.AddAttribute): Detect duplicates and just skip on
23539 adding them. This trivial fix catches a pretty gross error in our
23540 attribute emission - global attributes were being emitted twice!
23542 Bugzilla bug #33187 is now fixed.
23544 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23546 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23547 instead of pp_and).
23549 * expression.cs (Binary.ResolveOperator): I can only use the
23550 Concat (string, string, string) and Concat (string, string,
23551 string, string) if the child is actually a concatenation of
23554 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23556 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23557 context where we need a 2-character lookahead.
23559 * pending.cs (PendingImplementation): Rework so we can keep track
23560 of interface types all the time, and flag those which were
23561 implemented by parents as optional.
23563 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23565 * expression.cs (Binary.ResolveOperator): Use
23566 String.Concat(string,string,string) or
23567 String.Concat(string,string,string,string) when possible.
23569 * typemanager: More helper methods.
23572 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23574 * pending.cs: remove the bogus return from GetMissingInterfaces()
23575 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23577 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23579 * namespace.cs: avoid duplicated 'using xxx' being added to
23580 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23581 when we get more than one 'using' statement for the same namespace.
23582 Report a CS0105 warning for it.
23584 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23586 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23587 of calling getChar/putback, uses internal knowledge of it.
23589 (xtoken): Reorder tokenizer so most common patterns are checked
23590 first. This reduces the compilation time in another 5% (from 8.11s
23591 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23593 The parsing time is 22% of the compilation in mcs, and from that
23594 64% is spent on the tokenization process.
23596 I tried using a binary search for keywords, but this is slower
23597 than the hashtable. Another option would be to do a couple of
23600 * Not use a StringBuilder, instead use an array of chars,
23601 with a set value. Notice that this way we could catch
23602 the 645 error without having to do it *afterwards*.
23604 * We could write a hand-parser to avoid the hashtable
23605 compares altogether.
23607 The identifier consumption process takes 37% of the tokenization
23608 time. Another 15% is spent on is_number. 56% of the time spent
23609 on is_number is spent on Int64.Parse:
23611 * We could probably choose based on the string length to
23612 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23615 Another 3% is spend on wrapping `xtoken' in the `token' function.
23617 Handle 0xa0 as whitespace (#34752)
23619 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23621 * typemanager.cs (IsCLRType): New routine to tell whether a type
23622 is one of the builtin types.
23624 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23625 typecode in more places instead of doing pointer comparissions.
23626 We could leverage some knowledge about the way the typecodes are
23629 New code to cache namespaces in assemblies, it is currently not
23630 invoked, to be used soon.
23632 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23634 * expression.cs (Binary.ResolveOperator): specially handle
23635 strings, and do not perform user-defined operator overloading for
23638 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23640 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23641 internalcall as it is a pretty simple operation; Avoid whenever
23642 possible to call Char.IsLetter.
23644 (consume_identifier): Cut by half the number of
23645 hashtable calls by merging the is_keyword and GetKeyword behavior.
23647 Do not short-circuit, because if we do, we
23648 report errors (ie, #if false && true would produce an invalid
23652 2002-11-24 Martin Baulig <martin@ximian.com>
23654 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23655 check constant ranges and report a CS0221. Fixes #33186.
23657 2002-11-24 Martin Baulig <martin@ximian.com>
23659 * cs-parser.jay: Make this work for uninitialized variable
23660 declarations in the `for' initializer. Fixes #32416.
23662 2002-11-24 Martin Baulig <martin@ximian.com>
23664 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23665 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23667 2002-11-24 Martin Baulig <martin@ximian.com>
23669 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23670 argument; if true, we also check for user-defined conversions.
23671 This is only needed if both arguments are of a user-defined type.
23672 Fixes #30443, added test-175.cs.
23673 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23675 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23677 2002-11-24 Martin Baulig <martin@ximian.com>
23679 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23680 function to get the store opcode.
23681 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23682 only emit the Ldelema if the store opcode is Stobj. You must run
23683 both test-34 and test-167 to test this. Fixes #34529.
23685 2002-11-23 Martin Baulig <martin@ximian.com>
23687 * ecore.cs (Expression.MemberLookup): Added additional
23688 `qualifier_type' argument which is used when we're being called
23689 from MemberAccess.DoResolve() and null if we're called from a
23691 (Expression.MemberLookupFailed): New method to report errors; this
23692 does the CS1540 check and reports the correct error message.
23694 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23695 argument for the CS1540 check and redone the way how we're dealing
23696 with private members. See the comment in the source code for details.
23697 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23698 `closure_start_type' to `closure_qualifier_type' and check whether
23699 it's not null. It was not this filter being broken, it was just
23700 being called with the wrong arguments.
23702 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23703 and pass it the correct `qualifier_type'; this also does the error
23706 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23708 * expression.cs (Invocation.EmitParams): If the we are dealing
23709 with a non-built-in value type, load its address as well.
23711 (ArrayCreation): Use a a pretty constant instead
23712 of the hardcoded value 2. Use 6 instead of 2 for the number of
23713 static initializers.
23715 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23716 because they are not really value types, just glorified integers.
23718 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23720 * ecore.cs: Remove redundant code for enumerations, make them use
23721 the same code path as everything else, fixes the casting issue
23722 with enumerations in Windows.Forms.
23724 * attribute.cs: Do only cast to string if it is a string, the
23725 validation happens later.
23727 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23728 people upgrade their corlibs.
23730 * ecore.cs: Oops, enumerations were not following the entire code path
23732 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23734 * typemanager.cs (FilterWithClosure): Commented out the test for
23735 1540 in typemanager.cs, as it has problems when accessing
23736 protected methods from a parent class (see test-174.cs).
23738 * attribute.cs (Attribute.ValidateGuid): new method.
23739 (Attribute.Resolve): Use above.
23741 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23743 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23745 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23746 handling for enumerations, as we only needed the TypeContainer
23747 functionality to begin with (this is required for the fix below to
23748 work for enums that reference constants in a container class for
23751 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23753 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23754 a valid TypeBuilder to perform lookups on.o
23756 * class.cs (InheritableMemberSignatureCompare): Use true in the
23757 call to GetGetMethod and GetSetMethod, because we are comparing
23758 the signature, and we need to get the methods *even* if they are
23761 (PropertyBase.CheckBase): ditto.
23763 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23764 GotoCase.Resolve): Use Peel on EmpytCasts.
23766 * ecore.cs (EmptyCast): drop child, add Peel method.
23768 2002-11-17 Martin Baulig <martin@ximian.com>
23770 * ecore.cs (EmptyCast.Child): New public property.
23772 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23773 label resolved to an EmptyCast. Fixes #34162.
23774 (GotoCase.Resolve): Likewise.
23775 (Block.EmitMeta): Likewise.
23777 2002-11-17 Martin Baulig <martin@ximian.com>
23779 * expression.cs (Invocation.BetterConversion): Prefer int over
23780 uint; short over ushort; long over ulong for integer literals.
23781 Use ImplicitConversionExists instead of StandardConversionExists
23782 since we also need to check for user-defined implicit conversions.
23783 Fixes #34165. Added test-173.cs.
23785 2002-11-16 Martin Baulig <martin@ximian.com>
23787 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23788 with the `true' and `false' literals. Fixes #33151.
23790 2002-11-16 Martin Baulig <martin@ximian.com>
23792 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23793 October 22nd; don't do the cs1540 check for static members.
23795 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23796 now using our own filter here and doing the cs1540 check again.
23798 2002-11-16 Martin Baulig <martin@ximian.com>
23800 * support.cs (InternalParameters): Don't crash if we don't have
23801 any fixed parameters. Fixes #33532.
23803 2002-11-16 Martin Baulig <martin@ximian.com>
23805 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23806 when looking up static methods to make this work on Windows.
23809 2002-11-16 Martin Baulig <martin@ximian.com>
23811 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23812 a setter rather than using PropertyInfo.CanWrite.
23814 2002-11-15 Nick Drochak <ndrochak@gol.com>
23816 * class.cs: Allow acces to block member by subclasses. Fixes build
23819 2002-11-14 Martin Baulig <martin@ximian.com>
23821 * class.cs (Constructor.Emit): Added the extern/block check.
23824 2002-11-14 Martin Baulig <martin@ximian.com>
23826 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23827 iteration while looking for indexers, this is needed because the
23828 indexer may have a different name in our base classes. Fixed the
23829 error reporting (no indexers at all, not get accessor, no
23830 overloaded match). Fixes bug #33089.
23831 (IndexerAccess.DoResolveLValue): Likewise.
23833 2002-11-14 Martin Baulig <martin@ximian.com>
23835 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23836 indexers. Fixes the first part of bug #33089.
23837 (MethodSignature.InheritableMemberSignatureCompare): Added support
23840 2002-11-13 Ravi Pratap <ravi@ximian.com>
23842 * attribute.cs (Attribute.Resolve): Catch the
23843 NullReferenceException and report it since it isn't supposed to
23846 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23848 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23849 LogicalOr and LogicalAnd that can benefit from recursively
23850 handling EmitBranchable. The code now should be nice for Paolo.
23852 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23854 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23855 the Type lookups, as we perform quite a number of lookups on
23856 non-Types. This can be removed once we can deterministically tell
23857 whether we have a type or a namespace in advance.
23859 But this might require special hacks from our corlib.
23863 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23864 and double which avoids a conversion from an integer to a double.
23866 * expression.cs: tiny optimization, avoid calling IsConstant,
23867 because it effectively performs the lookup twice.
23869 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23871 But a bogus return here to keep the semantics of the old code
23872 until the Mono runtime is fixed.
23874 * pending.cs (GetMissingInterfaces): New method used to remove all
23875 the interfaces that are already implemented by our parent
23876 classes from the list of pending methods.
23878 * interface.cs: Add checks for calls after ResolveTypeExpr.
23880 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23882 * class.cs (Class.Emit): Report warning 67: event not used if the
23883 warning level is beyond 3.
23885 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23886 being a NullLiteral.
23888 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23891 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23892 path that might fail if a type can not be resolved.
23894 * expression.cs (Binary.Emit): Emit unsigned versions of the
23897 * driver.cs: use error 5.
23899 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23901 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23903 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23905 * cs-parser.jay (switch_section): A beautiful patch from Martin
23906 Baulig that fixed 33094.
23908 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23910 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23911 Check whether the base is abstract and report an error if so.
23913 * expression.cs (IndexerAccess.DoResolveLValue,
23914 IndexerAccess.DoResolve): ditto.
23916 (Invocation.DoResolve): ditto.
23918 (Invocation.FullMethodDesc): Improve the report string.
23920 * statement.cs (Block): Eliminate IsVariableDefined as it is
23921 basically just a wrapper for GetVariableInfo.
23923 * ecore.cs (SimpleName): Use new
23925 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23926 type, as we return the actual parameter ref/unref state on a
23929 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23931 * support.cs: Return proper flags REF/OUT fixing the previous
23934 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23935 not used to mean `ref' but `ref or out' in ParameterReference
23937 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23938 full type signature instead of calling TypeManger.CSharpName
23941 * support.cs (InternalParameters.ParameterDesc): Do not compare
23942 directly to the modflags, because REF/OUT will actually be bitsets
23945 * delegate.cs (VerifyMethod): Check also the modifiers.
23947 * cs-tokenizer.cs: Fix bug where floating point values with an
23948 exponent where a sign was missing was ignored.
23950 * driver.cs: Allow multiple assemblies to be specified in a single
23953 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23955 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23956 because identifiers after a parenthesis would end up in this kind
23957 of production, and we needed to desamiguate it for having casts
23960 (UserDefinedType *) xxx
23962 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23964 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23965 we should set on the Bindingflags.NonPublic, but not turn on
23966 private_ok. private_ok controls whether a Private member is
23967 returned (this is chekced on the filter routine), while the
23968 BindingFlags.NonPublic just controls whether private/protected
23969 will be allowed. This fixes the problem part of the problem of
23970 private properties being allowed to be used in derived classes.
23972 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23973 so we can call the children DoResolveLValue method (this will
23974 properly signal errors on lvalue assignments to base properties)
23976 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23977 getter are null, and we have a property info, we know that this
23978 happened because the lookup failed, so we report an error 122 for
23979 protection level violation.
23981 We also silently return if setter and getter are null in the
23982 resolve functions, this condition only happens if we have flagged
23983 the error before. This is the other half of the problem.
23985 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23986 not have accessibility information, that is why we were returning
23987 true in the filter function in typemanager.cs.
23989 To properly report 122 (property is inaccessible because of its
23990 protection level) correctly, we report this error in ResolveAccess
23991 by failing if both the setter and the getter are lacking (ie, the
23994 DoResolve and DoLResolve have been modified to check for both
23995 setter/getter being null and returning silently, the reason being
23996 that I did not want to put the knowledge about this error in upper
23999 int old = Report.Errors;
24000 x = new PropertyExpr (...);
24001 if (old != Report.Errors)
24006 So the property expr is returned, but it is invalid, so the error
24007 will be flagged during the resolve process.
24009 * class.cs: Remove InheritablePropertySignatureCompare from the
24010 class, as we no longer depend on the property signature to compute
24011 whether it is possible to implement a method or not.
24013 The reason is that calling PropertyInfo.GetGetMethod will return
24014 null (in .NET, in Mono it works, and we should change this), in
24015 cases where the Get Method does not exist in that particular
24020 class X { public virtual int A { get { return 1; } } }
24022 class Z : Y { public override int A { get { return 2; } } }
24024 Would fail in Z because the parent (Y) would not have the property
24025 defined. So we avoid this completely now (because the alternative
24026 fix was ugly and slow), and we now depend exclusively on the
24029 (PropertyBase.CheckBase): Use a method-base mechanism to find our
24030 reference method, instead of using the property.
24032 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
24033 routines are gone now.
24035 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
24036 names, they were incorrectly named.
24038 * cs-tokenizer.cs: Return are more gentle token on failure.
24040 * pending.cs (PendingImplementation.InterfaceMethod): This routine
24041 had an out-of-sync index variable, which caused it to remove from
24042 the list of pending methods the wrong method sometimes.
24044 2002-10-22 Miguel de Icaza <miguel@ximian.com>
24046 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
24047 CanWrite, because those refer to this particular instance of the
24048 property, and do not take into account the fact that we can
24049 override single members of a property.
24051 Constructor requires an EmitContext. The resolution process does
24052 not happen here, but we need to compute the accessors before,
24053 because the resolution does not always happen for properties.
24055 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
24056 subclass, before we did not update this flag, but we did update
24059 (GetAccessors): Drop this routine, as it did not work in the
24060 presence of partially overwritten set/get methods.
24062 Notice that this broke the cs1540 detection, but that will require
24065 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24069 * driver.cs: issue a warning instead of an error if we don't support
24070 debugging for the platform. Also ignore a couple of errors that may
24071 arise when trying to write the symbols. Undo my previous patch.
24073 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24075 * driver.cs: ignore /debug switch except for Unix platforms.
24077 2002-10-23 Nick Drochak <ndrochak@gol.com>
24079 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
24081 2002-10-21 Miguel de Icaza <miguel@ximian.com>
24083 * driver.cs: Do not make mcs-debug conditional, so we do not break
24084 builds that use it.
24086 * statement.cs (UsageVector.MergeChildren): I would like Martin to
24087 review this patch. But basically after all the children variables
24088 have been merged, the value of "Breaks" was not being set to
24089 new_breaks for Switch blocks. I think that it should be set after
24090 it has executed. Currently I set this to the value of new_breaks,
24091 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
24092 conservative, but I do not understand this code very well.
24094 I did not break anything in the build, so that is good ;-)
24096 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
24098 2002-10-20 Mark Crichton <crichton@gimp.org>
24100 * cfold.cs: Fixed compile blocker. Really fixed it this time.
24102 2002-10-20 Nick Drochak <ndrochak@gol.com>
24104 * cfold.cs: Fixed compile blocker.
24106 2002-10-20 Miguel de Icaza <miguel@ximian.com>
24108 * driver.cs: I was chekcing the key, not the file.
24110 2002-10-19 Ravi Pratap <ravi@ximian.com>
24112 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
24113 message that we were generating - we just need to silently return
24116 2002-10-19 Miguel de Icaza <miguel@ximian.com>
24118 * class.cs (Event.Define): Change my previous commit, as this
24119 breaks the debugger. This is a temporary hack, as it seems like
24120 the compiler is generating events incorrectly to begin with.
24122 * expression.cs (Binary.ResolveOperator): Added support for
24123 "U operator - (E x, E y)"
24125 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
24128 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
24129 init-only variables, but this path did not take into account that
24130 there might be also instance readonly variables. Correct this
24133 This fixes bug 32253
24135 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
24138 * driver.cs: Change the extension for modules to `netmodule'
24140 * cs-parser.jay: Improved slightly the location tracking for
24141 the debugger symbols.
24143 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
24144 modifiers that were specified instead of the hardcoded value
24145 (FamAndAssem). This was basically ignoring the static modifier,
24146 and others. Fixes 32429.
24148 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
24149 fixed a bug in the process (32476)
24151 * expression.cs (ArrayAccess.EmitAssign): Patch from
24152 hwang_rob@yahoo.ca that fixes bug 31834.3
24154 2002-10-18 Miguel de Icaza <miguel@ximian.com>
24156 * driver.cs: Make the module extension .netmodule.
24158 2002-10-16 Miguel de Icaza <miguel@ximian.com>
24160 * driver.cs: Report an error if the resource file is not found
24161 instead of crashing.
24163 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
24164 false, like Emit does.
24166 2002-10-16 Nick Drochak <ndrochak@gol.com>
24168 * typemanager.cs: Remove unused private member. Also reported mcs
24169 bug to report this as a warning like csc.
24171 2002-10-15 Martin Baulig <martin@gnome.org>
24173 * statement.cs (Statement.Emit): Made this a virtual method; emits
24174 the line number info and calls DoEmit().
24175 (Statement.DoEmit): New protected abstract method, formerly knows
24176 as Statement.Emit().
24178 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
24180 2002-10-11 Miguel de Icaza <miguel@ximian.com>
24182 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
24183 have fixed a remaining problem: not every AddXXXX was adding a
24184 fully qualified name.
24186 Now everyone registers a fully qualified name in the DeclSpace as
24187 being defined instead of the partial name.
24189 Downsides: we are slower than we need to be due to the excess
24190 copies and the names being registered this way.
24192 The reason for this is that we currently depend (on the corlib
24193 bootstrap for instance) that types are fully qualified, because
24194 we dump all the types in the namespace, and we should really have
24195 types inserted into the proper namespace, so we can only store the
24196 basenames in the defined_names array.
24198 2002-10-10 Martin Baulig <martin@gnome.org>
24200 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
24201 from bug #31834, see the bug report for a testcase which is
24204 2002-10-10 Martin Baulig <martin@gnome.org>
24206 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
24207 flow analysis code for this.
24209 * statement.cs (Do, While, For): Tell the flow analysis code about
24211 (FlowBranching.UsageVector): Added support for infinite loops.
24212 (Block.Resolve): Moved the dead code elimination here and use flow
24215 2002-10-09 Miguel de Icaza <miguel@ximian.com>
24217 * class.cs (Field.Define): Catch cycles on struct type
24220 * typemanager.cs (IsUnmanagedtype): Do not recursively check
24221 fields if the fields are static. We only need to check instance
24224 * expression.cs (As.DoResolve): Test for reference type.
24226 * statement.cs (Using.ResolveExpression): Use
24227 ConvertImplicitRequired, not ConvertImplicit which reports an
24229 (Using.ResolveLocalVariableDecls): ditto.
24231 * expression.cs (Binary.ResolveOperator): Report errors in a few
24232 places where we had to.
24234 * typemanager.cs (IsUnmanagedtype): Finish implementation.
24236 2002-10-08 Miguel de Icaza <miguel@ximian.com>
24238 * expression.cs: Use StoreFromPtr instead of extracting the type
24239 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
24241 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
24242 an enumeration value to a System.Enum, but System.Enum is not a
24243 value type, but an class type, so we need to box.
24245 (Expression.ConvertExplicit): One codepath could return
24246 errors but not flag them. Fix this. Fixes #31853
24248 * parameter.cs (Resolve): Do not allow void as a parameter type.
24250 2002-10-06 Martin Baulig <martin@gnome.org>
24252 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
24253 if it's a class type and not a struct. Fixes #31815.
24255 2002-10-06 Martin Baulig <martin@gnome.org>
24257 * statement.cs: Reworked the flow analysis code a bit to make it
24258 usable for dead code elimination.
24260 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24262 * cs-parser.jay: allow empty source files. Fixes bug #31781.
24264 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24266 * expression.cs (ComposedCast.DoResolveType): A quick workaround
24267 to fix the test 165, will investigate deeper.
24269 2002-10-04 Martin Baulig <martin@gnome.org>
24271 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
24272 finally blocks actually work.
24273 (Try.Resolve): We don't need to create a sibling for `finally' if
24274 there is no finally block.
24276 2002-10-04 Martin Baulig <martin@gnome.org>
24278 * class.cs (Constructor.Define): The default accessibility for a
24279 non-default constructor is private, not public.
24281 2002-10-04 Miguel de Icaza <miguel@ximian.com>
24283 * class.cs (Constructor): Make AllowedModifiers public, add
24286 * cs-parser.jay: Perform the modifiers test here, as the
24287 constructor for the Constructor class usually receives a zero
24288 because of the way we create it (first we create, later we
24289 customize, and we were never checking the modifiers).
24291 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
24292 is a version of LookupTypeReflection that includes the type-name
24293 cache. This can be used as a fast path for functions that know
24294 the fully qualified name and are only calling into *.GetType() to
24295 obtain a composed type.
24297 This is also used by TypeManager.LookupType during its type
24300 (LookupType): We now also track the real type name, as sometimes
24301 we can get a quey for the real type name from things like
24302 ComposedCast. This fixes bug 31422.
24304 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
24305 complete type fullname, it does not have to go through the type
24306 resolution system to obtain the composed version of the type (for
24307 obtaining arrays or pointers).
24309 (Conditional.Emit): Use the EmitBoolExpression to
24310 generate nicer code, as requested by Paolo.
24312 (ArrayCreation.CheckIndices): Use the patch from
24313 hwang_rob@yahoo.ca to validate the array initializers.
24315 2002-10-03 Miguel de Icaza <miguel@ximian.com>
24317 * class.cs (ConstructorInitializer.Emit): simplify code by using
24318 Invocation.EmitCall, and at the same time, fix the bugs in calling
24319 parent constructors that took variable arguments.
24321 * ecore.cs (Expression.ConvertNumericExplicit,
24322 Expression.ImplicitNumericConversion): Remove the code that
24323 manually wrapped decimal (InternalTypeConstructor call is now gone
24326 * expression.cs (Cast.TryReduce): Also handle decimal types when
24327 trying to perform a constant fold on the type.
24329 * typemanager.cs (IsUnmanagedtype): Partially implemented.
24331 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
24332 that only turned off an error report, and did nothing else.
24334 2002-10-02 Miguel de Icaza <miguel@ximian.com>
24336 * driver.cs: Handle and ignore /fullpaths
24338 2002-10-01 Miguel de Icaza <miguel@ximian.com>
24340 * expression.cs (Binary.ResolveOperator): Catch the case where
24341 DoNumericPromotions returns true,
24343 (Binary.DoNumericPromotions): Simplify the code, and the tests.
24345 2002-09-27 Miguel de Icaza <miguel@ximian.com>
24347 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
24350 2002-09-26 Miguel de Icaza <miguel@ximian.com>
24352 * ecore.cs (ConvertNumericExplicit): It is not enough that the
24353 conversion exists, but it is also required that the conversion be
24354 performed. This manifested in "(Type64Enum) 2".
24356 * class.cs (TypeManager.AddMethod): The fix is not to change
24357 AddEnum, because that one was using a fully qualified name (every
24358 DeclSpace derivative does), but to change the AddMethod routine
24359 that was using an un-namespaced name. This now correctly reports
24360 the duplicated name.
24362 Revert patch until I can properly fix it. The issue
24363 is that we have a shared Type space across all namespaces
24364 currently, which is wrong.
24366 Options include making the Namespace a DeclSpace, and merge
24367 current_namespace/current_container in the parser.
24369 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24371 * cs-parser.jay: Improve error reporting when we get a different
24372 kind of expression in local_variable_type and
24373 local_variable_pointer_type.
24375 Propagate this to avoid missleading errors being reported.
24377 * ecore.cs (ImplicitReferenceConversion): treat
24378 TypeManager.value_type as a target just like object_type. As
24383 Is valid, and needs to result in the int 1 being boxed before it
24384 is assigned to the value type v.
24386 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24387 to validate the enumeration name.
24389 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24390 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24391 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24393 * ecore.cs (TryImplicitIntConversion): When doing an
24394 implicit-enumeration-conversion, check if the type is 64-bits and
24395 perform a conversion before passing to EnumConstant.
24397 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24399 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24400 report ambiguous type references. Unlike the MS version, we
24401 report what the ambiguity is. Innovation at work ;-)
24403 (DeclSpace.FindType): Require a location argument to
24404 display when we display an ambiguous error.
24406 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24408 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24410 * expression.cs (EmitDynamicInitializers): Apply patch from
24411 hwang_rob@yahoo.ca that fixes the order in which we emit our
24414 2002-09-21 Martin Baulig <martin@gnome.org>
24416 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24417 delegate takes no arguments.
24419 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24421 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24424 * expression.cs: Extract the underlying type.
24426 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24428 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24430 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24432 * class.cs (TypeContainer.DefineType): We can not use the nice
24433 PackingSize with the size set to 1 DefineType method, because it
24434 will not allow us to define the interfaces that the struct
24437 This completes the fixing of bug 27287
24439 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24440 means also structs. This fixes part of the problem.
24441 (Expresion.ImplicitReferenceConversionExists): ditto.
24443 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24444 error if there were no errors reported during the type lookup
24445 process, to avoid duplicates or redundant errors. Without this
24446 you would get an ambiguous errors plus a type not found. We have
24447 beaten the user enough with the first error.
24449 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24452 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24453 during the resolution process, stop the lookup, this avoids
24454 repeated error reports (same error twice).
24456 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24458 * typemanager.cs (LookupType): Redo the type lookup code to match
24459 the needs of System.Reflection.
24461 The issue is that System.Reflection requires references to nested
24462 types to begin with a "+" sign instead of a dot. So toplevel
24463 types look like: "NameSpace.TopLevelClass", and nested ones look
24464 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24467 2002-09-19 Martin Baulig <martin@gnome.org>
24469 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24470 says that a method always returns or always throws an exception,
24471 don't report the CS0161.
24473 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24474 set `Returns = new_returns'.
24476 2002-09-19 Martin Baulig <martin@gnome.org>
24478 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24479 to an enum constant, check for a CS0176.
24481 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24483 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24484 for operators that must be in pairs and report errors.
24486 * ecore.cs (SimpleName.DoResolveType): During the initial type
24487 resolution process, when we define types recursively, we must
24488 check first for types in our current scope before we perform
24489 lookups in the enclosing scopes.
24491 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24493 (Invocation.VerifyArgumentsCompat): Call
24494 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24495 I thought we were supposed to always call this, but there are a
24496 few places in the code where we dont do it.
24498 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24500 * driver.cs: Add support in -linkres and -resource to specify the
24501 name of the identifier.
24503 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24505 * ecore.cs (StandardConversionExists): Sync with the conversion
24506 code: allow anything-* to void* conversions.
24508 (FindMostSpecificSource): Use an Expression argument
24509 instead of a Type, because we might be handed over a Literal which
24510 gets a few more implicit conversions that plain types do not. So
24511 this information was being lost.
24513 Also, we drop the temporary type-holder expression when not
24516 2002-09-17 Martin Baulig <martin@gnome.org>
24518 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24519 this is an explicit interface implementation.
24521 2002-09-17 Martin Baulig <martin@gnome.org>
24523 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24524 different `IndexerName' attributes.
24526 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24527 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24528 virtual CommonResolve().
24530 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24532 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24533 and convert that to the UnderlyingType.
24535 * statement.cs (Foreach.Resolve): Indexers are just like variables
24536 or PropertyAccesses.
24538 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24539 inside quoted strings, we were not doing this before.
24541 2002-09-16 Martin Baulig <martin@gnome.org>
24543 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24544 resolve it. This is needed for the definite assignment check of the
24545 instance expression, fixes bug #29846.
24546 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24548 2002-09-16 Nick Drochak <ndrochak@gol.com>
24550 * parameter.cs: Fix compile error. Cannot reference static member
24551 from an instance object. Is this an mcs bug?
24553 2002-09-14 Martin Baulig <martin@gnome.org>
24555 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24556 multiple times. Fixes bug #30295, added test-166.cs.
24558 2002-09-14 Martin Baulig <martin@gnome.org>
24560 * statement.cs (Block.Emit): Don't emit unreachable code.
24561 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24562 `break' statements.
24563 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24565 2002-09-14 Martin Baulig <martin@gnome.org>
24567 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24570 2002-09-14 Martin Baulig <martin@gnome.org>
24572 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24573 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24574 be false on the ms runtime.
24576 2002-09-13 Martin Baulig <martin@gnome.org>
24578 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24579 the CS0038 error message.
24581 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24583 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24584 constant inside, return it.
24586 2002-09-12 Martin Baulig <martin@gnome.org>
24588 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24589 implicit conversion can be done between enum types.
24591 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24592 check whether an implicit conversion to the current enum's UnderlyingType
24593 exists and report an error if not.
24595 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24596 without debugging support.
24598 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24599 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24601 2002-09-12 Martin Baulig <martin@gnome.org>
24603 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24605 * ecore.cs (IMemberExpr.DeclaringType): New property.
24606 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24607 nonstatic member of an outer type (CS0038).
24609 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24611 * driver.cs: Activate the using-error detector at warning level
24612 4 (at least for MS-compatible APIs).
24614 * namespace.cs (VerifyUsing): Small buglett fix.
24616 * pending.cs (PendingImplementation): pass the container pointer.
24618 * interface.cs (GetMethods): Allow for recursive definition. Long
24619 term, I would like to move every type to support recursive
24620 definitions, not the current ordering mechanism that we have right
24623 The situation is this: Attributes are handled before interfaces,
24624 so we can apply attributes to interfaces. But some attributes
24625 implement interfaces, we will now handle the simple cases
24626 (recursive definitions will just get an error).
24628 * parameter.cs: Only invalidate types at the end if we fail to
24631 2002-09-09 Martin Baulig <martin@gnome.org>
24633 * ecore.cs (PropertyExpr.Emit): Also check for
24634 TypeManager.system_int_array_get_length so this'll also work when
24635 compiling corlib. Fixes #30003.
24637 2002-09-09 Martin Baulig <martin@gnome.org>
24639 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24640 and throw an exception if we can't get the type's size. Fixed #30040,
24643 2002-09-09 Martin Baulig <martin@gnome.org>
24645 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24647 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24648 context. Fixes bug #30027.
24650 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24651 virtual functions. Fixes bug #30043, added test-164.cs.
24653 2002-09-08 Ravi Pratap <ravi@ximian.com>
24655 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24657 2002-09-08 Nick Drochak <ndrochak@gol.com>
24659 * driver.cs: Use an object to get the windows codepage since it's not a
24662 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24664 * statement.cs (For.Emit): for infinite loops (test == null)
24665 return whether there is a break inside, not always "true".
24667 * namespace.cs (UsingEntry): New struct to hold the name of the
24668 using definition, the location where it is defined, and whether it
24669 has been used in a successful type lookup.
24671 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24676 2002-09-06 Ravi Pratap <ravi@ximian.com>
24678 * attribute.cs : Fix incorrect code which relied on catching
24679 a NullReferenceException to detect a null being passed in
24680 where an object was expected.
24682 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24684 * statement.cs (Try): flag the catch variable as assigned
24686 * expression.cs (Cast): Simplified by using ResolveType instead of
24687 manually resolving.
24689 * statement.cs (Catch): Fix bug by using ResolveType.
24691 2002-09-06 Ravi Pratap <ravi@ximian.com>
24693 * expression.cs (BetterConversion): Special case for when we have
24694 a NullLiteral as the argument and we have to choose between string
24695 and object types - we choose string the way csc does.
24697 * attribute.cs (Attribute.Resolve): Catch the
24698 NullReferenceException and report error #182 since the Mono
24699 runtime no more has the bug and having this exception raised means
24700 we tried to select a constructor which takes an object and is
24703 2002-09-05 Ravi Pratap <ravi@ximian.com>
24705 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24706 message (1502, 1503) when we can't locate a method after overload
24707 resolution. This is much more informative and closes the bug
24710 * interface.cs (PopulateMethod): Return if there are no argument
24711 types. Fixes a NullReferenceException bug.
24713 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24714 expressions too. Previously we were checking only in one place for
24715 positional arguments leaving out named arguments.
24717 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24718 type to the enum type is not allowed. Remove code corresponding to
24721 (ConvertNumericExplicit): Allow explicit conversions from
24722 the underlying type to enum type. This precisely follows the spec
24723 and closes a bug filed by Gonzalo.
24725 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24728 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24730 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24732 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24733 it was important that we stored the right value after the
24734 reduction in `converted'.
24736 2002-09-04 Martin Baulig <martin@gnome.org>
24738 * location.cs (Location.SymbolDocument): Use full pathnames for the
24741 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24743 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24744 of the expression resolve mechanism, because that will catch the
24745 SimpleName error failures.
24747 (Conditional): If we can not resolve the
24748 expression, return, do not crash.
24750 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24753 (location): display token name instead of its number.
24755 2002-08-28 Martin Baulig <martin@gnome.org>
24757 * expression.cs (Binary.ResolveOperator): Don't silently return
24758 but return an error if an operator cannot be applied between two
24761 2002-08-28 Martin Baulig <martin@gnome.org>
24763 * class.cs (Constructor.Define): Set the permission attributes
24764 correctly instead of making all constructors public.
24766 2002-08-28 Martin Baulig <martin@gnome.org>
24768 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24769 for private members before reporting a CS0103; if we find anything,
24772 2002-08-28 Martin Baulig <martin@gnome.org>
24774 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24775 to check whether `closure_start_type == closure_invocation_type',
24776 we also need to check whether `m.DeclaringType == closure_invocation_type'
24777 before bypassing the permission checks. We might be accessing
24778 protected/private members from the base class.
24779 (TypeManager.RealMemberLookup): Only set private_ok if private
24780 members were requested via BindingFlags.NonPublic.
24782 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24784 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24785 MethodGroupExpr.IsExplicitImpl if appropriate.
24786 (Invocation.DoResolve): Don't report the CS0120 for explicit
24787 interface implementations.
24789 2002-08-27 Martin Baulig <martin@gnome.org>
24791 * expression.cs (Invocation.DoResolve): If this is a static
24792 method and we don't have an InstanceExpression, we must report
24795 2002-08-25 Martin Baulig <martin@gnome.org>
24797 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24798 `==' between a valuetype and an object.
24800 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24802 * ecore.cs (TypeExpr): Provide a ToString method.
24804 2002-08-24 Martin Baulig <martin@gnome.org>
24806 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24807 now called proggie.dbg and it's a binary file.
24809 2002-08-23 Martin Baulig <martin@gnome.org>
24811 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24813 2002-08-23 Martin Baulig <martin@gnome.org>
24815 * struct.cs (MyStructInfo.ctor): Make this work with empty
24816 structs; it's not allowed to use foreach() on null.
24818 2002-08-23 Martin Baulig <martin@gnome.org>
24820 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24821 writer the full pathname of the generated assembly.
24823 2002-08-23 Martin Baulig <martin@gnome.org>
24825 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24826 A `finally' block never returns or breaks; improved handling of
24829 2002-08-23 Martin Baulig <martin@gnome.org>
24831 * statement.cs (Throw.Resolve): Allow `throw null'.
24833 2002-08-23 Martin Baulig <martin@gnome.org>
24835 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24836 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24837 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24838 MemberLookup would return a wrong event if this is an explicit
24839 interface implementation and the class has an event with the same
24842 2002-08-23 Martin Baulig <martin@gnome.org>
24844 * statement.cs (Block.AddChildVariableNames): New public method.
24845 (Block.AddChildVariableName): Likewise.
24846 (Block.IsVariableNameUsedInChildBlock): Likewise.
24847 (Block.AddVariable): Check whether a variable name has already
24848 been used in a child block.
24850 * cs-parser.jay (declare_local_variables): Mark all variable names
24851 from the current block as being used in a child block in the
24854 2002-08-23 Martin Baulig <martin@gnome.org>
24856 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24857 find the symbol writer.
24859 * driver.cs: csc also allows the arguments to /define being
24860 separated by commas, not only by semicolons.
24862 2002-08-23 Martin Baulig <martin@gnome.org>
24864 * interface.cs (Interface.GetMembers): Added static check for events.
24866 2002-08-15 Martin Baulig <martin@gnome.org>
24868 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24869 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24871 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24872 why the MethodData.EmitDestructor() change was necessary.
24874 2002-08-20 Martin Baulig <martin@gnome.org>
24876 * class.cs (TypeContainer.FindMembers): Added static check for events.
24878 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24880 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24881 use Type.GetEvents(), not Type.FindMembers().
24883 2002-08-20 Martin Baulig <martin@gnome.org>
24885 * decl.cs (MemberCache): Added a special method cache which will
24886 be used for method-only searched. This ensures that a method
24887 search will return a MethodInfo with the correct ReflectedType for
24890 2002-08-20 Martin Baulig <martin@gnome.org>
24892 * decl.cs (DeclSpace.FindMembers): Made this public.
24894 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24896 * delegate.cs: fixed build on windows.
24897 [FIXME: Filed as bug #29150: MCS must report these errors.]
24899 2002-08-19 Ravi Pratap <ravi@ximian.com>
24901 * ecore.cs (StandardConversionExists): Return a false
24902 if we are trying to convert the void type to anything else
24903 since that is not allowed.
24905 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24906 we flag error 70 in the event an event is trying to be accessed
24907 directly from outside the declaring type.
24909 2002-08-20 Martin Baulig <martin@gnome.org>
24911 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24912 MemberCache from typemanager.cs to decl.cs.
24914 2002-08-19 Martin Baulig <martin@gnome.org>
24916 * class.cs (TypeContainer): Implement IMemberContainer.
24917 (TypeContainer.DefineMembers): Create the MemberCache.
24918 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24919 return public members if BindingFlags.Public was given, check
24920 whether members are static.
24922 2002-08-16 Martin Baulig <martin@gnome.org>
24924 * decl.cs (DeclSpace.Define): Splitted this in Define and
24925 DefineMembers. DefineMembers is called first and initializes the
24928 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24929 DefineMembers() on all our DeclSpaces.
24931 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24932 but call DefineMembers() on all nested interfaces. We call their
24933 Define() in our new Define() function.
24935 * interface.cs (Interface): Implement IMemberContainer.
24936 (Interface.Define): Moved all code except the attribute stuf to
24938 (Interface.DefineMembers): Initialize the member cache.
24940 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24941 need this anymore since we can use MemberCache.FindMembers directly.
24943 2002-08-19 Martin Baulig <martin@gnome.org>
24945 * typemanager.cs (MemberCache): When creating the cache for an
24946 interface type, add all inherited members.
24947 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24948 to `out bool used_cache' and documented it.
24949 (TypeManager.MemberLookup): If we already used the cache in the first
24950 iteration, we don't need to do the interfaces check.
24952 2002-08-19 Martin Baulig <martin@gnome.org>
24954 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24955 here from IMemberFinder and don't implement this interface anymore.
24956 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24958 * typemanager.cs (IMemberFinder): This interface is now only used by
24959 classes which actually support the member cache.
24960 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24961 since we only put DeclSpaces into this Hashtable.
24962 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24963 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24965 2002-08-16 Martin Baulig <martin@gnome.org>
24967 * typemanager.cs (ICachingMemberFinder): Removed.
24968 (IMemberFinder.MemberCache): New property.
24969 (TypeManager.FindMembers): Merged this with RealFindMembers().
24970 This function will never be called from TypeManager.MemberLookup()
24971 so we can't use the cache here, just the IMemberFinder.
24972 (TypeManager.MemberLookup_FindMembers): Check whether the
24973 IMemberFinder has a MemberCache and call the cache's FindMembers
24975 (MemberCache): Rewrote larger parts of this yet another time and
24976 cleaned it up a bit.
24978 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24980 * driver.cs (LoadArgs): Support quoting.
24982 (Usage): Show the CSC-like command line arguments.
24984 Improved a few error messages.
24986 2002-08-15 Martin Baulig <martin@gnome.org>
24988 * typemanager.cs (IMemberContainer.Type): New property.
24989 (IMemberContainer.IsInterface): New property.
24991 The following changes are conditional to BROKEN_RUNTIME, which is
24992 defined at the top of the file.
24994 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24995 class'es members, but add all members from TypeHandle.ObjectType
24996 if we're an interface.
24997 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24998 is the current type.
24999 (MemberCache.CacheEntry.Container): Removed this field.
25000 (TypeHandle.GetMembers): Include inherited members.
25002 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25004 * typemanager.cs: fixed compilation and added a comment on a field that
25007 2002-08-15 Martin Baulig <martin@gnome.org>
25009 * class.cs (ConstructorInitializer.Resolve): In the
25010 Expression.MemberLookup call, use the queried_type as
25013 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
25014 declared' attribute, it's always true.
25015 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
25016 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
25017 temporary wrapper for FindMembers which tells MemberLookup whether
25018 members from the base classes are included in the return value.
25019 This will go away soon.
25020 (TypeManager.MemberLookup): Use this temporary hack here; once the
25021 new MemberCache is completed, we don't need to do the DeclaredOnly
25022 looping here anymore since the MemberCache will take care of this.
25023 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
25024 (MemberCache): When creating the MemberCache for a class, get
25025 members from the current class and all its base classes.
25026 (MemberCache.CacheEntry.Container): New field. This is a
25027 temporary hack until the Mono runtime is fixed to distinguish
25028 between ReflectedType and DeclaringType. It allows us to use MCS
25029 with both the MS runtime and the unfixed Mono runtime without
25030 problems and without accecting performance.
25031 (MemberCache.SearchMembers): The DeclaredOnly looping from
25032 TypeManager.MemberLookup is now done here.
25034 2002-08-14 Martin Baulig <martin@gnome.org>
25036 * statement.cs (MyStructInfo.MyStructInfo): Don't call
25037 Type.GetFields on dynamic types but get the fields from the
25038 corresponding TypeContainer.
25039 (MyStructInfo.GetStructInfo): Added check for enum types.
25041 * typemanager.cs (MemberList.IsSynchronized): Implemented.
25042 (MemberList.SyncRoot): Implemented.
25043 (TypeManager.FilterWithClosure): No need to check permissions if
25044 closure_start_type == closure_invocation_type, don't crash if
25045 closure_invocation_type is null.
25047 2002-08-13 Martin Baulig <martin@gnome.org>
25049 Rewrote TypeContainer.FindMembers to use a member cache. This
25050 gives us a speed increase of about 35% for the self-hosting MCS
25051 build and of about 15-20% for the class libs (both on GNU/Linux).
25053 * report.cs (Timer): New class to get enhanced profiling. This
25054 whole class is "TIMER" conditional since it remarkably slows down
25057 * class.cs (MemberList): New class. This is an IList wrapper
25058 which we're now using instead of passing MemberInfo[]'s around to
25059 avoid copying this array unnecessarily.
25060 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
25061 (ICachingMemberFinder, IMemberContainer): New interface.
25062 (TypeManager.FilterWithClosure): If `criteria' is null, the name
25063 has already been checked, otherwise use it for the name comparision.
25064 (TypeManager.FindMembers): Renamed to RealMemberFinder and
25065 provided wrapper which tries to use ICachingMemberFinder.FindMembers
25066 if possible. Returns a MemberList, not a MemberInfo [].
25067 (TypeHandle): New class, implements IMemberContainer. We create
25068 one instance of this class per type, it contains a MemberCache
25069 which is used to do the member lookups.
25070 (MemberCache): New class. Each instance of this class contains
25071 all members of a type and a name-based hash table.
25072 (MemberCache.FindMembers): This is our new member lookup
25073 function. First, it looks up all members of the requested name in
25074 the hash table. Then, it walks this list and sorts out all
25075 applicable members and returns them.
25077 2002-08-13 Martin Baulig <martin@gnome.org>
25079 In addition to a nice code cleanup, this gives us a performance
25080 increase of about 1.4% on GNU/Linux - not much, but it's already
25081 half a second for the self-hosting MCS compilation.
25083 * typemanager.cs (IMemberFinder): New interface. It is used by
25084 TypeManager.FindMembers to call FindMembers on a TypeContainer,
25085 Enum, Delegate or Interface.
25086 (TypeManager.finder_to_member_finder): New PtrHashtable.
25087 (TypeManager.finder_to_container): Removed.
25088 (TypeManager.finder_to_delegate): Removed.
25089 (TypeManager.finder_to_interface): Removed.
25090 (TypeManager.finder_to_enum): Removed.
25092 * interface.cs (Interface): Implement IMemberFinder.
25094 * delegate.cs (Delegate): Implement IMemberFinder.
25096 * enum.cs (Enum): Implement IMemberFinder.
25098 * class.cs (TypeContainer): Implement IMemberFinder.
25100 2002-08-12 Martin Baulig <martin@gnome.org>
25102 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
25104 2002-08-12 Martin Baulig <martin@gnome.org>
25106 * ecore.cs (ITypeExpression): New interface for expressions which
25108 (TypeExpression): Renamed to TypeLookupExpression.
25109 (Expression.DoResolve): If we're doing a types-only lookup, the
25110 expression must implement the ITypeExpression interface and we
25111 call DoResolveType() on it.
25112 (SimpleName): Implement the new ITypeExpression interface.
25113 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
25114 hack, the situation that we're only looking up types can't happen
25115 anymore when this method is called. Moved the type lookup code to
25116 DoResolveType() and call it.
25117 (SimpleName.DoResolveType): This ITypeExpression interface method
25118 is now doing the types-only lookup.
25119 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
25120 (ResolveFlags): Added MaskExprClass.
25122 * expression.cs (MemberAccess): Implement the ITypeExpression
25124 (MemberAccess.DoResolve): Added support for a types-only lookup
25125 when we're called via ITypeExpression.DoResolveType().
25126 (ComposedCast): Implement the ITypeExpression interface.
25128 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
25129 Expression.Resolve() with ResolveFlags.Type instead.
25131 2002-08-12 Martin Baulig <martin@gnome.org>
25133 * interface.cs (Interface.Define): Apply attributes.
25135 * attribute.cs (Attribute.ApplyAttributes): Added support for
25136 interface attributes.
25138 2002-08-11 Martin Baulig <martin@gnome.org>
25140 * statement.cs (Block.Emit): Only check the "this" variable if we
25141 do not always throw an exception.
25143 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
25144 whether the property has a set accessor.
25146 2002-08-11 Martin Baulig <martin@gnome.org>
25148 Added control flow analysis support for structs.
25150 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
25151 with control flow analysis turned off.
25152 (IVariable): New interface.
25153 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
25154 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
25155 (FieldExpr.DoResolve): Resolve the instance expression with flow
25156 analysis turned off and do the definite assignment check after the
25157 resolving when we know what the expression will resolve to.
25159 * expression.cs (LocalVariableReference, ParameterReference):
25160 Implement the new IVariable interface, only call the flow analysis
25161 code if ec.DoFlowAnalysis is true.
25162 (This): Added constructor which takes a Block argument. Implement
25163 the new IVariable interface.
25164 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
25165 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
25166 This does the definite assignment checks for struct members.
25168 * class.cs (Constructor.Emit): If this is a non-static `struct'
25169 constructor which doesn't have any initializer, call
25170 Block.AddThisVariable() to tell the flow analysis code that all
25171 struct elements must be initialized before control returns from
25174 * statement.cs (MyStructInfo): New public class.
25175 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
25176 argument to this indexer. If non-zero, check an individual struct
25177 member, not the whole struct.
25178 (FlowBranching.CheckOutParameters): Check struct members.
25179 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
25180 overloaded versions of these methods which take an additional
25181 `int field_idx' argument to check struct members.
25182 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
25183 overloaded versions of these methods which take an additional
25184 `string field_name' argument to check struct member.s
25185 (VariableInfo): Implement the IVariable interface.
25186 (VariableInfo.StructInfo): New public property. Returns the
25187 MyStructInfo instance of the variable if it's a struct or null.
25188 (Block.AddThisVariable): New public method. This is called from
25189 Constructor.Emit() for non-static `struct' constructor which do
25190 not have any initializer. It creates a special variable for the
25191 "this" instance variable which will be checked by the flow
25192 analysis code to ensure that all of the struct's fields are
25193 initialized before control returns from the constructor.
25194 (UsageVector): Added support for struct members. If a
25195 variable/parameter is a struct with N members, we reserve a slot
25196 in the usage vector for each member. A struct is considered fully
25197 initialized if either the struct itself (slot 0) or all its
25198 members are initialized.
25200 2002-08-08 Martin Baulig <martin@gnome.org>
25202 * driver.cs (Driver.MainDriver): Only report an error CS5001
25203 if there were no compilation errors.
25205 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
25206 `UnsafeContext' property to determine whether the parent is in
25207 unsafe context rather than checking the parent's ModFlags:
25208 classes nested in an unsafe class are unsafe as well.
25210 2002-08-08 Martin Baulig <martin@gnome.org>
25212 * statement.cs (UsageVector.MergeChildren): Distinguish between
25213 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
25214 we return. Added test17() and test18() to test-154.cs.
25216 2002-08-08 Martin Baulig <martin@gnome.org>
25218 * typemanager.cs (TypeManager.FilterWithClosure): If we have
25219 Family access, make sure the invoking type isn't a subclass of the
25220 queried type (that'd be a CS1540).
25222 * ecore.cs (Expression.MemberLookup): Added overloaded version of
25223 this method which takes an additional `Type invocation_type'.
25225 * expression.cs (BaseAccess.DoResolve): Use the base type as
25226 invocation and query type.
25227 (MemberAccess.DoResolve): If the lookup failed and we're about to
25228 report a CS0122, try a lookup with the ec.ContainerType - if this
25229 succeeds, we must report a CS1540.
25231 2002-08-08 Martin Baulig <martin@gnome.org>
25233 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
25234 (MethodGroupExpr): Implement the IMemberExpr interface.
25236 * expression (MemberAccess.ResolveMemberAccess): No need to have
25237 any special code for MethodGroupExprs anymore, they're now
25240 2002-08-08 Martin Baulig <martin@gnome.org>
25242 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
25243 Family, FamANDAssem and FamORAssem permissions.
25244 (TypeManager.IsSubclassOrNestedChildOf): New public method.
25246 2002-08-08 Martin Baulig <martin@gnome.org>
25248 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
25249 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
25252 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
25254 * driver.cs: implemented /resource option to embed managed resources.
25256 2002-08-07 Martin Baulig <martin@gnome.org>
25258 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
25259 (FieldBase.HasFieldInitializer): New public property.
25260 (FieldBase.GetInitializerExpression): New public method. Resolves and
25261 returns the field initializer and makes sure it is only resolved once.
25262 (TypeContainer.EmitFieldInitializers): Call
25263 FieldBase.GetInitializerExpression to get the initializer, this ensures
25264 that it isn't resolved multiple times.
25266 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
25267 the resolving process (SimpleName/MemberLookup) that we're currently
25268 emitting a field initializer (which must not access any instance members,
25269 this is an error CS0236).
25271 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
25272 argument, if the `IsFieldInitializer' flag is set, we must report and
25273 error CS0236 and not an error CS0120.
25275 2002-08-07 Martin Baulig <martin@gnome.org>
25277 * ecore.cs (IMemberExpr): New public interface.
25278 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
25279 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
25280 if the expression is an IMemberExpr.
25282 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
25283 to be null, implicitly default to `this' if we're non-static in
25284 this case. Simplified the code a lot by using the new IMemberExpr
25285 interface. Also fixed bug #28176 here.
25287 2002-08-06 Martin Baulig <martin@gnome.org>
25289 * cs-parser.jay (SimpleLookup): Removed. We need to create
25290 ParameterReferences during semantic analysis so that we can do a
25291 type-only search when resolving Cast, TypeOf and SizeOf.
25292 (block): Pass the `current_local_parameters' to the Block's
25295 * class.cs (ConstructorInitializer): Added `Parameters parameters'
25296 argument to the constructor.
25297 (ConstructorInitializer.Resolve): Create a temporary implicit
25298 block with the parameters.
25300 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
25301 references here if we aren't doing a type-only search.
25303 * statement.cs (Block): Added constructor which takes a
25304 `Parameters parameters' argument.
25305 (Block.Parameters): New public property.
25307 * support.cs (InternalParameters.Parameters): Renamed `parameters'
25308 to `Parameters' and made it public readonly.
25310 2002-08-06 Martin Baulig <martin@gnome.org>
25312 * ecore.cs (Expression.Warning): Made this public as well.
25314 * report.cs (Report.Debug): Print the contents of collections.
25316 2002-08-06 Martin Baulig <martin@gnome.org>
25318 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
25319 used to tell Resolve() which kinds of expressions it may return.
25320 (Expression.Resolve): Added overloaded version of this method which
25321 takes a `ResolveFlags flags' argument. This can be used to tell
25322 Resolve() which kinds of expressions it may return. Reports a
25324 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
25325 ResolveFlags.SimpleName.
25326 (Expression.Error118): Added overloaded version of this method which
25327 takes a `ResolveFlags flags' argument. It uses the flags to determine
25328 which kinds of expressions are allowed.
25330 * expression.cs (Argument.ResolveMethodGroup): New public method.
25331 Resolves an argument, but allows a MethodGroup to be returned.
25332 This is used when invoking a delegate.
25334 * TODO: Updated a bit.
25336 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25338 Fixed compilation with csc.
25340 * ecore.cs: Expression.Error made public. Is this correct? Should
25341 Warning be made public too?
25343 * expression.cs: use ea.Location instead of ea.loc.
25344 [FIXME: Filed as bug #28607: MCS must report these errors.]
25346 2002-08-06 Martin Baulig <martin@gnome.org>
25348 * ecore.cs (Expression.loc): Moved the location here instead of
25349 duplicating it in all derived classes.
25350 (Expression.Location): New public property.
25351 (Expression.Error, Expression.Warning): Made them non-static and
25352 removed the location argument.
25353 (Expression.Warning): Added overloaded version which takes an
25354 `int level' argument.
25355 (Expression.Error118): Make this non-static and removed the
25356 expression and location arguments.
25357 (TypeExpr): Added location argument to the constructor.
25359 * expression.cs (StaticCallExpr): Added location argument to
25361 (Indirection, PointerArithmetic): Likewise.
25362 (CheckedExpr, UnCheckedExpr): Likewise.
25363 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25364 (StringPtr): Likewise.
25367 2002-08-05 Martin Baulig <martin@gnome.org>
25369 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25371 * assign.cs (Assign.DoResolve): Check whether the source
25372 expression is a value or variable.
25374 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25375 while resolving the corresponding blocks.
25377 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25378 an error, don't silently return null.
25380 * statement.cs (Block.AddVariable): Do the error reporting here
25381 and distinguish between CS0128 and CS0136.
25382 (Block.DoResolve): Report all unused labels (warning CS0164).
25383 (LabeledStatement): Pass the location to the constructor.
25384 (LabeledStatement.HasBeenReferenced): New property.
25385 (LabeledStatement.Resolve): Set it to true here.
25387 * statement.cs (Return.Emit): Return success even after reporting
25388 a type mismatch error (CS0126 or CS0127), this is what csc does and
25389 it avoids confusing the users with any consecutive errors.
25391 2002-08-05 Martin Baulig <martin@gnome.org>
25393 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25395 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25397 * expression.cs (MemberAccess.DoResolve): Silently return if an
25398 error has already been reported.
25400 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25401 error has already been reported.
25403 2002-08-05 Martin Baulig <martin@gnome.org>
25405 * statement.cs (UsageVector): Only initialize the `parameters'
25406 vector if we actually have any "out" parameters.
25408 2002-08-05 Martin Baulig <martin@gnome.org>
25410 * expression.cs (Binary.ResolveOperator): When combining delegates,
25411 they must have the same type.
25413 2002-08-05 Martin Baulig <martin@gnome.org>
25415 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25416 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25417 work with the ms runtime and we also don't need it: if we're a
25418 PropertyBuilder and not in the `indexer_arguments' hash, then we
25419 are a property and not an indexer.
25421 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25422 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25423 since the latter one doesn't work with the ms runtime.
25425 2002-08-03 Martin Baulig <martin@gnome.org>
25427 Fixed bugs #27998 and #22735.
25429 * class.cs (Method.IsOperator): New public field.
25430 (Method.CheckBase): Report CS0111 if there's already a method
25431 with the same parameters in the current class. Report CS0508 when
25432 attempting to change the return type of an inherited method.
25433 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25434 and it's not marked abstract or extern.
25435 (PropertyBase): New abstract base class for Property and Indexer.
25436 (PropertyBase.CheckBase): Moved here from Property and made it work
25438 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25439 the same so we can reuse it there.
25440 (Property, Indexer): Derive from PropertyBase.
25441 (MethodSignature.inheritable_property_signature_filter): New delegate
25442 to find properties and indexers.
25444 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25445 argument and improved error reporting.
25447 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25448 EmptyReadOnlyParameters and made it a property.
25450 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25451 version of this method which takes a `PropertyInfo indexer'.
25452 (TypeManager.RegisterIndexer): New method.
25454 * class.cs: Added myself as author of this file :-)
25456 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25458 * class.cs: fixed compilation on windoze.
25460 2002-08-03 Martin Baulig <martin@gnome.org>
25462 * interface.cs (Interface.GetInterfaceBases): Check whether all
25463 base interfaces are at least as accessible than the current one.
25465 * class.cs (TypeContainer.GetClassBases): Check whether base types
25466 are at least as accessible than the current type.
25467 (TypeContainer.AsAccessible): Implemented and made non-static.
25468 (MemberBase.CheckParameters): Report errors if the accessibility
25471 * delegate.cs (Delegate.Delegate): The default visibility is
25472 internal for top-level types and private for nested types.
25473 (Delegate.Define): Report errors if the accessibility checks fail.
25475 * enum.cs (Enum.Enum): The default visibility is internal for
25476 top-level types and private for nested types.
25477 (Enum.DefineType): Compute the correct visibility.
25479 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25480 function which takes a `bool is_toplevel' instead of a TypeContainer.
25482 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25485 2002-08-02 Martin Baulig <martin@gnome.org>
25487 * expression.cs (LocalVariableReferenc): Added constructor which
25488 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25489 (LocalVariableReference.IsReadOnly): New property.
25490 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25491 variable is readonly, use our own readonly flag to do this; you can
25492 use the new constructor to get a writable reference to a read-only
25495 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25496 reference to the local variable.
25498 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25500 * rootcontext.cs (ResolveCore): Also include System.Exception
25502 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25503 we reach an EmptyStatement.
25505 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25508 * expression.cs (Binary.ResolveOperator): Check error result in
25511 use brtrue/brfalse directly and avoid compares to null.
25513 2002-08-02 Martin Baulig <martin@gnome.org>
25515 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25516 Fixes bug #28407, added test-155.cs.
25518 2002-08-01 Martin Baulig <martin@gnome.org>
25520 * class.cs (Event.EmitDefaultMethod): Make this work with static
25521 events. Fixes #28311, added verify-3.cs.
25523 2002-08-01 Martin Baulig <martin@gnome.org>
25525 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25526 `is_disposable' fields.
25527 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25528 `hm.is_disposable' if we're using the collection pattern.
25529 (Foreach.EmitCollectionForeach): Use the correct type for the
25530 enumerator's local variable, only emit the try/finally block if
25531 necessary (fixes #27713).
25533 2002-08-01 Martin Baulig <martin@gnome.org>
25535 * ecore.cs (Expression.report118): Renamed to Error118 and made
25538 * statement.cs (Throw.Resolve): Check whether the expression is of
25539 the correct type (CS0118) and whether the type derives from
25540 System.Exception (CS0155).
25541 (Catch.Resolve): New method. Do the type lookup here and check
25542 whether it derives from System.Exception (CS0155).
25543 (Catch.CatchType, Catch.IsGeneral): New public properties.
25545 * typemanager.cs (TypeManager.exception_type): Added.
25547 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25549 * driver.cs: Updated About function.
25551 2002-07-31 Martin Baulig <martin@gnome.org>
25553 Implemented Control Flow Analysis.
25555 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25556 (EmitContext.CurrentBranching): Added.
25557 (EmitContext.StartFlowBranching): Added.
25558 (EmitContext.EndFlowBranching): Added.
25559 (EmitContext.KillFlowBranching): Added.
25560 (EmitContext.IsVariableAssigned): Added.
25561 (EmitContext.SetVariableAssigned): Added.
25562 (EmitContext.IsParameterAssigned): Added.
25563 (EmitContext.SetParameterAssigned): Added.
25564 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25565 Added control flow analysis stuff here.
25567 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25568 resolve the expression as lvalue.
25569 (LocalVariableReference.DoResolve): Check whether the variable has
25570 already been assigned.
25571 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25572 the parameter as assigned here.
25573 (ParameterReference.DoResolve): Check whether the parameter has already
25575 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25576 expression as lvalue.
25578 * statement.cs (FlowBranching): New class for the flow analysis code.
25579 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25580 (LabeledStatement.IsDefined): New public property.
25581 (LabeledStatement.AddUsageVector): New public method to tell flow
25582 analyis that the label may be reached via a forward jump.
25583 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25585 (VariableInfo.Number): New public field. This is used by flow analysis
25586 to number all locals of a block.
25587 (Block.CountVariables): New public property. This is the number of
25588 local variables in this block (including the locals from all parent
25590 (Block.EmitMeta): Number all the variables.
25592 * statement.cs: Added flow analysis support to all classes.
25594 2002-07-31 Martin Baulig <martin@gnome.org>
25596 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25597 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25598 then use this argument.
25600 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25602 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25603 use this to specify /define options.
25605 2002-07-29 Martin Baulig <martin@gnome.org>
25607 * statement.cs (Fixed): Moved all code that does variable lookups
25608 and resolvings from Emit to Resolve.
25610 * statement.cs (For): Moved all code that does variable lookups
25611 and resolvings from Emit to Resolve.
25613 * statement.cs (Using): Moved all code that does variable lookups
25614 and resolvings from Emit to Resolve.
25616 2002-07-29 Martin Baulig <martin@gnome.org>
25618 * attribute.cs (Attribute.Resolve): Explicitly catch a
25619 System.NullReferenceException when creating the
25620 CustromAttributeBuilder and report a different warning message.
25622 2002-07-29 Martin Baulig <martin@gnome.org>
25624 * support.cs (ParameterData.ParameterName): Added method to
25625 get the name of a parameter.
25627 * typemanager.cs (TypeManager.IsValueType): New public method.
25629 2002-07-29 Martin Baulig <martin@gnome.org>
25631 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25632 is a flag which specifies that it's either ref or out.
25633 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25634 the out parameter to `out Parameter.Modifier mod', also set the
25635 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25637 * support.cs (InternalParameters.ParameterModifier): Distinguish
25638 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25639 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25641 * expression.cs (Argument.GetParameterModifier): Distinguish
25642 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25643 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25645 2002-07-29 Martin Baulig <martin@gnome.org>
25647 * expression.cs (ParameterReference.ParameterReference): Added
25648 `Location loc' argument to the constructor.
25650 * cs-parser.jay: Pass location to ParameterReference.
25652 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25654 * statement.cs (Try): Initialize the location.
25656 * cs-parser.jay: pass location to Try.
25658 * expression.cs (Unary.Reduce): Change the prototype to return
25659 whether a constant fold could be performed or not. The result is
25660 returned in an out parameters. In the case of Indirection and
25661 AddressOf, we want to perform the full tests.
25663 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25665 * statement.cs (Statement.Emit): Flag dead code.
25667 2002-07-27 Andrew Birkett <andy@nobugs.org>
25669 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25671 2002-07-27 Martin Baulig <martin@gnome.org>
25673 * class.cs (MethodData.Define): Put back call to
25674 TypeManager.AddMethod(), accidentally commented this out.
25676 * report.cs (Debug): New public method to print debugging information,
25677 this is `[Conditional ("DEBUG")]'.
25679 2002-07-26 Martin Baulig <martin@gnome.org>
25681 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25682 (switch_statement): Push the current_block to the switch_stack and
25683 pop it again when we're done with the switch.
25684 (switch_section): The new block is a child of the current_block.
25685 Fixes bug #24007, added test-152.cs.
25687 2002-07-27 Martin Baulig <martin@gnome.org>
25689 * expression.cs (Invocation.EmitArguments): When calling a varargs
25690 function with only its fixed arguments, we need to pass an empty
25693 2002-07-27 Martin Baulig <martin@gnome.org>
25695 Mono 0.13 has been released.
25697 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25699 * driver.cs: Rename --resource to --linkres, because that is what
25700 we do currently, we dont support --resource yet.
25702 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25704 2002-07-25 Martin Baulig <martin@gnome.org>
25706 * class.cs (MethodData): New public class. This is a `method builder'
25707 class for a method or one accessor of a Property/Indexer/Event.
25708 (MethodData.GetMethodFlags): Moved here from MemberBase.
25709 (MethodData.ApplyAttributes): Likewise.
25710 (MethodData.ApplyObsoleteAttribute): Likewise.
25711 (MethodData.ApplyConditionalAttribute): Likewise.
25712 (MethodData.ApplyDllImportAttribute): Likewise.
25713 (MethodData.CheckAbstractAndExternal): Likewise.
25714 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25715 (MethodData.Emit): Formerly known as Method.Emit().
25716 (MemberBase): Moved everything which was specific to a single
25717 accessor/method to MethodData.
25718 (Method): Create a new MethodData and call Define() and Emit() on it.
25719 (Property, Indexer, Event): Create a new MethodData objects for each
25720 accessor and call Define() and Emit() on them.
25722 2002-07-25 Martin Baulig <martin@gnome.org>
25724 Made MethodCore derive from MemberBase to reuse the code from there.
25725 MemberBase now also checks for attributes.
25727 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25728 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25730 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25731 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25732 (MemberBase.ApplyAttributes): New virtual method; applies the
25733 attributes to a method or accessor.
25734 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25735 (MemberBase.ApplyConditionalAttribute): Likewise.
25736 (MemberBase.ApplyDllImportAttribute): Likewise.
25737 (MemberBase.CheckAbstractAndExternal): Likewise.
25738 (MethodCore.ParameterTypes): This is now a property instead of a
25739 method, it's initialized from DoDefineParameters().
25740 (MethodCore.ParameterInfo): Removed the set accessor.
25741 (MethodCore.DoDefineParameters): New protected virtual method to
25742 initialize ParameterTypes and ParameterInfo.
25743 (Method.GetReturnType): We can now simply return the MemberType.
25744 (Method.GetMethodFlags): Override the MemberBase version and add
25745 the conditional flags.
25746 (Method.CheckBase): Moved some code from Define() here, call
25747 DoDefineParameters() here.
25748 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25749 here to avoid some larger code duplication.
25750 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25751 ensure that abstract and external accessors don't declare a body.
25753 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25754 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25755 lookup in the attribute's parent classes, so we need to abort as soon
25756 as we found the first match.
25757 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25758 the attribute has no arguments.
25760 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25763 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25765 * cs-parser.jay: reverted previous patch.
25767 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25769 * cs-parser.jay: fixed bug #22119.
25771 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25773 * attribute.cs: fixed compilation. The error was:
25774 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25775 be assigned to before control leaves the current method."
25776 [FIXME: Filed as bug #28186: MCS must report this error.]
25778 2002-07-25 Martin Baulig <martin@gnome.org>
25780 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25781 method to pull the condition name ouf of a Conditional attribute.
25782 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25783 the obsolete message and error flag out of an Obsolete attribute.
25785 * class.cs (Method.GetMethodFlags): New public method to get the
25786 TypeManager.MethodFlags for this method.
25787 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25789 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25790 if we're overriding a virtual function, set the new private variable
25791 `parent_method'; call the new TypeManager.AddMethod().
25793 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25794 the MethodBuilder and the Method in a PtrHashtable.
25795 (TypeManager.builder_to_method): Added for this purpose.
25796 (TypeManager.MethodFlags): Added IsObsoleteError.
25797 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25798 Obsolete and Conditional arguments in MethodBuilders. If we discover
25799 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25800 the message from the attribute.
25802 2002-07-24 Martin Baulig <martin@gnome.org>
25804 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25805 preprocessor directives, ensure that the argument to #define/#undef is
25806 exactly one identifier and that it's actually an identifier.
25808 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25811 2002-07-24 Martin Baulig <martin@gnome.org>
25813 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25814 initialize it to TypeManager.object_type in the constructor.
25815 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25816 of the `hm.get_current' method if we're using the collection pattern.
25817 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25818 for the explicit conversion to make it work when we're using the collection
25819 pattern and the `Current' property has a different return type than `object'.
25822 2002-07-24 Martin Baulig <martin@gnome.org>
25824 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25825 does not match, but don't report any errors. This method is called in
25826 order for all methods in a MethodGroupExpr until a matching method is
25827 found, so we don't want to bail out if the first method doesn't match.
25828 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25829 matches, report the 123. Fixes #28070.
25831 2002-07-24 Martin Baulig <martin@gnome.org>
25833 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25834 TypeManager.TypeToCoreType() to the top of the method so the
25835 following equality checks will work. Fixes #28107.
25837 2002-07-24 Martin Baulig <martin@gnome.org>
25839 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25840 operand is of type uint, and the other operand is of type sbyte,
25841 short or int, the operands are converted to type long." -
25842 Actually do what this comment already told us. Fixes bug #28106,
25845 2002-07-24 Martin Baulig <martin@gnome.org>
25847 * class.cs (MethodBase): New abstract class. This is now a base
25848 class for Property, Indexer and Event to avoid some code duplication
25849 in their Define() and DefineMethods() methods.
25850 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25851 generic methods for Define() and DefineMethods().
25852 (FieldBase): Derive from MemberBase, not MemberCore.
25853 (Property): Derive from MemberBase, not MemberCore.
25854 (Property.DefineMethod): Moved all the code from this method to the
25855 new MethodBase.DefineAccessor(), just call it with appropriate
25857 (Property.Define): Call the new Property.DoDefine(), this does some
25858 sanity checks and we don't need to duplicate the code everywhere.
25859 (Event): Derive from MemberBase, not MemberCore.
25860 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25861 accessors, this will also make them work with interface events.
25862 (Indexer): Derive from MemberBase, not MemberCore.
25863 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25864 (Indexer.Define): Use the new MethodBase functions.
25866 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25867 argument to the constructor.
25868 (Interface.FindMembers): Added support for interface events.
25869 (Interface.PopluateEvent): Implemented.
25871 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25873 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25875 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25876 but this is required to check for a method name being the same as
25877 the containing class.
25881 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25883 * interface.cs: initialize variable.
25885 2002-07-23 Martin Baulig <martin@gnome.org>
25887 Implemented the IndexerName attribute in interfaces.
25889 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25890 name if this is an explicit interface implementation.
25891 (Indexer.InterfaceIndexerName): New public variable. If we're
25892 implementing an interface indexer, this is the IndexerName in that
25893 interface. Otherwise, it's the IndexerName.
25894 (Indexer.DefineMethod): If we're implementing interface indexer,
25895 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25896 and Pending.ImplementIndexer methods.
25897 (Indexer.Define): Also define the PropertyBuilder if we're
25898 implementing an interface indexer and this is neither an explicit
25899 interface implementation nor do the IndexerName match the one in
25902 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25903 If a method is defined here, then we always need to create a proxy
25904 for it. This is used when implementing interface indexers.
25905 (Pending.IsInterfaceIndexer): New public method.
25906 (Pending.ImplementIndexer): New public method.
25907 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25908 This is used when implementing interface indexers to define a proxy
25910 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25911 define a proxy if necessary.
25913 * interface.cs (Interface.IndexerName): New public variable.
25914 (Interface.PopulateIndexer): Set the IndexerName.
25915 (Interface.DefineIndexers): New private method. Populate all the
25916 indexers and make sure their IndexerNames match.
25918 * typemanager.cs (IndexerPropertyName): Added support for interface
25921 2002-07-22 Martin Baulig <martin@gnome.org>
25923 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25924 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25925 ret if HasReturnLabel.
25926 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25929 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25930 and set the ec.LoopBeginTryCatchLevel.
25931 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25932 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25933 the current ec.TryCatchLevel, the branch goes out of an exception
25934 block. In this case, we need to use Leave and not Br.
25936 2002-07-22 Martin Baulig <martin@gnome.org>
25938 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25939 block unless the block does not always return or it is contained in
25940 another try { ... } catch { ... } block. Fixes bug #26506.
25941 Added verify-1.cs to the test suite.
25943 2002-07-22 Martin Baulig <martin@gnome.org>
25945 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25946 then we do not always return. Fixes bug #24985.
25948 2002-07-22 Martin Baulig <martin@gnome.org>
25950 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25951 lookup on a per-class level; ie. walk up the class hierarchy until we
25952 found at least one applicable method, then choose the best among them.
25953 Fixes bug #24463 and test-29.cs.
25955 2002-07-22 Martin Baulig <martin@gnome.org>
25957 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25958 return types of the methods. The return type is not part of the
25959 signature and we must not check it to make the `new' modifier work.
25960 Fixes bug #27999, also added test-147.cs.
25961 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25963 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25964 on the method's return type.
25966 2002-07-21 Martin Baulig <martin@gnome.org>
25968 * assign.cs: Make this work if the rightmost source is a constant and
25969 we need to do an implicit type conversion. Also adding a few more tests
25970 to test-38.cs which should have caught this.
25972 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25973 target in the makefile for this. The makefile.gnu is primarily intended
25974 for end-users who don't want to debug the compiler.
25976 2002-07-21 Martin Baulig <martin@gnome.org>
25978 * assign.cs: Improved the Assign class so it can now handle embedded
25979 assignments (X = Y = Z = something). As a side-effect this'll now also
25980 consume less local variables. test-38.cs now passes with MCS, added
25981 a few new test cases to that test.
25983 2002-07-20 Martin Baulig <martin@gnome.org>
25985 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25986 instructions. Fixes bug #27977, also added test-146.cs.
25988 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25990 * cs-tokenizer.cs: fixed getHex ().
25992 2002-07-19 Martin Baulig <martin@gnome.org>
25994 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25995 not Type.GetType() to lookup the array type. This is needed when
25996 we're constructing an array of a user-defined type.
25997 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25998 single-dimensional arrays, but also for single-dimensial arrays of
26001 2002-07-19 Martin Baulig <martin@gnome.org>
26003 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
26004 this function is called, it's not allowed to share LocalBuilders
26005 among ILGenerators.
26007 2002-07-19 Martin Baulig <martin@gnome.org>
26009 * expression.cs (Argument.Resolve): Report an error 118 when trying
26010 to pass a type as argument.
26012 2002-07-18 Martin Baulig <martin@gnome.org>
26014 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
26015 Conv_R_Un for the signed `long' type.
26017 2002-07-15 Miguel de Icaza <miguel@ximian.com>
26019 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
26020 `expr' for the temporary result, as that will fail if we do
26021 multiple resolves on the same expression.
26023 2002-07-05 Miguel de Icaza <miguel@ximian.com>
26025 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
26026 ec.TypeContainer for looking up aliases.
26028 * class.cs (TypeContainer): Remove LookupAlias from here.
26030 * decl.cs (DeclSpace); Move here.
26032 2002-07-01 Miguel de Icaza <miguel@ximian.com>
26034 * class.cs (FindMembers): Only call filter if the constructor
26035 bulider is not null.
26037 Also handle delegates in `NestedTypes' now. Now we will perform
26038 type lookups using the standard resolution process. This also
26041 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
26042 This uses Expressions (the limited kind that can be parsed by the
26043 tree) instead of strings.
26045 * expression.cs (ComposedCast.ToString): Implement, used to flag
26046 errors since now we have to render expressions.
26048 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
26051 * ecore.cs (SimpleName.ToString): ditto.
26053 * cs-parser.jay: Instead of using strings to assemble types, use
26054 Expressions to assemble the type (using SimpleName, ComposedCast,
26055 MemberAccess). This should fix the type lookups in declarations,
26056 because we were using a different code path for this.
26058 * statement.cs (Block.Resolve): Continue processing statements
26059 even when there is an error.
26061 2002-07-17 Miguel de Icaza <miguel@ximian.com>
26063 * class.cs (Event.Define): Also remove the `remove' method from
26064 the list of pending items.
26066 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
26067 generate more compact code.
26069 2002-07-17 Martin Baulig <martin@gnome.org>
26071 * const.cs (Const.LookupConstantValue): Add support for constant
26072 `unchecked' and `checked' expressions.
26073 Also adding test case test-140.cs for this.
26075 2002-07-17 Martin Baulig <martin@gnome.org>
26077 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
26078 check whether mi.ReturnType implements the IEnumerator interface; the
26079 `==' and the IsAssignableFrom() will fail in this situation.
26081 2002-07-16 Ravi Pratap <ravi@ximian.com>
26083 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
26086 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26088 * expression.cs: fixed bug #27811.
26090 2002-07-14 Miguel de Icaza <miguel@ximian.com>
26092 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
26093 Molaro: when we are a ref, the value already contains a pointer
26094 value, do not take the address of it.
26096 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26097 * removed mb-parser.jay and mb-tokenizer.cs
26099 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26101 * expression.cs: check against the building corlib void type.
26103 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
26105 * ecore.cs: fix for valuetype static readonly fields: when
26106 initializing them, we need their address, not the address of a copy.
26108 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
26110 * typemanager.cs: register also enum_type in corlib.
26112 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26114 * class.cs: allow calling this (but not base) initializers in structs.
26116 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
26118 * ecore.cs: make sure we compare against the building base types
26121 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
26123 * typemanager.cs: fix TypeToCoreType() to handle void and object
26124 (corlib gets no more typerefs after this change).
26126 2002-07-12 Miguel de Icaza <miguel@ximian.com>
26128 * expression.cs (ArrayCreation.EmitArrayArguments): use
26129 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
26131 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
26132 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
26133 array indexes, the runtime actually forbids them.
26135 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
26136 for array arguments here.
26138 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
26139 instead of the default for ValueTypes.
26141 (New.DoEmit): Use IsValueType instead of
26142 IsSubclassOf (value_type)
26143 (New.DoResolve): ditto.
26144 (Invocation.EmitCall): ditto.
26146 * assign.cs (Assign): ditto.
26148 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
26149 Statements *are* currently doing part of their resolution during
26152 Expressions do always resolve during resolve, but statements are
26153 only required to propagate resolution to their children.
26155 2002-07-11 Miguel de Icaza <miguel@ximian.com>
26157 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
26159 (LoadAssembly): Do not add the dll if it is already specified
26161 (MainDriver): Add the System directory to the link path at the end,
26162 after all the other -L arguments.
26164 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
26165 wrong opcode for loading bytes and bools (ldelem.i1 instead of
26166 ldelem.u1) and using the opposite for sbytes.
26168 This fixes Digger, and we can finally run it.
26170 * driver.cs (UnixParseOption): Move the option parsing here.
26171 (CSCParseOption): Implement CSC-like parsing of options.
26173 We now support both modes of operation, the old Unix way, and the
26174 new CSC-like way. This should help those who wanted to make cross
26175 platform makefiles.
26177 The only thing broken is that /r:, /reference: and /lib: are not
26178 implemented, because I want to make those have the same semantics
26179 as the CSC compiler has, and kill once and for all the confussion
26180 around this. Will be doing this tomorrow.
26182 * statement.cs (Unsafe.Resolve): The state is checked during
26183 resolve, not emit, so we have to set the flags for IsUnsfe here.
26185 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26187 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
26188 not catch the Error_ObjectRefRequired in SimpleName (as it is
26189 possible to have a class/instance variable name that later gets
26190 deambiguated), we have to check this here.
26192 2002-07-10 Ravi Pratap <ravi@ximian.com>
26194 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
26195 make static and put into Expression.
26197 (Event.Define): Register the private field of the event with the
26198 TypeManager so that GetFieldFromEvent can get at it.
26200 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
26201 keep track of the private field associated with an event which
26204 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
26207 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
26209 2002-07-10 Miguel de Icaza <miguel@ximian.com>
26211 * expression.cs (Binary.EmitBranchable): this routine emits the
26212 Binary expression in a branchable context. This basically means:
26213 we need to branch somewhere, not just get the value on the stack.
26215 This works together with Statement.EmitBoolExpression.
26217 * statement.cs (Statement.EmitBoolExpression): Use
26220 2002-07-09 Miguel de Icaza <miguel@ximian.com>
26222 * statement.cs (For): Reduce the number of jumps in loops.
26224 (For): Implement loop inversion for the For statement.
26226 (Break): We can be breaking out of a Try/Catch controlled section
26227 (foreach might have an implicit try/catch clause), so we need to
26228 use Leave instead of Br.
26230 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
26231 now). If the instace expression supports IMemoryLocation, we use
26232 the AddressOf method from the IMemoryLocation to extract the
26233 address instead of emitting the instance.
26235 This showed up with `This', as we were emitting the instance
26236 always (Emit) instead of the Address of This. Particularly
26237 interesting when This is a value type, as we dont want the Emit
26238 effect (which was to load the object).
26240 2002-07-08 Miguel de Icaza <miguel@ximian.com>
26242 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
26244 * statement.cs (Checked): Set the CheckedState during the resolve
26245 process too, as the ConvCast operations track the checked state on
26246 the resolve process, and not emit.
26248 * cs-parser.jay (namespace_member_declaration): Flag that we have
26249 found a declaration when we do. This is used to flag error 1529
26251 * driver.cs: Report ok when we display the help only.
26253 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
26255 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
26257 2002-07-04 Miguel de Icaza <miguel@ximian.com>
26259 * cs-tokenizer.cs (define): We also have to track locally the
26260 defines. AllDefines is just used for the Conditional Attribute,
26261 but we also need the local defines for the current source code.
26263 2002-07-03 Miguel de Icaza <miguel@ximian.com>
26265 * statement.cs (While, For, Do): These loops can exit through a
26266 Break statement, use this information to tell whether the
26267 statement is the last piece of code.
26269 (Break): Flag that we break.
26271 * codegen.cs (EmitContexts): New `Breaks' state variable.
26273 2002-07-03 Martin Baulig <martin@gnome.org>
26275 * class.cs (TypeContainer.MethodModifiersValid): Allow override
26276 modifiers in method declarations in structs. Otherwise, you won't
26277 be able to override things like Object.Equals().
26279 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26281 * class.cs (Method, Property, Indexer): Do not allow the public
26282 modifier to be used in explicit interface implementations.
26284 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
26285 override modifiers in method declarations in structs
26287 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
26289 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
26290 integer or real overflow, report an error
26292 2002-07-02 Martin Baulig <martin@gnome.org>
26294 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
26295 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
26296 to tell the runtime about our newly created System.Object and
26297 System.ValueType types.
26299 2002-07-02 Miguel de Icaza <miguel@ximian.com>
26301 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
26302 struct instead of Ldarg/Starg.
26304 2002-07-02 Martin Baulig <martin@gnome.org>
26306 * expression.cs (Indirection.Indirection): Call
26307 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
26309 2002-07-02 Martin Baulig <martin@gnome.org>
26311 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
26312 ValueType, call TypeManager.TypeToCoreType() on it.
26313 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
26314 the OpCodes.Newarr argument.
26316 2002-07-02 Martin Baulig <martin@gnome.org>
26318 * expression.cs (Invocation.EmitCall): When compiling corlib,
26319 replace all calls to the system's System.Array type to calls to
26320 the newly created one.
26322 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
26323 System.Array methods.
26324 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
26325 from the system's System.Array type which must be replaced.
26327 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
26329 * typemanager.cs: load unverifiable_code_ctor so we can build
26330 corlib using the correct type. Avoid using GetTypeCode() with
26332 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
26333 TypeManager.object_type to allow building corlib.
26335 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
26337 * ecore.cs: handle System.Enum separately in LoadFromPtr().
26339 2002-07-01 Martin Baulig <martin@gnome.org>
26341 * class.cs: Make the last change actually work, we need to check
26342 whether `ifaces != null' to avoid a crash.
26344 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
26346 * class.cs: when we build structs without fields that implement
26347 interfaces, we need to add the interfaces separately, since there is
26348 no API to both set the size and add the interfaces at type creation
26351 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
26353 * expression.cs: the dimension arguments to the array constructors
26354 need to be converted if they are a long.
26356 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
26358 * class.cs: don't emit ldarg.0 if there is no parent constructor
26359 (fixes showstopper for corlib).
26361 2002-06-29 Martin Baulig <martin@gnome.org>
26363 MCS now compiles corlib on GNU/Linux :-)
26365 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26366 ie. check for MethodImplOptions.InternalCall.
26368 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26369 and TypeManager.attribute_type are null, so we must explicitly check
26370 whether parent is not null to find out whether it's an attribute type.
26371 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26372 and SetBuilder, not only if the property is neither abstract nor external.
26373 This is necessary to set the MethodImplOptions on the accessor methods.
26374 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26375 SetBuilder, see Property.Emit().
26377 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26378 populate "System.Object", "System.ValueType" and "System.Attribute" since
26379 they've already been populated from BootCorlib_PopulateCoreTypes().
26381 2002-06-29 Martin Baulig <martin@gnome.org>
26383 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26384 is the NullLiteral, we also need to make sure that target_type is not
26387 2002-06-29 Martin Baulig <martin@gnome.org>
26389 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26390 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26391 before calling BootstrapCorlib_ResolveDelegate ().
26393 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26395 * statement.cs: fixed build-breaker. All tests passed ok.
26397 2002-06-27 Martin Baulig <martin@gnome.org>
26399 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26400 for System.Decimal when compiling corlib.
26402 2002-06-27 Martin Baulig <martin@gnome.org>
26404 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26405 switch blocks which contain nothing but a default clause.
26407 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26409 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26411 2002-06-27 Martin Baulig <martin@gnome.org>
26413 * ecore.cs (PropertyExpr.PropertyExpr): Call
26414 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26416 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26417 is already a TypeBuilder.
26419 2002-06-27 Martin Baulig <martin@gnome.org>
26421 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26422 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26423 the "from an array-type to System.Array" case. This makes it work
26424 when compiling corlib.
26426 2002-06-27 Martin Baulig <martin@gnome.org>
26428 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26429 non-static PropertyExpr, set its InstanceExpression. This makes
26430 the `ICollection.Count' property work in System/Array.cs.
26432 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26434 * driver.cs: Made error handling more consistent. Errors now
26435 tracked by Report class, so many methods which used to return int
26436 now return void. Main() now prints success/failure and
26437 errors/warnings message.
26439 Renamed '--probe' compiler argument to '--expect-error'. Removed
26440 the magic number return values (123 and 124). Now, if the
26441 expected error occurs, the compiler exits with success (exit value
26442 0). If the compilation completes without seeing that particular
26443 error, the compiler exits with failure (exit value 1). The
26444 makefile in mcs/errors has been changed to handle the new behaviour.
26446 * report.cs: Made 'expected error' number a property and renamed
26447 it from 'Probe' to 'ExpectedError'.
26449 * genericparser.cs: Removed error handling support, since it is
26450 now all done by Report class.
26452 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26453 class, so parse() no longer returns an int.
26455 * namespace.cs: Use Report.Error instead of GenericParser.error
26457 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26459 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26460 TypeContainer.AddOperator): At the front of the list put the
26461 explicit implementations, so they get resolved/defined first.
26463 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26465 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26466 interface type is implemented by this TypeContainer. Used during
26467 explicit interface implementation.
26469 (Property.Define, Indexer.Define, Method.Define): Validate that
26470 the given interface in the explicit implementation is one of the
26471 base classes for the containing type.
26473 Also if we are explicitly implementing an interface, but there is
26474 no match in the pending implementation table, report an error.
26476 (Property.Define): Only define the property if we are
26477 not explicitly implementing a property from an interface. Use the
26478 correct name also for those properties (the same CSC uses,
26479 although that is really not needed).
26481 (Property.Emit): Do not emit attributes for explicitly implemented
26482 properties, as there is no TypeBuilder.
26484 (Indexer.Emit): ditto.
26486 Hiding then means that we do not really *implement* a pending
26487 implementation, which makes code fail.
26489 2002-06-22 Martin Baulig <martin@gnome.org>
26491 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26492 the return value of Object.GetType(). [FIXME: we need to do this whenever
26493 we get a type back from the reflection library].
26495 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26497 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26499 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26501 * attribute.cs: Return null if we can not look up the type.
26503 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26504 the interface types found.
26506 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26507 interface types found.
26509 * typemanager.cs (GetInterfaces): Make this routine returns alll
26510 the interfaces and work around the lame differences between
26511 System.Type and System.Reflection.Emit.TypeBuilder in the results
26512 result for GetInterfaces.
26514 (ExpandInterfaces): Given an array of interface types, expand and
26515 eliminate repeated ocurrences of an interface. This expands in
26516 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26519 2002-06-21 Martin Baulig <martin@gnome.org>
26521 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26524 2002-06-21 Martin Baulig <martin@gnome.org>
26526 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26527 and called with one of the core types, return the corresponding typebuilder for
26530 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26533 2002-06-21 Martin Baulig <martin@gnome.org>
26535 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26536 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26537 (Expression.ConvertReferenceExplicit): Likewise.
26539 * expression.cs (ElementAccess.DoResolve): Likewise.
26540 (ElementAccess.DoResolveLValue): Likewise.
26542 2002-06-10 Martin Baulig <martin@gnome.org>
26544 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26545 add the "value" parameter to the parameter list.
26547 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26550 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26552 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26553 the argument to an int, uint, long or ulong, per the spec. Also
26554 catch negative constants in array creation.
26556 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26558 * class.cs: do not allow the same interface to appear twice in
26559 the definition list.
26561 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26563 * ecore.cs: don't use ldlen with System.Array.
26565 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26567 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26569 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26571 * modifiers.cs: produce correct field attributes for protected
26572 internal. Easy fix so miguel can work on ther harder stuff:-)
26574 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26576 * pending.cs: New file. Move the code from class.cs here.
26577 Support clearning the pending flag for all methods (when not doing
26578 explicit interface implementation).
26580 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26582 * rootcontext.cs: added a couple more types needed to bootstrap.
26584 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26586 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26587 constructor in the type, instead of any constructor in the type
26588 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26589 a bug in the Mono runtime when applying the params attribute).
26591 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26592 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26594 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26596 * expression.cs (Unary.ResolveOperator): Use TypeManager
26597 to resolve the type.
26599 2002-06-13 Ravi Pratap <ravi@ximian.com>
26601 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26604 * enum.cs (AddEnumMember): Add support to store the attributes associated
26605 with each member too.
26607 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26608 field builders too - this takes care of the enum member case.
26610 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26612 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26613 address-of operator on both value types and pointers.
26615 2002-06-10 Martin Baulig <martin@gnome.org>
26617 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26618 PropertyBuilder to the `property_builders' list.
26620 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26621 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26622 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26623 find any indexers which are inherited from an interface.
26625 2002-06-09 Martin Baulig <martin@gnome.org>
26627 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26628 the same type as the constant if necessary. There's also a test-130.cs
26631 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26633 * typemanager.cs (TypeManager.ChangeType): Previously known as
26634 Enum.ChangeEnumType().
26636 2002-06-09 Martin Baulig <martin@gnome.org>
26638 * expression.cs (Cast.TryReduce): Added support for consts.
26640 2002-06-08 Ravi Pratap <ravi@ximian.com>
26642 * class.cs (Accessor): Hold attributes information so we can pass
26645 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26646 Modify to pass in attributes attached to the methods.
26648 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26650 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26651 to handle the Accessor kind :-)
26653 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26655 2002-06-08 Martin Baulig <martin@gnome.org>
26657 * expression.cs (Unary.TryReduceNegative): Added support for
26660 2002-06-08 Martin Baulig <martin@gnome.org>
26662 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26663 name can't be found in the `defined_names' - the caller will do a
26664 MemberLookup in this case and thus find methods in System.Enum
26665 such as Enum.IsDefined().
26667 2002-06-08 Martin Baulig <martin@gnome.org>
26669 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26670 Convert.ChangeType() which works with TypeBuilder created types.
26671 (Enum.LookupEnumValue, Enum.Define): Use it here.
26673 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26674 `TypeBuilder.BaseType != null' check.
26675 (TypeContainer.FindMembers): Only lookup parent members if we
26676 actually have a parent.
26677 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26678 (ConstructorInitializer.Resolve): Likewise.
26680 * interface.cs (Interface.FindMembers): Added
26681 `TypeBuilder.BaseType != null' check.
26683 * rootcontext.cs (RootContext.ResolveCore): Added
26684 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26685 classes_second_stage.
26687 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26688 debug_type and trace_type when compiling with --nostdlib.
26690 2002-06-07 Martin Baulig <martin@gnome.org>
26692 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26693 (AddField): Set it to true when adding a non-static field.
26694 (DefineType): Use `have_nonstatic_fields' to find out whether we
26695 have non-static fields, not `Fields != null'.
26697 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26699 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26700 dereferencing a null on the static-field code path)
26702 2002-05-30 Martin Baulig <martin@gnome.org>
26704 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26705 to take command line arguments. Use reflection to call the new
26706 custom `Initialize' function on the symbol writer and pass it the
26707 command line arguments.
26709 * driver.cs (--debug-args): New command line argument to pass command
26710 line arguments to the symbol writer.
26712 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26714 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26715 the target type for indexers and properties. Thanks to Joe for
26718 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26720 * typemanager.cs (MethodFlags): returns the method flags
26721 (Obsolete/ShouldIgnore) that control warning emission and whether
26722 the invocation should be made, or ignored.
26724 * expression.cs (Invocation.Emit): Remove previous hack, we should
26725 not do this on matching a base type, we should do this based on an attribute
26727 Only emit calls to System.Diagnostics.Debug and
26728 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26729 on the command line.
26731 * rootcontext.cs: Global settings for tracing and debugging.
26733 * cs-tokenizer.cs (define): New utility function to track
26734 defines. Set the global settings for TRACE and DEBUG if found.
26736 2002-05-25 Ravi Pratap <ravi@ximian.com>
26738 * interface.cs (Populate*): Pass in the TypeContainer as well as
26739 the DeclSpace as parameters so that we can create EmitContexts and
26740 then use that to apply attributes etc.
26742 (PopulateMethod, PopulateEvent, PopulateProperty)
26743 (PopulateIndexer): Apply attributes everywhere.
26745 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26748 (ApplyAttributes): Update accordingly.
26750 We now apply interface attributes for all members too.
26752 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26754 * class.cs (Indexer.Define); Correctly check if we are explicit
26755 implementation (instead of checking the Name for a ".", we
26756 directly look up if the InterfaceType was specified).
26758 Delay the creation of the PropertyBuilder.
26760 Only create the PropertyBuilder if we are not an explicit
26761 interface implementation. This means that explicit interface
26762 implementation members do not participate in regular function
26763 lookups, and hence fixes another major ambiguity problem in
26764 overload resolution (that was the visible effect).
26766 (DefineMethod): Return whether we are doing an interface
26769 * typemanager.cs: Temporary hack until we get attributes in
26770 interfaces (Ravi is working on that) and we get IndexerName
26771 support in interfaces.
26773 * interface.cs: Register the indexers as properties.
26775 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26776 warning, I have verified that this is a bug in the .NET runtime
26777 (JavaScript suffers of the same problem).
26779 * typemanager.cs (MemberLookup): When looking up members for
26780 interfaces, the parent of an interface is the implicit
26781 System.Object (so we succeed in searches of Object methods in an
26782 interface method invocation. Example: IEnumerable x; x.ToString
26785 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26787 * class.cs (Event): Events should also register if they do
26788 implement the methods that an interface requires.
26790 * typemanager.cs (MemberLookup); use the new GetInterfaces
26793 (GetInterfaces): The code used to lookup interfaces for a type is
26794 used in more than one place, factor it here.
26796 * driver.cs: Track the errors at the bottom of the file, we kept
26799 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26800 instance if the method we are calling is static!
26802 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26804 * attribute.cs (ApplyAttributes): Make this function filter out
26805 the IndexerName attribute (as that attribute in reality is never
26806 applied) and return the string constant for the IndexerName
26809 * class.cs (TypeContainer.Emit): Validate that all the indexers
26810 have the same IndexerName attribute, and if so, set the
26811 DefaultName attribute on the class.
26813 * typemanager.cs: The return value might contain other stuff (not
26814 only methods). For instance, consider a method with an "Item"
26815 property and an Item method.
26817 * class.cs: If there is a problem with the parameter types,
26820 2002-05-24 Ravi Pratap <ravi@ximian.com>
26822 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26823 looks at user defined conversion after making a call to
26824 StandardConversionExists - we need this for overload resolution.
26826 * expression.cs : Update accordingly the various method calls.
26828 This fixes 2 bugs filed against implicit user defined conversions
26830 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26832 * statement.cs: Track the result of the assignment.
26834 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26836 * expression.cs (MemberAccess): Improved error reporting for
26837 inaccessible members.
26839 2002-05-22 Martin Baulig <martin@gnome.org>
26841 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26842 itself with debugging support.
26844 2002-05-22 Martin Baulig <martin@gnome.org>
26846 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26847 Removed, this isn't needed anymore.
26849 2002-05-20 Martin Baulig <martin@gnome.org>
26851 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26852 be underlying type for an enum.
26854 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26856 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26857 that splits out the loading of just the core types.
26859 * rootcontext.cs (ResolveCore): Split the struct resolution in
26860 two, so we can load the enumeration underlying types before any
26863 * expression.cs (Is): Bandaid until we fix properly Switch (see
26864 bug #24985 for details).
26866 * typemanager.cs (ImplementsInterface): The hashtable will contain
26867 a null if there are no interfaces implemented.
26869 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26871 * cs-parser.jay (indexer_declarator): It is fine to have array
26874 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26876 * typemanager.cs: (RegisterBuilder): New function used to register
26877 TypeBuilders that implement interfaces. Since
26878 TypeBuilder.GetInterfaces (as usual) does not work with lame
26880 (AddUserType): register interfaces.
26882 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26883 dealing with TypeBuilder. Also, arrays are showing up as
26884 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26885 methods can not be invoked on them!
26887 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26888 (ImplicitReferenceConversionExists): Split out from
26889 StandardConversionExists.
26891 * expression.cs (As): We were only implementing one of the three
26892 cases for the as operator. We now implement them all.
26893 (Is): Implement the various other cases for Is as well.
26895 * typemanager.cs (CACHE): New define used to control if we want or
26896 not the FindMembers cache. Seems to have a negative impact on
26897 performance currently
26899 (MemberLookup): Nested types have full acess to
26900 enclosing type members
26902 Remove code that coped with instance/static returns for events, we
26903 now catch this in RealFindMembers.
26905 (RealFindMembers): only perform static lookup if the instance
26906 lookup did not return a type or an event.
26908 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26910 * assign.cs (CompoundAssign): We pass more semantic information
26911 now to Compound Assignments than we did before: now we have all
26912 the information at hand, and now we resolve the target *before* we
26913 do the expression expansion, which allows the "CacheValue" method
26914 to have the effect we intended (before, a [x] += 1 would generate
26915 two differen ArrayAccess expressions from the ElementAccess,
26916 during the resolution process).
26918 (CompoundAssign.DoResolve): Resolve target and original_source here.
26920 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26922 * expression.cs (ArrayAccess): dropped debugging information.
26924 * typemanager.cs: Small bug fix: I was always returning i_members,
26925 instead of one of i_members or s_members (depending on which had
26928 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26929 method is invoked before any code generation takes place, and it
26930 is a mechanism to inform that the expression will be invoked more
26931 than once, and that the method should use temporary values to
26932 avoid having side effects
26934 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26936 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26939 * expression.cs (Indirection, ArrayAccess): Add support for
26940 CacheTemporaries in these two bad boys.
26942 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26943 ldobj or ldind_ref.
26944 (StoreFromPtr): Handle stobj as well.
26946 * expression.cs (UnaryMutator): Share more code.
26948 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26949 down: I was not tracking the Filter function as well, which
26950 was affecting the results of the cache.
26952 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26954 * attribute.cs: Remove the hack to handle the CharSet property on
26957 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26959 * attribute.cs (DoResolve): More uglyness, we now only try to
26960 resolve the attribute partially, to extract the CharSet
26961 information (only if we are a StructLayout attribute). Otherwise
26963 (GetExtraTypeInfo): Add some code to conditionally kill in the
26964 future this. I am more and more convinced that the .NET
26965 framework has special code to handle the attribute setting on
26968 * expression.cs (IsParamsMethodApplicable): Revert my previous
26969 foreach change here, it was wrong.
26971 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26973 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26974 (pp_expr): do not abort on unknown input, just return.
26975 (eval): abort if there are pending chars.
26977 * attribute.cs (Attribute.Resolve): Positional parameters are
26978 optional. Deal with that case.
26980 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26981 the Ansi/Unicode/Auto information for the type.
26983 (TypeContainer.DefineType): instantiate the EmitContext here, as
26984 we will be using it during the type definition (to resolve
26985 attributes) and during the emit phase.
26987 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26988 to pull type information out of the attributes
26990 (Attribute.Resolve): track the constructor builder, and allow for
26991 multiple invocations (structs and classes will use this).
26993 * ecore.cs (MemberLookupFinal): new version with all the
26994 parameters customizable.
26996 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26997 constructors. Return if the result value is null (as the error
26998 would have been flagged already by MemberLookupFinal)
27000 Do not allow instances of abstract classes or interfaces to be
27003 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
27004 We have to compare the assembly property here when dealing with
27005 FamANDAssem and Assembly access modifiers, because we might be
27006 creating an assembly from *modules* (that means that we are not
27007 getting TypeBuilders for types defined in other modules that are
27008 part of this assembly).
27010 (Method.Emit): If the method is marked abstract and has a body,
27013 (TypeContainer.DefineMembers): If both the defined member and the
27014 parent name match are methods, then do not emit any warnings: let
27015 the Method.Define routine take care of flagging warnings. But if
27016 there is a mismatch (method overrides something else, or method is
27017 overriwritten by something, then emit warning).
27019 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
27020 set to null, this means `do not check for the return type on the
27023 (Method.Define): set the return type for the method signature to
27024 null, so that we get methods with the same name and parameters and
27025 different return types. This is used to flag warning 114 (you are
27026 hiding a method, and you probably want to use the new/override
27029 * typemanager.cs (MemberLookup): Implemented proper access
27030 control, closing a long standing set of bug reports. The problem
27031 was that the Framework only has two bits: Public and NonPublic,
27032 and NonPublic includes private and protected methods, but we need
27033 to enforce the FamANDAssem, FamOrAssem and Family.
27035 2002-05-11 Miguel de Icaza <miguel@ximian.com>
27037 * statement.cs (GotoCase): Return true: Ammounts to giving up
27038 knowledge on whether we return or not, and letting the other case
27039 be responsible for it.
27041 2002-05-10 Miguel de Icaza <miguel@ximian.com>
27043 * driver.cs: Do not load directories for each file processed, only
27044 do it if there is a pattern.
27046 * ecore.cs: Report readonly assigns here as well, as we might have
27047 been resolved only by MemberAccess.
27049 (SimpleName.SimpleNameResolve): Also be useful for LValue
27050 resolution. We need this to propagate assign to local readonly variables
27052 * typemanager.cs: Use a ptrhashtable for the criteria, because we
27053 do not want to reuse potential criteria memory.
27055 * class.cs (MyEventBuilder): Set reflected_type;
27057 * ecore.cs (Constantify): Added support for constifying bools.
27059 (RootContext.LookupType): Added a cache for values looked up in
27060 the declaration space.
27062 * typemanager.cs (FindMembers): Now is a front-end to
27063 RealFindMembers, and provides a two-level hashtable-based cache to
27066 15% performance improvement: from 22.5 to 19.2 seconds.
27068 * expression.cs (IsParamsMethodApplicable): use foreach.
27069 (Invocation.DoResolve): ditto.
27070 (New.DoResolve): ditto.
27071 (ArrayCreation.DoResolve): ditto.
27073 * ecore.cs (FindMostEncompassingType): use foreach.
27075 * delegate.cs (NewDelegate.DoResolve): Use foreach
27077 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
27078 (RemoveMethods): use foreach.
27080 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
27081 nested foreach statements instead of for, and also break out of
27082 the inner loop once a match is found.
27084 (Invocation.OverloadResolve): Use foreach, simplify the code.
27086 2002-05-08 Miguel de Icaza <miguel@ximian.com>
27088 * cfold.cs (BinaryFold): During an enumeration evaluation context,
27089 we actually unwrap the expression to allow for extra information
27092 * expression.cs: Use Shr_Un on unsigned operations.
27094 2002-05-08 Ravi Pratap <ravi@ximian.com>
27096 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
27097 applicable operators was not being considered correctly. This closes
27098 the bug Miguel reported.
27100 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
27102 * attribute.cs: check that the type derives from System.Attribute
27103 and report the correct error in that case (moved the duplicate code to
27104 its own method, too).
27106 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
27108 * attribute.cs: lookup attribute type name as the spec says: first the
27109 bare attribute name and then name + "Attribute" (nant compiles with
27110 mcs after this fix).
27112 2002-05-07 Miguel de Icaza <miguel@ximian.com>
27114 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
27115 Because of the way we parse things, we should try to see if a
27116 UIntConstant can fit in an integer.
27118 2002-05-07 Ravi Pratap <ravi@ximian.com>
27120 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
27121 when we are in an explicit context.
27123 (ConvertReferenceExplicit): When converting from Iface type S to Class
27124 T make sure the rules are implemented as an OR.
27126 * parameter.cs (ParameterType): Make it a property for now although the
27127 purpose really isn't anything immediate.
27129 * expression.cs (Is*Applicable): Do better checking on the parameter type
27130 of a ref/out parameter. The ones from the system assemblies are already
27131 marked with the correct type so we don't need to do any correction.
27133 * ecore.cs (StandardConversionExists): Conversion from Interface types to
27134 the object type is standard too so include that.
27136 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27138 * ecore.cs (StandardConversionExists): Augment with missing code:
27139 deal with IntConstant, LongConstants and Enumerations.
27141 * assign.cs: Report the error, instead of failing silently
27143 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
27144 typecontainer that they are declared, because the
27145 typecontainer/namespace will have the list of using clauses that
27146 need to be applied.
27148 Assembly Attributes were escaping the normal registration
27151 (EmitCode): Apply attributes within an EmitContext that represents
27152 the container they were declared on.
27154 * cs-parser.jay: Track bases for structs. How did I get this wrong?
27156 2002-05-06 Ravi Pratap <ravi@ximian.com>
27158 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
27159 Revamp completely - make much cleaner as we now operate only
27162 (FindMostSpecificSource, FindMostSpecificTarget): New methods
27163 to implement the logic detailed in the spec more correctly.
27165 (UserDefinedConversion): Update accordingly.
27167 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27169 * statement.cs: Return flow analysis information up.
27171 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
27174 (token): Do not consume an extra character before calling
27177 2002-05-06 Piers Haken <piersh@friskit.com>
27179 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
27181 2002-05-06 Miguel de Icaza <miguel@ximian.com>
27183 * class.cs (Constructor.Emit): Set the IsStatic flag in the
27184 EmitContext during the instance constructor initializer
27185 resolution, to stop access to instance variables.
27187 This is mandated by the spec, last paragraph of the `constructor
27188 initializers' section.
27190 2002-05-05 Miguel de Icaza <miguel@ximian.com>
27192 * cs-parser.jay, class.cs (Accessor): new class used to represent
27193 an accessor (get or set). In the past we used `null' to represent
27194 a missing accessor. But this is ambiguous because there was no
27195 way to tell in abstract indexers/properties if one of them was
27198 Now there is a way of addressing that.
27200 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
27201 instead of FindMembers.
27203 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
27204 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
27206 * attribute.cs: Treat indexers and properties as the same in terms
27207 of applying attributes
27209 * ecore.cs (FindMostEncompassedType): Use statically initialized
27210 EmptyExpressions()s like we do elsewhere to avoid creating useless
27211 objects (and we take this out of the tight loop).
27213 (GetConversionOperators): Move the code to extract the actual
27214 operators to a separate routine to clean things up.
27216 2002-05-04 Miguel de Icaza <miguel@ximian.com>
27218 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
27219 events are always registered FieldBuilders.
27221 * class.cs (FieldBase): New class shared by Fields
27223 * delegate.cs: If we are a toplevel delegate, use our full name.
27224 If we are a nested delegate, then only use our tail name.
27226 2002-05-02 Ravi Pratap <ravi@ximian.com>
27228 * expression.cs (IsApplicable): Ensure that we add the "&" to
27229 ref/out types before comparing it with the type of the argument.
27231 (IsParamsMethodApplicable): Ditto.
27233 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
27236 * delegate.cs : Handle the case when we have more than one applicable
27237 method. Flag an error only when we finish checking all.
27239 2002-05-02 Miguel de Icaza <miguel@ximian.com>
27241 * expression.cs: Add support for boolean static initializers.
27243 2002-05-01 Miguel de Icaza <miguel@ximian.com>
27245 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
27247 * parameter.cs (ComputeParameterTypes,
27248 ComputeAndDefineParameterTypes): Better error handling: now we
27249 clear the `types' cache if we fail during any of the type lookups.
27250 We also return the status code correctly to our caller
27252 * delegate.cs: If we fail to define a delegate, abort the extra
27255 * expression.cs (Binary.ResolveOperator): for
27256 operator==(object,object) and operator !=(object, object) we also
27257 have to verify that there is an implicit conversion from one to
27260 (ArrayAccess.DoResolve): Array Access can operate on
27263 2002-04-30 Miguel de Icaza <miguel@ximian.com>
27265 * assign.cs (CompoundAssign): A new class used as a "flag" that
27266 the assignment actually is happening as part of a compound
27267 assignment operator.
27269 During compound assignment, a few new rules exist to enable things
27276 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
27277 to the type of x) if y is implicitly convertible to the type of x,
27278 and the operator is a builtin operator and the return type of the
27279 operator is explicitly convertible to the type of x.
27281 * rootcontext.cs: Reset warning level to 2. 4 catches various
27282 "interesting" features in mcs, we must clean this up at some
27283 point, but currently am trying to kill other bugs ;-)
27285 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
27286 in container classes as well.
27288 * expression.cs (Binary.ResolveOperator): Handle string case
27289 before anything else (as operator overloading does emit an error
27290 before doing anything else).
27292 This code could go away when we move to a table driven model, but
27293 i could not come up with a good plan last night.
27295 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
27297 * typemanager.cs (CSharpName): reimplementation using regex.
27298 * class.cs: added null check for fields in Emit
27299 * rootcontext.cs: set warninglevel to 4
27301 2002-04-29 Miguel de Icaza <miguel@ximian.com>
27303 * typemanager.cs (CSharpName): reimplemented with Lupus
27306 2002-04-28 Miguel de Icaza <miguel@ximian.com>
27308 * statement.cs (If): correclty implement Resolve, because we were
27309 not catching sem errors in there. The same process is needed
27311 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
27314 (Statement.Warning_DeadCodeFound): Factorize code.
27315 (While): Report dead code here too.
27317 (Statement): Added Resolve virtual method to allow
27318 for resolution split from the emit code.
27320 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27322 * statement.cs (EmitBoolExpression): No longer try to resolve the
27324 (MakeBoolean): New utility function that resolve, implicitly
27325 converts to boolean and tags the expression.
27328 (If, Do): Implement dead code elimination.
27329 (While): Implement loop inversion
27331 (Do, While, For, If): Resolve the expression prior to calling our
27334 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
27337 - added method Report28 (warning: program has more than one entry point)
27338 - added method IsEntryPoint, implements paragraph 10.1 of the spec
27339 - modified method Method.Define, the part at the end of the method
27341 * rootcontext.cs: added static public Location EntryPointLocation;
27343 * ../errors/cs0028.cs : Add test case for the above warning.
27346 - modified method CSharpName to allow arrays of primitive type to
27347 be printed nicely (e.g. instead of System.Int32[][] it now prints
27349 - added method CSharpSignature: returns the signature of a method
27350 in string format to be used in reporting errors, warnings, etc.
27352 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
27355 2002-04-26 Ravi Pratap <ravi@ximian.com>
27357 * delegate.cs (Define): Fix extremely silly bug where I was
27358 setting the type of the 'object' parameter of the BeginInvoke
27359 method to System.IAsyncResult instead of System.Object ;-)
27361 2002-04-26 Miguel de Icaza <miguel@ximian.com>
27363 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27366 (Constructor.Emit): return if we fail to initialize the
27367 constructor. Another door closed!
27369 * expression.cs (New.DoResolve): Improve error message (from -6 to
27370 1501). Use DeclaredOnly lookup to find the exact constructor.
27372 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27373 loop. This is useful.
27375 * cs-parser.jay: Adjust the default parameters so that destructors
27376 have the proper signature.
27378 2002-04-26 Martin Baulig <martin@gnome.org>
27380 * driver.cs (LoadAssembly): If `assembly' contains any characters
27381 which are only valid in path names and not in assembly names
27382 (currently slash, backslash and point), use Assembly.LoadFrom ()
27383 instead of Assembly.Load () on the `assembly' (before iteration
27384 over the link_paths).
27386 2002-04-26 Martin Baulig <martin@gnome.org>
27388 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27390 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27392 * class.cs (Property): use the new typemanager.MemberLookup
27394 (TypeContainer.MemberLookup): Implement using the
27395 TypeManager.MemberLookup now.
27397 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27398 and return MemberInfos, so that these can be used without an
27399 EmitContext (what we had before).
27401 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27403 * expression.cs: Fix the case where the argument to params if the
27404 type of the params. I omitted handling this before. Fixed
27406 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27408 * driver.cs: Call BootCorlib_PopulateCoreType
27410 * class.cs (Property.CheckBase): Check for properties only, not
27413 * interface.cs: Temporary hack: try/catch around the
27414 CustomAttributeBuilder, because I am getting an exception that I
27417 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27418 types whose definitions are required to be there (attributes are
27419 defined before standard types).
27421 Compute definitions as we boot the various types, as they are used
27422 immediately (value_type class will need object_type, but if we do
27423 not initialize object_type, we will pass a null, which will let
27424 the runtime pick the System.Object from the existing corlib, which
27425 is not what we want).
27427 2002-04-22 Patrik Torstensson <totte@labs2.com>
27429 * cs-tokenizer.cs: fixed a number of trim() issues.
27431 2002-04-22 Ravi Pratap <ravi@ximian.com>
27433 * expression.cs (Argument.Type): Ensure that we return the correct
27434 type when we have out or ref parameters [in which case we
27437 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27439 * class.cs (Property, Indexer): Allow extern modifier in there.
27441 * typemanager.cs (InitBaseTypes): Initializes object_type and
27442 value_type, since those will be used early on during the bootstrap
27443 process to compile corlib.
27445 (InitCoreTypes): Move code from here to InitBaseTypes.
27447 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27449 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27450 single-dimension arrays as using the ldlen opcode.
27452 Daniel Lewis discovered this optimization.
27454 * typemanager.cs: Add signature for System.Array::get_Length
27456 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27458 * statement.cs: report the error when the foreach does not apply to an
27459 array nor a collection.
27461 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27463 * expression.cs: Add implicit conversions to the operator ~.
27465 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27467 * typemanager.cs: Locate the decimal constructor.
27469 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27471 * attribute.cs: use the new property of TypeOf.
27472 * expression.cs: added 'get' property around typearg.
27474 These changes fix a build breaker reported by NickD. Is this the
27475 correct way to fix? If not, please, revert my changes and make it
27478 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27480 * attribute.cs: Add support for typeof in attribute invocations.
27481 I am not sure that this is right though.
27483 2002-04-14 Duncan Mak <duncan@ximian.com>
27485 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27486 Binary.Operator.Division case.
27488 2002-04-13 Ravi Pratap <ravi@ximian.com>
27490 * class.cs (DefineType): Ensure that we do a proper check on
27491 attribute types and also register it with the TypeManager.
27493 (TypeContainer.Targets): The default for attribute types is
27494 AttributeTargets.All.
27496 * attribute.cs (ApplyAttributes): Registering the attribute type
27497 is done elsewhere, not when we discover we have a Usage attribute.
27499 2002-04-12 Ravi Pratap <ravi@ximian.com>
27501 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27502 and get rid of is_delegate parameter.
27504 * everywhere : update.
27506 2002-04-12 Ravi Pratap <ravi@ximian.com>
27508 * cs-parser.jay (compilation_unit): Revamp completely to use
27509 some new ideas that I got from Rhys' grammar to solve the problems
27510 with assembly level attributes.
27512 (outer_declaration): New grammar production.
27514 (attribute_sections): Add.
27516 (opt_attributes): Base on attribute_sections
27518 (namespace_declaration): Allow opt_attributes to tackle the case
27519 when we have assembly level attributes - we are clever in this
27522 * attribute.cs (ApplyAttributes): Do not worry about assembly
27523 attributes in the non-global context.
27525 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27526 instead of SetGlobalAttributes.
27528 * class.cs, rootcontext.cs : Ensure we define and generate
27529 attribute types before anything else.
27531 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27532 and flag the new error -20 for the case when the attribute type
27533 does not have valid targets specified. csc does not catch this.
27535 * ../errors/errors.txt : update for error # -20
27537 2002-04-11 Ravi Pratap <ravi@ximian.com>
27539 * support.cs (InternalParameters.ParameterModifier): Do some null
27540 checking and return sane values.
27542 * class.cs (Method.Define): If we are a PInvoke method, ensure
27543 that we are static and extern. Report error # 601
27545 * ../errors/cs0601.cs : Add test case for the above error.
27547 2002-04-07 Ravi Pratap <ravi@ximian.com>
27549 * rootcontext.cs (attribute_types): We need to keep type of
27550 all attribute types separately and emit code for them first.
27552 (RegisterAttribute) : Implement.
27554 * class.cs (DefineType): Check if the current Type is a custom
27555 attribute type and register it accordingly.
27557 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27558 adding the first attribute twice and rename to
27560 (SetGlobalAttributes): this.
27562 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27565 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27566 if we are processing global arguments. Hmm, I am unsure of this.
27568 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27570 * expression.cs: added static array of strings to avoid calling
27571 Enum.ToString () for Operator in Binary. Significant recover of
27574 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27576 * class.cs (FindMembers): Allow the Builders of the various
27577 members to be null. If they are skip them. This only happens
27578 during the PInvoke declaration.
27580 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27582 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27583 failure, so we do not keep going afterwards.
27585 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27586 wanted to pass `false' as the `is_delegate' argument. If this is
27587 the case, why not use delegate_type == null to mean `is_delegate =
27588 false' and anything else as is_delegate = true.
27590 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27592 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27593 code for the section, not the beginning of the tests.
27595 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27597 * cfold.cs: Handle operator + (Enum x, Underlying x)
27599 * expression.cs (Binary): same. Warn about errors where we have
27600 Enum/Enum in operator + as well.
27602 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27605 - added support for switch(bool)
27606 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27607 - add TableSwitchEmit() to handle table-based switch statements
27609 2002-04-05 Ravi Pratap <ravi@ximian.com>
27611 * expression.cs (Invocation.OverloadResolve): Factor out code which
27612 does parameter compatibility checking with arguments so that we can
27613 re-use the code even from Delegate.VerifyApplicability
27615 (VerifyArgumentsCompat): Move above code here.
27617 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27618 and instead make a call to the above method.
27620 2002-03-31 Ravi Pratap <ravi@ximian.com>
27622 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27623 We use it to keep track of classes which are attribute types.
27625 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27627 * delegate.cs (Delegate.Define): Correctly define the types in the
27628 presence of fixed and array parameters.
27630 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27633 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27634 include NonPublic after the first iteration.
27636 * class.cs (Indexer.CheckBase): Only check if both parents are
27639 * cs-parser.jay (accessor_body): If empty, set to null.
27641 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27642 same code path here to resolve constants names that we did have in
27643 MemberAccess.DoResolve. There is too much code duplicated here.
27645 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27647 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27649 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27652 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27653 tokens, numbers and strings.
27655 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27658 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27659 asyncronous parameters and the regular parameters.
27661 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27662 specify the target directory.
27664 * expression.cs: (This.DoResolve): Simplify
27665 (As.Emit): Optimize, do not generate IsInst if the expression is
27666 always of the given type.
27668 (Is.DoResolve): Bug fix, we were reporting both always/never for
27671 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27672 creating too many unnecessary arrays.
27674 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27676 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27677 fields instead of rolling our own initializer. Takes care of all
27678 implicit conversions, and drops unnecessary static checks/argument.
27680 2002-03-31 Dick Porter <dick@ximian.com>
27682 * driver.cs: use the GetDirectories() return values properly, and
27683 use "/" as path separator.
27685 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27687 * expression.cs (Unary): Optimize - - expr into expr.
27688 (Binary): Optimize a + (-b) into a -b.
27690 * codegen.cs (CodeGen): Made all methods static.
27692 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27696 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27697 TypeBuilder property.
27699 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27702 * tree.cs: Removed the various RecordXXXX, and replaced with a
27703 single RecordDecl. Removed all the accessor methods, and just
27704 left a single access point Type
27706 * enum.cs: Rename DefineEnum to DefineType.
27708 * decl.cs: New abstract method `DefineType' used to unify the
27709 Defines for Enumerations, Interfaces, TypeContainers and
27712 (FindType): Moved LookupInterfaceOrClass here. Moved the
27713 LookupBaseClasses method that used to live in class.cs and
27714 interface.cs here, and renamed to FindType.
27716 * delegate.cs: Implement DefineType. Take advantage of the
27717 refactored pattern for locating the parent builder without taking
27718 the parent_builder argument (which we know does not work if we are
27719 nested, and triggering a toplevel definition).
27721 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27723 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27724 accessibility of a member has changed during override and report
27727 * class.cs (Method.Define, Property.Define): Only complain on
27728 overrides if the method is private, any other accessibility is
27729 fine (and since we just checked the permission is the same, we are
27732 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27733 and elif are processed always. The other pre-processing
27734 directives are only processed if we are "taking" the path
27736 2002-03-29 Martin Baulig <martin@gnome.org>
27738 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27739 current location is not Null.
27741 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27742 a separate method so we can profile it.
27744 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27745 `span.Seconds' are just seconds, but no minutes or hours.
27746 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27748 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27750 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27751 Remove the gratuitous set of Final:
27753 // If an interface implementation, then we can set Final.
27754 if (((flags & MethodAttributes.Abstract) == 0) &&
27755 implementing.DeclaringType.IsInterface)
27756 flags |= MethodAttributes.Final;
27758 I do not know what I was smoking when I used that.
27761 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27762 step into fixing the name resolution issues for delegates and
27763 unifying the toplevel name resolution.
27765 2002-03-28 Martin Baulig <martin@gnome.org>
27767 * class.cs (Method.Emit): If we have a symbol writer, call its
27768 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27769 tell it about the current method.
27771 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27772 writer that we're going to emit the first byte of IL code for a new
27773 statement (a new source line).
27774 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27775 EmitContext.Mark() before emitting any code.
27777 * location.cs (SymbolDocument): Return null when we're Null.
27779 * statement.cs (Statement): Moved the `Location loc' variable here.
27780 (Statement.EmitBoolExpression): If we have a symbol writer, call
27781 ec.Mark() before emitting any code to tell it that we're at the
27782 beginning of a new statement.
27783 (StatementExpression): Added `Location' argument to the constructor.
27784 (Block): Added public readonly variable `StartLocation' and public
27785 variable `EndLocation'. The latter is to be set using SetEndLocation().
27786 (Block): Added constructor which takes a start and end location.
27787 (Block.SetEndLocation): New method. This sets the end location.
27788 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27789 local variables we create.
27790 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27791 each statement and do also mark the begin and end of the block.
27793 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27794 tell it the current lexer.Location, use Location.Null for the end of the
27796 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27797 current block, set its end location using SetEndLocation().
27798 (statement_expression): StatementExpression constructor now takes the
27799 lexer.Location as additional argument.
27800 (for_statement, declare_local_variables): Likewise.
27801 (declare_local_variables): When creating a new implicit block, use the
27802 new Block constructor and pass it the lexer.Location.
27804 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27806 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27807 members also on the parent interfaces recursively.
27809 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27811 * report.cs: Use new formats, since Gonzalo finished the missing
27814 * expression.cs (Binary.ResolveOperator): added missing operator|
27815 operator& and operator^ for bool/bool.
27817 * cs-parser.jay: CheckDef now takes a Location argument that is
27818 used to report errors more precisly (instead of reporting the end
27819 of a definition, we try to track something which is a lot closer
27820 to the source of the problem).
27822 * cs-tokenizer.cs: Track global token use, so we can properly flag
27823 the use of #define/#undef after the first token has been seen.
27825 Also, rename the reportXXXX to Error_DescriptiveName
27827 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27828 TypeContainer, so that Enum and Interface can use this too.
27830 * class.cs (TypeContainer.LookupInterfaceOrClass,
27831 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27832 `builder' argument. Typically this was used to pass the parent
27833 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27836 The problem is that a nested class could trigger the definition of
27837 a toplevel class, and the builder would be obviously wrong in that
27840 So we drop this argument, and we compute dynamically the
27841 TypeBuilder/ModuleBuilder (the correct information was available
27842 to us anyways from DeclSpace.Parent)
27844 * interface.cs (Interface.DefineInterface): Drop builder
27845 parameter cleanup like class.cs
27847 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27850 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27853 (Try.Emit): Propagate the returns value from the statement.
27855 (Return.Emit): Even if we are leavning
27857 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27859 * modifiers.cs: Fix the computation of MethodAttributes flags.
27861 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27863 * driver.cs: allow compilation of files that start with '/'.
27864 Add a default case when checking the argument of --target.
27866 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27868 * interface.cs: Implement the same search algorithm for types in
27869 the interface code.
27871 * delegate.cs: Do not allow multiple definition.
27873 * Recovered ChangeLog that got accidentally amputated
27875 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27877 * rootcontext.cs: Load manually enum to allow core classes to
27878 contain enumerations.
27880 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27881 Update to new static methods in TypeManager.
27883 * typemanager.cs (GetMethod, GetConstructor): Use our
27884 implementation of FindMembers to find the members, since during
27885 corlib compilation, the types are TypeBuilders and GetMethod and
27886 GetConstructor do not work.
27888 Make all methods in TypeManager static.
27890 (InitCodeHelpers): Split the functionality from
27891 the InitCodeTypes function.
27893 * driver.cs: Call InitCodeHelpers after we have populated the
27896 * cs-parser.jay (delegate_declaration): we did not used to compute
27897 the delegate name correctly for void delegates.
27899 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27901 * rootcontext.cs (RootContext): Init the interface_resolve_order
27902 and type_container_resolve_order always.
27904 (ResolveCore, BootstrapCorlib_ResolveClass,
27905 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27906 compiler when compiling with --nostdlib
27908 * class.cs (TypeContainer.DefineType): Check that our parent is
27909 not null. This test is most important when we are bootstraping
27912 * codegen.cs: Split out the symbol writing code.
27914 2002-03-25 Martin Baulig <martin@gnome.org>
27916 * driver.cs (-g): Made -g an alias for --debug.
27918 2002-03-24 Martin Baulig <martin@gnome.org>
27920 * codegen.cs (SymbolWriter): New public variable. Returns the
27921 current symbol writer.
27922 (CodeGen): Added `bool want_debugging_support' argument to the
27923 constructor. If true, tell the ModuleBuild that we want debugging
27924 support and ask it for the ISymbolWriter.
27925 (Save): If we have a symbol writer, call it's Close() method after
27926 saving the assembly.
27928 * driver.c (--debug): New command line argument to create a
27929 debugger information file.
27931 * location.cs (SymbolDocument): New public property. Returns an
27932 ISymbolDocumentWriter object for the current source file or null
27933 if we don't have a symbol writer.
27935 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27937 * driver.cs (LoadAssembly): Correctly return when all the paths
27938 have been tried and not before.
27940 * statement.cs (Switch.Emit): return the actual coverage for this
27941 statement (returns/not-returns)
27943 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27944 switch of the statement if we are the last switch section. That
27945 kills two problems: try/catch problems (we used to emit an empty
27946 nop at the end) and switch statements where all branches would
27949 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27951 * driver.cs: Add default assemblies (the equivalent to the
27952 Microsoft CSC.RSP file)
27954 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27955 also update tokens_seen and set it to false.
27957 * driver.cs: Implement --recurse for Mike.
27959 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27960 correctly splitting out the paths.
27962 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27964 * interface.cs (Interface.PopulateProperty): Instead of using
27965 `parent' as the declaration space for the set parameters, use
27968 * support.cs (InternalParameters): InternalParameters constructor
27969 takes a DeclSpace instead of a TypeContainer.
27971 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27972 types are being initialized, load the address of it before calling
27975 (New): Provide a mechanism to disable the generation of local
27976 value type temporaries when the caller will be providing us with
27977 an address to store it.
27979 (ArrayCreation.EmitDynamicInitializers): Use it.
27981 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27983 * expression.cs (Invocation.EmitArguments): Only probe for array
27984 property if there is more than one argument. Sorry about that.
27986 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27987 empty param arrays.
27989 * class.cs (Method.LabelParameters): Fix incorrect code path that
27990 prevented the `ParamArrayAttribute' from being applied to the
27993 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27995 * support.cs (ReflectionParameters): Correctly compute whether the
27996 last argument is a params array. Fixes the problem with
27999 * typemanager.cs: Make the assemblies array always be non-null
28000 (empty, but non-null)
28002 * tree.cs (RecordDecl): New function that abstracts the recording
28003 of names. This reports error 101, and provides a pointer to the
28004 previous declaration. Fixes a crash in the compiler.
28006 * cs-parser.jay (constructor_declaration): Update to new grammar,
28007 and provide a constructor_body that can be empty.
28009 2002-03-15 Miguel de Icaza <miguel@ximian.com>
28011 * driver.cs: Add support for --resources.
28013 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
28014 Make all types for the various array helper methods be integer.
28016 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
28017 CheckState to ConvCast.
28019 (ConvCast): Now it takes a `checked' state argument, to avoid
28020 depending on the emit context for the conversion, and just using
28021 the resolve time setting.
28023 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
28024 instead of Invocation.EmitArguments. We do not emit the original
28025 arguments, instead we emit those which have been converted to
28026 unsigned int expressions.
28028 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
28030 * codegen.cs: ditto.
28032 * expression.cs (LocalVariableReference): Drop the use of the
28033 Store function that depended on the variable index.
28035 * statement.cs (VariableInfo): Drop the `Idx' property from this
28036 class, as this is not taking into account the indexes for
28037 temporaries tat we generate during the execution, getting the
28040 * class.cs: First emit class initializers, then call the parent
28043 * expression.cs (Binary): Fix opcode emision.
28044 (UnaryMutator.EmitCode): Support checked code generation
28046 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
28047 matches for events for both the Static and Instance scans,
28048 pointing to the same element. Fix that.
28050 2002-03-14 Miguel de Icaza <miguel@ximian.com>
28052 * rootcontext.cs (ResolveTree): Always set the
28053 interface_resolve_order, because nested interfaces will be calling
28056 * class.cs (GetInterfaceOrClass): Track the same resolution
28057 process used by TypeManager.LookupType. This fixes the nested
28058 type lookups in class declarations (separate path from
28061 (TypeContainer.DefineType): Also define nested interfaces.
28062 (TypeContainer.RegisterOrder): New public function used to
28063 register the order in which child interfaces need to be closed.
28065 Nested interfaces need to be closed after their parents have been
28068 * interface.cs (InterfaceAttr): Put all the logic for computing
28069 the interface attribute here.
28071 (DefineInterface): Register our interface order with the
28072 RootContext or with the TypeContainer depending on the case.
28074 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28076 * cs-parser.jay: rework foreach statement to work with the new
28077 changes to the policy on SimpleNames.
28079 * report.cs: support Stacktrace on warnings as well.
28081 * makefile: drop --unsafe and /unsafe from the compile.
28083 2002-03-13 Ravi Pratap <ravi@ximian.com>
28085 * ecore.cs (StandardConversionExists): Modify to take an Expression
28086 as the first parameter. Ensure we do null -> reference type conversion
28089 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
28090 temporary Expression objects.
28092 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
28094 * interface.cs: workaround bug in method overloading resolution
28095 (there is already a bugzilla bug for it).
28097 2002-03-12 Miguel de Icaza <miguel@ximian.com>
28099 We could also solve this problem by having a separate path for
28100 performing type lookups, instead of DoResolve, we could have a
28101 ResolveType entry point, and only participating pieces of the
28102 production (simplename, deref, array) would implement this.
28104 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
28105 signal SimpleName to only resolve type names and not attempt to
28106 resolve anything else.
28108 * expression.cs (Cast): Set the flag.
28110 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
28112 * class.cs: Only report 108 if there is no `new' modifier.
28114 * cs-parser.jay: rework foreach statement to work with the new
28115 changes to the policy on SimpleNames.
28117 * report.cs: support Stacktrace on warnings as well.
28119 * makefile: drop --unsafe and /unsafe from the compile.
28121 2002-03-11 Miguel de Icaza <miguel@ximian.com>
28123 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28124 lookups here, instead of doing that at parse time. This means
28125 that our grammar will not introduce `LocalVariableReferences' as
28126 expressions at this point. That solves the problem of code like
28130 static void Main ()
28134 This is only half the fix. The full fix requires parameters to
28135 also be handled in this way.
28137 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
28138 makes the use more obvious of the DeclSpace. The
28139 ec.TypeContainer.TypeBuilder is now only used to pull the
28140 TypeBuilder for it.
28142 My theory is that I can get rid of the TypeBuilder completely from
28143 the EmitContext, and have typecasts where it is used (from
28144 DeclSpace to where it matters).
28146 The only pending problem is that the code that implements Aliases
28147 is on TypeContainer, and probably should go in DeclSpace.
28149 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
28150 lookups here, instead of doing that at parse time. This means
28151 that our grammar will not introduce `LocalVariableReferences' as
28152 expressions at this point. That solves the problem of code like
28156 static void Main ()
28160 This is only half the fix. The full fix requires parameters to
28161 also be handled in this way.
28163 * class.cs (Property.DefineMethod): When implementing an interface
28164 method, set newslot, when implementing an abstract method, do not
28165 set the flag (before we tried never setting it, or always setting
28166 it, which is the difference).
28167 (Indexer.DefineMethod): same.
28168 (Method.DefineMethod): same.
28170 * ecore.cs: Only set the status used flag if we get back a Field.
28172 * attribute.cs: Temporary hack, so Paolo can keep working.
28174 2002-03-08 Ravi Pratap <ravi@ximian.com>
28176 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
28177 the unmanaged type in the case we have a MarshalAs attribute.
28179 (Resolve): Handle the case when we are parsing the special MarshalAs
28180 attribute [we need to store the unmanaged type to use later]
28182 * typemanager.cs (marshal_as_attr_type): Built in type for the
28183 MarshalAs Attribute.
28185 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
28186 on parameters and accordingly set the marshalling info.
28188 2002-03-09 Miguel de Icaza <miguel@ximian.com>
28190 * class.cs: Optimizing slightly by removing redundant code after
28191 we switched to the `NoTypes' return value.
28192 (Property.DefineMethod): use NoTypes here too.
28194 This fixes the bug I introduced in my last batch of changes.
28196 2002-03-05 Ravi Pratap <ravi@ximian.com>
28198 * tree.cs (RecordEnum): Add. We now keep track of enums too.
28200 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
28201 Enums since those are types too.
28203 * cs-parser.jay (enum_declaration): Record enums as we parse them.
28205 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
28206 thanks to a call during the lookup process.
28208 2002-03-07 Miguel de Icaza <miguel@ximian.com>
28210 * statement.cs (Foreach): Lots of work to accomodate a particular
28211 kind of foreach statement that I had not kept in mind. It is
28212 possible to have foreachs on classes that provide a GetEnumerator
28213 method that return objects that implement the "pattern" for using
28214 a foreach, there is no need to support GetEnumerator
28217 This is needed to compile nant.
28219 * decl.cs: Only report 114 if the member is not `Finalize' and if
28220 the warning level is at least 2.
28222 * class.cs: Moved the compare function from Method to
28225 (MethodSignature.InheritableMemberSignatureCompare): Add new
28226 filter function that is used to extract inheritable methods from a
28229 (Method.Define): Use the new `inheritable_method_signature_filter'
28232 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
28235 2002-03-06 Miguel de Icaza <miguel@ximian.com>
28237 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
28239 * cs-parser.jay: Add opt_semicolon to the interface declaration.
28241 * expression.cs: Pass location information to
28242 ConvertImplicitStandard.
28244 * class.cs: Added debugging code to track return values from
28247 2002-03-05 Miguel de Icaza <miguel@ximian.com>
28249 * expression.cs (Is.DoResolve): If either side of the `is' is an
28250 interface, do not flag the warning.
28252 * ecore.cs (ImplicitReferenceConversion): We need a separate test
28255 * report.cs: Allow for --fatal to be used with --probe.
28257 * typemanager.cs (NoTypes): Move the definition for the empty Type
28260 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
28262 (TypeContainer.DefineProxy): New function used to proxy to parent
28263 implementations when implementing interfaces.
28264 (TypeContainer.ParentImplements): used to lookup if our parent
28265 implements a public function that is required by an interface.
28266 (TypeContainer.VerifyPendingMethods): Hook this up.
28268 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
28269 `modules' and `assemblies' arraylists into arrays. We only grow
28270 these are the very early start up of the program, so this improves
28271 the speedof LookupType (nicely measured).
28273 * expression.cs (MakeByteBlob): Replaced unsafe code with
28274 BitConverter, as suggested by Paolo.
28276 * cfold.cs (ConstantFold.Binary): Special case: perform constant
28277 folding of string concatenation, but if either side is a string,
28278 and the other is not, then return null, and let the runtime use
28279 the concatenation on the string plus the object (using
28280 `Object.ToString').
28282 2002-03-04 Miguel de Icaza <miguel@ximian.com>
28284 Constant Folding has been implemented now.
28286 * expression.cs (Unary.Reduce): Do not throw an exception, catch
28287 the error instead on types that are not supported in one's
28290 * constant.cs (Constant and all children): New set of functions to
28291 perform implict and explicit conversions.
28293 * ecore.cs (EnumConstant): Implement the new functions to perform
28294 conversion by proxying to the child expression.
28296 * codegen.cs: (ConstantCheckState): Constant evaluation has its
28297 own separate setting that can not be turned off from the command
28298 line using --unchecked or --checked and is only controlled using
28299 the checked/unchecked statements and expressions. This setting is
28300 used by the constant folder to flag errors.
28302 * expression.cs (CheckedExpr, UncheckedExpr): Set the
28303 ConstantCheckState as well.
28305 During Resolve, they also have to flag the state, because the
28306 constant folder runs completely in the Resolve phase.
28308 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
28311 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28313 * cfold.cs: New file, this file contains the constant folder.
28315 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
28316 argument to track whether we are using the resulting address to
28317 load or store a value and provide better error messages.
28319 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
28320 new AddressOf arguments.
28322 * statement.cs (Foreach.EmitCollectionForeach): Update
28324 * expression.cs (Argument.Emit): Call AddressOf with proper
28325 arguments to track usage.
28327 (New.DoEmit): Call AddressOf with new arguments.
28329 (Unary.Emit): Adjust AddressOf call.
28331 2002-03-01 Ravi Pratap <ravi@ximian.com>
28333 * cs-parser.jay (member_access): Change the case for pre-defined types
28334 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
28337 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
28340 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
28341 essentially like methods and apply attributes like MethodImplOptions to them too.
28343 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
28346 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
28347 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
28350 * Update code everywhere accordingly.
28352 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
28354 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
28356 2002-02-28 Ravi Pratap <ravi@ximian.com>
28358 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
28359 try performing lookups against those instead of jumping straight into using
28360 the 'using' clauses.
28362 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28364 (LookupType): Perform lookups in implicit parents too.
28366 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28367 sequence as RootContext.LookupType.
28369 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28370 the various cases of namespace lookups into this method.
28372 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28374 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28375 in positional arguments)
28377 * class.cs (Operator): Update the AllowedModifiers to contain
28380 * cs-parser.jay: Update operator declaration to allow for the
28381 operator body to be empty.
28383 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28386 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28388 * class.cs (Method.Emit): Label parameters.
28390 * driver.cs: Return 1 or 0 as the program exit code.
28392 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28394 * expression.cs: Special case the `null' object when trying to
28395 auto-compute the type, as anything can be explicitly converted to
28398 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28399 spotting this Paolo.
28401 (Expression.ImplicitNumericConversion): Perform comparissions of
28402 the type using the underlying type in the case of an enumeration
28403 rather than using the enumeration type for the compare.
28405 Cope with the underlying == type case, which is not possible to
28408 (Expression.ConvertNumericExplicit): Perform comparissions of
28409 the type using the underlying type in the case of an enumeration
28410 rather than using the enumeration type for the compare.
28412 * driver.cs: If the user does not supply an extension, assume .exe
28414 * cs-parser.jay (if_statement): Rewrote so that we can track the
28415 location for the if statement.
28417 * expression.cs (Binary.ConstantFold): Only concat strings when
28418 the operation is "+", not everything ;-)
28420 * statement.cs (Statement.EmitBoolExpression): Take a location
28422 (If, While, Do): Track location.
28424 * expression.cs (Binary.ResolveOperator): In the object + string
28425 case, I was missing a call to ConvertImplicit
28427 2002-02-25 Ravi Pratap <ravi@ximian.com>
28429 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28430 Location arguments. Ensure we use RootContext.LookupType to do our work
28431 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28433 * interface.cs (PopulateMethod): Handle the type of the parameter being
28436 * expression.cs (Invocation.BetterFunction): Handle the case when we
28437 have a params method with no fixed arguments and a call is made with no
28440 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28442 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28443 the verbatim-string-literal
28445 * support.cs (InternalParameters.ParameterModifier): handle null
28447 (InternalParameters.ParameterType): ditto.
28449 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28450 duplicating the name of the variable parameter.
28451 (GetParameterByName): Fix bug where we were not looking up array
28452 paramters if they were the only present (thanks Paolo!).
28453 (GetParameterInfo): We only have an empty set of types if both
28454 fixed and array are set to null.
28455 (GetParameterInfo-idx): Handle FixedParameter == null
28457 * cs-parser.jay: Handle the case where there is no catch
28458 statements (missing null test).
28460 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28462 * driver.cs (MainDriver): Be conservative on our command line
28465 Catch DirectoryNotFoundException when calling GetFiles.
28467 (SplitPathAndPattern): Used to split the input specification into
28468 a path and a pattern that we can feed to Directory.GetFiles.
28470 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28472 * statement.cs (Fixed): Implement the last case of the Fixed
28473 statement (string handling).
28475 * expression.cs (StringPtr): New class used to return a char * to
28476 a string; Used by the Fixed statement.
28478 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28480 * expression.cs (Binary.ResolveOperator): Remove redundant
28481 MemberLookup pn parent type.
28482 Optimize union call, we do not need a union if the types are the same.
28483 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28486 Specialize the use of MemberLookup everywhere, instead of using
28487 the default settings.
28489 (StackAlloc): Implement stackalloc keyword.
28491 * cs-parser.jay: Add rule to parse stackalloc.
28493 * driver.cs: Handle /h, /help, /?
28495 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28496 before we supported unsafe code.
28498 * makefile: add --unsafe to the self compilation of mcs.
28500 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28502 * expression.cs (PointerArithmetic): New class that is used to
28503 perform pointer arithmetic.
28504 (Binary.Resolve): Handle pointer arithmetic
28505 Handle pointer comparission.
28506 (ArrayPtr): Utility expression class that is used to take the
28507 address of an array.
28509 (ElementAccess): Implement array access for pointers
28511 * statement.cs (Fixed): Implement fixed statement for arrays, we
28512 are missing one more case before we are done.
28514 * expression.cs (Indirection): Implement EmitAssign and set the
28515 ExprClass to Variable. This allows pointer dereferences to be
28516 treated as variables, and to have values assigned to them.
28518 * ecore.cs (Expression.StoreFromPtr): New utility function to
28519 store values dereferencing.
28521 2002-02-20 Ravi Pratap <ravi@ximian.com>
28523 * expression.cs (Binary.ResolveOperator): Ensure that we are
28524 not trying to operate on a void type - this fixes the reported
28527 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28528 the parent implementation is sealed.
28530 * ../errors/cs0239.cs : Add.
28532 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28534 * typemanager.cs (unverifiable_code_type): Corresponds to
28535 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28536 which have unsafe code in them.
28538 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28541 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28543 * cs-tokenizer.cs: Add support for @"litreal strings"
28545 Make tokenizer accept pre-processor directives
28546 on any column (remove the old C-like limitation).
28548 * rootcontext.cs (EmitCode): Emit any global attributes.
28549 (AddGlobalAttributes): Used to keep track of assembly attributes.
28551 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28553 * cs-parser.jay: Add support for global attributes.
28555 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28557 * expression.cs (Indirection): New helper class. Unary will
28558 create Indirection classes to be able to implement the
28559 IMemoryLocation interface on it.
28561 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28563 * cs-parser.jay (fixed_statement): reference the right statement.
28565 * statement.cs (Fixed.Emit): Finish implementing the fixed
28566 statement for the &x case.
28568 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28570 * class.cs (Property.Define, Method.Define): Remove newslot when
28573 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28574 wrong. NewSlot should only be used if the `new' keyword is present.
28576 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28577 locating our system dir. Sorry about this.
28579 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28581 * driver.cs (GetSystemDir): Compute correctly the location of our
28582 system assemblies. I was using the compiler directory instead of
28583 the library directory.
28585 2002-02-13 Ravi Pratap <ravi@ximian.com>
28587 * expression.cs (BetterFunction): Put back in what Miguel commented out
28588 since it is the correct fix. The problem is elsewhere ;-)
28590 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28591 parameters of the parms method are themselves compatible or not !
28593 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28594 to check that a class implements an interface before saying that an implicit
28595 conversion was allowed. Use ImplementsInterface to do the checking.
28597 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28599 * class.cs (Method.Define): Track whether we are an explicit
28600 implementation or not. And only call DefineMethodOverride if we
28601 are an explicit implementation.
28603 (Property.DefineMethod): Ditto.
28605 2002-02-11 Ravi Pratap <ravi@ximian.com>
28607 * expression.cs (BetterFunction): Catch hideous bug which was
28608 preventing us from detecting ambiguous calls due to implicit casts i.e
28611 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28613 * support.cs (Pair): Remove un-needed method. I figured why I was
28614 getting the error in cs-parser.jay, the variable in a foreach loop
28615 is readonly, and the compiler does not really treat this as a variable.
28617 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28618 instead of EQUALS in grammar.
28620 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28622 * expression.cs (Unary.DoResolve): Check whether the argument is
28625 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28627 * support.cs: Api for Pair to set a value. Despite the fact that
28628 the variables are public the MS C# compiler refuses to compile
28629 code that accesses the field if the variable is part of a foreach
28632 * statement.cs (Fixed): Begin implementation of the fixed
28635 (Block.AddVariable): Return the VariableInfo on success and null
28636 on failure instead of true/false.
28638 * cs-parser.jay (foreach): Catch errors on variables already
28639 defined (we were ignoring this value before) and properly unwind
28640 the block hierarchy
28642 (fixed_statement): grammar for the fixed statement.
28644 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28646 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28647 pointer types to be incretemented.
28649 (SizeOf): Implement.
28651 * cs-parser.jay (pointer_member_access): Implement
28652 expr->IDENTIFIER production.
28654 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28655 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28658 (Unary): Implement indirection.
28660 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28661 use in non-unsafe context).
28663 (SimpleName.DoResolve): Check for pointers in field access on safe
28666 (Expression.LoadFromPtr): Factor the load-indirect code in this
28667 function. This was duplicated in UnboxCast and ParameterReference
28669 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28671 * expression.cs (ComposedCast): report an error if a pointer cast
28672 is used in a safe region.
28674 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28675 pointer type casts in unsafe context.
28677 * codegen.cs (EmitContext): Set up IsUnsafe.
28679 * cs-parser.jay (non_expression_type): Add productions for pointer
28682 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28683 code. We should not use force into static mode if the method is
28684 not virtual. Fixes bug in MIS
28686 * statement.cs (Do.Emit, While.Emit, For.Emit,
28687 Statement.EmitBoolExpression): Add support to Do and While to
28688 propagate infinite loop as `I do return' semantics.
28690 Improve the For case to also test for boolean constants.
28692 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28693 to the list of attributes we can add.
28695 Remove `EmitContext' argument.
28697 * class.cs (Method.Define): Apply parameter attributes.
28698 (Constructor.Define): Apply parameter attributes.
28699 (MethodCore.LabelParameters): Move here the core of labeling
28702 * support.cs (ReflectionParameters.ParameterModifier,
28703 InternalParameters.ParameterModifier): Use IsByRef on the type and
28704 only return the OUT bit for these parameters instead of in/out/ref
28707 This is because I miss-understood things. The ParameterInfo.IsIn
28708 and IsOut represent whether the parameter has the [In] and [Out]
28711 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28713 * ecore.cs (FieldExpr.Emit): Release temporaries.
28715 * assign.cs (LocalTemporary.Release): new function.
28717 * codegen.cs (EmitContext.GetTemporaryStorage,
28718 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28719 temporary storage. Now we can "put back" localbuilders when we
28722 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28724 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28725 need to make a copy of the variable to generate verifiable code.
28727 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28729 * driver.cs: Compute dynamically the system directory.
28731 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28732 Slower, but more generally useful. Used by the abstract
28733 registering implementation.
28735 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28736 the rules for the special rule on Type/instances. First check if
28737 we have the same name, and if so, try that special static path
28738 rather than the instance path.
28740 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28742 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28745 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28746 Enum, ValueType, Delegate or Array for non-corlib compiles.
28748 * cs-tokenizer.cs: Catch long identifiers (645)
28750 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28753 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28754 fix, we were returning too early, so we were not registering
28755 pending methods from abstract classes.
28757 Do not register pending methods if the class is abstract.
28759 * expression.cs (Conditional.DoResolve): Report circular implicit
28760 conversions when we neecd to compute it for conditional
28763 (Is.DoResolve): If the expression is always of the provided type,
28764 flag warning 183. If the expression can not ever be of the
28765 provided type flag warning 184.
28767 * class.cs: Catch 169 as well.
28769 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28772 2002-01-18 Nick Drochak <ndrochak@gol.com>
28774 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28776 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28778 * interface.cs: (PopulateMethod): Check for pointers being defined
28779 only if the unsafe context is active.
28780 (PopulateProperty): ditto.
28781 (PopulateIndexer): ditto.
28783 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28784 specified. If pointers are present, make sure that they are
28785 present in an unsafe context.
28786 (Constructor, Constructor.Define): ditto.
28787 (Field, Field.Define): ditto.
28788 (Property, Property.Define): ditto.
28789 (Event, Event.Define): ditto.
28791 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28792 hashtable if there are classes or structs defined.
28794 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28795 code, as the constant resolution moved.
28797 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28798 the metadata, so we can flag error 133.
28800 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28801 pointer is being declared in an unsafe context.
28803 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28805 * modifiers.cs (Modifiers.Check): Require a Location argument.
28806 Report error 227 for Unsafe use.
28808 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28810 * statement.cs (For.Emit): If the test is null, then report that
28811 we do `return', as we wont reach anything afterwards.
28813 (Switch.SwitchGoverningType): Track the expression that matched
28816 * driver.cs: Allow negative numbers as an error code to flag.
28818 * cs-parser.jay: Handle 1551.
28820 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28822 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28824 * cs-parser.jay: Report 1518 (type declaration can only contain
28825 class, struct, interface, enum or delegate)
28827 (switch_label): Report 1523 (keywords `case' or `default' must
28830 (opt_switch_sections): Report 1522 (empty switch)
28832 * driver.cs: Report 1515 (response file specified multiple times)
28833 Report 1516 (Source file specified multiple times).
28835 * expression.cs (Argument.Resolve): Signal 1510
28837 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28838 access not allowed in static code)
28840 2002-01-11 Ravi Pratap <ravi@ximian.com>
28842 * typemanager.cs (IsPointerType): Utility method which we are going
28845 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28846 the object type, so we take care of that.
28848 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28850 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28851 added to non-params parameters :-)
28853 * typemanager.cs (CSharpName): Include 'void' type too.
28855 (void_ptr_type): Include in the set of core types.
28857 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28860 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28863 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28864 completely forgotten about it.
28866 2002-01-10 Ravi Pratap <ravi@ximian.com>
28868 * cs-parser.jay (pointer_type): Add. This begins our implementation
28869 of parsing rules for unsafe code.
28871 (unsafe_statement): Implement.
28873 (embedded_statement): Modify to include the above.
28875 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28877 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28878 if the current context is an unsafe one.
28880 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28881 are handled differently, we need separate rules for them.
28883 (local_variable_declaration): Update to use local_variable_pointer_type
28884 to allow variable declarations of unmanaged pointer types.
28886 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28887 in unsafe contexts.
28889 * ../errors/cs0214.cs : Add.
28891 2002-01-16 Nick Drochak <ndrochak@gol.com>
28893 * makefile: remove 'response' file when cleaning.
28895 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28897 * cs-parser.jay: Report 1524.
28899 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28901 * typemanager.cs (RegisterMethod): drop checking if we have
28902 registered this from here
28904 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28906 * class.cs (Method.EmitDestructor): Implement calling our base
28909 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28910 value of InFinally.
28912 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28913 this routine and will wrap the call in a try/catch block. Deal
28916 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28918 * ecore.cs (Expression.MemberLookup): instead of taking a
28919 parameter `same_type' that was used to tell whether we could
28920 access private members we compute our containing type from the
28923 (FieldExpr): Added partial support for volatile fields. This does
28924 not work for volatile fields exposed from assemblies, as I can not
28925 figure out how to extract the modreq from it.
28927 Updated all the source files to use this.
28929 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28930 because it is referenced by MemberLookup very often.
28932 2002-01-09 Ravi Pratap <ravi@ximian.com>
28934 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28935 TypeBuilder.GetCustomAttributes to retrieve what we need.
28937 Get rid of redundant default_member_attr_type as this is the same as
28938 default_member_type which already exists.
28940 * interface.cs, attribute.cs : Update accordingly.
28942 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28944 * typemanager.cs: Enable IndexerPropertyName again. It does not
28945 work for TYpeBuilders though. Ravi, can you please fix this?
28947 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28949 * expression.cs (Argument.Emit): Handle the case of ref objects
28950 being passed to ref functions;
28952 (ParameterReference.EmitLoad): Loads the content of the pointer
28953 without dereferencing.
28955 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28957 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28959 2002-01-08 Ravi Pratap <ravi@ximian.com>
28961 * class.cs (Indexer.DefineMethod): Incorporate the interface
28962 type in the name of the method if we are doing explicit interface
28965 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28967 (BetterConversion): Fix extremely trivial bug where we were referring to
28968 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28971 * ../errors/bug16.cs : Add although we have fixed it.
28973 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28975 * expression.cs (BaseIndexer): Begin implementation.
28977 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28979 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28980 production directly to remove a shift/reduce, and implement
28981 explicit interface implementation.
28983 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28984 after a floating point suffix.
28986 * expression.cs (DoNumericPromotions): Improved the conversion for
28987 uint/uint. If we have a constant, we avoid doing a typecast to a
28990 * class.cs (Indexer): Implement explicit interface implementation
28993 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28995 * class.cs: make the default instance constructor public and hidebysig.
28997 2001-01-03 Ravi Pratap <ravi@ximian.com>
28999 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
29000 so we can call it from elsewhere.
29002 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
29003 we emit it internally if the class has a defined indexer; otherwise the user
29004 emits it by decorating the class definition with the DefaultMemberAttribute.
29006 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
29007 attribute is not used on a type which defines an indexer.
29009 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
29010 character when we skip whitespace.
29012 * ../errors/cs0646.cs : Add.
29014 2002-01-03 Miguel de Icaza <miguel@ximian.com>
29016 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
29019 * makefile: Add practical target `mcs3.exe' which builds the third
29020 generation compiler.
29022 * expression.cs (New): Fix structures constructor calling.
29024 * class.cs (Property, Method, Indexer): Emit Final flag on the
29025 method if we are an interface implementation and we are not
29028 * ecore.cs (PropertyExpr): New public field `IsBase', tells
29029 whether this property is referencing a `base' method.
29031 * expression.cs (Invocation.EmitCall): take an extra argument:
29032 is_base, this is used to determine whether the `call' or
29033 `callvirt' opcode should be used.
29036 * delegate.cs: update EmitCall.
29038 * class.cs (Method.Define): Set NewSlot for the cases where we are
29039 not implementing an interface method.
29041 (Property.Define): ditto.
29043 2002-01-02 Miguel de Icaza <miguel@ximian.com>
29045 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
29046 'r'. Allows mcs to parse itself fully.
29048 2002-01-02 Ravi Pratap <ravi@ximian.com>
29050 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
29051 of the number of initializers that require the InitializeArray method.
29053 (CheckIndices): Store the Expression in all cases - not the plain value. Also
29054 update the above field where necessary.
29056 (MakeByteBlob): Update accordingly.
29058 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
29061 (EmitDynamicInitializers): Update in accordance with the new optimization.
29063 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
29064 same OpCode applies.
29066 * cs-parser.jay : Fix some glaring errors I introduced.
29068 2002-01-01 Ravi Pratap <ravi@ximian.com>
29070 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
29071 so that we can check for name clashes there too.
29073 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
29074 for interface indexers.
29076 * interfaces.cs (Define): Emit the default member attribute.
29078 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
29079 variable was being referred to while setting the value ;-)
29081 2002-01-01 Miguel de Icaza <miguel@ximian.com>
29083 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
29084 byte-by-byte information when we know the data is zero.
29086 Make the block always a multiple of 4, because
29087 DefineInitializedData has a bug.
29089 * assign.cs: Fix, we should assign from the temporary, not from
29092 * expression.cs (MakeByteBlob): Fix my incorrect code.
29094 2001-12-31 Miguel de Icaza <miguel@ximian.com>
29096 * typemanager.cs (EnumToUnderlying): This function is used to get
29097 the underlying type from an enumeration, because it does not
29100 * constant.cs: Use the I4_S form for values between -128 and 127.
29102 * statement.cs (Block.LookupLabel): Looks up a label.
29103 (Block): Drop support for labeled blocks.
29105 (LabeledStatement): New kind of statement that represents a label
29108 (Goto): Finally implement this bad boy.
29110 * cs-parser.jay: Update to reflect new mechanism to implement
29113 2001-12-30 Miguel de Icaza <miguel@ximian.com>
29115 * codegen.cs (EmitContext.This): a codegen property that keeps the
29116 a single instance of this instead of creating many different this
29119 * delegate.cs (Delegate.DoResolve): Update to use the property;
29121 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
29123 * expression.cs (BaseAccess.DoResolve): Ditto.
29125 2001-12-29 Ravi Pratap <ravi@ximian.com>
29127 * typemanager.cs (methodimpl_attr_type): Add to hold the type
29128 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
29130 (InitCoreTypes): Update accordingly.
29132 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
29133 so we can quickly store the state.
29135 (ApplyAttributes): Set the correct implementation flags
29136 for InternalCall methods.
29138 2001-12-29 Miguel de Icaza <miguel@ximian.com>
29140 * expression.cs (EmitCall): if a method is not virtual, then do
29141 not use callvirt on it.
29143 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
29144 user defined stuff) requires the use of stobj, which takes an
29145 address on the stack instead of an array and an index. So emit
29146 the Ldelema operation for it.
29148 (EmitStoreOpcode): Use stobj for valuetypes.
29150 (UnaryMutator.EmitCode): Use the right 1 value depending on
29151 whether we are dealing with int64/uint64, float or doubles.
29153 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
29154 constructors that I implemented last night.
29156 (Constructor.IsDefault): Fix to work properly for static
29159 * cs-parser.jay (CheckDef): report method signature errors.
29160 Update error number 103 to be 132.
29162 * decl.cs: New AdditionResult enumeration value: MethodExists.
29163 Although we do this check for methods later on in the semantic
29164 analysis, catching repeated default constructors is so easy that
29165 we catch these here.
29167 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
29170 (ParameterReference.EmitAssign, Emit): handle
29173 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
29174 (ArrayAccess.EmitStoreOpcode): ditto.
29176 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
29178 * expression.cs (MakeByteBlob): Complete all the missing types
29179 (uint, short, ushort, byte, sbyte)
29181 * class.cs: Only init instance field initializers on instance
29184 Rename `constructors' to instance_constructors.
29186 (TypeContainer.AddConstructor): Only add constructors to the list
29187 if it is not static.
29189 Make sure that we handle default_static_constructor independently
29190 everywhere where we handle instance_constructors
29192 2001-12-28 Miguel de Icaza <miguel@ximian.com>
29194 * class.cs: Do not lookup or create a base initializer for a
29195 static constructor.
29197 (ConstructorInitializer.Resolve): use the proper type to lookup
29200 * cs-parser.jay: Report error 1585 (modifiers between type and name).
29202 * enum.cs, interface.cs: Remove CloseType, this is taken care by
29205 * decl.cs: CloseType is now an virtual method, the default
29206 implementation just closes this type.
29208 2001-12-28 Ravi Pratap <ravi@ximian.com>
29210 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
29211 to PreserveSig by default. Also emit HideBySig on such methods.
29213 Basically, set the defaults to standard values.
29215 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
29216 argument, if candidate is better, it can't be worse than the best !
29218 (Invocation): Re-write bits to differentiate between methods being
29219 applicable in their expanded form and their normal form - for params
29222 Get rid of use_standard everywhere as only standard conversions are allowed
29223 in overload resolution.
29225 More spec conformance.
29227 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29229 * driver.cs: Add --timestamp, to see where the compiler spends
29232 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
29233 `this' in static code.
29235 (SimpleName.DoResolve): Implement in terms of a helper function
29236 that allows static-references to be passed upstream to
29239 (Expression.ResolveWithSimpleName): Resolve specially simple
29240 names when called by MemberAccess to implement the special
29243 (Expression.ImplicitReferenceConversion): Handle conversions from
29244 Null to reference types before others, as Null's type is
29247 * expression.cs (Invocation.EmitCall): Handle the special case of
29248 calling methods declared on a reference type from a ValueType
29249 (Base classes System.Object and System.Enum)
29251 (MemberAccess.Resolve): Only perform lookups on Enumerations if
29252 the left hand side is a TypeExpr, not on every enumeration.
29254 (Binary.Resolve): If types are reference types, then do a cast to
29255 object on operators != and == of both arguments.
29257 * typemanager.cs (FindMembers): Extract instance and static
29258 members if requested.
29260 * interface.cs (PopulateProperty): Use void_type instead of null
29261 as the return type for the setter method.
29263 (PopulateIndexer): ditto.
29265 2001-12-27 Ravi Pratap <ravi@ximian.com>
29267 * support.cs (ReflectionParameters): Fix minor bug where we
29268 were examining the wrong parameter for the ParamArray attribute.
29270 Cope with requests for the type of the parameter at position
29271 greater than the params parameter's. We now return the element
29272 type of the params array as that makes more sense.
29274 * expression.cs (Invocation.IsParamsMethodApplicable): Update
29275 accordingly as we no longer have to extract the element type
29278 (Invocation.OverloadResolve): Update.
29280 2001-12-27 Miguel de Icaza <miguel@ximian.com>
29282 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
29283 against IEnumerator, test whether the return value is a descendant
29284 of the IEnumerator interface.
29286 * class.cs (Indexer.Define): Use an auxiliary method to implement
29287 the other bits of the method definition. Begin support for
29288 explicit interface implementation.
29290 (Property.DefineMethod): Use TypeManager.void_type instead of null
29291 for an empty return value.
29293 2001-12-26 Miguel de Icaza <miguel@ximian.com>
29295 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
29296 dealing with a FieldExpr which is composed of a FieldBuilder, in
29297 the code path we did extract the constant, but we should have
29298 obtained the underlying value to be able to cast it (otherwise we
29299 end up in an infinite loop, this is what Ravi was running into).
29301 (ArrayCreation.UpdateIndices): Arrays might be empty.
29303 (MemberAccess.ResolveMemberAccess): Add support for section
29304 14.5.4.1 that deals with the special case of E.I when E is a type
29305 and something else, that I can be a reference to a static member.
29307 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
29308 handle a particular array type to create byte blobs, it is just
29309 something we dont generate byteblobs for.
29311 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
29314 * location.cs (Push): remove the key from the hashtable that we
29315 are about to add. This happens for empty files.
29317 * driver.cs: Dispose files after we have parsed them.
29319 (tokenize): new function that only runs the tokenizer on its
29320 input, for speed testing.
29322 2001-12-26 Ravi Pratap <ravi@ximian.com>
29324 * class.cs (Event.Define): Define the private field only if there
29325 are no accessors defined.
29327 * expression.cs (ResolveMemberAccess): If there is no associated
29328 field with the event, that means we have an event defined with its
29329 own accessors and we should flag error cs0070 since transforming
29330 ourselves into a field is not valid in that case.
29332 * ecore.cs (SimpleName.DoResolve): Same as above.
29334 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
29335 and charset to sane values.
29337 2001-12-25 Ravi Pratap <ravi@ximian.com>
29339 * assign.cs (DoResolve): Perform check on events only if they
29340 are being accessed outside the declaring type.
29342 * cs-parser.jay (event_declarations): Update rules to correctly
29343 set the type of the implicit parameter etc.
29345 (add_accessor, remove_accessor): Set current local parameters.
29347 * expression.cs (Binary): For delegate addition and subtraction,
29348 cast the return value from the method into the appropriate delegate
29351 2001-12-24 Ravi Pratap <ravi@ximian.com>
29353 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
29354 of these as the workaround is unnecessary.
29356 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
29357 delegate data - none of that is needed at all.
29359 Re-write bits to extract the instance expression and the delegate method
29362 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29365 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29366 of attaching attributes instead of duplicating code everywhere.
29368 * everywhere : Update code to do attribute emission using the above method.
29370 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29372 * expression.cs (IsParamsMethodApplicable): if there are not
29373 parameters, return immediately.
29375 * ecore.cs: The 0 literal can be implicity converted to an enum
29378 (SimpleName.DoResolve): First lookup the type, then lookup the
29381 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29382 want to get its address. If the InstanceExpression is not
29383 addressable, store the result in a temporary variable, then get
29386 * codegen.cs: Only display 219 errors on warning level or above.
29388 * expression.cs (ArrayAccess): Make it implement the
29389 IMemoryLocation interface.
29391 (Binary.DoResolve): handle the operator == (object a, object b)
29392 and operator != (object a, object b) without incurring into a
29393 BoxedCast (because 5 != o should never be performed).
29395 Handle binary enumerator operators.
29397 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29398 value type, otherwise use Ldelem_ref.
29400 Use precomputed names;
29402 (AddressOf): Implement address of
29404 * cs-parser.jay (labeled_statement): Fix recursive block
29405 addition by reworking the production.
29407 * expression.cs (New.DoEmit): New has a special case:
29409 If we are dealing with a ValueType, we have a few
29410 situations to deal with:
29412 * The target of New is a ValueType variable, that is
29413 easy, we just pass this as the variable reference
29415 * The target of New is being passed as an argument,
29416 to a boxing operation or a function that takes a
29419 In this case, we need to create a temporary variable
29420 that is the argument of New.
29423 2001-12-23 Ravi Pratap <ravi@ximian.com>
29425 * rootcontext.cs (LookupType): Check that current_type is not null before
29426 going about looking at nested types.
29428 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29429 not implement the IAssignMethod interface any more.
29431 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29432 where we tranform them into FieldExprs if they are being resolved from within
29433 the declaring type.
29435 * ecore.cs (SimpleName.DoResolve): Do the same here.
29437 * assign.cs (DoResolve, Emit): Clean up code considerably.
29439 * ../errors/bug10.cs : Add.
29441 * ../errors/cs0070.cs : Add.
29443 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29445 * assign.cs : Get rid of EventIsLocal everywhere.
29447 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29449 * ecore.cs (ConvertIntLiteral): finished the implementation.
29451 * statement.cs (SwitchLabel): Convert the value we are using as a
29452 key before looking up the table.
29454 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29456 * codegen.cs (EmitTopBlock): Require a Location argument now.
29458 * cs-parser.jay (constructor_declarator): We need to setup
29459 current_local_parameters before we parse the
29460 opt_constructor_initializer, to allow the variables to be bound
29461 to the constructor arguments.
29463 * rootcontext.cs (LookupType): First lookup nested classes in our
29464 class and our parents before we go looking outside our class.
29466 * expression.cs (ConstantFold): Extract/debox the values at the
29469 * rootcontext.cs (EmitCode): Resolve the constants first before we
29470 resolve the types. This is not really needed, but it helps debugging.
29472 * statement.cs: report location.
29474 * cs-parser.jay: pass location to throw statement.
29476 * driver.cs: Small bug fix.
29478 * report.cs: Updated format to be 4-zero filled digits.
29480 2001-12-22 Ravi Pratap <ravi@ximian.com>
29482 * expression.cs (CheckIndices): Fix minor bug where the wrong
29483 variable was being referred to ;-)
29485 (DoEmit): Do not call EmitStaticInitializers when the
29486 underlying type is System.Object.
29488 2001-12-21 Ravi Pratap <ravi@ximian.com>
29490 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29491 and do the usual workaround for SRE.
29493 * class.cs (MyEventBuilder.EventType): New member to get at the type
29494 of the event, quickly.
29496 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29498 * assign.cs (Assign.DoResolve): Handle the case when the target
29499 is an EventExpr and perform the necessary checks.
29501 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29504 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29506 (EventExpr): Set the type in the constructor itself since we
29507 are meant to be born fully resolved.
29509 (EventExpr.Define): Revert code I wrote earlier.
29511 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29512 instance expression is null. The instance expression is a This in that case
29513 or a null, depending on whether it is a static method or not.
29515 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29516 refers to more than one method.
29518 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29519 and accordingly flag errors.
29521 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29523 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29525 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29527 * location.cs (ToString): Provide useful rutine.
29529 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29531 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29532 objects, return the actual integral boxed.
29534 * statement.cs (SwitchLabel): define an ILLabel for each
29537 (Switch.CheckSwitch): If the value is a Literal, extract
29538 the underlying literal.
29540 Also in the unused hashtable we had, add the SwitchLabel so we can
29541 quickly look this value up.
29543 * constant.cs: Implement a bunch of new constants. Rewrite
29544 Literal based on this. Made changes everywhere to adapt to this.
29546 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29547 dereferencing array only once, and also copes with enumrations.
29549 bytes are two bytes wide, not one.
29551 (Cast): Perform constant conversions.
29553 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29554 wrappers to the literals here.
29556 * expression.cs (DoNumericPromotions): long literals can converted
29557 to ulong implicity (this is taken care of elsewhere, but I was
29558 missing this spot).
29560 * ecore.cs (Expression.Literalize): Make the return type Literal,
29561 to improve type checking.
29563 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29565 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29567 * literal.cs: Revert code from ravi that checked the bounds. The
29568 bounds are sane by the definition of the type itself.
29570 * typemanager.cs: Fix implementation of ImplementsInterface. We
29571 need to actually look up in our parent hierarchy for interfaces
29574 * const.cs: Use the underlying type for enumerations
29576 * delegate.cs: Compute the basename for the delegate creation,
29577 that should fix the delegate test case, and restore the correct
29578 Type Lookup semantics in rootcontext
29580 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29581 referencing a nested type with the Reflection API is using the "+"
29584 * cs-parser.jay: Do not require EOF token at the end.
29586 2001-12-20 Ravi Pratap <ravi@ximian.com>
29588 * rootcontext.cs (LookupType): Concatenate type names with
29589 a '.' instead of a '+' The test suite passes again.
29591 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29592 field of the enumeration.
29594 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29595 the case when the member is an EventExpr.
29597 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29598 static has an associated instance expression.
29600 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29602 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29604 * class.cs (Event.Define): Register event and perform appropriate checks
29607 We define the Add and Remove methods even if the use provides none because
29608 in that case, we provide default implementations ourselves.
29610 Define a private field of the type of the event. This is done by the CSC compiler
29611 and we should be doing it too ;-)
29613 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29614 More methods we use in code we generate.
29616 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29619 (InitCoreTypes): Update accordingly for the above.
29621 * class.cs (Event.Emit): Generate code for default accessors that we provide
29623 (EmitDefaultMethod): Do the job in the above.
29625 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29628 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29630 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29631 builders even if we were missing one.
29633 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29634 pass the Basename as our class name instead of the Name. The
29635 basename will be correctly composed for us.
29637 * parameter.cs (Paramters): Now takes a Location argument.
29639 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29640 make all the code call directly LookupType in RootContext and take
29641 this chance to pass the Location information everywhere.
29643 * Everywhere: pass Location information.
29645 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29647 * class.cs (Constructor.Define): Updated way of detecting the
29648 length of the parameters.
29650 (TypeContainer.DefineType): Use basename as the type name for
29653 (TypeContainer.Define): Do not recursively define types here, as
29654 definition is taken care in order by the RootContext.
29656 * tree.cs: Keep track of namespaces in a per-file basis.
29658 * parameter.cs (Parameter.ComputeSignature): Update to use
29661 (Parameters.GetSignature): ditto.
29663 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29664 instead of a TypeContainer.
29666 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29667 resolve names. Because we need to be resolve in our context, not
29670 * driver.cs: Implement response files.
29672 * class.cs (TypeContainer.DefineType): If we are defined, do not
29673 redefine ourselves.
29675 (Event.Emit): Emit the code for add/remove handlers.
29676 (Event.Define): Save the MethodBuilders for add/remove.
29678 * typemanager.cs: Use pair here too.
29680 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29681 DictionaryEntry requires the first argument to be non-null.
29683 (enum_declaration): Compute full name for registering the
29686 (delegate_declaration): Instead of using
29687 formal_parameter_list, use opt_formal_parameter_list as the list
29690 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29691 (EventParsing): New property that controls whether `add' and
29692 `remove' are returned as tokens or identifiers (for events);
29694 2001-12-19 Ravi Pratap <ravi@ximian.com>
29696 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29697 use MyEventBuilder only and let it wrap the real builder for us.
29699 (MyEventBuilder): Revamp constructor etc.
29701 Implement all operations that we perform on EventBuilder in precisely the same
29704 (FindMembers): Update to use the EventBuilder member.
29706 (Event.Emit): Update accordingly.
29708 2001-12-18 Ravi Pratap <ravi@ximian.com>
29710 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29711 by calling the appropriate methods.
29713 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29716 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29718 2001-12-17 Ravi Pratap <ravi@ximian.com>
29720 * delegate.cs (Delegate.Populate): Check that the return type
29721 and various parameters types are indeed accessible.
29723 * class.cs (Constructor.Define): Same here.
29725 (Field.Define): Ditto.
29727 (Event.Define): Ditto.
29729 (Operator.Define): Check that the underlying Method defined itself
29730 correctly - so it's MethodBuilder should not be null.
29732 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29733 expression happens to be null.
29735 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29736 members but as of now we don't seem to be able to do anything really useful with it.
29738 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29739 not the EventBuilder.
29741 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29743 * cs-tokenizer.cs: Add support for defines.
29744 Add support for #if, #elif, #else, #endif
29746 (eval_var): evaluates a variable.
29747 (eval): stubbed for evaluating functions.
29749 * cs-parser.jay: Pass the defines information
29751 * driver.cs: Add --define command line option.
29753 * decl.cs: Move MemberCore here.
29755 Make it the base class for DeclSpace. This allows us to catch and
29756 report 108 and 109 for everything now.
29758 * class.cs (TypeContainer.Define): Extract all the members
29759 before populating and emit the warning 108 (new keyword required
29760 to override) instead of having each member implement this.
29762 (MemberCore.Define): New abstract method, we will be using this in
29763 the warning reporting engine in Populate.
29765 (Operator.Define): Adjust to new MemberCore protocol.
29767 * const.cs (Const): This does not derive from Expression, it is a
29768 temporary object we use to create fields, it is a MemberCore.
29770 * class.cs (Method.Define): Allow the entry point to be in a
29773 * driver.cs: Rewrite the argument handler to clean it up a bit.
29775 * rootcontext.cs: Made it just an auxiliary namespace feature by
29776 making everything static.
29778 * driver.cs: Adapt code to use RootContext type name instead of
29781 * delegate.cs: Remove RootContext argument.
29783 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29786 * class.cs (Event.Define): The lookup can fail.
29788 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29790 * expression.cs: Resolve the this instance before invoking the code.
29792 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29794 * cs-parser.jay: Add a production in element_access that allows
29795 the thing to become a "type" reference. This way we can parse
29796 things like "(string [])" as a type.
29798 Note that this still does not handle the more complex rules of
29802 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29804 * ecore.cs: (CopyNewMethods): new utility function used to
29805 assemble the list of methods from running FindMembers.
29807 (MemberLookup): Rework FindMembers so that
29809 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29811 * class.cs (TypeContainer): Remove Delegates who fail to be
29814 * delegate.cs (Populate): Verify that we dont get null return
29815 values. TODO: Check for AsAccessible.
29817 * cs-parser.jay: Use basename to emit error 574 (destructor should
29818 have the same name as container class), not the full name.
29820 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29821 possible representation.
29823 Also implements integer type suffixes U and L.
29825 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29827 * expression.cs (ArrayCreation.DoResolve): We need to do the
29828 argument resolution *always*.
29830 * decl.cs: Make this hold the namespace. Hold the root context as
29832 (LookupType): Move here.
29834 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29836 * location.cs (Row, Name): Fixed the code, it was always returning
29837 references to the first file.
29839 * interface.cs: Register properties defined through interfaces.
29841 * driver.cs: Add support for globbing on the command line
29843 * class.cs (Field): Make it derive from MemberCore as well.
29846 2001-12-15 Ravi Pratap <ravi@ximian.com>
29848 * class.cs (Event::Define): Check that the type of the event is a delegate
29849 type else flag error #66.
29851 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29854 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29855 values of EntryPoint, CharSet etc etc.
29857 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29859 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29860 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29861 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29862 which needs this to do its work.
29864 * ../errors/cs0066.cs : Add.
29866 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29868 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29871 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29872 clears out the parameters field.
29873 (MemberSignatureCompare): Cleanup
29875 (MemberCore): New base class used to share code between MethodCore
29878 (RegisterRequiredImplementations) BindingFlags.Public requires
29879 either BindingFlags.Instace or Static. Use instance here.
29881 (Property): Refactored code to cope better with the full spec.
29883 * parameter.cs (GetParameterInfo): Return an empty array instead
29886 * class.cs (Property): Abstract or extern properties have no bodies.
29888 * parameter.cs (GetParameterInfo): return a zero-sized array.
29890 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29891 method modifier validation to the typecontainer so we can reuse
29892 this on properties.
29894 (MethodCore.ParameterTypes): return an empty sized array of types.
29896 (Property.Define): Test property modifier validity.
29898 Add tests for sealed/override too.
29900 (Method.Emit): abstract or extern methods have no bodies.
29902 2001-12-14 Ravi Pratap <ravi@ximian.com>
29904 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29907 (Method::Define, ::Emit): Modify accordingly.
29909 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29911 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29913 * makefile: Pass in /unsafe.
29915 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29917 * class.cs (MakeKey): Kill routine.
29919 * class.cs (TypeContainer.Define): Correctly define explicit
29920 method implementations (they require the full interface name plus
29923 * typemanager.cs: Deply the PtrHashtable here and stop using the
29924 lame keys. Things work so much better.
29926 This of course broke everyone who depended on `RegisterMethod' to
29927 do the `test for existance' test. This has to be done elsewhere.
29929 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29930 the object stupid Equals method (because, that like fails all over
29931 the place). We still do not use it.
29933 * class.cs (TypeContainer.SetRequiredInterface,
29934 TypeContainer.RequireMethods): Killed these two routines and moved
29935 all the functionality to RegisterRequiredImplementations.
29937 (TypeContainer.RegisterRequiredImplementations): This routine now
29938 registers all the implementations required in an array for the
29939 interfaces and abstract methods. We use an array of structures
29940 which can be computed ahead of time to reduce memory usage and we
29941 also assume that lookups are cheap as most classes will not
29942 implement too many interfaces.
29944 We also avoid creating too many MethodSignatures.
29946 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29947 clear the "pending" bit if we find that there are problems with
29950 (TypeContainer.VerifyPendingMethods): Update to report errors of
29951 methods that look like implementations but are not.
29953 (TypeContainer.Define): Add support for explicit interface method
29956 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29958 * typemanager.cs: Keep track of the parameters here instead of
29959 being a feature of the TypeContainer.
29961 * class.cs: Drop the registration of parameters here, as
29962 InterfaceMethods are also interface declarations.
29964 * delegate.cs: Register methods with the TypeManager not only with
29965 the TypeContainer. This code was buggy.
29967 * interface.cs: Full registation here.
29969 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29971 * expression.cs: Remove reducer for binary expressions, it can not
29974 * const.cs: Put here the code that used to go into constant.cs
29976 * constant.cs: Put here the code for constants, this is a new base
29977 class for Literals.
29979 * literal.cs: Make Literal derive from Constant.
29981 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29983 * statement.cs (Return.Emit): Report error 157 if the user
29984 attempts to return from a finally block.
29986 (Return.Emit): Instead of emitting a return, jump to the end of
29989 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29990 LocalBuilder to store the result of the function. ReturnLabel is
29991 the target where we jump.
29994 2001-12-09 Radek Doulik <rodo@ximian.com>
29996 * cs-parser.jay: remember alias in current namespace
29998 * ecore.cs (SimpleName::DoResolve): use aliases for types or
30001 * class.cs (LookupAlias): lookup alias in my_namespace
30003 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
30005 (LookupAlias): lookup alias in this and if needed in parent
30008 2001-12-08 Miguel de Icaza <miguel@ximian.com>
30012 * rootcontext.cs: (ModuleBuilder) Made static, first step into
30013 making things static. I need this to avoid passing the
30014 TypeContainer when calling ParameterType.
30016 * support.cs (InternalParameters.ParameterType): Remove ugly hack
30017 that did string manipulation to compute the type and then call
30018 GetType. Use Parameter.ParameterType instead.
30020 * cs-tokenizer.cs: Consume the suffix for floating values.
30022 * expression.cs (ParameterReference): figure out whether this is a
30023 reference parameter or not. Kill an extra variable by computing
30024 the arg_idx during emission.
30026 * parameter.cs (Parameters.GetParameterInfo): New overloaded
30027 function that returns whether a parameter is an out/ref value or not.
30029 (Parameter.ParameterType): The type of the parameter (base,
30030 without ref/out applied).
30032 (Parameter.Resolve): Perform resolution here.
30033 (Parameter.ExternalType): The full type (with ref/out applied).
30035 * statement.cs (Using.Emit, Using.EmitExpression): Implement
30036 support for expressions on the using statement.
30038 2001-12-07 Miguel de Icaza <miguel@ximian.com>
30040 * statement.cs (Using.EmitLocalVariableDecls): Split the
30041 localvariable handling of the using statement.
30043 (Block.EmitMeta): Keep track of variable count across blocks. We
30044 were reusing slots on separate branches of blocks.
30046 (Try.Emit): Emit the general code block, we were not emitting it.
30048 Check the type of the declaration to be an IDisposable or
30049 something that can be implicity converted to it.
30051 Emit conversions if required.
30053 * ecore.cs (EmptyExpression): New utility class.
30054 (Expression.ImplicitConversionExists): New utility function.
30056 2001-12-06 Miguel de Icaza <miguel@ximian.com>
30058 * statement.cs (Using): Implement.
30060 * expression.cs (LocalVariableReference): Support read only variables.
30062 * statement.cs: Remove the explicit emit for the Leave opcode.
30063 (VariableInfo): Add a readonly field.
30065 2001-12-05 Miguel de Icaza <miguel@ximian.com>
30067 * ecore.cs (ConvCast): new class used to encapsulate the various
30068 explicit integer conversions that works in both checked and
30069 unchecked contexts.
30071 (Expression.ConvertNumericExplicit): Use new ConvCast class to
30072 properly generate the overflow opcodes.
30074 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30076 * statement.cs: The correct type for the EmptyExpression is the
30077 element_type, not the variable type. Ravi pointed this out.
30079 2001-12-04 Ravi Pratap <ravi@ximian.com>
30081 * class.cs (Method::Define): Handle PInvoke methods specially
30082 by using DefinePInvokeMethod instead of the usual one.
30084 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
30085 above to do the task of extracting information and defining the method.
30087 2001-12-04 Ravi Pratap <ravi@ximian.com>
30089 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
30090 of the condition for string type.
30092 (Emit): Move that here.
30094 (ArrayCreation::CheckIndices): Keep string literals in their expression
30097 (EmitDynamicInitializers): Handle strings appropriately.
30099 2001-12-04 Miguel de Icaza <miguel@ximian.com>
30101 * codegen.cs (EmitContext): Replace multiple variables with a
30102 single pointer to the current Switch statement.
30104 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
30107 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30111 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
30114 (Foreach.Emit): Foreach on arrays was not setting
30115 up the loop variables (for break/continue).
30117 (GotoCase): Semi-implented.
30119 2001-12-03 Ravi Pratap <ravi@ximian.com>
30121 * attribute.cs (CheckAttribute): Handle system attributes by using
30122 Attribute.GetAttributes to examine information we need.
30124 (GetValidPlaces): Same here.
30126 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
30128 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
30130 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
30132 (Method::Define): Set appropriate flags if we have a DllImport attribute.
30134 (Method::Emit): Handle the case when we are a PInvoke method.
30136 2001-12-03 Miguel de Icaza <miguel@ximian.com>
30138 * expression.cs: Use ResolveWithSimpleName on compound names.
30140 2001-12-02 Ravi Pratap <ravi@ximian.com>
30142 * constant.cs (EmitConstant): Make sure we resolve the associated expression
30143 before trying to reduce it.
30145 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
30147 * constant.cs (LookupConstantValue): Implement.
30149 (EmitConstant): Use the above in emitting the constant.
30151 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
30152 that are user-defined by doing a LookupConstantValue on them.
30154 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
30157 2001-11-29 Miguel de Icaza <miguel@ximian.com>
30159 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
30161 (BaseAccess.DoResolve): Implement.
30163 (MemberAccess.DoResolve): Split this routine into a
30164 ResolveMemberAccess routine that can be used independently
30166 2001-11-28 Miguel de Icaza <miguel@ximian.com>
30168 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
30169 As that share bits of the implementation. Is returns a boolean,
30170 while As returns the Type that is being probed.
30172 2001-12-01 Ravi Pratap <ravi@ximian.com>
30174 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
30175 instead of a Literal - much easier.
30177 (EnumInTransit): Remove - utterly useless :-)
30179 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
30181 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
30183 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
30184 chain when we have no associated expression.
30186 2001-11-30 Ravi Pratap <ravi@ximian.com>
30188 * constant.cs (Define): Use Location while reporting the errror.
30190 Also emit a warning when 'new' is used and there is no inherited
30193 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
30196 (LookupEnumValue): Implement to lookup an enum member's value and define it
30199 (Populate): Re-write accordingly to use the above routine.
30201 2001-11-27 Miguel de Icaza <miguel@ximian.com>
30203 * expression.cs (This): Fix prototype for DoResolveLValue to
30204 override the base class DoResolveLValue.
30206 * cs-parser.cs: Report errors cs574 and cs575 (destructor
30209 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
30210 (we need to load the address of the field here). This fixes
30213 (FieldExpr.DoResolveLValue): Call the DoResolve
30214 function to initialize the Instance expression.
30216 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
30217 correctly the GetEnumerator operation on a value type.
30219 * cs-parser.jay: Add more simple parsing error catches.
30221 * statement.cs (Switch): Add support for string switches.
30222 Handle null specially.
30224 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
30226 2001-11-28 Ravi Pratap <ravi@ximian.com>
30228 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
30230 (declare_local_constant): New helper function.
30232 * statement.cs (AddConstant): Keep a separate record of constants
30234 (IsConstant): Implement to determine if a variable is a constant.
30236 (GetConstantExpression): Implement.
30238 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
30240 * statement.cs (IsVariableDefined): Re-write.
30242 2001-11-27 Ravi Pratap <ravi@ximian.com>
30244 * class.cs (TypeContainer::FindMembers): Look for constants
30245 in the case when we are looking for MemberTypes.Field
30247 * expression.cs (MemberAccess::DoResolve): Check that in the
30248 case we are a FieldExpr and a Literal, we are not being accessed
30249 by an instance reference.
30251 * cs-parser.jay (local_constant_declaration): Implement.
30253 (declaration_statement): Implement for constant declarations.
30255 2001-11-26 Miguel de Icaza <miguel@ximian.com>
30257 * statement.cs (Switch): Catch double defaults.
30259 (Switch): More work on the switch() statement
30260 implementation. It works for integral values now, need to finish
30264 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30266 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
30267 integer literals into other integer literals. To be used by
30270 2001-11-24 Ravi Pratap <ravi@ximian.com>
30272 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
30275 (EmitDynamicInitializers): Cope with the above since we extract data
30276 directly from ArrayData now.
30278 (ExpectInitializers): Keep track of whether initializers are mandatory
30281 (Bounds): Make it a hashtable to prevent the same dimension being
30282 recorded for every element in that dimension.
30284 (EmitDynamicInitializers): Fix bug which prevented the Set array method
30287 Also fix bug which was causing the indices to be emitted in the reverse
30290 2001-11-24 Miguel de Icaza <miguel@ximian.com>
30292 * expression.cs (ArrayCreation): Implement the bits that Ravi left
30293 unfinished. They do not work, because the underlying code is
30296 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30298 * cs-parser.jay: Remove bogus fixme.
30300 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
30301 on Switch statement.
30303 2001-11-23 Ravi Pratap <ravi@ximian.com>
30305 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
30308 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
30309 parameter. Apparently, any expression is allowed.
30311 (ValidateInitializers): Update accordingly.
30313 (CheckIndices): Fix some tricky bugs thanks to recursion.
30315 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
30316 I was being completely brain-dead.
30318 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
30319 and re-write acordingly.
30321 (DelegateInvocation): Re-write accordingly.
30323 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
30325 (MakeByteBlob): Handle types more correctly.
30327 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
30328 initialization from expressions but it is incomplete because I am a complete
30331 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30333 * statement.cs (If.Emit): Fix a bug that generated incorrect code
30334 on If. Basically, we have to return `true' (ie, we do return to
30335 our caller) only if both branches of the if return.
30337 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
30338 short-circuit operators, handle them as short circuit operators.
30340 (Cast.DoResolve): Resolve type.
30341 (Cast.Cast): Take an expression as the target type.
30343 * cs-parser.jay (cast_expression): Remove old hack that only
30344 allowed a limited set of types to be handled. Now we take a
30345 unary_expression and we resolve to a type during semantic
30348 Use the grammar productions from Rhys to handle casts (this is
30349 not complete like Rhys syntax yet, we fail to handle that corner
30350 case that C# has regarding (-x), but we will get there.
30352 2001-11-22 Ravi Pratap <ravi@ximian.com>
30354 * class.cs (EmitFieldInitializer): Take care of the case when we have a
30355 field which is an array type.
30357 * cs-parser.jay (declare_local_variables): Support array initialization too.
30359 * typemanager.cs (MakeKey): Implement.
30361 (everywhere): Use the above appropriately.
30363 * cs-parser.jay (for_statement): Update for array initialization while
30364 declaring variables.
30366 * ecore.cs : The error message was correct, it's the variable's names that
30367 were misleading ;-) Make the code more readable.
30369 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30370 the correct type etc.
30372 (ConvertExplicit): Handle Enum types by examining the underlying type.
30374 2001-11-21 Ravi Pratap <ravi@ximian.com>
30376 * parameter.cs (GetCallingConvention): Always return
30377 CallingConventions.Standard for now.
30379 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30381 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30382 and `r' after calling DoNumericPromotions.
30384 * ecore.cs: Fix error message (the types were in the wrong order).
30386 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30387 BindingFlags.Instance as well
30389 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30390 implicit int literal conversion in an empty cast so that we
30391 propagate the right type upstream.
30393 (UnboxCast): new class used to unbox value types.
30394 (Expression.ConvertExplicit): Add explicit type conversions done
30397 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30398 the target type before applying the implicit LongLiterals to ULong
30401 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30403 * cs-parser.jay (for_statement): Reworked the way For works: now
30404 we declare manually any variables that are introduced in
30405 for_initializer to solve the problem of having out-of-band code
30406 emition (that is what got for broken).
30408 (declaration_statement): Perform the actual variable declaration
30409 that used to be done in local_variable_declaration here.
30411 (local_variable_declaration): Do not declare anything, just pass
30412 the information on a DictionaryEntry
30414 2001-11-20 Ravi Pratap <ravi@ximian.com>
30416 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30417 re-write of the logic to now make it recursive.
30419 (UpdateIndices): Re-write accordingly.
30421 Store element data in a separate ArrayData list in the above methods.
30423 (MakeByteBlob): Implement to dump the array data into a byte array.
30425 2001-11-19 Ravi Pratap <ravi@ximian.com>
30427 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30430 * constant.cs (Define): Implement.
30432 (EmitConstant): Re-write fully.
30434 Pass in location info.
30436 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30439 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30440 DictionaryEntry since we need location info too.
30442 (constant_declaration): Update accordingly.
30444 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30445 code into another method : UpdateIndices.
30447 2001-11-18 Ravi Pratap <ravi@ximian.com>
30449 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30450 some type checking etc.
30452 2001-11-17 Ravi Pratap <ravi@ximian.com>
30454 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30455 bits to provide dimension info if the user skips doing that.
30457 Update second constructor to store the rank correctly.
30459 2001-11-16 Ravi Pratap <ravi@ximian.com>
30461 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30462 and try to implement.
30464 * ../errors/cs0150.cs : Add.
30466 * ../errors/cs0178.cs : Add.
30468 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30470 * statement.cs: Implement foreach on multi-dimensional arrays.
30472 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30473 name of the params argument.
30475 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30476 initializing the array.
30478 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30479 we can use this elsewhere.
30481 * statement.cs: Finish implementation of foreach for single
30484 * cs-parser.jay: Use an out-of-band stack to pass information
30485 around, I wonder why I need this.
30487 foreach_block: Make the new foreach_block the current_block.
30489 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30490 function used to return a static Parameters structure. Used for
30491 empty parameters, as those are created very frequently.
30493 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30495 2001-11-15 Ravi Pratap <ravi@ximian.com>
30497 * interface.cs : Default modifier is private, not public. The
30498 make verify test passes again.
30500 2001-11-15 Ravi Pratap <ravi@ximian.com>
30502 * support.cs (ReflectionParameters): Fix logic to determine
30503 whether the last parameter is a params one. Test 9 passes again.
30505 * delegate.cs (Populate): Register the builders we define with
30506 RegisterParameterForBuilder. Test 19 passes again.
30508 * cs-parser.jay (property_declaration): Reference $6 instead
30509 of $$ to get at the location.
30511 (indexer_declaration): Similar stuff.
30513 (attribute): Ditto.
30515 * class.cs (Property): Register parameters for the Get and Set methods
30516 if they exist. Test 23 passes again.
30518 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30519 call to EmitArguments as we are sure there aren't any params arguments.
30520 Test 32 passes again.
30522 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30523 IndexOutOfRangeException.
30525 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30526 Test 33 now passes again.
30528 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30530 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30531 broke a bunch of things. Will have to come up with a better way
30532 of tracking locations.
30534 * statement.cs: Implemented foreach for single dimension arrays.
30536 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30538 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30539 an error. This removes the lookup from the critical path.
30541 * cs-parser.jay: Removed use of temporary_loc, which is completely
30544 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30546 * support.cs (ReflectionParameters.ParameterModifier): Report
30547 whether the argument is a PARAMS argument or not.
30549 * class.cs: Set the attribute `ParamArrayAttribute' on the
30550 parameter argument.
30552 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30553 and cons_param_array_attribute (ConstructorInfo for
30554 ParamArrayAttribute).,
30556 * codegen.cs: Emit the return using the `Return' statement, that
30557 way we can report the error correctly for missing return values.
30559 * class.cs (Method.Emit): Clean up.
30561 * expression.cs (Argument.Resolve): Take another argument: the
30562 location where this argument is used. Notice that this is not
30563 part of the "Argument" class as to reduce the size of the
30564 structure (we know the approximate location anyways).
30566 Test if the argument is a variable-reference, if not, then
30567 complain with a 206.
30569 (Argument.Emit): Emit addresses of variables.
30571 (Argument.FullDesc): Simplify.
30573 (Invocation.DoResolve): Update for Argument.Resolve.
30575 (ElementAccess.DoResolve): ditto.
30577 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30578 method should be virtual, as this method is always virtual.
30580 (NewDelegate.DoResolve): Update for Argument.Resolve.
30582 * class.cs (ConstructorInitializer.DoResolve): ditto.
30584 * attribute.cs (Attribute.Resolve): ditto.
30586 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30588 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30590 * expression.cs (ParameterReference): Drop IStackStorage and implement
30591 IAssignMethod instead.
30593 (LocalVariableReference): ditto.
30595 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30596 IAssignMethod instead.
30598 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30600 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30601 enumerations that are used in heavily used structures derive from
30602 byte in a laughable and pathetic attempt to reduce memory usage.
30603 This is the kind of pre-optimzations that you should not do at
30604 home without adult supervision.
30606 * expression.cs (UnaryMutator): New class, used to handle ++ and
30607 -- separatedly from the other unary operators. Cleans up the
30608 code, and kills the ExpressionStatement dependency in Unary.
30610 (Unary): Removed `method' and `Arguments' from this class, making
30611 it smaller, and moving it all to SimpleCall, so I can reuse this
30612 code in other locations and avoid creating a lot of transient data
30613 strucutres when not required.
30615 * cs-parser.jay: Adjust for new changes.
30617 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30619 * enum.cs (Enum.Populate): If there is a failure during
30622 * cs-parser.jay (opt_enum_base): we used to catch type errors
30623 here, but this is really incorrect. The type error should be
30624 catched during semantic analysis.
30626 2001-12-11 Ravi Pratap <ravi@ximian.com>
30628 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30629 current_local_parameters as expected since I, in my stupidity, had forgotten
30632 * attribute.cs (GetValidPlaces): Fix stupid bug.
30634 * class.cs (Method::Emit): Perform check on applicability of attributes.
30636 (Constructor::Emit): Ditto.
30638 (Field::Emit): Ditto.
30640 (Field.Location): Store location information.
30642 (Property, Event, Indexer, Operator): Ditto.
30644 * cs-parser.jay (field_declaration): Pass in location for each field.
30646 * ../errors/cs0592.cs : Add.
30648 2001-11-12 Ravi Pratap <ravi@ximian.com>
30650 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30652 (InitCoreTypes): Update accordingly.
30654 (RegisterAttrType, LookupAttr): Implement.
30656 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30657 info about the same.
30659 (Resolve): Update to populate the above as necessary.
30661 (Error592): Helper.
30663 (GetValidPlaces): Helper to the above.
30665 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30667 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30669 2001-11-12 Ravi Pratap <ravi@ximian.com>
30671 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30673 * ../errors/cs0617.cs : Add.
30675 2001-11-11 Ravi Pratap <ravi@ximian.com>
30677 * enum.cs (Emit): Rename to Populate to be more consistent with what
30678 we expect it to do and when exactly it is called.
30680 * class.cs, rootcontext.cs : Update accordingly.
30682 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30683 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30685 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30687 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30688 of a fieldinfo using the above, when dealing with a FieldBuilder.
30690 2001-11-10 Ravi Pratap <ravi@ximian.com>
30692 * ../errors/cs0031.cs : Add.
30694 * ../errors/cs1008.cs : Add.
30696 * ../errrors/cs0543.cs : Add.
30698 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30701 (FindMembers): Implement.
30703 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30704 enums and delegates too.
30706 (enum_types): Rename to builder_to_enum.
30708 (delegate_types): Rename to builder_to_delegate.
30710 * delegate.cs (FindMembers): Implement.
30712 2001-11-09 Ravi Pratap <ravi@ximian.com>
30714 * typemanager.cs (IsEnumType): Implement.
30716 * enum.cs (Emit): Re-write parts to account for the underlying type
30717 better and perform checking etc.
30719 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30720 of the underlying type.
30722 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30725 * enum.cs (error31): Helper to report error #31.
30727 * cs-parser.jay (enum_declaration): Store location of each member too.
30729 * enum.cs (member_to_location): New hashtable.
30731 (AddEnumMember): Update location hashtable.
30733 (Emit): Use the location of each member while reporting errors.
30735 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30737 * cs-parser.jay: A for_initializer if is a
30738 local_variable_declaration really ammount to have an implicit
30739 block with the variable declaration and no initializer for for.
30741 * statement.cs (For.Emit): Cope with null initializers.
30743 This fixes the infinite loop on for initializers.
30745 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30747 * enum.cs: More cleanup.
30749 * ecore.cs: Remove dead code.
30751 * class.cs (Property.Emit): More simplification.
30752 (Event.Emit): ditto.
30754 Reworked to have less levels of indentation.
30756 2001-11-08 Ravi Pratap <ravi@ximian.com>
30758 * class.cs (Property): Emit attributes.
30768 * enum.cs (Emit): Ditto.
30770 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30773 * class.cs (Field, Event, etc.): Move attribute generation into the
30774 Emit method everywhere.
30776 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30777 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30778 as we had no way of defining nested enums !
30780 * rootcontext.cs : Adjust code accordingly.
30782 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30784 2001-11-07 Ravi Pratap <ravi@ximian.com>
30786 * expression.cs (EvalConstantExpression): Move into ecore.cs
30788 * enum.cs (Enum): Rename some members and make them public and readonly
30789 according to our convention.
30791 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30794 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30796 (Enum::Emit): Write a simple version for now which doesn't try to compute
30797 expressions. I shall modify this to be more robust in just a while.
30799 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30801 (TypeContainer::CloseType): Create the Enum types too.
30803 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30805 * expression.cs (EvalConstantExpression): Get rid of completely.
30807 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30808 user-defined values and other cases.
30810 (IsValidEnumLiteral): Helper function.
30812 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30813 out there in the case we had a literal FieldExpr.
30815 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30817 (Literalize): Revamp a bit to take two arguments.
30819 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30821 2001-11-06 Ravi Pratap <ravi@ximian.com>
30823 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30825 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30827 (Resolve): Use the above to ensure we have proper initializers.
30829 2001-11-05 Ravi Pratap <ravi@ximian.com>
30831 * expression.cs (Expression::EvalConstantExpression): New method to
30832 evaluate constant expressions.
30834 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30836 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30838 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30841 (Binary.ResolveOperator): Handle operator != (object a, object b)
30842 and operator == (object a, object b);
30844 (Binary.DoNumericPromotions): Indicate whether the numeric
30845 promotion was possible.
30847 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30850 Made the ArrayAccess implement interface IAssignMethod instead of
30851 IStackStore as the order in which arguments are passed reflects
30854 * assign.cs: Instead of using expr.ExprClass to select the way of
30855 assinging, probe for the IStackStore/IAssignMethod interfaces.
30857 * typemanager.cs: Load InitializeArray definition.
30859 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30860 static data that can be used to initialize arrays.
30862 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30864 * expression.cs: Handle operator== and operator!= for booleans.
30866 (Conditioal.Reduce): Implement reducer for the ?: operator.
30868 (Conditional.Resolve): Implement dead code elimination.
30870 (Binary.Resolve): Catch string literals and return a new
30871 concatenated string.
30873 (Unary.Reduce): Implement reduction of unary expressions.
30875 * ecore.cs: Split out the expression core handling here.
30877 (Expression.Reduce): New method used to perform constant folding
30878 and CSE. This is needed to support constant-expressions.
30880 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30881 targets, and optimize for !x.
30883 2001-11-04 Ravi Pratap <ravi@ximian.com>
30885 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30886 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30887 set custom atttributes.
30889 * literal.cs (Literal::GetValue): New abstract method to return the actual
30890 value of the literal, cast as an object.
30892 (*Literal): Implement GetValue method.
30894 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30895 expressions to the arraylist but objects of type Argument.
30897 * class.cs (TypeContainer::Emit): Emit our attributes too.
30899 (Method::Emit, Constructor::Emit): Ditto.
30901 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30902 to be ignoring earlier.
30904 2001-11-03 Ravi Pratap <ravi@ximian.com>
30906 * attribute.cs (AttributeSection::Define): Implement to do the business
30907 of constructing a CustomAttributeBuilder.
30909 (Attribute): New trivial class. Increases readability of code.
30911 * cs-parser.jay : Update accordingly.
30913 (positional_argument_list, named_argument_list, named_argument): New rules
30915 (attribute_arguments): Use the above so that we are more correct.
30917 2001-11-02 Ravi Pratap <ravi@ximian.com>
30919 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30920 to perform all checks for a method with a params parameter.
30922 (Invocation::OverloadResolve): Update to use the above method and therefore
30923 cope correctly with params method invocations.
30925 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30928 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30929 constructors in our parent too because we can't afford to miss out on
30932 * attribute.cs (AttributeSection): New name for the class Attribute
30934 Other trivial changes to improve readability.
30936 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30937 use the new class names.
30939 2001-11-01 Ravi Pratap <ravi@ximian.com>
30941 * class.cs (Method::Define): Complete definition for params types too
30943 (Indexer::Define): Ditto.
30945 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30946 Cope everywhere with a request for info about the array parameter.
30948 2001-11-01 Ravi Pratap <ravi@ximian.com>
30950 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30952 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30953 local_variable_type to extract the string corresponding to the type.
30955 (local_variable_type): Fixup the action to use the new helper method.
30957 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30960 * expression.cs : Clean out code which uses the above.
30962 2001-10-31 Ravi Pratap <ravi@ximian.com>
30964 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30965 and bale out if necessary by returning a false.
30967 (RegisterProperty): Ditto.
30969 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30970 and print out appropriate error messages.
30972 * interface.cs (everywhere): Ditto.
30974 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30975 location to constructor.
30977 * class.cs (Property, Event, Indexer): Update accordingly.
30979 * ../errors/cs111.cs : Added.
30981 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30982 of a method, as laid down by the spec.
30984 (Invocation::OverloadResolve): Use the above method.
30986 2001-10-31 Ravi Pratap <ravi@ximian.com>
30988 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30989 now take a TypeContainer and a Parameters object.
30991 (ParameterData): Modify return type of ParameterModifier method to be
30992 Parameter.Modifier and not a string.
30994 (ReflectionParameters, InternalParameters): Update accordingly.
30996 * expression.cs (Argument::GetParameterModifier): Same here.
30998 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30999 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
31000 symbol in it at all so maybe this is only for now.
31002 2001-10-30 Ravi Pratap <ravi@ximian.com>
31004 * support.cs (InternalParameters): Constructor now takes an extra argument
31005 which is the actual Parameters class.
31007 (ParameterDesc): Update to provide info on ref/out modifiers.
31009 * class.cs (everywhere): Update call to InternalParameters to pass in
31010 the second argument too.
31012 * support.cs (ParameterData): Add ParameterModifier, which is a method
31013 to return the modifier info [ref/out etc]
31015 (InternalParameters, ReflectionParameters): Implement the above.
31017 * expression.cs (Argument::ParameterModifier): Similar function to return
31018 info about the argument's modifiers.
31020 (Invocation::OverloadResolve): Update to take into account matching modifiers
31023 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
31024 a new SetFormalParameters object which we pass to InternalParameters.
31026 2001-10-30 Ravi Pratap <ravi@ximian.com>
31028 * expression.cs (NewArray): Merge into the ArrayCreation class.
31030 2001-10-29 Ravi Pratap <ravi@ximian.com>
31032 * expression.cs (NewArray): Merge classes NewBuiltinArray and
31033 NewUserdefinedArray into one as there wasn't much of a use in having
31036 * expression.cs (Argument): Change field's name to ArgType from Type.
31038 (Type): New readonly property which returns the proper type, taking into
31039 account ref/out modifiers.
31041 (everywhere): Adjust code accordingly for the above.
31043 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
31044 whether we are emitting for a ref or out parameter.
31046 * expression.cs (Argument::Emit): Use the above field to set the state.
31048 (LocalVariableReference::Emit): Update to honour the flag and emit the
31051 * parameter.cs (Attributes): Set the correct flags for ref parameters.
31053 * expression.cs (Argument::FullDesc): New function to provide a full desc.
31055 * support.cs (ParameterData): Add method ParameterDesc to the interface.
31057 (ReflectionParameters, InternalParameters): Implement the above method.
31059 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
31062 (Invocation::FullMethodDesc): Ditto.
31064 2001-10-29 Miguel de Icaza <miguel@ximian.com>
31066 * cs-parser.jay: Add extra production for the second form of array
31069 * expression.cs (ArrayCreation): Update to reflect the above
31072 * Small changes to prepare for Array initialization.
31074 2001-10-28 Miguel de Icaza <miguel@ximian.com>
31076 * typemanager.cs (ImplementsInterface): interface might be null;
31077 Deal with this problem;
31079 Also, we do store negative hits on the cache (null values), so use
31080 this instead of calling t.GetInterfaces on the type everytime.
31082 2001-10-28 Ravi Pratap <ravi@ximian.com>
31084 * typemanager.cs (IsBuiltinType): New method to help determine the same.
31086 * expression.cs (New::DoResolve): Get rid of array creation code and instead
31087 split functionality out into different classes.
31089 (New::FormArrayType): Move into NewBuiltinArray.
31091 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
31094 (NewBuiltinArray): New class to handle creation of built-in arrays.
31096 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
31097 account creation of one-dimensional arrays.
31099 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
31101 (NewUserdefinedArray::DoResolve): Implement.
31103 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
31105 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
31106 we maintain inside the TypeManager. This is necessary to perform lookups on the
31109 (LookupType): Update to perform GetType on the module builders too.
31111 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
31113 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
31115 2001-10-23 Ravi Pratap <ravi@ximian.com>
31117 * expression.cs (New::DoResolve): Implement guts of array creation.
31119 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
31121 2001-10-27 Miguel de Icaza <miguel@ximian.com>
31123 * expression.cs: Fix bug I introduced lsat night that broke
31126 (Expression.Resolve): Report a 246 error (can not resolve name)
31127 if we find a SimpleName in the stream.
31129 (Expression.ResolveLValue): Ditto.
31131 (Expression.ResolveWithSimpleName): This function is a variant of
31132 ResolveName, this one allows SimpleNames to be returned without a
31133 warning. The only consumer of SimpleNames is MemberAccess
31135 2001-10-26 Miguel de Icaza <miguel@ximian.com>
31137 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
31138 might arrive here. I have my doubts that this is correct.
31140 * statement.cs (Lock): Implement lock statement.
31142 * cs-parser.jay: Small fixes to support `lock' and `using'
31144 * cs-tokenizer.cs: Remove extra space
31146 * driver.cs: New flag --checked, allows to turn on integer math
31149 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
31150 Threading.Monitor.Exit
31152 2001-10-23 Miguel de Icaza <miguel@ximian.com>
31154 * expression.cs (IndexerAccess::DoResolveLValue): Set the
31155 Expression Class to be IndexerAccess.
31157 Notice that Indexer::DoResolve sets the eclass to Value.
31159 2001-10-22 Miguel de Icaza <miguel@ximian.com>
31161 * class.cs (TypeContainer::Emit): Emit code for indexers.
31163 * assign.cs (IAssignMethod): New interface implemented by Indexers
31164 and Properties for handling assignment.
31166 (Assign::Emit): Simplify and reuse code.
31168 * expression.cs (IndexerAccess, PropertyExpr): Implement
31169 IAssignMethod, clean up old code.
31171 2001-10-22 Ravi Pratap <ravi@ximian.com>
31173 * typemanager.cs (ImplementsInterface): New method to determine if a type
31174 implements a given interface. Provides a nice cache too.
31176 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
31179 (ConvertReferenceExplicit): Ditto.
31181 * delegate.cs (Delegate::Populate): Update to define the parameters on the
31182 various methods, with correct names etc.
31184 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
31185 Operator.UnaryNegation.
31187 * cs-parser.jay (operator_declarator): Be a little clever in the case where
31188 we have a unary plus or minus operator.
31190 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
31193 * everywhere : update accordingly.
31195 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
31198 * class.cs (Method::Define): For the case where we are implementing a method
31199 inherited from an interface, we need to set the MethodAttributes.Final flag too.
31200 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
31202 2001-10-21 Ravi Pratap <ravi@ximian.com>
31204 * interface.cs (FindMembers): Implement to work around S.R.E
31207 * typemanager.cs (IsInterfaceType): Implement.
31209 (FindMembers): Update to handle interface types too.
31211 * expression.cs (ImplicitReferenceConversion): Re-write bits which
31212 use IsAssignableFrom as that is not correct - it doesn't work.
31214 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
31215 and accordingly override EmitStatement.
31217 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
31218 using the correct logic :-)
31220 2001-10-19 Ravi Pratap <ravi@ximian.com>
31222 * ../errors/cs-11.cs : Add to demonstrate error -11
31224 2001-10-17 Miguel de Icaza <miguel@ximian.com>
31226 * assign.cs (Assign::Resolve): Resolve right hand side first, and
31227 then pass this as a hint to ResolveLValue.
31229 * expression.cs (FieldExpr): Add Location information
31231 (FieldExpr::LValueResolve): Report assignment to readonly
31234 (Expression::ExprClassFromMemberInfo): Pass location information.
31236 (Expression::ResolveLValue): Add new method that resolves an
31239 (Expression::DoResolveLValue): Default invocation calls
31242 (Indexers): New class used to keep track of indexers in a given
31245 (IStackStore): Renamed from LValue, as it did not really describe
31246 what this did. Also ResolveLValue is gone from this interface and
31247 now is part of Expression.
31249 (ElementAccess): Depending on the element access type
31251 * typemanager.cs: Add `indexer_name_type' as a Core type
31252 (System.Runtime.CompilerServices.IndexerNameAttribute)
31254 * statement.cs (Goto): Take a location.
31256 2001-10-18 Ravi Pratap <ravi@ximian.com>
31258 * delegate.cs (Delegate::VerifyDelegate): New method to verify
31259 if two delegates are compatible.
31261 (NewDelegate::DoResolve): Update to take care of the case when
31262 we instantiate a delegate from another delegate.
31264 * typemanager.cs (FindMembers): Don't even try to look up members
31265 of Delegate types for now.
31267 2001-10-18 Ravi Pratap <ravi@ximian.com>
31269 * delegate.cs (NewDelegate): New class to take care of delegate
31272 * expression.cs (New): Split the delegate related code out into
31273 the NewDelegate class.
31275 * delegate.cs (DelegateInvocation): New class to handle delegate
31278 * expression.cs (Invocation): Split out delegate related code into
31279 the DelegateInvocation class.
31281 2001-10-17 Ravi Pratap <ravi@ximian.com>
31283 * expression.cs (New::DoResolve): Implement delegate creation fully
31284 and according to the spec.
31286 (New::DoEmit): Update to handle delegates differently.
31288 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
31289 because of which we were printing out arguments in reverse order !
31291 * delegate.cs (VerifyMethod): Implement to check if the given method
31292 matches the delegate.
31294 (FullDelegateDesc): Implement.
31296 (VerifyApplicability): Implement.
31298 * expression.cs (Invocation::DoResolve): Update to accordingly handle
31299 delegate invocations too.
31301 (Invocation::Emit): Ditto.
31303 * ../errors/cs1593.cs : Added.
31305 * ../errors/cs1594.cs : Added.
31307 * delegate.cs (InstanceExpression, TargetMethod): New properties.
31309 2001-10-16 Ravi Pratap <ravi@ximian.com>
31311 * typemanager.cs (intptr_type): Core type for System.IntPtr
31313 (InitCoreTypes): Update for the same.
31315 (iasyncresult_type, asynccallback_type): Ditto.
31317 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
31320 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
31323 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
31324 the builders for the 4 members of a delegate type :-)
31326 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
31329 * expression.cs (New::DoResolve): Implement guts for delegate creation.
31331 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
31333 2001-10-15 Miguel de Icaza <miguel@ximian.com>
31335 * statement.cs (Break::Emit): Implement.
31336 (Continue::Emit): Implement.
31338 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
31339 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
31340 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
31341 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
31344 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
31345 properties that track the label for the current loop (begin of the
31346 loop and end of the loop).
31348 2001-10-15 Ravi Pratap <ravi@ximian.com>
31350 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
31351 use of emitting anything at all.
31353 * class.cs, rootcontext.cs : Get rid of calls to the same.
31355 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
31357 (Populate): Define the constructor correctly and set the implementation
31360 * typemanager.cs (delegate_types): New hashtable to hold delegates that
31363 (AddDelegateType): Implement.
31365 (IsDelegateType): Implement helper method.
31367 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31369 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31370 and accordingly handle it.
31372 * delegate.cs (Populate): Take TypeContainer argument.
31373 Implement bits to define the Invoke method. However, I still haven't figured out
31374 how to take care of the native int bit :-(
31376 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31377 Qualify the name of the delegate, not its return type !
31379 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31382 (StandardConversionExists): Checking for array types turns out to be recursive.
31384 (ConvertReferenceExplicit): Implement array conversion.
31386 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31388 2001-10-12 Ravi Pratap <ravi@ximian.com>
31390 * cs-parser.jay (delegate_declaration): Store the fully qualified
31391 name as it is a type declaration.
31393 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31396 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31397 as TypeContainer::DefineType.
31399 (Populate): Method in which all the definition of the various methods (Invoke)
31402 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31405 (CloseDelegate): Finally creates the delegate.
31407 * class.cs (TypeContainer::DefineType): Update to define delegates.
31408 (Populate, Emit and CloseType): Do the same thing here too.
31410 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31411 delegates in all these operations.
31413 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31415 * expression.cs: LocalTemporary: a new expression used to
31416 reference a temporary that has been created.
31418 * assign.cs: Handle PropertyAccess back here, so that we can
31419 provide the proper semantic access to properties.
31421 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31422 a few more explicit conversions.
31424 * modifiers.cs: `NEW' modifier maps to HideBySig.
31426 * expression.cs (PropertyExpr): Make this into an
31427 ExpressionStatement, and support the EmitStatement code path.
31429 Perform get/set error checking, clean up the interface.
31431 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31432 them into toplevel access objects.
31434 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31436 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31439 * typemanager.cs: Keep track here of our PropertyBuilders again to
31440 work around lameness in SRE.
31442 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31444 * expression.cs (LValue::LValueResolve): New method in the
31445 interface, used to perform a second resolution pass for LValues.
31447 (This::DoResolve): Catch the use of this in static methods.
31449 (This::LValueResolve): Implement.
31451 (This::Store): Remove warning, assigning to `this' in structures
31454 (Invocation::Emit): Deal with invocation of
31455 methods on value types. We need to pass the address to structure
31456 methods rather than the object itself. (The equivalent code to
31457 emit "this" for structures leaves the entire structure on the
31458 stack instead of a pointer to it).
31460 (ParameterReference::DoResolve): Compute the real index for the
31461 argument based on whether the method takes or not a `this' pointer
31462 (ie, the method is static).
31464 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31465 value types returned from functions when we need to invoke a
31466 method on the sturcture.
31469 2001-10-11 Ravi Pratap <ravi@ximian.com>
31471 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31472 defining the type in the Modulebuilder or Typebuilder. This is to take
31473 care of nested types which need to be defined on the TypeBuilder using
31474 DefineNestedMethod.
31476 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31477 methods in RootContext, only ported to be part of TypeContainer.
31479 (TypeContainer::GetInterfaceOrClass): Ditto.
31481 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31483 * interface.cs (Interface::DefineInterface): New method. Does exactly
31484 what RootContext.CreateInterface did earlier, only it takes care of nested types
31487 (Interface::GetInterfaces): Move from RootContext here and port.
31489 (Interface::GetInterfaceByName): Same here.
31491 * rootcontext.cs (ResolveTree): Re-write.
31493 (PopulateTypes): Re-write.
31495 * class.cs (TypeContainer::Populate): Populate nested types too.
31496 (TypeContainer::Emit): Emit nested members too.
31498 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31499 instead just use the name argument passed in as it is already fully
31502 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31503 to TypeContainer mapping to see if a type is user-defined.
31505 * class.cs (TypeContainer::CloseType): Implement.
31507 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31508 the default constructor.
31510 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31513 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31515 * interface.cs (CloseType): Create the type here.
31517 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31520 Remove all the methods which are now in TypeContainer.
31522 2001-10-10 Ravi Pratap <ravi@ximian.com>
31524 * delegate.cs (Define): Re-write bits to define the delegate
31527 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31529 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31531 * expression.cs (ImplicitReferenceConversion): handle null as well
31532 as a source to convert to any reference type.
31534 * statement.cs (Return): Perform any implicit conversions to
31535 expected return type.
31537 Validate use of return statement.
31539 * codegen.cs (EmitContext): Pass the expected return type here.
31541 * class.cs (Method, Constructor, Property): Pass expected return
31542 type to EmitContext.
31544 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31546 * expression.cs: Make DoResolve take an EmitContext instead of a
31549 Replaced `l' and `location' for `loc', for consistency.
31551 (Error, Warning): Remove unneeded Tc argument.
31553 * assign.cs, literal.cs, constant.cs: Update to new calling
31556 * codegen.cs: EmitContext now contains a flag indicating whether
31557 code is being generated in a static method or not.
31559 * cs-parser.jay: DecomposeQI, new function that replaces the old
31560 QualifiedIdentifier. Now we always decompose the assembled
31561 strings from qualified_identifier productions into a group of
31564 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31566 * rootcontext.cs: Deal with field-less struct types correctly now
31567 by passing the size option to Define Type.
31569 * class.cs: Removed hack that created one static field.
31571 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31573 * statement.cs: Moved most of the code generation here.
31575 2001-10-09 Ravi Pratap <ravi@ximian.com>
31577 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31580 (ElementAccess): Remove useless bits for now - keep checks as the spec
31583 2001-10-08 Ravi Pratap <ravi@ximian.com>
31585 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31586 and start performing checks according to the spec.
31588 2001-10-07 Ravi Pratap <ravi@ximian.com>
31590 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31591 rank_specifiers instead.
31593 (rank_specifiers): Change the order in which the rank specifiers are stored
31595 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31597 * expression.cs (ElementAccess): Implement the LValue interface too.
31599 2001-10-06 Ravi Pratap <ravi@ximian.com>
31601 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31602 except that user defined conversions are not included.
31604 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31605 perform the conversion of the return type, if necessary.
31607 (New::DoResolve): Check whether we are creating an array or an object
31608 and accordingly do the needful.
31610 (New::Emit): Same here.
31612 (New::DoResolve): Implement guts of array creation.
31614 (New::FormLookupType): Helper function.
31616 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31618 * codegen.cs: Removed most of the code generation here, and move the
31619 corresponding code generation bits to the statement classes.
31621 Added support for try/catch/finalize and throw.
31623 * cs-parser.jay: Added support for try/catch/finalize.
31625 * class.cs: Catch static methods having the flags override,
31626 virtual or abstract.
31628 * expression.cs (UserCast): This user cast was not really doing
31629 what it was supposed to do. Which is to be born in fully resolved
31630 state. Parts of the resolution were being performed at Emit time!
31634 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31636 * expression.cs: Implicity convert the result from UserCast.
31638 2001-10-05 Ravi Pratap <ravi@ximian.com>
31640 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31641 prevented it from working correctly.
31643 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31644 merely ConvertImplicit.
31646 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31648 * typemanager.cs: Make the LookupTypeContainer function static,
31649 and not per-instance.
31651 * class.cs: Make static FindMembers (the one that takes a Type
31654 * codegen.cs: Add EmitForeach here.
31656 * cs-parser.jay: Make foreach a toplevel object instead of the
31657 inline expansion, as we need to perform semantic analysis on it.
31659 2001-10-05 Ravi Pratap <ravi@ximian.com>
31661 * expression.cs (Expression::ImplicitUserConversion): Rename to
31662 UserDefinedConversion.
31664 (Expression::UserDefinedConversion): Take an extra argument specifying
31665 whether we look for explicit user conversions too.
31667 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31669 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31671 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31672 with the appropriate arguments.
31674 * cs-parser.jay (cast_expression): Record location too.
31676 * expression.cs (Cast): Record location info.
31678 (Expression::ConvertExplicit): Take location argument.
31680 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31681 to determine if we are doing explicit conversions.
31683 (UserCast::Emit): Update accordingly.
31685 (Expression::ConvertExplicit): Report an error if everything fails.
31687 * ../errors/cs0030.cs : Add.
31689 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31691 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31692 virtual and newslot bits.
31694 * class.cs (TypeContainer::RegisterRequiredImplementations):
31695 Record methods we need.
31697 (TypeContainer::MakeKey): Helper function to make keys for
31698 MethodBases, since the Methodbase key is useless.
31700 (TypeContainer::Populate): Call RegisterRequiredImplementations
31701 before defining the methods.
31703 Create a mapping for method_builders_to_methods ahead of time
31704 instead of inside a tight loop.
31706 (::RequireMethods): Accept an object as the data to set into the
31707 hashtable so we can report interface vs abstract method mismatch.
31709 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31711 * report.cs: Make all of it static.
31713 * rootcontext.cs: Drop object_type and value_type computations, as
31714 we have those in the TypeManager anyways.
31716 Drop report instance variable too, now it is a global.
31718 * driver.cs: Use try/catch on command line handling.
31720 Add --probe option to debug the error reporting system with a test
31723 * report.cs: Add support for exiting program when a probe
31724 condition is reached.
31726 2001-10-03 Ravi Pratap <ravi@ximian.com>
31728 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31729 we do a forcible conversion regardless of type, to check if
31730 ForceConversion returns a null.
31732 (Binary::error19): Use location to report error.
31734 (Unary::error23): Use location here too.
31736 * ../errors/cs0019.cs : Check in.
31738 * ../errors/cs0023.cs : Check in.
31740 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31741 case of a non-null MethodInfo object with a length of 0 !
31743 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31744 an applicable member - according to the spec :-)
31745 Also fix logic to find members in base types.
31747 (Unary::ResolveOperator): Same here.
31749 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31750 as I was getting thoroughly confused between this and error19 :-)
31752 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31753 (::FindMostEncompassedType): Implement.
31754 (::FindMostEncompassingType): Implement.
31755 (::StandardConversionExists): Implement.
31757 (UserImplicitCast): Re-vamp. We now need info about most specific
31758 source and target types so that we can do the necessary conversions.
31760 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31761 mathematical union with no duplicates.
31763 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31765 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31766 in order from base classes to child classes, so that we can in
31767 child classes look up in our parent for method names and
31768 attributes (required for handling abstract, virtual, new, override
31769 constructs: we need to instrospect our base class, and if we dont
31770 populate the classes in order, the introspection might be
31771 incorrect. For example, a method could query its parent before
31772 the parent has any methods and would determine that the parent has
31773 no abstract methods (while it could have had them)).
31775 (RootContext::CreateType): Record the order in which we define the
31778 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31780 * class.cs (TypeContainer::Populate): Also method definitions can
31781 fail now, keep track of this.
31783 (TypeContainer::FindMembers): Implement support for
31784 DeclaredOnly/noDeclaredOnly flag.
31786 (Constructor::Emit) Return the ConstructorBuilder.
31788 (Method::Emit) Return the MethodBuilder.
31789 Check for abstract or virtual methods to be public.
31791 * rootcontext.cs (RootContext::CreateType): Register all the
31792 abstract methods required for the class to be complete and the
31793 interface methods that must be implemented.
31795 * cs-parser.jay: Report error 501 (method requires body if it is
31796 not marked abstract or extern).
31798 * expression.cs (TypeOf::Emit): Implement.
31800 * typemanager.cs: runtime_handle_type, new global type.
31802 * class.cs (Property::Emit): Generate code for properties.
31804 2001-10-02 Ravi Pratap <ravi@ximian.com>
31806 * expression.cs (Unary::ResolveOperator): Find operators on base type
31807 too - we now conform exactly to the spec.
31809 (Binary::ResolveOperator): Same here.
31811 * class.cs (Operator::Define): Fix minor quirk in the tests.
31813 * ../errors/cs0215.cs : Added.
31815 * ../errors/cs0556.cs : Added.
31817 * ../errors/cs0555.cs : Added.
31819 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31821 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31822 single integer which is really efficient
31824 2001-10-01 Ravi Pratap <ravi@ximian.com>
31826 * expression.cs (Expression::ImplicitUserConversion): Use location
31827 even in the case when we are examining True operators.
31829 * class.cs (Operator::Define): Perform extensive checks to conform
31830 with the rules for operator overloading in the spec.
31832 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31833 some of the other conversions mentioned in the spec.
31835 * typemanager.cs (array_type): New static member for the System.Array built-in
31838 (cloneable_interface): For System.ICloneable interface.
31840 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31841 we start resolving the tree and populating types.
31843 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31845 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31847 * expression.cs (Expression::ExprClassFromMemberInfo,
31848 Expression::Literalize): Create literal expressions from
31849 FieldInfos which are literals.
31851 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31852 type casts, because they were wrong. The test suite in tests
31855 (ImplicitNumericConversion): ushort to ulong requires a widening
31858 Int32 constant to long requires widening cast as well.
31860 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31861 for integers because the type on the stack is not i4.
31863 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31865 * expression.cs (report118): require location argument.
31867 * parameter.cs: Do not dereference potential null value.
31869 * class.cs: Catch methods that lack the `new' keyword when
31870 overriding a name. Report warnings when `new' is used without
31871 anything being there to override.
31873 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31875 * class.cs: Only add constructor to hashtable if it is non-null
31876 (as now constructors can fail on define).
31878 (TypeManager, Class, Struct): Take location arguments.
31880 Catch field instance initialization in structs as errors.
31882 accepting_filter: a new filter for FindMembers that is static so
31883 that we dont create an instance per invocation.
31885 (Constructor::Define): Catch errors where a struct constructor is
31888 * cs-parser.jay: Pass location information for various new
31891 * delegate.cs (Delegate): take a location argument.
31893 * driver.cs: Do not call EmitCode if there were problesm in the
31894 Definition of the types, as many Builders wont be there.
31896 * decl.cs (Decl::Decl): Require a location argument.
31898 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31899 into integers, and find the most appropiate integer for it.
31901 * literal.cs: Implement ULongLiteral.
31903 * rootcontext.cs: Provide better information about the location of
31904 failure when CreateType fails.
31906 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31908 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31911 * expression.cs (Binary::CheckShiftArguments): Add missing type
31913 (Binary::ResolveOperator): Add type to the logical and and logical
31914 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31917 (Binary::DoNumericPromotions): In the case where either argument
31918 is ulong (and most signed types combined with ulong cause an
31919 error) perform implicit integer constant conversions as well.
31921 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31923 * expression.cs (UserImplicitCast): Method should always be
31925 (Invocation::BetterConversion): Simplified test for IntLiteral.
31927 (Expression::ImplicitNumericConversion): Split this routine out.
31928 Put the code that performs implicit constant integer conversions
31931 (Expression::Resolve): Become a wrapper around DoResolve so we can
31932 check eclass and type being set after resolve.
31934 (Invocation::Badness): Remove this dead function
31936 (Binary::ResolveOperator): Do not compute the expensive argumnets
31937 unless we have a union for it.
31939 (Probe::Emit): Is needs to do an isinst and then
31940 compare against null.
31942 (::CanConvert): Added Location argument. If the Location argument
31943 is null (Location.Null), then we do not report errors. This is
31944 used by the `probe' mechanism of the Explicit conversion. We do
31945 not want to generate an error for something that the user
31946 explicitly requested to be casted. But the pipeline for an
31947 explicit cast first tests for potential implicit casts.
31949 So for now, if the Location is null, it means `Probe only' to
31950 avoid adding another argument. Might have to revise this
31953 (ClassCast): New class used to type cast objects into arbitrary
31954 classes (used in Explicit Reference Conversions).
31956 Implement `as' as well.
31958 Reverted all the patches from Ravi below: they were broken:
31960 * The use of `level' as a mechanism to stop recursive
31961 invocations is wrong. That was there just to catch the
31962 bug with a strack trace but not as a way of addressing
31965 To fix the problem we have to *understand* what is going
31966 on and the interactions and come up with a plan, not
31967 just get things going.
31969 * The use of the type conversion cache that I proposed
31970 last night had an open topic: How does this work across
31971 protection domains. A user defined conversion might not
31972 be public in the location where we are applying the
31973 conversion, a different conversion might be selected
31974 (ie, private A->B (better) but public B->A (worse),
31975 inside A, A->B applies, but outside it, B->A will
31978 * On top of that (ie, even if the above is solved),
31979 conversions in a cache need to be abstract. Ie, `To
31980 convert from an Int to a Short use an OpcodeCast', not
31981 `To convert from an Int to a Short use the OpcodeCast on
31982 the variable 5' (which is what this patch was doing).
31984 2001-09-28 Ravi Pratap <ravi@ximian.com>
31986 * expression.cs (Invocation::ConversionExists): Re-write to use
31987 the conversion cache
31989 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31990 cache all conversions done, not just user-defined ones.
31992 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31993 to determine if a conversion exists instead of acutually trying to
31994 perform the conversion. It's faster too.
31996 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31997 and only then attempt the implicit conversion.
31999 2001-09-28 Ravi Pratap <ravi@ximian.com>
32001 * expression.cs (ConvertImplicit): Use a cache for conversions
32002 already found. Check level of recursion and bail out if necessary.
32004 2001-09-28 Miguel de Icaza <miguel@ximian.com>
32006 * typemanager.cs (string_concat_string_string, string_concat_object_object):
32007 Export standard methods that we expect for string operations.
32009 * statement.cs (Block::UsageWarning): Track usage of variables and
32010 report the errors for not used variables.
32012 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
32015 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32017 * codegen.cs: remove unnneded code
32019 * expression.cs: Removed BuiltinTypeAccess class
32021 Fix the order in which implicit conversions are
32024 The previous fixed dropped support for boxed conversions (adding a
32025 test to the test suite now)
32027 (UserImplicitCast::CanConvert): Remove test for source being null,
32028 that code is broken. We should not feed a null to begin with, if
32029 we do, then we should track the bug where the problem originates
32030 and not try to cover it up here.
32032 Return a resolved expression of type UserImplicitCast on success
32033 rather than true/false. Ravi: this is what I was talking about,
32034 the pattern is to use a static method as a "constructor" for
32037 Also, do not create arguments until the very last minute,
32038 otherwise we always create the arguments even for lookups that
32039 will never be performed.
32041 (UserImplicitCast::Resolve): Eliminate, objects of type
32042 UserImplicitCast are born in a fully resolved state.
32044 * typemanager.cs (InitCoreTypes): Init also value_type
32045 (System.ValueType).
32047 * expression.cs (Cast::Resolve): First resolve the child expression.
32049 (LValue): Add new method AddressOf to be used by
32052 Change the argument of Store to take an EmitContext instead of an
32053 ILGenerator, because things like FieldExpr need to be able to call
32054 their children expression to generate the instance code.
32056 (Expression::Error, Expression::Warning): Sugar functions for
32059 (Expression::MemberLookup): Accept a TypeContainer instead of a
32060 Report as the first argument.
32062 (Expression::ResolvePrimary): Killed. I still want to improve
32063 this as currently the code is just not right.
32065 (Expression::ResolveMemberAccess): Simplify, but it is still
32068 (Unary::Resolve): Catch errors in AddressOf operators.
32070 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
32071 index to a byte for the short-version, or the compiler will choose
32072 the wrong Emit call, which generates the wrong data.
32074 (ParameterReference::Emit, ::Store): same.
32076 (FieldExpr::AddressOf): Implement.
32078 * typemanager.cs: TypeManager: made public variable instead of
32081 * driver.cs: document --fatal.
32083 * report.cs (ErrorMessage, WarningMessage): new names for the old
32084 Error and Warning classes.
32086 * cs-parser.jay (member_access): Turn built-in access to types
32087 into a normal simplename
32089 2001-09-27 Ravi Pratap <ravi@ximian.com>
32091 * expression.cs (Invocation::BetterConversion): Fix to cope
32092 with q being null, since this was introducing a bug.
32094 * expression.cs (ConvertImplicit): Do built-in conversions first.
32096 2001-09-27 Ravi Pratap <ravi@ximian.com>
32098 * expression.cs (UserImplicitCast::Resolve): Fix bug.
32100 2001-09-27 Ravi Pratap <ravi@ximian.com>
32102 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
32103 I had introduced long ago (what's new ?).
32105 * expression.cs (UserImplicitCast::CanConvert): Static method to do
32106 the work of all the checking.
32107 (ConvertImplicit): Call CanConvert and only then create object if necessary.
32108 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
32110 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
32111 that is the right way.
32113 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
32114 overloading resolution. Use everywhere instead of cutting and pasting code.
32116 (Binary::ResolveOperator): Use MakeUnionSet.
32118 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
32119 we have to convert to bool types. Not complete yet.
32121 2001-09-27 Miguel de Icaza <miguel@ximian.com>
32123 * typemanager.cs (TypeManager::CSharpName): support ushort.
32125 * expression.cs (Expression::TryImplicitIntConversion): Attempts
32126 to provide an expression that performsn an implicit constant int
32127 conversion (section 6.1.6).
32128 (Expression::ConvertImplicitRequired): Reworked to include
32129 implicit constant expression conversions.
32131 (Expression::ConvertNumericExplicit): Finished.
32133 (Invocation::Emit): If InstanceExpression is null, then it means
32134 that we perform a call on this.
32136 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32138 * expression.cs (Unary::Emit): Remove some dead code.
32139 (Probe): Implement Resolve and Emit for `is'.
32140 (Expression::ConvertImplicitRequired): Attempt to do constant
32141 expression conversions here. Maybe should be moved to
32142 ConvertImplicit, but I am not sure.
32143 (Expression::ImplicitLongConstantConversionPossible,
32144 Expression::ImplicitIntConstantConversionPossible): New functions
32145 that tell whether is it possible to apply an implicit constant
32146 expression conversion.
32148 (ConvertNumericExplicit): Started work on explicit numeric
32151 * cs-parser.jay: Update operator constants.
32153 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
32154 (Parameters::GetSignature): Hook up VerifyArgs here.
32155 (Parameters::VerifyArgs): Verifies that no two arguments have the
32158 * class.cs (Operator): Update the operator names to reflect the
32159 ones that the spec expects (as we are just stringizing the
32162 * expression.cs (Unary::ResolveOperator): Fix bug: Use
32163 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
32164 previous usage did only work for our methods.
32165 (Expression::ConvertImplicit): Handle decimal implicit numeric
32166 conversions as well.
32167 (Expression::InternalTypeConstructor): Used to invoke constructors
32168 on internal types for default promotions.
32170 (Unary::Emit): Implement special handling for the pre/post
32171 increment/decrement for overloaded operators, as they need to have
32172 the same semantics as the other operators.
32174 (Binary::ResolveOperator): ditto.
32175 (Invocation::ConversionExists): ditto.
32176 (UserImplicitCast::Resolve): ditto.
32178 2001-09-26 Ravi Pratap <ravi@ximian.com>
32180 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
32181 operator, return after emitting body. Regression tests pass again !
32183 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
32184 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
32185 (Invocation::OverloadResolve): Ditto.
32186 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
32188 * everywhere : update calls to the above methods accordingly.
32190 2001-09-26 Miguel de Icaza <miguel@ximian.com>
32192 * assign.cs (Assign): Make it inherit from ExpressionStatement.
32194 * expression.cs (ExpressionStatement): New base class used for
32195 expressions that can appear in statements, so that we can provide
32196 an alternate path to generate expression that do not leave a value
32199 (Expression::Emit, and all the derivatives): We no longer return
32200 whether a value is left on the stack or not. Every expression
32201 after being emitted leaves a single value on the stack.
32203 * codegen.cs (EmitContext::EmitStatementExpression): Use the
32204 facilties of ExpressionStatement if possible.
32206 * cs-parser.jay: Update statement_expression.
32208 2001-09-25 Miguel de Icaza <miguel@ximian.com>
32210 * driver.cs: Change the wording of message
32212 2001-09-25 Ravi Pratap <ravi@ximian.com>
32214 * expression.cs (Binary::ResolveOperator): Had forgottten to set
32215 the type of the expression to the return type of the method if
32216 we have an overloaded operator match ! The regression tests pass again !
32217 (Unary::ResolveOperator): Ditto.
32219 * expression.cs (Invocation::ConversionExists): Correct the member lookup
32220 to find "op_Implicit", not "implicit" ;-)
32221 (UserImplicitCast): New class to take care of user-defined implicit conversions.
32222 (ConvertImplicit, ForceConversion): Take TypeContainer argument
32224 * everywhere : Correct calls to the above accordingly.
32226 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
32227 (ConvertImplicit): Do user-defined conversion if it exists.
32229 2001-09-24 Miguel de Icaza <miguel@ximian.com>
32231 * assign.cs: track location.
32232 (Resolve): Use implicit conversions on assignment.
32234 * literal.cs: Oops. Not good, Emit of short access values should
32235 pass (Bytes) or the wrong argument will be selected.
32237 * expression.cs (Unary::Emit): Emit code for -expr.
32239 (Unary::ResolveOperator): Handle `Substract' for non-constants
32240 (substract from zero from the non-constants).
32241 Deal with Doubles as well.
32243 (Expression::ConvertImplicitRequired): New routine that reports an
32244 error if no implicit conversion exists.
32246 (Invocation::OverloadResolve): Store the converted implicit
32247 expressions if we make them
32249 2001-09-24 Ravi Pratap <ravi@ximian.com>
32251 * class.cs (ConstructorInitializer): Take a Location argument.
32252 (ConstructorBaseInitializer): Same here.
32253 (ConstructorThisInitializer): Same here.
32255 * cs-parser.jay : Update all calls accordingly.
32257 * expression.cs (Unary, Binary, New): Take location argument.
32258 Update accordingly everywhere.
32260 * cs-parser.jay : Update all calls to the above to take a location
32263 * class.cs : Ditto.
32265 2001-09-24 Ravi Pratap <ravi@ximian.com>
32267 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
32268 (Invocation::BetterConversion): Same here
32269 (Invocation::ConversionExists): Ditto.
32271 (Invocation::ConversionExists): Implement.
32273 2001-09-22 Ravi Pratap <ravi@ximian.com>
32275 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
32276 Also take an additional TypeContainer argument.
32278 * All over : Pass in TypeContainer as argument to OverloadResolve.
32280 * typemanager.cs (CSharpName): Update to check for the string type and return
32283 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
32286 2001-09-21 Ravi Pratap <ravi@ximian.com>
32288 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
32289 (Invocation::BetterFunction): Implement.
32290 (Invocation::BetterConversion): Implement.
32291 (Invocation::ConversionExists): Skeleton, no implementation yet.
32293 Okay, things work fine !
32295 2001-09-21 Miguel de Icaza <miguel@ximian.com>
32297 * typemanager.cs: declare and load enum_type, delegate_type and
32300 * expression.cs (Expression::Emit): Now emit returns a value that
32301 tells whether a value is left on the stack or not. This strategy
32302 might be reveted tomorrow with a mechanism that would address
32303 multiple assignments.
32304 (Expression::report118): Utility routine to report mismatches on
32307 (Unary::Report23): Report impossible type/operator combination
32310 (Unary::IsIncrementableNumber): Whether the type can be
32311 incremented or decremented with add.
32312 (Unary::ResolveOperator): Also allow enumerations to be bitwise
32314 (Unary::ResolveOperator): Implement ++, !, ~,
32316 (Invocation::Emit): Deal with new Emit convetion.
32318 * All Expression derivatives: Updated their Emit method to return
32319 whether they leave values on the stack or not.
32321 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
32322 stack for expressions that are statements.
32324 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32326 * expression.cs (LValue): New interface. Must be implemented by
32328 (LocalVariableReference, ParameterReference, FieldExpr): Implement
32331 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
32332 interface for generating code, simplifies the code.
32334 2001-09-20 Ravi Pratap <ravi@ximian.com>
32336 * expression.cs (everywhere): Comment out return statements in ::Resolve
32337 methods to avoid the warnings.
32339 2001-09-20 Miguel de Icaza <miguel@ximian.com>
32341 * driver.cs (parse): Report error 2001 if we can not open the
32344 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
32347 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
32350 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
32351 otherwise nested blocks end up with the same index.
32353 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
32355 * expression.cs: Instead of having FIXMEs in the Resolve
32356 functions, throw exceptions so it is obvious that we are facing a
32359 * cs-parser.jay (invocation_expression): Pass Location information.
32361 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
32362 Use a basename for those routines because .NET does not like paths
32365 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32368 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32370 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32371 are loading the correct data types (throws an exception if not).
32372 (TypeManager::InitCoreTypes): Use CoreLookupType
32374 * expression.cs (Unary::ResolveOperator): return the child
32375 expression for expressions which are just +expr.
32376 (Unary::ResolveOperator): Return negative literals for -LITERAL
32377 expressions (otherwise they are Unary {Literal}).
32378 (Invocation::Badness): Take into account `Implicit constant
32379 expression conversions'.
32381 * literal.cs (LongLiteral): Implement long literal class.
32382 (IntLiteral): export the `Value' of the intliteral.
32384 2001-09-19 Ravi Pratap <ravi@ximian.com>
32386 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32388 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32389 instead of 'Operator'
32391 * expression.cs (Binary::ResolveOperator): Update accordingly.
32392 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32395 * cs-parser.jay (unary_expression): Update to use the new names.
32397 * gen-treedump.cs (GetUnary): Same here.
32399 * expression.cs (Unary::Resolve): Implement.
32400 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32401 operators are found instead of making noise ;-)
32402 (Unary::ResolveOperator): New method to do precisely the same thing which
32403 Binary::ResolveOperator does for Binary expressions.
32404 (Unary.method, .Arguments): Add.
32405 (Unary::OperName): Implement.
32406 (Unary::ForceConversion): Copy and Paste !
32408 * class.cs (Operator::Define): Fix a small bug for the case when we have
32411 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32412 for the inbuilt operators. Only overloading works for now ;-)
32414 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32416 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32417 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32419 * expression.cs (This::Emit): Implement.
32420 (This::Resolve): Implement.
32421 (TypeOf:Resolve): Implement.
32422 (Expression::ResolveSimpleName): Add an implicit this to instance
32424 (MemberAccess::Resolve): Deal with Parameters and Fields.
32425 Bind instance variable to Field expressions.
32426 (FieldExpr::Instance): New field used to track the expression that
32427 represents the object instance.
32428 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32430 (FieldExpr::Emit): Implement.
32432 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32433 the last instruction contains a return opcode to avoid generating
32434 the last `ret' instruction (this generates correct code, and it is
32435 nice to pass the peverify output).
32437 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32438 initializer for static and instance variables.
32439 (Constructor::Emit): Allow initializer to be null in the case of
32440 static constructors. Only emit initializer for instance
32443 (TypeContainer::FindMembers): Return a null array if there are no
32446 Also fix the code for the MemberTypes.Method branch, as it was not
32447 scanning that for operators (or tried to access null variables before).
32449 * assign.cs (Assign::Emit): Handle instance and static fields.
32453 * driver.cs: Stop compilation if there are parse errors.
32455 * cs-parser.jay (constructor_declaration): Provide default base
32456 initializer for non-static constructors.
32457 (constructor_declarator): Do not provide a default base
32458 initializers if none was specified.
32459 Catch the fact that constructors should not have parameters.
32461 * class.cs: Do not emit parent class initializers for static
32462 constructors, that should be flagged as an error.
32464 2001-09-18 Ravi Pratap <ravi@ximian.com>
32466 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32467 Move back code into TypeContainer::Populate.
32469 2001-09-18 Ravi Pratap <ravi@ximian.com>
32471 * class.cs (TypeContainer::AddConstructor): Fix the check to
32472 compare against Name, not Basename.
32473 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32475 * cs-parser.jay : Update accordingly.
32477 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32478 for methods, don't forget to look into the operators too.
32479 (RegisterMethodBuilder): Helper method to take care of this for
32480 methods, constructors and operators.
32481 (Operator::Define): Completely revamp.
32482 (Operator.OperatorMethod, MethodName): New fields.
32483 (TypeContainer::Populate): Move the registering of builders into
32484 RegisterMethodBuilder.
32485 (Operator::Emit): Re-write.
32487 * expression.cs (Binary::Emit): Comment out code path to emit method
32488 invocation stuff for the case when we have a user defined operator. I am
32489 just not able to get it right !
32491 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32493 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32496 (Expression::MemberLookup): Provide a version that allows to
32497 specify the MemberTypes and BindingFlags.
32499 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32500 so it was not fetching variable information from outer blocks.
32502 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32503 Beforefieldinit as it was buggy.
32505 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32506 that Ravi put here.
32508 * class.cs (Constructor::Emit): Only emit if block is not null.
32509 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32510 deal with this by semantically definining it as if the user had
32513 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32514 constructors as we now "emit" them at a higher level.
32516 (TypeContainer::DefineDefaultConstructor): Used to define the
32517 default constructors if none was provided.
32519 (ConstructorInitializer): Add methods Resolve and Emit.
32521 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32523 2001-09-17 Ravi Pratap <ravi@ximian.com>
32525 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32526 the default constructor builder with our hashtable for methodbuilders
32529 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32530 and argument_count is 0 in which case we have a match.
32531 (Binary::ResolveOperator): More null checking and miscellaneous coding
32534 2001-09-17 Ravi Pratap <ravi@ximian.com>
32536 * rootcontext.cs (IsNameSpace): Compare against null.
32538 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32540 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32541 and Unary::Operator.
32543 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32546 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32547 we have overloaded operators.
32548 (Binary::ResolveOperator): Implement the part which does the operator overload
32551 * class.cs (Operator::Emit): Implement.
32552 (TypeContainer::Emit): Emit the operators we have too.
32554 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32555 the case when we have a user-defined operator.
32557 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32559 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32561 2001-09-16 Ravi Pratap <ravi@ximian.com>
32563 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32564 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32565 (Constructor::Emit): Implement.
32566 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32567 if we have no work to do.
32568 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32571 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32572 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32574 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32577 2001-09-15 Ravi Pratap <ravi@ximian.com>
32579 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32581 (Tree::RecordNamespace): Method to do what the name says ;-)
32582 (Tree::Namespaces): Property to get at the namespaces hashtable.
32584 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32587 * rootcontext.cs (IsNamespace): Fixed it :-)
32589 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32591 * class.cs (TypeContainer::FindMembers): Add support for
32593 (MethodCore): New class that encapsulates both the shared aspects
32594 of a Constructor and a Method.
32595 (Method, Constructor): Factored pieces into MethodCore.
32597 * driver.cs: Added --fatal which makes errors throw exceptions.
32598 Load System assembly as well as part of the standard library.
32600 * report.cs: Allow throwing exceptions on errors for debugging.
32602 * modifiers.cs: Do not use `parent', instead use the real type
32603 container to evaluate permission settings.
32605 * class.cs: Put Ravi's patch back in. He is right, and we will
32606 have to cope with the
32608 2001-09-14 Ravi Pratap <ravi@ximian.com>
32610 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32611 FamORAssem, not FamANDAssem.
32613 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32615 * driver.cs: Added --parse option that only parses its input files
32618 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32619 incorrect. IsTopLevel is not used to tell whether an object is
32620 root_types or not (that can be achieved by testing this ==
32621 root_types). But to see if this is a top-level *class* (not
32622 necessarly our "toplevel" container).
32624 2001-09-14 Ravi Pratap <ravi@ximian.com>
32626 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32627 parent instead of a direct call to GetType.
32629 2001-09-14 Ravi Pratap <ravi@ximian.com>
32631 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32632 Modifiers.TypeAttr. This should just be a call to that method.
32634 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32635 object so that we can determine if we are top-level or not.
32637 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32640 * enum.cs (Enum::Define): Ditto.
32642 * modifiers.cs (FieldAttr): Re-write.
32644 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32645 (TypeContainer::HaveStaticConstructor): New property to provide access
32646 to precisely that info.
32648 * modifiers.cs (MethodAttr): Re-write.
32649 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32651 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32652 of top-level types as claimed.
32654 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32656 * expression.cs (MemberLookup): Fruitless attempt to lookup
32657 constructors. Maybe I need to emit default constructors? That
32658 might be it (currently .NET emits this for me automatically).
32659 (Invocation::OverloadResolve): Cope with Arguments == null.
32660 (Invocation::EmitArguments): new function, shared by the new
32661 constructor and us.
32662 (Invocation::Emit): Handle static and instance methods. Emit
32663 proper call instruction for virtual or non-virtual invocations.
32664 (New::Emit): Implement.
32665 (New::Resolve): Implement.
32666 (MemberAccess:Resolve): Implement.
32667 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32668 to track instances.
32669 (FieldExpr::Resolve): Set type.
32671 * support.cs: Handle empty arguments.
32673 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32674 SimpleLookup): Auxiliary routines to help parse a qualifier
32677 Update qualifier_identifier rule.
32679 * codegen.cs: Removed debugging messages.
32681 * class.cs: Make this a global thing, this acts just as a "key" to
32682 objects that we might have around.
32684 (Populate): Only initialize method_builders_to_methods once.
32686 * expression.cs (PropertyExpr): Initialize type from the
32689 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32690 Resolve pattern. Attempt to implicitly convert value to boolean.
32693 * expression.cs: Set the type for the int32/int32 argument case.
32694 (Binary::ResolveOperator): Set the return type to boolean for
32695 comparission operators
32697 * typemanager.cs: Remove debugging print code.
32699 (Invocation::Resolve): resolve type.
32701 * class.cs: Allocate a MemberInfo of the correct size, as the code
32702 elsewhere depends on the test to reflect the correct contents.
32704 (Method::) Keep track of parameters, due to System.Reflection holes
32706 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32709 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32710 of the exact size and return that.
32712 (Class::LookupMethodByBuilder): New function that maps
32713 MethodBuilders to its methods. Required to locate the information
32714 on methods because System.Reflection bit us again.
32716 * support.cs: New file, contains an interface ParameterData and
32717 two implementations: ReflectionParameters and InternalParameters
32718 used to access Parameter information. We will need to grow this
32721 * expression.cs (Invocation::GetParameterData): implement a cache
32722 and a wrapper around the ParameterData creation for methods.
32723 (Invocation::OverloadResolve): Use new code.
32725 2001-09-13 Ravi Pratap <ravi@ximian.com>
32727 * class.cs (TypeContainer::EmitField): Remove and move into
32728 (Field::Define): here and modify accordingly.
32729 (Field.FieldBuilder): New member.
32730 (TypeContainer::Populate): Update accordingly.
32731 (TypeContainer::FindMembers): Implement.
32733 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32735 * statement.cs: (VariableInfo::VariableType): New field to be
32736 initialized with the full type once it is resolved.
32738 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32740 * parameter.cs (GetParameterInfo): Use a type cache to compute
32741 things only once, and to reuse this information
32743 * expression.cs (LocalVariableReference::Emit): Implement.
32744 (OpcodeCast::Emit): fix.
32746 (ParameterReference::Resolve): Implement.
32747 (ParameterReference::Emit): Implement.
32749 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32750 that are expressions need to stay as Expressions.
32752 * typemanager.cs (CSharpName): Returns the C# name of a type if
32755 * expression.cs (Expression::ConvertImplicit): New function that
32756 implements implicit type conversions.
32758 (Expression::ImplicitReferenceConversion): Implements implicit
32759 reference conversions.
32761 (EmptyCast): New type for transparent casts.
32763 (OpcodeCast): New type for casts of types that are performed with
32764 a sequence of bytecodes.
32766 (BoxedCast): New type used for casting value types into reference
32767 types. Emits a box opcode.
32769 (Binary::DoNumericPromotions): Implements numeric promotions of
32770 and computation of the Binary::Type.
32772 (Binary::EmitBranchable): Optimization.
32774 (Binary::Emit): Implement code emission for expressions.
32776 * typemanager.cs (TypeManager): Added two new core types: sbyte
32779 2001-09-12 Ravi Pratap <ravi@ximian.com>
32781 * class.cs (TypeContainer::FindMembers): Method which does exactly
32782 what Type.FindMembers does, only we don't have to use reflection. No
32783 implementation yet.
32785 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32786 typecontainer objects as we need to get at them.
32787 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32789 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32790 typecontainer object.
32792 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32793 of just a Report object.
32795 2001-09-11 Ravi Pratap <ravi@ximian.com>
32797 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32799 (TypeContainer::Populate): Now define the delegates of the type too.
32800 (TypeContainer.Delegates): Property to access the list of delegates defined
32803 * delegates.cs (Delegate::Define): Implement partially.
32805 * modifiers.cs (TypeAttr): Handle more flags.
32807 2001-09-11 Ravi Pratap <ravi@ximian.com>
32809 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32811 (Operator::Define): Re-write logic to get types by using the LookupType method
32812 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32813 (Indexer::Define): Ditto.
32814 (Event::Define): Ditto.
32815 (Property::Define): Ditto.
32817 2001-09-10 Ravi Pratap <ravi@ximian.com>
32819 * class.cs (TypeContainer::Populate): Now define operators too.
32820 (TypeContainer.Operators): New property to access the list of operators
32822 (Operator.OperatorMethodBuilder): New member to hold the method builder
32823 for the operator we are defining.
32824 (Operator::Define): Implement.
32826 2001-09-10 Ravi Pratap <ravi@ximian.com>
32828 * class.cs (Event::Define): Make the prefixes of the accessor methods
32829 addOn_ and removeOn_
32831 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32832 of the location being passed in too. Ideally, this should go later since all
32833 error reporting should be done through the Report object.
32835 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32836 (Populate): Iterate thru the indexers we have and define them too.
32837 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32838 for the get and set accessors.
32839 (Indexer::Define): Implement.
32841 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32843 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32844 my previous implementation, did not work.
32846 * typemanager.cs: Add a couple of missing types (the longs).
32848 * literal.cs: Use TypeManager.bool_type instead of getting it.
32850 * expression.cs (EventExpr): New kind of expressions.
32851 (Expressio::ExprClassFromMemberInfo): finish
32853 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32855 * assign.cs: Emit stores to static fields differently.
32857 2001-09-08 Ravi Pratap <ravi@ximian.com>
32859 * Merge in changes and adjust code to tackle conflicts. Backed out my
32860 code in Assign::Resolve ;-)
32862 2001-09-08 Ravi Pratap <ravi@ximian.com>
32864 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32865 instead Report.Error and also pass in the location.
32866 (CSharpParser::Lexer): New readonly property to return the reference
32867 to the Tokenizer object.
32868 (declare_local_variables): Use Report.Error with location instead of plain
32872 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32873 (Operator.CheckBinaryOperator): Ditto.
32875 * cs-parser.jay (operator_declarator): Update accordingly.
32877 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32878 (CheckBinaryOperator): Same here.
32880 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32881 on the name without any prefixes of namespace names etc. This is because we
32882 already might have something already fully qualified like
32883 'System.Console.WriteLine'
32885 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32887 2001-09-07 Ravi Pratap <ravi@ximian.com>
32889 * cs-tokenizer.cs (location): Return a string which also contains
32892 * expression.cs (ElementAccess): New class for expressions of the
32893 type 'element access.'
32894 (BaseAccess): New class for expressions of the type 'base access.'
32895 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32898 * cs-parser.jay (element_access): Implement action.
32899 (base_access): Implement actions.
32900 (checked_expression, unchecked_expression): Implement.
32902 * cs-parser.jay (local_variable_type): Correct and implement.
32903 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32905 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32907 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32908 name and the specifiers.
32910 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32912 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32913 making them all public ;-)
32915 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32918 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32920 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32922 (FieldExpr, PropertyExprs): New resolved expressions.
32923 (SimpleName::MemberStaticCheck): Perform static checks for access
32924 to non-static fields on static methods. Maybe this should be
32925 generalized for MemberAccesses.
32926 (SimpleName::ResolveSimpleName): More work on simple name
32929 * cs-parser.jay (primary_expression/qualified_identifier): track
32930 the parameter index.
32932 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32933 (EmitContext::EmitBoolExpression): Chain to expression generation
32934 instead of temporary hack.
32935 (::EmitStatementExpression): Put generic expression code generation.
32937 * assign.cs (Assign::Emit): Implement variable assignments to
32938 local variables, parameters and fields.
32940 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32942 * statement.cs (Block::GetVariableInfo): New method, returns the
32943 VariableInfo for a variable name in a block.
32944 (Block::GetVariableType): Implement in terms of GetVariableInfo
32946 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32947 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32949 2001-09-06 Ravi Pratap <ravi@ximian.com>
32951 * cs-parser.jay (operator_declaration): Continue on my quest : update
32952 to take attributes argument.
32953 (event_declaration): Ditto.
32954 (enum_declaration): Ditto.
32955 (indexer_declaration): Ditto.
32957 * class.cs (Operator::Operator): Update constructor accordingly.
32958 (Event::Event): Ditto.
32960 * delegate.cs (Delegate::Delegate): Same here.
32962 * enum.cs (Enum::Enum): Same here.
32964 2001-09-05 Ravi Pratap <ravi@ximian.com>
32966 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32968 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32970 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32971 being passed around as an arraylist.
32972 (Attributes::AddAttribute): Method to add attribute sections.
32974 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32975 (struct_declaration): Update accordingly.
32976 (constant_declaration): Update.
32977 (field_declaration): Update.
32978 (method_header): Update.
32979 (fixed_parameter): Update.
32980 (parameter_array): Ditto.
32981 (property_declaration): Ditto.
32982 (destructor_declaration): Ditto.
32984 * class.cs (Struct::Struct): Update constructors accordingly.
32985 (Class::Class): Ditto.
32986 (Field::Field): Ditto.
32987 (Method::Method): Ditto.
32988 (Property::Property): Ditto.
32989 (TypeContainer::OptAttribute): update property's return type.
32991 * interface.cs (Interface.opt_attributes): New member.
32992 (Interface::Interface): Update to take the extra Attributes argument.
32994 * parameter.cs (Parameter::Parameter): Ditto.
32996 * constant.cs (Constant::Constant): Ditto.
32998 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32999 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
33000 the attributes as a parameter.
33001 (InterfaceProperty): Update constructor call.
33002 (InterfaceEvent): Ditto.
33003 (InterfaceMethod): Ditto.
33004 (InterfaceIndexer): Ditto.
33006 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
33007 pass the attributes too.
33008 (interface_event_declaration): Ditto.
33009 (interface_property_declaration): Ditto.
33010 (interface_method_declaration): Ditto.
33011 (interface_declaration): Ditto.
33013 2001-09-05 Miguel de Icaza <miguel@ximian.com>
33015 * class.cs (Method::Define): Track the "static Main" definition to
33016 create an entry point.
33018 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
33019 EntryPoint if we find it.
33021 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
33022 (EmitContext::ig): Make this variable public.
33024 * driver.cs: Make the default output file be the first file name
33025 with the .exe extension.
33027 Detect empty compilations
33029 Handle various kinds of output targets. Handle --target and
33030 rename -t to --dumper.
33032 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
33033 methods inherited from Expression return now an Expression. This
33034 will is used during the tree rewriting as we resolve them during
33037 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
33038 the spec. Missing entirely is the information about
33039 accessability of elements of it.
33041 (Expression::ExprClassFromMemberInfo): New constructor for
33042 Expressions that creates a fully initialized Expression based on
33043 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
33046 (Invocation::Resolve): Begin implementing resolution of invocations.
33048 * literal.cs (StringLiteral): Implement Emit.
33050 2001-09-05 Ravi Pratap <ravi@ximian.com>
33052 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
33055 2001-09-04 Ravi Pratap <ravi@ximian.com>
33057 * cs-parser.jay (attribute_arguments): Implement actions.
33058 (attribute): Fix bug in production. Implement action.
33059 (attribute_list): Implement.
33060 (attribute_target): Implement.
33061 (attribute_target_specifier, opt_target_specifier): Implement
33062 (CheckAttributeTarget): New method to check if the attribute target
33064 (attribute_section): Implement.
33065 (opt_attributes): Implement.
33067 * attribute.cs : New file to handle attributes.
33068 (Attribute): Class to hold attribute info.
33070 * cs-parser.jay (opt_attribute_target_specifier): Remove production
33071 (attribute_section): Modify production to use 2 different rules to
33072 achieve the same thing. 1 s/r conflict down !
33073 Clean out commented, useless, non-reducing dimension_separator rules.
33075 * class.cs (TypeContainer.attributes): New member to hold list
33076 of attributes for a type.
33077 (Struct::Struct): Modify to take one more argument, the attribute list.
33078 (Class::Class): Ditto.
33079 (Field::Field): Ditto.
33080 (Method::Method): Ditto.
33081 (Property::Property): Ditto.
33083 * cs-parser.jay (struct_declaration): Update constructor call to
33084 pass in the attributes too.
33085 (class_declaration): Ditto.
33086 (constant_declaration): Ditto.
33087 (field_declaration): Ditto.
33088 (method_header): Ditto.
33089 (fixed_parameter): Ditto.
33090 (parameter_array): Ditto.
33091 (property_declaration): Ditto.
33093 * constant.cs (Constant::Constant): Update constructor similarly.
33094 Use System.Collections.
33096 * parameter.cs (Parameter::Parameter): Update as above.
33098 2001-09-02 Ravi Pratap <ravi@ximian.com>
33100 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
33101 (TypeContainer.delegates): New member to hold list of delegates.
33103 * cs-parser.jay (delegate_declaration): Implement the action correctly
33104 this time as I seem to be on crack ;-)
33106 2001-09-02 Miguel de Icaza <miguel@ximian.com>
33108 * rootcontext.cs (RootContext::IsNamespace): new function, used to
33109 tell whether an identifier represents a namespace.
33111 * expression.cs (NamespaceExpr): A namespace expression, used only
33112 temporarly during expression resolution.
33113 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
33114 utility functions to resolve names on expressions.
33116 2001-09-01 Miguel de Icaza <miguel@ximian.com>
33118 * codegen.cs: Add hook for StatementExpressions.
33120 * class.cs: Fix inverted test for static flag in methods.
33122 2001-09-02 Ravi Pratap <ravi@ximian.com>
33124 * class.cs (Operator::CheckUnaryOperator): Correct error number used
33125 to make it coincide with MS' number.
33126 (Operator::CheckBinaryOperator): Ditto.
33128 * ../errors/errors.txt : Remove error numbers added earlier.
33130 * ../errors/cs1019.cs : Test case for error # 1019
33132 * ../errros/cs1020.cs : Test case for error # 1020
33134 * cs-parser.jay : Clean out commented cruft.
33135 (dimension_separators, dimension_separator): Comment out. Ostensibly not
33136 used anywhere - non-reducing rule.
33137 (namespace_declarations): Non-reducing rule - comment out.
33139 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
33140 with TypeContainer::AddEnum.
33142 * delegate.cs : New file for delegate handling classes.
33143 (Delegate): Class for declaring delegates.
33145 * makefile : Update.
33147 * cs-parser.jay (delegate_declaration): Implement.
33149 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
33151 * class.cs (Event::Define): Implement.
33152 (Event.EventBuilder): New member.
33154 * class.cs (TypeContainer::Populate): Update to define all enums and events
33156 (Events): New property for the events arraylist we hold. Shouldn't we move to using
33157 readonly fields for all these cases ?
33159 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33161 * class.cs (Property): Revamp to use the convention of making fields readonly.
33162 Accordingly modify code elsewhere.
33164 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
33165 the Define method of the Property class.
33167 * class.cs : Clean up applied patch and update references to variables etc. Fix
33169 (TypeContainer::Populate): Update to define all the properties we have. Also
33170 define all enumerations.
33172 * enum.cs (Define): Implement.
33174 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
33176 * cs-parser.jay (overloadable_operator): The semantic value is an
33177 enum of the Operator class.
33178 (operator_declarator): Implement actions.
33179 (operator_declaration): Implement.
33181 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
33182 validity of definitions.
33183 (Operator::CheckBinaryOperator): Static method to check for binary operators
33184 (TypeContainer::AddOperator): New method to add an operator to a type.
33186 * cs-parser.jay (indexer_declaration): Added line to actually call the
33187 AddIndexer method so it gets added ;-)
33189 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
33190 already taken care of by the MS compiler ?
33192 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33194 * class.cs (Operator): New class for operator declarations.
33195 (Operator::OpType): Enum for the various operators.
33197 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
33199 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
33200 ostensibly handle this in semantic analysis.
33202 * cs-parser.jay (general_catch_clause): Comment out
33203 (specific_catch_clauses, specific_catch_clause): Ditto.
33204 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
33205 (catch_args, opt_catch_args): New productions.
33206 (catch_clause): Rewrite to use the new productions above
33207 (catch_clauses): Modify accordingly.
33208 (opt_catch_clauses): New production to use in try_statement
33209 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
33210 and re-write the code in the actions to extract the specific and
33211 general catch clauses by being a little smart ;-)
33213 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
33214 Hooray, try and catch statements parse fine !
33216 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33218 * statement.cs (Block::GetVariableType): Fix logic to extract the type
33219 string from the hashtable of variables.
33221 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
33222 I end up making that mistake ;-)
33223 (catch_clauses): Fixed gross error which made Key and Value of the
33224 DictionaryEntry the same : $1 !!
33226 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33228 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
33230 * cs-parser.jay (event_declaration): Correct to remove the semicolon
33231 when the add and remove accessors are specified.
33233 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
33235 * cs-parser.jay (IndexerDeclaration): New helper class to hold
33236 information about indexer_declarator.
33237 (indexer_declarator): Implement actions.
33238 (parsing_indexer): New local boolean used to keep track of whether
33239 we are parsing indexers or properties. This is necessary because
33240 implicit_parameters come into picture even for the get accessor in the
33241 case of an indexer.
33242 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
33244 * class.cs (Indexer): New class for indexer declarations.
33245 (TypeContainer::AddIndexer): New method to add an indexer to a type.
33246 (TypeContainer::indexers): New member to hold list of indexers for the
33249 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33251 * cs-parser.jay (add_accessor_declaration): Implement action.
33252 (remove_accessor_declaration): Implement action.
33253 (event_accessors_declaration): Implement
33254 (variable_declarators): swap statements for first rule - trivial.
33256 * class.cs (Event): New class to hold information about event
33258 (TypeContainer::AddEvent): New method to add an event to a type
33259 (TypeContainer::events): New member to hold list of events.
33261 * cs-parser.jay (event_declaration): Implement actions.
33263 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
33265 * cs-parser.jay (dim_separators): Implement. Make it a string
33266 concatenating all the commas together, just as they appear.
33267 (opt_dim_separators): Modify accordingly
33268 (rank_specifiers): Update accordingly. Basically do the same
33269 thing - instead, collect the brackets here.
33270 (opt_rank_sepcifiers): Modify accordingly.
33271 (array_type): Modify to actually return the complete type string
33272 instead of ignoring the rank_specifiers.
33273 (expression_list): Implement to collect the expressions
33274 (variable_initializer): Implement. We make it a list of expressions
33275 essentially so that we can handle the array_initializer case neatly too.
33276 (variable_initializer_list): Implement.
33277 (array_initializer): Make it a list of variable_initializers
33278 (opt_array_initializer): Modify accordingly.
33280 * expression.cs (New::NType): Add enumeration to help us
33281 keep track of whether we have an object/delegate creation
33282 or an array creation.
33283 (New:NewType, New::Rank, New::Indices, New::Initializers): New
33284 members to hold data about array creation.
33285 (New:New): Modify to update NewType
33286 (New:New): New Overloaded contructor for the array creation
33289 * cs-parser.jay (array_creation_expression): Implement to call
33290 the overloaded New constructor.
33292 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
33294 * class.cs (TypeContainer::Constructors): Return member
33295 constructors instead of returning null.
33297 2001-08-26 Miguel de Icaza <miguel@ximian.com>
33299 * typemanager.cs (InitCoreTypes): Initialize the various core
33300 types after we have populated the type manager with the user
33301 defined types (this distinction will be important later while
33302 compiling corlib.dll)
33304 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
33305 on Expression Classification. Now all expressions have a method
33306 `Resolve' and a method `Emit'.
33308 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
33309 generation from working. Also add some temporary debugging
33312 2001-08-24 Miguel de Icaza <miguel@ximian.com>
33314 * codegen.cs: Lots of code generation pieces. This is only the
33315 beginning, will continue tomorrow with more touches of polish. We
33316 handle the fundamentals of if, while, do, for, return. Others are
33317 trickier and I need to start working on invocations soon.
33319 * gen-treedump.cs: Bug fix, use s.Increment here instead of
33322 * codegen.cs (EmitContext): New struct, used during code
33323 emission to keep a context. Most of the code generation will be
33326 * cs-parser.jay: Add embedded blocks to the list of statements of
33327 this block. So code generation proceeds in a top down fashion.
33329 2001-08-23 Miguel de Icaza <miguel@ximian.com>
33331 * statement.cs: Add support for multiple child blocks.
33333 2001-08-22 Miguel de Icaza <miguel@ximian.com>
33335 * codegen.cs (EmitCode): New function, will emit the code for a
33336 Block of code given a TypeContainer and its ILGenerator.
33338 * statement.cs (Block): Standard public readonly optimization.
33339 (Block::Block constructors): Link children.
33340 (Block::Child): Child Linker.
33341 (Block::EmitVariables): Emits IL variable declarations.
33343 * class.cs: Drop support for MethodGroups here, delay until
33345 (Method::): Applied the same simplification that I did before, and
33346 move from Properties to public readonly fields.
33347 (Method::ParameterTypes): Returns the parameter types for the
33348 function, and implements a cache that will be useful later when I
33349 do error checking and the semantic analysis on the methods is
33351 (Constructor::GetCallingConvention): Renamed from CallingConvetion
33352 and made a method, optional argument tells whether this is a class
33353 or a structure to apply the `has-this' bit.
33354 (Method::GetCallingConvention): Implement, returns the calling
33356 (Method::Define): Defines the type, a second pass is performed
33357 later to populate the methods.
33359 (Constructor::ParameterTypes): implement a cache similar to the
33360 one on Method::ParameterTypes, useful later when we do semantic
33363 (TypeContainer::EmitMethod): New method. Emits methods.
33365 * expression.cs: Removed MethodGroup class from here.
33367 * parameter.cs (Parameters::GetCallingConvention): new method.
33369 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33371 * class.cs (TypeContainer::Populate): Drop RootContext from the
33374 (Constructor::CallingConvention): Returns the calling convention.
33375 (Constructor::ParameterTypes): Returns the constructor parameter
33378 (TypeContainer::AddConstructor): Keep track of default constructor
33379 and the default static constructor.
33381 (Constructor::) Another class that starts using `public readonly'
33382 instead of properties.
33384 (Constructor::IsDefault): Whether this is a default constructor.
33386 (Field::) use readonly public fields instead of properties also.
33388 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33389 track of static constructors; If none is used, turn on
33390 BeforeFieldInit in the TypeAttributes.
33392 * cs-parser.jay (opt_argument_list): now the return can be null
33393 for the cases where there are no arguments.
33395 (constructor_declarator): If there is no implicit `base' or
33396 `this', then invoke the default parent constructor.
33398 * modifiers.cs (MethodAttr): New static function maps a set of
33399 modifiers flags into a MethodAttributes enum
33400 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33401 MethodAttr, TypeAttr to represent the various mappings where the
33402 modifiers are used.
33403 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33405 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33407 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33410 * interface.cs (PopulateIndexer): Implemented the code generator
33411 for interface indexers.
33413 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33415 * interface.cs (InterfaceMemberBase): Now we track the new status
33418 (PopulateProperty): Implement property population. Woohoo! Got
33419 Methods and Properties going today.
33421 Removed all the properties for interfaces, and replaced them with
33422 `public readonly' fields.
33424 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33426 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33427 initialize their hashtables/arraylists only when they are needed
33428 instead of doing this always.
33430 * parameter.cs: Handle refs and out parameters.
33432 * cs-parser.jay: Use an ArrayList to construct the arguments
33433 instead of the ParameterCollection, and then cast that to a
33436 * parameter.cs: Drop the use of ParameterCollection and use
33437 instead arrays of Parameters.
33439 (GetParameterInfo): Use the Type, not the Name when resolving
33442 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33444 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33445 and instead use public readonly fields.
33447 * class.cs: Put back walking code for type containers.
33449 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33451 * class.cs (MakeConstant): Code to define constants.
33453 * rootcontext.cs (LookupType): New function. Used to locate types
33456 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33458 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33459 this System.Reflection code is. Kudos to Microsoft
33461 * typemanager.cs: Implement a type cache and avoid loading all
33462 types at boot time. Wrap in LookupType the internals. This made
33463 the compiler so much faster. Wow. I rule!
33465 * driver.cs: Make sure we always load mscorlib first (for
33466 debugging purposes, nothing really important).
33468 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33469 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33471 * rootcontext.cs: Lookup types on their namespace; Lookup types
33472 on namespaces that have been imported using the `using' keyword.
33474 * class.cs (TypeContainer::TypeAttr): Virtualize.
33475 (Class::TypeAttr): Return attributes suitable for this bad boy.
33476 (Struct::TypeAttr): ditto.
33477 Handle nested classes.
33478 (TypeContainer::) Remove all the type visiting code, it is now
33479 replaced with the rootcontext.cs code
33481 * rootcontext.cs (GetClassBases): Added support for structs.
33483 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33485 * interface.cs, statement.cs, class.cs, parameter.cs,
33486 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33487 Drop use of TypeRefs, and use strings instead.
33489 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33493 * class.cs (Struct::Struct): set the SEALED flags after
33494 checking the modifiers.
33495 (TypeContainer::TypeAttr): new property, returns the
33496 TypeAttributes for a class.
33498 * cs-parser.jay (type_list): Oops, list production was creating a
33499 new list of base types.
33501 * rootcontext.cs (StdLib): New property.
33502 (GetInterfaceTypeByName): returns an interface by type name, and
33503 encapsulates error handling here.
33504 (GetInterfaces): simplified.
33505 (ResolveTree): Encapsulated all the tree resolution here.
33506 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33509 * driver.cs: Add support for --nostdlib, to avoid loading the
33510 default assemblies.
33511 (Main): Do not put tree resolution here.
33513 * rootcontext.cs: Beginning of the class resolution.
33515 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33517 * rootcontext.cs: Provide better error reporting.
33519 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33521 * rootcontext.cs (CreateInterface): Handle the case where there
33522 are no parent interfaces.
33524 (CloseTypes): Routine to flush types at the end.
33525 (CreateInterface): Track types.
33526 (GetInterfaces): Returns an array of Types from the list of
33527 defined interfaces.
33529 * typemanager.c (AddUserType): Mechanism to track user types (puts
33530 the type on the global type hash, and allows us to close it at the
33533 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33535 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33536 RecordInterface instead.
33538 * cs-parser.jay: Updated to reflect changes above.
33540 * decl.cs (Definition): Keep track of the TypeBuilder type that
33541 represents this type here. Not sure we will use it in the long
33542 run, but wont hurt for now.
33544 * driver.cs: Smaller changes to accomodate the new code.
33546 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33549 * rootcontext.cs (CreateInterface): New method, used to create
33550 the System.TypeBuilder type for interfaces.
33551 (ResolveInterfaces): new entry point to resolve the interface
33553 (CodeGen): Property, used to keep track of the code generator.
33555 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33557 * cs-parser.jay: Add a second production for delegate_declaration
33560 (enum_body): Put an opt_comma here instead of putting it on
33561 enum_body or enum_member_declarations so we can handle trailing
33562 commas on enumeration members. Gets rid of a shift/reduce.
33564 (type_list): Need a COMMA in the middle.
33566 (indexer_declaration): Tell tokenizer to recognize get/set
33568 * Remove old targets.
33570 * Re-add the parser target.
33572 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33574 * cs-parser.jay: Add precendence rules for a number of operators
33575 ot reduce the number of shift/reduce conflicts in the grammar.
33577 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33579 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33582 Get rid of old crufty code.
33584 * rootcontext.cs: Use this to keep track of the parsed
33585 representation and the defined types available to the program.
33587 * gen-treedump.cs: adjust for new convention.
33589 * type.cs: Split out the type manager, and the assembly builder
33592 * typemanager.cs: the type manager will live here now.
33594 * cil-codegen.cs: And the code generator here.
33596 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33598 * makefile: Fixed up for easy making.
33600 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33602 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33605 (unary_expression): Expand pre_increment_expression and
33606 post_decrement_expression to reduce a shift/reduce.
33608 2001-07-11 Simon Cozens
33610 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33612 Improve allow_keyword_as_indent name.
33614 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33616 * Adjustments for Beta2.
33618 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33620 * decl.cs: Added `Define' abstract method.
33621 (InTransit): new property, used to catch recursive definitions.
33623 * interface.cs: Implement `Define'.
33625 * modifiers.cs: Map Modifiers.constants to
33626 System.Reflection.TypeAttribute flags.
33628 * class.cs: Keep track of types and user-defined types.
33629 (BuilderInit): New method for creating an assembly
33630 (ResolveType): New function to launch the resolution process, only
33631 used by interfaces for now.
33633 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33634 that are inserted into the name space.
33636 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33638 * ARGH. I have screwed up my tree so many times due to the use of
33639 rsync rather than using CVS. Going to fix this at once.
33641 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33644 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33646 * Experiment successful: Use System.Type rather that our own
33649 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33651 * cs-parser.jay: Removed nsAliases from here.
33653 Use new namespaces, handle `using XXX;'
33655 * namespace.cs: Reimplemented namespace handling, use a recursive
33656 definition of the class. Now we can keep track of using clauses
33657 and catch invalid using clauses.
33659 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33661 * gen-treedump.cs: Adapted for all the renaming.
33663 * expression.cs (Expression): this class now has a Type property
33664 which returns an expression Type.
33666 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33667 `Type', as this has a different meaning now in the base
33669 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33671 * interface.cs, class.cs: Removed from all the sources the
33672 references to signature computation, as we can not do method
33673 signature computation during the parsing time, as we are not
33674 trying to solve at that point distinguishing:
33678 void a (NS.Blah x) {}
33681 Which depending on the context might be valid or not, as we do not
33682 know if Blah is the same thing as NS.Blah at that point.
33684 * Redid everything so the code uses TypeRefs now instead of
33685 Types. TypeRefs are just temporary type placeholders, that need
33686 to be resolved. They initially have a pointer to a string and the
33687 current scope in which they are used. This is used later by the
33688 compiler to resolve the reference to an actual Type.
33690 * DeclSpace is no longer a CIR.Type, and neither are
33691 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33692 are all DeclSpaces, but no Types.
33694 * type.cs (TypeRefManager): This implements the TypeRef manager,
33695 which keeps track of all the types that need to be resolved after
33696 the parsing has finished.
33698 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33700 * ARGH. We are going to have to store `foreach' as a class rather
33701 than resolving it, as we need to verify error 1579 after name
33702 resolution. *OR* we could keep a flag that says `This request to
33703 IEnumerator comes from a foreach statement' which we can then use
33704 to generate the error.
33706 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33708 * class.cs (TypeContainer.AddMethod): we now add methods to the
33709 MethodGroup instead of the method hashtable.
33711 * expression.cs: Add MethodGroup abstraction, which gets us one
33712 step closer to the specification in the way we handle method
33715 * cs-parser.jay (primary_expression): qualified_identifier now
33716 tried to match up an identifier to a local variable reference or
33717 to a parameter reference.
33719 current_local_parameters is now a parser global variable that
33720 points to the current parameters for the block, used during name
33723 (property_declaration): Now creates an implicit `value' argument to
33726 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33728 * parameter.cs: Do not use `param' arguments as part of the
33729 signature, per the spec.
33731 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33733 * decl.cs: Base class for classes, structs and interfaces. This
33734 is the "Declaration Space"
33736 * cs-parser.jay: Use CheckDef for checking declaration errors
33737 instead of having one on each function.
33739 * class.cs: Factor out some code for handling error handling in
33740 accordance to the "Declarations" section in the "Basic Concepts"
33741 chapter in the ECMA C# spec.
33743 * interface.cs: Make all interface member classes derive from
33744 InterfaceMemberBase.
33746 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33748 * Many things: all interfaces are parsed and generated in
33749 gen-treedump. Support for member variables, constructors,
33750 destructors, properties, constants is there.
33752 Beginning of the IL backend, but very little done, just there for
33755 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33757 * cs-parser.jay: Fix labeled statement.
33759 * cs-tokenizer.cs (escape): Escape " and ' always.
33760 ref_line, ref_name: keep track of the line/filename as instructed
33761 by #line by the compiler.
33764 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33766 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33767 to match the values in System.CodeDOM.
33769 Divid renamed to Divide.
33771 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33773 (Statements.set): remove.
33775 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33778 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33779 falseStatements always have valid values.
33781 * cs-parser.jay: Use System.CodeDOM now.