1 2009-12-16 Miguel de Icaza <miguel@novell.com>
5 2009-12-08 Marek Safar <marek.safar@gmail.com>
8 anonymous.cs: Use actual type parameters when checking for generic
11 2009-11-26 Marek Safar <marek.safar@gmail.com>
14 * decl.cs: Check private nested types of nested types recursively.
16 2009-11-26 Marek Safar <marek.safar@gmail.com>
19 * location.cs: Ignore self referencing #line directive
21 2009-11-26 Marek Safar <marek.safar@gmail.com>
24 * class.cs: Allow single unsafe fixed buffer fields.
26 2009-11-07 Marek Safar <marek.safar@gmail.com>
29 * expression.cs: Fixed mixed version of expression tree anonymous
32 2009-11-06 Marek Safar <marek.safar@gmail.com>
36 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
37 expression tree version of anonymous type with members declaration.
39 2009-10-29 Marek Safar <marek.safar@gmail.com>
42 * convert.cs: Don't eliminate explicit precission casts.
44 2009-10-16 Marek Safar <marek.safar@gmail.com>
46 A fix for bug #493523, #507067
47 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
48 standard nullable conversion using underlying standard conversion
49 and not full conversion.
51 2009-10-05 Marek Safar <marek.safar@gmail.com>
53 * expression.cs: Equality comparison of generic parameter with
56 2009-10-05 Marek Safar <marek.safar@gmail.com>
59 * generic.cs: Import predefined constraints correctly.
61 2009-10-02 Marek Safar <marek.safar@gmail.com>
63 * ecore.cs: Don't crash on overloads with optional paremeters where
64 arguments count overflows.
66 * parameter.cs: Import optional parameter constants using optional
69 2009-09-30 Marek Safar <marek.safar@gmail.com>
72 * delegate.cs: Emit correct delegate instance variable when there
73 are static and non-static overloads.
75 2009-09-25 Marek Safar <marek.safar@gmail.com>
77 * expression.cs, ecore.cs: More dynamic binary expressions.
79 2009-09-22 Marek Safar <marek.safar@gmail.com>
81 * nullable.cs, expression.cs: Fixed null lifted conversion for
82 bitwise enum operations.
84 2009-09-22 Marek Safar <marek.safar@gmail.com>
86 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
87 values in checked context.
89 2009-09-22 Marek Safar <marek.safar@gmail.com>
91 * expression.cs, ecore.cs: Fixed array index constant conversion.
93 2009-09-20 Miguel de Icaza <miguel@novell.com>
95 * expression.cs: Do not crash when MemberLookup returns something
96 that is not a MemberExpr here. Report error 582 instead.
100 2009-09-18 Marek Safar <marek.safar@gmail.com>
102 * decl.cs, class.cs: Check protected property accessors.
104 2009-09-18 Marek Safar <marek.safar@gmail.com>
106 * dynamic.cs, assign.cs: Dynamic compound assignment.
108 2009-09-17 Marek Safar <marek.safar@gmail.com>
110 * expression.cs: Fixed compound assignment explicit conversion.
112 2009-09-17 Marek Safar <marek.safar@gmail.com>
114 * expression.cs, ecore.cs: Cannot infer variables from method group.
116 2009-09-16 Marek Safar <marek.safar@gmail.com>
118 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
119 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
120 codegen.cs: Dynamic binary operations scaffolding.
122 2009-09-15 Marek Safar <marek.safar@gmail.com>
124 * expression.cs: Fixes nullable promotion for enum type variables.
126 2009-09-11 Marek Safar <marek.safar@gmail.com>
128 * driver.cs, dynamic.cs: Reset more static variables.
130 2009-09-11 Marek Safar <marek.safar@gmail.com>
132 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
133 driver.cs: Introduced Expression::MakeExpression.
135 2009-09-11 Marek Safar <marek.safar@gmail.com>
137 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
139 2009-09-09 Marek Safar <marek.safar@gmail.com>
141 * eval.cs, report.cs: Use Console.Out for all eval error or warning
144 2009-09-09 Marek Safar <marek.safar@gmail.com>
146 A fix for bug #518707
147 * expression.cs (Is): Optimize only generic parameter type
148 expression probing value type generic parameter.
150 2009-09-09 Marek Safar <marek.safar@gmail.com>
152 A fix for bug #532571
153 * ecore.cs: Check for simple name type arguments used with
156 2009-09-08 Marek Safar <marek.safar@gmail.com>
158 A fix for bug #497421
159 * generic.cs (CheckConstraint): Don't use buildin types to check for
160 parameterless constructor.
162 2009-09-08 Marek Safar <marek.safar@gmail.com>
164 A fix for bug #537402
165 * generic.cs (CheckConstraint): Correctly inflate generic type
166 arguments when checking generic method.
168 2009-09-08 Marek Safar <marek.safar@gmail.com>
170 A fix for bug #536463
171 * decl.cs (AddToContainer): Don't report collision between explicit
172 and parameterless non-explicit members.
174 2009-09-08 Marek Safar <marek.safar@gmail.com>
176 * eval.cs: Reset more static stuff.
178 2009-09-07 Marek Safar <marek.safar@gmail.com>
180 A fix for bug #324625
181 * expression.cs, ecore.cs: Create nested generic type expression
182 using declaring and not current type.
184 2009-09-07 Marek Safar <marek.safar@gmail.com>
186 * *.cs: Changed Report class to accept various output printers and
187 be an instance class. An expression resolver can now use different
188 message reporter for each call and Report.Error can safely throw
189 an exception. Part of ongoing work to turn mcs into proper library.
191 2009-09-04 Marek Safar <marek.safar@gmail.com>
193 * statement.cs, ecore.cs: Removed error reporting from emit code.
195 2009-09-04 Marek Safar <marek.safar@gmail.com>
197 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
199 2009-09-03 Marek Safar <marek.safar@gmail.com>
201 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
202 parser checks out of constructors.
204 2009-09-02 Marek Safar <marek.safar@gmail.com>
206 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
208 2009-09-02 Marek Safar <marek.safar@gmail.com>
210 A fix for bug #535448
211 * anonymous.cs, class.cs: Copy return label between all contexts.
213 2009-09-02 Marek Safar <marek.safar@gmail.com>
215 A fix for bug #535395
216 * namespace.cs: Resolve context can be null.
218 2009-08-25 Marek Safar <marek.safar@gmail.com>
220 A fix for bug #533912
221 * generic.cs: Use correct context for constraints resolving.
223 2009-08-25 Marek Safar <marek.safar@gmail.com>
225 A fix for bug #532630
226 * driver.cs: Trim conditional symbols.
228 2009-08-25 Marek Safar <marek.safar@gmail.com>
230 * context.cs: New file.
232 * *.exe.sources, *.csproj: Updated.
234 2009-08-25 Marek Safar <marek.safar@gmail.com>
236 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
237 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
238 IMembercontext, some small cleanups.
240 2009-08-24 Marek Safar <marek.safar@gmail.com>
242 * *.cs: Split ResolveContext and EmitContext.
244 2009-08-24 Marek Safar <marek.safar@gmail.com>
246 * *.cs: Only ResolveContext implements IMemberContext.
248 2009-08-21 Marek Safar <marek.safar@gmail.com>
250 * *.cs: Renamed IResolveContext to IMemberContext.
252 2009-08-21 Marek Safar <marek.safar@gmail.com>
254 * *.cs: Detached ResolveContext from EmitContext.
256 2009-08-21 Marek Safar <marek.safar@gmail.com>
258 * codegen.cs: Moved flow-analysis to BlockContext.
260 2009-08-21 Marek Safar <marek.safar@gmail.com>
262 * *.cs: Detached BlockContext from EmitContext.
264 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
266 * statement.cs: avoid nullref when the return value of GetEnumerator()
267 does not contain any MoveNext() method.
269 2009-08-19 Marek Safar <marek.safar@gmail.com>
271 * *.cs: Removed IResolveContext::GenericDeclContainer.
273 2009-08-19 Marek Safar <marek.safar@gmail.com>
275 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
277 2009-08-19 Marek Safar <marek.safar@gmail.com>
279 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
280 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
282 2009-08-18 Marek Safar <marek.safar@gmail.com>
284 * *.cs: Removed boolean fields from EmitContext.
286 2009-08-18 Marek Safar <marek.safar@gmail.com>
288 * *.cs: Add IResolveContext::IsStatic.
290 2009-08-18 Marek Safar <marek.safar@gmail.com>
292 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
294 2009-08-17 Marek Safar <marek.safar@gmail.com>
296 * *.cs: Removed DeclContainer from EmitContext.
298 2009-08-17 Marek Safar <marek.safar@gmail.com>
300 * *.cs: Add IResolveContext::CurrentTypeParameters.
302 2009-08-14 Marek Safar <marek.safar@gmail.com>
304 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
306 2009-08-14 Marek Safar <marek.safar@gmail.com>
308 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
309 codegen.cs: Add IResolveContext::LookupExtensionMethod.
311 2009-08-13 Marek Safar <marek.safar@gmail.com>
313 * decl.cs: Look in PartialContainer for parent type parameters.
315 2009-08-13 Marek Safar <marek.safar@gmail.com>
317 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
318 codegen.cs: Add IResolveContext::LookupTypeParameter.
320 2009-08-13 Marek Safar <marek.safar@gmail.com>
322 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
323 Moved resolved logic from Emit to Resolve.
325 2009-08-13 Marek Safar <marek.safar@gmail.com>
327 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
328 codegen.cs: Reworked atttributes handling of ResolveContext.
330 2009-08-12 Marek Safar <marek.safar@gmail.com>
332 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
333 LookupNamespaceOrType to ResolveContext.
335 2009-08-12 Marek Safar <marek.safar@gmail.com>
337 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
338 class.cs: Removed unused parameters and methods.
340 2009-08-11 Marek Safar <marek.safar@gmail.com>
342 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
343 codegen.cs: Finding the best common type of a set of expressions for
346 2009-08-07 Marek Safar <marek.safar@gmail.com>
348 * dynamic.cs, expression.cs: More dynamic conversions.
350 2009-08-06 Miguel de Icaza <miguel@novell.com>
352 * generic.cs: This loop was incorrect, it was increment ii, but
353 checking for `i'. This was a change introduced to fix #327497,
356 * class.cs: Catch another case for cs0533 error, fixes #324782.
358 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
360 * typemanager.cs (GetGenericArguments): SRE returns null for
361 generic methods on type builder instances if they are not generic
362 themselves. For example, for Foo<int>::Bar() it returns null, but
363 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
365 2009-08-05 Marek Safar <marek.safar@gmail.com>
367 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
368 delegate.cs: Work on dynamic binding.
370 2009-08-04 Marek Safar <marek.safar@gmail.com>
372 A second fix for bug #525342
373 * class.cs: Attach partial method attributes to method
376 2009-08-03 Marek Safar <marek.safar@gmail.com>
378 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
381 * rootcontext.cs: Default to langversion v4.
383 2009-08-03 Marek Safar <marek.safar@gmail.com>
385 * pending.cs: Check return type before member info is set.
387 2009-08-03 Marek Safar <marek.safar@gmail.com>
389 * anonymous.cs: Fully initialize generic hoisted field expression.
391 2009-08-02 Miguel de Icaza <miguel@novell.com>
393 * cs-parser.jay: Flag variables declared on the interactive shell
394 as used to prevent the 168 warning about local variable not being
397 2009-07-31 Marek Safar <marek.safar@gmail.com>
399 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
400 attribute.cs: Emit dynamic export attribute.
402 2009-07-30 Marek Safar <marek.safar@gmail.com>
404 * expression.cs: More verifier work.
406 2009-07-29 Marek Safar <marek.safar@gmail.com>
408 * nullable.cs: Fixed SRE crash during corlib compilation.
410 2009-07-29 Marek Safar <marek.safar@gmail.com>
412 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
413 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
414 More TypeManager.TypeToCoreType needed.
416 2009-07-29 Marek Safar <marek.safar@gmail.com>
418 * anonymous.cs: Update after recent SRE fixes.
420 2009-07-28 Marek Safar <marek.safar@gmail.com>
422 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
423 version of GetFieldHandle for fields of generic types.
425 2009-07-27 Marek Safar <marek.safar@gmail.com>
427 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
428 ecore.cs: Add TypeManager.IsDynamicType,
429 PredefinedAttributes.Dynamic.
431 2009-07-27 Marek Safar <marek.safar@gmail.com>
433 A fix for bug #415375
434 * expression.cs: Fixed object and reference type parameter
437 2009-07-27 Marek Safar <marek.safar@gmail.com>
439 A fix for bug #525342
440 * class.cs: Attach partial method attributes to method
443 2009-07-24 Marek Safar <marek.safar@gmail.com>
445 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
448 2009-07-24 Marek Safar <marek.safar@gmail.com>
450 * anonymous.cs (MutateField): Add imported types handling.
452 2009-07-23 Marek Safar <marek.safar@gmail.com>
454 * expression.cs, delegate.cs: Moved arguments resolve into their
455 counterparts expressions. Removed argument resolve from
456 CollectionElementInitializer.
458 2009-07-23 Marek Safar <marek.safar@gmail.com>
460 A fix for bug #523683
461 * convert.cs, delegate.cs: Use common overload mechanism for method
462 group conversion check.
464 2009-07-22 Marek Safar <marek.safar@gmail.com>
466 A fix for bug #523899
467 * generics.cs: Exact type inference with other bound types.
469 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
471 Don't complain when the same type is implemented by the output
472 assembly as well as multiple referenced assemblies
473 * namespace.cs (RootNamespace.LookupTypeReflection): Add
474 'must_be_unique' flag.
475 (GlobalRootNamespace): Update to changes.
476 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
477 already have a type in hand.
479 2009-07-22 Marek Safar <marek.safar@gmail.com>
481 * expression.cs: More verifier instrumentation.
483 * statement.cs: Do proper throw expression conversion.
485 2009-07-22 Marek Safar <marek.safar@gmail.com>
487 A fix for bug #522789
488 * expression.cs: Mutate invocation return type.
490 2009-07-16 Marek Safar <marek.safar@gmail.com>
492 * anonymous.cs: Split assignable and readonly generated variable
495 2009-07-16 Marek Safar <marek.safar@gmail.com>
497 A fix for bug #521671
498 * statement.cs: Fixed crash when checking missing type.
500 2009-07-16 Marek Safar <marek.safar@gmail.com>
502 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
503 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
504 class.cs, driver.cs: Work on dynamic binding.
506 * dynamic.cs: New file.
508 * *.sources, *.proj: Updated.
510 2009-07-15 Marek Safar <marek.safar@gmail.com>
512 * expression.cs (Conditional): Avoid double Resolve.
514 2009-07-13 Marcus Griep <marcus@griep.us>
516 * ecore.cs: Fix obscure bug with resolving members of interfaces
517 that hide parent interface members. Fixes bug #444388 and corrects
520 2009-07-13 Marek Safar <marek.safar@gmail.com>
522 * expression.cs (LocalVariableReference): Bounce resolve.
524 2009-07-10 Marek Safar <marek.safar@gmail.com>
526 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
527 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
530 * support.cs: New dynamic type wrapper.
532 2009-07-08 Marek Safar <marek.safar@gmail.com>
534 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
535 typed local variable.
537 2009-07-06 Marek Safar <marek.safar@gmail.com>
539 A fix for bug #519005
540 * anonymous.cs: Use null_type as no return type placeholder.
542 2009-07-02 Marek Safar <marek.safar@gmail.com>
544 * generic.cs: Handle type inference of identical type parameters
545 with different bounds.
547 2009-07-01 Marek Safar <marek.safar@gmail.com>
549 * expression.cs, class.cs: Events variance.
551 * cs-parser.jay: Interface events error messages.
553 2009-07-01 Marek Safar <marek.safar@gmail.com>
555 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
557 2009-06-29 Marek Safar <marek.safar@gmail.com>
559 * parameter.cs, convert.cs, expression.cs, class.cs: Default
560 parameter expression can be value-type New.
562 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
564 2009-06-26 Marek Safar <marek.safar@gmail.com>
566 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
567 Implemented C# 4.0 named arguments.
569 2009-06-24 Marek Safar <marek.safar@gmail.com>
571 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
572 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
573 parameter modifier. Also fixes bug #515497.
575 2009-06-24 Marek Safar <marek.safar@gmail.com>
577 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
578 arguments expression to be implemented.
580 *.sources: Add argument.cs
582 2009-06-23 Marek Safar <marek.safar@gmail.com>
584 * parameter.cs: Moved GetParameterIndexByName to base class.
586 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
587 unused AType. Use argument's version of GetExpressionTree.
589 2009-06-22 Marek Safar <marek.safar@gmail.com>
591 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
594 2009-06-17 Marek Safar <marek.safar@gmail.com>
596 A fix for bug #514096
597 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
599 2009-06-17 Marek Safar <marek.safar@gmail.com>
601 * expression.cs: The first multi-dimensional array nested array
602 initializers was not checked.
604 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
606 2009-06-17 Marek Safar <marek.safar@gmail.com>
608 A fix for bug #513400
609 * nullable.cs (EmitEquality): Operands emit could be simplified for
610 built-in types when we now emit user operators differently.
612 2009-06-16 Marek Safar <marek.safar@gmail.com>
614 * ecore.cs: Report inaccessible delegate methods correctly.
616 2009-06-16 Marek Safar <marek.safar@gmail.com>
618 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
619 cs-parser.jay: Implemented C# 4.0 optional parameters.
621 2009-06-16 Marek Safar <marek.safar@gmail.com>
623 * driver.cs: Removed broken DefineManifestResource.
625 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
627 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
628 Use $(BOOTSTRAP_PROFILE) instead.
630 2009-06-12 Jb Evain <jbevain@novell.com>
632 * rootcontext.cs: add a Platform field.
633 * driver.cs: handle /platform.
634 * codegen.cs: pass the proper flags according to
635 the platform when saving the assembly.
637 2009-06-11 Marek Safar <marek.safar@gmail.com>
639 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
640 Add optional parameters grammar.
642 2009-06-10 Marek Safar <marek.safar@gmail.com>
644 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
645 driver.cs: Split lang version and metadata version.
647 2009-06-10 Marek Safar <marek.safar@gmail.com>
649 * decl.cs: Better overload ctor collision error message.
651 2009-06-05 Jb Evain <jbevain@novell.com>
653 * driver.cs (EmbededResource): avoid using an internal method
654 in gmcs to embed manifest resources.
656 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
658 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
659 the compiler from older mono versions (like moon's bots)
661 2009-06-04 Marek Safar <marek.safar@gmail.com>
663 * namespace.cs (LookupTypeReflection): Ignore collisions between
666 2009-06-04 Marek Safar <marek.safar@gmail.com>
668 * codegen.cs: Enabled generic type forwarders.
670 2009-06-04 Marek Safar <marek.safar@gmail.com>
672 * dmcs.*: Add another version of SRE compiler.
674 2009-06-03 Marek Safar <marek.safar@gmail.com>
676 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
677 generic-mcs.cs: Fixed variant type conversions.
679 2009-06-02 Marek Safar <marek.safar@gmail.com>
681 A fix for bug #507863
682 * codegen.cs: Fixes a crash on invalid string value attribute.
684 2009-06-01 Marek Safar <marek.safar@gmail.com>
686 A fix for bug #508334
687 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
688 cs-parser.jay: Fully import __arglist modifier.
690 2009-05-29 Marek Safar <marek.safar@gmail.com>
692 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
693 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
694 actually work with closed generic types.
696 2009-05-27 Alan McGovern <amcgovern@novell.com>
698 * class.cs, decl.cs, delegate.cs, parameter.cs:
699 Fix the build by replacing the use of 'var' with the actual type.
701 2009-05-27 Marek Safar <marek.safar@gmail.com>
703 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
704 cs-parser.jay, generic-mcs.cs: Report wrong variant types
707 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
710 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
711 Marek Safar <marek.safar@gmail.com>
713 A fix for bug #377509
714 * parameter.cs: Use predefined and not empty name for implicit
717 2009-05-21 Marek Safar <marek.safar@gmail.com>
719 * class.cs: Don't report wrong warnings for event fields.
721 2009-05-21 Marek Safar <marek.safar@gmail.com>
723 A fix for bug #504667
724 * class.cs: Check for static class using parent container instead of
727 2009-05-08 Marek Safar <marek.safar@gmail.com>
729 A fix for bug #496922
730 * expression.cs: Always use temporary variable when using object
733 2009-04-28 Marek Safar <marek.safar@gmail.com>
735 A fix for bug #495112
736 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
739 2009-04-27 Miguel de Icaza <miguel@novell.com>
741 * driver.cs: Add a flag to work as a replacement for CSC in VS.
743 2009-04-24 Miguel de Icaza <miguel@novell.com>
745 * complete.cs: No idea how gonzalo got a null in the list, but
748 2009-04-24 Miguel de Icaza <miguel@novell.com>
750 * complete.cs (CompletionElementInitializer): New completion class
751 to support completing inside a C# 3 element initializer, so this
752 allows completion for Silverlight situations where it is very
755 new TextBlock () { Fo<TAB>
757 (CompletionSimpleName): Expose the prefix that was
758 passed to the simple name.
760 * cs-parser.jay (object_or_collection_initializer): Add support
761 for element_initializers.
763 * expression.cs (CollectionOrObjectInitializers.DoResolve):
764 special case completion expressions as this method aggressively
765 collects data before it operates, and errors were being thrown
766 earlier than we were able to complete.
768 2009-04-23 Miguel de Icaza <miguel@novell.com>
770 * eval.cs: Make getcompletions silent and enable debugging output
771 if the -v option is passed.
773 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
774 Consider looking up the namespace that matches the prefix being
777 This is part of the support for allowing completions like:
778 `System.Co<TAB>' to complete to System.Console.
780 * complete.cs (CompletionSimpleName.AppendResults): Make this
783 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
785 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
786 COMPLETE_COMPLETION as internal.
788 2009-04-17 Miguel de Icaza <miguel@novell.com>
790 * complete.cs: Include namespace resolution in simple names as
791 well as global types and types in the using scope in the
794 * namespace.cs: Supporting infrastrcture to provide completions
795 based on the current using scope.
797 * eval.cs: Introduce an entry point that allows for initialization
798 to return a list of the files passed on the command line.
800 2009-04-14 Marek Safar <marek.safar@gmail.com>
802 A fix for bug #494243
803 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
805 2009-04-13 Marek Safar <marek.safar@gmail.com>
807 A fix for bug #493887
808 * statement.cs: Don't skip string multi-section with default or
809 null label when populating string hashtable.
811 2009-04-06 Marek Safar <marek.safar@gmail.com>
813 A fix for bug #492329
814 * expression.cs (New): Load variable when assigning type parameter
817 2009-04-06 Marek Safar <marek.safar@gmail.com>
819 A fix for bug #488960
820 * decl.cs: Compare MVAR types using non-null values.
822 2009-03-27 Marek Safar <marek.safar@gmail.com>
824 * typemanager.cs, expression.cs: Removed unused nullable checks.
826 2009-03-27 Marek Safar <marek.safar@gmail.com>
828 * *.cs: Removed some gmcs conditionals.
830 2009-03-26 Marek Safar <marek.safar@gmail.com>
832 * generic.cs, support.cs: Moved generics stuff out of support.cs
834 2009-03-24 Marek Safar <marek.safar@gmail.com>
836 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
839 2009-03-23 Marek Safar <marek.safar@gmail.com>
841 * attribute.cs: Consider all members for error reporting when
842 checking named arguments.
844 2009-03-23 Marek Safar <marek.safar@gmail.com>
846 A fix for bug #487625
847 * namespace.cs: Use a warning for all predefined type conflicts.
849 2009-03-23 Marek Safar <marek.safar@gmail.com>
851 A fix for bug #485706
852 * statement.cs: Explicitly type catch type argument to pass verifier
855 2009-03-22 Miguel de Icaza <miguel@novell.com>
857 Initial support to provide code completion facilities to consumers
858 of the evaluator API.
860 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
861 support the completion engine. When we reach the end of the
862 input stream instead of returning EOF, when this flag is true the
863 tokenizer instead produces:
865 One GENERATE_COMPLETION token: this token then must be
866 handled in the grammar at every point where the user
867 would likely request a completion.
869 As many COMPLETE_COMPLETION tokens as necessary. These
870 tokens are generated to assist the parser in unwinding and
871 producing a valid parse tree.
873 The parser rules do not have to be perfect, the parser needs to be
874 augmented with judicious use of GENERATE_COMPLETION tokens to
875 improve the areas where we can provide completion and the parser
876 needs to add support for COMPLETE_COMPLETION tokens in productions
879 It is common to not have enough support for COMPLETE_COMPLETION
880 under certain rules and that even if we generated the
881 GENERATE_COMPLETION token that the resulting tree will be invalid
882 due to the missing rules that support COMPLETE_COMPLETION.
884 The final EOF token is produced by having the parser notify the
885 tokenizer when it reaches the root production that the next token
888 * support.cs (CompletionResult): New Exception. This exception
889 is thrown to return the completion results when one of the special
890 completion expressions is reached.
892 This exception is thrown by the completing ExpressionStatements
893 classes that live in complete.cs
895 * complete.cs (CompletingExpression): a new base class for
896 completing expressions. This derives from the
897 ExpressionStatement class and not from Expression as it allows
898 completion to happen not only where expressions are expected in
899 the grammar, but also where statements are expected.
901 (CompletionSimpleName): A new class used to provide completions
902 for SimpleNames. This currently only resolves to local
903 variables from the evaluator context (GetVars call).
905 (CompletionMemberAccess): Implements support for completing member
908 * cs-parser.jay: Add support for completion in a few places.
910 * eval.cs (GetCompletions): New public API for the evaluator that
911 returns a list of possible completions given the input. The
912 return value is an array of completions
914 * anonymous.cs (Compatible): If the exception thrown from the
915 resolved expression is a CompletionResult exception let that one
916 through instead of printing a diagnostic error in the try/catch.
918 2009-03-22 Miguel de Icaza <miguel@novell.com>
922 * driver.cs (Main): Use Environment.Exit to quit quickly and
923 prevent the compiler from doing the usual wait for helper thread
926 This is to prevent a slowdown that was reported by Gonzalo on
929 2009-03-19 Marek Safar <marek.safar@gmail.com>
931 * ecore.cs: Load build-in types directly instead of accessing
934 2009-03-18 Marek Safar <marek.safar@gmail.com>
936 * ecore.cs: Always use unbox.any when available.
938 2009-03-18 Marek Safar <marek.safar@gmail.com>
940 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
942 2009-03-17 Marek Safar <marek.safar@gmail.com>
944 * generic.cs: Removed obsolete version of type inference.
946 2009-03-16 Marek Safar <marek.safar@gmail.com>
948 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
949 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
950 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
951 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
953 2009-03-11 Marek Safar <marek.safar@gmail.com>
955 A fix for bug #482996
956 * anonymous.cs: Make sure we are not infering return type when
957 checking type compatibility.
959 2009-03-11 Marek Safar <marek.safar@gmail.com>
961 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
962 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
963 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
964 attributes in their own structure. Needed when accessing their
965 properties before they are resolved.
967 2009-03-09 Marek Safar <marek.safar@gmail.com>
969 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
970 hashtable (~10x faster).
972 * driver.cs: Removed wrong Reset.
974 2009-03-08 Marek Safar <marek.safar@gmail.com>
976 * class.cs: Use correct common base type for unmanaged delayed
979 * rootcontext.cs: Wrap unhandled exception.
981 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
983 Make SeekableStreamReader self-tuning and arbitrarily seekable
984 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
986 (SeekableStreamReader.Position.set): Use it. Simplify logic
987 which, as a side-effect, makes it arbitrarily-seekable. Tune the
988 buffer size when the stream needs to be re-read from the beginning.
990 2009-03-05 Marek Safar <marek.safar@gmail.com>
992 A fix for bug #480100
993 * parameter.cs: A parameter is not hoisted when used directly as ET.
995 2009-03-04 Marek Safar <marek.safar@gmail.com>
997 * statement.cs: Fixed an issue when using variable is of interface
1000 2009-03-03 Marek Safar <marek.safar@gmail.com>
1002 A fix for bug #480319
1003 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1005 2009-03-03 Marek Safar <marek.safar@gmail.com>
1007 A fix for bug #480867
1008 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1009 expression to have no valid type.
1011 2009-03-03 Marek Safar <marek.safar@gmail.com>
1013 A fix for bug #481258
1014 * class.cs: Set extension method flag in partial container.
1016 2009-03-03 Marek Safar <marek.safar@gmail.com>
1018 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1020 * attribute.cs: Add sanity check.
1022 2009-02-27 Marek Safar <marek.safar@gmail.com>
1024 * class.cs: Add external constructor error.
1026 2009-02-26 Marek Safar <marek.safar@gmail.com>
1028 A fix for bug #475354
1029 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1030 correctly user defined nullable equality operators.
1032 2009-02-25 Marek Safar <marek.safar@gmail.com>
1034 A fix for bug #479532
1035 * expression.cs: Implement NewInitialize::AddressOf.
1037 2009-02-25 Marek Safar <marek.safar@gmail.com>
1039 A fix for bug #413633
1040 * expression.cs: Iterate all base class-constraint types.
1042 2009-02-24 Marek Safar <marek.safar@gmail.com>
1044 A fix for bug #479209
1045 * literal.cs: Mutate null underlying type.
1047 2009-02-24 Marek Safar <marek.safar@gmail.com>
1049 A fix for bug #476295
1050 * convert.cs: Avoid wrapping implicitly convertible reference type.
1052 2009-02-23 Marek Safar <marek.safar@gmail.com>
1054 * iterators.cs: Create MemberName correctly.
1056 2009-02-23 Marek Safar <marek.safar@gmail.com>
1058 A fix for bug #478655
1059 * literal.cs: Check also underlying null type conversion.
1061 2009-02-21 Marek Safar <marek.safar@gmail.com>
1063 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1065 2009-02-20 Marek Safar <marek.safar@gmail.com>
1067 A fix for bug #477447
1068 * statement.cs: Add reference to correct parent storey when this
1069 is accessible from deep children storey (more than 1 level).
1071 2009-02-19 Marek Safar <marek.safar@gmail.com>
1073 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1074 * class.cs: Define base type members before setting up member cache.
1076 2009-02-18 Marek Safar <marek.safar@gmail.com>
1078 A fix for bug #477378
1079 * nullable.cs, expression.cs, statement.cs: More precise null type
1082 2009-02-18 Marek Safar <marek.safar@gmail.com>
1084 A fix for bug #472805
1085 * typemanager.cs, namespace.cs: Import only visible extension method
1088 2009-02-18 Marek Safar <marek.safar@gmail.com>
1090 A fix for bug #476895
1091 * attribute.cs: Use correct resolve context for attribute type.
1093 2009-02-18 Marek Safar <marek.safar@gmail.com>
1095 A fix for bug #476266
1096 * anonymous.cs: Mutate multi-dimensional arrays.
1098 2009-02-18 Marek Safar <marek.safar@gmail.com>
1100 A fix for bug #476400
1101 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1103 2009-02-18 Marek Safar <marek.safar@gmail.com>
1105 A fix for bug #476811
1106 * generics.cs: Fixed null-literal check.
1108 2009-02-17 Marek Safar <marek.safar@gmail.com>
1110 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1111 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1112 messing with static variables.
1114 2009-02-16 Marek Safar <marek.safar@gmail.com>
1116 A fix for bug #475965
1117 * generics.cs: Check generic parameter type after extracting from
1120 2009-02-16 Marek Safar <marek.safar@gmail.com>
1122 A fix for bug #475823
1123 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1126 2009-02-14 Marek Safar <marek.safar@gmail.com>
1128 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1129 Simplified event field definition using backing field and not
1130 field builder directly.
1132 * expression.cs (EmitLdArg): Optimize fast paths.
1134 2009-02-13 Marek Safar <marek.safar@gmail.com>
1136 A fix for bug #475327
1137 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1139 2009-02-13 Marek Safar <marek.safar@gmail.com>
1141 A fix for bug #475342
1142 * cs-parser.jay: Using 'super' instead of 'base' to call base
1143 constructor crashes compiler.
1145 2009-02-13 Marek Safar <marek.safar@gmail.com>
1147 A fix for bug #475354
1148 * expression.cs (Constantify): Add nullable types.
1150 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1152 2009-02-12 Marek Safar <marek.safar@gmail.com>
1154 A fix for bug #475246
1155 * expression.cs: More broken flowanalysis hacking needed.
1157 2009-02-12 Marek Safar <marek.safar@gmail.com>
1159 * attribute.cs: Compare only ref/out array modifiers.
1161 2009-02-11 Marek Safar <marek.safar@gmail.com>
1163 * statement.cs: Use member cache when looking for foreach members.
1165 2009-02-11 Marek Safar <marek.safar@gmail.com>
1167 * expression.cs: Don't expose internal initializer types.
1169 * statement.cs: Check also explicit conversions for goto case.
1171 2009-02-11 Marek Safar <marek.safar@gmail.com>
1173 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1175 2009-02-10 Marek Safar <marek.safar@gmail.com>
1177 * *.cs: Replace null-type with NullLiteral where appropriate.
1179 2009-02-09 Marek Safar <marek.safar@gmail.com>
1181 * expression.cs: Initializer of reference argument use temporary
1182 variable to be verifiable.
1184 * parameter.cs: Share EmitLdArg.
1186 2009-02-09 Marek Safar <marek.safar@gmail.com>
1188 A fix for bug #473559
1189 * class.cs: Fixed: Not reporting error about nested class with the
1192 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1194 Contributed under the MIT/X11 license.
1196 * generic.cs: Added VerifyVariantTypeParameters which performs new
1197 variance verification logic. The old logic, based on the spec, was
1198 wrong because the spec is full of LIES!
1200 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1202 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1205 * ecore.cs: Added calls to the new variance verification logic.
1208 * delegate.cs: Removed calls to the old variance verification logic.
1210 2009-02-06 Marek Safar <marek.safar@gmail.com>
1212 * delegate.cs: Use cached Invoke method directly.
1214 2009-02-06 Marek Safar <marek.safar@gmail.com>
1216 * expression.cs: Emit expression tree for hoisted variable access.
1218 2009-02-04 Marek Safar <marek.safar@gmail.com>
1220 * namespace.cs: Add better extension class check.
1222 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1224 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1226 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1228 This patch adds initial generic variance support to the compiler.
1229 It is contributed under the MIT/X11 license.
1231 * typemanager.cs: Modified ImplementsInterface to check variance.
1232 Added VerifyVariantTypeParameters which checks the specified type to see
1233 if it uses a variant type parameter as a type argument (which is not
1234 allowed). Added IsVariantOf which determins if the first type is a
1235 variant of the second. NOTE: This only supports reference types at
1236 the moment to conform with the current level of VM support. When the
1237 VM supports value types, this will follow step.
1239 * generic.cs: Added the Variance enum. Added a Variance property to
1240 TypeParameter and added variance support to definition phase. Added a
1241 Variance property to TypeParameterName. Also check to make sure that
1242 no variant types appear in generic method parameters.
1244 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1245 keywords if the langversion supports it.
1247 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1248 that variant types are only used in legal positions. Also added
1249 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1252 * decl.cs: Construct TypeParameter with the variance information.
1254 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1255 and ImplicitConversionStandard.
1257 * rootcontext.cs: Added new "Future" language version.
1259 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1260 type parameters are not used as type arguments in interface inheritance.
1261 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1262 parameters are not used as method return types. In MemberBase.
1263 ResolveMemberType, ensure that variant type parameters are not used
1264 as type arguments. Also call VerifyNoVariantTypeParameters on every
1265 set of parameters which are resolved.
1267 * delegate.cs: Modified Delegate.Define to ensure that variant
1268 parameters are not used as type arguments and that a contravariant
1269 parameter is not used as the return type. Also call
1270 VerifyNoVariantTypeParameters on the delegate parameters.
1272 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1273 to specify generic variance.
1275 * driver.cs: Added support for LanguageVersion.Future in the form of
1276 "-langversion:future".
1278 * generic-mcs.cs: Stubbed out new members in generic.cs.
1280 2009-02-03 Marek Safar <marek.safar@gmail.com>
1282 * class.cs, generic.cs: Emit type parameter constraints for nested
1285 2009-02-02 Marek Safar <marek.safar@gmail.com>
1287 A fix for bug #471213
1288 * class.cs: Avoid emitting backing field for abstract event fields.
1290 2009-02-01 Marek Safar <marek.safar@gmail.com>
1292 A fix for bug #359731
1293 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1296 2009-01-30 Marek Safar <marek.safar@gmail.com>
1298 A fix for bug #470767
1299 * statement.cs: Introduced BlockScopeExpression, needed when
1300 expression tree conversion has to emit scope variables.
1302 2009-01-29 Marek Safar <marek.safar@gmail.com>
1304 * class.cs: Remove duplicate CallingConvention.
1306 2009-01-29 Marek Safar <marek.safar@gmail.com>
1308 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1309 when I finally found the right naming convention.
1311 2009-01-29 Marek Safar <marek.safar@gmail.com>
1313 * cs-tokenizer.cs: Put back different open parens optimization.
1315 2009-01-28 Marek Safar <marek.safar@gmail.com>
1317 A fix for bug #470227
1318 * cs-tokenizer.cs: Remove too agressive parser optimization.
1320 2009-01-28 Marek Safar <marek.safar@gmail.com>
1322 A fix for bug #324319
1323 * class.cs: Remove too early base type resolve.
1325 2009-01-27 Marek Safar <marek.safar@gmail.com>
1327 A fix for bug #324319
1328 * ecore.cs: Explicitly type null when assigning to type argument to
1329 make pass verifier check.
1331 2009-01-27 Marek Safar <marek.safar@gmail.com>
1333 * anonymous.cs: Fixed recent regression when initializing captured
1336 2009-01-26 Marek Safar <marek.safar@gmail.com>
1338 A fix for bug #469019
1339 * anonymous.cs: Use all parent type parameters when instantiating
1340 nested generic storey.
1342 2009-01-26 Marek Safar <marek.safar@gmail.com>
1344 * expression.cs: Check for null instance methodgroup expression.
1346 2009-01-26 Marek Safar <marek.safar@gmail.com>
1348 A fix for bug #469244
1349 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1350 instance inside a conditional expression.
1352 2009-01-23 Marek Safar <marek.safar@gmail.com>
1354 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1355 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1356 GetElementType and HasElementType. IsValueType clean up.
1358 2009-01-23 Marek Safar <marek.safar@gmail.com>
1360 * nullable.cs: Use common EmitCall.
1362 * expression.cs: Emit constraint. for virtual calls only.
1364 2009-01-23 Marek Safar <marek.safar@gmail.com>
1366 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1367 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1368 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1371 2009-01-22 Jb Evain <jbevain@novell.com>
1373 * anonymous.cs: make anonymous types' ToString implementation
1374 match what csc outputs.
1376 2009-01-21 Marek Safar <marek.safar@gmail.com>
1378 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1381 2009-01-17 Marek Safar <marek.safar@gmail.com>
1383 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1386 2009-01-16 Marek Safar <marek.safar@gmail.com>
1388 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1391 2009-01-15 Marek Safar <marek.safar@gmail.com>
1393 A fix for bug #466634
1394 * statement.cs: Add reference for nested storey when only this
1397 2009-01-15 Marek Safar <marek.safar@gmail.com>
1399 A fix for bug #466474
1400 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1403 2009-01-15 Marek Safar <marek.safar@gmail.com>
1405 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1406 Fixed nested stories parent referencing process. Also fixes #463985.
1408 2009-01-06 Marek Safar <marek.safar@gmail.com>
1410 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1411 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1412 implementation. Also fixes #463108.
1414 2009-01-05 Marek Safar <marek.safar@gmail.com>
1416 A fix for bug #416109
1417 * decl.cs: Issue correct CLSAttribute warning location.
1419 2009-01-05 Marek Safar <marek.safar@gmail.com>
1421 A fix for bug #456775
1422 * attribute.cs: Use attribute owner scope when resolving attribute
1425 2009-01-05 Marek Safar <marek.safar@gmail.com>
1427 A fix for bug #457257
1428 * decl.cs: Fixed incorrect member declaring type comparison.
1430 2009-01-05 Marek Safar <marek.safar@gmail.com>
1432 A fix for bug #460896
1433 * driver.cs: Handle /RES resources as embeddable.
1435 2009-01-05 Marek Safar <marek.safar@gmail.com>
1437 A fix for bug #462515
1438 * ecore.cs: Report inacessible members upwards.
1440 2009-01-05 Marek Safar <marek.safar@gmail.com>
1442 A fix for bug #463190, #463192
1443 * decl.cs, namespace.cs: Also import internal extension classes.
1445 2009-01-04 Marek Safar <marek.safar@gmail.com>
1447 A fix for bug #463415
1448 * generic.cs: Use right index for RemoveDependentTypes.
1450 2009-01-02 Marek Safar <marek.safar@gmail.com>
1452 A fix for bug #463196
1453 * expression.cs: Fixed enum to null comparison.
1455 2009-01-02 Marek Safar <marek.safar@gmail.com>
1457 A fix for bug #463121
1458 * nullable.cs: Fixed nullable user equality operator comparison.
1460 2009-01-02 Marek Safar <marek.safar@gmail.com>
1462 A fix for bug #462950
1463 * class.cs, decl.cs: Use full explicit name when defining automatic
1464 property backing field.
1466 2009-01-02 Marek Safar <marek.safar@gmail.com>
1468 A fix for bug #462592
1469 * pending.cs: Emit type arguments for generic proxy method.
1471 2008-12-30 Marek Safar <marek.safar@gmail.com>
1473 * expression.cs (As): Mutate all type arguments.
1475 2008-12-29 Marek Safar <marek.safar@gmail.com>
1477 A fix for bug #462622
1478 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1481 2008-12-29 Marek Safar <marek.safar@gmail.com>
1483 A fix for bug #450782
1484 * ecore.cs: Consider more variables of form V.I to be fixed.
1486 2008-12-29 Marek Safar <marek.safar@gmail.com>
1488 A fix for bug #460712
1489 * typemanager.cs: Core types could be imported.
1491 2008-12-28 Marek Safar <marek.safar@gmail.com>
1493 A fix for bugs #460847, #460772, #458049, #457339, #447807
1494 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
1495 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
1496 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
1497 user lambdas used inside query clauses.
1499 2008-12-18 Marek Safar <marek.safar@gmail.com>
1501 A fix for bug #460229
1502 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
1504 2008-12-18 Marek Safar <marek.safar@gmail.com>
1506 A fix for bug #459952
1507 * decl.cs, namespace.cs: Use common CheckAccessLevel.
1509 2008-12-18 Marek Safar <marek.safar@gmail.com>
1511 A fix for bug #459630
1512 * convert.cs: Enum to valuetype conversion is not allowed.
1514 2008-12-18 Marek Safar <marek.safar@gmail.com>
1516 A fix for bug #457087
1517 * generic.cs: Don't crash when constraint comes from type
1520 2008-12-16 Marek Safar <marek.safar@gmail.com>
1522 A fix for bug #459221
1523 * anonymous.cs, statement.cs: Delay only captured this
1526 2008-12-12 Marek Safar <marek.safar@gmail.com>
1528 A fix for bug #457489
1529 * anonymous.cs, statement.cs: Split anonymous storey instantiation
1530 and initialization to capture scope initializers correctly.
1532 2008-12-11 Marek Safar <marek.safar@gmail.com>
1534 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
1535 ParameterReference refactoring.
1537 2008-12-03 Marek Safar <marek.safar@gmail.com>
1539 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
1540 to be imported from any assembly.
1542 2008-12-03 Marek Safar <marek.safar@gmail.com>
1544 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
1545 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
1546 from anonymous method and lambda expression.
1548 2008-12-01 Marek Safar <marek.safar@gmail.com>
1550 A fix for bug #448560
1551 * expression.cs (As): Box any generic type arguments to be
1554 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1556 Add tripwire for implicit conversion bugs
1557 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
1559 (MethodGroupExpr.OverloadResolve): Add sanity check between
1560 IsApplicable and VerifyArgumentsCompat.
1561 (VerifyArgumentsCompat): Report CS1501 where appropriate.
1563 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1565 Fix build break in System.Data_test
1566 * convert.cs (ImplicitConversionExists): Move NullLiteral
1568 (ImplicitStandardConversionExists): ... here.
1570 2008-11-28 Marek Safar <marek.safar@gmail.com>
1572 * literal.cs: Emit correctly explicit null to nullable cast.
1574 2008-11-28 Marek Safar <marek.safar@gmail.com>
1576 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
1579 2008-11-28 Marek Safar <marek.safar@gmail.com>
1581 A fix for bug #449005
1582 * convert.cs, nullable.cs: Use only one implicit nullable
1585 2008-11-27 Marek Safar <marek.safar@gmail.com>
1587 * convert.cs, literal.cs: More Convert cleanup is needed.
1589 2008-11-27 Marek Safar <marek.safar@gmail.com>
1591 * decl.cs, class.cs: Fixed misleading error message.
1593 2008-11-26 Marek Safar <marek.safar@gmail.com>
1595 A fix for bug #449005
1596 * nullable.cs (EmitEquality): Disable optimization for user operator
1599 2008-11-25 Marek Safar <marek.safar@gmail.com>
1601 A fix for bug #447027
1602 * anonymous.cs (HoistedVariable): Cache also outer access to deal
1603 with context variables stored as expression instances.
1605 2008-11-25 Marek Safar <marek.safar@gmail.com>
1607 A fix for bug #447027
1608 * delegate.cs: Fixed delegate VerifyMethod logic.
1610 2008-11-24 Marek Safar <marek.safar@gmail.com>
1612 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
1615 2008-11-21 Marek Safar <marek.safar@gmail.com>
1617 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
1618 member type resolve to follow normal flow, instead of random
1621 2008-11-21 Marek Safar <marek.safar@gmail.com>
1623 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
1626 2008-11-21 Marek Safar <marek.safar@gmail.com>
1628 * const.cs: Emit decimal array constant as literal.
1630 2008-11-20 Marek Safar <marek.safar@gmail.com>
1632 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
1634 2008-11-19 Marek Safar <marek.safar@gmail.com>
1636 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
1637 into real property (saves 8 MB for corlib compilation).
1639 2008-11-19 Marek Safar <marek.safar@gmail.com>
1641 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
1642 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
1643 generic-mcs.cs: Small cleanup of TypeArguments.
1645 2008-11-18 Marek Safar <marek.safar@gmail.com>
1647 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
1648 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
1649 of ConstructedType expression, renamed to GenericTypeExpr.
1651 2008-11-17 Marek Safar <marek.safar@gmail.com>
1653 A fix for bug #445303
1654 * location.cs (IsConditionalDefined): Handle undefined global
1657 2008-11-17 Marek Safar <marek.safar@gmail.com>
1659 A fix for bug #444678
1660 * expression.cs (TryReduceConstant): Always create new constant
1663 2008-11-17 Marek Safar <marek.safar@gmail.com>
1665 A fix for bug #444673
1666 * ecore.cs: Ignore open generic types when used as generic type
1669 2008-11-17 Marek Safar <marek.safar@gmail.com>
1671 A fix for bug #445458
1672 * expression.cs, cs-parser.jay: Don't crash when an expression
1675 2008-11-17 Marek Safar <marek.safar@gmail.com>
1677 A fix for bug #445464
1678 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
1679 inside unbound type.
1681 2008-11-14 Jb Evain <jbevain@novell.com>
1683 * driver.cs: ignore empty -nowarn argument such as
1684 the one in -nowarn:12,13,,.
1686 2008-11-13 Marek Safar <marek.safar@gmail.com>
1688 A fix for bug #444271
1689 * anonymous.cs: Rescan parent storeys when best candidate was
1692 2008-11-13 Marek Safar <marek.safar@gmail.com>
1694 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
1695 useless UnboundTypeExpression.
1697 * attribute.cs: Do check obsolete attribute on generic types.
1699 2008-11-12 Marek Safar <marek.safar@gmail.com>
1701 A fix for bugs #425680, #400139
1702 * ecore.cs, expression.cs: Trying to do some almost_matched_members
1705 2008-11-11 Marek Safar <marek.safar@gmail.com>
1707 A fix for bug #435747
1708 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
1709 compound value types assignment. Few micro optimizations added.
1711 2008-11-10 Marek Safar <marek.safar@gmail.com>
1713 A fix for bug #442610
1714 * anonymous.cs (MutateConstructor): More SRE hacking.
1716 2008-11-10 Marek Safar <marek.safar@gmail.com>
1718 A fix for bug #442579
1719 * ecore.cs: Also initialize expanded form of a method with 1 params
1722 2008-11-06 Marek Safar <marek.safar@gmail.com>
1724 * expression.cs (UnaryMutator): Do early l-side check.
1726 2008-11-05 Miguel de Icaza <miguel@novell.com>
1728 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
1729 Init, otherwise we would crash later on when checking for friend
1732 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
1733 Otherwise we never get any meaningful information as to what
1736 2008-11-05 Marek Safar <marek.safar@gmail.com>
1738 A fix for bug #436318
1739 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
1741 2008-11-05 Miguel de Icaza <miguel@novell.com>
1743 * namespace.cs: Turns out that it was a really bad idea to hide
1744 the errors for namespaces not found here in eval mode.
1746 * eval.cs: When we process using clauses, only enter those into
1747 the list of valid using clauses after they have been validated.
1749 The above change gives the proper semantics: it does not
1750 senselessly report the same errors with broken using statements by
1751 never storing them in the first place when they are invalid.
1753 2008-11-05 Marek Safar <marek.safar@gmail.com>
1755 A fix for bug #421839
1756 * cs-parser.jay: Remove expression from coalesce rule to force lower
1757 priority than the assignment operator.
1759 2008-11-05 Marek Safar <marek.safar@gmail.com>
1761 A fix for bug #437875
1762 * nullable.cs: Compile correctly method group operand used with null
1763 coalescing operator.
1765 2008-11-04 Marek Safar <marek.safar@gmail.com>
1767 A fix for bug #434589
1768 * expression.cs (Binary): Ignore lifted conversions when at least
1769 one operand is of reference type.
1771 2008-11-04 Marek Safar <marek.safar@gmail.com>
1773 * cs-parser.jay: Better syntax error report.
1775 2008-11-03 Marek Safar <marek.safar@gmail.com>
1777 A fix for bug #436792
1778 * cs-parser.jay: Use GetLocation to access location.
1780 2008-11-03 Marek Safar <marek.safar@gmail.com>
1782 A fix for bug #440774
1783 * cs-parser.jay: Also set current_array_type when parsing local
1786 2008-11-03 Marek Safar <marek.safar@gmail.com>
1788 A fix for bug #440785
1789 * expression.cs (As): Don't resolve self modifing expression
1792 2008-11-03 Marek Safar <marek.safar@gmail.com>
1794 A fix for bug #439447
1795 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
1797 2008-11-03 Marek Safar <marek.safar@gmail.com>
1799 A fix for bug #437571
1800 * cs-parser.jay: Fixes internal error for invalid expression
1803 2008-10-17 Marek Safar <marek.safar@gmail.com>
1805 * ecore.cs: Resolve correctly ambiguous params delegate methods.
1807 2008-10-17 Marek Safar <marek.safar@gmail.com>
1809 * generic.cs, anonymous.cs: Simplified GetDeclarations.
1811 2008-10-17 Marek Safar <marek.safar@gmail.com>
1813 * cs-tokenizer.cs: More precise cast parsing.
1815 2008-10-16 Martin Baulig <martin@ximian.com>
1817 * anonymous.cs (AnonymousMethodStorey): Put back the
1818 `hoisted_locals' hashtable and use it in EmitType().
1820 2008-10-15 Marek Safar <marek.safar@gmail.com>
1822 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
1823 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
1826 2008-10-14 Marek Safar <marek.safar@gmail.com>
1828 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
1830 2008-10-14 Marek Safar <marek.safar@gmail.com>
1832 * statement.cs: Mutate scope initializers.
1834 2008-10-14 Marek Safar <marek.safar@gmail.com>
1836 * expression.cs: Use typeless value for This constant.
1838 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
1840 2008-10-14 Marek Safar <marek.safar@gmail.com>
1842 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
1845 2008-10-13 Marek Safar <marek.safar@gmail.com>
1847 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
1850 2008-10-13 Marek Safar <marek.safar@gmail.com>
1852 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
1853 parser and tokenizer. Fixes many ambiguities including #433258.
1855 2008-10-10 Marek Safar <marek.safar@gmail.com>
1857 * cs-parser.jay: Fixed missing accessor recovery.
1859 2008-10-10 Marek Safar <marek.safar@gmail.com>
1861 A fix for bug #433701
1862 * expression.cs: Better error message.
1864 2008-10-10 Marek Safar <marek.safar@gmail.com>
1866 * cs-parser.jay, expression.cs: Start reporting real parser errors.
1868 * Makefile: Disabled unused debug symbols.
1870 Also fixes: #320556, #321097, #321656, #321876, #351316
1872 2008-10-09 Miguel de Icaza <miguel@novell.com>
1874 * eval.cs: rename "<interactive>" to "{interactive}", to work
1875 around a requirement in the compiler that this be a valid
1876 filename, and in Windows it is not (433886).
1878 2008-10-09 Marek Safar <marek.safar@gmail.com>
1880 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
1882 2008-10-08 Marek Safar <marek.safar@gmail.com>
1884 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
1885 cs-parser.jay: Generic type declaration and type arguments cleanup.
1887 2008-10-05 Marek Safar <marek.safar@gmail.com>
1889 * cs-parser.jay: Allow parsing weird array creation construct.
1891 2008-10-05 Marek Safar <marek.safar@gmail.com>
1893 * cs-parser.jay: Conflicts reduction.
1895 2008-10-04 Marek Safar <marek.safar@gmail.com>
1897 * cs-parser.jay: Conflicts reduction.
1899 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
1902 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
1903 property. Add a 'count' hint about the use of the shared vector.
1904 Ensure that we don't leak out dirty bits.
1905 (UsageVector.MergeChild): Throw away information about variables
1907 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
1909 2008-10-03 Marek Safar <marek.safar@gmail.com>
1911 A fix for bug #431746
1912 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
1913 parameters when iterator is created.
1915 2008-10-03 Marek Safar <marek.safar@gmail.com>
1917 A fix for bug #431827
1918 * expression.cs: Fixed right based pointer arithmetic operations
1921 2008-10-03 Marek Safar <marek.safar@gmail.com>
1923 A fix for bug #353779
1924 * assign.cs, expression.cs: Fixed compound assignment conversions.
1926 2008-10-02 Marek Safar <marek.safar@gmail.com>
1928 A fix for bug #375262
1929 * statement.cs: Refactor ArrayForeach to be usable with string
1930 indexer. Optimized single dimentional arrays foreach.
1932 2008-10-02 Marek Safar <marek.safar@gmail.com>
1934 A fix for bug #431255
1935 * anonymous.cs, expression.cs: Removed broken optimization.
1937 2008-10-01 Marek Safar <marek.safar@gmail.com>
1939 * anonymous.cs: Use full type parameters of parent generic
1940 containers. Removed unnecessary AddParentStoreyReference call.
1942 2008-10-01 Marek Safar <marek.safar@gmail.com>
1944 A fix for bug #324702
1945 * class.cs: Use better shorter names for explicit interface member
1948 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
1950 2008-10-01 Marek Safar <marek.safar@gmail.com>
1952 * expression.cs: Use new interface to check fixed expression.
1954 2008-10-01 Marek Safar <marek.safar@gmail.com>
1956 A fix for bug #421101
1957 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
1958 interface to check for fixed fixed-buffers.
1960 2008-10-01 Marek Safar <marek.safar@gmail.com>
1962 A fix for bug #429264
1963 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
1965 * delegate.cs: Removed unnecessary casts.
1967 2008-09-30 Marek Safar <marek.safar@gmail.com>
1969 A fix for bug #352151
1970 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
1971 class.cs: Fixed already defined explicit interface members check.
1973 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
1975 cs-tokenizer.cs: Fix typo.
1977 2008-09-28 Miguel de Icaza <miguel@novell.com>
1979 * eval.cs (InteractiveBase): The quit command now just sets a
1980 flag, instead of calling Environment.Exit(), it is milder on
1983 CompiledMethod is now in Mono.CSharp, not nested inside
1984 the Evaluator, it was inconvenient to use.
1986 2008-09-27 Miguel de Icaza <miguel@novell.com>
1988 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
1989 code to be invoked without having to reparse.
1991 2008-09-27 Miguel de Icaza <miguel@novell.com>
1993 * ecore.cs: The recent changes to FieldExpr broke this as well.
1994 Fixes LINQ queries in the interactive shell.
1996 * Multiple files: indentation fixing for the Mono coding
1997 guidelines for the switch statement.
1999 * eval.cs: Make the Evaluator API thread safe.
2001 2008-09-26 Marek Safar <marek.safar@gmail.com>
2003 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2004 constructor parsing.
2006 2008-09-26 Marek Safar <marek.safar@gmail.com>
2008 A fix for bug #325326
2009 * statement.cs: Check possible mistaken empty statement using
2010 explicit blocks only.
2012 2008-09-25 Miguel de Icaza <miguel@novell.com>
2014 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2015 RootNamespace.ComputeNamespaces to update the internal list of
2016 namespaces, this is no longer done for us.
2018 (InteractiveBase): Use the Evaluator APIs instead of calling into
2021 2008-09-25 Marek Safar <marek.safar@gmail.com>
2023 A fix for bug #429264
2024 * expression.cs: Missing mutator for access to multidimensional
2027 2008-09-25 Marek Safar <marek.safar@gmail.com>
2029 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2032 * driver.cs: Missing input argument check.
2034 2008-09-25 Marek Safar <marek.safar@gmail.com>
2036 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2037 expression.cs, statement.cs, rootcontext.cs, class.cs,
2038 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2041 2008-09-24 Miguel de Icaza <miguel@novell.com>
2043 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2044 fully constructed FieldExpr, fixes the regression introduced in
2047 * ecore.cs, expression.cs: Plug back the eclass initialization as
2048 otherwise it regresses `csharp'.
2050 2008-09-24 Marek Safar <marek.safar@gmail.com>
2052 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2053 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2054 phase to resolve phase. It resolves problems with expression trees
2055 and fixes bugs #323796, #325156.
2057 2008-09-23 Marek Safar <marek.safar@gmail.com>
2059 * codegen.cs: Report better error when symbol writer is missing.
2061 2008-09-23 Marek Safar <marek.safar@gmail.com>
2063 * codegen.cs: Set .NET symbol writer.
2065 * decl.cs: Guard against null generic arguments.
2067 * report.cs: Don't report exactly same additional details.
2069 2008-09-22 Marek Safar <marek.safar@gmail.com>
2071 A fix for bug #324917
2072 * cs-parser.jay: Add missing multidimensional non-expression type
2075 2008-09-22 Marek Safar <marek.safar@gmail.com>
2077 A fix for bug #428191
2078 * anonymous.cs: Create an outer generic fields also for non-storey
2081 2008-09-22 Marek Safar <marek.safar@gmail.com>
2083 A fix for bug #378294
2084 * class.cs: Make fixed size buffers gmcs feature only.
2086 2008-09-22 Marek Safar <marek.safar@gmail.com>
2088 A fix for bug #355622, #324993
2089 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2092 2008-09-19 Marek Safar <marek.safar@gmail.com>
2094 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2097 2008-09-19 Marek Safar <marek.safar@gmail.com>
2099 A fix for bug #416110
2100 * generic.cs: Struct constraint results in default ctor and
2101 ValueType base type constraint to be set.
2103 2008-09-19 Marek Safar <marek.safar@gmail.com>
2105 A fix for bug #423791
2106 * generic.cs: Fixed params output type type-inference.
2108 2008-09-19 Marek Safar <marek.safar@gmail.com>
2110 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2112 2008-09-19 Marek Safar <marek.safar@gmail.com>
2114 * cs-tokenizer.cs: Don't break on extra partial modifier.
2116 2008-09-19 Marek Safar <marek.safar@gmail.com>
2118 A fix for bug #427592
2119 * generic.cs: Use common parameter resolve method.
2121 2008-09-18 Marek Safar <marek.safar@gmail.com>
2123 A fix for bug #414758
2124 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2127 2008-09-18 Marek Safar <marek.safar@gmail.com>
2129 * driver.cs, namespace.cs: Read types and namespaces after all
2130 requested assemblies are loaded, fixes issues with System.Core
2131 auto-reference, and #419888.
2133 2008-09-18 Marek Safar <marek.safar@gmail.com>
2135 A fix for bug #417705
2136 * cs-parser.jay: Fixed as/is operator expression split.
2138 2008-09-18 Marek Safar <marek.safar@gmail.com>
2140 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2141 Fixed expression tree representation of empty new expression and
2142 new initializer expression.
2144 2008-09-18 Miguel de Icaza <miguel@novell.com>
2146 * eval.cs: Remove warning, keep reference to driver around.
2148 * Hide fields that do not need to be public.
2150 2008-09-17 Marek Safar <marek.safar@gmail.com>
2152 A fix for bug #426385
2153 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2154 conversion for array elements.
2156 2008-09-17 Marek Safar <marek.safar@gmail.com>
2158 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2159 void parsing conflicts.
2161 2008-09-15 Marek Safar <marek.safar@gmail.com>
2163 A fix for bug #425601
2164 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2165 System.Core only when there is no custom ExtensionAttribute
2168 2008-09-15 Miguel de Icaza <miguel@novell.com>
2170 * namespace.cs: Do not report CS0246 (name
2172 2008-09-12 Marek Safar <marek.safar@gmail.com>
2174 A fix for bug #425669
2175 * generic.cs: Don't cache generic static anonymous method
2178 2008-09-12 Marek Safar <marek.safar@gmail.com>
2180 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2181 conflicting constraints.
2183 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2185 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2188 2008-09-12 Marek Safar <marek.safar@gmail.com>
2190 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2191 to null pointer conversion fixes.
2193 2008-09-11 Marek Safar <marek.safar@gmail.com>
2195 * cs-parser.jay, expression.cs: An implicitly typed local variable
2196 declarator cannot use an array initializer.
2198 2008-09-11 Marek Safar <marek.safar@gmail.com>
2200 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2202 2008-09-11 Marek Safar <marek.safar@gmail.com>
2204 * generic.cs (InflatedConstraints): Don't crash when constraints
2207 * cs-parser.jay: const_declarator is a block.
2209 * constant.cs: Check for not allowed NaN conversions.
2211 2008-09-10 Miguel de Icaza <miguel@novell.com>
2213 * driver.cs: Drop --shell argument, the compiler is no longer a
2216 * eval.cs: Move most of the code that deals with evaluation into
2217 this file and document the public API from repl.cs
2219 * repl.cs: Remove from here.
2221 2008-09-10 Marek Safar <marek.safar@gmail.com>
2223 A fix for bug #424684
2224 * generic.cs: Generic class constraints must come first.
2226 2008-09-09 Miguel de Icaza <miguel@novell.com>
2228 * cs-parser.jay: Improve error reporting for syntax errors in
2229 statements and expressions, we now report the expected tokens
2230 instead of reporting the useless "; expected".
2232 Drop the strings from the token declaration, it turns out that
2233 they did not do what I thought they did. Instead they were adding
2234 two sets of tokens to the tables.
2236 2008-09-09 Marek Safar <marek.safar@gmail.com>
2238 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2239 delegate.cs: Share special type check.
2241 2008-09-09 Marek Safar <marek.safar@gmail.com>
2243 A fix for bug #423981
2244 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2246 2008-09-09 Marek Safar <marek.safar@gmail.com>
2248 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2251 2008-09-09 Marek Safar <marek.safar@gmail.com>
2253 A fix for bugs: #324750, #335946
2254 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2255 lookup rule to determine ?-based tokens.
2257 2008-09-08 Miguel de Icaza <miguel@novell.com>
2259 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2260 expressions (like event adding or removing) end up here, so we
2261 need to treat those as statements.
2263 Add LoadAssembly method.
2265 2008-09-04 Miguel de Icaza <miguel@novell.com>
2267 * repl.cs: Add Time method.
2269 2008-09-05 Marek Safar <marek.safar@gmail.com>
2271 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2273 2008-09-05 Miguel de Icaza <miguel@novell.com>
2275 * repl.cs: Add workaround for old compilers.
2277 2008-09-04 Jb Evain <jbevain@novell.com>
2279 * repl.cs (PrettyPrint): pretty print everything that
2280 implements IDictionary, as well as IEnumerables. Also,
2281 add a quit helper property.
2283 2008-09-04 Marek Safar <marek.safar@gmail.com>
2285 * constant.cs: Better error reporting for decimal literals.
2287 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2290 2008-09-04 Marek Safar <marek.safar@gmail.com>
2291 Miguel de Icaza <miguel@novell.com>
2293 A fix for bug #422951
2294 * assign.cs (Assign.DoResolve): Perform the type conversions
2295 checks before we attempt to initialize `New' initializers.
2297 2008-09-04 Marek Safar <marek.safar@gmail.com>
2299 A fix for bug #422853
2300 * delegate.cs (DelegateCreation): Add special handling for
2301 EmptyExpression.Null instance expression which is just another
2302 hack for undecided member instance exression.
2304 2008-09-04 Marek Safar <marek.safar@gmail.com>
2306 * expression.cs, ecore.cs: Emit full expression tree for reduced
2309 2008-09-04 Marek Safar <marek.safar@gmail.com>
2311 * expression.cs (This): Guard against multi-resolving.
2313 * ecore.cs, statement.cs (Throw): Simplified.
2315 * flowanalysis.cs: Also verify event fields.
2317 2008-09-04 Miguel de Icaza <miguel@novell.com>
2319 * assign.cs (Assign.DoResolve): Perform the type conversions
2320 checks before we attempt to initialize `New' initializers.
2322 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2324 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2327 * repl.cs: Update help.
2329 2008-09-03 Miguel de Icaza <miguel@novell.com>
2331 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2332 handling of the default config handling, including the special
2333 treatment of System.Core assembly.
2335 Fixes the REPL processing for LINQ.
2337 2008-09-03 Marek Safar <marek.safar@gmail.com>
2339 A fix for bug #422507
2340 * expression.cs (UnboxCast): Add missing child expression mutator.
2342 2008-09-03 Marek Safar <marek.safar@gmail.com>
2344 * driver.cs: Don't self reference System.Core assembly.
2346 2008-09-03 Marek Safar <marek.safar@gmail.com>
2348 A fix for bug #422507
2349 * expression.cs (StringConcat): Add missing type mutator.
2351 2008-09-03 Marek Safar <marek.safar@gmail.com>
2353 * generic.cs (TypeInferenceContext): Follow equality rule for
2354 constructed type lower bound type inference.
2356 2008-09-02 Miguel de Icaza <miguel@novell.com>
2358 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2359 <dblank@cs.brynmawr.edu> which updates the cursor position on
2362 2008-09-02 Marek Safar <marek.safar@gmail.com>
2364 A fix for bug #367145
2365 * driver.cs: Fixed import of extension methods when using -noconfig
2368 2008-09-02 Marek Safar <marek.safar@gmail.com>
2370 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2371 version from non-generic implementation instead.
2373 2008-09-01 Marek Safar <marek.safar@gmail.com>
2375 A fix for bug #418908
2376 * class.cs: Use AddScopeStatement for field initializers.
2378 2008-09-01 Marek Safar <marek.safar@gmail.com>
2380 A fix for bug #415385
2381 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2383 2008-09-01 Marek Safar <marek.safar@gmail.com>
2385 A fix for bug #421736
2386 * iterators.cs: Don't crash on unreachable iterators.
2388 2008-09-01 Marek Safar <marek.safar@gmail.com>
2390 A fix for bug #421628
2391 * parameter.cs, attribute.cs: Clone also parameter attributes.
2393 2008-08-30 Miguel de Icaza <miguel@novell.com>
2395 * namespace.cs (LookupType): In EvalMode, try to replace
2396 the TypeBuilder from our cache with a Type as Reflection.Emit does
2397 not like to mix code from older assemblies emitted and new
2400 This sounds like a serious Mono bug that prevents multiple
2401 assemblies to be generated and consumed at the same time.
2403 * cs-parser.jay (push_current_class): Do not make interactive
2404 classes internal or private, make them public as we currently
2405 generate each new class in a new assembly.
2407 2008-08-29 Miguel de Icaza <miguel@novell.com>
2409 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2410 remove types that are entered into the global namespace during
2411 parsing so that we can remove them on failure.
2413 * cs-parser.jay: Parsing: we now keep track of types that are
2414 entered into global variables and queue those in case the parsing
2417 This happens in a few situations: during partial-input, we invoke
2418 the parser repeatedly for example with the string "class X", this
2419 would cause X to be registed, and we need to remove this
2420 registration so that another parse attempt later with say "class X {"
2421 would actually work.
2423 Additionally, if there is an error in the resolution phase, for
2424 example: "class X : NonExistant {}" th
2426 * cs-parser.jay: Be more precise with the errors being raised,
2427 instead of flagging all exceptions during parsing to be attributed
2428 to the parsing process, distinguish those from errors happening in
2429 the actions and hint that using -v would produce the actual
2432 * repl.cs: Do not load all compiler references on each reset,
2433 doing the partial reset takes care of this.
2435 2008-08-28 Miguel de Icaza <miguel@novell.com>
2437 * repl.cs: Add support for loading all the files from
2438 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2441 Introduce a micro-parser that is able to deambiguate on its input
2442 whether we are dealing with a compilation unit (namespace, class,
2443 interface, struct, delegate) declaration or a statement. This
2444 allows both declarations and statements to be entered.
2446 Set history size by default to 300 lines.
2448 Instead of distinguishing based on the parser.InteractiveResult,
2449 have only two cases: statements were parsed, or a compilation unit
2450 was. Always pull the Using statement additions from the
2451 compilation unit parse.
2453 * cs-tokenizer.cs: Rename tokens to better describe their intent
2454 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2456 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2457 EvalMode is used to trigger the lookup of global variables while
2458 StatementMode is used turn variable declarations into static
2461 * getline.cs: Allow history size to be set.
2463 2008-08-29 Marek Safar <marek.safar@gmail.com>
2465 A fix for bug #360755
2466 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2468 2008-08-29 Marek Safar <marek.safar@gmail.com>
2470 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2472 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2473 member name, it is too confusing
2475 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2477 * rootcontext.cs: Finally default to warning level 4.
2479 2008-08-28 Marek Safar <marek.safar@gmail.com>
2481 * class.cs (CheckBase): Ignore overloaded operators.
2483 2008-08-28 Marek Safar <marek.safar@gmail.com>
2485 A fix for bug #420830
2486 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
2488 2008-08-28 Marek Safar <marek.safar@gmail.com>
2490 A fix for bug #420832
2491 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
2493 2008-08-28 Marek Safar <marek.safar@gmail.com>
2495 A fix for bug #420386
2496 * nullables.cs: Fixed logic of nullable user comparison operators involving
2499 2008-08-28 Marek Safar <marek.safar@gmail.com>
2501 * attribute (IsClsCompliant): Use FALSE value for pointer types.
2503 2008-08-27 Miguel de Icaza <miguel@novell.com>
2505 * repl.cs: Add support for aborting the running code with C-c.
2507 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
2509 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
2511 2008-08-27 Miguel de Icaza <miguel@novell.com>
2513 * cs-parser.jay (interactive_statement_list): A new set of rules
2514 for hosting statements that uses the "interactive_" prefix.
2516 * repl.cs: Add support for parsing `using' as a statement or as a
2517 directive. Deambiguating before passing this to the parser.
2519 We need to distinguish statement_expressions that occur at the
2520 toplevel vs those that occur embedded into expressions.
2522 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
2523 that fixes the cursor key handling, and a history bug.
2525 2008-08-26 Miguel de Icaza <miguel@novell.com>
2527 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
2528 limitations in Console, instead the 2.0 bootstrap libraries now
2529 include the Console bits.
2531 Also, remove the use of Nullables from getline.cs
2535 Interactive support for the C# compiler. Use gmcs --shell to
2536 enter a read-eval-print loop shell.
2538 Docs: http://www.mono-project.com/CsharpRepl
2540 * sources: include repl.cs here and getline.cs for gmcs.exe,
2541 everything else is getline.cs impaired.
2543 * Makefile: when bootstrapping pass a special flag
2544 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
2545 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
2546 This distinguishes those two cases.
2548 * repl.cs: Support for a read-eval-print loop. Will be soon
2549 refactored into eval support and then REPL on top of it.
2551 * ecore.cs: If a simplename lookup fails, before erroring out,
2552 if we are in EvalMode to resolve the name to a declaration in the
2555 This means that variable declarations that happened in previous
2556 classes (as repl puts every statement in a separate class) are
2557 made visible in this way.
2559 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
2560 triggered an error due to the end of file being reached. This is
2561 used to do multi-line input, and notify the caller that the user
2562 needs to provide more text before a successful parse.
2564 Add new grammar rules after the INTERACTIVE_PARSER token is seen
2565 to drive the evaluation with a custom wrapper.
2567 * driver.cs: Add support for --shell, and refactor some code to be
2570 * namespace.cs: Add support for serializing the contents of the
2571 namespaces and reloading them.
2573 * getline.cs: A managed implementation of ReadLine under
2574 X11/Apache2 license terms. Easy to embed in other applications as
2577 * namespace.cs: Add some functions to save and restore the
2580 * rootcontext.cs: New public field.
2582 * cs-tokenizer.cs: Add support for one of the possible characters
2583 we introduce into the token stream.
2585 This patch does not affect the regular tokenization process, the
2586 only performance hit would happen if there is an invalid character
2587 on the input string.
2589 * support.cs: Move isatty helper routine here.
2591 * codegen.cs: Small cleanup, and add a mechanism to initialize the
2592 code generator for in-memory assemblies.
2594 2008-08-26 Marek Safar <marek.safar@gmail.com>
2596 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
2597 parameter cannot be always used as a type.
2599 2008-08-21 Marek Safar <marek.safar@gmail.com>
2601 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
2603 2008-08-21 Marek Safar <marek.safar@gmail.com>
2605 * convert.cs: Implement explicit array to IList<T> conversion.
2607 2008-08-20 Marek Safar <marek.safar@gmail.com>
2609 A fix for bug #362740
2610 * cs-tokenizer.cs: Handle UTF-16 surrogates.
2612 2008-08-20 Marek Safar <marek.safar@gmail.com>
2614 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
2615 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
2616 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
2617 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
2618 handling to use just one type of infrastructure and deal with generics
2621 2008-07-23 Martin Baulig <martin@ximian.com>
2623 *** Merged this from trunk revision 108527 ***
2626 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
2627 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
2630 2008-08-15 Marek Safar <marek.safar@gmail.com>
2632 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
2635 2008-08-15 Marek Safar <marek.safar@gmail.com>
2637 * delegate.cs: Fixed compiler crash when creating delegate using partial
2640 * typemanager.cs: MulticastDelegate is not a delegate.
2642 2008-08-14 Marek Safar <marek.safar@gmail.com>
2644 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
2647 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
2649 * cs-parser.jay (type): Allow 'var' in mcs too.
2650 (local_variable_type): Likewise.
2652 2008-08-14 Marek Safar <marek.safar@gmail.com>
2654 * driver.cs: Removed broken -noconfig variants.
2656 2008-08-14 Marek Safar <marek.safar@gmail.com>
2658 A fix for bug #417078
2659 * expression.cs: Emit correctly left side pointer operators.
2661 2008-08-13 Marek Safar <marek.safar@gmail.com>
2663 * generic.cs, lambda.cs: Inflate method generic arguments only.
2665 2008-08-12 Marek Safar <marek.safar@gmail.com>
2667 * class.cs: Fixed struct layout check regression.
2669 2008-08-12 Marek Safar <marek.safar@gmail.com>
2671 * cs-parser.jay, enum.cs: Simplified enum parsing.
2673 * decl.cs: Check all type parameters conflicts.
2675 * expression.cs, statement.cs, attribute.cs: More expression checks.
2677 2008-08-11 Marek Safar <marek.safar@gmail.com>
2679 * generic.cs: Add type inference types restriction.
2681 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
2682 anonymous.cs, expression.cs: Allocate less accessor parameters.
2684 2008-08-08 Marek Safar <marek.safar@gmail.com>
2686 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
2689 2008-08-08 Marek Safar <marek.safar@gmail.com>
2691 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
2693 2008-08-07 Marek Safar <marek.safar@gmail.com>
2695 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
2696 Also fixes #362146 and #381592.
2698 2008-08-07 Marek Safar <marek.safar@gmail.com>
2700 * ecore.cs: Reduced constant cannot be used as an attribute value.
2702 * cs-parser.jay: Base expression has to be a type.
2704 * expression.cs (Conditional): Uses ReducedExpression.
2706 2008-08-06 Marek Safar <marek.safar@gmail.com>
2708 A fix for bug #376826
2709 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
2710 address of hoisted local variable or parameter cannot be taken.
2712 2008-08-05 Marek Safar <marek.safar@gmail.com>
2714 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
2715 anonymous method inside checked/unchecked expression.
2717 2008-08-05 Marek Safar <marek.safar@gmail.com>
2719 * typemanager.cs (IsEqual): Guard against null.
2721 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
2722 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
2723 routine. Fixed few misleading conversion errors.
2725 2008-08-04 Marek Safar <marek.safar@gmail.com>
2727 * class.cs: Consider generics when checking cycles in struct layout.
2729 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
2731 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
2733 2008-08-04 Marek Safar <marek.safar@gmail.com>
2735 A fix for bug #414165
2736 * anonymous.cs: Use same anonymous implementation method for all anonymous
2739 2008-08-04 Marek Safar <marek.safar@gmail.com>
2741 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
2744 2008-08-04 Marek Safar <marek.safar@gmail.com>
2746 * cs-parser.jay: Typeof argument has to be a type expression.
2748 * namespace.cs: Check alias and namespace definitions collisions.
2750 * class.cs, pending.cs: Moved explicit interface accessor implementation
2753 * delegate.cs, expression.cs: Verify special name invocations.
2755 2008-08-01 Marek Safar <marek.safar@gmail.com>
2757 * cs-parser.jay: Don't choke on empty generic type arguments.
2759 * cs-tokenizer.cs: Handle escaped preprocessor directives.
2761 * expression.cs, ecore.cs: Minor expressions bugs.
2763 2008-08-01 Marek Safar <marek.safar@gmail.com>
2765 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
2766 and added more error handling.
2768 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
2770 * modifiers.cs, enum.cs: Fixed.
2772 2008-07-31 Jb Evain <jbevain@novell.com>
2774 * driver.cs: remove -pkg ability of smcs.
2776 2008-07-30 Marek Safar <marek.safar@gmail.com>
2778 * statement.cs (Switch): Correctly set empty default target for single
2781 2008-07-30 Marek Safar <marek.safar@gmail.com>
2783 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
2784 string switch statement implementation to use string dictionary which
2785 significantly (2-8x) improves performance of generated code.
2787 2008-07-29 Marek Safar <marek.safar@gmail.com>
2789 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
2790 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
2792 2008-07-29 Marek Safar <marek.safar@gmail.com>
2794 A fix for bug #412595
2795 * typemanager.cs, convert.cs, expression.cs: Some types are never
2796 convertible to each other.
2798 2008-07-29 Marek Safar <marek.safar@gmail.com>
2800 * nullable.cs (CreateNullConstant): An error messages update.
2802 2008-07-29 Marek Safar <marek.safar@gmail.com>
2804 A fix for bug #412595
2805 * cfold.cs: Don't cast undefined bool constant.
2807 2008-07-29 Martin Baulig <martin@ximian.com>
2810 (SymbolWriter.Reset): New public static method.
2813 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
2815 2008-07-28 Marek Safar <marek.safar@gmail.com>
2817 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
2819 * expression.cs (ElementAccess): Exact size allocation.
2821 2008-07-26 Marek Safar <marek.safar@gmail.com>
2823 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
2825 2008-07-25 Marek Safar <marek.safar@gmail.com>
2827 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
2829 * class.cs: Removed $PRIVATE$ field hack which caused problems during
2832 2008-07-25 Marek Safar <marek.safar@gmail.com>
2834 A fix for bug #412217
2835 * assign.cs: Mutate also assignment type.
2837 2008-07-25 Marek Safar <marek.safar@gmail.com>
2839 A fix for bug #323644
2840 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
2843 2008-07-25 Marek Safar <marek.safar@gmail.com>
2845 A fix for bug #412134
2846 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
2847 non-enumerable operands when overloading equality or bitwise operators.
2849 2008-07-25 Marek Safar <marek.safar@gmail.com>
2851 * anonymous.cs: Cache closed generic anonymous method delegates.
2853 2008-07-24 Marek Safar <marek.safar@gmail.com>
2855 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
2856 anonymous.cs, statement.cs: Always emit anonymous method as static method
2857 when is instance free. Use nesting for nested anynomous methods blocks.
2859 2008-07-23 Marek Safar <marek.safar@gmail.com>
2861 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
2864 2008-07-23 Marek Safar <marek.safar@gmail.com>
2866 * expression.cs: Removed MakeSimpleCall.
2868 2008-07-23 Marek Safar <marek.safar@gmail.com>
2870 A fix for bug #323012
2871 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
2872 Base method implementing interface has to be public.
2874 2008-07-23 Marek Safar <marek.safar@gmail.com>
2876 * cs-parser.jay: Don't break on missing argument.
2878 2008-07-22 Marek Safar <marek.safar@gmail.com>
2880 A fix for bug #320993
2881 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
2882 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
2884 2008-07-22 Marek Safar <marek.safar@gmail.com>
2886 A fix for bug #320748
2887 * convert.cs: Implicit user operators cannot convert to interfaces
2889 2008-07-22 Marek Safar <marek.safar@gmail.com>
2891 A fix for bug #312686
2892 * driver.cs: Ignore empty assembly references.
2894 2008-07-22 Marek Safar <marek.safar@gmail.com>
2896 A fix for bug #387040
2897 * ecore.cs: Skip constrains check for an explicit implementation.
2899 2008-07-21 Marek Safar <marek.safar@gmail.com>
2901 A fix for bug #409045
2902 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
2903 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
2904 identifiers are file specific unless passed as input arguments.
2906 2008-07-21 Marek Safar <marek.safar@gmail.com>
2908 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
2909 to emit UnmanagedMarshal data under 2.0 profile.
2911 2008-07-21 Marek Safar <marek.safar@gmail.com>
2913 A fix for bug #410369
2914 * parameter.cs: Clone correctly ParamsParameter.
2916 2008-07-21 Marek Safar <marek.safar@gmail.com>
2918 * expression.cs (Argument): Always report type for type based expressions
2921 2008-07-18 Marek Safar <marek.safar@gmail.com>
2923 A fix for bug #410666
2924 * anonymous.cs: Correctly initialize generic storey reference.
2926 2008-07-18 Marek Safar <marek.safar@gmail.com>
2928 * convert.cs: Don't box same type arguments.
2930 2008-07-18 Marek Safar <marek.safar@gmail.com>
2932 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
2933 Finished missing generic type mutators.
2935 2008-07-18 Marek Safar <marek.safar@gmail.com>
2937 * iterators.cs, statement.cs: Finished statements CloneTo.
2939 2008-07-18 Marek Safar <marek.safar@gmail.com>
2941 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
2943 * expression.cs: Emit optimized default value expressions in expression tree
2946 2008-07-18 Marek Safar <marek.safar@gmail.com>
2948 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
2950 2008-07-17 Marek Safar <marek.safar@gmail.com>
2952 A fix for bug #367536
2953 * cs-parser.jay: Check static constructor of generic types for an access
2956 2008-07-17 Marek Safar <marek.safar@gmail.com>
2958 A fix for bug #353800
2959 * lambda.cs: Emit ret for contextual statements.
2961 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
2962 up emitting redundant ret for all anonymous methods with return.
2964 2008-07-17 Marek Safar <marek.safar@gmail.com>
2966 A fix for bug #365188
2967 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
2968 create anonymous method storey in unreachable block.
2970 2008-07-17 Marek Safar <marek.safar@gmail.com>
2972 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
2973 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
2974 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
2975 statement.cs: Fixed relevant defects found by Gendarme.
2977 2008-07-17 Marek Safar <marek.safar@gmail.com>
2979 A fix for bug #325291
2980 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
2981 statement.cs: Replaced IAnonymousHost with top level block flag.
2983 2008-07-17 Marek Safar <marek.safar@gmail.com>
2985 * cs-parser.jay: Clean up unused open_parens.
2987 2008-07-17 Marek Safar <marek.safar@gmail.com>
2989 * ecore.cs: Custom error message for a range variable assignment.
2991 2008-07-16 Marek Safar <marek.safar@gmail.com>
2993 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
2996 2008-07-16 Marek Safar <marek.safar@gmail.com>
2998 * literal.cs: Null literal is of object type.
3000 2008-07-16 Marek Safar <marek.safar@gmail.com>
3002 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3003 expression of nullable equality comparison.
3005 2008-07-15 Marek Safar <marek.safar@gmail.com>
3007 * expression.cs(PointerArithmetic): Removed redundant assignment.
3009 2008-07-15 Marek Safar <marek.safar@gmail.com>
3011 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3013 2008-07-14 Marek Safar <marek.safar@gmail.com>
3015 A fix for bug #408361
3016 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3017 they are replaced by GetMethod.
3019 2008-07-14 Marek Safar <marek.safar@gmail.com>
3021 A fix for bug #408721 by jeremie.laval@gmail.com
3022 * expression.cs (Indirection): Implemented CloneTo.
3024 2008-07-14 Marek Safar <marek.safar@gmail.com>
3026 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3029 2008-07-14 Marek Safar <marek.safar@gmail.com>
3031 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3033 2008-07-11 Marek Safar <marek.safar@gmail.com>
3035 * linq.cs: Reset tranparent parameter counter in probing mode.
3037 2008-07-11 Marek Safar <marek.safar@gmail.com>
3039 * anonymous.cs: Mutate anonymous method type.
3041 2008-07-11 Marek Safar <marek.safar@gmail.com>
3043 * ecore.cs, anonymous.cs: Mutate field expressions.
3045 2008-07-10 Marek Safar <marek.safar@gmail.com>
3047 A fix for bug #369670
3048 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3050 2008-07-10 Marek Safar <marek.safar@gmail.com>
3052 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3054 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3057 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3058 only one '>', and finds a '>>', abort the generic lookahead.
3060 2008-07-10 Marek Safar <marek.safar@gmail.com>
3062 A fix for bug #319902
3063 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3065 2008-07-10 Marek Safar <marek.safar@gmail.com>
3067 A fix for bug #406371
3068 * statement.cs: Moved EmitSymbolInfo to Block.
3070 2008-07-09 Marek Safar <marek.safar@gmail.com>
3072 * ecore.cs: Report better error for extension method overload failures.
3074 2008-07-09 Marek Safar <marek.safar@gmail.com>
3076 * expression.cs (Is): No need to box reference values.
3078 2008-07-09 Marek Safar <marek.safar@gmail.com>
3080 * class.cs: Use event resolve context when initializing CreateEmitContext.
3082 2008-07-09 Marek Safar <marek.safar@gmail.com>
3084 A fix for bug #394436
3085 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3086 method used inside expression trees. Added more LINQ to expression tree
3089 2008-07-08 Marek Safar <marek.safar@gmail.com>
3091 A fix for bug #378189, #370577
3092 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3095 2008-07-08 Marek Safar <marek.safar@gmail.com>
3097 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3100 2008-07-08 Marek Safar <marek.safar@gmail.com>
3102 A fix for bug #406702
3103 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3105 2008-07-07 Marek Safar <marek.safar@gmail.com>
3107 A fix for bug #406648
3108 * cs-parser.jay: Report nullable use in mcs for some cases.
3110 2008-07-07 Marek Safar <marek.safar@gmail.com>
3112 * ecore.cs: Improved argument mismatch error messages.
3114 2008-07-07 Marek Safar <marek.safar@gmail.com>
3116 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3118 2008-07-07 Marek Safar <marek.safar@gmail.com>
3120 * expression.cs (TypeOf): Mutate type argument.
3122 2008-07-04 Marek Safar <marek.safar@gmail.com>
3124 * class.cs: Report missing partial modifier for correct type.
3126 2008-07-04 Marek Safar <marek.safar@gmail.com>
3128 * ecore.cs, expression.cs (VariableReference): Variable property is
3131 2008-07-04 Marek Safar <marek.safar@gmail.com>
3133 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3135 2008-07-04 Marek Safar <marek.safar@gmail.com>
3137 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3140 2008-07-04 Marek Safar <marek.safar@gmail.com>
3142 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3143 anonymous method storey to an instance method when only "this" is hoisted.
3145 2008-07-03 Marek Safar <marek.safar@gmail.com>
3147 A fix for bug #321615
3148 * expression.cs: Pointer comparisons use unsigned operator.
3150 2008-07-03 Marek Safar <marek.safar@gmail.com>
3152 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3154 2008-07-02 Marek Safar <marek.safar@gmail.com>
3156 A fix for bug #404905
3157 * class.cs: Always initialize local unsafe variables.
3159 2008-06-30 Marek Safar <marek.safar@gmail.com>
3161 A fix for bug #396987
3162 * expression.cs (NewInitialize): Clear local temporary variable for next run
3164 2008-06-27 Marek Safar <marek.safar@gmail.com>
3166 A fix for bug #401020
3167 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3169 2008-06-27 Marek Safar <marek.safar@gmail.com>
3171 A fix for bug #398319
3172 * cs-parser.jay: Implemented undocumented base access expression inside
3175 2008-06-26 Marek Safar <marek.safar@gmail.com>
3177 A fix for bug #404227
3178 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3180 2008-06-26 Marek Safar <marek.safar@gmail.com>
3182 A fix for bug #404227
3183 * convert.cs: Fixed explicit array to interface cast.
3185 2008-06-26 Marek Safar <marek.safar@gmail.com>
3187 A fix for bug #403894
3188 * delegate.cs: Mutate DelegateInvocation type.
3190 2008-06-26 Marek Safar <marek.safar@gmail.com>
3192 A fix for bug #379348
3193 * delegate.cs: Box a load of generic parameters.
3195 2008-06-26 Marek Safar <marek.safar@gmail.com>
3197 * expression.cs: Add an array creation arguments mutate.
3199 2008-06-26 Marek Safar <marek.safar@gmail.com>
3201 A fix for bug #386068
3202 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3205 2008-06-25 Marek Safar <marek.safar@gmail.com>
3207 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3210 2008-06-25 Marek Safar <marek.safar@gmail.com>
3212 A fix for bug #403518
3213 * delegate.cs: Type correctly anonymous method new invocation.
3215 2008-06-24 Marek Safar <marek.safar@gmail.com>
3217 A fix for bug #394826
3218 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3221 2008-06-24 Marek Safar <marek.safar@gmail.com>
3223 A fix for bug #394826
3224 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3227 2008-06-24 Marek Safar <marek.safar@gmail.com>
3229 * class.cs: Clone indexer parameters for localized capturing.
3231 2008-06-24 Marek Safar <marek.safar@gmail.com>
3233 A fix for bug #402379
3234 * expression.cs: Don't crash when an object initializer resolve fails.
3236 2008-06-24 Marek Safar <marek.safar@gmail.com>
3238 A fix for bug #402888
3239 * expression.cs: Mutate conditional expression.
3241 2008-06-24 Marek Safar <marek.safar@gmail.com>
3243 A fix for bug #401012
3244 * class.cs: Keep StructLayout in shared container.
3246 2008-06-24 Marek Safar <marek.safar@gmail.com>
3248 A fix for bug #400438
3249 * decl.cs, class.cs: Only properties can be automatically implemented.
3251 2008-06-24 Marek Safar <marek.safar@gmail.com>
3253 * statement.cs (ChangeToIterator): Copy also labels.
3255 2008-06-23 Marek Safar <marek.safar@gmail.com>
3257 * ecore.cs: Pass type argument details to parent extension method.
3259 2008-06-23 Marek Safar <marek.safar@gmail.com>
3261 A fix for bug #375966
3262 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3264 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3266 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3268 2008-06-22 Marek Safar <marek.safar@gmail.com>
3270 A fix for bug #394347
3271 * anonymous.cs: Cache compatible delegates as compatibility check produces
3272 a new method every time.
3274 2008-06-20 Marek Safar <marek.safar@gmail.com>
3276 * anonymous.cs: Propagate storey reference for single references.
3278 2008-06-20 Marek Safar <marek.safar@gmail.com>
3280 A fix for bug #387615
3281 * assign.cs, expression.cs: Correctly clone compound assignment.
3283 2008-06-19 Marek Safar <marek.safar@gmail.com>
3285 A fix for bug #359611, #359604
3286 * anonymous.cs: Mutate all types of hoisted parameters.
3288 2008-06-19 Marek Safar <marek.safar@gmail.com>
3290 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3291 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3292 expression.cs, codegen.cs, statement.cs
3294 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3295 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3297 ** Anonymous methods, lambda expressions rewrite **
3299 Anonymous expressions are now resolved when an explicit block is resolved
3300 and they don't require any registration procedure anymore. Further,
3301 anonymous methods are defined when explicit block is emitted which allows
3302 better control of whole process and opens possibilities for more
3303 optimizations as well as alternative to reverse whole process.
3305 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3306 process consistent and to correctly emit hoisted generic methods when they
3307 have at least 1 hoisted variable.
3309 2008-06-17 Martin Baulig <martin@ximian.com>
3311 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3313 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3314 virtual property; check it in Emit().
3315 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3317 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3319 (Indexer.Define): Likewise.
3321 2008-06-17 Marek Safar <marek.safar@gmail.com>
3323 * convert.cs: Don't use IsInterface on type arguments.
3325 * delegate.cs: DelegateInvocation uses MethodInfo.
3327 * parameter.cs: Removed IsTypeParameter.
3329 * generic-mcs.cs: More missing stuff.
3331 2008-06-16 Martin Baulig <martin@ximian.com>
3334 (Modifiers.DEBUGGER_HIDDEN): New public const.
3337 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3340 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3341 (AbstractPropertyEventMethod): Likewise.
3342 (Constructor.Emit): Likewise.
3343 (SourceMethod.SetCompilerGenerated): Removed.
3345 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3349 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3350 if we're an `IteratorHost'.
3351 (AnonymousMethodMethod..ctor): Don't set
3352 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3355 2008-06-16 Marek Safar <marek.safar@gmail.com>
3357 * statement.cs: Clean-up foreach statements.
3359 2008-06-12 Marek Safar <marek.safar@gmail.com>
3361 * class.cs: Stop using public method which should not exist
3362 (MethodBuilder.SetGenericMethodSignature).
3364 2008-06-11 Martin Baulig <martin@ximian.com>
3367 (Location.LookupFile): Add `CompilationUnit' argument; when given
3368 a relative file name, make it relative to the directory the .cs
3369 file is located in instead of using the current directory.
3371 2008-06-11 Martin Baulig <martin@ximian.com>
3374 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3375 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3376 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3377 (SourceMethod.SetCompilerGenerated): Likewise.
3379 2008-06-11 Marek Safar <marek.safar@gmail.com>
3381 * codegen.cs, driver: Only write symbol file when it's asked for.
3383 2008-06-11 Marek Safar <marek.safar@gmail.com>
3385 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3387 2008-06-10 Martin Baulig <martin@ximian.com>
3389 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3391 2008-06-09 Marek Safar <marek.safar@gmail.com>
3393 A fix for bug #316290
3394 * expression.cs: Include decimal operators in predefined table.
3396 * parameters.cs: More readonlyness.
3398 2008-06-09 Marek Safar <marek.safar@gmail.com>
3400 A fix for bug #397213
3401 * cs-parser.jay: One more missing current_local_parameters reset.
3403 2008-06-09 Marek Safar <marek.safar@gmail.com>
3405 A fix for bug #396633
3406 * class.cs: Host backing field in partial container.
3408 2008-06-09 Marek Safar <marek.safar@gmail.com>
3410 A fix for bug #397068
3411 * expression.cs: Check both operand types when predefined operator is used.
3413 2008-06-05 Martin Baulig <martin@ximian.com>
3415 Merged the `debugger-kahalo' branch.
3418 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3419 we're an iterator method.
3420 (SourceMethod): Reflect latest symbol writer changes;
3421 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3422 now `start_row' and `end_row'.
3423 (Constructor.Emit): Fix the logic whether to emit symbol information.
3425 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3429 (CompilationUnit): New public class; derives from `SourceFile'.
3430 (SourceFileEntry.DefineSymbolInfo): New public method.
3431 (SourceFileEntry.SetChecksum): New public method.
3432 (Location): Encode hidden line numbers by using `column == 255';
3433 the .ctor now accepts `column == -1' to mark a hidden line number.
3434 (Location.Hidden): New public property.
3435 (Location.CheckPoint): Add `CompilationUnit'.
3436 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3437 (Location.Push): Add `CompilationUnit compile_unit' argument.
3438 (Location.CompilationUnit): New public property.
3441 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3443 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3445 * driver.cs: `SourceFile' -> `CompilationUnit'.
3447 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3449 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3451 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3455 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3456 new symbol writer API to also pass the file.
3458 2008-06-05 Marek Safar <marek.safar@gmail.com>
3460 * statement.cs: Emit catch variable assignment using variable expression.
3462 2008-06-05 Marek Safar <marek.safar@gmail.com>
3464 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3465 with other variable types.
3467 2008-06-04 Marek Safar <marek.safar@gmail.com>
3469 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3470 GetLength method emit, it breaks resolve rules.
3472 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3473 Marek Safar <marek.safar@gmail.com>
3475 A fix for bug #395542
3476 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3479 2008-06-02 Marek Safar <marek.safar@gmail.com>
3481 A fix for bug #395287
3482 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
3484 2008-05-31 Marek Safar <marek.safar@gmail.com>
3486 A fix for bug #395845
3487 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
3488 non-nullable parameter type.
3490 2008-05-31 Marek Safar <marek.safar@gmail.com>
3492 * class.cs: Handle contructor initializer as a statement in top-level block.
3494 2008-05-30 Marek Safar <marek.safar@gmail.com>
3496 * attribute.cs: Don't mix old and new corlib types when emitting corlib
3497 security attributes.
3499 2008-05-24 Marek Safar <marek.safar@gmail.com>
3501 * ecore.cs, expression.cs: Small IVariable refactoring.
3503 2008-05-22 Marek Safar <marek.safar@gmail.com>
3505 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
3507 2008-05-21 Marek Safar <marek.safar@gmail.com>
3509 * cs-parser.jay: Removed redundant catch type check.
3511 2008-05-21 Marek Safar <marek.safar@gmail.com>
3513 A fix for bug #390372
3514 * nullable.cs: Set correct return type.
3516 2008-05-21 Marek Safar <marek.safar@gmail.com>
3518 A fix for bug #391062
3519 * typemanager.cs: Fixed crash when comparing null types.
3521 2008-05-21 Marek Safar <marek.safar@gmail.com>
3523 A fix for bug #391871
3524 * cs-parser.jay: Better error handling for invalid catch type.
3526 2008-05-20 Marek Safar <marek.safar@gmail.com>
3528 A fix for bug #392155
3529 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
3531 2008-05-15 Marek Safar <marek.safar@gmail.com>
3533 A fix for bug #390666
3534 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
3537 2008-05-15 Marek Safar <marek.safar@gmail.com>
3539 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
3542 2008-05-13 Marek Safar <marek.safar@gmail.com>
3544 A fix for bug #389625
3545 * delegate.cs, generic.cs: Some progress on method group return type
3548 2008-05-13 Marek Safar <marek.safar@gmail.com>
3550 A fix for bug #378419
3551 * namespace.cs: Inspect also parent namespaces not only namespace entries.
3553 2008-05-12 Marek Safar <marek.safar@gmail.com>
3555 * class.cs (Constructor): Added IsCompilerGenerated.
3557 2008-05-12 Marek Safar <marek.safar@gmail.com>
3559 * expression.cs: Enum binary operators can accept non-enum operand only when
3560 is implicitly convertible to underlying type.
3562 2008-05-12 Marek Safar <marek.safar@gmail.com>
3564 A fix for bug #389272
3565 * support.cs: Workaround System.InvalidOperationException for enums.
3567 2008-05-12 Marek Safar <marek.safar@gmail.com>
3569 A fix for bug #389073
3570 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
3572 2008-05-10 Marek Safar <marek.safar@gmail.com>
3574 * driver.cs: Split Parse.
3576 * location.cs (LookupFile): Uses string.Empty.
3578 2008-05-07 Marek Safar <marek.safar@gmail.com>
3580 * expression.cs, parameter.cs: Small ParameterReference clean up.
3582 2008-05-07 Marek Safar <marek.safar@gmail.com>
3584 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
3585 hack. Fixes #387502.
3587 2008-05-06 Martin Baulig <martin@ximian.com>
3589 * class.cs (Constructor.Emit): Fix the logic whether to emit
3592 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
3595 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
3596 InvalidOperationException when the iterator is before the start or
3599 2008-05-06 Marek Safar <marek.safar@gmail.com>
3601 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
3602 when left is nullable type.
3604 2008-05-06 Marek Safar <marek.safar@gmail.com>
3606 A fix for bug #386628
3607 * expression.cs (LocalVariableReference): Continue in resolving when
3608 variable is not assigned.
3610 2008-05-05 Marek Safar <marek.safar@gmail.com>
3612 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
3613 nullable operations.
3615 2008-05-04 Marek Safar <marek.safar@gmail.com>
3617 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
3618 it saves many redundant temporary variables for nullable operations.
3620 2008-05-03 Marek Safar <marek.safar@gmail.com>
3622 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
3624 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
3627 * nullable.cs: Constant coalescing operator optimizations.
3629 2008-05-03 Marek Safar <marek.safar@gmail.com>
3631 * constant.cs: Use unsigned conversion for values which are unsigned only.
3633 2008-05-03 Marek Safar <marek.safar@gmail.com>
3635 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
3636 coalescing operator as it should be.
3638 2008-05-02 Marek Safar <marek.safar@gmail.com>
3640 A fix for bug #371016
3641 * expression.cs: All predefined delegate operators require implicit method
3644 2008-05-02 Marek Safar <marek.safar@gmail.com>
3646 * constant.cs: Emit long constant as uint when fits the range.
3648 * convert.cs, expression.cs: Fixed few unsafe conversions.
3650 2008-05-02 Marek Safar <marek.safar@gmail.com>
3652 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
3654 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
3657 * convert.cs (ImplicitNumericConversion): Don't modify the type of
3659 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
3661 2008-05-01 Marek Safar <marek.safar@gmail.com>
3663 * constant.cs, literal.cs: IsLiteral property for error reporting.
3665 * ecore.cs, expression.cs: Implemented Property expression.
3667 2008-05-01 Marek Safar <marek.safar@gmail.com>
3669 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
3671 * nullable.cs: Implemented nullable coalescing null operator.
3673 * ecore.cs, expression.cs: Expression trees work.
3675 2008-05-01 Marek Safar <marek.safar@gmail.com>
3677 * ecore.cs: CreateExpressionTree is finally abstract.
3679 * expression.cs, linq.cs: Updated.
3681 2008-05-01 Marek Safar <marek.safar@gmail.com>
3683 * expression.cs, ecore.cs: Block base access expression inside expression
3686 2008-05-01 Marek Safar <marek.safar@gmail.com>
3688 A fix for bug #385058
3689 * expression.cs: User-defined operator implementations always take
3690 precedence over predefined operator implementations.
3692 2008-04-30 Marek Safar <marek.safar@gmail.com>
3694 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
3695 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
3696 expression tree conversions.
3698 2008-04-30 Marek Safar <marek.safar@gmail.com>
3700 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
3701 operators method details to Operator class.
3703 2008-04-30 Marek Safar <marek.safar@gmail.com>
3705 * anonymous.cs: Pass unsafe flags to anonymous container.
3707 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
3708 inside expression tree.
3710 2008-04-29 Martin Baulig <martin@ximian.com>
3712 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
3713 (Tokenizer.PopPosition): Also restore the `line'.
3715 2008-04-29 Marek Safar <marek.safar@gmail.com>
3717 * delegate.cs: Implemented Invoke expression.
3719 2008-04-29 Marek Safar <marek.safar@gmail.com>
3721 * expression.cs: Fixed equality reference comparison regression.
3723 2008-04-29 Marek Safar <marek.safar@gmail.com>
3725 * ecore.cs: Clean up EmptyCast hack.
3727 * expression.cs, nullable.cs: Implemented enum binary and unary operations
3728 using correct conversion rules. Also fixes #383993.
3730 2008-04-28 Martin Baulig <martin@ximian.com>
3732 * class.cs (Constructor.Emit): Don't emit debugging information
3733 for generated default .ctor's.
3735 2008-04-28 Marek Safar <marek.safar@gmail.com>
3737 * convert.cs: Empty-cast ushort to int conversion.
3739 2008-04-28 Marek Safar <marek.safar@gmail.com>
3741 A fix for bug #384191
3742 * ecore.cs, expression.cs: Fixed expression cloning.
3744 2008-04-28 Marek Safar <marek.safar@gmail.com>
3746 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
3748 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
3750 Fix #381559, test-638.cs, test-639.cs
3751 * assign.cs (CompoundAssign.Helper): New wrapper.
3752 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
3754 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
3755 Pass unconverted expressions to the params array creation expression.
3756 (FieldExpr.EmitAssign): Don't special-case StringConcat.
3757 (PropertyExpr.EmitAssign): Likewise.
3758 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
3759 element if it is of kind CompoundAssign.Helper.
3760 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
3761 first before anything else.
3762 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
3763 (ArrayAccess.LoadArrayAndArguments): Simplify.
3765 2008-04-27 Marek Safar <marek.safar@gmail.com>
3767 * expression.cs: Fixed cloning of typeof(void).
3769 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
3771 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
3772 (Assign.Emit): Likewise. Move it to ...
3773 (CompoundAssign.DoResolve): ... here and ...
3774 (CompoundAssign.Emit): ... here.
3775 (EventAddOrRemove): New helper to handle += and -= on events, and
3776 avoid the use of BinaryDelegates.
3777 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
3778 (EventExpr.EmitAddOrRemove): Improve.
3779 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
3781 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
3782 create VarExprs for 'foo.bar.var'.
3783 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
3784 is a highly inappropriate name for its functionality.
3786 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3788 Simplify handling of multiple assignments
3789 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
3791 (SimpleAssign): New. Class to be used for normal assignments.
3792 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
3793 * expression.cs, parameter.cs, statement.cs: Likewise.
3795 2008-04-25 Marek Safar <marek.safar@gmail.com>
3797 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
3798 for incompatible underlying types, more to come, uff.
3800 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3803 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
3804 Handle 'leave_copy'.
3806 2008-04-25 Marek Safar <marek.safar@gmail.com>
3808 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
3810 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
3812 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
3813 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
3814 * statement.cs (While, Do, For): Allow test to have side effects.
3815 (For.DoEmit): Always emit InitStatement.
3818 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
3819 Always create SideEffectConstant.
3820 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
3821 of type EnumConstant.
3823 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
3824 Handle 'right' being SideEffectConstant of type 'bool'.
3826 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
3827 Use left.EmitBranchable instead of open coding it, so as to
3828 improve optimization opportunities.
3830 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
3832 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
3834 (Expression.EmitSideEffect): Document.
3836 2008-04-23 Marek Safar <marek.safar@gmail.com>
3838 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
3840 2008-04-23 Marek Safar <marek.safar@gmail.com>
3842 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
3844 2008-04-23 Marek Safar <marek.safar@gmail.com>
3846 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
3847 conversion to expression tree.
3849 2008-04-23 Marek Safar <marek.safar@gmail.com>
3851 * ecore.cs: Removed unused expression.
3853 2008-04-22 Marek Safar <marek.safar@gmail.com>
3855 * expression.cs: Implemented NegateChecked and New expressions.
3857 2008-04-22 Marek Safar <marek.safar@gmail.com>
3859 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
3861 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
3864 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
3865 needing final 'ret' instruction.
3867 2008-04-22 Marek Safar <marek.safar@gmail.com>
3869 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
3871 2008-04-21 Marek Safar <marek.safar@gmail.com>
3873 * expression.cs: Emit ldnull and not null expression as an instance argument
3874 of static method expression calls.
3876 2008-04-21 Marek Safar <marek.safar@gmail.com>
3878 A fix for bug #378200
3879 * expression.cs: Fixed crash when creating parameterless expression tree
3882 2008-04-21 Marek Safar <marek.safar@gmail.com>
3884 A fix for bug #375297
3885 * anonymous.cs: Fixed crash when inferring from null argument anonymous
3888 2008-04-21 Marek Safar <marek.safar@gmail.com>
3890 A fix for bug #377596
3891 * decl.cs, class.cs: Emit delegate type argument attributes.
3893 2008-04-21 Marek Safar <marek.safar@gmail.com>
3895 A fix for bug #365314
3896 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
3898 2008-04-21 Marek Safar <marek.safar@gmail.com>
3900 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
3903 2008-04-21 Marek Safar <marek.safar@gmail.com>
3905 * generic.cs (TypeParameter): Removed redundant location.
3907 2008-04-19 Marek Safar <marek.safar@gmail.com>
3909 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
3910 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
3911 FullNamedExpression in all declaration type expression, statements will come
3914 2008-04-18 Marek Safar <marek.safar@gmail.com>
3916 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
3917 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
3919 2008-04-18 Marek Safar <marek.safar@gmail.com>
3921 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
3924 2008-04-17 Marek Safar <marek.safar@gmail.com>
3926 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
3929 2008-04-17 Marek Safar <marek.safar@gmail.com>
3931 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
3935 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
3937 Hook up 'EmitSideEffect'
3938 * constant.cs (Constant.EmitSideEffect): New.
3939 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
3940 (SideEffectConstant.EmitSideEffect): New.
3941 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
3942 unconditional branch in EmitBranchable.
3943 (FieldExpr.EmitBranchable): New.
3944 * expression.cs (Unary.EmitSideEffect): New.
3945 (Binary.EmitSideEffect): New.
3946 (VariableReference.EmitSideEffect): New. Do nothing.
3948 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
3950 Introduce 'EmitSideEffect'
3951 * ecore.cs (Expression.EmitSideEffect): New.
3952 (TypeCast): Rename from EmptyCast.
3954 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
3955 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
3956 * convert.cs, nullable.cs: Update to changes.
3958 2008-04-16 Marek Safar <marek.safar@gmail.com>
3960 * class.cs, cs-parser.jay: Early check for base types expression.
3962 2008-04-16 Marek Safar <marek.safar@gmail.com>
3964 * decl.cs (MemberName): Declare PrettyName as obsolete.
3966 2008-04-16 Marek Safar <marek.safar@gmail.com>
3968 * namespace.cs: Use MemberName comparison.
3970 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
3973 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
3975 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
3976 (MemberName.FullyQualifiedName): New. Provides the functionality
3977 that users assume FullName would have.
3978 * ecore.cs, namespace.cs: Update to changes.
3980 * statement.cs (Using.assign): Make into ExpressionStatement.
3981 (Using.EmitPreTryBody): Simplify.
3983 2008-04-16 Marek Safar <marek.safar@gmail.com>
3985 * report.cs: ColorFormat is protected.
3987 * rootcontext.cs: Unused fields clean-up.
3989 * namespace.cs: Made UsingEntry name private.
3991 2008-04-16 Marek Safar <marek.safar@gmail.com>
3993 * cs-tokenizer.cs, location.cs: Removed unused field.
3995 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
3996 Raja R Harinath <harinath@hurrynot.org>
3999 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4000 (SideEffectConstant.side_effect): Rename from 'right'.
4001 (SideEffectConstant..ctor): Normalize 'side_effect'.
4002 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4003 value of this constant.
4004 * cfold.cs: Update to changes.
4006 2008-04-15 Marek Safar <marek.safar@gmail.com>
4008 * cs-paser.jay: Removed unused variable.
4010 * driver.cs: Made Compile instance method.
4012 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4014 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4016 2008-04-15 Marek Safar <marek.safar@gmail.com>
4018 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4020 2008-04-13 Jb Evain <jbevain@novell.com>
4022 * namespace.cs: update the System.Core fullname for 2.1
4023 * driver.cs: update the list of required assemblies for 2.1.
4024 Merged from the Moonlight 2 branch.
4026 2008-04-11 Marek Safar <marek.safar@gmail.com>
4028 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4029 types and user defined operators. User operators arguments has to be checked
4030 for null value before invocation, which also means no operator is called
4031 when any argument is not convertible to unwrapped nullable type.
4033 2008-04-09 Marek Safar <marek.safar@gmail.com>
4035 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4036 of Unary expressions to follow operator overloading rules precisely.
4037 Also fixes #321794, #323794
4039 2008-04-08 Marek Safar <marek.safar@gmail.com>
4041 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4044 2008-04-08 Marek Safar <marek.safar@gmail.com>
4046 * expression.cs, ecore.cs: Implemented MemberInit expression.
4048 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4050 Fix mono/tests/exception4.cs
4051 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4052 ec.NeedReturnLabel () rather emitting a 'nop'.
4054 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4056 (TryCatch.SomeCodeFollows): Likewise.
4057 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4058 for 'break', 'continue' and 'return' statements inside a try.
4059 We're fairly sure that the generated IL stream will have more
4060 instructions textually following the try.
4061 (FlowBranchingTryCatch): Likewise.
4063 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4064 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4067 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4068 wrapper -- forward everything to CollectionForeach.
4069 (CollectionForeach.NonDisposableWrapper): New.
4070 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4071 instead of a pop + branch to end.
4073 2008-04-07 Marek Safar <marek.safar@gmail.com>
4075 A fix for bug #377485
4076 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4077 Propagate location for extension method groups. Report conversion failure at
4080 2008-04-07 Marek Safar <marek.safar@gmail.com>
4082 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4083 ListInit and Field expressions.
4085 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4087 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4088 Since $PC is always -1 inside the body of MoveNext, the fault
4090 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4091 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4092 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4094 The denouement! Fix #324708
4095 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4096 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4097 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4098 'finally' inside the finally clause.
4100 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4101 inside an iterator. Don't emit the body of the 'finally' inside
4102 the finally clause yet.
4104 Use the ResumableStatement infrastructure for MoveNext ()
4105 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4106 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4107 'old_resume_points'. Move dispatcher upfront.
4108 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4109 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4110 in an enumerator. This encodes the main fix in this patch series
4111 -- we can only jump into the first instruction of a try from the
4112 outside, but we want to emit try/finally regions in iterators and
4113 resume in the middle of them.
4115 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4117 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4118 of NeedReturnLabel here.
4120 Introduce a common point for emitting try/finally to IL
4121 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4122 features of the various subclasses, which are now driven by ...
4123 (ExceptionStatement.EmitPreTryBody): ... this and ...
4124 (ExceptionStatement.EmitTryBody): ... this and the original
4126 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4127 Remove DoEmit and update to follow above protocol.
4129 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4130 of the dispatcher are the same, skip emitting the 'switch'.
4131 * iterator.cs (Iterator.EmitDispose): Update to changes.
4133 Clean up handling of 'using' statement
4134 * statement.cs (UsingTemporary): New. Carved out of ...
4135 (Using): ... this. Simplify drastically. Handle exactly
4137 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4138 or Using as appropriate. If there are multiple variable declared,
4139 create nested Using statements.
4140 (resource_acquisition): Kill.
4142 * statement.cs (ExceptionStatement.EmitForDispose): Use
4143 EmitFinallyBody, not EmitFinally.
4145 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4146 * iterator.cs: Update to changes.
4148 Start using the ResumableStatement infrastructure
4149 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4150 (ResumableStatement.EmitForDispose): New.
4151 (ExceptionStatement): Override them.
4152 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4153 EmitForDispose to create the body of the Dispose method. Don't
4156 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4157 * statement.cs (Toplevel.AddResumePoint): ... here.
4158 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4159 * flowanalysis.cs (FlowBranchingIterator): New.
4160 * codegen.cs (EmitContext): Update to changes.
4162 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4163 (Iterator.old_resume_points): Rename from 'resume_points'.
4164 (Iterator.MoveNextStatement): Remove unused class.
4166 New infrastructure for try/finally in iterators (still unused)
4167 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4168 (FlowBranchingToplevel.AddResumePoint): Hook into
4169 ToplevelBlock.AddResumePoint.
4170 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4171 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4172 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4173 resume points and assign program-counter values.
4174 (ExceptionBlock.AddResumePoint): Collect resume points for
4175 de-muxer at the top of try block.
4176 * iterators.cs (Yield.CheckContext): Simplify.
4177 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4179 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4181 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4182 argument to an ExitStatement.
4183 (FlowBranchingException): Refactor saved origins code.
4184 * statement.cs (ExitStatement): Update to cahges.
4185 * iterator.cs (YieldBreak): Likewise.
4187 * statement.cs (ResumableStatement): New. Common base class for
4188 YieldReturn and ExceptionStatement.
4189 (ExitStatement): New. Common base class for Return and YieldBreak.
4190 (Return): Update to changes.
4191 * iterator.cs (YieldBreak): Likewise.
4192 * lambda.cs (ContextualReturn): Likewise.
4195 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4196 emit a meaningful error message.
4198 Fix #324765, #319508
4199 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4200 (VariableInfo.SetAssigned): Set it.
4201 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4202 determine if CS0219 or CS0168 is appropriate. Don't use
4203 flow-analysis information.
4204 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4205 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4206 (EmitContext.EndFlowBranching): ... this.
4208 2008-04-03 Marek Safar <marek.safar@gmail.com>
4210 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4212 2008-04-03 Marek Safar <marek.safar@gmail.com>
4214 A fix for bug #376508
4215 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4216 ImplicitConversionExists.
4218 2008-04-03 Marek Safar <marek.safar@gmail.com>
4220 * expression.cs (Binary): Added remaining binary operators to expression
4223 * nullable.cs: Optimize shift with null argument.
4225 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4227 Fix minor IL regression
4228 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4229 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4230 * cs-parser.jay (try_statement): Update to changes.
4232 * statement.cs (TryFinally.need_exc_block): Delete.
4233 (TryFinally): Update to changes.
4235 Now all ExceptionStatements are unconditional
4236 * statement.cs (CollectionForeach.DisposableWrapper): New.
4237 Extract out the try/finally code into a new wrapper.
4238 (CollectionForeach.Resolve): Use it to simplify the code.
4240 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4242 Start at simplifying ExceptionStatement semantics a bit
4243 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4244 * cs-parser.jay (try_statement): Update to changes.
4245 (opt_catch_clauses): Remove.
4246 * flowanalysis.cs: Update to changes.
4247 (FlowBranching.BranchingType.TryCatch): New.
4248 (FlowBranchingTryCatch): New.
4250 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4251 (FlowBranching.CreateBranching): Update to changes.
4252 (FlowBranchingBlock.AddSibling): Add sanity check.
4253 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4256 * iterators.cs (Iterator.MarkFinally): Remove.
4257 * statement.cs (ExceptionStatement): Update to changes.
4259 Add support for skipping over finally blocks at runtime. First
4260 in a series to fix #324708
4261 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4262 (Iterator.EmitMoveNext): Initialize it.
4263 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4264 branch over the body of the 'finally' clause.
4266 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4268 Avoid lopsided use of Foo/DoFoo names
4269 * statement.cs (ExpressionStatement.EmitFinallyBody):
4270 Rename from EmitFinally.
4271 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4272 * iterator.cs: Update to changes.
4274 2008-04-02 Marek Safar <marek.safar@gmail.com>
4276 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4277 based on UserOperatorCall. More binary nullable operators clean up.
4279 2008-04-02 Martin Baulig <martin@ximian.com>
4281 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4283 2008-04-02 Marek Safar <marek.safar@gmail.com>
4285 * nullable.cs: Merge user and empty conversions when lifting expression
4288 * expression.cs (StringConcat): Implemented expression tree representation.
4290 2008-04-01 Marek Safar <marek.safar@gmail.com>
4292 * nullable.cs: When lifting null literal and a user operator exists, no call
4295 2008-04-01 Marek Safar <marek.safar@gmail.com>
4297 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4300 2008-04-01 Marek Safar <marek.safar@gmail.com>
4302 * nullable.cs, expression.cs: Use namespace instead heavily nested
4303 monster abstract class.
4305 2008-04-01 Marek Safar <marek.safar@gmail.com>
4307 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4308 lifting of null literal and user operators. Clean up of some temporary
4311 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4313 Fix #368224, test-629.cs
4314 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4315 if it crossed an unwind-protect boundary.
4316 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4317 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4318 inside an unwind-protected region.
4319 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4320 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4321 'leave' instead of a 'br' if unwind-protected.
4322 (Iterator.EmitYieldBreak): Likewise.
4324 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4326 * driver.cs: Only define versioninfo resources if no win32 resource
4329 2008-03-28 Marek Safar <marek.safar@gmail.com>
4331 A fix for bug #372375
4332 * convert.cs: Fixed boxing of nullable types.
4334 2008-03-28 Marek Safar <marek.safar@gmail.com>
4336 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4339 2008-03-28 Marek Safar <marek.safar@gmail.com>
4341 A fix for bug #374619
4342 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4344 2008-03-27 Marek Safar <marek.safar@gmail.com>
4346 * lambda.cs: Check return type only for invocation.
4348 2008-03-27 Marek Safar <marek.safar@gmail.com>
4350 A fix for bug #374214
4351 * ecore.cs: Correctly report argument type mismatch.
4353 2008-03-27 Marek Safar <marek.safar@gmail.com>
4355 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4356 and not rely on broken IsEnum.
4358 2008-03-27 Marek Safar <marek.safar@gmail.com>
4360 * nullable.cs: New file, extracted from generic.cs.
4362 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4364 2008-03-27 Marek Safar <marek.safar@gmail.com>
4366 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4367 predefined comparison operators and null literals.
4369 * report.cs: New warning ID.
4371 2008-03-25 Marek Safar <marek.safar@gmail.com>
4373 A fix for bug #370577
4374 * lambda.cs: Check return type too.
4376 2008-03-25 Marek Safar <marek.safar@gmail.com>
4378 A fix for bug #372846
4379 * class.cs: Automatic properties can be declared as unsafe.
4381 2008-03-20 Marek Safar <marek.safar@gmail.com>
4383 * location.cs: Use string based concatenation.
4385 * expression.cs: LiftedBinaryOperator is gmcs only.
4387 2008-03-20 Marek Safar <marek.safar@gmail.com>
4389 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4390 conversions rules and expression trees.
4392 2008-03-19 Marek Safar <marek.safar@gmail.com>
4394 * delegate.cs: Use extension method source as delegate target.
4396 2008-03-19 Marek Safar <marek.safar@gmail.com>
4398 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4399 binary operations to be purely based on binary operations and optimized
4400 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4401 and other ET refactoring.
4403 * typemanager.cs: Fixed warning.
4405 2008-03-17 Marek Safar <marek.safar@gmail.com>
4407 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4409 * symbolwriter.cs: Fixed.
4411 2008-03-17 Marek Safar <marek.safar@gmail.com>
4413 * anonymous.cs, driver.cs: Reset anonymous types counters.
4415 2008-03-17 Marek Safar <marek.safar@gmail.com>
4417 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4419 * class.cs: Use fullname for all type member definitions.
4421 2008-02-19 Martin Baulig <martin@ximian.com>
4424 (IMethodData.EmitExtraSymbolInfo): New interface method.
4425 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4426 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4427 interface method here as an empty public virtual method.
4430 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4431 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4432 CodeGen.SymbolWriter.SetRealMethodName().
4434 2008-02-18 Martin Baulig <martin@ximian.com>
4437 (ScopeInfo.EmitType): Override this and emit debugging
4438 information for captured variables.
4439 (RootScopeInfo.EmitType): Override this and emit symbol
4440 information for a captured `this'.
4442 2008-02-15 Martin Baulig <martin@ximian.com>
4444 * iterators.cs: Emit debugging info.
4447 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4448 (EmitContext.OmitDebuggingInfo): New public property.
4451 (While): Override Emit() and don't emit symbol info there; do it
4452 inside DoEmit() instead.
4453 (Block.Emit): Omit symbol information while emitting the scope
4454 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4456 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4457 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4458 .ctor to make `IsIterator' work.
4460 2008-03-14 Martin Baulig <martin@ximian.com>
4462 * symbolwriter.cs: Added the new symbol writer function from the
4463 debugger's `terrania' branch; temporarily enclose them inside
4464 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4467 2008-03-14 Martin Baulig <martin@ximian.com>
4470 (SymbolWriter): Make this a public static class.
4473 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4474 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4476 2008-03-14 Marek Safar <marek.safar@gmail.com>
4478 A fix for bug #370577
4479 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4482 2008-03-14 Marek Safar <marek.safar@gmail.com>
4484 * typemanager.cs (CSharpName): Made 250 times faster.
4486 2008-03-13 Marek Safar <marek.safar@gmail.com>
4488 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
4490 2008-03-12 Marek Safar <marek.safar@gmail.com>
4492 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
4493 crash when predefined field does not exist.
4495 2008-03-12 Marek Safar <marek.safar@gmail.com>
4497 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
4499 2008-03-12 Marek Safar <marek.safar@gmail.com>
4501 * class.cs (FixedField): Don't crash when contructors are missing.
4503 2008-03-11 Marek Safar <marek.safar@gmail.com>
4505 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
4506 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
4507 check internal types accessibility for internal and external types.
4508 Replaced EnumToUnderlying by GetEnumUnderlyingType.
4510 2008-03-11 Marek Safar <marek.safar@gmail.com>
4512 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
4513 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
4514 attribute.cs, statement: Use corect instance of predefined types (work
4515 related to #364674).
4517 2008-03-07 Marek Safar <marek.safar@gmail.com>
4519 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
4521 2008-03-07 Marek Safar <marek.safar@gmail.com>
4523 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
4524 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
4525 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
4526 predefined types clean up, delayed predefined types members initialization
4527 (work related to #364674).
4529 2008-03-05 Marek Safar <marek.safar@gmail.com>
4531 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
4533 2008-03-05 Marek Safar <marek.safar@gmail.com>
4535 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
4536 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
4537 predefined types clean up (work related to #364674).
4539 2008-03-04 Marek Safar <marek.safar@gmail.com>
4541 * ecore.cs: Print an error message instead of throwing exception.
4543 2008-03-04 Marek Safar <marek.safar@gmail.com>
4545 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
4546 expression.cs, statement.cs: Unififed null literal representation.
4548 2008-03-03 Marek Safar <marek.safar@gmail.com>
4550 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
4551 expression.cs: Refactored binary operators resolve phase and improved speed.
4552 The nullable code is still missing and won't work correctly, more fixes
4555 It also fixes #323726, #324312, #324248, and many other unreported issues.
4557 2008-02-29 Zoltan Varga <vargaz@gmail.com>
4559 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
4562 2008-02-27 Marek Safar <marek.safar@gmail.com>
4564 * ecore.cs: Clean-up and split BetterConversion.
4566 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
4569 * enum.cs (EnumMember.Value): Only access 'value' if
4570 ResolveValue says it's ok.
4571 (EnumMember.DoResolveValue): Don't set prev_member.value.
4572 (Enum.GetDefinition): Reverse arguments of Equals --
4573 EnumMember.Value can return 'null'.
4575 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
4577 2008-02-22 Marek Safar <marek.safar@gmail.com>
4579 * generic.cs, expression.cs: More ongoing work on expression trees.
4581 2008-02-21 Marek Safar <marek.safar@gmail.com>
4583 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
4584 handle missing matches when mutiple operators exist.
4586 2008-02-20 Marek Safar <marek.safar@gmail.com>
4588 A fix for bug #363218
4589 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
4592 2008-02-20 Marek Safar <marek.safar@gmail.com>
4594 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
4595 update. This time to deal correctly with SideEffectConstant expression used
4596 as an argument for another constant folding.
4598 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
4600 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
4603 2008-02-19 Marek Safar <marek.safar@gmail.com>
4605 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
4607 2008-02-19 Marek Safar <marek.safar@gmail.com>
4609 A fix for bug #328136
4610 * expression.cs: Do not fold immediately LogicalAnd operators when the left
4611 side is a false constant, because we still need to evaluate the right-hand
4614 * statement.cs (If): Emit two types of boolean constants (simple constant,
4615 side-effect constant).
4617 2008-02-19 Marek Safar <marek.safar@gmail.com>
4619 * constant.cs (SideEffectConstant): Don't emit boolean constant.
4621 * expression.cs: Fold immediately LogicalAnd operators when both sides are
4624 2008-02-18 Marek Safar <marek.safar@gmail.com>
4626 A fix for bug #361457
4627 * ecore.cs (IsApplicable): Params methods have lower priority.
4629 * support.cs: Return correct parameter modifier for params types.
4631 2008-02-18 Marek Safar <marek.safar@gmail.com>
4633 * generic.cs (TypeParameter): Cache attribute target name.
4635 * support.cs: Removed unused variable.
4637 * typemanager.cs: Removed debugging leftover.
4639 * ecore.cs: Use local type instead of a property;
4641 * class.cs (VerifyMembers): Consider also parent to test whether type member
4644 * expression.cs (FullMethodDesc): Removed.
4646 * attribute.cs (IsValidArgumentType): Made static.
4648 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
4650 Cleanup to be more readable.
4651 * Makefile (GMCS_PROFILE): Remove.
4652 (COMPILER_NAME): New helper.
4654 2008-02-15 Miguel de Icaza <miguel@novell.com>
4656 * cs-tokenizer.cs: if a conditional expression happens inside a
4657 (...) this also means that we do not need to de-ambiguate between
4658 an parenthesized expression and a cast.
4662 * constant.cs (SideEffectConstant): a constant value that happens
4663 to have a side effect.
4665 Fixes the build regressions introduced by the fix for #359789
4667 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
4669 * expression.cs (Conditional.Emit): when emitting the ternary
4670 operator, use local variables to generate code verifiable code.
4672 The verifier cannot infer that the type on stack before the
4673 stloc.0 is executed is of type ParentB. This happens because the
4674 stack merge algorithm uses only parent types when deciding which
4675 is the common type. This is described in Part III 1.8.1.3 of ECMA
4678 This code compiled with mcs is not verifiable under MS. The MS
4679 verifier picks the first common interface of Foo and Bar, which is
4680 wrong, but doesn't use a full join type of the 2 interfaces.
4682 CSC uses a clever hack to compile such code in a verifiable
4683 way. It stores the intermediate values in a local variable with
4688 2008-02-14 Miguel de Icaza <miguel@novell.com>
4690 * expression.cs: Do not fold BitwiseAnd operators when the left
4691 side is a false constant, because we still need to evaluate the
4696 * support.cs: Instead of throwing an InternalErrorException when
4697 the position of the stream is outside the boundary of our buffer,
4698 reset the state of the reader, and restart the reading from the
4699 beginning of the file.
4701 2008-02-14 Marek Safar <marek.safar@gmail.com>
4703 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
4705 2008-02-14 Marek Safar <marek.safar@gmail.com>
4707 A fix for bug #361686
4708 * decl.cs: A protected types used inside a private class which parents
4709 derives from the protected class are accessible.
4711 2008-02-13 Marek Safar <marek.safar@gmail.com>
4713 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
4714 the parameterless constructor.
4716 2008-02-13 Marek Safar <marek.safar@gmail.com>
4718 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
4719 lookup methods to use standard member cache when doing member lookup.
4721 2008-02-12 Marek Safar <marek.safar@gmail.com>
4723 * driver.cs: Don't report full path for referenced module as assembly error.
4725 2008-02-12 Marek Safar <marek.safar@gmail.com>
4727 * Makefile: Fixed `qh' target to work on all machines.
4729 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
4730 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
4731 and HasElementType with TypeManager implementation.
4733 2008-02-08 Marek Safar <marek.safar@gmail.com>
4735 A fix for bugs #325134, #359749
4736 * expression.cs, ecore.cs: Try to resolve an extension method even if the
4737 first binds point to non-method member expression.
4739 2008-02-08 Marek Safar <marek.safar@gmail.com>
4741 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
4743 2008-02-08 Marek Safar <marek.safar@gmail.com>
4745 A fix for bugs #321394, #323028
4746 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
4747 Reworked naive IsAccessibleAs implementation to handle nested types.
4749 2008-02-05 Jb Evain <jbevain@novell.com>
4751 * class.cs: use generic type comparison for parameters
4754 2008-02-05 Marek Safar <marek.safar@gmail.com>
4756 A fix for bug #325372
4757 * class.cs: Use generic type comparison when testing method signatures.
4759 2008-02-05 Marek Safar <marek.safar@gmail.com>
4761 A fix for bug #357047
4762 * ecore.cs: Applied C# 3.0 changes to better conversion.
4764 2008-02-05 Marek Safar <marek.safar@gmail.com>
4766 A fix for bug #358374
4767 * cs-parser.jay: Correctly set modifiers for all constructor types.
4769 2008-02-04 Marek Safar <marek.safar@gmail.com>
4771 A fix for bug #355251
4772 * generic.cs: Added base class constraint based type inference.
4774 2008-02-01 Marek Safar <marek.safar@gmail.com>
4776 A fix for bug #357255
4777 * decl.cs: One more missing visibility check.
4779 2008-02-01 Marek Safar <marek.safar@gmail.com>
4781 * support.cs: Fixed broken return.
4783 2008-01-25 Marek Safar <marek.safar@gmail.com>
4785 * report.cs: Correctly reset warnings count after probing.
4787 2008-01-25 Martin Baulig <martin@ximian.com>
4790 (NamespaceEntry.SymbolFileID): Make this work again after
4791 MemberName.ToString() is gone.
4793 2008-01-25 Marek Safar <marek.safar@gmail.com>
4795 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
4798 2008-01-25 Marek Safar <marek.safar@gmail.com>
4800 * generic.cs: Use full implicit conversion for type inference fixing.
4802 2008-01-24 Marek Safar <marek.safar@gmail.com>
4804 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
4805 Fixed user operator conversions.
4807 2008-01-24 Marek Safar <marek.safar@gmail.com>
4809 * generic.cs: Do nullable type to null comparison optimization during
4812 2008-01-24 Marek Safar <marek.safar@gmail.com>
4814 A fix for bug #355163
4815 * generic.cs: Enabled l-value resolve on nullable expressions.
4817 2008-01-24 Marek Safar <marek.safar@gmail.com>
4819 A fix for bug #353986
4820 * class.cs: Ingore static ctors with parameters for any further checks.
4822 2008-01-24 Marek Safar <marek.safar@gmail.com>
4824 A fix for bug #354310
4825 * namespace.cs: Removed redundant check.
4827 2008-01-24 Marek Safar <marek.safar@gmail.com>
4829 A fix for bug #354928
4830 * expression.cs: ElementInitializers can be resolved only once.
4832 2008-01-24 Marek Safar <marek.safar@gmail.com>
4834 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
4835 Condition expressions.
4837 2008-01-23 Marek Safar <marek.safar@gmail.com>
4839 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
4841 2008-01-22 Marek Safar <marek.safar@gmail.com>
4843 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
4846 * generic.cs: Implemented coalesce expression.
4848 2008-01-22 Marek Safar <marek.safar@gmail.com>
4850 A fix for bug #355145
4851 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
4852 expression tree type inference.
4854 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
4857 * expression.cs (Binary.IsUnsignedType): Fix typo.
4859 2008-01-22 Marek Safar <marek.safar@gmail.com>
4861 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
4863 2008-01-22 Marek Safar <marek.safar@gmail.com>
4865 A fix for bug #355161
4866 * ecore.cs, expression.cs: Wider range of extension method supported
4869 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
4871 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
4872 AssemblyBuilder to operate in compiler context. Fixes mcs part of
4875 2008-01-22 Marek Safar <marek.safar@gmail.com>
4877 A fix for bug #355148
4878 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
4880 2008-01-22 Miguel de Icaza <miguel@novell.com>
4882 * expression.cs (CreateExpressionTree): Add support for or and
4883 logical or, and indent following the coding conventions.
4885 * typemanager.cs (LinqExpression): renamed from
4886 ExpressionTreeManager, for a shorter name.
4888 Use TypeManager.CoreLookupType to lookup types from our core
4889 assemblies and turn those into "Type" variables.
4891 Consumers that previously used "Namespace" and "Type" from this
4892 class should instead use the TypeExpression which is a type that
4893 is fully resolved (without involving the regular C# resolution
4896 This typically looks like this:
4898 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
4899 new MemberAccess (texpr, name, type_arguments, loc)
4901 This avoids the problem in: #355178
4903 2008-01-21 Marek Safar <marek.safar@gmail.com>
4905 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
4906 feature in parser only as we do in other cases.
4908 2008-01-21 Marek Safar <marek.safar@gmail.com>
4910 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
4911 typemanager.cs: A refactoring of params arguments to reuse existing
4912 expressions (params -> array initializer) to emit params argument instead
4913 of specialized handling.
4914 It was required by expression tree implementation and it has other benefits
4915 as well, we now apply same optimization for params arguments as we do for
4918 2008-01-18 Marek Safar <marek.safar@gmail.com>
4920 A fix for bug #353526
4921 * generic.cs: A type inference of params arguments may not required any
4922 temporary array creation.
4924 2008-01-18 Marek Safar <marek.safar@gmail.com>
4926 A fix for bug #353534
4927 * generic.cs, ecore.cs, expression.cs: A method group type inference is
4928 supported for delegates only.
4930 2008-01-18 Marek Safar <marek.safar@gmail.com>
4932 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
4933 type for more than 1 candidates.
4935 2008-01-18 Marek Safar <marek.safar@gmail.com>
4937 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
4940 2008-01-16 Marek Safar <marek.safar@gmail.com>
4942 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
4943 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
4944 operator) expressions.
4946 2008-01-16 Zoltan Varga <vargaz@gmail.com>
4948 * statement.cs: Avoid declaring an IL variable for this_variable since it is
4949 not accessed from the generated IL.
4951 2008-01-14 Marek Safar <marek.safar@gmail.com>
4953 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
4954 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
4955 statement.cs: The first expression tree implementation drop, mostly
4956 infrastructure work.
4958 2008-01-14 Marek Safar <marek.safar@gmail.com>
4960 * ecore.cs (IsNestedChild): Refactored.
4962 2008-01-11 Marek Safar <marek.safar@gmail.com>
4964 * lambda.cs: Don't use a cast on unknown expression statement.
4966 2008-01-10 Geoff Norton <gnorton@novell.com>
4968 * cs-tokenizer.cs: One more token to distinguish between method and lambda
4971 2008-01-09 Marek Safar <marek.safar@gmail.com>
4973 * doc.cs: Report better /doc crash details.
4975 2008-01-09 Marek Safar <marek.safar@gmail.com>
4977 A fix for bug #352536
4978 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
4980 2008-01-08 Marek Safar <marek.safar@gmail.com>
4982 A fix for bug #352287
4983 * ecore.cs, expression.cs: Do `this' access checking in all member access
4986 2008-01-08 Marek Safar <marek.safar@gmail.com>
4988 * rootcontext.cs, driver.cs: Switch to linq mode by default.
4990 * report.cs: Reset message stacks.
4992 2008-01-08 Marek Safar <marek.safar@gmail.com>
4994 * generic.cs (InferInPhases): Correctly calculate params position.
4996 2008-01-08 Marek Safar <marek.safar@gmail.com>
4998 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5001 2008-01-07 Marek Safar <marek.safar@gmail.com>
5003 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5005 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5007 * driver.cs: Updated --help option.
5009 2008-01-07 Marek Safar <marek.safar@gmail.com>
5011 * generic.cs (InferParamsTypeArguments): Removed.
5012 (InferInPhases): Add params type inference.
5013 (LowerBoundInference): Fixed scoring mechanism.
5015 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5017 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5019 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5020 byte array for unsigned "baked" assemblies.
5022 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5024 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5025 array for assemblies that are not strongnamed.
5027 2008-01-04 Marek Safar <marek.safar@gmail.com>
5029 A fix for bug #351481
5030 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5031 declaring type for nested generic types.
5033 2008-01-04 Marek Safar <marek.safar@gmail.com>
5035 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5036 instead of ToString.
5038 2008-01-03 Marek Safar <marek.safar@gmail.com>
5040 A fix for bug #351047
5041 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5042 null and structs only when equality and inequality operators are defined
5043 either as an user-operators or predefined operators.
5045 2008-01-03 Marek Safar <marek.safar@gmail.com>
5047 A fix for bug #351047
5048 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5050 2008-01-03 Marek Safar <marek.safar@gmail.com>
5052 A fix for bug #351257
5053 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5055 2008-01-03 Marek Safar <marek.safar@gmail.com>
5057 A fix for bug #351157
5058 * class.cs (Using): Fixed yet another broken cloning.
5060 (Block): Put back more sensible default value for statements.
5062 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5064 * codegen.cs: Allow AssemblyVersion with only major version component.
5067 2007-12-29 Marek Safar <marek.safar@gmail.com>
5069 A fix for bug #324654
5070 * class.cs: Use FullName property as member name.
5072 2007-12-28 Marek Safar <marek.safar@gmail.com>
5074 A fix for bug #342117
5075 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5076 constructor constraint.
5078 2007-12-28 Marek Safar <marek.safar@gmail.com>
5080 A fix for bug #338273
5081 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5084 2007-12-28 Marek Safar <marek.safar@gmail.com>
5086 A fix for bug #350839
5087 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5089 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5091 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5094 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5096 * statement.cs: Changed some Hashtables to use HybridDictionaries
5097 instead. It was observed that some HashTables only contained a few
5098 items in the vast majority of cases. Since HybridDictionary is
5099 more efficient on small sets (<10 elements), "known_variables"
5100 from class ExplicitBlock as well as "labels" and "constants " from
5101 class Block were changed to HybridDictionaries.
5103 Atsai results: (56216kb->54987kb)
5105 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5108 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5110 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5113 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5115 * expression.cs: foreach loop to for loop, saved on allocation of
5116 enumerator (59333kb->59141kb)
5118 * statement.cs. Changed foreach loops to for loops, saved on
5119 allocation of enumerator (59141kb->59006kb)
5121 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5122 when constructed with no specified capacity. This was causing a
5123 few ArrayLists to allocate more memory than they would potentially
5124 need in the Block class and MemberCache class. Setting the
5125 ArrayLists to construct with a capacity of 1 saves some
5126 memory. (56216kb->55585kb)
5128 2007-12-27 Marek Safar <marek.safar@gmail.com>
5130 A fix for bug #347189 (2nd issue)
5131 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5134 2007-12-27 Miguel de Icaza <miguel@novell.com>
5136 * report.cs: Do not use colors if stdout and stderr are not a
5139 2007-12-27 Marek Safar <marek.safar@gmail.com>
5141 A fix for bug #346998
5142 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5145 2007-12-27 Marek Safar <marek.safar@gmail.com>
5147 A fix for bug #343465
5148 * class.cs: Explicit method name for nested types uses dots only.
5150 2007-12-27 Marek Safar <marek.safar@gmail.com>
5152 A fix for bug #343707
5153 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5155 2007-12-27 Marek Safar <marek.safar@gmail.com>
5157 * ecore.cs: Report type inference errors only when arguments count matches
5160 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5162 * expression.cs, report.cs: New warning.
5164 * typemanager.cs: Catch anonymous method type too.
5166 2007-12-23 Marek Safar <marek.safar@gmail.com>
5168 A fix for bug #346379
5169 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5171 2007-12-23 Marek Safar <marek.safar@gmail.com>
5173 A fix for bug #347359
5174 * expression.cs (Invocation): Don't resolve already resolved expression.
5176 2007-12-23 Marek Safar <marek.safar@gmail.com>
5178 A fix for bug #347189
5179 * class.cs (FixedField): Use non-dependent code only in the define phase.
5181 2007-12-23 Marek Safar <marek.safar@gmail.com>
5183 A fix for bug #348076
5184 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5186 2007-12-22 Marek Safar <marek.safar@gmail.com>
5188 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5189 discovered extension methods.
5191 2007-12-22 Marek Safar <marek.safar@gmail.com>
5193 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5196 2007-12-21 Miguel de Icaza <miguel@novell.com>
5198 * report.cs (ErrorMessage): Add support for using colors on
5199 terminals that support it.
5201 2007-12-21 Marek Safar <marek.safar@gmail.com>
5203 * ecore.cs: Use information about expanded params for error reporting.
5205 2007-12-21 Marek Safar <marek.safar@gmail.com>
5207 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5208 and logic for params overloads.
5210 2007-12-15 Miguel de Icaza <miguel@novell.com>
5212 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5213 as this is also created from the parser. Fixes #349034
5215 2007-12-12 Miguel de Icaza <miguel@novell.com>
5217 * statement.cs (Throw.CloneTo): it is valid to have empty
5218 expressions for throw.
5220 2007-12-03 Marek Safar <marek.safar@gmail.com>
5222 * cs-parser.jay: Set delegate constraint parsing region correctly.
5224 2007-12-03 Marek Safar <marek.safar@gmail.com>
5226 A fix for bug #345467
5227 * typemanager.cs (IsEqual): Compare generic parameters position only.
5229 2007-11-28 Marek Safar <marek.safar@gmail.com>
5231 * expression.cs (BaseAccess): Type arguments can be null.
5233 2007-11-27 Raja R Harinath <harinath@gmail.com>
5235 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5236 consistent even when an error has occured.
5237 (Switch.Resolve): Likewise.
5239 2007-11-22 Marek Safar <marek.safar@gmail.com>
5241 A fix for bug #334505
5242 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5245 2007-11-22 Marek Safar <marek.safar@gmail.com>
5247 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5248 refactorings required to resolve extension methods correctly when mixing
5249 generics and non-generics members.
5251 2007-11-20 Marek Safar <marek.safar@gmail.com>
5253 A fix for bug #342584
5254 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5257 2007-11-19 Marek Safar <marek.safar@gmail.com>
5259 A fix for bug #342512
5260 * delegate.cs: Use delegate argument expression when is available. Don't
5261 emit virtual call when class is sealed.
5263 2007-11-16 Marek Safar <marek.safar@gmail.com>
5265 A fix for bug #325423
5266 * assign.cs (FieldInitializer): Use resolved expression for emit.
5268 * class.cs: Print less confusing error message.
5270 2007-11-16 Marek Safar <marek.safar@gmail.com>
5272 * cs-tokenizer.cs: Removed GMCS ifdefs.
5274 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5277 * cs-parser.jay: Disabled nullable check.
5279 * generic-mcs: Copied more generic stuff.
5281 2007-11-16 Marek Safar <marek.safar@gmail.com>
5283 * gcs-parser.jay: Merged to cs-parser.jay.
5285 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5286 * *.csproj, *.sources: Updated to use only jay parser file.
5288 2007-11-16 Marek Safar <marek.safar@gmail.com>
5290 * gcs-parser.jay: Added nullable and default expression feature checks.
5292 2007-11-16 Marek Safar <marek.safar@gmail.com>
5294 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5295 it fixes many TODOs and hidden bugs.
5297 * expression: Removed duplicate error check.
5299 2007-11-15 Marek Safar <marek.safar@gmail.com>
5301 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5302 implicitly type local variable only when it is used in a declaration.
5304 2007-11-15 Marek Safar <marek.safar@gmail.com>
5306 * attribute.cs: Use CS0612 for empty strings.
5308 2007-11-14 Marek Safar <marek.safar@gmail.com>
5310 * lambda.cs, statement.cs: Contextual return may act as a statement.
5312 2007-11-14 Marek Safar <marek.safar@gmail.com>
5314 A fix for a regression cause by #324222
5315 * class.cs: Don't report unused even when it implements an interface.
5317 2007-11-13 Marek Safar <marek.safar@gmail.com>
5319 A fix for bug #341205
5320 * ecore.cs, expression.cs: Method group expression cannot do static
5321 method access with an instance reference check before overloading takes
5324 2007-11-13 Marek Safar <marek.safar@gmail.com>
5326 A fix for bug #325359
5327 * class.cs: Use predictable name for automatically generated property.
5329 2007-11-12 Marek Safar <marek.safar@gmail.com>
5331 A fix for bug #324996
5332 * expression.cs (Is): Handle case where D is nullable and T is not
5335 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5337 2007-11-12 Marek Safar <marek.safar@gmail.com>
5339 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5340 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5341 Flush small error reporting changes.
5343 2007-11-09 Marek Safar <marek.safar@gmail.com>
5345 A fix for bug #324996
5346 * expression.cs: Rewrote Is expression implementation to work with
5347 generics, nullable types, anonymous method. A const result expression
5348 uses existing infrastructure instead of custom not fully-featured one.
5350 2007-11-08 Marek Safar <marek.safar@gmail.com>
5352 A fix for bug #340202
5353 * class.cs: Consider generics for volatile field.
5355 2007-11-08 Marek Safar <marek.safar@gmail.com>
5357 A fix for bug #335594
5358 * expression.cs: Use conversion rules when handling string addition.
5360 2007-11-07 Marek Safar <marek.safar@gmail.com>
5362 A fix for bug #336651
5363 * expression.cs: Fixed a crash when probing is on.
5365 2007-11-07 Marek Safar <marek.safar@gmail.com>
5367 A fix for bug #324242
5368 * covert.cs: Added a conversion from any nullable-type with an
5369 underlying enum-type to the type System.Enum.
5371 2007-11-07 Marek Safar <marek.safar@gmail.com>
5373 A fix for bug #324222
5374 * class.cs: Report all non-used event fields.
5376 2007-11-07 Marek Safar <marek.safar@gmail.com>
5378 A fix for bug #325161
5379 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5380 qualifier for generic types.
5382 2007-11-07 Marek Safar <marek.safar@gmail.com>
5384 A fix for bug #322971
5385 * expression.cs, ecore.cs: Added intermediate result value check for
5388 2007-11-07 Marek Safar <marek.safar@gmail.com>
5390 A fix for bug #324754
5391 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5392 when it was requested.
5394 2007-11-07 Marek Safar <marek.safar@gmail.com>
5396 A fix for bug #325101
5397 * expression.cs: Do type not value comparison for `is' expression.
5399 2007-11-07 Marek Safar <marek.safar@gmail.com>
5401 A fix for bug #320236
5402 * convert.cs: Don't apply user conversion on underlying target type.
5404 2007-11-06 Marek Safar <marek.safar@gmail.com>
5406 * expression.cs: Don't use unresolved expression for error reporting.
5408 2007-11-06 Marek Safar <marek.safar@gmail.com>
5410 A fix for bugs #337712, #324490
5411 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5412 overloading resolution too.
5414 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5415 the process consistent and more robust.
5417 * expression.cs, linq.cs, report.cs: Update.
5419 2007-11-02 Marek Safar <marek.safar@gmail.com>
5421 A fix for bug #332909
5422 * attribute.cs: Resolve attributes in correct context using error
5425 * rootcontext.cs: Define Obsolete attribute members as core members.
5427 2007-11-02 Marek Safar <marek.safar@gmail.com>
5429 * statement.cs: Removed unused methods.
5431 2007-10-31 Wade Berrier <wberrier@novell.com>
5433 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5434 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5437 2007-10-31 Marek Safar <marek.safar@gmail.com>
5439 A fix for bug #338102
5440 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5441 methods registered as non-generics.
5443 2007-10-31 Marek Safar <marek.safar@gmail.com>
5445 A fix for bugs #337712, #324490
5446 * delegate.cs: Delegate covariance and contravariance is not allowed for
5449 2007-10-31 Marek Safar <marek.safar@gmail.com>
5451 A fix for bug #337719
5452 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5455 2007-10-30 Marek Safar <marek.safar@gmail.com>
5457 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5459 2007-10-29 Marek Safar <marek.safar@gmail.com>
5461 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5464 2007-10-29 Raja R Harinath <rharinath@novell.com>
5466 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5468 2007-10-29 Marek Safar <marek.safar@gmail.com>
5470 A fix for bug #334652
5471 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5472 extension methods when we have not found the best candidate in normal
5475 2007-10-27 Marek Safar <marek.safar@gmail.com>
5477 * AssemblyInfo.cs: Keep up-to-date.
5479 2007-10-27 Marek Safar <marek.safar@gmail.com>
5481 * Makefile: Fixed generics compiler name.
5483 2007-10-27 Marek Safar <marek.safar@gmail.com>
5485 * lambda.test: removed, lambda parsing is done differently.
5487 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
5489 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
5491 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
5493 2007-10-27 Marek Safar <marek.safar@gmail.com>
5495 * Makefile, *.sources : All C# compilers are in mcs folder.
5497 * *.cs: Use existing 2_1 define for smcs.
5499 2007-10-26 Marek Safar <marek.safar@gmail.com>
5501 A fix for bug #335847
5502 * assign.cs, expression.cs: Couple of changes to avoid creating a
5503 temporary variable for each object initializer assignment statement. It
5504 simplifies struct initialization too, otherwise two temporary variables
5506 Implemented optimization of redundant default element initializers.
5508 2007-10-25 Marek Safar <marek.safar@gmail.com>
5510 A fix for bug #336766
5511 * expression.cs (Class.CheckBase): Use generic name when method is
5514 2007-10-25 Marek Safar <marek.safar@gmail.com>
5516 A fix for bug #334737
5517 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
5518 variable and not variable argument for prepared copies.
5520 2007-10-24 Marek Safar <marek.safar@gmail.com>
5522 A fix for bug #325110
5523 * class.cs, expression.cs, attribute.cs: Use open generic method when
5524 checking conditional attribute.
5526 2007-10-24 Marek Safar <marek.safar@gmail.com>
5528 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
5529 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
5530 FeatureIsNotAvailable.
5532 2007-10-24 Marek Safar <marek.safar@gmail.com>
5534 ** C# 3.0 Partial methods
5536 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
5537 methods support. Because of member cache issue with generics only
5538 non-generics partial methods are fully supported.
5540 2007-10-23 Marek Safar <marek.safar@gmail.com>
5542 * class.cs, decl.cs: Rewrote member overloads check to cope with
5543 generics and to use member cache for member checking. It also improves
5544 performance and fixes remaining overloads issues.
5546 2007-10-20 Marek Safar <marek.safar@gmail.com>
5548 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
5549 roottypes.cs, typemanager.cs:
5551 A member cache creation logic changed to add members immediately and
5552 not rely on fallback. The member cache is now only prefered way
5553 how to access and find type declaration members. It saves 5 MB of memory
5554 during MWF compilation and makes code ready for more optimizations and
5555 clean-ups, it's also a pre-requirement for partial methods.
5557 2007-10-18 Raja R Harinath <harinath@gmail.com>
5559 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
5560 handling for generic parameters.
5562 2007-10-15 Marek Safar <marek.safar@gmail.com>
5564 * class.cs (FixedField): Removed redundant volatile check.
5566 2007-10-15 Marek Safar <marek.safar@gmail.com>
5568 * class.cs, decl.cs: Fixed overload members verification to do only one
5569 check per possible collision.
5571 2007-10-13 Marek Safar <marek.safar@gmail.com>
5573 A fix for bug #325478
5574 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
5575 and create only one disposable flags container.
5577 2007-10-12 Marek Safar <marek.safar@gmail.com>
5579 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
5580 * statement.cs (Fixed): Fixed variables cloning.
5582 2007-10-12 Marek Safar <marek.safar@gmail.com>
5584 A fix for bug #333342
5585 * class.cs (EventField): Don't mark value type event as synchronized.
5587 2007-10-12 Marek Safar <marek.safar@gmail.com>
5589 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
5590 inference to identify best candidate method correctly.
5591 (ProperyExpr): A range variable is read only and cannot be modified.
5593 2007-10-11 Marek Safar <marek.safar@gmail.com>
5595 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
5596 logic to identify best candidate method correctly.
5598 2007-10-11 Marek Safar <marek.safar@gmail.com>
5600 * location.cs (Equals, GetHashCode): Removed.
5602 2007-10-11 Marek Safar <marek.safar@gmail.com>
5604 * report.cs: Implemented message recorder. It is used mainly for lambda
5605 expressions to capture otherwise swallowed error messages.
5607 * anonymous.cs, lambda.cs.cs: Do full parameters check.
5609 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
5611 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
5613 * expression.cs (MemberAccess): Always report lookup failure.
5615 * location.cs: Implemented Equals, GetHashCode.
5617 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
5619 2007-10-10 Jb Evain <jbevain@novell.com>
5621 * codegen.cs: re-enable assembly version check.
5623 2007-10-09 Marek Safar <marek.safar@gmail.com>
5625 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
5628 * namespace.cs (UsingAlias): Do correct version check.
5630 2007-10-08 Marek Safar <marek.safar@gmail.com>
5632 * expresison.cs, ecore.cs: Issue extension method error message when
5635 * rootcontext.cs: Added ISO_2 compiler mode option.
5637 2007-10-08 Marek Safar <marek.safar@gmail.com>
5639 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
5642 2007-10-08 Marek Safar <marek.safar@gmail.com>
5644 * attribute.cs (GetString, GetBoolean): Work with both literal and
5647 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
5648 Moved method overload specific methods to MethodGroupExpr.
5650 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
5651 it should be less memory consuming.
5653 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
5655 * codegen.cs: remove the assembly version check until the buildbot is
5658 2007-10-07 Jb Evain <jbevain@novell.com>
5660 * attribute.cs (Attribute.GetString): if the value
5661 expression is a StringConstant, return its string value.
5663 2007-10-07 Jb Evain <jbevain@novell.com>
5665 * typemanager.cs: add `assembly_version_attribute_type`.
5666 * codegen.cs: on attribute emission, check that the
5667 AssemblyVersionAttribute doesn't overflow.
5669 2007-10-05 Marek Safar <marek.safar@gmail.com>
5671 A fix for bug #324677
5672 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
5673 parent container of a scope container with currently resolved one.
5675 2007-10-05 Marek Safar <marek.safar@gmail.com>
5677 A fix for bug #325534
5678 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
5681 2007-10-05 Marek Safar <marek.safar@gmail.com>
5683 A fix for bug #327504
5684 * class.cs (Operator.Define): Refactored implicit and explicit user
5685 operator conversion rules.
5687 2007-10-05 Marek Safar <marek.safar@gmail.com>
5689 A fix for bug #327520
5690 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
5692 2007-10-04 Marek Safar <marek.safar@gmail.com>
5694 A fix for bug #328022
5695 * class.cs (MethodData.Define): Use correct method to check whether
5696 a method implementents an accessor.
5698 2007-10-04 Marek Safar <marek.safar@gmail.com>
5700 A fix for bug #330069
5701 * statement.cs (Fixed.Resolve): Read the first array element only when
5702 an array is instantiated.
5704 2007-10-04 Marek Safar <marek.safar@gmail.com>
5706 * expression.cs, assign.cs, generics.cs: Print correct operator when
5707 compound assignment is used.
5709 2007-10-04 Marek Safar <marek.safar@gmail.com>
5711 A fix for bug #325841
5712 * expression.cs (ArrayAccess): Use full argument cloning only for
5713 string compound concatenation.
5715 2007-10-03 Marek Safar <marek.safar@gmail.com>
5717 A fix for bug #328774
5718 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
5720 (PropertyExpr.EmitAssign): Fixed string concatenation compound
5723 2007-10-03 Raja R Harinath <rharinath@novell.com>
5726 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
5727 Event accessibility checks here. Remove some bogus code that
5728 accidently made GenericMethods work.
5729 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
5731 2007-09-25 Marek Safar <marek.safar@gmail.com>
5733 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
5735 * statement.cs (Block): Refactored AddVariable to allow error handling
5738 * generic.cs: New stub.
5740 2007-09-23 Marek Safar <marek.safar@gmail.com>
5742 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
5745 2007-09-17 Marek Safar <marek.safar@gmail.com>
5747 * class.cs: Use partial container to record whether any partial part
5748 contains static field initializer and therefore default contructor has
5751 2007-09-14 Marek Safar <marek.safar@gmail.com>
5753 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
5754 mono-list when only one of two partial parts has defined accessibility
5757 2007-09-14 Marek Safar <marek.safar@gmail.com>
5759 A fix for bug #82845
5761 * class.cs (TypeContainer): Set correct resolve context for all field
5764 2007-09-13 Marek Safar <marek.safar@gmail.com>
5766 * assign.cs: Fixed a crash when field is resolved twice with an error.
5768 * codegen.cs: Changed InFieldInitializer to be flag.
5770 * anonymous.cs, ecore.cs, expression.cs: Update after
5771 IsInFieldInitializer rename.
5773 * const.cs: Removed unused parameter.
5775 * class.cs: Changed the way how we resolve and emit field initializers.
5776 The field initilizers have to have access to contructor block to emit
5777 compiler generated code.
5779 2007-09-13 Marek Safar <marek.safar@gmail.com>
5781 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
5782 generics use TypeContainer instead.
5784 2007-09-12 Marek Safar <marek.safar@gmail.com>
5786 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
5788 * lambda.cs (ResolveParameters): Use more powerful
5789 InflateGenericArgument.
5791 * parameters.cs: Better exception message.
5793 2007-09-10 Marek Safar <marek.safar@gmail.com>
5795 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
5796 correct expression block type.
5798 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
5800 * expression.cs (Invocation): Extracted method group resolve to
5803 2007-09-07 Marek Safar <marek.safar@gmail.com>
5805 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
5806 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
5808 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
5809 generic extension methods.
5811 2007-09-06 Marek Safar <marek.safar@gmail.com>
5813 A fix for bug #82676 (Do I get it right now?)
5814 * convert.cs (Binary.ResolveOperator): An interface is converted to the
5815 object before a standard conversion is applied.
5817 2007-09-06 Marek Safar <marek.safar@gmail.com>
5819 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
5822 2007-09-05 Marek Safar <marek.safar@gmail.com>
5824 A fix for bug #82676
5825 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
5826 non-generic interface types.
5828 2007-09-05 Marek Safar <marek.safar@gmail.com>
5830 A fix for bug #82690
5831 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
5833 2007-09-05 Marek Safar <marek.safar@gmail.com>
5835 A fix for bug #82571
5836 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
5837 modifier for container based methods.
5839 2007-09-05 Marek Safar <marek.safar@gmail.com>
5841 A fix for bug #82676
5842 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
5843 any interface-type T means to any of interface type T.
5845 2007-09-04 Marek Safar <marek.safar@gmail.com>
5847 * namespace.cs: We have 2 versions of System.Core assembly.
5849 2007-09-04 Marek Safar <marek.safar@gmail.com>
5851 A fix for bug #82652
5852 * class.cs (Class.GetClassBases): Compare types and not expressions.
5854 2007-09-04 Marek Safar <marek.safar@gmail.com>
5856 A fix for bug #82620
5857 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
5858 actually never worked before.
5859 (IndexerAccess): Emit prepared arguments before they are modified.
5861 2007-09-04 Marek Safar <marek.safar@gmail.com>
5863 A fix for bug #82563
5864 * assign.cs: Revert wrong fix.
5866 * expression.cs (VariableReference.EmitAssign): Handle ref reference
5868 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
5869 Instead of ldelema/stdind we have to use temporary variables to handle
5870 cases like String.Concat (params string[]).
5872 2007-08-31 Marek Safar <marek.safar@gmail.com>
5874 * class.cs: EmitAttributes to Emit rename.
5876 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
5878 (MemberCore.HasClsCompliantAttribute): Don't depend on
5879 GetClsCompliantAttributeValue execution.
5881 2007-08-31 Marek Safar <marek.safar@gmail.com>
5883 * anonymous.cs: Use shorter type prefix.
5885 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
5888 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
5889 variables when probing is on.
5891 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
5892 unresolved variables.
5893 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
5894 handle transparent identifiers.
5896 2007-08-26 Marek Safar <marek.safar@gmail.com>
5898 * attribute.cs (IsClsCompliant): Add nullable types test.
5900 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
5902 * doc.cs : catch other types of exception than XmlException to
5903 report CS1570. Fixed bug #82565.
5905 2007-08-23 Marek Safar <marek.safar@gmail.com>
5907 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
5908 The number of delegate parameters has to match.
5909 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
5912 2007-08-21 Marek Safar <marek.safar@gmail.com>
5914 * anonymous.cs (AnonymousMethod): Generate private anonymous method
5915 to fix problem with private arguments.
5917 2007-08-20 Marek Safar <marek.safar@gmail.com>
5919 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
5921 * decl.cs (MemberName): Ignore generic type with no generic arguments.
5923 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
5924 empty. Add cloning suport.
5926 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
5928 2007-08-20 Marek Safar <marek.safar@gmail.com>
5930 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
5931 to create EmptyCast. It handles EmptyConstantCast specialization for
5934 2007-08-18 Marek Safar <marek.safar@gmail.com>
5936 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
5937 (EmitArrayArgument): One routine for array arguments.
5938 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
5940 2007-08-17 Marek Safar <marek.safar@gmail.com>
5942 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
5944 2007-08-17 Marek Safar <marek.safar@gmail.com>
5946 * anonymous.cs: MemberLookupFinal update.
5948 * class.cs (ConstructorInitializer): Is expression based.
5950 * delegate.cs: MethodGroupExpr update.
5952 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
5954 (Error_MemberLookupFailed): Customizable error override.
5955 (MethodGroupExpr): Keep queried type for later usage.
5956 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
5959 * expression.cs: Error_MemberLookupFailed refactoring.
5960 (New.DoResolve): Resolve as much as possible.
5961 (ElementInitializer.Error_MemberLookupFailed): Object initializer
5962 customization for invalid member types.
5964 * statement.cs: MethodGroupExpr update.
5966 2007-08-16 Marek Safar <marek.safar@gmail.com>
5968 * modifier.cs (Check): Check all modifiers and not only accessibility
5971 2007-08-16 Marek Safar <marek.safar@gmail.com>
5973 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
5974 type and not an expression.
5976 2007-08-16 Marek Safar <marek.safar@gmail.com>
5978 * statement.cs (Catch.Clone): Type and variable can be null.
5980 2007-08-16 Marek Safar <marek.safar@gmail.com>
5982 A fix for bug #81979
5983 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
5984 I am really not sure whether this is the best fix.
5986 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
5989 2007-08-14 Marek Safar <marek.safar@gmail.com>
5991 ** C# 3.0 Object and collection initializers (major re-write)
5993 * assign.cs (DoResolve): Initializers are not assign related.
5995 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
5996 used during collection or object initialization.
5998 * expression.cs (Error_InvalidArguments): Add initializers specific
5999 messages. More will come later because it requires some general
6001 (New.DoResolve): Better error handling for unsafe types.
6002 (EmptyExpressionStatement): New class.
6003 (ElementInitializer): An object initializer expression.
6004 (CollectionElementInitializer): A collection initializer expression.
6005 (CollectionOrObjectInitializers): A block of object or collection
6007 (NewInitialize): New expression with element/object initializers.
6009 * statement.cs: Reverted object/collection initializer hacks.
6011 * typemanager.cs (CSharpName): Filter __arglist type.
6013 2007-08-09 Marek Safar <marek.safar@gmail.com>
6015 ** C# 3.0 Anonymous Types (update to the latest standard)
6017 * expression.cs (Binary.ResolveOperator): Threat all null based types
6019 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6020 (AnonymousTypeParameter): Updated.
6022 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6023 (AnonymousTypeClass): New anonymous type container.
6025 * class.cs (AddField): Return operation result.
6027 * generic.cs: Another empty TypeArguments overload.
6029 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6030 are stored at top of normal hierarchy.
6032 * typemanager.cs (CSharpName): Filter anonymous types.
6034 2007-08-09 Marek Safar <marek.safar@gmail.com>
6036 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6037 as single Concat call. How could we miss that :-(
6039 2007-08-08 Marek Safar <marek.safar@gmail.com>
6041 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6043 2007-08-07 Miguel de Icaza <miguel@novell.com>
6045 * expression.cs: Fix the previous commit, the creation of the
6046 arguments array list needs also to be conditional on the arguments
6049 * class.cs: Add a little bit of help to help narrow down problems.
6051 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6052 not try to copy in that case.
6054 * driver.cs: When building SMCS, include a new different set of
6055 default assemblies here. Do this here so we can control whether
6056 to include the default assemblies with /noconfig.
6058 2007-08-03 Marek Safar <marek.safar@gmail.com>
6060 A fix for bug #81979
6061 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6064 2007-08-03 Marek Safar <marek.safar@gmail.com>
6066 A fix for bug #82300
6068 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6069 we are in probing scope.
6071 2007-08-03 Marek Safar <marek.safar@gmail.com>
6073 A fix for bug #82301
6075 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6076 (Statement.CloneTo): Clone and not map children blocks.
6078 2007-08-03 Marek Safar <marek.safar@gmail.com>
6080 A fix for bug #82299
6082 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6085 * statement.cs (Statement.CloneTo): Clone variables before statements
6086 to allow remaping of local variables.
6088 2007-08-03 Marek Safar <marek.safar@gmail.com>
6090 A fix for bug #82296
6093 * report.cs: Log crash details for future clone problems.
6095 * statement.cs (Return.Clone): Don't clone non-existent expression.
6097 2007-08-03 Raja R Harinath <harinath@gmail.com>
6099 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6100 (Class.AddBasesForPart): Move CS0537 check here from ...
6101 * cs-parser.jay (class_declaration): ... here. Move calling of
6102 'AddBasesForPart' to ...
6103 (class_bases): ... here.
6104 (struct_declaration, interface_declaration): Update to changes.
6106 2007-08-02 Marek Safar <marek.safar@gmail.com>
6108 A fix for bug #81923
6110 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6111 conversion is allowed.
6113 2007-08-02 Marek Safar <marek.safar@gmail.com>
6115 A fix for bug #81564
6117 * ecore.cs (EventExpr): Add IsBase handling.
6119 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6122 2007-08-02 Raja R Harinath <harinath@gmail.com>
6124 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6125 * cs-parser.jay: Some whitespace cleanups.
6126 (current_delegate): New.
6128 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6129 a dummy code block, and use 'type_name' instead of 'member_name'.
6130 (interface_declaration, class_declaration): Likewise.
6131 (delegate_declaration): Likewise. Rearrange slightly and use
6133 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6134 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6136 2007-08-02 Marek Safar <marek.safar@gmail.com>
6138 A fix for bug #82039
6140 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6143 * typemanager.cs (CSharpName): Split to string overload.
6145 2007-08-02 Marek Safar <marek.safar@gmail.com>
6148 * report.cs: Updated warning CS0472.
6150 2007-08-01 Marek Safar <marek.safar@gmail.com>
6152 A fix for bug #82181
6154 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6156 2007-08-01 Marek Safar <marek.safar@gmail.com>
6158 A fix for bug #82277
6159 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6161 2007-08-01 Marek Safar <marek.safar@gmail.com>
6163 ** C# 3.0 Type Inference (major bits are working)
6165 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6166 (.ImplicitStandardConversionExists): Uses compatible.
6167 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6168 (.InferReturnType): New method.
6169 (.Compatible): Refactored.
6170 (.ResolveParameters): Uses factory to create resolved parameters.
6171 (.CompatibleMethod): Add probing mode support.
6172 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6173 clearly distinguish between 2 different operations.
6174 (LambdaMethod): Moved to lambda.cs.
6175 (AnonymousMethod): Removed unused fields and methods.
6176 (AnonymousDelegate): Simplified.
6178 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6180 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6182 * delegate.cs (Delegate): New mehods to reduce code duplication.
6183 (.GetConstructor): New method.
6184 (.GetInvokeMethod): New method.
6185 (DelegateCreation): Updated.
6187 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6189 (OverloadResolve): Made probing little bit faster.
6191 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6194 * generic.cs (TypeInferenceContext): Dummy implementation.
6196 * iterators.cs: Updated after Resolve/Define rename.
6198 * lambda.cs (LambdaExpression)
6199 (.ResolveParameters): Handles both type of arguments and type inference too.
6201 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6202 (InflateTypes): Updated.
6204 * support.cs (InflateTypes): Changed signature and updated.
6206 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6207 (MemberLookup_FindMembers): More MS tricks.
6208 (GetParameterData): Ditto.
6209 (GetDelegateParameters): Uses quick path for dynamic types.
6211 2007-08-01 Marek Safar <marek.safar@gmail.com>
6213 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6216 2007-07-31 Marek Safar <marek.safar@gmail.com>
6218 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6221 2007-07-26 Jb Evain <jbevain@novell.com>
6223 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6224 which takes a boolean 'report_errors', similar to the GetMethod.
6225 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6226 in .net 2.1, do not report errors here.
6228 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6229 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6230 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6233 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6234 of the type InternalsVisibleToAttribute before the first call
6235 to CoreLookupType which is allowed to fail (third boolean parameter
6236 to true). Because, during the resolution for a type that is not
6237 immediately found, we try to check if the type is not defined in
6238 a friend assembly, and to do so, we need the
6239 InternalVisibleToAttribute.
6241 2007-07-23 Miguel de Icaza <miguel@novell.com>
6243 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6244 feature that allows structs to be compared against null and inline
6245 the result as true or false.
6247 Notice that the same code is not permitted inside a generic block
6248 of code that would do:
6250 class Foo<T> where T : struct {
6257 It is only allowed if the type of T is not bound (no where
6258 clause). In my opinion, this CSC 2 behavior is broken but people
6259 seem to be using it (IronRuby does, a few bug reports on bugzilla
6260 have it and some people have complained about it).
6262 All of the users that depend on this behavior have code that is
6265 * report.cs (Warning, Error): make these take object arguments,
6266 not strings, as that allows us to take advantage of Format.
6268 2007-07-20 William Holmes <billholmes54@gmail.com>
6270 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6271 Left member variable for the Count.
6272 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6273 MemberName.CountTypeArguments to avoid a NRE.
6275 This code is contributed under the MIT X11 license
6277 2007-07-18 Marek Safar <marek.safar@gmail.com>
6279 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6281 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6283 * doc.cs : generic method arguments are written as ``x while generic
6284 type arguments are `x. Combined with the previous change, fixed bug
6287 2007-07-18 Raja R Harinath <rharinath@novell.com>
6290 * expression.cs (Binary.ResolveOperator): When converting
6291 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6293 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6295 * doc.cs : when T: or whatever x: is specified, it does not really
6296 check the doc comment's syntax correctness. Fixed bug #82006.
6298 2007-07-18 Marek Safar <marek.safar@gmail.com>
6300 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6301 LambdaExpression better.
6303 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6305 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6307 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6308 as it can be generated.
6310 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6313 * lambda.cs (LambdaExpression): Refactored to share same code with
6314 AnonymousMethodExpression.
6316 2007-07-17 Marek Safar <marek.safar@gmail.com>
6318 * anonymous.cs (MakeName): Include host name for easier debugging.
6319 (LambdaMethod): New class for lambda spcecific stuff.
6321 * attribute.cs: Set EmitContext return type.
6323 * class.cs: Set EmitContext return type.
6325 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6326 with null/void meaning.
6328 * iterators.cs (ContainerType): Implemented.
6330 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6332 * statement.cs (Return): Updated to lambda expressions.
6333 (Block.CloneTo): Parent can be null.
6335 2007-07-13 Marek Safar <marek.safar@gmail.com>
6337 A fix for bug #81917
6338 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6340 * class.cs (FixedField): Check whether field is in unsafe scope.
6342 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6343 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6345 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6348 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6350 2007-07-13 Marek Safar <marek.safar@gmail.com>
6352 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6353 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6356 2007-07-13 Marek Safar <marek.safar@gmail.com>
6358 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6360 2007-07-13 Marek Safar <marek.safar@gmail.com>
6362 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6363 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6365 * codegen.cs(EmitContext): Add ProbingMode flag.
6367 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6369 * driver.cs: For now set both warning values.
6371 * ecore.cs (SimpleName): Name is readonly.
6372 (MethodGroup.OverloadResolve): One quick path for probing.
6374 * expression.cs (Unary): Set Oper r/o.
6375 (Binary): Set Oper r/o.
6376 (ParameterReference): Set few instance variables as r/o.
6377 (ParameterReference.DoResolveBase): Don't capture aruments when
6379 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6380 (Arglist): arguments are private.
6381 (SizeOf): type is private and r/o.
6382 (MemberAccess): arguments are private.
6384 * report.cs: Enhanced reporting on/off capabilities.
6386 * lambda.cs: Uses ec.IsInProbingMode.
6387 (ContextualReturn): Derives from return.
6389 * rootcontext.cs: For now set both warning values.
6391 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6393 (Return.Resolve): Don't die immediately.
6394 (Block.Resolve): Speed-up probing.
6395 (Block.CloneTo): Clone only child blocks.
6397 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6399 * iterators.cs: reverted Miguel's latest change (r81925) as it
6400 breaks the build in System.
6402 2007-07-13 Miguel de Icaza <miguel@novell.com>
6404 * iterators.cs (Yield.CheckContext): Check for the iterator type
6405 also here as we can call into Yield even in codepaths that are not
6407 (MethodOrOperator is the only path that was checked).
6409 In addition to the standard check, use a more specific check for
6410 constructors to report a more verbose error.
6412 2007-07-12 Miguel de Icaza <miguel@novell.com>
6414 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6415 report the warning and continue
6417 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6418 values on the stack on the call to Emit. Use EmitStatement if
6419 possible, or using Emit + Pop if not possible. Fixes #82064
6421 2007-07-12 Raja R Harinath <rharinath@novell.com>
6423 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6424 avoid try...finally in some cases.
6426 2007-07-10 Marek Safar <marek.safar@gmail.com>
6428 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6430 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6431 instead of method. Re-use standard error handling.
6432 (ConstructorInitializer.Emit): Simplified.
6434 * delegate.cs: Updated after Invocation.EmitCall change.
6436 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6437 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6438 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6439 method and don't permanently changing input arguments.
6440 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6441 is resolved it has one of the candidates is the best one which is later
6442 used to emit. Removed a few unused method.
6443 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6445 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6446 (Binary.ResolveOperator): Ditto.
6447 (ConditionalLogicalOperator.DoResolve): Ditto.
6448 (Invocation): Uses method group.
6449 (Invocation.DoResolve): Simplified.
6450 (Invocation.EmitCall): Removed useless is_static.
6451 (Invocation.Emit): Delegate to method group.
6452 (Invocation.EmitStatement): Simplified.
6453 (New): Uses method group.
6454 (MemberAccess.DoResolve): Don't destroy original expression.
6456 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6458 2007-07-04 Marek Safar <marek.safar@gmail.com>
6460 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6463 * lambda.cs: Add custom error message type.
6465 2007-07-03 Marek Safar <marek.safar@gmail.com>
6467 * lambda.cs: Simplified little bit.
6469 * parameter.cs: Introduced ImplicitLambdaParameter.
6470 (Parameters.CreateFullyResolved): New factory instead of ctor.
6474 * delegate.cs: Updated parameter creation.
6476 2007-07-03 Marek Safar <marek.safar@gmail.com>
6478 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6481 * generic.cs: Synchronized with gmcs.
6483 2007-07-03 Marek Safar <marek.safar@gmail.com>
6485 * class.cs (Indexer): Check return type as soon as possible.
6487 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6490 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
6492 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
6494 * parameter.cs (Parameter): Use expression type when it is available.
6496 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
6497 method modifier for the first parameter only.
6499 2007-06-24 Marek Safar <marek.safar@gmail.com>
6501 A fix for bug #81938
6502 * typemanager.cs (ChangeType): Fixed couple of char conversions.
6504 * constant.cs: Tide up an exception message.
6506 2007-06-22 Marek Safar <marek.safar@gmail.com>
6508 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
6509 an uninitialized variable is used.
6511 * expression.cs (LocalVariableReference.DoResolve): Ditto.
6513 2007-06-22 Marek Safar <marek.safar@gmail.com>
6515 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
6516 not found error handling.
6518 * expression.cs (ArrayCreation): Removed redundant fields and little bit
6520 (ArrayCreation.ResolveArrayElement): To be ready to customization.
6521 (ArrayCreation.DoResolve): Simplified.
6522 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
6523 its own resolve process.
6524 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
6526 2007-06-20 Marek Safar <marek.safar@gmail.com>
6528 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
6531 2007-06-20 Marek Safar <marek.safar@gmail.com>
6533 * cs-tokenizer.cs: Removed var related stuff.
6535 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
6536 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
6537 a type and a keyword at same time.
6539 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
6542 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
6543 implicitly typed arrays, more changes will follow.
6545 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
6547 2007-06-19 Marek Safar <marek.safar@gmail.com>
6549 * ecore.cs (VarExpr): Removed Handled field.
6551 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
6552 build-in assign functionality.
6553 (ForEach.Resolve): Removed all implicitly typed local variable code and
6555 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
6556 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
6558 2007-06-18 Marek Safar <marek.safar@gmail.com>
6560 * assign.cs: Removed implicitly typed local variable check.
6562 * expression.cs (LocalVariableReference.DoResolve): Add check for self
6563 referencing implicitly typed local variable.
6564 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
6567 * statement.cs (Fixed): Removed unsupported implicitly typed local
6570 2007-06-15 Marek Safar <marek.safar@gmail.com>
6572 * decl.cs (MemberName): Moved all Unbound stuff to parser.
6574 2007-06-14 Marek Safar <marek.safar@gmail.com>
6576 A fix for bugs #81855 and #76274
6577 * attribute.cs (AttachTo): Always set owner for global attributes to
6580 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
6583 * cs-parser.jay: Assembly and module attributes must precede all other
6584 elements except using clauses and extern alias declarations.
6586 2007-06-13 Marek Safar <marek.safar@gmail.com>
6588 A fix for bug #81748
6590 * expression.cs: More checks for non ISO-1 features.
6592 2007-06-12 Marek Safar <marek.safar@gmail.com>
6594 A fix for bug #81807
6595 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
6596 present inside switch statement and it is required by nullable check.
6598 2007-06-12 Marek Safar <marek.safar@gmail.com>
6600 A fix for bug #81840
6601 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
6602 when type matching fails.
6604 * namespace.cs: Tiny error message change.
6606 2007-06-12 Marek Safar <marek.safar@gmail.com>
6608 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
6609 reporting. Added automatic property check.
6611 * class.cs: Updated after CheckAbstractAndExtern relocation.
6612 (AEventPropertyAccessor.GetSignatureForError): Customized.
6614 2007-06-11 Marek Safar <marek.safar@gmail.com>
6616 * class.cs (DefineBaseTypes): Base type can be undefined.
6618 * ecore.cs (TypeLookup): Minor refactoring.
6619 (DoResolveAsTypeStep): Removed redundant check.
6621 * namespace.cs (Lookup): Removed redundant check.
6623 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
6624 ResolveAsTypeTerminal step.
6625 (BootstrapCorlib_*): Simplified.
6626 (PopulateCoreType): Core types can be now external.
6628 2007-06-07 Marek Safar <marek.safar@gmail.com>
6630 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
6632 (InferTypeArguments): Infers anonymous expression type arguments.
6633 (Compatible): Split to Compatible and InferTypeArguments.
6635 * lambda.cs: Updated.
6637 2007-06-08 Marek Safar <marek.safar@gmail.com>
6639 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
6641 2007-06-07 Raja R Harinath <harinath@gmail.com>
6643 Fix #80477, cs0135-2.cs, cs0135-3.cs
6644 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
6645 names to the "known" variables list.
6646 (Block.CheckInvariantMeaningInBlock): Handle the fact the
6647 parameter names are also "known".
6648 (Block.CheckError136): Remove.
6649 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
6652 2007-06-07 Marek Safar <marek.safar@gmail.com>
6654 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
6656 2007-06-06 Marek Safar <marek.safar@gmail.com>
6658 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
6659 internal error not an user error.
6661 * expression.cs (IsApplicable): Refactored to make debugging easier.
6663 * support.cs: More tricks for non-mono runtimes.
6665 * typemanager.cs (CoreLookupType): Made public.
6666 (InitSystemCore): All linq specific stuff moved to linq.cs
6668 2007-06-05 Marek Safar <marek.safar@gmail.com>
6670 * typemanager.cs (CSharpSignature): One more missing build-in types
6672 More tricks for non-mono runtime.
6674 2007-06-05 Raja R Harinath <harinath@gmail.com>
6676 * statement.cs (Block.CheckError136_InParents): Remove.
6677 (Block.AddVariable): Use GetParameterInfo instead.
6678 (ToplevelBlock.ProcessArguments): Likewise.
6680 2007-06-04 Raja R Harinath <rharinath@novell.com>
6682 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
6684 (ToplevelBlock.GetParameterInfo): Split out of ...
6685 (ToplevelBlock.GetParameterRefernce): ... this.
6686 (ToplevelBlock.ParameterMap): Remove.
6687 * expression.cs (ParameterReference): Update to use
6688 ToplevelParameterInfo.
6690 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
6693 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
6694 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
6696 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
6697 (ToplevelBlock.ProcessParameters) ... here.
6698 (ToplevelBlock..ctor): Invoke it.
6700 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
6703 * statement.cs (IKnownVariable): New interface.
6704 (LocalInfo): Implement it.
6705 (ToplevelParameterInfo): New class.
6706 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
6707 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
6708 GetKnownVariableInfo.
6710 2007-06-03 Raja R Harinath <harinath@gmail.com>
6712 Partly speed up CS0136 error checks.
6713 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
6714 'recurse' parameter.
6715 (Block.DoCheckError136): Only check errors in parameters. Move
6716 local variable checks ...
6717 (Block.AddVariable): ... here, and ...
6718 (ToplevelBlock.ResolveMeta): ... here.
6720 2007-06-02 Raja R Harinath <harinath@gmail.com>
6722 * statement.cs (Block.IsChildOf): Remove.
6724 * statement.cs (Statement.Clone): Move special case code ...
6725 (Block.CloneTo): ... here.
6727 2007-05-29 Raja R Harinath <rharinath@novell.com>
6729 * statement.cs (ToplevelBlock.container): Remove field. It's
6730 redundant with 'Parent'.
6731 (ToplevelBlock.ContainerBlock): Remove accessor.
6732 (ToplevelBlock..ctor): Update to changes. Register anonymous
6733 child with parent here, ...
6734 * cs-parser.jay (end_anonymous): ... not here. Don't modify
6736 (start_anonymous): Don't save current_block.
6737 (top_current_block): Remove.
6739 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
6740 (Block.Resolve): Update to changes.
6741 (Block..ctor): Move setting of "correct" 'Toplevel'
6742 and 'Explicit' fields to ...
6743 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
6745 2007-05-27 Raja R Harinath <harinath@gmail.com>
6748 * statement.cs (Block.Implicit): Remove.
6749 (Block): Update to changes.
6750 * flowanalysis.cs: Likewise.
6752 Mildly speed up CheckInvariantMeaningInBlock
6753 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
6754 Recursively call AddKnownVariable to all enclosing blocks.
6755 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
6756 Remove recursive calls.
6757 (Block): Update to changes.
6759 New ExplicitBlock invariants
6760 * statement.cs (Block.Explicit): New field. It points to the
6761 immediately enclosing non-implicit block.
6762 (Block..ctor): Maintain the invariant.
6763 * cs-parser.jay: Take advantage of invariant.
6765 Introduce ExplicitBlock
6766 * statement.cs (ExplicitBlock): New.
6767 (ToplevelBlock): Derive from it.
6768 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
6770 (Block.Implicit): Update to changes.
6771 * cs-parser.jay: Update to changes.
6774 * codegen.cs (EmitContext.IsLastStatement): Remove.
6775 * statement.cs (Block.DoEmit): Update to changes.
6777 2007-05-25 Raja R Harinath <rharinath@novell.com>
6779 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
6780 modifying current_block directly.
6782 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
6784 * class.cs: Implemented automatic properties (C# 3.0)
6785 Thanks to Marek for the help.
6787 2007-05-23 Raja R Harinath <rharinath@novell.com>
6789 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
6790 variable as assigned, note also that all its components are
6792 (MyBitVector.SetRange): New. Function to set multiple bits to true.
6794 2007-05-19 Marek Safar <marek.safar@gmail.com>
6796 * anonymous.cs, class.cs: Emit Compiler generated attribute when
6797 member is marked as compiler generated.
6799 * decl.cs (MemberCore): Refactored ModFlags into property.
6801 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
6802 (Check): Check only accessibility modifiers.
6804 2007-05-18 Raja R Harinath <rharinath@novell.com>
6806 Track all assignable slots in one bit array
6807 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
6808 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
6809 logic from VariableMap constructor here. Use the same 'offset'
6810 variable that's later used for computing offsets of local
6812 * flowanalysis.cs (UsageVector.parameters): Remove.
6813 (UsageVector): Update to changes.
6814 (VariableMap): Remove.
6816 Avoid creating ParameterMap in every block
6817 * statement.cs (Block.ParameterMap): Move ...
6818 (ToplevelBlock.ParameterMap): ... here.
6819 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
6821 * flowanalysis.cs (FlowBranching.param_map): Remove.
6822 (FlowBranching.UsageVector): Update to changes.
6823 (FlowBranchingToplevel.CheckOutParameters): Likewise.
6825 * statement.cs (Block.CloneTo): Clone Toplevel field too.
6827 * expression.cs (ParameterReference): Distinguish between block
6828 where parameter was referenced and declared.
6830 2007-05-18 Marek Safar <marek.safar@gmail.com>
6832 * flowanalysis.cs, statement.cs: Put back improved error handling.
6834 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
6838 Imporved object and collection initialization (C# 3.0).
6840 2007-05-15 Marek Safar <marek.safar@gmail.com>
6842 A fix for bug #81380
6843 * expression.cs (Is.DoResolve): Only value types have constant `is'
6846 2007-05-15 Raja R Harinath <rharinath@novell.com>
6848 * statement.cs (ToplevelBlock.child): Remove.
6850 2007-05-15 Raja R Harinath <harinath@gmail.com>
6852 Rationalize ResolveMeta: refactoring
6853 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
6854 out constant handling code into ...
6855 (Block.DoResolveConstants): ... this.
6857 Rationalize ResolveMeta: kill local_map
6858 * statement.cs (Block.local_map, Block.LocalMap): Remove.
6859 (Block.AssignableSlots): New.
6860 (Block.ResolveMeta): Make protected. Don't create a VariableMap
6861 for locals -- move code from VariableMap here. Avoid unnecessary
6863 * flowanalysis.cs (FlowBranching.local_map): Remove.
6864 (FlowBranching..ctor): Use Block.AssignableSlots.
6865 (VariableMap): Remove unused constructors.
6867 2007-05-11 Raja R Harinath <rharinath@novell.com>
6869 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
6871 2007-05-11 Marek Safar <marek.safar@gmail.com>
6873 * typemanager.cs (IsFriendAssembly): Should not be called for building
6876 2007-05-09 Marek Safar <marek.safar@gmail.com>
6878 * literal.cs (NullConstant): Print null in all cases.
6880 * expression.cs (Binary.ResolveOperator): Implemented delegate
6881 comparison based on C# 2.0 changes.
6883 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
6885 This code is contributed under the MIT X11 license
6887 The following enables support for several C# 3.0 language features:
6889 * cs-tokenizer.cs: Added support for the "var" keyword.
6891 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
6892 Added VarExpr class to facilitate type inferencing.
6894 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
6895 to support anonymous types.
6897 * assign.cs: Added support for type inferencing and initialization.
6899 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
6901 * expression.cs: Added implicit array support to ArrayCreation.
6902 Added 5 types and 1 interface:
6904 IInitializable Implementing classes can inject initializing
6905 statements after object instantiation.
6907 Initializer Stores data for object initialization.
6909 AnonymousType An expression for anonymous types.
6911 AnonymousTypeParameter Stores data about an anonymous type's field.
6913 NewInitialize An expression for object initialization.
6915 CollectionInitialize An expression for collection initialization.
6917 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
6920 2007-05-06 Marek Safar <marek.safar@gmail.com>
6922 A fix for bug #81500
6923 * cs-tokenizer.cs: Add special handling for coalescing operator.
6925 2007-05-06 Marek Safar <marek.safar@gmail.com>
6927 A fix for bug #81529
6928 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
6929 its value from base class until it is redefined.
6931 2007-05-02 Raja R Harinath <rharinath@novell.com>
6933 Fix regression in cs0631-3.cs
6934 * cs-parser.jay (operator_declarator): Add opt_attributes to error
6935 fallback. Make error fallback catch more cases.
6937 2007-05-01 Miguel de Icaza <miguel@novell.com>
6939 * cs-parser.jay: Allow parameters in operator declarations to have
6942 2007-04-27 Miguel de Icaza <miguel@novell.com>
6944 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
6947 * lambda.cs (ContextualReturn.Resolve): An expression is valid
6948 inside the ContextualReturn, it does not have to be an
6949 ExpressionStatement.
6951 2007-04-24 Miguel de Icaza <miguel@novell.com>
6953 * lambda.cs (ContextualReturn.Resolve): if the return type is not
6956 2007-04-23 Miguel de Icaza <miguel@novell.com>
6958 * anonymous.cs (AnonymousContainer): split the virtual Resolve
6959 method in two methods: ResolveNoDefine and Resolve.
6961 ResolveNoDefine will stop just after ResolveTopBlock has been
6964 Resolve will then continue by creating a method and issuing the
6965 call to method.Define ().
6967 (AnonymousMethod): Split and implement the new Resolve and
6968 ResolveNoDefine as well.
6970 * lambda.cs (LambdaExpression): Split the anonymous method
6971 resolution code into a separate routine (CoreCompatibilityTest)
6972 from DoCompatibleTest.
6974 (LambdaExpression.TryBuild): New method, this method tries to
6975 build the LambdaExpression with the given set of types to be used
6976 as the types for the various parameters of the lambda expression.
6978 If the compilation succeed with the given types, the infered type
6979 of the Anonymous method is returned, otherwise null is returned.
6981 2007-04-23 Marek Safar <marek.safar@gmail.com>
6983 A fix for bug #81414
6984 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
6986 2007-04-22 Miguel de Icaza <miguel@novell.com>
6988 * cs-tokenizer.cs: Change various identifiers here from the
6989 camelCasing to the recommended Linux-like style for instance
6990 variables from the Coding Guidelines.
6992 2007-04-19 Martin Baulig <martin@ximian.com>
6995 (Convert.ImplicitReferenceConversionCore): Allow conversions from
6996 System.Enum to System.ValueType.
6998 2007-04-13 Martin Baulig <martin@ximian.com>
7000 Rewrote implicit reference conversions. We need to distinguish
7001 between implicit reference conversions (13.1.4) and implicit
7002 boxing conversions (13.1.5).
7004 According to the spec, there's an an implicit conversion
7005 "From a one-dimensional array-type S[] to IList<T> and base
7006 interfaces of this interface, provided there is an implicit
7007 reference conversion from S to T." Note that this does not
7008 include boxing conversions.
7011 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7012 (Convert.ImplicitReferenceConversion): Split into
7013 ImplicitReferenceConversionCore() and
7014 ImplicitBoxingConversionExist().
7015 (Convert.ImplicitReferenceConversionExists): Use the new
7016 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7018 2007-04-12 Martin Baulig <martin@ximian.com>
7020 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7021 `TypeManager.null_type' checks up to the top of the method.
7023 2007-04-11 Marek Safar <marek.safar@gmail.com>
7025 A fix for bug #81350
7026 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7029 2007-04-11 Martin Baulig <martin@ximian.com>
7031 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7032 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7033 to make this work for generic classes; fixes #79561.
7035 2007-04-11 Martin Baulig <martin@ximian.com>
7037 * expression.cs (As): Add support for nullable types; fixes #79371.
7039 2007-04-11 Martin Baulig <martin@ximian.com>
7041 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7042 `type.FullName' is null; fixes #80243.
7044 2007-04-11 Martin Baulig <martin@ximian.com>
7046 * expression.cs (Invocation.IsApplicable): Don't modify the method
7047 if type inference succeeded, but the method was not applicable.
7050 2007-04-10 Marek Safar <marek.safar@gmail.com>
7052 A fix for bug #81324
7053 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7054 internal and external namespaces containers.
7056 2007-04-10 Martin Baulig <martin@ximian.com>
7058 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7059 TypeManager.DropGenericMethodArguments() so we also call
7060 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7062 2007-04-10 Martin Baulig <martin@ximian.com>
7064 * iterators.cs (Iterator.CreateIterator): Don't crash if
7065 `method.ReturnType' is null. This happens if something went wrong
7066 while resolving that typ (we already reported an error in this case).
7068 2007-04-10 Martin Baulig <martin@ximian.com>
7070 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7071 generic interfaces; report the CS0144 directly.
7073 2007-04-10 Martin Baulig <martin@ximian.com>
7075 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7076 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7078 2007-04-10 Martin Baulig <martin@ximian.com>
7080 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7082 2007-04-09 Raja R Harinath <rharinath@novell.com>
7085 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7086 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7089 * statement.cs (For.Resolve): If resolution fails, use
7092 2007-04-08 Marek Safar <marek.safar@gmail.com>
7094 * anonymous.cs (MakeName): Make faster and zero-based.
7095 (VerifyExplicitParameterCompatibility): Back to mode where generic
7096 parameter is ignored.
7097 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7099 * class.cs (EmitType): Method can emit another new method.
7101 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7103 * driver.cs: Updated.
7105 * lambda.cs: Reuse predefined empty parameters.
7107 * parameter.cs: Updated
7109 * support.cs: Implemented InflateTypes.
7111 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7112 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7114 2007-04-03 Martin Baulig <martin@ximian.com>
7118 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7119 version of TypeManager.IsOverride() which also works with generic
7122 2007-04-03 Martin Baulig <martin@ximian.com>
7127 (Convert.ExplicitReferenceConversion): We need to cast when
7128 converting from IList<T> to S[].
7130 2007-04-01 Marek Safar <marek.safar@gmail.com>
7132 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7135 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7137 2007-03-31 Marek Safar <marek.safar@gmail.com>
7139 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7140 argument and return type inferring.
7142 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7143 (ReturnType): Turned to property.
7145 * statement.cs (Return): Implemented return type inferring.
7147 * support.cs (ReflectionParameters): Use local types if possible.
7149 2007-03-30 Raja R Harinath <rharinath@novell.com>
7151 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7152 (FlowBranching.UsageVector): Update to changes.
7154 Prepare to kill 'Reachability'
7155 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7156 argument of constructor.
7158 2007-03-29 Raja R Harinath <rharinath@novell.com>
7160 Prepare to kill 'Reachability'
7161 * flowanalysis.cs (UsageVector.is_unreachable): New.
7162 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7163 'reachability', and verify they're consistent.
7166 * expression.cs (New.EmitStatement): Handle type parameters here too.
7168 2007-03-29 Martin Baulig <martin@ximian.com>
7173 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7174 CompilerGeneratedClass.
7175 (ScopeInfo.EmitScopeInstance): Make this protected.
7176 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7177 `ec.CurrentAnonymousMethod.Scope == Scope'.
7179 * statement.cs (Block.ScopeInfo): Make this a property.
7181 2007-03-27 Raja R Harinath <harinath@gmail.com>
7183 Prepare to kill 'Reachability'
7184 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7185 (FlowBranching.UsageVector.Reachability): Remove property.
7186 (FlowBranching.UsageVector.IsUnreachable): New property.
7187 (FlowBranching.UsageVector.ResetBarrier): New.
7188 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7189 * codegen.cs, statement.cs: Update to changes.
7191 2007-03-27 Martin Baulig <martin@ximian.com>
7196 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7199 2007-03-26 Raja R Harinath <rharinath@novell.com>
7201 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7202 instead of TriState. Remove all mention of TriState.
7204 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7205 replaced by a boolean. Add boolean 'is_unreachable' field, check
7206 and maintain invariants.
7208 2007-03-25 Marek Safar <marek.safar@gmail.com>
7210 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7212 2007-03-25 Marek Safar <marek.safar@gmail.com>
7214 * expression.cs: Stop using obsolete 2.0 opcodes.
7216 2007-03-25 Marek Safar <marek.safar@gmail.com>
7218 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7219 one of the latests Martin's fixes.
7221 2007-03-23 Miguel de Icaza <miguel@novell.com>
7223 * expression.cs: On BigEndian systems, swap the bytes, temporary
7224 solution until we get a new bitconverter class.
7226 2007-03-23 Martin Baulig <martin@ximian.com>
7230 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7231 "Method" and "Method`1". Normally, a cache lookup is done on the
7232 "Method" form (ie. without the generic arity), but this one makes
7233 lookups on the full form work as well.
7235 2007-03-22 Raja R Harinath <rharinath@novell.com>
7237 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7240 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7242 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7243 ordered_member_list, to TypeBuilder to store members to be defined
7244 in the order they were parsed in.
7245 - ordered_explicit_member_list contains all properties indexers
7246 and methods that are defined as explicit implementation of an
7247 interface or base class.
7248 - ordered_member_list contains all properties indexers and methods
7249 that are not defined as explicit implementation of an interface
7252 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7253 functionality in these removed classes has been replaced with
7254 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7255 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7257 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7258 to CheckForDuplications inside GetMethod and SetMethod Define Method
7259 to handle method property and indexer name conflicts.
7263 All code is contributed under the MIT/X11 license.
7265 2007-03-20 Martin Baulig <martin@ximian.com>
7267 * class.cs (TypeContainer.Interfaces): Removed; they're now
7268 included in `TypeContainer.Types'.
7270 2007-03-20 Martin Baulig <martin@ximian.com>
7272 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7274 * class.cs (TypeContainer.CreateType): New public method. This is
7275 now called before DefineType() to create the TypeBuilders.
7276 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7277 has already been created by CreateType().
7278 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7279 don't resolve our base classes here; this has been moved into
7280 DefineBaseTypes(). We're now called from CreateType().
7281 (TypeContainer.DefineBaseTypes): New private method; resolve our
7282 base classes here. We're now called from DefineType().
7285 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7286 our types first to create all the TypeBuilders. After that, call
7287 TypeContainer.DefineType() on all the types which'll resolve their
7288 base classes and setup the resolve order.
7290 2007-03-20 Martin Baulig <martin@ximian.com>
7292 * class.cs (TypeContainer.Enums): Removed; they're now included in
7293 `TypeContainer.Types'.
7295 2007-03-20 Martin Baulig <martin@ximian.com>
7298 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7299 (TypeContainer.DoResolveMembers): Call DefineType() on our
7300 `compiler_generated' classes; moved here from DefineNestedTypes().
7303 (RootContext.ResolveTree): Call ResolveMembers() on all
7304 TypeContainer's in the `type_container_resolve_order'.
7306 2007-03-19 Marek Safar <marek.safar@gmail.com>
7308 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7310 2007-03-17 Marek Safar <marek.safar@gmail.com>
7312 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7313 implementation flags.
7315 2007-03-17 Marek Safar <marek.safar@gmail.com>
7317 * class.cs: More optimizations for type parameters.
7319 2007-03-15 Marek Safar <marek.safar@gmail.com>
7321 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7323 * ecore.cs, parameter.cs: More common code for both corlibs.
7325 * typemanager.cs (IsGenericMethod): Simplified.
7327 2007-03-15 Raja R Harinath <rharinath@novell.com>
7329 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7331 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7333 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7334 unconditionally. Simplify explanation.
7335 (Try.Resolve, Using.Resolve): Likewise.
7337 2007-03-15 Martin Baulig <martin@ximian.com>
7341 * decl.cs (DeclSpace): If we're a partial class, use our
7342 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7344 2007-03-15 Raja R Harinath <rharinath@novell.com>
7346 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7348 (FlowBranching.UsageVector): Update to changes.
7349 (FlowBranching.MergeSiblings): Likewise.
7350 * statement.cs: Likewise.
7352 2007-03-15 Martin Baulig <martin@ximian.com>
7357 (MemberCache): Added a special .ctor for type parameters.
7360 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7363 2007-03-09 Martin Baulig <martin@ximian.com>
7365 * enum.cs (Enum): Make this a TypeContainer.
7366 (EnumMember): Derive from `Const'.
7369 (Const.DoResolveValue): New protected virtual method; move most of
7370 the functionality of ResolveValue() here so we can override it in
7372 (Const.CreateConstantReference): Make this virtual.
7374 * class.cs (Kind): Add `Kind.Enum'.
7375 (TypeContainer.Emit): Don't emit the enums here; they're already
7376 in the `RootContext.typecontainer_resolve_order'.
7378 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7379 here; they're already in the `typecontainer_resolve_order'.
7381 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7382 TypeManager.DropGenericTypeArguments().
7385 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7386 (TypeManager.IsEnumType): Likewise.
7387 (TypeManager.EnumToUnderlying): Likewise.
7388 (TypeManager.IsEqual): Add support for enums.
7390 2007-03-12 Raja R Harinath <rharinath@novell.com>
7392 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7393 DefaultParameterValueAttribute to be undefined, say if System.dll
7396 2007-03-11 Marek Safar <marek.safar@gmail.com>
7398 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7401 2007-03-10 Marek Safar <marek.safar@gmail.com>
7403 * class.cs, parameter.cs: Unified parameters verification.
7405 2007-03-08 Martin Baulig <martin@ximian.com>
7407 * cs-parser.jay (constructor_header): Pass the location to the
7408 newly created TopLevelBlock.
7410 2007-03-07 Martin Baulig <martin@ximian.com>
7412 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7414 2007-03-06 Miguel de Icaza <miguel@novell.com>
7416 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7417 with the changes from David, fixes the build.
7419 2007-03-05 David Mitchell <dmitchell@logos.com>
7421 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7422 and its base interfaces to a one-dimensional array type S[],
7423 provided there is an implicit or explicit reference conversion
7426 2007-03-03 Marek Safar <marek.safar@gmail.com>
7428 * cs-tokenizer.cs: Implemented basic linq grammar.
7430 * driver.cs: Set linq lang version on demand.
7432 2007-02-26 Marek Safar <marek.safar@gmail.com>
7434 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7436 2007-02-25 Marek Safar <marek.safar@gmail.com>
7438 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7441 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7443 Check property and event extern attributes.
7445 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7448 2007-02-24 Marek Safar <marek.safar@gmail.com>
7450 A fix for bug #80407
7451 * ecore.cs: Don't report ambiguity error when methods have same parent.
7453 2007-02-23 Marek Safar <marek.safar@gmail.com>
7455 A fix for bug #80878
7456 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7458 2007-02-22 Marek Safar <marek.safar@gmail.com>
7460 * attribute.cs: Enable ExtensionAttribute presence test.
7462 2007-02-22 Marek Safar <marek.safar@gmail.com>
7464 * class.cs: Warn about missing GetHashCode only when Equals is override.
7466 * decl.cs: Check accessibility of type arguments.
7468 * typemanager.cs: Correctly report nullable array.
7470 2007-02-20 Marek Safar <marek.safar@gmail.com>
7472 * class.cs, report.cs: Capture more details when things go wrong.
7474 2007-02-20 Marek Safar <marek.safar@gmail.com>
7476 A fix for bug #80650
7477 * cs-parser.jay: Anonymous container starts at constructor declaration
7478 and not at block beginning because it has to be usable in constructor
7481 * statement.cs: Use context location and not block one for error reporting.
7483 2007-02-18 Marek Safar <marek.safar@gmail.com>
7485 A fix for bug #78712
7486 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
7489 2007-02-18 Marek Safar <marek.safar@gmail.com>
7491 A fix for bug #80493 by Atsushi Enomoto
7492 * cs-parser.jay: Ignore invalid attribute target.
7494 2007-02-18 Marek Safar <marek.safar@gmail.com>
7496 * cs-tokenizer.cs: Ignore '\0' as white space character.
7498 2007-02-17 Miguel de Icaza <miguel@novell.com>
7500 * cs-parser.jay: Add support for lambda expressions to the mcs
7503 * lambda.cs: Only clone when we are probing, not on the final call
7504 (Compatible is the final call).
7506 * statement.cs (CloneContext): Introduce class to provide block
7507 remapping during clone.
7509 All statements Clone themselves now.
7511 (Clone): special handling for blocks, when we clone a block, we
7512 register the block inside this routine, as children of the block
7513 might trigger a lookup.
7515 * expression.cs: Add support for CloneContext in all expressions.
7517 2007-02-17 Marek Safar <marek.safar@gmail.com>
7519 A fix for bug #80493
7520 * statement.cs: Report ambiguous warning when interfaces are not related.
7522 2007-02-15 Marek Safar <marek.safar@gmail.com>
7524 C# 3.0 extension methods.
7526 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
7527 cannot be used directly.
7529 * class.cs (Class.Emit): Emit extension attribute if any class method
7530 is extension method.
7531 (Method.Define): Add basic extension method validation conditions.
7532 (Method.Emit): Emit extension attribute for method.
7534 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
7535 extension method exists. Currently we follow same approach as Microsoft
7536 does, emit even if a method or a class are private but this can change
7539 * cs-parser.jay: Add handling of `this' keyword in method parameters
7542 * decl.cs (DeclSpace.IsStaticClass): New property.
7543 (MemberCache.FindExtensionMethods): Looks for extension methods with
7544 defined name and extension type.
7546 * doc.cs: Updated after OverloadResolve changes.
7548 * driver.cs: Add new soft reference to System.Core.dll.
7550 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
7551 (ExtensionMethodGroupExpr): Represents group of extension methods.
7553 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
7554 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
7555 to MethodGroupExpr and made non-static for easier customization.
7556 (Invocation.DoResolve): Add extension method lookup when no standard
7558 (MemberAccess.DoResolve): Try extension methods if no member exists.
7560 * modifiers.cs: Add METHOD_EXTENSION modifier.
7562 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
7563 as well as candidate extension type.
7564 (ComputeNamespaces): When assembly constains extension methods registers
7566 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
7567 extension method lookup.
7568 (Namespace.LookupExtensionMethod): Looks for extension method in this
7570 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
7571 find a method which matches name and extensionType.
7573 * parameter.cs (Parameter): Add This modifer.
7574 (HasExtensionMethodModifier): New property.
7575 (Resolve): Add extension parameter check.
7576 (ModFlags): turned to property to exclude this modifier as it is not real
7578 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
7580 * support.cs (ParameterData): Add ExtensionMethodType.
7581 (ReflectionParameters): Implemented ExtensionMethodType interface property.
7583 * typemanager.cs: Add type and ctor extension attribute type.
7585 2007-02-15 Miguel de Icaza <miguel@novell.com>
7587 * report.cs (DisableErrors, EnableErrors): used to prevent error
7588 output when we are "trying" to compile various methods with
7591 * ecore.cs (Expression): Add Clone method that calls the virtual
7592 CloneTo method. The current CloneTo method in Expression throws
7593 an exception so we can track down all the places where this must
7594 be implemented (not using abstract, because that would be a lot of
7595 up-front-work before we can start testing the implementation
7598 Important: we only need Clone capabilities for expressions created
7599 by the parser, as the expressions we will be cloning are
7600 expressions in the pre-resolved state. This vastly simplifies
7603 (SimpleName): Add CloneTo that does nothing.
7604 (EmptyCast): Add CloneTo.
7606 * expression.cs (Binary): Implement CloneTo.
7607 (Invocation.IsApplicable): Store the current ec in
7608 EmitContext.TempEc and restore it on return. This is used so we
7609 do not have to sprinkle hundres of methods with an extra
7610 EmitContext, we know that the only user is the lambda expression
7611 ImplicitConversionExists code.
7613 (Argument): Add Cloning capabilities.
7614 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
7615 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
7616 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
7617 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
7618 IndexerAccess): Add Clone capability.
7620 (LocalVariableReference, This): TODO: needs cloned Block mapping.
7622 (Argument): Add cloning capability.
7624 * assign.cs (Assign): Implement CloneTo.
7626 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
7628 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
7629 version by calling Convert with the EmitContext (that we are
7630 currently storing in ec, this is not great, but will do for now,
7631 to avoid passing EmitContext parameters to hundreds of functions
7632 that do not need them now).
7634 (SetExpression): Remove, it is not needed.
7636 (ContextualReturn): Implement CloneTo.
7638 * statement.cs (Statement): Implement cloning infrastructure,
7639 similar to expressions.
7641 (Block): Partial implementation of Clone for statements.
7643 (Return): Implement clone.
7645 * constant.cs (Constant.CloneTo): New method, does nothing.
7647 * codegen.cs (TempEc): Add a static EmitContext as a temporary
7648 solution, until we decide how to exactly do this.
7650 2007-02-14 Marek Safar <marek.safar@gmail.com>
7652 A fix for bug #80493
7653 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
7654 a property is override we need to use second accessor.
7656 2007-02-13 Marek Safar <marek.safar@gmail.com>
7658 A fix for bug #80418
7659 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
7662 2007-02-13 Marek Safar <marek.safar@gmail.com>
7664 Another fix for bug #80749
7665 * pending.cs: Abstract class has priority over interfaces.
7667 2007-02-13 Marek Safar <marek.safar@gmail.com>
7669 Another fix for bug #80749
7670 * pending.cs: Abstract class has priority over interfaces.
7672 2007-02-13 Marek Safar <marek.safar@gmail.com>
7674 Another fix for bug #80749
7675 * pending.cs: Abstract class has priority over interfaces.
7677 2007-02-13 Marek Safar <marek.safar@gmail.com>
7679 Another fix for bug #80749
7680 * pending.cs: Abstract class has priority over interfaces.
7682 2007-02-13 Marek Safar <marek.safar@gmail.com>
7684 * class.cs Better error message.
7686 * driver.cs: Add shorter versions of -optimize option.
7688 2007-02-13 Martin Baulig <martin@ximian.com>
7690 * class.cs (Constructor.Emit): Check the return value of
7691 ec.ResolveTopBlock() and return on error.
7693 2007-02-13 Raja R Harinath <rharinath@novell.com>
7695 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
7696 message to fix error message regression.
7698 2007-02-12 Marek Safar <marek.safar@gmail.com>
7700 * delegate.cs: Delegate creation expression cannot be of Nullable type.
7702 2007-02-12 Marek Safar <marek.safar@gmail.com>
7704 A fix for bug #80749
7705 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
7706 its parent container.
7708 * class.cs (DefineFieldInitializers): Each initializer can has different
7711 * const.cs: Updated.
7713 2007-02-11 Miguel de Icaza <miguel@novell.com>
7715 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
7716 now all the heavy lifting to check that embedded statements or
7717 expressions have the right form is done in the ContextualReturn.
7719 (ContextualReturn): New class.
7721 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
7722 method that can be invoked to report 201, so we do not replicate
7725 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
7727 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
7728 treating tabs as spaces.
7730 2007-02-09 Marek Safar <marek.safar@gmail.com>
7732 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
7733 * assign.cs: Use full implicit conversion for right side check.
7735 2007-02-09 Marek Safar <marek.safar@gmail.com>
7737 * statement.cs (Switch): Switch over boolean type is not standardized.
7739 2007-02-08 Marek Safar <marek.safar@gmail.com>
7741 A fix for bug #80755
7742 * decl.cs (FindBaseEvent): Don't use method cache for events.
7744 2007-02-07 Marek Safar <marek.safar@gmail.com>
7746 * cs-parser.jay: Better syntax error handling.
7748 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
7749 instead of underlying type value.
7751 2007-02-06 Marek Safar <marek.safar@gmail.com>
7753 * driver.cs: Check define identifier before is registered.
7755 * namespace.cs: Use existing error message.
7757 * report.cs: New warning.
7759 2007-02-06 Marek Safar <marek.safar@gmail.com>
7761 A fix for bug #80742
7762 * expression.cs: Delegate Invoke method can be called directly.
7764 2007-02-06 Marek Safar <marek.safar@gmail.com>
7766 A fix for bug #80676
7767 * class.cs (IsEntryPoint): The Main method can have params modifier.
7769 2007-02-04 Miguel de Icaza <miguel@novell.com>
7771 * parameter.cs (Parameter, Parameters): Add Clone method.
7773 * anonymous.cs (Compatible): Turn method into virtual method, so
7774 LambdaExpression can implement a different behavior.
7776 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
7777 out the basic checking here, so it can be used by
7780 * lambda.cs: Introduce "Compatible" function that will do the
7783 2007-02-02 Marek Safar <marek.safar@gmail.com>
7785 * attribute.cs: Unified one error message.
7787 * class.cs (Class): Use type attributes and not properties to test static
7789 (IsEntryPoint): Don's pass local variable.
7791 * convert.cs: Removed duplicate check.
7793 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
7795 * driver.cs: Don't crash when soft reference does not exist.
7797 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
7798 (UsingEntry): Removed redundant allocation.
7800 * parameter.cs: Add fast path for type parameters.
7802 * support.cs: Don't allocate attribute when it's not used.
7804 2007-01-30 Miguel de Icaza <miguel@novell.com>
7807 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
7808 this into a virtual method, so we can override it in LambdaExpression.
7810 * driver.cs: Improve diagnostics in case of failure.
7812 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
7813 write a function that is slightly more complex and that parses:
7815 type identifier [, type identifier]* )
7817 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
7820 (canEmpty ? i >= 0 : i > 0)
7822 2007-01-30 Raja R Harinath <rharinath@novell.com>
7824 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
7825 exception on possibly valid code.
7827 2007-01-29 Raja R Harinath <rharinath@novell.com>
7829 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
7831 (parse_opt_type_arguments): Remove. It's almost the same as
7833 (parse_namespace_or_typename): Use parse_less_than.
7835 2007-01-28 Miguel de Icaza <miguel@novell.com>
7837 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
7838 this bug took a few hours to find, because the state saved and
7839 restored by PushPosition and PopPosition was ignoring the state of
7840 parse_generic_less_than.
7842 I can also now remove the handling of OP_LT and OP_GT, this solves
7845 * cs-tokenizer.cs: store the location for the ARROW token, we use
7848 (PushPosition, PopPosition): save/restore also `current_token',
7849 restore `parse_generic_less_than' (was missing).
7851 (parse_opt_type_arguments): use parse_type, not
7852 parse_namespace_or_typename to parse types.
7854 * lambda.cs: Empty new file, will eventually have the lambda
7855 expression implementation.
7857 * lambda.test: used to test the internal tokenizer.
7859 * report.cs (FeatureIsNotISO1): Rename from
7860 FeatureIsNotStandardized, because it was about the language level
7861 (1 vs 2) it was not about standarization.
7863 (FeatureRequiresLINQ): New.
7865 * support.cs (SeekableStreamReader): Only require that the reader
7866 is a TextReader, not a StreamReader, so we can plug StringReader.
7868 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
7869 given position in the input stream the following tokens can be
7870 parsed as a type followed by an identifier.
7872 (is_punct): after a '(' if parse_type_and_parameter returns true,
7873 then return a special token OPEN_PARENS_LAMBDA which is used to
7874 avoid reduce/reduce errors in the grammar for the
7875 lambda_expression rules.
7877 (parse_type): implement a type parser inside the
7878 tokenizer, the parser only returns true or false depending on
7879 whether the input at a given position can be parsed as a type.
7881 (peek_token): new method used during type parsing.
7883 2007-01-28 Raja R Harinath <rharinath@novell.com>
7886 * anonymous.cs (ScopeInfo.InflateParameters): New.
7887 (AnonymousContainer.Resolve): Use it to redirect types of
7888 delegate parameters.
7890 2007-01-27 Raja R Harinath <rharinath@novell.com>
7893 * expression.cs (Error_InvalidArguments): Don't use two different
7894 messages for CS1503. Use ExtraInformation and
7895 SymbolRelatedToPreviousError instead.
7898 * decl.cs (DeclSpace.initialize_type_params): Don't access
7899 'type_params' of a partial class directly.
7901 2007-01-26 Miguel de Icaza <miguel@novell.com>
7903 * constant.cs: Removed a handful of out-of-range checks that were
7906 2007-01-25 Marek Safar <marek.safar@gmail.com>
7908 * expression.cs (CheckUselessComparison): Add additional check for char
7911 * namespace.cs: Fixed typo.
7913 2007-01-23 Miguel de Icaza <miguel@novell.com>
7915 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
7916 gone, instead we inline the test, preventing the needless casts to
7917 longs, ulongs and doubles for the parameters, avoiding calls to
7918 methods that overchecked stuff, and instead inlined things
7921 2007-01-20 Marek Safar <marek.safar@gmail.com>
7923 * cs-parser.jay: Better parameter error handling.
7925 2007-01-17 Marek Safar <marek.safar@gmail.com>
7927 A fix for bug #80368, #80522
7928 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
7929 whether array initializer contains constants only.
7930 (ArrayCreation.Emit): Use better formula to decide when
7931 are array initializers for static initialization.
7932 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
7933 have to emit even constants otherwise they are pre-initialized.
7935 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
7936 Raja R Harinath <rharinath@novell.com>
7938 Fix emit order of 'get' vs. 'set'.
7939 * support.cs (Accessors): New.
7940 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
7941 Note the order in which accessors are declared in the source.
7942 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
7943 Refactored from Property.Define and Indexer.Define.
7944 (PropertyBase.DefineAccessors): New helper that calls the above in
7945 appropriate order as noted by the parser.
7946 (Property.Define, Indexer.Define): Update to changes.
7947 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
7949 2007-01-17 Raja R Harinath <rharinath@novell.com>
7951 Fix cs0029-6.cs and gcs0029-2.cs (regression)
7952 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
7953 there's an implicit conversion from the current type to the target
7954 type before converting the underlying constant.
7956 2007-01-16 Marek Safar <marek.safar@gmail.com>
7958 * const.cs (ResolveValue): Updated after constant conversion was made more
7961 * constant.cs (GetAttributableValue): constant to object conversion is
7962 used for attributes only.
7963 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
7964 constant conversions.
7965 (LongConstant.ConvertImplicitly): Ditto.
7967 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
7968 (ImplicitConversionStandard): Handle constant conversion as extra step.
7969 It solves the issue when constant conversion was called indirectly like
7970 inside array initializer and constant folding was skipped.
7972 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
7975 * statement.cs(ImplicitConversionStandard): Updated after constant
7976 conversion was made more generic.
7978 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
7980 * expression.cs (As.DoResolve): Use GenericConstraints instead of
7981 Constraints, solves the problem where the compiler incorrectly
7982 reported that a type parameter was not constrained to a class (Bug
7985 2007-01-14 Marek Habersack <grendello@gmail.com>
7987 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
7989 2007-01-14 Marek Safar <marek.safar@gmail.com>
7991 A fix for bug #80368
7992 * assign.cs (FieldInitializer): New class implements field
7993 initializer statement.
7995 * attribute.cs: Update after FieldMember rename.
7997 * class.cs (PropertyBasedMember): New common class for property based
7999 (InterfaceMemberBase): New base class for all members which can be used as
8000 an interface members.
8001 (MethodCore): Moved really common code to InterfaceMemberBase.
8002 (Method.Define): Equal and GetHasCode detection is relevant for methods
8004 (MethodData.Define): Don't assume that public event implements an
8005 interface automatically.
8006 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8008 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8009 (FieldMember): Merged with FieldBase.
8010 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8011 event extern modifier can be used.
8012 (EventField.EventFieldAccessor): Moved event field specific code here.
8013 (Event.AllowedModifiers): Even event can be extern.
8014 (Event.FindOutBaseMethod): New override specific to events.
8015 (Indexer.parameters): Reintroduce parameters because base class holds
8016 only properties common data.
8017 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8018 need do extra parameters check.
8020 * const.cs: Update after FieldMember rename.
8022 * decl.cs (MemberCache.FindBaseEvent): New method.
8024 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8025 to reflect that indexer is now derived from PropertyBased.
8027 * ecore.cs (GetMemberType): Made public.
8028 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8031 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8033 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8034 (RegisterEvent): Removed.
8035 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8036 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8038 2007-01-11 Raja R Harinath <rharinath@novell.com>
8041 * statement.cs (CollectionForeach.TryType): Prefer generic
8042 GetEnumerator over non-generic variant. Fix code to follow comments.
8044 2007-01-09 Raja R Harinath <rharinath@novell.com>
8047 * support.cs (ReflectionParameter): Don't use an invalid index on
8048 the generic parameter data.
8050 2007-01-08 Miguel de Icaza <miguel@novell.com>
8052 * driver.cs: Just add a tiny bit of infrastructure.
8054 2007-01-02 Marek Safar <marek.safar@gmail.com>
8056 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8057 where field type is struct from current assembly.
8059 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8062 2007-01-02 Marek Safar <marek.safar@gmail.com>
8064 A fix for bug #80381
8065 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8068 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8070 (Namespace.LookupType): Always use core types from corlib when speficied.
8072 * report.cs: A new warning.
8074 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8075 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8076 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8078 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8079 (InitCoreTypes): Set expression type of object_type and value_type
8080 immediately after lookup.
8082 2007-01-01 Miguel de Icaza <miguel@novell.com>
8084 * cs-tokenizer.cs: Accept Pc class characters (Connector
8085 Punctuation) as valid identifiers. Fixes #78259
8087 * expression.cs (Invocation.DoResolve): Moved the check for the
8088 use of `this' for doing method calls to the Invocation resolution
8089 step, after overload resolution has taken place instead of doing
8090 the check at the low-level `This.DoResolve' level.
8092 The `This.DoResolve'(appens before overload resolution, so it has
8093 no way of knowing if the method that will be called will be
8094 instace or static, triggering an erroneous report for cs0188 (Bug
8097 We now do the check for instance method invocations after we know
8098 what method will be called.
8100 (This.CheckThisUsage): Move the actual use of this structure
8101 checking into its own method and expose it.
8103 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8106 Exceptions: Null.ConvertImplicitly,
8107 Constant.ImplicitConversionRequired as there are too many call
8108 sites for passing the ec.
8110 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8111 EmitContext, if the value is null, then we do not try to provide
8112 the extra information from the error (If a userdefined conversion
8113 exists, as UserDefinedConversion requires a non null-EmitContext).
8117 2006-12-30 Raja R Harinath <rharinath@novell.com>
8119 * flowanalysis.cs (MyBitVector): Document some invariants.
8120 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8121 introduced below, and add a couple of others,
8123 2006-12-30 Marek Safar <marek.safar@gmail.com>
8125 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8126 GetPropertyFromAccessor and GetEventFromAccessor.
8128 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8129 overrides non-obsolete one.
8130 (Indexer.Define): Error message has been moved to the parser.
8132 * cs-parser.jay: Better syntax errors handling.
8134 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8135 when an invocation has no arguments.
8137 * ecore.cs: Removed not used caching.
8139 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8142 * report.cs: Add a new warning.
8144 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8146 * typemanager.cs (enumeration_type): Removed.
8147 (CSharpSignature): Reuses IsSpecialMethod.
8148 (IsEqual): Hack for MS BCL.
8149 (GetPropertyFromAccessor): New method.
8150 (GetEventFromAccessor): New method.
8151 (IsSpecialMethod): Fixed to handle more cases.
8153 2006-12-30 Marek Safar <marek.safar@gmail.com>
8155 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8156 Made white spaces array static.
8158 * ecore.cs (RemoveGenericArity): Optimized.
8160 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8162 (MyBitVector.initialize_vector): Simplified.
8164 2006-12-22 Miguel de Icaza <miguel@novell.com>
8166 * ecore.cs: Am not entirely happy with this hack, but it seems to
8167 address the issue in 80257 (a small test case for
8170 I set the MethodGroupExpr.Type to an internal compiler type
8171 (itself in this case) to force the resolution to take place. Why
8172 it does not take place with a null is beyond me.
8174 2006-12-20 Marek Safar <marek.safar@gmail.com>
8176 A fix for bug #80288
8177 * expression.cs (ResolveOperator): Consider user defined conversion for
8178 logical and operator too.
8179 (EmitBranchable): Optimization for logical and when full constant folding
8180 could not be applied but one operand is constant.
8182 2006-12-19 Marek Safar <marek.safar@gmail.com>
8184 * class.cs (GetClassBases): Write 5 times every day, will never use
8185 FullName for error reporting.
8187 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8189 2006-12-19 Martin Baulig <martin@ximian.com>
8191 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8192 the symbol file info here.
8194 2006-12-18 Marek Safar <marek.safar@gmail.com>
8196 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8197 of `elseif' is taking then following sections are not taking.
8198 Fixes an issue reported on mono mailing list.
8200 2006-12-18 Marek Safar <marek.safar@gmail.com>
8202 A fix for bug #80300
8203 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8204 a caller is not taking.
8206 2006-12-18 Raja R Harinath <rharinath@novell.com>
8208 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8209 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8210 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8211 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8212 * class.cs: Update to changes.
8214 2006-12-17 Marek Safar <marek.safar@gmail.com>
8216 A fix for bug #79934
8217 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8220 * class.cs (ResolveMembers): Register an iterator in current container and
8223 2006-12-16 Raja R Harinath <rharinath@novell.com>
8226 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8227 satisfy a params annotated parameter.
8229 2006-12-16 Marek Safar <marek.safar@gmail.com>
8231 A fix for bug #77014
8232 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8233 paramters correctly and not rely on hacks in Parameters class.
8234 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8236 (Invocation.VerifyArgumentsCompat): Ditto.
8237 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8240 * parameter.cs (HasParams): Don't assume that params is the last one.
8242 * support.cs (ReflectionParameters.ctor): Look for params attribute
8244 (ReflectionParameters.ParameterType): Removed hack when we returned last
8245 parameter for out of range parameters.
8246 (ParameterName, ParameterModifier): Ditto.
8248 2006-12-14 Marek Safar <marek.safar@gmail.com>
8250 A fix for bug #79987
8251 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8252 when assembly is not CLS compliant but type is. I have no idea why is this
8255 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8257 2006-12-13 Miguel de Icaza <miguel@novell.com>
8259 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8260 in struct constructors, they are basically no-ops.
8262 2006-12-12 Marek Safar <marek.safar@gmail.com>
8264 * cs-tokenizer.cs (Position): Save preprocessor status too.
8266 2006-12-12 Marek Safar <marek.safar@gmail.com>
8268 A fix for bug #77794
8269 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8271 2006-12-12 Marek Safar <marek.safar@gmail.com>
8273 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8275 (pp_expr): Report error for an invalid expression.
8276 (handle_preprocessing_directive): Simplified; add more error checking.
8278 2006-12-11 Marek Safar <marek.safar@gmail.com>
8280 A fix for bug #74939
8281 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8282 directives handling.
8284 2006-12-10 Marek Safar <marek.safar@gmail.com>
8286 A fix for bugs #80093, and #75984
8287 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8288 logic, it seems to me as it worked before "by coincidence".
8289 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8290 (cleanup): Enabled endif check.
8292 2006-12-09 Marek Safar <marek.safar@gmail.com>
8294 A fix for bug #80162
8295 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8296 enumerators are never ambiguous.
8298 2006-12-08 Raja R Harinath <rharinath@novell.com>
8301 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8303 2006-12-06 Marek Safar <marek.safar@gmail.com>
8305 A fix for bug #80144
8306 * class.cs (EventProperty.Define): Explicit implementation means
8307 that an even is used.
8309 2006-12-06 Marek Safar <marek.safar@gmail.com>
8311 Fixes the operators implementation (part II)
8313 * cfold.cs (DoConstantNumericPromotions): Renamed to
8314 DoBinaryNumericPromotions and simplified.
8315 (BinaryFold): Couple of conversion fixes; simplified.
8317 * constant.cs, ecore.cs, literal.cs
8318 (ToType): Renamed to ConvertImplicitly.
8319 (Reduce): Renamed to ConvertExplicitly.
8321 * class.cs, convert.cs: Updated.
8323 * expression.cs: TryReduce doesn't throw an exception.
8325 2006-12-01 Marek Safar <marek.safar@gmail.com>
8327 A fix for bug #80108
8328 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8331 2006-11-30 Marek Safar <marek.safar@gmail.com>
8333 Fixes unary operators implementation (part I)
8336 * cfold.cs (Error_CompileTimeOverflow): Made internal
8338 * const.cs (IConstant): Changed to use reference to constant and
8339 not constant itself.
8340 Updated IConstant implementations.
8342 * constant.cs (CreateConstant): New factory method.
8343 Updated IConstant implementation.
8345 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8347 * ecore.cs: Updated to use CreateConstantReference.
8349 * enum.cs: Reflects IConstant changes.
8351 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8353 * literal.cs (NullConstant): Change to be independently usable.
8355 2006-11-29 Martin Baulig <martin@ximian.com>
8357 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8358 we need to emit the scope initializer before calling the base .ctor.
8360 * anonymous.cs: Merged back from the new anonymous methods branch.
8361 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8363 * expression.cs (ParameterReference.DoResolveBase): Create a
8364 "normal" ScopeInfo when capturing parameters rather than using the
8365 root scope; this makes things work with anonymous methods having
8369 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8371 2006-11-22 Marek Safar <marek.safar@gmail.com>
8373 A fix for bug #79987
8374 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8375 check to a base class.
8376 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8377 only when assembly has missing attribute.
8378 * report.cs: Update.
8380 2006-11-21 Marek Safar <marek.safar@gmail.com>
8382 * cs-tokenizer.cs: Merged with gmcs version.
8384 2006-11-20 Marek Safar <marek.safar@gmail.com>
8387 * cs-parser.jay: Better error message when partial keyword is misplaced.
8389 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8391 A fix for bug #79810
8392 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8393 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8394 a RuntimeWrappedException by default.
8396 2006-11-18 Marek Safar <marek.safar@gmail.com>
8398 A fix for bug #79843
8399 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8401 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8403 2006-11-18 Marek Safar <marek.safar@gmail.com>
8405 * driver.cs, namespace.cs: Uses faster IndexOf version.
8407 2006-11-17 Marek Safar <marek.safar@gmail.com>
8409 A fix for bug #79941
8410 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8412 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8413 even if internal name is different.
8414 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8415 (UserDefinedConversion): Simplified as the operators cannot be internal.
8416 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8418 (MethodLookup): Replaced EmitContext with parentType.
8419 * expression.cs: Updated.
8421 2006-11-09 Raja R Harinath <rharinath@novell.com>
8423 * driver.cs (BadAssembly): Handle all the ugliness of
8424 DefineDynamicAssembly.
8426 2006-11-08 Raja R Harinath <rharinath@novell.com>
8428 Address parts of #58244 -- most of what's left is in the runtime
8429 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8430 CS1509 error checks, and handle them for all assembly loads, not
8431 just the first invocation.
8432 (LoadModule): Likewise. Move handling of 'adder_method' ...
8433 * codegen.cs (AssemblyClass.AddModule): ... here.
8435 2006-11-02 Marek Safar <marek.safar@gmail.com>
8437 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8438 IEnumerable<T> is ambiguous.
8440 2006-10-31 Marek Safar <marek.safar@gmail.com>
8442 A fix for bug #67689
8443 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8444 GetEnumerator is ambiguous.
8446 * report.cs: Add new warning.
8448 2006-10-29 Marek Safar <marek.safar@gmail.com>
8450 A fix for bug #78602
8451 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8452 to protected member can be nested type.
8454 2006-10-28 Marek Safar <marek.safar@gmail.com>
8456 A fix for bug #78965
8457 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8458 to protected member must derive from current type.
8460 2006-10-27 Marek Safar <marek.safar@gmail.com>
8462 assign.cs: Reuses error method.
8464 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8465 instead of type for constants.
8466 (Expression.Error_ValueAssignment): Common error method.
8468 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8471 2006-10-27 Marek Safar <marek.safar@gmail.com>
8473 A fix for bug #79081
8474 * expression.cs (MemberAccess.DoResolve): Check nested type
8477 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8479 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8481 2006-10-26 Marek Safar <marek.safar@gmail.com>
8483 A fix for bug #76591
8484 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
8486 2006-10-26 Marek Safar <marek.safar@gmail.com>
8488 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
8489 type forwarder of the same type multiple times.
8491 2006-10-26 Raja R Harinath <rharinath@novell.com>
8494 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
8495 instance as an rvalue, even when we later resolve as an lvalue.
8497 2006-10-25 Martin Baulig <martin@ximian.com>
8499 * anonymous.cs: Fix #79673.
8501 2006-10-24 Marek Safar <marek.safar@seznam.cz>
8503 A fix for bug #79666
8504 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
8505 ignored when is optimized (= default value) as its value is already set.
8507 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8509 A fix for bug #79724
8510 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
8511 TypeContainer for type lookup.
8513 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8515 A fix for bug #79231
8516 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
8517 * expression.cs (OverloadResolve): Always convert type name for
8519 (ResolveNamespaceOrType): Don't confuse a nested type with any
8522 2006-10-18 Martin Baulig <martin@ximian.com>
8524 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
8526 2006-10-17 Miguel de Icaza <miguel@novell.com>
8528 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
8529 an int32, but requesting an int64 from the conversion
8531 2006-10-12 Martin Baulig <martin@ximian.com>
8534 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
8536 2006-10-12 Martin Baulig <martin@ximian.com>
8539 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
8541 2006-10-11 Miguel de Icaza <miguel@novell.com>
8543 * convert.cs: Remove broken code: I was doing the "Existance"
8544 tests for Implicit conversions.
8546 2006-10-10 Miguel de Icaza <miguel@novell.com>
8548 * convert.cs: Added one missing case in
8549 ImplicitStandardConversionExists uint64 to intptr.
8553 * typemanager.cs (uintptr_type): another core known type.
8555 * ecore.cs (OperatorCast): routine used to do cast operations that
8556 depend on op_Explicit. We could change some of the Decimal
8557 conversions to use this.
8559 This one has a probe mechanism that checks both types for an op_
8560 which it coudl be used to eliminate two classes: CastToDecimal
8561 and CastFromDecimal.
8563 * convert.cs: Implement the conversions documented in #59800
8565 2006-10-10 Martin Baulig <martin@ximian.com>
8567 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
8568 before RootScope.ResolveMembers().
8570 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
8571 `CurrentType' if appropriate.
8573 2006-10-09 Marek Safar <marek.safar@seznam.cz>
8575 A fix for bug #78568
8576 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
8577 when contains binary operators.
8578 * cs-parser.jay: Updated.
8580 2006-10-09 Martin Baulig <martin@ximian.com>
8583 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
8584 moved that into Define() and also do the other type parameter
8585 checks there. Fixes #79094. Added gtest-292.cs.
8588 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
8589 since that doesn't include type parameters; don't use `Ldelema'
8590 for type parameters. Fixes #78980. Added gtest-293.cs.
8592 2006-10-08 Marek Safar <marek.safar@seznam.cz>
8595 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
8596 conversion is allowed.
8598 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8600 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
8601 error reporting when no error occurs.
8603 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8605 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
8608 2006-10-06 Raja R Harinath <rharinath@novell.com>
8611 * class.cs (DefineTypeBuilder): Check circular dependencies before
8612 setting the parent of the TypeBuilder.
8613 (CheckRecursiveDefinition): Don't use 'BaseType', since
8614 it may not be valid until after DefineTypeBuilder. Use
8615 'base_type' instead.
8617 2006-10-04 Martin Baulig <martin@ximian.com>
8619 Merged the Anonymous Methods patch.
8621 * anonymous.cs, iterators.cs: The new anonymous methods code.
8623 * statement.cs (Variable): New public abstract class.
8624 (LocalInfo.Variable): New public property.
8625 (LocalInfo.ResolveVariable): New public method.
8626 (Block.Flags): Add `IsIterator'.
8627 (Block.AddVariable): Improved the CS0136 check.
8628 (Block.AnonymousChildren): New public property.
8629 (Block.AddAnonymousChild): New public method.
8630 (ToplevelBlock): Update to use the new anonymous method framework.
8631 (ToplevelBlock.ctor): `container' is now a `Block' and not a
8632 `ToplevelBlock'; this is required to correctly implement the
8634 (Fixed, Using): Use `TemporaryVariable' instead of directly
8635 creating the `LocalBuilder'.
8637 * parameter.cs (Parameter.ResolveVariable): New public method.
8638 (Parameters.ResolveVariable): Likewise.
8640 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
8642 * class.cs (TypeContainer): Replaced the `iterators' list and
8643 corresponding methods with a list of `CompilerGeneratedClass'es.
8644 (TypeContainer.ResolveMembers): New public method.
8645 (Method): `IIteratorContainer' has been replaced by
8648 * expression.cs (VariableReference): New public abstract base
8649 class for `LocalVariableReference', `ParameterReference' and
8652 * codegen.cs (EmitContext): Removed `capture_context',
8653 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
8654 (EmitContext.EmitThis): Removed.
8656 * cs-parser.jay: Replace `iterator_container' with
8659 2006-10-04 Martin Baulig <martin@ximian.com>
8661 * generic.cs (GenericMethod): Don't make this abstract.
8662 (Constraints.Clone): Added dummy implementation.
8664 2006-10-04 Raja R Harinath <harinath@gmail.com>
8667 * namespace.cs (LookForAnyGenericType): Avoid nullref on
8668 'declspaces'. Avoid allocating arrays willy-nilly.
8671 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
8672 cases out of the switch.
8674 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8676 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
8677 message when non-generic type is used with the type arguments.
8678 * expression.cs: Updated.
8680 2006-09-28 Raja R Harinath <rharinath@novell.com>
8683 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
8684 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8685 Change semantics slightly. Don't insist on having only one
8686 temporary EmptyExpression -- just throttle the creation of new ones.
8689 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
8690 non-interfaces too. If no methods are found, don't try to create
8693 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8695 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
8698 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
8699 us produce better error message.
8701 2006-09-27 Marek Safar <marek.safar@seznam.cz>
8703 * expression.cs (Binary.ResolveOperator): Warn about a side effect
8704 of the `|' operator.
8706 * report.cs: A new warning added.
8708 2006-09-27 Martin Baulig <martin@ximian.com>
8710 * generic.cs (GenericMethod): Don't make this abstract.
8712 2006-09-27 Martin Baulig <martin@ximian.com>
8715 (InternalErrorException): Added overloaded ctor taking a params array.
8717 2006-09-26 Marek Safar <marek.safar@seznam.cz>
8719 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
8720 Fixed the cases when same error was reported twice.
8722 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
8723 now report symbol information.
8725 2006-09-25 Martin Baulig <martin@ximian.com>
8727 * class.cs: Completely unified with the gmcs version.
8729 2006-09-25 Martin Baulig <martin@ximian.com>
8731 * typemanager.cs (TypeManager.IsNullableType): New public function.
8732 (TypeManager.IsNullableTypeOf): Likewise.
8733 (TypeManager.IsNullableValueType): Likewise.
8735 * class.cs (MethodCore): Added the `GenericMethod' argument from
8736 gmcs and also unified all classes derived from `MethodCore' with gmcs.
8738 2006-09-24 Raja R Harinath <harinath@gmail.com>
8740 * convert.cs: Unify with gmcs version.
8742 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8744 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
8745 verify them as well.
8747 * report.cs: New warning.
8749 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8751 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
8752 for anonymous block with out argument.
8754 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8756 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
8757 not used private events only.
8759 2006-09-23 Marek Safar <marek.safar@seznam.cz>
8761 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
8763 * const.cs (Const.Define): Check for constant type.
8764 (Const.IsConstantTypeValid): Looks for valid constant types.
8766 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
8768 * ecore.cs (EmptyConstantCast): New common class for all constant based
8771 * expression.cs (Is.DoResolve): Handle null constant especially.
8772 (New.DoResolve): Check for new void().
8773 (MemberAccess.DoResolve): Cope with all kind of nulls.
8775 * literal.cs (NullConstant): Uses EmptyConstantCast.
8776 (NullDefault): Based on EmptyConstantCast.
8777 (NullLiteral): Uses EmptyConstantCast.
8779 * statement.cs (Block.ResolveMeta): Check for constant type.
8781 2006-09-22 Martin Baulig <martin@ximian.com>
8783 * delegate.cs, attribute.cs: Merged with the gmcs versions.
8785 2006-09-22 Raja R Harinath <rharinath@novell.com>
8787 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
8791 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
8792 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
8795 2006-09-22 Martin Baulig <martin@ximian.com>
8797 * ecore.cs: Merged with the gmcs version.
8799 * generic.cs (ConstructedType): New dummy class.
8800 (TypeArguments): Don't make this abstract.
8803 (TypeManager.IsGenericTypeDefinition): New method.
8804 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
8806 2006-09-22 Raja R Harinath <rharinath@novell.com>
8808 * expression.cs (ComposedCast): Check for arrays of TypedReference
8809 before creating the type, not after.
8811 2006-09-21 Marek Safar <marek.safar@seznam.cz>
8813 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
8814 after ToType change.
8816 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
8817 when constant must be implicitly convertible.
8819 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
8821 * ecore.cs (NullCast): Derives from NullConstant.
8823 * expression.cs (Is.DoResolve): Removed useless variables.
8824 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
8825 (New.Constantify): Add enum support.
8826 (MemberAccess.DoResolve): Add warning when accessing null constant or
8829 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
8832 * literal.cs (NullConstant): New abstract class with common
8833 functionality for all null specializations.
8834 (NullDefault): Represents default(X) when result can be
8836 (NullLiteral): Updated.
8838 * report.cs: Add new warning.
8840 2006-09-21 Martin Baulig <martin@ximian.com>
8842 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
8844 2006-09-21 Martin Baulig <martin@ximian.com>
8846 * generic.cs (GenericConstraints): New dummy class.
8847 (Constraints): Likewise.
8848 (TypeParameter): Likewise.
8849 (TypeParameterName): Likewise.
8850 (GenericMethod): Likewise.
8852 * typemanager.cs (TypeManager.GetGenericArguments): New method.
8854 * decl.cs: Merged with the gmcs version.
8856 2006-09-21 Raja R Harinath <rharinath@novell.com>
8858 * generic.cs (TypeParameter): Implement IMemberContainer.
8859 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
8861 * rootcontext.cs: Unify with gmcs version.
8863 * report.cs: Unify with gmcs version.
8864 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
8865 from gmcs/generics.cs.
8866 * generics.cs (TypeParameter): New dummy class.
8868 * support.cs: Unify with gmcs version.
8870 2006-09-20 Raja R Harinath <rharinath@novell.com>
8872 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
8873 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
8875 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
8876 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
8877 * mcs.exe.sources: Add generic.cs.
8879 * codegen.cs: Unify with gmcs version.
8881 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
8882 (EmitContext): Add GenericDeclContainer implementation.
8883 * decl.cs (MemberCore, DeclSpace): Likewise.
8884 * namespace.cs: Remove #ifdef GMCS_SOURCE.
8886 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
8887 MCS TypeManager has a corresponding dummy method.
8889 2006-09-19 Martin Baulig <martin@ximian.com>
8891 * expression.cs: Completely merged with the gmcs version.
8893 2006-09-19 Martin Baulig <martin@ximian.com>
8895 * expression.cs (Invocation): Merged with the gmcs version.
8896 (ArrayAccess.GetStoreOpcode): Likewise.
8898 2006-09-19 Martin Baulig <martin@ximian.com>
8901 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
8902 (TypeManager.IsGenericMethodDefinition): Likewise.
8904 2006-09-19 Martin Baulig <martin@ximian.com>
8907 (TypeManager.IsEqual): Moved the gmcs implementation here.
8908 (TypeManager.DropGenericTypeArguments): Likewise.
8909 (TypeManager.DropGenericMethodArguments): Likewise.
8910 (TypeManager.GetTypeArguments): Moved here from gmcs.
8911 (TypeManager.HasGenericArguments): Likewise.
8913 2006-09-19 Martin Baulig <martin@ximian.com>
8915 * expression.cs (Binary): Merged with the gmcs version.
8917 2006-09-19 Martin Baulig <martin@ximian.com>
8919 * expression.cs (Probe, As, Is): Merged with the gmcs version.
8921 2006-09-19 Martin Baulig <martin@ximian.com>
8923 * typemanager.cs: Merged with the gmcs version.
8925 2006-09-16 Raja R Harinath <rharinath@novell.com>
8927 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
8928 * driver.cs: Likewise.
8930 2006-09-16 Marek Safar <marek.safar@seznam.cz>
8933 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
8934 only if parent type is class.
8935 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
8938 2006-09-15 Marek Safar <marek.safar@seznam.cz>
8941 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
8943 * typemanager.cs(CSharpName): Converts NullType to null.
8945 2006-09-15 Martin Baulig <martin@ximian.com>
8948 (TypeManager.GetMethodName): Added mcs implementation.
8949 (TypeManager.IsEqual): Likewise.
8952 (SimpleName.RemoveGenericArity): Added dummy implementation.
8954 * pending.cs: Merged with the gmcs version.
8956 2006-09-15 Martin Baulig <martin@ximian.com>
8958 * statement.cs: Merge with the gmcs version.
8960 2006-09-15 Martin Baulig <martin@ximian.com>
8962 * statement.cs (Switch): Merge with the gmcs implementation
8963 (without nullables), which is newer.
8965 2006-09-15 Martin Baulig <martin@ximian.com>
8967 * statement.cs (Block.Variables): Make this public.
8968 (ToplevelBlock.Parameters): Make this a property.
8969 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
8971 2006-09-15 Martin Baulig <martin@ximian.com>
8973 * namespace.cs: Merge with the gmcs version.
8975 2006-09-15 Martin Baulig <martin@ximian.com>
8977 * decl.cs (MemberName): Minor code cleanups.
8979 2006-09-15 Martin Baulig <martin@ximian.com>
8981 * parameter.cs: Merge with the gmcs version.
8983 2006-09-15 Martin Baulig <martin@ximian.com>
8985 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
8986 and an error in mcs.
8988 2006-09-15 Martin Baulig <martin@ximian.com>
8990 * flowanalysis.cs: Merged from GMCS; added the generics code into
8991 a `GMCS_SOURCE' conditional so we can share this file.
8993 2006-09-08 Martin Baulig <martin@ximian.com>
8995 * typemanager.cs (TypeManager.interlocked_type): New public field.
8996 (TypeManager.int_interlocked_compare-exchange): New public field.
8997 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
8998 enumerator types here and call InitGenericCoreTypes().
8999 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9000 after calling InitEnumUnderlyingTypes().
9003 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9004 `classes_second_stage'.
9006 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9008 * assign.cs, ecore.cs, expression.cs: Share error message text.
9009 * class.cs (FieldMember.Define): Check for varible of static type.
9010 * driver.cs (LoadAssembly): Uses error output for errors.
9011 * statement.cs: Updated.
9013 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9015 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9018 2006-09-07 Martin Baulig <martin@ximian.com>
9021 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9023 2006-08-29 Miguel de Icaza <miguel@novell.com>
9025 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9027 2006-08-17 Miguel de Icaza <miguel@novell.com>
9029 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9030 #52019 and #79064, the use of the \uXXXX sequence in source code
9031 to represent unicode characters.
9033 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9035 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9037 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9039 2006-08-13 Miguel de Icaza <miguel@novell.com>
9041 * assign.cs: Catch attempts to assign to a method groups in += and
9044 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9047 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9049 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9051 * class.cs (Method.Define): Issue a warning when generic method looks like
9053 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9056 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9058 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9060 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9061 search all base interfaces as a member can be ambiguous.
9062 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9063 Constructor member type filter.
9064 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9065 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9066 reporting for returned memberinfos.
9067 * report.cs: Updated.
9068 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9069 version to work on all runtimes.
9070 (TypeManager.RealMemberLookup): Removed members filtering.
9072 2006-08-08 Raja R Harinath <rharinath@novell.com>
9074 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9075 (PropertyExpr.EmitAssign): Likewise.
9076 * expression.cs (Indirection.EmitAssign): Likewise.
9077 (LocalVariableReference.EmitAssign): Likewise.
9078 (ParameterReference.EmitAssign): Likewise.
9079 (Invocation.EmitArguments): Likewise.
9080 (ArrayAccess.EmitAssign): Likewise.
9081 (IndexerAccess.EmitAssign): Likewise.
9082 (This.EmitAssign): Likewise.
9083 (ConditionalLogicalOperator.Emit): Likewise.
9086 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9087 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9088 leave it in after returning it.
9089 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9091 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9093 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9096 2006-08-03 Raja R Harinath <rharinath@novell.com>
9098 Fix cs0146-3.cs and cs0146-4.cs.
9099 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9100 enclosing types don't depend on the current type.
9102 2006-08-02 Raja R Harinath <rharinath@novell.com>
9105 * class.cs (TypeContainer.DoDefineMembers): Use
9106 FindBaseMemberWithSameName on Parent, since we're interested in
9107 whether we hide inherited members or not.
9108 (FindBaseMemberWithSameName): Make slightly more robust.
9110 Fix the non-generic testcase from #77396
9111 * decl.cs (DeclSpace.DeclContainer): Remove override.
9113 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9114 declspaces for doppelgangers too.
9115 (UsingEntry): Implement IResolveContext.
9116 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9117 'this' as the resolve context.
9118 (LocalAliasEntry): Likewise.
9120 Implement parts of #77403
9121 * roottypes.cs (RootDeclSpace): New. Used to represent the
9122 toplevel declaration space. Each namespace declaration introduces
9123 a "partial" root declaretion space.
9124 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9125 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9126 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9127 from 'current_namespace.SlaveDeclSpace'.
9128 (namespace_declaration): Likewise.
9129 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9130 check. It can't happen now.
9131 * decl.cs (DeclSpace.LookupType): Likewise.
9132 * driver.cs (MainDriver): Sanity check.
9134 2006-08-01 Raja R Harinath <rharinath@novell.com>
9136 * decl.cs (DeclSpace.FindNestedType): Remove.
9137 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9138 LookupTypeContainer to get the container of the nested type.
9139 * class.cs (TypeContainer.FindNestedType): Make non-override.
9141 2006-07-31 Raja R Harinath <rharinath@novell.com>
9143 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9144 * class.cs (TypeContainer.PartialContainer): ... here.
9145 (TypeContainer.AddBasesForPart): New helper.
9146 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9148 * cs-parser.jay (current_class): Convert to DeclSpace.
9149 (struct_declaration, interface_declaration, class_declaration):
9150 Use AddBasesForPart instead of .Bases directly.
9151 * const.cs, iterators.cs: Update to changes.
9153 2006-07-28 Raja R Harinath <rharinath@novell.com>
9155 * class.cs (TypeContainer.AddMemberType): Rename from
9157 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9158 (AddTypeContainer): New. Combine AddClassOrStruct and
9160 (AddPartial): Update. Add 'is_partial' argument.
9161 * roottypes.cs: Update to changes.
9162 * cs-parser.jay (push_current_class): New helper for handling
9163 current_container and current_class.
9164 (struct_declaration, interface_declaration, class_declaration):
9167 2006-07-26 Raja R Harinath <rharinath@novell.com>
9169 * roottypes.cs: Rename from tree.cs.
9171 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9172 * tree.cs (Tree, ITreeDump): Remove types.
9173 * rootcontext.cs (tree, Tree): Remove fields.
9174 (root, ToplevelTypes): New.
9175 * *.cs: Update to rename.
9177 * tree.cs (Tree.RecordDecl): Remove.
9178 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9180 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9182 2006-07-23 Raja R Harinath <harinath@gmail.com>
9184 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9185 DoFlowAnalysis and OmitStructFlowAnalysis here.
9186 (ec.With): Rename from WithUnsafe and generalize.
9187 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9188 (ec.WithFlowAnalyis): New.
9189 * ecore.cs, expression.cs, statement.cs: Update.
9191 2006-07-22 Raja R Harinath <harinath@gmail.com>
9193 * statement.cs (Block.ResolveMeta): Simplify slightly.
9195 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9196 multiple boolean fields. Convert InUnsafe, constant_check_state,
9197 check_state to flags.
9198 (CheckState, ConstantCheckState): Update.
9199 (InUnsafe): New read-only property.
9200 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9202 (WithUnsafe): New helper similar to WithCheckState.
9203 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9204 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9206 2006-07-21 Raja R Harinath <rharinath@novell.com>
9208 Make comparisons use the same IL irrespective of whether they're
9209 in a 'checked' or 'unchecked' context: one of the issues in #78899
9210 * codegen.cs (EmitContext.CheckState): Make read-only property.
9211 (EmitContext.ConstantCheckState): Likewise.
9212 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9213 helper that implement a save/restore stack for CheckState
9214 values. This is the only way to change check-state.
9215 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9216 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9217 (CheckedExpr.EmitBranchable): New forwarding method.
9218 (UnCheckedExpr): Likewise.
9219 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9220 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9221 (Checked.Resolve, checked.DoEmit): Likewise.
9223 2006-07-20 Miguel de Icaza <miguel@novell.com>
9225 * anonymous.cs: Cache the resolved anonymous delegate, and return
9226 this so that the ResolveTopBlock is only triggered once, not
9229 Currently we trigger ResolvetopBlock twice due to a first pass of
9230 argument check compatibility, and a second pass that does the
9233 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9235 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9237 * rootcontext.cs (Reset): Add helper_classes.
9239 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9242 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9245 2006-07-13 Miguel de Icaza <miguel@novell.com>
9247 * statement.cs (Lock): Handle expressions of type
9248 TypeManager.null_type specially. Fixes #78770
9250 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9252 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9255 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9257 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9258 for accessors as well.
9259 * ecore.cs (EventExpr): Add AccessorTable.
9261 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9264 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9265 for CS0122 where appropriate.
9266 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9268 (Filter): Assembly can be null in the case of top level attributes.
9270 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9274 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9275 is done at global level.
9277 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9279 A fix for #77002, Implemented TypeForwarder support.
9281 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9282 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9283 * typemanager.cs (): Add type_forwarder_attr_type.
9285 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9287 * report.cs: Add CS0469 warning.
9289 2006-06-21 Martin Baulig <martin@ximian.com>
9291 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9292 the `try'-block, so we also report CS0016 etc. there.
9294 2006-06-21 Martin Baulig <martin@ximian.com>
9297 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9299 2006-06-21 Martin Baulig <martin@ximian.com>
9301 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9302 also report CS1686 for parameters.
9304 2006-06-21 Martin Baulig <martin@ximian.com>
9306 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9307 instead of an error if the value is not implicitly convertible to
9308 the switch types; fixes #77964.
9310 2006-06-21 Raja R Harinath <rharinath@novell.com>
9313 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9314 FieldBuilder is null.
9317 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9318 'left' and 'right' before error-checking.
9320 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9322 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9324 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9325 (FieldExpr.DoResolve): likewise.
9326 (PropertyExpr.InstanceResolve): likewise.
9327 (EventExpr.InstanceResolve): likewise.
9329 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9331 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9332 attribute applicable tests for attribute argument.
9334 2006-06-02 Raja R Harinath <rharinath@novell.com>
9337 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9338 (Binary.OverloadResolve_PredefinedIntegral): New.
9339 (Binary.OverloadResolve_PredefinedFloating): New.
9340 (Binary.OverloadResolve_PredefinedString): New.
9341 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9342 Follow the standard more closely, and treat numeric promotions in
9343 terms of overload resolution.
9344 (Binary.CheckShiftArguments): Simplify.
9346 2006-06-01 Raja R Harinath <rharinath@novell.com>
9348 * flowanalysis.cs (MyBitVector): Simplify representation.
9349 (MyBitVector.Clone): Avoid allocating BitArray.
9350 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9351 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9352 (*): Update. Change all references to MyBitVector.And and
9353 MyBitVector.Or to &= and |=.
9355 2006-05-29 Raja R Harinath <rharinath@novell.com>
9358 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9359 to param arguments too.
9361 2006-05-26 Miguel de Icaza <miguel@novell.com>
9363 * cs-parser.jay: Catch another parsing form for arglist being
9364 followed by other arguments. Fixes #78313.
9366 2006-05-24 Raja R Harinath <rharinath@novell.com>
9368 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9369 checking of out parameters to ...
9370 (FlowBranchingToplevel.Merge): ... here.
9371 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9372 set, propagate the origin upward, and only complain if there was
9374 (FlowBranchingException.AddContinueOrigin): Likewise.
9375 (FlowBranchingException.AddReturnOrigin): Likewise.
9376 (FlowBranchingException.AddGotoOrigin): Likewise.
9378 2006-05-23 Raja R Harinath <rharinath@novell.com>
9380 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9381 unreachable, skip it.
9382 (FlowBranchingException.Merge): Always propagate jumps, even if
9383 the finally block renders subsequent code unreachable.
9385 2006-05-18 Raja R Harinath <rharinath@novell.com>
9388 * statement.cs (Goto.Resolve): Move responsibility for resolving
9389 'goto' to FlowBranching.AddGotoOrigin.
9390 (Goto.SetResolvedTarget): New. Callback to set the
9391 LabeledStatement that's the target of the goto.
9392 (Goto.DoEmit): Use Leave instead of Br when crossing an
9393 unwind-protect boundary.
9394 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9395 LookupLabel and adjust to new semantics.
9396 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9397 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9398 Goto.SetResolvedTarget to update target.
9399 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9400 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9401 AddBreakOrigin & co. Delay propagation until ...
9402 (FlowBranchingException.Merge): ... this.
9404 * statement.cs (Block.Resolve): Always depend on flow-branching to
9405 determine unreachability. Kill workaround that originally emitted
9406 only one statement after an "unreachable" label (see infloop in
9409 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9410 This is still "wrong", but anything better would probably need a
9411 multi-pass algorithm.
9412 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9413 usage vector. Force current usage vector to be reachable, to
9414 optimistically signify backward jumps.
9415 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9417 (FlowBranchingLabeled.Merge): New. If no backward jump was
9418 detected, return the original salted-away usage vector instead,
9419 updated with appropriate changes. Print unreachable warning if
9421 * statement.cs (Block.Resolve): Don't print unreachable warning on
9422 a labeled statement.
9424 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9426 * driver.cs: Pass filename without path to AssemblyBuilder's
9427 AddResourceFile. Fixes bug #78407.
9429 2006-05-17 Raja R Harinath <rharinath@novell.com>
9431 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9432 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9433 (FlowBranching.MergeChild): Overwrite
9434 reachability information from Labeled branchings too.
9436 2006-05-16 Raja R Harinath <rharinath@novell.com>
9438 * statement.cs (Goto.Resolve): Merge jump origins here ...
9439 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9441 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9442 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9443 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9444 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9446 * statement.cs (Goto.Resolve): ... not here.
9447 (Goto.Emit): Remove CS1632 check.
9449 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9451 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9454 2006-05-11 Raja R Harinath <rharinath@novell.com>
9456 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9457 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9458 (FlowBranchingException.Label): Likewise.
9460 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9462 (MyBitVector.Or): Use it to avoid losing information (Count).
9463 (FlowBranching.MergeOrigins): Likewise.
9465 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9466 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9467 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9468 (UsageVector.ToString): Simplify.
9469 (UsageVector.MergeSiblings): Move here from ...
9470 (FlowBranching.Merge): ... here.
9471 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9474 2006-05-10 Raja R Harinath <rharinath@novell.com>
9476 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9477 null bitvector is treated as all-true.
9479 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9480 (MyBitVector): Rationalize invariants. 'vector != null' implies
9481 that we have our own copy of the bitvector. Otherwise,
9482 'InheritsFrom == null' implies all inherited bits are true.
9484 2006-05-09 Marek Safar <marek.safar@seznam.cz>
9486 * statement.cs (LocalInfo): Add IsConstant.
9487 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
9488 local variable for constants.
9490 2006-05-09 Raja R Harinath <rharinath@novell.com>
9492 * flowanalysis.cs (MyBitVector.Empty): New.
9493 (MyBitVector): Don't allow InheritedFrom to be null.
9494 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
9495 (UsageVector, FlowBranching): Update to changes.
9497 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
9498 recursion. The 'Parent == null' condition isn't sufficient for
9500 (FlowBranching.AddBreakOrigin): Likewise.
9501 (FlowBranching.AddContinueOrigin): Likewise.
9502 (FlowBranching.AddReturnOrigin): Likewise.
9503 (FlowBranching.StealFinallyClauses): Likewise.
9504 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
9505 (FlowBranching.CheckOutParameters): Likewise.
9506 (FlowBranchingToplevel): Terminate all the above recursions here.
9507 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
9508 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
9510 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
9512 (FlowBranchingToplevel): New. Empty for now.
9513 (FlowBranching.MergeTopBlock): Update.
9514 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
9515 branching for the anonymous delegate.
9516 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
9518 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
9519 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
9520 information at the start of the merge. Reorganize.
9522 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9524 * class.cs (MethodData.Define): Method cannot implement interface accessor.
9526 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9528 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
9529 to newly introduced ctor.
9531 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
9532 message to one place.
9533 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
9536 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9538 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
9540 * ecore.cs (Expression.ResolveAsConstant): Updated.
9542 * statement.cs (ResolveMeta): Updated.
9544 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9546 * cs-parser.jay: __arglist cannot be used in initializer.
9548 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9551 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
9554 2006-05-05 Raja R Harinath <rharinath@novell.com>
9556 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
9557 (LabeledStatement): Add 'name' parameter.
9558 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
9559 (Block.AddLabel): Update to changes.
9560 * cs-parser.jay (labeled_statement): Likewise.
9562 * flowanalysis.cs (BranchingType.Labeled): New.
9563 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
9564 (FlowBranchingLabeled): New. Does nothing for now, but will
9565 eventually handle 'goto' flows.
9566 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
9567 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
9568 that's terminated ...
9569 (Block.Resolve): ... here.
9571 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
9572 (UsageVector.MergeFinallyOrigins): Likewise.
9573 (FlowBranching.InTryOrCatch): Likewise.
9574 (FlowBranching.AddFinallyVector): Likewise.
9575 (FlowBranchingException): Update to changes.
9578 * statement.cs (Return.Resolve): Move error checking to ...
9579 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
9580 (FlowBranchingException): Handle return origins like break and
9582 (FlowBranching.UsageVector.CheckOutParameters): Remove.
9584 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9587 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
9590 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9593 * class.cs (MethodData.Define): Do public accessor check only when method
9594 implements an interface.
9596 2006-05-04 Raja R Harinath <rharinath@novell.com>
9598 Remove special handling of 'break'
9599 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
9600 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
9601 (UsageVector.Break): Remove.
9602 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
9604 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
9606 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
9607 UsageVector.Breaks (). Don't set NeedsReturnLabel.
9609 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9612 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
9613 be the interface member.
9615 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9618 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
9619 for emitting small (int) values.
9621 2006-05-03 Raja R Harinath <rharinath@novell.com>
9624 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
9625 control-flow passes through the 'finally' after merging-in all the
9626 control-flows from 'try' and the 'catch' clauses.
9628 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
9629 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
9630 always true at the only non-recursive entry point.
9631 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
9632 FlowBranchingBreakable.
9633 (FlowBranchingLoop): Remove.
9634 * statement.cs (Return.DoResolve): Update to changes.
9637 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
9638 (FlowBranching.CreateBranching): Handle it: create a
9639 FlowBranchingContinuable.
9640 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
9641 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
9642 except that it handles the 'continue' command.
9643 (FlowBranching.UsageVector.MergeOrigins): Rename from
9645 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
9646 except that it overrides AddContinueOrigin.
9647 (FlowBranchingException): Override AddContinueOrigin, similar to
9649 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
9650 Create a new branching around the embedded statement.
9651 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
9652 control flow after the embedded statement.
9653 (Continue.Resolve): Move all error checking to AddContinueOrigin.
9655 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
9656 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
9657 FlowBranchingBreakable.
9658 (FlowBranchingSwitch): Remove.
9661 * statement.cs (Break.Resolve): Simplify. Move responsibility for
9662 error reporting to ...
9663 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
9664 Rename from 'AddBreakVector'. Add new location argument. Return
9665 a bool indicating whether the 'break' crosses an unwind-protect.
9666 (FlowBranchingException.AddBreakOrigin): Add.
9667 (FlowBranchingException.Merge): Propagate 'break's to surrounding
9668 flowbranching after updating with the effects of the 'finally'
9670 (FlowBranchingBreakable): New common base class for
9671 FlowBranchingLoop and FlowBranchingSwitch.
9673 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
9675 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
9677 2006-05-02 Raja R Harinath <rharinath@novell.com>
9679 * statement.cs (Do.Resolve): If the loop is infinite, set the
9681 (While.Resolve, For.Resolve): Set a barrier after the embedded
9682 statement. There's no direct control flow that goes from the end
9683 of the embedded statement to the end of the loop.
9684 * flowanalysis.cs (FlowBranching.Infinite): Remove.
9685 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
9686 above ensure that the reachability is correctly computed.
9688 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
9689 (UsageVector.MergeBreakOrigins): If the current path is
9690 unreachable, treat it as if all parameters/locals are initialized.
9691 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
9692 infinite loops before merging-in break origins.
9694 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
9695 (Reachability.Reachable): Split part into ...
9696 (Reachability.Unreachable): ... this. Simplify.
9697 (Reachability.IsUnreachable): Use 'Unreachable' instead.
9699 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
9700 (Reachability.SetThrowsSometimes): Likewise.
9701 (FlowBranchingBlock.MergeTopBlock): Don't compare against
9702 TriState.Always, use corresponding property.
9703 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
9704 (Block.Resolve): Likewise. Remove some redundant checks.
9706 2006-05-02 Raja R Harinath <harinath@gmail.com>
9708 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
9709 (Reachability.Meet): Don't bother checking AlwaysThrows --
9710 barrier is always set.
9711 (FlowBranchingBlock.Merge): Likewise.
9713 2006-05-01 Raja R Harinath <harinath@gmail.com>
9715 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
9716 checks for unreachable.
9718 2006-05-01 Marek Safar <marek.safar@seznam.cz>
9721 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
9723 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
9724 whether field is really assigned.
9726 2006-04-30 Raja R Harinath <harinath@gmail.com>
9728 * flowanalysis.cs (Reachability): Make 4-argument constructor
9730 (Reachability.Meet): Rename from 'And'. Remove static variant.
9731 (Reachability.Always): Rename from the highly misleading
9732 'Reachability.Never'.
9733 (FlowBranching.Merge): Update to changes. Mark an impossible
9734 situation with a 'throw'.
9735 (*): Update to changes.
9737 2006-04-29 Raja R Harinath <harinath@gmail.com>
9739 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
9741 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
9742 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
9743 (*): Update to changes.
9744 * statement.cs: Update to changes.
9746 2006-04-28 Marek Safar <marek.safar@seznam.cz>
9749 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
9751 2006-04-28 Raja R Harinath <harinath@gmail.com>
9753 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
9756 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
9757 argument to two arguments: an usage-vector and a bool. Move call
9758 to FlowBranching.Merge () ...
9759 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
9761 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
9762 handling of loop and switch reachability to ...
9763 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
9765 2006-04-27 Raja R Harinath <harinath@gmail.com>
9767 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
9768 handling to FlowBranchingLoop.InLoop.
9769 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
9771 2006-04-26 Marek Safar <marek.safar@seznam.cz>
9774 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
9775 anonymous method is allowed from AnonymousContainer here.
9777 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
9779 2006-04-24 Raja R Harinath <rharinath@novell.com>
9782 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
9784 2006-04-23 Marek Safar <marek.safar@seznam.cz>
9787 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
9788 (DoubleConstant.Reduce): Ditto.
9790 2006-04-23 Raja R Harinath <rharinath@novell.com>
9792 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
9793 Remove 'lvalue_right_side' argument. Move parts to ...
9794 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
9795 (LocalVariable.DoResolveLValue): ... these.
9797 2006-04-21 Raja R Harinath <rharinath@novell.com>
9800 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
9801 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
9802 (LocalVariableReference.DoResolveBase): Use it to implement new
9804 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
9805 (Argument.Resolve): Simplify. Move CS1510 check ...
9806 * ecore.cs (Expression.ResolveLValue): ... here.
9807 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
9808 (PropertyExpr.DoResolveLValue): Likewise.
9809 (FieldExpr.Report_AssignToReadonly): Likewise.
9810 (FieldExpr.DoResolve): Add 'out_access' argument. Use
9811 LValueMemberAccess or LValueMemberOutAccess on instance depending
9813 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
9814 DoResolve as appropriate.
9816 2006-04-20 Raja R Harinath <rharinath@novell.com>
9819 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
9820 implicit conversions on 'out' and 'ref' arguments.
9822 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
9823 improve clarity. Remove dead code.
9826 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
9827 (Catch.Resolve): Resolve VarBlock if it exists.
9829 2006-04-19 Miguel de Icaza <miguel@novell.com>
9831 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
9832 twice, this was some residual code, the enumerator was emitted
9833 properly in the two branche of if later.
9835 2006-04-19 Raja R Harinath <rharinath@novell.com>
9837 * expression.cs (Cast.ResolveLValue): Remove. The result of a
9838 cast is never an lvalue.
9839 (Cast.DoResolve, Cast.ResolveRest): Combine.
9840 (Argument.Emit): Simplify slightly. Move 'Expr is
9841 IMemoryLocation' check ...
9842 (Argument.Resolve): ... here.
9843 (Argument.Error_LValueRequired): Remove. Inline into only user.
9845 Simplifications. Fix cs0191-2.cs
9846 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
9847 CS1649 and CS1651 to ...
9848 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
9849 the actual selection of the error code and message to a lookup
9850 table. Add a dummy return value to simplify callsites.
9851 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
9852 readonly fields of other instances of the same type. Move CS0197
9854 * expression.cs (Argument.Resolve): ... here. Simplify code.
9855 Ensure that ec.InRefOutArgumentResolving is only set during LValue
9856 resolution of an out or ref argument. The code simplification
9857 above uses this invariant.
9859 2006-04-18 Raja R Harinath <rharinath@novell.com>
9861 Possibly fix #77752. Fix cs1690-[4-7].cs.
9862 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
9863 CheckMarshallByRefAccess. Drop parameter.
9864 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
9866 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
9868 * report.cs (AllWarnings): Add CS1690.
9869 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
9871 (LocalVariableReference.DoResolveBase): Update.
9873 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9875 * class.cs (MethodOrOperator): Moved common parts from method class.
9876 detect obsolete attributes.
9877 (Method.Define): Simplified as it reuses code from base.
9878 (Constructor.ValidAttributeTargets): Fixed issue found during
9880 (Destructor.ValidAttributeTargets): Fixed issue found during
9882 (Operator): Finished refactoring set off by #78020. Operator class is now
9883 ordinary method class.
9885 * anonymous.cs: Updated.
9887 * decl.cs (DeclSpace): Add IsGeneric
9889 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9891 * class.cs (Constructor.Emit): Don't emit the attributes twice.
9893 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9895 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
9896 detect obsolete attributes.
9897 (Method.CreateEmitContext): Moved to MethodOrOperator.
9899 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9902 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
9903 customized exception to make crash detection easier.
9904 (MethodOrOperator): Started to work on new base class for methods and
9906 (Method): Derives from MethodOrOperator.
9907 (Constructor.Emit): Emits its own attributes.
9908 (AbstractPropertyEventMethod.Emit): Ditto.
9909 (Operator): Derives from MethodOrOperator, will refactor fully in extra
9911 (Operator.Emit): It's temporary more tricky than should be.
9913 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
9915 * report.cs (InternalErrorException): Add ctor with inner exception.
9917 2006-04-08 Marek Safar <marek.safar@seznam.cz>
9920 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
9923 2006-04-07 Marek Safar <marek.safar@seznam.cz>
9926 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
9929 2006-04-06 Marek Safar <marek.safar@seznam.cz>
9931 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
9932 attribute is present and Guid not.
9933 (Interface.ApplyAttributeBuilder): Ditto.
9935 * attribute.cs: Add error message.
9937 2006-04-06 Marek Safar <marek.safar@seznam.cz>
9941 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
9942 sources (it's composite) so hold them in extra array as they are used in
9943 Emit phase only. It worked in the previous versions by mistake.
9944 (Attribute.Emit): Emit attribute for more owners when exist.
9946 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
9947 it has now different behaviour.
9949 2006-04-04 Marek Safar <marek.safar@seznam.cz>
9951 * constant.cs (Constant.IsDefaultInitializer): New method.
9953 * class.cs: Updated.
9955 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
9956 re-initialize default values. It saves KBs almost for every assembly.
9957 Thanks Zoltan for the idea.
9958 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
9959 (ArrayCreation.DoResolve): Resolve only once.
9960 (ArrayCreation.Emit): Emit static initializer only when it is faster.
9961 (ArrayCreation.GetAttributableValue): Cope with optimized values.
9963 2006-04-03 Zoltan Varga <vargaz@gmail.com>
9965 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
9968 2006-04-01 Marek Safar <marek.safar@seznam.cz>
9970 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
9971 in an embedded statement too.
9973 2006-04-01 Raja R Harinath <rharinath@novell.com>
9976 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
9978 2006-04-01 Marek Safar <marek.safar@seznam.cz>
9982 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
9985 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
9987 2006-03-31 Marek Safar <marek.safar@seznam.cz>
9989 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
9992 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
9993 LocalTemporary change.
9995 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
9997 (ClassOrStruct.DefineFieldInitializers): Implemented static field
9998 initializers optimization.
9999 (ClassOrStruct.TypeAttr): Moved from modifiers.
10000 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10001 (FieldBase.ResolveInitializer): Resolves initializer.
10002 (FieldBase.HasDefaultInitializer): New property.
10004 * cs-parser.jay: Removed message.
10006 * expression.cs (CompilerGeneratedThis): New specialization.
10008 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10010 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10012 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10014 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10016 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10017 be now EnumConstants only.
10019 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10021 * attribute.cs, driver.cs: Reset more caches.
10023 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10025 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10027 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10029 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10030 for easier reuse. Updated all overrides.
10031 (IntegralConstant): New base class for all integral constants.
10032 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10033 of the constant range, report custom error.
10034 (UIntConstant.Reduce): Fixed uint conversion.
10036 * ecore.cs, literal.cs: Reduce updates.
10038 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10042 * class.cs (Constructor.Define): Removed extra if for default ctors.
10043 A patch from Atsushi Enomoto.
10045 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10047 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10048 GetAttributableValue.
10050 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10053 * convert.cs (ImplicitConversionRequired): Error message moved to
10056 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10057 automatic implicit conversion of an output value.
10058 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10060 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10062 (TypeOf.GetAttributableValue): Add extra handling for object type.
10064 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10065 special error message.
10067 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10069 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10071 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10072 compatible with MS runtime.
10074 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10076 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10077 attribute arguments here.
10079 * class.cs (Indexer.Define): The check was moved to attribute class.
10081 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10083 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10084 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10087 2006-03-22 Raja R Harinath <rharinath@novell.com>
10089 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10090 mcs to keep code differences small.
10091 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10092 * typemanager.cs (parameter_default_value_attribute_type): New.
10093 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10096 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10098 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10100 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10102 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10104 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10107 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10109 * doc-bootstrap.cs : fix build.
10111 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10113 * expression.cs (StringConcat.Append): Issue a warning when empty string
10114 is going to append.
10116 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10118 * assign.cs (CompoundAssign.ResolveSource): Removed.
10120 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10123 * class.cs (TypeContainer.FindMethods): Removed.
10124 (TypeContainer.CheckMemberUsage): Made static.
10126 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10128 * constant.cs (CheckRange): Removed unused type argument.
10129 (CheckUnsigned): Removed unused type argument.
10131 * cs-parser.jay: Updated after MemberAccess clean up.
10132 Uses Length for empty string test.
10134 * cs-tokenizer.cs: Uses Length for empty string test.
10135 (IsCastToken): Made static.
10136 (is_hex): Made static.
10137 (real_type_suffix): Made static.
10139 * decl.cs (SetupCache): Made static.
10140 (OnGenerateDocComment): Removed unused ds argument.
10142 * delegate.cs (VerifyDelegate): Removed unused argument.
10144 * doc.cs: Uses Length for empty string test.
10146 * driver.cs: Uses Length for empty string test.
10148 * enum.cs (IsValidEnumType): Made static
10150 * expression.cs (EnumLiftUp): Removed unused argument.
10151 (ResolveMethodGroup): Ditto.
10152 (BetterConversion): Ditto.
10153 (GetVarargsTypes): Ditto.
10154 (UpdateIndices): Ditto.
10155 (ValidateInitializers): Ditto.
10156 (MemberAccess.ctor): Ditto.
10157 (GetIndexersForType): Ditto.
10159 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10161 * iterators.cs: Updated after MemberAccess clean up.
10163 * location.cs: Uses Length for empty string test.
10165 * namespace.cs: Uses Length for empty string test.
10167 * report.cs (CheckWarningCode): Made static.
10169 * statement.cs (LabeledStatement): Removed unused argument.
10171 * typemanager.cs (FilterNone): Removed.
10173 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10175 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10178 * class.cs: Updated.
10180 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10182 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10184 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10188 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10189 reporting, it's more tricky than I thought.
10191 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10195 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10197 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10198 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10199 Add more error reporting; Fixed issue with params.
10201 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10203 * cs-parser.jay: AnonymousMethod requires host container.
10205 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10207 2006-03-18 Raja R Harinath <harinath@gmail.com>
10209 * class.cs: Change 'TypeContainer ds' constructor argument to
10210 'DeclSpace parent'. Some classes were missed below due to
10211 different naming convention.
10213 * class.cs (MemberCore.Parent): Delete. This makes the
10214 ParentContainer changes below enforceable by the compiler.
10216 Treat pointers to enclosing declaration space as 'DeclSpace', not
10218 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10219 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10221 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10223 (Block.AddThisVariable): Likewise.
10224 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10225 (AbstractPropertyEventMethod.Emit): Likewise.
10226 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10227 (GetMethod.Define, SetMethod.Define): Likewise.
10228 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10229 (DelegateMethod.EmitMethod): Likewise.
10231 Fix regression test-partial-13.cs.
10232 Rationalize use of PartialContainer. Ensure that the partial
10233 class semantics can be tied to type-correctness, i.e., any
10234 violation will cause a compile error.
10235 * class.cs, const.cs: Access all fields that belong to class
10236 TypeContainer via ParentContainer. Arguments of EmitContexts and
10237 Resolve()-like functions still use 'Parent'.
10239 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10240 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10241 (PropertyMethod.CheckModifiers): Remove unused argument.
10242 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10245 2006-03-17 Raja R Harinath <harinath@gmail.com>
10247 Make semantics of PartialContainer simpler.
10248 * decl.cs (DeclSpace.IsPartial): Remove.
10249 * class.cs (TypeContainer.IsPartial): Likewise.
10250 (TypeContainer..ctor): Set PartialContainer to point to self.
10251 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10252 (TypeContainer.FindNestedType): Likewise.
10253 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10255 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10257 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10259 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10261 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10264 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10266 * class.cs (Operator.Define): An error for base conversion was not
10267 reported correctly.
10269 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10271 * iterator.cs : yield break is allowed in try statement which has
10272 catch clauses. Fixed bug #77767.
10274 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10276 A fix for #77593, #77574.
10278 * class.cs (MethodCore.CheckBase): Another if for operator.
10280 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10282 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10285 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10286 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10289 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10292 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10293 Updated after another emitcontext usage was clean up. It should help us to
10294 synchronize with gmcs easier.
10296 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10300 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10301 (Event.Define): ditto
10302 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10304 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10305 Removed redundant code and set NewSlot for Invoke method too.
10307 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10308 (Parameters.MergeGenerated): New method. Use this method when you merge
10309 compiler generated argument with user arguments.
10311 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10313 * attribute.cs (ResolveAsTypeTerminal): Removed.
10315 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10316 specialization for predefined types; 30% speed up.
10317 Finally placed obsolete check to right place.
10318 (Expression.ResolveType): Removed.
10320 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10321 Updated after ResolveType was removed.
10323 * expression.cs (Cast.ctor): Check void cast.
10324 (Binary.ResolveAsTypeTerminal): Is never type.
10325 (Conditional.ResolveAsTypeTerminal): Is never type.
10327 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10329 2006-03-01 Raja R Harinath <rharinath@novell.com>
10332 * expression.cs (ParameterReference.DoResolveBase): Change return
10334 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10338 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10341 * typemanager.cs (GetFullNameSignature): Don't nullref on
10342 protected accessors.
10344 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10346 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10347 these two separated members to simplify the code.
10348 (Attribute.Resolve): Refactored to use new fields and methods.
10349 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10350 implemented obsolete attribute checking.
10351 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10352 implemented obsolete checking again. It look line never ending quest ;-)
10353 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10355 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10357 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10359 *class.cs (Property.Define): Add RegisterProperty call.
10361 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10362 argument groups (only 2).
10364 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10365 encoding expression to arguments.
10366 (Expression.ExprClassToResolveFlags): Just turned to property.
10368 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10369 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10370 optimized as well as implemented support for zero-length attributes.
10372 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10373 Add caching of PropertyInfo's.
10375 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10377 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10378 error multiple times.
10380 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10382 New partial class implementation.
10383 A fix for #77027, #77029, #77403
10385 * attribute.cs (Attributable): Made attributes protected.
10387 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10388 the replacements of ClassPart and PartialContainer.
10389 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10390 (TypeContainer.AddInterface): Ditto.
10391 (TypeContainer.AddPartial): The main method for partial classes. It checks
10392 for errors and merges ModFlags and attributes. At the end class is added to
10393 partial_parts list.
10394 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10396 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10397 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10398 from the rest of partial classes.
10399 (TypeContainer.GetClassBases): Simplified.
10400 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10402 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10403 (TypeContainer.HasExplicitLayout): Uses Flags now.
10404 (PartialContainer): Removed.
10405 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10406 (StaticClass): Was merged with Class.
10407 (Class.GetClassBases): class and static class bases are verified here.
10408 (Class.TypeAttr): Added static attributes when class is static.
10409 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10410 (MemberBase): In some cases we need to call parent container for partial
10411 class. It should be eliminated but it's not easy now.
10413 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10415 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10416 partial classed to accumulate class comments.
10417 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10419 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10421 * driver.cs (MainDriver): Tree.GetDecl was removed.
10423 * modifiers.cs (Modifiers): Add partial modifier.
10425 * tree.cs (Tree.decl): Removed.
10426 (RootTypes): Started to use this class more often for root types
10429 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10433 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10434 external interface does not have an attribute.
10436 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10438 Another prerequisites for new partial classs implementation.
10440 * attribute.cs (Attribute.Equal): Implemented.
10441 (Attribute.Emit): Changed as attributes can be applied more than twice.
10442 (Attributes.Emit): Check for duplicate attributes here.
10444 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10445 as a parameter, clean-up.
10447 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10451 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10452 contains obsolete attribute check which can in some cases look for base
10453 type of current class which is not initialized yet.
10454 (TypeContainer.BaseType): Replacement of ptype.
10456 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10458 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10460 First of prerequisites for new partial classs implemention.
10462 * attribute.cs (Attributable): Extended by ResolveContext;
10463 Attributes finally have correct context for resolving in all cases.
10464 (AttachTo): Attribute owner is assigned here.
10466 * codegen.cs (IResolveContext): Introduce new interface to hold
10467 all information needed in resolving phase.
10468 (EmitContext): Implements IResolveContext; more clean-up needed here.
10470 * decl.cs (MemberCore): Implemented IResolveContext.
10472 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10473 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10474 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10475 Refactored to use new IResolveContext instead of EmitContext; cleanup
10477 2006-02-06 Miguel de Icaza <miguel@novell.com>
10479 * codegen.cs (EmitScopeInitFromBlock): check here the
10480 capture_context, there is no need to make two calls to the
10483 * anonymous.cs: Add some debugging messages that might help me
10484 track other instances of this problem in the future (the
10485 regression of test 467).
10487 * cs-parser.jay: track the variable block, as we need to initalize
10488 any captured variables declared in this block for the "catch"
10489 portion of the "Try" statement.
10491 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
10492 scope initialization for captured variables.
10494 Also, move the emit for the variables after the block location has
10497 2006-02-06 Marek Safar <marek.safar@seznam.cz>
10499 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
10501 2006-02-02 Miguel de Icaza <miguel@novell.com>
10503 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
10504 commit yesterday, the initialization for the roots is necessary.
10505 What is not necessary is the scope activation.
10507 2006-02-02 Raja R Harinath <rharinath@novell.com>
10509 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
10510 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
10512 (Argument.Resolve): Remove CS0206 checks.
10514 2006-02-01 Miguel de Icaza <miguel@novell.com>
10516 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
10517 scopes for all the roots, the scopes will now be emitted when the
10518 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
10520 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
10521 code. This reduces a lot of existing cruft.
10523 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
10524 that the ScopeInfo is generated as we enter the scope, not at the
10525 time of use, which is what we used to do before.
10527 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
10528 every time a Block is about to be emitted if we have a
10531 2006-02-01 Raja R Harinath <rharinath@novell.com>
10533 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
10535 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
10537 * typemanager.cs (cons_param_array_attribute): Make private.
10538 (Reset): Set it to null.
10539 (InitCoreHelpers): Don't initialize it.
10540 (ConsParamArrayAttribute): New. Initialize it as needed.
10541 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
10543 2006-01-31 Miguel de Icaza <miguel@novell.com>
10545 * expression.cs: There might be errors reported during the
10546 selection of applicable methods. If there are errors, do not
10547 continue execution as it will lead the compiler to crash.
10549 2006-01-30 Miguel de Icaza <miguel@novell.com>
10551 * expression.cs: Member access is not allowed on anonymous
10552 methods. Fixes #77402.
10554 2006-01-30 Raja R Harinath <rharinath@novell.com>
10557 * cs-parser.jay (VariableDeclaration): Don't set
10558 current_array_type to null.
10559 (field_declaration, event_declaration, declaration_statement):
10560 Set it to null here.
10562 2006-01-28 Raja R Harinath <harinath@gmail.com>
10564 * typemanager.cs (GenericParameterPosition): New.
10567 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
10569 * doc.cs : To process "include" elements, first we should create
10570 another list than XmlNodeList, because it could result in node
10571 removal, which could result in that the XmlNodeList gives up
10572 yielding next node.
10574 (Also made code identical to gmcs again.)
10576 2006-01-25 Miguel de Icaza <miguel@novell.com>
10578 * ecore.cs: Introduce an error report that we were not catching
10579 before, if not silent, we must report the error. Gonzalo ran into
10582 2006-01-23 Miguel de Icaza <miguel@novell.com>
10584 A fix for bug: #76957
10586 * iterators.cs (MoveNextMethod.CreateMethodHost): call
10587 ComputeMethodHost before creating the method, this is a new
10590 * anonymous.cs (AnonymousContainer): Now we track all the scopes
10591 that this method references (RegisterScope). The actual scope
10592 where the method is hosted is computed with the ComputeMethodHost
10593 before we create the method.
10595 Moved the Deepest routine here.
10597 (AnonymousContainer.ComputeMethodHost): New routine used to
10598 compute the proper ScopeInfo that will host the anonymous method.
10600 (ScopeInfo): Deal with multiple roots. The problem was that we
10601 did not have a unique root where all ScopeInfos could be hanged
10602 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
10605 Remove AdjustMethodScope which is now computed at the end. Remove
10606 LinkScope which did a partial link, instead link all ScopeInfos
10607 before code generation from the new "LinkScopes" routine.
10609 Simplify all the Add* routines as they no longer need to maintain
10610 the tree, they just need to record that they are using variables
10613 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
10614 routines to produce the forest of ScopeInfo trees.
10616 * class.cs (TypeContainer.AppendMethod): This is just like
10617 AddMethod, but ensures that an interface implementation method
10618 (IEnumerable.XXX) is not inserted at the beginning of the queue of
10619 methods, but at the end.
10621 We use this functionality to ensure that the generated MoveNext
10622 method in the iterator class is resolved/emitted before the
10623 enumerator methods created.
10625 This is required because the MoveNext method computes the right
10626 ScopeInfo for the method. And the other methods will eventually
10627 need to resolve and fetch information computed from the anonymous
10630 2006-01-21 Raja R Harinath <harinath@gmail.com>
10631 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10633 Fix rest of #76995.
10634 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
10635 the 'aliases' hash.
10636 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
10637 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
10639 2006-01-18 Raja R Harinath <rharinath@novell.com>
10641 Fix #76656, cs0231-2.cs.
10642 * cs-parser.jay (formal_parameter_list): Make error case catch
10644 (parenthesized_expression_0): Add CS1026 check.
10645 (invocation_expression): Remove unused { $$ = lexer.Location }.
10647 2006-01-17 Raja R Harinath <rharinath@novell.com>
10650 * cs-parser.jay (statement_expression): Don't list out the
10651 individual statement-expressions. Convert syntax error into
10654 2006-01-16 Raja R Harinath <rharinath@novell.com>
10657 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
10658 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
10659 CheckIntermediateModification.
10660 (FieldExpr.DoResolve): Add new two-argument version that
10661 allows us to resolve the InstanceExpression as an lvalue.
10662 The one-argument variant is now just a wrapper.
10663 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
10664 Resolve the lhs as an lvalue if the it has a value type.
10665 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
10666 from Assign.DoResolve.
10667 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
10668 resolved as an lvalue.
10669 (PropertyExpr.DoResolve): Update.
10670 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
10671 has a value type. Move CS1612 check here from
10672 CheckIntermediateModification.
10673 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
10674 * expression.cs (EmptyExpression.OutAccess): New. Used as the
10675 'right_side' of a ResolveLValue on an 'out' argument.
10676 (EmptyExpression.LValueMemberAccess): New. Used as the
10677 'right_side' of a propagated ResolveLValue on a value type.
10678 (LocalVariableReference.DoResolveBase): Recognize
10679 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
10681 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
10682 EmptyExpression.Null.
10684 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
10686 * typemanager.cs : added IsGenericParameter(). In mcs it always
10688 * doc.cs : for generic parameters, use GenericParameterPosition,
10691 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
10693 * expression.cs: Fix Console.WriteLine ((this = x).foo);
10695 2006-01-12 Miguel de Icaza <miguel@novell.com>
10697 This fixes the problem where we used ldfld instead of ldflda to
10698 load the "THIS" pointer on captured parameters, when THIS is a
10699 value type. See bug #77205.
10701 * iterators.cs (CapturedThisReference.Emit): Pass false to
10702 EmitThis (we do not need the address).
10704 * codegen.cs (EmitThis): it needs to know whether we need the
10705 address of `this' or not. This is used by value types.
10707 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
10708 every other call passes false.
10710 2006-01-12 Raja R Harinath <rharinath@novell.com>
10713 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
10715 * expression.cs (Invocation.OverloadResolve): Update.
10716 (Invocation.DoResolve): Avoid double resolution of invocation.
10718 2006-01-11 Raja R Harinath <rharinath@novell.com>
10721 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
10722 unary negation of floating point types as 0-expr; negation cannot
10723 overflow in floating point types.
10726 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
10727 on operands of 'void' type.
10730 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
10731 and ExclusiveOr for boolean constants too.
10733 2006-01-09 Raja R Harinath <rharinath@novell.com>
10736 * expression.cs (Invocation.OverloadResolve): Replace reflected
10737 override methods with their base virtual methods, rather than
10738 skipping over them.
10739 * typemanager.cs (TypeManager.GetOverride): New.
10741 2006-01-05 Jb Evain <jbevain@gmail.com>
10743 * class.cs (Property.Define, Indexer.Define): do not tag the
10744 properties as SpecialName | RTSpecialName.
10746 2006-01-04 Miguel de Icaza <miguel@novell.com>
10748 * class.cs (MethodCore.IsDuplicateImplementation): This method was
10749 doing a low-level comparission of parameter types. It was lacking
10750 a check for __argslist.
10752 2005-12-30 Miguel de Icaza <miguel@novell.com>
10754 * expression.cs (ParameterReference.DoResolveBase): Allow
10755 reference parameters if they are local to this block.
10757 This allows the ref and out parameters of a delegate to be used in
10758 an anonymous method, for example:
10760 delegate void set (out int x);
10762 set s = delegate (out int x){
10766 This is used by functionality introduced late in the C# language.
10768 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
10769 method that take ref and out parameters.
10771 Fixes #77119 which was a late change in the spec.
10773 2005-12-23 Miguel de Icaza <miguel@novell.com>
10775 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
10776 parent if its the same scope. Fixes #77060.
10778 2005-12-21 Miguel de Icaza <miguel@novell.com>
10780 * driver.cs: Report the case of no source files and no -out:
10783 2005-12-20 Raja R Harinath <rharinath@novell.com>
10786 * expression.cs (ComposedCast.GetSignatureForError): Define.
10788 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10792 * namespace.cs (NamespaceEntry): Add extern_aliases as a
10793 ListDictionary, to contain the ExternAliasEntry entries (in
10794 addition to the NamespaceEntry.aliases hashtable). This field is
10795 shared between the original entry and its doppelganger (bodyless
10797 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
10798 extern_aliases field.
10799 (NamespaceEntry.Lookup): Move the IsImplicit check after the
10800 lookup in extern_aliases.
10802 2005-12-16 Raja R Harinath <rharinath@novell.com>
10805 * class.cs (TypeContainer.Mark_HasEquals): New.
10806 (TypeContainer.Mark_HasGetHashCode): New.
10807 (ClassPart): Override them.
10808 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
10811 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
10812 'parent' argument to the base constructor.
10814 Remove all mention of TypeContainer from decl.cs.
10815 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
10816 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
10817 (DeclSpace.DeclSpace): Likewise.
10818 (DeclSpace.DefineMembers): Remove unused argument.
10819 * cs-parser.jay (pop_current_class): Update to changes. Simplify
10820 debugging check -- we don't care if the debug code throws an
10821 InvalidCastException instead of an InternalErrorException.
10822 * class.cs (TypeContainer.DefineMembers): Update to changes.
10823 (TypeContainer.DoDefineMembers): Likewise.
10824 (TypeContainer.GetMethods): Likewise.
10825 (PropertyMember.Define): Likewise.
10826 (MemberBase.Parent): New property that forwards to
10827 MemberCore.Parent, but ensures that we get a TypeContainer.
10828 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
10829 (RootContext.PopulateTypes): Likewise. Remove special case code
10830 for !RootContext.StdLib: DefineMembers is idempotent.
10832 2005-12-14 Miguel de Icaza <miguel@novell.com>
10834 * convert.cs (ExplicitConversionCore): Check the return value from
10835 ExplicitConversionCore which can return null on failure. Fixes #76914
10837 2005-12-13 Marek Safar <marek.safar@seznam.cz>
10839 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
10841 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
10843 * doc.cs : The search for referenced namespace was insufficient to
10844 get global one as it used to do. Fixed bug #76965.
10846 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
10848 * doc.cs : check name in cref in the last phase that whether it is
10851 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10853 * cs-tokenizer.cs : reverted the latest change: it somehow broke
10856 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10858 * doc.cs : so it turned out that we cannot skip override check for
10859 interface members. Fixed bug #76954.
10861 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10863 * cs-tokenizer.cs : fixed bug #75984:
10864 - #warning and #error should not be handled when the source line
10866 - #line is not checked strictly when the source line is disabled.
10867 - #define and #undef is on the other hand checked strictly at any
10870 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
10872 * cs-tokenizer.cs : missing Location (actually, filename) in one of
10875 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10877 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
10879 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
10880 event initializers.
10881 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
10882 (FieldBase.Initializer): Initializer is now optional.
10883 (EventField.Define): Only event field can have initializer.
10885 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
10887 * const.cs (Const): Reuse initializer.
10889 * cs-parser.jay: Updated after FieldBase changes.
10890 Added current_array_type to simplify array initializers.
10892 * ecore.cs (NullCast.IsDefaultValue): Implemented.
10894 * expression.cs, iterators.cs: Updated.
10896 * namespace.cs (NamespaceEntry): Made UsingFound private.
10898 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10900 * parameterCollection.cs: Obsolete, removed.
10901 * parser.cs: Obsolete, removed.
10903 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10906 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
10908 * enum.cs (Enum.Define): Set obsolete context here.
10910 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
10913 - FindDocumentedMember() now expects 1) paramList as null
10914 when "we don't have to check the number of parameters" and
10915 2) Type.EmptyTypes when "there is no arguments".
10916 - Introduced FoundMember struct to hold the exact type which was
10917 used to find the documented member (the above change broke
10918 test-xml-044; it might be better just to use DeclaringType than
10919 what MS does, like this change does, but it depends on usage.)
10921 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
10923 * doc.cs : documented member might be from DeclaringType for nested
10924 types. Fixed bug #76782.
10926 2005-12-03 Ben Maurer <bmaurer@ximian.com>
10928 * anonymous.cs: Have the param code handle leaving copies on the
10929 stack etc. Allows anonymous params to take part in the assignment
10930 code (++, +=, etc). Fixes bug #76550
10932 * expression.cs: Handle the prepare_for_load/leave_copy by passing
10933 it down to the anon code.
10935 * iterators.cs: Use dummy var here
10937 * codegen.cs: Handle new vars
10939 2005-12-01 Marek Safar <marek.safar@seznam.cz>
10942 * class.cs (MethodData.Define): Set proper Obsolete context.
10944 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
10946 (FieldExpr.DoResolve): Ditto.
10948 2005-12-01 Marek Safar <marek.safar@seznam.cz>
10951 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
10952 parent is not obsolete.
10954 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
10956 * doc.cs : (FindDocumentedMember) find parameterless members first
10957 and get CS0419 in the early stage. Fixed first case of bug #76727.
10959 2005-11-30 Marek Safar <marek.safar@seznam.cz>
10962 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
10963 no error was reported.
10965 *expression.cs (Binary.DoResolve): left can be null.
10967 2005-11-22 Marek Safar <marek.safar@seznam.cz>
10970 * class.cs (MethodData.Emit): Parameters should be labeled first.
10972 2005-11-21 Marek Safar <marek.safar@seznam.cz>
10975 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
10977 2005-11-18 Marek Safar <marek.safar@seznam.cz>
10979 * attribute.cs (AreParametersCompliant): Moved to Parameter.
10981 * class.cs (MethodCore): Parameter clean up.
10982 (IMethodData): Added ParameterInfo.
10983 (MethodData): Parameter clean up.
10984 (Indexer.Define): Parameter clean up.
10996 * typemanager.cs: Parameter clean up.
10998 * delegate.cs (Define): Get rid of duplicated code.
11000 * expression.cs (ParameterReference): Removed useless parameters
11002 (Invocation): Ditto.
11004 * parameter.cs (ParamsParameter): New class, params specialization.
11005 (ArglistParameter): Attemp to separate arglist.
11006 (Parameter): Refactored to be reusable and faster.
11007 (Parameter.Modifier): Made understandable.
11008 (Parameters): Changed to be used as a class for `this' assembly
11009 parameters. Refactored to use new specialized classes.
11011 * support.cs (ParameterData): Added Types property.
11012 (InternalParameters): Deleted.
11014 2005-08-20 Martin Baulig <martin@ximian.com>
11016 Merging this patch from GMCS to fix #75867.
11018 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11019 scope if we don't already have it.
11021 2005-11-17 Martin Baulig <martin@ximian.com>
11024 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11025 inherit the scope from our parent. Fixes #76653.
11027 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11029 * doc.cs : the previous patch does not actually fix the bug.
11030 PropertyInfo override check is now implemented and really fixed it.
11031 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11033 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11035 * doc.cs : apply "override filter" also to properties.
11038 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11040 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11041 no need to check overrides. For classes, omit those results from
11042 interfaces since they must exist in the class. Fixed bug #76726.
11044 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11046 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11047 with different parameters. Fixed the second problem in #76685.
11049 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11051 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11052 get expected 'protected' access in CheckValidFamilyAccess()).
11055 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11057 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11058 Fixed bug #76705. CS1569 was incorrectly commented out.
11060 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11062 * doc.cs : use Invocation.IsOverride() to do real override check.
11063 * expression.cs : made Invocation.IsOverride() internal.
11065 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11067 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11068 TypeBuilder.FindMembers() and filter overriden base members out.
11071 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11073 * doc.cs : ref/out parameters are represented as '@' (instead of
11074 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11076 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11078 * doc.cs : when there was no '.' in cref to methods in doc comment,
11079 then parameters were missing in the output. Fixed bug #76691.
11081 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11083 * driver.cs : don't output docs when there is an error.
11086 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11089 Now it should detect indexers. Fixed primary concern in bug #76685.
11090 Fixed CS0419 message to not show the identical member signature in
11093 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11095 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11096 instead of Type.FindMembers() since it does not handle events.
11099 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11101 * codegen.cs: Fixed typo (speficied -> specified).
11103 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11106 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11108 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11110 * attribute.cs: Changed error message.
11112 * cs-tokenizer.cs: One more check.
11114 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11116 * statement.cs (Block.Resolve): Ignore empty statement.
11118 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11120 * report.cs: Made error/warning methods more strict to avoid
11123 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11124 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11125 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11126 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11128 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11130 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11131 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11133 * class.cs (TypeContainer.IsComImport): New property.
11134 (Constructor.Define): Create proper ctor for ComImport types.
11136 * expression.cs (New.CheckComImport): Fixed.
11138 2005-11-07 Miguel de Icaza <miguel@novell.com>
11140 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11141 that a parameter has been captured does not mean that we do not
11142 have to do the rest of the processing. This fixes the second part
11143 of #76592. If there was another anonymous method capturing
11144 values in the past, the Scope would never be set for the second
11145 method that captured the same parameter.
11147 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11148 properly manipulate the stack. Second part of fix for #76592.
11150 * expression.cs (New): Add support for invoking "new" on
11151 interfaces that have been flagged with the ComImport attribute and
11152 the CoClass. Fixes #76637
11154 * statement.cs (Try.DoEmit): When a variable is captured, do not
11155 try to emit the vi.LocalBuilder variable as it has been captured.
11156 Create a temporary variable and store the results on the
11157 FieldBuilder. Fixes #76642
11159 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11161 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11163 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11165 * expression.cs (Binary.DoResolve): Added && optimalization.
11167 * typemanager.cs (AddUserType): Removed useless argument.
11169 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11171 * statement.cs (Block.variables): Uses ListDictionary.
11173 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11176 * class.cs (PartialContainer.EmitType): Customized to emit
11177 security attributes.
11178 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11179 for partial classes.
11181 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11184 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11185 access has to be fixed.
11187 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11189 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11192 * ecore.cs (NullCast.Reduce): Implemented.
11194 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11197 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11199 (Foreach.Resolve): Catch null properly.
11201 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11203 * cs-tokenizer.cs: Warning text fix.
11205 * driver.cs: AllWarningNumbers exposed on public interface.
11207 * report.cs (): Reviewed warning numbers.
11208 (IsValidWarning): Use binary search.
11210 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11212 * driver.cs: Implemeted resource visibility.
11213 (Resources): New class for code sharing between /res: and
11216 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11219 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11222 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11225 * ecore.cs (NullCast): Child is contant only.
11227 * literal.cs (NullLiteral.Reduce): null can be converted to any
11230 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11232 * driver.cs: Use Encoding.Default as default code page instead
11235 2005-10-27 Raja R Harinath <rharinath@novell.com>
11238 * expression.cs (Invocation.Error_InvalidArguments): Handle
11239 __arglist parameters.
11240 (Invocation.VerifyArgumentsCompat): Likewise.
11241 * support.cs (ReflectionParameters.GetSignatureForError): Print
11242 __arglist parameters.
11243 (InternalParamters.GetSignatureForError): Likewise.
11244 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11246 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11248 * attribute.cs (GetPropertyValue): Made public.
11250 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11252 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11254 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11257 * driver.cs: Reflect method name change.
11259 * statement.cs (Try.Resolve): Warn when try has both general
11260 exception handlers.
11262 * typemanager.cs: runtime_compatibility_attr_type new predefined
11265 2005-10-26 Raja R Harinath <harinath@gmail.com>
11268 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11269 treat it as an empty parameter list.
11271 2005-10-26 Raja R Harinath <rharinath@novell.com>
11274 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11275 ResolveAsTypeStep silent.
11276 * statement.cs (Block.AddConstant): Mark block as used.
11277 (Block.ResolveMeta): Avoid piling on error messages
11278 if a constant initializer resolution fails.
11280 2005-10-25 Raja R Harinath <rharinath@novell.com>
11282 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11284 (NamespaceEntry.VerifyAllUsing): New.
11285 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11286 behaviour. Delegates actual resolution of alias to ...
11287 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11288 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11290 * driver.cs (Driver.MainDriver): Update.
11292 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11293 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11295 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11297 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11298 RootNamespace.DefineNamespacesForAll.
11300 2005-10-24 Raja R Harinath <harinath@gmail.com>
11302 * typemanager.cs (assemblies, external_aliases, modules)
11303 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11304 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11305 overhead. Move resposibility ...
11306 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11307 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11309 2005-10-23 Raja R Harinath <harinath@gmail.com>
11311 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11312 cached_namespaces. Improve usage.
11313 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11314 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11315 Move from GlobalRootNamespace and simplify.
11316 (RootNamespace.Global): Make instance variable.
11317 (RootNamespace.RootNamespace): Add "alias name" parameter.
11318 (GlobalRootNamespace): Simplify drastically.
11319 (Namespace.Lookup): Don't use GetNamespace.
11320 * typemanager.cs (GetRootNamespace): Rename from
11321 ComputeNamespaceForAlias.
11322 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11324 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11326 * anonymous.cs (AnonymousContainer): Don't crash when container
11329 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11331 * expression.cs (Binary.DoResolve): Warn when comparing same
11334 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11337 * expression.cs (Binary.DoResolve): It looks like there are no
11338 convetsion rules in enum context.
11340 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11342 Add support for extern alias qualifiers.
11343 * typemanager.cs: Move some LookupTypeReflection code
11344 to namespace.cs, to have cleaner code. Added some methods
11345 to help us keep track of the extern aliased references.
11346 * driver.cs: Add suport for extern alias assemblies on command
11347 line and check for their warnings/errors. Also keep track of the
11348 extern aliased assemblies.
11349 * namespace.cs: Move the global functionality of Namespace
11350 to GlobalRootNamespace/RootNamespace. Now the global namespace
11351 is GlobalRootNamespace.Globa. Also the code moved from
11352 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11353 Finally added LocalAliasEntry (AliasEntry before) and
11354 ExternAliasEntry, to handle alias statements.
11355 * cs-parser.jay: Add support in the grammar for extern alias
11357 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11358 Update callings to Namespace (now in GlobalRootNamespace).
11360 2005-10-18 Raja R Harinath <rharinath@novell.com>
11363 * class.cs (TypeContainer.DefineType): Move updating of
11364 topological sort earlier in the code.
11365 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11367 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11370 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11372 * constant.cs (Constant.TryReduce): Moved from Cast class.
11373 (Reduce): Made little bit more OO and fixed missing conversions.
11375 * ecore.cs (Reduce): Implemented.
11376 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11378 * literal.cs (Reduce): Implemented.
11380 * class.cs: Reverted Miguel's wrong commit.
11382 2005-10-14 Miguel de Icaza <miguel@novell.com>
11384 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11386 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11388 * cs-parser.jay, expression.cs : CS0214 was missing error location
11389 for constants. Fixed bug #76404.
11391 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11394 * convert.cs (ExplicitConversionCore): Fixed object->enum
11397 2005-10-10 Raja R Harinath <rharinath@novell.com>
11399 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11400 InstanceExpression.
11401 (PropertyExpr.EmitCall): Likewise.
11402 * expression.cs (Invocation.EmitArguments): Handle case where
11404 (Invocation.EmitCall): Avoid allocating temporary variable if
11405 there are no arguments.
11407 2005-10-07 Raja R Harinath <rharinath@novell.com>
11410 * convert.cs (ImplicitConversionStandard): Move conversion of
11411 void* to arbitrary pointer types ...
11412 (ExplicitConversionStandard): .. here.
11413 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11414 error to always print typenames.
11416 2005-10-07 Raja R Harinath <rharinath@novell.com>
11418 * convert.cs (GetConversionOperator): Rename from
11419 GetConversionOperators. Move operator selection code from ...
11420 (UserDefinedConversion): ... here.
11422 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11424 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11427 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11429 * assign.cs (Assign.DoResolve): Error method changed.
11431 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11433 * const.cs (ResolveValue): Reset in_transit immediately.
11435 * constant.cs: Error method changed.
11437 * convert.cs: Removed useless location parameter.
11438 (ExplicitNumericConversion): Don't do double enum check.
11439 (ExplicitConversionCore): Renamed from ExplicitConversion.
11440 (ExplicitUnsafe): Extracted from ExplicitConversion.
11441 (ExplicitConversion): Uses for error reporting.
11443 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11445 (ResolveBoolean): Uses common error method.
11446 (CastToDecimal): Get rid of ec.
11447 (CastFromDecimal): Optimized.
11448 (ConvCast): Get rid of ec.
11450 * enum.cs (ResolveValue): Reset in_transit immediately.
11451 (Emit): Return after first error.
11453 * expression.cs: Convert changes.
11455 * literal.cs: Error method changed.
11457 * statement.cs: Error method changed.
11459 2005-10-03 Raja R Harinath <rharinath@novell.com>
11461 * support.cs (SeekableStreamReader.Position): Don't error out when
11462 the requested position is just beyond the end of the current
11465 2005-09-28 Raja R Harinath <rharinath@novell.com>
11467 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11468 try to keep in sync with the byte count of the underlying Stream.
11469 However, this limits us to a window size of 2048 characters: i.e.,
11470 the maximum lookahead of our lexer/parser can be 2048 characters.
11472 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11475 * driver.cs: Fix compilation files with full root path.
11477 2005-09-25 Miguel de Icaza <miguel@novell.com>
11479 * report.cs (SymbolRelatedToPreviousError): Format the output so
11480 it does not use an open parenthesis that is never closed.
11482 * driver.cs: Follow coding guidelines
11484 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11487 * const.cs (Const.ResolveValue): Check for assigning non-null
11488 value to reference type.
11490 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11492 * anonymous.cs: Implemented ExprClassName.
11494 * assign.cs (Assign.DoResolve): Don't chrash when type is not
11497 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
11500 * class.cs (StaticClass.DefineContainerMembers): Report protected
11503 * codegen.cs: if(ed) PRODUCTION.
11505 * convert.cs (Error_CannotImplicitConversion): Better error
11508 * cs-parser.jay: More error checks.
11510 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
11512 * driver.cs (CSCParseOption): Enabled wrong option check.
11514 * ecore.cs (Expression.ExprClassName): Turned to property.
11515 (MemberExpr.CheckIntermediateModification): For checking boxed
11516 value types modification.
11518 * statement.cs (Fixed.Resolve): Expression type must be
11519 convertible to fixed type.
11520 (CollectionForeach.GetEnumeratorFilter,TryType):
11521 Small refactoring for easier error checking.
11523 2005-09-26 Marek Safar <marek.safar@seznam.cz>
11525 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
11528 * class.cs (GeneratedBaseInitializer): New class for customization
11529 compiler generated initializers.
11530 (MemberBase.DoDefine): Check Obsolete attribute here.
11531 (FieldMember.DoDefine): Ditto.
11533 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
11536 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
11537 (MemberCore.GetObsoleteAttribute): Removed argument.
11538 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
11539 (MemberCore.CheckObsoleteType): New helper.
11543 * statement.cs: Updates after MemberCore changes.
11545 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
11546 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
11548 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
11549 obsolete attribute for compiler construct.
11550 (As.DoResolve): Cache result.
11552 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
11554 2005-09-26 Raja R Harinath <rharinath@novell.com>
11557 * expression.cs (This.VerifyFixed): In a value type T, the type of
11558 'this' is T&, iow, 'this' is either an out or ref parameter. In a
11559 value type R, 'this' is treated as a value parameter.
11561 2005-09-22 Miguel de Icaza <miguel@novell.com>
11563 * statement.cs (Lock): Use the TemporaryVariable class instead of
11564 manually using local variables as those do not work when variables
11567 * ecore.cs: Moved the TemporaryVariable class from being a nested
11568 class inside Foreach to be a public class that can be employed in
11571 2005-09-19 Marek Safar <marek.safar@seznam.cz>
11573 * cs-parser.jay: interface_accessors replaced by
11574 accessor_declarations.
11576 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
11579 * statement.cs (GotoCase.Resolve): Convert null constant to
11581 (SwitchLabel.ResolveAndReduce): Ditto.
11582 (SwitchLabel.NullStringCase): Custom null stamp.
11583 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
11585 typemanager.cs (CSharpSignature): Don't skip first argument
11588 2005-09-18 Miguel de Icaza <miguel@novell.com>
11590 * driver.cs: Set InEmacs based on the environment variable EMACS.
11592 * location.cs (InEmacs): in this mode, do not report column
11593 location as it confuses Emacs.
11595 2005-09-16 Marek Safar <marek.safar@seznam.cz>
11597 * cfold.cs, constant.cs, convert.cs, ecore.cs,
11598 expression.cs, iterators.cs, literal.cs: Store constants and
11601 * class.cs (MemberBase.ShortName): Pass location.
11603 * cs-parser.jay: Some location fixes.
11605 * ecore.cs (Expression.Location): Made virtual.
11607 2005-09-05 Miguel de Icaza <miguel@novell.com>
11609 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
11610 if the underlying types are the same, otherwise we need to produce
11611 code that will do the proper cast.
11613 This was exposed by Marek's constant rewrite which produced
11614 invalid code for the call site:
11616 enum X : long { a }
11617 void Method (X v) {}
11621 This fixes test-49.cs
11623 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11625 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
11626 Type/Object should be allowed as well. Fixed bug #75968.
11628 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11630 * expression.cs : (Binary.DoResolve): when one is enum constant and
11631 another is constant 0, then return enum one *as enum type*.
11634 2005-09-02 Raja R Harinath <rharinath@novell.com>
11636 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
11640 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
11641 flow-branching for LocalVariableReferences in case we were invoked
11642 from a MemberAccess.
11643 * expression.cs (LocalVariableReference.VerifyAssigned): New.
11645 (LocalVariableReference.DoResolveBase): ... this.
11646 (MemberAccess.Resolve): Do the check that was disabled during
11649 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11652 (PartialContainer.Create): check abstract/sealed/static strictly
11653 but abstract/sealed can exist only at one side. Fixed bug #75883.
11655 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
11658 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
11659 specified, don't default to UnmanagedType.I4.
11661 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11663 * expression.cs : conditional operator should check possibly
11664 incorrect assign expression. Fixed bug #75946.
11666 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11668 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
11669 Reverting the change. gmcs is much complex than mcs on this matter.
11671 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11673 * cs-tokenizer.cs : To read another token ahead of the actual
11674 consumption, use new SavedToken and cache token instead of moving
11675 back the stream with SeekableStreamReader (it seemed problematic).
11677 driver.cs : Thus use StreamReader directly.
11678 * support.cs : Thus removed SeekableStreamReader.
11680 2005-08-30 Raja R Harinath <rharinath@novell.com>
11683 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
11684 (ScopeInfo.EmitScopeType): Use it to construct field names from
11685 names of captured locals.
11688 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
11689 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
11690 Pass 'target_type' to BoxedCast. Don't default to 'object'.
11691 (ExplicitConversion): Remove enum cases already handled by
11692 implicit conversion. Move implicit conversion check to the beginning.
11693 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
11694 * expression.cs (ArrayCreation.EmitDynamicInitializers):
11695 Don't treat System.Enum as a struct.
11697 2005-08-30 Jb Evain <jbevain@gmail.com>
11699 * attribute.cs: handles as expression in parameters.
11701 2005-08-30 Raja R Harinath <rharinath@novell.com>
11704 * class.cs (TypeContainer.VerifyClsName): Don't use a
11705 PartialContainer when verifying CLS compliance.
11706 (AbstractPropertyEventMethod): Set Parent here, ...
11707 (PropertyMethod): ... not here.
11709 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
11711 * attribute.cs : escaped attribute name should not be allowed to be
11712 resolved (e.g. @class as classAttribute). Fixed bug #75930.
11714 2005-08-29 Raja R Harinath <rharinath@novell.com>
11717 * convert.cs (ImplicitStandardConversionExists): Allow zero also
11718 when converting a long constant to unsigned long.
11719 * expression.cs (Invocation.OverloadResolve): Add sanity check to
11720 detect where IsApplicable and VerifyArgumentsCompat disagree.
11722 2005-08-29 Raja R Harinath <rharinath@novell.com>
11723 and Carlos Alberto Cortez <carlos@unixmexico.org>
11726 * class.cs (TypeContainer.CanElideInitializer): New helper.
11727 (TypeContainer.EmitFieldInitializers): Use it to determine if we
11728 can safely emitting the initializer of a field.
11730 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11732 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
11733 allowed inside a switch (without loop). Fixed bug #75433.
11735 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
11737 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
11738 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
11740 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11742 * driver.cs : kinda reverting the default encoding changes (not exact
11743 revert since I noticed that "codepage:reset" might not work fine).
11745 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11747 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
11748 Location. Now getter and setter store location correctly.
11749 (errors/cs0111-12.cs now reports the expected location.)
11751 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11753 * driver.cs : Use default encoding on the environment.
11754 Removed (now that) extra parameter for SeekableStreamReader.
11755 * support.cs : (SeekableStreamReader) third .ctor() argument for
11756 StreamReader is not required (always true). preamble size could
11757 be acquired in simpler and safe way.
11759 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
11761 * cs-parser.jay: report CS0642 at warning level 3
11762 and report CS0642 for an if else statement also
11763 fixes bug #74745. Patch by John Luke (and a bit
11765 Removed extra CS0642 warning check for "while",
11767 * statement.cs: In Block.Resolve(), CS0642 check
11768 is reimplemented to check a sequence of an empty
11769 statement and a block.
11771 Both fix bug #66777.
11773 2005-08-24 Marek Safar <marek.safar@seznam.cz>
11775 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
11776 detection until I fix it.
11778 * cs-tokenizer.cs: Changed error message.
11780 * cs-parser.jay: Fixed 2 error locations.
11782 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
11783 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
11786 * enum.cs (GetSignatureForError): Fixed.
11788 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
11792 * typemanager.cs (RegisterProperty): Removed.
11794 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
11796 2005-08-24 Raja R Harinath <rharinath@novell.com>
11799 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
11800 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
11802 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11804 * expression.cs : tiny fix is required for not warning positive ulong.
11807 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11809 * expression.cs : add CS0652 check for constant and integral
11810 expression. Fixed bug #53974.
11812 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11814 * expression.cs : in DoNumericPromotions(), check if there is implicit
11815 conversion overload for string (to check CS0034). Fixed bug #52492.
11817 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11819 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
11821 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11823 * ecore.cs : report location when it is *not* Null.
11825 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11831 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
11832 correctly. Fixed bug #75721.
11834 2005-08-23 Raja R Harinath <rharinath@novell.com>
11836 * support.cs (SeekableStreamReader.Position): Avoid an expensive
11837 loop that performs 'min (pos, char_count)'.
11840 * expression.cs (Unary.ResolveOperator): Don't discard implicit
11841 converted value in Operator.OnesComplement.
11843 2005-08-22 Ben Maurer <bmaurer@ximian.com>
11845 * anonymous.cs: If the anon method is pulled into a helper class,
11846 it needs to be `internal' not `private'. Fixes runtime behavior on
11849 2005-08-20 Martin Baulig <martin@ximian.com>
11851 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11852 scope if we don't already have it.
11854 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
11855 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
11858 2005-08-17 Marek Safar <marek.safar@seznam.cz>
11861 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
11862 is a partial class.
11864 2005-08-16 Marek Safar <marek.safar@seznam.cz>
11866 The big constants rewrite
11867 Fix #75746, #75685 and more
11868 As a side effect saved 1MB for MWF ;-)
11870 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
11871 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
11872 enum based for corlib compilation.
11874 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
11877 * class.cs (FixedField.Define): Use ResolveAsConstant.
11879 * const.cs (IConstant): Interface constants and enums.
11880 (Const.ResolveValue): New method for constant resolvning.
11881 (ExternalConstant): Constants from imported assemblies.
11883 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
11884 conversion; like enums.
11885 (Constant.ToType): Converts this constant to different type.
11886 (Constant.Increment): Adds 1.
11888 * convert.cs (ImplicitConversionRequired): Simplified.
11890 * cs-parser.jay: Create EnumMember directly.
11892 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
11894 * doc.cs (GenerateEnumDocComment): Removed.
11896 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
11897 (ConvertIntLiteral): Removed.
11898 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
11900 * enum.cs (EnumMember): Implement IConstant.
11901 (Enum.IsValidEnumConstant): Removed.
11902 (Enum.GetNextDefaultValue): Removed.
11903 (Enum.FindMembers): Updated.
11904 (Enum.GenerateDocComment): Iterate enum members.
11906 * expression.cs (Cast.TryReduce): Handle enums correctly.
11907 (New.Constantify): Made public.
11908 (MemberAccess.DoResolve): Removed contant specific if(s).
11910 * literal.cs (NullLiteral): Implement new abstract methods.
11912 * statement.cs (GotoCase.Resolve): Use new constant methods.
11913 (SwitchLabel.ResolveAndReduce): Use new constant methods.
11915 * typemanager.cs (LookupEnum): Removed.
11916 (IsEnumType): Fixed to work with corlib.
11917 (RegisterConstant): Removed.
11918 (LookupConstant): Removed.
11919 (GetConstant): Changed to work with IConstant.
11921 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
11923 * location.cs : Fixed overflown (>255) column number.
11925 2005-08-03 Raja R Harinath <rharinath@novell.com>
11927 First cut of the qualified-alias-member feature.
11928 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
11930 * cs-parser.jay (DOUBLE_COLON): New token.
11931 (namespace_or_type_name): Add rule for recognizing
11932 qualified-alias-members.
11933 (primary_expression): Likewise.
11934 (element_access): Allow QualifiedAliasMember as a possible
11935 type-bearing expression.
11936 (local_variable_type, local_variable_pointer_type): Likewise.
11937 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
11938 aliases in the current and enclosing namespace declarations.
11939 (NamespaceEntry.UsingAlias): Add CS0440 warning.
11940 * decl.cs (MemberName.is_double_colon): New.
11941 (MemberName.MemberName): Add new constructor for alias-member.
11942 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
11943 * expression.cs (QualifiedAliasMember): New expression type.
11945 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11947 * location.cs : it borked when no argument was specified.
11949 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11951 * location.cs : tiny ToString() format fix.
11953 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11955 * statement.cs : oops, it was missing.
11957 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11959 A set of fixes for precise line/column location.
11962 "token" field now holds a file/line "delta", a line number offset
11963 from the segment, and a column number. See also:
11964 http://lists.ximian.com/pipermail/mono-devel-list/2004-
11965 December/009508.html
11966 Removed static IsNull. Use instance IsNull property instead.
11967 * cs-tokenizer.cs :
11968 For some tokens it stores Location. For Identifier it stores
11969 LocatedToken which is a pair of string name and location.
11970 Column numbers are adjusted only at getChar().
11972 Use Location.ToString() for reporting (it now contains column).
11974 Largely modified to use LocatedToken instead of
11975 string (IDENTIFIER), and to acquire Location from some tokens.
11976 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
11977 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
11979 Now MemberName holds Location. DeclSpace.ctor() receives Location
11980 as a parameter. Removed extra parameters to all derived classes.
11981 Replaced Location.IsNull() with instance property.
11982 * assign.cs, expression.cs :
11983 Added .ctor() overload that omits Location.
11985 Added "nameEscaped" flag that indicates the identifier was escaped
11986 in the source file. This fixes bug #57047.
11988 2005-08-02 Marek Safar <marek.safar@seznam.cz>
11990 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
11991 New method, looking for lo-case imported cls type.
11993 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
11996 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
11998 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12000 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12001 all_imported_types.
12002 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12004 Optimized to save 3.5 MB for SWF compilation.
12006 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12008 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12009 (PartialContainer.Create): Moved logic AddToContainer.
12010 (PartialContainer.MarkForDuplicationCheck): Shares name.
12012 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12015 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12017 (Namespace.GetSignatureForError): New method.
12019 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12020 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12022 2005-08-01 Raja R Harinath <rharinath@novell.com>
12025 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12026 member lookup rather than qualifier_type, since qualifier_type can
12029 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12031 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12034 2005-07-31 Miguel de Icaza <miguel@novell.com>
12036 * statement.cs: Copy the local exception into the exception
12037 captured local. Fixes 75674
12039 2005-07-31 Raja R Harinath <harinath@gmail.com>
12042 * expression.cs (Invocation.OverloadResolve): Don't report error
12043 CS1501 if error CS1502 has been reported.
12044 (New.DoResolve): Delegate CS1501 reporting to
12045 Invocation.OverloadResolve.
12048 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12049 invariant-meaning-in-block property in an enclosing block if
12052 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12054 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12055 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12056 (Switch.CheckSwitch): Just save 50kb for SWF.
12058 2005-07-27 Martin Baulig <martin@ximian.com>
12060 * anonymous.cs (CaptureContext.AddField): Added
12061 `AnonymousContainer am' argument; compute its toplevel scope if
12062 it's not already computed. Fixes #75649.
12064 2005-07-26 Raja R Harinath <rharinath@novell.com>
12067 * class.cs (Constructor.Emit): Reset block to null if the block
12070 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12072 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12074 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12076 * class.cs (MethodData.Define): Check whether accessor implementing
12077 interface is public.
12079 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12081 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12084 * namespace.cs (LookupType): Moved same type check to...
12086 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12087 with the same name.
12089 2005-07-21 Raja R Harinath <rharinath@novell.com>
12091 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12092 already found a typebuilder.
12093 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12094 MemberNames, not strings.
12096 * const.cs (Error_ExpressionMustBeConst):
12097 Rename from Error_EpressionMustBeConst.
12098 * const.cs, class.cs, statement.cd: Update.
12100 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12104 * const.cs (Const.LookupConstantValue): Report missing contant expression
12106 (Error_EpressionMustBeConstant): Only one error method.
12108 * class.cs, statement.c: Updated.
12110 2005-07-20 Raja R Harinath <rharinath@novell.com>
12112 * statement.cs (Block.Flags): Add back HasVarargs.
12113 (Block.flags): Make protected.
12114 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12116 * typemanager.cs (types, typecontainers, user_types): Remove.
12117 (UserTypes, TypeContainers): Likewise.
12118 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12119 (CleanUp, Reset): Update.
12120 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12121 (GetNestedType): Use Type.GetNestedType.
12122 (CoreLookupType): Take two arguments, the namespace and the
12123 basename of the type. Update to use the Namespace.Lookup
12125 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12126 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12127 string concatenation and substring matches.
12128 * class.cs, enum.cs, delegate.cs: Update to changes.
12130 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12132 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12133 Expression and made virtual.
12135 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12136 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12138 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12140 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12143 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12146 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12149 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12150 AssemblyCultureAttribute is not used on executable.
12153 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12155 2005-07-16 Raja R Harinath <rharinath@novell.com>
12158 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12159 New. Reports CS0252/CS0253.
12160 Mostly taken from preliminary patch by Duncak Mak.
12161 (Binary.DoResolveOperator): Store results of operator lookup.
12162 Use them to detect if we need to warn about unintended reference
12165 2005-07-15 Raja R Harinath <rharinath@novell.com>
12168 * namespace.cs (Namespace.Lookup): Add back location parameter.
12169 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12170 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12172 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12173 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12174 (Namespace.LookupType): ... this.
12175 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12177 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12178 purported to handle pointers.
12179 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12182 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12184 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12187 2005-07-15 Raja R Harinath <rharinath@novell.com>
12189 * namespace.cs (Namespace.Lookup): Drop location parameter.
12190 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12191 (NamespaceEntry.Lookup): ... this.
12192 (NamespaceEntry.Error_AmbiguousTypeReference):
12193 Move here from DeclSpace.
12194 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12196 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12197 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12198 Move to NamespaceEntry.
12199 * delegate.cs, expression.cs: Update to changes.
12201 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12203 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12204 CheckAttributeType and refactored.
12205 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12206 ResolveAsTypeTerminal error handling.
12207 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12209 (GetSignatureForError): Print errors in same way.
12212 * codegen.cs: Reflect attribute GetSignatureForError change.
12215 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12217 * namespace.cs (UsingEntry): Refactored to make fields private.
12220 statement.cs: Error_UnexpectedKind has extra parameter.
12222 2005-07-14 Raja R Harinath <rharinath@novell.com>
12224 * ecore.cs (IAlias): Remove.
12225 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12226 that implement the interface.
12227 * namespace.cs (Namespace): Likewise.
12228 (Namespace.declspaces): Renamed from 'defined_names'.
12229 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12230 DeclSpace instead of an IAlias.
12231 * tree.cs (Tree.AddDecl): Update.
12233 2005-07-12 Raja R Harinath <rharinath@novell.com>
12235 * statement.cs (Block.Flags); Remove HasVarargs.
12236 (Block.HasVarargs): Move to ToplevelBlock.
12237 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12238 (Block.Variables): Make protected. Initialize variable hashtable
12240 (Block.AddVariable): Update.
12241 (Block.Resolve): Update to changes.
12242 (ToplevelBlock.HasVarargs): New boolean.
12243 (ToplevelBlock.ThisVariable): Move here from Block.
12244 (ToplevelBlock.AddThisVariable): Likewise.
12245 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12246 * expression.cs (This.ResolveBase): Update to changes.
12247 (ArglistAccess.DoResolve): Likewise.
12249 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12252 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12254 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12255 not used and not used & assigned.
12256 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12258 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12261 * expression.cs (Is.DoResolve): null is never provided type.
12263 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12266 * cs-parser.jay: Less strict event error rule to catch more errors.
12268 2005-07-08 Martin Baulig <martin@ximian.com>
12270 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12271 gettter (allowed) or setter (not allowed).
12273 * class.cs (Accessor): Implement IIteratorContainer.
12274 (Accessor.Yields): New public field.
12275 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12276 per-accessor basis.
12279 (get_accessor_declaration, set_accessor_declaration): Set the
12280 `yields' flag on the accessor, not the property.
12281 (property_declaration): Do the iterators check on a per-accessor
12282 basis and not for the whole property.
12284 2005-07-08 Martin Baulig <martin@ximian.com>
12286 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12287 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12289 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12292 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12293 (ExtractSecurityPermissionSet): Cope with self referencing security
12294 attributes properly.
12296 * driver.cs (SetOutputFile): Made public property OutputFile.
12298 2005-07-07 Raja R Harinath <rharinath@novell.com>
12301 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12302 has_nonstatic_fields. Make into a FieldBase pointer.
12303 (TypeContainer.AddField): Add CS0282 check.
12304 (TypeContainer.EmitType): Update.
12306 2005-07-06 Miguel de Icaza <miguel@novell.com>
12308 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12309 compare if they start with __.
12311 2005-07-06 Raja R Harinath <rharinath@novell.com>
12313 * statement.cs (Switch.SwitchGoverningType): Only look at
12314 UserCasts that don't need implicit standard conversions to one of
12315 the allowed switch types (Fixes test-322.cs).
12316 (LocalInfo.Resolve): Re-enable sanity-test.
12318 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12320 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12322 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12324 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12326 2005-07-06 Raja R Harinath <rharinath@novell.com>
12329 * ecore.cs (SimpleName.GetSignatureForError): Add.
12330 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12331 (MemberAccess.GetSignatureForError): Add.
12333 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12335 The big error and warning messages review.
12365 * typemanager.cs: Updated.
12367 * class.cs: (MethodCore.SetYields): Moved here to share.
12368 (PropertyMethod.Define): Moved iterator setup here.
12370 * iterators.cs: Add orig_method to have full access to parent
12373 2005-07-05 Raja R Harinath <rharinath@novell.com>
12375 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12376 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12377 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12378 variable of struct type.
12379 * expression.cs (Unary.ResolveOperator): Update to change.
12380 (Indirection.VerifyFixed): Likewise.
12381 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12382 (ParameterReference.VerifyFixed): Value parameters are fixed.
12383 (This.VerifyFixed): Treat 'this' as a value parameter.
12384 * statement.cs (LocalInfo.IsFixed): Remove.
12386 2005-07-01 Martin Baulig <martin@ximian.com>
12388 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12389 `ec.EmitThis ()' to get the correct scope.
12391 2005-07-01 Martin Baulig <martin@ximian.com>
12393 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12394 instance is a ParameterReference; fixes #75299.
12396 2005-07-01 Martin Baulig <martin@ximian.com>
12398 Reverted Marek's latest patch (r46725):
12399 - it contains structural changes which are neither mentioned in
12400 the ChangeLog nor explained anywhere; for example the additional
12401 argument of EmitContext's and Iterator's .ctor's and the
12402 TypeContainer.DefineMembers() change.
12403 - structural changes like this should go in in seperate patches
12404 and not be hidden in a huge patch which just seems to affect
12405 warnings and errors.
12406 a big and hard to understand patch.
12407 - it breaks iterators and causes regressions, for instance in
12410 2005-06-30 Raja R Harinath <rharinath@novell.com>
12413 * expression.cs (Indexers.map): Remove.
12414 (Indexers.Append): Filter out inaccessible setters and getters.
12415 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12418 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12419 Refactored from ...
12420 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12421 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12422 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12423 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12425 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12428 * class.cs (FieldBase.GetInitializerExpression): One more field
12431 2005-06-28 Miguel de Icaza <miguel@novell.com>
12433 * pending.cs: Do not define a proxy if the base method is virtual,
12434 it will be picked up by the runtime (bug 75270).
12436 2005-06-08 Martin Baulig <martin@ximian.com>
12438 The big Iterators rewrite :-)
12440 * iterators.cs: Rewrite this to use the anonymous methods framework.
12442 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12443 before the TypeContainers; see 2test-21.cs.
12446 (TypeContainer.DefineType): Don't create a new EmitContext if we
12447 already have one (this only happens if we're an Iterator).
12448 (TypeContainer.Define): Also call Define() on all our iterators.
12449 (Method.CreateEmitContext): Added support for iterators.
12452 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12453 (AnonymousContainer.CreateMethodHost): Moved here from
12454 AnonymousMethod and made abstract.
12455 (AnonymousContainer.CreateScopeType): New abstract method.
12456 (AnonymousContainer.IsIterator): New public property.
12457 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12458 get the ScopeTypeBuilder rather than manually defining it here.
12459 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12462 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12463 before RootContext.DefineTypes().
12465 * codegen.cs (EmitContext.RemapToProxy): Removed.
12466 (EmitContext.CurrentAnonymousMethod): Changed type from
12467 AnonymousMethod -> AnonymousContainer.
12468 (EmitContext.ResolveTopBlock): Protect from being called twice.
12469 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12470 (EmitContext.EmitThis): Removed the iterators hacks; use the
12471 anonymous methods framework for that.
12474 (ToplevelBlock.Container): Make this a property, not a field.
12475 (ToplevelBlock.ReParent): New public method; move the
12476 ToplevelBlock into a new container.
12477 (Foreach.TemporaryVariable): Simplify.
12479 2005-06-05 Martin Baulig <martin@ximian.com>
12481 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12482 (Block.AddTemporaryVariable): New public method; creates a new
12483 `LocalInfo' for a temporary variable.
12484 (Block.EmitMeta): Create the LocalBuilders for all the temporary
12486 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
12487 non-iterator variables.
12489 2005-06-05 Martin Baulig <martin@ximian.com>
12491 * statement.cs (Foreach.TemporaryVariable): Create the
12492 LocalBuilder in the Emit phase and not in Resolve since in some
12493 situations, we don't have an ILGenerator during Resolve; see
12494 2test-19.cs for an example.
12496 2005-06-04 Martin Baulig <martin@ximian.com>
12498 **** Merged r45395 from GCS ****
12500 The big Foreach rewrite - Part II.
12502 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
12503 with `PropertyInfo ienumerator_getcurrent'.
12505 * codegen.cs (VariableStorage): Removed.
12508 (Foreach): Derive from Statement, not ExceptionStatement.
12509 (Foreach.CollectionForeach): New nested class. Moved all the code
12510 dealing with collection foreach here.
12511 (Foreach.ForeachHelperMethods): Removed.
12512 (Foreach.TemporaryVariable): Implement IMemoryLocation.
12514 2005-05-23 Martin Baulig <martin@ximian.com>
12516 * statement.cs (Try.DoResolve): Don't create a `finally' if we
12517 don't need to. Fix #75014.
12519 2005-05-20 Martin Baulig <martin@ximian.com>
12521 Merged r44808 from GMCS.
12523 * class.cs (TypeContainer.CircularDepException): Removed.
12524 (TypeContainer.DefineType): Removed the `InTransit' stuff.
12525 (TypeContainer.CheckRecursiveDefinition): Check for circular class
12526 (CS0146) and interface (CS0529) dependencies here.
12528 2005-06-21 Raja R Harinath <rharinath@novell.com>
12530 * expression.cs (Invocation.EmitCall): Fix initialization
12531 'this_call' to reflect current behaviour. Fix indentation.
12533 * convert.cs (FindMostEncompassedType): Add two trivial special
12534 cases (number_of_types == 0 || number_of_types == 1).
12535 (FindMostEncompasingType): Likewise.
12537 2005-06-17 Raja R Harinath <rharinath@novell.com>
12539 Some cleanups preparing for the fix of #75283.
12540 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
12542 (EventExpr.InstanceResolve): Likewise.
12543 (EventExpr.DoResolve): Remove redundant checks.
12545 2005-06-10 Duncan Mak <duncan@novell.com>
12547 * cs-tokenizer.cs (process_directives): New flag for controlling
12548 the processing of preprocessor directives.
12549 (x_token): After seeing a '#', return Token.NONE instead of going
12550 to handle_preprocessing_directive() when not processing
12551 directives. This avoids unnecessary processing during the token peek in
12556 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
12557 the existing error reporting methods instead of Report.Error.
12559 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
12560 after Raja's rewrite.
12562 2005-06-08 Miguel de Icaza <miguel@novell.com>
12564 * class.cs: Small fix.
12566 2005-06-08 Raja R Harinath <rharinath@novell.com>
12569 * class.cs (GetPartialBases): Fix return value check of
12570 part.GetClassBases.
12572 2005-06-07 Raja R Harinath <rharinath@novell.com>
12574 Ensure that partial classes are registered in their enclosing
12575 namespace. Initial part of fix of #75160.
12576 * tree.cs (Tree.RecordDecl): Add new namespace argument.
12577 Register declspace with namespace here, not in
12578 DeclSpace.RecordDecl.
12579 * cs-parser.jay: Pass namespace to RecordDecl.
12580 * class.cs (PartialContainer.Create): Likewise.
12581 (ClassPart.DefineType): New sanity-check. Throws an exception if
12583 * decl.cs (Declspace.RecordDecl): Remove.
12584 * namespace.cs (NamespaceEntry.DefineName): Remove.
12586 2005-06-06 Marek Safar <marek.safar@seznam.cz>
12588 * rootcontext.cs: Reset TargetExt as well.
12590 2005-06-03 Raja R Harinath <rharinath@novell.com>
12592 * ecore.cs (Expression.Resolve): Emit CS0654 error when
12593 -langversion:ISO-1.
12595 2005-06-02 Raja R Harinath <rharinath@novell.com>
12597 Fix #75080, cs0119.cs.
12598 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
12600 (Expression.Resolve): ... this. Use it. Remove bogus code
12601 allowing ExprClass.Type and ExprClass.Namespace for
12602 ResolveFlags.VariableOrValue.
12603 (Expression.Resolve) [1-argument variant]: Change default resolve
12604 flags based on language version.
12605 (Expression.Error_UnexpectedKind): Use a simple string array
12606 rather than an ArrayList.
12607 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
12608 not ExprClass.Type.
12609 (TypeOfVoid.DoResolve): Likewise.
12610 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
12611 flags argument -- it always has the same value.
12613 2005-05-31 Raja R Harinath <rharinath@novell.com>
12616 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
12617 Use it in the error message.
12618 * assign.cs, expression.cs, statement.cs: Update.
12620 2005-05-30 Raja R Harinath <rharinath@novell.com>
12623 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
12624 the "almostMatchedMember" case too.
12625 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
12626 that failed the accessibility checks to 'almost_match'.
12628 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
12630 * attribute.cs: Use internal MethodBuilder methods to set
12631 ExactSpelling and SetLastError on PInvoke methods, instead
12632 of passing them via charset. Fixes #75060.
12634 2005-05-27 Raja R Harinath <rharinath@novell.com>
12636 * parameter.cs (Parameter): Remove TODO comment.
12637 (Parameter.DefineParameter): Remove Location parameter.
12638 (Parameters.LabelParameters): Likewise.
12639 * class.cs (Constructor.Emit): Update to change.
12640 (MethodData.Emit): Likewise.
12641 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
12642 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
12644 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
12647 Removed Parameters.Location and added Parameter.Location instead.
12648 Removed Location parameter from Emit() and GetSignature().
12655 Modified all related calls.
12657 2005-05-26 Raja R Harinath <rharinath@novell.com>
12659 Improve user-defined conversion handling.
12660 * convert.cs (GetConversionOperators): Rewrite. Return only the
12661 applicable operators.
12662 (AddConversionOperators): New. Helper for GetConversionOperators.
12663 (FindMostEncompassedType, FindMostEncompassingType): Verify that
12664 there is only one most encompassed/encompassing type.
12665 (FindMostSpecificSource, FindMostSpecificTarget): Remove
12666 "applicable operator" handling.
12667 (UserConversion): Move cache here from GetConversionOperators.
12668 Directly cache the chosen operator, rather than the whole
12670 (ExplicitNumericConversion): Fix buggy implementation of Decimal
12671 case. Allow conversion of decimal to sbyte and byte too.
12672 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
12673 New static methods. Used to avoid allocating EmptyExpressions in
12676 2005-05-24 Duncan Mak <duncan@novell.com>
12678 * ecore.cs (CastFromDecimal): New class for casting a decimal to
12679 another class, used in Convert.ExplicitNumericConversion.
12680 (CastToDecimal): New class, similar to above, but casts to
12681 System.Decimal, used in Convert.ImplicitNumericConversion and also
12682 in explicit convesion from double/float to decimal.
12684 * convert.cs (ImplicitNumericConversion): Handle implicit
12685 conversions to System.Decimal.
12686 (ExplicitNumericConversion): handle explicit conversions to
12691 2005-05-20 Miguel de Icaza <miguel@novell.com>
12693 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
12694 know the type at this stage, just break through. Fixes #75008
12696 2005-05-19 Martin Baulig <martin@ximian.com>
12699 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
12700 to disable error reporting.
12702 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
12703 here since we don't want to report an error; see the new test-336.cs.
12705 2005-05-19 Raja R Harinath <rharinath@novell.com>
12707 * statement.cs (ToplevelBlock.GetParameterReference)
12708 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
12709 Move here from class Block.
12710 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
12711 * expression.cs (ParameterReference.DoResolveBase): Likewise.
12713 2005-05-18 Martin Baulig <martin@ximian.com>
12718 (FlowBranching.Reachability): Add non-static public And() and Or()
12720 (FlowBranchingSwitch): New class; do the `break_origins' thing
12721 like in FlowBranchingLoop.
12722 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
12723 reachability, not just locals and parameters.
12724 (FlowBranching.MergeChild): Remove some of the hacks for loop and
12725 switch; MergeBreakOrigins() now takes care of that.
12727 2005-05-18 Martin Baulig <martin@ximian.com>
12729 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12730 a loop and may leave it, reset the barrier; fixes #74974.
12732 2005-05-17 Marek Safar <marek.safar@seznam.cz>
12734 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
12737 * cs-parser.jay: Catch more lexical errors.
12739 * report.cs: Add one more Error method.
12742 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
12744 2005-05-17 Martin Baulig <martin@ximian.com>
12746 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
12749 2005-05-16 Raja R Harinath <rharinath@novell.com>
12751 Fix test-382.cs. Emit values of decimal constants.
12752 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
12754 (TypeContainer.AddField): ... this.
12755 (TypeContainer.EmitFieldInitializers): Allow the list of fields
12756 with initializers to include 'Const's.
12757 (ClassPart.RegisterFieldForInitialization): Forward to
12759 * const.cs (Const.Const): Pass initializer to base class.
12760 (Const.Define): In case of decimal constants, register them for
12761 initialization in a static constructor.
12763 2005-05-14 Martin Baulig <martin@ximian.com>
12765 * statement.cs (Block.Resolve): Correctly handle unreachable code;
12766 do not call ResolveUnreachable() on unreachable statements in
12767 here, see the comment in the source code.
12769 2005-05-13 Raja R Harinath <rharinath@novell.com>
12772 * expression.cs (BinaryResolveOperator): If one of the operands of
12773 an equality comparison is 'null' and the other is a pointer type,
12774 convert the null to a NullPointer.
12775 * convert.cs (ImplicitReferenceConversion): If the expression is a
12776 NullLiteral and the target type is a pointer type, return a
12777 NullPointer instead.
12778 (ImplicitConversionStandard): Likewise.
12780 2005-05-13 Marek Safar <marek.safar@seznam.cz>
12782 * cs-parser.jay: Set readonly context based on special constructs.
12784 * expression.cs (LocalVariableReference.DoResolveBase): Improved
12785 readonly variable error handling.
12787 * rootcontext.cs (EmitCode): Don't verify members when error
12790 * statement.cs (LocalInfo): Add reaodnly context information.
12791 (SetReadOnlyContext, GetReadOnlyContext): New methods.
12793 2005-05-13 Raja R Harinath <rharinath@novell.com>
12795 * statement.cs (Block.Resolve): Revert change below. Modify fix
12796 for #74041 to initialize 'resolved' to false only for explicit
12797 blocks. Fixes #74873.
12799 2005-05-12 Raja R Harinath <harinath@gmail.com>
12802 * typemanager.cs (unmanaged_enclosing_types): New.
12803 (IsUnmanagedType): Avoid infloops by using
12804 'unmanaged_enclosing_types' to talk with recursive invocations.
12806 2005-05-13 Martin Baulig <martin@ximian.com>
12808 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
12809 instance variable, not a local. Fix #74873.
12810 (Block.ResolveUnreachable): Set it to true here.
12812 2005-05-11 Duncan Mak <duncan@novell.com>
12814 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
12815 continuing to process for 'arg'.
12816 (handle_preprocessing_directive): Check the argument of the #endif
12817 directive and report error CS1025 if there are any trailing
12820 According to the C# spec, having even whitespace after the #endif
12821 directive is illegal; however, because we call arg.TrimEnd ()
12822 beforehand, we have the same behavior as csc, allowing whitespace
12823 after the directive.
12827 2005-05-11 Marek Safar <marek.safar@seznam.cz>
12831 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
12832 (Constructor.GetObsoleteAttribute): Implemented correctly.
12834 2005-05-10 Martin Baulig <martin@ximian.com>
12836 * support.cs (ReflectionParameters.ParameterModifier): Use
12837 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
12838 and `ParameterAttributes.In'. Fixes #74884.
12840 2005-05-10 Marek Safar <marek.safar@seznam.cz>
12842 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
12844 * expression.cs (Argument.GetParameterModifier): Turned to property.
12845 (Invocation.Error_InvalidArguments): Add more descriptive errors.
12847 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
12850 2005-05-09 Raja R Harinath <rharinath@novell.com>
12853 * decl.cs (MemberCache.AddMethods): Register override methods,
12854 rather than non-override methods.
12855 * typemanager.cs (RegisterOverride): New.
12856 (IsOverride): Update.
12858 2005-05-09 Marek Safar <marek.safar@seznam.cz>
12862 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
12863 recursive declaration.
12865 * statement.cs (Block.ResolveMeta): Report any error in resolving.
12867 2005-05-06 Marek Safar <marek.safar@seznam.cz>
12869 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
12871 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
12873 2005-05-05 Raja R Harinath <rharinath@novell.com>
12876 * decl.cs (DeclSpace.FamilyAccessible):
12877 Use TypeManager.IsNestedFamilyAccessible.
12879 Fix reopened #64812.
12880 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
12883 2005-05-04 Raja R Harinath <rharinath@novell.com>
12884 Abin Thomas <projectmonokochi@rediffmail.com>
12885 Anoob V E <projectmonokochi@rediffmail.com>
12886 Harilal P R <projectmonokochi@rediffmail.com>
12889 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
12890 allow access to all static members.
12892 2005-05-04 Martin Baulig <martin@ximian.com>
12894 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
12896 2005-05-04 Martin Baulig <martin@ximian.com>
12900 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
12901 section at the end; make things work if `default' is not the last
12904 2005-05-04 Martin Baulig <martin@ximian.com>
12908 * statement.cs (Switch): Replaced the `got_default' field with a
12909 `default_section' one.
12910 (Switch.CheckSwitch): Set `default_section' here.
12911 (Switch.Resolve): If we're a constant switch and the constant is
12912 not found, use the default section.
12914 2005-05-03 Martin Baulig <martin@ximian.com>
12916 * expression.cs (ArrayAccess.EmitGetLength): New public method.
12918 * statement.cs (Foreach.ArrayForeach): New nested class.
12919 (Foreach.TemporaryVariable): New nested class.
12920 (Foreach.EmitArrayForeach): Removed; this is now in the new
12921 ArrayForeach class.
12923 2005-05-03 Raja R Harinath <rharinath@novell.com>
12925 * pending.cs (BaseImplements): Move the #74773 fix here. This is
12927 (VerifyPendingMethods): Revert change below.
12929 * typemanager.cs (IsOverride, RegisterNonOverride): New.
12930 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
12931 that used to trigger warning -28. Remove warning -28.
12932 * expression.cs (Invocation.OverloadResolve): Use
12933 TypeManager.IsOverride to distinguish override methods.
12936 * pending.cs (VerifyPendingMethods): If a base type implements the
12937 requested interface, don't bother checking individual methods of
12938 the base type. As a side-effect, this prevents the creation of
12939 unnecessary proxies.
12941 2005-05-02 Martin Baulig <martin@ximian.com>
12945 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12946 Also `And' the locals if the old vector is null.
12947 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
12948 null; in this case we basically reset all the variables.
12950 2005-05-02 Martin Baulig <martin@ximian.com>
12954 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
12955 Added `FlowBranching branching' argument; always `and' the
12956 variables instead of `or'ing them unless we're an infinite loop.
12958 * statement.cs (While.Resolve): Create a new sibling unless we're
12961 2005-05-02 Martin Baulig <martin@ximian.com>
12965 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
12966 arguments; use it instead of creating a new TopLevelBlock.
12967 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
12968 our ConstructorInitializer.
12971 (TopLevelBlock.TopLevelBranching): New public property.
12972 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
12973 and create our `TopLevelBranching'.
12975 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
12976 anonymous method host, use `block.TopLevelBranching' rather than
12977 creating a new branching.
12979 2005-04-20 Miguel de Icaza <miguel@novell.com>
12981 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
12982 a ScopeInfo, if any of the current children is a child of the new
12983 entry, move those children there.
12985 2005-04-30 Martin Baulig <martin@ximian.com>
12987 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
12988 at the beginning of a SwitchSection. Fix #73335.
12990 2005-04-27 Marek Safar <marek.safar@seznam.cz>
12993 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
12995 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
12996 (FieldExpr.DoResolve): Obsolete members are ignored for field
12999 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13001 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13002 of arrays detection.
13004 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13006 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13008 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13011 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13013 * cs-parser.jay: Use the prefered version of -unsafe in error
13016 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13018 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13021 2005-04-20 John Luke <john.luke@gmail.com>
13023 * driver.cs: fix typo in error message, --outout to --output
13025 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13027 * codegen.cs (InRefOutArgumentResolving): New field.
13029 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13030 fields outside contructor.
13032 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13034 2005-04-19 Miguel de Icaza <miguel@novell.com>
13036 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13037 parameter code was not completed ever, so it was not as up-to-date
13038 as local variables. Must finish it.
13040 The bug fix was to compare the Toplevel of the block, not the
13041 current block. Thanks for Ben for pointing this out.
13043 2005-04-19 Raja R Harinath <rharinath@novell.com>
13045 * decl.cs (AddMethods): Use the declaring type of the problem
13046 method to determine if we want to squash a warning.
13048 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13050 * attribute.cs: Removed debug output.
13052 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13054 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13057 2005-04-18 Raja R Harinath <rharinath@novell.com>
13060 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13061 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13062 all null comparisons against reference types.
13064 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13067 * class.cs (TypeContainer.CircularDepException) New nested
13069 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13070 (TypeContainer.DefineType): Removed error, reset InTransit before
13072 (Class.DefineType): Throw exception when is in Transit.
13073 Catch exception and report error.
13074 (Struct.DefineType): Throw exception when is in Transit.
13075 Catch exception and report error.
13076 (Interface.DefineType): Throw exception when is in Transit.
13077 Catch exception and report error.
13079 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13080 handle nested exception handlers.
13082 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13085 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13086 InFinally and InCatch storage.
13088 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13089 (Catch.Resolve): Set and Restore ec.InCatch.
13090 (Try.Resolve): Set and Restore ec.InFinally.
13091 (Try.HasCatch): True when try has catch.
13093 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13095 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13096 for the same event member, so exclude such cases from warning 419.
13099 2005-04-16 Miguel de Icaza <miguel@novell.com>
13101 * expression.cs (Binary.ResolveOperator): Apply patch from John
13102 Luke to fix bug 59864: operators &, | and ^ on enumerations
13103 require that the same enum type on both sides.
13105 * driver.cs: Add warnings to old flag usage, this is to assist
13106 people who produce Makefiles and hope that the Makefiles will be
13109 * class.cs (TypeContainer.EmitType): Moved the definition of the
13110 special $PRIVATE$ field from the resolve phase to the Emit phase.
13111 During resolve we do not know if we are a struct with
13112 HasExplicitLayout, we know this only after the attributes for the
13115 Set the FieldOffset to zero on the dummy field that we create for
13116 the class. Fixes 74590.
13118 2005-04-16 Raja R Harinath <rharinath@novell.com>
13121 * ecore.cs (PropertyExpr.resolved): New.
13122 (DoResolve): Use it to handle a case of double resolution here.
13123 Handle a case of identical-name-and-type-name.
13124 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13125 resolution by storing the results of expression resolution back
13126 into the "probes" array.
13128 2005-04-15 Raja R Harinath <rharinath@novell.com>
13130 Fix cs0208-7.cs and cs0208-8.cs.
13131 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13132 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13133 error reporting to point out the reason a struct is not unmanaged.
13135 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13137 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13138 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13140 2005-04-13 Raja R Harinath <rharinath@novell.com>
13143 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13144 IdenticalNameAndTypeName here.
13145 (EventExpr.InstanceResolve): Likewise.
13147 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13149 C# 2.0 DefaultCharSetAttribute implementation
13151 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13152 which allows us to set GlobalNamespace for every resolve.
13153 (Attribute.ResolveArguments): Cut from Resolve.
13154 (Attribute.GetCharSetValue): Returns CharSet named argument.
13155 (Attribute.DefinePInvokeMethod): Gets default charset from
13157 (GlobalAttribute.ResolveAsTypeStep): Override.
13158 (GlobalAttribute.ResolveArguments): Override.
13160 * class.cs (TypeAttr): Is protected.
13162 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13163 (ModuleClass.DefaultCharSetType): New memeber.
13164 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13166 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13167 charset from module.
13169 * delegate.cs (TypeAttr): Override.
13170 (Delegate.DefineType): Use this TypeAttr.
13172 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13173 at very early stage (before types are defined) to resolve model
13174 module attributes. It will probably not work with corlib but it
13177 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13178 charset from module.
13180 * typemanager.cs (default_charset_type): New type.
13182 2005-04-13 Raja R Harinath <rharinath@novell.com>
13184 * decl.cs (MemberCache.AddMethods): Don't warn if
13185 System.Object.Finalize has buggy MethodAttributes.
13187 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13190 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13192 * doc.cs : detect ambiguous reference to overloaded members.
13193 Fixed bug #71603. MS 1.1 csc does not detect it.
13195 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13197 * doc.cs : delegates must not be referenced with parameters.
13200 2005-04-12 Miguel de Icaza <miguel@novell.com>
13202 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13204 2005-04-10 Miguel de Icaza <miguel@novell.com>
13206 * driver.cs (MainDriver): Stop processing if the CLS stage found
13209 (CompilerCallableEntryPoint.InvokeCompiler): Always
13210 reset after execution; Take a TextWriter argument for the
13213 * report.cs: Use the error stream instead of hardcoding stderr.
13215 2005-04-09 Miguel de Icaza <miguel@novell.com>
13217 * class.cs: Reduce code paths to test, too small of an
13218 optimization to make it worth the extra testing. Always perform
13221 2005-04-08 Raja R Harinath <rharinath@novell.com>
13224 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13225 operators that had errors reported on them.
13227 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13229 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13231 (Attribute.Resolve): Add named argument type checking.
13233 * class.cs (FixedField.Define): Use IsPrimitiveType
13235 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13237 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13238 unsafe parameter types.
13240 * statement.cs (Using.ResolveExpression): Add better error description.
13242 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13244 2005-04-08 Raja R Harinath <rharinath@novell.com>
13247 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13248 AttributeUsageAttribute in the emitcontext of the attribute class,
13249 not in the emitcontext of the attributable entity it was attached to.
13250 * cs-parser.jay: Use 'current_class', not 'current_container',
13251 when creating a GlobalAttribute.
13253 2005-04-08 Alp Toker <alp@atoker.com>
13255 * pending.cs: The fix to #58413 failed to compile methods implementing
13256 interfaces with/without params modifiers and vice versa, even though
13257 params modifiers aren't part of the signature. Make the modifier check
13258 less strict as in csc.
13260 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13261 Anoob V E <projectmonokochi@rediffmail.com>
13262 Harilal P R <projectmonokochi@rediffmail.com>
13265 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13266 modifiers of pending methods.
13267 (PendingImplementation.PendingImplementation): Initialize it.
13268 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13269 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13270 with ParameterData. Add check for modifiers.
13271 * class.cs (MethodData.Define): Update to changes.
13273 2005-04-07 Raja R Harinath <rharinath@novell.com>
13275 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13277 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13279 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13282 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13285 * typemanager.cs: Registered RequiredAttributeAttribute.
13287 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13289 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13290 Warning CS0169 is back at level 3.
13291 (IMethodData.SetMemberIsUsed): New method.
13293 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13294 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13296 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13298 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13300 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13303 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13306 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13307 to avoid the problems with nested types.
13309 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13310 Anoob V.E <projectmonokochi@rediffmail.com>
13311 Harilal P.R <projectmonokochi@rediffmail.com>
13312 Raja R Harinath <rharinath@novell.com>
13315 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13317 * typemanager (GetConstructor): Make public.
13319 2005-04-05 John Luke <john.luke@gmail.com>
13320 Raja R Harinath <rharinath@novell.com>
13323 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13324 struct too. Return false quicker in a few cases.
13325 (VerifyUnManaged): Use it.
13327 2005-04-05 Raja R Harinath <rharinath@novell.com>
13330 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13331 not 'unreachable_seen'.
13333 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13335 * attribute.cs (Attribute.GetValue): Removed unused.
13337 * codegen.cs (CodeGen.TrimExt): Removed unused.
13339 * cs-parser.jay (output): Removed unused.
13341 * cs-tokenizer.cs (hex_digits): Removed unused.
13343 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13345 * expression.cs (Indirection.LoadExprValue): Removed unused.
13346 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13348 * iterators.cs (Iterator.param_types): Removed unused.
13350 * statement.cs (Goto.block): Removed unused.
13351 (ToplevelBlock.did): Removed unused.
13352 (Switch.ResolveConstantSwitch): Removed unused.
13354 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13356 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13359 2005-04-01 Raja R Harinath <rharinath@novell.com>
13361 Fix #74232 and cs0208-3.cs.
13362 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13363 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13364 unmanaged type. Don't use FieldBuilders when 't' is a
13365 TypeBuilder. Use ModFlags and MemberType fields.
13366 * class.cs (MemberBase.member_type): Rename from MemberType.
13367 (MemberBase.MemberType): New property. Determines member_type on
13369 (MemberBase.DoDefine): Don't initialize MemberType here.
13370 (FieldMember.Define): Likewise.
13372 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13375 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13376 Attributes are emitted there.
13378 2005-04-01 Raja R Harinath <rharinath@novell.com>
13380 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13381 keyword in 'partial enum' too.
13382 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13384 Report from Kamil Skalski <nazgul@omega.pl>.
13387 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13388 have partial containers too.
13390 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13391 in block' checks to Block.CheckInvariantMeaningInBlock.
13392 * statement.cs (Block.GetKnownVariableInfo): Make private.
13393 (Block.IsVariableUsedInChildBlock): Remove.
13394 (Block.IsVariableUsedInBlock): Likewise.
13395 (Block.CheckInvariantMeaningInBlock): New. Show location of
13396 conflicting declaration.
13397 (Block.AddVariable): Make error messages less long-winded and more
13398 specific. Show location of conflicting declaration.
13399 * parameter.cs (Parameters.Location): New readonly property.
13401 2005-03-31 Raja R Harinath <rharinath@novell.com>
13403 Clean up semantics of invoking ResolveMemberAccess.
13404 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13405 can have an instance, ensure that we pass in a non-TypeExpression
13406 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13407 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13408 argument. Update to changes and simplify.
13409 (FieldExpr.Emitinstance): Remove CS0120 check.
13410 (PropertyExpr.EmitInstance): Likewise.
13411 * expression.cs (Argument.Resolve): Likewise.
13412 (Invocation.DoResolve): Update to changes in semantics of
13413 InstanceExpression.
13415 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13418 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13421 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13423 2005-03-31 Raja R Harinath <rharinath@novell.com>
13425 Fix difference in behaviour with commandline invocation.
13426 * driver.cs (Driver.Reset): New.
13427 (CompilerCallableEntryPoint): Call it.
13429 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13430 variable" warnings if the boolean expression failed to resolve.
13432 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13434 * attribute.cs: Fix the union of several permissions when some of them
13435 are unrestricted (so the result isn't an unrestricted permission set).
13438 2005-03-30 Raja R Harinath <rharinath@novell.com>
13440 * ecore.cs (MemberExpr): New class. Convert from interface
13442 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13443 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13445 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13446 (MethodGroupExpr.IsExplicitImpl): Remove.
13447 (Expression.GetFieldFromEvent): Remove.
13448 (SimpleName.MemberStaticCheck): Remove.
13449 (SimpleName.DoSimpleNameResolve): Update to changes.
13450 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13451 (MemberAccess.IdenticalNameAndTypeName): Remove.
13452 (MemberAccess.error176): Move to MemberExpr.
13453 (MemberAccess.DoResolve): Update to changes.
13454 (BaseAccess.DoResolve): Likewise.
13456 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13458 C# 2.0 Conditional attribute class implementation
13460 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13461 Analyzes class whether it has attribute which has ConditionalAttribute
13462 and its condition is not defined.
13464 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13465 (Class.IsExcluded): New method. Search for at least one defined
13466 condition in ConditionalAttribute of attribute class.
13468 2005-03-30 Raja R Harinath <rharinath@novell.com>
13470 * ecore.cs (PropertyExpr): Derive from Expression, not
13471 ExpressionStatement.
13472 (PropertyExpr.EmitStatement): Remove.
13474 2005-03-29 Raja R Harinath <rharinath@novell.com>
13477 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13478 internal field "value__" of an enum be private. The examples for
13479 "value__" that I found on MSDN all used FieldAttributes.Private.
13481 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13482 Don't mention IL method attribute names.
13484 Fix #47991. Remove a TODO.
13485 * statement.cs (Block.Toplevel): Make into a field.
13486 (Block.Parameters): Move into ToplevelBlock.
13487 (Block.known_variables): Rename from child_variable_names.
13488 (Block.Block): Remove variants that take Parameters. Initialize
13489 'Toplevel' with the immediately surrounding toplevel block.
13490 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
13491 LocalInfo parameter.
13492 (Block.GetKnownVariableInfo): New.
13493 (Block.IsVariableNameUsedInChildBlock): Update.
13494 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
13495 the block, even though it may not be in scope.
13496 (Block.AddVariable): Remove Parameters parameter. Use
13497 Toplevel.Parameters instead.
13498 (Block.AddConstant): Remove Parameters parameter.
13499 (Block.GetParameterReference): Update to use Toplevel.Parameters.
13500 (Block.IsParamaterReference): Likewise.
13501 (Block.IsLocalParameter): Likewise. Simplify a lot.
13502 (ToplevelBlock.Parameters): New. Moved from Block.
13503 (ToplevelBlock.ToplevelBlock): Update to changes. Always
13504 initialize Parameters to a non-null value.
13505 * cs-parser.jay: Update to changes.
13506 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
13507 simple names that mean different things in the same block. Use
13508 Block.IsVariableNameUsedInBlock.
13510 2005-03-28 Raja R Harinath <rharinath@novell.com>
13512 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
13513 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
13514 GetTypeHandle. It is possible for a reflected type to derive from
13515 a TypeBuilder (e.g., int[] derives from the TypeBuilder
13516 System.Array during mscorlib compilation).
13517 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
13518 contain a method_hash, don't create one either. Don't create a
13519 deep copy of the base cache's method_hash.
13520 (MemberCache.SetupCache): Rename back from DeepCopy.
13521 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
13522 already initialized. If we see an override function, add its
13523 underlying base virtual function to the member_hash too.
13525 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
13527 2005-03-26 Raja R Harinath <harinath@acm.org>
13530 * assign.cs (Assign.DoResolve): When the RHS of an assignment
13531 fails to resolve, ensure that the LHS is still resolved as an
13534 2005-03-25 Raja R Harinath <harinath@acm.org>
13536 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
13538 (Enum.current_ec): Remove.
13539 (Enum.LookupEnumValue): Remove EmitContext argument.
13540 Just uses the one created during DefineType.
13541 (Enum.FindMembers): Update.
13542 * expression.cs (MemberAccess.DoResolve): Update.
13544 2005-03-22 Marek Safar <marek.safar@seznam.cz>
13546 * assign.cs (Assign.DoResolve): Check for CS1717 when
13547 source and target are same (uses Equals).
13549 * expression.cs (LocalVariableReference, ParameterReference,
13550 This): Implemented Equals, GetHashCode.
13552 * statement.cs (Block.GetParameterReference): Removed useless
13555 2005-03-22 Raja R Harinath <rharinath@novell.com>
13558 * statement.cs (Block.AddVariable): Ensure that we skip implicit
13559 blocks before deciding whether the error is cs0136 or cs0128.
13561 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
13562 (using_alias_directive, using_namespace_directive): Pass
13563 MemberName, not an expression to Namespace.UsingAlias and
13565 (MakeName): Use the MemberName of the namespace.
13566 * namespace.cs (Namespace.MemberName): New.
13567 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
13568 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
13570 * decl.cs (MemberName.Name): Make readonly.
13571 (MemberName.FromDotted): New "constructor".
13572 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
13573 (MemberCore.Name): Compute from MemberName on demand.
13574 (MemberCore.SetMemberName): Provide a way to change the
13576 (MemberCore.AddToContainer): Don't take a fullname parameter.
13577 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
13578 fully qualified name of the container to the member name.
13579 (TypeContainer.AddToTypeContainer): Use a fully qualified name
13580 only if the type is a member of the root container.
13581 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
13582 MemberName.Left rather than searching for an embedded ".".
13583 (PartialContainer.CreatePart): Update to changes in RootContext.
13584 (MemberBase.ShortName): Turn into a property. Use
13585 MemberCore.SetMemberName.
13586 (MemberBase.ExplicitInterfaceName): Remove.
13587 (MemberBase.UpdateMemberName): Remove.
13588 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
13589 (PropertyBase.SetMemberName): New override.
13590 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
13591 (Tree.GetDecl): New.
13592 (Tree.AllDecls): Rename from Decls.
13593 * attribute.cs, enum.cs, report.cs: Update to changes.
13594 * driver.cs (MainDriver): Use MemberName.FromDotted on
13595 RootContext.MainClass.
13597 2005-03-21 Marek Safar <marek.safar@seznam.cz>
13599 * class.cs (FixedField.Define): Check for CS1664 and more sanity
13602 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
13604 2005-03-18 Marek Safar <marek.safar@seznam.cz>
13606 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
13607 property accessor modifiers.
13609 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
13610 fixed buffer attribute (CS1716).
13611 (PropertyMethod.HasCustomAccessModifier): When property accessor
13612 has custom modifier.
13614 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
13616 (PropertyExpr.DoResolveLValue): Add CS0272.
13618 2005-03-17 Miguel de Icaza <miguel@novell.com>
13620 * convert.cs: When converting to a pointer, use the proper Conv.U
13621 or Conv.I depending on the source data type.
13623 * cs-tokenizer.cs: Make the size for large decimal constants,
13626 2005-03-17 Martin Baulig <martin@ximian.com>
13628 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
13629 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
13631 2005-03-17 Martin Baulig <martin@ximian.com>
13633 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
13634 to bool so we can return an error condition.
13635 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
13638 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
13640 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
13643 2005-03-16 Raja R Harinath <rharinath@novell.com>
13645 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
13646 Refactor to avoid traversing the list of assemblies, and to avoid
13647 string concatenation.
13648 * typemanager.cs (guid_attr_type): Remove.
13649 (negative_hits, pointers, references): Remove hashes.
13651 (GetConstructedType): New. Uses type_hash to handle constructed
13652 types (arrays, references, pointers).
13653 (GetReferenceType, GetPointerType): Use it.
13654 (GetNestedType): New. Uses type_hash to handle nested types of
13656 (LookupType, LookupTypeDirect): Remove.
13657 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
13658 'types' hash and LookupTypeReflection directly.
13659 (params_string, params_object): Use GetConstructedType.
13660 * namespace.cs (Namespace.cached_types): New. Cache of reflected
13662 (Namespace.Lookup): Use cached_types.
13663 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
13664 provided by old TypeManager.LookupType.
13665 * rootcontext.cs (MakeFQN): Remove.
13666 * decl.cs (DeclSpace.MakeFQN): Likewise.
13667 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
13668 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13669 TypeManager.GetConstructedType.
13670 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
13672 2005-03-15 Marek Safar <marek.safar@seznam.cz>
13674 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
13677 * cs-parser.jay: Reports CS1527 for any namespace element.
13679 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
13682 * expression.cs (ParameterReference.IsAssigned): Changed error to
13684 (Error_WrongNumArguments): Moved CS0245 detection here.
13686 * statement.cs (Return.Resolve): Add CS1622 report.
13688 2005-03-11 Marek Safar <marek.safar@seznam.cz>
13690 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
13692 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
13694 * attribute.cs expression.cs: Get rid of some allocations.
13696 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
13698 * doc.cs : just eliminate the latest change.
13700 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13702 * doc.cs : commented out the latest change. It breaks xml-030.cs
13704 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13706 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
13707 fail. So invoke CreateType() in FindDocumentedType().
13709 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13711 * cs-tokenizer.cs : added IsKeyword().
13712 * doc.cs : Detect keyword incorrectly used as identifier.
13713 Allow identifiers prefixed by @.
13715 2005-03-10 Marek Safar <marek.safar@seznam.cz>
13717 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
13718 It caused exception in namespace resolving (again!).
13720 * class.cs (Class.ctor): Removed exit.
13721 (PropertyMethod.ctor): ditto.
13723 * codegen.cs (Codegen.Reset): Reset static data.
13724 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
13726 * cs-tokenizer.cs (Cleanup): Removed.
13728 * driver.cs (GetSystemDir): Rewrote to one line command.
13729 It caused problem with unloaded dynamic modules.
13730 (UnixParseOption): Removed Exit.
13731 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
13732 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
13733 Now can be mcs used as library.
13735 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
13738 * location.cs (Reset): Reset static data.
13740 * namespace.cs (Reset): Reset static data.
13742 * report.cs (Report.Reset): Reset static data.
13744 * rootcontext.cs (RootContext.Reset): Reset static data.
13746 * tree.cs (RootTypes.ctor): Use Location.Null
13748 * typemanager.cs (TypeManager.Reset): Reset static data.
13749 (CoreLookupType): Removed Exit.
13750 (TypeHandle.Reset): Reset static data.
13752 2005-03-10 Raja R Harinath <rharinath@novell.com>
13755 * typemanager.cs (ComputeNamespaces): Import namespaces from
13756 referenced modules too.
13758 2005-03-09 Raja R Harinath <rharinath@novell.com>
13760 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
13763 2005-03-09 Raja R Harinath <rharinath@novell.com>
13765 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
13766 enclosing DeclSpace. This ensures that a name-lookup populates
13767 more caches and there are fewer 'TypeExpression's. Carve out
13768 nested type lookup into ...
13769 (LookupNestedTypeInHierarchy): ... this.
13771 2005-03-09 Raja R Harinath <rharinath@novell.com>
13773 Clean up a few partial-class semantics.
13774 Fixes test-357.cs and cs1618-2.cs.
13775 * cs-parser.jay (struct_declaration): Use 'current_class' as
13776 parent of newly-created struct. Remove call to Register ().
13777 Use 'pop_current_class' to complete handing the current struct.
13778 (interface_declaration): Likewise.
13779 (class_declaration): Likewise.
13780 (enum_declaration): Use 'current_class' as parent of newly created
13782 (delegate_declaration): Likewise.
13783 (pop_current_class): New function. This is used to handle closing
13784 up the 'current_class' and 'current_container', and pointing them
13785 to the enclosing class/container.
13786 (CSharpParser): Initialize 'current_class' too.
13787 * decl.cs (MemberCore): Add check for invariant: a partial
13788 container is not a parsed entity, and thus does not enclose any
13790 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
13791 (DeclSpace.BaseTypeExpr): Use it.
13792 (DeclSpace.LookupType): Add check for invariant.
13793 * class.cs (TypeContainer): Add check for invariant: a nested
13794 class should have the same NamespaceEntry as its enclosing class.
13795 (TypeContainer.EmitFieldInitializers): Make virtual.
13796 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
13798 (TypeContainer.Register): Remove.
13799 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
13800 null. Use TypeResolveEmitContext for resolving base types and
13801 interfaces. Move initialization of Parts.TypeBuilder here from
13803 (TypeContainer.DefineNestedTypes): ... here.
13804 (PartialContainer): Take a Namespace not a NamespaceEntry.
13805 (PartialContainer.Create): Don't use Register. Call the
13806 appropriate Add... function directly.
13807 (ClassPart): Take both the PartialContainer and the enclosing
13808 class as constructor arguments.
13809 (ClassPart.EmitFieldInitializers): Override.
13810 (ClassPart.PartFindNestedTypes): Remove.
13811 (FieldBase.GetInitializerExpression): Resolve the initializer
13812 expression in the emit context of the enclosing class.
13813 * tree.cs (RootTypes): Remove Register ().
13815 2005-03-08 Marek Safar <marek.safar@seznam.cz>
13817 * cs-parser.jay: Removed CS0134.
13819 * driver.cs: Removed CS1901.
13821 * expression.cs (SizeOf.DoResolve): Don't report CS0233
13822 for predefined types.
13824 2005-03-07 Duncan Mak <duncan@novell.com>
13826 * codegen.cs (Save): Catch UnauthorizedAccessException as
13827 well. Fixes bug #73454.
13829 2005-03-07 Marek Safar <marek.safar@seznam.cz>
13831 * cs-tokenizer.cs (xtoken): Add CS1035.
13833 * class.cs (MethodData.Define): Add CS0683.
13834 (FieldMember.ctor): Add CS0681.
13836 2005-03-07 Raja R Harinath <rharinath@novell.com>
13838 * ecore.cs (SimpleName.DoResolve): Rename from
13839 SimpleName.DoResolveAllowStatic.
13840 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
13841 Pass 'intermediate' flag to MemberStaticCheck.
13842 (SimpleName.MemberStaticCheck): Skip "static check" only in case
13843 of "intermediate" lookups via MemberAccess.
13844 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
13845 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
13847 2005-03-07 Raja R Harinath <rharinath@novell.com>
13850 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
13851 slipped in because of variable names that are identical to a
13852 builtin type's BCL equivalent ('string String;', 'int Int32;').
13853 (PropertyExpr.EmitInstance): Likewise.
13855 2005-03-04 Marek Safar <marek.safar@seznam.cz>
13857 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
13859 * report.cs (warning_ignore_table): Made public.
13861 2005-03-04 Raja R Harinath <rharinath@novell.com>
13864 * class.cs (MethodData.Emit): Pass 'container' to
13865 container.GetObsoleteAttribute instead of 'container.Parent'.
13867 2005-03-03 Marek Safar <marek.safar@seznam.cz>
13869 * cs-parser.jay: Add 1534 error test.
13871 * iterators.cs (Yield.CheckContext): Add error 1629.
13872 (Iterator.ctor): Save unsafe modifier.
13873 (MoveNextMethod.DoEmit): Restore unsafe context.
13875 * namespace.cs (UsingAlias): Better error message.
13877 2005-03-03 Dan Winship <danw@novell.com>
13879 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
13880 the warning message [#73219]
13882 2005-03-03 Raja R Harinath <rharinath@novell.com>
13884 Fix compile with MCS 1.0.0.0.
13885 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
13886 w_restore to not depend on string constant folding.
13888 2005-03-03 Raja R Harinath <rharinath@novell.com>
13890 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
13891 CS0246 check to users who passed 'silent = false'.
13892 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
13894 (SimpleName.SimpleNameResolve): Update.
13895 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
13896 (MemberAccess.IdenticalNameAndTypeName): Update.
13897 * doc.cs (FindDocumentedTypeNonArray): Update.
13899 2005-03-03 Raja R Harinath <rharinath@novell.com>
13901 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
13902 * parameters.cs (ComputeAndDefineParameters): Remove.
13903 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
13904 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
13905 Use GetParameterInfo.
13907 2005-03-02 Marek Safar <marek.safar@seznam.cz>
13909 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
13911 2005-03-02 Raja R Harinath <rharinath@novell.com>
13913 Unify DeclSpace.LookupType and DeclSpace.FindType.
13914 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
13915 is in charge of defining nested types on demand.
13916 (DeclSpace.LookupType): Use it when the current_type is a
13917 TypeBuilder. Use LookupTypeDirect for reflected types.
13918 (DeclSpace.FindType): Remove.
13919 (DeclSpace.LookupInterfaceOrClass): Likewise.
13920 (DeclSpace.DefineTypeAndParents): Likewise.
13921 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
13922 DeclSpace.LookupType.
13923 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
13924 * typemanager.cs (LookupType): Simplify.
13925 (AddUserType): Remove type from negative_hits.
13926 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
13927 * class.cs (TypeContainer.FindMembers): Move handling of nested
13929 (TypeContainer.FindMembers_NestedTypes): ... here.
13930 (TypeContainer.FindNestedType): Implement override.
13931 (ClassPart.FindNestedType): Delegate to PartialContainer.
13932 (ClassPart.PartFindNestedType): Looks up the nested types of the
13935 2005-03-02 Martin Baulig <martin@ximian.com>
13937 * class.cs (TypeContainer.DoDefineMembers): We also need a default
13938 static constructor in static classes.
13940 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
13942 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
13943 sizeParamIndex is not specified.
13945 2005-03-01 Marek Safar <marek.safar@seznam.cz>
13948 * report.cs (WarningMessage.IsEnabled): Missing null check.
13950 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13952 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
13953 in the fields and not in the properties.
13955 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
13957 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
13960 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13962 * attribute.cs: Small refactoring (improved robustness).
13963 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
13964 (ValidateGuid): Removed.
13965 (Resolve): Removed referenced to above mentioned.
13966 (GetAttributeUsage): Made private and changed to work without
13968 (GetIndexerAttributeValue): Don't crash.
13969 (GetConditionalAttributeValue): Ditto.
13970 (GetClsCompliantAttributeValue): Ditto.
13971 (ExtractSecurityPermissionSet): All attributes exceptions are
13973 (GetPropertyValue): New helper.
13974 (GetMethodImplOptions): New method.
13975 (DefinePInvokeMethod): Reuse common code. Implemented handling of
13976 some missing properties.
13978 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
13979 (Method.ApplyAttributeBuilder): Updated.
13981 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
13984 2005-02-28 Raja R Harinath <rharinath@novell.com>
13987 * report.cs (Report.SymbolRelatedToPreviousError): Handle
13988 non-simple types (array, pointer, reference).
13990 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13992 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
13994 * class.cs (MethodCore.IsDuplicateImplementation): Special error
13996 (Method.CheckBase): Catch wrong destructor here.
13997 (MethodData.Define): Add errors 550, 668.
13999 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14001 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14003 * pending.cs (VerifyPendingMethods): Add error 551.
14005 * typemanager.cs (CSharpName): Next error report helper.
14007 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14009 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14010 attributes. Removed useless attribute double check.
14011 It saves almost 2MBs for corlib.
14013 2005-02-25 Raja R Harinath <rharinath@novell.com>
14016 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14017 called twice in case of error.
14019 2005-02-23 Chris Toshok <toshok@ximian.com>
14021 Fix compiler portions of #72827.
14022 * statement.cs (Block.Emit): call Begin/EndScope on the
14023 EmitContext instead of the ILGenerator.
14025 * codegen.cs (EmitContext.BeginScope): new method, call
14026 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14028 (EmitContext.BeginScope): same, but EndScope and CloseScope
14030 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14031 offset and call the superclass's OpenScope(int) with it.
14032 (SymbolWriter.CloseScope): get the current il
14033 offset and call superclass's CloseScope(int) with it.
14035 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14037 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14038 CS1677 for out and ref as well.
14040 * class.cs (Method.Define): Add error CS1599 detection.
14042 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14044 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14046 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14048 * support.cs.cs (ModifierDesc): New helper method.
14050 2005-02-23 Raja R Harinath <rharinath@novell.com>
14051 Abin Thomas <projectmonokochi@rediffmail.com>
14052 Anoob V E <projectmonokochi@rediffmail.com>
14053 Harilal P R <projectmonokochi@rediffmail.com>
14055 Fix #57851, #72718.
14056 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14057 MemberLookup (used for error reporting) actually returns a result.
14058 Fix error report number (122, not 112).
14060 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14061 Anoob V E <projectmonokochi@rediffmail.com>
14062 Harilal P R <projectmonokochi@rediffmail.com>
14065 * pending.cs (PendingImplementation.GetAbstractMethods):
14066 Find NonPublic members too.
14068 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14070 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14073 * class.cs (MethodCore.CheckMethodAgainstBase):
14074 Add error 239 report.
14076 2005-02-21 Raja R Harinath <rharinath@novell.com>
14079 * expression.cs (Invocation.IsApplicable): Make public.
14080 (Invocation.IsParamsMethodApplicable): Likewise.
14081 * delegate.cs (Delegate.VerifyApplicability): Don't use
14082 Invocation.VerifyArgumentCompat for parameter applicability
14083 testing. Use Invocation.IsApplicable and
14084 Invocation.IsParamsMethodApplicable.
14086 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14088 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14090 * class.cs (Operator.Define): Add error 217 report.
14092 2005-02-21 Raja R Harinath <rharinath@novell.com>
14094 * namespace.cs (UsingEntry.Resolve): Undo change below.
14096 2005-02-21 Raja R Harinath <rharinath@novell.com>
14099 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14100 disable the error message when the extended MemberLookup also
14102 (Expression.MemberLookupFinal): Update.
14103 (SimpleName.DoSimpleNameResolve): Update.
14104 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14105 Don't use MemberLookupFinal.
14106 (New.DoResolve): Update.
14107 (BaseAccess.CommonResolve): Update.
14109 2005-02-21 Raja R Harinath <rharinath@novell.com>
14112 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14113 occured previously, don't resolve again.
14115 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14118 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14119 argument. Call ResolveAttributeUsage for unresolved.
14120 when types doesn't match ctor arguments.
14122 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14123 for nested attribute classes.
14124 (Class.attribute_usage): Removed.
14125 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14126 for attribute class.
14128 * ecore.cs (IsAttribute): Removed.
14130 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14132 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14134 (attribute_types): Removed.
14135 (EmitCode): Global attributes are emited as the latest.
14137 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14139 * class.cs (EmitFieldInitializers): Don't emit field initializer
14140 for default values when optimilization is on.
14142 * constant.cs (Constant.IsDefaultValue): New property.
14144 * driver.cs: Add /optimize handling.
14148 * literal.cs: Implement new IsDefaultValue property.
14150 * rootcontext.cs (Optimize): New field, holds /optimize option.
14152 2005-02-18 Raja R Harinath <rharinath@novell.com>
14154 Fix crasher in re-opened #72347.
14155 * namespace.cs (Namespace.Lookup): Return null if
14156 DeclSpace.DefineType returns null.
14159 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14161 2005-02-18 Raja R Harinath <rharinath@novell.com>
14163 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14164 now returns null if it cannot resolve to an lvalue.
14165 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14166 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14167 returned null. Remove check for SimpleName.
14168 (EventExpr.DoResolveLValue): New.
14169 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14170 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14172 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14173 avoid CS0131 error.
14174 (Unary.ResolveOperator): Move CS0211 check ...
14175 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14177 (Unary.DoResolveLValue): Simplify.
14178 (AddressOf.DoResolveLValue): New.
14179 (ArrayAccess.DoResolveLValue): New.
14181 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14183 * attribute.cs (Attribute.Resolve): Add arguments casting for
14184 when types doesn't match ctor arguments.
14186 2005-02-16 Raja R Harinath <rharinath@novell.com>
14188 Fix parts of #63202.
14189 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14190 lookup of operator in base type. Ensure that all checks happen
14191 when the operator resolves to an "op_..." method.
14193 2005-02-15 Raja R Harinath <rharinath@novell.com>
14196 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14197 'ignore_cs0104' parameter. Pass it to ...
14198 (NamespaceEntry.Lookup): ... this.
14199 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14200 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14201 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14202 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14203 Update. Request that cs0104 errors be ignored.
14204 (ComposedCast.ResolveAsTypeStep): Update.
14206 2005-02-14 Raja R Harinath <rharinath@novell.com>
14209 * expression.cs (Invocation.BetterFunction): Remove support for
14210 comparing virtual functions and their overrides.
14211 (Invocation.IsOverride): New.
14212 (Invocation.OverloadResolve): Don't consider 'override' functions
14213 during candidate selection. Store them in a lookaside list.
14214 If the selected method is a 'virtual' function, use the list to
14215 find any overrides that are closer to the LHS type.
14217 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14219 * expression.cs (New.DoResolve): Add complex core type reduction.
14220 (New.Constantify): Converts complex core type syntax like 'new int ()'
14221 to simple constant.
14223 2005-02-14 Raja R Harinath <rharinath@novell.com>
14225 * decl.cs (EntryType.EntryType): New constructor to create an
14226 updated copy of a cache entry.
14227 (MemberCache.AddMethods): Use it.
14228 (MemberCache.ClearDeclaredOnly): Remove.
14229 (MemberCache.MemberCache): Update.
14231 2005-02-11 Miguel de Icaza <miguel@novell.com>
14233 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14234 variable. This one is represents the actual low-level declaration
14235 of the method, as opposed to the semantic level `IsStatic'.
14237 An anonymous method which is hosted into a static method might be
14238 actually an instance method. IsStatic would reflect the
14239 container, while MethodIsStatic represents the actual code
14242 * expression.cs (ParameterReference): Use the new MethodIsStatic
14243 instead of IsStatic.
14245 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14246 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14247 set on the current EmitContext.
14249 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14250 resolve our casted expression as an LValue. This triggers the
14251 proper LValue processing that is later required by Assign.
14255 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14257 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14259 C# 2.0 Fixed buffer implementation
14261 * anonymous.cs: Update after RegisterHelperClass renaming.
14263 * attribute.cs (AttributeTester.fixed_buffer_cache):
14264 Cache of external fixed buffers.
14265 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14266 implementation if field is fixed buffer else null.
14269 (TypeContainer.AddField): Accept FieldMember instead of Field.
14270 (FieldBase.IsFieldClsCompliant): Extracted code from
14271 VerifyClsCompliance descendant customization.
14272 (FixedField): New class handles fixed buffer fields.
14273 (FixedFieldExternal): Keeps information about imported fixed
14275 (IFixedField): Make access to internal or external fixed buffer
14278 * cs-parser.jay: Add fixed buffer parsing.
14280 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14283 * expression.cs (Indirection): Extended implementation to accept
14284 fixed buffer field.
14285 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14286 (ElementAccess.MakePointerAccess): Get type as parameter.
14287 (DoResolve): Add fixed buffer field expression conversion.
14288 (DoResolveLValue): Ditto.
14289 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14290 (ArrayPtr): Derives from FixedBufferPtr.
14291 (ArrayPtr.Emit): Add extra emit for array elements.
14293 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14295 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14296 for compiler generated types.
14297 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14299 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14300 and consume less memory.
14301 (Fixed.Resolve): Add fixed buffer case.
14303 * typemanager.cs (compiler_generated_attr_ctor,
14304 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14305 (HasElementType): Add our own implementation to work on every
14308 2005-02-11 Miguel de Icaza <miguel@novell.com>
14310 * anonymous.cs (CaptureContext): Track whether `this' has been
14313 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14314 only captured `this' if it was implicitly done (instance
14315 methods/variables were used).
14317 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14318 `this' must be captured.
14320 2005-01-30 Miguel de Icaza <miguel@novell.com>
14322 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14323 is null it means that there has been no need to capture anything,
14324 so we just create a sibling.
14326 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14328 Just a partial fix. The other half is fairly elusive.
14330 2005-02-10 Raja R Harinath <rharinath@novell.com>
14332 Fix #52586, cs0121-4.cs.
14333 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14334 and return a hashtable.
14335 (MemberCache.ClearDeclaredOnly): New.
14336 (MemberCache.MemberCache): Update to change. Make a deep copy of
14337 the method_hash of a base type too.
14338 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14339 type methods. Overwrite entries with the same MethodHandle so
14340 that the ReflectedType is correct. The process leaves in base
14341 virtual functions and their overrides as distinct entries.
14342 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14343 matters since it was boxed in a ArrayList before.
14344 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14346 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14347 case of a virtual function and its override (choose the overload
14349 (Invocation.OverloadResolve): Avoid 'override' members during
14350 'applicable_type' calculation.
14352 2005-02-09 Raja R Harinath <rharinath@novell.com>
14354 Combine two near-redundant caches.
14355 * typemanager.cs (method_params): Rename from method_internal_params.
14356 (TypeManager.GetParameterData): New. Replace
14357 Invocation.GetParameterData.
14358 (TypeManager.LookupParametersByBuilder): Remove.
14359 * expression.cs (Invocation.method_parameter_cache): Remove.
14360 (Invocation.GetParameterData): Remove.
14362 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14365 2005-02-08 Raja R Harinath <rharinath@novell.com>
14368 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14369 TypeManager.multicast_delegate_type is null, resolve it by looking
14370 up "System.MulticastDelegate".
14371 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14373 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14374 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14375 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14378 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14379 (LabeledStatement.AddReference): New. Set 'referenced'.
14380 (Goto.Resolve): Use it.
14382 2005-02-05 John Luke <john.luke@gmail.com>
14384 * driver.cs: remove duplicate -doc line in Usage ()
14386 2005-02-04 Raja R Harinath <rharinath@novell.com>
14388 * location.cs (Location.AddFile): Fix CS2002 error report.
14390 2005-02-02 Martin Baulig <martin@ximian.com>
14392 * delegate.cs (Delegate.DefineType): Report an internal error if
14393 TypeManager.multicast_delegate_type is null. See bug #72015 for
14396 2005-02-02 Raja R Harinath <rharinath@novell.com>
14398 Fix a crasher in a variant of #31984.
14399 * const.cs (Constant.CheckBase): New override that defers the
14400 new-or-override check in case the base type hasn't been populated
14402 (Constant.Define): Ensure the new-or-override check is performed.
14404 2005-02-01 Duncan Mak <duncan@ximian.com>
14406 * const.cs (LookupConstantValue): Check that `ce' is not null
14407 before calling GetValue ().
14409 2005-02-01 Raja R Harinath <rharinath@novell.com>
14411 Fix test-334.cs (#69519).
14412 * cs-parser.jay (using_alias_directive): Pass in an expression to
14413 NamespaceEntry.UsingAlias.
14414 (using_namespace_directive): Pass in an expression to
14415 NamespaceEntry.Using.
14416 (namespace_name): Don't flatten to a string.
14417 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14418 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14420 (NamespaceEntry.UsingEntry): Likewise.
14421 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14423 (NamespaceEntry.LookupForUsing): Remove.
14424 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14426 (NamespaceEntry.Lookup): Remove support for dotted names.
14428 2005-02-01 Raja R Harinath <rharinath@novell.com>
14430 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14432 (NamespaceEntry.ImplicitParent): Compute on demand.
14433 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14434 parallels the current.
14435 (NamespaceEntry.LookupForUsing): Use it.
14436 (NamespaceEntry.Lookup): If the current namespace-entry is
14437 implicit, don't search aliases and using tables.
14439 2005-02-01 Raja R Harinath <rharinath@novell.com>
14442 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14444 (TypeContainer.BaseCache): Compute on demand.
14445 (TypeContainer.FindMembers): Define constants and types if they're
14446 not already created.
14447 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14449 * const.cs (Constant.Define): Make idempotent.
14451 2005-01-29 Miguel de Icaza <miguel@novell.com>
14453 * pending.cs: Produce better code (no nops produced by using Ldarg
14456 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14457 i - 1' it should be arg + 1.
14461 2005-01-28 Raja R Harinath <rharinath@novell.com>
14463 * attribute.cs (Attribute.CheckAttributeType): Make private
14465 (Attribute.ResolveType): Make virtual.
14466 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14467 handling of RootContext.Tree.Types.
14469 2005-01-27 Raja R Harinath <rharinath@novell.com>
14471 Update attribute-handling to use the SimpleName/MemberAccess
14473 * cs-parser.jay (attribute): Pass in an expression to the
14474 constructors of Attribute and GlobalAttribute.
14475 * attribute.cs (Attribute): Take an expression for the name.
14476 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14477 passed in attribute name expression.
14478 (Attribute.CheckAttributeType): Use it.
14479 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14480 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14481 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14482 argument to prevent error messages if the lookup fails.
14484 2005-01-27 Marek Safar <marek.safar@seznam.cz>
14486 * expression.cs (Indirection): Implemented IVariable interface
14487 to support indirection in AddressOf operator.
14488 (PointerArithmetic.Emit): Add optimalization for case where
14489 result can be precomputed.
14491 2005-01-26 Martin Baulig <martin@ximian.com>
14493 * class.cs (TypeContainer.AttributeTargets): Return the correct
14494 AttributeTargets depending on our `Kind' instead of throwing an
14495 exception; fixes #71632.
14497 2005-01-26 Marek Safar <marek.safar@seznam.cz>
14500 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
14503 2005-01-25 Raja R Harinath <rharinath@novell.com>
14506 * expression.cs (MemberAccess.DoResolve): Don't complain with
14507 cs0572 when the LHS of a member access has identical name and type
14510 2005-01-25 Marek Safar <marek.safar@seznam.cz>
14513 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
14515 Create custom PermissionSet only for PermissionSetAttribute.
14517 2005-01-24 Marek Safar <marek.safar@seznam.cz>
14520 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
14521 delegates in static class.
14523 2005-01-24 Martin Baulig <martin@ximian.com>
14525 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14526 merging an implicit block, just use its reachability.
14528 * statement.cs (Block.Resolve): Make the unreachable code check
14529 work wrt. implicit blocks; see test-337 from #63842.
14531 2005-01-21 Alp Toker <alp@atoker.com>
14533 * cs-parser.jay: destructor_declaration's container is PartialContainer
14534 not Class when partial types are used, so use Kind prop instead of
14537 2005-01-22 Miguel de Icaza <miguel@ximian.com>
14539 * cs-parser.jay: Improve error reporting when an interface
14540 declares new types.
14542 2005-01-20 Dick Porter <dick@ximian.com>
14544 * support.cs: SeekableStreamReader fix from Sandor Dobos
14545 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
14546 chars are read. Fixes bug 70369.
14548 2005-01-20 Raja R Harinath <rharinath@novell.com>
14550 * cs-parser.jay (catch_clause): Simplify current_block handling
14553 2005-01-17 Miguel de Icaza <miguel@ximian.com>
14555 * convert.cs (ImplicitStandardConversionExists): Synchronize the
14556 code with ImplicitStandardConversion to handle the implicit
14557 conversion of method groups into valid delegate invocations.
14559 The problem is that in parameter handling we were using this code
14560 path. Fixes bug #64698
14562 2005-01-19 Raja R Harinath <rharinath@novell.com>
14564 * cs-parser.jay: Fix several infelicities.
14565 - Avoid assigning to the parser value stack. Code like
14566 '$3 = null' is unclean. Synthesize a value for the code block
14568 - Avoid using oob_stack for storing location information. Use ...
14569 (_mark_): ... this. New (empty) rule. Saves the current location
14571 (foreach_statement): Avoid using oob_stack for current_block
14572 handling. Use technique used in for_statement and
14573 using_statement. Synthesize a value for the code block to store
14574 additional intermediate information.
14576 2005-01-13 Miguel de Icaza <miguel@ximian.com>
14578 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
14579 of a different type is only allowed to private fields of a
14580 containing type, not on fields of a base class.
14582 See test-174.cs and error cs0122-9.cs
14584 2005-01-13 Raja R Harinath <rharinath@novell.com>
14586 Fix test-335.cs (bug #58126).
14587 * cs-parser.jay (argument): Split out non-expression parts of the
14588 rule into 'non_simple_argument'.
14589 (invocation_expression): Support parenthesized invocations with
14590 multiple arguments, and with single non-simple arguments.
14592 2005-01-13 Raja R Harinath <rharinath@novell.com>
14594 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
14597 2005-01-12 Raja R Harinath <rharinath@novell.com>
14599 Fix cs0038-1.cs, cs1640-6.cs.
14600 * ecore.cs (Expression.Resolve): Remove special-case for
14601 SimpleName in error-handling.
14602 (Expression.almostMatchedMembers): Relax access permission to
14604 (Expression.MemberLookupFailed): Handle duplicates in
14605 almostMatchedMembers list.
14606 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
14607 * expression.cs (New.DoResolve): Report CS1540 for more cases.
14608 * typemanager.cs (GetFullNameSignature): Use the MethodBase
14609 overload if the passed in MemberInfo is a MethodBase.
14611 2005-01-12 Marek Safar <marek.safar@seznam.cz>
14614 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
14615 for non-CAS & merge permission sets properly.
14617 2005-01-11 Raja R Harinath <rharinath@novell.com>
14619 Improve standard-compliance of simple name and member access
14620 resolution. Fixes bugs #52697, #57200, #67520, #69519.
14621 * ecore.cs (FullNamedExpression): New abstract base class
14622 for Namespaces and TypeExpressions.
14623 (ResolveFlags.SimpleName): Remove.
14624 (SimpleName): Remove support for dotted names.
14625 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
14626 DeclSpace.FindType and DeclSpace.LookupType.
14627 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
14628 (Expression.ExprClassName): Make member function.
14629 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
14630 a namespace. Remove creation of dotted "SimpleName"s.
14631 (MemberAccess.DoResolve): Likewise.
14632 * decl.cs (DeclSpace.Cache): Make private.
14633 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
14634 (DeclSpace.FindType): Update.
14635 (DeclSpace.LookupType): Move here from RootContext. Return a
14636 FullNamedExpression.
14637 * namespace.cs (Namespace): Derive from FullNamedExpression
14638 so that it can be part of expression resolution.
14639 (Namespace.Lookup): Return an FullNamedExpression.
14640 (NamespaceEntry.LookupAlias): Lookup aliases only in current
14642 * rootcontext.cs (NamespaceLookup): Remove.
14643 (LookupType): Move to DeclSpace.
14644 * attribute.cs (CheckAttributeType): Update.
14645 * doc.cs (FindDocumentedType): Remove allowAlias argument.
14646 (FindDocumentedTypeNonArray): Likewise.
14648 2005-01-11 Raja R Harinath <rharinath@novell.com>
14650 Fix cs0509.cs, cs1632.cs.
14651 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
14652 is the same as IsInterface.
14653 (TypeContainer.GetClassBases): Likewise.
14654 * statement.cs (LabeledStatement.ig): New field.
14655 (LabeledStatement.LabelTarget): Save ILGenerator which created the
14657 (LabeledStatement.DoEmit): Check that the label was created with
14658 the same ILGenerator.
14660 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14663 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
14664 accessors to its properties.
14666 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
14667 from accessors to property.
14669 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14672 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
14673 only for overrides.
14675 2005-01-08 Miguel de Icaza <miguel@ximian.com>
14677 * attribute.cs: Check for null and empty strings.
14679 I have lost another battle to Paolo.
14681 2005-01-07 Marek Safar <marek.safar@seznam.cz>
14684 * class.cs (PropertyMethod): Set Parent field in ctors.
14685 (SetMethod.InternalParameters): Add unsafe switch hack.
14686 Override MarkForDuplicationCheck where it is appropriate.
14688 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
14689 It says whether container allows members with the same name.
14690 Base default is no.
14691 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
14692 Removed is_method parameter.
14694 2005-01-06 Duncan Mak <duncan@ximian.com>
14696 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
14697 because the previous change led to incorrect reporting of CS1032
14698 ("Cannot define/undefine preprocessor symbols after first token in
14699 file"). Instead of using `tokens_seen' as the only flag that
14700 triggers CS1040, introduce `comments_seen'. This new flag is used
14701 to signify having seen comments on the current line, so it is
14702 unset after a newline.
14704 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14706 * doc.cs : When searching for a type, find nested type too.
14707 This fixes bug #71040.
14709 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14712 - Warn missing member comment on those classes which also does not
14713 have doc comments. Fixed bug #71041.
14714 - Don't warn missing doc comment on default constructor.
14717 2005-01-06 Duncan Mak <duncan@ximian.com>
14719 * cs-tokenizer.cs (xtoken): After handling traditional C-style
14720 comments, set `tokens_seen' to true. This allows us to detect
14721 misplaced preprocessor directives (i.e. not at the beginning of
14722 the a line, nor after whitespaces). In that case, report error
14723 CS1040. This fixes bug #56460.
14725 * cs-parser.jay (interface_member_declaration): Add checks for
14726 IsExplicitImpl, and report CS0541 error if an interface member is
14727 defined as an explicit interface declaration.
14729 2005-01-06 Marek Safar <marek.safar@seznam.cz>
14732 * class.cs (PropertyMethod): Set Parent field in ctors.
14733 (SetMethod.InternalParameters): Add unsafe switch hack.
14735 * decl.cs (MemberCore.Parent): Cannot be readonly.
14737 2005-01-06 Raja R Harinath <rharinath@novell.com>
14739 * decl.cs (DeclSpace.ResolveType): Remove.
14740 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
14741 Merge in code from ...
14742 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
14743 * class.cs, enum.cs: Update to changes.
14745 2005-01-06 Miguel de Icaza <miguel@ximian.com>
14747 * anonymous.cs: Ensure that we init the scope of our parent if it
14748 has not been initialized yet.
14750 2004-12-30 Duncan Mak <duncan@ximian.com>
14752 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
14753 if field.FieldBuilder is null. Fixes #70758.
14755 * convert.cs: Fixed some typos and updated some of the comments.
14756 (ImplicitStandardConversionExists):
14757 (TryImplicitIntConversion): If `target_type' is an interface and
14758 the type of `ic' implements this interface, return true or a new
14759 BoxedCast instead of null. This fixes #70468.
14761 2004-12-29 Duncan Mak <duncan@ximian.com>
14763 * expression.cs (Argument.Emit): Check that Expr is
14764 IMemoryLocation before casting to it, and report CS1510 otherwise.
14768 2004-12-21 Ben Maurer <bmaurer@ximian.com>
14770 * statement.cs (Block.ThisVariable): remove the recursion here, to
14771 make the --profile more sane.
14773 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
14775 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
14776 assembly, by JB Evain.
14778 2004-12-17 Raja R Harinath <rharinath@novell.com>
14780 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
14781 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
14782 "parent" refers to enclosing type/class. "base" refers to superclass.
14784 2004-12-17 Raja R Harinath <rharinath@novell.com>
14786 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14787 Ensure that we only have GlobalAttributes.
14788 * attribute.cs (Attribute.Emit): Make non-virtual.
14789 (GlobalAttribute.Emit): Remove.
14790 (Attribute.Resolve): Make virtual.
14791 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
14792 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
14793 the argument. Don't create one.
14794 (Attribute.GetObsoleteAttribute): Likewise.
14795 (Attribute.GetClsCompliantAttributeValue): Likewise.
14796 * class.cs, decl.cs: Update to changes.
14798 2004-12-17 Marek Safar <marek.safar@seznam.cz>
14800 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
14802 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
14804 * statement.cs (Foreach.Resolve): Add error 186 report.
14806 2004-12-16 Marek Safar <marek.safar@seznam.cz>
14808 * expression.cs (Conditional.DoResolve): Add warning 429.
14810 * statement.cs (If.Resolve): Add warning 665.
14812 2004-12-16 Raja R Harinath <rharinath@novell.com>
14814 New invariant: RootContext.Tree.Types.NamespaceEntry == null
14815 except when in the parser, and in GlobalAttribute.
14816 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
14817 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
14818 RootContext.Tree.Types.NamespaceEntry once work is done.
14819 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
14820 and resets RootContext.Tree.Types.NamespaceEntry.
14822 2004-12-15 Marek Safar <marek.safar@seznam.cz>
14824 * cs-parser.jay: Don't create a block for every variable.
14826 2004-12-14 Miguel de Icaza <miguel@ximian.com>
14828 * location.cs: Provide extra information.
14830 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
14831 variables from the captured environment, it is the ldarg_0.
14833 2004-12-14 Marek Safar <marek.safar@seznam.cz>
14835 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
14838 * class.cs: Changed warning level for 169 to avoid developer
14839 displeasure from warning flooding. It will be changed back when they
14840 fix most of current BCL warnings.
14842 * RootContext.cs: Pushed default WarningLevel to 3.
14844 * statement.cs: Removed unused variable.
14846 2004-12-14 Marek Safar <marek.safar@seznam.cz>
14848 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
14849 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
14850 Add error 502 report.
14851 (StaticClass.DefineType): Add error 441 report.
14852 (Class.AllowedModifiersProp): New virtual property as temporary
14853 extension to AllowedModifiers.
14854 (Class.DefineType): Add error 418 report. Moved ModFlags check here
14855 to share implementation with StaticClass and don't call virtual
14858 * driver.cs (MainDriver): Add error 1558 test.
14860 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
14861 report. Moved error 36 test here.
14863 * statement.cs (Throw.Resolve): Add error 724 report.
14865 * typemanager.cs: Add out_attribute_type core type.
14867 2004-12-13 Marek Safar <marek.safar@seznam.cz>
14869 * class.cs (TypeContainer.VerifyClsCompliance): Add error
14871 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
14873 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
14876 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
14878 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
14879 Add error 3023 report.
14880 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
14882 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
14885 2004-12-12 John Luke <john.luke@gmail.com>
14887 * driver.cs (AddArgs): take -- into account when
14888 adding arguments, fixes bug 65710
14890 2004-12-12 Martin Baulig <martin@ximian.com>
14892 * expression.cs (Unary.TryReduceNegative): Added support for
14893 SByteConstant and ByteConstant.
14894 (Unary.Reduce): Check error values from TryReduceNegative().
14896 2004-12-10 Marek Safar <marek.safar@seznam.cz>
14898 * attributes.cs (Attribute.Resolve): Avoid multiple error report
14899 and report exception as error 182.
14901 2004-12-10 Raja R Harinath <rharinath@novell.com>
14903 * driver.cs (Main): Fix message when there are warnings.
14905 2004-12-09 Miguel de Icaza <miguel@ximian.com>
14907 * delegate.cs: Fixed my fix from yesterday, sorry about that.
14909 2004-12-09 Marek Safar <marek.safar@seznam.cz>
14911 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
14912 Reduced number of warnings.
14914 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
14916 2004-12-08 Miguel de Icaza <miguel@ximian.com>
14918 * driver.cs: Removed message.
14920 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
14922 2004-12-08 <vargaz@freemail.hu>
14924 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
14926 2004-12-08 Martin Baulig <martin@ximian.com>
14928 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
14929 instead of a CS3002 for properties and indexer.
14931 2004-12-08 Martin Baulig <martin@ximian.com>
14933 * decl.cs (MemberName.ToString): Make this work again.
14935 2004-12-08 Marek Safar <marek.safar@seznam.cz>
14937 * attribute.cs (Resolve): Add error 591 detection.
14939 * class.cs (FieldMember.Define): Add error 1547 detection.
14940 (Indexer.Define): Add error 620 detection.
14941 (Operator.Define): Add error 590 detection.
14943 * ecore.cs: Missing argument for error 79.
14945 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
14948 2004-12-07 Marek Safar <marek.safar@seznam.cz>
14951 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
14954 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
14956 * cs-parser.jay : handle doc comments on implicit/explicit operators.
14957 Some operator comments were suppressed.
14958 * doc.cs : Implicit/explicit operator name in doc comments are like
14959 "op_Explicit(type)~returnType", so added suffix handling.
14961 2004-12-07 Martin Baulig <martin@ximian.com>
14964 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
14965 (MemberCore.GetClsCompliantAttributeValue): Likewise.
14966 (DeclSpace.ec): New protected field; store the EmitContext here.
14967 (DeclSpace.EmitContext): New public property; moved here from
14969 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
14972 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
14973 (Enum.Emit): Don't create a new EmitContext.
14975 * delegate.cs (Delegate.DefineType): Always create the
14978 * iterators.cs (Iterators.DefineIterator): Create a new
14979 EmitContext and store it in `ec'.
14981 2004-08-24 Martin Baulig <martin@ximian.com>
14984 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
14985 this for accessibility checks.
14986 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
14987 IsNestedFamilyAccessible.
14988 (TypeManager.IsSubclassOf): New method, do what the name actually
14991 2004-12-06 Raja R Harinath <rharinath@novell.com>
14993 Fix crash on cs0657-17.cs.
14994 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14995 Use RootContext.Tree.Types, not 'new RootTypes ()'.
14996 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
14997 the case where the NamespaceEntry gets overwritten.
14999 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15001 Fixed #69195, #56821
15002 * ecore.cs (ResolveBoolean): Tiny refactoring.
15004 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15005 of right expression resolving when left is false constant and
15006 operator is LogicalAnd OR true constant and operator is LogicalOr.
15008 * statement.cs (ResolveUnreachable): Always reports warning.
15010 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15012 * class.cs: Distinguish between 1721 and 1722 (just a little help
15013 for the programmer).
15015 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15017 * delegate.cs: Only allow this on new versions of the language.
15019 2004-12-02 Duncan Mak <duncan@ximian.com>
15021 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15023 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15024 here as a static method. Take an additional bool out parameter
15025 `must_do_cs1540_check' for signaling to InstanceResolve.
15026 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15027 member field from PropertyExpr class and made it an argument of
15028 the method instead.
15029 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15030 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15031 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15032 and `remove_accessor' as well as InstanceResolve: report CS0122
15037 2004-12-03 Raja R Harinath <rharinath@novell.com>
15039 Fix test-327.cs, test-328.cs, and put in early infrastructure
15040 for eventually fixing #52697.
15041 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15042 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15043 from other methods.
15044 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15045 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15046 (VerifyUsing, error246): Update.
15047 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15048 'NamespaceEntry.LookupNamespaceOrType'.
15050 2004-12-03 Martin Baulig <martin@ximian.com>
15052 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15053 method as our child, call AnonymousMethod.Compatible() on it.
15055 2004-12-03 Raja R Harinath <rharinath@novell.com>
15057 Disable XML documentation support in 'basic' profile.
15058 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15059 Redirect XmlElement to System.Object.
15060 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15061 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15062 * mcs.exe.sources: Add doc-bootstrap.cs.
15063 * doc-bootstrap.cs: New file. Contains empty stub implementation
15066 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15068 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15069 comments are allowed.
15071 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15073 * delegate.cs: Add checks for subtypes in paramaters and return values
15074 in VerifyMethod () to add support for Covariance/Contravariance
15077 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15079 * report.cs: Remove extra closing parenthesis.
15081 * convert.cs (Error_CannotImplicitConversion): If the name of the
15082 types are the same, provide some extra information.
15084 * class.cs (FieldBase): Use an unused bit field from the field to
15085 encode the `has_offset' property from the FieldMember. This saves
15086 a couple of Ks on bootstrap compilation.
15088 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15089 method as our child, return the AnonymousMethod resolved
15092 * expression.cs (New.DoResolve): Allow return values from
15093 NewDelegate to also include AnonymousMethods.
15097 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15100 * attribute.cs (Resolve): Improved implementation of params
15101 attribute arguments.
15103 * support.cs (ParameterData): Add HasParams to be faster.
15105 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15107 all things are for /doc support:
15109 * doc.cs: new file that supports XML documentation generation.
15110 * mcs.exe.sources: added doc.cs.
15112 Handle /doc command line option.
15113 Report error 2006 instead of 5 for missing file name for /doc.
15114 Generate XML documentation when required, after type resolution.
15116 Added support for picking up documentation (/// and /** ... */),
15117 including a new XmlCommentState enumeration.
15119 Added lines to fill Documentation element for field, constant,
15120 property, indexer, method, constructor, destructor, operator, event
15121 and class, struct, interface, delegate, enum.
15122 Added lines to warn incorrect comment.
15124 Added Documentation field (passed only when /doc was specified).
15126 Added DocComment, DocCommentHeader, GenerateDocComment() and
15127 OnGenerateDocComment() and some supporting private members for
15128 /doc feature to MemberCore.
15130 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15132 Added overriden DocCommentHeader.
15134 Added overriden DocCommentHeader and GenerateDocComment().
15136 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15138 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15139 unwrapping the enumeration values, chain to
15140 DoConstantNumericPromotions again, so we can promote things to the
15141 fundamental types (takes care of enums that are bytes, sbytes).
15145 2004-12-01 Raja R Harinath <rharinath@novell.com>
15147 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15148 Fix long-standing bug in type-lookup. Use FindType instead of
15149 LookupType when ec.ResolvingTypeTree.
15150 (Attribute.ResolveType, Attribute.Resolve)
15151 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15153 (Attributes.Search): Remove internal version. Update.
15154 (Attributes.SearchMulti): Update.
15155 (Attributes.GetClsCompliantAttribute): Remove.
15156 (Attributes.GetIndexerNameAttribute): Remove.
15157 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15158 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15159 * class.cs (Indexer.Define): Likewise.
15161 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15164 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15165 MarshallByReference members access.
15167 * expression.cs: Use CheckMarshallByRefAccess;
15168 Better error CS0197 message.
15170 * report.cs: Print whole related error message.
15172 2004-11-30 Raja R Harinath <rharinath@novell.com>
15174 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15175 the current directory to help debugging.
15177 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15179 * class (GetClassBases): Better error 60 report.
15180 (EventProperty): Disabled warning 67 detection.
15182 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15185 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15187 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15190 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15193 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15195 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15197 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15199 * attribute.cs (Attribute.Resolve): Refine error reporting and
15200 report a cs0117 if the identifier does not exist, to distinguish
15201 from 0617 which is a miss-use of the actual identifier.
15203 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15204 between cs0070 and cs0079.
15206 * class.cs (MemberBase.DoDefine): When reporting a wrong
15207 accessibility level, we use MethodCore to compare instead of
15208 Method (this was a regression in some refactoring effort).
15210 So now we correctly report cs0056 again.
15212 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15213 testing the target_type (which was known to be object_type) and
15214 not the source type (which is anonymous_method).
15216 Fixed reporting of error cs1660.
15218 * expression.cs (UserCast.Source): Expose the underlying cast.
15220 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15221 allowed types to find a match to int32 first (most common).
15223 In addition, it ignores any ImplicitUserConversions that did an
15224 internal implicit conversion (as the switch statement allows only
15225 one integral conversion to exist).
15227 * class.cs (PartialContainer.Create): rename `name' to
15228 `member_name' for clarity. Then replace the string calls with a
15229 call to MemberName.GetPartialName, as now using
15230 MemberName.ToString is an error (this is due to the side effects
15231 it had, that were fixed in the past).
15233 This will restore the error reporting on a number of partial class
15234 errors that were missusing this (and getting an exception as a
15235 results, which is now just a plain textual warning, because
15236 yyparse debug output would crash otherwise).
15238 2004-11-26 Raja R Harinath <rharinath@novell.com>
15240 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15242 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15244 * rootcontext.cs (LookupType): Make sure to cache lookups that
15245 don't give us a negative result. This saves about 5% of corlib
15248 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15250 * report.cs (AbstractMessage.Print): messages are sent to stderr
15252 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15253 non-interface in the list of interfaces (at this point, either
15254 parent was properly set, or a base class is being listed in the
15255 interfaces section).
15257 This flags error 1722, and resolves the crash from bug 69259.
15259 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15261 * statement.cs (Using.EmitExpressionFinally): make this work right
15262 for valuetypes. Fixes 69926.
15264 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15266 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15267 converted to an enum" here, before we try to change the underlying
15268 type. This code exists, but it is a different code path than the
15269 one used while encoding constants.
15271 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15272 old bug: when converting from the null literal to a pointer,
15273 return an EmptyCast, not the NullLiteral.
15275 This fixes #69921, the recent null_type changes probably made this
15276 bug more prominent.
15278 (ImplicitReferenceConversionExists): In addition, resynchronized
15279 the code here, so it matches the same code in
15280 ImplicitReferenceConversionExists for the `from any class-type S
15281 to any interface-type T'.
15284 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15286 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15288 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15290 * cs-parser.jay: Use verbosity accordingly.
15292 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15294 * expression.cs (Unary.ResolveOperator): Do not report warning;
15295 AddressOf reads from variable.
15297 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15299 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15303 * attribute.cs (Attributable): Removed CheckTargets.
15304 (Attributes.Emit): Explicit attribute targets are tested here.
15306 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15307 not enabled for interfaces.
15309 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15310 (GetAssemblyName): Ouch next bug there.
15312 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15314 * expression.cs: Error 275 added.
15316 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15318 Fix bug #69177 (Implemented decimal constant support)
15320 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15321 (BinaryFold): Add DecimalConstant.
15323 * const.cs (Define): Decimal constant
15325 (ChangeType): Add decimal type handling.
15326 (LookupConstantValue): Don't set value for decimal type but
15327 emit DecimalConstantAttribute. Needed for constant optimization.
15329 * constant.cs (ToDecimal): New method.
15330 (ConvertToDecimal): New method.
15331 (IntConstant): Implemented ConvertToDecimal.
15332 (DecimalConstant.Emit): Emit optimized version for decimals in
15335 * expression.cs (ResolveOperator): Changed order of constant
15336 reduction to work correctly with native types which have
15337 overloaded operators.
15338 (ResolveMemberAccess): Extract constant value from attribute
15341 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15343 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15344 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15345 (ChangeType): Decimal is special.
15346 (TypeToCoreType): Add decimal type.
15348 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15350 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15353 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15355 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15358 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15360 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15362 * pending.cs (PendingImplementation): Grab only interfaces.
15364 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15366 * statement.cs (ForeachHelperMethods): Add location member and
15367 error 202 detection.
15369 2004-11-19 Raja R Harinath <rharinath@novell.com>
15371 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15372 automatically handled by executable.make.
15373 (PROGRAM): Make profile-specific.
15375 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15377 * expression.cs (DoResolveBase): Fixed wrong warning for out
15380 2004-11-18 Martin Baulig <martin@ximian.com>
15382 Merged latest changes into gmcs. Please keep this comment in
15383 here, it makes it easier for me to see what changed in MCS since
15384 the last time I merged.
15386 2004-11-17 Raja R Harinath <rharinath@novell.com>
15388 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15389 (TypeHandle.GetMemberCache): New.
15390 (TypeHandle.TypeHandle): Update.
15391 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15392 (TypeManager.LookupParentInterfacesCache):
15393 Rename from LookupInterfaceCache. Optimize slightly.
15394 (TypeManager.MemberLookup_FindMembers): Update.
15395 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15396 multi-type variant.
15397 (AddCacheContents): Rename from AddHashtable.
15398 * class.cs (TypeContainer.parent_container): Remove.
15399 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15400 (TypeContainer.DoDefineMembers): Don't initialize it.
15401 Update to name changes.
15403 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15405 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15406 that factors the code to check access modifiers on override.
15408 (PropertyBase): Use the code here.
15410 Patch from Lluis S'anchez, fixes bug #69361.
15412 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15414 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15415 routine that is used to report the use of a captured variable
15416 whose address has been taken.
15418 There are two checks: one when variables are being captured and
15419 the other check is when the address of a variable is taken.
15421 (because an anonymous methods might be resolved before *or* after
15422 the address has been taken) and
15424 * expression.cs (Conditional.DoResolve): Remove the special
15425 casing that Martin added to trueExpr and falseExpr being both
15426 NullLiteral. We get the right behavior now just by introducing
15427 the null_type into the compiler.
15429 * convert.cs (ExplicitConversion): Change the code to use
15430 null_type instead of testing `expr is NullLiteral'.
15431 (ImplicitConversionStandard): use null_type too.
15432 (ImplicitReferenceConversionExists): use null_type too.
15433 (ImplicitReferenceConversion): use null_type too.
15435 * literal.cs: The type of `NullLiteral' is now null_type instead
15437 (Resolve): Set the type here.
15439 * typemanager.cs: Introduce null_type.
15441 2004-11-17 Martin Baulig <martin@ximian.com>
15443 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15444 direction, like FindMembers() does. Fixes #69546, testcase is in
15447 2004-11-16 Martin Baulig <martin@ximian.com>
15449 This is based on a patch from Marek Safar, see bug #69082.
15450 Fixes bugs #63705 and #67130.
15452 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15453 method; create a MemberCache for an interface type and cache the
15456 * decl.cs (IMemberContainer.ParentContainer): Removed.
15457 (IMemberContainer.ParentCache): New property.
15458 (MemberCache.SetupCacheForInterface): Removed.
15459 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15460 to create a cache for an interface's "parent".
15462 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15465 2004-11-16 Martin Baulig <martin@ximian.com>
15467 Merged back from gmcs; these changes already went into gmcs a
15468 couple of weeks ago.
15471 (TypeManager.AddUserType): Removed the `ifaces' argument.
15472 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15474 (TypeManager.AddUserInterface): Removed.
15475 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15477 (TypeManager.GetInterfaces): Likewise.
15478 (TypeManager.GetExplicitInterfaces): Likewise.
15480 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15482 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15483 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
15485 2004-11-14 Ben Maurer <bmaurer@ximian.com>
15487 * statement.cs: Avoid adding bools to a hashtable.
15489 2004-11-07 Miguel de Icaza <miguel@ximian.com>
15491 * expression.cs (Invocation.OverloadResolve): Flag error if we are
15492 calling an unsafe method from a safe location.
15494 2004-11-06 Marek Safar <marek.safar@seznam.cz>
15497 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
15499 2004-11-06 Miguel de Icaza <miguel@ximian.com>
15501 * namespace.cs (VerifyUsing): use GetPartialName instead of
15504 2004-11-05 Miguel de Icaza <miguel@ximian.com>
15506 * statement.cs (Return.Resolve): Fix regression in typo: if
15507 `in_exc', we have to request a NeedReturnLabel, this was a typo
15508 introduced in the anonymous method check-in. Fixes #69131.
15510 * Indexers were using the ShortName when defining themselves,
15511 causing a regression in the compiler bootstrap when applying the
15512 patch from 2004-11-02 (first part), now they use their full name
15513 and the bug is gone.
15515 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
15517 * driver.cs: Strip the path from the names of embedded resources. Fixes
15520 2004-11-04 Raja R Harinath <rharinath@novell.com>
15522 Fix error message regression: cs0104-2.cs.
15523 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
15524 (AliasEntry.Resolve): Update.
15525 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
15527 (RootContext.LookupType): Update.
15529 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
15531 * cs-parser.jay: Add support for handling accessor modifiers
15532 * class: Add support port accessor modifiers and error checking,
15533 define PropertyMethod.Define as virtual (not abstract anymore)
15534 * ecore.cs: Add checking for proeprties access with access modifiers
15535 * iterators.cs: Modify Accessor constructor call based in the modified
15537 2004-11-02 Ben Maurer <bmaurer@ximian.com>
15539 * expression.cs (StringConcat): Handle being called twice,
15540 as when we have a concat in a field init with more than two
15543 2004-11-02 Miguel de Icaza <miguel@ximian.com>
15545 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
15546 special case explicit implementations, we should always produce
15547 the .property or .event declaration.
15549 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
15550 since it will not return correct data if people use this
15551 unresolved in the presence of using statements (see test-313).
15553 * class.cs (MethodData.Define): If we are an explicit interface
15554 implementation, set the method name to the full name of the
15555 interface plus the name of the method.
15557 Notice that using the method.MethodName.GetFullName() does not
15558 work, as it will only contain the name as declared on the source
15559 file (it can be a shorthand in the presence of using statements)
15560 and not the fully qualifed type name, for example:
15564 class D : ICloneable {
15565 object ICloneable.Clone () {
15569 Would produce a method called `ICloneable.Clone' instead of
15570 `System.ICloneable.Clone'.
15572 * namespace.cs (Alias.Resolve): Use GetPartialName.
15574 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15576 * cs-parser.jay: Add error 1055 report.
15578 2004-11-01 Miguel de Icaza <miguel@ximian.com>
15580 * assign.cs (Assign.DoResolve): Only do the transform of
15581 assignment into a New if the types are compatible, if not, fall
15582 through and let the implicit code deal with the errors and with
15583 the necessary conversions.
15585 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15587 * cs-parser.jay: Add error 1031 report.
15589 * cs-tokenizer.cs: Add location for error 1038.
15591 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15593 * cs-parser.jay: Add error 1016 report.
15595 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15597 * cs-parser.jay: Add errors 1575,1611 report.
15599 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15601 * cs-parser.jay: Add error 1001 report.
15603 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15606 * attribute.cs (GetMarshal): Add method argument for
15607 caller identification.
15609 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
15610 agument for GetMarshal and RuntimeMissingSupport.
15612 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15614 * attribute.cs (ExtractSecurityPermissionSet): Removed
15615 TypeManager.code_access_permission_type.
15617 * typemanager.cs: Removed TypeManager.code_access_permission_type.
15619 2004-10-27 Miguel de Icaza <miguel@ximian.com>
15621 * expression.cs (LocalVariableReference.DoResolveLValue): Check
15622 for obsolete use of a variable here. Fixes regression on errors
15623 cs0619-25 and cs0619-26.
15625 2004-10-27 Marek Safar <marek.safar@seznam.cz>
15627 Fix #62358, implemented security attribute encoding.
15629 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
15630 Tests permitted SecurityAction for assembly or other types.
15631 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
15632 data from SecurityPermissionAttribute to PermisionSet class.
15634 * class.cs (ApplyAttributeBuilder): Added special handling
15635 for System.Security.Permissions.SecurityAttribute based types.
15637 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
15638 special handling for System.Security.Permissions.SecurityAttribute
15641 * enum.cs (ApplyAttributeBuilder): Added special handling
15642 for System.Security.Permissions.SecurityAttribute based types.
15644 * parameter.cs (ApplyAttributeBuilder): Added special handling
15645 for System.Security.Permissions.SecurityAttribute based types.
15647 * rootcontext.cs: Next 2 core types.
15649 * typemanager.cs (TypeManager.security_permission_attr_type):
15650 Built in type for the SecurityPermission Attribute.
15651 (code_access_permission_type): Build in type.
15653 2004-10-17 Miguel de Icaza <miguel@ximian.com>
15655 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
15656 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
15657 all of this information into
15658 EmitContext.EmitCapturedVariableInstance.
15660 * codegen.cs (EmitCapturedVariableInstance): move here the
15661 funcionality of emitting an ldarg.0 in the presence of a
15662 remapping. This centralizes the instance emit code.
15664 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
15665 then emit a load of this: it means that we have reached the
15666 topmost ScopeInfo: the one that contains the pointer to the
15667 instance of the class hosting the anonymous method.
15669 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
15670 captures to the topmost CaptureContext.
15672 2004-10-12 Miguel de Icaza <miguel@ximian.com>
15674 * expression.cs (LocalVariableReference): Move the knowledge about
15675 the iterators into codegen's EmitCapturedVariableInstance.
15677 2004-10-11 Miguel de Icaza <miguel@ximian.com>
15679 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
15680 all code paths return a value from an anonymous method (it is the
15681 same as the 161 error, but for anonymous methods).
15683 2004-10-08 Miguel de Icaza <miguel@ximian.com>
15685 The introduction of anonymous methods in the compiler changed
15686 various ways of doing things in the compiler. The most
15687 significant one is the hard split between the resolution phase
15688 and the emission phases of the compiler.
15690 For instance, routines that referenced local variables no
15691 longer can safely create temporary variables during the
15692 resolution phase: they must do so from the emission phase,
15693 since the variable might have been "captured", hence access to
15694 it can not be done with the local-variable operations from the runtime.
15698 (Block.Flags): New flag `IsTopLevel' to indicate that this block
15699 is a toplevel block.
15701 (ToplevelBlock): A new kind of Block, these are the blocks that
15702 are created by the parser for all toplevel method bodies. These
15703 include methods, accessors and anonymous methods.
15705 These contain some extra information not found in regular blocks:
15706 A pointer to an optional CaptureContext (for tracking captured
15707 local variables and parameters). A pointer to the parent
15710 (Return.Resolve): Catch missmatches when returning a value from an
15711 anonymous method (error 1662).
15712 Invoke NeedReturnLabel from the Resolve phase instead of the emit
15715 (Break.Resolve): ditto.
15717 (SwitchLabel): instead of defining the labels during the
15718 resolution phase, we now turned the public ILLabel and ILLabelCode
15719 labels into methods called GetILLabelCode() and GetILLabel() that
15720 only define the label during the Emit phase.
15722 (GotoCase): Track the SwitchLabel instead of the computed label
15723 (its contained therein). Emit the code by using
15724 SwitchLabel.GetILLabelCode ().
15726 (LocalInfo.Flags.Captured): A new flag has been introduce to track
15727 whether the Local has been captured or not.
15729 (LocalInfo.IsCaptured): New property, used to tell whether the
15730 local has been captured.
15732 * anonymous.cs: Vastly updated to contain the anonymous method
15735 The main classes here are: CaptureContext which tracks any
15736 captured information for a toplevel block and ScopeInfo used to
15737 track the activation frames for various local variables.
15739 Each toplevel block has an optional capture context associated
15740 with it. When a method contains an anonymous method both the
15741 toplevel method and the anonymous method will create a capture
15742 context. When variables or parameters are captured, they are
15743 recorded on the CaptureContext that owns them, for example:
15747 MyDelegate d = delegate {
15752 Here `a' will be recorded as captured on the toplevel
15753 CapturedContext, the inner captured context will not have anything
15754 (it will only have data if local variables or parameters from it
15755 are captured in a nested anonymous method.
15757 The ScopeInfo is used to track the activation frames for local
15758 variables, for example:
15760 for (int i = 0; i < 10; i++)
15761 for (int j = 0; j < 10; j++){
15762 MyDelegate d = delegate {
15767 At runtime this captures a single captured variable `i', but it
15768 captures 10 different versions of the variable `j'. The variable
15769 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
15770 recorded on a child.
15772 The toplevel ScopeInfo will also track information like the `this'
15773 pointer if instance variables were referenced (this is necessary
15774 as the anonymous method lives inside a nested class in the host
15775 type of the method).
15777 (AnonymousMethod): Expanded to track the Toplevel, implement
15778 `AnonymousMethod.Compatible' to tell whether an anonymous method
15779 can be converted to a target delegate type.
15781 The routine now also produces the anonymous method content
15783 (AnonymousDelegate): A helper class that derives from
15784 DelegateCreation, this is used to generate the code necessary to
15785 produce the delegate for the anonymous method that was created.
15787 * assign.cs: API adjustments for new changes in
15788 Convert.ImplicitStandardConversionExists.
15790 * class.cs: Adjustments to cope with the fact that now toplevel
15791 blocks are of type `ToplevelBlock'.
15793 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
15794 insteda of standard blocks.
15796 Flag errors if params arguments are passed to anonymous methods.
15798 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
15799 `CurrentAnonymousMethod' which points to the current Anonymous
15800 Method. The variable points to the AnonymousMethod class that
15801 holds the code being compiled. It is set in the new EmitContext
15802 created for the anonymous method.
15804 (EmitContext.Phase): Introduce a variable and an enumeration to
15805 assist in enforcing some rules about when and where we are allowed
15806 to invoke certain methods (EmitContext.NeedsReturnLabel is the
15807 only one that enfonces this right now).
15809 (EmitContext.HaveCaptureInfo): new helper method that returns
15810 whether we have a CapturedContext initialized.
15812 (EmitContext.CaptureVariable): New method used to register that a
15813 LocalInfo must be flagged for capturing.
15815 (EmitContext.CapturedParameter): New method used to register that a
15816 parameters must be flagged for capturing.
15818 (EmitContext.CapturedField): New method used to register that a
15819 field must be flagged for capturing.
15821 (EmitContext.HaveCapturedVariables,
15822 EmitContext.HaveCapturedFields): Return whether there are captured
15823 variables or fields.
15825 (EmitContext.EmitMethodHostInstance): This is used to emit the
15826 instance for the anonymous method. The instance might be null
15827 (static methods), this (for anonymous methods that capture nothing
15828 and happen to live side-by-side with the current method body) or a
15829 more complicated expression if the method has a CaptureContext.
15831 (EmitContext.EmitTopBlock): Routine that drives the emission of
15832 code: it will first resolve the top block, then emit any metadata
15833 and then emit the code. The split is done so that we can extract
15834 any anonymous methods and flag any captured variables/parameters.
15836 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
15837 during this phase, the ILGenerator should not be used as labels
15838 and local variables declared here might not be accessible to any
15839 code that is part of an anonymous method.
15841 Exceptions to this include the temporary variables that are
15842 created by some statements internally for holding temporary
15845 (EmitContext.EmitMeta): New routine, in charge of emitting all the
15848 (EmitContext.TemporaryReturn): This method is typically called
15849 from the Emit phase, and its the only place where we allow the
15850 ReturnLabel to be defined other than the EmitMeta. The reason is
15851 that otherwise we would have to duplicate a lot of logic in the
15852 Resolve phases of various methods that today is on the Emit
15855 (EmitContext.NeedReturnLabel): This no longer creates the label,
15856 as the ILGenerator is not valid during the resolve phase.
15858 (EmitContext.EmitThis): Extended the knowledge in this class to
15859 work in anonymous methods in addition to iterators.
15861 (EmitContext.EmitCapturedVariableInstance): This emits whatever
15862 code is necessary on the stack to access the instance to a local
15863 variable (the variable will be accessed as a field).
15865 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
15866 EmitContext.EmitAddressOfParameter): Routines to support
15867 parameters (not completed at this point).
15869 Removals: Removed RemapLocal and RemapLocalLValue. We probably
15870 will also remove the parameters.
15872 * convert.cs (Convert): Define a `ConstantEC' which points to a
15873 null. This is just to prefity some code that uses
15874 ImplicitStandardConversion code and do not have an EmitContext
15877 The idea is to flag explicitly that at that point in time, it is
15878 known that the conversion will not trigger the delegate checking
15879 code in implicit conversions (which requires a valid
15882 Everywhere: pass new EmitContext parameter since
15883 ImplicitStandardConversionExists now requires it to check for
15884 anonymous method conversions.
15886 (Convert.ImplicitStandardConversionExists): If the type of an
15887 expression is the anonymous_method_type, and the type is a
15888 delegate, we invoke the AnonymousMethod.Compatible method to check
15889 whether an implicit conversion is possible.
15891 (Convert.ImplicitConversionStandard): Only do implicit method
15892 group conversions if the language level is not ISO_1.
15894 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
15895 MethodInfo for the Invoke method. used by Delegate and
15898 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
15899 method conversions if the target type is a delegate.
15901 Removed extra debugging nops.
15903 (LocalVariableReference): Turn the `local_info' into a public
15906 Add `prepared' field, the same hack used for FieldExprs to cope
15907 with composed assignments, as Local variables do not necessarily
15908 operate purely on the stack as they used to: they can be captured
15911 Add `temp' for a temporary result, like fields.
15913 Refactor DoResolve and DoResolveLValue into DoResolveBase.
15915 It now copes with Local variables that are captured and emits the
15916 proper instance variable to load it from a field in the captured
15919 (ParameterReference.DoResolveBase): During the resolve phase,
15920 capture parameters if we are in an anonymous method.
15922 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
15923 anonymous method, use the EmitContext helper routines to emit the
15924 parameter reference.
15926 * iterators.cs: Set RemapToProxy to true/false during the
15929 * parameters.cs (GetParameterByName): New helper method.
15931 * typemanager.cs (anonymous_method_type) a new type that
15932 represents an anonyous method. This is always an internal type,
15933 used as a fencepost to test against the anonymous-methodness of an
15936 2004-10-20 Marek Safar <marek.safar@seznam.cz>
15938 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
15940 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
15942 2004-10-18 Martin Baulig <martin@ximian.com>
15944 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
15945 `Type' directly, but call ResolveType() on it.
15946 (Catch.Resolve): Likewise.
15947 (Foreach.Resolve): Likewise.
15949 2004-10-18 Martin Baulig <martin@ximian.com>
15951 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
15952 `Type' directly, but call ResolveType() on it.
15953 (Probe.DoResolve): Likewise.
15954 (ArrayCreation.LookupType): Likewise.
15955 (TypeOf.DoResolve): Likewise.
15956 (SizeOf.DoResolve): Likewise.
15958 2004-10-18 Martin Baulig <martin@ximian.com>
15960 * expression.cs (Invocation.BetterFunction): Put back
15961 TypeManager.TypeToCoreType().
15963 2004-10-18 Raja R Harinath <rharinath@novell.com>
15965 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
15968 2004-10-18 Martin Baulig <martin@ximian.com>
15970 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
15971 `Type' directly, but call ResolveType() on it.
15973 2004-10-18 Martin Baulig <martin@ximian.com>
15975 * class.cs (FieldMember.Define): Don't access the TypeExpr's
15976 `Type' directly, but call ResolveType() on it.
15977 (MemberBase.DoDefine): Likewise.
15979 * expression.cs (New.DoResolve): Don't access the TypeExpr's
15980 `Type' directly, but call ResolveType() on it.
15981 (ComposedCast.DoResolveAsTypeStep): Likewise.
15983 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
15984 `Type' directly, but call ResolveType() on it.
15986 2004-10-17 John Luke <john.luke@gmail.com>
15988 * class.cs (Operator.GetSignatureForError): use CSharpName
15990 * parameter.cs (Parameter.GetSignatureForError): Returns
15991 correct name even if was not defined.
15993 2004-10-13 Raja R Harinath <rharinath@novell.com>
15996 * class.cs (TypeContainer.EmitContext): New property.
15997 (DefineNestedTypes): Create an emitcontext for each part.
15998 (MethodCore.DoDefineParameters): Use container's emitcontext.
15999 Pass type array to InternalParameters.
16000 (MemberBase.DoDefine): Use container's emitcontext.
16001 (FieldMember.Define): Likewise.
16002 (Event.Define): Likewise.
16003 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16004 Pass type array to InternalParameters.
16005 (SetIndexerMethod.GetParameterInfo): Likewise.
16006 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16007 * delegate.cs (Define): Pass emitcontext to
16008 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16009 array to InternalParameters.
16010 * expression.cs (ParameterReference.DoResolveBase): Pass
16011 emitcontext to GetParameterInfo.
16012 (ComposedCast.DoResolveAsTypeStep): Remove check on
16013 ec.ResolvingTypeTree.
16014 * parameter.cs (Parameter.Resolve): Change argument to
16015 EmitContext. Use ResolveAsTypeTerminal.
16016 (Parameter.GetSignature): Change argument to EmitContext.
16017 (Parameters.ComputeSignature): Likewise.
16018 (Parameters.ComputeParameterTypes): Likewise.
16019 (Parameters.GetParameterInfo): Likewise.
16020 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16021 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16022 * support.cs (InternalParameters..ctor): Remove variant that takes
16024 * typemanager.cs (system_intptr_expr): New.
16025 (InitExpressionTypes): Initialize it.
16027 2004-10-12 Chris Toshok <toshok@ximian.com>
16029 * cs-parser.jay: fix location for try_statement and catch_clause.
16031 2004-10-11 Martin Baulig <martin@ximian.com>
16033 * report.cs: Don't make --fatal abort on warnings, we have
16034 -warnaserror for that.
16036 2004-10-07 Raja R Harinath <rharinath@novell.com>
16038 More DeclSpace.ResolveType avoidance.
16039 * decl.cs (MemberCore.InUnsafe): New property.
16040 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16041 with newly created EmitContext.
16042 (FieldMember.Define): Likewise.
16043 * delegate.cs (Delegate.Define): Likewise.
16044 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16045 only if normal name-lookup fails.
16046 (TypeExpr.DoResolve): Enable error-checking.
16047 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16048 (SizeOf.DoResolve): Likewise.
16049 (ComposedCast.DoResolveAsTypeStep): Likewise.
16050 (StackAlloc.DoResolve): Likewise.
16051 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16052 (Block.Unsafe): New property.
16053 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16054 (Unsafe): Set 'unsafe' flag of contained block.
16055 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16056 (Fixed.Resolve): Likewise.
16057 (Catch.Resolve): Likewise.
16058 (Using.ResolveLocalVariableDecls): Likewise.
16059 (Foreach.Resolve): Likewise.
16061 2004-10-05 John Luke <john.luke@gmail.com>
16063 * cs-parser.jay: add location to error CS0175
16065 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16067 * ecore.cs (Expression.Constantity): Add support for turning null
16070 * const.cs (Const.Define): Allow constants to be reference types
16071 as long as the value is Null.
16073 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16075 * namespace.cs (NamespaceEntry.Using): No matter which warning
16076 level is set, check if this namespace name has already been added.
16078 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16080 * expression.cs: reftype [!=]= null should always use br[true,false].
16083 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16086 * attribute.cs: Enum conversion moved to
16087 GetAttributeArgumentExpression to be applied to the all
16090 2004-10-01 Raja R Harinath <rharinath@novell.com>
16092 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16093 * class.c (TypeContainer.DefineType): Flag error if
16094 base types aren't accessible due to access permissions.
16095 * decl.cs (DeclSpace.ResolveType): Move logic to
16096 Expression.ResolveAsTypeTerminal.
16097 (DeclSpace.ResolveTypeExpr): Thin layer over
16098 Expression.ResolveAsTypeTerminal.
16099 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16100 Refactor code into NestedAccess. Use it.
16101 (DeclSpace.NestedAccess): New.
16102 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16103 argument to silence errors. Check access permissions.
16104 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16105 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16106 (Cast.DoResolve): Likewise.
16107 (New.DoResolve): Likewise.
16108 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16109 (TypeOf.DoResolve): Likewise.
16111 * expression.cs (Invocation.BetterConversion): Return the Type of
16112 the better conversion. Implement section 14.4.2.3 more faithfully.
16113 (Invocation.BetterFunction): Make boolean. Make correspondence to
16114 section 14.4.2.2 explicit.
16115 (Invocation.OverloadResolve): Update.
16116 (Invocation): Remove is_base field.
16117 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16118 (Invocation.Emit): Likewise.
16120 2004-09-27 Raja R Harinath <rharinath@novell.com>
16122 * README: Update to changes.
16124 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16126 * cs-parser.jay: Reverted 642 warning fix.
16128 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16131 * decl.cs (FindMemberWithSameName): Indexer can have more than
16134 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16136 * expression.cs (LocalVariableReference.DoResolveLValue):
16137 Do not report warning 219 for out values.
16138 (EmptyExpression.Null): New member to avoid extra allocations.
16140 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16142 * cs-parser.jay: Fix wrong warning 642 report.
16144 * cs-tokenizer.cs (CheckNextToken): New helper;
16145 Inspect next character if is same as expected.
16147 2004-09-23 Martin Baulig <martin@ximian.com>
16149 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16150 (Convert.ImplicitReferenceConversionExists): Likewise.
16152 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16154 * class.cs (Operator.Define): Add error 448 and 559 report.
16156 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16158 * class.cs (MemberBase.IsTypePermitted): New protected
16159 method for checking error CS0610.
16161 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16163 * class.cs (TypeContainer.HasExplicitLayout): New property
16164 Returns whether container has StructLayout attribute set Explicit.
16165 (FieldMember): New abstract class for consts and fields.
16166 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16167 (Field): Reuse FieldMember.
16169 * const.cs (Const): Reuse FieldMember.
16171 * rootcontext.cs: EmitConstants call moved to class.
16173 2004-09-22 Martin Baulig <martin@ximian.com>
16175 Thanks to Peter Sestoft for this bug report.
16177 * expression.cs (Conditional): If both the `trueExpr' and the
16178 `falseExpr' is a NullLiteral, return a NullLiteral.
16180 2004-09-22 Martin Baulig <martin@ximian.com>
16182 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16183 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16184 for the "get_Current" call.
16186 2004-09-22 Martin Baulig <martin@ximian.com>
16188 Marek and me just fixed one of our oldest bugs: #28562 :-)
16190 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16192 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16193 we're an EnumConstant, just return that.
16194 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16195 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16196 to get the value which'll actually be written into the attribute.
16197 However, we have to use GetValue() to access the attribute's value
16200 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16202 * constant.cs (Constant.IsNegative): New abstract property
16205 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16206 (StackAlloc.DoResolve): Reused IsNegative.
16208 2004-09-21 Martin Baulig <martin@ximian.com>
16210 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16211 if we're used in an iterator, we may be called from different
16214 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16215 we actually have an exception block.
16217 2004-09-20 John Luke <jluke@cfl.rr.com>
16219 * class.cs, cs-parser.jay: Improve the error report for 1520:
16220 report the actual line where the error happens, not where the
16221 class was declared.
16223 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16224 Pass location information that was available elsewhere.
16226 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16228 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16229 runtime to delay sign assemblies.
16231 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16233 * cs-parser.jay: Do not report the stack trace, this is barely
16236 2004-08-22 John Luke <john.luke@gmail.com>
16238 * driver.cs : check that a resource id is not already used
16239 before adding it, report CS1508 if it is, bug #63637
16241 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16243 * ecore.cs: Removed dead code.
16245 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16247 * class.cs: Do not report warning CS0067 on the interfaces.
16249 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16251 * cs-parser.jay: Add error 504 report.
16253 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16255 * rootcontext.cs: WarningLevel is 4 by default now.
16257 * statement.cs (Fixed.Resolve): Do not null
16260 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16263 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16264 deep search when property is not virtual.
16265 (PropertyExpr.ResolveAccessors): Make one call for both
16268 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16271 * statement.cs: Error 152 report constains also location.
16273 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16276 * const.cs: Explicitly set constant as static.
16278 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16281 * cs-parser.jay: Add error 1017 report.
16283 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16285 Fixed bug #59980, #64224
16286 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16288 * typemanager.cs (IsSpecialMethod): Simplified
16290 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16292 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16293 condition with better params.
16295 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16298 * attribute.cs (Resolve): Property has to have both
16301 2004-09-14 Martin Baulig <martin@ximian.com>
16303 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16305 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16308 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16309 called and is obsolete then this member suppress message
16310 when call is inside next [Obsolete] method or type.
16312 * expression.cs: Use TestObsoleteMethodUsage member.
16314 2004-09-14 Martin Baulig <martin@ximian.com>
16316 * cs-parser.jay: Sync a bit with the GMCS version.
16318 2004-09-14 Martin Baulig <martin@ximian.com>
16320 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16321 (CSharpParser.yacc_verbose_flag): New public field.
16323 * genericparser.cs: Removed.
16325 2004-09-14 Raja R Harinath <rharinath@novell.com>
16327 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16329 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16331 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16333 2004-09-10 Martin Baulig <martin@ximian.com>
16335 Backported my MemberName changes from GMCS into MCS.
16337 - we are now using a special `MemberName' class instead of using
16338 strings; in GMCS, the `MemberName' also contains the type
16341 - changed the grammar rules a bit:
16342 * the old `member_name' is now a `namespace_or_type_name':
16343 The rule is that we use `namespace_or_type_name' everywhere
16344 where we expect either a "member name" (GetEnumerator) or a
16345 "member name" with an explicit interface name
16346 (IEnumerable.GetEnumerator).
16347 In GMCS, the explicit interface name may include type arguments
16348 (IEnumerable<T>.GetEnumerator).
16349 * we use `member_name' instead of just `IDENTIFIER' for
16351 The rule is that we use `member_name' wherever a member may
16352 have type parameters in GMCS.
16354 * decl.cs (MemberName): New public class.
16355 (MemberCore.MemberName): New public readonly field.
16356 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16357 (DeclSpace): Likewise.
16359 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16360 * enum.cs (Enum.ctor): Likewise.
16362 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16364 (AliasEntry.ctor): Take a MemberName, not an Expression.
16365 (AliasEntry.UsingAlias): Likewise.
16367 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16368 (IMethodData.MemberName): Changed type from string to MemberName.
16369 (MemberBase.ExplicitInterfaceName): Likewise.
16370 (AbstractPropertyEventMethod.SetupName): Make this private.
16371 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16372 argument; compute the member name here.
16373 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16374 on the `member.MemberName' and the `prefix'.
16376 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16378 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16379 thus, we get a `MemberName' instead of a `string'. These
16380 declarations may have type parameters in GMCS.
16381 (interface_method_declaration, delegate_declaration): Likewise.
16382 (class_declaration, interface_declaration): Likewise.
16383 (method_header): Use `namespace_or_type_name' instead of
16384 `member_name'. We may be an explicit interface implementation.
16385 (property_declaration, event_declaration): Likewise.
16386 (member_name): This is now just an `IDENTIFIER', not a
16387 `namespace_or_type_name'.
16388 (type_name, interface_type): Removed.
16389 (namespace_or_type_name): Return a MemberName, not an Expression.
16390 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16391 call GetTypeExpression() on the MemberName to get an expression.
16392 (IndexerDeclaration.interface_type): Changed type from string to
16394 (MakeName): Operate on MemberName's instead of string's.
16396 2004-09-13 Raja R Harinath <rharinath@novell.com>
16399 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16400 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16401 lookup to avoid symbols introduced by 'using'.
16402 * rootcontext.cs (NamespaceLookup): Update.
16404 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16406 * class.cs (TypeContainer.DoDefineMembers): Do not call
16407 DefineDefaultConstructor for static classes.
16409 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16411 * attribute.cs (Attribute.Resolve): Add error 653 report.
16413 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16415 (Method.ApplyAttributeBuilder): Add error 685 report.
16416 (Operator.Define): Add error 564 report.
16418 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16420 * expression.cs (Invocation.DoResolve): Add error
16421 245 and 250 report.
16423 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16426 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16428 * class.cs (ConstructorInitializer.Resolve):
16429 Wrong error number (515->516).
16431 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16433 * class.cs (Indexer.Define): Add error 631 report.
16435 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16437 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16439 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16441 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16443 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16445 * cs-parser.jay: Added error CS0241 report.
16447 2004-09-10 Raja R Harinath <rharinath@novell.com>
16449 * cs-parser.jay (fixed_statement): Introduce a scope for the
16450 declaration in the 'fixed' statement.
16452 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16454 * cs-parser.jay: Added CS0230 error report.
16456 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16458 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16460 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16462 * expression.cs (Argument.Resolve): Added error CS0192 and
16465 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16467 C# 2.0 #pragma warning feature
16469 * cs-tokenizer.cs (PreProcessPragma): New method;
16470 Handles #pragma directive.
16472 * report.cs (WarningRegions): New class; Support
16473 class for #pragma warning directive. It tests whether
16474 warning is enabled for a given line.
16476 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16478 * const.cs: Add more descriptive error report, tahnks to
16481 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16483 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
16485 2004-09-07 Miguel de Icaza <miguel@ximian.com>
16487 * expression.cs: Apply patch from Ben: Remove dead code from
16488 ArrayCreation, and remove the TurnintoConstant call in const.cs,
16489 as that code just threw an exception anwyays.
16491 * const.cs: Remove the call to the turnintoconstant, for details
16494 * literal.cs: The type of the null-literal is the null type; So
16495 we use a placeholder type (literal.cs:System.Null, defined here)
16498 * expression.cs (Conditional.DoResolve): Remove some old code that
16499 is no longer needed, conversions have been fixed.
16501 (ArrayCreationExpression.DoResolve): Return false if we fail to
16502 resolve the inner expression.
16504 2004-09-07 Raja R Harinath <rharinath@novell.com>
16507 * cs-parser.jay (delegate_declaration): Record a delegate
16508 declaration as a type declaration.
16509 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
16511 2004-09-06 Miguel de Icaza <miguel@ximian.com>
16513 * parameter.cs: Do not crash if the type can not be resolved.
16515 * expression.cs: Report errors with unsafe pointers, fixes #64896
16517 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
16519 * expression.cs: Pointer arith always needs to do a conv.i
16520 if the operand is a long. fix 65320
16522 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16524 Fixed cs0619-37.cs, cs0619-38.cs
16526 * enum.cs (GetObsoleteAttribute): Removed.
16528 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
16529 on Enum member is double staged. The first is tested member
16532 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16534 Fixed #56986, #63631, #65231
16536 * class.cs: (TypeContainer.AddToMemberContainer): New method,
16537 adds member to name container.
16538 (TypeContainer.AddToTypeContainer): New method, adds type to
16540 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
16541 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
16542 AddOperator): Simplified by reusing AddToMemberContainer.
16543 (TypeContainer.UserDefinedStaticConstructor): Changed to property
16545 (Method.CheckForDuplications): Fixed implementation to test all
16547 (MemberBase): Detection whether member is explicit interface
16548 implementation is now in constructor.
16549 (MemberBase.UpdateMemberName): Handles IndexerName.
16550 (Accessor): Changed to keep also location information.
16551 (AbstractPropertyEventMethod): Is derived from MemberCore.
16552 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
16553 will be emited or not.
16554 (PropertyBase.AreAccessorsDuplicateImplementation):
16555 Tests whether accessors are not in collision with some method.
16556 (Operator): Is derived from MethodCore to simplify common
16559 * decl.cs (Flags.TestMethodDuplication): Test for duplication
16561 (DeclSpace.AddToContainer): Adds the member to defined_names
16562 table. It tests for duplications and enclosing name conflicts.
16564 * enum.cs (EnumMember): Clean up to reuse the base structures
16566 2004-09-03 Martin Baulig <martin@ximian.com>
16568 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
16569 into TypeContainer, to make partial classes work again.
16571 2004-09-03 Martin Baulig <martin@ximian.com>
16573 * rootcontext.cs (RootContext.V2): Removed.
16575 2004-03-23 Martin Baulig <martin@ximian.com>
16577 * expression.cs (Invocation.OverloadResolve): Added `bool
16578 may_fail' argument and use it instead of the Location.IsNull() hack.
16580 2004-09-03 Martin Baulig <martin@ximian.com>
16582 Merged latest changes into gmcs. Please keep this comment in
16583 here, it makes it easier for me to see what changed in MCS since
16584 the last time I merged.
16586 2004-09-03 Raja R Harinath <rharinath@novell.com>
16589 * expression.cs (BetterConversion): Don't allow either conversion
16590 to be null. Remove redundant implicit conversion test when 'q ==
16591 null' -- when this function is invoked, we already know that the
16592 implicit conversion exists.
16593 (BetterFunction): Assume that 'best' is non-null. Remove
16594 redundant reimplementation of IsApplicable when 'best' is null.
16595 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
16596 number of arguments.
16597 (IsAncestralType): Extract from OverloadResolve.
16598 (OverloadResolve): Make robust to the MethodGroupExpr being
16599 unsorted. Implement all the logic of Section 14.5.5.1, and
16600 support overloading of methods from multiple applicable types.
16601 Clean up logic somewhat. Don't pass null methods to BetterFunction.
16603 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
16604 (RealError, Warning): Append type of report to related symbol.
16606 2004-09-03 Marek Safar <marek.safar@seznam.cz>
16608 * enum.cs: Fixed CLS-Compliance checks for enum members.
16609 Error tests cs3008-8.cs, cs3014-8.cs
16611 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16613 Fixed bug #62342, #63102
16614 * class.cs: ImplementIndexer uses member.IsExplicitImpl
16615 like ImplementMethod.
16617 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16619 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16622 2004-09-02 Martin Baulig <martin@ximian.com>
16624 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
16625 TypeManager.GetArgumentTypes() rather than calling GetParameters()
16628 2004-09-01 Marek Safar <marek.safar@seznam.cz>
16630 C# 2.0 Static classes implemented
16632 * class.cs (TypeContainer): instance_constructors,
16633 initialized_fields, initialized_static_fields,
16634 default_constructor, base_inteface_types are protected to be
16635 accessible from StaticClass.
16636 (TypeContainer.DefineDefaultConstructor): New virtual method
16637 for custom default constructor generating
16638 (StaticClass): New class to handle "Static classes" feature.
16640 * cs-parser.jay: Handle static keyword on class like instance
16643 * driver.cs: Added "/langversion" command line switch with two
16644 options (iso-1, default).
16646 2004-08-31 Marek Safar <marek.safar@seznam.cz>
16648 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
16650 2004-08-31 Miguel de Icaza <miguel@ximian.com>
16652 * delegate.cs: Style.
16654 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
16656 * delegate.cs: Add seperate instance expr field for miguel.
16658 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16660 * PointerArithmetic (Resolve): make sure we are not doing
16661 pointer arith on void*. Also, make sure we are resolved
16662 by not setting eclass until resolve.
16664 All callers: Make sure that PointerArithmetic gets resolved.
16666 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16668 * ArrayCreation (LookupType): If the type does not resolve
16669 to an array, give an error.
16671 2004-08-27 Marek Safar <marek.safar@seznam.cz>
16673 * statement.cs (Try.Resolve): Fixed bug #64222
16675 2004-08-27 Martin Baulig <martin@ximian.com>
16678 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
16681 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16683 * ecore.cs (Constantify): Get underlying type via
16684 System.Enum.GetUnderlyingType to avoid StackOverflow on the
16685 Windows in special cases.
16687 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16689 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
16690 for obtaining also private methods.
16691 (GetRemoveMethod): Used GetRemoveMethod (true)
16692 for obtaining also private methods.
16694 2004-08-24 Martin Baulig <martin@ximian.com>
16696 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
16697 MethodAttributes.HideBySig for operators.
16699 2004-08-23 Martin Baulig <martin@ximian.com>
16701 Back to the old error reporting system :-)
16703 * report.cs (Message): Removed.
16704 (Report.MessageData, ErrorData, WarningData): Removed.
16705 (Report.Error, Warning): Back to the old system.
16707 2004-08-23 Martin Baulig <martin@ximian.com>
16709 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
16711 * class.cs (TypeContainer.ParentContainer): New public virtual
16712 method; replaces the explicit interface implementation.
16713 (ClassPart.ParentContainer): Override.
16715 2004-08-23 Martin Baulig <martin@ximian.com>
16717 * statement.cs (Switch): Added support for constant switches; see
16718 #59428 or test-285.cs.
16720 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16723 * statement.cs (GetEnumeratorFilter): Removed useless
16724 logic because C# specs is strict. GetEnumerator must be
16727 2004-08-22 Martin Baulig <martin@ximian.com>
16729 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
16730 a switch and may break, reset the barrier. Fixes #59867.
16732 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16734 CLS-Compliance speed up (~5% for corlib)
16736 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
16737 New method. Tests container for CLS-Compliant names
16739 * class.cs (TypeContainer.VerifyClsName): New method.
16740 Checks whether container name is CLS Compliant.
16741 (Constructor): Implements IMethodData.
16743 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
16744 low-case table for CLS Compliance test.
16745 (MemberCache.VerifyClsParameterConflict): New method.
16746 Checks method parameters for CS3006 error.
16748 * enum.cs (EnumMember): Is derived from MemberCore.
16749 (Enum.VerifyClsName): Optimized for better performance.
16751 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16753 * report.cs: Renamed Error_T to Error and changed all
16756 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16758 * class.cs (TypeContainer.IndexerArrayList): New inner class
16759 container for indexers.
16760 (TypeContainer.DefaultIndexerName): New constant for default
16761 indexer name. Replaced all "Item" with this constant.
16762 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
16764 * typemanager.cs (TypeManager.default_member_ctor): Cache here
16765 DefaultMemberAttribute constructor.
16767 2004-08-05 Martin Baulig <martin@ximian.com>
16769 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
16772 2004-08-05 Marek Safar <marek.safar@seznam.cz>
16774 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
16775 multi platforms problem.
16777 * compiler.csproj: Included shared files.
16779 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16781 Fix bug 60333, 55971 in the more general way
16782 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16783 Added arg_type argument for constant conversion.
16784 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
16786 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16789 * class.cs (TypeContainer ): New inner classes MethodArrayList,
16790 OperatorArrayList, MethodCoreArrayList for typecontainer
16791 containers. Changed class member types to these new types.
16792 (MethodArrayList.DefineMembers): Added test for CS0659.
16794 2004-08-04 Miguel de Icaza <miguel@ximian.com>
16796 * cfold.cs: Synchronize the folding with the code in expression.cs
16797 Binary.DoNumericPromotions for uint operands.
16799 * attribute.cs: Revert patch from Raja, it introduced a regression
16800 while building Blam-1.2.1 (hard to isolate a test case).
16802 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16806 (TypeContainer.Define): Renamed to DefineContainerMembers because of
16808 (MethodCore.parent_method): New member. The method we're overriding
16809 if this is an override method.
16810 (MethodCore.CheckBase): Moved from Method class and made common.
16811 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
16813 (MethodCore.CheckForDuplications): New abstract method. For custom
16814 member duplication search in a container
16815 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
16816 method and its return type.
16817 (Event.conflict_symbol): New member. Symbol with same name in the
16821 (MemberCache.FindMemberWithSameName): New method. The method
16822 is looking for conflict with inherited symbols.
16824 2004-08-04 Martin Baulig <martin@ximian.com>
16826 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
16828 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
16830 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16832 * report.cs (Message): New enum for better error, warning reference in
16834 (MessageData): New inner abstract class. It generally handles printing of
16835 error and warning messages.
16836 Removed unused Error, Warning, Message methods.
16838 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16840 Fix for cs0592-8.cs test
16842 (Attributable.ValidAttributeTargets): Made public.
16843 (Attribute.ExplicitTarget): New member for explicit target value.
16844 (Attribute.CheckTargets): Now we translate explicit attribute
16845 target to Target here.
16847 2004-08-03 Ben Maurer <bmaurer@ximian.com>
16849 * ecore.cs (MethodGroupExpr): new IsBase property.
16851 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
16853 * delegate.cs (DelegateCreation): store a MethodGroupExpr
16854 rather than an instance expr.
16856 (DelegateCreation.Emit): Use the method group rather than
16857 the instance expression. Also, if you have base.Foo as the
16858 method for a delegate, make sure to emit ldftn, not ldftnvirt.
16860 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
16862 (NewDelegate.DoResolve): Only check for the existance of Invoke
16863 if the method is going to be needed. Use MethodGroupExpr.
16865 (NewDelegate.Emit): Remove, DelegateCreation implements this.
16867 * expression.cs: For pointer arith., make sure to use
16868 the size of the type, not the size of the pointer to
16871 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16874 * class.cs (Class): Added error CS0502 test.
16876 2004-08-03 John Luke <jluke@cfl.rr.com>
16877 Raja R Harinath <rharinath@novell.com>
16880 * attribute.cs (Attribute.complained_before): New flag.
16881 (Attribute.ResolveType, Attribute.Resolve),
16882 (Attribute.DefinePInvokeMethod): Set it.
16883 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
16885 2004-08-03 Martin Baulig <martin@ximian.com>
16887 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
16888 use a user-defined operator; we still need to do numeric
16889 promotions in case one argument is a builtin type and the other
16890 one has an implicit conversion to that type. Fixes #62322.
16892 2004-08-02 Martin Baulig <martin@ximian.com>
16894 * statement.cs (LocalInfo.Flags): Added `IsThis'.
16895 (LocalInfo.IsThis): New public property.
16896 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
16898 2004-08-01 Martin Baulig <martin@ximian.com>
16900 * class.cs (TypeContainer.GetClassBases): Don't set the default
16901 here since we may get called from GetPartialBases().
16902 (TypeContainer.DefineType): If GetClassBases() didn't return a
16903 parent, use the default one.
16905 2004-07-30 Duncan Mak <duncan@ximian.com>
16907 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
16909 2004-07-30 Martin Baulig <martin@ximian.com>
16911 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
16913 * class.cs (SourceMethod): New public class, derive from the
16914 symbol writer's ISourceMethod.
16915 (Method): Use the new symbol writer API.
16917 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
16918 as argument and use the new symbol writer.
16921 (SourceFile): Implement the symbol writer's ISourceFile.
16922 (Location.SymbolDocument): Removed.
16923 (Location.SourceFile): New public property.
16925 * symbolwriter.cs: Use the new symbol writer API.
16927 2004-07-30 Raja R Harinath <rharinath@novell.com>
16929 * Makefile (install-local): Remove. Functionality moved to
16932 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
16934 * Makefile: Install mcs.exe.config file together with mcs.exe.
16935 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
16936 correct runtime version.
16938 2004-07-25 Martin Baulig <martin@ximian.com>
16941 (TypeContainer.RegisterOrder): Removed, this was unused.
16942 (TypeContainer, interface_order): Removed.
16943 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
16944 TypeContainer as argument since we can also be called with a
16945 `PartialContainer' for a partial class/struct/interface.
16946 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
16947 of checking whether we're an `Interface' - we could be a
16948 `PartialContainer'.
16949 (PartialContainer.Register): Override; call
16950 AddClass()/AddStruct()/AddInterface() on our parent.
16952 * cs-parser.jay (interface_member_declaration): Add things to the
16953 `current_container', not the `current_class'.
16955 * rootcontext.cs (RegisterOrder): The overloaded version which
16956 takes an `Interface' was unused, removed.
16958 * typemanager.cs (TypeManager.LookupInterface): Return a
16959 `TypeContainer', not an `Interface'.
16960 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
16961 contain a `PartialContainer' for an interface, so check it's
16962 `Kind' to figure out what it is.
16964 2004-07-25 Martin Baulig <martin@ximian.com>
16966 * class.cs (Class.DefaultTypeAttributes): New public constant.
16967 (Struct.DefaultTypeAttributes): Likewise.
16968 (Interface.DefaultTypeAttributes): Likewise.
16969 (PartialContainer.TypeAttr): Override this and add the
16970 DefaultTypeAttributes.
16972 2004-07-25 Martin Baulig <martin@ximian.com>
16974 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
16975 we can just use the `Parent' field instead.
16977 2004-07-25 Martin Baulig <martin@ximian.com>
16979 * class.cs (TypeContainer.Emit): Renamed to EmitType().
16981 2004-07-25 Martin Baulig <martin@ximian.com>
16983 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
16984 our parts before defining any methods.
16985 (TypeContainer.VerifyImplements): Make this virtual.
16986 (ClassPart.VerifyImplements): Override and call VerifyImplements()
16987 on our PartialContainer.
16989 2004-07-25 Martin Baulig <martin@ximian.com>
16991 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
16993 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
16994 argument, we can just use the `Parent' field instead.
16997 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
16998 (MemberBase.DoDefine): Likewise.
17000 2004-07-24 Martin Baulig <martin@ximian.com>
17002 * decl.cs (MemberCore.Parent): New public field.
17003 (DeclSpace.Parent): Moved to MemberCore.
17005 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17006 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17008 (FieldBase, Field, Operator): Likewise.
17009 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17010 (EventField, Event): Likewise.
17012 2004-07-23 Martin Baulig <martin@ximian.com>
17014 * class.cs (PartialContainer): New public class.
17015 (ClassPart): New public class.
17016 (TypeContainer): Added support for partial classes.
17017 (TypeContainer.GetClassBases): Splitted some of the functionality
17018 out into GetNormalBases() and GetPartialBases().
17020 * cs-tokenizer.cs (Token.PARTIAL): New token.
17021 (Tokenizer.consume_identifier): Added some hacks to recognize
17022 `partial', but only if it's immediately followed by `class',
17023 `struct' or `interface'.
17025 * cs-parser.jay: Added support for partial clases.
17027 2004-07-23 Martin Baulig <martin@ximian.com>
17029 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17030 a `DeclSpace' and also made it readonly.
17031 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17032 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17033 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17035 * cs-parser.jay: Pass the `current_class', not the
17036 `current_container' (at the moment, this is still the same thing)
17037 to a new Method, Property, Event, Indexer or Constructor.
17039 2004-07-23 Martin Baulig <martin@ximian.com>
17041 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17042 and removed the `current_interface' one.
17043 (struct_declaration, class_declaration, interface_declaration):
17044 Set `current_class' to the newly created class/struct/interface;
17045 set their `Bases' and call Register() before parsing their body.
17047 2004-07-23 Martin Baulig <martin@ximian.com>
17049 * class.cs (Kind): New public enum.
17050 (TypeContainer): Made this class abstract.
17051 (TypeContainer.Kind): New public readonly field.
17052 (TypeContainer.CheckDef): New public method; moved here from
17054 (TypeContainer.Register): New public abstract method.
17055 (TypeContainer.GetPendingImplementations): New public abstract
17057 (TypeContainer.GetClassBases): Removed the `is_class' and
17058 `is_iface' parameters.
17059 (TypeContainer.DefineNestedTypes): Formerly known as
17061 (ClassOrStruct): Made this class abstract.
17063 * tree.cs (RootTypes): New public type.
17065 2004-07-20 Martin Baulig <martin@ximian.com>
17067 * tree.cs (Tree.RecordNamespace): Removed.
17068 (Tree.Namespaces): Removed.
17070 * rootcontext.cs (RootContext.IsNamespace): Removed.
17072 * cs-parser.jay (namespace_declaration): Just create a new
17073 NamespaceEntry here.
17075 2004-07-20 Martin Baulig <martin@ximian.com>
17077 * statement.cs (ExceptionStatement): New abstract class. This is
17078 now used as a base class for everyone who's using `finally'.
17079 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17080 our local variables before using them.
17082 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17083 virtual method. This is used by Yield.Resolve() to "steal" an
17084 outer block's `finally' clauses.
17085 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17088 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17089 version which takes an ExceptionStatement. This version must be
17090 used to create exception branchings.
17093 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17094 (Iterator.EmitMoveNext): Added exception support; protect the
17095 block with a `fault' clause, properly handle 'finally' clauses.
17096 (Iterator.EmitDispose): Run all the `finally' clauses here.
17098 2004-07-20 Martin Baulig <martin@ximian.com>
17100 * iterator.cs: This is the first of a set of changes in the
17101 iterator code. Match the spec more closely: if we're an
17102 IEnumerable, then GetEnumerator() must be called. The first time
17103 GetEnumerator() is called, it returns the current instance; all
17104 subsequent invocations (if any) must create a copy.
17106 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17108 * expression.cs: Resolve the constant expression before returning
17111 2004-07-19 Martin Baulig <martin@ximian.com>
17113 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17114 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17115 the return type of the new EmitContext.
17117 2004-07-18 Martin Baulig <martin@ximian.com>
17119 * class.cs (Property.Define): Fix iterators.
17121 * iterators.cs (Iterator.Define): Moved the
17122 `container.AddInterator (this)' call here from the .ctor; only do
17123 it if we resolved successfully.
17125 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17127 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17128 `true' for preprocessing directives that we parse. The return
17129 value indicates whether we should return to regular tokenizing or
17130 not, not whether it was parsed successfully.
17132 In the past if we were in: #if false ... #line #endif, we would
17133 resume parsing after `#line'. See bug 61604.
17135 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17136 building: IsEnumType should return true only for enums, not for
17137 enums or System.Enum itself. This fixes #61593.
17139 Likely what happened is that corlib was wrong: mcs depended on
17140 this bug in some places. The bug got fixed, we had to add the
17141 hack, which caused bug 61593.
17143 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17144 that was a workaround for the older conditions.
17146 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17148 * assign.cs: IAssignMethod has a new interface, as documented
17149 inline. All assignment code now uses this new api.
17151 * ecore.cs, expression.cs: All classes which implement
17152 IAssignMethod now use the new interface.
17154 * expression.cs (Invocation): add a hack to EmitCall so that
17155 IndexerAccess can be the target of a compound assignment without
17156 evaluating its arguments twice.
17158 * statement.cs: Handle changes in Invocation api.
17160 2004-07-16 Martin Baulig <martin@ximian.com>
17162 * iterators.cs: Rewrote this. We're now using one single Proxy
17163 class for both the IEnumerable and the IEnumerator interface and
17164 `Iterator' derives from Class so we can use the high-level API.
17166 * class.cs (TypeContainer.AddIterator): New method.
17167 (TypeContainer.DoDefineType): New protected virtual method, which
17168 is called from DefineType().
17169 (TypeContainer.DoDefineMembers): Call DefineType() and
17170 DefineMembers() on all our iterators.
17171 (TypeContainer.Emit): Call Emit() on all our iterators.
17172 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17174 * codegen.cs (EmitContext.CurrentIterator): New public field.
17176 2004-07-15 Martin Baulig <martin@ximian.com>
17179 (TypeManager.not_supported_exception_type): New type.
17181 2004-07-14 Martin Baulig <martin@ximian.com>
17183 * iterators.cs: Use real error numbers.
17185 2004-07-14 Martin Baulig <martin@ximian.com>
17187 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17188 requires this to be a System.Collection.IEnumerable and not a
17189 class implementing that interface.
17190 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17192 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17194 * class.cs: Fixed previous fix, it broke some error tests.
17196 2004-07-12 Martin Baulig <martin@ximian.com>
17198 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17201 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17203 * assign.cs (LocalTemporary): Add new argument: is_address,If
17204 `is_address' is true, then the value that we store is the address
17205 to the real value, and not the value itself.
17207 * ecore.cs (PropertyExpr): use the new local temporary
17208 stuff to allow us to handle X.Y += z (where X is a struct)
17210 2004-07-08 Martin Baulig <martin@ximian.com>
17212 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17213 not always return, just like we're doing in Using.Resolve().
17215 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17217 * cs-parser.jay (fixed_statement): flag this as Pinned.
17219 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17221 * typemanager.cs (TypeManager): Removed MakePinned method, this
17222 mechanism is replaced with the .NET 2.x compatible mechanism of
17223 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17225 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17226 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17227 `IsFixed' property which has a different meaning.
17229 2004-07-02 Raja R Harinath <rharinath@novell.com>
17231 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17232 visible from inside a nested class, not just the names of the
17233 immediately enclosing class.
17234 Fix for bug #60730.
17236 2004-06-24 Raja R Harinath <rharinath@novell.com>
17238 * expression.cs (BetterConversion): Remove buggy special-case
17239 handling of "implicit constant expression conversions". At this
17240 point, we already know that the conversion is possible -- we're
17241 only checking to see which is better.
17243 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17245 * cs-parser.jay: Added error CS0210 test.
17247 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17249 * cs-parser.jay: Added error CS0134 test.
17251 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17254 * cs-parser.jay: Added error CS0145 test.
17256 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17258 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17260 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17262 * expression.cs (StackAlloc.Resolve): The argument may not
17263 be a constant; deal with this case.
17265 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17267 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17268 GetIndexerAttributeValue.
17269 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17271 * class.cs (Indexer.Define): Added error tests for CS0415,
17274 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17276 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17279 2004-06-23 Martin Baulig <martin@ximian.com>
17281 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17282 neither return nor throw, reset the barrier as well. Fixes #60457.
17284 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17286 * class.cs : EventAttributes is now set to None by default.
17287 This fixes bug #60459.
17289 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17292 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17293 Don't throw exception but return null (it's sufficient now).
17295 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17297 * typemanager.cs (GetArgumentTypes): Faster implementation.
17299 2004-06-18 Martin Baulig <martin@ximian.com>
17301 * attribute.cs (Attribute.Resolve): Check whether we're an
17302 EmptyCast which a Constant child. Fixes #60333.
17304 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17306 * statement.cs (EmitCollectionForeach): Account for the fact that
17307 not all valuetypes are in areas which we can take the address of.
17308 For these variables, we store to a temporary variable. Also, make
17309 sure that we dont emit a `callvirt' on a valuetype method.
17311 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17313 * expression.cs (StackAlloc.DoReSolve): Added test for
17314 negative parameter (CS0247).
17316 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17319 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17321 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17324 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17327 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17329 Fix bug #58254 & cs1555.cs, cs1556.cs
17330 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17332 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17334 * cs-parser.jay: Added error CS1669 test for indexers.
17336 2004-06-11 Martin Baulig <martin@ximian.com>
17338 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17339 call this twice: for params and varargs methods.
17341 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17344 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17346 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17348 * attribute.cs (Attribute.GetValidTargets): Made public.
17351 (AbstractPropertyEventMethod): New class for better code sharing.
17352 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17354 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17356 2004-06-11 Raja R Harinath <rharinath@novell.com>
17359 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17360 that the call to Resolve is part of a MemberAccess.
17361 (Expression.Resolve): Use it for SimpleName resolution.
17362 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17363 Add 'intermediate' boolean argument.
17364 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17365 error message when the SimpleName can be resolved ambiguously
17366 between an expression and a type.
17367 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17369 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17370 call on the left-side.
17372 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17375 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17377 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17379 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17381 2004-06-11 Martin Baulig <martin@ximian.com>
17383 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17384 varargs methods if applicable.
17386 2004-06-11 Martin Baulig <martin@ximian.com>
17388 * expression.cs (Invocation.EmitCall): Don't use
17389 `method.CallingConvention == CallingConventions.VarArgs' since the
17390 method could also have `CallingConventions.HasThis'.
17392 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17394 * class.cs (Event.GetSignatureForError): Implemented.
17395 Fixed crash in error test cs3010.cs
17397 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17399 * cs-tokenizer.cs: Change the way we track __arglist to be
17400 consistent with the other keywords.
17402 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17404 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17407 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17409 * codegen.cs: Check that all referenced assemblies have a strongname
17410 before strongnaming the compiled assembly. If not report error CS1577.
17411 Fix bug #56563. Patch by Jackson Harper.
17412 * typemanager.cs: Added a method to return all referenced assemblies.
17413 Fix bug #56563. Patch by Jackson Harper.
17415 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17418 (Method.ApplyAttributeBuilder): Moved and added conditional
17419 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17422 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17424 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17427 * class.cs: (EventField.attribute_targets): Changed default target.
17429 2004-06-08 Martin Baulig <martin@ximian.com>
17431 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17433 2004-06-08 Martin Baulig <martin@ximian.com>
17435 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17437 2004-06-07 Martin Baulig <martin@ximian.com>
17439 Added support for varargs methods.
17441 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17444 * cs-parser.jay: Added support for `__arglist'.
17446 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17448 * expression.cs (Argument.AType): Added `ArgList'.
17449 (Invocation): Added support for varargs methods.
17450 (ArglistAccess): New public class.
17451 (Arglist): New public class.
17453 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17455 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17456 a method's top-level block if the method has varargs.
17458 * support.cs (ReflectionParameters, InternalParameters): Added
17459 support for varargs methods.
17461 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17463 * class.cs: Provide location in indexer error report.
17465 * driver.cs: Use standard names.
17467 * namespace.cs: Catch the use of using after a namespace has been
17468 declared also on using aliases.
17470 2004-06-03 Raja R Harinath <rharinath@novell.com>
17473 * typemanager.cs (closure_private_ok, closure_invocation_type)
17474 (closure_qualifier_type, closure_invocation_assembly)
17475 (FilterWithClosure): Move to ...
17476 (Closure): New internal nested class.
17477 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17478 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17479 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17480 (MemberLookup, MemberLookupFailed): Use it.
17481 * expression.cs (New.DoResolve): Treat the lookup for the
17482 constructor as being qualified by the 'new'ed type.
17483 (Indexers.GetIndexersForTypeOrInterface): Update.
17485 2004-06-03 Marek Safar <marek.safar@seznam.cz>
17488 (GetConditionalAttributeValue): New method. Returns
17489 condition of ConditionalAttribute.
17490 (SearchMulti): New method. Returns all attributes of type 't'.
17491 Use it when attribute is AllowMultiple = true.
17492 (IsConditionalMethodExcluded): New method.
17495 (Method.IsExcluded): Implemented. Returns true if method has conditional
17496 attribute and the conditions is not defined (method is excluded).
17497 (IMethodData): Extended interface for ConditionalAttribute support.
17498 (PropertyMethod.IsExcluded): Implemented.
17501 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
17504 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
17507 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
17509 * expression.cs (ArrayCreationExpression): Make this just an
17510 `expression'. It can't be a statement, so the code here was
17513 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17516 * typemanager.cs (GetFullNameSignature): New method for
17519 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17522 * class.cs (MemberBase.GetSignatureForError): New virtual method.
17523 Use this method when MethodBuilder is null.
17524 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
17525 Added test for error CS0626 (MONO reports error for this situation).
17526 (IMethodData.GetSignatureForError): Extended interface.
17528 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17531 (AttributeTester.GetObsoleteAttribute): Returns instance of
17532 ObsoleteAttribute when type is obsolete.
17535 (TypeContainer.VerifyObsoleteAttribute): Override.
17536 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
17537 (MethodCode.VerifyObsoleteAttribute): Override.
17538 (MemberBase.VerifyObsoleteAttribute): Override.
17541 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
17542 and report proper error.
17545 Delegate.VerifyObsoleteAttribute): Override.
17548 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
17549 and report proper error.
17550 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
17553 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
17557 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
17558 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
17559 Added test for ObsoleteAttribute.
17562 (Catch): Derived from Statement.
17564 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17566 Fixed bug #59071 & cs0160.cs
17568 * statement.cs (Try.Resolve): Check here whether order of catch
17569 clauses matches their dependencies.
17571 2004-05-31 Miguel de Icaza <miguel@ximian.com>
17573 * Reverted patch to namespace.cs (Use lookuptypedirect). This
17574 caused a regression: #59343. Referencing nested classes from an
17575 assembly stopped working.
17577 2004-05-31 Martin Baulig <martin@ximian.com>
17579 MCS is now frozen for beta 2.
17581 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17583 * convert.cs: add a trivial cache for overload operator resolution.
17585 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17587 * decl.cs: If possible, use lookuptypedirect here. We can only do
17588 this if there is no `.' after the namespace. Avoids using
17589 LookupType, which does lots of slow processing.
17590 (FindNestedType) New method, does what it says :-).
17591 * namespace.cs: use LookupTypeDirect.
17592 * rootcontext.cs: use membercache, if possible.
17593 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
17595 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17598 According to the spec,
17600 In a member access of the form E.I, if E is a single identifier,
17601 and if the meaning of E as a simple-name (§7.5.2) is a constant,
17602 field, property, localvariable, or parameter with the same type as
17603 the meaning of E as a type-name (§3.8), then both possible
17604 meanings of E are permitted.
17606 We did not check that E as a simple-name had the same type as E as
17609 This trivial check gives us 5-7% on bootstrap time.
17611 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17613 * expression.cs (Invocation.OverloadResolve): Avoid the
17614 use of hashtables and boxing here by allocating on demand.
17616 2004-05-30 Martin Baulig <martin@ximian.com>
17618 * rootcontext.cs (RootContext.LookupType): Don't cache things if
17619 we're doing a silent lookup. Don't try to lookup nested types in
17620 TypeManager.object_type (thanks to Ben Maurer).
17622 2004-05-30 Martin Baulig <martin@ximian.com>
17624 Committing a patch from Ben Maurer.
17626 * rootcontext.cs (RootContext.LookupType): Cache negative results.
17628 2004-05-29 Martin Baulig <martin@ximian.com>
17630 * class.cs (IMethodData.ShouldIgnore): New method.
17632 * typemanager.cs (TypeManager.MethodFlags): Don't take a
17633 `Location' argument, we don't need it anywhere. Use
17634 `IMethodData.ShouldIgnore ()' instead of
17635 `MethodData.GetMethodFlags ()'.
17636 (TypeManager.AddMethod): Removed.
17637 (TypeManager.AddMethod2): Renamed to AddMethod.
17639 2004-05-29 Martin Baulig <martin@ximian.com>
17641 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
17643 * convert.cs (Convert.ImplicitReferenceConversion): If we're
17644 converting from a class type S to an interface type and we already
17645 have an object on the stack, don't box it again. Fixes #52578.
17647 2004-05-29 Martin Baulig <martin@ximian.com>
17649 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17650 Added support for `params' parameters. Fixes #59267.
17652 2004-05-29 Martin Baulig <martin@ximian.com>
17654 * literal.cs (NullPointer): Provide a private .ctor which sets
17655 `type' to TypeManager.object_type. Fixes #59048.
17657 2004-05-29 Martin Baulig <martin@ximian.com>
17659 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
17660 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
17662 * ecore.cs (EventExpr.instance_expr): Make the field private.
17664 2004-05-26 Marek Safar <marek.safar@seznam.cz>
17666 Fixed bug #50080 & cs0214-2.cs
17667 * expression.cs (Cast.DoResolve): Check unsafe context here.
17669 * statement.cs (Resolve.DoResolve): Likewise.
17671 2004-05-26 Martin Baulig <martin@ximian.com>
17673 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
17675 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
17676 (RootContext.LookupType): Pass down the `silent' flag.
17678 2004-05-25 Martin Baulig <martin@ximian.com>
17681 (MethodGroupExpr.IdenticalTypeName): New public property.
17682 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
17683 expression actually refers to a type.
17685 2004-05-25 Martin Baulig <martin@ximian.com>
17687 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
17688 for #56176 and made it actually work.
17690 2004-05-25 Martin Baulig <martin@ximian.com>
17692 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
17693 (FieldExpr, PropertyExpr): Override and implement
17694 CacheTemporaries. Fixes #52279.
17696 2004-05-25 Miguel de Icaza <miguel@ximian.com>
17698 * location.cs: In the new compiler listing a file twice is a
17699 warning, not an error.
17701 2004-05-24 Martin Baulig <martin@ximian.com>
17703 * enum.cs (Enum.DefineType): For the `BaseType' to be a
17704 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
17706 2004-05-24 Martin Baulig <martin@ximian.com>
17708 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
17709 walking the `using' list. Fixes #53921.
17711 2004-05-24 Martin Baulig <martin@ximian.com>
17713 * const.cs (Const.LookupConstantValue): Added support for
17714 EmptyCast's; fixes #55251.
17716 2004-05-24 Martin Baulig <martin@ximian.com>
17718 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
17719 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
17720 which does the CS0135 check. The reason is that we first need to
17721 check whether the variable actually exists.
17723 2004-05-24 Martin Baulig <martin@ximian.com>
17725 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
17726 than RootContext.LookupType() to find the explicit interface
17727 type. Fixes #58584.
17729 2004-05-24 Raja R Harinath <rharinath@novell.com>
17731 * Makefile: Simplify. Use executable.make.
17732 * mcs.exe.sources: New file. List of sources of mcs.exe.
17734 2004-05-24 Anders Carlsson <andersca@gnome.org>
17738 Use the invariant culture when doing String.Compare for CLS case
17741 2004-05-23 Martin Baulig <martin@ximian.com>
17743 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
17744 don't have any dots. Fixes #52622, added cs0246-8.cs.
17746 * namespace.cs (NamespaceEntry.Lookup): Likewise.
17748 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17750 * class.cs (MemberBase.Define): Reuse MemberType member for
17751 resolved type. Other methods can use it too.
17753 2004-05-23 Martin Baulig <martin@ximian.com>
17755 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
17756 the variable also exists in the current block (otherwise, we need
17757 to report a CS0103). Fixes #58670.
17759 2004-05-23 Martin Baulig <martin@ximian.com>
17761 * flowanalysis.cs (Reachability.Reachable): Compute this
17762 on-the-fly rather than storing it as a field.
17764 2004-05-23 Martin Baulig <martin@ximian.com>
17766 * flowanalysis.cs (Reachability.And): Manually compute the
17767 resulting `barrier' from the reachability.
17769 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17772 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
17773 instance of ObsoleteAttribute when symbol is obsolete.
17776 (IMethodData): Extended interface for ObsoleteAttribute support.
17778 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17780 * attribute.cs: Fix bug #55970
17782 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17786 (GetObsoleteAttribute): New method. Creates the instance of
17788 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
17789 ObsoleteAttribute when member is obsolete.
17790 (AttributeTester.Report_ObsoleteMessage): Common method for
17791 Obsolete error/warning reporting.
17794 (TypeContainer.base_classs_type): New member for storing parent type.
17797 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
17798 for this MemberCore.
17800 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17802 * attribute.cs, const.cs: Fix bug #58590
17804 2004-05-21 Martin Baulig <martin@ximian.com>
17806 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
17807 out parameters if the end of the method is unreachable. Fixes
17810 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17812 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
17813 Hari was right, why extra method.
17815 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17817 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
17819 2004-05-20 Martin Baulig <martin@ximian.com>
17821 Merged this back from gmcs to keep the differences to a minumum.
17823 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
17824 instead of a Declspace.
17825 (Attribute.ResolveType): Likewise.
17826 (Attributes.Search): Likewise.
17827 (Attributes.Contains): Likewise.
17828 (Attributes.GetClsCompliantAttribute): Likewise.
17830 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
17832 (MethodData.ApplyAttributes): Take an EmitContext instead of a
17835 2004-05-19 Marek Safar <marek.safar@seznam.cz>
17837 Fix bug #58688 (MCS does not report error when the same attribute
17840 * attribute.cs (Attribute.Emit): Distinction between null and default.
17842 2004-05-19 Raja R Harinath <rharinath@novell.com>
17844 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
17845 of a top-level attribute without an attribute target.
17846 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
17848 (Attribute.Conditional_GetConditionName),
17849 (Attribute.Obsolete_GetObsoleteMessage): Update.
17850 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
17851 part of ScanForIndexerName.
17852 (Attribute.CanIgnoreInvalidAttribute): New function.
17853 (Attribute.ScanForIndexerName): Move to ...
17854 (Attributes.ScanForIndexerName): ... here.
17855 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
17856 (Attributes.Search): New internal variant that can choose not to
17857 complain if types aren't resolved. The original signature now
17859 (Attributes.GetClsCompliantAttribute): Use internal variant, with
17860 complaints suppressed.
17861 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
17862 only if it not useful.
17863 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
17864 top-level for attributes that are shared between the assembly
17865 and a top-level class.
17866 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
17867 * class.cs: Update to reflect changes.
17868 (DefineIndexers): Fuse loops.
17869 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
17870 a couple more variants of attribute names.
17872 2004-05-18 Marek Safar <marek.safar@seznam.cz>
17874 Fix bug #52585 (Implemented explicit attribute declaration)
17877 (Attributable.ValidAttributeTargets): New abstract method. It gets
17878 list of valid attribute targets for explicit target declaration.
17879 (Attribute.Target): It holds target itself.
17880 (AttributeSection): Removed.
17881 (Attribute.CheckTargets): New method. It checks whether attribute
17882 target is valid for the current element.
17885 (EventProperty): New class. For events that are declared like
17886 property (with add and remove accessors).
17887 (EventField): New class. For events that are declared like field.
17890 * cs-parser.jay: Implemented explicit attribute target declaration.
17892 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
17893 Override ValidAttributeTargets.
17896 (ReturnParameter): Class for applying custom attributes on
17898 (ParameterAtribute): New class. Class for applying custom
17899 attributes on the parameter type.
17901 2004-05-17 Miguel de Icaza <miguel@ximian.com>
17903 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
17906 (Method): Allow UNSAFE here.
17908 * modifiers.cs: Support unsafe reporting.
17910 2004-05-17 Marek Safar <marek.safar@seznam.cz>
17912 * decl.cs: Fix bug #58478.
17914 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17916 * statement.cs: When checking for unreachable code on an EmptyStatement,
17917 set the location. Fixes bug #58488.
17919 2004-05-13 Miguel de Icaza <miguel@ximian.com>
17921 * driver.cs: Add -pkg handling.
17923 From Gonzalo: UseShelLExecute=false
17925 2004-05-12 Marek Safar <marek.safar@seznam.cz>
17928 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
17930 (Attribute.IsClsCompliaceRequired): Moved to base for better
17932 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
17933 when attribute is AttributeUsageAttribute.
17934 (Attribute.GetValidTargets): Simplified.
17935 (Attribute.GetAttributeUsage): New method returns AttributeUsage
17936 attribute for this type.
17937 (Attribute.ApplyAttributes): Method renamed to Emit and make
17939 (GlobalAttributeSection): New class for special handling of global
17940 attributes (assembly, module).
17941 (AttributeSection.Emit): New method.
17943 * class.cs: Implemented Attributable abstract methods.
17944 (MethodCore.LabelParameters): Moved to Parameter class.
17945 (Accessor): Is back simple class.
17946 (PropertyMethod): Implemented Attributable abstract class.
17947 (DelegateMethod): Implemented Attributable abstract class.
17948 (Event): New constructor for disctintion between normal Event
17949 and Event with accessors.
17951 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
17953 * codegen.cs, const.cs, decl.cs, delegate.cs:
17954 (CommonAssemblyModulClass): Implemented Attributable abstract class
17957 * enum.cs: Implement IAttributeSupport interface.
17958 (EnumMember): New class for emum members. Implemented Attributable
17962 (ParameterBase): Is abstract.
17963 (ReturnParameter): New class for easier [return:] attribute handling.
17965 * typemanager.cs: Removed builder_to_attr.
17967 2004-05-11 Raja R Harinath <rharinath@novell.com>
17970 * attribute.cs (Attribute.GetPositionalValue): New function.
17971 * class.cs (TypeContainer.VerifyMembers): New function.
17972 (TypeContainer.Emit): Use it.
17973 (ClassOrStruct): New base class for Class and Struct.
17974 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
17975 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
17977 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
17978 then each non-static field should have a FieldOffset attribute.
17979 Otherwise, none of the fields should have a FieldOffset attribute.
17980 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
17981 and FieldOffset attributes.
17982 * typemanager.cs (TypeManager.struct_layout_attribute_type)
17983 (TypeManager.field_offset_attribute_type): New core types.
17984 (TypeManager.InitCoreTypes): Initialize them.
17986 2004-05-11 Michal Moskal <malekith@pld-linux.org>
17988 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
17989 Return correct type.
17992 2004-05-09 Miguel de Icaza <miguel@ximian.com>
17994 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
17995 be implicitly converted to ulong.
17997 * expression.cs: The logic for allowing operator &, | and ^ worked
17998 was wrong, it worked before because we did not report an error in
17999 an else branch. Fixes 57895.
18001 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18002 allow volatile fields to be reference types.
18004 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18006 * driver.cs: Add support for /debug-
18008 2004-05-07 Raja R Harinath <rharinath@novell.com>
18010 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18011 Add a 'complain' parameter to silence errors.
18012 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18013 silently overlooked type-resolutions.
18014 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18015 to reflect changes.
18016 (Attributes.Search): New function.
18017 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18018 (Attributes.GetAttributeFullName): Remove hack.
18019 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18020 Update to reflect changes.
18021 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18022 Use Attributes.Search instead of nested loops.
18024 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18027 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18028 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18029 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18031 * report.cs: (Report.Warning): Renamed to Warning_T because of
18032 parameter collision.
18034 2004-05-05 Raja R Harinath <rharinath@novell.com>
18036 * expression.cs (MemberAccess.ResolveMemberAccess):
18037 Exit with non-zero status after Report.Error.
18038 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18040 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18042 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18044 * support.cs: Don't hang when the file is empty.
18046 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18048 * support.cs: In SeekableStreamReader, compute the preamble size of the
18049 underlying stream. Position changes should take into account that initial
18052 2004-05-03 Todd Berman <tberman@sevenl.net>
18054 * driver.cs: remove unused GetSysVersion function.
18056 2004-05-03 Todd Berman <tberman@sevenl.net>
18058 * driver.cs: Remove the hack from saturday, as well as the hack
18059 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18060 link_paths to get that bit proper.
18062 2004-05-01 Todd Berman <tberman@sevenl.net>
18064 * driver.cs: Try a LoadFrom before a Load, this checks the current
18065 path. This is currently a bug in mono that is be fixed, however, this
18066 provides a workaround for now. This will be removed when the bug
18069 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18071 * CryptoConvert.cs: Updated to latest version. Fix issue with
18072 incomplete key pairs (#57941).
18074 2004-05-01 Todd Berman <tberman@sevenl.net>
18076 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18079 2004-04-30 Jackson Harper <jackson@ximian.com>
18081 * codegen.cs: Open keys readonly.
18083 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18085 * typemanager.cs: don't report cyclic struct layout when a struct
18086 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18087 which has 2 Pango.Rectangle fields.
18089 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18091 * expression.cs: Handle IntPtr comparisons with IL code
18092 rather than a method call.
18094 2004-04-29 Martin Baulig <martin@ximian.com>
18096 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18097 the list of PropertyInfo's in class hierarchy and find the
18098 accessor. Fixes #56013.
18100 2004-04-29 Martin Baulig <martin@ximian.com>
18102 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18104 2004-04-29 Martin Baulig <martin@ximian.com>
18106 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18108 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18110 2004-04-29 Martin Baulig <martin@ximian.com>
18112 * class.cs (ConstructorInitializer.Resolve): Check whether the
18113 parent .ctor is accessible. Fixes #52146.
18115 2004-04-29 Martin Baulig <martin@ximian.com>
18117 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18119 * statement.cs (Using.EmitLocalVariableDecls): Use
18120 TypeManager.idisposable_type, not typeof (IDisposable).
18121 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18123 2004-04-29 Martin Baulig <martin@ximian.com>
18125 * class.cs (Event.Define): Don't emit the field and don't set
18126 RTSpecialName and SpecialName for events on interfaces. Fixes
18129 2004-04-29 Raja R Harinath <rharinath@novell.com>
18131 Refactor Attribute.ApplyAttributes.
18132 * attribute.cs (Attributable): New base class for objects that can
18133 have Attributes applied on them.
18134 (Attribute): Make AttributeUsage fields public.
18135 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18136 (Attribute.IsInternalCall): New property.
18137 (Attribute.UsageAttr): Convert to a public read-only property.
18138 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18139 (Attribute.ResolveType, Attribute.Resolve)
18140 (Attribute.ScanForIndexerName): Update to reflect changes.
18141 (Attribute.CheckAttributeTarget): Re-format.
18142 (Attribute.ApplyAttributes): Refactor, to various
18143 Attributable.ApplyAttributeBuilder methods.
18144 * decl.cs (MemberCore): Make Attributable.
18145 * class.cs (Accessor): Make Attributable.
18146 (MethodData.ApplyAttributes): Use proper attribute types, not
18148 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18149 (TypeContainer.ApplyAttributeBuilder)
18150 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18151 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18152 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18153 (Operator.ApplyAttributeBuilder): New factored-out methods.
18154 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18155 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18156 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18157 * parameter.cs (ParameterBase): New Attributable base class
18158 that can also represent Return types.
18159 (Parameter): Update to the changes.
18161 2004-04-29 Jackson Harper <jackson@ximian.com>
18163 * driver.cs: Prefer the corlib system version when looking for
18164 assemblies in the GAC. This is still a hack, but its a better hack
18167 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18169 * decl.cs, enum.cs: Improved error 3005 reporting.
18171 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18172 (related_symbols): New private member for list of symbols
18173 related to reported error/warning.
18175 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18177 2004-04-29 Martin Baulig <martin@ximian.com>
18179 * ecore.cs (Expression.Constantify): If we're an enum and
18180 TypeManager.TypeToCoreType() doesn't give us another type, use
18181 t.UnderlyingSystemType. Fixes #56178.
18183 2004-04-29 Martin Baulig <martin@ximian.com>
18185 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18186 interfaces and for each interface, only add members directly
18187 declared in that interface. Fixes #53255.
18189 2004-04-28 Martin Baulig <martin@ximian.com>
18191 * expression.cs (ConditionalLogicalOperator): Use a temporary
18192 variable for `left' to avoid that we evaluate it more than once;
18195 2004-04-28 Martin Baulig <martin@ximian.com>
18197 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18200 2004-04-28 Martin Baulig <martin@ximian.com>
18202 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18205 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18206 whether the type is not void (CS1547).
18208 2004-04-28 Martin Baulig <martin@ximian.com>
18210 * expression.cs (Unary.DoResolveLValue): Override this and report
18211 CS0131 for anything but Operator.Indirection.
18213 2004-04-28 Martin Baulig <martin@ximian.com>
18215 Committing a patch from Ben Maurer; see bug #50820.
18217 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18220 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18223 2004-04-28 Martin Baulig <martin@ximian.com>
18225 Committing a patch from Ben Maurer; see bug #50820.
18227 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18230 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18233 2004-04-28 Martin Baulig <martin@ximian.com>
18235 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18236 (Block.AddLabel): Call DoLookupLabel() to only search in the
18239 2004-04-28 Martin Baulig <martin@ximian.com>
18241 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18242 comparing StringConstants and NullLiterals in Equality and Inequality.
18244 2004-04-28 Jackson Harper <jackson@ximian.com>
18246 * driver.cs: Attempt to load referenced assemblies from the
18247 GAC. This is the quick and dirty version of this method that
18248 doesnt take into account versions and just takes the first
18249 canidate found. Will be good enough for now as we will not have more
18250 then one version installed into the GAC until I update this method.
18252 2004-04-28 Martin Baulig <martin@ximian.com>
18254 * typemanager.cs (TypeManager.CheckStructCycles): New public
18255 static method to check for cycles in the struct layout.
18257 * rootcontext.cs (RootContext.PopulateTypes): Call
18258 TypeManager.CheckStructCycles() for each TypeContainer.
18259 [Note: We only need to visit each type once.]
18261 2004-04-28 Martin Baulig <martin@ximian.com>
18263 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18265 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18266 success and added `out object value'. Use a `bool resolved' field
18267 to check whether we've already been called rather than
18268 `ConstantValue != null' since this breaks for NullLiterals.
18270 2004-04-28 Raja R Harinath <rharinath@novell.com>
18272 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18273 setting of this flag, since the 'set' method may be non-public.
18275 2004-04-28 Raja R Harinath <rharinath@novell.com>
18277 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18278 check on current_vector.Block.
18280 2004-04-27 Martin Baulig <martin@ximian.com>
18282 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18283 a field initializer. Fixes #56459.
18285 2004-04-27 Martin Baulig <martin@ximian.com>
18287 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18288 we're not attempting to use an indexer. Fixes #52154.
18290 2004-04-27 Martin Baulig <martin@ximian.com>
18292 * statement.cs (Return): Don't create a return label if we don't
18293 need it; reverts my change from January 20th. Thanks to Ben
18296 2004-04-27 Martin Baulig <martin@ximian.com>
18298 According to the spec, `goto' can only leave a nested scope, but
18301 * statement.cs (Block.LookupLabel): Only lookup in the current
18302 block, don't recurse into parent or child blocks.
18303 (Block.AddLabel): Check in parent and child blocks, report
18304 CS0140/CS0158 if we find a duplicate.
18305 (Block): Removed this indexer for label lookups.
18306 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18307 this already does the error reporting for us.
18310 (FlowBranching.UsageVector.Block): New public variable; may be null.
18311 (FlowBranching.CreateSibling): Added `Block' argument.
18312 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18313 label for the target of a `goto' and check whether we're not
18314 leaving a `finally'.
18316 2004-04-27 Martin Baulig <martin@ximian.com>
18318 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18319 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18322 2004-04-27 Martin Baulig <martin@ximian.com>
18324 * statement.cs (Block.AddLabel): Also check for implicit blocks
18325 and added a CS0158 check.
18327 2004-04-27 Martin Baulig <martin@ximian.com>
18329 * flowanalysis.cs (FlowBranchingLoop): New class.
18330 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18331 UsageVector's instead of an ArrayList.
18332 (FlowBranching.Label): Likewise.
18333 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18334 (FlowBranching.AddBreakVector): New method.
18336 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18338 * attribute.cs: Small regression fix: only convert the type if we
18339 the type is different, fixes System.Drawing build.
18341 2004-04-27 Martin Baulig <martin@ximian.com>
18343 * attribute.cs (Attribute.Resolve): If we have a constant value
18344 for a named field or property, implicity convert it to the correct
18347 2004-04-27 Raja R Harinath <rharinath@novell.com>
18349 * statement.cs (Block.Block): Implicit blocks share
18350 'child_variable_names' fields with parent blocks.
18351 (Block.AddChildVariableNames): Remove.
18352 (Block.AddVariable): Mark variable as "used by a child block" in
18353 every surrounding block.
18354 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18355 been used in a child block, complain about violation of "Invariant
18356 meaning in blocks" rule.
18357 * cs-parser.jay (declare_local_variables): Don't use
18358 AddChildVariableNames.
18359 (foreach_statement): Don't create an implicit block: 'foreach'
18360 introduces a scope.
18362 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18364 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18365 converting from 0L to ulong. Fixes 57522.
18367 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18369 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18370 derived class hides via 'new' keyword field from base class (test-242.cs).
18371 TODO: Handle this in the more general way.
18373 * class.cs (CheckBase): Ditto.
18375 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18377 * decl.cs (caching_flags): New member for storing cached values
18379 (MemberCore.Flags): New enum where bit flags for caching_flags
18381 (MemberCore.cls_compliance): Moved to caching_flags.
18382 (DeclSpace.Created): Moved to caching_flags.
18384 * class.cs: Use caching_flags instead of DeclSpace.Created
18386 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18388 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18389 if we are only a derived class, not a nested class.
18391 * typemanager.cs: Same as above, but do this at the MemberLookup
18392 level (used by field and methods, properties are handled in
18393 PropertyExpr). Allow for the qualified access if we are a nested
18396 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18398 * class.cs: Refactoring.
18399 (IMethodData): New inteface; Holds links to parent members
18400 to avoid member duplication (reduced memory allocation).
18401 (Method): Implemented IMethodData interface.
18402 (PropertyBase): New inner classes for get/set methods.
18403 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18404 (Event): New inner classes for add/remove methods.
18405 (Event.DelegateMethod): Implemented IMethodData interface.
18407 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18408 EmitContext (related to class.cs refactoring).
18410 2004-04-21 Raja R Harinath <rharinath@novell.com>
18412 * delegate.cs (Delegate.VerifyApplicability): If the number of
18413 arguments are the same as the number of parameters, first try to
18414 verify applicability ignoring any 'params' modifier on the last
18418 2004-04-16 Raja R Harinath <rharinath@novell.com>
18420 * class.cs (TypeContainer.AddIndexer): Use
18421 'ExplicitInterfaceName' to determine if interface name was
18422 explicitly specified. 'InterfaceType' is not initialized at this time.
18423 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18424 Indexers array is already in the required order. Initialize
18425 'IndexerName' only if there are normal indexers.
18426 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18427 (TypeContainer.Emit): Emit DefaultMember attribute only if
18428 IndexerName is initialized.
18431 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18433 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18436 2004-04-15 Raja R Harinath <rharinath@novell.com>
18438 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18442 * attribute.cs (Attribute.Resolve): Check for duplicate named
18446 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18448 * iterators.cs (MarkYield): track whether we are in an exception,
18449 and generate code accordingly. Use a temporary value to store the
18450 result for our state.
18452 I had ignored a bit the interaction of try/catch with iterators
18453 since their behavior was not entirely obvious, but now it is
18454 possible to verify that our behavior is the same as MS .NET 2.0
18458 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18460 * iterators.cs: Avoid creating temporaries if there is no work to
18463 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18464 Enumerations, use TypeManager.EnumToUnderlying and call
18467 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18470 (This.Emit): Use EmitContext.EmitThis to emit our
18473 (This.EmitAssign): Ditto.
18475 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18476 codepaths, we will move all the functionality into
18479 (FieldExpr.EmitAssign): Ditto.
18481 This fixes several hidden bugs that I uncovered while doing a code
18482 review of this today.
18484 * codegen.cs (EmitThis): reworked so the semantics are more clear
18485 and also support value types "this" instances.
18487 * iterators.cs: Changed so that for iterators in value types, we
18488 do not pass the value type as a parameter.
18490 Initialization of the enumerator helpers is now done in the caller
18491 instead of passing the parameters to the constructors and having
18492 the constructor set the fields.
18494 The fields have now `assembly' visibility instead of private.
18496 2004-04-11 Miguel de Icaza <miguel@ximian.com>
18498 * expression.cs (Argument.Resolve): Check if fields passed as ref
18499 or out are contained in a MarshalByRefObject.
18501 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
18502 another compiler type.
18504 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
18506 * class.cs (Indexer.Define): use the new name checking method.
18507 Also, return false on an error.
18508 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
18509 (is_identifier_[start/part]_character): make static.
18511 2004-04-10 Miguel de Icaza <miguel@ximian.com>
18513 * expression.cs (Binary.ResolveOperator): Do no append strings
18514 twice: since we can be invoked more than once (array evaluation)
18515 on the same concatenation, take care of this here. Based on a fix
18516 from Ben (bug #56454)
18518 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
18520 * codegen.cs: Fix another case where CS1548 must be reported (when
18521 delay-sign isn't specified and no private is available #56564). Fix
18522 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
18523 error when MCS is used on the MS runtime and we need to delay-sign
18524 (which seems unsupported by AssemblyBuilder - see #56621).
18526 2004-04-08 Marek Safar <marek.safar@seznam.cz>
18528 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
18529 (TypeManager.ComputeNamespaces): Faster implementation for
18532 * compiler.csproj: Updated AssemblyName to mcs.
18534 2004-04-07 Miguel de Icaza <miguel@ximian.com>
18536 * rootcontext.cs: Add new types to the boot resolution.
18538 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
18539 MulticastDelegate is not allowed.
18541 * typemanager.cs: Add new types to lookup: System.TypedReference
18544 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
18545 check for TypedReference or ArgIterator, they are not allowed.
18547 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
18548 makes us properly catch 1510 in some conditions (see bug 56016 for
18551 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
18553 * CryptoConvert.cs: update from corlib version
18556 2004-04-05 Miguel de Icaza <miguel@ximian.com>
18558 * class.cs (Indexer.Define): Check indexername declaration
18560 2004-04-05 Marek Safar <marek.safar@seznam.cz>
18562 * attribute.cs (IsClsCompliant): Fixed problem with handling
18563 all three states (compliant, not-compliant, undetected).
18565 2004-03-30 Marek Safar <marek.safar@seznam.cz>
18567 * attribute.cs (Attribute): Location is now public.
18568 (Resolve): Store resolved arguments (pos_values) in attribute class.
18569 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
18570 (GetClsCompliantAttributeValue): New method that gets
18571 CLSCompliantAttribute value.
18572 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
18573 if exists else null.
18574 (AttributeTester): New class for CLS-Compliant verification routines.
18576 * class.cs (Emit): Add CLS-Compliant verification.
18577 (Method.GetSignatureForError): Implemented.
18578 (Constructor.GetSignatureForError): Implemented
18579 (Constructor.HasCompliantArgs): Returns if constructor has
18580 CLS-Compliant arguments.
18581 (Constructor.Emit): Override.
18582 (Construcor.IsIdentifierClsCompliant): New method; For constructors
18583 is needed to test only parameters.
18584 (FieldBase.GetSignatureForError): Implemented.
18585 (TypeContainer): New member for storing base interfaces.
18586 (TypeContainer.FindMembers): Search in base interfaces too.
18588 * codegen.cs (GetClsComplianceAttribute): New method that gets
18589 assembly or module CLSCompliantAttribute value.
18590 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
18592 (ModuleClass.Emit): Add error 3012 test.
18594 * const.cs (Emit): Override and call base for CLS-Compliant tests.
18596 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
18597 state for all decl types.
18598 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
18599 if CLS-Compliant tests are required.
18600 (IsClsCompliaceRequired): New method. Analyze whether code
18601 must be CLS-Compliant.
18602 (IsExposedFromAssembly): New method. Returns true when MemberCore
18603 is exposed from assembly.
18604 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
18605 value or gets cached value.
18606 (HasClsCompliantAttribute): New method. Returns true if MemberCore
18607 is explicitly marked with CLSCompliantAttribute.
18608 (IsIdentifierClsCompliant): New abstract method. This method is
18609 used to testing error 3005.
18610 (IsIdentifierAndParamClsCompliant): New method. Common helper method
18611 for identifier and parameters CLS-Compliant testing.
18612 (VerifyClsCompliance): New method. The main virtual method for
18613 CLS-Compliant verifications.
18614 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
18615 null. I don't know why is null (too many public members !).
18616 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
18617 and get value of first CLSCompliantAttribute that found.
18619 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
18620 (VerifyClsCompliance): Override and add extra tests.
18622 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
18623 clscheck- disable CLS-Compliant verification event if assembly is has
18624 CLSCompliantAttribute(true).
18626 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
18627 ApllyAttribute is now called in emit section as in the other cases.
18628 Possible future Emit integration.
18629 (IsIdentifierClsCompliant): New override.
18630 (VerifyClsCompliance): New override.
18631 (GetEnumeratorName): Returns full enum name.
18633 * parameter.cs (GetSignatureForError): Implemented.
18635 * report.cs (WarningData): New struct for Warning message information.
18636 (LocationOfPreviousError): New method.
18637 (Warning): New method. Reports warning based on the warning table.
18638 (Error_T): New method. Reports error based on the error table.
18640 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
18641 verifications are done here.
18643 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
18645 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
18646 CLSCompliantAttribute.
18647 (all_imported_types): New member holds all imported types from other
18649 (LoadAllImportedTypes): New method fills static table with exported types
18650 from all referenced assemblies.
18651 (Modules): New property returns all assembly modules.
18653 2004-03-30 Miguel de Icaza <miguel@ximian.com>
18655 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
18656 throwing a parser error.
18658 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
18659 which removes the hardcoded get_/set_ prefixes for properties, as
18660 IL allows for the properties to be named something else.
18664 * expression.cs: Do not override operand before we know if it is
18665 non-null. Fix 56207
18667 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18669 * typemanager.cs: support for pinned variables.
18671 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18673 * decl.cs, typemanager.cs: Avoid using an arraylist
18674 as a buffer if there is only one result set.
18676 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18678 * expression.cs: Make sure you cant call a static method
18679 with an instance expression, bug #56174.
18681 2004-03-29 Miguel de Icaza <miguel@ximian.com>
18683 * class.cs (IsDuplicateImplementation): Improve error reporting to
18684 flag 663 (method only differs in parameter modifier).
18686 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
18687 in preprocessor directives.
18689 * location.cs (LookupFile): Allow for the empty path.
18691 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
18692 better approach for some of that patch, but its failing with the
18693 CharSet enumeration. For now try/catch will do.
18695 * typemanager.cs: Do not crash if a struct does not have fields.
18698 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18700 * expression.cs: cs0213, cant fix a fixed expression.
18703 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18705 * cs-parser.jay: detect invalid embeded statements gracefully.
18708 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18710 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
18713 the invocation type may not be a subclass of the tye of the item/
18714 The type of the item must be a subclass of the invocation item.
18719 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
18721 * attribute.cs: Added methods to get a string and a bool from an
18722 attribute. Required to information from AssemblyKeyFileAttribute,
18723 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
18724 * codegen.cs: Modified AssemblyName creation to include support for
18725 strongnames. Catch additional exceptions to report them as CS1548.
18726 * compiler.csproj: Updated include CryptoConvert.cs.
18727 * compiler.csproj.user: Removed file - user specific configuration.
18728 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
18729 Mono.Security assembly. The original class is maintained and tested in
18730 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
18731 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
18732 like CSC 8.0 (C# v2) supports.
18733 * Makefile: Added CryptoConvert.cs to mcs sources.
18734 * rootcontext.cs: Added new options for strongnames.
18736 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
18738 * driver.cs: For --expect-error, report error code `2'
18739 if the program compiled with no errors, error code `1' if
18740 it compiled with an error other than the one expected.
18742 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
18744 * compiler.csproj: Updated for Visual Studio .NET 2003.
18745 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
18746 * compiler.sln: Updated for Visual Studio .NET 2003.
18748 2004-03-24 Ravi Pratap M <ravi@ximian.com>
18750 * expression.cs: Fix bug #47234. We basically need to apply the
18751 rule that we prefer the conversion of null to a reference type
18752 when faced with a conversion to 'object' (csc behaviour).
18754 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18756 * statement.cs: Shorter form for foreach, eliminates
18757 a local variable. r=Martin.
18759 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18761 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
18762 checks if we can use brtrue/brfalse to test for 0.
18763 * expression.cs: use the above in the test for using brtrue/brfalse.
18764 cleanup code a bit.
18766 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18768 * expression.cs: Rewrite string concat stuff. Benefits:
18770 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
18771 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
18772 rather than a concat chain.
18774 * typemanager.cs: Add lookups for more concat overloads.
18776 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18778 * expression.cs: Emit shorter il code for array init.
18795 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
18797 * statement.cs: Before, two switch blocks would be merged if the
18798 total size of the blocks (end_item - begin_item + 1) was less than
18799 two times the combined sizes of the blocks.
18801 Now, it will only merge if after the merge at least half of the
18806 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
18808 * class.cs : csc build fix for GetMethods(). See bug #52503.
18810 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
18812 * expression.cs: Make sure fp comparisons work with NaN.
18813 This fixes bug #54303. Mig approved this patch a long
18814 time ago, but we were not able to test b/c the runtime
18817 2004-03-19 Miguel de Icaza <miguel@ximian.com>
18819 * ecore.cs (TypExpr.GetHashCode): implement this overload.
18821 2004-03-19 Martin Baulig <martin@ximian.com>
18823 * class.cs (MemberCore.IsDuplicateImplementation): Report the
18824 error here and not in our caller.
18826 2004-03-19 Martin Baulig <martin@ximian.com>
18828 * interface.cs: Completely killed this file.
18829 (Interface): We're now a TypeContainer and live in class.cs.
18831 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
18832 argument; we're now also called for interfaces.
18833 (TypeContainer.DefineMembers): Allow this method being called
18835 (TypeContainer.GetMethods): New public method; formerly known as
18836 Interface.GetMethod(). This is used by PendingImplementation.
18837 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
18838 it's now private and non-static.
18839 (Interface): Moved this here; it's now implemented similar to
18841 (Method, Property, Event, Indexer): Added `bool is_interface'
18842 argument to their .ctor's.
18843 (MemberBase.IsInterface): New public field.
18845 * cs-parser.jay: Create normal Method, Property, Event, Indexer
18846 instances instead of InterfaceMethod, InterfaceProperty, etc.
18847 (opt_interface_base): Removed; we now use `opt_class_base' instead.
18848 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
18850 2004-03-19 Martin Baulig <martin@ximian.com>
18852 * class.cs (MethodCore.IsDuplicateImplementation): New private
18853 method which does the CS0111 checking.
18854 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
18855 Use IsDuplicateImplementation().
18857 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
18859 * decl.cs (FindMemberToOverride): New method to find the correct
18860 method or property to override in the base class.
18862 - Make Method/Property use the above method to find the
18863 version in the base class.
18864 - Remove the InheritableMemberSignatureCompare as it is now
18867 This patch makes large code bases much faster to compile, as it is
18868 O(n) rather than O(n^2) to do this validation.
18870 Also, it fixes bug 52458 which is that nested classes are not
18871 taken into account when finding the base class member.
18873 Reviewed/Approved by Martin.
18875 2004-03-17 Marek Safar <marek.safar@seznam.cz>
18877 * interface.cs: In all interface classes removed redundant
18878 member initialization.
18880 2004-03-16 Martin Baulig <martin@ximian.com>
18882 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
18884 2004-03-15 Miguel de Icaza <miguel@ximian.com>
18886 * decl.cs (DefineTypeAndParents): New helper method to define a
18887 type's containers before the type itself is defined; This is a
18888 bug exposed by the recent changes to Windows.Forms when an
18889 implemented interface was defined inside a class that had not been
18892 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
18894 (Check): Loop correctly to report errors modifiers
18895 (UNSAFE was not in the loop, since it was the same as TOP).
18897 * interface.cs: Every interface member now takes a ModFlags,
18898 instead of a "is_new" bool, which we set on the base MemberCore.
18900 Every place where we called "UnsafeOk" in the interface, now we
18901 call the proper member (InterfaceMethod.UnsafeOK) instead to get
18902 the unsafe settings from the member declaration instead of the
18903 container interface.
18905 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
18907 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
18908 `set_indexer_name' to the pending bits (one per type).
18910 We fixed a bug today that was picking the wrong method to
18911 override, since for properties the existing InterfaceMethod code
18912 basically ignored the method name. Now we make sure that the
18913 method name is one of the valid indexer names.
18915 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
18917 * support.cs (SeekableStreamReader): Keep track of stream byte
18918 positions and don't mix them with character offsets to the buffer.
18920 Patch from Gustavo Giráldez
18922 2004-03-15 Marek Safar <marek.safar@seznam.cz>
18924 * interface.cs (InterfaceSetGetBase): Removed double member
18925 initialization, base class does it as well.
18927 2004-03-13 Martin Baulig <martin@ximian.com>
18929 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
18930 when compiling corlib.
18932 2004-03-13 Miguel de Icaza <miguel@ximian.com>
18934 * convert.cs (ExplicitConversion): We were reporting an error on
18935 certain conversions (object_type source to a value type, when the
18936 expression was `null') before we had a chance to pass it through
18937 the user defined conversions.
18939 * driver.cs: Replace / and \ in resource specifications to dots.
18942 * class.cs: Add check for duplicate operators. Fixes 52477
18944 2004-03-11 Miguel de Icaza <miguel@ximian.com>
18946 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
18947 that are in the middle of the statements, not only at the end.
18950 * class.cs (TypeContainer.AddField): No longer set the
18951 `HaveStaticConstructor' flag, now we call it
18952 `UserDefineStaticConstructor' to diferentiate the slightly
18953 semantic difference.
18955 The situation is that we were not adding BeforeFieldInit (from
18956 Modifiers.TypeAttr) to classes that could have it.
18957 BeforeFieldInit should be set to classes that have no static
18962 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
18964 And most importantly Zoltan's comment:
18966 http://bugzilla.ximian.com/show_bug.cgi?id=44229
18968 "I think beforefieldinit means 'it's ok to initialize the type sometime
18969 before its static fields are used', i.e. initialization does not need
18970 to be triggered by the first access to the type. Setting this flag
18971 helps the JIT to compile better code, since it can run the static
18972 constructor at JIT time, and does not need to generate code to call it
18973 (possibly lots of times) at runtime. Unfortunately, mcs does not set
18974 this flag for lots of classes like String.
18976 csc sets this flag if the type does not have an explicit static
18977 constructor. The reasoning seems to be that if there are only static
18978 initalizers for a type, and no static constructor, then the programmer
18979 does not care when this initialization happens, so beforefieldinit
18982 This bug prevents the AOT compiler from being usable, since it
18983 generates so many calls to mono_runtime_class_init that the AOT code
18984 is much slower than the JITted code. The JITted code is faster,
18985 because it does not generate these calls if the vtable is type is
18986 already initialized, which is true in the majority of cases. But the
18987 AOT compiler can't do this."
18989 2004-03-10 Miguel de Icaza <miguel@ximian.com>
18991 * class.cs (MethodData.Emit): Refactor the code so symbolic
18992 information is generated for destructors; For some reasons we
18993 were taking a code path that did not generate symbolic information
18996 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
18998 * class.cs: Create a Constructor.CheckBase method that
18999 takes care of all validation type code. The method
19000 contains some code that was moved from Define.
19002 It also includes new code that checks for duplicate ctors.
19003 This fixes bug #55148.
19005 2004-03-09 Joshua Tauberer <tauberer@for.net>
19007 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19008 a { ... }-style array creation invokes EmitStaticInitializers
19009 which is not good for reference-type arrays. String, decimal
19010 and now null constants (NullCast) are not counted toward
19011 static initializers.
19013 2004-03-05 Martin Baulig <martin@ximian.com>
19015 * location.cs (SourceFile.HasLineDirective): New public field;
19016 specifies whether the file contains or is referenced by a "#line"
19018 (Location.DefineSymbolDocuments): Ignore source files which
19019 either contain or are referenced by a "#line" directive.
19021 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19023 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19024 direct access to our parent, so check the method inline there.
19026 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19028 * expression.cs (Invocation.EmitCall): Miguel's last commit
19029 caused a regression. If you had:
19034 In Foo the implict this would be null.
19036 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19038 * expression.cs (Invocation.EmitCall): If the method is not
19039 virtual, do not emit a CallVirt to it, use Call.
19041 * typemanager.cs (GetFullNameSignature): Improve the method to
19042 cope with ".ctor" and replace it with the type name.
19044 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19045 as an argument the ConstructorBuilder where it is being defined,
19046 to catch the recursive constructor invocations.
19048 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19050 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19051 routines to check if a type is an enumerable/enumerator allow
19052 classes that implement the IEnumerable or IEnumerator interfaces.
19054 * class.cs (Property, Operator): Implement IIteratorContainer, and
19055 implement SetYields.
19057 (Property.Define): Do the block swapping for get_methods in the
19058 context of iterators. We need to check if Properties also
19059 include indexers or not.
19061 (Operator): Assign the Block before invoking the
19062 OperatorMethod.Define, so we can trigger the Iterator code
19065 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19066 Property and Operator classes are not created when we parse the
19067 declarator but until we have the block completed, so we use a
19068 singleton SimpleIteratorContainer.Simple to flag whether the
19069 SetYields has been invoked.
19071 We propagate this setting then to the Property or the Operator to
19072 allow the `yield' to function.
19074 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19076 * codegen.cs: Implemented attribute support for modules.
19077 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19078 Assembly/Module functionality.
19080 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19081 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19082 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19084 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19086 * interface.cs (FindMembers): The operation is performed on all base
19087 interfaces and not only on the first. It is required for future CLS Compliance patch.
19089 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19091 * statement.cs, codegen.cs:
19092 This patch deals with patterns such as:
19094 public class List : IEnumerable {
19096 public MyEnumerator GetEnumerator () {
19097 return new MyEnumerator(this);
19100 IEnumerator IEnumerable.GetEnumerator () {
19104 public struct MyEnumerator : IEnumerator {
19109 Before, there were a few things we did wrong:
19110 1) we would emit callvirt on a struct, which is illegal
19111 2) we emited ldarg when we needed to emit ldarga
19112 3) we would mistakenly call the interface methods on an enumerator
19113 type that derived from IEnumerator and was in another assembly. For example:
19115 public class MyEnumerator : IEnumerator
19117 Would have the interface methods called, even if there were public impls of the
19118 method. In a struct, this lead to invalid IL code.
19120 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19122 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19125 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19127 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19129 * cs-parser.jay: Fix small regression: we were not testing V2
19130 compiler features correctly.
19132 * interface.cs: If the emit context is null, then create one
19134 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19136 * decl.cs (GetSignatureForError): New virtual method to get full name
19137 for error messages.
19139 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19140 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19142 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19143 Duplicated members and code in these classes has been removed.
19144 Better encapsulation in these classes.
19146 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19148 * assign.cs (Assign.DoResolve): When dealing with compound
19149 assignments, there is a new rule in ECMA C# 2.4 (might have been
19150 there before, but it is documented here) that states that in:
19154 If b is of type int, and the `op' is a shift-operator, then the
19155 above is evaluated as:
19159 * expression.cs (Binary.ResolveOperator): Instead of testing for
19160 int/uint/long/ulong, try to implicitly convert to any of those
19161 types and use that in pointer arithmetic.
19163 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19164 method to print information for from the type, not from the
19165 null-method we were given.
19167 2004-02-01 Duncan Mak <duncan@ximian.com>
19169 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19170 parsing for cmd, fixes bug #53694.
19172 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19174 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19175 in the member name duplication tests. Property and operator name duplication
19176 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19178 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19180 * interface.cs (PopulateMethod): Fixed crash when interface method
19181 returns not existing type (error test cs0246-3.cs).
19183 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19185 * cs-parser.jay (interface_accessors): Re-write actions to also
19186 store attributes attached to get and set methods. Fix spelling
19189 (inteface_property_declaration): Modify accordingly.
19191 (InterfaceAccessorInfo): New helper class to store information to pass
19192 around between rules that use interface_accessors.
19194 * interface.cs (Emit): Apply attributes on the get and set
19195 accessors of properties and indexers too.
19197 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19198 right MethodBuilder when applying attributes to the get and set accessors.
19200 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19202 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19204 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19206 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19208 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19210 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19211 changes that treat `yield' specially when present before `break'
19212 or `return' tokens.
19214 * cs-tokenizer.cs: yield is no longer a keyword.
19216 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19218 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19219 setting for default constructors.
19220 For default constructors are almost every time set wrong Modifier. The
19221 generated IL code has been alright. But inside mcs this values was
19222 wrong and this was reason why several of my CLS Compliance tests
19225 2004-01-22 Martin Baulig <martin@ximian.com>
19227 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19228 not a QualifiedIdentifier. This is what `type_name_expression'
19229 was previously doing.
19230 (type_name_expression): Removed; the code is now in
19231 `namespace_or_type_name'.
19232 (qualified_identifier): Removed, use `namespace_or_type_name'
19234 (QualifiedIdentifier): Removed this class.
19236 2004-01-22 Martin Baulig <martin@ximian.com>
19238 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19239 not a string as alias name.
19241 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19243 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19244 #52730 bug, and instead compute correctly the need to use a
19245 temporary variable when requesting an address based on the
19246 static/instace modified of the field and the constructor.
19248 2004-01-21 Martin Baulig <martin@ximian.com>
19250 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19251 class and namespace before looking up aliases. Fixes #52517.
19253 2004-01-21 Martin Baulig <martin@ximian.com>
19255 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19256 assinged in a 'try'; fixes exception4.cs.
19258 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19259 * class.cs : Implemented parameter-less constructor for TypeContainer
19261 * decl.cs: Attributes are now stored here. New property OptAttributes
19263 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19265 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19267 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19269 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19270 (CSharpSignature): New method for indexer and property signature.
19272 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19274 * pending.cs (IsVirtualFilter): Faster implementation.
19276 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19278 * typemanager.cs: Avoid inclusion of same assembly more than once.
19280 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19282 * cs-parser.jay: Fixed problem where the last assembly attribute
19283 has been applied also to following declaration (class, struct, etc.)
19285 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19287 * class.cs: Added error CS0538, CS0539 reporting.
19288 Fixed crash on Microsoft runtime when field type is void.
19290 * cs-parser.jay: Added error CS0537 reporting.
19292 * pending.cs: Added error CS0535 reporting.
19293 Improved error report for errors CS0536, CS0534.
19295 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19297 Merge a few bits from the Anonymous Method MCS tree.
19299 * statement.cs (ToplevelBlock): New class for toplevel methods,
19300 will hold anonymous methods, lifted variables.
19302 * cs-parser.jay: Create toplevel blocks for delegates and for
19303 regular blocks of code.
19305 2004-01-20 Martin Baulig <martin@ximian.com>
19307 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19308 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19309 and `NeedExplicitReturn'; added `IsLastStatement'.
19310 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19311 have a `ReturnLabel' or we're not unreachable.
19313 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19314 child's reachability; don't just override ours with it. Fixes
19315 #58058 (lluis's example).
19316 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19317 InFinally(), InLoop(), InSwitch() and
19318 BreakCrossesTryCatchBoundary() methods.
19320 * statement.cs (Return): Do all error checking in Resolve().
19321 Unless we are the last statement in a top-level block, always
19322 create a return label and jump to it.
19323 (Break, Continue): Do all error checking in Resolve(); also make
19324 sure we aren't leaving a `finally'.
19325 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19326 statement in a top-level block.
19327 (Block.Flags): Added `IsDestructor'.
19328 (Block.IsDestructor): New public property.
19330 2004-01-20 Martin Baulig <martin@ximian.com>
19332 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19334 2004-01-20 Martin Baulig <martin@ximian.com>
19336 * statement.cs (Statement.ResolveUnreachable): New public method.
19337 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19338 (Block.Resolve): Resolve unreachable statements.
19340 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19342 * expression.cs: We need to fix the case where we do
19343 not have a temp variable here.
19345 * assign.cs: Only expression compound assignments need
19346 temporary variables.
19348 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19350 * flowanalysis.cs: Reduce memory allocation in a few ways:
19351 - A block with no variables should not allocate a bit
19353 - A method with no out parameters does not need any tracking
19354 for assignment of the parameters, so we need not allocate
19357 public readonly Type[] VariableTypes;
19358 public readonly string[] VariableNames;
19359 Are redundant. The data is already stored in the variable
19360 map, so we need not allocate another array for it.
19361 - We need to add alot of checks for if (params | locals) == null
19362 due to the first two changes.
19364 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19366 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19367 implement IMemoryLocation, we store a copy on a local variable and
19368 take the address of it. Patch from Benjamin Jemlich
19370 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19371 to use a special "type_name_expression" rule which reduces the
19372 number of "QualifiedIdentifier" classes created, and instead
19373 directly creates MemberAccess expressions.
19375 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19377 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19378 that fixes #52853. Null literal assignment to ValueType
19380 * class.cs (MethodData.Emit): Instead of checking the name of the
19381 method to determine if its a destructor, create a new derived
19382 class from Method called Destructor, and test for that.
19384 * cs-parser.jay: Create a Destructor object instead of a Method.
19386 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19390 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19392 * expression.cs (Binary.ResolveOperator): Perform an implicit
19393 conversion from MethodGroups to their delegate types on the
19394 Addition operation.
19396 * delegate.cs: Introduce a new class DelegateCreation that is the
19397 base class for `NewDelegate' and `ImplicitDelegateCreation',
19398 factor some code in here.
19400 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19401 conversion from MethodGroups to compatible delegate types.
19403 * ecore.cs (Expression.Resolve): Do not flag error 654
19404 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19405 we allow conversions from MethodGroups to delegate types now.
19407 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19408 assignments in v2 either.
19410 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19412 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19413 static read-only fields in ctors.
19415 Applied patch from Benjamin Jemlich
19417 * expression.cs (UnaryMutator): Avoid leaking local variables.
19419 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19421 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19422 here to return true, as they can be used like this:
19424 (XXX) int.MEMBER ()
19426 Fixed 49836 and all the other dups
19428 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19430 * driver.cs: Implement /win32res and /win32icon.
19432 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19434 * cs-parser.jay: Add a rule to improve error handling for the
19435 common mistake of placing modifiers after the type.
19437 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19439 * cs-parser.jay (interface_event_declaration): Catch
19440 initialization of events on interfaces, and report cs0068
19442 * cs-parser.jay (interface_event_declaration): Catch
19443 initialization of events.
19445 * ecore.cs: Better report missing constructors.
19447 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19448 the error reporting done in the wrong place. Fix.
19450 * expression.cs (Binary.ResolveOperator): Catch the
19451 operator + (E x, E y) error earlier, and later allow for implicit
19452 conversions in operator +/- (E e, U x) from U to the underlying
19455 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19456 52596, if the container class is abstract, the default constructor
19457 is protected otherwise its public (before, we were always public).
19459 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19462 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19463 Jemlich that fixes bug #52597, MCS was generating invalid code for
19464 idisposable structs. Thanks to Ben for following up with this
19467 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19469 * driver.cs: Allow assemblies without code to be generated, fixes
19472 2004-01-07 Nick Drochak <ndrochak@gol.com>
19474 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19476 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19478 * cs-parser.jay: Add rules to improve error reporting if fields or
19479 methods are declared at the namespace level (error 116)
19481 * Add rules to catch event add/remove
19483 2004-01-04 David Sheldon <dave-mono@earth.li>
19485 * expression.cs: Added matching ")" to error message for
19488 2004-01-03 Todd Berman <tberman@gentoo.org>
19490 * ecore.cs, attribute.cs:
19491 Applying fix from #52429.
19493 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19495 * ecore.cs, expression.cs, statement.cs:
19496 Total rewrite of how we handle branching. We
19497 now handle complex boolean expressions with fewer
19498 jumps. As well if (x == 0) no longer emits a ceq.
19500 if (x is Foo) is much faster now, because we generate
19503 Overall, we get a pretty big improvement on our benchmark
19504 tests. The code we generate is smaller and more readable.
19506 I did a full two-stage bootstrap. The patch was reviewed
19507 by Martin and Miguel.
19509 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19511 * cs-parser.jay: Make primary_expression not take a QI.
19512 we dont need this because the member_access rule covers
19513 us here. So we replace the rule with just IDENTIFIER.
19515 This has two good effects. First, we remove a s/r conflict.
19516 Second, we allocate many fewer QualifiedIdentifier objects.
19518 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19520 * attribute.cs: Handle MarshalAs attributes as pseudo, and
19521 set the correct information via SRE. This prevents
19522 hanging on the MS runtime. Fixes #29374.
19524 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19526 * convert.cs: correctly handle conversions to value types
19527 from Enum and ValueType as unboxing conversions.
19529 Fixes bug #52569. Patch by Benjamin Jemlich.
19531 2004-01-02 Ravi Pratap <ravi@ximian.com>
19533 * expression.cs (BetterConversion): Prefer int -> uint
19534 over int -> ulong (csc's behaviour). This fixed bug #52046.
19536 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
19538 * decl.cs (MemberCache.FindMembers): now returns a
19541 * typemanager.cs: In general, go with with ^^.
19542 (CopyNewMethods): take an IList.
19543 (RealMemberLookup): Only allocate an arraylist
19544 if we copy from two sets of methods.
19546 This change basically does two things:
19547 1) Fewer array lists allocated due to CopyNewMethods.
19548 2) the explicit cast in MemberList costed ALOT.
19550 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
19552 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
19553 a hashtable to avoid needless string allocations when an identifier is
19554 used more than once (the common case).
19556 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19558 * pending.cs: MS's TypeBuilder.GetInterfaces ()
19559 is broken, it will not return anything. So, we
19560 have to use the information we have in mcs to
19563 * typemanager.cs: Add a cache for GetInterfaces,
19564 since this will now be used more often (due to ^^)
19566 (GetExplicitInterfaces) New method that gets the
19567 declared, not effective, interfaces on a type
19568 builder (eg, if you have interface IFoo, interface
19569 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
19572 This patch makes MCS able to bootstrap itself on
19575 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19577 * expression.cs: Remove the Nop's that Miguel put
19580 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19582 * report.cs, codegen.cs: Give the real stack trace to
19583 the error when an exception is thrown.
19585 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19587 * decl.cs: only allocate hashtables for ifaces if
19590 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19592 * expression.cs: fix the error from cs0121-2.cs
19593 (a parent interface has two child interfaces that
19594 have a function with the same name and 0 params
19595 and the function is called through the parent).
19597 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
19599 * class.cs, rootcontext.cs, typmanager.cs: do not
19602 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
19604 * codegen.cs: remove stack for the ec flow branching.
19605 It is already a linked list, so no need.
19607 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
19609 * Makefile: Allow custom profiler here.
19611 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19613 * typemanager.cs (LookupType):
19614 - Use a static char [], because split takes
19615 a param array for args, so it was allocating
19617 - Do not store true in a hashtable, it boxes.
19619 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19621 * flowanalysis.cs: bytify common enums.
19623 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19625 * modifiers.cs: Add a new set of flags for the
19626 flags allowed on explicit interface impls.
19627 * cs-parser.jay: catch the use of modifiers in
19628 interfaces correctly.
19629 * class.cs: catch private void IFoo.Blah ().
19631 All related to bug #50572.
19633 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19635 * decl.cs: Rewrite the consistant accessability checking.
19636 Accessability is not linear, it must be implemented in
19637 a tableish way. Fixes #49704.
19639 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19641 * expression.cs: Handle negation in a checked context.
19642 We must use subtraction from zero. Fixes #38674.
19644 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19646 * class.cs: Ignore static void main in DLLs.
19647 * rootcontext.cs: Handle the target type here,
19648 since we are have to access it from class.cs
19649 * driver.cs: account for the above.
19651 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19653 * report.cs: Give line numbers and files if available.
19655 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
19657 * driver.cs: Implement /addmodule.
19659 * typemanager.cs: Change 'modules' field so it now contains Modules not
19662 2003-12-20 Martin Baulig <martin@ximian.com>
19664 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
19665 (FieldBase.IsAssigned): Removed this field.
19666 (FieldBase.SetAssigned): New public method.
19667 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
19669 2003-12-20 Martin Baulig <martin@ximian.com>
19671 * expression.cs (LocalVariableReference.DoResolve): Don't set
19672 `vi.Used' if we're called from DoResolveLValue().
19674 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
19675 returns the usage vector it just merged into the current one -
19676 pass this one to UsageWarning().
19677 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
19678 of the `EmitContext', don't call this recursively on our children.
19680 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
19682 * driver.cs: Implement /target:module.
19684 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
19686 * support.cs (CharArrayHashtable): New helper class.
19688 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
19689 char arrays, not strings, so we can avoid creating a string in
19690 consume_identifier if the identifier is a keyword.
19692 2003-12-16 Martin Baulig <martin@ximian.com>
19694 * statement.cs (LocalInfo.Assigned): Removed this property.
19695 (LocalInfo.Flags): Removed `Assigned'.
19696 (LocalInfo.IsAssigned): New public method; takes the EmitContext
19697 and uses flow analysis.
19698 (Block.UsageWarning): Made this method private.
19699 (Block.Resolve): Call UsageWarning() if appropriate.
19701 * expression.cs (LocalVariableReference.DoResolve): Always set
19702 LocalInfo.Used here.
19704 2003-12-13 Martin Baulig <martin@ximian.com>
19706 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
19707 any value here; we're now using flow analysis to figure out
19708 whether a statement/block returns a value.
19710 2003-12-13 Martin Baulig <martin@ximian.com>
19712 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
19714 (FlowBranching.MergeFinally): Don't call
19715 `branching.CheckOutParameters()' here, this is called in
19717 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
19718 when adding the `finally' vector.
19720 2003-12-13 Martin Baulig <martin@ximian.com>
19723 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
19724 actually work and also fix #48962.
19726 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
19728 * decl.cs: Do not check System.Object for nested types,
19729 since we know it does not have any. Big bang for buck:
19732 Run 1: 8.35 seconds
19733 Run 2: 8.32 seconds
19734 corlib: 17.99 seconds
19736 Run 1: 8.17 seconds
19737 Run 2: 8.17 seconds
19738 corlib: 17.39 seconds
19740 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
19742 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
19743 time we are returning 0 members, so we save alot here.
19745 2003-12-11 Martin Baulig <martin@ximian.com>
19747 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
19748 `MergeChild()', also just take the `FlowBranching' as argument;
19749 call Merge() on it and return the result.
19750 (FlowBranching.Merge): We don't need to do anything if we just
19753 2003-12-11 Martin Baulig <martin@ximian.com>
19755 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
19756 them in an `ArrayList' to reduce memory usage. Thanks to Ben
19757 Maurer for this idea.
19759 2003-12-11 Martin Baulig <martin@ximian.com>
19761 * flowanalysis.cs (MergeResult): This class is now gone; we now
19762 use the `UsageVector' for this. The reason for this is that if a
19763 branching just has one sibling, we don't need to "merge" them at
19764 all - that's the next step to do.
19765 (FlowBranching.Merge): We now return a `UsageVector' instead of a
19768 2003-12-11 Martin Baulig <martin@ximian.com>
19770 Reworked flow analyis and made it more precise and bug-free. The
19771 most important change is that we're now using a special `Reachability'
19772 class instead of having "magic" meanings of `FlowReturns'. I'll
19773 do some more cleanups and optimizations and also add some more
19774 documentation this week.
19776 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
19777 largely reworked this class.
19778 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
19779 the new `Reachability' class instead of having "magic" values here.
19780 (FlowBranching): We're now using an instance of `Reachability'
19781 instead of having separate `Returns', `Breaks' etc. fields.
19783 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
19784 based on flow analysis; ignore the return value of block.Emit ().
19786 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
19788 * driver.cs typemanager.cs: Find the mono extensions to corlib even
19789 if they are private.
19791 2003-12-09 Martin Baulig <martin@ximian.com>
19793 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
19794 call them directly on the UsageVector.
19796 2003-12-09 Martin Baulig <martin@ximian.com>
19798 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
19799 Changed return type from `FlowReturns' to `Reachability'.
19801 2003-12-09 Martin Baulig <martin@ximian.com>
19803 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
19804 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
19805 `Reachable' fields with a single `Reachability' one.
19807 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19809 * class.cs (FindMembers): Remove foreach's.
19814 Run 1: 8.74 seconds
19815 Run 2: 8.71 seconds
19818 Run 1: 8.64 seconds
19819 Run 2: 8.58 seconds
19822 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19827 This patch does a few things:
19828 1. EmptyStatement is now a singleton, so it is never reallocated.
19829 2. All blah is EmptyStatement constructs have been changed to
19830 blah == EmptyStatement.Value, which is much faster and valid
19831 now that EmptyStatement is a singleton.
19832 3. When resolving a block, rather than allocating a new array for
19833 the non-empty statements, empty statements are replaced with
19834 EmptyStatement.Value
19835 4. Some recursive functions have been made non-recursive.
19836 Mainly the performance impact is from (3), however (1) and (2) are needed for
19837 this to work. (4) does not make a big difference in normal situations, however
19838 it makes the profile look saner.
19843 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
19844 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
19845 Total memory allocated: 56397 KB
19848 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
19849 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
19850 Total memory allocated: 55666 KB
19852 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19854 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
19855 than the hashtable in a hashtable version
19857 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
19858 we always end up concating a string. This results in a huge perf
19859 loss, because many strings have to be tracked by the GC. In this
19860 patch, we first use a hashtable that works with two keys, so that
19861 the strings do not need to be concat'ed.
19865 Run 1: 8.74 seconds
19866 Run 2: 8.71 seconds
19869 Run 1: 8.65 seconds
19870 Run 2: 8.56 seconds
19872 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19874 * Makefile: Add a new target `do-time' that does a quick and simple
19875 profile, leaving easy to parse output.
19877 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
19879 * codegen.cs (Init): Create the dynamic assembly with
19880 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
19882 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
19884 * support.cs: Make the PtrHashtable use only one
19885 instance of its comparer.
19887 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
19889 * typemanager.cs: Fix lookup of GetNamespaces.
19891 2003-11-29 Miguel de Icaza <miguel@ximian.com>
19893 * expression.cs: Removed redundant line.
19895 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
19896 ArrayLists, use for loops with bounds.
19898 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
19901 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
19902 arraylists, use for loop with bounds.
19904 The above three changes give us a 0.071 second performance
19905 improvement out of 3.294 seconds down to 3.223. On my machine
19906 the above changes reduced the memory usage by 1,387 KB during
19907 compiler bootstrap.
19909 * cs-parser.jay (QualifiedIdentifier): New class used to represent
19910 QualifiedIdentifiers. Before we created a new string through
19911 concatenation, and mostly later on, the result would be
19912 manipulated by DecomposeQI through string manipulation.
19914 This reduced the compiler memory usage for bootstrapping from
19915 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
19916 compile times in 0.05 seconds.
19918 2003-11-28 Dick Porter <dick@ximian.com>
19920 * support.cs: Do string compares with the Invariant culture.
19928 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
19929 the comparison is done with the Invariant culture.
19931 2003-11-27 Miguel de Icaza <miguel@ximian.com>
19933 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
19934 GetEnumerator method.
19936 (ProbeCollectionType): Iterate starting at the most specific type
19937 upwards looking for a GetEnumerator
19939 * expression.cs: Shift count can be up to 31 for int/uint and 63
19942 2003-11-26 Miguel de Icaza <miguel@ximian.com>
19944 * statement.cs (Block.LookupLabel): Also look for the label on the
19945 children blocks. Use a hash table to keep track of visited
19948 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
19949 we actually did transform the other operand, otherwise fall back
19950 to the common codepath that casts to long.
19952 * cs-tokenizer.cs: Use the same code pattern as the int case.
19953 Maybe I should do the parsing myself, and avoid depending on the
19954 Parse routines to get this done.
19956 2003-11-25 Miguel de Icaza <miguel@ximian.com>
19958 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
19959 which fixes bug 51347. This time test it.
19961 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
19962 attributes for example can not tell the difference between these.
19963 The difference was only a syntax feature of the language.
19965 * attribute.cs: Apply attributes to delegates.
19967 * delegate.cs: Call the apply attributes method.
19969 2003-11-24 Miguel de Icaza <miguel@ximian.com>
19971 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
19972 comparing 0 vs Byte.MinValue, not the value
19974 (ImplicitConversionRequired): When reporting a conversion error,
19975 use error 31 to print out the constant error instead of the
19978 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
19979 which fixes bug 51347.
19981 2003-11-22 Miguel de Icaza <miguel@ximian.com>
19983 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
19984 which fixes the -warnaserror command line option.
19986 2003-11-21 Miguel de Icaza <miguel@ximian.com>
19988 * cfold.cs (DoNumericPromotions): During constant folding of
19989 additions on UIntConstant, special case intconstants with
19990 IntConstants like we do on the expression binary operator.
19992 2003-11-12 Miguel de Icaza <miguel@ximian.com>
19994 * convert.cs (ImplicitReferenceConversion): We were missing a case
19995 (System.Enum are not value types or class types, so we need to
19996 classify them separatedly).
19998 * driver.cs: We do not support error 2007.
20000 2003-11-12 Jackson Harper <jackson@ximian.com>
20002 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20003 system directory. Also use the full file name so users can
20004 libraries names mscorlib-o-tron.dll in a non system dir.
20006 2003-11-10 Martin Baulig <martin@ximian.com>
20008 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20009 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20010 calling `ResolveType()' on them, directly assign their `Type'.
20012 2003-11-08 Martin Baulig <martin@ximian.com>
20014 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20015 return value and the `out parent' parameter.
20016 (TypeContainer.DefineType): Moved the CS0644 check into
20017 GetClassBases(). Don't pass the interface types to the
20018 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20019 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20021 * ecore.cs (TypeExpr.IsAttribute): New property.
20022 (TypeExpr.GetInterfaces): New method.
20024 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20025 TypeExpr instead of a Type.
20026 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20027 (Interface.DefineType): Don't pass the interface types to the
20028 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20029 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20031 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20032 instead of a `Type[]'.
20033 (TypeManager.RegisterBuilder): Likewise.
20034 (TypeManager.AddUserInterface): Likewise.
20035 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20036 `Type[]' and also return a `TypeExpr[]'.
20037 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20039 2003-11-08 Martin Baulig <martin@ximian.com>
20041 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20044 2003-11-08 Martin Baulig <martin@ximian.com>
20046 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20047 TypeManager.ResolveExpressionTypes().
20049 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20050 instead of an Expression.
20051 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20052 (TypeExpression): New public class; formerly known as `TypeExpr'.
20054 * expression.cs (ComposedCast): Derive from TypeExpr.
20056 * typemanager.cs (TypeManager.system_*_expr): These are now
20057 TypExpr's instead of Expression's.
20058 (TypeManager.ResolveExpressionTypes): New public static function;
20059 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20062 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20064 * expression.cs (New.DoResolve): Do not dereference value that
20065 might be a null return.
20067 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20068 sure that the constant value has the right type. Fixes an
20069 unreported bug, similar to 50425.
20071 * const.cs (Const.LookupConstantValue): Call
20072 ImplicitStandardConversionExists before doing a conversion to
20073 avoid havng the TypeManager.ChangeType do conversions.
20075 Reduced the number of casts used
20077 (Const.ChangeType): New routine to enable reuse of the constant
20078 type changing code from statement.
20080 * typemanager.cs (ChangeType): Move common initialization to
20081 static global variables.
20085 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20086 every value type to go through, even if it was void. Fix that.
20088 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20089 character of the define, and the is_identifier_part_character for
20090 the rest of the string.
20092 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20094 * expression.cs (UnaryMutator.EmitCode): When I updated
20095 LocalVariableReference.DoResolve, I overdid it, and dropped an
20096 optimization done on local variable references.
20098 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20100 * ecore.cs: Convert the return from Ldlen into an int.
20102 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20104 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20105 the accessibility, this is a special case for toplevel non-public
20106 classes (internal for instance).
20108 2003-10-20 Nick Drochak <ndrochak@gol.com>
20110 * ecore.cs: Fix typo and build. Needed another right paren.
20112 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20114 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20115 `internal' case regular and protected, but not allowing protected
20116 to be evaluated later. Bug 49840
20118 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20120 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20121 to kb.Nlast, and not the kb.nFirst to isolate the switch
20124 Extract the underlying type, so enumerations of long/ulong are
20125 treated like long/ulong.
20127 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20129 * expression.cs (New): Overload the meaning of RequestedType to
20130 track the possible creation of the NewDelegate type, since
20131 DoResolve is invoked more than once for new constructors on field
20134 See bugs: #48800 and #37014
20136 * cs-parser.jay (declare_local_constants): Take an arraylist
20137 instead of a single constant.
20139 (local_constant_declaration): It should take a
20140 constant_declarators, not a constant_declarator. Fixes 49487
20142 * convert.cs: Fix error report.
20144 2003-10-13 Jackson Harper <jackson@ximian.com>
20146 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20149 2003-10-09 Martin Baulig <martin@ximian.com>
20151 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20153 (MethodCore.DoDefineParameters): Removed the TypeContainer
20154 argument; use the DeclSpace which was passed to the .ctor instead.
20155 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20156 TypeContainer; we only need a DeclSpace here.
20158 2003-10-09 Martin Baulig <martin@ximian.com>
20160 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20162 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20163 EmitContext's .ctor.
20165 2003-10-09 Martin Baulig <martin@ximian.com>
20167 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20168 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20169 AsAccessible(), moved them as well.
20171 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20173 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20175 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20177 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20179 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20180 generation for >=, as spotted by Paolo, bug 48679.
20181 Patch from David Waite.
20183 * cs-tokenizer.cs: Add handling for #pragma.
20185 * cs-parser.jay: Allow for both yield and yield return in the
20186 syntax. The anti-cobolization of C# fight will go on!
20188 * class.cs (TypeBuilder.DefineType): Catch error condition here
20189 (Parent.DefineType erroring out and returning null).
20191 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20192 coping with enumerations variables, we were mistakenly processing
20193 them as a regular value type instead of built-in types. Fixes the
20196 * typemanager.cs (IsBuiltinOrEnum): New method.
20198 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20200 * cs-parser.jay: Upgrade: yield now needs the return clause.
20202 2003-09-19 Martin Baulig <martin@ximian.com>
20204 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20205 `MemberCache parent' argument. Normally, an interface doesn't
20206 have a parent type except System.Object, but we use this in gmcs
20207 for generic type parameters.
20209 2003-09-18 Martin Baulig <martin@ximian.com>
20211 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20212 on `type.IsInterface'; don't check whether the type has a parent
20213 to determine whether it's an interface.
20215 2003-09-15 Martin Baulig <martin@ximian.com>
20217 * class.cs (TypeContainer.DefineType): Added an error flag to
20218 avoid reporting duplicate CS0146's ("class definition is
20221 * driver.cs (Driver.MainDriver): Abort if
20222 RootContext.ResolveTree() reported any errors.
20224 2003-09-07 Martin Baulig <martin@ximian.com>
20226 * report.cs (Error, Warning): Added overloaded versions which take
20227 a `params object[] args' and call String.Format().
20229 2003-09-07 Martin Baulig <martin@ximian.com>
20231 * decl.cs (DeclSpace..ctor): Don't call
20232 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20233 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20234 (DeclSpace.RecordDecl): New method.
20236 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20238 2003-09-02 Ravi Pratap <ravi@ximian.com>
20240 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20241 value attributes to be applied to ParameterBuilders.
20243 * class.cs (MethodCore.LabelParameters): Make static and more
20244 generic so that it can be used from other places - like interface
20245 methods, for instance.
20247 * interface.cs (Interface.Emit): Call LabelParameters before
20248 emitting attributes on the InterfaceMethod.
20250 2003-08-26 Martin Baulig <martin@ximian.com>
20252 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20253 resolving aliases; fixes #47927.
20255 2003-08-26 Martin Baulig <martin@ximian.com>
20257 * statement.cs (Using.DoResolve): This is internally emitting a
20258 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20259 do not always return. Fixes #47681.
20261 2003-08-26 Martin Baulig <martin@ximian.com>
20263 * decl.cs (MemberCore): Moved WarningNotHiding(),
20264 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20266 (AdditionResult): Make this nested in DeclSpace.
20267 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20268 argument; call NamespaceEntry.Define() unless we're nested in a
20271 * namespace.cs (Namespace.DefineName): New public function. This
20272 is called from DeclSpace's .ctor to add
20273 (Namespace.Lookup): Include DeclSpaces in the lookup.
20275 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20277 * const.cs (Const): Derive from MemberBase, not MemberCore.
20279 2003-08-25 Martin Baulig <martin@ximian.com>
20281 * convert.cs (Convert.ExplicitReferenceConversion): When
20282 converting from an interface type to a class, unbox if the target
20283 type is a struct type. Fixes #47822.
20285 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20287 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20290 2003-08-22 Martin Baulig <martin@ximian.com>
20292 * class.cs (TypeManager.DefineType): When defining a nested type,
20293 call DefineType() on our parent; fixes #47801.
20295 2003-08-22 Martin Baulig <martin@ximian.com>
20297 * class.cs (MethodData.Define): While checking if a method is an
20298 interface implementation, improve the test a bit more to fix #47654.
20300 2003-08-22 Martin Baulig <martin@ximian.com>
20302 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20303 correctly; fixes #47722.
20305 2003-08-22 Martin Baulig <martin@ximian.com>
20307 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20308 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20310 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20312 2003-08-22 Martin Baulig <martin@ximian.com>
20314 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20315 can only be assigned in static constructors. Fixes #47161.
20317 2003-08-22 Martin Baulig <martin@ximian.com>
20319 Rewrote and improved the flow analysis code.
20321 * flowbranching.cs (FlowBranching): Make this class abstract.
20322 (FlowBranching.CreateBranching): New static function to create a
20323 new flow branching.
20324 (FlowBranchingBlock, FlowBranchingException): New classes.
20325 (FlowBranching.UsageVector.Type): New public readonly field.
20326 (FlowBranching.UsageVector.Breaks): Removed the setter.
20327 (FlowBranching.UsageVector.Returns): Removed the setter.
20328 (FlowBranching.UsageVector): Added Break(), Return(),
20329 NeverReachable() and Throw() methods to modify the reachability.
20330 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20331 done by FlowBranching.Merge().
20332 (FlowBranching.UsageVector.MergeChild): New method; merges the
20333 merge result into the current vector.
20334 (FlowBranching.Merge): New abstract method to merge a branching.
20336 2003-08-12 Martin Baulig <martin@ximian.com>
20338 * expression.cs (Indirection.CacheTemporaries): Create the
20339 LocalTemporary with the pointer type, not its element type.
20341 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20343 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20344 token was a keyword or not.
20346 Add `error' options where an IDENTIFIER was expected; Provide
20347 CheckToken and CheckIdentifierToken convenience error reporting
20350 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20352 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20353 NameSpaceEntry NameSpaceEntry.
20355 (LookupInterfaceOrClass): Avoid creating a full qualified name
20356 from namespace and name: avoid doing lookups when we know the
20357 namespace is non-existant. Use new Tree.LookupByNamespace which
20358 looks up DeclSpaces based on their namespace, name pair.
20360 * driver.cs: Provide a new `parser verbose' to display the
20361 exception thrown during parsing. This is turned off by default
20362 now, so the output of a failure from mcs is more graceful.
20364 * namespace.cs: Track all the namespaces defined in a hashtable
20367 (IsNamespace): New method
20369 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20371 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20372 we know that we need to concatenate (full typename can never be
20377 * statement.cs: Use a bitfield; Do not initialize to null things
20378 which are done by the constructor by default.
20380 * cs-parser.jay: bug fix, parameter was 4, not 3.
20382 * expression.cs: Just use the property;
20384 * statement.cs: No need for GetVariableInfo method.
20386 2003-08-08 Martin Baulig <martin@ximian.com>
20388 * flowanalysis.cs (FlowReturns): This is now nested in the
20389 `FlowBranching' class.
20390 (MyBitVector): Moved this here from statement.cs.
20391 (FlowBranching.SiblingType): New enum type.
20392 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20394 2003-08-07 Martin Baulig <martin@ximian.com>
20396 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20397 `FlowBranching' class and called `BranchingType'.
20399 2003-08-07 Martin Baulig <martin@ximian.com>
20401 * flowanalysis.cs: Moved all the control flow analysis code into
20404 2003-08-07 Martin Baulig <martin@ximian.com>
20406 * assign.cs (Assign.DoResolve): `target' must either be an
20407 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20410 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20412 * expression.cs (BinaryMethod): This kind of expression is created by the
20413 Binary class if it determines that the operator has to be handled
20416 (BinaryDelegate): This kind of expression is created if we are
20417 dealing with a + or - operator on delegates.
20419 (Binary): remove method, argumetns, and DelegateOperator: when
20420 dealing with methods,
20422 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20424 * statement.cs (Block): use bitfields for the three extra booleans
20425 we had in use. Remove unused topblock parameter.
20427 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20429 * assign.cs: Drop extra unneeded tests.
20431 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20433 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20435 * statement.cs (Foreach): Use VariableStorage instead of
20438 * codegen.cs (VariableStorage): New class used by clients that
20439 require a variable stored: locals or fields for variables that
20440 need to live across yield.
20442 Maybe provide a convenience api for EmitThis+EmitLoad?
20444 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20447 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20449 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20450 RemapParameterLValue): New methods that are used to turn a
20451 precomputed FieldInfo into an expression like this:
20455 The idea is to use this instead of making LocalVariableReference
20456 have more than one meaning.
20458 * cs-parser.jay: Add error production to BASE.
20460 * ecore.cs: Deal with TypeManager.GetField returning null, which
20461 is now a valid return value.
20463 (FieldExprNoAddress): New expression for Fields whose address can
20466 * expression.cs (LocalVariableReference): During the resolve
20467 phases, create new expressions if we are in a remapping context.
20468 Remove code that dealt with remapping here.
20470 (ParameterReference): same.
20472 (ProxyInstance): New expression, like the `This' expression, but
20473 it is born fully resolved. We know what we are doing, so remove
20474 the errors that are targeted to user-provided uses of `this'.
20476 * statement.cs (Foreach): our variable is now stored as an
20477 Expression; During resolution, follow the protocol, dont just
20478 assume it will return this.
20480 2003-08-06 Martin Baulig <martin@ximian.com>
20482 * support.cs (SeekableStreamReader.cs): New public class.
20484 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
20485 SeekableStreamReader instead of the normal StreamReader.
20487 2003-08-04 Martin Baulig <martin@ximian.com>
20489 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
20490 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
20491 deambiguate casts and delegate invocations.
20492 (parenthesized_expression): Use the new tokens to ensure this is
20493 not a cast of method invocation.
20495 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
20496 when reading a `)' and Deambiguate_CloseParens () was previously
20499 * expression.cs (ParenthesizedExpression): New class. This is
20500 just used for the CS0075 test.
20501 (Binary.DoResolve): Check for CS0075.
20503 2003-07-29 Ravi Pratap <ravi@ximian.com>
20505 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
20506 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
20507 reference comparison.
20509 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
20510 examine the ReturnType for equality - this is necessary in the
20511 cases of implicit and explicit operators whose signature also
20512 includes the return type.
20514 2003-07-26 Miguel de Icaza <miguel@ximian.com>
20516 * namespace.cs: Cache the result of the namespace computation,
20517 instead of computing it every time.
20519 2003-07-24 Miguel de Icaza <miguel@ximian.com>
20521 * decl.cs: Use a global arraylist that we reuse over invocations
20522 to avoid excesive memory consumption. Reduces memory usage on an
20523 mcs compile by one meg (45 average).
20525 * typemanager.cs (LookupTypeReflection): In .NET pointers are
20526 private, work around that.
20528 2003-07-23 Miguel de Icaza <miguel@ximian.com>
20530 * literal.cs (IntLiteral): Define Zero and One static literals.
20532 * cs-parser.jay (integer_literal): use static literals to reduce
20533 memory usage for the most used literals (0, 1 and -1). 211kb
20534 reduced in memory usage.
20536 Replace all calls to `new ArrayList' with `new
20537 ArrayList(4)' which is a good average number for most allocations,
20538 and also requires only 16 bytes of memory for its buffer by
20541 This reduced MCS memory usage in seven megabytes for the RSS after
20544 2003-07-28 Ravi Pratap <ravi@ximian.com>
20546 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
20547 handle params methods the correct way by forming only one
20548 applicable set with params and normal methods in them. Earlier we
20549 were looking at params methods only if we found no normal methods
20550 which was not the correct thing to do.
20552 (Invocation.BetterFunction): Take separate arguments indicating
20553 when candidate and the best method are params methods in their
20556 This fixes bugs #43367 and #46199.
20558 * attribute.cs: Documentation updates.
20560 (CheckAttribute): Rename to CheckAttributeTarget.
20561 (GetValidPlaces): Rename to GetValidTargets.
20563 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
20564 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
20568 2003-07-28 Martin Baulig <martin@ximian.com>
20570 * class.cs (TypeContainer.DefineMembers): Use the base type's full
20571 name when looking up the base class of a nested class. Fixes #46977.
20573 2003-07-26 Martin Baulig <martin@ximian.com>
20575 * expression.cs (Indexers.Indexer): New nested struct; contains
20576 getter, setter and the indexer's type.
20577 (Indexers.Properties): This is now an ArrayList of
20578 Indexers.Indexer's.
20579 (IndexerAccess.DoResolveLValue): Correctly set the type if the
20580 indexer doesn't have any getters.
20582 * assign.cs (Assign.DoResolve): Also do the implicit conversions
20583 for embedded property and indexer assignments.
20585 2003-07-26 Martin Baulig <martin@ximian.com>
20587 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
20588 preprocessor directive is not the first non-whitespace character
20591 2003-07-26 Martin Baulig <martin@ximian.com>
20593 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
20594 namespace parsing, follow the spec more closely.
20596 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
20597 NamespaceEntry.Lookup().
20599 2003-07-25 Martin Baulig <martin@ximian.com>
20601 * MethodCore.cs (OverridesSomething): New public field; it's set
20602 from TypeContainer.DefineMembers if this method overrides
20603 something (which doesn't need to be a method). Fix #39462.
20605 2003-07-25 Ravi Pratap <ravi@ximian.com>
20607 * typemanager.cs (GetMembers): Ensure that the list of members is
20608 reversed. This keeps things in sync.
20610 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
20611 find an AttributeUsage attribute.
20613 * expression.cs (Invocation.OverloadResolve): Perform the check
20614 which disallows Invoke to be directly called on a Delegate.
20616 (Error_InvokeOnDelegate): Report error cs1533.
20618 2003-07-25 Martin Baulig <martin@ximian.com>
20620 * expression.cs (Indexers.GetIndexersForType): Only look in the
20621 interface hierarchy if the requested type is already an
20622 interface. Fixes #46788 while keeping #46502 fixed.
20624 2003-07-25 Martin Baulig <martin@ximian.com>
20626 * class.cs (TypeContainer.DefineMembers): Check whether all
20627 readonly fields have been assigned and report warning CS0649 if
20630 * statement.cs (LocalInfo.IsFixed): Always return true if this is
20633 2003-07-24 Ravi Pratap <ravi@ximian.com>
20635 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
20636 returned from GetMethods to make things consistent with the
20637 assumptions MCS makes about ordering of methods.
20639 This should comprehensively fix bug #45127 and it does :-)
20641 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
20642 ordering is actually reverse.
20644 * Clean up some debug messages I left lying around.
20646 * interface.cs (Populate*): Get rid of code which emits attributes
20647 since the stage in which we emit attributes is the 'Emit' stage,
20648 not the define stage.
20650 (Emit): Move attribute emission for interface members here.
20652 2003-07-22 Ravi Pratap <ravi@ximian.com>
20654 * expression.cs (Invocation.OverloadResolve): Follow the spec more
20655 closely: we eliminate methods in base types when we have an
20656 applicable method in a top-level type.
20658 Please see section 14.5.5.1 for an exact description of what goes
20661 This fixes bug #45127 and a host of other related to corlib compilation.
20663 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
20664 array is the method corresponding to the top-level type (this is
20665 because of the changes made to icall.c) so we change this
20668 (MethodGroupExpr.Name): This too.
20670 * typemanager.cs (GetElementType): New method which does the right
20671 thing when compiling corlib.
20673 * everywhere: Make use of the above in the relevant places.
20675 2003-07-22 Martin Baulig <martin@ximian.com>
20677 * cs-parser.jay (invocation_expression): Moved
20678 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
20679 `cast_expression', but create a InvocationOrCast which later
20680 resolves to either an Invocation or a Cast.
20682 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
20683 method; call this before EmitStatement() to make sure that this
20684 expression can be used as a statement.
20686 * expression.cs (InvocationOrCast): New class; resolves to either
20687 an Invocation or a Cast.
20689 * statement.cs (StatementExpression): Call ResolveStatement() on
20690 the ExpressionStatement before emitting it.
20692 2003-07-21 Martin Baulig <martin@ximian.com>
20694 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
20695 `ref' and `out' attributes match; fixes #46220.
20696 (MemberAccess.ResolveMemberAccess): You can't reference a type
20697 through an expression; fixes #33180.
20698 (Indexers.GetIndexersForType): Don't return the indexers from
20699 interfaces the class implements; fixes #46502.
20701 2003-07-21 Martin Baulig <martin@ximian.com>
20703 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
20704 CS0661 checks; fixes bug #30442.
20706 2003-07-21 Martin Baulig <martin@ximian.com>
20708 * decl.cs (AdditionResult): Added `Error'.
20710 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
20712 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
20713 makes cs0031.cs actually work.
20715 2003-07-20 Martin Baulig <martin@ximian.com>
20717 * namespace.cs: Fixed that bug which caused a crash when compiling
20718 the debugger's GUI.
20720 2003-07-20 Miguel de Icaza <miguel@ximian.com>
20722 * typemanager.cs (LookupTypeReflection): Never expose types which
20723 are NotPublic, NestedPrivate, NestedAssembly, or
20724 NestedFamANDAssem. We used to return these, and later do a check
20725 that would report a meaningful error, but the problem is that we
20726 would not get the real match, if there was a name override.
20728 2003-07-18 Miguel de Icaza <miguel@ximian.com>
20730 * namespace.cs (Namespace, Name): Do not compute the namespace
20731 name dynamically, compute it in the constructor. This reduced
20732 memory usage by 1697 KB.
20734 * driver.cs: Use --pause to pause at the end.
20736 2003-07-17 Peter Williams <peter@newton.cx>
20738 * Makefile: Change the name of the test target so that it doesn't
20739 conflict with the recursive test target.
20741 2003-07-17 Miguel de Icaza <miguel@ximian.com>
20743 * expression.cs (LocalVariableReference.Emit, EmitAssign,
20744 AddressOf): Do not use EmitThis, that was wrong, use the actual
20747 2003-07-15 Miguel de Icaza <miguel@ximian.com>
20749 * class.cs (MethodData.Define): While checking if a method is an
20750 interface implementation, improve the test: If we are not public
20751 (use new test here: use the computed MethodAttributes directly,
20752 instead of the parsed modifier flags) check if the `implementing'
20753 method comes from an interface or not.
20755 * pending.cs (VerifyPendingMethods): Slightly better error
20758 * makefile: add test target that does the mcs bootstrap.
20760 2003-07-16 Ravi Pratap <ravi@ximian.com>
20762 * interface.cs (Define): Do nothing here since there are no
20763 members to populate etc. Move the attribute emission out of here
20764 since this was just totally the wrong place to put it. Attribute
20765 application happens during the 'Emit' phase, not in the 'Define'
20768 (Emit): Add this method and move the attribute emission here
20770 * rootcontext.cs (EmitCode): Call the Emit method on interface
20773 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20775 * expression.cs (OverloadResolve): Report error only if Location
20776 is not 'Null' which means that there was a probe going on.
20778 2003-07-14 Martin Baulig <martin@ximian.com>
20780 * expression.cs (ConditionalLogicalOperator): New public class to
20781 implement user defined conditional logical operators.
20782 This is section 14.11.2 in the spec and bug #40505.
20784 2003-07-14 Martin Baulig <martin@ximian.com>
20786 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
20788 2003-07-14 Martin Baulig <martin@ximian.com>
20790 * codegen.cs (EmitContext.InFixedInitializer): New public field.
20792 * ecore.cs (IVariable.VerifyFixed): New interface method.
20794 * expression.cs (Unary.ResolveOperator): When resolving the `&'
20795 operator, check whether the variable is actually fixed. Fixes bug
20796 #36055. Set a variable definitely assigned when taking its
20797 address as required by the spec.
20799 * statement.cs (LocalInfo.IsFixed): New field.
20800 (LocalInfo.MakePinned): Set `IsFixed' to true.
20802 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20804 * attribute.cs (Attribute.Resolve): While doing a Member lookup
20805 for .ctors, ensure that we only ask for members declared in the
20806 attribute type (BindingFlags.DeclaredOnly).
20810 * expression.cs (Error_WrongNumArguments): Report error 1501
20811 correctly the way CSC does.
20813 2003-07-13 Martin Baulig <martin@ximian.com>
20815 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
20816 lookup on the fully qualified name, to make things like "X.X" work
20817 where "X.X" is a fully qualified type name, but we also have a
20818 namespace "X" in the using list. Fixes #41975.
20820 2003-07-13 Martin Baulig <martin@ximian.com>
20822 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
20823 function. If we're a CompoundAssign, we need to create an embedded
20824 CompoundAssign, not an embedded Assign.
20825 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
20828 2003-07-13 Martin Baulig <martin@ximian.com>
20830 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
20831 work to fix bug #46088.
20833 2003-07-13 Ravi Pratap <ravi@ximian.com>
20835 * class.cs (Operator.Emit): Do not emit attributes here - it is
20836 taken care of by the Method class that we delegate too. This takes
20837 care of bug #45876.
20839 2003-07-10 Martin Baulig <martin@ximian.com>
20841 * expression.cs (TypeOfVoid): New class.
20842 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
20844 2003-07-10 Martin Baulig <martin@ximian.com>
20846 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
20849 2003-07-10 Martin Baulig <martin@ximian.com>
20851 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
20852 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
20854 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
20856 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
20858 2003-07-10 Martin Baulig <martin@ximian.com>
20860 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
20861 of decimal. Fixes #42850.
20863 NOTE: I also fixed the created byte blob, but this doesn't work on
20864 the MS runtime and csc never produces any byte blobs for decimal
20867 2003-07-10 Martin Baulig <martin@ximian.com>
20869 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
20870 structs; fixes #32068.
20871 (Block.AddChildVariableNames): Fixed #44302.
20873 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20875 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
20877 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20879 * attribute.cs: And this test is onger needed.
20881 2003-07-08 Martin Baulig <martin@ximian.com>
20883 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
20884 inaccessible types. Fixes #36313.
20886 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
20888 * namespace.cs (NamespaceEntry): Create implicit entries for all
20889 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
20890 implicit entries for N1.N2 and N1.
20892 2003-07-08 Martin Baulig <martin@ximian.com>
20894 Rewrote the handling of namespaces to fix a lot of the issues
20895 wrt. `using' aliases etc.
20897 * namespace.cs (Namespace): Splitted this class into a
20898 per-assembly `Namespace' and a per-file `NamespaceEntry'.
20900 * typemanager.cs (TypeManager.IsNamespace): Removed.
20901 (TypeManager.ComputeNamespaces): Only compute namespaces from
20902 loaded assemblies here, not the namespaces from the assembly we're
20903 currently compiling.
20905 2003-07-08 Martin Baulig <martin@ximian.com>
20907 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
20909 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20911 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
20914 I thought about the memory savings here, but LookupTypeReflection
20915 is used under already very constrained scenarios. Compiling
20916 corlib or mcs only exposes one hit, so it would not really reduce
20917 any memory consumption.
20919 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20921 * typemanager.cs: fixes bug #45889 by only adding public types from
20922 other assemblies to the list of known types.
20924 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20926 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
20927 on the type we resolved.
20929 2003-07-05 Martin Baulig <martin@ximian.com>
20931 * pending.cs (PendingImplementation.ParentImplements): Don't
20932 create the proxy if the parent is abstract.
20934 * class.cs (TypeContainer.DefineIndexers): Process explicit
20935 interface implementations first. Fixes #37714.
20937 2003-07-04 Miguel de Icaza <miguel@ximian.com>
20939 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
20940 defined recursively; but since we modify the input parameters
20941 (left is set to `this' temporarily), we reset this value if the
20942 left_is_explicit is false, which gives the original semantics to
20945 * literal.cs (NullPointer): new class used to represent a null
20946 literal in a pointer context.
20948 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
20949 type is a pointer, use a NullPointer object instead of a
20950 NullLiteral. Closes 43687
20952 (ExplicitConversion): Convert pointer values using
20953 the conv opcode to the proper type.
20955 * ecore.cs (New): change ValueTypeVariable property into a method,
20956 that returns whether the valuetype is suitable for being used.
20958 * expression.cs (Binary.DoNumericPromotions): Only return if we
20959 the int constant was a valid uint, and we can return both left and
20960 right as uints. If not, we continue processing, to trigger the
20961 type conversion. This fixes 39018.
20963 * statement.cs (Block.EmitMeta): During constant resolution, set
20964 the CurrentBlock property on the emitcontext, so that we resolve
20965 constants propertly.
20967 2003-07-02 Martin Baulig <martin@ximian.com>
20969 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
20970 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
20972 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
20973 than emitting it here.
20975 * statement.cs: Fixed some more flow analysis bugs.
20977 2003-07-02 Martin Baulig <martin@ximian.com>
20979 * class.cs (MethodData.Define): When implementing interface
20980 methods, set Final unless we're Virtual.
20982 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
20983 check work for interface methods.
20985 2003-07-01 Martin Baulig <martin@ximian.com>
20987 * ecore.cs (EmitContext.This): Replaced this property with a
20988 GetThis() method which takes a Location argument. This ensures
20989 that we get the correct error location for a CS0188.
20991 2003-07-01 Miguel de Icaza <miguel@ximian.com>
20993 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
20994 ImplicitStandardConversion.
20996 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
20998 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21000 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21003 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21005 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21008 (MethodData.Define): Turn off initlocals for unsafe methods.
21010 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21012 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21013 complete; Fixes #37521.
21015 * delegate.cs: Use Modifiers.TypeAttr to compute the
21016 TypeAttributes, instead of rolling our own. This makes the flags
21017 correct for the delegates.
21019 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21021 * class.cs (Constructor.Define): Set the private flag for static
21022 constructors as well.
21024 * cs-parser.jay (statement_expression): Set the return value to
21025 null, to avoid a crash when we catch an error.
21027 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21029 * cs-parser.jay: Applied patch from Jackson that adds support for
21030 extern and unsafe modifiers to destructor declarations.
21032 * expression.cs: Report error 21 if the user is trying to index a
21035 * driver.cs: Add an error message, suggested by the bug report.
21037 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21038 if we do not have a ": this ()" constructor initializer. Fixes 45149
21040 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21042 * namespace.cs: Add some information to reduce FAQs.
21044 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21046 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21047 underlying enumeration types. Fixes #43915.
21049 * expression.cs: Treat ushort/short as legal values to be used in
21050 bitwise operations.
21052 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21054 * delegate.cs: transfer custom attributes for paramenters from
21055 the delegate declaration to Invoke and BeginInvoke.
21057 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21059 * attribute.cs: handle custom marshalers and emit marshal info
21062 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21064 * makefile.gnu: Added anonymous.cs to the compiler sources.
21066 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21068 * iterators.cs: Change the name of the proxy class to include two
21071 * cs-parser.jay: Update grammar to include anonymous methods.
21073 * anonymous.cs: new file.
21075 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21077 * class.cs (Field.Define): Add missing test for pointers and
21080 2003-05-27 Ravi Pratap <ravi@ximian.com>
21082 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21083 we use the stobj opcode.
21085 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21086 since it wasn't the correct fix.
21088 It still is puzzling that we are required to use stobj for IntPtr
21089 which seems to be a ValueType.
21091 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21093 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21094 during regular simple name resolution. Now, the trick is that
21095 instead of returning for processing the simplename, we do a
21096 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21097 contextual lookup type). If a match is found, return that, if
21098 not, return for further composition.
21100 This fixes long-standing 30485.
21102 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21103 using the address to initialize an object, do an Stobj instead of
21104 using the regular Stelem.
21106 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21107 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21108 Because if we are a BaseIndexerAccess that value will be true.
21111 * statement.cs (GotoCase.Resolve): Return after reporting an
21112 error, do not attempt to continue.
21114 * expression.cs (PointerArithmetic.Emit): If our operand is a
21115 long, convert our constants to match the operand before
21116 multiplying. Convert to I type before adding. Fixes 43670.
21118 2003-05-14 Ravi Pratap <ravi@ximian.com>
21120 * enum.cs (ImplicitConversionExists) : Rename to
21121 ImplicitEnumConversionExists to remove ambiguity.
21123 * ecore.cs (NullCast): New type of cast expression class which
21124 basically is very similar to EmptyCast with the difference being
21125 it still is a constant since it is used only to cast a null to
21127 (eg. (string) null)
21129 * convert.cs (ImplicitReferenceConversion): When casting a null
21130 literal, we return a NullCast.
21132 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21133 should be around anymore.
21135 The renaming (reported was slightly wrong). Corrections:
21137 ConvertImplicitStandard -> ImplicitConversionStandard
21138 ConvertExplicitStandard -> ExplicitConversionStandard
21140 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21141 before passing them in !
21143 * convert.cs (ImplicitConversionStandard): When comparing for
21144 equal expr and target types, ensure that expr is not a
21147 In general, we must not be checking (expr_type ==
21148 target_type) in the top level conversion methods
21149 (ImplicitConversion, ExplicitConversion etc). This checking is
21150 done in the methods that they delegate to.
21152 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21154 * convert.cs: Move Error_CannotConvertType,
21155 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21156 ImplicitNumericConversion, ImplicitConversionExists,
21157 ImplicitUserConversionExists, StandardConversionExists,
21158 FindMostEncompassedType, FindMostSpecificSource,
21159 FindMostSpecificTarget, ImplicitUserConversion,
21160 ExplicitUserConversion, GetConversionOperators,
21161 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21162 TryImplicitIntConversion, Error_CannotConvertImplicit,
21163 ConvertImplicitRequired, ConvertNumericExplicit,
21164 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21165 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21168 Perform the following renames:
21170 StandardConversionExists -> ImplicitStandardConversionExists
21171 ConvertImplicit -> ImplicitConversion
21172 ConvertImplicitStandard -> ImplicitStandardConversion
21173 TryImplicitIntConversion -> ImplicitIntConversion
21174 ConvertImplicitRequired -> ImplicitConversionRequired
21175 ConvertNumericExplicit -> ExplicitNumericConversion
21176 ConvertReferenceExplicit -> ExplicitReferenceConversion
21177 ConvertExplicit -> ExplicitConversion
21178 ConvertExplicitStandard -> ExplicitStandardConversion
21180 2003-05-19 Martin Baulig <martin@ximian.com>
21182 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21183 (TypeInfo): Added support for structs having structs as fields.
21185 * ecore.cs (FieldExpr): Implement IVariable.
21186 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21187 VariableInfo for the field.
21189 2003-05-18 Martin Baulig <martin@ximian.com>
21191 * expression.cs (This.DoResolve): Report a CS0027 if we're
21192 emitting a field initializer.
21194 2003-05-18 Martin Baulig <martin@ximian.com>
21196 * expression.cs (This.ResolveBase): New public function.
21197 (This.DoResolve): Check for CS0188.
21199 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21202 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21203 `instance_expression' to null if we don't have any non-static
21206 2003-05-18 Martin Baulig <martin@ximian.com>
21208 Reworked the way how local variables and parameters are handled by
21209 the flow analysis code.
21211 * statement.cs (TypeInfo, VariableMap): New public classes.
21212 (VariableInfo): New public class. This is now responsible for
21213 checking whether a variable has been assigned. It is used for
21214 parameters and local variables.
21215 (Block.EmitMeta): Take the InternalParameters as argument; compute
21216 the layout of the flow vectors here.
21217 (Block.LocalMap, Block.ParameterMap): New public properties.
21218 (FlowBranching): The .ctor doesn't get the InternalParameters
21219 anymore since Block.EmitMeta() now computes the layout of the flow
21221 (MyStructInfo): This class is now known as `StructInfo' and nested
21222 in `TypeInfo'; we don't access this directly anymore.
21224 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21225 property and removed IsAssigned(), IsFieldAssigned(),
21226 SetAssigned() and SetFieldAssigned(); we now call them on the
21227 VariableInfo so we don't need to duplicate this code everywhere.
21229 * expression.cs (ParameterReference): Added `Block block' argument
21231 (LocalVariableReference, ParameterReference, This): The new
21232 VariableInfo class is now responsible for all the definite
21235 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21236 IsParameterAssigned, SetParameterAssigned): Removed.
21238 2003-05-18 Martin Baulig <martin@ximian.com>
21240 * typemanager.cs (InitCoreTypes): Try calling
21241 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21242 the 3-args-version. Corlib now also needs our `void_type'.
21243 (GetMethod): Added overloaded version which takes an optional
21244 `bool report_errors' to allow lookups of optional methods.
21246 2003-05-12 Martin Baulig <martin@ximian.com>
21248 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21249 only used for locals and not for parameters.
21251 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21253 * support.cs (InternalParameters.ParameterType): Return the
21254 ExternalType of the parameter.
21256 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21259 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21261 * class.cs (MethodData.Define): Do not set the `newslot' on
21262 interface members, if they are also flagged as "override".
21264 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21265 better code for ++i and i++. This only works for static fields
21266 and local variables.
21268 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21269 want to pull the DeclSpace out of the builder_to_declspace instead
21270 of the TypeBuilder (like in TypeContainer.FindMembers).
21272 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21273 instead of LookupTypeContainer. Fixes the crash on .NET for
21274 looking up interface members.
21276 * const.cs: Create our own emit context during the Definition
21277 stage, so that constants are evaluated in the proper context, when
21278 a recursive definition happens.
21280 2003-05-11 Martin Baulig <martin@ximian.com>
21282 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21283 new block for a switch section.
21284 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21285 the adding/lookup in the switch block. Fixes #39828.
21287 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21289 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21290 functionality: I needed to convert the data after I had performed
21291 the add/sub operation into the operands type size.
21293 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21294 pass the type for the box operation, otherwise the resulting
21295 object would have been of type object.
21297 (BoxedCast): Add constructor to specify the type to box as.
21299 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21301 * iterators.cs: I was reusing the `count' variable inadvertently,
21302 take steps to not allow this to happen.
21304 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21306 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21307 by creating an array at the point where the params starts and
21308 putting all those arguments there, then adjusting the size of the
21311 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21313 * expression.cs (New.AddressOf): Implement interface
21314 IMemoryLocation. This is used when the `new' operator is used in
21315 the context of an invocation to a method on a value type.
21317 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21320 * namespace.cs: Also check the using aliases here.
21322 * driver.cs: Move the test for using validity after the types have
21323 been entered, so we do a single pass that also includes the using
21326 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21327 in the regular case. CreateSiblingForFinally is doing extra
21330 * attribute.cs (GetAttributeArgumentExpression): Store the result
21331 on an out value, and use the return value to indicate failure
21332 instead of using null (which is a valid return for Constant.GetValue).
21334 * statement.cs: Perform the analysis flow for the increment
21335 portion after the statement, because this will be the real flow of
21336 execution. Fixes #42385
21338 * codegen.cs (EmitContext.EmitArgument,
21339 EmitContext.EmitStoreArgument): New helper functions when the
21340 RemapToProxy flag is set.
21342 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21345 Add support for remapping parameters.
21347 * iterators.cs: Propagate parameter values; Store parameter
21348 values in the proxy classes.
21350 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21352 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21353 need a proxy reference; I do not know what I was thinking
21355 * cs-parser.jay (constructor_initializer): catch another error,
21356 and display nice message.
21358 (field_declaration): catch void field declaration
21359 to flag a better error.
21361 * class.cs (MemberBase.CheckBase): Report an error instead of a
21362 warning if a new protected member is declared in a struct.
21363 (Field.Define): catch the error of readonly/volatile.
21365 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21367 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21368 volatile variable is taken
21370 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21372 * statement.cs (Fixed.Resolve): Report an error if we are not in
21375 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21377 * typemanager.cs: reuse the code that handles type clashes for
21378 delegates and enumerations.
21380 * class.cs (Report28): Always report.
21382 * expression.cs (EncodeAsAttribute): Allow nulls here.
21384 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21386 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21387 the functionality for testing whether an expression is valid for
21388 an attribute here. Also handle the case of arrays of elements
21391 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21392 encoding a linear array into an array of objects that are suitable
21393 to be passed to an CustomAttributeBuilder.
21395 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21397 * ecore.cs: (FieldExpr): Handle field remapping here.
21399 * iteratators.cs: Pass the instance variable (if the method is an
21400 instance method) to the constructors, so we can access the field
21401 variables on the class.
21403 TODO: Test this with structs. I think the THIS variable on
21404 structs might have to be a pointer, and not a refenrece
21406 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21408 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21409 local variables to fields in a proxy class.
21411 * iterators.cs (PopulateProxy): Rename our internal fields to
21413 Create a <THIS> field if we are an instance method, so we can
21414 reference our parent container variables.
21415 (MapVariable): Called back from the EmitContext code to enter a
21416 new variable to field mapping into the proxy class (we just create
21420 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21421 for using the remapped locals to fields.
21423 I placed the code here, because that gives the same semantics to
21424 local variables, and only changes the Emit code.
21426 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21427 statements inside iterators.
21428 (VariableInfo): Add a FieldBuilder for the cases when we are
21429 remapping local variables to fields in a proxy class
21431 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21432 current_block != null.
21434 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21435 not cope with strings, as it has been moved to the
21436 TableSwitchEmit. Fixed bug in switch generation.
21438 * expression.cs (New.DoResolve): Provide more context for the user
21439 when reporting an error.
21441 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21444 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21445 check the permissions for it. Note than in a type-resolution
21446 context the check was already present in DeclSpace.ResolveType,
21447 but was missing from the MemberAccess.
21449 (ArrayCreation.CheckIndices): warn if the user has
21450 more nested levels of expressions, but there are no more
21451 dimensions specified. Avoids crash on bug 41906.
21453 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21455 * statement.cs (Block): replace Implicit bool, for a generic
21457 New flag: `Unchecked'. This is used during the EmitMeta phase
21458 (which is out-of-line with the regular Resolve/Emit process for a
21459 statement, as this is done ahead of time, but still gets a chance
21460 to call constant resolve).
21462 (Block.Flags): new enum for adding a new flag.
21464 (Block.EmitMeta): track the state of unchecked.
21466 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21467 to enable constant resolution to work there as well.
21469 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21471 * typemanager.cs (ienumerable_type): Also look up
21472 System.Collections.IEnumerable.
21474 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21476 TODO: Test more than one conditional per method.
21478 * class.cs (Indexer.Define): Report the location where the user is
21479 referencing the unsupported feature.
21481 (MethodData): Overload the use of `conditionals' to
21482 minimize the creation of needless ArrayLists. This saves roughly
21483 212kb on my machine.
21485 (Method): Implement the new IIteratorContainer interface.
21486 (Method.SetYields): Implement the method by setting the ModFlags
21487 to contain METHOD_YIELDS.
21489 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
21490 which just got set to null.
21492 * iterators.cs: New file.
21494 (Yield, YieldBreak): New statements.
21496 * statement.cs (Return.Resolve): Flag an error if we are used in
21497 an iterator method.
21499 * codegen.cs (InIterator): New flag set if the code is being
21500 compiled in an iterator method.
21502 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
21503 internal modifier, and we just use it to avoid adding extra
21504 fields, as this is seldom used.
21506 * cs-parser.jay: Add yield_statement (yield and yield break).
21508 * driver.cs: New flag -v2 to turn on version 2 features.
21510 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
21511 hashtable when v2 is enabled.
21513 2003-04-20 Miguel de Icaza <miguel@ximian.com>
21515 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
21516 there is already a namespace defined with this name.
21518 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
21519 people upgraded their corlibs.
21521 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
21522 always use fully qualified types, no need to use the compiler
21525 (TypeManager.IsNamespace): Use binarysearch.
21527 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
21528 AddDelegate): I did not quite use the new IsValid API properly: I
21529 have to pass the short-name and the fullname. I was passing only
21530 the basename instead of the fullname sometimes.
21532 (TypeContainer.DefineType): call NamespaceClash.
21534 * interface.cs (Interface.DefineType): use NamespaceClash before
21537 * delegate.cs (Delegate.DefineType): use NamespaceClash before
21540 * enum.cs: (Enum.DefineType): use NamespaceClash before
21543 * typemanager.cs (: 3-line patch that gives us some tasty 11%
21544 speed increase. First, use the negative_hits cache when we get a
21545 negative. Second, add the type with its full original name
21546 instead of the new . and + encoded name (reflection uses + to
21547 separate type from a nested type). Use LookupTypeReflection
21548 directly which bypasses the type->name hashtable (that we already
21549 know does not contain the type.
21551 * decl.cs (DeclSpace.ResolveTypeExpr): track the
21552 location/container type.
21554 * driver.cs: When passing utf8, use directly the UTF8Encoding.
21556 2003-04-19 Miguel de Icaza <miguel@ximian.com>
21558 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
21560 * delegate.cs (NewDelegate.Resolve): Test whether an instance
21561 method is being referenced in the method group from a static
21562 context, and report error 120 if so.
21564 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
21567 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
21568 is created, we create the A namespace).
21570 * cs-parser.jay: A namespace also introduces a DeclarationFound.
21573 2003-04-18 Miguel de Icaza <miguel@ximian.com>
21575 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
21576 invocation to ModuleBuilder.GetType with the same values will
21577 return a new type instance, so we need to cache its return
21580 * expression.cs (Binary.ResolveOperator): Only allow the compare
21581 operators on enums if they are of the same type.
21583 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
21584 types of ValueType on their own case. Before we were giving them
21585 the same treatment as objects.
21587 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
21588 fullname. Short name is used to compare against container name.
21589 Fullname is used to check against defined namespace names.
21591 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
21592 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
21594 (Method.CheckBase): Call parent.
21595 (MemberBase.CheckBase): Check for protected members on sealed
21597 (PropertyBase.CheckBase): Call parent.
21598 (Field.Define): Call parent.
21600 * report.cs: Negative error codes are now mapped to 8000 - code,
21601 so that the display is render more nicely.
21603 * typemanager.cs: Do not use try/catch, instead report a regular
21606 (GetPointerType, GetReferenceType): These methods provide
21607 mechanisms to obtain the T* and T& from a T. We had the code
21608 previously scattered around the code base, and it also used
21609 TypeManager.LookupType that would go through plenty of caches.
21610 This one goes directly to the type source.
21612 In some places we did the Type.GetType followed by
21613 ModuleBuilder.GetType, but not in others, so this unifies the
21614 processing as well.
21616 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
21617 statements now that we have namespace information.
21619 * typemanager.cs (IsNamespace): New method, returns whether the
21620 string presented is a namespace or not.
21622 (ComputeNamespaces): New public entry point, computes the list of
21623 available namespaces, using the GetNamespaces API call in Mono, or
21624 the slower version in MS.NET.
21626 Now before we start the semantic analysis phase, we have a
21627 complete list of namespaces including everything that the user has
21630 Deleted old code to cache namespaces in .nsc files.
21632 2003-04-17 Miguel de Icaza <miguel@ximian.com>
21634 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
21635 class/struct location definition Location for the implicit
21636 constructor location.
21638 (Operator.Define): Use the location of the operator for the
21639 implicit Method definition.
21641 (Constructor.Emit): use the constructor location for the implicit
21642 base initializer constructor.
21644 * ecore.cs: Remove ITypeExpression. This interface is now gone,
21645 and the Expression class now contains two new methods:
21647 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
21648 isolate type lookup from the rest of the resolution process.
21650 Since we use Expressions to hold type definitions due to the way
21651 we parse the input we have historically overloaded Resolve to
21652 perform the Type lookups if a special flag is passed. Now this is
21653 eliminated and two methods take their place.
21655 The differences in the two methods between xStep and xTerminal is
21656 that xStep is involved in our current lookup system that uses
21657 SimpleNames to compose a name, while xTerminal is used just to
21658 catch the case where the simplename lookup failed.
21660 2003-04-16 Miguel de Icaza <miguel@ximian.com>
21662 * expression.cs (ResolveMemberAccess): Remove redundant code.
21663 TypeExpr expressions are always born fully resolved.
21665 * interface.cs (PopulateMethod): Do not lookup the types twice.
21666 We were doing it once during SemanticAnalysis and once during
21669 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
21670 in local variable type definitions, were being returned as a
21671 SimpleName (we decomposed everything into a string), that is
21672 because primary_expression was being used instead of a type in the
21673 grammar (reduce/reduce conflicts).
21675 The part that was wrong is that we converted the expression into a
21676 string (an oversimplification in one hand, compounded with primary
21677 expressions doing string concatenation).
21683 Would return "A.B.C[]" as a SimpleName. This stopped things like
21684 using clauses from working on this particular context. And a type
21685 was being matched directly against "A.B.C[]".
21687 We now use the correct approach, and allow for ComposedCast to be
21688 part of the unary expression. So the "A.B.C []" become a composed
21689 cast of "A.B.C" (as a nested group of MemberAccess with a
21690 SimpleName at the end) plus the rank composition "[]".
21694 2003-04-10 Miguel de Icaza <miguel@ximian.com>
21696 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
21697 for the access level checking.
21699 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
21700 `TypeContainer container', because I kept getting confused when I
21701 was debugging this code.
21703 * expression.cs (Indexers): Instead of tracking getters/setters,
21704 we now track them in parallel. We create one arraylist less, but
21705 most importantly it is possible now for the LValue code to find a
21706 matching get for a set.
21708 (IndexerAccess.DoResolveLValue): Update the code.
21709 GetIndexersForType has been modified already to extract all the
21710 indexers from a type. The code assumed it did not.
21712 Also make the code set the correct return type for the indexer.
21713 This was fixed a long time ago for properties, but was missing for
21714 indexers. It used to be void_type.
21716 (Binary.Emit): Test first for doubles instead of
21717 floats, as they are more common.
21719 (Binary.EmitBranchable): Use the .un version of the branch opcodes
21720 when dealing with floats and the <=, >= operators. This fixes bug
21723 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
21724 to load the array value by emitting a load on the foreach variable
21725 type. This was incorrect.
21727 We now emit the code to load an element using the the array
21728 variable type, and then we emit the conversion operator.
21732 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
21734 * attribute.cs: Avoid allocation of ArrayLists in the common case.
21736 2003-04-09 Miguel de Icaza <miguel@ximian.com>
21738 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
21739 test for protection before we test for signatures.
21741 (MethodSignature.ToString): implement.
21743 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
21744 to the case where we reduced into a LongConstant.
21746 * decl.cs (CheckAccessLevel): If the type is an array, we can not
21747 depend on whether the information is acurrate, because the
21748 Microsoft runtime will always claim that the array type is public,
21749 regardless of the real state.
21751 If the type is a pointer, another problem happens: the type is
21752 reported as non-public in Microsoft.
21754 In both cases we have to call CheckAccessLevel recursively with
21755 the underlying type as the argument to be tested.
21757 2003-04-08 Miguel de Icaza <miguel@ximian.com>
21759 * assign.cs (Assign.Emit): If we are dealing with a compound
21760 assignment expression, we should use the code path that stores the
21761 intermediate result in a temporary value. This fixes #40903.
21763 *expression.cs (Indirection.ToString): Provide ToString method for
21766 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
21768 * class.cs: Null out fields holding references to Block objects so
21769 they can be garbage collected.
21771 * expression.cs (OverloadResolve): Remove unused local.
21773 2003-04-07 Martin Baulig <martin@ximian.com>
21775 * codegen.cs (EmitContext.CurrentFile): New public field.
21776 (EmitContext.Mark): Use the CurrentFile to check whether the
21777 location is in the correct file.
21778 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
21780 2003-04-07 Martin Baulig <martin@ximian.com>
21782 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
21784 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
21785 location. [FIXME: The location argument which gets passed to this
21786 method is sometimes wrong!]
21788 2003-04-07 Nick Drochak <ndrochak@gol.com>
21790 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
21792 2003-04-07 Miguel de Icaza <miguel@ximian.com>
21794 * expression.cs (Indirection.EmitAssign): We were using the
21795 temporary, but returning immediately instead of continuing the
21798 2003-04-06 Martin Baulig <martin@ximian.com>
21800 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
21801 if it's a nested child, but also deriving from the outer class.
21804 * typemanager.cs (IsNestedChildOf): Make this work if it's a
21805 nested child, but also deriving from the outer class. See
21807 (FilterWithClosure): We may access private members of the outer
21808 class if we're a nested child and deriving from the outer class.
21809 (RealMemberLookup): Only set `closure_private_ok' if the
21810 `original_bf' contained BindingFlags.NonPublic.
21812 2003-04-05 Martin Baulig <martin@ximian.com>
21814 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
21816 2003-04-02 Miguel de Icaza <miguel@ximian.com>
21818 * class.cs (Event.Define): Do not allow abstract events to have
21821 2003-04-01 Miguel de Icaza <miguel@ximian.com>
21823 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
21824 block in event declarations.
21826 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
21827 value type, get its address.
21829 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
21830 leaving a class on the stack instead of a boolean value (int
21831 0/1). Change the code so we compare against null, and then the
21832 result against zero.
21834 * class.cs (TypeContainer.GetClassBases): We were checking for the
21835 parent class being sealed too late.
21837 * expression.cs (Binary.Emit): For <= and >= when dealing with
21838 floating point values, use cgt.un and clt.un instead of cgt and
21841 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
21843 * statement.cs: Apply the same optimization as MS: skip the
21844 GetEnumerator returning an IEnumerator, and use the one returning a
21845 CharEnumerator instead. This allows us to avoid the try-finally block
21848 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
21850 * cs-parser.jay: Attributes cannot be applied to
21851 namespaces. Fixes #40473
21853 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21856 (Add*): check if the name is valid using the full name for constants,
21857 fields, properties and events.
21859 2003-03-28 Miguel de Icaza <miguel@ximian.com>
21861 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
21862 char constants to be part of the enumeration.
21864 * expression.cs (Conditional.DoResolve): Add support for operator
21865 true. Implements the missing functionality from 14.12
21867 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
21868 operator true/false as required by the spec.
21870 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
21871 implicit conversion to boolean.
21873 * statement.cs (Statement.ResolveBoolean): A boolean expression is
21874 also one where the type implements `operator true'.
21876 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
21877 get an expression that will invoke operator true based on an
21880 (GetConversionOperators): Removed the hack that called op_True
21883 (Expression.ResolveBoolean): Move this from Statement.
21885 2003-03-17 Miguel de Icaza <miguel@ximian.com>
21887 * ecore.cs (FieldExpr): do not allow initialization of initonly
21888 fields on derived classes
21890 2003-03-13 Martin Baulig <martin@ximian.com>
21892 * statement.cs (Block.Emit): Call ig.BeginScope() and
21893 ig.EndScope() when compiling with debugging info; call
21894 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
21896 2003-03-08 Miguel de Icaza <miguel@ximian.com>
21898 * expression.cs (Indexers): Do not construct immediately, allow
21899 for new members to be appended as we go. Fixes 38143
21901 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21903 * expression.cs: save/restore context when resolving an unchecked
21906 2003-03-05 Miguel de Icaza <miguel@ximian.com>
21908 * cfold.cs: Catch division by zero in modulus operator during
21911 2003-03-03 Miguel de Icaza <miguel@ximian.com>
21913 * interface.cs (Interface.DefineMembers): Avoid defining members
21916 2003-02-27 Miguel de Icaza <miguel@ximian.com>
21918 * driver.cs: handle the +/- options for -noconfig
21920 * statement.cs (Unckeched.Resolve): Also track the state of
21921 unchecked in the Resolve phase.
21923 2003-02-27 Martin Baulig <martin@ximian.com>
21925 * ecore.cs (Expression.MemberLookup): Don't create a
21926 MethodGroupExpr for something which is not a method. Fixes #38291.
21928 2003-02-25 Miguel de Icaza <miguel@ximian.com>
21930 * class.cs (MemberBase.CheckParameters): Also check that the type
21931 is unmanaged if it is a pointer.
21933 * expression.cs (SizeOf.Resolve): Add location information.
21935 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
21936 a managed type is declared.
21938 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
21939 parameter modifiers as well. Fixes bug 38606
21941 * class.cs: Very sad. Am backing out the speed up changes
21942 introduced by the ArrayList -> Array in the TypeContainer, as they
21943 were not actually that much faster, and introduced a bug (no error
21944 reports on duplicated methods).
21946 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
21947 source first, this will guarantee that we have a valid expression
21948 before calling in lower levels functions that will require a
21949 resolved object. Then use this original_source in the
21950 target.ResolveLValue instead of the original source that was
21953 Another change. Use target.Resolve instead of LValueResolve.
21954 Although we are resolving for LValues, we will let the Assign code
21955 take care of that (it will be called again from Resolve). This
21956 basically allows code like this:
21958 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
21959 class Y { void A (X x) { x [0] += o; }
21961 The problem was that the indexer was trying to resolve for
21962 set_Item (idx, object o) and never finding one. The real set_Item
21963 was set_Item (idx, X). By delaying the process we get the right
21968 2003-02-23 Martin Baulig <martin@ximian.com>
21970 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
21971 while calling DoEmit ().
21973 * codegen.cs (EmitContext.Mark): Don't mark locations in other
21974 source files; if you use the #line directive inside a method, the
21975 compiler stops emitting line numbers for the debugger until it
21976 reaches the end of the method or another #line directive which
21977 restores the original file.
21979 2003-02-23 Martin Baulig <martin@ximian.com>
21981 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
21983 2003-02-23 Martin Baulig <martin@ximian.com>
21985 * statement.cs (Block.AddChildVariableNames): We need to call this
21986 recursively, not just for our immediate children.
21988 2003-02-23 Martin Baulig <martin@ximian.com>
21990 * class.cs (Event.Define): Always make the field private, like csc does.
21992 * typemanager.cs (TypeManager.RealMemberLookup): Make events
21993 actually work, fixes bug #37521.
21995 2003-02-23 Miguel de Icaza <miguel@ximian.com>
21997 * delegate.cs: When creating the various temporary "Parameters"
21998 classes, make sure that we call the ComputeAndDefineParameterTypes
21999 on those new parameters (just like we do with the formal ones), to
22000 allow them to be resolved in the context of the DeclSpace.
22002 This fixes the bug that Dick observed in Bugzilla #38530.
22004 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22006 * expression.cs (ResolveMemberAccess): When resolving a constant,
22007 do not attempt to pull a constant if the value was not able to
22008 generate a valid constant.
22010 * const.cs (LookupConstantValue): Do not report more errors than required.
22012 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22014 * expression.cs: fixes bug #38328.
22016 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22018 * class.cs: Changed all the various members that can be part of a
22019 class from being an ArrayList to be an Array of the right type.
22020 During the DefineType type_list, interface_list, delegate_list and
22021 enum_list are turned into types, interfaces, delegates and enums
22024 And during the member population, indexer_list, event_list,
22025 constant_list, field_list, instance_constructor_list, method_list,
22026 operator_list and property_list are turned into their real arrays.
22028 Although we could probably perform this operation earlier, for
22029 good error reporting we need to keep the lists and remove the
22030 lists for longer than required.
22032 This optimization was triggered by Paolo profiling the compiler
22033 speed on the output of `gen-sample-program.pl' perl script.
22035 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22036 not crash in methods like MemberLookupFailed that use this field.
22038 This problem arises when the compiler fails to resolve a type
22039 during interface type definition for example.
22041 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22043 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22044 inherit from System.Object, so we have to stop at null, not only
22045 when reaching System.Object.
22047 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22049 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22050 DeclaredOnly because the parent indexer might have had a different
22051 name, but did not loop until the top of the hierarchy was reached.
22053 The problem this one fixes is 35492: when a class implemented an
22054 indexer from an interface, we were getting the interface method
22055 (which was abstract) and we were flagging an error (can not invoke
22058 This also keeps bug 33089 functioning, and test-148 functioning.
22060 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22061 out if a method is special is to see if it is declared in a
22062 property or event, or whether it is one of the predefined operator
22063 names. This should fix correctly #36804.
22065 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22067 The goal here is to remove the dependency on EmptyCast.Peel ().
22068 Killing it completely.
22070 The problem is that currently in a number of places where
22071 constants are expected, we have to "probe" for an EmptyCast, and
22072 Peel, which is not the correct thing to do, as this will be
22073 repetitive and will likely lead to errors.
22075 The idea is to remove any EmptyCasts that are used in casts that
22076 can be reduced to constants, so we only have to cope with
22079 This bug hunt was triggered by Bug 37363 and the desire to remove
22080 the duplicate pattern where we were "peeling" emptycasts to check
22081 whether they were constants. Now constants will always be
22084 * ecore.cs: Use an enumconstant here instead of wrapping with
22087 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22088 throwing me off. By handling this we can get rid of a few hacks.
22090 * statement.cs (Switch): Removed Peel() code.
22092 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22094 * class.cs: Location information for error 508
22096 * expression.cs (New.DoResolve): Add a guard against double
22097 resolution of an expression.
22099 The New DoResolve might be called twice when initializing field
22100 expressions (see EmitFieldInitializers, the call to
22101 GetInitializerExpression will perform a resolve on the expression,
22102 and later the assign will trigger another resolution
22104 This leads to bugs (#37014)
22106 * delegate.cs: The signature for EndInvoke should contain any ref
22107 or out parameters as well. We were not doing this in the past.
22109 * class.cs (Field.Define): Do not overwrite the type definition
22110 inside the `volatile' group. Turns out that volatile enumerations
22111 were changing the type here to perform a validity test, which
22114 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22116 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22117 and structs, we do not want to load the instance variable
22119 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22120 enum_type has to be handled like an object reference (implicit
22121 conversions exists from this to object), but the regular IsClass
22122 and IsValueType tests will never return true for this one.
22124 Also we use TypeManager.IsValueType instead of type.IsValueType,
22125 just for consistency with the rest of the code (this is only
22126 needed if we ever use the construct exposed by test-180.cs inside
22127 corlib, which we dont today).
22129 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22131 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22134 2003-02-09 Martin Baulig <martin@ximian.com>
22136 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22137 (Namespace.DefineNamespaces): New static public method; this is
22138 called when we're compiling with debugging to add all namespaces
22139 to the symbol file.
22141 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22142 pass it to the Namespace's .ctor.
22144 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22145 and MethodBase arguments; pass the namespace ID to the symwriter;
22146 pass the MethodBase instead of the token to the symwriter.
22147 (SymbolWriter.DefineNamespace): New method to add a namespace to
22150 2003-02-09 Martin Baulig <martin@ximian.com>
22152 * symbolwriter.cs: New file. This is a wrapper around
22153 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22154 methods here in near future.
22156 2003-02-09 Martin Baulig <martin@ximian.com>
22158 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22159 ILGenerator.MarkSequencePoint() which are actually used by the
22162 2003-02-09 Martin Baulig <martin@ximian.com>
22164 * location.cs (SourceFile): New public sealed class. This
22165 contains the name and an index which is used in the location's token.
22166 (Location): Reserve an appropriate number of bits in the token for
22167 the source file instead of walking over that list, this gives us a
22168 really huge performance improvement when compiling with debugging.
22170 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22171 `SourceFile' argument instead of a string.
22172 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22173 but don't parse/tokenize here, we need to generate the list of all
22174 source files before we do that.
22175 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22178 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22179 instead of a string.
22181 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22184 2003-02-09 Martin Baulig <martin@ximian.com>
22186 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22187 filename on `#line default'.
22189 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22191 * statement.cs: don't clear the pinned var when the fixed statement
22192 returns from the method (fixes bug#37752).
22194 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22196 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22199 2003-02-07 Martin Baulig <martin@ximian.com>
22201 * driver.cs: Removed the `--debug-args' command line argument.
22203 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22204 automatically by the AsssemblyBuilder.
22205 (CodeGen.InitializeSymbolWriter): We don't need to call any
22206 initialization function on the symbol writer anymore. This method
22207 doesn't take any arguments.
22209 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22211 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22212 from referenced assemblies as well.
22214 2003-02-02 Martin Baulig <martin@ximian.com>
22216 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22218 2003-02-02 Martin Baulig <martin@ximian.com>
22220 * class.cs (Constructor.Emit): Open the symbol writer before
22221 emitting the constructor initializer.
22222 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22223 single-stepping through constructor initializers.
22225 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22227 * class.cs: Handle error 549: do not allow virtual methods in
22230 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22232 * decl.cs: Check access levels when resolving types
22234 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22236 * statement.cs: Add parameters and locals set in catch blocks that might
22237 return to set vector
22239 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22241 * class.cs (Operator): Set the SpecialName flags for operators.
22243 * expression.cs (Invocation.DoResolve): Only block calls to
22244 accessors and operators on SpecialName methods.
22246 (Cast.TryReduce): Handle conversions from char constants.
22249 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22251 * statement.cs: small memory and time optimization in FlowBranching.
22253 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22255 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22256 problem that the last fix but in the other sid (Set).
22258 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22259 access when there is no indexer in the hierarchy.
22261 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22263 * class.cs: Combine some if statements.
22265 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22267 * driver.cs: fixed bug #37187.
22269 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22271 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22272 any indexer, it's needed to build a list with all the indexers in the
22273 hierarchy (AllGetters), else we have problems. Fixes #35653.
22275 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22277 * class.cs (MethodData.Define): It is wrong for an interface
22278 implementation to be static in both cases: explicit and implicit.
22279 We were only handling this in one case.
22281 Improve the if situation there to not have negations.
22283 * class.cs (Field.Define): Turns out that we do not need to check
22284 the unsafe bit on field definition, only on usage. Remove the test.
22286 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22288 * driver.cs: use assembly.Location instead of Codebase (the latest
22289 patch made mcs fail when using MS assemblies).
22291 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22293 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22294 get the path to *corlib.dll.
22296 2003-01-21 Nick Drochak <ndrochak@gol.com>
22300 * typemanager.cs: Remove compiler warnings
22302 2003-01-20 Duncan Mak <duncan@ximian.com>
22304 * AssemblyInfo.cs: Bump the version number to 0.19.
22306 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22308 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22310 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22312 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22314 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22316 * cs-parser.jay: Small fix: we were not comparing the constructor
22317 name correctly. Thanks to Zoltan for the initial pointer.
22319 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22321 * cs-tokenizer.cs: Set file name when specified with #line
22323 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22325 * cs-parser.jay: Only perform the constructor checks here if we
22326 are named like the class; This will help provider a better
22327 error. The constructor path is taken when a type definition is
22328 not found, but most likely the user forgot to add the type, so
22329 report that rather than the constructor error.
22331 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22333 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22336 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22338 * cs-parser.jay: Add cleanup call.
22340 2003-01-13 Duncan Mak <duncan@ximian.com>
22342 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22343 consistent with other methods.
22345 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22347 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22349 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22351 * attribute.cs: only set GuidAttr to true when we have a
22354 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22358 * typemanager.cs: fixes to allow mcs compile corlib with the new
22359 Type.IsSubclassOf fix.
22361 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22363 * expression.cs (LocalVariableReference.DoResolve): Classify a
22364 constant as a value, not as a variable. Also, set the type for
22367 * cs-parser.jay (fixed_statement): take a type instead of a
22368 pointer_type, so we can produce a better error message later.
22370 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22373 (For.DoEmit): Make inifinite loops have a
22374 non-conditional branch back.
22376 (Fixed.DoEmit): First populate the pinned variables, then emit the
22377 statement, then clear the variables. Before I was emitting the
22378 code once for each fixed piece.
22381 2003-01-08 Martin Baulig <martin@ximian.com>
22383 * statement.cs (FlowBranching.MergeChild): A break in a
22384 SWITCH_SECTION does not leave a loop. Fixes #36155.
22386 2003-01-08 Martin Baulig <martin@ximian.com>
22388 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22389 lives in the same number space than `param_map'. Fixes #36154.
22391 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22393 * cs-parser.jay (constructor_declaration): Set the
22394 Constructor.ModFlags before probing for it. This makes the
22395 compiler report 514, 515 and 132 (the code was there, but got
22398 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22399 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22400 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22402 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22404 * enum.cs: create the enum static fields using the enum type.
22406 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22408 * class.cs: don't try to create the ParamBuilder for the return
22409 type if it's not needed (and handle it breaking for the ms runtime
22412 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22414 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22416 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22418 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22419 the command. This showed up while compiling the JANET source
22420 code, which used \r as its only newline separator.
22422 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22424 * class.cs (Method.Define): If we are an operator (because it
22425 reuses our code), then set the SpecialName and HideBySig. #36128
22427 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22429 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22430 exception, report error 120 `object reference required'.
22432 * driver.cs: Add --pause option, used during to measure the size
22433 of the process as it goes with --timestamp.
22435 * expression.cs (Invocation.DoResolve): Do not allow methods with
22436 SpecialName to be invoked.
22438 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22440 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22441 number before adding it.
22443 2002-12-21 Ravi Pratap <ravi@ximian.com>
22445 * ecore.cs (StandardImplicitConversion): When in an unsafe
22446 context, we allow conversion between void * to any other pointer
22447 type. This fixes bug #35973.
22449 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22451 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22452 is not thrown when extensionless outputs are used
22454 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22456 * rootcontext.cs: fixed compilation of corlib.
22458 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22460 * attribute.cs (Attributes.Contains): Add new method.
22462 * class.cs (MethodCore.LabelParameters): if the parameter is an
22463 `out' parameter, check that no attribute `[In]' has been passed.
22465 * enum.cs: Handle the `value__' name in an enumeration.
22467 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22469 * decl.cs: Added special case to allow overrides on "protected
22472 2002-12-18 Ravi Pratap <ravi@ximian.com>
22474 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22475 since it makes much more sense.
22477 (Attributes.ctor): Don't require a Location parameter.
22479 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22481 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22482 since we already have that information per attribute.
22484 * everywhere : make appropriate changes.
22486 * class.cs (LabelParameters): Write the code which actually
22487 applies attributes to the return type. We can't do this on the MS
22488 .NET runtime so we flag a warning in the case an exception is
22491 2002-12-18 Miguel de Icaza <miguel@ximian.com>
22493 * const.cs: Handle implicit null conversions here too.
22495 2002-12-17 Ravi Pratap <ravi@ximian.com>
22497 * class.cs (MethodCore.LabelParameters): Remove the extra
22498 Type [] parameter since it is completely unnecessary. Instead
22499 pass in the method's attributes so that we can extract
22500 the "return" attribute.
22502 2002-12-17 Miguel de Icaza <miguel@ximian.com>
22504 * cs-parser.jay (parse): Use Report.Error to flag errors instead
22505 of ignoring it and letting the compile continue.
22507 * typemanager.cs (ChangeType): use an extra argument to return an
22508 error condition instead of throwing an exception.
22510 2002-12-15 Miguel de Icaza <miguel@ximian.com>
22512 * expression.cs (Unary.TryReduce): mimic the code for the regular
22513 code path. Perform an implicit cast in the cases where we can
22514 implicitly convert to one of the integral types, and then reduce
22515 based on that constant. This fixes bug #35483.
22517 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22519 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
22521 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22523 * namespace.cs: fixed bug #35489.
22525 2002-12-12 Miguel de Icaza <miguel@ximian.com>
22527 * class.cs: Remove some dead code.
22529 * cs-parser.jay: Estimate the number of methods needed
22530 (RootContext.MethodCount);
22532 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
22533 numbers instead of StringBuilders.
22535 * support.cs (PtrHashtable): Add constructor with initial size;
22536 We can now reduce reallocations of the method table.
22538 2002-12-10 Ravi Pratap <ravi@ximian.com>
22540 * attribute.cs (ApplyAttributes): Keep track of the emitted
22541 attributes on a per-target basis. This fixes bug #35413.
22543 2002-12-10 Miguel de Icaza <miguel@ximian.com>
22545 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
22546 default to the Windows 1252 encoding.
22548 (UnixParseOption): Support version, thanks to Alp for the missing
22551 * AssemblyInfo.cs: Add nice assembly information.
22553 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
22556 * cs-parser.jay: Allow a trailing comma before the close bracked
22557 in the attribute_section production.
22559 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
22560 address of the instance was being taken, I will take this out,
22561 because we take the address of the object immediately here.
22563 2002-12-09 Ravi Pratap <ravi@ximian.com>
22565 * typemanager.cs (AreMultipleAllowed): Take care of the most
22566 obvious case where attribute type is not in the current assembly -
22569 2002-12-08 Miguel de Icaza <miguel@ximian.com>
22571 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
22572 definitions, instead of doing that afterwards.
22574 Also we use a nice little hack, depending on the constructor, we
22575 know if we are a "composed" name or a simple name. Hence, we
22576 avoid the IndexOf test, and we avoid
22578 * codegen.cs: Add code to assist in a bug reporter to track down
22579 the source of a compiler crash.
22581 2002-12-07 Ravi Pratap <ravi@ximian.com>
22583 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
22584 types have been emitted for a given element and flag an error
22585 if something which does not have AllowMultiple set is used more
22588 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
22589 attribute types and their corresponding AllowMultiple properties
22591 (AreMultipleAllowed): Check the property for a given type.
22593 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
22594 property in the case we have a TypeContainer.
22596 (Attributes.AddAttribute): Detect duplicates and just skip on
22597 adding them. This trivial fix catches a pretty gross error in our
22598 attribute emission - global attributes were being emitted twice!
22600 Bugzilla bug #33187 is now fixed.
22602 2002-12-06 Miguel de Icaza <miguel@ximian.com>
22604 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
22605 instead of pp_and).
22607 * expression.cs (Binary.ResolveOperator): I can only use the
22608 Concat (string, string, string) and Concat (string, string,
22609 string, string) if the child is actually a concatenation of
22612 2002-12-04 Miguel de Icaza <miguel@ximian.com>
22614 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
22615 context where we need a 2-character lookahead.
22617 * pending.cs (PendingImplementation): Rework so we can keep track
22618 of interface types all the time, and flag those which were
22619 implemented by parents as optional.
22621 2002-12-03 Miguel de Icaza <miguel@ximian.com>
22623 * expression.cs (Binary.ResolveOperator): Use
22624 String.Concat(string,string,string) or
22625 String.Concat(string,string,string,string) when possible.
22627 * typemanager: More helper methods.
22630 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
22632 * pending.cs: remove the bogus return from GetMissingInterfaces()
22633 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
22635 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22637 * namespace.cs: avoid duplicated 'using xxx' being added to
22638 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
22639 when we get more than one 'using' statement for the same namespace.
22640 Report a CS0105 warning for it.
22642 2002-11-30 Miguel de Icaza <miguel@ximian.com>
22644 * cs-tokenizer.cs (consume_identifier): use read directly, instead
22645 of calling getChar/putback, uses internal knowledge of it.
22647 (xtoken): Reorder tokenizer so most common patterns are checked
22648 first. This reduces the compilation time in another 5% (from 8.11s
22649 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
22651 The parsing time is 22% of the compilation in mcs, and from that
22652 64% is spent on the tokenization process.
22654 I tried using a binary search for keywords, but this is slower
22655 than the hashtable. Another option would be to do a couple of
22658 * Not use a StringBuilder, instead use an array of chars,
22659 with a set value. Notice that this way we could catch
22660 the 645 error without having to do it *afterwards*.
22662 * We could write a hand-parser to avoid the hashtable
22663 compares altogether.
22665 The identifier consumption process takes 37% of the tokenization
22666 time. Another 15% is spent on is_number. 56% of the time spent
22667 on is_number is spent on Int64.Parse:
22669 * We could probably choose based on the string length to
22670 use Int32.Parse or Int64.Parse and avoid all the 64-bit
22673 Another 3% is spend on wrapping `xtoken' in the `token' function.
22675 Handle 0xa0 as whitespace (#34752)
22677 2002-11-26 Miguel de Icaza <miguel@ximian.com>
22679 * typemanager.cs (IsCLRType): New routine to tell whether a type
22680 is one of the builtin types.
22682 Maybe it needs to use TypeCodes to be faster. Maybe we could use
22683 typecode in more places instead of doing pointer comparissions.
22684 We could leverage some knowledge about the way the typecodes are
22687 New code to cache namespaces in assemblies, it is currently not
22688 invoked, to be used soon.
22690 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
22692 * expression.cs (Binary.ResolveOperator): specially handle
22693 strings, and do not perform user-defined operator overloading for
22696 2002-11-24 Miguel de Icaza <miguel@ximian.com>
22698 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
22699 internalcall as it is a pretty simple operation; Avoid whenever
22700 possible to call Char.IsLetter.
22702 (consume_identifier): Cut by half the number of
22703 hashtable calls by merging the is_keyword and GetKeyword behavior.
22705 Do not short-circuit, because if we do, we
22706 report errors (ie, #if false && true would produce an invalid
22710 2002-11-24 Martin Baulig <martin@ximian.com>
22712 * expression.cs (Cast.TryReduce): If we're in checked syntax,
22713 check constant ranges and report a CS0221. Fixes #33186.
22715 2002-11-24 Martin Baulig <martin@ximian.com>
22717 * cs-parser.jay: Make this work for uninitialized variable
22718 declarations in the `for' initializer. Fixes #32416.
22720 2002-11-24 Martin Baulig <martin@ximian.com>
22722 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
22723 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
22725 2002-11-24 Martin Baulig <martin@ximian.com>
22727 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
22728 argument; if true, we also check for user-defined conversions.
22729 This is only needed if both arguments are of a user-defined type.
22730 Fixes #30443, added test-175.cs.
22731 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
22733 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
22735 2002-11-24 Martin Baulig <martin@ximian.com>
22737 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
22738 function to get the store opcode.
22739 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
22740 only emit the Ldelema if the store opcode is Stobj. You must run
22741 both test-34 and test-167 to test this. Fixes #34529.
22743 2002-11-23 Martin Baulig <martin@ximian.com>
22745 * ecore.cs (Expression.MemberLookup): Added additional
22746 `qualifier_type' argument which is used when we're being called
22747 from MemberAccess.DoResolve() and null if we're called from a
22749 (Expression.MemberLookupFailed): New method to report errors; this
22750 does the CS1540 check and reports the correct error message.
22752 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
22753 argument for the CS1540 check and redone the way how we're dealing
22754 with private members. See the comment in the source code for details.
22755 (FilterWithClosure): Reverted this back to revision 1.197; renamed
22756 `closure_start_type' to `closure_qualifier_type' and check whether
22757 it's not null. It was not this filter being broken, it was just
22758 being called with the wrong arguments.
22760 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
22761 and pass it the correct `qualifier_type'; this also does the error
22764 2002-11-22 Miguel de Icaza <miguel@ximian.com>
22766 * expression.cs (Invocation.EmitParams): If the we are dealing
22767 with a non-built-in value type, load its address as well.
22769 (ArrayCreation): Use a a pretty constant instead
22770 of the hardcoded value 2. Use 6 instead of 2 for the number of
22771 static initializers.
22773 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
22774 because they are not really value types, just glorified integers.
22776 * driver.cs: Do not append .exe, the CSC compiler does not do it.
22778 * ecore.cs: Remove redundant code for enumerations, make them use
22779 the same code path as everything else, fixes the casting issue
22780 with enumerations in Windows.Forms.
22782 * attribute.cs: Do only cast to string if it is a string, the
22783 validation happens later.
22785 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
22786 people upgrade their corlibs.
22788 * ecore.cs: Oops, enumerations were not following the entire code path
22790 2002-11-21 Miguel de Icaza <miguel@ximian.com>
22792 * typemanager.cs (FilterWithClosure): Commented out the test for
22793 1540 in typemanager.cs, as it has problems when accessing
22794 protected methods from a parent class (see test-174.cs).
22796 * attribute.cs (Attribute.ValidateGuid): new method.
22797 (Attribute.Resolve): Use above.
22799 2002-11-19 Miguel de Icaza <miguel@ximian.com>
22801 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
22803 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
22804 handling for enumerations, as we only needed the TypeContainer
22805 functionality to begin with (this is required for the fix below to
22806 work for enums that reference constants in a container class for
22809 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
22811 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
22812 a valid TypeBuilder to perform lookups on.o
22814 * class.cs (InheritableMemberSignatureCompare): Use true in the
22815 call to GetGetMethod and GetSetMethod, because we are comparing
22816 the signature, and we need to get the methods *even* if they are
22819 (PropertyBase.CheckBase): ditto.
22821 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
22822 GotoCase.Resolve): Use Peel on EmpytCasts.
22824 * ecore.cs (EmptyCast): drop child, add Peel method.
22826 2002-11-17 Martin Baulig <martin@ximian.com>
22828 * ecore.cs (EmptyCast.Child): New public property.
22830 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
22831 label resolved to an EmptyCast. Fixes #34162.
22832 (GotoCase.Resolve): Likewise.
22833 (Block.EmitMeta): Likewise.
22835 2002-11-17 Martin Baulig <martin@ximian.com>
22837 * expression.cs (Invocation.BetterConversion): Prefer int over
22838 uint; short over ushort; long over ulong for integer literals.
22839 Use ImplicitConversionExists instead of StandardConversionExists
22840 since we also need to check for user-defined implicit conversions.
22841 Fixes #34165. Added test-173.cs.
22843 2002-11-16 Martin Baulig <martin@ximian.com>
22845 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
22846 with the `true' and `false' literals. Fixes #33151.
22848 2002-11-16 Martin Baulig <martin@ximian.com>
22850 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
22851 October 22nd; don't do the cs1540 check for static members.
22853 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
22854 now using our own filter here and doing the cs1540 check again.
22856 2002-11-16 Martin Baulig <martin@ximian.com>
22858 * support.cs (InternalParameters): Don't crash if we don't have
22859 any fixed parameters. Fixes #33532.
22861 2002-11-16 Martin Baulig <martin@ximian.com>
22863 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
22864 when looking up static methods to make this work on Windows.
22867 2002-11-16 Martin Baulig <martin@ximian.com>
22869 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
22870 a setter rather than using PropertyInfo.CanWrite.
22872 2002-11-15 Nick Drochak <ndrochak@gol.com>
22874 * class.cs: Allow acces to block member by subclasses. Fixes build
22877 2002-11-14 Martin Baulig <martin@ximian.com>
22879 * class.cs (Constructor.Emit): Added the extern/block check.
22882 2002-11-14 Martin Baulig <martin@ximian.com>
22884 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
22885 iteration while looking for indexers, this is needed because the
22886 indexer may have a different name in our base classes. Fixed the
22887 error reporting (no indexers at all, not get accessor, no
22888 overloaded match). Fixes bug #33089.
22889 (IndexerAccess.DoResolveLValue): Likewise.
22891 2002-11-14 Martin Baulig <martin@ximian.com>
22893 * class.cs (PropertyBase.CheckBase): Make this work for multiple
22894 indexers. Fixes the first part of bug #33089.
22895 (MethodSignature.InheritableMemberSignatureCompare): Added support
22898 2002-11-13 Ravi Pratap <ravi@ximian.com>
22900 * attribute.cs (Attribute.Resolve): Catch the
22901 NullReferenceException and report it since it isn't supposed to
22904 2002-11-12 Miguel de Icaza <miguel@ximian.com>
22906 * expression.cs (Binary.EmitBranchable): Also handle the cases for
22907 LogicalOr and LogicalAnd that can benefit from recursively
22908 handling EmitBranchable. The code now should be nice for Paolo.
22910 2002-11-08 Miguel de Icaza <miguel@ximian.com>
22912 * typemanager.cs (LookupType): Added a negative-hit hashtable for
22913 the Type lookups, as we perform quite a number of lookups on
22914 non-Types. This can be removed once we can deterministically tell
22915 whether we have a type or a namespace in advance.
22917 But this might require special hacks from our corlib.
22921 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
22922 and double which avoids a conversion from an integer to a double.
22924 * expression.cs: tiny optimization, avoid calling IsConstant,
22925 because it effectively performs the lookup twice.
22927 2002-11-06 Miguel de Icaza <miguel@ximian.com>
22929 But a bogus return here to keep the semantics of the old code
22930 until the Mono runtime is fixed.
22932 * pending.cs (GetMissingInterfaces): New method used to remove all
22933 the interfaces that are already implemented by our parent
22934 classes from the list of pending methods.
22936 * interface.cs: Add checks for calls after ResolveTypeExpr.
22938 2002-11-05 Miguel de Icaza <miguel@ximian.com>
22940 * class.cs (Class.Emit): Report warning 67: event not used if the
22941 warning level is beyond 3.
22943 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
22944 being a NullLiteral.
22946 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
22949 * class.cs (TypeContainer.GetClassBases): Cover a missing code
22950 path that might fail if a type can not be resolved.
22952 * expression.cs (Binary.Emit): Emit unsigned versions of the
22955 * driver.cs: use error 5.
22957 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
22959 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
22961 2002-11-01 Miguel de Icaza <miguel@ximian.com>
22963 * cs-parser.jay (switch_section): A beautiful patch from Martin
22964 Baulig that fixed 33094.
22966 2002-10-31 Miguel de Icaza <miguel@ximian.com>
22968 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
22969 Check whether the base is abstract and report an error if so.
22971 * expression.cs (IndexerAccess.DoResolveLValue,
22972 IndexerAccess.DoResolve): ditto.
22974 (Invocation.DoResolve): ditto.
22976 (Invocation.FullMethodDesc): Improve the report string.
22978 * statement.cs (Block): Eliminate IsVariableDefined as it is
22979 basically just a wrapper for GetVariableInfo.
22981 * ecore.cs (SimpleName): Use new
22983 * support.cs (ReflectionParamter.ParameterType): We unwrap the
22984 type, as we return the actual parameter ref/unref state on a
22987 2002-10-30 Miguel de Icaza <miguel@ximian.com>
22989 * support.cs: Return proper flags REF/OUT fixing the previous
22992 * expression.cs: Reverted last patch, that was wrong. Is_ref is
22993 not used to mean `ref' but `ref or out' in ParameterReference
22995 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
22996 full type signature instead of calling TypeManger.CSharpName
22999 * support.cs (InternalParameters.ParameterDesc): Do not compare
23000 directly to the modflags, because REF/OUT will actually be bitsets
23003 * delegate.cs (VerifyMethod): Check also the modifiers.
23005 * cs-tokenizer.cs: Fix bug where floating point values with an
23006 exponent where a sign was missing was ignored.
23008 * driver.cs: Allow multiple assemblies to be specified in a single
23011 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23013 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23014 because identifiers after a parenthesis would end up in this kind
23015 of production, and we needed to desamiguate it for having casts
23018 (UserDefinedType *) xxx
23020 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23022 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23023 we should set on the Bindingflags.NonPublic, but not turn on
23024 private_ok. private_ok controls whether a Private member is
23025 returned (this is chekced on the filter routine), while the
23026 BindingFlags.NonPublic just controls whether private/protected
23027 will be allowed. This fixes the problem part of the problem of
23028 private properties being allowed to be used in derived classes.
23030 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23031 so we can call the children DoResolveLValue method (this will
23032 properly signal errors on lvalue assignments to base properties)
23034 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23035 getter are null, and we have a property info, we know that this
23036 happened because the lookup failed, so we report an error 122 for
23037 protection level violation.
23039 We also silently return if setter and getter are null in the
23040 resolve functions, this condition only happens if we have flagged
23041 the error before. This is the other half of the problem.
23043 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23044 not have accessibility information, that is why we were returning
23045 true in the filter function in typemanager.cs.
23047 To properly report 122 (property is inaccessible because of its
23048 protection level) correctly, we report this error in ResolveAccess
23049 by failing if both the setter and the getter are lacking (ie, the
23052 DoResolve and DoLResolve have been modified to check for both
23053 setter/getter being null and returning silently, the reason being
23054 that I did not want to put the knowledge about this error in upper
23057 int old = Report.Errors;
23058 x = new PropertyExpr (...);
23059 if (old != Report.Errors)
23064 So the property expr is returned, but it is invalid, so the error
23065 will be flagged during the resolve process.
23067 * class.cs: Remove InheritablePropertySignatureCompare from the
23068 class, as we no longer depend on the property signature to compute
23069 whether it is possible to implement a method or not.
23071 The reason is that calling PropertyInfo.GetGetMethod will return
23072 null (in .NET, in Mono it works, and we should change this), in
23073 cases where the Get Method does not exist in that particular
23078 class X { public virtual int A { get { return 1; } } }
23080 class Z : Y { public override int A { get { return 2; } } }
23082 Would fail in Z because the parent (Y) would not have the property
23083 defined. So we avoid this completely now (because the alternative
23084 fix was ugly and slow), and we now depend exclusively on the
23087 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23088 reference method, instead of using the property.
23090 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23091 routines are gone now.
23093 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23094 names, they were incorrectly named.
23096 * cs-tokenizer.cs: Return are more gentle token on failure.
23098 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23099 had an out-of-sync index variable, which caused it to remove from
23100 the list of pending methods the wrong method sometimes.
23102 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23104 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23105 CanWrite, because those refer to this particular instance of the
23106 property, and do not take into account the fact that we can
23107 override single members of a property.
23109 Constructor requires an EmitContext. The resolution process does
23110 not happen here, but we need to compute the accessors before,
23111 because the resolution does not always happen for properties.
23113 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23114 subclass, before we did not update this flag, but we did update
23117 (GetAccessors): Drop this routine, as it did not work in the
23118 presence of partially overwritten set/get methods.
23120 Notice that this broke the cs1540 detection, but that will require
23123 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23127 * driver.cs: issue a warning instead of an error if we don't support
23128 debugging for the platform. Also ignore a couple of errors that may
23129 arise when trying to write the symbols. Undo my previous patch.
23131 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23133 * driver.cs: ignore /debug switch except for Unix platforms.
23135 2002-10-23 Nick Drochak <ndrochak@gol.com>
23137 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23139 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23141 * driver.cs: Do not make mcs-debug conditional, so we do not break
23142 builds that use it.
23144 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23145 review this patch. But basically after all the children variables
23146 have been merged, the value of "Breaks" was not being set to
23147 new_breaks for Switch blocks. I think that it should be set after
23148 it has executed. Currently I set this to the value of new_breaks,
23149 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23150 conservative, but I do not understand this code very well.
23152 I did not break anything in the build, so that is good ;-)
23154 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23156 2002-10-20 Mark Crichton <crichton@gimp.org>
23158 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23160 2002-10-20 Nick Drochak <ndrochak@gol.com>
23162 * cfold.cs: Fixed compile blocker.
23164 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23166 * driver.cs: I was chekcing the key, not the file.
23168 2002-10-19 Ravi Pratap <ravi@ximian.com>
23170 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23171 message that we were generating - we just need to silently return
23174 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23176 * class.cs (Event.Define): Change my previous commit, as this
23177 breaks the debugger. This is a temporary hack, as it seems like
23178 the compiler is generating events incorrectly to begin with.
23180 * expression.cs (Binary.ResolveOperator): Added support for
23181 "U operator - (E x, E y)"
23183 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23186 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23187 init-only variables, but this path did not take into account that
23188 there might be also instance readonly variables. Correct this
23191 This fixes bug 32253
23193 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23196 * driver.cs: Change the extension for modules to `netmodule'
23198 * cs-parser.jay: Improved slightly the location tracking for
23199 the debugger symbols.
23201 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23202 modifiers that were specified instead of the hardcoded value
23203 (FamAndAssem). This was basically ignoring the static modifier,
23204 and others. Fixes 32429.
23206 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23207 fixed a bug in the process (32476)
23209 * expression.cs (ArrayAccess.EmitAssign): Patch from
23210 hwang_rob@yahoo.ca that fixes bug 31834.3
23212 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23214 * driver.cs: Make the module extension .netmodule.
23216 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23218 * driver.cs: Report an error if the resource file is not found
23219 instead of crashing.
23221 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23222 false, like Emit does.
23224 2002-10-16 Nick Drochak <ndrochak@gol.com>
23226 * typemanager.cs: Remove unused private member. Also reported mcs
23227 bug to report this as a warning like csc.
23229 2002-10-15 Martin Baulig <martin@gnome.org>
23231 * statement.cs (Statement.Emit): Made this a virtual method; emits
23232 the line number info and calls DoEmit().
23233 (Statement.DoEmit): New protected abstract method, formerly knows
23234 as Statement.Emit().
23236 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23238 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23240 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23241 have fixed a remaining problem: not every AddXXXX was adding a
23242 fully qualified name.
23244 Now everyone registers a fully qualified name in the DeclSpace as
23245 being defined instead of the partial name.
23247 Downsides: we are slower than we need to be due to the excess
23248 copies and the names being registered this way.
23250 The reason for this is that we currently depend (on the corlib
23251 bootstrap for instance) that types are fully qualified, because
23252 we dump all the types in the namespace, and we should really have
23253 types inserted into the proper namespace, so we can only store the
23254 basenames in the defined_names array.
23256 2002-10-10 Martin Baulig <martin@gnome.org>
23258 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23259 from bug #31834, see the bug report for a testcase which is
23262 2002-10-10 Martin Baulig <martin@gnome.org>
23264 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23265 flow analysis code for this.
23267 * statement.cs (Do, While, For): Tell the flow analysis code about
23269 (FlowBranching.UsageVector): Added support for infinite loops.
23270 (Block.Resolve): Moved the dead code elimination here and use flow
23273 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23275 * class.cs (Field.Define): Catch cycles on struct type
23278 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23279 fields if the fields are static. We only need to check instance
23282 * expression.cs (As.DoResolve): Test for reference type.
23284 * statement.cs (Using.ResolveExpression): Use
23285 ConvertImplicitRequired, not ConvertImplicit which reports an
23287 (Using.ResolveLocalVariableDecls): ditto.
23289 * expression.cs (Binary.ResolveOperator): Report errors in a few
23290 places where we had to.
23292 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23294 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23296 * expression.cs: Use StoreFromPtr instead of extracting the type
23297 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23299 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23300 an enumeration value to a System.Enum, but System.Enum is not a
23301 value type, but an class type, so we need to box.
23303 (Expression.ConvertExplicit): One codepath could return
23304 errors but not flag them. Fix this. Fixes #31853
23306 * parameter.cs (Resolve): Do not allow void as a parameter type.
23308 2002-10-06 Martin Baulig <martin@gnome.org>
23310 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23311 if it's a class type and not a struct. Fixes #31815.
23313 2002-10-06 Martin Baulig <martin@gnome.org>
23315 * statement.cs: Reworked the flow analysis code a bit to make it
23316 usable for dead code elimination.
23318 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23320 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23322 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23324 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23325 to fix the test 165, will investigate deeper.
23327 2002-10-04 Martin Baulig <martin@gnome.org>
23329 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23330 finally blocks actually work.
23331 (Try.Resolve): We don't need to create a sibling for `finally' if
23332 there is no finally block.
23334 2002-10-04 Martin Baulig <martin@gnome.org>
23336 * class.cs (Constructor.Define): The default accessibility for a
23337 non-default constructor is private, not public.
23339 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23341 * class.cs (Constructor): Make AllowedModifiers public, add
23344 * cs-parser.jay: Perform the modifiers test here, as the
23345 constructor for the Constructor class usually receives a zero
23346 because of the way we create it (first we create, later we
23347 customize, and we were never checking the modifiers).
23349 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23350 is a version of LookupTypeReflection that includes the type-name
23351 cache. This can be used as a fast path for functions that know
23352 the fully qualified name and are only calling into *.GetType() to
23353 obtain a composed type.
23355 This is also used by TypeManager.LookupType during its type
23358 (LookupType): We now also track the real type name, as sometimes
23359 we can get a quey for the real type name from things like
23360 ComposedCast. This fixes bug 31422.
23362 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23363 complete type fullname, it does not have to go through the type
23364 resolution system to obtain the composed version of the type (for
23365 obtaining arrays or pointers).
23367 (Conditional.Emit): Use the EmitBoolExpression to
23368 generate nicer code, as requested by Paolo.
23370 (ArrayCreation.CheckIndices): Use the patch from
23371 hwang_rob@yahoo.ca to validate the array initializers.
23373 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23375 * class.cs (ConstructorInitializer.Emit): simplify code by using
23376 Invocation.EmitCall, and at the same time, fix the bugs in calling
23377 parent constructors that took variable arguments.
23379 * ecore.cs (Expression.ConvertNumericExplicit,
23380 Expression.ImplicitNumericConversion): Remove the code that
23381 manually wrapped decimal (InternalTypeConstructor call is now gone
23384 * expression.cs (Cast.TryReduce): Also handle decimal types when
23385 trying to perform a constant fold on the type.
23387 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23389 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23390 that only turned off an error report, and did nothing else.
23392 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23394 * driver.cs: Handle and ignore /fullpaths
23396 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23398 * expression.cs (Binary.ResolveOperator): Catch the case where
23399 DoNumericPromotions returns true,
23401 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23403 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23405 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23408 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23410 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23411 conversion exists, but it is also required that the conversion be
23412 performed. This manifested in "(Type64Enum) 2".
23414 * class.cs (TypeManager.AddMethod): The fix is not to change
23415 AddEnum, because that one was using a fully qualified name (every
23416 DeclSpace derivative does), but to change the AddMethod routine
23417 that was using an un-namespaced name. This now correctly reports
23418 the duplicated name.
23420 Revert patch until I can properly fix it. The issue
23421 is that we have a shared Type space across all namespaces
23422 currently, which is wrong.
23424 Options include making the Namespace a DeclSpace, and merge
23425 current_namespace/current_container in the parser.
23427 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23429 * cs-parser.jay: Improve error reporting when we get a different
23430 kind of expression in local_variable_type and
23431 local_variable_pointer_type.
23433 Propagate this to avoid missleading errors being reported.
23435 * ecore.cs (ImplicitReferenceConversion): treat
23436 TypeManager.value_type as a target just like object_type. As
23441 Is valid, and needs to result in the int 1 being boxed before it
23442 is assigned to the value type v.
23444 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23445 to validate the enumeration name.
23447 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23448 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23449 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23451 * ecore.cs (TryImplicitIntConversion): When doing an
23452 implicit-enumeration-conversion, check if the type is 64-bits and
23453 perform a conversion before passing to EnumConstant.
23455 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23457 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23458 report ambiguous type references. Unlike the MS version, we
23459 report what the ambiguity is. Innovation at work ;-)
23461 (DeclSpace.FindType): Require a location argument to
23462 display when we display an ambiguous error.
23464 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23466 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23468 * expression.cs (EmitDynamicInitializers): Apply patch from
23469 hwang_rob@yahoo.ca that fixes the order in which we emit our
23472 2002-09-21 Martin Baulig <martin@gnome.org>
23474 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23475 delegate takes no arguments.
23477 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23479 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23482 * expression.cs: Extract the underlying type.
23484 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
23486 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
23488 2002-09-19 Miguel de Icaza <miguel@ximian.com>
23490 * class.cs (TypeContainer.DefineType): We can not use the nice
23491 PackingSize with the size set to 1 DefineType method, because it
23492 will not allow us to define the interfaces that the struct
23495 This completes the fixing of bug 27287
23497 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
23498 means also structs. This fixes part of the problem.
23499 (Expresion.ImplicitReferenceConversionExists): ditto.
23501 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
23502 error if there were no errors reported during the type lookup
23503 process, to avoid duplicates or redundant errors. Without this
23504 you would get an ambiguous errors plus a type not found. We have
23505 beaten the user enough with the first error.
23507 (DeclSparce.FindType): Emit a warning if we have an ambiguous
23510 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
23511 during the resolution process, stop the lookup, this avoids
23512 repeated error reports (same error twice).
23514 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
23516 * typemanager.cs (LookupType): Redo the type lookup code to match
23517 the needs of System.Reflection.
23519 The issue is that System.Reflection requires references to nested
23520 types to begin with a "+" sign instead of a dot. So toplevel
23521 types look like: "NameSpace.TopLevelClass", and nested ones look
23522 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
23525 2002-09-19 Martin Baulig <martin@gnome.org>
23527 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
23528 says that a method always returns or always throws an exception,
23529 don't report the CS0161.
23531 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
23532 set `Returns = new_returns'.
23534 2002-09-19 Martin Baulig <martin@gnome.org>
23536 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
23537 to an enum constant, check for a CS0176.
23539 2002-09-18 Miguel de Icaza <miguel@ximian.com>
23541 * class.cs (TypeContainer.CheckPairedOperators): Now we check
23542 for operators that must be in pairs and report errors.
23544 * ecore.cs (SimpleName.DoResolveType): During the initial type
23545 resolution process, when we define types recursively, we must
23546 check first for types in our current scope before we perform
23547 lookups in the enclosing scopes.
23549 * expression.cs (MakeByteBlob): Handle Decimal blobs.
23551 (Invocation.VerifyArgumentsCompat): Call
23552 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
23553 I thought we were supposed to always call this, but there are a
23554 few places in the code where we dont do it.
23556 2002-09-17 Miguel de Icaza <miguel@ximian.com>
23558 * driver.cs: Add support in -linkres and -resource to specify the
23559 name of the identifier.
23561 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23563 * ecore.cs (StandardConversionExists): Sync with the conversion
23564 code: allow anything-* to void* conversions.
23566 (FindMostSpecificSource): Use an Expression argument
23567 instead of a Type, because we might be handed over a Literal which
23568 gets a few more implicit conversions that plain types do not. So
23569 this information was being lost.
23571 Also, we drop the temporary type-holder expression when not
23574 2002-09-17 Martin Baulig <martin@gnome.org>
23576 * class.cs (PropertyBase.CheckBase): Don't check the base class if
23577 this is an explicit interface implementation.
23579 2002-09-17 Martin Baulig <martin@gnome.org>
23581 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
23582 different `IndexerName' attributes.
23584 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
23585 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
23586 virtual CommonResolve().
23588 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23590 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
23591 and convert that to the UnderlyingType.
23593 * statement.cs (Foreach.Resolve): Indexers are just like variables
23594 or PropertyAccesses.
23596 * cs-tokenizer.cs (consume_string): Track line numbers and columns
23597 inside quoted strings, we were not doing this before.
23599 2002-09-16 Martin Baulig <martin@gnome.org>
23601 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
23602 resolve it. This is needed for the definite assignment check of the
23603 instance expression, fixes bug #29846.
23604 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
23606 2002-09-16 Nick Drochak <ndrochak@gol.com>
23608 * parameter.cs: Fix compile error. Cannot reference static member
23609 from an instance object. Is this an mcs bug?
23611 2002-09-14 Martin Baulig <martin@gnome.org>
23613 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
23614 multiple times. Fixes bug #30295, added test-166.cs.
23616 2002-09-14 Martin Baulig <martin@gnome.org>
23618 * statement.cs (Block.Emit): Don't emit unreachable code.
23619 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
23620 `break' statements.
23621 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
23623 2002-09-14 Martin Baulig <martin@gnome.org>
23625 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
23628 2002-09-14 Martin Baulig <martin@gnome.org>
23630 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
23631 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
23632 be false on the ms runtime.
23634 2002-09-13 Martin Baulig <martin@gnome.org>
23636 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
23637 the CS0038 error message.
23639 2002-09-12 Miguel de Icaza <miguel@ximian.com>
23641 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
23642 constant inside, return it.
23644 2002-09-12 Martin Baulig <martin@gnome.org>
23646 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
23647 implicit conversion can be done between enum types.
23649 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
23650 check whether an implicit conversion to the current enum's UnderlyingType
23651 exists and report an error if not.
23653 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
23654 without debugging support.
23656 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
23657 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
23659 2002-09-12 Martin Baulig <martin@gnome.org>
23661 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
23663 * ecore.cs (IMemberExpr.DeclaringType): New property.
23664 (SimpleName.SimpleNameResolve): Check whether we're accessing a
23665 nonstatic member of an outer type (CS0038).
23667 2002-09-11 Miguel de Icaza <miguel@ximian.com>
23669 * driver.cs: Activate the using-error detector at warning level
23670 4 (at least for MS-compatible APIs).
23672 * namespace.cs (VerifyUsing): Small buglett fix.
23674 * pending.cs (PendingImplementation): pass the container pointer.
23676 * interface.cs (GetMethods): Allow for recursive definition. Long
23677 term, I would like to move every type to support recursive
23678 definitions, not the current ordering mechanism that we have right
23681 The situation is this: Attributes are handled before interfaces,
23682 so we can apply attributes to interfaces. But some attributes
23683 implement interfaces, we will now handle the simple cases
23684 (recursive definitions will just get an error).
23686 * parameter.cs: Only invalidate types at the end if we fail to
23689 2002-09-09 Martin Baulig <martin@gnome.org>
23691 * ecore.cs (PropertyExpr.Emit): Also check for
23692 TypeManager.system_int_array_get_length so this'll also work when
23693 compiling corlib. Fixes #30003.
23695 2002-09-09 Martin Baulig <martin@gnome.org>
23697 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
23698 and throw an exception if we can't get the type's size. Fixed #30040,
23701 2002-09-09 Martin Baulig <martin@gnome.org>
23703 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
23705 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
23706 context. Fixes bug #30027.
23708 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
23709 virtual functions. Fixes bug #30043, added test-164.cs.
23711 2002-09-08 Ravi Pratap <ravi@ximian.com>
23713 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
23715 2002-09-08 Nick Drochak <ndrochak@gol.com>
23717 * driver.cs: Use an object to get the windows codepage since it's not a
23720 2002-09-08 Miguel de Icaza <miguel@ximian.com>
23722 * statement.cs (For.Emit): for infinite loops (test == null)
23723 return whether there is a break inside, not always "true".
23725 * namespace.cs (UsingEntry): New struct to hold the name of the
23726 using definition, the location where it is defined, and whether it
23727 has been used in a successful type lookup.
23729 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
23734 2002-09-06 Ravi Pratap <ravi@ximian.com>
23736 * attribute.cs : Fix incorrect code which relied on catching
23737 a NullReferenceException to detect a null being passed in
23738 where an object was expected.
23740 2002-09-06 Miguel de Icaza <miguel@ximian.com>
23742 * statement.cs (Try): flag the catch variable as assigned
23744 * expression.cs (Cast): Simplified by using ResolveType instead of
23745 manually resolving.
23747 * statement.cs (Catch): Fix bug by using ResolveType.
23749 2002-09-06 Ravi Pratap <ravi@ximian.com>
23751 * expression.cs (BetterConversion): Special case for when we have
23752 a NullLiteral as the argument and we have to choose between string
23753 and object types - we choose string the way csc does.
23755 * attribute.cs (Attribute.Resolve): Catch the
23756 NullReferenceException and report error #182 since the Mono
23757 runtime no more has the bug and having this exception raised means
23758 we tried to select a constructor which takes an object and is
23761 2002-09-05 Ravi Pratap <ravi@ximian.com>
23763 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
23764 message (1502, 1503) when we can't locate a method after overload
23765 resolution. This is much more informative and closes the bug
23768 * interface.cs (PopulateMethod): Return if there are no argument
23769 types. Fixes a NullReferenceException bug.
23771 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
23772 expressions too. Previously we were checking only in one place for
23773 positional arguments leaving out named arguments.
23775 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
23776 type to the enum type is not allowed. Remove code corresponding to
23779 (ConvertNumericExplicit): Allow explicit conversions from
23780 the underlying type to enum type. This precisely follows the spec
23781 and closes a bug filed by Gonzalo.
23783 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23786 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
23788 2002-09-03 Miguel de Icaza <miguel@ximian.com>
23790 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
23791 it was important that we stored the right value after the
23792 reduction in `converted'.
23794 2002-09-04 Martin Baulig <martin@gnome.org>
23796 * location.cs (Location.SymbolDocument): Use full pathnames for the
23799 2002-08-30 Miguel de Icaza <miguel@ximian.com>
23801 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
23802 of the expression resolve mechanism, because that will catch the
23803 SimpleName error failures.
23805 (Conditional): If we can not resolve the
23806 expression, return, do not crash.
23808 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23811 (location): display token name instead of its number.
23813 2002-08-28 Martin Baulig <martin@gnome.org>
23815 * expression.cs (Binary.ResolveOperator): Don't silently return
23816 but return an error if an operator cannot be applied between two
23819 2002-08-28 Martin Baulig <martin@gnome.org>
23821 * class.cs (Constructor.Define): Set the permission attributes
23822 correctly instead of making all constructors public.
23824 2002-08-28 Martin Baulig <martin@gnome.org>
23826 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
23827 for private members before reporting a CS0103; if we find anything,
23830 2002-08-28 Martin Baulig <martin@gnome.org>
23832 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
23833 to check whether `closure_start_type == closure_invocation_type',
23834 we also need to check whether `m.DeclaringType == closure_invocation_type'
23835 before bypassing the permission checks. We might be accessing
23836 protected/private members from the base class.
23837 (TypeManager.RealMemberLookup): Only set private_ok if private
23838 members were requested via BindingFlags.NonPublic.
23840 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
23842 * expression.cs (MemberAccess.ResolveMemberAccess): Set
23843 MethodGroupExpr.IsExplicitImpl if appropriate.
23844 (Invocation.DoResolve): Don't report the CS0120 for explicit
23845 interface implementations.
23847 2002-08-27 Martin Baulig <martin@gnome.org>
23849 * expression.cs (Invocation.DoResolve): If this is a static
23850 method and we don't have an InstanceExpression, we must report
23853 2002-08-25 Martin Baulig <martin@gnome.org>
23855 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
23856 `==' between a valuetype and an object.
23858 2002-08-25 Miguel de Icaza <miguel@ximian.com>
23860 * ecore.cs (TypeExpr): Provide a ToString method.
23862 2002-08-24 Martin Baulig <martin@gnome.org>
23864 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
23865 now called proggie.dbg and it's a binary file.
23867 2002-08-23 Martin Baulig <martin@gnome.org>
23869 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
23871 2002-08-23 Martin Baulig <martin@gnome.org>
23873 * struct.cs (MyStructInfo.ctor): Make this work with empty
23874 structs; it's not allowed to use foreach() on null.
23876 2002-08-23 Martin Baulig <martin@gnome.org>
23878 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
23879 writer the full pathname of the generated assembly.
23881 2002-08-23 Martin Baulig <martin@gnome.org>
23883 * statements.cs (FlowBranching.UsageVector.MergeChildren):
23884 A `finally' block never returns or breaks; improved handling of
23887 2002-08-23 Martin Baulig <martin@gnome.org>
23889 * statement.cs (Throw.Resolve): Allow `throw null'.
23891 2002-08-23 Martin Baulig <martin@gnome.org>
23893 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
23894 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
23895 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
23896 MemberLookup would return a wrong event if this is an explicit
23897 interface implementation and the class has an event with the same
23900 2002-08-23 Martin Baulig <martin@gnome.org>
23902 * statement.cs (Block.AddChildVariableNames): New public method.
23903 (Block.AddChildVariableName): Likewise.
23904 (Block.IsVariableNameUsedInChildBlock): Likewise.
23905 (Block.AddVariable): Check whether a variable name has already
23906 been used in a child block.
23908 * cs-parser.jay (declare_local_variables): Mark all variable names
23909 from the current block as being used in a child block in the
23912 2002-08-23 Martin Baulig <martin@gnome.org>
23914 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
23915 find the symbol writer.
23917 * driver.cs: csc also allows the arguments to /define being
23918 separated by commas, not only by semicolons.
23920 2002-08-23 Martin Baulig <martin@gnome.org>
23922 * interface.cs (Interface.GetMembers): Added static check for events.
23924 2002-08-15 Martin Baulig <martin@gnome.org>
23926 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
23927 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
23929 * ecore.cs (Expression.MemberLookup): Added documentation and explained
23930 why the MethodData.EmitDestructor() change was necessary.
23932 2002-08-20 Martin Baulig <martin@gnome.org>
23934 * class.cs (TypeContainer.FindMembers): Added static check for events.
23936 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
23938 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
23939 use Type.GetEvents(), not Type.FindMembers().
23941 2002-08-20 Martin Baulig <martin@gnome.org>
23943 * decl.cs (MemberCache): Added a special method cache which will
23944 be used for method-only searched. This ensures that a method
23945 search will return a MethodInfo with the correct ReflectedType for
23948 2002-08-20 Martin Baulig <martin@gnome.org>
23950 * decl.cs (DeclSpace.FindMembers): Made this public.
23952 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23954 * delegate.cs: fixed build on windows.
23955 [FIXME: Filed as bug #29150: MCS must report these errors.]
23957 2002-08-19 Ravi Pratap <ravi@ximian.com>
23959 * ecore.cs (StandardConversionExists): Return a false
23960 if we are trying to convert the void type to anything else
23961 since that is not allowed.
23963 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
23964 we flag error 70 in the event an event is trying to be accessed
23965 directly from outside the declaring type.
23967 2002-08-20 Martin Baulig <martin@gnome.org>
23969 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
23970 MemberCache from typemanager.cs to decl.cs.
23972 2002-08-19 Martin Baulig <martin@gnome.org>
23974 * class.cs (TypeContainer): Implement IMemberContainer.
23975 (TypeContainer.DefineMembers): Create the MemberCache.
23976 (TypeContainer.FindMembers): Do better BindingFlags checking; only
23977 return public members if BindingFlags.Public was given, check
23978 whether members are static.
23980 2002-08-16 Martin Baulig <martin@gnome.org>
23982 * decl.cs (DeclSpace.Define): Splitted this in Define and
23983 DefineMembers. DefineMembers is called first and initializes the
23986 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
23987 DefineMembers() on all our DeclSpaces.
23989 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
23990 but call DefineMembers() on all nested interfaces. We call their
23991 Define() in our new Define() function.
23993 * interface.cs (Interface): Implement IMemberContainer.
23994 (Interface.Define): Moved all code except the attribute stuf to
23996 (Interface.DefineMembers): Initialize the member cache.
23998 * typemanager.cs (IMemberFinder): Removed this interface, we don't
23999 need this anymore since we can use MemberCache.FindMembers directly.
24001 2002-08-19 Martin Baulig <martin@gnome.org>
24003 * typemanager.cs (MemberCache): When creating the cache for an
24004 interface type, add all inherited members.
24005 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24006 to `out bool used_cache' and documented it.
24007 (TypeManager.MemberLookup): If we already used the cache in the first
24008 iteration, we don't need to do the interfaces check.
24010 2002-08-19 Martin Baulig <martin@gnome.org>
24012 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24013 here from IMemberFinder and don't implement this interface anymore.
24014 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24016 * typemanager.cs (IMemberFinder): This interface is now only used by
24017 classes which actually support the member cache.
24018 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24019 since we only put DeclSpaces into this Hashtable.
24020 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24021 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24023 2002-08-16 Martin Baulig <martin@gnome.org>
24025 * typemanager.cs (ICachingMemberFinder): Removed.
24026 (IMemberFinder.MemberCache): New property.
24027 (TypeManager.FindMembers): Merged this with RealFindMembers().
24028 This function will never be called from TypeManager.MemberLookup()
24029 so we can't use the cache here, just the IMemberFinder.
24030 (TypeManager.MemberLookup_FindMembers): Check whether the
24031 IMemberFinder has a MemberCache and call the cache's FindMembers
24033 (MemberCache): Rewrote larger parts of this yet another time and
24034 cleaned it up a bit.
24036 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24038 * driver.cs (LoadArgs): Support quoting.
24040 (Usage): Show the CSC-like command line arguments.
24042 Improved a few error messages.
24044 2002-08-15 Martin Baulig <martin@gnome.org>
24046 * typemanager.cs (IMemberContainer.Type): New property.
24047 (IMemberContainer.IsInterface): New property.
24049 The following changes are conditional to BROKEN_RUNTIME, which is
24050 defined at the top of the file.
24052 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24053 class'es members, but add all members from TypeHandle.ObjectType
24054 if we're an interface.
24055 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24056 is the current type.
24057 (MemberCache.CacheEntry.Container): Removed this field.
24058 (TypeHandle.GetMembers): Include inherited members.
24060 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24062 * typemanager.cs: fixed compilation and added a comment on a field that
24065 2002-08-15 Martin Baulig <martin@gnome.org>
24067 * class.cs (ConstructorInitializer.Resolve): In the
24068 Expression.MemberLookup call, use the queried_type as
24071 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24072 declared' attribute, it's always true.
24073 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24074 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24075 temporary wrapper for FindMembers which tells MemberLookup whether
24076 members from the base classes are included in the return value.
24077 This will go away soon.
24078 (TypeManager.MemberLookup): Use this temporary hack here; once the
24079 new MemberCache is completed, we don't need to do the DeclaredOnly
24080 looping here anymore since the MemberCache will take care of this.
24081 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24082 (MemberCache): When creating the MemberCache for a class, get
24083 members from the current class and all its base classes.
24084 (MemberCache.CacheEntry.Container): New field. This is a
24085 temporary hack until the Mono runtime is fixed to distinguish
24086 between ReflectedType and DeclaringType. It allows us to use MCS
24087 with both the MS runtime and the unfixed Mono runtime without
24088 problems and without accecting performance.
24089 (MemberCache.SearchMembers): The DeclaredOnly looping from
24090 TypeManager.MemberLookup is now done here.
24092 2002-08-14 Martin Baulig <martin@gnome.org>
24094 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24095 Type.GetFields on dynamic types but get the fields from the
24096 corresponding TypeContainer.
24097 (MyStructInfo.GetStructInfo): Added check for enum types.
24099 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24100 (MemberList.SyncRoot): Implemented.
24101 (TypeManager.FilterWithClosure): No need to check permissions if
24102 closure_start_type == closure_invocation_type, don't crash if
24103 closure_invocation_type is null.
24105 2002-08-13 Martin Baulig <martin@gnome.org>
24107 Rewrote TypeContainer.FindMembers to use a member cache. This
24108 gives us a speed increase of about 35% for the self-hosting MCS
24109 build and of about 15-20% for the class libs (both on GNU/Linux).
24111 * report.cs (Timer): New class to get enhanced profiling. This
24112 whole class is "TIMER" conditional since it remarkably slows down
24115 * class.cs (MemberList): New class. This is an IList wrapper
24116 which we're now using instead of passing MemberInfo[]'s around to
24117 avoid copying this array unnecessarily.
24118 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24119 (ICachingMemberFinder, IMemberContainer): New interface.
24120 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24121 has already been checked, otherwise use it for the name comparision.
24122 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24123 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24124 if possible. Returns a MemberList, not a MemberInfo [].
24125 (TypeHandle): New class, implements IMemberContainer. We create
24126 one instance of this class per type, it contains a MemberCache
24127 which is used to do the member lookups.
24128 (MemberCache): New class. Each instance of this class contains
24129 all members of a type and a name-based hash table.
24130 (MemberCache.FindMembers): This is our new member lookup
24131 function. First, it looks up all members of the requested name in
24132 the hash table. Then, it walks this list and sorts out all
24133 applicable members and returns them.
24135 2002-08-13 Martin Baulig <martin@gnome.org>
24137 In addition to a nice code cleanup, this gives us a performance
24138 increase of about 1.4% on GNU/Linux - not much, but it's already
24139 half a second for the self-hosting MCS compilation.
24141 * typemanager.cs (IMemberFinder): New interface. It is used by
24142 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24143 Enum, Delegate or Interface.
24144 (TypeManager.finder_to_member_finder): New PtrHashtable.
24145 (TypeManager.finder_to_container): Removed.
24146 (TypeManager.finder_to_delegate): Removed.
24147 (TypeManager.finder_to_interface): Removed.
24148 (TypeManager.finder_to_enum): Removed.
24150 * interface.cs (Interface): Implement IMemberFinder.
24152 * delegate.cs (Delegate): Implement IMemberFinder.
24154 * enum.cs (Enum): Implement IMemberFinder.
24156 * class.cs (TypeContainer): Implement IMemberFinder.
24158 2002-08-12 Martin Baulig <martin@gnome.org>
24160 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24162 2002-08-12 Martin Baulig <martin@gnome.org>
24164 * ecore.cs (ITypeExpression): New interface for expressions which
24166 (TypeExpression): Renamed to TypeLookupExpression.
24167 (Expression.DoResolve): If we're doing a types-only lookup, the
24168 expression must implement the ITypeExpression interface and we
24169 call DoResolveType() on it.
24170 (SimpleName): Implement the new ITypeExpression interface.
24171 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24172 hack, the situation that we're only looking up types can't happen
24173 anymore when this method is called. Moved the type lookup code to
24174 DoResolveType() and call it.
24175 (SimpleName.DoResolveType): This ITypeExpression interface method
24176 is now doing the types-only lookup.
24177 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24178 (ResolveFlags): Added MaskExprClass.
24180 * expression.cs (MemberAccess): Implement the ITypeExpression
24182 (MemberAccess.DoResolve): Added support for a types-only lookup
24183 when we're called via ITypeExpression.DoResolveType().
24184 (ComposedCast): Implement the ITypeExpression interface.
24186 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24187 Expression.Resolve() with ResolveFlags.Type instead.
24189 2002-08-12 Martin Baulig <martin@gnome.org>
24191 * interface.cs (Interface.Define): Apply attributes.
24193 * attribute.cs (Attribute.ApplyAttributes): Added support for
24194 interface attributes.
24196 2002-08-11 Martin Baulig <martin@gnome.org>
24198 * statement.cs (Block.Emit): Only check the "this" variable if we
24199 do not always throw an exception.
24201 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24202 whether the property has a set accessor.
24204 2002-08-11 Martin Baulig <martin@gnome.org>
24206 Added control flow analysis support for structs.
24208 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24209 with control flow analysis turned off.
24210 (IVariable): New interface.
24211 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24212 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24213 (FieldExpr.DoResolve): Resolve the instance expression with flow
24214 analysis turned off and do the definite assignment check after the
24215 resolving when we know what the expression will resolve to.
24217 * expression.cs (LocalVariableReference, ParameterReference):
24218 Implement the new IVariable interface, only call the flow analysis
24219 code if ec.DoFlowAnalysis is true.
24220 (This): Added constructor which takes a Block argument. Implement
24221 the new IVariable interface.
24222 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24223 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24224 This does the definite assignment checks for struct members.
24226 * class.cs (Constructor.Emit): If this is a non-static `struct'
24227 constructor which doesn't have any initializer, call
24228 Block.AddThisVariable() to tell the flow analysis code that all
24229 struct elements must be initialized before control returns from
24232 * statement.cs (MyStructInfo): New public class.
24233 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24234 argument to this indexer. If non-zero, check an individual struct
24235 member, not the whole struct.
24236 (FlowBranching.CheckOutParameters): Check struct members.
24237 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24238 overloaded versions of these methods which take an additional
24239 `int field_idx' argument to check struct members.
24240 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24241 overloaded versions of these methods which take an additional
24242 `string field_name' argument to check struct member.s
24243 (VariableInfo): Implement the IVariable interface.
24244 (VariableInfo.StructInfo): New public property. Returns the
24245 MyStructInfo instance of the variable if it's a struct or null.
24246 (Block.AddThisVariable): New public method. This is called from
24247 Constructor.Emit() for non-static `struct' constructor which do
24248 not have any initializer. It creates a special variable for the
24249 "this" instance variable which will be checked by the flow
24250 analysis code to ensure that all of the struct's fields are
24251 initialized before control returns from the constructor.
24252 (UsageVector): Added support for struct members. If a
24253 variable/parameter is a struct with N members, we reserve a slot
24254 in the usage vector for each member. A struct is considered fully
24255 initialized if either the struct itself (slot 0) or all its
24256 members are initialized.
24258 2002-08-08 Martin Baulig <martin@gnome.org>
24260 * driver.cs (Driver.MainDriver): Only report an error CS5001
24261 if there were no compilation errors.
24263 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24264 `UnsafeContext' property to determine whether the parent is in
24265 unsafe context rather than checking the parent's ModFlags:
24266 classes nested in an unsafe class are unsafe as well.
24268 2002-08-08 Martin Baulig <martin@gnome.org>
24270 * statement.cs (UsageVector.MergeChildren): Distinguish between
24271 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24272 we return. Added test17() and test18() to test-154.cs.
24274 2002-08-08 Martin Baulig <martin@gnome.org>
24276 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24277 Family access, make sure the invoking type isn't a subclass of the
24278 queried type (that'd be a CS1540).
24280 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24281 this method which takes an additional `Type invocation_type'.
24283 * expression.cs (BaseAccess.DoResolve): Use the base type as
24284 invocation and query type.
24285 (MemberAccess.DoResolve): If the lookup failed and we're about to
24286 report a CS0122, try a lookup with the ec.ContainerType - if this
24287 succeeds, we must report a CS1540.
24289 2002-08-08 Martin Baulig <martin@gnome.org>
24291 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24292 (MethodGroupExpr): Implement the IMemberExpr interface.
24294 * expression (MemberAccess.ResolveMemberAccess): No need to have
24295 any special code for MethodGroupExprs anymore, they're now
24298 2002-08-08 Martin Baulig <martin@gnome.org>
24300 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24301 Family, FamANDAssem and FamORAssem permissions.
24302 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24304 2002-08-08 Martin Baulig <martin@gnome.org>
24306 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24307 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24310 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24312 * driver.cs: implemented /resource option to embed managed resources.
24314 2002-08-07 Martin Baulig <martin@gnome.org>
24316 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24317 (FieldBase.HasFieldInitializer): New public property.
24318 (FieldBase.GetInitializerExpression): New public method. Resolves and
24319 returns the field initializer and makes sure it is only resolved once.
24320 (TypeContainer.EmitFieldInitializers): Call
24321 FieldBase.GetInitializerExpression to get the initializer, this ensures
24322 that it isn't resolved multiple times.
24324 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24325 the resolving process (SimpleName/MemberLookup) that we're currently
24326 emitting a field initializer (which must not access any instance members,
24327 this is an error CS0236).
24329 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24330 argument, if the `IsFieldInitializer' flag is set, we must report and
24331 error CS0236 and not an error CS0120.
24333 2002-08-07 Martin Baulig <martin@gnome.org>
24335 * ecore.cs (IMemberExpr): New public interface.
24336 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24337 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24338 if the expression is an IMemberExpr.
24340 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24341 to be null, implicitly default to `this' if we're non-static in
24342 this case. Simplified the code a lot by using the new IMemberExpr
24343 interface. Also fixed bug #28176 here.
24345 2002-08-06 Martin Baulig <martin@gnome.org>
24347 * cs-parser.jay (SimpleLookup): Removed. We need to create
24348 ParameterReferences during semantic analysis so that we can do a
24349 type-only search when resolving Cast, TypeOf and SizeOf.
24350 (block): Pass the `current_local_parameters' to the Block's
24353 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24354 argument to the constructor.
24355 (ConstructorInitializer.Resolve): Create a temporary implicit
24356 block with the parameters.
24358 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24359 references here if we aren't doing a type-only search.
24361 * statement.cs (Block): Added constructor which takes a
24362 `Parameters parameters' argument.
24363 (Block.Parameters): New public property.
24365 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24366 to `Parameters' and made it public readonly.
24368 2002-08-06 Martin Baulig <martin@gnome.org>
24370 * ecore.cs (Expression.Warning): Made this public as well.
24372 * report.cs (Report.Debug): Print the contents of collections.
24374 2002-08-06 Martin Baulig <martin@gnome.org>
24376 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24377 used to tell Resolve() which kinds of expressions it may return.
24378 (Expression.Resolve): Added overloaded version of this method which
24379 takes a `ResolveFlags flags' argument. This can be used to tell
24380 Resolve() which kinds of expressions it may return. Reports a
24382 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24383 ResolveFlags.SimpleName.
24384 (Expression.Error118): Added overloaded version of this method which
24385 takes a `ResolveFlags flags' argument. It uses the flags to determine
24386 which kinds of expressions are allowed.
24388 * expression.cs (Argument.ResolveMethodGroup): New public method.
24389 Resolves an argument, but allows a MethodGroup to be returned.
24390 This is used when invoking a delegate.
24392 * TODO: Updated a bit.
24394 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24396 Fixed compilation with csc.
24398 * ecore.cs: Expression.Error made public. Is this correct? Should
24399 Warning be made public too?
24401 * expression.cs: use ea.Location instead of ea.loc.
24402 [FIXME: Filed as bug #28607: MCS must report these errors.]
24404 2002-08-06 Martin Baulig <martin@gnome.org>
24406 * ecore.cs (Expression.loc): Moved the location here instead of
24407 duplicating it in all derived classes.
24408 (Expression.Location): New public property.
24409 (Expression.Error, Expression.Warning): Made them non-static and
24410 removed the location argument.
24411 (Expression.Warning): Added overloaded version which takes an
24412 `int level' argument.
24413 (Expression.Error118): Make this non-static and removed the
24414 expression and location arguments.
24415 (TypeExpr): Added location argument to the constructor.
24417 * expression.cs (StaticCallExpr): Added location argument to
24419 (Indirection, PointerArithmetic): Likewise.
24420 (CheckedExpr, UnCheckedExpr): Likewise.
24421 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24422 (StringPtr): Likewise.
24425 2002-08-05 Martin Baulig <martin@gnome.org>
24427 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24429 * assign.cs (Assign.DoResolve): Check whether the source
24430 expression is a value or variable.
24432 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24433 while resolving the corresponding blocks.
24435 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24436 an error, don't silently return null.
24438 * statement.cs (Block.AddVariable): Do the error reporting here
24439 and distinguish between CS0128 and CS0136.
24440 (Block.DoResolve): Report all unused labels (warning CS0164).
24441 (LabeledStatement): Pass the location to the constructor.
24442 (LabeledStatement.HasBeenReferenced): New property.
24443 (LabeledStatement.Resolve): Set it to true here.
24445 * statement.cs (Return.Emit): Return success even after reporting
24446 a type mismatch error (CS0126 or CS0127), this is what csc does and
24447 it avoids confusing the users with any consecutive errors.
24449 2002-08-05 Martin Baulig <martin@gnome.org>
24451 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24453 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24455 * expression.cs (MemberAccess.DoResolve): Silently return if an
24456 error has already been reported.
24458 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24459 error has already been reported.
24461 2002-08-05 Martin Baulig <martin@gnome.org>
24463 * statement.cs (UsageVector): Only initialize the `parameters'
24464 vector if we actually have any "out" parameters.
24466 2002-08-05 Martin Baulig <martin@gnome.org>
24468 * expression.cs (Binary.ResolveOperator): When combining delegates,
24469 they must have the same type.
24471 2002-08-05 Martin Baulig <martin@gnome.org>
24473 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24474 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24475 work with the ms runtime and we also don't need it: if we're a
24476 PropertyBuilder and not in the `indexer_arguments' hash, then we
24477 are a property and not an indexer.
24479 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24480 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24481 since the latter one doesn't work with the ms runtime.
24483 2002-08-03 Martin Baulig <martin@gnome.org>
24485 Fixed bugs #27998 and #22735.
24487 * class.cs (Method.IsOperator): New public field.
24488 (Method.CheckBase): Report CS0111 if there's already a method
24489 with the same parameters in the current class. Report CS0508 when
24490 attempting to change the return type of an inherited method.
24491 (MethodData.Emit): Report CS0179 if a method doesn't have a body
24492 and it's not marked abstract or extern.
24493 (PropertyBase): New abstract base class for Property and Indexer.
24494 (PropertyBase.CheckBase): Moved here from Property and made it work
24496 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
24497 the same so we can reuse it there.
24498 (Property, Indexer): Derive from PropertyBase.
24499 (MethodSignature.inheritable_property_signature_filter): New delegate
24500 to find properties and indexers.
24502 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
24503 argument and improved error reporting.
24505 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
24506 EmptyReadOnlyParameters and made it a property.
24508 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
24509 version of this method which takes a `PropertyInfo indexer'.
24510 (TypeManager.RegisterIndexer): New method.
24512 * class.cs: Added myself as author of this file :-)
24514 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24516 * class.cs: fixed compilation on windoze.
24518 2002-08-03 Martin Baulig <martin@gnome.org>
24520 * interface.cs (Interface.GetInterfaceBases): Check whether all
24521 base interfaces are at least as accessible than the current one.
24523 * class.cs (TypeContainer.GetClassBases): Check whether base types
24524 are at least as accessible than the current type.
24525 (TypeContainer.AsAccessible): Implemented and made non-static.
24526 (MemberBase.CheckParameters): Report errors if the accessibility
24529 * delegate.cs (Delegate.Delegate): The default visibility is
24530 internal for top-level types and private for nested types.
24531 (Delegate.Define): Report errors if the accessibility checks fail.
24533 * enum.cs (Enum.Enum): The default visibility is internal for
24534 top-level types and private for nested types.
24535 (Enum.DefineType): Compute the correct visibility.
24537 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
24538 function which takes a `bool is_toplevel' instead of a TypeContainer.
24540 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
24543 2002-08-02 Martin Baulig <martin@gnome.org>
24545 * expression.cs (LocalVariableReferenc): Added constructor which
24546 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
24547 (LocalVariableReference.IsReadOnly): New property.
24548 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
24549 variable is readonly, use our own readonly flag to do this; you can
24550 use the new constructor to get a writable reference to a read-only
24553 * cs-parser.jay (foreach_statement, using_statement): Get a writable
24554 reference to the local variable.
24556 2002-08-01 Miguel de Icaza <miguel@ximian.com>
24558 * rootcontext.cs (ResolveCore): Also include System.Exception
24560 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
24561 we reach an EmptyStatement.
24563 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
24566 * expression.cs (Binary.ResolveOperator): Check error result in
24569 use brtrue/brfalse directly and avoid compares to null.
24571 2002-08-02 Martin Baulig <martin@gnome.org>
24573 * class.cs (TypeContainer.Define): Define all nested interfaces here.
24574 Fixes bug #28407, added test-155.cs.
24576 2002-08-01 Martin Baulig <martin@gnome.org>
24578 * class.cs (Event.EmitDefaultMethod): Make this work with static
24579 events. Fixes #28311, added verify-3.cs.
24581 2002-08-01 Martin Baulig <martin@gnome.org>
24583 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
24584 `is_disposable' fields.
24585 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
24586 `hm.is_disposable' if we're using the collection pattern.
24587 (Foreach.EmitCollectionForeach): Use the correct type for the
24588 enumerator's local variable, only emit the try/finally block if
24589 necessary (fixes #27713).
24591 2002-08-01 Martin Baulig <martin@gnome.org>
24593 * ecore.cs (Expression.report118): Renamed to Error118 and made
24596 * statement.cs (Throw.Resolve): Check whether the expression is of
24597 the correct type (CS0118) and whether the type derives from
24598 System.Exception (CS0155).
24599 (Catch.Resolve): New method. Do the type lookup here and check
24600 whether it derives from System.Exception (CS0155).
24601 (Catch.CatchType, Catch.IsGeneral): New public properties.
24603 * typemanager.cs (TypeManager.exception_type): Added.
24605 2002-07-31 Miguel de Icaza <miguel@ximian.com>
24607 * driver.cs: Updated About function.
24609 2002-07-31 Martin Baulig <martin@gnome.org>
24611 Implemented Control Flow Analysis.
24613 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
24614 (EmitContext.CurrentBranching): Added.
24615 (EmitContext.StartFlowBranching): Added.
24616 (EmitContext.EndFlowBranching): Added.
24617 (EmitContext.KillFlowBranching): Added.
24618 (EmitContext.IsVariableAssigned): Added.
24619 (EmitContext.SetVariableAssigned): Added.
24620 (EmitContext.IsParameterAssigned): Added.
24621 (EmitContext.SetParameterAssigned): Added.
24622 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
24623 Added control flow analysis stuff here.
24625 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
24626 resolve the expression as lvalue.
24627 (LocalVariableReference.DoResolve): Check whether the variable has
24628 already been assigned.
24629 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
24630 the parameter as assigned here.
24631 (ParameterReference.DoResolve): Check whether the parameter has already
24633 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
24634 expression as lvalue.
24636 * statement.cs (FlowBranching): New class for the flow analysis code.
24637 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
24638 (LabeledStatement.IsDefined): New public property.
24639 (LabeledStatement.AddUsageVector): New public method to tell flow
24640 analyis that the label may be reached via a forward jump.
24641 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
24643 (VariableInfo.Number): New public field. This is used by flow analysis
24644 to number all locals of a block.
24645 (Block.CountVariables): New public property. This is the number of
24646 local variables in this block (including the locals from all parent
24648 (Block.EmitMeta): Number all the variables.
24650 * statement.cs: Added flow analysis support to all classes.
24652 2002-07-31 Martin Baulig <martin@gnome.org>
24654 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
24655 To get debugging messages, compile mcs with /define:MCS_DEBUG and
24656 then use this argument.
24658 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
24660 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
24661 use this to specify /define options.
24663 2002-07-29 Martin Baulig <martin@gnome.org>
24665 * statement.cs (Fixed): Moved all code that does variable lookups
24666 and resolvings from Emit to Resolve.
24668 * statement.cs (For): Moved all code that does variable lookups
24669 and resolvings from Emit to Resolve.
24671 * statement.cs (Using): Moved all code that does variable lookups
24672 and resolvings from Emit to Resolve.
24674 2002-07-29 Martin Baulig <martin@gnome.org>
24676 * attribute.cs (Attribute.Resolve): Explicitly catch a
24677 System.NullReferenceException when creating the
24678 CustromAttributeBuilder and report a different warning message.
24680 2002-07-29 Martin Baulig <martin@gnome.org>
24682 * support.cs (ParameterData.ParameterName): Added method to
24683 get the name of a parameter.
24685 * typemanager.cs (TypeManager.IsValueType): New public method.
24687 2002-07-29 Martin Baulig <martin@gnome.org>
24689 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
24690 is a flag which specifies that it's either ref or out.
24691 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
24692 the out parameter to `out Parameter.Modifier mod', also set the
24693 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
24695 * support.cs (InternalParameters.ParameterModifier): Distinguish
24696 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24697 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24699 * expression.cs (Argument.GetParameterModifier): Distinguish
24700 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24701 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24703 2002-07-29 Martin Baulig <martin@gnome.org>
24705 * expression.cs (ParameterReference.ParameterReference): Added
24706 `Location loc' argument to the constructor.
24708 * cs-parser.jay: Pass location to ParameterReference.
24710 2002-07-28 Miguel de Icaza <miguel@ximian.com>
24712 * statement.cs (Try): Initialize the location.
24714 * cs-parser.jay: pass location to Try.
24716 * expression.cs (Unary.Reduce): Change the prototype to return
24717 whether a constant fold could be performed or not. The result is
24718 returned in an out parameters. In the case of Indirection and
24719 AddressOf, we want to perform the full tests.
24721 2002-07-26 Miguel de Icaza <miguel@ximian.com>
24723 * statement.cs (Statement.Emit): Flag dead code.
24725 2002-07-27 Andrew Birkett <andy@nobugs.org>
24727 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
24729 2002-07-27 Martin Baulig <martin@gnome.org>
24731 * class.cs (MethodData.Define): Put back call to
24732 TypeManager.AddMethod(), accidentally commented this out.
24734 * report.cs (Debug): New public method to print debugging information,
24735 this is `[Conditional ("DEBUG")]'.
24737 2002-07-26 Martin Baulig <martin@gnome.org>
24739 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
24740 (switch_statement): Push the current_block to the switch_stack and
24741 pop it again when we're done with the switch.
24742 (switch_section): The new block is a child of the current_block.
24743 Fixes bug #24007, added test-152.cs.
24745 2002-07-27 Martin Baulig <martin@gnome.org>
24747 * expression.cs (Invocation.EmitArguments): When calling a varargs
24748 function with only its fixed arguments, we need to pass an empty
24751 2002-07-27 Martin Baulig <martin@gnome.org>
24753 Mono 0.13 has been released.
24755 2002-07-25 Miguel de Icaza <miguel@ximian.com>
24757 * driver.cs: Rename --resource to --linkres, because that is what
24758 we do currently, we dont support --resource yet.
24760 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
24762 2002-07-25 Martin Baulig <martin@gnome.org>
24764 * class.cs (MethodData): New public class. This is a `method builder'
24765 class for a method or one accessor of a Property/Indexer/Event.
24766 (MethodData.GetMethodFlags): Moved here from MemberBase.
24767 (MethodData.ApplyAttributes): Likewise.
24768 (MethodData.ApplyObsoleteAttribute): Likewise.
24769 (MethodData.ApplyConditionalAttribute): Likewise.
24770 (MethodData.ApplyDllImportAttribute): Likewise.
24771 (MethodData.CheckAbstractAndExternal): Likewise.
24772 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
24773 (MethodData.Emit): Formerly known as Method.Emit().
24774 (MemberBase): Moved everything which was specific to a single
24775 accessor/method to MethodData.
24776 (Method): Create a new MethodData and call Define() and Emit() on it.
24777 (Property, Indexer, Event): Create a new MethodData objects for each
24778 accessor and call Define() and Emit() on them.
24780 2002-07-25 Martin Baulig <martin@gnome.org>
24782 Made MethodCore derive from MemberBase to reuse the code from there.
24783 MemberBase now also checks for attributes.
24785 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
24786 (MemberBase.GetMethodFlags): Moved here from class Method and marked
24788 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
24789 `CallingConventions cc' and `Attributes opt_attrs' arguments.
24790 (MemberBase.ApplyAttributes): New virtual method; applies the
24791 attributes to a method or accessor.
24792 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
24793 (MemberBase.ApplyConditionalAttribute): Likewise.
24794 (MemberBase.ApplyDllImportAttribute): Likewise.
24795 (MemberBase.CheckAbstractAndExternal): Likewise.
24796 (MethodCore.ParameterTypes): This is now a property instead of a
24797 method, it's initialized from DoDefineParameters().
24798 (MethodCore.ParameterInfo): Removed the set accessor.
24799 (MethodCore.DoDefineParameters): New protected virtual method to
24800 initialize ParameterTypes and ParameterInfo.
24801 (Method.GetReturnType): We can now simply return the MemberType.
24802 (Method.GetMethodFlags): Override the MemberBase version and add
24803 the conditional flags.
24804 (Method.CheckBase): Moved some code from Define() here, call
24805 DoDefineParameters() here.
24806 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
24807 here to avoid some larger code duplication.
24808 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
24809 ensure that abstract and external accessors don't declare a body.
24811 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
24812 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
24813 lookup in the attribute's parent classes, so we need to abort as soon
24814 as we found the first match.
24815 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
24816 the attribute has no arguments.
24818 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
24821 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24823 * cs-parser.jay: reverted previous patch.
24825 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24827 * cs-parser.jay: fixed bug #22119.
24829 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24831 * attribute.cs: fixed compilation. The error was:
24832 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
24833 be assigned to before control leaves the current method."
24834 [FIXME: Filed as bug #28186: MCS must report this error.]
24836 2002-07-25 Martin Baulig <martin@gnome.org>
24838 * attribute.cs (Attribute.Conditional_GetConditionName): New static
24839 method to pull the condition name ouf of a Conditional attribute.
24840 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
24841 the obsolete message and error flag out of an Obsolete attribute.
24843 * class.cs (Method.GetMethodFlags): New public method to get the
24844 TypeManager.MethodFlags for this method.
24845 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
24847 (Method.Define): Get and apply the Obsolete and Conditional attributes;
24848 if we're overriding a virtual function, set the new private variable
24849 `parent_method'; call the new TypeManager.AddMethod().
24851 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
24852 the MethodBuilder and the Method in a PtrHashtable.
24853 (TypeManager.builder_to_method): Added for this purpose.
24854 (TypeManager.MethodFlags): Added IsObsoleteError.
24855 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
24856 Obsolete and Conditional arguments in MethodBuilders. If we discover
24857 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
24858 the message from the attribute.
24860 2002-07-24 Martin Baulig <martin@gnome.org>
24862 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
24863 preprocessor directives, ensure that the argument to #define/#undef is
24864 exactly one identifier and that it's actually an identifier.
24866 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
24869 2002-07-24 Martin Baulig <martin@gnome.org>
24871 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
24872 initialize it to TypeManager.object_type in the constructor.
24873 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
24874 of the `hm.get_current' method if we're using the collection pattern.
24875 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
24876 for the explicit conversion to make it work when we're using the collection
24877 pattern and the `Current' property has a different return type than `object'.
24880 2002-07-24 Martin Baulig <martin@gnome.org>
24882 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
24883 does not match, but don't report any errors. This method is called in
24884 order for all methods in a MethodGroupExpr until a matching method is
24885 found, so we don't want to bail out if the first method doesn't match.
24886 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
24887 matches, report the 123. Fixes #28070.
24889 2002-07-24 Martin Baulig <martin@gnome.org>
24891 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
24892 TypeManager.TypeToCoreType() to the top of the method so the
24893 following equality checks will work. Fixes #28107.
24895 2002-07-24 Martin Baulig <martin@gnome.org>
24897 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
24898 operand is of type uint, and the other operand is of type sbyte,
24899 short or int, the operands are converted to type long." -
24900 Actually do what this comment already told us. Fixes bug #28106,
24903 2002-07-24 Martin Baulig <martin@gnome.org>
24905 * class.cs (MethodBase): New abstract class. This is now a base
24906 class for Property, Indexer and Event to avoid some code duplication
24907 in their Define() and DefineMethods() methods.
24908 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
24909 generic methods for Define() and DefineMethods().
24910 (FieldBase): Derive from MemberBase, not MemberCore.
24911 (Property): Derive from MemberBase, not MemberCore.
24912 (Property.DefineMethod): Moved all the code from this method to the
24913 new MethodBase.DefineAccessor(), just call it with appropriate
24915 (Property.Define): Call the new Property.DoDefine(), this does some
24916 sanity checks and we don't need to duplicate the code everywhere.
24917 (Event): Derive from MemberBase, not MemberCore.
24918 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
24919 accessors, this will also make them work with interface events.
24920 (Indexer): Derive from MemberBase, not MemberCore.
24921 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
24922 (Indexer.Define): Use the new MethodBase functions.
24924 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
24925 argument to the constructor.
24926 (Interface.FindMembers): Added support for interface events.
24927 (Interface.PopluateEvent): Implemented.
24929 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
24931 2002-07-22 Miguel de Icaza <miguel@ximian.com>
24933 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
24934 but this is required to check for a method name being the same as
24935 the containing class.
24939 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24941 * interface.cs: initialize variable.
24943 2002-07-23 Martin Baulig <martin@gnome.org>
24945 Implemented the IndexerName attribute in interfaces.
24947 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
24948 name if this is an explicit interface implementation.
24949 (Indexer.InterfaceIndexerName): New public variable. If we're
24950 implementing an interface indexer, this is the IndexerName in that
24951 interface. Otherwise, it's the IndexerName.
24952 (Indexer.DefineMethod): If we're implementing interface indexer,
24953 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
24954 and Pending.ImplementIndexer methods.
24955 (Indexer.Define): Also define the PropertyBuilder if we're
24956 implementing an interface indexer and this is neither an explicit
24957 interface implementation nor do the IndexerName match the one in
24960 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
24961 If a method is defined here, then we always need to create a proxy
24962 for it. This is used when implementing interface indexers.
24963 (Pending.IsInterfaceIndexer): New public method.
24964 (Pending.ImplementIndexer): New public method.
24965 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
24966 This is used when implementing interface indexers to define a proxy
24968 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
24969 define a proxy if necessary.
24971 * interface.cs (Interface.IndexerName): New public variable.
24972 (Interface.PopulateIndexer): Set the IndexerName.
24973 (Interface.DefineIndexers): New private method. Populate all the
24974 indexers and make sure their IndexerNames match.
24976 * typemanager.cs (IndexerPropertyName): Added support for interface
24979 2002-07-22 Martin Baulig <martin@gnome.org>
24981 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
24982 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
24983 ret if HasReturnLabel.
24984 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
24987 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
24988 and set the ec.LoopBeginTryCatchLevel.
24989 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
24990 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
24991 the current ec.TryCatchLevel, the branch goes out of an exception
24992 block. In this case, we need to use Leave and not Br.
24994 2002-07-22 Martin Baulig <martin@gnome.org>
24996 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
24997 block unless the block does not always return or it is contained in
24998 another try { ... } catch { ... } block. Fixes bug #26506.
24999 Added verify-1.cs to the test suite.
25001 2002-07-22 Martin Baulig <martin@gnome.org>
25003 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25004 then we do not always return. Fixes bug #24985.
25006 2002-07-22 Martin Baulig <martin@gnome.org>
25008 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25009 lookup on a per-class level; ie. walk up the class hierarchy until we
25010 found at least one applicable method, then choose the best among them.
25011 Fixes bug #24463 and test-29.cs.
25013 2002-07-22 Martin Baulig <martin@gnome.org>
25015 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25016 return types of the methods. The return type is not part of the
25017 signature and we must not check it to make the `new' modifier work.
25018 Fixes bug #27999, also added test-147.cs.
25019 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25021 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25022 on the method's return type.
25024 2002-07-21 Martin Baulig <martin@gnome.org>
25026 * assign.cs: Make this work if the rightmost source is a constant and
25027 we need to do an implicit type conversion. Also adding a few more tests
25028 to test-38.cs which should have caught this.
25030 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25031 target in the makefile for this. The makefile.gnu is primarily intended
25032 for end-users who don't want to debug the compiler.
25034 2002-07-21 Martin Baulig <martin@gnome.org>
25036 * assign.cs: Improved the Assign class so it can now handle embedded
25037 assignments (X = Y = Z = something). As a side-effect this'll now also
25038 consume less local variables. test-38.cs now passes with MCS, added
25039 a few new test cases to that test.
25041 2002-07-20 Martin Baulig <martin@gnome.org>
25043 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25044 instructions. Fixes bug #27977, also added test-146.cs.
25046 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25048 * cs-tokenizer.cs: fixed getHex ().
25050 2002-07-19 Martin Baulig <martin@gnome.org>
25052 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25053 not Type.GetType() to lookup the array type. This is needed when
25054 we're constructing an array of a user-defined type.
25055 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25056 single-dimensional arrays, but also for single-dimensial arrays of
25059 2002-07-19 Martin Baulig <martin@gnome.org>
25061 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25062 this function is called, it's not allowed to share LocalBuilders
25063 among ILGenerators.
25065 2002-07-19 Martin Baulig <martin@gnome.org>
25067 * expression.cs (Argument.Resolve): Report an error 118 when trying
25068 to pass a type as argument.
25070 2002-07-18 Martin Baulig <martin@gnome.org>
25072 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25073 Conv_R_Un for the signed `long' type.
25075 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25077 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25078 `expr' for the temporary result, as that will fail if we do
25079 multiple resolves on the same expression.
25081 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25083 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25084 ec.TypeContainer for looking up aliases.
25086 * class.cs (TypeContainer): Remove LookupAlias from here.
25088 * decl.cs (DeclSpace); Move here.
25090 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25092 * class.cs (FindMembers): Only call filter if the constructor
25093 bulider is not null.
25095 Also handle delegates in `NestedTypes' now. Now we will perform
25096 type lookups using the standard resolution process. This also
25099 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25100 This uses Expressions (the limited kind that can be parsed by the
25101 tree) instead of strings.
25103 * expression.cs (ComposedCast.ToString): Implement, used to flag
25104 errors since now we have to render expressions.
25106 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25109 * ecore.cs (SimpleName.ToString): ditto.
25111 * cs-parser.jay: Instead of using strings to assemble types, use
25112 Expressions to assemble the type (using SimpleName, ComposedCast,
25113 MemberAccess). This should fix the type lookups in declarations,
25114 because we were using a different code path for this.
25116 * statement.cs (Block.Resolve): Continue processing statements
25117 even when there is an error.
25119 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25121 * class.cs (Event.Define): Also remove the `remove' method from
25122 the list of pending items.
25124 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25125 generate more compact code.
25127 2002-07-17 Martin Baulig <martin@gnome.org>
25129 * const.cs (Const.LookupConstantValue): Add support for constant
25130 `unchecked' and `checked' expressions.
25131 Also adding test case test-140.cs for this.
25133 2002-07-17 Martin Baulig <martin@gnome.org>
25135 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25136 check whether mi.ReturnType implements the IEnumerator interface; the
25137 `==' and the IsAssignableFrom() will fail in this situation.
25139 2002-07-16 Ravi Pratap <ravi@ximian.com>
25141 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25144 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25146 * expression.cs: fixed bug #27811.
25148 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25150 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25151 Molaro: when we are a ref, the value already contains a pointer
25152 value, do not take the address of it.
25154 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25155 * removed mb-parser.jay and mb-tokenizer.cs
25157 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25159 * expression.cs: check against the building corlib void type.
25161 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25163 * ecore.cs: fix for valuetype static readonly fields: when
25164 initializing them, we need their address, not the address of a copy.
25166 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25168 * typemanager.cs: register also enum_type in corlib.
25170 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25172 * class.cs: allow calling this (but not base) initializers in structs.
25174 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25176 * ecore.cs: make sure we compare against the building base types
25179 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25181 * typemanager.cs: fix TypeToCoreType() to handle void and object
25182 (corlib gets no more typerefs after this change).
25184 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25186 * expression.cs (ArrayCreation.EmitArrayArguments): use
25187 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25189 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25190 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25191 array indexes, the runtime actually forbids them.
25193 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25194 for array arguments here.
25196 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25197 instead of the default for ValueTypes.
25199 (New.DoEmit): Use IsValueType instead of
25200 IsSubclassOf (value_type)
25201 (New.DoResolve): ditto.
25202 (Invocation.EmitCall): ditto.
25204 * assign.cs (Assign): ditto.
25206 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25207 Statements *are* currently doing part of their resolution during
25210 Expressions do always resolve during resolve, but statements are
25211 only required to propagate resolution to their children.
25213 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25215 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25217 (LoadAssembly): Do not add the dll if it is already specified
25219 (MainDriver): Add the System directory to the link path at the end,
25220 after all the other -L arguments.
25222 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25223 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25224 ldelem.u1) and using the opposite for sbytes.
25226 This fixes Digger, and we can finally run it.
25228 * driver.cs (UnixParseOption): Move the option parsing here.
25229 (CSCParseOption): Implement CSC-like parsing of options.
25231 We now support both modes of operation, the old Unix way, and the
25232 new CSC-like way. This should help those who wanted to make cross
25233 platform makefiles.
25235 The only thing broken is that /r:, /reference: and /lib: are not
25236 implemented, because I want to make those have the same semantics
25237 as the CSC compiler has, and kill once and for all the confussion
25238 around this. Will be doing this tomorrow.
25240 * statement.cs (Unsafe.Resolve): The state is checked during
25241 resolve, not emit, so we have to set the flags for IsUnsfe here.
25243 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25245 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25246 not catch the Error_ObjectRefRequired in SimpleName (as it is
25247 possible to have a class/instance variable name that later gets
25248 deambiguated), we have to check this here.
25250 2002-07-10 Ravi Pratap <ravi@ximian.com>
25252 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25253 make static and put into Expression.
25255 (Event.Define): Register the private field of the event with the
25256 TypeManager so that GetFieldFromEvent can get at it.
25258 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25259 keep track of the private field associated with an event which
25262 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25265 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25267 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25269 * expression.cs (Binary.EmitBranchable): this routine emits the
25270 Binary expression in a branchable context. This basically means:
25271 we need to branch somewhere, not just get the value on the stack.
25273 This works together with Statement.EmitBoolExpression.
25275 * statement.cs (Statement.EmitBoolExpression): Use
25278 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25280 * statement.cs (For): Reduce the number of jumps in loops.
25282 (For): Implement loop inversion for the For statement.
25284 (Break): We can be breaking out of a Try/Catch controlled section
25285 (foreach might have an implicit try/catch clause), so we need to
25286 use Leave instead of Br.
25288 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25289 now). If the instace expression supports IMemoryLocation, we use
25290 the AddressOf method from the IMemoryLocation to extract the
25291 address instead of emitting the instance.
25293 This showed up with `This', as we were emitting the instance
25294 always (Emit) instead of the Address of This. Particularly
25295 interesting when This is a value type, as we dont want the Emit
25296 effect (which was to load the object).
25298 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25300 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25302 * statement.cs (Checked): Set the CheckedState during the resolve
25303 process too, as the ConvCast operations track the checked state on
25304 the resolve process, and not emit.
25306 * cs-parser.jay (namespace_member_declaration): Flag that we have
25307 found a declaration when we do. This is used to flag error 1529
25309 * driver.cs: Report ok when we display the help only.
25311 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25313 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25315 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25317 * cs-tokenizer.cs (define): We also have to track locally the
25318 defines. AllDefines is just used for the Conditional Attribute,
25319 but we also need the local defines for the current source code.
25321 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25323 * statement.cs (While, For, Do): These loops can exit through a
25324 Break statement, use this information to tell whether the
25325 statement is the last piece of code.
25327 (Break): Flag that we break.
25329 * codegen.cs (EmitContexts): New `Breaks' state variable.
25331 2002-07-03 Martin Baulig <martin@gnome.org>
25333 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25334 modifiers in method declarations in structs. Otherwise, you won't
25335 be able to override things like Object.Equals().
25337 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25339 * class.cs (Method, Property, Indexer): Do not allow the public
25340 modifier to be used in explicit interface implementations.
25342 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25343 override modifiers in method declarations in structs
25345 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25347 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25348 integer or real overflow, report an error
25350 2002-07-02 Martin Baulig <martin@gnome.org>
25352 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25353 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25354 to tell the runtime about our newly created System.Object and
25355 System.ValueType types.
25357 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25359 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25360 struct instead of Ldarg/Starg.
25362 2002-07-02 Martin Baulig <martin@gnome.org>
25364 * expression.cs (Indirection.Indirection): Call
25365 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25367 2002-07-02 Martin Baulig <martin@gnome.org>
25369 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25370 ValueType, call TypeManager.TypeToCoreType() on it.
25371 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25372 the OpCodes.Newarr argument.
25374 2002-07-02 Martin Baulig <martin@gnome.org>
25376 * expression.cs (Invocation.EmitCall): When compiling corlib,
25377 replace all calls to the system's System.Array type to calls to
25378 the newly created one.
25380 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25381 System.Array methods.
25382 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25383 from the system's System.Array type which must be replaced.
25385 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25387 * typemanager.cs: load unverifiable_code_ctor so we can build
25388 corlib using the correct type. Avoid using GetTypeCode() with
25390 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25391 TypeManager.object_type to allow building corlib.
25393 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25395 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25397 2002-07-01 Martin Baulig <martin@gnome.org>
25399 * class.cs: Make the last change actually work, we need to check
25400 whether `ifaces != null' to avoid a crash.
25402 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25404 * class.cs: when we build structs without fields that implement
25405 interfaces, we need to add the interfaces separately, since there is
25406 no API to both set the size and add the interfaces at type creation
25409 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25411 * expression.cs: the dimension arguments to the array constructors
25412 need to be converted if they are a long.
25414 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25416 * class.cs: don't emit ldarg.0 if there is no parent constructor
25417 (fixes showstopper for corlib).
25419 2002-06-29 Martin Baulig <martin@gnome.org>
25421 MCS now compiles corlib on GNU/Linux :-)
25423 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25424 ie. check for MethodImplOptions.InternalCall.
25426 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25427 and TypeManager.attribute_type are null, so we must explicitly check
25428 whether parent is not null to find out whether it's an attribute type.
25429 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25430 and SetBuilder, not only if the property is neither abstract nor external.
25431 This is necessary to set the MethodImplOptions on the accessor methods.
25432 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25433 SetBuilder, see Property.Emit().
25435 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25436 populate "System.Object", "System.ValueType" and "System.Attribute" since
25437 they've already been populated from BootCorlib_PopulateCoreTypes().
25439 2002-06-29 Martin Baulig <martin@gnome.org>
25441 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25442 is the NullLiteral, we also need to make sure that target_type is not
25445 2002-06-29 Martin Baulig <martin@gnome.org>
25447 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25448 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25449 before calling BootstrapCorlib_ResolveDelegate ().
25451 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25453 * statement.cs: fixed build-breaker. All tests passed ok.
25455 2002-06-27 Martin Baulig <martin@gnome.org>
25457 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25458 for System.Decimal when compiling corlib.
25460 2002-06-27 Martin Baulig <martin@gnome.org>
25462 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25463 switch blocks which contain nothing but a default clause.
25465 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25467 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25469 2002-06-27 Martin Baulig <martin@gnome.org>
25471 * ecore.cs (PropertyExpr.PropertyExpr): Call
25472 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25474 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25475 is already a TypeBuilder.
25477 2002-06-27 Martin Baulig <martin@gnome.org>
25479 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25480 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25481 the "from an array-type to System.Array" case. This makes it work
25482 when compiling corlib.
25484 2002-06-27 Martin Baulig <martin@gnome.org>
25486 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
25487 non-static PropertyExpr, set its InstanceExpression. This makes
25488 the `ICollection.Count' property work in System/Array.cs.
25490 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
25492 * driver.cs: Made error handling more consistent. Errors now
25493 tracked by Report class, so many methods which used to return int
25494 now return void. Main() now prints success/failure and
25495 errors/warnings message.
25497 Renamed '--probe' compiler argument to '--expect-error'. Removed
25498 the magic number return values (123 and 124). Now, if the
25499 expected error occurs, the compiler exits with success (exit value
25500 0). If the compilation completes without seeing that particular
25501 error, the compiler exits with failure (exit value 1). The
25502 makefile in mcs/errors has been changed to handle the new behaviour.
25504 * report.cs: Made 'expected error' number a property and renamed
25505 it from 'Probe' to 'ExpectedError'.
25507 * genericparser.cs: Removed error handling support, since it is
25508 now all done by Report class.
25510 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
25511 class, so parse() no longer returns an int.
25513 * namespace.cs: Use Report.Error instead of GenericParser.error
25515 2002-06-22 Miguel de Icaza <miguel@ximian.com>
25517 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
25518 TypeContainer.AddOperator): At the front of the list put the
25519 explicit implementations, so they get resolved/defined first.
25521 2002-06-21 Miguel de Icaza <miguel@ximian.com>
25523 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
25524 interface type is implemented by this TypeContainer. Used during
25525 explicit interface implementation.
25527 (Property.Define, Indexer.Define, Method.Define): Validate that
25528 the given interface in the explicit implementation is one of the
25529 base classes for the containing type.
25531 Also if we are explicitly implementing an interface, but there is
25532 no match in the pending implementation table, report an error.
25534 (Property.Define): Only define the property if we are
25535 not explicitly implementing a property from an interface. Use the
25536 correct name also for those properties (the same CSC uses,
25537 although that is really not needed).
25539 (Property.Emit): Do not emit attributes for explicitly implemented
25540 properties, as there is no TypeBuilder.
25542 (Indexer.Emit): ditto.
25544 Hiding then means that we do not really *implement* a pending
25545 implementation, which makes code fail.
25547 2002-06-22 Martin Baulig <martin@gnome.org>
25549 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
25550 the return value of Object.GetType(). [FIXME: we need to do this whenever
25551 we get a type back from the reflection library].
25553 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
25555 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
25557 2002-06-20 Miguel de Icaza <miguel@ximian.com>
25559 * attribute.cs: Return null if we can not look up the type.
25561 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
25562 the interface types found.
25564 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
25565 interface types found.
25567 * typemanager.cs (GetInterfaces): Make this routine returns alll
25568 the interfaces and work around the lame differences between
25569 System.Type and System.Reflection.Emit.TypeBuilder in the results
25570 result for GetInterfaces.
25572 (ExpandInterfaces): Given an array of interface types, expand and
25573 eliminate repeated ocurrences of an interface. This expands in
25574 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
25577 2002-06-21 Martin Baulig <martin@gnome.org>
25579 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
25582 2002-06-21 Martin Baulig <martin@gnome.org>
25584 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
25585 and called with one of the core types, return the corresponding typebuilder for
25588 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
25591 2002-06-21 Martin Baulig <martin@gnome.org>
25593 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
25594 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
25595 (Expression.ConvertReferenceExplicit): Likewise.
25597 * expression.cs (ElementAccess.DoResolve): Likewise.
25598 (ElementAccess.DoResolveLValue): Likewise.
25600 2002-06-10 Martin Baulig <martin@gnome.org>
25602 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
25603 add the "value" parameter to the parameter list.
25605 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
25608 2002-06-19 Miguel de Icaza <miguel@ximian.com>
25610 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
25611 the argument to an int, uint, long or ulong, per the spec. Also
25612 catch negative constants in array creation.
25614 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
25616 * class.cs: do not allow the same interface to appear twice in
25617 the definition list.
25619 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
25621 * ecore.cs: don't use ldlen with System.Array.
25623 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
25625 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
25627 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
25629 * modifiers.cs: produce correct field attributes for protected
25630 internal. Easy fix so miguel can work on ther harder stuff:-)
25632 2002-06-18 Miguel de Icaza <miguel@ximian.com>
25634 * pending.cs: New file. Move the code from class.cs here.
25635 Support clearning the pending flag for all methods (when not doing
25636 explicit interface implementation).
25638 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
25640 * rootcontext.cs: added a couple more types needed to bootstrap.
25642 2002-06-17 Miguel de Icaza <miguel@ximian.com>
25644 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
25645 constructor in the type, instead of any constructor in the type
25646 hierarchy. Thanks to Paolo for finding this bug (it showed up as
25647 a bug in the Mono runtime when applying the params attribute).
25649 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25650 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
25652 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
25654 * expression.cs (Unary.ResolveOperator): Use TypeManager
25655 to resolve the type.
25657 2002-06-13 Ravi Pratap <ravi@ximian.com>
25659 * cs-parser.jay (enum_member_declaration): Pass in the attributes
25662 * enum.cs (AddEnumMember): Add support to store the attributes associated
25663 with each member too.
25665 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
25666 field builders too - this takes care of the enum member case.
25668 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
25670 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
25671 address-of operator on both value types and pointers.
25673 2002-06-10 Martin Baulig <martin@gnome.org>
25675 * interface.cs (Interface.PopulateIndexer): Add the indexer's
25676 PropertyBuilder to the `property_builders' list.
25678 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
25679 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
25680 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
25681 find any indexers which are inherited from an interface.
25683 2002-06-09 Martin Baulig <martin@gnome.org>
25685 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
25686 the same type as the constant if necessary. There's also a test-130.cs
25689 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
25691 * typemanager.cs (TypeManager.ChangeType): Previously known as
25692 Enum.ChangeEnumType().
25694 2002-06-09 Martin Baulig <martin@gnome.org>
25696 * expression.cs (Cast.TryReduce): Added support for consts.
25698 2002-06-08 Ravi Pratap <ravi@ximian.com>
25700 * class.cs (Accessor): Hold attributes information so we can pass
25703 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
25704 Modify to pass in attributes attached to the methods.
25706 (add_accessor_declaration, remove_accessor_declaration): Ditto.
25708 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
25709 to handle the Accessor kind :-)
25711 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
25713 2002-06-08 Martin Baulig <martin@gnome.org>
25715 * expression.cs (Unary.TryReduceNegative): Added support for
25718 2002-06-08 Martin Baulig <martin@gnome.org>
25720 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
25721 name can't be found in the `defined_names' - the caller will do a
25722 MemberLookup in this case and thus find methods in System.Enum
25723 such as Enum.IsDefined().
25725 2002-06-08 Martin Baulig <martin@gnome.org>
25727 * enum.cs (Enum.ChangeEnumType): This is a custom version of
25728 Convert.ChangeType() which works with TypeBuilder created types.
25729 (Enum.LookupEnumValue, Enum.Define): Use it here.
25731 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
25732 `TypeBuilder.BaseType != null' check.
25733 (TypeContainer.FindMembers): Only lookup parent members if we
25734 actually have a parent.
25735 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
25736 (ConstructorInitializer.Resolve): Likewise.
25738 * interface.cs (Interface.FindMembers): Added
25739 `TypeBuilder.BaseType != null' check.
25741 * rootcontext.cs (RootContext.ResolveCore): Added
25742 "System.Runtime.CompilerServices.IndexerNameAttribute" to
25743 classes_second_stage.
25745 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
25746 debug_type and trace_type when compiling with --nostdlib.
25748 2002-06-07 Martin Baulig <martin@gnome.org>
25750 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
25751 (AddField): Set it to true when adding a non-static field.
25752 (DefineType): Use `have_nonstatic_fields' to find out whether we
25753 have non-static fields, not `Fields != null'.
25755 2002-06-02 Miguel de Icaza <miguel@ximian.com>
25757 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
25758 dereferencing a null on the static-field code path)
25760 2002-05-30 Martin Baulig <martin@gnome.org>
25762 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
25763 to take command line arguments. Use reflection to call the new
25764 custom `Initialize' function on the symbol writer and pass it the
25765 command line arguments.
25767 * driver.cs (--debug-args): New command line argument to pass command
25768 line arguments to the symbol writer.
25770 2002-05-28 Miguel de Icaza <miguel@ximian.com>
25772 * assign.cs (DoResolve): Forgot to do the implicit conversion to
25773 the target type for indexers and properties. Thanks to Joe for
25776 2002-05-27 Miguel de Icaza <miguel@ximian.com>
25778 * typemanager.cs (MethodFlags): returns the method flags
25779 (Obsolete/ShouldIgnore) that control warning emission and whether
25780 the invocation should be made, or ignored.
25782 * expression.cs (Invocation.Emit): Remove previous hack, we should
25783 not do this on matching a base type, we should do this based on an attribute
25785 Only emit calls to System.Diagnostics.Debug and
25786 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
25787 on the command line.
25789 * rootcontext.cs: Global settings for tracing and debugging.
25791 * cs-tokenizer.cs (define): New utility function to track
25792 defines. Set the global settings for TRACE and DEBUG if found.
25794 2002-05-25 Ravi Pratap <ravi@ximian.com>
25796 * interface.cs (Populate*): Pass in the TypeContainer as well as
25797 the DeclSpace as parameters so that we can create EmitContexts and
25798 then use that to apply attributes etc.
25800 (PopulateMethod, PopulateEvent, PopulateProperty)
25801 (PopulateIndexer): Apply attributes everywhere.
25803 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
25806 (ApplyAttributes): Update accordingly.
25808 We now apply interface attributes for all members too.
25810 2002-05-26 Miguel de Icaza <miguel@ximian.com>
25812 * class.cs (Indexer.Define); Correctly check if we are explicit
25813 implementation (instead of checking the Name for a ".", we
25814 directly look up if the InterfaceType was specified).
25816 Delay the creation of the PropertyBuilder.
25818 Only create the PropertyBuilder if we are not an explicit
25819 interface implementation. This means that explicit interface
25820 implementation members do not participate in regular function
25821 lookups, and hence fixes another major ambiguity problem in
25822 overload resolution (that was the visible effect).
25824 (DefineMethod): Return whether we are doing an interface
25827 * typemanager.cs: Temporary hack until we get attributes in
25828 interfaces (Ravi is working on that) and we get IndexerName
25829 support in interfaces.
25831 * interface.cs: Register the indexers as properties.
25833 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
25834 warning, I have verified that this is a bug in the .NET runtime
25835 (JavaScript suffers of the same problem).
25837 * typemanager.cs (MemberLookup): When looking up members for
25838 interfaces, the parent of an interface is the implicit
25839 System.Object (so we succeed in searches of Object methods in an
25840 interface method invocation. Example: IEnumerable x; x.ToString
25843 2002-05-25 Miguel de Icaza <miguel@ximian.com>
25845 * class.cs (Event): Events should also register if they do
25846 implement the methods that an interface requires.
25848 * typemanager.cs (MemberLookup); use the new GetInterfaces
25851 (GetInterfaces): The code used to lookup interfaces for a type is
25852 used in more than one place, factor it here.
25854 * driver.cs: Track the errors at the bottom of the file, we kept
25857 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
25858 instance if the method we are calling is static!
25860 2002-05-24 Miguel de Icaza <miguel@ximian.com>
25862 * attribute.cs (ApplyAttributes): Make this function filter out
25863 the IndexerName attribute (as that attribute in reality is never
25864 applied) and return the string constant for the IndexerName
25867 * class.cs (TypeContainer.Emit): Validate that all the indexers
25868 have the same IndexerName attribute, and if so, set the
25869 DefaultName attribute on the class.
25871 * typemanager.cs: The return value might contain other stuff (not
25872 only methods). For instance, consider a method with an "Item"
25873 property and an Item method.
25875 * class.cs: If there is a problem with the parameter types,
25878 2002-05-24 Ravi Pratap <ravi@ximian.com>
25880 * ecore.cs (ImplicitConversionExists): Wrapper function which also
25881 looks at user defined conversion after making a call to
25882 StandardConversionExists - we need this for overload resolution.
25884 * expression.cs : Update accordingly the various method calls.
25886 This fixes 2 bugs filed against implicit user defined conversions
25888 2002-05-22 Miguel de Icaza <miguel@ximian.com>
25890 * statement.cs: Track the result of the assignment.
25892 2002-05-21 Miguel de Icaza <miguel@ximian.com>
25894 * expression.cs (MemberAccess): Improved error reporting for
25895 inaccessible members.
25897 2002-05-22 Martin Baulig <martin@gnome.org>
25899 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
25900 itself with debugging support.
25902 2002-05-22 Martin Baulig <martin@gnome.org>
25904 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
25905 Removed, this isn't needed anymore.
25907 2002-05-20 Martin Baulig <martin@gnome.org>
25909 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
25910 be underlying type for an enum.
25912 2002-05-20 Miguel de Icaza <miguel@ximian.com>
25914 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
25915 that splits out the loading of just the core types.
25917 * rootcontext.cs (ResolveCore): Split the struct resolution in
25918 two, so we can load the enumeration underlying types before any
25921 * expression.cs (Is): Bandaid until we fix properly Switch (see
25922 bug #24985 for details).
25924 * typemanager.cs (ImplementsInterface): The hashtable will contain
25925 a null if there are no interfaces implemented.
25927 2002-05-18 Miguel de Icaza <miguel@ximian.com>
25929 * cs-parser.jay (indexer_declarator): It is fine to have array
25932 2002-05-17 Miguel de Icaza <miguel@ximian.com>
25934 * typemanager.cs: (RegisterBuilder): New function used to register
25935 TypeBuilders that implement interfaces. Since
25936 TypeBuilder.GetInterfaces (as usual) does not work with lame
25938 (AddUserType): register interfaces.
25940 (ImplementsInterface): Use the builder_to_ifaces hash if we are
25941 dealing with TypeBuilder. Also, arrays are showing up as
25942 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
25943 methods can not be invoked on them!
25945 * ecore.cs (ExplicitReferenceConversionExists): Made public.
25946 (ImplicitReferenceConversionExists): Split out from
25947 StandardConversionExists.
25949 * expression.cs (As): We were only implementing one of the three
25950 cases for the as operator. We now implement them all.
25951 (Is): Implement the various other cases for Is as well.
25953 * typemanager.cs (CACHE): New define used to control if we want or
25954 not the FindMembers cache. Seems to have a negative impact on
25955 performance currently
25957 (MemberLookup): Nested types have full acess to
25958 enclosing type members
25960 Remove code that coped with instance/static returns for events, we
25961 now catch this in RealFindMembers.
25963 (RealFindMembers): only perform static lookup if the instance
25964 lookup did not return a type or an event.
25966 2002-05-17 Miguel de Icaza <miguel@ximian.com>
25968 * assign.cs (CompoundAssign): We pass more semantic information
25969 now to Compound Assignments than we did before: now we have all
25970 the information at hand, and now we resolve the target *before* we
25971 do the expression expansion, which allows the "CacheValue" method
25972 to have the effect we intended (before, a [x] += 1 would generate
25973 two differen ArrayAccess expressions from the ElementAccess,
25974 during the resolution process).
25976 (CompoundAssign.DoResolve): Resolve target and original_source here.
25978 2002-05-16 Miguel de Icaza <miguel@ximian.com>
25980 * expression.cs (ArrayAccess): dropped debugging information.
25982 * typemanager.cs: Small bug fix: I was always returning i_members,
25983 instead of one of i_members or s_members (depending on which had
25986 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
25987 method is invoked before any code generation takes place, and it
25988 is a mechanism to inform that the expression will be invoked more
25989 than once, and that the method should use temporary values to
25990 avoid having side effects
25992 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
25994 * ecore.cs (Expression.CacheTemporaries): Provide empty default
25997 * expression.cs (Indirection, ArrayAccess): Add support for
25998 CacheTemporaries in these two bad boys.
26000 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26001 ldobj or ldind_ref.
26002 (StoreFromPtr): Handle stobj as well.
26004 * expression.cs (UnaryMutator): Share more code.
26006 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26007 down: I was not tracking the Filter function as well, which
26008 was affecting the results of the cache.
26010 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26012 * attribute.cs: Remove the hack to handle the CharSet property on
26015 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26017 * attribute.cs (DoResolve): More uglyness, we now only try to
26018 resolve the attribute partially, to extract the CharSet
26019 information (only if we are a StructLayout attribute). Otherwise
26021 (GetExtraTypeInfo): Add some code to conditionally kill in the
26022 future this. I am more and more convinced that the .NET
26023 framework has special code to handle the attribute setting on
26026 * expression.cs (IsParamsMethodApplicable): Revert my previous
26027 foreach change here, it was wrong.
26029 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26031 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26032 (pp_expr): do not abort on unknown input, just return.
26033 (eval): abort if there are pending chars.
26035 * attribute.cs (Attribute.Resolve): Positional parameters are
26036 optional. Deal with that case.
26038 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26039 the Ansi/Unicode/Auto information for the type.
26041 (TypeContainer.DefineType): instantiate the EmitContext here, as
26042 we will be using it during the type definition (to resolve
26043 attributes) and during the emit phase.
26045 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26046 to pull type information out of the attributes
26048 (Attribute.Resolve): track the constructor builder, and allow for
26049 multiple invocations (structs and classes will use this).
26051 * ecore.cs (MemberLookupFinal): new version with all the
26052 parameters customizable.
26054 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26055 constructors. Return if the result value is null (as the error
26056 would have been flagged already by MemberLookupFinal)
26058 Do not allow instances of abstract classes or interfaces to be
26061 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26062 We have to compare the assembly property here when dealing with
26063 FamANDAssem and Assembly access modifiers, because we might be
26064 creating an assembly from *modules* (that means that we are not
26065 getting TypeBuilders for types defined in other modules that are
26066 part of this assembly).
26068 (Method.Emit): If the method is marked abstract and has a body,
26071 (TypeContainer.DefineMembers): If both the defined member and the
26072 parent name match are methods, then do not emit any warnings: let
26073 the Method.Define routine take care of flagging warnings. But if
26074 there is a mismatch (method overrides something else, or method is
26075 overriwritten by something, then emit warning).
26077 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26078 set to null, this means `do not check for the return type on the
26081 (Method.Define): set the return type for the method signature to
26082 null, so that we get methods with the same name and parameters and
26083 different return types. This is used to flag warning 114 (you are
26084 hiding a method, and you probably want to use the new/override
26087 * typemanager.cs (MemberLookup): Implemented proper access
26088 control, closing a long standing set of bug reports. The problem
26089 was that the Framework only has two bits: Public and NonPublic,
26090 and NonPublic includes private and protected methods, but we need
26091 to enforce the FamANDAssem, FamOrAssem and Family.
26093 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26095 * statement.cs (GotoCase): Return true: Ammounts to giving up
26096 knowledge on whether we return or not, and letting the other case
26097 be responsible for it.
26099 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26101 * driver.cs: Do not load directories for each file processed, only
26102 do it if there is a pattern.
26104 * ecore.cs: Report readonly assigns here as well, as we might have
26105 been resolved only by MemberAccess.
26107 (SimpleName.SimpleNameResolve): Also be useful for LValue
26108 resolution. We need this to propagate assign to local readonly variables
26110 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26111 do not want to reuse potential criteria memory.
26113 * class.cs (MyEventBuilder): Set reflected_type;
26115 * ecore.cs (Constantify): Added support for constifying bools.
26117 (RootContext.LookupType): Added a cache for values looked up in
26118 the declaration space.
26120 * typemanager.cs (FindMembers): Now is a front-end to
26121 RealFindMembers, and provides a two-level hashtable-based cache to
26124 15% performance improvement: from 22.5 to 19.2 seconds.
26126 * expression.cs (IsParamsMethodApplicable): use foreach.
26127 (Invocation.DoResolve): ditto.
26128 (New.DoResolve): ditto.
26129 (ArrayCreation.DoResolve): ditto.
26131 * ecore.cs (FindMostEncompassingType): use foreach.
26133 * delegate.cs (NewDelegate.DoResolve): Use foreach
26135 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26136 (RemoveMethods): use foreach.
26138 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26139 nested foreach statements instead of for, and also break out of
26140 the inner loop once a match is found.
26142 (Invocation.OverloadResolve): Use foreach, simplify the code.
26144 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26146 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26147 we actually unwrap the expression to allow for extra information
26150 * expression.cs: Use Shr_Un on unsigned operations.
26152 2002-05-08 Ravi Pratap <ravi@ximian.com>
26154 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26155 applicable operators was not being considered correctly. This closes
26156 the bug Miguel reported.
26158 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26160 * attribute.cs: check that the type derives from System.Attribute
26161 and report the correct error in that case (moved the duplicate code to
26162 its own method, too).
26164 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26166 * attribute.cs: lookup attribute type name as the spec says: first the
26167 bare attribute name and then name + "Attribute" (nant compiles with
26168 mcs after this fix).
26170 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26172 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26173 Because of the way we parse things, we should try to see if a
26174 UIntConstant can fit in an integer.
26176 2002-05-07 Ravi Pratap <ravi@ximian.com>
26178 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26179 when we are in an explicit context.
26181 (ConvertReferenceExplicit): When converting from Iface type S to Class
26182 T make sure the rules are implemented as an OR.
26184 * parameter.cs (ParameterType): Make it a property for now although the
26185 purpose really isn't anything immediate.
26187 * expression.cs (Is*Applicable): Do better checking on the parameter type
26188 of a ref/out parameter. The ones from the system assemblies are already
26189 marked with the correct type so we don't need to do any correction.
26191 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26192 the object type is standard too so include that.
26194 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26196 * ecore.cs (StandardConversionExists): Augment with missing code:
26197 deal with IntConstant, LongConstants and Enumerations.
26199 * assign.cs: Report the error, instead of failing silently
26201 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26202 typecontainer that they are declared, because the
26203 typecontainer/namespace will have the list of using clauses that
26204 need to be applied.
26206 Assembly Attributes were escaping the normal registration
26209 (EmitCode): Apply attributes within an EmitContext that represents
26210 the container they were declared on.
26212 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26214 2002-05-06 Ravi Pratap <ravi@ximian.com>
26216 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26217 Revamp completely - make much cleaner as we now operate only
26220 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26221 to implement the logic detailed in the spec more correctly.
26223 (UserDefinedConversion): Update accordingly.
26225 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26227 * statement.cs: Return flow analysis information up.
26229 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26232 (token): Do not consume an extra character before calling
26235 2002-05-06 Piers Haken <piersh@friskit.com>
26237 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26239 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26241 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26242 EmitContext during the instance constructor initializer
26243 resolution, to stop access to instance variables.
26245 This is mandated by the spec, last paragraph of the `constructor
26246 initializers' section.
26248 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26250 * cs-parser.jay, class.cs (Accessor): new class used to represent
26251 an accessor (get or set). In the past we used `null' to represent
26252 a missing accessor. But this is ambiguous because there was no
26253 way to tell in abstract indexers/properties if one of them was
26256 Now there is a way of addressing that.
26258 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26259 instead of FindMembers.
26261 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26262 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26264 * attribute.cs: Treat indexers and properties as the same in terms
26265 of applying attributes
26267 * ecore.cs (FindMostEncompassedType): Use statically initialized
26268 EmptyExpressions()s like we do elsewhere to avoid creating useless
26269 objects (and we take this out of the tight loop).
26271 (GetConversionOperators): Move the code to extract the actual
26272 operators to a separate routine to clean things up.
26274 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26276 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26277 events are always registered FieldBuilders.
26279 * class.cs (FieldBase): New class shared by Fields
26281 * delegate.cs: If we are a toplevel delegate, use our full name.
26282 If we are a nested delegate, then only use our tail name.
26284 2002-05-02 Ravi Pratap <ravi@ximian.com>
26286 * expression.cs (IsApplicable): Ensure that we add the "&" to
26287 ref/out types before comparing it with the type of the argument.
26289 (IsParamsMethodApplicable): Ditto.
26291 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26294 * delegate.cs : Handle the case when we have more than one applicable
26295 method. Flag an error only when we finish checking all.
26297 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26299 * expression.cs: Add support for boolean static initializers.
26301 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26303 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26305 * parameter.cs (ComputeParameterTypes,
26306 ComputeAndDefineParameterTypes): Better error handling: now we
26307 clear the `types' cache if we fail during any of the type lookups.
26308 We also return the status code correctly to our caller
26310 * delegate.cs: If we fail to define a delegate, abort the extra
26313 * expression.cs (Binary.ResolveOperator): for
26314 operator==(object,object) and operator !=(object, object) we also
26315 have to verify that there is an implicit conversion from one to
26318 (ArrayAccess.DoResolve): Array Access can operate on
26321 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26323 * assign.cs (CompoundAssign): A new class used as a "flag" that
26324 the assignment actually is happening as part of a compound
26325 assignment operator.
26327 During compound assignment, a few new rules exist to enable things
26334 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26335 to the type of x) if y is implicitly convertible to the type of x,
26336 and the operator is a builtin operator and the return type of the
26337 operator is explicitly convertible to the type of x.
26339 * rootcontext.cs: Reset warning level to 2. 4 catches various
26340 "interesting" features in mcs, we must clean this up at some
26341 point, but currently am trying to kill other bugs ;-)
26343 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26344 in container classes as well.
26346 * expression.cs (Binary.ResolveOperator): Handle string case
26347 before anything else (as operator overloading does emit an error
26348 before doing anything else).
26350 This code could go away when we move to a table driven model, but
26351 i could not come up with a good plan last night.
26353 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26355 * typemanager.cs (CSharpName): reimplementation using regex.
26356 * class.cs: added null check for fields in Emit
26357 * rootcontext.cs: set warninglevel to 4
26359 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26361 * typemanager.cs (CSharpName): reimplemented with Lupus
26364 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26366 * statement.cs (If): correclty implement Resolve, because we were
26367 not catching sem errors in there. The same process is needed
26369 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26372 (Statement.Warning_DeadCodeFound): Factorize code.
26373 (While): Report dead code here too.
26375 (Statement): Added Resolve virtual method to allow
26376 for resolution split from the emit code.
26378 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26380 * statement.cs (EmitBoolExpression): No longer try to resolve the
26382 (MakeBoolean): New utility function that resolve, implicitly
26383 converts to boolean and tags the expression.
26386 (If, Do): Implement dead code elimination.
26387 (While): Implement loop inversion
26389 (Do, While, For, If): Resolve the expression prior to calling our
26392 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26395 - added method Report28 (warning: program has more than one entry point)
26396 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26397 - modified method Method.Define, the part at the end of the method
26399 * rootcontext.cs: added static public Location EntryPointLocation;
26401 * ../errors/cs0028.cs : Add test case for the above warning.
26404 - modified method CSharpName to allow arrays of primitive type to
26405 be printed nicely (e.g. instead of System.Int32[][] it now prints
26407 - added method CSharpSignature: returns the signature of a method
26408 in string format to be used in reporting errors, warnings, etc.
26410 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26413 2002-04-26 Ravi Pratap <ravi@ximian.com>
26415 * delegate.cs (Define): Fix extremely silly bug where I was
26416 setting the type of the 'object' parameter of the BeginInvoke
26417 method to System.IAsyncResult instead of System.Object ;-)
26419 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26421 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26424 (Constructor.Emit): return if we fail to initialize the
26425 constructor. Another door closed!
26427 * expression.cs (New.DoResolve): Improve error message (from -6 to
26428 1501). Use DeclaredOnly lookup to find the exact constructor.
26430 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26431 loop. This is useful.
26433 * cs-parser.jay: Adjust the default parameters so that destructors
26434 have the proper signature.
26436 2002-04-26 Martin Baulig <martin@gnome.org>
26438 * driver.cs (LoadAssembly): If `assembly' contains any characters
26439 which are only valid in path names and not in assembly names
26440 (currently slash, backslash and point), use Assembly.LoadFrom ()
26441 instead of Assembly.Load () on the `assembly' (before iteration
26442 over the link_paths).
26444 2002-04-26 Martin Baulig <martin@gnome.org>
26446 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26448 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26450 * class.cs (Property): use the new typemanager.MemberLookup
26452 (TypeContainer.MemberLookup): Implement using the
26453 TypeManager.MemberLookup now.
26455 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26456 and return MemberInfos, so that these can be used without an
26457 EmitContext (what we had before).
26459 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26461 * expression.cs: Fix the case where the argument to params if the
26462 type of the params. I omitted handling this before. Fixed
26464 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26466 * driver.cs: Call BootCorlib_PopulateCoreType
26468 * class.cs (Property.CheckBase): Check for properties only, not
26471 * interface.cs: Temporary hack: try/catch around the
26472 CustomAttributeBuilder, because I am getting an exception that I
26475 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26476 types whose definitions are required to be there (attributes are
26477 defined before standard types).
26479 Compute definitions as we boot the various types, as they are used
26480 immediately (value_type class will need object_type, but if we do
26481 not initialize object_type, we will pass a null, which will let
26482 the runtime pick the System.Object from the existing corlib, which
26483 is not what we want).
26485 2002-04-22 Patrik Torstensson <totte@labs2.com>
26487 * cs-tokenizer.cs: fixed a number of trim() issues.
26489 2002-04-22 Ravi Pratap <ravi@ximian.com>
26491 * expression.cs (Argument.Type): Ensure that we return the correct
26492 type when we have out or ref parameters [in which case we
26495 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26497 * class.cs (Property, Indexer): Allow extern modifier in there.
26499 * typemanager.cs (InitBaseTypes): Initializes object_type and
26500 value_type, since those will be used early on during the bootstrap
26501 process to compile corlib.
26503 (InitCoreTypes): Move code from here to InitBaseTypes.
26505 2002-04-21 Miguel de Icaza <miguel@ximian.com>
26507 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
26508 single-dimension arrays as using the ldlen opcode.
26510 Daniel Lewis discovered this optimization.
26512 * typemanager.cs: Add signature for System.Array::get_Length
26514 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26516 * statement.cs: report the error when the foreach does not apply to an
26517 array nor a collection.
26519 2002-04-19 Miguel de Icaza <miguel@ximian.com>
26521 * expression.cs: Add implicit conversions to the operator ~.
26523 * constant.cs (DecimalConstant.Emit): Emit decimal value.
26525 * typemanager.cs: Locate the decimal constructor.
26527 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26529 * attribute.cs: use the new property of TypeOf.
26530 * expression.cs: added 'get' property around typearg.
26532 These changes fix a build breaker reported by NickD. Is this the
26533 correct way to fix? If not, please, revert my changes and make it
26536 2002-04-17 Miguel de Icaza <miguel@ximian.com>
26538 * attribute.cs: Add support for typeof in attribute invocations.
26539 I am not sure that this is right though.
26541 2002-04-14 Duncan Mak <duncan@ximian.com>
26543 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
26544 Binary.Operator.Division case.
26546 2002-04-13 Ravi Pratap <ravi@ximian.com>
26548 * class.cs (DefineType): Ensure that we do a proper check on
26549 attribute types and also register it with the TypeManager.
26551 (TypeContainer.Targets): The default for attribute types is
26552 AttributeTargets.All.
26554 * attribute.cs (ApplyAttributes): Registering the attribute type
26555 is done elsewhere, not when we discover we have a Usage attribute.
26557 2002-04-12 Ravi Pratap <ravi@ximian.com>
26559 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
26560 and get rid of is_delegate parameter.
26562 * everywhere : update.
26564 2002-04-12 Ravi Pratap <ravi@ximian.com>
26566 * cs-parser.jay (compilation_unit): Revamp completely to use
26567 some new ideas that I got from Rhys' grammar to solve the problems
26568 with assembly level attributes.
26570 (outer_declaration): New grammar production.
26572 (attribute_sections): Add.
26574 (opt_attributes): Base on attribute_sections
26576 (namespace_declaration): Allow opt_attributes to tackle the case
26577 when we have assembly level attributes - we are clever in this
26580 * attribute.cs (ApplyAttributes): Do not worry about assembly
26581 attributes in the non-global context.
26583 * rootcontext.cs (AddGlobalAttributes): Go back to using this
26584 instead of SetGlobalAttributes.
26586 * class.cs, rootcontext.cs : Ensure we define and generate
26587 attribute types before anything else.
26589 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
26590 and flag the new error -20 for the case when the attribute type
26591 does not have valid targets specified. csc does not catch this.
26593 * ../errors/errors.txt : update for error # -20
26595 2002-04-11 Ravi Pratap <ravi@ximian.com>
26597 * support.cs (InternalParameters.ParameterModifier): Do some null
26598 checking and return sane values.
26600 * class.cs (Method.Define): If we are a PInvoke method, ensure
26601 that we are static and extern. Report error # 601
26603 * ../errors/cs0601.cs : Add test case for the above error.
26605 2002-04-07 Ravi Pratap <ravi@ximian.com>
26607 * rootcontext.cs (attribute_types): We need to keep type of
26608 all attribute types separately and emit code for them first.
26610 (RegisterAttribute) : Implement.
26612 * class.cs (DefineType): Check if the current Type is a custom
26613 attribute type and register it accordingly.
26615 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
26616 adding the first attribute twice and rename to
26618 (SetGlobalAttributes): this.
26620 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
26623 * attribute.cs (ApplyAttributes): Take an additional argument telling us
26624 if we are processing global arguments. Hmm, I am unsure of this.
26626 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26628 * expression.cs: added static array of strings to avoid calling
26629 Enum.ToString () for Operator in Binary. Significant recover of
26632 2002-04-10 Miguel de Icaza <miguel@ximian.com>
26634 * class.cs (FindMembers): Allow the Builders of the various
26635 members to be null. If they are skip them. This only happens
26636 during the PInvoke declaration.
26638 2002-04-09 Miguel de Icaza <miguel@ximian.com>
26640 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
26641 failure, so we do not keep going afterwards.
26643 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
26644 wanted to pass `false' as the `is_delegate' argument. If this is
26645 the case, why not use delegate_type == null to mean `is_delegate =
26646 false' and anything else as is_delegate = true.
26648 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
26650 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
26651 code for the section, not the beginning of the tests.
26653 2002-04-08 Miguel de Icaza <miguel@ximian.com>
26655 * cfold.cs: Handle operator + (Enum x, Underlying x)
26657 * expression.cs (Binary): same. Warn about errors where we have
26658 Enum/Enum in operator + as well.
26660 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
26663 - added support for switch(bool)
26664 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
26665 - add TableSwitchEmit() to handle table-based switch statements
26667 2002-04-05 Ravi Pratap <ravi@ximian.com>
26669 * expression.cs (Invocation.OverloadResolve): Factor out code which
26670 does parameter compatibility checking with arguments so that we can
26671 re-use the code even from Delegate.VerifyApplicability
26673 (VerifyArgumentsCompat): Move above code here.
26675 * delegate.cs (VerifyApplicability): Get rid of duplicate code
26676 and instead make a call to the above method.
26678 2002-03-31 Ravi Pratap <ravi@ximian.com>
26680 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
26681 We use it to keep track of classes which are attribute types.
26683 2002-04-02 Miguel de Icaza <miguel@ximian.com>
26685 * delegate.cs (Delegate.Define): Correctly define the types in the
26686 presence of fixed and array parameters.
26688 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
26691 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
26692 include NonPublic after the first iteration.
26694 * class.cs (Indexer.CheckBase): Only check if both parents are
26697 * cs-parser.jay (accessor_body): If empty, set to null.
26699 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
26700 same code path here to resolve constants names that we did have in
26701 MemberAccess.DoResolve. There is too much code duplicated here.
26703 2002-04-01 Miguel de Icaza <miguel@ximian.com>
26705 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
26707 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
26710 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
26711 tokens, numbers and strings.
26713 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
26716 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
26717 asyncronous parameters and the regular parameters.
26719 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
26720 specify the target directory.
26722 * expression.cs: (This.DoResolve): Simplify
26723 (As.Emit): Optimize, do not generate IsInst if the expression is
26724 always of the given type.
26726 (Is.DoResolve): Bug fix, we were reporting both always/never for
26729 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
26730 creating too many unnecessary arrays.
26732 2002-03-31 Miguel de Icaza <miguel@ximian.com>
26734 * class.cs (EmitFieldInitializer): Use Assign expression to assign
26735 fields instead of rolling our own initializer. Takes care of all
26736 implicit conversions, and drops unnecessary static checks/argument.
26738 2002-03-31 Dick Porter <dick@ximian.com>
26740 * driver.cs: use the GetDirectories() return values properly, and
26741 use "/" as path separator.
26743 2002-03-30 Miguel de Icaza <miguel@ximian.com>
26745 * expression.cs (Unary): Optimize - - expr into expr.
26746 (Binary): Optimize a + (-b) into a -b.
26748 * codegen.cs (CodeGen): Made all methods static.
26750 2002-03-29 Miguel de Icaza <miguel@ximian.com>
26754 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
26755 TypeBuilder property.
26757 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
26760 * tree.cs: Removed the various RecordXXXX, and replaced with a
26761 single RecordDecl. Removed all the accessor methods, and just
26762 left a single access point Type
26764 * enum.cs: Rename DefineEnum to DefineType.
26766 * decl.cs: New abstract method `DefineType' used to unify the
26767 Defines for Enumerations, Interfaces, TypeContainers and
26770 (FindType): Moved LookupInterfaceOrClass here. Moved the
26771 LookupBaseClasses method that used to live in class.cs and
26772 interface.cs here, and renamed to FindType.
26774 * delegate.cs: Implement DefineType. Take advantage of the
26775 refactored pattern for locating the parent builder without taking
26776 the parent_builder argument (which we know does not work if we are
26777 nested, and triggering a toplevel definition).
26779 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26781 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
26782 accessibility of a member has changed during override and report
26785 * class.cs (Method.Define, Property.Define): Only complain on
26786 overrides if the method is private, any other accessibility is
26787 fine (and since we just checked the permission is the same, we are
26790 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
26791 and elif are processed always. The other pre-processing
26792 directives are only processed if we are "taking" the path
26794 2002-03-29 Martin Baulig <martin@gnome.org>
26796 * class.cs (Method.Emit): Only emit symbolic debugging info if the
26797 current location is not Null.
26799 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
26800 a separate method so we can profile it.
26802 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
26803 `span.Seconds' are just seconds, but no minutes or hours.
26804 (MainDriver): Profile the CodeGen.SaveSymbols calls.
26806 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26808 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
26809 Remove the gratuitous set of Final:
26811 // If an interface implementation, then we can set Final.
26812 if (((flags & MethodAttributes.Abstract) == 0) &&
26813 implementing.DeclaringType.IsInterface)
26814 flags |= MethodAttributes.Final;
26816 I do not know what I was smoking when I used that.
26819 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
26820 step into fixing the name resolution issues for delegates and
26821 unifying the toplevel name resolution.
26823 2002-03-28 Martin Baulig <martin@gnome.org>
26825 * class.cs (Method.Emit): If we have a symbol writer, call its
26826 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
26827 tell it about the current method.
26829 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
26830 writer that we're going to emit the first byte of IL code for a new
26831 statement (a new source line).
26832 (EmitContext.EmitTopBlock): If we have a symbol writer, call
26833 EmitContext.Mark() before emitting any code.
26835 * location.cs (SymbolDocument): Return null when we're Null.
26837 * statement.cs (Statement): Moved the `Location loc' variable here.
26838 (Statement.EmitBoolExpression): If we have a symbol writer, call
26839 ec.Mark() before emitting any code to tell it that we're at the
26840 beginning of a new statement.
26841 (StatementExpression): Added `Location' argument to the constructor.
26842 (Block): Added public readonly variable `StartLocation' and public
26843 variable `EndLocation'. The latter is to be set using SetEndLocation().
26844 (Block): Added constructor which takes a start and end location.
26845 (Block.SetEndLocation): New method. This sets the end location.
26846 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
26847 local variables we create.
26848 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
26849 each statement and do also mark the begin and end of the block.
26851 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
26852 tell it the current lexer.Location, use Location.Null for the end of the
26854 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
26855 current block, set its end location using SetEndLocation().
26856 (statement_expression): StatementExpression constructor now takes the
26857 lexer.Location as additional argument.
26858 (for_statement, declare_local_variables): Likewise.
26859 (declare_local_variables): When creating a new implicit block, use the
26860 new Block constructor and pass it the lexer.Location.
26862 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26864 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
26865 members also on the parent interfaces recursively.
26867 2002-03-27 Miguel de Icaza <miguel@ximian.com>
26869 * report.cs: Use new formats, since Gonzalo finished the missing
26872 * expression.cs (Binary.ResolveOperator): added missing operator|
26873 operator& and operator^ for bool/bool.
26875 * cs-parser.jay: CheckDef now takes a Location argument that is
26876 used to report errors more precisly (instead of reporting the end
26877 of a definition, we try to track something which is a lot closer
26878 to the source of the problem).
26880 * cs-tokenizer.cs: Track global token use, so we can properly flag
26881 the use of #define/#undef after the first token has been seen.
26883 Also, rename the reportXXXX to Error_DescriptiveName
26885 * decl.cs (DeclSpace.IsTopLevel): Move property here from
26886 TypeContainer, so that Enum and Interface can use this too.
26888 * class.cs (TypeContainer.LookupInterfaceOrClass,
26889 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
26890 `builder' argument. Typically this was used to pass the parent
26891 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
26894 The problem is that a nested class could trigger the definition of
26895 a toplevel class, and the builder would be obviously wrong in that
26898 So we drop this argument, and we compute dynamically the
26899 TypeBuilder/ModuleBuilder (the correct information was available
26900 to us anyways from DeclSpace.Parent)
26902 * interface.cs (Interface.DefineInterface): Drop builder
26903 parameter cleanup like class.cs
26905 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
26908 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
26911 (Try.Emit): Propagate the returns value from the statement.
26913 (Return.Emit): Even if we are leavning
26915 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
26917 * modifiers.cs: Fix the computation of MethodAttributes flags.
26919 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
26921 * driver.cs: allow compilation of files that start with '/'.
26922 Add a default case when checking the argument of --target.
26924 2002-03-25 Miguel de Icaza <miguel@ximian.com>
26926 * interface.cs: Implement the same search algorithm for types in
26927 the interface code.
26929 * delegate.cs: Do not allow multiple definition.
26931 * Recovered ChangeLog that got accidentally amputated
26933 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
26935 * rootcontext.cs: Load manually enum to allow core classes to
26936 contain enumerations.
26938 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
26939 Update to new static methods in TypeManager.
26941 * typemanager.cs (GetMethod, GetConstructor): Use our
26942 implementation of FindMembers to find the members, since during
26943 corlib compilation, the types are TypeBuilders and GetMethod and
26944 GetConstructor do not work.
26946 Make all methods in TypeManager static.
26948 (InitCodeHelpers): Split the functionality from
26949 the InitCodeTypes function.
26951 * driver.cs: Call InitCodeHelpers after we have populated the
26954 * cs-parser.jay (delegate_declaration): we did not used to compute
26955 the delegate name correctly for void delegates.
26957 2002-03-24 Miguel de Icaza <miguel@ximian.com>
26959 * rootcontext.cs (RootContext): Init the interface_resolve_order
26960 and type_container_resolve_order always.
26962 (ResolveCore, BootstrapCorlib_ResolveClass,
26963 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
26964 compiler when compiling with --nostdlib
26966 * class.cs (TypeContainer.DefineType): Check that our parent is
26967 not null. This test is most important when we are bootstraping
26970 * codegen.cs: Split out the symbol writing code.
26972 2002-03-25 Martin Baulig <martin@gnome.org>
26974 * driver.cs (-g): Made -g an alias for --debug.
26976 2002-03-24 Martin Baulig <martin@gnome.org>
26978 * codegen.cs (SymbolWriter): New public variable. Returns the
26979 current symbol writer.
26980 (CodeGen): Added `bool want_debugging_support' argument to the
26981 constructor. If true, tell the ModuleBuild that we want debugging
26982 support and ask it for the ISymbolWriter.
26983 (Save): If we have a symbol writer, call it's Close() method after
26984 saving the assembly.
26986 * driver.c (--debug): New command line argument to create a
26987 debugger information file.
26989 * location.cs (SymbolDocument): New public property. Returns an
26990 ISymbolDocumentWriter object for the current source file or null
26991 if we don't have a symbol writer.
26993 2002-03-21 Miguel de Icaza <miguel@ximian.com>
26995 * driver.cs (LoadAssembly): Correctly return when all the paths
26996 have been tried and not before.
26998 * statement.cs (Switch.Emit): return the actual coverage for this
26999 statement (returns/not-returns)
27001 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27002 switch of the statement if we are the last switch section. That
27003 kills two problems: try/catch problems (we used to emit an empty
27004 nop at the end) and switch statements where all branches would
27007 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27009 * driver.cs: Add default assemblies (the equivalent to the
27010 Microsoft CSC.RSP file)
27012 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27013 also update tokens_seen and set it to false.
27015 * driver.cs: Implement --recurse for Mike.
27017 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27018 correctly splitting out the paths.
27020 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27022 * interface.cs (Interface.PopulateProperty): Instead of using
27023 `parent' as the declaration space for the set parameters, use
27026 * support.cs (InternalParameters): InternalParameters constructor
27027 takes a DeclSpace instead of a TypeContainer.
27029 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27030 types are being initialized, load the address of it before calling
27033 (New): Provide a mechanism to disable the generation of local
27034 value type temporaries when the caller will be providing us with
27035 an address to store it.
27037 (ArrayCreation.EmitDynamicInitializers): Use it.
27039 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27041 * expression.cs (Invocation.EmitArguments): Only probe for array
27042 property if there is more than one argument. Sorry about that.
27044 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27045 empty param arrays.
27047 * class.cs (Method.LabelParameters): Fix incorrect code path that
27048 prevented the `ParamArrayAttribute' from being applied to the
27051 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27053 * support.cs (ReflectionParameters): Correctly compute whether the
27054 last argument is a params array. Fixes the problem with
27057 * typemanager.cs: Make the assemblies array always be non-null
27058 (empty, but non-null)
27060 * tree.cs (RecordDecl): New function that abstracts the recording
27061 of names. This reports error 101, and provides a pointer to the
27062 previous declaration. Fixes a crash in the compiler.
27064 * cs-parser.jay (constructor_declaration): Update to new grammar,
27065 and provide a constructor_body that can be empty.
27067 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27069 * driver.cs: Add support for --resources.
27071 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27072 Make all types for the various array helper methods be integer.
27074 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27075 CheckState to ConvCast.
27077 (ConvCast): Now it takes a `checked' state argument, to avoid
27078 depending on the emit context for the conversion, and just using
27079 the resolve time setting.
27081 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27082 instead of Invocation.EmitArguments. We do not emit the original
27083 arguments, instead we emit those which have been converted to
27084 unsigned int expressions.
27086 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27088 * codegen.cs: ditto.
27090 * expression.cs (LocalVariableReference): Drop the use of the
27091 Store function that depended on the variable index.
27093 * statement.cs (VariableInfo): Drop the `Idx' property from this
27094 class, as this is not taking into account the indexes for
27095 temporaries tat we generate during the execution, getting the
27098 * class.cs: First emit class initializers, then call the parent
27101 * expression.cs (Binary): Fix opcode emision.
27102 (UnaryMutator.EmitCode): Support checked code generation
27104 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27105 matches for events for both the Static and Instance scans,
27106 pointing to the same element. Fix that.
27108 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27110 * rootcontext.cs (ResolveTree): Always set the
27111 interface_resolve_order, because nested interfaces will be calling
27114 * class.cs (GetInterfaceOrClass): Track the same resolution
27115 process used by TypeManager.LookupType. This fixes the nested
27116 type lookups in class declarations (separate path from
27119 (TypeContainer.DefineType): Also define nested interfaces.
27120 (TypeContainer.RegisterOrder): New public function used to
27121 register the order in which child interfaces need to be closed.
27123 Nested interfaces need to be closed after their parents have been
27126 * interface.cs (InterfaceAttr): Put all the logic for computing
27127 the interface attribute here.
27129 (DefineInterface): Register our interface order with the
27130 RootContext or with the TypeContainer depending on the case.
27132 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27134 * cs-parser.jay: rework foreach statement to work with the new
27135 changes to the policy on SimpleNames.
27137 * report.cs: support Stacktrace on warnings as well.
27139 * makefile: drop --unsafe and /unsafe from the compile.
27141 2002-03-13 Ravi Pratap <ravi@ximian.com>
27143 * ecore.cs (StandardConversionExists): Modify to take an Expression
27144 as the first parameter. Ensure we do null -> reference type conversion
27147 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27148 temporary Expression objects.
27150 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27152 * interface.cs: workaround bug in method overloading resolution
27153 (there is already a bugzilla bug for it).
27155 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27157 We could also solve this problem by having a separate path for
27158 performing type lookups, instead of DoResolve, we could have a
27159 ResolveType entry point, and only participating pieces of the
27160 production (simplename, deref, array) would implement this.
27162 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27163 signal SimpleName to only resolve type names and not attempt to
27164 resolve anything else.
27166 * expression.cs (Cast): Set the flag.
27168 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27170 * class.cs: Only report 108 if there is no `new' modifier.
27172 * cs-parser.jay: rework foreach statement to work with the new
27173 changes to the policy on SimpleNames.
27175 * report.cs: support Stacktrace on warnings as well.
27177 * makefile: drop --unsafe and /unsafe from the compile.
27179 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27181 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27182 lookups here, instead of doing that at parse time. This means
27183 that our grammar will not introduce `LocalVariableReferences' as
27184 expressions at this point. That solves the problem of code like
27188 static void Main ()
27192 This is only half the fix. The full fix requires parameters to
27193 also be handled in this way.
27195 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27196 makes the use more obvious of the DeclSpace. The
27197 ec.TypeContainer.TypeBuilder is now only used to pull the
27198 TypeBuilder for it.
27200 My theory is that I can get rid of the TypeBuilder completely from
27201 the EmitContext, and have typecasts where it is used (from
27202 DeclSpace to where it matters).
27204 The only pending problem is that the code that implements Aliases
27205 is on TypeContainer, and probably should go in DeclSpace.
27207 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27208 lookups here, instead of doing that at parse time. This means
27209 that our grammar will not introduce `LocalVariableReferences' as
27210 expressions at this point. That solves the problem of code like
27214 static void Main ()
27218 This is only half the fix. The full fix requires parameters to
27219 also be handled in this way.
27221 * class.cs (Property.DefineMethod): When implementing an interface
27222 method, set newslot, when implementing an abstract method, do not
27223 set the flag (before we tried never setting it, or always setting
27224 it, which is the difference).
27225 (Indexer.DefineMethod): same.
27226 (Method.DefineMethod): same.
27228 * ecore.cs: Only set the status used flag if we get back a Field.
27230 * attribute.cs: Temporary hack, so Paolo can keep working.
27232 2002-03-08 Ravi Pratap <ravi@ximian.com>
27234 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27235 the unmanaged type in the case we have a MarshalAs attribute.
27237 (Resolve): Handle the case when we are parsing the special MarshalAs
27238 attribute [we need to store the unmanaged type to use later]
27240 * typemanager.cs (marshal_as_attr_type): Built in type for the
27241 MarshalAs Attribute.
27243 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27244 on parameters and accordingly set the marshalling info.
27246 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27248 * class.cs: Optimizing slightly by removing redundant code after
27249 we switched to the `NoTypes' return value.
27250 (Property.DefineMethod): use NoTypes here too.
27252 This fixes the bug I introduced in my last batch of changes.
27254 2002-03-05 Ravi Pratap <ravi@ximian.com>
27256 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27258 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27259 Enums since those are types too.
27261 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27263 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27264 thanks to a call during the lookup process.
27266 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27268 * statement.cs (Foreach): Lots of work to accomodate a particular
27269 kind of foreach statement that I had not kept in mind. It is
27270 possible to have foreachs on classes that provide a GetEnumerator
27271 method that return objects that implement the "pattern" for using
27272 a foreach, there is no need to support GetEnumerator
27275 This is needed to compile nant.
27277 * decl.cs: Only report 114 if the member is not `Finalize' and if
27278 the warning level is at least 2.
27280 * class.cs: Moved the compare function from Method to
27283 (MethodSignature.InheritableMemberSignatureCompare): Add new
27284 filter function that is used to extract inheritable methods from a
27287 (Method.Define): Use the new `inheritable_method_signature_filter'
27290 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27293 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27295 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27297 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27299 * expression.cs: Pass location information to
27300 ConvertImplicitStandard.
27302 * class.cs: Added debugging code to track return values from
27305 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27307 * expression.cs (Is.DoResolve): If either side of the `is' is an
27308 interface, do not flag the warning.
27310 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27313 * report.cs: Allow for --fatal to be used with --probe.
27315 * typemanager.cs (NoTypes): Move the definition for the empty Type
27318 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27320 (TypeContainer.DefineProxy): New function used to proxy to parent
27321 implementations when implementing interfaces.
27322 (TypeContainer.ParentImplements): used to lookup if our parent
27323 implements a public function that is required by an interface.
27324 (TypeContainer.VerifyPendingMethods): Hook this up.
27326 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27327 `modules' and `assemblies' arraylists into arrays. We only grow
27328 these are the very early start up of the program, so this improves
27329 the speedof LookupType (nicely measured).
27331 * expression.cs (MakeByteBlob): Replaced unsafe code with
27332 BitConverter, as suggested by Paolo.
27334 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27335 folding of string concatenation, but if either side is a string,
27336 and the other is not, then return null, and let the runtime use
27337 the concatenation on the string plus the object (using
27338 `Object.ToString').
27340 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27342 Constant Folding has been implemented now.
27344 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27345 the error instead on types that are not supported in one's
27348 * constant.cs (Constant and all children): New set of functions to
27349 perform implict and explicit conversions.
27351 * ecore.cs (EnumConstant): Implement the new functions to perform
27352 conversion by proxying to the child expression.
27354 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27355 own separate setting that can not be turned off from the command
27356 line using --unchecked or --checked and is only controlled using
27357 the checked/unchecked statements and expressions. This setting is
27358 used by the constant folder to flag errors.
27360 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27361 ConstantCheckState as well.
27363 During Resolve, they also have to flag the state, because the
27364 constant folder runs completely in the Resolve phase.
27366 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27369 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27371 * cfold.cs: New file, this file contains the constant folder.
27373 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27374 argument to track whether we are using the resulting address to
27375 load or store a value and provide better error messages.
27377 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27378 new AddressOf arguments.
27380 * statement.cs (Foreach.EmitCollectionForeach): Update
27382 * expression.cs (Argument.Emit): Call AddressOf with proper
27383 arguments to track usage.
27385 (New.DoEmit): Call AddressOf with new arguments.
27387 (Unary.Emit): Adjust AddressOf call.
27389 2002-03-01 Ravi Pratap <ravi@ximian.com>
27391 * cs-parser.jay (member_access): Change the case for pre-defined types
27392 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27395 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27398 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27399 essentially like methods and apply attributes like MethodImplOptions to them too.
27401 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27404 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27405 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27408 * Update code everywhere accordingly.
27410 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27412 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27414 2002-02-28 Ravi Pratap <ravi@ximian.com>
27416 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27417 try performing lookups against those instead of jumping straight into using
27418 the 'using' clauses.
27420 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27422 (LookupType): Perform lookups in implicit parents too.
27424 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27425 sequence as RootContext.LookupType.
27427 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27428 the various cases of namespace lookups into this method.
27430 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27432 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27433 in positional arguments)
27435 * class.cs (Operator): Update the AllowedModifiers to contain
27438 * cs-parser.jay: Update operator declaration to allow for the
27439 operator body to be empty.
27441 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27444 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27446 * class.cs (Method.Emit): Label parameters.
27448 * driver.cs: Return 1 or 0 as the program exit code.
27450 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27452 * expression.cs: Special case the `null' object when trying to
27453 auto-compute the type, as anything can be explicitly converted to
27456 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27457 spotting this Paolo.
27459 (Expression.ImplicitNumericConversion): Perform comparissions of
27460 the type using the underlying type in the case of an enumeration
27461 rather than using the enumeration type for the compare.
27463 Cope with the underlying == type case, which is not possible to
27466 (Expression.ConvertNumericExplicit): Perform comparissions of
27467 the type using the underlying type in the case of an enumeration
27468 rather than using the enumeration type for the compare.
27470 * driver.cs: If the user does not supply an extension, assume .exe
27472 * cs-parser.jay (if_statement): Rewrote so that we can track the
27473 location for the if statement.
27475 * expression.cs (Binary.ConstantFold): Only concat strings when
27476 the operation is "+", not everything ;-)
27478 * statement.cs (Statement.EmitBoolExpression): Take a location
27480 (If, While, Do): Track location.
27482 * expression.cs (Binary.ResolveOperator): In the object + string
27483 case, I was missing a call to ConvertImplicit
27485 2002-02-25 Ravi Pratap <ravi@ximian.com>
27487 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
27488 Location arguments. Ensure we use RootContext.LookupType to do our work
27489 and not try to do a direct Type.GetType and ModuleBuilder.GetType
27491 * interface.cs (PopulateMethod): Handle the type of the parameter being
27494 * expression.cs (Invocation.BetterFunction): Handle the case when we
27495 have a params method with no fixed arguments and a call is made with no
27498 2002-02-25 Miguel de Icaza <miguel@ximian.com>
27500 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
27501 the verbatim-string-literal
27503 * support.cs (InternalParameters.ParameterModifier): handle null
27505 (InternalParameters.ParameterType): ditto.
27507 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
27508 duplicating the name of the variable parameter.
27509 (GetParameterByName): Fix bug where we were not looking up array
27510 paramters if they were the only present (thanks Paolo!).
27511 (GetParameterInfo): We only have an empty set of types if both
27512 fixed and array are set to null.
27513 (GetParameterInfo-idx): Handle FixedParameter == null
27515 * cs-parser.jay: Handle the case where there is no catch
27516 statements (missing null test).
27518 2002-02-22 Miguel de Icaza <miguel@ximian.com>
27520 * driver.cs (MainDriver): Be conservative on our command line
27523 Catch DirectoryNotFoundException when calling GetFiles.
27525 (SplitPathAndPattern): Used to split the input specification into
27526 a path and a pattern that we can feed to Directory.GetFiles.
27528 2002-02-21 Miguel de Icaza <miguel@ximian.com>
27530 * statement.cs (Fixed): Implement the last case of the Fixed
27531 statement (string handling).
27533 * expression.cs (StringPtr): New class used to return a char * to
27534 a string; Used by the Fixed statement.
27536 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
27538 * expression.cs (Binary.ResolveOperator): Remove redundant
27539 MemberLookup pn parent type.
27540 Optimize union call, we do not need a union if the types are the same.
27541 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
27544 Specialize the use of MemberLookup everywhere, instead of using
27545 the default settings.
27547 (StackAlloc): Implement stackalloc keyword.
27549 * cs-parser.jay: Add rule to parse stackalloc.
27551 * driver.cs: Handle /h, /help, /?
27553 * expression.cs (MakeByteBlob): Removed the hacks we had in place
27554 before we supported unsafe code.
27556 * makefile: add --unsafe to the self compilation of mcs.
27558 2002-02-20 Miguel de Icaza <miguel@ximian.com>
27560 * expression.cs (PointerArithmetic): New class that is used to
27561 perform pointer arithmetic.
27562 (Binary.Resolve): Handle pointer arithmetic
27563 Handle pointer comparission.
27564 (ArrayPtr): Utility expression class that is used to take the
27565 address of an array.
27567 (ElementAccess): Implement array access for pointers
27569 * statement.cs (Fixed): Implement fixed statement for arrays, we
27570 are missing one more case before we are done.
27572 * expression.cs (Indirection): Implement EmitAssign and set the
27573 ExprClass to Variable. This allows pointer dereferences to be
27574 treated as variables, and to have values assigned to them.
27576 * ecore.cs (Expression.StoreFromPtr): New utility function to
27577 store values dereferencing.
27579 2002-02-20 Ravi Pratap <ravi@ximian.com>
27581 * expression.cs (Binary.ResolveOperator): Ensure that we are
27582 not trying to operate on a void type - this fixes the reported
27585 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
27586 the parent implementation is sealed.
27588 * ../errors/cs0239.cs : Add.
27590 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
27592 * typemanager.cs (unverifiable_code_type): Corresponds to
27593 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
27594 which have unsafe code in them.
27596 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
27599 2002-02-19 Miguel de Icaza <miguel@ximian.com>
27601 * cs-tokenizer.cs: Add support for @"litreal strings"
27603 Make tokenizer accept pre-processor directives
27604 on any column (remove the old C-like limitation).
27606 * rootcontext.cs (EmitCode): Emit any global attributes.
27607 (AddGlobalAttributes): Used to keep track of assembly attributes.
27609 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
27611 * cs-parser.jay: Add support for global attributes.
27613 2002-02-17 Miguel de Icaza <miguel@ximian.com>
27615 * expression.cs (Indirection): New helper class. Unary will
27616 create Indirection classes to be able to implement the
27617 IMemoryLocation interface on it.
27619 2002-02-16 Miguel de Icaza <miguel@ximian.com>
27621 * cs-parser.jay (fixed_statement): reference the right statement.
27623 * statement.cs (Fixed.Emit): Finish implementing the fixed
27624 statement for the &x case.
27626 2002-02-14 Miguel de Icaza <miguel@ximian.com>
27628 * class.cs (Property.Define, Method.Define): Remove newslot when
27631 * modifiers.cs: My use of NewSlot when `Abstract' was set was
27632 wrong. NewSlot should only be used if the `new' keyword is present.
27634 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
27635 locating our system dir. Sorry about this.
27637 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27639 * driver.cs (GetSystemDir): Compute correctly the location of our
27640 system assemblies. I was using the compiler directory instead of
27641 the library directory.
27643 2002-02-13 Ravi Pratap <ravi@ximian.com>
27645 * expression.cs (BetterFunction): Put back in what Miguel commented out
27646 since it is the correct fix. The problem is elsewhere ;-)
27648 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
27649 parameters of the parms method are themselves compatible or not !
27651 (StandardConversionExists): Fix very dangerous bug where we were forgetting
27652 to check that a class implements an interface before saying that an implicit
27653 conversion was allowed. Use ImplementsInterface to do the checking.
27655 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27657 * class.cs (Method.Define): Track whether we are an explicit
27658 implementation or not. And only call DefineMethodOverride if we
27659 are an explicit implementation.
27661 (Property.DefineMethod): Ditto.
27663 2002-02-11 Ravi Pratap <ravi@ximian.com>
27665 * expression.cs (BetterFunction): Catch hideous bug which was
27666 preventing us from detecting ambiguous calls due to implicit casts i.e
27669 2002-01-29 Miguel de Icaza <miguel@ximian.com>
27671 * support.cs (Pair): Remove un-needed method. I figured why I was
27672 getting the error in cs-parser.jay, the variable in a foreach loop
27673 is readonly, and the compiler does not really treat this as a variable.
27675 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
27676 instead of EQUALS in grammar.
27678 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
27680 * expression.cs (Unary.DoResolve): Check whether the argument is
27683 2002-01-28 Miguel de Icaza <miguel@ximian.com>
27685 * support.cs: Api for Pair to set a value. Despite the fact that
27686 the variables are public the MS C# compiler refuses to compile
27687 code that accesses the field if the variable is part of a foreach
27690 * statement.cs (Fixed): Begin implementation of the fixed
27693 (Block.AddVariable): Return the VariableInfo on success and null
27694 on failure instead of true/false.
27696 * cs-parser.jay (foreach): Catch errors on variables already
27697 defined (we were ignoring this value before) and properly unwind
27698 the block hierarchy
27700 (fixed_statement): grammar for the fixed statement.
27702 2002-01-25 Miguel de Icaza <miguel@ximian.com>
27704 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
27705 pointer types to be incretemented.
27707 (SizeOf): Implement.
27709 * cs-parser.jay (pointer_member_access): Implement
27710 expr->IDENTIFIER production.
27712 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
27713 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
27716 (Unary): Implement indirection.
27718 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
27719 use in non-unsafe context).
27721 (SimpleName.DoResolve): Check for pointers in field access on safe
27724 (Expression.LoadFromPtr): Factor the load-indirect code in this
27725 function. This was duplicated in UnboxCast and ParameterReference
27727 2002-01-24 Miguel de Icaza <miguel@ximian.com>
27729 * expression.cs (ComposedCast): report an error if a pointer cast
27730 is used in a safe region.
27732 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
27733 pointer type casts in unsafe context.
27735 * codegen.cs (EmitContext): Set up IsUnsafe.
27737 * cs-parser.jay (non_expression_type): Add productions for pointer
27740 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
27741 code. We should not use force into static mode if the method is
27742 not virtual. Fixes bug in MIS
27744 * statement.cs (Do.Emit, While.Emit, For.Emit,
27745 Statement.EmitBoolExpression): Add support to Do and While to
27746 propagate infinite loop as `I do return' semantics.
27748 Improve the For case to also test for boolean constants.
27750 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
27751 to the list of attributes we can add.
27753 Remove `EmitContext' argument.
27755 * class.cs (Method.Define): Apply parameter attributes.
27756 (Constructor.Define): Apply parameter attributes.
27757 (MethodCore.LabelParameters): Move here the core of labeling
27760 * support.cs (ReflectionParameters.ParameterModifier,
27761 InternalParameters.ParameterModifier): Use IsByRef on the type and
27762 only return the OUT bit for these parameters instead of in/out/ref
27765 This is because I miss-understood things. The ParameterInfo.IsIn
27766 and IsOut represent whether the parameter has the [In] and [Out]
27769 2002-01-22 Miguel de Icaza <miguel@ximian.com>
27771 * ecore.cs (FieldExpr.Emit): Release temporaries.
27773 * assign.cs (LocalTemporary.Release): new function.
27775 * codegen.cs (EmitContext.GetTemporaryStorage,
27776 EmitContext.FreeTemporaryStorage): Rework the way we deal with
27777 temporary storage. Now we can "put back" localbuilders when we
27780 2002-01-21 Miguel de Icaza <miguel@ximian.com>
27782 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
27783 need to make a copy of the variable to generate verifiable code.
27785 2002-01-19 Miguel de Icaza <miguel@ximian.com>
27787 * driver.cs: Compute dynamically the system directory.
27789 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
27790 Slower, but more generally useful. Used by the abstract
27791 registering implementation.
27793 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
27794 the rules for the special rule on Type/instances. First check if
27795 we have the same name, and if so, try that special static path
27796 rather than the instance path.
27798 2002-01-18 Miguel de Icaza <miguel@ximian.com>
27800 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
27803 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
27804 Enum, ValueType, Delegate or Array for non-corlib compiles.
27806 * cs-tokenizer.cs: Catch long identifiers (645)
27808 * typemanager.cs (IndexerPropetyName): Ravi never tested this
27811 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
27812 fix, we were returning too early, so we were not registering
27813 pending methods from abstract classes.
27815 Do not register pending methods if the class is abstract.
27817 * expression.cs (Conditional.DoResolve): Report circular implicit
27818 conversions when we neecd to compute it for conditional
27821 (Is.DoResolve): If the expression is always of the provided type,
27822 flag warning 183. If the expression can not ever be of the
27823 provided type flag warning 184.
27825 * class.cs: Catch 169 as well.
27827 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
27830 2002-01-18 Nick Drochak <ndrochak@gol.com>
27832 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
27834 2002-01-17 Miguel de Icaza <miguel@ximian.com>
27836 * interface.cs: (PopulateMethod): Check for pointers being defined
27837 only if the unsafe context is active.
27838 (PopulateProperty): ditto.
27839 (PopulateIndexer): ditto.
27841 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
27842 specified. If pointers are present, make sure that they are
27843 present in an unsafe context.
27844 (Constructor, Constructor.Define): ditto.
27845 (Field, Field.Define): ditto.
27846 (Property, Property.Define): ditto.
27847 (Event, Event.Define): ditto.
27849 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
27850 hashtable if there are classes or structs defined.
27852 * expression.cs (LocalVariableReference.DoResolve): Simplify this
27853 code, as the constant resolution moved.
27855 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
27856 the metadata, so we can flag error 133.
27858 * decl.cs (MemberCore.UnsafeOK): New function to test that a
27859 pointer is being declared in an unsafe context.
27861 2002-01-16 Miguel de Icaza <miguel@ximian.com>
27863 * modifiers.cs (Modifiers.Check): Require a Location argument.
27864 Report error 227 for Unsafe use.
27866 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
27868 * statement.cs (For.Emit): If the test is null, then report that
27869 we do `return', as we wont reach anything afterwards.
27871 (Switch.SwitchGoverningType): Track the expression that matched
27874 * driver.cs: Allow negative numbers as an error code to flag.
27876 * cs-parser.jay: Handle 1551.
27878 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
27880 2002-01-15 Miguel de Icaza <miguel@ximian.com>
27882 * cs-parser.jay: Report 1518 (type declaration can only contain
27883 class, struct, interface, enum or delegate)
27885 (switch_label): Report 1523 (keywords `case' or `default' must
27888 (opt_switch_sections): Report 1522 (empty switch)
27890 * driver.cs: Report 1515 (response file specified multiple times)
27891 Report 1516 (Source file specified multiple times).
27893 * expression.cs (Argument.Resolve): Signal 1510
27895 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
27896 access not allowed in static code)
27898 2002-01-11 Ravi Pratap <ravi@ximian.com>
27900 * typemanager.cs (IsPointerType): Utility method which we are going
27903 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
27904 the object type, so we take care of that.
27906 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
27908 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
27909 added to non-params parameters :-)
27911 * typemanager.cs (CSharpName): Include 'void' type too.
27913 (void_ptr_type): Include in the set of core types.
27915 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
27918 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
27921 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
27922 completely forgotten about it.
27924 2002-01-10 Ravi Pratap <ravi@ximian.com>
27926 * cs-parser.jay (pointer_type): Add. This begins our implementation
27927 of parsing rules for unsafe code.
27929 (unsafe_statement): Implement.
27931 (embedded_statement): Modify to include the above.
27933 * statement.cs (Unsafe): Implement new class for unsafe blocks.
27935 * codegen.cs (EmitContext.InUnsafe): Add. This determines
27936 if the current context is an unsafe one.
27938 * cs-parser.jay (local_variable_pointer_type): Since local variable types
27939 are handled differently, we need separate rules for them.
27941 (local_variable_declaration): Update to use local_variable_pointer_type
27942 to allow variable declarations of unmanaged pointer types.
27944 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
27945 in unsafe contexts.
27947 * ../errors/cs0214.cs : Add.
27949 2002-01-16 Nick Drochak <ndrochak@gol.com>
27951 * makefile: remove 'response' file when cleaning.
27953 2002-01-15 Miguel de Icaza <miguel@ximian.com>
27955 * cs-parser.jay: Report 1524.
27957 2002-01-14 Miguel de Icaza <miguel@ximian.com>
27959 * typemanager.cs (RegisterMethod): drop checking if we have
27960 registered this from here
27962 2002-01-12 Miguel de Icaza <miguel@ximian.com>
27964 * class.cs (Method.EmitDestructor): Implement calling our base
27967 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
27968 value of InFinally.
27970 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
27971 this routine and will wrap the call in a try/catch block. Deal
27974 2002-01-11 Miguel de Icaza <miguel@ximian.com>
27976 * ecore.cs (Expression.MemberLookup): instead of taking a
27977 parameter `same_type' that was used to tell whether we could
27978 access private members we compute our containing type from the
27981 (FieldExpr): Added partial support for volatile fields. This does
27982 not work for volatile fields exposed from assemblies, as I can not
27983 figure out how to extract the modreq from it.
27985 Updated all the source files to use this.
27987 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
27988 because it is referenced by MemberLookup very often.
27990 2002-01-09 Ravi Pratap <ravi@ximian.com>
27992 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
27993 TypeBuilder.GetCustomAttributes to retrieve what we need.
27995 Get rid of redundant default_member_attr_type as this is the same as
27996 default_member_type which already exists.
27998 * interface.cs, attribute.cs : Update accordingly.
28000 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28002 * typemanager.cs: Enable IndexerPropertyName again. It does not
28003 work for TYpeBuilders though. Ravi, can you please fix this?
28005 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28007 * expression.cs (Argument.Emit): Handle the case of ref objects
28008 being passed to ref functions;
28010 (ParameterReference.EmitLoad): Loads the content of the pointer
28011 without dereferencing.
28013 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28015 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28017 2002-01-08 Ravi Pratap <ravi@ximian.com>
28019 * class.cs (Indexer.DefineMethod): Incorporate the interface
28020 type in the name of the method if we are doing explicit interface
28023 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28025 (BetterConversion): Fix extremely trivial bug where we were referring to
28026 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28029 * ../errors/bug16.cs : Add although we have fixed it.
28031 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28033 * expression.cs (BaseIndexer): Begin implementation.
28035 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28037 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28038 production directly to remove a shift/reduce, and implement
28039 explicit interface implementation.
28041 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28042 after a floating point suffix.
28044 * expression.cs (DoNumericPromotions): Improved the conversion for
28045 uint/uint. If we have a constant, we avoid doing a typecast to a
28048 * class.cs (Indexer): Implement explicit interface implementation
28051 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28053 * class.cs: make the default instance constructor public and hidebysig.
28055 2001-01-03 Ravi Pratap <ravi@ximian.com>
28057 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28058 so we can call it from elsewhere.
28060 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28061 we emit it internally if the class has a defined indexer; otherwise the user
28062 emits it by decorating the class definition with the DefaultMemberAttribute.
28064 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28065 attribute is not used on a type which defines an indexer.
28067 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28068 character when we skip whitespace.
28070 * ../errors/cs0646.cs : Add.
28072 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28074 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28077 * makefile: Add practical target `mcs3.exe' which builds the third
28078 generation compiler.
28080 * expression.cs (New): Fix structures constructor calling.
28082 * class.cs (Property, Method, Indexer): Emit Final flag on the
28083 method if we are an interface implementation and we are not
28086 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28087 whether this property is referencing a `base' method.
28089 * expression.cs (Invocation.EmitCall): take an extra argument:
28090 is_base, this is used to determine whether the `call' or
28091 `callvirt' opcode should be used.
28094 * delegate.cs: update EmitCall.
28096 * class.cs (Method.Define): Set NewSlot for the cases where we are
28097 not implementing an interface method.
28099 (Property.Define): ditto.
28101 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28103 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28104 'r'. Allows mcs to parse itself fully.
28106 2002-01-02 Ravi Pratap <ravi@ximian.com>
28108 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28109 of the number of initializers that require the InitializeArray method.
28111 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28112 update the above field where necessary.
28114 (MakeByteBlob): Update accordingly.
28116 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28119 (EmitDynamicInitializers): Update in accordance with the new optimization.
28121 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28122 same OpCode applies.
28124 * cs-parser.jay : Fix some glaring errors I introduced.
28126 2002-01-01 Ravi Pratap <ravi@ximian.com>
28128 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28129 so that we can check for name clashes there too.
28131 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28132 for interface indexers.
28134 * interfaces.cs (Define): Emit the default member attribute.
28136 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28137 variable was being referred to while setting the value ;-)
28139 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28141 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28142 byte-by-byte information when we know the data is zero.
28144 Make the block always a multiple of 4, because
28145 DefineInitializedData has a bug.
28147 * assign.cs: Fix, we should assign from the temporary, not from
28150 * expression.cs (MakeByteBlob): Fix my incorrect code.
28152 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28154 * typemanager.cs (EnumToUnderlying): This function is used to get
28155 the underlying type from an enumeration, because it does not
28158 * constant.cs: Use the I4_S form for values between -128 and 127.
28160 * statement.cs (Block.LookupLabel): Looks up a label.
28161 (Block): Drop support for labeled blocks.
28163 (LabeledStatement): New kind of statement that represents a label
28166 (Goto): Finally implement this bad boy.
28168 * cs-parser.jay: Update to reflect new mechanism to implement
28171 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28173 * codegen.cs (EmitContext.This): a codegen property that keeps the
28174 a single instance of this instead of creating many different this
28177 * delegate.cs (Delegate.DoResolve): Update to use the property;
28179 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28181 * expression.cs (BaseAccess.DoResolve): Ditto.
28183 2001-12-29 Ravi Pratap <ravi@ximian.com>
28185 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28186 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28188 (InitCoreTypes): Update accordingly.
28190 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28191 so we can quickly store the state.
28193 (ApplyAttributes): Set the correct implementation flags
28194 for InternalCall methods.
28196 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28198 * expression.cs (EmitCall): if a method is not virtual, then do
28199 not use callvirt on it.
28201 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28202 user defined stuff) requires the use of stobj, which takes an
28203 address on the stack instead of an array and an index. So emit
28204 the Ldelema operation for it.
28206 (EmitStoreOpcode): Use stobj for valuetypes.
28208 (UnaryMutator.EmitCode): Use the right 1 value depending on
28209 whether we are dealing with int64/uint64, float or doubles.
28211 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28212 constructors that I implemented last night.
28214 (Constructor.IsDefault): Fix to work properly for static
28217 * cs-parser.jay (CheckDef): report method signature errors.
28218 Update error number 103 to be 132.
28220 * decl.cs: New AdditionResult enumeration value: MethodExists.
28221 Although we do this check for methods later on in the semantic
28222 analysis, catching repeated default constructors is so easy that
28223 we catch these here.
28225 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28228 (ParameterReference.EmitAssign, Emit): handle
28231 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28232 (ArrayAccess.EmitStoreOpcode): ditto.
28234 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28236 * expression.cs (MakeByteBlob): Complete all the missing types
28237 (uint, short, ushort, byte, sbyte)
28239 * class.cs: Only init instance field initializers on instance
28242 Rename `constructors' to instance_constructors.
28244 (TypeContainer.AddConstructor): Only add constructors to the list
28245 if it is not static.
28247 Make sure that we handle default_static_constructor independently
28248 everywhere where we handle instance_constructors
28250 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28252 * class.cs: Do not lookup or create a base initializer for a
28253 static constructor.
28255 (ConstructorInitializer.Resolve): use the proper type to lookup
28258 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28260 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28263 * decl.cs: CloseType is now an virtual method, the default
28264 implementation just closes this type.
28266 2001-12-28 Ravi Pratap <ravi@ximian.com>
28268 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28269 to PreserveSig by default. Also emit HideBySig on such methods.
28271 Basically, set the defaults to standard values.
28273 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28274 argument, if candidate is better, it can't be worse than the best !
28276 (Invocation): Re-write bits to differentiate between methods being
28277 applicable in their expanded form and their normal form - for params
28280 Get rid of use_standard everywhere as only standard conversions are allowed
28281 in overload resolution.
28283 More spec conformance.
28285 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28287 * driver.cs: Add --timestamp, to see where the compiler spends
28290 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28291 `this' in static code.
28293 (SimpleName.DoResolve): Implement in terms of a helper function
28294 that allows static-references to be passed upstream to
28297 (Expression.ResolveWithSimpleName): Resolve specially simple
28298 names when called by MemberAccess to implement the special
28301 (Expression.ImplicitReferenceConversion): Handle conversions from
28302 Null to reference types before others, as Null's type is
28305 * expression.cs (Invocation.EmitCall): Handle the special case of
28306 calling methods declared on a reference type from a ValueType
28307 (Base classes System.Object and System.Enum)
28309 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28310 the left hand side is a TypeExpr, not on every enumeration.
28312 (Binary.Resolve): If types are reference types, then do a cast to
28313 object on operators != and == of both arguments.
28315 * typemanager.cs (FindMembers): Extract instance and static
28316 members if requested.
28318 * interface.cs (PopulateProperty): Use void_type instead of null
28319 as the return type for the setter method.
28321 (PopulateIndexer): ditto.
28323 2001-12-27 Ravi Pratap <ravi@ximian.com>
28325 * support.cs (ReflectionParameters): Fix minor bug where we
28326 were examining the wrong parameter for the ParamArray attribute.
28328 Cope with requests for the type of the parameter at position
28329 greater than the params parameter's. We now return the element
28330 type of the params array as that makes more sense.
28332 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28333 accordingly as we no longer have to extract the element type
28336 (Invocation.OverloadResolve): Update.
28338 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28340 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28341 against IEnumerator, test whether the return value is a descendant
28342 of the IEnumerator interface.
28344 * class.cs (Indexer.Define): Use an auxiliary method to implement
28345 the other bits of the method definition. Begin support for
28346 explicit interface implementation.
28348 (Property.DefineMethod): Use TypeManager.void_type instead of null
28349 for an empty return value.
28351 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28353 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28354 dealing with a FieldExpr which is composed of a FieldBuilder, in
28355 the code path we did extract the constant, but we should have
28356 obtained the underlying value to be able to cast it (otherwise we
28357 end up in an infinite loop, this is what Ravi was running into).
28359 (ArrayCreation.UpdateIndices): Arrays might be empty.
28361 (MemberAccess.ResolveMemberAccess): Add support for section
28362 14.5.4.1 that deals with the special case of E.I when E is a type
28363 and something else, that I can be a reference to a static member.
28365 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28366 handle a particular array type to create byte blobs, it is just
28367 something we dont generate byteblobs for.
28369 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28372 * location.cs (Push): remove the key from the hashtable that we
28373 are about to add. This happens for empty files.
28375 * driver.cs: Dispose files after we have parsed them.
28377 (tokenize): new function that only runs the tokenizer on its
28378 input, for speed testing.
28380 2001-12-26 Ravi Pratap <ravi@ximian.com>
28382 * class.cs (Event.Define): Define the private field only if there
28383 are no accessors defined.
28385 * expression.cs (ResolveMemberAccess): If there is no associated
28386 field with the event, that means we have an event defined with its
28387 own accessors and we should flag error cs0070 since transforming
28388 ourselves into a field is not valid in that case.
28390 * ecore.cs (SimpleName.DoResolve): Same as above.
28392 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28393 and charset to sane values.
28395 2001-12-25 Ravi Pratap <ravi@ximian.com>
28397 * assign.cs (DoResolve): Perform check on events only if they
28398 are being accessed outside the declaring type.
28400 * cs-parser.jay (event_declarations): Update rules to correctly
28401 set the type of the implicit parameter etc.
28403 (add_accessor, remove_accessor): Set current local parameters.
28405 * expression.cs (Binary): For delegate addition and subtraction,
28406 cast the return value from the method into the appropriate delegate
28409 2001-12-24 Ravi Pratap <ravi@ximian.com>
28411 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28412 of these as the workaround is unnecessary.
28414 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28415 delegate data - none of that is needed at all.
28417 Re-write bits to extract the instance expression and the delegate method
28420 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28423 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28424 of attaching attributes instead of duplicating code everywhere.
28426 * everywhere : Update code to do attribute emission using the above method.
28428 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28430 * expression.cs (IsParamsMethodApplicable): if there are not
28431 parameters, return immediately.
28433 * ecore.cs: The 0 literal can be implicity converted to an enum
28436 (SimpleName.DoResolve): First lookup the type, then lookup the
28439 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28440 want to get its address. If the InstanceExpression is not
28441 addressable, store the result in a temporary variable, then get
28444 * codegen.cs: Only display 219 errors on warning level or above.
28446 * expression.cs (ArrayAccess): Make it implement the
28447 IMemoryLocation interface.
28449 (Binary.DoResolve): handle the operator == (object a, object b)
28450 and operator != (object a, object b) without incurring into a
28451 BoxedCast (because 5 != o should never be performed).
28453 Handle binary enumerator operators.
28455 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28456 value type, otherwise use Ldelem_ref.
28458 Use precomputed names;
28460 (AddressOf): Implement address of
28462 * cs-parser.jay (labeled_statement): Fix recursive block
28463 addition by reworking the production.
28465 * expression.cs (New.DoEmit): New has a special case:
28467 If we are dealing with a ValueType, we have a few
28468 situations to deal with:
28470 * The target of New is a ValueType variable, that is
28471 easy, we just pass this as the variable reference
28473 * The target of New is being passed as an argument,
28474 to a boxing operation or a function that takes a
28477 In this case, we need to create a temporary variable
28478 that is the argument of New.
28481 2001-12-23 Ravi Pratap <ravi@ximian.com>
28483 * rootcontext.cs (LookupType): Check that current_type is not null before
28484 going about looking at nested types.
28486 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
28487 not implement the IAssignMethod interface any more.
28489 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
28490 where we tranform them into FieldExprs if they are being resolved from within
28491 the declaring type.
28493 * ecore.cs (SimpleName.DoResolve): Do the same here.
28495 * assign.cs (DoResolve, Emit): Clean up code considerably.
28497 * ../errors/bug10.cs : Add.
28499 * ../errors/cs0070.cs : Add.
28501 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
28503 * assign.cs : Get rid of EventIsLocal everywhere.
28505 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28507 * ecore.cs (ConvertIntLiteral): finished the implementation.
28509 * statement.cs (SwitchLabel): Convert the value we are using as a
28510 key before looking up the table.
28512 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28514 * codegen.cs (EmitTopBlock): Require a Location argument now.
28516 * cs-parser.jay (constructor_declarator): We need to setup
28517 current_local_parameters before we parse the
28518 opt_constructor_initializer, to allow the variables to be bound
28519 to the constructor arguments.
28521 * rootcontext.cs (LookupType): First lookup nested classes in our
28522 class and our parents before we go looking outside our class.
28524 * expression.cs (ConstantFold): Extract/debox the values at the
28527 * rootcontext.cs (EmitCode): Resolve the constants first before we
28528 resolve the types. This is not really needed, but it helps debugging.
28530 * statement.cs: report location.
28532 * cs-parser.jay: pass location to throw statement.
28534 * driver.cs: Small bug fix.
28536 * report.cs: Updated format to be 4-zero filled digits.
28538 2001-12-22 Ravi Pratap <ravi@ximian.com>
28540 * expression.cs (CheckIndices): Fix minor bug where the wrong
28541 variable was being referred to ;-)
28543 (DoEmit): Do not call EmitStaticInitializers when the
28544 underlying type is System.Object.
28546 2001-12-21 Ravi Pratap <ravi@ximian.com>
28548 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
28549 and do the usual workaround for SRE.
28551 * class.cs (MyEventBuilder.EventType): New member to get at the type
28552 of the event, quickly.
28554 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
28556 * assign.cs (Assign.DoResolve): Handle the case when the target
28557 is an EventExpr and perform the necessary checks.
28559 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
28562 (SimpleName.MemberStaticCheck): Include check for EventExpr.
28564 (EventExpr): Set the type in the constructor itself since we
28565 are meant to be born fully resolved.
28567 (EventExpr.Define): Revert code I wrote earlier.
28569 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
28570 instance expression is null. The instance expression is a This in that case
28571 or a null, depending on whether it is a static method or not.
28573 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
28574 refers to more than one method.
28576 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
28577 and accordingly flag errors.
28579 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28581 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
28583 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28585 * location.cs (ToString): Provide useful rutine.
28587 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28589 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
28590 objects, return the actual integral boxed.
28592 * statement.cs (SwitchLabel): define an ILLabel for each
28595 (Switch.CheckSwitch): If the value is a Literal, extract
28596 the underlying literal.
28598 Also in the unused hashtable we had, add the SwitchLabel so we can
28599 quickly look this value up.
28601 * constant.cs: Implement a bunch of new constants. Rewrite
28602 Literal based on this. Made changes everywhere to adapt to this.
28604 * expression.cs (Expression.MakeByteBlob): Optimize routine by
28605 dereferencing array only once, and also copes with enumrations.
28607 bytes are two bytes wide, not one.
28609 (Cast): Perform constant conversions.
28611 * ecore.cs (TryImplicitIntConversion): Return literals instead of
28612 wrappers to the literals here.
28614 * expression.cs (DoNumericPromotions): long literals can converted
28615 to ulong implicity (this is taken care of elsewhere, but I was
28616 missing this spot).
28618 * ecore.cs (Expression.Literalize): Make the return type Literal,
28619 to improve type checking.
28621 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
28623 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28625 * literal.cs: Revert code from ravi that checked the bounds. The
28626 bounds are sane by the definition of the type itself.
28628 * typemanager.cs: Fix implementation of ImplementsInterface. We
28629 need to actually look up in our parent hierarchy for interfaces
28632 * const.cs: Use the underlying type for enumerations
28634 * delegate.cs: Compute the basename for the delegate creation,
28635 that should fix the delegate test case, and restore the correct
28636 Type Lookup semantics in rootcontext
28638 * rootcontext.cs: Revert Ravi's last patch. The correct way of
28639 referencing a nested type with the Reflection API is using the "+"
28642 * cs-parser.jay: Do not require EOF token at the end.
28644 2001-12-20 Ravi Pratap <ravi@ximian.com>
28646 * rootcontext.cs (LookupType): Concatenate type names with
28647 a '.' instead of a '+' The test suite passes again.
28649 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
28650 field of the enumeration.
28652 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
28653 the case when the member is an EventExpr.
28655 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
28656 static has an associated instance expression.
28658 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
28660 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
28662 * class.cs (Event.Define): Register event and perform appropriate checks
28665 We define the Add and Remove methods even if the use provides none because
28666 in that case, we provide default implementations ourselves.
28668 Define a private field of the type of the event. This is done by the CSC compiler
28669 and we should be doing it too ;-)
28671 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
28672 More methods we use in code we generate.
28674 (multicast_delegate_type, delegate_type): Two separate types since the distinction
28677 (InitCoreTypes): Update accordingly for the above.
28679 * class.cs (Event.Emit): Generate code for default accessors that we provide
28681 (EmitDefaultMethod): Do the job in the above.
28683 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
28686 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28688 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
28689 builders even if we were missing one.
28691 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
28692 pass the Basename as our class name instead of the Name. The
28693 basename will be correctly composed for us.
28695 * parameter.cs (Paramters): Now takes a Location argument.
28697 * decl.cs (DeclSpace.LookupType): Removed convenience function and
28698 make all the code call directly LookupType in RootContext and take
28699 this chance to pass the Location information everywhere.
28701 * Everywhere: pass Location information.
28703 2001-12-19 Miguel de Icaza <miguel@ximian.com>
28705 * class.cs (Constructor.Define): Updated way of detecting the
28706 length of the parameters.
28708 (TypeContainer.DefineType): Use basename as the type name for
28711 (TypeContainer.Define): Do not recursively define types here, as
28712 definition is taken care in order by the RootContext.
28714 * tree.cs: Keep track of namespaces in a per-file basis.
28716 * parameter.cs (Parameter.ComputeSignature): Update to use
28719 (Parameters.GetSignature): ditto.
28721 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
28722 instead of a TypeContainer.
28724 (Interface.SemanticAnalysis): Use `this' instead of our parent to
28725 resolve names. Because we need to be resolve in our context, not
28728 * driver.cs: Implement response files.
28730 * class.cs (TypeContainer.DefineType): If we are defined, do not
28731 redefine ourselves.
28733 (Event.Emit): Emit the code for add/remove handlers.
28734 (Event.Define): Save the MethodBuilders for add/remove.
28736 * typemanager.cs: Use pair here too.
28738 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
28739 DictionaryEntry requires the first argument to be non-null.
28741 (enum_declaration): Compute full name for registering the
28744 (delegate_declaration): Instead of using
28745 formal_parameter_list, use opt_formal_parameter_list as the list
28748 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
28749 (EventParsing): New property that controls whether `add' and
28750 `remove' are returned as tokens or identifiers (for events);
28752 2001-12-19 Ravi Pratap <ravi@ximian.com>
28754 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
28755 use MyEventBuilder only and let it wrap the real builder for us.
28757 (MyEventBuilder): Revamp constructor etc.
28759 Implement all operations that we perform on EventBuilder in precisely the same
28762 (FindMembers): Update to use the EventBuilder member.
28764 (Event.Emit): Update accordingly.
28766 2001-12-18 Ravi Pratap <ravi@ximian.com>
28768 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
28769 by calling the appropriate methods.
28771 (GetCustomAttributes): Make stubs as they cannot possibly do anything
28774 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
28776 2001-12-17 Ravi Pratap <ravi@ximian.com>
28778 * delegate.cs (Delegate.Populate): Check that the return type
28779 and various parameters types are indeed accessible.
28781 * class.cs (Constructor.Define): Same here.
28783 (Field.Define): Ditto.
28785 (Event.Define): Ditto.
28787 (Operator.Define): Check that the underlying Method defined itself
28788 correctly - so it's MethodBuilder should not be null.
28790 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
28791 expression happens to be null.
28793 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
28794 members but as of now we don't seem to be able to do anything really useful with it.
28796 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
28797 not the EventBuilder.
28799 2001-12-18 Miguel de Icaza <miguel@ximian.com>
28801 * cs-tokenizer.cs: Add support for defines.
28802 Add support for #if, #elif, #else, #endif
28804 (eval_var): evaluates a variable.
28805 (eval): stubbed for evaluating functions.
28807 * cs-parser.jay: Pass the defines information
28809 * driver.cs: Add --define command line option.
28811 * decl.cs: Move MemberCore here.
28813 Make it the base class for DeclSpace. This allows us to catch and
28814 report 108 and 109 for everything now.
28816 * class.cs (TypeContainer.Define): Extract all the members
28817 before populating and emit the warning 108 (new keyword required
28818 to override) instead of having each member implement this.
28820 (MemberCore.Define): New abstract method, we will be using this in
28821 the warning reporting engine in Populate.
28823 (Operator.Define): Adjust to new MemberCore protocol.
28825 * const.cs (Const): This does not derive from Expression, it is a
28826 temporary object we use to create fields, it is a MemberCore.
28828 * class.cs (Method.Define): Allow the entry point to be in a
28831 * driver.cs: Rewrite the argument handler to clean it up a bit.
28833 * rootcontext.cs: Made it just an auxiliary namespace feature by
28834 making everything static.
28836 * driver.cs: Adapt code to use RootContext type name instead of
28839 * delegate.cs: Remove RootContext argument.
28841 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
28844 * class.cs (Event.Define): The lookup can fail.
28846 * cs-tokenizer.cs: Begin implementation of pre-procesor.
28848 * expression.cs: Resolve the this instance before invoking the code.
28850 2001-12-17 Miguel de Icaza <miguel@ximian.com>
28852 * cs-parser.jay: Add a production in element_access that allows
28853 the thing to become a "type" reference. This way we can parse
28854 things like "(string [])" as a type.
28856 Note that this still does not handle the more complex rules of
28860 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
28862 * ecore.cs: (CopyNewMethods): new utility function used to
28863 assemble the list of methods from running FindMembers.
28865 (MemberLookup): Rework FindMembers so that
28867 2001-12-16 Miguel de Icaza <miguel@ximian.com>
28869 * class.cs (TypeContainer): Remove Delegates who fail to be
28872 * delegate.cs (Populate): Verify that we dont get null return
28873 values. TODO: Check for AsAccessible.
28875 * cs-parser.jay: Use basename to emit error 574 (destructor should
28876 have the same name as container class), not the full name.
28878 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
28879 possible representation.
28881 Also implements integer type suffixes U and L.
28883 2001-12-15 Miguel de Icaza <miguel@ximian.com>
28885 * expression.cs (ArrayCreation.DoResolve): We need to do the
28886 argument resolution *always*.
28888 * decl.cs: Make this hold the namespace. Hold the root context as
28890 (LookupType): Move here.
28892 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
28894 * location.cs (Row, Name): Fixed the code, it was always returning
28895 references to the first file.
28897 * interface.cs: Register properties defined through interfaces.
28899 * driver.cs: Add support for globbing on the command line
28901 * class.cs (Field): Make it derive from MemberCore as well.
28904 2001-12-15 Ravi Pratap <ravi@ximian.com>
28906 * class.cs (Event::Define): Check that the type of the event is a delegate
28907 type else flag error #66.
28909 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
28912 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
28913 values of EntryPoint, CharSet etc etc.
28915 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
28917 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
28918 be null and we should ignore this. I am not sure if this is really clean. Apparently,
28919 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
28920 which needs this to do its work.
28922 * ../errors/cs0066.cs : Add.
28924 2001-12-14 Miguel de Icaza <miguel@ximian.com>
28926 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
28929 * class.cs: (MethodSignature.MethodSignature): Removed hack that
28930 clears out the parameters field.
28931 (MemberSignatureCompare): Cleanup
28933 (MemberCore): New base class used to share code between MethodCore
28936 (RegisterRequiredImplementations) BindingFlags.Public requires
28937 either BindingFlags.Instace or Static. Use instance here.
28939 (Property): Refactored code to cope better with the full spec.
28941 * parameter.cs (GetParameterInfo): Return an empty array instead
28944 * class.cs (Property): Abstract or extern properties have no bodies.
28946 * parameter.cs (GetParameterInfo): return a zero-sized array.
28948 * class.cs (TypeContainer.MethodModifiersValid): Move all the
28949 method modifier validation to the typecontainer so we can reuse
28950 this on properties.
28952 (MethodCore.ParameterTypes): return an empty sized array of types.
28954 (Property.Define): Test property modifier validity.
28956 Add tests for sealed/override too.
28958 (Method.Emit): abstract or extern methods have no bodies.
28960 2001-12-14 Ravi Pratap <ravi@ximian.com>
28962 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
28965 (Method::Define, ::Emit): Modify accordingly.
28967 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
28969 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
28971 * makefile: Pass in /unsafe.
28973 2001-12-13 Miguel de Icaza <miguel@ximian.com>
28975 * class.cs (MakeKey): Kill routine.
28977 * class.cs (TypeContainer.Define): Correctly define explicit
28978 method implementations (they require the full interface name plus
28981 * typemanager.cs: Deply the PtrHashtable here and stop using the
28982 lame keys. Things work so much better.
28984 This of course broke everyone who depended on `RegisterMethod' to
28985 do the `test for existance' test. This has to be done elsewhere.
28987 * support.cs (PtrHashtable): A hashtable that avoid comparing with
28988 the object stupid Equals method (because, that like fails all over
28989 the place). We still do not use it.
28991 * class.cs (TypeContainer.SetRequiredInterface,
28992 TypeContainer.RequireMethods): Killed these two routines and moved
28993 all the functionality to RegisterRequiredImplementations.
28995 (TypeContainer.RegisterRequiredImplementations): This routine now
28996 registers all the implementations required in an array for the
28997 interfaces and abstract methods. We use an array of structures
28998 which can be computed ahead of time to reduce memory usage and we
28999 also assume that lookups are cheap as most classes will not
29000 implement too many interfaces.
29002 We also avoid creating too many MethodSignatures.
29004 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29005 clear the "pending" bit if we find that there are problems with
29008 (TypeContainer.VerifyPendingMethods): Update to report errors of
29009 methods that look like implementations but are not.
29011 (TypeContainer.Define): Add support for explicit interface method
29014 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29016 * typemanager.cs: Keep track of the parameters here instead of
29017 being a feature of the TypeContainer.
29019 * class.cs: Drop the registration of parameters here, as
29020 InterfaceMethods are also interface declarations.
29022 * delegate.cs: Register methods with the TypeManager not only with
29023 the TypeContainer. This code was buggy.
29025 * interface.cs: Full registation here.
29027 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29029 * expression.cs: Remove reducer for binary expressions, it can not
29032 * const.cs: Put here the code that used to go into constant.cs
29034 * constant.cs: Put here the code for constants, this is a new base
29035 class for Literals.
29037 * literal.cs: Make Literal derive from Constant.
29039 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29041 * statement.cs (Return.Emit): Report error 157 if the user
29042 attempts to return from a finally block.
29044 (Return.Emit): Instead of emitting a return, jump to the end of
29047 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29048 LocalBuilder to store the result of the function. ReturnLabel is
29049 the target where we jump.
29052 2001-12-09 Radek Doulik <rodo@ximian.com>
29054 * cs-parser.jay: remember alias in current namespace
29056 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29059 * class.cs (LookupAlias): lookup alias in my_namespace
29061 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29063 (LookupAlias): lookup alias in this and if needed in parent
29066 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29070 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29071 making things static. I need this to avoid passing the
29072 TypeContainer when calling ParameterType.
29074 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29075 that did string manipulation to compute the type and then call
29076 GetType. Use Parameter.ParameterType instead.
29078 * cs-tokenizer.cs: Consume the suffix for floating values.
29080 * expression.cs (ParameterReference): figure out whether this is a
29081 reference parameter or not. Kill an extra variable by computing
29082 the arg_idx during emission.
29084 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29085 function that returns whether a parameter is an out/ref value or not.
29087 (Parameter.ParameterType): The type of the parameter (base,
29088 without ref/out applied).
29090 (Parameter.Resolve): Perform resolution here.
29091 (Parameter.ExternalType): The full type (with ref/out applied).
29093 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29094 support for expressions on the using statement.
29096 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29098 * statement.cs (Using.EmitLocalVariableDecls): Split the
29099 localvariable handling of the using statement.
29101 (Block.EmitMeta): Keep track of variable count across blocks. We
29102 were reusing slots on separate branches of blocks.
29104 (Try.Emit): Emit the general code block, we were not emitting it.
29106 Check the type of the declaration to be an IDisposable or
29107 something that can be implicity converted to it.
29109 Emit conversions if required.
29111 * ecore.cs (EmptyExpression): New utility class.
29112 (Expression.ImplicitConversionExists): New utility function.
29114 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29116 * statement.cs (Using): Implement.
29118 * expression.cs (LocalVariableReference): Support read only variables.
29120 * statement.cs: Remove the explicit emit for the Leave opcode.
29121 (VariableInfo): Add a readonly field.
29123 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29125 * ecore.cs (ConvCast): new class used to encapsulate the various
29126 explicit integer conversions that works in both checked and
29127 unchecked contexts.
29129 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29130 properly generate the overflow opcodes.
29132 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29134 * statement.cs: The correct type for the EmptyExpression is the
29135 element_type, not the variable type. Ravi pointed this out.
29137 2001-12-04 Ravi Pratap <ravi@ximian.com>
29139 * class.cs (Method::Define): Handle PInvoke methods specially
29140 by using DefinePInvokeMethod instead of the usual one.
29142 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29143 above to do the task of extracting information and defining the method.
29145 2001-12-04 Ravi Pratap <ravi@ximian.com>
29147 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29148 of the condition for string type.
29150 (Emit): Move that here.
29152 (ArrayCreation::CheckIndices): Keep string literals in their expression
29155 (EmitDynamicInitializers): Handle strings appropriately.
29157 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29159 * codegen.cs (EmitContext): Replace multiple variables with a
29160 single pointer to the current Switch statement.
29162 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29165 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29169 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29172 (Foreach.Emit): Foreach on arrays was not setting
29173 up the loop variables (for break/continue).
29175 (GotoCase): Semi-implented.
29177 2001-12-03 Ravi Pratap <ravi@ximian.com>
29179 * attribute.cs (CheckAttribute): Handle system attributes by using
29180 Attribute.GetAttributes to examine information we need.
29182 (GetValidPlaces): Same here.
29184 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29186 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29188 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29190 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29192 (Method::Emit): Handle the case when we are a PInvoke method.
29194 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29196 * expression.cs: Use ResolveWithSimpleName on compound names.
29198 2001-12-02 Ravi Pratap <ravi@ximian.com>
29200 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29201 before trying to reduce it.
29203 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29205 * constant.cs (LookupConstantValue): Implement.
29207 (EmitConstant): Use the above in emitting the constant.
29209 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29210 that are user-defined by doing a LookupConstantValue on them.
29212 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29215 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29217 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29219 (BaseAccess.DoResolve): Implement.
29221 (MemberAccess.DoResolve): Split this routine into a
29222 ResolveMemberAccess routine that can be used independently
29224 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29226 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29227 As that share bits of the implementation. Is returns a boolean,
29228 while As returns the Type that is being probed.
29230 2001-12-01 Ravi Pratap <ravi@ximian.com>
29232 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29233 instead of a Literal - much easier.
29235 (EnumInTransit): Remove - utterly useless :-)
29237 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29239 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29241 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29242 chain when we have no associated expression.
29244 2001-11-30 Ravi Pratap <ravi@ximian.com>
29246 * constant.cs (Define): Use Location while reporting the errror.
29248 Also emit a warning when 'new' is used and there is no inherited
29251 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29254 (LookupEnumValue): Implement to lookup an enum member's value and define it
29257 (Populate): Re-write accordingly to use the above routine.
29259 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29261 * expression.cs (This): Fix prototype for DoResolveLValue to
29262 override the base class DoResolveLValue.
29264 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29267 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29268 (we need to load the address of the field here). This fixes
29271 (FieldExpr.DoResolveLValue): Call the DoResolve
29272 function to initialize the Instance expression.
29274 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29275 correctly the GetEnumerator operation on a value type.
29277 * cs-parser.jay: Add more simple parsing error catches.
29279 * statement.cs (Switch): Add support for string switches.
29280 Handle null specially.
29282 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29284 2001-11-28 Ravi Pratap <ravi@ximian.com>
29286 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29288 (declare_local_constant): New helper function.
29290 * statement.cs (AddConstant): Keep a separate record of constants
29292 (IsConstant): Implement to determine if a variable is a constant.
29294 (GetConstantExpression): Implement.
29296 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29298 * statement.cs (IsVariableDefined): Re-write.
29300 2001-11-27 Ravi Pratap <ravi@ximian.com>
29302 * class.cs (TypeContainer::FindMembers): Look for constants
29303 in the case when we are looking for MemberTypes.Field
29305 * expression.cs (MemberAccess::DoResolve): Check that in the
29306 case we are a FieldExpr and a Literal, we are not being accessed
29307 by an instance reference.
29309 * cs-parser.jay (local_constant_declaration): Implement.
29311 (declaration_statement): Implement for constant declarations.
29313 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29315 * statement.cs (Switch): Catch double defaults.
29317 (Switch): More work on the switch() statement
29318 implementation. It works for integral values now, need to finish
29322 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29324 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29325 integer literals into other integer literals. To be used by
29328 2001-11-24 Ravi Pratap <ravi@ximian.com>
29330 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29333 (EmitDynamicInitializers): Cope with the above since we extract data
29334 directly from ArrayData now.
29336 (ExpectInitializers): Keep track of whether initializers are mandatory
29339 (Bounds): Make it a hashtable to prevent the same dimension being
29340 recorded for every element in that dimension.
29342 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29345 Also fix bug which was causing the indices to be emitted in the reverse
29348 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29350 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29351 unfinished. They do not work, because the underlying code is
29354 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29356 * cs-parser.jay: Remove bogus fixme.
29358 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29359 on Switch statement.
29361 2001-11-23 Ravi Pratap <ravi@ximian.com>
29363 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29366 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29367 parameter. Apparently, any expression is allowed.
29369 (ValidateInitializers): Update accordingly.
29371 (CheckIndices): Fix some tricky bugs thanks to recursion.
29373 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29374 I was being completely brain-dead.
29376 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29377 and re-write acordingly.
29379 (DelegateInvocation): Re-write accordingly.
29381 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29383 (MakeByteBlob): Handle types more correctly.
29385 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29386 initialization from expressions but it is incomplete because I am a complete
29389 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29391 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29392 on If. Basically, we have to return `true' (ie, we do return to
29393 our caller) only if both branches of the if return.
29395 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29396 short-circuit operators, handle them as short circuit operators.
29398 (Cast.DoResolve): Resolve type.
29399 (Cast.Cast): Take an expression as the target type.
29401 * cs-parser.jay (cast_expression): Remove old hack that only
29402 allowed a limited set of types to be handled. Now we take a
29403 unary_expression and we resolve to a type during semantic
29406 Use the grammar productions from Rhys to handle casts (this is
29407 not complete like Rhys syntax yet, we fail to handle that corner
29408 case that C# has regarding (-x), but we will get there.
29410 2001-11-22 Ravi Pratap <ravi@ximian.com>
29412 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29413 field which is an array type.
29415 * cs-parser.jay (declare_local_variables): Support array initialization too.
29417 * typemanager.cs (MakeKey): Implement.
29419 (everywhere): Use the above appropriately.
29421 * cs-parser.jay (for_statement): Update for array initialization while
29422 declaring variables.
29424 * ecore.cs : The error message was correct, it's the variable's names that
29425 were misleading ;-) Make the code more readable.
29427 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29428 the correct type etc.
29430 (ConvertExplicit): Handle Enum types by examining the underlying type.
29432 2001-11-21 Ravi Pratap <ravi@ximian.com>
29434 * parameter.cs (GetCallingConvention): Always return
29435 CallingConventions.Standard for now.
29437 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29439 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29440 and `r' after calling DoNumericPromotions.
29442 * ecore.cs: Fix error message (the types were in the wrong order).
29444 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29445 BindingFlags.Instance as well
29447 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29448 implicit int literal conversion in an empty cast so that we
29449 propagate the right type upstream.
29451 (UnboxCast): new class used to unbox value types.
29452 (Expression.ConvertExplicit): Add explicit type conversions done
29455 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29456 the target type before applying the implicit LongLiterals to ULong
29459 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29461 * cs-parser.jay (for_statement): Reworked the way For works: now
29462 we declare manually any variables that are introduced in
29463 for_initializer to solve the problem of having out-of-band code
29464 emition (that is what got for broken).
29466 (declaration_statement): Perform the actual variable declaration
29467 that used to be done in local_variable_declaration here.
29469 (local_variable_declaration): Do not declare anything, just pass
29470 the information on a DictionaryEntry
29472 2001-11-20 Ravi Pratap <ravi@ximian.com>
29474 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29475 re-write of the logic to now make it recursive.
29477 (UpdateIndices): Re-write accordingly.
29479 Store element data in a separate ArrayData list in the above methods.
29481 (MakeByteBlob): Implement to dump the array data into a byte array.
29483 2001-11-19 Ravi Pratap <ravi@ximian.com>
29485 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
29488 * constant.cs (Define): Implement.
29490 (EmitConstant): Re-write fully.
29492 Pass in location info.
29494 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
29497 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
29498 DictionaryEntry since we need location info too.
29500 (constant_declaration): Update accordingly.
29502 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
29503 code into another method : UpdateIndices.
29505 2001-11-18 Ravi Pratap <ravi@ximian.com>
29507 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
29508 some type checking etc.
29510 2001-11-17 Ravi Pratap <ravi@ximian.com>
29512 * expression.cs (ArrayCreation::ValidateInitializers): Implement
29513 bits to provide dimension info if the user skips doing that.
29515 Update second constructor to store the rank correctly.
29517 2001-11-16 Ravi Pratap <ravi@ximian.com>
29519 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
29520 and try to implement.
29522 * ../errors/cs0150.cs : Add.
29524 * ../errors/cs0178.cs : Add.
29526 2001-11-16 Miguel de Icaza <miguel@ximian.com>
29528 * statement.cs: Implement foreach on multi-dimensional arrays.
29530 * parameter.cs (Parameters.GetParameterByName): Also lookup the
29531 name of the params argument.
29533 * expression.cs: Use EmitStoreOpcode to get the right opcode while
29534 initializing the array.
29536 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
29537 we can use this elsewhere.
29539 * statement.cs: Finish implementation of foreach for single
29542 * cs-parser.jay: Use an out-of-band stack to pass information
29543 around, I wonder why I need this.
29545 foreach_block: Make the new foreach_block the current_block.
29547 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
29548 function used to return a static Parameters structure. Used for
29549 empty parameters, as those are created very frequently.
29551 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
29553 2001-11-15 Ravi Pratap <ravi@ximian.com>
29555 * interface.cs : Default modifier is private, not public. The
29556 make verify test passes again.
29558 2001-11-15 Ravi Pratap <ravi@ximian.com>
29560 * support.cs (ReflectionParameters): Fix logic to determine
29561 whether the last parameter is a params one. Test 9 passes again.
29563 * delegate.cs (Populate): Register the builders we define with
29564 RegisterParameterForBuilder. Test 19 passes again.
29566 * cs-parser.jay (property_declaration): Reference $6 instead
29567 of $$ to get at the location.
29569 (indexer_declaration): Similar stuff.
29571 (attribute): Ditto.
29573 * class.cs (Property): Register parameters for the Get and Set methods
29574 if they exist. Test 23 passes again.
29576 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
29577 call to EmitArguments as we are sure there aren't any params arguments.
29578 Test 32 passes again.
29580 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
29581 IndexOutOfRangeException.
29583 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
29584 Test 33 now passes again.
29586 2001-11-15 Miguel de Icaza <miguel@ximian.com>
29588 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
29589 broke a bunch of things. Will have to come up with a better way
29590 of tracking locations.
29592 * statement.cs: Implemented foreach for single dimension arrays.
29594 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29596 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
29597 an error. This removes the lookup from the critical path.
29599 * cs-parser.jay: Removed use of temporary_loc, which is completely
29602 2001-11-14 Miguel de Icaza <miguel@ximian.com>
29604 * support.cs (ReflectionParameters.ParameterModifier): Report
29605 whether the argument is a PARAMS argument or not.
29607 * class.cs: Set the attribute `ParamArrayAttribute' on the
29608 parameter argument.
29610 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
29611 and cons_param_array_attribute (ConstructorInfo for
29612 ParamArrayAttribute).,
29614 * codegen.cs: Emit the return using the `Return' statement, that
29615 way we can report the error correctly for missing return values.
29617 * class.cs (Method.Emit): Clean up.
29619 * expression.cs (Argument.Resolve): Take another argument: the
29620 location where this argument is used. Notice that this is not
29621 part of the "Argument" class as to reduce the size of the
29622 structure (we know the approximate location anyways).
29624 Test if the argument is a variable-reference, if not, then
29625 complain with a 206.
29627 (Argument.Emit): Emit addresses of variables.
29629 (Argument.FullDesc): Simplify.
29631 (Invocation.DoResolve): Update for Argument.Resolve.
29633 (ElementAccess.DoResolve): ditto.
29635 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
29636 method should be virtual, as this method is always virtual.
29638 (NewDelegate.DoResolve): Update for Argument.Resolve.
29640 * class.cs (ConstructorInitializer.DoResolve): ditto.
29642 * attribute.cs (Attribute.Resolve): ditto.
29644 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29646 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
29648 * expression.cs (ParameterReference): Drop IStackStorage and implement
29649 IAssignMethod instead.
29651 (LocalVariableReference): ditto.
29653 * ecore.cs (FieldExpr): Drop IStackStorage and implement
29654 IAssignMethod instead.
29656 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29658 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
29659 enumerations that are used in heavily used structures derive from
29660 byte in a laughable and pathetic attempt to reduce memory usage.
29661 This is the kind of pre-optimzations that you should not do at
29662 home without adult supervision.
29664 * expression.cs (UnaryMutator): New class, used to handle ++ and
29665 -- separatedly from the other unary operators. Cleans up the
29666 code, and kills the ExpressionStatement dependency in Unary.
29668 (Unary): Removed `method' and `Arguments' from this class, making
29669 it smaller, and moving it all to SimpleCall, so I can reuse this
29670 code in other locations and avoid creating a lot of transient data
29671 strucutres when not required.
29673 * cs-parser.jay: Adjust for new changes.
29675 2001-11-11 Miguel de Icaza <miguel@ximian.com>
29677 * enum.cs (Enum.Populate): If there is a failure during
29680 * cs-parser.jay (opt_enum_base): we used to catch type errors
29681 here, but this is really incorrect. The type error should be
29682 catched during semantic analysis.
29684 2001-12-11 Ravi Pratap <ravi@ximian.com>
29686 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
29687 current_local_parameters as expected since I, in my stupidity, had forgotten
29690 * attribute.cs (GetValidPlaces): Fix stupid bug.
29692 * class.cs (Method::Emit): Perform check on applicability of attributes.
29694 (Constructor::Emit): Ditto.
29696 (Field::Emit): Ditto.
29698 (Field.Location): Store location information.
29700 (Property, Event, Indexer, Operator): Ditto.
29702 * cs-parser.jay (field_declaration): Pass in location for each field.
29704 * ../errors/cs0592.cs : Add.
29706 2001-11-12 Ravi Pratap <ravi@ximian.com>
29708 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
29710 (InitCoreTypes): Update accordingly.
29712 (RegisterAttrType, LookupAttr): Implement.
29714 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
29715 info about the same.
29717 (Resolve): Update to populate the above as necessary.
29719 (Error592): Helper.
29721 (GetValidPlaces): Helper to the above.
29723 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
29725 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
29727 2001-11-12 Ravi Pratap <ravi@ximian.com>
29729 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
29731 * ../errors/cs0617.cs : Add.
29733 2001-11-11 Ravi Pratap <ravi@ximian.com>
29735 * enum.cs (Emit): Rename to Populate to be more consistent with what
29736 we expect it to do and when exactly it is called.
29738 * class.cs, rootcontext.cs : Update accordingly.
29740 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
29741 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
29743 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
29745 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
29746 of a fieldinfo using the above, when dealing with a FieldBuilder.
29748 2001-11-10 Ravi Pratap <ravi@ximian.com>
29750 * ../errors/cs0031.cs : Add.
29752 * ../errors/cs1008.cs : Add.
29754 * ../errrors/cs0543.cs : Add.
29756 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
29759 (FindMembers): Implement.
29761 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
29762 enums and delegates too.
29764 (enum_types): Rename to builder_to_enum.
29766 (delegate_types): Rename to builder_to_delegate.
29768 * delegate.cs (FindMembers): Implement.
29770 2001-11-09 Ravi Pratap <ravi@ximian.com>
29772 * typemanager.cs (IsEnumType): Implement.
29774 * enum.cs (Emit): Re-write parts to account for the underlying type
29775 better and perform checking etc.
29777 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
29778 of the underlying type.
29780 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
29783 * enum.cs (error31): Helper to report error #31.
29785 * cs-parser.jay (enum_declaration): Store location of each member too.
29787 * enum.cs (member_to_location): New hashtable.
29789 (AddEnumMember): Update location hashtable.
29791 (Emit): Use the location of each member while reporting errors.
29793 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29795 * cs-parser.jay: A for_initializer if is a
29796 local_variable_declaration really ammount to have an implicit
29797 block with the variable declaration and no initializer for for.
29799 * statement.cs (For.Emit): Cope with null initializers.
29801 This fixes the infinite loop on for initializers.
29803 2001-11-08 Miguel de Icaza <miguel@ximian.com>
29805 * enum.cs: More cleanup.
29807 * ecore.cs: Remove dead code.
29809 * class.cs (Property.Emit): More simplification.
29810 (Event.Emit): ditto.
29812 Reworked to have less levels of indentation.
29814 2001-11-08 Ravi Pratap <ravi@ximian.com>
29816 * class.cs (Property): Emit attributes.
29826 * enum.cs (Emit): Ditto.
29828 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
29831 * class.cs (Field, Event, etc.): Move attribute generation into the
29832 Emit method everywhere.
29834 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
29835 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
29836 as we had no way of defining nested enums !
29838 * rootcontext.cs : Adjust code accordingly.
29840 * typemanager.cs (AddEnumType): To keep track of enum types separately.
29842 2001-11-07 Ravi Pratap <ravi@ximian.com>
29844 * expression.cs (EvalConstantExpression): Move into ecore.cs
29846 * enum.cs (Enum): Rename some members and make them public and readonly
29847 according to our convention.
29849 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
29852 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
29854 (Enum::Emit): Write a simple version for now which doesn't try to compute
29855 expressions. I shall modify this to be more robust in just a while.
29857 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
29859 (TypeContainer::CloseType): Create the Enum types too.
29861 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
29863 * expression.cs (EvalConstantExpression): Get rid of completely.
29865 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
29866 user-defined values and other cases.
29868 (IsValidEnumLiteral): Helper function.
29870 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
29871 out there in the case we had a literal FieldExpr.
29873 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
29875 (Literalize): Revamp a bit to take two arguments.
29877 (EnumLiteral): New class which derives from Literal to wrap enum literals.
29879 2001-11-06 Ravi Pratap <ravi@ximian.com>
29881 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
29883 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
29885 (Resolve): Use the above to ensure we have proper initializers.
29887 2001-11-05 Ravi Pratap <ravi@ximian.com>
29889 * expression.cs (Expression::EvalConstantExpression): New method to
29890 evaluate constant expressions.
29892 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
29894 2001-11-07 Miguel de Icaza <miguel@ximian.com>
29896 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
29899 (Binary.ResolveOperator): Handle operator != (object a, object b)
29900 and operator == (object a, object b);
29902 (Binary.DoNumericPromotions): Indicate whether the numeric
29903 promotion was possible.
29905 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
29908 Made the ArrayAccess implement interface IAssignMethod instead of
29909 IStackStore as the order in which arguments are passed reflects
29912 * assign.cs: Instead of using expr.ExprClass to select the way of
29913 assinging, probe for the IStackStore/IAssignMethod interfaces.
29915 * typemanager.cs: Load InitializeArray definition.
29917 * rootcontext.cs (RootContext.MakeStaticData): Used to define
29918 static data that can be used to initialize arrays.
29920 2001-11-05 Miguel de Icaza <miguel@ximian.com>
29922 * expression.cs: Handle operator== and operator!= for booleans.
29924 (Conditioal.Reduce): Implement reducer for the ?: operator.
29926 (Conditional.Resolve): Implement dead code elimination.
29928 (Binary.Resolve): Catch string literals and return a new
29929 concatenated string.
29931 (Unary.Reduce): Implement reduction of unary expressions.
29933 * ecore.cs: Split out the expression core handling here.
29935 (Expression.Reduce): New method used to perform constant folding
29936 and CSE. This is needed to support constant-expressions.
29938 * statement.cs (Statement.EmitBoolExpression): Pass true and false
29939 targets, and optimize for !x.
29941 2001-11-04 Ravi Pratap <ravi@ximian.com>
29943 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
29944 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
29945 set custom atttributes.
29947 * literal.cs (Literal::GetValue): New abstract method to return the actual
29948 value of the literal, cast as an object.
29950 (*Literal): Implement GetValue method.
29952 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
29953 expressions to the arraylist but objects of type Argument.
29955 * class.cs (TypeContainer::Emit): Emit our attributes too.
29957 (Method::Emit, Constructor::Emit): Ditto.
29959 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
29960 to be ignoring earlier.
29962 2001-11-03 Ravi Pratap <ravi@ximian.com>
29964 * attribute.cs (AttributeSection::Define): Implement to do the business
29965 of constructing a CustomAttributeBuilder.
29967 (Attribute): New trivial class. Increases readability of code.
29969 * cs-parser.jay : Update accordingly.
29971 (positional_argument_list, named_argument_list, named_argument): New rules
29973 (attribute_arguments): Use the above so that we are more correct.
29975 2001-11-02 Ravi Pratap <ravi@ximian.com>
29977 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
29978 to perform all checks for a method with a params parameter.
29980 (Invocation::OverloadResolve): Update to use the above method and therefore
29981 cope correctly with params method invocations.
29983 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
29986 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
29987 constructors in our parent too because we can't afford to miss out on
29990 * attribute.cs (AttributeSection): New name for the class Attribute
29992 Other trivial changes to improve readability.
29994 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
29995 use the new class names.
29997 2001-11-01 Ravi Pratap <ravi@ximian.com>
29999 * class.cs (Method::Define): Complete definition for params types too
30001 (Indexer::Define): Ditto.
30003 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30004 Cope everywhere with a request for info about the array parameter.
30006 2001-11-01 Ravi Pratap <ravi@ximian.com>
30008 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30010 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30011 local_variable_type to extract the string corresponding to the type.
30013 (local_variable_type): Fixup the action to use the new helper method.
30015 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30018 * expression.cs : Clean out code which uses the above.
30020 2001-10-31 Ravi Pratap <ravi@ximian.com>
30022 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30023 and bale out if necessary by returning a false.
30025 (RegisterProperty): Ditto.
30027 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30028 and print out appropriate error messages.
30030 * interface.cs (everywhere): Ditto.
30032 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30033 location to constructor.
30035 * class.cs (Property, Event, Indexer): Update accordingly.
30037 * ../errors/cs111.cs : Added.
30039 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30040 of a method, as laid down by the spec.
30042 (Invocation::OverloadResolve): Use the above method.
30044 2001-10-31 Ravi Pratap <ravi@ximian.com>
30046 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30047 now take a TypeContainer and a Parameters object.
30049 (ParameterData): Modify return type of ParameterModifier method to be
30050 Parameter.Modifier and not a string.
30052 (ReflectionParameters, InternalParameters): Update accordingly.
30054 * expression.cs (Argument::GetParameterModifier): Same here.
30056 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30057 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30058 symbol in it at all so maybe this is only for now.
30060 2001-10-30 Ravi Pratap <ravi@ximian.com>
30062 * support.cs (InternalParameters): Constructor now takes an extra argument
30063 which is the actual Parameters class.
30065 (ParameterDesc): Update to provide info on ref/out modifiers.
30067 * class.cs (everywhere): Update call to InternalParameters to pass in
30068 the second argument too.
30070 * support.cs (ParameterData): Add ParameterModifier, which is a method
30071 to return the modifier info [ref/out etc]
30073 (InternalParameters, ReflectionParameters): Implement the above.
30075 * expression.cs (Argument::ParameterModifier): Similar function to return
30076 info about the argument's modifiers.
30078 (Invocation::OverloadResolve): Update to take into account matching modifiers
30081 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30082 a new SetFormalParameters object which we pass to InternalParameters.
30084 2001-10-30 Ravi Pratap <ravi@ximian.com>
30086 * expression.cs (NewArray): Merge into the ArrayCreation class.
30088 2001-10-29 Ravi Pratap <ravi@ximian.com>
30090 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30091 NewUserdefinedArray into one as there wasn't much of a use in having
30094 * expression.cs (Argument): Change field's name to ArgType from Type.
30096 (Type): New readonly property which returns the proper type, taking into
30097 account ref/out modifiers.
30099 (everywhere): Adjust code accordingly for the above.
30101 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30102 whether we are emitting for a ref or out parameter.
30104 * expression.cs (Argument::Emit): Use the above field to set the state.
30106 (LocalVariableReference::Emit): Update to honour the flag and emit the
30109 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30111 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30113 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30115 (ReflectionParameters, InternalParameters): Implement the above method.
30117 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30120 (Invocation::FullMethodDesc): Ditto.
30122 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30124 * cs-parser.jay: Add extra production for the second form of array
30127 * expression.cs (ArrayCreation): Update to reflect the above
30130 * Small changes to prepare for Array initialization.
30132 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30134 * typemanager.cs (ImplementsInterface): interface might be null;
30135 Deal with this problem;
30137 Also, we do store negative hits on the cache (null values), so use
30138 this instead of calling t.GetInterfaces on the type everytime.
30140 2001-10-28 Ravi Pratap <ravi@ximian.com>
30142 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30144 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30145 split functionality out into different classes.
30147 (New::FormArrayType): Move into NewBuiltinArray.
30149 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30152 (NewBuiltinArray): New class to handle creation of built-in arrays.
30154 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30155 account creation of one-dimensional arrays.
30157 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30159 (NewUserdefinedArray::DoResolve): Implement.
30161 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30163 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30164 we maintain inside the TypeManager. This is necessary to perform lookups on the
30167 (LookupType): Update to perform GetType on the module builders too.
30169 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30171 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30173 2001-10-23 Ravi Pratap <ravi@ximian.com>
30175 * expression.cs (New::DoResolve): Implement guts of array creation.
30177 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30179 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30181 * expression.cs: Fix bug I introduced lsat night that broke
30184 (Expression.Resolve): Report a 246 error (can not resolve name)
30185 if we find a SimpleName in the stream.
30187 (Expression.ResolveLValue): Ditto.
30189 (Expression.ResolveWithSimpleName): This function is a variant of
30190 ResolveName, this one allows SimpleNames to be returned without a
30191 warning. The only consumer of SimpleNames is MemberAccess
30193 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30195 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30196 might arrive here. I have my doubts that this is correct.
30198 * statement.cs (Lock): Implement lock statement.
30200 * cs-parser.jay: Small fixes to support `lock' and `using'
30202 * cs-tokenizer.cs: Remove extra space
30204 * driver.cs: New flag --checked, allows to turn on integer math
30207 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30208 Threading.Monitor.Exit
30210 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30212 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30213 Expression Class to be IndexerAccess.
30215 Notice that Indexer::DoResolve sets the eclass to Value.
30217 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30219 * class.cs (TypeContainer::Emit): Emit code for indexers.
30221 * assign.cs (IAssignMethod): New interface implemented by Indexers
30222 and Properties for handling assignment.
30224 (Assign::Emit): Simplify and reuse code.
30226 * expression.cs (IndexerAccess, PropertyExpr): Implement
30227 IAssignMethod, clean up old code.
30229 2001-10-22 Ravi Pratap <ravi@ximian.com>
30231 * typemanager.cs (ImplementsInterface): New method to determine if a type
30232 implements a given interface. Provides a nice cache too.
30234 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30237 (ConvertReferenceExplicit): Ditto.
30239 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30240 various methods, with correct names etc.
30242 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30243 Operator.UnaryNegation.
30245 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30246 we have a unary plus or minus operator.
30248 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30251 * everywhere : update accordingly.
30253 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30256 * class.cs (Method::Define): For the case where we are implementing a method
30257 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30258 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30260 2001-10-21 Ravi Pratap <ravi@ximian.com>
30262 * interface.cs (FindMembers): Implement to work around S.R.E
30265 * typemanager.cs (IsInterfaceType): Implement.
30267 (FindMembers): Update to handle interface types too.
30269 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30270 use IsAssignableFrom as that is not correct - it doesn't work.
30272 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30273 and accordingly override EmitStatement.
30275 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30276 using the correct logic :-)
30278 2001-10-19 Ravi Pratap <ravi@ximian.com>
30280 * ../errors/cs-11.cs : Add to demonstrate error -11
30282 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30284 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30285 then pass this as a hint to ResolveLValue.
30287 * expression.cs (FieldExpr): Add Location information
30289 (FieldExpr::LValueResolve): Report assignment to readonly
30292 (Expression::ExprClassFromMemberInfo): Pass location information.
30294 (Expression::ResolveLValue): Add new method that resolves an
30297 (Expression::DoResolveLValue): Default invocation calls
30300 (Indexers): New class used to keep track of indexers in a given
30303 (IStackStore): Renamed from LValue, as it did not really describe
30304 what this did. Also ResolveLValue is gone from this interface and
30305 now is part of Expression.
30307 (ElementAccess): Depending on the element access type
30309 * typemanager.cs: Add `indexer_name_type' as a Core type
30310 (System.Runtime.CompilerServices.IndexerNameAttribute)
30312 * statement.cs (Goto): Take a location.
30314 2001-10-18 Ravi Pratap <ravi@ximian.com>
30316 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30317 if two delegates are compatible.
30319 (NewDelegate::DoResolve): Update to take care of the case when
30320 we instantiate a delegate from another delegate.
30322 * typemanager.cs (FindMembers): Don't even try to look up members
30323 of Delegate types for now.
30325 2001-10-18 Ravi Pratap <ravi@ximian.com>
30327 * delegate.cs (NewDelegate): New class to take care of delegate
30330 * expression.cs (New): Split the delegate related code out into
30331 the NewDelegate class.
30333 * delegate.cs (DelegateInvocation): New class to handle delegate
30336 * expression.cs (Invocation): Split out delegate related code into
30337 the DelegateInvocation class.
30339 2001-10-17 Ravi Pratap <ravi@ximian.com>
30341 * expression.cs (New::DoResolve): Implement delegate creation fully
30342 and according to the spec.
30344 (New::DoEmit): Update to handle delegates differently.
30346 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30347 because of which we were printing out arguments in reverse order !
30349 * delegate.cs (VerifyMethod): Implement to check if the given method
30350 matches the delegate.
30352 (FullDelegateDesc): Implement.
30354 (VerifyApplicability): Implement.
30356 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30357 delegate invocations too.
30359 (Invocation::Emit): Ditto.
30361 * ../errors/cs1593.cs : Added.
30363 * ../errors/cs1594.cs : Added.
30365 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30367 2001-10-16 Ravi Pratap <ravi@ximian.com>
30369 * typemanager.cs (intptr_type): Core type for System.IntPtr
30371 (InitCoreTypes): Update for the same.
30373 (iasyncresult_type, asynccallback_type): Ditto.
30375 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30378 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30381 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30382 the builders for the 4 members of a delegate type :-)
30384 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30387 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30389 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30391 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30393 * statement.cs (Break::Emit): Implement.
30394 (Continue::Emit): Implement.
30396 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30397 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30398 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30399 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30402 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30403 properties that track the label for the current loop (begin of the
30404 loop and end of the loop).
30406 2001-10-15 Ravi Pratap <ravi@ximian.com>
30408 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30409 use of emitting anything at all.
30411 * class.cs, rootcontext.cs : Get rid of calls to the same.
30413 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30415 (Populate): Define the constructor correctly and set the implementation
30418 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30421 (AddDelegateType): Implement.
30423 (IsDelegateType): Implement helper method.
30425 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30427 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30428 and accordingly handle it.
30430 * delegate.cs (Populate): Take TypeContainer argument.
30431 Implement bits to define the Invoke method. However, I still haven't figured out
30432 how to take care of the native int bit :-(
30434 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30435 Qualify the name of the delegate, not its return type !
30437 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30440 (StandardConversionExists): Checking for array types turns out to be recursive.
30442 (ConvertReferenceExplicit): Implement array conversion.
30444 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30446 2001-10-12 Ravi Pratap <ravi@ximian.com>
30448 * cs-parser.jay (delegate_declaration): Store the fully qualified
30449 name as it is a type declaration.
30451 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30454 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30455 as TypeContainer::DefineType.
30457 (Populate): Method in which all the definition of the various methods (Invoke)
30460 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30463 (CloseDelegate): Finally creates the delegate.
30465 * class.cs (TypeContainer::DefineType): Update to define delegates.
30466 (Populate, Emit and CloseType): Do the same thing here too.
30468 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30469 delegates in all these operations.
30471 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30473 * expression.cs: LocalTemporary: a new expression used to
30474 reference a temporary that has been created.
30476 * assign.cs: Handle PropertyAccess back here, so that we can
30477 provide the proper semantic access to properties.
30479 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30480 a few more explicit conversions.
30482 * modifiers.cs: `NEW' modifier maps to HideBySig.
30484 * expression.cs (PropertyExpr): Make this into an
30485 ExpressionStatement, and support the EmitStatement code path.
30487 Perform get/set error checking, clean up the interface.
30489 * assign.cs: recognize PropertyExprs as targets, and if so, turn
30490 them into toplevel access objects.
30492 2001-10-12 Miguel de Icaza <miguel@ximian.com>
30494 * expression.cs: PropertyExpr::PropertyExpr: use work around the
30497 * typemanager.cs: Keep track here of our PropertyBuilders again to
30498 work around lameness in SRE.
30500 2001-10-11 Miguel de Icaza <miguel@ximian.com>
30502 * expression.cs (LValue::LValueResolve): New method in the
30503 interface, used to perform a second resolution pass for LValues.
30505 (This::DoResolve): Catch the use of this in static methods.
30507 (This::LValueResolve): Implement.
30509 (This::Store): Remove warning, assigning to `this' in structures
30512 (Invocation::Emit): Deal with invocation of
30513 methods on value types. We need to pass the address to structure
30514 methods rather than the object itself. (The equivalent code to
30515 emit "this" for structures leaves the entire structure on the
30516 stack instead of a pointer to it).
30518 (ParameterReference::DoResolve): Compute the real index for the
30519 argument based on whether the method takes or not a `this' pointer
30520 (ie, the method is static).
30522 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
30523 value types returned from functions when we need to invoke a
30524 method on the sturcture.
30527 2001-10-11 Ravi Pratap <ravi@ximian.com>
30529 * class.cs (TypeContainer::DefineType): Method to actually do the business of
30530 defining the type in the Modulebuilder or Typebuilder. This is to take
30531 care of nested types which need to be defined on the TypeBuilder using
30532 DefineNestedMethod.
30534 (TypeContainer::GetClassBases): Implement. Essentially the code from the
30535 methods in RootContext, only ported to be part of TypeContainer.
30537 (TypeContainer::GetInterfaceOrClass): Ditto.
30539 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
30541 * interface.cs (Interface::DefineInterface): New method. Does exactly
30542 what RootContext.CreateInterface did earlier, only it takes care of nested types
30545 (Interface::GetInterfaces): Move from RootContext here and port.
30547 (Interface::GetInterfaceByName): Same here.
30549 * rootcontext.cs (ResolveTree): Re-write.
30551 (PopulateTypes): Re-write.
30553 * class.cs (TypeContainer::Populate): Populate nested types too.
30554 (TypeContainer::Emit): Emit nested members too.
30556 * typemanager.cs (AddUserType): Do not make use of the FullName property,
30557 instead just use the name argument passed in as it is already fully
30560 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
30561 to TypeContainer mapping to see if a type is user-defined.
30563 * class.cs (TypeContainer::CloseType): Implement.
30565 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
30566 the default constructor.
30568 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
30571 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
30573 * interface.cs (CloseType): Create the type here.
30575 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
30578 Remove all the methods which are now in TypeContainer.
30580 2001-10-10 Ravi Pratap <ravi@ximian.com>
30582 * delegate.cs (Define): Re-write bits to define the delegate
30585 2001-10-10 Miguel de Icaza <miguel@ximian.com>
30587 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
30589 * expression.cs (ImplicitReferenceConversion): handle null as well
30590 as a source to convert to any reference type.
30592 * statement.cs (Return): Perform any implicit conversions to
30593 expected return type.
30595 Validate use of return statement.
30597 * codegen.cs (EmitContext): Pass the expected return type here.
30599 * class.cs (Method, Constructor, Property): Pass expected return
30600 type to EmitContext.
30602 2001-10-09 Miguel de Icaza <miguel@ximian.com>
30604 * expression.cs: Make DoResolve take an EmitContext instead of a
30607 Replaced `l' and `location' for `loc', for consistency.
30609 (Error, Warning): Remove unneeded Tc argument.
30611 * assign.cs, literal.cs, constant.cs: Update to new calling
30614 * codegen.cs: EmitContext now contains a flag indicating whether
30615 code is being generated in a static method or not.
30617 * cs-parser.jay: DecomposeQI, new function that replaces the old
30618 QualifiedIdentifier. Now we always decompose the assembled
30619 strings from qualified_identifier productions into a group of
30622 2001-10-08 Miguel de Icaza <miguel@ximian.com>
30624 * rootcontext.cs: Deal with field-less struct types correctly now
30625 by passing the size option to Define Type.
30627 * class.cs: Removed hack that created one static field.
30629 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30631 * statement.cs: Moved most of the code generation here.
30633 2001-10-09 Ravi Pratap <ravi@ximian.com>
30635 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
30638 (ElementAccess): Remove useless bits for now - keep checks as the spec
30641 2001-10-08 Ravi Pratap <ravi@ximian.com>
30643 * expression.cs (ElementAccess::DoResolve): Remove my crap code
30644 and start performing checks according to the spec.
30646 2001-10-07 Ravi Pratap <ravi@ximian.com>
30648 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
30649 rank_specifiers instead.
30651 (rank_specifiers): Change the order in which the rank specifiers are stored
30653 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
30655 * expression.cs (ElementAccess): Implement the LValue interface too.
30657 2001-10-06 Ravi Pratap <ravi@ximian.com>
30659 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
30660 except that user defined conversions are not included.
30662 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
30663 perform the conversion of the return type, if necessary.
30665 (New::DoResolve): Check whether we are creating an array or an object
30666 and accordingly do the needful.
30668 (New::Emit): Same here.
30670 (New::DoResolve): Implement guts of array creation.
30672 (New::FormLookupType): Helper function.
30674 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30676 * codegen.cs: Removed most of the code generation here, and move the
30677 corresponding code generation bits to the statement classes.
30679 Added support for try/catch/finalize and throw.
30681 * cs-parser.jay: Added support for try/catch/finalize.
30683 * class.cs: Catch static methods having the flags override,
30684 virtual or abstract.
30686 * expression.cs (UserCast): This user cast was not really doing
30687 what it was supposed to do. Which is to be born in fully resolved
30688 state. Parts of the resolution were being performed at Emit time!
30692 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30694 * expression.cs: Implicity convert the result from UserCast.
30696 2001-10-05 Ravi Pratap <ravi@ximian.com>
30698 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
30699 prevented it from working correctly.
30701 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
30702 merely ConvertImplicit.
30704 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30706 * typemanager.cs: Make the LookupTypeContainer function static,
30707 and not per-instance.
30709 * class.cs: Make static FindMembers (the one that takes a Type
30712 * codegen.cs: Add EmitForeach here.
30714 * cs-parser.jay: Make foreach a toplevel object instead of the
30715 inline expansion, as we need to perform semantic analysis on it.
30717 2001-10-05 Ravi Pratap <ravi@ximian.com>
30719 * expression.cs (Expression::ImplicitUserConversion): Rename to
30720 UserDefinedConversion.
30722 (Expression::UserDefinedConversion): Take an extra argument specifying
30723 whether we look for explicit user conversions too.
30725 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
30727 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
30729 (ExplicitUserConversion): Make it a call to UserDefinedConversion
30730 with the appropriate arguments.
30732 * cs-parser.jay (cast_expression): Record location too.
30734 * expression.cs (Cast): Record location info.
30736 (Expression::ConvertExplicit): Take location argument.
30738 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
30739 to determine if we are doing explicit conversions.
30741 (UserCast::Emit): Update accordingly.
30743 (Expression::ConvertExplicit): Report an error if everything fails.
30745 * ../errors/cs0030.cs : Add.
30747 2001-10-04 Miguel de Icaza <miguel@ximian.com>
30749 * modifiers.cs: If the ABSTRACT keyword is present, also set the
30750 virtual and newslot bits.
30752 * class.cs (TypeContainer::RegisterRequiredImplementations):
30753 Record methods we need.
30755 (TypeContainer::MakeKey): Helper function to make keys for
30756 MethodBases, since the Methodbase key is useless.
30758 (TypeContainer::Populate): Call RegisterRequiredImplementations
30759 before defining the methods.
30761 Create a mapping for method_builders_to_methods ahead of time
30762 instead of inside a tight loop.
30764 (::RequireMethods): Accept an object as the data to set into the
30765 hashtable so we can report interface vs abstract method mismatch.
30767 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30769 * report.cs: Make all of it static.
30771 * rootcontext.cs: Drop object_type and value_type computations, as
30772 we have those in the TypeManager anyways.
30774 Drop report instance variable too, now it is a global.
30776 * driver.cs: Use try/catch on command line handling.
30778 Add --probe option to debug the error reporting system with a test
30781 * report.cs: Add support for exiting program when a probe
30782 condition is reached.
30784 2001-10-03 Ravi Pratap <ravi@ximian.com>
30786 * expression.cs (Binary::DoNumericPromotions): Fix the case when
30787 we do a forcible conversion regardless of type, to check if
30788 ForceConversion returns a null.
30790 (Binary::error19): Use location to report error.
30792 (Unary::error23): Use location here too.
30794 * ../errors/cs0019.cs : Check in.
30796 * ../errors/cs0023.cs : Check in.
30798 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
30799 case of a non-null MethodInfo object with a length of 0 !
30801 (Binary::ResolveOperator): Flag error if overload resolution fails to find
30802 an applicable member - according to the spec :-)
30803 Also fix logic to find members in base types.
30805 (Unary::ResolveOperator): Same here.
30807 (Unary::report23): Change name to error23 and make first argument a TypeContainer
30808 as I was getting thoroughly confused between this and error19 :-)
30810 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
30811 (::FindMostEncompassedType): Implement.
30812 (::FindMostEncompassingType): Implement.
30813 (::StandardConversionExists): Implement.
30815 (UserImplicitCast): Re-vamp. We now need info about most specific
30816 source and target types so that we can do the necessary conversions.
30818 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
30819 mathematical union with no duplicates.
30821 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30823 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
30824 in order from base classes to child classes, so that we can in
30825 child classes look up in our parent for method names and
30826 attributes (required for handling abstract, virtual, new, override
30827 constructs: we need to instrospect our base class, and if we dont
30828 populate the classes in order, the introspection might be
30829 incorrect. For example, a method could query its parent before
30830 the parent has any methods and would determine that the parent has
30831 no abstract methods (while it could have had them)).
30833 (RootContext::CreateType): Record the order in which we define the
30836 2001-10-02 Miguel de Icaza <miguel@ximian.com>
30838 * class.cs (TypeContainer::Populate): Also method definitions can
30839 fail now, keep track of this.
30841 (TypeContainer::FindMembers): Implement support for
30842 DeclaredOnly/noDeclaredOnly flag.
30844 (Constructor::Emit) Return the ConstructorBuilder.
30846 (Method::Emit) Return the MethodBuilder.
30847 Check for abstract or virtual methods to be public.
30849 * rootcontext.cs (RootContext::CreateType): Register all the
30850 abstract methods required for the class to be complete and the
30851 interface methods that must be implemented.
30853 * cs-parser.jay: Report error 501 (method requires body if it is
30854 not marked abstract or extern).
30856 * expression.cs (TypeOf::Emit): Implement.
30858 * typemanager.cs: runtime_handle_type, new global type.
30860 * class.cs (Property::Emit): Generate code for properties.
30862 2001-10-02 Ravi Pratap <ravi@ximian.com>
30864 * expression.cs (Unary::ResolveOperator): Find operators on base type
30865 too - we now conform exactly to the spec.
30867 (Binary::ResolveOperator): Same here.
30869 * class.cs (Operator::Define): Fix minor quirk in the tests.
30871 * ../errors/cs0215.cs : Added.
30873 * ../errors/cs0556.cs : Added.
30875 * ../errors/cs0555.cs : Added.
30877 2001-10-01 Miguel de Icaza <miguel@ximian.com>
30879 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
30880 single integer which is really efficient
30882 2001-10-01 Ravi Pratap <ravi@ximian.com>
30884 * expression.cs (Expression::ImplicitUserConversion): Use location
30885 even in the case when we are examining True operators.
30887 * class.cs (Operator::Define): Perform extensive checks to conform
30888 with the rules for operator overloading in the spec.
30890 * expression.cs (Expression::ImplicitReferenceConversion): Implement
30891 some of the other conversions mentioned in the spec.
30893 * typemanager.cs (array_type): New static member for the System.Array built-in
30896 (cloneable_interface): For System.ICloneable interface.
30898 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
30899 we start resolving the tree and populating types.
30901 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
30903 2001-10-01 Miguel de Icaza <miguel@ximian.com>
30905 * expression.cs (Expression::ExprClassFromMemberInfo,
30906 Expression::Literalize): Create literal expressions from
30907 FieldInfos which are literals.
30909 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
30910 type casts, because they were wrong. The test suite in tests
30913 (ImplicitNumericConversion): ushort to ulong requires a widening
30916 Int32 constant to long requires widening cast as well.
30918 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
30919 for integers because the type on the stack is not i4.
30921 2001-09-30 Miguel de Icaza <miguel@ximian.com>
30923 * expression.cs (report118): require location argument.
30925 * parameter.cs: Do not dereference potential null value.
30927 * class.cs: Catch methods that lack the `new' keyword when
30928 overriding a name. Report warnings when `new' is used without
30929 anything being there to override.
30931 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
30933 * class.cs: Only add constructor to hashtable if it is non-null
30934 (as now constructors can fail on define).
30936 (TypeManager, Class, Struct): Take location arguments.
30938 Catch field instance initialization in structs as errors.
30940 accepting_filter: a new filter for FindMembers that is static so
30941 that we dont create an instance per invocation.
30943 (Constructor::Define): Catch errors where a struct constructor is
30946 * cs-parser.jay: Pass location information for various new
30949 * delegate.cs (Delegate): take a location argument.
30951 * driver.cs: Do not call EmitCode if there were problesm in the
30952 Definition of the types, as many Builders wont be there.
30954 * decl.cs (Decl::Decl): Require a location argument.
30956 * cs-tokenizer.cs: Handle properly hex constants that can not fit
30957 into integers, and find the most appropiate integer for it.
30959 * literal.cs: Implement ULongLiteral.
30961 * rootcontext.cs: Provide better information about the location of
30962 failure when CreateType fails.
30964 2001-09-29 Miguel de Icaza <miguel@ximian.com>
30966 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
30969 * expression.cs (Binary::CheckShiftArguments): Add missing type
30971 (Binary::ResolveOperator): Add type to the logical and and logical
30972 or, Bitwise And/Or and Exclusive Or code paths, it was missing
30975 (Binary::DoNumericPromotions): In the case where either argument
30976 is ulong (and most signed types combined with ulong cause an
30977 error) perform implicit integer constant conversions as well.
30979 2001-09-28 Miguel de Icaza <miguel@ximian.com>
30981 * expression.cs (UserImplicitCast): Method should always be
30983 (Invocation::BetterConversion): Simplified test for IntLiteral.
30985 (Expression::ImplicitNumericConversion): Split this routine out.
30986 Put the code that performs implicit constant integer conversions
30989 (Expression::Resolve): Become a wrapper around DoResolve so we can
30990 check eclass and type being set after resolve.
30992 (Invocation::Badness): Remove this dead function
30994 (Binary::ResolveOperator): Do not compute the expensive argumnets
30995 unless we have a union for it.
30997 (Probe::Emit): Is needs to do an isinst and then
30998 compare against null.
31000 (::CanConvert): Added Location argument. If the Location argument
31001 is null (Location.Null), then we do not report errors. This is
31002 used by the `probe' mechanism of the Explicit conversion. We do
31003 not want to generate an error for something that the user
31004 explicitly requested to be casted. But the pipeline for an
31005 explicit cast first tests for potential implicit casts.
31007 So for now, if the Location is null, it means `Probe only' to
31008 avoid adding another argument. Might have to revise this
31011 (ClassCast): New class used to type cast objects into arbitrary
31012 classes (used in Explicit Reference Conversions).
31014 Implement `as' as well.
31016 Reverted all the patches from Ravi below: they were broken:
31018 * The use of `level' as a mechanism to stop recursive
31019 invocations is wrong. That was there just to catch the
31020 bug with a strack trace but not as a way of addressing
31023 To fix the problem we have to *understand* what is going
31024 on and the interactions and come up with a plan, not
31025 just get things going.
31027 * The use of the type conversion cache that I proposed
31028 last night had an open topic: How does this work across
31029 protection domains. A user defined conversion might not
31030 be public in the location where we are applying the
31031 conversion, a different conversion might be selected
31032 (ie, private A->B (better) but public B->A (worse),
31033 inside A, A->B applies, but outside it, B->A will
31036 * On top of that (ie, even if the above is solved),
31037 conversions in a cache need to be abstract. Ie, `To
31038 convert from an Int to a Short use an OpcodeCast', not
31039 `To convert from an Int to a Short use the OpcodeCast on
31040 the variable 5' (which is what this patch was doing).
31042 2001-09-28 Ravi Pratap <ravi@ximian.com>
31044 * expression.cs (Invocation::ConversionExists): Re-write to use
31045 the conversion cache
31047 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31048 cache all conversions done, not just user-defined ones.
31050 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31051 to determine if a conversion exists instead of acutually trying to
31052 perform the conversion. It's faster too.
31054 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31055 and only then attempt the implicit conversion.
31057 2001-09-28 Ravi Pratap <ravi@ximian.com>
31059 * expression.cs (ConvertImplicit): Use a cache for conversions
31060 already found. Check level of recursion and bail out if necessary.
31062 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31064 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31065 Export standard methods that we expect for string operations.
31067 * statement.cs (Block::UsageWarning): Track usage of variables and
31068 report the errors for not used variables.
31070 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31073 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31075 * codegen.cs: remove unnneded code
31077 * expression.cs: Removed BuiltinTypeAccess class
31079 Fix the order in which implicit conversions are
31082 The previous fixed dropped support for boxed conversions (adding a
31083 test to the test suite now)
31085 (UserImplicitCast::CanConvert): Remove test for source being null,
31086 that code is broken. We should not feed a null to begin with, if
31087 we do, then we should track the bug where the problem originates
31088 and not try to cover it up here.
31090 Return a resolved expression of type UserImplicitCast on success
31091 rather than true/false. Ravi: this is what I was talking about,
31092 the pattern is to use a static method as a "constructor" for
31095 Also, do not create arguments until the very last minute,
31096 otherwise we always create the arguments even for lookups that
31097 will never be performed.
31099 (UserImplicitCast::Resolve): Eliminate, objects of type
31100 UserImplicitCast are born in a fully resolved state.
31102 * typemanager.cs (InitCoreTypes): Init also value_type
31103 (System.ValueType).
31105 * expression.cs (Cast::Resolve): First resolve the child expression.
31107 (LValue): Add new method AddressOf to be used by
31110 Change the argument of Store to take an EmitContext instead of an
31111 ILGenerator, because things like FieldExpr need to be able to call
31112 their children expression to generate the instance code.
31114 (Expression::Error, Expression::Warning): Sugar functions for
31117 (Expression::MemberLookup): Accept a TypeContainer instead of a
31118 Report as the first argument.
31120 (Expression::ResolvePrimary): Killed. I still want to improve
31121 this as currently the code is just not right.
31123 (Expression::ResolveMemberAccess): Simplify, but it is still
31126 (Unary::Resolve): Catch errors in AddressOf operators.
31128 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31129 index to a byte for the short-version, or the compiler will choose
31130 the wrong Emit call, which generates the wrong data.
31132 (ParameterReference::Emit, ::Store): same.
31134 (FieldExpr::AddressOf): Implement.
31136 * typemanager.cs: TypeManager: made public variable instead of
31139 * driver.cs: document --fatal.
31141 * report.cs (ErrorMessage, WarningMessage): new names for the old
31142 Error and Warning classes.
31144 * cs-parser.jay (member_access): Turn built-in access to types
31145 into a normal simplename
31147 2001-09-27 Ravi Pratap <ravi@ximian.com>
31149 * expression.cs (Invocation::BetterConversion): Fix to cope
31150 with q being null, since this was introducing a bug.
31152 * expression.cs (ConvertImplicit): Do built-in conversions first.
31154 2001-09-27 Ravi Pratap <ravi@ximian.com>
31156 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31158 2001-09-27 Ravi Pratap <ravi@ximian.com>
31160 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31161 I had introduced long ago (what's new ?).
31163 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31164 the work of all the checking.
31165 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31166 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31168 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31169 that is the right way.
31171 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31172 overloading resolution. Use everywhere instead of cutting and pasting code.
31174 (Binary::ResolveOperator): Use MakeUnionSet.
31176 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31177 we have to convert to bool types. Not complete yet.
31179 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31181 * typemanager.cs (TypeManager::CSharpName): support ushort.
31183 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31184 to provide an expression that performsn an implicit constant int
31185 conversion (section 6.1.6).
31186 (Expression::ConvertImplicitRequired): Reworked to include
31187 implicit constant expression conversions.
31189 (Expression::ConvertNumericExplicit): Finished.
31191 (Invocation::Emit): If InstanceExpression is null, then it means
31192 that we perform a call on this.
31194 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31196 * expression.cs (Unary::Emit): Remove some dead code.
31197 (Probe): Implement Resolve and Emit for `is'.
31198 (Expression::ConvertImplicitRequired): Attempt to do constant
31199 expression conversions here. Maybe should be moved to
31200 ConvertImplicit, but I am not sure.
31201 (Expression::ImplicitLongConstantConversionPossible,
31202 Expression::ImplicitIntConstantConversionPossible): New functions
31203 that tell whether is it possible to apply an implicit constant
31204 expression conversion.
31206 (ConvertNumericExplicit): Started work on explicit numeric
31209 * cs-parser.jay: Update operator constants.
31211 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31212 (Parameters::GetSignature): Hook up VerifyArgs here.
31213 (Parameters::VerifyArgs): Verifies that no two arguments have the
31216 * class.cs (Operator): Update the operator names to reflect the
31217 ones that the spec expects (as we are just stringizing the
31220 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31221 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31222 previous usage did only work for our methods.
31223 (Expression::ConvertImplicit): Handle decimal implicit numeric
31224 conversions as well.
31225 (Expression::InternalTypeConstructor): Used to invoke constructors
31226 on internal types for default promotions.
31228 (Unary::Emit): Implement special handling for the pre/post
31229 increment/decrement for overloaded operators, as they need to have
31230 the same semantics as the other operators.
31232 (Binary::ResolveOperator): ditto.
31233 (Invocation::ConversionExists): ditto.
31234 (UserImplicitCast::Resolve): ditto.
31236 2001-09-26 Ravi Pratap <ravi@ximian.com>
31238 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31239 operator, return after emitting body. Regression tests pass again !
31241 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31242 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31243 (Invocation::OverloadResolve): Ditto.
31244 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31246 * everywhere : update calls to the above methods accordingly.
31248 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31250 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31252 * expression.cs (ExpressionStatement): New base class used for
31253 expressions that can appear in statements, so that we can provide
31254 an alternate path to generate expression that do not leave a value
31257 (Expression::Emit, and all the derivatives): We no longer return
31258 whether a value is left on the stack or not. Every expression
31259 after being emitted leaves a single value on the stack.
31261 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31262 facilties of ExpressionStatement if possible.
31264 * cs-parser.jay: Update statement_expression.
31266 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31268 * driver.cs: Change the wording of message
31270 2001-09-25 Ravi Pratap <ravi@ximian.com>
31272 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31273 the type of the expression to the return type of the method if
31274 we have an overloaded operator match ! The regression tests pass again !
31275 (Unary::ResolveOperator): Ditto.
31277 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31278 to find "op_Implicit", not "implicit" ;-)
31279 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31280 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31282 * everywhere : Correct calls to the above accordingly.
31284 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31285 (ConvertImplicit): Do user-defined conversion if it exists.
31287 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31289 * assign.cs: track location.
31290 (Resolve): Use implicit conversions on assignment.
31292 * literal.cs: Oops. Not good, Emit of short access values should
31293 pass (Bytes) or the wrong argument will be selected.
31295 * expression.cs (Unary::Emit): Emit code for -expr.
31297 (Unary::ResolveOperator): Handle `Substract' for non-constants
31298 (substract from zero from the non-constants).
31299 Deal with Doubles as well.
31301 (Expression::ConvertImplicitRequired): New routine that reports an
31302 error if no implicit conversion exists.
31304 (Invocation::OverloadResolve): Store the converted implicit
31305 expressions if we make them
31307 2001-09-24 Ravi Pratap <ravi@ximian.com>
31309 * class.cs (ConstructorInitializer): Take a Location argument.
31310 (ConstructorBaseInitializer): Same here.
31311 (ConstructorThisInitializer): Same here.
31313 * cs-parser.jay : Update all calls accordingly.
31315 * expression.cs (Unary, Binary, New): Take location argument.
31316 Update accordingly everywhere.
31318 * cs-parser.jay : Update all calls to the above to take a location
31321 * class.cs : Ditto.
31323 2001-09-24 Ravi Pratap <ravi@ximian.com>
31325 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31326 (Invocation::BetterConversion): Same here
31327 (Invocation::ConversionExists): Ditto.
31329 (Invocation::ConversionExists): Implement.
31331 2001-09-22 Ravi Pratap <ravi@ximian.com>
31333 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31334 Also take an additional TypeContainer argument.
31336 * All over : Pass in TypeContainer as argument to OverloadResolve.
31338 * typemanager.cs (CSharpName): Update to check for the string type and return
31341 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31344 2001-09-21 Ravi Pratap <ravi@ximian.com>
31346 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31347 (Invocation::BetterFunction): Implement.
31348 (Invocation::BetterConversion): Implement.
31349 (Invocation::ConversionExists): Skeleton, no implementation yet.
31351 Okay, things work fine !
31353 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31355 * typemanager.cs: declare and load enum_type, delegate_type and
31358 * expression.cs (Expression::Emit): Now emit returns a value that
31359 tells whether a value is left on the stack or not. This strategy
31360 might be reveted tomorrow with a mechanism that would address
31361 multiple assignments.
31362 (Expression::report118): Utility routine to report mismatches on
31365 (Unary::Report23): Report impossible type/operator combination
31368 (Unary::IsIncrementableNumber): Whether the type can be
31369 incremented or decremented with add.
31370 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31372 (Unary::ResolveOperator): Implement ++, !, ~,
31374 (Invocation::Emit): Deal with new Emit convetion.
31376 * All Expression derivatives: Updated their Emit method to return
31377 whether they leave values on the stack or not.
31379 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31380 stack for expressions that are statements.
31382 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31384 * expression.cs (LValue): New interface. Must be implemented by
31386 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31389 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31390 interface for generating code, simplifies the code.
31392 2001-09-20 Ravi Pratap <ravi@ximian.com>
31394 * expression.cs (everywhere): Comment out return statements in ::Resolve
31395 methods to avoid the warnings.
31397 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31399 * driver.cs (parse): Report error 2001 if we can not open the
31402 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31405 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31408 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31409 otherwise nested blocks end up with the same index.
31411 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31413 * expression.cs: Instead of having FIXMEs in the Resolve
31414 functions, throw exceptions so it is obvious that we are facing a
31417 * cs-parser.jay (invocation_expression): Pass Location information.
31419 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31420 Use a basename for those routines because .NET does not like paths
31423 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31426 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31428 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31429 are loading the correct data types (throws an exception if not).
31430 (TypeManager::InitCoreTypes): Use CoreLookupType
31432 * expression.cs (Unary::ResolveOperator): return the child
31433 expression for expressions which are just +expr.
31434 (Unary::ResolveOperator): Return negative literals for -LITERAL
31435 expressions (otherwise they are Unary {Literal}).
31436 (Invocation::Badness): Take into account `Implicit constant
31437 expression conversions'.
31439 * literal.cs (LongLiteral): Implement long literal class.
31440 (IntLiteral): export the `Value' of the intliteral.
31442 2001-09-19 Ravi Pratap <ravi@ximian.com>
31444 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31446 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31447 instead of 'Operator'
31449 * expression.cs (Binary::ResolveOperator): Update accordingly.
31450 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31453 * cs-parser.jay (unary_expression): Update to use the new names.
31455 * gen-treedump.cs (GetUnary): Same here.
31457 * expression.cs (Unary::Resolve): Implement.
31458 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31459 operators are found instead of making noise ;-)
31460 (Unary::ResolveOperator): New method to do precisely the same thing which
31461 Binary::ResolveOperator does for Binary expressions.
31462 (Unary.method, .Arguments): Add.
31463 (Unary::OperName): Implement.
31464 (Unary::ForceConversion): Copy and Paste !
31466 * class.cs (Operator::Define): Fix a small bug for the case when we have
31469 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31470 for the inbuilt operators. Only overloading works for now ;-)
31472 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31474 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31475 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31477 * expression.cs (This::Emit): Implement.
31478 (This::Resolve): Implement.
31479 (TypeOf:Resolve): Implement.
31480 (Expression::ResolveSimpleName): Add an implicit this to instance
31482 (MemberAccess::Resolve): Deal with Parameters and Fields.
31483 Bind instance variable to Field expressions.
31484 (FieldExpr::Instance): New field used to track the expression that
31485 represents the object instance.
31486 (FieldExpr::Resolve): Track potential errors from MemberLookup not
31488 (FieldExpr::Emit): Implement.
31490 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
31491 the last instruction contains a return opcode to avoid generating
31492 the last `ret' instruction (this generates correct code, and it is
31493 nice to pass the peverify output).
31495 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
31496 initializer for static and instance variables.
31497 (Constructor::Emit): Allow initializer to be null in the case of
31498 static constructors. Only emit initializer for instance
31501 (TypeContainer::FindMembers): Return a null array if there are no
31504 Also fix the code for the MemberTypes.Method branch, as it was not
31505 scanning that for operators (or tried to access null variables before).
31507 * assign.cs (Assign::Emit): Handle instance and static fields.
31511 * driver.cs: Stop compilation if there are parse errors.
31513 * cs-parser.jay (constructor_declaration): Provide default base
31514 initializer for non-static constructors.
31515 (constructor_declarator): Do not provide a default base
31516 initializers if none was specified.
31517 Catch the fact that constructors should not have parameters.
31519 * class.cs: Do not emit parent class initializers for static
31520 constructors, that should be flagged as an error.
31522 2001-09-18 Ravi Pratap <ravi@ximian.com>
31524 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
31525 Move back code into TypeContainer::Populate.
31527 2001-09-18 Ravi Pratap <ravi@ximian.com>
31529 * class.cs (TypeContainer::AddConstructor): Fix the check to
31530 compare against Name, not Basename.
31531 (Operator::OpType): Change Plus and Minus to Add and Subtract.
31533 * cs-parser.jay : Update accordingly.
31535 * class.cs (TypeContainer::FindMembers): For the case where we are searching
31536 for methods, don't forget to look into the operators too.
31537 (RegisterMethodBuilder): Helper method to take care of this for
31538 methods, constructors and operators.
31539 (Operator::Define): Completely revamp.
31540 (Operator.OperatorMethod, MethodName): New fields.
31541 (TypeContainer::Populate): Move the registering of builders into
31542 RegisterMethodBuilder.
31543 (Operator::Emit): Re-write.
31545 * expression.cs (Binary::Emit): Comment out code path to emit method
31546 invocation stuff for the case when we have a user defined operator. I am
31547 just not able to get it right !
31549 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31551 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
31554 (Expression::MemberLookup): Provide a version that allows to
31555 specify the MemberTypes and BindingFlags.
31557 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
31558 so it was not fetching variable information from outer blocks.
31560 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
31561 Beforefieldinit as it was buggy.
31563 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
31564 that Ravi put here.
31566 * class.cs (Constructor::Emit): Only emit if block is not null.
31567 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
31568 deal with this by semantically definining it as if the user had
31571 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
31572 constructors as we now "emit" them at a higher level.
31574 (TypeContainer::DefineDefaultConstructor): Used to define the
31575 default constructors if none was provided.
31577 (ConstructorInitializer): Add methods Resolve and Emit.
31579 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
31581 2001-09-17 Ravi Pratap <ravi@ximian.com>
31583 * class.cs (TypeContainer::EmitDefaultConstructor): Register
31584 the default constructor builder with our hashtable for methodbuilders
31587 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
31588 and argument_count is 0 in which case we have a match.
31589 (Binary::ResolveOperator): More null checking and miscellaneous coding
31592 2001-09-17 Ravi Pratap <ravi@ximian.com>
31594 * rootcontext.cs (IsNameSpace): Compare against null.
31596 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
31598 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
31599 and Unary::Operator.
31601 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
31604 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
31605 we have overloaded operators.
31606 (Binary::ResolveOperator): Implement the part which does the operator overload
31609 * class.cs (Operator::Emit): Implement.
31610 (TypeContainer::Emit): Emit the operators we have too.
31612 * expression.cs (Binary::Emit): Update to emit the appropriate code for
31613 the case when we have a user-defined operator.
31615 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31617 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
31619 2001-09-16 Ravi Pratap <ravi@ximian.com>
31621 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
31622 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
31623 (Constructor::Emit): Implement.
31624 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
31625 if we have no work to do.
31626 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
31629 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
31630 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
31632 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
31635 2001-09-15 Ravi Pratap <ravi@ximian.com>
31637 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
31639 (Tree::RecordNamespace): Method to do what the name says ;-)
31640 (Tree::Namespaces): Property to get at the namespaces hashtable.
31642 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
31645 * rootcontext.cs (IsNamespace): Fixed it :-)
31647 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31649 * class.cs (TypeContainer::FindMembers): Add support for
31651 (MethodCore): New class that encapsulates both the shared aspects
31652 of a Constructor and a Method.
31653 (Method, Constructor): Factored pieces into MethodCore.
31655 * driver.cs: Added --fatal which makes errors throw exceptions.
31656 Load System assembly as well as part of the standard library.
31658 * report.cs: Allow throwing exceptions on errors for debugging.
31660 * modifiers.cs: Do not use `parent', instead use the real type
31661 container to evaluate permission settings.
31663 * class.cs: Put Ravi's patch back in. He is right, and we will
31664 have to cope with the
31666 2001-09-14 Ravi Pratap <ravi@ximian.com>
31668 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
31669 FamORAssem, not FamANDAssem.
31671 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31673 * driver.cs: Added --parse option that only parses its input files
31676 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
31677 incorrect. IsTopLevel is not used to tell whether an object is
31678 root_types or not (that can be achieved by testing this ==
31679 root_types). But to see if this is a top-level *class* (not
31680 necessarly our "toplevel" container).
31682 2001-09-14 Ravi Pratap <ravi@ximian.com>
31684 * enum.cs (Enum::Define): Modify to call the Lookup method on the
31685 parent instead of a direct call to GetType.
31687 2001-09-14 Ravi Pratap <ravi@ximian.com>
31689 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
31690 Modifiers.TypeAttr. This should just be a call to that method.
31692 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
31693 object so that we can determine if we are top-level or not.
31695 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
31698 * enum.cs (Enum::Define): Ditto.
31700 * modifiers.cs (FieldAttr): Re-write.
31702 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
31703 (TypeContainer::HaveStaticConstructor): New property to provide access
31704 to precisely that info.
31706 * modifiers.cs (MethodAttr): Re-write.
31707 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
31709 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
31710 of top-level types as claimed.
31712 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31714 * expression.cs (MemberLookup): Fruitless attempt to lookup
31715 constructors. Maybe I need to emit default constructors? That
31716 might be it (currently .NET emits this for me automatically).
31717 (Invocation::OverloadResolve): Cope with Arguments == null.
31718 (Invocation::EmitArguments): new function, shared by the new
31719 constructor and us.
31720 (Invocation::Emit): Handle static and instance methods. Emit
31721 proper call instruction for virtual or non-virtual invocations.
31722 (New::Emit): Implement.
31723 (New::Resolve): Implement.
31724 (MemberAccess:Resolve): Implement.
31725 (MethodGroupExpr::InstanceExpression): used conforming to the spec
31726 to track instances.
31727 (FieldExpr::Resolve): Set type.
31729 * support.cs: Handle empty arguments.
31731 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
31732 SimpleLookup): Auxiliary routines to help parse a qualifier
31735 Update qualifier_identifier rule.
31737 * codegen.cs: Removed debugging messages.
31739 * class.cs: Make this a global thing, this acts just as a "key" to
31740 objects that we might have around.
31742 (Populate): Only initialize method_builders_to_methods once.
31744 * expression.cs (PropertyExpr): Initialize type from the
31747 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
31748 Resolve pattern. Attempt to implicitly convert value to boolean.
31751 * expression.cs: Set the type for the int32/int32 argument case.
31752 (Binary::ResolveOperator): Set the return type to boolean for
31753 comparission operators
31755 * typemanager.cs: Remove debugging print code.
31757 (Invocation::Resolve): resolve type.
31759 * class.cs: Allocate a MemberInfo of the correct size, as the code
31760 elsewhere depends on the test to reflect the correct contents.
31762 (Method::) Keep track of parameters, due to System.Reflection holes
31764 (TypeContainer::Populate): Keep track of MethodBuilders to Method
31767 (TypeContainer::FindMembers): Use ArrayList and then copy an array
31768 of the exact size and return that.
31770 (Class::LookupMethodByBuilder): New function that maps
31771 MethodBuilders to its methods. Required to locate the information
31772 on methods because System.Reflection bit us again.
31774 * support.cs: New file, contains an interface ParameterData and
31775 two implementations: ReflectionParameters and InternalParameters
31776 used to access Parameter information. We will need to grow this
31779 * expression.cs (Invocation::GetParameterData): implement a cache
31780 and a wrapper around the ParameterData creation for methods.
31781 (Invocation::OverloadResolve): Use new code.
31783 2001-09-13 Ravi Pratap <ravi@ximian.com>
31785 * class.cs (TypeContainer::EmitField): Remove and move into
31786 (Field::Define): here and modify accordingly.
31787 (Field.FieldBuilder): New member.
31788 (TypeContainer::Populate): Update accordingly.
31789 (TypeContainer::FindMembers): Implement.
31791 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31793 * statement.cs: (VariableInfo::VariableType): New field to be
31794 initialized with the full type once it is resolved.
31796 2001-09-12 Miguel de Icaza <miguel@ximian.com>
31798 * parameter.cs (GetParameterInfo): Use a type cache to compute
31799 things only once, and to reuse this information
31801 * expression.cs (LocalVariableReference::Emit): Implement.
31802 (OpcodeCast::Emit): fix.
31804 (ParameterReference::Resolve): Implement.
31805 (ParameterReference::Emit): Implement.
31807 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
31808 that are expressions need to stay as Expressions.
31810 * typemanager.cs (CSharpName): Returns the C# name of a type if
31813 * expression.cs (Expression::ConvertImplicit): New function that
31814 implements implicit type conversions.
31816 (Expression::ImplicitReferenceConversion): Implements implicit
31817 reference conversions.
31819 (EmptyCast): New type for transparent casts.
31821 (OpcodeCast): New type for casts of types that are performed with
31822 a sequence of bytecodes.
31824 (BoxedCast): New type used for casting value types into reference
31825 types. Emits a box opcode.
31827 (Binary::DoNumericPromotions): Implements numeric promotions of
31828 and computation of the Binary::Type.
31830 (Binary::EmitBranchable): Optimization.
31832 (Binary::Emit): Implement code emission for expressions.
31834 * typemanager.cs (TypeManager): Added two new core types: sbyte
31837 2001-09-12 Ravi Pratap <ravi@ximian.com>
31839 * class.cs (TypeContainer::FindMembers): Method which does exactly
31840 what Type.FindMembers does, only we don't have to use reflection. No
31841 implementation yet.
31843 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
31844 typecontainer objects as we need to get at them.
31845 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
31847 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
31848 typecontainer object.
31850 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
31851 of just a Report object.
31853 2001-09-11 Ravi Pratap <ravi@ximian.com>
31855 * class.cs (Event::Define): Go back to using the prefixes "add_" and
31857 (TypeContainer::Populate): Now define the delegates of the type too.
31858 (TypeContainer.Delegates): Property to access the list of delegates defined
31861 * delegates.cs (Delegate::Define): Implement partially.
31863 * modifiers.cs (TypeAttr): Handle more flags.
31865 2001-09-11 Ravi Pratap <ravi@ximian.com>
31867 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
31869 (Operator::Define): Re-write logic to get types by using the LookupType method
31870 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
31871 (Indexer::Define): Ditto.
31872 (Event::Define): Ditto.
31873 (Property::Define): Ditto.
31875 2001-09-10 Ravi Pratap <ravi@ximian.com>
31877 * class.cs (TypeContainer::Populate): Now define operators too.
31878 (TypeContainer.Operators): New property to access the list of operators
31880 (Operator.OperatorMethodBuilder): New member to hold the method builder
31881 for the operator we are defining.
31882 (Operator::Define): Implement.
31884 2001-09-10 Ravi Pratap <ravi@ximian.com>
31886 * class.cs (Event::Define): Make the prefixes of the accessor methods
31887 addOn_ and removeOn_
31889 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
31890 of the location being passed in too. Ideally, this should go later since all
31891 error reporting should be done through the Report object.
31893 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
31894 (Populate): Iterate thru the indexers we have and define them too.
31895 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
31896 for the get and set accessors.
31897 (Indexer::Define): Implement.
31899 2001-09-09 Miguel de Icaza <miguel@ximian.com>
31901 * expression.cs (Binary::Resolve): Beginning of it. I scratched
31902 my previous implementation, did not work.
31904 * typemanager.cs: Add a couple of missing types (the longs).
31906 * literal.cs: Use TypeManager.bool_type instead of getting it.
31908 * expression.cs (EventExpr): New kind of expressions.
31909 (Expressio::ExprClassFromMemberInfo): finish
31911 2001-09-08 Miguel de Icaza <miguel@ximian.com>
31913 * assign.cs: Emit stores to static fields differently.
31915 2001-09-08 Ravi Pratap <ravi@ximian.com>
31917 * Merge in changes and adjust code to tackle conflicts. Backed out my
31918 code in Assign::Resolve ;-)
31920 2001-09-08 Ravi Pratap <ravi@ximian.com>
31922 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
31923 instead Report.Error and also pass in the location.
31924 (CSharpParser::Lexer): New readonly property to return the reference
31925 to the Tokenizer object.
31926 (declare_local_variables): Use Report.Error with location instead of plain
31930 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
31931 (Operator.CheckBinaryOperator): Ditto.
31933 * cs-parser.jay (operator_declarator): Update accordingly.
31935 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
31936 (CheckBinaryOperator): Same here.
31938 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
31939 on the name without any prefixes of namespace names etc. This is because we
31940 already might have something already fully qualified like
31941 'System.Console.WriteLine'
31943 * assign.cs (Resolve): Begin implementation. Stuck ;-)
31945 2001-09-07 Ravi Pratap <ravi@ximian.com>
31947 * cs-tokenizer.cs (location): Return a string which also contains
31950 * expression.cs (ElementAccess): New class for expressions of the
31951 type 'element access.'
31952 (BaseAccess): New class for expressions of the type 'base access.'
31953 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
31956 * cs-parser.jay (element_access): Implement action.
31957 (base_access): Implement actions.
31958 (checked_expression, unchecked_expression): Implement.
31960 * cs-parser.jay (local_variable_type): Correct and implement.
31961 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
31963 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
31965 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
31966 name and the specifiers.
31968 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
31970 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
31971 making them all public ;-)
31973 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
31976 2001-09-07 Miguel de Icaza <miguel@ximian.com>
31978 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
31980 (FieldExpr, PropertyExprs): New resolved expressions.
31981 (SimpleName::MemberStaticCheck): Perform static checks for access
31982 to non-static fields on static methods. Maybe this should be
31983 generalized for MemberAccesses.
31984 (SimpleName::ResolveSimpleName): More work on simple name
31987 * cs-parser.jay (primary_expression/qualified_identifier): track
31988 the parameter index.
31990 * codegen.cs (CodeGen::Save): Catch save exception, report error.
31991 (EmitContext::EmitBoolExpression): Chain to expression generation
31992 instead of temporary hack.
31993 (::EmitStatementExpression): Put generic expression code generation.
31995 * assign.cs (Assign::Emit): Implement variable assignments to
31996 local variables, parameters and fields.
31998 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32000 * statement.cs (Block::GetVariableInfo): New method, returns the
32001 VariableInfo for a variable name in a block.
32002 (Block::GetVariableType): Implement in terms of GetVariableInfo
32004 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32005 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32007 2001-09-06 Ravi Pratap <ravi@ximian.com>
32009 * cs-parser.jay (operator_declaration): Continue on my quest : update
32010 to take attributes argument.
32011 (event_declaration): Ditto.
32012 (enum_declaration): Ditto.
32013 (indexer_declaration): Ditto.
32015 * class.cs (Operator::Operator): Update constructor accordingly.
32016 (Event::Event): Ditto.
32018 * delegate.cs (Delegate::Delegate): Same here.
32020 * enum.cs (Enum::Enum): Same here.
32022 2001-09-05 Ravi Pratap <ravi@ximian.com>
32024 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32026 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32028 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32029 being passed around as an arraylist.
32030 (Attributes::AddAttribute): Method to add attribute sections.
32032 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32033 (struct_declaration): Update accordingly.
32034 (constant_declaration): Update.
32035 (field_declaration): Update.
32036 (method_header): Update.
32037 (fixed_parameter): Update.
32038 (parameter_array): Ditto.
32039 (property_declaration): Ditto.
32040 (destructor_declaration): Ditto.
32042 * class.cs (Struct::Struct): Update constructors accordingly.
32043 (Class::Class): Ditto.
32044 (Field::Field): Ditto.
32045 (Method::Method): Ditto.
32046 (Property::Property): Ditto.
32047 (TypeContainer::OptAttribute): update property's return type.
32049 * interface.cs (Interface.opt_attributes): New member.
32050 (Interface::Interface): Update to take the extra Attributes argument.
32052 * parameter.cs (Parameter::Parameter): Ditto.
32054 * constant.cs (Constant::Constant): Ditto.
32056 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32057 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32058 the attributes as a parameter.
32059 (InterfaceProperty): Update constructor call.
32060 (InterfaceEvent): Ditto.
32061 (InterfaceMethod): Ditto.
32062 (InterfaceIndexer): Ditto.
32064 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32065 pass the attributes too.
32066 (interface_event_declaration): Ditto.
32067 (interface_property_declaration): Ditto.
32068 (interface_method_declaration): Ditto.
32069 (interface_declaration): Ditto.
32071 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32073 * class.cs (Method::Define): Track the "static Main" definition to
32074 create an entry point.
32076 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32077 EntryPoint if we find it.
32079 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32080 (EmitContext::ig): Make this variable public.
32082 * driver.cs: Make the default output file be the first file name
32083 with the .exe extension.
32085 Detect empty compilations
32087 Handle various kinds of output targets. Handle --target and
32088 rename -t to --dumper.
32090 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32091 methods inherited from Expression return now an Expression. This
32092 will is used during the tree rewriting as we resolve them during
32095 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32096 the spec. Missing entirely is the information about
32097 accessability of elements of it.
32099 (Expression::ExprClassFromMemberInfo): New constructor for
32100 Expressions that creates a fully initialized Expression based on
32101 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32104 (Invocation::Resolve): Begin implementing resolution of invocations.
32106 * literal.cs (StringLiteral): Implement Emit.
32108 2001-09-05 Ravi Pratap <ravi@ximian.com>
32110 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32113 2001-09-04 Ravi Pratap <ravi@ximian.com>
32115 * cs-parser.jay (attribute_arguments): Implement actions.
32116 (attribute): Fix bug in production. Implement action.
32117 (attribute_list): Implement.
32118 (attribute_target): Implement.
32119 (attribute_target_specifier, opt_target_specifier): Implement
32120 (CheckAttributeTarget): New method to check if the attribute target
32122 (attribute_section): Implement.
32123 (opt_attributes): Implement.
32125 * attribute.cs : New file to handle attributes.
32126 (Attribute): Class to hold attribute info.
32128 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32129 (attribute_section): Modify production to use 2 different rules to
32130 achieve the same thing. 1 s/r conflict down !
32131 Clean out commented, useless, non-reducing dimension_separator rules.
32133 * class.cs (TypeContainer.attributes): New member to hold list
32134 of attributes for a type.
32135 (Struct::Struct): Modify to take one more argument, the attribute list.
32136 (Class::Class): Ditto.
32137 (Field::Field): Ditto.
32138 (Method::Method): Ditto.
32139 (Property::Property): Ditto.
32141 * cs-parser.jay (struct_declaration): Update constructor call to
32142 pass in the attributes too.
32143 (class_declaration): Ditto.
32144 (constant_declaration): Ditto.
32145 (field_declaration): Ditto.
32146 (method_header): Ditto.
32147 (fixed_parameter): Ditto.
32148 (parameter_array): Ditto.
32149 (property_declaration): Ditto.
32151 * constant.cs (Constant::Constant): Update constructor similarly.
32152 Use System.Collections.
32154 * parameter.cs (Parameter::Parameter): Update as above.
32156 2001-09-02 Ravi Pratap <ravi@ximian.com>
32158 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32159 (TypeContainer.delegates): New member to hold list of delegates.
32161 * cs-parser.jay (delegate_declaration): Implement the action correctly
32162 this time as I seem to be on crack ;-)
32164 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32166 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32167 tell whether an identifier represents a namespace.
32169 * expression.cs (NamespaceExpr): A namespace expression, used only
32170 temporarly during expression resolution.
32171 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32172 utility functions to resolve names on expressions.
32174 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32176 * codegen.cs: Add hook for StatementExpressions.
32178 * class.cs: Fix inverted test for static flag in methods.
32180 2001-09-02 Ravi Pratap <ravi@ximian.com>
32182 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32183 to make it coincide with MS' number.
32184 (Operator::CheckBinaryOperator): Ditto.
32186 * ../errors/errors.txt : Remove error numbers added earlier.
32188 * ../errors/cs1019.cs : Test case for error # 1019
32190 * ../errros/cs1020.cs : Test case for error # 1020
32192 * cs-parser.jay : Clean out commented cruft.
32193 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32194 used anywhere - non-reducing rule.
32195 (namespace_declarations): Non-reducing rule - comment out.
32197 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32198 with TypeContainer::AddEnum.
32200 * delegate.cs : New file for delegate handling classes.
32201 (Delegate): Class for declaring delegates.
32203 * makefile : Update.
32205 * cs-parser.jay (delegate_declaration): Implement.
32207 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32209 * class.cs (Event::Define): Implement.
32210 (Event.EventBuilder): New member.
32212 * class.cs (TypeContainer::Populate): Update to define all enums and events
32214 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32215 readonly fields for all these cases ?
32217 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32219 * class.cs (Property): Revamp to use the convention of making fields readonly.
32220 Accordingly modify code elsewhere.
32222 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32223 the Define method of the Property class.
32225 * class.cs : Clean up applied patch and update references to variables etc. Fix
32227 (TypeContainer::Populate): Update to define all the properties we have. Also
32228 define all enumerations.
32230 * enum.cs (Define): Implement.
32232 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32234 * cs-parser.jay (overloadable_operator): The semantic value is an
32235 enum of the Operator class.
32236 (operator_declarator): Implement actions.
32237 (operator_declaration): Implement.
32239 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32240 validity of definitions.
32241 (Operator::CheckBinaryOperator): Static method to check for binary operators
32242 (TypeContainer::AddOperator): New method to add an operator to a type.
32244 * cs-parser.jay (indexer_declaration): Added line to actually call the
32245 AddIndexer method so it gets added ;-)
32247 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32248 already taken care of by the MS compiler ?
32250 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32252 * class.cs (Operator): New class for operator declarations.
32253 (Operator::OpType): Enum for the various operators.
32255 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32257 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32258 ostensibly handle this in semantic analysis.
32260 * cs-parser.jay (general_catch_clause): Comment out
32261 (specific_catch_clauses, specific_catch_clause): Ditto.
32262 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32263 (catch_args, opt_catch_args): New productions.
32264 (catch_clause): Rewrite to use the new productions above
32265 (catch_clauses): Modify accordingly.
32266 (opt_catch_clauses): New production to use in try_statement
32267 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32268 and re-write the code in the actions to extract the specific and
32269 general catch clauses by being a little smart ;-)
32271 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32272 Hooray, try and catch statements parse fine !
32274 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32276 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32277 string from the hashtable of variables.
32279 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32280 I end up making that mistake ;-)
32281 (catch_clauses): Fixed gross error which made Key and Value of the
32282 DictionaryEntry the same : $1 !!
32284 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32286 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32288 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32289 when the add and remove accessors are specified.
32291 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32293 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32294 information about indexer_declarator.
32295 (indexer_declarator): Implement actions.
32296 (parsing_indexer): New local boolean used to keep track of whether
32297 we are parsing indexers or properties. This is necessary because
32298 implicit_parameters come into picture even for the get accessor in the
32299 case of an indexer.
32300 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32302 * class.cs (Indexer): New class for indexer declarations.
32303 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32304 (TypeContainer::indexers): New member to hold list of indexers for the
32307 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32309 * cs-parser.jay (add_accessor_declaration): Implement action.
32310 (remove_accessor_declaration): Implement action.
32311 (event_accessors_declaration): Implement
32312 (variable_declarators): swap statements for first rule - trivial.
32314 * class.cs (Event): New class to hold information about event
32316 (TypeContainer::AddEvent): New method to add an event to a type
32317 (TypeContainer::events): New member to hold list of events.
32319 * cs-parser.jay (event_declaration): Implement actions.
32321 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32323 * cs-parser.jay (dim_separators): Implement. Make it a string
32324 concatenating all the commas together, just as they appear.
32325 (opt_dim_separators): Modify accordingly
32326 (rank_specifiers): Update accordingly. Basically do the same
32327 thing - instead, collect the brackets here.
32328 (opt_rank_sepcifiers): Modify accordingly.
32329 (array_type): Modify to actually return the complete type string
32330 instead of ignoring the rank_specifiers.
32331 (expression_list): Implement to collect the expressions
32332 (variable_initializer): Implement. We make it a list of expressions
32333 essentially so that we can handle the array_initializer case neatly too.
32334 (variable_initializer_list): Implement.
32335 (array_initializer): Make it a list of variable_initializers
32336 (opt_array_initializer): Modify accordingly.
32338 * expression.cs (New::NType): Add enumeration to help us
32339 keep track of whether we have an object/delegate creation
32340 or an array creation.
32341 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32342 members to hold data about array creation.
32343 (New:New): Modify to update NewType
32344 (New:New): New Overloaded contructor for the array creation
32347 * cs-parser.jay (array_creation_expression): Implement to call
32348 the overloaded New constructor.
32350 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32352 * class.cs (TypeContainer::Constructors): Return member
32353 constructors instead of returning null.
32355 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32357 * typemanager.cs (InitCoreTypes): Initialize the various core
32358 types after we have populated the type manager with the user
32359 defined types (this distinction will be important later while
32360 compiling corlib.dll)
32362 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32363 on Expression Classification. Now all expressions have a method
32364 `Resolve' and a method `Emit'.
32366 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32367 generation from working. Also add some temporary debugging
32370 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32372 * codegen.cs: Lots of code generation pieces. This is only the
32373 beginning, will continue tomorrow with more touches of polish. We
32374 handle the fundamentals of if, while, do, for, return. Others are
32375 trickier and I need to start working on invocations soon.
32377 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32380 * codegen.cs (EmitContext): New struct, used during code
32381 emission to keep a context. Most of the code generation will be
32384 * cs-parser.jay: Add embedded blocks to the list of statements of
32385 this block. So code generation proceeds in a top down fashion.
32387 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32389 * statement.cs: Add support for multiple child blocks.
32391 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32393 * codegen.cs (EmitCode): New function, will emit the code for a
32394 Block of code given a TypeContainer and its ILGenerator.
32396 * statement.cs (Block): Standard public readonly optimization.
32397 (Block::Block constructors): Link children.
32398 (Block::Child): Child Linker.
32399 (Block::EmitVariables): Emits IL variable declarations.
32401 * class.cs: Drop support for MethodGroups here, delay until
32403 (Method::): Applied the same simplification that I did before, and
32404 move from Properties to public readonly fields.
32405 (Method::ParameterTypes): Returns the parameter types for the
32406 function, and implements a cache that will be useful later when I
32407 do error checking and the semantic analysis on the methods is
32409 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32410 and made a method, optional argument tells whether this is a class
32411 or a structure to apply the `has-this' bit.
32412 (Method::GetCallingConvention): Implement, returns the calling
32414 (Method::Define): Defines the type, a second pass is performed
32415 later to populate the methods.
32417 (Constructor::ParameterTypes): implement a cache similar to the
32418 one on Method::ParameterTypes, useful later when we do semantic
32421 (TypeContainer::EmitMethod): New method. Emits methods.
32423 * expression.cs: Removed MethodGroup class from here.
32425 * parameter.cs (Parameters::GetCallingConvention): new method.
32427 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32429 * class.cs (TypeContainer::Populate): Drop RootContext from the
32432 (Constructor::CallingConvention): Returns the calling convention.
32433 (Constructor::ParameterTypes): Returns the constructor parameter
32436 (TypeContainer::AddConstructor): Keep track of default constructor
32437 and the default static constructor.
32439 (Constructor::) Another class that starts using `public readonly'
32440 instead of properties.
32442 (Constructor::IsDefault): Whether this is a default constructor.
32444 (Field::) use readonly public fields instead of properties also.
32446 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32447 track of static constructors; If none is used, turn on
32448 BeforeFieldInit in the TypeAttributes.
32450 * cs-parser.jay (opt_argument_list): now the return can be null
32451 for the cases where there are no arguments.
32453 (constructor_declarator): If there is no implicit `base' or
32454 `this', then invoke the default parent constructor.
32456 * modifiers.cs (MethodAttr): New static function maps a set of
32457 modifiers flags into a MethodAttributes enum
32458 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32459 MethodAttr, TypeAttr to represent the various mappings where the
32460 modifiers are used.
32461 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32463 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32465 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32468 * interface.cs (PopulateIndexer): Implemented the code generator
32469 for interface indexers.
32471 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32473 * interface.cs (InterfaceMemberBase): Now we track the new status
32476 (PopulateProperty): Implement property population. Woohoo! Got
32477 Methods and Properties going today.
32479 Removed all the properties for interfaces, and replaced them with
32480 `public readonly' fields.
32482 2001-08-16 Miguel de Icaza <miguel@ximian.com>
32484 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
32485 initialize their hashtables/arraylists only when they are needed
32486 instead of doing this always.
32488 * parameter.cs: Handle refs and out parameters.
32490 * cs-parser.jay: Use an ArrayList to construct the arguments
32491 instead of the ParameterCollection, and then cast that to a
32494 * parameter.cs: Drop the use of ParameterCollection and use
32495 instead arrays of Parameters.
32497 (GetParameterInfo): Use the Type, not the Name when resolving
32500 2001-08-13 Miguel de Icaza <miguel@ximian.com>
32502 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
32503 and instead use public readonly fields.
32505 * class.cs: Put back walking code for type containers.
32507 2001-08-11 Miguel de Icaza <miguel@ximian.com>
32509 * class.cs (MakeConstant): Code to define constants.
32511 * rootcontext.cs (LookupType): New function. Used to locate types
32514 2001-08-08 Miguel de Icaza <miguel@ximian.com>
32516 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
32517 this System.Reflection code is. Kudos to Microsoft
32519 * typemanager.cs: Implement a type cache and avoid loading all
32520 types at boot time. Wrap in LookupType the internals. This made
32521 the compiler so much faster. Wow. I rule!
32523 * driver.cs: Make sure we always load mscorlib first (for
32524 debugging purposes, nothing really important).
32526 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
32527 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
32529 * rootcontext.cs: Lookup types on their namespace; Lookup types
32530 on namespaces that have been imported using the `using' keyword.
32532 * class.cs (TypeContainer::TypeAttr): Virtualize.
32533 (Class::TypeAttr): Return attributes suitable for this bad boy.
32534 (Struct::TypeAttr): ditto.
32535 Handle nested classes.
32536 (TypeContainer::) Remove all the type visiting code, it is now
32537 replaced with the rootcontext.cs code
32539 * rootcontext.cs (GetClassBases): Added support for structs.
32541 2001-08-06 Miguel de Icaza <miguel@ximian.com>
32543 * interface.cs, statement.cs, class.cs, parameter.cs,
32544 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
32545 Drop use of TypeRefs, and use strings instead.
32547 2001-08-04 Miguel de Icaza <miguel@ximian.com>
32551 * class.cs (Struct::Struct): set the SEALED flags after
32552 checking the modifiers.
32553 (TypeContainer::TypeAttr): new property, returns the
32554 TypeAttributes for a class.
32556 * cs-parser.jay (type_list): Oops, list production was creating a
32557 new list of base types.
32559 * rootcontext.cs (StdLib): New property.
32560 (GetInterfaceTypeByName): returns an interface by type name, and
32561 encapsulates error handling here.
32562 (GetInterfaces): simplified.
32563 (ResolveTree): Encapsulated all the tree resolution here.
32564 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
32567 * driver.cs: Add support for --nostdlib, to avoid loading the
32568 default assemblies.
32569 (Main): Do not put tree resolution here.
32571 * rootcontext.cs: Beginning of the class resolution.
32573 2001-08-03 Miguel de Icaza <miguel@ximian.com>
32575 * rootcontext.cs: Provide better error reporting.
32577 * cs-parser.jay (interface_base): set our $$ to be interfaces.
32579 * rootcontext.cs (CreateInterface): Handle the case where there
32580 are no parent interfaces.
32582 (CloseTypes): Routine to flush types at the end.
32583 (CreateInterface): Track types.
32584 (GetInterfaces): Returns an array of Types from the list of
32585 defined interfaces.
32587 * typemanager.c (AddUserType): Mechanism to track user types (puts
32588 the type on the global type hash, and allows us to close it at the
32591 2001-08-02 Miguel de Icaza <miguel@ximian.com>
32593 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
32594 RecordInterface instead.
32596 * cs-parser.jay: Updated to reflect changes above.
32598 * decl.cs (Definition): Keep track of the TypeBuilder type that
32599 represents this type here. Not sure we will use it in the long
32600 run, but wont hurt for now.
32602 * driver.cs: Smaller changes to accomodate the new code.
32604 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
32607 * rootcontext.cs (CreateInterface): New method, used to create
32608 the System.TypeBuilder type for interfaces.
32609 (ResolveInterfaces): new entry point to resolve the interface
32611 (CodeGen): Property, used to keep track of the code generator.
32613 2001-07-26 Miguel de Icaza <miguel@ximian.com>
32615 * cs-parser.jay: Add a second production for delegate_declaration
32618 (enum_body): Put an opt_comma here instead of putting it on
32619 enum_body or enum_member_declarations so we can handle trailing
32620 commas on enumeration members. Gets rid of a shift/reduce.
32622 (type_list): Need a COMMA in the middle.
32624 (indexer_declaration): Tell tokenizer to recognize get/set
32626 * Remove old targets.
32628 * Re-add the parser target.
32630 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32632 * cs-parser.jay: Add precendence rules for a number of operators
32633 ot reduce the number of shift/reduce conflicts in the grammar.
32635 2001-07-17 Miguel de Icaza <miguel@ximian.com>
32637 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
32640 Get rid of old crufty code.
32642 * rootcontext.cs: Use this to keep track of the parsed
32643 representation and the defined types available to the program.
32645 * gen-treedump.cs: adjust for new convention.
32647 * type.cs: Split out the type manager, and the assembly builder
32650 * typemanager.cs: the type manager will live here now.
32652 * cil-codegen.cs: And the code generator here.
32654 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
32656 * makefile: Fixed up for easy making.
32658 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32660 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
32663 (unary_expression): Expand pre_increment_expression and
32664 post_decrement_expression to reduce a shift/reduce.
32666 2001-07-11 Simon Cozens
32668 * cs-tokenizer.cs: Hex numbers should begin with a 0.
32670 Improve allow_keyword_as_indent name.
32672 2001-06-19 Miguel de Icaza <miguel@ximian.com>
32674 * Adjustments for Beta2.
32676 2001-06-13 Miguel de Icaza <miguel@ximian.com>
32678 * decl.cs: Added `Define' abstract method.
32679 (InTransit): new property, used to catch recursive definitions.
32681 * interface.cs: Implement `Define'.
32683 * modifiers.cs: Map Modifiers.constants to
32684 System.Reflection.TypeAttribute flags.
32686 * class.cs: Keep track of types and user-defined types.
32687 (BuilderInit): New method for creating an assembly
32688 (ResolveType): New function to launch the resolution process, only
32689 used by interfaces for now.
32691 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
32692 that are inserted into the name space.
32694 2001-06-08 Miguel de Icaza <miguel@ximian.com>
32696 * ARGH. I have screwed up my tree so many times due to the use of
32697 rsync rather than using CVS. Going to fix this at once.
32699 * driver.cs: Objetify driver. Load assemblies, use assemblies to
32702 2001-06-07 Miguel de Icaza <miguel@ximian.com>
32704 * Experiment successful: Use System.Type rather that our own
32707 2001-05-25 Miguel de Icaza <miguel@ximian.com>
32709 * cs-parser.jay: Removed nsAliases from here.
32711 Use new namespaces, handle `using XXX;'
32713 * namespace.cs: Reimplemented namespace handling, use a recursive
32714 definition of the class. Now we can keep track of using clauses
32715 and catch invalid using clauses.
32717 2001-05-24 Miguel de Icaza <miguel@ximian.com>
32719 * gen-treedump.cs: Adapted for all the renaming.
32721 * expression.cs (Expression): this class now has a Type property
32722 which returns an expression Type.
32724 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
32725 `Type', as this has a different meaning now in the base
32727 2001-05-22 Miguel de Icaza <miguel@ximian.com>
32729 * interface.cs, class.cs: Removed from all the sources the
32730 references to signature computation, as we can not do method
32731 signature computation during the parsing time, as we are not
32732 trying to solve at that point distinguishing:
32736 void a (NS.Blah x) {}
32739 Which depending on the context might be valid or not, as we do not
32740 know if Blah is the same thing as NS.Blah at that point.
32742 * Redid everything so the code uses TypeRefs now instead of
32743 Types. TypeRefs are just temporary type placeholders, that need
32744 to be resolved. They initially have a pointer to a string and the
32745 current scope in which they are used. This is used later by the
32746 compiler to resolve the reference to an actual Type.
32748 * DeclSpace is no longer a CIR.Type, and neither are
32749 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
32750 are all DeclSpaces, but no Types.
32752 * type.cs (TypeRefManager): This implements the TypeRef manager,
32753 which keeps track of all the types that need to be resolved after
32754 the parsing has finished.
32756 2001-05-13 Miguel de Icaza <miguel@ximian.com>
32758 * ARGH. We are going to have to store `foreach' as a class rather
32759 than resolving it, as we need to verify error 1579 after name
32760 resolution. *OR* we could keep a flag that says `This request to
32761 IEnumerator comes from a foreach statement' which we can then use
32762 to generate the error.
32764 2001-05-10 Miguel de Icaza <miguel@ximian.com>
32766 * class.cs (TypeContainer.AddMethod): we now add methods to the
32767 MethodGroup instead of the method hashtable.
32769 * expression.cs: Add MethodGroup abstraction, which gets us one
32770 step closer to the specification in the way we handle method
32773 * cs-parser.jay (primary_expression): qualified_identifier now
32774 tried to match up an identifier to a local variable reference or
32775 to a parameter reference.
32777 current_local_parameters is now a parser global variable that
32778 points to the current parameters for the block, used during name
32781 (property_declaration): Now creates an implicit `value' argument to
32784 2001-05-09 Miguel de Icaza <miguel@ximian.com>
32786 * parameter.cs: Do not use `param' arguments as part of the
32787 signature, per the spec.
32789 2001-05-08 Miguel de Icaza <miguel@ximian.com>
32791 * decl.cs: Base class for classes, structs and interfaces. This
32792 is the "Declaration Space"
32794 * cs-parser.jay: Use CheckDef for checking declaration errors
32795 instead of having one on each function.
32797 * class.cs: Factor out some code for handling error handling in
32798 accordance to the "Declarations" section in the "Basic Concepts"
32799 chapter in the ECMA C# spec.
32801 * interface.cs: Make all interface member classes derive from
32802 InterfaceMemberBase.
32804 2001-05-07 Miguel de Icaza <miguel@ximian.com>
32806 * Many things: all interfaces are parsed and generated in
32807 gen-treedump. Support for member variables, constructors,
32808 destructors, properties, constants is there.
32810 Beginning of the IL backend, but very little done, just there for
32813 2001-04-29 Miguel de Icaza <miguel@ximian.com>
32815 * cs-parser.jay: Fix labeled statement.
32817 * cs-tokenizer.cs (escape): Escape " and ' always.
32818 ref_line, ref_name: keep track of the line/filename as instructed
32819 by #line by the compiler.
32822 2001-04-27 Miguel de Icaza <miguel@ximian.com>
32824 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
32825 to match the values in System.CodeDOM.
32827 Divid renamed to Divide.
32829 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
32831 (Statements.set): remove.
32833 * System.CodeDOM/CodeCatchClause.cs: always have a valid
32836 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
32837 falseStatements always have valid values.
32839 * cs-parser.jay: Use System.CodeDOM now.