1 2009-06-05 Jb Evain <jbevain@novell.com>
3 * driver.cs (EmbededResource): avoid using an internal method
4 in gmcs to embed manifest resources.
6 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
8 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
9 the compiler from older mono versions (like moon's bots)
11 2009-06-04 Marek Safar <marek.safar@gmail.com>
13 * namespace.cs (LookupTypeReflection): Ignore collisions between
16 2009-06-04 Marek Safar <marek.safar@gmail.com>
18 * codegen.cs: Enabled generic type forwarders.
20 2009-06-04 Marek Safar <marek.safar@gmail.com>
22 * dmcs.*: Add another version of SRE compiler.
24 2009-06-03 Marek Safar <marek.safar@gmail.com>
26 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
27 generic-mcs.cs: Fixed variant type conversions.
29 2009-06-02 Marek Safar <marek.safar@gmail.com>
32 * codegen.cs: Fixes a crash on invalid string value attribute.
34 2009-06-01 Marek Safar <marek.safar@gmail.com>
37 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
38 cs-parser.jay: Fully import __arglist modifier.
40 2009-05-29 Marek Safar <marek.safar@gmail.com>
42 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
43 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
44 actually work with closed generic types.
46 2009-05-27 Alan McGovern <amcgovern@novell.com>
48 * class.cs, decl.cs, delegate.cs, parameter.cs:
49 Fix the build by replacing the use of 'var' with the actual type.
51 2009-05-27 Marek Safar <marek.safar@gmail.com>
53 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
54 cs-parser.jay, generic-mcs.cs: Report wrong variant types
57 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
60 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
61 Marek Safar <marek.safar@gmail.com>
64 * parameter.cs: Use predefined and not empty name for implicit
67 2009-05-21 Marek Safar <marek.safar@gmail.com>
69 * class.cs: Don't report wrong warnings for event fields.
71 2009-05-21 Marek Safar <marek.safar@gmail.com>
74 * class.cs: Check for static class using parent container instead of
77 2009-05-08 Marek Safar <marek.safar@gmail.com>
80 * expression.cs: Always use temporary variable when using object
83 2009-04-28 Marek Safar <marek.safar@gmail.com>
86 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
89 2009-04-27 Miguel de Icaza <miguel@novell.com>
91 * driver.cs: Add a flag to work as a replacement for CSC in VS.
93 2009-04-24 Miguel de Icaza <miguel@novell.com>
95 * complete.cs: No idea how gonzalo got a null in the list, but
98 2009-04-24 Miguel de Icaza <miguel@novell.com>
100 * complete.cs (CompletionElementInitializer): New completion class
101 to support completing inside a C# 3 element initializer, so this
102 allows completion for Silverlight situations where it is very
105 new TextBlock () { Fo<TAB>
107 (CompletionSimpleName): Expose the prefix that was
108 passed to the simple name.
110 * cs-parser.jay (object_or_collection_initializer): Add support
111 for element_initializers.
113 * expression.cs (CollectionOrObjectInitializers.DoResolve):
114 special case completion expressions as this method aggressively
115 collects data before it operates, and errors were being thrown
116 earlier than we were able to complete.
118 2009-04-23 Miguel de Icaza <miguel@novell.com>
120 * eval.cs: Make getcompletions silent and enable debugging output
121 if the -v option is passed.
123 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
124 Consider looking up the namespace that matches the prefix being
127 This is part of the support for allowing completions like:
128 `System.Co<TAB>' to complete to System.Console.
130 * complete.cs (CompletionSimpleName.AppendResults): Make this
133 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
135 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
136 COMPLETE_COMPLETION as internal.
138 2009-04-17 Miguel de Icaza <miguel@novell.com>
140 * complete.cs: Include namespace resolution in simple names as
141 well as global types and types in the using scope in the
144 * namespace.cs: Supporting infrastrcture to provide completions
145 based on the current using scope.
147 * eval.cs: Introduce an entry point that allows for initialization
148 to return a list of the files passed on the command line.
150 2009-04-14 Marek Safar <marek.safar@gmail.com>
152 A fix for bug #494243
153 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
155 2009-04-13 Marek Safar <marek.safar@gmail.com>
157 A fix for bug #493887
158 * statement.cs: Don't skip string multi-section with default or
159 null label when populating string hashtable.
161 2009-04-06 Marek Safar <marek.safar@gmail.com>
163 A fix for bug #492329
164 * expression.cs (New): Load variable when assigning type parameter
167 2009-04-06 Marek Safar <marek.safar@gmail.com>
169 A fix for bug #488960
170 * decl.cs: Compare MVAR types using non-null values.
172 2009-03-27 Marek Safar <marek.safar@gmail.com>
174 * typemanager.cs, expression.cs: Removed unused nullable checks.
176 2009-03-27 Marek Safar <marek.safar@gmail.com>
178 * *.cs: Removed some gmcs conditionals.
180 2009-03-26 Marek Safar <marek.safar@gmail.com>
182 * generic.cs, support.cs: Moved generics stuff out of support.cs
184 2009-03-24 Marek Safar <marek.safar@gmail.com>
186 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
189 2009-03-23 Marek Safar <marek.safar@gmail.com>
191 * attribute.cs: Consider all members for error reporting when
192 checking named arguments.
194 2009-03-23 Marek Safar <marek.safar@gmail.com>
196 A fix for bug #487625
197 * namespace.cs: Use a warning for all predefined type conflicts.
199 2009-03-23 Marek Safar <marek.safar@gmail.com>
201 A fix for bug #485706
202 * statement.cs: Explicitly type catch type argument to pass verifier
205 2009-03-22 Miguel de Icaza <miguel@novell.com>
207 Initial support to provide code completion facilities to consumers
208 of the evaluator API.
210 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
211 support the completion engine. When we reach the end of the
212 input stream instead of returning EOF, when this flag is true the
213 tokenizer instead produces:
215 One GENERATE_COMPLETION token: this token then must be
216 handled in the grammar at every point where the user
217 would likely request a completion.
219 As many COMPLETE_COMPLETION tokens as necessary. These
220 tokens are generated to assist the parser in unwinding and
221 producing a valid parse tree.
223 The parser rules do not have to be perfect, the parser needs to be
224 augmented with judicious use of GENERATE_COMPLETION tokens to
225 improve the areas where we can provide completion and the parser
226 needs to add support for COMPLETE_COMPLETION tokens in productions
229 It is common to not have enough support for COMPLETE_COMPLETION
230 under certain rules and that even if we generated the
231 GENERATE_COMPLETION token that the resulting tree will be invalid
232 due to the missing rules that support COMPLETE_COMPLETION.
234 The final EOF token is produced by having the parser notify the
235 tokenizer when it reaches the root production that the next token
238 * support.cs (CompletionResult): New Exception. This exception
239 is thrown to return the completion results when one of the special
240 completion expressions is reached.
242 This exception is thrown by the completing ExpressionStatements
243 classes that live in complete.cs
245 * complete.cs (CompletingExpression): a new base class for
246 completing expressions. This derives from the
247 ExpressionStatement class and not from Expression as it allows
248 completion to happen not only where expressions are expected in
249 the grammar, but also where statements are expected.
251 (CompletionSimpleName): A new class used to provide completions
252 for SimpleNames. This currently only resolves to local
253 variables from the evaluator context (GetVars call).
255 (CompletionMemberAccess): Implements support for completing member
258 * cs-parser.jay: Add support for completion in a few places.
260 * eval.cs (GetCompletions): New public API for the evaluator that
261 returns a list of possible completions given the input. The
262 return value is an array of completions
264 * anonymous.cs (Compatible): If the exception thrown from the
265 resolved expression is a CompletionResult exception let that one
266 through instead of printing a diagnostic error in the try/catch.
268 2009-03-22 Miguel de Icaza <miguel@novell.com>
272 * driver.cs (Main): Use Environment.Exit to quit quickly and
273 prevent the compiler from doing the usual wait for helper thread
276 This is to prevent a slowdown that was reported by Gonzalo on
279 2009-03-19 Marek Safar <marek.safar@gmail.com>
281 * ecore.cs: Load build-in types directly instead of accessing
284 2009-03-18 Marek Safar <marek.safar@gmail.com>
286 * ecore.cs: Always use unbox.any when available.
288 2009-03-18 Marek Safar <marek.safar@gmail.com>
290 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
292 2009-03-17 Marek Safar <marek.safar@gmail.com>
294 * generic.cs: Removed obsolete version of type inference.
296 2009-03-16 Marek Safar <marek.safar@gmail.com>
298 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
299 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
300 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
301 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
303 2009-03-11 Marek Safar <marek.safar@gmail.com>
305 A fix for bug #482996
306 * anonymous.cs: Make sure we are not infering return type when
307 checking type compatibility.
309 2009-03-11 Marek Safar <marek.safar@gmail.com>
311 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
312 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
313 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
314 attributes in their own structure. Needed when accessing their
315 properties before they are resolved.
317 2009-03-09 Marek Safar <marek.safar@gmail.com>
319 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
320 hashtable (~10x faster).
322 * driver.cs: Removed wrong Reset.
324 2009-03-08 Marek Safar <marek.safar@gmail.com>
326 * class.cs: Use correct common base type for unmanaged delayed
329 * rootcontext.cs: Wrap unhandled exception.
331 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
333 Make SeekableStreamReader self-tuning and arbitrarily seekable
334 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
336 (SeekableStreamReader.Position.set): Use it. Simplify logic
337 which, as a side-effect, makes it arbitrarily-seekable. Tune the
338 buffer size when the stream needs to be re-read from the beginning.
340 2009-03-05 Marek Safar <marek.safar@gmail.com>
342 A fix for bug #480100
343 * parameter.cs: A parameter is not hoisted when used directly as ET.
345 2009-03-04 Marek Safar <marek.safar@gmail.com>
347 * statement.cs: Fixed an issue when using variable is of interface
350 2009-03-03 Marek Safar <marek.safar@gmail.com>
352 A fix for bug #480319
353 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
355 2009-03-03 Marek Safar <marek.safar@gmail.com>
357 A fix for bug #480867
358 * typemanager.cs, expression.cs, ecore.cs: Changed method group
359 expression to have no valid type.
361 2009-03-03 Marek Safar <marek.safar@gmail.com>
363 A fix for bug #481258
364 * class.cs: Set extension method flag in partial container.
366 2009-03-03 Marek Safar <marek.safar@gmail.com>
368 * statement.cs, typemanager.cs: Use expression for StringEmitter.
370 * attribute.cs: Add sanity check.
372 2009-02-27 Marek Safar <marek.safar@gmail.com>
374 * class.cs: Add external constructor error.
376 2009-02-26 Marek Safar <marek.safar@gmail.com>
378 A fix for bug #475354
379 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
380 correctly user defined nullable equality operators.
382 2009-02-25 Marek Safar <marek.safar@gmail.com>
384 A fix for bug #479532
385 * expression.cs: Implement NewInitialize::AddressOf.
387 2009-02-25 Marek Safar <marek.safar@gmail.com>
389 A fix for bug #413633
390 * expression.cs: Iterate all base class-constraint types.
392 2009-02-24 Marek Safar <marek.safar@gmail.com>
394 A fix for bug #479209
395 * literal.cs: Mutate null underlying type.
397 2009-02-24 Marek Safar <marek.safar@gmail.com>
399 A fix for bug #476295
400 * convert.cs: Avoid wrapping implicitly convertible reference type.
402 2009-02-23 Marek Safar <marek.safar@gmail.com>
404 * iterators.cs: Create MemberName correctly.
406 2009-02-23 Marek Safar <marek.safar@gmail.com>
408 A fix for bug #478655
409 * literal.cs: Check also underlying null type conversion.
411 2009-02-21 Marek Safar <marek.safar@gmail.com>
413 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
415 2009-02-20 Marek Safar <marek.safar@gmail.com>
417 A fix for bug #477447
418 * statement.cs: Add reference to correct parent storey when this
419 is accessible from deep children storey (more than 1 level).
421 2009-02-19 Marek Safar <marek.safar@gmail.com>
423 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
424 * class.cs: Define base type members before setting up member cache.
426 2009-02-18 Marek Safar <marek.safar@gmail.com>
428 A fix for bug #477378
429 * nullable.cs, expression.cs, statement.cs: More precise null type
432 2009-02-18 Marek Safar <marek.safar@gmail.com>
434 A fix for bug #472805
435 * typemanager.cs, namespace.cs: Import only visible extension method
438 2009-02-18 Marek Safar <marek.safar@gmail.com>
440 A fix for bug #476895
441 * attribute.cs: Use correct resolve context for attribute type.
443 2009-02-18 Marek Safar <marek.safar@gmail.com>
445 A fix for bug #476266
446 * anonymous.cs: Mutate multi-dimensional arrays.
448 2009-02-18 Marek Safar <marek.safar@gmail.com>
450 A fix for bug #476400
451 * statement.cs, expression.cs: Removed wrong Dispose optimization.
453 2009-02-18 Marek Safar <marek.safar@gmail.com>
455 A fix for bug #476811
456 * generics.cs: Fixed null-literal check.
458 2009-02-17 Marek Safar <marek.safar@gmail.com>
460 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
461 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
462 messing with static variables.
464 2009-02-16 Marek Safar <marek.safar@gmail.com>
466 A fix for bug #475965
467 * generics.cs: Check generic parameter type after extracting from
470 2009-02-16 Marek Safar <marek.safar@gmail.com>
472 A fix for bug #475823
473 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
476 2009-02-14 Marek Safar <marek.safar@gmail.com>
478 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
479 Simplified event field definition using backing field and not
480 field builder directly.
482 * expression.cs (EmitLdArg): Optimize fast paths.
484 2009-02-13 Marek Safar <marek.safar@gmail.com>
486 A fix for bug #475327
487 * expression.cs (ArrayCreation): Don't mutate values optimized away.
489 2009-02-13 Marek Safar <marek.safar@gmail.com>
491 A fix for bug #475342
492 * cs-parser.jay: Using 'super' instead of 'base' to call base
493 constructor crashes compiler.
495 2009-02-13 Marek Safar <marek.safar@gmail.com>
497 A fix for bug #475354
498 * expression.cs (Constantify): Add nullable types.
500 * const.cs (EmitDecimalConstant): Avoid explicit cast.
502 2009-02-12 Marek Safar <marek.safar@gmail.com>
504 A fix for bug #475246
505 * expression.cs: More broken flowanalysis hacking needed.
507 2009-02-12 Marek Safar <marek.safar@gmail.com>
509 * attribute.cs: Compare only ref/out array modifiers.
511 2009-02-11 Marek Safar <marek.safar@gmail.com>
513 * statement.cs: Use member cache when looking for foreach members.
515 2009-02-11 Marek Safar <marek.safar@gmail.com>
517 * expression.cs: Don't expose internal initializer types.
519 * statement.cs: Check also explicit conversions for goto case.
521 2009-02-11 Marek Safar <marek.safar@gmail.com>
523 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
525 2009-02-10 Marek Safar <marek.safar@gmail.com>
527 * *.cs: Replace null-type with NullLiteral where appropriate.
529 2009-02-09 Marek Safar <marek.safar@gmail.com>
531 * expression.cs: Initializer of reference argument use temporary
532 variable to be verifiable.
534 * parameter.cs: Share EmitLdArg.
536 2009-02-09 Marek Safar <marek.safar@gmail.com>
538 A fix for bug #473559
539 * class.cs: Fixed: Not reporting error about nested class with the
542 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
544 Contributed under the MIT/X11 license.
546 * generic.cs: Added VerifyVariantTypeParameters which performs new
547 variance verification logic. The old logic, based on the spec, was
548 wrong because the spec is full of LIES!
550 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
552 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
555 * ecore.cs: Added calls to the new variance verification logic.
558 * delegate.cs: Removed calls to the old variance verification logic.
560 2009-02-06 Marek Safar <marek.safar@gmail.com>
562 * delegate.cs: Use cached Invoke method directly.
564 2009-02-06 Marek Safar <marek.safar@gmail.com>
566 * expression.cs: Emit expression tree for hoisted variable access.
568 2009-02-04 Marek Safar <marek.safar@gmail.com>
570 * namespace.cs: Add better extension class check.
572 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
574 * generic.cs: Fixed typeo (TypeParameter.Variacne).
576 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
578 This patch adds initial generic variance support to the compiler.
579 It is contributed under the MIT/X11 license.
581 * typemanager.cs: Modified ImplementsInterface to check variance.
582 Added VerifyVariantTypeParameters which checks the specified type to see
583 if it uses a variant type parameter as a type argument (which is not
584 allowed). Added IsVariantOf which determins if the first type is a
585 variant of the second. NOTE: This only supports reference types at
586 the moment to conform with the current level of VM support. When the
587 VM supports value types, this will follow step.
589 * generic.cs: Added the Variance enum. Added a Variance property to
590 TypeParameter and added variance support to definition phase. Added a
591 Variance property to TypeParameterName. Also check to make sure that
592 no variant types appear in generic method parameters.
594 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
595 keywords if the langversion supports it.
597 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
598 that variant types are only used in legal positions. Also added
599 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
602 * decl.cs: Construct TypeParameter with the variance information.
604 * convert.cs: Checks variance in ImplicitReferenceConversionExists
605 and ImplicitConversionStandard.
607 * rootcontext.cs: Added new "Future" language version.
609 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
610 type parameters are not used as type arguments in interface inheritance.
611 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
612 parameters are not used as method return types. In MemberBase.
613 ResolveMemberType, ensure that variant type parameters are not used
614 as type arguments. Also call VerifyNoVariantTypeParameters on every
615 set of parameters which are resolved.
617 * delegate.cs: Modified Delegate.Define to ensure that variant
618 parameters are not used as type arguments and that a contravariant
619 parameter is not used as the return type. Also call
620 VerifyNoVariantTypeParameters on the delegate parameters.
622 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
623 to specify generic variance.
625 * driver.cs: Added support for LanguageVersion.Future in the form of
626 "-langversion:future".
628 * generic-mcs.cs: Stubbed out new members in generic.cs.
630 2009-02-03 Marek Safar <marek.safar@gmail.com>
632 * class.cs, generic.cs: Emit type parameter constraints for nested
635 2009-02-02 Marek Safar <marek.safar@gmail.com>
637 A fix for bug #471213
638 * class.cs: Avoid emitting backing field for abstract event fields.
640 2009-02-01 Marek Safar <marek.safar@gmail.com>
642 A fix for bug #359731
643 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
646 2009-01-30 Marek Safar <marek.safar@gmail.com>
648 A fix for bug #470767
649 * statement.cs: Introduced BlockScopeExpression, needed when
650 expression tree conversion has to emit scope variables.
652 2009-01-29 Marek Safar <marek.safar@gmail.com>
654 * class.cs: Remove duplicate CallingConvention.
656 2009-01-29 Marek Safar <marek.safar@gmail.com>
658 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
659 when I finally found the right naming convention.
661 2009-01-29 Marek Safar <marek.safar@gmail.com>
663 * cs-tokenizer.cs: Put back different open parens optimization.
665 2009-01-28 Marek Safar <marek.safar@gmail.com>
667 A fix for bug #470227
668 * cs-tokenizer.cs: Remove too agressive parser optimization.
670 2009-01-28 Marek Safar <marek.safar@gmail.com>
672 A fix for bug #324319
673 * class.cs: Remove too early base type resolve.
675 2009-01-27 Marek Safar <marek.safar@gmail.com>
677 A fix for bug #324319
678 * ecore.cs: Explicitly type null when assigning to type argument to
679 make pass verifier check.
681 2009-01-27 Marek Safar <marek.safar@gmail.com>
683 * anonymous.cs: Fixed recent regression when initializing captured
686 2009-01-26 Marek Safar <marek.safar@gmail.com>
688 A fix for bug #469019
689 * anonymous.cs: Use all parent type parameters when instantiating
690 nested generic storey.
692 2009-01-26 Marek Safar <marek.safar@gmail.com>
694 * expression.cs: Check for null instance methodgroup expression.
696 2009-01-26 Marek Safar <marek.safar@gmail.com>
698 A fix for bug #469244
699 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
700 instance inside a conditional expression.
702 2009-01-23 Marek Safar <marek.safar@gmail.com>
704 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
705 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
706 GetElementType and HasElementType. IsValueType clean up.
708 2009-01-23 Marek Safar <marek.safar@gmail.com>
710 * nullable.cs: Use common EmitCall.
712 * expression.cs: Emit constraint. for virtual calls only.
714 2009-01-23 Marek Safar <marek.safar@gmail.com>
716 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
717 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
718 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
721 2009-01-22 Jb Evain <jbevain@novell.com>
723 * anonymous.cs: make anonymous types' ToString implementation
724 match what csc outputs.
726 2009-01-21 Marek Safar <marek.safar@gmail.com>
728 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
731 2009-01-17 Marek Safar <marek.safar@gmail.com>
733 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
736 2009-01-16 Marek Safar <marek.safar@gmail.com>
738 * nullable.cs (LiftedBinaryOperator): Check for all possible null
741 2009-01-15 Marek Safar <marek.safar@gmail.com>
743 A fix for bug #466634
744 * statement.cs: Add reference for nested storey when only this
747 2009-01-15 Marek Safar <marek.safar@gmail.com>
749 A fix for bug #466474
750 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
753 2009-01-15 Marek Safar <marek.safar@gmail.com>
755 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
756 Fixed nested stories parent referencing process. Also fixes #463985.
758 2009-01-06 Marek Safar <marek.safar@gmail.com>
760 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
761 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
762 implementation. Also fixes #463108.
764 2009-01-05 Marek Safar <marek.safar@gmail.com>
766 A fix for bug #416109
767 * decl.cs: Issue correct CLSAttribute warning location.
769 2009-01-05 Marek Safar <marek.safar@gmail.com>
771 A fix for bug #456775
772 * attribute.cs: Use attribute owner scope when resolving attribute
775 2009-01-05 Marek Safar <marek.safar@gmail.com>
777 A fix for bug #457257
778 * decl.cs: Fixed incorrect member declaring type comparison.
780 2009-01-05 Marek Safar <marek.safar@gmail.com>
782 A fix for bug #460896
783 * driver.cs: Handle /RES resources as embeddable.
785 2009-01-05 Marek Safar <marek.safar@gmail.com>
787 A fix for bug #462515
788 * ecore.cs: Report inacessible members upwards.
790 2009-01-05 Marek Safar <marek.safar@gmail.com>
792 A fix for bug #463190, #463192
793 * decl.cs, namespace.cs: Also import internal extension classes.
795 2009-01-04 Marek Safar <marek.safar@gmail.com>
797 A fix for bug #463415
798 * generic.cs: Use right index for RemoveDependentTypes.
800 2009-01-02 Marek Safar <marek.safar@gmail.com>
802 A fix for bug #463196
803 * expression.cs: Fixed enum to null comparison.
805 2009-01-02 Marek Safar <marek.safar@gmail.com>
807 A fix for bug #463121
808 * nullable.cs: Fixed nullable user equality operator comparison.
810 2009-01-02 Marek Safar <marek.safar@gmail.com>
812 A fix for bug #462950
813 * class.cs, decl.cs: Use full explicit name when defining automatic
814 property backing field.
816 2009-01-02 Marek Safar <marek.safar@gmail.com>
818 A fix for bug #462592
819 * pending.cs: Emit type arguments for generic proxy method.
821 2008-12-30 Marek Safar <marek.safar@gmail.com>
823 * expression.cs (As): Mutate all type arguments.
825 2008-12-29 Marek Safar <marek.safar@gmail.com>
827 A fix for bug #462622
828 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
831 2008-12-29 Marek Safar <marek.safar@gmail.com>
833 A fix for bug #450782
834 * ecore.cs: Consider more variables of form V.I to be fixed.
836 2008-12-29 Marek Safar <marek.safar@gmail.com>
838 A fix for bug #460712
839 * typemanager.cs: Core types could be imported.
841 2008-12-28 Marek Safar <marek.safar@gmail.com>
843 A fix for bugs #460847, #460772, #458049, #457339, #447807
844 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
845 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
846 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
847 user lambdas used inside query clauses.
849 2008-12-18 Marek Safar <marek.safar@gmail.com>
851 A fix for bug #460229
852 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
854 2008-12-18 Marek Safar <marek.safar@gmail.com>
856 A fix for bug #459952
857 * decl.cs, namespace.cs: Use common CheckAccessLevel.
859 2008-12-18 Marek Safar <marek.safar@gmail.com>
861 A fix for bug #459630
862 * convert.cs: Enum to valuetype conversion is not allowed.
864 2008-12-18 Marek Safar <marek.safar@gmail.com>
866 A fix for bug #457087
867 * generic.cs: Don't crash when constraint comes from type
870 2008-12-16 Marek Safar <marek.safar@gmail.com>
872 A fix for bug #459221
873 * anonymous.cs, statement.cs: Delay only captured this
876 2008-12-12 Marek Safar <marek.safar@gmail.com>
878 A fix for bug #457489
879 * anonymous.cs, statement.cs: Split anonymous storey instantiation
880 and initialization to capture scope initializers correctly.
882 2008-12-11 Marek Safar <marek.safar@gmail.com>
884 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
885 ParameterReference refactoring.
887 2008-12-03 Marek Safar <marek.safar@gmail.com>
889 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
890 to be imported from any assembly.
892 2008-12-03 Marek Safar <marek.safar@gmail.com>
894 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
895 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
896 from anonymous method and lambda expression.
898 2008-12-01 Marek Safar <marek.safar@gmail.com>
900 A fix for bug #448560
901 * expression.cs (As): Box any generic type arguments to be
904 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
906 Add tripwire for implicit conversion bugs
907 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
909 (MethodGroupExpr.OverloadResolve): Add sanity check between
910 IsApplicable and VerifyArgumentsCompat.
911 (VerifyArgumentsCompat): Report CS1501 where appropriate.
913 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
915 Fix build break in System.Data_test
916 * convert.cs (ImplicitConversionExists): Move NullLiteral
918 (ImplicitStandardConversionExists): ... here.
920 2008-11-28 Marek Safar <marek.safar@gmail.com>
922 * literal.cs: Emit correctly explicit null to nullable cast.
924 2008-11-28 Marek Safar <marek.safar@gmail.com>
926 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
929 2008-11-28 Marek Safar <marek.safar@gmail.com>
931 A fix for bug #449005
932 * convert.cs, nullable.cs: Use only one implicit nullable
935 2008-11-27 Marek Safar <marek.safar@gmail.com>
937 * convert.cs, literal.cs: More Convert cleanup is needed.
939 2008-11-27 Marek Safar <marek.safar@gmail.com>
941 * decl.cs, class.cs: Fixed misleading error message.
943 2008-11-26 Marek Safar <marek.safar@gmail.com>
945 A fix for bug #449005
946 * nullable.cs (EmitEquality): Disable optimization for user operator
949 2008-11-25 Marek Safar <marek.safar@gmail.com>
951 A fix for bug #447027
952 * anonymous.cs (HoistedVariable): Cache also outer access to deal
953 with context variables stored as expression instances.
955 2008-11-25 Marek Safar <marek.safar@gmail.com>
957 A fix for bug #447027
958 * delegate.cs: Fixed delegate VerifyMethod logic.
960 2008-11-24 Marek Safar <marek.safar@gmail.com>
962 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
965 2008-11-21 Marek Safar <marek.safar@gmail.com>
967 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
968 member type resolve to follow normal flow, instead of random
971 2008-11-21 Marek Safar <marek.safar@gmail.com>
973 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
976 2008-11-21 Marek Safar <marek.safar@gmail.com>
978 * const.cs: Emit decimal array constant as literal.
980 2008-11-20 Marek Safar <marek.safar@gmail.com>
982 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
984 2008-11-19 Marek Safar <marek.safar@gmail.com>
986 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
987 into real property (saves 8 MB for corlib compilation).
989 2008-11-19 Marek Safar <marek.safar@gmail.com>
991 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
992 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
993 generic-mcs.cs: Small cleanup of TypeArguments.
995 2008-11-18 Marek Safar <marek.safar@gmail.com>
997 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
998 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
999 of ConstructedType expression, renamed to GenericTypeExpr.
1001 2008-11-17 Marek Safar <marek.safar@gmail.com>
1003 A fix for bug #445303
1004 * location.cs (IsConditionalDefined): Handle undefined global
1007 2008-11-17 Marek Safar <marek.safar@gmail.com>
1009 A fix for bug #444678
1010 * expression.cs (TryReduceConstant): Always create new constant
1013 2008-11-17 Marek Safar <marek.safar@gmail.com>
1015 A fix for bug #444673
1016 * ecore.cs: Ignore open generic types when used as generic type
1019 2008-11-17 Marek Safar <marek.safar@gmail.com>
1021 A fix for bug #445458
1022 * expression.cs, cs-parser.jay: Don't crash when an expression
1025 2008-11-17 Marek Safar <marek.safar@gmail.com>
1027 A fix for bug #445464
1028 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
1029 inside unbound type.
1031 2008-11-14 Jb Evain <jbevain@novell.com>
1033 * driver.cs: ignore empty -nowarn argument such as
1034 the one in -nowarn:12,13,,.
1036 2008-11-13 Marek Safar <marek.safar@gmail.com>
1038 A fix for bug #444271
1039 * anonymous.cs: Rescan parent storeys when best candidate was
1042 2008-11-13 Marek Safar <marek.safar@gmail.com>
1044 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
1045 useless UnboundTypeExpression.
1047 * attribute.cs: Do check obsolete attribute on generic types.
1049 2008-11-12 Marek Safar <marek.safar@gmail.com>
1051 A fix for bugs #425680, #400139
1052 * ecore.cs, expression.cs: Trying to do some almost_matched_members
1055 2008-11-11 Marek Safar <marek.safar@gmail.com>
1057 A fix for bug #435747
1058 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
1059 compound value types assignment. Few micro optimizations added.
1061 2008-11-10 Marek Safar <marek.safar@gmail.com>
1063 A fix for bug #442610
1064 * anonymous.cs (MutateConstructor): More SRE hacking.
1066 2008-11-10 Marek Safar <marek.safar@gmail.com>
1068 A fix for bug #442579
1069 * ecore.cs: Also initialize expanded form of a method with 1 params
1072 2008-11-06 Marek Safar <marek.safar@gmail.com>
1074 * expression.cs (UnaryMutator): Do early l-side check.
1076 2008-11-05 Miguel de Icaza <miguel@novell.com>
1078 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
1079 Init, otherwise we would crash later on when checking for friend
1082 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
1083 Otherwise we never get any meaningful information as to what
1086 2008-11-05 Marek Safar <marek.safar@gmail.com>
1088 A fix for bug #436318
1089 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
1091 2008-11-05 Miguel de Icaza <miguel@novell.com>
1093 * namespace.cs: Turns out that it was a really bad idea to hide
1094 the errors for namespaces not found here in eval mode.
1096 * eval.cs: When we process using clauses, only enter those into
1097 the list of valid using clauses after they have been validated.
1099 The above change gives the proper semantics: it does not
1100 senselessly report the same errors with broken using statements by
1101 never storing them in the first place when they are invalid.
1103 2008-11-05 Marek Safar <marek.safar@gmail.com>
1105 A fix for bug #421839
1106 * cs-parser.jay: Remove expression from coalesce rule to force lower
1107 priority than the assignment operator.
1109 2008-11-05 Marek Safar <marek.safar@gmail.com>
1111 A fix for bug #437875
1112 * nullable.cs: Compile correctly method group operand used with null
1113 coalescing operator.
1115 2008-11-04 Marek Safar <marek.safar@gmail.com>
1117 A fix for bug #434589
1118 * expression.cs (Binary): Ignore lifted conversions when at least
1119 one operand is of reference type.
1121 2008-11-04 Marek Safar <marek.safar@gmail.com>
1123 * cs-parser.jay: Better syntax error report.
1125 2008-11-03 Marek Safar <marek.safar@gmail.com>
1127 A fix for bug #436792
1128 * cs-parser.jay: Use GetLocation to access location.
1130 2008-11-03 Marek Safar <marek.safar@gmail.com>
1132 A fix for bug #440774
1133 * cs-parser.jay: Also set current_array_type when parsing local
1136 2008-11-03 Marek Safar <marek.safar@gmail.com>
1138 A fix for bug #440785
1139 * expression.cs (As): Don't resolve self modifing expression
1142 2008-11-03 Marek Safar <marek.safar@gmail.com>
1144 A fix for bug #439447
1145 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
1147 2008-11-03 Marek Safar <marek.safar@gmail.com>
1149 A fix for bug #437571
1150 * cs-parser.jay: Fixes internal error for invalid expression
1153 2008-10-17 Marek Safar <marek.safar@gmail.com>
1155 * ecore.cs: Resolve correctly ambiguous params delegate methods.
1157 2008-10-17 Marek Safar <marek.safar@gmail.com>
1159 * generic.cs, anonymous.cs: Simplified GetDeclarations.
1161 2008-10-17 Marek Safar <marek.safar@gmail.com>
1163 * cs-tokenizer.cs: More precise cast parsing.
1165 2008-10-16 Martin Baulig <martin@ximian.com>
1167 * anonymous.cs (AnonymousMethodStorey): Put back the
1168 `hoisted_locals' hashtable and use it in EmitType().
1170 2008-10-15 Marek Safar <marek.safar@gmail.com>
1172 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
1173 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
1176 2008-10-14 Marek Safar <marek.safar@gmail.com>
1178 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
1180 2008-10-14 Marek Safar <marek.safar@gmail.com>
1182 * statement.cs: Mutate scope initializers.
1184 2008-10-14 Marek Safar <marek.safar@gmail.com>
1186 * expression.cs: Use typeless value for This constant.
1188 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
1190 2008-10-14 Marek Safar <marek.safar@gmail.com>
1192 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
1195 2008-10-13 Marek Safar <marek.safar@gmail.com>
1197 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
1200 2008-10-13 Marek Safar <marek.safar@gmail.com>
1202 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
1203 parser and tokenizer. Fixes many ambiguities including #433258.
1205 2008-10-10 Marek Safar <marek.safar@gmail.com>
1207 * cs-parser.jay: Fixed missing accessor recovery.
1209 2008-10-10 Marek Safar <marek.safar@gmail.com>
1211 A fix for bug #433701
1212 * expression.cs: Better error message.
1214 2008-10-10 Marek Safar <marek.safar@gmail.com>
1216 * cs-parser.jay, expression.cs: Start reporting real parser errors.
1218 * Makefile: Disabled unused debug symbols.
1220 Also fixes: #320556, #321097, #321656, #321876, #351316
1222 2008-10-09 Miguel de Icaza <miguel@novell.com>
1224 * eval.cs: rename "<interactive>" to "{interactive}", to work
1225 around a requirement in the compiler that this be a valid
1226 filename, and in Windows it is not (433886).
1228 2008-10-09 Marek Safar <marek.safar@gmail.com>
1230 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
1232 2008-10-08 Marek Safar <marek.safar@gmail.com>
1234 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
1235 cs-parser.jay: Generic type declaration and type arguments cleanup.
1237 2008-10-05 Marek Safar <marek.safar@gmail.com>
1239 * cs-parser.jay: Allow parsing weird array creation construct.
1241 2008-10-05 Marek Safar <marek.safar@gmail.com>
1243 * cs-parser.jay: Conflicts reduction.
1245 2008-10-04 Marek Safar <marek.safar@gmail.com>
1247 * cs-parser.jay: Conflicts reduction.
1249 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
1252 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
1253 property. Add a 'count' hint about the use of the shared vector.
1254 Ensure that we don't leak out dirty bits.
1255 (UsageVector.MergeChild): Throw away information about variables
1257 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
1259 2008-10-03 Marek Safar <marek.safar@gmail.com>
1261 A fix for bug #431746
1262 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
1263 parameters when iterator is created.
1265 2008-10-03 Marek Safar <marek.safar@gmail.com>
1267 A fix for bug #431827
1268 * expression.cs: Fixed right based pointer arithmetic operations
1271 2008-10-03 Marek Safar <marek.safar@gmail.com>
1273 A fix for bug #353779
1274 * assign.cs, expression.cs: Fixed compound assignment conversions.
1276 2008-10-02 Marek Safar <marek.safar@gmail.com>
1278 A fix for bug #375262
1279 * statement.cs: Refactor ArrayForeach to be usable with string
1280 indexer. Optimized single dimentional arrays foreach.
1282 2008-10-02 Marek Safar <marek.safar@gmail.com>
1284 A fix for bug #431255
1285 * anonymous.cs, expression.cs: Removed broken optimization.
1287 2008-10-01 Marek Safar <marek.safar@gmail.com>
1289 * anonymous.cs: Use full type parameters of parent generic
1290 containers. Removed unnecessary AddParentStoreyReference call.
1292 2008-10-01 Marek Safar <marek.safar@gmail.com>
1294 A fix for bug #324702
1295 * class.cs: Use better shorter names for explicit interface member
1298 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
1300 2008-10-01 Marek Safar <marek.safar@gmail.com>
1302 * expression.cs: Use new interface to check fixed expression.
1304 2008-10-01 Marek Safar <marek.safar@gmail.com>
1306 A fix for bug #421101
1307 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
1308 interface to check for fixed fixed-buffers.
1310 2008-10-01 Marek Safar <marek.safar@gmail.com>
1312 A fix for bug #429264
1313 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
1315 * delegate.cs: Removed unnecessary casts.
1317 2008-09-30 Marek Safar <marek.safar@gmail.com>
1319 A fix for bug #352151
1320 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
1321 class.cs: Fixed already defined explicit interface members check.
1323 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
1325 cs-tokenizer.cs: Fix typo.
1327 2008-09-28 Miguel de Icaza <miguel@novell.com>
1329 * eval.cs (InteractiveBase): The quit command now just sets a
1330 flag, instead of calling Environment.Exit(), it is milder on
1333 CompiledMethod is now in Mono.CSharp, not nested inside
1334 the Evaluator, it was inconvenient to use.
1336 2008-09-27 Miguel de Icaza <miguel@novell.com>
1338 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
1339 code to be invoked without having to reparse.
1341 2008-09-27 Miguel de Icaza <miguel@novell.com>
1343 * ecore.cs: The recent changes to FieldExpr broke this as well.
1344 Fixes LINQ queries in the interactive shell.
1346 * Multiple files: indentation fixing for the Mono coding
1347 guidelines for the switch statement.
1349 * eval.cs: Make the Evaluator API thread safe.
1351 2008-09-26 Marek Safar <marek.safar@gmail.com>
1353 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
1354 constructor parsing.
1356 2008-09-26 Marek Safar <marek.safar@gmail.com>
1358 A fix for bug #325326
1359 * statement.cs: Check possible mistaken empty statement using
1360 explicit blocks only.
1362 2008-09-25 Miguel de Icaza <miguel@novell.com>
1364 * eval.cs (LoadAssembly, ReferenceAssembly): Call
1365 RootNamespace.ComputeNamespaces to update the internal list of
1366 namespaces, this is no longer done for us.
1368 (InteractiveBase): Use the Evaluator APIs instead of calling into
1371 2008-09-25 Marek Safar <marek.safar@gmail.com>
1373 A fix for bug #429264
1374 * expression.cs: Missing mutator for access to multidimensional
1377 2008-09-25 Marek Safar <marek.safar@gmail.com>
1379 * class.cs, statement: Emit DebuggerHidden attribute for iterator
1382 * driver.cs: Missing input argument check.
1384 2008-09-25 Marek Safar <marek.safar@gmail.com>
1386 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
1387 expression.cs, statement.cs, rootcontext.cs, class.cs,
1388 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
1391 2008-09-24 Miguel de Icaza <miguel@novell.com>
1393 * ecore.cs (FieldExpr): Only initialize eclass when we return a
1394 fully constructed FieldExpr, fixes the regression introduced in
1397 * ecore.cs, expression.cs: Plug back the eclass initialization as
1398 otherwise it regresses `csharp'.
1400 2008-09-24 Marek Safar <marek.safar@gmail.com>
1402 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
1403 ecore.cs, attribute.cs: Moved obsolete method checks from emit
1404 phase to resolve phase. It resolves problems with expression trees
1405 and fixes bugs #323796, #325156.
1407 2008-09-23 Marek Safar <marek.safar@gmail.com>
1409 * codegen.cs: Report better error when symbol writer is missing.
1411 2008-09-23 Marek Safar <marek.safar@gmail.com>
1413 * codegen.cs: Set .NET symbol writer.
1415 * decl.cs: Guard against null generic arguments.
1417 * report.cs: Don't report exactly same additional details.
1419 2008-09-22 Marek Safar <marek.safar@gmail.com>
1421 A fix for bug #324917
1422 * cs-parser.jay: Add missing multidimensional non-expression type
1425 2008-09-22 Marek Safar <marek.safar@gmail.com>
1427 A fix for bug #428191
1428 * anonymous.cs: Create an outer generic fields also for non-storey
1431 2008-09-22 Marek Safar <marek.safar@gmail.com>
1433 A fix for bug #378294
1434 * class.cs: Make fixed size buffers gmcs feature only.
1436 2008-09-22 Marek Safar <marek.safar@gmail.com>
1438 A fix for bug #355622, #324993
1439 * assign.cs, const.cs, class.cs: Create new EmitContext for each
1442 2008-09-19 Marek Safar <marek.safar@gmail.com>
1444 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
1447 2008-09-19 Marek Safar <marek.safar@gmail.com>
1449 A fix for bug #416110
1450 * generic.cs: Struct constraint results in default ctor and
1451 ValueType base type constraint to be set.
1453 2008-09-19 Marek Safar <marek.safar@gmail.com>
1455 A fix for bug #423791
1456 * generic.cs: Fixed params output type type-inference.
1458 2008-09-19 Marek Safar <marek.safar@gmail.com>
1460 * cs-parser.jay, expression.cs: Fixed few expression crashes.
1462 2008-09-19 Marek Safar <marek.safar@gmail.com>
1464 * cs-tokenizer.cs: Don't break on extra partial modifier.
1466 2008-09-19 Marek Safar <marek.safar@gmail.com>
1468 A fix for bug #427592
1469 * generic.cs: Use common parameter resolve method.
1471 2008-09-18 Marek Safar <marek.safar@gmail.com>
1473 A fix for bug #414758
1474 * expression.cs, ecore.cs: Fixed crash when accessing non-static
1477 2008-09-18 Marek Safar <marek.safar@gmail.com>
1479 * driver.cs, namespace.cs: Read types and namespaces after all
1480 requested assemblies are loaded, fixes issues with System.Core
1481 auto-reference, and #419888.
1483 2008-09-18 Marek Safar <marek.safar@gmail.com>
1485 A fix for bug #417705
1486 * cs-parser.jay: Fixed as/is operator expression split.
1488 2008-09-18 Marek Safar <marek.safar@gmail.com>
1490 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
1491 Fixed expression tree representation of empty new expression and
1492 new initializer expression.
1494 2008-09-18 Miguel de Icaza <miguel@novell.com>
1496 * eval.cs: Remove warning, keep reference to driver around.
1498 * Hide fields that do not need to be public.
1500 2008-09-17 Marek Safar <marek.safar@gmail.com>
1502 A fix for bug #426385
1503 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
1504 conversion for array elements.
1506 2008-09-17 Marek Safar <marek.safar@gmail.com>
1508 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
1509 void parsing conflicts.
1511 2008-09-15 Marek Safar <marek.safar@gmail.com>
1513 A fix for bug #425601
1514 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
1515 System.Core only when there is no custom ExtensionAttribute
1518 2008-09-15 Miguel de Icaza <miguel@novell.com>
1520 * namespace.cs: Do not report CS0246 (name
1522 2008-09-12 Marek Safar <marek.safar@gmail.com>
1524 A fix for bug #425669
1525 * generic.cs: Don't cache generic static anonymous method
1528 2008-09-12 Marek Safar <marek.safar@gmail.com>
1530 * generic.cs, class.cs, delegate.cs: Check recursive inherited
1531 conflicting constraints.
1533 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
1535 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
1538 2008-09-12 Marek Safar <marek.safar@gmail.com>
1540 * literal.cs, convert.cs, expression.cs, statement.cs: More null
1541 to null pointer conversion fixes.
1543 2008-09-11 Marek Safar <marek.safar@gmail.com>
1545 * cs-parser.jay, expression.cs: An implicitly typed local variable
1546 declarator cannot use an array initializer.
1548 2008-09-11 Marek Safar <marek.safar@gmail.com>
1550 * cs-parser.jay: Reduced number of printed tokens, add sorting.
1552 2008-09-11 Marek Safar <marek.safar@gmail.com>
1554 * generic.cs (InflatedConstraints): Don't crash when constraints
1557 * cs-parser.jay: const_declarator is a block.
1559 * constant.cs: Check for not allowed NaN conversions.
1561 2008-09-10 Miguel de Icaza <miguel@novell.com>
1563 * driver.cs: Drop --shell argument, the compiler is no longer a
1566 * eval.cs: Move most of the code that deals with evaluation into
1567 this file and document the public API from repl.cs
1569 * repl.cs: Remove from here.
1571 2008-09-10 Marek Safar <marek.safar@gmail.com>
1573 A fix for bug #424684
1574 * generic.cs: Generic class constraints must come first.
1576 2008-09-09 Miguel de Icaza <miguel@novell.com>
1578 * cs-parser.jay: Improve error reporting for syntax errors in
1579 statements and expressions, we now report the expected tokens
1580 instead of reporting the useless "; expected".
1582 Drop the strings from the token declaration, it turns out that
1583 they did not do what I thought they did. Instead they were adding
1584 two sets of tokens to the tables.
1586 2008-09-09 Marek Safar <marek.safar@gmail.com>
1588 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
1589 delegate.cs: Share special type check.
1591 2008-09-09 Marek Safar <marek.safar@gmail.com>
1593 A fix for bug #423981
1594 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
1596 2008-09-09 Marek Safar <marek.safar@gmail.com>
1598 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
1601 2008-09-09 Marek Safar <marek.safar@gmail.com>
1603 A fix for bugs: #324750, #335946
1604 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
1605 lookup rule to determine ?-based tokens.
1607 2008-09-08 Miguel de Icaza <miguel@novell.com>
1609 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
1610 expressions (like event adding or removing) end up here, so we
1611 need to treat those as statements.
1613 Add LoadAssembly method.
1615 2008-09-04 Miguel de Icaza <miguel@novell.com>
1617 * repl.cs: Add Time method.
1619 2008-09-05 Marek Safar <marek.safar@gmail.com>
1621 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
1623 2008-09-05 Miguel de Icaza <miguel@novell.com>
1625 * repl.cs: Add workaround for old compilers.
1627 2008-09-04 Jb Evain <jbevain@novell.com>
1629 * repl.cs (PrettyPrint): pretty print everything that
1630 implements IDictionary, as well as IEnumerables. Also,
1631 add a quit helper property.
1633 2008-09-04 Marek Safar <marek.safar@gmail.com>
1635 * constant.cs: Better error reporting for decimal literals.
1637 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
1640 2008-09-04 Marek Safar <marek.safar@gmail.com>
1641 Miguel de Icaza <miguel@novell.com>
1643 A fix for bug #422951
1644 * assign.cs (Assign.DoResolve): Perform the type conversions
1645 checks before we attempt to initialize `New' initializers.
1647 2008-09-04 Marek Safar <marek.safar@gmail.com>
1649 A fix for bug #422853
1650 * delegate.cs (DelegateCreation): Add special handling for
1651 EmptyExpression.Null instance expression which is just another
1652 hack for undecided member instance exression.
1654 2008-09-04 Marek Safar <marek.safar@gmail.com>
1656 * expression.cs, ecore.cs: Emit full expression tree for reduced
1659 2008-09-04 Marek Safar <marek.safar@gmail.com>
1661 * expression.cs (This): Guard against multi-resolving.
1663 * ecore.cs, statement.cs (Throw): Simplified.
1665 * flowanalysis.cs: Also verify event fields.
1667 2008-09-04 Miguel de Icaza <miguel@novell.com>
1669 * assign.cs (Assign.DoResolve): Perform the type conversions
1670 checks before we attempt to initialize `New' initializers.
1672 * repl.cs (PrettyPrint): Add Hashtable prettyprint
1674 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
1677 * repl.cs: Update help.
1679 2008-09-03 Miguel de Icaza <miguel@novell.com>
1681 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
1682 handling of the default config handling, including the special
1683 treatment of System.Core assembly.
1685 Fixes the REPL processing for LINQ.
1687 2008-09-03 Marek Safar <marek.safar@gmail.com>
1689 A fix for bug #422507
1690 * expression.cs (UnboxCast): Add missing child expression mutator.
1692 2008-09-03 Marek Safar <marek.safar@gmail.com>
1694 * driver.cs: Don't self reference System.Core assembly.
1696 2008-09-03 Marek Safar <marek.safar@gmail.com>
1698 A fix for bug #422507
1699 * expression.cs (StringConcat): Add missing type mutator.
1701 2008-09-03 Marek Safar <marek.safar@gmail.com>
1703 * generic.cs (TypeInferenceContext): Follow equality rule for
1704 constructed type lower bound type inference.
1706 2008-09-02 Miguel de Icaza <miguel@novell.com>
1708 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
1709 <dblank@cs.brynmawr.edu> which updates the cursor position on
1712 2008-09-02 Marek Safar <marek.safar@gmail.com>
1714 A fix for bug #367145
1715 * driver.cs: Fixed import of extension methods when using -noconfig
1718 2008-09-02 Marek Safar <marek.safar@gmail.com>
1720 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
1721 version from non-generic implementation instead.
1723 2008-09-01 Marek Safar <marek.safar@gmail.com>
1725 A fix for bug #418908
1726 * class.cs: Use AddScopeStatement for field initializers.
1728 2008-09-01 Marek Safar <marek.safar@gmail.com>
1730 A fix for bug #415385
1731 * ecore.cs, convert.cs: Do method group conversion for equal group types.
1733 2008-09-01 Marek Safar <marek.safar@gmail.com>
1735 A fix for bug #421736
1736 * iterators.cs: Don't crash on unreachable iterators.
1738 2008-09-01 Marek Safar <marek.safar@gmail.com>
1740 A fix for bug #421628
1741 * parameter.cs, attribute.cs: Clone also parameter attributes.
1743 2008-08-30 Miguel de Icaza <miguel@novell.com>
1745 * namespace.cs (LookupType): In EvalMode, try to replace
1746 the TypeBuilder from our cache with a Type as Reflection.Emit does
1747 not like to mix code from older assemblies emitted and new
1750 This sounds like a serious Mono bug that prevents multiple
1751 assemblies to be generated and consumed at the same time.
1753 * cs-parser.jay (push_current_class): Do not make interactive
1754 classes internal or private, make them public as we currently
1755 generate each new class in a new assembly.
1757 2008-08-29 Miguel de Icaza <miguel@novell.com>
1759 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
1760 remove types that are entered into the global namespace during
1761 parsing so that we can remove them on failure.
1763 * cs-parser.jay: Parsing: we now keep track of types that are
1764 entered into global variables and queue those in case the parsing
1767 This happens in a few situations: during partial-input, we invoke
1768 the parser repeatedly for example with the string "class X", this
1769 would cause X to be registed, and we need to remove this
1770 registration so that another parse attempt later with say "class X {"
1771 would actually work.
1773 Additionally, if there is an error in the resolution phase, for
1774 example: "class X : NonExistant {}" th
1776 * cs-parser.jay: Be more precise with the errors being raised,
1777 instead of flagging all exceptions during parsing to be attributed
1778 to the parsing process, distinguish those from errors happening in
1779 the actions and hint that using -v would produce the actual
1782 * repl.cs: Do not load all compiler references on each reset,
1783 doing the partial reset takes care of this.
1785 2008-08-28 Miguel de Icaza <miguel@novell.com>
1787 * repl.cs: Add support for loading all the files from
1788 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
1791 Introduce a micro-parser that is able to deambiguate on its input
1792 whether we are dealing with a compilation unit (namespace, class,
1793 interface, struct, delegate) declaration or a statement. This
1794 allows both declarations and statements to be entered.
1796 Set history size by default to 300 lines.
1798 Instead of distinguishing based on the parser.InteractiveResult,
1799 have only two cases: statements were parsed, or a compilation unit
1800 was. Always pull the Using statement additions from the
1801 compilation unit parse.
1803 * cs-tokenizer.cs: Rename tokens to better describe their intent
1804 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
1806 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
1807 EvalMode is used to trigger the lookup of global variables while
1808 StatementMode is used turn variable declarations into static
1811 * getline.cs: Allow history size to be set.
1813 2008-08-29 Marek Safar <marek.safar@gmail.com>
1815 A fix for bug #360755
1816 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
1818 2008-08-29 Marek Safar <marek.safar@gmail.com>
1820 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
1822 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
1823 member name, it is too confusing
1825 * decl.cs, class.cs: Don't report unused fields with attached attribute.
1827 * rootcontext.cs: Finally default to warning level 4.
1829 2008-08-28 Marek Safar <marek.safar@gmail.com>
1831 * class.cs (CheckBase): Ignore overloaded operators.
1833 2008-08-28 Marek Safar <marek.safar@gmail.com>
1835 A fix for bug #420830
1836 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
1838 2008-08-28 Marek Safar <marek.safar@gmail.com>
1840 A fix for bug #420832
1841 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
1843 2008-08-28 Marek Safar <marek.safar@gmail.com>
1845 A fix for bug #420386
1846 * nullables.cs: Fixed logic of nullable user comparison operators involving
1849 2008-08-28 Marek Safar <marek.safar@gmail.com>
1851 * attribute (IsClsCompliant): Use FALSE value for pointer types.
1853 2008-08-27 Miguel de Icaza <miguel@novell.com>
1855 * repl.cs: Add support for aborting the running code with C-c.
1857 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
1859 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
1861 2008-08-27 Miguel de Icaza <miguel@novell.com>
1863 * cs-parser.jay (interactive_statement_list): A new set of rules
1864 for hosting statements that uses the "interactive_" prefix.
1866 * repl.cs: Add support for parsing `using' as a statement or as a
1867 directive. Deambiguating before passing this to the parser.
1869 We need to distinguish statement_expressions that occur at the
1870 toplevel vs those that occur embedded into expressions.
1872 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
1873 that fixes the cursor key handling, and a history bug.
1875 2008-08-26 Miguel de Icaza <miguel@novell.com>
1877 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
1878 limitations in Console, instead the 2.0 bootstrap libraries now
1879 include the Console bits.
1881 Also, remove the use of Nullables from getline.cs
1885 Interactive support for the C# compiler. Use gmcs --shell to
1886 enter a read-eval-print loop shell.
1888 Docs: http://www.mono-project.com/CsharpRepl
1890 * sources: include repl.cs here and getline.cs for gmcs.exe,
1891 everything else is getline.cs impaired.
1893 * Makefile: when bootstrapping pass a special flag
1894 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
1895 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
1896 This distinguishes those two cases.
1898 * repl.cs: Support for a read-eval-print loop. Will be soon
1899 refactored into eval support and then REPL on top of it.
1901 * ecore.cs: If a simplename lookup fails, before erroring out,
1902 if we are in EvalMode to resolve the name to a declaration in the
1905 This means that variable declarations that happened in previous
1906 classes (as repl puts every statement in a separate class) are
1907 made visible in this way.
1909 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
1910 triggered an error due to the end of file being reached. This is
1911 used to do multi-line input, and notify the caller that the user
1912 needs to provide more text before a successful parse.
1914 Add new grammar rules after the INTERACTIVE_PARSER token is seen
1915 to drive the evaluation with a custom wrapper.
1917 * driver.cs: Add support for --shell, and refactor some code to be
1920 * namespace.cs: Add support for serializing the contents of the
1921 namespaces and reloading them.
1923 * getline.cs: A managed implementation of ReadLine under
1924 X11/Apache2 license terms. Easy to embed in other applications as
1927 * namespace.cs: Add some functions to save and restore the
1930 * rootcontext.cs: New public field.
1932 * cs-tokenizer.cs: Add support for one of the possible characters
1933 we introduce into the token stream.
1935 This patch does not affect the regular tokenization process, the
1936 only performance hit would happen if there is an invalid character
1937 on the input string.
1939 * support.cs: Move isatty helper routine here.
1941 * codegen.cs: Small cleanup, and add a mechanism to initialize the
1942 code generator for in-memory assemblies.
1944 2008-08-26 Marek Safar <marek.safar@gmail.com>
1946 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
1947 parameter cannot be always used as a type.
1949 2008-08-21 Marek Safar <marek.safar@gmail.com>
1951 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
1953 2008-08-21 Marek Safar <marek.safar@gmail.com>
1955 * convert.cs: Implement explicit array to IList<T> conversion.
1957 2008-08-20 Marek Safar <marek.safar@gmail.com>
1959 A fix for bug #362740
1960 * cs-tokenizer.cs: Handle UTF-16 surrogates.
1962 2008-08-20 Marek Safar <marek.safar@gmail.com>
1964 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
1965 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
1966 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
1967 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
1968 handling to use just one type of infrastructure and deal with generics
1971 2008-07-23 Martin Baulig <martin@ximian.com>
1973 *** Merged this from trunk revision 108527 ***
1976 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
1977 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
1980 2008-08-15 Marek Safar <marek.safar@gmail.com>
1982 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
1985 2008-08-15 Marek Safar <marek.safar@gmail.com>
1987 * delegate.cs: Fixed compiler crash when creating delegate using partial
1990 * typemanager.cs: MulticastDelegate is not a delegate.
1992 2008-08-14 Marek Safar <marek.safar@gmail.com>
1994 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
1997 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
1999 * cs-parser.jay (type): Allow 'var' in mcs too.
2000 (local_variable_type): Likewise.
2002 2008-08-14 Marek Safar <marek.safar@gmail.com>
2004 * driver.cs: Removed broken -noconfig variants.
2006 2008-08-14 Marek Safar <marek.safar@gmail.com>
2008 A fix for bug #417078
2009 * expression.cs: Emit correctly left side pointer operators.
2011 2008-08-13 Marek Safar <marek.safar@gmail.com>
2013 * generic.cs, lambda.cs: Inflate method generic arguments only.
2015 2008-08-12 Marek Safar <marek.safar@gmail.com>
2017 * class.cs: Fixed struct layout check regression.
2019 2008-08-12 Marek Safar <marek.safar@gmail.com>
2021 * cs-parser.jay, enum.cs: Simplified enum parsing.
2023 * decl.cs: Check all type parameters conflicts.
2025 * expression.cs, statement.cs, attribute.cs: More expression checks.
2027 2008-08-11 Marek Safar <marek.safar@gmail.com>
2029 * generic.cs: Add type inference types restriction.
2031 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
2032 anonymous.cs, expression.cs: Allocate less accessor parameters.
2034 2008-08-08 Marek Safar <marek.safar@gmail.com>
2036 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
2039 2008-08-08 Marek Safar <marek.safar@gmail.com>
2041 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
2043 2008-08-07 Marek Safar <marek.safar@gmail.com>
2045 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
2046 Also fixes #362146 and #381592.
2048 2008-08-07 Marek Safar <marek.safar@gmail.com>
2050 * ecore.cs: Reduced constant cannot be used as an attribute value.
2052 * cs-parser.jay: Base expression has to be a type.
2054 * expression.cs (Conditional): Uses ReducedExpression.
2056 2008-08-06 Marek Safar <marek.safar@gmail.com>
2058 A fix for bug #376826
2059 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
2060 address of hoisted local variable or parameter cannot be taken.
2062 2008-08-05 Marek Safar <marek.safar@gmail.com>
2064 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
2065 anonymous method inside checked/unchecked expression.
2067 2008-08-05 Marek Safar <marek.safar@gmail.com>
2069 * typemanager.cs (IsEqual): Guard against null.
2071 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
2072 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
2073 routine. Fixed few misleading conversion errors.
2075 2008-08-04 Marek Safar <marek.safar@gmail.com>
2077 * class.cs: Consider generics when checking cycles in struct layout.
2079 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
2081 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
2083 2008-08-04 Marek Safar <marek.safar@gmail.com>
2085 A fix for bug #414165
2086 * anonymous.cs: Use same anonymous implementation method for all anonymous
2089 2008-08-04 Marek Safar <marek.safar@gmail.com>
2091 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
2094 2008-08-04 Marek Safar <marek.safar@gmail.com>
2096 * cs-parser.jay: Typeof argument has to be a type expression.
2098 * namespace.cs: Check alias and namespace definitions collisions.
2100 * class.cs, pending.cs: Moved explicit interface accessor implementation
2103 * delegate.cs, expression.cs: Verify special name invocations.
2105 2008-08-01 Marek Safar <marek.safar@gmail.com>
2107 * cs-parser.jay: Don't choke on empty generic type arguments.
2109 * cs-tokenizer.cs: Handle escaped preprocessor directives.
2111 * expression.cs, ecore.cs: Minor expressions bugs.
2113 2008-08-01 Marek Safar <marek.safar@gmail.com>
2115 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
2116 and added more error handling.
2118 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
2120 * modifiers.cs, enum.cs: Fixed.
2122 2008-07-31 Jb Evain <jbevain@novell.com>
2124 * driver.cs: remove -pkg ability of smcs.
2126 2008-07-30 Marek Safar <marek.safar@gmail.com>
2128 * statement.cs (Switch): Correctly set empty default target for single
2131 2008-07-30 Marek Safar <marek.safar@gmail.com>
2133 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
2134 string switch statement implementation to use string dictionary which
2135 significantly (2-8x) improves performance of generated code.
2137 2008-07-29 Marek Safar <marek.safar@gmail.com>
2139 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
2140 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
2142 2008-07-29 Marek Safar <marek.safar@gmail.com>
2144 A fix for bug #412595
2145 * typemanager.cs, convert.cs, expression.cs: Some types are never
2146 convertible to each other.
2148 2008-07-29 Marek Safar <marek.safar@gmail.com>
2150 * nullable.cs (CreateNullConstant): An error messages update.
2152 2008-07-29 Marek Safar <marek.safar@gmail.com>
2154 A fix for bug #412595
2155 * cfold.cs: Don't cast undefined bool constant.
2157 2008-07-29 Martin Baulig <martin@ximian.com>
2160 (SymbolWriter.Reset): New public static method.
2163 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
2165 2008-07-28 Marek Safar <marek.safar@gmail.com>
2167 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
2169 * expression.cs (ElementAccess): Exact size allocation.
2171 2008-07-26 Marek Safar <marek.safar@gmail.com>
2173 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
2175 2008-07-25 Marek Safar <marek.safar@gmail.com>
2177 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
2179 * class.cs: Removed $PRIVATE$ field hack which caused problems during
2182 2008-07-25 Marek Safar <marek.safar@gmail.com>
2184 A fix for bug #412217
2185 * assign.cs: Mutate also assignment type.
2187 2008-07-25 Marek Safar <marek.safar@gmail.com>
2189 A fix for bug #323644
2190 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
2193 2008-07-25 Marek Safar <marek.safar@gmail.com>
2195 A fix for bug #412134
2196 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
2197 non-enumerable operands when overloading equality or bitwise operators.
2199 2008-07-25 Marek Safar <marek.safar@gmail.com>
2201 * anonymous.cs: Cache closed generic anonymous method delegates.
2203 2008-07-24 Marek Safar <marek.safar@gmail.com>
2205 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
2206 anonymous.cs, statement.cs: Always emit anonymous method as static method
2207 when is instance free. Use nesting for nested anynomous methods blocks.
2209 2008-07-23 Marek Safar <marek.safar@gmail.com>
2211 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
2214 2008-07-23 Marek Safar <marek.safar@gmail.com>
2216 * expression.cs: Removed MakeSimpleCall.
2218 2008-07-23 Marek Safar <marek.safar@gmail.com>
2220 A fix for bug #323012
2221 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
2222 Base method implementing interface has to be public.
2224 2008-07-23 Marek Safar <marek.safar@gmail.com>
2226 * cs-parser.jay: Don't break on missing argument.
2228 2008-07-22 Marek Safar <marek.safar@gmail.com>
2230 A fix for bug #320993
2231 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
2232 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
2234 2008-07-22 Marek Safar <marek.safar@gmail.com>
2236 A fix for bug #320748
2237 * convert.cs: Implicit user operators cannot convert to interfaces
2239 2008-07-22 Marek Safar <marek.safar@gmail.com>
2241 A fix for bug #312686
2242 * driver.cs: Ignore empty assembly references.
2244 2008-07-22 Marek Safar <marek.safar@gmail.com>
2246 A fix for bug #387040
2247 * ecore.cs: Skip constrains check for an explicit implementation.
2249 2008-07-21 Marek Safar <marek.safar@gmail.com>
2251 A fix for bug #409045
2252 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
2253 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
2254 identifiers are file specific unless passed as input arguments.
2256 2008-07-21 Marek Safar <marek.safar@gmail.com>
2258 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
2259 to emit UnmanagedMarshal data under 2.0 profile.
2261 2008-07-21 Marek Safar <marek.safar@gmail.com>
2263 A fix for bug #410369
2264 * parameter.cs: Clone correctly ParamsParameter.
2266 2008-07-21 Marek Safar <marek.safar@gmail.com>
2268 * expression.cs (Argument): Always report type for type based expressions
2271 2008-07-18 Marek Safar <marek.safar@gmail.com>
2273 A fix for bug #410666
2274 * anonymous.cs: Correctly initialize generic storey reference.
2276 2008-07-18 Marek Safar <marek.safar@gmail.com>
2278 * convert.cs: Don't box same type arguments.
2280 2008-07-18 Marek Safar <marek.safar@gmail.com>
2282 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
2283 Finished missing generic type mutators.
2285 2008-07-18 Marek Safar <marek.safar@gmail.com>
2287 * iterators.cs, statement.cs: Finished statements CloneTo.
2289 2008-07-18 Marek Safar <marek.safar@gmail.com>
2291 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
2293 * expression.cs: Emit optimized default value expressions in expression tree
2296 2008-07-18 Marek Safar <marek.safar@gmail.com>
2298 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
2300 2008-07-17 Marek Safar <marek.safar@gmail.com>
2302 A fix for bug #367536
2303 * cs-parser.jay: Check static constructor of generic types for an access
2306 2008-07-17 Marek Safar <marek.safar@gmail.com>
2308 A fix for bug #353800
2309 * lambda.cs: Emit ret for contextual statements.
2311 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
2312 up emitting redundant ret for all anonymous methods with return.
2314 2008-07-17 Marek Safar <marek.safar@gmail.com>
2316 A fix for bug #365188
2317 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
2318 create anonymous method storey in unreachable block.
2320 2008-07-17 Marek Safar <marek.safar@gmail.com>
2322 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
2323 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
2324 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
2325 statement.cs: Fixed relevant defects found by Gendarme.
2327 2008-07-17 Marek Safar <marek.safar@gmail.com>
2329 A fix for bug #325291
2330 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
2331 statement.cs: Replaced IAnonymousHost with top level block flag.
2333 2008-07-17 Marek Safar <marek.safar@gmail.com>
2335 * cs-parser.jay: Clean up unused open_parens.
2337 2008-07-17 Marek Safar <marek.safar@gmail.com>
2339 * ecore.cs: Custom error message for a range variable assignment.
2341 2008-07-16 Marek Safar <marek.safar@gmail.com>
2343 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
2346 2008-07-16 Marek Safar <marek.safar@gmail.com>
2348 * literal.cs: Null literal is of object type.
2350 2008-07-16 Marek Safar <marek.safar@gmail.com>
2352 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
2353 expression of nullable equality comparison.
2355 2008-07-15 Marek Safar <marek.safar@gmail.com>
2357 * expression.cs(PointerArithmetic): Removed redundant assignment.
2359 2008-07-15 Marek Safar <marek.safar@gmail.com>
2361 * decl.cs (GetSignatureForError): Report full namespace name for containers.
2363 2008-07-14 Marek Safar <marek.safar@gmail.com>
2365 A fix for bug #408361
2366 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
2367 they are replaced by GetMethod.
2369 2008-07-14 Marek Safar <marek.safar@gmail.com>
2371 A fix for bug #408721 by jeremie.laval@gmail.com
2372 * expression.cs (Indirection): Implemented CloneTo.
2374 2008-07-14 Marek Safar <marek.safar@gmail.com>
2376 * statement.cs (AssignableSlots): Temporary disabled variable initialization
2379 2008-07-14 Marek Safar <marek.safar@gmail.com>
2381 * report.cs (EnableReporting): Don't reinitialize 0-based values.
2383 2008-07-11 Marek Safar <marek.safar@gmail.com>
2385 * linq.cs: Reset tranparent parameter counter in probing mode.
2387 2008-07-11 Marek Safar <marek.safar@gmail.com>
2389 * anonymous.cs: Mutate anonymous method type.
2391 2008-07-11 Marek Safar <marek.safar@gmail.com>
2393 * ecore.cs, anonymous.cs: Mutate field expressions.
2395 2008-07-10 Marek Safar <marek.safar@gmail.com>
2397 A fix for bug #369670
2398 * linq.cs, statement.cs: Use explicit block for query expressions variables.
2400 2008-07-10 Marek Safar <marek.safar@gmail.com>
2402 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
2404 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
2407 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
2408 only one '>', and finds a '>>', abort the generic lookahead.
2410 2008-07-10 Marek Safar <marek.safar@gmail.com>
2412 A fix for bug #319902
2413 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
2415 2008-07-10 Marek Safar <marek.safar@gmail.com>
2417 A fix for bug #406371
2418 * statement.cs: Moved EmitSymbolInfo to Block.
2420 2008-07-09 Marek Safar <marek.safar@gmail.com>
2422 * ecore.cs: Report better error for extension method overload failures.
2424 2008-07-09 Marek Safar <marek.safar@gmail.com>
2426 * expression.cs (Is): No need to box reference values.
2428 2008-07-09 Marek Safar <marek.safar@gmail.com>
2430 * class.cs: Use event resolve context when initializing CreateEmitContext.
2432 2008-07-09 Marek Safar <marek.safar@gmail.com>
2434 A fix for bug #394436
2435 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
2436 method used inside expression trees. Added more LINQ to expression tree
2439 2008-07-08 Marek Safar <marek.safar@gmail.com>
2441 A fix for bug #378189, #370577
2442 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
2445 2008-07-08 Marek Safar <marek.safar@gmail.com>
2447 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
2450 2008-07-08 Marek Safar <marek.safar@gmail.com>
2452 A fix for bug #406702
2453 * anonymous.cs: Always park anonymous method in the nearest parent storey.
2455 2008-07-07 Marek Safar <marek.safar@gmail.com>
2457 A fix for bug #406648
2458 * cs-parser.jay: Report nullable use in mcs for some cases.
2460 2008-07-07 Marek Safar <marek.safar@gmail.com>
2462 * ecore.cs: Improved argument mismatch error messages.
2464 2008-07-07 Marek Safar <marek.safar@gmail.com>
2466 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
2468 2008-07-07 Marek Safar <marek.safar@gmail.com>
2470 * expression.cs (TypeOf): Mutate type argument.
2472 2008-07-04 Marek Safar <marek.safar@gmail.com>
2474 * class.cs: Report missing partial modifier for correct type.
2476 2008-07-04 Marek Safar <marek.safar@gmail.com>
2478 * ecore.cs, expression.cs (VariableReference): Variable property is
2481 2008-07-04 Marek Safar <marek.safar@gmail.com>
2483 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
2485 2008-07-04 Marek Safar <marek.safar@gmail.com>
2487 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
2490 2008-07-04 Marek Safar <marek.safar@gmail.com>
2492 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
2493 anonymous method storey to an instance method when only "this" is hoisted.
2495 2008-07-03 Marek Safar <marek.safar@gmail.com>
2497 A fix for bug #321615
2498 * expression.cs: Pointer comparisons use unsigned operator.
2500 2008-07-03 Marek Safar <marek.safar@gmail.com>
2502 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
2504 2008-07-02 Marek Safar <marek.safar@gmail.com>
2506 A fix for bug #404905
2507 * class.cs: Always initialize local unsafe variables.
2509 2008-06-30 Marek Safar <marek.safar@gmail.com>
2511 A fix for bug #396987
2512 * expression.cs (NewInitialize): Clear local temporary variable for next run
2514 2008-06-27 Marek Safar <marek.safar@gmail.com>
2516 A fix for bug #401020
2517 * ecore.cs: Both types and modifiers have to match for ref and out arguments
2519 2008-06-27 Marek Safar <marek.safar@gmail.com>
2521 A fix for bug #398319
2522 * cs-parser.jay: Implemented undocumented base access expression inside
2525 2008-06-26 Marek Safar <marek.safar@gmail.com>
2527 A fix for bug #404227
2528 * cs-parser.jay: Parse namespace declaration using qualified identifier.
2530 2008-06-26 Marek Safar <marek.safar@gmail.com>
2532 A fix for bug #404227
2533 * convert.cs: Fixed explicit array to interface cast.
2535 2008-06-26 Marek Safar <marek.safar@gmail.com>
2537 A fix for bug #403894
2538 * delegate.cs: Mutate DelegateInvocation type.
2540 2008-06-26 Marek Safar <marek.safar@gmail.com>
2542 A fix for bug #379348
2543 * delegate.cs: Box a load of generic parameters.
2545 2008-06-26 Marek Safar <marek.safar@gmail.com>
2547 * expression.cs: Add an array creation arguments mutate.
2549 2008-06-26 Marek Safar <marek.safar@gmail.com>
2551 A fix for bug #386068
2552 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
2555 2008-06-25 Marek Safar <marek.safar@gmail.com>
2557 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
2560 2008-06-25 Marek Safar <marek.safar@gmail.com>
2562 A fix for bug #403518
2563 * delegate.cs: Type correctly anonymous method new invocation.
2565 2008-06-24 Marek Safar <marek.safar@gmail.com>
2567 A fix for bug #394826
2568 * anonymous.cs: Fully qualify members when resolving anonymous type internal
2571 2008-06-24 Marek Safar <marek.safar@gmail.com>
2573 A fix for bug #394826
2574 * anonymous.cs, iterators.cs: Construct generic storey only when is really
2577 2008-06-24 Marek Safar <marek.safar@gmail.com>
2579 * class.cs: Clone indexer parameters for localized capturing.
2581 2008-06-24 Marek Safar <marek.safar@gmail.com>
2583 A fix for bug #402379
2584 * expression.cs: Don't crash when an object initializer resolve fails.
2586 2008-06-24 Marek Safar <marek.safar@gmail.com>
2588 A fix for bug #402888
2589 * expression.cs: Mutate conditional expression.
2591 2008-06-24 Marek Safar <marek.safar@gmail.com>
2593 A fix for bug #401012
2594 * class.cs: Keep StructLayout in shared container.
2596 2008-06-24 Marek Safar <marek.safar@gmail.com>
2598 A fix for bug #400438
2599 * decl.cs, class.cs: Only properties can be automatically implemented.
2601 2008-06-24 Marek Safar <marek.safar@gmail.com>
2603 * statement.cs (ChangeToIterator): Copy also labels.
2605 2008-06-23 Marek Safar <marek.safar@gmail.com>
2607 * ecore.cs: Pass type argument details to parent extension method.
2609 2008-06-23 Marek Safar <marek.safar@gmail.com>
2611 A fix for bug #375966
2612 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
2614 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
2616 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
2618 2008-06-22 Marek Safar <marek.safar@gmail.com>
2620 A fix for bug #394347
2621 * anonymous.cs: Cache compatible delegates as compatibility check produces
2622 a new method every time.
2624 2008-06-20 Marek Safar <marek.safar@gmail.com>
2626 * anonymous.cs: Propagate storey reference for single references.
2628 2008-06-20 Marek Safar <marek.safar@gmail.com>
2630 A fix for bug #387615
2631 * assign.cs, expression.cs: Correctly clone compound assignment.
2633 2008-06-19 Marek Safar <marek.safar@gmail.com>
2635 A fix for bug #359611, #359604
2636 * anonymous.cs: Mutate all types of hoisted parameters.
2638 2008-06-19 Marek Safar <marek.safar@gmail.com>
2640 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
2641 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
2642 expression.cs, codegen.cs, statement.cs
2644 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
2645 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
2647 ** Anonymous methods, lambda expressions rewrite **
2649 Anonymous expressions are now resolved when an explicit block is resolved
2650 and they don't require any registration procedure anymore. Further,
2651 anonymous methods are defined when explicit block is emitted which allows
2652 better control of whole process and opens possibilities for more
2653 optimizations as well as alternative to reverse whole process.
2655 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
2656 process consistent and to correctly emit hoisted generic methods when they
2657 have at least 1 hoisted variable.
2659 2008-06-17 Martin Baulig <martin@ximian.com>
2661 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
2663 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
2664 virtual property; check it in Emit().
2665 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
2667 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
2669 (Indexer.Define): Likewise.
2671 2008-06-17 Marek Safar <marek.safar@gmail.com>
2673 * convert.cs: Don't use IsInterface on type arguments.
2675 * delegate.cs: DelegateInvocation uses MethodInfo.
2677 * parameter.cs: Removed IsTypeParameter.
2679 * generic-mcs.cs: More missing stuff.
2681 2008-06-16 Martin Baulig <martin@ximian.com>
2684 (Modifiers.DEBUGGER_HIDDEN): New public const.
2687 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
2690 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
2691 (AbstractPropertyEventMethod): Likewise.
2692 (Constructor.Emit): Likewise.
2693 (SourceMethod.SetCompilerGenerated): Removed.
2695 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
2699 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
2700 if we're an `IteratorHost'.
2701 (AnonymousMethodMethod..ctor): Don't set
2702 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
2705 2008-06-16 Marek Safar <marek.safar@gmail.com>
2707 * statement.cs: Clean-up foreach statements.
2709 2008-06-12 Marek Safar <marek.safar@gmail.com>
2711 * class.cs: Stop using public method which should not exist
2712 (MethodBuilder.SetGenericMethodSignature).
2714 2008-06-11 Martin Baulig <martin@ximian.com>
2717 (Location.LookupFile): Add `CompilationUnit' argument; when given
2718 a relative file name, make it relative to the directory the .cs
2719 file is located in instead of using the current directory.
2721 2008-06-11 Martin Baulig <martin@ximian.com>
2724 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
2725 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
2726 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
2727 (SourceMethod.SetCompilerGenerated): Likewise.
2729 2008-06-11 Marek Safar <marek.safar@gmail.com>
2731 * codegen.cs, driver: Only write symbol file when it's asked for.
2733 2008-06-11 Marek Safar <marek.safar@gmail.com>
2735 * codegen.cs: Don't use assembly writer error handling for symbol writer.
2737 2008-06-10 Martin Baulig <martin@ximian.com>
2739 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
2741 2008-06-09 Marek Safar <marek.safar@gmail.com>
2743 A fix for bug #316290
2744 * expression.cs: Include decimal operators in predefined table.
2746 * parameters.cs: More readonlyness.
2748 2008-06-09 Marek Safar <marek.safar@gmail.com>
2750 A fix for bug #397213
2751 * cs-parser.jay: One more missing current_local_parameters reset.
2753 2008-06-09 Marek Safar <marek.safar@gmail.com>
2755 A fix for bug #396633
2756 * class.cs: Host backing field in partial container.
2758 2008-06-09 Marek Safar <marek.safar@gmail.com>
2760 A fix for bug #397068
2761 * expression.cs: Check both operand types when predefined operator is used.
2763 2008-06-05 Martin Baulig <martin@ximian.com>
2765 Merged the `debugger-kahalo' branch.
2768 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
2769 we're an iterator method.
2770 (SourceMethod): Reflect latest symbol writer changes;
2771 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
2772 now `start_row' and `end_row'.
2773 (Constructor.Emit): Fix the logic whether to emit symbol information.
2775 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
2779 (CompilationUnit): New public class; derives from `SourceFile'.
2780 (SourceFileEntry.DefineSymbolInfo): New public method.
2781 (SourceFileEntry.SetChecksum): New public method.
2782 (Location): Encode hidden line numbers by using `column == 255';
2783 the .ctor now accepts `column == -1' to mark a hidden line number.
2784 (Location.Hidden): New public property.
2785 (Location.CheckPoint): Add `CompilationUnit'.
2786 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
2787 (Location.Push): Add `CompilationUnit compile_unit' argument.
2788 (Location.CompilationUnit): New public property.
2791 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
2793 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
2795 * driver.cs: `SourceFile' -> `CompilationUnit'.
2797 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
2799 * namespace.cs: `SourceFile' -> `CompilationUnit'.
2801 * cs-tokenizer.cs: Add support for `#pragma checksum' and
2805 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
2806 new symbol writer API to also pass the file.
2808 2008-06-05 Marek Safar <marek.safar@gmail.com>
2810 * statement.cs: Emit catch variable assignment using variable expression.
2812 2008-06-05 Marek Safar <marek.safar@gmail.com>
2814 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
2815 with other variable types.
2817 2008-06-04 Marek Safar <marek.safar@gmail.com>
2819 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
2820 GetLength method emit, it breaks resolve rules.
2822 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
2823 Marek Safar <marek.safar@gmail.com>
2825 A fix for bug #395542
2826 * cs-parser.jay: The trailing comma is allowed in anonymous type member
2829 2008-06-02 Marek Safar <marek.safar@gmail.com>
2831 A fix for bug #395287
2832 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
2834 2008-05-31 Marek Safar <marek.safar@gmail.com>
2836 A fix for bug #395845
2837 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
2838 non-nullable parameter type.
2840 2008-05-31 Marek Safar <marek.safar@gmail.com>
2842 * class.cs: Handle contructor initializer as a statement in top-level block.
2844 2008-05-30 Marek Safar <marek.safar@gmail.com>
2846 * attribute.cs: Don't mix old and new corlib types when emitting corlib
2847 security attributes.
2849 2008-05-24 Marek Safar <marek.safar@gmail.com>
2851 * ecore.cs, expression.cs: Small IVariable refactoring.
2853 2008-05-22 Marek Safar <marek.safar@gmail.com>
2855 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
2857 2008-05-21 Marek Safar <marek.safar@gmail.com>
2859 * cs-parser.jay: Removed redundant catch type check.
2861 2008-05-21 Marek Safar <marek.safar@gmail.com>
2863 A fix for bug #390372
2864 * nullable.cs: Set correct return type.
2866 2008-05-21 Marek Safar <marek.safar@gmail.com>
2868 A fix for bug #391062
2869 * typemanager.cs: Fixed crash when comparing null types.
2871 2008-05-21 Marek Safar <marek.safar@gmail.com>
2873 A fix for bug #391871
2874 * cs-parser.jay: Better error handling for invalid catch type.
2876 2008-05-20 Marek Safar <marek.safar@gmail.com>
2878 A fix for bug #392155
2879 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
2881 2008-05-15 Marek Safar <marek.safar@gmail.com>
2883 A fix for bug #390666
2884 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
2887 2008-05-15 Marek Safar <marek.safar@gmail.com>
2889 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
2892 2008-05-13 Marek Safar <marek.safar@gmail.com>
2894 A fix for bug #389625
2895 * delegate.cs, generic.cs: Some progress on method group return type
2898 2008-05-13 Marek Safar <marek.safar@gmail.com>
2900 A fix for bug #378419
2901 * namespace.cs: Inspect also parent namespaces not only namespace entries.
2903 2008-05-12 Marek Safar <marek.safar@gmail.com>
2905 * class.cs (Constructor): Added IsCompilerGenerated.
2907 2008-05-12 Marek Safar <marek.safar@gmail.com>
2909 * expression.cs: Enum binary operators can accept non-enum operand only when
2910 is implicitly convertible to underlying type.
2912 2008-05-12 Marek Safar <marek.safar@gmail.com>
2914 A fix for bug #389272
2915 * support.cs: Workaround System.InvalidOperationException for enums.
2917 2008-05-12 Marek Safar <marek.safar@gmail.com>
2919 A fix for bug #389073
2920 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
2922 2008-05-10 Marek Safar <marek.safar@gmail.com>
2924 * driver.cs: Split Parse.
2926 * location.cs (LookupFile): Uses string.Empty.
2928 2008-05-07 Marek Safar <marek.safar@gmail.com>
2930 * expression.cs, parameter.cs: Small ParameterReference clean up.
2932 2008-05-07 Marek Safar <marek.safar@gmail.com>
2934 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
2935 hack. Fixes #387502.
2937 2008-05-06 Martin Baulig <martin@ximian.com>
2939 * class.cs (Constructor.Emit): Fix the logic whether to emit
2942 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
2945 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
2946 InvalidOperationException when the iterator is before the start or
2949 2008-05-06 Marek Safar <marek.safar@gmail.com>
2951 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
2952 when left is nullable type.
2954 2008-05-06 Marek Safar <marek.safar@gmail.com>
2956 A fix for bug #386628
2957 * expression.cs (LocalVariableReference): Continue in resolving when
2958 variable is not assigned.
2960 2008-05-05 Marek Safar <marek.safar@gmail.com>
2962 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
2963 nullable operations.
2965 2008-05-04 Marek Safar <marek.safar@gmail.com>
2967 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
2968 it saves many redundant temporary variables for nullable operations.
2970 2008-05-03 Marek Safar <marek.safar@gmail.com>
2972 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
2974 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
2977 * nullable.cs: Constant coalescing operator optimizations.
2979 2008-05-03 Marek Safar <marek.safar@gmail.com>
2981 * constant.cs: Use unsigned conversion for values which are unsigned only.
2983 2008-05-03 Marek Safar <marek.safar@gmail.com>
2985 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
2986 coalescing operator as it should be.
2988 2008-05-02 Marek Safar <marek.safar@gmail.com>
2990 A fix for bug #371016
2991 * expression.cs: All predefined delegate operators require implicit method
2994 2008-05-02 Marek Safar <marek.safar@gmail.com>
2996 * constant.cs: Emit long constant as uint when fits the range.
2998 * convert.cs, expression.cs: Fixed few unsafe conversions.
3000 2008-05-02 Marek Safar <marek.safar@gmail.com>
3002 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
3004 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
3007 * convert.cs (ImplicitNumericConversion): Don't modify the type of
3009 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
3011 2008-05-01 Marek Safar <marek.safar@gmail.com>
3013 * constant.cs, literal.cs: IsLiteral property for error reporting.
3015 * ecore.cs, expression.cs: Implemented Property expression.
3017 2008-05-01 Marek Safar <marek.safar@gmail.com>
3019 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
3021 * nullable.cs: Implemented nullable coalescing null operator.
3023 * ecore.cs, expression.cs: Expression trees work.
3025 2008-05-01 Marek Safar <marek.safar@gmail.com>
3027 * ecore.cs: CreateExpressionTree is finally abstract.
3029 * expression.cs, linq.cs: Updated.
3031 2008-05-01 Marek Safar <marek.safar@gmail.com>
3033 * expression.cs, ecore.cs: Block base access expression inside expression
3036 2008-05-01 Marek Safar <marek.safar@gmail.com>
3038 A fix for bug #385058
3039 * expression.cs: User-defined operator implementations always take
3040 precedence over predefined operator implementations.
3042 2008-04-30 Marek Safar <marek.safar@gmail.com>
3044 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
3045 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
3046 expression tree conversions.
3048 2008-04-30 Marek Safar <marek.safar@gmail.com>
3050 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
3051 operators method details to Operator class.
3053 2008-04-30 Marek Safar <marek.safar@gmail.com>
3055 * anonymous.cs: Pass unsafe flags to anonymous container.
3057 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
3058 inside expression tree.
3060 2008-04-29 Martin Baulig <martin@ximian.com>
3062 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
3063 (Tokenizer.PopPosition): Also restore the `line'.
3065 2008-04-29 Marek Safar <marek.safar@gmail.com>
3067 * delegate.cs: Implemented Invoke expression.
3069 2008-04-29 Marek Safar <marek.safar@gmail.com>
3071 * expression.cs: Fixed equality reference comparison regression.
3073 2008-04-29 Marek Safar <marek.safar@gmail.com>
3075 * ecore.cs: Clean up EmptyCast hack.
3077 * expression.cs, nullable.cs: Implemented enum binary and unary operations
3078 using correct conversion rules. Also fixes #383993.
3080 2008-04-28 Martin Baulig <martin@ximian.com>
3082 * class.cs (Constructor.Emit): Don't emit debugging information
3083 for generated default .ctor's.
3085 2008-04-28 Marek Safar <marek.safar@gmail.com>
3087 * convert.cs: Empty-cast ushort to int conversion.
3089 2008-04-28 Marek Safar <marek.safar@gmail.com>
3091 A fix for bug #384191
3092 * ecore.cs, expression.cs: Fixed expression cloning.
3094 2008-04-28 Marek Safar <marek.safar@gmail.com>
3096 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
3098 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
3100 Fix #381559, test-638.cs, test-639.cs
3101 * assign.cs (CompoundAssign.Helper): New wrapper.
3102 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
3104 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
3105 Pass unconverted expressions to the params array creation expression.
3106 (FieldExpr.EmitAssign): Don't special-case StringConcat.
3107 (PropertyExpr.EmitAssign): Likewise.
3108 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
3109 element if it is of kind CompoundAssign.Helper.
3110 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
3111 first before anything else.
3112 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
3113 (ArrayAccess.LoadArrayAndArguments): Simplify.
3115 2008-04-27 Marek Safar <marek.safar@gmail.com>
3117 * expression.cs: Fixed cloning of typeof(void).
3119 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
3121 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
3122 (Assign.Emit): Likewise. Move it to ...
3123 (CompoundAssign.DoResolve): ... here and ...
3124 (CompoundAssign.Emit): ... here.
3125 (EventAddOrRemove): New helper to handle += and -= on events, and
3126 avoid the use of BinaryDelegates.
3127 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
3128 (EventExpr.EmitAddOrRemove): Improve.
3129 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
3131 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
3132 create VarExprs for 'foo.bar.var'.
3133 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
3134 is a highly inappropriate name for its functionality.
3136 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3138 Simplify handling of multiple assignments
3139 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
3141 (SimpleAssign): New. Class to be used for normal assignments.
3142 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
3143 * expression.cs, parameter.cs, statement.cs: Likewise.
3145 2008-04-25 Marek Safar <marek.safar@gmail.com>
3147 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
3148 for incompatible underlying types, more to come, uff.
3150 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3153 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
3154 Handle 'leave_copy'.
3156 2008-04-25 Marek Safar <marek.safar@gmail.com>
3158 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
3160 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
3162 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
3163 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
3164 * statement.cs (While, Do, For): Allow test to have side effects.
3165 (For.DoEmit): Always emit InitStatement.
3168 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
3169 Always create SideEffectConstant.
3170 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
3171 of type EnumConstant.
3173 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
3174 Handle 'right' being SideEffectConstant of type 'bool'.
3176 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
3177 Use left.EmitBranchable instead of open coding it, so as to
3178 improve optimization opportunities.
3180 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
3182 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
3184 (Expression.EmitSideEffect): Document.
3186 2008-04-23 Marek Safar <marek.safar@gmail.com>
3188 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
3190 2008-04-23 Marek Safar <marek.safar@gmail.com>
3192 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
3194 2008-04-23 Marek Safar <marek.safar@gmail.com>
3196 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
3197 conversion to expression tree.
3199 2008-04-23 Marek Safar <marek.safar@gmail.com>
3201 * ecore.cs: Removed unused expression.
3203 2008-04-22 Marek Safar <marek.safar@gmail.com>
3205 * expression.cs: Implemented NegateChecked and New expressions.
3207 2008-04-22 Marek Safar <marek.safar@gmail.com>
3209 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
3211 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
3214 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
3215 needing final 'ret' instruction.
3217 2008-04-22 Marek Safar <marek.safar@gmail.com>
3219 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
3221 2008-04-21 Marek Safar <marek.safar@gmail.com>
3223 * expression.cs: Emit ldnull and not null expression as an instance argument
3224 of static method expression calls.
3226 2008-04-21 Marek Safar <marek.safar@gmail.com>
3228 A fix for bug #378200
3229 * expression.cs: Fixed crash when creating parameterless expression tree
3232 2008-04-21 Marek Safar <marek.safar@gmail.com>
3234 A fix for bug #375297
3235 * anonymous.cs: Fixed crash when inferring from null argument anonymous
3238 2008-04-21 Marek Safar <marek.safar@gmail.com>
3240 A fix for bug #377596
3241 * decl.cs, class.cs: Emit delegate type argument attributes.
3243 2008-04-21 Marek Safar <marek.safar@gmail.com>
3245 A fix for bug #365314
3246 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
3248 2008-04-21 Marek Safar <marek.safar@gmail.com>
3250 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
3253 2008-04-21 Marek Safar <marek.safar@gmail.com>
3255 * generic.cs (TypeParameter): Removed redundant location.
3257 2008-04-19 Marek Safar <marek.safar@gmail.com>
3259 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
3260 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
3261 FullNamedExpression in all declaration type expression, statements will come
3264 2008-04-18 Marek Safar <marek.safar@gmail.com>
3266 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
3267 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
3269 2008-04-18 Marek Safar <marek.safar@gmail.com>
3271 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
3274 2008-04-17 Marek Safar <marek.safar@gmail.com>
3276 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
3279 2008-04-17 Marek Safar <marek.safar@gmail.com>
3281 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
3285 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
3287 Hook up 'EmitSideEffect'
3288 * constant.cs (Constant.EmitSideEffect): New.
3289 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
3290 (SideEffectConstant.EmitSideEffect): New.
3291 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
3292 unconditional branch in EmitBranchable.
3293 (FieldExpr.EmitBranchable): New.
3294 * expression.cs (Unary.EmitSideEffect): New.
3295 (Binary.EmitSideEffect): New.
3296 (VariableReference.EmitSideEffect): New. Do nothing.
3298 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
3300 Introduce 'EmitSideEffect'
3301 * ecore.cs (Expression.EmitSideEffect): New.
3302 (TypeCast): Rename from EmptyCast.
3304 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
3305 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
3306 * convert.cs, nullable.cs: Update to changes.
3308 2008-04-16 Marek Safar <marek.safar@gmail.com>
3310 * class.cs, cs-parser.jay: Early check for base types expression.
3312 2008-04-16 Marek Safar <marek.safar@gmail.com>
3314 * decl.cs (MemberName): Declare PrettyName as obsolete.
3316 2008-04-16 Marek Safar <marek.safar@gmail.com>
3318 * namespace.cs: Use MemberName comparison.
3320 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
3323 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
3325 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
3326 (MemberName.FullyQualifiedName): New. Provides the functionality
3327 that users assume FullName would have.
3328 * ecore.cs, namespace.cs: Update to changes.
3330 * statement.cs (Using.assign): Make into ExpressionStatement.
3331 (Using.EmitPreTryBody): Simplify.
3333 2008-04-16 Marek Safar <marek.safar@gmail.com>
3335 * report.cs: ColorFormat is protected.
3337 * rootcontext.cs: Unused fields clean-up.
3339 * namespace.cs: Made UsingEntry name private.
3341 2008-04-16 Marek Safar <marek.safar@gmail.com>
3343 * cs-tokenizer.cs, location.cs: Removed unused field.
3345 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
3346 Raja R Harinath <harinath@hurrynot.org>
3349 * constant.cs (SideEffectConstant.value): Rename from 'left'.
3350 (SideEffectConstant.side_effect): Rename from 'right'.
3351 (SideEffectConstant..ctor): Normalize 'side_effect'.
3352 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
3353 value of this constant.
3354 * cfold.cs: Update to changes.
3356 2008-04-15 Marek Safar <marek.safar@gmail.com>
3358 * cs-paser.jay: Removed unused variable.
3360 * driver.cs: Made Compile instance method.
3362 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
3364 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
3366 2008-04-15 Marek Safar <marek.safar@gmail.com>
3368 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
3370 2008-04-13 Jb Evain <jbevain@novell.com>
3372 * namespace.cs: update the System.Core fullname for 2.1
3373 * driver.cs: update the list of required assemblies for 2.1.
3374 Merged from the Moonlight 2 branch.
3376 2008-04-11 Marek Safar <marek.safar@gmail.com>
3378 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
3379 types and user defined operators. User operators arguments has to be checked
3380 for null value before invocation, which also means no operator is called
3381 when any argument is not convertible to unwrapped nullable type.
3383 2008-04-09 Marek Safar <marek.safar@gmail.com>
3385 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
3386 of Unary expressions to follow operator overloading rules precisely.
3387 Also fixes #321794, #323794
3389 2008-04-08 Marek Safar <marek.safar@gmail.com>
3391 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
3394 2008-04-08 Marek Safar <marek.safar@gmail.com>
3396 * expression.cs, ecore.cs: Implemented MemberInit expression.
3398 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
3400 Fix mono/tests/exception4.cs
3401 * statement.cs (ExceptionStatement, TryCatch): Revert to using
3402 ec.NeedReturnLabel () rather emitting a 'nop'.
3404 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
3406 (TryCatch.SomeCodeFollows): Likewise.
3407 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
3408 for 'break', 'continue' and 'return' statements inside a try.
3409 We're fairly sure that the generated IL stream will have more
3410 instructions textually following the try.
3411 (FlowBranchingTryCatch): Likewise.
3413 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
3414 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
3417 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
3418 wrapper -- forward everything to CollectionForeach.
3419 (CollectionForeach.NonDisposableWrapper): New.
3420 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
3421 instead of a pop + branch to end.
3423 2008-04-07 Marek Safar <marek.safar@gmail.com>
3425 A fix for bug #377485
3426 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
3427 Propagate location for extension method groups. Report conversion failure at
3430 2008-04-07 Marek Safar <marek.safar@gmail.com>
3432 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
3433 ListInit and Field expressions.
3435 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
3437 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
3438 Since $PC is always -1 inside the body of MoveNext, the fault
3440 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
3441 * statement.cs (ExceptionStatement.emit_finally): Likewise.
3442 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
3444 The denouement! Fix #324708
3445 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
3446 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
3447 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
3448 'finally' inside the finally clause.
3450 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
3451 inside an iterator. Don't emit the body of the 'finally' inside
3452 the finally clause yet.
3454 Use the ResumableStatement infrastructure for MoveNext ()
3455 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
3456 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
3457 'old_resume_points'. Move dispatcher upfront.
3458 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
3459 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
3460 in an enumerator. This encodes the main fix in this patch series
3461 -- we can only jump into the first instruction of a try from the
3462 outside, but we want to emit try/finally regions in iterators and
3463 resume in the middle of them.
3465 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
3467 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
3468 of NeedReturnLabel here.
3470 Introduce a common point for emitting try/finally to IL
3471 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
3472 features of the various subclasses, which are now driven by ...
3473 (ExceptionStatement.EmitPreTryBody): ... this and ...
3474 (ExceptionStatement.EmitTryBody): ... this and the original
3476 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
3477 Remove DoEmit and update to follow above protocol.
3479 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
3480 of the dispatcher are the same, skip emitting the 'switch'.
3481 * iterator.cs (Iterator.EmitDispose): Update to changes.
3483 Clean up handling of 'using' statement
3484 * statement.cs (UsingTemporary): New. Carved out of ...
3485 (Using): ... this. Simplify drastically. Handle exactly
3487 * cs-parser.jay (using_statement): Split. Create UsingTemporary
3488 or Using as appropriate. If there are multiple variable declared,
3489 create nested Using statements.
3490 (resource_acquisition): Kill.
3492 * statement.cs (ExceptionStatement.EmitForDispose): Use
3493 EmitFinallyBody, not EmitFinally.
3495 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
3496 * iterator.cs: Update to changes.
3498 Start using the ResumableStatement infrastructure
3499 * statement.cs (ResumeableStatement.PrepareForDispose): New.
3500 (ResumableStatement.EmitForDispose): New.
3501 (ExceptionStatement): Override them.
3502 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
3503 EmitForDispose to create the body of the Dispose method. Don't
3506 * iterator.cs (Iterator.AddResumePoint): Move here from ...
3507 * statement.cs (Toplevel.AddResumePoint): ... here.
3508 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
3509 * flowanalysis.cs (FlowBranchingIterator): New.
3510 * codegen.cs (EmitContext): Update to changes.
3512 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
3513 (Iterator.old_resume_points): Rename from 'resume_points'.
3514 (Iterator.MoveNextStatement): Remove unused class.
3516 New infrastructure for try/finally in iterators (still unused)
3517 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
3518 (FlowBranchingToplevel.AddResumePoint): Hook into
3519 ToplevelBlock.AddResumePoint.
3520 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
3521 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
3522 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
3523 resume points and assign program-counter values.
3524 (ExceptionBlock.AddResumePoint): Collect resume points for
3525 de-muxer at the top of try block.
3526 * iterators.cs (Yield.CheckContext): Simplify.
3527 (Yield.Resolve): Use FlowBranching.AddResumePoint.
3529 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
3531 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
3532 argument to an ExitStatement.
3533 (FlowBranchingException): Refactor saved origins code.
3534 * statement.cs (ExitStatement): Update to cahges.
3535 * iterator.cs (YieldBreak): Likewise.
3537 * statement.cs (ResumableStatement): New. Common base class for
3538 YieldReturn and ExceptionStatement.
3539 (ExitStatement): New. Common base class for Return and YieldBreak.
3540 (Return): Update to changes.
3541 * iterator.cs (YieldBreak): Likewise.
3542 * lambda.cs (ContextualReturn): Likewise.
3545 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
3546 emit a meaningful error message.
3548 Fix #324765, #319508
3549 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
3550 (VariableInfo.SetAssigned): Set it.
3551 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
3552 determine if CS0219 or CS0168 is appropriate. Don't use
3553 flow-analysis information.
3554 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
3555 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
3556 (EmitContext.EndFlowBranching): ... this.
3558 2008-04-03 Marek Safar <marek.safar@gmail.com>
3560 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
3562 2008-04-03 Marek Safar <marek.safar@gmail.com>
3564 A fix for bug #376508
3565 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
3566 ImplicitConversionExists.
3568 2008-04-03 Marek Safar <marek.safar@gmail.com>
3570 * expression.cs (Binary): Added remaining binary operators to expression
3573 * nullable.cs: Optimize shift with null argument.
3575 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
3577 Fix minor IL regression
3578 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
3579 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
3580 * cs-parser.jay (try_statement): Update to changes.
3582 * statement.cs (TryFinally.need_exc_block): Delete.
3583 (TryFinally): Update to changes.
3585 Now all ExceptionStatements are unconditional
3586 * statement.cs (CollectionForeach.DisposableWrapper): New.
3587 Extract out the try/finally code into a new wrapper.
3588 (CollectionForeach.Resolve): Use it to simplify the code.
3590 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
3592 Start at simplifying ExceptionStatement semantics a bit
3593 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
3594 * cs-parser.jay (try_statement): Update to changes.
3595 (opt_catch_clauses): Remove.
3596 * flowanalysis.cs: Update to changes.
3597 (FlowBranching.BranchingType.TryCatch): New.
3598 (FlowBranchingTryCatch): New.
3600 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
3601 (FlowBranching.CreateBranching): Update to changes.
3602 (FlowBranchingBlock.AddSibling): Add sanity check.
3603 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
3606 * iterators.cs (Iterator.MarkFinally): Remove.
3607 * statement.cs (ExceptionStatement): Update to changes.
3609 Add support for skipping over finally blocks at runtime. First
3610 in a series to fix #324708
3611 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
3612 (Iterator.EmitMoveNext): Initialize it.
3613 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
3614 branch over the body of the 'finally' clause.
3616 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
3618 Avoid lopsided use of Foo/DoFoo names
3619 * statement.cs (ExpressionStatement.EmitFinallyBody):
3620 Rename from EmitFinally.
3621 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
3622 * iterator.cs: Update to changes.
3624 2008-04-02 Marek Safar <marek.safar@gmail.com>
3626 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
3627 based on UserOperatorCall. More binary nullable operators clean up.
3629 2008-04-02 Martin Baulig <martin@ximian.com>
3631 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
3633 2008-04-02 Marek Safar <marek.safar@gmail.com>
3635 * nullable.cs: Merge user and empty conversions when lifting expression
3638 * expression.cs (StringConcat): Implemented expression tree representation.
3640 2008-04-01 Marek Safar <marek.safar@gmail.com>
3642 * nullable.cs: When lifting null literal and a user operator exists, no call
3645 2008-04-01 Marek Safar <marek.safar@gmail.com>
3647 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
3650 2008-04-01 Marek Safar <marek.safar@gmail.com>
3652 * nullable.cs, expression.cs: Use namespace instead heavily nested
3653 monster abstract class.
3655 2008-04-01 Marek Safar <marek.safar@gmail.com>
3657 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
3658 lifting of null literal and user operators. Clean up of some temporary
3661 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
3663 Fix #368224, test-629.cs
3664 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
3665 if it crossed an unwind-protect boundary.
3666 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
3667 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
3668 inside an unwind-protected region.
3669 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
3670 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
3671 'leave' instead of a 'br' if unwind-protected.
3672 (Iterator.EmitYieldBreak): Likewise.
3674 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
3676 * driver.cs: Only define versioninfo resources if no win32 resource
3679 2008-03-28 Marek Safar <marek.safar@gmail.com>
3681 A fix for bug #372375
3682 * convert.cs: Fixed boxing of nullable types.
3684 2008-03-28 Marek Safar <marek.safar@gmail.com>
3686 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
3689 2008-03-28 Marek Safar <marek.safar@gmail.com>
3691 A fix for bug #374619
3692 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
3694 2008-03-27 Marek Safar <marek.safar@gmail.com>
3696 * lambda.cs: Check return type only for invocation.
3698 2008-03-27 Marek Safar <marek.safar@gmail.com>
3700 A fix for bug #374214
3701 * ecore.cs: Correctly report argument type mismatch.
3703 2008-03-27 Marek Safar <marek.safar@gmail.com>
3705 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
3706 and not rely on broken IsEnum.
3708 2008-03-27 Marek Safar <marek.safar@gmail.com>
3710 * nullable.cs: New file, extracted from generic.cs.
3712 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
3714 2008-03-27 Marek Safar <marek.safar@gmail.com>
3716 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
3717 predefined comparison operators and null literals.
3719 * report.cs: New warning ID.
3721 2008-03-25 Marek Safar <marek.safar@gmail.com>
3723 A fix for bug #370577
3724 * lambda.cs: Check return type too.
3726 2008-03-25 Marek Safar <marek.safar@gmail.com>
3728 A fix for bug #372846
3729 * class.cs: Automatic properties can be declared as unsafe.
3731 2008-03-20 Marek Safar <marek.safar@gmail.com>
3733 * location.cs: Use string based concatenation.
3735 * expression.cs: LiftedBinaryOperator is gmcs only.
3737 2008-03-20 Marek Safar <marek.safar@gmail.com>
3739 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
3740 conversions rules and expression trees.
3742 2008-03-19 Marek Safar <marek.safar@gmail.com>
3744 * delegate.cs: Use extension method source as delegate target.
3746 2008-03-19 Marek Safar <marek.safar@gmail.com>
3748 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
3749 binary operations to be purely based on binary operations and optimized
3750 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
3751 and other ET refactoring.
3753 * typemanager.cs: Fixed warning.
3755 2008-03-17 Marek Safar <marek.safar@gmail.com>
3757 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
3759 * symbolwriter.cs: Fixed.
3761 2008-03-17 Marek Safar <marek.safar@gmail.com>
3763 * anonymous.cs, driver.cs: Reset anonymous types counters.
3765 2008-03-17 Marek Safar <marek.safar@gmail.com>
3767 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
3769 * class.cs: Use fullname for all type member definitions.
3771 2008-02-19 Martin Baulig <martin@ximian.com>
3774 (IMethodData.EmitExtraSymbolInfo): New interface method.
3775 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
3776 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
3777 interface method here as an empty public virtual method.
3780 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
3781 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
3782 CodeGen.SymbolWriter.SetRealMethodName().
3784 2008-02-18 Martin Baulig <martin@ximian.com>
3787 (ScopeInfo.EmitType): Override this and emit debugging
3788 information for captured variables.
3789 (RootScopeInfo.EmitType): Override this and emit symbol
3790 information for a captured `this'.
3792 2008-02-15 Martin Baulig <martin@ximian.com>
3794 * iterators.cs: Emit debugging info.
3797 (EmitContext.Flags): Add `OmitDebuggingInfo'.
3798 (EmitContext.OmitDebuggingInfo): New public property.
3801 (While): Override Emit() and don't emit symbol info there; do it
3802 inside DoEmit() instead.
3803 (Block.Emit): Omit symbol information while emitting the scope
3804 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
3806 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
3807 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
3808 .ctor to make `IsIterator' work.
3810 2008-03-14 Martin Baulig <martin@ximian.com>
3812 * symbolwriter.cs: Added the new symbol writer function from the
3813 debugger's `terrania' branch; temporarily enclose them inside
3814 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
3817 2008-03-14 Martin Baulig <martin@ximian.com>
3820 (SymbolWriter): Make this a public static class.
3823 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
3824 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
3826 2008-03-14 Marek Safar <marek.safar@gmail.com>
3828 A fix for bug #370577
3829 * statement.cs, lambda.cs: Added extra limitations when dealing with void
3832 2008-03-14 Marek Safar <marek.safar@gmail.com>
3834 * typemanager.cs (CSharpName): Made 250 times faster.
3836 2008-03-13 Marek Safar <marek.safar@gmail.com>
3838 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
3840 2008-03-12 Marek Safar <marek.safar@gmail.com>
3842 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
3843 crash when predefined field does not exist.
3845 2008-03-12 Marek Safar <marek.safar@gmail.com>
3847 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
3849 2008-03-12 Marek Safar <marek.safar@gmail.com>
3851 * class.cs (FixedField): Don't crash when contructors are missing.
3853 2008-03-11 Marek Safar <marek.safar@gmail.com>
3855 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
3856 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
3857 check internal types accessibility for internal and external types.
3858 Replaced EnumToUnderlying by GetEnumUnderlyingType.
3860 2008-03-11 Marek Safar <marek.safar@gmail.com>
3862 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
3863 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
3864 attribute.cs, statement: Use corect instance of predefined types (work
3865 related to #364674).
3867 2008-03-07 Marek Safar <marek.safar@gmail.com>
3869 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
3871 2008-03-07 Marek Safar <marek.safar@gmail.com>
3873 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
3874 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
3875 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
3876 predefined types clean up, delayed predefined types members initialization
3877 (work related to #364674).
3879 2008-03-05 Marek Safar <marek.safar@gmail.com>
3881 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
3883 2008-03-05 Marek Safar <marek.safar@gmail.com>
3885 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
3886 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
3887 predefined types clean up (work related to #364674).
3889 2008-03-04 Marek Safar <marek.safar@gmail.com>
3891 * ecore.cs: Print an error message instead of throwing exception.
3893 2008-03-04 Marek Safar <marek.safar@gmail.com>
3895 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
3896 expression.cs, statement.cs: Unififed null literal representation.
3898 2008-03-03 Marek Safar <marek.safar@gmail.com>
3900 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
3901 expression.cs: Refactored binary operators resolve phase and improved speed.
3902 The nullable code is still missing and won't work correctly, more fixes
3905 It also fixes #323726, #324312, #324248, and many other unreported issues.
3907 2008-02-29 Zoltan Varga <vargaz@gmail.com>
3909 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
3912 2008-02-27 Marek Safar <marek.safar@gmail.com>
3914 * ecore.cs: Clean-up and split BetterConversion.
3916 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
3919 * enum.cs (EnumMember.Value): Only access 'value' if
3920 ResolveValue says it's ok.
3921 (EnumMember.DoResolveValue): Don't set prev_member.value.
3922 (Enum.GetDefinition): Reverse arguments of Equals --
3923 EnumMember.Value can return 'null'.
3925 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
3927 2008-02-22 Marek Safar <marek.safar@gmail.com>
3929 * generic.cs, expression.cs: More ongoing work on expression trees.
3931 2008-02-21 Marek Safar <marek.safar@gmail.com>
3933 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
3934 handle missing matches when mutiple operators exist.
3936 2008-02-20 Marek Safar <marek.safar@gmail.com>
3938 A fix for bug #363218
3939 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
3942 2008-02-20 Marek Safar <marek.safar@gmail.com>
3944 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
3945 update. This time to deal correctly with SideEffectConstant expression used
3946 as an argument for another constant folding.
3948 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
3950 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
3953 2008-02-19 Marek Safar <marek.safar@gmail.com>
3955 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
3957 2008-02-19 Marek Safar <marek.safar@gmail.com>
3959 A fix for bug #328136
3960 * expression.cs: Do not fold immediately LogicalAnd operators when the left
3961 side is a false constant, because we still need to evaluate the right-hand
3964 * statement.cs (If): Emit two types of boolean constants (simple constant,
3965 side-effect constant).
3967 2008-02-19 Marek Safar <marek.safar@gmail.com>
3969 * constant.cs (SideEffectConstant): Don't emit boolean constant.
3971 * expression.cs: Fold immediately LogicalAnd operators when both sides are
3974 2008-02-18 Marek Safar <marek.safar@gmail.com>
3976 A fix for bug #361457
3977 * ecore.cs (IsApplicable): Params methods have lower priority.
3979 * support.cs: Return correct parameter modifier for params types.
3981 2008-02-18 Marek Safar <marek.safar@gmail.com>
3983 * generic.cs (TypeParameter): Cache attribute target name.
3985 * support.cs: Removed unused variable.
3987 * typemanager.cs: Removed debugging leftover.
3989 * ecore.cs: Use local type instead of a property;
3991 * class.cs (VerifyMembers): Consider also parent to test whether type member
3994 * expression.cs (FullMethodDesc): Removed.
3996 * attribute.cs (IsValidArgumentType): Made static.
3998 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
4000 Cleanup to be more readable.
4001 * Makefile (GMCS_PROFILE): Remove.
4002 (COMPILER_NAME): New helper.
4004 2008-02-15 Miguel de Icaza <miguel@novell.com>
4006 * cs-tokenizer.cs: if a conditional expression happens inside a
4007 (...) this also means that we do not need to de-ambiguate between
4008 an parenthesized expression and a cast.
4012 * constant.cs (SideEffectConstant): a constant value that happens
4013 to have a side effect.
4015 Fixes the build regressions introduced by the fix for #359789
4017 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
4019 * expression.cs (Conditional.Emit): when emitting the ternary
4020 operator, use local variables to generate code verifiable code.
4022 The verifier cannot infer that the type on stack before the
4023 stloc.0 is executed is of type ParentB. This happens because the
4024 stack merge algorithm uses only parent types when deciding which
4025 is the common type. This is described in Part III 1.8.1.3 of ECMA
4028 This code compiled with mcs is not verifiable under MS. The MS
4029 verifier picks the first common interface of Foo and Bar, which is
4030 wrong, but doesn't use a full join type of the 2 interfaces.
4032 CSC uses a clever hack to compile such code in a verifiable
4033 way. It stores the intermediate values in a local variable with
4038 2008-02-14 Miguel de Icaza <miguel@novell.com>
4040 * expression.cs: Do not fold BitwiseAnd operators when the left
4041 side is a false constant, because we still need to evaluate the
4046 * support.cs: Instead of throwing an InternalErrorException when
4047 the position of the stream is outside the boundary of our buffer,
4048 reset the state of the reader, and restart the reading from the
4049 beginning of the file.
4051 2008-02-14 Marek Safar <marek.safar@gmail.com>
4053 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
4055 2008-02-14 Marek Safar <marek.safar@gmail.com>
4057 A fix for bug #361686
4058 * decl.cs: A protected types used inside a private class which parents
4059 derives from the protected class are accessible.
4061 2008-02-13 Marek Safar <marek.safar@gmail.com>
4063 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
4064 the parameterless constructor.
4066 2008-02-13 Marek Safar <marek.safar@gmail.com>
4068 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
4069 lookup methods to use standard member cache when doing member lookup.
4071 2008-02-12 Marek Safar <marek.safar@gmail.com>
4073 * driver.cs: Don't report full path for referenced module as assembly error.
4075 2008-02-12 Marek Safar <marek.safar@gmail.com>
4077 * Makefile: Fixed `qh' target to work on all machines.
4079 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
4080 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
4081 and HasElementType with TypeManager implementation.
4083 2008-02-08 Marek Safar <marek.safar@gmail.com>
4085 A fix for bugs #325134, #359749
4086 * expression.cs, ecore.cs: Try to resolve an extension method even if the
4087 first binds point to non-method member expression.
4089 2008-02-08 Marek Safar <marek.safar@gmail.com>
4091 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
4093 2008-02-08 Marek Safar <marek.safar@gmail.com>
4095 A fix for bugs #321394, #323028
4096 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
4097 Reworked naive IsAccessibleAs implementation to handle nested types.
4099 2008-02-05 Jb Evain <jbevain@novell.com>
4101 * class.cs: use generic type comparison for parameters
4104 2008-02-05 Marek Safar <marek.safar@gmail.com>
4106 A fix for bug #325372
4107 * class.cs: Use generic type comparison when testing method signatures.
4109 2008-02-05 Marek Safar <marek.safar@gmail.com>
4111 A fix for bug #357047
4112 * ecore.cs: Applied C# 3.0 changes to better conversion.
4114 2008-02-05 Marek Safar <marek.safar@gmail.com>
4116 A fix for bug #358374
4117 * cs-parser.jay: Correctly set modifiers for all constructor types.
4119 2008-02-04 Marek Safar <marek.safar@gmail.com>
4121 A fix for bug #355251
4122 * generic.cs: Added base class constraint based type inference.
4124 2008-02-01 Marek Safar <marek.safar@gmail.com>
4126 A fix for bug #357255
4127 * decl.cs: One more missing visibility check.
4129 2008-02-01 Marek Safar <marek.safar@gmail.com>
4131 * support.cs: Fixed broken return.
4133 2008-01-25 Marek Safar <marek.safar@gmail.com>
4135 * report.cs: Correctly reset warnings count after probing.
4137 2008-01-25 Martin Baulig <martin@ximian.com>
4140 (NamespaceEntry.SymbolFileID): Make this work again after
4141 MemberName.ToString() is gone.
4143 2008-01-25 Marek Safar <marek.safar@gmail.com>
4145 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
4148 2008-01-25 Marek Safar <marek.safar@gmail.com>
4150 * generic.cs: Use full implicit conversion for type inference fixing.
4152 2008-01-24 Marek Safar <marek.safar@gmail.com>
4154 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
4155 Fixed user operator conversions.
4157 2008-01-24 Marek Safar <marek.safar@gmail.com>
4159 * generic.cs: Do nullable type to null comparison optimization during
4162 2008-01-24 Marek Safar <marek.safar@gmail.com>
4164 A fix for bug #355163
4165 * generic.cs: Enabled l-value resolve on nullable expressions.
4167 2008-01-24 Marek Safar <marek.safar@gmail.com>
4169 A fix for bug #353986
4170 * class.cs: Ingore static ctors with parameters for any further checks.
4172 2008-01-24 Marek Safar <marek.safar@gmail.com>
4174 A fix for bug #354310
4175 * namespace.cs: Removed redundant check.
4177 2008-01-24 Marek Safar <marek.safar@gmail.com>
4179 A fix for bug #354928
4180 * expression.cs: ElementInitializers can be resolved only once.
4182 2008-01-24 Marek Safar <marek.safar@gmail.com>
4184 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
4185 Condition expressions.
4187 2008-01-23 Marek Safar <marek.safar@gmail.com>
4189 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
4191 2008-01-22 Marek Safar <marek.safar@gmail.com>
4193 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
4196 * generic.cs: Implemented coalesce expression.
4198 2008-01-22 Marek Safar <marek.safar@gmail.com>
4200 A fix for bug #355145
4201 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
4202 expression tree type inference.
4204 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
4207 * expression.cs (Binary.IsUnsignedType): Fix typo.
4209 2008-01-22 Marek Safar <marek.safar@gmail.com>
4211 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
4213 2008-01-22 Marek Safar <marek.safar@gmail.com>
4215 A fix for bug #355161
4216 * ecore.cs, expression.cs: Wider range of extension method supported
4219 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
4221 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
4222 AssemblyBuilder to operate in compiler context. Fixes mcs part of
4225 2008-01-22 Marek Safar <marek.safar@gmail.com>
4227 A fix for bug #355148
4228 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
4230 2008-01-22 Miguel de Icaza <miguel@novell.com>
4232 * expression.cs (CreateExpressionTree): Add support for or and
4233 logical or, and indent following the coding conventions.
4235 * typemanager.cs (LinqExpression): renamed from
4236 ExpressionTreeManager, for a shorter name.
4238 Use TypeManager.CoreLookupType to lookup types from our core
4239 assemblies and turn those into "Type" variables.
4241 Consumers that previously used "Namespace" and "Type" from this
4242 class should instead use the TypeExpression which is a type that
4243 is fully resolved (without involving the regular C# resolution
4246 This typically looks like this:
4248 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
4249 new MemberAccess (texpr, name, type_arguments, loc)
4251 This avoids the problem in: #355178
4253 2008-01-21 Marek Safar <marek.safar@gmail.com>
4255 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
4256 feature in parser only as we do in other cases.
4258 2008-01-21 Marek Safar <marek.safar@gmail.com>
4260 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
4261 typemanager.cs: A refactoring of params arguments to reuse existing
4262 expressions (params -> array initializer) to emit params argument instead
4263 of specialized handling.
4264 It was required by expression tree implementation and it has other benefits
4265 as well, we now apply same optimization for params arguments as we do for
4268 2008-01-18 Marek Safar <marek.safar@gmail.com>
4270 A fix for bug #353526
4271 * generic.cs: A type inference of params arguments may not required any
4272 temporary array creation.
4274 2008-01-18 Marek Safar <marek.safar@gmail.com>
4276 A fix for bug #353534
4277 * generic.cs, ecore.cs, expression.cs: A method group type inference is
4278 supported for delegates only.
4280 2008-01-18 Marek Safar <marek.safar@gmail.com>
4282 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
4283 type for more than 1 candidates.
4285 2008-01-18 Marek Safar <marek.safar@gmail.com>
4287 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
4290 2008-01-16 Marek Safar <marek.safar@gmail.com>
4292 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
4293 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
4294 operator) expressions.
4296 2008-01-16 Zoltan Varga <vargaz@gmail.com>
4298 * statement.cs: Avoid declaring an IL variable for this_variable since it is
4299 not accessed from the generated IL.
4301 2008-01-14 Marek Safar <marek.safar@gmail.com>
4303 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
4304 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
4305 statement.cs: The first expression tree implementation drop, mostly
4306 infrastructure work.
4308 2008-01-14 Marek Safar <marek.safar@gmail.com>
4310 * ecore.cs (IsNestedChild): Refactored.
4312 2008-01-11 Marek Safar <marek.safar@gmail.com>
4314 * lambda.cs: Don't use a cast on unknown expression statement.
4316 2008-01-10 Geoff Norton <gnorton@novell.com>
4318 * cs-tokenizer.cs: One more token to distinguish between method and lambda
4321 2008-01-09 Marek Safar <marek.safar@gmail.com>
4323 * doc.cs: Report better /doc crash details.
4325 2008-01-09 Marek Safar <marek.safar@gmail.com>
4327 A fix for bug #352536
4328 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
4330 2008-01-08 Marek Safar <marek.safar@gmail.com>
4332 A fix for bug #352287
4333 * ecore.cs, expression.cs: Do `this' access checking in all member access
4336 2008-01-08 Marek Safar <marek.safar@gmail.com>
4338 * rootcontext.cs, driver.cs: Switch to linq mode by default.
4340 * report.cs: Reset message stacks.
4342 2008-01-08 Marek Safar <marek.safar@gmail.com>
4344 * generic.cs (InferInPhases): Correctly calculate params position.
4346 2008-01-08 Marek Safar <marek.safar@gmail.com>
4348 * cs-tokenizer.cs: No need to parse full string when parsing lambda
4351 2008-01-07 Marek Safar <marek.safar@gmail.com>
4353 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
4355 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
4357 * driver.cs: Updated --help option.
4359 2008-01-07 Marek Safar <marek.safar@gmail.com>
4361 * generic.cs (InferParamsTypeArguments): Removed.
4362 (InferInPhases): Add params type inference.
4363 (LowerBoundInference): Fixed scoring mechanism.
4365 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
4367 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
4369 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
4370 byte array for unsigned "baked" assemblies.
4372 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
4374 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
4375 array for assemblies that are not strongnamed.
4377 2008-01-04 Marek Safar <marek.safar@gmail.com>
4379 A fix for bug #351481
4380 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
4381 declaring type for nested generic types.
4383 2008-01-04 Marek Safar <marek.safar@gmail.com>
4385 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
4386 instead of ToString.
4388 2008-01-03 Marek Safar <marek.safar@gmail.com>
4390 A fix for bug #351047
4391 * expression.cs (Binary.ResolveOperator): Allow equality operators between
4392 null and structs only when equality and inequality operators are defined
4393 either as an user-operators or predefined operators.
4395 2008-01-03 Marek Safar <marek.safar@gmail.com>
4397 A fix for bug #351047
4398 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
4400 2008-01-03 Marek Safar <marek.safar@gmail.com>
4402 A fix for bug #351257
4403 * cs-tokenizer.cs: Advance line number for '\r' correctly.
4405 2008-01-03 Marek Safar <marek.safar@gmail.com>
4407 A fix for bug #351157
4408 * class.cs (Using): Fixed yet another broken cloning.
4410 (Block): Put back more sensible default value for statements.
4412 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
4414 * codegen.cs: Allow AssemblyVersion with only major version component.
4417 2007-12-29 Marek Safar <marek.safar@gmail.com>
4419 A fix for bug #324654
4420 * class.cs: Use FullName property as member name.
4422 2007-12-28 Marek Safar <marek.safar@gmail.com>
4424 A fix for bug #342117
4425 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
4426 constructor constraint.
4428 2007-12-28 Marek Safar <marek.safar@gmail.com>
4430 A fix for bug #338273
4431 * class.cs (ProbertyBase): Access modifier checks are required for overrides
4434 2007-12-28 Marek Safar <marek.safar@gmail.com>
4436 A fix for bug #350839
4437 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
4439 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
4441 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
4444 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
4446 * statement.cs: Changed some Hashtables to use HybridDictionaries
4447 instead. It was observed that some HashTables only contained a few
4448 items in the vast majority of cases. Since HybridDictionary is
4449 more efficient on small sets (<10 elements), "known_variables"
4450 from class ExplicitBlock as well as "labels" and "constants " from
4451 class Block were changed to HybridDictionaries.
4453 Atsai results: (56216kb->54987kb)
4455 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
4458 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
4460 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
4463 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
4465 * expression.cs: foreach loop to for loop, saved on allocation of
4466 enumerator (59333kb->59141kb)
4468 * statement.cs. Changed foreach loops to for loops, saved on
4469 allocation of enumerator (59141kb->59006kb)
4471 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
4472 when constructed with no specified capacity. This was causing a
4473 few ArrayLists to allocate more memory than they would potentially
4474 need in the Block class and MemberCache class. Setting the
4475 ArrayLists to construct with a capacity of 1 saves some
4476 memory. (56216kb->55585kb)
4478 2007-12-27 Marek Safar <marek.safar@gmail.com>
4480 A fix for bug #347189 (2nd issue)
4481 * expression.cs (MemberAccess): Nested type can be found in base non-generic
4484 2007-12-27 Miguel de Icaza <miguel@novell.com>
4486 * report.cs: Do not use colors if stdout and stderr are not a
4489 2007-12-27 Marek Safar <marek.safar@gmail.com>
4491 A fix for bug #346998
4492 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
4495 2007-12-27 Marek Safar <marek.safar@gmail.com>
4497 A fix for bug #343465
4498 * class.cs: Explicit method name for nested types uses dots only.
4500 2007-12-27 Marek Safar <marek.safar@gmail.com>
4502 A fix for bug #343707
4503 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
4505 2007-12-27 Marek Safar <marek.safar@gmail.com>
4507 * ecore.cs: Report type inference errors only when arguments count matches
4510 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
4512 * expression.cs, report.cs: New warning.
4514 * typemanager.cs: Catch anonymous method type too.
4516 2007-12-23 Marek Safar <marek.safar@gmail.com>
4518 A fix for bug #346379
4519 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
4521 2007-12-23 Marek Safar <marek.safar@gmail.com>
4523 A fix for bug #347359
4524 * expression.cs (Invocation): Don't resolve already resolved expression.
4526 2007-12-23 Marek Safar <marek.safar@gmail.com>
4528 A fix for bug #347189
4529 * class.cs (FixedField): Use non-dependent code only in the define phase.
4531 2007-12-23 Marek Safar <marek.safar@gmail.com>
4533 A fix for bug #348076
4534 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
4536 2007-12-22 Marek Safar <marek.safar@gmail.com>
4538 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
4539 discovered extension methods.
4541 2007-12-22 Marek Safar <marek.safar@gmail.com>
4543 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
4546 2007-12-21 Miguel de Icaza <miguel@novell.com>
4548 * report.cs (ErrorMessage): Add support for using colors on
4549 terminals that support it.
4551 2007-12-21 Marek Safar <marek.safar@gmail.com>
4553 * ecore.cs: Use information about expanded params for error reporting.
4555 2007-12-21 Marek Safar <marek.safar@gmail.com>
4557 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
4558 and logic for params overloads.
4560 2007-12-15 Miguel de Icaza <miguel@novell.com>
4562 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
4563 as this is also created from the parser. Fixes #349034
4565 2007-12-12 Miguel de Icaza <miguel@novell.com>
4567 * statement.cs (Throw.CloneTo): it is valid to have empty
4568 expressions for throw.
4570 2007-12-03 Marek Safar <marek.safar@gmail.com>
4572 * cs-parser.jay: Set delegate constraint parsing region correctly.
4574 2007-12-03 Marek Safar <marek.safar@gmail.com>
4576 A fix for bug #345467
4577 * typemanager.cs (IsEqual): Compare generic parameters position only.
4579 2007-11-28 Marek Safar <marek.safar@gmail.com>
4581 * expression.cs (BaseAccess): Type arguments can be null.
4583 2007-11-27 Raja R Harinath <harinath@gmail.com>
4585 * statement.cs (Block.Resolve): Ensure flow-branching tree is
4586 consistent even when an error has occured.
4587 (Switch.Resolve): Likewise.
4589 2007-11-22 Marek Safar <marek.safar@gmail.com>
4591 A fix for bug #334505
4592 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
4595 2007-11-22 Marek Safar <marek.safar@gmail.com>
4597 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
4598 refactorings required to resolve extension methods correctly when mixing
4599 generics and non-generics members.
4601 2007-11-20 Marek Safar <marek.safar@gmail.com>
4603 A fix for bug #342584
4604 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
4607 2007-11-19 Marek Safar <marek.safar@gmail.com>
4609 A fix for bug #342512
4610 * delegate.cs: Use delegate argument expression when is available. Don't
4611 emit virtual call when class is sealed.
4613 2007-11-16 Marek Safar <marek.safar@gmail.com>
4615 A fix for bug #325423
4616 * assign.cs (FieldInitializer): Use resolved expression for emit.
4618 * class.cs: Print less confusing error message.
4620 2007-11-16 Marek Safar <marek.safar@gmail.com>
4622 * cs-tokenizer.cs: Removed GMCS ifdefs.
4624 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
4627 * cs-parser.jay: Disabled nullable check.
4629 * generic-mcs: Copied more generic stuff.
4631 2007-11-16 Marek Safar <marek.safar@gmail.com>
4633 * gcs-parser.jay: Merged to cs-parser.jay.
4635 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
4636 * *.csproj, *.sources: Updated to use only jay parser file.
4638 2007-11-16 Marek Safar <marek.safar@gmail.com>
4640 * gcs-parser.jay: Added nullable and default expression feature checks.
4642 2007-11-16 Marek Safar <marek.safar@gmail.com>
4644 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
4645 it fixes many TODOs and hidden bugs.
4647 * expression: Removed duplicate error check.
4649 2007-11-15 Marek Safar <marek.safar@gmail.com>
4651 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
4652 implicitly type local variable only when it is used in a declaration.
4654 2007-11-15 Marek Safar <marek.safar@gmail.com>
4656 * attribute.cs: Use CS0612 for empty strings.
4658 2007-11-14 Marek Safar <marek.safar@gmail.com>
4660 * lambda.cs, statement.cs: Contextual return may act as a statement.
4662 2007-11-14 Marek Safar <marek.safar@gmail.com>
4664 A fix for a regression cause by #324222
4665 * class.cs: Don't report unused even when it implements an interface.
4667 2007-11-13 Marek Safar <marek.safar@gmail.com>
4669 A fix for bug #341205
4670 * ecore.cs, expression.cs: Method group expression cannot do static
4671 method access with an instance reference check before overloading takes
4674 2007-11-13 Marek Safar <marek.safar@gmail.com>
4676 A fix for bug #325359
4677 * class.cs: Use predictable name for automatically generated property.
4679 2007-11-12 Marek Safar <marek.safar@gmail.com>
4681 A fix for bug #324996
4682 * expression.cs (Is): Handle case where D is nullable and T is not
4685 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
4687 2007-11-12 Marek Safar <marek.safar@gmail.com>
4689 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
4690 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
4691 Flush small error reporting changes.
4693 2007-11-09 Marek Safar <marek.safar@gmail.com>
4695 A fix for bug #324996
4696 * expression.cs: Rewrote Is expression implementation to work with
4697 generics, nullable types, anonymous method. A const result expression
4698 uses existing infrastructure instead of custom not fully-featured one.
4700 2007-11-08 Marek Safar <marek.safar@gmail.com>
4702 A fix for bug #340202
4703 * class.cs: Consider generics for volatile field.
4705 2007-11-08 Marek Safar <marek.safar@gmail.com>
4707 A fix for bug #335594
4708 * expression.cs: Use conversion rules when handling string addition.
4710 2007-11-07 Marek Safar <marek.safar@gmail.com>
4712 A fix for bug #336651
4713 * expression.cs: Fixed a crash when probing is on.
4715 2007-11-07 Marek Safar <marek.safar@gmail.com>
4717 A fix for bug #324242
4718 * covert.cs: Added a conversion from any nullable-type with an
4719 underlying enum-type to the type System.Enum.
4721 2007-11-07 Marek Safar <marek.safar@gmail.com>
4723 A fix for bug #324222
4724 * class.cs: Report all non-used event fields.
4726 2007-11-07 Marek Safar <marek.safar@gmail.com>
4728 A fix for bug #325161
4729 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
4730 qualifier for generic types.
4732 2007-11-07 Marek Safar <marek.safar@gmail.com>
4734 A fix for bug #322971
4735 * expression.cs, ecore.cs: Added intermediate result value check for
4738 2007-11-07 Marek Safar <marek.safar@gmail.com>
4740 A fix for bug #324754
4741 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
4742 when it was requested.
4744 2007-11-07 Marek Safar <marek.safar@gmail.com>
4746 A fix for bug #325101
4747 * expression.cs: Do type not value comparison for `is' expression.
4749 2007-11-07 Marek Safar <marek.safar@gmail.com>
4751 A fix for bug #320236
4752 * convert.cs: Don't apply user conversion on underlying target type.
4754 2007-11-06 Marek Safar <marek.safar@gmail.com>
4756 * expression.cs: Don't use unresolved expression for error reporting.
4758 2007-11-06 Marek Safar <marek.safar@gmail.com>
4760 A fix for bugs #337712, #324490
4761 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
4762 overloading resolution too.
4764 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
4765 the process consistent and more robust.
4767 * expression.cs, linq.cs, report.cs: Update.
4769 2007-11-02 Marek Safar <marek.safar@gmail.com>
4771 A fix for bug #332909
4772 * attribute.cs: Resolve attributes in correct context using error
4775 * rootcontext.cs: Define Obsolete attribute members as core members.
4777 2007-11-02 Marek Safar <marek.safar@gmail.com>
4779 * statement.cs: Removed unused methods.
4781 2007-10-31 Wade Berrier <wberrier@novell.com>
4783 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
4784 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
4787 2007-10-31 Marek Safar <marek.safar@gmail.com>
4789 A fix for bug #338102
4790 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
4791 methods registered as non-generics.
4793 2007-10-31 Marek Safar <marek.safar@gmail.com>
4795 A fix for bugs #337712, #324490
4796 * delegate.cs: Delegate covariance and contravariance is not allowed for
4799 2007-10-31 Marek Safar <marek.safar@gmail.com>
4801 A fix for bug #337719
4802 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
4805 2007-10-30 Marek Safar <marek.safar@gmail.com>
4807 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
4809 2007-10-29 Marek Safar <marek.safar@gmail.com>
4811 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
4814 2007-10-29 Raja R Harinath <rharinath@novell.com>
4816 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
4818 2007-10-29 Marek Safar <marek.safar@gmail.com>
4820 A fix for bug #334652
4821 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
4822 extension methods when we have not found the best candidate in normal
4825 2007-10-27 Marek Safar <marek.safar@gmail.com>
4827 * AssemblyInfo.cs: Keep up-to-date.
4829 2007-10-27 Marek Safar <marek.safar@gmail.com>
4831 * Makefile: Fixed generics compiler name.
4833 2007-10-27 Marek Safar <marek.safar@gmail.com>
4835 * lambda.test: removed, lambda parsing is done differently.
4837 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
4839 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
4841 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
4843 2007-10-27 Marek Safar <marek.safar@gmail.com>
4845 * Makefile, *.sources : All C# compilers are in mcs folder.
4847 * *.cs: Use existing 2_1 define for smcs.
4849 2007-10-26 Marek Safar <marek.safar@gmail.com>
4851 A fix for bug #335847
4852 * assign.cs, expression.cs: Couple of changes to avoid creating a
4853 temporary variable for each object initializer assignment statement. It
4854 simplifies struct initialization too, otherwise two temporary variables
4856 Implemented optimization of redundant default element initializers.
4858 2007-10-25 Marek Safar <marek.safar@gmail.com>
4860 A fix for bug #336766
4861 * expression.cs (Class.CheckBase): Use generic name when method is
4864 2007-10-25 Marek Safar <marek.safar@gmail.com>
4866 A fix for bug #334737
4867 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
4868 variable and not variable argument for prepared copies.
4870 2007-10-24 Marek Safar <marek.safar@gmail.com>
4872 A fix for bug #325110
4873 * class.cs, expression.cs, attribute.cs: Use open generic method when
4874 checking conditional attribute.
4876 2007-10-24 Marek Safar <marek.safar@gmail.com>
4878 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
4879 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
4880 FeatureIsNotAvailable.
4882 2007-10-24 Marek Safar <marek.safar@gmail.com>
4884 ** C# 3.0 Partial methods
4886 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
4887 methods support. Because of member cache issue with generics only
4888 non-generics partial methods are fully supported.
4890 2007-10-23 Marek Safar <marek.safar@gmail.com>
4892 * class.cs, decl.cs: Rewrote member overloads check to cope with
4893 generics and to use member cache for member checking. It also improves
4894 performance and fixes remaining overloads issues.
4896 2007-10-20 Marek Safar <marek.safar@gmail.com>
4898 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
4899 roottypes.cs, typemanager.cs:
4901 A member cache creation logic changed to add members immediately and
4902 not rely on fallback. The member cache is now only prefered way
4903 how to access and find type declaration members. It saves 5 MB of memory
4904 during MWF compilation and makes code ready for more optimizations and
4905 clean-ups, it's also a pre-requirement for partial methods.
4907 2007-10-18 Raja R Harinath <harinath@gmail.com>
4909 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
4910 handling for generic parameters.
4912 2007-10-15 Marek Safar <marek.safar@gmail.com>
4914 * class.cs (FixedField): Removed redundant volatile check.
4916 2007-10-15 Marek Safar <marek.safar@gmail.com>
4918 * class.cs, decl.cs: Fixed overload members verification to do only one
4919 check per possible collision.
4921 2007-10-13 Marek Safar <marek.safar@gmail.com>
4923 A fix for bug #325478
4924 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
4925 and create only one disposable flags container.
4927 2007-10-12 Marek Safar <marek.safar@gmail.com>
4929 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
4930 * statement.cs (Fixed): Fixed variables cloning.
4932 2007-10-12 Marek Safar <marek.safar@gmail.com>
4934 A fix for bug #333342
4935 * class.cs (EventField): Don't mark value type event as synchronized.
4937 2007-10-12 Marek Safar <marek.safar@gmail.com>
4939 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
4940 inference to identify best candidate method correctly.
4941 (ProperyExpr): A range variable is read only and cannot be modified.
4943 2007-10-11 Marek Safar <marek.safar@gmail.com>
4945 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
4946 logic to identify best candidate method correctly.
4948 2007-10-11 Marek Safar <marek.safar@gmail.com>
4950 * location.cs (Equals, GetHashCode): Removed.
4952 2007-10-11 Marek Safar <marek.safar@gmail.com>
4954 * report.cs: Implemented message recorder. It is used mainly for lambda
4955 expressions to capture otherwise swallowed error messages.
4957 * anonymous.cs, lambda.cs.cs: Do full parameters check.
4959 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
4961 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
4963 * expression.cs (MemberAccess): Always report lookup failure.
4965 * location.cs: Implemented Equals, GetHashCode.
4967 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
4969 2007-10-10 Jb Evain <jbevain@novell.com>
4971 * codegen.cs: re-enable assembly version check.
4973 2007-10-09 Marek Safar <marek.safar@gmail.com>
4975 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
4978 * namespace.cs (UsingAlias): Do correct version check.
4980 2007-10-08 Marek Safar <marek.safar@gmail.com>
4982 * expresison.cs, ecore.cs: Issue extension method error message when
4985 * rootcontext.cs: Added ISO_2 compiler mode option.
4987 2007-10-08 Marek Safar <marek.safar@gmail.com>
4989 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
4992 2007-10-08 Marek Safar <marek.safar@gmail.com>
4994 * attribute.cs (GetString, GetBoolean): Work with both literal and
4997 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
4998 Moved method overload specific methods to MethodGroupExpr.
5000 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
5001 it should be less memory consuming.
5003 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
5005 * codegen.cs: remove the assembly version check until the buildbot is
5008 2007-10-07 Jb Evain <jbevain@novell.com>
5010 * attribute.cs (Attribute.GetString): if the value
5011 expression is a StringConstant, return its string value.
5013 2007-10-07 Jb Evain <jbevain@novell.com>
5015 * typemanager.cs: add `assembly_version_attribute_type`.
5016 * codegen.cs: on attribute emission, check that the
5017 AssemblyVersionAttribute doesn't overflow.
5019 2007-10-05 Marek Safar <marek.safar@gmail.com>
5021 A fix for bug #324677
5022 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
5023 parent container of a scope container with currently resolved one.
5025 2007-10-05 Marek Safar <marek.safar@gmail.com>
5027 A fix for bug #325534
5028 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
5031 2007-10-05 Marek Safar <marek.safar@gmail.com>
5033 A fix for bug #327504
5034 * class.cs (Operator.Define): Refactored implicit and explicit user
5035 operator conversion rules.
5037 2007-10-05 Marek Safar <marek.safar@gmail.com>
5039 A fix for bug #327520
5040 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
5042 2007-10-04 Marek Safar <marek.safar@gmail.com>
5044 A fix for bug #328022
5045 * class.cs (MethodData.Define): Use correct method to check whether
5046 a method implementents an accessor.
5048 2007-10-04 Marek Safar <marek.safar@gmail.com>
5050 A fix for bug #330069
5051 * statement.cs (Fixed.Resolve): Read the first array element only when
5052 an array is instantiated.
5054 2007-10-04 Marek Safar <marek.safar@gmail.com>
5056 * expression.cs, assign.cs, generics.cs: Print correct operator when
5057 compound assignment is used.
5059 2007-10-04 Marek Safar <marek.safar@gmail.com>
5061 A fix for bug #325841
5062 * expression.cs (ArrayAccess): Use full argument cloning only for
5063 string compound concatenation.
5065 2007-10-03 Marek Safar <marek.safar@gmail.com>
5067 A fix for bug #328774
5068 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
5070 (PropertyExpr.EmitAssign): Fixed string concatenation compound
5073 2007-10-03 Raja R Harinath <rharinath@novell.com>
5076 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
5077 Event accessibility checks here. Remove some bogus code that
5078 accidently made GenericMethods work.
5079 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
5081 2007-09-25 Marek Safar <marek.safar@gmail.com>
5083 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
5085 * statement.cs (Block): Refactored AddVariable to allow error handling
5088 * generic.cs: New stub.
5090 2007-09-23 Marek Safar <marek.safar@gmail.com>
5092 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
5095 2007-09-17 Marek Safar <marek.safar@gmail.com>
5097 * class.cs: Use partial container to record whether any partial part
5098 contains static field initializer and therefore default contructor has
5101 2007-09-14 Marek Safar <marek.safar@gmail.com>
5103 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
5104 mono-list when only one of two partial parts has defined accessibility
5107 2007-09-14 Marek Safar <marek.safar@gmail.com>
5109 A fix for bug #82845
5111 * class.cs (TypeContainer): Set correct resolve context for all field
5114 2007-09-13 Marek Safar <marek.safar@gmail.com>
5116 * assign.cs: Fixed a crash when field is resolved twice with an error.
5118 * codegen.cs: Changed InFieldInitializer to be flag.
5120 * anonymous.cs, ecore.cs, expression.cs: Update after
5121 IsInFieldInitializer rename.
5123 * const.cs: Removed unused parameter.
5125 * class.cs: Changed the way how we resolve and emit field initializers.
5126 The field initilizers have to have access to contructor block to emit
5127 compiler generated code.
5129 2007-09-13 Marek Safar <marek.safar@gmail.com>
5131 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
5132 generics use TypeContainer instead.
5134 2007-09-12 Marek Safar <marek.safar@gmail.com>
5136 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
5138 * lambda.cs (ResolveParameters): Use more powerful
5139 InflateGenericArgument.
5141 * parameters.cs: Better exception message.
5143 2007-09-10 Marek Safar <marek.safar@gmail.com>
5145 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
5146 correct expression block type.
5148 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
5150 * expression.cs (Invocation): Extracted method group resolve to
5153 2007-09-07 Marek Safar <marek.safar@gmail.com>
5155 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
5156 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
5158 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
5159 generic extension methods.
5161 2007-09-06 Marek Safar <marek.safar@gmail.com>
5163 A fix for bug #82676 (Do I get it right now?)
5164 * convert.cs (Binary.ResolveOperator): An interface is converted to the
5165 object before a standard conversion is applied.
5167 2007-09-06 Marek Safar <marek.safar@gmail.com>
5169 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
5172 2007-09-05 Marek Safar <marek.safar@gmail.com>
5174 A fix for bug #82676
5175 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
5176 non-generic interface types.
5178 2007-09-05 Marek Safar <marek.safar@gmail.com>
5180 A fix for bug #82690
5181 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
5183 2007-09-05 Marek Safar <marek.safar@gmail.com>
5185 A fix for bug #82571
5186 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
5187 modifier for container based methods.
5189 2007-09-05 Marek Safar <marek.safar@gmail.com>
5191 A fix for bug #82676
5192 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
5193 any interface-type T means to any of interface type T.
5195 2007-09-04 Marek Safar <marek.safar@gmail.com>
5197 * namespace.cs: We have 2 versions of System.Core assembly.
5199 2007-09-04 Marek Safar <marek.safar@gmail.com>
5201 A fix for bug #82652
5202 * class.cs (Class.GetClassBases): Compare types and not expressions.
5204 2007-09-04 Marek Safar <marek.safar@gmail.com>
5206 A fix for bug #82620
5207 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
5208 actually never worked before.
5209 (IndexerAccess): Emit prepared arguments before they are modified.
5211 2007-09-04 Marek Safar <marek.safar@gmail.com>
5213 A fix for bug #82563
5214 * assign.cs: Revert wrong fix.
5216 * expression.cs (VariableReference.EmitAssign): Handle ref reference
5218 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
5219 Instead of ldelema/stdind we have to use temporary variables to handle
5220 cases like String.Concat (params string[]).
5222 2007-08-31 Marek Safar <marek.safar@gmail.com>
5224 * class.cs: EmitAttributes to Emit rename.
5226 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
5228 (MemberCore.HasClsCompliantAttribute): Don't depend on
5229 GetClsCompliantAttributeValue execution.
5231 2007-08-31 Marek Safar <marek.safar@gmail.com>
5233 * anonymous.cs: Use shorter type prefix.
5235 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
5238 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
5239 variables when probing is on.
5241 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
5242 unresolved variables.
5243 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
5244 handle transparent identifiers.
5246 2007-08-26 Marek Safar <marek.safar@gmail.com>
5248 * attribute.cs (IsClsCompliant): Add nullable types test.
5250 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
5252 * doc.cs : catch other types of exception than XmlException to
5253 report CS1570. Fixed bug #82565.
5255 2007-08-23 Marek Safar <marek.safar@gmail.com>
5257 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
5258 The number of delegate parameters has to match.
5259 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
5262 2007-08-21 Marek Safar <marek.safar@gmail.com>
5264 * anonymous.cs (AnonymousMethod): Generate private anonymous method
5265 to fix problem with private arguments.
5267 2007-08-20 Marek Safar <marek.safar@gmail.com>
5269 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
5271 * decl.cs (MemberName): Ignore generic type with no generic arguments.
5273 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
5274 empty. Add cloning suport.
5276 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
5278 2007-08-20 Marek Safar <marek.safar@gmail.com>
5280 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
5281 to create EmptyCast. It handles EmptyConstantCast specialization for
5284 2007-08-18 Marek Safar <marek.safar@gmail.com>
5286 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
5287 (EmitArrayArgument): One routine for array arguments.
5288 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
5290 2007-08-17 Marek Safar <marek.safar@gmail.com>
5292 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
5294 2007-08-17 Marek Safar <marek.safar@gmail.com>
5296 * anonymous.cs: MemberLookupFinal update.
5298 * class.cs (ConstructorInitializer): Is expression based.
5300 * delegate.cs: MethodGroupExpr update.
5302 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
5304 (Error_MemberLookupFailed): Customizable error override.
5305 (MethodGroupExpr): Keep queried type for later usage.
5306 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
5309 * expression.cs: Error_MemberLookupFailed refactoring.
5310 (New.DoResolve): Resolve as much as possible.
5311 (ElementInitializer.Error_MemberLookupFailed): Object initializer
5312 customization for invalid member types.
5314 * statement.cs: MethodGroupExpr update.
5316 2007-08-16 Marek Safar <marek.safar@gmail.com>
5318 * modifier.cs (Check): Check all modifiers and not only accessibility
5321 2007-08-16 Marek Safar <marek.safar@gmail.com>
5323 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
5324 type and not an expression.
5326 2007-08-16 Marek Safar <marek.safar@gmail.com>
5328 * statement.cs (Catch.Clone): Type and variable can be null.
5330 2007-08-16 Marek Safar <marek.safar@gmail.com>
5332 A fix for bug #81979
5333 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
5334 I am really not sure whether this is the best fix.
5336 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
5339 2007-08-14 Marek Safar <marek.safar@gmail.com>
5341 ** C# 3.0 Object and collection initializers (major re-write)
5343 * assign.cs (DoResolve): Initializers are not assign related.
5345 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
5346 used during collection or object initialization.
5348 * expression.cs (Error_InvalidArguments): Add initializers specific
5349 messages. More will come later because it requires some general
5351 (New.DoResolve): Better error handling for unsafe types.
5352 (EmptyExpressionStatement): New class.
5353 (ElementInitializer): An object initializer expression.
5354 (CollectionElementInitializer): A collection initializer expression.
5355 (CollectionOrObjectInitializers): A block of object or collection
5357 (NewInitialize): New expression with element/object initializers.
5359 * statement.cs: Reverted object/collection initializer hacks.
5361 * typemanager.cs (CSharpName): Filter __arglist type.
5363 2007-08-09 Marek Safar <marek.safar@gmail.com>
5365 ** C# 3.0 Anonymous Types (update to the latest standard)
5367 * expression.cs (Binary.ResolveOperator): Threat all null based types
5369 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
5370 (AnonymousTypeParameter): Updated.
5372 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
5373 (AnonymousTypeClass): New anonymous type container.
5375 * class.cs (AddField): Return operation result.
5377 * generic.cs: Another empty TypeArguments overload.
5379 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
5380 are stored at top of normal hierarchy.
5382 * typemanager.cs (CSharpName): Filter anonymous types.
5384 2007-08-09 Marek Safar <marek.safar@gmail.com>
5386 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
5387 as single Concat call. How could we miss that :-(
5389 2007-08-08 Marek Safar <marek.safar@gmail.com>
5391 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
5393 2007-08-07 Miguel de Icaza <miguel@novell.com>
5395 * expression.cs: Fix the previous commit, the creation of the
5396 arguments array list needs also to be conditional on the arguments
5399 * class.cs: Add a little bit of help to help narrow down problems.
5401 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
5402 not try to copy in that case.
5404 * driver.cs: When building SMCS, include a new different set of
5405 default assemblies here. Do this here so we can control whether
5406 to include the default assemblies with /noconfig.
5408 2007-08-03 Marek Safar <marek.safar@gmail.com>
5410 A fix for bug #81979
5411 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
5414 2007-08-03 Marek Safar <marek.safar@gmail.com>
5416 A fix for bug #82300
5418 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
5419 we are in probing scope.
5421 2007-08-03 Marek Safar <marek.safar@gmail.com>
5423 A fix for bug #82301
5425 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
5426 (Statement.CloneTo): Clone and not map children blocks.
5428 2007-08-03 Marek Safar <marek.safar@gmail.com>
5430 A fix for bug #82299
5432 * expression.cs (LocalVariableReference.CloneTo): Remap local info
5435 * statement.cs (Statement.CloneTo): Clone variables before statements
5436 to allow remaping of local variables.
5438 2007-08-03 Marek Safar <marek.safar@gmail.com>
5440 A fix for bug #82296
5443 * report.cs: Log crash details for future clone problems.
5445 * statement.cs (Return.Clone): Don't clone non-existent expression.
5447 2007-08-03 Raja R Harinath <harinath@gmail.com>
5449 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
5450 (Class.AddBasesForPart): Move CS0537 check here from ...
5451 * cs-parser.jay (class_declaration): ... here. Move calling of
5452 'AddBasesForPart' to ...
5453 (class_bases): ... here.
5454 (struct_declaration, interface_declaration): Update to changes.
5456 2007-08-02 Marek Safar <marek.safar@gmail.com>
5458 A fix for bug #81923
5460 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
5461 conversion is allowed.
5463 2007-08-02 Marek Safar <marek.safar@gmail.com>
5465 A fix for bug #81564
5467 * ecore.cs (EventExpr): Add IsBase handling.
5469 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
5472 2007-08-02 Raja R Harinath <harinath@gmail.com>
5474 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
5475 * cs-parser.jay: Some whitespace cleanups.
5476 (current_delegate): New.
5478 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
5479 a dummy code block, and use 'type_name' instead of 'member_name'.
5480 (interface_declaration, class_declaration): Likewise.
5481 (delegate_declaration): Likewise. Rearrange slightly and use
5483 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
5484 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
5486 2007-08-02 Marek Safar <marek.safar@gmail.com>
5488 A fix for bug #82039
5490 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
5493 * typemanager.cs (CSharpName): Split to string overload.
5495 2007-08-02 Marek Safar <marek.safar@gmail.com>
5498 * report.cs: Updated warning CS0472.
5500 2007-08-01 Marek Safar <marek.safar@gmail.com>
5502 A fix for bug #82181
5504 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
5506 2007-08-01 Marek Safar <marek.safar@gmail.com>
5508 A fix for bug #82277
5509 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
5511 2007-08-01 Marek Safar <marek.safar@gmail.com>
5513 ** C# 3.0 Type Inference (major bits are working)
5515 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
5516 (.ImplicitStandardConversionExists): Uses compatible.
5517 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
5518 (.InferReturnType): New method.
5519 (.Compatible): Refactored.
5520 (.ResolveParameters): Uses factory to create resolved parameters.
5521 (.CompatibleMethod): Add probing mode support.
5522 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
5523 clearly distinguish between 2 different operations.
5524 (LambdaMethod): Moved to lambda.cs.
5525 (AnonymousMethod): Removed unused fields and methods.
5526 (AnonymousDelegate): Simplified.
5528 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
5530 * convert. cs (ImplicitConversionStandard): Compatible works differently.
5532 * delegate.cs (Delegate): New mehods to reduce code duplication.
5533 (.GetConstructor): New method.
5534 (.GetInvokeMethod): New method.
5535 (DelegateCreation): Updated.
5537 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
5539 (OverloadResolve): Made probing little bit faster.
5541 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
5544 * generic.cs (TypeInferenceContext): Dummy implementation.
5546 * iterators.cs: Updated after Resolve/Define rename.
5548 * lambda.cs (LambdaExpression)
5549 (.ResolveParameters): Handles both type of arguments and type inference too.
5551 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
5552 (InflateTypes): Updated.
5554 * support.cs (InflateTypes): Changed signature and updated.
5556 * typemanager.cs (LookupMemberCache): Better dynamic type check.
5557 (MemberLookup_FindMembers): More MS tricks.
5558 (GetParameterData): Ditto.
5559 (GetDelegateParameters): Uses quick path for dynamic types.
5561 2007-08-01 Marek Safar <marek.safar@gmail.com>
5563 * class.cs (MethodData.Define): EmitContext is required for generic stuff
5566 2007-07-31 Marek Safar <marek.safar@gmail.com>
5568 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
5571 2007-07-26 Jb Evain <jbevain@novell.com>
5573 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
5574 which takes a boolean 'report_errors', similar to the GetMethod.
5575 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
5576 in .net 2.1, do not report errors here.
5578 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
5579 System.Runtime.CompilerServices.RequiredAttributeAttribute and
5580 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
5583 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
5584 of the type InternalsVisibleToAttribute before the first call
5585 to CoreLookupType which is allowed to fail (third boolean parameter
5586 to true). Because, during the resolution for a type that is not
5587 immediately found, we try to check if the type is not defined in
5588 a friend assembly, and to do so, we need the
5589 InternalVisibleToAttribute.
5591 2007-07-23 Miguel de Icaza <miguel@novell.com>
5593 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
5594 feature that allows structs to be compared against null and inline
5595 the result as true or false.
5597 Notice that the same code is not permitted inside a generic block
5598 of code that would do:
5600 class Foo<T> where T : struct {
5607 It is only allowed if the type of T is not bound (no where
5608 clause). In my opinion, this CSC 2 behavior is broken but people
5609 seem to be using it (IronRuby does, a few bug reports on bugzilla
5610 have it and some people have complained about it).
5612 All of the users that depend on this behavior have code that is
5615 * report.cs (Warning, Error): make these take object arguments,
5616 not strings, as that allows us to take advantage of Format.
5618 2007-07-20 William Holmes <billholmes54@gmail.com>
5620 * decl.cs: Changed MemberName.CountTypeArguments to also check the
5621 Left member variable for the Count.
5622 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
5623 MemberName.CountTypeArguments to avoid a NRE.
5625 This code is contributed under the MIT X11 license
5627 2007-07-18 Marek Safar <marek.safar@gmail.com>
5629 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
5631 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
5633 * doc.cs : generic method arguments are written as ``x while generic
5634 type arguments are `x. Combined with the previous change, fixed bug
5637 2007-07-18 Raja R Harinath <rharinath@novell.com>
5640 * expression.cs (Binary.ResolveOperator): When converting
5641 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
5643 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
5645 * doc.cs : when T: or whatever x: is specified, it does not really
5646 check the doc comment's syntax correctness. Fixed bug #82006.
5648 2007-07-18 Marek Safar <marek.safar@gmail.com>
5650 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
5651 LambdaExpression better.
5653 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
5655 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
5657 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
5658 as it can be generated.
5660 * expression.cs (Invocation.Error_InvalidArguments): Show correct
5663 * lambda.cs (LambdaExpression): Refactored to share same code with
5664 AnonymousMethodExpression.
5666 2007-07-17 Marek Safar <marek.safar@gmail.com>
5668 * anonymous.cs (MakeName): Include host name for easier debugging.
5669 (LambdaMethod): New class for lambda spcecific stuff.
5671 * attribute.cs: Set EmitContext return type.
5673 * class.cs: Set EmitContext return type.
5675 * codegen.cs (EmitContext): Return type cannot be null to stop messing
5676 with null/void meaning.
5678 * iterators.cs (ContainerType): Implemented.
5680 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
5682 * statement.cs (Return): Updated to lambda expressions.
5683 (Block.CloneTo): Parent can be null.
5685 2007-07-13 Marek Safar <marek.safar@gmail.com>
5687 A fix for bug #81917
5688 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
5690 * class.cs (FixedField): Check whether field is in unsafe scope.
5692 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
5693 (FieldExpr.Emit): Fixed buffers cannot be volatile.
5695 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
5698 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
5700 2007-07-13 Marek Safar <marek.safar@gmail.com>
5702 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
5703 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
5706 2007-07-13 Marek Safar <marek.safar@gmail.com>
5708 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
5710 2007-07-13 Marek Safar <marek.safar@gmail.com>
5712 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
5713 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
5715 * codegen.cs(EmitContext): Add ProbingMode flag.
5717 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
5719 * driver.cs: For now set both warning values.
5721 * ecore.cs (SimpleName): Name is readonly.
5722 (MethodGroup.OverloadResolve): One quick path for probing.
5724 * expression.cs (Unary): Set Oper r/o.
5725 (Binary): Set Oper r/o.
5726 (ParameterReference): Set few instance variables as r/o.
5727 (ParameterReference.DoResolveBase): Don't capture aruments when
5729 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
5730 (Arglist): arguments are private.
5731 (SizeOf): type is private and r/o.
5732 (MemberAccess): arguments are private.
5734 * report.cs: Enhanced reporting on/off capabilities.
5736 * lambda.cs: Uses ec.IsInProbingMode.
5737 (ContextualReturn): Derives from return.
5739 * rootcontext.cs: For now set both warning values.
5741 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
5743 (Return.Resolve): Don't die immediately.
5744 (Block.Resolve): Speed-up probing.
5745 (Block.CloneTo): Clone only child blocks.
5747 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
5749 * iterators.cs: reverted Miguel's latest change (r81925) as it
5750 breaks the build in System.
5752 2007-07-13 Miguel de Icaza <miguel@novell.com>
5754 * iterators.cs (Yield.CheckContext): Check for the iterator type
5755 also here as we can call into Yield even in codepaths that are not
5757 (MethodOrOperator is the only path that was checked).
5759 In addition to the standard check, use a more specific check for
5760 constructors to report a more verbose error.
5762 2007-07-12 Miguel de Icaza <miguel@novell.com>
5764 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
5765 report the warning and continue
5767 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
5768 values on the stack on the call to Emit. Use EmitStatement if
5769 possible, or using Emit + Pop if not possible. Fixes #82064
5771 2007-07-12 Raja R Harinath <rharinath@novell.com>
5773 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
5774 avoid try...finally in some cases.
5776 2007-07-10 Marek Safar <marek.safar@gmail.com>
5778 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
5780 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
5781 instead of method. Re-use standard error handling.
5782 (ConstructorInitializer.Emit): Simplified.
5784 * delegate.cs: Updated after Invocation.EmitCall change.
5786 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
5787 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
5788 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
5789 method and don't permanently changing input arguments.
5790 (MethodGroupExpr): Introduced resolved best_candidate, when method group
5791 is resolved it has one of the candidates is the best one which is later
5792 used to emit. Removed a few unused method.
5793 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
5795 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
5796 (Binary.ResolveOperator): Ditto.
5797 (ConditionalLogicalOperator.DoResolve): Ditto.
5798 (Invocation): Uses method group.
5799 (Invocation.DoResolve): Simplified.
5800 (Invocation.EmitCall): Removed useless is_static.
5801 (Invocation.Emit): Delegate to method group.
5802 (Invocation.EmitStatement): Simplified.
5803 (New): Uses method group.
5804 (MemberAccess.DoResolve): Don't destroy original expression.
5806 * statement.cs (ForEach.Resolve): Use null for no method arguments.
5808 2007-07-04 Marek Safar <marek.safar@gmail.com>
5810 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
5813 * lambda.cs: Add custom error message type.
5815 2007-07-03 Marek Safar <marek.safar@gmail.com>
5817 * lambda.cs: Simplified little bit.
5819 * parameter.cs: Introduced ImplicitLambdaParameter.
5820 (Parameters.CreateFullyResolved): New factory instead of ctor.
5824 * delegate.cs: Updated parameter creation.
5826 2007-07-03 Marek Safar <marek.safar@gmail.com>
5828 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
5831 * generic.cs: Synchronized with gmcs.
5833 2007-07-03 Marek Safar <marek.safar@gmail.com>
5835 * class.cs (Indexer): Check return type as soon as possible.
5837 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
5840 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
5842 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
5844 * parameter.cs (Parameter): Use expression type when it is available.
5846 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
5847 method modifier for the first parameter only.
5849 2007-06-24 Marek Safar <marek.safar@gmail.com>
5851 A fix for bug #81938
5852 * typemanager.cs (ChangeType): Fixed couple of char conversions.
5854 * constant.cs: Tide up an exception message.
5856 2007-06-22 Marek Safar <marek.safar@gmail.com>
5858 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
5859 an uninitialized variable is used.
5861 * expression.cs (LocalVariableReference.DoResolve): Ditto.
5863 2007-06-22 Marek Safar <marek.safar@gmail.com>
5865 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
5866 not found error handling.
5868 * expression.cs (ArrayCreation): Removed redundant fields and little bit
5870 (ArrayCreation.ResolveArrayElement): To be ready to customization.
5871 (ArrayCreation.DoResolve): Simplified.
5872 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
5873 its own resolve process.
5874 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
5876 2007-06-20 Marek Safar <marek.safar@gmail.com>
5878 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
5881 2007-06-20 Marek Safar <marek.safar@gmail.com>
5883 * cs-tokenizer.cs: Removed var related stuff.
5885 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
5886 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
5887 a type and a keyword at same time.
5889 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
5892 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
5893 implicitly typed arrays, more changes will follow.
5895 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
5897 2007-06-19 Marek Safar <marek.safar@gmail.com>
5899 * ecore.cs (VarExpr): Removed Handled field.
5901 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
5902 build-in assign functionality.
5903 (ForEach.Resolve): Removed all implicitly typed local variable code and
5905 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
5906 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
5908 2007-06-18 Marek Safar <marek.safar@gmail.com>
5910 * assign.cs: Removed implicitly typed local variable check.
5912 * expression.cs (LocalVariableReference.DoResolve): Add check for self
5913 referencing implicitly typed local variable.
5914 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
5917 * statement.cs (Fixed): Removed unsupported implicitly typed local
5920 2007-06-15 Marek Safar <marek.safar@gmail.com>
5922 * decl.cs (MemberName): Moved all Unbound stuff to parser.
5924 2007-06-14 Marek Safar <marek.safar@gmail.com>
5926 A fix for bugs #81855 and #76274
5927 * attribute.cs (AttachTo): Always set owner for global attributes to
5930 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
5933 * cs-parser.jay: Assembly and module attributes must precede all other
5934 elements except using clauses and extern alias declarations.
5936 2007-06-13 Marek Safar <marek.safar@gmail.com>
5938 A fix for bug #81748
5940 * expression.cs: More checks for non ISO-1 features.
5942 2007-06-12 Marek Safar <marek.safar@gmail.com>
5944 A fix for bug #81807
5945 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
5946 present inside switch statement and it is required by nullable check.
5948 2007-06-12 Marek Safar <marek.safar@gmail.com>
5950 A fix for bug #81840
5951 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
5952 when type matching fails.
5954 * namespace.cs: Tiny error message change.
5956 2007-06-12 Marek Safar <marek.safar@gmail.com>
5958 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
5959 reporting. Added automatic property check.
5961 * class.cs: Updated after CheckAbstractAndExtern relocation.
5962 (AEventPropertyAccessor.GetSignatureForError): Customized.
5964 2007-06-11 Marek Safar <marek.safar@gmail.com>
5966 * class.cs (DefineBaseTypes): Base type can be undefined.
5968 * ecore.cs (TypeLookup): Minor refactoring.
5969 (DoResolveAsTypeStep): Removed redundant check.
5971 * namespace.cs (Lookup): Removed redundant check.
5973 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
5974 ResolveAsTypeTerminal step.
5975 (BootstrapCorlib_*): Simplified.
5976 (PopulateCoreType): Core types can be now external.
5978 2007-06-07 Marek Safar <marek.safar@gmail.com>
5980 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
5982 (InferTypeArguments): Infers anonymous expression type arguments.
5983 (Compatible): Split to Compatible and InferTypeArguments.
5985 * lambda.cs: Updated.
5987 2007-06-08 Marek Safar <marek.safar@gmail.com>
5989 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
5991 2007-06-07 Raja R Harinath <harinath@gmail.com>
5993 Fix #80477, cs0135-2.cs, cs0135-3.cs
5994 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
5995 names to the "known" variables list.
5996 (Block.CheckInvariantMeaningInBlock): Handle the fact the
5997 parameter names are also "known".
5998 (Block.CheckError136): Remove.
5999 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
6002 2007-06-07 Marek Safar <marek.safar@gmail.com>
6004 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
6006 2007-06-06 Marek Safar <marek.safar@gmail.com>
6008 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
6009 internal error not an user error.
6011 * expression.cs (IsApplicable): Refactored to make debugging easier.
6013 * support.cs: More tricks for non-mono runtimes.
6015 * typemanager.cs (CoreLookupType): Made public.
6016 (InitSystemCore): All linq specific stuff moved to linq.cs
6018 2007-06-05 Marek Safar <marek.safar@gmail.com>
6020 * typemanager.cs (CSharpSignature): One more missing build-in types
6022 More tricks for non-mono runtime.
6024 2007-06-05 Raja R Harinath <harinath@gmail.com>
6026 * statement.cs (Block.CheckError136_InParents): Remove.
6027 (Block.AddVariable): Use GetParameterInfo instead.
6028 (ToplevelBlock.ProcessArguments): Likewise.
6030 2007-06-04 Raja R Harinath <rharinath@novell.com>
6032 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
6034 (ToplevelBlock.GetParameterInfo): Split out of ...
6035 (ToplevelBlock.GetParameterRefernce): ... this.
6036 (ToplevelBlock.ParameterMap): Remove.
6037 * expression.cs (ParameterReference): Update to use
6038 ToplevelParameterInfo.
6040 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
6043 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
6044 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
6046 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
6047 (ToplevelBlock.ProcessParameters) ... here.
6048 (ToplevelBlock..ctor): Invoke it.
6050 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
6053 * statement.cs (IKnownVariable): New interface.
6054 (LocalInfo): Implement it.
6055 (ToplevelParameterInfo): New class.
6056 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
6057 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
6058 GetKnownVariableInfo.
6060 2007-06-03 Raja R Harinath <harinath@gmail.com>
6062 Partly speed up CS0136 error checks.
6063 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
6064 'recurse' parameter.
6065 (Block.DoCheckError136): Only check errors in parameters. Move
6066 local variable checks ...
6067 (Block.AddVariable): ... here, and ...
6068 (ToplevelBlock.ResolveMeta): ... here.
6070 2007-06-02 Raja R Harinath <harinath@gmail.com>
6072 * statement.cs (Block.IsChildOf): Remove.
6074 * statement.cs (Statement.Clone): Move special case code ...
6075 (Block.CloneTo): ... here.
6077 2007-05-29 Raja R Harinath <rharinath@novell.com>
6079 * statement.cs (ToplevelBlock.container): Remove field. It's
6080 redundant with 'Parent'.
6081 (ToplevelBlock.ContainerBlock): Remove accessor.
6082 (ToplevelBlock..ctor): Update to changes. Register anonymous
6083 child with parent here, ...
6084 * cs-parser.jay (end_anonymous): ... not here. Don't modify
6086 (start_anonymous): Don't save current_block.
6087 (top_current_block): Remove.
6089 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
6090 (Block.Resolve): Update to changes.
6091 (Block..ctor): Move setting of "correct" 'Toplevel'
6092 and 'Explicit' fields to ...
6093 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
6095 2007-05-27 Raja R Harinath <harinath@gmail.com>
6098 * statement.cs (Block.Implicit): Remove.
6099 (Block): Update to changes.
6100 * flowanalysis.cs: Likewise.
6102 Mildly speed up CheckInvariantMeaningInBlock
6103 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
6104 Recursively call AddKnownVariable to all enclosing blocks.
6105 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
6106 Remove recursive calls.
6107 (Block): Update to changes.
6109 New ExplicitBlock invariants
6110 * statement.cs (Block.Explicit): New field. It points to the
6111 immediately enclosing non-implicit block.
6112 (Block..ctor): Maintain the invariant.
6113 * cs-parser.jay: Take advantage of invariant.
6115 Introduce ExplicitBlock
6116 * statement.cs (ExplicitBlock): New.
6117 (ToplevelBlock): Derive from it.
6118 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
6120 (Block.Implicit): Update to changes.
6121 * cs-parser.jay: Update to changes.
6124 * codegen.cs (EmitContext.IsLastStatement): Remove.
6125 * statement.cs (Block.DoEmit): Update to changes.
6127 2007-05-25 Raja R Harinath <rharinath@novell.com>
6129 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
6130 modifying current_block directly.
6132 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
6134 * class.cs: Implemented automatic properties (C# 3.0)
6135 Thanks to Marek for the help.
6137 2007-05-23 Raja R Harinath <rharinath@novell.com>
6139 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
6140 variable as assigned, note also that all its components are
6142 (MyBitVector.SetRange): New. Function to set multiple bits to true.
6144 2007-05-19 Marek Safar <marek.safar@gmail.com>
6146 * anonymous.cs, class.cs: Emit Compiler generated attribute when
6147 member is marked as compiler generated.
6149 * decl.cs (MemberCore): Refactored ModFlags into property.
6151 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
6152 (Check): Check only accessibility modifiers.
6154 2007-05-18 Raja R Harinath <rharinath@novell.com>
6156 Track all assignable slots in one bit array
6157 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
6158 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
6159 logic from VariableMap constructor here. Use the same 'offset'
6160 variable that's later used for computing offsets of local
6162 * flowanalysis.cs (UsageVector.parameters): Remove.
6163 (UsageVector): Update to changes.
6164 (VariableMap): Remove.
6166 Avoid creating ParameterMap in every block
6167 * statement.cs (Block.ParameterMap): Move ...
6168 (ToplevelBlock.ParameterMap): ... here.
6169 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
6171 * flowanalysis.cs (FlowBranching.param_map): Remove.
6172 (FlowBranching.UsageVector): Update to changes.
6173 (FlowBranchingToplevel.CheckOutParameters): Likewise.
6175 * statement.cs (Block.CloneTo): Clone Toplevel field too.
6177 * expression.cs (ParameterReference): Distinguish between block
6178 where parameter was referenced and declared.
6180 2007-05-18 Marek Safar <marek.safar@gmail.com>
6182 * flowanalysis.cs, statement.cs: Put back improved error handling.
6184 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
6188 Imporved object and collection initialization (C# 3.0).
6190 2007-05-15 Marek Safar <marek.safar@gmail.com>
6192 A fix for bug #81380
6193 * expression.cs (Is.DoResolve): Only value types have constant `is'
6196 2007-05-15 Raja R Harinath <rharinath@novell.com>
6198 * statement.cs (ToplevelBlock.child): Remove.
6200 2007-05-15 Raja R Harinath <harinath@gmail.com>
6202 Rationalize ResolveMeta: refactoring
6203 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
6204 out constant handling code into ...
6205 (Block.DoResolveConstants): ... this.
6207 Rationalize ResolveMeta: kill local_map
6208 * statement.cs (Block.local_map, Block.LocalMap): Remove.
6209 (Block.AssignableSlots): New.
6210 (Block.ResolveMeta): Make protected. Don't create a VariableMap
6211 for locals -- move code from VariableMap here. Avoid unnecessary
6213 * flowanalysis.cs (FlowBranching.local_map): Remove.
6214 (FlowBranching..ctor): Use Block.AssignableSlots.
6215 (VariableMap): Remove unused constructors.
6217 2007-05-11 Raja R Harinath <rharinath@novell.com>
6219 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
6221 2007-05-11 Marek Safar <marek.safar@gmail.com>
6223 * typemanager.cs (IsFriendAssembly): Should not be called for building
6226 2007-05-09 Marek Safar <marek.safar@gmail.com>
6228 * literal.cs (NullConstant): Print null in all cases.
6230 * expression.cs (Binary.ResolveOperator): Implemented delegate
6231 comparison based on C# 2.0 changes.
6233 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
6235 This code is contributed under the MIT X11 license
6237 The following enables support for several C# 3.0 language features:
6239 * cs-tokenizer.cs: Added support for the "var" keyword.
6241 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
6242 Added VarExpr class to facilitate type inferencing.
6244 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
6245 to support anonymous types.
6247 * assign.cs: Added support for type inferencing and initialization.
6249 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
6251 * expression.cs: Added implicit array support to ArrayCreation.
6252 Added 5 types and 1 interface:
6254 IInitializable Implementing classes can inject initializing
6255 statements after object instantiation.
6257 Initializer Stores data for object initialization.
6259 AnonymousType An expression for anonymous types.
6261 AnonymousTypeParameter Stores data about an anonymous type's field.
6263 NewInitialize An expression for object initialization.
6265 CollectionInitialize An expression for collection initialization.
6267 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
6270 2007-05-06 Marek Safar <marek.safar@gmail.com>
6272 A fix for bug #81500
6273 * cs-tokenizer.cs: Add special handling for coalescing operator.
6275 2007-05-06 Marek Safar <marek.safar@gmail.com>
6277 A fix for bug #81529
6278 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
6279 its value from base class until it is redefined.
6281 2007-05-02 Raja R Harinath <rharinath@novell.com>
6283 Fix regression in cs0631-3.cs
6284 * cs-parser.jay (operator_declarator): Add opt_attributes to error
6285 fallback. Make error fallback catch more cases.
6287 2007-05-01 Miguel de Icaza <miguel@novell.com>
6289 * cs-parser.jay: Allow parameters in operator declarations to have
6292 2007-04-27 Miguel de Icaza <miguel@novell.com>
6294 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
6297 * lambda.cs (ContextualReturn.Resolve): An expression is valid
6298 inside the ContextualReturn, it does not have to be an
6299 ExpressionStatement.
6301 2007-04-24 Miguel de Icaza <miguel@novell.com>
6303 * lambda.cs (ContextualReturn.Resolve): if the return type is not
6306 2007-04-23 Miguel de Icaza <miguel@novell.com>
6308 * anonymous.cs (AnonymousContainer): split the virtual Resolve
6309 method in two methods: ResolveNoDefine and Resolve.
6311 ResolveNoDefine will stop just after ResolveTopBlock has been
6314 Resolve will then continue by creating a method and issuing the
6315 call to method.Define ().
6317 (AnonymousMethod): Split and implement the new Resolve and
6318 ResolveNoDefine as well.
6320 * lambda.cs (LambdaExpression): Split the anonymous method
6321 resolution code into a separate routine (CoreCompatibilityTest)
6322 from DoCompatibleTest.
6324 (LambdaExpression.TryBuild): New method, this method tries to
6325 build the LambdaExpression with the given set of types to be used
6326 as the types for the various parameters of the lambda expression.
6328 If the compilation succeed with the given types, the infered type
6329 of the Anonymous method is returned, otherwise null is returned.
6331 2007-04-23 Marek Safar <marek.safar@gmail.com>
6333 A fix for bug #81414
6334 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
6336 2007-04-22 Miguel de Icaza <miguel@novell.com>
6338 * cs-tokenizer.cs: Change various identifiers here from the
6339 camelCasing to the recommended Linux-like style for instance
6340 variables from the Coding Guidelines.
6342 2007-04-19 Martin Baulig <martin@ximian.com>
6345 (Convert.ImplicitReferenceConversionCore): Allow conversions from
6346 System.Enum to System.ValueType.
6348 2007-04-13 Martin Baulig <martin@ximian.com>
6350 Rewrote implicit reference conversions. We need to distinguish
6351 between implicit reference conversions (13.1.4) and implicit
6352 boxing conversions (13.1.5).
6354 According to the spec, there's an an implicit conversion
6355 "From a one-dimensional array-type S[] to IList<T> and base
6356 interfaces of this interface, provided there is an implicit
6357 reference conversion from S to T." Note that this does not
6358 include boxing conversions.
6361 (Convert.ImplicitTypeParameterBoxingConversion): New method.
6362 (Convert.ImplicitReferenceConversion): Split into
6363 ImplicitReferenceConversionCore() and
6364 ImplicitBoxingConversionExist().
6365 (Convert.ImplicitReferenceConversionExists): Use the new
6366 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
6368 2007-04-12 Martin Baulig <martin@ximian.com>
6370 * convert.cs (Convert.ImplicitReferenceConversion): Move the
6371 `TypeManager.null_type' checks up to the top of the method.
6373 2007-04-11 Marek Safar <marek.safar@gmail.com>
6375 A fix for bug #81350
6376 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
6379 2007-04-11 Martin Baulig <martin@ximian.com>
6381 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
6382 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
6383 to make this work for generic classes; fixes #79561.
6385 2007-04-11 Martin Baulig <martin@ximian.com>
6387 * expression.cs (As): Add support for nullable types; fixes #79371.
6389 2007-04-11 Martin Baulig <martin@ximian.com>
6391 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
6392 `type.FullName' is null; fixes #80243.
6394 2007-04-11 Martin Baulig <martin@ximian.com>
6396 * expression.cs (Invocation.IsApplicable): Don't modify the method
6397 if type inference succeeded, but the method was not applicable.
6400 2007-04-10 Marek Safar <marek.safar@gmail.com>
6402 A fix for bug #81324
6403 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
6404 internal and external namespaces containers.
6406 2007-04-10 Martin Baulig <martin@ximian.com>
6408 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
6409 TypeManager.DropGenericMethodArguments() so we also call
6410 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
6412 2007-04-10 Martin Baulig <martin@ximian.com>
6414 * iterators.cs (Iterator.CreateIterator): Don't crash if
6415 `method.ReturnType' is null. This happens if something went wrong
6416 while resolving that typ (we already reported an error in this case).
6418 2007-04-10 Martin Baulig <martin@ximian.com>
6420 * expression.cs (New.DoResolve): Don't call CheckComImport() on
6421 generic interfaces; report the CS0144 directly.
6423 2007-04-10 Martin Baulig <martin@ximian.com>
6425 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
6426 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
6428 2007-04-10 Martin Baulig <martin@ximian.com>
6430 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
6432 2007-04-09 Raja R Harinath <rharinath@novell.com>
6435 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
6436 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
6439 * statement.cs (For.Resolve): If resolution fails, use
6442 2007-04-08 Marek Safar <marek.safar@gmail.com>
6444 * anonymous.cs (MakeName): Make faster and zero-based.
6445 (VerifyExplicitParameterCompatibility): Back to mode where generic
6446 parameter is ignored.
6447 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
6449 * class.cs (EmitType): Method can emit another new method.
6451 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
6453 * driver.cs: Updated.
6455 * lambda.cs: Reuse predefined empty parameters.
6457 * parameter.cs: Updated
6459 * support.cs: Implemented InflateTypes.
6461 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
6462 (InitSystemCore): Introduced to isolate 3.0 dependencies.
6464 2007-04-03 Martin Baulig <martin@ximian.com>
6468 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
6469 version of TypeManager.IsOverride() which also works with generic
6472 2007-04-03 Martin Baulig <martin@ximian.com>
6477 (Convert.ExplicitReferenceConversion): We need to cast when
6478 converting from IList<T> to S[].
6480 2007-04-01 Marek Safar <marek.safar@gmail.com>
6482 * decl.cs (FindExtensionMethods): Consider all candidates with same name
6485 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
6487 2007-03-31 Marek Safar <marek.safar@gmail.com>
6489 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
6490 argument and return type inferring.
6492 * codegen.cs (InferReturnType): Flag whether return can be inferred.
6493 (ReturnType): Turned to property.
6495 * statement.cs (Return): Implemented return type inferring.
6497 * support.cs (ReflectionParameters): Use local types if possible.
6499 2007-03-30 Raja R Harinath <rharinath@novell.com>
6501 * flowanalysis.cs (FlowBranching.Reachability): Remove.
6502 (FlowBranching.UsageVector): Update to changes.
6504 Prepare to kill 'Reachability'
6505 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
6506 argument of constructor.
6508 2007-03-29 Raja R Harinath <rharinath@novell.com>
6510 Prepare to kill 'Reachability'
6511 * flowanalysis.cs (UsageVector.is_unreachable): New.
6512 (UsageVector): Update to maintain 'is_unreachable' in parallel to
6513 'reachability', and verify they're consistent.
6516 * expression.cs (New.EmitStatement): Handle type parameters here too.
6518 2007-03-29 Martin Baulig <martin@ximian.com>
6523 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
6524 CompilerGeneratedClass.
6525 (ScopeInfo.EmitScopeInstance): Make this protected.
6526 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
6527 `ec.CurrentAnonymousMethod.Scope == Scope'.
6529 * statement.cs (Block.ScopeInfo): Make this a property.
6531 2007-03-27 Raja R Harinath <harinath@gmail.com>
6533 Prepare to kill 'Reachability'
6534 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
6535 (FlowBranching.UsageVector.Reachability): Remove property.
6536 (FlowBranching.UsageVector.IsUnreachable): New property.
6537 (FlowBranching.UsageVector.ResetBarrier): New.
6538 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
6539 * codegen.cs, statement.cs: Update to changes.
6541 2007-03-27 Martin Baulig <martin@ximian.com>
6546 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
6549 2007-03-26 Raja R Harinath <rharinath@novell.com>
6551 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
6552 instead of TriState. Remove all mention of TriState.
6554 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
6555 replaced by a boolean. Add boolean 'is_unreachable' field, check
6556 and maintain invariants.
6558 2007-03-25 Marek Safar <marek.safar@gmail.com>
6560 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
6562 2007-03-25 Marek Safar <marek.safar@gmail.com>
6564 * expression.cs: Stop using obsolete 2.0 opcodes.
6566 2007-03-25 Marek Safar <marek.safar@gmail.com>
6568 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
6569 one of the latests Martin's fixes.
6571 2007-03-23 Miguel de Icaza <miguel@novell.com>
6573 * expression.cs: On BigEndian systems, swap the bytes, temporary
6574 solution until we get a new bitconverter class.
6576 2007-03-23 Martin Baulig <martin@ximian.com>
6580 * decl.cs (MemberCache.AddMembers): Add generic methods both as
6581 "Method" and "Method`1". Normally, a cache lookup is done on the
6582 "Method" form (ie. without the generic arity), but this one makes
6583 lookups on the full form work as well.
6585 2007-03-22 Raja R Harinath <rharinath@novell.com>
6587 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
6590 2007-03-20 Bill Holmes <billholmes54@gmail.com>
6592 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
6593 ordered_member_list, to TypeBuilder to store members to be defined
6594 in the order they were parsed in.
6595 - ordered_explicit_member_list contains all properties indexers
6596 and methods that are defined as explicit implementation of an
6597 interface or base class.
6598 - ordered_member_list contains all properties indexers and methods
6599 that are not defined as explicit implementation of an interface
6602 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
6603 functionality in these removed classes has been replaced with
6604 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
6605 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
6607 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
6608 to CheckForDuplications inside GetMethod and SetMethod Define Method
6609 to handle method property and indexer name conflicts.
6613 All code is contributed under the MIT/X11 license.
6615 2007-03-20 Martin Baulig <martin@ximian.com>
6617 * class.cs (TypeContainer.Interfaces): Removed; they're now
6618 included in `TypeContainer.Types'.
6620 2007-03-20 Martin Baulig <martin@ximian.com>
6622 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
6624 * class.cs (TypeContainer.CreateType): New public method. This is
6625 now called before DefineType() to create the TypeBuilders.
6626 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
6627 has already been created by CreateType().
6628 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
6629 don't resolve our base classes here; this has been moved into
6630 DefineBaseTypes(). We're now called from CreateType().
6631 (TypeContainer.DefineBaseTypes): New private method; resolve our
6632 base classes here. We're now called from DefineType().
6635 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
6636 our types first to create all the TypeBuilders. After that, call
6637 TypeContainer.DefineType() on all the types which'll resolve their
6638 base classes and setup the resolve order.
6640 2007-03-20 Martin Baulig <martin@ximian.com>
6642 * class.cs (TypeContainer.Enums): Removed; they're now included in
6643 `TypeContainer.Types'.
6645 2007-03-20 Martin Baulig <martin@ximian.com>
6648 (TypeContainer.DefineType): Don't call ResolveMembers() here.
6649 (TypeContainer.DoResolveMembers): Call DefineType() on our
6650 `compiler_generated' classes; moved here from DefineNestedTypes().
6653 (RootContext.ResolveTree): Call ResolveMembers() on all
6654 TypeContainer's in the `type_container_resolve_order'.
6656 2007-03-19 Marek Safar <marek.safar@gmail.com>
6658 * class.cs: Use corlib to handle InternalMethodImplAttribute.
6660 2007-03-17 Marek Safar <marek.safar@gmail.com>
6662 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
6663 implementation flags.
6665 2007-03-17 Marek Safar <marek.safar@gmail.com>
6667 * class.cs: More optimizations for type parameters.
6669 2007-03-15 Marek Safar <marek.safar@gmail.com>
6671 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
6673 * ecore.cs, parameter.cs: More common code for both corlibs.
6675 * typemanager.cs (IsGenericMethod): Simplified.
6677 2007-03-15 Raja R Harinath <rharinath@novell.com>
6679 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
6681 * statement.cs, iterators.cs, lambda.cs: Update to changes.
6683 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
6684 unconditionally. Simplify explanation.
6685 (Try.Resolve, Using.Resolve): Likewise.
6687 2007-03-15 Martin Baulig <martin@ximian.com>
6691 * decl.cs (DeclSpace): If we're a partial class, use our
6692 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
6694 2007-03-15 Raja R Harinath <rharinath@novell.com>
6696 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
6698 (FlowBranching.UsageVector): Update to changes.
6699 (FlowBranching.MergeSiblings): Likewise.
6700 * statement.cs: Likewise.
6702 2007-03-15 Martin Baulig <martin@ximian.com>
6707 (MemberCache): Added a special .ctor for type parameters.
6710 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
6713 2007-03-09 Martin Baulig <martin@ximian.com>
6715 * enum.cs (Enum): Make this a TypeContainer.
6716 (EnumMember): Derive from `Const'.
6719 (Const.DoResolveValue): New protected virtual method; move most of
6720 the functionality of ResolveValue() here so we can override it in
6722 (Const.CreateConstantReference): Make this virtual.
6724 * class.cs (Kind): Add `Kind.Enum'.
6725 (TypeContainer.Emit): Don't emit the enums here; they're already
6726 in the `RootContext.typecontainer_resolve_order'.
6728 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
6729 here; they're already in the `typecontainer_resolve_order'.
6731 * ecore.cs (EnumConstant.ConvertImplicitly): Add
6732 TypeManager.DropGenericTypeArguments().
6735 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
6736 (TypeManager.IsEnumType): Likewise.
6737 (TypeManager.EnumToUnderlying): Likewise.
6738 (TypeManager.IsEqual): Add support for enums.
6740 2007-03-12 Raja R Harinath <rharinath@novell.com>
6742 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
6743 DefaultParameterValueAttribute to be undefined, say if System.dll
6746 2007-03-11 Marek Safar <marek.safar@gmail.com>
6748 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
6751 2007-03-10 Marek Safar <marek.safar@gmail.com>
6753 * class.cs, parameter.cs: Unified parameters verification.
6755 2007-03-08 Martin Baulig <martin@ximian.com>
6757 * cs-parser.jay (constructor_header): Pass the location to the
6758 newly created TopLevelBlock.
6760 2007-03-07 Martin Baulig <martin@ximian.com>
6762 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
6764 2007-03-06 Miguel de Icaza <miguel@novell.com>
6766 * convert.cs (ExplicitReferenceConversionExists): Sync this method
6767 with the changes from David, fixes the build.
6769 2007-03-05 David Mitchell <dmitchell@logos.com>
6771 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
6772 and its base interfaces to a one-dimensional array type S[],
6773 provided there is an implicit or explicit reference conversion
6776 2007-03-03 Marek Safar <marek.safar@gmail.com>
6778 * cs-tokenizer.cs: Implemented basic linq grammar.
6780 * driver.cs: Set linq lang version on demand.
6782 2007-02-26 Marek Safar <marek.safar@gmail.com>
6784 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
6786 2007-02-25 Marek Safar <marek.safar@gmail.com>
6788 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
6791 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
6793 Check property and event extern attributes.
6795 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
6798 2007-02-24 Marek Safar <marek.safar@gmail.com>
6800 A fix for bug #80407
6801 * ecore.cs: Don't report ambiguity error when methods have same parent.
6803 2007-02-23 Marek Safar <marek.safar@gmail.com>
6805 A fix for bug #80878
6806 * class.cs, cs-parser.jay: Event property can host anonymous methods.
6808 2007-02-22 Marek Safar <marek.safar@gmail.com>
6810 * attribute.cs: Enable ExtensionAttribute presence test.
6812 2007-02-22 Marek Safar <marek.safar@gmail.com>
6814 * class.cs: Warn about missing GetHashCode only when Equals is override.
6816 * decl.cs: Check accessibility of type arguments.
6818 * typemanager.cs: Correctly report nullable array.
6820 2007-02-20 Marek Safar <marek.safar@gmail.com>
6822 * class.cs, report.cs: Capture more details when things go wrong.
6824 2007-02-20 Marek Safar <marek.safar@gmail.com>
6826 A fix for bug #80650
6827 * cs-parser.jay: Anonymous container starts at constructor declaration
6828 and not at block beginning because it has to be usable in constructor
6831 * statement.cs: Use context location and not block one for error reporting.
6833 2007-02-18 Marek Safar <marek.safar@gmail.com>
6835 A fix for bug #78712
6836 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
6839 2007-02-18 Marek Safar <marek.safar@gmail.com>
6841 A fix for bug #80493 by Atsushi Enomoto
6842 * cs-parser.jay: Ignore invalid attribute target.
6844 2007-02-18 Marek Safar <marek.safar@gmail.com>
6846 * cs-tokenizer.cs: Ignore '\0' as white space character.
6848 2007-02-17 Miguel de Icaza <miguel@novell.com>
6850 * cs-parser.jay: Add support for lambda expressions to the mcs
6853 * lambda.cs: Only clone when we are probing, not on the final call
6854 (Compatible is the final call).
6856 * statement.cs (CloneContext): Introduce class to provide block
6857 remapping during clone.
6859 All statements Clone themselves now.
6861 (Clone): special handling for blocks, when we clone a block, we
6862 register the block inside this routine, as children of the block
6863 might trigger a lookup.
6865 * expression.cs: Add support for CloneContext in all expressions.
6867 2007-02-17 Marek Safar <marek.safar@gmail.com>
6869 A fix for bug #80493
6870 * statement.cs: Report ambiguous warning when interfaces are not related.
6872 2007-02-15 Marek Safar <marek.safar@gmail.com>
6874 C# 3.0 extension methods.
6876 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
6877 cannot be used directly.
6879 * class.cs (Class.Emit): Emit extension attribute if any class method
6880 is extension method.
6881 (Method.Define): Add basic extension method validation conditions.
6882 (Method.Emit): Emit extension attribute for method.
6884 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
6885 extension method exists. Currently we follow same approach as Microsoft
6886 does, emit even if a method or a class are private but this can change
6889 * cs-parser.jay: Add handling of `this' keyword in method parameters
6892 * decl.cs (DeclSpace.IsStaticClass): New property.
6893 (MemberCache.FindExtensionMethods): Looks for extension methods with
6894 defined name and extension type.
6896 * doc.cs: Updated after OverloadResolve changes.
6898 * driver.cs: Add new soft reference to System.Core.dll.
6900 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
6901 (ExtensionMethodGroupExpr): Represents group of extension methods.
6903 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
6904 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
6905 to MethodGroupExpr and made non-static for easier customization.
6906 (Invocation.DoResolve): Add extension method lookup when no standard
6908 (MemberAccess.DoResolve): Try extension methods if no member exists.
6910 * modifiers.cs: Add METHOD_EXTENSION modifier.
6912 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
6913 as well as candidate extension type.
6914 (ComputeNamespaces): When assembly constains extension methods registers
6916 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
6917 extension method lookup.
6918 (Namespace.LookupExtensionMethod): Looks for extension method in this
6920 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
6921 find a method which matches name and extensionType.
6923 * parameter.cs (Parameter): Add This modifer.
6924 (HasExtensionMethodModifier): New property.
6925 (Resolve): Add extension parameter check.
6926 (ModFlags): turned to property to exclude this modifier as it is not real
6928 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
6930 * support.cs (ParameterData): Add ExtensionMethodType.
6931 (ReflectionParameters): Implemented ExtensionMethodType interface property.
6933 * typemanager.cs: Add type and ctor extension attribute type.
6935 2007-02-15 Miguel de Icaza <miguel@novell.com>
6937 * report.cs (DisableErrors, EnableErrors): used to prevent error
6938 output when we are "trying" to compile various methods with
6941 * ecore.cs (Expression): Add Clone method that calls the virtual
6942 CloneTo method. The current CloneTo method in Expression throws
6943 an exception so we can track down all the places where this must
6944 be implemented (not using abstract, because that would be a lot of
6945 up-front-work before we can start testing the implementation
6948 Important: we only need Clone capabilities for expressions created
6949 by the parser, as the expressions we will be cloning are
6950 expressions in the pre-resolved state. This vastly simplifies
6953 (SimpleName): Add CloneTo that does nothing.
6954 (EmptyCast): Add CloneTo.
6956 * expression.cs (Binary): Implement CloneTo.
6957 (Invocation.IsApplicable): Store the current ec in
6958 EmitContext.TempEc and restore it on return. This is used so we
6959 do not have to sprinkle hundres of methods with an extra
6960 EmitContext, we know that the only user is the lambda expression
6961 ImplicitConversionExists code.
6963 (Argument): Add Cloning capabilities.
6964 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
6965 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
6966 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
6967 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
6968 IndexerAccess): Add Clone capability.
6970 (LocalVariableReference, This): TODO: needs cloned Block mapping.
6972 (Argument): Add cloning capability.
6974 * assign.cs (Assign): Implement CloneTo.
6976 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
6978 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
6979 version by calling Convert with the EmitContext (that we are
6980 currently storing in ec, this is not great, but will do for now,
6981 to avoid passing EmitContext parameters to hundreds of functions
6982 that do not need them now).
6984 (SetExpression): Remove, it is not needed.
6986 (ContextualReturn): Implement CloneTo.
6988 * statement.cs (Statement): Implement cloning infrastructure,
6989 similar to expressions.
6991 (Block): Partial implementation of Clone for statements.
6993 (Return): Implement clone.
6995 * constant.cs (Constant.CloneTo): New method, does nothing.
6997 * codegen.cs (TempEc): Add a static EmitContext as a temporary
6998 solution, until we decide how to exactly do this.
7000 2007-02-14 Marek Safar <marek.safar@gmail.com>
7002 A fix for bug #80493
7003 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
7004 a property is override we need to use second accessor.
7006 2007-02-13 Marek Safar <marek.safar@gmail.com>
7008 A fix for bug #80418
7009 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
7012 2007-02-13 Marek Safar <marek.safar@gmail.com>
7014 Another fix for bug #80749
7015 * pending.cs: Abstract class has priority over interfaces.
7017 2007-02-13 Marek Safar <marek.safar@gmail.com>
7019 Another fix for bug #80749
7020 * pending.cs: Abstract class has priority over interfaces.
7022 2007-02-13 Marek Safar <marek.safar@gmail.com>
7024 Another fix for bug #80749
7025 * pending.cs: Abstract class has priority over interfaces.
7027 2007-02-13 Marek Safar <marek.safar@gmail.com>
7029 Another fix for bug #80749
7030 * pending.cs: Abstract class has priority over interfaces.
7032 2007-02-13 Marek Safar <marek.safar@gmail.com>
7034 * class.cs Better error message.
7036 * driver.cs: Add shorter versions of -optimize option.
7038 2007-02-13 Martin Baulig <martin@ximian.com>
7040 * class.cs (Constructor.Emit): Check the return value of
7041 ec.ResolveTopBlock() and return on error.
7043 2007-02-13 Raja R Harinath <rharinath@novell.com>
7045 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
7046 message to fix error message regression.
7048 2007-02-12 Marek Safar <marek.safar@gmail.com>
7050 * delegate.cs: Delegate creation expression cannot be of Nullable type.
7052 2007-02-12 Marek Safar <marek.safar@gmail.com>
7054 A fix for bug #80749
7055 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
7056 its parent container.
7058 * class.cs (DefineFieldInitializers): Each initializer can has different
7061 * const.cs: Updated.
7063 2007-02-11 Miguel de Icaza <miguel@novell.com>
7065 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
7066 now all the heavy lifting to check that embedded statements or
7067 expressions have the right form is done in the ContextualReturn.
7069 (ContextualReturn): New class.
7071 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
7072 method that can be invoked to report 201, so we do not replicate
7075 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
7077 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
7078 treating tabs as spaces.
7080 2007-02-09 Marek Safar <marek.safar@gmail.com>
7082 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
7083 * assign.cs: Use full implicit conversion for right side check.
7085 2007-02-09 Marek Safar <marek.safar@gmail.com>
7087 * statement.cs (Switch): Switch over boolean type is not standardized.
7089 2007-02-08 Marek Safar <marek.safar@gmail.com>
7091 A fix for bug #80755
7092 * decl.cs (FindBaseEvent): Don't use method cache for events.
7094 2007-02-07 Marek Safar <marek.safar@gmail.com>
7096 * cs-parser.jay: Better syntax error handling.
7098 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
7099 instead of underlying type value.
7101 2007-02-06 Marek Safar <marek.safar@gmail.com>
7103 * driver.cs: Check define identifier before is registered.
7105 * namespace.cs: Use existing error message.
7107 * report.cs: New warning.
7109 2007-02-06 Marek Safar <marek.safar@gmail.com>
7111 A fix for bug #80742
7112 * expression.cs: Delegate Invoke method can be called directly.
7114 2007-02-06 Marek Safar <marek.safar@gmail.com>
7116 A fix for bug #80676
7117 * class.cs (IsEntryPoint): The Main method can have params modifier.
7119 2007-02-04 Miguel de Icaza <miguel@novell.com>
7121 * parameter.cs (Parameter, Parameters): Add Clone method.
7123 * anonymous.cs (Compatible): Turn method into virtual method, so
7124 LambdaExpression can implement a different behavior.
7126 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
7127 out the basic checking here, so it can be used by
7130 * lambda.cs: Introduce "Compatible" function that will do the
7133 2007-02-02 Marek Safar <marek.safar@gmail.com>
7135 * attribute.cs: Unified one error message.
7137 * class.cs (Class): Use type attributes and not properties to test static
7139 (IsEntryPoint): Don's pass local variable.
7141 * convert.cs: Removed duplicate check.
7143 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
7145 * driver.cs: Don't crash when soft reference does not exist.
7147 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
7148 (UsingEntry): Removed redundant allocation.
7150 * parameter.cs: Add fast path for type parameters.
7152 * support.cs: Don't allocate attribute when it's not used.
7154 2007-01-30 Miguel de Icaza <miguel@novell.com>
7157 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
7158 this into a virtual method, so we can override it in LambdaExpression.
7160 * driver.cs: Improve diagnostics in case of failure.
7162 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
7163 write a function that is slightly more complex and that parses:
7165 type identifier [, type identifier]* )
7167 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
7170 (canEmpty ? i >= 0 : i > 0)
7172 2007-01-30 Raja R Harinath <rharinath@novell.com>
7174 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
7175 exception on possibly valid code.
7177 2007-01-29 Raja R Harinath <rharinath@novell.com>
7179 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
7181 (parse_opt_type_arguments): Remove. It's almost the same as
7183 (parse_namespace_or_typename): Use parse_less_than.
7185 2007-01-28 Miguel de Icaza <miguel@novell.com>
7187 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
7188 this bug took a few hours to find, because the state saved and
7189 restored by PushPosition and PopPosition was ignoring the state of
7190 parse_generic_less_than.
7192 I can also now remove the handling of OP_LT and OP_GT, this solves
7195 * cs-tokenizer.cs: store the location for the ARROW token, we use
7198 (PushPosition, PopPosition): save/restore also `current_token',
7199 restore `parse_generic_less_than' (was missing).
7201 (parse_opt_type_arguments): use parse_type, not
7202 parse_namespace_or_typename to parse types.
7204 * lambda.cs: Empty new file, will eventually have the lambda
7205 expression implementation.
7207 * lambda.test: used to test the internal tokenizer.
7209 * report.cs (FeatureIsNotISO1): Rename from
7210 FeatureIsNotStandardized, because it was about the language level
7211 (1 vs 2) it was not about standarization.
7213 (FeatureRequiresLINQ): New.
7215 * support.cs (SeekableStreamReader): Only require that the reader
7216 is a TextReader, not a StreamReader, so we can plug StringReader.
7218 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
7219 given position in the input stream the following tokens can be
7220 parsed as a type followed by an identifier.
7222 (is_punct): after a '(' if parse_type_and_parameter returns true,
7223 then return a special token OPEN_PARENS_LAMBDA which is used to
7224 avoid reduce/reduce errors in the grammar for the
7225 lambda_expression rules.
7227 (parse_type): implement a type parser inside the
7228 tokenizer, the parser only returns true or false depending on
7229 whether the input at a given position can be parsed as a type.
7231 (peek_token): new method used during type parsing.
7233 2007-01-28 Raja R Harinath <rharinath@novell.com>
7236 * anonymous.cs (ScopeInfo.InflateParameters): New.
7237 (AnonymousContainer.Resolve): Use it to redirect types of
7238 delegate parameters.
7240 2007-01-27 Raja R Harinath <rharinath@novell.com>
7243 * expression.cs (Error_InvalidArguments): Don't use two different
7244 messages for CS1503. Use ExtraInformation and
7245 SymbolRelatedToPreviousError instead.
7248 * decl.cs (DeclSpace.initialize_type_params): Don't access
7249 'type_params' of a partial class directly.
7251 2007-01-26 Miguel de Icaza <miguel@novell.com>
7253 * constant.cs: Removed a handful of out-of-range checks that were
7256 2007-01-25 Marek Safar <marek.safar@gmail.com>
7258 * expression.cs (CheckUselessComparison): Add additional check for char
7261 * namespace.cs: Fixed typo.
7263 2007-01-23 Miguel de Icaza <miguel@novell.com>
7265 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
7266 gone, instead we inline the test, preventing the needless casts to
7267 longs, ulongs and doubles for the parameters, avoiding calls to
7268 methods that overchecked stuff, and instead inlined things
7271 2007-01-20 Marek Safar <marek.safar@gmail.com>
7273 * cs-parser.jay: Better parameter error handling.
7275 2007-01-17 Marek Safar <marek.safar@gmail.com>
7277 A fix for bug #80368, #80522
7278 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
7279 whether array initializer contains constants only.
7280 (ArrayCreation.Emit): Use better formula to decide when
7281 are array initializers for static initialization.
7282 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
7283 have to emit even constants otherwise they are pre-initialized.
7285 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
7286 Raja R Harinath <rharinath@novell.com>
7288 Fix emit order of 'get' vs. 'set'.
7289 * support.cs (Accessors): New.
7290 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
7291 Note the order in which accessors are declared in the source.
7292 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
7293 Refactored from Property.Define and Indexer.Define.
7294 (PropertyBase.DefineAccessors): New helper that calls the above in
7295 appropriate order as noted by the parser.
7296 (Property.Define, Indexer.Define): Update to changes.
7297 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
7299 2007-01-17 Raja R Harinath <rharinath@novell.com>
7301 Fix cs0029-6.cs and gcs0029-2.cs (regression)
7302 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
7303 there's an implicit conversion from the current type to the target
7304 type before converting the underlying constant.
7306 2007-01-16 Marek Safar <marek.safar@gmail.com>
7308 * const.cs (ResolveValue): Updated after constant conversion was made more
7311 * constant.cs (GetAttributableValue): constant to object conversion is
7312 used for attributes only.
7313 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
7314 constant conversions.
7315 (LongConstant.ConvertImplicitly): Ditto.
7317 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
7318 (ImplicitConversionStandard): Handle constant conversion as extra step.
7319 It solves the issue when constant conversion was called indirectly like
7320 inside array initializer and constant folding was skipped.
7322 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
7325 * statement.cs(ImplicitConversionStandard): Updated after constant
7326 conversion was made more generic.
7328 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
7330 * expression.cs (As.DoResolve): Use GenericConstraints instead of
7331 Constraints, solves the problem where the compiler incorrectly
7332 reported that a type parameter was not constrained to a class (Bug
7335 2007-01-14 Marek Habersack <grendello@gmail.com>
7337 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
7339 2007-01-14 Marek Safar <marek.safar@gmail.com>
7341 A fix for bug #80368
7342 * assign.cs (FieldInitializer): New class implements field
7343 initializer statement.
7345 * attribute.cs: Update after FieldMember rename.
7347 * class.cs (PropertyBasedMember): New common class for property based
7349 (InterfaceMemberBase): New base class for all members which can be used as
7350 an interface members.
7351 (MethodCore): Moved really common code to InterfaceMemberBase.
7352 (Method.Define): Equal and GetHasCode detection is relevant for methods
7354 (MethodData.Define): Don't assume that public event implements an
7355 interface automatically.
7356 (MethodData.DefineMethodBuilder): Issue an error even if only extern
7358 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
7359 (FieldMember): Merged with FieldBase.
7360 (EventProperty.AEventPropertyAccessor): New specialization to check whether
7361 event extern modifier can be used.
7362 (EventField.EventFieldAccessor): Moved event field specific code here.
7363 (Event.AllowedModifiers): Even event can be extern.
7364 (Event.FindOutBaseMethod): New override specific to events.
7365 (Indexer.parameters): Reintroduce parameters because base class holds
7366 only properties common data.
7367 (Indexer.CheckForDuplications): Indexers are threated as methods so we
7368 need do extra parameters check.
7370 * const.cs: Update after FieldMember rename.
7372 * decl.cs (MemberCache.FindBaseEvent): New method.
7374 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
7375 to reflect that indexer is now derived from PropertyBased.
7377 * ecore.cs (GetMemberType): Made public.
7378 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
7381 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
7383 * typemanager.cs (CSharpSignature): Correctly print event accessors.
7384 (RegisterEvent): Removed.
7385 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
7386 (GetPrivateFieldOfEvent): Renamed to GetEventField.
7388 2007-01-11 Raja R Harinath <rharinath@novell.com>
7391 * statement.cs (CollectionForeach.TryType): Prefer generic
7392 GetEnumerator over non-generic variant. Fix code to follow comments.
7394 2007-01-09 Raja R Harinath <rharinath@novell.com>
7397 * support.cs (ReflectionParameter): Don't use an invalid index on
7398 the generic parameter data.
7400 2007-01-08 Miguel de Icaza <miguel@novell.com>
7402 * driver.cs: Just add a tiny bit of infrastructure.
7404 2007-01-02 Marek Safar <marek.safar@gmail.com>
7406 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
7407 where field type is struct from current assembly.
7409 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
7412 2007-01-02 Marek Safar <marek.safar@gmail.com>
7414 A fix for bug #80381
7415 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
7418 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
7420 (Namespace.LookupType): Always use core types from corlib when speficied.
7422 * report.cs: A new warning.
7424 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
7425 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
7426 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
7428 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
7429 (InitCoreTypes): Set expression type of object_type and value_type
7430 immediately after lookup.
7432 2007-01-01 Miguel de Icaza <miguel@novell.com>
7434 * cs-tokenizer.cs: Accept Pc class characters (Connector
7435 Punctuation) as valid identifiers. Fixes #78259
7437 * expression.cs (Invocation.DoResolve): Moved the check for the
7438 use of `this' for doing method calls to the Invocation resolution
7439 step, after overload resolution has taken place instead of doing
7440 the check at the low-level `This.DoResolve' level.
7442 The `This.DoResolve'(appens before overload resolution, so it has
7443 no way of knowing if the method that will be called will be
7444 instace or static, triggering an erroneous report for cs0188 (Bug
7447 We now do the check for instance method invocations after we know
7448 what method will be called.
7450 (This.CheckThisUsage): Move the actual use of this structure
7451 checking into its own method and expose it.
7453 * Everywhere that called Error_ValueCannotBeConverted: pass a new
7456 Exceptions: Null.ConvertImplicitly,
7457 Constant.ImplicitConversionRequired as there are too many call
7458 sites for passing the ec.
7460 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
7461 EmitContext, if the value is null, then we do not try to provide
7462 the extra information from the error (If a userdefined conversion
7463 exists, as UserDefinedConversion requires a non null-EmitContext).
7467 2006-12-30 Raja R Harinath <rharinath@novell.com>
7469 * flowanalysis.cs (MyBitVector): Document some invariants.
7470 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
7471 introduced below, and add a couple of others,
7473 2006-12-30 Marek Safar <marek.safar@gmail.com>
7475 * attribute.cs (GetMethodObsoleteAttribute): Uses new
7476 GetPropertyFromAccessor and GetEventFromAccessor.
7478 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
7479 overrides non-obsolete one.
7480 (Indexer.Define): Error message has been moved to the parser.
7482 * cs-parser.jay: Better syntax errors handling.
7484 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
7485 when an invocation has no arguments.
7487 * ecore.cs: Removed not used caching.
7489 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
7492 * report.cs: Add a new warning.
7494 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
7496 * typemanager.cs (enumeration_type): Removed.
7497 (CSharpSignature): Reuses IsSpecialMethod.
7498 (IsEqual): Hack for MS BCL.
7499 (GetPropertyFromAccessor): New method.
7500 (GetEventFromAccessor): New method.
7501 (IsSpecialMethod): Fixed to handle more cases.
7503 2006-12-30 Marek Safar <marek.safar@gmail.com>
7505 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
7506 Made white spaces array static.
7508 * ecore.cs (RemoveGenericArity): Optimized.
7510 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
7512 (MyBitVector.initialize_vector): Simplified.
7514 2006-12-22 Miguel de Icaza <miguel@novell.com>
7516 * ecore.cs: Am not entirely happy with this hack, but it seems to
7517 address the issue in 80257 (a small test case for
7520 I set the MethodGroupExpr.Type to an internal compiler type
7521 (itself in this case) to force the resolution to take place. Why
7522 it does not take place with a null is beyond me.
7524 2006-12-20 Marek Safar <marek.safar@gmail.com>
7526 A fix for bug #80288
7527 * expression.cs (ResolveOperator): Consider user defined conversion for
7528 logical and operator too.
7529 (EmitBranchable): Optimization for logical and when full constant folding
7530 could not be applied but one operand is constant.
7532 2006-12-19 Marek Safar <marek.safar@gmail.com>
7534 * class.cs (GetClassBases): Write 5 times every day, will never use
7535 FullName for error reporting.
7537 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
7539 2006-12-19 Martin Baulig <martin@ximian.com>
7541 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
7542 the symbol file info here.
7544 2006-12-18 Marek Safar <marek.safar@gmail.com>
7546 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
7547 of `elseif' is taking then following sections are not taking.
7548 Fixes an issue reported on mono mailing list.
7550 2006-12-18 Marek Safar <marek.safar@gmail.com>
7552 A fix for bug #80300
7553 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
7554 a caller is not taking.
7556 2006-12-18 Raja R Harinath <rharinath@novell.com>
7558 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
7559 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
7560 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
7561 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
7562 * class.cs: Update to changes.
7564 2006-12-17 Marek Safar <marek.safar@gmail.com>
7566 A fix for bug #79934
7567 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
7570 * class.cs (ResolveMembers): Register an iterator in current container and
7573 2006-12-16 Raja R Harinath <rharinath@novell.com>
7576 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
7577 satisfy a params annotated parameter.
7579 2006-12-16 Marek Safar <marek.safar@gmail.com>
7581 A fix for bug #77014
7582 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
7583 paramters correctly and not rely on hacks in Parameters class.
7584 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
7586 (Invocation.VerifyArgumentsCompat): Ditto.
7587 (Invocation.EmitArguments): Changed to correctly emit params arguments at
7590 * parameter.cs (HasParams): Don't assume that params is the last one.
7592 * support.cs (ReflectionParameters.ctor): Look for params attribute
7594 (ReflectionParameters.ParameterType): Removed hack when we returned last
7595 parameter for out of range parameters.
7596 (ParameterName, ParameterModifier): Ditto.
7598 2006-12-14 Marek Safar <marek.safar@gmail.com>
7600 A fix for bug #79987
7601 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
7602 when assembly is not CLS compliant but type is. I have no idea why is this
7605 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
7607 2006-12-13 Miguel de Icaza <miguel@novell.com>
7609 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
7610 in struct constructors, they are basically no-ops.
7612 2006-12-12 Marek Safar <marek.safar@gmail.com>
7614 * cs-tokenizer.cs (Position): Save preprocessor status too.
7616 2006-12-12 Marek Safar <marek.safar@gmail.com>
7618 A fix for bug #77794
7619 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
7621 2006-12-12 Marek Safar <marek.safar@gmail.com>
7623 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
7625 (pp_expr): Report error for an invalid expression.
7626 (handle_preprocessing_directive): Simplified; add more error checking.
7628 2006-12-11 Marek Safar <marek.safar@gmail.com>
7630 A fix for bug #74939
7631 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
7632 directives handling.
7634 2006-12-10 Marek Safar <marek.safar@gmail.com>
7636 A fix for bugs #80093, and #75984
7637 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
7638 logic, it seems to me as it worked before "by coincidence".
7639 (xtoken): Simplified to use reworked handle_preprocessing_directive.
7640 (cleanup): Enabled endif check.
7642 2006-12-09 Marek Safar <marek.safar@gmail.com>
7644 A fix for bug #80162
7645 * statement.cs (CollectionForeach.TryType): Generics and non-generics
7646 enumerators are never ambiguous.
7648 2006-12-08 Raja R Harinath <rharinath@novell.com>
7651 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
7653 2006-12-06 Marek Safar <marek.safar@gmail.com>
7655 A fix for bug #80144
7656 * class.cs (EventProperty.Define): Explicit implementation means
7657 that an even is used.
7659 2006-12-06 Marek Safar <marek.safar@gmail.com>
7661 Fixes the operators implementation (part II)
7663 * cfold.cs (DoConstantNumericPromotions): Renamed to
7664 DoBinaryNumericPromotions and simplified.
7665 (BinaryFold): Couple of conversion fixes; simplified.
7667 * constant.cs, ecore.cs, literal.cs
7668 (ToType): Renamed to ConvertImplicitly.
7669 (Reduce): Renamed to ConvertExplicitly.
7671 * class.cs, convert.cs: Updated.
7673 * expression.cs: TryReduce doesn't throw an exception.
7675 2006-12-01 Marek Safar <marek.safar@gmail.com>
7677 A fix for bug #80108
7678 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
7681 2006-11-30 Marek Safar <marek.safar@gmail.com>
7683 Fixes unary operators implementation (part I)
7686 * cfold.cs (Error_CompileTimeOverflow): Made internal
7688 * const.cs (IConstant): Changed to use reference to constant and
7689 not constant itself.
7690 Updated IConstant implementations.
7692 * constant.cs (CreateConstant): New factory method.
7693 Updated IConstant implementation.
7695 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
7697 * ecore.cs: Updated to use CreateConstantReference.
7699 * enum.cs: Reflects IConstant changes.
7701 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
7703 * literal.cs (NullConstant): Change to be independently usable.
7705 2006-11-29 Martin Baulig <martin@ximian.com>
7707 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
7708 we need to emit the scope initializer before calling the base .ctor.
7710 * anonymous.cs: Merged back from the new anonymous methods branch.
7711 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
7713 * expression.cs (ParameterReference.DoResolveBase): Create a
7714 "normal" ScopeInfo when capturing parameters rather than using the
7715 root scope; this makes things work with anonymous methods having
7719 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
7721 2006-11-22 Marek Safar <marek.safar@gmail.com>
7723 A fix for bug #79987
7724 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
7725 check to a base class.
7726 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
7727 only when assembly has missing attribute.
7728 * report.cs: Update.
7730 2006-11-21 Marek Safar <marek.safar@gmail.com>
7732 * cs-tokenizer.cs: Merged with gmcs version.
7734 2006-11-20 Marek Safar <marek.safar@gmail.com>
7737 * cs-parser.jay: Better error message when partial keyword is misplaced.
7739 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
7741 A fix for bug #79810
7742 report.cs: CS1058 only applies to 2.0 profile (gmcs).
7743 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
7744 a RuntimeWrappedException by default.
7746 2006-11-18 Marek Safar <marek.safar@gmail.com>
7748 A fix for bug #79843
7749 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
7751 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
7753 2006-11-18 Marek Safar <marek.safar@gmail.com>
7755 * driver.cs, namespace.cs: Uses faster IndexOf version.
7757 2006-11-17 Marek Safar <marek.safar@gmail.com>
7759 A fix for bug #79941
7760 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
7762 (Operator.Define): Implicit/Explicit operator of same type is duplicate
7763 even if internal name is different.
7764 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
7765 (UserDefinedConversion): Simplified as the operators cannot be internal.
7766 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
7768 (MethodLookup): Replaced EmitContext with parentType.
7769 * expression.cs: Updated.
7771 2006-11-09 Raja R Harinath <rharinath@novell.com>
7773 * driver.cs (BadAssembly): Handle all the ugliness of
7774 DefineDynamicAssembly.
7776 2006-11-08 Raja R Harinath <rharinath@novell.com>
7778 Address parts of #58244 -- most of what's left is in the runtime
7779 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
7780 CS1509 error checks, and handle them for all assembly loads, not
7781 just the first invocation.
7782 (LoadModule): Likewise. Move handling of 'adder_method' ...
7783 * codegen.cs (AssemblyClass.AddModule): ... here.
7785 2006-11-02 Marek Safar <marek.safar@gmail.com>
7787 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
7788 IEnumerable<T> is ambiguous.
7790 2006-10-31 Marek Safar <marek.safar@gmail.com>
7792 A fix for bug #67689
7793 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
7794 GetEnumerator is ambiguous.
7796 * report.cs: Add new warning.
7798 2006-10-29 Marek Safar <marek.safar@gmail.com>
7800 A fix for bug #78602
7801 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
7802 to protected member can be nested type.
7804 2006-10-28 Marek Safar <marek.safar@gmail.com>
7806 A fix for bug #78965
7807 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
7808 to protected member must derive from current type.
7810 2006-10-27 Marek Safar <marek.safar@gmail.com>
7812 assign.cs: Reuses error method.
7814 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
7815 instead of type for constants.
7816 (Expression.Error_ValueAssignment): Common error method.
7818 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
7821 2006-10-27 Marek Safar <marek.safar@gmail.com>
7823 A fix for bug #79081
7824 * expression.cs (MemberAccess.DoResolve): Check nested type
7827 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
7829 * doc.cs : nested delegates were not handled. Fixed bug #79754.
7831 2006-10-26 Marek Safar <marek.safar@gmail.com>
7833 A fix for bug #76591
7834 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
7836 2006-10-26 Marek Safar <marek.safar@gmail.com>
7838 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
7839 type forwarder of the same type multiple times.
7841 2006-10-26 Raja R Harinath <rharinath@novell.com>
7844 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
7845 instance as an rvalue, even when we later resolve as an lvalue.
7847 2006-10-25 Martin Baulig <martin@ximian.com>
7849 * anonymous.cs: Fix #79673.
7851 2006-10-24 Marek Safar <marek.safar@seznam.cz>
7853 A fix for bug #79666
7854 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
7855 ignored when is optimized (= default value) as its value is already set.
7857 2006-10-23 Marek Safar <marek.safar@seznam.cz>
7859 A fix for bug #79724
7860 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
7861 TypeContainer for type lookup.
7863 2006-10-23 Marek Safar <marek.safar@seznam.cz>
7865 A fix for bug #79231
7866 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
7867 * expression.cs (OverloadResolve): Always convert type name for
7869 (ResolveNamespaceOrType): Don't confuse a nested type with any
7872 2006-10-18 Martin Baulig <martin@ximian.com>
7874 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
7876 2006-10-17 Miguel de Icaza <miguel@novell.com>
7878 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
7879 an int32, but requesting an int64 from the conversion
7881 2006-10-12 Martin Baulig <martin@ximian.com>
7884 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
7886 2006-10-12 Martin Baulig <martin@ximian.com>
7889 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
7891 2006-10-11 Miguel de Icaza <miguel@novell.com>
7893 * convert.cs: Remove broken code: I was doing the "Existance"
7894 tests for Implicit conversions.
7896 2006-10-10 Miguel de Icaza <miguel@novell.com>
7898 * convert.cs: Added one missing case in
7899 ImplicitStandardConversionExists uint64 to intptr.
7903 * typemanager.cs (uintptr_type): another core known type.
7905 * ecore.cs (OperatorCast): routine used to do cast operations that
7906 depend on op_Explicit. We could change some of the Decimal
7907 conversions to use this.
7909 This one has a probe mechanism that checks both types for an op_
7910 which it coudl be used to eliminate two classes: CastToDecimal
7911 and CastFromDecimal.
7913 * convert.cs: Implement the conversions documented in #59800
7915 2006-10-10 Martin Baulig <martin@ximian.com>
7917 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
7918 before RootScope.ResolveMembers().
7920 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
7921 `CurrentType' if appropriate.
7923 2006-10-09 Marek Safar <marek.safar@seznam.cz>
7925 A fix for bug #78568
7926 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
7927 when contains binary operators.
7928 * cs-parser.jay: Updated.
7930 2006-10-09 Martin Baulig <martin@ximian.com>
7933 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
7934 moved that into Define() and also do the other type parameter
7935 checks there. Fixes #79094. Added gtest-292.cs.
7938 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
7939 since that doesn't include type parameters; don't use `Ldelema'
7940 for type parameters. Fixes #78980. Added gtest-293.cs.
7942 2006-10-08 Marek Safar <marek.safar@seznam.cz>
7945 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
7946 conversion is allowed.
7948 2006-10-06 Marek Safar <marek.safar@seznam.cz>
7950 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
7951 error reporting when no error occurs.
7953 2006-10-06 Marek Safar <marek.safar@seznam.cz>
7955 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
7958 2006-10-06 Raja R Harinath <rharinath@novell.com>
7961 * class.cs (DefineTypeBuilder): Check circular dependencies before
7962 setting the parent of the TypeBuilder.
7963 (CheckRecursiveDefinition): Don't use 'BaseType', since
7964 it may not be valid until after DefineTypeBuilder. Use
7965 'base_type' instead.
7967 2006-10-04 Martin Baulig <martin@ximian.com>
7969 Merged the Anonymous Methods patch.
7971 * anonymous.cs, iterators.cs: The new anonymous methods code.
7973 * statement.cs (Variable): New public abstract class.
7974 (LocalInfo.Variable): New public property.
7975 (LocalInfo.ResolveVariable): New public method.
7976 (Block.Flags): Add `IsIterator'.
7977 (Block.AddVariable): Improved the CS0136 check.
7978 (Block.AnonymousChildren): New public property.
7979 (Block.AddAnonymousChild): New public method.
7980 (ToplevelBlock): Update to use the new anonymous method framework.
7981 (ToplevelBlock.ctor): `container' is now a `Block' and not a
7982 `ToplevelBlock'; this is required to correctly implement the
7984 (Fixed, Using): Use `TemporaryVariable' instead of directly
7985 creating the `LocalBuilder'.
7987 * parameter.cs (Parameter.ResolveVariable): New public method.
7988 (Parameters.ResolveVariable): Likewise.
7990 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
7992 * class.cs (TypeContainer): Replaced the `iterators' list and
7993 corresponding methods with a list of `CompilerGeneratedClass'es.
7994 (TypeContainer.ResolveMembers): New public method.
7995 (Method): `IIteratorContainer' has been replaced by
7998 * expression.cs (VariableReference): New public abstract base
7999 class for `LocalVariableReference', `ParameterReference' and
8002 * codegen.cs (EmitContext): Removed `capture_context',
8003 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
8004 (EmitContext.EmitThis): Removed.
8006 * cs-parser.jay: Replace `iterator_container' with
8009 2006-10-04 Martin Baulig <martin@ximian.com>
8011 * generic.cs (GenericMethod): Don't make this abstract.
8012 (Constraints.Clone): Added dummy implementation.
8014 2006-10-04 Raja R Harinath <harinath@gmail.com>
8017 * namespace.cs (LookForAnyGenericType): Avoid nullref on
8018 'declspaces'. Avoid allocating arrays willy-nilly.
8021 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
8022 cases out of the switch.
8024 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8026 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
8027 message when non-generic type is used with the type arguments.
8028 * expression.cs: Updated.
8030 2006-09-28 Raja R Harinath <rharinath@novell.com>
8033 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
8034 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8035 Change semantics slightly. Don't insist on having only one
8036 temporary EmptyExpression -- just throttle the creation of new ones.
8039 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
8040 non-interfaces too. If no methods are found, don't try to create
8043 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8045 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
8048 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
8049 us produce better error message.
8051 2006-09-27 Marek Safar <marek.safar@seznam.cz>
8053 * expression.cs (Binary.ResolveOperator): Warn about a side effect
8054 of the `|' operator.
8056 * report.cs: A new warning added.
8058 2006-09-27 Martin Baulig <martin@ximian.com>
8060 * generic.cs (GenericMethod): Don't make this abstract.
8062 2006-09-27 Martin Baulig <martin@ximian.com>
8065 (InternalErrorException): Added overloaded ctor taking a params array.
8067 2006-09-26 Marek Safar <marek.safar@seznam.cz>
8069 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
8070 Fixed the cases when same error was reported twice.
8072 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
8073 now report symbol information.
8075 2006-09-25 Martin Baulig <martin@ximian.com>
8077 * class.cs: Completely unified with the gmcs version.
8079 2006-09-25 Martin Baulig <martin@ximian.com>
8081 * typemanager.cs (TypeManager.IsNullableType): New public function.
8082 (TypeManager.IsNullableTypeOf): Likewise.
8083 (TypeManager.IsNullableValueType): Likewise.
8085 * class.cs (MethodCore): Added the `GenericMethod' argument from
8086 gmcs and also unified all classes derived from `MethodCore' with gmcs.
8088 2006-09-24 Raja R Harinath <harinath@gmail.com>
8090 * convert.cs: Unify with gmcs version.
8092 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8094 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
8095 verify them as well.
8097 * report.cs: New warning.
8099 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8101 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
8102 for anonymous block with out argument.
8104 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8106 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
8107 not used private events only.
8109 2006-09-23 Marek Safar <marek.safar@seznam.cz>
8111 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
8113 * const.cs (Const.Define): Check for constant type.
8114 (Const.IsConstantTypeValid): Looks for valid constant types.
8116 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
8118 * ecore.cs (EmptyConstantCast): New common class for all constant based
8121 * expression.cs (Is.DoResolve): Handle null constant especially.
8122 (New.DoResolve): Check for new void().
8123 (MemberAccess.DoResolve): Cope with all kind of nulls.
8125 * literal.cs (NullConstant): Uses EmptyConstantCast.
8126 (NullDefault): Based on EmptyConstantCast.
8127 (NullLiteral): Uses EmptyConstantCast.
8129 * statement.cs (Block.ResolveMeta): Check for constant type.
8131 2006-09-22 Martin Baulig <martin@ximian.com>
8133 * delegate.cs, attribute.cs: Merged with the gmcs versions.
8135 2006-09-22 Raja R Harinath <rharinath@novell.com>
8137 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
8141 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
8142 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
8145 2006-09-22 Martin Baulig <martin@ximian.com>
8147 * ecore.cs: Merged with the gmcs version.
8149 * generic.cs (ConstructedType): New dummy class.
8150 (TypeArguments): Don't make this abstract.
8153 (TypeManager.IsGenericTypeDefinition): New method.
8154 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
8156 2006-09-22 Raja R Harinath <rharinath@novell.com>
8158 * expression.cs (ComposedCast): Check for arrays of TypedReference
8159 before creating the type, not after.
8161 2006-09-21 Marek Safar <marek.safar@seznam.cz>
8163 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
8164 after ToType change.
8166 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
8167 when constant must be implicitly convertible.
8169 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
8171 * ecore.cs (NullCast): Derives from NullConstant.
8173 * expression.cs (Is.DoResolve): Removed useless variables.
8174 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
8175 (New.Constantify): Add enum support.
8176 (MemberAccess.DoResolve): Add warning when accessing null constant or
8179 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
8182 * literal.cs (NullConstant): New abstract class with common
8183 functionality for all null specializations.
8184 (NullDefault): Represents default(X) when result can be
8186 (NullLiteral): Updated.
8188 * report.cs: Add new warning.
8190 2006-09-21 Martin Baulig <martin@ximian.com>
8192 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
8194 2006-09-21 Martin Baulig <martin@ximian.com>
8196 * generic.cs (GenericConstraints): New dummy class.
8197 (Constraints): Likewise.
8198 (TypeParameter): Likewise.
8199 (TypeParameterName): Likewise.
8200 (GenericMethod): Likewise.
8202 * typemanager.cs (TypeManager.GetGenericArguments): New method.
8204 * decl.cs: Merged with the gmcs version.
8206 2006-09-21 Raja R Harinath <rharinath@novell.com>
8208 * generic.cs (TypeParameter): Implement IMemberContainer.
8209 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
8211 * rootcontext.cs: Unify with gmcs version.
8213 * report.cs: Unify with gmcs version.
8214 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
8215 from gmcs/generics.cs.
8216 * generics.cs (TypeParameter): New dummy class.
8218 * support.cs: Unify with gmcs version.
8220 2006-09-20 Raja R Harinath <rharinath@novell.com>
8222 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
8223 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
8225 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
8226 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
8227 * mcs.exe.sources: Add generic.cs.
8229 * codegen.cs: Unify with gmcs version.
8231 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
8232 (EmitContext): Add GenericDeclContainer implementation.
8233 * decl.cs (MemberCore, DeclSpace): Likewise.
8234 * namespace.cs: Remove #ifdef GMCS_SOURCE.
8236 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
8237 MCS TypeManager has a corresponding dummy method.
8239 2006-09-19 Martin Baulig <martin@ximian.com>
8241 * expression.cs: Completely merged with the gmcs version.
8243 2006-09-19 Martin Baulig <martin@ximian.com>
8245 * expression.cs (Invocation): Merged with the gmcs version.
8246 (ArrayAccess.GetStoreOpcode): Likewise.
8248 2006-09-19 Martin Baulig <martin@ximian.com>
8251 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
8252 (TypeManager.IsGenericMethodDefinition): Likewise.
8254 2006-09-19 Martin Baulig <martin@ximian.com>
8257 (TypeManager.IsEqual): Moved the gmcs implementation here.
8258 (TypeManager.DropGenericTypeArguments): Likewise.
8259 (TypeManager.DropGenericMethodArguments): Likewise.
8260 (TypeManager.GetTypeArguments): Moved here from gmcs.
8261 (TypeManager.HasGenericArguments): Likewise.
8263 2006-09-19 Martin Baulig <martin@ximian.com>
8265 * expression.cs (Binary): Merged with the gmcs version.
8267 2006-09-19 Martin Baulig <martin@ximian.com>
8269 * expression.cs (Probe, As, Is): Merged with the gmcs version.
8271 2006-09-19 Martin Baulig <martin@ximian.com>
8273 * typemanager.cs: Merged with the gmcs version.
8275 2006-09-16 Raja R Harinath <rharinath@novell.com>
8277 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
8278 * driver.cs: Likewise.
8280 2006-09-16 Marek Safar <marek.safar@seznam.cz>
8283 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
8284 only if parent type is class.
8285 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
8288 2006-09-15 Marek Safar <marek.safar@seznam.cz>
8291 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
8293 * typemanager.cs(CSharpName): Converts NullType to null.
8295 2006-09-15 Martin Baulig <martin@ximian.com>
8298 (TypeManager.GetMethodName): Added mcs implementation.
8299 (TypeManager.IsEqual): Likewise.
8302 (SimpleName.RemoveGenericArity): Added dummy implementation.
8304 * pending.cs: Merged with the gmcs version.
8306 2006-09-15 Martin Baulig <martin@ximian.com>
8308 * statement.cs: Merge with the gmcs version.
8310 2006-09-15 Martin Baulig <martin@ximian.com>
8312 * statement.cs (Switch): Merge with the gmcs implementation
8313 (without nullables), which is newer.
8315 2006-09-15 Martin Baulig <martin@ximian.com>
8317 * statement.cs (Block.Variables): Make this public.
8318 (ToplevelBlock.Parameters): Make this a property.
8319 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
8321 2006-09-15 Martin Baulig <martin@ximian.com>
8323 * namespace.cs: Merge with the gmcs version.
8325 2006-09-15 Martin Baulig <martin@ximian.com>
8327 * decl.cs (MemberName): Minor code cleanups.
8329 2006-09-15 Martin Baulig <martin@ximian.com>
8331 * parameter.cs: Merge with the gmcs version.
8333 2006-09-15 Martin Baulig <martin@ximian.com>
8335 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
8336 and an error in mcs.
8338 2006-09-15 Martin Baulig <martin@ximian.com>
8340 * flowanalysis.cs: Merged from GMCS; added the generics code into
8341 a `GMCS_SOURCE' conditional so we can share this file.
8343 2006-09-08 Martin Baulig <martin@ximian.com>
8345 * typemanager.cs (TypeManager.interlocked_type): New public field.
8346 (TypeManager.int_interlocked_compare-exchange): New public field.
8347 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
8348 enumerator types here and call InitGenericCoreTypes().
8349 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
8350 after calling InitEnumUnderlyingTypes().
8353 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
8354 `classes_second_stage'.
8356 2006-09-14 Marek Safar <marek.safar@seznam.cz>
8358 * assign.cs, ecore.cs, expression.cs: Share error message text.
8359 * class.cs (FieldMember.Define): Check for varible of static type.
8360 * driver.cs (LoadAssembly): Uses error output for errors.
8361 * statement.cs: Updated.
8363 2006-09-08 Marek Safar <marek.safar@seznam.cz>
8365 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
8368 2006-09-07 Martin Baulig <martin@ximian.com>
8371 (MainDriver): Revert r62663 from Marek; see #70506 for details.
8373 2006-08-29 Miguel de Icaza <miguel@novell.com>
8375 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
8377 2006-08-17 Miguel de Icaza <miguel@novell.com>
8379 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
8380 #52019 and #79064, the use of the \uXXXX sequence in source code
8381 to represent unicode characters.
8383 2006-08-15 Marek Safar <marek.safar@seznam.cz>
8385 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
8387 * class.cs, ecore.cs, statement.cs: Merged to one error message.
8389 2006-08-13 Miguel de Icaza <miguel@novell.com>
8391 * assign.cs: Catch attempts to assign to a method groups in += and
8394 2006-08-13 Marek Safar <marek.safar@seznam.cz>
8397 * cs-parser.jay: Don't destroy current array type by typeof of array's.
8399 2006-08-12 Marek Safar <marek.safar@seznam.cz>
8401 * class.cs (Method.Define): Issue a warning when generic method looks like
8403 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
8406 2006-08-09 Marek Safar <marek.safar@seznam.cz>
8408 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
8410 * decl.cs (MemberCache.FindMembers): When container is interface we need to
8411 search all base interfaces as a member can be ambiguous.
8412 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
8413 Constructor member type filter.
8414 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
8415 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
8416 reporting for returned memberinfos.
8417 * report.cs: Updated.
8418 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
8419 version to work on all runtimes.
8420 (TypeManager.RealMemberLookup): Removed members filtering.
8422 2006-08-08 Raja R Harinath <rharinath@novell.com>
8424 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
8425 (PropertyExpr.EmitAssign): Likewise.
8426 * expression.cs (Indirection.EmitAssign): Likewise.
8427 (LocalVariableReference.EmitAssign): Likewise.
8428 (ParameterReference.EmitAssign): Likewise.
8429 (Invocation.EmitArguments): Likewise.
8430 (ArrayAccess.EmitAssign): Likewise.
8431 (IndexerAccess.EmitAssign): Likewise.
8432 (This.EmitAssign): Likewise.
8433 (ConditionalLogicalOperator.Emit): Likewise.
8436 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
8437 instead of ArrayList. If the hashtable has a LocalBuilder, don't
8438 leave it in after returning it.
8439 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
8441 2006-08-06 Marek Safar <marek.safar@seznam.cz>
8443 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
8446 2006-08-03 Raja R Harinath <rharinath@novell.com>
8448 Fix cs0146-3.cs and cs0146-4.cs.
8449 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
8450 enclosing types don't depend on the current type.
8452 2006-08-02 Raja R Harinath <rharinath@novell.com>
8455 * class.cs (TypeContainer.DoDefineMembers): Use
8456 FindBaseMemberWithSameName on Parent, since we're interested in
8457 whether we hide inherited members or not.
8458 (FindBaseMemberWithSameName): Make slightly more robust.
8460 Fix the non-generic testcase from #77396
8461 * decl.cs (DeclSpace.DeclContainer): Remove override.
8463 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
8464 declspaces for doppelgangers too.
8465 (UsingEntry): Implement IResolveContext.
8466 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
8467 'this' as the resolve context.
8468 (LocalAliasEntry): Likewise.
8470 Implement parts of #77403
8471 * roottypes.cs (RootDeclSpace): New. Used to represent the
8472 toplevel declaration space. Each namespace declaration introduces
8473 a "partial" root declaretion space.
8474 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
8475 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
8476 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
8477 from 'current_namespace.SlaveDeclSpace'.
8478 (namespace_declaration): Likewise.
8479 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
8480 check. It can't happen now.
8481 * decl.cs (DeclSpace.LookupType): Likewise.
8482 * driver.cs (MainDriver): Sanity check.
8484 2006-08-01 Raja R Harinath <rharinath@novell.com>
8486 * decl.cs (DeclSpace.FindNestedType): Remove.
8487 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
8488 LookupTypeContainer to get the container of the nested type.
8489 * class.cs (TypeContainer.FindNestedType): Make non-override.
8491 2006-07-31 Raja R Harinath <rharinath@novell.com>
8493 * decl.cs (DeclSpace.PartialContainer): Move field from ...
8494 * class.cs (TypeContainer.PartialContainer): ... here.
8495 (TypeContainer.AddBasesForPart): New helper.
8496 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
8498 * cs-parser.jay (current_class): Convert to DeclSpace.
8499 (struct_declaration, interface_declaration, class_declaration):
8500 Use AddBasesForPart instead of .Bases directly.
8501 * const.cs, iterators.cs: Update to changes.
8503 2006-07-28 Raja R Harinath <rharinath@novell.com>
8505 * class.cs (TypeContainer.AddMemberType): Rename from
8507 (TypeContainer.AddMember): Rename from AddToMemberContainer.
8508 (AddTypeContainer): New. Combine AddClassOrStruct and
8510 (AddPartial): Update. Add 'is_partial' argument.
8511 * roottypes.cs: Update to changes.
8512 * cs-parser.jay (push_current_class): New helper for handling
8513 current_container and current_class.
8514 (struct_declaration, interface_declaration, class_declaration):
8517 2006-07-26 Raja R Harinath <rharinath@novell.com>
8519 * roottypes.cs: Rename from tree.cs.
8521 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
8522 * tree.cs (Tree, ITreeDump): Remove types.
8523 * rootcontext.cs (tree, Tree): Remove fields.
8524 (root, ToplevelTypes): New.
8525 * *.cs: Update to rename.
8527 * tree.cs (Tree.RecordDecl): Remove.
8528 (RootTypes.AddToTypeContainer): Record the toplevel type in its
8530 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
8532 2006-07-23 Raja R Harinath <harinath@gmail.com>
8534 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
8535 DoFlowAnalysis and OmitStructFlowAnalysis here.
8536 (ec.With): Rename from WithUnsafe and generalize.
8537 (ec.WithCheckState): Remove. All users can be handled by 'With'.
8538 (ec.WithFlowAnalyis): New.
8539 * ecore.cs, expression.cs, statement.cs: Update.
8541 2006-07-22 Raja R Harinath <harinath@gmail.com>
8543 * statement.cs (Block.ResolveMeta): Simplify slightly.
8545 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
8546 multiple boolean fields. Convert InUnsafe, constant_check_state,
8547 check_state to flags.
8548 (CheckState, ConstantCheckState): Update.
8549 (InUnsafe): New read-only property.
8550 (FlagsHandle): Rename from CheckStateHandle and convert to handle
8552 (WithUnsafe): New helper similar to WithCheckState.
8553 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
8554 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
8556 2006-07-21 Raja R Harinath <rharinath@novell.com>
8558 Make comparisons use the same IL irrespective of whether they're
8559 in a 'checked' or 'unchecked' context: one of the issues in #78899
8560 * codegen.cs (EmitContext.CheckState): Make read-only property.
8561 (EmitContext.ConstantCheckState): Likewise.
8562 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
8563 helper that implement a save/restore stack for CheckState
8564 values. This is the only way to change check-state.
8565 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
8566 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
8567 (CheckedExpr.EmitBranchable): New forwarding method.
8568 (UnCheckedExpr): Likewise.
8569 * statement.cs (Block.ResolveMeta): Use WithCheckState.
8570 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
8571 (Checked.Resolve, checked.DoEmit): Likewise.
8573 2006-07-20 Miguel de Icaza <miguel@novell.com>
8575 * anonymous.cs: Cache the resolved anonymous delegate, and return
8576 this so that the ResolveTopBlock is only triggered once, not
8579 Currently we trigger ResolvetopBlock twice due to a first pass of
8580 argument check compatibility, and a second pass that does the
8583 2006-07-15 Marek Safar <marek.safar@seznam.cz>
8585 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
8587 * rootcontext.cs (Reset): Add helper_classes.
8589 2006-07-15 Marek Safar <marek.safar@seznam.cz>
8592 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
8595 2006-07-13 Miguel de Icaza <miguel@novell.com>
8597 * statement.cs (Lock): Handle expressions of type
8598 TypeManager.null_type specially. Fixes #78770
8600 2006-07-08 Marek Safar <marek.safar@seznam.cz>
8602 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
8605 2006-07-08 Marek Safar <marek.safar@seznam.cz>
8607 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
8608 for accessors as well.
8609 * ecore.cs (EventExpr): Add AccessorTable.
8611 2006-07-01 Marek Safar <marek.safar@seznam.cz>
8614 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
8615 for CS0122 where appropriate.
8616 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
8618 (Filter): Assembly can be null in the case of top level attributes.
8620 2006-06-25 Marek Safar <marek.safar@seznam.cz>
8624 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
8625 is done at global level.
8627 2006-06-24 Marek Safar <marek.safar@seznam.cz>
8629 A fix for #77002, Implemented TypeForwarder support.
8631 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
8632 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
8633 * typemanager.cs (): Add type_forwarder_attr_type.
8635 2006-06-24 Marek Safar <marek.safar@seznam.cz>
8637 * report.cs: Add CS0469 warning.
8639 2006-06-21 Martin Baulig <martin@ximian.com>
8641 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
8642 the `try'-block, so we also report CS0016 etc. there.
8644 2006-06-21 Martin Baulig <martin@ximian.com>
8647 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
8649 2006-06-21 Martin Baulig <martin@ximian.com>
8651 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
8652 also report CS1686 for parameters.
8654 2006-06-21 Martin Baulig <martin@ximian.com>
8656 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
8657 instead of an error if the value is not implicitly convertible to
8658 the switch types; fixes #77964.
8660 2006-06-21 Raja R Harinath <rharinath@novell.com>
8663 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
8664 FieldBuilder is null.
8667 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
8668 'left' and 'right' before error-checking.
8670 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
8672 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
8674 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
8675 (FieldExpr.DoResolve): likewise.
8676 (PropertyExpr.InstanceResolve): likewise.
8677 (EventExpr.InstanceResolve): likewise.
8679 2006-06-04 Marek Safar <marek.safar@seznam.cz>
8681 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
8682 attribute applicable tests for attribute argument.
8684 2006-06-02 Raja R Harinath <rharinath@novell.com>
8687 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
8688 (Binary.OverloadResolve_PredefinedIntegral): New.
8689 (Binary.OverloadResolve_PredefinedFloating): New.
8690 (Binary.OverloadResolve_PredefinedString): New.
8691 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
8692 Follow the standard more closely, and treat numeric promotions in
8693 terms of overload resolution.
8694 (Binary.CheckShiftArguments): Simplify.
8696 2006-06-01 Raja R Harinath <rharinath@novell.com>
8698 * flowanalysis.cs (MyBitVector): Simplify representation.
8699 (MyBitVector.Clone): Avoid allocating BitArray.
8700 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
8701 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
8702 (*): Update. Change all references to MyBitVector.And and
8703 MyBitVector.Or to &= and |=.
8705 2006-05-29 Raja R Harinath <rharinath@novell.com>
8708 * cs-parser.jay (formal_parameter_list): Extend the pattern below
8709 to param arguments too.
8711 2006-05-26 Miguel de Icaza <miguel@novell.com>
8713 * cs-parser.jay: Catch another parsing form for arglist being
8714 followed by other arguments. Fixes #78313.
8716 2006-05-24 Raja R Harinath <rharinath@novell.com>
8718 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
8719 checking of out parameters to ...
8720 (FlowBranchingToplevel.Merge): ... here.
8721 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
8722 set, propagate the origin upward, and only complain if there was
8724 (FlowBranchingException.AddContinueOrigin): Likewise.
8725 (FlowBranchingException.AddReturnOrigin): Likewise.
8726 (FlowBranchingException.AddGotoOrigin): Likewise.
8728 2006-05-23 Raja R Harinath <rharinath@novell.com>
8730 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
8731 unreachable, skip it.
8732 (FlowBranchingException.Merge): Always propagate jumps, even if
8733 the finally block renders subsequent code unreachable.
8735 2006-05-18 Raja R Harinath <rharinath@novell.com>
8738 * statement.cs (Goto.Resolve): Move responsibility for resolving
8739 'goto' to FlowBranching.AddGotoOrigin.
8740 (Goto.SetResolvedTarget): New. Callback to set the
8741 LabeledStatement that's the target of the goto.
8742 (Goto.DoEmit): Use Leave instead of Br when crossing an
8743 unwind-protect boundary.
8744 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
8745 LookupLabel and adjust to new semantics.
8746 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
8747 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
8748 Goto.SetResolvedTarget to update target.
8749 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
8750 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
8751 AddBreakOrigin & co. Delay propagation until ...
8752 (FlowBranchingException.Merge): ... this.
8754 * statement.cs (Block.Resolve): Always depend on flow-branching to
8755 determine unreachability. Kill workaround that originally emitted
8756 only one statement after an "unreachable" label (see infloop in
8759 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
8760 This is still "wrong", but anything better would probably need a
8761 multi-pass algorithm.
8762 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
8763 usage vector. Force current usage vector to be reachable, to
8764 optimistically signify backward jumps.
8765 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
8767 (FlowBranchingLabeled.Merge): New. If no backward jump was
8768 detected, return the original salted-away usage vector instead,
8769 updated with appropriate changes. Print unreachable warning if
8771 * statement.cs (Block.Resolve): Don't print unreachable warning on
8772 a labeled statement.
8774 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
8776 * driver.cs: Pass filename without path to AssemblyBuilder's
8777 AddResourceFile. Fixes bug #78407.
8779 2006-05-17 Raja R Harinath <rharinath@novell.com>
8781 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
8782 * flowanalysis.cs (FlowBranchingLabeled): ... here.
8783 (FlowBranching.MergeChild): Overwrite
8784 reachability information from Labeled branchings too.
8786 2006-05-16 Raja R Harinath <rharinath@novell.com>
8788 * statement.cs (Goto.Resolve): Merge jump origins here ...
8789 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
8791 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
8792 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
8793 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
8794 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
8796 * statement.cs (Goto.Resolve): ... not here.
8797 (Goto.Emit): Remove CS1632 check.
8799 2006-05-14 Marek Safar <marek.safar@seznam.cz>
8801 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
8804 2006-05-11 Raja R Harinath <rharinath@novell.com>
8806 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
8807 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
8808 (FlowBranchingException.Label): Likewise.
8810 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
8812 (MyBitVector.Or): Use it to avoid losing information (Count).
8813 (FlowBranching.MergeOrigins): Likewise.
8815 * flowanalysis.cs (UsageVector.IsDirty): Remove.
8816 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
8817 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
8818 (UsageVector.ToString): Simplify.
8819 (UsageVector.MergeSiblings): Move here from ...
8820 (FlowBranching.Merge): ... here.
8821 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
8824 2006-05-10 Raja R Harinath <rharinath@novell.com>
8826 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
8827 null bitvector is treated as all-true.
8829 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
8830 (MyBitVector): Rationalize invariants. 'vector != null' implies
8831 that we have our own copy of the bitvector. Otherwise,
8832 'InheritsFrom == null' implies all inherited bits are true.
8834 2006-05-09 Marek Safar <marek.safar@seznam.cz>
8836 * statement.cs (LocalInfo): Add IsConstant.
8837 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
8838 local variable for constants.
8840 2006-05-09 Raja R Harinath <rharinath@novell.com>
8842 * flowanalysis.cs (MyBitVector.Empty): New.
8843 (MyBitVector): Don't allow InheritedFrom to be null.
8844 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
8845 (UsageVector, FlowBranching): Update to changes.
8847 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
8848 recursion. The 'Parent == null' condition isn't sufficient for
8850 (FlowBranching.AddBreakOrigin): Likewise.
8851 (FlowBranching.AddContinueOrigin): Likewise.
8852 (FlowBranching.AddReturnOrigin): Likewise.
8853 (FlowBranching.StealFinallyClauses): Likewise.
8854 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
8855 (FlowBranching.CheckOutParameters): Likewise.
8856 (FlowBranchingToplevel): Terminate all the above recursions here.
8857 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
8858 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
8860 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
8862 (FlowBranchingToplevel): New. Empty for now.
8863 (FlowBranching.MergeTopBlock): Update.
8864 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
8865 branching for the anonymous delegate.
8866 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
8868 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
8869 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
8870 information at the start of the merge. Reorganize.
8872 2006-05-07 Marek Safar <marek.safar@seznam.cz>
8874 * class.cs (MethodData.Define): Method cannot implement interface accessor.
8876 2006-05-07 Marek Safar <marek.safar@seznam.cz>
8878 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
8879 to newly introduced ctor.
8881 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
8882 message to one place.
8883 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
8886 2006-05-07 Marek Safar <marek.safar@seznam.cz>
8888 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
8890 * ecore.cs (Expression.ResolveAsConstant): Updated.
8892 * statement.cs (ResolveMeta): Updated.
8894 2006-05-06 Marek Safar <marek.safar@seznam.cz>
8896 * cs-parser.jay: __arglist cannot be used in initializer.
8898 2006-05-06 Marek Safar <marek.safar@seznam.cz>
8901 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
8904 2006-05-05 Raja R Harinath <rharinath@novell.com>
8906 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
8907 (LabeledStatement): Add 'name' parameter.
8908 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
8909 (Block.AddLabel): Update to changes.
8910 * cs-parser.jay (labeled_statement): Likewise.
8912 * flowanalysis.cs (BranchingType.Labeled): New.
8913 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
8914 (FlowBranchingLabeled): New. Does nothing for now, but will
8915 eventually handle 'goto' flows.
8916 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
8917 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
8918 that's terminated ...
8919 (Block.Resolve): ... here.
8921 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
8922 (UsageVector.MergeFinallyOrigins): Likewise.
8923 (FlowBranching.InTryOrCatch): Likewise.
8924 (FlowBranching.AddFinallyVector): Likewise.
8925 (FlowBranchingException): Update to changes.
8928 * statement.cs (Return.Resolve): Move error checking to ...
8929 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
8930 (FlowBranchingException): Handle return origins like break and
8932 (FlowBranching.UsageVector.CheckOutParameters): Remove.
8934 2006-05-04 Marek Safar <marek.safar@seznam.cz>
8937 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
8940 2006-05-04 Marek Safar <marek.safar@seznam.cz>
8943 * class.cs (MethodData.Define): Do public accessor check only when method
8944 implements an interface.
8946 2006-05-04 Raja R Harinath <rharinath@novell.com>
8948 Remove special handling of 'break'
8949 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
8950 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
8951 (UsageVector.Break): Remove.
8952 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
8954 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
8956 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
8957 UsageVector.Breaks (). Don't set NeedsReturnLabel.
8959 2006-05-03 Marek Safar <marek.safar@seznam.cz>
8962 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
8963 be the interface member.
8965 2006-05-03 Marek Safar <marek.safar@seznam.cz>
8968 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
8969 for emitting small (int) values.
8971 2006-05-03 Raja R Harinath <rharinath@novell.com>
8974 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
8975 control-flow passes through the 'finally' after merging-in all the
8976 control-flows from 'try' and the 'catch' clauses.
8978 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
8979 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
8980 always true at the only non-recursive entry point.
8981 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
8982 FlowBranchingBreakable.
8983 (FlowBranchingLoop): Remove.
8984 * statement.cs (Return.DoResolve): Update to changes.
8987 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
8988 (FlowBranching.CreateBranching): Handle it: create a
8989 FlowBranchingContinuable.
8990 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
8991 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
8992 except that it handles the 'continue' command.
8993 (FlowBranching.UsageVector.MergeOrigins): Rename from
8995 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
8996 except that it overrides AddContinueOrigin.
8997 (FlowBranchingException): Override AddContinueOrigin, similar to
8999 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
9000 Create a new branching around the embedded statement.
9001 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
9002 control flow after the embedded statement.
9003 (Continue.Resolve): Move all error checking to AddContinueOrigin.
9005 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
9006 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
9007 FlowBranchingBreakable.
9008 (FlowBranchingSwitch): Remove.
9011 * statement.cs (Break.Resolve): Simplify. Move responsibility for
9012 error reporting to ...
9013 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
9014 Rename from 'AddBreakVector'. Add new location argument. Return
9015 a bool indicating whether the 'break' crosses an unwind-protect.
9016 (FlowBranchingException.AddBreakOrigin): Add.
9017 (FlowBranchingException.Merge): Propagate 'break's to surrounding
9018 flowbranching after updating with the effects of the 'finally'
9020 (FlowBranchingBreakable): New common base class for
9021 FlowBranchingLoop and FlowBranchingSwitch.
9023 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
9025 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
9027 2006-05-02 Raja R Harinath <rharinath@novell.com>
9029 * statement.cs (Do.Resolve): If the loop is infinite, set the
9031 (While.Resolve, For.Resolve): Set a barrier after the embedded
9032 statement. There's no direct control flow that goes from the end
9033 of the embedded statement to the end of the loop.
9034 * flowanalysis.cs (FlowBranching.Infinite): Remove.
9035 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
9036 above ensure that the reachability is correctly computed.
9038 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
9039 (UsageVector.MergeBreakOrigins): If the current path is
9040 unreachable, treat it as if all parameters/locals are initialized.
9041 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
9042 infinite loops before merging-in break origins.
9044 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
9045 (Reachability.Reachable): Split part into ...
9046 (Reachability.Unreachable): ... this. Simplify.
9047 (Reachability.IsUnreachable): Use 'Unreachable' instead.
9049 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
9050 (Reachability.SetThrowsSometimes): Likewise.
9051 (FlowBranchingBlock.MergeTopBlock): Don't compare against
9052 TriState.Always, use corresponding property.
9053 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
9054 (Block.Resolve): Likewise. Remove some redundant checks.
9056 2006-05-02 Raja R Harinath <harinath@gmail.com>
9058 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
9059 (Reachability.Meet): Don't bother checking AlwaysThrows --
9060 barrier is always set.
9061 (FlowBranchingBlock.Merge): Likewise.
9063 2006-05-01 Raja R Harinath <harinath@gmail.com>
9065 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
9066 checks for unreachable.
9068 2006-05-01 Marek Safar <marek.safar@seznam.cz>
9071 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
9073 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
9074 whether field is really assigned.
9076 2006-04-30 Raja R Harinath <harinath@gmail.com>
9078 * flowanalysis.cs (Reachability): Make 4-argument constructor
9080 (Reachability.Meet): Rename from 'And'. Remove static variant.
9081 (Reachability.Always): Rename from the highly misleading
9082 'Reachability.Never'.
9083 (FlowBranching.Merge): Update to changes. Mark an impossible
9084 situation with a 'throw'.
9085 (*): Update to changes.
9087 2006-04-29 Raja R Harinath <harinath@gmail.com>
9089 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
9091 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
9092 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
9093 (*): Update to changes.
9094 * statement.cs: Update to changes.
9096 2006-04-28 Marek Safar <marek.safar@seznam.cz>
9099 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
9101 2006-04-28 Raja R Harinath <harinath@gmail.com>
9103 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
9106 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
9107 argument to two arguments: an usage-vector and a bool. Move call
9108 to FlowBranching.Merge () ...
9109 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
9111 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
9112 handling of loop and switch reachability to ...
9113 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
9115 2006-04-27 Raja R Harinath <harinath@gmail.com>
9117 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
9118 handling to FlowBranchingLoop.InLoop.
9119 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
9121 2006-04-26 Marek Safar <marek.safar@seznam.cz>
9124 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
9125 anonymous method is allowed from AnonymousContainer here.
9127 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
9129 2006-04-24 Raja R Harinath <rharinath@novell.com>
9132 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
9134 2006-04-23 Marek Safar <marek.safar@seznam.cz>
9137 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
9138 (DoubleConstant.Reduce): Ditto.
9140 2006-04-23 Raja R Harinath <rharinath@novell.com>
9142 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
9143 Remove 'lvalue_right_side' argument. Move parts to ...
9144 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
9145 (LocalVariable.DoResolveLValue): ... these.
9147 2006-04-21 Raja R Harinath <rharinath@novell.com>
9150 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
9151 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
9152 (LocalVariableReference.DoResolveBase): Use it to implement new
9154 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
9155 (Argument.Resolve): Simplify. Move CS1510 check ...
9156 * ecore.cs (Expression.ResolveLValue): ... here.
9157 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
9158 (PropertyExpr.DoResolveLValue): Likewise.
9159 (FieldExpr.Report_AssignToReadonly): Likewise.
9160 (FieldExpr.DoResolve): Add 'out_access' argument. Use
9161 LValueMemberAccess or LValueMemberOutAccess on instance depending
9163 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
9164 DoResolve as appropriate.
9166 2006-04-20 Raja R Harinath <rharinath@novell.com>
9169 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
9170 implicit conversions on 'out' and 'ref' arguments.
9172 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
9173 improve clarity. Remove dead code.
9176 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
9177 (Catch.Resolve): Resolve VarBlock if it exists.
9179 2006-04-19 Miguel de Icaza <miguel@novell.com>
9181 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
9182 twice, this was some residual code, the enumerator was emitted
9183 properly in the two branche of if later.
9185 2006-04-19 Raja R Harinath <rharinath@novell.com>
9187 * expression.cs (Cast.ResolveLValue): Remove. The result of a
9188 cast is never an lvalue.
9189 (Cast.DoResolve, Cast.ResolveRest): Combine.
9190 (Argument.Emit): Simplify slightly. Move 'Expr is
9191 IMemoryLocation' check ...
9192 (Argument.Resolve): ... here.
9193 (Argument.Error_LValueRequired): Remove. Inline into only user.
9195 Simplifications. Fix cs0191-2.cs
9196 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
9197 CS1649 and CS1651 to ...
9198 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
9199 the actual selection of the error code and message to a lookup
9200 table. Add a dummy return value to simplify callsites.
9201 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
9202 readonly fields of other instances of the same type. Move CS0197
9204 * expression.cs (Argument.Resolve): ... here. Simplify code.
9205 Ensure that ec.InRefOutArgumentResolving is only set during LValue
9206 resolution of an out or ref argument. The code simplification
9207 above uses this invariant.
9209 2006-04-18 Raja R Harinath <rharinath@novell.com>
9211 Possibly fix #77752. Fix cs1690-[4-7].cs.
9212 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
9213 CheckMarshallByRefAccess. Drop parameter.
9214 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
9216 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
9218 * report.cs (AllWarnings): Add CS1690.
9219 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
9221 (LocalVariableReference.DoResolveBase): Update.
9223 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9225 * class.cs (MethodOrOperator): Moved common parts from method class.
9226 detect obsolete attributes.
9227 (Method.Define): Simplified as it reuses code from base.
9228 (Constructor.ValidAttributeTargets): Fixed issue found during
9230 (Destructor.ValidAttributeTargets): Fixed issue found during
9232 (Operator): Finished refactoring set off by #78020. Operator class is now
9233 ordinary method class.
9235 * anonymous.cs: Updated.
9237 * decl.cs (DeclSpace): Add IsGeneric
9239 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9241 * class.cs (Constructor.Emit): Don't emit the attributes twice.
9243 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9245 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
9246 detect obsolete attributes.
9247 (Method.CreateEmitContext): Moved to MethodOrOperator.
9249 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9252 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
9253 customized exception to make crash detection easier.
9254 (MethodOrOperator): Started to work on new base class for methods and
9256 (Method): Derives from MethodOrOperator.
9257 (Constructor.Emit): Emits its own attributes.
9258 (AbstractPropertyEventMethod.Emit): Ditto.
9259 (Operator): Derives from MethodOrOperator, will refactor fully in extra
9261 (Operator.Emit): It's temporary more tricky than should be.
9263 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
9265 * report.cs (InternalErrorException): Add ctor with inner exception.
9267 2006-04-08 Marek Safar <marek.safar@seznam.cz>
9270 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
9273 2006-04-07 Marek Safar <marek.safar@seznam.cz>
9276 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
9279 2006-04-06 Marek Safar <marek.safar@seznam.cz>
9281 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
9282 attribute is present and Guid not.
9283 (Interface.ApplyAttributeBuilder): Ditto.
9285 * attribute.cs: Add error message.
9287 2006-04-06 Marek Safar <marek.safar@seznam.cz>
9291 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
9292 sources (it's composite) so hold them in extra array as they are used in
9293 Emit phase only. It worked in the previous versions by mistake.
9294 (Attribute.Emit): Emit attribute for more owners when exist.
9296 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
9297 it has now different behaviour.
9299 2006-04-04 Marek Safar <marek.safar@seznam.cz>
9301 * constant.cs (Constant.IsDefaultInitializer): New method.
9303 * class.cs: Updated.
9305 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
9306 re-initialize default values. It saves KBs almost for every assembly.
9307 Thanks Zoltan for the idea.
9308 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
9309 (ArrayCreation.DoResolve): Resolve only once.
9310 (ArrayCreation.Emit): Emit static initializer only when it is faster.
9311 (ArrayCreation.GetAttributableValue): Cope with optimized values.
9313 2006-04-03 Zoltan Varga <vargaz@gmail.com>
9315 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
9318 2006-04-01 Marek Safar <marek.safar@seznam.cz>
9320 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
9321 in an embedded statement too.
9323 2006-04-01 Raja R Harinath <rharinath@novell.com>
9326 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
9328 2006-04-01 Marek Safar <marek.safar@seznam.cz>
9332 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
9335 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
9337 2006-03-31 Marek Safar <marek.safar@seznam.cz>
9339 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
9342 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
9343 LocalTemporary change.
9345 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
9347 (ClassOrStruct.DefineFieldInitializers): Implemented static field
9348 initializers optimization.
9349 (ClassOrStruct.TypeAttr): Moved from modifiers.
9350 (Constructor.CheckBase): Don't crash when static ctor has parameters.
9351 (FieldBase.ResolveInitializer): Resolves initializer.
9352 (FieldBase.HasDefaultInitializer): New property.
9354 * cs-parser.jay: Removed message.
9356 * expression.cs (CompilerGeneratedThis): New specialization.
9358 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
9360 2006-03-28 Marek Safar <marek.safar@seznam.cz>
9362 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
9364 2006-03-27 Marek Safar <marek.safar@seznam.cz>
9366 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
9367 be now EnumConstants only.
9369 2006-03-27 Marek Safar <marek.safar@seznam.cz>
9371 * attribute.cs, driver.cs: Reset more caches.
9373 2006-03-26 Marek Safar <marek.safar@seznam.cz>
9375 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
9377 2006-03-26 Marek Safar <marek.safar@seznam.cz>
9379 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
9380 for easier reuse. Updated all overrides.
9381 (IntegralConstant): New base class for all integral constants.
9382 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
9383 of the constant range, report custom error.
9384 (UIntConstant.Reduce): Fixed uint conversion.
9386 * ecore.cs, literal.cs: Reduce updates.
9388 2006-03-26 Marek Safar <marek.safar@seznam.cz>
9392 * class.cs (Constructor.Define): Removed extra if for default ctors.
9393 A patch from Atsushi Enomoto.
9395 2006-03-26 Marek Safar <marek.safar@seznam.cz>
9397 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
9398 GetAttributableValue.
9400 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
9403 * convert.cs (ImplicitConversionRequired): Error message moved to
9406 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
9407 automatic implicit conversion of an output value.
9408 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
9410 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
9412 (TypeOf.GetAttributableValue): Add extra handling for object type.
9414 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
9415 special error message.
9417 2006-03-25 Marek Safar <marek.safar@seznam.cz>
9419 * class.cs (Constructor.Emit): Don't crash when struct ctor is
9421 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
9422 compatible with MS runtime.
9424 2006-03-23 Marek Safar <marek.safar@seznam.cz>
9426 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
9427 attribute arguments here.
9429 * class.cs (Indexer.Define): The check was moved to attribute class.
9431 2006-03-22 Marek Safar <marek.safar@seznam.cz>
9433 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
9434 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
9437 2006-03-22 Raja R Harinath <rharinath@novell.com>
9439 Support ParameterDefaultValueAttribute in gmcs. Also applied to
9440 mcs to keep code differences small.
9441 * attribute.cs (Attribute.GetParameterDefaultValue): New.
9442 * typemanager.cs (parameter_default_value_attribute_type): New.
9443 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
9446 2006-03-21 Marek Safar <marek.safar@seznam.cz>
9448 * expression.cs (StringConcat.Append): Reverted back to no warning state.
9450 2006-03-21 Marek Safar <marek.safar@seznam.cz>
9452 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
9454 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
9457 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
9459 * doc-bootstrap.cs : fix build.
9461 2006-03-20 Marek Safar <marek.safar@seznam.cz>
9463 * expression.cs (StringConcat.Append): Issue a warning when empty string
9466 2006-03-20 Marek Safar <marek.safar@seznam.cz>
9468 * assign.cs (CompoundAssign.ResolveSource): Removed.
9470 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
9473 * class.cs (TypeContainer.FindMethods): Removed.
9474 (TypeContainer.CheckMemberUsage): Made static.
9476 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
9478 * constant.cs (CheckRange): Removed unused type argument.
9479 (CheckUnsigned): Removed unused type argument.
9481 * cs-parser.jay: Updated after MemberAccess clean up.
9482 Uses Length for empty string test.
9484 * cs-tokenizer.cs: Uses Length for empty string test.
9485 (IsCastToken): Made static.
9486 (is_hex): Made static.
9487 (real_type_suffix): Made static.
9489 * decl.cs (SetupCache): Made static.
9490 (OnGenerateDocComment): Removed unused ds argument.
9492 * delegate.cs (VerifyDelegate): Removed unused argument.
9494 * doc.cs: Uses Length for empty string test.
9496 * driver.cs: Uses Length for empty string test.
9498 * enum.cs (IsValidEnumType): Made static
9500 * expression.cs (EnumLiftUp): Removed unused argument.
9501 (ResolveMethodGroup): Ditto.
9502 (BetterConversion): Ditto.
9503 (GetVarargsTypes): Ditto.
9504 (UpdateIndices): Ditto.
9505 (ValidateInitializers): Ditto.
9506 (MemberAccess.ctor): Ditto.
9507 (GetIndexersForType): Ditto.
9509 * flowanalysis.cs: (MergeFinally): Removed unused argument.
9511 * iterators.cs: Updated after MemberAccess clean up.
9513 * location.cs: Uses Length for empty string test.
9515 * namespace.cs: Uses Length for empty string test.
9517 * report.cs (CheckWarningCode): Made static.
9519 * statement.cs (LabeledStatement): Removed unused argument.
9521 * typemanager.cs (FilterNone): Removed.
9523 2006-03-18 Marek Safar <marek.safar@seznam.cz>
9525 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
9528 * class.cs: Updated.
9530 2006-03-18 Marek Safar <marek.safar@seznam.cz>
9532 * cs-parser.jay.cs: __arglist is not allowed for delegates.
9534 2006-03-18 Marek Safar <marek.safar@seznam.cz>
9538 * expression.cs (VerifyArgumentsCompat): Reverted to double error
9539 reporting, it's more tricky than I thought.
9541 2006-03-18 Marek Safar <marek.safar@seznam.cz>
9545 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
9547 (AnonymousMethod.ImplicitStandardConversionExists): New method.
9548 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
9549 Add more error reporting; Fixed issue with params.
9551 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
9553 * cs-parser.jay: AnonymousMethod requires host container.
9555 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
9557 2006-03-18 Raja R Harinath <harinath@gmail.com>
9559 * class.cs: Change 'TypeContainer ds' constructor argument to
9560 'DeclSpace parent'. Some classes were missed below due to
9561 different naming convention.
9563 * class.cs (MemberCore.Parent): Delete. This makes the
9564 ParentContainer changes below enforceable by the compiler.
9566 Treat pointers to enclosing declaration space as 'DeclSpace', not
9568 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
9569 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
9571 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
9573 (Block.AddThisVariable): Likewise.
9574 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
9575 (AbstractPropertyEventMethod.Emit): Likewise.
9576 (AbstractPropertyEventMethod.EmitMethod): Likewise.
9577 (GetMethod.Define, SetMethod.Define): Likewise.
9578 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
9579 (DelegateMethod.EmitMethod): Likewise.
9581 Fix regression test-partial-13.cs.
9582 Rationalize use of PartialContainer. Ensure that the partial
9583 class semantics can be tied to type-correctness, i.e., any
9584 violation will cause a compile error.
9585 * class.cs, const.cs: Access all fields that belong to class
9586 TypeContainer via ParentContainer. Arguments of EmitContexts and
9587 Resolve()-like functions still use 'Parent'.
9589 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
9590 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
9591 (PropertyMethod.CheckModifiers): Remove unused argument.
9592 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
9595 2006-03-17 Raja R Harinath <harinath@gmail.com>
9597 Make semantics of PartialContainer simpler.
9598 * decl.cs (DeclSpace.IsPartial): Remove.
9599 * class.cs (TypeContainer.IsPartial): Likewise.
9600 (TypeContainer..ctor): Set PartialContainer to point to self.
9601 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
9602 (TypeContainer.FindNestedType): Likewise.
9603 (MemberCore.ParentContainer): Simplify. Remove deprecation.
9605 2006-03-17 Marek Safar <marek.safar@seznam.cz>
9607 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
9609 2006-03-15 Marek Safar <marek.safar@seznam.cz>
9611 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
9614 2006-03-15 Marek Safar <marek.safar@seznam.cz>
9616 * class.cs (Operator.Define): An error for base conversion was not
9619 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
9621 * iterator.cs : yield break is allowed in try statement which has
9622 catch clauses. Fixed bug #77767.
9624 2006-03-13 Marek Safar <marek.safar@seznam.cz>
9626 A fix for #77593, #77574.
9628 * class.cs (MethodCore.CheckBase): Another if for operator.
9630 2006-03-09 Marek Safar <marek.safar@seznam.cz>
9632 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
9635 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
9636 (DelegateCreation.ImplicitStandardConversionExists): New method for just
9639 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
9642 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
9643 Updated after another emitcontext usage was clean up. It should help us to
9644 synchronize with gmcs easier.
9646 2006-03-04 Marek Safar <marek.safar@seznam.cz>
9650 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
9651 (Event.Define): ditto
9652 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
9654 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
9655 Removed redundant code and set NewSlot for Invoke method too.
9657 * parameter.cs (Parameters.ctor): Add custom, type ctor.
9658 (Parameters.MergeGenerated): New method. Use this method when you merge
9659 compiler generated argument with user arguments.
9661 2006-03-03 Marek Safar <marek.safar@seznam.cz>
9663 * attribute.cs (ResolveAsTypeTerminal): Removed.
9665 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
9666 specialization for predefined types; 30% speed up.
9667 Finally placed obsolete check to right place.
9668 (Expression.ResolveType): Removed.
9670 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
9671 Updated after ResolveType was removed.
9673 * expression.cs (Cast.ctor): Check void cast.
9674 (Binary.ResolveAsTypeTerminal): Is never type.
9675 (Conditional.ResolveAsTypeTerminal): Is never type.
9677 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
9679 2006-03-01 Raja R Harinath <rharinath@novell.com>
9682 * expression.cs (ParameterReference.DoResolveBase): Change return
9684 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
9688 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
9691 * typemanager.cs (GetFullNameSignature): Don't nullref on
9692 protected accessors.
9694 2006-02-27 Marek Safar <marek.safar@seznam.cz>
9696 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
9697 these two separated members to simplify the code.
9698 (Attribute.Resolve): Refactored to use new fields and methods.
9699 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
9700 implemented obsolete attribute checking.
9701 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
9702 implemented obsolete checking again. It look line never ending quest ;-)
9703 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
9705 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
9707 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
9709 *class.cs (Property.Define): Add RegisterProperty call.
9711 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
9712 argument groups (only 2).
9714 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
9715 encoding expression to arguments.
9716 (Expression.ExprClassToResolveFlags): Just turned to property.
9718 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
9719 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
9720 optimized as well as implemented support for zero-length attributes.
9722 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
9723 Add caching of PropertyInfo's.
9725 2006-02-25 Marek Safar <marek.safar@seznam.cz>
9727 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
9728 error multiple times.
9730 2006-02-25 Marek Safar <marek.safar@seznam.cz>
9732 New partial class implementation.
9733 A fix for #77027, #77029, #77403
9735 * attribute.cs (Attributable): Made attributes protected.
9737 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
9738 the replacements of ClassPart and PartialContainer.
9739 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
9740 (TypeContainer.AddInterface): Ditto.
9741 (TypeContainer.AddPartial): The main method for partial classes. It checks
9742 for errors and merges ModFlags and attributes. At the end class is added to
9744 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
9746 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
9747 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
9748 from the rest of partial classes.
9749 (TypeContainer.GetClassBases): Simplified.
9750 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
9752 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
9753 (TypeContainer.HasExplicitLayout): Uses Flags now.
9754 (PartialContainer): Removed.
9755 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
9756 (StaticClass): Was merged with Class.
9757 (Class.GetClassBases): class and static class bases are verified here.
9758 (Class.TypeAttr): Added static attributes when class is static.
9759 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
9760 (MemberBase): In some cases we need to call parent container for partial
9761 class. It should be eliminated but it's not easy now.
9763 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
9765 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
9766 partial classed to accumulate class comments.
9767 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
9769 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
9771 * driver.cs (MainDriver): Tree.GetDecl was removed.
9773 * modifiers.cs (Modifiers): Add partial modifier.
9775 * tree.cs (Tree.decl): Removed.
9776 (RootTypes): Started to use this class more often for root types
9779 2006-02-22 Marek Safar <marek.safar@seznam.cz>
9783 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
9784 external interface does not have an attribute.
9786 2006-02-22 Marek Safar <marek.safar@seznam.cz>
9788 Another prerequisites for new partial classs implementation.
9790 * attribute.cs (Attribute.Equal): Implemented.
9791 (Attribute.Emit): Changed as attributes can be applied more than twice.
9792 (Attributes.Emit): Check for duplicate attributes here.
9794 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
9795 as a parameter, clean-up.
9797 2006-02-11 Marek Safar <marek.safar@seznam.cz>
9801 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
9802 contains obsolete attribute check which can in some cases look for base
9803 type of current class which is not initialized yet.
9804 (TypeContainer.BaseType): Replacement of ptype.
9806 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
9808 2006-02-11 Marek Safar <marek.safar@seznam.cz>
9810 First of prerequisites for new partial classs implemention.
9812 * attribute.cs (Attributable): Extended by ResolveContext;
9813 Attributes finally have correct context for resolving in all cases.
9814 (AttachTo): Attribute owner is assigned here.
9816 * codegen.cs (IResolveContext): Introduce new interface to hold
9817 all information needed in resolving phase.
9818 (EmitContext): Implements IResolveContext; more clean-up needed here.
9820 * decl.cs (MemberCore): Implemented IResolveContext.
9822 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
9823 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
9824 parameter.cs, statement.cs, tree.cs, typemanager.cs:
9825 Refactored to use new IResolveContext instead of EmitContext; cleanup
9827 2006-02-06 Miguel de Icaza <miguel@novell.com>
9829 * codegen.cs (EmitScopeInitFromBlock): check here the
9830 capture_context, there is no need to make two calls to the
9833 * anonymous.cs: Add some debugging messages that might help me
9834 track other instances of this problem in the future (the
9835 regression of test 467).
9837 * cs-parser.jay: track the variable block, as we need to initalize
9838 any captured variables declared in this block for the "catch"
9839 portion of the "Try" statement.
9841 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
9842 scope initialization for captured variables.
9844 Also, move the emit for the variables after the block location has
9847 2006-02-06 Marek Safar <marek.safar@seznam.cz>
9849 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
9851 2006-02-02 Miguel de Icaza <miguel@novell.com>
9853 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
9854 commit yesterday, the initialization for the roots is necessary.
9855 What is not necessary is the scope activation.
9857 2006-02-02 Raja R Harinath <rharinath@novell.com>
9859 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
9860 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
9862 (Argument.Resolve): Remove CS0206 checks.
9864 2006-02-01 Miguel de Icaza <miguel@novell.com>
9866 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
9867 scopes for all the roots, the scopes will now be emitted when the
9868 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
9870 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
9871 code. This reduces a lot of existing cruft.
9873 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
9874 that the ScopeInfo is generated as we enter the scope, not at the
9875 time of use, which is what we used to do before.
9877 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
9878 every time a Block is about to be emitted if we have a
9881 2006-02-01 Raja R Harinath <rharinath@novell.com>
9883 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
9885 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
9887 * typemanager.cs (cons_param_array_attribute): Make private.
9888 (Reset): Set it to null.
9889 (InitCoreHelpers): Don't initialize it.
9890 (ConsParamArrayAttribute): New. Initialize it as needed.
9891 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
9893 2006-01-31 Miguel de Icaza <miguel@novell.com>
9895 * expression.cs: There might be errors reported during the
9896 selection of applicable methods. If there are errors, do not
9897 continue execution as it will lead the compiler to crash.
9899 2006-01-30 Miguel de Icaza <miguel@novell.com>
9901 * expression.cs: Member access is not allowed on anonymous
9902 methods. Fixes #77402.
9904 2006-01-30 Raja R Harinath <rharinath@novell.com>
9907 * cs-parser.jay (VariableDeclaration): Don't set
9908 current_array_type to null.
9909 (field_declaration, event_declaration, declaration_statement):
9910 Set it to null here.
9912 2006-01-28 Raja R Harinath <harinath@gmail.com>
9914 * typemanager.cs (GenericParameterPosition): New.
9917 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
9919 * doc.cs : To process "include" elements, first we should create
9920 another list than XmlNodeList, because it could result in node
9921 removal, which could result in that the XmlNodeList gives up
9924 (Also made code identical to gmcs again.)
9926 2006-01-25 Miguel de Icaza <miguel@novell.com>
9928 * ecore.cs: Introduce an error report that we were not catching
9929 before, if not silent, we must report the error. Gonzalo ran into
9932 2006-01-23 Miguel de Icaza <miguel@novell.com>
9934 A fix for bug: #76957
9936 * iterators.cs (MoveNextMethod.CreateMethodHost): call
9937 ComputeMethodHost before creating the method, this is a new
9940 * anonymous.cs (AnonymousContainer): Now we track all the scopes
9941 that this method references (RegisterScope). The actual scope
9942 where the method is hosted is computed with the ComputeMethodHost
9943 before we create the method.
9945 Moved the Deepest routine here.
9947 (AnonymousContainer.ComputeMethodHost): New routine used to
9948 compute the proper ScopeInfo that will host the anonymous method.
9950 (ScopeInfo): Deal with multiple roots. The problem was that we
9951 did not have a unique root where all ScopeInfos could be hanged
9952 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
9955 Remove AdjustMethodScope which is now computed at the end. Remove
9956 LinkScope which did a partial link, instead link all ScopeInfos
9957 before code generation from the new "LinkScopes" routine.
9959 Simplify all the Add* routines as they no longer need to maintain
9960 the tree, they just need to record that they are using variables
9963 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
9964 routines to produce the forest of ScopeInfo trees.
9966 * class.cs (TypeContainer.AppendMethod): This is just like
9967 AddMethod, but ensures that an interface implementation method
9968 (IEnumerable.XXX) is not inserted at the beginning of the queue of
9969 methods, but at the end.
9971 We use this functionality to ensure that the generated MoveNext
9972 method in the iterator class is resolved/emitted before the
9973 enumerator methods created.
9975 This is required because the MoveNext method computes the right
9976 ScopeInfo for the method. And the other methods will eventually
9977 need to resolve and fetch information computed from the anonymous
9980 2006-01-21 Raja R Harinath <harinath@gmail.com>
9981 Carlos Alberto Cortez <calberto.cortez@gmail.com>
9984 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
9986 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
9987 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
9989 2006-01-18 Raja R Harinath <rharinath@novell.com>
9991 Fix #76656, cs0231-2.cs.
9992 * cs-parser.jay (formal_parameter_list): Make error case catch
9994 (parenthesized_expression_0): Add CS1026 check.
9995 (invocation_expression): Remove unused { $$ = lexer.Location }.
9997 2006-01-17 Raja R Harinath <rharinath@novell.com>
10000 * cs-parser.jay (statement_expression): Don't list out the
10001 individual statement-expressions. Convert syntax error into
10004 2006-01-16 Raja R Harinath <rharinath@novell.com>
10007 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
10008 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
10009 CheckIntermediateModification.
10010 (FieldExpr.DoResolve): Add new two-argument version that
10011 allows us to resolve the InstanceExpression as an lvalue.
10012 The one-argument variant is now just a wrapper.
10013 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
10014 Resolve the lhs as an lvalue if the it has a value type.
10015 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
10016 from Assign.DoResolve.
10017 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
10018 resolved as an lvalue.
10019 (PropertyExpr.DoResolve): Update.
10020 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
10021 has a value type. Move CS1612 check here from
10022 CheckIntermediateModification.
10023 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
10024 * expression.cs (EmptyExpression.OutAccess): New. Used as the
10025 'right_side' of a ResolveLValue on an 'out' argument.
10026 (EmptyExpression.LValueMemberAccess): New. Used as the
10027 'right_side' of a propagated ResolveLValue on a value type.
10028 (LocalVariableReference.DoResolveBase): Recognize
10029 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
10031 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
10032 EmptyExpression.Null.
10034 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
10036 * typemanager.cs : added IsGenericParameter(). In mcs it always
10038 * doc.cs : for generic parameters, use GenericParameterPosition,
10041 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
10043 * expression.cs: Fix Console.WriteLine ((this = x).foo);
10045 2006-01-12 Miguel de Icaza <miguel@novell.com>
10047 This fixes the problem where we used ldfld instead of ldflda to
10048 load the "THIS" pointer on captured parameters, when THIS is a
10049 value type. See bug #77205.
10051 * iterators.cs (CapturedThisReference.Emit): Pass false to
10052 EmitThis (we do not need the address).
10054 * codegen.cs (EmitThis): it needs to know whether we need the
10055 address of `this' or not. This is used by value types.
10057 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
10058 every other call passes false.
10060 2006-01-12 Raja R Harinath <rharinath@novell.com>
10063 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
10065 * expression.cs (Invocation.OverloadResolve): Update.
10066 (Invocation.DoResolve): Avoid double resolution of invocation.
10068 2006-01-11 Raja R Harinath <rharinath@novell.com>
10071 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
10072 unary negation of floating point types as 0-expr; negation cannot
10073 overflow in floating point types.
10076 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
10077 on operands of 'void' type.
10080 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
10081 and ExclusiveOr for boolean constants too.
10083 2006-01-09 Raja R Harinath <rharinath@novell.com>
10086 * expression.cs (Invocation.OverloadResolve): Replace reflected
10087 override methods with their base virtual methods, rather than
10088 skipping over them.
10089 * typemanager.cs (TypeManager.GetOverride): New.
10091 2006-01-05 Jb Evain <jbevain@gmail.com>
10093 * class.cs (Property.Define, Indexer.Define): do not tag the
10094 properties as SpecialName | RTSpecialName.
10096 2006-01-04 Miguel de Icaza <miguel@novell.com>
10098 * class.cs (MethodCore.IsDuplicateImplementation): This method was
10099 doing a low-level comparission of parameter types. It was lacking
10100 a check for __argslist.
10102 2005-12-30 Miguel de Icaza <miguel@novell.com>
10104 * expression.cs (ParameterReference.DoResolveBase): Allow
10105 reference parameters if they are local to this block.
10107 This allows the ref and out parameters of a delegate to be used in
10108 an anonymous method, for example:
10110 delegate void set (out int x);
10112 set s = delegate (out int x){
10116 This is used by functionality introduced late in the C# language.
10118 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
10119 method that take ref and out parameters.
10121 Fixes #77119 which was a late change in the spec.
10123 2005-12-23 Miguel de Icaza <miguel@novell.com>
10125 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
10126 parent if its the same scope. Fixes #77060.
10128 2005-12-21 Miguel de Icaza <miguel@novell.com>
10130 * driver.cs: Report the case of no source files and no -out:
10133 2005-12-20 Raja R Harinath <rharinath@novell.com>
10136 * expression.cs (ComposedCast.GetSignatureForError): Define.
10138 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10142 * namespace.cs (NamespaceEntry): Add extern_aliases as a
10143 ListDictionary, to contain the ExternAliasEntry entries (in
10144 addition to the NamespaceEntry.aliases hashtable). This field is
10145 shared between the original entry and its doppelganger (bodyless
10147 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
10148 extern_aliases field.
10149 (NamespaceEntry.Lookup): Move the IsImplicit check after the
10150 lookup in extern_aliases.
10152 2005-12-16 Raja R Harinath <rharinath@novell.com>
10155 * class.cs (TypeContainer.Mark_HasEquals): New.
10156 (TypeContainer.Mark_HasGetHashCode): New.
10157 (ClassPart): Override them.
10158 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
10161 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
10162 'parent' argument to the base constructor.
10164 Remove all mention of TypeContainer from decl.cs.
10165 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
10166 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
10167 (DeclSpace.DeclSpace): Likewise.
10168 (DeclSpace.DefineMembers): Remove unused argument.
10169 * cs-parser.jay (pop_current_class): Update to changes. Simplify
10170 debugging check -- we don't care if the debug code throws an
10171 InvalidCastException instead of an InternalErrorException.
10172 * class.cs (TypeContainer.DefineMembers): Update to changes.
10173 (TypeContainer.DoDefineMembers): Likewise.
10174 (TypeContainer.GetMethods): Likewise.
10175 (PropertyMember.Define): Likewise.
10176 (MemberBase.Parent): New property that forwards to
10177 MemberCore.Parent, but ensures that we get a TypeContainer.
10178 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
10179 (RootContext.PopulateTypes): Likewise. Remove special case code
10180 for !RootContext.StdLib: DefineMembers is idempotent.
10182 2005-12-14 Miguel de Icaza <miguel@novell.com>
10184 * convert.cs (ExplicitConversionCore): Check the return value from
10185 ExplicitConversionCore which can return null on failure. Fixes #76914
10187 2005-12-13 Marek Safar <marek.safar@seznam.cz>
10189 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
10191 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
10193 * doc.cs : The search for referenced namespace was insufficient to
10194 get global one as it used to do. Fixed bug #76965.
10196 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
10198 * doc.cs : check name in cref in the last phase that whether it is
10201 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10203 * cs-tokenizer.cs : reverted the latest change: it somehow broke
10206 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10208 * doc.cs : so it turned out that we cannot skip override check for
10209 interface members. Fixed bug #76954.
10211 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10213 * cs-tokenizer.cs : fixed bug #75984:
10214 - #warning and #error should not be handled when the source line
10216 - #line is not checked strictly when the source line is disabled.
10217 - #define and #undef is on the other hand checked strictly at any
10220 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
10222 * cs-tokenizer.cs : missing Location (actually, filename) in one of
10225 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10227 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
10229 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
10230 event initializers.
10231 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
10232 (FieldBase.Initializer): Initializer is now optional.
10233 (EventField.Define): Only event field can have initializer.
10235 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
10237 * const.cs (Const): Reuse initializer.
10239 * cs-parser.jay: Updated after FieldBase changes.
10240 Added current_array_type to simplify array initializers.
10242 * ecore.cs (NullCast.IsDefaultValue): Implemented.
10244 * expression.cs, iterators.cs: Updated.
10246 * namespace.cs (NamespaceEntry): Made UsingFound private.
10248 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10250 * parameterCollection.cs: Obsolete, removed.
10251 * parser.cs: Obsolete, removed.
10253 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10256 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
10258 * enum.cs (Enum.Define): Set obsolete context here.
10260 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
10263 - FindDocumentedMember() now expects 1) paramList as null
10264 when "we don't have to check the number of parameters" and
10265 2) Type.EmptyTypes when "there is no arguments".
10266 - Introduced FoundMember struct to hold the exact type which was
10267 used to find the documented member (the above change broke
10268 test-xml-044; it might be better just to use DeclaringType than
10269 what MS does, like this change does, but it depends on usage.)
10271 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
10273 * doc.cs : documented member might be from DeclaringType for nested
10274 types. Fixed bug #76782.
10276 2005-12-03 Ben Maurer <bmaurer@ximian.com>
10278 * anonymous.cs: Have the param code handle leaving copies on the
10279 stack etc. Allows anonymous params to take part in the assignment
10280 code (++, +=, etc). Fixes bug #76550
10282 * expression.cs: Handle the prepare_for_load/leave_copy by passing
10283 it down to the anon code.
10285 * iterators.cs: Use dummy var here
10287 * codegen.cs: Handle new vars
10289 2005-12-01 Marek Safar <marek.safar@seznam.cz>
10292 * class.cs (MethodData.Define): Set proper Obsolete context.
10294 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
10296 (FieldExpr.DoResolve): Ditto.
10298 2005-12-01 Marek Safar <marek.safar@seznam.cz>
10301 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
10302 parent is not obsolete.
10304 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
10306 * doc.cs : (FindDocumentedMember) find parameterless members first
10307 and get CS0419 in the early stage. Fixed first case of bug #76727.
10309 2005-11-30 Marek Safar <marek.safar@seznam.cz>
10312 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
10313 no error was reported.
10315 *expression.cs (Binary.DoResolve): left can be null.
10317 2005-11-22 Marek Safar <marek.safar@seznam.cz>
10320 * class.cs (MethodData.Emit): Parameters should be labeled first.
10322 2005-11-21 Marek Safar <marek.safar@seznam.cz>
10325 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
10327 2005-11-18 Marek Safar <marek.safar@seznam.cz>
10329 * attribute.cs (AreParametersCompliant): Moved to Parameter.
10331 * class.cs (MethodCore): Parameter clean up.
10332 (IMethodData): Added ParameterInfo.
10333 (MethodData): Parameter clean up.
10334 (Indexer.Define): Parameter clean up.
10346 * typemanager.cs: Parameter clean up.
10348 * delegate.cs (Define): Get rid of duplicated code.
10350 * expression.cs (ParameterReference): Removed useless parameters
10352 (Invocation): Ditto.
10354 * parameter.cs (ParamsParameter): New class, params specialization.
10355 (ArglistParameter): Attemp to separate arglist.
10356 (Parameter): Refactored to be reusable and faster.
10357 (Parameter.Modifier): Made understandable.
10358 (Parameters): Changed to be used as a class for `this' assembly
10359 parameters. Refactored to use new specialized classes.
10361 * support.cs (ParameterData): Added Types property.
10362 (InternalParameters): Deleted.
10364 2005-08-20 Martin Baulig <martin@ximian.com>
10366 Merging this patch from GMCS to fix #75867.
10368 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
10369 scope if we don't already have it.
10371 2005-11-17 Martin Baulig <martin@ximian.com>
10374 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
10375 inherit the scope from our parent. Fixes #76653.
10377 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
10379 * doc.cs : the previous patch does not actually fix the bug.
10380 PropertyInfo override check is now implemented and really fixed it.
10381 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
10383 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
10385 * doc.cs : apply "override filter" also to properties.
10388 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
10390 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
10391 no need to check overrides. For classes, omit those results from
10392 interfaces since they must exist in the class. Fixed bug #76726.
10394 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
10396 * typemanager.cs : (GetFullNameSignature) differentiate indexers
10397 with different parameters. Fixed the second problem in #76685.
10399 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
10401 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
10402 get expected 'protected' access in CheckValidFamilyAccess()).
10405 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
10407 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
10408 Fixed bug #76705. CS1569 was incorrectly commented out.
10410 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
10412 * doc.cs : use Invocation.IsOverride() to do real override check.
10413 * expression.cs : made Invocation.IsOverride() internal.
10415 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
10417 * doc.cs : use TypeManager.FindMembers() instead of (possible)
10418 TypeBuilder.FindMembers() and filter overriden base members out.
10421 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10423 * doc.cs : ref/out parameters are represented as '@' (instead of
10424 '&' in type FullName). Fixed bug #76630 (additionally crefs).
10426 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10428 * doc.cs : when there was no '.' in cref to methods in doc comment,
10429 then parameters were missing in the output. Fixed bug #76691.
10431 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10433 * driver.cs : don't output docs when there is an error.
10436 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10439 Now it should detect indexers. Fixed primary concern in bug #76685.
10440 Fixed CS0419 message to not show the identical member signature in
10443 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10445 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
10446 instead of Type.FindMembers() since it does not handle events.
10449 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
10451 * codegen.cs: Fixed typo (speficied -> specified).
10453 2005-11-11 Marek Safar <marek.safar@seznam.cz>
10456 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
10458 2005-11-11 Marek Safar <marek.safar@seznam.cz>
10460 * attribute.cs: Changed error message.
10462 * cs-tokenizer.cs: One more check.
10464 2005-11-10 Marek Safar <marek.safar@seznam.cz>
10466 * statement.cs (Block.Resolve): Ignore empty statement.
10468 2005-11-10 Marek Safar <marek.safar@seznam.cz>
10470 * report.cs: Made error/warning methods more strict to avoid
10473 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
10474 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
10475 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
10476 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
10478 2005-11-08 Marek Safar <marek.safar@seznam.cz>
10480 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
10481 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
10483 * class.cs (TypeContainer.IsComImport): New property.
10484 (Constructor.Define): Create proper ctor for ComImport types.
10486 * expression.cs (New.CheckComImport): Fixed.
10488 2005-11-07 Miguel de Icaza <miguel@novell.com>
10490 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
10491 that a parameter has been captured does not mean that we do not
10492 have to do the rest of the processing. This fixes the second part
10493 of #76592. If there was another anonymous method capturing
10494 values in the past, the Scope would never be set for the second
10495 method that captured the same parameter.
10497 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
10498 properly manipulate the stack. Second part of fix for #76592.
10500 * expression.cs (New): Add support for invoking "new" on
10501 interfaces that have been flagged with the ComImport attribute and
10502 the CoClass. Fixes #76637
10504 * statement.cs (Try.DoEmit): When a variable is captured, do not
10505 try to emit the vi.LocalBuilder variable as it has been captured.
10506 Create a temporary variable and store the results on the
10507 FieldBuilder. Fixes #76642
10509 2005-11-07 Marek Safar <marek.safar@seznam.cz>
10511 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
10513 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
10515 * expression.cs (Binary.DoResolve): Added && optimalization.
10517 * typemanager.cs (AddUserType): Removed useless argument.
10519 2005-11-04 Marek Safar <marek.safar@seznam.cz>
10521 * statement.cs (Block.variables): Uses ListDictionary.
10523 2005-11-03 Marek Safar <marek.safar@seznam.cz>
10526 * class.cs (PartialContainer.EmitType): Customized to emit
10527 security attributes.
10528 (ClassPart.ApplyAttributeBuilder): Transform security attribute
10529 for partial classes.
10531 2005-11-03 Marek Safar <marek.safar@seznam.cz>
10534 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
10535 access has to be fixed.
10537 * typemanager.cs (IsUnmanagedType): Wrong common field type.
10539 2005-11-01 Marek Safar <marek.safar@seznam.cz>
10542 * ecore.cs (NullCast.Reduce): Implemented.
10544 * expression.cs (ArrayCreation.CheckIndices): Correcly check
10547 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
10549 (Foreach.Resolve): Catch null properly.
10551 2005-10-29 Marek Safar <marek.safar@seznam.cz>
10553 * cs-tokenizer.cs: Warning text fix.
10555 * driver.cs: AllWarningNumbers exposed on public interface.
10557 * report.cs (): Reviewed warning numbers.
10558 (IsValidWarning): Use binary search.
10560 2005-10-29 Marek Safar <marek.safar@seznam.cz>
10562 * driver.cs: Implemeted resource visibility.
10563 (Resources): New class for code sharing between /res: and
10566 2005-10-28 Marek Safar <marek.safar@seznam.cz>
10569 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
10572 * convert (Convert.ImplicitReferenceConversion): NullCast holds
10575 * ecore.cs (NullCast): Child is contant only.
10577 * literal.cs (NullLiteral.Reduce): null can be converted to any
10580 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
10582 * driver.cs: Use Encoding.Default as default code page instead
10585 2005-10-27 Raja R Harinath <rharinath@novell.com>
10588 * expression.cs (Invocation.Error_InvalidArguments): Handle
10589 __arglist parameters.
10590 (Invocation.VerifyArgumentsCompat): Likewise.
10591 * support.cs (ReflectionParameters.GetSignatureForError): Print
10592 __arglist parameters.
10593 (InternalParamters.GetSignatureForError): Likewise.
10594 * parameter.cs (Parameters.GetSignatureForError): Likewise.
10596 2005-10-26 Marek Safar <marek.safar@seznam.cz>
10598 * attribute.cs (GetPropertyValue): Made public.
10600 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
10602 Add new property WrapNonExceptionThrows to handle 2.0 assembly
10604 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
10607 * driver.cs: Reflect method name change.
10609 * statement.cs (Try.Resolve): Warn when try has both general
10610 exception handlers.
10612 * typemanager.cs: runtime_compatibility_attr_type new predefined
10615 2005-10-26 Raja R Harinath <harinath@gmail.com>
10618 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
10619 treat it as an empty parameter list.
10621 2005-10-26 Raja R Harinath <rharinath@novell.com>
10624 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
10625 ResolveAsTypeStep silent.
10626 * statement.cs (Block.AddConstant): Mark block as used.
10627 (Block.ResolveMeta): Avoid piling on error messages
10628 if a constant initializer resolution fails.
10630 2005-10-25 Raja R Harinath <rharinath@novell.com>
10632 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
10634 (NamespaceEntry.VerifyAllUsing): New.
10635 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
10636 behaviour. Delegates actual resolution of alias to ...
10637 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
10638 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
10640 * driver.cs (Driver.MainDriver): Update.
10642 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
10643 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
10645 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
10647 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
10648 RootNamespace.DefineNamespacesForAll.
10650 2005-10-24 Raja R Harinath <harinath@gmail.com>
10652 * typemanager.cs (assemblies, external_aliases, modules)
10653 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
10654 (ComputeNamespaces, GetRootNamespace): Remove extra staging
10655 overhead. Move resposibility ...
10656 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
10657 * driver.cs, attribute.cs, codegen.cs: Update to changes.
10659 2005-10-23 Raja R Harinath <harinath@gmail.com>
10661 * namespace.cs (RootNamespace.all_namespaces): Renamed from
10662 cached_namespaces. Improve usage.
10663 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
10664 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
10665 Move from GlobalRootNamespace and simplify.
10666 (RootNamespace.Global): Make instance variable.
10667 (RootNamespace.RootNamespace): Add "alias name" parameter.
10668 (GlobalRootNamespace): Simplify drastically.
10669 (Namespace.Lookup): Don't use GetNamespace.
10670 * typemanager.cs (GetRootNamespace): Rename from
10671 ComputeNamespaceForAlias.
10672 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
10674 2005-10-23 Marek Safar <marek.safar@seznam.cz>
10676 * anonymous.cs (AnonymousContainer): Don't crash when container
10679 2005-10-23 Marek Safar <marek.safar@seznam.cz>
10681 * expression.cs (Binary.DoResolve): Warn when comparing same
10684 2005-10-23 Marek Safar <marek.safar@seznam.cz>
10687 * expression.cs (Binary.DoResolve): It looks like there are no
10688 convetsion rules in enum context.
10690 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10692 Add support for extern alias qualifiers.
10693 * typemanager.cs: Move some LookupTypeReflection code
10694 to namespace.cs, to have cleaner code. Added some methods
10695 to help us keep track of the extern aliased references.
10696 * driver.cs: Add suport for extern alias assemblies on command
10697 line and check for their warnings/errors. Also keep track of the
10698 extern aliased assemblies.
10699 * namespace.cs: Move the global functionality of Namespace
10700 to GlobalRootNamespace/RootNamespace. Now the global namespace
10701 is GlobalRootNamespace.Globa. Also the code moved from
10702 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
10703 Finally added LocalAliasEntry (AliasEntry before) and
10704 ExternAliasEntry, to handle alias statements.
10705 * cs-parser.jay: Add support in the grammar for extern alias
10707 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
10708 Update callings to Namespace (now in GlobalRootNamespace).
10710 2005-10-18 Raja R Harinath <rharinath@novell.com>
10713 * class.cs (TypeContainer.DefineType): Move updating of
10714 topological sort earlier in the code.
10715 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
10717 2005-10-18 Marek Safar <marek.safar@seznam.cz>
10720 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
10722 * constant.cs (Constant.TryReduce): Moved from Cast class.
10723 (Reduce): Made little bit more OO and fixed missing conversions.
10725 * ecore.cs (Reduce): Implemented.
10726 (Binary.EnumLiftUp): New method to upgrade values to enum values.
10728 * literal.cs (Reduce): Implemented.
10730 * class.cs: Reverted Miguel's wrong commit.
10732 2005-10-14 Miguel de Icaza <miguel@novell.com>
10734 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
10736 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
10738 * cs-parser.jay, expression.cs : CS0214 was missing error location
10739 for constants. Fixed bug #76404.
10741 2005-10-11 Marek Safar <marek.safar@seznam.cz>
10744 * convert.cs (ExplicitConversionCore): Fixed object->enum
10747 2005-10-10 Raja R Harinath <rharinath@novell.com>
10749 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
10750 InstanceExpression.
10751 (PropertyExpr.EmitCall): Likewise.
10752 * expression.cs (Invocation.EmitArguments): Handle case where
10754 (Invocation.EmitCall): Avoid allocating temporary variable if
10755 there are no arguments.
10757 2005-10-07 Raja R Harinath <rharinath@novell.com>
10760 * convert.cs (ImplicitConversionStandard): Move conversion of
10761 void* to arbitrary pointer types ...
10762 (ExplicitConversionStandard): .. here.
10763 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
10764 error to always print typenames.
10766 2005-10-07 Raja R Harinath <rharinath@novell.com>
10768 * convert.cs (GetConversionOperator): Rename from
10769 GetConversionOperators. Move operator selection code from ...
10770 (UserDefinedConversion): ... here.
10772 2005-10-06 Marek Safar <marek.safar@seznam.cz>
10774 * convert.cs (ExplicitConversionCore): Removed duplicate enum
10777 2005-10-05 Marek Safar <marek.safar@seznam.cz>
10779 * assign.cs (Assign.DoResolve): Error method changed.
10781 * cfold.cs (DoConstantNumericPromotions): Error method changed.
10783 * const.cs (ResolveValue): Reset in_transit immediately.
10785 * constant.cs: Error method changed.
10787 * convert.cs: Removed useless location parameter.
10788 (ExplicitNumericConversion): Don't do double enum check.
10789 (ExplicitConversionCore): Renamed from ExplicitConversion.
10790 (ExplicitUnsafe): Extracted from ExplicitConversion.
10791 (ExplicitConversion): Uses for error reporting.
10793 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
10795 (ResolveBoolean): Uses common error method.
10796 (CastToDecimal): Get rid of ec.
10797 (CastFromDecimal): Optimized.
10798 (ConvCast): Get rid of ec.
10800 * enum.cs (ResolveValue): Reset in_transit immediately.
10801 (Emit): Return after first error.
10803 * expression.cs: Convert changes.
10805 * literal.cs: Error method changed.
10807 * statement.cs: Error method changed.
10809 2005-10-03 Raja R Harinath <rharinath@novell.com>
10811 * support.cs (SeekableStreamReader.Position): Don't error out when
10812 the requested position is just beyond the end of the current
10815 2005-09-28 Raja R Harinath <rharinath@novell.com>
10817 * support.cs (SeekableStreamReader): Simplify drastically. Don't
10818 try to keep in sync with the byte count of the underlying Stream.
10819 However, this limits us to a window size of 2048 characters: i.e.,
10820 the maximum lookahead of our lexer/parser can be 2048 characters.
10822 2005-09-28 Marek Safar <marek.safar@seznam.cz>
10825 * driver.cs: Fix compilation files with full root path.
10827 2005-09-25 Miguel de Icaza <miguel@novell.com>
10829 * report.cs (SymbolRelatedToPreviousError): Format the output so
10830 it does not use an open parenthesis that is never closed.
10832 * driver.cs: Follow coding guidelines
10834 2005-09-27 Marek Safar <marek.safar@seznam.cz>
10837 * const.cs (Const.ResolveValue): Check for assigning non-null
10838 value to reference type.
10840 2005-09-27 Marek Safar <marek.safar@seznam.cz>
10842 * anonymous.cs: Implemented ExprClassName.
10844 * assign.cs (Assign.DoResolve): Don't chrash when type is not
10847 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
10850 * class.cs (StaticClass.DefineContainerMembers): Report protected
10853 * codegen.cs: if(ed) PRODUCTION.
10855 * convert.cs (Error_CannotImplicitConversion): Better error
10858 * cs-parser.jay: More error checks.
10860 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
10862 * driver.cs (CSCParseOption): Enabled wrong option check.
10864 * ecore.cs (Expression.ExprClassName): Turned to property.
10865 (MemberExpr.CheckIntermediateModification): For checking boxed
10866 value types modification.
10868 * statement.cs (Fixed.Resolve): Expression type must be
10869 convertible to fixed type.
10870 (CollectionForeach.GetEnumeratorFilter,TryType):
10871 Small refactoring for easier error checking.
10873 2005-09-26 Marek Safar <marek.safar@seznam.cz>
10875 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
10878 * class.cs (GeneratedBaseInitializer): New class for customization
10879 compiler generated initializers.
10880 (MemberBase.DoDefine): Check Obsolete attribute here.
10881 (FieldMember.DoDefine): Ditto.
10883 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
10886 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
10887 (MemberCore.GetObsoleteAttribute): Removed argument.
10888 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
10889 (MemberCore.CheckObsoleteType): New helper.
10893 * statement.cs: Updates after MemberCore changes.
10895 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
10896 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
10898 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
10899 obsolete attribute for compiler construct.
10900 (As.DoResolve): Cache result.
10902 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
10904 2005-09-26 Raja R Harinath <rharinath@novell.com>
10907 * expression.cs (This.VerifyFixed): In a value type T, the type of
10908 'this' is T&, iow, 'this' is either an out or ref parameter. In a
10909 value type R, 'this' is treated as a value parameter.
10911 2005-09-22 Miguel de Icaza <miguel@novell.com>
10913 * statement.cs (Lock): Use the TemporaryVariable class instead of
10914 manually using local variables as those do not work when variables
10917 * ecore.cs: Moved the TemporaryVariable class from being a nested
10918 class inside Foreach to be a public class that can be employed in
10921 2005-09-19 Marek Safar <marek.safar@seznam.cz>
10923 * cs-parser.jay: interface_accessors replaced by
10924 accessor_declarations.
10926 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
10929 * statement.cs (GotoCase.Resolve): Convert null constant to
10931 (SwitchLabel.ResolveAndReduce): Ditto.
10932 (SwitchLabel.NullStringCase): Custom null stamp.
10933 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
10935 typemanager.cs (CSharpSignature): Don't skip first argument
10938 2005-09-18 Miguel de Icaza <miguel@novell.com>
10940 * driver.cs: Set InEmacs based on the environment variable EMACS.
10942 * location.cs (InEmacs): in this mode, do not report column
10943 location as it confuses Emacs.
10945 2005-09-16 Marek Safar <marek.safar@seznam.cz>
10947 * cfold.cs, constant.cs, convert.cs, ecore.cs,
10948 expression.cs, iterators.cs, literal.cs: Store constants and
10951 * class.cs (MemberBase.ShortName): Pass location.
10953 * cs-parser.jay: Some location fixes.
10955 * ecore.cs (Expression.Location): Made virtual.
10957 2005-09-05 Miguel de Icaza <miguel@novell.com>
10959 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
10960 if the underlying types are the same, otherwise we need to produce
10961 code that will do the proper cast.
10963 This was exposed by Marek's constant rewrite which produced
10964 invalid code for the call site:
10966 enum X : long { a }
10967 void Method (X v) {}
10971 This fixes test-49.cs
10973 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
10975 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
10976 Type/Object should be allowed as well. Fixed bug #75968.
10978 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
10980 * expression.cs : (Binary.DoResolve): when one is enum constant and
10981 another is constant 0, then return enum one *as enum type*.
10984 2005-09-02 Raja R Harinath <rharinath@novell.com>
10986 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
10990 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
10991 flow-branching for LocalVariableReferences in case we were invoked
10992 from a MemberAccess.
10993 * expression.cs (LocalVariableReference.VerifyAssigned): New.
10995 (LocalVariableReference.DoResolveBase): ... this.
10996 (MemberAccess.Resolve): Do the check that was disabled during
10999 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11002 (PartialContainer.Create): check abstract/sealed/static strictly
11003 but abstract/sealed can exist only at one side. Fixed bug #75883.
11005 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
11008 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
11009 specified, don't default to UnmanagedType.I4.
11011 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11013 * expression.cs : conditional operator should check possibly
11014 incorrect assign expression. Fixed bug #75946.
11016 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11018 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
11019 Reverting the change. gmcs is much complex than mcs on this matter.
11021 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11023 * cs-tokenizer.cs : To read another token ahead of the actual
11024 consumption, use new SavedToken and cache token instead of moving
11025 back the stream with SeekableStreamReader (it seemed problematic).
11027 driver.cs : Thus use StreamReader directly.
11028 * support.cs : Thus removed SeekableStreamReader.
11030 2005-08-30 Raja R Harinath <rharinath@novell.com>
11033 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
11034 (ScopeInfo.EmitScopeType): Use it to construct field names from
11035 names of captured locals.
11038 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
11039 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
11040 Pass 'target_type' to BoxedCast. Don't default to 'object'.
11041 (ExplicitConversion): Remove enum cases already handled by
11042 implicit conversion. Move implicit conversion check to the beginning.
11043 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
11044 * expression.cs (ArrayCreation.EmitDynamicInitializers):
11045 Don't treat System.Enum as a struct.
11047 2005-08-30 Jb Evain <jbevain@gmail.com>
11049 * attribute.cs: handles as expression in parameters.
11051 2005-08-30 Raja R Harinath <rharinath@novell.com>
11054 * class.cs (TypeContainer.VerifyClsName): Don't use a
11055 PartialContainer when verifying CLS compliance.
11056 (AbstractPropertyEventMethod): Set Parent here, ...
11057 (PropertyMethod): ... not here.
11059 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
11061 * attribute.cs : escaped attribute name should not be allowed to be
11062 resolved (e.g. @class as classAttribute). Fixed bug #75930.
11064 2005-08-29 Raja R Harinath <rharinath@novell.com>
11067 * convert.cs (ImplicitStandardConversionExists): Allow zero also
11068 when converting a long constant to unsigned long.
11069 * expression.cs (Invocation.OverloadResolve): Add sanity check to
11070 detect where IsApplicable and VerifyArgumentsCompat disagree.
11072 2005-08-29 Raja R Harinath <rharinath@novell.com>
11073 and Carlos Alberto Cortez <carlos@unixmexico.org>
11076 * class.cs (TypeContainer.CanElideInitializer): New helper.
11077 (TypeContainer.EmitFieldInitializers): Use it to determine if we
11078 can safely emitting the initializer of a field.
11080 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11082 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
11083 allowed inside a switch (without loop). Fixed bug #75433.
11085 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
11087 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
11088 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
11090 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11092 * driver.cs : kinda reverting the default encoding changes (not exact
11093 revert since I noticed that "codepage:reset" might not work fine).
11095 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11097 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
11098 Location. Now getter and setter store location correctly.
11099 (errors/cs0111-12.cs now reports the expected location.)
11101 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11103 * driver.cs : Use default encoding on the environment.
11104 Removed (now that) extra parameter for SeekableStreamReader.
11105 * support.cs : (SeekableStreamReader) third .ctor() argument for
11106 StreamReader is not required (always true). preamble size could
11107 be acquired in simpler and safe way.
11109 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
11111 * cs-parser.jay: report CS0642 at warning level 3
11112 and report CS0642 for an if else statement also
11113 fixes bug #74745. Patch by John Luke (and a bit
11115 Removed extra CS0642 warning check for "while",
11117 * statement.cs: In Block.Resolve(), CS0642 check
11118 is reimplemented to check a sequence of an empty
11119 statement and a block.
11121 Both fix bug #66777.
11123 2005-08-24 Marek Safar <marek.safar@seznam.cz>
11125 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
11126 detection until I fix it.
11128 * cs-tokenizer.cs: Changed error message.
11130 * cs-parser.jay: Fixed 2 error locations.
11132 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
11133 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
11136 * enum.cs (GetSignatureForError): Fixed.
11138 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
11142 * typemanager.cs (RegisterProperty): Removed.
11144 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
11146 2005-08-24 Raja R Harinath <rharinath@novell.com>
11149 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
11150 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
11152 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11154 * expression.cs : tiny fix is required for not warning positive ulong.
11157 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11159 * expression.cs : add CS0652 check for constant and integral
11160 expression. Fixed bug #53974.
11162 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11164 * expression.cs : in DoNumericPromotions(), check if there is implicit
11165 conversion overload for string (to check CS0034). Fixed bug #52492.
11167 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11169 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
11171 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11173 * ecore.cs : report location when it is *not* Null.
11175 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11181 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
11182 correctly. Fixed bug #75721.
11184 2005-08-23 Raja R Harinath <rharinath@novell.com>
11186 * support.cs (SeekableStreamReader.Position): Avoid an expensive
11187 loop that performs 'min (pos, char_count)'.
11190 * expression.cs (Unary.ResolveOperator): Don't discard implicit
11191 converted value in Operator.OnesComplement.
11193 2005-08-22 Ben Maurer <bmaurer@ximian.com>
11195 * anonymous.cs: If the anon method is pulled into a helper class,
11196 it needs to be `internal' not `private'. Fixes runtime behavior on
11199 2005-08-20 Martin Baulig <martin@ximian.com>
11201 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11202 scope if we don't already have it.
11204 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
11205 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
11208 2005-08-17 Marek Safar <marek.safar@seznam.cz>
11211 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
11212 is a partial class.
11214 2005-08-16 Marek Safar <marek.safar@seznam.cz>
11216 The big constants rewrite
11217 Fix #75746, #75685 and more
11218 As a side effect saved 1MB for MWF ;-)
11220 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
11221 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
11222 enum based for corlib compilation.
11224 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
11227 * class.cs (FixedField.Define): Use ResolveAsConstant.
11229 * const.cs (IConstant): Interface constants and enums.
11230 (Const.ResolveValue): New method for constant resolvning.
11231 (ExternalConstant): Constants from imported assemblies.
11233 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
11234 conversion; like enums.
11235 (Constant.ToType): Converts this constant to different type.
11236 (Constant.Increment): Adds 1.
11238 * convert.cs (ImplicitConversionRequired): Simplified.
11240 * cs-parser.jay: Create EnumMember directly.
11242 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
11244 * doc.cs (GenerateEnumDocComment): Removed.
11246 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
11247 (ConvertIntLiteral): Removed.
11248 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
11250 * enum.cs (EnumMember): Implement IConstant.
11251 (Enum.IsValidEnumConstant): Removed.
11252 (Enum.GetNextDefaultValue): Removed.
11253 (Enum.FindMembers): Updated.
11254 (Enum.GenerateDocComment): Iterate enum members.
11256 * expression.cs (Cast.TryReduce): Handle enums correctly.
11257 (New.Constantify): Made public.
11258 (MemberAccess.DoResolve): Removed contant specific if(s).
11260 * literal.cs (NullLiteral): Implement new abstract methods.
11262 * statement.cs (GotoCase.Resolve): Use new constant methods.
11263 (SwitchLabel.ResolveAndReduce): Use new constant methods.
11265 * typemanager.cs (LookupEnum): Removed.
11266 (IsEnumType): Fixed to work with corlib.
11267 (RegisterConstant): Removed.
11268 (LookupConstant): Removed.
11269 (GetConstant): Changed to work with IConstant.
11271 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
11273 * location.cs : Fixed overflown (>255) column number.
11275 2005-08-03 Raja R Harinath <rharinath@novell.com>
11277 First cut of the qualified-alias-member feature.
11278 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
11280 * cs-parser.jay (DOUBLE_COLON): New token.
11281 (namespace_or_type_name): Add rule for recognizing
11282 qualified-alias-members.
11283 (primary_expression): Likewise.
11284 (element_access): Allow QualifiedAliasMember as a possible
11285 type-bearing expression.
11286 (local_variable_type, local_variable_pointer_type): Likewise.
11287 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
11288 aliases in the current and enclosing namespace declarations.
11289 (NamespaceEntry.UsingAlias): Add CS0440 warning.
11290 * decl.cs (MemberName.is_double_colon): New.
11291 (MemberName.MemberName): Add new constructor for alias-member.
11292 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
11293 * expression.cs (QualifiedAliasMember): New expression type.
11295 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11297 * location.cs : it borked when no argument was specified.
11299 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11301 * location.cs : tiny ToString() format fix.
11303 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11305 * statement.cs : oops, it was missing.
11307 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11309 A set of fixes for precise line/column location.
11312 "token" field now holds a file/line "delta", a line number offset
11313 from the segment, and a column number. See also:
11314 http://lists.ximian.com/pipermail/mono-devel-list/2004-
11315 December/009508.html
11316 Removed static IsNull. Use instance IsNull property instead.
11317 * cs-tokenizer.cs :
11318 For some tokens it stores Location. For Identifier it stores
11319 LocatedToken which is a pair of string name and location.
11320 Column numbers are adjusted only at getChar().
11322 Use Location.ToString() for reporting (it now contains column).
11324 Largely modified to use LocatedToken instead of
11325 string (IDENTIFIER), and to acquire Location from some tokens.
11326 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
11327 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
11329 Now MemberName holds Location. DeclSpace.ctor() receives Location
11330 as a parameter. Removed extra parameters to all derived classes.
11331 Replaced Location.IsNull() with instance property.
11332 * assign.cs, expression.cs :
11333 Added .ctor() overload that omits Location.
11335 Added "nameEscaped" flag that indicates the identifier was escaped
11336 in the source file. This fixes bug #57047.
11338 2005-08-02 Marek Safar <marek.safar@seznam.cz>
11340 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
11341 New method, looking for lo-case imported cls type.
11343 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
11346 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
11348 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
11350 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
11351 all_imported_types.
11352 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
11354 Optimized to save 3.5 MB for SWF compilation.
11356 2005-08-01 Marek Safar <marek.safar@seznam.cz>
11358 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
11359 (PartialContainer.Create): Moved logic AddToContainer.
11360 (PartialContainer.MarkForDuplicationCheck): Shares name.
11362 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
11365 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
11367 (Namespace.GetSignatureForError): New method.
11369 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
11370 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
11372 2005-08-01 Raja R Harinath <rharinath@novell.com>
11375 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
11376 member lookup rather than qualifier_type, since qualifier_type can
11379 2005-08-01 Marek Safar <marek.safar@seznam.cz>
11381 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
11384 2005-07-31 Miguel de Icaza <miguel@novell.com>
11386 * statement.cs: Copy the local exception into the exception
11387 captured local. Fixes 75674
11389 2005-07-31 Raja R Harinath <harinath@gmail.com>
11392 * expression.cs (Invocation.OverloadResolve): Don't report error
11393 CS1501 if error CS1502 has been reported.
11394 (New.DoResolve): Delegate CS1501 reporting to
11395 Invocation.OverloadResolve.
11398 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
11399 invariant-meaning-in-block property in an enclosing block if
11402 2005-07-29 Marek Safar <marek.safar@seznam.cz>
11404 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
11405 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
11406 (Switch.CheckSwitch): Just save 50kb for SWF.
11408 2005-07-27 Martin Baulig <martin@ximian.com>
11410 * anonymous.cs (CaptureContext.AddField): Added
11411 `AnonymousContainer am' argument; compute its toplevel scope if
11412 it's not already computed. Fixes #75649.
11414 2005-07-26 Raja R Harinath <rharinath@novell.com>
11417 * class.cs (Constructor.Emit): Reset block to null if the block
11420 2005-07-25 Marek Safar <marek.safar@seznam.cz>
11422 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
11424 2005-07-25 Marek Safar <marek.safar@seznam.cz>
11426 * class.cs (MethodData.Define): Check whether accessor implementing
11427 interface is public.
11429 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
11431 2005-07-22 Marek Safar <marek.safar@seznam.cz>
11434 * namespace.cs (LookupType): Moved same type check to...
11436 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
11437 with the same name.
11439 2005-07-21 Raja R Harinath <rharinath@novell.com>
11441 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
11442 already found a typebuilder.
11443 * class.cs (MethodCore.IsDuplicateImplementation): Compare
11444 MemberNames, not strings.
11446 * const.cs (Error_ExpressionMustBeConst):
11447 Rename from Error_EpressionMustBeConst.
11448 * const.cs, class.cs, statement.cd: Update.
11450 2005-07-21 Marek Safar <marek.safar@seznam.cz>
11454 * const.cs (Const.LookupConstantValue): Report missing contant expression
11456 (Error_EpressionMustBeConstant): Only one error method.
11458 * class.cs, statement.c: Updated.
11460 2005-07-20 Raja R Harinath <rharinath@novell.com>
11462 * statement.cs (Block.Flags): Add back HasVarargs.
11463 (Block.flags): Make protected.
11464 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
11466 * typemanager.cs (types, typecontainers, user_types): Remove.
11467 (UserTypes, TypeContainers): Likewise.
11468 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
11469 (CleanUp, Reset): Update.
11470 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
11471 (GetNestedType): Use Type.GetNestedType.
11472 (CoreLookupType): Take two arguments, the namespace and the
11473 basename of the type. Update to use the Namespace.Lookup
11475 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
11476 (RealMemberLookup): Use IsNestedChildOf instead of playing with
11477 string concatenation and substring matches.
11478 * class.cs, enum.cs, delegate.cs: Update to changes.
11480 2005-07-20 Marek Safar <marek.safar@seznam.cz>
11482 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
11483 Expression and made virtual.
11485 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
11486 (ImplicitStandardConversionExists): Fixed `byte' typo ?
11488 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
11490 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
11493 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
11496 2005-07-18 Marek Safar <marek.safar@seznam.cz>
11499 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
11500 AssemblyCultureAttribute is not used on executable.
11503 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
11505 2005-07-16 Raja R Harinath <rharinath@novell.com>
11508 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
11509 New. Reports CS0252/CS0253.
11510 Mostly taken from preliminary patch by Duncak Mak.
11511 (Binary.DoResolveOperator): Store results of operator lookup.
11512 Use them to detect if we need to warn about unintended reference
11515 2005-07-15 Raja R Harinath <rharinath@novell.com>
11518 * namespace.cs (Namespace.Lookup): Add back location parameter.
11519 (Namespace.LookupType): Add CS0436 report. Add location parameter.
11520 * delegate.cs, ecore.cs, expression.cs: Update to changes.
11522 * codegen.cs (EmitContext.DeclSpace): Make readonly.
11523 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
11524 (Namespace.LookupType): ... this.
11525 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
11527 * typemanager.cs (LookupTypeReflection): Remove buggy code that
11528 purported to handle pointers.
11529 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
11532 2005-07-15 Marek Safar <marek.safar@seznam.cz>
11534 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
11537 2005-07-15 Raja R Harinath <rharinath@novell.com>
11539 * namespace.cs (Namespace.Lookup): Drop location parameter.
11540 (NamespaceEntry.LookupAlias): Remove. Merge into ...
11541 (NamespaceEntry.Lookup): ... this.
11542 (NamespaceEntry.Error_AmbiguousTypeReference):
11543 Move here from DeclSpace.
11544 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
11546 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
11547 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
11548 Move to NamespaceEntry.
11549 * delegate.cs, expression.cs: Update to changes.
11551 2005-07-14 Marek Safar <marek.safar@seznam.cz>
11553 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
11554 CheckAttributeType and refactored.
11555 (Attribute.ResolvePossibleAttributeType): Changed to reuse
11556 ResolveAsTypeTerminal error handling.
11557 (ResolveAsTypeTerminal): Introduced because of global attributes extra
11559 (GetSignatureForError): Print errors in same way.
11562 * codegen.cs: Reflect attribute GetSignatureForError change.
11565 * expression.cs: Add silent parameter to ResolveAsTypeStep.
11567 * namespace.cs (UsingEntry): Refactored to make fields private.
11570 statement.cs: Error_UnexpectedKind has extra parameter.
11572 2005-07-14 Raja R Harinath <rharinath@novell.com>
11574 * ecore.cs (IAlias): Remove.
11575 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
11576 that implement the interface.
11577 * namespace.cs (Namespace): Likewise.
11578 (Namespace.declspaces): Renamed from 'defined_names'.
11579 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
11580 DeclSpace instead of an IAlias.
11581 * tree.cs (Tree.AddDecl): Update.
11583 2005-07-12 Raja R Harinath <rharinath@novell.com>
11585 * statement.cs (Block.Flags); Remove HasVarargs.
11586 (Block.HasVarargs): Move to ToplevelBlock.
11587 (Block.ThisVariable, Block.AddThisVariable): Likewise.
11588 (Block.Variables): Make protected. Initialize variable hashtable
11590 (Block.AddVariable): Update.
11591 (Block.Resolve): Update to changes.
11592 (ToplevelBlock.HasVarargs): New boolean.
11593 (ToplevelBlock.ThisVariable): Move here from Block.
11594 (ToplevelBlock.AddThisVariable): Likewise.
11595 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
11596 * expression.cs (This.ResolveBase): Update to changes.
11597 (ArglistAccess.DoResolve): Likewise.
11599 2005-07-11 Marek Safar <marek.safar@seznam.cz>
11602 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
11604 * class.cs (TypeContainer.VerifyMembers): Distinguish between
11605 not used and not used & assigned.
11606 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
11608 2005-07-11 Marek Safar <marek.safar@seznam.cz>
11611 * expression.cs (Is.DoResolve): null is never provided type.
11613 2005-07-08 Marek Safar <marek.safar@seznam.cz>
11616 * cs-parser.jay: Less strict event error rule to catch more errors.
11618 2005-07-08 Martin Baulig <martin@ximian.com>
11620 Fix test-iter-10.cs - distinguish whether we `yield' in a property
11621 gettter (allowed) or setter (not allowed).
11623 * class.cs (Accessor): Implement IIteratorContainer.
11624 (Accessor.Yields): New public field.
11625 (PropertyBase.PropertyMethod.Define): Handle iterators on a
11626 per-accessor basis.
11629 (get_accessor_declaration, set_accessor_declaration): Set the
11630 `yields' flag on the accessor, not the property.
11631 (property_declaration): Do the iterators check on a per-accessor
11632 basis and not for the whole property.
11634 2005-07-08 Martin Baulig <martin@ximian.com>
11636 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
11637 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
11639 2005-07-07 Marek Safar <marek.safar@seznam.cz>
11642 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
11643 (ExtractSecurityPermissionSet): Cope with self referencing security
11644 attributes properly.
11646 * driver.cs (SetOutputFile): Made public property OutputFile.
11648 2005-07-07 Raja R Harinath <rharinath@novell.com>
11651 * class.cs (TypeContainer.first_nonstatic_field): Rename from
11652 has_nonstatic_fields. Make into a FieldBase pointer.
11653 (TypeContainer.AddField): Add CS0282 check.
11654 (TypeContainer.EmitType): Update.
11656 2005-07-06 Miguel de Icaza <miguel@novell.com>
11658 * cs-tokenizer.cs (consume_identifier): Do not create strings to
11659 compare if they start with __.
11661 2005-07-06 Raja R Harinath <rharinath@novell.com>
11663 * statement.cs (Switch.SwitchGoverningType): Only look at
11664 UserCasts that don't need implicit standard conversions to one of
11665 the allowed switch types (Fixes test-322.cs).
11666 (LocalInfo.Resolve): Re-enable sanity-test.
11668 2005-07-06 Marek Safar <marek.safar@seznam.cz>
11670 * cs-tokenizer.cs (consume_identifier): Detect double undescores
11672 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
11674 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
11676 2005-07-06 Raja R Harinath <rharinath@novell.com>
11679 * ecore.cs (SimpleName.GetSignatureForError): Add.
11680 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
11681 (MemberAccess.GetSignatureForError): Add.
11683 2005-07-05 Marek Safar <marek.safar@seznam.cz>
11685 The big error and warning messages review.
11715 * typemanager.cs: Updated.
11717 * class.cs: (MethodCore.SetYields): Moved here to share.
11718 (PropertyMethod.Define): Moved iterator setup here.
11720 * iterators.cs: Add orig_method to have full access to parent
11723 2005-07-05 Raja R Harinath <rharinath@novell.com>
11725 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
11726 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
11727 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
11728 variable of struct type.
11729 * expression.cs (Unary.ResolveOperator): Update to change.
11730 (Indirection.VerifyFixed): Likewise.
11731 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
11732 (ParameterReference.VerifyFixed): Value parameters are fixed.
11733 (This.VerifyFixed): Treat 'this' as a value parameter.
11734 * statement.cs (LocalInfo.IsFixed): Remove.
11736 2005-07-01 Martin Baulig <martin@ximian.com>
11738 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
11739 `ec.EmitThis ()' to get the correct scope.
11741 2005-07-01 Martin Baulig <martin@ximian.com>
11743 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
11744 instance is a ParameterReference; fixes #75299.
11746 2005-07-01 Martin Baulig <martin@ximian.com>
11748 Reverted Marek's latest patch (r46725):
11749 - it contains structural changes which are neither mentioned in
11750 the ChangeLog nor explained anywhere; for example the additional
11751 argument of EmitContext's and Iterator's .ctor's and the
11752 TypeContainer.DefineMembers() change.
11753 - structural changes like this should go in in seperate patches
11754 and not be hidden in a huge patch which just seems to affect
11755 warnings and errors.
11756 a big and hard to understand patch.
11757 - it breaks iterators and causes regressions, for instance in
11760 2005-06-30 Raja R Harinath <rharinath@novell.com>
11763 * expression.cs (Indexers.map): Remove.
11764 (Indexers.Append): Filter out inaccessible setters and getters.
11765 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
11768 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
11769 Refactored from ...
11770 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
11771 (FieldExpr.Emit, PropertyExpr.Emit): Update.
11772 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
11773 * expression.cs (Invocation.EmitCall): Add CS0120 check.
11775 2005-06-30 Marek Safar <marek.safar@seznam.cz>
11778 * class.cs (FieldBase.GetInitializerExpression): One more field
11781 2005-06-28 Miguel de Icaza <miguel@novell.com>
11783 * pending.cs: Do not define a proxy if the base method is virtual,
11784 it will be picked up by the runtime (bug 75270).
11786 2005-06-08 Martin Baulig <martin@ximian.com>
11788 The big Iterators rewrite :-)
11790 * iterators.cs: Rewrite this to use the anonymous methods framework.
11792 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
11793 before the TypeContainers; see 2test-21.cs.
11796 (TypeContainer.DefineType): Don't create a new EmitContext if we
11797 already have one (this only happens if we're an Iterator).
11798 (TypeContainer.Define): Also call Define() on all our iterators.
11799 (Method.CreateEmitContext): Added support for iterators.
11802 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
11803 (AnonymousContainer.CreateMethodHost): Moved here from
11804 AnonymousMethod and made abstract.
11805 (AnonymousContainer.CreateScopeType): New abstract method.
11806 (AnonymousContainer.IsIterator): New public property.
11807 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
11808 get the ScopeTypeBuilder rather than manually defining it here.
11809 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
11812 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
11813 before RootContext.DefineTypes().
11815 * codegen.cs (EmitContext.RemapToProxy): Removed.
11816 (EmitContext.CurrentAnonymousMethod): Changed type from
11817 AnonymousMethod -> AnonymousContainer.
11818 (EmitContext.ResolveTopBlock): Protect from being called twice.
11819 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
11820 (EmitContext.EmitThis): Removed the iterators hacks; use the
11821 anonymous methods framework for that.
11824 (ToplevelBlock.Container): Make this a property, not a field.
11825 (ToplevelBlock.ReParent): New public method; move the
11826 ToplevelBlock into a new container.
11827 (Foreach.TemporaryVariable): Simplify.
11829 2005-06-05 Martin Baulig <martin@ximian.com>
11831 * statement.cs (LocalInfo.CompilerGenerated): New flag.
11832 (Block.AddTemporaryVariable): New public method; creates a new
11833 `LocalInfo' for a temporary variable.
11834 (Block.EmitMeta): Create the LocalBuilders for all the temporary
11836 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
11837 non-iterator variables.
11839 2005-06-05 Martin Baulig <martin@ximian.com>
11841 * statement.cs (Foreach.TemporaryVariable): Create the
11842 LocalBuilder in the Emit phase and not in Resolve since in some
11843 situations, we don't have an ILGenerator during Resolve; see
11844 2test-19.cs for an example.
11846 2005-06-04 Martin Baulig <martin@ximian.com>
11848 **** Merged r45395 from GCS ****
11850 The big Foreach rewrite - Part II.
11852 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
11853 with `PropertyInfo ienumerator_getcurrent'.
11855 * codegen.cs (VariableStorage): Removed.
11858 (Foreach): Derive from Statement, not ExceptionStatement.
11859 (Foreach.CollectionForeach): New nested class. Moved all the code
11860 dealing with collection foreach here.
11861 (Foreach.ForeachHelperMethods): Removed.
11862 (Foreach.TemporaryVariable): Implement IMemoryLocation.
11864 2005-05-23 Martin Baulig <martin@ximian.com>
11866 * statement.cs (Try.DoResolve): Don't create a `finally' if we
11867 don't need to. Fix #75014.
11869 2005-05-20 Martin Baulig <martin@ximian.com>
11871 Merged r44808 from GMCS.
11873 * class.cs (TypeContainer.CircularDepException): Removed.
11874 (TypeContainer.DefineType): Removed the `InTransit' stuff.
11875 (TypeContainer.CheckRecursiveDefinition): Check for circular class
11876 (CS0146) and interface (CS0529) dependencies here.
11878 2005-06-21 Raja R Harinath <rharinath@novell.com>
11880 * expression.cs (Invocation.EmitCall): Fix initialization
11881 'this_call' to reflect current behaviour. Fix indentation.
11883 * convert.cs (FindMostEncompassedType): Add two trivial special
11884 cases (number_of_types == 0 || number_of_types == 1).
11885 (FindMostEncompasingType): Likewise.
11887 2005-06-17 Raja R Harinath <rharinath@novell.com>
11889 Some cleanups preparing for the fix of #75283.
11890 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
11892 (EventExpr.InstanceResolve): Likewise.
11893 (EventExpr.DoResolve): Remove redundant checks.
11895 2005-06-10 Duncan Mak <duncan@novell.com>
11897 * cs-tokenizer.cs (process_directives): New flag for controlling
11898 the processing of preprocessor directives.
11899 (x_token): After seeing a '#', return Token.NONE instead of going
11900 to handle_preprocessing_directive() when not processing
11901 directives. This avoids unnecessary processing during the token peek in
11906 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
11907 the existing error reporting methods instead of Report.Error.
11909 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
11910 after Raja's rewrite.
11912 2005-06-08 Miguel de Icaza <miguel@novell.com>
11914 * class.cs: Small fix.
11916 2005-06-08 Raja R Harinath <rharinath@novell.com>
11919 * class.cs (GetPartialBases): Fix return value check of
11920 part.GetClassBases.
11922 2005-06-07 Raja R Harinath <rharinath@novell.com>
11924 Ensure that partial classes are registered in their enclosing
11925 namespace. Initial part of fix of #75160.
11926 * tree.cs (Tree.RecordDecl): Add new namespace argument.
11927 Register declspace with namespace here, not in
11928 DeclSpace.RecordDecl.
11929 * cs-parser.jay: Pass namespace to RecordDecl.
11930 * class.cs (PartialContainer.Create): Likewise.
11931 (ClassPart.DefineType): New sanity-check. Throws an exception if
11933 * decl.cs (Declspace.RecordDecl): Remove.
11934 * namespace.cs (NamespaceEntry.DefineName): Remove.
11936 2005-06-06 Marek Safar <marek.safar@seznam.cz>
11938 * rootcontext.cs: Reset TargetExt as well.
11940 2005-06-03 Raja R Harinath <rharinath@novell.com>
11942 * ecore.cs (Expression.Resolve): Emit CS0654 error when
11943 -langversion:ISO-1.
11945 2005-06-02 Raja R Harinath <rharinath@novell.com>
11947 Fix #75080, cs0119.cs.
11948 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
11950 (Expression.Resolve): ... this. Use it. Remove bogus code
11951 allowing ExprClass.Type and ExprClass.Namespace for
11952 ResolveFlags.VariableOrValue.
11953 (Expression.Resolve) [1-argument variant]: Change default resolve
11954 flags based on language version.
11955 (Expression.Error_UnexpectedKind): Use a simple string array
11956 rather than an ArrayList.
11957 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
11958 not ExprClass.Type.
11959 (TypeOfVoid.DoResolve): Likewise.
11960 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
11961 flags argument -- it always has the same value.
11963 2005-05-31 Raja R Harinath <rharinath@novell.com>
11966 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
11967 Use it in the error message.
11968 * assign.cs, expression.cs, statement.cs: Update.
11970 2005-05-30 Raja R Harinath <rharinath@novell.com>
11973 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
11974 the "almostMatchedMember" case too.
11975 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
11976 that failed the accessibility checks to 'almost_match'.
11978 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
11980 * attribute.cs: Use internal MethodBuilder methods to set
11981 ExactSpelling and SetLastError on PInvoke methods, instead
11982 of passing them via charset. Fixes #75060.
11984 2005-05-27 Raja R Harinath <rharinath@novell.com>
11986 * parameter.cs (Parameter): Remove TODO comment.
11987 (Parameter.DefineParameter): Remove Location parameter.
11988 (Parameters.LabelParameters): Likewise.
11989 * class.cs (Constructor.Emit): Update to change.
11990 (MethodData.Emit): Likewise.
11991 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
11992 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
11994 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
11997 Removed Parameters.Location and added Parameter.Location instead.
11998 Removed Location parameter from Emit() and GetSignature().
12005 Modified all related calls.
12007 2005-05-26 Raja R Harinath <rharinath@novell.com>
12009 Improve user-defined conversion handling.
12010 * convert.cs (GetConversionOperators): Rewrite. Return only the
12011 applicable operators.
12012 (AddConversionOperators): New. Helper for GetConversionOperators.
12013 (FindMostEncompassedType, FindMostEncompassingType): Verify that
12014 there is only one most encompassed/encompassing type.
12015 (FindMostSpecificSource, FindMostSpecificTarget): Remove
12016 "applicable operator" handling.
12017 (UserConversion): Move cache here from GetConversionOperators.
12018 Directly cache the chosen operator, rather than the whole
12020 (ExplicitNumericConversion): Fix buggy implementation of Decimal
12021 case. Allow conversion of decimal to sbyte and byte too.
12022 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
12023 New static methods. Used to avoid allocating EmptyExpressions in
12026 2005-05-24 Duncan Mak <duncan@novell.com>
12028 * ecore.cs (CastFromDecimal): New class for casting a decimal to
12029 another class, used in Convert.ExplicitNumericConversion.
12030 (CastToDecimal): New class, similar to above, but casts to
12031 System.Decimal, used in Convert.ImplicitNumericConversion and also
12032 in explicit convesion from double/float to decimal.
12034 * convert.cs (ImplicitNumericConversion): Handle implicit
12035 conversions to System.Decimal.
12036 (ExplicitNumericConversion): handle explicit conversions to
12041 2005-05-20 Miguel de Icaza <miguel@novell.com>
12043 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
12044 know the type at this stage, just break through. Fixes #75008
12046 2005-05-19 Martin Baulig <martin@ximian.com>
12049 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
12050 to disable error reporting.
12052 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
12053 here since we don't want to report an error; see the new test-336.cs.
12055 2005-05-19 Raja R Harinath <rharinath@novell.com>
12057 * statement.cs (ToplevelBlock.GetParameterReference)
12058 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
12059 Move here from class Block.
12060 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
12061 * expression.cs (ParameterReference.DoResolveBase): Likewise.
12063 2005-05-18 Martin Baulig <martin@ximian.com>
12068 (FlowBranching.Reachability): Add non-static public And() and Or()
12070 (FlowBranchingSwitch): New class; do the `break_origins' thing
12071 like in FlowBranchingLoop.
12072 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
12073 reachability, not just locals and parameters.
12074 (FlowBranching.MergeChild): Remove some of the hacks for loop and
12075 switch; MergeBreakOrigins() now takes care of that.
12077 2005-05-18 Martin Baulig <martin@ximian.com>
12079 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12080 a loop and may leave it, reset the barrier; fixes #74974.
12082 2005-05-17 Marek Safar <marek.safar@seznam.cz>
12084 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
12087 * cs-parser.jay: Catch more lexical errors.
12089 * report.cs: Add one more Error method.
12092 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
12094 2005-05-17 Martin Baulig <martin@ximian.com>
12096 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
12099 2005-05-16 Raja R Harinath <rharinath@novell.com>
12101 Fix test-382.cs. Emit values of decimal constants.
12102 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
12104 (TypeContainer.AddField): ... this.
12105 (TypeContainer.EmitFieldInitializers): Allow the list of fields
12106 with initializers to include 'Const's.
12107 (ClassPart.RegisterFieldForInitialization): Forward to
12109 * const.cs (Const.Const): Pass initializer to base class.
12110 (Const.Define): In case of decimal constants, register them for
12111 initialization in a static constructor.
12113 2005-05-14 Martin Baulig <martin@ximian.com>
12115 * statement.cs (Block.Resolve): Correctly handle unreachable code;
12116 do not call ResolveUnreachable() on unreachable statements in
12117 here, see the comment in the source code.
12119 2005-05-13 Raja R Harinath <rharinath@novell.com>
12122 * expression.cs (BinaryResolveOperator): If one of the operands of
12123 an equality comparison is 'null' and the other is a pointer type,
12124 convert the null to a NullPointer.
12125 * convert.cs (ImplicitReferenceConversion): If the expression is a
12126 NullLiteral and the target type is a pointer type, return a
12127 NullPointer instead.
12128 (ImplicitConversionStandard): Likewise.
12130 2005-05-13 Marek Safar <marek.safar@seznam.cz>
12132 * cs-parser.jay: Set readonly context based on special constructs.
12134 * expression.cs (LocalVariableReference.DoResolveBase): Improved
12135 readonly variable error handling.
12137 * rootcontext.cs (EmitCode): Don't verify members when error
12140 * statement.cs (LocalInfo): Add reaodnly context information.
12141 (SetReadOnlyContext, GetReadOnlyContext): New methods.
12143 2005-05-13 Raja R Harinath <rharinath@novell.com>
12145 * statement.cs (Block.Resolve): Revert change below. Modify fix
12146 for #74041 to initialize 'resolved' to false only for explicit
12147 blocks. Fixes #74873.
12149 2005-05-12 Raja R Harinath <harinath@gmail.com>
12152 * typemanager.cs (unmanaged_enclosing_types): New.
12153 (IsUnmanagedType): Avoid infloops by using
12154 'unmanaged_enclosing_types' to talk with recursive invocations.
12156 2005-05-13 Martin Baulig <martin@ximian.com>
12158 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
12159 instance variable, not a local. Fix #74873.
12160 (Block.ResolveUnreachable): Set it to true here.
12162 2005-05-11 Duncan Mak <duncan@novell.com>
12164 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
12165 continuing to process for 'arg'.
12166 (handle_preprocessing_directive): Check the argument of the #endif
12167 directive and report error CS1025 if there are any trailing
12170 According to the C# spec, having even whitespace after the #endif
12171 directive is illegal; however, because we call arg.TrimEnd ()
12172 beforehand, we have the same behavior as csc, allowing whitespace
12173 after the directive.
12177 2005-05-11 Marek Safar <marek.safar@seznam.cz>
12181 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
12182 (Constructor.GetObsoleteAttribute): Implemented correctly.
12184 2005-05-10 Martin Baulig <martin@ximian.com>
12186 * support.cs (ReflectionParameters.ParameterModifier): Use
12187 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
12188 and `ParameterAttributes.In'. Fixes #74884.
12190 2005-05-10 Marek Safar <marek.safar@seznam.cz>
12192 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
12194 * expression.cs (Argument.GetParameterModifier): Turned to property.
12195 (Invocation.Error_InvalidArguments): Add more descriptive errors.
12197 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
12200 2005-05-09 Raja R Harinath <rharinath@novell.com>
12203 * decl.cs (MemberCache.AddMethods): Register override methods,
12204 rather than non-override methods.
12205 * typemanager.cs (RegisterOverride): New.
12206 (IsOverride): Update.
12208 2005-05-09 Marek Safar <marek.safar@seznam.cz>
12212 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
12213 recursive declaration.
12215 * statement.cs (Block.ResolveMeta): Report any error in resolving.
12217 2005-05-06 Marek Safar <marek.safar@seznam.cz>
12219 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
12221 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
12223 2005-05-05 Raja R Harinath <rharinath@novell.com>
12226 * decl.cs (DeclSpace.FamilyAccessible):
12227 Use TypeManager.IsNestedFamilyAccessible.
12229 Fix reopened #64812.
12230 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
12233 2005-05-04 Raja R Harinath <rharinath@novell.com>
12234 Abin Thomas <projectmonokochi@rediffmail.com>
12235 Anoob V E <projectmonokochi@rediffmail.com>
12236 Harilal P R <projectmonokochi@rediffmail.com>
12239 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
12240 allow access to all static members.
12242 2005-05-04 Martin Baulig <martin@ximian.com>
12244 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
12246 2005-05-04 Martin Baulig <martin@ximian.com>
12250 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
12251 section at the end; make things work if `default' is not the last
12254 2005-05-04 Martin Baulig <martin@ximian.com>
12258 * statement.cs (Switch): Replaced the `got_default' field with a
12259 `default_section' one.
12260 (Switch.CheckSwitch): Set `default_section' here.
12261 (Switch.Resolve): If we're a constant switch and the constant is
12262 not found, use the default section.
12264 2005-05-03 Martin Baulig <martin@ximian.com>
12266 * expression.cs (ArrayAccess.EmitGetLength): New public method.
12268 * statement.cs (Foreach.ArrayForeach): New nested class.
12269 (Foreach.TemporaryVariable): New nested class.
12270 (Foreach.EmitArrayForeach): Removed; this is now in the new
12271 ArrayForeach class.
12273 2005-05-03 Raja R Harinath <rharinath@novell.com>
12275 * pending.cs (BaseImplements): Move the #74773 fix here. This is
12277 (VerifyPendingMethods): Revert change below.
12279 * typemanager.cs (IsOverride, RegisterNonOverride): New.
12280 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
12281 that used to trigger warning -28. Remove warning -28.
12282 * expression.cs (Invocation.OverloadResolve): Use
12283 TypeManager.IsOverride to distinguish override methods.
12286 * pending.cs (VerifyPendingMethods): If a base type implements the
12287 requested interface, don't bother checking individual methods of
12288 the base type. As a side-effect, this prevents the creation of
12289 unnecessary proxies.
12291 2005-05-02 Martin Baulig <martin@ximian.com>
12295 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12296 Also `And' the locals if the old vector is null.
12297 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
12298 null; in this case we basically reset all the variables.
12300 2005-05-02 Martin Baulig <martin@ximian.com>
12304 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
12305 Added `FlowBranching branching' argument; always `and' the
12306 variables instead of `or'ing them unless we're an infinite loop.
12308 * statement.cs (While.Resolve): Create a new sibling unless we're
12311 2005-05-02 Martin Baulig <martin@ximian.com>
12315 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
12316 arguments; use it instead of creating a new TopLevelBlock.
12317 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
12318 our ConstructorInitializer.
12321 (TopLevelBlock.TopLevelBranching): New public property.
12322 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
12323 and create our `TopLevelBranching'.
12325 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
12326 anonymous method host, use `block.TopLevelBranching' rather than
12327 creating a new branching.
12329 2005-04-20 Miguel de Icaza <miguel@novell.com>
12331 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
12332 a ScopeInfo, if any of the current children is a child of the new
12333 entry, move those children there.
12335 2005-04-30 Martin Baulig <martin@ximian.com>
12337 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
12338 at the beginning of a SwitchSection. Fix #73335.
12340 2005-04-27 Marek Safar <marek.safar@seznam.cz>
12343 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
12345 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
12346 (FieldExpr.DoResolve): Obsolete members are ignored for field
12349 2005-04-26 Marek Safar <marek.safar@seznam.cz>
12351 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
12352 of arrays detection.
12354 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
12356 (Field.VerifyClsCompliance): Volatile fields are not compliant.
12358 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
12361 2005-04-25 Ben Maurer <bmaurer@ximian.com>
12363 * cs-parser.jay: Use the prefered version of -unsafe in error
12366 2005-04-22 Marek Safar <marek.safar@seznam.cz>
12368 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
12371 2005-04-20 John Luke <john.luke@gmail.com>
12373 * driver.cs: fix typo in error message, --outout to --output
12375 2005-04-20 Marek Safar <marek.safar@seznam.cz>
12377 * codegen.cs (InRefOutArgumentResolving): New field.
12379 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
12380 fields outside contructor.
12382 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
12384 2005-04-19 Miguel de Icaza <miguel@novell.com>
12386 * anonymous.cs (CaptureContext.EmitParameterInstance): The
12387 parameter code was not completed ever, so it was not as up-to-date
12388 as local variables. Must finish it.
12390 The bug fix was to compare the Toplevel of the block, not the
12391 current block. Thanks for Ben for pointing this out.
12393 2005-04-19 Raja R Harinath <rharinath@novell.com>
12395 * decl.cs (AddMethods): Use the declaring type of the problem
12396 method to determine if we want to squash a warning.
12398 2005-04-19 Marek Safar <marek.safar@seznam.cz>
12400 * attribute.cs: Removed debug output.
12402 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
12404 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
12407 2005-04-18 Raja R Harinath <rharinath@novell.com>
12410 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
12411 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
12412 all null comparisons against reference types.
12414 2005-04-18 Marek Safar <marek.safar@seznam.cz>
12417 * class.cs (TypeContainer.CircularDepException) New nested
12419 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
12420 (TypeContainer.DefineType): Removed error, reset InTransit before
12422 (Class.DefineType): Throw exception when is in Transit.
12423 Catch exception and report error.
12424 (Struct.DefineType): Throw exception when is in Transit.
12425 Catch exception and report error.
12426 (Interface.DefineType): Throw exception when is in Transit.
12427 Catch exception and report error.
12429 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
12430 handle nested exception handlers.
12432 * flowanalysis.cs (InTryWithCatch): New method, search for try with
12435 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
12436 InFinally and InCatch storage.
12438 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
12439 (Catch.Resolve): Set and Restore ec.InCatch.
12440 (Try.Resolve): Set and Restore ec.InFinally.
12441 (Try.HasCatch): True when try has catch.
12443 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
12445 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
12446 for the same event member, so exclude such cases from warning 419.
12449 2005-04-16 Miguel de Icaza <miguel@novell.com>
12451 * expression.cs (Binary.ResolveOperator): Apply patch from John
12452 Luke to fix bug 59864: operators &, | and ^ on enumerations
12453 require that the same enum type on both sides.
12455 * driver.cs: Add warnings to old flag usage, this is to assist
12456 people who produce Makefiles and hope that the Makefiles will be
12459 * class.cs (TypeContainer.EmitType): Moved the definition of the
12460 special $PRIVATE$ field from the resolve phase to the Emit phase.
12461 During resolve we do not know if we are a struct with
12462 HasExplicitLayout, we know this only after the attributes for the
12465 Set the FieldOffset to zero on the dummy field that we create for
12466 the class. Fixes 74590.
12468 2005-04-16 Raja R Harinath <rharinath@novell.com>
12471 * ecore.cs (PropertyExpr.resolved): New.
12472 (DoResolve): Use it to handle a case of double resolution here.
12473 Handle a case of identical-name-and-type-name.
12474 * expression.cs (ArrayCreation.CheckIndices): Avoid double
12475 resolution by storing the results of expression resolution back
12476 into the "probes" array.
12478 2005-04-15 Raja R Harinath <rharinath@novell.com>
12480 Fix cs0208-7.cs and cs0208-8.cs.
12481 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
12482 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
12483 error reporting to point out the reason a struct is not unmanaged.
12485 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
12487 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
12488 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
12490 2005-04-13 Raja R Harinath <rharinath@novell.com>
12493 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
12494 IdenticalNameAndTypeName here.
12495 (EventExpr.InstanceResolve): Likewise.
12497 2005-04-13 Marek Safar <marek.safar@seznam.cz>
12499 C# 2.0 DefaultCharSetAttribute implementation
12501 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
12502 which allows us to set GlobalNamespace for every resolve.
12503 (Attribute.ResolveArguments): Cut from Resolve.
12504 (Attribute.GetCharSetValue): Returns CharSet named argument.
12505 (Attribute.DefinePInvokeMethod): Gets default charset from
12507 (GlobalAttribute.ResolveAsTypeStep): Override.
12508 (GlobalAttribute.ResolveArguments): Override.
12510 * class.cs (TypeAttr): Is protected.
12512 * codegen.cs (ModuleClass.DefaultCharSet): New member.
12513 (ModuleClass.DefaultCharSetType): New memeber.
12514 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
12516 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
12517 charset from module.
12519 * delegate.cs (TypeAttr): Override.
12520 (Delegate.DefineType): Use this TypeAttr.
12522 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
12523 at very early stage (before types are defined) to resolve model
12524 module attributes. It will probably not work with corlib but it
12527 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
12528 charset from module.
12530 * typemanager.cs (default_charset_type): New type.
12532 2005-04-13 Raja R Harinath <rharinath@novell.com>
12534 * decl.cs (MemberCache.AddMethods): Don't warn if
12535 System.Object.Finalize has buggy MethodAttributes.
12537 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
12540 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
12542 * doc.cs : detect ambiguous reference to overloaded members.
12543 Fixed bug #71603. MS 1.1 csc does not detect it.
12545 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
12547 * doc.cs : delegates must not be referenced with parameters.
12550 2005-04-12 Miguel de Icaza <miguel@novell.com>
12552 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
12554 2005-04-10 Miguel de Icaza <miguel@novell.com>
12556 * driver.cs (MainDriver): Stop processing if the CLS stage found
12559 (CompilerCallableEntryPoint.InvokeCompiler): Always
12560 reset after execution; Take a TextWriter argument for the
12563 * report.cs: Use the error stream instead of hardcoding stderr.
12565 2005-04-09 Miguel de Icaza <miguel@novell.com>
12567 * class.cs: Reduce code paths to test, too small of an
12568 optimization to make it worth the extra testing. Always perform
12571 2005-04-08 Raja R Harinath <rharinath@novell.com>
12574 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
12575 operators that had errors reported on them.
12577 2005-04-08 Marek Safar <marek.safar@seznam.cz>
12579 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
12581 (Attribute.Resolve): Add named argument type checking.
12583 * class.cs (FixedField.Define): Use IsPrimitiveType
12585 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
12587 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
12588 unsafe parameter types.
12590 * statement.cs (Using.ResolveExpression): Add better error description.
12592 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
12594 2005-04-08 Raja R Harinath <rharinath@novell.com>
12597 * attribute.cs (Attribute.GetAttributeUsage): Resolve
12598 AttributeUsageAttribute in the emitcontext of the attribute class,
12599 not in the emitcontext of the attributable entity it was attached to.
12600 * cs-parser.jay: Use 'current_class', not 'current_container',
12601 when creating a GlobalAttribute.
12603 2005-04-08 Alp Toker <alp@atoker.com>
12605 * pending.cs: The fix to #58413 failed to compile methods implementing
12606 interfaces with/without params modifiers and vice versa, even though
12607 params modifiers aren't part of the signature. Make the modifier check
12608 less strict as in csc.
12610 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
12611 Anoob V E <projectmonokochi@rediffmail.com>
12612 Harilal P R <projectmonokochi@rediffmail.com>
12615 * pending.cs (TypeAndMethods.mods): New. Store the parameter
12616 modifiers of pending methods.
12617 (PendingImplementation.PendingImplementation): Initialize it.
12618 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
12619 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
12620 with ParameterData. Add check for modifiers.
12621 * class.cs (MethodData.Define): Update to changes.
12623 2005-04-07 Raja R Harinath <rharinath@novell.com>
12625 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
12627 2005-04-07 Marek Safar <marek.safar@seznam.cz>
12629 * class.cs (PropertyMethod.Define): Check private accessor in abstract
12632 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
12635 * typemanager.cs: Registered RequiredAttributeAttribute.
12637 2005-04-06 Marek Safar <marek.safar@seznam.cz>
12639 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
12640 Warning CS0169 is back at level 3.
12641 (IMethodData.SetMemberIsUsed): New method.
12643 * decl.cs (IsUsed): New value; moved from FieldBase.Status
12644 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
12646 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
12648 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
12650 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
12653 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
12656 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
12657 to avoid the problems with nested types.
12659 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
12660 Anoob V.E <projectmonokochi@rediffmail.com>
12661 Harilal P.R <projectmonokochi@rediffmail.com>
12662 Raja R Harinath <rharinath@novell.com>
12665 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
12667 * typemanager (GetConstructor): Make public.
12669 2005-04-05 John Luke <john.luke@gmail.com>
12670 Raja R Harinath <rharinath@novell.com>
12673 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
12674 struct too. Return false quicker in a few cases.
12675 (VerifyUnManaged): Use it.
12677 2005-04-05 Raja R Harinath <rharinath@novell.com>
12680 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
12681 not 'unreachable_seen'.
12683 2005-04-04 Marek Safar <marek.safar@seznam.cz>
12685 * attribute.cs (Attribute.GetValue): Removed unused.
12687 * codegen.cs (CodeGen.TrimExt): Removed unused.
12689 * cs-parser.jay (output): Removed unused.
12691 * cs-tokenizer.cs (hex_digits): Removed unused.
12693 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
12695 * expression.cs (Indirection.LoadExprValue): Removed unused.
12696 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
12698 * iterators.cs (Iterator.param_types): Removed unused.
12700 * statement.cs (Goto.block): Removed unused.
12701 (ToplevelBlock.did): Removed unused.
12702 (Switch.ResolveConstantSwitch): Removed unused.
12704 2005-04-01 Ben Maurer <bmaurer@ximian.com>
12706 * rootcontext.cs: Allow mcs to bootstrap with the compilation
12709 2005-04-01 Raja R Harinath <rharinath@novell.com>
12711 Fix #74232 and cs0208-3.cs.
12712 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
12713 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
12714 unmanaged type. Don't use FieldBuilders when 't' is a
12715 TypeBuilder. Use ModFlags and MemberType fields.
12716 * class.cs (MemberBase.member_type): Rename from MemberType.
12717 (MemberBase.MemberType): New property. Determines member_type on
12719 (MemberBase.DoDefine): Don't initialize MemberType here.
12720 (FieldMember.Define): Likewise.
12722 2005-04-01 Marek Safar <marek.safar@seznam.cz>
12725 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
12726 Attributes are emitted there.
12728 2005-04-01 Raja R Harinath <rharinath@novell.com>
12730 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
12731 keyword in 'partial enum' too.
12732 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
12734 Report from Kamil Skalski <nazgul@omega.pl>.
12737 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
12738 have partial containers too.
12740 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
12741 in block' checks to Block.CheckInvariantMeaningInBlock.
12742 * statement.cs (Block.GetKnownVariableInfo): Make private.
12743 (Block.IsVariableUsedInChildBlock): Remove.
12744 (Block.IsVariableUsedInBlock): Likewise.
12745 (Block.CheckInvariantMeaningInBlock): New. Show location of
12746 conflicting declaration.
12747 (Block.AddVariable): Make error messages less long-winded and more
12748 specific. Show location of conflicting declaration.
12749 * parameter.cs (Parameters.Location): New readonly property.
12751 2005-03-31 Raja R Harinath <rharinath@novell.com>
12753 Clean up semantics of invoking ResolveMemberAccess.
12754 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
12755 can have an instance, ensure that we pass in a non-TypeExpression
12756 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
12757 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
12758 argument. Update to changes and simplify.
12759 (FieldExpr.Emitinstance): Remove CS0120 check.
12760 (PropertyExpr.EmitInstance): Likewise.
12761 * expression.cs (Argument.Resolve): Likewise.
12762 (Invocation.DoResolve): Update to changes in semantics of
12763 InstanceExpression.
12765 2005-03-31 Marek Safar <marek.safar@seznam.cz>
12768 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
12771 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
12773 2005-03-31 Raja R Harinath <rharinath@novell.com>
12775 Fix difference in behaviour with commandline invocation.
12776 * driver.cs (Driver.Reset): New.
12777 (CompilerCallableEntryPoint): Call it.
12779 * statement.cs (If.Resolve): Avoid spurious "uninitialized
12780 variable" warnings if the boolean expression failed to resolve.
12782 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
12784 * attribute.cs: Fix the union of several permissions when some of them
12785 are unrestricted (so the result isn't an unrestricted permission set).
12788 2005-03-30 Raja R Harinath <rharinath@novell.com>
12790 * ecore.cs (MemberExpr): New class. Convert from interface
12792 (MemberExpr.ResolveMemberAccess): Refactor and move here from
12793 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
12795 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
12796 (MethodGroupExpr.IsExplicitImpl): Remove.
12797 (Expression.GetFieldFromEvent): Remove.
12798 (SimpleName.MemberStaticCheck): Remove.
12799 (SimpleName.DoSimpleNameResolve): Update to changes.
12800 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
12801 (MemberAccess.IdenticalNameAndTypeName): Remove.
12802 (MemberAccess.error176): Move to MemberExpr.
12803 (MemberAccess.DoResolve): Update to changes.
12804 (BaseAccess.DoResolve): Likewise.
12806 2005-03-30 Marek Safar <marek.safar@seznam.cz>
12808 C# 2.0 Conditional attribute class implementation
12810 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
12811 Analyzes class whether it has attribute which has ConditionalAttribute
12812 and its condition is not defined.
12814 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
12815 (Class.IsExcluded): New method. Search for at least one defined
12816 condition in ConditionalAttribute of attribute class.
12818 2005-03-30 Raja R Harinath <rharinath@novell.com>
12820 * ecore.cs (PropertyExpr): Derive from Expression, not
12821 ExpressionStatement.
12822 (PropertyExpr.EmitStatement): Remove.
12824 2005-03-29 Raja R Harinath <rharinath@novell.com>
12827 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
12828 internal field "value__" of an enum be private. The examples for
12829 "value__" that I found on MSDN all used FieldAttributes.Private.
12831 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
12832 Don't mention IL method attribute names.
12834 Fix #47991. Remove a TODO.
12835 * statement.cs (Block.Toplevel): Make into a field.
12836 (Block.Parameters): Move into ToplevelBlock.
12837 (Block.known_variables): Rename from child_variable_names.
12838 (Block.Block): Remove variants that take Parameters. Initialize
12839 'Toplevel' with the immediately surrounding toplevel block.
12840 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
12841 LocalInfo parameter.
12842 (Block.GetKnownVariableInfo): New.
12843 (Block.IsVariableNameUsedInChildBlock): Update.
12844 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
12845 the block, even though it may not be in scope.
12846 (Block.AddVariable): Remove Parameters parameter. Use
12847 Toplevel.Parameters instead.
12848 (Block.AddConstant): Remove Parameters parameter.
12849 (Block.GetParameterReference): Update to use Toplevel.Parameters.
12850 (Block.IsParamaterReference): Likewise.
12851 (Block.IsLocalParameter): Likewise. Simplify a lot.
12852 (ToplevelBlock.Parameters): New. Moved from Block.
12853 (ToplevelBlock.ToplevelBlock): Update to changes. Always
12854 initialize Parameters to a non-null value.
12855 * cs-parser.jay: Update to changes.
12856 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
12857 simple names that mean different things in the same block. Use
12858 Block.IsVariableNameUsedInBlock.
12860 2005-03-28 Raja R Harinath <rharinath@novell.com>
12862 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
12863 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
12864 GetTypeHandle. It is possible for a reflected type to derive from
12865 a TypeBuilder (e.g., int[] derives from the TypeBuilder
12866 System.Array during mscorlib compilation).
12867 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
12868 contain a method_hash, don't create one either. Don't create a
12869 deep copy of the base cache's method_hash.
12870 (MemberCache.SetupCache): Rename back from DeepCopy.
12871 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
12872 already initialized. If we see an override function, add its
12873 underlying base virtual function to the member_hash too.
12875 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
12877 2005-03-26 Raja R Harinath <harinath@acm.org>
12880 * assign.cs (Assign.DoResolve): When the RHS of an assignment
12881 fails to resolve, ensure that the LHS is still resolved as an
12884 2005-03-25 Raja R Harinath <harinath@acm.org>
12886 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
12888 (Enum.current_ec): Remove.
12889 (Enum.LookupEnumValue): Remove EmitContext argument.
12890 Just uses the one created during DefineType.
12891 (Enum.FindMembers): Update.
12892 * expression.cs (MemberAccess.DoResolve): Update.
12894 2005-03-22 Marek Safar <marek.safar@seznam.cz>
12896 * assign.cs (Assign.DoResolve): Check for CS1717 when
12897 source and target are same (uses Equals).
12899 * expression.cs (LocalVariableReference, ParameterReference,
12900 This): Implemented Equals, GetHashCode.
12902 * statement.cs (Block.GetParameterReference): Removed useless
12905 2005-03-22 Raja R Harinath <rharinath@novell.com>
12908 * statement.cs (Block.AddVariable): Ensure that we skip implicit
12909 blocks before deciding whether the error is cs0136 or cs0128.
12911 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
12912 (using_alias_directive, using_namespace_directive): Pass
12913 MemberName, not an expression to Namespace.UsingAlias and
12915 (MakeName): Use the MemberName of the namespace.
12916 * namespace.cs (Namespace.MemberName): New.
12917 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
12918 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
12920 * decl.cs (MemberName.Name): Make readonly.
12921 (MemberName.FromDotted): New "constructor".
12922 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
12923 (MemberCore.Name): Compute from MemberName on demand.
12924 (MemberCore.SetMemberName): Provide a way to change the
12926 (MemberCore.AddToContainer): Don't take a fullname parameter.
12927 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
12928 fully qualified name of the container to the member name.
12929 (TypeContainer.AddToTypeContainer): Use a fully qualified name
12930 only if the type is a member of the root container.
12931 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
12932 MemberName.Left rather than searching for an embedded ".".
12933 (PartialContainer.CreatePart): Update to changes in RootContext.
12934 (MemberBase.ShortName): Turn into a property. Use
12935 MemberCore.SetMemberName.
12936 (MemberBase.ExplicitInterfaceName): Remove.
12937 (MemberBase.UpdateMemberName): Remove.
12938 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
12939 (PropertyBase.SetMemberName): New override.
12940 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
12941 (Tree.GetDecl): New.
12942 (Tree.AllDecls): Rename from Decls.
12943 * attribute.cs, enum.cs, report.cs: Update to changes.
12944 * driver.cs (MainDriver): Use MemberName.FromDotted on
12945 RootContext.MainClass.
12947 2005-03-21 Marek Safar <marek.safar@seznam.cz>
12949 * class.cs (FixedField.Define): Check for CS1664 and more sanity
12952 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
12954 2005-03-18 Marek Safar <marek.safar@seznam.cz>
12956 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
12957 property accessor modifiers.
12959 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
12960 fixed buffer attribute (CS1716).
12961 (PropertyMethod.HasCustomAccessModifier): When property accessor
12962 has custom modifier.
12964 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
12966 (PropertyExpr.DoResolveLValue): Add CS0272.
12968 2005-03-17 Miguel de Icaza <miguel@novell.com>
12970 * convert.cs: When converting to a pointer, use the proper Conv.U
12971 or Conv.I depending on the source data type.
12973 * cs-tokenizer.cs: Make the size for large decimal constants,
12976 2005-03-17 Martin Baulig <martin@ximian.com>
12978 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
12979 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
12981 2005-03-17 Martin Baulig <martin@ximian.com>
12983 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
12984 to bool so we can return an error condition.
12985 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
12988 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
12990 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
12993 2005-03-16 Raja R Harinath <rharinath@novell.com>
12995 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
12996 Refactor to avoid traversing the list of assemblies, and to avoid
12997 string concatenation.
12998 * typemanager.cs (guid_attr_type): Remove.
12999 (negative_hits, pointers, references): Remove hashes.
13001 (GetConstructedType): New. Uses type_hash to handle constructed
13002 types (arrays, references, pointers).
13003 (GetReferenceType, GetPointerType): Use it.
13004 (GetNestedType): New. Uses type_hash to handle nested types of
13006 (LookupType, LookupTypeDirect): Remove.
13007 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
13008 'types' hash and LookupTypeReflection directly.
13009 (params_string, params_object): Use GetConstructedType.
13010 * namespace.cs (Namespace.cached_types): New. Cache of reflected
13012 (Namespace.Lookup): Use cached_types.
13013 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
13014 provided by old TypeManager.LookupType.
13015 * rootcontext.cs (MakeFQN): Remove.
13016 * decl.cs (DeclSpace.MakeFQN): Likewise.
13017 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
13018 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13019 TypeManager.GetConstructedType.
13020 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
13022 2005-03-15 Marek Safar <marek.safar@seznam.cz>
13024 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
13027 * cs-parser.jay: Reports CS1527 for any namespace element.
13029 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
13032 * expression.cs (ParameterReference.IsAssigned): Changed error to
13034 (Error_WrongNumArguments): Moved CS0245 detection here.
13036 * statement.cs (Return.Resolve): Add CS1622 report.
13038 2005-03-11 Marek Safar <marek.safar@seznam.cz>
13040 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
13042 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
13044 * attribute.cs expression.cs: Get rid of some allocations.
13046 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
13048 * doc.cs : just eliminate the latest change.
13050 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13052 * doc.cs : commented out the latest change. It breaks xml-030.cs
13054 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13056 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
13057 fail. So invoke CreateType() in FindDocumentedType().
13059 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13061 * cs-tokenizer.cs : added IsKeyword().
13062 * doc.cs : Detect keyword incorrectly used as identifier.
13063 Allow identifiers prefixed by @.
13065 2005-03-10 Marek Safar <marek.safar@seznam.cz>
13067 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
13068 It caused exception in namespace resolving (again!).
13070 * class.cs (Class.ctor): Removed exit.
13071 (PropertyMethod.ctor): ditto.
13073 * codegen.cs (Codegen.Reset): Reset static data.
13074 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
13076 * cs-tokenizer.cs (Cleanup): Removed.
13078 * driver.cs (GetSystemDir): Rewrote to one line command.
13079 It caused problem with unloaded dynamic modules.
13080 (UnixParseOption): Removed Exit.
13081 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
13082 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
13083 Now can be mcs used as library.
13085 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
13088 * location.cs (Reset): Reset static data.
13090 * namespace.cs (Reset): Reset static data.
13092 * report.cs (Report.Reset): Reset static data.
13094 * rootcontext.cs (RootContext.Reset): Reset static data.
13096 * tree.cs (RootTypes.ctor): Use Location.Null
13098 * typemanager.cs (TypeManager.Reset): Reset static data.
13099 (CoreLookupType): Removed Exit.
13100 (TypeHandle.Reset): Reset static data.
13102 2005-03-10 Raja R Harinath <rharinath@novell.com>
13105 * typemanager.cs (ComputeNamespaces): Import namespaces from
13106 referenced modules too.
13108 2005-03-09 Raja R Harinath <rharinath@novell.com>
13110 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
13113 2005-03-09 Raja R Harinath <rharinath@novell.com>
13115 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
13116 enclosing DeclSpace. This ensures that a name-lookup populates
13117 more caches and there are fewer 'TypeExpression's. Carve out
13118 nested type lookup into ...
13119 (LookupNestedTypeInHierarchy): ... this.
13121 2005-03-09 Raja R Harinath <rharinath@novell.com>
13123 Clean up a few partial-class semantics.
13124 Fixes test-357.cs and cs1618-2.cs.
13125 * cs-parser.jay (struct_declaration): Use 'current_class' as
13126 parent of newly-created struct. Remove call to Register ().
13127 Use 'pop_current_class' to complete handing the current struct.
13128 (interface_declaration): Likewise.
13129 (class_declaration): Likewise.
13130 (enum_declaration): Use 'current_class' as parent of newly created
13132 (delegate_declaration): Likewise.
13133 (pop_current_class): New function. This is used to handle closing
13134 up the 'current_class' and 'current_container', and pointing them
13135 to the enclosing class/container.
13136 (CSharpParser): Initialize 'current_class' too.
13137 * decl.cs (MemberCore): Add check for invariant: a partial
13138 container is not a parsed entity, and thus does not enclose any
13140 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
13141 (DeclSpace.BaseTypeExpr): Use it.
13142 (DeclSpace.LookupType): Add check for invariant.
13143 * class.cs (TypeContainer): Add check for invariant: a nested
13144 class should have the same NamespaceEntry as its enclosing class.
13145 (TypeContainer.EmitFieldInitializers): Make virtual.
13146 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
13148 (TypeContainer.Register): Remove.
13149 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
13150 null. Use TypeResolveEmitContext for resolving base types and
13151 interfaces. Move initialization of Parts.TypeBuilder here from
13153 (TypeContainer.DefineNestedTypes): ... here.
13154 (PartialContainer): Take a Namespace not a NamespaceEntry.
13155 (PartialContainer.Create): Don't use Register. Call the
13156 appropriate Add... function directly.
13157 (ClassPart): Take both the PartialContainer and the enclosing
13158 class as constructor arguments.
13159 (ClassPart.EmitFieldInitializers): Override.
13160 (ClassPart.PartFindNestedTypes): Remove.
13161 (FieldBase.GetInitializerExpression): Resolve the initializer
13162 expression in the emit context of the enclosing class.
13163 * tree.cs (RootTypes): Remove Register ().
13165 2005-03-08 Marek Safar <marek.safar@seznam.cz>
13167 * cs-parser.jay: Removed CS0134.
13169 * driver.cs: Removed CS1901.
13171 * expression.cs (SizeOf.DoResolve): Don't report CS0233
13172 for predefined types.
13174 2005-03-07 Duncan Mak <duncan@novell.com>
13176 * codegen.cs (Save): Catch UnauthorizedAccessException as
13177 well. Fixes bug #73454.
13179 2005-03-07 Marek Safar <marek.safar@seznam.cz>
13181 * cs-tokenizer.cs (xtoken): Add CS1035.
13183 * class.cs (MethodData.Define): Add CS0683.
13184 (FieldMember.ctor): Add CS0681.
13186 2005-03-07 Raja R Harinath <rharinath@novell.com>
13188 * ecore.cs (SimpleName.DoResolve): Rename from
13189 SimpleName.DoResolveAllowStatic.
13190 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
13191 Pass 'intermediate' flag to MemberStaticCheck.
13192 (SimpleName.MemberStaticCheck): Skip "static check" only in case
13193 of "intermediate" lookups via MemberAccess.
13194 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
13195 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
13197 2005-03-07 Raja R Harinath <rharinath@novell.com>
13200 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
13201 slipped in because of variable names that are identical to a
13202 builtin type's BCL equivalent ('string String;', 'int Int32;').
13203 (PropertyExpr.EmitInstance): Likewise.
13205 2005-03-04 Marek Safar <marek.safar@seznam.cz>
13207 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
13209 * report.cs (warning_ignore_table): Made public.
13211 2005-03-04 Raja R Harinath <rharinath@novell.com>
13214 * class.cs (MethodData.Emit): Pass 'container' to
13215 container.GetObsoleteAttribute instead of 'container.Parent'.
13217 2005-03-03 Marek Safar <marek.safar@seznam.cz>
13219 * cs-parser.jay: Add 1534 error test.
13221 * iterators.cs (Yield.CheckContext): Add error 1629.
13222 (Iterator.ctor): Save unsafe modifier.
13223 (MoveNextMethod.DoEmit): Restore unsafe context.
13225 * namespace.cs (UsingAlias): Better error message.
13227 2005-03-03 Dan Winship <danw@novell.com>
13229 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
13230 the warning message [#73219]
13232 2005-03-03 Raja R Harinath <rharinath@novell.com>
13234 Fix compile with MCS 1.0.0.0.
13235 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
13236 w_restore to not depend on string constant folding.
13238 2005-03-03 Raja R Harinath <rharinath@novell.com>
13240 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
13241 CS0246 check to users who passed 'silent = false'.
13242 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
13244 (SimpleName.SimpleNameResolve): Update.
13245 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
13246 (MemberAccess.IdenticalNameAndTypeName): Update.
13247 * doc.cs (FindDocumentedTypeNonArray): Update.
13249 2005-03-03 Raja R Harinath <rharinath@novell.com>
13251 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
13252 * parameters.cs (ComputeAndDefineParameters): Remove.
13253 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
13254 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
13255 Use GetParameterInfo.
13257 2005-03-02 Marek Safar <marek.safar@seznam.cz>
13259 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
13261 2005-03-02 Raja R Harinath <rharinath@novell.com>
13263 Unify DeclSpace.LookupType and DeclSpace.FindType.
13264 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
13265 is in charge of defining nested types on demand.
13266 (DeclSpace.LookupType): Use it when the current_type is a
13267 TypeBuilder. Use LookupTypeDirect for reflected types.
13268 (DeclSpace.FindType): Remove.
13269 (DeclSpace.LookupInterfaceOrClass): Likewise.
13270 (DeclSpace.DefineTypeAndParents): Likewise.
13271 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
13272 DeclSpace.LookupType.
13273 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
13274 * typemanager.cs (LookupType): Simplify.
13275 (AddUserType): Remove type from negative_hits.
13276 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
13277 * class.cs (TypeContainer.FindMembers): Move handling of nested
13279 (TypeContainer.FindMembers_NestedTypes): ... here.
13280 (TypeContainer.FindNestedType): Implement override.
13281 (ClassPart.FindNestedType): Delegate to PartialContainer.
13282 (ClassPart.PartFindNestedType): Looks up the nested types of the
13285 2005-03-02 Martin Baulig <martin@ximian.com>
13287 * class.cs (TypeContainer.DoDefineMembers): We also need a default
13288 static constructor in static classes.
13290 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
13292 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
13293 sizeParamIndex is not specified.
13295 2005-03-01 Marek Safar <marek.safar@seznam.cz>
13298 * report.cs (WarningMessage.IsEnabled): Missing null check.
13300 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13302 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
13303 in the fields and not in the properties.
13305 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
13307 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
13310 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13312 * attribute.cs: Small refactoring (improved robustness).
13313 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
13314 (ValidateGuid): Removed.
13315 (Resolve): Removed referenced to above mentioned.
13316 (GetAttributeUsage): Made private and changed to work without
13318 (GetIndexerAttributeValue): Don't crash.
13319 (GetConditionalAttributeValue): Ditto.
13320 (GetClsCompliantAttributeValue): Ditto.
13321 (ExtractSecurityPermissionSet): All attributes exceptions are
13323 (GetPropertyValue): New helper.
13324 (GetMethodImplOptions): New method.
13325 (DefinePInvokeMethod): Reuse common code. Implemented handling of
13326 some missing properties.
13328 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
13329 (Method.ApplyAttributeBuilder): Updated.
13331 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
13334 2005-02-28 Raja R Harinath <rharinath@novell.com>
13337 * report.cs (Report.SymbolRelatedToPreviousError): Handle
13338 non-simple types (array, pointer, reference).
13340 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13342 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
13344 * class.cs (MethodCore.IsDuplicateImplementation): Special error
13346 (Method.CheckBase): Catch wrong destructor here.
13347 (MethodData.Define): Add errors 550, 668.
13349 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
13351 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
13353 * pending.cs (VerifyPendingMethods): Add error 551.
13355 * typemanager.cs (CSharpName): Next error report helper.
13357 2005-02-25 Marek Safar <marek.safar@seznam.cz>
13359 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
13360 attributes. Removed useless attribute double check.
13361 It saves almost 2MBs for corlib.
13363 2005-02-25 Raja R Harinath <rharinath@novell.com>
13366 * statement.cs (ExpressionStatement.Resolve): Make robust to being
13367 called twice in case of error.
13369 2005-02-23 Chris Toshok <toshok@ximian.com>
13371 Fix compiler portions of #72827.
13372 * statement.cs (Block.Emit): call Begin/EndScope on the
13373 EmitContext instead of the ILGenerator.
13375 * codegen.cs (EmitContext.BeginScope): new method, call
13376 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
13378 (EmitContext.BeginScope): same, but EndScope and CloseScope
13380 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
13381 offset and call the superclass's OpenScope(int) with it.
13382 (SymbolWriter.CloseScope): get the current il
13383 offset and call superclass's CloseScope(int) with it.
13385 2005-02-23 Marek Safar <marek.safar@seznam.cz>
13387 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
13388 CS1677 for out and ref as well.
13390 * class.cs (Method.Define): Add error CS1599 detection.
13392 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
13394 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
13396 * delegate.cs (Delegate.Define): Add error CS1599 detection.
13398 * support.cs.cs (ModifierDesc): New helper method.
13400 2005-02-23 Raja R Harinath <rharinath@novell.com>
13401 Abin Thomas <projectmonokochi@rediffmail.com>
13402 Anoob V E <projectmonokochi@rediffmail.com>
13403 Harilal P R <projectmonokochi@rediffmail.com>
13405 Fix #57851, #72718.
13406 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
13407 MemberLookup (used for error reporting) actually returns a result.
13408 Fix error report number (122, not 112).
13410 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
13411 Anoob V E <projectmonokochi@rediffmail.com>
13412 Harilal P R <projectmonokochi@rediffmail.com>
13415 * pending.cs (PendingImplementation.GetAbstractMethods):
13416 Find NonPublic members too.
13418 2005-02-22 Marek Safar <marek.safar@seznam.cz>
13420 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
13423 * class.cs (MethodCore.CheckMethodAgainstBase):
13424 Add error 239 report.
13426 2005-02-21 Raja R Harinath <rharinath@novell.com>
13429 * expression.cs (Invocation.IsApplicable): Make public.
13430 (Invocation.IsParamsMethodApplicable): Likewise.
13431 * delegate.cs (Delegate.VerifyApplicability): Don't use
13432 Invocation.VerifyArgumentCompat for parameter applicability
13433 testing. Use Invocation.IsApplicable and
13434 Invocation.IsParamsMethodApplicable.
13436 2005-02-21 Marek Safar <marek.safar@seznam.cz>
13438 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
13440 * class.cs (Operator.Define): Add error 217 report.
13442 2005-02-21 Raja R Harinath <rharinath@novell.com>
13444 * namespace.cs (UsingEntry.Resolve): Undo change below.
13446 2005-02-21 Raja R Harinath <rharinath@novell.com>
13449 * ecore.cs (Expression.MemberLookupFailed): Add argument to
13450 disable the error message when the extended MemberLookup also
13452 (Expression.MemberLookupFinal): Update.
13453 (SimpleName.DoSimpleNameResolve): Update.
13454 * expression.cs (MemberAccess.ResolveNamespaceOrType):
13455 Don't use MemberLookupFinal.
13456 (New.DoResolve): Update.
13457 (BaseAccess.CommonResolve): Update.
13459 2005-02-21 Raja R Harinath <rharinath@novell.com>
13462 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
13463 occured previously, don't resolve again.
13465 2005-02-21 Marek Safar <marek.safar@seznam.cz>
13468 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
13469 argument. Call ResolveAttributeUsage for unresolved.
13470 when types doesn't match ctor arguments.
13472 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
13473 for nested attribute classes.
13474 (Class.attribute_usage): Removed.
13475 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
13476 for attribute class.
13478 * ecore.cs (IsAttribute): Removed.
13480 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
13482 * rootcontext.cs (RegisterAttribute): Removed, attributes are
13484 (attribute_types): Removed.
13485 (EmitCode): Global attributes are emited as the latest.
13487 2005-02-18 Marek Safar <marek.safar@seznam.cz>
13489 * class.cs (EmitFieldInitializers): Don't emit field initializer
13490 for default values when optimilization is on.
13492 * constant.cs (Constant.IsDefaultValue): New property.
13494 * driver.cs: Add /optimize handling.
13498 * literal.cs: Implement new IsDefaultValue property.
13500 * rootcontext.cs (Optimize): New field, holds /optimize option.
13502 2005-02-18 Raja R Harinath <rharinath@novell.com>
13504 Fix crasher in re-opened #72347.
13505 * namespace.cs (Namespace.Lookup): Return null if
13506 DeclSpace.DefineType returns null.
13509 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
13511 2005-02-18 Raja R Harinath <rharinath@novell.com>
13513 Fix remainder of #63202. Change semantics of DoResolveLValue: it
13514 now returns null if it cannot resolve to an lvalue.
13515 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
13516 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
13517 returned null. Remove check for SimpleName.
13518 (EventExpr.DoResolveLValue): New.
13519 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
13520 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
13522 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
13523 avoid CS0131 error.
13524 (Unary.ResolveOperator): Move CS0211 check ...
13525 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
13527 (Unary.DoResolveLValue): Simplify.
13528 (AddressOf.DoResolveLValue): New.
13529 (ArrayAccess.DoResolveLValue): New.
13531 2005-02-16 Marek Safar <marek.safar@seznam.cz>
13533 * attribute.cs (Attribute.Resolve): Add arguments casting for
13534 when types doesn't match ctor arguments.
13536 2005-02-16 Raja R Harinath <rharinath@novell.com>
13538 Fix parts of #63202.
13539 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
13540 lookup of operator in base type. Ensure that all checks happen
13541 when the operator resolves to an "op_..." method.
13543 2005-02-15 Raja R Harinath <rharinath@novell.com>
13546 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
13547 'ignore_cs0104' parameter. Pass it to ...
13548 (NamespaceEntry.Lookup): ... this.
13549 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
13550 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
13551 (TypeLookupExpression.DoResolveAsTypeStep): Update.
13552 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
13553 Update. Request that cs0104 errors be ignored.
13554 (ComposedCast.ResolveAsTypeStep): Update.
13556 2005-02-14 Raja R Harinath <rharinath@novell.com>
13559 * expression.cs (Invocation.BetterFunction): Remove support for
13560 comparing virtual functions and their overrides.
13561 (Invocation.IsOverride): New.
13562 (Invocation.OverloadResolve): Don't consider 'override' functions
13563 during candidate selection. Store them in a lookaside list.
13564 If the selected method is a 'virtual' function, use the list to
13565 find any overrides that are closer to the LHS type.
13567 2005-02-14 Marek Safar <marek.safar@seznam.cz>
13569 * expression.cs (New.DoResolve): Add complex core type reduction.
13570 (New.Constantify): Converts complex core type syntax like 'new int ()'
13571 to simple constant.
13573 2005-02-14 Raja R Harinath <rharinath@novell.com>
13575 * decl.cs (EntryType.EntryType): New constructor to create an
13576 updated copy of a cache entry.
13577 (MemberCache.AddMethods): Use it.
13578 (MemberCache.ClearDeclaredOnly): Remove.
13579 (MemberCache.MemberCache): Update.
13581 2005-02-11 Miguel de Icaza <miguel@novell.com>
13583 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
13584 variable. This one is represents the actual low-level declaration
13585 of the method, as opposed to the semantic level `IsStatic'.
13587 An anonymous method which is hosted into a static method might be
13588 actually an instance method. IsStatic would reflect the
13589 container, while MethodIsStatic represents the actual code
13592 * expression.cs (ParameterReference): Use the new MethodIsStatic
13593 instead of IsStatic.
13595 * anonymous.cs (AnonymousMethod.Compatible): Pass the
13596 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
13597 set on the current EmitContext.
13599 * expression.cs (Cast): Overload DoResolveLValue so we can pass
13600 resolve our casted expression as an LValue. This triggers the
13601 proper LValue processing that is later required by Assign.
13605 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
13607 2005-02-11 Marek Safar <marek.safar@seznam.cz>
13609 C# 2.0 Fixed buffer implementation
13611 * anonymous.cs: Update after RegisterHelperClass renaming.
13613 * attribute.cs (AttributeTester.fixed_buffer_cache):
13614 Cache of external fixed buffers.
13615 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
13616 implementation if field is fixed buffer else null.
13619 (TypeContainer.AddField): Accept FieldMember instead of Field.
13620 (FieldBase.IsFieldClsCompliant): Extracted code from
13621 VerifyClsCompliance descendant customization.
13622 (FixedField): New class handles fixed buffer fields.
13623 (FixedFieldExternal): Keeps information about imported fixed
13625 (IFixedField): Make access to internal or external fixed buffer
13628 * cs-parser.jay: Add fixed buffer parsing.
13630 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
13633 * expression.cs (Indirection): Extended implementation to accept
13634 fixed buffer field.
13635 (PointerArithmetic.Emit): Get element from fixed buffer as well.
13636 (ElementAccess.MakePointerAccess): Get type as parameter.
13637 (DoResolve): Add fixed buffer field expression conversion.
13638 (DoResolveLValue): Ditto.
13639 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
13640 (ArrayPtr): Derives from FixedBufferPtr.
13641 (ArrayPtr.Emit): Add extra emit for array elements.
13643 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
13645 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
13646 for compiler generated types.
13647 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
13649 * statement.cs (Fixed): Refactored to be easier add fixed buffer
13650 and consume less memory.
13651 (Fixed.Resolve): Add fixed buffer case.
13653 * typemanager.cs (compiler_generated_attr_ctor,
13654 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
13655 (HasElementType): Add our own implementation to work on every
13658 2005-02-11 Miguel de Icaza <miguel@novell.com>
13660 * anonymous.cs (CaptureContext): Track whether `this' has been
13663 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
13664 only captured `this' if it was implicitly done (instance
13665 methods/variables were used).
13667 * codegen.cs (EmitContext.CaptureThis): New method to flag that
13668 `this' must be captured.
13670 2005-01-30 Miguel de Icaza <miguel@novell.com>
13672 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
13673 is null it means that there has been no need to capture anything,
13674 so we just create a sibling.
13676 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
13678 Just a partial fix. The other half is fairly elusive.
13680 2005-02-10 Raja R Harinath <rharinath@novell.com>
13682 Fix #52586, cs0121-4.cs.
13683 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
13684 and return a hashtable.
13685 (MemberCache.ClearDeclaredOnly): New.
13686 (MemberCache.MemberCache): Update to change. Make a deep copy of
13687 the method_hash of a base type too.
13688 (MemberCache.AddMethods): Adapt to having a deep copy of the base
13689 type methods. Overwrite entries with the same MethodHandle so
13690 that the ReflectedType is correct. The process leaves in base
13691 virtual functions and their overrides as distinct entries.
13692 (CacheEntry): Now a class instead of a struct. It shouldn't alter
13693 matters since it was boxed in a ArrayList before.
13694 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
13696 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
13697 case of a virtual function and its override (choose the overload
13699 (Invocation.OverloadResolve): Avoid 'override' members during
13700 'applicable_type' calculation.
13702 2005-02-09 Raja R Harinath <rharinath@novell.com>
13704 Combine two near-redundant caches.
13705 * typemanager.cs (method_params): Rename from method_internal_params.
13706 (TypeManager.GetParameterData): New. Replace
13707 Invocation.GetParameterData.
13708 (TypeManager.LookupParametersByBuilder): Remove.
13709 * expression.cs (Invocation.method_parameter_cache): Remove.
13710 (Invocation.GetParameterData): Remove.
13712 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
13715 2005-02-08 Raja R Harinath <rharinath@novell.com>
13718 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
13719 TypeManager.multicast_delegate_type is null, resolve it by looking
13720 up "System.MulticastDelegate".
13721 * rootcontext.cs (RootContext.ResolveCore): Simplify.
13723 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
13724 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
13725 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
13728 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
13729 (LabeledStatement.AddReference): New. Set 'referenced'.
13730 (Goto.Resolve): Use it.
13732 2005-02-05 John Luke <john.luke@gmail.com>
13734 * driver.cs: remove duplicate -doc line in Usage ()
13736 2005-02-04 Raja R Harinath <rharinath@novell.com>
13738 * location.cs (Location.AddFile): Fix CS2002 error report.
13740 2005-02-02 Martin Baulig <martin@ximian.com>
13742 * delegate.cs (Delegate.DefineType): Report an internal error if
13743 TypeManager.multicast_delegate_type is null. See bug #72015 for
13746 2005-02-02 Raja R Harinath <rharinath@novell.com>
13748 Fix a crasher in a variant of #31984.
13749 * const.cs (Constant.CheckBase): New override that defers the
13750 new-or-override check in case the base type hasn't been populated
13752 (Constant.Define): Ensure the new-or-override check is performed.
13754 2005-02-01 Duncan Mak <duncan@ximian.com>
13756 * const.cs (LookupConstantValue): Check that `ce' is not null
13757 before calling GetValue ().
13759 2005-02-01 Raja R Harinath <rharinath@novell.com>
13761 Fix test-334.cs (#69519).
13762 * cs-parser.jay (using_alias_directive): Pass in an expression to
13763 NamespaceEntry.UsingAlias.
13764 (using_namespace_directive): Pass in an expression to
13765 NamespaceEntry.Using.
13766 (namespace_name): Don't flatten to a string.
13767 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
13768 (NamespaceEntry.AliasEntry.Resolve): Lookup using
13770 (NamespaceEntry.UsingEntry): Likewise.
13771 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
13773 (NamespaceEntry.LookupForUsing): Remove.
13774 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
13776 (NamespaceEntry.Lookup): Remove support for dotted names.
13778 2005-02-01 Raja R Harinath <rharinath@novell.com>
13780 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
13782 (NamespaceEntry.ImplicitParent): Compute on demand.
13783 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
13784 parallels the current.
13785 (NamespaceEntry.LookupForUsing): Use it.
13786 (NamespaceEntry.Lookup): If the current namespace-entry is
13787 implicit, don't search aliases and using tables.
13789 2005-02-01 Raja R Harinath <rharinath@novell.com>
13792 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
13794 (TypeContainer.BaseCache): Compute on demand.
13795 (TypeContainer.FindMembers): Define constants and types if they're
13796 not already created.
13797 (FieldMember.Define): Move resetting of ec.InUnsafe before error
13799 * const.cs (Constant.Define): Make idempotent.
13801 2005-01-29 Miguel de Icaza <miguel@novell.com>
13803 * pending.cs: Produce better code (no nops produced by using Ldarg
13806 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
13807 i - 1' it should be arg + 1.
13811 2005-01-28 Raja R Harinath <rharinath@novell.com>
13813 * attribute.cs (Attribute.CheckAttributeType): Make private
13815 (Attribute.ResolveType): Make virtual.
13816 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
13817 handling of RootContext.Tree.Types.
13819 2005-01-27 Raja R Harinath <rharinath@novell.com>
13821 Update attribute-handling to use the SimpleName/MemberAccess
13823 * cs-parser.jay (attribute): Pass in an expression to the
13824 constructors of Attribute and GlobalAttribute.
13825 * attribute.cs (Attribute): Take an expression for the name.
13826 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
13827 passed in attribute name expression.
13828 (Attribute.CheckAttributeType): Use it.
13829 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
13830 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
13831 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
13832 argument to prevent error messages if the lookup fails.
13834 2005-01-27 Marek Safar <marek.safar@seznam.cz>
13836 * expression.cs (Indirection): Implemented IVariable interface
13837 to support indirection in AddressOf operator.
13838 (PointerArithmetic.Emit): Add optimalization for case where
13839 result can be precomputed.
13841 2005-01-26 Martin Baulig <martin@ximian.com>
13843 * class.cs (TypeContainer.AttributeTargets): Return the correct
13844 AttributeTargets depending on our `Kind' instead of throwing an
13845 exception; fixes #71632.
13847 2005-01-26 Marek Safar <marek.safar@seznam.cz>
13850 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
13853 2005-01-25 Raja R Harinath <rharinath@novell.com>
13856 * expression.cs (MemberAccess.DoResolve): Don't complain with
13857 cs0572 when the LHS of a member access has identical name and type
13860 2005-01-25 Marek Safar <marek.safar@seznam.cz>
13863 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
13865 Create custom PermissionSet only for PermissionSetAttribute.
13867 2005-01-24 Marek Safar <marek.safar@seznam.cz>
13870 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
13871 delegates in static class.
13873 2005-01-24 Martin Baulig <martin@ximian.com>
13875 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13876 merging an implicit block, just use its reachability.
13878 * statement.cs (Block.Resolve): Make the unreachable code check
13879 work wrt. implicit blocks; see test-337 from #63842.
13881 2005-01-21 Alp Toker <alp@atoker.com>
13883 * cs-parser.jay: destructor_declaration's container is PartialContainer
13884 not Class when partial types are used, so use Kind prop instead of
13887 2005-01-22 Miguel de Icaza <miguel@ximian.com>
13889 * cs-parser.jay: Improve error reporting when an interface
13890 declares new types.
13892 2005-01-20 Dick Porter <dick@ximian.com>
13894 * support.cs: SeekableStreamReader fix from Sandor Dobos
13895 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
13896 chars are read. Fixes bug 70369.
13898 2005-01-20 Raja R Harinath <rharinath@novell.com>
13900 * cs-parser.jay (catch_clause): Simplify current_block handling
13903 2005-01-17 Miguel de Icaza <miguel@ximian.com>
13905 * convert.cs (ImplicitStandardConversionExists): Synchronize the
13906 code with ImplicitStandardConversion to handle the implicit
13907 conversion of method groups into valid delegate invocations.
13909 The problem is that in parameter handling we were using this code
13910 path. Fixes bug #64698
13912 2005-01-19 Raja R Harinath <rharinath@novell.com>
13914 * cs-parser.jay: Fix several infelicities.
13915 - Avoid assigning to the parser value stack. Code like
13916 '$3 = null' is unclean. Synthesize a value for the code block
13918 - Avoid using oob_stack for storing location information. Use ...
13919 (_mark_): ... this. New (empty) rule. Saves the current location
13921 (foreach_statement): Avoid using oob_stack for current_block
13922 handling. Use technique used in for_statement and
13923 using_statement. Synthesize a value for the code block to store
13924 additional intermediate information.
13926 2005-01-13 Miguel de Icaza <miguel@ximian.com>
13928 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
13929 of a different type is only allowed to private fields of a
13930 containing type, not on fields of a base class.
13932 See test-174.cs and error cs0122-9.cs
13934 2005-01-13 Raja R Harinath <rharinath@novell.com>
13936 Fix test-335.cs (bug #58126).
13937 * cs-parser.jay (argument): Split out non-expression parts of the
13938 rule into 'non_simple_argument'.
13939 (invocation_expression): Support parenthesized invocations with
13940 multiple arguments, and with single non-simple arguments.
13942 2005-01-13 Raja R Harinath <rharinath@novell.com>
13944 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
13947 2005-01-12 Raja R Harinath <rharinath@novell.com>
13949 Fix cs0038-1.cs, cs1640-6.cs.
13950 * ecore.cs (Expression.Resolve): Remove special-case for
13951 SimpleName in error-handling.
13952 (Expression.almostMatchedMembers): Relax access permission to
13954 (Expression.MemberLookupFailed): Handle duplicates in
13955 almostMatchedMembers list.
13956 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
13957 * expression.cs (New.DoResolve): Report CS1540 for more cases.
13958 * typemanager.cs (GetFullNameSignature): Use the MethodBase
13959 overload if the passed in MemberInfo is a MethodBase.
13961 2005-01-12 Marek Safar <marek.safar@seznam.cz>
13964 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
13965 for non-CAS & merge permission sets properly.
13967 2005-01-11 Raja R Harinath <rharinath@novell.com>
13969 Improve standard-compliance of simple name and member access
13970 resolution. Fixes bugs #52697, #57200, #67520, #69519.
13971 * ecore.cs (FullNamedExpression): New abstract base class
13972 for Namespaces and TypeExpressions.
13973 (ResolveFlags.SimpleName): Remove.
13974 (SimpleName): Remove support for dotted names.
13975 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
13976 DeclSpace.FindType and DeclSpace.LookupType.
13977 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
13978 (Expression.ExprClassName): Make member function.
13979 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
13980 a namespace. Remove creation of dotted "SimpleName"s.
13981 (MemberAccess.DoResolve): Likewise.
13982 * decl.cs (DeclSpace.Cache): Make private.
13983 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
13984 (DeclSpace.FindType): Update.
13985 (DeclSpace.LookupType): Move here from RootContext. Return a
13986 FullNamedExpression.
13987 * namespace.cs (Namespace): Derive from FullNamedExpression
13988 so that it can be part of expression resolution.
13989 (Namespace.Lookup): Return an FullNamedExpression.
13990 (NamespaceEntry.LookupAlias): Lookup aliases only in current
13992 * rootcontext.cs (NamespaceLookup): Remove.
13993 (LookupType): Move to DeclSpace.
13994 * attribute.cs (CheckAttributeType): Update.
13995 * doc.cs (FindDocumentedType): Remove allowAlias argument.
13996 (FindDocumentedTypeNonArray): Likewise.
13998 2005-01-11 Raja R Harinath <rharinath@novell.com>
14000 Fix cs0509.cs, cs1632.cs.
14001 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
14002 is the same as IsInterface.
14003 (TypeContainer.GetClassBases): Likewise.
14004 * statement.cs (LabeledStatement.ig): New field.
14005 (LabeledStatement.LabelTarget): Save ILGenerator which created the
14007 (LabeledStatement.DoEmit): Check that the label was created with
14008 the same ILGenerator.
14010 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14013 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
14014 accessors to its properties.
14016 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
14017 from accessors to property.
14019 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14022 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
14023 only for overrides.
14025 2005-01-08 Miguel de Icaza <miguel@ximian.com>
14027 * attribute.cs: Check for null and empty strings.
14029 I have lost another battle to Paolo.
14031 2005-01-07 Marek Safar <marek.safar@seznam.cz>
14034 * class.cs (PropertyMethod): Set Parent field in ctors.
14035 (SetMethod.InternalParameters): Add unsafe switch hack.
14036 Override MarkForDuplicationCheck where it is appropriate.
14038 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
14039 It says whether container allows members with the same name.
14040 Base default is no.
14041 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
14042 Removed is_method parameter.
14044 2005-01-06 Duncan Mak <duncan@ximian.com>
14046 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
14047 because the previous change led to incorrect reporting of CS1032
14048 ("Cannot define/undefine preprocessor symbols after first token in
14049 file"). Instead of using `tokens_seen' as the only flag that
14050 triggers CS1040, introduce `comments_seen'. This new flag is used
14051 to signify having seen comments on the current line, so it is
14052 unset after a newline.
14054 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14056 * doc.cs : When searching for a type, find nested type too.
14057 This fixes bug #71040.
14059 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14062 - Warn missing member comment on those classes which also does not
14063 have doc comments. Fixed bug #71041.
14064 - Don't warn missing doc comment on default constructor.
14067 2005-01-06 Duncan Mak <duncan@ximian.com>
14069 * cs-tokenizer.cs (xtoken): After handling traditional C-style
14070 comments, set `tokens_seen' to true. This allows us to detect
14071 misplaced preprocessor directives (i.e. not at the beginning of
14072 the a line, nor after whitespaces). In that case, report error
14073 CS1040. This fixes bug #56460.
14075 * cs-parser.jay (interface_member_declaration): Add checks for
14076 IsExplicitImpl, and report CS0541 error if an interface member is
14077 defined as an explicit interface declaration.
14079 2005-01-06 Marek Safar <marek.safar@seznam.cz>
14082 * class.cs (PropertyMethod): Set Parent field in ctors.
14083 (SetMethod.InternalParameters): Add unsafe switch hack.
14085 * decl.cs (MemberCore.Parent): Cannot be readonly.
14087 2005-01-06 Raja R Harinath <rharinath@novell.com>
14089 * decl.cs (DeclSpace.ResolveType): Remove.
14090 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
14091 Merge in code from ...
14092 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
14093 * class.cs, enum.cs: Update to changes.
14095 2005-01-06 Miguel de Icaza <miguel@ximian.com>
14097 * anonymous.cs: Ensure that we init the scope of our parent if it
14098 has not been initialized yet.
14100 2004-12-30 Duncan Mak <duncan@ximian.com>
14102 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
14103 if field.FieldBuilder is null. Fixes #70758.
14105 * convert.cs: Fixed some typos and updated some of the comments.
14106 (ImplicitStandardConversionExists):
14107 (TryImplicitIntConversion): If `target_type' is an interface and
14108 the type of `ic' implements this interface, return true or a new
14109 BoxedCast instead of null. This fixes #70468.
14111 2004-12-29 Duncan Mak <duncan@ximian.com>
14113 * expression.cs (Argument.Emit): Check that Expr is
14114 IMemoryLocation before casting to it, and report CS1510 otherwise.
14118 2004-12-21 Ben Maurer <bmaurer@ximian.com>
14120 * statement.cs (Block.ThisVariable): remove the recursion here, to
14121 make the --profile more sane.
14123 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
14125 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
14126 assembly, by JB Evain.
14128 2004-12-17 Raja R Harinath <rharinath@novell.com>
14130 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
14131 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
14132 "parent" refers to enclosing type/class. "base" refers to superclass.
14134 2004-12-17 Raja R Harinath <rharinath@novell.com>
14136 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14137 Ensure that we only have GlobalAttributes.
14138 * attribute.cs (Attribute.Emit): Make non-virtual.
14139 (GlobalAttribute.Emit): Remove.
14140 (Attribute.Resolve): Make virtual.
14141 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
14142 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
14143 the argument. Don't create one.
14144 (Attribute.GetObsoleteAttribute): Likewise.
14145 (Attribute.GetClsCompliantAttributeValue): Likewise.
14146 * class.cs, decl.cs: Update to changes.
14148 2004-12-17 Marek Safar <marek.safar@seznam.cz>
14150 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
14152 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
14154 * statement.cs (Foreach.Resolve): Add error 186 report.
14156 2004-12-16 Marek Safar <marek.safar@seznam.cz>
14158 * expression.cs (Conditional.DoResolve): Add warning 429.
14160 * statement.cs (If.Resolve): Add warning 665.
14162 2004-12-16 Raja R Harinath <rharinath@novell.com>
14164 New invariant: RootContext.Tree.Types.NamespaceEntry == null
14165 except when in the parser, and in GlobalAttribute.
14166 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
14167 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
14168 RootContext.Tree.Types.NamespaceEntry once work is done.
14169 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
14170 and resets RootContext.Tree.Types.NamespaceEntry.
14172 2004-12-15 Marek Safar <marek.safar@seznam.cz>
14174 * cs-parser.jay: Don't create a block for every variable.
14176 2004-12-14 Miguel de Icaza <miguel@ximian.com>
14178 * location.cs: Provide extra information.
14180 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
14181 variables from the captured environment, it is the ldarg_0.
14183 2004-12-14 Marek Safar <marek.safar@seznam.cz>
14185 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
14188 * class.cs: Changed warning level for 169 to avoid developer
14189 displeasure from warning flooding. It will be changed back when they
14190 fix most of current BCL warnings.
14192 * RootContext.cs: Pushed default WarningLevel to 3.
14194 * statement.cs: Removed unused variable.
14196 2004-12-14 Marek Safar <marek.safar@seznam.cz>
14198 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
14199 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
14200 Add error 502 report.
14201 (StaticClass.DefineType): Add error 441 report.
14202 (Class.AllowedModifiersProp): New virtual property as temporary
14203 extension to AllowedModifiers.
14204 (Class.DefineType): Add error 418 report. Moved ModFlags check here
14205 to share implementation with StaticClass and don't call virtual
14208 * driver.cs (MainDriver): Add error 1558 test.
14210 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
14211 report. Moved error 36 test here.
14213 * statement.cs (Throw.Resolve): Add error 724 report.
14215 * typemanager.cs: Add out_attribute_type core type.
14217 2004-12-13 Marek Safar <marek.safar@seznam.cz>
14219 * class.cs (TypeContainer.VerifyClsCompliance): Add error
14221 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
14223 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
14226 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
14228 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
14229 Add error 3023 report.
14230 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
14232 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
14235 2004-12-12 John Luke <john.luke@gmail.com>
14237 * driver.cs (AddArgs): take -- into account when
14238 adding arguments, fixes bug 65710
14240 2004-12-12 Martin Baulig <martin@ximian.com>
14242 * expression.cs (Unary.TryReduceNegative): Added support for
14243 SByteConstant and ByteConstant.
14244 (Unary.Reduce): Check error values from TryReduceNegative().
14246 2004-12-10 Marek Safar <marek.safar@seznam.cz>
14248 * attributes.cs (Attribute.Resolve): Avoid multiple error report
14249 and report exception as error 182.
14251 2004-12-10 Raja R Harinath <rharinath@novell.com>
14253 * driver.cs (Main): Fix message when there are warnings.
14255 2004-12-09 Miguel de Icaza <miguel@ximian.com>
14257 * delegate.cs: Fixed my fix from yesterday, sorry about that.
14259 2004-12-09 Marek Safar <marek.safar@seznam.cz>
14261 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
14262 Reduced number of warnings.
14264 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
14266 2004-12-08 Miguel de Icaza <miguel@ximian.com>
14268 * driver.cs: Removed message.
14270 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
14272 2004-12-08 <vargaz@freemail.hu>
14274 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
14276 2004-12-08 Martin Baulig <martin@ximian.com>
14278 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
14279 instead of a CS3002 for properties and indexer.
14281 2004-12-08 Martin Baulig <martin@ximian.com>
14283 * decl.cs (MemberName.ToString): Make this work again.
14285 2004-12-08 Marek Safar <marek.safar@seznam.cz>
14287 * attribute.cs (Resolve): Add error 591 detection.
14289 * class.cs (FieldMember.Define): Add error 1547 detection.
14290 (Indexer.Define): Add error 620 detection.
14291 (Operator.Define): Add error 590 detection.
14293 * ecore.cs: Missing argument for error 79.
14295 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
14298 2004-12-07 Marek Safar <marek.safar@seznam.cz>
14301 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
14304 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
14306 * cs-parser.jay : handle doc comments on implicit/explicit operators.
14307 Some operator comments were suppressed.
14308 * doc.cs : Implicit/explicit operator name in doc comments are like
14309 "op_Explicit(type)~returnType", so added suffix handling.
14311 2004-12-07 Martin Baulig <martin@ximian.com>
14314 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
14315 (MemberCore.GetClsCompliantAttributeValue): Likewise.
14316 (DeclSpace.ec): New protected field; store the EmitContext here.
14317 (DeclSpace.EmitContext): New public property; moved here from
14319 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
14322 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
14323 (Enum.Emit): Don't create a new EmitContext.
14325 * delegate.cs (Delegate.DefineType): Always create the
14328 * iterators.cs (Iterators.DefineIterator): Create a new
14329 EmitContext and store it in `ec'.
14331 2004-08-24 Martin Baulig <martin@ximian.com>
14334 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
14335 this for accessibility checks.
14336 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
14337 IsNestedFamilyAccessible.
14338 (TypeManager.IsSubclassOf): New method, do what the name actually
14341 2004-12-06 Raja R Harinath <rharinath@novell.com>
14343 Fix crash on cs0657-17.cs.
14344 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14345 Use RootContext.Tree.Types, not 'new RootTypes ()'.
14346 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
14347 the case where the NamespaceEntry gets overwritten.
14349 2004-12-06 Marek Safar <marek.safar@seznam.cz>
14351 Fixed #69195, #56821
14352 * ecore.cs (ResolveBoolean): Tiny refactoring.
14354 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
14355 of right expression resolving when left is false constant and
14356 operator is LogicalAnd OR true constant and operator is LogicalOr.
14358 * statement.cs (ResolveUnreachable): Always reports warning.
14360 2004-12-05 Miguel de Icaza <miguel@ximian.com>
14362 * class.cs: Distinguish between 1721 and 1722 (just a little help
14363 for the programmer).
14365 2004-12-03 Miguel de Icaza <miguel@ximian.com>
14367 * delegate.cs: Only allow this on new versions of the language.
14369 2004-12-02 Duncan Mak <duncan@ximian.com>
14371 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
14373 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
14374 here as a static method. Take an additional bool out parameter
14375 `must_do_cs1540_check' for signaling to InstanceResolve.
14376 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
14377 member field from PropertyExpr class and made it an argument of
14378 the method instead.
14379 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
14380 check for MarshalByRefObject, and report CS0122 instead of CS1540.
14381 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
14382 and `remove_accessor' as well as InstanceResolve: report CS0122
14387 2004-12-03 Raja R Harinath <rharinath@novell.com>
14389 Fix test-327.cs, test-328.cs, and put in early infrastructure
14390 for eventually fixing #52697.
14391 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
14392 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
14393 from other methods.
14394 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
14395 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
14396 (VerifyUsing, error246): Update.
14397 * rootcontext.cs (RootContext.NamespaceLookup): Just use
14398 'NamespaceEntry.LookupNamespaceOrType'.
14400 2004-12-03 Martin Baulig <martin@ximian.com>
14402 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
14403 method as our child, call AnonymousMethod.Compatible() on it.
14405 2004-12-03 Raja R Harinath <rharinath@novell.com>
14407 Disable XML documentation support in 'basic' profile.
14408 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
14409 Redirect XmlElement to System.Object.
14410 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
14411 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
14412 * mcs.exe.sources: Add doc-bootstrap.cs.
14413 * doc-bootstrap.cs: New file. Contains empty stub implementation
14416 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
14418 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
14419 comments are allowed.
14421 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
14423 * delegate.cs: Add checks for subtypes in paramaters and return values
14424 in VerifyMethod () to add support for Covariance/Contravariance
14427 2004-12-02 Miguel de Icaza <miguel@ximian.com>
14429 * report.cs: Remove extra closing parenthesis.
14431 * convert.cs (Error_CannotImplicitConversion): If the name of the
14432 types are the same, provide some extra information.
14434 * class.cs (FieldBase): Use an unused bit field from the field to
14435 encode the `has_offset' property from the FieldMember. This saves
14436 a couple of Ks on bootstrap compilation.
14438 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
14439 method as our child, return the AnonymousMethod resolved
14442 * expression.cs (New.DoResolve): Allow return values from
14443 NewDelegate to also include AnonymousMethods.
14447 2004-12-02 Marek Safar <marek.safar@seznam.cz>
14450 * attribute.cs (Resolve): Improved implementation of params
14451 attribute arguments.
14453 * support.cs (ParameterData): Add HasParams to be faster.
14455 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
14457 all things are for /doc support:
14459 * doc.cs: new file that supports XML documentation generation.
14460 * mcs.exe.sources: added doc.cs.
14462 Handle /doc command line option.
14463 Report error 2006 instead of 5 for missing file name for /doc.
14464 Generate XML documentation when required, after type resolution.
14466 Added support for picking up documentation (/// and /** ... */),
14467 including a new XmlCommentState enumeration.
14469 Added lines to fill Documentation element for field, constant,
14470 property, indexer, method, constructor, destructor, operator, event
14471 and class, struct, interface, delegate, enum.
14472 Added lines to warn incorrect comment.
14474 Added Documentation field (passed only when /doc was specified).
14476 Added DocComment, DocCommentHeader, GenerateDocComment() and
14477 OnGenerateDocComment() and some supporting private members for
14478 /doc feature to MemberCore.
14480 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
14482 Added overriden DocCommentHeader.
14484 Added overriden DocCommentHeader and GenerateDocComment().
14486 2004-12-01 Miguel de Icaza <miguel@ximian.com>
14488 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
14489 unwrapping the enumeration values, chain to
14490 DoConstantNumericPromotions again, so we can promote things to the
14491 fundamental types (takes care of enums that are bytes, sbytes).
14495 2004-12-01 Raja R Harinath <rharinath@novell.com>
14497 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
14498 Fix long-standing bug in type-lookup. Use FindType instead of
14499 LookupType when ec.ResolvingTypeTree.
14500 (Attribute.ResolveType, Attribute.Resolve)
14501 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
14503 (Attributes.Search): Remove internal version. Update.
14504 (Attributes.SearchMulti): Update.
14505 (Attributes.GetClsCompliantAttribute): Remove.
14506 (Attributes.GetIndexerNameAttribute): Remove.
14507 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
14508 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
14509 * class.cs (Indexer.Define): Likewise.
14511 2004-12-01 Marek Safar <marek.safar@seznam.cz>
14514 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
14515 MarshallByReference members access.
14517 * expression.cs: Use CheckMarshallByRefAccess;
14518 Better error CS0197 message.
14520 * report.cs: Print whole related error message.
14522 2004-11-30 Raja R Harinath <rharinath@novell.com>
14524 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
14525 the current directory to help debugging.
14527 2004-11-29 Marek Safar <marek.safar@seznam.cz>
14529 * class (GetClassBases): Better error 60 report.
14530 (EventProperty): Disabled warning 67 detection.
14532 2004-11-29 Marek Safar <marek.safar@seznam.cz>
14535 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
14537 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
14540 2004-11-29 Marek Safar <marek.safar@seznam.cz>
14543 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
14545 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
14547 2004-11-26 Miguel de Icaza <miguel@ximian.com>
14549 * attribute.cs (Attribute.Resolve): Refine error reporting and
14550 report a cs0117 if the identifier does not exist, to distinguish
14551 from 0617 which is a miss-use of the actual identifier.
14553 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
14554 between cs0070 and cs0079.
14556 * class.cs (MemberBase.DoDefine): When reporting a wrong
14557 accessibility level, we use MethodCore to compare instead of
14558 Method (this was a regression in some refactoring effort).
14560 So now we correctly report cs0056 again.
14562 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
14563 testing the target_type (which was known to be object_type) and
14564 not the source type (which is anonymous_method).
14566 Fixed reporting of error cs1660.
14568 * expression.cs (UserCast.Source): Expose the underlying cast.
14570 * statement.cs (Switch.SwitchGoverningType): Sort the list of
14571 allowed types to find a match to int32 first (most common).
14573 In addition, it ignores any ImplicitUserConversions that did an
14574 internal implicit conversion (as the switch statement allows only
14575 one integral conversion to exist).
14577 * class.cs (PartialContainer.Create): rename `name' to
14578 `member_name' for clarity. Then replace the string calls with a
14579 call to MemberName.GetPartialName, as now using
14580 MemberName.ToString is an error (this is due to the side effects
14581 it had, that were fixed in the past).
14583 This will restore the error reporting on a number of partial class
14584 errors that were missusing this (and getting an exception as a
14585 results, which is now just a plain textual warning, because
14586 yyparse debug output would crash otherwise).
14588 2004-11-26 Raja R Harinath <rharinath@novell.com>
14590 * Makefile (PROGRAM_INSTALL_DIR): Remove.
14592 2004-11-25 Ben Maurer <bmaurer@ximian.com>
14594 * rootcontext.cs (LookupType): Make sure to cache lookups that
14595 don't give us a negative result. This saves about 5% of corlib
14598 2004-11-25 Miguel de Icaza <miguel@ximian.com>
14600 * report.cs (AbstractMessage.Print): messages are sent to stderr
14602 * class.cs (TypeContainer.GetClassBases): It is an error to have a
14603 non-interface in the list of interfaces (at this point, either
14604 parent was properly set, or a base class is being listed in the
14605 interfaces section).
14607 This flags error 1722, and resolves the crash from bug 69259.
14609 2004-11-25 Ben Maurer <bmaurer@ximian.com>
14611 * statement.cs (Using.EmitExpressionFinally): make this work right
14612 for valuetypes. Fixes 69926.
14614 2004-11-25 Miguel de Icaza <miguel@ximian.com>
14616 * const.cs (Const.ChangeType): Cope with the "0 literal can be
14617 converted to an enum" here, before we try to change the underlying
14618 type. This code exists, but it is a different code path than the
14619 one used while encoding constants.
14621 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
14622 old bug: when converting from the null literal to a pointer,
14623 return an EmptyCast, not the NullLiteral.
14625 This fixes #69921, the recent null_type changes probably made this
14626 bug more prominent.
14628 (ImplicitReferenceConversionExists): In addition, resynchronized
14629 the code here, so it matches the same code in
14630 ImplicitReferenceConversionExists for the `from any class-type S
14631 to any interface-type T'.
14634 2004-11-25 Marek Safar <marek.safar@seznam.cz>
14636 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
14638 2004-11-24 Miguel de Icaza <miguel@ximian.com>
14640 * cs-parser.jay: Use verbosity accordingly.
14642 2004-11-24 Marek Safar <marek.safar@seznam.cz>
14644 * expression.cs (Unary.ResolveOperator): Do not report warning;
14645 AddressOf reads from variable.
14647 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
14649 2004-11-24 Marek Safar <marek.safar@seznam.cz>
14653 * attribute.cs (Attributable): Removed CheckTargets.
14654 (Attributes.Emit): Explicit attribute targets are tested here.
14656 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
14657 not enabled for interfaces.
14659 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
14660 (GetAssemblyName): Ouch next bug there.
14662 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
14664 * expression.cs: Error 275 added.
14666 2004-11-23 Marek Safar <marek.safar@seznam.cz>
14668 Fix bug #69177 (Implemented decimal constant support)
14670 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
14671 (BinaryFold): Add DecimalConstant.
14673 * const.cs (Define): Decimal constant
14675 (ChangeType): Add decimal type handling.
14676 (LookupConstantValue): Don't set value for decimal type but
14677 emit DecimalConstantAttribute. Needed for constant optimization.
14679 * constant.cs (ToDecimal): New method.
14680 (ConvertToDecimal): New method.
14681 (IntConstant): Implemented ConvertToDecimal.
14682 (DecimalConstant.Emit): Emit optimized version for decimals in
14685 * expression.cs (ResolveOperator): Changed order of constant
14686 reduction to work correctly with native types which have
14687 overloaded operators.
14688 (ResolveMemberAccess): Extract constant value from attribute
14691 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
14693 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
14694 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
14695 (ChangeType): Decimal is special.
14696 (TypeToCoreType): Add decimal type.
14698 2004-11-22 Marek Safar <marek.safar@seznam.cz>
14700 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
14703 2004-11-22 Marek Safar <marek.safar@seznam.cz>
14705 * class.cs (EventField.ApplyAttributeBuilder): Fix error
14708 2004-11-19 Marek Safar <marek.safar@seznam.cz>
14710 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
14712 * pending.cs (PendingImplementation): Grab only interfaces.
14714 2004-11-19 Marek Safar <marek.safar@seznam.cz>
14716 * statement.cs (ForeachHelperMethods): Add location member and
14717 error 202 detection.
14719 2004-11-19 Raja R Harinath <rharinath@novell.com>
14721 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
14722 automatically handled by executable.make.
14723 (PROGRAM): Make profile-specific.
14725 2004-11-18 Marek Safar <marek.safar@seznam.cz>
14727 * expression.cs (DoResolveBase): Fixed wrong warning for out
14730 2004-11-18 Martin Baulig <martin@ximian.com>
14732 Merged latest changes into gmcs. Please keep this comment in
14733 here, it makes it easier for me to see what changed in MCS since
14734 the last time I merged.
14736 2004-11-17 Raja R Harinath <rharinath@novell.com>
14738 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
14739 (TypeHandle.GetMemberCache): New.
14740 (TypeHandle.TypeHandle): Update.
14741 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
14742 (TypeManager.LookupParentInterfacesCache):
14743 Rename from LookupInterfaceCache. Optimize slightly.
14744 (TypeManager.MemberLookup_FindMembers): Update.
14745 * decl.cs (MemberCache.MemberCache): Set Container to null in the
14746 multi-type variant.
14747 (AddCacheContents): Rename from AddHashtable.
14748 * class.cs (TypeContainer.parent_container): Remove.
14749 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
14750 (TypeContainer.DoDefineMembers): Don't initialize it.
14751 Update to name changes.
14753 2004-11-17 Miguel de Icaza <miguel@ximian.com>
14755 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
14756 that factors the code to check access modifiers on override.
14758 (PropertyBase): Use the code here.
14760 Patch from Lluis S'anchez, fixes bug #69361.
14762 2004-11-15 Miguel de Icaza <miguel@ximian.com>
14764 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
14765 routine that is used to report the use of a captured variable
14766 whose address has been taken.
14768 There are two checks: one when variables are being captured and
14769 the other check is when the address of a variable is taken.
14771 (because an anonymous methods might be resolved before *or* after
14772 the address has been taken) and
14774 * expression.cs (Conditional.DoResolve): Remove the special
14775 casing that Martin added to trueExpr and falseExpr being both
14776 NullLiteral. We get the right behavior now just by introducing
14777 the null_type into the compiler.
14779 * convert.cs (ExplicitConversion): Change the code to use
14780 null_type instead of testing `expr is NullLiteral'.
14781 (ImplicitConversionStandard): use null_type too.
14782 (ImplicitReferenceConversionExists): use null_type too.
14783 (ImplicitReferenceConversion): use null_type too.
14785 * literal.cs: The type of `NullLiteral' is now null_type instead
14787 (Resolve): Set the type here.
14789 * typemanager.cs: Introduce null_type.
14791 2004-11-17 Martin Baulig <martin@ximian.com>
14793 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
14794 direction, like FindMembers() does. Fixes #69546, testcase is in
14797 2004-11-16 Martin Baulig <martin@ximian.com>
14799 This is based on a patch from Marek Safar, see bug #69082.
14800 Fixes bugs #63705 and #67130.
14802 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
14803 method; create a MemberCache for an interface type and cache the
14806 * decl.cs (IMemberContainer.ParentContainer): Removed.
14807 (IMemberContainer.ParentCache): New property.
14808 (MemberCache.SetupCacheForInterface): Removed.
14809 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
14810 to create a cache for an interface's "parent".
14812 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
14815 2004-11-16 Martin Baulig <martin@ximian.com>
14817 Merged back from gmcs; these changes already went into gmcs a
14818 couple of weeks ago.
14821 (TypeManager.AddUserType): Removed the `ifaces' argument.
14822 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
14824 (TypeManager.AddUserInterface): Removed.
14825 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
14827 (TypeManager.GetInterfaces): Likewise.
14828 (TypeManager.GetExplicitInterfaces): Likewise.
14830 * ecore.cs (TypeExpr.GetInterfaces): Removed.
14832 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
14833 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
14835 2004-11-14 Ben Maurer <bmaurer@ximian.com>
14837 * statement.cs: Avoid adding bools to a hashtable.
14839 2004-11-07 Miguel de Icaza <miguel@ximian.com>
14841 * expression.cs (Invocation.OverloadResolve): Flag error if we are
14842 calling an unsafe method from a safe location.
14844 2004-11-06 Marek Safar <marek.safar@seznam.cz>
14847 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
14849 2004-11-06 Miguel de Icaza <miguel@ximian.com>
14851 * namespace.cs (VerifyUsing): use GetPartialName instead of
14854 2004-11-05 Miguel de Icaza <miguel@ximian.com>
14856 * statement.cs (Return.Resolve): Fix regression in typo: if
14857 `in_exc', we have to request a NeedReturnLabel, this was a typo
14858 introduced in the anonymous method check-in. Fixes #69131.
14860 * Indexers were using the ShortName when defining themselves,
14861 causing a regression in the compiler bootstrap when applying the
14862 patch from 2004-11-02 (first part), now they use their full name
14863 and the bug is gone.
14865 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
14867 * driver.cs: Strip the path from the names of embedded resources. Fixes
14870 2004-11-04 Raja R Harinath <rharinath@novell.com>
14872 Fix error message regression: cs0104-2.cs.
14873 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
14874 (AliasEntry.Resolve): Update.
14875 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
14877 (RootContext.LookupType): Update.
14879 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
14881 * cs-parser.jay: Add support for handling accessor modifiers
14882 * class: Add support port accessor modifiers and error checking,
14883 define PropertyMethod.Define as virtual (not abstract anymore)
14884 * ecore.cs: Add checking for proeprties access with access modifiers
14885 * iterators.cs: Modify Accessor constructor call based in the modified
14887 2004-11-02 Ben Maurer <bmaurer@ximian.com>
14889 * expression.cs (StringConcat): Handle being called twice,
14890 as when we have a concat in a field init with more than two
14893 2004-11-02 Miguel de Icaza <miguel@ximian.com>
14895 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
14896 special case explicit implementations, we should always produce
14897 the .property or .event declaration.
14899 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
14900 since it will not return correct data if people use this
14901 unresolved in the presence of using statements (see test-313).
14903 * class.cs (MethodData.Define): If we are an explicit interface
14904 implementation, set the method name to the full name of the
14905 interface plus the name of the method.
14907 Notice that using the method.MethodName.GetFullName() does not
14908 work, as it will only contain the name as declared on the source
14909 file (it can be a shorthand in the presence of using statements)
14910 and not the fully qualifed type name, for example:
14914 class D : ICloneable {
14915 object ICloneable.Clone () {
14919 Would produce a method called `ICloneable.Clone' instead of
14920 `System.ICloneable.Clone'.
14922 * namespace.cs (Alias.Resolve): Use GetPartialName.
14924 2004-11-01 Marek Safar <marek.safar@seznam.cz>
14926 * cs-parser.jay: Add error 1055 report.
14928 2004-11-01 Miguel de Icaza <miguel@ximian.com>
14930 * assign.cs (Assign.DoResolve): Only do the transform of
14931 assignment into a New if the types are compatible, if not, fall
14932 through and let the implicit code deal with the errors and with
14933 the necessary conversions.
14935 2004-11-01 Marek Safar <marek.safar@seznam.cz>
14937 * cs-parser.jay: Add error 1031 report.
14939 * cs-tokenizer.cs: Add location for error 1038.
14941 2004-10-31 Marek Safar <marek.safar@seznam.cz>
14943 * cs-parser.jay: Add error 1016 report.
14945 2004-10-31 Marek Safar <marek.safar@seznam.cz>
14947 * cs-parser.jay: Add errors 1575,1611 report.
14949 2004-10-31 Marek Safar <marek.safar@seznam.cz>
14951 * cs-parser.jay: Add error 1001 report.
14953 2004-10-31 Marek Safar <marek.safar@seznam.cz>
14956 * attribute.cs (GetMarshal): Add method argument for
14957 caller identification.
14959 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
14960 agument for GetMarshal and RuntimeMissingSupport.
14962 2004-10-31 Marek Safar <marek.safar@seznam.cz>
14964 * attribute.cs (ExtractSecurityPermissionSet): Removed
14965 TypeManager.code_access_permission_type.
14967 * typemanager.cs: Removed TypeManager.code_access_permission_type.
14969 2004-10-27 Miguel de Icaza <miguel@ximian.com>
14971 * expression.cs (LocalVariableReference.DoResolveLValue): Check
14972 for obsolete use of a variable here. Fixes regression on errors
14973 cs0619-25 and cs0619-26.
14975 2004-10-27 Marek Safar <marek.safar@seznam.cz>
14977 Fix #62358, implemented security attribute encoding.
14979 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
14980 Tests permitted SecurityAction for assembly or other types.
14981 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
14982 data from SecurityPermissionAttribute to PermisionSet class.
14984 * class.cs (ApplyAttributeBuilder): Added special handling
14985 for System.Security.Permissions.SecurityAttribute based types.
14987 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
14988 special handling for System.Security.Permissions.SecurityAttribute
14991 * enum.cs (ApplyAttributeBuilder): Added special handling
14992 for System.Security.Permissions.SecurityAttribute based types.
14994 * parameter.cs (ApplyAttributeBuilder): Added special handling
14995 for System.Security.Permissions.SecurityAttribute based types.
14997 * rootcontext.cs: Next 2 core types.
14999 * typemanager.cs (TypeManager.security_permission_attr_type):
15000 Built in type for the SecurityPermission Attribute.
15001 (code_access_permission_type): Build in type.
15003 2004-10-17 Miguel de Icaza <miguel@ximian.com>
15005 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
15006 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
15007 all of this information into
15008 EmitContext.EmitCapturedVariableInstance.
15010 * codegen.cs (EmitCapturedVariableInstance): move here the
15011 funcionality of emitting an ldarg.0 in the presence of a
15012 remapping. This centralizes the instance emit code.
15014 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
15015 then emit a load of this: it means that we have reached the
15016 topmost ScopeInfo: the one that contains the pointer to the
15017 instance of the class hosting the anonymous method.
15019 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
15020 captures to the topmost CaptureContext.
15022 2004-10-12 Miguel de Icaza <miguel@ximian.com>
15024 * expression.cs (LocalVariableReference): Move the knowledge about
15025 the iterators into codegen's EmitCapturedVariableInstance.
15027 2004-10-11 Miguel de Icaza <miguel@ximian.com>
15029 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
15030 all code paths return a value from an anonymous method (it is the
15031 same as the 161 error, but for anonymous methods).
15033 2004-10-08 Miguel de Icaza <miguel@ximian.com>
15035 The introduction of anonymous methods in the compiler changed
15036 various ways of doing things in the compiler. The most
15037 significant one is the hard split between the resolution phase
15038 and the emission phases of the compiler.
15040 For instance, routines that referenced local variables no
15041 longer can safely create temporary variables during the
15042 resolution phase: they must do so from the emission phase,
15043 since the variable might have been "captured", hence access to
15044 it can not be done with the local-variable operations from the runtime.
15048 (Block.Flags): New flag `IsTopLevel' to indicate that this block
15049 is a toplevel block.
15051 (ToplevelBlock): A new kind of Block, these are the blocks that
15052 are created by the parser for all toplevel method bodies. These
15053 include methods, accessors and anonymous methods.
15055 These contain some extra information not found in regular blocks:
15056 A pointer to an optional CaptureContext (for tracking captured
15057 local variables and parameters). A pointer to the parent
15060 (Return.Resolve): Catch missmatches when returning a value from an
15061 anonymous method (error 1662).
15062 Invoke NeedReturnLabel from the Resolve phase instead of the emit
15065 (Break.Resolve): ditto.
15067 (SwitchLabel): instead of defining the labels during the
15068 resolution phase, we now turned the public ILLabel and ILLabelCode
15069 labels into methods called GetILLabelCode() and GetILLabel() that
15070 only define the label during the Emit phase.
15072 (GotoCase): Track the SwitchLabel instead of the computed label
15073 (its contained therein). Emit the code by using
15074 SwitchLabel.GetILLabelCode ().
15076 (LocalInfo.Flags.Captured): A new flag has been introduce to track
15077 whether the Local has been captured or not.
15079 (LocalInfo.IsCaptured): New property, used to tell whether the
15080 local has been captured.
15082 * anonymous.cs: Vastly updated to contain the anonymous method
15085 The main classes here are: CaptureContext which tracks any
15086 captured information for a toplevel block and ScopeInfo used to
15087 track the activation frames for various local variables.
15089 Each toplevel block has an optional capture context associated
15090 with it. When a method contains an anonymous method both the
15091 toplevel method and the anonymous method will create a capture
15092 context. When variables or parameters are captured, they are
15093 recorded on the CaptureContext that owns them, for example:
15097 MyDelegate d = delegate {
15102 Here `a' will be recorded as captured on the toplevel
15103 CapturedContext, the inner captured context will not have anything
15104 (it will only have data if local variables or parameters from it
15105 are captured in a nested anonymous method.
15107 The ScopeInfo is used to track the activation frames for local
15108 variables, for example:
15110 for (int i = 0; i < 10; i++)
15111 for (int j = 0; j < 10; j++){
15112 MyDelegate d = delegate {
15117 At runtime this captures a single captured variable `i', but it
15118 captures 10 different versions of the variable `j'. The variable
15119 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
15120 recorded on a child.
15122 The toplevel ScopeInfo will also track information like the `this'
15123 pointer if instance variables were referenced (this is necessary
15124 as the anonymous method lives inside a nested class in the host
15125 type of the method).
15127 (AnonymousMethod): Expanded to track the Toplevel, implement
15128 `AnonymousMethod.Compatible' to tell whether an anonymous method
15129 can be converted to a target delegate type.
15131 The routine now also produces the anonymous method content
15133 (AnonymousDelegate): A helper class that derives from
15134 DelegateCreation, this is used to generate the code necessary to
15135 produce the delegate for the anonymous method that was created.
15137 * assign.cs: API adjustments for new changes in
15138 Convert.ImplicitStandardConversionExists.
15140 * class.cs: Adjustments to cope with the fact that now toplevel
15141 blocks are of type `ToplevelBlock'.
15143 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
15144 insteda of standard blocks.
15146 Flag errors if params arguments are passed to anonymous methods.
15148 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
15149 `CurrentAnonymousMethod' which points to the current Anonymous
15150 Method. The variable points to the AnonymousMethod class that
15151 holds the code being compiled. It is set in the new EmitContext
15152 created for the anonymous method.
15154 (EmitContext.Phase): Introduce a variable and an enumeration to
15155 assist in enforcing some rules about when and where we are allowed
15156 to invoke certain methods (EmitContext.NeedsReturnLabel is the
15157 only one that enfonces this right now).
15159 (EmitContext.HaveCaptureInfo): new helper method that returns
15160 whether we have a CapturedContext initialized.
15162 (EmitContext.CaptureVariable): New method used to register that a
15163 LocalInfo must be flagged for capturing.
15165 (EmitContext.CapturedParameter): New method used to register that a
15166 parameters must be flagged for capturing.
15168 (EmitContext.CapturedField): New method used to register that a
15169 field must be flagged for capturing.
15171 (EmitContext.HaveCapturedVariables,
15172 EmitContext.HaveCapturedFields): Return whether there are captured
15173 variables or fields.
15175 (EmitContext.EmitMethodHostInstance): This is used to emit the
15176 instance for the anonymous method. The instance might be null
15177 (static methods), this (for anonymous methods that capture nothing
15178 and happen to live side-by-side with the current method body) or a
15179 more complicated expression if the method has a CaptureContext.
15181 (EmitContext.EmitTopBlock): Routine that drives the emission of
15182 code: it will first resolve the top block, then emit any metadata
15183 and then emit the code. The split is done so that we can extract
15184 any anonymous methods and flag any captured variables/parameters.
15186 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
15187 during this phase, the ILGenerator should not be used as labels
15188 and local variables declared here might not be accessible to any
15189 code that is part of an anonymous method.
15191 Exceptions to this include the temporary variables that are
15192 created by some statements internally for holding temporary
15195 (EmitContext.EmitMeta): New routine, in charge of emitting all the
15198 (EmitContext.TemporaryReturn): This method is typically called
15199 from the Emit phase, and its the only place where we allow the
15200 ReturnLabel to be defined other than the EmitMeta. The reason is
15201 that otherwise we would have to duplicate a lot of logic in the
15202 Resolve phases of various methods that today is on the Emit
15205 (EmitContext.NeedReturnLabel): This no longer creates the label,
15206 as the ILGenerator is not valid during the resolve phase.
15208 (EmitContext.EmitThis): Extended the knowledge in this class to
15209 work in anonymous methods in addition to iterators.
15211 (EmitContext.EmitCapturedVariableInstance): This emits whatever
15212 code is necessary on the stack to access the instance to a local
15213 variable (the variable will be accessed as a field).
15215 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
15216 EmitContext.EmitAddressOfParameter): Routines to support
15217 parameters (not completed at this point).
15219 Removals: Removed RemapLocal and RemapLocalLValue. We probably
15220 will also remove the parameters.
15222 * convert.cs (Convert): Define a `ConstantEC' which points to a
15223 null. This is just to prefity some code that uses
15224 ImplicitStandardConversion code and do not have an EmitContext
15227 The idea is to flag explicitly that at that point in time, it is
15228 known that the conversion will not trigger the delegate checking
15229 code in implicit conversions (which requires a valid
15232 Everywhere: pass new EmitContext parameter since
15233 ImplicitStandardConversionExists now requires it to check for
15234 anonymous method conversions.
15236 (Convert.ImplicitStandardConversionExists): If the type of an
15237 expression is the anonymous_method_type, and the type is a
15238 delegate, we invoke the AnonymousMethod.Compatible method to check
15239 whether an implicit conversion is possible.
15241 (Convert.ImplicitConversionStandard): Only do implicit method
15242 group conversions if the language level is not ISO_1.
15244 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
15245 MethodInfo for the Invoke method. used by Delegate and
15248 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
15249 method conversions if the target type is a delegate.
15251 Removed extra debugging nops.
15253 (LocalVariableReference): Turn the `local_info' into a public
15256 Add `prepared' field, the same hack used for FieldExprs to cope
15257 with composed assignments, as Local variables do not necessarily
15258 operate purely on the stack as they used to: they can be captured
15261 Add `temp' for a temporary result, like fields.
15263 Refactor DoResolve and DoResolveLValue into DoResolveBase.
15265 It now copes with Local variables that are captured and emits the
15266 proper instance variable to load it from a field in the captured
15269 (ParameterReference.DoResolveBase): During the resolve phase,
15270 capture parameters if we are in an anonymous method.
15272 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
15273 anonymous method, use the EmitContext helper routines to emit the
15274 parameter reference.
15276 * iterators.cs: Set RemapToProxy to true/false during the
15279 * parameters.cs (GetParameterByName): New helper method.
15281 * typemanager.cs (anonymous_method_type) a new type that
15282 represents an anonyous method. This is always an internal type,
15283 used as a fencepost to test against the anonymous-methodness of an
15286 2004-10-20 Marek Safar <marek.safar@seznam.cz>
15288 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
15290 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
15292 2004-10-18 Martin Baulig <martin@ximian.com>
15294 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
15295 `Type' directly, but call ResolveType() on it.
15296 (Catch.Resolve): Likewise.
15297 (Foreach.Resolve): Likewise.
15299 2004-10-18 Martin Baulig <martin@ximian.com>
15301 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
15302 `Type' directly, but call ResolveType() on it.
15303 (Probe.DoResolve): Likewise.
15304 (ArrayCreation.LookupType): Likewise.
15305 (TypeOf.DoResolve): Likewise.
15306 (SizeOf.DoResolve): Likewise.
15308 2004-10-18 Martin Baulig <martin@ximian.com>
15310 * expression.cs (Invocation.BetterFunction): Put back
15311 TypeManager.TypeToCoreType().
15313 2004-10-18 Raja R Harinath <rharinath@novell.com>
15315 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
15318 2004-10-18 Martin Baulig <martin@ximian.com>
15320 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
15321 `Type' directly, but call ResolveType() on it.
15323 2004-10-18 Martin Baulig <martin@ximian.com>
15325 * class.cs (FieldMember.Define): Don't access the TypeExpr's
15326 `Type' directly, but call ResolveType() on it.
15327 (MemberBase.DoDefine): Likewise.
15329 * expression.cs (New.DoResolve): Don't access the TypeExpr's
15330 `Type' directly, but call ResolveType() on it.
15331 (ComposedCast.DoResolveAsTypeStep): Likewise.
15333 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
15334 `Type' directly, but call ResolveType() on it.
15336 2004-10-17 John Luke <john.luke@gmail.com>
15338 * class.cs (Operator.GetSignatureForError): use CSharpName
15340 * parameter.cs (Parameter.GetSignatureForError): Returns
15341 correct name even if was not defined.
15343 2004-10-13 Raja R Harinath <rharinath@novell.com>
15346 * class.cs (TypeContainer.EmitContext): New property.
15347 (DefineNestedTypes): Create an emitcontext for each part.
15348 (MethodCore.DoDefineParameters): Use container's emitcontext.
15349 Pass type array to InternalParameters.
15350 (MemberBase.DoDefine): Use container's emitcontext.
15351 (FieldMember.Define): Likewise.
15352 (Event.Define): Likewise.
15353 (SetMethod.GetParameterInfo): Change argument to EmitContext.
15354 Pass type array to InternalParameters.
15355 (SetIndexerMethod.GetParameterInfo): Likewise.
15356 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
15357 * delegate.cs (Define): Pass emitcontext to
15358 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
15359 array to InternalParameters.
15360 * expression.cs (ParameterReference.DoResolveBase): Pass
15361 emitcontext to GetParameterInfo.
15362 (ComposedCast.DoResolveAsTypeStep): Remove check on
15363 ec.ResolvingTypeTree.
15364 * parameter.cs (Parameter.Resolve): Change argument to
15365 EmitContext. Use ResolveAsTypeTerminal.
15366 (Parameter.GetSignature): Change argument to EmitContext.
15367 (Parameters.ComputeSignature): Likewise.
15368 (Parameters.ComputeParameterTypes): Likewise.
15369 (Parameters.GetParameterInfo): Likewise.
15370 (Parameters.ComputeAndDefineParameterTypes): Likewise.
15371 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
15372 * support.cs (InternalParameters..ctor): Remove variant that takes
15374 * typemanager.cs (system_intptr_expr): New.
15375 (InitExpressionTypes): Initialize it.
15377 2004-10-12 Chris Toshok <toshok@ximian.com>
15379 * cs-parser.jay: fix location for try_statement and catch_clause.
15381 2004-10-11 Martin Baulig <martin@ximian.com>
15383 * report.cs: Don't make --fatal abort on warnings, we have
15384 -warnaserror for that.
15386 2004-10-07 Raja R Harinath <rharinath@novell.com>
15388 More DeclSpace.ResolveType avoidance.
15389 * decl.cs (MemberCore.InUnsafe): New property.
15390 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
15391 with newly created EmitContext.
15392 (FieldMember.Define): Likewise.
15393 * delegate.cs (Delegate.Define): Likewise.
15394 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
15395 only if normal name-lookup fails.
15396 (TypeExpr.DoResolve): Enable error-checking.
15397 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
15398 (SizeOf.DoResolve): Likewise.
15399 (ComposedCast.DoResolveAsTypeStep): Likewise.
15400 (StackAlloc.DoResolve): Likewise.
15401 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
15402 (Block.Unsafe): New property.
15403 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
15404 (Unsafe): Set 'unsafe' flag of contained block.
15405 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
15406 (Fixed.Resolve): Likewise.
15407 (Catch.Resolve): Likewise.
15408 (Using.ResolveLocalVariableDecls): Likewise.
15409 (Foreach.Resolve): Likewise.
15411 2004-10-05 John Luke <john.luke@gmail.com>
15413 * cs-parser.jay: add location to error CS0175
15415 2004-10-04 Miguel de Icaza <miguel@ximian.com>
15417 * ecore.cs (Expression.Constantity): Add support for turning null
15420 * const.cs (Const.Define): Allow constants to be reference types
15421 as long as the value is Null.
15423 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
15425 * namespace.cs (NamespaceEntry.Using): No matter which warning
15426 level is set, check if this namespace name has already been added.
15428 2004-10-03 Ben Maurer <bmaurer@ximian.com>
15430 * expression.cs: reftype [!=]= null should always use br[true,false].
15433 2004-10-03 Marek Safar <marek.safar@seznam.cz>
15436 * attribute.cs: Enum conversion moved to
15437 GetAttributeArgumentExpression to be applied to the all
15440 2004-10-01 Raja R Harinath <rharinath@novell.com>
15442 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
15443 * class.c (TypeContainer.DefineType): Flag error if
15444 base types aren't accessible due to access permissions.
15445 * decl.cs (DeclSpace.ResolveType): Move logic to
15446 Expression.ResolveAsTypeTerminal.
15447 (DeclSpace.ResolveTypeExpr): Thin layer over
15448 Expression.ResolveAsTypeTerminal.
15449 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
15450 Refactor code into NestedAccess. Use it.
15451 (DeclSpace.NestedAccess): New.
15452 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
15453 argument to silence errors. Check access permissions.
15454 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
15455 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
15456 (Cast.DoResolve): Likewise.
15457 (New.DoResolve): Likewise.
15458 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
15459 (TypeOf.DoResolve): Likewise.
15461 * expression.cs (Invocation.BetterConversion): Return the Type of
15462 the better conversion. Implement section 14.4.2.3 more faithfully.
15463 (Invocation.BetterFunction): Make boolean. Make correspondence to
15464 section 14.4.2.2 explicit.
15465 (Invocation.OverloadResolve): Update.
15466 (Invocation): Remove is_base field.
15467 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
15468 (Invocation.Emit): Likewise.
15470 2004-09-27 Raja R Harinath <rharinath@novell.com>
15472 * README: Update to changes.
15474 2004-09-24 Marek Safar <marek.safar@seznam.cz>
15476 * cs-parser.jay: Reverted 642 warning fix.
15478 2004-09-23 Marek Safar <marek.safar@seznam.cz>
15481 * decl.cs (FindMemberWithSameName): Indexer can have more than
15484 2004-09-23 Marek Safar <marek.safar@seznam.cz>
15486 * expression.cs (LocalVariableReference.DoResolveLValue):
15487 Do not report warning 219 for out values.
15488 (EmptyExpression.Null): New member to avoid extra allocations.
15490 2004-09-23 Marek Safar <marek.safar@seznam.cz>
15492 * cs-parser.jay: Fix wrong warning 642 report.
15494 * cs-tokenizer.cs (CheckNextToken): New helper;
15495 Inspect next character if is same as expected.
15497 2004-09-23 Martin Baulig <martin@ximian.com>
15499 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
15500 (Convert.ImplicitReferenceConversionExists): Likewise.
15502 2004-09-23 Marek Safar <marek.safar@seznam.cz>
15504 * class.cs (Operator.Define): Add error 448 and 559 report.
15506 2004-09-22 Marek Safar <marek.safar@seznam.cz>
15508 * class.cs (MemberBase.IsTypePermitted): New protected
15509 method for checking error CS0610.
15511 2004-09-22 Marek Safar <marek.safar@seznam.cz>
15513 * class.cs (TypeContainer.HasExplicitLayout): New property
15514 Returns whether container has StructLayout attribute set Explicit.
15515 (FieldMember): New abstract class for consts and fields.
15516 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
15517 (Field): Reuse FieldMember.
15519 * const.cs (Const): Reuse FieldMember.
15521 * rootcontext.cs: EmitConstants call moved to class.
15523 2004-09-22 Martin Baulig <martin@ximian.com>
15525 Thanks to Peter Sestoft for this bug report.
15527 * expression.cs (Conditional): If both the `trueExpr' and the
15528 `falseExpr' is a NullLiteral, return a NullLiteral.
15530 2004-09-22 Martin Baulig <martin@ximian.com>
15532 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
15533 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
15534 for the "get_Current" call.
15536 2004-09-22 Martin Baulig <martin@ximian.com>
15538 Marek and me just fixed one of our oldest bugs: #28562 :-)
15540 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
15542 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
15543 we're an EnumConstant, just return that.
15544 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
15545 an EnumConstant. In this case, we need to use GetValueAsEnumType()
15546 to get the value which'll actually be written into the attribute.
15547 However, we have to use GetValue() to access the attribute's value
15550 2004-09-22 Marek Safar <marek.safar@seznam.cz>
15552 * constant.cs (Constant.IsNegative): New abstract property
15555 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
15556 (StackAlloc.DoResolve): Reused IsNegative.
15558 2004-09-21 Martin Baulig <martin@ximian.com>
15560 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
15561 if we're used in an iterator, we may be called from different
15564 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
15565 we actually have an exception block.
15567 2004-09-20 John Luke <jluke@cfl.rr.com>
15569 * class.cs, cs-parser.jay: Improve the error report for 1520:
15570 report the actual line where the error happens, not where the
15571 class was declared.
15573 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
15574 Pass location information that was available elsewhere.
15576 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
15578 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
15579 runtime to delay sign assemblies.
15581 2004-09-19 Miguel de Icaza <miguel@ximian.com>
15583 * cs-parser.jay: Do not report the stack trace, this is barely
15586 2004-08-22 John Luke <john.luke@gmail.com>
15588 * driver.cs : check that a resource id is not already used
15589 before adding it, report CS1508 if it is, bug #63637
15591 2004-09-19 Miguel de Icaza <miguel@ximian.com>
15593 * ecore.cs: Removed dead code.
15595 2004-09-18 Marek Safar <marek.safar@seznam.cz>
15597 * class.cs: Do not report warning CS0067 on the interfaces.
15599 2004-09-16 Marek Safar <marek.safar@seznam.cz>
15601 * cs-parser.jay: Add error 504 report.
15603 2004-09-16 Marek Safar <marek.safar@seznam.cz>
15605 * rootcontext.cs: WarningLevel is 4 by default now.
15607 * statement.cs (Fixed.Resolve): Do not null
15610 2004-09-16 Marek Safar <marek.safar@seznam.cz>
15613 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
15614 deep search when property is not virtual.
15615 (PropertyExpr.ResolveAccessors): Make one call for both
15618 2004-09-15 Marek Safar <marek.safar@seznam.cz>
15621 * statement.cs: Error 152 report constains also location.
15623 2004-09-15 Marek Safar <marek.safar@seznam.cz>
15626 * const.cs: Explicitly set constant as static.
15628 2004-09-15 Marek Safar <marek.safar@seznam.cz>
15631 * cs-parser.jay: Add error 1017 report.
15633 2004-09-15 Marek Safar <marek.safar@seznam.cz>
15635 Fixed bug #59980, #64224
15636 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
15638 * typemanager.cs (IsSpecialMethod): Simplified
15640 2004-09-14 Marek Safar <marek.safar@seznam.cz>
15642 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
15643 condition with better params.
15645 2004-09-14 Marek Safar <marek.safar@seznam.cz>
15648 * attribute.cs (Resolve): Property has to have both
15651 2004-09-14 Martin Baulig <martin@ximian.com>
15653 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
15655 2004-09-14 Marek Safar <marek.safar@seznam.cz>
15658 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
15659 called and is obsolete then this member suppress message
15660 when call is inside next [Obsolete] method or type.
15662 * expression.cs: Use TestObsoleteMethodUsage member.
15664 2004-09-14 Martin Baulig <martin@ximian.com>
15666 * cs-parser.jay: Sync a bit with the GMCS version.
15668 2004-09-14 Martin Baulig <martin@ximian.com>
15670 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
15671 (CSharpParser.yacc_verbose_flag): New public field.
15673 * genericparser.cs: Removed.
15675 2004-09-14 Raja R Harinath <rharinath@novell.com>
15677 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
15679 2004-09-13 Marek Safar <marek.safar@seznam.cz>
15681 * class.cs (MethodCore.CheckBase): Fix bug #65757.
15683 2004-09-10 Martin Baulig <martin@ximian.com>
15685 Backported my MemberName changes from GMCS into MCS.
15687 - we are now using a special `MemberName' class instead of using
15688 strings; in GMCS, the `MemberName' also contains the type
15691 - changed the grammar rules a bit:
15692 * the old `member_name' is now a `namespace_or_type_name':
15693 The rule is that we use `namespace_or_type_name' everywhere
15694 where we expect either a "member name" (GetEnumerator) or a
15695 "member name" with an explicit interface name
15696 (IEnumerable.GetEnumerator).
15697 In GMCS, the explicit interface name may include type arguments
15698 (IEnumerable<T>.GetEnumerator).
15699 * we use `member_name' instead of just `IDENTIFIER' for
15701 The rule is that we use `member_name' wherever a member may
15702 have type parameters in GMCS.
15704 * decl.cs (MemberName): New public class.
15705 (MemberCore.MemberName): New public readonly field.
15706 (MemberCore.ctor): Take a `MemberName' argument, not a string.
15707 (DeclSpace): Likewise.
15709 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
15710 * enum.cs (Enum.ctor): Likewise.
15712 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
15714 (AliasEntry.ctor): Take a MemberName, not an Expression.
15715 (AliasEntry.UsingAlias): Likewise.
15717 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
15718 (IMethodData.MemberName): Changed type from string to MemberName.
15719 (MemberBase.ExplicitInterfaceName): Likewise.
15720 (AbstractPropertyEventMethod.SetupName): Make this private.
15721 (AbstractPropertyEventMethod.ctor): Added `string prefix'
15722 argument; compute the member name here.
15723 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
15724 on the `member.MemberName' and the `prefix'.
15726 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
15728 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
15729 thus, we get a `MemberName' instead of a `string'. These
15730 declarations may have type parameters in GMCS.
15731 (interface_method_declaration, delegate_declaration): Likewise.
15732 (class_declaration, interface_declaration): Likewise.
15733 (method_header): Use `namespace_or_type_name' instead of
15734 `member_name'. We may be an explicit interface implementation.
15735 (property_declaration, event_declaration): Likewise.
15736 (member_name): This is now just an `IDENTIFIER', not a
15737 `namespace_or_type_name'.
15738 (type_name, interface_type): Removed.
15739 (namespace_or_type_name): Return a MemberName, not an Expression.
15740 (primary_expression): Use `member_name' instead of `IDENTIFIER';
15741 call GetTypeExpression() on the MemberName to get an expression.
15742 (IndexerDeclaration.interface_type): Changed type from string to
15744 (MakeName): Operate on MemberName's instead of string's.
15746 2004-09-13 Raja R Harinath <rharinath@novell.com>
15749 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
15750 (NamespaceEntry.Lookup): Add new argument to flag if we want the
15751 lookup to avoid symbols introduced by 'using'.
15752 * rootcontext.cs (NamespaceLookup): Update.
15754 2004-09-12 Marek Safar <marek.safar@seznam.cz>
15756 * class.cs (TypeContainer.DoDefineMembers): Do not call
15757 DefineDefaultConstructor for static classes.
15759 2004-09-12 Marek Safar <marek.safar@seznam.cz>
15761 * attribute.cs (Attribute.Resolve): Add error 653 report.
15763 * class.cs (Class.ApplyAttributeBuilder): Add error 641
15765 (Method.ApplyAttributeBuilder): Add error 685 report.
15766 (Operator.Define): Add error 564 report.
15768 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
15770 * expression.cs (Invocation.DoResolve): Add error
15771 245 and 250 report.
15773 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
15776 2004-09-11 Marek Safar <marek.safar@seznam.cz>
15778 * class.cs (ConstructorInitializer.Resolve):
15779 Wrong error number (515->516).
15781 2004-09-11 Marek Safar <marek.safar@seznam.cz>
15783 * class.cs (Indexer.Define): Add error 631 report.
15785 2004-09-11 Marek Safar <marek.safar@seznam.cz>
15787 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
15789 2004-09-11 Marek Safar <marek.safar@seznam.cz>
15791 * expression.cs (Probe.DoResolve): Add error CS0241 report.
15793 2004-09-10 Marek Safar <marek.safar@seznam.cz>
15795 * cs-parser.jay: Added error CS0241 report.
15797 2004-09-10 Raja R Harinath <rharinath@novell.com>
15799 * cs-parser.jay (fixed_statement): Introduce a scope for the
15800 declaration in the 'fixed' statement.
15802 2004-09-09 Marek Safar <marek.safar@seznam.cz>
15804 * cs-parser.jay: Added CS0230 error report.
15806 2004-09-09 Marek Safar <marek.safar@seznam.cz>
15808 * cs-parser.jay: Added errors CS0231 and CS0257 report.
15810 2004-09-09 Marek Safar <marek.safar@seznam.cz>
15812 * expression.cs (Argument.Resolve): Added error CS0192 and
15815 2004-09-09 Marek Safar <marek.safar@seznam.cz>
15817 C# 2.0 #pragma warning feature
15819 * cs-tokenizer.cs (PreProcessPragma): New method;
15820 Handles #pragma directive.
15822 * report.cs (WarningRegions): New class; Support
15823 class for #pragma warning directive. It tests whether
15824 warning is enabled for a given line.
15826 2004-09-08 Miguel de Icaza <miguel@ximian.com>
15828 * const.cs: Add more descriptive error report, tahnks to
15831 2004-09-08 Marek Safar <marek.safar@seznam.cz>
15833 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
15835 2004-09-07 Miguel de Icaza <miguel@ximian.com>
15837 * expression.cs: Apply patch from Ben: Remove dead code from
15838 ArrayCreation, and remove the TurnintoConstant call in const.cs,
15839 as that code just threw an exception anwyays.
15841 * const.cs: Remove the call to the turnintoconstant, for details
15844 * literal.cs: The type of the null-literal is the null type; So
15845 we use a placeholder type (literal.cs:System.Null, defined here)
15848 * expression.cs (Conditional.DoResolve): Remove some old code that
15849 is no longer needed, conversions have been fixed.
15851 (ArrayCreationExpression.DoResolve): Return false if we fail to
15852 resolve the inner expression.
15854 2004-09-07 Raja R Harinath <rharinath@novell.com>
15857 * cs-parser.jay (delegate_declaration): Record a delegate
15858 declaration as a type declaration.
15859 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
15861 2004-09-06 Miguel de Icaza <miguel@ximian.com>
15863 * parameter.cs: Do not crash if the type can not be resolved.
15865 * expression.cs: Report errors with unsafe pointers, fixes #64896
15867 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
15869 * expression.cs: Pointer arith always needs to do a conv.i
15870 if the operand is a long. fix 65320
15872 2004-09-04 Marek Safar <marek.safar@seznam.cz>
15874 Fixed cs0619-37.cs, cs0619-38.cs
15876 * enum.cs (GetObsoleteAttribute): Removed.
15878 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
15879 on Enum member is double staged. The first is tested member
15882 2004-09-04 Marek Safar <marek.safar@seznam.cz>
15884 Fixed #56986, #63631, #65231
15886 * class.cs: (TypeContainer.AddToMemberContainer): New method,
15887 adds member to name container.
15888 (TypeContainer.AddToTypeContainer): New method, adds type to
15890 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
15891 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
15892 AddOperator): Simplified by reusing AddToMemberContainer.
15893 (TypeContainer.UserDefinedStaticConstructor): Changed to property
15895 (Method.CheckForDuplications): Fixed implementation to test all
15897 (MemberBase): Detection whether member is explicit interface
15898 implementation is now in constructor.
15899 (MemberBase.UpdateMemberName): Handles IndexerName.
15900 (Accessor): Changed to keep also location information.
15901 (AbstractPropertyEventMethod): Is derived from MemberCore.
15902 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
15903 will be emited or not.
15904 (PropertyBase.AreAccessorsDuplicateImplementation):
15905 Tests whether accessors are not in collision with some method.
15906 (Operator): Is derived from MethodCore to simplify common
15909 * decl.cs (Flags.TestMethodDuplication): Test for duplication
15911 (DeclSpace.AddToContainer): Adds the member to defined_names
15912 table. It tests for duplications and enclosing name conflicts.
15914 * enum.cs (EnumMember): Clean up to reuse the base structures
15916 2004-09-03 Martin Baulig <martin@ximian.com>
15918 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
15919 into TypeContainer, to make partial classes work again.
15921 2004-09-03 Martin Baulig <martin@ximian.com>
15923 * rootcontext.cs (RootContext.V2): Removed.
15925 2004-03-23 Martin Baulig <martin@ximian.com>
15927 * expression.cs (Invocation.OverloadResolve): Added `bool
15928 may_fail' argument and use it instead of the Location.IsNull() hack.
15930 2004-09-03 Martin Baulig <martin@ximian.com>
15932 Merged latest changes into gmcs. Please keep this comment in
15933 here, it makes it easier for me to see what changed in MCS since
15934 the last time I merged.
15936 2004-09-03 Raja R Harinath <rharinath@novell.com>
15939 * expression.cs (BetterConversion): Don't allow either conversion
15940 to be null. Remove redundant implicit conversion test when 'q ==
15941 null' -- when this function is invoked, we already know that the
15942 implicit conversion exists.
15943 (BetterFunction): Assume that 'best' is non-null. Remove
15944 redundant reimplementation of IsApplicable when 'best' is null.
15945 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
15946 number of arguments.
15947 (IsAncestralType): Extract from OverloadResolve.
15948 (OverloadResolve): Make robust to the MethodGroupExpr being
15949 unsorted. Implement all the logic of Section 14.5.5.1, and
15950 support overloading of methods from multiple applicable types.
15951 Clean up logic somewhat. Don't pass null methods to BetterFunction.
15953 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
15954 (RealError, Warning): Append type of report to related symbol.
15956 2004-09-03 Marek Safar <marek.safar@seznam.cz>
15958 * enum.cs: Fixed CLS-Compliance checks for enum members.
15959 Error tests cs3008-8.cs, cs3014-8.cs
15961 2004-09-02 Marek Safar <marek.safar@seznam.cz>
15963 Fixed bug #62342, #63102
15964 * class.cs: ImplementIndexer uses member.IsExplicitImpl
15965 like ImplementMethod.
15967 2004-09-02 Marek Safar <marek.safar@seznam.cz>
15969 * attribute.cs (Attribute.GetAttributeArgumentExpression):
15972 2004-09-02 Martin Baulig <martin@ximian.com>
15974 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
15975 TypeManager.GetArgumentTypes() rather than calling GetParameters()
15978 2004-09-01 Marek Safar <marek.safar@seznam.cz>
15980 C# 2.0 Static classes implemented
15982 * class.cs (TypeContainer): instance_constructors,
15983 initialized_fields, initialized_static_fields,
15984 default_constructor, base_inteface_types are protected to be
15985 accessible from StaticClass.
15986 (TypeContainer.DefineDefaultConstructor): New virtual method
15987 for custom default constructor generating
15988 (StaticClass): New class to handle "Static classes" feature.
15990 * cs-parser.jay: Handle static keyword on class like instance
15993 * driver.cs: Added "/langversion" command line switch with two
15994 options (iso-1, default).
15996 2004-08-31 Marek Safar <marek.safar@seznam.cz>
15998 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
16000 2004-08-31 Miguel de Icaza <miguel@ximian.com>
16002 * delegate.cs: Style.
16004 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
16006 * delegate.cs: Add seperate instance expr field for miguel.
16008 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16010 * PointerArithmetic (Resolve): make sure we are not doing
16011 pointer arith on void*. Also, make sure we are resolved
16012 by not setting eclass until resolve.
16014 All callers: Make sure that PointerArithmetic gets resolved.
16016 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16018 * ArrayCreation (LookupType): If the type does not resolve
16019 to an array, give an error.
16021 2004-08-27 Marek Safar <marek.safar@seznam.cz>
16023 * statement.cs (Try.Resolve): Fixed bug #64222
16025 2004-08-27 Martin Baulig <martin@ximian.com>
16028 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
16031 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16033 * ecore.cs (Constantify): Get underlying type via
16034 System.Enum.GetUnderlyingType to avoid StackOverflow on the
16035 Windows in special cases.
16037 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16039 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
16040 for obtaining also private methods.
16041 (GetRemoveMethod): Used GetRemoveMethod (true)
16042 for obtaining also private methods.
16044 2004-08-24 Martin Baulig <martin@ximian.com>
16046 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
16047 MethodAttributes.HideBySig for operators.
16049 2004-08-23 Martin Baulig <martin@ximian.com>
16051 Back to the old error reporting system :-)
16053 * report.cs (Message): Removed.
16054 (Report.MessageData, ErrorData, WarningData): Removed.
16055 (Report.Error, Warning): Back to the old system.
16057 2004-08-23 Martin Baulig <martin@ximian.com>
16059 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
16061 * class.cs (TypeContainer.ParentContainer): New public virtual
16062 method; replaces the explicit interface implementation.
16063 (ClassPart.ParentContainer): Override.
16065 2004-08-23 Martin Baulig <martin@ximian.com>
16067 * statement.cs (Switch): Added support for constant switches; see
16068 #59428 or test-285.cs.
16070 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16073 * statement.cs (GetEnumeratorFilter): Removed useless
16074 logic because C# specs is strict. GetEnumerator must be
16077 2004-08-22 Martin Baulig <martin@ximian.com>
16079 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
16080 a switch and may break, reset the barrier. Fixes #59867.
16082 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16084 CLS-Compliance speed up (~5% for corlib)
16086 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
16087 New method. Tests container for CLS-Compliant names
16089 * class.cs (TypeContainer.VerifyClsName): New method.
16090 Checks whether container name is CLS Compliant.
16091 (Constructor): Implements IMethodData.
16093 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
16094 low-case table for CLS Compliance test.
16095 (MemberCache.VerifyClsParameterConflict): New method.
16096 Checks method parameters for CS3006 error.
16098 * enum.cs (EnumMember): Is derived from MemberCore.
16099 (Enum.VerifyClsName): Optimized for better performance.
16101 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16103 * report.cs: Renamed Error_T to Error and changed all
16106 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16108 * class.cs (TypeContainer.IndexerArrayList): New inner class
16109 container for indexers.
16110 (TypeContainer.DefaultIndexerName): New constant for default
16111 indexer name. Replaced all "Item" with this constant.
16112 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
16114 * typemanager.cs (TypeManager.default_member_ctor): Cache here
16115 DefaultMemberAttribute constructor.
16117 2004-08-05 Martin Baulig <martin@ximian.com>
16119 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
16122 2004-08-05 Marek Safar <marek.safar@seznam.cz>
16124 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
16125 multi platforms problem.
16127 * compiler.csproj: Included shared files.
16129 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16131 Fix bug 60333, 55971 in the more general way
16132 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16133 Added arg_type argument for constant conversion.
16134 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
16136 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16139 * class.cs (TypeContainer ): New inner classes MethodArrayList,
16140 OperatorArrayList, MethodCoreArrayList for typecontainer
16141 containers. Changed class member types to these new types.
16142 (MethodArrayList.DefineMembers): Added test for CS0659.
16144 2004-08-04 Miguel de Icaza <miguel@ximian.com>
16146 * cfold.cs: Synchronize the folding with the code in expression.cs
16147 Binary.DoNumericPromotions for uint operands.
16149 * attribute.cs: Revert patch from Raja, it introduced a regression
16150 while building Blam-1.2.1 (hard to isolate a test case).
16152 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16156 (TypeContainer.Define): Renamed to DefineContainerMembers because of
16158 (MethodCore.parent_method): New member. The method we're overriding
16159 if this is an override method.
16160 (MethodCore.CheckBase): Moved from Method class and made common.
16161 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
16163 (MethodCore.CheckForDuplications): New abstract method. For custom
16164 member duplication search in a container
16165 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
16166 method and its return type.
16167 (Event.conflict_symbol): New member. Symbol with same name in the
16171 (MemberCache.FindMemberWithSameName): New method. The method
16172 is looking for conflict with inherited symbols.
16174 2004-08-04 Martin Baulig <martin@ximian.com>
16176 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
16178 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
16180 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16182 * report.cs (Message): New enum for better error, warning reference in
16184 (MessageData): New inner abstract class. It generally handles printing of
16185 error and warning messages.
16186 Removed unused Error, Warning, Message methods.
16188 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16190 Fix for cs0592-8.cs test
16192 (Attributable.ValidAttributeTargets): Made public.
16193 (Attribute.ExplicitTarget): New member for explicit target value.
16194 (Attribute.CheckTargets): Now we translate explicit attribute
16195 target to Target here.
16197 2004-08-03 Ben Maurer <bmaurer@ximian.com>
16199 * ecore.cs (MethodGroupExpr): new IsBase property.
16201 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
16203 * delegate.cs (DelegateCreation): store a MethodGroupExpr
16204 rather than an instance expr.
16206 (DelegateCreation.Emit): Use the method group rather than
16207 the instance expression. Also, if you have base.Foo as the
16208 method for a delegate, make sure to emit ldftn, not ldftnvirt.
16210 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
16212 (NewDelegate.DoResolve): Only check for the existance of Invoke
16213 if the method is going to be needed. Use MethodGroupExpr.
16215 (NewDelegate.Emit): Remove, DelegateCreation implements this.
16217 * expression.cs: For pointer arith., make sure to use
16218 the size of the type, not the size of the pointer to
16221 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16224 * class.cs (Class): Added error CS0502 test.
16226 2004-08-03 John Luke <jluke@cfl.rr.com>
16227 Raja R Harinath <rharinath@novell.com>
16230 * attribute.cs (Attribute.complained_before): New flag.
16231 (Attribute.ResolveType, Attribute.Resolve),
16232 (Attribute.DefinePInvokeMethod): Set it.
16233 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
16235 2004-08-03 Martin Baulig <martin@ximian.com>
16237 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
16238 use a user-defined operator; we still need to do numeric
16239 promotions in case one argument is a builtin type and the other
16240 one has an implicit conversion to that type. Fixes #62322.
16242 2004-08-02 Martin Baulig <martin@ximian.com>
16244 * statement.cs (LocalInfo.Flags): Added `IsThis'.
16245 (LocalInfo.IsThis): New public property.
16246 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
16248 2004-08-01 Martin Baulig <martin@ximian.com>
16250 * class.cs (TypeContainer.GetClassBases): Don't set the default
16251 here since we may get called from GetPartialBases().
16252 (TypeContainer.DefineType): If GetClassBases() didn't return a
16253 parent, use the default one.
16255 2004-07-30 Duncan Mak <duncan@ximian.com>
16257 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
16259 2004-07-30 Martin Baulig <martin@ximian.com>
16261 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
16263 * class.cs (SourceMethod): New public class, derive from the
16264 symbol writer's ISourceMethod.
16265 (Method): Use the new symbol writer API.
16267 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
16268 as argument and use the new symbol writer.
16271 (SourceFile): Implement the symbol writer's ISourceFile.
16272 (Location.SymbolDocument): Removed.
16273 (Location.SourceFile): New public property.
16275 * symbolwriter.cs: Use the new symbol writer API.
16277 2004-07-30 Raja R Harinath <rharinath@novell.com>
16279 * Makefile (install-local): Remove. Functionality moved to
16282 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
16284 * Makefile: Install mcs.exe.config file together with mcs.exe.
16285 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
16286 correct runtime version.
16288 2004-07-25 Martin Baulig <martin@ximian.com>
16291 (TypeContainer.RegisterOrder): Removed, this was unused.
16292 (TypeContainer, interface_order): Removed.
16293 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
16294 TypeContainer as argument since we can also be called with a
16295 `PartialContainer' for a partial class/struct/interface.
16296 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
16297 of checking whether we're an `Interface' - we could be a
16298 `PartialContainer'.
16299 (PartialContainer.Register): Override; call
16300 AddClass()/AddStruct()/AddInterface() on our parent.
16302 * cs-parser.jay (interface_member_declaration): Add things to the
16303 `current_container', not the `current_class'.
16305 * rootcontext.cs (RegisterOrder): The overloaded version which
16306 takes an `Interface' was unused, removed.
16308 * typemanager.cs (TypeManager.LookupInterface): Return a
16309 `TypeContainer', not an `Interface'.
16310 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
16311 contain a `PartialContainer' for an interface, so check it's
16312 `Kind' to figure out what it is.
16314 2004-07-25 Martin Baulig <martin@ximian.com>
16316 * class.cs (Class.DefaultTypeAttributes): New public constant.
16317 (Struct.DefaultTypeAttributes): Likewise.
16318 (Interface.DefaultTypeAttributes): Likewise.
16319 (PartialContainer.TypeAttr): Override this and add the
16320 DefaultTypeAttributes.
16322 2004-07-25 Martin Baulig <martin@ximian.com>
16324 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
16325 we can just use the `Parent' field instead.
16327 2004-07-25 Martin Baulig <martin@ximian.com>
16329 * class.cs (TypeContainer.Emit): Renamed to EmitType().
16331 2004-07-25 Martin Baulig <martin@ximian.com>
16333 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
16334 our parts before defining any methods.
16335 (TypeContainer.VerifyImplements): Make this virtual.
16336 (ClassPart.VerifyImplements): Override and call VerifyImplements()
16337 on our PartialContainer.
16339 2004-07-25 Martin Baulig <martin@ximian.com>
16341 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
16343 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
16344 argument, we can just use the `Parent' field instead.
16347 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
16348 (MemberBase.DoDefine): Likewise.
16350 2004-07-24 Martin Baulig <martin@ximian.com>
16352 * decl.cs (MemberCore.Parent): New public field.
16353 (DeclSpace.Parent): Moved to MemberCore.
16355 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
16356 (MemberBase.ctor): Added TypeContainer argument, pass it to our
16358 (FieldBase, Field, Operator): Likewise.
16359 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
16360 (EventField, Event): Likewise.
16362 2004-07-23 Martin Baulig <martin@ximian.com>
16364 * class.cs (PartialContainer): New public class.
16365 (ClassPart): New public class.
16366 (TypeContainer): Added support for partial classes.
16367 (TypeContainer.GetClassBases): Splitted some of the functionality
16368 out into GetNormalBases() and GetPartialBases().
16370 * cs-tokenizer.cs (Token.PARTIAL): New token.
16371 (Tokenizer.consume_identifier): Added some hacks to recognize
16372 `partial', but only if it's immediately followed by `class',
16373 `struct' or `interface'.
16375 * cs-parser.jay: Added support for partial clases.
16377 2004-07-23 Martin Baulig <martin@ximian.com>
16379 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
16380 a `DeclSpace' and also made it readonly.
16381 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
16382 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
16383 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
16385 * cs-parser.jay: Pass the `current_class', not the
16386 `current_container' (at the moment, this is still the same thing)
16387 to a new Method, Property, Event, Indexer or Constructor.
16389 2004-07-23 Martin Baulig <martin@ximian.com>
16391 * cs-parser.jay (CSharpParser): Added a new `current_class' field
16392 and removed the `current_interface' one.
16393 (struct_declaration, class_declaration, interface_declaration):
16394 Set `current_class' to the newly created class/struct/interface;
16395 set their `Bases' and call Register() before parsing their body.
16397 2004-07-23 Martin Baulig <martin@ximian.com>
16399 * class.cs (Kind): New public enum.
16400 (TypeContainer): Made this class abstract.
16401 (TypeContainer.Kind): New public readonly field.
16402 (TypeContainer.CheckDef): New public method; moved here from
16404 (TypeContainer.Register): New public abstract method.
16405 (TypeContainer.GetPendingImplementations): New public abstract
16407 (TypeContainer.GetClassBases): Removed the `is_class' and
16408 `is_iface' parameters.
16409 (TypeContainer.DefineNestedTypes): Formerly known as
16411 (ClassOrStruct): Made this class abstract.
16413 * tree.cs (RootTypes): New public type.
16415 2004-07-20 Martin Baulig <martin@ximian.com>
16417 * tree.cs (Tree.RecordNamespace): Removed.
16418 (Tree.Namespaces): Removed.
16420 * rootcontext.cs (RootContext.IsNamespace): Removed.
16422 * cs-parser.jay (namespace_declaration): Just create a new
16423 NamespaceEntry here.
16425 2004-07-20 Martin Baulig <martin@ximian.com>
16427 * statement.cs (ExceptionStatement): New abstract class. This is
16428 now used as a base class for everyone who's using `finally'.
16429 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
16430 our local variables before using them.
16432 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
16433 virtual method. This is used by Yield.Resolve() to "steal" an
16434 outer block's `finally' clauses.
16435 (FlowBranchingException): The .ctor now takes an ExceptionStatement
16438 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
16439 version which takes an ExceptionStatement. This version must be
16440 used to create exception branchings.
16443 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
16444 (Iterator.EmitMoveNext): Added exception support; protect the
16445 block with a `fault' clause, properly handle 'finally' clauses.
16446 (Iterator.EmitDispose): Run all the `finally' clauses here.
16448 2004-07-20 Martin Baulig <martin@ximian.com>
16450 * iterator.cs: This is the first of a set of changes in the
16451 iterator code. Match the spec more closely: if we're an
16452 IEnumerable, then GetEnumerator() must be called. The first time
16453 GetEnumerator() is called, it returns the current instance; all
16454 subsequent invocations (if any) must create a copy.
16456 2004-07-19 Miguel de Icaza <miguel@ximian.com>
16458 * expression.cs: Resolve the constant expression before returning
16461 2004-07-19 Martin Baulig <martin@ximian.com>
16463 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
16464 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
16465 the return type of the new EmitContext.
16467 2004-07-18 Martin Baulig <martin@ximian.com>
16469 * class.cs (Property.Define): Fix iterators.
16471 * iterators.cs (Iterator.Define): Moved the
16472 `container.AddInterator (this)' call here from the .ctor; only do
16473 it if we resolved successfully.
16475 2004-07-17 Miguel de Icaza <miguel@ximian.com>
16477 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
16478 `true' for preprocessing directives that we parse. The return
16479 value indicates whether we should return to regular tokenizing or
16480 not, not whether it was parsed successfully.
16482 In the past if we were in: #if false ... #line #endif, we would
16483 resume parsing after `#line'. See bug 61604.
16485 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
16486 building: IsEnumType should return true only for enums, not for
16487 enums or System.Enum itself. This fixes #61593.
16489 Likely what happened is that corlib was wrong: mcs depended on
16490 this bug in some places. The bug got fixed, we had to add the
16491 hack, which caused bug 61593.
16493 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
16494 that was a workaround for the older conditions.
16496 2004-07-16 Ben Maurer <bmaurer@ximian.com>
16498 * assign.cs: IAssignMethod has a new interface, as documented
16499 inline. All assignment code now uses this new api.
16501 * ecore.cs, expression.cs: All classes which implement
16502 IAssignMethod now use the new interface.
16504 * expression.cs (Invocation): add a hack to EmitCall so that
16505 IndexerAccess can be the target of a compound assignment without
16506 evaluating its arguments twice.
16508 * statement.cs: Handle changes in Invocation api.
16510 2004-07-16 Martin Baulig <martin@ximian.com>
16512 * iterators.cs: Rewrote this. We're now using one single Proxy
16513 class for both the IEnumerable and the IEnumerator interface and
16514 `Iterator' derives from Class so we can use the high-level API.
16516 * class.cs (TypeContainer.AddIterator): New method.
16517 (TypeContainer.DoDefineType): New protected virtual method, which
16518 is called from DefineType().
16519 (TypeContainer.DoDefineMembers): Call DefineType() and
16520 DefineMembers() on all our iterators.
16521 (TypeContainer.Emit): Call Emit() on all our iterators.
16522 (TypeContainer.CloseType): Call CloseType() on all our iterators.
16524 * codegen.cs (EmitContext.CurrentIterator): New public field.
16526 2004-07-15 Martin Baulig <martin@ximian.com>
16529 (TypeManager.not_supported_exception_type): New type.
16531 2004-07-14 Martin Baulig <martin@ximian.com>
16533 * iterators.cs: Use real error numbers.
16535 2004-07-14 Martin Baulig <martin@ximian.com>
16537 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
16538 requires this to be a System.Collection.IEnumerable and not a
16539 class implementing that interface.
16540 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
16542 2004-07-13 Marek Safar <marek.safar@seznam.cz>
16544 * class.cs: Fixed previous fix, it broke some error tests.
16546 2004-07-12 Martin Baulig <martin@ximian.com>
16548 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
16551 2004-07-09 Miguel de Icaza <miguel@ximian.com>
16553 * assign.cs (LocalTemporary): Add new argument: is_address,If
16554 `is_address' is true, then the value that we store is the address
16555 to the real value, and not the value itself.
16557 * ecore.cs (PropertyExpr): use the new local temporary
16558 stuff to allow us to handle X.Y += z (where X is a struct)
16560 2004-07-08 Martin Baulig <martin@ximian.com>
16562 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
16563 not always return, just like we're doing in Using.Resolve().
16565 2004-07-07 Miguel de Icaza <miguel@ximian.com>
16567 * cs-parser.jay (fixed_statement): flag this as Pinned.
16569 2004-07-06 Miguel de Icaza <miguel@ximian.com>
16571 * typemanager.cs (TypeManager): Removed MakePinned method, this
16572 mechanism is replaced with the .NET 2.x compatible mechanism of
16573 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
16575 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
16576 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
16577 `IsFixed' property which has a different meaning.
16579 2004-07-02 Raja R Harinath <rharinath@novell.com>
16581 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
16582 visible from inside a nested class, not just the names of the
16583 immediately enclosing class.
16584 Fix for bug #60730.
16586 2004-06-24 Raja R Harinath <rharinath@novell.com>
16588 * expression.cs (BetterConversion): Remove buggy special-case
16589 handling of "implicit constant expression conversions". At this
16590 point, we already know that the conversion is possible -- we're
16591 only checking to see which is better.
16593 2004-06-24 Marek Safar <marek.safar@seznam.cz>
16595 * cs-parser.jay: Added error CS0210 test.
16597 2004-06-24 Marek Safar <marek.safar@seznam.cz>
16599 * cs-parser.jay: Added error CS0134 test.
16601 2004-06-24 Marek Safar <marek.safar@seznam.cz>
16604 * cs-parser.jay: Added error CS0145 test.
16606 2004-06-24 Marek Safar <marek.safar@seznam.cz>
16608 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
16610 2004-06-23 Ben Maurer <bmaurer@ximian.com>
16612 * expression.cs (StackAlloc.Resolve): The argument may not
16613 be a constant; deal with this case.
16615 2004-06-23 Marek Safar <marek.safar@seznam.cz>
16617 * attribute.cs (IndexerName_GetIndexerName): Renamed to
16618 GetIndexerAttributeValue.
16619 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
16621 * class.cs (Indexer.Define): Added error tests for CS0415,
16624 2004-06-23 Miguel de Icaza <miguel@ximian.com>
16626 * attribute.cs (Attribute.Resolve): Keep field code in sync with
16629 2004-06-23 Martin Baulig <martin@ximian.com>
16631 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
16632 neither return nor throw, reset the barrier as well. Fixes #60457.
16634 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
16636 * class.cs : EventAttributes is now set to None by default.
16637 This fixes bug #60459.
16639 2004-06-18 Marek Safar <marek.safar@seznam.cz>
16642 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
16643 Don't throw exception but return null (it's sufficient now).
16645 2004-06-18 Marek Safar <marek.safar@seznam.cz>
16647 * typemanager.cs (GetArgumentTypes): Faster implementation.
16649 2004-06-18 Martin Baulig <martin@ximian.com>
16651 * attribute.cs (Attribute.Resolve): Check whether we're an
16652 EmptyCast which a Constant child. Fixes #60333.
16654 2004-06-17 Ben Maurer <bmaurer@ximian.com>
16656 * statement.cs (EmitCollectionForeach): Account for the fact that
16657 not all valuetypes are in areas which we can take the address of.
16658 For these variables, we store to a temporary variable. Also, make
16659 sure that we dont emit a `callvirt' on a valuetype method.
16661 2004-06-15 Marek Safar <marek.safar@seznam.cz>
16663 * expression.cs (StackAlloc.DoReSolve): Added test for
16664 negative parameter (CS0247).
16666 2004-06-15 Marek Safar <marek.safar@seznam.cz>
16669 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
16671 2004-06-15 Marek Safar <marek.safar@seznam.cz>
16674 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
16677 2004-06-14 Marek Safar <marek.safar@seznam.cz>
16679 Fix bug #58254 & cs1555.cs, cs1556.cs
16680 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
16682 2004-06-14 Marek Safar <marek.safar@seznam.cz>
16684 * cs-parser.jay: Added error CS1669 test for indexers.
16686 2004-06-11 Martin Baulig <martin@ximian.com>
16688 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
16689 call this twice: for params and varargs methods.
16691 2004-06-11 Marek Safar <marek.safar@seznam.cz>
16694 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
16696 2004-06-11 Marek Safar <marek.safar@seznam.cz>
16698 * attribute.cs (Attribute.GetValidTargets): Made public.
16701 (AbstractPropertyEventMethod): New class for better code sharing.
16702 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
16704 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
16706 2004-06-11 Raja R Harinath <rharinath@novell.com>
16709 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
16710 that the call to Resolve is part of a MemberAccess.
16711 (Expression.Resolve): Use it for SimpleName resolution.
16712 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
16713 Add 'intermediate' boolean argument.
16714 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
16715 error message when the SimpleName can be resolved ambiguously
16716 between an expression and a type.
16717 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
16719 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
16720 call on the left-side.
16722 2004-06-11 Marek Safar <marek.safar@seznam.cz>
16725 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
16727 2004-06-11 Marek Safar <marek.safar@seznam.cz>
16729 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
16731 2004-06-11 Martin Baulig <martin@ximian.com>
16733 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
16734 varargs methods if applicable.
16736 2004-06-11 Martin Baulig <martin@ximian.com>
16738 * expression.cs (Invocation.EmitCall): Don't use
16739 `method.CallingConvention == CallingConventions.VarArgs' since the
16740 method could also have `CallingConventions.HasThis'.
16742 2004-06-11 Marek Safar <marek.safar@seznam.cz>
16744 * class.cs (Event.GetSignatureForError): Implemented.
16745 Fixed crash in error test cs3010.cs
16747 2004-06-10 Miguel de Icaza <miguel@ximian.com>
16749 * cs-tokenizer.cs: Change the way we track __arglist to be
16750 consistent with the other keywords.
16752 2004-06-09 Miguel de Icaza <miguel@ximian.com>
16754 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
16757 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
16759 * codegen.cs: Check that all referenced assemblies have a strongname
16760 before strongnaming the compiled assembly. If not report error CS1577.
16761 Fix bug #56563. Patch by Jackson Harper.
16762 * typemanager.cs: Added a method to return all referenced assemblies.
16763 Fix bug #56563. Patch by Jackson Harper.
16765 2004-06-08 Marek Safar <marek.safar@seznam.cz>
16768 (Method.ApplyAttributeBuilder): Moved and added conditional
16769 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
16772 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
16774 2004-06-08 Marek Safar <marek.safar@seznam.cz>
16777 * class.cs: (EventField.attribute_targets): Changed default target.
16779 2004-06-08 Martin Baulig <martin@ximian.com>
16781 * expression.cs (Invocation.EmitCall): Enable varargs methods.
16783 2004-06-08 Martin Baulig <martin@ximian.com>
16785 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
16787 2004-06-07 Martin Baulig <martin@ximian.com>
16789 Added support for varargs methods.
16791 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
16794 * cs-parser.jay: Added support for `__arglist'.
16796 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
16798 * expression.cs (Argument.AType): Added `ArgList'.
16799 (Invocation): Added support for varargs methods.
16800 (ArglistAccess): New public class.
16801 (Arglist): New public class.
16803 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
16805 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
16806 a method's top-level block if the method has varargs.
16808 * support.cs (ReflectionParameters, InternalParameters): Added
16809 support for varargs methods.
16811 2004-06-07 Miguel de Icaza <miguel@ximian.com>
16813 * class.cs: Provide location in indexer error report.
16815 * driver.cs: Use standard names.
16817 * namespace.cs: Catch the use of using after a namespace has been
16818 declared also on using aliases.
16820 2004-06-03 Raja R Harinath <rharinath@novell.com>
16823 * typemanager.cs (closure_private_ok, closure_invocation_type)
16824 (closure_qualifier_type, closure_invocation_assembly)
16825 (FilterWithClosure): Move to ...
16826 (Closure): New internal nested class.
16827 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
16828 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
16829 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
16830 (MemberLookup, MemberLookupFailed): Use it.
16831 * expression.cs (New.DoResolve): Treat the lookup for the
16832 constructor as being qualified by the 'new'ed type.
16833 (Indexers.GetIndexersForTypeOrInterface): Update.
16835 2004-06-03 Marek Safar <marek.safar@seznam.cz>
16838 (GetConditionalAttributeValue): New method. Returns
16839 condition of ConditionalAttribute.
16840 (SearchMulti): New method. Returns all attributes of type 't'.
16841 Use it when attribute is AllowMultiple = true.
16842 (IsConditionalMethodExcluded): New method.
16845 (Method.IsExcluded): Implemented. Returns true if method has conditional
16846 attribute and the conditions is not defined (method is excluded).
16847 (IMethodData): Extended interface for ConditionalAttribute support.
16848 (PropertyMethod.IsExcluded): Implemented.
16851 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
16854 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
16857 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
16859 * expression.cs (ArrayCreationExpression): Make this just an
16860 `expression'. It can't be a statement, so the code here was
16863 2004-06-02 Marek Safar <marek.safar@seznam.cz>
16866 * typemanager.cs (GetFullNameSignature): New method for
16869 2004-06-02 Marek Safar <marek.safar@seznam.cz>
16872 * class.cs (MemberBase.GetSignatureForError): New virtual method.
16873 Use this method when MethodBuilder is null.
16874 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
16875 Added test for error CS0626 (MONO reports error for this situation).
16876 (IMethodData.GetSignatureForError): Extended interface.
16878 2004-06-01 Marek Safar <marek.safar@seznam.cz>
16881 (AttributeTester.GetObsoleteAttribute): Returns instance of
16882 ObsoleteAttribute when type is obsolete.
16885 (TypeContainer.VerifyObsoleteAttribute): Override.
16886 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
16887 (MethodCode.VerifyObsoleteAttribute): Override.
16888 (MemberBase.VerifyObsoleteAttribute): Override.
16891 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
16892 and report proper error.
16895 Delegate.VerifyObsoleteAttribute): Override.
16898 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
16899 and report proper error.
16900 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
16903 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
16907 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
16908 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
16909 Added test for ObsoleteAttribute.
16912 (Catch): Derived from Statement.
16914 2004-06-01 Marek Safar <marek.safar@seznam.cz>
16916 Fixed bug #59071 & cs0160.cs
16918 * statement.cs (Try.Resolve): Check here whether order of catch
16919 clauses matches their dependencies.
16921 2004-05-31 Miguel de Icaza <miguel@ximian.com>
16923 * Reverted patch to namespace.cs (Use lookuptypedirect). This
16924 caused a regression: #59343. Referencing nested classes from an
16925 assembly stopped working.
16927 2004-05-31 Martin Baulig <martin@ximian.com>
16929 MCS is now frozen for beta 2.
16931 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
16933 * convert.cs: add a trivial cache for overload operator resolution.
16935 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
16937 * decl.cs: If possible, use lookuptypedirect here. We can only do
16938 this if there is no `.' after the namespace. Avoids using
16939 LookupType, which does lots of slow processing.
16940 (FindNestedType) New method, does what it says :-).
16941 * namespace.cs: use LookupTypeDirect.
16942 * rootcontext.cs: use membercache, if possible.
16943 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
16945 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
16948 According to the spec,
16950 In a member access of the form E.I, if E is a single identifier,
16951 and if the meaning of E as a simple-name (§7.5.2) is a constant,
16952 field, property, localvariable, or parameter with the same type as
16953 the meaning of E as a type-name (§3.8), then both possible
16954 meanings of E are permitted.
16956 We did not check that E as a simple-name had the same type as E as
16959 This trivial check gives us 5-7% on bootstrap time.
16961 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
16963 * expression.cs (Invocation.OverloadResolve): Avoid the
16964 use of hashtables and boxing here by allocating on demand.
16966 2004-05-30 Martin Baulig <martin@ximian.com>
16968 * rootcontext.cs (RootContext.LookupType): Don't cache things if
16969 we're doing a silent lookup. Don't try to lookup nested types in
16970 TypeManager.object_type (thanks to Ben Maurer).
16972 2004-05-30 Martin Baulig <martin@ximian.com>
16974 Committing a patch from Ben Maurer.
16976 * rootcontext.cs (RootContext.LookupType): Cache negative results.
16978 2004-05-29 Martin Baulig <martin@ximian.com>
16980 * class.cs (IMethodData.ShouldIgnore): New method.
16982 * typemanager.cs (TypeManager.MethodFlags): Don't take a
16983 `Location' argument, we don't need it anywhere. Use
16984 `IMethodData.ShouldIgnore ()' instead of
16985 `MethodData.GetMethodFlags ()'.
16986 (TypeManager.AddMethod): Removed.
16987 (TypeManager.AddMethod2): Renamed to AddMethod.
16989 2004-05-29 Martin Baulig <martin@ximian.com>
16991 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
16993 * convert.cs (Convert.ImplicitReferenceConversion): If we're
16994 converting from a class type S to an interface type and we already
16995 have an object on the stack, don't box it again. Fixes #52578.
16997 2004-05-29 Martin Baulig <martin@ximian.com>
16999 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17000 Added support for `params' parameters. Fixes #59267.
17002 2004-05-29 Martin Baulig <martin@ximian.com>
17004 * literal.cs (NullPointer): Provide a private .ctor which sets
17005 `type' to TypeManager.object_type. Fixes #59048.
17007 2004-05-29 Martin Baulig <martin@ximian.com>
17009 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
17010 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
17012 * ecore.cs (EventExpr.instance_expr): Make the field private.
17014 2004-05-26 Marek Safar <marek.safar@seznam.cz>
17016 Fixed bug #50080 & cs0214-2.cs
17017 * expression.cs (Cast.DoResolve): Check unsafe context here.
17019 * statement.cs (Resolve.DoResolve): Likewise.
17021 2004-05-26 Martin Baulig <martin@ximian.com>
17023 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
17025 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
17026 (RootContext.LookupType): Pass down the `silent' flag.
17028 2004-05-25 Martin Baulig <martin@ximian.com>
17031 (MethodGroupExpr.IdenticalTypeName): New public property.
17032 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
17033 expression actually refers to a type.
17035 2004-05-25 Martin Baulig <martin@ximian.com>
17037 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
17038 for #56176 and made it actually work.
17040 2004-05-25 Martin Baulig <martin@ximian.com>
17042 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
17043 (FieldExpr, PropertyExpr): Override and implement
17044 CacheTemporaries. Fixes #52279.
17046 2004-05-25 Miguel de Icaza <miguel@ximian.com>
17048 * location.cs: In the new compiler listing a file twice is a
17049 warning, not an error.
17051 2004-05-24 Martin Baulig <martin@ximian.com>
17053 * enum.cs (Enum.DefineType): For the `BaseType' to be a
17054 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
17056 2004-05-24 Martin Baulig <martin@ximian.com>
17058 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
17059 walking the `using' list. Fixes #53921.
17061 2004-05-24 Martin Baulig <martin@ximian.com>
17063 * const.cs (Const.LookupConstantValue): Added support for
17064 EmptyCast's; fixes #55251.
17066 2004-05-24 Martin Baulig <martin@ximian.com>
17068 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
17069 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
17070 which does the CS0135 check. The reason is that we first need to
17071 check whether the variable actually exists.
17073 2004-05-24 Martin Baulig <martin@ximian.com>
17075 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
17076 than RootContext.LookupType() to find the explicit interface
17077 type. Fixes #58584.
17079 2004-05-24 Raja R Harinath <rharinath@novell.com>
17081 * Makefile: Simplify. Use executable.make.
17082 * mcs.exe.sources: New file. List of sources of mcs.exe.
17084 2004-05-24 Anders Carlsson <andersca@gnome.org>
17088 Use the invariant culture when doing String.Compare for CLS case
17091 2004-05-23 Martin Baulig <martin@ximian.com>
17093 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
17094 don't have any dots. Fixes #52622, added cs0246-8.cs.
17096 * namespace.cs (NamespaceEntry.Lookup): Likewise.
17098 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17100 * class.cs (MemberBase.Define): Reuse MemberType member for
17101 resolved type. Other methods can use it too.
17103 2004-05-23 Martin Baulig <martin@ximian.com>
17105 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
17106 the variable also exists in the current block (otherwise, we need
17107 to report a CS0103). Fixes #58670.
17109 2004-05-23 Martin Baulig <martin@ximian.com>
17111 * flowanalysis.cs (Reachability.Reachable): Compute this
17112 on-the-fly rather than storing it as a field.
17114 2004-05-23 Martin Baulig <martin@ximian.com>
17116 * flowanalysis.cs (Reachability.And): Manually compute the
17117 resulting `barrier' from the reachability.
17119 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17122 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
17123 instance of ObsoleteAttribute when symbol is obsolete.
17126 (IMethodData): Extended interface for ObsoleteAttribute support.
17128 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17130 * attribute.cs: Fix bug #55970
17132 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17136 (GetObsoleteAttribute): New method. Creates the instance of
17138 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
17139 ObsoleteAttribute when member is obsolete.
17140 (AttributeTester.Report_ObsoleteMessage): Common method for
17141 Obsolete error/warning reporting.
17144 (TypeContainer.base_classs_type): New member for storing parent type.
17147 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
17148 for this MemberCore.
17150 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17152 * attribute.cs, const.cs: Fix bug #58590
17154 2004-05-21 Martin Baulig <martin@ximian.com>
17156 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
17157 out parameters if the end of the method is unreachable. Fixes
17160 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17162 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
17163 Hari was right, why extra method.
17165 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17167 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
17169 2004-05-20 Martin Baulig <martin@ximian.com>
17171 Merged this back from gmcs to keep the differences to a minumum.
17173 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
17174 instead of a Declspace.
17175 (Attribute.ResolveType): Likewise.
17176 (Attributes.Search): Likewise.
17177 (Attributes.Contains): Likewise.
17178 (Attributes.GetClsCompliantAttribute): Likewise.
17180 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
17182 (MethodData.ApplyAttributes): Take an EmitContext instead of a
17185 2004-05-19 Marek Safar <marek.safar@seznam.cz>
17187 Fix bug #58688 (MCS does not report error when the same attribute
17190 * attribute.cs (Attribute.Emit): Distinction between null and default.
17192 2004-05-19 Raja R Harinath <rharinath@novell.com>
17194 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
17195 of a top-level attribute without an attribute target.
17196 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
17198 (Attribute.Conditional_GetConditionName),
17199 (Attribute.Obsolete_GetObsoleteMessage): Update.
17200 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
17201 part of ScanForIndexerName.
17202 (Attribute.CanIgnoreInvalidAttribute): New function.
17203 (Attribute.ScanForIndexerName): Move to ...
17204 (Attributes.ScanForIndexerName): ... here.
17205 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
17206 (Attributes.Search): New internal variant that can choose not to
17207 complain if types aren't resolved. The original signature now
17209 (Attributes.GetClsCompliantAttribute): Use internal variant, with
17210 complaints suppressed.
17211 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
17212 only if it not useful.
17213 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
17214 top-level for attributes that are shared between the assembly
17215 and a top-level class.
17216 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
17217 * class.cs: Update to reflect changes.
17218 (DefineIndexers): Fuse loops.
17219 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
17220 a couple more variants of attribute names.
17222 2004-05-18 Marek Safar <marek.safar@seznam.cz>
17224 Fix bug #52585 (Implemented explicit attribute declaration)
17227 (Attributable.ValidAttributeTargets): New abstract method. It gets
17228 list of valid attribute targets for explicit target declaration.
17229 (Attribute.Target): It holds target itself.
17230 (AttributeSection): Removed.
17231 (Attribute.CheckTargets): New method. It checks whether attribute
17232 target is valid for the current element.
17235 (EventProperty): New class. For events that are declared like
17236 property (with add and remove accessors).
17237 (EventField): New class. For events that are declared like field.
17240 * cs-parser.jay: Implemented explicit attribute target declaration.
17242 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
17243 Override ValidAttributeTargets.
17246 (ReturnParameter): Class for applying custom attributes on
17248 (ParameterAtribute): New class. Class for applying custom
17249 attributes on the parameter type.
17251 2004-05-17 Miguel de Icaza <miguel@ximian.com>
17253 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
17256 (Method): Allow UNSAFE here.
17258 * modifiers.cs: Support unsafe reporting.
17260 2004-05-17 Marek Safar <marek.safar@seznam.cz>
17262 * decl.cs: Fix bug #58478.
17264 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17266 * statement.cs: When checking for unreachable code on an EmptyStatement,
17267 set the location. Fixes bug #58488.
17269 2004-05-13 Miguel de Icaza <miguel@ximian.com>
17271 * driver.cs: Add -pkg handling.
17273 From Gonzalo: UseShelLExecute=false
17275 2004-05-12 Marek Safar <marek.safar@seznam.cz>
17278 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
17280 (Attribute.IsClsCompliaceRequired): Moved to base for better
17282 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
17283 when attribute is AttributeUsageAttribute.
17284 (Attribute.GetValidTargets): Simplified.
17285 (Attribute.GetAttributeUsage): New method returns AttributeUsage
17286 attribute for this type.
17287 (Attribute.ApplyAttributes): Method renamed to Emit and make
17289 (GlobalAttributeSection): New class for special handling of global
17290 attributes (assembly, module).
17291 (AttributeSection.Emit): New method.
17293 * class.cs: Implemented Attributable abstract methods.
17294 (MethodCore.LabelParameters): Moved to Parameter class.
17295 (Accessor): Is back simple class.
17296 (PropertyMethod): Implemented Attributable abstract class.
17297 (DelegateMethod): Implemented Attributable abstract class.
17298 (Event): New constructor for disctintion between normal Event
17299 and Event with accessors.
17301 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
17303 * codegen.cs, const.cs, decl.cs, delegate.cs:
17304 (CommonAssemblyModulClass): Implemented Attributable abstract class
17307 * enum.cs: Implement IAttributeSupport interface.
17308 (EnumMember): New class for emum members. Implemented Attributable
17312 (ParameterBase): Is abstract.
17313 (ReturnParameter): New class for easier [return:] attribute handling.
17315 * typemanager.cs: Removed builder_to_attr.
17317 2004-05-11 Raja R Harinath <rharinath@novell.com>
17320 * attribute.cs (Attribute.GetPositionalValue): New function.
17321 * class.cs (TypeContainer.VerifyMembers): New function.
17322 (TypeContainer.Emit): Use it.
17323 (ClassOrStruct): New base class for Class and Struct.
17324 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
17325 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
17327 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
17328 then each non-static field should have a FieldOffset attribute.
17329 Otherwise, none of the fields should have a FieldOffset attribute.
17330 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
17331 and FieldOffset attributes.
17332 * typemanager.cs (TypeManager.struct_layout_attribute_type)
17333 (TypeManager.field_offset_attribute_type): New core types.
17334 (TypeManager.InitCoreTypes): Initialize them.
17336 2004-05-11 Michal Moskal <malekith@pld-linux.org>
17338 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
17339 Return correct type.
17342 2004-05-09 Miguel de Icaza <miguel@ximian.com>
17344 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
17345 be implicitly converted to ulong.
17347 * expression.cs: The logic for allowing operator &, | and ^ worked
17348 was wrong, it worked before because we did not report an error in
17349 an else branch. Fixes 57895.
17351 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
17352 allow volatile fields to be reference types.
17354 2004-05-07 Miguel de Icaza <miguel@ximian.com>
17356 * driver.cs: Add support for /debug-
17358 2004-05-07 Raja R Harinath <rharinath@novell.com>
17360 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
17361 Add a 'complain' parameter to silence errors.
17362 (Attribute.Resolve): Update to changes. Put in sanity check to catch
17363 silently overlooked type-resolutions.
17364 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
17365 to reflect changes.
17366 (Attributes.Search): New function.
17367 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
17368 (Attributes.GetAttributeFullName): Remove hack.
17369 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
17370 Update to reflect changes.
17371 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
17372 Use Attributes.Search instead of nested loops.
17374 2004-05-07 Marek Safar <marek.safar@seznam.cz>
17377 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
17378 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
17379 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
17381 * report.cs: (Report.Warning): Renamed to Warning_T because of
17382 parameter collision.
17384 2004-05-05 Raja R Harinath <rharinath@novell.com>
17386 * expression.cs (MemberAccess.ResolveMemberAccess):
17387 Exit with non-zero status after Report.Error.
17388 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
17390 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
17392 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
17394 * support.cs: Don't hang when the file is empty.
17396 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
17398 * support.cs: In SeekableStreamReader, compute the preamble size of the
17399 underlying stream. Position changes should take into account that initial
17402 2004-05-03 Todd Berman <tberman@sevenl.net>
17404 * driver.cs: remove unused GetSysVersion function.
17406 2004-05-03 Todd Berman <tberman@sevenl.net>
17408 * driver.cs: Remove the hack from saturday, as well as the hack
17409 from jackson (LoadAssemblyFromGac), also adds the CWD to the
17410 link_paths to get that bit proper.
17412 2004-05-01 Todd Berman <tberman@sevenl.net>
17414 * driver.cs: Try a LoadFrom before a Load, this checks the current
17415 path. This is currently a bug in mono that is be fixed, however, this
17416 provides a workaround for now. This will be removed when the bug
17419 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
17421 * CryptoConvert.cs: Updated to latest version. Fix issue with
17422 incomplete key pairs (#57941).
17424 2004-05-01 Todd Berman <tberman@sevenl.net>
17426 * driver.cs: Remove '.' from path_chars, now System.* loads properly
17429 2004-04-30 Jackson Harper <jackson@ximian.com>
17431 * codegen.cs: Open keys readonly.
17433 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17435 * typemanager.cs: don't report cyclic struct layout when a struct
17436 contains 2 or more fields of the same type. Failed for Pango.AttrShape
17437 which has 2 Pango.Rectangle fields.
17439 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
17441 * expression.cs: Handle IntPtr comparisons with IL code
17442 rather than a method call.
17444 2004-04-29 Martin Baulig <martin@ximian.com>
17446 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
17447 the list of PropertyInfo's in class hierarchy and find the
17448 accessor. Fixes #56013.
17450 2004-04-29 Martin Baulig <martin@ximian.com>
17452 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
17454 2004-04-29 Martin Baulig <martin@ximian.com>
17456 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
17458 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
17460 2004-04-29 Martin Baulig <martin@ximian.com>
17462 * class.cs (ConstructorInitializer.Resolve): Check whether the
17463 parent .ctor is accessible. Fixes #52146.
17465 2004-04-29 Martin Baulig <martin@ximian.com>
17467 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
17469 * statement.cs (Using.EmitLocalVariableDecls): Use
17470 TypeManager.idisposable_type, not typeof (IDisposable).
17471 (Foreach.EmitCollectionForeach): Added support for valuetypes.
17473 2004-04-29 Martin Baulig <martin@ximian.com>
17475 * class.cs (Event.Define): Don't emit the field and don't set
17476 RTSpecialName and SpecialName for events on interfaces. Fixes
17479 2004-04-29 Raja R Harinath <rharinath@novell.com>
17481 Refactor Attribute.ApplyAttributes.
17482 * attribute.cs (Attributable): New base class for objects that can
17483 have Attributes applied on them.
17484 (Attribute): Make AttributeUsage fields public.
17485 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
17486 (Attribute.IsInternalCall): New property.
17487 (Attribute.UsageAttr): Convert to a public read-only property.
17488 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
17489 (Attribute.ResolveType, Attribute.Resolve)
17490 (Attribute.ScanForIndexerName): Update to reflect changes.
17491 (Attribute.CheckAttributeTarget): Re-format.
17492 (Attribute.ApplyAttributes): Refactor, to various
17493 Attributable.ApplyAttributeBuilder methods.
17494 * decl.cs (MemberCore): Make Attributable.
17495 * class.cs (Accessor): Make Attributable.
17496 (MethodData.ApplyAttributes): Use proper attribute types, not
17498 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
17499 (TypeContainer.ApplyAttributeBuilder)
17500 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
17501 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
17502 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
17503 (Operator.ApplyAttributeBuilder): New factored-out methods.
17504 * const.cs (Const.ApplyAttributeBuilder): Likewise.
17505 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
17506 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
17507 * parameter.cs (ParameterBase): New Attributable base class
17508 that can also represent Return types.
17509 (Parameter): Update to the changes.
17511 2004-04-29 Jackson Harper <jackson@ximian.com>
17513 * driver.cs: Prefer the corlib system version when looking for
17514 assemblies in the GAC. This is still a hack, but its a better hack
17517 2004-04-29 Marek Safar <marek.safar@seznam.cz>
17519 * decl.cs, enum.cs: Improved error 3005 reporting.
17521 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
17522 (related_symbols): New private member for list of symbols
17523 related to reported error/warning.
17525 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
17527 2004-04-29 Martin Baulig <martin@ximian.com>
17529 * ecore.cs (Expression.Constantify): If we're an enum and
17530 TypeManager.TypeToCoreType() doesn't give us another type, use
17531 t.UnderlyingSystemType. Fixes #56178.
17533 2004-04-29 Martin Baulig <martin@ximian.com>
17535 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
17536 interfaces and for each interface, only add members directly
17537 declared in that interface. Fixes #53255.
17539 2004-04-28 Martin Baulig <martin@ximian.com>
17541 * expression.cs (ConditionalLogicalOperator): Use a temporary
17542 variable for `left' to avoid that we evaluate it more than once;
17545 2004-04-28 Martin Baulig <martin@ximian.com>
17547 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
17550 2004-04-28 Martin Baulig <martin@ximian.com>
17552 * statement.cs (LocalInfo.Resolve): Check whether the type is not
17555 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
17556 whether the type is not void (CS1547).
17558 2004-04-28 Martin Baulig <martin@ximian.com>
17560 * expression.cs (Unary.DoResolveLValue): Override this and report
17561 CS0131 for anything but Operator.Indirection.
17563 2004-04-28 Martin Baulig <martin@ximian.com>
17565 Committing a patch from Ben Maurer; see bug #50820.
17567 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
17570 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
17573 2004-04-28 Martin Baulig <martin@ximian.com>
17575 Committing a patch from Ben Maurer; see bug #50820.
17577 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
17580 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
17583 2004-04-28 Martin Baulig <martin@ximian.com>
17585 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
17586 (Block.AddLabel): Call DoLookupLabel() to only search in the
17589 2004-04-28 Martin Baulig <martin@ximian.com>
17591 * cfold.cs (ConstantFold.BinaryFold): Added special support for
17592 comparing StringConstants and NullLiterals in Equality and Inequality.
17594 2004-04-28 Jackson Harper <jackson@ximian.com>
17596 * driver.cs: Attempt to load referenced assemblies from the
17597 GAC. This is the quick and dirty version of this method that
17598 doesnt take into account versions and just takes the first
17599 canidate found. Will be good enough for now as we will not have more
17600 then one version installed into the GAC until I update this method.
17602 2004-04-28 Martin Baulig <martin@ximian.com>
17604 * typemanager.cs (TypeManager.CheckStructCycles): New public
17605 static method to check for cycles in the struct layout.
17607 * rootcontext.cs (RootContext.PopulateTypes): Call
17608 TypeManager.CheckStructCycles() for each TypeContainer.
17609 [Note: We only need to visit each type once.]
17611 2004-04-28 Martin Baulig <martin@ximian.com>
17613 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
17615 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
17616 success and added `out object value'. Use a `bool resolved' field
17617 to check whether we've already been called rather than
17618 `ConstantValue != null' since this breaks for NullLiterals.
17620 2004-04-28 Raja R Harinath <rharinath@novell.com>
17622 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
17623 setting of this flag, since the 'set' method may be non-public.
17625 2004-04-28 Raja R Harinath <rharinath@novell.com>
17627 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
17628 check on current_vector.Block.
17630 2004-04-27 Martin Baulig <martin@ximian.com>
17632 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
17633 a field initializer. Fixes #56459.
17635 2004-04-27 Martin Baulig <martin@ximian.com>
17637 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
17638 we're not attempting to use an indexer. Fixes #52154.
17640 2004-04-27 Martin Baulig <martin@ximian.com>
17642 * statement.cs (Return): Don't create a return label if we don't
17643 need it; reverts my change from January 20th. Thanks to Ben
17646 2004-04-27 Martin Baulig <martin@ximian.com>
17648 According to the spec, `goto' can only leave a nested scope, but
17651 * statement.cs (Block.LookupLabel): Only lookup in the current
17652 block, don't recurse into parent or child blocks.
17653 (Block.AddLabel): Check in parent and child blocks, report
17654 CS0140/CS0158 if we find a duplicate.
17655 (Block): Removed this indexer for label lookups.
17656 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
17657 this already does the error reporting for us.
17660 (FlowBranching.UsageVector.Block): New public variable; may be null.
17661 (FlowBranching.CreateSibling): Added `Block' argument.
17662 (FlowBranching.LookupLabel): New public virtual method. Lookup a
17663 label for the target of a `goto' and check whether we're not
17664 leaving a `finally'.
17666 2004-04-27 Martin Baulig <martin@ximian.com>
17668 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17669 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
17672 2004-04-27 Martin Baulig <martin@ximian.com>
17674 * statement.cs (Block.AddLabel): Also check for implicit blocks
17675 and added a CS0158 check.
17677 2004-04-27 Martin Baulig <martin@ximian.com>
17679 * flowanalysis.cs (FlowBranchingLoop): New class.
17680 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
17681 UsageVector's instead of an ArrayList.
17682 (FlowBranching.Label): Likewise.
17683 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
17684 (FlowBranching.AddBreakVector): New method.
17686 2004-04-27 Miguel de Icaza <miguel@ximian.com>
17688 * attribute.cs: Small regression fix: only convert the type if we
17689 the type is different, fixes System.Drawing build.
17691 2004-04-27 Martin Baulig <martin@ximian.com>
17693 * attribute.cs (Attribute.Resolve): If we have a constant value
17694 for a named field or property, implicity convert it to the correct
17697 2004-04-27 Raja R Harinath <rharinath@novell.com>
17699 * statement.cs (Block.Block): Implicit blocks share
17700 'child_variable_names' fields with parent blocks.
17701 (Block.AddChildVariableNames): Remove.
17702 (Block.AddVariable): Mark variable as "used by a child block" in
17703 every surrounding block.
17704 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
17705 been used in a child block, complain about violation of "Invariant
17706 meaning in blocks" rule.
17707 * cs-parser.jay (declare_local_variables): Don't use
17708 AddChildVariableNames.
17709 (foreach_statement): Don't create an implicit block: 'foreach'
17710 introduces a scope.
17712 2004-04-23 Miguel de Icaza <miguel@ximian.com>
17714 * convert.cs (ImplicitNumericConversion): 0 is also positive when
17715 converting from 0L to ulong. Fixes 57522.
17717 2004-04-22 Marek Safar <marek.safar@seznam.cz>
17719 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
17720 derived class hides via 'new' keyword field from base class (test-242.cs).
17721 TODO: Handle this in the more general way.
17723 * class.cs (CheckBase): Ditto.
17725 2004-04-22 Marek Safar <marek.safar@seznam.cz>
17727 * decl.cs (caching_flags): New member for storing cached values
17729 (MemberCore.Flags): New enum where bit flags for caching_flags
17731 (MemberCore.cls_compliance): Moved to caching_flags.
17732 (DeclSpace.Created): Moved to caching_flags.
17734 * class.cs: Use caching_flags instead of DeclSpace.Created
17736 2004-04-21 Miguel de Icaza <miguel@ximian.com>
17738 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
17739 if we are only a derived class, not a nested class.
17741 * typemanager.cs: Same as above, but do this at the MemberLookup
17742 level (used by field and methods, properties are handled in
17743 PropertyExpr). Allow for the qualified access if we are a nested
17746 2004-04-21 Marek Safar <marek.safar@seznam.cz>
17748 * class.cs: Refactoring.
17749 (IMethodData): New inteface; Holds links to parent members
17750 to avoid member duplication (reduced memory allocation).
17751 (Method): Implemented IMethodData interface.
17752 (PropertyBase): New inner classes for get/set methods.
17753 (PropertyBase.PropertyMethod): Implemented IMethodData interface
17754 (Event): New inner classes for add/remove methods.
17755 (Event.DelegateMethod): Implemented IMethodData interface.
17757 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
17758 EmitContext (related to class.cs refactoring).
17760 2004-04-21 Raja R Harinath <rharinath@novell.com>
17762 * delegate.cs (Delegate.VerifyApplicability): If the number of
17763 arguments are the same as the number of parameters, first try to
17764 verify applicability ignoring any 'params' modifier on the last
17768 2004-04-16 Raja R Harinath <rharinath@novell.com>
17770 * class.cs (TypeContainer.AddIndexer): Use
17771 'ExplicitInterfaceName' to determine if interface name was
17772 explicitly specified. 'InterfaceType' is not initialized at this time.
17773 (TypeContainer.DefineIndexers): Remove use of temporary list. The
17774 Indexers array is already in the required order. Initialize
17775 'IndexerName' only if there are normal indexers.
17776 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
17777 (TypeContainer.Emit): Emit DefaultMember attribute only if
17778 IndexerName is initialized.
17781 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
17783 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
17786 2004-04-15 Raja R Harinath <rharinath@novell.com>
17788 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
17792 * attribute.cs (Attribute.Resolve): Check for duplicate named
17796 2004-04-15 Miguel de Icaza <miguel@ximian.com>
17798 * iterators.cs (MarkYield): track whether we are in an exception,
17799 and generate code accordingly. Use a temporary value to store the
17800 result for our state.
17802 I had ignored a bit the interaction of try/catch with iterators
17803 since their behavior was not entirely obvious, but now it is
17804 possible to verify that our behavior is the same as MS .NET 2.0
17808 2004-04-14 Miguel de Icaza <miguel@ximian.com>
17810 * iterators.cs: Avoid creating temporaries if there is no work to
17813 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
17814 Enumerations, use TypeManager.EnumToUnderlying and call
17817 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
17820 (This.Emit): Use EmitContext.EmitThis to emit our
17823 (This.EmitAssign): Ditto.
17825 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
17826 codepaths, we will move all the functionality into
17829 (FieldExpr.EmitAssign): Ditto.
17831 This fixes several hidden bugs that I uncovered while doing a code
17832 review of this today.
17834 * codegen.cs (EmitThis): reworked so the semantics are more clear
17835 and also support value types "this" instances.
17837 * iterators.cs: Changed so that for iterators in value types, we
17838 do not pass the value type as a parameter.
17840 Initialization of the enumerator helpers is now done in the caller
17841 instead of passing the parameters to the constructors and having
17842 the constructor set the fields.
17844 The fields have now `assembly' visibility instead of private.
17846 2004-04-11 Miguel de Icaza <miguel@ximian.com>
17848 * expression.cs (Argument.Resolve): Check if fields passed as ref
17849 or out are contained in a MarshalByRefObject.
17851 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
17852 another compiler type.
17854 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
17856 * class.cs (Indexer.Define): use the new name checking method.
17857 Also, return false on an error.
17858 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
17859 (is_identifier_[start/part]_character): make static.
17861 2004-04-10 Miguel de Icaza <miguel@ximian.com>
17863 * expression.cs (Binary.ResolveOperator): Do no append strings
17864 twice: since we can be invoked more than once (array evaluation)
17865 on the same concatenation, take care of this here. Based on a fix
17866 from Ben (bug #56454)
17868 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
17870 * codegen.cs: Fix another case where CS1548 must be reported (when
17871 delay-sign isn't specified and no private is available #56564). Fix
17872 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
17873 error when MCS is used on the MS runtime and we need to delay-sign
17874 (which seems unsupported by AssemblyBuilder - see #56621).
17876 2004-04-08 Marek Safar <marek.safar@seznam.cz>
17878 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
17879 (TypeManager.ComputeNamespaces): Faster implementation for
17882 * compiler.csproj: Updated AssemblyName to mcs.
17884 2004-04-07 Miguel de Icaza <miguel@ximian.com>
17886 * rootcontext.cs: Add new types to the boot resolution.
17888 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
17889 MulticastDelegate is not allowed.
17891 * typemanager.cs: Add new types to lookup: System.TypedReference
17894 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
17895 check for TypedReference or ArgIterator, they are not allowed.
17897 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
17898 makes us properly catch 1510 in some conditions (see bug 56016 for
17901 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
17903 * CryptoConvert.cs: update from corlib version
17906 2004-04-05 Miguel de Icaza <miguel@ximian.com>
17908 * class.cs (Indexer.Define): Check indexername declaration
17910 2004-04-05 Marek Safar <marek.safar@seznam.cz>
17912 * attribute.cs (IsClsCompliant): Fixed problem with handling
17913 all three states (compliant, not-compliant, undetected).
17915 2004-03-30 Marek Safar <marek.safar@seznam.cz>
17917 * attribute.cs (Attribute): Location is now public.
17918 (Resolve): Store resolved arguments (pos_values) in attribute class.
17919 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
17920 (GetClsCompliantAttributeValue): New method that gets
17921 CLSCompliantAttribute value.
17922 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
17923 if exists else null.
17924 (AttributeTester): New class for CLS-Compliant verification routines.
17926 * class.cs (Emit): Add CLS-Compliant verification.
17927 (Method.GetSignatureForError): Implemented.
17928 (Constructor.GetSignatureForError): Implemented
17929 (Constructor.HasCompliantArgs): Returns if constructor has
17930 CLS-Compliant arguments.
17931 (Constructor.Emit): Override.
17932 (Construcor.IsIdentifierClsCompliant): New method; For constructors
17933 is needed to test only parameters.
17934 (FieldBase.GetSignatureForError): Implemented.
17935 (TypeContainer): New member for storing base interfaces.
17936 (TypeContainer.FindMembers): Search in base interfaces too.
17938 * codegen.cs (GetClsComplianceAttribute): New method that gets
17939 assembly or module CLSCompliantAttribute value.
17940 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
17942 (ModuleClass.Emit): Add error 3012 test.
17944 * const.cs (Emit): Override and call base for CLS-Compliant tests.
17946 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
17947 state for all decl types.
17948 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
17949 if CLS-Compliant tests are required.
17950 (IsClsCompliaceRequired): New method. Analyze whether code
17951 must be CLS-Compliant.
17952 (IsExposedFromAssembly): New method. Returns true when MemberCore
17953 is exposed from assembly.
17954 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
17955 value or gets cached value.
17956 (HasClsCompliantAttribute): New method. Returns true if MemberCore
17957 is explicitly marked with CLSCompliantAttribute.
17958 (IsIdentifierClsCompliant): New abstract method. This method is
17959 used to testing error 3005.
17960 (IsIdentifierAndParamClsCompliant): New method. Common helper method
17961 for identifier and parameters CLS-Compliant testing.
17962 (VerifyClsCompliance): New method. The main virtual method for
17963 CLS-Compliant verifications.
17964 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
17965 null. I don't know why is null (too many public members !).
17966 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
17967 and get value of first CLSCompliantAttribute that found.
17969 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
17970 (VerifyClsCompliance): Override and add extra tests.
17972 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
17973 clscheck- disable CLS-Compliant verification event if assembly is has
17974 CLSCompliantAttribute(true).
17976 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
17977 ApllyAttribute is now called in emit section as in the other cases.
17978 Possible future Emit integration.
17979 (IsIdentifierClsCompliant): New override.
17980 (VerifyClsCompliance): New override.
17981 (GetEnumeratorName): Returns full enum name.
17983 * parameter.cs (GetSignatureForError): Implemented.
17985 * report.cs (WarningData): New struct for Warning message information.
17986 (LocationOfPreviousError): New method.
17987 (Warning): New method. Reports warning based on the warning table.
17988 (Error_T): New method. Reports error based on the error table.
17990 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
17991 verifications are done here.
17993 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
17995 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
17996 CLSCompliantAttribute.
17997 (all_imported_types): New member holds all imported types from other
17999 (LoadAllImportedTypes): New method fills static table with exported types
18000 from all referenced assemblies.
18001 (Modules): New property returns all assembly modules.
18003 2004-03-30 Miguel de Icaza <miguel@ximian.com>
18005 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
18006 throwing a parser error.
18008 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
18009 which removes the hardcoded get_/set_ prefixes for properties, as
18010 IL allows for the properties to be named something else.
18014 * expression.cs: Do not override operand before we know if it is
18015 non-null. Fix 56207
18017 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18019 * typemanager.cs: support for pinned variables.
18021 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18023 * decl.cs, typemanager.cs: Avoid using an arraylist
18024 as a buffer if there is only one result set.
18026 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18028 * expression.cs: Make sure you cant call a static method
18029 with an instance expression, bug #56174.
18031 2004-03-29 Miguel de Icaza <miguel@ximian.com>
18033 * class.cs (IsDuplicateImplementation): Improve error reporting to
18034 flag 663 (method only differs in parameter modifier).
18036 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
18037 in preprocessor directives.
18039 * location.cs (LookupFile): Allow for the empty path.
18041 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
18042 better approach for some of that patch, but its failing with the
18043 CharSet enumeration. For now try/catch will do.
18045 * typemanager.cs: Do not crash if a struct does not have fields.
18048 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18050 * expression.cs: cs0213, cant fix a fixed expression.
18053 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18055 * cs-parser.jay: detect invalid embeded statements gracefully.
18058 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18060 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
18063 the invocation type may not be a subclass of the tye of the item/
18064 The type of the item must be a subclass of the invocation item.
18069 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
18071 * attribute.cs: Added methods to get a string and a bool from an
18072 attribute. Required to information from AssemblyKeyFileAttribute,
18073 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
18074 * codegen.cs: Modified AssemblyName creation to include support for
18075 strongnames. Catch additional exceptions to report them as CS1548.
18076 * compiler.csproj: Updated include CryptoConvert.cs.
18077 * compiler.csproj.user: Removed file - user specific configuration.
18078 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
18079 Mono.Security assembly. The original class is maintained and tested in
18080 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
18081 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
18082 like CSC 8.0 (C# v2) supports.
18083 * Makefile: Added CryptoConvert.cs to mcs sources.
18084 * rootcontext.cs: Added new options for strongnames.
18086 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
18088 * driver.cs: For --expect-error, report error code `2'
18089 if the program compiled with no errors, error code `1' if
18090 it compiled with an error other than the one expected.
18092 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
18094 * compiler.csproj: Updated for Visual Studio .NET 2003.
18095 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
18096 * compiler.sln: Updated for Visual Studio .NET 2003.
18098 2004-03-24 Ravi Pratap M <ravi@ximian.com>
18100 * expression.cs: Fix bug #47234. We basically need to apply the
18101 rule that we prefer the conversion of null to a reference type
18102 when faced with a conversion to 'object' (csc behaviour).
18104 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18106 * statement.cs: Shorter form for foreach, eliminates
18107 a local variable. r=Martin.
18109 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18111 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
18112 checks if we can use brtrue/brfalse to test for 0.
18113 * expression.cs: use the above in the test for using brtrue/brfalse.
18114 cleanup code a bit.
18116 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18118 * expression.cs: Rewrite string concat stuff. Benefits:
18120 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
18121 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
18122 rather than a concat chain.
18124 * typemanager.cs: Add lookups for more concat overloads.
18126 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18128 * expression.cs: Emit shorter il code for array init.
18145 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
18147 * statement.cs: Before, two switch blocks would be merged if the
18148 total size of the blocks (end_item - begin_item + 1) was less than
18149 two times the combined sizes of the blocks.
18151 Now, it will only merge if after the merge at least half of the
18156 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
18158 * class.cs : csc build fix for GetMethods(). See bug #52503.
18160 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
18162 * expression.cs: Make sure fp comparisons work with NaN.
18163 This fixes bug #54303. Mig approved this patch a long
18164 time ago, but we were not able to test b/c the runtime
18167 2004-03-19 Miguel de Icaza <miguel@ximian.com>
18169 * ecore.cs (TypExpr.GetHashCode): implement this overload.
18171 2004-03-19 Martin Baulig <martin@ximian.com>
18173 * class.cs (MemberCore.IsDuplicateImplementation): Report the
18174 error here and not in our caller.
18176 2004-03-19 Martin Baulig <martin@ximian.com>
18178 * interface.cs: Completely killed this file.
18179 (Interface): We're now a TypeContainer and live in class.cs.
18181 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
18182 argument; we're now also called for interfaces.
18183 (TypeContainer.DefineMembers): Allow this method being called
18185 (TypeContainer.GetMethods): New public method; formerly known as
18186 Interface.GetMethod(). This is used by PendingImplementation.
18187 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
18188 it's now private and non-static.
18189 (Interface): Moved this here; it's now implemented similar to
18191 (Method, Property, Event, Indexer): Added `bool is_interface'
18192 argument to their .ctor's.
18193 (MemberBase.IsInterface): New public field.
18195 * cs-parser.jay: Create normal Method, Property, Event, Indexer
18196 instances instead of InterfaceMethod, InterfaceProperty, etc.
18197 (opt_interface_base): Removed; we now use `opt_class_base' instead.
18198 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
18200 2004-03-19 Martin Baulig <martin@ximian.com>
18202 * class.cs (MethodCore.IsDuplicateImplementation): New private
18203 method which does the CS0111 checking.
18204 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
18205 Use IsDuplicateImplementation().
18207 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
18209 * decl.cs (FindMemberToOverride): New method to find the correct
18210 method or property to override in the base class.
18212 - Make Method/Property use the above method to find the
18213 version in the base class.
18214 - Remove the InheritableMemberSignatureCompare as it is now
18217 This patch makes large code bases much faster to compile, as it is
18218 O(n) rather than O(n^2) to do this validation.
18220 Also, it fixes bug 52458 which is that nested classes are not
18221 taken into account when finding the base class member.
18223 Reviewed/Approved by Martin.
18225 2004-03-17 Marek Safar <marek.safar@seznam.cz>
18227 * interface.cs: In all interface classes removed redundant
18228 member initialization.
18230 2004-03-16 Martin Baulig <martin@ximian.com>
18232 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
18234 2004-03-15 Miguel de Icaza <miguel@ximian.com>
18236 * decl.cs (DefineTypeAndParents): New helper method to define a
18237 type's containers before the type itself is defined; This is a
18238 bug exposed by the recent changes to Windows.Forms when an
18239 implemented interface was defined inside a class that had not been
18242 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
18244 (Check): Loop correctly to report errors modifiers
18245 (UNSAFE was not in the loop, since it was the same as TOP).
18247 * interface.cs: Every interface member now takes a ModFlags,
18248 instead of a "is_new" bool, which we set on the base MemberCore.
18250 Every place where we called "UnsafeOk" in the interface, now we
18251 call the proper member (InterfaceMethod.UnsafeOK) instead to get
18252 the unsafe settings from the member declaration instead of the
18253 container interface.
18255 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
18257 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
18258 `set_indexer_name' to the pending bits (one per type).
18260 We fixed a bug today that was picking the wrong method to
18261 override, since for properties the existing InterfaceMethod code
18262 basically ignored the method name. Now we make sure that the
18263 method name is one of the valid indexer names.
18265 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
18267 * support.cs (SeekableStreamReader): Keep track of stream byte
18268 positions and don't mix them with character offsets to the buffer.
18270 Patch from Gustavo Giráldez
18272 2004-03-15 Marek Safar <marek.safar@seznam.cz>
18274 * interface.cs (InterfaceSetGetBase): Removed double member
18275 initialization, base class does it as well.
18277 2004-03-13 Martin Baulig <martin@ximian.com>
18279 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
18280 when compiling corlib.
18282 2004-03-13 Miguel de Icaza <miguel@ximian.com>
18284 * convert.cs (ExplicitConversion): We were reporting an error on
18285 certain conversions (object_type source to a value type, when the
18286 expression was `null') before we had a chance to pass it through
18287 the user defined conversions.
18289 * driver.cs: Replace / and \ in resource specifications to dots.
18292 * class.cs: Add check for duplicate operators. Fixes 52477
18294 2004-03-11 Miguel de Icaza <miguel@ximian.com>
18296 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
18297 that are in the middle of the statements, not only at the end.
18300 * class.cs (TypeContainer.AddField): No longer set the
18301 `HaveStaticConstructor' flag, now we call it
18302 `UserDefineStaticConstructor' to diferentiate the slightly
18303 semantic difference.
18305 The situation is that we were not adding BeforeFieldInit (from
18306 Modifiers.TypeAttr) to classes that could have it.
18307 BeforeFieldInit should be set to classes that have no static
18312 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
18314 And most importantly Zoltan's comment:
18316 http://bugzilla.ximian.com/show_bug.cgi?id=44229
18318 "I think beforefieldinit means 'it's ok to initialize the type sometime
18319 before its static fields are used', i.e. initialization does not need
18320 to be triggered by the first access to the type. Setting this flag
18321 helps the JIT to compile better code, since it can run the static
18322 constructor at JIT time, and does not need to generate code to call it
18323 (possibly lots of times) at runtime. Unfortunately, mcs does not set
18324 this flag for lots of classes like String.
18326 csc sets this flag if the type does not have an explicit static
18327 constructor. The reasoning seems to be that if there are only static
18328 initalizers for a type, and no static constructor, then the programmer
18329 does not care when this initialization happens, so beforefieldinit
18332 This bug prevents the AOT compiler from being usable, since it
18333 generates so many calls to mono_runtime_class_init that the AOT code
18334 is much slower than the JITted code. The JITted code is faster,
18335 because it does not generate these calls if the vtable is type is
18336 already initialized, which is true in the majority of cases. But the
18337 AOT compiler can't do this."
18339 2004-03-10 Miguel de Icaza <miguel@ximian.com>
18341 * class.cs (MethodData.Emit): Refactor the code so symbolic
18342 information is generated for destructors; For some reasons we
18343 were taking a code path that did not generate symbolic information
18346 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
18348 * class.cs: Create a Constructor.CheckBase method that
18349 takes care of all validation type code. The method
18350 contains some code that was moved from Define.
18352 It also includes new code that checks for duplicate ctors.
18353 This fixes bug #55148.
18355 2004-03-09 Joshua Tauberer <tauberer@for.net>
18357 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
18358 a { ... }-style array creation invokes EmitStaticInitializers
18359 which is not good for reference-type arrays. String, decimal
18360 and now null constants (NullCast) are not counted toward
18361 static initializers.
18363 2004-03-05 Martin Baulig <martin@ximian.com>
18365 * location.cs (SourceFile.HasLineDirective): New public field;
18366 specifies whether the file contains or is referenced by a "#line"
18368 (Location.DefineSymbolDocuments): Ignore source files which
18369 either contain or are referenced by a "#line" directive.
18371 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
18373 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
18374 direct access to our parent, so check the method inline there.
18376 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
18378 * expression.cs (Invocation.EmitCall): Miguel's last commit
18379 caused a regression. If you had:
18384 In Foo the implict this would be null.
18386 2004-02-27 Miguel de Icaza <miguel@ximian.com>
18388 * expression.cs (Invocation.EmitCall): If the method is not
18389 virtual, do not emit a CallVirt to it, use Call.
18391 * typemanager.cs (GetFullNameSignature): Improve the method to
18392 cope with ".ctor" and replace it with the type name.
18394 * class.cs (ConstructorInitializer.Resolve): Now the method takes
18395 as an argument the ConstructorBuilder where it is being defined,
18396 to catch the recursive constructor invocations.
18398 2004-02-26 Miguel de Icaza <miguel@ximian.com>
18400 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
18401 routines to check if a type is an enumerable/enumerator allow
18402 classes that implement the IEnumerable or IEnumerator interfaces.
18404 * class.cs (Property, Operator): Implement IIteratorContainer, and
18405 implement SetYields.
18407 (Property.Define): Do the block swapping for get_methods in the
18408 context of iterators. We need to check if Properties also
18409 include indexers or not.
18411 (Operator): Assign the Block before invoking the
18412 OperatorMethod.Define, so we can trigger the Iterator code
18415 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
18416 Property and Operator classes are not created when we parse the
18417 declarator but until we have the block completed, so we use a
18418 singleton SimpleIteratorContainer.Simple to flag whether the
18419 SetYields has been invoked.
18421 We propagate this setting then to the Property or the Operator to
18422 allow the `yield' to function.
18424 2004-02-25 Marek Safar <marek.safar@seznam.cz>
18426 * codegen.cs: Implemented attribute support for modules.
18427 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
18428 Assembly/Module functionality.
18430 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
18431 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
18432 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
18434 2004-02-16 Marek Safar <marek.safar@seznam.cz>
18436 * interface.cs (FindMembers): The operation is performed on all base
18437 interfaces and not only on the first. It is required for future CLS Compliance patch.
18439 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
18441 * statement.cs, codegen.cs:
18442 This patch deals with patterns such as:
18444 public class List : IEnumerable {
18446 public MyEnumerator GetEnumerator () {
18447 return new MyEnumerator(this);
18450 IEnumerator IEnumerable.GetEnumerator () {
18454 public struct MyEnumerator : IEnumerator {
18459 Before, there were a few things we did wrong:
18460 1) we would emit callvirt on a struct, which is illegal
18461 2) we emited ldarg when we needed to emit ldarga
18462 3) we would mistakenly call the interface methods on an enumerator
18463 type that derived from IEnumerator and was in another assembly. For example:
18465 public class MyEnumerator : IEnumerator
18467 Would have the interface methods called, even if there were public impls of the
18468 method. In a struct, this lead to invalid IL code.
18470 2004-02-11 Marek Safar <marek.safar@seznam.cz>
18472 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
18475 * delegate.cs (Define): Fixed crash when delegate type is undefined.
18477 2004-02-11 Miguel de Icaza <miguel@ximian.com>
18479 * cs-parser.jay: Fix small regression: we were not testing V2
18480 compiler features correctly.
18482 * interface.cs: If the emit context is null, then create one
18484 2004-02-09 Marek Safar <marek.safar@seznam.cz>
18486 * decl.cs (GetSignatureForError): New virtual method to get full name
18487 for error messages.
18489 * attribute.cs (IAttributeSupport): New interface for attribute setting.
18490 Now it is possible to rewrite ApplyAttributes method to be less if/else.
18492 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
18493 Duplicated members and code in these classes has been removed.
18494 Better encapsulation in these classes.
18496 2004-02-07 Miguel de Icaza <miguel@ximian.com>
18498 * assign.cs (Assign.DoResolve): When dealing with compound
18499 assignments, there is a new rule in ECMA C# 2.4 (might have been
18500 there before, but it is documented here) that states that in:
18504 If b is of type int, and the `op' is a shift-operator, then the
18505 above is evaluated as:
18509 * expression.cs (Binary.ResolveOperator): Instead of testing for
18510 int/uint/long/ulong, try to implicitly convert to any of those
18511 types and use that in pointer arithmetic.
18513 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
18514 method to print information for from the type, not from the
18515 null-method we were given.
18517 2004-02-01 Duncan Mak <duncan@ximian.com>
18519 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
18520 parsing for cmd, fixes bug #53694.
18522 2004-02-04 Marek Safar <marek.safar@seznam.cz>
18524 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
18525 in the member name duplication tests. Property and operator name duplication
18526 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
18528 2004-02-03 Marek Safar <marek.safar@seznam.cz>
18530 * interface.cs (PopulateMethod): Fixed crash when interface method
18531 returns not existing type (error test cs0246-3.cs).
18533 2004-02-02 Ravi Pratap M <ravi@ximian.com>
18535 * cs-parser.jay (interface_accessors): Re-write actions to also
18536 store attributes attached to get and set methods. Fix spelling
18539 (inteface_property_declaration): Modify accordingly.
18541 (InterfaceAccessorInfo): New helper class to store information to pass
18542 around between rules that use interface_accessors.
18544 * interface.cs (Emit): Apply attributes on the get and set
18545 accessors of properties and indexers too.
18547 * attribute.cs (ApplyAttributes): Modify accordingly to use the
18548 right MethodBuilder when applying attributes to the get and set accessors.
18550 2004-01-31 Miguel de Icaza <miguel@ximian.com>
18552 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
18554 2004-01-26 Miguel de Icaza <miguel@ximian.com>
18556 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
18558 2004-01-25 Miguel de Icaza <miguel@ximian.com>
18560 * cs-parser.jay: Remove YIELD token, instead use the new grammar
18561 changes that treat `yield' specially when present before `break'
18562 or `return' tokens.
18564 * cs-tokenizer.cs: yield is no longer a keyword.
18566 2004-01-23 Marek Safar <marek.safar@seznam.cz>
18568 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
18569 setting for default constructors.
18570 For default constructors are almost every time set wrong Modifier. The
18571 generated IL code has been alright. But inside mcs this values was
18572 wrong and this was reason why several of my CLS Compliance tests
18575 2004-01-22 Martin Baulig <martin@ximian.com>
18577 * cs-parser.jay (namespace_or_type_name): Return an Expression,
18578 not a QualifiedIdentifier. This is what `type_name_expression'
18579 was previously doing.
18580 (type_name_expression): Removed; the code is now in
18581 `namespace_or_type_name'.
18582 (qualified_identifier): Removed, use `namespace_or_type_name'
18584 (QualifiedIdentifier): Removed this class.
18586 2004-01-22 Martin Baulig <martin@ximian.com>
18588 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
18589 not a string as alias name.
18591 2004-01-21 Miguel de Icaza <miguel@ximian.com>
18593 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
18594 #52730 bug, and instead compute correctly the need to use a
18595 temporary variable when requesting an address based on the
18596 static/instace modified of the field and the constructor.
18598 2004-01-21 Martin Baulig <martin@ximian.com>
18600 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
18601 class and namespace before looking up aliases. Fixes #52517.
18603 2004-01-21 Martin Baulig <martin@ximian.com>
18605 * flowanalysis.cs (UsageVector.Merge): Allow variables being
18606 assinged in a 'try'; fixes exception4.cs.
18608 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18609 * class.cs : Implemented parameter-less constructor for TypeContainer
18611 * decl.cs: Attributes are now stored here. New property OptAttributes
18613 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
18615 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
18617 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18619 * typemanager.cs (CSharpSignature): Now reports also inner class name.
18620 (CSharpSignature): New method for indexer and property signature.
18622 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18624 * pending.cs (IsVirtualFilter): Faster implementation.
18626 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18628 * typemanager.cs: Avoid inclusion of same assembly more than once.
18630 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18632 * cs-parser.jay: Fixed problem where the last assembly attribute
18633 has been applied also to following declaration (class, struct, etc.)
18635 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18637 * class.cs: Added error CS0538, CS0539 reporting.
18638 Fixed crash on Microsoft runtime when field type is void.
18640 * cs-parser.jay: Added error CS0537 reporting.
18642 * pending.cs: Added error CS0535 reporting.
18643 Improved error report for errors CS0536, CS0534.
18645 2004-01-20 Miguel de Icaza <miguel@ximian.com>
18647 Merge a few bits from the Anonymous Method MCS tree.
18649 * statement.cs (ToplevelBlock): New class for toplevel methods,
18650 will hold anonymous methods, lifted variables.
18652 * cs-parser.jay: Create toplevel blocks for delegates and for
18653 regular blocks of code.
18655 2004-01-20 Martin Baulig <martin@ximian.com>
18657 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
18658 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
18659 and `NeedExplicitReturn'; added `IsLastStatement'.
18660 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
18661 have a `ReturnLabel' or we're not unreachable.
18663 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
18664 child's reachability; don't just override ours with it. Fixes
18665 #58058 (lluis's example).
18666 (FlowBranching): Added public InTryOrCatch(), InCatch(),
18667 InFinally(), InLoop(), InSwitch() and
18668 BreakCrossesTryCatchBoundary() methods.
18670 * statement.cs (Return): Do all error checking in Resolve().
18671 Unless we are the last statement in a top-level block, always
18672 create a return label and jump to it.
18673 (Break, Continue): Do all error checking in Resolve(); also make
18674 sure we aren't leaving a `finally'.
18675 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
18676 statement in a top-level block.
18677 (Block.Flags): Added `IsDestructor'.
18678 (Block.IsDestructor): New public property.
18680 2004-01-20 Martin Baulig <martin@ximian.com>
18682 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
18684 2004-01-20 Martin Baulig <martin@ximian.com>
18686 * statement.cs (Statement.ResolveUnreachable): New public method.
18687 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
18688 (Block.Resolve): Resolve unreachable statements.
18690 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
18692 * expression.cs: We need to fix the case where we do
18693 not have a temp variable here.
18695 * assign.cs: Only expression compound assignments need
18696 temporary variables.
18698 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
18700 * flowanalysis.cs: Reduce memory allocation in a few ways:
18701 - A block with no variables should not allocate a bit
18703 - A method with no out parameters does not need any tracking
18704 for assignment of the parameters, so we need not allocate
18707 public readonly Type[] VariableTypes;
18708 public readonly string[] VariableNames;
18709 Are redundant. The data is already stored in the variable
18710 map, so we need not allocate another array for it.
18711 - We need to add alot of checks for if (params | locals) == null
18712 due to the first two changes.
18714 2004-01-18 Miguel de Icaza <miguel@ximian.com>
18716 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
18717 implement IMemoryLocation, we store a copy on a local variable and
18718 take the address of it. Patch from Benjamin Jemlich
18720 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
18721 to use a special "type_name_expression" rule which reduces the
18722 number of "QualifiedIdentifier" classes created, and instead
18723 directly creates MemberAccess expressions.
18725 2004-01-17 Miguel de Icaza <miguel@ximian.com>
18727 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
18728 that fixes #52853. Null literal assignment to ValueType
18730 * class.cs (MethodData.Emit): Instead of checking the name of the
18731 method to determine if its a destructor, create a new derived
18732 class from Method called Destructor, and test for that.
18734 * cs-parser.jay: Create a Destructor object instead of a Method.
18736 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
18740 2004-01-16 Miguel de Icaza <miguel@ximian.com>
18742 * expression.cs (Binary.ResolveOperator): Perform an implicit
18743 conversion from MethodGroups to their delegate types on the
18744 Addition operation.
18746 * delegate.cs: Introduce a new class DelegateCreation that is the
18747 base class for `NewDelegate' and `ImplicitDelegateCreation',
18748 factor some code in here.
18750 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
18751 conversion from MethodGroups to compatible delegate types.
18753 * ecore.cs (Expression.Resolve): Do not flag error 654
18754 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
18755 we allow conversions from MethodGroups to delegate types now.
18757 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
18758 assignments in v2 either.
18760 2004-01-10 Miguel de Icaza <miguel@ximian.com>
18762 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
18763 static read-only fields in ctors.
18765 Applied patch from Benjamin Jemlich
18767 * expression.cs (UnaryMutator): Avoid leaking local variables.
18769 2004-01-09 Miguel de Icaza <miguel@ximian.com>
18771 * cs-tokenizer.cs (IsCastToken): Allow the various native types
18772 here to return true, as they can be used like this:
18774 (XXX) int.MEMBER ()
18776 Fixed 49836 and all the other dups
18778 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
18780 * driver.cs: Implement /win32res and /win32icon.
18782 2004-01-08 Miguel de Icaza <miguel@ximian.com>
18784 * cs-parser.jay: Add a rule to improve error handling for the
18785 common mistake of placing modifiers after the type.
18787 2004-01-07 Miguel de Icaza <miguel@ximian.com>
18789 * cs-parser.jay (interface_event_declaration): Catch
18790 initialization of events on interfaces, and report cs0068
18792 * cs-parser.jay (interface_event_declaration): Catch
18793 initialization of events.
18795 * ecore.cs: Better report missing constructors.
18797 * expression.cs (Binary.ResolveOperator): My previous bug fix had
18798 the error reporting done in the wrong place. Fix.
18800 * expression.cs (Binary.ResolveOperator): Catch the
18801 operator + (E x, E y) error earlier, and later allow for implicit
18802 conversions in operator +/- (E e, U x) from U to the underlying
18805 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
18806 52596, if the container class is abstract, the default constructor
18807 is protected otherwise its public (before, we were always public).
18809 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
18812 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
18813 Jemlich that fixes bug #52597, MCS was generating invalid code for
18814 idisposable structs. Thanks to Ben for following up with this
18817 2004-01-06 Miguel de Icaza <miguel@ximian.com>
18819 * driver.cs: Allow assemblies without code to be generated, fixes
18822 2004-01-07 Nick Drochak <ndrochak@gol.com>
18824 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
18826 2004-01-05 Miguel de Icaza <miguel@ximian.com>
18828 * cs-parser.jay: Add rules to improve error reporting if fields or
18829 methods are declared at the namespace level (error 116)
18831 * Add rules to catch event add/remove
18833 2004-01-04 David Sheldon <dave-mono@earth.li>
18835 * expression.cs: Added matching ")" to error message for
18838 2004-01-03 Todd Berman <tberman@gentoo.org>
18840 * ecore.cs, attribute.cs:
18841 Applying fix from #52429.
18843 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
18845 * ecore.cs, expression.cs, statement.cs:
18846 Total rewrite of how we handle branching. We
18847 now handle complex boolean expressions with fewer
18848 jumps. As well if (x == 0) no longer emits a ceq.
18850 if (x is Foo) is much faster now, because we generate
18853 Overall, we get a pretty big improvement on our benchmark
18854 tests. The code we generate is smaller and more readable.
18856 I did a full two-stage bootstrap. The patch was reviewed
18857 by Martin and Miguel.
18859 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
18861 * cs-parser.jay: Make primary_expression not take a QI.
18862 we dont need this because the member_access rule covers
18863 us here. So we replace the rule with just IDENTIFIER.
18865 This has two good effects. First, we remove a s/r conflict.
18866 Second, we allocate many fewer QualifiedIdentifier objects.
18868 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
18870 * attribute.cs: Handle MarshalAs attributes as pseudo, and
18871 set the correct information via SRE. This prevents
18872 hanging on the MS runtime. Fixes #29374.
18874 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
18876 * convert.cs: correctly handle conversions to value types
18877 from Enum and ValueType as unboxing conversions.
18879 Fixes bug #52569. Patch by Benjamin Jemlich.
18881 2004-01-02 Ravi Pratap <ravi@ximian.com>
18883 * expression.cs (BetterConversion): Prefer int -> uint
18884 over int -> ulong (csc's behaviour). This fixed bug #52046.
18886 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
18888 * decl.cs (MemberCache.FindMembers): now returns a
18891 * typemanager.cs: In general, go with with ^^.
18892 (CopyNewMethods): take an IList.
18893 (RealMemberLookup): Only allocate an arraylist
18894 if we copy from two sets of methods.
18896 This change basically does two things:
18897 1) Fewer array lists allocated due to CopyNewMethods.
18898 2) the explicit cast in MemberList costed ALOT.
18900 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
18902 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
18903 a hashtable to avoid needless string allocations when an identifier is
18904 used more than once (the common case).
18906 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
18908 * pending.cs: MS's TypeBuilder.GetInterfaces ()
18909 is broken, it will not return anything. So, we
18910 have to use the information we have in mcs to
18913 * typemanager.cs: Add a cache for GetInterfaces,
18914 since this will now be used more often (due to ^^)
18916 (GetExplicitInterfaces) New method that gets the
18917 declared, not effective, interfaces on a type
18918 builder (eg, if you have interface IFoo, interface
18919 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
18922 This patch makes MCS able to bootstrap itself on
18925 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
18927 * expression.cs: Remove the Nop's that Miguel put
18930 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
18932 * report.cs, codegen.cs: Give the real stack trace to
18933 the error when an exception is thrown.
18935 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
18937 * decl.cs: only allocate hashtables for ifaces if
18940 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
18942 * expression.cs: fix the error from cs0121-2.cs
18943 (a parent interface has two child interfaces that
18944 have a function with the same name and 0 params
18945 and the function is called through the parent).
18947 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
18949 * class.cs, rootcontext.cs, typmanager.cs: do not
18952 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
18954 * codegen.cs: remove stack for the ec flow branching.
18955 It is already a linked list, so no need.
18957 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
18959 * Makefile: Allow custom profiler here.
18961 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
18963 * typemanager.cs (LookupType):
18964 - Use a static char [], because split takes
18965 a param array for args, so it was allocating
18967 - Do not store true in a hashtable, it boxes.
18969 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
18971 * flowanalysis.cs: bytify common enums.
18973 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
18975 * modifiers.cs: Add a new set of flags for the
18976 flags allowed on explicit interface impls.
18977 * cs-parser.jay: catch the use of modifiers in
18978 interfaces correctly.
18979 * class.cs: catch private void IFoo.Blah ().
18981 All related to bug #50572.
18983 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
18985 * decl.cs: Rewrite the consistant accessability checking.
18986 Accessability is not linear, it must be implemented in
18987 a tableish way. Fixes #49704.
18989 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
18991 * expression.cs: Handle negation in a checked context.
18992 We must use subtraction from zero. Fixes #38674.
18994 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
18996 * class.cs: Ignore static void main in DLLs.
18997 * rootcontext.cs: Handle the target type here,
18998 since we are have to access it from class.cs
18999 * driver.cs: account for the above.
19001 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19003 * report.cs: Give line numbers and files if available.
19005 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
19007 * driver.cs: Implement /addmodule.
19009 * typemanager.cs: Change 'modules' field so it now contains Modules not
19012 2003-12-20 Martin Baulig <martin@ximian.com>
19014 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
19015 (FieldBase.IsAssigned): Removed this field.
19016 (FieldBase.SetAssigned): New public method.
19017 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
19019 2003-12-20 Martin Baulig <martin@ximian.com>
19021 * expression.cs (LocalVariableReference.DoResolve): Don't set
19022 `vi.Used' if we're called from DoResolveLValue().
19024 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
19025 returns the usage vector it just merged into the current one -
19026 pass this one to UsageWarning().
19027 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
19028 of the `EmitContext', don't call this recursively on our children.
19030 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
19032 * driver.cs: Implement /target:module.
19034 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
19036 * support.cs (CharArrayHashtable): New helper class.
19038 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
19039 char arrays, not strings, so we can avoid creating a string in
19040 consume_identifier if the identifier is a keyword.
19042 2003-12-16 Martin Baulig <martin@ximian.com>
19044 * statement.cs (LocalInfo.Assigned): Removed this property.
19045 (LocalInfo.Flags): Removed `Assigned'.
19046 (LocalInfo.IsAssigned): New public method; takes the EmitContext
19047 and uses flow analysis.
19048 (Block.UsageWarning): Made this method private.
19049 (Block.Resolve): Call UsageWarning() if appropriate.
19051 * expression.cs (LocalVariableReference.DoResolve): Always set
19052 LocalInfo.Used here.
19054 2003-12-13 Martin Baulig <martin@ximian.com>
19056 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
19057 any value here; we're now using flow analysis to figure out
19058 whether a statement/block returns a value.
19060 2003-12-13 Martin Baulig <martin@ximian.com>
19062 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
19064 (FlowBranching.MergeFinally): Don't call
19065 `branching.CheckOutParameters()' here, this is called in
19067 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
19068 when adding the `finally' vector.
19070 2003-12-13 Martin Baulig <martin@ximian.com>
19073 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
19074 actually work and also fix #48962.
19076 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
19078 * decl.cs: Do not check System.Object for nested types,
19079 since we know it does not have any. Big bang for buck:
19082 Run 1: 8.35 seconds
19083 Run 2: 8.32 seconds
19084 corlib: 17.99 seconds
19086 Run 1: 8.17 seconds
19087 Run 2: 8.17 seconds
19088 corlib: 17.39 seconds
19090 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
19092 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
19093 time we are returning 0 members, so we save alot here.
19095 2003-12-11 Martin Baulig <martin@ximian.com>
19097 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
19098 `MergeChild()', also just take the `FlowBranching' as argument;
19099 call Merge() on it and return the result.
19100 (FlowBranching.Merge): We don't need to do anything if we just
19103 2003-12-11 Martin Baulig <martin@ximian.com>
19105 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
19106 them in an `ArrayList' to reduce memory usage. Thanks to Ben
19107 Maurer for this idea.
19109 2003-12-11 Martin Baulig <martin@ximian.com>
19111 * flowanalysis.cs (MergeResult): This class is now gone; we now
19112 use the `UsageVector' for this. The reason for this is that if a
19113 branching just has one sibling, we don't need to "merge" them at
19114 all - that's the next step to do.
19115 (FlowBranching.Merge): We now return a `UsageVector' instead of a
19118 2003-12-11 Martin Baulig <martin@ximian.com>
19120 Reworked flow analyis and made it more precise and bug-free. The
19121 most important change is that we're now using a special `Reachability'
19122 class instead of having "magic" meanings of `FlowReturns'. I'll
19123 do some more cleanups and optimizations and also add some more
19124 documentation this week.
19126 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
19127 largely reworked this class.
19128 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
19129 the new `Reachability' class instead of having "magic" values here.
19130 (FlowBranching): We're now using an instance of `Reachability'
19131 instead of having separate `Returns', `Breaks' etc. fields.
19133 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
19134 based on flow analysis; ignore the return value of block.Emit ().
19136 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
19138 * driver.cs typemanager.cs: Find the mono extensions to corlib even
19139 if they are private.
19141 2003-12-09 Martin Baulig <martin@ximian.com>
19143 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
19144 call them directly on the UsageVector.
19146 2003-12-09 Martin Baulig <martin@ximian.com>
19148 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
19149 Changed return type from `FlowReturns' to `Reachability'.
19151 2003-12-09 Martin Baulig <martin@ximian.com>
19153 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
19154 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
19155 `Reachable' fields with a single `Reachability' one.
19157 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19159 * class.cs (FindMembers): Remove foreach's.
19164 Run 1: 8.74 seconds
19165 Run 2: 8.71 seconds
19168 Run 1: 8.64 seconds
19169 Run 2: 8.58 seconds
19172 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19177 This patch does a few things:
19178 1. EmptyStatement is now a singleton, so it is never reallocated.
19179 2. All blah is EmptyStatement constructs have been changed to
19180 blah == EmptyStatement.Value, which is much faster and valid
19181 now that EmptyStatement is a singleton.
19182 3. When resolving a block, rather than allocating a new array for
19183 the non-empty statements, empty statements are replaced with
19184 EmptyStatement.Value
19185 4. Some recursive functions have been made non-recursive.
19186 Mainly the performance impact is from (3), however (1) and (2) are needed for
19187 this to work. (4) does not make a big difference in normal situations, however
19188 it makes the profile look saner.
19193 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
19194 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
19195 Total memory allocated: 56397 KB
19198 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
19199 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
19200 Total memory allocated: 55666 KB
19202 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19204 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
19205 than the hashtable in a hashtable version
19207 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
19208 we always end up concating a string. This results in a huge perf
19209 loss, because many strings have to be tracked by the GC. In this
19210 patch, we first use a hashtable that works with two keys, so that
19211 the strings do not need to be concat'ed.
19215 Run 1: 8.74 seconds
19216 Run 2: 8.71 seconds
19219 Run 1: 8.65 seconds
19220 Run 2: 8.56 seconds
19222 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19224 * Makefile: Add a new target `do-time' that does a quick and simple
19225 profile, leaving easy to parse output.
19227 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
19229 * codegen.cs (Init): Create the dynamic assembly with
19230 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
19232 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
19234 * support.cs: Make the PtrHashtable use only one
19235 instance of its comparer.
19237 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
19239 * typemanager.cs: Fix lookup of GetNamespaces.
19241 2003-11-29 Miguel de Icaza <miguel@ximian.com>
19243 * expression.cs: Removed redundant line.
19245 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
19246 ArrayLists, use for loops with bounds.
19248 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
19251 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
19252 arraylists, use for loop with bounds.
19254 The above three changes give us a 0.071 second performance
19255 improvement out of 3.294 seconds down to 3.223. On my machine
19256 the above changes reduced the memory usage by 1,387 KB during
19257 compiler bootstrap.
19259 * cs-parser.jay (QualifiedIdentifier): New class used to represent
19260 QualifiedIdentifiers. Before we created a new string through
19261 concatenation, and mostly later on, the result would be
19262 manipulated by DecomposeQI through string manipulation.
19264 This reduced the compiler memory usage for bootstrapping from
19265 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
19266 compile times in 0.05 seconds.
19268 2003-11-28 Dick Porter <dick@ximian.com>
19270 * support.cs: Do string compares with the Invariant culture.
19278 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
19279 the comparison is done with the Invariant culture.
19281 2003-11-27 Miguel de Icaza <miguel@ximian.com>
19283 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
19284 GetEnumerator method.
19286 (ProbeCollectionType): Iterate starting at the most specific type
19287 upwards looking for a GetEnumerator
19289 * expression.cs: Shift count can be up to 31 for int/uint and 63
19292 2003-11-26 Miguel de Icaza <miguel@ximian.com>
19294 * statement.cs (Block.LookupLabel): Also look for the label on the
19295 children blocks. Use a hash table to keep track of visited
19298 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
19299 we actually did transform the other operand, otherwise fall back
19300 to the common codepath that casts to long.
19302 * cs-tokenizer.cs: Use the same code pattern as the int case.
19303 Maybe I should do the parsing myself, and avoid depending on the
19304 Parse routines to get this done.
19306 2003-11-25 Miguel de Icaza <miguel@ximian.com>
19308 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
19309 which fixes bug 51347. This time test it.
19311 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
19312 attributes for example can not tell the difference between these.
19313 The difference was only a syntax feature of the language.
19315 * attribute.cs: Apply attributes to delegates.
19317 * delegate.cs: Call the apply attributes method.
19319 2003-11-24 Miguel de Icaza <miguel@ximian.com>
19321 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
19322 comparing 0 vs Byte.MinValue, not the value
19324 (ImplicitConversionRequired): When reporting a conversion error,
19325 use error 31 to print out the constant error instead of the
19328 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
19329 which fixes bug 51347.
19331 2003-11-22 Miguel de Icaza <miguel@ximian.com>
19333 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
19334 which fixes the -warnaserror command line option.
19336 2003-11-21 Miguel de Icaza <miguel@ximian.com>
19338 * cfold.cs (DoNumericPromotions): During constant folding of
19339 additions on UIntConstant, special case intconstants with
19340 IntConstants like we do on the expression binary operator.
19342 2003-11-12 Miguel de Icaza <miguel@ximian.com>
19344 * convert.cs (ImplicitReferenceConversion): We were missing a case
19345 (System.Enum are not value types or class types, so we need to
19346 classify them separatedly).
19348 * driver.cs: We do not support error 2007.
19350 2003-11-12 Jackson Harper <jackson@ximian.com>
19352 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
19353 system directory. Also use the full file name so users can
19354 libraries names mscorlib-o-tron.dll in a non system dir.
19356 2003-11-10 Martin Baulig <martin@ximian.com>
19358 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
19359 (TypeManager.InitCoreTypes): Initialize them here, but instead of
19360 calling `ResolveType()' on them, directly assign their `Type'.
19362 2003-11-08 Martin Baulig <martin@ximian.com>
19364 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
19365 return value and the `out parent' parameter.
19366 (TypeContainer.DefineType): Moved the CS0644 check into
19367 GetClassBases(). Don't pass the interface types to the
19368 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
19369 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
19371 * ecore.cs (TypeExpr.IsAttribute): New property.
19372 (TypeExpr.GetInterfaces): New method.
19374 * interface.cs (Interface.GetInterfaceTypeByName): Return a
19375 TypeExpr instead of a Type.
19376 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
19377 (Interface.DefineType): Don't pass the interface types to the
19378 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
19379 them later and then call `TypeBulider.AddInterfaceImplementation()'.
19381 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
19382 instead of a `Type[]'.
19383 (TypeManager.RegisterBuilder): Likewise.
19384 (TypeManager.AddUserInterface): Likewise.
19385 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
19386 `Type[]' and also return a `TypeExpr[]'.
19387 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
19389 2003-11-08 Martin Baulig <martin@ximian.com>
19391 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
19394 2003-11-08 Martin Baulig <martin@ximian.com>
19396 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
19397 TypeManager.ResolveExpressionTypes().
19399 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
19400 instead of an Expression.
19401 (TypeExpr): This is now an abstract base class for `TypeExpression'.
19402 (TypeExpression): New public class; formerly known as `TypeExpr'.
19404 * expression.cs (ComposedCast): Derive from TypeExpr.
19406 * typemanager.cs (TypeManager.system_*_expr): These are now
19407 TypExpr's instead of Expression's.
19408 (TypeManager.ResolveExpressionTypes): New public static function;
19409 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
19412 2003-11-06 Miguel de Icaza <miguel@ximian.com>
19414 * expression.cs (New.DoResolve): Do not dereference value that
19415 might be a null return.
19417 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
19418 sure that the constant value has the right type. Fixes an
19419 unreported bug, similar to 50425.
19421 * const.cs (Const.LookupConstantValue): Call
19422 ImplicitStandardConversionExists before doing a conversion to
19423 avoid havng the TypeManager.ChangeType do conversions.
19425 Reduced the number of casts used
19427 (Const.ChangeType): New routine to enable reuse of the constant
19428 type changing code from statement.
19430 * typemanager.cs (ChangeType): Move common initialization to
19431 static global variables.
19435 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
19436 every value type to go through, even if it was void. Fix that.
19438 * cs-tokenizer.cs: Use is_identifier_start_character on the start
19439 character of the define, and the is_identifier_part_character for
19440 the rest of the string.
19442 2003-11-05 Miguel de Icaza <miguel@ximian.com>
19444 * expression.cs (UnaryMutator.EmitCode): When I updated
19445 LocalVariableReference.DoResolve, I overdid it, and dropped an
19446 optimization done on local variable references.
19448 2003-11-04 Miguel de Icaza <miguel@ximian.com>
19450 * ecore.cs: Convert the return from Ldlen into an int.
19452 2003-10-20 Miguel de Icaza <miguel@ximian.com>
19454 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
19455 the accessibility, this is a special case for toplevel non-public
19456 classes (internal for instance).
19458 2003-10-20 Nick Drochak <ndrochak@gol.com>
19460 * ecore.cs: Fix typo and build. Needed another right paren.
19462 2003-10-19 Miguel de Icaza <miguel@ximian.com>
19464 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
19465 `internal' case regular and protected, but not allowing protected
19466 to be evaluated later. Bug 49840
19468 2003-10-15 Miguel de Icaza <miguel@ximian.com>
19470 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
19471 to kb.Nlast, and not the kb.nFirst to isolate the switch
19474 Extract the underlying type, so enumerations of long/ulong are
19475 treated like long/ulong.
19477 2003-10-14 Miguel de Icaza <miguel@ximian.com>
19479 * expression.cs (New): Overload the meaning of RequestedType to
19480 track the possible creation of the NewDelegate type, since
19481 DoResolve is invoked more than once for new constructors on field
19484 See bugs: #48800 and #37014
19486 * cs-parser.jay (declare_local_constants): Take an arraylist
19487 instead of a single constant.
19489 (local_constant_declaration): It should take a
19490 constant_declarators, not a constant_declarator. Fixes 49487
19492 * convert.cs: Fix error report.
19494 2003-10-13 Jackson Harper <jackson@ximian.com>
19496 * typemanager.cs (TypeToCoreType): Add float and double this fixes
19499 2003-10-09 Martin Baulig <martin@ximian.com>
19501 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
19503 (MethodCore.DoDefineParameters): Removed the TypeContainer
19504 argument; use the DeclSpace which was passed to the .ctor instead.
19505 (MethodCore.CheckParameter): Take a DeclSpace instead of a
19506 TypeContainer; we only need a DeclSpace here.
19508 2003-10-09 Martin Baulig <martin@ximian.com>
19510 * class.cs (MethodData): Added additional `DeclSpace ds' argument
19512 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
19513 EmitContext's .ctor.
19515 2003-10-09 Martin Baulig <martin@ximian.com>
19517 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
19518 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
19519 AsAccessible(), moved them as well.
19521 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
19523 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
19525 * cs-parser.jay : Renamed yyName to yyNames related to jay.
19527 2003-10-07 Miguel de Icaza <miguel@ximian.com>
19529 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
19530 generation for >=, as spotted by Paolo, bug 48679.
19531 Patch from David Waite.
19533 * cs-tokenizer.cs: Add handling for #pragma.
19535 * cs-parser.jay: Allow for both yield and yield return in the
19536 syntax. The anti-cobolization of C# fight will go on!
19538 * class.cs (TypeBuilder.DefineType): Catch error condition here
19539 (Parent.DefineType erroring out and returning null).
19541 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
19542 coping with enumerations variables, we were mistakenly processing
19543 them as a regular value type instead of built-in types. Fixes the
19546 * typemanager.cs (IsBuiltinOrEnum): New method.
19548 2003-09-30 Miguel de Icaza <miguel@ximian.com>
19550 * cs-parser.jay: Upgrade: yield now needs the return clause.
19552 2003-09-19 Martin Baulig <martin@ximian.com>
19554 * decl.cs (MemberCache.SetupCacheForInterface): Take a
19555 `MemberCache parent' argument. Normally, an interface doesn't
19556 have a parent type except System.Object, but we use this in gmcs
19557 for generic type parameters.
19559 2003-09-18 Martin Baulig <martin@ximian.com>
19561 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
19562 on `type.IsInterface'; don't check whether the type has a parent
19563 to determine whether it's an interface.
19565 2003-09-15 Martin Baulig <martin@ximian.com>
19567 * class.cs (TypeContainer.DefineType): Added an error flag to
19568 avoid reporting duplicate CS0146's ("class definition is
19571 * driver.cs (Driver.MainDriver): Abort if
19572 RootContext.ResolveTree() reported any errors.
19574 2003-09-07 Martin Baulig <martin@ximian.com>
19576 * report.cs (Error, Warning): Added overloaded versions which take
19577 a `params object[] args' and call String.Format().
19579 2003-09-07 Martin Baulig <martin@ximian.com>
19581 * decl.cs (DeclSpace..ctor): Don't call
19582 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
19583 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
19584 (DeclSpace.RecordDecl): New method.
19586 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
19588 2003-09-02 Ravi Pratap <ravi@ximian.com>
19590 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
19591 value attributes to be applied to ParameterBuilders.
19593 * class.cs (MethodCore.LabelParameters): Make static and more
19594 generic so that it can be used from other places - like interface
19595 methods, for instance.
19597 * interface.cs (Interface.Emit): Call LabelParameters before
19598 emitting attributes on the InterfaceMethod.
19600 2003-08-26 Martin Baulig <martin@ximian.com>
19602 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
19603 resolving aliases; fixes #47927.
19605 2003-08-26 Martin Baulig <martin@ximian.com>
19607 * statement.cs (Using.DoResolve): This is internally emitting a
19608 try/finally clause, so we need to set ec.NeedExplicitReturn if we
19609 do not always return. Fixes #47681.
19611 2003-08-26 Martin Baulig <martin@ximian.com>
19613 * decl.cs (MemberCore): Moved WarningNotHiding(),
19614 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
19616 (AdditionResult): Make this nested in DeclSpace.
19617 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
19618 argument; call NamespaceEntry.Define() unless we're nested in a
19621 * namespace.cs (Namespace.DefineName): New public function. This
19622 is called from DeclSpace's .ctor to add
19623 (Namespace.Lookup): Include DeclSpaces in the lookup.
19625 * class.cs (Operator): Derive from MemberBase, not MemberCore.
19627 * const.cs (Const): Derive from MemberBase, not MemberCore.
19629 2003-08-25 Martin Baulig <martin@ximian.com>
19631 * convert.cs (Convert.ExplicitReferenceConversion): When
19632 converting from an interface type to a class, unbox if the target
19633 type is a struct type. Fixes #47822.
19635 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19637 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
19640 2003-08-22 Martin Baulig <martin@ximian.com>
19642 * class.cs (TypeManager.DefineType): When defining a nested type,
19643 call DefineType() on our parent; fixes #47801.
19645 2003-08-22 Martin Baulig <martin@ximian.com>
19647 * class.cs (MethodData.Define): While checking if a method is an
19648 interface implementation, improve the test a bit more to fix #47654.
19650 2003-08-22 Martin Baulig <martin@ximian.com>
19652 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
19653 correctly; fixes #47722.
19655 2003-08-22 Martin Baulig <martin@ximian.com>
19657 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
19658 LocalVariableReference, ensure it's not read-only. Fixes #47536.
19660 * statement.cs (Fixed.DoResolve): Make all variables read-only.
19662 2003-08-22 Martin Baulig <martin@ximian.com>
19664 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
19665 can only be assigned in static constructors. Fixes #47161.
19667 2003-08-22 Martin Baulig <martin@ximian.com>
19669 Rewrote and improved the flow analysis code.
19671 * flowbranching.cs (FlowBranching): Make this class abstract.
19672 (FlowBranching.CreateBranching): New static function to create a
19673 new flow branching.
19674 (FlowBranchingBlock, FlowBranchingException): New classes.
19675 (FlowBranching.UsageVector.Type): New public readonly field.
19676 (FlowBranching.UsageVector.Breaks): Removed the setter.
19677 (FlowBranching.UsageVector.Returns): Removed the setter.
19678 (FlowBranching.UsageVector): Added Break(), Return(),
19679 NeverReachable() and Throw() methods to modify the reachability.
19680 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
19681 done by FlowBranching.Merge().
19682 (FlowBranching.UsageVector.MergeChild): New method; merges the
19683 merge result into the current vector.
19684 (FlowBranching.Merge): New abstract method to merge a branching.
19686 2003-08-12 Martin Baulig <martin@ximian.com>
19688 * expression.cs (Indirection.CacheTemporaries): Create the
19689 LocalTemporary with the pointer type, not its element type.
19691 2003-08-10 Miguel de Icaza <miguel@ximian.com>
19693 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
19694 token was a keyword or not.
19696 Add `error' options where an IDENTIFIER was expected; Provide
19697 CheckToken and CheckIdentifierToken convenience error reporting
19700 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
19702 * decl.cs: Rename `NamespaceEntry Namespace' public field into
19703 NameSpaceEntry NameSpaceEntry.
19705 (LookupInterfaceOrClass): Avoid creating a full qualified name
19706 from namespace and name: avoid doing lookups when we know the
19707 namespace is non-existant. Use new Tree.LookupByNamespace which
19708 looks up DeclSpaces based on their namespace, name pair.
19710 * driver.cs: Provide a new `parser verbose' to display the
19711 exception thrown during parsing. This is turned off by default
19712 now, so the output of a failure from mcs is more graceful.
19714 * namespace.cs: Track all the namespaces defined in a hashtable
19717 (IsNamespace): New method
19719 2003-08-09 Miguel de Icaza <miguel@ximian.com>
19721 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
19722 we know that we need to concatenate (full typename can never be
19727 * statement.cs: Use a bitfield; Do not initialize to null things
19728 which are done by the constructor by default.
19730 * cs-parser.jay: bug fix, parameter was 4, not 3.
19732 * expression.cs: Just use the property;
19734 * statement.cs: No need for GetVariableInfo method.
19736 2003-08-08 Martin Baulig <martin@ximian.com>
19738 * flowanalysis.cs (FlowReturns): This is now nested in the
19739 `FlowBranching' class.
19740 (MyBitVector): Moved this here from statement.cs.
19741 (FlowBranching.SiblingType): New enum type.
19742 (FlowBranching.CreateSibling): Added `SiblingType' argument.
19744 2003-08-07 Martin Baulig <martin@ximian.com>
19746 * flowanalysis.cs (FlowBranchingType): This is now nested in the
19747 `FlowBranching' class and called `BranchingType'.
19749 2003-08-07 Martin Baulig <martin@ximian.com>
19751 * flowanalysis.cs: Moved all the control flow analysis code into
19754 2003-08-07 Martin Baulig <martin@ximian.com>
19756 * assign.cs (Assign.DoResolve): `target' must either be an
19757 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
19760 2003-08-07 Miguel de Icaza <miguel@ximian.com>
19762 * expression.cs (BinaryMethod): This kind of expression is created by the
19763 Binary class if it determines that the operator has to be handled
19766 (BinaryDelegate): This kind of expression is created if we are
19767 dealing with a + or - operator on delegates.
19769 (Binary): remove method, argumetns, and DelegateOperator: when
19770 dealing with methods,
19772 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
19774 * statement.cs (Block): use bitfields for the three extra booleans
19775 we had in use. Remove unused topblock parameter.
19777 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
19779 * assign.cs: Drop extra unneeded tests.
19781 2003-08-06 Miguel de Icaza <miguel@ximian.com>
19783 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
19785 * statement.cs (Foreach): Use VariableStorage instead of
19788 * codegen.cs (VariableStorage): New class used by clients that
19789 require a variable stored: locals or fields for variables that
19790 need to live across yield.
19792 Maybe provide a convenience api for EmitThis+EmitLoad?
19794 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
19797 2003-08-05 Miguel de Icaza <miguel@ximian.com>
19799 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
19800 RemapParameterLValue): New methods that are used to turn a
19801 precomputed FieldInfo into an expression like this:
19805 The idea is to use this instead of making LocalVariableReference
19806 have more than one meaning.
19808 * cs-parser.jay: Add error production to BASE.
19810 * ecore.cs: Deal with TypeManager.GetField returning null, which
19811 is now a valid return value.
19813 (FieldExprNoAddress): New expression for Fields whose address can
19816 * expression.cs (LocalVariableReference): During the resolve
19817 phases, create new expressions if we are in a remapping context.
19818 Remove code that dealt with remapping here.
19820 (ParameterReference): same.
19822 (ProxyInstance): New expression, like the `This' expression, but
19823 it is born fully resolved. We know what we are doing, so remove
19824 the errors that are targeted to user-provided uses of `this'.
19826 * statement.cs (Foreach): our variable is now stored as an
19827 Expression; During resolution, follow the protocol, dont just
19828 assume it will return this.
19830 2003-08-06 Martin Baulig <martin@ximian.com>
19832 * support.cs (SeekableStreamReader.cs): New public class.
19834 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
19835 SeekableStreamReader instead of the normal StreamReader.
19837 2003-08-04 Martin Baulig <martin@ximian.com>
19839 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
19840 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
19841 deambiguate casts and delegate invocations.
19842 (parenthesized_expression): Use the new tokens to ensure this is
19843 not a cast of method invocation.
19845 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
19846 when reading a `)' and Deambiguate_CloseParens () was previously
19849 * expression.cs (ParenthesizedExpression): New class. This is
19850 just used for the CS0075 test.
19851 (Binary.DoResolve): Check for CS0075.
19853 2003-07-29 Ravi Pratap <ravi@ximian.com>
19855 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
19856 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
19857 reference comparison.
19859 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
19860 examine the ReturnType for equality - this is necessary in the
19861 cases of implicit and explicit operators whose signature also
19862 includes the return type.
19864 2003-07-26 Miguel de Icaza <miguel@ximian.com>
19866 * namespace.cs: Cache the result of the namespace computation,
19867 instead of computing it every time.
19869 2003-07-24 Miguel de Icaza <miguel@ximian.com>
19871 * decl.cs: Use a global arraylist that we reuse over invocations
19872 to avoid excesive memory consumption. Reduces memory usage on an
19873 mcs compile by one meg (45 average).
19875 * typemanager.cs (LookupTypeReflection): In .NET pointers are
19876 private, work around that.
19878 2003-07-23 Miguel de Icaza <miguel@ximian.com>
19880 * literal.cs (IntLiteral): Define Zero and One static literals.
19882 * cs-parser.jay (integer_literal): use static literals to reduce
19883 memory usage for the most used literals (0, 1 and -1). 211kb
19884 reduced in memory usage.
19886 Replace all calls to `new ArrayList' with `new
19887 ArrayList(4)' which is a good average number for most allocations,
19888 and also requires only 16 bytes of memory for its buffer by
19891 This reduced MCS memory usage in seven megabytes for the RSS after
19894 2003-07-28 Ravi Pratap <ravi@ximian.com>
19896 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
19897 handle params methods the correct way by forming only one
19898 applicable set with params and normal methods in them. Earlier we
19899 were looking at params methods only if we found no normal methods
19900 which was not the correct thing to do.
19902 (Invocation.BetterFunction): Take separate arguments indicating
19903 when candidate and the best method are params methods in their
19906 This fixes bugs #43367 and #46199.
19908 * attribute.cs: Documentation updates.
19910 (CheckAttribute): Rename to CheckAttributeTarget.
19911 (GetValidPlaces): Rename to GetValidTargets.
19913 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
19914 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
19918 2003-07-28 Martin Baulig <martin@ximian.com>
19920 * class.cs (TypeContainer.DefineMembers): Use the base type's full
19921 name when looking up the base class of a nested class. Fixes #46977.
19923 2003-07-26 Martin Baulig <martin@ximian.com>
19925 * expression.cs (Indexers.Indexer): New nested struct; contains
19926 getter, setter and the indexer's type.
19927 (Indexers.Properties): This is now an ArrayList of
19928 Indexers.Indexer's.
19929 (IndexerAccess.DoResolveLValue): Correctly set the type if the
19930 indexer doesn't have any getters.
19932 * assign.cs (Assign.DoResolve): Also do the implicit conversions
19933 for embedded property and indexer assignments.
19935 2003-07-26 Martin Baulig <martin@ximian.com>
19937 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
19938 preprocessor directive is not the first non-whitespace character
19941 2003-07-26 Martin Baulig <martin@ximian.com>
19943 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
19944 namespace parsing, follow the spec more closely.
19946 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
19947 NamespaceEntry.Lookup().
19949 2003-07-25 Martin Baulig <martin@ximian.com>
19951 * MethodCore.cs (OverridesSomething): New public field; it's set
19952 from TypeContainer.DefineMembers if this method overrides
19953 something (which doesn't need to be a method). Fix #39462.
19955 2003-07-25 Ravi Pratap <ravi@ximian.com>
19957 * typemanager.cs (GetMembers): Ensure that the list of members is
19958 reversed. This keeps things in sync.
19960 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
19961 find an AttributeUsage attribute.
19963 * expression.cs (Invocation.OverloadResolve): Perform the check
19964 which disallows Invoke to be directly called on a Delegate.
19966 (Error_InvokeOnDelegate): Report error cs1533.
19968 2003-07-25 Martin Baulig <martin@ximian.com>
19970 * expression.cs (Indexers.GetIndexersForType): Only look in the
19971 interface hierarchy if the requested type is already an
19972 interface. Fixes #46788 while keeping #46502 fixed.
19974 2003-07-25 Martin Baulig <martin@ximian.com>
19976 * class.cs (TypeContainer.DefineMembers): Check whether all
19977 readonly fields have been assigned and report warning CS0649 if
19980 * statement.cs (LocalInfo.IsFixed): Always return true if this is
19983 2003-07-24 Ravi Pratap <ravi@ximian.com>
19985 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
19986 returned from GetMethods to make things consistent with the
19987 assumptions MCS makes about ordering of methods.
19989 This should comprehensively fix bug #45127 and it does :-)
19991 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
19992 ordering is actually reverse.
19994 * Clean up some debug messages I left lying around.
19996 * interface.cs (Populate*): Get rid of code which emits attributes
19997 since the stage in which we emit attributes is the 'Emit' stage,
19998 not the define stage.
20000 (Emit): Move attribute emission for interface members here.
20002 2003-07-22 Ravi Pratap <ravi@ximian.com>
20004 * expression.cs (Invocation.OverloadResolve): Follow the spec more
20005 closely: we eliminate methods in base types when we have an
20006 applicable method in a top-level type.
20008 Please see section 14.5.5.1 for an exact description of what goes
20011 This fixes bug #45127 and a host of other related to corlib compilation.
20013 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
20014 array is the method corresponding to the top-level type (this is
20015 because of the changes made to icall.c) so we change this
20018 (MethodGroupExpr.Name): This too.
20020 * typemanager.cs (GetElementType): New method which does the right
20021 thing when compiling corlib.
20023 * everywhere: Make use of the above in the relevant places.
20025 2003-07-22 Martin Baulig <martin@ximian.com>
20027 * cs-parser.jay (invocation_expression): Moved
20028 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
20029 `cast_expression', but create a InvocationOrCast which later
20030 resolves to either an Invocation or a Cast.
20032 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
20033 method; call this before EmitStatement() to make sure that this
20034 expression can be used as a statement.
20036 * expression.cs (InvocationOrCast): New class; resolves to either
20037 an Invocation or a Cast.
20039 * statement.cs (StatementExpression): Call ResolveStatement() on
20040 the ExpressionStatement before emitting it.
20042 2003-07-21 Martin Baulig <martin@ximian.com>
20044 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
20045 `ref' and `out' attributes match; fixes #46220.
20046 (MemberAccess.ResolveMemberAccess): You can't reference a type
20047 through an expression; fixes #33180.
20048 (Indexers.GetIndexersForType): Don't return the indexers from
20049 interfaces the class implements; fixes #46502.
20051 2003-07-21 Martin Baulig <martin@ximian.com>
20053 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
20054 CS0661 checks; fixes bug #30442.
20056 2003-07-21 Martin Baulig <martin@ximian.com>
20058 * decl.cs (AdditionResult): Added `Error'.
20060 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
20062 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
20063 makes cs0031.cs actually work.
20065 2003-07-20 Martin Baulig <martin@ximian.com>
20067 * namespace.cs: Fixed that bug which caused a crash when compiling
20068 the debugger's GUI.
20070 2003-07-20 Miguel de Icaza <miguel@ximian.com>
20072 * typemanager.cs (LookupTypeReflection): Never expose types which
20073 are NotPublic, NestedPrivate, NestedAssembly, or
20074 NestedFamANDAssem. We used to return these, and later do a check
20075 that would report a meaningful error, but the problem is that we
20076 would not get the real match, if there was a name override.
20078 2003-07-18 Miguel de Icaza <miguel@ximian.com>
20080 * namespace.cs (Namespace, Name): Do not compute the namespace
20081 name dynamically, compute it in the constructor. This reduced
20082 memory usage by 1697 KB.
20084 * driver.cs: Use --pause to pause at the end.
20086 2003-07-17 Peter Williams <peter@newton.cx>
20088 * Makefile: Change the name of the test target so that it doesn't
20089 conflict with the recursive test target.
20091 2003-07-17 Miguel de Icaza <miguel@ximian.com>
20093 * expression.cs (LocalVariableReference.Emit, EmitAssign,
20094 AddressOf): Do not use EmitThis, that was wrong, use the actual
20097 2003-07-15 Miguel de Icaza <miguel@ximian.com>
20099 * class.cs (MethodData.Define): While checking if a method is an
20100 interface implementation, improve the test: If we are not public
20101 (use new test here: use the computed MethodAttributes directly,
20102 instead of the parsed modifier flags) check if the `implementing'
20103 method comes from an interface or not.
20105 * pending.cs (VerifyPendingMethods): Slightly better error
20108 * makefile: add test target that does the mcs bootstrap.
20110 2003-07-16 Ravi Pratap <ravi@ximian.com>
20112 * interface.cs (Define): Do nothing here since there are no
20113 members to populate etc. Move the attribute emission out of here
20114 since this was just totally the wrong place to put it. Attribute
20115 application happens during the 'Emit' phase, not in the 'Define'
20118 (Emit): Add this method and move the attribute emission here
20120 * rootcontext.cs (EmitCode): Call the Emit method on interface
20123 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20125 * expression.cs (OverloadResolve): Report error only if Location
20126 is not 'Null' which means that there was a probe going on.
20128 2003-07-14 Martin Baulig <martin@ximian.com>
20130 * expression.cs (ConditionalLogicalOperator): New public class to
20131 implement user defined conditional logical operators.
20132 This is section 14.11.2 in the spec and bug #40505.
20134 2003-07-14 Martin Baulig <martin@ximian.com>
20136 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
20138 2003-07-14 Martin Baulig <martin@ximian.com>
20140 * codegen.cs (EmitContext.InFixedInitializer): New public field.
20142 * ecore.cs (IVariable.VerifyFixed): New interface method.
20144 * expression.cs (Unary.ResolveOperator): When resolving the `&'
20145 operator, check whether the variable is actually fixed. Fixes bug
20146 #36055. Set a variable definitely assigned when taking its
20147 address as required by the spec.
20149 * statement.cs (LocalInfo.IsFixed): New field.
20150 (LocalInfo.MakePinned): Set `IsFixed' to true.
20152 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20154 * attribute.cs (Attribute.Resolve): While doing a Member lookup
20155 for .ctors, ensure that we only ask for members declared in the
20156 attribute type (BindingFlags.DeclaredOnly).
20160 * expression.cs (Error_WrongNumArguments): Report error 1501
20161 correctly the way CSC does.
20163 2003-07-13 Martin Baulig <martin@ximian.com>
20165 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
20166 lookup on the fully qualified name, to make things like "X.X" work
20167 where "X.X" is a fully qualified type name, but we also have a
20168 namespace "X" in the using list. Fixes #41975.
20170 2003-07-13 Martin Baulig <martin@ximian.com>
20172 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
20173 function. If we're a CompoundAssign, we need to create an embedded
20174 CompoundAssign, not an embedded Assign.
20175 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
20178 2003-07-13 Martin Baulig <martin@ximian.com>
20180 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
20181 work to fix bug #46088.
20183 2003-07-13 Ravi Pratap <ravi@ximian.com>
20185 * class.cs (Operator.Emit): Do not emit attributes here - it is
20186 taken care of by the Method class that we delegate too. This takes
20187 care of bug #45876.
20189 2003-07-10 Martin Baulig <martin@ximian.com>
20191 * expression.cs (TypeOfVoid): New class.
20192 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
20194 2003-07-10 Martin Baulig <martin@ximian.com>
20196 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
20199 2003-07-10 Martin Baulig <martin@ximian.com>
20201 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
20202 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
20204 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
20206 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
20208 2003-07-10 Martin Baulig <martin@ximian.com>
20210 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
20211 of decimal. Fixes #42850.
20213 NOTE: I also fixed the created byte blob, but this doesn't work on
20214 the MS runtime and csc never produces any byte blobs for decimal
20217 2003-07-10 Martin Baulig <martin@ximian.com>
20219 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
20220 structs; fixes #32068.
20221 (Block.AddChildVariableNames): Fixed #44302.
20223 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20225 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
20227 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20229 * attribute.cs: And this test is onger needed.
20231 2003-07-08 Martin Baulig <martin@ximian.com>
20233 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
20234 inaccessible types. Fixes #36313.
20236 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
20238 * namespace.cs (NamespaceEntry): Create implicit entries for all
20239 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
20240 implicit entries for N1.N2 and N1.
20242 2003-07-08 Martin Baulig <martin@ximian.com>
20244 Rewrote the handling of namespaces to fix a lot of the issues
20245 wrt. `using' aliases etc.
20247 * namespace.cs (Namespace): Splitted this class into a
20248 per-assembly `Namespace' and a per-file `NamespaceEntry'.
20250 * typemanager.cs (TypeManager.IsNamespace): Removed.
20251 (TypeManager.ComputeNamespaces): Only compute namespaces from
20252 loaded assemblies here, not the namespaces from the assembly we're
20253 currently compiling.
20255 2003-07-08 Martin Baulig <martin@ximian.com>
20257 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
20259 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20261 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
20264 I thought about the memory savings here, but LookupTypeReflection
20265 is used under already very constrained scenarios. Compiling
20266 corlib or mcs only exposes one hit, so it would not really reduce
20267 any memory consumption.
20269 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20271 * typemanager.cs: fixes bug #45889 by only adding public types from
20272 other assemblies to the list of known types.
20274 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20276 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
20277 on the type we resolved.
20279 2003-07-05 Martin Baulig <martin@ximian.com>
20281 * pending.cs (PendingImplementation.ParentImplements): Don't
20282 create the proxy if the parent is abstract.
20284 * class.cs (TypeContainer.DefineIndexers): Process explicit
20285 interface implementations first. Fixes #37714.
20287 2003-07-04 Miguel de Icaza <miguel@ximian.com>
20289 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
20290 defined recursively; but since we modify the input parameters
20291 (left is set to `this' temporarily), we reset this value if the
20292 left_is_explicit is false, which gives the original semantics to
20295 * literal.cs (NullPointer): new class used to represent a null
20296 literal in a pointer context.
20298 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
20299 type is a pointer, use a NullPointer object instead of a
20300 NullLiteral. Closes 43687
20302 (ExplicitConversion): Convert pointer values using
20303 the conv opcode to the proper type.
20305 * ecore.cs (New): change ValueTypeVariable property into a method,
20306 that returns whether the valuetype is suitable for being used.
20308 * expression.cs (Binary.DoNumericPromotions): Only return if we
20309 the int constant was a valid uint, and we can return both left and
20310 right as uints. If not, we continue processing, to trigger the
20311 type conversion. This fixes 39018.
20313 * statement.cs (Block.EmitMeta): During constant resolution, set
20314 the CurrentBlock property on the emitcontext, so that we resolve
20315 constants propertly.
20317 2003-07-02 Martin Baulig <martin@ximian.com>
20319 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
20320 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
20322 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
20323 than emitting it here.
20325 * statement.cs: Fixed some more flow analysis bugs.
20327 2003-07-02 Martin Baulig <martin@ximian.com>
20329 * class.cs (MethodData.Define): When implementing interface
20330 methods, set Final unless we're Virtual.
20332 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
20333 check work for interface methods.
20335 2003-07-01 Martin Baulig <martin@ximian.com>
20337 * ecore.cs (EmitContext.This): Replaced this property with a
20338 GetThis() method which takes a Location argument. This ensures
20339 that we get the correct error location for a CS0188.
20341 2003-07-01 Miguel de Icaza <miguel@ximian.com>
20343 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
20344 ImplicitStandardConversion.
20346 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
20348 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
20350 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
20353 2003-06-30 Miguel de Icaza <miguel@ximian.com>
20355 * class.cs (Constructor.Define): Turn off initlocals for unsafe
20358 (MethodData.Define): Turn off initlocals for unsafe methods.
20360 2003-06-29 Miguel de Icaza <miguel@ximian.com>
20362 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
20363 complete; Fixes #37521.
20365 * delegate.cs: Use Modifiers.TypeAttr to compute the
20366 TypeAttributes, instead of rolling our own. This makes the flags
20367 correct for the delegates.
20369 2003-06-28 Miguel de Icaza <miguel@ximian.com>
20371 * class.cs (Constructor.Define): Set the private flag for static
20372 constructors as well.
20374 * cs-parser.jay (statement_expression): Set the return value to
20375 null, to avoid a crash when we catch an error.
20377 2003-06-24 Miguel de Icaza <miguel@ximian.com>
20379 * cs-parser.jay: Applied patch from Jackson that adds support for
20380 extern and unsafe modifiers to destructor declarations.
20382 * expression.cs: Report error 21 if the user is trying to index a
20385 * driver.cs: Add an error message, suggested by the bug report.
20387 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
20388 if we do not have a ": this ()" constructor initializer. Fixes 45149
20390 2003-06-14 Miguel de Icaza <miguel@ximian.com>
20392 * namespace.cs: Add some information to reduce FAQs.
20394 2003-06-13 Miguel de Icaza <miguel@ximian.com>
20396 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
20397 underlying enumeration types. Fixes #43915.
20399 * expression.cs: Treat ushort/short as legal values to be used in
20400 bitwise operations.
20402 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
20404 * delegate.cs: transfer custom attributes for paramenters from
20405 the delegate declaration to Invoke and BeginInvoke.
20407 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
20409 * attribute.cs: handle custom marshalers and emit marshal info
20412 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
20414 * makefile.gnu: Added anonymous.cs to the compiler sources.
20416 2003-05-28 Miguel de Icaza <miguel@ximian.com>
20418 * iterators.cs: Change the name of the proxy class to include two
20421 * cs-parser.jay: Update grammar to include anonymous methods.
20423 * anonymous.cs: new file.
20425 2003-05-27 Miguel de Icaza <miguel@ximian.com>
20427 * class.cs (Field.Define): Add missing test for pointers and
20430 2003-05-27 Ravi Pratap <ravi@ximian.com>
20432 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
20433 we use the stobj opcode.
20435 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
20436 since it wasn't the correct fix.
20438 It still is puzzling that we are required to use stobj for IntPtr
20439 which seems to be a ValueType.
20441 2003-05-26 Miguel de Icaza <miguel@ximian.com>
20443 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
20444 during regular simple name resolution. Now, the trick is that
20445 instead of returning for processing the simplename, we do a
20446 TypeManager.LookupType (ie, a rooted lookup as opposed to a
20447 contextual lookup type). If a match is found, return that, if
20448 not, return for further composition.
20450 This fixes long-standing 30485.
20452 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20453 using the address to initialize an object, do an Stobj instead of
20454 using the regular Stelem.
20456 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
20457 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
20458 Because if we are a BaseIndexerAccess that value will be true.
20461 * statement.cs (GotoCase.Resolve): Return after reporting an
20462 error, do not attempt to continue.
20464 * expression.cs (PointerArithmetic.Emit): If our operand is a
20465 long, convert our constants to match the operand before
20466 multiplying. Convert to I type before adding. Fixes 43670.
20468 2003-05-14 Ravi Pratap <ravi@ximian.com>
20470 * enum.cs (ImplicitConversionExists) : Rename to
20471 ImplicitEnumConversionExists to remove ambiguity.
20473 * ecore.cs (NullCast): New type of cast expression class which
20474 basically is very similar to EmptyCast with the difference being
20475 it still is a constant since it is used only to cast a null to
20477 (eg. (string) null)
20479 * convert.cs (ImplicitReferenceConversion): When casting a null
20480 literal, we return a NullCast.
20482 * literal.cs (NullLiteralTyped): Remove - I don't see why this
20483 should be around anymore.
20485 The renaming (reported was slightly wrong). Corrections:
20487 ConvertImplicitStandard -> ImplicitConversionStandard
20488 ConvertExplicitStandard -> ExplicitConversionStandard
20490 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
20491 before passing them in !
20493 * convert.cs (ImplicitConversionStandard): When comparing for
20494 equal expr and target types, ensure that expr is not a
20497 In general, we must not be checking (expr_type ==
20498 target_type) in the top level conversion methods
20499 (ImplicitConversion, ExplicitConversion etc). This checking is
20500 done in the methods that they delegate to.
20502 2003-05-20 Miguel de Icaza <miguel@ximian.com>
20504 * convert.cs: Move Error_CannotConvertType,
20505 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
20506 ImplicitNumericConversion, ImplicitConversionExists,
20507 ImplicitUserConversionExists, StandardConversionExists,
20508 FindMostEncompassedType, FindMostSpecificSource,
20509 FindMostSpecificTarget, ImplicitUserConversion,
20510 ExplicitUserConversion, GetConversionOperators,
20511 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
20512 TryImplicitIntConversion, Error_CannotConvertImplicit,
20513 ConvertImplicitRequired, ConvertNumericExplicit,
20514 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
20515 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
20518 Perform the following renames:
20520 StandardConversionExists -> ImplicitStandardConversionExists
20521 ConvertImplicit -> ImplicitConversion
20522 ConvertImplicitStandard -> ImplicitStandardConversion
20523 TryImplicitIntConversion -> ImplicitIntConversion
20524 ConvertImplicitRequired -> ImplicitConversionRequired
20525 ConvertNumericExplicit -> ExplicitNumericConversion
20526 ConvertReferenceExplicit -> ExplicitReferenceConversion
20527 ConvertExplicit -> ExplicitConversion
20528 ConvertExplicitStandard -> ExplicitStandardConversion
20530 2003-05-19 Martin Baulig <martin@ximian.com>
20532 * statement.cs (TypeInfo.StructInfo): Made this type protected.
20533 (TypeInfo): Added support for structs having structs as fields.
20535 * ecore.cs (FieldExpr): Implement IVariable.
20536 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
20537 VariableInfo for the field.
20539 2003-05-18 Martin Baulig <martin@ximian.com>
20541 * expression.cs (This.DoResolve): Report a CS0027 if we're
20542 emitting a field initializer.
20544 2003-05-18 Martin Baulig <martin@ximian.com>
20546 * expression.cs (This.ResolveBase): New public function.
20547 (This.DoResolve): Check for CS0188.
20549 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
20552 * ecore.cs (MethodGroupExpr.DoResolve): Set the
20553 `instance_expression' to null if we don't have any non-static
20556 2003-05-18 Martin Baulig <martin@ximian.com>
20558 Reworked the way how local variables and parameters are handled by
20559 the flow analysis code.
20561 * statement.cs (TypeInfo, VariableMap): New public classes.
20562 (VariableInfo): New public class. This is now responsible for
20563 checking whether a variable has been assigned. It is used for
20564 parameters and local variables.
20565 (Block.EmitMeta): Take the InternalParameters as argument; compute
20566 the layout of the flow vectors here.
20567 (Block.LocalMap, Block.ParameterMap): New public properties.
20568 (FlowBranching): The .ctor doesn't get the InternalParameters
20569 anymore since Block.EmitMeta() now computes the layout of the flow
20571 (MyStructInfo): This class is now known as `StructInfo' and nested
20572 in `TypeInfo'; we don't access this directly anymore.
20574 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
20575 property and removed IsAssigned(), IsFieldAssigned(),
20576 SetAssigned() and SetFieldAssigned(); we now call them on the
20577 VariableInfo so we don't need to duplicate this code everywhere.
20579 * expression.cs (ParameterReference): Added `Block block' argument
20581 (LocalVariableReference, ParameterReference, This): The new
20582 VariableInfo class is now responsible for all the definite
20585 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
20586 IsParameterAssigned, SetParameterAssigned): Removed.
20588 2003-05-18 Martin Baulig <martin@ximian.com>
20590 * typemanager.cs (InitCoreTypes): Try calling
20591 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
20592 the 3-args-version. Corlib now also needs our `void_type'.
20593 (GetMethod): Added overloaded version which takes an optional
20594 `bool report_errors' to allow lookups of optional methods.
20596 2003-05-12 Martin Baulig <martin@ximian.com>
20598 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
20599 only used for locals and not for parameters.
20601 2003-05-12 Miguel de Icaza <miguel@ximian.com>
20603 * support.cs (InternalParameters.ParameterType): Return the
20604 ExternalType of the parameter.
20606 * parameter.cs (Parameter.ExternalType): drop the two arguments,
20609 2003-05-11 Miguel de Icaza <miguel@ximian.com>
20611 * class.cs (MethodData.Define): Do not set the `newslot' on
20612 interface members, if they are also flagged as "override".
20614 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
20615 better code for ++i and i++. This only works for static fields
20616 and local variables.
20618 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
20619 want to pull the DeclSpace out of the builder_to_declspace instead
20620 of the TypeBuilder (like in TypeContainer.FindMembers).
20622 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
20623 instead of LookupTypeContainer. Fixes the crash on .NET for
20624 looking up interface members.
20626 * const.cs: Create our own emit context during the Definition
20627 stage, so that constants are evaluated in the proper context, when
20628 a recursive definition happens.
20630 2003-05-11 Martin Baulig <martin@ximian.com>
20632 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
20633 new block for a switch section.
20634 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
20635 the adding/lookup in the switch block. Fixes #39828.
20637 2003-05-09 Miguel de Icaza <miguel@ximian.com>
20639 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
20640 functionality: I needed to convert the data after I had performed
20641 the add/sub operation into the operands type size.
20643 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
20644 pass the type for the box operation, otherwise the resulting
20645 object would have been of type object.
20647 (BoxedCast): Add constructor to specify the type to box as.
20649 2003-05-07 Miguel de Icaza <miguel@ximian.com>
20651 * iterators.cs: I was reusing the `count' variable inadvertently,
20652 take steps to not allow this to happen.
20654 2003-05-06 Miguel de Icaza <miguel@ximian.com>
20656 * attribute.cs (Attribute.Resolve): Params attributes are encoded
20657 by creating an array at the point where the params starts and
20658 putting all those arguments there, then adjusting the size of the
20661 2003-05-05 Miguel de Icaza <miguel@ximian.com>
20663 * expression.cs (New.AddressOf): Implement interface
20664 IMemoryLocation. This is used when the `new' operator is used in
20665 the context of an invocation to a method on a value type.
20667 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
20670 * namespace.cs: Also check the using aliases here.
20672 * driver.cs: Move the test for using validity after the types have
20673 been entered, so we do a single pass that also includes the using
20676 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
20677 in the regular case. CreateSiblingForFinally is doing extra
20680 * attribute.cs (GetAttributeArgumentExpression): Store the result
20681 on an out value, and use the return value to indicate failure
20682 instead of using null (which is a valid return for Constant.GetValue).
20684 * statement.cs: Perform the analysis flow for the increment
20685 portion after the statement, because this will be the real flow of
20686 execution. Fixes #42385
20688 * codegen.cs (EmitContext.EmitArgument,
20689 EmitContext.EmitStoreArgument): New helper functions when the
20690 RemapToProxy flag is set.
20692 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
20695 Add support for remapping parameters.
20697 * iterators.cs: Propagate parameter values; Store parameter
20698 values in the proxy classes.
20700 2003-05-04 Miguel de Icaza <miguel@ximian.com>
20702 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
20703 need a proxy reference; I do not know what I was thinking
20705 * cs-parser.jay (constructor_initializer): catch another error,
20706 and display nice message.
20708 (field_declaration): catch void field declaration
20709 to flag a better error.
20711 * class.cs (MemberBase.CheckBase): Report an error instead of a
20712 warning if a new protected member is declared in a struct.
20713 (Field.Define): catch the error of readonly/volatile.
20715 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
20717 (FieldExpr.AddressOf): ditto. Catch error where the address of a
20718 volatile variable is taken
20720 2003-05-02 Miguel de Icaza <miguel@ximian.com>
20722 * statement.cs (Fixed.Resolve): Report an error if we are not in
20725 2003-05-01 Miguel de Icaza <miguel@ximian.com>
20727 * typemanager.cs: reuse the code that handles type clashes for
20728 delegates and enumerations.
20730 * class.cs (Report28): Always report.
20732 * expression.cs (EncodeAsAttribute): Allow nulls here.
20734 2003-04-28 Miguel de Icaza <miguel@ximian.com>
20736 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
20737 the functionality for testing whether an expression is valid for
20738 an attribute here. Also handle the case of arrays of elements
20741 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
20742 encoding a linear array into an array of objects that are suitable
20743 to be passed to an CustomAttributeBuilder.
20745 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
20747 * ecore.cs: (FieldExpr): Handle field remapping here.
20749 * iteratators.cs: Pass the instance variable (if the method is an
20750 instance method) to the constructors, so we can access the field
20751 variables on the class.
20753 TODO: Test this with structs. I think the THIS variable on
20754 structs might have to be a pointer, and not a refenrece
20756 2003-04-27 Miguel de Icaza <miguel@ximian.com>
20758 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
20759 local variables to fields in a proxy class.
20761 * iterators.cs (PopulateProxy): Rename our internal fields to
20763 Create a <THIS> field if we are an instance method, so we can
20764 reference our parent container variables.
20765 (MapVariable): Called back from the EmitContext code to enter a
20766 new variable to field mapping into the proxy class (we just create
20770 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
20771 for using the remapped locals to fields.
20773 I placed the code here, because that gives the same semantics to
20774 local variables, and only changes the Emit code.
20776 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
20777 statements inside iterators.
20778 (VariableInfo): Add a FieldBuilder for the cases when we are
20779 remapping local variables to fields in a proxy class
20781 * ecore.cs (SimpleNameResolve): Avoid testing two times for
20782 current_block != null.
20784 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
20785 not cope with strings, as it has been moved to the
20786 TableSwitchEmit. Fixed bug in switch generation.
20788 * expression.cs (New.DoResolve): Provide more context for the user
20789 when reporting an error.
20791 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
20794 * expression.cs (MemberAccess.DoResolve): When we get a type back,
20795 check the permissions for it. Note than in a type-resolution
20796 context the check was already present in DeclSpace.ResolveType,
20797 but was missing from the MemberAccess.
20799 (ArrayCreation.CheckIndices): warn if the user has
20800 more nested levels of expressions, but there are no more
20801 dimensions specified. Avoids crash on bug 41906.
20803 2003-04-26 Miguel de Icaza <miguel@ximian.com>
20805 * statement.cs (Block): replace Implicit bool, for a generic
20807 New flag: `Unchecked'. This is used during the EmitMeta phase
20808 (which is out-of-line with the regular Resolve/Emit process for a
20809 statement, as this is done ahead of time, but still gets a chance
20810 to call constant resolve).
20812 (Block.Flags): new enum for adding a new flag.
20814 (Block.EmitMeta): track the state of unchecked.
20816 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
20817 to enable constant resolution to work there as well.
20819 2003-04-22 Miguel de Icaza <miguel@ximian.com>
20821 * typemanager.cs (ienumerable_type): Also look up
20822 System.Collections.IEnumerable.
20824 2003-04-21 Miguel de Icaza <miguel@ximian.com>
20826 TODO: Test more than one conditional per method.
20828 * class.cs (Indexer.Define): Report the location where the user is
20829 referencing the unsupported feature.
20831 (MethodData): Overload the use of `conditionals' to
20832 minimize the creation of needless ArrayLists. This saves roughly
20833 212kb on my machine.
20835 (Method): Implement the new IIteratorContainer interface.
20836 (Method.SetYields): Implement the method by setting the ModFlags
20837 to contain METHOD_YIELDS.
20839 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
20840 which just got set to null.
20842 * iterators.cs: New file.
20844 (Yield, YieldBreak): New statements.
20846 * statement.cs (Return.Resolve): Flag an error if we are used in
20847 an iterator method.
20849 * codegen.cs (InIterator): New flag set if the code is being
20850 compiled in an iterator method.
20852 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
20853 internal modifier, and we just use it to avoid adding extra
20854 fields, as this is seldom used.
20856 * cs-parser.jay: Add yield_statement (yield and yield break).
20858 * driver.cs: New flag -v2 to turn on version 2 features.
20860 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
20861 hashtable when v2 is enabled.
20863 2003-04-20 Miguel de Icaza <miguel@ximian.com>
20865 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
20866 there is already a namespace defined with this name.
20868 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
20869 people upgraded their corlibs.
20871 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
20872 always use fully qualified types, no need to use the compiler
20875 (TypeManager.IsNamespace): Use binarysearch.
20877 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
20878 AddDelegate): I did not quite use the new IsValid API properly: I
20879 have to pass the short-name and the fullname. I was passing only
20880 the basename instead of the fullname sometimes.
20882 (TypeContainer.DefineType): call NamespaceClash.
20884 * interface.cs (Interface.DefineType): use NamespaceClash before
20887 * delegate.cs (Delegate.DefineType): use NamespaceClash before
20890 * enum.cs: (Enum.DefineType): use NamespaceClash before
20893 * typemanager.cs (: 3-line patch that gives us some tasty 11%
20894 speed increase. First, use the negative_hits cache when we get a
20895 negative. Second, add the type with its full original name
20896 instead of the new . and + encoded name (reflection uses + to
20897 separate type from a nested type). Use LookupTypeReflection
20898 directly which bypasses the type->name hashtable (that we already
20899 know does not contain the type.
20901 * decl.cs (DeclSpace.ResolveTypeExpr): track the
20902 location/container type.
20904 * driver.cs: When passing utf8, use directly the UTF8Encoding.
20906 2003-04-19 Miguel de Icaza <miguel@ximian.com>
20908 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
20910 * delegate.cs (NewDelegate.Resolve): Test whether an instance
20911 method is being referenced in the method group from a static
20912 context, and report error 120 if so.
20914 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
20917 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
20918 is created, we create the A namespace).
20920 * cs-parser.jay: A namespace also introduces a DeclarationFound.
20923 2003-04-18 Miguel de Icaza <miguel@ximian.com>
20925 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
20926 invocation to ModuleBuilder.GetType with the same values will
20927 return a new type instance, so we need to cache its return
20930 * expression.cs (Binary.ResolveOperator): Only allow the compare
20931 operators on enums if they are of the same type.
20933 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
20934 types of ValueType on their own case. Before we were giving them
20935 the same treatment as objects.
20937 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
20938 fullname. Short name is used to compare against container name.
20939 Fullname is used to check against defined namespace names.
20941 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
20942 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
20944 (Method.CheckBase): Call parent.
20945 (MemberBase.CheckBase): Check for protected members on sealed
20947 (PropertyBase.CheckBase): Call parent.
20948 (Field.Define): Call parent.
20950 * report.cs: Negative error codes are now mapped to 8000 - code,
20951 so that the display is render more nicely.
20953 * typemanager.cs: Do not use try/catch, instead report a regular
20956 (GetPointerType, GetReferenceType): These methods provide
20957 mechanisms to obtain the T* and T& from a T. We had the code
20958 previously scattered around the code base, and it also used
20959 TypeManager.LookupType that would go through plenty of caches.
20960 This one goes directly to the type source.
20962 In some places we did the Type.GetType followed by
20963 ModuleBuilder.GetType, but not in others, so this unifies the
20964 processing as well.
20966 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
20967 statements now that we have namespace information.
20969 * typemanager.cs (IsNamespace): New method, returns whether the
20970 string presented is a namespace or not.
20972 (ComputeNamespaces): New public entry point, computes the list of
20973 available namespaces, using the GetNamespaces API call in Mono, or
20974 the slower version in MS.NET.
20976 Now before we start the semantic analysis phase, we have a
20977 complete list of namespaces including everything that the user has
20980 Deleted old code to cache namespaces in .nsc files.
20982 2003-04-17 Miguel de Icaza <miguel@ximian.com>
20984 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
20985 class/struct location definition Location for the implicit
20986 constructor location.
20988 (Operator.Define): Use the location of the operator for the
20989 implicit Method definition.
20991 (Constructor.Emit): use the constructor location for the implicit
20992 base initializer constructor.
20994 * ecore.cs: Remove ITypeExpression. This interface is now gone,
20995 and the Expression class now contains two new methods:
20997 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
20998 isolate type lookup from the rest of the resolution process.
21000 Since we use Expressions to hold type definitions due to the way
21001 we parse the input we have historically overloaded Resolve to
21002 perform the Type lookups if a special flag is passed. Now this is
21003 eliminated and two methods take their place.
21005 The differences in the two methods between xStep and xTerminal is
21006 that xStep is involved in our current lookup system that uses
21007 SimpleNames to compose a name, while xTerminal is used just to
21008 catch the case where the simplename lookup failed.
21010 2003-04-16 Miguel de Icaza <miguel@ximian.com>
21012 * expression.cs (ResolveMemberAccess): Remove redundant code.
21013 TypeExpr expressions are always born fully resolved.
21015 * interface.cs (PopulateMethod): Do not lookup the types twice.
21016 We were doing it once during SemanticAnalysis and once during
21019 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
21020 in local variable type definitions, were being returned as a
21021 SimpleName (we decomposed everything into a string), that is
21022 because primary_expression was being used instead of a type in the
21023 grammar (reduce/reduce conflicts).
21025 The part that was wrong is that we converted the expression into a
21026 string (an oversimplification in one hand, compounded with primary
21027 expressions doing string concatenation).
21033 Would return "A.B.C[]" as a SimpleName. This stopped things like
21034 using clauses from working on this particular context. And a type
21035 was being matched directly against "A.B.C[]".
21037 We now use the correct approach, and allow for ComposedCast to be
21038 part of the unary expression. So the "A.B.C []" become a composed
21039 cast of "A.B.C" (as a nested group of MemberAccess with a
21040 SimpleName at the end) plus the rank composition "[]".
21044 2003-04-10 Miguel de Icaza <miguel@ximian.com>
21046 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
21047 for the access level checking.
21049 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
21050 `TypeContainer container', because I kept getting confused when I
21051 was debugging this code.
21053 * expression.cs (Indexers): Instead of tracking getters/setters,
21054 we now track them in parallel. We create one arraylist less, but
21055 most importantly it is possible now for the LValue code to find a
21056 matching get for a set.
21058 (IndexerAccess.DoResolveLValue): Update the code.
21059 GetIndexersForType has been modified already to extract all the
21060 indexers from a type. The code assumed it did not.
21062 Also make the code set the correct return type for the indexer.
21063 This was fixed a long time ago for properties, but was missing for
21064 indexers. It used to be void_type.
21066 (Binary.Emit): Test first for doubles instead of
21067 floats, as they are more common.
21069 (Binary.EmitBranchable): Use the .un version of the branch opcodes
21070 when dealing with floats and the <=, >= operators. This fixes bug
21073 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
21074 to load the array value by emitting a load on the foreach variable
21075 type. This was incorrect.
21077 We now emit the code to load an element using the the array
21078 variable type, and then we emit the conversion operator.
21082 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
21084 * attribute.cs: Avoid allocation of ArrayLists in the common case.
21086 2003-04-09 Miguel de Icaza <miguel@ximian.com>
21088 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
21089 test for protection before we test for signatures.
21091 (MethodSignature.ToString): implement.
21093 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
21094 to the case where we reduced into a LongConstant.
21096 * decl.cs (CheckAccessLevel): If the type is an array, we can not
21097 depend on whether the information is acurrate, because the
21098 Microsoft runtime will always claim that the array type is public,
21099 regardless of the real state.
21101 If the type is a pointer, another problem happens: the type is
21102 reported as non-public in Microsoft.
21104 In both cases we have to call CheckAccessLevel recursively with
21105 the underlying type as the argument to be tested.
21107 2003-04-08 Miguel de Icaza <miguel@ximian.com>
21109 * assign.cs (Assign.Emit): If we are dealing with a compound
21110 assignment expression, we should use the code path that stores the
21111 intermediate result in a temporary value. This fixes #40903.
21113 *expression.cs (Indirection.ToString): Provide ToString method for
21116 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
21118 * class.cs: Null out fields holding references to Block objects so
21119 they can be garbage collected.
21121 * expression.cs (OverloadResolve): Remove unused local.
21123 2003-04-07 Martin Baulig <martin@ximian.com>
21125 * codegen.cs (EmitContext.CurrentFile): New public field.
21126 (EmitContext.Mark): Use the CurrentFile to check whether the
21127 location is in the correct file.
21128 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
21130 2003-04-07 Martin Baulig <martin@ximian.com>
21132 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
21134 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
21135 location. [FIXME: The location argument which gets passed to this
21136 method is sometimes wrong!]
21138 2003-04-07 Nick Drochak <ndrochak@gol.com>
21140 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
21142 2003-04-07 Miguel de Icaza <miguel@ximian.com>
21144 * expression.cs (Indirection.EmitAssign): We were using the
21145 temporary, but returning immediately instead of continuing the
21148 2003-04-06 Martin Baulig <martin@ximian.com>
21150 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
21151 if it's a nested child, but also deriving from the outer class.
21154 * typemanager.cs (IsNestedChildOf): Make this work if it's a
21155 nested child, but also deriving from the outer class. See
21157 (FilterWithClosure): We may access private members of the outer
21158 class if we're a nested child and deriving from the outer class.
21159 (RealMemberLookup): Only set `closure_private_ok' if the
21160 `original_bf' contained BindingFlags.NonPublic.
21162 2003-04-05 Martin Baulig <martin@ximian.com>
21164 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
21166 2003-04-02 Miguel de Icaza <miguel@ximian.com>
21168 * class.cs (Event.Define): Do not allow abstract events to have
21171 2003-04-01 Miguel de Icaza <miguel@ximian.com>
21173 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
21174 block in event declarations.
21176 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
21177 value type, get its address.
21179 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
21180 leaving a class on the stack instead of a boolean value (int
21181 0/1). Change the code so we compare against null, and then the
21182 result against zero.
21184 * class.cs (TypeContainer.GetClassBases): We were checking for the
21185 parent class being sealed too late.
21187 * expression.cs (Binary.Emit): For <= and >= when dealing with
21188 floating point values, use cgt.un and clt.un instead of cgt and
21191 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
21193 * statement.cs: Apply the same optimization as MS: skip the
21194 GetEnumerator returning an IEnumerator, and use the one returning a
21195 CharEnumerator instead. This allows us to avoid the try-finally block
21198 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
21200 * cs-parser.jay: Attributes cannot be applied to
21201 namespaces. Fixes #40473
21203 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21206 (Add*): check if the name is valid using the full name for constants,
21207 fields, properties and events.
21209 2003-03-28 Miguel de Icaza <miguel@ximian.com>
21211 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
21212 char constants to be part of the enumeration.
21214 * expression.cs (Conditional.DoResolve): Add support for operator
21215 true. Implements the missing functionality from 14.12
21217 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
21218 operator true/false as required by the spec.
21220 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
21221 implicit conversion to boolean.
21223 * statement.cs (Statement.ResolveBoolean): A boolean expression is
21224 also one where the type implements `operator true'.
21226 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
21227 get an expression that will invoke operator true based on an
21230 (GetConversionOperators): Removed the hack that called op_True
21233 (Expression.ResolveBoolean): Move this from Statement.
21235 2003-03-17 Miguel de Icaza <miguel@ximian.com>
21237 * ecore.cs (FieldExpr): do not allow initialization of initonly
21238 fields on derived classes
21240 2003-03-13 Martin Baulig <martin@ximian.com>
21242 * statement.cs (Block.Emit): Call ig.BeginScope() and
21243 ig.EndScope() when compiling with debugging info; call
21244 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
21246 2003-03-08 Miguel de Icaza <miguel@ximian.com>
21248 * expression.cs (Indexers): Do not construct immediately, allow
21249 for new members to be appended as we go. Fixes 38143
21251 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21253 * expression.cs: save/restore context when resolving an unchecked
21256 2003-03-05 Miguel de Icaza <miguel@ximian.com>
21258 * cfold.cs: Catch division by zero in modulus operator during
21261 2003-03-03 Miguel de Icaza <miguel@ximian.com>
21263 * interface.cs (Interface.DefineMembers): Avoid defining members
21266 2003-02-27 Miguel de Icaza <miguel@ximian.com>
21268 * driver.cs: handle the +/- options for -noconfig
21270 * statement.cs (Unckeched.Resolve): Also track the state of
21271 unchecked in the Resolve phase.
21273 2003-02-27 Martin Baulig <martin@ximian.com>
21275 * ecore.cs (Expression.MemberLookup): Don't create a
21276 MethodGroupExpr for something which is not a method. Fixes #38291.
21278 2003-02-25 Miguel de Icaza <miguel@ximian.com>
21280 * class.cs (MemberBase.CheckParameters): Also check that the type
21281 is unmanaged if it is a pointer.
21283 * expression.cs (SizeOf.Resolve): Add location information.
21285 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
21286 a managed type is declared.
21288 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
21289 parameter modifiers as well. Fixes bug 38606
21291 * class.cs: Very sad. Am backing out the speed up changes
21292 introduced by the ArrayList -> Array in the TypeContainer, as they
21293 were not actually that much faster, and introduced a bug (no error
21294 reports on duplicated methods).
21296 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
21297 source first, this will guarantee that we have a valid expression
21298 before calling in lower levels functions that will require a
21299 resolved object. Then use this original_source in the
21300 target.ResolveLValue instead of the original source that was
21303 Another change. Use target.Resolve instead of LValueResolve.
21304 Although we are resolving for LValues, we will let the Assign code
21305 take care of that (it will be called again from Resolve). This
21306 basically allows code like this:
21308 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
21309 class Y { void A (X x) { x [0] += o; }
21311 The problem was that the indexer was trying to resolve for
21312 set_Item (idx, object o) and never finding one. The real set_Item
21313 was set_Item (idx, X). By delaying the process we get the right
21318 2003-02-23 Martin Baulig <martin@ximian.com>
21320 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
21321 while calling DoEmit ().
21323 * codegen.cs (EmitContext.Mark): Don't mark locations in other
21324 source files; if you use the #line directive inside a method, the
21325 compiler stops emitting line numbers for the debugger until it
21326 reaches the end of the method or another #line directive which
21327 restores the original file.
21329 2003-02-23 Martin Baulig <martin@ximian.com>
21331 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
21333 2003-02-23 Martin Baulig <martin@ximian.com>
21335 * statement.cs (Block.AddChildVariableNames): We need to call this
21336 recursively, not just for our immediate children.
21338 2003-02-23 Martin Baulig <martin@ximian.com>
21340 * class.cs (Event.Define): Always make the field private, like csc does.
21342 * typemanager.cs (TypeManager.RealMemberLookup): Make events
21343 actually work, fixes bug #37521.
21345 2003-02-23 Miguel de Icaza <miguel@ximian.com>
21347 * delegate.cs: When creating the various temporary "Parameters"
21348 classes, make sure that we call the ComputeAndDefineParameterTypes
21349 on those new parameters (just like we do with the formal ones), to
21350 allow them to be resolved in the context of the DeclSpace.
21352 This fixes the bug that Dick observed in Bugzilla #38530.
21354 2003-02-22 Miguel de Icaza <miguel@ximian.com>
21356 * expression.cs (ResolveMemberAccess): When resolving a constant,
21357 do not attempt to pull a constant if the value was not able to
21358 generate a valid constant.
21360 * const.cs (LookupConstantValue): Do not report more errors than required.
21362 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21364 * expression.cs: fixes bug #38328.
21366 2003-02-18 Miguel de Icaza <miguel@ximian.com>
21368 * class.cs: Changed all the various members that can be part of a
21369 class from being an ArrayList to be an Array of the right type.
21370 During the DefineType type_list, interface_list, delegate_list and
21371 enum_list are turned into types, interfaces, delegates and enums
21374 And during the member population, indexer_list, event_list,
21375 constant_list, field_list, instance_constructor_list, method_list,
21376 operator_list and property_list are turned into their real arrays.
21378 Although we could probably perform this operation earlier, for
21379 good error reporting we need to keep the lists and remove the
21380 lists for longer than required.
21382 This optimization was triggered by Paolo profiling the compiler
21383 speed on the output of `gen-sample-program.pl' perl script.
21385 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
21386 not crash in methods like MemberLookupFailed that use this field.
21388 This problem arises when the compiler fails to resolve a type
21389 during interface type definition for example.
21391 2003-02-18 Miguel de Icaza <miguel@ximian.com>
21393 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
21394 inherit from System.Object, so we have to stop at null, not only
21395 when reaching System.Object.
21397 2003-02-17 Miguel de Icaza <miguel@ximian.com>
21399 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
21400 DeclaredOnly because the parent indexer might have had a different
21401 name, but did not loop until the top of the hierarchy was reached.
21403 The problem this one fixes is 35492: when a class implemented an
21404 indexer from an interface, we were getting the interface method
21405 (which was abstract) and we were flagging an error (can not invoke
21408 This also keeps bug 33089 functioning, and test-148 functioning.
21410 * typemanager.cs (IsSpecialMethod): The correct way of figuring
21411 out if a method is special is to see if it is declared in a
21412 property or event, or whether it is one of the predefined operator
21413 names. This should fix correctly #36804.
21415 2003-02-15 Miguel de Icaza <miguel@ximian.com>
21417 The goal here is to remove the dependency on EmptyCast.Peel ().
21418 Killing it completely.
21420 The problem is that currently in a number of places where
21421 constants are expected, we have to "probe" for an EmptyCast, and
21422 Peel, which is not the correct thing to do, as this will be
21423 repetitive and will likely lead to errors.
21425 The idea is to remove any EmptyCasts that are used in casts that
21426 can be reduced to constants, so we only have to cope with
21429 This bug hunt was triggered by Bug 37363 and the desire to remove
21430 the duplicate pattern where we were "peeling" emptycasts to check
21431 whether they were constants. Now constants will always be
21434 * ecore.cs: Use an enumconstant here instead of wrapping with
21437 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
21438 throwing me off. By handling this we can get rid of a few hacks.
21440 * statement.cs (Switch): Removed Peel() code.
21442 2003-02-14 Miguel de Icaza <miguel@ximian.com>
21444 * class.cs: Location information for error 508
21446 * expression.cs (New.DoResolve): Add a guard against double
21447 resolution of an expression.
21449 The New DoResolve might be called twice when initializing field
21450 expressions (see EmitFieldInitializers, the call to
21451 GetInitializerExpression will perform a resolve on the expression,
21452 and later the assign will trigger another resolution
21454 This leads to bugs (#37014)
21456 * delegate.cs: The signature for EndInvoke should contain any ref
21457 or out parameters as well. We were not doing this in the past.
21459 * class.cs (Field.Define): Do not overwrite the type definition
21460 inside the `volatile' group. Turns out that volatile enumerations
21461 were changing the type here to perform a validity test, which
21464 2003-02-12 Miguel de Icaza <miguel@ximian.com>
21466 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
21467 and structs, we do not want to load the instance variable
21469 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
21470 enum_type has to be handled like an object reference (implicit
21471 conversions exists from this to object), but the regular IsClass
21472 and IsValueType tests will never return true for this one.
21474 Also we use TypeManager.IsValueType instead of type.IsValueType,
21475 just for consistency with the rest of the code (this is only
21476 needed if we ever use the construct exposed by test-180.cs inside
21477 corlib, which we dont today).
21479 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
21481 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
21484 2003-02-09 Martin Baulig <martin@ximian.com>
21486 * namespace.cs (Namespace..ctor): Added SourceFile argument.
21487 (Namespace.DefineNamespaces): New static public method; this is
21488 called when we're compiling with debugging to add all namespaces
21489 to the symbol file.
21491 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
21492 pass it to the Namespace's .ctor.
21494 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
21495 and MethodBase arguments; pass the namespace ID to the symwriter;
21496 pass the MethodBase instead of the token to the symwriter.
21497 (SymbolWriter.DefineNamespace): New method to add a namespace to
21500 2003-02-09 Martin Baulig <martin@ximian.com>
21502 * symbolwriter.cs: New file. This is a wrapper around
21503 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
21504 methods here in near future.
21506 2003-02-09 Martin Baulig <martin@ximian.com>
21508 * codegen.cs (EmitContext.Mark): Just pass the arguments to
21509 ILGenerator.MarkSequencePoint() which are actually used by the
21512 2003-02-09 Martin Baulig <martin@ximian.com>
21514 * location.cs (SourceFile): New public sealed class. This
21515 contains the name and an index which is used in the location's token.
21516 (Location): Reserve an appropriate number of bits in the token for
21517 the source file instead of walking over that list, this gives us a
21518 really huge performance improvement when compiling with debugging.
21520 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
21521 `SourceFile' argument instead of a string.
21522 (Driver.ProcessFile): Add all the files via Location.AddFile(),
21523 but don't parse/tokenize here, we need to generate the list of all
21524 source files before we do that.
21525 (Driver.ProcessFiles): New static function. Parses/tokenizes all
21528 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
21529 instead of a string.
21531 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
21534 2003-02-09 Martin Baulig <martin@ximian.com>
21536 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
21537 filename on `#line default'.
21539 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
21541 * statement.cs: don't clear the pinned var when the fixed statement
21542 returns from the method (fixes bug#37752).
21544 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
21546 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
21549 2003-02-07 Martin Baulig <martin@ximian.com>
21551 * driver.cs: Removed the `--debug-args' command line argument.
21553 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
21554 automatically by the AsssemblyBuilder.
21555 (CodeGen.InitializeSymbolWriter): We don't need to call any
21556 initialization function on the symbol writer anymore. This method
21557 doesn't take any arguments.
21559 2003-02-03 Miguel de Icaza <miguel@ximian.com>
21561 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
21562 from referenced assemblies as well.
21564 2003-02-02 Martin Baulig <martin@ximian.com>
21566 * class.cs (MethodData.Emit): Generate debugging info for external methods.
21568 2003-02-02 Martin Baulig <martin@ximian.com>
21570 * class.cs (Constructor.Emit): Open the symbol writer before
21571 emitting the constructor initializer.
21572 (ConstructorInitializer.Emit): Call ec.Mark() to allow
21573 single-stepping through constructor initializers.
21575 2003-01-30 Miguel de Icaza <miguel@ximian.com>
21577 * class.cs: Handle error 549: do not allow virtual methods in
21580 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
21582 * decl.cs: Check access levels when resolving types
21584 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
21586 * statement.cs: Add parameters and locals set in catch blocks that might
21587 return to set vector
21589 2003-01-29 Miguel de Icaza <miguel@ximian.com>
21591 * class.cs (Operator): Set the SpecialName flags for operators.
21593 * expression.cs (Invocation.DoResolve): Only block calls to
21594 accessors and operators on SpecialName methods.
21596 (Cast.TryReduce): Handle conversions from char constants.
21599 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
21601 * statement.cs: small memory and time optimization in FlowBranching.
21603 2003-01-28 Pedro Mart <yoros@wanadoo.es>
21605 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
21606 problem that the last fix but in the other sid (Set).
21608 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
21609 access when there is no indexer in the hierarchy.
21611 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
21613 * class.cs: Combine some if statements.
21615 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21617 * driver.cs: fixed bug #37187.
21619 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
21621 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
21622 any indexer, it's needed to build a list with all the indexers in the
21623 hierarchy (AllGetters), else we have problems. Fixes #35653.
21625 2003-01-23 Miguel de Icaza <miguel@ximian.com>
21627 * class.cs (MethodData.Define): It is wrong for an interface
21628 implementation to be static in both cases: explicit and implicit.
21629 We were only handling this in one case.
21631 Improve the if situation there to not have negations.
21633 * class.cs (Field.Define): Turns out that we do not need to check
21634 the unsafe bit on field definition, only on usage. Remove the test.
21636 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21638 * driver.cs: use assembly.Location instead of Codebase (the latest
21639 patch made mcs fail when using MS assemblies).
21641 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
21643 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
21644 get the path to *corlib.dll.
21646 2003-01-21 Nick Drochak <ndrochak@gol.com>
21650 * typemanager.cs: Remove compiler warnings
21652 2003-01-20 Duncan Mak <duncan@ximian.com>
21654 * AssemblyInfo.cs: Bump the version number to 0.19.
21656 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21658 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
21660 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
21662 * class.cs (Constructor::Emit): Emit debugging info for constructors.
21664 2003-01-17 Miguel de Icaza <miguel@ximian.com>
21666 * cs-parser.jay: Small fix: we were not comparing the constructor
21667 name correctly. Thanks to Zoltan for the initial pointer.
21669 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
21671 * cs-tokenizer.cs: Set file name when specified with #line
21673 2003-01-15 Miguel de Icaza <miguel@ximian.com>
21675 * cs-parser.jay: Only perform the constructor checks here if we
21676 are named like the class; This will help provider a better
21677 error. The constructor path is taken when a type definition is
21678 not found, but most likely the user forgot to add the type, so
21679 report that rather than the constructor error.
21681 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
21683 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
21686 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
21688 * cs-parser.jay: Add cleanup call.
21690 2003-01-13 Duncan Mak <duncan@ximian.com>
21692 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
21693 consistent with other methods.
21695 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
21697 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
21699 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
21701 * attribute.cs: only set GuidAttr to true when we have a
21704 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21708 * typemanager.cs: fixes to allow mcs compile corlib with the new
21709 Type.IsSubclassOf fix.
21711 2003-01-08 Miguel de Icaza <miguel@ximian.com>
21713 * expression.cs (LocalVariableReference.DoResolve): Classify a
21714 constant as a value, not as a variable. Also, set the type for
21717 * cs-parser.jay (fixed_statement): take a type instead of a
21718 pointer_type, so we can produce a better error message later.
21720 * statement.cs (Fixed.Resolve): Flag types that are not pointers
21723 (For.DoEmit): Make inifinite loops have a
21724 non-conditional branch back.
21726 (Fixed.DoEmit): First populate the pinned variables, then emit the
21727 statement, then clear the variables. Before I was emitting the
21728 code once for each fixed piece.
21731 2003-01-08 Martin Baulig <martin@ximian.com>
21733 * statement.cs (FlowBranching.MergeChild): A break in a
21734 SWITCH_SECTION does not leave a loop. Fixes #36155.
21736 2003-01-08 Martin Baulig <martin@ximian.com>
21738 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
21739 lives in the same number space than `param_map'. Fixes #36154.
21741 2003-01-07 Miguel de Icaza <miguel@ximian.com>
21743 * cs-parser.jay (constructor_declaration): Set the
21744 Constructor.ModFlags before probing for it. This makes the
21745 compiler report 514, 515 and 132 (the code was there, but got
21748 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
21749 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
21750 (GotoCase.Resolve): Set `Returns' to ALWAYS.
21752 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
21754 * enum.cs: create the enum static fields using the enum type.
21756 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
21758 * class.cs: don't try to create the ParamBuilder for the return
21759 type if it's not needed (and handle it breaking for the ms runtime
21762 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
21764 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
21766 2002-12-29 Miguel de Icaza <miguel@ximian.com>
21768 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
21769 the command. This showed up while compiling the JANET source
21770 code, which used \r as its only newline separator.
21772 2002-12-28 Miguel de Icaza <miguel@ximian.com>
21774 * class.cs (Method.Define): If we are an operator (because it
21775 reuses our code), then set the SpecialName and HideBySig. #36128
21777 2002-12-22 Miguel de Icaza <miguel@ximian.com>
21779 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
21780 exception, report error 120 `object reference required'.
21782 * driver.cs: Add --pause option, used during to measure the size
21783 of the process as it goes with --timestamp.
21785 * expression.cs (Invocation.DoResolve): Do not allow methods with
21786 SpecialName to be invoked.
21788 2002-12-21 Miguel de Icaza <miguel@ximian.com>
21790 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
21791 number before adding it.
21793 2002-12-21 Ravi Pratap <ravi@ximian.com>
21795 * ecore.cs (StandardImplicitConversion): When in an unsafe
21796 context, we allow conversion between void * to any other pointer
21797 type. This fixes bug #35973.
21799 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
21801 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
21802 is not thrown when extensionless outputs are used
21804 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21806 * rootcontext.cs: fixed compilation of corlib.
21808 2002-12-19 Miguel de Icaza <miguel@ximian.com>
21810 * attribute.cs (Attributes.Contains): Add new method.
21812 * class.cs (MethodCore.LabelParameters): if the parameter is an
21813 `out' parameter, check that no attribute `[In]' has been passed.
21815 * enum.cs: Handle the `value__' name in an enumeration.
21817 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
21819 * decl.cs: Added special case to allow overrides on "protected
21822 2002-12-18 Ravi Pratap <ravi@ximian.com>
21824 * attribute.cs (Attributes.AddAttributeSection): Rename to this
21825 since it makes much more sense.
21827 (Attributes.ctor): Don't require a Location parameter.
21829 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
21831 * attribute.cs (ApplyAttributes): Remove extra Location parameters
21832 since we already have that information per attribute.
21834 * everywhere : make appropriate changes.
21836 * class.cs (LabelParameters): Write the code which actually
21837 applies attributes to the return type. We can't do this on the MS
21838 .NET runtime so we flag a warning in the case an exception is
21841 2002-12-18 Miguel de Icaza <miguel@ximian.com>
21843 * const.cs: Handle implicit null conversions here too.
21845 2002-12-17 Ravi Pratap <ravi@ximian.com>
21847 * class.cs (MethodCore.LabelParameters): Remove the extra
21848 Type [] parameter since it is completely unnecessary. Instead
21849 pass in the method's attributes so that we can extract
21850 the "return" attribute.
21852 2002-12-17 Miguel de Icaza <miguel@ximian.com>
21854 * cs-parser.jay (parse): Use Report.Error to flag errors instead
21855 of ignoring it and letting the compile continue.
21857 * typemanager.cs (ChangeType): use an extra argument to return an
21858 error condition instead of throwing an exception.
21860 2002-12-15 Miguel de Icaza <miguel@ximian.com>
21862 * expression.cs (Unary.TryReduce): mimic the code for the regular
21863 code path. Perform an implicit cast in the cases where we can
21864 implicitly convert to one of the integral types, and then reduce
21865 based on that constant. This fixes bug #35483.
21867 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21869 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
21871 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21873 * namespace.cs: fixed bug #35489.
21875 2002-12-12 Miguel de Icaza <miguel@ximian.com>
21877 * class.cs: Remove some dead code.
21879 * cs-parser.jay: Estimate the number of methods needed
21880 (RootContext.MethodCount);
21882 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
21883 numbers instead of StringBuilders.
21885 * support.cs (PtrHashtable): Add constructor with initial size;
21886 We can now reduce reallocations of the method table.
21888 2002-12-10 Ravi Pratap <ravi@ximian.com>
21890 * attribute.cs (ApplyAttributes): Keep track of the emitted
21891 attributes on a per-target basis. This fixes bug #35413.
21893 2002-12-10 Miguel de Icaza <miguel@ximian.com>
21895 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
21896 default to the Windows 1252 encoding.
21898 (UnixParseOption): Support version, thanks to Alp for the missing
21901 * AssemblyInfo.cs: Add nice assembly information.
21903 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
21906 * cs-parser.jay: Allow a trailing comma before the close bracked
21907 in the attribute_section production.
21909 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
21910 address of the instance was being taken, I will take this out,
21911 because we take the address of the object immediately here.
21913 2002-12-09 Ravi Pratap <ravi@ximian.com>
21915 * typemanager.cs (AreMultipleAllowed): Take care of the most
21916 obvious case where attribute type is not in the current assembly -
21919 2002-12-08 Miguel de Icaza <miguel@ximian.com>
21921 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
21922 definitions, instead of doing that afterwards.
21924 Also we use a nice little hack, depending on the constructor, we
21925 know if we are a "composed" name or a simple name. Hence, we
21926 avoid the IndexOf test, and we avoid
21928 * codegen.cs: Add code to assist in a bug reporter to track down
21929 the source of a compiler crash.
21931 2002-12-07 Ravi Pratap <ravi@ximian.com>
21933 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
21934 types have been emitted for a given element and flag an error
21935 if something which does not have AllowMultiple set is used more
21938 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
21939 attribute types and their corresponding AllowMultiple properties
21941 (AreMultipleAllowed): Check the property for a given type.
21943 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
21944 property in the case we have a TypeContainer.
21946 (Attributes.AddAttribute): Detect duplicates and just skip on
21947 adding them. This trivial fix catches a pretty gross error in our
21948 attribute emission - global attributes were being emitted twice!
21950 Bugzilla bug #33187 is now fixed.
21952 2002-12-06 Miguel de Icaza <miguel@ximian.com>
21954 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
21955 instead of pp_and).
21957 * expression.cs (Binary.ResolveOperator): I can only use the
21958 Concat (string, string, string) and Concat (string, string,
21959 string, string) if the child is actually a concatenation of
21962 2002-12-04 Miguel de Icaza <miguel@ximian.com>
21964 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
21965 context where we need a 2-character lookahead.
21967 * pending.cs (PendingImplementation): Rework so we can keep track
21968 of interface types all the time, and flag those which were
21969 implemented by parents as optional.
21971 2002-12-03 Miguel de Icaza <miguel@ximian.com>
21973 * expression.cs (Binary.ResolveOperator): Use
21974 String.Concat(string,string,string) or
21975 String.Concat(string,string,string,string) when possible.
21977 * typemanager: More helper methods.
21980 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
21982 * pending.cs: remove the bogus return from GetMissingInterfaces()
21983 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
21985 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21987 * namespace.cs: avoid duplicated 'using xxx' being added to
21988 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
21989 when we get more than one 'using' statement for the same namespace.
21990 Report a CS0105 warning for it.
21992 2002-11-30 Miguel de Icaza <miguel@ximian.com>
21994 * cs-tokenizer.cs (consume_identifier): use read directly, instead
21995 of calling getChar/putback, uses internal knowledge of it.
21997 (xtoken): Reorder tokenizer so most common patterns are checked
21998 first. This reduces the compilation time in another 5% (from 8.11s
21999 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
22001 The parsing time is 22% of the compilation in mcs, and from that
22002 64% is spent on the tokenization process.
22004 I tried using a binary search for keywords, but this is slower
22005 than the hashtable. Another option would be to do a couple of
22008 * Not use a StringBuilder, instead use an array of chars,
22009 with a set value. Notice that this way we could catch
22010 the 645 error without having to do it *afterwards*.
22012 * We could write a hand-parser to avoid the hashtable
22013 compares altogether.
22015 The identifier consumption process takes 37% of the tokenization
22016 time. Another 15% is spent on is_number. 56% of the time spent
22017 on is_number is spent on Int64.Parse:
22019 * We could probably choose based on the string length to
22020 use Int32.Parse or Int64.Parse and avoid all the 64-bit
22023 Another 3% is spend on wrapping `xtoken' in the `token' function.
22025 Handle 0xa0 as whitespace (#34752)
22027 2002-11-26 Miguel de Icaza <miguel@ximian.com>
22029 * typemanager.cs (IsCLRType): New routine to tell whether a type
22030 is one of the builtin types.
22032 Maybe it needs to use TypeCodes to be faster. Maybe we could use
22033 typecode in more places instead of doing pointer comparissions.
22034 We could leverage some knowledge about the way the typecodes are
22037 New code to cache namespaces in assemblies, it is currently not
22038 invoked, to be used soon.
22040 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
22042 * expression.cs (Binary.ResolveOperator): specially handle
22043 strings, and do not perform user-defined operator overloading for
22046 2002-11-24 Miguel de Icaza <miguel@ximian.com>
22048 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
22049 internalcall as it is a pretty simple operation; Avoid whenever
22050 possible to call Char.IsLetter.
22052 (consume_identifier): Cut by half the number of
22053 hashtable calls by merging the is_keyword and GetKeyword behavior.
22055 Do not short-circuit, because if we do, we
22056 report errors (ie, #if false && true would produce an invalid
22060 2002-11-24 Martin Baulig <martin@ximian.com>
22062 * expression.cs (Cast.TryReduce): If we're in checked syntax,
22063 check constant ranges and report a CS0221. Fixes #33186.
22065 2002-11-24 Martin Baulig <martin@ximian.com>
22067 * cs-parser.jay: Make this work for uninitialized variable
22068 declarations in the `for' initializer. Fixes #32416.
22070 2002-11-24 Martin Baulig <martin@ximian.com>
22072 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
22073 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
22075 2002-11-24 Martin Baulig <martin@ximian.com>
22077 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
22078 argument; if true, we also check for user-defined conversions.
22079 This is only needed if both arguments are of a user-defined type.
22080 Fixes #30443, added test-175.cs.
22081 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
22083 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
22085 2002-11-24 Martin Baulig <martin@ximian.com>
22087 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
22088 function to get the store opcode.
22089 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
22090 only emit the Ldelema if the store opcode is Stobj. You must run
22091 both test-34 and test-167 to test this. Fixes #34529.
22093 2002-11-23 Martin Baulig <martin@ximian.com>
22095 * ecore.cs (Expression.MemberLookup): Added additional
22096 `qualifier_type' argument which is used when we're being called
22097 from MemberAccess.DoResolve() and null if we're called from a
22099 (Expression.MemberLookupFailed): New method to report errors; this
22100 does the CS1540 check and reports the correct error message.
22102 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
22103 argument for the CS1540 check and redone the way how we're dealing
22104 with private members. See the comment in the source code for details.
22105 (FilterWithClosure): Reverted this back to revision 1.197; renamed
22106 `closure_start_type' to `closure_qualifier_type' and check whether
22107 it's not null. It was not this filter being broken, it was just
22108 being called with the wrong arguments.
22110 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
22111 and pass it the correct `qualifier_type'; this also does the error
22114 2002-11-22 Miguel de Icaza <miguel@ximian.com>
22116 * expression.cs (Invocation.EmitParams): If the we are dealing
22117 with a non-built-in value type, load its address as well.
22119 (ArrayCreation): Use a a pretty constant instead
22120 of the hardcoded value 2. Use 6 instead of 2 for the number of
22121 static initializers.
22123 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
22124 because they are not really value types, just glorified integers.
22126 * driver.cs: Do not append .exe, the CSC compiler does not do it.
22128 * ecore.cs: Remove redundant code for enumerations, make them use
22129 the same code path as everything else, fixes the casting issue
22130 with enumerations in Windows.Forms.
22132 * attribute.cs: Do only cast to string if it is a string, the
22133 validation happens later.
22135 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
22136 people upgrade their corlibs.
22138 * ecore.cs: Oops, enumerations were not following the entire code path
22140 2002-11-21 Miguel de Icaza <miguel@ximian.com>
22142 * typemanager.cs (FilterWithClosure): Commented out the test for
22143 1540 in typemanager.cs, as it has problems when accessing
22144 protected methods from a parent class (see test-174.cs).
22146 * attribute.cs (Attribute.ValidateGuid): new method.
22147 (Attribute.Resolve): Use above.
22149 2002-11-19 Miguel de Icaza <miguel@ximian.com>
22151 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
22153 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
22154 handling for enumerations, as we only needed the TypeContainer
22155 functionality to begin with (this is required for the fix below to
22156 work for enums that reference constants in a container class for
22159 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
22161 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
22162 a valid TypeBuilder to perform lookups on.o
22164 * class.cs (InheritableMemberSignatureCompare): Use true in the
22165 call to GetGetMethod and GetSetMethod, because we are comparing
22166 the signature, and we need to get the methods *even* if they are
22169 (PropertyBase.CheckBase): ditto.
22171 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
22172 GotoCase.Resolve): Use Peel on EmpytCasts.
22174 * ecore.cs (EmptyCast): drop child, add Peel method.
22176 2002-11-17 Martin Baulig <martin@ximian.com>
22178 * ecore.cs (EmptyCast.Child): New public property.
22180 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
22181 label resolved to an EmptyCast. Fixes #34162.
22182 (GotoCase.Resolve): Likewise.
22183 (Block.EmitMeta): Likewise.
22185 2002-11-17 Martin Baulig <martin@ximian.com>
22187 * expression.cs (Invocation.BetterConversion): Prefer int over
22188 uint; short over ushort; long over ulong for integer literals.
22189 Use ImplicitConversionExists instead of StandardConversionExists
22190 since we also need to check for user-defined implicit conversions.
22191 Fixes #34165. Added test-173.cs.
22193 2002-11-16 Martin Baulig <martin@ximian.com>
22195 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
22196 with the `true' and `false' literals. Fixes #33151.
22198 2002-11-16 Martin Baulig <martin@ximian.com>
22200 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
22201 October 22nd; don't do the cs1540 check for static members.
22203 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
22204 now using our own filter here and doing the cs1540 check again.
22206 2002-11-16 Martin Baulig <martin@ximian.com>
22208 * support.cs (InternalParameters): Don't crash if we don't have
22209 any fixed parameters. Fixes #33532.
22211 2002-11-16 Martin Baulig <martin@ximian.com>
22213 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
22214 when looking up static methods to make this work on Windows.
22217 2002-11-16 Martin Baulig <martin@ximian.com>
22219 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
22220 a setter rather than using PropertyInfo.CanWrite.
22222 2002-11-15 Nick Drochak <ndrochak@gol.com>
22224 * class.cs: Allow acces to block member by subclasses. Fixes build
22227 2002-11-14 Martin Baulig <martin@ximian.com>
22229 * class.cs (Constructor.Emit): Added the extern/block check.
22232 2002-11-14 Martin Baulig <martin@ximian.com>
22234 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
22235 iteration while looking for indexers, this is needed because the
22236 indexer may have a different name in our base classes. Fixed the
22237 error reporting (no indexers at all, not get accessor, no
22238 overloaded match). Fixes bug #33089.
22239 (IndexerAccess.DoResolveLValue): Likewise.
22241 2002-11-14 Martin Baulig <martin@ximian.com>
22243 * class.cs (PropertyBase.CheckBase): Make this work for multiple
22244 indexers. Fixes the first part of bug #33089.
22245 (MethodSignature.InheritableMemberSignatureCompare): Added support
22248 2002-11-13 Ravi Pratap <ravi@ximian.com>
22250 * attribute.cs (Attribute.Resolve): Catch the
22251 NullReferenceException and report it since it isn't supposed to
22254 2002-11-12 Miguel de Icaza <miguel@ximian.com>
22256 * expression.cs (Binary.EmitBranchable): Also handle the cases for
22257 LogicalOr and LogicalAnd that can benefit from recursively
22258 handling EmitBranchable. The code now should be nice for Paolo.
22260 2002-11-08 Miguel de Icaza <miguel@ximian.com>
22262 * typemanager.cs (LookupType): Added a negative-hit hashtable for
22263 the Type lookups, as we perform quite a number of lookups on
22264 non-Types. This can be removed once we can deterministically tell
22265 whether we have a type or a namespace in advance.
22267 But this might require special hacks from our corlib.
22271 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
22272 and double which avoids a conversion from an integer to a double.
22274 * expression.cs: tiny optimization, avoid calling IsConstant,
22275 because it effectively performs the lookup twice.
22277 2002-11-06 Miguel de Icaza <miguel@ximian.com>
22279 But a bogus return here to keep the semantics of the old code
22280 until the Mono runtime is fixed.
22282 * pending.cs (GetMissingInterfaces): New method used to remove all
22283 the interfaces that are already implemented by our parent
22284 classes from the list of pending methods.
22286 * interface.cs: Add checks for calls after ResolveTypeExpr.
22288 2002-11-05 Miguel de Icaza <miguel@ximian.com>
22290 * class.cs (Class.Emit): Report warning 67: event not used if the
22291 warning level is beyond 3.
22293 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
22294 being a NullLiteral.
22296 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
22299 * class.cs (TypeContainer.GetClassBases): Cover a missing code
22300 path that might fail if a type can not be resolved.
22302 * expression.cs (Binary.Emit): Emit unsigned versions of the
22305 * driver.cs: use error 5.
22307 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
22309 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
22311 2002-11-01 Miguel de Icaza <miguel@ximian.com>
22313 * cs-parser.jay (switch_section): A beautiful patch from Martin
22314 Baulig that fixed 33094.
22316 2002-10-31 Miguel de Icaza <miguel@ximian.com>
22318 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
22319 Check whether the base is abstract and report an error if so.
22321 * expression.cs (IndexerAccess.DoResolveLValue,
22322 IndexerAccess.DoResolve): ditto.
22324 (Invocation.DoResolve): ditto.
22326 (Invocation.FullMethodDesc): Improve the report string.
22328 * statement.cs (Block): Eliminate IsVariableDefined as it is
22329 basically just a wrapper for GetVariableInfo.
22331 * ecore.cs (SimpleName): Use new
22333 * support.cs (ReflectionParamter.ParameterType): We unwrap the
22334 type, as we return the actual parameter ref/unref state on a
22337 2002-10-30 Miguel de Icaza <miguel@ximian.com>
22339 * support.cs: Return proper flags REF/OUT fixing the previous
22342 * expression.cs: Reverted last patch, that was wrong. Is_ref is
22343 not used to mean `ref' but `ref or out' in ParameterReference
22345 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
22346 full type signature instead of calling TypeManger.CSharpName
22349 * support.cs (InternalParameters.ParameterDesc): Do not compare
22350 directly to the modflags, because REF/OUT will actually be bitsets
22353 * delegate.cs (VerifyMethod): Check also the modifiers.
22355 * cs-tokenizer.cs: Fix bug where floating point values with an
22356 exponent where a sign was missing was ignored.
22358 * driver.cs: Allow multiple assemblies to be specified in a single
22361 2002-10-28 Miguel de Icaza <miguel@ximian.com>
22363 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
22364 because identifiers after a parenthesis would end up in this kind
22365 of production, and we needed to desamiguate it for having casts
22368 (UserDefinedType *) xxx
22370 2002-10-24 Miguel de Icaza <miguel@ximian.com>
22372 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
22373 we should set on the Bindingflags.NonPublic, but not turn on
22374 private_ok. private_ok controls whether a Private member is
22375 returned (this is chekced on the filter routine), while the
22376 BindingFlags.NonPublic just controls whether private/protected
22377 will be allowed. This fixes the problem part of the problem of
22378 private properties being allowed to be used in derived classes.
22380 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
22381 so we can call the children DoResolveLValue method (this will
22382 properly signal errors on lvalue assignments to base properties)
22384 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
22385 getter are null, and we have a property info, we know that this
22386 happened because the lookup failed, so we report an error 122 for
22387 protection level violation.
22389 We also silently return if setter and getter are null in the
22390 resolve functions, this condition only happens if we have flagged
22391 the error before. This is the other half of the problem.
22393 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
22394 not have accessibility information, that is why we were returning
22395 true in the filter function in typemanager.cs.
22397 To properly report 122 (property is inaccessible because of its
22398 protection level) correctly, we report this error in ResolveAccess
22399 by failing if both the setter and the getter are lacking (ie, the
22402 DoResolve and DoLResolve have been modified to check for both
22403 setter/getter being null and returning silently, the reason being
22404 that I did not want to put the knowledge about this error in upper
22407 int old = Report.Errors;
22408 x = new PropertyExpr (...);
22409 if (old != Report.Errors)
22414 So the property expr is returned, but it is invalid, so the error
22415 will be flagged during the resolve process.
22417 * class.cs: Remove InheritablePropertySignatureCompare from the
22418 class, as we no longer depend on the property signature to compute
22419 whether it is possible to implement a method or not.
22421 The reason is that calling PropertyInfo.GetGetMethod will return
22422 null (in .NET, in Mono it works, and we should change this), in
22423 cases where the Get Method does not exist in that particular
22428 class X { public virtual int A { get { return 1; } } }
22430 class Z : Y { public override int A { get { return 2; } } }
22432 Would fail in Z because the parent (Y) would not have the property
22433 defined. So we avoid this completely now (because the alternative
22434 fix was ugly and slow), and we now depend exclusively on the
22437 (PropertyBase.CheckBase): Use a method-base mechanism to find our
22438 reference method, instead of using the property.
22440 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
22441 routines are gone now.
22443 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
22444 names, they were incorrectly named.
22446 * cs-tokenizer.cs: Return are more gentle token on failure.
22448 * pending.cs (PendingImplementation.InterfaceMethod): This routine
22449 had an out-of-sync index variable, which caused it to remove from
22450 the list of pending methods the wrong method sometimes.
22452 2002-10-22 Miguel de Icaza <miguel@ximian.com>
22454 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
22455 CanWrite, because those refer to this particular instance of the
22456 property, and do not take into account the fact that we can
22457 override single members of a property.
22459 Constructor requires an EmitContext. The resolution process does
22460 not happen here, but we need to compute the accessors before,
22461 because the resolution does not always happen for properties.
22463 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
22464 subclass, before we did not update this flag, but we did update
22467 (GetAccessors): Drop this routine, as it did not work in the
22468 presence of partially overwritten set/get methods.
22470 Notice that this broke the cs1540 detection, but that will require
22473 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22477 * driver.cs: issue a warning instead of an error if we don't support
22478 debugging for the platform. Also ignore a couple of errors that may
22479 arise when trying to write the symbols. Undo my previous patch.
22481 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22483 * driver.cs: ignore /debug switch except for Unix platforms.
22485 2002-10-23 Nick Drochak <ndrochak@gol.com>
22487 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
22489 2002-10-21 Miguel de Icaza <miguel@ximian.com>
22491 * driver.cs: Do not make mcs-debug conditional, so we do not break
22492 builds that use it.
22494 * statement.cs (UsageVector.MergeChildren): I would like Martin to
22495 review this patch. But basically after all the children variables
22496 have been merged, the value of "Breaks" was not being set to
22497 new_breaks for Switch blocks. I think that it should be set after
22498 it has executed. Currently I set this to the value of new_breaks,
22499 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
22500 conservative, but I do not understand this code very well.
22502 I did not break anything in the build, so that is good ;-)
22504 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
22506 2002-10-20 Mark Crichton <crichton@gimp.org>
22508 * cfold.cs: Fixed compile blocker. Really fixed it this time.
22510 2002-10-20 Nick Drochak <ndrochak@gol.com>
22512 * cfold.cs: Fixed compile blocker.
22514 2002-10-20 Miguel de Icaza <miguel@ximian.com>
22516 * driver.cs: I was chekcing the key, not the file.
22518 2002-10-19 Ravi Pratap <ravi@ximian.com>
22520 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
22521 message that we were generating - we just need to silently return
22524 2002-10-19 Miguel de Icaza <miguel@ximian.com>
22526 * class.cs (Event.Define): Change my previous commit, as this
22527 breaks the debugger. This is a temporary hack, as it seems like
22528 the compiler is generating events incorrectly to begin with.
22530 * expression.cs (Binary.ResolveOperator): Added support for
22531 "U operator - (E x, E y)"
22533 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
22536 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
22537 init-only variables, but this path did not take into account that
22538 there might be also instance readonly variables. Correct this
22541 This fixes bug 32253
22543 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
22546 * driver.cs: Change the extension for modules to `netmodule'
22548 * cs-parser.jay: Improved slightly the location tracking for
22549 the debugger symbols.
22551 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
22552 modifiers that were specified instead of the hardcoded value
22553 (FamAndAssem). This was basically ignoring the static modifier,
22554 and others. Fixes 32429.
22556 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
22557 fixed a bug in the process (32476)
22559 * expression.cs (ArrayAccess.EmitAssign): Patch from
22560 hwang_rob@yahoo.ca that fixes bug 31834.3
22562 2002-10-18 Miguel de Icaza <miguel@ximian.com>
22564 * driver.cs: Make the module extension .netmodule.
22566 2002-10-16 Miguel de Icaza <miguel@ximian.com>
22568 * driver.cs: Report an error if the resource file is not found
22569 instead of crashing.
22571 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
22572 false, like Emit does.
22574 2002-10-16 Nick Drochak <ndrochak@gol.com>
22576 * typemanager.cs: Remove unused private member. Also reported mcs
22577 bug to report this as a warning like csc.
22579 2002-10-15 Martin Baulig <martin@gnome.org>
22581 * statement.cs (Statement.Emit): Made this a virtual method; emits
22582 the line number info and calls DoEmit().
22583 (Statement.DoEmit): New protected abstract method, formerly knows
22584 as Statement.Emit().
22586 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
22588 2002-10-11 Miguel de Icaza <miguel@ximian.com>
22590 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
22591 have fixed a remaining problem: not every AddXXXX was adding a
22592 fully qualified name.
22594 Now everyone registers a fully qualified name in the DeclSpace as
22595 being defined instead of the partial name.
22597 Downsides: we are slower than we need to be due to the excess
22598 copies and the names being registered this way.
22600 The reason for this is that we currently depend (on the corlib
22601 bootstrap for instance) that types are fully qualified, because
22602 we dump all the types in the namespace, and we should really have
22603 types inserted into the proper namespace, so we can only store the
22604 basenames in the defined_names array.
22606 2002-10-10 Martin Baulig <martin@gnome.org>
22608 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
22609 from bug #31834, see the bug report for a testcase which is
22612 2002-10-10 Martin Baulig <martin@gnome.org>
22614 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
22615 flow analysis code for this.
22617 * statement.cs (Do, While, For): Tell the flow analysis code about
22619 (FlowBranching.UsageVector): Added support for infinite loops.
22620 (Block.Resolve): Moved the dead code elimination here and use flow
22623 2002-10-09 Miguel de Icaza <miguel@ximian.com>
22625 * class.cs (Field.Define): Catch cycles on struct type
22628 * typemanager.cs (IsUnmanagedtype): Do not recursively check
22629 fields if the fields are static. We only need to check instance
22632 * expression.cs (As.DoResolve): Test for reference type.
22634 * statement.cs (Using.ResolveExpression): Use
22635 ConvertImplicitRequired, not ConvertImplicit which reports an
22637 (Using.ResolveLocalVariableDecls): ditto.
22639 * expression.cs (Binary.ResolveOperator): Report errors in a few
22640 places where we had to.
22642 * typemanager.cs (IsUnmanagedtype): Finish implementation.
22644 2002-10-08 Miguel de Icaza <miguel@ximian.com>
22646 * expression.cs: Use StoreFromPtr instead of extracting the type
22647 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
22649 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
22650 an enumeration value to a System.Enum, but System.Enum is not a
22651 value type, but an class type, so we need to box.
22653 (Expression.ConvertExplicit): One codepath could return
22654 errors but not flag them. Fix this. Fixes #31853
22656 * parameter.cs (Resolve): Do not allow void as a parameter type.
22658 2002-10-06 Martin Baulig <martin@gnome.org>
22660 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
22661 if it's a class type and not a struct. Fixes #31815.
22663 2002-10-06 Martin Baulig <martin@gnome.org>
22665 * statement.cs: Reworked the flow analysis code a bit to make it
22666 usable for dead code elimination.
22668 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22670 * cs-parser.jay: allow empty source files. Fixes bug #31781.
22672 2002-10-04 Miguel de Icaza <miguel@ximian.com>
22674 * expression.cs (ComposedCast.DoResolveType): A quick workaround
22675 to fix the test 165, will investigate deeper.
22677 2002-10-04 Martin Baulig <martin@gnome.org>
22679 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
22680 finally blocks actually work.
22681 (Try.Resolve): We don't need to create a sibling for `finally' if
22682 there is no finally block.
22684 2002-10-04 Martin Baulig <martin@gnome.org>
22686 * class.cs (Constructor.Define): The default accessibility for a
22687 non-default constructor is private, not public.
22689 2002-10-04 Miguel de Icaza <miguel@ximian.com>
22691 * class.cs (Constructor): Make AllowedModifiers public, add
22694 * cs-parser.jay: Perform the modifiers test here, as the
22695 constructor for the Constructor class usually receives a zero
22696 because of the way we create it (first we create, later we
22697 customize, and we were never checking the modifiers).
22699 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
22700 is a version of LookupTypeReflection that includes the type-name
22701 cache. This can be used as a fast path for functions that know
22702 the fully qualified name and are only calling into *.GetType() to
22703 obtain a composed type.
22705 This is also used by TypeManager.LookupType during its type
22708 (LookupType): We now also track the real type name, as sometimes
22709 we can get a quey for the real type name from things like
22710 ComposedCast. This fixes bug 31422.
22712 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
22713 complete type fullname, it does not have to go through the type
22714 resolution system to obtain the composed version of the type (for
22715 obtaining arrays or pointers).
22717 (Conditional.Emit): Use the EmitBoolExpression to
22718 generate nicer code, as requested by Paolo.
22720 (ArrayCreation.CheckIndices): Use the patch from
22721 hwang_rob@yahoo.ca to validate the array initializers.
22723 2002-10-03 Miguel de Icaza <miguel@ximian.com>
22725 * class.cs (ConstructorInitializer.Emit): simplify code by using
22726 Invocation.EmitCall, and at the same time, fix the bugs in calling
22727 parent constructors that took variable arguments.
22729 * ecore.cs (Expression.ConvertNumericExplicit,
22730 Expression.ImplicitNumericConversion): Remove the code that
22731 manually wrapped decimal (InternalTypeConstructor call is now gone
22734 * expression.cs (Cast.TryReduce): Also handle decimal types when
22735 trying to perform a constant fold on the type.
22737 * typemanager.cs (IsUnmanagedtype): Partially implemented.
22739 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
22740 that only turned off an error report, and did nothing else.
22742 2002-10-02 Miguel de Icaza <miguel@ximian.com>
22744 * driver.cs: Handle and ignore /fullpaths
22746 2002-10-01 Miguel de Icaza <miguel@ximian.com>
22748 * expression.cs (Binary.ResolveOperator): Catch the case where
22749 DoNumericPromotions returns true,
22751 (Binary.DoNumericPromotions): Simplify the code, and the tests.
22753 2002-09-27 Miguel de Icaza <miguel@ximian.com>
22755 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
22758 2002-09-26 Miguel de Icaza <miguel@ximian.com>
22760 * ecore.cs (ConvertNumericExplicit): It is not enough that the
22761 conversion exists, but it is also required that the conversion be
22762 performed. This manifested in "(Type64Enum) 2".
22764 * class.cs (TypeManager.AddMethod): The fix is not to change
22765 AddEnum, because that one was using a fully qualified name (every
22766 DeclSpace derivative does), but to change the AddMethod routine
22767 that was using an un-namespaced name. This now correctly reports
22768 the duplicated name.
22770 Revert patch until I can properly fix it. The issue
22771 is that we have a shared Type space across all namespaces
22772 currently, which is wrong.
22774 Options include making the Namespace a DeclSpace, and merge
22775 current_namespace/current_container in the parser.
22777 2002-09-25 Miguel de Icaza <miguel@ximian.com>
22779 * cs-parser.jay: Improve error reporting when we get a different
22780 kind of expression in local_variable_type and
22781 local_variable_pointer_type.
22783 Propagate this to avoid missleading errors being reported.
22785 * ecore.cs (ImplicitReferenceConversion): treat
22786 TypeManager.value_type as a target just like object_type. As
22791 Is valid, and needs to result in the int 1 being boxed before it
22792 is assigned to the value type v.
22794 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
22795 to validate the enumeration name.
22797 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
22798 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
22799 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
22801 * ecore.cs (TryImplicitIntConversion): When doing an
22802 implicit-enumeration-conversion, check if the type is 64-bits and
22803 perform a conversion before passing to EnumConstant.
22805 2002-09-23 Miguel de Icaza <miguel@ximian.com>
22807 * decl.cs (Error_AmbiguousTypeReference); New routine used to
22808 report ambiguous type references. Unlike the MS version, we
22809 report what the ambiguity is. Innovation at work ;-)
22811 (DeclSpace.FindType): Require a location argument to
22812 display when we display an ambiguous error.
22814 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
22816 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
22818 * expression.cs (EmitDynamicInitializers): Apply patch from
22819 hwang_rob@yahoo.ca that fixes the order in which we emit our
22822 2002-09-21 Martin Baulig <martin@gnome.org>
22824 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
22825 delegate takes no arguments.
22827 2002-09-20 Miguel de Icaza <miguel@ximian.com>
22829 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
22832 * expression.cs: Extract the underlying type.
22834 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
22836 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
22838 2002-09-19 Miguel de Icaza <miguel@ximian.com>
22840 * class.cs (TypeContainer.DefineType): We can not use the nice
22841 PackingSize with the size set to 1 DefineType method, because it
22842 will not allow us to define the interfaces that the struct
22845 This completes the fixing of bug 27287
22847 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
22848 means also structs. This fixes part of the problem.
22849 (Expresion.ImplicitReferenceConversionExists): ditto.
22851 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
22852 error if there were no errors reported during the type lookup
22853 process, to avoid duplicates or redundant errors. Without this
22854 you would get an ambiguous errors plus a type not found. We have
22855 beaten the user enough with the first error.
22857 (DeclSparce.FindType): Emit a warning if we have an ambiguous
22860 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
22861 during the resolution process, stop the lookup, this avoids
22862 repeated error reports (same error twice).
22864 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
22866 * typemanager.cs (LookupType): Redo the type lookup code to match
22867 the needs of System.Reflection.
22869 The issue is that System.Reflection requires references to nested
22870 types to begin with a "+" sign instead of a dot. So toplevel
22871 types look like: "NameSpace.TopLevelClass", and nested ones look
22872 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
22875 2002-09-19 Martin Baulig <martin@gnome.org>
22877 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
22878 says that a method always returns or always throws an exception,
22879 don't report the CS0161.
22881 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
22882 set `Returns = new_returns'.
22884 2002-09-19 Martin Baulig <martin@gnome.org>
22886 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
22887 to an enum constant, check for a CS0176.
22889 2002-09-18 Miguel de Icaza <miguel@ximian.com>
22891 * class.cs (TypeContainer.CheckPairedOperators): Now we check
22892 for operators that must be in pairs and report errors.
22894 * ecore.cs (SimpleName.DoResolveType): During the initial type
22895 resolution process, when we define types recursively, we must
22896 check first for types in our current scope before we perform
22897 lookups in the enclosing scopes.
22899 * expression.cs (MakeByteBlob): Handle Decimal blobs.
22901 (Invocation.VerifyArgumentsCompat): Call
22902 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
22903 I thought we were supposed to always call this, but there are a
22904 few places in the code where we dont do it.
22906 2002-09-17 Miguel de Icaza <miguel@ximian.com>
22908 * driver.cs: Add support in -linkres and -resource to specify the
22909 name of the identifier.
22911 2002-09-16 Miguel de Icaza <miguel@ximian.com>
22913 * ecore.cs (StandardConversionExists): Sync with the conversion
22914 code: allow anything-* to void* conversions.
22916 (FindMostSpecificSource): Use an Expression argument
22917 instead of a Type, because we might be handed over a Literal which
22918 gets a few more implicit conversions that plain types do not. So
22919 this information was being lost.
22921 Also, we drop the temporary type-holder expression when not
22924 2002-09-17 Martin Baulig <martin@gnome.org>
22926 * class.cs (PropertyBase.CheckBase): Don't check the base class if
22927 this is an explicit interface implementation.
22929 2002-09-17 Martin Baulig <martin@gnome.org>
22931 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
22932 different `IndexerName' attributes.
22934 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
22935 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
22936 virtual CommonResolve().
22938 2002-09-16 Miguel de Icaza <miguel@ximian.com>
22940 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
22941 and convert that to the UnderlyingType.
22943 * statement.cs (Foreach.Resolve): Indexers are just like variables
22944 or PropertyAccesses.
22946 * cs-tokenizer.cs (consume_string): Track line numbers and columns
22947 inside quoted strings, we were not doing this before.
22949 2002-09-16 Martin Baulig <martin@gnome.org>
22951 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
22952 resolve it. This is needed for the definite assignment check of the
22953 instance expression, fixes bug #29846.
22954 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
22956 2002-09-16 Nick Drochak <ndrochak@gol.com>
22958 * parameter.cs: Fix compile error. Cannot reference static member
22959 from an instance object. Is this an mcs bug?
22961 2002-09-14 Martin Baulig <martin@gnome.org>
22963 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
22964 multiple times. Fixes bug #30295, added test-166.cs.
22966 2002-09-14 Martin Baulig <martin@gnome.org>
22968 * statement.cs (Block.Emit): Don't emit unreachable code.
22969 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
22970 `break' statements.
22971 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
22973 2002-09-14 Martin Baulig <martin@gnome.org>
22975 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
22978 2002-09-14 Martin Baulig <martin@gnome.org>
22980 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
22981 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
22982 be false on the ms runtime.
22984 2002-09-13 Martin Baulig <martin@gnome.org>
22986 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
22987 the CS0038 error message.
22989 2002-09-12 Miguel de Icaza <miguel@ximian.com>
22991 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
22992 constant inside, return it.
22994 2002-09-12 Martin Baulig <martin@gnome.org>
22996 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
22997 implicit conversion can be done between enum types.
22999 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
23000 check whether an implicit conversion to the current enum's UnderlyingType
23001 exists and report an error if not.
23003 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
23004 without debugging support.
23006 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
23007 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
23009 2002-09-12 Martin Baulig <martin@gnome.org>
23011 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
23013 * ecore.cs (IMemberExpr.DeclaringType): New property.
23014 (SimpleName.SimpleNameResolve): Check whether we're accessing a
23015 nonstatic member of an outer type (CS0038).
23017 2002-09-11 Miguel de Icaza <miguel@ximian.com>
23019 * driver.cs: Activate the using-error detector at warning level
23020 4 (at least for MS-compatible APIs).
23022 * namespace.cs (VerifyUsing): Small buglett fix.
23024 * pending.cs (PendingImplementation): pass the container pointer.
23026 * interface.cs (GetMethods): Allow for recursive definition. Long
23027 term, I would like to move every type to support recursive
23028 definitions, not the current ordering mechanism that we have right
23031 The situation is this: Attributes are handled before interfaces,
23032 so we can apply attributes to interfaces. But some attributes
23033 implement interfaces, we will now handle the simple cases
23034 (recursive definitions will just get an error).
23036 * parameter.cs: Only invalidate types at the end if we fail to
23039 2002-09-09 Martin Baulig <martin@gnome.org>
23041 * ecore.cs (PropertyExpr.Emit): Also check for
23042 TypeManager.system_int_array_get_length so this'll also work when
23043 compiling corlib. Fixes #30003.
23045 2002-09-09 Martin Baulig <martin@gnome.org>
23047 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
23048 and throw an exception if we can't get the type's size. Fixed #30040,
23051 2002-09-09 Martin Baulig <martin@gnome.org>
23053 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
23055 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
23056 context. Fixes bug #30027.
23058 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
23059 virtual functions. Fixes bug #30043, added test-164.cs.
23061 2002-09-08 Ravi Pratap <ravi@ximian.com>
23063 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
23065 2002-09-08 Nick Drochak <ndrochak@gol.com>
23067 * driver.cs: Use an object to get the windows codepage since it's not a
23070 2002-09-08 Miguel de Icaza <miguel@ximian.com>
23072 * statement.cs (For.Emit): for infinite loops (test == null)
23073 return whether there is a break inside, not always "true".
23075 * namespace.cs (UsingEntry): New struct to hold the name of the
23076 using definition, the location where it is defined, and whether it
23077 has been used in a successful type lookup.
23079 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
23084 2002-09-06 Ravi Pratap <ravi@ximian.com>
23086 * attribute.cs : Fix incorrect code which relied on catching
23087 a NullReferenceException to detect a null being passed in
23088 where an object was expected.
23090 2002-09-06 Miguel de Icaza <miguel@ximian.com>
23092 * statement.cs (Try): flag the catch variable as assigned
23094 * expression.cs (Cast): Simplified by using ResolveType instead of
23095 manually resolving.
23097 * statement.cs (Catch): Fix bug by using ResolveType.
23099 2002-09-06 Ravi Pratap <ravi@ximian.com>
23101 * expression.cs (BetterConversion): Special case for when we have
23102 a NullLiteral as the argument and we have to choose between string
23103 and object types - we choose string the way csc does.
23105 * attribute.cs (Attribute.Resolve): Catch the
23106 NullReferenceException and report error #182 since the Mono
23107 runtime no more has the bug and having this exception raised means
23108 we tried to select a constructor which takes an object and is
23111 2002-09-05 Ravi Pratap <ravi@ximian.com>
23113 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
23114 message (1502, 1503) when we can't locate a method after overload
23115 resolution. This is much more informative and closes the bug
23118 * interface.cs (PopulateMethod): Return if there are no argument
23119 types. Fixes a NullReferenceException bug.
23121 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
23122 expressions too. Previously we were checking only in one place for
23123 positional arguments leaving out named arguments.
23125 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
23126 type to the enum type is not allowed. Remove code corresponding to
23129 (ConvertNumericExplicit): Allow explicit conversions from
23130 the underlying type to enum type. This precisely follows the spec
23131 and closes a bug filed by Gonzalo.
23133 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23136 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
23138 2002-09-03 Miguel de Icaza <miguel@ximian.com>
23140 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
23141 it was important that we stored the right value after the
23142 reduction in `converted'.
23144 2002-09-04 Martin Baulig <martin@gnome.org>
23146 * location.cs (Location.SymbolDocument): Use full pathnames for the
23149 2002-08-30 Miguel de Icaza <miguel@ximian.com>
23151 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
23152 of the expression resolve mechanism, because that will catch the
23153 SimpleName error failures.
23155 (Conditional): If we can not resolve the
23156 expression, return, do not crash.
23158 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23161 (location): display token name instead of its number.
23163 2002-08-28 Martin Baulig <martin@gnome.org>
23165 * expression.cs (Binary.ResolveOperator): Don't silently return
23166 but return an error if an operator cannot be applied between two
23169 2002-08-28 Martin Baulig <martin@gnome.org>
23171 * class.cs (Constructor.Define): Set the permission attributes
23172 correctly instead of making all constructors public.
23174 2002-08-28 Martin Baulig <martin@gnome.org>
23176 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
23177 for private members before reporting a CS0103; if we find anything,
23180 2002-08-28 Martin Baulig <martin@gnome.org>
23182 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
23183 to check whether `closure_start_type == closure_invocation_type',
23184 we also need to check whether `m.DeclaringType == closure_invocation_type'
23185 before bypassing the permission checks. We might be accessing
23186 protected/private members from the base class.
23187 (TypeManager.RealMemberLookup): Only set private_ok if private
23188 members were requested via BindingFlags.NonPublic.
23190 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
23192 * expression.cs (MemberAccess.ResolveMemberAccess): Set
23193 MethodGroupExpr.IsExplicitImpl if appropriate.
23194 (Invocation.DoResolve): Don't report the CS0120 for explicit
23195 interface implementations.
23197 2002-08-27 Martin Baulig <martin@gnome.org>
23199 * expression.cs (Invocation.DoResolve): If this is a static
23200 method and we don't have an InstanceExpression, we must report
23203 2002-08-25 Martin Baulig <martin@gnome.org>
23205 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
23206 `==' between a valuetype and an object.
23208 2002-08-25 Miguel de Icaza <miguel@ximian.com>
23210 * ecore.cs (TypeExpr): Provide a ToString method.
23212 2002-08-24 Martin Baulig <martin@gnome.org>
23214 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
23215 now called proggie.dbg and it's a binary file.
23217 2002-08-23 Martin Baulig <martin@gnome.org>
23219 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
23221 2002-08-23 Martin Baulig <martin@gnome.org>
23223 * struct.cs (MyStructInfo.ctor): Make this work with empty
23224 structs; it's not allowed to use foreach() on null.
23226 2002-08-23 Martin Baulig <martin@gnome.org>
23228 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
23229 writer the full pathname of the generated assembly.
23231 2002-08-23 Martin Baulig <martin@gnome.org>
23233 * statements.cs (FlowBranching.UsageVector.MergeChildren):
23234 A `finally' block never returns or breaks; improved handling of
23237 2002-08-23 Martin Baulig <martin@gnome.org>
23239 * statement.cs (Throw.Resolve): Allow `throw null'.
23241 2002-08-23 Martin Baulig <martin@gnome.org>
23243 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
23244 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
23245 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
23246 MemberLookup would return a wrong event if this is an explicit
23247 interface implementation and the class has an event with the same
23250 2002-08-23 Martin Baulig <martin@gnome.org>
23252 * statement.cs (Block.AddChildVariableNames): New public method.
23253 (Block.AddChildVariableName): Likewise.
23254 (Block.IsVariableNameUsedInChildBlock): Likewise.
23255 (Block.AddVariable): Check whether a variable name has already
23256 been used in a child block.
23258 * cs-parser.jay (declare_local_variables): Mark all variable names
23259 from the current block as being used in a child block in the
23262 2002-08-23 Martin Baulig <martin@gnome.org>
23264 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
23265 find the symbol writer.
23267 * driver.cs: csc also allows the arguments to /define being
23268 separated by commas, not only by semicolons.
23270 2002-08-23 Martin Baulig <martin@gnome.org>
23272 * interface.cs (Interface.GetMembers): Added static check for events.
23274 2002-08-15 Martin Baulig <martin@gnome.org>
23276 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
23277 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
23279 * ecore.cs (Expression.MemberLookup): Added documentation and explained
23280 why the MethodData.EmitDestructor() change was necessary.
23282 2002-08-20 Martin Baulig <martin@gnome.org>
23284 * class.cs (TypeContainer.FindMembers): Added static check for events.
23286 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
23288 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
23289 use Type.GetEvents(), not Type.FindMembers().
23291 2002-08-20 Martin Baulig <martin@gnome.org>
23293 * decl.cs (MemberCache): Added a special method cache which will
23294 be used for method-only searched. This ensures that a method
23295 search will return a MethodInfo with the correct ReflectedType for
23298 2002-08-20 Martin Baulig <martin@gnome.org>
23300 * decl.cs (DeclSpace.FindMembers): Made this public.
23302 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23304 * delegate.cs: fixed build on windows.
23305 [FIXME: Filed as bug #29150: MCS must report these errors.]
23307 2002-08-19 Ravi Pratap <ravi@ximian.com>
23309 * ecore.cs (StandardConversionExists): Return a false
23310 if we are trying to convert the void type to anything else
23311 since that is not allowed.
23313 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
23314 we flag error 70 in the event an event is trying to be accessed
23315 directly from outside the declaring type.
23317 2002-08-20 Martin Baulig <martin@gnome.org>
23319 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
23320 MemberCache from typemanager.cs to decl.cs.
23322 2002-08-19 Martin Baulig <martin@gnome.org>
23324 * class.cs (TypeContainer): Implement IMemberContainer.
23325 (TypeContainer.DefineMembers): Create the MemberCache.
23326 (TypeContainer.FindMembers): Do better BindingFlags checking; only
23327 return public members if BindingFlags.Public was given, check
23328 whether members are static.
23330 2002-08-16 Martin Baulig <martin@gnome.org>
23332 * decl.cs (DeclSpace.Define): Splitted this in Define and
23333 DefineMembers. DefineMembers is called first and initializes the
23336 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
23337 DefineMembers() on all our DeclSpaces.
23339 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
23340 but call DefineMembers() on all nested interfaces. We call their
23341 Define() in our new Define() function.
23343 * interface.cs (Interface): Implement IMemberContainer.
23344 (Interface.Define): Moved all code except the attribute stuf to
23346 (Interface.DefineMembers): Initialize the member cache.
23348 * typemanager.cs (IMemberFinder): Removed this interface, we don't
23349 need this anymore since we can use MemberCache.FindMembers directly.
23351 2002-08-19 Martin Baulig <martin@gnome.org>
23353 * typemanager.cs (MemberCache): When creating the cache for an
23354 interface type, add all inherited members.
23355 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
23356 to `out bool used_cache' and documented it.
23357 (TypeManager.MemberLookup): If we already used the cache in the first
23358 iteration, we don't need to do the interfaces check.
23360 2002-08-19 Martin Baulig <martin@gnome.org>
23362 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
23363 here from IMemberFinder and don't implement this interface anymore.
23364 (DeclSpace.MemberCache): Moved here from IMemberFinder.
23366 * typemanager.cs (IMemberFinder): This interface is now only used by
23367 classes which actually support the member cache.
23368 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
23369 since we only put DeclSpaces into this Hashtable.
23370 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
23371 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
23373 2002-08-16 Martin Baulig <martin@gnome.org>
23375 * typemanager.cs (ICachingMemberFinder): Removed.
23376 (IMemberFinder.MemberCache): New property.
23377 (TypeManager.FindMembers): Merged this with RealFindMembers().
23378 This function will never be called from TypeManager.MemberLookup()
23379 so we can't use the cache here, just the IMemberFinder.
23380 (TypeManager.MemberLookup_FindMembers): Check whether the
23381 IMemberFinder has a MemberCache and call the cache's FindMembers
23383 (MemberCache): Rewrote larger parts of this yet another time and
23384 cleaned it up a bit.
23386 2002-08-15 Miguel de Icaza <miguel@ximian.com>
23388 * driver.cs (LoadArgs): Support quoting.
23390 (Usage): Show the CSC-like command line arguments.
23392 Improved a few error messages.
23394 2002-08-15 Martin Baulig <martin@gnome.org>
23396 * typemanager.cs (IMemberContainer.Type): New property.
23397 (IMemberContainer.IsInterface): New property.
23399 The following changes are conditional to BROKEN_RUNTIME, which is
23400 defined at the top of the file.
23402 * typemanager.cs (MemberCache.MemberCache): Don't add the base
23403 class'es members, but add all members from TypeHandle.ObjectType
23404 if we're an interface.
23405 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
23406 is the current type.
23407 (MemberCache.CacheEntry.Container): Removed this field.
23408 (TypeHandle.GetMembers): Include inherited members.
23410 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23412 * typemanager.cs: fixed compilation and added a comment on a field that
23415 2002-08-15 Martin Baulig <martin@gnome.org>
23417 * class.cs (ConstructorInitializer.Resolve): In the
23418 Expression.MemberLookup call, use the queried_type as
23421 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
23422 declared' attribute, it's always true.
23423 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
23424 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
23425 temporary wrapper for FindMembers which tells MemberLookup whether
23426 members from the base classes are included in the return value.
23427 This will go away soon.
23428 (TypeManager.MemberLookup): Use this temporary hack here; once the
23429 new MemberCache is completed, we don't need to do the DeclaredOnly
23430 looping here anymore since the MemberCache will take care of this.
23431 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
23432 (MemberCache): When creating the MemberCache for a class, get
23433 members from the current class and all its base classes.
23434 (MemberCache.CacheEntry.Container): New field. This is a
23435 temporary hack until the Mono runtime is fixed to distinguish
23436 between ReflectedType and DeclaringType. It allows us to use MCS
23437 with both the MS runtime and the unfixed Mono runtime without
23438 problems and without accecting performance.
23439 (MemberCache.SearchMembers): The DeclaredOnly looping from
23440 TypeManager.MemberLookup is now done here.
23442 2002-08-14 Martin Baulig <martin@gnome.org>
23444 * statement.cs (MyStructInfo.MyStructInfo): Don't call
23445 Type.GetFields on dynamic types but get the fields from the
23446 corresponding TypeContainer.
23447 (MyStructInfo.GetStructInfo): Added check for enum types.
23449 * typemanager.cs (MemberList.IsSynchronized): Implemented.
23450 (MemberList.SyncRoot): Implemented.
23451 (TypeManager.FilterWithClosure): No need to check permissions if
23452 closure_start_type == closure_invocation_type, don't crash if
23453 closure_invocation_type is null.
23455 2002-08-13 Martin Baulig <martin@gnome.org>
23457 Rewrote TypeContainer.FindMembers to use a member cache. This
23458 gives us a speed increase of about 35% for the self-hosting MCS
23459 build and of about 15-20% for the class libs (both on GNU/Linux).
23461 * report.cs (Timer): New class to get enhanced profiling. This
23462 whole class is "TIMER" conditional since it remarkably slows down
23465 * class.cs (MemberList): New class. This is an IList wrapper
23466 which we're now using instead of passing MemberInfo[]'s around to
23467 avoid copying this array unnecessarily.
23468 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
23469 (ICachingMemberFinder, IMemberContainer): New interface.
23470 (TypeManager.FilterWithClosure): If `criteria' is null, the name
23471 has already been checked, otherwise use it for the name comparision.
23472 (TypeManager.FindMembers): Renamed to RealMemberFinder and
23473 provided wrapper which tries to use ICachingMemberFinder.FindMembers
23474 if possible. Returns a MemberList, not a MemberInfo [].
23475 (TypeHandle): New class, implements IMemberContainer. We create
23476 one instance of this class per type, it contains a MemberCache
23477 which is used to do the member lookups.
23478 (MemberCache): New class. Each instance of this class contains
23479 all members of a type and a name-based hash table.
23480 (MemberCache.FindMembers): This is our new member lookup
23481 function. First, it looks up all members of the requested name in
23482 the hash table. Then, it walks this list and sorts out all
23483 applicable members and returns them.
23485 2002-08-13 Martin Baulig <martin@gnome.org>
23487 In addition to a nice code cleanup, this gives us a performance
23488 increase of about 1.4% on GNU/Linux - not much, but it's already
23489 half a second for the self-hosting MCS compilation.
23491 * typemanager.cs (IMemberFinder): New interface. It is used by
23492 TypeManager.FindMembers to call FindMembers on a TypeContainer,
23493 Enum, Delegate or Interface.
23494 (TypeManager.finder_to_member_finder): New PtrHashtable.
23495 (TypeManager.finder_to_container): Removed.
23496 (TypeManager.finder_to_delegate): Removed.
23497 (TypeManager.finder_to_interface): Removed.
23498 (TypeManager.finder_to_enum): Removed.
23500 * interface.cs (Interface): Implement IMemberFinder.
23502 * delegate.cs (Delegate): Implement IMemberFinder.
23504 * enum.cs (Enum): Implement IMemberFinder.
23506 * class.cs (TypeContainer): Implement IMemberFinder.
23508 2002-08-12 Martin Baulig <martin@gnome.org>
23510 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
23512 2002-08-12 Martin Baulig <martin@gnome.org>
23514 * ecore.cs (ITypeExpression): New interface for expressions which
23516 (TypeExpression): Renamed to TypeLookupExpression.
23517 (Expression.DoResolve): If we're doing a types-only lookup, the
23518 expression must implement the ITypeExpression interface and we
23519 call DoResolveType() on it.
23520 (SimpleName): Implement the new ITypeExpression interface.
23521 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
23522 hack, the situation that we're only looking up types can't happen
23523 anymore when this method is called. Moved the type lookup code to
23524 DoResolveType() and call it.
23525 (SimpleName.DoResolveType): This ITypeExpression interface method
23526 is now doing the types-only lookup.
23527 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
23528 (ResolveFlags): Added MaskExprClass.
23530 * expression.cs (MemberAccess): Implement the ITypeExpression
23532 (MemberAccess.DoResolve): Added support for a types-only lookup
23533 when we're called via ITypeExpression.DoResolveType().
23534 (ComposedCast): Implement the ITypeExpression interface.
23536 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
23537 Expression.Resolve() with ResolveFlags.Type instead.
23539 2002-08-12 Martin Baulig <martin@gnome.org>
23541 * interface.cs (Interface.Define): Apply attributes.
23543 * attribute.cs (Attribute.ApplyAttributes): Added support for
23544 interface attributes.
23546 2002-08-11 Martin Baulig <martin@gnome.org>
23548 * statement.cs (Block.Emit): Only check the "this" variable if we
23549 do not always throw an exception.
23551 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
23552 whether the property has a set accessor.
23554 2002-08-11 Martin Baulig <martin@gnome.org>
23556 Added control flow analysis support for structs.
23558 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
23559 with control flow analysis turned off.
23560 (IVariable): New interface.
23561 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
23562 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
23563 (FieldExpr.DoResolve): Resolve the instance expression with flow
23564 analysis turned off and do the definite assignment check after the
23565 resolving when we know what the expression will resolve to.
23567 * expression.cs (LocalVariableReference, ParameterReference):
23568 Implement the new IVariable interface, only call the flow analysis
23569 code if ec.DoFlowAnalysis is true.
23570 (This): Added constructor which takes a Block argument. Implement
23571 the new IVariable interface.
23572 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
23573 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
23574 This does the definite assignment checks for struct members.
23576 * class.cs (Constructor.Emit): If this is a non-static `struct'
23577 constructor which doesn't have any initializer, call
23578 Block.AddThisVariable() to tell the flow analysis code that all
23579 struct elements must be initialized before control returns from
23582 * statement.cs (MyStructInfo): New public class.
23583 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
23584 argument to this indexer. If non-zero, check an individual struct
23585 member, not the whole struct.
23586 (FlowBranching.CheckOutParameters): Check struct members.
23587 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
23588 overloaded versions of these methods which take an additional
23589 `int field_idx' argument to check struct members.
23590 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
23591 overloaded versions of these methods which take an additional
23592 `string field_name' argument to check struct member.s
23593 (VariableInfo): Implement the IVariable interface.
23594 (VariableInfo.StructInfo): New public property. Returns the
23595 MyStructInfo instance of the variable if it's a struct or null.
23596 (Block.AddThisVariable): New public method. This is called from
23597 Constructor.Emit() for non-static `struct' constructor which do
23598 not have any initializer. It creates a special variable for the
23599 "this" instance variable which will be checked by the flow
23600 analysis code to ensure that all of the struct's fields are
23601 initialized before control returns from the constructor.
23602 (UsageVector): Added support for struct members. If a
23603 variable/parameter is a struct with N members, we reserve a slot
23604 in the usage vector for each member. A struct is considered fully
23605 initialized if either the struct itself (slot 0) or all its
23606 members are initialized.
23608 2002-08-08 Martin Baulig <martin@gnome.org>
23610 * driver.cs (Driver.MainDriver): Only report an error CS5001
23611 if there were no compilation errors.
23613 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
23614 `UnsafeContext' property to determine whether the parent is in
23615 unsafe context rather than checking the parent's ModFlags:
23616 classes nested in an unsafe class are unsafe as well.
23618 2002-08-08 Martin Baulig <martin@gnome.org>
23620 * statement.cs (UsageVector.MergeChildren): Distinguish between
23621 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
23622 we return. Added test17() and test18() to test-154.cs.
23624 2002-08-08 Martin Baulig <martin@gnome.org>
23626 * typemanager.cs (TypeManager.FilterWithClosure): If we have
23627 Family access, make sure the invoking type isn't a subclass of the
23628 queried type (that'd be a CS1540).
23630 * ecore.cs (Expression.MemberLookup): Added overloaded version of
23631 this method which takes an additional `Type invocation_type'.
23633 * expression.cs (BaseAccess.DoResolve): Use the base type as
23634 invocation and query type.
23635 (MemberAccess.DoResolve): If the lookup failed and we're about to
23636 report a CS0122, try a lookup with the ec.ContainerType - if this
23637 succeeds, we must report a CS1540.
23639 2002-08-08 Martin Baulig <martin@gnome.org>
23641 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
23642 (MethodGroupExpr): Implement the IMemberExpr interface.
23644 * expression (MemberAccess.ResolveMemberAccess): No need to have
23645 any special code for MethodGroupExprs anymore, they're now
23648 2002-08-08 Martin Baulig <martin@gnome.org>
23650 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
23651 Family, FamANDAssem and FamORAssem permissions.
23652 (TypeManager.IsSubclassOrNestedChildOf): New public method.
23654 2002-08-08 Martin Baulig <martin@gnome.org>
23656 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
23657 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
23660 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
23662 * driver.cs: implemented /resource option to embed managed resources.
23664 2002-08-07 Martin Baulig <martin@gnome.org>
23666 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
23667 (FieldBase.HasFieldInitializer): New public property.
23668 (FieldBase.GetInitializerExpression): New public method. Resolves and
23669 returns the field initializer and makes sure it is only resolved once.
23670 (TypeContainer.EmitFieldInitializers): Call
23671 FieldBase.GetInitializerExpression to get the initializer, this ensures
23672 that it isn't resolved multiple times.
23674 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
23675 the resolving process (SimpleName/MemberLookup) that we're currently
23676 emitting a field initializer (which must not access any instance members,
23677 this is an error CS0236).
23679 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
23680 argument, if the `IsFieldInitializer' flag is set, we must report and
23681 error CS0236 and not an error CS0120.
23683 2002-08-07 Martin Baulig <martin@gnome.org>
23685 * ecore.cs (IMemberExpr): New public interface.
23686 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
23687 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
23688 if the expression is an IMemberExpr.
23690 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
23691 to be null, implicitly default to `this' if we're non-static in
23692 this case. Simplified the code a lot by using the new IMemberExpr
23693 interface. Also fixed bug #28176 here.
23695 2002-08-06 Martin Baulig <martin@gnome.org>
23697 * cs-parser.jay (SimpleLookup): Removed. We need to create
23698 ParameterReferences during semantic analysis so that we can do a
23699 type-only search when resolving Cast, TypeOf and SizeOf.
23700 (block): Pass the `current_local_parameters' to the Block's
23703 * class.cs (ConstructorInitializer): Added `Parameters parameters'
23704 argument to the constructor.
23705 (ConstructorInitializer.Resolve): Create a temporary implicit
23706 block with the parameters.
23708 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
23709 references here if we aren't doing a type-only search.
23711 * statement.cs (Block): Added constructor which takes a
23712 `Parameters parameters' argument.
23713 (Block.Parameters): New public property.
23715 * support.cs (InternalParameters.Parameters): Renamed `parameters'
23716 to `Parameters' and made it public readonly.
23718 2002-08-06 Martin Baulig <martin@gnome.org>
23720 * ecore.cs (Expression.Warning): Made this public as well.
23722 * report.cs (Report.Debug): Print the contents of collections.
23724 2002-08-06 Martin Baulig <martin@gnome.org>
23726 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
23727 used to tell Resolve() which kinds of expressions it may return.
23728 (Expression.Resolve): Added overloaded version of this method which
23729 takes a `ResolveFlags flags' argument. This can be used to tell
23730 Resolve() which kinds of expressions it may return. Reports a
23732 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
23733 ResolveFlags.SimpleName.
23734 (Expression.Error118): Added overloaded version of this method which
23735 takes a `ResolveFlags flags' argument. It uses the flags to determine
23736 which kinds of expressions are allowed.
23738 * expression.cs (Argument.ResolveMethodGroup): New public method.
23739 Resolves an argument, but allows a MethodGroup to be returned.
23740 This is used when invoking a delegate.
23742 * TODO: Updated a bit.
23744 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23746 Fixed compilation with csc.
23748 * ecore.cs: Expression.Error made public. Is this correct? Should
23749 Warning be made public too?
23751 * expression.cs: use ea.Location instead of ea.loc.
23752 [FIXME: Filed as bug #28607: MCS must report these errors.]
23754 2002-08-06 Martin Baulig <martin@gnome.org>
23756 * ecore.cs (Expression.loc): Moved the location here instead of
23757 duplicating it in all derived classes.
23758 (Expression.Location): New public property.
23759 (Expression.Error, Expression.Warning): Made them non-static and
23760 removed the location argument.
23761 (Expression.Warning): Added overloaded version which takes an
23762 `int level' argument.
23763 (Expression.Error118): Make this non-static and removed the
23764 expression and location arguments.
23765 (TypeExpr): Added location argument to the constructor.
23767 * expression.cs (StaticCallExpr): Added location argument to
23769 (Indirection, PointerArithmetic): Likewise.
23770 (CheckedExpr, UnCheckedExpr): Likewise.
23771 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
23772 (StringPtr): Likewise.
23775 2002-08-05 Martin Baulig <martin@gnome.org>
23777 * expression.cs (BaseAccess.DoResolve): Actually report errors.
23779 * assign.cs (Assign.DoResolve): Check whether the source
23780 expression is a value or variable.
23782 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
23783 while resolving the corresponding blocks.
23785 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
23786 an error, don't silently return null.
23788 * statement.cs (Block.AddVariable): Do the error reporting here
23789 and distinguish between CS0128 and CS0136.
23790 (Block.DoResolve): Report all unused labels (warning CS0164).
23791 (LabeledStatement): Pass the location to the constructor.
23792 (LabeledStatement.HasBeenReferenced): New property.
23793 (LabeledStatement.Resolve): Set it to true here.
23795 * statement.cs (Return.Emit): Return success even after reporting
23796 a type mismatch error (CS0126 or CS0127), this is what csc does and
23797 it avoids confusing the users with any consecutive errors.
23799 2002-08-05 Martin Baulig <martin@gnome.org>
23801 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
23803 * const.cs (Const.LookupConstantValue): Catch circular definitions.
23805 * expression.cs (MemberAccess.DoResolve): Silently return if an
23806 error has already been reported.
23808 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
23809 error has already been reported.
23811 2002-08-05 Martin Baulig <martin@gnome.org>
23813 * statement.cs (UsageVector): Only initialize the `parameters'
23814 vector if we actually have any "out" parameters.
23816 2002-08-05 Martin Baulig <martin@gnome.org>
23818 * expression.cs (Binary.ResolveOperator): When combining delegates,
23819 they must have the same type.
23821 2002-08-05 Martin Baulig <martin@gnome.org>
23823 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
23824 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
23825 work with the ms runtime and we also don't need it: if we're a
23826 PropertyBuilder and not in the `indexer_arguments' hash, then we
23827 are a property and not an indexer.
23829 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
23830 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
23831 since the latter one doesn't work with the ms runtime.
23833 2002-08-03 Martin Baulig <martin@gnome.org>
23835 Fixed bugs #27998 and #22735.
23837 * class.cs (Method.IsOperator): New public field.
23838 (Method.CheckBase): Report CS0111 if there's already a method
23839 with the same parameters in the current class. Report CS0508 when
23840 attempting to change the return type of an inherited method.
23841 (MethodData.Emit): Report CS0179 if a method doesn't have a body
23842 and it's not marked abstract or extern.
23843 (PropertyBase): New abstract base class for Property and Indexer.
23844 (PropertyBase.CheckBase): Moved here from Property and made it work
23846 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
23847 the same so we can reuse it there.
23848 (Property, Indexer): Derive from PropertyBase.
23849 (MethodSignature.inheritable_property_signature_filter): New delegate
23850 to find properties and indexers.
23852 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
23853 argument and improved error reporting.
23855 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
23856 EmptyReadOnlyParameters and made it a property.
23858 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
23859 version of this method which takes a `PropertyInfo indexer'.
23860 (TypeManager.RegisterIndexer): New method.
23862 * class.cs: Added myself as author of this file :-)
23864 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23866 * class.cs: fixed compilation on windoze.
23868 2002-08-03 Martin Baulig <martin@gnome.org>
23870 * interface.cs (Interface.GetInterfaceBases): Check whether all
23871 base interfaces are at least as accessible than the current one.
23873 * class.cs (TypeContainer.GetClassBases): Check whether base types
23874 are at least as accessible than the current type.
23875 (TypeContainer.AsAccessible): Implemented and made non-static.
23876 (MemberBase.CheckParameters): Report errors if the accessibility
23879 * delegate.cs (Delegate.Delegate): The default visibility is
23880 internal for top-level types and private for nested types.
23881 (Delegate.Define): Report errors if the accessibility checks fail.
23883 * enum.cs (Enum.Enum): The default visibility is internal for
23884 top-level types and private for nested types.
23885 (Enum.DefineType): Compute the correct visibility.
23887 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
23888 function which takes a `bool is_toplevel' instead of a TypeContainer.
23890 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
23893 2002-08-02 Martin Baulig <martin@gnome.org>
23895 * expression.cs (LocalVariableReferenc): Added constructor which
23896 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
23897 (LocalVariableReference.IsReadOnly): New property.
23898 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
23899 variable is readonly, use our own readonly flag to do this; you can
23900 use the new constructor to get a writable reference to a read-only
23903 * cs-parser.jay (foreach_statement, using_statement): Get a writable
23904 reference to the local variable.
23906 2002-08-01 Miguel de Icaza <miguel@ximian.com>
23908 * rootcontext.cs (ResolveCore): Also include System.Exception
23910 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
23911 we reach an EmptyStatement.
23913 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
23916 * expression.cs (Binary.ResolveOperator): Check error result in
23919 use brtrue/brfalse directly and avoid compares to null.
23921 2002-08-02 Martin Baulig <martin@gnome.org>
23923 * class.cs (TypeContainer.Define): Define all nested interfaces here.
23924 Fixes bug #28407, added test-155.cs.
23926 2002-08-01 Martin Baulig <martin@gnome.org>
23928 * class.cs (Event.EmitDefaultMethod): Make this work with static
23929 events. Fixes #28311, added verify-3.cs.
23931 2002-08-01 Martin Baulig <martin@gnome.org>
23933 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
23934 `is_disposable' fields.
23935 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
23936 `hm.is_disposable' if we're using the collection pattern.
23937 (Foreach.EmitCollectionForeach): Use the correct type for the
23938 enumerator's local variable, only emit the try/finally block if
23939 necessary (fixes #27713).
23941 2002-08-01 Martin Baulig <martin@gnome.org>
23943 * ecore.cs (Expression.report118): Renamed to Error118 and made
23946 * statement.cs (Throw.Resolve): Check whether the expression is of
23947 the correct type (CS0118) and whether the type derives from
23948 System.Exception (CS0155).
23949 (Catch.Resolve): New method. Do the type lookup here and check
23950 whether it derives from System.Exception (CS0155).
23951 (Catch.CatchType, Catch.IsGeneral): New public properties.
23953 * typemanager.cs (TypeManager.exception_type): Added.
23955 2002-07-31 Miguel de Icaza <miguel@ximian.com>
23957 * driver.cs: Updated About function.
23959 2002-07-31 Martin Baulig <martin@gnome.org>
23961 Implemented Control Flow Analysis.
23963 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
23964 (EmitContext.CurrentBranching): Added.
23965 (EmitContext.StartFlowBranching): Added.
23966 (EmitContext.EndFlowBranching): Added.
23967 (EmitContext.KillFlowBranching): Added.
23968 (EmitContext.IsVariableAssigned): Added.
23969 (EmitContext.SetVariableAssigned): Added.
23970 (EmitContext.IsParameterAssigned): Added.
23971 (EmitContext.SetParameterAssigned): Added.
23972 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
23973 Added control flow analysis stuff here.
23975 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
23976 resolve the expression as lvalue.
23977 (LocalVariableReference.DoResolve): Check whether the variable has
23978 already been assigned.
23979 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
23980 the parameter as assigned here.
23981 (ParameterReference.DoResolve): Check whether the parameter has already
23983 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
23984 expression as lvalue.
23986 * statement.cs (FlowBranching): New class for the flow analysis code.
23987 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
23988 (LabeledStatement.IsDefined): New public property.
23989 (LabeledStatement.AddUsageVector): New public method to tell flow
23990 analyis that the label may be reached via a forward jump.
23991 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
23993 (VariableInfo.Number): New public field. This is used by flow analysis
23994 to number all locals of a block.
23995 (Block.CountVariables): New public property. This is the number of
23996 local variables in this block (including the locals from all parent
23998 (Block.EmitMeta): Number all the variables.
24000 * statement.cs: Added flow analysis support to all classes.
24002 2002-07-31 Martin Baulig <martin@gnome.org>
24004 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
24005 To get debugging messages, compile mcs with /define:MCS_DEBUG and
24006 then use this argument.
24008 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
24010 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
24011 use this to specify /define options.
24013 2002-07-29 Martin Baulig <martin@gnome.org>
24015 * statement.cs (Fixed): Moved all code that does variable lookups
24016 and resolvings from Emit to Resolve.
24018 * statement.cs (For): Moved all code that does variable lookups
24019 and resolvings from Emit to Resolve.
24021 * statement.cs (Using): Moved all code that does variable lookups
24022 and resolvings from Emit to Resolve.
24024 2002-07-29 Martin Baulig <martin@gnome.org>
24026 * attribute.cs (Attribute.Resolve): Explicitly catch a
24027 System.NullReferenceException when creating the
24028 CustromAttributeBuilder and report a different warning message.
24030 2002-07-29 Martin Baulig <martin@gnome.org>
24032 * support.cs (ParameterData.ParameterName): Added method to
24033 get the name of a parameter.
24035 * typemanager.cs (TypeManager.IsValueType): New public method.
24037 2002-07-29 Martin Baulig <martin@gnome.org>
24039 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
24040 is a flag which specifies that it's either ref or out.
24041 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
24042 the out parameter to `out Parameter.Modifier mod', also set the
24043 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
24045 * support.cs (InternalParameters.ParameterModifier): Distinguish
24046 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24047 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24049 * expression.cs (Argument.GetParameterModifier): Distinguish
24050 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24051 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24053 2002-07-29 Martin Baulig <martin@gnome.org>
24055 * expression.cs (ParameterReference.ParameterReference): Added
24056 `Location loc' argument to the constructor.
24058 * cs-parser.jay: Pass location to ParameterReference.
24060 2002-07-28 Miguel de Icaza <miguel@ximian.com>
24062 * statement.cs (Try): Initialize the location.
24064 * cs-parser.jay: pass location to Try.
24066 * expression.cs (Unary.Reduce): Change the prototype to return
24067 whether a constant fold could be performed or not. The result is
24068 returned in an out parameters. In the case of Indirection and
24069 AddressOf, we want to perform the full tests.
24071 2002-07-26 Miguel de Icaza <miguel@ximian.com>
24073 * statement.cs (Statement.Emit): Flag dead code.
24075 2002-07-27 Andrew Birkett <andy@nobugs.org>
24077 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
24079 2002-07-27 Martin Baulig <martin@gnome.org>
24081 * class.cs (MethodData.Define): Put back call to
24082 TypeManager.AddMethod(), accidentally commented this out.
24084 * report.cs (Debug): New public method to print debugging information,
24085 this is `[Conditional ("DEBUG")]'.
24087 2002-07-26 Martin Baulig <martin@gnome.org>
24089 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
24090 (switch_statement): Push the current_block to the switch_stack and
24091 pop it again when we're done with the switch.
24092 (switch_section): The new block is a child of the current_block.
24093 Fixes bug #24007, added test-152.cs.
24095 2002-07-27 Martin Baulig <martin@gnome.org>
24097 * expression.cs (Invocation.EmitArguments): When calling a varargs
24098 function with only its fixed arguments, we need to pass an empty
24101 2002-07-27 Martin Baulig <martin@gnome.org>
24103 Mono 0.13 has been released.
24105 2002-07-25 Miguel de Icaza <miguel@ximian.com>
24107 * driver.cs: Rename --resource to --linkres, because that is what
24108 we do currently, we dont support --resource yet.
24110 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
24112 2002-07-25 Martin Baulig <martin@gnome.org>
24114 * class.cs (MethodData): New public class. This is a `method builder'
24115 class for a method or one accessor of a Property/Indexer/Event.
24116 (MethodData.GetMethodFlags): Moved here from MemberBase.
24117 (MethodData.ApplyAttributes): Likewise.
24118 (MethodData.ApplyObsoleteAttribute): Likewise.
24119 (MethodData.ApplyConditionalAttribute): Likewise.
24120 (MethodData.ApplyDllImportAttribute): Likewise.
24121 (MethodData.CheckAbstractAndExternal): Likewise.
24122 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
24123 (MethodData.Emit): Formerly known as Method.Emit().
24124 (MemberBase): Moved everything which was specific to a single
24125 accessor/method to MethodData.
24126 (Method): Create a new MethodData and call Define() and Emit() on it.
24127 (Property, Indexer, Event): Create a new MethodData objects for each
24128 accessor and call Define() and Emit() on them.
24130 2002-07-25 Martin Baulig <martin@gnome.org>
24132 Made MethodCore derive from MemberBase to reuse the code from there.
24133 MemberBase now also checks for attributes.
24135 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
24136 (MemberBase.GetMethodFlags): Moved here from class Method and marked
24138 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
24139 `CallingConventions cc' and `Attributes opt_attrs' arguments.
24140 (MemberBase.ApplyAttributes): New virtual method; applies the
24141 attributes to a method or accessor.
24142 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
24143 (MemberBase.ApplyConditionalAttribute): Likewise.
24144 (MemberBase.ApplyDllImportAttribute): Likewise.
24145 (MemberBase.CheckAbstractAndExternal): Likewise.
24146 (MethodCore.ParameterTypes): This is now a property instead of a
24147 method, it's initialized from DoDefineParameters().
24148 (MethodCore.ParameterInfo): Removed the set accessor.
24149 (MethodCore.DoDefineParameters): New protected virtual method to
24150 initialize ParameterTypes and ParameterInfo.
24151 (Method.GetReturnType): We can now simply return the MemberType.
24152 (Method.GetMethodFlags): Override the MemberBase version and add
24153 the conditional flags.
24154 (Method.CheckBase): Moved some code from Define() here, call
24155 DoDefineParameters() here.
24156 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
24157 here to avoid some larger code duplication.
24158 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
24159 ensure that abstract and external accessors don't declare a body.
24161 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
24162 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
24163 lookup in the attribute's parent classes, so we need to abort as soon
24164 as we found the first match.
24165 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
24166 the attribute has no arguments.
24168 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
24171 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24173 * cs-parser.jay: reverted previous patch.
24175 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24177 * cs-parser.jay: fixed bug #22119.
24179 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24181 * attribute.cs: fixed compilation. The error was:
24182 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
24183 be assigned to before control leaves the current method."
24184 [FIXME: Filed as bug #28186: MCS must report this error.]
24186 2002-07-25 Martin Baulig <martin@gnome.org>
24188 * attribute.cs (Attribute.Conditional_GetConditionName): New static
24189 method to pull the condition name ouf of a Conditional attribute.
24190 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
24191 the obsolete message and error flag out of an Obsolete attribute.
24193 * class.cs (Method.GetMethodFlags): New public method to get the
24194 TypeManager.MethodFlags for this method.
24195 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
24197 (Method.Define): Get and apply the Obsolete and Conditional attributes;
24198 if we're overriding a virtual function, set the new private variable
24199 `parent_method'; call the new TypeManager.AddMethod().
24201 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
24202 the MethodBuilder and the Method in a PtrHashtable.
24203 (TypeManager.builder_to_method): Added for this purpose.
24204 (TypeManager.MethodFlags): Added IsObsoleteError.
24205 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
24206 Obsolete and Conditional arguments in MethodBuilders. If we discover
24207 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
24208 the message from the attribute.
24210 2002-07-24 Martin Baulig <martin@gnome.org>
24212 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
24213 preprocessor directives, ensure that the argument to #define/#undef is
24214 exactly one identifier and that it's actually an identifier.
24216 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
24219 2002-07-24 Martin Baulig <martin@gnome.org>
24221 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
24222 initialize it to TypeManager.object_type in the constructor.
24223 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
24224 of the `hm.get_current' method if we're using the collection pattern.
24225 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
24226 for the explicit conversion to make it work when we're using the collection
24227 pattern and the `Current' property has a different return type than `object'.
24230 2002-07-24 Martin Baulig <martin@gnome.org>
24232 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
24233 does not match, but don't report any errors. This method is called in
24234 order for all methods in a MethodGroupExpr until a matching method is
24235 found, so we don't want to bail out if the first method doesn't match.
24236 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
24237 matches, report the 123. Fixes #28070.
24239 2002-07-24 Martin Baulig <martin@gnome.org>
24241 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
24242 TypeManager.TypeToCoreType() to the top of the method so the
24243 following equality checks will work. Fixes #28107.
24245 2002-07-24 Martin Baulig <martin@gnome.org>
24247 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
24248 operand is of type uint, and the other operand is of type sbyte,
24249 short or int, the operands are converted to type long." -
24250 Actually do what this comment already told us. Fixes bug #28106,
24253 2002-07-24 Martin Baulig <martin@gnome.org>
24255 * class.cs (MethodBase): New abstract class. This is now a base
24256 class for Property, Indexer and Event to avoid some code duplication
24257 in their Define() and DefineMethods() methods.
24258 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
24259 generic methods for Define() and DefineMethods().
24260 (FieldBase): Derive from MemberBase, not MemberCore.
24261 (Property): Derive from MemberBase, not MemberCore.
24262 (Property.DefineMethod): Moved all the code from this method to the
24263 new MethodBase.DefineAccessor(), just call it with appropriate
24265 (Property.Define): Call the new Property.DoDefine(), this does some
24266 sanity checks and we don't need to duplicate the code everywhere.
24267 (Event): Derive from MemberBase, not MemberCore.
24268 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
24269 accessors, this will also make them work with interface events.
24270 (Indexer): Derive from MemberBase, not MemberCore.
24271 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
24272 (Indexer.Define): Use the new MethodBase functions.
24274 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
24275 argument to the constructor.
24276 (Interface.FindMembers): Added support for interface events.
24277 (Interface.PopluateEvent): Implemented.
24279 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
24281 2002-07-22 Miguel de Icaza <miguel@ximian.com>
24283 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
24284 but this is required to check for a method name being the same as
24285 the containing class.
24289 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24291 * interface.cs: initialize variable.
24293 2002-07-23 Martin Baulig <martin@gnome.org>
24295 Implemented the IndexerName attribute in interfaces.
24297 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
24298 name if this is an explicit interface implementation.
24299 (Indexer.InterfaceIndexerName): New public variable. If we're
24300 implementing an interface indexer, this is the IndexerName in that
24301 interface. Otherwise, it's the IndexerName.
24302 (Indexer.DefineMethod): If we're implementing interface indexer,
24303 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
24304 and Pending.ImplementIndexer methods.
24305 (Indexer.Define): Also define the PropertyBuilder if we're
24306 implementing an interface indexer and this is neither an explicit
24307 interface implementation nor do the IndexerName match the one in
24310 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
24311 If a method is defined here, then we always need to create a proxy
24312 for it. This is used when implementing interface indexers.
24313 (Pending.IsInterfaceIndexer): New public method.
24314 (Pending.ImplementIndexer): New public method.
24315 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
24316 This is used when implementing interface indexers to define a proxy
24318 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
24319 define a proxy if necessary.
24321 * interface.cs (Interface.IndexerName): New public variable.
24322 (Interface.PopulateIndexer): Set the IndexerName.
24323 (Interface.DefineIndexers): New private method. Populate all the
24324 indexers and make sure their IndexerNames match.
24326 * typemanager.cs (IndexerPropertyName): Added support for interface
24329 2002-07-22 Martin Baulig <martin@gnome.org>
24331 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
24332 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
24333 ret if HasReturnLabel.
24334 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
24337 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
24338 and set the ec.LoopBeginTryCatchLevel.
24339 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
24340 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
24341 the current ec.TryCatchLevel, the branch goes out of an exception
24342 block. In this case, we need to use Leave and not Br.
24344 2002-07-22 Martin Baulig <martin@gnome.org>
24346 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
24347 block unless the block does not always return or it is contained in
24348 another try { ... } catch { ... } block. Fixes bug #26506.
24349 Added verify-1.cs to the test suite.
24351 2002-07-22 Martin Baulig <martin@gnome.org>
24353 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
24354 then we do not always return. Fixes bug #24985.
24356 2002-07-22 Martin Baulig <martin@gnome.org>
24358 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
24359 lookup on a per-class level; ie. walk up the class hierarchy until we
24360 found at least one applicable method, then choose the best among them.
24361 Fixes bug #24463 and test-29.cs.
24363 2002-07-22 Martin Baulig <martin@gnome.org>
24365 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
24366 return types of the methods. The return type is not part of the
24367 signature and we must not check it to make the `new' modifier work.
24368 Fixes bug #27999, also added test-147.cs.
24369 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
24371 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
24372 on the method's return type.
24374 2002-07-21 Martin Baulig <martin@gnome.org>
24376 * assign.cs: Make this work if the rightmost source is a constant and
24377 we need to do an implicit type conversion. Also adding a few more tests
24378 to test-38.cs which should have caught this.
24380 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
24381 target in the makefile for this. The makefile.gnu is primarily intended
24382 for end-users who don't want to debug the compiler.
24384 2002-07-21 Martin Baulig <martin@gnome.org>
24386 * assign.cs: Improved the Assign class so it can now handle embedded
24387 assignments (X = Y = Z = something). As a side-effect this'll now also
24388 consume less local variables. test-38.cs now passes with MCS, added
24389 a few new test cases to that test.
24391 2002-07-20 Martin Baulig <martin@gnome.org>
24393 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
24394 instructions. Fixes bug #27977, also added test-146.cs.
24396 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24398 * cs-tokenizer.cs: fixed getHex ().
24400 2002-07-19 Martin Baulig <martin@gnome.org>
24402 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
24403 not Type.GetType() to lookup the array type. This is needed when
24404 we're constructing an array of a user-defined type.
24405 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
24406 single-dimensional arrays, but also for single-dimensial arrays of
24409 2002-07-19 Martin Baulig <martin@gnome.org>
24411 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
24412 this function is called, it's not allowed to share LocalBuilders
24413 among ILGenerators.
24415 2002-07-19 Martin Baulig <martin@gnome.org>
24417 * expression.cs (Argument.Resolve): Report an error 118 when trying
24418 to pass a type as argument.
24420 2002-07-18 Martin Baulig <martin@gnome.org>
24422 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
24423 Conv_R_Un for the signed `long' type.
24425 2002-07-15 Miguel de Icaza <miguel@ximian.com>
24427 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
24428 `expr' for the temporary result, as that will fail if we do
24429 multiple resolves on the same expression.
24431 2002-07-05 Miguel de Icaza <miguel@ximian.com>
24433 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
24434 ec.TypeContainer for looking up aliases.
24436 * class.cs (TypeContainer): Remove LookupAlias from here.
24438 * decl.cs (DeclSpace); Move here.
24440 2002-07-01 Miguel de Icaza <miguel@ximian.com>
24442 * class.cs (FindMembers): Only call filter if the constructor
24443 bulider is not null.
24445 Also handle delegates in `NestedTypes' now. Now we will perform
24446 type lookups using the standard resolution process. This also
24449 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
24450 This uses Expressions (the limited kind that can be parsed by the
24451 tree) instead of strings.
24453 * expression.cs (ComposedCast.ToString): Implement, used to flag
24454 errors since now we have to render expressions.
24456 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
24459 * ecore.cs (SimpleName.ToString): ditto.
24461 * cs-parser.jay: Instead of using strings to assemble types, use
24462 Expressions to assemble the type (using SimpleName, ComposedCast,
24463 MemberAccess). This should fix the type lookups in declarations,
24464 because we were using a different code path for this.
24466 * statement.cs (Block.Resolve): Continue processing statements
24467 even when there is an error.
24469 2002-07-17 Miguel de Icaza <miguel@ximian.com>
24471 * class.cs (Event.Define): Also remove the `remove' method from
24472 the list of pending items.
24474 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
24475 generate more compact code.
24477 2002-07-17 Martin Baulig <martin@gnome.org>
24479 * const.cs (Const.LookupConstantValue): Add support for constant
24480 `unchecked' and `checked' expressions.
24481 Also adding test case test-140.cs for this.
24483 2002-07-17 Martin Baulig <martin@gnome.org>
24485 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
24486 check whether mi.ReturnType implements the IEnumerator interface; the
24487 `==' and the IsAssignableFrom() will fail in this situation.
24489 2002-07-16 Ravi Pratap <ravi@ximian.com>
24491 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
24494 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24496 * expression.cs: fixed bug #27811.
24498 2002-07-14 Miguel de Icaza <miguel@ximian.com>
24500 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
24501 Molaro: when we are a ref, the value already contains a pointer
24502 value, do not take the address of it.
24504 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
24505 * removed mb-parser.jay and mb-tokenizer.cs
24507 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
24509 * expression.cs: check against the building corlib void type.
24511 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
24513 * ecore.cs: fix for valuetype static readonly fields: when
24514 initializing them, we need their address, not the address of a copy.
24516 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
24518 * typemanager.cs: register also enum_type in corlib.
24520 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
24522 * class.cs: allow calling this (but not base) initializers in structs.
24524 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
24526 * ecore.cs: make sure we compare against the building base types
24529 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
24531 * typemanager.cs: fix TypeToCoreType() to handle void and object
24532 (corlib gets no more typerefs after this change).
24534 2002-07-12 Miguel de Icaza <miguel@ximian.com>
24536 * expression.cs (ArrayCreation.EmitArrayArguments): use
24537 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
24539 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
24540 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
24541 array indexes, the runtime actually forbids them.
24543 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
24544 for array arguments here.
24546 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
24547 instead of the default for ValueTypes.
24549 (New.DoEmit): Use IsValueType instead of
24550 IsSubclassOf (value_type)
24551 (New.DoResolve): ditto.
24552 (Invocation.EmitCall): ditto.
24554 * assign.cs (Assign): ditto.
24556 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
24557 Statements *are* currently doing part of their resolution during
24560 Expressions do always resolve during resolve, but statements are
24561 only required to propagate resolution to their children.
24563 2002-07-11 Miguel de Icaza <miguel@ximian.com>
24565 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
24567 (LoadAssembly): Do not add the dll if it is already specified
24569 (MainDriver): Add the System directory to the link path at the end,
24570 after all the other -L arguments.
24572 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
24573 wrong opcode for loading bytes and bools (ldelem.i1 instead of
24574 ldelem.u1) and using the opposite for sbytes.
24576 This fixes Digger, and we can finally run it.
24578 * driver.cs (UnixParseOption): Move the option parsing here.
24579 (CSCParseOption): Implement CSC-like parsing of options.
24581 We now support both modes of operation, the old Unix way, and the
24582 new CSC-like way. This should help those who wanted to make cross
24583 platform makefiles.
24585 The only thing broken is that /r:, /reference: and /lib: are not
24586 implemented, because I want to make those have the same semantics
24587 as the CSC compiler has, and kill once and for all the confussion
24588 around this. Will be doing this tomorrow.
24590 * statement.cs (Unsafe.Resolve): The state is checked during
24591 resolve, not emit, so we have to set the flags for IsUnsfe here.
24593 2002-07-10 Miguel de Icaza <miguel@ximian.com>
24595 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
24596 not catch the Error_ObjectRefRequired in SimpleName (as it is
24597 possible to have a class/instance variable name that later gets
24598 deambiguated), we have to check this here.
24600 2002-07-10 Ravi Pratap <ravi@ximian.com>
24602 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
24603 make static and put into Expression.
24605 (Event.Define): Register the private field of the event with the
24606 TypeManager so that GetFieldFromEvent can get at it.
24608 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
24609 keep track of the private field associated with an event which
24612 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
24615 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
24617 2002-07-10 Miguel de Icaza <miguel@ximian.com>
24619 * expression.cs (Binary.EmitBranchable): this routine emits the
24620 Binary expression in a branchable context. This basically means:
24621 we need to branch somewhere, not just get the value on the stack.
24623 This works together with Statement.EmitBoolExpression.
24625 * statement.cs (Statement.EmitBoolExpression): Use
24628 2002-07-09 Miguel de Icaza <miguel@ximian.com>
24630 * statement.cs (For): Reduce the number of jumps in loops.
24632 (For): Implement loop inversion for the For statement.
24634 (Break): We can be breaking out of a Try/Catch controlled section
24635 (foreach might have an implicit try/catch clause), so we need to
24636 use Leave instead of Br.
24638 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
24639 now). If the instace expression supports IMemoryLocation, we use
24640 the AddressOf method from the IMemoryLocation to extract the
24641 address instead of emitting the instance.
24643 This showed up with `This', as we were emitting the instance
24644 always (Emit) instead of the Address of This. Particularly
24645 interesting when This is a value type, as we dont want the Emit
24646 effect (which was to load the object).
24648 2002-07-08 Miguel de Icaza <miguel@ximian.com>
24650 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
24652 * statement.cs (Checked): Set the CheckedState during the resolve
24653 process too, as the ConvCast operations track the checked state on
24654 the resolve process, and not emit.
24656 * cs-parser.jay (namespace_member_declaration): Flag that we have
24657 found a declaration when we do. This is used to flag error 1529
24659 * driver.cs: Report ok when we display the help only.
24661 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
24663 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
24665 2002-07-04 Miguel de Icaza <miguel@ximian.com>
24667 * cs-tokenizer.cs (define): We also have to track locally the
24668 defines. AllDefines is just used for the Conditional Attribute,
24669 but we also need the local defines for the current source code.
24671 2002-07-03 Miguel de Icaza <miguel@ximian.com>
24673 * statement.cs (While, For, Do): These loops can exit through a
24674 Break statement, use this information to tell whether the
24675 statement is the last piece of code.
24677 (Break): Flag that we break.
24679 * codegen.cs (EmitContexts): New `Breaks' state variable.
24681 2002-07-03 Martin Baulig <martin@gnome.org>
24683 * class.cs (TypeContainer.MethodModifiersValid): Allow override
24684 modifiers in method declarations in structs. Otherwise, you won't
24685 be able to override things like Object.Equals().
24687 2002-07-02 Miguel de Icaza <miguel@ximian.com>
24689 * class.cs (Method, Property, Indexer): Do not allow the public
24690 modifier to be used in explicit interface implementations.
24692 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
24693 override modifiers in method declarations in structs
24695 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
24697 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
24698 integer or real overflow, report an error
24700 2002-07-02 Martin Baulig <martin@gnome.org>
24702 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
24703 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
24704 to tell the runtime about our newly created System.Object and
24705 System.ValueType types.
24707 2002-07-02 Miguel de Icaza <miguel@ximian.com>
24709 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
24710 struct instead of Ldarg/Starg.
24712 2002-07-02 Martin Baulig <martin@gnome.org>
24714 * expression.cs (Indirection.Indirection): Call
24715 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
24717 2002-07-02 Martin Baulig <martin@gnome.org>
24719 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
24720 ValueType, call TypeManager.TypeToCoreType() on it.
24721 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
24722 the OpCodes.Newarr argument.
24724 2002-07-02 Martin Baulig <martin@gnome.org>
24726 * expression.cs (Invocation.EmitCall): When compiling corlib,
24727 replace all calls to the system's System.Array type to calls to
24728 the newly created one.
24730 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
24731 System.Array methods.
24732 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
24733 from the system's System.Array type which must be replaced.
24735 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
24737 * typemanager.cs: load unverifiable_code_ctor so we can build
24738 corlib using the correct type. Avoid using GetTypeCode() with
24740 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
24741 TypeManager.object_type to allow building corlib.
24743 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
24745 * ecore.cs: handle System.Enum separately in LoadFromPtr().
24747 2002-07-01 Martin Baulig <martin@gnome.org>
24749 * class.cs: Make the last change actually work, we need to check
24750 whether `ifaces != null' to avoid a crash.
24752 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
24754 * class.cs: when we build structs without fields that implement
24755 interfaces, we need to add the interfaces separately, since there is
24756 no API to both set the size and add the interfaces at type creation
24759 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
24761 * expression.cs: the dimension arguments to the array constructors
24762 need to be converted if they are a long.
24764 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
24766 * class.cs: don't emit ldarg.0 if there is no parent constructor
24767 (fixes showstopper for corlib).
24769 2002-06-29 Martin Baulig <martin@gnome.org>
24771 MCS now compiles corlib on GNU/Linux :-)
24773 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
24774 ie. check for MethodImplOptions.InternalCall.
24776 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
24777 and TypeManager.attribute_type are null, so we must explicitly check
24778 whether parent is not null to find out whether it's an attribute type.
24779 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
24780 and SetBuilder, not only if the property is neither abstract nor external.
24781 This is necessary to set the MethodImplOptions on the accessor methods.
24782 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
24783 SetBuilder, see Property.Emit().
24785 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
24786 populate "System.Object", "System.ValueType" and "System.Attribute" since
24787 they've already been populated from BootCorlib_PopulateCoreTypes().
24789 2002-06-29 Martin Baulig <martin@gnome.org>
24791 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
24792 is the NullLiteral, we also need to make sure that target_type is not
24795 2002-06-29 Martin Baulig <martin@gnome.org>
24797 * rootcontext.cs (RootContext.ResolveCore): We must initialize
24798 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
24799 before calling BootstrapCorlib_ResolveDelegate ().
24801 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24803 * statement.cs: fixed build-breaker. All tests passed ok.
24805 2002-06-27 Martin Baulig <martin@gnome.org>
24807 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
24808 for System.Decimal when compiling corlib.
24810 2002-06-27 Martin Baulig <martin@gnome.org>
24812 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
24813 switch blocks which contain nothing but a default clause.
24815 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
24817 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
24819 2002-06-27 Martin Baulig <martin@gnome.org>
24821 * ecore.cs (PropertyExpr.PropertyExpr): Call
24822 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
24824 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
24825 is already a TypeBuilder.
24827 2002-06-27 Martin Baulig <martin@gnome.org>
24829 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
24830 `target_type == TypeManager.array_type', not IsAssignableFrom() in
24831 the "from an array-type to System.Array" case. This makes it work
24832 when compiling corlib.
24834 2002-06-27 Martin Baulig <martin@gnome.org>
24836 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
24837 non-static PropertyExpr, set its InstanceExpression. This makes
24838 the `ICollection.Count' property work in System/Array.cs.
24840 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
24842 * driver.cs: Made error handling more consistent. Errors now
24843 tracked by Report class, so many methods which used to return int
24844 now return void. Main() now prints success/failure and
24845 errors/warnings message.
24847 Renamed '--probe' compiler argument to '--expect-error'. Removed
24848 the magic number return values (123 and 124). Now, if the
24849 expected error occurs, the compiler exits with success (exit value
24850 0). If the compilation completes without seeing that particular
24851 error, the compiler exits with failure (exit value 1). The
24852 makefile in mcs/errors has been changed to handle the new behaviour.
24854 * report.cs: Made 'expected error' number a property and renamed
24855 it from 'Probe' to 'ExpectedError'.
24857 * genericparser.cs: Removed error handling support, since it is
24858 now all done by Report class.
24860 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
24861 class, so parse() no longer returns an int.
24863 * namespace.cs: Use Report.Error instead of GenericParser.error
24865 2002-06-22 Miguel de Icaza <miguel@ximian.com>
24867 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
24868 TypeContainer.AddOperator): At the front of the list put the
24869 explicit implementations, so they get resolved/defined first.
24871 2002-06-21 Miguel de Icaza <miguel@ximian.com>
24873 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
24874 interface type is implemented by this TypeContainer. Used during
24875 explicit interface implementation.
24877 (Property.Define, Indexer.Define, Method.Define): Validate that
24878 the given interface in the explicit implementation is one of the
24879 base classes for the containing type.
24881 Also if we are explicitly implementing an interface, but there is
24882 no match in the pending implementation table, report an error.
24884 (Property.Define): Only define the property if we are
24885 not explicitly implementing a property from an interface. Use the
24886 correct name also for those properties (the same CSC uses,
24887 although that is really not needed).
24889 (Property.Emit): Do not emit attributes for explicitly implemented
24890 properties, as there is no TypeBuilder.
24892 (Indexer.Emit): ditto.
24894 Hiding then means that we do not really *implement* a pending
24895 implementation, which makes code fail.
24897 2002-06-22 Martin Baulig <martin@gnome.org>
24899 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
24900 the return value of Object.GetType(). [FIXME: we need to do this whenever
24901 we get a type back from the reflection library].
24903 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
24905 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
24907 2002-06-20 Miguel de Icaza <miguel@ximian.com>
24909 * attribute.cs: Return null if we can not look up the type.
24911 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
24912 the interface types found.
24914 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
24915 interface types found.
24917 * typemanager.cs (GetInterfaces): Make this routine returns alll
24918 the interfaces and work around the lame differences between
24919 System.Type and System.Reflection.Emit.TypeBuilder in the results
24920 result for GetInterfaces.
24922 (ExpandInterfaces): Given an array of interface types, expand and
24923 eliminate repeated ocurrences of an interface. This expands in
24924 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
24927 2002-06-21 Martin Baulig <martin@gnome.org>
24929 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
24932 2002-06-21 Martin Baulig <martin@gnome.org>
24934 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
24935 and called with one of the core types, return the corresponding typebuilder for
24938 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
24941 2002-06-21 Martin Baulig <martin@gnome.org>
24943 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
24944 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
24945 (Expression.ConvertReferenceExplicit): Likewise.
24947 * expression.cs (ElementAccess.DoResolve): Likewise.
24948 (ElementAccess.DoResolveLValue): Likewise.
24950 2002-06-10 Martin Baulig <martin@gnome.org>
24952 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
24953 add the "value" parameter to the parameter list.
24955 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
24958 2002-06-19 Miguel de Icaza <miguel@ximian.com>
24960 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
24961 the argument to an int, uint, long or ulong, per the spec. Also
24962 catch negative constants in array creation.
24964 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
24966 * class.cs: do not allow the same interface to appear twice in
24967 the definition list.
24969 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
24971 * ecore.cs: don't use ldlen with System.Array.
24973 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
24975 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
24977 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
24979 * modifiers.cs: produce correct field attributes for protected
24980 internal. Easy fix so miguel can work on ther harder stuff:-)
24982 2002-06-18 Miguel de Icaza <miguel@ximian.com>
24984 * pending.cs: New file. Move the code from class.cs here.
24985 Support clearning the pending flag for all methods (when not doing
24986 explicit interface implementation).
24988 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
24990 * rootcontext.cs: added a couple more types needed to bootstrap.
24992 2002-06-17 Miguel de Icaza <miguel@ximian.com>
24994 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
24995 constructor in the type, instead of any constructor in the type
24996 hierarchy. Thanks to Paolo for finding this bug (it showed up as
24997 a bug in the Mono runtime when applying the params attribute).
24999 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25000 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
25002 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
25004 * expression.cs (Unary.ResolveOperator): Use TypeManager
25005 to resolve the type.
25007 2002-06-13 Ravi Pratap <ravi@ximian.com>
25009 * cs-parser.jay (enum_member_declaration): Pass in the attributes
25012 * enum.cs (AddEnumMember): Add support to store the attributes associated
25013 with each member too.
25015 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
25016 field builders too - this takes care of the enum member case.
25018 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
25020 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
25021 address-of operator on both value types and pointers.
25023 2002-06-10 Martin Baulig <martin@gnome.org>
25025 * interface.cs (Interface.PopulateIndexer): Add the indexer's
25026 PropertyBuilder to the `property_builders' list.
25028 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
25029 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
25030 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
25031 find any indexers which are inherited from an interface.
25033 2002-06-09 Martin Baulig <martin@gnome.org>
25035 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
25036 the same type as the constant if necessary. There's also a test-130.cs
25039 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
25041 * typemanager.cs (TypeManager.ChangeType): Previously known as
25042 Enum.ChangeEnumType().
25044 2002-06-09 Martin Baulig <martin@gnome.org>
25046 * expression.cs (Cast.TryReduce): Added support for consts.
25048 2002-06-08 Ravi Pratap <ravi@ximian.com>
25050 * class.cs (Accessor): Hold attributes information so we can pass
25053 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
25054 Modify to pass in attributes attached to the methods.
25056 (add_accessor_declaration, remove_accessor_declaration): Ditto.
25058 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
25059 to handle the Accessor kind :-)
25061 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
25063 2002-06-08 Martin Baulig <martin@gnome.org>
25065 * expression.cs (Unary.TryReduceNegative): Added support for
25068 2002-06-08 Martin Baulig <martin@gnome.org>
25070 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
25071 name can't be found in the `defined_names' - the caller will do a
25072 MemberLookup in this case and thus find methods in System.Enum
25073 such as Enum.IsDefined().
25075 2002-06-08 Martin Baulig <martin@gnome.org>
25077 * enum.cs (Enum.ChangeEnumType): This is a custom version of
25078 Convert.ChangeType() which works with TypeBuilder created types.
25079 (Enum.LookupEnumValue, Enum.Define): Use it here.
25081 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
25082 `TypeBuilder.BaseType != null' check.
25083 (TypeContainer.FindMembers): Only lookup parent members if we
25084 actually have a parent.
25085 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
25086 (ConstructorInitializer.Resolve): Likewise.
25088 * interface.cs (Interface.FindMembers): Added
25089 `TypeBuilder.BaseType != null' check.
25091 * rootcontext.cs (RootContext.ResolveCore): Added
25092 "System.Runtime.CompilerServices.IndexerNameAttribute" to
25093 classes_second_stage.
25095 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
25096 debug_type and trace_type when compiling with --nostdlib.
25098 2002-06-07 Martin Baulig <martin@gnome.org>
25100 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
25101 (AddField): Set it to true when adding a non-static field.
25102 (DefineType): Use `have_nonstatic_fields' to find out whether we
25103 have non-static fields, not `Fields != null'.
25105 2002-06-02 Miguel de Icaza <miguel@ximian.com>
25107 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
25108 dereferencing a null on the static-field code path)
25110 2002-05-30 Martin Baulig <martin@gnome.org>
25112 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
25113 to take command line arguments. Use reflection to call the new
25114 custom `Initialize' function on the symbol writer and pass it the
25115 command line arguments.
25117 * driver.cs (--debug-args): New command line argument to pass command
25118 line arguments to the symbol writer.
25120 2002-05-28 Miguel de Icaza <miguel@ximian.com>
25122 * assign.cs (DoResolve): Forgot to do the implicit conversion to
25123 the target type for indexers and properties. Thanks to Joe for
25126 2002-05-27 Miguel de Icaza <miguel@ximian.com>
25128 * typemanager.cs (MethodFlags): returns the method flags
25129 (Obsolete/ShouldIgnore) that control warning emission and whether
25130 the invocation should be made, or ignored.
25132 * expression.cs (Invocation.Emit): Remove previous hack, we should
25133 not do this on matching a base type, we should do this based on an attribute
25135 Only emit calls to System.Diagnostics.Debug and
25136 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
25137 on the command line.
25139 * rootcontext.cs: Global settings for tracing and debugging.
25141 * cs-tokenizer.cs (define): New utility function to track
25142 defines. Set the global settings for TRACE and DEBUG if found.
25144 2002-05-25 Ravi Pratap <ravi@ximian.com>
25146 * interface.cs (Populate*): Pass in the TypeContainer as well as
25147 the DeclSpace as parameters so that we can create EmitContexts and
25148 then use that to apply attributes etc.
25150 (PopulateMethod, PopulateEvent, PopulateProperty)
25151 (PopulateIndexer): Apply attributes everywhere.
25153 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
25156 (ApplyAttributes): Update accordingly.
25158 We now apply interface attributes for all members too.
25160 2002-05-26 Miguel de Icaza <miguel@ximian.com>
25162 * class.cs (Indexer.Define); Correctly check if we are explicit
25163 implementation (instead of checking the Name for a ".", we
25164 directly look up if the InterfaceType was specified).
25166 Delay the creation of the PropertyBuilder.
25168 Only create the PropertyBuilder if we are not an explicit
25169 interface implementation. This means that explicit interface
25170 implementation members do not participate in regular function
25171 lookups, and hence fixes another major ambiguity problem in
25172 overload resolution (that was the visible effect).
25174 (DefineMethod): Return whether we are doing an interface
25177 * typemanager.cs: Temporary hack until we get attributes in
25178 interfaces (Ravi is working on that) and we get IndexerName
25179 support in interfaces.
25181 * interface.cs: Register the indexers as properties.
25183 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
25184 warning, I have verified that this is a bug in the .NET runtime
25185 (JavaScript suffers of the same problem).
25187 * typemanager.cs (MemberLookup): When looking up members for
25188 interfaces, the parent of an interface is the implicit
25189 System.Object (so we succeed in searches of Object methods in an
25190 interface method invocation. Example: IEnumerable x; x.ToString
25193 2002-05-25 Miguel de Icaza <miguel@ximian.com>
25195 * class.cs (Event): Events should also register if they do
25196 implement the methods that an interface requires.
25198 * typemanager.cs (MemberLookup); use the new GetInterfaces
25201 (GetInterfaces): The code used to lookup interfaces for a type is
25202 used in more than one place, factor it here.
25204 * driver.cs: Track the errors at the bottom of the file, we kept
25207 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
25208 instance if the method we are calling is static!
25210 2002-05-24 Miguel de Icaza <miguel@ximian.com>
25212 * attribute.cs (ApplyAttributes): Make this function filter out
25213 the IndexerName attribute (as that attribute in reality is never
25214 applied) and return the string constant for the IndexerName
25217 * class.cs (TypeContainer.Emit): Validate that all the indexers
25218 have the same IndexerName attribute, and if so, set the
25219 DefaultName attribute on the class.
25221 * typemanager.cs: The return value might contain other stuff (not
25222 only methods). For instance, consider a method with an "Item"
25223 property and an Item method.
25225 * class.cs: If there is a problem with the parameter types,
25228 2002-05-24 Ravi Pratap <ravi@ximian.com>
25230 * ecore.cs (ImplicitConversionExists): Wrapper function which also
25231 looks at user defined conversion after making a call to
25232 StandardConversionExists - we need this for overload resolution.
25234 * expression.cs : Update accordingly the various method calls.
25236 This fixes 2 bugs filed against implicit user defined conversions
25238 2002-05-22 Miguel de Icaza <miguel@ximian.com>
25240 * statement.cs: Track the result of the assignment.
25242 2002-05-21 Miguel de Icaza <miguel@ximian.com>
25244 * expression.cs (MemberAccess): Improved error reporting for
25245 inaccessible members.
25247 2002-05-22 Martin Baulig <martin@gnome.org>
25249 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
25250 itself with debugging support.
25252 2002-05-22 Martin Baulig <martin@gnome.org>
25254 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
25255 Removed, this isn't needed anymore.
25257 2002-05-20 Martin Baulig <martin@gnome.org>
25259 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
25260 be underlying type for an enum.
25262 2002-05-20 Miguel de Icaza <miguel@ximian.com>
25264 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
25265 that splits out the loading of just the core types.
25267 * rootcontext.cs (ResolveCore): Split the struct resolution in
25268 two, so we can load the enumeration underlying types before any
25271 * expression.cs (Is): Bandaid until we fix properly Switch (see
25272 bug #24985 for details).
25274 * typemanager.cs (ImplementsInterface): The hashtable will contain
25275 a null if there are no interfaces implemented.
25277 2002-05-18 Miguel de Icaza <miguel@ximian.com>
25279 * cs-parser.jay (indexer_declarator): It is fine to have array
25282 2002-05-17 Miguel de Icaza <miguel@ximian.com>
25284 * typemanager.cs: (RegisterBuilder): New function used to register
25285 TypeBuilders that implement interfaces. Since
25286 TypeBuilder.GetInterfaces (as usual) does not work with lame
25288 (AddUserType): register interfaces.
25290 (ImplementsInterface): Use the builder_to_ifaces hash if we are
25291 dealing with TypeBuilder. Also, arrays are showing up as
25292 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
25293 methods can not be invoked on them!
25295 * ecore.cs (ExplicitReferenceConversionExists): Made public.
25296 (ImplicitReferenceConversionExists): Split out from
25297 StandardConversionExists.
25299 * expression.cs (As): We were only implementing one of the three
25300 cases for the as operator. We now implement them all.
25301 (Is): Implement the various other cases for Is as well.
25303 * typemanager.cs (CACHE): New define used to control if we want or
25304 not the FindMembers cache. Seems to have a negative impact on
25305 performance currently
25307 (MemberLookup): Nested types have full acess to
25308 enclosing type members
25310 Remove code that coped with instance/static returns for events, we
25311 now catch this in RealFindMembers.
25313 (RealFindMembers): only perform static lookup if the instance
25314 lookup did not return a type or an event.
25316 2002-05-17 Miguel de Icaza <miguel@ximian.com>
25318 * assign.cs (CompoundAssign): We pass more semantic information
25319 now to Compound Assignments than we did before: now we have all
25320 the information at hand, and now we resolve the target *before* we
25321 do the expression expansion, which allows the "CacheValue" method
25322 to have the effect we intended (before, a [x] += 1 would generate
25323 two differen ArrayAccess expressions from the ElementAccess,
25324 during the resolution process).
25326 (CompoundAssign.DoResolve): Resolve target and original_source here.
25328 2002-05-16 Miguel de Icaza <miguel@ximian.com>
25330 * expression.cs (ArrayAccess): dropped debugging information.
25332 * typemanager.cs: Small bug fix: I was always returning i_members,
25333 instead of one of i_members or s_members (depending on which had
25336 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
25337 method is invoked before any code generation takes place, and it
25338 is a mechanism to inform that the expression will be invoked more
25339 than once, and that the method should use temporary values to
25340 avoid having side effects
25342 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
25344 * ecore.cs (Expression.CacheTemporaries): Provide empty default
25347 * expression.cs (Indirection, ArrayAccess): Add support for
25348 CacheTemporaries in these two bad boys.
25350 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
25351 ldobj or ldind_ref.
25352 (StoreFromPtr): Handle stobj as well.
25354 * expression.cs (UnaryMutator): Share more code.
25356 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
25357 down: I was not tracking the Filter function as well, which
25358 was affecting the results of the cache.
25360 2002-05-15 Miguel de Icaza <miguel@ximian.com>
25362 * attribute.cs: Remove the hack to handle the CharSet property on
25365 2002-05-14 Miguel de Icaza <miguel@ximian.com>
25367 * attribute.cs (DoResolve): More uglyness, we now only try to
25368 resolve the attribute partially, to extract the CharSet
25369 information (only if we are a StructLayout attribute). Otherwise
25371 (GetExtraTypeInfo): Add some code to conditionally kill in the
25372 future this. I am more and more convinced that the .NET
25373 framework has special code to handle the attribute setting on
25376 * expression.cs (IsParamsMethodApplicable): Revert my previous
25377 foreach change here, it was wrong.
25379 2002-05-13 Miguel de Icaza <miguel@ximian.com>
25381 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
25382 (pp_expr): do not abort on unknown input, just return.
25383 (eval): abort if there are pending chars.
25385 * attribute.cs (Attribute.Resolve): Positional parameters are
25386 optional. Deal with that case.
25388 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
25389 the Ansi/Unicode/Auto information for the type.
25391 (TypeContainer.DefineType): instantiate the EmitContext here, as
25392 we will be using it during the type definition (to resolve
25393 attributes) and during the emit phase.
25395 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
25396 to pull type information out of the attributes
25398 (Attribute.Resolve): track the constructor builder, and allow for
25399 multiple invocations (structs and classes will use this).
25401 * ecore.cs (MemberLookupFinal): new version with all the
25402 parameters customizable.
25404 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
25405 constructors. Return if the result value is null (as the error
25406 would have been flagged already by MemberLookupFinal)
25408 Do not allow instances of abstract classes or interfaces to be
25411 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
25412 We have to compare the assembly property here when dealing with
25413 FamANDAssem and Assembly access modifiers, because we might be
25414 creating an assembly from *modules* (that means that we are not
25415 getting TypeBuilders for types defined in other modules that are
25416 part of this assembly).
25418 (Method.Emit): If the method is marked abstract and has a body,
25421 (TypeContainer.DefineMembers): If both the defined member and the
25422 parent name match are methods, then do not emit any warnings: let
25423 the Method.Define routine take care of flagging warnings. But if
25424 there is a mismatch (method overrides something else, or method is
25425 overriwritten by something, then emit warning).
25427 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
25428 set to null, this means `do not check for the return type on the
25431 (Method.Define): set the return type for the method signature to
25432 null, so that we get methods with the same name and parameters and
25433 different return types. This is used to flag warning 114 (you are
25434 hiding a method, and you probably want to use the new/override
25437 * typemanager.cs (MemberLookup): Implemented proper access
25438 control, closing a long standing set of bug reports. The problem
25439 was that the Framework only has two bits: Public and NonPublic,
25440 and NonPublic includes private and protected methods, but we need
25441 to enforce the FamANDAssem, FamOrAssem and Family.
25443 2002-05-11 Miguel de Icaza <miguel@ximian.com>
25445 * statement.cs (GotoCase): Return true: Ammounts to giving up
25446 knowledge on whether we return or not, and letting the other case
25447 be responsible for it.
25449 2002-05-10 Miguel de Icaza <miguel@ximian.com>
25451 * driver.cs: Do not load directories for each file processed, only
25452 do it if there is a pattern.
25454 * ecore.cs: Report readonly assigns here as well, as we might have
25455 been resolved only by MemberAccess.
25457 (SimpleName.SimpleNameResolve): Also be useful for LValue
25458 resolution. We need this to propagate assign to local readonly variables
25460 * typemanager.cs: Use a ptrhashtable for the criteria, because we
25461 do not want to reuse potential criteria memory.
25463 * class.cs (MyEventBuilder): Set reflected_type;
25465 * ecore.cs (Constantify): Added support for constifying bools.
25467 (RootContext.LookupType): Added a cache for values looked up in
25468 the declaration space.
25470 * typemanager.cs (FindMembers): Now is a front-end to
25471 RealFindMembers, and provides a two-level hashtable-based cache to
25474 15% performance improvement: from 22.5 to 19.2 seconds.
25476 * expression.cs (IsParamsMethodApplicable): use foreach.
25477 (Invocation.DoResolve): ditto.
25478 (New.DoResolve): ditto.
25479 (ArrayCreation.DoResolve): ditto.
25481 * ecore.cs (FindMostEncompassingType): use foreach.
25483 * delegate.cs (NewDelegate.DoResolve): Use foreach
25485 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
25486 (RemoveMethods): use foreach.
25488 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
25489 nested foreach statements instead of for, and also break out of
25490 the inner loop once a match is found.
25492 (Invocation.OverloadResolve): Use foreach, simplify the code.
25494 2002-05-08 Miguel de Icaza <miguel@ximian.com>
25496 * cfold.cs (BinaryFold): During an enumeration evaluation context,
25497 we actually unwrap the expression to allow for extra information
25500 * expression.cs: Use Shr_Un on unsigned operations.
25502 2002-05-08 Ravi Pratap <ravi@ximian.com>
25504 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
25505 applicable operators was not being considered correctly. This closes
25506 the bug Miguel reported.
25508 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
25510 * attribute.cs: check that the type derives from System.Attribute
25511 and report the correct error in that case (moved the duplicate code to
25512 its own method, too).
25514 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
25516 * attribute.cs: lookup attribute type name as the spec says: first the
25517 bare attribute name and then name + "Attribute" (nant compiles with
25518 mcs after this fix).
25520 2002-05-07 Miguel de Icaza <miguel@ximian.com>
25522 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
25523 Because of the way we parse things, we should try to see if a
25524 UIntConstant can fit in an integer.
25526 2002-05-07 Ravi Pratap <ravi@ximian.com>
25528 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
25529 when we are in an explicit context.
25531 (ConvertReferenceExplicit): When converting from Iface type S to Class
25532 T make sure the rules are implemented as an OR.
25534 * parameter.cs (ParameterType): Make it a property for now although the
25535 purpose really isn't anything immediate.
25537 * expression.cs (Is*Applicable): Do better checking on the parameter type
25538 of a ref/out parameter. The ones from the system assemblies are already
25539 marked with the correct type so we don't need to do any correction.
25541 * ecore.cs (StandardConversionExists): Conversion from Interface types to
25542 the object type is standard too so include that.
25544 2002-05-06 Miguel de Icaza <miguel@ximian.com>
25546 * ecore.cs (StandardConversionExists): Augment with missing code:
25547 deal with IntConstant, LongConstants and Enumerations.
25549 * assign.cs: Report the error, instead of failing silently
25551 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
25552 typecontainer that they are declared, because the
25553 typecontainer/namespace will have the list of using clauses that
25554 need to be applied.
25556 Assembly Attributes were escaping the normal registration
25559 (EmitCode): Apply attributes within an EmitContext that represents
25560 the container they were declared on.
25562 * cs-parser.jay: Track bases for structs. How did I get this wrong?
25564 2002-05-06 Ravi Pratap <ravi@ximian.com>
25566 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
25567 Revamp completely - make much cleaner as we now operate only
25570 (FindMostSpecificSource, FindMostSpecificTarget): New methods
25571 to implement the logic detailed in the spec more correctly.
25573 (UserDefinedConversion): Update accordingly.
25575 2002-05-06 Miguel de Icaza <miguel@ximian.com>
25577 * statement.cs: Return flow analysis information up.
25579 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
25582 (token): Do not consume an extra character before calling
25585 2002-05-06 Piers Haken <piersh@friskit.com>
25587 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
25589 2002-05-06 Miguel de Icaza <miguel@ximian.com>
25591 * class.cs (Constructor.Emit): Set the IsStatic flag in the
25592 EmitContext during the instance constructor initializer
25593 resolution, to stop access to instance variables.
25595 This is mandated by the spec, last paragraph of the `constructor
25596 initializers' section.
25598 2002-05-05 Miguel de Icaza <miguel@ximian.com>
25600 * cs-parser.jay, class.cs (Accessor): new class used to represent
25601 an accessor (get or set). In the past we used `null' to represent
25602 a missing accessor. But this is ambiguous because there was no
25603 way to tell in abstract indexers/properties if one of them was
25606 Now there is a way of addressing that.
25608 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
25609 instead of FindMembers.
25611 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
25612 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
25614 * attribute.cs: Treat indexers and properties as the same in terms
25615 of applying attributes
25617 * ecore.cs (FindMostEncompassedType): Use statically initialized
25618 EmptyExpressions()s like we do elsewhere to avoid creating useless
25619 objects (and we take this out of the tight loop).
25621 (GetConversionOperators): Move the code to extract the actual
25622 operators to a separate routine to clean things up.
25624 2002-05-04 Miguel de Icaza <miguel@ximian.com>
25626 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
25627 events are always registered FieldBuilders.
25629 * class.cs (FieldBase): New class shared by Fields
25631 * delegate.cs: If we are a toplevel delegate, use our full name.
25632 If we are a nested delegate, then only use our tail name.
25634 2002-05-02 Ravi Pratap <ravi@ximian.com>
25636 * expression.cs (IsApplicable): Ensure that we add the "&" to
25637 ref/out types before comparing it with the type of the argument.
25639 (IsParamsMethodApplicable): Ditto.
25641 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
25644 * delegate.cs : Handle the case when we have more than one applicable
25645 method. Flag an error only when we finish checking all.
25647 2002-05-02 Miguel de Icaza <miguel@ximian.com>
25649 * expression.cs: Add support for boolean static initializers.
25651 2002-05-01 Miguel de Icaza <miguel@ximian.com>
25653 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
25655 * parameter.cs (ComputeParameterTypes,
25656 ComputeAndDefineParameterTypes): Better error handling: now we
25657 clear the `types' cache if we fail during any of the type lookups.
25658 We also return the status code correctly to our caller
25660 * delegate.cs: If we fail to define a delegate, abort the extra
25663 * expression.cs (Binary.ResolveOperator): for
25664 operator==(object,object) and operator !=(object, object) we also
25665 have to verify that there is an implicit conversion from one to
25668 (ArrayAccess.DoResolve): Array Access can operate on
25671 2002-04-30 Miguel de Icaza <miguel@ximian.com>
25673 * assign.cs (CompoundAssign): A new class used as a "flag" that
25674 the assignment actually is happening as part of a compound
25675 assignment operator.
25677 During compound assignment, a few new rules exist to enable things
25684 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
25685 to the type of x) if y is implicitly convertible to the type of x,
25686 and the operator is a builtin operator and the return type of the
25687 operator is explicitly convertible to the type of x.
25689 * rootcontext.cs: Reset warning level to 2. 4 catches various
25690 "interesting" features in mcs, we must clean this up at some
25691 point, but currently am trying to kill other bugs ;-)
25693 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
25694 in container classes as well.
25696 * expression.cs (Binary.ResolveOperator): Handle string case
25697 before anything else (as operator overloading does emit an error
25698 before doing anything else).
25700 This code could go away when we move to a table driven model, but
25701 i could not come up with a good plan last night.
25703 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
25705 * typemanager.cs (CSharpName): reimplementation using regex.
25706 * class.cs: added null check for fields in Emit
25707 * rootcontext.cs: set warninglevel to 4
25709 2002-04-29 Miguel de Icaza <miguel@ximian.com>
25711 * typemanager.cs (CSharpName): reimplemented with Lupus
25714 2002-04-28 Miguel de Icaza <miguel@ximian.com>
25716 * statement.cs (If): correclty implement Resolve, because we were
25717 not catching sem errors in there. The same process is needed
25719 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
25722 (Statement.Warning_DeadCodeFound): Factorize code.
25723 (While): Report dead code here too.
25725 (Statement): Added Resolve virtual method to allow
25726 for resolution split from the emit code.
25728 2002-04-26 Miguel de Icaza <miguel@ximian.com>
25730 * statement.cs (EmitBoolExpression): No longer try to resolve the
25732 (MakeBoolean): New utility function that resolve, implicitly
25733 converts to boolean and tags the expression.
25736 (If, Do): Implement dead code elimination.
25737 (While): Implement loop inversion
25739 (Do, While, For, If): Resolve the expression prior to calling our
25742 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
25745 - added method Report28 (warning: program has more than one entry point)
25746 - added method IsEntryPoint, implements paragraph 10.1 of the spec
25747 - modified method Method.Define, the part at the end of the method
25749 * rootcontext.cs: added static public Location EntryPointLocation;
25751 * ../errors/cs0028.cs : Add test case for the above warning.
25754 - modified method CSharpName to allow arrays of primitive type to
25755 be printed nicely (e.g. instead of System.Int32[][] it now prints
25757 - added method CSharpSignature: returns the signature of a method
25758 in string format to be used in reporting errors, warnings, etc.
25760 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
25763 2002-04-26 Ravi Pratap <ravi@ximian.com>
25765 * delegate.cs (Define): Fix extremely silly bug where I was
25766 setting the type of the 'object' parameter of the BeginInvoke
25767 method to System.IAsyncResult instead of System.Object ;-)
25769 2002-04-26 Miguel de Icaza <miguel@ximian.com>
25771 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
25774 (Constructor.Emit): return if we fail to initialize the
25775 constructor. Another door closed!
25777 * expression.cs (New.DoResolve): Improve error message (from -6 to
25778 1501). Use DeclaredOnly lookup to find the exact constructor.
25780 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
25781 loop. This is useful.
25783 * cs-parser.jay: Adjust the default parameters so that destructors
25784 have the proper signature.
25786 2002-04-26 Martin Baulig <martin@gnome.org>
25788 * driver.cs (LoadAssembly): If `assembly' contains any characters
25789 which are only valid in path names and not in assembly names
25790 (currently slash, backslash and point), use Assembly.LoadFrom ()
25791 instead of Assembly.Load () on the `assembly' (before iteration
25792 over the link_paths).
25794 2002-04-26 Martin Baulig <martin@gnome.org>
25796 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
25798 2002-04-25 Miguel de Icaza <miguel@ximian.com>
25800 * class.cs (Property): use the new typemanager.MemberLookup
25802 (TypeContainer.MemberLookup): Implement using the
25803 TypeManager.MemberLookup now.
25805 * typemanager.cs: Make MemberLookup a function of the TypeManager,
25806 and return MemberInfos, so that these can be used without an
25807 EmitContext (what we had before).
25809 2002-04-24 Miguel de Icaza <miguel@ximian.com>
25811 * expression.cs: Fix the case where the argument to params if the
25812 type of the params. I omitted handling this before. Fixed
25814 2002-04-22 Miguel de Icaza <miguel@ximian.com>
25816 * driver.cs: Call BootCorlib_PopulateCoreType
25818 * class.cs (Property.CheckBase): Check for properties only, not
25821 * interface.cs: Temporary hack: try/catch around the
25822 CustomAttributeBuilder, because I am getting an exception that I
25825 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
25826 types whose definitions are required to be there (attributes are
25827 defined before standard types).
25829 Compute definitions as we boot the various types, as they are used
25830 immediately (value_type class will need object_type, but if we do
25831 not initialize object_type, we will pass a null, which will let
25832 the runtime pick the System.Object from the existing corlib, which
25833 is not what we want).
25835 2002-04-22 Patrik Torstensson <totte@labs2.com>
25837 * cs-tokenizer.cs: fixed a number of trim() issues.
25839 2002-04-22 Ravi Pratap <ravi@ximian.com>
25841 * expression.cs (Argument.Type): Ensure that we return the correct
25842 type when we have out or ref parameters [in which case we
25845 2002-04-22 Miguel de Icaza <miguel@ximian.com>
25847 * class.cs (Property, Indexer): Allow extern modifier in there.
25849 * typemanager.cs (InitBaseTypes): Initializes object_type and
25850 value_type, since those will be used early on during the bootstrap
25851 process to compile corlib.
25853 (InitCoreTypes): Move code from here to InitBaseTypes.
25855 2002-04-21 Miguel de Icaza <miguel@ximian.com>
25857 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
25858 single-dimension arrays as using the ldlen opcode.
25860 Daniel Lewis discovered this optimization.
25862 * typemanager.cs: Add signature for System.Array::get_Length
25864 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25866 * statement.cs: report the error when the foreach does not apply to an
25867 array nor a collection.
25869 2002-04-19 Miguel de Icaza <miguel@ximian.com>
25871 * expression.cs: Add implicit conversions to the operator ~.
25873 * constant.cs (DecimalConstant.Emit): Emit decimal value.
25875 * typemanager.cs: Locate the decimal constructor.
25877 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25879 * attribute.cs: use the new property of TypeOf.
25880 * expression.cs: added 'get' property around typearg.
25882 These changes fix a build breaker reported by NickD. Is this the
25883 correct way to fix? If not, please, revert my changes and make it
25886 2002-04-17 Miguel de Icaza <miguel@ximian.com>
25888 * attribute.cs: Add support for typeof in attribute invocations.
25889 I am not sure that this is right though.
25891 2002-04-14 Duncan Mak <duncan@ximian.com>
25893 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
25894 Binary.Operator.Division case.
25896 2002-04-13 Ravi Pratap <ravi@ximian.com>
25898 * class.cs (DefineType): Ensure that we do a proper check on
25899 attribute types and also register it with the TypeManager.
25901 (TypeContainer.Targets): The default for attribute types is
25902 AttributeTargets.All.
25904 * attribute.cs (ApplyAttributes): Registering the attribute type
25905 is done elsewhere, not when we discover we have a Usage attribute.
25907 2002-04-12 Ravi Pratap <ravi@ximian.com>
25909 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
25910 and get rid of is_delegate parameter.
25912 * everywhere : update.
25914 2002-04-12 Ravi Pratap <ravi@ximian.com>
25916 * cs-parser.jay (compilation_unit): Revamp completely to use
25917 some new ideas that I got from Rhys' grammar to solve the problems
25918 with assembly level attributes.
25920 (outer_declaration): New grammar production.
25922 (attribute_sections): Add.
25924 (opt_attributes): Base on attribute_sections
25926 (namespace_declaration): Allow opt_attributes to tackle the case
25927 when we have assembly level attributes - we are clever in this
25930 * attribute.cs (ApplyAttributes): Do not worry about assembly
25931 attributes in the non-global context.
25933 * rootcontext.cs (AddGlobalAttributes): Go back to using this
25934 instead of SetGlobalAttributes.
25936 * class.cs, rootcontext.cs : Ensure we define and generate
25937 attribute types before anything else.
25939 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
25940 and flag the new error -20 for the case when the attribute type
25941 does not have valid targets specified. csc does not catch this.
25943 * ../errors/errors.txt : update for error # -20
25945 2002-04-11 Ravi Pratap <ravi@ximian.com>
25947 * support.cs (InternalParameters.ParameterModifier): Do some null
25948 checking and return sane values.
25950 * class.cs (Method.Define): If we are a PInvoke method, ensure
25951 that we are static and extern. Report error # 601
25953 * ../errors/cs0601.cs : Add test case for the above error.
25955 2002-04-07 Ravi Pratap <ravi@ximian.com>
25957 * rootcontext.cs (attribute_types): We need to keep type of
25958 all attribute types separately and emit code for them first.
25960 (RegisterAttribute) : Implement.
25962 * class.cs (DefineType): Check if the current Type is a custom
25963 attribute type and register it accordingly.
25965 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
25966 adding the first attribute twice and rename to
25968 (SetGlobalAttributes): this.
25970 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
25973 * attribute.cs (ApplyAttributes): Take an additional argument telling us
25974 if we are processing global arguments. Hmm, I am unsure of this.
25976 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25978 * expression.cs: added static array of strings to avoid calling
25979 Enum.ToString () for Operator in Binary. Significant recover of
25982 2002-04-10 Miguel de Icaza <miguel@ximian.com>
25984 * class.cs (FindMembers): Allow the Builders of the various
25985 members to be null. If they are skip them. This only happens
25986 during the PInvoke declaration.
25988 2002-04-09 Miguel de Icaza <miguel@ximian.com>
25990 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
25991 failure, so we do not keep going afterwards.
25993 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
25994 wanted to pass `false' as the `is_delegate' argument. If this is
25995 the case, why not use delegate_type == null to mean `is_delegate =
25996 false' and anything else as is_delegate = true.
25998 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
26000 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
26001 code for the section, not the beginning of the tests.
26003 2002-04-08 Miguel de Icaza <miguel@ximian.com>
26005 * cfold.cs: Handle operator + (Enum x, Underlying x)
26007 * expression.cs (Binary): same. Warn about errors where we have
26008 Enum/Enum in operator + as well.
26010 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
26013 - added support for switch(bool)
26014 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
26015 - add TableSwitchEmit() to handle table-based switch statements
26017 2002-04-05 Ravi Pratap <ravi@ximian.com>
26019 * expression.cs (Invocation.OverloadResolve): Factor out code which
26020 does parameter compatibility checking with arguments so that we can
26021 re-use the code even from Delegate.VerifyApplicability
26023 (VerifyArgumentsCompat): Move above code here.
26025 * delegate.cs (VerifyApplicability): Get rid of duplicate code
26026 and instead make a call to the above method.
26028 2002-03-31 Ravi Pratap <ravi@ximian.com>
26030 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
26031 We use it to keep track of classes which are attribute types.
26033 2002-04-02 Miguel de Icaza <miguel@ximian.com>
26035 * delegate.cs (Delegate.Define): Correctly define the types in the
26036 presence of fixed and array parameters.
26038 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
26041 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
26042 include NonPublic after the first iteration.
26044 * class.cs (Indexer.CheckBase): Only check if both parents are
26047 * cs-parser.jay (accessor_body): If empty, set to null.
26049 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
26050 same code path here to resolve constants names that we did have in
26051 MemberAccess.DoResolve. There is too much code duplicated here.
26053 2002-04-01 Miguel de Icaza <miguel@ximian.com>
26055 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
26057 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
26060 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
26061 tokens, numbers and strings.
26063 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
26066 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
26067 asyncronous parameters and the regular parameters.
26069 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
26070 specify the target directory.
26072 * expression.cs: (This.DoResolve): Simplify
26073 (As.Emit): Optimize, do not generate IsInst if the expression is
26074 always of the given type.
26076 (Is.DoResolve): Bug fix, we were reporting both always/never for
26079 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
26080 creating too many unnecessary arrays.
26082 2002-03-31 Miguel de Icaza <miguel@ximian.com>
26084 * class.cs (EmitFieldInitializer): Use Assign expression to assign
26085 fields instead of rolling our own initializer. Takes care of all
26086 implicit conversions, and drops unnecessary static checks/argument.
26088 2002-03-31 Dick Porter <dick@ximian.com>
26090 * driver.cs: use the GetDirectories() return values properly, and
26091 use "/" as path separator.
26093 2002-03-30 Miguel de Icaza <miguel@ximian.com>
26095 * expression.cs (Unary): Optimize - - expr into expr.
26096 (Binary): Optimize a + (-b) into a -b.
26098 * codegen.cs (CodeGen): Made all methods static.
26100 2002-03-29 Miguel de Icaza <miguel@ximian.com>
26104 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
26105 TypeBuilder property.
26107 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
26110 * tree.cs: Removed the various RecordXXXX, and replaced with a
26111 single RecordDecl. Removed all the accessor methods, and just
26112 left a single access point Type
26114 * enum.cs: Rename DefineEnum to DefineType.
26116 * decl.cs: New abstract method `DefineType' used to unify the
26117 Defines for Enumerations, Interfaces, TypeContainers and
26120 (FindType): Moved LookupInterfaceOrClass here. Moved the
26121 LookupBaseClasses method that used to live in class.cs and
26122 interface.cs here, and renamed to FindType.
26124 * delegate.cs: Implement DefineType. Take advantage of the
26125 refactored pattern for locating the parent builder without taking
26126 the parent_builder argument (which we know does not work if we are
26127 nested, and triggering a toplevel definition).
26129 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26131 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
26132 accessibility of a member has changed during override and report
26135 * class.cs (Method.Define, Property.Define): Only complain on
26136 overrides if the method is private, any other accessibility is
26137 fine (and since we just checked the permission is the same, we are
26140 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
26141 and elif are processed always. The other pre-processing
26142 directives are only processed if we are "taking" the path
26144 2002-03-29 Martin Baulig <martin@gnome.org>
26146 * class.cs (Method.Emit): Only emit symbolic debugging info if the
26147 current location is not Null.
26149 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
26150 a separate method so we can profile it.
26152 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
26153 `span.Seconds' are just seconds, but no minutes or hours.
26154 (MainDriver): Profile the CodeGen.SaveSymbols calls.
26156 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26158 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
26159 Remove the gratuitous set of Final:
26161 // If an interface implementation, then we can set Final.
26162 if (((flags & MethodAttributes.Abstract) == 0) &&
26163 implementing.DeclaringType.IsInterface)
26164 flags |= MethodAttributes.Final;
26166 I do not know what I was smoking when I used that.
26169 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
26170 step into fixing the name resolution issues for delegates and
26171 unifying the toplevel name resolution.
26173 2002-03-28 Martin Baulig <martin@gnome.org>
26175 * class.cs (Method.Emit): If we have a symbol writer, call its
26176 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
26177 tell it about the current method.
26179 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
26180 writer that we're going to emit the first byte of IL code for a new
26181 statement (a new source line).
26182 (EmitContext.EmitTopBlock): If we have a symbol writer, call
26183 EmitContext.Mark() before emitting any code.
26185 * location.cs (SymbolDocument): Return null when we're Null.
26187 * statement.cs (Statement): Moved the `Location loc' variable here.
26188 (Statement.EmitBoolExpression): If we have a symbol writer, call
26189 ec.Mark() before emitting any code to tell it that we're at the
26190 beginning of a new statement.
26191 (StatementExpression): Added `Location' argument to the constructor.
26192 (Block): Added public readonly variable `StartLocation' and public
26193 variable `EndLocation'. The latter is to be set using SetEndLocation().
26194 (Block): Added constructor which takes a start and end location.
26195 (Block.SetEndLocation): New method. This sets the end location.
26196 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
26197 local variables we create.
26198 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
26199 each statement and do also mark the begin and end of the block.
26201 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
26202 tell it the current lexer.Location, use Location.Null for the end of the
26204 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
26205 current block, set its end location using SetEndLocation().
26206 (statement_expression): StatementExpression constructor now takes the
26207 lexer.Location as additional argument.
26208 (for_statement, declare_local_variables): Likewise.
26209 (declare_local_variables): When creating a new implicit block, use the
26210 new Block constructor and pass it the lexer.Location.
26212 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26214 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
26215 members also on the parent interfaces recursively.
26217 2002-03-27 Miguel de Icaza <miguel@ximian.com>
26219 * report.cs: Use new formats, since Gonzalo finished the missing
26222 * expression.cs (Binary.ResolveOperator): added missing operator|
26223 operator& and operator^ for bool/bool.
26225 * cs-parser.jay: CheckDef now takes a Location argument that is
26226 used to report errors more precisly (instead of reporting the end
26227 of a definition, we try to track something which is a lot closer
26228 to the source of the problem).
26230 * cs-tokenizer.cs: Track global token use, so we can properly flag
26231 the use of #define/#undef after the first token has been seen.
26233 Also, rename the reportXXXX to Error_DescriptiveName
26235 * decl.cs (DeclSpace.IsTopLevel): Move property here from
26236 TypeContainer, so that Enum and Interface can use this too.
26238 * class.cs (TypeContainer.LookupInterfaceOrClass,
26239 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
26240 `builder' argument. Typically this was used to pass the parent
26241 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
26244 The problem is that a nested class could trigger the definition of
26245 a toplevel class, and the builder would be obviously wrong in that
26248 So we drop this argument, and we compute dynamically the
26249 TypeBuilder/ModuleBuilder (the correct information was available
26250 to us anyways from DeclSpace.Parent)
26252 * interface.cs (Interface.DefineInterface): Drop builder
26253 parameter cleanup like class.cs
26255 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
26258 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
26261 (Try.Emit): Propagate the returns value from the statement.
26263 (Return.Emit): Even if we are leavning
26265 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
26267 * modifiers.cs: Fix the computation of MethodAttributes flags.
26269 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
26271 * driver.cs: allow compilation of files that start with '/'.
26272 Add a default case when checking the argument of --target.
26274 2002-03-25 Miguel de Icaza <miguel@ximian.com>
26276 * interface.cs: Implement the same search algorithm for types in
26277 the interface code.
26279 * delegate.cs: Do not allow multiple definition.
26281 * Recovered ChangeLog that got accidentally amputated
26283 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
26285 * rootcontext.cs: Load manually enum to allow core classes to
26286 contain enumerations.
26288 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
26289 Update to new static methods in TypeManager.
26291 * typemanager.cs (GetMethod, GetConstructor): Use our
26292 implementation of FindMembers to find the members, since during
26293 corlib compilation, the types are TypeBuilders and GetMethod and
26294 GetConstructor do not work.
26296 Make all methods in TypeManager static.
26298 (InitCodeHelpers): Split the functionality from
26299 the InitCodeTypes function.
26301 * driver.cs: Call InitCodeHelpers after we have populated the
26304 * cs-parser.jay (delegate_declaration): we did not used to compute
26305 the delegate name correctly for void delegates.
26307 2002-03-24 Miguel de Icaza <miguel@ximian.com>
26309 * rootcontext.cs (RootContext): Init the interface_resolve_order
26310 and type_container_resolve_order always.
26312 (ResolveCore, BootstrapCorlib_ResolveClass,
26313 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
26314 compiler when compiling with --nostdlib
26316 * class.cs (TypeContainer.DefineType): Check that our parent is
26317 not null. This test is most important when we are bootstraping
26320 * codegen.cs: Split out the symbol writing code.
26322 2002-03-25 Martin Baulig <martin@gnome.org>
26324 * driver.cs (-g): Made -g an alias for --debug.
26326 2002-03-24 Martin Baulig <martin@gnome.org>
26328 * codegen.cs (SymbolWriter): New public variable. Returns the
26329 current symbol writer.
26330 (CodeGen): Added `bool want_debugging_support' argument to the
26331 constructor. If true, tell the ModuleBuild that we want debugging
26332 support and ask it for the ISymbolWriter.
26333 (Save): If we have a symbol writer, call it's Close() method after
26334 saving the assembly.
26336 * driver.c (--debug): New command line argument to create a
26337 debugger information file.
26339 * location.cs (SymbolDocument): New public property. Returns an
26340 ISymbolDocumentWriter object for the current source file or null
26341 if we don't have a symbol writer.
26343 2002-03-21 Miguel de Icaza <miguel@ximian.com>
26345 * driver.cs (LoadAssembly): Correctly return when all the paths
26346 have been tried and not before.
26348 * statement.cs (Switch.Emit): return the actual coverage for this
26349 statement (returns/not-returns)
26351 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
26352 switch of the statement if we are the last switch section. That
26353 kills two problems: try/catch problems (we used to emit an empty
26354 nop at the end) and switch statements where all branches would
26357 2002-03-19 Miguel de Icaza <miguel@ximian.com>
26359 * driver.cs: Add default assemblies (the equivalent to the
26360 Microsoft CSC.RSP file)
26362 * cs-tokenizer.cs: When updating `cols and setting it to zero,
26363 also update tokens_seen and set it to false.
26365 * driver.cs: Implement --recurse for Mike.
26367 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
26368 correctly splitting out the paths.
26370 2002-03-18 Miguel de Icaza <miguel@ximian.com>
26372 * interface.cs (Interface.PopulateProperty): Instead of using
26373 `parent' as the declaration space for the set parameters, use
26376 * support.cs (InternalParameters): InternalParameters constructor
26377 takes a DeclSpace instead of a TypeContainer.
26379 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
26380 types are being initialized, load the address of it before calling
26383 (New): Provide a mechanism to disable the generation of local
26384 value type temporaries when the caller will be providing us with
26385 an address to store it.
26387 (ArrayCreation.EmitDynamicInitializers): Use it.
26389 2002-03-17 Miguel de Icaza <miguel@ximian.com>
26391 * expression.cs (Invocation.EmitArguments): Only probe for array
26392 property if there is more than one argument. Sorry about that.
26394 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
26395 empty param arrays.
26397 * class.cs (Method.LabelParameters): Fix incorrect code path that
26398 prevented the `ParamArrayAttribute' from being applied to the
26401 2002-03-16 Miguel de Icaza <miguel@ximian.com>
26403 * support.cs (ReflectionParameters): Correctly compute whether the
26404 last argument is a params array. Fixes the problem with
26407 * typemanager.cs: Make the assemblies array always be non-null
26408 (empty, but non-null)
26410 * tree.cs (RecordDecl): New function that abstracts the recording
26411 of names. This reports error 101, and provides a pointer to the
26412 previous declaration. Fixes a crash in the compiler.
26414 * cs-parser.jay (constructor_declaration): Update to new grammar,
26415 and provide a constructor_body that can be empty.
26417 2002-03-15 Miguel de Icaza <miguel@ximian.com>
26419 * driver.cs: Add support for --resources.
26421 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
26422 Make all types for the various array helper methods be integer.
26424 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
26425 CheckState to ConvCast.
26427 (ConvCast): Now it takes a `checked' state argument, to avoid
26428 depending on the emit context for the conversion, and just using
26429 the resolve time setting.
26431 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
26432 instead of Invocation.EmitArguments. We do not emit the original
26433 arguments, instead we emit those which have been converted to
26434 unsigned int expressions.
26436 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
26438 * codegen.cs: ditto.
26440 * expression.cs (LocalVariableReference): Drop the use of the
26441 Store function that depended on the variable index.
26443 * statement.cs (VariableInfo): Drop the `Idx' property from this
26444 class, as this is not taking into account the indexes for
26445 temporaries tat we generate during the execution, getting the
26448 * class.cs: First emit class initializers, then call the parent
26451 * expression.cs (Binary): Fix opcode emision.
26452 (UnaryMutator.EmitCode): Support checked code generation
26454 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
26455 matches for events for both the Static and Instance scans,
26456 pointing to the same element. Fix that.
26458 2002-03-14 Miguel de Icaza <miguel@ximian.com>
26460 * rootcontext.cs (ResolveTree): Always set the
26461 interface_resolve_order, because nested interfaces will be calling
26464 * class.cs (GetInterfaceOrClass): Track the same resolution
26465 process used by TypeManager.LookupType. This fixes the nested
26466 type lookups in class declarations (separate path from
26469 (TypeContainer.DefineType): Also define nested interfaces.
26470 (TypeContainer.RegisterOrder): New public function used to
26471 register the order in which child interfaces need to be closed.
26473 Nested interfaces need to be closed after their parents have been
26476 * interface.cs (InterfaceAttr): Put all the logic for computing
26477 the interface attribute here.
26479 (DefineInterface): Register our interface order with the
26480 RootContext or with the TypeContainer depending on the case.
26482 2002-03-12 Miguel de Icaza <miguel@ximian.com>
26484 * cs-parser.jay: rework foreach statement to work with the new
26485 changes to the policy on SimpleNames.
26487 * report.cs: support Stacktrace on warnings as well.
26489 * makefile: drop --unsafe and /unsafe from the compile.
26491 2002-03-13 Ravi Pratap <ravi@ximian.com>
26493 * ecore.cs (StandardConversionExists): Modify to take an Expression
26494 as the first parameter. Ensure we do null -> reference type conversion
26497 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
26498 temporary Expression objects.
26500 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
26502 * interface.cs: workaround bug in method overloading resolution
26503 (there is already a bugzilla bug for it).
26505 2002-03-12 Miguel de Icaza <miguel@ximian.com>
26507 We could also solve this problem by having a separate path for
26508 performing type lookups, instead of DoResolve, we could have a
26509 ResolveType entry point, and only participating pieces of the
26510 production (simplename, deref, array) would implement this.
26512 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
26513 signal SimpleName to only resolve type names and not attempt to
26514 resolve anything else.
26516 * expression.cs (Cast): Set the flag.
26518 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
26520 * class.cs: Only report 108 if there is no `new' modifier.
26522 * cs-parser.jay: rework foreach statement to work with the new
26523 changes to the policy on SimpleNames.
26525 * report.cs: support Stacktrace on warnings as well.
26527 * makefile: drop --unsafe and /unsafe from the compile.
26529 2002-03-11 Miguel de Icaza <miguel@ximian.com>
26531 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
26532 lookups here, instead of doing that at parse time. This means
26533 that our grammar will not introduce `LocalVariableReferences' as
26534 expressions at this point. That solves the problem of code like
26538 static void Main ()
26542 This is only half the fix. The full fix requires parameters to
26543 also be handled in this way.
26545 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
26546 makes the use more obvious of the DeclSpace. The
26547 ec.TypeContainer.TypeBuilder is now only used to pull the
26548 TypeBuilder for it.
26550 My theory is that I can get rid of the TypeBuilder completely from
26551 the EmitContext, and have typecasts where it is used (from
26552 DeclSpace to where it matters).
26554 The only pending problem is that the code that implements Aliases
26555 is on TypeContainer, and probably should go in DeclSpace.
26557 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
26558 lookups here, instead of doing that at parse time. This means
26559 that our grammar will not introduce `LocalVariableReferences' as
26560 expressions at this point. That solves the problem of code like
26564 static void Main ()
26568 This is only half the fix. The full fix requires parameters to
26569 also be handled in this way.
26571 * class.cs (Property.DefineMethod): When implementing an interface
26572 method, set newslot, when implementing an abstract method, do not
26573 set the flag (before we tried never setting it, or always setting
26574 it, which is the difference).
26575 (Indexer.DefineMethod): same.
26576 (Method.DefineMethod): same.
26578 * ecore.cs: Only set the status used flag if we get back a Field.
26580 * attribute.cs: Temporary hack, so Paolo can keep working.
26582 2002-03-08 Ravi Pratap <ravi@ximian.com>
26584 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
26585 the unmanaged type in the case we have a MarshalAs attribute.
26587 (Resolve): Handle the case when we are parsing the special MarshalAs
26588 attribute [we need to store the unmanaged type to use later]
26590 * typemanager.cs (marshal_as_attr_type): Built in type for the
26591 MarshalAs Attribute.
26593 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
26594 on parameters and accordingly set the marshalling info.
26596 2002-03-09 Miguel de Icaza <miguel@ximian.com>
26598 * class.cs: Optimizing slightly by removing redundant code after
26599 we switched to the `NoTypes' return value.
26600 (Property.DefineMethod): use NoTypes here too.
26602 This fixes the bug I introduced in my last batch of changes.
26604 2002-03-05 Ravi Pratap <ravi@ximian.com>
26606 * tree.cs (RecordEnum): Add. We now keep track of enums too.
26608 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
26609 Enums since those are types too.
26611 * cs-parser.jay (enum_declaration): Record enums as we parse them.
26613 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
26614 thanks to a call during the lookup process.
26616 2002-03-07 Miguel de Icaza <miguel@ximian.com>
26618 * statement.cs (Foreach): Lots of work to accomodate a particular
26619 kind of foreach statement that I had not kept in mind. It is
26620 possible to have foreachs on classes that provide a GetEnumerator
26621 method that return objects that implement the "pattern" for using
26622 a foreach, there is no need to support GetEnumerator
26625 This is needed to compile nant.
26627 * decl.cs: Only report 114 if the member is not `Finalize' and if
26628 the warning level is at least 2.
26630 * class.cs: Moved the compare function from Method to
26633 (MethodSignature.InheritableMemberSignatureCompare): Add new
26634 filter function that is used to extract inheritable methods from a
26637 (Method.Define): Use the new `inheritable_method_signature_filter'
26640 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
26643 2002-03-06 Miguel de Icaza <miguel@ximian.com>
26645 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
26647 * cs-parser.jay: Add opt_semicolon to the interface declaration.
26649 * expression.cs: Pass location information to
26650 ConvertImplicitStandard.
26652 * class.cs: Added debugging code to track return values from
26655 2002-03-05 Miguel de Icaza <miguel@ximian.com>
26657 * expression.cs (Is.DoResolve): If either side of the `is' is an
26658 interface, do not flag the warning.
26660 * ecore.cs (ImplicitReferenceConversion): We need a separate test
26663 * report.cs: Allow for --fatal to be used with --probe.
26665 * typemanager.cs (NoTypes): Move the definition for the empty Type
26668 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
26670 (TypeContainer.DefineProxy): New function used to proxy to parent
26671 implementations when implementing interfaces.
26672 (TypeContainer.ParentImplements): used to lookup if our parent
26673 implements a public function that is required by an interface.
26674 (TypeContainer.VerifyPendingMethods): Hook this up.
26676 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
26677 `modules' and `assemblies' arraylists into arrays. We only grow
26678 these are the very early start up of the program, so this improves
26679 the speedof LookupType (nicely measured).
26681 * expression.cs (MakeByteBlob): Replaced unsafe code with
26682 BitConverter, as suggested by Paolo.
26684 * cfold.cs (ConstantFold.Binary): Special case: perform constant
26685 folding of string concatenation, but if either side is a string,
26686 and the other is not, then return null, and let the runtime use
26687 the concatenation on the string plus the object (using
26688 `Object.ToString').
26690 2002-03-04 Miguel de Icaza <miguel@ximian.com>
26692 Constant Folding has been implemented now.
26694 * expression.cs (Unary.Reduce): Do not throw an exception, catch
26695 the error instead on types that are not supported in one's
26698 * constant.cs (Constant and all children): New set of functions to
26699 perform implict and explicit conversions.
26701 * ecore.cs (EnumConstant): Implement the new functions to perform
26702 conversion by proxying to the child expression.
26704 * codegen.cs: (ConstantCheckState): Constant evaluation has its
26705 own separate setting that can not be turned off from the command
26706 line using --unchecked or --checked and is only controlled using
26707 the checked/unchecked statements and expressions. This setting is
26708 used by the constant folder to flag errors.
26710 * expression.cs (CheckedExpr, UncheckedExpr): Set the
26711 ConstantCheckState as well.
26713 During Resolve, they also have to flag the state, because the
26714 constant folder runs completely in the Resolve phase.
26716 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
26719 2002-03-01 Miguel de Icaza <miguel@ximian.com>
26721 * cfold.cs: New file, this file contains the constant folder.
26723 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
26724 argument to track whether we are using the resulting address to
26725 load or store a value and provide better error messages.
26727 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
26728 new AddressOf arguments.
26730 * statement.cs (Foreach.EmitCollectionForeach): Update
26732 * expression.cs (Argument.Emit): Call AddressOf with proper
26733 arguments to track usage.
26735 (New.DoEmit): Call AddressOf with new arguments.
26737 (Unary.Emit): Adjust AddressOf call.
26739 2002-03-01 Ravi Pratap <ravi@ximian.com>
26741 * cs-parser.jay (member_access): Change the case for pre-defined types
26742 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
26745 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
26748 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
26749 essentially like methods and apply attributes like MethodImplOptions to them too.
26751 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
26754 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
26755 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
26758 * Update code everywhere accordingly.
26760 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
26762 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
26764 2002-02-28 Ravi Pratap <ravi@ximian.com>
26766 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
26767 try performing lookups against those instead of jumping straight into using
26768 the 'using' clauses.
26770 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
26772 (LookupType): Perform lookups in implicit parents too.
26774 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
26775 sequence as RootContext.LookupType.
26777 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
26778 the various cases of namespace lookups into this method.
26780 2002-03-01 Miguel de Icaza <miguel@ximian.com>
26782 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
26783 in positional arguments)
26785 * class.cs (Operator): Update the AllowedModifiers to contain
26788 * cs-parser.jay: Update operator declaration to allow for the
26789 operator body to be empty.
26791 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
26794 2002-02-27 Miguel de Icaza <miguel@ximian.com>
26796 * class.cs (Method.Emit): Label parameters.
26798 * driver.cs: Return 1 or 0 as the program exit code.
26800 2002-02-26 Miguel de Icaza <miguel@ximian.com>
26802 * expression.cs: Special case the `null' object when trying to
26803 auto-compute the type, as anything can be explicitly converted to
26806 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
26807 spotting this Paolo.
26809 (Expression.ImplicitNumericConversion): Perform comparissions of
26810 the type using the underlying type in the case of an enumeration
26811 rather than using the enumeration type for the compare.
26813 Cope with the underlying == type case, which is not possible to
26816 (Expression.ConvertNumericExplicit): Perform comparissions of
26817 the type using the underlying type in the case of an enumeration
26818 rather than using the enumeration type for the compare.
26820 * driver.cs: If the user does not supply an extension, assume .exe
26822 * cs-parser.jay (if_statement): Rewrote so that we can track the
26823 location for the if statement.
26825 * expression.cs (Binary.ConstantFold): Only concat strings when
26826 the operation is "+", not everything ;-)
26828 * statement.cs (Statement.EmitBoolExpression): Take a location
26830 (If, While, Do): Track location.
26832 * expression.cs (Binary.ResolveOperator): In the object + string
26833 case, I was missing a call to ConvertImplicit
26835 2002-02-25 Ravi Pratap <ravi@ximian.com>
26837 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
26838 Location arguments. Ensure we use RootContext.LookupType to do our work
26839 and not try to do a direct Type.GetType and ModuleBuilder.GetType
26841 * interface.cs (PopulateMethod): Handle the type of the parameter being
26844 * expression.cs (Invocation.BetterFunction): Handle the case when we
26845 have a params method with no fixed arguments and a call is made with no
26848 2002-02-25 Miguel de Icaza <miguel@ximian.com>
26850 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
26851 the verbatim-string-literal
26853 * support.cs (InternalParameters.ParameterModifier): handle null
26855 (InternalParameters.ParameterType): ditto.
26857 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
26858 duplicating the name of the variable parameter.
26859 (GetParameterByName): Fix bug where we were not looking up array
26860 paramters if they were the only present (thanks Paolo!).
26861 (GetParameterInfo): We only have an empty set of types if both
26862 fixed and array are set to null.
26863 (GetParameterInfo-idx): Handle FixedParameter == null
26865 * cs-parser.jay: Handle the case where there is no catch
26866 statements (missing null test).
26868 2002-02-22 Miguel de Icaza <miguel@ximian.com>
26870 * driver.cs (MainDriver): Be conservative on our command line
26873 Catch DirectoryNotFoundException when calling GetFiles.
26875 (SplitPathAndPattern): Used to split the input specification into
26876 a path and a pattern that we can feed to Directory.GetFiles.
26878 2002-02-21 Miguel de Icaza <miguel@ximian.com>
26880 * statement.cs (Fixed): Implement the last case of the Fixed
26881 statement (string handling).
26883 * expression.cs (StringPtr): New class used to return a char * to
26884 a string; Used by the Fixed statement.
26886 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
26888 * expression.cs (Binary.ResolveOperator): Remove redundant
26889 MemberLookup pn parent type.
26890 Optimize union call, we do not need a union if the types are the same.
26891 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
26894 Specialize the use of MemberLookup everywhere, instead of using
26895 the default settings.
26897 (StackAlloc): Implement stackalloc keyword.
26899 * cs-parser.jay: Add rule to parse stackalloc.
26901 * driver.cs: Handle /h, /help, /?
26903 * expression.cs (MakeByteBlob): Removed the hacks we had in place
26904 before we supported unsafe code.
26906 * makefile: add --unsafe to the self compilation of mcs.
26908 2002-02-20 Miguel de Icaza <miguel@ximian.com>
26910 * expression.cs (PointerArithmetic): New class that is used to
26911 perform pointer arithmetic.
26912 (Binary.Resolve): Handle pointer arithmetic
26913 Handle pointer comparission.
26914 (ArrayPtr): Utility expression class that is used to take the
26915 address of an array.
26917 (ElementAccess): Implement array access for pointers
26919 * statement.cs (Fixed): Implement fixed statement for arrays, we
26920 are missing one more case before we are done.
26922 * expression.cs (Indirection): Implement EmitAssign and set the
26923 ExprClass to Variable. This allows pointer dereferences to be
26924 treated as variables, and to have values assigned to them.
26926 * ecore.cs (Expression.StoreFromPtr): New utility function to
26927 store values dereferencing.
26929 2002-02-20 Ravi Pratap <ravi@ximian.com>
26931 * expression.cs (Binary.ResolveOperator): Ensure that we are
26932 not trying to operate on a void type - this fixes the reported
26935 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
26936 the parent implementation is sealed.
26938 * ../errors/cs0239.cs : Add.
26940 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
26942 * typemanager.cs (unverifiable_code_type): Corresponds to
26943 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
26944 which have unsafe code in them.
26946 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
26949 2002-02-19 Miguel de Icaza <miguel@ximian.com>
26951 * cs-tokenizer.cs: Add support for @"litreal strings"
26953 Make tokenizer accept pre-processor directives
26954 on any column (remove the old C-like limitation).
26956 * rootcontext.cs (EmitCode): Emit any global attributes.
26957 (AddGlobalAttributes): Used to keep track of assembly attributes.
26959 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
26961 * cs-parser.jay: Add support for global attributes.
26963 2002-02-17 Miguel de Icaza <miguel@ximian.com>
26965 * expression.cs (Indirection): New helper class. Unary will
26966 create Indirection classes to be able to implement the
26967 IMemoryLocation interface on it.
26969 2002-02-16 Miguel de Icaza <miguel@ximian.com>
26971 * cs-parser.jay (fixed_statement): reference the right statement.
26973 * statement.cs (Fixed.Emit): Finish implementing the fixed
26974 statement for the &x case.
26976 2002-02-14 Miguel de Icaza <miguel@ximian.com>
26978 * class.cs (Property.Define, Method.Define): Remove newslot when
26981 * modifiers.cs: My use of NewSlot when `Abstract' was set was
26982 wrong. NewSlot should only be used if the `new' keyword is present.
26984 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
26985 locating our system dir. Sorry about this.
26987 2002-02-13 Miguel de Icaza <miguel@ximian.com>
26989 * driver.cs (GetSystemDir): Compute correctly the location of our
26990 system assemblies. I was using the compiler directory instead of
26991 the library directory.
26993 2002-02-13 Ravi Pratap <ravi@ximian.com>
26995 * expression.cs (BetterFunction): Put back in what Miguel commented out
26996 since it is the correct fix. The problem is elsewhere ;-)
26998 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
26999 parameters of the parms method are themselves compatible or not !
27001 (StandardConversionExists): Fix very dangerous bug where we were forgetting
27002 to check that a class implements an interface before saying that an implicit
27003 conversion was allowed. Use ImplementsInterface to do the checking.
27005 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27007 * class.cs (Method.Define): Track whether we are an explicit
27008 implementation or not. And only call DefineMethodOverride if we
27009 are an explicit implementation.
27011 (Property.DefineMethod): Ditto.
27013 2002-02-11 Ravi Pratap <ravi@ximian.com>
27015 * expression.cs (BetterFunction): Catch hideous bug which was
27016 preventing us from detecting ambiguous calls due to implicit casts i.e
27019 2002-01-29 Miguel de Icaza <miguel@ximian.com>
27021 * support.cs (Pair): Remove un-needed method. I figured why I was
27022 getting the error in cs-parser.jay, the variable in a foreach loop
27023 is readonly, and the compiler does not really treat this as a variable.
27025 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
27026 instead of EQUALS in grammar.
27028 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
27030 * expression.cs (Unary.DoResolve): Check whether the argument is
27033 2002-01-28 Miguel de Icaza <miguel@ximian.com>
27035 * support.cs: Api for Pair to set a value. Despite the fact that
27036 the variables are public the MS C# compiler refuses to compile
27037 code that accesses the field if the variable is part of a foreach
27040 * statement.cs (Fixed): Begin implementation of the fixed
27043 (Block.AddVariable): Return the VariableInfo on success and null
27044 on failure instead of true/false.
27046 * cs-parser.jay (foreach): Catch errors on variables already
27047 defined (we were ignoring this value before) and properly unwind
27048 the block hierarchy
27050 (fixed_statement): grammar for the fixed statement.
27052 2002-01-25 Miguel de Icaza <miguel@ximian.com>
27054 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
27055 pointer types to be incretemented.
27057 (SizeOf): Implement.
27059 * cs-parser.jay (pointer_member_access): Implement
27060 expr->IDENTIFIER production.
27062 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
27063 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
27066 (Unary): Implement indirection.
27068 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
27069 use in non-unsafe context).
27071 (SimpleName.DoResolve): Check for pointers in field access on safe
27074 (Expression.LoadFromPtr): Factor the load-indirect code in this
27075 function. This was duplicated in UnboxCast and ParameterReference
27077 2002-01-24 Miguel de Icaza <miguel@ximian.com>
27079 * expression.cs (ComposedCast): report an error if a pointer cast
27080 is used in a safe region.
27082 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
27083 pointer type casts in unsafe context.
27085 * codegen.cs (EmitContext): Set up IsUnsafe.
27087 * cs-parser.jay (non_expression_type): Add productions for pointer
27090 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
27091 code. We should not use force into static mode if the method is
27092 not virtual. Fixes bug in MIS
27094 * statement.cs (Do.Emit, While.Emit, For.Emit,
27095 Statement.EmitBoolExpression): Add support to Do and While to
27096 propagate infinite loop as `I do return' semantics.
27098 Improve the For case to also test for boolean constants.
27100 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
27101 to the list of attributes we can add.
27103 Remove `EmitContext' argument.
27105 * class.cs (Method.Define): Apply parameter attributes.
27106 (Constructor.Define): Apply parameter attributes.
27107 (MethodCore.LabelParameters): Move here the core of labeling
27110 * support.cs (ReflectionParameters.ParameterModifier,
27111 InternalParameters.ParameterModifier): Use IsByRef on the type and
27112 only return the OUT bit for these parameters instead of in/out/ref
27115 This is because I miss-understood things. The ParameterInfo.IsIn
27116 and IsOut represent whether the parameter has the [In] and [Out]
27119 2002-01-22 Miguel de Icaza <miguel@ximian.com>
27121 * ecore.cs (FieldExpr.Emit): Release temporaries.
27123 * assign.cs (LocalTemporary.Release): new function.
27125 * codegen.cs (EmitContext.GetTemporaryStorage,
27126 EmitContext.FreeTemporaryStorage): Rework the way we deal with
27127 temporary storage. Now we can "put back" localbuilders when we
27130 2002-01-21 Miguel de Icaza <miguel@ximian.com>
27132 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
27133 need to make a copy of the variable to generate verifiable code.
27135 2002-01-19 Miguel de Icaza <miguel@ximian.com>
27137 * driver.cs: Compute dynamically the system directory.
27139 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
27140 Slower, but more generally useful. Used by the abstract
27141 registering implementation.
27143 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
27144 the rules for the special rule on Type/instances. First check if
27145 we have the same name, and if so, try that special static path
27146 rather than the instance path.
27148 2002-01-18 Miguel de Icaza <miguel@ximian.com>
27150 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
27153 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
27154 Enum, ValueType, Delegate or Array for non-corlib compiles.
27156 * cs-tokenizer.cs: Catch long identifiers (645)
27158 * typemanager.cs (IndexerPropetyName): Ravi never tested this
27161 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
27162 fix, we were returning too early, so we were not registering
27163 pending methods from abstract classes.
27165 Do not register pending methods if the class is abstract.
27167 * expression.cs (Conditional.DoResolve): Report circular implicit
27168 conversions when we neecd to compute it for conditional
27171 (Is.DoResolve): If the expression is always of the provided type,
27172 flag warning 183. If the expression can not ever be of the
27173 provided type flag warning 184.
27175 * class.cs: Catch 169 as well.
27177 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
27180 2002-01-18 Nick Drochak <ndrochak@gol.com>
27182 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
27184 2002-01-17 Miguel de Icaza <miguel@ximian.com>
27186 * interface.cs: (PopulateMethod): Check for pointers being defined
27187 only if the unsafe context is active.
27188 (PopulateProperty): ditto.
27189 (PopulateIndexer): ditto.
27191 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
27192 specified. If pointers are present, make sure that they are
27193 present in an unsafe context.
27194 (Constructor, Constructor.Define): ditto.
27195 (Field, Field.Define): ditto.
27196 (Property, Property.Define): ditto.
27197 (Event, Event.Define): ditto.
27199 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
27200 hashtable if there are classes or structs defined.
27202 * expression.cs (LocalVariableReference.DoResolve): Simplify this
27203 code, as the constant resolution moved.
27205 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
27206 the metadata, so we can flag error 133.
27208 * decl.cs (MemberCore.UnsafeOK): New function to test that a
27209 pointer is being declared in an unsafe context.
27211 2002-01-16 Miguel de Icaza <miguel@ximian.com>
27213 * modifiers.cs (Modifiers.Check): Require a Location argument.
27214 Report error 227 for Unsafe use.
27216 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
27218 * statement.cs (For.Emit): If the test is null, then report that
27219 we do `return', as we wont reach anything afterwards.
27221 (Switch.SwitchGoverningType): Track the expression that matched
27224 * driver.cs: Allow negative numbers as an error code to flag.
27226 * cs-parser.jay: Handle 1551.
27228 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
27230 2002-01-15 Miguel de Icaza <miguel@ximian.com>
27232 * cs-parser.jay: Report 1518 (type declaration can only contain
27233 class, struct, interface, enum or delegate)
27235 (switch_label): Report 1523 (keywords `case' or `default' must
27238 (opt_switch_sections): Report 1522 (empty switch)
27240 * driver.cs: Report 1515 (response file specified multiple times)
27241 Report 1516 (Source file specified multiple times).
27243 * expression.cs (Argument.Resolve): Signal 1510
27245 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
27246 access not allowed in static code)
27248 2002-01-11 Ravi Pratap <ravi@ximian.com>
27250 * typemanager.cs (IsPointerType): Utility method which we are going
27253 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
27254 the object type, so we take care of that.
27256 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
27258 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
27259 added to non-params parameters :-)
27261 * typemanager.cs (CSharpName): Include 'void' type too.
27263 (void_ptr_type): Include in the set of core types.
27265 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
27268 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
27271 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
27272 completely forgotten about it.
27274 2002-01-10 Ravi Pratap <ravi@ximian.com>
27276 * cs-parser.jay (pointer_type): Add. This begins our implementation
27277 of parsing rules for unsafe code.
27279 (unsafe_statement): Implement.
27281 (embedded_statement): Modify to include the above.
27283 * statement.cs (Unsafe): Implement new class for unsafe blocks.
27285 * codegen.cs (EmitContext.InUnsafe): Add. This determines
27286 if the current context is an unsafe one.
27288 * cs-parser.jay (local_variable_pointer_type): Since local variable types
27289 are handled differently, we need separate rules for them.
27291 (local_variable_declaration): Update to use local_variable_pointer_type
27292 to allow variable declarations of unmanaged pointer types.
27294 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
27295 in unsafe contexts.
27297 * ../errors/cs0214.cs : Add.
27299 2002-01-16 Nick Drochak <ndrochak@gol.com>
27301 * makefile: remove 'response' file when cleaning.
27303 2002-01-15 Miguel de Icaza <miguel@ximian.com>
27305 * cs-parser.jay: Report 1524.
27307 2002-01-14 Miguel de Icaza <miguel@ximian.com>
27309 * typemanager.cs (RegisterMethod): drop checking if we have
27310 registered this from here
27312 2002-01-12 Miguel de Icaza <miguel@ximian.com>
27314 * class.cs (Method.EmitDestructor): Implement calling our base
27317 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
27318 value of InFinally.
27320 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
27321 this routine and will wrap the call in a try/catch block. Deal
27324 2002-01-11 Miguel de Icaza <miguel@ximian.com>
27326 * ecore.cs (Expression.MemberLookup): instead of taking a
27327 parameter `same_type' that was used to tell whether we could
27328 access private members we compute our containing type from the
27331 (FieldExpr): Added partial support for volatile fields. This does
27332 not work for volatile fields exposed from assemblies, as I can not
27333 figure out how to extract the modreq from it.
27335 Updated all the source files to use this.
27337 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
27338 because it is referenced by MemberLookup very often.
27340 2002-01-09 Ravi Pratap <ravi@ximian.com>
27342 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
27343 TypeBuilder.GetCustomAttributes to retrieve what we need.
27345 Get rid of redundant default_member_attr_type as this is the same as
27346 default_member_type which already exists.
27348 * interface.cs, attribute.cs : Update accordingly.
27350 2002-01-08 Miguel de Icaza <miguel@ximian.com>
27352 * typemanager.cs: Enable IndexerPropertyName again. It does not
27353 work for TYpeBuilders though. Ravi, can you please fix this?
27355 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
27357 * expression.cs (Argument.Emit): Handle the case of ref objects
27358 being passed to ref functions;
27360 (ParameterReference.EmitLoad): Loads the content of the pointer
27361 without dereferencing.
27363 2002-01-07 Miguel de Icaza <miguel@ximian.com>
27365 * cs-tokenizer.cs: Implemented the pre-processing expressions.
27367 2002-01-08 Ravi Pratap <ravi@ximian.com>
27369 * class.cs (Indexer.DefineMethod): Incorporate the interface
27370 type in the name of the method if we are doing explicit interface
27373 * expression.cs (ConversionExists): Remove as it is completely obsolete.
27375 (BetterConversion): Fix extremely trivial bug where we were referring to
27376 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
27379 * ../errors/bug16.cs : Add although we have fixed it.
27381 2002-01-07 Miguel de Icaza <miguel@ximian.com>
27383 * expression.cs (BaseIndexer): Begin implementation.
27385 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
27387 * cs-parser.jay (indexer_declarator): Use qualified_identifier
27388 production directly to remove a shift/reduce, and implement
27389 explicit interface implementation.
27391 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
27392 after a floating point suffix.
27394 * expression.cs (DoNumericPromotions): Improved the conversion for
27395 uint/uint. If we have a constant, we avoid doing a typecast to a
27398 * class.cs (Indexer): Implement explicit interface implementation
27401 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
27403 * class.cs: make the default instance constructor public and hidebysig.
27405 2001-01-03 Ravi Pratap <ravi@ximian.com>
27407 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
27408 so we can call it from elsewhere.
27410 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
27411 we emit it internally if the class has a defined indexer; otherwise the user
27412 emits it by decorating the class definition with the DefaultMemberAttribute.
27414 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
27415 attribute is not used on a type which defines an indexer.
27417 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
27418 character when we skip whitespace.
27420 * ../errors/cs0646.cs : Add.
27422 2002-01-03 Miguel de Icaza <miguel@ximian.com>
27424 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
27427 * makefile: Add practical target `mcs3.exe' which builds the third
27428 generation compiler.
27430 * expression.cs (New): Fix structures constructor calling.
27432 * class.cs (Property, Method, Indexer): Emit Final flag on the
27433 method if we are an interface implementation and we are not
27436 * ecore.cs (PropertyExpr): New public field `IsBase', tells
27437 whether this property is referencing a `base' method.
27439 * expression.cs (Invocation.EmitCall): take an extra argument:
27440 is_base, this is used to determine whether the `call' or
27441 `callvirt' opcode should be used.
27444 * delegate.cs: update EmitCall.
27446 * class.cs (Method.Define): Set NewSlot for the cases where we are
27447 not implementing an interface method.
27449 (Property.Define): ditto.
27451 2002-01-02 Miguel de Icaza <miguel@ximian.com>
27453 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
27454 'r'. Allows mcs to parse itself fully.
27456 2002-01-02 Ravi Pratap <ravi@ximian.com>
27458 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
27459 of the number of initializers that require the InitializeArray method.
27461 (CheckIndices): Store the Expression in all cases - not the plain value. Also
27462 update the above field where necessary.
27464 (MakeByteBlob): Update accordingly.
27466 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
27469 (EmitDynamicInitializers): Update in accordance with the new optimization.
27471 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
27472 same OpCode applies.
27474 * cs-parser.jay : Fix some glaring errors I introduced.
27476 2002-01-01 Ravi Pratap <ravi@ximian.com>
27478 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
27479 so that we can check for name clashes there too.
27481 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
27482 for interface indexers.
27484 * interfaces.cs (Define): Emit the default member attribute.
27486 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
27487 variable was being referred to while setting the value ;-)
27489 2002-01-01 Miguel de Icaza <miguel@ximian.com>
27491 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
27492 byte-by-byte information when we know the data is zero.
27494 Make the block always a multiple of 4, because
27495 DefineInitializedData has a bug.
27497 * assign.cs: Fix, we should assign from the temporary, not from
27500 * expression.cs (MakeByteBlob): Fix my incorrect code.
27502 2001-12-31 Miguel de Icaza <miguel@ximian.com>
27504 * typemanager.cs (EnumToUnderlying): This function is used to get
27505 the underlying type from an enumeration, because it does not
27508 * constant.cs: Use the I4_S form for values between -128 and 127.
27510 * statement.cs (Block.LookupLabel): Looks up a label.
27511 (Block): Drop support for labeled blocks.
27513 (LabeledStatement): New kind of statement that represents a label
27516 (Goto): Finally implement this bad boy.
27518 * cs-parser.jay: Update to reflect new mechanism to implement
27521 2001-12-30 Miguel de Icaza <miguel@ximian.com>
27523 * codegen.cs (EmitContext.This): a codegen property that keeps the
27524 a single instance of this instead of creating many different this
27527 * delegate.cs (Delegate.DoResolve): Update to use the property;
27529 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
27531 * expression.cs (BaseAccess.DoResolve): Ditto.
27533 2001-12-29 Ravi Pratap <ravi@ximian.com>
27535 * typemanager.cs (methodimpl_attr_type): Add to hold the type
27536 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
27538 (InitCoreTypes): Update accordingly.
27540 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
27541 so we can quickly store the state.
27543 (ApplyAttributes): Set the correct implementation flags
27544 for InternalCall methods.
27546 2001-12-29 Miguel de Icaza <miguel@ximian.com>
27548 * expression.cs (EmitCall): if a method is not virtual, then do
27549 not use callvirt on it.
27551 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
27552 user defined stuff) requires the use of stobj, which takes an
27553 address on the stack instead of an array and an index. So emit
27554 the Ldelema operation for it.
27556 (EmitStoreOpcode): Use stobj for valuetypes.
27558 (UnaryMutator.EmitCode): Use the right 1 value depending on
27559 whether we are dealing with int64/uint64, float or doubles.
27561 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
27562 constructors that I implemented last night.
27564 (Constructor.IsDefault): Fix to work properly for static
27567 * cs-parser.jay (CheckDef): report method signature errors.
27568 Update error number 103 to be 132.
27570 * decl.cs: New AdditionResult enumeration value: MethodExists.
27571 Although we do this check for methods later on in the semantic
27572 analysis, catching repeated default constructors is so easy that
27573 we catch these here.
27575 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
27578 (ParameterReference.EmitAssign, Emit): handle
27581 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
27582 (ArrayAccess.EmitStoreOpcode): ditto.
27584 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
27586 * expression.cs (MakeByteBlob): Complete all the missing types
27587 (uint, short, ushort, byte, sbyte)
27589 * class.cs: Only init instance field initializers on instance
27592 Rename `constructors' to instance_constructors.
27594 (TypeContainer.AddConstructor): Only add constructors to the list
27595 if it is not static.
27597 Make sure that we handle default_static_constructor independently
27598 everywhere where we handle instance_constructors
27600 2001-12-28 Miguel de Icaza <miguel@ximian.com>
27602 * class.cs: Do not lookup or create a base initializer for a
27603 static constructor.
27605 (ConstructorInitializer.Resolve): use the proper type to lookup
27608 * cs-parser.jay: Report error 1585 (modifiers between type and name).
27610 * enum.cs, interface.cs: Remove CloseType, this is taken care by
27613 * decl.cs: CloseType is now an virtual method, the default
27614 implementation just closes this type.
27616 2001-12-28 Ravi Pratap <ravi@ximian.com>
27618 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
27619 to PreserveSig by default. Also emit HideBySig on such methods.
27621 Basically, set the defaults to standard values.
27623 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
27624 argument, if candidate is better, it can't be worse than the best !
27626 (Invocation): Re-write bits to differentiate between methods being
27627 applicable in their expanded form and their normal form - for params
27630 Get rid of use_standard everywhere as only standard conversions are allowed
27631 in overload resolution.
27633 More spec conformance.
27635 2001-12-27 Miguel de Icaza <miguel@ximian.com>
27637 * driver.cs: Add --timestamp, to see where the compiler spends
27640 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
27641 `this' in static code.
27643 (SimpleName.DoResolve): Implement in terms of a helper function
27644 that allows static-references to be passed upstream to
27647 (Expression.ResolveWithSimpleName): Resolve specially simple
27648 names when called by MemberAccess to implement the special
27651 (Expression.ImplicitReferenceConversion): Handle conversions from
27652 Null to reference types before others, as Null's type is
27655 * expression.cs (Invocation.EmitCall): Handle the special case of
27656 calling methods declared on a reference type from a ValueType
27657 (Base classes System.Object and System.Enum)
27659 (MemberAccess.Resolve): Only perform lookups on Enumerations if
27660 the left hand side is a TypeExpr, not on every enumeration.
27662 (Binary.Resolve): If types are reference types, then do a cast to
27663 object on operators != and == of both arguments.
27665 * typemanager.cs (FindMembers): Extract instance and static
27666 members if requested.
27668 * interface.cs (PopulateProperty): Use void_type instead of null
27669 as the return type for the setter method.
27671 (PopulateIndexer): ditto.
27673 2001-12-27 Ravi Pratap <ravi@ximian.com>
27675 * support.cs (ReflectionParameters): Fix minor bug where we
27676 were examining the wrong parameter for the ParamArray attribute.
27678 Cope with requests for the type of the parameter at position
27679 greater than the params parameter's. We now return the element
27680 type of the params array as that makes more sense.
27682 * expression.cs (Invocation.IsParamsMethodApplicable): Update
27683 accordingly as we no longer have to extract the element type
27686 (Invocation.OverloadResolve): Update.
27688 2001-12-27 Miguel de Icaza <miguel@ximian.com>
27690 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
27691 against IEnumerator, test whether the return value is a descendant
27692 of the IEnumerator interface.
27694 * class.cs (Indexer.Define): Use an auxiliary method to implement
27695 the other bits of the method definition. Begin support for
27696 explicit interface implementation.
27698 (Property.DefineMethod): Use TypeManager.void_type instead of null
27699 for an empty return value.
27701 2001-12-26 Miguel de Icaza <miguel@ximian.com>
27703 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
27704 dealing with a FieldExpr which is composed of a FieldBuilder, in
27705 the code path we did extract the constant, but we should have
27706 obtained the underlying value to be able to cast it (otherwise we
27707 end up in an infinite loop, this is what Ravi was running into).
27709 (ArrayCreation.UpdateIndices): Arrays might be empty.
27711 (MemberAccess.ResolveMemberAccess): Add support for section
27712 14.5.4.1 that deals with the special case of E.I when E is a type
27713 and something else, that I can be a reference to a static member.
27715 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
27716 handle a particular array type to create byte blobs, it is just
27717 something we dont generate byteblobs for.
27719 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
27722 * location.cs (Push): remove the key from the hashtable that we
27723 are about to add. This happens for empty files.
27725 * driver.cs: Dispose files after we have parsed them.
27727 (tokenize): new function that only runs the tokenizer on its
27728 input, for speed testing.
27730 2001-12-26 Ravi Pratap <ravi@ximian.com>
27732 * class.cs (Event.Define): Define the private field only if there
27733 are no accessors defined.
27735 * expression.cs (ResolveMemberAccess): If there is no associated
27736 field with the event, that means we have an event defined with its
27737 own accessors and we should flag error cs0070 since transforming
27738 ourselves into a field is not valid in that case.
27740 * ecore.cs (SimpleName.DoResolve): Same as above.
27742 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
27743 and charset to sane values.
27745 2001-12-25 Ravi Pratap <ravi@ximian.com>
27747 * assign.cs (DoResolve): Perform check on events only if they
27748 are being accessed outside the declaring type.
27750 * cs-parser.jay (event_declarations): Update rules to correctly
27751 set the type of the implicit parameter etc.
27753 (add_accessor, remove_accessor): Set current local parameters.
27755 * expression.cs (Binary): For delegate addition and subtraction,
27756 cast the return value from the method into the appropriate delegate
27759 2001-12-24 Ravi Pratap <ravi@ximian.com>
27761 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
27762 of these as the workaround is unnecessary.
27764 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
27765 delegate data - none of that is needed at all.
27767 Re-write bits to extract the instance expression and the delegate method
27770 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
27773 * attribute.cs (ApplyAttributes): New method to take care of common tasks
27774 of attaching attributes instead of duplicating code everywhere.
27776 * everywhere : Update code to do attribute emission using the above method.
27778 2001-12-23 Miguel de Icaza <miguel@ximian.com>
27780 * expression.cs (IsParamsMethodApplicable): if there are not
27781 parameters, return immediately.
27783 * ecore.cs: The 0 literal can be implicity converted to an enum
27786 (SimpleName.DoResolve): First lookup the type, then lookup the
27789 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
27790 want to get its address. If the InstanceExpression is not
27791 addressable, store the result in a temporary variable, then get
27794 * codegen.cs: Only display 219 errors on warning level or above.
27796 * expression.cs (ArrayAccess): Make it implement the
27797 IMemoryLocation interface.
27799 (Binary.DoResolve): handle the operator == (object a, object b)
27800 and operator != (object a, object b) without incurring into a
27801 BoxedCast (because 5 != o should never be performed).
27803 Handle binary enumerator operators.
27805 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
27806 value type, otherwise use Ldelem_ref.
27808 Use precomputed names;
27810 (AddressOf): Implement address of
27812 * cs-parser.jay (labeled_statement): Fix recursive block
27813 addition by reworking the production.
27815 * expression.cs (New.DoEmit): New has a special case:
27817 If we are dealing with a ValueType, we have a few
27818 situations to deal with:
27820 * The target of New is a ValueType variable, that is
27821 easy, we just pass this as the variable reference
27823 * The target of New is being passed as an argument,
27824 to a boxing operation or a function that takes a
27827 In this case, we need to create a temporary variable
27828 that is the argument of New.
27831 2001-12-23 Ravi Pratap <ravi@ximian.com>
27833 * rootcontext.cs (LookupType): Check that current_type is not null before
27834 going about looking at nested types.
27836 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
27837 not implement the IAssignMethod interface any more.
27839 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
27840 where we tranform them into FieldExprs if they are being resolved from within
27841 the declaring type.
27843 * ecore.cs (SimpleName.DoResolve): Do the same here.
27845 * assign.cs (DoResolve, Emit): Clean up code considerably.
27847 * ../errors/bug10.cs : Add.
27849 * ../errors/cs0070.cs : Add.
27851 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
27853 * assign.cs : Get rid of EventIsLocal everywhere.
27855 2001-12-23 Miguel de Icaza <miguel@ximian.com>
27857 * ecore.cs (ConvertIntLiteral): finished the implementation.
27859 * statement.cs (SwitchLabel): Convert the value we are using as a
27860 key before looking up the table.
27862 2001-12-22 Miguel de Icaza <miguel@ximian.com>
27864 * codegen.cs (EmitTopBlock): Require a Location argument now.
27866 * cs-parser.jay (constructor_declarator): We need to setup
27867 current_local_parameters before we parse the
27868 opt_constructor_initializer, to allow the variables to be bound
27869 to the constructor arguments.
27871 * rootcontext.cs (LookupType): First lookup nested classes in our
27872 class and our parents before we go looking outside our class.
27874 * expression.cs (ConstantFold): Extract/debox the values at the
27877 * rootcontext.cs (EmitCode): Resolve the constants first before we
27878 resolve the types. This is not really needed, but it helps debugging.
27880 * statement.cs: report location.
27882 * cs-parser.jay: pass location to throw statement.
27884 * driver.cs: Small bug fix.
27886 * report.cs: Updated format to be 4-zero filled digits.
27888 2001-12-22 Ravi Pratap <ravi@ximian.com>
27890 * expression.cs (CheckIndices): Fix minor bug where the wrong
27891 variable was being referred to ;-)
27893 (DoEmit): Do not call EmitStaticInitializers when the
27894 underlying type is System.Object.
27896 2001-12-21 Ravi Pratap <ravi@ximian.com>
27898 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
27899 and do the usual workaround for SRE.
27901 * class.cs (MyEventBuilder.EventType): New member to get at the type
27902 of the event, quickly.
27904 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
27906 * assign.cs (Assign.DoResolve): Handle the case when the target
27907 is an EventExpr and perform the necessary checks.
27909 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
27912 (SimpleName.MemberStaticCheck): Include check for EventExpr.
27914 (EventExpr): Set the type in the constructor itself since we
27915 are meant to be born fully resolved.
27917 (EventExpr.Define): Revert code I wrote earlier.
27919 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
27920 instance expression is null. The instance expression is a This in that case
27921 or a null, depending on whether it is a static method or not.
27923 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
27924 refers to more than one method.
27926 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
27927 and accordingly flag errors.
27929 2001-12-21 Miguel de Icaza <miguel@ximian.com>
27931 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
27933 2001-12-22 Miguel de Icaza <miguel@ximian.com>
27935 * location.cs (ToString): Provide useful rutine.
27937 2001-12-21 Miguel de Icaza <miguel@ximian.com>
27939 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
27940 objects, return the actual integral boxed.
27942 * statement.cs (SwitchLabel): define an ILLabel for each
27945 (Switch.CheckSwitch): If the value is a Literal, extract
27946 the underlying literal.
27948 Also in the unused hashtable we had, add the SwitchLabel so we can
27949 quickly look this value up.
27951 * constant.cs: Implement a bunch of new constants. Rewrite
27952 Literal based on this. Made changes everywhere to adapt to this.
27954 * expression.cs (Expression.MakeByteBlob): Optimize routine by
27955 dereferencing array only once, and also copes with enumrations.
27957 bytes are two bytes wide, not one.
27959 (Cast): Perform constant conversions.
27961 * ecore.cs (TryImplicitIntConversion): Return literals instead of
27962 wrappers to the literals here.
27964 * expression.cs (DoNumericPromotions): long literals can converted
27965 to ulong implicity (this is taken care of elsewhere, but I was
27966 missing this spot).
27968 * ecore.cs (Expression.Literalize): Make the return type Literal,
27969 to improve type checking.
27971 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
27973 2001-12-20 Miguel de Icaza <miguel@ximian.com>
27975 * literal.cs: Revert code from ravi that checked the bounds. The
27976 bounds are sane by the definition of the type itself.
27978 * typemanager.cs: Fix implementation of ImplementsInterface. We
27979 need to actually look up in our parent hierarchy for interfaces
27982 * const.cs: Use the underlying type for enumerations
27984 * delegate.cs: Compute the basename for the delegate creation,
27985 that should fix the delegate test case, and restore the correct
27986 Type Lookup semantics in rootcontext
27988 * rootcontext.cs: Revert Ravi's last patch. The correct way of
27989 referencing a nested type with the Reflection API is using the "+"
27992 * cs-parser.jay: Do not require EOF token at the end.
27994 2001-12-20 Ravi Pratap <ravi@ximian.com>
27996 * rootcontext.cs (LookupType): Concatenate type names with
27997 a '.' instead of a '+' The test suite passes again.
27999 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
28000 field of the enumeration.
28002 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
28003 the case when the member is an EventExpr.
28005 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
28006 static has an associated instance expression.
28008 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
28010 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
28012 * class.cs (Event.Define): Register event and perform appropriate checks
28015 We define the Add and Remove methods even if the use provides none because
28016 in that case, we provide default implementations ourselves.
28018 Define a private field of the type of the event. This is done by the CSC compiler
28019 and we should be doing it too ;-)
28021 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
28022 More methods we use in code we generate.
28024 (multicast_delegate_type, delegate_type): Two separate types since the distinction
28027 (InitCoreTypes): Update accordingly for the above.
28029 * class.cs (Event.Emit): Generate code for default accessors that we provide
28031 (EmitDefaultMethod): Do the job in the above.
28033 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
28036 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28038 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
28039 builders even if we were missing one.
28041 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
28042 pass the Basename as our class name instead of the Name. The
28043 basename will be correctly composed for us.
28045 * parameter.cs (Paramters): Now takes a Location argument.
28047 * decl.cs (DeclSpace.LookupType): Removed convenience function and
28048 make all the code call directly LookupType in RootContext and take
28049 this chance to pass the Location information everywhere.
28051 * Everywhere: pass Location information.
28053 2001-12-19 Miguel de Icaza <miguel@ximian.com>
28055 * class.cs (Constructor.Define): Updated way of detecting the
28056 length of the parameters.
28058 (TypeContainer.DefineType): Use basename as the type name for
28061 (TypeContainer.Define): Do not recursively define types here, as
28062 definition is taken care in order by the RootContext.
28064 * tree.cs: Keep track of namespaces in a per-file basis.
28066 * parameter.cs (Parameter.ComputeSignature): Update to use
28069 (Parameters.GetSignature): ditto.
28071 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
28072 instead of a TypeContainer.
28074 (Interface.SemanticAnalysis): Use `this' instead of our parent to
28075 resolve names. Because we need to be resolve in our context, not
28078 * driver.cs: Implement response files.
28080 * class.cs (TypeContainer.DefineType): If we are defined, do not
28081 redefine ourselves.
28083 (Event.Emit): Emit the code for add/remove handlers.
28084 (Event.Define): Save the MethodBuilders for add/remove.
28086 * typemanager.cs: Use pair here too.
28088 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
28089 DictionaryEntry requires the first argument to be non-null.
28091 (enum_declaration): Compute full name for registering the
28094 (delegate_declaration): Instead of using
28095 formal_parameter_list, use opt_formal_parameter_list as the list
28098 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
28099 (EventParsing): New property that controls whether `add' and
28100 `remove' are returned as tokens or identifiers (for events);
28102 2001-12-19 Ravi Pratap <ravi@ximian.com>
28104 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
28105 use MyEventBuilder only and let it wrap the real builder for us.
28107 (MyEventBuilder): Revamp constructor etc.
28109 Implement all operations that we perform on EventBuilder in precisely the same
28112 (FindMembers): Update to use the EventBuilder member.
28114 (Event.Emit): Update accordingly.
28116 2001-12-18 Ravi Pratap <ravi@ximian.com>
28118 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
28119 by calling the appropriate methods.
28121 (GetCustomAttributes): Make stubs as they cannot possibly do anything
28124 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
28126 2001-12-17 Ravi Pratap <ravi@ximian.com>
28128 * delegate.cs (Delegate.Populate): Check that the return type
28129 and various parameters types are indeed accessible.
28131 * class.cs (Constructor.Define): Same here.
28133 (Field.Define): Ditto.
28135 (Event.Define): Ditto.
28137 (Operator.Define): Check that the underlying Method defined itself
28138 correctly - so it's MethodBuilder should not be null.
28140 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
28141 expression happens to be null.
28143 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
28144 members but as of now we don't seem to be able to do anything really useful with it.
28146 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
28147 not the EventBuilder.
28149 2001-12-18 Miguel de Icaza <miguel@ximian.com>
28151 * cs-tokenizer.cs: Add support for defines.
28152 Add support for #if, #elif, #else, #endif
28154 (eval_var): evaluates a variable.
28155 (eval): stubbed for evaluating functions.
28157 * cs-parser.jay: Pass the defines information
28159 * driver.cs: Add --define command line option.
28161 * decl.cs: Move MemberCore here.
28163 Make it the base class for DeclSpace. This allows us to catch and
28164 report 108 and 109 for everything now.
28166 * class.cs (TypeContainer.Define): Extract all the members
28167 before populating and emit the warning 108 (new keyword required
28168 to override) instead of having each member implement this.
28170 (MemberCore.Define): New abstract method, we will be using this in
28171 the warning reporting engine in Populate.
28173 (Operator.Define): Adjust to new MemberCore protocol.
28175 * const.cs (Const): This does not derive from Expression, it is a
28176 temporary object we use to create fields, it is a MemberCore.
28178 * class.cs (Method.Define): Allow the entry point to be in a
28181 * driver.cs: Rewrite the argument handler to clean it up a bit.
28183 * rootcontext.cs: Made it just an auxiliary namespace feature by
28184 making everything static.
28186 * driver.cs: Adapt code to use RootContext type name instead of
28189 * delegate.cs: Remove RootContext argument.
28191 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
28194 * class.cs (Event.Define): The lookup can fail.
28196 * cs-tokenizer.cs: Begin implementation of pre-procesor.
28198 * expression.cs: Resolve the this instance before invoking the code.
28200 2001-12-17 Miguel de Icaza <miguel@ximian.com>
28202 * cs-parser.jay: Add a production in element_access that allows
28203 the thing to become a "type" reference. This way we can parse
28204 things like "(string [])" as a type.
28206 Note that this still does not handle the more complex rules of
28210 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
28212 * ecore.cs: (CopyNewMethods): new utility function used to
28213 assemble the list of methods from running FindMembers.
28215 (MemberLookup): Rework FindMembers so that
28217 2001-12-16 Miguel de Icaza <miguel@ximian.com>
28219 * class.cs (TypeContainer): Remove Delegates who fail to be
28222 * delegate.cs (Populate): Verify that we dont get null return
28223 values. TODO: Check for AsAccessible.
28225 * cs-parser.jay: Use basename to emit error 574 (destructor should
28226 have the same name as container class), not the full name.
28228 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
28229 possible representation.
28231 Also implements integer type suffixes U and L.
28233 2001-12-15 Miguel de Icaza <miguel@ximian.com>
28235 * expression.cs (ArrayCreation.DoResolve): We need to do the
28236 argument resolution *always*.
28238 * decl.cs: Make this hold the namespace. Hold the root context as
28240 (LookupType): Move here.
28242 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
28244 * location.cs (Row, Name): Fixed the code, it was always returning
28245 references to the first file.
28247 * interface.cs: Register properties defined through interfaces.
28249 * driver.cs: Add support for globbing on the command line
28251 * class.cs (Field): Make it derive from MemberCore as well.
28254 2001-12-15 Ravi Pratap <ravi@ximian.com>
28256 * class.cs (Event::Define): Check that the type of the event is a delegate
28257 type else flag error #66.
28259 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
28262 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
28263 values of EntryPoint, CharSet etc etc.
28265 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
28267 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
28268 be null and we should ignore this. I am not sure if this is really clean. Apparently,
28269 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
28270 which needs this to do its work.
28272 * ../errors/cs0066.cs : Add.
28274 2001-12-14 Miguel de Icaza <miguel@ximian.com>
28276 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
28279 * class.cs: (MethodSignature.MethodSignature): Removed hack that
28280 clears out the parameters field.
28281 (MemberSignatureCompare): Cleanup
28283 (MemberCore): New base class used to share code between MethodCore
28286 (RegisterRequiredImplementations) BindingFlags.Public requires
28287 either BindingFlags.Instace or Static. Use instance here.
28289 (Property): Refactored code to cope better with the full spec.
28291 * parameter.cs (GetParameterInfo): Return an empty array instead
28294 * class.cs (Property): Abstract or extern properties have no bodies.
28296 * parameter.cs (GetParameterInfo): return a zero-sized array.
28298 * class.cs (TypeContainer.MethodModifiersValid): Move all the
28299 method modifier validation to the typecontainer so we can reuse
28300 this on properties.
28302 (MethodCore.ParameterTypes): return an empty sized array of types.
28304 (Property.Define): Test property modifier validity.
28306 Add tests for sealed/override too.
28308 (Method.Emit): abstract or extern methods have no bodies.
28310 2001-12-14 Ravi Pratap <ravi@ximian.com>
28312 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
28315 (Method::Define, ::Emit): Modify accordingly.
28317 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
28319 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
28321 * makefile: Pass in /unsafe.
28323 2001-12-13 Miguel de Icaza <miguel@ximian.com>
28325 * class.cs (MakeKey): Kill routine.
28327 * class.cs (TypeContainer.Define): Correctly define explicit
28328 method implementations (they require the full interface name plus
28331 * typemanager.cs: Deply the PtrHashtable here and stop using the
28332 lame keys. Things work so much better.
28334 This of course broke everyone who depended on `RegisterMethod' to
28335 do the `test for existance' test. This has to be done elsewhere.
28337 * support.cs (PtrHashtable): A hashtable that avoid comparing with
28338 the object stupid Equals method (because, that like fails all over
28339 the place). We still do not use it.
28341 * class.cs (TypeContainer.SetRequiredInterface,
28342 TypeContainer.RequireMethods): Killed these two routines and moved
28343 all the functionality to RegisterRequiredImplementations.
28345 (TypeContainer.RegisterRequiredImplementations): This routine now
28346 registers all the implementations required in an array for the
28347 interfaces and abstract methods. We use an array of structures
28348 which can be computed ahead of time to reduce memory usage and we
28349 also assume that lookups are cheap as most classes will not
28350 implement too many interfaces.
28352 We also avoid creating too many MethodSignatures.
28354 (TypeContainer.IsInterfaceMethod): Update and optionally does not
28355 clear the "pending" bit if we find that there are problems with
28358 (TypeContainer.VerifyPendingMethods): Update to report errors of
28359 methods that look like implementations but are not.
28361 (TypeContainer.Define): Add support for explicit interface method
28364 2001-12-12 Miguel de Icaza <miguel@ximian.com>
28366 * typemanager.cs: Keep track of the parameters here instead of
28367 being a feature of the TypeContainer.
28369 * class.cs: Drop the registration of parameters here, as
28370 InterfaceMethods are also interface declarations.
28372 * delegate.cs: Register methods with the TypeManager not only with
28373 the TypeContainer. This code was buggy.
28375 * interface.cs: Full registation here.
28377 2001-12-11 Miguel de Icaza <miguel@ximian.com>
28379 * expression.cs: Remove reducer for binary expressions, it can not
28382 * const.cs: Put here the code that used to go into constant.cs
28384 * constant.cs: Put here the code for constants, this is a new base
28385 class for Literals.
28387 * literal.cs: Make Literal derive from Constant.
28389 2001-12-09 Miguel de Icaza <miguel@ximian.com>
28391 * statement.cs (Return.Emit): Report error 157 if the user
28392 attempts to return from a finally block.
28394 (Return.Emit): Instead of emitting a return, jump to the end of
28397 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
28398 LocalBuilder to store the result of the function. ReturnLabel is
28399 the target where we jump.
28402 2001-12-09 Radek Doulik <rodo@ximian.com>
28404 * cs-parser.jay: remember alias in current namespace
28406 * ecore.cs (SimpleName::DoResolve): use aliases for types or
28409 * class.cs (LookupAlias): lookup alias in my_namespace
28411 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
28413 (LookupAlias): lookup alias in this and if needed in parent
28416 2001-12-08 Miguel de Icaza <miguel@ximian.com>
28420 * rootcontext.cs: (ModuleBuilder) Made static, first step into
28421 making things static. I need this to avoid passing the
28422 TypeContainer when calling ParameterType.
28424 * support.cs (InternalParameters.ParameterType): Remove ugly hack
28425 that did string manipulation to compute the type and then call
28426 GetType. Use Parameter.ParameterType instead.
28428 * cs-tokenizer.cs: Consume the suffix for floating values.
28430 * expression.cs (ParameterReference): figure out whether this is a
28431 reference parameter or not. Kill an extra variable by computing
28432 the arg_idx during emission.
28434 * parameter.cs (Parameters.GetParameterInfo): New overloaded
28435 function that returns whether a parameter is an out/ref value or not.
28437 (Parameter.ParameterType): The type of the parameter (base,
28438 without ref/out applied).
28440 (Parameter.Resolve): Perform resolution here.
28441 (Parameter.ExternalType): The full type (with ref/out applied).
28443 * statement.cs (Using.Emit, Using.EmitExpression): Implement
28444 support for expressions on the using statement.
28446 2001-12-07 Miguel de Icaza <miguel@ximian.com>
28448 * statement.cs (Using.EmitLocalVariableDecls): Split the
28449 localvariable handling of the using statement.
28451 (Block.EmitMeta): Keep track of variable count across blocks. We
28452 were reusing slots on separate branches of blocks.
28454 (Try.Emit): Emit the general code block, we were not emitting it.
28456 Check the type of the declaration to be an IDisposable or
28457 something that can be implicity converted to it.
28459 Emit conversions if required.
28461 * ecore.cs (EmptyExpression): New utility class.
28462 (Expression.ImplicitConversionExists): New utility function.
28464 2001-12-06 Miguel de Icaza <miguel@ximian.com>
28466 * statement.cs (Using): Implement.
28468 * expression.cs (LocalVariableReference): Support read only variables.
28470 * statement.cs: Remove the explicit emit for the Leave opcode.
28471 (VariableInfo): Add a readonly field.
28473 2001-12-05 Miguel de Icaza <miguel@ximian.com>
28475 * ecore.cs (ConvCast): new class used to encapsulate the various
28476 explicit integer conversions that works in both checked and
28477 unchecked contexts.
28479 (Expression.ConvertNumericExplicit): Use new ConvCast class to
28480 properly generate the overflow opcodes.
28482 2001-12-04 Miguel de Icaza <miguel@ximian.com>
28484 * statement.cs: The correct type for the EmptyExpression is the
28485 element_type, not the variable type. Ravi pointed this out.
28487 2001-12-04 Ravi Pratap <ravi@ximian.com>
28489 * class.cs (Method::Define): Handle PInvoke methods specially
28490 by using DefinePInvokeMethod instead of the usual one.
28492 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
28493 above to do the task of extracting information and defining the method.
28495 2001-12-04 Ravi Pratap <ravi@ximian.com>
28497 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
28498 of the condition for string type.
28500 (Emit): Move that here.
28502 (ArrayCreation::CheckIndices): Keep string literals in their expression
28505 (EmitDynamicInitializers): Handle strings appropriately.
28507 2001-12-04 Miguel de Icaza <miguel@ximian.com>
28509 * codegen.cs (EmitContext): Replace multiple variables with a
28510 single pointer to the current Switch statement.
28512 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
28515 2001-12-03 Miguel de Icaza <miguel@ximian.com>
28519 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
28522 (Foreach.Emit): Foreach on arrays was not setting
28523 up the loop variables (for break/continue).
28525 (GotoCase): Semi-implented.
28527 2001-12-03 Ravi Pratap <ravi@ximian.com>
28529 * attribute.cs (CheckAttribute): Handle system attributes by using
28530 Attribute.GetAttributes to examine information we need.
28532 (GetValidPlaces): Same here.
28534 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
28536 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
28538 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
28540 (Method::Define): Set appropriate flags if we have a DllImport attribute.
28542 (Method::Emit): Handle the case when we are a PInvoke method.
28544 2001-12-03 Miguel de Icaza <miguel@ximian.com>
28546 * expression.cs: Use ResolveWithSimpleName on compound names.
28548 2001-12-02 Ravi Pratap <ravi@ximian.com>
28550 * constant.cs (EmitConstant): Make sure we resolve the associated expression
28551 before trying to reduce it.
28553 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
28555 * constant.cs (LookupConstantValue): Implement.
28557 (EmitConstant): Use the above in emitting the constant.
28559 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
28560 that are user-defined by doing a LookupConstantValue on them.
28562 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
28565 2001-11-29 Miguel de Icaza <miguel@ximian.com>
28567 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
28569 (BaseAccess.DoResolve): Implement.
28571 (MemberAccess.DoResolve): Split this routine into a
28572 ResolveMemberAccess routine that can be used independently
28574 2001-11-28 Miguel de Icaza <miguel@ximian.com>
28576 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
28577 As that share bits of the implementation. Is returns a boolean,
28578 while As returns the Type that is being probed.
28580 2001-12-01 Ravi Pratap <ravi@ximian.com>
28582 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
28583 instead of a Literal - much easier.
28585 (EnumInTransit): Remove - utterly useless :-)
28587 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
28589 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
28591 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
28592 chain when we have no associated expression.
28594 2001-11-30 Ravi Pratap <ravi@ximian.com>
28596 * constant.cs (Define): Use Location while reporting the errror.
28598 Also emit a warning when 'new' is used and there is no inherited
28601 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
28604 (LookupEnumValue): Implement to lookup an enum member's value and define it
28607 (Populate): Re-write accordingly to use the above routine.
28609 2001-11-27 Miguel de Icaza <miguel@ximian.com>
28611 * expression.cs (This): Fix prototype for DoResolveLValue to
28612 override the base class DoResolveLValue.
28614 * cs-parser.cs: Report errors cs574 and cs575 (destructor
28617 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
28618 (we need to load the address of the field here). This fixes
28621 (FieldExpr.DoResolveLValue): Call the DoResolve
28622 function to initialize the Instance expression.
28624 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
28625 correctly the GetEnumerator operation on a value type.
28627 * cs-parser.jay: Add more simple parsing error catches.
28629 * statement.cs (Switch): Add support for string switches.
28630 Handle null specially.
28632 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
28634 2001-11-28 Ravi Pratap <ravi@ximian.com>
28636 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
28638 (declare_local_constant): New helper function.
28640 * statement.cs (AddConstant): Keep a separate record of constants
28642 (IsConstant): Implement to determine if a variable is a constant.
28644 (GetConstantExpression): Implement.
28646 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
28648 * statement.cs (IsVariableDefined): Re-write.
28650 2001-11-27 Ravi Pratap <ravi@ximian.com>
28652 * class.cs (TypeContainer::FindMembers): Look for constants
28653 in the case when we are looking for MemberTypes.Field
28655 * expression.cs (MemberAccess::DoResolve): Check that in the
28656 case we are a FieldExpr and a Literal, we are not being accessed
28657 by an instance reference.
28659 * cs-parser.jay (local_constant_declaration): Implement.
28661 (declaration_statement): Implement for constant declarations.
28663 2001-11-26 Miguel de Icaza <miguel@ximian.com>
28665 * statement.cs (Switch): Catch double defaults.
28667 (Switch): More work on the switch() statement
28668 implementation. It works for integral values now, need to finish
28672 2001-11-24 Miguel de Icaza <miguel@ximian.com>
28674 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
28675 integer literals into other integer literals. To be used by
28678 2001-11-24 Ravi Pratap <ravi@ximian.com>
28680 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
28683 (EmitDynamicInitializers): Cope with the above since we extract data
28684 directly from ArrayData now.
28686 (ExpectInitializers): Keep track of whether initializers are mandatory
28689 (Bounds): Make it a hashtable to prevent the same dimension being
28690 recorded for every element in that dimension.
28692 (EmitDynamicInitializers): Fix bug which prevented the Set array method
28695 Also fix bug which was causing the indices to be emitted in the reverse
28698 2001-11-24 Miguel de Icaza <miguel@ximian.com>
28700 * expression.cs (ArrayCreation): Implement the bits that Ravi left
28701 unfinished. They do not work, because the underlying code is
28704 2001-11-22 Miguel de Icaza <miguel@ximian.com>
28706 * cs-parser.jay: Remove bogus fixme.
28708 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
28709 on Switch statement.
28711 2001-11-23 Ravi Pratap <ravi@ximian.com>
28713 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
28716 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
28717 parameter. Apparently, any expression is allowed.
28719 (ValidateInitializers): Update accordingly.
28721 (CheckIndices): Fix some tricky bugs thanks to recursion.
28723 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
28724 I was being completely brain-dead.
28726 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
28727 and re-write acordingly.
28729 (DelegateInvocation): Re-write accordingly.
28731 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
28733 (MakeByteBlob): Handle types more correctly.
28735 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
28736 initialization from expressions but it is incomplete because I am a complete
28739 2001-11-22 Miguel de Icaza <miguel@ximian.com>
28741 * statement.cs (If.Emit): Fix a bug that generated incorrect code
28742 on If. Basically, we have to return `true' (ie, we do return to
28743 our caller) only if both branches of the if return.
28745 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
28746 short-circuit operators, handle them as short circuit operators.
28748 (Cast.DoResolve): Resolve type.
28749 (Cast.Cast): Take an expression as the target type.
28751 * cs-parser.jay (cast_expression): Remove old hack that only
28752 allowed a limited set of types to be handled. Now we take a
28753 unary_expression and we resolve to a type during semantic
28756 Use the grammar productions from Rhys to handle casts (this is
28757 not complete like Rhys syntax yet, we fail to handle that corner
28758 case that C# has regarding (-x), but we will get there.
28760 2001-11-22 Ravi Pratap <ravi@ximian.com>
28762 * class.cs (EmitFieldInitializer): Take care of the case when we have a
28763 field which is an array type.
28765 * cs-parser.jay (declare_local_variables): Support array initialization too.
28767 * typemanager.cs (MakeKey): Implement.
28769 (everywhere): Use the above appropriately.
28771 * cs-parser.jay (for_statement): Update for array initialization while
28772 declaring variables.
28774 * ecore.cs : The error message was correct, it's the variable's names that
28775 were misleading ;-) Make the code more readable.
28777 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
28778 the correct type etc.
28780 (ConvertExplicit): Handle Enum types by examining the underlying type.
28782 2001-11-21 Ravi Pratap <ravi@ximian.com>
28784 * parameter.cs (GetCallingConvention): Always return
28785 CallingConventions.Standard for now.
28787 2001-11-22 Miguel de Icaza <miguel@ximian.com>
28789 * expression.cs (Binary.ResolveOperator): Update the values of `l'
28790 and `r' after calling DoNumericPromotions.
28792 * ecore.cs: Fix error message (the types were in the wrong order).
28794 * statement.cs (Foreach.ProbeCollectionType): Need to pass
28795 BindingFlags.Instance as well
28797 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
28798 implicit int literal conversion in an empty cast so that we
28799 propagate the right type upstream.
28801 (UnboxCast): new class used to unbox value types.
28802 (Expression.ConvertExplicit): Add explicit type conversions done
28805 (Expression.ImplicitNumericConversion): Oops, forgot to test for
28806 the target type before applying the implicit LongLiterals to ULong
28809 2001-11-21 Miguel de Icaza <miguel@ximian.com>
28811 * cs-parser.jay (for_statement): Reworked the way For works: now
28812 we declare manually any variables that are introduced in
28813 for_initializer to solve the problem of having out-of-band code
28814 emition (that is what got for broken).
28816 (declaration_statement): Perform the actual variable declaration
28817 that used to be done in local_variable_declaration here.
28819 (local_variable_declaration): Do not declare anything, just pass
28820 the information on a DictionaryEntry
28822 2001-11-20 Ravi Pratap <ravi@ximian.com>
28824 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
28825 re-write of the logic to now make it recursive.
28827 (UpdateIndices): Re-write accordingly.
28829 Store element data in a separate ArrayData list in the above methods.
28831 (MakeByteBlob): Implement to dump the array data into a byte array.
28833 2001-11-19 Ravi Pratap <ravi@ximian.com>
28835 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
28838 * constant.cs (Define): Implement.
28840 (EmitConstant): Re-write fully.
28842 Pass in location info.
28844 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
28847 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
28848 DictionaryEntry since we need location info too.
28850 (constant_declaration): Update accordingly.
28852 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
28853 code into another method : UpdateIndices.
28855 2001-11-18 Ravi Pratap <ravi@ximian.com>
28857 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
28858 some type checking etc.
28860 2001-11-17 Ravi Pratap <ravi@ximian.com>
28862 * expression.cs (ArrayCreation::ValidateInitializers): Implement
28863 bits to provide dimension info if the user skips doing that.
28865 Update second constructor to store the rank correctly.
28867 2001-11-16 Ravi Pratap <ravi@ximian.com>
28869 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
28870 and try to implement.
28872 * ../errors/cs0150.cs : Add.
28874 * ../errors/cs0178.cs : Add.
28876 2001-11-16 Miguel de Icaza <miguel@ximian.com>
28878 * statement.cs: Implement foreach on multi-dimensional arrays.
28880 * parameter.cs (Parameters.GetParameterByName): Also lookup the
28881 name of the params argument.
28883 * expression.cs: Use EmitStoreOpcode to get the right opcode while
28884 initializing the array.
28886 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
28887 we can use this elsewhere.
28889 * statement.cs: Finish implementation of foreach for single
28892 * cs-parser.jay: Use an out-of-band stack to pass information
28893 around, I wonder why I need this.
28895 foreach_block: Make the new foreach_block the current_block.
28897 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
28898 function used to return a static Parameters structure. Used for
28899 empty parameters, as those are created very frequently.
28901 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
28903 2001-11-15 Ravi Pratap <ravi@ximian.com>
28905 * interface.cs : Default modifier is private, not public. The
28906 make verify test passes again.
28908 2001-11-15 Ravi Pratap <ravi@ximian.com>
28910 * support.cs (ReflectionParameters): Fix logic to determine
28911 whether the last parameter is a params one. Test 9 passes again.
28913 * delegate.cs (Populate): Register the builders we define with
28914 RegisterParameterForBuilder. Test 19 passes again.
28916 * cs-parser.jay (property_declaration): Reference $6 instead
28917 of $$ to get at the location.
28919 (indexer_declaration): Similar stuff.
28921 (attribute): Ditto.
28923 * class.cs (Property): Register parameters for the Get and Set methods
28924 if they exist. Test 23 passes again.
28926 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
28927 call to EmitArguments as we are sure there aren't any params arguments.
28928 Test 32 passes again.
28930 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
28931 IndexOutOfRangeException.
28933 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
28934 Test 33 now passes again.
28936 2001-11-15 Miguel de Icaza <miguel@ximian.com>
28938 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
28939 broke a bunch of things. Will have to come up with a better way
28940 of tracking locations.
28942 * statement.cs: Implemented foreach for single dimension arrays.
28944 2001-11-09 Miguel de Icaza <miguel@ximian.com>
28946 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
28947 an error. This removes the lookup from the critical path.
28949 * cs-parser.jay: Removed use of temporary_loc, which is completely
28952 2001-11-14 Miguel de Icaza <miguel@ximian.com>
28954 * support.cs (ReflectionParameters.ParameterModifier): Report
28955 whether the argument is a PARAMS argument or not.
28957 * class.cs: Set the attribute `ParamArrayAttribute' on the
28958 parameter argument.
28960 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
28961 and cons_param_array_attribute (ConstructorInfo for
28962 ParamArrayAttribute).,
28964 * codegen.cs: Emit the return using the `Return' statement, that
28965 way we can report the error correctly for missing return values.
28967 * class.cs (Method.Emit): Clean up.
28969 * expression.cs (Argument.Resolve): Take another argument: the
28970 location where this argument is used. Notice that this is not
28971 part of the "Argument" class as to reduce the size of the
28972 structure (we know the approximate location anyways).
28974 Test if the argument is a variable-reference, if not, then
28975 complain with a 206.
28977 (Argument.Emit): Emit addresses of variables.
28979 (Argument.FullDesc): Simplify.
28981 (Invocation.DoResolve): Update for Argument.Resolve.
28983 (ElementAccess.DoResolve): ditto.
28985 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
28986 method should be virtual, as this method is always virtual.
28988 (NewDelegate.DoResolve): Update for Argument.Resolve.
28990 * class.cs (ConstructorInitializer.DoResolve): ditto.
28992 * attribute.cs (Attribute.Resolve): ditto.
28994 2001-11-13 Miguel de Icaza <miguel@ximian.com>
28996 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
28998 * expression.cs (ParameterReference): Drop IStackStorage and implement
28999 IAssignMethod instead.
29001 (LocalVariableReference): ditto.
29003 * ecore.cs (FieldExpr): Drop IStackStorage and implement
29004 IAssignMethod instead.
29006 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29008 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
29009 enumerations that are used in heavily used structures derive from
29010 byte in a laughable and pathetic attempt to reduce memory usage.
29011 This is the kind of pre-optimzations that you should not do at
29012 home without adult supervision.
29014 * expression.cs (UnaryMutator): New class, used to handle ++ and
29015 -- separatedly from the other unary operators. Cleans up the
29016 code, and kills the ExpressionStatement dependency in Unary.
29018 (Unary): Removed `method' and `Arguments' from this class, making
29019 it smaller, and moving it all to SimpleCall, so I can reuse this
29020 code in other locations and avoid creating a lot of transient data
29021 strucutres when not required.
29023 * cs-parser.jay: Adjust for new changes.
29025 2001-11-11 Miguel de Icaza <miguel@ximian.com>
29027 * enum.cs (Enum.Populate): If there is a failure during
29030 * cs-parser.jay (opt_enum_base): we used to catch type errors
29031 here, but this is really incorrect. The type error should be
29032 catched during semantic analysis.
29034 2001-12-11 Ravi Pratap <ravi@ximian.com>
29036 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
29037 current_local_parameters as expected since I, in my stupidity, had forgotten
29040 * attribute.cs (GetValidPlaces): Fix stupid bug.
29042 * class.cs (Method::Emit): Perform check on applicability of attributes.
29044 (Constructor::Emit): Ditto.
29046 (Field::Emit): Ditto.
29048 (Field.Location): Store location information.
29050 (Property, Event, Indexer, Operator): Ditto.
29052 * cs-parser.jay (field_declaration): Pass in location for each field.
29054 * ../errors/cs0592.cs : Add.
29056 2001-11-12 Ravi Pratap <ravi@ximian.com>
29058 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
29060 (InitCoreTypes): Update accordingly.
29062 (RegisterAttrType, LookupAttr): Implement.
29064 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
29065 info about the same.
29067 (Resolve): Update to populate the above as necessary.
29069 (Error592): Helper.
29071 (GetValidPlaces): Helper to the above.
29073 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
29075 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
29077 2001-11-12 Ravi Pratap <ravi@ximian.com>
29079 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
29081 * ../errors/cs0617.cs : Add.
29083 2001-11-11 Ravi Pratap <ravi@ximian.com>
29085 * enum.cs (Emit): Rename to Populate to be more consistent with what
29086 we expect it to do and when exactly it is called.
29088 * class.cs, rootcontext.cs : Update accordingly.
29090 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
29091 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
29093 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
29095 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
29096 of a fieldinfo using the above, when dealing with a FieldBuilder.
29098 2001-11-10 Ravi Pratap <ravi@ximian.com>
29100 * ../errors/cs0031.cs : Add.
29102 * ../errors/cs1008.cs : Add.
29104 * ../errrors/cs0543.cs : Add.
29106 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
29109 (FindMembers): Implement.
29111 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
29112 enums and delegates too.
29114 (enum_types): Rename to builder_to_enum.
29116 (delegate_types): Rename to builder_to_delegate.
29118 * delegate.cs (FindMembers): Implement.
29120 2001-11-09 Ravi Pratap <ravi@ximian.com>
29122 * typemanager.cs (IsEnumType): Implement.
29124 * enum.cs (Emit): Re-write parts to account for the underlying type
29125 better and perform checking etc.
29127 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
29128 of the underlying type.
29130 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
29133 * enum.cs (error31): Helper to report error #31.
29135 * cs-parser.jay (enum_declaration): Store location of each member too.
29137 * enum.cs (member_to_location): New hashtable.
29139 (AddEnumMember): Update location hashtable.
29141 (Emit): Use the location of each member while reporting errors.
29143 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29145 * cs-parser.jay: A for_initializer if is a
29146 local_variable_declaration really ammount to have an implicit
29147 block with the variable declaration and no initializer for for.
29149 * statement.cs (For.Emit): Cope with null initializers.
29151 This fixes the infinite loop on for initializers.
29153 2001-11-08 Miguel de Icaza <miguel@ximian.com>
29155 * enum.cs: More cleanup.
29157 * ecore.cs: Remove dead code.
29159 * class.cs (Property.Emit): More simplification.
29160 (Event.Emit): ditto.
29162 Reworked to have less levels of indentation.
29164 2001-11-08 Ravi Pratap <ravi@ximian.com>
29166 * class.cs (Property): Emit attributes.
29176 * enum.cs (Emit): Ditto.
29178 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
29181 * class.cs (Field, Event, etc.): Move attribute generation into the
29182 Emit method everywhere.
29184 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
29185 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
29186 as we had no way of defining nested enums !
29188 * rootcontext.cs : Adjust code accordingly.
29190 * typemanager.cs (AddEnumType): To keep track of enum types separately.
29192 2001-11-07 Ravi Pratap <ravi@ximian.com>
29194 * expression.cs (EvalConstantExpression): Move into ecore.cs
29196 * enum.cs (Enum): Rename some members and make them public and readonly
29197 according to our convention.
29199 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
29202 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
29204 (Enum::Emit): Write a simple version for now which doesn't try to compute
29205 expressions. I shall modify this to be more robust in just a while.
29207 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
29209 (TypeContainer::CloseType): Create the Enum types too.
29211 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
29213 * expression.cs (EvalConstantExpression): Get rid of completely.
29215 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
29216 user-defined values and other cases.
29218 (IsValidEnumLiteral): Helper function.
29220 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
29221 out there in the case we had a literal FieldExpr.
29223 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
29225 (Literalize): Revamp a bit to take two arguments.
29227 (EnumLiteral): New class which derives from Literal to wrap enum literals.
29229 2001-11-06 Ravi Pratap <ravi@ximian.com>
29231 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
29233 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
29235 (Resolve): Use the above to ensure we have proper initializers.
29237 2001-11-05 Ravi Pratap <ravi@ximian.com>
29239 * expression.cs (Expression::EvalConstantExpression): New method to
29240 evaluate constant expressions.
29242 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
29244 2001-11-07 Miguel de Icaza <miguel@ximian.com>
29246 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
29249 (Binary.ResolveOperator): Handle operator != (object a, object b)
29250 and operator == (object a, object b);
29252 (Binary.DoNumericPromotions): Indicate whether the numeric
29253 promotion was possible.
29255 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
29258 Made the ArrayAccess implement interface IAssignMethod instead of
29259 IStackStore as the order in which arguments are passed reflects
29262 * assign.cs: Instead of using expr.ExprClass to select the way of
29263 assinging, probe for the IStackStore/IAssignMethod interfaces.
29265 * typemanager.cs: Load InitializeArray definition.
29267 * rootcontext.cs (RootContext.MakeStaticData): Used to define
29268 static data that can be used to initialize arrays.
29270 2001-11-05 Miguel de Icaza <miguel@ximian.com>
29272 * expression.cs: Handle operator== and operator!= for booleans.
29274 (Conditioal.Reduce): Implement reducer for the ?: operator.
29276 (Conditional.Resolve): Implement dead code elimination.
29278 (Binary.Resolve): Catch string literals and return a new
29279 concatenated string.
29281 (Unary.Reduce): Implement reduction of unary expressions.
29283 * ecore.cs: Split out the expression core handling here.
29285 (Expression.Reduce): New method used to perform constant folding
29286 and CSE. This is needed to support constant-expressions.
29288 * statement.cs (Statement.EmitBoolExpression): Pass true and false
29289 targets, and optimize for !x.
29291 2001-11-04 Ravi Pratap <ravi@ximian.com>
29293 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
29294 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
29295 set custom atttributes.
29297 * literal.cs (Literal::GetValue): New abstract method to return the actual
29298 value of the literal, cast as an object.
29300 (*Literal): Implement GetValue method.
29302 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
29303 expressions to the arraylist but objects of type Argument.
29305 * class.cs (TypeContainer::Emit): Emit our attributes too.
29307 (Method::Emit, Constructor::Emit): Ditto.
29309 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
29310 to be ignoring earlier.
29312 2001-11-03 Ravi Pratap <ravi@ximian.com>
29314 * attribute.cs (AttributeSection::Define): Implement to do the business
29315 of constructing a CustomAttributeBuilder.
29317 (Attribute): New trivial class. Increases readability of code.
29319 * cs-parser.jay : Update accordingly.
29321 (positional_argument_list, named_argument_list, named_argument): New rules
29323 (attribute_arguments): Use the above so that we are more correct.
29325 2001-11-02 Ravi Pratap <ravi@ximian.com>
29327 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
29328 to perform all checks for a method with a params parameter.
29330 (Invocation::OverloadResolve): Update to use the above method and therefore
29331 cope correctly with params method invocations.
29333 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
29336 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
29337 constructors in our parent too because we can't afford to miss out on
29340 * attribute.cs (AttributeSection): New name for the class Attribute
29342 Other trivial changes to improve readability.
29344 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
29345 use the new class names.
29347 2001-11-01 Ravi Pratap <ravi@ximian.com>
29349 * class.cs (Method::Define): Complete definition for params types too
29351 (Indexer::Define): Ditto.
29353 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
29354 Cope everywhere with a request for info about the array parameter.
29356 2001-11-01 Ravi Pratap <ravi@ximian.com>
29358 * tree.cs (RecordNamespace): Fix up to check for the correct key.
29360 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
29361 local_variable_type to extract the string corresponding to the type.
29363 (local_variable_type): Fixup the action to use the new helper method.
29365 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
29368 * expression.cs : Clean out code which uses the above.
29370 2001-10-31 Ravi Pratap <ravi@ximian.com>
29372 * typemanager.cs (RegisterMethod): Check if we already have an existing key
29373 and bale out if necessary by returning a false.
29375 (RegisterProperty): Ditto.
29377 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
29378 and print out appropriate error messages.
29380 * interface.cs (everywhere): Ditto.
29382 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
29383 location to constructor.
29385 * class.cs (Property, Event, Indexer): Update accordingly.
29387 * ../errors/cs111.cs : Added.
29389 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
29390 of a method, as laid down by the spec.
29392 (Invocation::OverloadResolve): Use the above method.
29394 2001-10-31 Ravi Pratap <ravi@ximian.com>
29396 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
29397 now take a TypeContainer and a Parameters object.
29399 (ParameterData): Modify return type of ParameterModifier method to be
29400 Parameter.Modifier and not a string.
29402 (ReflectionParameters, InternalParameters): Update accordingly.
29404 * expression.cs (Argument::GetParameterModifier): Same here.
29406 * support.cs (InternalParameters::ParameterType): Find a better way of determining
29407 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
29408 symbol in it at all so maybe this is only for now.
29410 2001-10-30 Ravi Pratap <ravi@ximian.com>
29412 * support.cs (InternalParameters): Constructor now takes an extra argument
29413 which is the actual Parameters class.
29415 (ParameterDesc): Update to provide info on ref/out modifiers.
29417 * class.cs (everywhere): Update call to InternalParameters to pass in
29418 the second argument too.
29420 * support.cs (ParameterData): Add ParameterModifier, which is a method
29421 to return the modifier info [ref/out etc]
29423 (InternalParameters, ReflectionParameters): Implement the above.
29425 * expression.cs (Argument::ParameterModifier): Similar function to return
29426 info about the argument's modifiers.
29428 (Invocation::OverloadResolve): Update to take into account matching modifiers
29431 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
29432 a new SetFormalParameters object which we pass to InternalParameters.
29434 2001-10-30 Ravi Pratap <ravi@ximian.com>
29436 * expression.cs (NewArray): Merge into the ArrayCreation class.
29438 2001-10-29 Ravi Pratap <ravi@ximian.com>
29440 * expression.cs (NewArray): Merge classes NewBuiltinArray and
29441 NewUserdefinedArray into one as there wasn't much of a use in having
29444 * expression.cs (Argument): Change field's name to ArgType from Type.
29446 (Type): New readonly property which returns the proper type, taking into
29447 account ref/out modifiers.
29449 (everywhere): Adjust code accordingly for the above.
29451 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
29452 whether we are emitting for a ref or out parameter.
29454 * expression.cs (Argument::Emit): Use the above field to set the state.
29456 (LocalVariableReference::Emit): Update to honour the flag and emit the
29459 * parameter.cs (Attributes): Set the correct flags for ref parameters.
29461 * expression.cs (Argument::FullDesc): New function to provide a full desc.
29463 * support.cs (ParameterData): Add method ParameterDesc to the interface.
29465 (ReflectionParameters, InternalParameters): Implement the above method.
29467 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
29470 (Invocation::FullMethodDesc): Ditto.
29472 2001-10-29 Miguel de Icaza <miguel@ximian.com>
29474 * cs-parser.jay: Add extra production for the second form of array
29477 * expression.cs (ArrayCreation): Update to reflect the above
29480 * Small changes to prepare for Array initialization.
29482 2001-10-28 Miguel de Icaza <miguel@ximian.com>
29484 * typemanager.cs (ImplementsInterface): interface might be null;
29485 Deal with this problem;
29487 Also, we do store negative hits on the cache (null values), so use
29488 this instead of calling t.GetInterfaces on the type everytime.
29490 2001-10-28 Ravi Pratap <ravi@ximian.com>
29492 * typemanager.cs (IsBuiltinType): New method to help determine the same.
29494 * expression.cs (New::DoResolve): Get rid of array creation code and instead
29495 split functionality out into different classes.
29497 (New::FormArrayType): Move into NewBuiltinArray.
29499 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
29502 (NewBuiltinArray): New class to handle creation of built-in arrays.
29504 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
29505 account creation of one-dimensional arrays.
29507 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
29509 (NewUserdefinedArray::DoResolve): Implement.
29511 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
29513 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
29514 we maintain inside the TypeManager. This is necessary to perform lookups on the
29517 (LookupType): Update to perform GetType on the module builders too.
29519 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
29521 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
29523 2001-10-23 Ravi Pratap <ravi@ximian.com>
29525 * expression.cs (New::DoResolve): Implement guts of array creation.
29527 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
29529 2001-10-27 Miguel de Icaza <miguel@ximian.com>
29531 * expression.cs: Fix bug I introduced lsat night that broke
29534 (Expression.Resolve): Report a 246 error (can not resolve name)
29535 if we find a SimpleName in the stream.
29537 (Expression.ResolveLValue): Ditto.
29539 (Expression.ResolveWithSimpleName): This function is a variant of
29540 ResolveName, this one allows SimpleNames to be returned without a
29541 warning. The only consumer of SimpleNames is MemberAccess
29543 2001-10-26 Miguel de Icaza <miguel@ximian.com>
29545 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
29546 might arrive here. I have my doubts that this is correct.
29548 * statement.cs (Lock): Implement lock statement.
29550 * cs-parser.jay: Small fixes to support `lock' and `using'
29552 * cs-tokenizer.cs: Remove extra space
29554 * driver.cs: New flag --checked, allows to turn on integer math
29557 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
29558 Threading.Monitor.Exit
29560 2001-10-23 Miguel de Icaza <miguel@ximian.com>
29562 * expression.cs (IndexerAccess::DoResolveLValue): Set the
29563 Expression Class to be IndexerAccess.
29565 Notice that Indexer::DoResolve sets the eclass to Value.
29567 2001-10-22 Miguel de Icaza <miguel@ximian.com>
29569 * class.cs (TypeContainer::Emit): Emit code for indexers.
29571 * assign.cs (IAssignMethod): New interface implemented by Indexers
29572 and Properties for handling assignment.
29574 (Assign::Emit): Simplify and reuse code.
29576 * expression.cs (IndexerAccess, PropertyExpr): Implement
29577 IAssignMethod, clean up old code.
29579 2001-10-22 Ravi Pratap <ravi@ximian.com>
29581 * typemanager.cs (ImplementsInterface): New method to determine if a type
29582 implements a given interface. Provides a nice cache too.
29584 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
29587 (ConvertReferenceExplicit): Ditto.
29589 * delegate.cs (Delegate::Populate): Update to define the parameters on the
29590 various methods, with correct names etc.
29592 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
29593 Operator.UnaryNegation.
29595 * cs-parser.jay (operator_declarator): Be a little clever in the case where
29596 we have a unary plus or minus operator.
29598 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
29601 * everywhere : update accordingly.
29603 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
29606 * class.cs (Method::Define): For the case where we are implementing a method
29607 inherited from an interface, we need to set the MethodAttributes.Final flag too.
29608 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
29610 2001-10-21 Ravi Pratap <ravi@ximian.com>
29612 * interface.cs (FindMembers): Implement to work around S.R.E
29615 * typemanager.cs (IsInterfaceType): Implement.
29617 (FindMembers): Update to handle interface types too.
29619 * expression.cs (ImplicitReferenceConversion): Re-write bits which
29620 use IsAssignableFrom as that is not correct - it doesn't work.
29622 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
29623 and accordingly override EmitStatement.
29625 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
29626 using the correct logic :-)
29628 2001-10-19 Ravi Pratap <ravi@ximian.com>
29630 * ../errors/cs-11.cs : Add to demonstrate error -11
29632 2001-10-17 Miguel de Icaza <miguel@ximian.com>
29634 * assign.cs (Assign::Resolve): Resolve right hand side first, and
29635 then pass this as a hint to ResolveLValue.
29637 * expression.cs (FieldExpr): Add Location information
29639 (FieldExpr::LValueResolve): Report assignment to readonly
29642 (Expression::ExprClassFromMemberInfo): Pass location information.
29644 (Expression::ResolveLValue): Add new method that resolves an
29647 (Expression::DoResolveLValue): Default invocation calls
29650 (Indexers): New class used to keep track of indexers in a given
29653 (IStackStore): Renamed from LValue, as it did not really describe
29654 what this did. Also ResolveLValue is gone from this interface and
29655 now is part of Expression.
29657 (ElementAccess): Depending on the element access type
29659 * typemanager.cs: Add `indexer_name_type' as a Core type
29660 (System.Runtime.CompilerServices.IndexerNameAttribute)
29662 * statement.cs (Goto): Take a location.
29664 2001-10-18 Ravi Pratap <ravi@ximian.com>
29666 * delegate.cs (Delegate::VerifyDelegate): New method to verify
29667 if two delegates are compatible.
29669 (NewDelegate::DoResolve): Update to take care of the case when
29670 we instantiate a delegate from another delegate.
29672 * typemanager.cs (FindMembers): Don't even try to look up members
29673 of Delegate types for now.
29675 2001-10-18 Ravi Pratap <ravi@ximian.com>
29677 * delegate.cs (NewDelegate): New class to take care of delegate
29680 * expression.cs (New): Split the delegate related code out into
29681 the NewDelegate class.
29683 * delegate.cs (DelegateInvocation): New class to handle delegate
29686 * expression.cs (Invocation): Split out delegate related code into
29687 the DelegateInvocation class.
29689 2001-10-17 Ravi Pratap <ravi@ximian.com>
29691 * expression.cs (New::DoResolve): Implement delegate creation fully
29692 and according to the spec.
29694 (New::DoEmit): Update to handle delegates differently.
29696 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
29697 because of which we were printing out arguments in reverse order !
29699 * delegate.cs (VerifyMethod): Implement to check if the given method
29700 matches the delegate.
29702 (FullDelegateDesc): Implement.
29704 (VerifyApplicability): Implement.
29706 * expression.cs (Invocation::DoResolve): Update to accordingly handle
29707 delegate invocations too.
29709 (Invocation::Emit): Ditto.
29711 * ../errors/cs1593.cs : Added.
29713 * ../errors/cs1594.cs : Added.
29715 * delegate.cs (InstanceExpression, TargetMethod): New properties.
29717 2001-10-16 Ravi Pratap <ravi@ximian.com>
29719 * typemanager.cs (intptr_type): Core type for System.IntPtr
29721 (InitCoreTypes): Update for the same.
29723 (iasyncresult_type, asynccallback_type): Ditto.
29725 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
29728 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
29731 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
29732 the builders for the 4 members of a delegate type :-)
29734 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
29737 * expression.cs (New::DoResolve): Implement guts for delegate creation.
29739 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
29741 2001-10-15 Miguel de Icaza <miguel@ximian.com>
29743 * statement.cs (Break::Emit): Implement.
29744 (Continue::Emit): Implement.
29746 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
29747 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
29748 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
29749 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
29752 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
29753 properties that track the label for the current loop (begin of the
29754 loop and end of the loop).
29756 2001-10-15 Ravi Pratap <ravi@ximian.com>
29758 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
29759 use of emitting anything at all.
29761 * class.cs, rootcontext.cs : Get rid of calls to the same.
29763 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
29765 (Populate): Define the constructor correctly and set the implementation
29768 * typemanager.cs (delegate_types): New hashtable to hold delegates that
29771 (AddDelegateType): Implement.
29773 (IsDelegateType): Implement helper method.
29775 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
29777 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
29778 and accordingly handle it.
29780 * delegate.cs (Populate): Take TypeContainer argument.
29781 Implement bits to define the Invoke method. However, I still haven't figured out
29782 how to take care of the native int bit :-(
29784 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
29785 Qualify the name of the delegate, not its return type !
29787 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
29790 (StandardConversionExists): Checking for array types turns out to be recursive.
29792 (ConvertReferenceExplicit): Implement array conversion.
29794 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
29796 2001-10-12 Ravi Pratap <ravi@ximian.com>
29798 * cs-parser.jay (delegate_declaration): Store the fully qualified
29799 name as it is a type declaration.
29801 * delegate.cs (ReturnType, Name): Rename members to these. Make them
29804 (DefineDelegate): Renamed from Define. Does the same thing essentially,
29805 as TypeContainer::DefineType.
29807 (Populate): Method in which all the definition of the various methods (Invoke)
29810 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
29813 (CloseDelegate): Finally creates the delegate.
29815 * class.cs (TypeContainer::DefineType): Update to define delegates.
29816 (Populate, Emit and CloseType): Do the same thing here too.
29818 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
29819 delegates in all these operations.
29821 2001-10-14 Miguel de Icaza <miguel@ximian.com>
29823 * expression.cs: LocalTemporary: a new expression used to
29824 reference a temporary that has been created.
29826 * assign.cs: Handle PropertyAccess back here, so that we can
29827 provide the proper semantic access to properties.
29829 * expression.cs (Expression::ConvertReferenceExplicit): Implement
29830 a few more explicit conversions.
29832 * modifiers.cs: `NEW' modifier maps to HideBySig.
29834 * expression.cs (PropertyExpr): Make this into an
29835 ExpressionStatement, and support the EmitStatement code path.
29837 Perform get/set error checking, clean up the interface.
29839 * assign.cs: recognize PropertyExprs as targets, and if so, turn
29840 them into toplevel access objects.
29842 2001-10-12 Miguel de Icaza <miguel@ximian.com>
29844 * expression.cs: PropertyExpr::PropertyExpr: use work around the
29847 * typemanager.cs: Keep track here of our PropertyBuilders again to
29848 work around lameness in SRE.
29850 2001-10-11 Miguel de Icaza <miguel@ximian.com>
29852 * expression.cs (LValue::LValueResolve): New method in the
29853 interface, used to perform a second resolution pass for LValues.
29855 (This::DoResolve): Catch the use of this in static methods.
29857 (This::LValueResolve): Implement.
29859 (This::Store): Remove warning, assigning to `this' in structures
29862 (Invocation::Emit): Deal with invocation of
29863 methods on value types. We need to pass the address to structure
29864 methods rather than the object itself. (The equivalent code to
29865 emit "this" for structures leaves the entire structure on the
29866 stack instead of a pointer to it).
29868 (ParameterReference::DoResolve): Compute the real index for the
29869 argument based on whether the method takes or not a `this' pointer
29870 (ie, the method is static).
29872 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
29873 value types returned from functions when we need to invoke a
29874 method on the sturcture.
29877 2001-10-11 Ravi Pratap <ravi@ximian.com>
29879 * class.cs (TypeContainer::DefineType): Method to actually do the business of
29880 defining the type in the Modulebuilder or Typebuilder. This is to take
29881 care of nested types which need to be defined on the TypeBuilder using
29882 DefineNestedMethod.
29884 (TypeContainer::GetClassBases): Implement. Essentially the code from the
29885 methods in RootContext, only ported to be part of TypeContainer.
29887 (TypeContainer::GetInterfaceOrClass): Ditto.
29889 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
29891 * interface.cs (Interface::DefineInterface): New method. Does exactly
29892 what RootContext.CreateInterface did earlier, only it takes care of nested types
29895 (Interface::GetInterfaces): Move from RootContext here and port.
29897 (Interface::GetInterfaceByName): Same here.
29899 * rootcontext.cs (ResolveTree): Re-write.
29901 (PopulateTypes): Re-write.
29903 * class.cs (TypeContainer::Populate): Populate nested types too.
29904 (TypeContainer::Emit): Emit nested members too.
29906 * typemanager.cs (AddUserType): Do not make use of the FullName property,
29907 instead just use the name argument passed in as it is already fully
29910 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
29911 to TypeContainer mapping to see if a type is user-defined.
29913 * class.cs (TypeContainer::CloseType): Implement.
29915 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
29916 the default constructor.
29918 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
29921 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
29923 * interface.cs (CloseType): Create the type here.
29925 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
29928 Remove all the methods which are now in TypeContainer.
29930 2001-10-10 Ravi Pratap <ravi@ximian.com>
29932 * delegate.cs (Define): Re-write bits to define the delegate
29935 2001-10-10 Miguel de Icaza <miguel@ximian.com>
29937 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
29939 * expression.cs (ImplicitReferenceConversion): handle null as well
29940 as a source to convert to any reference type.
29942 * statement.cs (Return): Perform any implicit conversions to
29943 expected return type.
29945 Validate use of return statement.
29947 * codegen.cs (EmitContext): Pass the expected return type here.
29949 * class.cs (Method, Constructor, Property): Pass expected return
29950 type to EmitContext.
29952 2001-10-09 Miguel de Icaza <miguel@ximian.com>
29954 * expression.cs: Make DoResolve take an EmitContext instead of a
29957 Replaced `l' and `location' for `loc', for consistency.
29959 (Error, Warning): Remove unneeded Tc argument.
29961 * assign.cs, literal.cs, constant.cs: Update to new calling
29964 * codegen.cs: EmitContext now contains a flag indicating whether
29965 code is being generated in a static method or not.
29967 * cs-parser.jay: DecomposeQI, new function that replaces the old
29968 QualifiedIdentifier. Now we always decompose the assembled
29969 strings from qualified_identifier productions into a group of
29972 2001-10-08 Miguel de Icaza <miguel@ximian.com>
29974 * rootcontext.cs: Deal with field-less struct types correctly now
29975 by passing the size option to Define Type.
29977 * class.cs: Removed hack that created one static field.
29979 2001-10-07 Miguel de Icaza <miguel@ximian.com>
29981 * statement.cs: Moved most of the code generation here.
29983 2001-10-09 Ravi Pratap <ravi@ximian.com>
29985 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
29988 (ElementAccess): Remove useless bits for now - keep checks as the spec
29991 2001-10-08 Ravi Pratap <ravi@ximian.com>
29993 * expression.cs (ElementAccess::DoResolve): Remove my crap code
29994 and start performing checks according to the spec.
29996 2001-10-07 Ravi Pratap <ravi@ximian.com>
29998 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
29999 rank_specifiers instead.
30001 (rank_specifiers): Change the order in which the rank specifiers are stored
30003 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
30005 * expression.cs (ElementAccess): Implement the LValue interface too.
30007 2001-10-06 Ravi Pratap <ravi@ximian.com>
30009 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
30010 except that user defined conversions are not included.
30012 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
30013 perform the conversion of the return type, if necessary.
30015 (New::DoResolve): Check whether we are creating an array or an object
30016 and accordingly do the needful.
30018 (New::Emit): Same here.
30020 (New::DoResolve): Implement guts of array creation.
30022 (New::FormLookupType): Helper function.
30024 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30026 * codegen.cs: Removed most of the code generation here, and move the
30027 corresponding code generation bits to the statement classes.
30029 Added support for try/catch/finalize and throw.
30031 * cs-parser.jay: Added support for try/catch/finalize.
30033 * class.cs: Catch static methods having the flags override,
30034 virtual or abstract.
30036 * expression.cs (UserCast): This user cast was not really doing
30037 what it was supposed to do. Which is to be born in fully resolved
30038 state. Parts of the resolution were being performed at Emit time!
30042 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30044 * expression.cs: Implicity convert the result from UserCast.
30046 2001-10-05 Ravi Pratap <ravi@ximian.com>
30048 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
30049 prevented it from working correctly.
30051 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
30052 merely ConvertImplicit.
30054 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30056 * typemanager.cs: Make the LookupTypeContainer function static,
30057 and not per-instance.
30059 * class.cs: Make static FindMembers (the one that takes a Type
30062 * codegen.cs: Add EmitForeach here.
30064 * cs-parser.jay: Make foreach a toplevel object instead of the
30065 inline expansion, as we need to perform semantic analysis on it.
30067 2001-10-05 Ravi Pratap <ravi@ximian.com>
30069 * expression.cs (Expression::ImplicitUserConversion): Rename to
30070 UserDefinedConversion.
30072 (Expression::UserDefinedConversion): Take an extra argument specifying
30073 whether we look for explicit user conversions too.
30075 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
30077 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
30079 (ExplicitUserConversion): Make it a call to UserDefinedConversion
30080 with the appropriate arguments.
30082 * cs-parser.jay (cast_expression): Record location too.
30084 * expression.cs (Cast): Record location info.
30086 (Expression::ConvertExplicit): Take location argument.
30088 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
30089 to determine if we are doing explicit conversions.
30091 (UserCast::Emit): Update accordingly.
30093 (Expression::ConvertExplicit): Report an error if everything fails.
30095 * ../errors/cs0030.cs : Add.
30097 2001-10-04 Miguel de Icaza <miguel@ximian.com>
30099 * modifiers.cs: If the ABSTRACT keyword is present, also set the
30100 virtual and newslot bits.
30102 * class.cs (TypeContainer::RegisterRequiredImplementations):
30103 Record methods we need.
30105 (TypeContainer::MakeKey): Helper function to make keys for
30106 MethodBases, since the Methodbase key is useless.
30108 (TypeContainer::Populate): Call RegisterRequiredImplementations
30109 before defining the methods.
30111 Create a mapping for method_builders_to_methods ahead of time
30112 instead of inside a tight loop.
30114 (::RequireMethods): Accept an object as the data to set into the
30115 hashtable so we can report interface vs abstract method mismatch.
30117 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30119 * report.cs: Make all of it static.
30121 * rootcontext.cs: Drop object_type and value_type computations, as
30122 we have those in the TypeManager anyways.
30124 Drop report instance variable too, now it is a global.
30126 * driver.cs: Use try/catch on command line handling.
30128 Add --probe option to debug the error reporting system with a test
30131 * report.cs: Add support for exiting program when a probe
30132 condition is reached.
30134 2001-10-03 Ravi Pratap <ravi@ximian.com>
30136 * expression.cs (Binary::DoNumericPromotions): Fix the case when
30137 we do a forcible conversion regardless of type, to check if
30138 ForceConversion returns a null.
30140 (Binary::error19): Use location to report error.
30142 (Unary::error23): Use location here too.
30144 * ../errors/cs0019.cs : Check in.
30146 * ../errors/cs0023.cs : Check in.
30148 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
30149 case of a non-null MethodInfo object with a length of 0 !
30151 (Binary::ResolveOperator): Flag error if overload resolution fails to find
30152 an applicable member - according to the spec :-)
30153 Also fix logic to find members in base types.
30155 (Unary::ResolveOperator): Same here.
30157 (Unary::report23): Change name to error23 and make first argument a TypeContainer
30158 as I was getting thoroughly confused between this and error19 :-)
30160 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
30161 (::FindMostEncompassedType): Implement.
30162 (::FindMostEncompassingType): Implement.
30163 (::StandardConversionExists): Implement.
30165 (UserImplicitCast): Re-vamp. We now need info about most specific
30166 source and target types so that we can do the necessary conversions.
30168 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
30169 mathematical union with no duplicates.
30171 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30173 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
30174 in order from base classes to child classes, so that we can in
30175 child classes look up in our parent for method names and
30176 attributes (required for handling abstract, virtual, new, override
30177 constructs: we need to instrospect our base class, and if we dont
30178 populate the classes in order, the introspection might be
30179 incorrect. For example, a method could query its parent before
30180 the parent has any methods and would determine that the parent has
30181 no abstract methods (while it could have had them)).
30183 (RootContext::CreateType): Record the order in which we define the
30186 2001-10-02 Miguel de Icaza <miguel@ximian.com>
30188 * class.cs (TypeContainer::Populate): Also method definitions can
30189 fail now, keep track of this.
30191 (TypeContainer::FindMembers): Implement support for
30192 DeclaredOnly/noDeclaredOnly flag.
30194 (Constructor::Emit) Return the ConstructorBuilder.
30196 (Method::Emit) Return the MethodBuilder.
30197 Check for abstract or virtual methods to be public.
30199 * rootcontext.cs (RootContext::CreateType): Register all the
30200 abstract methods required for the class to be complete and the
30201 interface methods that must be implemented.
30203 * cs-parser.jay: Report error 501 (method requires body if it is
30204 not marked abstract or extern).
30206 * expression.cs (TypeOf::Emit): Implement.
30208 * typemanager.cs: runtime_handle_type, new global type.
30210 * class.cs (Property::Emit): Generate code for properties.
30212 2001-10-02 Ravi Pratap <ravi@ximian.com>
30214 * expression.cs (Unary::ResolveOperator): Find operators on base type
30215 too - we now conform exactly to the spec.
30217 (Binary::ResolveOperator): Same here.
30219 * class.cs (Operator::Define): Fix minor quirk in the tests.
30221 * ../errors/cs0215.cs : Added.
30223 * ../errors/cs0556.cs : Added.
30225 * ../errors/cs0555.cs : Added.
30227 2001-10-01 Miguel de Icaza <miguel@ximian.com>
30229 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
30230 single integer which is really efficient
30232 2001-10-01 Ravi Pratap <ravi@ximian.com>
30234 * expression.cs (Expression::ImplicitUserConversion): Use location
30235 even in the case when we are examining True operators.
30237 * class.cs (Operator::Define): Perform extensive checks to conform
30238 with the rules for operator overloading in the spec.
30240 * expression.cs (Expression::ImplicitReferenceConversion): Implement
30241 some of the other conversions mentioned in the spec.
30243 * typemanager.cs (array_type): New static member for the System.Array built-in
30246 (cloneable_interface): For System.ICloneable interface.
30248 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
30249 we start resolving the tree and populating types.
30251 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
30253 2001-10-01 Miguel de Icaza <miguel@ximian.com>
30255 * expression.cs (Expression::ExprClassFromMemberInfo,
30256 Expression::Literalize): Create literal expressions from
30257 FieldInfos which are literals.
30259 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
30260 type casts, because they were wrong. The test suite in tests
30263 (ImplicitNumericConversion): ushort to ulong requires a widening
30266 Int32 constant to long requires widening cast as well.
30268 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
30269 for integers because the type on the stack is not i4.
30271 2001-09-30 Miguel de Icaza <miguel@ximian.com>
30273 * expression.cs (report118): require location argument.
30275 * parameter.cs: Do not dereference potential null value.
30277 * class.cs: Catch methods that lack the `new' keyword when
30278 overriding a name. Report warnings when `new' is used without
30279 anything being there to override.
30281 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
30283 * class.cs: Only add constructor to hashtable if it is non-null
30284 (as now constructors can fail on define).
30286 (TypeManager, Class, Struct): Take location arguments.
30288 Catch field instance initialization in structs as errors.
30290 accepting_filter: a new filter for FindMembers that is static so
30291 that we dont create an instance per invocation.
30293 (Constructor::Define): Catch errors where a struct constructor is
30296 * cs-parser.jay: Pass location information for various new
30299 * delegate.cs (Delegate): take a location argument.
30301 * driver.cs: Do not call EmitCode if there were problesm in the
30302 Definition of the types, as many Builders wont be there.
30304 * decl.cs (Decl::Decl): Require a location argument.
30306 * cs-tokenizer.cs: Handle properly hex constants that can not fit
30307 into integers, and find the most appropiate integer for it.
30309 * literal.cs: Implement ULongLiteral.
30311 * rootcontext.cs: Provide better information about the location of
30312 failure when CreateType fails.
30314 2001-09-29 Miguel de Icaza <miguel@ximian.com>
30316 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
30319 * expression.cs (Binary::CheckShiftArguments): Add missing type
30321 (Binary::ResolveOperator): Add type to the logical and and logical
30322 or, Bitwise And/Or and Exclusive Or code paths, it was missing
30325 (Binary::DoNumericPromotions): In the case where either argument
30326 is ulong (and most signed types combined with ulong cause an
30327 error) perform implicit integer constant conversions as well.
30329 2001-09-28 Miguel de Icaza <miguel@ximian.com>
30331 * expression.cs (UserImplicitCast): Method should always be
30333 (Invocation::BetterConversion): Simplified test for IntLiteral.
30335 (Expression::ImplicitNumericConversion): Split this routine out.
30336 Put the code that performs implicit constant integer conversions
30339 (Expression::Resolve): Become a wrapper around DoResolve so we can
30340 check eclass and type being set after resolve.
30342 (Invocation::Badness): Remove this dead function
30344 (Binary::ResolveOperator): Do not compute the expensive argumnets
30345 unless we have a union for it.
30347 (Probe::Emit): Is needs to do an isinst and then
30348 compare against null.
30350 (::CanConvert): Added Location argument. If the Location argument
30351 is null (Location.Null), then we do not report errors. This is
30352 used by the `probe' mechanism of the Explicit conversion. We do
30353 not want to generate an error for something that the user
30354 explicitly requested to be casted. But the pipeline for an
30355 explicit cast first tests for potential implicit casts.
30357 So for now, if the Location is null, it means `Probe only' to
30358 avoid adding another argument. Might have to revise this
30361 (ClassCast): New class used to type cast objects into arbitrary
30362 classes (used in Explicit Reference Conversions).
30364 Implement `as' as well.
30366 Reverted all the patches from Ravi below: they were broken:
30368 * The use of `level' as a mechanism to stop recursive
30369 invocations is wrong. That was there just to catch the
30370 bug with a strack trace but not as a way of addressing
30373 To fix the problem we have to *understand* what is going
30374 on and the interactions and come up with a plan, not
30375 just get things going.
30377 * The use of the type conversion cache that I proposed
30378 last night had an open topic: How does this work across
30379 protection domains. A user defined conversion might not
30380 be public in the location where we are applying the
30381 conversion, a different conversion might be selected
30382 (ie, private A->B (better) but public B->A (worse),
30383 inside A, A->B applies, but outside it, B->A will
30386 * On top of that (ie, even if the above is solved),
30387 conversions in a cache need to be abstract. Ie, `To
30388 convert from an Int to a Short use an OpcodeCast', not
30389 `To convert from an Int to a Short use the OpcodeCast on
30390 the variable 5' (which is what this patch was doing).
30392 2001-09-28 Ravi Pratap <ravi@ximian.com>
30394 * expression.cs (Invocation::ConversionExists): Re-write to use
30395 the conversion cache
30397 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
30398 cache all conversions done, not just user-defined ones.
30400 (Invocation::BetterConversion): The real culprit. Use ConversionExists
30401 to determine if a conversion exists instead of acutually trying to
30402 perform the conversion. It's faster too.
30404 (Expression::ConvertExplicit): Modify to use ConversionExists to check
30405 and only then attempt the implicit conversion.
30407 2001-09-28 Ravi Pratap <ravi@ximian.com>
30409 * expression.cs (ConvertImplicit): Use a cache for conversions
30410 already found. Check level of recursion and bail out if necessary.
30412 2001-09-28 Miguel de Icaza <miguel@ximian.com>
30414 * typemanager.cs (string_concat_string_string, string_concat_object_object):
30415 Export standard methods that we expect for string operations.
30417 * statement.cs (Block::UsageWarning): Track usage of variables and
30418 report the errors for not used variables.
30420 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
30423 2001-09-27 Miguel de Icaza <miguel@ximian.com>
30425 * codegen.cs: remove unnneded code
30427 * expression.cs: Removed BuiltinTypeAccess class
30429 Fix the order in which implicit conversions are
30432 The previous fixed dropped support for boxed conversions (adding a
30433 test to the test suite now)
30435 (UserImplicitCast::CanConvert): Remove test for source being null,
30436 that code is broken. We should not feed a null to begin with, if
30437 we do, then we should track the bug where the problem originates
30438 and not try to cover it up here.
30440 Return a resolved expression of type UserImplicitCast on success
30441 rather than true/false. Ravi: this is what I was talking about,
30442 the pattern is to use a static method as a "constructor" for
30445 Also, do not create arguments until the very last minute,
30446 otherwise we always create the arguments even for lookups that
30447 will never be performed.
30449 (UserImplicitCast::Resolve): Eliminate, objects of type
30450 UserImplicitCast are born in a fully resolved state.
30452 * typemanager.cs (InitCoreTypes): Init also value_type
30453 (System.ValueType).
30455 * expression.cs (Cast::Resolve): First resolve the child expression.
30457 (LValue): Add new method AddressOf to be used by
30460 Change the argument of Store to take an EmitContext instead of an
30461 ILGenerator, because things like FieldExpr need to be able to call
30462 their children expression to generate the instance code.
30464 (Expression::Error, Expression::Warning): Sugar functions for
30467 (Expression::MemberLookup): Accept a TypeContainer instead of a
30468 Report as the first argument.
30470 (Expression::ResolvePrimary): Killed. I still want to improve
30471 this as currently the code is just not right.
30473 (Expression::ResolveMemberAccess): Simplify, but it is still
30476 (Unary::Resolve): Catch errors in AddressOf operators.
30478 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
30479 index to a byte for the short-version, or the compiler will choose
30480 the wrong Emit call, which generates the wrong data.
30482 (ParameterReference::Emit, ::Store): same.
30484 (FieldExpr::AddressOf): Implement.
30486 * typemanager.cs: TypeManager: made public variable instead of
30489 * driver.cs: document --fatal.
30491 * report.cs (ErrorMessage, WarningMessage): new names for the old
30492 Error and Warning classes.
30494 * cs-parser.jay (member_access): Turn built-in access to types
30495 into a normal simplename
30497 2001-09-27 Ravi Pratap <ravi@ximian.com>
30499 * expression.cs (Invocation::BetterConversion): Fix to cope
30500 with q being null, since this was introducing a bug.
30502 * expression.cs (ConvertImplicit): Do built-in conversions first.
30504 2001-09-27 Ravi Pratap <ravi@ximian.com>
30506 * expression.cs (UserImplicitCast::Resolve): Fix bug.
30508 2001-09-27 Ravi Pratap <ravi@ximian.com>
30510 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
30511 I had introduced long ago (what's new ?).
30513 * expression.cs (UserImplicitCast::CanConvert): Static method to do
30514 the work of all the checking.
30515 (ConvertImplicit): Call CanConvert and only then create object if necessary.
30516 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
30518 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
30519 that is the right way.
30521 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
30522 overloading resolution. Use everywhere instead of cutting and pasting code.
30524 (Binary::ResolveOperator): Use MakeUnionSet.
30526 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
30527 we have to convert to bool types. Not complete yet.
30529 2001-09-27 Miguel de Icaza <miguel@ximian.com>
30531 * typemanager.cs (TypeManager::CSharpName): support ushort.
30533 * expression.cs (Expression::TryImplicitIntConversion): Attempts
30534 to provide an expression that performsn an implicit constant int
30535 conversion (section 6.1.6).
30536 (Expression::ConvertImplicitRequired): Reworked to include
30537 implicit constant expression conversions.
30539 (Expression::ConvertNumericExplicit): Finished.
30541 (Invocation::Emit): If InstanceExpression is null, then it means
30542 that we perform a call on this.
30544 2001-09-26 Miguel de Icaza <miguel@ximian.com>
30546 * expression.cs (Unary::Emit): Remove some dead code.
30547 (Probe): Implement Resolve and Emit for `is'.
30548 (Expression::ConvertImplicitRequired): Attempt to do constant
30549 expression conversions here. Maybe should be moved to
30550 ConvertImplicit, but I am not sure.
30551 (Expression::ImplicitLongConstantConversionPossible,
30552 Expression::ImplicitIntConstantConversionPossible): New functions
30553 that tell whether is it possible to apply an implicit constant
30554 expression conversion.
30556 (ConvertNumericExplicit): Started work on explicit numeric
30559 * cs-parser.jay: Update operator constants.
30561 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
30562 (Parameters::GetSignature): Hook up VerifyArgs here.
30563 (Parameters::VerifyArgs): Verifies that no two arguments have the
30566 * class.cs (Operator): Update the operator names to reflect the
30567 ones that the spec expects (as we are just stringizing the
30570 * expression.cs (Unary::ResolveOperator): Fix bug: Use
30571 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
30572 previous usage did only work for our methods.
30573 (Expression::ConvertImplicit): Handle decimal implicit numeric
30574 conversions as well.
30575 (Expression::InternalTypeConstructor): Used to invoke constructors
30576 on internal types for default promotions.
30578 (Unary::Emit): Implement special handling for the pre/post
30579 increment/decrement for overloaded operators, as they need to have
30580 the same semantics as the other operators.
30582 (Binary::ResolveOperator): ditto.
30583 (Invocation::ConversionExists): ditto.
30584 (UserImplicitCast::Resolve): ditto.
30586 2001-09-26 Ravi Pratap <ravi@ximian.com>
30588 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
30589 operator, return after emitting body. Regression tests pass again !
30591 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
30592 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
30593 (Invocation::OverloadResolve): Ditto.
30594 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
30596 * everywhere : update calls to the above methods accordingly.
30598 2001-09-26 Miguel de Icaza <miguel@ximian.com>
30600 * assign.cs (Assign): Make it inherit from ExpressionStatement.
30602 * expression.cs (ExpressionStatement): New base class used for
30603 expressions that can appear in statements, so that we can provide
30604 an alternate path to generate expression that do not leave a value
30607 (Expression::Emit, and all the derivatives): We no longer return
30608 whether a value is left on the stack or not. Every expression
30609 after being emitted leaves a single value on the stack.
30611 * codegen.cs (EmitContext::EmitStatementExpression): Use the
30612 facilties of ExpressionStatement if possible.
30614 * cs-parser.jay: Update statement_expression.
30616 2001-09-25 Miguel de Icaza <miguel@ximian.com>
30618 * driver.cs: Change the wording of message
30620 2001-09-25 Ravi Pratap <ravi@ximian.com>
30622 * expression.cs (Binary::ResolveOperator): Had forgottten to set
30623 the type of the expression to the return type of the method if
30624 we have an overloaded operator match ! The regression tests pass again !
30625 (Unary::ResolveOperator): Ditto.
30627 * expression.cs (Invocation::ConversionExists): Correct the member lookup
30628 to find "op_Implicit", not "implicit" ;-)
30629 (UserImplicitCast): New class to take care of user-defined implicit conversions.
30630 (ConvertImplicit, ForceConversion): Take TypeContainer argument
30632 * everywhere : Correct calls to the above accordingly.
30634 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
30635 (ConvertImplicit): Do user-defined conversion if it exists.
30637 2001-09-24 Miguel de Icaza <miguel@ximian.com>
30639 * assign.cs: track location.
30640 (Resolve): Use implicit conversions on assignment.
30642 * literal.cs: Oops. Not good, Emit of short access values should
30643 pass (Bytes) or the wrong argument will be selected.
30645 * expression.cs (Unary::Emit): Emit code for -expr.
30647 (Unary::ResolveOperator): Handle `Substract' for non-constants
30648 (substract from zero from the non-constants).
30649 Deal with Doubles as well.
30651 (Expression::ConvertImplicitRequired): New routine that reports an
30652 error if no implicit conversion exists.
30654 (Invocation::OverloadResolve): Store the converted implicit
30655 expressions if we make them
30657 2001-09-24 Ravi Pratap <ravi@ximian.com>
30659 * class.cs (ConstructorInitializer): Take a Location argument.
30660 (ConstructorBaseInitializer): Same here.
30661 (ConstructorThisInitializer): Same here.
30663 * cs-parser.jay : Update all calls accordingly.
30665 * expression.cs (Unary, Binary, New): Take location argument.
30666 Update accordingly everywhere.
30668 * cs-parser.jay : Update all calls to the above to take a location
30671 * class.cs : Ditto.
30673 2001-09-24 Ravi Pratap <ravi@ximian.com>
30675 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
30676 (Invocation::BetterConversion): Same here
30677 (Invocation::ConversionExists): Ditto.
30679 (Invocation::ConversionExists): Implement.
30681 2001-09-22 Ravi Pratap <ravi@ximian.com>
30683 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
30684 Also take an additional TypeContainer argument.
30686 * All over : Pass in TypeContainer as argument to OverloadResolve.
30688 * typemanager.cs (CSharpName): Update to check for the string type and return
30691 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
30694 2001-09-21 Ravi Pratap <ravi@ximian.com>
30696 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
30697 (Invocation::BetterFunction): Implement.
30698 (Invocation::BetterConversion): Implement.
30699 (Invocation::ConversionExists): Skeleton, no implementation yet.
30701 Okay, things work fine !
30703 2001-09-21 Miguel de Icaza <miguel@ximian.com>
30705 * typemanager.cs: declare and load enum_type, delegate_type and
30708 * expression.cs (Expression::Emit): Now emit returns a value that
30709 tells whether a value is left on the stack or not. This strategy
30710 might be reveted tomorrow with a mechanism that would address
30711 multiple assignments.
30712 (Expression::report118): Utility routine to report mismatches on
30715 (Unary::Report23): Report impossible type/operator combination
30718 (Unary::IsIncrementableNumber): Whether the type can be
30719 incremented or decremented with add.
30720 (Unary::ResolveOperator): Also allow enumerations to be bitwise
30722 (Unary::ResolveOperator): Implement ++, !, ~,
30724 (Invocation::Emit): Deal with new Emit convetion.
30726 * All Expression derivatives: Updated their Emit method to return
30727 whether they leave values on the stack or not.
30729 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
30730 stack for expressions that are statements.
30732 2001-09-20 Miguel de Icaza <miguel@ximian.com>
30734 * expression.cs (LValue): New interface. Must be implemented by
30736 (LocalVariableReference, ParameterReference, FieldExpr): Implement
30739 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
30740 interface for generating code, simplifies the code.
30742 2001-09-20 Ravi Pratap <ravi@ximian.com>
30744 * expression.cs (everywhere): Comment out return statements in ::Resolve
30745 methods to avoid the warnings.
30747 2001-09-20 Miguel de Icaza <miguel@ximian.com>
30749 * driver.cs (parse): Report error 2001 if we can not open the
30752 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
30755 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
30758 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
30759 otherwise nested blocks end up with the same index.
30761 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
30763 * expression.cs: Instead of having FIXMEs in the Resolve
30764 functions, throw exceptions so it is obvious that we are facing a
30767 * cs-parser.jay (invocation_expression): Pass Location information.
30769 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
30770 Use a basename for those routines because .NET does not like paths
30773 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
30776 2001-09-19 Miguel de Icaza <miguel@ximian.com>
30778 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
30779 are loading the correct data types (throws an exception if not).
30780 (TypeManager::InitCoreTypes): Use CoreLookupType
30782 * expression.cs (Unary::ResolveOperator): return the child
30783 expression for expressions which are just +expr.
30784 (Unary::ResolveOperator): Return negative literals for -LITERAL
30785 expressions (otherwise they are Unary {Literal}).
30786 (Invocation::Badness): Take into account `Implicit constant
30787 expression conversions'.
30789 * literal.cs (LongLiteral): Implement long literal class.
30790 (IntLiteral): export the `Value' of the intliteral.
30792 2001-09-19 Ravi Pratap <ravi@ximian.com>
30794 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
30796 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
30797 instead of 'Operator'
30799 * expression.cs (Binary::ResolveOperator): Update accordingly.
30800 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
30803 * cs-parser.jay (unary_expression): Update to use the new names.
30805 * gen-treedump.cs (GetUnary): Same here.
30807 * expression.cs (Unary::Resolve): Implement.
30808 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
30809 operators are found instead of making noise ;-)
30810 (Unary::ResolveOperator): New method to do precisely the same thing which
30811 Binary::ResolveOperator does for Binary expressions.
30812 (Unary.method, .Arguments): Add.
30813 (Unary::OperName): Implement.
30814 (Unary::ForceConversion): Copy and Paste !
30816 * class.cs (Operator::Define): Fix a small bug for the case when we have
30819 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
30820 for the inbuilt operators. Only overloading works for now ;-)
30822 2001-09-18 Miguel de Icaza <miguel@ximian.com>
30824 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
30825 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
30827 * expression.cs (This::Emit): Implement.
30828 (This::Resolve): Implement.
30829 (TypeOf:Resolve): Implement.
30830 (Expression::ResolveSimpleName): Add an implicit this to instance
30832 (MemberAccess::Resolve): Deal with Parameters and Fields.
30833 Bind instance variable to Field expressions.
30834 (FieldExpr::Instance): New field used to track the expression that
30835 represents the object instance.
30836 (FieldExpr::Resolve): Track potential errors from MemberLookup not
30838 (FieldExpr::Emit): Implement.
30840 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
30841 the last instruction contains a return opcode to avoid generating
30842 the last `ret' instruction (this generates correct code, and it is
30843 nice to pass the peverify output).
30845 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
30846 initializer for static and instance variables.
30847 (Constructor::Emit): Allow initializer to be null in the case of
30848 static constructors. Only emit initializer for instance
30851 (TypeContainer::FindMembers): Return a null array if there are no
30854 Also fix the code for the MemberTypes.Method branch, as it was not
30855 scanning that for operators (or tried to access null variables before).
30857 * assign.cs (Assign::Emit): Handle instance and static fields.
30861 * driver.cs: Stop compilation if there are parse errors.
30863 * cs-parser.jay (constructor_declaration): Provide default base
30864 initializer for non-static constructors.
30865 (constructor_declarator): Do not provide a default base
30866 initializers if none was specified.
30867 Catch the fact that constructors should not have parameters.
30869 * class.cs: Do not emit parent class initializers for static
30870 constructors, that should be flagged as an error.
30872 2001-09-18 Ravi Pratap <ravi@ximian.com>
30874 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
30875 Move back code into TypeContainer::Populate.
30877 2001-09-18 Ravi Pratap <ravi@ximian.com>
30879 * class.cs (TypeContainer::AddConstructor): Fix the check to
30880 compare against Name, not Basename.
30881 (Operator::OpType): Change Plus and Minus to Add and Subtract.
30883 * cs-parser.jay : Update accordingly.
30885 * class.cs (TypeContainer::FindMembers): For the case where we are searching
30886 for methods, don't forget to look into the operators too.
30887 (RegisterMethodBuilder): Helper method to take care of this for
30888 methods, constructors and operators.
30889 (Operator::Define): Completely revamp.
30890 (Operator.OperatorMethod, MethodName): New fields.
30891 (TypeContainer::Populate): Move the registering of builders into
30892 RegisterMethodBuilder.
30893 (Operator::Emit): Re-write.
30895 * expression.cs (Binary::Emit): Comment out code path to emit method
30896 invocation stuff for the case when we have a user defined operator. I am
30897 just not able to get it right !
30899 2001-09-17 Miguel de Icaza <miguel@ximian.com>
30901 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
30904 (Expression::MemberLookup): Provide a version that allows to
30905 specify the MemberTypes and BindingFlags.
30907 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
30908 so it was not fetching variable information from outer blocks.
30910 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
30911 Beforefieldinit as it was buggy.
30913 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
30914 that Ravi put here.
30916 * class.cs (Constructor::Emit): Only emit if block is not null.
30917 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
30918 deal with this by semantically definining it as if the user had
30921 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
30922 constructors as we now "emit" them at a higher level.
30924 (TypeContainer::DefineDefaultConstructor): Used to define the
30925 default constructors if none was provided.
30927 (ConstructorInitializer): Add methods Resolve and Emit.
30929 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
30931 2001-09-17 Ravi Pratap <ravi@ximian.com>
30933 * class.cs (TypeContainer::EmitDefaultConstructor): Register
30934 the default constructor builder with our hashtable for methodbuilders
30937 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
30938 and argument_count is 0 in which case we have a match.
30939 (Binary::ResolveOperator): More null checking and miscellaneous coding
30942 2001-09-17 Ravi Pratap <ravi@ximian.com>
30944 * rootcontext.cs (IsNameSpace): Compare against null.
30946 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
30948 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
30949 and Unary::Operator.
30951 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
30954 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
30955 we have overloaded operators.
30956 (Binary::ResolveOperator): Implement the part which does the operator overload
30959 * class.cs (Operator::Emit): Implement.
30960 (TypeContainer::Emit): Emit the operators we have too.
30962 * expression.cs (Binary::Emit): Update to emit the appropriate code for
30963 the case when we have a user-defined operator.
30965 2001-09-17 Miguel de Icaza <miguel@ximian.com>
30967 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
30969 2001-09-16 Ravi Pratap <ravi@ximian.com>
30971 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
30972 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
30973 (Constructor::Emit): Implement.
30974 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
30975 if we have no work to do.
30976 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
30979 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
30980 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
30982 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
30985 2001-09-15 Ravi Pratap <ravi@ximian.com>
30987 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
30989 (Tree::RecordNamespace): Method to do what the name says ;-)
30990 (Tree::Namespaces): Property to get at the namespaces hashtable.
30992 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
30995 * rootcontext.cs (IsNamespace): Fixed it :-)
30997 2001-09-14 Miguel de Icaza <miguel@ximian.com>
30999 * class.cs (TypeContainer::FindMembers): Add support for
31001 (MethodCore): New class that encapsulates both the shared aspects
31002 of a Constructor and a Method.
31003 (Method, Constructor): Factored pieces into MethodCore.
31005 * driver.cs: Added --fatal which makes errors throw exceptions.
31006 Load System assembly as well as part of the standard library.
31008 * report.cs: Allow throwing exceptions on errors for debugging.
31010 * modifiers.cs: Do not use `parent', instead use the real type
31011 container to evaluate permission settings.
31013 * class.cs: Put Ravi's patch back in. He is right, and we will
31014 have to cope with the
31016 2001-09-14 Ravi Pratap <ravi@ximian.com>
31018 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
31019 FamORAssem, not FamANDAssem.
31021 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31023 * driver.cs: Added --parse option that only parses its input files
31026 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
31027 incorrect. IsTopLevel is not used to tell whether an object is
31028 root_types or not (that can be achieved by testing this ==
31029 root_types). But to see if this is a top-level *class* (not
31030 necessarly our "toplevel" container).
31032 2001-09-14 Ravi Pratap <ravi@ximian.com>
31034 * enum.cs (Enum::Define): Modify to call the Lookup method on the
31035 parent instead of a direct call to GetType.
31037 2001-09-14 Ravi Pratap <ravi@ximian.com>
31039 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
31040 Modifiers.TypeAttr. This should just be a call to that method.
31042 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
31043 object so that we can determine if we are top-level or not.
31045 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
31048 * enum.cs (Enum::Define): Ditto.
31050 * modifiers.cs (FieldAttr): Re-write.
31052 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
31053 (TypeContainer::HaveStaticConstructor): New property to provide access
31054 to precisely that info.
31056 * modifiers.cs (MethodAttr): Re-write.
31057 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
31059 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
31060 of top-level types as claimed.
31062 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31064 * expression.cs (MemberLookup): Fruitless attempt to lookup
31065 constructors. Maybe I need to emit default constructors? That
31066 might be it (currently .NET emits this for me automatically).
31067 (Invocation::OverloadResolve): Cope with Arguments == null.
31068 (Invocation::EmitArguments): new function, shared by the new
31069 constructor and us.
31070 (Invocation::Emit): Handle static and instance methods. Emit
31071 proper call instruction for virtual or non-virtual invocations.
31072 (New::Emit): Implement.
31073 (New::Resolve): Implement.
31074 (MemberAccess:Resolve): Implement.
31075 (MethodGroupExpr::InstanceExpression): used conforming to the spec
31076 to track instances.
31077 (FieldExpr::Resolve): Set type.
31079 * support.cs: Handle empty arguments.
31081 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
31082 SimpleLookup): Auxiliary routines to help parse a qualifier
31085 Update qualifier_identifier rule.
31087 * codegen.cs: Removed debugging messages.
31089 * class.cs: Make this a global thing, this acts just as a "key" to
31090 objects that we might have around.
31092 (Populate): Only initialize method_builders_to_methods once.
31094 * expression.cs (PropertyExpr): Initialize type from the
31097 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
31098 Resolve pattern. Attempt to implicitly convert value to boolean.
31101 * expression.cs: Set the type for the int32/int32 argument case.
31102 (Binary::ResolveOperator): Set the return type to boolean for
31103 comparission operators
31105 * typemanager.cs: Remove debugging print code.
31107 (Invocation::Resolve): resolve type.
31109 * class.cs: Allocate a MemberInfo of the correct size, as the code
31110 elsewhere depends on the test to reflect the correct contents.
31112 (Method::) Keep track of parameters, due to System.Reflection holes
31114 (TypeContainer::Populate): Keep track of MethodBuilders to Method
31117 (TypeContainer::FindMembers): Use ArrayList and then copy an array
31118 of the exact size and return that.
31120 (Class::LookupMethodByBuilder): New function that maps
31121 MethodBuilders to its methods. Required to locate the information
31122 on methods because System.Reflection bit us again.
31124 * support.cs: New file, contains an interface ParameterData and
31125 two implementations: ReflectionParameters and InternalParameters
31126 used to access Parameter information. We will need to grow this
31129 * expression.cs (Invocation::GetParameterData): implement a cache
31130 and a wrapper around the ParameterData creation for methods.
31131 (Invocation::OverloadResolve): Use new code.
31133 2001-09-13 Ravi Pratap <ravi@ximian.com>
31135 * class.cs (TypeContainer::EmitField): Remove and move into
31136 (Field::Define): here and modify accordingly.
31137 (Field.FieldBuilder): New member.
31138 (TypeContainer::Populate): Update accordingly.
31139 (TypeContainer::FindMembers): Implement.
31141 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31143 * statement.cs: (VariableInfo::VariableType): New field to be
31144 initialized with the full type once it is resolved.
31146 2001-09-12 Miguel de Icaza <miguel@ximian.com>
31148 * parameter.cs (GetParameterInfo): Use a type cache to compute
31149 things only once, and to reuse this information
31151 * expression.cs (LocalVariableReference::Emit): Implement.
31152 (OpcodeCast::Emit): fix.
31154 (ParameterReference::Resolve): Implement.
31155 (ParameterReference::Emit): Implement.
31157 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
31158 that are expressions need to stay as Expressions.
31160 * typemanager.cs (CSharpName): Returns the C# name of a type if
31163 * expression.cs (Expression::ConvertImplicit): New function that
31164 implements implicit type conversions.
31166 (Expression::ImplicitReferenceConversion): Implements implicit
31167 reference conversions.
31169 (EmptyCast): New type for transparent casts.
31171 (OpcodeCast): New type for casts of types that are performed with
31172 a sequence of bytecodes.
31174 (BoxedCast): New type used for casting value types into reference
31175 types. Emits a box opcode.
31177 (Binary::DoNumericPromotions): Implements numeric promotions of
31178 and computation of the Binary::Type.
31180 (Binary::EmitBranchable): Optimization.
31182 (Binary::Emit): Implement code emission for expressions.
31184 * typemanager.cs (TypeManager): Added two new core types: sbyte
31187 2001-09-12 Ravi Pratap <ravi@ximian.com>
31189 * class.cs (TypeContainer::FindMembers): Method which does exactly
31190 what Type.FindMembers does, only we don't have to use reflection. No
31191 implementation yet.
31193 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
31194 typecontainer objects as we need to get at them.
31195 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
31197 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
31198 typecontainer object.
31200 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
31201 of just a Report object.
31203 2001-09-11 Ravi Pratap <ravi@ximian.com>
31205 * class.cs (Event::Define): Go back to using the prefixes "add_" and
31207 (TypeContainer::Populate): Now define the delegates of the type too.
31208 (TypeContainer.Delegates): Property to access the list of delegates defined
31211 * delegates.cs (Delegate::Define): Implement partially.
31213 * modifiers.cs (TypeAttr): Handle more flags.
31215 2001-09-11 Ravi Pratap <ravi@ximian.com>
31217 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
31219 (Operator::Define): Re-write logic to get types by using the LookupType method
31220 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
31221 (Indexer::Define): Ditto.
31222 (Event::Define): Ditto.
31223 (Property::Define): Ditto.
31225 2001-09-10 Ravi Pratap <ravi@ximian.com>
31227 * class.cs (TypeContainer::Populate): Now define operators too.
31228 (TypeContainer.Operators): New property to access the list of operators
31230 (Operator.OperatorMethodBuilder): New member to hold the method builder
31231 for the operator we are defining.
31232 (Operator::Define): Implement.
31234 2001-09-10 Ravi Pratap <ravi@ximian.com>
31236 * class.cs (Event::Define): Make the prefixes of the accessor methods
31237 addOn_ and removeOn_
31239 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
31240 of the location being passed in too. Ideally, this should go later since all
31241 error reporting should be done through the Report object.
31243 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
31244 (Populate): Iterate thru the indexers we have and define them too.
31245 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
31246 for the get and set accessors.
31247 (Indexer::Define): Implement.
31249 2001-09-09 Miguel de Icaza <miguel@ximian.com>
31251 * expression.cs (Binary::Resolve): Beginning of it. I scratched
31252 my previous implementation, did not work.
31254 * typemanager.cs: Add a couple of missing types (the longs).
31256 * literal.cs: Use TypeManager.bool_type instead of getting it.
31258 * expression.cs (EventExpr): New kind of expressions.
31259 (Expressio::ExprClassFromMemberInfo): finish
31261 2001-09-08 Miguel de Icaza <miguel@ximian.com>
31263 * assign.cs: Emit stores to static fields differently.
31265 2001-09-08 Ravi Pratap <ravi@ximian.com>
31267 * Merge in changes and adjust code to tackle conflicts. Backed out my
31268 code in Assign::Resolve ;-)
31270 2001-09-08 Ravi Pratap <ravi@ximian.com>
31272 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
31273 instead Report.Error and also pass in the location.
31274 (CSharpParser::Lexer): New readonly property to return the reference
31275 to the Tokenizer object.
31276 (declare_local_variables): Use Report.Error with location instead of plain
31280 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
31281 (Operator.CheckBinaryOperator): Ditto.
31283 * cs-parser.jay (operator_declarator): Update accordingly.
31285 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
31286 (CheckBinaryOperator): Same here.
31288 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
31289 on the name without any prefixes of namespace names etc. This is because we
31290 already might have something already fully qualified like
31291 'System.Console.WriteLine'
31293 * assign.cs (Resolve): Begin implementation. Stuck ;-)
31295 2001-09-07 Ravi Pratap <ravi@ximian.com>
31297 * cs-tokenizer.cs (location): Return a string which also contains
31300 * expression.cs (ElementAccess): New class for expressions of the
31301 type 'element access.'
31302 (BaseAccess): New class for expressions of the type 'base access.'
31303 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
31306 * cs-parser.jay (element_access): Implement action.
31307 (base_access): Implement actions.
31308 (checked_expression, unchecked_expression): Implement.
31310 * cs-parser.jay (local_variable_type): Correct and implement.
31311 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
31313 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
31315 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
31316 name and the specifiers.
31318 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
31320 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
31321 making them all public ;-)
31323 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
31326 2001-09-07 Miguel de Icaza <miguel@ximian.com>
31328 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
31330 (FieldExpr, PropertyExprs): New resolved expressions.
31331 (SimpleName::MemberStaticCheck): Perform static checks for access
31332 to non-static fields on static methods. Maybe this should be
31333 generalized for MemberAccesses.
31334 (SimpleName::ResolveSimpleName): More work on simple name
31337 * cs-parser.jay (primary_expression/qualified_identifier): track
31338 the parameter index.
31340 * codegen.cs (CodeGen::Save): Catch save exception, report error.
31341 (EmitContext::EmitBoolExpression): Chain to expression generation
31342 instead of temporary hack.
31343 (::EmitStatementExpression): Put generic expression code generation.
31345 * assign.cs (Assign::Emit): Implement variable assignments to
31346 local variables, parameters and fields.
31348 2001-09-06 Miguel de Icaza <miguel@ximian.com>
31350 * statement.cs (Block::GetVariableInfo): New method, returns the
31351 VariableInfo for a variable name in a block.
31352 (Block::GetVariableType): Implement in terms of GetVariableInfo
31354 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
31355 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
31357 2001-09-06 Ravi Pratap <ravi@ximian.com>
31359 * cs-parser.jay (operator_declaration): Continue on my quest : update
31360 to take attributes argument.
31361 (event_declaration): Ditto.
31362 (enum_declaration): Ditto.
31363 (indexer_declaration): Ditto.
31365 * class.cs (Operator::Operator): Update constructor accordingly.
31366 (Event::Event): Ditto.
31368 * delegate.cs (Delegate::Delegate): Same here.
31370 * enum.cs (Enum::Enum): Same here.
31372 2001-09-05 Ravi Pratap <ravi@ximian.com>
31374 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
31376 * ../tests/cs0658.cs : New file to demonstrate error 0658.
31378 * attribute.cs (Attributes): New class to encapsulate all attributes which were
31379 being passed around as an arraylist.
31380 (Attributes::AddAttribute): Method to add attribute sections.
31382 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
31383 (struct_declaration): Update accordingly.
31384 (constant_declaration): Update.
31385 (field_declaration): Update.
31386 (method_header): Update.
31387 (fixed_parameter): Update.
31388 (parameter_array): Ditto.
31389 (property_declaration): Ditto.
31390 (destructor_declaration): Ditto.
31392 * class.cs (Struct::Struct): Update constructors accordingly.
31393 (Class::Class): Ditto.
31394 (Field::Field): Ditto.
31395 (Method::Method): Ditto.
31396 (Property::Property): Ditto.
31397 (TypeContainer::OptAttribute): update property's return type.
31399 * interface.cs (Interface.opt_attributes): New member.
31400 (Interface::Interface): Update to take the extra Attributes argument.
31402 * parameter.cs (Parameter::Parameter): Ditto.
31404 * constant.cs (Constant::Constant): Ditto.
31406 * interface.cs (InterfaceMemberBase): New OptAttributes field.
31407 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
31408 the attributes as a parameter.
31409 (InterfaceProperty): Update constructor call.
31410 (InterfaceEvent): Ditto.
31411 (InterfaceMethod): Ditto.
31412 (InterfaceIndexer): Ditto.
31414 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
31415 pass the attributes too.
31416 (interface_event_declaration): Ditto.
31417 (interface_property_declaration): Ditto.
31418 (interface_method_declaration): Ditto.
31419 (interface_declaration): Ditto.
31421 2001-09-05 Miguel de Icaza <miguel@ximian.com>
31423 * class.cs (Method::Define): Track the "static Main" definition to
31424 create an entry point.
31426 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
31427 EntryPoint if we find it.
31429 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
31430 (EmitContext::ig): Make this variable public.
31432 * driver.cs: Make the default output file be the first file name
31433 with the .exe extension.
31435 Detect empty compilations
31437 Handle various kinds of output targets. Handle --target and
31438 rename -t to --dumper.
31440 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
31441 methods inherited from Expression return now an Expression. This
31442 will is used during the tree rewriting as we resolve them during
31445 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
31446 the spec. Missing entirely is the information about
31447 accessability of elements of it.
31449 (Expression::ExprClassFromMemberInfo): New constructor for
31450 Expressions that creates a fully initialized Expression based on
31451 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
31454 (Invocation::Resolve): Begin implementing resolution of invocations.
31456 * literal.cs (StringLiteral): Implement Emit.
31458 2001-09-05 Ravi Pratap <ravi@ximian.com>
31460 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
31463 2001-09-04 Ravi Pratap <ravi@ximian.com>
31465 * cs-parser.jay (attribute_arguments): Implement actions.
31466 (attribute): Fix bug in production. Implement action.
31467 (attribute_list): Implement.
31468 (attribute_target): Implement.
31469 (attribute_target_specifier, opt_target_specifier): Implement
31470 (CheckAttributeTarget): New method to check if the attribute target
31472 (attribute_section): Implement.
31473 (opt_attributes): Implement.
31475 * attribute.cs : New file to handle attributes.
31476 (Attribute): Class to hold attribute info.
31478 * cs-parser.jay (opt_attribute_target_specifier): Remove production
31479 (attribute_section): Modify production to use 2 different rules to
31480 achieve the same thing. 1 s/r conflict down !
31481 Clean out commented, useless, non-reducing dimension_separator rules.
31483 * class.cs (TypeContainer.attributes): New member to hold list
31484 of attributes for a type.
31485 (Struct::Struct): Modify to take one more argument, the attribute list.
31486 (Class::Class): Ditto.
31487 (Field::Field): Ditto.
31488 (Method::Method): Ditto.
31489 (Property::Property): Ditto.
31491 * cs-parser.jay (struct_declaration): Update constructor call to
31492 pass in the attributes too.
31493 (class_declaration): Ditto.
31494 (constant_declaration): Ditto.
31495 (field_declaration): Ditto.
31496 (method_header): Ditto.
31497 (fixed_parameter): Ditto.
31498 (parameter_array): Ditto.
31499 (property_declaration): Ditto.
31501 * constant.cs (Constant::Constant): Update constructor similarly.
31502 Use System.Collections.
31504 * parameter.cs (Parameter::Parameter): Update as above.
31506 2001-09-02 Ravi Pratap <ravi@ximian.com>
31508 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
31509 (TypeContainer.delegates): New member to hold list of delegates.
31511 * cs-parser.jay (delegate_declaration): Implement the action correctly
31512 this time as I seem to be on crack ;-)
31514 2001-09-02 Miguel de Icaza <miguel@ximian.com>
31516 * rootcontext.cs (RootContext::IsNamespace): new function, used to
31517 tell whether an identifier represents a namespace.
31519 * expression.cs (NamespaceExpr): A namespace expression, used only
31520 temporarly during expression resolution.
31521 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
31522 utility functions to resolve names on expressions.
31524 2001-09-01 Miguel de Icaza <miguel@ximian.com>
31526 * codegen.cs: Add hook for StatementExpressions.
31528 * class.cs: Fix inverted test for static flag in methods.
31530 2001-09-02 Ravi Pratap <ravi@ximian.com>
31532 * class.cs (Operator::CheckUnaryOperator): Correct error number used
31533 to make it coincide with MS' number.
31534 (Operator::CheckBinaryOperator): Ditto.
31536 * ../errors/errors.txt : Remove error numbers added earlier.
31538 * ../errors/cs1019.cs : Test case for error # 1019
31540 * ../errros/cs1020.cs : Test case for error # 1020
31542 * cs-parser.jay : Clean out commented cruft.
31543 (dimension_separators, dimension_separator): Comment out. Ostensibly not
31544 used anywhere - non-reducing rule.
31545 (namespace_declarations): Non-reducing rule - comment out.
31547 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
31548 with TypeContainer::AddEnum.
31550 * delegate.cs : New file for delegate handling classes.
31551 (Delegate): Class for declaring delegates.
31553 * makefile : Update.
31555 * cs-parser.jay (delegate_declaration): Implement.
31557 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
31559 * class.cs (Event::Define): Implement.
31560 (Event.EventBuilder): New member.
31562 * class.cs (TypeContainer::Populate): Update to define all enums and events
31564 (Events): New property for the events arraylist we hold. Shouldn't we move to using
31565 readonly fields for all these cases ?
31567 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
31569 * class.cs (Property): Revamp to use the convention of making fields readonly.
31570 Accordingly modify code elsewhere.
31572 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
31573 the Define method of the Property class.
31575 * class.cs : Clean up applied patch and update references to variables etc. Fix
31577 (TypeContainer::Populate): Update to define all the properties we have. Also
31578 define all enumerations.
31580 * enum.cs (Define): Implement.
31582 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
31584 * cs-parser.jay (overloadable_operator): The semantic value is an
31585 enum of the Operator class.
31586 (operator_declarator): Implement actions.
31587 (operator_declaration): Implement.
31589 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
31590 validity of definitions.
31591 (Operator::CheckBinaryOperator): Static method to check for binary operators
31592 (TypeContainer::AddOperator): New method to add an operator to a type.
31594 * cs-parser.jay (indexer_declaration): Added line to actually call the
31595 AddIndexer method so it gets added ;-)
31597 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
31598 already taken care of by the MS compiler ?
31600 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
31602 * class.cs (Operator): New class for operator declarations.
31603 (Operator::OpType): Enum for the various operators.
31605 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
31607 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
31608 ostensibly handle this in semantic analysis.
31610 * cs-parser.jay (general_catch_clause): Comment out
31611 (specific_catch_clauses, specific_catch_clause): Ditto.
31612 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
31613 (catch_args, opt_catch_args): New productions.
31614 (catch_clause): Rewrite to use the new productions above
31615 (catch_clauses): Modify accordingly.
31616 (opt_catch_clauses): New production to use in try_statement
31617 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
31618 and re-write the code in the actions to extract the specific and
31619 general catch clauses by being a little smart ;-)
31621 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
31622 Hooray, try and catch statements parse fine !
31624 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
31626 * statement.cs (Block::GetVariableType): Fix logic to extract the type
31627 string from the hashtable of variables.
31629 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
31630 I end up making that mistake ;-)
31631 (catch_clauses): Fixed gross error which made Key and Value of the
31632 DictionaryEntry the same : $1 !!
31634 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
31636 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
31638 * cs-parser.jay (event_declaration): Correct to remove the semicolon
31639 when the add and remove accessors are specified.
31641 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
31643 * cs-parser.jay (IndexerDeclaration): New helper class to hold
31644 information about indexer_declarator.
31645 (indexer_declarator): Implement actions.
31646 (parsing_indexer): New local boolean used to keep track of whether
31647 we are parsing indexers or properties. This is necessary because
31648 implicit_parameters come into picture even for the get accessor in the
31649 case of an indexer.
31650 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
31652 * class.cs (Indexer): New class for indexer declarations.
31653 (TypeContainer::AddIndexer): New method to add an indexer to a type.
31654 (TypeContainer::indexers): New member to hold list of indexers for the
31657 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
31659 * cs-parser.jay (add_accessor_declaration): Implement action.
31660 (remove_accessor_declaration): Implement action.
31661 (event_accessors_declaration): Implement
31662 (variable_declarators): swap statements for first rule - trivial.
31664 * class.cs (Event): New class to hold information about event
31666 (TypeContainer::AddEvent): New method to add an event to a type
31667 (TypeContainer::events): New member to hold list of events.
31669 * cs-parser.jay (event_declaration): Implement actions.
31671 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
31673 * cs-parser.jay (dim_separators): Implement. Make it a string
31674 concatenating all the commas together, just as they appear.
31675 (opt_dim_separators): Modify accordingly
31676 (rank_specifiers): Update accordingly. Basically do the same
31677 thing - instead, collect the brackets here.
31678 (opt_rank_sepcifiers): Modify accordingly.
31679 (array_type): Modify to actually return the complete type string
31680 instead of ignoring the rank_specifiers.
31681 (expression_list): Implement to collect the expressions
31682 (variable_initializer): Implement. We make it a list of expressions
31683 essentially so that we can handle the array_initializer case neatly too.
31684 (variable_initializer_list): Implement.
31685 (array_initializer): Make it a list of variable_initializers
31686 (opt_array_initializer): Modify accordingly.
31688 * expression.cs (New::NType): Add enumeration to help us
31689 keep track of whether we have an object/delegate creation
31690 or an array creation.
31691 (New:NewType, New::Rank, New::Indices, New::Initializers): New
31692 members to hold data about array creation.
31693 (New:New): Modify to update NewType
31694 (New:New): New Overloaded contructor for the array creation
31697 * cs-parser.jay (array_creation_expression): Implement to call
31698 the overloaded New constructor.
31700 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
31702 * class.cs (TypeContainer::Constructors): Return member
31703 constructors instead of returning null.
31705 2001-08-26 Miguel de Icaza <miguel@ximian.com>
31707 * typemanager.cs (InitCoreTypes): Initialize the various core
31708 types after we have populated the type manager with the user
31709 defined types (this distinction will be important later while
31710 compiling corlib.dll)
31712 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
31713 on Expression Classification. Now all expressions have a method
31714 `Resolve' and a method `Emit'.
31716 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
31717 generation from working. Also add some temporary debugging
31720 2001-08-24 Miguel de Icaza <miguel@ximian.com>
31722 * codegen.cs: Lots of code generation pieces. This is only the
31723 beginning, will continue tomorrow with more touches of polish. We
31724 handle the fundamentals of if, while, do, for, return. Others are
31725 trickier and I need to start working on invocations soon.
31727 * gen-treedump.cs: Bug fix, use s.Increment here instead of
31730 * codegen.cs (EmitContext): New struct, used during code
31731 emission to keep a context. Most of the code generation will be
31734 * cs-parser.jay: Add embedded blocks to the list of statements of
31735 this block. So code generation proceeds in a top down fashion.
31737 2001-08-23 Miguel de Icaza <miguel@ximian.com>
31739 * statement.cs: Add support for multiple child blocks.
31741 2001-08-22 Miguel de Icaza <miguel@ximian.com>
31743 * codegen.cs (EmitCode): New function, will emit the code for a
31744 Block of code given a TypeContainer and its ILGenerator.
31746 * statement.cs (Block): Standard public readonly optimization.
31747 (Block::Block constructors): Link children.
31748 (Block::Child): Child Linker.
31749 (Block::EmitVariables): Emits IL variable declarations.
31751 * class.cs: Drop support for MethodGroups here, delay until
31753 (Method::): Applied the same simplification that I did before, and
31754 move from Properties to public readonly fields.
31755 (Method::ParameterTypes): Returns the parameter types for the
31756 function, and implements a cache that will be useful later when I
31757 do error checking and the semantic analysis on the methods is
31759 (Constructor::GetCallingConvention): Renamed from CallingConvetion
31760 and made a method, optional argument tells whether this is a class
31761 or a structure to apply the `has-this' bit.
31762 (Method::GetCallingConvention): Implement, returns the calling
31764 (Method::Define): Defines the type, a second pass is performed
31765 later to populate the methods.
31767 (Constructor::ParameterTypes): implement a cache similar to the
31768 one on Method::ParameterTypes, useful later when we do semantic
31771 (TypeContainer::EmitMethod): New method. Emits methods.
31773 * expression.cs: Removed MethodGroup class from here.
31775 * parameter.cs (Parameters::GetCallingConvention): new method.
31777 2001-08-21 Miguel de Icaza <miguel@ximian.com>
31779 * class.cs (TypeContainer::Populate): Drop RootContext from the
31782 (Constructor::CallingConvention): Returns the calling convention.
31783 (Constructor::ParameterTypes): Returns the constructor parameter
31786 (TypeContainer::AddConstructor): Keep track of default constructor
31787 and the default static constructor.
31789 (Constructor::) Another class that starts using `public readonly'
31790 instead of properties.
31792 (Constructor::IsDefault): Whether this is a default constructor.
31794 (Field::) use readonly public fields instead of properties also.
31796 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
31797 track of static constructors; If none is used, turn on
31798 BeforeFieldInit in the TypeAttributes.
31800 * cs-parser.jay (opt_argument_list): now the return can be null
31801 for the cases where there are no arguments.
31803 (constructor_declarator): If there is no implicit `base' or
31804 `this', then invoke the default parent constructor.
31806 * modifiers.cs (MethodAttr): New static function maps a set of
31807 modifiers flags into a MethodAttributes enum
31808 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
31809 MethodAttr, TypeAttr to represent the various mappings where the
31810 modifiers are used.
31811 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
31813 2001-08-19 Miguel de Icaza <miguel@ximian.com>
31815 * parameter.cs (GetParameterInfo): Fix bug where there would be no
31818 * interface.cs (PopulateIndexer): Implemented the code generator
31819 for interface indexers.
31821 2001-08-17 Miguel de Icaza <miguel@ximian.com>
31823 * interface.cs (InterfaceMemberBase): Now we track the new status
31826 (PopulateProperty): Implement property population. Woohoo! Got
31827 Methods and Properties going today.
31829 Removed all the properties for interfaces, and replaced them with
31830 `public readonly' fields.
31832 2001-08-16 Miguel de Icaza <miguel@ximian.com>
31834 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
31835 initialize their hashtables/arraylists only when they are needed
31836 instead of doing this always.
31838 * parameter.cs: Handle refs and out parameters.
31840 * cs-parser.jay: Use an ArrayList to construct the arguments
31841 instead of the ParameterCollection, and then cast that to a
31844 * parameter.cs: Drop the use of ParameterCollection and use
31845 instead arrays of Parameters.
31847 (GetParameterInfo): Use the Type, not the Name when resolving
31850 2001-08-13 Miguel de Icaza <miguel@ximian.com>
31852 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
31853 and instead use public readonly fields.
31855 * class.cs: Put back walking code for type containers.
31857 2001-08-11 Miguel de Icaza <miguel@ximian.com>
31859 * class.cs (MakeConstant): Code to define constants.
31861 * rootcontext.cs (LookupType): New function. Used to locate types
31864 2001-08-08 Miguel de Icaza <miguel@ximian.com>
31866 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
31867 this System.Reflection code is. Kudos to Microsoft
31869 * typemanager.cs: Implement a type cache and avoid loading all
31870 types at boot time. Wrap in LookupType the internals. This made
31871 the compiler so much faster. Wow. I rule!
31873 * driver.cs: Make sure we always load mscorlib first (for
31874 debugging purposes, nothing really important).
31876 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
31877 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
31879 * rootcontext.cs: Lookup types on their namespace; Lookup types
31880 on namespaces that have been imported using the `using' keyword.
31882 * class.cs (TypeContainer::TypeAttr): Virtualize.
31883 (Class::TypeAttr): Return attributes suitable for this bad boy.
31884 (Struct::TypeAttr): ditto.
31885 Handle nested classes.
31886 (TypeContainer::) Remove all the type visiting code, it is now
31887 replaced with the rootcontext.cs code
31889 * rootcontext.cs (GetClassBases): Added support for structs.
31891 2001-08-06 Miguel de Icaza <miguel@ximian.com>
31893 * interface.cs, statement.cs, class.cs, parameter.cs,
31894 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
31895 Drop use of TypeRefs, and use strings instead.
31897 2001-08-04 Miguel de Icaza <miguel@ximian.com>
31901 * class.cs (Struct::Struct): set the SEALED flags after
31902 checking the modifiers.
31903 (TypeContainer::TypeAttr): new property, returns the
31904 TypeAttributes for a class.
31906 * cs-parser.jay (type_list): Oops, list production was creating a
31907 new list of base types.
31909 * rootcontext.cs (StdLib): New property.
31910 (GetInterfaceTypeByName): returns an interface by type name, and
31911 encapsulates error handling here.
31912 (GetInterfaces): simplified.
31913 (ResolveTree): Encapsulated all the tree resolution here.
31914 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
31917 * driver.cs: Add support for --nostdlib, to avoid loading the
31918 default assemblies.
31919 (Main): Do not put tree resolution here.
31921 * rootcontext.cs: Beginning of the class resolution.
31923 2001-08-03 Miguel de Icaza <miguel@ximian.com>
31925 * rootcontext.cs: Provide better error reporting.
31927 * cs-parser.jay (interface_base): set our $$ to be interfaces.
31929 * rootcontext.cs (CreateInterface): Handle the case where there
31930 are no parent interfaces.
31932 (CloseTypes): Routine to flush types at the end.
31933 (CreateInterface): Track types.
31934 (GetInterfaces): Returns an array of Types from the list of
31935 defined interfaces.
31937 * typemanager.c (AddUserType): Mechanism to track user types (puts
31938 the type on the global type hash, and allows us to close it at the
31941 2001-08-02 Miguel de Icaza <miguel@ximian.com>
31943 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
31944 RecordInterface instead.
31946 * cs-parser.jay: Updated to reflect changes above.
31948 * decl.cs (Definition): Keep track of the TypeBuilder type that
31949 represents this type here. Not sure we will use it in the long
31950 run, but wont hurt for now.
31952 * driver.cs: Smaller changes to accomodate the new code.
31954 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
31957 * rootcontext.cs (CreateInterface): New method, used to create
31958 the System.TypeBuilder type for interfaces.
31959 (ResolveInterfaces): new entry point to resolve the interface
31961 (CodeGen): Property, used to keep track of the code generator.
31963 2001-07-26 Miguel de Icaza <miguel@ximian.com>
31965 * cs-parser.jay: Add a second production for delegate_declaration
31968 (enum_body): Put an opt_comma here instead of putting it on
31969 enum_body or enum_member_declarations so we can handle trailing
31970 commas on enumeration members. Gets rid of a shift/reduce.
31972 (type_list): Need a COMMA in the middle.
31974 (indexer_declaration): Tell tokenizer to recognize get/set
31976 * Remove old targets.
31978 * Re-add the parser target.
31980 2001-07-13 Simon Cozens <simon@simon-cozens.org>
31982 * cs-parser.jay: Add precendence rules for a number of operators
31983 ot reduce the number of shift/reduce conflicts in the grammar.
31985 2001-07-17 Miguel de Icaza <miguel@ximian.com>
31987 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
31990 Get rid of old crufty code.
31992 * rootcontext.cs: Use this to keep track of the parsed
31993 representation and the defined types available to the program.
31995 * gen-treedump.cs: adjust for new convention.
31997 * type.cs: Split out the type manager, and the assembly builder
32000 * typemanager.cs: the type manager will live here now.
32002 * cil-codegen.cs: And the code generator here.
32004 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
32006 * makefile: Fixed up for easy making.
32008 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32010 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
32013 (unary_expression): Expand pre_increment_expression and
32014 post_decrement_expression to reduce a shift/reduce.
32016 2001-07-11 Simon Cozens
32018 * cs-tokenizer.cs: Hex numbers should begin with a 0.
32020 Improve allow_keyword_as_indent name.
32022 2001-06-19 Miguel de Icaza <miguel@ximian.com>
32024 * Adjustments for Beta2.
32026 2001-06-13 Miguel de Icaza <miguel@ximian.com>
32028 * decl.cs: Added `Define' abstract method.
32029 (InTransit): new property, used to catch recursive definitions.
32031 * interface.cs: Implement `Define'.
32033 * modifiers.cs: Map Modifiers.constants to
32034 System.Reflection.TypeAttribute flags.
32036 * class.cs: Keep track of types and user-defined types.
32037 (BuilderInit): New method for creating an assembly
32038 (ResolveType): New function to launch the resolution process, only
32039 used by interfaces for now.
32041 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
32042 that are inserted into the name space.
32044 2001-06-08 Miguel de Icaza <miguel@ximian.com>
32046 * ARGH. I have screwed up my tree so many times due to the use of
32047 rsync rather than using CVS. Going to fix this at once.
32049 * driver.cs: Objetify driver. Load assemblies, use assemblies to
32052 2001-06-07 Miguel de Icaza <miguel@ximian.com>
32054 * Experiment successful: Use System.Type rather that our own
32057 2001-05-25 Miguel de Icaza <miguel@ximian.com>
32059 * cs-parser.jay: Removed nsAliases from here.
32061 Use new namespaces, handle `using XXX;'
32063 * namespace.cs: Reimplemented namespace handling, use a recursive
32064 definition of the class. Now we can keep track of using clauses
32065 and catch invalid using clauses.
32067 2001-05-24 Miguel de Icaza <miguel@ximian.com>
32069 * gen-treedump.cs: Adapted for all the renaming.
32071 * expression.cs (Expression): this class now has a Type property
32072 which returns an expression Type.
32074 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
32075 `Type', as this has a different meaning now in the base
32077 2001-05-22 Miguel de Icaza <miguel@ximian.com>
32079 * interface.cs, class.cs: Removed from all the sources the
32080 references to signature computation, as we can not do method
32081 signature computation during the parsing time, as we are not
32082 trying to solve at that point distinguishing:
32086 void a (NS.Blah x) {}
32089 Which depending on the context might be valid or not, as we do not
32090 know if Blah is the same thing as NS.Blah at that point.
32092 * Redid everything so the code uses TypeRefs now instead of
32093 Types. TypeRefs are just temporary type placeholders, that need
32094 to be resolved. They initially have a pointer to a string and the
32095 current scope in which they are used. This is used later by the
32096 compiler to resolve the reference to an actual Type.
32098 * DeclSpace is no longer a CIR.Type, and neither are
32099 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
32100 are all DeclSpaces, but no Types.
32102 * type.cs (TypeRefManager): This implements the TypeRef manager,
32103 which keeps track of all the types that need to be resolved after
32104 the parsing has finished.
32106 2001-05-13 Miguel de Icaza <miguel@ximian.com>
32108 * ARGH. We are going to have to store `foreach' as a class rather
32109 than resolving it, as we need to verify error 1579 after name
32110 resolution. *OR* we could keep a flag that says `This request to
32111 IEnumerator comes from a foreach statement' which we can then use
32112 to generate the error.
32114 2001-05-10 Miguel de Icaza <miguel@ximian.com>
32116 * class.cs (TypeContainer.AddMethod): we now add methods to the
32117 MethodGroup instead of the method hashtable.
32119 * expression.cs: Add MethodGroup abstraction, which gets us one
32120 step closer to the specification in the way we handle method
32123 * cs-parser.jay (primary_expression): qualified_identifier now
32124 tried to match up an identifier to a local variable reference or
32125 to a parameter reference.
32127 current_local_parameters is now a parser global variable that
32128 points to the current parameters for the block, used during name
32131 (property_declaration): Now creates an implicit `value' argument to
32134 2001-05-09 Miguel de Icaza <miguel@ximian.com>
32136 * parameter.cs: Do not use `param' arguments as part of the
32137 signature, per the spec.
32139 2001-05-08 Miguel de Icaza <miguel@ximian.com>
32141 * decl.cs: Base class for classes, structs and interfaces. This
32142 is the "Declaration Space"
32144 * cs-parser.jay: Use CheckDef for checking declaration errors
32145 instead of having one on each function.
32147 * class.cs: Factor out some code for handling error handling in
32148 accordance to the "Declarations" section in the "Basic Concepts"
32149 chapter in the ECMA C# spec.
32151 * interface.cs: Make all interface member classes derive from
32152 InterfaceMemberBase.
32154 2001-05-07 Miguel de Icaza <miguel@ximian.com>
32156 * Many things: all interfaces are parsed and generated in
32157 gen-treedump. Support for member variables, constructors,
32158 destructors, properties, constants is there.
32160 Beginning of the IL backend, but very little done, just there for
32163 2001-04-29 Miguel de Icaza <miguel@ximian.com>
32165 * cs-parser.jay: Fix labeled statement.
32167 * cs-tokenizer.cs (escape): Escape " and ' always.
32168 ref_line, ref_name: keep track of the line/filename as instructed
32169 by #line by the compiler.
32172 2001-04-27 Miguel de Icaza <miguel@ximian.com>
32174 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
32175 to match the values in System.CodeDOM.
32177 Divid renamed to Divide.
32179 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
32181 (Statements.set): remove.
32183 * System.CodeDOM/CodeCatchClause.cs: always have a valid
32186 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
32187 falseStatements always have valid values.
32189 * cs-parser.jay: Use System.CodeDOM now.