1 2009-08-03 Marek Safar <marek.safar@gmail.com>
3 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
6 * rootcontext.cs: Default to langversion v4.
8 2009-08-03 Marek Safar <marek.safar@gmail.com>
10 * pending.cs: Check return type before member info is set.
12 2009-08-03 Marek Safar <marek.safar@gmail.com>
14 * anonymous.cs: Fully initialize generic hoisted field expression.
16 2009-08-02 Miguel de Icaza <miguel@novell.com>
18 * cs-parser.jay: Flag variables declared on the interactive shell
19 as used to prevent the 168 warning about local variable not being
22 2009-07-31 Marek Safar <marek.safar@gmail.com>
24 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
25 attribute.cs: Emit dynamic export attribute.
27 2009-07-30 Marek Safar <marek.safar@gmail.com>
29 * expression.cs: More verifier work.
31 2009-07-29 Marek Safar <marek.safar@gmail.com>
33 * nullable.cs: Fixed SRE crash during corlib compilation.
35 2009-07-29 Marek Safar <marek.safar@gmail.com>
37 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
38 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
39 More TypeManager.TypeToCoreType needed.
41 2009-07-29 Marek Safar <marek.safar@gmail.com>
43 * anonymous.cs: Update after recent SRE fixes.
45 2009-07-28 Marek Safar <marek.safar@gmail.com>
47 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
48 version of GetFieldHandle for fields of generic types.
50 2009-07-27 Marek Safar <marek.safar@gmail.com>
52 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
53 ecore.cs: Add TypeManager.IsDynamicType,
54 PredefinedAttributes.Dynamic.
56 2009-07-27 Marek Safar <marek.safar@gmail.com>
59 * expression.cs: Fixed object and reference type parameter
62 2009-07-27 Marek Safar <marek.safar@gmail.com>
65 * class.cs: Attach partial method attributes to method
68 2009-07-24 Marek Safar <marek.safar@gmail.com>
70 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
73 2009-07-24 Marek Safar <marek.safar@gmail.com>
75 * anonymous.cs (MutateField): Add imported types handling.
77 2009-07-23 Marek Safar <marek.safar@gmail.com>
79 * expression.cs, delegate.cs: Moved arguments resolve into their
80 counterparts expressions. Removed argument resolve from
81 CollectionElementInitializer.
83 2009-07-23 Marek Safar <marek.safar@gmail.com>
86 * convert.cs, delegate.cs: Use common overload mechanism for method
87 group conversion check.
89 2009-07-22 Marek Safar <marek.safar@gmail.com>
92 * generics.cs: Exact type inference with other bound types.
94 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
96 Don't complain when the same type is implemented by the output
97 assembly as well as multiple referenced assemblies
98 * namespace.cs (RootNamespace.LookupTypeReflection): Add
99 'must_be_unique' flag.
100 (GlobalRootNamespace): Update to changes.
101 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
102 already have a type in hand.
104 2009-07-22 Marek Safar <marek.safar@gmail.com>
106 * expression.cs: More verifier instrumentation.
108 * statement.cs: Do proper throw expression conversion.
110 2009-07-22 Marek Safar <marek.safar@gmail.com>
112 A fix for bug #522789
113 * expression.cs: Mutate invocation return type.
115 2009-07-16 Marek Safar <marek.safar@gmail.com>
117 * anonymous.cs: Split assignable and readonly generated variable
120 2009-07-16 Marek Safar <marek.safar@gmail.com>
122 A fix for bug #521671
123 * statement.cs: Fixed crash when checking missing type.
125 2009-07-16 Marek Safar <marek.safar@gmail.com>
127 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
128 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
129 class.cs, driver.cs: Work on dynamic binding.
131 * dynamic.cs: New file.
133 * *.sources, *.proj: Updated.
135 2009-07-15 Marek Safar <marek.safar@gmail.com>
137 * expression.cs (Conditional): Avoid double Resolve.
139 2009-07-13 Marcus Griep <marcus@griep.us>
141 * ecore.cs: Fix obscure bug with resolving members of interfaces
142 that hide parent interface members. Fixes bug #444388 and corrects
145 2009-07-13 Marek Safar <marek.safar@gmail.com>
147 * expression.cs (LocalVariableReference): Bounce resolve.
149 2009-07-10 Marek Safar <marek.safar@gmail.com>
151 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
152 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
155 * support.cs: New dynamic type wrapper.
157 2009-07-08 Marek Safar <marek.safar@gmail.com>
159 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
160 typed local variable.
162 2009-07-06 Marek Safar <marek.safar@gmail.com>
164 A fix for bug #519005
165 * anonymous.cs: Use null_type as no return type placeholder.
167 2009-07-02 Marek Safar <marek.safar@gmail.com>
169 * generic.cs: Handle type inference of identical type parameters
170 with different bounds.
172 2009-07-01 Marek Safar <marek.safar@gmail.com>
174 * expression.cs, class.cs: Events variance.
176 * cs-parser.jay: Interface events error messages.
178 2009-07-01 Marek Safar <marek.safar@gmail.com>
180 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
182 2009-06-29 Marek Safar <marek.safar@gmail.com>
184 * parameter.cs, convert.cs, expression.cs, class.cs: Default
185 parameter expression can be value-type New.
187 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
189 2009-06-26 Marek Safar <marek.safar@gmail.com>
191 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
192 Implemented C# 4.0 named arguments.
194 2009-06-24 Marek Safar <marek.safar@gmail.com>
196 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
197 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
198 parameter modifier. Also fixes bug #515497.
200 2009-06-24 Marek Safar <marek.safar@gmail.com>
202 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
203 arguments expression to be implemented.
205 *.sources: Add argument.cs
207 2009-06-23 Marek Safar <marek.safar@gmail.com>
209 * parameter.cs: Moved GetParameterIndexByName to base class.
211 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
212 unused AType. Use argument's version of GetExpressionTree.
214 2009-06-22 Marek Safar <marek.safar@gmail.com>
216 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
219 2009-06-17 Marek Safar <marek.safar@gmail.com>
221 A fix for bug #514096
222 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
224 2009-06-17 Marek Safar <marek.safar@gmail.com>
226 * expression.cs: The first multi-dimensional array nested array
227 initializers was not checked.
229 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
231 2009-06-17 Marek Safar <marek.safar@gmail.com>
233 A fix for bug #513400
234 * nullable.cs (EmitEquality): Operands emit could be simplified for
235 built-in types when we now emit user operators differently.
237 2009-06-16 Marek Safar <marek.safar@gmail.com>
239 * ecore.cs: Report inaccessible delegate methods correctly.
241 2009-06-16 Marek Safar <marek.safar@gmail.com>
243 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
244 cs-parser.jay: Implemented C# 4.0 optional parameters.
246 2009-06-16 Marek Safar <marek.safar@gmail.com>
248 * driver.cs: Removed broken DefineManifestResource.
250 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
252 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
253 Use $(BOOTSTRAP_PROFILE) instead.
255 2009-06-12 Jb Evain <jbevain@novell.com>
257 * rootcontext.cs: add a Platform field.
258 * driver.cs: handle /platform.
259 * codegen.cs: pass the proper flags according to
260 the platform when saving the assembly.
262 2009-06-11 Marek Safar <marek.safar@gmail.com>
264 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
265 Add optional parameters grammar.
267 2009-06-10 Marek Safar <marek.safar@gmail.com>
269 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
270 driver.cs: Split lang version and metadata version.
272 2009-06-10 Marek Safar <marek.safar@gmail.com>
274 * decl.cs: Better overload ctor collision error message.
276 2009-06-05 Jb Evain <jbevain@novell.com>
278 * driver.cs (EmbededResource): avoid using an internal method
279 in gmcs to embed manifest resources.
281 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
283 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
284 the compiler from older mono versions (like moon's bots)
286 2009-06-04 Marek Safar <marek.safar@gmail.com>
288 * namespace.cs (LookupTypeReflection): Ignore collisions between
291 2009-06-04 Marek Safar <marek.safar@gmail.com>
293 * codegen.cs: Enabled generic type forwarders.
295 2009-06-04 Marek Safar <marek.safar@gmail.com>
297 * dmcs.*: Add another version of SRE compiler.
299 2009-06-03 Marek Safar <marek.safar@gmail.com>
301 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
302 generic-mcs.cs: Fixed variant type conversions.
304 2009-06-02 Marek Safar <marek.safar@gmail.com>
306 A fix for bug #507863
307 * codegen.cs: Fixes a crash on invalid string value attribute.
309 2009-06-01 Marek Safar <marek.safar@gmail.com>
311 A fix for bug #508334
312 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
313 cs-parser.jay: Fully import __arglist modifier.
315 2009-05-29 Marek Safar <marek.safar@gmail.com>
317 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
318 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
319 actually work with closed generic types.
321 2009-05-27 Alan McGovern <amcgovern@novell.com>
323 * class.cs, decl.cs, delegate.cs, parameter.cs:
324 Fix the build by replacing the use of 'var' with the actual type.
326 2009-05-27 Marek Safar <marek.safar@gmail.com>
328 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
329 cs-parser.jay, generic-mcs.cs: Report wrong variant types
332 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
335 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
336 Marek Safar <marek.safar@gmail.com>
338 A fix for bug #377509
339 * parameter.cs: Use predefined and not empty name for implicit
342 2009-05-21 Marek Safar <marek.safar@gmail.com>
344 * class.cs: Don't report wrong warnings for event fields.
346 2009-05-21 Marek Safar <marek.safar@gmail.com>
348 A fix for bug #504667
349 * class.cs: Check for static class using parent container instead of
352 2009-05-08 Marek Safar <marek.safar@gmail.com>
354 A fix for bug #496922
355 * expression.cs: Always use temporary variable when using object
358 2009-04-28 Marek Safar <marek.safar@gmail.com>
360 A fix for bug #495112
361 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
364 2009-04-27 Miguel de Icaza <miguel@novell.com>
366 * driver.cs: Add a flag to work as a replacement for CSC in VS.
368 2009-04-24 Miguel de Icaza <miguel@novell.com>
370 * complete.cs: No idea how gonzalo got a null in the list, but
373 2009-04-24 Miguel de Icaza <miguel@novell.com>
375 * complete.cs (CompletionElementInitializer): New completion class
376 to support completing inside a C# 3 element initializer, so this
377 allows completion for Silverlight situations where it is very
380 new TextBlock () { Fo<TAB>
382 (CompletionSimpleName): Expose the prefix that was
383 passed to the simple name.
385 * cs-parser.jay (object_or_collection_initializer): Add support
386 for element_initializers.
388 * expression.cs (CollectionOrObjectInitializers.DoResolve):
389 special case completion expressions as this method aggressively
390 collects data before it operates, and errors were being thrown
391 earlier than we were able to complete.
393 2009-04-23 Miguel de Icaza <miguel@novell.com>
395 * eval.cs: Make getcompletions silent and enable debugging output
396 if the -v option is passed.
398 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
399 Consider looking up the namespace that matches the prefix being
402 This is part of the support for allowing completions like:
403 `System.Co<TAB>' to complete to System.Console.
405 * complete.cs (CompletionSimpleName.AppendResults): Make this
408 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
410 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
411 COMPLETE_COMPLETION as internal.
413 2009-04-17 Miguel de Icaza <miguel@novell.com>
415 * complete.cs: Include namespace resolution in simple names as
416 well as global types and types in the using scope in the
419 * namespace.cs: Supporting infrastrcture to provide completions
420 based on the current using scope.
422 * eval.cs: Introduce an entry point that allows for initialization
423 to return a list of the files passed on the command line.
425 2009-04-14 Marek Safar <marek.safar@gmail.com>
427 A fix for bug #494243
428 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
430 2009-04-13 Marek Safar <marek.safar@gmail.com>
432 A fix for bug #493887
433 * statement.cs: Don't skip string multi-section with default or
434 null label when populating string hashtable.
436 2009-04-06 Marek Safar <marek.safar@gmail.com>
438 A fix for bug #492329
439 * expression.cs (New): Load variable when assigning type parameter
442 2009-04-06 Marek Safar <marek.safar@gmail.com>
444 A fix for bug #488960
445 * decl.cs: Compare MVAR types using non-null values.
447 2009-03-27 Marek Safar <marek.safar@gmail.com>
449 * typemanager.cs, expression.cs: Removed unused nullable checks.
451 2009-03-27 Marek Safar <marek.safar@gmail.com>
453 * *.cs: Removed some gmcs conditionals.
455 2009-03-26 Marek Safar <marek.safar@gmail.com>
457 * generic.cs, support.cs: Moved generics stuff out of support.cs
459 2009-03-24 Marek Safar <marek.safar@gmail.com>
461 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
464 2009-03-23 Marek Safar <marek.safar@gmail.com>
466 * attribute.cs: Consider all members for error reporting when
467 checking named arguments.
469 2009-03-23 Marek Safar <marek.safar@gmail.com>
471 A fix for bug #487625
472 * namespace.cs: Use a warning for all predefined type conflicts.
474 2009-03-23 Marek Safar <marek.safar@gmail.com>
476 A fix for bug #485706
477 * statement.cs: Explicitly type catch type argument to pass verifier
480 2009-03-22 Miguel de Icaza <miguel@novell.com>
482 Initial support to provide code completion facilities to consumers
483 of the evaluator API.
485 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
486 support the completion engine. When we reach the end of the
487 input stream instead of returning EOF, when this flag is true the
488 tokenizer instead produces:
490 One GENERATE_COMPLETION token: this token then must be
491 handled in the grammar at every point where the user
492 would likely request a completion.
494 As many COMPLETE_COMPLETION tokens as necessary. These
495 tokens are generated to assist the parser in unwinding and
496 producing a valid parse tree.
498 The parser rules do not have to be perfect, the parser needs to be
499 augmented with judicious use of GENERATE_COMPLETION tokens to
500 improve the areas where we can provide completion and the parser
501 needs to add support for COMPLETE_COMPLETION tokens in productions
504 It is common to not have enough support for COMPLETE_COMPLETION
505 under certain rules and that even if we generated the
506 GENERATE_COMPLETION token that the resulting tree will be invalid
507 due to the missing rules that support COMPLETE_COMPLETION.
509 The final EOF token is produced by having the parser notify the
510 tokenizer when it reaches the root production that the next token
513 * support.cs (CompletionResult): New Exception. This exception
514 is thrown to return the completion results when one of the special
515 completion expressions is reached.
517 This exception is thrown by the completing ExpressionStatements
518 classes that live in complete.cs
520 * complete.cs (CompletingExpression): a new base class for
521 completing expressions. This derives from the
522 ExpressionStatement class and not from Expression as it allows
523 completion to happen not only where expressions are expected in
524 the grammar, but also where statements are expected.
526 (CompletionSimpleName): A new class used to provide completions
527 for SimpleNames. This currently only resolves to local
528 variables from the evaluator context (GetVars call).
530 (CompletionMemberAccess): Implements support for completing member
533 * cs-parser.jay: Add support for completion in a few places.
535 * eval.cs (GetCompletions): New public API for the evaluator that
536 returns a list of possible completions given the input. The
537 return value is an array of completions
539 * anonymous.cs (Compatible): If the exception thrown from the
540 resolved expression is a CompletionResult exception let that one
541 through instead of printing a diagnostic error in the try/catch.
543 2009-03-22 Miguel de Icaza <miguel@novell.com>
547 * driver.cs (Main): Use Environment.Exit to quit quickly and
548 prevent the compiler from doing the usual wait for helper thread
551 This is to prevent a slowdown that was reported by Gonzalo on
554 2009-03-19 Marek Safar <marek.safar@gmail.com>
556 * ecore.cs: Load build-in types directly instead of accessing
559 2009-03-18 Marek Safar <marek.safar@gmail.com>
561 * ecore.cs: Always use unbox.any when available.
563 2009-03-18 Marek Safar <marek.safar@gmail.com>
565 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
567 2009-03-17 Marek Safar <marek.safar@gmail.com>
569 * generic.cs: Removed obsolete version of type inference.
571 2009-03-16 Marek Safar <marek.safar@gmail.com>
573 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
574 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
575 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
576 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
578 2009-03-11 Marek Safar <marek.safar@gmail.com>
580 A fix for bug #482996
581 * anonymous.cs: Make sure we are not infering return type when
582 checking type compatibility.
584 2009-03-11 Marek Safar <marek.safar@gmail.com>
586 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
587 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
588 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
589 attributes in their own structure. Needed when accessing their
590 properties before they are resolved.
592 2009-03-09 Marek Safar <marek.safar@gmail.com>
594 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
595 hashtable (~10x faster).
597 * driver.cs: Removed wrong Reset.
599 2009-03-08 Marek Safar <marek.safar@gmail.com>
601 * class.cs: Use correct common base type for unmanaged delayed
604 * rootcontext.cs: Wrap unhandled exception.
606 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
608 Make SeekableStreamReader self-tuning and arbitrarily seekable
609 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
611 (SeekableStreamReader.Position.set): Use it. Simplify logic
612 which, as a side-effect, makes it arbitrarily-seekable. Tune the
613 buffer size when the stream needs to be re-read from the beginning.
615 2009-03-05 Marek Safar <marek.safar@gmail.com>
617 A fix for bug #480100
618 * parameter.cs: A parameter is not hoisted when used directly as ET.
620 2009-03-04 Marek Safar <marek.safar@gmail.com>
622 * statement.cs: Fixed an issue when using variable is of interface
625 2009-03-03 Marek Safar <marek.safar@gmail.com>
627 A fix for bug #480319
628 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
630 2009-03-03 Marek Safar <marek.safar@gmail.com>
632 A fix for bug #480867
633 * typemanager.cs, expression.cs, ecore.cs: Changed method group
634 expression to have no valid type.
636 2009-03-03 Marek Safar <marek.safar@gmail.com>
638 A fix for bug #481258
639 * class.cs: Set extension method flag in partial container.
641 2009-03-03 Marek Safar <marek.safar@gmail.com>
643 * statement.cs, typemanager.cs: Use expression for StringEmitter.
645 * attribute.cs: Add sanity check.
647 2009-02-27 Marek Safar <marek.safar@gmail.com>
649 * class.cs: Add external constructor error.
651 2009-02-26 Marek Safar <marek.safar@gmail.com>
653 A fix for bug #475354
654 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
655 correctly user defined nullable equality operators.
657 2009-02-25 Marek Safar <marek.safar@gmail.com>
659 A fix for bug #479532
660 * expression.cs: Implement NewInitialize::AddressOf.
662 2009-02-25 Marek Safar <marek.safar@gmail.com>
664 A fix for bug #413633
665 * expression.cs: Iterate all base class-constraint types.
667 2009-02-24 Marek Safar <marek.safar@gmail.com>
669 A fix for bug #479209
670 * literal.cs: Mutate null underlying type.
672 2009-02-24 Marek Safar <marek.safar@gmail.com>
674 A fix for bug #476295
675 * convert.cs: Avoid wrapping implicitly convertible reference type.
677 2009-02-23 Marek Safar <marek.safar@gmail.com>
679 * iterators.cs: Create MemberName correctly.
681 2009-02-23 Marek Safar <marek.safar@gmail.com>
683 A fix for bug #478655
684 * literal.cs: Check also underlying null type conversion.
686 2009-02-21 Marek Safar <marek.safar@gmail.com>
688 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
690 2009-02-20 Marek Safar <marek.safar@gmail.com>
692 A fix for bug #477447
693 * statement.cs: Add reference to correct parent storey when this
694 is accessible from deep children storey (more than 1 level).
696 2009-02-19 Marek Safar <marek.safar@gmail.com>
698 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
699 * class.cs: Define base type members before setting up member cache.
701 2009-02-18 Marek Safar <marek.safar@gmail.com>
703 A fix for bug #477378
704 * nullable.cs, expression.cs, statement.cs: More precise null type
707 2009-02-18 Marek Safar <marek.safar@gmail.com>
709 A fix for bug #472805
710 * typemanager.cs, namespace.cs: Import only visible extension method
713 2009-02-18 Marek Safar <marek.safar@gmail.com>
715 A fix for bug #476895
716 * attribute.cs: Use correct resolve context for attribute type.
718 2009-02-18 Marek Safar <marek.safar@gmail.com>
720 A fix for bug #476266
721 * anonymous.cs: Mutate multi-dimensional arrays.
723 2009-02-18 Marek Safar <marek.safar@gmail.com>
725 A fix for bug #476400
726 * statement.cs, expression.cs: Removed wrong Dispose optimization.
728 2009-02-18 Marek Safar <marek.safar@gmail.com>
730 A fix for bug #476811
731 * generics.cs: Fixed null-literal check.
733 2009-02-17 Marek Safar <marek.safar@gmail.com>
735 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
736 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
737 messing with static variables.
739 2009-02-16 Marek Safar <marek.safar@gmail.com>
741 A fix for bug #475965
742 * generics.cs: Check generic parameter type after extracting from
745 2009-02-16 Marek Safar <marek.safar@gmail.com>
747 A fix for bug #475823
748 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
751 2009-02-14 Marek Safar <marek.safar@gmail.com>
753 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
754 Simplified event field definition using backing field and not
755 field builder directly.
757 * expression.cs (EmitLdArg): Optimize fast paths.
759 2009-02-13 Marek Safar <marek.safar@gmail.com>
761 A fix for bug #475327
762 * expression.cs (ArrayCreation): Don't mutate values optimized away.
764 2009-02-13 Marek Safar <marek.safar@gmail.com>
766 A fix for bug #475342
767 * cs-parser.jay: Using 'super' instead of 'base' to call base
768 constructor crashes compiler.
770 2009-02-13 Marek Safar <marek.safar@gmail.com>
772 A fix for bug #475354
773 * expression.cs (Constantify): Add nullable types.
775 * const.cs (EmitDecimalConstant): Avoid explicit cast.
777 2009-02-12 Marek Safar <marek.safar@gmail.com>
779 A fix for bug #475246
780 * expression.cs: More broken flowanalysis hacking needed.
782 2009-02-12 Marek Safar <marek.safar@gmail.com>
784 * attribute.cs: Compare only ref/out array modifiers.
786 2009-02-11 Marek Safar <marek.safar@gmail.com>
788 * statement.cs: Use member cache when looking for foreach members.
790 2009-02-11 Marek Safar <marek.safar@gmail.com>
792 * expression.cs: Don't expose internal initializer types.
794 * statement.cs: Check also explicit conversions for goto case.
796 2009-02-11 Marek Safar <marek.safar@gmail.com>
798 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
800 2009-02-10 Marek Safar <marek.safar@gmail.com>
802 * *.cs: Replace null-type with NullLiteral where appropriate.
804 2009-02-09 Marek Safar <marek.safar@gmail.com>
806 * expression.cs: Initializer of reference argument use temporary
807 variable to be verifiable.
809 * parameter.cs: Share EmitLdArg.
811 2009-02-09 Marek Safar <marek.safar@gmail.com>
813 A fix for bug #473559
814 * class.cs: Fixed: Not reporting error about nested class with the
817 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
819 Contributed under the MIT/X11 license.
821 * generic.cs: Added VerifyVariantTypeParameters which performs new
822 variance verification logic. The old logic, based on the spec, was
823 wrong because the spec is full of LIES!
825 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
827 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
830 * ecore.cs: Added calls to the new variance verification logic.
833 * delegate.cs: Removed calls to the old variance verification logic.
835 2009-02-06 Marek Safar <marek.safar@gmail.com>
837 * delegate.cs: Use cached Invoke method directly.
839 2009-02-06 Marek Safar <marek.safar@gmail.com>
841 * expression.cs: Emit expression tree for hoisted variable access.
843 2009-02-04 Marek Safar <marek.safar@gmail.com>
845 * namespace.cs: Add better extension class check.
847 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
849 * generic.cs: Fixed typeo (TypeParameter.Variacne).
851 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
853 This patch adds initial generic variance support to the compiler.
854 It is contributed under the MIT/X11 license.
856 * typemanager.cs: Modified ImplementsInterface to check variance.
857 Added VerifyVariantTypeParameters which checks the specified type to see
858 if it uses a variant type parameter as a type argument (which is not
859 allowed). Added IsVariantOf which determins if the first type is a
860 variant of the second. NOTE: This only supports reference types at
861 the moment to conform with the current level of VM support. When the
862 VM supports value types, this will follow step.
864 * generic.cs: Added the Variance enum. Added a Variance property to
865 TypeParameter and added variance support to definition phase. Added a
866 Variance property to TypeParameterName. Also check to make sure that
867 no variant types appear in generic method parameters.
869 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
870 keywords if the langversion supports it.
872 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
873 that variant types are only used in legal positions. Also added
874 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
877 * decl.cs: Construct TypeParameter with the variance information.
879 * convert.cs: Checks variance in ImplicitReferenceConversionExists
880 and ImplicitConversionStandard.
882 * rootcontext.cs: Added new "Future" language version.
884 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
885 type parameters are not used as type arguments in interface inheritance.
886 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
887 parameters are not used as method return types. In MemberBase.
888 ResolveMemberType, ensure that variant type parameters are not used
889 as type arguments. Also call VerifyNoVariantTypeParameters on every
890 set of parameters which are resolved.
892 * delegate.cs: Modified Delegate.Define to ensure that variant
893 parameters are not used as type arguments and that a contravariant
894 parameter is not used as the return type. Also call
895 VerifyNoVariantTypeParameters on the delegate parameters.
897 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
898 to specify generic variance.
900 * driver.cs: Added support for LanguageVersion.Future in the form of
901 "-langversion:future".
903 * generic-mcs.cs: Stubbed out new members in generic.cs.
905 2009-02-03 Marek Safar <marek.safar@gmail.com>
907 * class.cs, generic.cs: Emit type parameter constraints for nested
910 2009-02-02 Marek Safar <marek.safar@gmail.com>
912 A fix for bug #471213
913 * class.cs: Avoid emitting backing field for abstract event fields.
915 2009-02-01 Marek Safar <marek.safar@gmail.com>
917 A fix for bug #359731
918 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
921 2009-01-30 Marek Safar <marek.safar@gmail.com>
923 A fix for bug #470767
924 * statement.cs: Introduced BlockScopeExpression, needed when
925 expression tree conversion has to emit scope variables.
927 2009-01-29 Marek Safar <marek.safar@gmail.com>
929 * class.cs: Remove duplicate CallingConvention.
931 2009-01-29 Marek Safar <marek.safar@gmail.com>
933 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
934 when I finally found the right naming convention.
936 2009-01-29 Marek Safar <marek.safar@gmail.com>
938 * cs-tokenizer.cs: Put back different open parens optimization.
940 2009-01-28 Marek Safar <marek.safar@gmail.com>
942 A fix for bug #470227
943 * cs-tokenizer.cs: Remove too agressive parser optimization.
945 2009-01-28 Marek Safar <marek.safar@gmail.com>
947 A fix for bug #324319
948 * class.cs: Remove too early base type resolve.
950 2009-01-27 Marek Safar <marek.safar@gmail.com>
952 A fix for bug #324319
953 * ecore.cs: Explicitly type null when assigning to type argument to
954 make pass verifier check.
956 2009-01-27 Marek Safar <marek.safar@gmail.com>
958 * anonymous.cs: Fixed recent regression when initializing captured
961 2009-01-26 Marek Safar <marek.safar@gmail.com>
963 A fix for bug #469019
964 * anonymous.cs: Use all parent type parameters when instantiating
965 nested generic storey.
967 2009-01-26 Marek Safar <marek.safar@gmail.com>
969 * expression.cs: Check for null instance methodgroup expression.
971 2009-01-26 Marek Safar <marek.safar@gmail.com>
973 A fix for bug #469244
974 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
975 instance inside a conditional expression.
977 2009-01-23 Marek Safar <marek.safar@gmail.com>
979 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
980 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
981 GetElementType and HasElementType. IsValueType clean up.
983 2009-01-23 Marek Safar <marek.safar@gmail.com>
985 * nullable.cs: Use common EmitCall.
987 * expression.cs: Emit constraint. for virtual calls only.
989 2009-01-23 Marek Safar <marek.safar@gmail.com>
991 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
992 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
993 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
996 2009-01-22 Jb Evain <jbevain@novell.com>
998 * anonymous.cs: make anonymous types' ToString implementation
999 match what csc outputs.
1001 2009-01-21 Marek Safar <marek.safar@gmail.com>
1003 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1006 2009-01-17 Marek Safar <marek.safar@gmail.com>
1008 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1011 2009-01-16 Marek Safar <marek.safar@gmail.com>
1013 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1016 2009-01-15 Marek Safar <marek.safar@gmail.com>
1018 A fix for bug #466634
1019 * statement.cs: Add reference for nested storey when only this
1022 2009-01-15 Marek Safar <marek.safar@gmail.com>
1024 A fix for bug #466474
1025 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1028 2009-01-15 Marek Safar <marek.safar@gmail.com>
1030 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1031 Fixed nested stories parent referencing process. Also fixes #463985.
1033 2009-01-06 Marek Safar <marek.safar@gmail.com>
1035 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1036 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1037 implementation. Also fixes #463108.
1039 2009-01-05 Marek Safar <marek.safar@gmail.com>
1041 A fix for bug #416109
1042 * decl.cs: Issue correct CLSAttribute warning location.
1044 2009-01-05 Marek Safar <marek.safar@gmail.com>
1046 A fix for bug #456775
1047 * attribute.cs: Use attribute owner scope when resolving attribute
1050 2009-01-05 Marek Safar <marek.safar@gmail.com>
1052 A fix for bug #457257
1053 * decl.cs: Fixed incorrect member declaring type comparison.
1055 2009-01-05 Marek Safar <marek.safar@gmail.com>
1057 A fix for bug #460896
1058 * driver.cs: Handle /RES resources as embeddable.
1060 2009-01-05 Marek Safar <marek.safar@gmail.com>
1062 A fix for bug #462515
1063 * ecore.cs: Report inacessible members upwards.
1065 2009-01-05 Marek Safar <marek.safar@gmail.com>
1067 A fix for bug #463190, #463192
1068 * decl.cs, namespace.cs: Also import internal extension classes.
1070 2009-01-04 Marek Safar <marek.safar@gmail.com>
1072 A fix for bug #463415
1073 * generic.cs: Use right index for RemoveDependentTypes.
1075 2009-01-02 Marek Safar <marek.safar@gmail.com>
1077 A fix for bug #463196
1078 * expression.cs: Fixed enum to null comparison.
1080 2009-01-02 Marek Safar <marek.safar@gmail.com>
1082 A fix for bug #463121
1083 * nullable.cs: Fixed nullable user equality operator comparison.
1085 2009-01-02 Marek Safar <marek.safar@gmail.com>
1087 A fix for bug #462950
1088 * class.cs, decl.cs: Use full explicit name when defining automatic
1089 property backing field.
1091 2009-01-02 Marek Safar <marek.safar@gmail.com>
1093 A fix for bug #462592
1094 * pending.cs: Emit type arguments for generic proxy method.
1096 2008-12-30 Marek Safar <marek.safar@gmail.com>
1098 * expression.cs (As): Mutate all type arguments.
1100 2008-12-29 Marek Safar <marek.safar@gmail.com>
1102 A fix for bug #462622
1103 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1106 2008-12-29 Marek Safar <marek.safar@gmail.com>
1108 A fix for bug #450782
1109 * ecore.cs: Consider more variables of form V.I to be fixed.
1111 2008-12-29 Marek Safar <marek.safar@gmail.com>
1113 A fix for bug #460712
1114 * typemanager.cs: Core types could be imported.
1116 2008-12-28 Marek Safar <marek.safar@gmail.com>
1118 A fix for bugs #460847, #460772, #458049, #457339, #447807
1119 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
1120 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
1121 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
1122 user lambdas used inside query clauses.
1124 2008-12-18 Marek Safar <marek.safar@gmail.com>
1126 A fix for bug #460229
1127 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
1129 2008-12-18 Marek Safar <marek.safar@gmail.com>
1131 A fix for bug #459952
1132 * decl.cs, namespace.cs: Use common CheckAccessLevel.
1134 2008-12-18 Marek Safar <marek.safar@gmail.com>
1136 A fix for bug #459630
1137 * convert.cs: Enum to valuetype conversion is not allowed.
1139 2008-12-18 Marek Safar <marek.safar@gmail.com>
1141 A fix for bug #457087
1142 * generic.cs: Don't crash when constraint comes from type
1145 2008-12-16 Marek Safar <marek.safar@gmail.com>
1147 A fix for bug #459221
1148 * anonymous.cs, statement.cs: Delay only captured this
1151 2008-12-12 Marek Safar <marek.safar@gmail.com>
1153 A fix for bug #457489
1154 * anonymous.cs, statement.cs: Split anonymous storey instantiation
1155 and initialization to capture scope initializers correctly.
1157 2008-12-11 Marek Safar <marek.safar@gmail.com>
1159 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
1160 ParameterReference refactoring.
1162 2008-12-03 Marek Safar <marek.safar@gmail.com>
1164 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
1165 to be imported from any assembly.
1167 2008-12-03 Marek Safar <marek.safar@gmail.com>
1169 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
1170 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
1171 from anonymous method and lambda expression.
1173 2008-12-01 Marek Safar <marek.safar@gmail.com>
1175 A fix for bug #448560
1176 * expression.cs (As): Box any generic type arguments to be
1179 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1181 Add tripwire for implicit conversion bugs
1182 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
1184 (MethodGroupExpr.OverloadResolve): Add sanity check between
1185 IsApplicable and VerifyArgumentsCompat.
1186 (VerifyArgumentsCompat): Report CS1501 where appropriate.
1188 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1190 Fix build break in System.Data_test
1191 * convert.cs (ImplicitConversionExists): Move NullLiteral
1193 (ImplicitStandardConversionExists): ... here.
1195 2008-11-28 Marek Safar <marek.safar@gmail.com>
1197 * literal.cs: Emit correctly explicit null to nullable cast.
1199 2008-11-28 Marek Safar <marek.safar@gmail.com>
1201 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
1204 2008-11-28 Marek Safar <marek.safar@gmail.com>
1206 A fix for bug #449005
1207 * convert.cs, nullable.cs: Use only one implicit nullable
1210 2008-11-27 Marek Safar <marek.safar@gmail.com>
1212 * convert.cs, literal.cs: More Convert cleanup is needed.
1214 2008-11-27 Marek Safar <marek.safar@gmail.com>
1216 * decl.cs, class.cs: Fixed misleading error message.
1218 2008-11-26 Marek Safar <marek.safar@gmail.com>
1220 A fix for bug #449005
1221 * nullable.cs (EmitEquality): Disable optimization for user operator
1224 2008-11-25 Marek Safar <marek.safar@gmail.com>
1226 A fix for bug #447027
1227 * anonymous.cs (HoistedVariable): Cache also outer access to deal
1228 with context variables stored as expression instances.
1230 2008-11-25 Marek Safar <marek.safar@gmail.com>
1232 A fix for bug #447027
1233 * delegate.cs: Fixed delegate VerifyMethod logic.
1235 2008-11-24 Marek Safar <marek.safar@gmail.com>
1237 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
1240 2008-11-21 Marek Safar <marek.safar@gmail.com>
1242 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
1243 member type resolve to follow normal flow, instead of random
1246 2008-11-21 Marek Safar <marek.safar@gmail.com>
1248 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
1251 2008-11-21 Marek Safar <marek.safar@gmail.com>
1253 * const.cs: Emit decimal array constant as literal.
1255 2008-11-20 Marek Safar <marek.safar@gmail.com>
1257 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
1259 2008-11-19 Marek Safar <marek.safar@gmail.com>
1261 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
1262 into real property (saves 8 MB for corlib compilation).
1264 2008-11-19 Marek Safar <marek.safar@gmail.com>
1266 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
1267 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
1268 generic-mcs.cs: Small cleanup of TypeArguments.
1270 2008-11-18 Marek Safar <marek.safar@gmail.com>
1272 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
1273 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
1274 of ConstructedType expression, renamed to GenericTypeExpr.
1276 2008-11-17 Marek Safar <marek.safar@gmail.com>
1278 A fix for bug #445303
1279 * location.cs (IsConditionalDefined): Handle undefined global
1282 2008-11-17 Marek Safar <marek.safar@gmail.com>
1284 A fix for bug #444678
1285 * expression.cs (TryReduceConstant): Always create new constant
1288 2008-11-17 Marek Safar <marek.safar@gmail.com>
1290 A fix for bug #444673
1291 * ecore.cs: Ignore open generic types when used as generic type
1294 2008-11-17 Marek Safar <marek.safar@gmail.com>
1296 A fix for bug #445458
1297 * expression.cs, cs-parser.jay: Don't crash when an expression
1300 2008-11-17 Marek Safar <marek.safar@gmail.com>
1302 A fix for bug #445464
1303 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
1304 inside unbound type.
1306 2008-11-14 Jb Evain <jbevain@novell.com>
1308 * driver.cs: ignore empty -nowarn argument such as
1309 the one in -nowarn:12,13,,.
1311 2008-11-13 Marek Safar <marek.safar@gmail.com>
1313 A fix for bug #444271
1314 * anonymous.cs: Rescan parent storeys when best candidate was
1317 2008-11-13 Marek Safar <marek.safar@gmail.com>
1319 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
1320 useless UnboundTypeExpression.
1322 * attribute.cs: Do check obsolete attribute on generic types.
1324 2008-11-12 Marek Safar <marek.safar@gmail.com>
1326 A fix for bugs #425680, #400139
1327 * ecore.cs, expression.cs: Trying to do some almost_matched_members
1330 2008-11-11 Marek Safar <marek.safar@gmail.com>
1332 A fix for bug #435747
1333 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
1334 compound value types assignment. Few micro optimizations added.
1336 2008-11-10 Marek Safar <marek.safar@gmail.com>
1338 A fix for bug #442610
1339 * anonymous.cs (MutateConstructor): More SRE hacking.
1341 2008-11-10 Marek Safar <marek.safar@gmail.com>
1343 A fix for bug #442579
1344 * ecore.cs: Also initialize expanded form of a method with 1 params
1347 2008-11-06 Marek Safar <marek.safar@gmail.com>
1349 * expression.cs (UnaryMutator): Do early l-side check.
1351 2008-11-05 Miguel de Icaza <miguel@novell.com>
1353 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
1354 Init, otherwise we would crash later on when checking for friend
1357 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
1358 Otherwise we never get any meaningful information as to what
1361 2008-11-05 Marek Safar <marek.safar@gmail.com>
1363 A fix for bug #436318
1364 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
1366 2008-11-05 Miguel de Icaza <miguel@novell.com>
1368 * namespace.cs: Turns out that it was a really bad idea to hide
1369 the errors for namespaces not found here in eval mode.
1371 * eval.cs: When we process using clauses, only enter those into
1372 the list of valid using clauses after they have been validated.
1374 The above change gives the proper semantics: it does not
1375 senselessly report the same errors with broken using statements by
1376 never storing them in the first place when they are invalid.
1378 2008-11-05 Marek Safar <marek.safar@gmail.com>
1380 A fix for bug #421839
1381 * cs-parser.jay: Remove expression from coalesce rule to force lower
1382 priority than the assignment operator.
1384 2008-11-05 Marek Safar <marek.safar@gmail.com>
1386 A fix for bug #437875
1387 * nullable.cs: Compile correctly method group operand used with null
1388 coalescing operator.
1390 2008-11-04 Marek Safar <marek.safar@gmail.com>
1392 A fix for bug #434589
1393 * expression.cs (Binary): Ignore lifted conversions when at least
1394 one operand is of reference type.
1396 2008-11-04 Marek Safar <marek.safar@gmail.com>
1398 * cs-parser.jay: Better syntax error report.
1400 2008-11-03 Marek Safar <marek.safar@gmail.com>
1402 A fix for bug #436792
1403 * cs-parser.jay: Use GetLocation to access location.
1405 2008-11-03 Marek Safar <marek.safar@gmail.com>
1407 A fix for bug #440774
1408 * cs-parser.jay: Also set current_array_type when parsing local
1411 2008-11-03 Marek Safar <marek.safar@gmail.com>
1413 A fix for bug #440785
1414 * expression.cs (As): Don't resolve self modifing expression
1417 2008-11-03 Marek Safar <marek.safar@gmail.com>
1419 A fix for bug #439447
1420 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
1422 2008-11-03 Marek Safar <marek.safar@gmail.com>
1424 A fix for bug #437571
1425 * cs-parser.jay: Fixes internal error for invalid expression
1428 2008-10-17 Marek Safar <marek.safar@gmail.com>
1430 * ecore.cs: Resolve correctly ambiguous params delegate methods.
1432 2008-10-17 Marek Safar <marek.safar@gmail.com>
1434 * generic.cs, anonymous.cs: Simplified GetDeclarations.
1436 2008-10-17 Marek Safar <marek.safar@gmail.com>
1438 * cs-tokenizer.cs: More precise cast parsing.
1440 2008-10-16 Martin Baulig <martin@ximian.com>
1442 * anonymous.cs (AnonymousMethodStorey): Put back the
1443 `hoisted_locals' hashtable and use it in EmitType().
1445 2008-10-15 Marek Safar <marek.safar@gmail.com>
1447 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
1448 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
1451 2008-10-14 Marek Safar <marek.safar@gmail.com>
1453 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
1455 2008-10-14 Marek Safar <marek.safar@gmail.com>
1457 * statement.cs: Mutate scope initializers.
1459 2008-10-14 Marek Safar <marek.safar@gmail.com>
1461 * expression.cs: Use typeless value for This constant.
1463 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
1465 2008-10-14 Marek Safar <marek.safar@gmail.com>
1467 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
1470 2008-10-13 Marek Safar <marek.safar@gmail.com>
1472 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
1475 2008-10-13 Marek Safar <marek.safar@gmail.com>
1477 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
1478 parser and tokenizer. Fixes many ambiguities including #433258.
1480 2008-10-10 Marek Safar <marek.safar@gmail.com>
1482 * cs-parser.jay: Fixed missing accessor recovery.
1484 2008-10-10 Marek Safar <marek.safar@gmail.com>
1486 A fix for bug #433701
1487 * expression.cs: Better error message.
1489 2008-10-10 Marek Safar <marek.safar@gmail.com>
1491 * cs-parser.jay, expression.cs: Start reporting real parser errors.
1493 * Makefile: Disabled unused debug symbols.
1495 Also fixes: #320556, #321097, #321656, #321876, #351316
1497 2008-10-09 Miguel de Icaza <miguel@novell.com>
1499 * eval.cs: rename "<interactive>" to "{interactive}", to work
1500 around a requirement in the compiler that this be a valid
1501 filename, and in Windows it is not (433886).
1503 2008-10-09 Marek Safar <marek.safar@gmail.com>
1505 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
1507 2008-10-08 Marek Safar <marek.safar@gmail.com>
1509 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
1510 cs-parser.jay: Generic type declaration and type arguments cleanup.
1512 2008-10-05 Marek Safar <marek.safar@gmail.com>
1514 * cs-parser.jay: Allow parsing weird array creation construct.
1516 2008-10-05 Marek Safar <marek.safar@gmail.com>
1518 * cs-parser.jay: Conflicts reduction.
1520 2008-10-04 Marek Safar <marek.safar@gmail.com>
1522 * cs-parser.jay: Conflicts reduction.
1524 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
1527 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
1528 property. Add a 'count' hint about the use of the shared vector.
1529 Ensure that we don't leak out dirty bits.
1530 (UsageVector.MergeChild): Throw away information about variables
1532 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
1534 2008-10-03 Marek Safar <marek.safar@gmail.com>
1536 A fix for bug #431746
1537 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
1538 parameters when iterator is created.
1540 2008-10-03 Marek Safar <marek.safar@gmail.com>
1542 A fix for bug #431827
1543 * expression.cs: Fixed right based pointer arithmetic operations
1546 2008-10-03 Marek Safar <marek.safar@gmail.com>
1548 A fix for bug #353779
1549 * assign.cs, expression.cs: Fixed compound assignment conversions.
1551 2008-10-02 Marek Safar <marek.safar@gmail.com>
1553 A fix for bug #375262
1554 * statement.cs: Refactor ArrayForeach to be usable with string
1555 indexer. Optimized single dimentional arrays foreach.
1557 2008-10-02 Marek Safar <marek.safar@gmail.com>
1559 A fix for bug #431255
1560 * anonymous.cs, expression.cs: Removed broken optimization.
1562 2008-10-01 Marek Safar <marek.safar@gmail.com>
1564 * anonymous.cs: Use full type parameters of parent generic
1565 containers. Removed unnecessary AddParentStoreyReference call.
1567 2008-10-01 Marek Safar <marek.safar@gmail.com>
1569 A fix for bug #324702
1570 * class.cs: Use better shorter names for explicit interface member
1573 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
1575 2008-10-01 Marek Safar <marek.safar@gmail.com>
1577 * expression.cs: Use new interface to check fixed expression.
1579 2008-10-01 Marek Safar <marek.safar@gmail.com>
1581 A fix for bug #421101
1582 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
1583 interface to check for fixed fixed-buffers.
1585 2008-10-01 Marek Safar <marek.safar@gmail.com>
1587 A fix for bug #429264
1588 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
1590 * delegate.cs: Removed unnecessary casts.
1592 2008-09-30 Marek Safar <marek.safar@gmail.com>
1594 A fix for bug #352151
1595 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
1596 class.cs: Fixed already defined explicit interface members check.
1598 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
1600 cs-tokenizer.cs: Fix typo.
1602 2008-09-28 Miguel de Icaza <miguel@novell.com>
1604 * eval.cs (InteractiveBase): The quit command now just sets a
1605 flag, instead of calling Environment.Exit(), it is milder on
1608 CompiledMethod is now in Mono.CSharp, not nested inside
1609 the Evaluator, it was inconvenient to use.
1611 2008-09-27 Miguel de Icaza <miguel@novell.com>
1613 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
1614 code to be invoked without having to reparse.
1616 2008-09-27 Miguel de Icaza <miguel@novell.com>
1618 * ecore.cs: The recent changes to FieldExpr broke this as well.
1619 Fixes LINQ queries in the interactive shell.
1621 * Multiple files: indentation fixing for the Mono coding
1622 guidelines for the switch statement.
1624 * eval.cs: Make the Evaluator API thread safe.
1626 2008-09-26 Marek Safar <marek.safar@gmail.com>
1628 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
1629 constructor parsing.
1631 2008-09-26 Marek Safar <marek.safar@gmail.com>
1633 A fix for bug #325326
1634 * statement.cs: Check possible mistaken empty statement using
1635 explicit blocks only.
1637 2008-09-25 Miguel de Icaza <miguel@novell.com>
1639 * eval.cs (LoadAssembly, ReferenceAssembly): Call
1640 RootNamespace.ComputeNamespaces to update the internal list of
1641 namespaces, this is no longer done for us.
1643 (InteractiveBase): Use the Evaluator APIs instead of calling into
1646 2008-09-25 Marek Safar <marek.safar@gmail.com>
1648 A fix for bug #429264
1649 * expression.cs: Missing mutator for access to multidimensional
1652 2008-09-25 Marek Safar <marek.safar@gmail.com>
1654 * class.cs, statement: Emit DebuggerHidden attribute for iterator
1657 * driver.cs: Missing input argument check.
1659 2008-09-25 Marek Safar <marek.safar@gmail.com>
1661 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
1662 expression.cs, statement.cs, rootcontext.cs, class.cs,
1663 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
1666 2008-09-24 Miguel de Icaza <miguel@novell.com>
1668 * ecore.cs (FieldExpr): Only initialize eclass when we return a
1669 fully constructed FieldExpr, fixes the regression introduced in
1672 * ecore.cs, expression.cs: Plug back the eclass initialization as
1673 otherwise it regresses `csharp'.
1675 2008-09-24 Marek Safar <marek.safar@gmail.com>
1677 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
1678 ecore.cs, attribute.cs: Moved obsolete method checks from emit
1679 phase to resolve phase. It resolves problems with expression trees
1680 and fixes bugs #323796, #325156.
1682 2008-09-23 Marek Safar <marek.safar@gmail.com>
1684 * codegen.cs: Report better error when symbol writer is missing.
1686 2008-09-23 Marek Safar <marek.safar@gmail.com>
1688 * codegen.cs: Set .NET symbol writer.
1690 * decl.cs: Guard against null generic arguments.
1692 * report.cs: Don't report exactly same additional details.
1694 2008-09-22 Marek Safar <marek.safar@gmail.com>
1696 A fix for bug #324917
1697 * cs-parser.jay: Add missing multidimensional non-expression type
1700 2008-09-22 Marek Safar <marek.safar@gmail.com>
1702 A fix for bug #428191
1703 * anonymous.cs: Create an outer generic fields also for non-storey
1706 2008-09-22 Marek Safar <marek.safar@gmail.com>
1708 A fix for bug #378294
1709 * class.cs: Make fixed size buffers gmcs feature only.
1711 2008-09-22 Marek Safar <marek.safar@gmail.com>
1713 A fix for bug #355622, #324993
1714 * assign.cs, const.cs, class.cs: Create new EmitContext for each
1717 2008-09-19 Marek Safar <marek.safar@gmail.com>
1719 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
1722 2008-09-19 Marek Safar <marek.safar@gmail.com>
1724 A fix for bug #416110
1725 * generic.cs: Struct constraint results in default ctor and
1726 ValueType base type constraint to be set.
1728 2008-09-19 Marek Safar <marek.safar@gmail.com>
1730 A fix for bug #423791
1731 * generic.cs: Fixed params output type type-inference.
1733 2008-09-19 Marek Safar <marek.safar@gmail.com>
1735 * cs-parser.jay, expression.cs: Fixed few expression crashes.
1737 2008-09-19 Marek Safar <marek.safar@gmail.com>
1739 * cs-tokenizer.cs: Don't break on extra partial modifier.
1741 2008-09-19 Marek Safar <marek.safar@gmail.com>
1743 A fix for bug #427592
1744 * generic.cs: Use common parameter resolve method.
1746 2008-09-18 Marek Safar <marek.safar@gmail.com>
1748 A fix for bug #414758
1749 * expression.cs, ecore.cs: Fixed crash when accessing non-static
1752 2008-09-18 Marek Safar <marek.safar@gmail.com>
1754 * driver.cs, namespace.cs: Read types and namespaces after all
1755 requested assemblies are loaded, fixes issues with System.Core
1756 auto-reference, and #419888.
1758 2008-09-18 Marek Safar <marek.safar@gmail.com>
1760 A fix for bug #417705
1761 * cs-parser.jay: Fixed as/is operator expression split.
1763 2008-09-18 Marek Safar <marek.safar@gmail.com>
1765 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
1766 Fixed expression tree representation of empty new expression and
1767 new initializer expression.
1769 2008-09-18 Miguel de Icaza <miguel@novell.com>
1771 * eval.cs: Remove warning, keep reference to driver around.
1773 * Hide fields that do not need to be public.
1775 2008-09-17 Marek Safar <marek.safar@gmail.com>
1777 A fix for bug #426385
1778 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
1779 conversion for array elements.
1781 2008-09-17 Marek Safar <marek.safar@gmail.com>
1783 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
1784 void parsing conflicts.
1786 2008-09-15 Marek Safar <marek.safar@gmail.com>
1788 A fix for bug #425601
1789 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
1790 System.Core only when there is no custom ExtensionAttribute
1793 2008-09-15 Miguel de Icaza <miguel@novell.com>
1795 * namespace.cs: Do not report CS0246 (name
1797 2008-09-12 Marek Safar <marek.safar@gmail.com>
1799 A fix for bug #425669
1800 * generic.cs: Don't cache generic static anonymous method
1803 2008-09-12 Marek Safar <marek.safar@gmail.com>
1805 * generic.cs, class.cs, delegate.cs: Check recursive inherited
1806 conflicting constraints.
1808 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
1810 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
1813 2008-09-12 Marek Safar <marek.safar@gmail.com>
1815 * literal.cs, convert.cs, expression.cs, statement.cs: More null
1816 to null pointer conversion fixes.
1818 2008-09-11 Marek Safar <marek.safar@gmail.com>
1820 * cs-parser.jay, expression.cs: An implicitly typed local variable
1821 declarator cannot use an array initializer.
1823 2008-09-11 Marek Safar <marek.safar@gmail.com>
1825 * cs-parser.jay: Reduced number of printed tokens, add sorting.
1827 2008-09-11 Marek Safar <marek.safar@gmail.com>
1829 * generic.cs (InflatedConstraints): Don't crash when constraints
1832 * cs-parser.jay: const_declarator is a block.
1834 * constant.cs: Check for not allowed NaN conversions.
1836 2008-09-10 Miguel de Icaza <miguel@novell.com>
1838 * driver.cs: Drop --shell argument, the compiler is no longer a
1841 * eval.cs: Move most of the code that deals with evaluation into
1842 this file and document the public API from repl.cs
1844 * repl.cs: Remove from here.
1846 2008-09-10 Marek Safar <marek.safar@gmail.com>
1848 A fix for bug #424684
1849 * generic.cs: Generic class constraints must come first.
1851 2008-09-09 Miguel de Icaza <miguel@novell.com>
1853 * cs-parser.jay: Improve error reporting for syntax errors in
1854 statements and expressions, we now report the expected tokens
1855 instead of reporting the useless "; expected".
1857 Drop the strings from the token declaration, it turns out that
1858 they did not do what I thought they did. Instead they were adding
1859 two sets of tokens to the tables.
1861 2008-09-09 Marek Safar <marek.safar@gmail.com>
1863 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
1864 delegate.cs: Share special type check.
1866 2008-09-09 Marek Safar <marek.safar@gmail.com>
1868 A fix for bug #423981
1869 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
1871 2008-09-09 Marek Safar <marek.safar@gmail.com>
1873 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
1876 2008-09-09 Marek Safar <marek.safar@gmail.com>
1878 A fix for bugs: #324750, #335946
1879 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
1880 lookup rule to determine ?-based tokens.
1882 2008-09-08 Miguel de Icaza <miguel@novell.com>
1884 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
1885 expressions (like event adding or removing) end up here, so we
1886 need to treat those as statements.
1888 Add LoadAssembly method.
1890 2008-09-04 Miguel de Icaza <miguel@novell.com>
1892 * repl.cs: Add Time method.
1894 2008-09-05 Marek Safar <marek.safar@gmail.com>
1896 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
1898 2008-09-05 Miguel de Icaza <miguel@novell.com>
1900 * repl.cs: Add workaround for old compilers.
1902 2008-09-04 Jb Evain <jbevain@novell.com>
1904 * repl.cs (PrettyPrint): pretty print everything that
1905 implements IDictionary, as well as IEnumerables. Also,
1906 add a quit helper property.
1908 2008-09-04 Marek Safar <marek.safar@gmail.com>
1910 * constant.cs: Better error reporting for decimal literals.
1912 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
1915 2008-09-04 Marek Safar <marek.safar@gmail.com>
1916 Miguel de Icaza <miguel@novell.com>
1918 A fix for bug #422951
1919 * assign.cs (Assign.DoResolve): Perform the type conversions
1920 checks before we attempt to initialize `New' initializers.
1922 2008-09-04 Marek Safar <marek.safar@gmail.com>
1924 A fix for bug #422853
1925 * delegate.cs (DelegateCreation): Add special handling for
1926 EmptyExpression.Null instance expression which is just another
1927 hack for undecided member instance exression.
1929 2008-09-04 Marek Safar <marek.safar@gmail.com>
1931 * expression.cs, ecore.cs: Emit full expression tree for reduced
1934 2008-09-04 Marek Safar <marek.safar@gmail.com>
1936 * expression.cs (This): Guard against multi-resolving.
1938 * ecore.cs, statement.cs (Throw): Simplified.
1940 * flowanalysis.cs: Also verify event fields.
1942 2008-09-04 Miguel de Icaza <miguel@novell.com>
1944 * assign.cs (Assign.DoResolve): Perform the type conversions
1945 checks before we attempt to initialize `New' initializers.
1947 * repl.cs (PrettyPrint): Add Hashtable prettyprint
1949 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
1952 * repl.cs: Update help.
1954 2008-09-03 Miguel de Icaza <miguel@novell.com>
1956 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
1957 handling of the default config handling, including the special
1958 treatment of System.Core assembly.
1960 Fixes the REPL processing for LINQ.
1962 2008-09-03 Marek Safar <marek.safar@gmail.com>
1964 A fix for bug #422507
1965 * expression.cs (UnboxCast): Add missing child expression mutator.
1967 2008-09-03 Marek Safar <marek.safar@gmail.com>
1969 * driver.cs: Don't self reference System.Core assembly.
1971 2008-09-03 Marek Safar <marek.safar@gmail.com>
1973 A fix for bug #422507
1974 * expression.cs (StringConcat): Add missing type mutator.
1976 2008-09-03 Marek Safar <marek.safar@gmail.com>
1978 * generic.cs (TypeInferenceContext): Follow equality rule for
1979 constructed type lower bound type inference.
1981 2008-09-02 Miguel de Icaza <miguel@novell.com>
1983 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
1984 <dblank@cs.brynmawr.edu> which updates the cursor position on
1987 2008-09-02 Marek Safar <marek.safar@gmail.com>
1989 A fix for bug #367145
1990 * driver.cs: Fixed import of extension methods when using -noconfig
1993 2008-09-02 Marek Safar <marek.safar@gmail.com>
1995 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
1996 version from non-generic implementation instead.
1998 2008-09-01 Marek Safar <marek.safar@gmail.com>
2000 A fix for bug #418908
2001 * class.cs: Use AddScopeStatement for field initializers.
2003 2008-09-01 Marek Safar <marek.safar@gmail.com>
2005 A fix for bug #415385
2006 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2008 2008-09-01 Marek Safar <marek.safar@gmail.com>
2010 A fix for bug #421736
2011 * iterators.cs: Don't crash on unreachable iterators.
2013 2008-09-01 Marek Safar <marek.safar@gmail.com>
2015 A fix for bug #421628
2016 * parameter.cs, attribute.cs: Clone also parameter attributes.
2018 2008-08-30 Miguel de Icaza <miguel@novell.com>
2020 * namespace.cs (LookupType): In EvalMode, try to replace
2021 the TypeBuilder from our cache with a Type as Reflection.Emit does
2022 not like to mix code from older assemblies emitted and new
2025 This sounds like a serious Mono bug that prevents multiple
2026 assemblies to be generated and consumed at the same time.
2028 * cs-parser.jay (push_current_class): Do not make interactive
2029 classes internal or private, make them public as we currently
2030 generate each new class in a new assembly.
2032 2008-08-29 Miguel de Icaza <miguel@novell.com>
2034 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2035 remove types that are entered into the global namespace during
2036 parsing so that we can remove them on failure.
2038 * cs-parser.jay: Parsing: we now keep track of types that are
2039 entered into global variables and queue those in case the parsing
2042 This happens in a few situations: during partial-input, we invoke
2043 the parser repeatedly for example with the string "class X", this
2044 would cause X to be registed, and we need to remove this
2045 registration so that another parse attempt later with say "class X {"
2046 would actually work.
2048 Additionally, if there is an error in the resolution phase, for
2049 example: "class X : NonExistant {}" th
2051 * cs-parser.jay: Be more precise with the errors being raised,
2052 instead of flagging all exceptions during parsing to be attributed
2053 to the parsing process, distinguish those from errors happening in
2054 the actions and hint that using -v would produce the actual
2057 * repl.cs: Do not load all compiler references on each reset,
2058 doing the partial reset takes care of this.
2060 2008-08-28 Miguel de Icaza <miguel@novell.com>
2062 * repl.cs: Add support for loading all the files from
2063 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2066 Introduce a micro-parser that is able to deambiguate on its input
2067 whether we are dealing with a compilation unit (namespace, class,
2068 interface, struct, delegate) declaration or a statement. This
2069 allows both declarations and statements to be entered.
2071 Set history size by default to 300 lines.
2073 Instead of distinguishing based on the parser.InteractiveResult,
2074 have only two cases: statements were parsed, or a compilation unit
2075 was. Always pull the Using statement additions from the
2076 compilation unit parse.
2078 * cs-tokenizer.cs: Rename tokens to better describe their intent
2079 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2081 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2082 EvalMode is used to trigger the lookup of global variables while
2083 StatementMode is used turn variable declarations into static
2086 * getline.cs: Allow history size to be set.
2088 2008-08-29 Marek Safar <marek.safar@gmail.com>
2090 A fix for bug #360755
2091 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2093 2008-08-29 Marek Safar <marek.safar@gmail.com>
2095 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2097 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2098 member name, it is too confusing
2100 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2102 * rootcontext.cs: Finally default to warning level 4.
2104 2008-08-28 Marek Safar <marek.safar@gmail.com>
2106 * class.cs (CheckBase): Ignore overloaded operators.
2108 2008-08-28 Marek Safar <marek.safar@gmail.com>
2110 A fix for bug #420830
2111 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
2113 2008-08-28 Marek Safar <marek.safar@gmail.com>
2115 A fix for bug #420832
2116 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
2118 2008-08-28 Marek Safar <marek.safar@gmail.com>
2120 A fix for bug #420386
2121 * nullables.cs: Fixed logic of nullable user comparison operators involving
2124 2008-08-28 Marek Safar <marek.safar@gmail.com>
2126 * attribute (IsClsCompliant): Use FALSE value for pointer types.
2128 2008-08-27 Miguel de Icaza <miguel@novell.com>
2130 * repl.cs: Add support for aborting the running code with C-c.
2132 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
2134 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
2136 2008-08-27 Miguel de Icaza <miguel@novell.com>
2138 * cs-parser.jay (interactive_statement_list): A new set of rules
2139 for hosting statements that uses the "interactive_" prefix.
2141 * repl.cs: Add support for parsing `using' as a statement or as a
2142 directive. Deambiguating before passing this to the parser.
2144 We need to distinguish statement_expressions that occur at the
2145 toplevel vs those that occur embedded into expressions.
2147 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
2148 that fixes the cursor key handling, and a history bug.
2150 2008-08-26 Miguel de Icaza <miguel@novell.com>
2152 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
2153 limitations in Console, instead the 2.0 bootstrap libraries now
2154 include the Console bits.
2156 Also, remove the use of Nullables from getline.cs
2160 Interactive support for the C# compiler. Use gmcs --shell to
2161 enter a read-eval-print loop shell.
2163 Docs: http://www.mono-project.com/CsharpRepl
2165 * sources: include repl.cs here and getline.cs for gmcs.exe,
2166 everything else is getline.cs impaired.
2168 * Makefile: when bootstrapping pass a special flag
2169 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
2170 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
2171 This distinguishes those two cases.
2173 * repl.cs: Support for a read-eval-print loop. Will be soon
2174 refactored into eval support and then REPL on top of it.
2176 * ecore.cs: If a simplename lookup fails, before erroring out,
2177 if we are in EvalMode to resolve the name to a declaration in the
2180 This means that variable declarations that happened in previous
2181 classes (as repl puts every statement in a separate class) are
2182 made visible in this way.
2184 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
2185 triggered an error due to the end of file being reached. This is
2186 used to do multi-line input, and notify the caller that the user
2187 needs to provide more text before a successful parse.
2189 Add new grammar rules after the INTERACTIVE_PARSER token is seen
2190 to drive the evaluation with a custom wrapper.
2192 * driver.cs: Add support for --shell, and refactor some code to be
2195 * namespace.cs: Add support for serializing the contents of the
2196 namespaces and reloading them.
2198 * getline.cs: A managed implementation of ReadLine under
2199 X11/Apache2 license terms. Easy to embed in other applications as
2202 * namespace.cs: Add some functions to save and restore the
2205 * rootcontext.cs: New public field.
2207 * cs-tokenizer.cs: Add support for one of the possible characters
2208 we introduce into the token stream.
2210 This patch does not affect the regular tokenization process, the
2211 only performance hit would happen if there is an invalid character
2212 on the input string.
2214 * support.cs: Move isatty helper routine here.
2216 * codegen.cs: Small cleanup, and add a mechanism to initialize the
2217 code generator for in-memory assemblies.
2219 2008-08-26 Marek Safar <marek.safar@gmail.com>
2221 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
2222 parameter cannot be always used as a type.
2224 2008-08-21 Marek Safar <marek.safar@gmail.com>
2226 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
2228 2008-08-21 Marek Safar <marek.safar@gmail.com>
2230 * convert.cs: Implement explicit array to IList<T> conversion.
2232 2008-08-20 Marek Safar <marek.safar@gmail.com>
2234 A fix for bug #362740
2235 * cs-tokenizer.cs: Handle UTF-16 surrogates.
2237 2008-08-20 Marek Safar <marek.safar@gmail.com>
2239 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
2240 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
2241 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
2242 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
2243 handling to use just one type of infrastructure and deal with generics
2246 2008-07-23 Martin Baulig <martin@ximian.com>
2248 *** Merged this from trunk revision 108527 ***
2251 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
2252 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
2255 2008-08-15 Marek Safar <marek.safar@gmail.com>
2257 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
2260 2008-08-15 Marek Safar <marek.safar@gmail.com>
2262 * delegate.cs: Fixed compiler crash when creating delegate using partial
2265 * typemanager.cs: MulticastDelegate is not a delegate.
2267 2008-08-14 Marek Safar <marek.safar@gmail.com>
2269 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
2272 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
2274 * cs-parser.jay (type): Allow 'var' in mcs too.
2275 (local_variable_type): Likewise.
2277 2008-08-14 Marek Safar <marek.safar@gmail.com>
2279 * driver.cs: Removed broken -noconfig variants.
2281 2008-08-14 Marek Safar <marek.safar@gmail.com>
2283 A fix for bug #417078
2284 * expression.cs: Emit correctly left side pointer operators.
2286 2008-08-13 Marek Safar <marek.safar@gmail.com>
2288 * generic.cs, lambda.cs: Inflate method generic arguments only.
2290 2008-08-12 Marek Safar <marek.safar@gmail.com>
2292 * class.cs: Fixed struct layout check regression.
2294 2008-08-12 Marek Safar <marek.safar@gmail.com>
2296 * cs-parser.jay, enum.cs: Simplified enum parsing.
2298 * decl.cs: Check all type parameters conflicts.
2300 * expression.cs, statement.cs, attribute.cs: More expression checks.
2302 2008-08-11 Marek Safar <marek.safar@gmail.com>
2304 * generic.cs: Add type inference types restriction.
2306 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
2307 anonymous.cs, expression.cs: Allocate less accessor parameters.
2309 2008-08-08 Marek Safar <marek.safar@gmail.com>
2311 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
2314 2008-08-08 Marek Safar <marek.safar@gmail.com>
2316 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
2318 2008-08-07 Marek Safar <marek.safar@gmail.com>
2320 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
2321 Also fixes #362146 and #381592.
2323 2008-08-07 Marek Safar <marek.safar@gmail.com>
2325 * ecore.cs: Reduced constant cannot be used as an attribute value.
2327 * cs-parser.jay: Base expression has to be a type.
2329 * expression.cs (Conditional): Uses ReducedExpression.
2331 2008-08-06 Marek Safar <marek.safar@gmail.com>
2333 A fix for bug #376826
2334 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
2335 address of hoisted local variable or parameter cannot be taken.
2337 2008-08-05 Marek Safar <marek.safar@gmail.com>
2339 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
2340 anonymous method inside checked/unchecked expression.
2342 2008-08-05 Marek Safar <marek.safar@gmail.com>
2344 * typemanager.cs (IsEqual): Guard against null.
2346 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
2347 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
2348 routine. Fixed few misleading conversion errors.
2350 2008-08-04 Marek Safar <marek.safar@gmail.com>
2352 * class.cs: Consider generics when checking cycles in struct layout.
2354 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
2356 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
2358 2008-08-04 Marek Safar <marek.safar@gmail.com>
2360 A fix for bug #414165
2361 * anonymous.cs: Use same anonymous implementation method for all anonymous
2364 2008-08-04 Marek Safar <marek.safar@gmail.com>
2366 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
2369 2008-08-04 Marek Safar <marek.safar@gmail.com>
2371 * cs-parser.jay: Typeof argument has to be a type expression.
2373 * namespace.cs: Check alias and namespace definitions collisions.
2375 * class.cs, pending.cs: Moved explicit interface accessor implementation
2378 * delegate.cs, expression.cs: Verify special name invocations.
2380 2008-08-01 Marek Safar <marek.safar@gmail.com>
2382 * cs-parser.jay: Don't choke on empty generic type arguments.
2384 * cs-tokenizer.cs: Handle escaped preprocessor directives.
2386 * expression.cs, ecore.cs: Minor expressions bugs.
2388 2008-08-01 Marek Safar <marek.safar@gmail.com>
2390 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
2391 and added more error handling.
2393 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
2395 * modifiers.cs, enum.cs: Fixed.
2397 2008-07-31 Jb Evain <jbevain@novell.com>
2399 * driver.cs: remove -pkg ability of smcs.
2401 2008-07-30 Marek Safar <marek.safar@gmail.com>
2403 * statement.cs (Switch): Correctly set empty default target for single
2406 2008-07-30 Marek Safar <marek.safar@gmail.com>
2408 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
2409 string switch statement implementation to use string dictionary which
2410 significantly (2-8x) improves performance of generated code.
2412 2008-07-29 Marek Safar <marek.safar@gmail.com>
2414 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
2415 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
2417 2008-07-29 Marek Safar <marek.safar@gmail.com>
2419 A fix for bug #412595
2420 * typemanager.cs, convert.cs, expression.cs: Some types are never
2421 convertible to each other.
2423 2008-07-29 Marek Safar <marek.safar@gmail.com>
2425 * nullable.cs (CreateNullConstant): An error messages update.
2427 2008-07-29 Marek Safar <marek.safar@gmail.com>
2429 A fix for bug #412595
2430 * cfold.cs: Don't cast undefined bool constant.
2432 2008-07-29 Martin Baulig <martin@ximian.com>
2435 (SymbolWriter.Reset): New public static method.
2438 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
2440 2008-07-28 Marek Safar <marek.safar@gmail.com>
2442 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
2444 * expression.cs (ElementAccess): Exact size allocation.
2446 2008-07-26 Marek Safar <marek.safar@gmail.com>
2448 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
2450 2008-07-25 Marek Safar <marek.safar@gmail.com>
2452 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
2454 * class.cs: Removed $PRIVATE$ field hack which caused problems during
2457 2008-07-25 Marek Safar <marek.safar@gmail.com>
2459 A fix for bug #412217
2460 * assign.cs: Mutate also assignment type.
2462 2008-07-25 Marek Safar <marek.safar@gmail.com>
2464 A fix for bug #323644
2465 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
2468 2008-07-25 Marek Safar <marek.safar@gmail.com>
2470 A fix for bug #412134
2471 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
2472 non-enumerable operands when overloading equality or bitwise operators.
2474 2008-07-25 Marek Safar <marek.safar@gmail.com>
2476 * anonymous.cs: Cache closed generic anonymous method delegates.
2478 2008-07-24 Marek Safar <marek.safar@gmail.com>
2480 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
2481 anonymous.cs, statement.cs: Always emit anonymous method as static method
2482 when is instance free. Use nesting for nested anynomous methods blocks.
2484 2008-07-23 Marek Safar <marek.safar@gmail.com>
2486 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
2489 2008-07-23 Marek Safar <marek.safar@gmail.com>
2491 * expression.cs: Removed MakeSimpleCall.
2493 2008-07-23 Marek Safar <marek.safar@gmail.com>
2495 A fix for bug #323012
2496 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
2497 Base method implementing interface has to be public.
2499 2008-07-23 Marek Safar <marek.safar@gmail.com>
2501 * cs-parser.jay: Don't break on missing argument.
2503 2008-07-22 Marek Safar <marek.safar@gmail.com>
2505 A fix for bug #320993
2506 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
2507 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
2509 2008-07-22 Marek Safar <marek.safar@gmail.com>
2511 A fix for bug #320748
2512 * convert.cs: Implicit user operators cannot convert to interfaces
2514 2008-07-22 Marek Safar <marek.safar@gmail.com>
2516 A fix for bug #312686
2517 * driver.cs: Ignore empty assembly references.
2519 2008-07-22 Marek Safar <marek.safar@gmail.com>
2521 A fix for bug #387040
2522 * ecore.cs: Skip constrains check for an explicit implementation.
2524 2008-07-21 Marek Safar <marek.safar@gmail.com>
2526 A fix for bug #409045
2527 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
2528 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
2529 identifiers are file specific unless passed as input arguments.
2531 2008-07-21 Marek Safar <marek.safar@gmail.com>
2533 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
2534 to emit UnmanagedMarshal data under 2.0 profile.
2536 2008-07-21 Marek Safar <marek.safar@gmail.com>
2538 A fix for bug #410369
2539 * parameter.cs: Clone correctly ParamsParameter.
2541 2008-07-21 Marek Safar <marek.safar@gmail.com>
2543 * expression.cs (Argument): Always report type for type based expressions
2546 2008-07-18 Marek Safar <marek.safar@gmail.com>
2548 A fix for bug #410666
2549 * anonymous.cs: Correctly initialize generic storey reference.
2551 2008-07-18 Marek Safar <marek.safar@gmail.com>
2553 * convert.cs: Don't box same type arguments.
2555 2008-07-18 Marek Safar <marek.safar@gmail.com>
2557 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
2558 Finished missing generic type mutators.
2560 2008-07-18 Marek Safar <marek.safar@gmail.com>
2562 * iterators.cs, statement.cs: Finished statements CloneTo.
2564 2008-07-18 Marek Safar <marek.safar@gmail.com>
2566 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
2568 * expression.cs: Emit optimized default value expressions in expression tree
2571 2008-07-18 Marek Safar <marek.safar@gmail.com>
2573 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
2575 2008-07-17 Marek Safar <marek.safar@gmail.com>
2577 A fix for bug #367536
2578 * cs-parser.jay: Check static constructor of generic types for an access
2581 2008-07-17 Marek Safar <marek.safar@gmail.com>
2583 A fix for bug #353800
2584 * lambda.cs: Emit ret for contextual statements.
2586 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
2587 up emitting redundant ret for all anonymous methods with return.
2589 2008-07-17 Marek Safar <marek.safar@gmail.com>
2591 A fix for bug #365188
2592 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
2593 create anonymous method storey in unreachable block.
2595 2008-07-17 Marek Safar <marek.safar@gmail.com>
2597 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
2598 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
2599 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
2600 statement.cs: Fixed relevant defects found by Gendarme.
2602 2008-07-17 Marek Safar <marek.safar@gmail.com>
2604 A fix for bug #325291
2605 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
2606 statement.cs: Replaced IAnonymousHost with top level block flag.
2608 2008-07-17 Marek Safar <marek.safar@gmail.com>
2610 * cs-parser.jay: Clean up unused open_parens.
2612 2008-07-17 Marek Safar <marek.safar@gmail.com>
2614 * ecore.cs: Custom error message for a range variable assignment.
2616 2008-07-16 Marek Safar <marek.safar@gmail.com>
2618 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
2621 2008-07-16 Marek Safar <marek.safar@gmail.com>
2623 * literal.cs: Null literal is of object type.
2625 2008-07-16 Marek Safar <marek.safar@gmail.com>
2627 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
2628 expression of nullable equality comparison.
2630 2008-07-15 Marek Safar <marek.safar@gmail.com>
2632 * expression.cs(PointerArithmetic): Removed redundant assignment.
2634 2008-07-15 Marek Safar <marek.safar@gmail.com>
2636 * decl.cs (GetSignatureForError): Report full namespace name for containers.
2638 2008-07-14 Marek Safar <marek.safar@gmail.com>
2640 A fix for bug #408361
2641 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
2642 they are replaced by GetMethod.
2644 2008-07-14 Marek Safar <marek.safar@gmail.com>
2646 A fix for bug #408721 by jeremie.laval@gmail.com
2647 * expression.cs (Indirection): Implemented CloneTo.
2649 2008-07-14 Marek Safar <marek.safar@gmail.com>
2651 * statement.cs (AssignableSlots): Temporary disabled variable initialization
2654 2008-07-14 Marek Safar <marek.safar@gmail.com>
2656 * report.cs (EnableReporting): Don't reinitialize 0-based values.
2658 2008-07-11 Marek Safar <marek.safar@gmail.com>
2660 * linq.cs: Reset tranparent parameter counter in probing mode.
2662 2008-07-11 Marek Safar <marek.safar@gmail.com>
2664 * anonymous.cs: Mutate anonymous method type.
2666 2008-07-11 Marek Safar <marek.safar@gmail.com>
2668 * ecore.cs, anonymous.cs: Mutate field expressions.
2670 2008-07-10 Marek Safar <marek.safar@gmail.com>
2672 A fix for bug #369670
2673 * linq.cs, statement.cs: Use explicit block for query expressions variables.
2675 2008-07-10 Marek Safar <marek.safar@gmail.com>
2677 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
2679 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
2682 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
2683 only one '>', and finds a '>>', abort the generic lookahead.
2685 2008-07-10 Marek Safar <marek.safar@gmail.com>
2687 A fix for bug #319902
2688 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
2690 2008-07-10 Marek Safar <marek.safar@gmail.com>
2692 A fix for bug #406371
2693 * statement.cs: Moved EmitSymbolInfo to Block.
2695 2008-07-09 Marek Safar <marek.safar@gmail.com>
2697 * ecore.cs: Report better error for extension method overload failures.
2699 2008-07-09 Marek Safar <marek.safar@gmail.com>
2701 * expression.cs (Is): No need to box reference values.
2703 2008-07-09 Marek Safar <marek.safar@gmail.com>
2705 * class.cs: Use event resolve context when initializing CreateEmitContext.
2707 2008-07-09 Marek Safar <marek.safar@gmail.com>
2709 A fix for bug #394436
2710 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
2711 method used inside expression trees. Added more LINQ to expression tree
2714 2008-07-08 Marek Safar <marek.safar@gmail.com>
2716 A fix for bug #378189, #370577
2717 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
2720 2008-07-08 Marek Safar <marek.safar@gmail.com>
2722 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
2725 2008-07-08 Marek Safar <marek.safar@gmail.com>
2727 A fix for bug #406702
2728 * anonymous.cs: Always park anonymous method in the nearest parent storey.
2730 2008-07-07 Marek Safar <marek.safar@gmail.com>
2732 A fix for bug #406648
2733 * cs-parser.jay: Report nullable use in mcs for some cases.
2735 2008-07-07 Marek Safar <marek.safar@gmail.com>
2737 * ecore.cs: Improved argument mismatch error messages.
2739 2008-07-07 Marek Safar <marek.safar@gmail.com>
2741 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
2743 2008-07-07 Marek Safar <marek.safar@gmail.com>
2745 * expression.cs (TypeOf): Mutate type argument.
2747 2008-07-04 Marek Safar <marek.safar@gmail.com>
2749 * class.cs: Report missing partial modifier for correct type.
2751 2008-07-04 Marek Safar <marek.safar@gmail.com>
2753 * ecore.cs, expression.cs (VariableReference): Variable property is
2756 2008-07-04 Marek Safar <marek.safar@gmail.com>
2758 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
2760 2008-07-04 Marek Safar <marek.safar@gmail.com>
2762 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
2765 2008-07-04 Marek Safar <marek.safar@gmail.com>
2767 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
2768 anonymous method storey to an instance method when only "this" is hoisted.
2770 2008-07-03 Marek Safar <marek.safar@gmail.com>
2772 A fix for bug #321615
2773 * expression.cs: Pointer comparisons use unsigned operator.
2775 2008-07-03 Marek Safar <marek.safar@gmail.com>
2777 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
2779 2008-07-02 Marek Safar <marek.safar@gmail.com>
2781 A fix for bug #404905
2782 * class.cs: Always initialize local unsafe variables.
2784 2008-06-30 Marek Safar <marek.safar@gmail.com>
2786 A fix for bug #396987
2787 * expression.cs (NewInitialize): Clear local temporary variable for next run
2789 2008-06-27 Marek Safar <marek.safar@gmail.com>
2791 A fix for bug #401020
2792 * ecore.cs: Both types and modifiers have to match for ref and out arguments
2794 2008-06-27 Marek Safar <marek.safar@gmail.com>
2796 A fix for bug #398319
2797 * cs-parser.jay: Implemented undocumented base access expression inside
2800 2008-06-26 Marek Safar <marek.safar@gmail.com>
2802 A fix for bug #404227
2803 * cs-parser.jay: Parse namespace declaration using qualified identifier.
2805 2008-06-26 Marek Safar <marek.safar@gmail.com>
2807 A fix for bug #404227
2808 * convert.cs: Fixed explicit array to interface cast.
2810 2008-06-26 Marek Safar <marek.safar@gmail.com>
2812 A fix for bug #403894
2813 * delegate.cs: Mutate DelegateInvocation type.
2815 2008-06-26 Marek Safar <marek.safar@gmail.com>
2817 A fix for bug #379348
2818 * delegate.cs: Box a load of generic parameters.
2820 2008-06-26 Marek Safar <marek.safar@gmail.com>
2822 * expression.cs: Add an array creation arguments mutate.
2824 2008-06-26 Marek Safar <marek.safar@gmail.com>
2826 A fix for bug #386068
2827 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
2830 2008-06-25 Marek Safar <marek.safar@gmail.com>
2832 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
2835 2008-06-25 Marek Safar <marek.safar@gmail.com>
2837 A fix for bug #403518
2838 * delegate.cs: Type correctly anonymous method new invocation.
2840 2008-06-24 Marek Safar <marek.safar@gmail.com>
2842 A fix for bug #394826
2843 * anonymous.cs: Fully qualify members when resolving anonymous type internal
2846 2008-06-24 Marek Safar <marek.safar@gmail.com>
2848 A fix for bug #394826
2849 * anonymous.cs, iterators.cs: Construct generic storey only when is really
2852 2008-06-24 Marek Safar <marek.safar@gmail.com>
2854 * class.cs: Clone indexer parameters for localized capturing.
2856 2008-06-24 Marek Safar <marek.safar@gmail.com>
2858 A fix for bug #402379
2859 * expression.cs: Don't crash when an object initializer resolve fails.
2861 2008-06-24 Marek Safar <marek.safar@gmail.com>
2863 A fix for bug #402888
2864 * expression.cs: Mutate conditional expression.
2866 2008-06-24 Marek Safar <marek.safar@gmail.com>
2868 A fix for bug #401012
2869 * class.cs: Keep StructLayout in shared container.
2871 2008-06-24 Marek Safar <marek.safar@gmail.com>
2873 A fix for bug #400438
2874 * decl.cs, class.cs: Only properties can be automatically implemented.
2876 2008-06-24 Marek Safar <marek.safar@gmail.com>
2878 * statement.cs (ChangeToIterator): Copy also labels.
2880 2008-06-23 Marek Safar <marek.safar@gmail.com>
2882 * ecore.cs: Pass type argument details to parent extension method.
2884 2008-06-23 Marek Safar <marek.safar@gmail.com>
2886 A fix for bug #375966
2887 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
2889 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
2891 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
2893 2008-06-22 Marek Safar <marek.safar@gmail.com>
2895 A fix for bug #394347
2896 * anonymous.cs: Cache compatible delegates as compatibility check produces
2897 a new method every time.
2899 2008-06-20 Marek Safar <marek.safar@gmail.com>
2901 * anonymous.cs: Propagate storey reference for single references.
2903 2008-06-20 Marek Safar <marek.safar@gmail.com>
2905 A fix for bug #387615
2906 * assign.cs, expression.cs: Correctly clone compound assignment.
2908 2008-06-19 Marek Safar <marek.safar@gmail.com>
2910 A fix for bug #359611, #359604
2911 * anonymous.cs: Mutate all types of hoisted parameters.
2913 2008-06-19 Marek Safar <marek.safar@gmail.com>
2915 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
2916 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
2917 expression.cs, codegen.cs, statement.cs
2919 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
2920 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
2922 ** Anonymous methods, lambda expressions rewrite **
2924 Anonymous expressions are now resolved when an explicit block is resolved
2925 and they don't require any registration procedure anymore. Further,
2926 anonymous methods are defined when explicit block is emitted which allows
2927 better control of whole process and opens possibilities for more
2928 optimizations as well as alternative to reverse whole process.
2930 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
2931 process consistent and to correctly emit hoisted generic methods when they
2932 have at least 1 hoisted variable.
2934 2008-06-17 Martin Baulig <martin@ximian.com>
2936 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
2938 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
2939 virtual property; check it in Emit().
2940 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
2942 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
2944 (Indexer.Define): Likewise.
2946 2008-06-17 Marek Safar <marek.safar@gmail.com>
2948 * convert.cs: Don't use IsInterface on type arguments.
2950 * delegate.cs: DelegateInvocation uses MethodInfo.
2952 * parameter.cs: Removed IsTypeParameter.
2954 * generic-mcs.cs: More missing stuff.
2956 2008-06-16 Martin Baulig <martin@ximian.com>
2959 (Modifiers.DEBUGGER_HIDDEN): New public const.
2962 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
2965 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
2966 (AbstractPropertyEventMethod): Likewise.
2967 (Constructor.Emit): Likewise.
2968 (SourceMethod.SetCompilerGenerated): Removed.
2970 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
2974 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
2975 if we're an `IteratorHost'.
2976 (AnonymousMethodMethod..ctor): Don't set
2977 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
2980 2008-06-16 Marek Safar <marek.safar@gmail.com>
2982 * statement.cs: Clean-up foreach statements.
2984 2008-06-12 Marek Safar <marek.safar@gmail.com>
2986 * class.cs: Stop using public method which should not exist
2987 (MethodBuilder.SetGenericMethodSignature).
2989 2008-06-11 Martin Baulig <martin@ximian.com>
2992 (Location.LookupFile): Add `CompilationUnit' argument; when given
2993 a relative file name, make it relative to the directory the .cs
2994 file is located in instead of using the current directory.
2996 2008-06-11 Martin Baulig <martin@ximian.com>
2999 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3000 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3001 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3002 (SourceMethod.SetCompilerGenerated): Likewise.
3004 2008-06-11 Marek Safar <marek.safar@gmail.com>
3006 * codegen.cs, driver: Only write symbol file when it's asked for.
3008 2008-06-11 Marek Safar <marek.safar@gmail.com>
3010 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3012 2008-06-10 Martin Baulig <martin@ximian.com>
3014 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3016 2008-06-09 Marek Safar <marek.safar@gmail.com>
3018 A fix for bug #316290
3019 * expression.cs: Include decimal operators in predefined table.
3021 * parameters.cs: More readonlyness.
3023 2008-06-09 Marek Safar <marek.safar@gmail.com>
3025 A fix for bug #397213
3026 * cs-parser.jay: One more missing current_local_parameters reset.
3028 2008-06-09 Marek Safar <marek.safar@gmail.com>
3030 A fix for bug #396633
3031 * class.cs: Host backing field in partial container.
3033 2008-06-09 Marek Safar <marek.safar@gmail.com>
3035 A fix for bug #397068
3036 * expression.cs: Check both operand types when predefined operator is used.
3038 2008-06-05 Martin Baulig <martin@ximian.com>
3040 Merged the `debugger-kahalo' branch.
3043 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3044 we're an iterator method.
3045 (SourceMethod): Reflect latest symbol writer changes;
3046 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3047 now `start_row' and `end_row'.
3048 (Constructor.Emit): Fix the logic whether to emit symbol information.
3050 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3054 (CompilationUnit): New public class; derives from `SourceFile'.
3055 (SourceFileEntry.DefineSymbolInfo): New public method.
3056 (SourceFileEntry.SetChecksum): New public method.
3057 (Location): Encode hidden line numbers by using `column == 255';
3058 the .ctor now accepts `column == -1' to mark a hidden line number.
3059 (Location.Hidden): New public property.
3060 (Location.CheckPoint): Add `CompilationUnit'.
3061 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3062 (Location.Push): Add `CompilationUnit compile_unit' argument.
3063 (Location.CompilationUnit): New public property.
3066 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3068 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3070 * driver.cs: `SourceFile' -> `CompilationUnit'.
3072 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3074 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3076 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3080 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3081 new symbol writer API to also pass the file.
3083 2008-06-05 Marek Safar <marek.safar@gmail.com>
3085 * statement.cs: Emit catch variable assignment using variable expression.
3087 2008-06-05 Marek Safar <marek.safar@gmail.com>
3089 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3090 with other variable types.
3092 2008-06-04 Marek Safar <marek.safar@gmail.com>
3094 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3095 GetLength method emit, it breaks resolve rules.
3097 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3098 Marek Safar <marek.safar@gmail.com>
3100 A fix for bug #395542
3101 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3104 2008-06-02 Marek Safar <marek.safar@gmail.com>
3106 A fix for bug #395287
3107 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
3109 2008-05-31 Marek Safar <marek.safar@gmail.com>
3111 A fix for bug #395845
3112 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
3113 non-nullable parameter type.
3115 2008-05-31 Marek Safar <marek.safar@gmail.com>
3117 * class.cs: Handle contructor initializer as a statement in top-level block.
3119 2008-05-30 Marek Safar <marek.safar@gmail.com>
3121 * attribute.cs: Don't mix old and new corlib types when emitting corlib
3122 security attributes.
3124 2008-05-24 Marek Safar <marek.safar@gmail.com>
3126 * ecore.cs, expression.cs: Small IVariable refactoring.
3128 2008-05-22 Marek Safar <marek.safar@gmail.com>
3130 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
3132 2008-05-21 Marek Safar <marek.safar@gmail.com>
3134 * cs-parser.jay: Removed redundant catch type check.
3136 2008-05-21 Marek Safar <marek.safar@gmail.com>
3138 A fix for bug #390372
3139 * nullable.cs: Set correct return type.
3141 2008-05-21 Marek Safar <marek.safar@gmail.com>
3143 A fix for bug #391062
3144 * typemanager.cs: Fixed crash when comparing null types.
3146 2008-05-21 Marek Safar <marek.safar@gmail.com>
3148 A fix for bug #391871
3149 * cs-parser.jay: Better error handling for invalid catch type.
3151 2008-05-20 Marek Safar <marek.safar@gmail.com>
3153 A fix for bug #392155
3154 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
3156 2008-05-15 Marek Safar <marek.safar@gmail.com>
3158 A fix for bug #390666
3159 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
3162 2008-05-15 Marek Safar <marek.safar@gmail.com>
3164 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
3167 2008-05-13 Marek Safar <marek.safar@gmail.com>
3169 A fix for bug #389625
3170 * delegate.cs, generic.cs: Some progress on method group return type
3173 2008-05-13 Marek Safar <marek.safar@gmail.com>
3175 A fix for bug #378419
3176 * namespace.cs: Inspect also parent namespaces not only namespace entries.
3178 2008-05-12 Marek Safar <marek.safar@gmail.com>
3180 * class.cs (Constructor): Added IsCompilerGenerated.
3182 2008-05-12 Marek Safar <marek.safar@gmail.com>
3184 * expression.cs: Enum binary operators can accept non-enum operand only when
3185 is implicitly convertible to underlying type.
3187 2008-05-12 Marek Safar <marek.safar@gmail.com>
3189 A fix for bug #389272
3190 * support.cs: Workaround System.InvalidOperationException for enums.
3192 2008-05-12 Marek Safar <marek.safar@gmail.com>
3194 A fix for bug #389073
3195 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
3197 2008-05-10 Marek Safar <marek.safar@gmail.com>
3199 * driver.cs: Split Parse.
3201 * location.cs (LookupFile): Uses string.Empty.
3203 2008-05-07 Marek Safar <marek.safar@gmail.com>
3205 * expression.cs, parameter.cs: Small ParameterReference clean up.
3207 2008-05-07 Marek Safar <marek.safar@gmail.com>
3209 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
3210 hack. Fixes #387502.
3212 2008-05-06 Martin Baulig <martin@ximian.com>
3214 * class.cs (Constructor.Emit): Fix the logic whether to emit
3217 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
3220 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
3221 InvalidOperationException when the iterator is before the start or
3224 2008-05-06 Marek Safar <marek.safar@gmail.com>
3226 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
3227 when left is nullable type.
3229 2008-05-06 Marek Safar <marek.safar@gmail.com>
3231 A fix for bug #386628
3232 * expression.cs (LocalVariableReference): Continue in resolving when
3233 variable is not assigned.
3235 2008-05-05 Marek Safar <marek.safar@gmail.com>
3237 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
3238 nullable operations.
3240 2008-05-04 Marek Safar <marek.safar@gmail.com>
3242 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
3243 it saves many redundant temporary variables for nullable operations.
3245 2008-05-03 Marek Safar <marek.safar@gmail.com>
3247 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
3249 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
3252 * nullable.cs: Constant coalescing operator optimizations.
3254 2008-05-03 Marek Safar <marek.safar@gmail.com>
3256 * constant.cs: Use unsigned conversion for values which are unsigned only.
3258 2008-05-03 Marek Safar <marek.safar@gmail.com>
3260 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
3261 coalescing operator as it should be.
3263 2008-05-02 Marek Safar <marek.safar@gmail.com>
3265 A fix for bug #371016
3266 * expression.cs: All predefined delegate operators require implicit method
3269 2008-05-02 Marek Safar <marek.safar@gmail.com>
3271 * constant.cs: Emit long constant as uint when fits the range.
3273 * convert.cs, expression.cs: Fixed few unsafe conversions.
3275 2008-05-02 Marek Safar <marek.safar@gmail.com>
3277 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
3279 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
3282 * convert.cs (ImplicitNumericConversion): Don't modify the type of
3284 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
3286 2008-05-01 Marek Safar <marek.safar@gmail.com>
3288 * constant.cs, literal.cs: IsLiteral property for error reporting.
3290 * ecore.cs, expression.cs: Implemented Property expression.
3292 2008-05-01 Marek Safar <marek.safar@gmail.com>
3294 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
3296 * nullable.cs: Implemented nullable coalescing null operator.
3298 * ecore.cs, expression.cs: Expression trees work.
3300 2008-05-01 Marek Safar <marek.safar@gmail.com>
3302 * ecore.cs: CreateExpressionTree is finally abstract.
3304 * expression.cs, linq.cs: Updated.
3306 2008-05-01 Marek Safar <marek.safar@gmail.com>
3308 * expression.cs, ecore.cs: Block base access expression inside expression
3311 2008-05-01 Marek Safar <marek.safar@gmail.com>
3313 A fix for bug #385058
3314 * expression.cs: User-defined operator implementations always take
3315 precedence over predefined operator implementations.
3317 2008-04-30 Marek Safar <marek.safar@gmail.com>
3319 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
3320 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
3321 expression tree conversions.
3323 2008-04-30 Marek Safar <marek.safar@gmail.com>
3325 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
3326 operators method details to Operator class.
3328 2008-04-30 Marek Safar <marek.safar@gmail.com>
3330 * anonymous.cs: Pass unsafe flags to anonymous container.
3332 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
3333 inside expression tree.
3335 2008-04-29 Martin Baulig <martin@ximian.com>
3337 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
3338 (Tokenizer.PopPosition): Also restore the `line'.
3340 2008-04-29 Marek Safar <marek.safar@gmail.com>
3342 * delegate.cs: Implemented Invoke expression.
3344 2008-04-29 Marek Safar <marek.safar@gmail.com>
3346 * expression.cs: Fixed equality reference comparison regression.
3348 2008-04-29 Marek Safar <marek.safar@gmail.com>
3350 * ecore.cs: Clean up EmptyCast hack.
3352 * expression.cs, nullable.cs: Implemented enum binary and unary operations
3353 using correct conversion rules. Also fixes #383993.
3355 2008-04-28 Martin Baulig <martin@ximian.com>
3357 * class.cs (Constructor.Emit): Don't emit debugging information
3358 for generated default .ctor's.
3360 2008-04-28 Marek Safar <marek.safar@gmail.com>
3362 * convert.cs: Empty-cast ushort to int conversion.
3364 2008-04-28 Marek Safar <marek.safar@gmail.com>
3366 A fix for bug #384191
3367 * ecore.cs, expression.cs: Fixed expression cloning.
3369 2008-04-28 Marek Safar <marek.safar@gmail.com>
3371 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
3373 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
3375 Fix #381559, test-638.cs, test-639.cs
3376 * assign.cs (CompoundAssign.Helper): New wrapper.
3377 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
3379 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
3380 Pass unconverted expressions to the params array creation expression.
3381 (FieldExpr.EmitAssign): Don't special-case StringConcat.
3382 (PropertyExpr.EmitAssign): Likewise.
3383 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
3384 element if it is of kind CompoundAssign.Helper.
3385 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
3386 first before anything else.
3387 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
3388 (ArrayAccess.LoadArrayAndArguments): Simplify.
3390 2008-04-27 Marek Safar <marek.safar@gmail.com>
3392 * expression.cs: Fixed cloning of typeof(void).
3394 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
3396 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
3397 (Assign.Emit): Likewise. Move it to ...
3398 (CompoundAssign.DoResolve): ... here and ...
3399 (CompoundAssign.Emit): ... here.
3400 (EventAddOrRemove): New helper to handle += and -= on events, and
3401 avoid the use of BinaryDelegates.
3402 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
3403 (EventExpr.EmitAddOrRemove): Improve.
3404 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
3406 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
3407 create VarExprs for 'foo.bar.var'.
3408 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
3409 is a highly inappropriate name for its functionality.
3411 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3413 Simplify handling of multiple assignments
3414 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
3416 (SimpleAssign): New. Class to be used for normal assignments.
3417 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
3418 * expression.cs, parameter.cs, statement.cs: Likewise.
3420 2008-04-25 Marek Safar <marek.safar@gmail.com>
3422 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
3423 for incompatible underlying types, more to come, uff.
3425 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3428 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
3429 Handle 'leave_copy'.
3431 2008-04-25 Marek Safar <marek.safar@gmail.com>
3433 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
3435 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
3437 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
3438 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
3439 * statement.cs (While, Do, For): Allow test to have side effects.
3440 (For.DoEmit): Always emit InitStatement.
3443 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
3444 Always create SideEffectConstant.
3445 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
3446 of type EnumConstant.
3448 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
3449 Handle 'right' being SideEffectConstant of type 'bool'.
3451 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
3452 Use left.EmitBranchable instead of open coding it, so as to
3453 improve optimization opportunities.
3455 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
3457 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
3459 (Expression.EmitSideEffect): Document.
3461 2008-04-23 Marek Safar <marek.safar@gmail.com>
3463 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
3465 2008-04-23 Marek Safar <marek.safar@gmail.com>
3467 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
3469 2008-04-23 Marek Safar <marek.safar@gmail.com>
3471 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
3472 conversion to expression tree.
3474 2008-04-23 Marek Safar <marek.safar@gmail.com>
3476 * ecore.cs: Removed unused expression.
3478 2008-04-22 Marek Safar <marek.safar@gmail.com>
3480 * expression.cs: Implemented NegateChecked and New expressions.
3482 2008-04-22 Marek Safar <marek.safar@gmail.com>
3484 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
3486 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
3489 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
3490 needing final 'ret' instruction.
3492 2008-04-22 Marek Safar <marek.safar@gmail.com>
3494 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
3496 2008-04-21 Marek Safar <marek.safar@gmail.com>
3498 * expression.cs: Emit ldnull and not null expression as an instance argument
3499 of static method expression calls.
3501 2008-04-21 Marek Safar <marek.safar@gmail.com>
3503 A fix for bug #378200
3504 * expression.cs: Fixed crash when creating parameterless expression tree
3507 2008-04-21 Marek Safar <marek.safar@gmail.com>
3509 A fix for bug #375297
3510 * anonymous.cs: Fixed crash when inferring from null argument anonymous
3513 2008-04-21 Marek Safar <marek.safar@gmail.com>
3515 A fix for bug #377596
3516 * decl.cs, class.cs: Emit delegate type argument attributes.
3518 2008-04-21 Marek Safar <marek.safar@gmail.com>
3520 A fix for bug #365314
3521 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
3523 2008-04-21 Marek Safar <marek.safar@gmail.com>
3525 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
3528 2008-04-21 Marek Safar <marek.safar@gmail.com>
3530 * generic.cs (TypeParameter): Removed redundant location.
3532 2008-04-19 Marek Safar <marek.safar@gmail.com>
3534 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
3535 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
3536 FullNamedExpression in all declaration type expression, statements will come
3539 2008-04-18 Marek Safar <marek.safar@gmail.com>
3541 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
3542 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
3544 2008-04-18 Marek Safar <marek.safar@gmail.com>
3546 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
3549 2008-04-17 Marek Safar <marek.safar@gmail.com>
3551 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
3554 2008-04-17 Marek Safar <marek.safar@gmail.com>
3556 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
3560 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
3562 Hook up 'EmitSideEffect'
3563 * constant.cs (Constant.EmitSideEffect): New.
3564 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
3565 (SideEffectConstant.EmitSideEffect): New.
3566 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
3567 unconditional branch in EmitBranchable.
3568 (FieldExpr.EmitBranchable): New.
3569 * expression.cs (Unary.EmitSideEffect): New.
3570 (Binary.EmitSideEffect): New.
3571 (VariableReference.EmitSideEffect): New. Do nothing.
3573 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
3575 Introduce 'EmitSideEffect'
3576 * ecore.cs (Expression.EmitSideEffect): New.
3577 (TypeCast): Rename from EmptyCast.
3579 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
3580 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
3581 * convert.cs, nullable.cs: Update to changes.
3583 2008-04-16 Marek Safar <marek.safar@gmail.com>
3585 * class.cs, cs-parser.jay: Early check for base types expression.
3587 2008-04-16 Marek Safar <marek.safar@gmail.com>
3589 * decl.cs (MemberName): Declare PrettyName as obsolete.
3591 2008-04-16 Marek Safar <marek.safar@gmail.com>
3593 * namespace.cs: Use MemberName comparison.
3595 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
3598 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
3600 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
3601 (MemberName.FullyQualifiedName): New. Provides the functionality
3602 that users assume FullName would have.
3603 * ecore.cs, namespace.cs: Update to changes.
3605 * statement.cs (Using.assign): Make into ExpressionStatement.
3606 (Using.EmitPreTryBody): Simplify.
3608 2008-04-16 Marek Safar <marek.safar@gmail.com>
3610 * report.cs: ColorFormat is protected.
3612 * rootcontext.cs: Unused fields clean-up.
3614 * namespace.cs: Made UsingEntry name private.
3616 2008-04-16 Marek Safar <marek.safar@gmail.com>
3618 * cs-tokenizer.cs, location.cs: Removed unused field.
3620 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
3621 Raja R Harinath <harinath@hurrynot.org>
3624 * constant.cs (SideEffectConstant.value): Rename from 'left'.
3625 (SideEffectConstant.side_effect): Rename from 'right'.
3626 (SideEffectConstant..ctor): Normalize 'side_effect'.
3627 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
3628 value of this constant.
3629 * cfold.cs: Update to changes.
3631 2008-04-15 Marek Safar <marek.safar@gmail.com>
3633 * cs-paser.jay: Removed unused variable.
3635 * driver.cs: Made Compile instance method.
3637 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
3639 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
3641 2008-04-15 Marek Safar <marek.safar@gmail.com>
3643 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
3645 2008-04-13 Jb Evain <jbevain@novell.com>
3647 * namespace.cs: update the System.Core fullname for 2.1
3648 * driver.cs: update the list of required assemblies for 2.1.
3649 Merged from the Moonlight 2 branch.
3651 2008-04-11 Marek Safar <marek.safar@gmail.com>
3653 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
3654 types and user defined operators. User operators arguments has to be checked
3655 for null value before invocation, which also means no operator is called
3656 when any argument is not convertible to unwrapped nullable type.
3658 2008-04-09 Marek Safar <marek.safar@gmail.com>
3660 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
3661 of Unary expressions to follow operator overloading rules precisely.
3662 Also fixes #321794, #323794
3664 2008-04-08 Marek Safar <marek.safar@gmail.com>
3666 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
3669 2008-04-08 Marek Safar <marek.safar@gmail.com>
3671 * expression.cs, ecore.cs: Implemented MemberInit expression.
3673 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
3675 Fix mono/tests/exception4.cs
3676 * statement.cs (ExceptionStatement, TryCatch): Revert to using
3677 ec.NeedReturnLabel () rather emitting a 'nop'.
3679 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
3681 (TryCatch.SomeCodeFollows): Likewise.
3682 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
3683 for 'break', 'continue' and 'return' statements inside a try.
3684 We're fairly sure that the generated IL stream will have more
3685 instructions textually following the try.
3686 (FlowBranchingTryCatch): Likewise.
3688 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
3689 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
3692 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
3693 wrapper -- forward everything to CollectionForeach.
3694 (CollectionForeach.NonDisposableWrapper): New.
3695 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
3696 instead of a pop + branch to end.
3698 2008-04-07 Marek Safar <marek.safar@gmail.com>
3700 A fix for bug #377485
3701 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
3702 Propagate location for extension method groups. Report conversion failure at
3705 2008-04-07 Marek Safar <marek.safar@gmail.com>
3707 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
3708 ListInit and Field expressions.
3710 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
3712 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
3713 Since $PC is always -1 inside the body of MoveNext, the fault
3715 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
3716 * statement.cs (ExceptionStatement.emit_finally): Likewise.
3717 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
3719 The denouement! Fix #324708
3720 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
3721 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
3722 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
3723 'finally' inside the finally clause.
3725 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
3726 inside an iterator. Don't emit the body of the 'finally' inside
3727 the finally clause yet.
3729 Use the ResumableStatement infrastructure for MoveNext ()
3730 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
3731 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
3732 'old_resume_points'. Move dispatcher upfront.
3733 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
3734 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
3735 in an enumerator. This encodes the main fix in this patch series
3736 -- we can only jump into the first instruction of a try from the
3737 outside, but we want to emit try/finally regions in iterators and
3738 resume in the middle of them.
3740 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
3742 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
3743 of NeedReturnLabel here.
3745 Introduce a common point for emitting try/finally to IL
3746 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
3747 features of the various subclasses, which are now driven by ...
3748 (ExceptionStatement.EmitPreTryBody): ... this and ...
3749 (ExceptionStatement.EmitTryBody): ... this and the original
3751 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
3752 Remove DoEmit and update to follow above protocol.
3754 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
3755 of the dispatcher are the same, skip emitting the 'switch'.
3756 * iterator.cs (Iterator.EmitDispose): Update to changes.
3758 Clean up handling of 'using' statement
3759 * statement.cs (UsingTemporary): New. Carved out of ...
3760 (Using): ... this. Simplify drastically. Handle exactly
3762 * cs-parser.jay (using_statement): Split. Create UsingTemporary
3763 or Using as appropriate. If there are multiple variable declared,
3764 create nested Using statements.
3765 (resource_acquisition): Kill.
3767 * statement.cs (ExceptionStatement.EmitForDispose): Use
3768 EmitFinallyBody, not EmitFinally.
3770 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
3771 * iterator.cs: Update to changes.
3773 Start using the ResumableStatement infrastructure
3774 * statement.cs (ResumeableStatement.PrepareForDispose): New.
3775 (ResumableStatement.EmitForDispose): New.
3776 (ExceptionStatement): Override them.
3777 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
3778 EmitForDispose to create the body of the Dispose method. Don't
3781 * iterator.cs (Iterator.AddResumePoint): Move here from ...
3782 * statement.cs (Toplevel.AddResumePoint): ... here.
3783 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
3784 * flowanalysis.cs (FlowBranchingIterator): New.
3785 * codegen.cs (EmitContext): Update to changes.
3787 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
3788 (Iterator.old_resume_points): Rename from 'resume_points'.
3789 (Iterator.MoveNextStatement): Remove unused class.
3791 New infrastructure for try/finally in iterators (still unused)
3792 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
3793 (FlowBranchingToplevel.AddResumePoint): Hook into
3794 ToplevelBlock.AddResumePoint.
3795 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
3796 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
3797 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
3798 resume points and assign program-counter values.
3799 (ExceptionBlock.AddResumePoint): Collect resume points for
3800 de-muxer at the top of try block.
3801 * iterators.cs (Yield.CheckContext): Simplify.
3802 (Yield.Resolve): Use FlowBranching.AddResumePoint.
3804 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
3806 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
3807 argument to an ExitStatement.
3808 (FlowBranchingException): Refactor saved origins code.
3809 * statement.cs (ExitStatement): Update to cahges.
3810 * iterator.cs (YieldBreak): Likewise.
3812 * statement.cs (ResumableStatement): New. Common base class for
3813 YieldReturn and ExceptionStatement.
3814 (ExitStatement): New. Common base class for Return and YieldBreak.
3815 (Return): Update to changes.
3816 * iterator.cs (YieldBreak): Likewise.
3817 * lambda.cs (ContextualReturn): Likewise.
3820 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
3821 emit a meaningful error message.
3823 Fix #324765, #319508
3824 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
3825 (VariableInfo.SetAssigned): Set it.
3826 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
3827 determine if CS0219 or CS0168 is appropriate. Don't use
3828 flow-analysis information.
3829 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
3830 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
3831 (EmitContext.EndFlowBranching): ... this.
3833 2008-04-03 Marek Safar <marek.safar@gmail.com>
3835 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
3837 2008-04-03 Marek Safar <marek.safar@gmail.com>
3839 A fix for bug #376508
3840 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
3841 ImplicitConversionExists.
3843 2008-04-03 Marek Safar <marek.safar@gmail.com>
3845 * expression.cs (Binary): Added remaining binary operators to expression
3848 * nullable.cs: Optimize shift with null argument.
3850 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
3852 Fix minor IL regression
3853 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
3854 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
3855 * cs-parser.jay (try_statement): Update to changes.
3857 * statement.cs (TryFinally.need_exc_block): Delete.
3858 (TryFinally): Update to changes.
3860 Now all ExceptionStatements are unconditional
3861 * statement.cs (CollectionForeach.DisposableWrapper): New.
3862 Extract out the try/finally code into a new wrapper.
3863 (CollectionForeach.Resolve): Use it to simplify the code.
3865 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
3867 Start at simplifying ExceptionStatement semantics a bit
3868 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
3869 * cs-parser.jay (try_statement): Update to changes.
3870 (opt_catch_clauses): Remove.
3871 * flowanalysis.cs: Update to changes.
3872 (FlowBranching.BranchingType.TryCatch): New.
3873 (FlowBranchingTryCatch): New.
3875 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
3876 (FlowBranching.CreateBranching): Update to changes.
3877 (FlowBranchingBlock.AddSibling): Add sanity check.
3878 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
3881 * iterators.cs (Iterator.MarkFinally): Remove.
3882 * statement.cs (ExceptionStatement): Update to changes.
3884 Add support for skipping over finally blocks at runtime. First
3885 in a series to fix #324708
3886 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
3887 (Iterator.EmitMoveNext): Initialize it.
3888 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
3889 branch over the body of the 'finally' clause.
3891 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
3893 Avoid lopsided use of Foo/DoFoo names
3894 * statement.cs (ExpressionStatement.EmitFinallyBody):
3895 Rename from EmitFinally.
3896 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
3897 * iterator.cs: Update to changes.
3899 2008-04-02 Marek Safar <marek.safar@gmail.com>
3901 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
3902 based on UserOperatorCall. More binary nullable operators clean up.
3904 2008-04-02 Martin Baulig <martin@ximian.com>
3906 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
3908 2008-04-02 Marek Safar <marek.safar@gmail.com>
3910 * nullable.cs: Merge user and empty conversions when lifting expression
3913 * expression.cs (StringConcat): Implemented expression tree representation.
3915 2008-04-01 Marek Safar <marek.safar@gmail.com>
3917 * nullable.cs: When lifting null literal and a user operator exists, no call
3920 2008-04-01 Marek Safar <marek.safar@gmail.com>
3922 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
3925 2008-04-01 Marek Safar <marek.safar@gmail.com>
3927 * nullable.cs, expression.cs: Use namespace instead heavily nested
3928 monster abstract class.
3930 2008-04-01 Marek Safar <marek.safar@gmail.com>
3932 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
3933 lifting of null literal and user operators. Clean up of some temporary
3936 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
3938 Fix #368224, test-629.cs
3939 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
3940 if it crossed an unwind-protect boundary.
3941 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
3942 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
3943 inside an unwind-protected region.
3944 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
3945 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
3946 'leave' instead of a 'br' if unwind-protected.
3947 (Iterator.EmitYieldBreak): Likewise.
3949 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
3951 * driver.cs: Only define versioninfo resources if no win32 resource
3954 2008-03-28 Marek Safar <marek.safar@gmail.com>
3956 A fix for bug #372375
3957 * convert.cs: Fixed boxing of nullable types.
3959 2008-03-28 Marek Safar <marek.safar@gmail.com>
3961 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
3964 2008-03-28 Marek Safar <marek.safar@gmail.com>
3966 A fix for bug #374619
3967 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
3969 2008-03-27 Marek Safar <marek.safar@gmail.com>
3971 * lambda.cs: Check return type only for invocation.
3973 2008-03-27 Marek Safar <marek.safar@gmail.com>
3975 A fix for bug #374214
3976 * ecore.cs: Correctly report argument type mismatch.
3978 2008-03-27 Marek Safar <marek.safar@gmail.com>
3980 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
3981 and not rely on broken IsEnum.
3983 2008-03-27 Marek Safar <marek.safar@gmail.com>
3985 * nullable.cs: New file, extracted from generic.cs.
3987 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
3989 2008-03-27 Marek Safar <marek.safar@gmail.com>
3991 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
3992 predefined comparison operators and null literals.
3994 * report.cs: New warning ID.
3996 2008-03-25 Marek Safar <marek.safar@gmail.com>
3998 A fix for bug #370577
3999 * lambda.cs: Check return type too.
4001 2008-03-25 Marek Safar <marek.safar@gmail.com>
4003 A fix for bug #372846
4004 * class.cs: Automatic properties can be declared as unsafe.
4006 2008-03-20 Marek Safar <marek.safar@gmail.com>
4008 * location.cs: Use string based concatenation.
4010 * expression.cs: LiftedBinaryOperator is gmcs only.
4012 2008-03-20 Marek Safar <marek.safar@gmail.com>
4014 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4015 conversions rules and expression trees.
4017 2008-03-19 Marek Safar <marek.safar@gmail.com>
4019 * delegate.cs: Use extension method source as delegate target.
4021 2008-03-19 Marek Safar <marek.safar@gmail.com>
4023 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4024 binary operations to be purely based on binary operations and optimized
4025 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4026 and other ET refactoring.
4028 * typemanager.cs: Fixed warning.
4030 2008-03-17 Marek Safar <marek.safar@gmail.com>
4032 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4034 * symbolwriter.cs: Fixed.
4036 2008-03-17 Marek Safar <marek.safar@gmail.com>
4038 * anonymous.cs, driver.cs: Reset anonymous types counters.
4040 2008-03-17 Marek Safar <marek.safar@gmail.com>
4042 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4044 * class.cs: Use fullname for all type member definitions.
4046 2008-02-19 Martin Baulig <martin@ximian.com>
4049 (IMethodData.EmitExtraSymbolInfo): New interface method.
4050 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4051 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4052 interface method here as an empty public virtual method.
4055 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4056 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4057 CodeGen.SymbolWriter.SetRealMethodName().
4059 2008-02-18 Martin Baulig <martin@ximian.com>
4062 (ScopeInfo.EmitType): Override this and emit debugging
4063 information for captured variables.
4064 (RootScopeInfo.EmitType): Override this and emit symbol
4065 information for a captured `this'.
4067 2008-02-15 Martin Baulig <martin@ximian.com>
4069 * iterators.cs: Emit debugging info.
4072 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4073 (EmitContext.OmitDebuggingInfo): New public property.
4076 (While): Override Emit() and don't emit symbol info there; do it
4077 inside DoEmit() instead.
4078 (Block.Emit): Omit symbol information while emitting the scope
4079 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4081 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4082 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4083 .ctor to make `IsIterator' work.
4085 2008-03-14 Martin Baulig <martin@ximian.com>
4087 * symbolwriter.cs: Added the new symbol writer function from the
4088 debugger's `terrania' branch; temporarily enclose them inside
4089 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4092 2008-03-14 Martin Baulig <martin@ximian.com>
4095 (SymbolWriter): Make this a public static class.
4098 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4099 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4101 2008-03-14 Marek Safar <marek.safar@gmail.com>
4103 A fix for bug #370577
4104 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4107 2008-03-14 Marek Safar <marek.safar@gmail.com>
4109 * typemanager.cs (CSharpName): Made 250 times faster.
4111 2008-03-13 Marek Safar <marek.safar@gmail.com>
4113 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
4115 2008-03-12 Marek Safar <marek.safar@gmail.com>
4117 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
4118 crash when predefined field does not exist.
4120 2008-03-12 Marek Safar <marek.safar@gmail.com>
4122 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
4124 2008-03-12 Marek Safar <marek.safar@gmail.com>
4126 * class.cs (FixedField): Don't crash when contructors are missing.
4128 2008-03-11 Marek Safar <marek.safar@gmail.com>
4130 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
4131 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
4132 check internal types accessibility for internal and external types.
4133 Replaced EnumToUnderlying by GetEnumUnderlyingType.
4135 2008-03-11 Marek Safar <marek.safar@gmail.com>
4137 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
4138 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
4139 attribute.cs, statement: Use corect instance of predefined types (work
4140 related to #364674).
4142 2008-03-07 Marek Safar <marek.safar@gmail.com>
4144 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
4146 2008-03-07 Marek Safar <marek.safar@gmail.com>
4148 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
4149 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
4150 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
4151 predefined types clean up, delayed predefined types members initialization
4152 (work related to #364674).
4154 2008-03-05 Marek Safar <marek.safar@gmail.com>
4156 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
4158 2008-03-05 Marek Safar <marek.safar@gmail.com>
4160 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
4161 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
4162 predefined types clean up (work related to #364674).
4164 2008-03-04 Marek Safar <marek.safar@gmail.com>
4166 * ecore.cs: Print an error message instead of throwing exception.
4168 2008-03-04 Marek Safar <marek.safar@gmail.com>
4170 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
4171 expression.cs, statement.cs: Unififed null literal representation.
4173 2008-03-03 Marek Safar <marek.safar@gmail.com>
4175 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
4176 expression.cs: Refactored binary operators resolve phase and improved speed.
4177 The nullable code is still missing and won't work correctly, more fixes
4180 It also fixes #323726, #324312, #324248, and many other unreported issues.
4182 2008-02-29 Zoltan Varga <vargaz@gmail.com>
4184 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
4187 2008-02-27 Marek Safar <marek.safar@gmail.com>
4189 * ecore.cs: Clean-up and split BetterConversion.
4191 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
4194 * enum.cs (EnumMember.Value): Only access 'value' if
4195 ResolveValue says it's ok.
4196 (EnumMember.DoResolveValue): Don't set prev_member.value.
4197 (Enum.GetDefinition): Reverse arguments of Equals --
4198 EnumMember.Value can return 'null'.
4200 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
4202 2008-02-22 Marek Safar <marek.safar@gmail.com>
4204 * generic.cs, expression.cs: More ongoing work on expression trees.
4206 2008-02-21 Marek Safar <marek.safar@gmail.com>
4208 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
4209 handle missing matches when mutiple operators exist.
4211 2008-02-20 Marek Safar <marek.safar@gmail.com>
4213 A fix for bug #363218
4214 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
4217 2008-02-20 Marek Safar <marek.safar@gmail.com>
4219 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
4220 update. This time to deal correctly with SideEffectConstant expression used
4221 as an argument for another constant folding.
4223 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
4225 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
4228 2008-02-19 Marek Safar <marek.safar@gmail.com>
4230 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
4232 2008-02-19 Marek Safar <marek.safar@gmail.com>
4234 A fix for bug #328136
4235 * expression.cs: Do not fold immediately LogicalAnd operators when the left
4236 side is a false constant, because we still need to evaluate the right-hand
4239 * statement.cs (If): Emit two types of boolean constants (simple constant,
4240 side-effect constant).
4242 2008-02-19 Marek Safar <marek.safar@gmail.com>
4244 * constant.cs (SideEffectConstant): Don't emit boolean constant.
4246 * expression.cs: Fold immediately LogicalAnd operators when both sides are
4249 2008-02-18 Marek Safar <marek.safar@gmail.com>
4251 A fix for bug #361457
4252 * ecore.cs (IsApplicable): Params methods have lower priority.
4254 * support.cs: Return correct parameter modifier for params types.
4256 2008-02-18 Marek Safar <marek.safar@gmail.com>
4258 * generic.cs (TypeParameter): Cache attribute target name.
4260 * support.cs: Removed unused variable.
4262 * typemanager.cs: Removed debugging leftover.
4264 * ecore.cs: Use local type instead of a property;
4266 * class.cs (VerifyMembers): Consider also parent to test whether type member
4269 * expression.cs (FullMethodDesc): Removed.
4271 * attribute.cs (IsValidArgumentType): Made static.
4273 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
4275 Cleanup to be more readable.
4276 * Makefile (GMCS_PROFILE): Remove.
4277 (COMPILER_NAME): New helper.
4279 2008-02-15 Miguel de Icaza <miguel@novell.com>
4281 * cs-tokenizer.cs: if a conditional expression happens inside a
4282 (...) this also means that we do not need to de-ambiguate between
4283 an parenthesized expression and a cast.
4287 * constant.cs (SideEffectConstant): a constant value that happens
4288 to have a side effect.
4290 Fixes the build regressions introduced by the fix for #359789
4292 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
4294 * expression.cs (Conditional.Emit): when emitting the ternary
4295 operator, use local variables to generate code verifiable code.
4297 The verifier cannot infer that the type on stack before the
4298 stloc.0 is executed is of type ParentB. This happens because the
4299 stack merge algorithm uses only parent types when deciding which
4300 is the common type. This is described in Part III 1.8.1.3 of ECMA
4303 This code compiled with mcs is not verifiable under MS. The MS
4304 verifier picks the first common interface of Foo and Bar, which is
4305 wrong, but doesn't use a full join type of the 2 interfaces.
4307 CSC uses a clever hack to compile such code in a verifiable
4308 way. It stores the intermediate values in a local variable with
4313 2008-02-14 Miguel de Icaza <miguel@novell.com>
4315 * expression.cs: Do not fold BitwiseAnd operators when the left
4316 side is a false constant, because we still need to evaluate the
4321 * support.cs: Instead of throwing an InternalErrorException when
4322 the position of the stream is outside the boundary of our buffer,
4323 reset the state of the reader, and restart the reading from the
4324 beginning of the file.
4326 2008-02-14 Marek Safar <marek.safar@gmail.com>
4328 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
4330 2008-02-14 Marek Safar <marek.safar@gmail.com>
4332 A fix for bug #361686
4333 * decl.cs: A protected types used inside a private class which parents
4334 derives from the protected class are accessible.
4336 2008-02-13 Marek Safar <marek.safar@gmail.com>
4338 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
4339 the parameterless constructor.
4341 2008-02-13 Marek Safar <marek.safar@gmail.com>
4343 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
4344 lookup methods to use standard member cache when doing member lookup.
4346 2008-02-12 Marek Safar <marek.safar@gmail.com>
4348 * driver.cs: Don't report full path for referenced module as assembly error.
4350 2008-02-12 Marek Safar <marek.safar@gmail.com>
4352 * Makefile: Fixed `qh' target to work on all machines.
4354 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
4355 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
4356 and HasElementType with TypeManager implementation.
4358 2008-02-08 Marek Safar <marek.safar@gmail.com>
4360 A fix for bugs #325134, #359749
4361 * expression.cs, ecore.cs: Try to resolve an extension method even if the
4362 first binds point to non-method member expression.
4364 2008-02-08 Marek Safar <marek.safar@gmail.com>
4366 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
4368 2008-02-08 Marek Safar <marek.safar@gmail.com>
4370 A fix for bugs #321394, #323028
4371 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
4372 Reworked naive IsAccessibleAs implementation to handle nested types.
4374 2008-02-05 Jb Evain <jbevain@novell.com>
4376 * class.cs: use generic type comparison for parameters
4379 2008-02-05 Marek Safar <marek.safar@gmail.com>
4381 A fix for bug #325372
4382 * class.cs: Use generic type comparison when testing method signatures.
4384 2008-02-05 Marek Safar <marek.safar@gmail.com>
4386 A fix for bug #357047
4387 * ecore.cs: Applied C# 3.0 changes to better conversion.
4389 2008-02-05 Marek Safar <marek.safar@gmail.com>
4391 A fix for bug #358374
4392 * cs-parser.jay: Correctly set modifiers for all constructor types.
4394 2008-02-04 Marek Safar <marek.safar@gmail.com>
4396 A fix for bug #355251
4397 * generic.cs: Added base class constraint based type inference.
4399 2008-02-01 Marek Safar <marek.safar@gmail.com>
4401 A fix for bug #357255
4402 * decl.cs: One more missing visibility check.
4404 2008-02-01 Marek Safar <marek.safar@gmail.com>
4406 * support.cs: Fixed broken return.
4408 2008-01-25 Marek Safar <marek.safar@gmail.com>
4410 * report.cs: Correctly reset warnings count after probing.
4412 2008-01-25 Martin Baulig <martin@ximian.com>
4415 (NamespaceEntry.SymbolFileID): Make this work again after
4416 MemberName.ToString() is gone.
4418 2008-01-25 Marek Safar <marek.safar@gmail.com>
4420 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
4423 2008-01-25 Marek Safar <marek.safar@gmail.com>
4425 * generic.cs: Use full implicit conversion for type inference fixing.
4427 2008-01-24 Marek Safar <marek.safar@gmail.com>
4429 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
4430 Fixed user operator conversions.
4432 2008-01-24 Marek Safar <marek.safar@gmail.com>
4434 * generic.cs: Do nullable type to null comparison optimization during
4437 2008-01-24 Marek Safar <marek.safar@gmail.com>
4439 A fix for bug #355163
4440 * generic.cs: Enabled l-value resolve on nullable expressions.
4442 2008-01-24 Marek Safar <marek.safar@gmail.com>
4444 A fix for bug #353986
4445 * class.cs: Ingore static ctors with parameters for any further checks.
4447 2008-01-24 Marek Safar <marek.safar@gmail.com>
4449 A fix for bug #354310
4450 * namespace.cs: Removed redundant check.
4452 2008-01-24 Marek Safar <marek.safar@gmail.com>
4454 A fix for bug #354928
4455 * expression.cs: ElementInitializers can be resolved only once.
4457 2008-01-24 Marek Safar <marek.safar@gmail.com>
4459 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
4460 Condition expressions.
4462 2008-01-23 Marek Safar <marek.safar@gmail.com>
4464 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
4466 2008-01-22 Marek Safar <marek.safar@gmail.com>
4468 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
4471 * generic.cs: Implemented coalesce expression.
4473 2008-01-22 Marek Safar <marek.safar@gmail.com>
4475 A fix for bug #355145
4476 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
4477 expression tree type inference.
4479 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
4482 * expression.cs (Binary.IsUnsignedType): Fix typo.
4484 2008-01-22 Marek Safar <marek.safar@gmail.com>
4486 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
4488 2008-01-22 Marek Safar <marek.safar@gmail.com>
4490 A fix for bug #355161
4491 * ecore.cs, expression.cs: Wider range of extension method supported
4494 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
4496 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
4497 AssemblyBuilder to operate in compiler context. Fixes mcs part of
4500 2008-01-22 Marek Safar <marek.safar@gmail.com>
4502 A fix for bug #355148
4503 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
4505 2008-01-22 Miguel de Icaza <miguel@novell.com>
4507 * expression.cs (CreateExpressionTree): Add support for or and
4508 logical or, and indent following the coding conventions.
4510 * typemanager.cs (LinqExpression): renamed from
4511 ExpressionTreeManager, for a shorter name.
4513 Use TypeManager.CoreLookupType to lookup types from our core
4514 assemblies and turn those into "Type" variables.
4516 Consumers that previously used "Namespace" and "Type" from this
4517 class should instead use the TypeExpression which is a type that
4518 is fully resolved (without involving the regular C# resolution
4521 This typically looks like this:
4523 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
4524 new MemberAccess (texpr, name, type_arguments, loc)
4526 This avoids the problem in: #355178
4528 2008-01-21 Marek Safar <marek.safar@gmail.com>
4530 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
4531 feature in parser only as we do in other cases.
4533 2008-01-21 Marek Safar <marek.safar@gmail.com>
4535 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
4536 typemanager.cs: A refactoring of params arguments to reuse existing
4537 expressions (params -> array initializer) to emit params argument instead
4538 of specialized handling.
4539 It was required by expression tree implementation and it has other benefits
4540 as well, we now apply same optimization for params arguments as we do for
4543 2008-01-18 Marek Safar <marek.safar@gmail.com>
4545 A fix for bug #353526
4546 * generic.cs: A type inference of params arguments may not required any
4547 temporary array creation.
4549 2008-01-18 Marek Safar <marek.safar@gmail.com>
4551 A fix for bug #353534
4552 * generic.cs, ecore.cs, expression.cs: A method group type inference is
4553 supported for delegates only.
4555 2008-01-18 Marek Safar <marek.safar@gmail.com>
4557 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
4558 type for more than 1 candidates.
4560 2008-01-18 Marek Safar <marek.safar@gmail.com>
4562 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
4565 2008-01-16 Marek Safar <marek.safar@gmail.com>
4567 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
4568 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
4569 operator) expressions.
4571 2008-01-16 Zoltan Varga <vargaz@gmail.com>
4573 * statement.cs: Avoid declaring an IL variable for this_variable since it is
4574 not accessed from the generated IL.
4576 2008-01-14 Marek Safar <marek.safar@gmail.com>
4578 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
4579 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
4580 statement.cs: The first expression tree implementation drop, mostly
4581 infrastructure work.
4583 2008-01-14 Marek Safar <marek.safar@gmail.com>
4585 * ecore.cs (IsNestedChild): Refactored.
4587 2008-01-11 Marek Safar <marek.safar@gmail.com>
4589 * lambda.cs: Don't use a cast on unknown expression statement.
4591 2008-01-10 Geoff Norton <gnorton@novell.com>
4593 * cs-tokenizer.cs: One more token to distinguish between method and lambda
4596 2008-01-09 Marek Safar <marek.safar@gmail.com>
4598 * doc.cs: Report better /doc crash details.
4600 2008-01-09 Marek Safar <marek.safar@gmail.com>
4602 A fix for bug #352536
4603 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
4605 2008-01-08 Marek Safar <marek.safar@gmail.com>
4607 A fix for bug #352287
4608 * ecore.cs, expression.cs: Do `this' access checking in all member access
4611 2008-01-08 Marek Safar <marek.safar@gmail.com>
4613 * rootcontext.cs, driver.cs: Switch to linq mode by default.
4615 * report.cs: Reset message stacks.
4617 2008-01-08 Marek Safar <marek.safar@gmail.com>
4619 * generic.cs (InferInPhases): Correctly calculate params position.
4621 2008-01-08 Marek Safar <marek.safar@gmail.com>
4623 * cs-tokenizer.cs: No need to parse full string when parsing lambda
4626 2008-01-07 Marek Safar <marek.safar@gmail.com>
4628 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
4630 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
4632 * driver.cs: Updated --help option.
4634 2008-01-07 Marek Safar <marek.safar@gmail.com>
4636 * generic.cs (InferParamsTypeArguments): Removed.
4637 (InferInPhases): Add params type inference.
4638 (LowerBoundInference): Fixed scoring mechanism.
4640 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
4642 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
4644 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
4645 byte array for unsigned "baked" assemblies.
4647 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
4649 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
4650 array for assemblies that are not strongnamed.
4652 2008-01-04 Marek Safar <marek.safar@gmail.com>
4654 A fix for bug #351481
4655 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
4656 declaring type for nested generic types.
4658 2008-01-04 Marek Safar <marek.safar@gmail.com>
4660 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
4661 instead of ToString.
4663 2008-01-03 Marek Safar <marek.safar@gmail.com>
4665 A fix for bug #351047
4666 * expression.cs (Binary.ResolveOperator): Allow equality operators between
4667 null and structs only when equality and inequality operators are defined
4668 either as an user-operators or predefined operators.
4670 2008-01-03 Marek Safar <marek.safar@gmail.com>
4672 A fix for bug #351047
4673 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
4675 2008-01-03 Marek Safar <marek.safar@gmail.com>
4677 A fix for bug #351257
4678 * cs-tokenizer.cs: Advance line number for '\r' correctly.
4680 2008-01-03 Marek Safar <marek.safar@gmail.com>
4682 A fix for bug #351157
4683 * class.cs (Using): Fixed yet another broken cloning.
4685 (Block): Put back more sensible default value for statements.
4687 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
4689 * codegen.cs: Allow AssemblyVersion with only major version component.
4692 2007-12-29 Marek Safar <marek.safar@gmail.com>
4694 A fix for bug #324654
4695 * class.cs: Use FullName property as member name.
4697 2007-12-28 Marek Safar <marek.safar@gmail.com>
4699 A fix for bug #342117
4700 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
4701 constructor constraint.
4703 2007-12-28 Marek Safar <marek.safar@gmail.com>
4705 A fix for bug #338273
4706 * class.cs (ProbertyBase): Access modifier checks are required for overrides
4709 2007-12-28 Marek Safar <marek.safar@gmail.com>
4711 A fix for bug #350839
4712 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
4714 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
4716 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
4719 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
4721 * statement.cs: Changed some Hashtables to use HybridDictionaries
4722 instead. It was observed that some HashTables only contained a few
4723 items in the vast majority of cases. Since HybridDictionary is
4724 more efficient on small sets (<10 elements), "known_variables"
4725 from class ExplicitBlock as well as "labels" and "constants " from
4726 class Block were changed to HybridDictionaries.
4728 Atsai results: (56216kb->54987kb)
4730 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
4733 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
4735 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
4738 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
4740 * expression.cs: foreach loop to for loop, saved on allocation of
4741 enumerator (59333kb->59141kb)
4743 * statement.cs. Changed foreach loops to for loops, saved on
4744 allocation of enumerator (59141kb->59006kb)
4746 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
4747 when constructed with no specified capacity. This was causing a
4748 few ArrayLists to allocate more memory than they would potentially
4749 need in the Block class and MemberCache class. Setting the
4750 ArrayLists to construct with a capacity of 1 saves some
4751 memory. (56216kb->55585kb)
4753 2007-12-27 Marek Safar <marek.safar@gmail.com>
4755 A fix for bug #347189 (2nd issue)
4756 * expression.cs (MemberAccess): Nested type can be found in base non-generic
4759 2007-12-27 Miguel de Icaza <miguel@novell.com>
4761 * report.cs: Do not use colors if stdout and stderr are not a
4764 2007-12-27 Marek Safar <marek.safar@gmail.com>
4766 A fix for bug #346998
4767 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
4770 2007-12-27 Marek Safar <marek.safar@gmail.com>
4772 A fix for bug #343465
4773 * class.cs: Explicit method name for nested types uses dots only.
4775 2007-12-27 Marek Safar <marek.safar@gmail.com>
4777 A fix for bug #343707
4778 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
4780 2007-12-27 Marek Safar <marek.safar@gmail.com>
4782 * ecore.cs: Report type inference errors only when arguments count matches
4785 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
4787 * expression.cs, report.cs: New warning.
4789 * typemanager.cs: Catch anonymous method type too.
4791 2007-12-23 Marek Safar <marek.safar@gmail.com>
4793 A fix for bug #346379
4794 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
4796 2007-12-23 Marek Safar <marek.safar@gmail.com>
4798 A fix for bug #347359
4799 * expression.cs (Invocation): Don't resolve already resolved expression.
4801 2007-12-23 Marek Safar <marek.safar@gmail.com>
4803 A fix for bug #347189
4804 * class.cs (FixedField): Use non-dependent code only in the define phase.
4806 2007-12-23 Marek Safar <marek.safar@gmail.com>
4808 A fix for bug #348076
4809 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
4811 2007-12-22 Marek Safar <marek.safar@gmail.com>
4813 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
4814 discovered extension methods.
4816 2007-12-22 Marek Safar <marek.safar@gmail.com>
4818 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
4821 2007-12-21 Miguel de Icaza <miguel@novell.com>
4823 * report.cs (ErrorMessage): Add support for using colors on
4824 terminals that support it.
4826 2007-12-21 Marek Safar <marek.safar@gmail.com>
4828 * ecore.cs: Use information about expanded params for error reporting.
4830 2007-12-21 Marek Safar <marek.safar@gmail.com>
4832 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
4833 and logic for params overloads.
4835 2007-12-15 Miguel de Icaza <miguel@novell.com>
4837 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
4838 as this is also created from the parser. Fixes #349034
4840 2007-12-12 Miguel de Icaza <miguel@novell.com>
4842 * statement.cs (Throw.CloneTo): it is valid to have empty
4843 expressions for throw.
4845 2007-12-03 Marek Safar <marek.safar@gmail.com>
4847 * cs-parser.jay: Set delegate constraint parsing region correctly.
4849 2007-12-03 Marek Safar <marek.safar@gmail.com>
4851 A fix for bug #345467
4852 * typemanager.cs (IsEqual): Compare generic parameters position only.
4854 2007-11-28 Marek Safar <marek.safar@gmail.com>
4856 * expression.cs (BaseAccess): Type arguments can be null.
4858 2007-11-27 Raja R Harinath <harinath@gmail.com>
4860 * statement.cs (Block.Resolve): Ensure flow-branching tree is
4861 consistent even when an error has occured.
4862 (Switch.Resolve): Likewise.
4864 2007-11-22 Marek Safar <marek.safar@gmail.com>
4866 A fix for bug #334505
4867 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
4870 2007-11-22 Marek Safar <marek.safar@gmail.com>
4872 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
4873 refactorings required to resolve extension methods correctly when mixing
4874 generics and non-generics members.
4876 2007-11-20 Marek Safar <marek.safar@gmail.com>
4878 A fix for bug #342584
4879 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
4882 2007-11-19 Marek Safar <marek.safar@gmail.com>
4884 A fix for bug #342512
4885 * delegate.cs: Use delegate argument expression when is available. Don't
4886 emit virtual call when class is sealed.
4888 2007-11-16 Marek Safar <marek.safar@gmail.com>
4890 A fix for bug #325423
4891 * assign.cs (FieldInitializer): Use resolved expression for emit.
4893 * class.cs: Print less confusing error message.
4895 2007-11-16 Marek Safar <marek.safar@gmail.com>
4897 * cs-tokenizer.cs: Removed GMCS ifdefs.
4899 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
4902 * cs-parser.jay: Disabled nullable check.
4904 * generic-mcs: Copied more generic stuff.
4906 2007-11-16 Marek Safar <marek.safar@gmail.com>
4908 * gcs-parser.jay: Merged to cs-parser.jay.
4910 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
4911 * *.csproj, *.sources: Updated to use only jay parser file.
4913 2007-11-16 Marek Safar <marek.safar@gmail.com>
4915 * gcs-parser.jay: Added nullable and default expression feature checks.
4917 2007-11-16 Marek Safar <marek.safar@gmail.com>
4919 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
4920 it fixes many TODOs and hidden bugs.
4922 * expression: Removed duplicate error check.
4924 2007-11-15 Marek Safar <marek.safar@gmail.com>
4926 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
4927 implicitly type local variable only when it is used in a declaration.
4929 2007-11-15 Marek Safar <marek.safar@gmail.com>
4931 * attribute.cs: Use CS0612 for empty strings.
4933 2007-11-14 Marek Safar <marek.safar@gmail.com>
4935 * lambda.cs, statement.cs: Contextual return may act as a statement.
4937 2007-11-14 Marek Safar <marek.safar@gmail.com>
4939 A fix for a regression cause by #324222
4940 * class.cs: Don't report unused even when it implements an interface.
4942 2007-11-13 Marek Safar <marek.safar@gmail.com>
4944 A fix for bug #341205
4945 * ecore.cs, expression.cs: Method group expression cannot do static
4946 method access with an instance reference check before overloading takes
4949 2007-11-13 Marek Safar <marek.safar@gmail.com>
4951 A fix for bug #325359
4952 * class.cs: Use predictable name for automatically generated property.
4954 2007-11-12 Marek Safar <marek.safar@gmail.com>
4956 A fix for bug #324996
4957 * expression.cs (Is): Handle case where D is nullable and T is not
4960 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
4962 2007-11-12 Marek Safar <marek.safar@gmail.com>
4964 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
4965 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
4966 Flush small error reporting changes.
4968 2007-11-09 Marek Safar <marek.safar@gmail.com>
4970 A fix for bug #324996
4971 * expression.cs: Rewrote Is expression implementation to work with
4972 generics, nullable types, anonymous method. A const result expression
4973 uses existing infrastructure instead of custom not fully-featured one.
4975 2007-11-08 Marek Safar <marek.safar@gmail.com>
4977 A fix for bug #340202
4978 * class.cs: Consider generics for volatile field.
4980 2007-11-08 Marek Safar <marek.safar@gmail.com>
4982 A fix for bug #335594
4983 * expression.cs: Use conversion rules when handling string addition.
4985 2007-11-07 Marek Safar <marek.safar@gmail.com>
4987 A fix for bug #336651
4988 * expression.cs: Fixed a crash when probing is on.
4990 2007-11-07 Marek Safar <marek.safar@gmail.com>
4992 A fix for bug #324242
4993 * covert.cs: Added a conversion from any nullable-type with an
4994 underlying enum-type to the type System.Enum.
4996 2007-11-07 Marek Safar <marek.safar@gmail.com>
4998 A fix for bug #324222
4999 * class.cs: Report all non-used event fields.
5001 2007-11-07 Marek Safar <marek.safar@gmail.com>
5003 A fix for bug #325161
5004 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5005 qualifier for generic types.
5007 2007-11-07 Marek Safar <marek.safar@gmail.com>
5009 A fix for bug #322971
5010 * expression.cs, ecore.cs: Added intermediate result value check for
5013 2007-11-07 Marek Safar <marek.safar@gmail.com>
5015 A fix for bug #324754
5016 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5017 when it was requested.
5019 2007-11-07 Marek Safar <marek.safar@gmail.com>
5021 A fix for bug #325101
5022 * expression.cs: Do type not value comparison for `is' expression.
5024 2007-11-07 Marek Safar <marek.safar@gmail.com>
5026 A fix for bug #320236
5027 * convert.cs: Don't apply user conversion on underlying target type.
5029 2007-11-06 Marek Safar <marek.safar@gmail.com>
5031 * expression.cs: Don't use unresolved expression for error reporting.
5033 2007-11-06 Marek Safar <marek.safar@gmail.com>
5035 A fix for bugs #337712, #324490
5036 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5037 overloading resolution too.
5039 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5040 the process consistent and more robust.
5042 * expression.cs, linq.cs, report.cs: Update.
5044 2007-11-02 Marek Safar <marek.safar@gmail.com>
5046 A fix for bug #332909
5047 * attribute.cs: Resolve attributes in correct context using error
5050 * rootcontext.cs: Define Obsolete attribute members as core members.
5052 2007-11-02 Marek Safar <marek.safar@gmail.com>
5054 * statement.cs: Removed unused methods.
5056 2007-10-31 Wade Berrier <wberrier@novell.com>
5058 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5059 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5062 2007-10-31 Marek Safar <marek.safar@gmail.com>
5064 A fix for bug #338102
5065 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5066 methods registered as non-generics.
5068 2007-10-31 Marek Safar <marek.safar@gmail.com>
5070 A fix for bugs #337712, #324490
5071 * delegate.cs: Delegate covariance and contravariance is not allowed for
5074 2007-10-31 Marek Safar <marek.safar@gmail.com>
5076 A fix for bug #337719
5077 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5080 2007-10-30 Marek Safar <marek.safar@gmail.com>
5082 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5084 2007-10-29 Marek Safar <marek.safar@gmail.com>
5086 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5089 2007-10-29 Raja R Harinath <rharinath@novell.com>
5091 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5093 2007-10-29 Marek Safar <marek.safar@gmail.com>
5095 A fix for bug #334652
5096 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5097 extension methods when we have not found the best candidate in normal
5100 2007-10-27 Marek Safar <marek.safar@gmail.com>
5102 * AssemblyInfo.cs: Keep up-to-date.
5104 2007-10-27 Marek Safar <marek.safar@gmail.com>
5106 * Makefile: Fixed generics compiler name.
5108 2007-10-27 Marek Safar <marek.safar@gmail.com>
5110 * lambda.test: removed, lambda parsing is done differently.
5112 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
5114 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
5116 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
5118 2007-10-27 Marek Safar <marek.safar@gmail.com>
5120 * Makefile, *.sources : All C# compilers are in mcs folder.
5122 * *.cs: Use existing 2_1 define for smcs.
5124 2007-10-26 Marek Safar <marek.safar@gmail.com>
5126 A fix for bug #335847
5127 * assign.cs, expression.cs: Couple of changes to avoid creating a
5128 temporary variable for each object initializer assignment statement. It
5129 simplifies struct initialization too, otherwise two temporary variables
5131 Implemented optimization of redundant default element initializers.
5133 2007-10-25 Marek Safar <marek.safar@gmail.com>
5135 A fix for bug #336766
5136 * expression.cs (Class.CheckBase): Use generic name when method is
5139 2007-10-25 Marek Safar <marek.safar@gmail.com>
5141 A fix for bug #334737
5142 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
5143 variable and not variable argument for prepared copies.
5145 2007-10-24 Marek Safar <marek.safar@gmail.com>
5147 A fix for bug #325110
5148 * class.cs, expression.cs, attribute.cs: Use open generic method when
5149 checking conditional attribute.
5151 2007-10-24 Marek Safar <marek.safar@gmail.com>
5153 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
5154 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
5155 FeatureIsNotAvailable.
5157 2007-10-24 Marek Safar <marek.safar@gmail.com>
5159 ** C# 3.0 Partial methods
5161 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
5162 methods support. Because of member cache issue with generics only
5163 non-generics partial methods are fully supported.
5165 2007-10-23 Marek Safar <marek.safar@gmail.com>
5167 * class.cs, decl.cs: Rewrote member overloads check to cope with
5168 generics and to use member cache for member checking. It also improves
5169 performance and fixes remaining overloads issues.
5171 2007-10-20 Marek Safar <marek.safar@gmail.com>
5173 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
5174 roottypes.cs, typemanager.cs:
5176 A member cache creation logic changed to add members immediately and
5177 not rely on fallback. The member cache is now only prefered way
5178 how to access and find type declaration members. It saves 5 MB of memory
5179 during MWF compilation and makes code ready for more optimizations and
5180 clean-ups, it's also a pre-requirement for partial methods.
5182 2007-10-18 Raja R Harinath <harinath@gmail.com>
5184 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
5185 handling for generic parameters.
5187 2007-10-15 Marek Safar <marek.safar@gmail.com>
5189 * class.cs (FixedField): Removed redundant volatile check.
5191 2007-10-15 Marek Safar <marek.safar@gmail.com>
5193 * class.cs, decl.cs: Fixed overload members verification to do only one
5194 check per possible collision.
5196 2007-10-13 Marek Safar <marek.safar@gmail.com>
5198 A fix for bug #325478
5199 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
5200 and create only one disposable flags container.
5202 2007-10-12 Marek Safar <marek.safar@gmail.com>
5204 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
5205 * statement.cs (Fixed): Fixed variables cloning.
5207 2007-10-12 Marek Safar <marek.safar@gmail.com>
5209 A fix for bug #333342
5210 * class.cs (EventField): Don't mark value type event as synchronized.
5212 2007-10-12 Marek Safar <marek.safar@gmail.com>
5214 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
5215 inference to identify best candidate method correctly.
5216 (ProperyExpr): A range variable is read only and cannot be modified.
5218 2007-10-11 Marek Safar <marek.safar@gmail.com>
5220 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
5221 logic to identify best candidate method correctly.
5223 2007-10-11 Marek Safar <marek.safar@gmail.com>
5225 * location.cs (Equals, GetHashCode): Removed.
5227 2007-10-11 Marek Safar <marek.safar@gmail.com>
5229 * report.cs: Implemented message recorder. It is used mainly for lambda
5230 expressions to capture otherwise swallowed error messages.
5232 * anonymous.cs, lambda.cs.cs: Do full parameters check.
5234 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
5236 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
5238 * expression.cs (MemberAccess): Always report lookup failure.
5240 * location.cs: Implemented Equals, GetHashCode.
5242 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
5244 2007-10-10 Jb Evain <jbevain@novell.com>
5246 * codegen.cs: re-enable assembly version check.
5248 2007-10-09 Marek Safar <marek.safar@gmail.com>
5250 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
5253 * namespace.cs (UsingAlias): Do correct version check.
5255 2007-10-08 Marek Safar <marek.safar@gmail.com>
5257 * expresison.cs, ecore.cs: Issue extension method error message when
5260 * rootcontext.cs: Added ISO_2 compiler mode option.
5262 2007-10-08 Marek Safar <marek.safar@gmail.com>
5264 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
5267 2007-10-08 Marek Safar <marek.safar@gmail.com>
5269 * attribute.cs (GetString, GetBoolean): Work with both literal and
5272 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
5273 Moved method overload specific methods to MethodGroupExpr.
5275 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
5276 it should be less memory consuming.
5278 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
5280 * codegen.cs: remove the assembly version check until the buildbot is
5283 2007-10-07 Jb Evain <jbevain@novell.com>
5285 * attribute.cs (Attribute.GetString): if the value
5286 expression is a StringConstant, return its string value.
5288 2007-10-07 Jb Evain <jbevain@novell.com>
5290 * typemanager.cs: add `assembly_version_attribute_type`.
5291 * codegen.cs: on attribute emission, check that the
5292 AssemblyVersionAttribute doesn't overflow.
5294 2007-10-05 Marek Safar <marek.safar@gmail.com>
5296 A fix for bug #324677
5297 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
5298 parent container of a scope container with currently resolved one.
5300 2007-10-05 Marek Safar <marek.safar@gmail.com>
5302 A fix for bug #325534
5303 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
5306 2007-10-05 Marek Safar <marek.safar@gmail.com>
5308 A fix for bug #327504
5309 * class.cs (Operator.Define): Refactored implicit and explicit user
5310 operator conversion rules.
5312 2007-10-05 Marek Safar <marek.safar@gmail.com>
5314 A fix for bug #327520
5315 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
5317 2007-10-04 Marek Safar <marek.safar@gmail.com>
5319 A fix for bug #328022
5320 * class.cs (MethodData.Define): Use correct method to check whether
5321 a method implementents an accessor.
5323 2007-10-04 Marek Safar <marek.safar@gmail.com>
5325 A fix for bug #330069
5326 * statement.cs (Fixed.Resolve): Read the first array element only when
5327 an array is instantiated.
5329 2007-10-04 Marek Safar <marek.safar@gmail.com>
5331 * expression.cs, assign.cs, generics.cs: Print correct operator when
5332 compound assignment is used.
5334 2007-10-04 Marek Safar <marek.safar@gmail.com>
5336 A fix for bug #325841
5337 * expression.cs (ArrayAccess): Use full argument cloning only for
5338 string compound concatenation.
5340 2007-10-03 Marek Safar <marek.safar@gmail.com>
5342 A fix for bug #328774
5343 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
5345 (PropertyExpr.EmitAssign): Fixed string concatenation compound
5348 2007-10-03 Raja R Harinath <rharinath@novell.com>
5351 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
5352 Event accessibility checks here. Remove some bogus code that
5353 accidently made GenericMethods work.
5354 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
5356 2007-09-25 Marek Safar <marek.safar@gmail.com>
5358 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
5360 * statement.cs (Block): Refactored AddVariable to allow error handling
5363 * generic.cs: New stub.
5365 2007-09-23 Marek Safar <marek.safar@gmail.com>
5367 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
5370 2007-09-17 Marek Safar <marek.safar@gmail.com>
5372 * class.cs: Use partial container to record whether any partial part
5373 contains static field initializer and therefore default contructor has
5376 2007-09-14 Marek Safar <marek.safar@gmail.com>
5378 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
5379 mono-list when only one of two partial parts has defined accessibility
5382 2007-09-14 Marek Safar <marek.safar@gmail.com>
5384 A fix for bug #82845
5386 * class.cs (TypeContainer): Set correct resolve context for all field
5389 2007-09-13 Marek Safar <marek.safar@gmail.com>
5391 * assign.cs: Fixed a crash when field is resolved twice with an error.
5393 * codegen.cs: Changed InFieldInitializer to be flag.
5395 * anonymous.cs, ecore.cs, expression.cs: Update after
5396 IsInFieldInitializer rename.
5398 * const.cs: Removed unused parameter.
5400 * class.cs: Changed the way how we resolve and emit field initializers.
5401 The field initilizers have to have access to contructor block to emit
5402 compiler generated code.
5404 2007-09-13 Marek Safar <marek.safar@gmail.com>
5406 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
5407 generics use TypeContainer instead.
5409 2007-09-12 Marek Safar <marek.safar@gmail.com>
5411 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
5413 * lambda.cs (ResolveParameters): Use more powerful
5414 InflateGenericArgument.
5416 * parameters.cs: Better exception message.
5418 2007-09-10 Marek Safar <marek.safar@gmail.com>
5420 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
5421 correct expression block type.
5423 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
5425 * expression.cs (Invocation): Extracted method group resolve to
5428 2007-09-07 Marek Safar <marek.safar@gmail.com>
5430 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
5431 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
5433 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
5434 generic extension methods.
5436 2007-09-06 Marek Safar <marek.safar@gmail.com>
5438 A fix for bug #82676 (Do I get it right now?)
5439 * convert.cs (Binary.ResolveOperator): An interface is converted to the
5440 object before a standard conversion is applied.
5442 2007-09-06 Marek Safar <marek.safar@gmail.com>
5444 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
5447 2007-09-05 Marek Safar <marek.safar@gmail.com>
5449 A fix for bug #82676
5450 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
5451 non-generic interface types.
5453 2007-09-05 Marek Safar <marek.safar@gmail.com>
5455 A fix for bug #82690
5456 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
5458 2007-09-05 Marek Safar <marek.safar@gmail.com>
5460 A fix for bug #82571
5461 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
5462 modifier for container based methods.
5464 2007-09-05 Marek Safar <marek.safar@gmail.com>
5466 A fix for bug #82676
5467 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
5468 any interface-type T means to any of interface type T.
5470 2007-09-04 Marek Safar <marek.safar@gmail.com>
5472 * namespace.cs: We have 2 versions of System.Core assembly.
5474 2007-09-04 Marek Safar <marek.safar@gmail.com>
5476 A fix for bug #82652
5477 * class.cs (Class.GetClassBases): Compare types and not expressions.
5479 2007-09-04 Marek Safar <marek.safar@gmail.com>
5481 A fix for bug #82620
5482 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
5483 actually never worked before.
5484 (IndexerAccess): Emit prepared arguments before they are modified.
5486 2007-09-04 Marek Safar <marek.safar@gmail.com>
5488 A fix for bug #82563
5489 * assign.cs: Revert wrong fix.
5491 * expression.cs (VariableReference.EmitAssign): Handle ref reference
5493 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
5494 Instead of ldelema/stdind we have to use temporary variables to handle
5495 cases like String.Concat (params string[]).
5497 2007-08-31 Marek Safar <marek.safar@gmail.com>
5499 * class.cs: EmitAttributes to Emit rename.
5501 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
5503 (MemberCore.HasClsCompliantAttribute): Don't depend on
5504 GetClsCompliantAttributeValue execution.
5506 2007-08-31 Marek Safar <marek.safar@gmail.com>
5508 * anonymous.cs: Use shorter type prefix.
5510 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
5513 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
5514 variables when probing is on.
5516 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
5517 unresolved variables.
5518 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
5519 handle transparent identifiers.
5521 2007-08-26 Marek Safar <marek.safar@gmail.com>
5523 * attribute.cs (IsClsCompliant): Add nullable types test.
5525 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
5527 * doc.cs : catch other types of exception than XmlException to
5528 report CS1570. Fixed bug #82565.
5530 2007-08-23 Marek Safar <marek.safar@gmail.com>
5532 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
5533 The number of delegate parameters has to match.
5534 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
5537 2007-08-21 Marek Safar <marek.safar@gmail.com>
5539 * anonymous.cs (AnonymousMethod): Generate private anonymous method
5540 to fix problem with private arguments.
5542 2007-08-20 Marek Safar <marek.safar@gmail.com>
5544 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
5546 * decl.cs (MemberName): Ignore generic type with no generic arguments.
5548 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
5549 empty. Add cloning suport.
5551 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
5553 2007-08-20 Marek Safar <marek.safar@gmail.com>
5555 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
5556 to create EmptyCast. It handles EmptyConstantCast specialization for
5559 2007-08-18 Marek Safar <marek.safar@gmail.com>
5561 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
5562 (EmitArrayArgument): One routine for array arguments.
5563 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
5565 2007-08-17 Marek Safar <marek.safar@gmail.com>
5567 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
5569 2007-08-17 Marek Safar <marek.safar@gmail.com>
5571 * anonymous.cs: MemberLookupFinal update.
5573 * class.cs (ConstructorInitializer): Is expression based.
5575 * delegate.cs: MethodGroupExpr update.
5577 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
5579 (Error_MemberLookupFailed): Customizable error override.
5580 (MethodGroupExpr): Keep queried type for later usage.
5581 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
5584 * expression.cs: Error_MemberLookupFailed refactoring.
5585 (New.DoResolve): Resolve as much as possible.
5586 (ElementInitializer.Error_MemberLookupFailed): Object initializer
5587 customization for invalid member types.
5589 * statement.cs: MethodGroupExpr update.
5591 2007-08-16 Marek Safar <marek.safar@gmail.com>
5593 * modifier.cs (Check): Check all modifiers and not only accessibility
5596 2007-08-16 Marek Safar <marek.safar@gmail.com>
5598 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
5599 type and not an expression.
5601 2007-08-16 Marek Safar <marek.safar@gmail.com>
5603 * statement.cs (Catch.Clone): Type and variable can be null.
5605 2007-08-16 Marek Safar <marek.safar@gmail.com>
5607 A fix for bug #81979
5608 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
5609 I am really not sure whether this is the best fix.
5611 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
5614 2007-08-14 Marek Safar <marek.safar@gmail.com>
5616 ** C# 3.0 Object and collection initializers (major re-write)
5618 * assign.cs (DoResolve): Initializers are not assign related.
5620 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
5621 used during collection or object initialization.
5623 * expression.cs (Error_InvalidArguments): Add initializers specific
5624 messages. More will come later because it requires some general
5626 (New.DoResolve): Better error handling for unsafe types.
5627 (EmptyExpressionStatement): New class.
5628 (ElementInitializer): An object initializer expression.
5629 (CollectionElementInitializer): A collection initializer expression.
5630 (CollectionOrObjectInitializers): A block of object or collection
5632 (NewInitialize): New expression with element/object initializers.
5634 * statement.cs: Reverted object/collection initializer hacks.
5636 * typemanager.cs (CSharpName): Filter __arglist type.
5638 2007-08-09 Marek Safar <marek.safar@gmail.com>
5640 ** C# 3.0 Anonymous Types (update to the latest standard)
5642 * expression.cs (Binary.ResolveOperator): Threat all null based types
5644 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
5645 (AnonymousTypeParameter): Updated.
5647 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
5648 (AnonymousTypeClass): New anonymous type container.
5650 * class.cs (AddField): Return operation result.
5652 * generic.cs: Another empty TypeArguments overload.
5654 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
5655 are stored at top of normal hierarchy.
5657 * typemanager.cs (CSharpName): Filter anonymous types.
5659 2007-08-09 Marek Safar <marek.safar@gmail.com>
5661 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
5662 as single Concat call. How could we miss that :-(
5664 2007-08-08 Marek Safar <marek.safar@gmail.com>
5666 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
5668 2007-08-07 Miguel de Icaza <miguel@novell.com>
5670 * expression.cs: Fix the previous commit, the creation of the
5671 arguments array list needs also to be conditional on the arguments
5674 * class.cs: Add a little bit of help to help narrow down problems.
5676 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
5677 not try to copy in that case.
5679 * driver.cs: When building SMCS, include a new different set of
5680 default assemblies here. Do this here so we can control whether
5681 to include the default assemblies with /noconfig.
5683 2007-08-03 Marek Safar <marek.safar@gmail.com>
5685 A fix for bug #81979
5686 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
5689 2007-08-03 Marek Safar <marek.safar@gmail.com>
5691 A fix for bug #82300
5693 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
5694 we are in probing scope.
5696 2007-08-03 Marek Safar <marek.safar@gmail.com>
5698 A fix for bug #82301
5700 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
5701 (Statement.CloneTo): Clone and not map children blocks.
5703 2007-08-03 Marek Safar <marek.safar@gmail.com>
5705 A fix for bug #82299
5707 * expression.cs (LocalVariableReference.CloneTo): Remap local info
5710 * statement.cs (Statement.CloneTo): Clone variables before statements
5711 to allow remaping of local variables.
5713 2007-08-03 Marek Safar <marek.safar@gmail.com>
5715 A fix for bug #82296
5718 * report.cs: Log crash details for future clone problems.
5720 * statement.cs (Return.Clone): Don't clone non-existent expression.
5722 2007-08-03 Raja R Harinath <harinath@gmail.com>
5724 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
5725 (Class.AddBasesForPart): Move CS0537 check here from ...
5726 * cs-parser.jay (class_declaration): ... here. Move calling of
5727 'AddBasesForPart' to ...
5728 (class_bases): ... here.
5729 (struct_declaration, interface_declaration): Update to changes.
5731 2007-08-02 Marek Safar <marek.safar@gmail.com>
5733 A fix for bug #81923
5735 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
5736 conversion is allowed.
5738 2007-08-02 Marek Safar <marek.safar@gmail.com>
5740 A fix for bug #81564
5742 * ecore.cs (EventExpr): Add IsBase handling.
5744 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
5747 2007-08-02 Raja R Harinath <harinath@gmail.com>
5749 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
5750 * cs-parser.jay: Some whitespace cleanups.
5751 (current_delegate): New.
5753 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
5754 a dummy code block, and use 'type_name' instead of 'member_name'.
5755 (interface_declaration, class_declaration): Likewise.
5756 (delegate_declaration): Likewise. Rearrange slightly and use
5758 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
5759 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
5761 2007-08-02 Marek Safar <marek.safar@gmail.com>
5763 A fix for bug #82039
5765 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
5768 * typemanager.cs (CSharpName): Split to string overload.
5770 2007-08-02 Marek Safar <marek.safar@gmail.com>
5773 * report.cs: Updated warning CS0472.
5775 2007-08-01 Marek Safar <marek.safar@gmail.com>
5777 A fix for bug #82181
5779 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
5781 2007-08-01 Marek Safar <marek.safar@gmail.com>
5783 A fix for bug #82277
5784 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
5786 2007-08-01 Marek Safar <marek.safar@gmail.com>
5788 ** C# 3.0 Type Inference (major bits are working)
5790 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
5791 (.ImplicitStandardConversionExists): Uses compatible.
5792 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
5793 (.InferReturnType): New method.
5794 (.Compatible): Refactored.
5795 (.ResolveParameters): Uses factory to create resolved parameters.
5796 (.CompatibleMethod): Add probing mode support.
5797 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
5798 clearly distinguish between 2 different operations.
5799 (LambdaMethod): Moved to lambda.cs.
5800 (AnonymousMethod): Removed unused fields and methods.
5801 (AnonymousDelegate): Simplified.
5803 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
5805 * convert. cs (ImplicitConversionStandard): Compatible works differently.
5807 * delegate.cs (Delegate): New mehods to reduce code duplication.
5808 (.GetConstructor): New method.
5809 (.GetInvokeMethod): New method.
5810 (DelegateCreation): Updated.
5812 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
5814 (OverloadResolve): Made probing little bit faster.
5816 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
5819 * generic.cs (TypeInferenceContext): Dummy implementation.
5821 * iterators.cs: Updated after Resolve/Define rename.
5823 * lambda.cs (LambdaExpression)
5824 (.ResolveParameters): Handles both type of arguments and type inference too.
5826 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
5827 (InflateTypes): Updated.
5829 * support.cs (InflateTypes): Changed signature and updated.
5831 * typemanager.cs (LookupMemberCache): Better dynamic type check.
5832 (MemberLookup_FindMembers): More MS tricks.
5833 (GetParameterData): Ditto.
5834 (GetDelegateParameters): Uses quick path for dynamic types.
5836 2007-08-01 Marek Safar <marek.safar@gmail.com>
5838 * class.cs (MethodData.Define): EmitContext is required for generic stuff
5841 2007-07-31 Marek Safar <marek.safar@gmail.com>
5843 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
5846 2007-07-26 Jb Evain <jbevain@novell.com>
5848 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
5849 which takes a boolean 'report_errors', similar to the GetMethod.
5850 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
5851 in .net 2.1, do not report errors here.
5853 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
5854 System.Runtime.CompilerServices.RequiredAttributeAttribute and
5855 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
5858 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
5859 of the type InternalsVisibleToAttribute before the first call
5860 to CoreLookupType which is allowed to fail (third boolean parameter
5861 to true). Because, during the resolution for a type that is not
5862 immediately found, we try to check if the type is not defined in
5863 a friend assembly, and to do so, we need the
5864 InternalVisibleToAttribute.
5866 2007-07-23 Miguel de Icaza <miguel@novell.com>
5868 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
5869 feature that allows structs to be compared against null and inline
5870 the result as true or false.
5872 Notice that the same code is not permitted inside a generic block
5873 of code that would do:
5875 class Foo<T> where T : struct {
5882 It is only allowed if the type of T is not bound (no where
5883 clause). In my opinion, this CSC 2 behavior is broken but people
5884 seem to be using it (IronRuby does, a few bug reports on bugzilla
5885 have it and some people have complained about it).
5887 All of the users that depend on this behavior have code that is
5890 * report.cs (Warning, Error): make these take object arguments,
5891 not strings, as that allows us to take advantage of Format.
5893 2007-07-20 William Holmes <billholmes54@gmail.com>
5895 * decl.cs: Changed MemberName.CountTypeArguments to also check the
5896 Left member variable for the Count.
5897 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
5898 MemberName.CountTypeArguments to avoid a NRE.
5900 This code is contributed under the MIT X11 license
5902 2007-07-18 Marek Safar <marek.safar@gmail.com>
5904 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
5906 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
5908 * doc.cs : generic method arguments are written as ``x while generic
5909 type arguments are `x. Combined with the previous change, fixed bug
5912 2007-07-18 Raja R Harinath <rharinath@novell.com>
5915 * expression.cs (Binary.ResolveOperator): When converting
5916 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
5918 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
5920 * doc.cs : when T: or whatever x: is specified, it does not really
5921 check the doc comment's syntax correctness. Fixed bug #82006.
5923 2007-07-18 Marek Safar <marek.safar@gmail.com>
5925 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
5926 LambdaExpression better.
5928 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
5930 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
5932 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
5933 as it can be generated.
5935 * expression.cs (Invocation.Error_InvalidArguments): Show correct
5938 * lambda.cs (LambdaExpression): Refactored to share same code with
5939 AnonymousMethodExpression.
5941 2007-07-17 Marek Safar <marek.safar@gmail.com>
5943 * anonymous.cs (MakeName): Include host name for easier debugging.
5944 (LambdaMethod): New class for lambda spcecific stuff.
5946 * attribute.cs: Set EmitContext return type.
5948 * class.cs: Set EmitContext return type.
5950 * codegen.cs (EmitContext): Return type cannot be null to stop messing
5951 with null/void meaning.
5953 * iterators.cs (ContainerType): Implemented.
5955 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
5957 * statement.cs (Return): Updated to lambda expressions.
5958 (Block.CloneTo): Parent can be null.
5960 2007-07-13 Marek Safar <marek.safar@gmail.com>
5962 A fix for bug #81917
5963 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
5965 * class.cs (FixedField): Check whether field is in unsafe scope.
5967 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
5968 (FieldExpr.Emit): Fixed buffers cannot be volatile.
5970 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
5973 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
5975 2007-07-13 Marek Safar <marek.safar@gmail.com>
5977 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
5978 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
5981 2007-07-13 Marek Safar <marek.safar@gmail.com>
5983 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
5985 2007-07-13 Marek Safar <marek.safar@gmail.com>
5987 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
5988 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
5990 * codegen.cs(EmitContext): Add ProbingMode flag.
5992 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
5994 * driver.cs: For now set both warning values.
5996 * ecore.cs (SimpleName): Name is readonly.
5997 (MethodGroup.OverloadResolve): One quick path for probing.
5999 * expression.cs (Unary): Set Oper r/o.
6000 (Binary): Set Oper r/o.
6001 (ParameterReference): Set few instance variables as r/o.
6002 (ParameterReference.DoResolveBase): Don't capture aruments when
6004 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6005 (Arglist): arguments are private.
6006 (SizeOf): type is private and r/o.
6007 (MemberAccess): arguments are private.
6009 * report.cs: Enhanced reporting on/off capabilities.
6011 * lambda.cs: Uses ec.IsInProbingMode.
6012 (ContextualReturn): Derives from return.
6014 * rootcontext.cs: For now set both warning values.
6016 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6018 (Return.Resolve): Don't die immediately.
6019 (Block.Resolve): Speed-up probing.
6020 (Block.CloneTo): Clone only child blocks.
6022 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6024 * iterators.cs: reverted Miguel's latest change (r81925) as it
6025 breaks the build in System.
6027 2007-07-13 Miguel de Icaza <miguel@novell.com>
6029 * iterators.cs (Yield.CheckContext): Check for the iterator type
6030 also here as we can call into Yield even in codepaths that are not
6032 (MethodOrOperator is the only path that was checked).
6034 In addition to the standard check, use a more specific check for
6035 constructors to report a more verbose error.
6037 2007-07-12 Miguel de Icaza <miguel@novell.com>
6039 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6040 report the warning and continue
6042 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6043 values on the stack on the call to Emit. Use EmitStatement if
6044 possible, or using Emit + Pop if not possible. Fixes #82064
6046 2007-07-12 Raja R Harinath <rharinath@novell.com>
6048 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6049 avoid try...finally in some cases.
6051 2007-07-10 Marek Safar <marek.safar@gmail.com>
6053 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6055 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6056 instead of method. Re-use standard error handling.
6057 (ConstructorInitializer.Emit): Simplified.
6059 * delegate.cs: Updated after Invocation.EmitCall change.
6061 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6062 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6063 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6064 method and don't permanently changing input arguments.
6065 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6066 is resolved it has one of the candidates is the best one which is later
6067 used to emit. Removed a few unused method.
6068 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6070 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6071 (Binary.ResolveOperator): Ditto.
6072 (ConditionalLogicalOperator.DoResolve): Ditto.
6073 (Invocation): Uses method group.
6074 (Invocation.DoResolve): Simplified.
6075 (Invocation.EmitCall): Removed useless is_static.
6076 (Invocation.Emit): Delegate to method group.
6077 (Invocation.EmitStatement): Simplified.
6078 (New): Uses method group.
6079 (MemberAccess.DoResolve): Don't destroy original expression.
6081 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6083 2007-07-04 Marek Safar <marek.safar@gmail.com>
6085 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6088 * lambda.cs: Add custom error message type.
6090 2007-07-03 Marek Safar <marek.safar@gmail.com>
6092 * lambda.cs: Simplified little bit.
6094 * parameter.cs: Introduced ImplicitLambdaParameter.
6095 (Parameters.CreateFullyResolved): New factory instead of ctor.
6099 * delegate.cs: Updated parameter creation.
6101 2007-07-03 Marek Safar <marek.safar@gmail.com>
6103 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6106 * generic.cs: Synchronized with gmcs.
6108 2007-07-03 Marek Safar <marek.safar@gmail.com>
6110 * class.cs (Indexer): Check return type as soon as possible.
6112 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6115 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
6117 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
6119 * parameter.cs (Parameter): Use expression type when it is available.
6121 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
6122 method modifier for the first parameter only.
6124 2007-06-24 Marek Safar <marek.safar@gmail.com>
6126 A fix for bug #81938
6127 * typemanager.cs (ChangeType): Fixed couple of char conversions.
6129 * constant.cs: Tide up an exception message.
6131 2007-06-22 Marek Safar <marek.safar@gmail.com>
6133 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
6134 an uninitialized variable is used.
6136 * expression.cs (LocalVariableReference.DoResolve): Ditto.
6138 2007-06-22 Marek Safar <marek.safar@gmail.com>
6140 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
6141 not found error handling.
6143 * expression.cs (ArrayCreation): Removed redundant fields and little bit
6145 (ArrayCreation.ResolveArrayElement): To be ready to customization.
6146 (ArrayCreation.DoResolve): Simplified.
6147 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
6148 its own resolve process.
6149 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
6151 2007-06-20 Marek Safar <marek.safar@gmail.com>
6153 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
6156 2007-06-20 Marek Safar <marek.safar@gmail.com>
6158 * cs-tokenizer.cs: Removed var related stuff.
6160 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
6161 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
6162 a type and a keyword at same time.
6164 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
6167 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
6168 implicitly typed arrays, more changes will follow.
6170 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
6172 2007-06-19 Marek Safar <marek.safar@gmail.com>
6174 * ecore.cs (VarExpr): Removed Handled field.
6176 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
6177 build-in assign functionality.
6178 (ForEach.Resolve): Removed all implicitly typed local variable code and
6180 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
6181 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
6183 2007-06-18 Marek Safar <marek.safar@gmail.com>
6185 * assign.cs: Removed implicitly typed local variable check.
6187 * expression.cs (LocalVariableReference.DoResolve): Add check for self
6188 referencing implicitly typed local variable.
6189 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
6192 * statement.cs (Fixed): Removed unsupported implicitly typed local
6195 2007-06-15 Marek Safar <marek.safar@gmail.com>
6197 * decl.cs (MemberName): Moved all Unbound stuff to parser.
6199 2007-06-14 Marek Safar <marek.safar@gmail.com>
6201 A fix for bugs #81855 and #76274
6202 * attribute.cs (AttachTo): Always set owner for global attributes to
6205 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
6208 * cs-parser.jay: Assembly and module attributes must precede all other
6209 elements except using clauses and extern alias declarations.
6211 2007-06-13 Marek Safar <marek.safar@gmail.com>
6213 A fix for bug #81748
6215 * expression.cs: More checks for non ISO-1 features.
6217 2007-06-12 Marek Safar <marek.safar@gmail.com>
6219 A fix for bug #81807
6220 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
6221 present inside switch statement and it is required by nullable check.
6223 2007-06-12 Marek Safar <marek.safar@gmail.com>
6225 A fix for bug #81840
6226 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
6227 when type matching fails.
6229 * namespace.cs: Tiny error message change.
6231 2007-06-12 Marek Safar <marek.safar@gmail.com>
6233 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
6234 reporting. Added automatic property check.
6236 * class.cs: Updated after CheckAbstractAndExtern relocation.
6237 (AEventPropertyAccessor.GetSignatureForError): Customized.
6239 2007-06-11 Marek Safar <marek.safar@gmail.com>
6241 * class.cs (DefineBaseTypes): Base type can be undefined.
6243 * ecore.cs (TypeLookup): Minor refactoring.
6244 (DoResolveAsTypeStep): Removed redundant check.
6246 * namespace.cs (Lookup): Removed redundant check.
6248 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
6249 ResolveAsTypeTerminal step.
6250 (BootstrapCorlib_*): Simplified.
6251 (PopulateCoreType): Core types can be now external.
6253 2007-06-07 Marek Safar <marek.safar@gmail.com>
6255 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
6257 (InferTypeArguments): Infers anonymous expression type arguments.
6258 (Compatible): Split to Compatible and InferTypeArguments.
6260 * lambda.cs: Updated.
6262 2007-06-08 Marek Safar <marek.safar@gmail.com>
6264 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
6266 2007-06-07 Raja R Harinath <harinath@gmail.com>
6268 Fix #80477, cs0135-2.cs, cs0135-3.cs
6269 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
6270 names to the "known" variables list.
6271 (Block.CheckInvariantMeaningInBlock): Handle the fact the
6272 parameter names are also "known".
6273 (Block.CheckError136): Remove.
6274 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
6277 2007-06-07 Marek Safar <marek.safar@gmail.com>
6279 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
6281 2007-06-06 Marek Safar <marek.safar@gmail.com>
6283 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
6284 internal error not an user error.
6286 * expression.cs (IsApplicable): Refactored to make debugging easier.
6288 * support.cs: More tricks for non-mono runtimes.
6290 * typemanager.cs (CoreLookupType): Made public.
6291 (InitSystemCore): All linq specific stuff moved to linq.cs
6293 2007-06-05 Marek Safar <marek.safar@gmail.com>
6295 * typemanager.cs (CSharpSignature): One more missing build-in types
6297 More tricks for non-mono runtime.
6299 2007-06-05 Raja R Harinath <harinath@gmail.com>
6301 * statement.cs (Block.CheckError136_InParents): Remove.
6302 (Block.AddVariable): Use GetParameterInfo instead.
6303 (ToplevelBlock.ProcessArguments): Likewise.
6305 2007-06-04 Raja R Harinath <rharinath@novell.com>
6307 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
6309 (ToplevelBlock.GetParameterInfo): Split out of ...
6310 (ToplevelBlock.GetParameterRefernce): ... this.
6311 (ToplevelBlock.ParameterMap): Remove.
6312 * expression.cs (ParameterReference): Update to use
6313 ToplevelParameterInfo.
6315 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
6318 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
6319 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
6321 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
6322 (ToplevelBlock.ProcessParameters) ... here.
6323 (ToplevelBlock..ctor): Invoke it.
6325 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
6328 * statement.cs (IKnownVariable): New interface.
6329 (LocalInfo): Implement it.
6330 (ToplevelParameterInfo): New class.
6331 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
6332 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
6333 GetKnownVariableInfo.
6335 2007-06-03 Raja R Harinath <harinath@gmail.com>
6337 Partly speed up CS0136 error checks.
6338 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
6339 'recurse' parameter.
6340 (Block.DoCheckError136): Only check errors in parameters. Move
6341 local variable checks ...
6342 (Block.AddVariable): ... here, and ...
6343 (ToplevelBlock.ResolveMeta): ... here.
6345 2007-06-02 Raja R Harinath <harinath@gmail.com>
6347 * statement.cs (Block.IsChildOf): Remove.
6349 * statement.cs (Statement.Clone): Move special case code ...
6350 (Block.CloneTo): ... here.
6352 2007-05-29 Raja R Harinath <rharinath@novell.com>
6354 * statement.cs (ToplevelBlock.container): Remove field. It's
6355 redundant with 'Parent'.
6356 (ToplevelBlock.ContainerBlock): Remove accessor.
6357 (ToplevelBlock..ctor): Update to changes. Register anonymous
6358 child with parent here, ...
6359 * cs-parser.jay (end_anonymous): ... not here. Don't modify
6361 (start_anonymous): Don't save current_block.
6362 (top_current_block): Remove.
6364 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
6365 (Block.Resolve): Update to changes.
6366 (Block..ctor): Move setting of "correct" 'Toplevel'
6367 and 'Explicit' fields to ...
6368 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
6370 2007-05-27 Raja R Harinath <harinath@gmail.com>
6373 * statement.cs (Block.Implicit): Remove.
6374 (Block): Update to changes.
6375 * flowanalysis.cs: Likewise.
6377 Mildly speed up CheckInvariantMeaningInBlock
6378 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
6379 Recursively call AddKnownVariable to all enclosing blocks.
6380 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
6381 Remove recursive calls.
6382 (Block): Update to changes.
6384 New ExplicitBlock invariants
6385 * statement.cs (Block.Explicit): New field. It points to the
6386 immediately enclosing non-implicit block.
6387 (Block..ctor): Maintain the invariant.
6388 * cs-parser.jay: Take advantage of invariant.
6390 Introduce ExplicitBlock
6391 * statement.cs (ExplicitBlock): New.
6392 (ToplevelBlock): Derive from it.
6393 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
6395 (Block.Implicit): Update to changes.
6396 * cs-parser.jay: Update to changes.
6399 * codegen.cs (EmitContext.IsLastStatement): Remove.
6400 * statement.cs (Block.DoEmit): Update to changes.
6402 2007-05-25 Raja R Harinath <rharinath@novell.com>
6404 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
6405 modifying current_block directly.
6407 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
6409 * class.cs: Implemented automatic properties (C# 3.0)
6410 Thanks to Marek for the help.
6412 2007-05-23 Raja R Harinath <rharinath@novell.com>
6414 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
6415 variable as assigned, note also that all its components are
6417 (MyBitVector.SetRange): New. Function to set multiple bits to true.
6419 2007-05-19 Marek Safar <marek.safar@gmail.com>
6421 * anonymous.cs, class.cs: Emit Compiler generated attribute when
6422 member is marked as compiler generated.
6424 * decl.cs (MemberCore): Refactored ModFlags into property.
6426 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
6427 (Check): Check only accessibility modifiers.
6429 2007-05-18 Raja R Harinath <rharinath@novell.com>
6431 Track all assignable slots in one bit array
6432 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
6433 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
6434 logic from VariableMap constructor here. Use the same 'offset'
6435 variable that's later used for computing offsets of local
6437 * flowanalysis.cs (UsageVector.parameters): Remove.
6438 (UsageVector): Update to changes.
6439 (VariableMap): Remove.
6441 Avoid creating ParameterMap in every block
6442 * statement.cs (Block.ParameterMap): Move ...
6443 (ToplevelBlock.ParameterMap): ... here.
6444 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
6446 * flowanalysis.cs (FlowBranching.param_map): Remove.
6447 (FlowBranching.UsageVector): Update to changes.
6448 (FlowBranchingToplevel.CheckOutParameters): Likewise.
6450 * statement.cs (Block.CloneTo): Clone Toplevel field too.
6452 * expression.cs (ParameterReference): Distinguish between block
6453 where parameter was referenced and declared.
6455 2007-05-18 Marek Safar <marek.safar@gmail.com>
6457 * flowanalysis.cs, statement.cs: Put back improved error handling.
6459 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
6463 Imporved object and collection initialization (C# 3.0).
6465 2007-05-15 Marek Safar <marek.safar@gmail.com>
6467 A fix for bug #81380
6468 * expression.cs (Is.DoResolve): Only value types have constant `is'
6471 2007-05-15 Raja R Harinath <rharinath@novell.com>
6473 * statement.cs (ToplevelBlock.child): Remove.
6475 2007-05-15 Raja R Harinath <harinath@gmail.com>
6477 Rationalize ResolveMeta: refactoring
6478 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
6479 out constant handling code into ...
6480 (Block.DoResolveConstants): ... this.
6482 Rationalize ResolveMeta: kill local_map
6483 * statement.cs (Block.local_map, Block.LocalMap): Remove.
6484 (Block.AssignableSlots): New.
6485 (Block.ResolveMeta): Make protected. Don't create a VariableMap
6486 for locals -- move code from VariableMap here. Avoid unnecessary
6488 * flowanalysis.cs (FlowBranching.local_map): Remove.
6489 (FlowBranching..ctor): Use Block.AssignableSlots.
6490 (VariableMap): Remove unused constructors.
6492 2007-05-11 Raja R Harinath <rharinath@novell.com>
6494 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
6496 2007-05-11 Marek Safar <marek.safar@gmail.com>
6498 * typemanager.cs (IsFriendAssembly): Should not be called for building
6501 2007-05-09 Marek Safar <marek.safar@gmail.com>
6503 * literal.cs (NullConstant): Print null in all cases.
6505 * expression.cs (Binary.ResolveOperator): Implemented delegate
6506 comparison based on C# 2.0 changes.
6508 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
6510 This code is contributed under the MIT X11 license
6512 The following enables support for several C# 3.0 language features:
6514 * cs-tokenizer.cs: Added support for the "var" keyword.
6516 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
6517 Added VarExpr class to facilitate type inferencing.
6519 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
6520 to support anonymous types.
6522 * assign.cs: Added support for type inferencing and initialization.
6524 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
6526 * expression.cs: Added implicit array support to ArrayCreation.
6527 Added 5 types and 1 interface:
6529 IInitializable Implementing classes can inject initializing
6530 statements after object instantiation.
6532 Initializer Stores data for object initialization.
6534 AnonymousType An expression for anonymous types.
6536 AnonymousTypeParameter Stores data about an anonymous type's field.
6538 NewInitialize An expression for object initialization.
6540 CollectionInitialize An expression for collection initialization.
6542 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
6545 2007-05-06 Marek Safar <marek.safar@gmail.com>
6547 A fix for bug #81500
6548 * cs-tokenizer.cs: Add special handling for coalescing operator.
6550 2007-05-06 Marek Safar <marek.safar@gmail.com>
6552 A fix for bug #81529
6553 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
6554 its value from base class until it is redefined.
6556 2007-05-02 Raja R Harinath <rharinath@novell.com>
6558 Fix regression in cs0631-3.cs
6559 * cs-parser.jay (operator_declarator): Add opt_attributes to error
6560 fallback. Make error fallback catch more cases.
6562 2007-05-01 Miguel de Icaza <miguel@novell.com>
6564 * cs-parser.jay: Allow parameters in operator declarations to have
6567 2007-04-27 Miguel de Icaza <miguel@novell.com>
6569 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
6572 * lambda.cs (ContextualReturn.Resolve): An expression is valid
6573 inside the ContextualReturn, it does not have to be an
6574 ExpressionStatement.
6576 2007-04-24 Miguel de Icaza <miguel@novell.com>
6578 * lambda.cs (ContextualReturn.Resolve): if the return type is not
6581 2007-04-23 Miguel de Icaza <miguel@novell.com>
6583 * anonymous.cs (AnonymousContainer): split the virtual Resolve
6584 method in two methods: ResolveNoDefine and Resolve.
6586 ResolveNoDefine will stop just after ResolveTopBlock has been
6589 Resolve will then continue by creating a method and issuing the
6590 call to method.Define ().
6592 (AnonymousMethod): Split and implement the new Resolve and
6593 ResolveNoDefine as well.
6595 * lambda.cs (LambdaExpression): Split the anonymous method
6596 resolution code into a separate routine (CoreCompatibilityTest)
6597 from DoCompatibleTest.
6599 (LambdaExpression.TryBuild): New method, this method tries to
6600 build the LambdaExpression with the given set of types to be used
6601 as the types for the various parameters of the lambda expression.
6603 If the compilation succeed with the given types, the infered type
6604 of the Anonymous method is returned, otherwise null is returned.
6606 2007-04-23 Marek Safar <marek.safar@gmail.com>
6608 A fix for bug #81414
6609 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
6611 2007-04-22 Miguel de Icaza <miguel@novell.com>
6613 * cs-tokenizer.cs: Change various identifiers here from the
6614 camelCasing to the recommended Linux-like style for instance
6615 variables from the Coding Guidelines.
6617 2007-04-19 Martin Baulig <martin@ximian.com>
6620 (Convert.ImplicitReferenceConversionCore): Allow conversions from
6621 System.Enum to System.ValueType.
6623 2007-04-13 Martin Baulig <martin@ximian.com>
6625 Rewrote implicit reference conversions. We need to distinguish
6626 between implicit reference conversions (13.1.4) and implicit
6627 boxing conversions (13.1.5).
6629 According to the spec, there's an an implicit conversion
6630 "From a one-dimensional array-type S[] to IList<T> and base
6631 interfaces of this interface, provided there is an implicit
6632 reference conversion from S to T." Note that this does not
6633 include boxing conversions.
6636 (Convert.ImplicitTypeParameterBoxingConversion): New method.
6637 (Convert.ImplicitReferenceConversion): Split into
6638 ImplicitReferenceConversionCore() and
6639 ImplicitBoxingConversionExist().
6640 (Convert.ImplicitReferenceConversionExists): Use the new
6641 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
6643 2007-04-12 Martin Baulig <martin@ximian.com>
6645 * convert.cs (Convert.ImplicitReferenceConversion): Move the
6646 `TypeManager.null_type' checks up to the top of the method.
6648 2007-04-11 Marek Safar <marek.safar@gmail.com>
6650 A fix for bug #81350
6651 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
6654 2007-04-11 Martin Baulig <martin@ximian.com>
6656 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
6657 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
6658 to make this work for generic classes; fixes #79561.
6660 2007-04-11 Martin Baulig <martin@ximian.com>
6662 * expression.cs (As): Add support for nullable types; fixes #79371.
6664 2007-04-11 Martin Baulig <martin@ximian.com>
6666 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
6667 `type.FullName' is null; fixes #80243.
6669 2007-04-11 Martin Baulig <martin@ximian.com>
6671 * expression.cs (Invocation.IsApplicable): Don't modify the method
6672 if type inference succeeded, but the method was not applicable.
6675 2007-04-10 Marek Safar <marek.safar@gmail.com>
6677 A fix for bug #81324
6678 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
6679 internal and external namespaces containers.
6681 2007-04-10 Martin Baulig <martin@ximian.com>
6683 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
6684 TypeManager.DropGenericMethodArguments() so we also call
6685 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
6687 2007-04-10 Martin Baulig <martin@ximian.com>
6689 * iterators.cs (Iterator.CreateIterator): Don't crash if
6690 `method.ReturnType' is null. This happens if something went wrong
6691 while resolving that typ (we already reported an error in this case).
6693 2007-04-10 Martin Baulig <martin@ximian.com>
6695 * expression.cs (New.DoResolve): Don't call CheckComImport() on
6696 generic interfaces; report the CS0144 directly.
6698 2007-04-10 Martin Baulig <martin@ximian.com>
6700 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
6701 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
6703 2007-04-10 Martin Baulig <martin@ximian.com>
6705 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
6707 2007-04-09 Raja R Harinath <rharinath@novell.com>
6710 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
6711 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
6714 * statement.cs (For.Resolve): If resolution fails, use
6717 2007-04-08 Marek Safar <marek.safar@gmail.com>
6719 * anonymous.cs (MakeName): Make faster and zero-based.
6720 (VerifyExplicitParameterCompatibility): Back to mode where generic
6721 parameter is ignored.
6722 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
6724 * class.cs (EmitType): Method can emit another new method.
6726 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
6728 * driver.cs: Updated.
6730 * lambda.cs: Reuse predefined empty parameters.
6732 * parameter.cs: Updated
6734 * support.cs: Implemented InflateTypes.
6736 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
6737 (InitSystemCore): Introduced to isolate 3.0 dependencies.
6739 2007-04-03 Martin Baulig <martin@ximian.com>
6743 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
6744 version of TypeManager.IsOverride() which also works with generic
6747 2007-04-03 Martin Baulig <martin@ximian.com>
6752 (Convert.ExplicitReferenceConversion): We need to cast when
6753 converting from IList<T> to S[].
6755 2007-04-01 Marek Safar <marek.safar@gmail.com>
6757 * decl.cs (FindExtensionMethods): Consider all candidates with same name
6760 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
6762 2007-03-31 Marek Safar <marek.safar@gmail.com>
6764 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
6765 argument and return type inferring.
6767 * codegen.cs (InferReturnType): Flag whether return can be inferred.
6768 (ReturnType): Turned to property.
6770 * statement.cs (Return): Implemented return type inferring.
6772 * support.cs (ReflectionParameters): Use local types if possible.
6774 2007-03-30 Raja R Harinath <rharinath@novell.com>
6776 * flowanalysis.cs (FlowBranching.Reachability): Remove.
6777 (FlowBranching.UsageVector): Update to changes.
6779 Prepare to kill 'Reachability'
6780 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
6781 argument of constructor.
6783 2007-03-29 Raja R Harinath <rharinath@novell.com>
6785 Prepare to kill 'Reachability'
6786 * flowanalysis.cs (UsageVector.is_unreachable): New.
6787 (UsageVector): Update to maintain 'is_unreachable' in parallel to
6788 'reachability', and verify they're consistent.
6791 * expression.cs (New.EmitStatement): Handle type parameters here too.
6793 2007-03-29 Martin Baulig <martin@ximian.com>
6798 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
6799 CompilerGeneratedClass.
6800 (ScopeInfo.EmitScopeInstance): Make this protected.
6801 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
6802 `ec.CurrentAnonymousMethod.Scope == Scope'.
6804 * statement.cs (Block.ScopeInfo): Make this a property.
6806 2007-03-27 Raja R Harinath <harinath@gmail.com>
6808 Prepare to kill 'Reachability'
6809 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
6810 (FlowBranching.UsageVector.Reachability): Remove property.
6811 (FlowBranching.UsageVector.IsUnreachable): New property.
6812 (FlowBranching.UsageVector.ResetBarrier): New.
6813 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
6814 * codegen.cs, statement.cs: Update to changes.
6816 2007-03-27 Martin Baulig <martin@ximian.com>
6821 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
6824 2007-03-26 Raja R Harinath <rharinath@novell.com>
6826 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
6827 instead of TriState. Remove all mention of TriState.
6829 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
6830 replaced by a boolean. Add boolean 'is_unreachable' field, check
6831 and maintain invariants.
6833 2007-03-25 Marek Safar <marek.safar@gmail.com>
6835 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
6837 2007-03-25 Marek Safar <marek.safar@gmail.com>
6839 * expression.cs: Stop using obsolete 2.0 opcodes.
6841 2007-03-25 Marek Safar <marek.safar@gmail.com>
6843 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
6844 one of the latests Martin's fixes.
6846 2007-03-23 Miguel de Icaza <miguel@novell.com>
6848 * expression.cs: On BigEndian systems, swap the bytes, temporary
6849 solution until we get a new bitconverter class.
6851 2007-03-23 Martin Baulig <martin@ximian.com>
6855 * decl.cs (MemberCache.AddMembers): Add generic methods both as
6856 "Method" and "Method`1". Normally, a cache lookup is done on the
6857 "Method" form (ie. without the generic arity), but this one makes
6858 lookups on the full form work as well.
6860 2007-03-22 Raja R Harinath <rharinath@novell.com>
6862 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
6865 2007-03-20 Bill Holmes <billholmes54@gmail.com>
6867 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
6868 ordered_member_list, to TypeBuilder to store members to be defined
6869 in the order they were parsed in.
6870 - ordered_explicit_member_list contains all properties indexers
6871 and methods that are defined as explicit implementation of an
6872 interface or base class.
6873 - ordered_member_list contains all properties indexers and methods
6874 that are not defined as explicit implementation of an interface
6877 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
6878 functionality in these removed classes has been replaced with
6879 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
6880 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
6882 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
6883 to CheckForDuplications inside GetMethod and SetMethod Define Method
6884 to handle method property and indexer name conflicts.
6888 All code is contributed under the MIT/X11 license.
6890 2007-03-20 Martin Baulig <martin@ximian.com>
6892 * class.cs (TypeContainer.Interfaces): Removed; they're now
6893 included in `TypeContainer.Types'.
6895 2007-03-20 Martin Baulig <martin@ximian.com>
6897 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
6899 * class.cs (TypeContainer.CreateType): New public method. This is
6900 now called before DefineType() to create the TypeBuilders.
6901 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
6902 has already been created by CreateType().
6903 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
6904 don't resolve our base classes here; this has been moved into
6905 DefineBaseTypes(). We're now called from CreateType().
6906 (TypeContainer.DefineBaseTypes): New private method; resolve our
6907 base classes here. We're now called from DefineType().
6910 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
6911 our types first to create all the TypeBuilders. After that, call
6912 TypeContainer.DefineType() on all the types which'll resolve their
6913 base classes and setup the resolve order.
6915 2007-03-20 Martin Baulig <martin@ximian.com>
6917 * class.cs (TypeContainer.Enums): Removed; they're now included in
6918 `TypeContainer.Types'.
6920 2007-03-20 Martin Baulig <martin@ximian.com>
6923 (TypeContainer.DefineType): Don't call ResolveMembers() here.
6924 (TypeContainer.DoResolveMembers): Call DefineType() on our
6925 `compiler_generated' classes; moved here from DefineNestedTypes().
6928 (RootContext.ResolveTree): Call ResolveMembers() on all
6929 TypeContainer's in the `type_container_resolve_order'.
6931 2007-03-19 Marek Safar <marek.safar@gmail.com>
6933 * class.cs: Use corlib to handle InternalMethodImplAttribute.
6935 2007-03-17 Marek Safar <marek.safar@gmail.com>
6937 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
6938 implementation flags.
6940 2007-03-17 Marek Safar <marek.safar@gmail.com>
6942 * class.cs: More optimizations for type parameters.
6944 2007-03-15 Marek Safar <marek.safar@gmail.com>
6946 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
6948 * ecore.cs, parameter.cs: More common code for both corlibs.
6950 * typemanager.cs (IsGenericMethod): Simplified.
6952 2007-03-15 Raja R Harinath <rharinath@novell.com>
6954 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
6956 * statement.cs, iterators.cs, lambda.cs: Update to changes.
6958 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
6959 unconditionally. Simplify explanation.
6960 (Try.Resolve, Using.Resolve): Likewise.
6962 2007-03-15 Martin Baulig <martin@ximian.com>
6966 * decl.cs (DeclSpace): If we're a partial class, use our
6967 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
6969 2007-03-15 Raja R Harinath <rharinath@novell.com>
6971 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
6973 (FlowBranching.UsageVector): Update to changes.
6974 (FlowBranching.MergeSiblings): Likewise.
6975 * statement.cs: Likewise.
6977 2007-03-15 Martin Baulig <martin@ximian.com>
6982 (MemberCache): Added a special .ctor for type parameters.
6985 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
6988 2007-03-09 Martin Baulig <martin@ximian.com>
6990 * enum.cs (Enum): Make this a TypeContainer.
6991 (EnumMember): Derive from `Const'.
6994 (Const.DoResolveValue): New protected virtual method; move most of
6995 the functionality of ResolveValue() here so we can override it in
6997 (Const.CreateConstantReference): Make this virtual.
6999 * class.cs (Kind): Add `Kind.Enum'.
7000 (TypeContainer.Emit): Don't emit the enums here; they're already
7001 in the `RootContext.typecontainer_resolve_order'.
7003 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7004 here; they're already in the `typecontainer_resolve_order'.
7006 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7007 TypeManager.DropGenericTypeArguments().
7010 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7011 (TypeManager.IsEnumType): Likewise.
7012 (TypeManager.EnumToUnderlying): Likewise.
7013 (TypeManager.IsEqual): Add support for enums.
7015 2007-03-12 Raja R Harinath <rharinath@novell.com>
7017 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7018 DefaultParameterValueAttribute to be undefined, say if System.dll
7021 2007-03-11 Marek Safar <marek.safar@gmail.com>
7023 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7026 2007-03-10 Marek Safar <marek.safar@gmail.com>
7028 * class.cs, parameter.cs: Unified parameters verification.
7030 2007-03-08 Martin Baulig <martin@ximian.com>
7032 * cs-parser.jay (constructor_header): Pass the location to the
7033 newly created TopLevelBlock.
7035 2007-03-07 Martin Baulig <martin@ximian.com>
7037 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7039 2007-03-06 Miguel de Icaza <miguel@novell.com>
7041 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7042 with the changes from David, fixes the build.
7044 2007-03-05 David Mitchell <dmitchell@logos.com>
7046 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7047 and its base interfaces to a one-dimensional array type S[],
7048 provided there is an implicit or explicit reference conversion
7051 2007-03-03 Marek Safar <marek.safar@gmail.com>
7053 * cs-tokenizer.cs: Implemented basic linq grammar.
7055 * driver.cs: Set linq lang version on demand.
7057 2007-02-26 Marek Safar <marek.safar@gmail.com>
7059 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7061 2007-02-25 Marek Safar <marek.safar@gmail.com>
7063 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7066 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7068 Check property and event extern attributes.
7070 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7073 2007-02-24 Marek Safar <marek.safar@gmail.com>
7075 A fix for bug #80407
7076 * ecore.cs: Don't report ambiguity error when methods have same parent.
7078 2007-02-23 Marek Safar <marek.safar@gmail.com>
7080 A fix for bug #80878
7081 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7083 2007-02-22 Marek Safar <marek.safar@gmail.com>
7085 * attribute.cs: Enable ExtensionAttribute presence test.
7087 2007-02-22 Marek Safar <marek.safar@gmail.com>
7089 * class.cs: Warn about missing GetHashCode only when Equals is override.
7091 * decl.cs: Check accessibility of type arguments.
7093 * typemanager.cs: Correctly report nullable array.
7095 2007-02-20 Marek Safar <marek.safar@gmail.com>
7097 * class.cs, report.cs: Capture more details when things go wrong.
7099 2007-02-20 Marek Safar <marek.safar@gmail.com>
7101 A fix for bug #80650
7102 * cs-parser.jay: Anonymous container starts at constructor declaration
7103 and not at block beginning because it has to be usable in constructor
7106 * statement.cs: Use context location and not block one for error reporting.
7108 2007-02-18 Marek Safar <marek.safar@gmail.com>
7110 A fix for bug #78712
7111 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
7114 2007-02-18 Marek Safar <marek.safar@gmail.com>
7116 A fix for bug #80493 by Atsushi Enomoto
7117 * cs-parser.jay: Ignore invalid attribute target.
7119 2007-02-18 Marek Safar <marek.safar@gmail.com>
7121 * cs-tokenizer.cs: Ignore '\0' as white space character.
7123 2007-02-17 Miguel de Icaza <miguel@novell.com>
7125 * cs-parser.jay: Add support for lambda expressions to the mcs
7128 * lambda.cs: Only clone when we are probing, not on the final call
7129 (Compatible is the final call).
7131 * statement.cs (CloneContext): Introduce class to provide block
7132 remapping during clone.
7134 All statements Clone themselves now.
7136 (Clone): special handling for blocks, when we clone a block, we
7137 register the block inside this routine, as children of the block
7138 might trigger a lookup.
7140 * expression.cs: Add support for CloneContext in all expressions.
7142 2007-02-17 Marek Safar <marek.safar@gmail.com>
7144 A fix for bug #80493
7145 * statement.cs: Report ambiguous warning when interfaces are not related.
7147 2007-02-15 Marek Safar <marek.safar@gmail.com>
7149 C# 3.0 extension methods.
7151 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
7152 cannot be used directly.
7154 * class.cs (Class.Emit): Emit extension attribute if any class method
7155 is extension method.
7156 (Method.Define): Add basic extension method validation conditions.
7157 (Method.Emit): Emit extension attribute for method.
7159 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
7160 extension method exists. Currently we follow same approach as Microsoft
7161 does, emit even if a method or a class are private but this can change
7164 * cs-parser.jay: Add handling of `this' keyword in method parameters
7167 * decl.cs (DeclSpace.IsStaticClass): New property.
7168 (MemberCache.FindExtensionMethods): Looks for extension methods with
7169 defined name and extension type.
7171 * doc.cs: Updated after OverloadResolve changes.
7173 * driver.cs: Add new soft reference to System.Core.dll.
7175 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
7176 (ExtensionMethodGroupExpr): Represents group of extension methods.
7178 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
7179 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
7180 to MethodGroupExpr and made non-static for easier customization.
7181 (Invocation.DoResolve): Add extension method lookup when no standard
7183 (MemberAccess.DoResolve): Try extension methods if no member exists.
7185 * modifiers.cs: Add METHOD_EXTENSION modifier.
7187 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
7188 as well as candidate extension type.
7189 (ComputeNamespaces): When assembly constains extension methods registers
7191 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
7192 extension method lookup.
7193 (Namespace.LookupExtensionMethod): Looks for extension method in this
7195 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
7196 find a method which matches name and extensionType.
7198 * parameter.cs (Parameter): Add This modifer.
7199 (HasExtensionMethodModifier): New property.
7200 (Resolve): Add extension parameter check.
7201 (ModFlags): turned to property to exclude this modifier as it is not real
7203 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
7205 * support.cs (ParameterData): Add ExtensionMethodType.
7206 (ReflectionParameters): Implemented ExtensionMethodType interface property.
7208 * typemanager.cs: Add type and ctor extension attribute type.
7210 2007-02-15 Miguel de Icaza <miguel@novell.com>
7212 * report.cs (DisableErrors, EnableErrors): used to prevent error
7213 output when we are "trying" to compile various methods with
7216 * ecore.cs (Expression): Add Clone method that calls the virtual
7217 CloneTo method. The current CloneTo method in Expression throws
7218 an exception so we can track down all the places where this must
7219 be implemented (not using abstract, because that would be a lot of
7220 up-front-work before we can start testing the implementation
7223 Important: we only need Clone capabilities for expressions created
7224 by the parser, as the expressions we will be cloning are
7225 expressions in the pre-resolved state. This vastly simplifies
7228 (SimpleName): Add CloneTo that does nothing.
7229 (EmptyCast): Add CloneTo.
7231 * expression.cs (Binary): Implement CloneTo.
7232 (Invocation.IsApplicable): Store the current ec in
7233 EmitContext.TempEc and restore it on return. This is used so we
7234 do not have to sprinkle hundres of methods with an extra
7235 EmitContext, we know that the only user is the lambda expression
7236 ImplicitConversionExists code.
7238 (Argument): Add Cloning capabilities.
7239 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
7240 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
7241 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
7242 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
7243 IndexerAccess): Add Clone capability.
7245 (LocalVariableReference, This): TODO: needs cloned Block mapping.
7247 (Argument): Add cloning capability.
7249 * assign.cs (Assign): Implement CloneTo.
7251 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
7253 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
7254 version by calling Convert with the EmitContext (that we are
7255 currently storing in ec, this is not great, but will do for now,
7256 to avoid passing EmitContext parameters to hundreds of functions
7257 that do not need them now).
7259 (SetExpression): Remove, it is not needed.
7261 (ContextualReturn): Implement CloneTo.
7263 * statement.cs (Statement): Implement cloning infrastructure,
7264 similar to expressions.
7266 (Block): Partial implementation of Clone for statements.
7268 (Return): Implement clone.
7270 * constant.cs (Constant.CloneTo): New method, does nothing.
7272 * codegen.cs (TempEc): Add a static EmitContext as a temporary
7273 solution, until we decide how to exactly do this.
7275 2007-02-14 Marek Safar <marek.safar@gmail.com>
7277 A fix for bug #80493
7278 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
7279 a property is override we need to use second accessor.
7281 2007-02-13 Marek Safar <marek.safar@gmail.com>
7283 A fix for bug #80418
7284 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
7287 2007-02-13 Marek Safar <marek.safar@gmail.com>
7289 Another fix for bug #80749
7290 * pending.cs: Abstract class has priority over interfaces.
7292 2007-02-13 Marek Safar <marek.safar@gmail.com>
7294 Another fix for bug #80749
7295 * pending.cs: Abstract class has priority over interfaces.
7297 2007-02-13 Marek Safar <marek.safar@gmail.com>
7299 Another fix for bug #80749
7300 * pending.cs: Abstract class has priority over interfaces.
7302 2007-02-13 Marek Safar <marek.safar@gmail.com>
7304 Another fix for bug #80749
7305 * pending.cs: Abstract class has priority over interfaces.
7307 2007-02-13 Marek Safar <marek.safar@gmail.com>
7309 * class.cs Better error message.
7311 * driver.cs: Add shorter versions of -optimize option.
7313 2007-02-13 Martin Baulig <martin@ximian.com>
7315 * class.cs (Constructor.Emit): Check the return value of
7316 ec.ResolveTopBlock() and return on error.
7318 2007-02-13 Raja R Harinath <rharinath@novell.com>
7320 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
7321 message to fix error message regression.
7323 2007-02-12 Marek Safar <marek.safar@gmail.com>
7325 * delegate.cs: Delegate creation expression cannot be of Nullable type.
7327 2007-02-12 Marek Safar <marek.safar@gmail.com>
7329 A fix for bug #80749
7330 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
7331 its parent container.
7333 * class.cs (DefineFieldInitializers): Each initializer can has different
7336 * const.cs: Updated.
7338 2007-02-11 Miguel de Icaza <miguel@novell.com>
7340 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
7341 now all the heavy lifting to check that embedded statements or
7342 expressions have the right form is done in the ContextualReturn.
7344 (ContextualReturn): New class.
7346 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
7347 method that can be invoked to report 201, so we do not replicate
7350 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
7352 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
7353 treating tabs as spaces.
7355 2007-02-09 Marek Safar <marek.safar@gmail.com>
7357 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
7358 * assign.cs: Use full implicit conversion for right side check.
7360 2007-02-09 Marek Safar <marek.safar@gmail.com>
7362 * statement.cs (Switch): Switch over boolean type is not standardized.
7364 2007-02-08 Marek Safar <marek.safar@gmail.com>
7366 A fix for bug #80755
7367 * decl.cs (FindBaseEvent): Don't use method cache for events.
7369 2007-02-07 Marek Safar <marek.safar@gmail.com>
7371 * cs-parser.jay: Better syntax error handling.
7373 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
7374 instead of underlying type value.
7376 2007-02-06 Marek Safar <marek.safar@gmail.com>
7378 * driver.cs: Check define identifier before is registered.
7380 * namespace.cs: Use existing error message.
7382 * report.cs: New warning.
7384 2007-02-06 Marek Safar <marek.safar@gmail.com>
7386 A fix for bug #80742
7387 * expression.cs: Delegate Invoke method can be called directly.
7389 2007-02-06 Marek Safar <marek.safar@gmail.com>
7391 A fix for bug #80676
7392 * class.cs (IsEntryPoint): The Main method can have params modifier.
7394 2007-02-04 Miguel de Icaza <miguel@novell.com>
7396 * parameter.cs (Parameter, Parameters): Add Clone method.
7398 * anonymous.cs (Compatible): Turn method into virtual method, so
7399 LambdaExpression can implement a different behavior.
7401 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
7402 out the basic checking here, so it can be used by
7405 * lambda.cs: Introduce "Compatible" function that will do the
7408 2007-02-02 Marek Safar <marek.safar@gmail.com>
7410 * attribute.cs: Unified one error message.
7412 * class.cs (Class): Use type attributes and not properties to test static
7414 (IsEntryPoint): Don's pass local variable.
7416 * convert.cs: Removed duplicate check.
7418 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
7420 * driver.cs: Don't crash when soft reference does not exist.
7422 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
7423 (UsingEntry): Removed redundant allocation.
7425 * parameter.cs: Add fast path for type parameters.
7427 * support.cs: Don't allocate attribute when it's not used.
7429 2007-01-30 Miguel de Icaza <miguel@novell.com>
7432 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
7433 this into a virtual method, so we can override it in LambdaExpression.
7435 * driver.cs: Improve diagnostics in case of failure.
7437 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
7438 write a function that is slightly more complex and that parses:
7440 type identifier [, type identifier]* )
7442 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
7445 (canEmpty ? i >= 0 : i > 0)
7447 2007-01-30 Raja R Harinath <rharinath@novell.com>
7449 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
7450 exception on possibly valid code.
7452 2007-01-29 Raja R Harinath <rharinath@novell.com>
7454 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
7456 (parse_opt_type_arguments): Remove. It's almost the same as
7458 (parse_namespace_or_typename): Use parse_less_than.
7460 2007-01-28 Miguel de Icaza <miguel@novell.com>
7462 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
7463 this bug took a few hours to find, because the state saved and
7464 restored by PushPosition and PopPosition was ignoring the state of
7465 parse_generic_less_than.
7467 I can also now remove the handling of OP_LT and OP_GT, this solves
7470 * cs-tokenizer.cs: store the location for the ARROW token, we use
7473 (PushPosition, PopPosition): save/restore also `current_token',
7474 restore `parse_generic_less_than' (was missing).
7476 (parse_opt_type_arguments): use parse_type, not
7477 parse_namespace_or_typename to parse types.
7479 * lambda.cs: Empty new file, will eventually have the lambda
7480 expression implementation.
7482 * lambda.test: used to test the internal tokenizer.
7484 * report.cs (FeatureIsNotISO1): Rename from
7485 FeatureIsNotStandardized, because it was about the language level
7486 (1 vs 2) it was not about standarization.
7488 (FeatureRequiresLINQ): New.
7490 * support.cs (SeekableStreamReader): Only require that the reader
7491 is a TextReader, not a StreamReader, so we can plug StringReader.
7493 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
7494 given position in the input stream the following tokens can be
7495 parsed as a type followed by an identifier.
7497 (is_punct): after a '(' if parse_type_and_parameter returns true,
7498 then return a special token OPEN_PARENS_LAMBDA which is used to
7499 avoid reduce/reduce errors in the grammar for the
7500 lambda_expression rules.
7502 (parse_type): implement a type parser inside the
7503 tokenizer, the parser only returns true or false depending on
7504 whether the input at a given position can be parsed as a type.
7506 (peek_token): new method used during type parsing.
7508 2007-01-28 Raja R Harinath <rharinath@novell.com>
7511 * anonymous.cs (ScopeInfo.InflateParameters): New.
7512 (AnonymousContainer.Resolve): Use it to redirect types of
7513 delegate parameters.
7515 2007-01-27 Raja R Harinath <rharinath@novell.com>
7518 * expression.cs (Error_InvalidArguments): Don't use two different
7519 messages for CS1503. Use ExtraInformation and
7520 SymbolRelatedToPreviousError instead.
7523 * decl.cs (DeclSpace.initialize_type_params): Don't access
7524 'type_params' of a partial class directly.
7526 2007-01-26 Miguel de Icaza <miguel@novell.com>
7528 * constant.cs: Removed a handful of out-of-range checks that were
7531 2007-01-25 Marek Safar <marek.safar@gmail.com>
7533 * expression.cs (CheckUselessComparison): Add additional check for char
7536 * namespace.cs: Fixed typo.
7538 2007-01-23 Miguel de Icaza <miguel@novell.com>
7540 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
7541 gone, instead we inline the test, preventing the needless casts to
7542 longs, ulongs and doubles for the parameters, avoiding calls to
7543 methods that overchecked stuff, and instead inlined things
7546 2007-01-20 Marek Safar <marek.safar@gmail.com>
7548 * cs-parser.jay: Better parameter error handling.
7550 2007-01-17 Marek Safar <marek.safar@gmail.com>
7552 A fix for bug #80368, #80522
7553 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
7554 whether array initializer contains constants only.
7555 (ArrayCreation.Emit): Use better formula to decide when
7556 are array initializers for static initialization.
7557 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
7558 have to emit even constants otherwise they are pre-initialized.
7560 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
7561 Raja R Harinath <rharinath@novell.com>
7563 Fix emit order of 'get' vs. 'set'.
7564 * support.cs (Accessors): New.
7565 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
7566 Note the order in which accessors are declared in the source.
7567 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
7568 Refactored from Property.Define and Indexer.Define.
7569 (PropertyBase.DefineAccessors): New helper that calls the above in
7570 appropriate order as noted by the parser.
7571 (Property.Define, Indexer.Define): Update to changes.
7572 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
7574 2007-01-17 Raja R Harinath <rharinath@novell.com>
7576 Fix cs0029-6.cs and gcs0029-2.cs (regression)
7577 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
7578 there's an implicit conversion from the current type to the target
7579 type before converting the underlying constant.
7581 2007-01-16 Marek Safar <marek.safar@gmail.com>
7583 * const.cs (ResolveValue): Updated after constant conversion was made more
7586 * constant.cs (GetAttributableValue): constant to object conversion is
7587 used for attributes only.
7588 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
7589 constant conversions.
7590 (LongConstant.ConvertImplicitly): Ditto.
7592 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
7593 (ImplicitConversionStandard): Handle constant conversion as extra step.
7594 It solves the issue when constant conversion was called indirectly like
7595 inside array initializer and constant folding was skipped.
7597 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
7600 * statement.cs(ImplicitConversionStandard): Updated after constant
7601 conversion was made more generic.
7603 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
7605 * expression.cs (As.DoResolve): Use GenericConstraints instead of
7606 Constraints, solves the problem where the compiler incorrectly
7607 reported that a type parameter was not constrained to a class (Bug
7610 2007-01-14 Marek Habersack <grendello@gmail.com>
7612 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
7614 2007-01-14 Marek Safar <marek.safar@gmail.com>
7616 A fix for bug #80368
7617 * assign.cs (FieldInitializer): New class implements field
7618 initializer statement.
7620 * attribute.cs: Update after FieldMember rename.
7622 * class.cs (PropertyBasedMember): New common class for property based
7624 (InterfaceMemberBase): New base class for all members which can be used as
7625 an interface members.
7626 (MethodCore): Moved really common code to InterfaceMemberBase.
7627 (Method.Define): Equal and GetHasCode detection is relevant for methods
7629 (MethodData.Define): Don't assume that public event implements an
7630 interface automatically.
7631 (MethodData.DefineMethodBuilder): Issue an error even if only extern
7633 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
7634 (FieldMember): Merged with FieldBase.
7635 (EventProperty.AEventPropertyAccessor): New specialization to check whether
7636 event extern modifier can be used.
7637 (EventField.EventFieldAccessor): Moved event field specific code here.
7638 (Event.AllowedModifiers): Even event can be extern.
7639 (Event.FindOutBaseMethod): New override specific to events.
7640 (Indexer.parameters): Reintroduce parameters because base class holds
7641 only properties common data.
7642 (Indexer.CheckForDuplications): Indexers are threated as methods so we
7643 need do extra parameters check.
7645 * const.cs: Update after FieldMember rename.
7647 * decl.cs (MemberCache.FindBaseEvent): New method.
7649 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
7650 to reflect that indexer is now derived from PropertyBased.
7652 * ecore.cs (GetMemberType): Made public.
7653 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
7656 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
7658 * typemanager.cs (CSharpSignature): Correctly print event accessors.
7659 (RegisterEvent): Removed.
7660 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
7661 (GetPrivateFieldOfEvent): Renamed to GetEventField.
7663 2007-01-11 Raja R Harinath <rharinath@novell.com>
7666 * statement.cs (CollectionForeach.TryType): Prefer generic
7667 GetEnumerator over non-generic variant. Fix code to follow comments.
7669 2007-01-09 Raja R Harinath <rharinath@novell.com>
7672 * support.cs (ReflectionParameter): Don't use an invalid index on
7673 the generic parameter data.
7675 2007-01-08 Miguel de Icaza <miguel@novell.com>
7677 * driver.cs: Just add a tiny bit of infrastructure.
7679 2007-01-02 Marek Safar <marek.safar@gmail.com>
7681 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
7682 where field type is struct from current assembly.
7684 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
7687 2007-01-02 Marek Safar <marek.safar@gmail.com>
7689 A fix for bug #80381
7690 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
7693 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
7695 (Namespace.LookupType): Always use core types from corlib when speficied.
7697 * report.cs: A new warning.
7699 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
7700 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
7701 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
7703 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
7704 (InitCoreTypes): Set expression type of object_type and value_type
7705 immediately after lookup.
7707 2007-01-01 Miguel de Icaza <miguel@novell.com>
7709 * cs-tokenizer.cs: Accept Pc class characters (Connector
7710 Punctuation) as valid identifiers. Fixes #78259
7712 * expression.cs (Invocation.DoResolve): Moved the check for the
7713 use of `this' for doing method calls to the Invocation resolution
7714 step, after overload resolution has taken place instead of doing
7715 the check at the low-level `This.DoResolve' level.
7717 The `This.DoResolve'(appens before overload resolution, so it has
7718 no way of knowing if the method that will be called will be
7719 instace or static, triggering an erroneous report for cs0188 (Bug
7722 We now do the check for instance method invocations after we know
7723 what method will be called.
7725 (This.CheckThisUsage): Move the actual use of this structure
7726 checking into its own method and expose it.
7728 * Everywhere that called Error_ValueCannotBeConverted: pass a new
7731 Exceptions: Null.ConvertImplicitly,
7732 Constant.ImplicitConversionRequired as there are too many call
7733 sites for passing the ec.
7735 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
7736 EmitContext, if the value is null, then we do not try to provide
7737 the extra information from the error (If a userdefined conversion
7738 exists, as UserDefinedConversion requires a non null-EmitContext).
7742 2006-12-30 Raja R Harinath <rharinath@novell.com>
7744 * flowanalysis.cs (MyBitVector): Document some invariants.
7745 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
7746 introduced below, and add a couple of others,
7748 2006-12-30 Marek Safar <marek.safar@gmail.com>
7750 * attribute.cs (GetMethodObsoleteAttribute): Uses new
7751 GetPropertyFromAccessor and GetEventFromAccessor.
7753 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
7754 overrides non-obsolete one.
7755 (Indexer.Define): Error message has been moved to the parser.
7757 * cs-parser.jay: Better syntax errors handling.
7759 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
7760 when an invocation has no arguments.
7762 * ecore.cs: Removed not used caching.
7764 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
7767 * report.cs: Add a new warning.
7769 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
7771 * typemanager.cs (enumeration_type): Removed.
7772 (CSharpSignature): Reuses IsSpecialMethod.
7773 (IsEqual): Hack for MS BCL.
7774 (GetPropertyFromAccessor): New method.
7775 (GetEventFromAccessor): New method.
7776 (IsSpecialMethod): Fixed to handle more cases.
7778 2006-12-30 Marek Safar <marek.safar@gmail.com>
7780 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
7781 Made white spaces array static.
7783 * ecore.cs (RemoveGenericArity): Optimized.
7785 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
7787 (MyBitVector.initialize_vector): Simplified.
7789 2006-12-22 Miguel de Icaza <miguel@novell.com>
7791 * ecore.cs: Am not entirely happy with this hack, but it seems to
7792 address the issue in 80257 (a small test case for
7795 I set the MethodGroupExpr.Type to an internal compiler type
7796 (itself in this case) to force the resolution to take place. Why
7797 it does not take place with a null is beyond me.
7799 2006-12-20 Marek Safar <marek.safar@gmail.com>
7801 A fix for bug #80288
7802 * expression.cs (ResolveOperator): Consider user defined conversion for
7803 logical and operator too.
7804 (EmitBranchable): Optimization for logical and when full constant folding
7805 could not be applied but one operand is constant.
7807 2006-12-19 Marek Safar <marek.safar@gmail.com>
7809 * class.cs (GetClassBases): Write 5 times every day, will never use
7810 FullName for error reporting.
7812 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
7814 2006-12-19 Martin Baulig <martin@ximian.com>
7816 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
7817 the symbol file info here.
7819 2006-12-18 Marek Safar <marek.safar@gmail.com>
7821 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
7822 of `elseif' is taking then following sections are not taking.
7823 Fixes an issue reported on mono mailing list.
7825 2006-12-18 Marek Safar <marek.safar@gmail.com>
7827 A fix for bug #80300
7828 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
7829 a caller is not taking.
7831 2006-12-18 Raja R Harinath <rharinath@novell.com>
7833 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
7834 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
7835 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
7836 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
7837 * class.cs: Update to changes.
7839 2006-12-17 Marek Safar <marek.safar@gmail.com>
7841 A fix for bug #79934
7842 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
7845 * class.cs (ResolveMembers): Register an iterator in current container and
7848 2006-12-16 Raja R Harinath <rharinath@novell.com>
7851 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
7852 satisfy a params annotated parameter.
7854 2006-12-16 Marek Safar <marek.safar@gmail.com>
7856 A fix for bug #77014
7857 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
7858 paramters correctly and not rely on hacks in Parameters class.
7859 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
7861 (Invocation.VerifyArgumentsCompat): Ditto.
7862 (Invocation.EmitArguments): Changed to correctly emit params arguments at
7865 * parameter.cs (HasParams): Don't assume that params is the last one.
7867 * support.cs (ReflectionParameters.ctor): Look for params attribute
7869 (ReflectionParameters.ParameterType): Removed hack when we returned last
7870 parameter for out of range parameters.
7871 (ParameterName, ParameterModifier): Ditto.
7873 2006-12-14 Marek Safar <marek.safar@gmail.com>
7875 A fix for bug #79987
7876 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
7877 when assembly is not CLS compliant but type is. I have no idea why is this
7880 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
7882 2006-12-13 Miguel de Icaza <miguel@novell.com>
7884 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
7885 in struct constructors, they are basically no-ops.
7887 2006-12-12 Marek Safar <marek.safar@gmail.com>
7889 * cs-tokenizer.cs (Position): Save preprocessor status too.
7891 2006-12-12 Marek Safar <marek.safar@gmail.com>
7893 A fix for bug #77794
7894 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
7896 2006-12-12 Marek Safar <marek.safar@gmail.com>
7898 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
7900 (pp_expr): Report error for an invalid expression.
7901 (handle_preprocessing_directive): Simplified; add more error checking.
7903 2006-12-11 Marek Safar <marek.safar@gmail.com>
7905 A fix for bug #74939
7906 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
7907 directives handling.
7909 2006-12-10 Marek Safar <marek.safar@gmail.com>
7911 A fix for bugs #80093, and #75984
7912 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
7913 logic, it seems to me as it worked before "by coincidence".
7914 (xtoken): Simplified to use reworked handle_preprocessing_directive.
7915 (cleanup): Enabled endif check.
7917 2006-12-09 Marek Safar <marek.safar@gmail.com>
7919 A fix for bug #80162
7920 * statement.cs (CollectionForeach.TryType): Generics and non-generics
7921 enumerators are never ambiguous.
7923 2006-12-08 Raja R Harinath <rharinath@novell.com>
7926 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
7928 2006-12-06 Marek Safar <marek.safar@gmail.com>
7930 A fix for bug #80144
7931 * class.cs (EventProperty.Define): Explicit implementation means
7932 that an even is used.
7934 2006-12-06 Marek Safar <marek.safar@gmail.com>
7936 Fixes the operators implementation (part II)
7938 * cfold.cs (DoConstantNumericPromotions): Renamed to
7939 DoBinaryNumericPromotions and simplified.
7940 (BinaryFold): Couple of conversion fixes; simplified.
7942 * constant.cs, ecore.cs, literal.cs
7943 (ToType): Renamed to ConvertImplicitly.
7944 (Reduce): Renamed to ConvertExplicitly.
7946 * class.cs, convert.cs: Updated.
7948 * expression.cs: TryReduce doesn't throw an exception.
7950 2006-12-01 Marek Safar <marek.safar@gmail.com>
7952 A fix for bug #80108
7953 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
7956 2006-11-30 Marek Safar <marek.safar@gmail.com>
7958 Fixes unary operators implementation (part I)
7961 * cfold.cs (Error_CompileTimeOverflow): Made internal
7963 * const.cs (IConstant): Changed to use reference to constant and
7964 not constant itself.
7965 Updated IConstant implementations.
7967 * constant.cs (CreateConstant): New factory method.
7968 Updated IConstant implementation.
7970 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
7972 * ecore.cs: Updated to use CreateConstantReference.
7974 * enum.cs: Reflects IConstant changes.
7976 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
7978 * literal.cs (NullConstant): Change to be independently usable.
7980 2006-11-29 Martin Baulig <martin@ximian.com>
7982 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
7983 we need to emit the scope initializer before calling the base .ctor.
7985 * anonymous.cs: Merged back from the new anonymous methods branch.
7986 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
7988 * expression.cs (ParameterReference.DoResolveBase): Create a
7989 "normal" ScopeInfo when capturing parameters rather than using the
7990 root scope; this makes things work with anonymous methods having
7994 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
7996 2006-11-22 Marek Safar <marek.safar@gmail.com>
7998 A fix for bug #79987
7999 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8000 check to a base class.
8001 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8002 only when assembly has missing attribute.
8003 * report.cs: Update.
8005 2006-11-21 Marek Safar <marek.safar@gmail.com>
8007 * cs-tokenizer.cs: Merged with gmcs version.
8009 2006-11-20 Marek Safar <marek.safar@gmail.com>
8012 * cs-parser.jay: Better error message when partial keyword is misplaced.
8014 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8016 A fix for bug #79810
8017 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8018 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8019 a RuntimeWrappedException by default.
8021 2006-11-18 Marek Safar <marek.safar@gmail.com>
8023 A fix for bug #79843
8024 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8026 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8028 2006-11-18 Marek Safar <marek.safar@gmail.com>
8030 * driver.cs, namespace.cs: Uses faster IndexOf version.
8032 2006-11-17 Marek Safar <marek.safar@gmail.com>
8034 A fix for bug #79941
8035 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8037 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8038 even if internal name is different.
8039 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8040 (UserDefinedConversion): Simplified as the operators cannot be internal.
8041 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8043 (MethodLookup): Replaced EmitContext with parentType.
8044 * expression.cs: Updated.
8046 2006-11-09 Raja R Harinath <rharinath@novell.com>
8048 * driver.cs (BadAssembly): Handle all the ugliness of
8049 DefineDynamicAssembly.
8051 2006-11-08 Raja R Harinath <rharinath@novell.com>
8053 Address parts of #58244 -- most of what's left is in the runtime
8054 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8055 CS1509 error checks, and handle them for all assembly loads, not
8056 just the first invocation.
8057 (LoadModule): Likewise. Move handling of 'adder_method' ...
8058 * codegen.cs (AssemblyClass.AddModule): ... here.
8060 2006-11-02 Marek Safar <marek.safar@gmail.com>
8062 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8063 IEnumerable<T> is ambiguous.
8065 2006-10-31 Marek Safar <marek.safar@gmail.com>
8067 A fix for bug #67689
8068 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8069 GetEnumerator is ambiguous.
8071 * report.cs: Add new warning.
8073 2006-10-29 Marek Safar <marek.safar@gmail.com>
8075 A fix for bug #78602
8076 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8077 to protected member can be nested type.
8079 2006-10-28 Marek Safar <marek.safar@gmail.com>
8081 A fix for bug #78965
8082 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8083 to protected member must derive from current type.
8085 2006-10-27 Marek Safar <marek.safar@gmail.com>
8087 assign.cs: Reuses error method.
8089 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8090 instead of type for constants.
8091 (Expression.Error_ValueAssignment): Common error method.
8093 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8096 2006-10-27 Marek Safar <marek.safar@gmail.com>
8098 A fix for bug #79081
8099 * expression.cs (MemberAccess.DoResolve): Check nested type
8102 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8104 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8106 2006-10-26 Marek Safar <marek.safar@gmail.com>
8108 A fix for bug #76591
8109 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
8111 2006-10-26 Marek Safar <marek.safar@gmail.com>
8113 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
8114 type forwarder of the same type multiple times.
8116 2006-10-26 Raja R Harinath <rharinath@novell.com>
8119 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
8120 instance as an rvalue, even when we later resolve as an lvalue.
8122 2006-10-25 Martin Baulig <martin@ximian.com>
8124 * anonymous.cs: Fix #79673.
8126 2006-10-24 Marek Safar <marek.safar@seznam.cz>
8128 A fix for bug #79666
8129 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
8130 ignored when is optimized (= default value) as its value is already set.
8132 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8134 A fix for bug #79724
8135 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
8136 TypeContainer for type lookup.
8138 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8140 A fix for bug #79231
8141 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
8142 * expression.cs (OverloadResolve): Always convert type name for
8144 (ResolveNamespaceOrType): Don't confuse a nested type with any
8147 2006-10-18 Martin Baulig <martin@ximian.com>
8149 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
8151 2006-10-17 Miguel de Icaza <miguel@novell.com>
8153 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
8154 an int32, but requesting an int64 from the conversion
8156 2006-10-12 Martin Baulig <martin@ximian.com>
8159 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
8161 2006-10-12 Martin Baulig <martin@ximian.com>
8164 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
8166 2006-10-11 Miguel de Icaza <miguel@novell.com>
8168 * convert.cs: Remove broken code: I was doing the "Existance"
8169 tests for Implicit conversions.
8171 2006-10-10 Miguel de Icaza <miguel@novell.com>
8173 * convert.cs: Added one missing case in
8174 ImplicitStandardConversionExists uint64 to intptr.
8178 * typemanager.cs (uintptr_type): another core known type.
8180 * ecore.cs (OperatorCast): routine used to do cast operations that
8181 depend on op_Explicit. We could change some of the Decimal
8182 conversions to use this.
8184 This one has a probe mechanism that checks both types for an op_
8185 which it coudl be used to eliminate two classes: CastToDecimal
8186 and CastFromDecimal.
8188 * convert.cs: Implement the conversions documented in #59800
8190 2006-10-10 Martin Baulig <martin@ximian.com>
8192 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
8193 before RootScope.ResolveMembers().
8195 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
8196 `CurrentType' if appropriate.
8198 2006-10-09 Marek Safar <marek.safar@seznam.cz>
8200 A fix for bug #78568
8201 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
8202 when contains binary operators.
8203 * cs-parser.jay: Updated.
8205 2006-10-09 Martin Baulig <martin@ximian.com>
8208 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
8209 moved that into Define() and also do the other type parameter
8210 checks there. Fixes #79094. Added gtest-292.cs.
8213 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
8214 since that doesn't include type parameters; don't use `Ldelema'
8215 for type parameters. Fixes #78980. Added gtest-293.cs.
8217 2006-10-08 Marek Safar <marek.safar@seznam.cz>
8220 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
8221 conversion is allowed.
8223 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8225 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
8226 error reporting when no error occurs.
8228 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8230 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
8233 2006-10-06 Raja R Harinath <rharinath@novell.com>
8236 * class.cs (DefineTypeBuilder): Check circular dependencies before
8237 setting the parent of the TypeBuilder.
8238 (CheckRecursiveDefinition): Don't use 'BaseType', since
8239 it may not be valid until after DefineTypeBuilder. Use
8240 'base_type' instead.
8242 2006-10-04 Martin Baulig <martin@ximian.com>
8244 Merged the Anonymous Methods patch.
8246 * anonymous.cs, iterators.cs: The new anonymous methods code.
8248 * statement.cs (Variable): New public abstract class.
8249 (LocalInfo.Variable): New public property.
8250 (LocalInfo.ResolveVariable): New public method.
8251 (Block.Flags): Add `IsIterator'.
8252 (Block.AddVariable): Improved the CS0136 check.
8253 (Block.AnonymousChildren): New public property.
8254 (Block.AddAnonymousChild): New public method.
8255 (ToplevelBlock): Update to use the new anonymous method framework.
8256 (ToplevelBlock.ctor): `container' is now a `Block' and not a
8257 `ToplevelBlock'; this is required to correctly implement the
8259 (Fixed, Using): Use `TemporaryVariable' instead of directly
8260 creating the `LocalBuilder'.
8262 * parameter.cs (Parameter.ResolveVariable): New public method.
8263 (Parameters.ResolveVariable): Likewise.
8265 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
8267 * class.cs (TypeContainer): Replaced the `iterators' list and
8268 corresponding methods with a list of `CompilerGeneratedClass'es.
8269 (TypeContainer.ResolveMembers): New public method.
8270 (Method): `IIteratorContainer' has been replaced by
8273 * expression.cs (VariableReference): New public abstract base
8274 class for `LocalVariableReference', `ParameterReference' and
8277 * codegen.cs (EmitContext): Removed `capture_context',
8278 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
8279 (EmitContext.EmitThis): Removed.
8281 * cs-parser.jay: Replace `iterator_container' with
8284 2006-10-04 Martin Baulig <martin@ximian.com>
8286 * generic.cs (GenericMethod): Don't make this abstract.
8287 (Constraints.Clone): Added dummy implementation.
8289 2006-10-04 Raja R Harinath <harinath@gmail.com>
8292 * namespace.cs (LookForAnyGenericType): Avoid nullref on
8293 'declspaces'. Avoid allocating arrays willy-nilly.
8296 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
8297 cases out of the switch.
8299 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8301 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
8302 message when non-generic type is used with the type arguments.
8303 * expression.cs: Updated.
8305 2006-09-28 Raja R Harinath <rharinath@novell.com>
8308 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
8309 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8310 Change semantics slightly. Don't insist on having only one
8311 temporary EmptyExpression -- just throttle the creation of new ones.
8314 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
8315 non-interfaces too. If no methods are found, don't try to create
8318 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8320 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
8323 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
8324 us produce better error message.
8326 2006-09-27 Marek Safar <marek.safar@seznam.cz>
8328 * expression.cs (Binary.ResolveOperator): Warn about a side effect
8329 of the `|' operator.
8331 * report.cs: A new warning added.
8333 2006-09-27 Martin Baulig <martin@ximian.com>
8335 * generic.cs (GenericMethod): Don't make this abstract.
8337 2006-09-27 Martin Baulig <martin@ximian.com>
8340 (InternalErrorException): Added overloaded ctor taking a params array.
8342 2006-09-26 Marek Safar <marek.safar@seznam.cz>
8344 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
8345 Fixed the cases when same error was reported twice.
8347 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
8348 now report symbol information.
8350 2006-09-25 Martin Baulig <martin@ximian.com>
8352 * class.cs: Completely unified with the gmcs version.
8354 2006-09-25 Martin Baulig <martin@ximian.com>
8356 * typemanager.cs (TypeManager.IsNullableType): New public function.
8357 (TypeManager.IsNullableTypeOf): Likewise.
8358 (TypeManager.IsNullableValueType): Likewise.
8360 * class.cs (MethodCore): Added the `GenericMethod' argument from
8361 gmcs and also unified all classes derived from `MethodCore' with gmcs.
8363 2006-09-24 Raja R Harinath <harinath@gmail.com>
8365 * convert.cs: Unify with gmcs version.
8367 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8369 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
8370 verify them as well.
8372 * report.cs: New warning.
8374 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8376 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
8377 for anonymous block with out argument.
8379 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8381 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
8382 not used private events only.
8384 2006-09-23 Marek Safar <marek.safar@seznam.cz>
8386 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
8388 * const.cs (Const.Define): Check for constant type.
8389 (Const.IsConstantTypeValid): Looks for valid constant types.
8391 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
8393 * ecore.cs (EmptyConstantCast): New common class for all constant based
8396 * expression.cs (Is.DoResolve): Handle null constant especially.
8397 (New.DoResolve): Check for new void().
8398 (MemberAccess.DoResolve): Cope with all kind of nulls.
8400 * literal.cs (NullConstant): Uses EmptyConstantCast.
8401 (NullDefault): Based on EmptyConstantCast.
8402 (NullLiteral): Uses EmptyConstantCast.
8404 * statement.cs (Block.ResolveMeta): Check for constant type.
8406 2006-09-22 Martin Baulig <martin@ximian.com>
8408 * delegate.cs, attribute.cs: Merged with the gmcs versions.
8410 2006-09-22 Raja R Harinath <rharinath@novell.com>
8412 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
8416 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
8417 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
8420 2006-09-22 Martin Baulig <martin@ximian.com>
8422 * ecore.cs: Merged with the gmcs version.
8424 * generic.cs (ConstructedType): New dummy class.
8425 (TypeArguments): Don't make this abstract.
8428 (TypeManager.IsGenericTypeDefinition): New method.
8429 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
8431 2006-09-22 Raja R Harinath <rharinath@novell.com>
8433 * expression.cs (ComposedCast): Check for arrays of TypedReference
8434 before creating the type, not after.
8436 2006-09-21 Marek Safar <marek.safar@seznam.cz>
8438 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
8439 after ToType change.
8441 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
8442 when constant must be implicitly convertible.
8444 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
8446 * ecore.cs (NullCast): Derives from NullConstant.
8448 * expression.cs (Is.DoResolve): Removed useless variables.
8449 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
8450 (New.Constantify): Add enum support.
8451 (MemberAccess.DoResolve): Add warning when accessing null constant or
8454 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
8457 * literal.cs (NullConstant): New abstract class with common
8458 functionality for all null specializations.
8459 (NullDefault): Represents default(X) when result can be
8461 (NullLiteral): Updated.
8463 * report.cs: Add new warning.
8465 2006-09-21 Martin Baulig <martin@ximian.com>
8467 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
8469 2006-09-21 Martin Baulig <martin@ximian.com>
8471 * generic.cs (GenericConstraints): New dummy class.
8472 (Constraints): Likewise.
8473 (TypeParameter): Likewise.
8474 (TypeParameterName): Likewise.
8475 (GenericMethod): Likewise.
8477 * typemanager.cs (TypeManager.GetGenericArguments): New method.
8479 * decl.cs: Merged with the gmcs version.
8481 2006-09-21 Raja R Harinath <rharinath@novell.com>
8483 * generic.cs (TypeParameter): Implement IMemberContainer.
8484 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
8486 * rootcontext.cs: Unify with gmcs version.
8488 * report.cs: Unify with gmcs version.
8489 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
8490 from gmcs/generics.cs.
8491 * generics.cs (TypeParameter): New dummy class.
8493 * support.cs: Unify with gmcs version.
8495 2006-09-20 Raja R Harinath <rharinath@novell.com>
8497 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
8498 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
8500 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
8501 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
8502 * mcs.exe.sources: Add generic.cs.
8504 * codegen.cs: Unify with gmcs version.
8506 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
8507 (EmitContext): Add GenericDeclContainer implementation.
8508 * decl.cs (MemberCore, DeclSpace): Likewise.
8509 * namespace.cs: Remove #ifdef GMCS_SOURCE.
8511 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
8512 MCS TypeManager has a corresponding dummy method.
8514 2006-09-19 Martin Baulig <martin@ximian.com>
8516 * expression.cs: Completely merged with the gmcs version.
8518 2006-09-19 Martin Baulig <martin@ximian.com>
8520 * expression.cs (Invocation): Merged with the gmcs version.
8521 (ArrayAccess.GetStoreOpcode): Likewise.
8523 2006-09-19 Martin Baulig <martin@ximian.com>
8526 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
8527 (TypeManager.IsGenericMethodDefinition): Likewise.
8529 2006-09-19 Martin Baulig <martin@ximian.com>
8532 (TypeManager.IsEqual): Moved the gmcs implementation here.
8533 (TypeManager.DropGenericTypeArguments): Likewise.
8534 (TypeManager.DropGenericMethodArguments): Likewise.
8535 (TypeManager.GetTypeArguments): Moved here from gmcs.
8536 (TypeManager.HasGenericArguments): Likewise.
8538 2006-09-19 Martin Baulig <martin@ximian.com>
8540 * expression.cs (Binary): Merged with the gmcs version.
8542 2006-09-19 Martin Baulig <martin@ximian.com>
8544 * expression.cs (Probe, As, Is): Merged with the gmcs version.
8546 2006-09-19 Martin Baulig <martin@ximian.com>
8548 * typemanager.cs: Merged with the gmcs version.
8550 2006-09-16 Raja R Harinath <rharinath@novell.com>
8552 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
8553 * driver.cs: Likewise.
8555 2006-09-16 Marek Safar <marek.safar@seznam.cz>
8558 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
8559 only if parent type is class.
8560 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
8563 2006-09-15 Marek Safar <marek.safar@seznam.cz>
8566 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
8568 * typemanager.cs(CSharpName): Converts NullType to null.
8570 2006-09-15 Martin Baulig <martin@ximian.com>
8573 (TypeManager.GetMethodName): Added mcs implementation.
8574 (TypeManager.IsEqual): Likewise.
8577 (SimpleName.RemoveGenericArity): Added dummy implementation.
8579 * pending.cs: Merged with the gmcs version.
8581 2006-09-15 Martin Baulig <martin@ximian.com>
8583 * statement.cs: Merge with the gmcs version.
8585 2006-09-15 Martin Baulig <martin@ximian.com>
8587 * statement.cs (Switch): Merge with the gmcs implementation
8588 (without nullables), which is newer.
8590 2006-09-15 Martin Baulig <martin@ximian.com>
8592 * statement.cs (Block.Variables): Make this public.
8593 (ToplevelBlock.Parameters): Make this a property.
8594 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
8596 2006-09-15 Martin Baulig <martin@ximian.com>
8598 * namespace.cs: Merge with the gmcs version.
8600 2006-09-15 Martin Baulig <martin@ximian.com>
8602 * decl.cs (MemberName): Minor code cleanups.
8604 2006-09-15 Martin Baulig <martin@ximian.com>
8606 * parameter.cs: Merge with the gmcs version.
8608 2006-09-15 Martin Baulig <martin@ximian.com>
8610 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
8611 and an error in mcs.
8613 2006-09-15 Martin Baulig <martin@ximian.com>
8615 * flowanalysis.cs: Merged from GMCS; added the generics code into
8616 a `GMCS_SOURCE' conditional so we can share this file.
8618 2006-09-08 Martin Baulig <martin@ximian.com>
8620 * typemanager.cs (TypeManager.interlocked_type): New public field.
8621 (TypeManager.int_interlocked_compare-exchange): New public field.
8622 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
8623 enumerator types here and call InitGenericCoreTypes().
8624 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
8625 after calling InitEnumUnderlyingTypes().
8628 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
8629 `classes_second_stage'.
8631 2006-09-14 Marek Safar <marek.safar@seznam.cz>
8633 * assign.cs, ecore.cs, expression.cs: Share error message text.
8634 * class.cs (FieldMember.Define): Check for varible of static type.
8635 * driver.cs (LoadAssembly): Uses error output for errors.
8636 * statement.cs: Updated.
8638 2006-09-08 Marek Safar <marek.safar@seznam.cz>
8640 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
8643 2006-09-07 Martin Baulig <martin@ximian.com>
8646 (MainDriver): Revert r62663 from Marek; see #70506 for details.
8648 2006-08-29 Miguel de Icaza <miguel@novell.com>
8650 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
8652 2006-08-17 Miguel de Icaza <miguel@novell.com>
8654 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
8655 #52019 and #79064, the use of the \uXXXX sequence in source code
8656 to represent unicode characters.
8658 2006-08-15 Marek Safar <marek.safar@seznam.cz>
8660 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
8662 * class.cs, ecore.cs, statement.cs: Merged to one error message.
8664 2006-08-13 Miguel de Icaza <miguel@novell.com>
8666 * assign.cs: Catch attempts to assign to a method groups in += and
8669 2006-08-13 Marek Safar <marek.safar@seznam.cz>
8672 * cs-parser.jay: Don't destroy current array type by typeof of array's.
8674 2006-08-12 Marek Safar <marek.safar@seznam.cz>
8676 * class.cs (Method.Define): Issue a warning when generic method looks like
8678 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
8681 2006-08-09 Marek Safar <marek.safar@seznam.cz>
8683 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
8685 * decl.cs (MemberCache.FindMembers): When container is interface we need to
8686 search all base interfaces as a member can be ambiguous.
8687 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
8688 Constructor member type filter.
8689 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
8690 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
8691 reporting for returned memberinfos.
8692 * report.cs: Updated.
8693 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
8694 version to work on all runtimes.
8695 (TypeManager.RealMemberLookup): Removed members filtering.
8697 2006-08-08 Raja R Harinath <rharinath@novell.com>
8699 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
8700 (PropertyExpr.EmitAssign): Likewise.
8701 * expression.cs (Indirection.EmitAssign): Likewise.
8702 (LocalVariableReference.EmitAssign): Likewise.
8703 (ParameterReference.EmitAssign): Likewise.
8704 (Invocation.EmitArguments): Likewise.
8705 (ArrayAccess.EmitAssign): Likewise.
8706 (IndexerAccess.EmitAssign): Likewise.
8707 (This.EmitAssign): Likewise.
8708 (ConditionalLogicalOperator.Emit): Likewise.
8711 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
8712 instead of ArrayList. If the hashtable has a LocalBuilder, don't
8713 leave it in after returning it.
8714 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
8716 2006-08-06 Marek Safar <marek.safar@seznam.cz>
8718 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
8721 2006-08-03 Raja R Harinath <rharinath@novell.com>
8723 Fix cs0146-3.cs and cs0146-4.cs.
8724 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
8725 enclosing types don't depend on the current type.
8727 2006-08-02 Raja R Harinath <rharinath@novell.com>
8730 * class.cs (TypeContainer.DoDefineMembers): Use
8731 FindBaseMemberWithSameName on Parent, since we're interested in
8732 whether we hide inherited members or not.
8733 (FindBaseMemberWithSameName): Make slightly more robust.
8735 Fix the non-generic testcase from #77396
8736 * decl.cs (DeclSpace.DeclContainer): Remove override.
8738 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
8739 declspaces for doppelgangers too.
8740 (UsingEntry): Implement IResolveContext.
8741 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
8742 'this' as the resolve context.
8743 (LocalAliasEntry): Likewise.
8745 Implement parts of #77403
8746 * roottypes.cs (RootDeclSpace): New. Used to represent the
8747 toplevel declaration space. Each namespace declaration introduces
8748 a "partial" root declaretion space.
8749 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
8750 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
8751 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
8752 from 'current_namespace.SlaveDeclSpace'.
8753 (namespace_declaration): Likewise.
8754 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
8755 check. It can't happen now.
8756 * decl.cs (DeclSpace.LookupType): Likewise.
8757 * driver.cs (MainDriver): Sanity check.
8759 2006-08-01 Raja R Harinath <rharinath@novell.com>
8761 * decl.cs (DeclSpace.FindNestedType): Remove.
8762 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
8763 LookupTypeContainer to get the container of the nested type.
8764 * class.cs (TypeContainer.FindNestedType): Make non-override.
8766 2006-07-31 Raja R Harinath <rharinath@novell.com>
8768 * decl.cs (DeclSpace.PartialContainer): Move field from ...
8769 * class.cs (TypeContainer.PartialContainer): ... here.
8770 (TypeContainer.AddBasesForPart): New helper.
8771 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
8773 * cs-parser.jay (current_class): Convert to DeclSpace.
8774 (struct_declaration, interface_declaration, class_declaration):
8775 Use AddBasesForPart instead of .Bases directly.
8776 * const.cs, iterators.cs: Update to changes.
8778 2006-07-28 Raja R Harinath <rharinath@novell.com>
8780 * class.cs (TypeContainer.AddMemberType): Rename from
8782 (TypeContainer.AddMember): Rename from AddToMemberContainer.
8783 (AddTypeContainer): New. Combine AddClassOrStruct and
8785 (AddPartial): Update. Add 'is_partial' argument.
8786 * roottypes.cs: Update to changes.
8787 * cs-parser.jay (push_current_class): New helper for handling
8788 current_container and current_class.
8789 (struct_declaration, interface_declaration, class_declaration):
8792 2006-07-26 Raja R Harinath <rharinath@novell.com>
8794 * roottypes.cs: Rename from tree.cs.
8796 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
8797 * tree.cs (Tree, ITreeDump): Remove types.
8798 * rootcontext.cs (tree, Tree): Remove fields.
8799 (root, ToplevelTypes): New.
8800 * *.cs: Update to rename.
8802 * tree.cs (Tree.RecordDecl): Remove.
8803 (RootTypes.AddToTypeContainer): Record the toplevel type in its
8805 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
8807 2006-07-23 Raja R Harinath <harinath@gmail.com>
8809 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
8810 DoFlowAnalysis and OmitStructFlowAnalysis here.
8811 (ec.With): Rename from WithUnsafe and generalize.
8812 (ec.WithCheckState): Remove. All users can be handled by 'With'.
8813 (ec.WithFlowAnalyis): New.
8814 * ecore.cs, expression.cs, statement.cs: Update.
8816 2006-07-22 Raja R Harinath <harinath@gmail.com>
8818 * statement.cs (Block.ResolveMeta): Simplify slightly.
8820 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
8821 multiple boolean fields. Convert InUnsafe, constant_check_state,
8822 check_state to flags.
8823 (CheckState, ConstantCheckState): Update.
8824 (InUnsafe): New read-only property.
8825 (FlagsHandle): Rename from CheckStateHandle and convert to handle
8827 (WithUnsafe): New helper similar to WithCheckState.
8828 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
8829 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
8831 2006-07-21 Raja R Harinath <rharinath@novell.com>
8833 Make comparisons use the same IL irrespective of whether they're
8834 in a 'checked' or 'unchecked' context: one of the issues in #78899
8835 * codegen.cs (EmitContext.CheckState): Make read-only property.
8836 (EmitContext.ConstantCheckState): Likewise.
8837 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
8838 helper that implement a save/restore stack for CheckState
8839 values. This is the only way to change check-state.
8840 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
8841 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
8842 (CheckedExpr.EmitBranchable): New forwarding method.
8843 (UnCheckedExpr): Likewise.
8844 * statement.cs (Block.ResolveMeta): Use WithCheckState.
8845 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
8846 (Checked.Resolve, checked.DoEmit): Likewise.
8848 2006-07-20 Miguel de Icaza <miguel@novell.com>
8850 * anonymous.cs: Cache the resolved anonymous delegate, and return
8851 this so that the ResolveTopBlock is only triggered once, not
8854 Currently we trigger ResolvetopBlock twice due to a first pass of
8855 argument check compatibility, and a second pass that does the
8858 2006-07-15 Marek Safar <marek.safar@seznam.cz>
8860 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
8862 * rootcontext.cs (Reset): Add helper_classes.
8864 2006-07-15 Marek Safar <marek.safar@seznam.cz>
8867 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
8870 2006-07-13 Miguel de Icaza <miguel@novell.com>
8872 * statement.cs (Lock): Handle expressions of type
8873 TypeManager.null_type specially. Fixes #78770
8875 2006-07-08 Marek Safar <marek.safar@seznam.cz>
8877 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
8880 2006-07-08 Marek Safar <marek.safar@seznam.cz>
8882 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
8883 for accessors as well.
8884 * ecore.cs (EventExpr): Add AccessorTable.
8886 2006-07-01 Marek Safar <marek.safar@seznam.cz>
8889 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
8890 for CS0122 where appropriate.
8891 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
8893 (Filter): Assembly can be null in the case of top level attributes.
8895 2006-06-25 Marek Safar <marek.safar@seznam.cz>
8899 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
8900 is done at global level.
8902 2006-06-24 Marek Safar <marek.safar@seznam.cz>
8904 A fix for #77002, Implemented TypeForwarder support.
8906 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
8907 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
8908 * typemanager.cs (): Add type_forwarder_attr_type.
8910 2006-06-24 Marek Safar <marek.safar@seznam.cz>
8912 * report.cs: Add CS0469 warning.
8914 2006-06-21 Martin Baulig <martin@ximian.com>
8916 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
8917 the `try'-block, so we also report CS0016 etc. there.
8919 2006-06-21 Martin Baulig <martin@ximian.com>
8922 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
8924 2006-06-21 Martin Baulig <martin@ximian.com>
8926 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
8927 also report CS1686 for parameters.
8929 2006-06-21 Martin Baulig <martin@ximian.com>
8931 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
8932 instead of an error if the value is not implicitly convertible to
8933 the switch types; fixes #77964.
8935 2006-06-21 Raja R Harinath <rharinath@novell.com>
8938 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
8939 FieldBuilder is null.
8942 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
8943 'left' and 'right' before error-checking.
8945 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
8947 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
8949 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
8950 (FieldExpr.DoResolve): likewise.
8951 (PropertyExpr.InstanceResolve): likewise.
8952 (EventExpr.InstanceResolve): likewise.
8954 2006-06-04 Marek Safar <marek.safar@seznam.cz>
8956 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
8957 attribute applicable tests for attribute argument.
8959 2006-06-02 Raja R Harinath <rharinath@novell.com>
8962 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
8963 (Binary.OverloadResolve_PredefinedIntegral): New.
8964 (Binary.OverloadResolve_PredefinedFloating): New.
8965 (Binary.OverloadResolve_PredefinedString): New.
8966 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
8967 Follow the standard more closely, and treat numeric promotions in
8968 terms of overload resolution.
8969 (Binary.CheckShiftArguments): Simplify.
8971 2006-06-01 Raja R Harinath <rharinath@novell.com>
8973 * flowanalysis.cs (MyBitVector): Simplify representation.
8974 (MyBitVector.Clone): Avoid allocating BitArray.
8975 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
8976 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
8977 (*): Update. Change all references to MyBitVector.And and
8978 MyBitVector.Or to &= and |=.
8980 2006-05-29 Raja R Harinath <rharinath@novell.com>
8983 * cs-parser.jay (formal_parameter_list): Extend the pattern below
8984 to param arguments too.
8986 2006-05-26 Miguel de Icaza <miguel@novell.com>
8988 * cs-parser.jay: Catch another parsing form for arglist being
8989 followed by other arguments. Fixes #78313.
8991 2006-05-24 Raja R Harinath <rharinath@novell.com>
8993 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
8994 checking of out parameters to ...
8995 (FlowBranchingToplevel.Merge): ... here.
8996 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
8997 set, propagate the origin upward, and only complain if there was
8999 (FlowBranchingException.AddContinueOrigin): Likewise.
9000 (FlowBranchingException.AddReturnOrigin): Likewise.
9001 (FlowBranchingException.AddGotoOrigin): Likewise.
9003 2006-05-23 Raja R Harinath <rharinath@novell.com>
9005 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9006 unreachable, skip it.
9007 (FlowBranchingException.Merge): Always propagate jumps, even if
9008 the finally block renders subsequent code unreachable.
9010 2006-05-18 Raja R Harinath <rharinath@novell.com>
9013 * statement.cs (Goto.Resolve): Move responsibility for resolving
9014 'goto' to FlowBranching.AddGotoOrigin.
9015 (Goto.SetResolvedTarget): New. Callback to set the
9016 LabeledStatement that's the target of the goto.
9017 (Goto.DoEmit): Use Leave instead of Br when crossing an
9018 unwind-protect boundary.
9019 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9020 LookupLabel and adjust to new semantics.
9021 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9022 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9023 Goto.SetResolvedTarget to update target.
9024 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9025 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9026 AddBreakOrigin & co. Delay propagation until ...
9027 (FlowBranchingException.Merge): ... this.
9029 * statement.cs (Block.Resolve): Always depend on flow-branching to
9030 determine unreachability. Kill workaround that originally emitted
9031 only one statement after an "unreachable" label (see infloop in
9034 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9035 This is still "wrong", but anything better would probably need a
9036 multi-pass algorithm.
9037 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9038 usage vector. Force current usage vector to be reachable, to
9039 optimistically signify backward jumps.
9040 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9042 (FlowBranchingLabeled.Merge): New. If no backward jump was
9043 detected, return the original salted-away usage vector instead,
9044 updated with appropriate changes. Print unreachable warning if
9046 * statement.cs (Block.Resolve): Don't print unreachable warning on
9047 a labeled statement.
9049 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9051 * driver.cs: Pass filename without path to AssemblyBuilder's
9052 AddResourceFile. Fixes bug #78407.
9054 2006-05-17 Raja R Harinath <rharinath@novell.com>
9056 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9057 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9058 (FlowBranching.MergeChild): Overwrite
9059 reachability information from Labeled branchings too.
9061 2006-05-16 Raja R Harinath <rharinath@novell.com>
9063 * statement.cs (Goto.Resolve): Merge jump origins here ...
9064 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9066 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9067 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9068 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9069 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9071 * statement.cs (Goto.Resolve): ... not here.
9072 (Goto.Emit): Remove CS1632 check.
9074 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9076 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9079 2006-05-11 Raja R Harinath <rharinath@novell.com>
9081 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9082 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9083 (FlowBranchingException.Label): Likewise.
9085 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9087 (MyBitVector.Or): Use it to avoid losing information (Count).
9088 (FlowBranching.MergeOrigins): Likewise.
9090 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9091 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9092 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9093 (UsageVector.ToString): Simplify.
9094 (UsageVector.MergeSiblings): Move here from ...
9095 (FlowBranching.Merge): ... here.
9096 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9099 2006-05-10 Raja R Harinath <rharinath@novell.com>
9101 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9102 null bitvector is treated as all-true.
9104 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9105 (MyBitVector): Rationalize invariants. 'vector != null' implies
9106 that we have our own copy of the bitvector. Otherwise,
9107 'InheritsFrom == null' implies all inherited bits are true.
9109 2006-05-09 Marek Safar <marek.safar@seznam.cz>
9111 * statement.cs (LocalInfo): Add IsConstant.
9112 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
9113 local variable for constants.
9115 2006-05-09 Raja R Harinath <rharinath@novell.com>
9117 * flowanalysis.cs (MyBitVector.Empty): New.
9118 (MyBitVector): Don't allow InheritedFrom to be null.
9119 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
9120 (UsageVector, FlowBranching): Update to changes.
9122 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
9123 recursion. The 'Parent == null' condition isn't sufficient for
9125 (FlowBranching.AddBreakOrigin): Likewise.
9126 (FlowBranching.AddContinueOrigin): Likewise.
9127 (FlowBranching.AddReturnOrigin): Likewise.
9128 (FlowBranching.StealFinallyClauses): Likewise.
9129 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
9130 (FlowBranching.CheckOutParameters): Likewise.
9131 (FlowBranchingToplevel): Terminate all the above recursions here.
9132 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
9133 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
9135 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
9137 (FlowBranchingToplevel): New. Empty for now.
9138 (FlowBranching.MergeTopBlock): Update.
9139 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
9140 branching for the anonymous delegate.
9141 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
9143 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
9144 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
9145 information at the start of the merge. Reorganize.
9147 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9149 * class.cs (MethodData.Define): Method cannot implement interface accessor.
9151 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9153 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
9154 to newly introduced ctor.
9156 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
9157 message to one place.
9158 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
9161 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9163 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
9165 * ecore.cs (Expression.ResolveAsConstant): Updated.
9167 * statement.cs (ResolveMeta): Updated.
9169 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9171 * cs-parser.jay: __arglist cannot be used in initializer.
9173 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9176 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
9179 2006-05-05 Raja R Harinath <rharinath@novell.com>
9181 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
9182 (LabeledStatement): Add 'name' parameter.
9183 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
9184 (Block.AddLabel): Update to changes.
9185 * cs-parser.jay (labeled_statement): Likewise.
9187 * flowanalysis.cs (BranchingType.Labeled): New.
9188 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
9189 (FlowBranchingLabeled): New. Does nothing for now, but will
9190 eventually handle 'goto' flows.
9191 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
9192 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
9193 that's terminated ...
9194 (Block.Resolve): ... here.
9196 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
9197 (UsageVector.MergeFinallyOrigins): Likewise.
9198 (FlowBranching.InTryOrCatch): Likewise.
9199 (FlowBranching.AddFinallyVector): Likewise.
9200 (FlowBranchingException): Update to changes.
9203 * statement.cs (Return.Resolve): Move error checking to ...
9204 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
9205 (FlowBranchingException): Handle return origins like break and
9207 (FlowBranching.UsageVector.CheckOutParameters): Remove.
9209 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9212 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
9215 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9218 * class.cs (MethodData.Define): Do public accessor check only when method
9219 implements an interface.
9221 2006-05-04 Raja R Harinath <rharinath@novell.com>
9223 Remove special handling of 'break'
9224 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
9225 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
9226 (UsageVector.Break): Remove.
9227 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
9229 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
9231 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
9232 UsageVector.Breaks (). Don't set NeedsReturnLabel.
9234 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9237 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
9238 be the interface member.
9240 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9243 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
9244 for emitting small (int) values.
9246 2006-05-03 Raja R Harinath <rharinath@novell.com>
9249 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
9250 control-flow passes through the 'finally' after merging-in all the
9251 control-flows from 'try' and the 'catch' clauses.
9253 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
9254 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
9255 always true at the only non-recursive entry point.
9256 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
9257 FlowBranchingBreakable.
9258 (FlowBranchingLoop): Remove.
9259 * statement.cs (Return.DoResolve): Update to changes.
9262 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
9263 (FlowBranching.CreateBranching): Handle it: create a
9264 FlowBranchingContinuable.
9265 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
9266 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
9267 except that it handles the 'continue' command.
9268 (FlowBranching.UsageVector.MergeOrigins): Rename from
9270 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
9271 except that it overrides AddContinueOrigin.
9272 (FlowBranchingException): Override AddContinueOrigin, similar to
9274 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
9275 Create a new branching around the embedded statement.
9276 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
9277 control flow after the embedded statement.
9278 (Continue.Resolve): Move all error checking to AddContinueOrigin.
9280 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
9281 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
9282 FlowBranchingBreakable.
9283 (FlowBranchingSwitch): Remove.
9286 * statement.cs (Break.Resolve): Simplify. Move responsibility for
9287 error reporting to ...
9288 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
9289 Rename from 'AddBreakVector'. Add new location argument. Return
9290 a bool indicating whether the 'break' crosses an unwind-protect.
9291 (FlowBranchingException.AddBreakOrigin): Add.
9292 (FlowBranchingException.Merge): Propagate 'break's to surrounding
9293 flowbranching after updating with the effects of the 'finally'
9295 (FlowBranchingBreakable): New common base class for
9296 FlowBranchingLoop and FlowBranchingSwitch.
9298 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
9300 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
9302 2006-05-02 Raja R Harinath <rharinath@novell.com>
9304 * statement.cs (Do.Resolve): If the loop is infinite, set the
9306 (While.Resolve, For.Resolve): Set a barrier after the embedded
9307 statement. There's no direct control flow that goes from the end
9308 of the embedded statement to the end of the loop.
9309 * flowanalysis.cs (FlowBranching.Infinite): Remove.
9310 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
9311 above ensure that the reachability is correctly computed.
9313 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
9314 (UsageVector.MergeBreakOrigins): If the current path is
9315 unreachable, treat it as if all parameters/locals are initialized.
9316 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
9317 infinite loops before merging-in break origins.
9319 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
9320 (Reachability.Reachable): Split part into ...
9321 (Reachability.Unreachable): ... this. Simplify.
9322 (Reachability.IsUnreachable): Use 'Unreachable' instead.
9324 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
9325 (Reachability.SetThrowsSometimes): Likewise.
9326 (FlowBranchingBlock.MergeTopBlock): Don't compare against
9327 TriState.Always, use corresponding property.
9328 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
9329 (Block.Resolve): Likewise. Remove some redundant checks.
9331 2006-05-02 Raja R Harinath <harinath@gmail.com>
9333 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
9334 (Reachability.Meet): Don't bother checking AlwaysThrows --
9335 barrier is always set.
9336 (FlowBranchingBlock.Merge): Likewise.
9338 2006-05-01 Raja R Harinath <harinath@gmail.com>
9340 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
9341 checks for unreachable.
9343 2006-05-01 Marek Safar <marek.safar@seznam.cz>
9346 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
9348 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
9349 whether field is really assigned.
9351 2006-04-30 Raja R Harinath <harinath@gmail.com>
9353 * flowanalysis.cs (Reachability): Make 4-argument constructor
9355 (Reachability.Meet): Rename from 'And'. Remove static variant.
9356 (Reachability.Always): Rename from the highly misleading
9357 'Reachability.Never'.
9358 (FlowBranching.Merge): Update to changes. Mark an impossible
9359 situation with a 'throw'.
9360 (*): Update to changes.
9362 2006-04-29 Raja R Harinath <harinath@gmail.com>
9364 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
9366 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
9367 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
9368 (*): Update to changes.
9369 * statement.cs: Update to changes.
9371 2006-04-28 Marek Safar <marek.safar@seznam.cz>
9374 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
9376 2006-04-28 Raja R Harinath <harinath@gmail.com>
9378 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
9381 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
9382 argument to two arguments: an usage-vector and a bool. Move call
9383 to FlowBranching.Merge () ...
9384 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
9386 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
9387 handling of loop and switch reachability to ...
9388 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
9390 2006-04-27 Raja R Harinath <harinath@gmail.com>
9392 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
9393 handling to FlowBranchingLoop.InLoop.
9394 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
9396 2006-04-26 Marek Safar <marek.safar@seznam.cz>
9399 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
9400 anonymous method is allowed from AnonymousContainer here.
9402 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
9404 2006-04-24 Raja R Harinath <rharinath@novell.com>
9407 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
9409 2006-04-23 Marek Safar <marek.safar@seznam.cz>
9412 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
9413 (DoubleConstant.Reduce): Ditto.
9415 2006-04-23 Raja R Harinath <rharinath@novell.com>
9417 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
9418 Remove 'lvalue_right_side' argument. Move parts to ...
9419 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
9420 (LocalVariable.DoResolveLValue): ... these.
9422 2006-04-21 Raja R Harinath <rharinath@novell.com>
9425 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
9426 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
9427 (LocalVariableReference.DoResolveBase): Use it to implement new
9429 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
9430 (Argument.Resolve): Simplify. Move CS1510 check ...
9431 * ecore.cs (Expression.ResolveLValue): ... here.
9432 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
9433 (PropertyExpr.DoResolveLValue): Likewise.
9434 (FieldExpr.Report_AssignToReadonly): Likewise.
9435 (FieldExpr.DoResolve): Add 'out_access' argument. Use
9436 LValueMemberAccess or LValueMemberOutAccess on instance depending
9438 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
9439 DoResolve as appropriate.
9441 2006-04-20 Raja R Harinath <rharinath@novell.com>
9444 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
9445 implicit conversions on 'out' and 'ref' arguments.
9447 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
9448 improve clarity. Remove dead code.
9451 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
9452 (Catch.Resolve): Resolve VarBlock if it exists.
9454 2006-04-19 Miguel de Icaza <miguel@novell.com>
9456 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
9457 twice, this was some residual code, the enumerator was emitted
9458 properly in the two branche of if later.
9460 2006-04-19 Raja R Harinath <rharinath@novell.com>
9462 * expression.cs (Cast.ResolveLValue): Remove. The result of a
9463 cast is never an lvalue.
9464 (Cast.DoResolve, Cast.ResolveRest): Combine.
9465 (Argument.Emit): Simplify slightly. Move 'Expr is
9466 IMemoryLocation' check ...
9467 (Argument.Resolve): ... here.
9468 (Argument.Error_LValueRequired): Remove. Inline into only user.
9470 Simplifications. Fix cs0191-2.cs
9471 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
9472 CS1649 and CS1651 to ...
9473 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
9474 the actual selection of the error code and message to a lookup
9475 table. Add a dummy return value to simplify callsites.
9476 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
9477 readonly fields of other instances of the same type. Move CS0197
9479 * expression.cs (Argument.Resolve): ... here. Simplify code.
9480 Ensure that ec.InRefOutArgumentResolving is only set during LValue
9481 resolution of an out or ref argument. The code simplification
9482 above uses this invariant.
9484 2006-04-18 Raja R Harinath <rharinath@novell.com>
9486 Possibly fix #77752. Fix cs1690-[4-7].cs.
9487 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
9488 CheckMarshallByRefAccess. Drop parameter.
9489 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
9491 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
9493 * report.cs (AllWarnings): Add CS1690.
9494 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
9496 (LocalVariableReference.DoResolveBase): Update.
9498 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9500 * class.cs (MethodOrOperator): Moved common parts from method class.
9501 detect obsolete attributes.
9502 (Method.Define): Simplified as it reuses code from base.
9503 (Constructor.ValidAttributeTargets): Fixed issue found during
9505 (Destructor.ValidAttributeTargets): Fixed issue found during
9507 (Operator): Finished refactoring set off by #78020. Operator class is now
9508 ordinary method class.
9510 * anonymous.cs: Updated.
9512 * decl.cs (DeclSpace): Add IsGeneric
9514 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9516 * class.cs (Constructor.Emit): Don't emit the attributes twice.
9518 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9520 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
9521 detect obsolete attributes.
9522 (Method.CreateEmitContext): Moved to MethodOrOperator.
9524 2006-04-09 Marek Safar <marek.safar@seznam.cz>
9527 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
9528 customized exception to make crash detection easier.
9529 (MethodOrOperator): Started to work on new base class for methods and
9531 (Method): Derives from MethodOrOperator.
9532 (Constructor.Emit): Emits its own attributes.
9533 (AbstractPropertyEventMethod.Emit): Ditto.
9534 (Operator): Derives from MethodOrOperator, will refactor fully in extra
9536 (Operator.Emit): It's temporary more tricky than should be.
9538 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
9540 * report.cs (InternalErrorException): Add ctor with inner exception.
9542 2006-04-08 Marek Safar <marek.safar@seznam.cz>
9545 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
9548 2006-04-07 Marek Safar <marek.safar@seznam.cz>
9551 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
9554 2006-04-06 Marek Safar <marek.safar@seznam.cz>
9556 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
9557 attribute is present and Guid not.
9558 (Interface.ApplyAttributeBuilder): Ditto.
9560 * attribute.cs: Add error message.
9562 2006-04-06 Marek Safar <marek.safar@seznam.cz>
9566 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
9567 sources (it's composite) so hold them in extra array as they are used in
9568 Emit phase only. It worked in the previous versions by mistake.
9569 (Attribute.Emit): Emit attribute for more owners when exist.
9571 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
9572 it has now different behaviour.
9574 2006-04-04 Marek Safar <marek.safar@seznam.cz>
9576 * constant.cs (Constant.IsDefaultInitializer): New method.
9578 * class.cs: Updated.
9580 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
9581 re-initialize default values. It saves KBs almost for every assembly.
9582 Thanks Zoltan for the idea.
9583 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
9584 (ArrayCreation.DoResolve): Resolve only once.
9585 (ArrayCreation.Emit): Emit static initializer only when it is faster.
9586 (ArrayCreation.GetAttributableValue): Cope with optimized values.
9588 2006-04-03 Zoltan Varga <vargaz@gmail.com>
9590 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
9593 2006-04-01 Marek Safar <marek.safar@seznam.cz>
9595 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
9596 in an embedded statement too.
9598 2006-04-01 Raja R Harinath <rharinath@novell.com>
9601 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
9603 2006-04-01 Marek Safar <marek.safar@seznam.cz>
9607 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
9610 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
9612 2006-03-31 Marek Safar <marek.safar@seznam.cz>
9614 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
9617 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
9618 LocalTemporary change.
9620 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
9622 (ClassOrStruct.DefineFieldInitializers): Implemented static field
9623 initializers optimization.
9624 (ClassOrStruct.TypeAttr): Moved from modifiers.
9625 (Constructor.CheckBase): Don't crash when static ctor has parameters.
9626 (FieldBase.ResolveInitializer): Resolves initializer.
9627 (FieldBase.HasDefaultInitializer): New property.
9629 * cs-parser.jay: Removed message.
9631 * expression.cs (CompilerGeneratedThis): New specialization.
9633 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
9635 2006-03-28 Marek Safar <marek.safar@seznam.cz>
9637 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
9639 2006-03-27 Marek Safar <marek.safar@seznam.cz>
9641 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
9642 be now EnumConstants only.
9644 2006-03-27 Marek Safar <marek.safar@seznam.cz>
9646 * attribute.cs, driver.cs: Reset more caches.
9648 2006-03-26 Marek Safar <marek.safar@seznam.cz>
9650 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
9652 2006-03-26 Marek Safar <marek.safar@seznam.cz>
9654 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
9655 for easier reuse. Updated all overrides.
9656 (IntegralConstant): New base class for all integral constants.
9657 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
9658 of the constant range, report custom error.
9659 (UIntConstant.Reduce): Fixed uint conversion.
9661 * ecore.cs, literal.cs: Reduce updates.
9663 2006-03-26 Marek Safar <marek.safar@seznam.cz>
9667 * class.cs (Constructor.Define): Removed extra if for default ctors.
9668 A patch from Atsushi Enomoto.
9670 2006-03-26 Marek Safar <marek.safar@seznam.cz>
9672 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
9673 GetAttributableValue.
9675 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
9678 * convert.cs (ImplicitConversionRequired): Error message moved to
9681 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
9682 automatic implicit conversion of an output value.
9683 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
9685 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
9687 (TypeOf.GetAttributableValue): Add extra handling for object type.
9689 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
9690 special error message.
9692 2006-03-25 Marek Safar <marek.safar@seznam.cz>
9694 * class.cs (Constructor.Emit): Don't crash when struct ctor is
9696 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
9697 compatible with MS runtime.
9699 2006-03-23 Marek Safar <marek.safar@seznam.cz>
9701 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
9702 attribute arguments here.
9704 * class.cs (Indexer.Define): The check was moved to attribute class.
9706 2006-03-22 Marek Safar <marek.safar@seznam.cz>
9708 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
9709 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
9712 2006-03-22 Raja R Harinath <rharinath@novell.com>
9714 Support ParameterDefaultValueAttribute in gmcs. Also applied to
9715 mcs to keep code differences small.
9716 * attribute.cs (Attribute.GetParameterDefaultValue): New.
9717 * typemanager.cs (parameter_default_value_attribute_type): New.
9718 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
9721 2006-03-21 Marek Safar <marek.safar@seznam.cz>
9723 * expression.cs (StringConcat.Append): Reverted back to no warning state.
9725 2006-03-21 Marek Safar <marek.safar@seznam.cz>
9727 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
9729 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
9732 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
9734 * doc-bootstrap.cs : fix build.
9736 2006-03-20 Marek Safar <marek.safar@seznam.cz>
9738 * expression.cs (StringConcat.Append): Issue a warning when empty string
9741 2006-03-20 Marek Safar <marek.safar@seznam.cz>
9743 * assign.cs (CompoundAssign.ResolveSource): Removed.
9745 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
9748 * class.cs (TypeContainer.FindMethods): Removed.
9749 (TypeContainer.CheckMemberUsage): Made static.
9751 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
9753 * constant.cs (CheckRange): Removed unused type argument.
9754 (CheckUnsigned): Removed unused type argument.
9756 * cs-parser.jay: Updated after MemberAccess clean up.
9757 Uses Length for empty string test.
9759 * cs-tokenizer.cs: Uses Length for empty string test.
9760 (IsCastToken): Made static.
9761 (is_hex): Made static.
9762 (real_type_suffix): Made static.
9764 * decl.cs (SetupCache): Made static.
9765 (OnGenerateDocComment): Removed unused ds argument.
9767 * delegate.cs (VerifyDelegate): Removed unused argument.
9769 * doc.cs: Uses Length for empty string test.
9771 * driver.cs: Uses Length for empty string test.
9773 * enum.cs (IsValidEnumType): Made static
9775 * expression.cs (EnumLiftUp): Removed unused argument.
9776 (ResolveMethodGroup): Ditto.
9777 (BetterConversion): Ditto.
9778 (GetVarargsTypes): Ditto.
9779 (UpdateIndices): Ditto.
9780 (ValidateInitializers): Ditto.
9781 (MemberAccess.ctor): Ditto.
9782 (GetIndexersForType): Ditto.
9784 * flowanalysis.cs: (MergeFinally): Removed unused argument.
9786 * iterators.cs: Updated after MemberAccess clean up.
9788 * location.cs: Uses Length for empty string test.
9790 * namespace.cs: Uses Length for empty string test.
9792 * report.cs (CheckWarningCode): Made static.
9794 * statement.cs (LabeledStatement): Removed unused argument.
9796 * typemanager.cs (FilterNone): Removed.
9798 2006-03-18 Marek Safar <marek.safar@seznam.cz>
9800 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
9803 * class.cs: Updated.
9805 2006-03-18 Marek Safar <marek.safar@seznam.cz>
9807 * cs-parser.jay.cs: __arglist is not allowed for delegates.
9809 2006-03-18 Marek Safar <marek.safar@seznam.cz>
9813 * expression.cs (VerifyArgumentsCompat): Reverted to double error
9814 reporting, it's more tricky than I thought.
9816 2006-03-18 Marek Safar <marek.safar@seznam.cz>
9820 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
9822 (AnonymousMethod.ImplicitStandardConversionExists): New method.
9823 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
9824 Add more error reporting; Fixed issue with params.
9826 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
9828 * cs-parser.jay: AnonymousMethod requires host container.
9830 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
9832 2006-03-18 Raja R Harinath <harinath@gmail.com>
9834 * class.cs: Change 'TypeContainer ds' constructor argument to
9835 'DeclSpace parent'. Some classes were missed below due to
9836 different naming convention.
9838 * class.cs (MemberCore.Parent): Delete. This makes the
9839 ParentContainer changes below enforceable by the compiler.
9841 Treat pointers to enclosing declaration space as 'DeclSpace', not
9843 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
9844 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
9846 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
9848 (Block.AddThisVariable): Likewise.
9849 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
9850 (AbstractPropertyEventMethod.Emit): Likewise.
9851 (AbstractPropertyEventMethod.EmitMethod): Likewise.
9852 (GetMethod.Define, SetMethod.Define): Likewise.
9853 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
9854 (DelegateMethod.EmitMethod): Likewise.
9856 Fix regression test-partial-13.cs.
9857 Rationalize use of PartialContainer. Ensure that the partial
9858 class semantics can be tied to type-correctness, i.e., any
9859 violation will cause a compile error.
9860 * class.cs, const.cs: Access all fields that belong to class
9861 TypeContainer via ParentContainer. Arguments of EmitContexts and
9862 Resolve()-like functions still use 'Parent'.
9864 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
9865 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
9866 (PropertyMethod.CheckModifiers): Remove unused argument.
9867 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
9870 2006-03-17 Raja R Harinath <harinath@gmail.com>
9872 Make semantics of PartialContainer simpler.
9873 * decl.cs (DeclSpace.IsPartial): Remove.
9874 * class.cs (TypeContainer.IsPartial): Likewise.
9875 (TypeContainer..ctor): Set PartialContainer to point to self.
9876 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
9877 (TypeContainer.FindNestedType): Likewise.
9878 (MemberCore.ParentContainer): Simplify. Remove deprecation.
9880 2006-03-17 Marek Safar <marek.safar@seznam.cz>
9882 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
9884 2006-03-15 Marek Safar <marek.safar@seznam.cz>
9886 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
9889 2006-03-15 Marek Safar <marek.safar@seznam.cz>
9891 * class.cs (Operator.Define): An error for base conversion was not
9894 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
9896 * iterator.cs : yield break is allowed in try statement which has
9897 catch clauses. Fixed bug #77767.
9899 2006-03-13 Marek Safar <marek.safar@seznam.cz>
9901 A fix for #77593, #77574.
9903 * class.cs (MethodCore.CheckBase): Another if for operator.
9905 2006-03-09 Marek Safar <marek.safar@seznam.cz>
9907 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
9910 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
9911 (DelegateCreation.ImplicitStandardConversionExists): New method for just
9914 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
9917 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
9918 Updated after another emitcontext usage was clean up. It should help us to
9919 synchronize with gmcs easier.
9921 2006-03-04 Marek Safar <marek.safar@seznam.cz>
9925 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
9926 (Event.Define): ditto
9927 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
9929 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
9930 Removed redundant code and set NewSlot for Invoke method too.
9932 * parameter.cs (Parameters.ctor): Add custom, type ctor.
9933 (Parameters.MergeGenerated): New method. Use this method when you merge
9934 compiler generated argument with user arguments.
9936 2006-03-03 Marek Safar <marek.safar@seznam.cz>
9938 * attribute.cs (ResolveAsTypeTerminal): Removed.
9940 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
9941 specialization for predefined types; 30% speed up.
9942 Finally placed obsolete check to right place.
9943 (Expression.ResolveType): Removed.
9945 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
9946 Updated after ResolveType was removed.
9948 * expression.cs (Cast.ctor): Check void cast.
9949 (Binary.ResolveAsTypeTerminal): Is never type.
9950 (Conditional.ResolveAsTypeTerminal): Is never type.
9952 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
9954 2006-03-01 Raja R Harinath <rharinath@novell.com>
9957 * expression.cs (ParameterReference.DoResolveBase): Change return
9959 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
9963 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
9966 * typemanager.cs (GetFullNameSignature): Don't nullref on
9967 protected accessors.
9969 2006-02-27 Marek Safar <marek.safar@seznam.cz>
9971 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
9972 these two separated members to simplify the code.
9973 (Attribute.Resolve): Refactored to use new fields and methods.
9974 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
9975 implemented obsolete attribute checking.
9976 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
9977 implemented obsolete checking again. It look line never ending quest ;-)
9978 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
9980 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
9982 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
9984 *class.cs (Property.Define): Add RegisterProperty call.
9986 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
9987 argument groups (only 2).
9989 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
9990 encoding expression to arguments.
9991 (Expression.ExprClassToResolveFlags): Just turned to property.
9993 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
9994 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
9995 optimized as well as implemented support for zero-length attributes.
9997 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
9998 Add caching of PropertyInfo's.
10000 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10002 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10003 error multiple times.
10005 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10007 New partial class implementation.
10008 A fix for #77027, #77029, #77403
10010 * attribute.cs (Attributable): Made attributes protected.
10012 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10013 the replacements of ClassPart and PartialContainer.
10014 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10015 (TypeContainer.AddInterface): Ditto.
10016 (TypeContainer.AddPartial): The main method for partial classes. It checks
10017 for errors and merges ModFlags and attributes. At the end class is added to
10018 partial_parts list.
10019 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10021 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10022 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10023 from the rest of partial classes.
10024 (TypeContainer.GetClassBases): Simplified.
10025 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10027 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10028 (TypeContainer.HasExplicitLayout): Uses Flags now.
10029 (PartialContainer): Removed.
10030 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10031 (StaticClass): Was merged with Class.
10032 (Class.GetClassBases): class and static class bases are verified here.
10033 (Class.TypeAttr): Added static attributes when class is static.
10034 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10035 (MemberBase): In some cases we need to call parent container for partial
10036 class. It should be eliminated but it's not easy now.
10038 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10040 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10041 partial classed to accumulate class comments.
10042 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10044 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10046 * driver.cs (MainDriver): Tree.GetDecl was removed.
10048 * modifiers.cs (Modifiers): Add partial modifier.
10050 * tree.cs (Tree.decl): Removed.
10051 (RootTypes): Started to use this class more often for root types
10054 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10058 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10059 external interface does not have an attribute.
10061 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10063 Another prerequisites for new partial classs implementation.
10065 * attribute.cs (Attribute.Equal): Implemented.
10066 (Attribute.Emit): Changed as attributes can be applied more than twice.
10067 (Attributes.Emit): Check for duplicate attributes here.
10069 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10070 as a parameter, clean-up.
10072 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10076 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10077 contains obsolete attribute check which can in some cases look for base
10078 type of current class which is not initialized yet.
10079 (TypeContainer.BaseType): Replacement of ptype.
10081 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10083 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10085 First of prerequisites for new partial classs implemention.
10087 * attribute.cs (Attributable): Extended by ResolveContext;
10088 Attributes finally have correct context for resolving in all cases.
10089 (AttachTo): Attribute owner is assigned here.
10091 * codegen.cs (IResolveContext): Introduce new interface to hold
10092 all information needed in resolving phase.
10093 (EmitContext): Implements IResolveContext; more clean-up needed here.
10095 * decl.cs (MemberCore): Implemented IResolveContext.
10097 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10098 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10099 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10100 Refactored to use new IResolveContext instead of EmitContext; cleanup
10102 2006-02-06 Miguel de Icaza <miguel@novell.com>
10104 * codegen.cs (EmitScopeInitFromBlock): check here the
10105 capture_context, there is no need to make two calls to the
10108 * anonymous.cs: Add some debugging messages that might help me
10109 track other instances of this problem in the future (the
10110 regression of test 467).
10112 * cs-parser.jay: track the variable block, as we need to initalize
10113 any captured variables declared in this block for the "catch"
10114 portion of the "Try" statement.
10116 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
10117 scope initialization for captured variables.
10119 Also, move the emit for the variables after the block location has
10122 2006-02-06 Marek Safar <marek.safar@seznam.cz>
10124 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
10126 2006-02-02 Miguel de Icaza <miguel@novell.com>
10128 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
10129 commit yesterday, the initialization for the roots is necessary.
10130 What is not necessary is the scope activation.
10132 2006-02-02 Raja R Harinath <rharinath@novell.com>
10134 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
10135 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
10137 (Argument.Resolve): Remove CS0206 checks.
10139 2006-02-01 Miguel de Icaza <miguel@novell.com>
10141 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
10142 scopes for all the roots, the scopes will now be emitted when the
10143 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
10145 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
10146 code. This reduces a lot of existing cruft.
10148 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
10149 that the ScopeInfo is generated as we enter the scope, not at the
10150 time of use, which is what we used to do before.
10152 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
10153 every time a Block is about to be emitted if we have a
10156 2006-02-01 Raja R Harinath <rharinath@novell.com>
10158 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
10160 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
10162 * typemanager.cs (cons_param_array_attribute): Make private.
10163 (Reset): Set it to null.
10164 (InitCoreHelpers): Don't initialize it.
10165 (ConsParamArrayAttribute): New. Initialize it as needed.
10166 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
10168 2006-01-31 Miguel de Icaza <miguel@novell.com>
10170 * expression.cs: There might be errors reported during the
10171 selection of applicable methods. If there are errors, do not
10172 continue execution as it will lead the compiler to crash.
10174 2006-01-30 Miguel de Icaza <miguel@novell.com>
10176 * expression.cs: Member access is not allowed on anonymous
10177 methods. Fixes #77402.
10179 2006-01-30 Raja R Harinath <rharinath@novell.com>
10182 * cs-parser.jay (VariableDeclaration): Don't set
10183 current_array_type to null.
10184 (field_declaration, event_declaration, declaration_statement):
10185 Set it to null here.
10187 2006-01-28 Raja R Harinath <harinath@gmail.com>
10189 * typemanager.cs (GenericParameterPosition): New.
10192 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
10194 * doc.cs : To process "include" elements, first we should create
10195 another list than XmlNodeList, because it could result in node
10196 removal, which could result in that the XmlNodeList gives up
10197 yielding next node.
10199 (Also made code identical to gmcs again.)
10201 2006-01-25 Miguel de Icaza <miguel@novell.com>
10203 * ecore.cs: Introduce an error report that we were not catching
10204 before, if not silent, we must report the error. Gonzalo ran into
10207 2006-01-23 Miguel de Icaza <miguel@novell.com>
10209 A fix for bug: #76957
10211 * iterators.cs (MoveNextMethod.CreateMethodHost): call
10212 ComputeMethodHost before creating the method, this is a new
10215 * anonymous.cs (AnonymousContainer): Now we track all the scopes
10216 that this method references (RegisterScope). The actual scope
10217 where the method is hosted is computed with the ComputeMethodHost
10218 before we create the method.
10220 Moved the Deepest routine here.
10222 (AnonymousContainer.ComputeMethodHost): New routine used to
10223 compute the proper ScopeInfo that will host the anonymous method.
10225 (ScopeInfo): Deal with multiple roots. The problem was that we
10226 did not have a unique root where all ScopeInfos could be hanged
10227 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
10230 Remove AdjustMethodScope which is now computed at the end. Remove
10231 LinkScope which did a partial link, instead link all ScopeInfos
10232 before code generation from the new "LinkScopes" routine.
10234 Simplify all the Add* routines as they no longer need to maintain
10235 the tree, they just need to record that they are using variables
10238 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
10239 routines to produce the forest of ScopeInfo trees.
10241 * class.cs (TypeContainer.AppendMethod): This is just like
10242 AddMethod, but ensures that an interface implementation method
10243 (IEnumerable.XXX) is not inserted at the beginning of the queue of
10244 methods, but at the end.
10246 We use this functionality to ensure that the generated MoveNext
10247 method in the iterator class is resolved/emitted before the
10248 enumerator methods created.
10250 This is required because the MoveNext method computes the right
10251 ScopeInfo for the method. And the other methods will eventually
10252 need to resolve and fetch information computed from the anonymous
10255 2006-01-21 Raja R Harinath <harinath@gmail.com>
10256 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10258 Fix rest of #76995.
10259 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
10260 the 'aliases' hash.
10261 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
10262 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
10264 2006-01-18 Raja R Harinath <rharinath@novell.com>
10266 Fix #76656, cs0231-2.cs.
10267 * cs-parser.jay (formal_parameter_list): Make error case catch
10269 (parenthesized_expression_0): Add CS1026 check.
10270 (invocation_expression): Remove unused { $$ = lexer.Location }.
10272 2006-01-17 Raja R Harinath <rharinath@novell.com>
10275 * cs-parser.jay (statement_expression): Don't list out the
10276 individual statement-expressions. Convert syntax error into
10279 2006-01-16 Raja R Harinath <rharinath@novell.com>
10282 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
10283 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
10284 CheckIntermediateModification.
10285 (FieldExpr.DoResolve): Add new two-argument version that
10286 allows us to resolve the InstanceExpression as an lvalue.
10287 The one-argument variant is now just a wrapper.
10288 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
10289 Resolve the lhs as an lvalue if the it has a value type.
10290 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
10291 from Assign.DoResolve.
10292 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
10293 resolved as an lvalue.
10294 (PropertyExpr.DoResolve): Update.
10295 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
10296 has a value type. Move CS1612 check here from
10297 CheckIntermediateModification.
10298 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
10299 * expression.cs (EmptyExpression.OutAccess): New. Used as the
10300 'right_side' of a ResolveLValue on an 'out' argument.
10301 (EmptyExpression.LValueMemberAccess): New. Used as the
10302 'right_side' of a propagated ResolveLValue on a value type.
10303 (LocalVariableReference.DoResolveBase): Recognize
10304 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
10306 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
10307 EmptyExpression.Null.
10309 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
10311 * typemanager.cs : added IsGenericParameter(). In mcs it always
10313 * doc.cs : for generic parameters, use GenericParameterPosition,
10316 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
10318 * expression.cs: Fix Console.WriteLine ((this = x).foo);
10320 2006-01-12 Miguel de Icaza <miguel@novell.com>
10322 This fixes the problem where we used ldfld instead of ldflda to
10323 load the "THIS" pointer on captured parameters, when THIS is a
10324 value type. See bug #77205.
10326 * iterators.cs (CapturedThisReference.Emit): Pass false to
10327 EmitThis (we do not need the address).
10329 * codegen.cs (EmitThis): it needs to know whether we need the
10330 address of `this' or not. This is used by value types.
10332 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
10333 every other call passes false.
10335 2006-01-12 Raja R Harinath <rharinath@novell.com>
10338 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
10340 * expression.cs (Invocation.OverloadResolve): Update.
10341 (Invocation.DoResolve): Avoid double resolution of invocation.
10343 2006-01-11 Raja R Harinath <rharinath@novell.com>
10346 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
10347 unary negation of floating point types as 0-expr; negation cannot
10348 overflow in floating point types.
10351 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
10352 on operands of 'void' type.
10355 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
10356 and ExclusiveOr for boolean constants too.
10358 2006-01-09 Raja R Harinath <rharinath@novell.com>
10361 * expression.cs (Invocation.OverloadResolve): Replace reflected
10362 override methods with their base virtual methods, rather than
10363 skipping over them.
10364 * typemanager.cs (TypeManager.GetOverride): New.
10366 2006-01-05 Jb Evain <jbevain@gmail.com>
10368 * class.cs (Property.Define, Indexer.Define): do not tag the
10369 properties as SpecialName | RTSpecialName.
10371 2006-01-04 Miguel de Icaza <miguel@novell.com>
10373 * class.cs (MethodCore.IsDuplicateImplementation): This method was
10374 doing a low-level comparission of parameter types. It was lacking
10375 a check for __argslist.
10377 2005-12-30 Miguel de Icaza <miguel@novell.com>
10379 * expression.cs (ParameterReference.DoResolveBase): Allow
10380 reference parameters if they are local to this block.
10382 This allows the ref and out parameters of a delegate to be used in
10383 an anonymous method, for example:
10385 delegate void set (out int x);
10387 set s = delegate (out int x){
10391 This is used by functionality introduced late in the C# language.
10393 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
10394 method that take ref and out parameters.
10396 Fixes #77119 which was a late change in the spec.
10398 2005-12-23 Miguel de Icaza <miguel@novell.com>
10400 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
10401 parent if its the same scope. Fixes #77060.
10403 2005-12-21 Miguel de Icaza <miguel@novell.com>
10405 * driver.cs: Report the case of no source files and no -out:
10408 2005-12-20 Raja R Harinath <rharinath@novell.com>
10411 * expression.cs (ComposedCast.GetSignatureForError): Define.
10413 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10417 * namespace.cs (NamespaceEntry): Add extern_aliases as a
10418 ListDictionary, to contain the ExternAliasEntry entries (in
10419 addition to the NamespaceEntry.aliases hashtable). This field is
10420 shared between the original entry and its doppelganger (bodyless
10422 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
10423 extern_aliases field.
10424 (NamespaceEntry.Lookup): Move the IsImplicit check after the
10425 lookup in extern_aliases.
10427 2005-12-16 Raja R Harinath <rharinath@novell.com>
10430 * class.cs (TypeContainer.Mark_HasEquals): New.
10431 (TypeContainer.Mark_HasGetHashCode): New.
10432 (ClassPart): Override them.
10433 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
10436 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
10437 'parent' argument to the base constructor.
10439 Remove all mention of TypeContainer from decl.cs.
10440 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
10441 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
10442 (DeclSpace.DeclSpace): Likewise.
10443 (DeclSpace.DefineMembers): Remove unused argument.
10444 * cs-parser.jay (pop_current_class): Update to changes. Simplify
10445 debugging check -- we don't care if the debug code throws an
10446 InvalidCastException instead of an InternalErrorException.
10447 * class.cs (TypeContainer.DefineMembers): Update to changes.
10448 (TypeContainer.DoDefineMembers): Likewise.
10449 (TypeContainer.GetMethods): Likewise.
10450 (PropertyMember.Define): Likewise.
10451 (MemberBase.Parent): New property that forwards to
10452 MemberCore.Parent, but ensures that we get a TypeContainer.
10453 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
10454 (RootContext.PopulateTypes): Likewise. Remove special case code
10455 for !RootContext.StdLib: DefineMembers is idempotent.
10457 2005-12-14 Miguel de Icaza <miguel@novell.com>
10459 * convert.cs (ExplicitConversionCore): Check the return value from
10460 ExplicitConversionCore which can return null on failure. Fixes #76914
10462 2005-12-13 Marek Safar <marek.safar@seznam.cz>
10464 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
10466 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
10468 * doc.cs : The search for referenced namespace was insufficient to
10469 get global one as it used to do. Fixed bug #76965.
10471 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
10473 * doc.cs : check name in cref in the last phase that whether it is
10476 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10478 * cs-tokenizer.cs : reverted the latest change: it somehow broke
10481 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10483 * doc.cs : so it turned out that we cannot skip override check for
10484 interface members. Fixed bug #76954.
10486 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
10488 * cs-tokenizer.cs : fixed bug #75984:
10489 - #warning and #error should not be handled when the source line
10491 - #line is not checked strictly when the source line is disabled.
10492 - #define and #undef is on the other hand checked strictly at any
10495 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
10497 * cs-tokenizer.cs : missing Location (actually, filename) in one of
10500 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10502 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
10504 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
10505 event initializers.
10506 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
10507 (FieldBase.Initializer): Initializer is now optional.
10508 (EventField.Define): Only event field can have initializer.
10510 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
10512 * const.cs (Const): Reuse initializer.
10514 * cs-parser.jay: Updated after FieldBase changes.
10515 Added current_array_type to simplify array initializers.
10517 * ecore.cs (NullCast.IsDefaultValue): Implemented.
10519 * expression.cs, iterators.cs: Updated.
10521 * namespace.cs (NamespaceEntry): Made UsingFound private.
10523 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10525 * parameterCollection.cs: Obsolete, removed.
10526 * parser.cs: Obsolete, removed.
10528 2005-12-05 Marek Safar <marek.safar@seznam.cz>
10531 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
10533 * enum.cs (Enum.Define): Set obsolete context here.
10535 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
10538 - FindDocumentedMember() now expects 1) paramList as null
10539 when "we don't have to check the number of parameters" and
10540 2) Type.EmptyTypes when "there is no arguments".
10541 - Introduced FoundMember struct to hold the exact type which was
10542 used to find the documented member (the above change broke
10543 test-xml-044; it might be better just to use DeclaringType than
10544 what MS does, like this change does, but it depends on usage.)
10546 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
10548 * doc.cs : documented member might be from DeclaringType for nested
10549 types. Fixed bug #76782.
10551 2005-12-03 Ben Maurer <bmaurer@ximian.com>
10553 * anonymous.cs: Have the param code handle leaving copies on the
10554 stack etc. Allows anonymous params to take part in the assignment
10555 code (++, +=, etc). Fixes bug #76550
10557 * expression.cs: Handle the prepare_for_load/leave_copy by passing
10558 it down to the anon code.
10560 * iterators.cs: Use dummy var here
10562 * codegen.cs: Handle new vars
10564 2005-12-01 Marek Safar <marek.safar@seznam.cz>
10567 * class.cs (MethodData.Define): Set proper Obsolete context.
10569 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
10571 (FieldExpr.DoResolve): Ditto.
10573 2005-12-01 Marek Safar <marek.safar@seznam.cz>
10576 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
10577 parent is not obsolete.
10579 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
10581 * doc.cs : (FindDocumentedMember) find parameterless members first
10582 and get CS0419 in the early stage. Fixed first case of bug #76727.
10584 2005-11-30 Marek Safar <marek.safar@seznam.cz>
10587 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
10588 no error was reported.
10590 *expression.cs (Binary.DoResolve): left can be null.
10592 2005-11-22 Marek Safar <marek.safar@seznam.cz>
10595 * class.cs (MethodData.Emit): Parameters should be labeled first.
10597 2005-11-21 Marek Safar <marek.safar@seznam.cz>
10600 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
10602 2005-11-18 Marek Safar <marek.safar@seznam.cz>
10604 * attribute.cs (AreParametersCompliant): Moved to Parameter.
10606 * class.cs (MethodCore): Parameter clean up.
10607 (IMethodData): Added ParameterInfo.
10608 (MethodData): Parameter clean up.
10609 (Indexer.Define): Parameter clean up.
10621 * typemanager.cs: Parameter clean up.
10623 * delegate.cs (Define): Get rid of duplicated code.
10625 * expression.cs (ParameterReference): Removed useless parameters
10627 (Invocation): Ditto.
10629 * parameter.cs (ParamsParameter): New class, params specialization.
10630 (ArglistParameter): Attemp to separate arglist.
10631 (Parameter): Refactored to be reusable and faster.
10632 (Parameter.Modifier): Made understandable.
10633 (Parameters): Changed to be used as a class for `this' assembly
10634 parameters. Refactored to use new specialized classes.
10636 * support.cs (ParameterData): Added Types property.
10637 (InternalParameters): Deleted.
10639 2005-08-20 Martin Baulig <martin@ximian.com>
10641 Merging this patch from GMCS to fix #75867.
10643 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
10644 scope if we don't already have it.
10646 2005-11-17 Martin Baulig <martin@ximian.com>
10649 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
10650 inherit the scope from our parent. Fixes #76653.
10652 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
10654 * doc.cs : the previous patch does not actually fix the bug.
10655 PropertyInfo override check is now implemented and really fixed it.
10656 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
10658 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
10660 * doc.cs : apply "override filter" also to properties.
10663 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
10665 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
10666 no need to check overrides. For classes, omit those results from
10667 interfaces since they must exist in the class. Fixed bug #76726.
10669 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
10671 * typemanager.cs : (GetFullNameSignature) differentiate indexers
10672 with different parameters. Fixed the second problem in #76685.
10674 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
10676 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
10677 get expected 'protected' access in CheckValidFamilyAccess()).
10680 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
10682 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
10683 Fixed bug #76705. CS1569 was incorrectly commented out.
10685 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
10687 * doc.cs : use Invocation.IsOverride() to do real override check.
10688 * expression.cs : made Invocation.IsOverride() internal.
10690 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
10692 * doc.cs : use TypeManager.FindMembers() instead of (possible)
10693 TypeBuilder.FindMembers() and filter overriden base members out.
10696 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10698 * doc.cs : ref/out parameters are represented as '@' (instead of
10699 '&' in type FullName). Fixed bug #76630 (additionally crefs).
10701 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10703 * doc.cs : when there was no '.' in cref to methods in doc comment,
10704 then parameters were missing in the output. Fixed bug #76691.
10706 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10708 * driver.cs : don't output docs when there is an error.
10711 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10714 Now it should detect indexers. Fixed primary concern in bug #76685.
10715 Fixed CS0419 message to not show the identical member signature in
10718 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
10720 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
10721 instead of Type.FindMembers() since it does not handle events.
10724 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
10726 * codegen.cs: Fixed typo (speficied -> specified).
10728 2005-11-11 Marek Safar <marek.safar@seznam.cz>
10731 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
10733 2005-11-11 Marek Safar <marek.safar@seznam.cz>
10735 * attribute.cs: Changed error message.
10737 * cs-tokenizer.cs: One more check.
10739 2005-11-10 Marek Safar <marek.safar@seznam.cz>
10741 * statement.cs (Block.Resolve): Ignore empty statement.
10743 2005-11-10 Marek Safar <marek.safar@seznam.cz>
10745 * report.cs: Made error/warning methods more strict to avoid
10748 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
10749 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
10750 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
10751 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
10753 2005-11-08 Marek Safar <marek.safar@seznam.cz>
10755 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
10756 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
10758 * class.cs (TypeContainer.IsComImport): New property.
10759 (Constructor.Define): Create proper ctor for ComImport types.
10761 * expression.cs (New.CheckComImport): Fixed.
10763 2005-11-07 Miguel de Icaza <miguel@novell.com>
10765 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
10766 that a parameter has been captured does not mean that we do not
10767 have to do the rest of the processing. This fixes the second part
10768 of #76592. If there was another anonymous method capturing
10769 values in the past, the Scope would never be set for the second
10770 method that captured the same parameter.
10772 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
10773 properly manipulate the stack. Second part of fix for #76592.
10775 * expression.cs (New): Add support for invoking "new" on
10776 interfaces that have been flagged with the ComImport attribute and
10777 the CoClass. Fixes #76637
10779 * statement.cs (Try.DoEmit): When a variable is captured, do not
10780 try to emit the vi.LocalBuilder variable as it has been captured.
10781 Create a temporary variable and store the results on the
10782 FieldBuilder. Fixes #76642
10784 2005-11-07 Marek Safar <marek.safar@seznam.cz>
10786 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
10788 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
10790 * expression.cs (Binary.DoResolve): Added && optimalization.
10792 * typemanager.cs (AddUserType): Removed useless argument.
10794 2005-11-04 Marek Safar <marek.safar@seznam.cz>
10796 * statement.cs (Block.variables): Uses ListDictionary.
10798 2005-11-03 Marek Safar <marek.safar@seznam.cz>
10801 * class.cs (PartialContainer.EmitType): Customized to emit
10802 security attributes.
10803 (ClassPart.ApplyAttributeBuilder): Transform security attribute
10804 for partial classes.
10806 2005-11-03 Marek Safar <marek.safar@seznam.cz>
10809 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
10810 access has to be fixed.
10812 * typemanager.cs (IsUnmanagedType): Wrong common field type.
10814 2005-11-01 Marek Safar <marek.safar@seznam.cz>
10817 * ecore.cs (NullCast.Reduce): Implemented.
10819 * expression.cs (ArrayCreation.CheckIndices): Correcly check
10822 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
10824 (Foreach.Resolve): Catch null properly.
10826 2005-10-29 Marek Safar <marek.safar@seznam.cz>
10828 * cs-tokenizer.cs: Warning text fix.
10830 * driver.cs: AllWarningNumbers exposed on public interface.
10832 * report.cs (): Reviewed warning numbers.
10833 (IsValidWarning): Use binary search.
10835 2005-10-29 Marek Safar <marek.safar@seznam.cz>
10837 * driver.cs: Implemeted resource visibility.
10838 (Resources): New class for code sharing between /res: and
10841 2005-10-28 Marek Safar <marek.safar@seznam.cz>
10844 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
10847 * convert (Convert.ImplicitReferenceConversion): NullCast holds
10850 * ecore.cs (NullCast): Child is contant only.
10852 * literal.cs (NullLiteral.Reduce): null can be converted to any
10855 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
10857 * driver.cs: Use Encoding.Default as default code page instead
10860 2005-10-27 Raja R Harinath <rharinath@novell.com>
10863 * expression.cs (Invocation.Error_InvalidArguments): Handle
10864 __arglist parameters.
10865 (Invocation.VerifyArgumentsCompat): Likewise.
10866 * support.cs (ReflectionParameters.GetSignatureForError): Print
10867 __arglist parameters.
10868 (InternalParamters.GetSignatureForError): Likewise.
10869 * parameter.cs (Parameters.GetSignatureForError): Likewise.
10871 2005-10-26 Marek Safar <marek.safar@seznam.cz>
10873 * attribute.cs (GetPropertyValue): Made public.
10875 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
10877 Add new property WrapNonExceptionThrows to handle 2.0 assembly
10879 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
10882 * driver.cs: Reflect method name change.
10884 * statement.cs (Try.Resolve): Warn when try has both general
10885 exception handlers.
10887 * typemanager.cs: runtime_compatibility_attr_type new predefined
10890 2005-10-26 Raja R Harinath <harinath@gmail.com>
10893 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
10894 treat it as an empty parameter list.
10896 2005-10-26 Raja R Harinath <rharinath@novell.com>
10899 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
10900 ResolveAsTypeStep silent.
10901 * statement.cs (Block.AddConstant): Mark block as used.
10902 (Block.ResolveMeta): Avoid piling on error messages
10903 if a constant initializer resolution fails.
10905 2005-10-25 Raja R Harinath <rharinath@novell.com>
10907 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
10909 (NamespaceEntry.VerifyAllUsing): New.
10910 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
10911 behaviour. Delegates actual resolution of alias to ...
10912 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
10913 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
10915 * driver.cs (Driver.MainDriver): Update.
10917 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
10918 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
10920 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
10922 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
10923 RootNamespace.DefineNamespacesForAll.
10925 2005-10-24 Raja R Harinath <harinath@gmail.com>
10927 * typemanager.cs (assemblies, external_aliases, modules)
10928 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
10929 (ComputeNamespaces, GetRootNamespace): Remove extra staging
10930 overhead. Move resposibility ...
10931 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
10932 * driver.cs, attribute.cs, codegen.cs: Update to changes.
10934 2005-10-23 Raja R Harinath <harinath@gmail.com>
10936 * namespace.cs (RootNamespace.all_namespaces): Renamed from
10937 cached_namespaces. Improve usage.
10938 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
10939 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
10940 Move from GlobalRootNamespace and simplify.
10941 (RootNamespace.Global): Make instance variable.
10942 (RootNamespace.RootNamespace): Add "alias name" parameter.
10943 (GlobalRootNamespace): Simplify drastically.
10944 (Namespace.Lookup): Don't use GetNamespace.
10945 * typemanager.cs (GetRootNamespace): Rename from
10946 ComputeNamespaceForAlias.
10947 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
10949 2005-10-23 Marek Safar <marek.safar@seznam.cz>
10951 * anonymous.cs (AnonymousContainer): Don't crash when container
10954 2005-10-23 Marek Safar <marek.safar@seznam.cz>
10956 * expression.cs (Binary.DoResolve): Warn when comparing same
10959 2005-10-23 Marek Safar <marek.safar@seznam.cz>
10962 * expression.cs (Binary.DoResolve): It looks like there are no
10963 convetsion rules in enum context.
10965 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10967 Add support for extern alias qualifiers.
10968 * typemanager.cs: Move some LookupTypeReflection code
10969 to namespace.cs, to have cleaner code. Added some methods
10970 to help us keep track of the extern aliased references.
10971 * driver.cs: Add suport for extern alias assemblies on command
10972 line and check for their warnings/errors. Also keep track of the
10973 extern aliased assemblies.
10974 * namespace.cs: Move the global functionality of Namespace
10975 to GlobalRootNamespace/RootNamespace. Now the global namespace
10976 is GlobalRootNamespace.Globa. Also the code moved from
10977 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
10978 Finally added LocalAliasEntry (AliasEntry before) and
10979 ExternAliasEntry, to handle alias statements.
10980 * cs-parser.jay: Add support in the grammar for extern alias
10982 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
10983 Update callings to Namespace (now in GlobalRootNamespace).
10985 2005-10-18 Raja R Harinath <rharinath@novell.com>
10988 * class.cs (TypeContainer.DefineType): Move updating of
10989 topological sort earlier in the code.
10990 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
10992 2005-10-18 Marek Safar <marek.safar@seznam.cz>
10995 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
10997 * constant.cs (Constant.TryReduce): Moved from Cast class.
10998 (Reduce): Made little bit more OO and fixed missing conversions.
11000 * ecore.cs (Reduce): Implemented.
11001 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11003 * literal.cs (Reduce): Implemented.
11005 * class.cs: Reverted Miguel's wrong commit.
11007 2005-10-14 Miguel de Icaza <miguel@novell.com>
11009 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11011 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11013 * cs-parser.jay, expression.cs : CS0214 was missing error location
11014 for constants. Fixed bug #76404.
11016 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11019 * convert.cs (ExplicitConversionCore): Fixed object->enum
11022 2005-10-10 Raja R Harinath <rharinath@novell.com>
11024 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11025 InstanceExpression.
11026 (PropertyExpr.EmitCall): Likewise.
11027 * expression.cs (Invocation.EmitArguments): Handle case where
11029 (Invocation.EmitCall): Avoid allocating temporary variable if
11030 there are no arguments.
11032 2005-10-07 Raja R Harinath <rharinath@novell.com>
11035 * convert.cs (ImplicitConversionStandard): Move conversion of
11036 void* to arbitrary pointer types ...
11037 (ExplicitConversionStandard): .. here.
11038 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11039 error to always print typenames.
11041 2005-10-07 Raja R Harinath <rharinath@novell.com>
11043 * convert.cs (GetConversionOperator): Rename from
11044 GetConversionOperators. Move operator selection code from ...
11045 (UserDefinedConversion): ... here.
11047 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11049 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11052 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11054 * assign.cs (Assign.DoResolve): Error method changed.
11056 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11058 * const.cs (ResolveValue): Reset in_transit immediately.
11060 * constant.cs: Error method changed.
11062 * convert.cs: Removed useless location parameter.
11063 (ExplicitNumericConversion): Don't do double enum check.
11064 (ExplicitConversionCore): Renamed from ExplicitConversion.
11065 (ExplicitUnsafe): Extracted from ExplicitConversion.
11066 (ExplicitConversion): Uses for error reporting.
11068 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11070 (ResolveBoolean): Uses common error method.
11071 (CastToDecimal): Get rid of ec.
11072 (CastFromDecimal): Optimized.
11073 (ConvCast): Get rid of ec.
11075 * enum.cs (ResolveValue): Reset in_transit immediately.
11076 (Emit): Return after first error.
11078 * expression.cs: Convert changes.
11080 * literal.cs: Error method changed.
11082 * statement.cs: Error method changed.
11084 2005-10-03 Raja R Harinath <rharinath@novell.com>
11086 * support.cs (SeekableStreamReader.Position): Don't error out when
11087 the requested position is just beyond the end of the current
11090 2005-09-28 Raja R Harinath <rharinath@novell.com>
11092 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11093 try to keep in sync with the byte count of the underlying Stream.
11094 However, this limits us to a window size of 2048 characters: i.e.,
11095 the maximum lookahead of our lexer/parser can be 2048 characters.
11097 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11100 * driver.cs: Fix compilation files with full root path.
11102 2005-09-25 Miguel de Icaza <miguel@novell.com>
11104 * report.cs (SymbolRelatedToPreviousError): Format the output so
11105 it does not use an open parenthesis that is never closed.
11107 * driver.cs: Follow coding guidelines
11109 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11112 * const.cs (Const.ResolveValue): Check for assigning non-null
11113 value to reference type.
11115 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11117 * anonymous.cs: Implemented ExprClassName.
11119 * assign.cs (Assign.DoResolve): Don't chrash when type is not
11122 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
11125 * class.cs (StaticClass.DefineContainerMembers): Report protected
11128 * codegen.cs: if(ed) PRODUCTION.
11130 * convert.cs (Error_CannotImplicitConversion): Better error
11133 * cs-parser.jay: More error checks.
11135 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
11137 * driver.cs (CSCParseOption): Enabled wrong option check.
11139 * ecore.cs (Expression.ExprClassName): Turned to property.
11140 (MemberExpr.CheckIntermediateModification): For checking boxed
11141 value types modification.
11143 * statement.cs (Fixed.Resolve): Expression type must be
11144 convertible to fixed type.
11145 (CollectionForeach.GetEnumeratorFilter,TryType):
11146 Small refactoring for easier error checking.
11148 2005-09-26 Marek Safar <marek.safar@seznam.cz>
11150 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
11153 * class.cs (GeneratedBaseInitializer): New class for customization
11154 compiler generated initializers.
11155 (MemberBase.DoDefine): Check Obsolete attribute here.
11156 (FieldMember.DoDefine): Ditto.
11158 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
11161 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
11162 (MemberCore.GetObsoleteAttribute): Removed argument.
11163 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
11164 (MemberCore.CheckObsoleteType): New helper.
11168 * statement.cs: Updates after MemberCore changes.
11170 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
11171 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
11173 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
11174 obsolete attribute for compiler construct.
11175 (As.DoResolve): Cache result.
11177 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
11179 2005-09-26 Raja R Harinath <rharinath@novell.com>
11182 * expression.cs (This.VerifyFixed): In a value type T, the type of
11183 'this' is T&, iow, 'this' is either an out or ref parameter. In a
11184 value type R, 'this' is treated as a value parameter.
11186 2005-09-22 Miguel de Icaza <miguel@novell.com>
11188 * statement.cs (Lock): Use the TemporaryVariable class instead of
11189 manually using local variables as those do not work when variables
11192 * ecore.cs: Moved the TemporaryVariable class from being a nested
11193 class inside Foreach to be a public class that can be employed in
11196 2005-09-19 Marek Safar <marek.safar@seznam.cz>
11198 * cs-parser.jay: interface_accessors replaced by
11199 accessor_declarations.
11201 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
11204 * statement.cs (GotoCase.Resolve): Convert null constant to
11206 (SwitchLabel.ResolveAndReduce): Ditto.
11207 (SwitchLabel.NullStringCase): Custom null stamp.
11208 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
11210 typemanager.cs (CSharpSignature): Don't skip first argument
11213 2005-09-18 Miguel de Icaza <miguel@novell.com>
11215 * driver.cs: Set InEmacs based on the environment variable EMACS.
11217 * location.cs (InEmacs): in this mode, do not report column
11218 location as it confuses Emacs.
11220 2005-09-16 Marek Safar <marek.safar@seznam.cz>
11222 * cfold.cs, constant.cs, convert.cs, ecore.cs,
11223 expression.cs, iterators.cs, literal.cs: Store constants and
11226 * class.cs (MemberBase.ShortName): Pass location.
11228 * cs-parser.jay: Some location fixes.
11230 * ecore.cs (Expression.Location): Made virtual.
11232 2005-09-05 Miguel de Icaza <miguel@novell.com>
11234 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
11235 if the underlying types are the same, otherwise we need to produce
11236 code that will do the proper cast.
11238 This was exposed by Marek's constant rewrite which produced
11239 invalid code for the call site:
11241 enum X : long { a }
11242 void Method (X v) {}
11246 This fixes test-49.cs
11248 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11250 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
11251 Type/Object should be allowed as well. Fixed bug #75968.
11253 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11255 * expression.cs : (Binary.DoResolve): when one is enum constant and
11256 another is constant 0, then return enum one *as enum type*.
11259 2005-09-02 Raja R Harinath <rharinath@novell.com>
11261 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
11265 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
11266 flow-branching for LocalVariableReferences in case we were invoked
11267 from a MemberAccess.
11268 * expression.cs (LocalVariableReference.VerifyAssigned): New.
11270 (LocalVariableReference.DoResolveBase): ... this.
11271 (MemberAccess.Resolve): Do the check that was disabled during
11274 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11277 (PartialContainer.Create): check abstract/sealed/static strictly
11278 but abstract/sealed can exist only at one side. Fixed bug #75883.
11280 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
11283 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
11284 specified, don't default to UnmanagedType.I4.
11286 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11288 * expression.cs : conditional operator should check possibly
11289 incorrect assign expression. Fixed bug #75946.
11291 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11293 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
11294 Reverting the change. gmcs is much complex than mcs on this matter.
11296 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11298 * cs-tokenizer.cs : To read another token ahead of the actual
11299 consumption, use new SavedToken and cache token instead of moving
11300 back the stream with SeekableStreamReader (it seemed problematic).
11302 driver.cs : Thus use StreamReader directly.
11303 * support.cs : Thus removed SeekableStreamReader.
11305 2005-08-30 Raja R Harinath <rharinath@novell.com>
11308 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
11309 (ScopeInfo.EmitScopeType): Use it to construct field names from
11310 names of captured locals.
11313 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
11314 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
11315 Pass 'target_type' to BoxedCast. Don't default to 'object'.
11316 (ExplicitConversion): Remove enum cases already handled by
11317 implicit conversion. Move implicit conversion check to the beginning.
11318 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
11319 * expression.cs (ArrayCreation.EmitDynamicInitializers):
11320 Don't treat System.Enum as a struct.
11322 2005-08-30 Jb Evain <jbevain@gmail.com>
11324 * attribute.cs: handles as expression in parameters.
11326 2005-08-30 Raja R Harinath <rharinath@novell.com>
11329 * class.cs (TypeContainer.VerifyClsName): Don't use a
11330 PartialContainer when verifying CLS compliance.
11331 (AbstractPropertyEventMethod): Set Parent here, ...
11332 (PropertyMethod): ... not here.
11334 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
11336 * attribute.cs : escaped attribute name should not be allowed to be
11337 resolved (e.g. @class as classAttribute). Fixed bug #75930.
11339 2005-08-29 Raja R Harinath <rharinath@novell.com>
11342 * convert.cs (ImplicitStandardConversionExists): Allow zero also
11343 when converting a long constant to unsigned long.
11344 * expression.cs (Invocation.OverloadResolve): Add sanity check to
11345 detect where IsApplicable and VerifyArgumentsCompat disagree.
11347 2005-08-29 Raja R Harinath <rharinath@novell.com>
11348 and Carlos Alberto Cortez <carlos@unixmexico.org>
11351 * class.cs (TypeContainer.CanElideInitializer): New helper.
11352 (TypeContainer.EmitFieldInitializers): Use it to determine if we
11353 can safely emitting the initializer of a field.
11355 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11357 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
11358 allowed inside a switch (without loop). Fixed bug #75433.
11360 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
11362 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
11363 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
11365 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11367 * driver.cs : kinda reverting the default encoding changes (not exact
11368 revert since I noticed that "codepage:reset" might not work fine).
11370 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11372 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
11373 Location. Now getter and setter store location correctly.
11374 (errors/cs0111-12.cs now reports the expected location.)
11376 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11378 * driver.cs : Use default encoding on the environment.
11379 Removed (now that) extra parameter for SeekableStreamReader.
11380 * support.cs : (SeekableStreamReader) third .ctor() argument for
11381 StreamReader is not required (always true). preamble size could
11382 be acquired in simpler and safe way.
11384 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
11386 * cs-parser.jay: report CS0642 at warning level 3
11387 and report CS0642 for an if else statement also
11388 fixes bug #74745. Patch by John Luke (and a bit
11390 Removed extra CS0642 warning check for "while",
11392 * statement.cs: In Block.Resolve(), CS0642 check
11393 is reimplemented to check a sequence of an empty
11394 statement and a block.
11396 Both fix bug #66777.
11398 2005-08-24 Marek Safar <marek.safar@seznam.cz>
11400 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
11401 detection until I fix it.
11403 * cs-tokenizer.cs: Changed error message.
11405 * cs-parser.jay: Fixed 2 error locations.
11407 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
11408 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
11411 * enum.cs (GetSignatureForError): Fixed.
11413 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
11417 * typemanager.cs (RegisterProperty): Removed.
11419 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
11421 2005-08-24 Raja R Harinath <rharinath@novell.com>
11424 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
11425 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
11427 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11429 * expression.cs : tiny fix is required for not warning positive ulong.
11432 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11434 * expression.cs : add CS0652 check for constant and integral
11435 expression. Fixed bug #53974.
11437 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11439 * expression.cs : in DoNumericPromotions(), check if there is implicit
11440 conversion overload for string (to check CS0034). Fixed bug #52492.
11442 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11444 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
11446 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11448 * ecore.cs : report location when it is *not* Null.
11450 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11456 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
11457 correctly. Fixed bug #75721.
11459 2005-08-23 Raja R Harinath <rharinath@novell.com>
11461 * support.cs (SeekableStreamReader.Position): Avoid an expensive
11462 loop that performs 'min (pos, char_count)'.
11465 * expression.cs (Unary.ResolveOperator): Don't discard implicit
11466 converted value in Operator.OnesComplement.
11468 2005-08-22 Ben Maurer <bmaurer@ximian.com>
11470 * anonymous.cs: If the anon method is pulled into a helper class,
11471 it needs to be `internal' not `private'. Fixes runtime behavior on
11474 2005-08-20 Martin Baulig <martin@ximian.com>
11476 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11477 scope if we don't already have it.
11479 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
11480 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
11483 2005-08-17 Marek Safar <marek.safar@seznam.cz>
11486 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
11487 is a partial class.
11489 2005-08-16 Marek Safar <marek.safar@seznam.cz>
11491 The big constants rewrite
11492 Fix #75746, #75685 and more
11493 As a side effect saved 1MB for MWF ;-)
11495 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
11496 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
11497 enum based for corlib compilation.
11499 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
11502 * class.cs (FixedField.Define): Use ResolveAsConstant.
11504 * const.cs (IConstant): Interface constants and enums.
11505 (Const.ResolveValue): New method for constant resolvning.
11506 (ExternalConstant): Constants from imported assemblies.
11508 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
11509 conversion; like enums.
11510 (Constant.ToType): Converts this constant to different type.
11511 (Constant.Increment): Adds 1.
11513 * convert.cs (ImplicitConversionRequired): Simplified.
11515 * cs-parser.jay: Create EnumMember directly.
11517 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
11519 * doc.cs (GenerateEnumDocComment): Removed.
11521 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
11522 (ConvertIntLiteral): Removed.
11523 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
11525 * enum.cs (EnumMember): Implement IConstant.
11526 (Enum.IsValidEnumConstant): Removed.
11527 (Enum.GetNextDefaultValue): Removed.
11528 (Enum.FindMembers): Updated.
11529 (Enum.GenerateDocComment): Iterate enum members.
11531 * expression.cs (Cast.TryReduce): Handle enums correctly.
11532 (New.Constantify): Made public.
11533 (MemberAccess.DoResolve): Removed contant specific if(s).
11535 * literal.cs (NullLiteral): Implement new abstract methods.
11537 * statement.cs (GotoCase.Resolve): Use new constant methods.
11538 (SwitchLabel.ResolveAndReduce): Use new constant methods.
11540 * typemanager.cs (LookupEnum): Removed.
11541 (IsEnumType): Fixed to work with corlib.
11542 (RegisterConstant): Removed.
11543 (LookupConstant): Removed.
11544 (GetConstant): Changed to work with IConstant.
11546 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
11548 * location.cs : Fixed overflown (>255) column number.
11550 2005-08-03 Raja R Harinath <rharinath@novell.com>
11552 First cut of the qualified-alias-member feature.
11553 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
11555 * cs-parser.jay (DOUBLE_COLON): New token.
11556 (namespace_or_type_name): Add rule for recognizing
11557 qualified-alias-members.
11558 (primary_expression): Likewise.
11559 (element_access): Allow QualifiedAliasMember as a possible
11560 type-bearing expression.
11561 (local_variable_type, local_variable_pointer_type): Likewise.
11562 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
11563 aliases in the current and enclosing namespace declarations.
11564 (NamespaceEntry.UsingAlias): Add CS0440 warning.
11565 * decl.cs (MemberName.is_double_colon): New.
11566 (MemberName.MemberName): Add new constructor for alias-member.
11567 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
11568 * expression.cs (QualifiedAliasMember): New expression type.
11570 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11572 * location.cs : it borked when no argument was specified.
11574 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11576 * location.cs : tiny ToString() format fix.
11578 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11580 * statement.cs : oops, it was missing.
11582 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
11584 A set of fixes for precise line/column location.
11587 "token" field now holds a file/line "delta", a line number offset
11588 from the segment, and a column number. See also:
11589 http://lists.ximian.com/pipermail/mono-devel-list/2004-
11590 December/009508.html
11591 Removed static IsNull. Use instance IsNull property instead.
11592 * cs-tokenizer.cs :
11593 For some tokens it stores Location. For Identifier it stores
11594 LocatedToken which is a pair of string name and location.
11595 Column numbers are adjusted only at getChar().
11597 Use Location.ToString() for reporting (it now contains column).
11599 Largely modified to use LocatedToken instead of
11600 string (IDENTIFIER), and to acquire Location from some tokens.
11601 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
11602 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
11604 Now MemberName holds Location. DeclSpace.ctor() receives Location
11605 as a parameter. Removed extra parameters to all derived classes.
11606 Replaced Location.IsNull() with instance property.
11607 * assign.cs, expression.cs :
11608 Added .ctor() overload that omits Location.
11610 Added "nameEscaped" flag that indicates the identifier was escaped
11611 in the source file. This fixes bug #57047.
11613 2005-08-02 Marek Safar <marek.safar@seznam.cz>
11615 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
11616 New method, looking for lo-case imported cls type.
11618 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
11621 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
11623 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
11625 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
11626 all_imported_types.
11627 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
11629 Optimized to save 3.5 MB for SWF compilation.
11631 2005-08-01 Marek Safar <marek.safar@seznam.cz>
11633 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
11634 (PartialContainer.Create): Moved logic AddToContainer.
11635 (PartialContainer.MarkForDuplicationCheck): Shares name.
11637 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
11640 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
11642 (Namespace.GetSignatureForError): New method.
11644 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
11645 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
11647 2005-08-01 Raja R Harinath <rharinath@novell.com>
11650 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
11651 member lookup rather than qualifier_type, since qualifier_type can
11654 2005-08-01 Marek Safar <marek.safar@seznam.cz>
11656 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
11659 2005-07-31 Miguel de Icaza <miguel@novell.com>
11661 * statement.cs: Copy the local exception into the exception
11662 captured local. Fixes 75674
11664 2005-07-31 Raja R Harinath <harinath@gmail.com>
11667 * expression.cs (Invocation.OverloadResolve): Don't report error
11668 CS1501 if error CS1502 has been reported.
11669 (New.DoResolve): Delegate CS1501 reporting to
11670 Invocation.OverloadResolve.
11673 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
11674 invariant-meaning-in-block property in an enclosing block if
11677 2005-07-29 Marek Safar <marek.safar@seznam.cz>
11679 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
11680 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
11681 (Switch.CheckSwitch): Just save 50kb for SWF.
11683 2005-07-27 Martin Baulig <martin@ximian.com>
11685 * anonymous.cs (CaptureContext.AddField): Added
11686 `AnonymousContainer am' argument; compute its toplevel scope if
11687 it's not already computed. Fixes #75649.
11689 2005-07-26 Raja R Harinath <rharinath@novell.com>
11692 * class.cs (Constructor.Emit): Reset block to null if the block
11695 2005-07-25 Marek Safar <marek.safar@seznam.cz>
11697 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
11699 2005-07-25 Marek Safar <marek.safar@seznam.cz>
11701 * class.cs (MethodData.Define): Check whether accessor implementing
11702 interface is public.
11704 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
11706 2005-07-22 Marek Safar <marek.safar@seznam.cz>
11709 * namespace.cs (LookupType): Moved same type check to...
11711 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
11712 with the same name.
11714 2005-07-21 Raja R Harinath <rharinath@novell.com>
11716 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
11717 already found a typebuilder.
11718 * class.cs (MethodCore.IsDuplicateImplementation): Compare
11719 MemberNames, not strings.
11721 * const.cs (Error_ExpressionMustBeConst):
11722 Rename from Error_EpressionMustBeConst.
11723 * const.cs, class.cs, statement.cd: Update.
11725 2005-07-21 Marek Safar <marek.safar@seznam.cz>
11729 * const.cs (Const.LookupConstantValue): Report missing contant expression
11731 (Error_EpressionMustBeConstant): Only one error method.
11733 * class.cs, statement.c: Updated.
11735 2005-07-20 Raja R Harinath <rharinath@novell.com>
11737 * statement.cs (Block.Flags): Add back HasVarargs.
11738 (Block.flags): Make protected.
11739 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
11741 * typemanager.cs (types, typecontainers, user_types): Remove.
11742 (UserTypes, TypeContainers): Likewise.
11743 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
11744 (CleanUp, Reset): Update.
11745 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
11746 (GetNestedType): Use Type.GetNestedType.
11747 (CoreLookupType): Take two arguments, the namespace and the
11748 basename of the type. Update to use the Namespace.Lookup
11750 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
11751 (RealMemberLookup): Use IsNestedChildOf instead of playing with
11752 string concatenation and substring matches.
11753 * class.cs, enum.cs, delegate.cs: Update to changes.
11755 2005-07-20 Marek Safar <marek.safar@seznam.cz>
11757 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
11758 Expression and made virtual.
11760 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
11761 (ImplicitStandardConversionExists): Fixed `byte' typo ?
11763 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
11765 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
11768 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
11771 2005-07-18 Marek Safar <marek.safar@seznam.cz>
11774 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
11775 AssemblyCultureAttribute is not used on executable.
11778 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
11780 2005-07-16 Raja R Harinath <rharinath@novell.com>
11783 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
11784 New. Reports CS0252/CS0253.
11785 Mostly taken from preliminary patch by Duncak Mak.
11786 (Binary.DoResolveOperator): Store results of operator lookup.
11787 Use them to detect if we need to warn about unintended reference
11790 2005-07-15 Raja R Harinath <rharinath@novell.com>
11793 * namespace.cs (Namespace.Lookup): Add back location parameter.
11794 (Namespace.LookupType): Add CS0436 report. Add location parameter.
11795 * delegate.cs, ecore.cs, expression.cs: Update to changes.
11797 * codegen.cs (EmitContext.DeclSpace): Make readonly.
11798 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
11799 (Namespace.LookupType): ... this.
11800 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
11802 * typemanager.cs (LookupTypeReflection): Remove buggy code that
11803 purported to handle pointers.
11804 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
11807 2005-07-15 Marek Safar <marek.safar@seznam.cz>
11809 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
11812 2005-07-15 Raja R Harinath <rharinath@novell.com>
11814 * namespace.cs (Namespace.Lookup): Drop location parameter.
11815 (NamespaceEntry.LookupAlias): Remove. Merge into ...
11816 (NamespaceEntry.Lookup): ... this.
11817 (NamespaceEntry.Error_AmbiguousTypeReference):
11818 Move here from DeclSpace.
11819 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
11821 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
11822 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
11823 Move to NamespaceEntry.
11824 * delegate.cs, expression.cs: Update to changes.
11826 2005-07-14 Marek Safar <marek.safar@seznam.cz>
11828 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
11829 CheckAttributeType and refactored.
11830 (Attribute.ResolvePossibleAttributeType): Changed to reuse
11831 ResolveAsTypeTerminal error handling.
11832 (ResolveAsTypeTerminal): Introduced because of global attributes extra
11834 (GetSignatureForError): Print errors in same way.
11837 * codegen.cs: Reflect attribute GetSignatureForError change.
11840 * expression.cs: Add silent parameter to ResolveAsTypeStep.
11842 * namespace.cs (UsingEntry): Refactored to make fields private.
11845 statement.cs: Error_UnexpectedKind has extra parameter.
11847 2005-07-14 Raja R Harinath <rharinath@novell.com>
11849 * ecore.cs (IAlias): Remove.
11850 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
11851 that implement the interface.
11852 * namespace.cs (Namespace): Likewise.
11853 (Namespace.declspaces): Renamed from 'defined_names'.
11854 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
11855 DeclSpace instead of an IAlias.
11856 * tree.cs (Tree.AddDecl): Update.
11858 2005-07-12 Raja R Harinath <rharinath@novell.com>
11860 * statement.cs (Block.Flags); Remove HasVarargs.
11861 (Block.HasVarargs): Move to ToplevelBlock.
11862 (Block.ThisVariable, Block.AddThisVariable): Likewise.
11863 (Block.Variables): Make protected. Initialize variable hashtable
11865 (Block.AddVariable): Update.
11866 (Block.Resolve): Update to changes.
11867 (ToplevelBlock.HasVarargs): New boolean.
11868 (ToplevelBlock.ThisVariable): Move here from Block.
11869 (ToplevelBlock.AddThisVariable): Likewise.
11870 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
11871 * expression.cs (This.ResolveBase): Update to changes.
11872 (ArglistAccess.DoResolve): Likewise.
11874 2005-07-11 Marek Safar <marek.safar@seznam.cz>
11877 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
11879 * class.cs (TypeContainer.VerifyMembers): Distinguish between
11880 not used and not used & assigned.
11881 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
11883 2005-07-11 Marek Safar <marek.safar@seznam.cz>
11886 * expression.cs (Is.DoResolve): null is never provided type.
11888 2005-07-08 Marek Safar <marek.safar@seznam.cz>
11891 * cs-parser.jay: Less strict event error rule to catch more errors.
11893 2005-07-08 Martin Baulig <martin@ximian.com>
11895 Fix test-iter-10.cs - distinguish whether we `yield' in a property
11896 gettter (allowed) or setter (not allowed).
11898 * class.cs (Accessor): Implement IIteratorContainer.
11899 (Accessor.Yields): New public field.
11900 (PropertyBase.PropertyMethod.Define): Handle iterators on a
11901 per-accessor basis.
11904 (get_accessor_declaration, set_accessor_declaration): Set the
11905 `yields' flag on the accessor, not the property.
11906 (property_declaration): Do the iterators check on a per-accessor
11907 basis and not for the whole property.
11909 2005-07-08 Martin Baulig <martin@ximian.com>
11911 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
11912 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
11914 2005-07-07 Marek Safar <marek.safar@seznam.cz>
11917 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
11918 (ExtractSecurityPermissionSet): Cope with self referencing security
11919 attributes properly.
11921 * driver.cs (SetOutputFile): Made public property OutputFile.
11923 2005-07-07 Raja R Harinath <rharinath@novell.com>
11926 * class.cs (TypeContainer.first_nonstatic_field): Rename from
11927 has_nonstatic_fields. Make into a FieldBase pointer.
11928 (TypeContainer.AddField): Add CS0282 check.
11929 (TypeContainer.EmitType): Update.
11931 2005-07-06 Miguel de Icaza <miguel@novell.com>
11933 * cs-tokenizer.cs (consume_identifier): Do not create strings to
11934 compare if they start with __.
11936 2005-07-06 Raja R Harinath <rharinath@novell.com>
11938 * statement.cs (Switch.SwitchGoverningType): Only look at
11939 UserCasts that don't need implicit standard conversions to one of
11940 the allowed switch types (Fixes test-322.cs).
11941 (LocalInfo.Resolve): Re-enable sanity-test.
11943 2005-07-06 Marek Safar <marek.safar@seznam.cz>
11945 * cs-tokenizer.cs (consume_identifier): Detect double undescores
11947 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
11949 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
11951 2005-07-06 Raja R Harinath <rharinath@novell.com>
11954 * ecore.cs (SimpleName.GetSignatureForError): Add.
11955 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
11956 (MemberAccess.GetSignatureForError): Add.
11958 2005-07-05 Marek Safar <marek.safar@seznam.cz>
11960 The big error and warning messages review.
11990 * typemanager.cs: Updated.
11992 * class.cs: (MethodCore.SetYields): Moved here to share.
11993 (PropertyMethod.Define): Moved iterator setup here.
11995 * iterators.cs: Add orig_method to have full access to parent
11998 2005-07-05 Raja R Harinath <rharinath@novell.com>
12000 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12001 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12002 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12003 variable of struct type.
12004 * expression.cs (Unary.ResolveOperator): Update to change.
12005 (Indirection.VerifyFixed): Likewise.
12006 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12007 (ParameterReference.VerifyFixed): Value parameters are fixed.
12008 (This.VerifyFixed): Treat 'this' as a value parameter.
12009 * statement.cs (LocalInfo.IsFixed): Remove.
12011 2005-07-01 Martin Baulig <martin@ximian.com>
12013 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12014 `ec.EmitThis ()' to get the correct scope.
12016 2005-07-01 Martin Baulig <martin@ximian.com>
12018 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12019 instance is a ParameterReference; fixes #75299.
12021 2005-07-01 Martin Baulig <martin@ximian.com>
12023 Reverted Marek's latest patch (r46725):
12024 - it contains structural changes which are neither mentioned in
12025 the ChangeLog nor explained anywhere; for example the additional
12026 argument of EmitContext's and Iterator's .ctor's and the
12027 TypeContainer.DefineMembers() change.
12028 - structural changes like this should go in in seperate patches
12029 and not be hidden in a huge patch which just seems to affect
12030 warnings and errors.
12031 a big and hard to understand patch.
12032 - it breaks iterators and causes regressions, for instance in
12035 2005-06-30 Raja R Harinath <rharinath@novell.com>
12038 * expression.cs (Indexers.map): Remove.
12039 (Indexers.Append): Filter out inaccessible setters and getters.
12040 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12043 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12044 Refactored from ...
12045 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12046 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12047 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12048 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12050 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12053 * class.cs (FieldBase.GetInitializerExpression): One more field
12056 2005-06-28 Miguel de Icaza <miguel@novell.com>
12058 * pending.cs: Do not define a proxy if the base method is virtual,
12059 it will be picked up by the runtime (bug 75270).
12061 2005-06-08 Martin Baulig <martin@ximian.com>
12063 The big Iterators rewrite :-)
12065 * iterators.cs: Rewrite this to use the anonymous methods framework.
12067 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12068 before the TypeContainers; see 2test-21.cs.
12071 (TypeContainer.DefineType): Don't create a new EmitContext if we
12072 already have one (this only happens if we're an Iterator).
12073 (TypeContainer.Define): Also call Define() on all our iterators.
12074 (Method.CreateEmitContext): Added support for iterators.
12077 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12078 (AnonymousContainer.CreateMethodHost): Moved here from
12079 AnonymousMethod and made abstract.
12080 (AnonymousContainer.CreateScopeType): New abstract method.
12081 (AnonymousContainer.IsIterator): New public property.
12082 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12083 get the ScopeTypeBuilder rather than manually defining it here.
12084 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12087 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12088 before RootContext.DefineTypes().
12090 * codegen.cs (EmitContext.RemapToProxy): Removed.
12091 (EmitContext.CurrentAnonymousMethod): Changed type from
12092 AnonymousMethod -> AnonymousContainer.
12093 (EmitContext.ResolveTopBlock): Protect from being called twice.
12094 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12095 (EmitContext.EmitThis): Removed the iterators hacks; use the
12096 anonymous methods framework for that.
12099 (ToplevelBlock.Container): Make this a property, not a field.
12100 (ToplevelBlock.ReParent): New public method; move the
12101 ToplevelBlock into a new container.
12102 (Foreach.TemporaryVariable): Simplify.
12104 2005-06-05 Martin Baulig <martin@ximian.com>
12106 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12107 (Block.AddTemporaryVariable): New public method; creates a new
12108 `LocalInfo' for a temporary variable.
12109 (Block.EmitMeta): Create the LocalBuilders for all the temporary
12111 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
12112 non-iterator variables.
12114 2005-06-05 Martin Baulig <martin@ximian.com>
12116 * statement.cs (Foreach.TemporaryVariable): Create the
12117 LocalBuilder in the Emit phase and not in Resolve since in some
12118 situations, we don't have an ILGenerator during Resolve; see
12119 2test-19.cs for an example.
12121 2005-06-04 Martin Baulig <martin@ximian.com>
12123 **** Merged r45395 from GCS ****
12125 The big Foreach rewrite - Part II.
12127 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
12128 with `PropertyInfo ienumerator_getcurrent'.
12130 * codegen.cs (VariableStorage): Removed.
12133 (Foreach): Derive from Statement, not ExceptionStatement.
12134 (Foreach.CollectionForeach): New nested class. Moved all the code
12135 dealing with collection foreach here.
12136 (Foreach.ForeachHelperMethods): Removed.
12137 (Foreach.TemporaryVariable): Implement IMemoryLocation.
12139 2005-05-23 Martin Baulig <martin@ximian.com>
12141 * statement.cs (Try.DoResolve): Don't create a `finally' if we
12142 don't need to. Fix #75014.
12144 2005-05-20 Martin Baulig <martin@ximian.com>
12146 Merged r44808 from GMCS.
12148 * class.cs (TypeContainer.CircularDepException): Removed.
12149 (TypeContainer.DefineType): Removed the `InTransit' stuff.
12150 (TypeContainer.CheckRecursiveDefinition): Check for circular class
12151 (CS0146) and interface (CS0529) dependencies here.
12153 2005-06-21 Raja R Harinath <rharinath@novell.com>
12155 * expression.cs (Invocation.EmitCall): Fix initialization
12156 'this_call' to reflect current behaviour. Fix indentation.
12158 * convert.cs (FindMostEncompassedType): Add two trivial special
12159 cases (number_of_types == 0 || number_of_types == 1).
12160 (FindMostEncompasingType): Likewise.
12162 2005-06-17 Raja R Harinath <rharinath@novell.com>
12164 Some cleanups preparing for the fix of #75283.
12165 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
12167 (EventExpr.InstanceResolve): Likewise.
12168 (EventExpr.DoResolve): Remove redundant checks.
12170 2005-06-10 Duncan Mak <duncan@novell.com>
12172 * cs-tokenizer.cs (process_directives): New flag for controlling
12173 the processing of preprocessor directives.
12174 (x_token): After seeing a '#', return Token.NONE instead of going
12175 to handle_preprocessing_directive() when not processing
12176 directives. This avoids unnecessary processing during the token peek in
12181 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
12182 the existing error reporting methods instead of Report.Error.
12184 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
12185 after Raja's rewrite.
12187 2005-06-08 Miguel de Icaza <miguel@novell.com>
12189 * class.cs: Small fix.
12191 2005-06-08 Raja R Harinath <rharinath@novell.com>
12194 * class.cs (GetPartialBases): Fix return value check of
12195 part.GetClassBases.
12197 2005-06-07 Raja R Harinath <rharinath@novell.com>
12199 Ensure that partial classes are registered in their enclosing
12200 namespace. Initial part of fix of #75160.
12201 * tree.cs (Tree.RecordDecl): Add new namespace argument.
12202 Register declspace with namespace here, not in
12203 DeclSpace.RecordDecl.
12204 * cs-parser.jay: Pass namespace to RecordDecl.
12205 * class.cs (PartialContainer.Create): Likewise.
12206 (ClassPart.DefineType): New sanity-check. Throws an exception if
12208 * decl.cs (Declspace.RecordDecl): Remove.
12209 * namespace.cs (NamespaceEntry.DefineName): Remove.
12211 2005-06-06 Marek Safar <marek.safar@seznam.cz>
12213 * rootcontext.cs: Reset TargetExt as well.
12215 2005-06-03 Raja R Harinath <rharinath@novell.com>
12217 * ecore.cs (Expression.Resolve): Emit CS0654 error when
12218 -langversion:ISO-1.
12220 2005-06-02 Raja R Harinath <rharinath@novell.com>
12222 Fix #75080, cs0119.cs.
12223 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
12225 (Expression.Resolve): ... this. Use it. Remove bogus code
12226 allowing ExprClass.Type and ExprClass.Namespace for
12227 ResolveFlags.VariableOrValue.
12228 (Expression.Resolve) [1-argument variant]: Change default resolve
12229 flags based on language version.
12230 (Expression.Error_UnexpectedKind): Use a simple string array
12231 rather than an ArrayList.
12232 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
12233 not ExprClass.Type.
12234 (TypeOfVoid.DoResolve): Likewise.
12235 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
12236 flags argument -- it always has the same value.
12238 2005-05-31 Raja R Harinath <rharinath@novell.com>
12241 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
12242 Use it in the error message.
12243 * assign.cs, expression.cs, statement.cs: Update.
12245 2005-05-30 Raja R Harinath <rharinath@novell.com>
12248 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
12249 the "almostMatchedMember" case too.
12250 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
12251 that failed the accessibility checks to 'almost_match'.
12253 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
12255 * attribute.cs: Use internal MethodBuilder methods to set
12256 ExactSpelling and SetLastError on PInvoke methods, instead
12257 of passing them via charset. Fixes #75060.
12259 2005-05-27 Raja R Harinath <rharinath@novell.com>
12261 * parameter.cs (Parameter): Remove TODO comment.
12262 (Parameter.DefineParameter): Remove Location parameter.
12263 (Parameters.LabelParameters): Likewise.
12264 * class.cs (Constructor.Emit): Update to change.
12265 (MethodData.Emit): Likewise.
12266 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
12267 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
12269 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
12272 Removed Parameters.Location and added Parameter.Location instead.
12273 Removed Location parameter from Emit() and GetSignature().
12280 Modified all related calls.
12282 2005-05-26 Raja R Harinath <rharinath@novell.com>
12284 Improve user-defined conversion handling.
12285 * convert.cs (GetConversionOperators): Rewrite. Return only the
12286 applicable operators.
12287 (AddConversionOperators): New. Helper for GetConversionOperators.
12288 (FindMostEncompassedType, FindMostEncompassingType): Verify that
12289 there is only one most encompassed/encompassing type.
12290 (FindMostSpecificSource, FindMostSpecificTarget): Remove
12291 "applicable operator" handling.
12292 (UserConversion): Move cache here from GetConversionOperators.
12293 Directly cache the chosen operator, rather than the whole
12295 (ExplicitNumericConversion): Fix buggy implementation of Decimal
12296 case. Allow conversion of decimal to sbyte and byte too.
12297 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
12298 New static methods. Used to avoid allocating EmptyExpressions in
12301 2005-05-24 Duncan Mak <duncan@novell.com>
12303 * ecore.cs (CastFromDecimal): New class for casting a decimal to
12304 another class, used in Convert.ExplicitNumericConversion.
12305 (CastToDecimal): New class, similar to above, but casts to
12306 System.Decimal, used in Convert.ImplicitNumericConversion and also
12307 in explicit convesion from double/float to decimal.
12309 * convert.cs (ImplicitNumericConversion): Handle implicit
12310 conversions to System.Decimal.
12311 (ExplicitNumericConversion): handle explicit conversions to
12316 2005-05-20 Miguel de Icaza <miguel@novell.com>
12318 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
12319 know the type at this stage, just break through. Fixes #75008
12321 2005-05-19 Martin Baulig <martin@ximian.com>
12324 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
12325 to disable error reporting.
12327 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
12328 here since we don't want to report an error; see the new test-336.cs.
12330 2005-05-19 Raja R Harinath <rharinath@novell.com>
12332 * statement.cs (ToplevelBlock.GetParameterReference)
12333 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
12334 Move here from class Block.
12335 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
12336 * expression.cs (ParameterReference.DoResolveBase): Likewise.
12338 2005-05-18 Martin Baulig <martin@ximian.com>
12343 (FlowBranching.Reachability): Add non-static public And() and Or()
12345 (FlowBranchingSwitch): New class; do the `break_origins' thing
12346 like in FlowBranchingLoop.
12347 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
12348 reachability, not just locals and parameters.
12349 (FlowBranching.MergeChild): Remove some of the hacks for loop and
12350 switch; MergeBreakOrigins() now takes care of that.
12352 2005-05-18 Martin Baulig <martin@ximian.com>
12354 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12355 a loop and may leave it, reset the barrier; fixes #74974.
12357 2005-05-17 Marek Safar <marek.safar@seznam.cz>
12359 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
12362 * cs-parser.jay: Catch more lexical errors.
12364 * report.cs: Add one more Error method.
12367 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
12369 2005-05-17 Martin Baulig <martin@ximian.com>
12371 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
12374 2005-05-16 Raja R Harinath <rharinath@novell.com>
12376 Fix test-382.cs. Emit values of decimal constants.
12377 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
12379 (TypeContainer.AddField): ... this.
12380 (TypeContainer.EmitFieldInitializers): Allow the list of fields
12381 with initializers to include 'Const's.
12382 (ClassPart.RegisterFieldForInitialization): Forward to
12384 * const.cs (Const.Const): Pass initializer to base class.
12385 (Const.Define): In case of decimal constants, register them for
12386 initialization in a static constructor.
12388 2005-05-14 Martin Baulig <martin@ximian.com>
12390 * statement.cs (Block.Resolve): Correctly handle unreachable code;
12391 do not call ResolveUnreachable() on unreachable statements in
12392 here, see the comment in the source code.
12394 2005-05-13 Raja R Harinath <rharinath@novell.com>
12397 * expression.cs (BinaryResolveOperator): If one of the operands of
12398 an equality comparison is 'null' and the other is a pointer type,
12399 convert the null to a NullPointer.
12400 * convert.cs (ImplicitReferenceConversion): If the expression is a
12401 NullLiteral and the target type is a pointer type, return a
12402 NullPointer instead.
12403 (ImplicitConversionStandard): Likewise.
12405 2005-05-13 Marek Safar <marek.safar@seznam.cz>
12407 * cs-parser.jay: Set readonly context based on special constructs.
12409 * expression.cs (LocalVariableReference.DoResolveBase): Improved
12410 readonly variable error handling.
12412 * rootcontext.cs (EmitCode): Don't verify members when error
12415 * statement.cs (LocalInfo): Add reaodnly context information.
12416 (SetReadOnlyContext, GetReadOnlyContext): New methods.
12418 2005-05-13 Raja R Harinath <rharinath@novell.com>
12420 * statement.cs (Block.Resolve): Revert change below. Modify fix
12421 for #74041 to initialize 'resolved' to false only for explicit
12422 blocks. Fixes #74873.
12424 2005-05-12 Raja R Harinath <harinath@gmail.com>
12427 * typemanager.cs (unmanaged_enclosing_types): New.
12428 (IsUnmanagedType): Avoid infloops by using
12429 'unmanaged_enclosing_types' to talk with recursive invocations.
12431 2005-05-13 Martin Baulig <martin@ximian.com>
12433 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
12434 instance variable, not a local. Fix #74873.
12435 (Block.ResolveUnreachable): Set it to true here.
12437 2005-05-11 Duncan Mak <duncan@novell.com>
12439 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
12440 continuing to process for 'arg'.
12441 (handle_preprocessing_directive): Check the argument of the #endif
12442 directive and report error CS1025 if there are any trailing
12445 According to the C# spec, having even whitespace after the #endif
12446 directive is illegal; however, because we call arg.TrimEnd ()
12447 beforehand, we have the same behavior as csc, allowing whitespace
12448 after the directive.
12452 2005-05-11 Marek Safar <marek.safar@seznam.cz>
12456 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
12457 (Constructor.GetObsoleteAttribute): Implemented correctly.
12459 2005-05-10 Martin Baulig <martin@ximian.com>
12461 * support.cs (ReflectionParameters.ParameterModifier): Use
12462 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
12463 and `ParameterAttributes.In'. Fixes #74884.
12465 2005-05-10 Marek Safar <marek.safar@seznam.cz>
12467 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
12469 * expression.cs (Argument.GetParameterModifier): Turned to property.
12470 (Invocation.Error_InvalidArguments): Add more descriptive errors.
12472 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
12475 2005-05-09 Raja R Harinath <rharinath@novell.com>
12478 * decl.cs (MemberCache.AddMethods): Register override methods,
12479 rather than non-override methods.
12480 * typemanager.cs (RegisterOverride): New.
12481 (IsOverride): Update.
12483 2005-05-09 Marek Safar <marek.safar@seznam.cz>
12487 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
12488 recursive declaration.
12490 * statement.cs (Block.ResolveMeta): Report any error in resolving.
12492 2005-05-06 Marek Safar <marek.safar@seznam.cz>
12494 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
12496 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
12498 2005-05-05 Raja R Harinath <rharinath@novell.com>
12501 * decl.cs (DeclSpace.FamilyAccessible):
12502 Use TypeManager.IsNestedFamilyAccessible.
12504 Fix reopened #64812.
12505 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
12508 2005-05-04 Raja R Harinath <rharinath@novell.com>
12509 Abin Thomas <projectmonokochi@rediffmail.com>
12510 Anoob V E <projectmonokochi@rediffmail.com>
12511 Harilal P R <projectmonokochi@rediffmail.com>
12514 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
12515 allow access to all static members.
12517 2005-05-04 Martin Baulig <martin@ximian.com>
12519 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
12521 2005-05-04 Martin Baulig <martin@ximian.com>
12525 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
12526 section at the end; make things work if `default' is not the last
12529 2005-05-04 Martin Baulig <martin@ximian.com>
12533 * statement.cs (Switch): Replaced the `got_default' field with a
12534 `default_section' one.
12535 (Switch.CheckSwitch): Set `default_section' here.
12536 (Switch.Resolve): If we're a constant switch and the constant is
12537 not found, use the default section.
12539 2005-05-03 Martin Baulig <martin@ximian.com>
12541 * expression.cs (ArrayAccess.EmitGetLength): New public method.
12543 * statement.cs (Foreach.ArrayForeach): New nested class.
12544 (Foreach.TemporaryVariable): New nested class.
12545 (Foreach.EmitArrayForeach): Removed; this is now in the new
12546 ArrayForeach class.
12548 2005-05-03 Raja R Harinath <rharinath@novell.com>
12550 * pending.cs (BaseImplements): Move the #74773 fix here. This is
12552 (VerifyPendingMethods): Revert change below.
12554 * typemanager.cs (IsOverride, RegisterNonOverride): New.
12555 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
12556 that used to trigger warning -28. Remove warning -28.
12557 * expression.cs (Invocation.OverloadResolve): Use
12558 TypeManager.IsOverride to distinguish override methods.
12561 * pending.cs (VerifyPendingMethods): If a base type implements the
12562 requested interface, don't bother checking individual methods of
12563 the base type. As a side-effect, this prevents the creation of
12564 unnecessary proxies.
12566 2005-05-02 Martin Baulig <martin@ximian.com>
12570 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
12571 Also `And' the locals if the old vector is null.
12572 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
12573 null; in this case we basically reset all the variables.
12575 2005-05-02 Martin Baulig <martin@ximian.com>
12579 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
12580 Added `FlowBranching branching' argument; always `and' the
12581 variables instead of `or'ing them unless we're an infinite loop.
12583 * statement.cs (While.Resolve): Create a new sibling unless we're
12586 2005-05-02 Martin Baulig <martin@ximian.com>
12590 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
12591 arguments; use it instead of creating a new TopLevelBlock.
12592 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
12593 our ConstructorInitializer.
12596 (TopLevelBlock.TopLevelBranching): New public property.
12597 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
12598 and create our `TopLevelBranching'.
12600 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
12601 anonymous method host, use `block.TopLevelBranching' rather than
12602 creating a new branching.
12604 2005-04-20 Miguel de Icaza <miguel@novell.com>
12606 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
12607 a ScopeInfo, if any of the current children is a child of the new
12608 entry, move those children there.
12610 2005-04-30 Martin Baulig <martin@ximian.com>
12612 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
12613 at the beginning of a SwitchSection. Fix #73335.
12615 2005-04-27 Marek Safar <marek.safar@seznam.cz>
12618 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
12620 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
12621 (FieldExpr.DoResolve): Obsolete members are ignored for field
12624 2005-04-26 Marek Safar <marek.safar@seznam.cz>
12626 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
12627 of arrays detection.
12629 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
12631 (Field.VerifyClsCompliance): Volatile fields are not compliant.
12633 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
12636 2005-04-25 Ben Maurer <bmaurer@ximian.com>
12638 * cs-parser.jay: Use the prefered version of -unsafe in error
12641 2005-04-22 Marek Safar <marek.safar@seznam.cz>
12643 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
12646 2005-04-20 John Luke <john.luke@gmail.com>
12648 * driver.cs: fix typo in error message, --outout to --output
12650 2005-04-20 Marek Safar <marek.safar@seznam.cz>
12652 * codegen.cs (InRefOutArgumentResolving): New field.
12654 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
12655 fields outside contructor.
12657 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
12659 2005-04-19 Miguel de Icaza <miguel@novell.com>
12661 * anonymous.cs (CaptureContext.EmitParameterInstance): The
12662 parameter code was not completed ever, so it was not as up-to-date
12663 as local variables. Must finish it.
12665 The bug fix was to compare the Toplevel of the block, not the
12666 current block. Thanks for Ben for pointing this out.
12668 2005-04-19 Raja R Harinath <rharinath@novell.com>
12670 * decl.cs (AddMethods): Use the declaring type of the problem
12671 method to determine if we want to squash a warning.
12673 2005-04-19 Marek Safar <marek.safar@seznam.cz>
12675 * attribute.cs: Removed debug output.
12677 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
12679 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
12682 2005-04-18 Raja R Harinath <rharinath@novell.com>
12685 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
12686 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
12687 all null comparisons against reference types.
12689 2005-04-18 Marek Safar <marek.safar@seznam.cz>
12692 * class.cs (TypeContainer.CircularDepException) New nested
12694 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
12695 (TypeContainer.DefineType): Removed error, reset InTransit before
12697 (Class.DefineType): Throw exception when is in Transit.
12698 Catch exception and report error.
12699 (Struct.DefineType): Throw exception when is in Transit.
12700 Catch exception and report error.
12701 (Interface.DefineType): Throw exception when is in Transit.
12702 Catch exception and report error.
12704 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
12705 handle nested exception handlers.
12707 * flowanalysis.cs (InTryWithCatch): New method, search for try with
12710 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
12711 InFinally and InCatch storage.
12713 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
12714 (Catch.Resolve): Set and Restore ec.InCatch.
12715 (Try.Resolve): Set and Restore ec.InFinally.
12716 (Try.HasCatch): True when try has catch.
12718 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
12720 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
12721 for the same event member, so exclude such cases from warning 419.
12724 2005-04-16 Miguel de Icaza <miguel@novell.com>
12726 * expression.cs (Binary.ResolveOperator): Apply patch from John
12727 Luke to fix bug 59864: operators &, | and ^ on enumerations
12728 require that the same enum type on both sides.
12730 * driver.cs: Add warnings to old flag usage, this is to assist
12731 people who produce Makefiles and hope that the Makefiles will be
12734 * class.cs (TypeContainer.EmitType): Moved the definition of the
12735 special $PRIVATE$ field from the resolve phase to the Emit phase.
12736 During resolve we do not know if we are a struct with
12737 HasExplicitLayout, we know this only after the attributes for the
12740 Set the FieldOffset to zero on the dummy field that we create for
12741 the class. Fixes 74590.
12743 2005-04-16 Raja R Harinath <rharinath@novell.com>
12746 * ecore.cs (PropertyExpr.resolved): New.
12747 (DoResolve): Use it to handle a case of double resolution here.
12748 Handle a case of identical-name-and-type-name.
12749 * expression.cs (ArrayCreation.CheckIndices): Avoid double
12750 resolution by storing the results of expression resolution back
12751 into the "probes" array.
12753 2005-04-15 Raja R Harinath <rharinath@novell.com>
12755 Fix cs0208-7.cs and cs0208-8.cs.
12756 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
12757 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
12758 error reporting to point out the reason a struct is not unmanaged.
12760 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
12762 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
12763 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
12765 2005-04-13 Raja R Harinath <rharinath@novell.com>
12768 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
12769 IdenticalNameAndTypeName here.
12770 (EventExpr.InstanceResolve): Likewise.
12772 2005-04-13 Marek Safar <marek.safar@seznam.cz>
12774 C# 2.0 DefaultCharSetAttribute implementation
12776 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
12777 which allows us to set GlobalNamespace for every resolve.
12778 (Attribute.ResolveArguments): Cut from Resolve.
12779 (Attribute.GetCharSetValue): Returns CharSet named argument.
12780 (Attribute.DefinePInvokeMethod): Gets default charset from
12782 (GlobalAttribute.ResolveAsTypeStep): Override.
12783 (GlobalAttribute.ResolveArguments): Override.
12785 * class.cs (TypeAttr): Is protected.
12787 * codegen.cs (ModuleClass.DefaultCharSet): New member.
12788 (ModuleClass.DefaultCharSetType): New memeber.
12789 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
12791 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
12792 charset from module.
12794 * delegate.cs (TypeAttr): Override.
12795 (Delegate.DefineType): Use this TypeAttr.
12797 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
12798 at very early stage (before types are defined) to resolve model
12799 module attributes. It will probably not work with corlib but it
12802 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
12803 charset from module.
12805 * typemanager.cs (default_charset_type): New type.
12807 2005-04-13 Raja R Harinath <rharinath@novell.com>
12809 * decl.cs (MemberCache.AddMethods): Don't warn if
12810 System.Object.Finalize has buggy MethodAttributes.
12812 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
12815 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
12817 * doc.cs : detect ambiguous reference to overloaded members.
12818 Fixed bug #71603. MS 1.1 csc does not detect it.
12820 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
12822 * doc.cs : delegates must not be referenced with parameters.
12825 2005-04-12 Miguel de Icaza <miguel@novell.com>
12827 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
12829 2005-04-10 Miguel de Icaza <miguel@novell.com>
12831 * driver.cs (MainDriver): Stop processing if the CLS stage found
12834 (CompilerCallableEntryPoint.InvokeCompiler): Always
12835 reset after execution; Take a TextWriter argument for the
12838 * report.cs: Use the error stream instead of hardcoding stderr.
12840 2005-04-09 Miguel de Icaza <miguel@novell.com>
12842 * class.cs: Reduce code paths to test, too small of an
12843 optimization to make it worth the extra testing. Always perform
12846 2005-04-08 Raja R Harinath <rharinath@novell.com>
12849 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
12850 operators that had errors reported on them.
12852 2005-04-08 Marek Safar <marek.safar@seznam.cz>
12854 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
12856 (Attribute.Resolve): Add named argument type checking.
12858 * class.cs (FixedField.Define): Use IsPrimitiveType
12860 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
12862 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
12863 unsafe parameter types.
12865 * statement.cs (Using.ResolveExpression): Add better error description.
12867 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
12869 2005-04-08 Raja R Harinath <rharinath@novell.com>
12872 * attribute.cs (Attribute.GetAttributeUsage): Resolve
12873 AttributeUsageAttribute in the emitcontext of the attribute class,
12874 not in the emitcontext of the attributable entity it was attached to.
12875 * cs-parser.jay: Use 'current_class', not 'current_container',
12876 when creating a GlobalAttribute.
12878 2005-04-08 Alp Toker <alp@atoker.com>
12880 * pending.cs: The fix to #58413 failed to compile methods implementing
12881 interfaces with/without params modifiers and vice versa, even though
12882 params modifiers aren't part of the signature. Make the modifier check
12883 less strict as in csc.
12885 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
12886 Anoob V E <projectmonokochi@rediffmail.com>
12887 Harilal P R <projectmonokochi@rediffmail.com>
12890 * pending.cs (TypeAndMethods.mods): New. Store the parameter
12891 modifiers of pending methods.
12892 (PendingImplementation.PendingImplementation): Initialize it.
12893 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
12894 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
12895 with ParameterData. Add check for modifiers.
12896 * class.cs (MethodData.Define): Update to changes.
12898 2005-04-07 Raja R Harinath <rharinath@novell.com>
12900 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
12902 2005-04-07 Marek Safar <marek.safar@seznam.cz>
12904 * class.cs (PropertyMethod.Define): Check private accessor in abstract
12907 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
12910 * typemanager.cs: Registered RequiredAttributeAttribute.
12912 2005-04-06 Marek Safar <marek.safar@seznam.cz>
12914 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
12915 Warning CS0169 is back at level 3.
12916 (IMethodData.SetMemberIsUsed): New method.
12918 * decl.cs (IsUsed): New value; moved from FieldBase.Status
12919 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
12921 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
12923 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
12925 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
12928 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
12931 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
12932 to avoid the problems with nested types.
12934 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
12935 Anoob V.E <projectmonokochi@rediffmail.com>
12936 Harilal P.R <projectmonokochi@rediffmail.com>
12937 Raja R Harinath <rharinath@novell.com>
12940 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
12942 * typemanager (GetConstructor): Make public.
12944 2005-04-05 John Luke <john.luke@gmail.com>
12945 Raja R Harinath <rharinath@novell.com>
12948 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
12949 struct too. Return false quicker in a few cases.
12950 (VerifyUnManaged): Use it.
12952 2005-04-05 Raja R Harinath <rharinath@novell.com>
12955 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
12956 not 'unreachable_seen'.
12958 2005-04-04 Marek Safar <marek.safar@seznam.cz>
12960 * attribute.cs (Attribute.GetValue): Removed unused.
12962 * codegen.cs (CodeGen.TrimExt): Removed unused.
12964 * cs-parser.jay (output): Removed unused.
12966 * cs-tokenizer.cs (hex_digits): Removed unused.
12968 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
12970 * expression.cs (Indirection.LoadExprValue): Removed unused.
12971 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
12973 * iterators.cs (Iterator.param_types): Removed unused.
12975 * statement.cs (Goto.block): Removed unused.
12976 (ToplevelBlock.did): Removed unused.
12977 (Switch.ResolveConstantSwitch): Removed unused.
12979 2005-04-01 Ben Maurer <bmaurer@ximian.com>
12981 * rootcontext.cs: Allow mcs to bootstrap with the compilation
12984 2005-04-01 Raja R Harinath <rharinath@novell.com>
12986 Fix #74232 and cs0208-3.cs.
12987 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
12988 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
12989 unmanaged type. Don't use FieldBuilders when 't' is a
12990 TypeBuilder. Use ModFlags and MemberType fields.
12991 * class.cs (MemberBase.member_type): Rename from MemberType.
12992 (MemberBase.MemberType): New property. Determines member_type on
12994 (MemberBase.DoDefine): Don't initialize MemberType here.
12995 (FieldMember.Define): Likewise.
12997 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13000 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13001 Attributes are emitted there.
13003 2005-04-01 Raja R Harinath <rharinath@novell.com>
13005 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13006 keyword in 'partial enum' too.
13007 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13009 Report from Kamil Skalski <nazgul@omega.pl>.
13012 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13013 have partial containers too.
13015 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13016 in block' checks to Block.CheckInvariantMeaningInBlock.
13017 * statement.cs (Block.GetKnownVariableInfo): Make private.
13018 (Block.IsVariableUsedInChildBlock): Remove.
13019 (Block.IsVariableUsedInBlock): Likewise.
13020 (Block.CheckInvariantMeaningInBlock): New. Show location of
13021 conflicting declaration.
13022 (Block.AddVariable): Make error messages less long-winded and more
13023 specific. Show location of conflicting declaration.
13024 * parameter.cs (Parameters.Location): New readonly property.
13026 2005-03-31 Raja R Harinath <rharinath@novell.com>
13028 Clean up semantics of invoking ResolveMemberAccess.
13029 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13030 can have an instance, ensure that we pass in a non-TypeExpression
13031 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13032 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13033 argument. Update to changes and simplify.
13034 (FieldExpr.Emitinstance): Remove CS0120 check.
13035 (PropertyExpr.EmitInstance): Likewise.
13036 * expression.cs (Argument.Resolve): Likewise.
13037 (Invocation.DoResolve): Update to changes in semantics of
13038 InstanceExpression.
13040 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13043 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13046 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13048 2005-03-31 Raja R Harinath <rharinath@novell.com>
13050 Fix difference in behaviour with commandline invocation.
13051 * driver.cs (Driver.Reset): New.
13052 (CompilerCallableEntryPoint): Call it.
13054 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13055 variable" warnings if the boolean expression failed to resolve.
13057 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13059 * attribute.cs: Fix the union of several permissions when some of them
13060 are unrestricted (so the result isn't an unrestricted permission set).
13063 2005-03-30 Raja R Harinath <rharinath@novell.com>
13065 * ecore.cs (MemberExpr): New class. Convert from interface
13067 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13068 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13070 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13071 (MethodGroupExpr.IsExplicitImpl): Remove.
13072 (Expression.GetFieldFromEvent): Remove.
13073 (SimpleName.MemberStaticCheck): Remove.
13074 (SimpleName.DoSimpleNameResolve): Update to changes.
13075 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13076 (MemberAccess.IdenticalNameAndTypeName): Remove.
13077 (MemberAccess.error176): Move to MemberExpr.
13078 (MemberAccess.DoResolve): Update to changes.
13079 (BaseAccess.DoResolve): Likewise.
13081 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13083 C# 2.0 Conditional attribute class implementation
13085 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13086 Analyzes class whether it has attribute which has ConditionalAttribute
13087 and its condition is not defined.
13089 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13090 (Class.IsExcluded): New method. Search for at least one defined
13091 condition in ConditionalAttribute of attribute class.
13093 2005-03-30 Raja R Harinath <rharinath@novell.com>
13095 * ecore.cs (PropertyExpr): Derive from Expression, not
13096 ExpressionStatement.
13097 (PropertyExpr.EmitStatement): Remove.
13099 2005-03-29 Raja R Harinath <rharinath@novell.com>
13102 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13103 internal field "value__" of an enum be private. The examples for
13104 "value__" that I found on MSDN all used FieldAttributes.Private.
13106 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13107 Don't mention IL method attribute names.
13109 Fix #47991. Remove a TODO.
13110 * statement.cs (Block.Toplevel): Make into a field.
13111 (Block.Parameters): Move into ToplevelBlock.
13112 (Block.known_variables): Rename from child_variable_names.
13113 (Block.Block): Remove variants that take Parameters. Initialize
13114 'Toplevel' with the immediately surrounding toplevel block.
13115 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
13116 LocalInfo parameter.
13117 (Block.GetKnownVariableInfo): New.
13118 (Block.IsVariableNameUsedInChildBlock): Update.
13119 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
13120 the block, even though it may not be in scope.
13121 (Block.AddVariable): Remove Parameters parameter. Use
13122 Toplevel.Parameters instead.
13123 (Block.AddConstant): Remove Parameters parameter.
13124 (Block.GetParameterReference): Update to use Toplevel.Parameters.
13125 (Block.IsParamaterReference): Likewise.
13126 (Block.IsLocalParameter): Likewise. Simplify a lot.
13127 (ToplevelBlock.Parameters): New. Moved from Block.
13128 (ToplevelBlock.ToplevelBlock): Update to changes. Always
13129 initialize Parameters to a non-null value.
13130 * cs-parser.jay: Update to changes.
13131 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
13132 simple names that mean different things in the same block. Use
13133 Block.IsVariableNameUsedInBlock.
13135 2005-03-28 Raja R Harinath <rharinath@novell.com>
13137 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
13138 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
13139 GetTypeHandle. It is possible for a reflected type to derive from
13140 a TypeBuilder (e.g., int[] derives from the TypeBuilder
13141 System.Array during mscorlib compilation).
13142 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
13143 contain a method_hash, don't create one either. Don't create a
13144 deep copy of the base cache's method_hash.
13145 (MemberCache.SetupCache): Rename back from DeepCopy.
13146 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
13147 already initialized. If we see an override function, add its
13148 underlying base virtual function to the member_hash too.
13150 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
13152 2005-03-26 Raja R Harinath <harinath@acm.org>
13155 * assign.cs (Assign.DoResolve): When the RHS of an assignment
13156 fails to resolve, ensure that the LHS is still resolved as an
13159 2005-03-25 Raja R Harinath <harinath@acm.org>
13161 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
13163 (Enum.current_ec): Remove.
13164 (Enum.LookupEnumValue): Remove EmitContext argument.
13165 Just uses the one created during DefineType.
13166 (Enum.FindMembers): Update.
13167 * expression.cs (MemberAccess.DoResolve): Update.
13169 2005-03-22 Marek Safar <marek.safar@seznam.cz>
13171 * assign.cs (Assign.DoResolve): Check for CS1717 when
13172 source and target are same (uses Equals).
13174 * expression.cs (LocalVariableReference, ParameterReference,
13175 This): Implemented Equals, GetHashCode.
13177 * statement.cs (Block.GetParameterReference): Removed useless
13180 2005-03-22 Raja R Harinath <rharinath@novell.com>
13183 * statement.cs (Block.AddVariable): Ensure that we skip implicit
13184 blocks before deciding whether the error is cs0136 or cs0128.
13186 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
13187 (using_alias_directive, using_namespace_directive): Pass
13188 MemberName, not an expression to Namespace.UsingAlias and
13190 (MakeName): Use the MemberName of the namespace.
13191 * namespace.cs (Namespace.MemberName): New.
13192 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
13193 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
13195 * decl.cs (MemberName.Name): Make readonly.
13196 (MemberName.FromDotted): New "constructor".
13197 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
13198 (MemberCore.Name): Compute from MemberName on demand.
13199 (MemberCore.SetMemberName): Provide a way to change the
13201 (MemberCore.AddToContainer): Don't take a fullname parameter.
13202 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
13203 fully qualified name of the container to the member name.
13204 (TypeContainer.AddToTypeContainer): Use a fully qualified name
13205 only if the type is a member of the root container.
13206 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
13207 MemberName.Left rather than searching for an embedded ".".
13208 (PartialContainer.CreatePart): Update to changes in RootContext.
13209 (MemberBase.ShortName): Turn into a property. Use
13210 MemberCore.SetMemberName.
13211 (MemberBase.ExplicitInterfaceName): Remove.
13212 (MemberBase.UpdateMemberName): Remove.
13213 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
13214 (PropertyBase.SetMemberName): New override.
13215 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
13216 (Tree.GetDecl): New.
13217 (Tree.AllDecls): Rename from Decls.
13218 * attribute.cs, enum.cs, report.cs: Update to changes.
13219 * driver.cs (MainDriver): Use MemberName.FromDotted on
13220 RootContext.MainClass.
13222 2005-03-21 Marek Safar <marek.safar@seznam.cz>
13224 * class.cs (FixedField.Define): Check for CS1664 and more sanity
13227 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
13229 2005-03-18 Marek Safar <marek.safar@seznam.cz>
13231 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
13232 property accessor modifiers.
13234 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
13235 fixed buffer attribute (CS1716).
13236 (PropertyMethod.HasCustomAccessModifier): When property accessor
13237 has custom modifier.
13239 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
13241 (PropertyExpr.DoResolveLValue): Add CS0272.
13243 2005-03-17 Miguel de Icaza <miguel@novell.com>
13245 * convert.cs: When converting to a pointer, use the proper Conv.U
13246 or Conv.I depending on the source data type.
13248 * cs-tokenizer.cs: Make the size for large decimal constants,
13251 2005-03-17 Martin Baulig <martin@ximian.com>
13253 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
13254 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
13256 2005-03-17 Martin Baulig <martin@ximian.com>
13258 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
13259 to bool so we can return an error condition.
13260 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
13263 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
13265 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
13268 2005-03-16 Raja R Harinath <rharinath@novell.com>
13270 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
13271 Refactor to avoid traversing the list of assemblies, and to avoid
13272 string concatenation.
13273 * typemanager.cs (guid_attr_type): Remove.
13274 (negative_hits, pointers, references): Remove hashes.
13276 (GetConstructedType): New. Uses type_hash to handle constructed
13277 types (arrays, references, pointers).
13278 (GetReferenceType, GetPointerType): Use it.
13279 (GetNestedType): New. Uses type_hash to handle nested types of
13281 (LookupType, LookupTypeDirect): Remove.
13282 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
13283 'types' hash and LookupTypeReflection directly.
13284 (params_string, params_object): Use GetConstructedType.
13285 * namespace.cs (Namespace.cached_types): New. Cache of reflected
13287 (Namespace.Lookup): Use cached_types.
13288 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
13289 provided by old TypeManager.LookupType.
13290 * rootcontext.cs (MakeFQN): Remove.
13291 * decl.cs (DeclSpace.MakeFQN): Likewise.
13292 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
13293 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13294 TypeManager.GetConstructedType.
13295 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
13297 2005-03-15 Marek Safar <marek.safar@seznam.cz>
13299 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
13302 * cs-parser.jay: Reports CS1527 for any namespace element.
13304 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
13307 * expression.cs (ParameterReference.IsAssigned): Changed error to
13309 (Error_WrongNumArguments): Moved CS0245 detection here.
13311 * statement.cs (Return.Resolve): Add CS1622 report.
13313 2005-03-11 Marek Safar <marek.safar@seznam.cz>
13315 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
13317 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
13319 * attribute.cs expression.cs: Get rid of some allocations.
13321 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
13323 * doc.cs : just eliminate the latest change.
13325 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13327 * doc.cs : commented out the latest change. It breaks xml-030.cs
13329 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13331 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
13332 fail. So invoke CreateType() in FindDocumentedType().
13334 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13336 * cs-tokenizer.cs : added IsKeyword().
13337 * doc.cs : Detect keyword incorrectly used as identifier.
13338 Allow identifiers prefixed by @.
13340 2005-03-10 Marek Safar <marek.safar@seznam.cz>
13342 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
13343 It caused exception in namespace resolving (again!).
13345 * class.cs (Class.ctor): Removed exit.
13346 (PropertyMethod.ctor): ditto.
13348 * codegen.cs (Codegen.Reset): Reset static data.
13349 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
13351 * cs-tokenizer.cs (Cleanup): Removed.
13353 * driver.cs (GetSystemDir): Rewrote to one line command.
13354 It caused problem with unloaded dynamic modules.
13355 (UnixParseOption): Removed Exit.
13356 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
13357 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
13358 Now can be mcs used as library.
13360 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
13363 * location.cs (Reset): Reset static data.
13365 * namespace.cs (Reset): Reset static data.
13367 * report.cs (Report.Reset): Reset static data.
13369 * rootcontext.cs (RootContext.Reset): Reset static data.
13371 * tree.cs (RootTypes.ctor): Use Location.Null
13373 * typemanager.cs (TypeManager.Reset): Reset static data.
13374 (CoreLookupType): Removed Exit.
13375 (TypeHandle.Reset): Reset static data.
13377 2005-03-10 Raja R Harinath <rharinath@novell.com>
13380 * typemanager.cs (ComputeNamespaces): Import namespaces from
13381 referenced modules too.
13383 2005-03-09 Raja R Harinath <rharinath@novell.com>
13385 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
13388 2005-03-09 Raja R Harinath <rharinath@novell.com>
13390 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
13391 enclosing DeclSpace. This ensures that a name-lookup populates
13392 more caches and there are fewer 'TypeExpression's. Carve out
13393 nested type lookup into ...
13394 (LookupNestedTypeInHierarchy): ... this.
13396 2005-03-09 Raja R Harinath <rharinath@novell.com>
13398 Clean up a few partial-class semantics.
13399 Fixes test-357.cs and cs1618-2.cs.
13400 * cs-parser.jay (struct_declaration): Use 'current_class' as
13401 parent of newly-created struct. Remove call to Register ().
13402 Use 'pop_current_class' to complete handing the current struct.
13403 (interface_declaration): Likewise.
13404 (class_declaration): Likewise.
13405 (enum_declaration): Use 'current_class' as parent of newly created
13407 (delegate_declaration): Likewise.
13408 (pop_current_class): New function. This is used to handle closing
13409 up the 'current_class' and 'current_container', and pointing them
13410 to the enclosing class/container.
13411 (CSharpParser): Initialize 'current_class' too.
13412 * decl.cs (MemberCore): Add check for invariant: a partial
13413 container is not a parsed entity, and thus does not enclose any
13415 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
13416 (DeclSpace.BaseTypeExpr): Use it.
13417 (DeclSpace.LookupType): Add check for invariant.
13418 * class.cs (TypeContainer): Add check for invariant: a nested
13419 class should have the same NamespaceEntry as its enclosing class.
13420 (TypeContainer.EmitFieldInitializers): Make virtual.
13421 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
13423 (TypeContainer.Register): Remove.
13424 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
13425 null. Use TypeResolveEmitContext for resolving base types and
13426 interfaces. Move initialization of Parts.TypeBuilder here from
13428 (TypeContainer.DefineNestedTypes): ... here.
13429 (PartialContainer): Take a Namespace not a NamespaceEntry.
13430 (PartialContainer.Create): Don't use Register. Call the
13431 appropriate Add... function directly.
13432 (ClassPart): Take both the PartialContainer and the enclosing
13433 class as constructor arguments.
13434 (ClassPart.EmitFieldInitializers): Override.
13435 (ClassPart.PartFindNestedTypes): Remove.
13436 (FieldBase.GetInitializerExpression): Resolve the initializer
13437 expression in the emit context of the enclosing class.
13438 * tree.cs (RootTypes): Remove Register ().
13440 2005-03-08 Marek Safar <marek.safar@seznam.cz>
13442 * cs-parser.jay: Removed CS0134.
13444 * driver.cs: Removed CS1901.
13446 * expression.cs (SizeOf.DoResolve): Don't report CS0233
13447 for predefined types.
13449 2005-03-07 Duncan Mak <duncan@novell.com>
13451 * codegen.cs (Save): Catch UnauthorizedAccessException as
13452 well. Fixes bug #73454.
13454 2005-03-07 Marek Safar <marek.safar@seznam.cz>
13456 * cs-tokenizer.cs (xtoken): Add CS1035.
13458 * class.cs (MethodData.Define): Add CS0683.
13459 (FieldMember.ctor): Add CS0681.
13461 2005-03-07 Raja R Harinath <rharinath@novell.com>
13463 * ecore.cs (SimpleName.DoResolve): Rename from
13464 SimpleName.DoResolveAllowStatic.
13465 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
13466 Pass 'intermediate' flag to MemberStaticCheck.
13467 (SimpleName.MemberStaticCheck): Skip "static check" only in case
13468 of "intermediate" lookups via MemberAccess.
13469 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
13470 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
13472 2005-03-07 Raja R Harinath <rharinath@novell.com>
13475 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
13476 slipped in because of variable names that are identical to a
13477 builtin type's BCL equivalent ('string String;', 'int Int32;').
13478 (PropertyExpr.EmitInstance): Likewise.
13480 2005-03-04 Marek Safar <marek.safar@seznam.cz>
13482 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
13484 * report.cs (warning_ignore_table): Made public.
13486 2005-03-04 Raja R Harinath <rharinath@novell.com>
13489 * class.cs (MethodData.Emit): Pass 'container' to
13490 container.GetObsoleteAttribute instead of 'container.Parent'.
13492 2005-03-03 Marek Safar <marek.safar@seznam.cz>
13494 * cs-parser.jay: Add 1534 error test.
13496 * iterators.cs (Yield.CheckContext): Add error 1629.
13497 (Iterator.ctor): Save unsafe modifier.
13498 (MoveNextMethod.DoEmit): Restore unsafe context.
13500 * namespace.cs (UsingAlias): Better error message.
13502 2005-03-03 Dan Winship <danw@novell.com>
13504 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
13505 the warning message [#73219]
13507 2005-03-03 Raja R Harinath <rharinath@novell.com>
13509 Fix compile with MCS 1.0.0.0.
13510 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
13511 w_restore to not depend on string constant folding.
13513 2005-03-03 Raja R Harinath <rharinath@novell.com>
13515 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
13516 CS0246 check to users who passed 'silent = false'.
13517 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
13519 (SimpleName.SimpleNameResolve): Update.
13520 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
13521 (MemberAccess.IdenticalNameAndTypeName): Update.
13522 * doc.cs (FindDocumentedTypeNonArray): Update.
13524 2005-03-03 Raja R Harinath <rharinath@novell.com>
13526 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
13527 * parameters.cs (ComputeAndDefineParameters): Remove.
13528 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
13529 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
13530 Use GetParameterInfo.
13532 2005-03-02 Marek Safar <marek.safar@seznam.cz>
13534 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
13536 2005-03-02 Raja R Harinath <rharinath@novell.com>
13538 Unify DeclSpace.LookupType and DeclSpace.FindType.
13539 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
13540 is in charge of defining nested types on demand.
13541 (DeclSpace.LookupType): Use it when the current_type is a
13542 TypeBuilder. Use LookupTypeDirect for reflected types.
13543 (DeclSpace.FindType): Remove.
13544 (DeclSpace.LookupInterfaceOrClass): Likewise.
13545 (DeclSpace.DefineTypeAndParents): Likewise.
13546 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
13547 DeclSpace.LookupType.
13548 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
13549 * typemanager.cs (LookupType): Simplify.
13550 (AddUserType): Remove type from negative_hits.
13551 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
13552 * class.cs (TypeContainer.FindMembers): Move handling of nested
13554 (TypeContainer.FindMembers_NestedTypes): ... here.
13555 (TypeContainer.FindNestedType): Implement override.
13556 (ClassPart.FindNestedType): Delegate to PartialContainer.
13557 (ClassPart.PartFindNestedType): Looks up the nested types of the
13560 2005-03-02 Martin Baulig <martin@ximian.com>
13562 * class.cs (TypeContainer.DoDefineMembers): We also need a default
13563 static constructor in static classes.
13565 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
13567 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
13568 sizeParamIndex is not specified.
13570 2005-03-01 Marek Safar <marek.safar@seznam.cz>
13573 * report.cs (WarningMessage.IsEnabled): Missing null check.
13575 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13577 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
13578 in the fields and not in the properties.
13580 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
13582 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
13585 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13587 * attribute.cs: Small refactoring (improved robustness).
13588 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
13589 (ValidateGuid): Removed.
13590 (Resolve): Removed referenced to above mentioned.
13591 (GetAttributeUsage): Made private and changed to work without
13593 (GetIndexerAttributeValue): Don't crash.
13594 (GetConditionalAttributeValue): Ditto.
13595 (GetClsCompliantAttributeValue): Ditto.
13596 (ExtractSecurityPermissionSet): All attributes exceptions are
13598 (GetPropertyValue): New helper.
13599 (GetMethodImplOptions): New method.
13600 (DefinePInvokeMethod): Reuse common code. Implemented handling of
13601 some missing properties.
13603 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
13604 (Method.ApplyAttributeBuilder): Updated.
13606 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
13609 2005-02-28 Raja R Harinath <rharinath@novell.com>
13612 * report.cs (Report.SymbolRelatedToPreviousError): Handle
13613 non-simple types (array, pointer, reference).
13615 2005-02-28 Marek Safar <marek.safar@seznam.cz>
13617 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
13619 * class.cs (MethodCore.IsDuplicateImplementation): Special error
13621 (Method.CheckBase): Catch wrong destructor here.
13622 (MethodData.Define): Add errors 550, 668.
13624 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
13626 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
13628 * pending.cs (VerifyPendingMethods): Add error 551.
13630 * typemanager.cs (CSharpName): Next error report helper.
13632 2005-02-25 Marek Safar <marek.safar@seznam.cz>
13634 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
13635 attributes. Removed useless attribute double check.
13636 It saves almost 2MBs for corlib.
13638 2005-02-25 Raja R Harinath <rharinath@novell.com>
13641 * statement.cs (ExpressionStatement.Resolve): Make robust to being
13642 called twice in case of error.
13644 2005-02-23 Chris Toshok <toshok@ximian.com>
13646 Fix compiler portions of #72827.
13647 * statement.cs (Block.Emit): call Begin/EndScope on the
13648 EmitContext instead of the ILGenerator.
13650 * codegen.cs (EmitContext.BeginScope): new method, call
13651 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
13653 (EmitContext.BeginScope): same, but EndScope and CloseScope
13655 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
13656 offset and call the superclass's OpenScope(int) with it.
13657 (SymbolWriter.CloseScope): get the current il
13658 offset and call superclass's CloseScope(int) with it.
13660 2005-02-23 Marek Safar <marek.safar@seznam.cz>
13662 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
13663 CS1677 for out and ref as well.
13665 * class.cs (Method.Define): Add error CS1599 detection.
13667 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
13669 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
13671 * delegate.cs (Delegate.Define): Add error CS1599 detection.
13673 * support.cs.cs (ModifierDesc): New helper method.
13675 2005-02-23 Raja R Harinath <rharinath@novell.com>
13676 Abin Thomas <projectmonokochi@rediffmail.com>
13677 Anoob V E <projectmonokochi@rediffmail.com>
13678 Harilal P R <projectmonokochi@rediffmail.com>
13680 Fix #57851, #72718.
13681 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
13682 MemberLookup (used for error reporting) actually returns a result.
13683 Fix error report number (122, not 112).
13685 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
13686 Anoob V E <projectmonokochi@rediffmail.com>
13687 Harilal P R <projectmonokochi@rediffmail.com>
13690 * pending.cs (PendingImplementation.GetAbstractMethods):
13691 Find NonPublic members too.
13693 2005-02-22 Marek Safar <marek.safar@seznam.cz>
13695 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
13698 * class.cs (MethodCore.CheckMethodAgainstBase):
13699 Add error 239 report.
13701 2005-02-21 Raja R Harinath <rharinath@novell.com>
13704 * expression.cs (Invocation.IsApplicable): Make public.
13705 (Invocation.IsParamsMethodApplicable): Likewise.
13706 * delegate.cs (Delegate.VerifyApplicability): Don't use
13707 Invocation.VerifyArgumentCompat for parameter applicability
13708 testing. Use Invocation.IsApplicable and
13709 Invocation.IsParamsMethodApplicable.
13711 2005-02-21 Marek Safar <marek.safar@seznam.cz>
13713 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
13715 * class.cs (Operator.Define): Add error 217 report.
13717 2005-02-21 Raja R Harinath <rharinath@novell.com>
13719 * namespace.cs (UsingEntry.Resolve): Undo change below.
13721 2005-02-21 Raja R Harinath <rharinath@novell.com>
13724 * ecore.cs (Expression.MemberLookupFailed): Add argument to
13725 disable the error message when the extended MemberLookup also
13727 (Expression.MemberLookupFinal): Update.
13728 (SimpleName.DoSimpleNameResolve): Update.
13729 * expression.cs (MemberAccess.ResolveNamespaceOrType):
13730 Don't use MemberLookupFinal.
13731 (New.DoResolve): Update.
13732 (BaseAccess.CommonResolve): Update.
13734 2005-02-21 Raja R Harinath <rharinath@novell.com>
13737 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
13738 occured previously, don't resolve again.
13740 2005-02-21 Marek Safar <marek.safar@seznam.cz>
13743 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
13744 argument. Call ResolveAttributeUsage for unresolved.
13745 when types doesn't match ctor arguments.
13747 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
13748 for nested attribute classes.
13749 (Class.attribute_usage): Removed.
13750 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
13751 for attribute class.
13753 * ecore.cs (IsAttribute): Removed.
13755 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
13757 * rootcontext.cs (RegisterAttribute): Removed, attributes are
13759 (attribute_types): Removed.
13760 (EmitCode): Global attributes are emited as the latest.
13762 2005-02-18 Marek Safar <marek.safar@seznam.cz>
13764 * class.cs (EmitFieldInitializers): Don't emit field initializer
13765 for default values when optimilization is on.
13767 * constant.cs (Constant.IsDefaultValue): New property.
13769 * driver.cs: Add /optimize handling.
13773 * literal.cs: Implement new IsDefaultValue property.
13775 * rootcontext.cs (Optimize): New field, holds /optimize option.
13777 2005-02-18 Raja R Harinath <rharinath@novell.com>
13779 Fix crasher in re-opened #72347.
13780 * namespace.cs (Namespace.Lookup): Return null if
13781 DeclSpace.DefineType returns null.
13784 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
13786 2005-02-18 Raja R Harinath <rharinath@novell.com>
13788 Fix remainder of #63202. Change semantics of DoResolveLValue: it
13789 now returns null if it cannot resolve to an lvalue.
13790 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
13791 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
13792 returned null. Remove check for SimpleName.
13793 (EventExpr.DoResolveLValue): New.
13794 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
13795 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
13797 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
13798 avoid CS0131 error.
13799 (Unary.ResolveOperator): Move CS0211 check ...
13800 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
13802 (Unary.DoResolveLValue): Simplify.
13803 (AddressOf.DoResolveLValue): New.
13804 (ArrayAccess.DoResolveLValue): New.
13806 2005-02-16 Marek Safar <marek.safar@seznam.cz>
13808 * attribute.cs (Attribute.Resolve): Add arguments casting for
13809 when types doesn't match ctor arguments.
13811 2005-02-16 Raja R Harinath <rharinath@novell.com>
13813 Fix parts of #63202.
13814 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
13815 lookup of operator in base type. Ensure that all checks happen
13816 when the operator resolves to an "op_..." method.
13818 2005-02-15 Raja R Harinath <rharinath@novell.com>
13821 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
13822 'ignore_cs0104' parameter. Pass it to ...
13823 (NamespaceEntry.Lookup): ... this.
13824 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
13825 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
13826 (TypeLookupExpression.DoResolveAsTypeStep): Update.
13827 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
13828 Update. Request that cs0104 errors be ignored.
13829 (ComposedCast.ResolveAsTypeStep): Update.
13831 2005-02-14 Raja R Harinath <rharinath@novell.com>
13834 * expression.cs (Invocation.BetterFunction): Remove support for
13835 comparing virtual functions and their overrides.
13836 (Invocation.IsOverride): New.
13837 (Invocation.OverloadResolve): Don't consider 'override' functions
13838 during candidate selection. Store them in a lookaside list.
13839 If the selected method is a 'virtual' function, use the list to
13840 find any overrides that are closer to the LHS type.
13842 2005-02-14 Marek Safar <marek.safar@seznam.cz>
13844 * expression.cs (New.DoResolve): Add complex core type reduction.
13845 (New.Constantify): Converts complex core type syntax like 'new int ()'
13846 to simple constant.
13848 2005-02-14 Raja R Harinath <rharinath@novell.com>
13850 * decl.cs (EntryType.EntryType): New constructor to create an
13851 updated copy of a cache entry.
13852 (MemberCache.AddMethods): Use it.
13853 (MemberCache.ClearDeclaredOnly): Remove.
13854 (MemberCache.MemberCache): Update.
13856 2005-02-11 Miguel de Icaza <miguel@novell.com>
13858 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
13859 variable. This one is represents the actual low-level declaration
13860 of the method, as opposed to the semantic level `IsStatic'.
13862 An anonymous method which is hosted into a static method might be
13863 actually an instance method. IsStatic would reflect the
13864 container, while MethodIsStatic represents the actual code
13867 * expression.cs (ParameterReference): Use the new MethodIsStatic
13868 instead of IsStatic.
13870 * anonymous.cs (AnonymousMethod.Compatible): Pass the
13871 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
13872 set on the current EmitContext.
13874 * expression.cs (Cast): Overload DoResolveLValue so we can pass
13875 resolve our casted expression as an LValue. This triggers the
13876 proper LValue processing that is later required by Assign.
13880 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
13882 2005-02-11 Marek Safar <marek.safar@seznam.cz>
13884 C# 2.0 Fixed buffer implementation
13886 * anonymous.cs: Update after RegisterHelperClass renaming.
13888 * attribute.cs (AttributeTester.fixed_buffer_cache):
13889 Cache of external fixed buffers.
13890 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
13891 implementation if field is fixed buffer else null.
13894 (TypeContainer.AddField): Accept FieldMember instead of Field.
13895 (FieldBase.IsFieldClsCompliant): Extracted code from
13896 VerifyClsCompliance descendant customization.
13897 (FixedField): New class handles fixed buffer fields.
13898 (FixedFieldExternal): Keeps information about imported fixed
13900 (IFixedField): Make access to internal or external fixed buffer
13903 * cs-parser.jay: Add fixed buffer parsing.
13905 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
13908 * expression.cs (Indirection): Extended implementation to accept
13909 fixed buffer field.
13910 (PointerArithmetic.Emit): Get element from fixed buffer as well.
13911 (ElementAccess.MakePointerAccess): Get type as parameter.
13912 (DoResolve): Add fixed buffer field expression conversion.
13913 (DoResolveLValue): Ditto.
13914 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
13915 (ArrayPtr): Derives from FixedBufferPtr.
13916 (ArrayPtr.Emit): Add extra emit for array elements.
13918 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
13920 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
13921 for compiler generated types.
13922 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
13924 * statement.cs (Fixed): Refactored to be easier add fixed buffer
13925 and consume less memory.
13926 (Fixed.Resolve): Add fixed buffer case.
13928 * typemanager.cs (compiler_generated_attr_ctor,
13929 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
13930 (HasElementType): Add our own implementation to work on every
13933 2005-02-11 Miguel de Icaza <miguel@novell.com>
13935 * anonymous.cs (CaptureContext): Track whether `this' has been
13938 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
13939 only captured `this' if it was implicitly done (instance
13940 methods/variables were used).
13942 * codegen.cs (EmitContext.CaptureThis): New method to flag that
13943 `this' must be captured.
13945 2005-01-30 Miguel de Icaza <miguel@novell.com>
13947 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
13948 is null it means that there has been no need to capture anything,
13949 so we just create a sibling.
13951 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
13953 Just a partial fix. The other half is fairly elusive.
13955 2005-02-10 Raja R Harinath <rharinath@novell.com>
13957 Fix #52586, cs0121-4.cs.
13958 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
13959 and return a hashtable.
13960 (MemberCache.ClearDeclaredOnly): New.
13961 (MemberCache.MemberCache): Update to change. Make a deep copy of
13962 the method_hash of a base type too.
13963 (MemberCache.AddMethods): Adapt to having a deep copy of the base
13964 type methods. Overwrite entries with the same MethodHandle so
13965 that the ReflectedType is correct. The process leaves in base
13966 virtual functions and their overrides as distinct entries.
13967 (CacheEntry): Now a class instead of a struct. It shouldn't alter
13968 matters since it was boxed in a ArrayList before.
13969 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
13971 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
13972 case of a virtual function and its override (choose the overload
13974 (Invocation.OverloadResolve): Avoid 'override' members during
13975 'applicable_type' calculation.
13977 2005-02-09 Raja R Harinath <rharinath@novell.com>
13979 Combine two near-redundant caches.
13980 * typemanager.cs (method_params): Rename from method_internal_params.
13981 (TypeManager.GetParameterData): New. Replace
13982 Invocation.GetParameterData.
13983 (TypeManager.LookupParametersByBuilder): Remove.
13984 * expression.cs (Invocation.method_parameter_cache): Remove.
13985 (Invocation.GetParameterData): Remove.
13987 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
13990 2005-02-08 Raja R Harinath <rharinath@novell.com>
13993 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
13994 TypeManager.multicast_delegate_type is null, resolve it by looking
13995 up "System.MulticastDelegate".
13996 * rootcontext.cs (RootContext.ResolveCore): Simplify.
13998 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
13999 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14000 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14003 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14004 (LabeledStatement.AddReference): New. Set 'referenced'.
14005 (Goto.Resolve): Use it.
14007 2005-02-05 John Luke <john.luke@gmail.com>
14009 * driver.cs: remove duplicate -doc line in Usage ()
14011 2005-02-04 Raja R Harinath <rharinath@novell.com>
14013 * location.cs (Location.AddFile): Fix CS2002 error report.
14015 2005-02-02 Martin Baulig <martin@ximian.com>
14017 * delegate.cs (Delegate.DefineType): Report an internal error if
14018 TypeManager.multicast_delegate_type is null. See bug #72015 for
14021 2005-02-02 Raja R Harinath <rharinath@novell.com>
14023 Fix a crasher in a variant of #31984.
14024 * const.cs (Constant.CheckBase): New override that defers the
14025 new-or-override check in case the base type hasn't been populated
14027 (Constant.Define): Ensure the new-or-override check is performed.
14029 2005-02-01 Duncan Mak <duncan@ximian.com>
14031 * const.cs (LookupConstantValue): Check that `ce' is not null
14032 before calling GetValue ().
14034 2005-02-01 Raja R Harinath <rharinath@novell.com>
14036 Fix test-334.cs (#69519).
14037 * cs-parser.jay (using_alias_directive): Pass in an expression to
14038 NamespaceEntry.UsingAlias.
14039 (using_namespace_directive): Pass in an expression to
14040 NamespaceEntry.Using.
14041 (namespace_name): Don't flatten to a string.
14042 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14043 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14045 (NamespaceEntry.UsingEntry): Likewise.
14046 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14048 (NamespaceEntry.LookupForUsing): Remove.
14049 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14051 (NamespaceEntry.Lookup): Remove support for dotted names.
14053 2005-02-01 Raja R Harinath <rharinath@novell.com>
14055 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14057 (NamespaceEntry.ImplicitParent): Compute on demand.
14058 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14059 parallels the current.
14060 (NamespaceEntry.LookupForUsing): Use it.
14061 (NamespaceEntry.Lookup): If the current namespace-entry is
14062 implicit, don't search aliases and using tables.
14064 2005-02-01 Raja R Harinath <rharinath@novell.com>
14067 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14069 (TypeContainer.BaseCache): Compute on demand.
14070 (TypeContainer.FindMembers): Define constants and types if they're
14071 not already created.
14072 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14074 * const.cs (Constant.Define): Make idempotent.
14076 2005-01-29 Miguel de Icaza <miguel@novell.com>
14078 * pending.cs: Produce better code (no nops produced by using Ldarg
14081 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14082 i - 1' it should be arg + 1.
14086 2005-01-28 Raja R Harinath <rharinath@novell.com>
14088 * attribute.cs (Attribute.CheckAttributeType): Make private
14090 (Attribute.ResolveType): Make virtual.
14091 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14092 handling of RootContext.Tree.Types.
14094 2005-01-27 Raja R Harinath <rharinath@novell.com>
14096 Update attribute-handling to use the SimpleName/MemberAccess
14098 * cs-parser.jay (attribute): Pass in an expression to the
14099 constructors of Attribute and GlobalAttribute.
14100 * attribute.cs (Attribute): Take an expression for the name.
14101 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14102 passed in attribute name expression.
14103 (Attribute.CheckAttributeType): Use it.
14104 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14105 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14106 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14107 argument to prevent error messages if the lookup fails.
14109 2005-01-27 Marek Safar <marek.safar@seznam.cz>
14111 * expression.cs (Indirection): Implemented IVariable interface
14112 to support indirection in AddressOf operator.
14113 (PointerArithmetic.Emit): Add optimalization for case where
14114 result can be precomputed.
14116 2005-01-26 Martin Baulig <martin@ximian.com>
14118 * class.cs (TypeContainer.AttributeTargets): Return the correct
14119 AttributeTargets depending on our `Kind' instead of throwing an
14120 exception; fixes #71632.
14122 2005-01-26 Marek Safar <marek.safar@seznam.cz>
14125 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
14128 2005-01-25 Raja R Harinath <rharinath@novell.com>
14131 * expression.cs (MemberAccess.DoResolve): Don't complain with
14132 cs0572 when the LHS of a member access has identical name and type
14135 2005-01-25 Marek Safar <marek.safar@seznam.cz>
14138 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
14140 Create custom PermissionSet only for PermissionSetAttribute.
14142 2005-01-24 Marek Safar <marek.safar@seznam.cz>
14145 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
14146 delegates in static class.
14148 2005-01-24 Martin Baulig <martin@ximian.com>
14150 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14151 merging an implicit block, just use its reachability.
14153 * statement.cs (Block.Resolve): Make the unreachable code check
14154 work wrt. implicit blocks; see test-337 from #63842.
14156 2005-01-21 Alp Toker <alp@atoker.com>
14158 * cs-parser.jay: destructor_declaration's container is PartialContainer
14159 not Class when partial types are used, so use Kind prop instead of
14162 2005-01-22 Miguel de Icaza <miguel@ximian.com>
14164 * cs-parser.jay: Improve error reporting when an interface
14165 declares new types.
14167 2005-01-20 Dick Porter <dick@ximian.com>
14169 * support.cs: SeekableStreamReader fix from Sandor Dobos
14170 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
14171 chars are read. Fixes bug 70369.
14173 2005-01-20 Raja R Harinath <rharinath@novell.com>
14175 * cs-parser.jay (catch_clause): Simplify current_block handling
14178 2005-01-17 Miguel de Icaza <miguel@ximian.com>
14180 * convert.cs (ImplicitStandardConversionExists): Synchronize the
14181 code with ImplicitStandardConversion to handle the implicit
14182 conversion of method groups into valid delegate invocations.
14184 The problem is that in parameter handling we were using this code
14185 path. Fixes bug #64698
14187 2005-01-19 Raja R Harinath <rharinath@novell.com>
14189 * cs-parser.jay: Fix several infelicities.
14190 - Avoid assigning to the parser value stack. Code like
14191 '$3 = null' is unclean. Synthesize a value for the code block
14193 - Avoid using oob_stack for storing location information. Use ...
14194 (_mark_): ... this. New (empty) rule. Saves the current location
14196 (foreach_statement): Avoid using oob_stack for current_block
14197 handling. Use technique used in for_statement and
14198 using_statement. Synthesize a value for the code block to store
14199 additional intermediate information.
14201 2005-01-13 Miguel de Icaza <miguel@ximian.com>
14203 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
14204 of a different type is only allowed to private fields of a
14205 containing type, not on fields of a base class.
14207 See test-174.cs and error cs0122-9.cs
14209 2005-01-13 Raja R Harinath <rharinath@novell.com>
14211 Fix test-335.cs (bug #58126).
14212 * cs-parser.jay (argument): Split out non-expression parts of the
14213 rule into 'non_simple_argument'.
14214 (invocation_expression): Support parenthesized invocations with
14215 multiple arguments, and with single non-simple arguments.
14217 2005-01-13 Raja R Harinath <rharinath@novell.com>
14219 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
14222 2005-01-12 Raja R Harinath <rharinath@novell.com>
14224 Fix cs0038-1.cs, cs1640-6.cs.
14225 * ecore.cs (Expression.Resolve): Remove special-case for
14226 SimpleName in error-handling.
14227 (Expression.almostMatchedMembers): Relax access permission to
14229 (Expression.MemberLookupFailed): Handle duplicates in
14230 almostMatchedMembers list.
14231 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
14232 * expression.cs (New.DoResolve): Report CS1540 for more cases.
14233 * typemanager.cs (GetFullNameSignature): Use the MethodBase
14234 overload if the passed in MemberInfo is a MethodBase.
14236 2005-01-12 Marek Safar <marek.safar@seznam.cz>
14239 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
14240 for non-CAS & merge permission sets properly.
14242 2005-01-11 Raja R Harinath <rharinath@novell.com>
14244 Improve standard-compliance of simple name and member access
14245 resolution. Fixes bugs #52697, #57200, #67520, #69519.
14246 * ecore.cs (FullNamedExpression): New abstract base class
14247 for Namespaces and TypeExpressions.
14248 (ResolveFlags.SimpleName): Remove.
14249 (SimpleName): Remove support for dotted names.
14250 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
14251 DeclSpace.FindType and DeclSpace.LookupType.
14252 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
14253 (Expression.ExprClassName): Make member function.
14254 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
14255 a namespace. Remove creation of dotted "SimpleName"s.
14256 (MemberAccess.DoResolve): Likewise.
14257 * decl.cs (DeclSpace.Cache): Make private.
14258 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
14259 (DeclSpace.FindType): Update.
14260 (DeclSpace.LookupType): Move here from RootContext. Return a
14261 FullNamedExpression.
14262 * namespace.cs (Namespace): Derive from FullNamedExpression
14263 so that it can be part of expression resolution.
14264 (Namespace.Lookup): Return an FullNamedExpression.
14265 (NamespaceEntry.LookupAlias): Lookup aliases only in current
14267 * rootcontext.cs (NamespaceLookup): Remove.
14268 (LookupType): Move to DeclSpace.
14269 * attribute.cs (CheckAttributeType): Update.
14270 * doc.cs (FindDocumentedType): Remove allowAlias argument.
14271 (FindDocumentedTypeNonArray): Likewise.
14273 2005-01-11 Raja R Harinath <rharinath@novell.com>
14275 Fix cs0509.cs, cs1632.cs.
14276 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
14277 is the same as IsInterface.
14278 (TypeContainer.GetClassBases): Likewise.
14279 * statement.cs (LabeledStatement.ig): New field.
14280 (LabeledStatement.LabelTarget): Save ILGenerator which created the
14282 (LabeledStatement.DoEmit): Check that the label was created with
14283 the same ILGenerator.
14285 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14288 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
14289 accessors to its properties.
14291 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
14292 from accessors to property.
14294 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14297 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
14298 only for overrides.
14300 2005-01-08 Miguel de Icaza <miguel@ximian.com>
14302 * attribute.cs: Check for null and empty strings.
14304 I have lost another battle to Paolo.
14306 2005-01-07 Marek Safar <marek.safar@seznam.cz>
14309 * class.cs (PropertyMethod): Set Parent field in ctors.
14310 (SetMethod.InternalParameters): Add unsafe switch hack.
14311 Override MarkForDuplicationCheck where it is appropriate.
14313 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
14314 It says whether container allows members with the same name.
14315 Base default is no.
14316 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
14317 Removed is_method parameter.
14319 2005-01-06 Duncan Mak <duncan@ximian.com>
14321 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
14322 because the previous change led to incorrect reporting of CS1032
14323 ("Cannot define/undefine preprocessor symbols after first token in
14324 file"). Instead of using `tokens_seen' as the only flag that
14325 triggers CS1040, introduce `comments_seen'. This new flag is used
14326 to signify having seen comments on the current line, so it is
14327 unset after a newline.
14329 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14331 * doc.cs : When searching for a type, find nested type too.
14332 This fixes bug #71040.
14334 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14337 - Warn missing member comment on those classes which also does not
14338 have doc comments. Fixed bug #71041.
14339 - Don't warn missing doc comment on default constructor.
14342 2005-01-06 Duncan Mak <duncan@ximian.com>
14344 * cs-tokenizer.cs (xtoken): After handling traditional C-style
14345 comments, set `tokens_seen' to true. This allows us to detect
14346 misplaced preprocessor directives (i.e. not at the beginning of
14347 the a line, nor after whitespaces). In that case, report error
14348 CS1040. This fixes bug #56460.
14350 * cs-parser.jay (interface_member_declaration): Add checks for
14351 IsExplicitImpl, and report CS0541 error if an interface member is
14352 defined as an explicit interface declaration.
14354 2005-01-06 Marek Safar <marek.safar@seznam.cz>
14357 * class.cs (PropertyMethod): Set Parent field in ctors.
14358 (SetMethod.InternalParameters): Add unsafe switch hack.
14360 * decl.cs (MemberCore.Parent): Cannot be readonly.
14362 2005-01-06 Raja R Harinath <rharinath@novell.com>
14364 * decl.cs (DeclSpace.ResolveType): Remove.
14365 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
14366 Merge in code from ...
14367 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
14368 * class.cs, enum.cs: Update to changes.
14370 2005-01-06 Miguel de Icaza <miguel@ximian.com>
14372 * anonymous.cs: Ensure that we init the scope of our parent if it
14373 has not been initialized yet.
14375 2004-12-30 Duncan Mak <duncan@ximian.com>
14377 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
14378 if field.FieldBuilder is null. Fixes #70758.
14380 * convert.cs: Fixed some typos and updated some of the comments.
14381 (ImplicitStandardConversionExists):
14382 (TryImplicitIntConversion): If `target_type' is an interface and
14383 the type of `ic' implements this interface, return true or a new
14384 BoxedCast instead of null. This fixes #70468.
14386 2004-12-29 Duncan Mak <duncan@ximian.com>
14388 * expression.cs (Argument.Emit): Check that Expr is
14389 IMemoryLocation before casting to it, and report CS1510 otherwise.
14393 2004-12-21 Ben Maurer <bmaurer@ximian.com>
14395 * statement.cs (Block.ThisVariable): remove the recursion here, to
14396 make the --profile more sane.
14398 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
14400 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
14401 assembly, by JB Evain.
14403 2004-12-17 Raja R Harinath <rharinath@novell.com>
14405 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
14406 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
14407 "parent" refers to enclosing type/class. "base" refers to superclass.
14409 2004-12-17 Raja R Harinath <rharinath@novell.com>
14411 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14412 Ensure that we only have GlobalAttributes.
14413 * attribute.cs (Attribute.Emit): Make non-virtual.
14414 (GlobalAttribute.Emit): Remove.
14415 (Attribute.Resolve): Make virtual.
14416 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
14417 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
14418 the argument. Don't create one.
14419 (Attribute.GetObsoleteAttribute): Likewise.
14420 (Attribute.GetClsCompliantAttributeValue): Likewise.
14421 * class.cs, decl.cs: Update to changes.
14423 2004-12-17 Marek Safar <marek.safar@seznam.cz>
14425 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
14427 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
14429 * statement.cs (Foreach.Resolve): Add error 186 report.
14431 2004-12-16 Marek Safar <marek.safar@seznam.cz>
14433 * expression.cs (Conditional.DoResolve): Add warning 429.
14435 * statement.cs (If.Resolve): Add warning 665.
14437 2004-12-16 Raja R Harinath <rharinath@novell.com>
14439 New invariant: RootContext.Tree.Types.NamespaceEntry == null
14440 except when in the parser, and in GlobalAttribute.
14441 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
14442 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
14443 RootContext.Tree.Types.NamespaceEntry once work is done.
14444 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
14445 and resets RootContext.Tree.Types.NamespaceEntry.
14447 2004-12-15 Marek Safar <marek.safar@seznam.cz>
14449 * cs-parser.jay: Don't create a block for every variable.
14451 2004-12-14 Miguel de Icaza <miguel@ximian.com>
14453 * location.cs: Provide extra information.
14455 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
14456 variables from the captured environment, it is the ldarg_0.
14458 2004-12-14 Marek Safar <marek.safar@seznam.cz>
14460 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
14463 * class.cs: Changed warning level for 169 to avoid developer
14464 displeasure from warning flooding. It will be changed back when they
14465 fix most of current BCL warnings.
14467 * RootContext.cs: Pushed default WarningLevel to 3.
14469 * statement.cs: Removed unused variable.
14471 2004-12-14 Marek Safar <marek.safar@seznam.cz>
14473 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
14474 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
14475 Add error 502 report.
14476 (StaticClass.DefineType): Add error 441 report.
14477 (Class.AllowedModifiersProp): New virtual property as temporary
14478 extension to AllowedModifiers.
14479 (Class.DefineType): Add error 418 report. Moved ModFlags check here
14480 to share implementation with StaticClass and don't call virtual
14483 * driver.cs (MainDriver): Add error 1558 test.
14485 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
14486 report. Moved error 36 test here.
14488 * statement.cs (Throw.Resolve): Add error 724 report.
14490 * typemanager.cs: Add out_attribute_type core type.
14492 2004-12-13 Marek Safar <marek.safar@seznam.cz>
14494 * class.cs (TypeContainer.VerifyClsCompliance): Add error
14496 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
14498 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
14501 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
14503 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
14504 Add error 3023 report.
14505 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
14507 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
14510 2004-12-12 John Luke <john.luke@gmail.com>
14512 * driver.cs (AddArgs): take -- into account when
14513 adding arguments, fixes bug 65710
14515 2004-12-12 Martin Baulig <martin@ximian.com>
14517 * expression.cs (Unary.TryReduceNegative): Added support for
14518 SByteConstant and ByteConstant.
14519 (Unary.Reduce): Check error values from TryReduceNegative().
14521 2004-12-10 Marek Safar <marek.safar@seznam.cz>
14523 * attributes.cs (Attribute.Resolve): Avoid multiple error report
14524 and report exception as error 182.
14526 2004-12-10 Raja R Harinath <rharinath@novell.com>
14528 * driver.cs (Main): Fix message when there are warnings.
14530 2004-12-09 Miguel de Icaza <miguel@ximian.com>
14532 * delegate.cs: Fixed my fix from yesterday, sorry about that.
14534 2004-12-09 Marek Safar <marek.safar@seznam.cz>
14536 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
14537 Reduced number of warnings.
14539 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
14541 2004-12-08 Miguel de Icaza <miguel@ximian.com>
14543 * driver.cs: Removed message.
14545 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
14547 2004-12-08 <vargaz@freemail.hu>
14549 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
14551 2004-12-08 Martin Baulig <martin@ximian.com>
14553 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
14554 instead of a CS3002 for properties and indexer.
14556 2004-12-08 Martin Baulig <martin@ximian.com>
14558 * decl.cs (MemberName.ToString): Make this work again.
14560 2004-12-08 Marek Safar <marek.safar@seznam.cz>
14562 * attribute.cs (Resolve): Add error 591 detection.
14564 * class.cs (FieldMember.Define): Add error 1547 detection.
14565 (Indexer.Define): Add error 620 detection.
14566 (Operator.Define): Add error 590 detection.
14568 * ecore.cs: Missing argument for error 79.
14570 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
14573 2004-12-07 Marek Safar <marek.safar@seznam.cz>
14576 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
14579 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
14581 * cs-parser.jay : handle doc comments on implicit/explicit operators.
14582 Some operator comments were suppressed.
14583 * doc.cs : Implicit/explicit operator name in doc comments are like
14584 "op_Explicit(type)~returnType", so added suffix handling.
14586 2004-12-07 Martin Baulig <martin@ximian.com>
14589 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
14590 (MemberCore.GetClsCompliantAttributeValue): Likewise.
14591 (DeclSpace.ec): New protected field; store the EmitContext here.
14592 (DeclSpace.EmitContext): New public property; moved here from
14594 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
14597 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
14598 (Enum.Emit): Don't create a new EmitContext.
14600 * delegate.cs (Delegate.DefineType): Always create the
14603 * iterators.cs (Iterators.DefineIterator): Create a new
14604 EmitContext and store it in `ec'.
14606 2004-08-24 Martin Baulig <martin@ximian.com>
14609 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
14610 this for accessibility checks.
14611 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
14612 IsNestedFamilyAccessible.
14613 (TypeManager.IsSubclassOf): New method, do what the name actually
14616 2004-12-06 Raja R Harinath <rharinath@novell.com>
14618 Fix crash on cs0657-17.cs.
14619 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14620 Use RootContext.Tree.Types, not 'new RootTypes ()'.
14621 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
14622 the case where the NamespaceEntry gets overwritten.
14624 2004-12-06 Marek Safar <marek.safar@seznam.cz>
14626 Fixed #69195, #56821
14627 * ecore.cs (ResolveBoolean): Tiny refactoring.
14629 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
14630 of right expression resolving when left is false constant and
14631 operator is LogicalAnd OR true constant and operator is LogicalOr.
14633 * statement.cs (ResolveUnreachable): Always reports warning.
14635 2004-12-05 Miguel de Icaza <miguel@ximian.com>
14637 * class.cs: Distinguish between 1721 and 1722 (just a little help
14638 for the programmer).
14640 2004-12-03 Miguel de Icaza <miguel@ximian.com>
14642 * delegate.cs: Only allow this on new versions of the language.
14644 2004-12-02 Duncan Mak <duncan@ximian.com>
14646 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
14648 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
14649 here as a static method. Take an additional bool out parameter
14650 `must_do_cs1540_check' for signaling to InstanceResolve.
14651 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
14652 member field from PropertyExpr class and made it an argument of
14653 the method instead.
14654 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
14655 check for MarshalByRefObject, and report CS0122 instead of CS1540.
14656 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
14657 and `remove_accessor' as well as InstanceResolve: report CS0122
14662 2004-12-03 Raja R Harinath <rharinath@novell.com>
14664 Fix test-327.cs, test-328.cs, and put in early infrastructure
14665 for eventually fixing #52697.
14666 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
14667 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
14668 from other methods.
14669 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
14670 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
14671 (VerifyUsing, error246): Update.
14672 * rootcontext.cs (RootContext.NamespaceLookup): Just use
14673 'NamespaceEntry.LookupNamespaceOrType'.
14675 2004-12-03 Martin Baulig <martin@ximian.com>
14677 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
14678 method as our child, call AnonymousMethod.Compatible() on it.
14680 2004-12-03 Raja R Harinath <rharinath@novell.com>
14682 Disable XML documentation support in 'basic' profile.
14683 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
14684 Redirect XmlElement to System.Object.
14685 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
14686 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
14687 * mcs.exe.sources: Add doc-bootstrap.cs.
14688 * doc-bootstrap.cs: New file. Contains empty stub implementation
14691 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
14693 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
14694 comments are allowed.
14696 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
14698 * delegate.cs: Add checks for subtypes in paramaters and return values
14699 in VerifyMethod () to add support for Covariance/Contravariance
14702 2004-12-02 Miguel de Icaza <miguel@ximian.com>
14704 * report.cs: Remove extra closing parenthesis.
14706 * convert.cs (Error_CannotImplicitConversion): If the name of the
14707 types are the same, provide some extra information.
14709 * class.cs (FieldBase): Use an unused bit field from the field to
14710 encode the `has_offset' property from the FieldMember. This saves
14711 a couple of Ks on bootstrap compilation.
14713 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
14714 method as our child, return the AnonymousMethod resolved
14717 * expression.cs (New.DoResolve): Allow return values from
14718 NewDelegate to also include AnonymousMethods.
14722 2004-12-02 Marek Safar <marek.safar@seznam.cz>
14725 * attribute.cs (Resolve): Improved implementation of params
14726 attribute arguments.
14728 * support.cs (ParameterData): Add HasParams to be faster.
14730 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
14732 all things are for /doc support:
14734 * doc.cs: new file that supports XML documentation generation.
14735 * mcs.exe.sources: added doc.cs.
14737 Handle /doc command line option.
14738 Report error 2006 instead of 5 for missing file name for /doc.
14739 Generate XML documentation when required, after type resolution.
14741 Added support for picking up documentation (/// and /** ... */),
14742 including a new XmlCommentState enumeration.
14744 Added lines to fill Documentation element for field, constant,
14745 property, indexer, method, constructor, destructor, operator, event
14746 and class, struct, interface, delegate, enum.
14747 Added lines to warn incorrect comment.
14749 Added Documentation field (passed only when /doc was specified).
14751 Added DocComment, DocCommentHeader, GenerateDocComment() and
14752 OnGenerateDocComment() and some supporting private members for
14753 /doc feature to MemberCore.
14755 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
14757 Added overriden DocCommentHeader.
14759 Added overriden DocCommentHeader and GenerateDocComment().
14761 2004-12-01 Miguel de Icaza <miguel@ximian.com>
14763 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
14764 unwrapping the enumeration values, chain to
14765 DoConstantNumericPromotions again, so we can promote things to the
14766 fundamental types (takes care of enums that are bytes, sbytes).
14770 2004-12-01 Raja R Harinath <rharinath@novell.com>
14772 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
14773 Fix long-standing bug in type-lookup. Use FindType instead of
14774 LookupType when ec.ResolvingTypeTree.
14775 (Attribute.ResolveType, Attribute.Resolve)
14776 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
14778 (Attributes.Search): Remove internal version. Update.
14779 (Attributes.SearchMulti): Update.
14780 (Attributes.GetClsCompliantAttribute): Remove.
14781 (Attributes.GetIndexerNameAttribute): Remove.
14782 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
14783 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
14784 * class.cs (Indexer.Define): Likewise.
14786 2004-12-01 Marek Safar <marek.safar@seznam.cz>
14789 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
14790 MarshallByReference members access.
14792 * expression.cs: Use CheckMarshallByRefAccess;
14793 Better error CS0197 message.
14795 * report.cs: Print whole related error message.
14797 2004-11-30 Raja R Harinath <rharinath@novell.com>
14799 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
14800 the current directory to help debugging.
14802 2004-11-29 Marek Safar <marek.safar@seznam.cz>
14804 * class (GetClassBases): Better error 60 report.
14805 (EventProperty): Disabled warning 67 detection.
14807 2004-11-29 Marek Safar <marek.safar@seznam.cz>
14810 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
14812 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
14815 2004-11-29 Marek Safar <marek.safar@seznam.cz>
14818 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
14820 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
14822 2004-11-26 Miguel de Icaza <miguel@ximian.com>
14824 * attribute.cs (Attribute.Resolve): Refine error reporting and
14825 report a cs0117 if the identifier does not exist, to distinguish
14826 from 0617 which is a miss-use of the actual identifier.
14828 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
14829 between cs0070 and cs0079.
14831 * class.cs (MemberBase.DoDefine): When reporting a wrong
14832 accessibility level, we use MethodCore to compare instead of
14833 Method (this was a regression in some refactoring effort).
14835 So now we correctly report cs0056 again.
14837 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
14838 testing the target_type (which was known to be object_type) and
14839 not the source type (which is anonymous_method).
14841 Fixed reporting of error cs1660.
14843 * expression.cs (UserCast.Source): Expose the underlying cast.
14845 * statement.cs (Switch.SwitchGoverningType): Sort the list of
14846 allowed types to find a match to int32 first (most common).
14848 In addition, it ignores any ImplicitUserConversions that did an
14849 internal implicit conversion (as the switch statement allows only
14850 one integral conversion to exist).
14852 * class.cs (PartialContainer.Create): rename `name' to
14853 `member_name' for clarity. Then replace the string calls with a
14854 call to MemberName.GetPartialName, as now using
14855 MemberName.ToString is an error (this is due to the side effects
14856 it had, that were fixed in the past).
14858 This will restore the error reporting on a number of partial class
14859 errors that were missusing this (and getting an exception as a
14860 results, which is now just a plain textual warning, because
14861 yyparse debug output would crash otherwise).
14863 2004-11-26 Raja R Harinath <rharinath@novell.com>
14865 * Makefile (PROGRAM_INSTALL_DIR): Remove.
14867 2004-11-25 Ben Maurer <bmaurer@ximian.com>
14869 * rootcontext.cs (LookupType): Make sure to cache lookups that
14870 don't give us a negative result. This saves about 5% of corlib
14873 2004-11-25 Miguel de Icaza <miguel@ximian.com>
14875 * report.cs (AbstractMessage.Print): messages are sent to stderr
14877 * class.cs (TypeContainer.GetClassBases): It is an error to have a
14878 non-interface in the list of interfaces (at this point, either
14879 parent was properly set, or a base class is being listed in the
14880 interfaces section).
14882 This flags error 1722, and resolves the crash from bug 69259.
14884 2004-11-25 Ben Maurer <bmaurer@ximian.com>
14886 * statement.cs (Using.EmitExpressionFinally): make this work right
14887 for valuetypes. Fixes 69926.
14889 2004-11-25 Miguel de Icaza <miguel@ximian.com>
14891 * const.cs (Const.ChangeType): Cope with the "0 literal can be
14892 converted to an enum" here, before we try to change the underlying
14893 type. This code exists, but it is a different code path than the
14894 one used while encoding constants.
14896 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
14897 old bug: when converting from the null literal to a pointer,
14898 return an EmptyCast, not the NullLiteral.
14900 This fixes #69921, the recent null_type changes probably made this
14901 bug more prominent.
14903 (ImplicitReferenceConversionExists): In addition, resynchronized
14904 the code here, so it matches the same code in
14905 ImplicitReferenceConversionExists for the `from any class-type S
14906 to any interface-type T'.
14909 2004-11-25 Marek Safar <marek.safar@seznam.cz>
14911 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
14913 2004-11-24 Miguel de Icaza <miguel@ximian.com>
14915 * cs-parser.jay: Use verbosity accordingly.
14917 2004-11-24 Marek Safar <marek.safar@seznam.cz>
14919 * expression.cs (Unary.ResolveOperator): Do not report warning;
14920 AddressOf reads from variable.
14922 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
14924 2004-11-24 Marek Safar <marek.safar@seznam.cz>
14928 * attribute.cs (Attributable): Removed CheckTargets.
14929 (Attributes.Emit): Explicit attribute targets are tested here.
14931 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
14932 not enabled for interfaces.
14934 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
14935 (GetAssemblyName): Ouch next bug there.
14937 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
14939 * expression.cs: Error 275 added.
14941 2004-11-23 Marek Safar <marek.safar@seznam.cz>
14943 Fix bug #69177 (Implemented decimal constant support)
14945 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
14946 (BinaryFold): Add DecimalConstant.
14948 * const.cs (Define): Decimal constant
14950 (ChangeType): Add decimal type handling.
14951 (LookupConstantValue): Don't set value for decimal type but
14952 emit DecimalConstantAttribute. Needed for constant optimization.
14954 * constant.cs (ToDecimal): New method.
14955 (ConvertToDecimal): New method.
14956 (IntConstant): Implemented ConvertToDecimal.
14957 (DecimalConstant.Emit): Emit optimized version for decimals in
14960 * expression.cs (ResolveOperator): Changed order of constant
14961 reduction to work correctly with native types which have
14962 overloaded operators.
14963 (ResolveMemberAccess): Extract constant value from attribute
14966 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
14968 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
14969 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
14970 (ChangeType): Decimal is special.
14971 (TypeToCoreType): Add decimal type.
14973 2004-11-22 Marek Safar <marek.safar@seznam.cz>
14975 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
14978 2004-11-22 Marek Safar <marek.safar@seznam.cz>
14980 * class.cs (EventField.ApplyAttributeBuilder): Fix error
14983 2004-11-19 Marek Safar <marek.safar@seznam.cz>
14985 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
14987 * pending.cs (PendingImplementation): Grab only interfaces.
14989 2004-11-19 Marek Safar <marek.safar@seznam.cz>
14991 * statement.cs (ForeachHelperMethods): Add location member and
14992 error 202 detection.
14994 2004-11-19 Raja R Harinath <rharinath@novell.com>
14996 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
14997 automatically handled by executable.make.
14998 (PROGRAM): Make profile-specific.
15000 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15002 * expression.cs (DoResolveBase): Fixed wrong warning for out
15005 2004-11-18 Martin Baulig <martin@ximian.com>
15007 Merged latest changes into gmcs. Please keep this comment in
15008 here, it makes it easier for me to see what changed in MCS since
15009 the last time I merged.
15011 2004-11-17 Raja R Harinath <rharinath@novell.com>
15013 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15014 (TypeHandle.GetMemberCache): New.
15015 (TypeHandle.TypeHandle): Update.
15016 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15017 (TypeManager.LookupParentInterfacesCache):
15018 Rename from LookupInterfaceCache. Optimize slightly.
15019 (TypeManager.MemberLookup_FindMembers): Update.
15020 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15021 multi-type variant.
15022 (AddCacheContents): Rename from AddHashtable.
15023 * class.cs (TypeContainer.parent_container): Remove.
15024 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15025 (TypeContainer.DoDefineMembers): Don't initialize it.
15026 Update to name changes.
15028 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15030 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15031 that factors the code to check access modifiers on override.
15033 (PropertyBase): Use the code here.
15035 Patch from Lluis S'anchez, fixes bug #69361.
15037 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15039 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15040 routine that is used to report the use of a captured variable
15041 whose address has been taken.
15043 There are two checks: one when variables are being captured and
15044 the other check is when the address of a variable is taken.
15046 (because an anonymous methods might be resolved before *or* after
15047 the address has been taken) and
15049 * expression.cs (Conditional.DoResolve): Remove the special
15050 casing that Martin added to trueExpr and falseExpr being both
15051 NullLiteral. We get the right behavior now just by introducing
15052 the null_type into the compiler.
15054 * convert.cs (ExplicitConversion): Change the code to use
15055 null_type instead of testing `expr is NullLiteral'.
15056 (ImplicitConversionStandard): use null_type too.
15057 (ImplicitReferenceConversionExists): use null_type too.
15058 (ImplicitReferenceConversion): use null_type too.
15060 * literal.cs: The type of `NullLiteral' is now null_type instead
15062 (Resolve): Set the type here.
15064 * typemanager.cs: Introduce null_type.
15066 2004-11-17 Martin Baulig <martin@ximian.com>
15068 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15069 direction, like FindMembers() does. Fixes #69546, testcase is in
15072 2004-11-16 Martin Baulig <martin@ximian.com>
15074 This is based on a patch from Marek Safar, see bug #69082.
15075 Fixes bugs #63705 and #67130.
15077 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15078 method; create a MemberCache for an interface type and cache the
15081 * decl.cs (IMemberContainer.ParentContainer): Removed.
15082 (IMemberContainer.ParentCache): New property.
15083 (MemberCache.SetupCacheForInterface): Removed.
15084 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15085 to create a cache for an interface's "parent".
15087 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15090 2004-11-16 Martin Baulig <martin@ximian.com>
15092 Merged back from gmcs; these changes already went into gmcs a
15093 couple of weeks ago.
15096 (TypeManager.AddUserType): Removed the `ifaces' argument.
15097 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15099 (TypeManager.AddUserInterface): Removed.
15100 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15102 (TypeManager.GetInterfaces): Likewise.
15103 (TypeManager.GetExplicitInterfaces): Likewise.
15105 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15107 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15108 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
15110 2004-11-14 Ben Maurer <bmaurer@ximian.com>
15112 * statement.cs: Avoid adding bools to a hashtable.
15114 2004-11-07 Miguel de Icaza <miguel@ximian.com>
15116 * expression.cs (Invocation.OverloadResolve): Flag error if we are
15117 calling an unsafe method from a safe location.
15119 2004-11-06 Marek Safar <marek.safar@seznam.cz>
15122 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
15124 2004-11-06 Miguel de Icaza <miguel@ximian.com>
15126 * namespace.cs (VerifyUsing): use GetPartialName instead of
15129 2004-11-05 Miguel de Icaza <miguel@ximian.com>
15131 * statement.cs (Return.Resolve): Fix regression in typo: if
15132 `in_exc', we have to request a NeedReturnLabel, this was a typo
15133 introduced in the anonymous method check-in. Fixes #69131.
15135 * Indexers were using the ShortName when defining themselves,
15136 causing a regression in the compiler bootstrap when applying the
15137 patch from 2004-11-02 (first part), now they use their full name
15138 and the bug is gone.
15140 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
15142 * driver.cs: Strip the path from the names of embedded resources. Fixes
15145 2004-11-04 Raja R Harinath <rharinath@novell.com>
15147 Fix error message regression: cs0104-2.cs.
15148 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
15149 (AliasEntry.Resolve): Update.
15150 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
15152 (RootContext.LookupType): Update.
15154 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
15156 * cs-parser.jay: Add support for handling accessor modifiers
15157 * class: Add support port accessor modifiers and error checking,
15158 define PropertyMethod.Define as virtual (not abstract anymore)
15159 * ecore.cs: Add checking for proeprties access with access modifiers
15160 * iterators.cs: Modify Accessor constructor call based in the modified
15162 2004-11-02 Ben Maurer <bmaurer@ximian.com>
15164 * expression.cs (StringConcat): Handle being called twice,
15165 as when we have a concat in a field init with more than two
15168 2004-11-02 Miguel de Icaza <miguel@ximian.com>
15170 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
15171 special case explicit implementations, we should always produce
15172 the .property or .event declaration.
15174 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
15175 since it will not return correct data if people use this
15176 unresolved in the presence of using statements (see test-313).
15178 * class.cs (MethodData.Define): If we are an explicit interface
15179 implementation, set the method name to the full name of the
15180 interface plus the name of the method.
15182 Notice that using the method.MethodName.GetFullName() does not
15183 work, as it will only contain the name as declared on the source
15184 file (it can be a shorthand in the presence of using statements)
15185 and not the fully qualifed type name, for example:
15189 class D : ICloneable {
15190 object ICloneable.Clone () {
15194 Would produce a method called `ICloneable.Clone' instead of
15195 `System.ICloneable.Clone'.
15197 * namespace.cs (Alias.Resolve): Use GetPartialName.
15199 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15201 * cs-parser.jay: Add error 1055 report.
15203 2004-11-01 Miguel de Icaza <miguel@ximian.com>
15205 * assign.cs (Assign.DoResolve): Only do the transform of
15206 assignment into a New if the types are compatible, if not, fall
15207 through and let the implicit code deal with the errors and with
15208 the necessary conversions.
15210 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15212 * cs-parser.jay: Add error 1031 report.
15214 * cs-tokenizer.cs: Add location for error 1038.
15216 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15218 * cs-parser.jay: Add error 1016 report.
15220 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15222 * cs-parser.jay: Add errors 1575,1611 report.
15224 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15226 * cs-parser.jay: Add error 1001 report.
15228 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15231 * attribute.cs (GetMarshal): Add method argument for
15232 caller identification.
15234 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
15235 agument for GetMarshal and RuntimeMissingSupport.
15237 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15239 * attribute.cs (ExtractSecurityPermissionSet): Removed
15240 TypeManager.code_access_permission_type.
15242 * typemanager.cs: Removed TypeManager.code_access_permission_type.
15244 2004-10-27 Miguel de Icaza <miguel@ximian.com>
15246 * expression.cs (LocalVariableReference.DoResolveLValue): Check
15247 for obsolete use of a variable here. Fixes regression on errors
15248 cs0619-25 and cs0619-26.
15250 2004-10-27 Marek Safar <marek.safar@seznam.cz>
15252 Fix #62358, implemented security attribute encoding.
15254 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
15255 Tests permitted SecurityAction for assembly or other types.
15256 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
15257 data from SecurityPermissionAttribute to PermisionSet class.
15259 * class.cs (ApplyAttributeBuilder): Added special handling
15260 for System.Security.Permissions.SecurityAttribute based types.
15262 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
15263 special handling for System.Security.Permissions.SecurityAttribute
15266 * enum.cs (ApplyAttributeBuilder): Added special handling
15267 for System.Security.Permissions.SecurityAttribute based types.
15269 * parameter.cs (ApplyAttributeBuilder): Added special handling
15270 for System.Security.Permissions.SecurityAttribute based types.
15272 * rootcontext.cs: Next 2 core types.
15274 * typemanager.cs (TypeManager.security_permission_attr_type):
15275 Built in type for the SecurityPermission Attribute.
15276 (code_access_permission_type): Build in type.
15278 2004-10-17 Miguel de Icaza <miguel@ximian.com>
15280 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
15281 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
15282 all of this information into
15283 EmitContext.EmitCapturedVariableInstance.
15285 * codegen.cs (EmitCapturedVariableInstance): move here the
15286 funcionality of emitting an ldarg.0 in the presence of a
15287 remapping. This centralizes the instance emit code.
15289 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
15290 then emit a load of this: it means that we have reached the
15291 topmost ScopeInfo: the one that contains the pointer to the
15292 instance of the class hosting the anonymous method.
15294 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
15295 captures to the topmost CaptureContext.
15297 2004-10-12 Miguel de Icaza <miguel@ximian.com>
15299 * expression.cs (LocalVariableReference): Move the knowledge about
15300 the iterators into codegen's EmitCapturedVariableInstance.
15302 2004-10-11 Miguel de Icaza <miguel@ximian.com>
15304 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
15305 all code paths return a value from an anonymous method (it is the
15306 same as the 161 error, but for anonymous methods).
15308 2004-10-08 Miguel de Icaza <miguel@ximian.com>
15310 The introduction of anonymous methods in the compiler changed
15311 various ways of doing things in the compiler. The most
15312 significant one is the hard split between the resolution phase
15313 and the emission phases of the compiler.
15315 For instance, routines that referenced local variables no
15316 longer can safely create temporary variables during the
15317 resolution phase: they must do so from the emission phase,
15318 since the variable might have been "captured", hence access to
15319 it can not be done with the local-variable operations from the runtime.
15323 (Block.Flags): New flag `IsTopLevel' to indicate that this block
15324 is a toplevel block.
15326 (ToplevelBlock): A new kind of Block, these are the blocks that
15327 are created by the parser for all toplevel method bodies. These
15328 include methods, accessors and anonymous methods.
15330 These contain some extra information not found in regular blocks:
15331 A pointer to an optional CaptureContext (for tracking captured
15332 local variables and parameters). A pointer to the parent
15335 (Return.Resolve): Catch missmatches when returning a value from an
15336 anonymous method (error 1662).
15337 Invoke NeedReturnLabel from the Resolve phase instead of the emit
15340 (Break.Resolve): ditto.
15342 (SwitchLabel): instead of defining the labels during the
15343 resolution phase, we now turned the public ILLabel and ILLabelCode
15344 labels into methods called GetILLabelCode() and GetILLabel() that
15345 only define the label during the Emit phase.
15347 (GotoCase): Track the SwitchLabel instead of the computed label
15348 (its contained therein). Emit the code by using
15349 SwitchLabel.GetILLabelCode ().
15351 (LocalInfo.Flags.Captured): A new flag has been introduce to track
15352 whether the Local has been captured or not.
15354 (LocalInfo.IsCaptured): New property, used to tell whether the
15355 local has been captured.
15357 * anonymous.cs: Vastly updated to contain the anonymous method
15360 The main classes here are: CaptureContext which tracks any
15361 captured information for a toplevel block and ScopeInfo used to
15362 track the activation frames for various local variables.
15364 Each toplevel block has an optional capture context associated
15365 with it. When a method contains an anonymous method both the
15366 toplevel method and the anonymous method will create a capture
15367 context. When variables or parameters are captured, they are
15368 recorded on the CaptureContext that owns them, for example:
15372 MyDelegate d = delegate {
15377 Here `a' will be recorded as captured on the toplevel
15378 CapturedContext, the inner captured context will not have anything
15379 (it will only have data if local variables or parameters from it
15380 are captured in a nested anonymous method.
15382 The ScopeInfo is used to track the activation frames for local
15383 variables, for example:
15385 for (int i = 0; i < 10; i++)
15386 for (int j = 0; j < 10; j++){
15387 MyDelegate d = delegate {
15392 At runtime this captures a single captured variable `i', but it
15393 captures 10 different versions of the variable `j'. The variable
15394 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
15395 recorded on a child.
15397 The toplevel ScopeInfo will also track information like the `this'
15398 pointer if instance variables were referenced (this is necessary
15399 as the anonymous method lives inside a nested class in the host
15400 type of the method).
15402 (AnonymousMethod): Expanded to track the Toplevel, implement
15403 `AnonymousMethod.Compatible' to tell whether an anonymous method
15404 can be converted to a target delegate type.
15406 The routine now also produces the anonymous method content
15408 (AnonymousDelegate): A helper class that derives from
15409 DelegateCreation, this is used to generate the code necessary to
15410 produce the delegate for the anonymous method that was created.
15412 * assign.cs: API adjustments for new changes in
15413 Convert.ImplicitStandardConversionExists.
15415 * class.cs: Adjustments to cope with the fact that now toplevel
15416 blocks are of type `ToplevelBlock'.
15418 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
15419 insteda of standard blocks.
15421 Flag errors if params arguments are passed to anonymous methods.
15423 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
15424 `CurrentAnonymousMethod' which points to the current Anonymous
15425 Method. The variable points to the AnonymousMethod class that
15426 holds the code being compiled. It is set in the new EmitContext
15427 created for the anonymous method.
15429 (EmitContext.Phase): Introduce a variable and an enumeration to
15430 assist in enforcing some rules about when and where we are allowed
15431 to invoke certain methods (EmitContext.NeedsReturnLabel is the
15432 only one that enfonces this right now).
15434 (EmitContext.HaveCaptureInfo): new helper method that returns
15435 whether we have a CapturedContext initialized.
15437 (EmitContext.CaptureVariable): New method used to register that a
15438 LocalInfo must be flagged for capturing.
15440 (EmitContext.CapturedParameter): New method used to register that a
15441 parameters must be flagged for capturing.
15443 (EmitContext.CapturedField): New method used to register that a
15444 field must be flagged for capturing.
15446 (EmitContext.HaveCapturedVariables,
15447 EmitContext.HaveCapturedFields): Return whether there are captured
15448 variables or fields.
15450 (EmitContext.EmitMethodHostInstance): This is used to emit the
15451 instance for the anonymous method. The instance might be null
15452 (static methods), this (for anonymous methods that capture nothing
15453 and happen to live side-by-side with the current method body) or a
15454 more complicated expression if the method has a CaptureContext.
15456 (EmitContext.EmitTopBlock): Routine that drives the emission of
15457 code: it will first resolve the top block, then emit any metadata
15458 and then emit the code. The split is done so that we can extract
15459 any anonymous methods and flag any captured variables/parameters.
15461 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
15462 during this phase, the ILGenerator should not be used as labels
15463 and local variables declared here might not be accessible to any
15464 code that is part of an anonymous method.
15466 Exceptions to this include the temporary variables that are
15467 created by some statements internally for holding temporary
15470 (EmitContext.EmitMeta): New routine, in charge of emitting all the
15473 (EmitContext.TemporaryReturn): This method is typically called
15474 from the Emit phase, and its the only place where we allow the
15475 ReturnLabel to be defined other than the EmitMeta. The reason is
15476 that otherwise we would have to duplicate a lot of logic in the
15477 Resolve phases of various methods that today is on the Emit
15480 (EmitContext.NeedReturnLabel): This no longer creates the label,
15481 as the ILGenerator is not valid during the resolve phase.
15483 (EmitContext.EmitThis): Extended the knowledge in this class to
15484 work in anonymous methods in addition to iterators.
15486 (EmitContext.EmitCapturedVariableInstance): This emits whatever
15487 code is necessary on the stack to access the instance to a local
15488 variable (the variable will be accessed as a field).
15490 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
15491 EmitContext.EmitAddressOfParameter): Routines to support
15492 parameters (not completed at this point).
15494 Removals: Removed RemapLocal and RemapLocalLValue. We probably
15495 will also remove the parameters.
15497 * convert.cs (Convert): Define a `ConstantEC' which points to a
15498 null. This is just to prefity some code that uses
15499 ImplicitStandardConversion code and do not have an EmitContext
15502 The idea is to flag explicitly that at that point in time, it is
15503 known that the conversion will not trigger the delegate checking
15504 code in implicit conversions (which requires a valid
15507 Everywhere: pass new EmitContext parameter since
15508 ImplicitStandardConversionExists now requires it to check for
15509 anonymous method conversions.
15511 (Convert.ImplicitStandardConversionExists): If the type of an
15512 expression is the anonymous_method_type, and the type is a
15513 delegate, we invoke the AnonymousMethod.Compatible method to check
15514 whether an implicit conversion is possible.
15516 (Convert.ImplicitConversionStandard): Only do implicit method
15517 group conversions if the language level is not ISO_1.
15519 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
15520 MethodInfo for the Invoke method. used by Delegate and
15523 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
15524 method conversions if the target type is a delegate.
15526 Removed extra debugging nops.
15528 (LocalVariableReference): Turn the `local_info' into a public
15531 Add `prepared' field, the same hack used for FieldExprs to cope
15532 with composed assignments, as Local variables do not necessarily
15533 operate purely on the stack as they used to: they can be captured
15536 Add `temp' for a temporary result, like fields.
15538 Refactor DoResolve and DoResolveLValue into DoResolveBase.
15540 It now copes with Local variables that are captured and emits the
15541 proper instance variable to load it from a field in the captured
15544 (ParameterReference.DoResolveBase): During the resolve phase,
15545 capture parameters if we are in an anonymous method.
15547 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
15548 anonymous method, use the EmitContext helper routines to emit the
15549 parameter reference.
15551 * iterators.cs: Set RemapToProxy to true/false during the
15554 * parameters.cs (GetParameterByName): New helper method.
15556 * typemanager.cs (anonymous_method_type) a new type that
15557 represents an anonyous method. This is always an internal type,
15558 used as a fencepost to test against the anonymous-methodness of an
15561 2004-10-20 Marek Safar <marek.safar@seznam.cz>
15563 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
15565 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
15567 2004-10-18 Martin Baulig <martin@ximian.com>
15569 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
15570 `Type' directly, but call ResolveType() on it.
15571 (Catch.Resolve): Likewise.
15572 (Foreach.Resolve): Likewise.
15574 2004-10-18 Martin Baulig <martin@ximian.com>
15576 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
15577 `Type' directly, but call ResolveType() on it.
15578 (Probe.DoResolve): Likewise.
15579 (ArrayCreation.LookupType): Likewise.
15580 (TypeOf.DoResolve): Likewise.
15581 (SizeOf.DoResolve): Likewise.
15583 2004-10-18 Martin Baulig <martin@ximian.com>
15585 * expression.cs (Invocation.BetterFunction): Put back
15586 TypeManager.TypeToCoreType().
15588 2004-10-18 Raja R Harinath <rharinath@novell.com>
15590 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
15593 2004-10-18 Martin Baulig <martin@ximian.com>
15595 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
15596 `Type' directly, but call ResolveType() on it.
15598 2004-10-18 Martin Baulig <martin@ximian.com>
15600 * class.cs (FieldMember.Define): Don't access the TypeExpr's
15601 `Type' directly, but call ResolveType() on it.
15602 (MemberBase.DoDefine): Likewise.
15604 * expression.cs (New.DoResolve): Don't access the TypeExpr's
15605 `Type' directly, but call ResolveType() on it.
15606 (ComposedCast.DoResolveAsTypeStep): Likewise.
15608 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
15609 `Type' directly, but call ResolveType() on it.
15611 2004-10-17 John Luke <john.luke@gmail.com>
15613 * class.cs (Operator.GetSignatureForError): use CSharpName
15615 * parameter.cs (Parameter.GetSignatureForError): Returns
15616 correct name even if was not defined.
15618 2004-10-13 Raja R Harinath <rharinath@novell.com>
15621 * class.cs (TypeContainer.EmitContext): New property.
15622 (DefineNestedTypes): Create an emitcontext for each part.
15623 (MethodCore.DoDefineParameters): Use container's emitcontext.
15624 Pass type array to InternalParameters.
15625 (MemberBase.DoDefine): Use container's emitcontext.
15626 (FieldMember.Define): Likewise.
15627 (Event.Define): Likewise.
15628 (SetMethod.GetParameterInfo): Change argument to EmitContext.
15629 Pass type array to InternalParameters.
15630 (SetIndexerMethod.GetParameterInfo): Likewise.
15631 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
15632 * delegate.cs (Define): Pass emitcontext to
15633 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
15634 array to InternalParameters.
15635 * expression.cs (ParameterReference.DoResolveBase): Pass
15636 emitcontext to GetParameterInfo.
15637 (ComposedCast.DoResolveAsTypeStep): Remove check on
15638 ec.ResolvingTypeTree.
15639 * parameter.cs (Parameter.Resolve): Change argument to
15640 EmitContext. Use ResolveAsTypeTerminal.
15641 (Parameter.GetSignature): Change argument to EmitContext.
15642 (Parameters.ComputeSignature): Likewise.
15643 (Parameters.ComputeParameterTypes): Likewise.
15644 (Parameters.GetParameterInfo): Likewise.
15645 (Parameters.ComputeAndDefineParameterTypes): Likewise.
15646 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
15647 * support.cs (InternalParameters..ctor): Remove variant that takes
15649 * typemanager.cs (system_intptr_expr): New.
15650 (InitExpressionTypes): Initialize it.
15652 2004-10-12 Chris Toshok <toshok@ximian.com>
15654 * cs-parser.jay: fix location for try_statement and catch_clause.
15656 2004-10-11 Martin Baulig <martin@ximian.com>
15658 * report.cs: Don't make --fatal abort on warnings, we have
15659 -warnaserror for that.
15661 2004-10-07 Raja R Harinath <rharinath@novell.com>
15663 More DeclSpace.ResolveType avoidance.
15664 * decl.cs (MemberCore.InUnsafe): New property.
15665 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
15666 with newly created EmitContext.
15667 (FieldMember.Define): Likewise.
15668 * delegate.cs (Delegate.Define): Likewise.
15669 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
15670 only if normal name-lookup fails.
15671 (TypeExpr.DoResolve): Enable error-checking.
15672 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
15673 (SizeOf.DoResolve): Likewise.
15674 (ComposedCast.DoResolveAsTypeStep): Likewise.
15675 (StackAlloc.DoResolve): Likewise.
15676 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
15677 (Block.Unsafe): New property.
15678 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
15679 (Unsafe): Set 'unsafe' flag of contained block.
15680 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
15681 (Fixed.Resolve): Likewise.
15682 (Catch.Resolve): Likewise.
15683 (Using.ResolveLocalVariableDecls): Likewise.
15684 (Foreach.Resolve): Likewise.
15686 2004-10-05 John Luke <john.luke@gmail.com>
15688 * cs-parser.jay: add location to error CS0175
15690 2004-10-04 Miguel de Icaza <miguel@ximian.com>
15692 * ecore.cs (Expression.Constantity): Add support for turning null
15695 * const.cs (Const.Define): Allow constants to be reference types
15696 as long as the value is Null.
15698 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
15700 * namespace.cs (NamespaceEntry.Using): No matter which warning
15701 level is set, check if this namespace name has already been added.
15703 2004-10-03 Ben Maurer <bmaurer@ximian.com>
15705 * expression.cs: reftype [!=]= null should always use br[true,false].
15708 2004-10-03 Marek Safar <marek.safar@seznam.cz>
15711 * attribute.cs: Enum conversion moved to
15712 GetAttributeArgumentExpression to be applied to the all
15715 2004-10-01 Raja R Harinath <rharinath@novell.com>
15717 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
15718 * class.c (TypeContainer.DefineType): Flag error if
15719 base types aren't accessible due to access permissions.
15720 * decl.cs (DeclSpace.ResolveType): Move logic to
15721 Expression.ResolveAsTypeTerminal.
15722 (DeclSpace.ResolveTypeExpr): Thin layer over
15723 Expression.ResolveAsTypeTerminal.
15724 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
15725 Refactor code into NestedAccess. Use it.
15726 (DeclSpace.NestedAccess): New.
15727 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
15728 argument to silence errors. Check access permissions.
15729 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
15730 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
15731 (Cast.DoResolve): Likewise.
15732 (New.DoResolve): Likewise.
15733 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
15734 (TypeOf.DoResolve): Likewise.
15736 * expression.cs (Invocation.BetterConversion): Return the Type of
15737 the better conversion. Implement section 14.4.2.3 more faithfully.
15738 (Invocation.BetterFunction): Make boolean. Make correspondence to
15739 section 14.4.2.2 explicit.
15740 (Invocation.OverloadResolve): Update.
15741 (Invocation): Remove is_base field.
15742 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
15743 (Invocation.Emit): Likewise.
15745 2004-09-27 Raja R Harinath <rharinath@novell.com>
15747 * README: Update to changes.
15749 2004-09-24 Marek Safar <marek.safar@seznam.cz>
15751 * cs-parser.jay: Reverted 642 warning fix.
15753 2004-09-23 Marek Safar <marek.safar@seznam.cz>
15756 * decl.cs (FindMemberWithSameName): Indexer can have more than
15759 2004-09-23 Marek Safar <marek.safar@seznam.cz>
15761 * expression.cs (LocalVariableReference.DoResolveLValue):
15762 Do not report warning 219 for out values.
15763 (EmptyExpression.Null): New member to avoid extra allocations.
15765 2004-09-23 Marek Safar <marek.safar@seznam.cz>
15767 * cs-parser.jay: Fix wrong warning 642 report.
15769 * cs-tokenizer.cs (CheckNextToken): New helper;
15770 Inspect next character if is same as expected.
15772 2004-09-23 Martin Baulig <martin@ximian.com>
15774 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
15775 (Convert.ImplicitReferenceConversionExists): Likewise.
15777 2004-09-23 Marek Safar <marek.safar@seznam.cz>
15779 * class.cs (Operator.Define): Add error 448 and 559 report.
15781 2004-09-22 Marek Safar <marek.safar@seznam.cz>
15783 * class.cs (MemberBase.IsTypePermitted): New protected
15784 method for checking error CS0610.
15786 2004-09-22 Marek Safar <marek.safar@seznam.cz>
15788 * class.cs (TypeContainer.HasExplicitLayout): New property
15789 Returns whether container has StructLayout attribute set Explicit.
15790 (FieldMember): New abstract class for consts and fields.
15791 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
15792 (Field): Reuse FieldMember.
15794 * const.cs (Const): Reuse FieldMember.
15796 * rootcontext.cs: EmitConstants call moved to class.
15798 2004-09-22 Martin Baulig <martin@ximian.com>
15800 Thanks to Peter Sestoft for this bug report.
15802 * expression.cs (Conditional): If both the `trueExpr' and the
15803 `falseExpr' is a NullLiteral, return a NullLiteral.
15805 2004-09-22 Martin Baulig <martin@ximian.com>
15807 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
15808 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
15809 for the "get_Current" call.
15811 2004-09-22 Martin Baulig <martin@ximian.com>
15813 Marek and me just fixed one of our oldest bugs: #28562 :-)
15815 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
15817 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
15818 we're an EnumConstant, just return that.
15819 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
15820 an EnumConstant. In this case, we need to use GetValueAsEnumType()
15821 to get the value which'll actually be written into the attribute.
15822 However, we have to use GetValue() to access the attribute's value
15825 2004-09-22 Marek Safar <marek.safar@seznam.cz>
15827 * constant.cs (Constant.IsNegative): New abstract property
15830 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
15831 (StackAlloc.DoResolve): Reused IsNegative.
15833 2004-09-21 Martin Baulig <martin@ximian.com>
15835 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
15836 if we're used in an iterator, we may be called from different
15839 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
15840 we actually have an exception block.
15842 2004-09-20 John Luke <jluke@cfl.rr.com>
15844 * class.cs, cs-parser.jay: Improve the error report for 1520:
15845 report the actual line where the error happens, not where the
15846 class was declared.
15848 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
15849 Pass location information that was available elsewhere.
15851 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
15853 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
15854 runtime to delay sign assemblies.
15856 2004-09-19 Miguel de Icaza <miguel@ximian.com>
15858 * cs-parser.jay: Do not report the stack trace, this is barely
15861 2004-08-22 John Luke <john.luke@gmail.com>
15863 * driver.cs : check that a resource id is not already used
15864 before adding it, report CS1508 if it is, bug #63637
15866 2004-09-19 Miguel de Icaza <miguel@ximian.com>
15868 * ecore.cs: Removed dead code.
15870 2004-09-18 Marek Safar <marek.safar@seznam.cz>
15872 * class.cs: Do not report warning CS0067 on the interfaces.
15874 2004-09-16 Marek Safar <marek.safar@seznam.cz>
15876 * cs-parser.jay: Add error 504 report.
15878 2004-09-16 Marek Safar <marek.safar@seznam.cz>
15880 * rootcontext.cs: WarningLevel is 4 by default now.
15882 * statement.cs (Fixed.Resolve): Do not null
15885 2004-09-16 Marek Safar <marek.safar@seznam.cz>
15888 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
15889 deep search when property is not virtual.
15890 (PropertyExpr.ResolveAccessors): Make one call for both
15893 2004-09-15 Marek Safar <marek.safar@seznam.cz>
15896 * statement.cs: Error 152 report constains also location.
15898 2004-09-15 Marek Safar <marek.safar@seznam.cz>
15901 * const.cs: Explicitly set constant as static.
15903 2004-09-15 Marek Safar <marek.safar@seznam.cz>
15906 * cs-parser.jay: Add error 1017 report.
15908 2004-09-15 Marek Safar <marek.safar@seznam.cz>
15910 Fixed bug #59980, #64224
15911 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
15913 * typemanager.cs (IsSpecialMethod): Simplified
15915 2004-09-14 Marek Safar <marek.safar@seznam.cz>
15917 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
15918 condition with better params.
15920 2004-09-14 Marek Safar <marek.safar@seznam.cz>
15923 * attribute.cs (Resolve): Property has to have both
15926 2004-09-14 Martin Baulig <martin@ximian.com>
15928 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
15930 2004-09-14 Marek Safar <marek.safar@seznam.cz>
15933 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
15934 called and is obsolete then this member suppress message
15935 when call is inside next [Obsolete] method or type.
15937 * expression.cs: Use TestObsoleteMethodUsage member.
15939 2004-09-14 Martin Baulig <martin@ximian.com>
15941 * cs-parser.jay: Sync a bit with the GMCS version.
15943 2004-09-14 Martin Baulig <martin@ximian.com>
15945 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
15946 (CSharpParser.yacc_verbose_flag): New public field.
15948 * genericparser.cs: Removed.
15950 2004-09-14 Raja R Harinath <rharinath@novell.com>
15952 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
15954 2004-09-13 Marek Safar <marek.safar@seznam.cz>
15956 * class.cs (MethodCore.CheckBase): Fix bug #65757.
15958 2004-09-10 Martin Baulig <martin@ximian.com>
15960 Backported my MemberName changes from GMCS into MCS.
15962 - we are now using a special `MemberName' class instead of using
15963 strings; in GMCS, the `MemberName' also contains the type
15966 - changed the grammar rules a bit:
15967 * the old `member_name' is now a `namespace_or_type_name':
15968 The rule is that we use `namespace_or_type_name' everywhere
15969 where we expect either a "member name" (GetEnumerator) or a
15970 "member name" with an explicit interface name
15971 (IEnumerable.GetEnumerator).
15972 In GMCS, the explicit interface name may include type arguments
15973 (IEnumerable<T>.GetEnumerator).
15974 * we use `member_name' instead of just `IDENTIFIER' for
15976 The rule is that we use `member_name' wherever a member may
15977 have type parameters in GMCS.
15979 * decl.cs (MemberName): New public class.
15980 (MemberCore.MemberName): New public readonly field.
15981 (MemberCore.ctor): Take a `MemberName' argument, not a string.
15982 (DeclSpace): Likewise.
15984 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
15985 * enum.cs (Enum.ctor): Likewise.
15987 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
15989 (AliasEntry.ctor): Take a MemberName, not an Expression.
15990 (AliasEntry.UsingAlias): Likewise.
15992 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
15993 (IMethodData.MemberName): Changed type from string to MemberName.
15994 (MemberBase.ExplicitInterfaceName): Likewise.
15995 (AbstractPropertyEventMethod.SetupName): Make this private.
15996 (AbstractPropertyEventMethod.ctor): Added `string prefix'
15997 argument; compute the member name here.
15998 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
15999 on the `member.MemberName' and the `prefix'.
16001 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16003 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16004 thus, we get a `MemberName' instead of a `string'. These
16005 declarations may have type parameters in GMCS.
16006 (interface_method_declaration, delegate_declaration): Likewise.
16007 (class_declaration, interface_declaration): Likewise.
16008 (method_header): Use `namespace_or_type_name' instead of
16009 `member_name'. We may be an explicit interface implementation.
16010 (property_declaration, event_declaration): Likewise.
16011 (member_name): This is now just an `IDENTIFIER', not a
16012 `namespace_or_type_name'.
16013 (type_name, interface_type): Removed.
16014 (namespace_or_type_name): Return a MemberName, not an Expression.
16015 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16016 call GetTypeExpression() on the MemberName to get an expression.
16017 (IndexerDeclaration.interface_type): Changed type from string to
16019 (MakeName): Operate on MemberName's instead of string's.
16021 2004-09-13 Raja R Harinath <rharinath@novell.com>
16024 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16025 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16026 lookup to avoid symbols introduced by 'using'.
16027 * rootcontext.cs (NamespaceLookup): Update.
16029 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16031 * class.cs (TypeContainer.DoDefineMembers): Do not call
16032 DefineDefaultConstructor for static classes.
16034 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16036 * attribute.cs (Attribute.Resolve): Add error 653 report.
16038 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16040 (Method.ApplyAttributeBuilder): Add error 685 report.
16041 (Operator.Define): Add error 564 report.
16043 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16045 * expression.cs (Invocation.DoResolve): Add error
16046 245 and 250 report.
16048 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16051 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16053 * class.cs (ConstructorInitializer.Resolve):
16054 Wrong error number (515->516).
16056 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16058 * class.cs (Indexer.Define): Add error 631 report.
16060 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16062 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16064 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16066 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16068 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16070 * cs-parser.jay: Added error CS0241 report.
16072 2004-09-10 Raja R Harinath <rharinath@novell.com>
16074 * cs-parser.jay (fixed_statement): Introduce a scope for the
16075 declaration in the 'fixed' statement.
16077 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16079 * cs-parser.jay: Added CS0230 error report.
16081 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16083 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16085 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16087 * expression.cs (Argument.Resolve): Added error CS0192 and
16090 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16092 C# 2.0 #pragma warning feature
16094 * cs-tokenizer.cs (PreProcessPragma): New method;
16095 Handles #pragma directive.
16097 * report.cs (WarningRegions): New class; Support
16098 class for #pragma warning directive. It tests whether
16099 warning is enabled for a given line.
16101 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16103 * const.cs: Add more descriptive error report, tahnks to
16106 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16108 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
16110 2004-09-07 Miguel de Icaza <miguel@ximian.com>
16112 * expression.cs: Apply patch from Ben: Remove dead code from
16113 ArrayCreation, and remove the TurnintoConstant call in const.cs,
16114 as that code just threw an exception anwyays.
16116 * const.cs: Remove the call to the turnintoconstant, for details
16119 * literal.cs: The type of the null-literal is the null type; So
16120 we use a placeholder type (literal.cs:System.Null, defined here)
16123 * expression.cs (Conditional.DoResolve): Remove some old code that
16124 is no longer needed, conversions have been fixed.
16126 (ArrayCreationExpression.DoResolve): Return false if we fail to
16127 resolve the inner expression.
16129 2004-09-07 Raja R Harinath <rharinath@novell.com>
16132 * cs-parser.jay (delegate_declaration): Record a delegate
16133 declaration as a type declaration.
16134 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
16136 2004-09-06 Miguel de Icaza <miguel@ximian.com>
16138 * parameter.cs: Do not crash if the type can not be resolved.
16140 * expression.cs: Report errors with unsafe pointers, fixes #64896
16142 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
16144 * expression.cs: Pointer arith always needs to do a conv.i
16145 if the operand is a long. fix 65320
16147 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16149 Fixed cs0619-37.cs, cs0619-38.cs
16151 * enum.cs (GetObsoleteAttribute): Removed.
16153 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
16154 on Enum member is double staged. The first is tested member
16157 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16159 Fixed #56986, #63631, #65231
16161 * class.cs: (TypeContainer.AddToMemberContainer): New method,
16162 adds member to name container.
16163 (TypeContainer.AddToTypeContainer): New method, adds type to
16165 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
16166 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
16167 AddOperator): Simplified by reusing AddToMemberContainer.
16168 (TypeContainer.UserDefinedStaticConstructor): Changed to property
16170 (Method.CheckForDuplications): Fixed implementation to test all
16172 (MemberBase): Detection whether member is explicit interface
16173 implementation is now in constructor.
16174 (MemberBase.UpdateMemberName): Handles IndexerName.
16175 (Accessor): Changed to keep also location information.
16176 (AbstractPropertyEventMethod): Is derived from MemberCore.
16177 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
16178 will be emited or not.
16179 (PropertyBase.AreAccessorsDuplicateImplementation):
16180 Tests whether accessors are not in collision with some method.
16181 (Operator): Is derived from MethodCore to simplify common
16184 * decl.cs (Flags.TestMethodDuplication): Test for duplication
16186 (DeclSpace.AddToContainer): Adds the member to defined_names
16187 table. It tests for duplications and enclosing name conflicts.
16189 * enum.cs (EnumMember): Clean up to reuse the base structures
16191 2004-09-03 Martin Baulig <martin@ximian.com>
16193 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
16194 into TypeContainer, to make partial classes work again.
16196 2004-09-03 Martin Baulig <martin@ximian.com>
16198 * rootcontext.cs (RootContext.V2): Removed.
16200 2004-03-23 Martin Baulig <martin@ximian.com>
16202 * expression.cs (Invocation.OverloadResolve): Added `bool
16203 may_fail' argument and use it instead of the Location.IsNull() hack.
16205 2004-09-03 Martin Baulig <martin@ximian.com>
16207 Merged latest changes into gmcs. Please keep this comment in
16208 here, it makes it easier for me to see what changed in MCS since
16209 the last time I merged.
16211 2004-09-03 Raja R Harinath <rharinath@novell.com>
16214 * expression.cs (BetterConversion): Don't allow either conversion
16215 to be null. Remove redundant implicit conversion test when 'q ==
16216 null' -- when this function is invoked, we already know that the
16217 implicit conversion exists.
16218 (BetterFunction): Assume that 'best' is non-null. Remove
16219 redundant reimplementation of IsApplicable when 'best' is null.
16220 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
16221 number of arguments.
16222 (IsAncestralType): Extract from OverloadResolve.
16223 (OverloadResolve): Make robust to the MethodGroupExpr being
16224 unsorted. Implement all the logic of Section 14.5.5.1, and
16225 support overloading of methods from multiple applicable types.
16226 Clean up logic somewhat. Don't pass null methods to BetterFunction.
16228 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
16229 (RealError, Warning): Append type of report to related symbol.
16231 2004-09-03 Marek Safar <marek.safar@seznam.cz>
16233 * enum.cs: Fixed CLS-Compliance checks for enum members.
16234 Error tests cs3008-8.cs, cs3014-8.cs
16236 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16238 Fixed bug #62342, #63102
16239 * class.cs: ImplementIndexer uses member.IsExplicitImpl
16240 like ImplementMethod.
16242 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16244 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16247 2004-09-02 Martin Baulig <martin@ximian.com>
16249 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
16250 TypeManager.GetArgumentTypes() rather than calling GetParameters()
16253 2004-09-01 Marek Safar <marek.safar@seznam.cz>
16255 C# 2.0 Static classes implemented
16257 * class.cs (TypeContainer): instance_constructors,
16258 initialized_fields, initialized_static_fields,
16259 default_constructor, base_inteface_types are protected to be
16260 accessible from StaticClass.
16261 (TypeContainer.DefineDefaultConstructor): New virtual method
16262 for custom default constructor generating
16263 (StaticClass): New class to handle "Static classes" feature.
16265 * cs-parser.jay: Handle static keyword on class like instance
16268 * driver.cs: Added "/langversion" command line switch with two
16269 options (iso-1, default).
16271 2004-08-31 Marek Safar <marek.safar@seznam.cz>
16273 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
16275 2004-08-31 Miguel de Icaza <miguel@ximian.com>
16277 * delegate.cs: Style.
16279 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
16281 * delegate.cs: Add seperate instance expr field for miguel.
16283 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16285 * PointerArithmetic (Resolve): make sure we are not doing
16286 pointer arith on void*. Also, make sure we are resolved
16287 by not setting eclass until resolve.
16289 All callers: Make sure that PointerArithmetic gets resolved.
16291 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16293 * ArrayCreation (LookupType): If the type does not resolve
16294 to an array, give an error.
16296 2004-08-27 Marek Safar <marek.safar@seznam.cz>
16298 * statement.cs (Try.Resolve): Fixed bug #64222
16300 2004-08-27 Martin Baulig <martin@ximian.com>
16303 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
16306 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16308 * ecore.cs (Constantify): Get underlying type via
16309 System.Enum.GetUnderlyingType to avoid StackOverflow on the
16310 Windows in special cases.
16312 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16314 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
16315 for obtaining also private methods.
16316 (GetRemoveMethod): Used GetRemoveMethod (true)
16317 for obtaining also private methods.
16319 2004-08-24 Martin Baulig <martin@ximian.com>
16321 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
16322 MethodAttributes.HideBySig for operators.
16324 2004-08-23 Martin Baulig <martin@ximian.com>
16326 Back to the old error reporting system :-)
16328 * report.cs (Message): Removed.
16329 (Report.MessageData, ErrorData, WarningData): Removed.
16330 (Report.Error, Warning): Back to the old system.
16332 2004-08-23 Martin Baulig <martin@ximian.com>
16334 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
16336 * class.cs (TypeContainer.ParentContainer): New public virtual
16337 method; replaces the explicit interface implementation.
16338 (ClassPart.ParentContainer): Override.
16340 2004-08-23 Martin Baulig <martin@ximian.com>
16342 * statement.cs (Switch): Added support for constant switches; see
16343 #59428 or test-285.cs.
16345 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16348 * statement.cs (GetEnumeratorFilter): Removed useless
16349 logic because C# specs is strict. GetEnumerator must be
16352 2004-08-22 Martin Baulig <martin@ximian.com>
16354 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
16355 a switch and may break, reset the barrier. Fixes #59867.
16357 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16359 CLS-Compliance speed up (~5% for corlib)
16361 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
16362 New method. Tests container for CLS-Compliant names
16364 * class.cs (TypeContainer.VerifyClsName): New method.
16365 Checks whether container name is CLS Compliant.
16366 (Constructor): Implements IMethodData.
16368 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
16369 low-case table for CLS Compliance test.
16370 (MemberCache.VerifyClsParameterConflict): New method.
16371 Checks method parameters for CS3006 error.
16373 * enum.cs (EnumMember): Is derived from MemberCore.
16374 (Enum.VerifyClsName): Optimized for better performance.
16376 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16378 * report.cs: Renamed Error_T to Error and changed all
16381 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16383 * class.cs (TypeContainer.IndexerArrayList): New inner class
16384 container for indexers.
16385 (TypeContainer.DefaultIndexerName): New constant for default
16386 indexer name. Replaced all "Item" with this constant.
16387 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
16389 * typemanager.cs (TypeManager.default_member_ctor): Cache here
16390 DefaultMemberAttribute constructor.
16392 2004-08-05 Martin Baulig <martin@ximian.com>
16394 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
16397 2004-08-05 Marek Safar <marek.safar@seznam.cz>
16399 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
16400 multi platforms problem.
16402 * compiler.csproj: Included shared files.
16404 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16406 Fix bug 60333, 55971 in the more general way
16407 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16408 Added arg_type argument for constant conversion.
16409 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
16411 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16414 * class.cs (TypeContainer ): New inner classes MethodArrayList,
16415 OperatorArrayList, MethodCoreArrayList for typecontainer
16416 containers. Changed class member types to these new types.
16417 (MethodArrayList.DefineMembers): Added test for CS0659.
16419 2004-08-04 Miguel de Icaza <miguel@ximian.com>
16421 * cfold.cs: Synchronize the folding with the code in expression.cs
16422 Binary.DoNumericPromotions for uint operands.
16424 * attribute.cs: Revert patch from Raja, it introduced a regression
16425 while building Blam-1.2.1 (hard to isolate a test case).
16427 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16431 (TypeContainer.Define): Renamed to DefineContainerMembers because of
16433 (MethodCore.parent_method): New member. The method we're overriding
16434 if this is an override method.
16435 (MethodCore.CheckBase): Moved from Method class and made common.
16436 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
16438 (MethodCore.CheckForDuplications): New abstract method. For custom
16439 member duplication search in a container
16440 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
16441 method and its return type.
16442 (Event.conflict_symbol): New member. Symbol with same name in the
16446 (MemberCache.FindMemberWithSameName): New method. The method
16447 is looking for conflict with inherited symbols.
16449 2004-08-04 Martin Baulig <martin@ximian.com>
16451 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
16453 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
16455 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16457 * report.cs (Message): New enum for better error, warning reference in
16459 (MessageData): New inner abstract class. It generally handles printing of
16460 error and warning messages.
16461 Removed unused Error, Warning, Message methods.
16463 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16465 Fix for cs0592-8.cs test
16467 (Attributable.ValidAttributeTargets): Made public.
16468 (Attribute.ExplicitTarget): New member for explicit target value.
16469 (Attribute.CheckTargets): Now we translate explicit attribute
16470 target to Target here.
16472 2004-08-03 Ben Maurer <bmaurer@ximian.com>
16474 * ecore.cs (MethodGroupExpr): new IsBase property.
16476 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
16478 * delegate.cs (DelegateCreation): store a MethodGroupExpr
16479 rather than an instance expr.
16481 (DelegateCreation.Emit): Use the method group rather than
16482 the instance expression. Also, if you have base.Foo as the
16483 method for a delegate, make sure to emit ldftn, not ldftnvirt.
16485 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
16487 (NewDelegate.DoResolve): Only check for the existance of Invoke
16488 if the method is going to be needed. Use MethodGroupExpr.
16490 (NewDelegate.Emit): Remove, DelegateCreation implements this.
16492 * expression.cs: For pointer arith., make sure to use
16493 the size of the type, not the size of the pointer to
16496 2004-08-03 Marek Safar <marek.safar@seznam.cz>
16499 * class.cs (Class): Added error CS0502 test.
16501 2004-08-03 John Luke <jluke@cfl.rr.com>
16502 Raja R Harinath <rharinath@novell.com>
16505 * attribute.cs (Attribute.complained_before): New flag.
16506 (Attribute.ResolveType, Attribute.Resolve),
16507 (Attribute.DefinePInvokeMethod): Set it.
16508 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
16510 2004-08-03 Martin Baulig <martin@ximian.com>
16512 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
16513 use a user-defined operator; we still need to do numeric
16514 promotions in case one argument is a builtin type and the other
16515 one has an implicit conversion to that type. Fixes #62322.
16517 2004-08-02 Martin Baulig <martin@ximian.com>
16519 * statement.cs (LocalInfo.Flags): Added `IsThis'.
16520 (LocalInfo.IsThis): New public property.
16521 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
16523 2004-08-01 Martin Baulig <martin@ximian.com>
16525 * class.cs (TypeContainer.GetClassBases): Don't set the default
16526 here since we may get called from GetPartialBases().
16527 (TypeContainer.DefineType): If GetClassBases() didn't return a
16528 parent, use the default one.
16530 2004-07-30 Duncan Mak <duncan@ximian.com>
16532 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
16534 2004-07-30 Martin Baulig <martin@ximian.com>
16536 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
16538 * class.cs (SourceMethod): New public class, derive from the
16539 symbol writer's ISourceMethod.
16540 (Method): Use the new symbol writer API.
16542 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
16543 as argument and use the new symbol writer.
16546 (SourceFile): Implement the symbol writer's ISourceFile.
16547 (Location.SymbolDocument): Removed.
16548 (Location.SourceFile): New public property.
16550 * symbolwriter.cs: Use the new symbol writer API.
16552 2004-07-30 Raja R Harinath <rharinath@novell.com>
16554 * Makefile (install-local): Remove. Functionality moved to
16557 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
16559 * Makefile: Install mcs.exe.config file together with mcs.exe.
16560 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
16561 correct runtime version.
16563 2004-07-25 Martin Baulig <martin@ximian.com>
16566 (TypeContainer.RegisterOrder): Removed, this was unused.
16567 (TypeContainer, interface_order): Removed.
16568 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
16569 TypeContainer as argument since we can also be called with a
16570 `PartialContainer' for a partial class/struct/interface.
16571 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
16572 of checking whether we're an `Interface' - we could be a
16573 `PartialContainer'.
16574 (PartialContainer.Register): Override; call
16575 AddClass()/AddStruct()/AddInterface() on our parent.
16577 * cs-parser.jay (interface_member_declaration): Add things to the
16578 `current_container', not the `current_class'.
16580 * rootcontext.cs (RegisterOrder): The overloaded version which
16581 takes an `Interface' was unused, removed.
16583 * typemanager.cs (TypeManager.LookupInterface): Return a
16584 `TypeContainer', not an `Interface'.
16585 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
16586 contain a `PartialContainer' for an interface, so check it's
16587 `Kind' to figure out what it is.
16589 2004-07-25 Martin Baulig <martin@ximian.com>
16591 * class.cs (Class.DefaultTypeAttributes): New public constant.
16592 (Struct.DefaultTypeAttributes): Likewise.
16593 (Interface.DefaultTypeAttributes): Likewise.
16594 (PartialContainer.TypeAttr): Override this and add the
16595 DefaultTypeAttributes.
16597 2004-07-25 Martin Baulig <martin@ximian.com>
16599 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
16600 we can just use the `Parent' field instead.
16602 2004-07-25 Martin Baulig <martin@ximian.com>
16604 * class.cs (TypeContainer.Emit): Renamed to EmitType().
16606 2004-07-25 Martin Baulig <martin@ximian.com>
16608 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
16609 our parts before defining any methods.
16610 (TypeContainer.VerifyImplements): Make this virtual.
16611 (ClassPart.VerifyImplements): Override and call VerifyImplements()
16612 on our PartialContainer.
16614 2004-07-25 Martin Baulig <martin@ximian.com>
16616 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
16618 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
16619 argument, we can just use the `Parent' field instead.
16622 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
16623 (MemberBase.DoDefine): Likewise.
16625 2004-07-24 Martin Baulig <martin@ximian.com>
16627 * decl.cs (MemberCore.Parent): New public field.
16628 (DeclSpace.Parent): Moved to MemberCore.
16630 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
16631 (MemberBase.ctor): Added TypeContainer argument, pass it to our
16633 (FieldBase, Field, Operator): Likewise.
16634 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
16635 (EventField, Event): Likewise.
16637 2004-07-23 Martin Baulig <martin@ximian.com>
16639 * class.cs (PartialContainer): New public class.
16640 (ClassPart): New public class.
16641 (TypeContainer): Added support for partial classes.
16642 (TypeContainer.GetClassBases): Splitted some of the functionality
16643 out into GetNormalBases() and GetPartialBases().
16645 * cs-tokenizer.cs (Token.PARTIAL): New token.
16646 (Tokenizer.consume_identifier): Added some hacks to recognize
16647 `partial', but only if it's immediately followed by `class',
16648 `struct' or `interface'.
16650 * cs-parser.jay: Added support for partial clases.
16652 2004-07-23 Martin Baulig <martin@ximian.com>
16654 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
16655 a `DeclSpace' and also made it readonly.
16656 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
16657 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
16658 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
16660 * cs-parser.jay: Pass the `current_class', not the
16661 `current_container' (at the moment, this is still the same thing)
16662 to a new Method, Property, Event, Indexer or Constructor.
16664 2004-07-23 Martin Baulig <martin@ximian.com>
16666 * cs-parser.jay (CSharpParser): Added a new `current_class' field
16667 and removed the `current_interface' one.
16668 (struct_declaration, class_declaration, interface_declaration):
16669 Set `current_class' to the newly created class/struct/interface;
16670 set their `Bases' and call Register() before parsing their body.
16672 2004-07-23 Martin Baulig <martin@ximian.com>
16674 * class.cs (Kind): New public enum.
16675 (TypeContainer): Made this class abstract.
16676 (TypeContainer.Kind): New public readonly field.
16677 (TypeContainer.CheckDef): New public method; moved here from
16679 (TypeContainer.Register): New public abstract method.
16680 (TypeContainer.GetPendingImplementations): New public abstract
16682 (TypeContainer.GetClassBases): Removed the `is_class' and
16683 `is_iface' parameters.
16684 (TypeContainer.DefineNestedTypes): Formerly known as
16686 (ClassOrStruct): Made this class abstract.
16688 * tree.cs (RootTypes): New public type.
16690 2004-07-20 Martin Baulig <martin@ximian.com>
16692 * tree.cs (Tree.RecordNamespace): Removed.
16693 (Tree.Namespaces): Removed.
16695 * rootcontext.cs (RootContext.IsNamespace): Removed.
16697 * cs-parser.jay (namespace_declaration): Just create a new
16698 NamespaceEntry here.
16700 2004-07-20 Martin Baulig <martin@ximian.com>
16702 * statement.cs (ExceptionStatement): New abstract class. This is
16703 now used as a base class for everyone who's using `finally'.
16704 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
16705 our local variables before using them.
16707 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
16708 virtual method. This is used by Yield.Resolve() to "steal" an
16709 outer block's `finally' clauses.
16710 (FlowBranchingException): The .ctor now takes an ExceptionStatement
16713 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
16714 version which takes an ExceptionStatement. This version must be
16715 used to create exception branchings.
16718 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
16719 (Iterator.EmitMoveNext): Added exception support; protect the
16720 block with a `fault' clause, properly handle 'finally' clauses.
16721 (Iterator.EmitDispose): Run all the `finally' clauses here.
16723 2004-07-20 Martin Baulig <martin@ximian.com>
16725 * iterator.cs: This is the first of a set of changes in the
16726 iterator code. Match the spec more closely: if we're an
16727 IEnumerable, then GetEnumerator() must be called. The first time
16728 GetEnumerator() is called, it returns the current instance; all
16729 subsequent invocations (if any) must create a copy.
16731 2004-07-19 Miguel de Icaza <miguel@ximian.com>
16733 * expression.cs: Resolve the constant expression before returning
16736 2004-07-19 Martin Baulig <martin@ximian.com>
16738 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
16739 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
16740 the return type of the new EmitContext.
16742 2004-07-18 Martin Baulig <martin@ximian.com>
16744 * class.cs (Property.Define): Fix iterators.
16746 * iterators.cs (Iterator.Define): Moved the
16747 `container.AddInterator (this)' call here from the .ctor; only do
16748 it if we resolved successfully.
16750 2004-07-17 Miguel de Icaza <miguel@ximian.com>
16752 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
16753 `true' for preprocessing directives that we parse. The return
16754 value indicates whether we should return to regular tokenizing or
16755 not, not whether it was parsed successfully.
16757 In the past if we were in: #if false ... #line #endif, we would
16758 resume parsing after `#line'. See bug 61604.
16760 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
16761 building: IsEnumType should return true only for enums, not for
16762 enums or System.Enum itself. This fixes #61593.
16764 Likely what happened is that corlib was wrong: mcs depended on
16765 this bug in some places. The bug got fixed, we had to add the
16766 hack, which caused bug 61593.
16768 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
16769 that was a workaround for the older conditions.
16771 2004-07-16 Ben Maurer <bmaurer@ximian.com>
16773 * assign.cs: IAssignMethod has a new interface, as documented
16774 inline. All assignment code now uses this new api.
16776 * ecore.cs, expression.cs: All classes which implement
16777 IAssignMethod now use the new interface.
16779 * expression.cs (Invocation): add a hack to EmitCall so that
16780 IndexerAccess can be the target of a compound assignment without
16781 evaluating its arguments twice.
16783 * statement.cs: Handle changes in Invocation api.
16785 2004-07-16 Martin Baulig <martin@ximian.com>
16787 * iterators.cs: Rewrote this. We're now using one single Proxy
16788 class for both the IEnumerable and the IEnumerator interface and
16789 `Iterator' derives from Class so we can use the high-level API.
16791 * class.cs (TypeContainer.AddIterator): New method.
16792 (TypeContainer.DoDefineType): New protected virtual method, which
16793 is called from DefineType().
16794 (TypeContainer.DoDefineMembers): Call DefineType() and
16795 DefineMembers() on all our iterators.
16796 (TypeContainer.Emit): Call Emit() on all our iterators.
16797 (TypeContainer.CloseType): Call CloseType() on all our iterators.
16799 * codegen.cs (EmitContext.CurrentIterator): New public field.
16801 2004-07-15 Martin Baulig <martin@ximian.com>
16804 (TypeManager.not_supported_exception_type): New type.
16806 2004-07-14 Martin Baulig <martin@ximian.com>
16808 * iterators.cs: Use real error numbers.
16810 2004-07-14 Martin Baulig <martin@ximian.com>
16812 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
16813 requires this to be a System.Collection.IEnumerable and not a
16814 class implementing that interface.
16815 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
16817 2004-07-13 Marek Safar <marek.safar@seznam.cz>
16819 * class.cs: Fixed previous fix, it broke some error tests.
16821 2004-07-12 Martin Baulig <martin@ximian.com>
16823 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
16826 2004-07-09 Miguel de Icaza <miguel@ximian.com>
16828 * assign.cs (LocalTemporary): Add new argument: is_address,If
16829 `is_address' is true, then the value that we store is the address
16830 to the real value, and not the value itself.
16832 * ecore.cs (PropertyExpr): use the new local temporary
16833 stuff to allow us to handle X.Y += z (where X is a struct)
16835 2004-07-08 Martin Baulig <martin@ximian.com>
16837 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
16838 not always return, just like we're doing in Using.Resolve().
16840 2004-07-07 Miguel de Icaza <miguel@ximian.com>
16842 * cs-parser.jay (fixed_statement): flag this as Pinned.
16844 2004-07-06 Miguel de Icaza <miguel@ximian.com>
16846 * typemanager.cs (TypeManager): Removed MakePinned method, this
16847 mechanism is replaced with the .NET 2.x compatible mechanism of
16848 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
16850 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
16851 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
16852 `IsFixed' property which has a different meaning.
16854 2004-07-02 Raja R Harinath <rharinath@novell.com>
16856 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
16857 visible from inside a nested class, not just the names of the
16858 immediately enclosing class.
16859 Fix for bug #60730.
16861 2004-06-24 Raja R Harinath <rharinath@novell.com>
16863 * expression.cs (BetterConversion): Remove buggy special-case
16864 handling of "implicit constant expression conversions". At this
16865 point, we already know that the conversion is possible -- we're
16866 only checking to see which is better.
16868 2004-06-24 Marek Safar <marek.safar@seznam.cz>
16870 * cs-parser.jay: Added error CS0210 test.
16872 2004-06-24 Marek Safar <marek.safar@seznam.cz>
16874 * cs-parser.jay: Added error CS0134 test.
16876 2004-06-24 Marek Safar <marek.safar@seznam.cz>
16879 * cs-parser.jay: Added error CS0145 test.
16881 2004-06-24 Marek Safar <marek.safar@seznam.cz>
16883 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
16885 2004-06-23 Ben Maurer <bmaurer@ximian.com>
16887 * expression.cs (StackAlloc.Resolve): The argument may not
16888 be a constant; deal with this case.
16890 2004-06-23 Marek Safar <marek.safar@seznam.cz>
16892 * attribute.cs (IndexerName_GetIndexerName): Renamed to
16893 GetIndexerAttributeValue.
16894 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
16896 * class.cs (Indexer.Define): Added error tests for CS0415,
16899 2004-06-23 Miguel de Icaza <miguel@ximian.com>
16901 * attribute.cs (Attribute.Resolve): Keep field code in sync with
16904 2004-06-23 Martin Baulig <martin@ximian.com>
16906 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
16907 neither return nor throw, reset the barrier as well. Fixes #60457.
16909 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
16911 * class.cs : EventAttributes is now set to None by default.
16912 This fixes bug #60459.
16914 2004-06-18 Marek Safar <marek.safar@seznam.cz>
16917 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
16918 Don't throw exception but return null (it's sufficient now).
16920 2004-06-18 Marek Safar <marek.safar@seznam.cz>
16922 * typemanager.cs (GetArgumentTypes): Faster implementation.
16924 2004-06-18 Martin Baulig <martin@ximian.com>
16926 * attribute.cs (Attribute.Resolve): Check whether we're an
16927 EmptyCast which a Constant child. Fixes #60333.
16929 2004-06-17 Ben Maurer <bmaurer@ximian.com>
16931 * statement.cs (EmitCollectionForeach): Account for the fact that
16932 not all valuetypes are in areas which we can take the address of.
16933 For these variables, we store to a temporary variable. Also, make
16934 sure that we dont emit a `callvirt' on a valuetype method.
16936 2004-06-15 Marek Safar <marek.safar@seznam.cz>
16938 * expression.cs (StackAlloc.DoReSolve): Added test for
16939 negative parameter (CS0247).
16941 2004-06-15 Marek Safar <marek.safar@seznam.cz>
16944 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
16946 2004-06-15 Marek Safar <marek.safar@seznam.cz>
16949 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
16952 2004-06-14 Marek Safar <marek.safar@seznam.cz>
16954 Fix bug #58254 & cs1555.cs, cs1556.cs
16955 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
16957 2004-06-14 Marek Safar <marek.safar@seznam.cz>
16959 * cs-parser.jay: Added error CS1669 test for indexers.
16961 2004-06-11 Martin Baulig <martin@ximian.com>
16963 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
16964 call this twice: for params and varargs methods.
16966 2004-06-11 Marek Safar <marek.safar@seznam.cz>
16969 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
16971 2004-06-11 Marek Safar <marek.safar@seznam.cz>
16973 * attribute.cs (Attribute.GetValidTargets): Made public.
16976 (AbstractPropertyEventMethod): New class for better code sharing.
16977 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
16979 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
16981 2004-06-11 Raja R Harinath <rharinath@novell.com>
16984 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
16985 that the call to Resolve is part of a MemberAccess.
16986 (Expression.Resolve): Use it for SimpleName resolution.
16987 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
16988 Add 'intermediate' boolean argument.
16989 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
16990 error message when the SimpleName can be resolved ambiguously
16991 between an expression and a type.
16992 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
16994 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
16995 call on the left-side.
16997 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17000 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17002 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17004 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17006 2004-06-11 Martin Baulig <martin@ximian.com>
17008 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17009 varargs methods if applicable.
17011 2004-06-11 Martin Baulig <martin@ximian.com>
17013 * expression.cs (Invocation.EmitCall): Don't use
17014 `method.CallingConvention == CallingConventions.VarArgs' since the
17015 method could also have `CallingConventions.HasThis'.
17017 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17019 * class.cs (Event.GetSignatureForError): Implemented.
17020 Fixed crash in error test cs3010.cs
17022 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17024 * cs-tokenizer.cs: Change the way we track __arglist to be
17025 consistent with the other keywords.
17027 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17029 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17032 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17034 * codegen.cs: Check that all referenced assemblies have a strongname
17035 before strongnaming the compiled assembly. If not report error CS1577.
17036 Fix bug #56563. Patch by Jackson Harper.
17037 * typemanager.cs: Added a method to return all referenced assemblies.
17038 Fix bug #56563. Patch by Jackson Harper.
17040 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17043 (Method.ApplyAttributeBuilder): Moved and added conditional
17044 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17047 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17049 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17052 * class.cs: (EventField.attribute_targets): Changed default target.
17054 2004-06-08 Martin Baulig <martin@ximian.com>
17056 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17058 2004-06-08 Martin Baulig <martin@ximian.com>
17060 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17062 2004-06-07 Martin Baulig <martin@ximian.com>
17064 Added support for varargs methods.
17066 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17069 * cs-parser.jay: Added support for `__arglist'.
17071 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17073 * expression.cs (Argument.AType): Added `ArgList'.
17074 (Invocation): Added support for varargs methods.
17075 (ArglistAccess): New public class.
17076 (Arglist): New public class.
17078 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17080 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17081 a method's top-level block if the method has varargs.
17083 * support.cs (ReflectionParameters, InternalParameters): Added
17084 support for varargs methods.
17086 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17088 * class.cs: Provide location in indexer error report.
17090 * driver.cs: Use standard names.
17092 * namespace.cs: Catch the use of using after a namespace has been
17093 declared also on using aliases.
17095 2004-06-03 Raja R Harinath <rharinath@novell.com>
17098 * typemanager.cs (closure_private_ok, closure_invocation_type)
17099 (closure_qualifier_type, closure_invocation_assembly)
17100 (FilterWithClosure): Move to ...
17101 (Closure): New internal nested class.
17102 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17103 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17104 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17105 (MemberLookup, MemberLookupFailed): Use it.
17106 * expression.cs (New.DoResolve): Treat the lookup for the
17107 constructor as being qualified by the 'new'ed type.
17108 (Indexers.GetIndexersForTypeOrInterface): Update.
17110 2004-06-03 Marek Safar <marek.safar@seznam.cz>
17113 (GetConditionalAttributeValue): New method. Returns
17114 condition of ConditionalAttribute.
17115 (SearchMulti): New method. Returns all attributes of type 't'.
17116 Use it when attribute is AllowMultiple = true.
17117 (IsConditionalMethodExcluded): New method.
17120 (Method.IsExcluded): Implemented. Returns true if method has conditional
17121 attribute and the conditions is not defined (method is excluded).
17122 (IMethodData): Extended interface for ConditionalAttribute support.
17123 (PropertyMethod.IsExcluded): Implemented.
17126 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
17129 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
17132 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
17134 * expression.cs (ArrayCreationExpression): Make this just an
17135 `expression'. It can't be a statement, so the code here was
17138 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17141 * typemanager.cs (GetFullNameSignature): New method for
17144 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17147 * class.cs (MemberBase.GetSignatureForError): New virtual method.
17148 Use this method when MethodBuilder is null.
17149 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
17150 Added test for error CS0626 (MONO reports error for this situation).
17151 (IMethodData.GetSignatureForError): Extended interface.
17153 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17156 (AttributeTester.GetObsoleteAttribute): Returns instance of
17157 ObsoleteAttribute when type is obsolete.
17160 (TypeContainer.VerifyObsoleteAttribute): Override.
17161 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
17162 (MethodCode.VerifyObsoleteAttribute): Override.
17163 (MemberBase.VerifyObsoleteAttribute): Override.
17166 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
17167 and report proper error.
17170 Delegate.VerifyObsoleteAttribute): Override.
17173 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
17174 and report proper error.
17175 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
17178 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
17182 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
17183 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
17184 Added test for ObsoleteAttribute.
17187 (Catch): Derived from Statement.
17189 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17191 Fixed bug #59071 & cs0160.cs
17193 * statement.cs (Try.Resolve): Check here whether order of catch
17194 clauses matches their dependencies.
17196 2004-05-31 Miguel de Icaza <miguel@ximian.com>
17198 * Reverted patch to namespace.cs (Use lookuptypedirect). This
17199 caused a regression: #59343. Referencing nested classes from an
17200 assembly stopped working.
17202 2004-05-31 Martin Baulig <martin@ximian.com>
17204 MCS is now frozen for beta 2.
17206 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17208 * convert.cs: add a trivial cache for overload operator resolution.
17210 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17212 * decl.cs: If possible, use lookuptypedirect here. We can only do
17213 this if there is no `.' after the namespace. Avoids using
17214 LookupType, which does lots of slow processing.
17215 (FindNestedType) New method, does what it says :-).
17216 * namespace.cs: use LookupTypeDirect.
17217 * rootcontext.cs: use membercache, if possible.
17218 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
17220 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17223 According to the spec,
17225 In a member access of the form E.I, if E is a single identifier,
17226 and if the meaning of E as a simple-name (§7.5.2) is a constant,
17227 field, property, localvariable, or parameter with the same type as
17228 the meaning of E as a type-name (§3.8), then both possible
17229 meanings of E are permitted.
17231 We did not check that E as a simple-name had the same type as E as
17234 This trivial check gives us 5-7% on bootstrap time.
17236 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17238 * expression.cs (Invocation.OverloadResolve): Avoid the
17239 use of hashtables and boxing here by allocating on demand.
17241 2004-05-30 Martin Baulig <martin@ximian.com>
17243 * rootcontext.cs (RootContext.LookupType): Don't cache things if
17244 we're doing a silent lookup. Don't try to lookup nested types in
17245 TypeManager.object_type (thanks to Ben Maurer).
17247 2004-05-30 Martin Baulig <martin@ximian.com>
17249 Committing a patch from Ben Maurer.
17251 * rootcontext.cs (RootContext.LookupType): Cache negative results.
17253 2004-05-29 Martin Baulig <martin@ximian.com>
17255 * class.cs (IMethodData.ShouldIgnore): New method.
17257 * typemanager.cs (TypeManager.MethodFlags): Don't take a
17258 `Location' argument, we don't need it anywhere. Use
17259 `IMethodData.ShouldIgnore ()' instead of
17260 `MethodData.GetMethodFlags ()'.
17261 (TypeManager.AddMethod): Removed.
17262 (TypeManager.AddMethod2): Renamed to AddMethod.
17264 2004-05-29 Martin Baulig <martin@ximian.com>
17266 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
17268 * convert.cs (Convert.ImplicitReferenceConversion): If we're
17269 converting from a class type S to an interface type and we already
17270 have an object on the stack, don't box it again. Fixes #52578.
17272 2004-05-29 Martin Baulig <martin@ximian.com>
17274 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17275 Added support for `params' parameters. Fixes #59267.
17277 2004-05-29 Martin Baulig <martin@ximian.com>
17279 * literal.cs (NullPointer): Provide a private .ctor which sets
17280 `type' to TypeManager.object_type. Fixes #59048.
17282 2004-05-29 Martin Baulig <martin@ximian.com>
17284 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
17285 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
17287 * ecore.cs (EventExpr.instance_expr): Make the field private.
17289 2004-05-26 Marek Safar <marek.safar@seznam.cz>
17291 Fixed bug #50080 & cs0214-2.cs
17292 * expression.cs (Cast.DoResolve): Check unsafe context here.
17294 * statement.cs (Resolve.DoResolve): Likewise.
17296 2004-05-26 Martin Baulig <martin@ximian.com>
17298 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
17300 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
17301 (RootContext.LookupType): Pass down the `silent' flag.
17303 2004-05-25 Martin Baulig <martin@ximian.com>
17306 (MethodGroupExpr.IdenticalTypeName): New public property.
17307 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
17308 expression actually refers to a type.
17310 2004-05-25 Martin Baulig <martin@ximian.com>
17312 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
17313 for #56176 and made it actually work.
17315 2004-05-25 Martin Baulig <martin@ximian.com>
17317 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
17318 (FieldExpr, PropertyExpr): Override and implement
17319 CacheTemporaries. Fixes #52279.
17321 2004-05-25 Miguel de Icaza <miguel@ximian.com>
17323 * location.cs: In the new compiler listing a file twice is a
17324 warning, not an error.
17326 2004-05-24 Martin Baulig <martin@ximian.com>
17328 * enum.cs (Enum.DefineType): For the `BaseType' to be a
17329 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
17331 2004-05-24 Martin Baulig <martin@ximian.com>
17333 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
17334 walking the `using' list. Fixes #53921.
17336 2004-05-24 Martin Baulig <martin@ximian.com>
17338 * const.cs (Const.LookupConstantValue): Added support for
17339 EmptyCast's; fixes #55251.
17341 2004-05-24 Martin Baulig <martin@ximian.com>
17343 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
17344 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
17345 which does the CS0135 check. The reason is that we first need to
17346 check whether the variable actually exists.
17348 2004-05-24 Martin Baulig <martin@ximian.com>
17350 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
17351 than RootContext.LookupType() to find the explicit interface
17352 type. Fixes #58584.
17354 2004-05-24 Raja R Harinath <rharinath@novell.com>
17356 * Makefile: Simplify. Use executable.make.
17357 * mcs.exe.sources: New file. List of sources of mcs.exe.
17359 2004-05-24 Anders Carlsson <andersca@gnome.org>
17363 Use the invariant culture when doing String.Compare for CLS case
17366 2004-05-23 Martin Baulig <martin@ximian.com>
17368 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
17369 don't have any dots. Fixes #52622, added cs0246-8.cs.
17371 * namespace.cs (NamespaceEntry.Lookup): Likewise.
17373 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17375 * class.cs (MemberBase.Define): Reuse MemberType member for
17376 resolved type. Other methods can use it too.
17378 2004-05-23 Martin Baulig <martin@ximian.com>
17380 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
17381 the variable also exists in the current block (otherwise, we need
17382 to report a CS0103). Fixes #58670.
17384 2004-05-23 Martin Baulig <martin@ximian.com>
17386 * flowanalysis.cs (Reachability.Reachable): Compute this
17387 on-the-fly rather than storing it as a field.
17389 2004-05-23 Martin Baulig <martin@ximian.com>
17391 * flowanalysis.cs (Reachability.And): Manually compute the
17392 resulting `barrier' from the reachability.
17394 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17397 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
17398 instance of ObsoleteAttribute when symbol is obsolete.
17401 (IMethodData): Extended interface for ObsoleteAttribute support.
17403 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17405 * attribute.cs: Fix bug #55970
17407 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17411 (GetObsoleteAttribute): New method. Creates the instance of
17413 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
17414 ObsoleteAttribute when member is obsolete.
17415 (AttributeTester.Report_ObsoleteMessage): Common method for
17416 Obsolete error/warning reporting.
17419 (TypeContainer.base_classs_type): New member for storing parent type.
17422 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
17423 for this MemberCore.
17425 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17427 * attribute.cs, const.cs: Fix bug #58590
17429 2004-05-21 Martin Baulig <martin@ximian.com>
17431 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
17432 out parameters if the end of the method is unreachable. Fixes
17435 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17437 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
17438 Hari was right, why extra method.
17440 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17442 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
17444 2004-05-20 Martin Baulig <martin@ximian.com>
17446 Merged this back from gmcs to keep the differences to a minumum.
17448 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
17449 instead of a Declspace.
17450 (Attribute.ResolveType): Likewise.
17451 (Attributes.Search): Likewise.
17452 (Attributes.Contains): Likewise.
17453 (Attributes.GetClsCompliantAttribute): Likewise.
17455 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
17457 (MethodData.ApplyAttributes): Take an EmitContext instead of a
17460 2004-05-19 Marek Safar <marek.safar@seznam.cz>
17462 Fix bug #58688 (MCS does not report error when the same attribute
17465 * attribute.cs (Attribute.Emit): Distinction between null and default.
17467 2004-05-19 Raja R Harinath <rharinath@novell.com>
17469 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
17470 of a top-level attribute without an attribute target.
17471 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
17473 (Attribute.Conditional_GetConditionName),
17474 (Attribute.Obsolete_GetObsoleteMessage): Update.
17475 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
17476 part of ScanForIndexerName.
17477 (Attribute.CanIgnoreInvalidAttribute): New function.
17478 (Attribute.ScanForIndexerName): Move to ...
17479 (Attributes.ScanForIndexerName): ... here.
17480 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
17481 (Attributes.Search): New internal variant that can choose not to
17482 complain if types aren't resolved. The original signature now
17484 (Attributes.GetClsCompliantAttribute): Use internal variant, with
17485 complaints suppressed.
17486 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
17487 only if it not useful.
17488 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
17489 top-level for attributes that are shared between the assembly
17490 and a top-level class.
17491 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
17492 * class.cs: Update to reflect changes.
17493 (DefineIndexers): Fuse loops.
17494 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
17495 a couple more variants of attribute names.
17497 2004-05-18 Marek Safar <marek.safar@seznam.cz>
17499 Fix bug #52585 (Implemented explicit attribute declaration)
17502 (Attributable.ValidAttributeTargets): New abstract method. It gets
17503 list of valid attribute targets for explicit target declaration.
17504 (Attribute.Target): It holds target itself.
17505 (AttributeSection): Removed.
17506 (Attribute.CheckTargets): New method. It checks whether attribute
17507 target is valid for the current element.
17510 (EventProperty): New class. For events that are declared like
17511 property (with add and remove accessors).
17512 (EventField): New class. For events that are declared like field.
17515 * cs-parser.jay: Implemented explicit attribute target declaration.
17517 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
17518 Override ValidAttributeTargets.
17521 (ReturnParameter): Class for applying custom attributes on
17523 (ParameterAtribute): New class. Class for applying custom
17524 attributes on the parameter type.
17526 2004-05-17 Miguel de Icaza <miguel@ximian.com>
17528 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
17531 (Method): Allow UNSAFE here.
17533 * modifiers.cs: Support unsafe reporting.
17535 2004-05-17 Marek Safar <marek.safar@seznam.cz>
17537 * decl.cs: Fix bug #58478.
17539 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17541 * statement.cs: When checking for unreachable code on an EmptyStatement,
17542 set the location. Fixes bug #58488.
17544 2004-05-13 Miguel de Icaza <miguel@ximian.com>
17546 * driver.cs: Add -pkg handling.
17548 From Gonzalo: UseShelLExecute=false
17550 2004-05-12 Marek Safar <marek.safar@seznam.cz>
17553 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
17555 (Attribute.IsClsCompliaceRequired): Moved to base for better
17557 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
17558 when attribute is AttributeUsageAttribute.
17559 (Attribute.GetValidTargets): Simplified.
17560 (Attribute.GetAttributeUsage): New method returns AttributeUsage
17561 attribute for this type.
17562 (Attribute.ApplyAttributes): Method renamed to Emit and make
17564 (GlobalAttributeSection): New class for special handling of global
17565 attributes (assembly, module).
17566 (AttributeSection.Emit): New method.
17568 * class.cs: Implemented Attributable abstract methods.
17569 (MethodCore.LabelParameters): Moved to Parameter class.
17570 (Accessor): Is back simple class.
17571 (PropertyMethod): Implemented Attributable abstract class.
17572 (DelegateMethod): Implemented Attributable abstract class.
17573 (Event): New constructor for disctintion between normal Event
17574 and Event with accessors.
17576 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
17578 * codegen.cs, const.cs, decl.cs, delegate.cs:
17579 (CommonAssemblyModulClass): Implemented Attributable abstract class
17582 * enum.cs: Implement IAttributeSupport interface.
17583 (EnumMember): New class for emum members. Implemented Attributable
17587 (ParameterBase): Is abstract.
17588 (ReturnParameter): New class for easier [return:] attribute handling.
17590 * typemanager.cs: Removed builder_to_attr.
17592 2004-05-11 Raja R Harinath <rharinath@novell.com>
17595 * attribute.cs (Attribute.GetPositionalValue): New function.
17596 * class.cs (TypeContainer.VerifyMembers): New function.
17597 (TypeContainer.Emit): Use it.
17598 (ClassOrStruct): New base class for Class and Struct.
17599 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
17600 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
17602 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
17603 then each non-static field should have a FieldOffset attribute.
17604 Otherwise, none of the fields should have a FieldOffset attribute.
17605 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
17606 and FieldOffset attributes.
17607 * typemanager.cs (TypeManager.struct_layout_attribute_type)
17608 (TypeManager.field_offset_attribute_type): New core types.
17609 (TypeManager.InitCoreTypes): Initialize them.
17611 2004-05-11 Michal Moskal <malekith@pld-linux.org>
17613 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
17614 Return correct type.
17617 2004-05-09 Miguel de Icaza <miguel@ximian.com>
17619 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
17620 be implicitly converted to ulong.
17622 * expression.cs: The logic for allowing operator &, | and ^ worked
17623 was wrong, it worked before because we did not report an error in
17624 an else branch. Fixes 57895.
17626 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
17627 allow volatile fields to be reference types.
17629 2004-05-07 Miguel de Icaza <miguel@ximian.com>
17631 * driver.cs: Add support for /debug-
17633 2004-05-07 Raja R Harinath <rharinath@novell.com>
17635 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
17636 Add a 'complain' parameter to silence errors.
17637 (Attribute.Resolve): Update to changes. Put in sanity check to catch
17638 silently overlooked type-resolutions.
17639 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
17640 to reflect changes.
17641 (Attributes.Search): New function.
17642 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
17643 (Attributes.GetAttributeFullName): Remove hack.
17644 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
17645 Update to reflect changes.
17646 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
17647 Use Attributes.Search instead of nested loops.
17649 2004-05-07 Marek Safar <marek.safar@seznam.cz>
17652 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
17653 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
17654 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
17656 * report.cs: (Report.Warning): Renamed to Warning_T because of
17657 parameter collision.
17659 2004-05-05 Raja R Harinath <rharinath@novell.com>
17661 * expression.cs (MemberAccess.ResolveMemberAccess):
17662 Exit with non-zero status after Report.Error.
17663 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
17665 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
17667 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
17669 * support.cs: Don't hang when the file is empty.
17671 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
17673 * support.cs: In SeekableStreamReader, compute the preamble size of the
17674 underlying stream. Position changes should take into account that initial
17677 2004-05-03 Todd Berman <tberman@sevenl.net>
17679 * driver.cs: remove unused GetSysVersion function.
17681 2004-05-03 Todd Berman <tberman@sevenl.net>
17683 * driver.cs: Remove the hack from saturday, as well as the hack
17684 from jackson (LoadAssemblyFromGac), also adds the CWD to the
17685 link_paths to get that bit proper.
17687 2004-05-01 Todd Berman <tberman@sevenl.net>
17689 * driver.cs: Try a LoadFrom before a Load, this checks the current
17690 path. This is currently a bug in mono that is be fixed, however, this
17691 provides a workaround for now. This will be removed when the bug
17694 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
17696 * CryptoConvert.cs: Updated to latest version. Fix issue with
17697 incomplete key pairs (#57941).
17699 2004-05-01 Todd Berman <tberman@sevenl.net>
17701 * driver.cs: Remove '.' from path_chars, now System.* loads properly
17704 2004-04-30 Jackson Harper <jackson@ximian.com>
17706 * codegen.cs: Open keys readonly.
17708 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
17710 * typemanager.cs: don't report cyclic struct layout when a struct
17711 contains 2 or more fields of the same type. Failed for Pango.AttrShape
17712 which has 2 Pango.Rectangle fields.
17714 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
17716 * expression.cs: Handle IntPtr comparisons with IL code
17717 rather than a method call.
17719 2004-04-29 Martin Baulig <martin@ximian.com>
17721 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
17722 the list of PropertyInfo's in class hierarchy and find the
17723 accessor. Fixes #56013.
17725 2004-04-29 Martin Baulig <martin@ximian.com>
17727 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
17729 2004-04-29 Martin Baulig <martin@ximian.com>
17731 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
17733 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
17735 2004-04-29 Martin Baulig <martin@ximian.com>
17737 * class.cs (ConstructorInitializer.Resolve): Check whether the
17738 parent .ctor is accessible. Fixes #52146.
17740 2004-04-29 Martin Baulig <martin@ximian.com>
17742 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
17744 * statement.cs (Using.EmitLocalVariableDecls): Use
17745 TypeManager.idisposable_type, not typeof (IDisposable).
17746 (Foreach.EmitCollectionForeach): Added support for valuetypes.
17748 2004-04-29 Martin Baulig <martin@ximian.com>
17750 * class.cs (Event.Define): Don't emit the field and don't set
17751 RTSpecialName and SpecialName for events on interfaces. Fixes
17754 2004-04-29 Raja R Harinath <rharinath@novell.com>
17756 Refactor Attribute.ApplyAttributes.
17757 * attribute.cs (Attributable): New base class for objects that can
17758 have Attributes applied on them.
17759 (Attribute): Make AttributeUsage fields public.
17760 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
17761 (Attribute.IsInternalCall): New property.
17762 (Attribute.UsageAttr): Convert to a public read-only property.
17763 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
17764 (Attribute.ResolveType, Attribute.Resolve)
17765 (Attribute.ScanForIndexerName): Update to reflect changes.
17766 (Attribute.CheckAttributeTarget): Re-format.
17767 (Attribute.ApplyAttributes): Refactor, to various
17768 Attributable.ApplyAttributeBuilder methods.
17769 * decl.cs (MemberCore): Make Attributable.
17770 * class.cs (Accessor): Make Attributable.
17771 (MethodData.ApplyAttributes): Use proper attribute types, not
17773 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
17774 (TypeContainer.ApplyAttributeBuilder)
17775 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
17776 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
17777 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
17778 (Operator.ApplyAttributeBuilder): New factored-out methods.
17779 * const.cs (Const.ApplyAttributeBuilder): Likewise.
17780 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
17781 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
17782 * parameter.cs (ParameterBase): New Attributable base class
17783 that can also represent Return types.
17784 (Parameter): Update to the changes.
17786 2004-04-29 Jackson Harper <jackson@ximian.com>
17788 * driver.cs: Prefer the corlib system version when looking for
17789 assemblies in the GAC. This is still a hack, but its a better hack
17792 2004-04-29 Marek Safar <marek.safar@seznam.cz>
17794 * decl.cs, enum.cs: Improved error 3005 reporting.
17796 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
17797 (related_symbols): New private member for list of symbols
17798 related to reported error/warning.
17800 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
17802 2004-04-29 Martin Baulig <martin@ximian.com>
17804 * ecore.cs (Expression.Constantify): If we're an enum and
17805 TypeManager.TypeToCoreType() doesn't give us another type, use
17806 t.UnderlyingSystemType. Fixes #56178.
17808 2004-04-29 Martin Baulig <martin@ximian.com>
17810 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
17811 interfaces and for each interface, only add members directly
17812 declared in that interface. Fixes #53255.
17814 2004-04-28 Martin Baulig <martin@ximian.com>
17816 * expression.cs (ConditionalLogicalOperator): Use a temporary
17817 variable for `left' to avoid that we evaluate it more than once;
17820 2004-04-28 Martin Baulig <martin@ximian.com>
17822 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
17825 2004-04-28 Martin Baulig <martin@ximian.com>
17827 * statement.cs (LocalInfo.Resolve): Check whether the type is not
17830 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
17831 whether the type is not void (CS1547).
17833 2004-04-28 Martin Baulig <martin@ximian.com>
17835 * expression.cs (Unary.DoResolveLValue): Override this and report
17836 CS0131 for anything but Operator.Indirection.
17838 2004-04-28 Martin Baulig <martin@ximian.com>
17840 Committing a patch from Ben Maurer; see bug #50820.
17842 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
17845 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
17848 2004-04-28 Martin Baulig <martin@ximian.com>
17850 Committing a patch from Ben Maurer; see bug #50820.
17852 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
17855 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
17858 2004-04-28 Martin Baulig <martin@ximian.com>
17860 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
17861 (Block.AddLabel): Call DoLookupLabel() to only search in the
17864 2004-04-28 Martin Baulig <martin@ximian.com>
17866 * cfold.cs (ConstantFold.BinaryFold): Added special support for
17867 comparing StringConstants and NullLiterals in Equality and Inequality.
17869 2004-04-28 Jackson Harper <jackson@ximian.com>
17871 * driver.cs: Attempt to load referenced assemblies from the
17872 GAC. This is the quick and dirty version of this method that
17873 doesnt take into account versions and just takes the first
17874 canidate found. Will be good enough for now as we will not have more
17875 then one version installed into the GAC until I update this method.
17877 2004-04-28 Martin Baulig <martin@ximian.com>
17879 * typemanager.cs (TypeManager.CheckStructCycles): New public
17880 static method to check for cycles in the struct layout.
17882 * rootcontext.cs (RootContext.PopulateTypes): Call
17883 TypeManager.CheckStructCycles() for each TypeContainer.
17884 [Note: We only need to visit each type once.]
17886 2004-04-28 Martin Baulig <martin@ximian.com>
17888 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
17890 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
17891 success and added `out object value'. Use a `bool resolved' field
17892 to check whether we've already been called rather than
17893 `ConstantValue != null' since this breaks for NullLiterals.
17895 2004-04-28 Raja R Harinath <rharinath@novell.com>
17897 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
17898 setting of this flag, since the 'set' method may be non-public.
17900 2004-04-28 Raja R Harinath <rharinath@novell.com>
17902 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
17903 check on current_vector.Block.
17905 2004-04-27 Martin Baulig <martin@ximian.com>
17907 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
17908 a field initializer. Fixes #56459.
17910 2004-04-27 Martin Baulig <martin@ximian.com>
17912 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
17913 we're not attempting to use an indexer. Fixes #52154.
17915 2004-04-27 Martin Baulig <martin@ximian.com>
17917 * statement.cs (Return): Don't create a return label if we don't
17918 need it; reverts my change from January 20th. Thanks to Ben
17921 2004-04-27 Martin Baulig <martin@ximian.com>
17923 According to the spec, `goto' can only leave a nested scope, but
17926 * statement.cs (Block.LookupLabel): Only lookup in the current
17927 block, don't recurse into parent or child blocks.
17928 (Block.AddLabel): Check in parent and child blocks, report
17929 CS0140/CS0158 if we find a duplicate.
17930 (Block): Removed this indexer for label lookups.
17931 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
17932 this already does the error reporting for us.
17935 (FlowBranching.UsageVector.Block): New public variable; may be null.
17936 (FlowBranching.CreateSibling): Added `Block' argument.
17937 (FlowBranching.LookupLabel): New public virtual method. Lookup a
17938 label for the target of a `goto' and check whether we're not
17939 leaving a `finally'.
17941 2004-04-27 Martin Baulig <martin@ximian.com>
17943 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17944 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
17947 2004-04-27 Martin Baulig <martin@ximian.com>
17949 * statement.cs (Block.AddLabel): Also check for implicit blocks
17950 and added a CS0158 check.
17952 2004-04-27 Martin Baulig <martin@ximian.com>
17954 * flowanalysis.cs (FlowBranchingLoop): New class.
17955 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
17956 UsageVector's instead of an ArrayList.
17957 (FlowBranching.Label): Likewise.
17958 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
17959 (FlowBranching.AddBreakVector): New method.
17961 2004-04-27 Miguel de Icaza <miguel@ximian.com>
17963 * attribute.cs: Small regression fix: only convert the type if we
17964 the type is different, fixes System.Drawing build.
17966 2004-04-27 Martin Baulig <martin@ximian.com>
17968 * attribute.cs (Attribute.Resolve): If we have a constant value
17969 for a named field or property, implicity convert it to the correct
17972 2004-04-27 Raja R Harinath <rharinath@novell.com>
17974 * statement.cs (Block.Block): Implicit blocks share
17975 'child_variable_names' fields with parent blocks.
17976 (Block.AddChildVariableNames): Remove.
17977 (Block.AddVariable): Mark variable as "used by a child block" in
17978 every surrounding block.
17979 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
17980 been used in a child block, complain about violation of "Invariant
17981 meaning in blocks" rule.
17982 * cs-parser.jay (declare_local_variables): Don't use
17983 AddChildVariableNames.
17984 (foreach_statement): Don't create an implicit block: 'foreach'
17985 introduces a scope.
17987 2004-04-23 Miguel de Icaza <miguel@ximian.com>
17989 * convert.cs (ImplicitNumericConversion): 0 is also positive when
17990 converting from 0L to ulong. Fixes 57522.
17992 2004-04-22 Marek Safar <marek.safar@seznam.cz>
17994 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
17995 derived class hides via 'new' keyword field from base class (test-242.cs).
17996 TODO: Handle this in the more general way.
17998 * class.cs (CheckBase): Ditto.
18000 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18002 * decl.cs (caching_flags): New member for storing cached values
18004 (MemberCore.Flags): New enum where bit flags for caching_flags
18006 (MemberCore.cls_compliance): Moved to caching_flags.
18007 (DeclSpace.Created): Moved to caching_flags.
18009 * class.cs: Use caching_flags instead of DeclSpace.Created
18011 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18013 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18014 if we are only a derived class, not a nested class.
18016 * typemanager.cs: Same as above, but do this at the MemberLookup
18017 level (used by field and methods, properties are handled in
18018 PropertyExpr). Allow for the qualified access if we are a nested
18021 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18023 * class.cs: Refactoring.
18024 (IMethodData): New inteface; Holds links to parent members
18025 to avoid member duplication (reduced memory allocation).
18026 (Method): Implemented IMethodData interface.
18027 (PropertyBase): New inner classes for get/set methods.
18028 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18029 (Event): New inner classes for add/remove methods.
18030 (Event.DelegateMethod): Implemented IMethodData interface.
18032 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18033 EmitContext (related to class.cs refactoring).
18035 2004-04-21 Raja R Harinath <rharinath@novell.com>
18037 * delegate.cs (Delegate.VerifyApplicability): If the number of
18038 arguments are the same as the number of parameters, first try to
18039 verify applicability ignoring any 'params' modifier on the last
18043 2004-04-16 Raja R Harinath <rharinath@novell.com>
18045 * class.cs (TypeContainer.AddIndexer): Use
18046 'ExplicitInterfaceName' to determine if interface name was
18047 explicitly specified. 'InterfaceType' is not initialized at this time.
18048 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18049 Indexers array is already in the required order. Initialize
18050 'IndexerName' only if there are normal indexers.
18051 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18052 (TypeContainer.Emit): Emit DefaultMember attribute only if
18053 IndexerName is initialized.
18056 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18058 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18061 2004-04-15 Raja R Harinath <rharinath@novell.com>
18063 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18067 * attribute.cs (Attribute.Resolve): Check for duplicate named
18071 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18073 * iterators.cs (MarkYield): track whether we are in an exception,
18074 and generate code accordingly. Use a temporary value to store the
18075 result for our state.
18077 I had ignored a bit the interaction of try/catch with iterators
18078 since their behavior was not entirely obvious, but now it is
18079 possible to verify that our behavior is the same as MS .NET 2.0
18083 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18085 * iterators.cs: Avoid creating temporaries if there is no work to
18088 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18089 Enumerations, use TypeManager.EnumToUnderlying and call
18092 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18095 (This.Emit): Use EmitContext.EmitThis to emit our
18098 (This.EmitAssign): Ditto.
18100 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18101 codepaths, we will move all the functionality into
18104 (FieldExpr.EmitAssign): Ditto.
18106 This fixes several hidden bugs that I uncovered while doing a code
18107 review of this today.
18109 * codegen.cs (EmitThis): reworked so the semantics are more clear
18110 and also support value types "this" instances.
18112 * iterators.cs: Changed so that for iterators in value types, we
18113 do not pass the value type as a parameter.
18115 Initialization of the enumerator helpers is now done in the caller
18116 instead of passing the parameters to the constructors and having
18117 the constructor set the fields.
18119 The fields have now `assembly' visibility instead of private.
18121 2004-04-11 Miguel de Icaza <miguel@ximian.com>
18123 * expression.cs (Argument.Resolve): Check if fields passed as ref
18124 or out are contained in a MarshalByRefObject.
18126 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
18127 another compiler type.
18129 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
18131 * class.cs (Indexer.Define): use the new name checking method.
18132 Also, return false on an error.
18133 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
18134 (is_identifier_[start/part]_character): make static.
18136 2004-04-10 Miguel de Icaza <miguel@ximian.com>
18138 * expression.cs (Binary.ResolveOperator): Do no append strings
18139 twice: since we can be invoked more than once (array evaluation)
18140 on the same concatenation, take care of this here. Based on a fix
18141 from Ben (bug #56454)
18143 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
18145 * codegen.cs: Fix another case where CS1548 must be reported (when
18146 delay-sign isn't specified and no private is available #56564). Fix
18147 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
18148 error when MCS is used on the MS runtime and we need to delay-sign
18149 (which seems unsupported by AssemblyBuilder - see #56621).
18151 2004-04-08 Marek Safar <marek.safar@seznam.cz>
18153 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
18154 (TypeManager.ComputeNamespaces): Faster implementation for
18157 * compiler.csproj: Updated AssemblyName to mcs.
18159 2004-04-07 Miguel de Icaza <miguel@ximian.com>
18161 * rootcontext.cs: Add new types to the boot resolution.
18163 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
18164 MulticastDelegate is not allowed.
18166 * typemanager.cs: Add new types to lookup: System.TypedReference
18169 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
18170 check for TypedReference or ArgIterator, they are not allowed.
18172 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
18173 makes us properly catch 1510 in some conditions (see bug 56016 for
18176 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
18178 * CryptoConvert.cs: update from corlib version
18181 2004-04-05 Miguel de Icaza <miguel@ximian.com>
18183 * class.cs (Indexer.Define): Check indexername declaration
18185 2004-04-05 Marek Safar <marek.safar@seznam.cz>
18187 * attribute.cs (IsClsCompliant): Fixed problem with handling
18188 all three states (compliant, not-compliant, undetected).
18190 2004-03-30 Marek Safar <marek.safar@seznam.cz>
18192 * attribute.cs (Attribute): Location is now public.
18193 (Resolve): Store resolved arguments (pos_values) in attribute class.
18194 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
18195 (GetClsCompliantAttributeValue): New method that gets
18196 CLSCompliantAttribute value.
18197 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
18198 if exists else null.
18199 (AttributeTester): New class for CLS-Compliant verification routines.
18201 * class.cs (Emit): Add CLS-Compliant verification.
18202 (Method.GetSignatureForError): Implemented.
18203 (Constructor.GetSignatureForError): Implemented
18204 (Constructor.HasCompliantArgs): Returns if constructor has
18205 CLS-Compliant arguments.
18206 (Constructor.Emit): Override.
18207 (Construcor.IsIdentifierClsCompliant): New method; For constructors
18208 is needed to test only parameters.
18209 (FieldBase.GetSignatureForError): Implemented.
18210 (TypeContainer): New member for storing base interfaces.
18211 (TypeContainer.FindMembers): Search in base interfaces too.
18213 * codegen.cs (GetClsComplianceAttribute): New method that gets
18214 assembly or module CLSCompliantAttribute value.
18215 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
18217 (ModuleClass.Emit): Add error 3012 test.
18219 * const.cs (Emit): Override and call base for CLS-Compliant tests.
18221 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
18222 state for all decl types.
18223 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
18224 if CLS-Compliant tests are required.
18225 (IsClsCompliaceRequired): New method. Analyze whether code
18226 must be CLS-Compliant.
18227 (IsExposedFromAssembly): New method. Returns true when MemberCore
18228 is exposed from assembly.
18229 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
18230 value or gets cached value.
18231 (HasClsCompliantAttribute): New method. Returns true if MemberCore
18232 is explicitly marked with CLSCompliantAttribute.
18233 (IsIdentifierClsCompliant): New abstract method. This method is
18234 used to testing error 3005.
18235 (IsIdentifierAndParamClsCompliant): New method. Common helper method
18236 for identifier and parameters CLS-Compliant testing.
18237 (VerifyClsCompliance): New method. The main virtual method for
18238 CLS-Compliant verifications.
18239 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
18240 null. I don't know why is null (too many public members !).
18241 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
18242 and get value of first CLSCompliantAttribute that found.
18244 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
18245 (VerifyClsCompliance): Override and add extra tests.
18247 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
18248 clscheck- disable CLS-Compliant verification event if assembly is has
18249 CLSCompliantAttribute(true).
18251 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
18252 ApllyAttribute is now called in emit section as in the other cases.
18253 Possible future Emit integration.
18254 (IsIdentifierClsCompliant): New override.
18255 (VerifyClsCompliance): New override.
18256 (GetEnumeratorName): Returns full enum name.
18258 * parameter.cs (GetSignatureForError): Implemented.
18260 * report.cs (WarningData): New struct for Warning message information.
18261 (LocationOfPreviousError): New method.
18262 (Warning): New method. Reports warning based on the warning table.
18263 (Error_T): New method. Reports error based on the error table.
18265 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
18266 verifications are done here.
18268 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
18270 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
18271 CLSCompliantAttribute.
18272 (all_imported_types): New member holds all imported types from other
18274 (LoadAllImportedTypes): New method fills static table with exported types
18275 from all referenced assemblies.
18276 (Modules): New property returns all assembly modules.
18278 2004-03-30 Miguel de Icaza <miguel@ximian.com>
18280 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
18281 throwing a parser error.
18283 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
18284 which removes the hardcoded get_/set_ prefixes for properties, as
18285 IL allows for the properties to be named something else.
18289 * expression.cs: Do not override operand before we know if it is
18290 non-null. Fix 56207
18292 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18294 * typemanager.cs: support for pinned variables.
18296 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18298 * decl.cs, typemanager.cs: Avoid using an arraylist
18299 as a buffer if there is only one result set.
18301 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18303 * expression.cs: Make sure you cant call a static method
18304 with an instance expression, bug #56174.
18306 2004-03-29 Miguel de Icaza <miguel@ximian.com>
18308 * class.cs (IsDuplicateImplementation): Improve error reporting to
18309 flag 663 (method only differs in parameter modifier).
18311 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
18312 in preprocessor directives.
18314 * location.cs (LookupFile): Allow for the empty path.
18316 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
18317 better approach for some of that patch, but its failing with the
18318 CharSet enumeration. For now try/catch will do.
18320 * typemanager.cs: Do not crash if a struct does not have fields.
18323 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18325 * expression.cs: cs0213, cant fix a fixed expression.
18328 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18330 * cs-parser.jay: detect invalid embeded statements gracefully.
18333 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18335 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
18338 the invocation type may not be a subclass of the tye of the item/
18339 The type of the item must be a subclass of the invocation item.
18344 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
18346 * attribute.cs: Added methods to get a string and a bool from an
18347 attribute. Required to information from AssemblyKeyFileAttribute,
18348 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
18349 * codegen.cs: Modified AssemblyName creation to include support for
18350 strongnames. Catch additional exceptions to report them as CS1548.
18351 * compiler.csproj: Updated include CryptoConvert.cs.
18352 * compiler.csproj.user: Removed file - user specific configuration.
18353 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
18354 Mono.Security assembly. The original class is maintained and tested in
18355 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
18356 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
18357 like CSC 8.0 (C# v2) supports.
18358 * Makefile: Added CryptoConvert.cs to mcs sources.
18359 * rootcontext.cs: Added new options for strongnames.
18361 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
18363 * driver.cs: For --expect-error, report error code `2'
18364 if the program compiled with no errors, error code `1' if
18365 it compiled with an error other than the one expected.
18367 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
18369 * compiler.csproj: Updated for Visual Studio .NET 2003.
18370 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
18371 * compiler.sln: Updated for Visual Studio .NET 2003.
18373 2004-03-24 Ravi Pratap M <ravi@ximian.com>
18375 * expression.cs: Fix bug #47234. We basically need to apply the
18376 rule that we prefer the conversion of null to a reference type
18377 when faced with a conversion to 'object' (csc behaviour).
18379 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18381 * statement.cs: Shorter form for foreach, eliminates
18382 a local variable. r=Martin.
18384 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18386 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
18387 checks if we can use brtrue/brfalse to test for 0.
18388 * expression.cs: use the above in the test for using brtrue/brfalse.
18389 cleanup code a bit.
18391 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18393 * expression.cs: Rewrite string concat stuff. Benefits:
18395 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
18396 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
18397 rather than a concat chain.
18399 * typemanager.cs: Add lookups for more concat overloads.
18401 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18403 * expression.cs: Emit shorter il code for array init.
18420 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
18422 * statement.cs: Before, two switch blocks would be merged if the
18423 total size of the blocks (end_item - begin_item + 1) was less than
18424 two times the combined sizes of the blocks.
18426 Now, it will only merge if after the merge at least half of the
18431 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
18433 * class.cs : csc build fix for GetMethods(). See bug #52503.
18435 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
18437 * expression.cs: Make sure fp comparisons work with NaN.
18438 This fixes bug #54303. Mig approved this patch a long
18439 time ago, but we were not able to test b/c the runtime
18442 2004-03-19 Miguel de Icaza <miguel@ximian.com>
18444 * ecore.cs (TypExpr.GetHashCode): implement this overload.
18446 2004-03-19 Martin Baulig <martin@ximian.com>
18448 * class.cs (MemberCore.IsDuplicateImplementation): Report the
18449 error here and not in our caller.
18451 2004-03-19 Martin Baulig <martin@ximian.com>
18453 * interface.cs: Completely killed this file.
18454 (Interface): We're now a TypeContainer and live in class.cs.
18456 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
18457 argument; we're now also called for interfaces.
18458 (TypeContainer.DefineMembers): Allow this method being called
18460 (TypeContainer.GetMethods): New public method; formerly known as
18461 Interface.GetMethod(). This is used by PendingImplementation.
18462 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
18463 it's now private and non-static.
18464 (Interface): Moved this here; it's now implemented similar to
18466 (Method, Property, Event, Indexer): Added `bool is_interface'
18467 argument to their .ctor's.
18468 (MemberBase.IsInterface): New public field.
18470 * cs-parser.jay: Create normal Method, Property, Event, Indexer
18471 instances instead of InterfaceMethod, InterfaceProperty, etc.
18472 (opt_interface_base): Removed; we now use `opt_class_base' instead.
18473 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
18475 2004-03-19 Martin Baulig <martin@ximian.com>
18477 * class.cs (MethodCore.IsDuplicateImplementation): New private
18478 method which does the CS0111 checking.
18479 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
18480 Use IsDuplicateImplementation().
18482 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
18484 * decl.cs (FindMemberToOverride): New method to find the correct
18485 method or property to override in the base class.
18487 - Make Method/Property use the above method to find the
18488 version in the base class.
18489 - Remove the InheritableMemberSignatureCompare as it is now
18492 This patch makes large code bases much faster to compile, as it is
18493 O(n) rather than O(n^2) to do this validation.
18495 Also, it fixes bug 52458 which is that nested classes are not
18496 taken into account when finding the base class member.
18498 Reviewed/Approved by Martin.
18500 2004-03-17 Marek Safar <marek.safar@seznam.cz>
18502 * interface.cs: In all interface classes removed redundant
18503 member initialization.
18505 2004-03-16 Martin Baulig <martin@ximian.com>
18507 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
18509 2004-03-15 Miguel de Icaza <miguel@ximian.com>
18511 * decl.cs (DefineTypeAndParents): New helper method to define a
18512 type's containers before the type itself is defined; This is a
18513 bug exposed by the recent changes to Windows.Forms when an
18514 implemented interface was defined inside a class that had not been
18517 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
18519 (Check): Loop correctly to report errors modifiers
18520 (UNSAFE was not in the loop, since it was the same as TOP).
18522 * interface.cs: Every interface member now takes a ModFlags,
18523 instead of a "is_new" bool, which we set on the base MemberCore.
18525 Every place where we called "UnsafeOk" in the interface, now we
18526 call the proper member (InterfaceMethod.UnsafeOK) instead to get
18527 the unsafe settings from the member declaration instead of the
18528 container interface.
18530 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
18532 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
18533 `set_indexer_name' to the pending bits (one per type).
18535 We fixed a bug today that was picking the wrong method to
18536 override, since for properties the existing InterfaceMethod code
18537 basically ignored the method name. Now we make sure that the
18538 method name is one of the valid indexer names.
18540 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
18542 * support.cs (SeekableStreamReader): Keep track of stream byte
18543 positions and don't mix them with character offsets to the buffer.
18545 Patch from Gustavo Giráldez
18547 2004-03-15 Marek Safar <marek.safar@seznam.cz>
18549 * interface.cs (InterfaceSetGetBase): Removed double member
18550 initialization, base class does it as well.
18552 2004-03-13 Martin Baulig <martin@ximian.com>
18554 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
18555 when compiling corlib.
18557 2004-03-13 Miguel de Icaza <miguel@ximian.com>
18559 * convert.cs (ExplicitConversion): We were reporting an error on
18560 certain conversions (object_type source to a value type, when the
18561 expression was `null') before we had a chance to pass it through
18562 the user defined conversions.
18564 * driver.cs: Replace / and \ in resource specifications to dots.
18567 * class.cs: Add check for duplicate operators. Fixes 52477
18569 2004-03-11 Miguel de Icaza <miguel@ximian.com>
18571 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
18572 that are in the middle of the statements, not only at the end.
18575 * class.cs (TypeContainer.AddField): No longer set the
18576 `HaveStaticConstructor' flag, now we call it
18577 `UserDefineStaticConstructor' to diferentiate the slightly
18578 semantic difference.
18580 The situation is that we were not adding BeforeFieldInit (from
18581 Modifiers.TypeAttr) to classes that could have it.
18582 BeforeFieldInit should be set to classes that have no static
18587 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
18589 And most importantly Zoltan's comment:
18591 http://bugzilla.ximian.com/show_bug.cgi?id=44229
18593 "I think beforefieldinit means 'it's ok to initialize the type sometime
18594 before its static fields are used', i.e. initialization does not need
18595 to be triggered by the first access to the type. Setting this flag
18596 helps the JIT to compile better code, since it can run the static
18597 constructor at JIT time, and does not need to generate code to call it
18598 (possibly lots of times) at runtime. Unfortunately, mcs does not set
18599 this flag for lots of classes like String.
18601 csc sets this flag if the type does not have an explicit static
18602 constructor. The reasoning seems to be that if there are only static
18603 initalizers for a type, and no static constructor, then the programmer
18604 does not care when this initialization happens, so beforefieldinit
18607 This bug prevents the AOT compiler from being usable, since it
18608 generates so many calls to mono_runtime_class_init that the AOT code
18609 is much slower than the JITted code. The JITted code is faster,
18610 because it does not generate these calls if the vtable is type is
18611 already initialized, which is true in the majority of cases. But the
18612 AOT compiler can't do this."
18614 2004-03-10 Miguel de Icaza <miguel@ximian.com>
18616 * class.cs (MethodData.Emit): Refactor the code so symbolic
18617 information is generated for destructors; For some reasons we
18618 were taking a code path that did not generate symbolic information
18621 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
18623 * class.cs: Create a Constructor.CheckBase method that
18624 takes care of all validation type code. The method
18625 contains some code that was moved from Define.
18627 It also includes new code that checks for duplicate ctors.
18628 This fixes bug #55148.
18630 2004-03-09 Joshua Tauberer <tauberer@for.net>
18632 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
18633 a { ... }-style array creation invokes EmitStaticInitializers
18634 which is not good for reference-type arrays. String, decimal
18635 and now null constants (NullCast) are not counted toward
18636 static initializers.
18638 2004-03-05 Martin Baulig <martin@ximian.com>
18640 * location.cs (SourceFile.HasLineDirective): New public field;
18641 specifies whether the file contains or is referenced by a "#line"
18643 (Location.DefineSymbolDocuments): Ignore source files which
18644 either contain or are referenced by a "#line" directive.
18646 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
18648 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
18649 direct access to our parent, so check the method inline there.
18651 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
18653 * expression.cs (Invocation.EmitCall): Miguel's last commit
18654 caused a regression. If you had:
18659 In Foo the implict this would be null.
18661 2004-02-27 Miguel de Icaza <miguel@ximian.com>
18663 * expression.cs (Invocation.EmitCall): If the method is not
18664 virtual, do not emit a CallVirt to it, use Call.
18666 * typemanager.cs (GetFullNameSignature): Improve the method to
18667 cope with ".ctor" and replace it with the type name.
18669 * class.cs (ConstructorInitializer.Resolve): Now the method takes
18670 as an argument the ConstructorBuilder where it is being defined,
18671 to catch the recursive constructor invocations.
18673 2004-02-26 Miguel de Icaza <miguel@ximian.com>
18675 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
18676 routines to check if a type is an enumerable/enumerator allow
18677 classes that implement the IEnumerable or IEnumerator interfaces.
18679 * class.cs (Property, Operator): Implement IIteratorContainer, and
18680 implement SetYields.
18682 (Property.Define): Do the block swapping for get_methods in the
18683 context of iterators. We need to check if Properties also
18684 include indexers or not.
18686 (Operator): Assign the Block before invoking the
18687 OperatorMethod.Define, so we can trigger the Iterator code
18690 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
18691 Property and Operator classes are not created when we parse the
18692 declarator but until we have the block completed, so we use a
18693 singleton SimpleIteratorContainer.Simple to flag whether the
18694 SetYields has been invoked.
18696 We propagate this setting then to the Property or the Operator to
18697 allow the `yield' to function.
18699 2004-02-25 Marek Safar <marek.safar@seznam.cz>
18701 * codegen.cs: Implemented attribute support for modules.
18702 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
18703 Assembly/Module functionality.
18705 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
18706 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
18707 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
18709 2004-02-16 Marek Safar <marek.safar@seznam.cz>
18711 * interface.cs (FindMembers): The operation is performed on all base
18712 interfaces and not only on the first. It is required for future CLS Compliance patch.
18714 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
18716 * statement.cs, codegen.cs:
18717 This patch deals with patterns such as:
18719 public class List : IEnumerable {
18721 public MyEnumerator GetEnumerator () {
18722 return new MyEnumerator(this);
18725 IEnumerator IEnumerable.GetEnumerator () {
18729 public struct MyEnumerator : IEnumerator {
18734 Before, there were a few things we did wrong:
18735 1) we would emit callvirt on a struct, which is illegal
18736 2) we emited ldarg when we needed to emit ldarga
18737 3) we would mistakenly call the interface methods on an enumerator
18738 type that derived from IEnumerator and was in another assembly. For example:
18740 public class MyEnumerator : IEnumerator
18742 Would have the interface methods called, even if there were public impls of the
18743 method. In a struct, this lead to invalid IL code.
18745 2004-02-11 Marek Safar <marek.safar@seznam.cz>
18747 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
18750 * delegate.cs (Define): Fixed crash when delegate type is undefined.
18752 2004-02-11 Miguel de Icaza <miguel@ximian.com>
18754 * cs-parser.jay: Fix small regression: we were not testing V2
18755 compiler features correctly.
18757 * interface.cs: If the emit context is null, then create one
18759 2004-02-09 Marek Safar <marek.safar@seznam.cz>
18761 * decl.cs (GetSignatureForError): New virtual method to get full name
18762 for error messages.
18764 * attribute.cs (IAttributeSupport): New interface for attribute setting.
18765 Now it is possible to rewrite ApplyAttributes method to be less if/else.
18767 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
18768 Duplicated members and code in these classes has been removed.
18769 Better encapsulation in these classes.
18771 2004-02-07 Miguel de Icaza <miguel@ximian.com>
18773 * assign.cs (Assign.DoResolve): When dealing with compound
18774 assignments, there is a new rule in ECMA C# 2.4 (might have been
18775 there before, but it is documented here) that states that in:
18779 If b is of type int, and the `op' is a shift-operator, then the
18780 above is evaluated as:
18784 * expression.cs (Binary.ResolveOperator): Instead of testing for
18785 int/uint/long/ulong, try to implicitly convert to any of those
18786 types and use that in pointer arithmetic.
18788 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
18789 method to print information for from the type, not from the
18790 null-method we were given.
18792 2004-02-01 Duncan Mak <duncan@ximian.com>
18794 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
18795 parsing for cmd, fixes bug #53694.
18797 2004-02-04 Marek Safar <marek.safar@seznam.cz>
18799 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
18800 in the member name duplication tests. Property and operator name duplication
18801 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
18803 2004-02-03 Marek Safar <marek.safar@seznam.cz>
18805 * interface.cs (PopulateMethod): Fixed crash when interface method
18806 returns not existing type (error test cs0246-3.cs).
18808 2004-02-02 Ravi Pratap M <ravi@ximian.com>
18810 * cs-parser.jay (interface_accessors): Re-write actions to also
18811 store attributes attached to get and set methods. Fix spelling
18814 (inteface_property_declaration): Modify accordingly.
18816 (InterfaceAccessorInfo): New helper class to store information to pass
18817 around between rules that use interface_accessors.
18819 * interface.cs (Emit): Apply attributes on the get and set
18820 accessors of properties and indexers too.
18822 * attribute.cs (ApplyAttributes): Modify accordingly to use the
18823 right MethodBuilder when applying attributes to the get and set accessors.
18825 2004-01-31 Miguel de Icaza <miguel@ximian.com>
18827 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
18829 2004-01-26 Miguel de Icaza <miguel@ximian.com>
18831 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
18833 2004-01-25 Miguel de Icaza <miguel@ximian.com>
18835 * cs-parser.jay: Remove YIELD token, instead use the new grammar
18836 changes that treat `yield' specially when present before `break'
18837 or `return' tokens.
18839 * cs-tokenizer.cs: yield is no longer a keyword.
18841 2004-01-23 Marek Safar <marek.safar@seznam.cz>
18843 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
18844 setting for default constructors.
18845 For default constructors are almost every time set wrong Modifier. The
18846 generated IL code has been alright. But inside mcs this values was
18847 wrong and this was reason why several of my CLS Compliance tests
18850 2004-01-22 Martin Baulig <martin@ximian.com>
18852 * cs-parser.jay (namespace_or_type_name): Return an Expression,
18853 not a QualifiedIdentifier. This is what `type_name_expression'
18854 was previously doing.
18855 (type_name_expression): Removed; the code is now in
18856 `namespace_or_type_name'.
18857 (qualified_identifier): Removed, use `namespace_or_type_name'
18859 (QualifiedIdentifier): Removed this class.
18861 2004-01-22 Martin Baulig <martin@ximian.com>
18863 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
18864 not a string as alias name.
18866 2004-01-21 Miguel de Icaza <miguel@ximian.com>
18868 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
18869 #52730 bug, and instead compute correctly the need to use a
18870 temporary variable when requesting an address based on the
18871 static/instace modified of the field and the constructor.
18873 2004-01-21 Martin Baulig <martin@ximian.com>
18875 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
18876 class and namespace before looking up aliases. Fixes #52517.
18878 2004-01-21 Martin Baulig <martin@ximian.com>
18880 * flowanalysis.cs (UsageVector.Merge): Allow variables being
18881 assinged in a 'try'; fixes exception4.cs.
18883 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18884 * class.cs : Implemented parameter-less constructor for TypeContainer
18886 * decl.cs: Attributes are now stored here. New property OptAttributes
18888 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
18890 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
18892 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18894 * typemanager.cs (CSharpSignature): Now reports also inner class name.
18895 (CSharpSignature): New method for indexer and property signature.
18897 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18899 * pending.cs (IsVirtualFilter): Faster implementation.
18901 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18903 * typemanager.cs: Avoid inclusion of same assembly more than once.
18905 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18907 * cs-parser.jay: Fixed problem where the last assembly attribute
18908 has been applied also to following declaration (class, struct, etc.)
18910 2004-01-21 Marek Safar <marek.safar@seznam.cz>
18912 * class.cs: Added error CS0538, CS0539 reporting.
18913 Fixed crash on Microsoft runtime when field type is void.
18915 * cs-parser.jay: Added error CS0537 reporting.
18917 * pending.cs: Added error CS0535 reporting.
18918 Improved error report for errors CS0536, CS0534.
18920 2004-01-20 Miguel de Icaza <miguel@ximian.com>
18922 Merge a few bits from the Anonymous Method MCS tree.
18924 * statement.cs (ToplevelBlock): New class for toplevel methods,
18925 will hold anonymous methods, lifted variables.
18927 * cs-parser.jay: Create toplevel blocks for delegates and for
18928 regular blocks of code.
18930 2004-01-20 Martin Baulig <martin@ximian.com>
18932 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
18933 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
18934 and `NeedExplicitReturn'; added `IsLastStatement'.
18935 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
18936 have a `ReturnLabel' or we're not unreachable.
18938 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
18939 child's reachability; don't just override ours with it. Fixes
18940 #58058 (lluis's example).
18941 (FlowBranching): Added public InTryOrCatch(), InCatch(),
18942 InFinally(), InLoop(), InSwitch() and
18943 BreakCrossesTryCatchBoundary() methods.
18945 * statement.cs (Return): Do all error checking in Resolve().
18946 Unless we are the last statement in a top-level block, always
18947 create a return label and jump to it.
18948 (Break, Continue): Do all error checking in Resolve(); also make
18949 sure we aren't leaving a `finally'.
18950 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
18951 statement in a top-level block.
18952 (Block.Flags): Added `IsDestructor'.
18953 (Block.IsDestructor): New public property.
18955 2004-01-20 Martin Baulig <martin@ximian.com>
18957 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
18959 2004-01-20 Martin Baulig <martin@ximian.com>
18961 * statement.cs (Statement.ResolveUnreachable): New public method.
18962 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
18963 (Block.Resolve): Resolve unreachable statements.
18965 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
18967 * expression.cs: We need to fix the case where we do
18968 not have a temp variable here.
18970 * assign.cs: Only expression compound assignments need
18971 temporary variables.
18973 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
18975 * flowanalysis.cs: Reduce memory allocation in a few ways:
18976 - A block with no variables should not allocate a bit
18978 - A method with no out parameters does not need any tracking
18979 for assignment of the parameters, so we need not allocate
18982 public readonly Type[] VariableTypes;
18983 public readonly string[] VariableNames;
18984 Are redundant. The data is already stored in the variable
18985 map, so we need not allocate another array for it.
18986 - We need to add alot of checks for if (params | locals) == null
18987 due to the first two changes.
18989 2004-01-18 Miguel de Icaza <miguel@ximian.com>
18991 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
18992 implement IMemoryLocation, we store a copy on a local variable and
18993 take the address of it. Patch from Benjamin Jemlich
18995 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
18996 to use a special "type_name_expression" rule which reduces the
18997 number of "QualifiedIdentifier" classes created, and instead
18998 directly creates MemberAccess expressions.
19000 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19002 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19003 that fixes #52853. Null literal assignment to ValueType
19005 * class.cs (MethodData.Emit): Instead of checking the name of the
19006 method to determine if its a destructor, create a new derived
19007 class from Method called Destructor, and test for that.
19009 * cs-parser.jay: Create a Destructor object instead of a Method.
19011 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19015 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19017 * expression.cs (Binary.ResolveOperator): Perform an implicit
19018 conversion from MethodGroups to their delegate types on the
19019 Addition operation.
19021 * delegate.cs: Introduce a new class DelegateCreation that is the
19022 base class for `NewDelegate' and `ImplicitDelegateCreation',
19023 factor some code in here.
19025 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19026 conversion from MethodGroups to compatible delegate types.
19028 * ecore.cs (Expression.Resolve): Do not flag error 654
19029 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19030 we allow conversions from MethodGroups to delegate types now.
19032 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19033 assignments in v2 either.
19035 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19037 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19038 static read-only fields in ctors.
19040 Applied patch from Benjamin Jemlich
19042 * expression.cs (UnaryMutator): Avoid leaking local variables.
19044 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19046 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19047 here to return true, as they can be used like this:
19049 (XXX) int.MEMBER ()
19051 Fixed 49836 and all the other dups
19053 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19055 * driver.cs: Implement /win32res and /win32icon.
19057 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19059 * cs-parser.jay: Add a rule to improve error handling for the
19060 common mistake of placing modifiers after the type.
19062 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19064 * cs-parser.jay (interface_event_declaration): Catch
19065 initialization of events on interfaces, and report cs0068
19067 * cs-parser.jay (interface_event_declaration): Catch
19068 initialization of events.
19070 * ecore.cs: Better report missing constructors.
19072 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19073 the error reporting done in the wrong place. Fix.
19075 * expression.cs (Binary.ResolveOperator): Catch the
19076 operator + (E x, E y) error earlier, and later allow for implicit
19077 conversions in operator +/- (E e, U x) from U to the underlying
19080 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19081 52596, if the container class is abstract, the default constructor
19082 is protected otherwise its public (before, we were always public).
19084 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19087 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19088 Jemlich that fixes bug #52597, MCS was generating invalid code for
19089 idisposable structs. Thanks to Ben for following up with this
19092 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19094 * driver.cs: Allow assemblies without code to be generated, fixes
19097 2004-01-07 Nick Drochak <ndrochak@gol.com>
19099 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19101 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19103 * cs-parser.jay: Add rules to improve error reporting if fields or
19104 methods are declared at the namespace level (error 116)
19106 * Add rules to catch event add/remove
19108 2004-01-04 David Sheldon <dave-mono@earth.li>
19110 * expression.cs: Added matching ")" to error message for
19113 2004-01-03 Todd Berman <tberman@gentoo.org>
19115 * ecore.cs, attribute.cs:
19116 Applying fix from #52429.
19118 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19120 * ecore.cs, expression.cs, statement.cs:
19121 Total rewrite of how we handle branching. We
19122 now handle complex boolean expressions with fewer
19123 jumps. As well if (x == 0) no longer emits a ceq.
19125 if (x is Foo) is much faster now, because we generate
19128 Overall, we get a pretty big improvement on our benchmark
19129 tests. The code we generate is smaller and more readable.
19131 I did a full two-stage bootstrap. The patch was reviewed
19132 by Martin and Miguel.
19134 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19136 * cs-parser.jay: Make primary_expression not take a QI.
19137 we dont need this because the member_access rule covers
19138 us here. So we replace the rule with just IDENTIFIER.
19140 This has two good effects. First, we remove a s/r conflict.
19141 Second, we allocate many fewer QualifiedIdentifier objects.
19143 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19145 * attribute.cs: Handle MarshalAs attributes as pseudo, and
19146 set the correct information via SRE. This prevents
19147 hanging on the MS runtime. Fixes #29374.
19149 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19151 * convert.cs: correctly handle conversions to value types
19152 from Enum and ValueType as unboxing conversions.
19154 Fixes bug #52569. Patch by Benjamin Jemlich.
19156 2004-01-02 Ravi Pratap <ravi@ximian.com>
19158 * expression.cs (BetterConversion): Prefer int -> uint
19159 over int -> ulong (csc's behaviour). This fixed bug #52046.
19161 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
19163 * decl.cs (MemberCache.FindMembers): now returns a
19166 * typemanager.cs: In general, go with with ^^.
19167 (CopyNewMethods): take an IList.
19168 (RealMemberLookup): Only allocate an arraylist
19169 if we copy from two sets of methods.
19171 This change basically does two things:
19172 1) Fewer array lists allocated due to CopyNewMethods.
19173 2) the explicit cast in MemberList costed ALOT.
19175 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
19177 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
19178 a hashtable to avoid needless string allocations when an identifier is
19179 used more than once (the common case).
19181 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19183 * pending.cs: MS's TypeBuilder.GetInterfaces ()
19184 is broken, it will not return anything. So, we
19185 have to use the information we have in mcs to
19188 * typemanager.cs: Add a cache for GetInterfaces,
19189 since this will now be used more often (due to ^^)
19191 (GetExplicitInterfaces) New method that gets the
19192 declared, not effective, interfaces on a type
19193 builder (eg, if you have interface IFoo, interface
19194 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
19197 This patch makes MCS able to bootstrap itself on
19200 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19202 * expression.cs: Remove the Nop's that Miguel put
19205 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19207 * report.cs, codegen.cs: Give the real stack trace to
19208 the error when an exception is thrown.
19210 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19212 * decl.cs: only allocate hashtables for ifaces if
19215 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19217 * expression.cs: fix the error from cs0121-2.cs
19218 (a parent interface has two child interfaces that
19219 have a function with the same name and 0 params
19220 and the function is called through the parent).
19222 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
19224 * class.cs, rootcontext.cs, typmanager.cs: do not
19227 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
19229 * codegen.cs: remove stack for the ec flow branching.
19230 It is already a linked list, so no need.
19232 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
19234 * Makefile: Allow custom profiler here.
19236 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19238 * typemanager.cs (LookupType):
19239 - Use a static char [], because split takes
19240 a param array for args, so it was allocating
19242 - Do not store true in a hashtable, it boxes.
19244 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19246 * flowanalysis.cs: bytify common enums.
19248 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19250 * modifiers.cs: Add a new set of flags for the
19251 flags allowed on explicit interface impls.
19252 * cs-parser.jay: catch the use of modifiers in
19253 interfaces correctly.
19254 * class.cs: catch private void IFoo.Blah ().
19256 All related to bug #50572.
19258 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19260 * decl.cs: Rewrite the consistant accessability checking.
19261 Accessability is not linear, it must be implemented in
19262 a tableish way. Fixes #49704.
19264 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19266 * expression.cs: Handle negation in a checked context.
19267 We must use subtraction from zero. Fixes #38674.
19269 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19271 * class.cs: Ignore static void main in DLLs.
19272 * rootcontext.cs: Handle the target type here,
19273 since we are have to access it from class.cs
19274 * driver.cs: account for the above.
19276 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19278 * report.cs: Give line numbers and files if available.
19280 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
19282 * driver.cs: Implement /addmodule.
19284 * typemanager.cs: Change 'modules' field so it now contains Modules not
19287 2003-12-20 Martin Baulig <martin@ximian.com>
19289 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
19290 (FieldBase.IsAssigned): Removed this field.
19291 (FieldBase.SetAssigned): New public method.
19292 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
19294 2003-12-20 Martin Baulig <martin@ximian.com>
19296 * expression.cs (LocalVariableReference.DoResolve): Don't set
19297 `vi.Used' if we're called from DoResolveLValue().
19299 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
19300 returns the usage vector it just merged into the current one -
19301 pass this one to UsageWarning().
19302 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
19303 of the `EmitContext', don't call this recursively on our children.
19305 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
19307 * driver.cs: Implement /target:module.
19309 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
19311 * support.cs (CharArrayHashtable): New helper class.
19313 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
19314 char arrays, not strings, so we can avoid creating a string in
19315 consume_identifier if the identifier is a keyword.
19317 2003-12-16 Martin Baulig <martin@ximian.com>
19319 * statement.cs (LocalInfo.Assigned): Removed this property.
19320 (LocalInfo.Flags): Removed `Assigned'.
19321 (LocalInfo.IsAssigned): New public method; takes the EmitContext
19322 and uses flow analysis.
19323 (Block.UsageWarning): Made this method private.
19324 (Block.Resolve): Call UsageWarning() if appropriate.
19326 * expression.cs (LocalVariableReference.DoResolve): Always set
19327 LocalInfo.Used here.
19329 2003-12-13 Martin Baulig <martin@ximian.com>
19331 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
19332 any value here; we're now using flow analysis to figure out
19333 whether a statement/block returns a value.
19335 2003-12-13 Martin Baulig <martin@ximian.com>
19337 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
19339 (FlowBranching.MergeFinally): Don't call
19340 `branching.CheckOutParameters()' here, this is called in
19342 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
19343 when adding the `finally' vector.
19345 2003-12-13 Martin Baulig <martin@ximian.com>
19348 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
19349 actually work and also fix #48962.
19351 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
19353 * decl.cs: Do not check System.Object for nested types,
19354 since we know it does not have any. Big bang for buck:
19357 Run 1: 8.35 seconds
19358 Run 2: 8.32 seconds
19359 corlib: 17.99 seconds
19361 Run 1: 8.17 seconds
19362 Run 2: 8.17 seconds
19363 corlib: 17.39 seconds
19365 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
19367 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
19368 time we are returning 0 members, so we save alot here.
19370 2003-12-11 Martin Baulig <martin@ximian.com>
19372 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
19373 `MergeChild()', also just take the `FlowBranching' as argument;
19374 call Merge() on it and return the result.
19375 (FlowBranching.Merge): We don't need to do anything if we just
19378 2003-12-11 Martin Baulig <martin@ximian.com>
19380 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
19381 them in an `ArrayList' to reduce memory usage. Thanks to Ben
19382 Maurer for this idea.
19384 2003-12-11 Martin Baulig <martin@ximian.com>
19386 * flowanalysis.cs (MergeResult): This class is now gone; we now
19387 use the `UsageVector' for this. The reason for this is that if a
19388 branching just has one sibling, we don't need to "merge" them at
19389 all - that's the next step to do.
19390 (FlowBranching.Merge): We now return a `UsageVector' instead of a
19393 2003-12-11 Martin Baulig <martin@ximian.com>
19395 Reworked flow analyis and made it more precise and bug-free. The
19396 most important change is that we're now using a special `Reachability'
19397 class instead of having "magic" meanings of `FlowReturns'. I'll
19398 do some more cleanups and optimizations and also add some more
19399 documentation this week.
19401 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
19402 largely reworked this class.
19403 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
19404 the new `Reachability' class instead of having "magic" values here.
19405 (FlowBranching): We're now using an instance of `Reachability'
19406 instead of having separate `Returns', `Breaks' etc. fields.
19408 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
19409 based on flow analysis; ignore the return value of block.Emit ().
19411 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
19413 * driver.cs typemanager.cs: Find the mono extensions to corlib even
19414 if they are private.
19416 2003-12-09 Martin Baulig <martin@ximian.com>
19418 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
19419 call them directly on the UsageVector.
19421 2003-12-09 Martin Baulig <martin@ximian.com>
19423 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
19424 Changed return type from `FlowReturns' to `Reachability'.
19426 2003-12-09 Martin Baulig <martin@ximian.com>
19428 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
19429 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
19430 `Reachable' fields with a single `Reachability' one.
19432 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19434 * class.cs (FindMembers): Remove foreach's.
19439 Run 1: 8.74 seconds
19440 Run 2: 8.71 seconds
19443 Run 1: 8.64 seconds
19444 Run 2: 8.58 seconds
19447 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19452 This patch does a few things:
19453 1. EmptyStatement is now a singleton, so it is never reallocated.
19454 2. All blah is EmptyStatement constructs have been changed to
19455 blah == EmptyStatement.Value, which is much faster and valid
19456 now that EmptyStatement is a singleton.
19457 3. When resolving a block, rather than allocating a new array for
19458 the non-empty statements, empty statements are replaced with
19459 EmptyStatement.Value
19460 4. Some recursive functions have been made non-recursive.
19461 Mainly the performance impact is from (3), however (1) and (2) are needed for
19462 this to work. (4) does not make a big difference in normal situations, however
19463 it makes the profile look saner.
19468 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
19469 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
19470 Total memory allocated: 56397 KB
19473 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
19474 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
19475 Total memory allocated: 55666 KB
19477 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19479 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
19480 than the hashtable in a hashtable version
19482 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
19483 we always end up concating a string. This results in a huge perf
19484 loss, because many strings have to be tracked by the GC. In this
19485 patch, we first use a hashtable that works with two keys, so that
19486 the strings do not need to be concat'ed.
19490 Run 1: 8.74 seconds
19491 Run 2: 8.71 seconds
19494 Run 1: 8.65 seconds
19495 Run 2: 8.56 seconds
19497 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19499 * Makefile: Add a new target `do-time' that does a quick and simple
19500 profile, leaving easy to parse output.
19502 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
19504 * codegen.cs (Init): Create the dynamic assembly with
19505 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
19507 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
19509 * support.cs: Make the PtrHashtable use only one
19510 instance of its comparer.
19512 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
19514 * typemanager.cs: Fix lookup of GetNamespaces.
19516 2003-11-29 Miguel de Icaza <miguel@ximian.com>
19518 * expression.cs: Removed redundant line.
19520 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
19521 ArrayLists, use for loops with bounds.
19523 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
19526 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
19527 arraylists, use for loop with bounds.
19529 The above three changes give us a 0.071 second performance
19530 improvement out of 3.294 seconds down to 3.223. On my machine
19531 the above changes reduced the memory usage by 1,387 KB during
19532 compiler bootstrap.
19534 * cs-parser.jay (QualifiedIdentifier): New class used to represent
19535 QualifiedIdentifiers. Before we created a new string through
19536 concatenation, and mostly later on, the result would be
19537 manipulated by DecomposeQI through string manipulation.
19539 This reduced the compiler memory usage for bootstrapping from
19540 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
19541 compile times in 0.05 seconds.
19543 2003-11-28 Dick Porter <dick@ximian.com>
19545 * support.cs: Do string compares with the Invariant culture.
19553 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
19554 the comparison is done with the Invariant culture.
19556 2003-11-27 Miguel de Icaza <miguel@ximian.com>
19558 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
19559 GetEnumerator method.
19561 (ProbeCollectionType): Iterate starting at the most specific type
19562 upwards looking for a GetEnumerator
19564 * expression.cs: Shift count can be up to 31 for int/uint and 63
19567 2003-11-26 Miguel de Icaza <miguel@ximian.com>
19569 * statement.cs (Block.LookupLabel): Also look for the label on the
19570 children blocks. Use a hash table to keep track of visited
19573 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
19574 we actually did transform the other operand, otherwise fall back
19575 to the common codepath that casts to long.
19577 * cs-tokenizer.cs: Use the same code pattern as the int case.
19578 Maybe I should do the parsing myself, and avoid depending on the
19579 Parse routines to get this done.
19581 2003-11-25 Miguel de Icaza <miguel@ximian.com>
19583 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
19584 which fixes bug 51347. This time test it.
19586 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
19587 attributes for example can not tell the difference between these.
19588 The difference was only a syntax feature of the language.
19590 * attribute.cs: Apply attributes to delegates.
19592 * delegate.cs: Call the apply attributes method.
19594 2003-11-24 Miguel de Icaza <miguel@ximian.com>
19596 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
19597 comparing 0 vs Byte.MinValue, not the value
19599 (ImplicitConversionRequired): When reporting a conversion error,
19600 use error 31 to print out the constant error instead of the
19603 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
19604 which fixes bug 51347.
19606 2003-11-22 Miguel de Icaza <miguel@ximian.com>
19608 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
19609 which fixes the -warnaserror command line option.
19611 2003-11-21 Miguel de Icaza <miguel@ximian.com>
19613 * cfold.cs (DoNumericPromotions): During constant folding of
19614 additions on UIntConstant, special case intconstants with
19615 IntConstants like we do on the expression binary operator.
19617 2003-11-12 Miguel de Icaza <miguel@ximian.com>
19619 * convert.cs (ImplicitReferenceConversion): We were missing a case
19620 (System.Enum are not value types or class types, so we need to
19621 classify them separatedly).
19623 * driver.cs: We do not support error 2007.
19625 2003-11-12 Jackson Harper <jackson@ximian.com>
19627 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
19628 system directory. Also use the full file name so users can
19629 libraries names mscorlib-o-tron.dll in a non system dir.
19631 2003-11-10 Martin Baulig <martin@ximian.com>
19633 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
19634 (TypeManager.InitCoreTypes): Initialize them here, but instead of
19635 calling `ResolveType()' on them, directly assign their `Type'.
19637 2003-11-08 Martin Baulig <martin@ximian.com>
19639 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
19640 return value and the `out parent' parameter.
19641 (TypeContainer.DefineType): Moved the CS0644 check into
19642 GetClassBases(). Don't pass the interface types to the
19643 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
19644 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
19646 * ecore.cs (TypeExpr.IsAttribute): New property.
19647 (TypeExpr.GetInterfaces): New method.
19649 * interface.cs (Interface.GetInterfaceTypeByName): Return a
19650 TypeExpr instead of a Type.
19651 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
19652 (Interface.DefineType): Don't pass the interface types to the
19653 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
19654 them later and then call `TypeBulider.AddInterfaceImplementation()'.
19656 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
19657 instead of a `Type[]'.
19658 (TypeManager.RegisterBuilder): Likewise.
19659 (TypeManager.AddUserInterface): Likewise.
19660 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
19661 `Type[]' and also return a `TypeExpr[]'.
19662 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
19664 2003-11-08 Martin Baulig <martin@ximian.com>
19666 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
19669 2003-11-08 Martin Baulig <martin@ximian.com>
19671 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
19672 TypeManager.ResolveExpressionTypes().
19674 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
19675 instead of an Expression.
19676 (TypeExpr): This is now an abstract base class for `TypeExpression'.
19677 (TypeExpression): New public class; formerly known as `TypeExpr'.
19679 * expression.cs (ComposedCast): Derive from TypeExpr.
19681 * typemanager.cs (TypeManager.system_*_expr): These are now
19682 TypExpr's instead of Expression's.
19683 (TypeManager.ResolveExpressionTypes): New public static function;
19684 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
19687 2003-11-06 Miguel de Icaza <miguel@ximian.com>
19689 * expression.cs (New.DoResolve): Do not dereference value that
19690 might be a null return.
19692 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
19693 sure that the constant value has the right type. Fixes an
19694 unreported bug, similar to 50425.
19696 * const.cs (Const.LookupConstantValue): Call
19697 ImplicitStandardConversionExists before doing a conversion to
19698 avoid havng the TypeManager.ChangeType do conversions.
19700 Reduced the number of casts used
19702 (Const.ChangeType): New routine to enable reuse of the constant
19703 type changing code from statement.
19705 * typemanager.cs (ChangeType): Move common initialization to
19706 static global variables.
19710 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
19711 every value type to go through, even if it was void. Fix that.
19713 * cs-tokenizer.cs: Use is_identifier_start_character on the start
19714 character of the define, and the is_identifier_part_character for
19715 the rest of the string.
19717 2003-11-05 Miguel de Icaza <miguel@ximian.com>
19719 * expression.cs (UnaryMutator.EmitCode): When I updated
19720 LocalVariableReference.DoResolve, I overdid it, and dropped an
19721 optimization done on local variable references.
19723 2003-11-04 Miguel de Icaza <miguel@ximian.com>
19725 * ecore.cs: Convert the return from Ldlen into an int.
19727 2003-10-20 Miguel de Icaza <miguel@ximian.com>
19729 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
19730 the accessibility, this is a special case for toplevel non-public
19731 classes (internal for instance).
19733 2003-10-20 Nick Drochak <ndrochak@gol.com>
19735 * ecore.cs: Fix typo and build. Needed another right paren.
19737 2003-10-19 Miguel de Icaza <miguel@ximian.com>
19739 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
19740 `internal' case regular and protected, but not allowing protected
19741 to be evaluated later. Bug 49840
19743 2003-10-15 Miguel de Icaza <miguel@ximian.com>
19745 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
19746 to kb.Nlast, and not the kb.nFirst to isolate the switch
19749 Extract the underlying type, so enumerations of long/ulong are
19750 treated like long/ulong.
19752 2003-10-14 Miguel de Icaza <miguel@ximian.com>
19754 * expression.cs (New): Overload the meaning of RequestedType to
19755 track the possible creation of the NewDelegate type, since
19756 DoResolve is invoked more than once for new constructors on field
19759 See bugs: #48800 and #37014
19761 * cs-parser.jay (declare_local_constants): Take an arraylist
19762 instead of a single constant.
19764 (local_constant_declaration): It should take a
19765 constant_declarators, not a constant_declarator. Fixes 49487
19767 * convert.cs: Fix error report.
19769 2003-10-13 Jackson Harper <jackson@ximian.com>
19771 * typemanager.cs (TypeToCoreType): Add float and double this fixes
19774 2003-10-09 Martin Baulig <martin@ximian.com>
19776 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
19778 (MethodCore.DoDefineParameters): Removed the TypeContainer
19779 argument; use the DeclSpace which was passed to the .ctor instead.
19780 (MethodCore.CheckParameter): Take a DeclSpace instead of a
19781 TypeContainer; we only need a DeclSpace here.
19783 2003-10-09 Martin Baulig <martin@ximian.com>
19785 * class.cs (MethodData): Added additional `DeclSpace ds' argument
19787 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
19788 EmitContext's .ctor.
19790 2003-10-09 Martin Baulig <martin@ximian.com>
19792 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
19793 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
19794 AsAccessible(), moved them as well.
19796 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
19798 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
19800 * cs-parser.jay : Renamed yyName to yyNames related to jay.
19802 2003-10-07 Miguel de Icaza <miguel@ximian.com>
19804 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
19805 generation for >=, as spotted by Paolo, bug 48679.
19806 Patch from David Waite.
19808 * cs-tokenizer.cs: Add handling for #pragma.
19810 * cs-parser.jay: Allow for both yield and yield return in the
19811 syntax. The anti-cobolization of C# fight will go on!
19813 * class.cs (TypeBuilder.DefineType): Catch error condition here
19814 (Parent.DefineType erroring out and returning null).
19816 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
19817 coping with enumerations variables, we were mistakenly processing
19818 them as a regular value type instead of built-in types. Fixes the
19821 * typemanager.cs (IsBuiltinOrEnum): New method.
19823 2003-09-30 Miguel de Icaza <miguel@ximian.com>
19825 * cs-parser.jay: Upgrade: yield now needs the return clause.
19827 2003-09-19 Martin Baulig <martin@ximian.com>
19829 * decl.cs (MemberCache.SetupCacheForInterface): Take a
19830 `MemberCache parent' argument. Normally, an interface doesn't
19831 have a parent type except System.Object, but we use this in gmcs
19832 for generic type parameters.
19834 2003-09-18 Martin Baulig <martin@ximian.com>
19836 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
19837 on `type.IsInterface'; don't check whether the type has a parent
19838 to determine whether it's an interface.
19840 2003-09-15 Martin Baulig <martin@ximian.com>
19842 * class.cs (TypeContainer.DefineType): Added an error flag to
19843 avoid reporting duplicate CS0146's ("class definition is
19846 * driver.cs (Driver.MainDriver): Abort if
19847 RootContext.ResolveTree() reported any errors.
19849 2003-09-07 Martin Baulig <martin@ximian.com>
19851 * report.cs (Error, Warning): Added overloaded versions which take
19852 a `params object[] args' and call String.Format().
19854 2003-09-07 Martin Baulig <martin@ximian.com>
19856 * decl.cs (DeclSpace..ctor): Don't call
19857 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
19858 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
19859 (DeclSpace.RecordDecl): New method.
19861 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
19863 2003-09-02 Ravi Pratap <ravi@ximian.com>
19865 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
19866 value attributes to be applied to ParameterBuilders.
19868 * class.cs (MethodCore.LabelParameters): Make static and more
19869 generic so that it can be used from other places - like interface
19870 methods, for instance.
19872 * interface.cs (Interface.Emit): Call LabelParameters before
19873 emitting attributes on the InterfaceMethod.
19875 2003-08-26 Martin Baulig <martin@ximian.com>
19877 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
19878 resolving aliases; fixes #47927.
19880 2003-08-26 Martin Baulig <martin@ximian.com>
19882 * statement.cs (Using.DoResolve): This is internally emitting a
19883 try/finally clause, so we need to set ec.NeedExplicitReturn if we
19884 do not always return. Fixes #47681.
19886 2003-08-26 Martin Baulig <martin@ximian.com>
19888 * decl.cs (MemberCore): Moved WarningNotHiding(),
19889 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
19891 (AdditionResult): Make this nested in DeclSpace.
19892 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
19893 argument; call NamespaceEntry.Define() unless we're nested in a
19896 * namespace.cs (Namespace.DefineName): New public function. This
19897 is called from DeclSpace's .ctor to add
19898 (Namespace.Lookup): Include DeclSpaces in the lookup.
19900 * class.cs (Operator): Derive from MemberBase, not MemberCore.
19902 * const.cs (Const): Derive from MemberBase, not MemberCore.
19904 2003-08-25 Martin Baulig <martin@ximian.com>
19906 * convert.cs (Convert.ExplicitReferenceConversion): When
19907 converting from an interface type to a class, unbox if the target
19908 type is a struct type. Fixes #47822.
19910 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
19912 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
19915 2003-08-22 Martin Baulig <martin@ximian.com>
19917 * class.cs (TypeManager.DefineType): When defining a nested type,
19918 call DefineType() on our parent; fixes #47801.
19920 2003-08-22 Martin Baulig <martin@ximian.com>
19922 * class.cs (MethodData.Define): While checking if a method is an
19923 interface implementation, improve the test a bit more to fix #47654.
19925 2003-08-22 Martin Baulig <martin@ximian.com>
19927 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
19928 correctly; fixes #47722.
19930 2003-08-22 Martin Baulig <martin@ximian.com>
19932 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
19933 LocalVariableReference, ensure it's not read-only. Fixes #47536.
19935 * statement.cs (Fixed.DoResolve): Make all variables read-only.
19937 2003-08-22 Martin Baulig <martin@ximian.com>
19939 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
19940 can only be assigned in static constructors. Fixes #47161.
19942 2003-08-22 Martin Baulig <martin@ximian.com>
19944 Rewrote and improved the flow analysis code.
19946 * flowbranching.cs (FlowBranching): Make this class abstract.
19947 (FlowBranching.CreateBranching): New static function to create a
19948 new flow branching.
19949 (FlowBranchingBlock, FlowBranchingException): New classes.
19950 (FlowBranching.UsageVector.Type): New public readonly field.
19951 (FlowBranching.UsageVector.Breaks): Removed the setter.
19952 (FlowBranching.UsageVector.Returns): Removed the setter.
19953 (FlowBranching.UsageVector): Added Break(), Return(),
19954 NeverReachable() and Throw() methods to modify the reachability.
19955 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
19956 done by FlowBranching.Merge().
19957 (FlowBranching.UsageVector.MergeChild): New method; merges the
19958 merge result into the current vector.
19959 (FlowBranching.Merge): New abstract method to merge a branching.
19961 2003-08-12 Martin Baulig <martin@ximian.com>
19963 * expression.cs (Indirection.CacheTemporaries): Create the
19964 LocalTemporary with the pointer type, not its element type.
19966 2003-08-10 Miguel de Icaza <miguel@ximian.com>
19968 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
19969 token was a keyword or not.
19971 Add `error' options where an IDENTIFIER was expected; Provide
19972 CheckToken and CheckIdentifierToken convenience error reporting
19975 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
19977 * decl.cs: Rename `NamespaceEntry Namespace' public field into
19978 NameSpaceEntry NameSpaceEntry.
19980 (LookupInterfaceOrClass): Avoid creating a full qualified name
19981 from namespace and name: avoid doing lookups when we know the
19982 namespace is non-existant. Use new Tree.LookupByNamespace which
19983 looks up DeclSpaces based on their namespace, name pair.
19985 * driver.cs: Provide a new `parser verbose' to display the
19986 exception thrown during parsing. This is turned off by default
19987 now, so the output of a failure from mcs is more graceful.
19989 * namespace.cs: Track all the namespaces defined in a hashtable
19992 (IsNamespace): New method
19994 2003-08-09 Miguel de Icaza <miguel@ximian.com>
19996 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
19997 we know that we need to concatenate (full typename can never be
20002 * statement.cs: Use a bitfield; Do not initialize to null things
20003 which are done by the constructor by default.
20005 * cs-parser.jay: bug fix, parameter was 4, not 3.
20007 * expression.cs: Just use the property;
20009 * statement.cs: No need for GetVariableInfo method.
20011 2003-08-08 Martin Baulig <martin@ximian.com>
20013 * flowanalysis.cs (FlowReturns): This is now nested in the
20014 `FlowBranching' class.
20015 (MyBitVector): Moved this here from statement.cs.
20016 (FlowBranching.SiblingType): New enum type.
20017 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20019 2003-08-07 Martin Baulig <martin@ximian.com>
20021 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20022 `FlowBranching' class and called `BranchingType'.
20024 2003-08-07 Martin Baulig <martin@ximian.com>
20026 * flowanalysis.cs: Moved all the control flow analysis code into
20029 2003-08-07 Martin Baulig <martin@ximian.com>
20031 * assign.cs (Assign.DoResolve): `target' must either be an
20032 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20035 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20037 * expression.cs (BinaryMethod): This kind of expression is created by the
20038 Binary class if it determines that the operator has to be handled
20041 (BinaryDelegate): This kind of expression is created if we are
20042 dealing with a + or - operator on delegates.
20044 (Binary): remove method, argumetns, and DelegateOperator: when
20045 dealing with methods,
20047 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20049 * statement.cs (Block): use bitfields for the three extra booleans
20050 we had in use. Remove unused topblock parameter.
20052 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20054 * assign.cs: Drop extra unneeded tests.
20056 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20058 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20060 * statement.cs (Foreach): Use VariableStorage instead of
20063 * codegen.cs (VariableStorage): New class used by clients that
20064 require a variable stored: locals or fields for variables that
20065 need to live across yield.
20067 Maybe provide a convenience api for EmitThis+EmitLoad?
20069 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20072 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20074 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20075 RemapParameterLValue): New methods that are used to turn a
20076 precomputed FieldInfo into an expression like this:
20080 The idea is to use this instead of making LocalVariableReference
20081 have more than one meaning.
20083 * cs-parser.jay: Add error production to BASE.
20085 * ecore.cs: Deal with TypeManager.GetField returning null, which
20086 is now a valid return value.
20088 (FieldExprNoAddress): New expression for Fields whose address can
20091 * expression.cs (LocalVariableReference): During the resolve
20092 phases, create new expressions if we are in a remapping context.
20093 Remove code that dealt with remapping here.
20095 (ParameterReference): same.
20097 (ProxyInstance): New expression, like the `This' expression, but
20098 it is born fully resolved. We know what we are doing, so remove
20099 the errors that are targeted to user-provided uses of `this'.
20101 * statement.cs (Foreach): our variable is now stored as an
20102 Expression; During resolution, follow the protocol, dont just
20103 assume it will return this.
20105 2003-08-06 Martin Baulig <martin@ximian.com>
20107 * support.cs (SeekableStreamReader.cs): New public class.
20109 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
20110 SeekableStreamReader instead of the normal StreamReader.
20112 2003-08-04 Martin Baulig <martin@ximian.com>
20114 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
20115 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
20116 deambiguate casts and delegate invocations.
20117 (parenthesized_expression): Use the new tokens to ensure this is
20118 not a cast of method invocation.
20120 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
20121 when reading a `)' and Deambiguate_CloseParens () was previously
20124 * expression.cs (ParenthesizedExpression): New class. This is
20125 just used for the CS0075 test.
20126 (Binary.DoResolve): Check for CS0075.
20128 2003-07-29 Ravi Pratap <ravi@ximian.com>
20130 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
20131 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
20132 reference comparison.
20134 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
20135 examine the ReturnType for equality - this is necessary in the
20136 cases of implicit and explicit operators whose signature also
20137 includes the return type.
20139 2003-07-26 Miguel de Icaza <miguel@ximian.com>
20141 * namespace.cs: Cache the result of the namespace computation,
20142 instead of computing it every time.
20144 2003-07-24 Miguel de Icaza <miguel@ximian.com>
20146 * decl.cs: Use a global arraylist that we reuse over invocations
20147 to avoid excesive memory consumption. Reduces memory usage on an
20148 mcs compile by one meg (45 average).
20150 * typemanager.cs (LookupTypeReflection): In .NET pointers are
20151 private, work around that.
20153 2003-07-23 Miguel de Icaza <miguel@ximian.com>
20155 * literal.cs (IntLiteral): Define Zero and One static literals.
20157 * cs-parser.jay (integer_literal): use static literals to reduce
20158 memory usage for the most used literals (0, 1 and -1). 211kb
20159 reduced in memory usage.
20161 Replace all calls to `new ArrayList' with `new
20162 ArrayList(4)' which is a good average number for most allocations,
20163 and also requires only 16 bytes of memory for its buffer by
20166 This reduced MCS memory usage in seven megabytes for the RSS after
20169 2003-07-28 Ravi Pratap <ravi@ximian.com>
20171 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
20172 handle params methods the correct way by forming only one
20173 applicable set with params and normal methods in them. Earlier we
20174 were looking at params methods only if we found no normal methods
20175 which was not the correct thing to do.
20177 (Invocation.BetterFunction): Take separate arguments indicating
20178 when candidate and the best method are params methods in their
20181 This fixes bugs #43367 and #46199.
20183 * attribute.cs: Documentation updates.
20185 (CheckAttribute): Rename to CheckAttributeTarget.
20186 (GetValidPlaces): Rename to GetValidTargets.
20188 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
20189 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
20193 2003-07-28 Martin Baulig <martin@ximian.com>
20195 * class.cs (TypeContainer.DefineMembers): Use the base type's full
20196 name when looking up the base class of a nested class. Fixes #46977.
20198 2003-07-26 Martin Baulig <martin@ximian.com>
20200 * expression.cs (Indexers.Indexer): New nested struct; contains
20201 getter, setter and the indexer's type.
20202 (Indexers.Properties): This is now an ArrayList of
20203 Indexers.Indexer's.
20204 (IndexerAccess.DoResolveLValue): Correctly set the type if the
20205 indexer doesn't have any getters.
20207 * assign.cs (Assign.DoResolve): Also do the implicit conversions
20208 for embedded property and indexer assignments.
20210 2003-07-26 Martin Baulig <martin@ximian.com>
20212 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
20213 preprocessor directive is not the first non-whitespace character
20216 2003-07-26 Martin Baulig <martin@ximian.com>
20218 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
20219 namespace parsing, follow the spec more closely.
20221 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
20222 NamespaceEntry.Lookup().
20224 2003-07-25 Martin Baulig <martin@ximian.com>
20226 * MethodCore.cs (OverridesSomething): New public field; it's set
20227 from TypeContainer.DefineMembers if this method overrides
20228 something (which doesn't need to be a method). Fix #39462.
20230 2003-07-25 Ravi Pratap <ravi@ximian.com>
20232 * typemanager.cs (GetMembers): Ensure that the list of members is
20233 reversed. This keeps things in sync.
20235 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
20236 find an AttributeUsage attribute.
20238 * expression.cs (Invocation.OverloadResolve): Perform the check
20239 which disallows Invoke to be directly called on a Delegate.
20241 (Error_InvokeOnDelegate): Report error cs1533.
20243 2003-07-25 Martin Baulig <martin@ximian.com>
20245 * expression.cs (Indexers.GetIndexersForType): Only look in the
20246 interface hierarchy if the requested type is already an
20247 interface. Fixes #46788 while keeping #46502 fixed.
20249 2003-07-25 Martin Baulig <martin@ximian.com>
20251 * class.cs (TypeContainer.DefineMembers): Check whether all
20252 readonly fields have been assigned and report warning CS0649 if
20255 * statement.cs (LocalInfo.IsFixed): Always return true if this is
20258 2003-07-24 Ravi Pratap <ravi@ximian.com>
20260 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
20261 returned from GetMethods to make things consistent with the
20262 assumptions MCS makes about ordering of methods.
20264 This should comprehensively fix bug #45127 and it does :-)
20266 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
20267 ordering is actually reverse.
20269 * Clean up some debug messages I left lying around.
20271 * interface.cs (Populate*): Get rid of code which emits attributes
20272 since the stage in which we emit attributes is the 'Emit' stage,
20273 not the define stage.
20275 (Emit): Move attribute emission for interface members here.
20277 2003-07-22 Ravi Pratap <ravi@ximian.com>
20279 * expression.cs (Invocation.OverloadResolve): Follow the spec more
20280 closely: we eliminate methods in base types when we have an
20281 applicable method in a top-level type.
20283 Please see section 14.5.5.1 for an exact description of what goes
20286 This fixes bug #45127 and a host of other related to corlib compilation.
20288 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
20289 array is the method corresponding to the top-level type (this is
20290 because of the changes made to icall.c) so we change this
20293 (MethodGroupExpr.Name): This too.
20295 * typemanager.cs (GetElementType): New method which does the right
20296 thing when compiling corlib.
20298 * everywhere: Make use of the above in the relevant places.
20300 2003-07-22 Martin Baulig <martin@ximian.com>
20302 * cs-parser.jay (invocation_expression): Moved
20303 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
20304 `cast_expression', but create a InvocationOrCast which later
20305 resolves to either an Invocation or a Cast.
20307 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
20308 method; call this before EmitStatement() to make sure that this
20309 expression can be used as a statement.
20311 * expression.cs (InvocationOrCast): New class; resolves to either
20312 an Invocation or a Cast.
20314 * statement.cs (StatementExpression): Call ResolveStatement() on
20315 the ExpressionStatement before emitting it.
20317 2003-07-21 Martin Baulig <martin@ximian.com>
20319 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
20320 `ref' and `out' attributes match; fixes #46220.
20321 (MemberAccess.ResolveMemberAccess): You can't reference a type
20322 through an expression; fixes #33180.
20323 (Indexers.GetIndexersForType): Don't return the indexers from
20324 interfaces the class implements; fixes #46502.
20326 2003-07-21 Martin Baulig <martin@ximian.com>
20328 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
20329 CS0661 checks; fixes bug #30442.
20331 2003-07-21 Martin Baulig <martin@ximian.com>
20333 * decl.cs (AdditionResult): Added `Error'.
20335 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
20337 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
20338 makes cs0031.cs actually work.
20340 2003-07-20 Martin Baulig <martin@ximian.com>
20342 * namespace.cs: Fixed that bug which caused a crash when compiling
20343 the debugger's GUI.
20345 2003-07-20 Miguel de Icaza <miguel@ximian.com>
20347 * typemanager.cs (LookupTypeReflection): Never expose types which
20348 are NotPublic, NestedPrivate, NestedAssembly, or
20349 NestedFamANDAssem. We used to return these, and later do a check
20350 that would report a meaningful error, but the problem is that we
20351 would not get the real match, if there was a name override.
20353 2003-07-18 Miguel de Icaza <miguel@ximian.com>
20355 * namespace.cs (Namespace, Name): Do not compute the namespace
20356 name dynamically, compute it in the constructor. This reduced
20357 memory usage by 1697 KB.
20359 * driver.cs: Use --pause to pause at the end.
20361 2003-07-17 Peter Williams <peter@newton.cx>
20363 * Makefile: Change the name of the test target so that it doesn't
20364 conflict with the recursive test target.
20366 2003-07-17 Miguel de Icaza <miguel@ximian.com>
20368 * expression.cs (LocalVariableReference.Emit, EmitAssign,
20369 AddressOf): Do not use EmitThis, that was wrong, use the actual
20372 2003-07-15 Miguel de Icaza <miguel@ximian.com>
20374 * class.cs (MethodData.Define): While checking if a method is an
20375 interface implementation, improve the test: If we are not public
20376 (use new test here: use the computed MethodAttributes directly,
20377 instead of the parsed modifier flags) check if the `implementing'
20378 method comes from an interface or not.
20380 * pending.cs (VerifyPendingMethods): Slightly better error
20383 * makefile: add test target that does the mcs bootstrap.
20385 2003-07-16 Ravi Pratap <ravi@ximian.com>
20387 * interface.cs (Define): Do nothing here since there are no
20388 members to populate etc. Move the attribute emission out of here
20389 since this was just totally the wrong place to put it. Attribute
20390 application happens during the 'Emit' phase, not in the 'Define'
20393 (Emit): Add this method and move the attribute emission here
20395 * rootcontext.cs (EmitCode): Call the Emit method on interface
20398 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20400 * expression.cs (OverloadResolve): Report error only if Location
20401 is not 'Null' which means that there was a probe going on.
20403 2003-07-14 Martin Baulig <martin@ximian.com>
20405 * expression.cs (ConditionalLogicalOperator): New public class to
20406 implement user defined conditional logical operators.
20407 This is section 14.11.2 in the spec and bug #40505.
20409 2003-07-14 Martin Baulig <martin@ximian.com>
20411 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
20413 2003-07-14 Martin Baulig <martin@ximian.com>
20415 * codegen.cs (EmitContext.InFixedInitializer): New public field.
20417 * ecore.cs (IVariable.VerifyFixed): New interface method.
20419 * expression.cs (Unary.ResolveOperator): When resolving the `&'
20420 operator, check whether the variable is actually fixed. Fixes bug
20421 #36055. Set a variable definitely assigned when taking its
20422 address as required by the spec.
20424 * statement.cs (LocalInfo.IsFixed): New field.
20425 (LocalInfo.MakePinned): Set `IsFixed' to true.
20427 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20429 * attribute.cs (Attribute.Resolve): While doing a Member lookup
20430 for .ctors, ensure that we only ask for members declared in the
20431 attribute type (BindingFlags.DeclaredOnly).
20435 * expression.cs (Error_WrongNumArguments): Report error 1501
20436 correctly the way CSC does.
20438 2003-07-13 Martin Baulig <martin@ximian.com>
20440 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
20441 lookup on the fully qualified name, to make things like "X.X" work
20442 where "X.X" is a fully qualified type name, but we also have a
20443 namespace "X" in the using list. Fixes #41975.
20445 2003-07-13 Martin Baulig <martin@ximian.com>
20447 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
20448 function. If we're a CompoundAssign, we need to create an embedded
20449 CompoundAssign, not an embedded Assign.
20450 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
20453 2003-07-13 Martin Baulig <martin@ximian.com>
20455 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
20456 work to fix bug #46088.
20458 2003-07-13 Ravi Pratap <ravi@ximian.com>
20460 * class.cs (Operator.Emit): Do not emit attributes here - it is
20461 taken care of by the Method class that we delegate too. This takes
20462 care of bug #45876.
20464 2003-07-10 Martin Baulig <martin@ximian.com>
20466 * expression.cs (TypeOfVoid): New class.
20467 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
20469 2003-07-10 Martin Baulig <martin@ximian.com>
20471 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
20474 2003-07-10 Martin Baulig <martin@ximian.com>
20476 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
20477 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
20479 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
20481 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
20483 2003-07-10 Martin Baulig <martin@ximian.com>
20485 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
20486 of decimal. Fixes #42850.
20488 NOTE: I also fixed the created byte blob, but this doesn't work on
20489 the MS runtime and csc never produces any byte blobs for decimal
20492 2003-07-10 Martin Baulig <martin@ximian.com>
20494 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
20495 structs; fixes #32068.
20496 (Block.AddChildVariableNames): Fixed #44302.
20498 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20500 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
20502 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20504 * attribute.cs: And this test is onger needed.
20506 2003-07-08 Martin Baulig <martin@ximian.com>
20508 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
20509 inaccessible types. Fixes #36313.
20511 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
20513 * namespace.cs (NamespaceEntry): Create implicit entries for all
20514 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
20515 implicit entries for N1.N2 and N1.
20517 2003-07-08 Martin Baulig <martin@ximian.com>
20519 Rewrote the handling of namespaces to fix a lot of the issues
20520 wrt. `using' aliases etc.
20522 * namespace.cs (Namespace): Splitted this class into a
20523 per-assembly `Namespace' and a per-file `NamespaceEntry'.
20525 * typemanager.cs (TypeManager.IsNamespace): Removed.
20526 (TypeManager.ComputeNamespaces): Only compute namespaces from
20527 loaded assemblies here, not the namespaces from the assembly we're
20528 currently compiling.
20530 2003-07-08 Martin Baulig <martin@ximian.com>
20532 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
20534 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20536 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
20539 I thought about the memory savings here, but LookupTypeReflection
20540 is used under already very constrained scenarios. Compiling
20541 corlib or mcs only exposes one hit, so it would not really reduce
20542 any memory consumption.
20544 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20546 * typemanager.cs: fixes bug #45889 by only adding public types from
20547 other assemblies to the list of known types.
20549 2003-07-07 Miguel de Icaza <miguel@ximian.com>
20551 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
20552 on the type we resolved.
20554 2003-07-05 Martin Baulig <martin@ximian.com>
20556 * pending.cs (PendingImplementation.ParentImplements): Don't
20557 create the proxy if the parent is abstract.
20559 * class.cs (TypeContainer.DefineIndexers): Process explicit
20560 interface implementations first. Fixes #37714.
20562 2003-07-04 Miguel de Icaza <miguel@ximian.com>
20564 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
20565 defined recursively; but since we modify the input parameters
20566 (left is set to `this' temporarily), we reset this value if the
20567 left_is_explicit is false, which gives the original semantics to
20570 * literal.cs (NullPointer): new class used to represent a null
20571 literal in a pointer context.
20573 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
20574 type is a pointer, use a NullPointer object instead of a
20575 NullLiteral. Closes 43687
20577 (ExplicitConversion): Convert pointer values using
20578 the conv opcode to the proper type.
20580 * ecore.cs (New): change ValueTypeVariable property into a method,
20581 that returns whether the valuetype is suitable for being used.
20583 * expression.cs (Binary.DoNumericPromotions): Only return if we
20584 the int constant was a valid uint, and we can return both left and
20585 right as uints. If not, we continue processing, to trigger the
20586 type conversion. This fixes 39018.
20588 * statement.cs (Block.EmitMeta): During constant resolution, set
20589 the CurrentBlock property on the emitcontext, so that we resolve
20590 constants propertly.
20592 2003-07-02 Martin Baulig <martin@ximian.com>
20594 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
20595 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
20597 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
20598 than emitting it here.
20600 * statement.cs: Fixed some more flow analysis bugs.
20602 2003-07-02 Martin Baulig <martin@ximian.com>
20604 * class.cs (MethodData.Define): When implementing interface
20605 methods, set Final unless we're Virtual.
20607 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
20608 check work for interface methods.
20610 2003-07-01 Martin Baulig <martin@ximian.com>
20612 * ecore.cs (EmitContext.This): Replaced this property with a
20613 GetThis() method which takes a Location argument. This ensures
20614 that we get the correct error location for a CS0188.
20616 2003-07-01 Miguel de Icaza <miguel@ximian.com>
20618 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
20619 ImplicitStandardConversion.
20621 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
20623 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
20625 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
20628 2003-06-30 Miguel de Icaza <miguel@ximian.com>
20630 * class.cs (Constructor.Define): Turn off initlocals for unsafe
20633 (MethodData.Define): Turn off initlocals for unsafe methods.
20635 2003-06-29 Miguel de Icaza <miguel@ximian.com>
20637 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
20638 complete; Fixes #37521.
20640 * delegate.cs: Use Modifiers.TypeAttr to compute the
20641 TypeAttributes, instead of rolling our own. This makes the flags
20642 correct for the delegates.
20644 2003-06-28 Miguel de Icaza <miguel@ximian.com>
20646 * class.cs (Constructor.Define): Set the private flag for static
20647 constructors as well.
20649 * cs-parser.jay (statement_expression): Set the return value to
20650 null, to avoid a crash when we catch an error.
20652 2003-06-24 Miguel de Icaza <miguel@ximian.com>
20654 * cs-parser.jay: Applied patch from Jackson that adds support for
20655 extern and unsafe modifiers to destructor declarations.
20657 * expression.cs: Report error 21 if the user is trying to index a
20660 * driver.cs: Add an error message, suggested by the bug report.
20662 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
20663 if we do not have a ": this ()" constructor initializer. Fixes 45149
20665 2003-06-14 Miguel de Icaza <miguel@ximian.com>
20667 * namespace.cs: Add some information to reduce FAQs.
20669 2003-06-13 Miguel de Icaza <miguel@ximian.com>
20671 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
20672 underlying enumeration types. Fixes #43915.
20674 * expression.cs: Treat ushort/short as legal values to be used in
20675 bitwise operations.
20677 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
20679 * delegate.cs: transfer custom attributes for paramenters from
20680 the delegate declaration to Invoke and BeginInvoke.
20682 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
20684 * attribute.cs: handle custom marshalers and emit marshal info
20687 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
20689 * makefile.gnu: Added anonymous.cs to the compiler sources.
20691 2003-05-28 Miguel de Icaza <miguel@ximian.com>
20693 * iterators.cs: Change the name of the proxy class to include two
20696 * cs-parser.jay: Update grammar to include anonymous methods.
20698 * anonymous.cs: new file.
20700 2003-05-27 Miguel de Icaza <miguel@ximian.com>
20702 * class.cs (Field.Define): Add missing test for pointers and
20705 2003-05-27 Ravi Pratap <ravi@ximian.com>
20707 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
20708 we use the stobj opcode.
20710 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
20711 since it wasn't the correct fix.
20713 It still is puzzling that we are required to use stobj for IntPtr
20714 which seems to be a ValueType.
20716 2003-05-26 Miguel de Icaza <miguel@ximian.com>
20718 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
20719 during regular simple name resolution. Now, the trick is that
20720 instead of returning for processing the simplename, we do a
20721 TypeManager.LookupType (ie, a rooted lookup as opposed to a
20722 contextual lookup type). If a match is found, return that, if
20723 not, return for further composition.
20725 This fixes long-standing 30485.
20727 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20728 using the address to initialize an object, do an Stobj instead of
20729 using the regular Stelem.
20731 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
20732 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
20733 Because if we are a BaseIndexerAccess that value will be true.
20736 * statement.cs (GotoCase.Resolve): Return after reporting an
20737 error, do not attempt to continue.
20739 * expression.cs (PointerArithmetic.Emit): If our operand is a
20740 long, convert our constants to match the operand before
20741 multiplying. Convert to I type before adding. Fixes 43670.
20743 2003-05-14 Ravi Pratap <ravi@ximian.com>
20745 * enum.cs (ImplicitConversionExists) : Rename to
20746 ImplicitEnumConversionExists to remove ambiguity.
20748 * ecore.cs (NullCast): New type of cast expression class which
20749 basically is very similar to EmptyCast with the difference being
20750 it still is a constant since it is used only to cast a null to
20752 (eg. (string) null)
20754 * convert.cs (ImplicitReferenceConversion): When casting a null
20755 literal, we return a NullCast.
20757 * literal.cs (NullLiteralTyped): Remove - I don't see why this
20758 should be around anymore.
20760 The renaming (reported was slightly wrong). Corrections:
20762 ConvertImplicitStandard -> ImplicitConversionStandard
20763 ConvertExplicitStandard -> ExplicitConversionStandard
20765 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
20766 before passing them in !
20768 * convert.cs (ImplicitConversionStandard): When comparing for
20769 equal expr and target types, ensure that expr is not a
20772 In general, we must not be checking (expr_type ==
20773 target_type) in the top level conversion methods
20774 (ImplicitConversion, ExplicitConversion etc). This checking is
20775 done in the methods that they delegate to.
20777 2003-05-20 Miguel de Icaza <miguel@ximian.com>
20779 * convert.cs: Move Error_CannotConvertType,
20780 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
20781 ImplicitNumericConversion, ImplicitConversionExists,
20782 ImplicitUserConversionExists, StandardConversionExists,
20783 FindMostEncompassedType, FindMostSpecificSource,
20784 FindMostSpecificTarget, ImplicitUserConversion,
20785 ExplicitUserConversion, GetConversionOperators,
20786 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
20787 TryImplicitIntConversion, Error_CannotConvertImplicit,
20788 ConvertImplicitRequired, ConvertNumericExplicit,
20789 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
20790 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
20793 Perform the following renames:
20795 StandardConversionExists -> ImplicitStandardConversionExists
20796 ConvertImplicit -> ImplicitConversion
20797 ConvertImplicitStandard -> ImplicitStandardConversion
20798 TryImplicitIntConversion -> ImplicitIntConversion
20799 ConvertImplicitRequired -> ImplicitConversionRequired
20800 ConvertNumericExplicit -> ExplicitNumericConversion
20801 ConvertReferenceExplicit -> ExplicitReferenceConversion
20802 ConvertExplicit -> ExplicitConversion
20803 ConvertExplicitStandard -> ExplicitStandardConversion
20805 2003-05-19 Martin Baulig <martin@ximian.com>
20807 * statement.cs (TypeInfo.StructInfo): Made this type protected.
20808 (TypeInfo): Added support for structs having structs as fields.
20810 * ecore.cs (FieldExpr): Implement IVariable.
20811 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
20812 VariableInfo for the field.
20814 2003-05-18 Martin Baulig <martin@ximian.com>
20816 * expression.cs (This.DoResolve): Report a CS0027 if we're
20817 emitting a field initializer.
20819 2003-05-18 Martin Baulig <martin@ximian.com>
20821 * expression.cs (This.ResolveBase): New public function.
20822 (This.DoResolve): Check for CS0188.
20824 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
20827 * ecore.cs (MethodGroupExpr.DoResolve): Set the
20828 `instance_expression' to null if we don't have any non-static
20831 2003-05-18 Martin Baulig <martin@ximian.com>
20833 Reworked the way how local variables and parameters are handled by
20834 the flow analysis code.
20836 * statement.cs (TypeInfo, VariableMap): New public classes.
20837 (VariableInfo): New public class. This is now responsible for
20838 checking whether a variable has been assigned. It is used for
20839 parameters and local variables.
20840 (Block.EmitMeta): Take the InternalParameters as argument; compute
20841 the layout of the flow vectors here.
20842 (Block.LocalMap, Block.ParameterMap): New public properties.
20843 (FlowBranching): The .ctor doesn't get the InternalParameters
20844 anymore since Block.EmitMeta() now computes the layout of the flow
20846 (MyStructInfo): This class is now known as `StructInfo' and nested
20847 in `TypeInfo'; we don't access this directly anymore.
20849 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
20850 property and removed IsAssigned(), IsFieldAssigned(),
20851 SetAssigned() and SetFieldAssigned(); we now call them on the
20852 VariableInfo so we don't need to duplicate this code everywhere.
20854 * expression.cs (ParameterReference): Added `Block block' argument
20856 (LocalVariableReference, ParameterReference, This): The new
20857 VariableInfo class is now responsible for all the definite
20860 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
20861 IsParameterAssigned, SetParameterAssigned): Removed.
20863 2003-05-18 Martin Baulig <martin@ximian.com>
20865 * typemanager.cs (InitCoreTypes): Try calling
20866 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
20867 the 3-args-version. Corlib now also needs our `void_type'.
20868 (GetMethod): Added overloaded version which takes an optional
20869 `bool report_errors' to allow lookups of optional methods.
20871 2003-05-12 Martin Baulig <martin@ximian.com>
20873 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
20874 only used for locals and not for parameters.
20876 2003-05-12 Miguel de Icaza <miguel@ximian.com>
20878 * support.cs (InternalParameters.ParameterType): Return the
20879 ExternalType of the parameter.
20881 * parameter.cs (Parameter.ExternalType): drop the two arguments,
20884 2003-05-11 Miguel de Icaza <miguel@ximian.com>
20886 * class.cs (MethodData.Define): Do not set the `newslot' on
20887 interface members, if they are also flagged as "override".
20889 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
20890 better code for ++i and i++. This only works for static fields
20891 and local variables.
20893 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
20894 want to pull the DeclSpace out of the builder_to_declspace instead
20895 of the TypeBuilder (like in TypeContainer.FindMembers).
20897 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
20898 instead of LookupTypeContainer. Fixes the crash on .NET for
20899 looking up interface members.
20901 * const.cs: Create our own emit context during the Definition
20902 stage, so that constants are evaluated in the proper context, when
20903 a recursive definition happens.
20905 2003-05-11 Martin Baulig <martin@ximian.com>
20907 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
20908 new block for a switch section.
20909 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
20910 the adding/lookup in the switch block. Fixes #39828.
20912 2003-05-09 Miguel de Icaza <miguel@ximian.com>
20914 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
20915 functionality: I needed to convert the data after I had performed
20916 the add/sub operation into the operands type size.
20918 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
20919 pass the type for the box operation, otherwise the resulting
20920 object would have been of type object.
20922 (BoxedCast): Add constructor to specify the type to box as.
20924 2003-05-07 Miguel de Icaza <miguel@ximian.com>
20926 * iterators.cs: I was reusing the `count' variable inadvertently,
20927 take steps to not allow this to happen.
20929 2003-05-06 Miguel de Icaza <miguel@ximian.com>
20931 * attribute.cs (Attribute.Resolve): Params attributes are encoded
20932 by creating an array at the point where the params starts and
20933 putting all those arguments there, then adjusting the size of the
20936 2003-05-05 Miguel de Icaza <miguel@ximian.com>
20938 * expression.cs (New.AddressOf): Implement interface
20939 IMemoryLocation. This is used when the `new' operator is used in
20940 the context of an invocation to a method on a value type.
20942 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
20945 * namespace.cs: Also check the using aliases here.
20947 * driver.cs: Move the test for using validity after the types have
20948 been entered, so we do a single pass that also includes the using
20951 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
20952 in the regular case. CreateSiblingForFinally is doing extra
20955 * attribute.cs (GetAttributeArgumentExpression): Store the result
20956 on an out value, and use the return value to indicate failure
20957 instead of using null (which is a valid return for Constant.GetValue).
20959 * statement.cs: Perform the analysis flow for the increment
20960 portion after the statement, because this will be the real flow of
20961 execution. Fixes #42385
20963 * codegen.cs (EmitContext.EmitArgument,
20964 EmitContext.EmitStoreArgument): New helper functions when the
20965 RemapToProxy flag is set.
20967 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
20970 Add support for remapping parameters.
20972 * iterators.cs: Propagate parameter values; Store parameter
20973 values in the proxy classes.
20975 2003-05-04 Miguel de Icaza <miguel@ximian.com>
20977 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
20978 need a proxy reference; I do not know what I was thinking
20980 * cs-parser.jay (constructor_initializer): catch another error,
20981 and display nice message.
20983 (field_declaration): catch void field declaration
20984 to flag a better error.
20986 * class.cs (MemberBase.CheckBase): Report an error instead of a
20987 warning if a new protected member is declared in a struct.
20988 (Field.Define): catch the error of readonly/volatile.
20990 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
20992 (FieldExpr.AddressOf): ditto. Catch error where the address of a
20993 volatile variable is taken
20995 2003-05-02 Miguel de Icaza <miguel@ximian.com>
20997 * statement.cs (Fixed.Resolve): Report an error if we are not in
21000 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21002 * typemanager.cs: reuse the code that handles type clashes for
21003 delegates and enumerations.
21005 * class.cs (Report28): Always report.
21007 * expression.cs (EncodeAsAttribute): Allow nulls here.
21009 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21011 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21012 the functionality for testing whether an expression is valid for
21013 an attribute here. Also handle the case of arrays of elements
21016 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21017 encoding a linear array into an array of objects that are suitable
21018 to be passed to an CustomAttributeBuilder.
21020 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21022 * ecore.cs: (FieldExpr): Handle field remapping here.
21024 * iteratators.cs: Pass the instance variable (if the method is an
21025 instance method) to the constructors, so we can access the field
21026 variables on the class.
21028 TODO: Test this with structs. I think the THIS variable on
21029 structs might have to be a pointer, and not a refenrece
21031 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21033 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21034 local variables to fields in a proxy class.
21036 * iterators.cs (PopulateProxy): Rename our internal fields to
21038 Create a <THIS> field if we are an instance method, so we can
21039 reference our parent container variables.
21040 (MapVariable): Called back from the EmitContext code to enter a
21041 new variable to field mapping into the proxy class (we just create
21045 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21046 for using the remapped locals to fields.
21048 I placed the code here, because that gives the same semantics to
21049 local variables, and only changes the Emit code.
21051 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21052 statements inside iterators.
21053 (VariableInfo): Add a FieldBuilder for the cases when we are
21054 remapping local variables to fields in a proxy class
21056 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21057 current_block != null.
21059 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21060 not cope with strings, as it has been moved to the
21061 TableSwitchEmit. Fixed bug in switch generation.
21063 * expression.cs (New.DoResolve): Provide more context for the user
21064 when reporting an error.
21066 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21069 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21070 check the permissions for it. Note than in a type-resolution
21071 context the check was already present in DeclSpace.ResolveType,
21072 but was missing from the MemberAccess.
21074 (ArrayCreation.CheckIndices): warn if the user has
21075 more nested levels of expressions, but there are no more
21076 dimensions specified. Avoids crash on bug 41906.
21078 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21080 * statement.cs (Block): replace Implicit bool, for a generic
21082 New flag: `Unchecked'. This is used during the EmitMeta phase
21083 (which is out-of-line with the regular Resolve/Emit process for a
21084 statement, as this is done ahead of time, but still gets a chance
21085 to call constant resolve).
21087 (Block.Flags): new enum for adding a new flag.
21089 (Block.EmitMeta): track the state of unchecked.
21091 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21092 to enable constant resolution to work there as well.
21094 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21096 * typemanager.cs (ienumerable_type): Also look up
21097 System.Collections.IEnumerable.
21099 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21101 TODO: Test more than one conditional per method.
21103 * class.cs (Indexer.Define): Report the location where the user is
21104 referencing the unsupported feature.
21106 (MethodData): Overload the use of `conditionals' to
21107 minimize the creation of needless ArrayLists. This saves roughly
21108 212kb on my machine.
21110 (Method): Implement the new IIteratorContainer interface.
21111 (Method.SetYields): Implement the method by setting the ModFlags
21112 to contain METHOD_YIELDS.
21114 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
21115 which just got set to null.
21117 * iterators.cs: New file.
21119 (Yield, YieldBreak): New statements.
21121 * statement.cs (Return.Resolve): Flag an error if we are used in
21122 an iterator method.
21124 * codegen.cs (InIterator): New flag set if the code is being
21125 compiled in an iterator method.
21127 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
21128 internal modifier, and we just use it to avoid adding extra
21129 fields, as this is seldom used.
21131 * cs-parser.jay: Add yield_statement (yield and yield break).
21133 * driver.cs: New flag -v2 to turn on version 2 features.
21135 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
21136 hashtable when v2 is enabled.
21138 2003-04-20 Miguel de Icaza <miguel@ximian.com>
21140 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
21141 there is already a namespace defined with this name.
21143 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
21144 people upgraded their corlibs.
21146 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
21147 always use fully qualified types, no need to use the compiler
21150 (TypeManager.IsNamespace): Use binarysearch.
21152 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
21153 AddDelegate): I did not quite use the new IsValid API properly: I
21154 have to pass the short-name and the fullname. I was passing only
21155 the basename instead of the fullname sometimes.
21157 (TypeContainer.DefineType): call NamespaceClash.
21159 * interface.cs (Interface.DefineType): use NamespaceClash before
21162 * delegate.cs (Delegate.DefineType): use NamespaceClash before
21165 * enum.cs: (Enum.DefineType): use NamespaceClash before
21168 * typemanager.cs (: 3-line patch that gives us some tasty 11%
21169 speed increase. First, use the negative_hits cache when we get a
21170 negative. Second, add the type with its full original name
21171 instead of the new . and + encoded name (reflection uses + to
21172 separate type from a nested type). Use LookupTypeReflection
21173 directly which bypasses the type->name hashtable (that we already
21174 know does not contain the type.
21176 * decl.cs (DeclSpace.ResolveTypeExpr): track the
21177 location/container type.
21179 * driver.cs: When passing utf8, use directly the UTF8Encoding.
21181 2003-04-19 Miguel de Icaza <miguel@ximian.com>
21183 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
21185 * delegate.cs (NewDelegate.Resolve): Test whether an instance
21186 method is being referenced in the method group from a static
21187 context, and report error 120 if so.
21189 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
21192 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
21193 is created, we create the A namespace).
21195 * cs-parser.jay: A namespace also introduces a DeclarationFound.
21198 2003-04-18 Miguel de Icaza <miguel@ximian.com>
21200 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
21201 invocation to ModuleBuilder.GetType with the same values will
21202 return a new type instance, so we need to cache its return
21205 * expression.cs (Binary.ResolveOperator): Only allow the compare
21206 operators on enums if they are of the same type.
21208 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
21209 types of ValueType on their own case. Before we were giving them
21210 the same treatment as objects.
21212 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
21213 fullname. Short name is used to compare against container name.
21214 Fullname is used to check against defined namespace names.
21216 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
21217 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
21219 (Method.CheckBase): Call parent.
21220 (MemberBase.CheckBase): Check for protected members on sealed
21222 (PropertyBase.CheckBase): Call parent.
21223 (Field.Define): Call parent.
21225 * report.cs: Negative error codes are now mapped to 8000 - code,
21226 so that the display is render more nicely.
21228 * typemanager.cs: Do not use try/catch, instead report a regular
21231 (GetPointerType, GetReferenceType): These methods provide
21232 mechanisms to obtain the T* and T& from a T. We had the code
21233 previously scattered around the code base, and it also used
21234 TypeManager.LookupType that would go through plenty of caches.
21235 This one goes directly to the type source.
21237 In some places we did the Type.GetType followed by
21238 ModuleBuilder.GetType, but not in others, so this unifies the
21239 processing as well.
21241 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
21242 statements now that we have namespace information.
21244 * typemanager.cs (IsNamespace): New method, returns whether the
21245 string presented is a namespace or not.
21247 (ComputeNamespaces): New public entry point, computes the list of
21248 available namespaces, using the GetNamespaces API call in Mono, or
21249 the slower version in MS.NET.
21251 Now before we start the semantic analysis phase, we have a
21252 complete list of namespaces including everything that the user has
21255 Deleted old code to cache namespaces in .nsc files.
21257 2003-04-17 Miguel de Icaza <miguel@ximian.com>
21259 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
21260 class/struct location definition Location for the implicit
21261 constructor location.
21263 (Operator.Define): Use the location of the operator for the
21264 implicit Method definition.
21266 (Constructor.Emit): use the constructor location for the implicit
21267 base initializer constructor.
21269 * ecore.cs: Remove ITypeExpression. This interface is now gone,
21270 and the Expression class now contains two new methods:
21272 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
21273 isolate type lookup from the rest of the resolution process.
21275 Since we use Expressions to hold type definitions due to the way
21276 we parse the input we have historically overloaded Resolve to
21277 perform the Type lookups if a special flag is passed. Now this is
21278 eliminated and two methods take their place.
21280 The differences in the two methods between xStep and xTerminal is
21281 that xStep is involved in our current lookup system that uses
21282 SimpleNames to compose a name, while xTerminal is used just to
21283 catch the case where the simplename lookup failed.
21285 2003-04-16 Miguel de Icaza <miguel@ximian.com>
21287 * expression.cs (ResolveMemberAccess): Remove redundant code.
21288 TypeExpr expressions are always born fully resolved.
21290 * interface.cs (PopulateMethod): Do not lookup the types twice.
21291 We were doing it once during SemanticAnalysis and once during
21294 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
21295 in local variable type definitions, were being returned as a
21296 SimpleName (we decomposed everything into a string), that is
21297 because primary_expression was being used instead of a type in the
21298 grammar (reduce/reduce conflicts).
21300 The part that was wrong is that we converted the expression into a
21301 string (an oversimplification in one hand, compounded with primary
21302 expressions doing string concatenation).
21308 Would return "A.B.C[]" as a SimpleName. This stopped things like
21309 using clauses from working on this particular context. And a type
21310 was being matched directly against "A.B.C[]".
21312 We now use the correct approach, and allow for ComposedCast to be
21313 part of the unary expression. So the "A.B.C []" become a composed
21314 cast of "A.B.C" (as a nested group of MemberAccess with a
21315 SimpleName at the end) plus the rank composition "[]".
21319 2003-04-10 Miguel de Icaza <miguel@ximian.com>
21321 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
21322 for the access level checking.
21324 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
21325 `TypeContainer container', because I kept getting confused when I
21326 was debugging this code.
21328 * expression.cs (Indexers): Instead of tracking getters/setters,
21329 we now track them in parallel. We create one arraylist less, but
21330 most importantly it is possible now for the LValue code to find a
21331 matching get for a set.
21333 (IndexerAccess.DoResolveLValue): Update the code.
21334 GetIndexersForType has been modified already to extract all the
21335 indexers from a type. The code assumed it did not.
21337 Also make the code set the correct return type for the indexer.
21338 This was fixed a long time ago for properties, but was missing for
21339 indexers. It used to be void_type.
21341 (Binary.Emit): Test first for doubles instead of
21342 floats, as they are more common.
21344 (Binary.EmitBranchable): Use the .un version of the branch opcodes
21345 when dealing with floats and the <=, >= operators. This fixes bug
21348 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
21349 to load the array value by emitting a load on the foreach variable
21350 type. This was incorrect.
21352 We now emit the code to load an element using the the array
21353 variable type, and then we emit the conversion operator.
21357 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
21359 * attribute.cs: Avoid allocation of ArrayLists in the common case.
21361 2003-04-09 Miguel de Icaza <miguel@ximian.com>
21363 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
21364 test for protection before we test for signatures.
21366 (MethodSignature.ToString): implement.
21368 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
21369 to the case where we reduced into a LongConstant.
21371 * decl.cs (CheckAccessLevel): If the type is an array, we can not
21372 depend on whether the information is acurrate, because the
21373 Microsoft runtime will always claim that the array type is public,
21374 regardless of the real state.
21376 If the type is a pointer, another problem happens: the type is
21377 reported as non-public in Microsoft.
21379 In both cases we have to call CheckAccessLevel recursively with
21380 the underlying type as the argument to be tested.
21382 2003-04-08 Miguel de Icaza <miguel@ximian.com>
21384 * assign.cs (Assign.Emit): If we are dealing with a compound
21385 assignment expression, we should use the code path that stores the
21386 intermediate result in a temporary value. This fixes #40903.
21388 *expression.cs (Indirection.ToString): Provide ToString method for
21391 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
21393 * class.cs: Null out fields holding references to Block objects so
21394 they can be garbage collected.
21396 * expression.cs (OverloadResolve): Remove unused local.
21398 2003-04-07 Martin Baulig <martin@ximian.com>
21400 * codegen.cs (EmitContext.CurrentFile): New public field.
21401 (EmitContext.Mark): Use the CurrentFile to check whether the
21402 location is in the correct file.
21403 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
21405 2003-04-07 Martin Baulig <martin@ximian.com>
21407 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
21409 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
21410 location. [FIXME: The location argument which gets passed to this
21411 method is sometimes wrong!]
21413 2003-04-07 Nick Drochak <ndrochak@gol.com>
21415 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
21417 2003-04-07 Miguel de Icaza <miguel@ximian.com>
21419 * expression.cs (Indirection.EmitAssign): We were using the
21420 temporary, but returning immediately instead of continuing the
21423 2003-04-06 Martin Baulig <martin@ximian.com>
21425 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
21426 if it's a nested child, but also deriving from the outer class.
21429 * typemanager.cs (IsNestedChildOf): Make this work if it's a
21430 nested child, but also deriving from the outer class. See
21432 (FilterWithClosure): We may access private members of the outer
21433 class if we're a nested child and deriving from the outer class.
21434 (RealMemberLookup): Only set `closure_private_ok' if the
21435 `original_bf' contained BindingFlags.NonPublic.
21437 2003-04-05 Martin Baulig <martin@ximian.com>
21439 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
21441 2003-04-02 Miguel de Icaza <miguel@ximian.com>
21443 * class.cs (Event.Define): Do not allow abstract events to have
21446 2003-04-01 Miguel de Icaza <miguel@ximian.com>
21448 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
21449 block in event declarations.
21451 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
21452 value type, get its address.
21454 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
21455 leaving a class on the stack instead of a boolean value (int
21456 0/1). Change the code so we compare against null, and then the
21457 result against zero.
21459 * class.cs (TypeContainer.GetClassBases): We were checking for the
21460 parent class being sealed too late.
21462 * expression.cs (Binary.Emit): For <= and >= when dealing with
21463 floating point values, use cgt.un and clt.un instead of cgt and
21466 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
21468 * statement.cs: Apply the same optimization as MS: skip the
21469 GetEnumerator returning an IEnumerator, and use the one returning a
21470 CharEnumerator instead. This allows us to avoid the try-finally block
21473 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
21475 * cs-parser.jay: Attributes cannot be applied to
21476 namespaces. Fixes #40473
21478 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21481 (Add*): check if the name is valid using the full name for constants,
21482 fields, properties and events.
21484 2003-03-28 Miguel de Icaza <miguel@ximian.com>
21486 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
21487 char constants to be part of the enumeration.
21489 * expression.cs (Conditional.DoResolve): Add support for operator
21490 true. Implements the missing functionality from 14.12
21492 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
21493 operator true/false as required by the spec.
21495 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
21496 implicit conversion to boolean.
21498 * statement.cs (Statement.ResolveBoolean): A boolean expression is
21499 also one where the type implements `operator true'.
21501 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
21502 get an expression that will invoke operator true based on an
21505 (GetConversionOperators): Removed the hack that called op_True
21508 (Expression.ResolveBoolean): Move this from Statement.
21510 2003-03-17 Miguel de Icaza <miguel@ximian.com>
21512 * ecore.cs (FieldExpr): do not allow initialization of initonly
21513 fields on derived classes
21515 2003-03-13 Martin Baulig <martin@ximian.com>
21517 * statement.cs (Block.Emit): Call ig.BeginScope() and
21518 ig.EndScope() when compiling with debugging info; call
21519 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
21521 2003-03-08 Miguel de Icaza <miguel@ximian.com>
21523 * expression.cs (Indexers): Do not construct immediately, allow
21524 for new members to be appended as we go. Fixes 38143
21526 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21528 * expression.cs: save/restore context when resolving an unchecked
21531 2003-03-05 Miguel de Icaza <miguel@ximian.com>
21533 * cfold.cs: Catch division by zero in modulus operator during
21536 2003-03-03 Miguel de Icaza <miguel@ximian.com>
21538 * interface.cs (Interface.DefineMembers): Avoid defining members
21541 2003-02-27 Miguel de Icaza <miguel@ximian.com>
21543 * driver.cs: handle the +/- options for -noconfig
21545 * statement.cs (Unckeched.Resolve): Also track the state of
21546 unchecked in the Resolve phase.
21548 2003-02-27 Martin Baulig <martin@ximian.com>
21550 * ecore.cs (Expression.MemberLookup): Don't create a
21551 MethodGroupExpr for something which is not a method. Fixes #38291.
21553 2003-02-25 Miguel de Icaza <miguel@ximian.com>
21555 * class.cs (MemberBase.CheckParameters): Also check that the type
21556 is unmanaged if it is a pointer.
21558 * expression.cs (SizeOf.Resolve): Add location information.
21560 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
21561 a managed type is declared.
21563 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
21564 parameter modifiers as well. Fixes bug 38606
21566 * class.cs: Very sad. Am backing out the speed up changes
21567 introduced by the ArrayList -> Array in the TypeContainer, as they
21568 were not actually that much faster, and introduced a bug (no error
21569 reports on duplicated methods).
21571 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
21572 source first, this will guarantee that we have a valid expression
21573 before calling in lower levels functions that will require a
21574 resolved object. Then use this original_source in the
21575 target.ResolveLValue instead of the original source that was
21578 Another change. Use target.Resolve instead of LValueResolve.
21579 Although we are resolving for LValues, we will let the Assign code
21580 take care of that (it will be called again from Resolve). This
21581 basically allows code like this:
21583 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
21584 class Y { void A (X x) { x [0] += o; }
21586 The problem was that the indexer was trying to resolve for
21587 set_Item (idx, object o) and never finding one. The real set_Item
21588 was set_Item (idx, X). By delaying the process we get the right
21593 2003-02-23 Martin Baulig <martin@ximian.com>
21595 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
21596 while calling DoEmit ().
21598 * codegen.cs (EmitContext.Mark): Don't mark locations in other
21599 source files; if you use the #line directive inside a method, the
21600 compiler stops emitting line numbers for the debugger until it
21601 reaches the end of the method or another #line directive which
21602 restores the original file.
21604 2003-02-23 Martin Baulig <martin@ximian.com>
21606 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
21608 2003-02-23 Martin Baulig <martin@ximian.com>
21610 * statement.cs (Block.AddChildVariableNames): We need to call this
21611 recursively, not just for our immediate children.
21613 2003-02-23 Martin Baulig <martin@ximian.com>
21615 * class.cs (Event.Define): Always make the field private, like csc does.
21617 * typemanager.cs (TypeManager.RealMemberLookup): Make events
21618 actually work, fixes bug #37521.
21620 2003-02-23 Miguel de Icaza <miguel@ximian.com>
21622 * delegate.cs: When creating the various temporary "Parameters"
21623 classes, make sure that we call the ComputeAndDefineParameterTypes
21624 on those new parameters (just like we do with the formal ones), to
21625 allow them to be resolved in the context of the DeclSpace.
21627 This fixes the bug that Dick observed in Bugzilla #38530.
21629 2003-02-22 Miguel de Icaza <miguel@ximian.com>
21631 * expression.cs (ResolveMemberAccess): When resolving a constant,
21632 do not attempt to pull a constant if the value was not able to
21633 generate a valid constant.
21635 * const.cs (LookupConstantValue): Do not report more errors than required.
21637 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21639 * expression.cs: fixes bug #38328.
21641 2003-02-18 Miguel de Icaza <miguel@ximian.com>
21643 * class.cs: Changed all the various members that can be part of a
21644 class from being an ArrayList to be an Array of the right type.
21645 During the DefineType type_list, interface_list, delegate_list and
21646 enum_list are turned into types, interfaces, delegates and enums
21649 And during the member population, indexer_list, event_list,
21650 constant_list, field_list, instance_constructor_list, method_list,
21651 operator_list and property_list are turned into their real arrays.
21653 Although we could probably perform this operation earlier, for
21654 good error reporting we need to keep the lists and remove the
21655 lists for longer than required.
21657 This optimization was triggered by Paolo profiling the compiler
21658 speed on the output of `gen-sample-program.pl' perl script.
21660 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
21661 not crash in methods like MemberLookupFailed that use this field.
21663 This problem arises when the compiler fails to resolve a type
21664 during interface type definition for example.
21666 2003-02-18 Miguel de Icaza <miguel@ximian.com>
21668 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
21669 inherit from System.Object, so we have to stop at null, not only
21670 when reaching System.Object.
21672 2003-02-17 Miguel de Icaza <miguel@ximian.com>
21674 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
21675 DeclaredOnly because the parent indexer might have had a different
21676 name, but did not loop until the top of the hierarchy was reached.
21678 The problem this one fixes is 35492: when a class implemented an
21679 indexer from an interface, we were getting the interface method
21680 (which was abstract) and we were flagging an error (can not invoke
21683 This also keeps bug 33089 functioning, and test-148 functioning.
21685 * typemanager.cs (IsSpecialMethod): The correct way of figuring
21686 out if a method is special is to see if it is declared in a
21687 property or event, or whether it is one of the predefined operator
21688 names. This should fix correctly #36804.
21690 2003-02-15 Miguel de Icaza <miguel@ximian.com>
21692 The goal here is to remove the dependency on EmptyCast.Peel ().
21693 Killing it completely.
21695 The problem is that currently in a number of places where
21696 constants are expected, we have to "probe" for an EmptyCast, and
21697 Peel, which is not the correct thing to do, as this will be
21698 repetitive and will likely lead to errors.
21700 The idea is to remove any EmptyCasts that are used in casts that
21701 can be reduced to constants, so we only have to cope with
21704 This bug hunt was triggered by Bug 37363 and the desire to remove
21705 the duplicate pattern where we were "peeling" emptycasts to check
21706 whether they were constants. Now constants will always be
21709 * ecore.cs: Use an enumconstant here instead of wrapping with
21712 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
21713 throwing me off. By handling this we can get rid of a few hacks.
21715 * statement.cs (Switch): Removed Peel() code.
21717 2003-02-14 Miguel de Icaza <miguel@ximian.com>
21719 * class.cs: Location information for error 508
21721 * expression.cs (New.DoResolve): Add a guard against double
21722 resolution of an expression.
21724 The New DoResolve might be called twice when initializing field
21725 expressions (see EmitFieldInitializers, the call to
21726 GetInitializerExpression will perform a resolve on the expression,
21727 and later the assign will trigger another resolution
21729 This leads to bugs (#37014)
21731 * delegate.cs: The signature for EndInvoke should contain any ref
21732 or out parameters as well. We were not doing this in the past.
21734 * class.cs (Field.Define): Do not overwrite the type definition
21735 inside the `volatile' group. Turns out that volatile enumerations
21736 were changing the type here to perform a validity test, which
21739 2003-02-12 Miguel de Icaza <miguel@ximian.com>
21741 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
21742 and structs, we do not want to load the instance variable
21744 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
21745 enum_type has to be handled like an object reference (implicit
21746 conversions exists from this to object), but the regular IsClass
21747 and IsValueType tests will never return true for this one.
21749 Also we use TypeManager.IsValueType instead of type.IsValueType,
21750 just for consistency with the rest of the code (this is only
21751 needed if we ever use the construct exposed by test-180.cs inside
21752 corlib, which we dont today).
21754 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
21756 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
21759 2003-02-09 Martin Baulig <martin@ximian.com>
21761 * namespace.cs (Namespace..ctor): Added SourceFile argument.
21762 (Namespace.DefineNamespaces): New static public method; this is
21763 called when we're compiling with debugging to add all namespaces
21764 to the symbol file.
21766 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
21767 pass it to the Namespace's .ctor.
21769 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
21770 and MethodBase arguments; pass the namespace ID to the symwriter;
21771 pass the MethodBase instead of the token to the symwriter.
21772 (SymbolWriter.DefineNamespace): New method to add a namespace to
21775 2003-02-09 Martin Baulig <martin@ximian.com>
21777 * symbolwriter.cs: New file. This is a wrapper around
21778 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
21779 methods here in near future.
21781 2003-02-09 Martin Baulig <martin@ximian.com>
21783 * codegen.cs (EmitContext.Mark): Just pass the arguments to
21784 ILGenerator.MarkSequencePoint() which are actually used by the
21787 2003-02-09 Martin Baulig <martin@ximian.com>
21789 * location.cs (SourceFile): New public sealed class. This
21790 contains the name and an index which is used in the location's token.
21791 (Location): Reserve an appropriate number of bits in the token for
21792 the source file instead of walking over that list, this gives us a
21793 really huge performance improvement when compiling with debugging.
21795 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
21796 `SourceFile' argument instead of a string.
21797 (Driver.ProcessFile): Add all the files via Location.AddFile(),
21798 but don't parse/tokenize here, we need to generate the list of all
21799 source files before we do that.
21800 (Driver.ProcessFiles): New static function. Parses/tokenizes all
21803 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
21804 instead of a string.
21806 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
21809 2003-02-09 Martin Baulig <martin@ximian.com>
21811 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
21812 filename on `#line default'.
21814 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
21816 * statement.cs: don't clear the pinned var when the fixed statement
21817 returns from the method (fixes bug#37752).
21819 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
21821 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
21824 2003-02-07 Martin Baulig <martin@ximian.com>
21826 * driver.cs: Removed the `--debug-args' command line argument.
21828 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
21829 automatically by the AsssemblyBuilder.
21830 (CodeGen.InitializeSymbolWriter): We don't need to call any
21831 initialization function on the symbol writer anymore. This method
21832 doesn't take any arguments.
21834 2003-02-03 Miguel de Icaza <miguel@ximian.com>
21836 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
21837 from referenced assemblies as well.
21839 2003-02-02 Martin Baulig <martin@ximian.com>
21841 * class.cs (MethodData.Emit): Generate debugging info for external methods.
21843 2003-02-02 Martin Baulig <martin@ximian.com>
21845 * class.cs (Constructor.Emit): Open the symbol writer before
21846 emitting the constructor initializer.
21847 (ConstructorInitializer.Emit): Call ec.Mark() to allow
21848 single-stepping through constructor initializers.
21850 2003-01-30 Miguel de Icaza <miguel@ximian.com>
21852 * class.cs: Handle error 549: do not allow virtual methods in
21855 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
21857 * decl.cs: Check access levels when resolving types
21859 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
21861 * statement.cs: Add parameters and locals set in catch blocks that might
21862 return to set vector
21864 2003-01-29 Miguel de Icaza <miguel@ximian.com>
21866 * class.cs (Operator): Set the SpecialName flags for operators.
21868 * expression.cs (Invocation.DoResolve): Only block calls to
21869 accessors and operators on SpecialName methods.
21871 (Cast.TryReduce): Handle conversions from char constants.
21874 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
21876 * statement.cs: small memory and time optimization in FlowBranching.
21878 2003-01-28 Pedro Mart <yoros@wanadoo.es>
21880 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
21881 problem that the last fix but in the other sid (Set).
21883 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
21884 access when there is no indexer in the hierarchy.
21886 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
21888 * class.cs: Combine some if statements.
21890 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21892 * driver.cs: fixed bug #37187.
21894 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
21896 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
21897 any indexer, it's needed to build a list with all the indexers in the
21898 hierarchy (AllGetters), else we have problems. Fixes #35653.
21900 2003-01-23 Miguel de Icaza <miguel@ximian.com>
21902 * class.cs (MethodData.Define): It is wrong for an interface
21903 implementation to be static in both cases: explicit and implicit.
21904 We were only handling this in one case.
21906 Improve the if situation there to not have negations.
21908 * class.cs (Field.Define): Turns out that we do not need to check
21909 the unsafe bit on field definition, only on usage. Remove the test.
21911 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21913 * driver.cs: use assembly.Location instead of Codebase (the latest
21914 patch made mcs fail when using MS assemblies).
21916 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
21918 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
21919 get the path to *corlib.dll.
21921 2003-01-21 Nick Drochak <ndrochak@gol.com>
21925 * typemanager.cs: Remove compiler warnings
21927 2003-01-20 Duncan Mak <duncan@ximian.com>
21929 * AssemblyInfo.cs: Bump the version number to 0.19.
21931 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21933 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
21935 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
21937 * class.cs (Constructor::Emit): Emit debugging info for constructors.
21939 2003-01-17 Miguel de Icaza <miguel@ximian.com>
21941 * cs-parser.jay: Small fix: we were not comparing the constructor
21942 name correctly. Thanks to Zoltan for the initial pointer.
21944 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
21946 * cs-tokenizer.cs: Set file name when specified with #line
21948 2003-01-15 Miguel de Icaza <miguel@ximian.com>
21950 * cs-parser.jay: Only perform the constructor checks here if we
21951 are named like the class; This will help provider a better
21952 error. The constructor path is taken when a type definition is
21953 not found, but most likely the user forgot to add the type, so
21954 report that rather than the constructor error.
21956 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
21958 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
21961 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
21963 * cs-parser.jay: Add cleanup call.
21965 2003-01-13 Duncan Mak <duncan@ximian.com>
21967 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
21968 consistent with other methods.
21970 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
21972 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
21974 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
21976 * attribute.cs: only set GuidAttr to true when we have a
21979 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21983 * typemanager.cs: fixes to allow mcs compile corlib with the new
21984 Type.IsSubclassOf fix.
21986 2003-01-08 Miguel de Icaza <miguel@ximian.com>
21988 * expression.cs (LocalVariableReference.DoResolve): Classify a
21989 constant as a value, not as a variable. Also, set the type for
21992 * cs-parser.jay (fixed_statement): take a type instead of a
21993 pointer_type, so we can produce a better error message later.
21995 * statement.cs (Fixed.Resolve): Flag types that are not pointers
21998 (For.DoEmit): Make inifinite loops have a
21999 non-conditional branch back.
22001 (Fixed.DoEmit): First populate the pinned variables, then emit the
22002 statement, then clear the variables. Before I was emitting the
22003 code once for each fixed piece.
22006 2003-01-08 Martin Baulig <martin@ximian.com>
22008 * statement.cs (FlowBranching.MergeChild): A break in a
22009 SWITCH_SECTION does not leave a loop. Fixes #36155.
22011 2003-01-08 Martin Baulig <martin@ximian.com>
22013 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22014 lives in the same number space than `param_map'. Fixes #36154.
22016 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22018 * cs-parser.jay (constructor_declaration): Set the
22019 Constructor.ModFlags before probing for it. This makes the
22020 compiler report 514, 515 and 132 (the code was there, but got
22023 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22024 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22025 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22027 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22029 * enum.cs: create the enum static fields using the enum type.
22031 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22033 * class.cs: don't try to create the ParamBuilder for the return
22034 type if it's not needed (and handle it breaking for the ms runtime
22037 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22039 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22041 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22043 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22044 the command. This showed up while compiling the JANET source
22045 code, which used \r as its only newline separator.
22047 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22049 * class.cs (Method.Define): If we are an operator (because it
22050 reuses our code), then set the SpecialName and HideBySig. #36128
22052 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22054 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22055 exception, report error 120 `object reference required'.
22057 * driver.cs: Add --pause option, used during to measure the size
22058 of the process as it goes with --timestamp.
22060 * expression.cs (Invocation.DoResolve): Do not allow methods with
22061 SpecialName to be invoked.
22063 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22065 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22066 number before adding it.
22068 2002-12-21 Ravi Pratap <ravi@ximian.com>
22070 * ecore.cs (StandardImplicitConversion): When in an unsafe
22071 context, we allow conversion between void * to any other pointer
22072 type. This fixes bug #35973.
22074 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22076 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22077 is not thrown when extensionless outputs are used
22079 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22081 * rootcontext.cs: fixed compilation of corlib.
22083 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22085 * attribute.cs (Attributes.Contains): Add new method.
22087 * class.cs (MethodCore.LabelParameters): if the parameter is an
22088 `out' parameter, check that no attribute `[In]' has been passed.
22090 * enum.cs: Handle the `value__' name in an enumeration.
22092 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22094 * decl.cs: Added special case to allow overrides on "protected
22097 2002-12-18 Ravi Pratap <ravi@ximian.com>
22099 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22100 since it makes much more sense.
22102 (Attributes.ctor): Don't require a Location parameter.
22104 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22106 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22107 since we already have that information per attribute.
22109 * everywhere : make appropriate changes.
22111 * class.cs (LabelParameters): Write the code which actually
22112 applies attributes to the return type. We can't do this on the MS
22113 .NET runtime so we flag a warning in the case an exception is
22116 2002-12-18 Miguel de Icaza <miguel@ximian.com>
22118 * const.cs: Handle implicit null conversions here too.
22120 2002-12-17 Ravi Pratap <ravi@ximian.com>
22122 * class.cs (MethodCore.LabelParameters): Remove the extra
22123 Type [] parameter since it is completely unnecessary. Instead
22124 pass in the method's attributes so that we can extract
22125 the "return" attribute.
22127 2002-12-17 Miguel de Icaza <miguel@ximian.com>
22129 * cs-parser.jay (parse): Use Report.Error to flag errors instead
22130 of ignoring it and letting the compile continue.
22132 * typemanager.cs (ChangeType): use an extra argument to return an
22133 error condition instead of throwing an exception.
22135 2002-12-15 Miguel de Icaza <miguel@ximian.com>
22137 * expression.cs (Unary.TryReduce): mimic the code for the regular
22138 code path. Perform an implicit cast in the cases where we can
22139 implicitly convert to one of the integral types, and then reduce
22140 based on that constant. This fixes bug #35483.
22142 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22144 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
22146 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22148 * namespace.cs: fixed bug #35489.
22150 2002-12-12 Miguel de Icaza <miguel@ximian.com>
22152 * class.cs: Remove some dead code.
22154 * cs-parser.jay: Estimate the number of methods needed
22155 (RootContext.MethodCount);
22157 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
22158 numbers instead of StringBuilders.
22160 * support.cs (PtrHashtable): Add constructor with initial size;
22161 We can now reduce reallocations of the method table.
22163 2002-12-10 Ravi Pratap <ravi@ximian.com>
22165 * attribute.cs (ApplyAttributes): Keep track of the emitted
22166 attributes on a per-target basis. This fixes bug #35413.
22168 2002-12-10 Miguel de Icaza <miguel@ximian.com>
22170 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
22171 default to the Windows 1252 encoding.
22173 (UnixParseOption): Support version, thanks to Alp for the missing
22176 * AssemblyInfo.cs: Add nice assembly information.
22178 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
22181 * cs-parser.jay: Allow a trailing comma before the close bracked
22182 in the attribute_section production.
22184 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
22185 address of the instance was being taken, I will take this out,
22186 because we take the address of the object immediately here.
22188 2002-12-09 Ravi Pratap <ravi@ximian.com>
22190 * typemanager.cs (AreMultipleAllowed): Take care of the most
22191 obvious case where attribute type is not in the current assembly -
22194 2002-12-08 Miguel de Icaza <miguel@ximian.com>
22196 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
22197 definitions, instead of doing that afterwards.
22199 Also we use a nice little hack, depending on the constructor, we
22200 know if we are a "composed" name or a simple name. Hence, we
22201 avoid the IndexOf test, and we avoid
22203 * codegen.cs: Add code to assist in a bug reporter to track down
22204 the source of a compiler crash.
22206 2002-12-07 Ravi Pratap <ravi@ximian.com>
22208 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
22209 types have been emitted for a given element and flag an error
22210 if something which does not have AllowMultiple set is used more
22213 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
22214 attribute types and their corresponding AllowMultiple properties
22216 (AreMultipleAllowed): Check the property for a given type.
22218 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
22219 property in the case we have a TypeContainer.
22221 (Attributes.AddAttribute): Detect duplicates and just skip on
22222 adding them. This trivial fix catches a pretty gross error in our
22223 attribute emission - global attributes were being emitted twice!
22225 Bugzilla bug #33187 is now fixed.
22227 2002-12-06 Miguel de Icaza <miguel@ximian.com>
22229 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
22230 instead of pp_and).
22232 * expression.cs (Binary.ResolveOperator): I can only use the
22233 Concat (string, string, string) and Concat (string, string,
22234 string, string) if the child is actually a concatenation of
22237 2002-12-04 Miguel de Icaza <miguel@ximian.com>
22239 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
22240 context where we need a 2-character lookahead.
22242 * pending.cs (PendingImplementation): Rework so we can keep track
22243 of interface types all the time, and flag those which were
22244 implemented by parents as optional.
22246 2002-12-03 Miguel de Icaza <miguel@ximian.com>
22248 * expression.cs (Binary.ResolveOperator): Use
22249 String.Concat(string,string,string) or
22250 String.Concat(string,string,string,string) when possible.
22252 * typemanager: More helper methods.
22255 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
22257 * pending.cs: remove the bogus return from GetMissingInterfaces()
22258 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
22260 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22262 * namespace.cs: avoid duplicated 'using xxx' being added to
22263 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
22264 when we get more than one 'using' statement for the same namespace.
22265 Report a CS0105 warning for it.
22267 2002-11-30 Miguel de Icaza <miguel@ximian.com>
22269 * cs-tokenizer.cs (consume_identifier): use read directly, instead
22270 of calling getChar/putback, uses internal knowledge of it.
22272 (xtoken): Reorder tokenizer so most common patterns are checked
22273 first. This reduces the compilation time in another 5% (from 8.11s
22274 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
22276 The parsing time is 22% of the compilation in mcs, and from that
22277 64% is spent on the tokenization process.
22279 I tried using a binary search for keywords, but this is slower
22280 than the hashtable. Another option would be to do a couple of
22283 * Not use a StringBuilder, instead use an array of chars,
22284 with a set value. Notice that this way we could catch
22285 the 645 error without having to do it *afterwards*.
22287 * We could write a hand-parser to avoid the hashtable
22288 compares altogether.
22290 The identifier consumption process takes 37% of the tokenization
22291 time. Another 15% is spent on is_number. 56% of the time spent
22292 on is_number is spent on Int64.Parse:
22294 * We could probably choose based on the string length to
22295 use Int32.Parse or Int64.Parse and avoid all the 64-bit
22298 Another 3% is spend on wrapping `xtoken' in the `token' function.
22300 Handle 0xa0 as whitespace (#34752)
22302 2002-11-26 Miguel de Icaza <miguel@ximian.com>
22304 * typemanager.cs (IsCLRType): New routine to tell whether a type
22305 is one of the builtin types.
22307 Maybe it needs to use TypeCodes to be faster. Maybe we could use
22308 typecode in more places instead of doing pointer comparissions.
22309 We could leverage some knowledge about the way the typecodes are
22312 New code to cache namespaces in assemblies, it is currently not
22313 invoked, to be used soon.
22315 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
22317 * expression.cs (Binary.ResolveOperator): specially handle
22318 strings, and do not perform user-defined operator overloading for
22321 2002-11-24 Miguel de Icaza <miguel@ximian.com>
22323 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
22324 internalcall as it is a pretty simple operation; Avoid whenever
22325 possible to call Char.IsLetter.
22327 (consume_identifier): Cut by half the number of
22328 hashtable calls by merging the is_keyword and GetKeyword behavior.
22330 Do not short-circuit, because if we do, we
22331 report errors (ie, #if false && true would produce an invalid
22335 2002-11-24 Martin Baulig <martin@ximian.com>
22337 * expression.cs (Cast.TryReduce): If we're in checked syntax,
22338 check constant ranges and report a CS0221. Fixes #33186.
22340 2002-11-24 Martin Baulig <martin@ximian.com>
22342 * cs-parser.jay: Make this work for uninitialized variable
22343 declarations in the `for' initializer. Fixes #32416.
22345 2002-11-24 Martin Baulig <martin@ximian.com>
22347 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
22348 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
22350 2002-11-24 Martin Baulig <martin@ximian.com>
22352 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
22353 argument; if true, we also check for user-defined conversions.
22354 This is only needed if both arguments are of a user-defined type.
22355 Fixes #30443, added test-175.cs.
22356 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
22358 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
22360 2002-11-24 Martin Baulig <martin@ximian.com>
22362 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
22363 function to get the store opcode.
22364 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
22365 only emit the Ldelema if the store opcode is Stobj. You must run
22366 both test-34 and test-167 to test this. Fixes #34529.
22368 2002-11-23 Martin Baulig <martin@ximian.com>
22370 * ecore.cs (Expression.MemberLookup): Added additional
22371 `qualifier_type' argument which is used when we're being called
22372 from MemberAccess.DoResolve() and null if we're called from a
22374 (Expression.MemberLookupFailed): New method to report errors; this
22375 does the CS1540 check and reports the correct error message.
22377 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
22378 argument for the CS1540 check and redone the way how we're dealing
22379 with private members. See the comment in the source code for details.
22380 (FilterWithClosure): Reverted this back to revision 1.197; renamed
22381 `closure_start_type' to `closure_qualifier_type' and check whether
22382 it's not null. It was not this filter being broken, it was just
22383 being called with the wrong arguments.
22385 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
22386 and pass it the correct `qualifier_type'; this also does the error
22389 2002-11-22 Miguel de Icaza <miguel@ximian.com>
22391 * expression.cs (Invocation.EmitParams): If the we are dealing
22392 with a non-built-in value type, load its address as well.
22394 (ArrayCreation): Use a a pretty constant instead
22395 of the hardcoded value 2. Use 6 instead of 2 for the number of
22396 static initializers.
22398 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
22399 because they are not really value types, just glorified integers.
22401 * driver.cs: Do not append .exe, the CSC compiler does not do it.
22403 * ecore.cs: Remove redundant code for enumerations, make them use
22404 the same code path as everything else, fixes the casting issue
22405 with enumerations in Windows.Forms.
22407 * attribute.cs: Do only cast to string if it is a string, the
22408 validation happens later.
22410 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
22411 people upgrade their corlibs.
22413 * ecore.cs: Oops, enumerations were not following the entire code path
22415 2002-11-21 Miguel de Icaza <miguel@ximian.com>
22417 * typemanager.cs (FilterWithClosure): Commented out the test for
22418 1540 in typemanager.cs, as it has problems when accessing
22419 protected methods from a parent class (see test-174.cs).
22421 * attribute.cs (Attribute.ValidateGuid): new method.
22422 (Attribute.Resolve): Use above.
22424 2002-11-19 Miguel de Icaza <miguel@ximian.com>
22426 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
22428 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
22429 handling for enumerations, as we only needed the TypeContainer
22430 functionality to begin with (this is required for the fix below to
22431 work for enums that reference constants in a container class for
22434 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
22436 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
22437 a valid TypeBuilder to perform lookups on.o
22439 * class.cs (InheritableMemberSignatureCompare): Use true in the
22440 call to GetGetMethod and GetSetMethod, because we are comparing
22441 the signature, and we need to get the methods *even* if they are
22444 (PropertyBase.CheckBase): ditto.
22446 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
22447 GotoCase.Resolve): Use Peel on EmpytCasts.
22449 * ecore.cs (EmptyCast): drop child, add Peel method.
22451 2002-11-17 Martin Baulig <martin@ximian.com>
22453 * ecore.cs (EmptyCast.Child): New public property.
22455 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
22456 label resolved to an EmptyCast. Fixes #34162.
22457 (GotoCase.Resolve): Likewise.
22458 (Block.EmitMeta): Likewise.
22460 2002-11-17 Martin Baulig <martin@ximian.com>
22462 * expression.cs (Invocation.BetterConversion): Prefer int over
22463 uint; short over ushort; long over ulong for integer literals.
22464 Use ImplicitConversionExists instead of StandardConversionExists
22465 since we also need to check for user-defined implicit conversions.
22466 Fixes #34165. Added test-173.cs.
22468 2002-11-16 Martin Baulig <martin@ximian.com>
22470 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
22471 with the `true' and `false' literals. Fixes #33151.
22473 2002-11-16 Martin Baulig <martin@ximian.com>
22475 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
22476 October 22nd; don't do the cs1540 check for static members.
22478 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
22479 now using our own filter here and doing the cs1540 check again.
22481 2002-11-16 Martin Baulig <martin@ximian.com>
22483 * support.cs (InternalParameters): Don't crash if we don't have
22484 any fixed parameters. Fixes #33532.
22486 2002-11-16 Martin Baulig <martin@ximian.com>
22488 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
22489 when looking up static methods to make this work on Windows.
22492 2002-11-16 Martin Baulig <martin@ximian.com>
22494 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
22495 a setter rather than using PropertyInfo.CanWrite.
22497 2002-11-15 Nick Drochak <ndrochak@gol.com>
22499 * class.cs: Allow acces to block member by subclasses. Fixes build
22502 2002-11-14 Martin Baulig <martin@ximian.com>
22504 * class.cs (Constructor.Emit): Added the extern/block check.
22507 2002-11-14 Martin Baulig <martin@ximian.com>
22509 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
22510 iteration while looking for indexers, this is needed because the
22511 indexer may have a different name in our base classes. Fixed the
22512 error reporting (no indexers at all, not get accessor, no
22513 overloaded match). Fixes bug #33089.
22514 (IndexerAccess.DoResolveLValue): Likewise.
22516 2002-11-14 Martin Baulig <martin@ximian.com>
22518 * class.cs (PropertyBase.CheckBase): Make this work for multiple
22519 indexers. Fixes the first part of bug #33089.
22520 (MethodSignature.InheritableMemberSignatureCompare): Added support
22523 2002-11-13 Ravi Pratap <ravi@ximian.com>
22525 * attribute.cs (Attribute.Resolve): Catch the
22526 NullReferenceException and report it since it isn't supposed to
22529 2002-11-12 Miguel de Icaza <miguel@ximian.com>
22531 * expression.cs (Binary.EmitBranchable): Also handle the cases for
22532 LogicalOr and LogicalAnd that can benefit from recursively
22533 handling EmitBranchable. The code now should be nice for Paolo.
22535 2002-11-08 Miguel de Icaza <miguel@ximian.com>
22537 * typemanager.cs (LookupType): Added a negative-hit hashtable for
22538 the Type lookups, as we perform quite a number of lookups on
22539 non-Types. This can be removed once we can deterministically tell
22540 whether we have a type or a namespace in advance.
22542 But this might require special hacks from our corlib.
22546 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
22547 and double which avoids a conversion from an integer to a double.
22549 * expression.cs: tiny optimization, avoid calling IsConstant,
22550 because it effectively performs the lookup twice.
22552 2002-11-06 Miguel de Icaza <miguel@ximian.com>
22554 But a bogus return here to keep the semantics of the old code
22555 until the Mono runtime is fixed.
22557 * pending.cs (GetMissingInterfaces): New method used to remove all
22558 the interfaces that are already implemented by our parent
22559 classes from the list of pending methods.
22561 * interface.cs: Add checks for calls after ResolveTypeExpr.
22563 2002-11-05 Miguel de Icaza <miguel@ximian.com>
22565 * class.cs (Class.Emit): Report warning 67: event not used if the
22566 warning level is beyond 3.
22568 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
22569 being a NullLiteral.
22571 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
22574 * class.cs (TypeContainer.GetClassBases): Cover a missing code
22575 path that might fail if a type can not be resolved.
22577 * expression.cs (Binary.Emit): Emit unsigned versions of the
22580 * driver.cs: use error 5.
22582 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
22584 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
22586 2002-11-01 Miguel de Icaza <miguel@ximian.com>
22588 * cs-parser.jay (switch_section): A beautiful patch from Martin
22589 Baulig that fixed 33094.
22591 2002-10-31 Miguel de Icaza <miguel@ximian.com>
22593 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
22594 Check whether the base is abstract and report an error if so.
22596 * expression.cs (IndexerAccess.DoResolveLValue,
22597 IndexerAccess.DoResolve): ditto.
22599 (Invocation.DoResolve): ditto.
22601 (Invocation.FullMethodDesc): Improve the report string.
22603 * statement.cs (Block): Eliminate IsVariableDefined as it is
22604 basically just a wrapper for GetVariableInfo.
22606 * ecore.cs (SimpleName): Use new
22608 * support.cs (ReflectionParamter.ParameterType): We unwrap the
22609 type, as we return the actual parameter ref/unref state on a
22612 2002-10-30 Miguel de Icaza <miguel@ximian.com>
22614 * support.cs: Return proper flags REF/OUT fixing the previous
22617 * expression.cs: Reverted last patch, that was wrong. Is_ref is
22618 not used to mean `ref' but `ref or out' in ParameterReference
22620 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
22621 full type signature instead of calling TypeManger.CSharpName
22624 * support.cs (InternalParameters.ParameterDesc): Do not compare
22625 directly to the modflags, because REF/OUT will actually be bitsets
22628 * delegate.cs (VerifyMethod): Check also the modifiers.
22630 * cs-tokenizer.cs: Fix bug where floating point values with an
22631 exponent where a sign was missing was ignored.
22633 * driver.cs: Allow multiple assemblies to be specified in a single
22636 2002-10-28 Miguel de Icaza <miguel@ximian.com>
22638 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
22639 because identifiers after a parenthesis would end up in this kind
22640 of production, and we needed to desamiguate it for having casts
22643 (UserDefinedType *) xxx
22645 2002-10-24 Miguel de Icaza <miguel@ximian.com>
22647 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
22648 we should set on the Bindingflags.NonPublic, but not turn on
22649 private_ok. private_ok controls whether a Private member is
22650 returned (this is chekced on the filter routine), while the
22651 BindingFlags.NonPublic just controls whether private/protected
22652 will be allowed. This fixes the problem part of the problem of
22653 private properties being allowed to be used in derived classes.
22655 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
22656 so we can call the children DoResolveLValue method (this will
22657 properly signal errors on lvalue assignments to base properties)
22659 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
22660 getter are null, and we have a property info, we know that this
22661 happened because the lookup failed, so we report an error 122 for
22662 protection level violation.
22664 We also silently return if setter and getter are null in the
22665 resolve functions, this condition only happens if we have flagged
22666 the error before. This is the other half of the problem.
22668 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
22669 not have accessibility information, that is why we were returning
22670 true in the filter function in typemanager.cs.
22672 To properly report 122 (property is inaccessible because of its
22673 protection level) correctly, we report this error in ResolveAccess
22674 by failing if both the setter and the getter are lacking (ie, the
22677 DoResolve and DoLResolve have been modified to check for both
22678 setter/getter being null and returning silently, the reason being
22679 that I did not want to put the knowledge about this error in upper
22682 int old = Report.Errors;
22683 x = new PropertyExpr (...);
22684 if (old != Report.Errors)
22689 So the property expr is returned, but it is invalid, so the error
22690 will be flagged during the resolve process.
22692 * class.cs: Remove InheritablePropertySignatureCompare from the
22693 class, as we no longer depend on the property signature to compute
22694 whether it is possible to implement a method or not.
22696 The reason is that calling PropertyInfo.GetGetMethod will return
22697 null (in .NET, in Mono it works, and we should change this), in
22698 cases where the Get Method does not exist in that particular
22703 class X { public virtual int A { get { return 1; } } }
22705 class Z : Y { public override int A { get { return 2; } } }
22707 Would fail in Z because the parent (Y) would not have the property
22708 defined. So we avoid this completely now (because the alternative
22709 fix was ugly and slow), and we now depend exclusively on the
22712 (PropertyBase.CheckBase): Use a method-base mechanism to find our
22713 reference method, instead of using the property.
22715 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
22716 routines are gone now.
22718 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
22719 names, they were incorrectly named.
22721 * cs-tokenizer.cs: Return are more gentle token on failure.
22723 * pending.cs (PendingImplementation.InterfaceMethod): This routine
22724 had an out-of-sync index variable, which caused it to remove from
22725 the list of pending methods the wrong method sometimes.
22727 2002-10-22 Miguel de Icaza <miguel@ximian.com>
22729 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
22730 CanWrite, because those refer to this particular instance of the
22731 property, and do not take into account the fact that we can
22732 override single members of a property.
22734 Constructor requires an EmitContext. The resolution process does
22735 not happen here, but we need to compute the accessors before,
22736 because the resolution does not always happen for properties.
22738 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
22739 subclass, before we did not update this flag, but we did update
22742 (GetAccessors): Drop this routine, as it did not work in the
22743 presence of partially overwritten set/get methods.
22745 Notice that this broke the cs1540 detection, but that will require
22748 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22752 * driver.cs: issue a warning instead of an error if we don't support
22753 debugging for the platform. Also ignore a couple of errors that may
22754 arise when trying to write the symbols. Undo my previous patch.
22756 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22758 * driver.cs: ignore /debug switch except for Unix platforms.
22760 2002-10-23 Nick Drochak <ndrochak@gol.com>
22762 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
22764 2002-10-21 Miguel de Icaza <miguel@ximian.com>
22766 * driver.cs: Do not make mcs-debug conditional, so we do not break
22767 builds that use it.
22769 * statement.cs (UsageVector.MergeChildren): I would like Martin to
22770 review this patch. But basically after all the children variables
22771 have been merged, the value of "Breaks" was not being set to
22772 new_breaks for Switch blocks. I think that it should be set after
22773 it has executed. Currently I set this to the value of new_breaks,
22774 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
22775 conservative, but I do not understand this code very well.
22777 I did not break anything in the build, so that is good ;-)
22779 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
22781 2002-10-20 Mark Crichton <crichton@gimp.org>
22783 * cfold.cs: Fixed compile blocker. Really fixed it this time.
22785 2002-10-20 Nick Drochak <ndrochak@gol.com>
22787 * cfold.cs: Fixed compile blocker.
22789 2002-10-20 Miguel de Icaza <miguel@ximian.com>
22791 * driver.cs: I was chekcing the key, not the file.
22793 2002-10-19 Ravi Pratap <ravi@ximian.com>
22795 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
22796 message that we were generating - we just need to silently return
22799 2002-10-19 Miguel de Icaza <miguel@ximian.com>
22801 * class.cs (Event.Define): Change my previous commit, as this
22802 breaks the debugger. This is a temporary hack, as it seems like
22803 the compiler is generating events incorrectly to begin with.
22805 * expression.cs (Binary.ResolveOperator): Added support for
22806 "U operator - (E x, E y)"
22808 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
22811 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
22812 init-only variables, but this path did not take into account that
22813 there might be also instance readonly variables. Correct this
22816 This fixes bug 32253
22818 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
22821 * driver.cs: Change the extension for modules to `netmodule'
22823 * cs-parser.jay: Improved slightly the location tracking for
22824 the debugger symbols.
22826 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
22827 modifiers that were specified instead of the hardcoded value
22828 (FamAndAssem). This was basically ignoring the static modifier,
22829 and others. Fixes 32429.
22831 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
22832 fixed a bug in the process (32476)
22834 * expression.cs (ArrayAccess.EmitAssign): Patch from
22835 hwang_rob@yahoo.ca that fixes bug 31834.3
22837 2002-10-18 Miguel de Icaza <miguel@ximian.com>
22839 * driver.cs: Make the module extension .netmodule.
22841 2002-10-16 Miguel de Icaza <miguel@ximian.com>
22843 * driver.cs: Report an error if the resource file is not found
22844 instead of crashing.
22846 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
22847 false, like Emit does.
22849 2002-10-16 Nick Drochak <ndrochak@gol.com>
22851 * typemanager.cs: Remove unused private member. Also reported mcs
22852 bug to report this as a warning like csc.
22854 2002-10-15 Martin Baulig <martin@gnome.org>
22856 * statement.cs (Statement.Emit): Made this a virtual method; emits
22857 the line number info and calls DoEmit().
22858 (Statement.DoEmit): New protected abstract method, formerly knows
22859 as Statement.Emit().
22861 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
22863 2002-10-11 Miguel de Icaza <miguel@ximian.com>
22865 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
22866 have fixed a remaining problem: not every AddXXXX was adding a
22867 fully qualified name.
22869 Now everyone registers a fully qualified name in the DeclSpace as
22870 being defined instead of the partial name.
22872 Downsides: we are slower than we need to be due to the excess
22873 copies and the names being registered this way.
22875 The reason for this is that we currently depend (on the corlib
22876 bootstrap for instance) that types are fully qualified, because
22877 we dump all the types in the namespace, and we should really have
22878 types inserted into the proper namespace, so we can only store the
22879 basenames in the defined_names array.
22881 2002-10-10 Martin Baulig <martin@gnome.org>
22883 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
22884 from bug #31834, see the bug report for a testcase which is
22887 2002-10-10 Martin Baulig <martin@gnome.org>
22889 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
22890 flow analysis code for this.
22892 * statement.cs (Do, While, For): Tell the flow analysis code about
22894 (FlowBranching.UsageVector): Added support for infinite loops.
22895 (Block.Resolve): Moved the dead code elimination here and use flow
22898 2002-10-09 Miguel de Icaza <miguel@ximian.com>
22900 * class.cs (Field.Define): Catch cycles on struct type
22903 * typemanager.cs (IsUnmanagedtype): Do not recursively check
22904 fields if the fields are static. We only need to check instance
22907 * expression.cs (As.DoResolve): Test for reference type.
22909 * statement.cs (Using.ResolveExpression): Use
22910 ConvertImplicitRequired, not ConvertImplicit which reports an
22912 (Using.ResolveLocalVariableDecls): ditto.
22914 * expression.cs (Binary.ResolveOperator): Report errors in a few
22915 places where we had to.
22917 * typemanager.cs (IsUnmanagedtype): Finish implementation.
22919 2002-10-08 Miguel de Icaza <miguel@ximian.com>
22921 * expression.cs: Use StoreFromPtr instead of extracting the type
22922 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
22924 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
22925 an enumeration value to a System.Enum, but System.Enum is not a
22926 value type, but an class type, so we need to box.
22928 (Expression.ConvertExplicit): One codepath could return
22929 errors but not flag them. Fix this. Fixes #31853
22931 * parameter.cs (Resolve): Do not allow void as a parameter type.
22933 2002-10-06 Martin Baulig <martin@gnome.org>
22935 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
22936 if it's a class type and not a struct. Fixes #31815.
22938 2002-10-06 Martin Baulig <martin@gnome.org>
22940 * statement.cs: Reworked the flow analysis code a bit to make it
22941 usable for dead code elimination.
22943 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22945 * cs-parser.jay: allow empty source files. Fixes bug #31781.
22947 2002-10-04 Miguel de Icaza <miguel@ximian.com>
22949 * expression.cs (ComposedCast.DoResolveType): A quick workaround
22950 to fix the test 165, will investigate deeper.
22952 2002-10-04 Martin Baulig <martin@gnome.org>
22954 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
22955 finally blocks actually work.
22956 (Try.Resolve): We don't need to create a sibling for `finally' if
22957 there is no finally block.
22959 2002-10-04 Martin Baulig <martin@gnome.org>
22961 * class.cs (Constructor.Define): The default accessibility for a
22962 non-default constructor is private, not public.
22964 2002-10-04 Miguel de Icaza <miguel@ximian.com>
22966 * class.cs (Constructor): Make AllowedModifiers public, add
22969 * cs-parser.jay: Perform the modifiers test here, as the
22970 constructor for the Constructor class usually receives a zero
22971 because of the way we create it (first we create, later we
22972 customize, and we were never checking the modifiers).
22974 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
22975 is a version of LookupTypeReflection that includes the type-name
22976 cache. This can be used as a fast path for functions that know
22977 the fully qualified name and are only calling into *.GetType() to
22978 obtain a composed type.
22980 This is also used by TypeManager.LookupType during its type
22983 (LookupType): We now also track the real type name, as sometimes
22984 we can get a quey for the real type name from things like
22985 ComposedCast. This fixes bug 31422.
22987 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
22988 complete type fullname, it does not have to go through the type
22989 resolution system to obtain the composed version of the type (for
22990 obtaining arrays or pointers).
22992 (Conditional.Emit): Use the EmitBoolExpression to
22993 generate nicer code, as requested by Paolo.
22995 (ArrayCreation.CheckIndices): Use the patch from
22996 hwang_rob@yahoo.ca to validate the array initializers.
22998 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23000 * class.cs (ConstructorInitializer.Emit): simplify code by using
23001 Invocation.EmitCall, and at the same time, fix the bugs in calling
23002 parent constructors that took variable arguments.
23004 * ecore.cs (Expression.ConvertNumericExplicit,
23005 Expression.ImplicitNumericConversion): Remove the code that
23006 manually wrapped decimal (InternalTypeConstructor call is now gone
23009 * expression.cs (Cast.TryReduce): Also handle decimal types when
23010 trying to perform a constant fold on the type.
23012 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23014 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23015 that only turned off an error report, and did nothing else.
23017 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23019 * driver.cs: Handle and ignore /fullpaths
23021 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23023 * expression.cs (Binary.ResolveOperator): Catch the case where
23024 DoNumericPromotions returns true,
23026 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23028 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23030 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23033 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23035 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23036 conversion exists, but it is also required that the conversion be
23037 performed. This manifested in "(Type64Enum) 2".
23039 * class.cs (TypeManager.AddMethod): The fix is not to change
23040 AddEnum, because that one was using a fully qualified name (every
23041 DeclSpace derivative does), but to change the AddMethod routine
23042 that was using an un-namespaced name. This now correctly reports
23043 the duplicated name.
23045 Revert patch until I can properly fix it. The issue
23046 is that we have a shared Type space across all namespaces
23047 currently, which is wrong.
23049 Options include making the Namespace a DeclSpace, and merge
23050 current_namespace/current_container in the parser.
23052 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23054 * cs-parser.jay: Improve error reporting when we get a different
23055 kind of expression in local_variable_type and
23056 local_variable_pointer_type.
23058 Propagate this to avoid missleading errors being reported.
23060 * ecore.cs (ImplicitReferenceConversion): treat
23061 TypeManager.value_type as a target just like object_type. As
23066 Is valid, and needs to result in the int 1 being boxed before it
23067 is assigned to the value type v.
23069 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23070 to validate the enumeration name.
23072 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23073 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23074 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23076 * ecore.cs (TryImplicitIntConversion): When doing an
23077 implicit-enumeration-conversion, check if the type is 64-bits and
23078 perform a conversion before passing to EnumConstant.
23080 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23082 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23083 report ambiguous type references. Unlike the MS version, we
23084 report what the ambiguity is. Innovation at work ;-)
23086 (DeclSpace.FindType): Require a location argument to
23087 display when we display an ambiguous error.
23089 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23091 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23093 * expression.cs (EmitDynamicInitializers): Apply patch from
23094 hwang_rob@yahoo.ca that fixes the order in which we emit our
23097 2002-09-21 Martin Baulig <martin@gnome.org>
23099 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23100 delegate takes no arguments.
23102 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23104 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23107 * expression.cs: Extract the underlying type.
23109 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
23111 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
23113 2002-09-19 Miguel de Icaza <miguel@ximian.com>
23115 * class.cs (TypeContainer.DefineType): We can not use the nice
23116 PackingSize with the size set to 1 DefineType method, because it
23117 will not allow us to define the interfaces that the struct
23120 This completes the fixing of bug 27287
23122 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
23123 means also structs. This fixes part of the problem.
23124 (Expresion.ImplicitReferenceConversionExists): ditto.
23126 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
23127 error if there were no errors reported during the type lookup
23128 process, to avoid duplicates or redundant errors. Without this
23129 you would get an ambiguous errors plus a type not found. We have
23130 beaten the user enough with the first error.
23132 (DeclSparce.FindType): Emit a warning if we have an ambiguous
23135 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
23136 during the resolution process, stop the lookup, this avoids
23137 repeated error reports (same error twice).
23139 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
23141 * typemanager.cs (LookupType): Redo the type lookup code to match
23142 the needs of System.Reflection.
23144 The issue is that System.Reflection requires references to nested
23145 types to begin with a "+" sign instead of a dot. So toplevel
23146 types look like: "NameSpace.TopLevelClass", and nested ones look
23147 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
23150 2002-09-19 Martin Baulig <martin@gnome.org>
23152 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
23153 says that a method always returns or always throws an exception,
23154 don't report the CS0161.
23156 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
23157 set `Returns = new_returns'.
23159 2002-09-19 Martin Baulig <martin@gnome.org>
23161 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
23162 to an enum constant, check for a CS0176.
23164 2002-09-18 Miguel de Icaza <miguel@ximian.com>
23166 * class.cs (TypeContainer.CheckPairedOperators): Now we check
23167 for operators that must be in pairs and report errors.
23169 * ecore.cs (SimpleName.DoResolveType): During the initial type
23170 resolution process, when we define types recursively, we must
23171 check first for types in our current scope before we perform
23172 lookups in the enclosing scopes.
23174 * expression.cs (MakeByteBlob): Handle Decimal blobs.
23176 (Invocation.VerifyArgumentsCompat): Call
23177 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
23178 I thought we were supposed to always call this, but there are a
23179 few places in the code where we dont do it.
23181 2002-09-17 Miguel de Icaza <miguel@ximian.com>
23183 * driver.cs: Add support in -linkres and -resource to specify the
23184 name of the identifier.
23186 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23188 * ecore.cs (StandardConversionExists): Sync with the conversion
23189 code: allow anything-* to void* conversions.
23191 (FindMostSpecificSource): Use an Expression argument
23192 instead of a Type, because we might be handed over a Literal which
23193 gets a few more implicit conversions that plain types do not. So
23194 this information was being lost.
23196 Also, we drop the temporary type-holder expression when not
23199 2002-09-17 Martin Baulig <martin@gnome.org>
23201 * class.cs (PropertyBase.CheckBase): Don't check the base class if
23202 this is an explicit interface implementation.
23204 2002-09-17 Martin Baulig <martin@gnome.org>
23206 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
23207 different `IndexerName' attributes.
23209 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
23210 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
23211 virtual CommonResolve().
23213 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23215 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
23216 and convert that to the UnderlyingType.
23218 * statement.cs (Foreach.Resolve): Indexers are just like variables
23219 or PropertyAccesses.
23221 * cs-tokenizer.cs (consume_string): Track line numbers and columns
23222 inside quoted strings, we were not doing this before.
23224 2002-09-16 Martin Baulig <martin@gnome.org>
23226 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
23227 resolve it. This is needed for the definite assignment check of the
23228 instance expression, fixes bug #29846.
23229 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
23231 2002-09-16 Nick Drochak <ndrochak@gol.com>
23233 * parameter.cs: Fix compile error. Cannot reference static member
23234 from an instance object. Is this an mcs bug?
23236 2002-09-14 Martin Baulig <martin@gnome.org>
23238 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
23239 multiple times. Fixes bug #30295, added test-166.cs.
23241 2002-09-14 Martin Baulig <martin@gnome.org>
23243 * statement.cs (Block.Emit): Don't emit unreachable code.
23244 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
23245 `break' statements.
23246 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
23248 2002-09-14 Martin Baulig <martin@gnome.org>
23250 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
23253 2002-09-14 Martin Baulig <martin@gnome.org>
23255 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
23256 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
23257 be false on the ms runtime.
23259 2002-09-13 Martin Baulig <martin@gnome.org>
23261 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
23262 the CS0038 error message.
23264 2002-09-12 Miguel de Icaza <miguel@ximian.com>
23266 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
23267 constant inside, return it.
23269 2002-09-12 Martin Baulig <martin@gnome.org>
23271 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
23272 implicit conversion can be done between enum types.
23274 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
23275 check whether an implicit conversion to the current enum's UnderlyingType
23276 exists and report an error if not.
23278 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
23279 without debugging support.
23281 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
23282 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
23284 2002-09-12 Martin Baulig <martin@gnome.org>
23286 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
23288 * ecore.cs (IMemberExpr.DeclaringType): New property.
23289 (SimpleName.SimpleNameResolve): Check whether we're accessing a
23290 nonstatic member of an outer type (CS0038).
23292 2002-09-11 Miguel de Icaza <miguel@ximian.com>
23294 * driver.cs: Activate the using-error detector at warning level
23295 4 (at least for MS-compatible APIs).
23297 * namespace.cs (VerifyUsing): Small buglett fix.
23299 * pending.cs (PendingImplementation): pass the container pointer.
23301 * interface.cs (GetMethods): Allow for recursive definition. Long
23302 term, I would like to move every type to support recursive
23303 definitions, not the current ordering mechanism that we have right
23306 The situation is this: Attributes are handled before interfaces,
23307 so we can apply attributes to interfaces. But some attributes
23308 implement interfaces, we will now handle the simple cases
23309 (recursive definitions will just get an error).
23311 * parameter.cs: Only invalidate types at the end if we fail to
23314 2002-09-09 Martin Baulig <martin@gnome.org>
23316 * ecore.cs (PropertyExpr.Emit): Also check for
23317 TypeManager.system_int_array_get_length so this'll also work when
23318 compiling corlib. Fixes #30003.
23320 2002-09-09 Martin Baulig <martin@gnome.org>
23322 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
23323 and throw an exception if we can't get the type's size. Fixed #30040,
23326 2002-09-09 Martin Baulig <martin@gnome.org>
23328 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
23330 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
23331 context. Fixes bug #30027.
23333 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
23334 virtual functions. Fixes bug #30043, added test-164.cs.
23336 2002-09-08 Ravi Pratap <ravi@ximian.com>
23338 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
23340 2002-09-08 Nick Drochak <ndrochak@gol.com>
23342 * driver.cs: Use an object to get the windows codepage since it's not a
23345 2002-09-08 Miguel de Icaza <miguel@ximian.com>
23347 * statement.cs (For.Emit): for infinite loops (test == null)
23348 return whether there is a break inside, not always "true".
23350 * namespace.cs (UsingEntry): New struct to hold the name of the
23351 using definition, the location where it is defined, and whether it
23352 has been used in a successful type lookup.
23354 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
23359 2002-09-06 Ravi Pratap <ravi@ximian.com>
23361 * attribute.cs : Fix incorrect code which relied on catching
23362 a NullReferenceException to detect a null being passed in
23363 where an object was expected.
23365 2002-09-06 Miguel de Icaza <miguel@ximian.com>
23367 * statement.cs (Try): flag the catch variable as assigned
23369 * expression.cs (Cast): Simplified by using ResolveType instead of
23370 manually resolving.
23372 * statement.cs (Catch): Fix bug by using ResolveType.
23374 2002-09-06 Ravi Pratap <ravi@ximian.com>
23376 * expression.cs (BetterConversion): Special case for when we have
23377 a NullLiteral as the argument and we have to choose between string
23378 and object types - we choose string the way csc does.
23380 * attribute.cs (Attribute.Resolve): Catch the
23381 NullReferenceException and report error #182 since the Mono
23382 runtime no more has the bug and having this exception raised means
23383 we tried to select a constructor which takes an object and is
23386 2002-09-05 Ravi Pratap <ravi@ximian.com>
23388 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
23389 message (1502, 1503) when we can't locate a method after overload
23390 resolution. This is much more informative and closes the bug
23393 * interface.cs (PopulateMethod): Return if there are no argument
23394 types. Fixes a NullReferenceException bug.
23396 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
23397 expressions too. Previously we were checking only in one place for
23398 positional arguments leaving out named arguments.
23400 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
23401 type to the enum type is not allowed. Remove code corresponding to
23404 (ConvertNumericExplicit): Allow explicit conversions from
23405 the underlying type to enum type. This precisely follows the spec
23406 and closes a bug filed by Gonzalo.
23408 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23411 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
23413 2002-09-03 Miguel de Icaza <miguel@ximian.com>
23415 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
23416 it was important that we stored the right value after the
23417 reduction in `converted'.
23419 2002-09-04 Martin Baulig <martin@gnome.org>
23421 * location.cs (Location.SymbolDocument): Use full pathnames for the
23424 2002-08-30 Miguel de Icaza <miguel@ximian.com>
23426 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
23427 of the expression resolve mechanism, because that will catch the
23428 SimpleName error failures.
23430 (Conditional): If we can not resolve the
23431 expression, return, do not crash.
23433 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23436 (location): display token name instead of its number.
23438 2002-08-28 Martin Baulig <martin@gnome.org>
23440 * expression.cs (Binary.ResolveOperator): Don't silently return
23441 but return an error if an operator cannot be applied between two
23444 2002-08-28 Martin Baulig <martin@gnome.org>
23446 * class.cs (Constructor.Define): Set the permission attributes
23447 correctly instead of making all constructors public.
23449 2002-08-28 Martin Baulig <martin@gnome.org>
23451 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
23452 for private members before reporting a CS0103; if we find anything,
23455 2002-08-28 Martin Baulig <martin@gnome.org>
23457 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
23458 to check whether `closure_start_type == closure_invocation_type',
23459 we also need to check whether `m.DeclaringType == closure_invocation_type'
23460 before bypassing the permission checks. We might be accessing
23461 protected/private members from the base class.
23462 (TypeManager.RealMemberLookup): Only set private_ok if private
23463 members were requested via BindingFlags.NonPublic.
23465 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
23467 * expression.cs (MemberAccess.ResolveMemberAccess): Set
23468 MethodGroupExpr.IsExplicitImpl if appropriate.
23469 (Invocation.DoResolve): Don't report the CS0120 for explicit
23470 interface implementations.
23472 2002-08-27 Martin Baulig <martin@gnome.org>
23474 * expression.cs (Invocation.DoResolve): If this is a static
23475 method and we don't have an InstanceExpression, we must report
23478 2002-08-25 Martin Baulig <martin@gnome.org>
23480 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
23481 `==' between a valuetype and an object.
23483 2002-08-25 Miguel de Icaza <miguel@ximian.com>
23485 * ecore.cs (TypeExpr): Provide a ToString method.
23487 2002-08-24 Martin Baulig <martin@gnome.org>
23489 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
23490 now called proggie.dbg and it's a binary file.
23492 2002-08-23 Martin Baulig <martin@gnome.org>
23494 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
23496 2002-08-23 Martin Baulig <martin@gnome.org>
23498 * struct.cs (MyStructInfo.ctor): Make this work with empty
23499 structs; it's not allowed to use foreach() on null.
23501 2002-08-23 Martin Baulig <martin@gnome.org>
23503 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
23504 writer the full pathname of the generated assembly.
23506 2002-08-23 Martin Baulig <martin@gnome.org>
23508 * statements.cs (FlowBranching.UsageVector.MergeChildren):
23509 A `finally' block never returns or breaks; improved handling of
23512 2002-08-23 Martin Baulig <martin@gnome.org>
23514 * statement.cs (Throw.Resolve): Allow `throw null'.
23516 2002-08-23 Martin Baulig <martin@gnome.org>
23518 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
23519 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
23520 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
23521 MemberLookup would return a wrong event if this is an explicit
23522 interface implementation and the class has an event with the same
23525 2002-08-23 Martin Baulig <martin@gnome.org>
23527 * statement.cs (Block.AddChildVariableNames): New public method.
23528 (Block.AddChildVariableName): Likewise.
23529 (Block.IsVariableNameUsedInChildBlock): Likewise.
23530 (Block.AddVariable): Check whether a variable name has already
23531 been used in a child block.
23533 * cs-parser.jay (declare_local_variables): Mark all variable names
23534 from the current block as being used in a child block in the
23537 2002-08-23 Martin Baulig <martin@gnome.org>
23539 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
23540 find the symbol writer.
23542 * driver.cs: csc also allows the arguments to /define being
23543 separated by commas, not only by semicolons.
23545 2002-08-23 Martin Baulig <martin@gnome.org>
23547 * interface.cs (Interface.GetMembers): Added static check for events.
23549 2002-08-15 Martin Baulig <martin@gnome.org>
23551 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
23552 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
23554 * ecore.cs (Expression.MemberLookup): Added documentation and explained
23555 why the MethodData.EmitDestructor() change was necessary.
23557 2002-08-20 Martin Baulig <martin@gnome.org>
23559 * class.cs (TypeContainer.FindMembers): Added static check for events.
23561 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
23563 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
23564 use Type.GetEvents(), not Type.FindMembers().
23566 2002-08-20 Martin Baulig <martin@gnome.org>
23568 * decl.cs (MemberCache): Added a special method cache which will
23569 be used for method-only searched. This ensures that a method
23570 search will return a MethodInfo with the correct ReflectedType for
23573 2002-08-20 Martin Baulig <martin@gnome.org>
23575 * decl.cs (DeclSpace.FindMembers): Made this public.
23577 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23579 * delegate.cs: fixed build on windows.
23580 [FIXME: Filed as bug #29150: MCS must report these errors.]
23582 2002-08-19 Ravi Pratap <ravi@ximian.com>
23584 * ecore.cs (StandardConversionExists): Return a false
23585 if we are trying to convert the void type to anything else
23586 since that is not allowed.
23588 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
23589 we flag error 70 in the event an event is trying to be accessed
23590 directly from outside the declaring type.
23592 2002-08-20 Martin Baulig <martin@gnome.org>
23594 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
23595 MemberCache from typemanager.cs to decl.cs.
23597 2002-08-19 Martin Baulig <martin@gnome.org>
23599 * class.cs (TypeContainer): Implement IMemberContainer.
23600 (TypeContainer.DefineMembers): Create the MemberCache.
23601 (TypeContainer.FindMembers): Do better BindingFlags checking; only
23602 return public members if BindingFlags.Public was given, check
23603 whether members are static.
23605 2002-08-16 Martin Baulig <martin@gnome.org>
23607 * decl.cs (DeclSpace.Define): Splitted this in Define and
23608 DefineMembers. DefineMembers is called first and initializes the
23611 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
23612 DefineMembers() on all our DeclSpaces.
23614 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
23615 but call DefineMembers() on all nested interfaces. We call their
23616 Define() in our new Define() function.
23618 * interface.cs (Interface): Implement IMemberContainer.
23619 (Interface.Define): Moved all code except the attribute stuf to
23621 (Interface.DefineMembers): Initialize the member cache.
23623 * typemanager.cs (IMemberFinder): Removed this interface, we don't
23624 need this anymore since we can use MemberCache.FindMembers directly.
23626 2002-08-19 Martin Baulig <martin@gnome.org>
23628 * typemanager.cs (MemberCache): When creating the cache for an
23629 interface type, add all inherited members.
23630 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
23631 to `out bool used_cache' and documented it.
23632 (TypeManager.MemberLookup): If we already used the cache in the first
23633 iteration, we don't need to do the interfaces check.
23635 2002-08-19 Martin Baulig <martin@gnome.org>
23637 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
23638 here from IMemberFinder and don't implement this interface anymore.
23639 (DeclSpace.MemberCache): Moved here from IMemberFinder.
23641 * typemanager.cs (IMemberFinder): This interface is now only used by
23642 classes which actually support the member cache.
23643 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
23644 since we only put DeclSpaces into this Hashtable.
23645 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
23646 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
23648 2002-08-16 Martin Baulig <martin@gnome.org>
23650 * typemanager.cs (ICachingMemberFinder): Removed.
23651 (IMemberFinder.MemberCache): New property.
23652 (TypeManager.FindMembers): Merged this with RealFindMembers().
23653 This function will never be called from TypeManager.MemberLookup()
23654 so we can't use the cache here, just the IMemberFinder.
23655 (TypeManager.MemberLookup_FindMembers): Check whether the
23656 IMemberFinder has a MemberCache and call the cache's FindMembers
23658 (MemberCache): Rewrote larger parts of this yet another time and
23659 cleaned it up a bit.
23661 2002-08-15 Miguel de Icaza <miguel@ximian.com>
23663 * driver.cs (LoadArgs): Support quoting.
23665 (Usage): Show the CSC-like command line arguments.
23667 Improved a few error messages.
23669 2002-08-15 Martin Baulig <martin@gnome.org>
23671 * typemanager.cs (IMemberContainer.Type): New property.
23672 (IMemberContainer.IsInterface): New property.
23674 The following changes are conditional to BROKEN_RUNTIME, which is
23675 defined at the top of the file.
23677 * typemanager.cs (MemberCache.MemberCache): Don't add the base
23678 class'es members, but add all members from TypeHandle.ObjectType
23679 if we're an interface.
23680 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
23681 is the current type.
23682 (MemberCache.CacheEntry.Container): Removed this field.
23683 (TypeHandle.GetMembers): Include inherited members.
23685 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23687 * typemanager.cs: fixed compilation and added a comment on a field that
23690 2002-08-15 Martin Baulig <martin@gnome.org>
23692 * class.cs (ConstructorInitializer.Resolve): In the
23693 Expression.MemberLookup call, use the queried_type as
23696 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
23697 declared' attribute, it's always true.
23698 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
23699 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
23700 temporary wrapper for FindMembers which tells MemberLookup whether
23701 members from the base classes are included in the return value.
23702 This will go away soon.
23703 (TypeManager.MemberLookup): Use this temporary hack here; once the
23704 new MemberCache is completed, we don't need to do the DeclaredOnly
23705 looping here anymore since the MemberCache will take care of this.
23706 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
23707 (MemberCache): When creating the MemberCache for a class, get
23708 members from the current class and all its base classes.
23709 (MemberCache.CacheEntry.Container): New field. This is a
23710 temporary hack until the Mono runtime is fixed to distinguish
23711 between ReflectedType and DeclaringType. It allows us to use MCS
23712 with both the MS runtime and the unfixed Mono runtime without
23713 problems and without accecting performance.
23714 (MemberCache.SearchMembers): The DeclaredOnly looping from
23715 TypeManager.MemberLookup is now done here.
23717 2002-08-14 Martin Baulig <martin@gnome.org>
23719 * statement.cs (MyStructInfo.MyStructInfo): Don't call
23720 Type.GetFields on dynamic types but get the fields from the
23721 corresponding TypeContainer.
23722 (MyStructInfo.GetStructInfo): Added check for enum types.
23724 * typemanager.cs (MemberList.IsSynchronized): Implemented.
23725 (MemberList.SyncRoot): Implemented.
23726 (TypeManager.FilterWithClosure): No need to check permissions if
23727 closure_start_type == closure_invocation_type, don't crash if
23728 closure_invocation_type is null.
23730 2002-08-13 Martin Baulig <martin@gnome.org>
23732 Rewrote TypeContainer.FindMembers to use a member cache. This
23733 gives us a speed increase of about 35% for the self-hosting MCS
23734 build and of about 15-20% for the class libs (both on GNU/Linux).
23736 * report.cs (Timer): New class to get enhanced profiling. This
23737 whole class is "TIMER" conditional since it remarkably slows down
23740 * class.cs (MemberList): New class. This is an IList wrapper
23741 which we're now using instead of passing MemberInfo[]'s around to
23742 avoid copying this array unnecessarily.
23743 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
23744 (ICachingMemberFinder, IMemberContainer): New interface.
23745 (TypeManager.FilterWithClosure): If `criteria' is null, the name
23746 has already been checked, otherwise use it for the name comparision.
23747 (TypeManager.FindMembers): Renamed to RealMemberFinder and
23748 provided wrapper which tries to use ICachingMemberFinder.FindMembers
23749 if possible. Returns a MemberList, not a MemberInfo [].
23750 (TypeHandle): New class, implements IMemberContainer. We create
23751 one instance of this class per type, it contains a MemberCache
23752 which is used to do the member lookups.
23753 (MemberCache): New class. Each instance of this class contains
23754 all members of a type and a name-based hash table.
23755 (MemberCache.FindMembers): This is our new member lookup
23756 function. First, it looks up all members of the requested name in
23757 the hash table. Then, it walks this list and sorts out all
23758 applicable members and returns them.
23760 2002-08-13 Martin Baulig <martin@gnome.org>
23762 In addition to a nice code cleanup, this gives us a performance
23763 increase of about 1.4% on GNU/Linux - not much, but it's already
23764 half a second for the self-hosting MCS compilation.
23766 * typemanager.cs (IMemberFinder): New interface. It is used by
23767 TypeManager.FindMembers to call FindMembers on a TypeContainer,
23768 Enum, Delegate or Interface.
23769 (TypeManager.finder_to_member_finder): New PtrHashtable.
23770 (TypeManager.finder_to_container): Removed.
23771 (TypeManager.finder_to_delegate): Removed.
23772 (TypeManager.finder_to_interface): Removed.
23773 (TypeManager.finder_to_enum): Removed.
23775 * interface.cs (Interface): Implement IMemberFinder.
23777 * delegate.cs (Delegate): Implement IMemberFinder.
23779 * enum.cs (Enum): Implement IMemberFinder.
23781 * class.cs (TypeContainer): Implement IMemberFinder.
23783 2002-08-12 Martin Baulig <martin@gnome.org>
23785 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
23787 2002-08-12 Martin Baulig <martin@gnome.org>
23789 * ecore.cs (ITypeExpression): New interface for expressions which
23791 (TypeExpression): Renamed to TypeLookupExpression.
23792 (Expression.DoResolve): If we're doing a types-only lookup, the
23793 expression must implement the ITypeExpression interface and we
23794 call DoResolveType() on it.
23795 (SimpleName): Implement the new ITypeExpression interface.
23796 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
23797 hack, the situation that we're only looking up types can't happen
23798 anymore when this method is called. Moved the type lookup code to
23799 DoResolveType() and call it.
23800 (SimpleName.DoResolveType): This ITypeExpression interface method
23801 is now doing the types-only lookup.
23802 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
23803 (ResolveFlags): Added MaskExprClass.
23805 * expression.cs (MemberAccess): Implement the ITypeExpression
23807 (MemberAccess.DoResolve): Added support for a types-only lookup
23808 when we're called via ITypeExpression.DoResolveType().
23809 (ComposedCast): Implement the ITypeExpression interface.
23811 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
23812 Expression.Resolve() with ResolveFlags.Type instead.
23814 2002-08-12 Martin Baulig <martin@gnome.org>
23816 * interface.cs (Interface.Define): Apply attributes.
23818 * attribute.cs (Attribute.ApplyAttributes): Added support for
23819 interface attributes.
23821 2002-08-11 Martin Baulig <martin@gnome.org>
23823 * statement.cs (Block.Emit): Only check the "this" variable if we
23824 do not always throw an exception.
23826 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
23827 whether the property has a set accessor.
23829 2002-08-11 Martin Baulig <martin@gnome.org>
23831 Added control flow analysis support for structs.
23833 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
23834 with control flow analysis turned off.
23835 (IVariable): New interface.
23836 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
23837 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
23838 (FieldExpr.DoResolve): Resolve the instance expression with flow
23839 analysis turned off and do the definite assignment check after the
23840 resolving when we know what the expression will resolve to.
23842 * expression.cs (LocalVariableReference, ParameterReference):
23843 Implement the new IVariable interface, only call the flow analysis
23844 code if ec.DoFlowAnalysis is true.
23845 (This): Added constructor which takes a Block argument. Implement
23846 the new IVariable interface.
23847 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
23848 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
23849 This does the definite assignment checks for struct members.
23851 * class.cs (Constructor.Emit): If this is a non-static `struct'
23852 constructor which doesn't have any initializer, call
23853 Block.AddThisVariable() to tell the flow analysis code that all
23854 struct elements must be initialized before control returns from
23857 * statement.cs (MyStructInfo): New public class.
23858 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
23859 argument to this indexer. If non-zero, check an individual struct
23860 member, not the whole struct.
23861 (FlowBranching.CheckOutParameters): Check struct members.
23862 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
23863 overloaded versions of these methods which take an additional
23864 `int field_idx' argument to check struct members.
23865 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
23866 overloaded versions of these methods which take an additional
23867 `string field_name' argument to check struct member.s
23868 (VariableInfo): Implement the IVariable interface.
23869 (VariableInfo.StructInfo): New public property. Returns the
23870 MyStructInfo instance of the variable if it's a struct or null.
23871 (Block.AddThisVariable): New public method. This is called from
23872 Constructor.Emit() for non-static `struct' constructor which do
23873 not have any initializer. It creates a special variable for the
23874 "this" instance variable which will be checked by the flow
23875 analysis code to ensure that all of the struct's fields are
23876 initialized before control returns from the constructor.
23877 (UsageVector): Added support for struct members. If a
23878 variable/parameter is a struct with N members, we reserve a slot
23879 in the usage vector for each member. A struct is considered fully
23880 initialized if either the struct itself (slot 0) or all its
23881 members are initialized.
23883 2002-08-08 Martin Baulig <martin@gnome.org>
23885 * driver.cs (Driver.MainDriver): Only report an error CS5001
23886 if there were no compilation errors.
23888 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
23889 `UnsafeContext' property to determine whether the parent is in
23890 unsafe context rather than checking the parent's ModFlags:
23891 classes nested in an unsafe class are unsafe as well.
23893 2002-08-08 Martin Baulig <martin@gnome.org>
23895 * statement.cs (UsageVector.MergeChildren): Distinguish between
23896 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
23897 we return. Added test17() and test18() to test-154.cs.
23899 2002-08-08 Martin Baulig <martin@gnome.org>
23901 * typemanager.cs (TypeManager.FilterWithClosure): If we have
23902 Family access, make sure the invoking type isn't a subclass of the
23903 queried type (that'd be a CS1540).
23905 * ecore.cs (Expression.MemberLookup): Added overloaded version of
23906 this method which takes an additional `Type invocation_type'.
23908 * expression.cs (BaseAccess.DoResolve): Use the base type as
23909 invocation and query type.
23910 (MemberAccess.DoResolve): If the lookup failed and we're about to
23911 report a CS0122, try a lookup with the ec.ContainerType - if this
23912 succeeds, we must report a CS1540.
23914 2002-08-08 Martin Baulig <martin@gnome.org>
23916 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
23917 (MethodGroupExpr): Implement the IMemberExpr interface.
23919 * expression (MemberAccess.ResolveMemberAccess): No need to have
23920 any special code for MethodGroupExprs anymore, they're now
23923 2002-08-08 Martin Baulig <martin@gnome.org>
23925 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
23926 Family, FamANDAssem and FamORAssem permissions.
23927 (TypeManager.IsSubclassOrNestedChildOf): New public method.
23929 2002-08-08 Martin Baulig <martin@gnome.org>
23931 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
23932 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
23935 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
23937 * driver.cs: implemented /resource option to embed managed resources.
23939 2002-08-07 Martin Baulig <martin@gnome.org>
23941 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
23942 (FieldBase.HasFieldInitializer): New public property.
23943 (FieldBase.GetInitializerExpression): New public method. Resolves and
23944 returns the field initializer and makes sure it is only resolved once.
23945 (TypeContainer.EmitFieldInitializers): Call
23946 FieldBase.GetInitializerExpression to get the initializer, this ensures
23947 that it isn't resolved multiple times.
23949 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
23950 the resolving process (SimpleName/MemberLookup) that we're currently
23951 emitting a field initializer (which must not access any instance members,
23952 this is an error CS0236).
23954 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
23955 argument, if the `IsFieldInitializer' flag is set, we must report and
23956 error CS0236 and not an error CS0120.
23958 2002-08-07 Martin Baulig <martin@gnome.org>
23960 * ecore.cs (IMemberExpr): New public interface.
23961 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
23962 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
23963 if the expression is an IMemberExpr.
23965 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
23966 to be null, implicitly default to `this' if we're non-static in
23967 this case. Simplified the code a lot by using the new IMemberExpr
23968 interface. Also fixed bug #28176 here.
23970 2002-08-06 Martin Baulig <martin@gnome.org>
23972 * cs-parser.jay (SimpleLookup): Removed. We need to create
23973 ParameterReferences during semantic analysis so that we can do a
23974 type-only search when resolving Cast, TypeOf and SizeOf.
23975 (block): Pass the `current_local_parameters' to the Block's
23978 * class.cs (ConstructorInitializer): Added `Parameters parameters'
23979 argument to the constructor.
23980 (ConstructorInitializer.Resolve): Create a temporary implicit
23981 block with the parameters.
23983 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
23984 references here if we aren't doing a type-only search.
23986 * statement.cs (Block): Added constructor which takes a
23987 `Parameters parameters' argument.
23988 (Block.Parameters): New public property.
23990 * support.cs (InternalParameters.Parameters): Renamed `parameters'
23991 to `Parameters' and made it public readonly.
23993 2002-08-06 Martin Baulig <martin@gnome.org>
23995 * ecore.cs (Expression.Warning): Made this public as well.
23997 * report.cs (Report.Debug): Print the contents of collections.
23999 2002-08-06 Martin Baulig <martin@gnome.org>
24001 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24002 used to tell Resolve() which kinds of expressions it may return.
24003 (Expression.Resolve): Added overloaded version of this method which
24004 takes a `ResolveFlags flags' argument. This can be used to tell
24005 Resolve() which kinds of expressions it may return. Reports a
24007 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24008 ResolveFlags.SimpleName.
24009 (Expression.Error118): Added overloaded version of this method which
24010 takes a `ResolveFlags flags' argument. It uses the flags to determine
24011 which kinds of expressions are allowed.
24013 * expression.cs (Argument.ResolveMethodGroup): New public method.
24014 Resolves an argument, but allows a MethodGroup to be returned.
24015 This is used when invoking a delegate.
24017 * TODO: Updated a bit.
24019 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24021 Fixed compilation with csc.
24023 * ecore.cs: Expression.Error made public. Is this correct? Should
24024 Warning be made public too?
24026 * expression.cs: use ea.Location instead of ea.loc.
24027 [FIXME: Filed as bug #28607: MCS must report these errors.]
24029 2002-08-06 Martin Baulig <martin@gnome.org>
24031 * ecore.cs (Expression.loc): Moved the location here instead of
24032 duplicating it in all derived classes.
24033 (Expression.Location): New public property.
24034 (Expression.Error, Expression.Warning): Made them non-static and
24035 removed the location argument.
24036 (Expression.Warning): Added overloaded version which takes an
24037 `int level' argument.
24038 (Expression.Error118): Make this non-static and removed the
24039 expression and location arguments.
24040 (TypeExpr): Added location argument to the constructor.
24042 * expression.cs (StaticCallExpr): Added location argument to
24044 (Indirection, PointerArithmetic): Likewise.
24045 (CheckedExpr, UnCheckedExpr): Likewise.
24046 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24047 (StringPtr): Likewise.
24050 2002-08-05 Martin Baulig <martin@gnome.org>
24052 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24054 * assign.cs (Assign.DoResolve): Check whether the source
24055 expression is a value or variable.
24057 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24058 while resolving the corresponding blocks.
24060 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24061 an error, don't silently return null.
24063 * statement.cs (Block.AddVariable): Do the error reporting here
24064 and distinguish between CS0128 and CS0136.
24065 (Block.DoResolve): Report all unused labels (warning CS0164).
24066 (LabeledStatement): Pass the location to the constructor.
24067 (LabeledStatement.HasBeenReferenced): New property.
24068 (LabeledStatement.Resolve): Set it to true here.
24070 * statement.cs (Return.Emit): Return success even after reporting
24071 a type mismatch error (CS0126 or CS0127), this is what csc does and
24072 it avoids confusing the users with any consecutive errors.
24074 2002-08-05 Martin Baulig <martin@gnome.org>
24076 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24078 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24080 * expression.cs (MemberAccess.DoResolve): Silently return if an
24081 error has already been reported.
24083 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24084 error has already been reported.
24086 2002-08-05 Martin Baulig <martin@gnome.org>
24088 * statement.cs (UsageVector): Only initialize the `parameters'
24089 vector if we actually have any "out" parameters.
24091 2002-08-05 Martin Baulig <martin@gnome.org>
24093 * expression.cs (Binary.ResolveOperator): When combining delegates,
24094 they must have the same type.
24096 2002-08-05 Martin Baulig <martin@gnome.org>
24098 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24099 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24100 work with the ms runtime and we also don't need it: if we're a
24101 PropertyBuilder and not in the `indexer_arguments' hash, then we
24102 are a property and not an indexer.
24104 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24105 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24106 since the latter one doesn't work with the ms runtime.
24108 2002-08-03 Martin Baulig <martin@gnome.org>
24110 Fixed bugs #27998 and #22735.
24112 * class.cs (Method.IsOperator): New public field.
24113 (Method.CheckBase): Report CS0111 if there's already a method
24114 with the same parameters in the current class. Report CS0508 when
24115 attempting to change the return type of an inherited method.
24116 (MethodData.Emit): Report CS0179 if a method doesn't have a body
24117 and it's not marked abstract or extern.
24118 (PropertyBase): New abstract base class for Property and Indexer.
24119 (PropertyBase.CheckBase): Moved here from Property and made it work
24121 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
24122 the same so we can reuse it there.
24123 (Property, Indexer): Derive from PropertyBase.
24124 (MethodSignature.inheritable_property_signature_filter): New delegate
24125 to find properties and indexers.
24127 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
24128 argument and improved error reporting.
24130 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
24131 EmptyReadOnlyParameters and made it a property.
24133 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
24134 version of this method which takes a `PropertyInfo indexer'.
24135 (TypeManager.RegisterIndexer): New method.
24137 * class.cs: Added myself as author of this file :-)
24139 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24141 * class.cs: fixed compilation on windoze.
24143 2002-08-03 Martin Baulig <martin@gnome.org>
24145 * interface.cs (Interface.GetInterfaceBases): Check whether all
24146 base interfaces are at least as accessible than the current one.
24148 * class.cs (TypeContainer.GetClassBases): Check whether base types
24149 are at least as accessible than the current type.
24150 (TypeContainer.AsAccessible): Implemented and made non-static.
24151 (MemberBase.CheckParameters): Report errors if the accessibility
24154 * delegate.cs (Delegate.Delegate): The default visibility is
24155 internal for top-level types and private for nested types.
24156 (Delegate.Define): Report errors if the accessibility checks fail.
24158 * enum.cs (Enum.Enum): The default visibility is internal for
24159 top-level types and private for nested types.
24160 (Enum.DefineType): Compute the correct visibility.
24162 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
24163 function which takes a `bool is_toplevel' instead of a TypeContainer.
24165 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
24168 2002-08-02 Martin Baulig <martin@gnome.org>
24170 * expression.cs (LocalVariableReferenc): Added constructor which
24171 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
24172 (LocalVariableReference.IsReadOnly): New property.
24173 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
24174 variable is readonly, use our own readonly flag to do this; you can
24175 use the new constructor to get a writable reference to a read-only
24178 * cs-parser.jay (foreach_statement, using_statement): Get a writable
24179 reference to the local variable.
24181 2002-08-01 Miguel de Icaza <miguel@ximian.com>
24183 * rootcontext.cs (ResolveCore): Also include System.Exception
24185 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
24186 we reach an EmptyStatement.
24188 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
24191 * expression.cs (Binary.ResolveOperator): Check error result in
24194 use brtrue/brfalse directly and avoid compares to null.
24196 2002-08-02 Martin Baulig <martin@gnome.org>
24198 * class.cs (TypeContainer.Define): Define all nested interfaces here.
24199 Fixes bug #28407, added test-155.cs.
24201 2002-08-01 Martin Baulig <martin@gnome.org>
24203 * class.cs (Event.EmitDefaultMethod): Make this work with static
24204 events. Fixes #28311, added verify-3.cs.
24206 2002-08-01 Martin Baulig <martin@gnome.org>
24208 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
24209 `is_disposable' fields.
24210 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
24211 `hm.is_disposable' if we're using the collection pattern.
24212 (Foreach.EmitCollectionForeach): Use the correct type for the
24213 enumerator's local variable, only emit the try/finally block if
24214 necessary (fixes #27713).
24216 2002-08-01 Martin Baulig <martin@gnome.org>
24218 * ecore.cs (Expression.report118): Renamed to Error118 and made
24221 * statement.cs (Throw.Resolve): Check whether the expression is of
24222 the correct type (CS0118) and whether the type derives from
24223 System.Exception (CS0155).
24224 (Catch.Resolve): New method. Do the type lookup here and check
24225 whether it derives from System.Exception (CS0155).
24226 (Catch.CatchType, Catch.IsGeneral): New public properties.
24228 * typemanager.cs (TypeManager.exception_type): Added.
24230 2002-07-31 Miguel de Icaza <miguel@ximian.com>
24232 * driver.cs: Updated About function.
24234 2002-07-31 Martin Baulig <martin@gnome.org>
24236 Implemented Control Flow Analysis.
24238 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
24239 (EmitContext.CurrentBranching): Added.
24240 (EmitContext.StartFlowBranching): Added.
24241 (EmitContext.EndFlowBranching): Added.
24242 (EmitContext.KillFlowBranching): Added.
24243 (EmitContext.IsVariableAssigned): Added.
24244 (EmitContext.SetVariableAssigned): Added.
24245 (EmitContext.IsParameterAssigned): Added.
24246 (EmitContext.SetParameterAssigned): Added.
24247 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
24248 Added control flow analysis stuff here.
24250 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
24251 resolve the expression as lvalue.
24252 (LocalVariableReference.DoResolve): Check whether the variable has
24253 already been assigned.
24254 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
24255 the parameter as assigned here.
24256 (ParameterReference.DoResolve): Check whether the parameter has already
24258 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
24259 expression as lvalue.
24261 * statement.cs (FlowBranching): New class for the flow analysis code.
24262 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
24263 (LabeledStatement.IsDefined): New public property.
24264 (LabeledStatement.AddUsageVector): New public method to tell flow
24265 analyis that the label may be reached via a forward jump.
24266 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
24268 (VariableInfo.Number): New public field. This is used by flow analysis
24269 to number all locals of a block.
24270 (Block.CountVariables): New public property. This is the number of
24271 local variables in this block (including the locals from all parent
24273 (Block.EmitMeta): Number all the variables.
24275 * statement.cs: Added flow analysis support to all classes.
24277 2002-07-31 Martin Baulig <martin@gnome.org>
24279 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
24280 To get debugging messages, compile mcs with /define:MCS_DEBUG and
24281 then use this argument.
24283 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
24285 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
24286 use this to specify /define options.
24288 2002-07-29 Martin Baulig <martin@gnome.org>
24290 * statement.cs (Fixed): Moved all code that does variable lookups
24291 and resolvings from Emit to Resolve.
24293 * statement.cs (For): Moved all code that does variable lookups
24294 and resolvings from Emit to Resolve.
24296 * statement.cs (Using): Moved all code that does variable lookups
24297 and resolvings from Emit to Resolve.
24299 2002-07-29 Martin Baulig <martin@gnome.org>
24301 * attribute.cs (Attribute.Resolve): Explicitly catch a
24302 System.NullReferenceException when creating the
24303 CustromAttributeBuilder and report a different warning message.
24305 2002-07-29 Martin Baulig <martin@gnome.org>
24307 * support.cs (ParameterData.ParameterName): Added method to
24308 get the name of a parameter.
24310 * typemanager.cs (TypeManager.IsValueType): New public method.
24312 2002-07-29 Martin Baulig <martin@gnome.org>
24314 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
24315 is a flag which specifies that it's either ref or out.
24316 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
24317 the out parameter to `out Parameter.Modifier mod', also set the
24318 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
24320 * support.cs (InternalParameters.ParameterModifier): Distinguish
24321 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24322 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24324 * expression.cs (Argument.GetParameterModifier): Distinguish
24325 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24326 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24328 2002-07-29 Martin Baulig <martin@gnome.org>
24330 * expression.cs (ParameterReference.ParameterReference): Added
24331 `Location loc' argument to the constructor.
24333 * cs-parser.jay: Pass location to ParameterReference.
24335 2002-07-28 Miguel de Icaza <miguel@ximian.com>
24337 * statement.cs (Try): Initialize the location.
24339 * cs-parser.jay: pass location to Try.
24341 * expression.cs (Unary.Reduce): Change the prototype to return
24342 whether a constant fold could be performed or not. The result is
24343 returned in an out parameters. In the case of Indirection and
24344 AddressOf, we want to perform the full tests.
24346 2002-07-26 Miguel de Icaza <miguel@ximian.com>
24348 * statement.cs (Statement.Emit): Flag dead code.
24350 2002-07-27 Andrew Birkett <andy@nobugs.org>
24352 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
24354 2002-07-27 Martin Baulig <martin@gnome.org>
24356 * class.cs (MethodData.Define): Put back call to
24357 TypeManager.AddMethod(), accidentally commented this out.
24359 * report.cs (Debug): New public method to print debugging information,
24360 this is `[Conditional ("DEBUG")]'.
24362 2002-07-26 Martin Baulig <martin@gnome.org>
24364 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
24365 (switch_statement): Push the current_block to the switch_stack and
24366 pop it again when we're done with the switch.
24367 (switch_section): The new block is a child of the current_block.
24368 Fixes bug #24007, added test-152.cs.
24370 2002-07-27 Martin Baulig <martin@gnome.org>
24372 * expression.cs (Invocation.EmitArguments): When calling a varargs
24373 function with only its fixed arguments, we need to pass an empty
24376 2002-07-27 Martin Baulig <martin@gnome.org>
24378 Mono 0.13 has been released.
24380 2002-07-25 Miguel de Icaza <miguel@ximian.com>
24382 * driver.cs: Rename --resource to --linkres, because that is what
24383 we do currently, we dont support --resource yet.
24385 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
24387 2002-07-25 Martin Baulig <martin@gnome.org>
24389 * class.cs (MethodData): New public class. This is a `method builder'
24390 class for a method or one accessor of a Property/Indexer/Event.
24391 (MethodData.GetMethodFlags): Moved here from MemberBase.
24392 (MethodData.ApplyAttributes): Likewise.
24393 (MethodData.ApplyObsoleteAttribute): Likewise.
24394 (MethodData.ApplyConditionalAttribute): Likewise.
24395 (MethodData.ApplyDllImportAttribute): Likewise.
24396 (MethodData.CheckAbstractAndExternal): Likewise.
24397 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
24398 (MethodData.Emit): Formerly known as Method.Emit().
24399 (MemberBase): Moved everything which was specific to a single
24400 accessor/method to MethodData.
24401 (Method): Create a new MethodData and call Define() and Emit() on it.
24402 (Property, Indexer, Event): Create a new MethodData objects for each
24403 accessor and call Define() and Emit() on them.
24405 2002-07-25 Martin Baulig <martin@gnome.org>
24407 Made MethodCore derive from MemberBase to reuse the code from there.
24408 MemberBase now also checks for attributes.
24410 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
24411 (MemberBase.GetMethodFlags): Moved here from class Method and marked
24413 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
24414 `CallingConventions cc' and `Attributes opt_attrs' arguments.
24415 (MemberBase.ApplyAttributes): New virtual method; applies the
24416 attributes to a method or accessor.
24417 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
24418 (MemberBase.ApplyConditionalAttribute): Likewise.
24419 (MemberBase.ApplyDllImportAttribute): Likewise.
24420 (MemberBase.CheckAbstractAndExternal): Likewise.
24421 (MethodCore.ParameterTypes): This is now a property instead of a
24422 method, it's initialized from DoDefineParameters().
24423 (MethodCore.ParameterInfo): Removed the set accessor.
24424 (MethodCore.DoDefineParameters): New protected virtual method to
24425 initialize ParameterTypes and ParameterInfo.
24426 (Method.GetReturnType): We can now simply return the MemberType.
24427 (Method.GetMethodFlags): Override the MemberBase version and add
24428 the conditional flags.
24429 (Method.CheckBase): Moved some code from Define() here, call
24430 DoDefineParameters() here.
24431 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
24432 here to avoid some larger code duplication.
24433 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
24434 ensure that abstract and external accessors don't declare a body.
24436 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
24437 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
24438 lookup in the attribute's parent classes, so we need to abort as soon
24439 as we found the first match.
24440 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
24441 the attribute has no arguments.
24443 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
24446 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24448 * cs-parser.jay: reverted previous patch.
24450 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24452 * cs-parser.jay: fixed bug #22119.
24454 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24456 * attribute.cs: fixed compilation. The error was:
24457 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
24458 be assigned to before control leaves the current method."
24459 [FIXME: Filed as bug #28186: MCS must report this error.]
24461 2002-07-25 Martin Baulig <martin@gnome.org>
24463 * attribute.cs (Attribute.Conditional_GetConditionName): New static
24464 method to pull the condition name ouf of a Conditional attribute.
24465 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
24466 the obsolete message and error flag out of an Obsolete attribute.
24468 * class.cs (Method.GetMethodFlags): New public method to get the
24469 TypeManager.MethodFlags for this method.
24470 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
24472 (Method.Define): Get and apply the Obsolete and Conditional attributes;
24473 if we're overriding a virtual function, set the new private variable
24474 `parent_method'; call the new TypeManager.AddMethod().
24476 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
24477 the MethodBuilder and the Method in a PtrHashtable.
24478 (TypeManager.builder_to_method): Added for this purpose.
24479 (TypeManager.MethodFlags): Added IsObsoleteError.
24480 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
24481 Obsolete and Conditional arguments in MethodBuilders. If we discover
24482 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
24483 the message from the attribute.
24485 2002-07-24 Martin Baulig <martin@gnome.org>
24487 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
24488 preprocessor directives, ensure that the argument to #define/#undef is
24489 exactly one identifier and that it's actually an identifier.
24491 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
24494 2002-07-24 Martin Baulig <martin@gnome.org>
24496 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
24497 initialize it to TypeManager.object_type in the constructor.
24498 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
24499 of the `hm.get_current' method if we're using the collection pattern.
24500 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
24501 for the explicit conversion to make it work when we're using the collection
24502 pattern and the `Current' property has a different return type than `object'.
24505 2002-07-24 Martin Baulig <martin@gnome.org>
24507 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
24508 does not match, but don't report any errors. This method is called in
24509 order for all methods in a MethodGroupExpr until a matching method is
24510 found, so we don't want to bail out if the first method doesn't match.
24511 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
24512 matches, report the 123. Fixes #28070.
24514 2002-07-24 Martin Baulig <martin@gnome.org>
24516 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
24517 TypeManager.TypeToCoreType() to the top of the method so the
24518 following equality checks will work. Fixes #28107.
24520 2002-07-24 Martin Baulig <martin@gnome.org>
24522 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
24523 operand is of type uint, and the other operand is of type sbyte,
24524 short or int, the operands are converted to type long." -
24525 Actually do what this comment already told us. Fixes bug #28106,
24528 2002-07-24 Martin Baulig <martin@gnome.org>
24530 * class.cs (MethodBase): New abstract class. This is now a base
24531 class for Property, Indexer and Event to avoid some code duplication
24532 in their Define() and DefineMethods() methods.
24533 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
24534 generic methods for Define() and DefineMethods().
24535 (FieldBase): Derive from MemberBase, not MemberCore.
24536 (Property): Derive from MemberBase, not MemberCore.
24537 (Property.DefineMethod): Moved all the code from this method to the
24538 new MethodBase.DefineAccessor(), just call it with appropriate
24540 (Property.Define): Call the new Property.DoDefine(), this does some
24541 sanity checks and we don't need to duplicate the code everywhere.
24542 (Event): Derive from MemberBase, not MemberCore.
24543 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
24544 accessors, this will also make them work with interface events.
24545 (Indexer): Derive from MemberBase, not MemberCore.
24546 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
24547 (Indexer.Define): Use the new MethodBase functions.
24549 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
24550 argument to the constructor.
24551 (Interface.FindMembers): Added support for interface events.
24552 (Interface.PopluateEvent): Implemented.
24554 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
24556 2002-07-22 Miguel de Icaza <miguel@ximian.com>
24558 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
24559 but this is required to check for a method name being the same as
24560 the containing class.
24564 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24566 * interface.cs: initialize variable.
24568 2002-07-23 Martin Baulig <martin@gnome.org>
24570 Implemented the IndexerName attribute in interfaces.
24572 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
24573 name if this is an explicit interface implementation.
24574 (Indexer.InterfaceIndexerName): New public variable. If we're
24575 implementing an interface indexer, this is the IndexerName in that
24576 interface. Otherwise, it's the IndexerName.
24577 (Indexer.DefineMethod): If we're implementing interface indexer,
24578 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
24579 and Pending.ImplementIndexer methods.
24580 (Indexer.Define): Also define the PropertyBuilder if we're
24581 implementing an interface indexer and this is neither an explicit
24582 interface implementation nor do the IndexerName match the one in
24585 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
24586 If a method is defined here, then we always need to create a proxy
24587 for it. This is used when implementing interface indexers.
24588 (Pending.IsInterfaceIndexer): New public method.
24589 (Pending.ImplementIndexer): New public method.
24590 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
24591 This is used when implementing interface indexers to define a proxy
24593 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
24594 define a proxy if necessary.
24596 * interface.cs (Interface.IndexerName): New public variable.
24597 (Interface.PopulateIndexer): Set the IndexerName.
24598 (Interface.DefineIndexers): New private method. Populate all the
24599 indexers and make sure their IndexerNames match.
24601 * typemanager.cs (IndexerPropertyName): Added support for interface
24604 2002-07-22 Martin Baulig <martin@gnome.org>
24606 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
24607 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
24608 ret if HasReturnLabel.
24609 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
24612 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
24613 and set the ec.LoopBeginTryCatchLevel.
24614 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
24615 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
24616 the current ec.TryCatchLevel, the branch goes out of an exception
24617 block. In this case, we need to use Leave and not Br.
24619 2002-07-22 Martin Baulig <martin@gnome.org>
24621 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
24622 block unless the block does not always return or it is contained in
24623 another try { ... } catch { ... } block. Fixes bug #26506.
24624 Added verify-1.cs to the test suite.
24626 2002-07-22 Martin Baulig <martin@gnome.org>
24628 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
24629 then we do not always return. Fixes bug #24985.
24631 2002-07-22 Martin Baulig <martin@gnome.org>
24633 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
24634 lookup on a per-class level; ie. walk up the class hierarchy until we
24635 found at least one applicable method, then choose the best among them.
24636 Fixes bug #24463 and test-29.cs.
24638 2002-07-22 Martin Baulig <martin@gnome.org>
24640 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
24641 return types of the methods. The return type is not part of the
24642 signature and we must not check it to make the `new' modifier work.
24643 Fixes bug #27999, also added test-147.cs.
24644 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
24646 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
24647 on the method's return type.
24649 2002-07-21 Martin Baulig <martin@gnome.org>
24651 * assign.cs: Make this work if the rightmost source is a constant and
24652 we need to do an implicit type conversion. Also adding a few more tests
24653 to test-38.cs which should have caught this.
24655 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
24656 target in the makefile for this. The makefile.gnu is primarily intended
24657 for end-users who don't want to debug the compiler.
24659 2002-07-21 Martin Baulig <martin@gnome.org>
24661 * assign.cs: Improved the Assign class so it can now handle embedded
24662 assignments (X = Y = Z = something). As a side-effect this'll now also
24663 consume less local variables. test-38.cs now passes with MCS, added
24664 a few new test cases to that test.
24666 2002-07-20 Martin Baulig <martin@gnome.org>
24668 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
24669 instructions. Fixes bug #27977, also added test-146.cs.
24671 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24673 * cs-tokenizer.cs: fixed getHex ().
24675 2002-07-19 Martin Baulig <martin@gnome.org>
24677 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
24678 not Type.GetType() to lookup the array type. This is needed when
24679 we're constructing an array of a user-defined type.
24680 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
24681 single-dimensional arrays, but also for single-dimensial arrays of
24684 2002-07-19 Martin Baulig <martin@gnome.org>
24686 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
24687 this function is called, it's not allowed to share LocalBuilders
24688 among ILGenerators.
24690 2002-07-19 Martin Baulig <martin@gnome.org>
24692 * expression.cs (Argument.Resolve): Report an error 118 when trying
24693 to pass a type as argument.
24695 2002-07-18 Martin Baulig <martin@gnome.org>
24697 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
24698 Conv_R_Un for the signed `long' type.
24700 2002-07-15 Miguel de Icaza <miguel@ximian.com>
24702 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
24703 `expr' for the temporary result, as that will fail if we do
24704 multiple resolves on the same expression.
24706 2002-07-05 Miguel de Icaza <miguel@ximian.com>
24708 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
24709 ec.TypeContainer for looking up aliases.
24711 * class.cs (TypeContainer): Remove LookupAlias from here.
24713 * decl.cs (DeclSpace); Move here.
24715 2002-07-01 Miguel de Icaza <miguel@ximian.com>
24717 * class.cs (FindMembers): Only call filter if the constructor
24718 bulider is not null.
24720 Also handle delegates in `NestedTypes' now. Now we will perform
24721 type lookups using the standard resolution process. This also
24724 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
24725 This uses Expressions (the limited kind that can be parsed by the
24726 tree) instead of strings.
24728 * expression.cs (ComposedCast.ToString): Implement, used to flag
24729 errors since now we have to render expressions.
24731 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
24734 * ecore.cs (SimpleName.ToString): ditto.
24736 * cs-parser.jay: Instead of using strings to assemble types, use
24737 Expressions to assemble the type (using SimpleName, ComposedCast,
24738 MemberAccess). This should fix the type lookups in declarations,
24739 because we were using a different code path for this.
24741 * statement.cs (Block.Resolve): Continue processing statements
24742 even when there is an error.
24744 2002-07-17 Miguel de Icaza <miguel@ximian.com>
24746 * class.cs (Event.Define): Also remove the `remove' method from
24747 the list of pending items.
24749 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
24750 generate more compact code.
24752 2002-07-17 Martin Baulig <martin@gnome.org>
24754 * const.cs (Const.LookupConstantValue): Add support for constant
24755 `unchecked' and `checked' expressions.
24756 Also adding test case test-140.cs for this.
24758 2002-07-17 Martin Baulig <martin@gnome.org>
24760 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
24761 check whether mi.ReturnType implements the IEnumerator interface; the
24762 `==' and the IsAssignableFrom() will fail in this situation.
24764 2002-07-16 Ravi Pratap <ravi@ximian.com>
24766 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
24769 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24771 * expression.cs: fixed bug #27811.
24773 2002-07-14 Miguel de Icaza <miguel@ximian.com>
24775 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
24776 Molaro: when we are a ref, the value already contains a pointer
24777 value, do not take the address of it.
24779 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
24780 * removed mb-parser.jay and mb-tokenizer.cs
24782 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
24784 * expression.cs: check against the building corlib void type.
24786 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
24788 * ecore.cs: fix for valuetype static readonly fields: when
24789 initializing them, we need their address, not the address of a copy.
24791 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
24793 * typemanager.cs: register also enum_type in corlib.
24795 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
24797 * class.cs: allow calling this (but not base) initializers in structs.
24799 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
24801 * ecore.cs: make sure we compare against the building base types
24804 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
24806 * typemanager.cs: fix TypeToCoreType() to handle void and object
24807 (corlib gets no more typerefs after this change).
24809 2002-07-12 Miguel de Icaza <miguel@ximian.com>
24811 * expression.cs (ArrayCreation.EmitArrayArguments): use
24812 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
24814 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
24815 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
24816 array indexes, the runtime actually forbids them.
24818 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
24819 for array arguments here.
24821 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
24822 instead of the default for ValueTypes.
24824 (New.DoEmit): Use IsValueType instead of
24825 IsSubclassOf (value_type)
24826 (New.DoResolve): ditto.
24827 (Invocation.EmitCall): ditto.
24829 * assign.cs (Assign): ditto.
24831 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
24832 Statements *are* currently doing part of their resolution during
24835 Expressions do always resolve during resolve, but statements are
24836 only required to propagate resolution to their children.
24838 2002-07-11 Miguel de Icaza <miguel@ximian.com>
24840 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
24842 (LoadAssembly): Do not add the dll if it is already specified
24844 (MainDriver): Add the System directory to the link path at the end,
24845 after all the other -L arguments.
24847 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
24848 wrong opcode for loading bytes and bools (ldelem.i1 instead of
24849 ldelem.u1) and using the opposite for sbytes.
24851 This fixes Digger, and we can finally run it.
24853 * driver.cs (UnixParseOption): Move the option parsing here.
24854 (CSCParseOption): Implement CSC-like parsing of options.
24856 We now support both modes of operation, the old Unix way, and the
24857 new CSC-like way. This should help those who wanted to make cross
24858 platform makefiles.
24860 The only thing broken is that /r:, /reference: and /lib: are not
24861 implemented, because I want to make those have the same semantics
24862 as the CSC compiler has, and kill once and for all the confussion
24863 around this. Will be doing this tomorrow.
24865 * statement.cs (Unsafe.Resolve): The state is checked during
24866 resolve, not emit, so we have to set the flags for IsUnsfe here.
24868 2002-07-10 Miguel de Icaza <miguel@ximian.com>
24870 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
24871 not catch the Error_ObjectRefRequired in SimpleName (as it is
24872 possible to have a class/instance variable name that later gets
24873 deambiguated), we have to check this here.
24875 2002-07-10 Ravi Pratap <ravi@ximian.com>
24877 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
24878 make static and put into Expression.
24880 (Event.Define): Register the private field of the event with the
24881 TypeManager so that GetFieldFromEvent can get at it.
24883 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
24884 keep track of the private field associated with an event which
24887 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
24890 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
24892 2002-07-10 Miguel de Icaza <miguel@ximian.com>
24894 * expression.cs (Binary.EmitBranchable): this routine emits the
24895 Binary expression in a branchable context. This basically means:
24896 we need to branch somewhere, not just get the value on the stack.
24898 This works together with Statement.EmitBoolExpression.
24900 * statement.cs (Statement.EmitBoolExpression): Use
24903 2002-07-09 Miguel de Icaza <miguel@ximian.com>
24905 * statement.cs (For): Reduce the number of jumps in loops.
24907 (For): Implement loop inversion for the For statement.
24909 (Break): We can be breaking out of a Try/Catch controlled section
24910 (foreach might have an implicit try/catch clause), so we need to
24911 use Leave instead of Br.
24913 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
24914 now). If the instace expression supports IMemoryLocation, we use
24915 the AddressOf method from the IMemoryLocation to extract the
24916 address instead of emitting the instance.
24918 This showed up with `This', as we were emitting the instance
24919 always (Emit) instead of the Address of This. Particularly
24920 interesting when This is a value type, as we dont want the Emit
24921 effect (which was to load the object).
24923 2002-07-08 Miguel de Icaza <miguel@ximian.com>
24925 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
24927 * statement.cs (Checked): Set the CheckedState during the resolve
24928 process too, as the ConvCast operations track the checked state on
24929 the resolve process, and not emit.
24931 * cs-parser.jay (namespace_member_declaration): Flag that we have
24932 found a declaration when we do. This is used to flag error 1529
24934 * driver.cs: Report ok when we display the help only.
24936 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
24938 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
24940 2002-07-04 Miguel de Icaza <miguel@ximian.com>
24942 * cs-tokenizer.cs (define): We also have to track locally the
24943 defines. AllDefines is just used for the Conditional Attribute,
24944 but we also need the local defines for the current source code.
24946 2002-07-03 Miguel de Icaza <miguel@ximian.com>
24948 * statement.cs (While, For, Do): These loops can exit through a
24949 Break statement, use this information to tell whether the
24950 statement is the last piece of code.
24952 (Break): Flag that we break.
24954 * codegen.cs (EmitContexts): New `Breaks' state variable.
24956 2002-07-03 Martin Baulig <martin@gnome.org>
24958 * class.cs (TypeContainer.MethodModifiersValid): Allow override
24959 modifiers in method declarations in structs. Otherwise, you won't
24960 be able to override things like Object.Equals().
24962 2002-07-02 Miguel de Icaza <miguel@ximian.com>
24964 * class.cs (Method, Property, Indexer): Do not allow the public
24965 modifier to be used in explicit interface implementations.
24967 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
24968 override modifiers in method declarations in structs
24970 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
24972 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
24973 integer or real overflow, report an error
24975 2002-07-02 Martin Baulig <martin@gnome.org>
24977 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
24978 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
24979 to tell the runtime about our newly created System.Object and
24980 System.ValueType types.
24982 2002-07-02 Miguel de Icaza <miguel@ximian.com>
24984 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
24985 struct instead of Ldarg/Starg.
24987 2002-07-02 Martin Baulig <martin@gnome.org>
24989 * expression.cs (Indirection.Indirection): Call
24990 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
24992 2002-07-02 Martin Baulig <martin@gnome.org>
24994 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
24995 ValueType, call TypeManager.TypeToCoreType() on it.
24996 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
24997 the OpCodes.Newarr argument.
24999 2002-07-02 Martin Baulig <martin@gnome.org>
25001 * expression.cs (Invocation.EmitCall): When compiling corlib,
25002 replace all calls to the system's System.Array type to calls to
25003 the newly created one.
25005 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25006 System.Array methods.
25007 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25008 from the system's System.Array type which must be replaced.
25010 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25012 * typemanager.cs: load unverifiable_code_ctor so we can build
25013 corlib using the correct type. Avoid using GetTypeCode() with
25015 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25016 TypeManager.object_type to allow building corlib.
25018 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25020 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25022 2002-07-01 Martin Baulig <martin@gnome.org>
25024 * class.cs: Make the last change actually work, we need to check
25025 whether `ifaces != null' to avoid a crash.
25027 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25029 * class.cs: when we build structs without fields that implement
25030 interfaces, we need to add the interfaces separately, since there is
25031 no API to both set the size and add the interfaces at type creation
25034 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25036 * expression.cs: the dimension arguments to the array constructors
25037 need to be converted if they are a long.
25039 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25041 * class.cs: don't emit ldarg.0 if there is no parent constructor
25042 (fixes showstopper for corlib).
25044 2002-06-29 Martin Baulig <martin@gnome.org>
25046 MCS now compiles corlib on GNU/Linux :-)
25048 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25049 ie. check for MethodImplOptions.InternalCall.
25051 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25052 and TypeManager.attribute_type are null, so we must explicitly check
25053 whether parent is not null to find out whether it's an attribute type.
25054 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25055 and SetBuilder, not only if the property is neither abstract nor external.
25056 This is necessary to set the MethodImplOptions on the accessor methods.
25057 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25058 SetBuilder, see Property.Emit().
25060 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25061 populate "System.Object", "System.ValueType" and "System.Attribute" since
25062 they've already been populated from BootCorlib_PopulateCoreTypes().
25064 2002-06-29 Martin Baulig <martin@gnome.org>
25066 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25067 is the NullLiteral, we also need to make sure that target_type is not
25070 2002-06-29 Martin Baulig <martin@gnome.org>
25072 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25073 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25074 before calling BootstrapCorlib_ResolveDelegate ().
25076 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25078 * statement.cs: fixed build-breaker. All tests passed ok.
25080 2002-06-27 Martin Baulig <martin@gnome.org>
25082 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25083 for System.Decimal when compiling corlib.
25085 2002-06-27 Martin Baulig <martin@gnome.org>
25087 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25088 switch blocks which contain nothing but a default clause.
25090 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25092 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25094 2002-06-27 Martin Baulig <martin@gnome.org>
25096 * ecore.cs (PropertyExpr.PropertyExpr): Call
25097 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25099 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25100 is already a TypeBuilder.
25102 2002-06-27 Martin Baulig <martin@gnome.org>
25104 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25105 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25106 the "from an array-type to System.Array" case. This makes it work
25107 when compiling corlib.
25109 2002-06-27 Martin Baulig <martin@gnome.org>
25111 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
25112 non-static PropertyExpr, set its InstanceExpression. This makes
25113 the `ICollection.Count' property work in System/Array.cs.
25115 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
25117 * driver.cs: Made error handling more consistent. Errors now
25118 tracked by Report class, so many methods which used to return int
25119 now return void. Main() now prints success/failure and
25120 errors/warnings message.
25122 Renamed '--probe' compiler argument to '--expect-error'. Removed
25123 the magic number return values (123 and 124). Now, if the
25124 expected error occurs, the compiler exits with success (exit value
25125 0). If the compilation completes without seeing that particular
25126 error, the compiler exits with failure (exit value 1). The
25127 makefile in mcs/errors has been changed to handle the new behaviour.
25129 * report.cs: Made 'expected error' number a property and renamed
25130 it from 'Probe' to 'ExpectedError'.
25132 * genericparser.cs: Removed error handling support, since it is
25133 now all done by Report class.
25135 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
25136 class, so parse() no longer returns an int.
25138 * namespace.cs: Use Report.Error instead of GenericParser.error
25140 2002-06-22 Miguel de Icaza <miguel@ximian.com>
25142 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
25143 TypeContainer.AddOperator): At the front of the list put the
25144 explicit implementations, so they get resolved/defined first.
25146 2002-06-21 Miguel de Icaza <miguel@ximian.com>
25148 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
25149 interface type is implemented by this TypeContainer. Used during
25150 explicit interface implementation.
25152 (Property.Define, Indexer.Define, Method.Define): Validate that
25153 the given interface in the explicit implementation is one of the
25154 base classes for the containing type.
25156 Also if we are explicitly implementing an interface, but there is
25157 no match in the pending implementation table, report an error.
25159 (Property.Define): Only define the property if we are
25160 not explicitly implementing a property from an interface. Use the
25161 correct name also for those properties (the same CSC uses,
25162 although that is really not needed).
25164 (Property.Emit): Do not emit attributes for explicitly implemented
25165 properties, as there is no TypeBuilder.
25167 (Indexer.Emit): ditto.
25169 Hiding then means that we do not really *implement* a pending
25170 implementation, which makes code fail.
25172 2002-06-22 Martin Baulig <martin@gnome.org>
25174 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
25175 the return value of Object.GetType(). [FIXME: we need to do this whenever
25176 we get a type back from the reflection library].
25178 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
25180 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
25182 2002-06-20 Miguel de Icaza <miguel@ximian.com>
25184 * attribute.cs: Return null if we can not look up the type.
25186 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
25187 the interface types found.
25189 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
25190 interface types found.
25192 * typemanager.cs (GetInterfaces): Make this routine returns alll
25193 the interfaces and work around the lame differences between
25194 System.Type and System.Reflection.Emit.TypeBuilder in the results
25195 result for GetInterfaces.
25197 (ExpandInterfaces): Given an array of interface types, expand and
25198 eliminate repeated ocurrences of an interface. This expands in
25199 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
25202 2002-06-21 Martin Baulig <martin@gnome.org>
25204 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
25207 2002-06-21 Martin Baulig <martin@gnome.org>
25209 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
25210 and called with one of the core types, return the corresponding typebuilder for
25213 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
25216 2002-06-21 Martin Baulig <martin@gnome.org>
25218 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
25219 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
25220 (Expression.ConvertReferenceExplicit): Likewise.
25222 * expression.cs (ElementAccess.DoResolve): Likewise.
25223 (ElementAccess.DoResolveLValue): Likewise.
25225 2002-06-10 Martin Baulig <martin@gnome.org>
25227 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
25228 add the "value" parameter to the parameter list.
25230 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
25233 2002-06-19 Miguel de Icaza <miguel@ximian.com>
25235 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
25236 the argument to an int, uint, long or ulong, per the spec. Also
25237 catch negative constants in array creation.
25239 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
25241 * class.cs: do not allow the same interface to appear twice in
25242 the definition list.
25244 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
25246 * ecore.cs: don't use ldlen with System.Array.
25248 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
25250 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
25252 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
25254 * modifiers.cs: produce correct field attributes for protected
25255 internal. Easy fix so miguel can work on ther harder stuff:-)
25257 2002-06-18 Miguel de Icaza <miguel@ximian.com>
25259 * pending.cs: New file. Move the code from class.cs here.
25260 Support clearning the pending flag for all methods (when not doing
25261 explicit interface implementation).
25263 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
25265 * rootcontext.cs: added a couple more types needed to bootstrap.
25267 2002-06-17 Miguel de Icaza <miguel@ximian.com>
25269 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
25270 constructor in the type, instead of any constructor in the type
25271 hierarchy. Thanks to Paolo for finding this bug (it showed up as
25272 a bug in the Mono runtime when applying the params attribute).
25274 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25275 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
25277 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
25279 * expression.cs (Unary.ResolveOperator): Use TypeManager
25280 to resolve the type.
25282 2002-06-13 Ravi Pratap <ravi@ximian.com>
25284 * cs-parser.jay (enum_member_declaration): Pass in the attributes
25287 * enum.cs (AddEnumMember): Add support to store the attributes associated
25288 with each member too.
25290 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
25291 field builders too - this takes care of the enum member case.
25293 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
25295 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
25296 address-of operator on both value types and pointers.
25298 2002-06-10 Martin Baulig <martin@gnome.org>
25300 * interface.cs (Interface.PopulateIndexer): Add the indexer's
25301 PropertyBuilder to the `property_builders' list.
25303 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
25304 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
25305 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
25306 find any indexers which are inherited from an interface.
25308 2002-06-09 Martin Baulig <martin@gnome.org>
25310 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
25311 the same type as the constant if necessary. There's also a test-130.cs
25314 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
25316 * typemanager.cs (TypeManager.ChangeType): Previously known as
25317 Enum.ChangeEnumType().
25319 2002-06-09 Martin Baulig <martin@gnome.org>
25321 * expression.cs (Cast.TryReduce): Added support for consts.
25323 2002-06-08 Ravi Pratap <ravi@ximian.com>
25325 * class.cs (Accessor): Hold attributes information so we can pass
25328 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
25329 Modify to pass in attributes attached to the methods.
25331 (add_accessor_declaration, remove_accessor_declaration): Ditto.
25333 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
25334 to handle the Accessor kind :-)
25336 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
25338 2002-06-08 Martin Baulig <martin@gnome.org>
25340 * expression.cs (Unary.TryReduceNegative): Added support for
25343 2002-06-08 Martin Baulig <martin@gnome.org>
25345 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
25346 name can't be found in the `defined_names' - the caller will do a
25347 MemberLookup in this case and thus find methods in System.Enum
25348 such as Enum.IsDefined().
25350 2002-06-08 Martin Baulig <martin@gnome.org>
25352 * enum.cs (Enum.ChangeEnumType): This is a custom version of
25353 Convert.ChangeType() which works with TypeBuilder created types.
25354 (Enum.LookupEnumValue, Enum.Define): Use it here.
25356 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
25357 `TypeBuilder.BaseType != null' check.
25358 (TypeContainer.FindMembers): Only lookup parent members if we
25359 actually have a parent.
25360 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
25361 (ConstructorInitializer.Resolve): Likewise.
25363 * interface.cs (Interface.FindMembers): Added
25364 `TypeBuilder.BaseType != null' check.
25366 * rootcontext.cs (RootContext.ResolveCore): Added
25367 "System.Runtime.CompilerServices.IndexerNameAttribute" to
25368 classes_second_stage.
25370 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
25371 debug_type and trace_type when compiling with --nostdlib.
25373 2002-06-07 Martin Baulig <martin@gnome.org>
25375 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
25376 (AddField): Set it to true when adding a non-static field.
25377 (DefineType): Use `have_nonstatic_fields' to find out whether we
25378 have non-static fields, not `Fields != null'.
25380 2002-06-02 Miguel de Icaza <miguel@ximian.com>
25382 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
25383 dereferencing a null on the static-field code path)
25385 2002-05-30 Martin Baulig <martin@gnome.org>
25387 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
25388 to take command line arguments. Use reflection to call the new
25389 custom `Initialize' function on the symbol writer and pass it the
25390 command line arguments.
25392 * driver.cs (--debug-args): New command line argument to pass command
25393 line arguments to the symbol writer.
25395 2002-05-28 Miguel de Icaza <miguel@ximian.com>
25397 * assign.cs (DoResolve): Forgot to do the implicit conversion to
25398 the target type for indexers and properties. Thanks to Joe for
25401 2002-05-27 Miguel de Icaza <miguel@ximian.com>
25403 * typemanager.cs (MethodFlags): returns the method flags
25404 (Obsolete/ShouldIgnore) that control warning emission and whether
25405 the invocation should be made, or ignored.
25407 * expression.cs (Invocation.Emit): Remove previous hack, we should
25408 not do this on matching a base type, we should do this based on an attribute
25410 Only emit calls to System.Diagnostics.Debug and
25411 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
25412 on the command line.
25414 * rootcontext.cs: Global settings for tracing and debugging.
25416 * cs-tokenizer.cs (define): New utility function to track
25417 defines. Set the global settings for TRACE and DEBUG if found.
25419 2002-05-25 Ravi Pratap <ravi@ximian.com>
25421 * interface.cs (Populate*): Pass in the TypeContainer as well as
25422 the DeclSpace as parameters so that we can create EmitContexts and
25423 then use that to apply attributes etc.
25425 (PopulateMethod, PopulateEvent, PopulateProperty)
25426 (PopulateIndexer): Apply attributes everywhere.
25428 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
25431 (ApplyAttributes): Update accordingly.
25433 We now apply interface attributes for all members too.
25435 2002-05-26 Miguel de Icaza <miguel@ximian.com>
25437 * class.cs (Indexer.Define); Correctly check if we are explicit
25438 implementation (instead of checking the Name for a ".", we
25439 directly look up if the InterfaceType was specified).
25441 Delay the creation of the PropertyBuilder.
25443 Only create the PropertyBuilder if we are not an explicit
25444 interface implementation. This means that explicit interface
25445 implementation members do not participate in regular function
25446 lookups, and hence fixes another major ambiguity problem in
25447 overload resolution (that was the visible effect).
25449 (DefineMethod): Return whether we are doing an interface
25452 * typemanager.cs: Temporary hack until we get attributes in
25453 interfaces (Ravi is working on that) and we get IndexerName
25454 support in interfaces.
25456 * interface.cs: Register the indexers as properties.
25458 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
25459 warning, I have verified that this is a bug in the .NET runtime
25460 (JavaScript suffers of the same problem).
25462 * typemanager.cs (MemberLookup): When looking up members for
25463 interfaces, the parent of an interface is the implicit
25464 System.Object (so we succeed in searches of Object methods in an
25465 interface method invocation. Example: IEnumerable x; x.ToString
25468 2002-05-25 Miguel de Icaza <miguel@ximian.com>
25470 * class.cs (Event): Events should also register if they do
25471 implement the methods that an interface requires.
25473 * typemanager.cs (MemberLookup); use the new GetInterfaces
25476 (GetInterfaces): The code used to lookup interfaces for a type is
25477 used in more than one place, factor it here.
25479 * driver.cs: Track the errors at the bottom of the file, we kept
25482 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
25483 instance if the method we are calling is static!
25485 2002-05-24 Miguel de Icaza <miguel@ximian.com>
25487 * attribute.cs (ApplyAttributes): Make this function filter out
25488 the IndexerName attribute (as that attribute in reality is never
25489 applied) and return the string constant for the IndexerName
25492 * class.cs (TypeContainer.Emit): Validate that all the indexers
25493 have the same IndexerName attribute, and if so, set the
25494 DefaultName attribute on the class.
25496 * typemanager.cs: The return value might contain other stuff (not
25497 only methods). For instance, consider a method with an "Item"
25498 property and an Item method.
25500 * class.cs: If there is a problem with the parameter types,
25503 2002-05-24 Ravi Pratap <ravi@ximian.com>
25505 * ecore.cs (ImplicitConversionExists): Wrapper function which also
25506 looks at user defined conversion after making a call to
25507 StandardConversionExists - we need this for overload resolution.
25509 * expression.cs : Update accordingly the various method calls.
25511 This fixes 2 bugs filed against implicit user defined conversions
25513 2002-05-22 Miguel de Icaza <miguel@ximian.com>
25515 * statement.cs: Track the result of the assignment.
25517 2002-05-21 Miguel de Icaza <miguel@ximian.com>
25519 * expression.cs (MemberAccess): Improved error reporting for
25520 inaccessible members.
25522 2002-05-22 Martin Baulig <martin@gnome.org>
25524 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
25525 itself with debugging support.
25527 2002-05-22 Martin Baulig <martin@gnome.org>
25529 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
25530 Removed, this isn't needed anymore.
25532 2002-05-20 Martin Baulig <martin@gnome.org>
25534 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
25535 be underlying type for an enum.
25537 2002-05-20 Miguel de Icaza <miguel@ximian.com>
25539 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
25540 that splits out the loading of just the core types.
25542 * rootcontext.cs (ResolveCore): Split the struct resolution in
25543 two, so we can load the enumeration underlying types before any
25546 * expression.cs (Is): Bandaid until we fix properly Switch (see
25547 bug #24985 for details).
25549 * typemanager.cs (ImplementsInterface): The hashtable will contain
25550 a null if there are no interfaces implemented.
25552 2002-05-18 Miguel de Icaza <miguel@ximian.com>
25554 * cs-parser.jay (indexer_declarator): It is fine to have array
25557 2002-05-17 Miguel de Icaza <miguel@ximian.com>
25559 * typemanager.cs: (RegisterBuilder): New function used to register
25560 TypeBuilders that implement interfaces. Since
25561 TypeBuilder.GetInterfaces (as usual) does not work with lame
25563 (AddUserType): register interfaces.
25565 (ImplementsInterface): Use the builder_to_ifaces hash if we are
25566 dealing with TypeBuilder. Also, arrays are showing up as
25567 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
25568 methods can not be invoked on them!
25570 * ecore.cs (ExplicitReferenceConversionExists): Made public.
25571 (ImplicitReferenceConversionExists): Split out from
25572 StandardConversionExists.
25574 * expression.cs (As): We were only implementing one of the three
25575 cases for the as operator. We now implement them all.
25576 (Is): Implement the various other cases for Is as well.
25578 * typemanager.cs (CACHE): New define used to control if we want or
25579 not the FindMembers cache. Seems to have a negative impact on
25580 performance currently
25582 (MemberLookup): Nested types have full acess to
25583 enclosing type members
25585 Remove code that coped with instance/static returns for events, we
25586 now catch this in RealFindMembers.
25588 (RealFindMembers): only perform static lookup if the instance
25589 lookup did not return a type or an event.
25591 2002-05-17 Miguel de Icaza <miguel@ximian.com>
25593 * assign.cs (CompoundAssign): We pass more semantic information
25594 now to Compound Assignments than we did before: now we have all
25595 the information at hand, and now we resolve the target *before* we
25596 do the expression expansion, which allows the "CacheValue" method
25597 to have the effect we intended (before, a [x] += 1 would generate
25598 two differen ArrayAccess expressions from the ElementAccess,
25599 during the resolution process).
25601 (CompoundAssign.DoResolve): Resolve target and original_source here.
25603 2002-05-16 Miguel de Icaza <miguel@ximian.com>
25605 * expression.cs (ArrayAccess): dropped debugging information.
25607 * typemanager.cs: Small bug fix: I was always returning i_members,
25608 instead of one of i_members or s_members (depending on which had
25611 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
25612 method is invoked before any code generation takes place, and it
25613 is a mechanism to inform that the expression will be invoked more
25614 than once, and that the method should use temporary values to
25615 avoid having side effects
25617 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
25619 * ecore.cs (Expression.CacheTemporaries): Provide empty default
25622 * expression.cs (Indirection, ArrayAccess): Add support for
25623 CacheTemporaries in these two bad boys.
25625 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
25626 ldobj or ldind_ref.
25627 (StoreFromPtr): Handle stobj as well.
25629 * expression.cs (UnaryMutator): Share more code.
25631 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
25632 down: I was not tracking the Filter function as well, which
25633 was affecting the results of the cache.
25635 2002-05-15 Miguel de Icaza <miguel@ximian.com>
25637 * attribute.cs: Remove the hack to handle the CharSet property on
25640 2002-05-14 Miguel de Icaza <miguel@ximian.com>
25642 * attribute.cs (DoResolve): More uglyness, we now only try to
25643 resolve the attribute partially, to extract the CharSet
25644 information (only if we are a StructLayout attribute). Otherwise
25646 (GetExtraTypeInfo): Add some code to conditionally kill in the
25647 future this. I am more and more convinced that the .NET
25648 framework has special code to handle the attribute setting on
25651 * expression.cs (IsParamsMethodApplicable): Revert my previous
25652 foreach change here, it was wrong.
25654 2002-05-13 Miguel de Icaza <miguel@ximian.com>
25656 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
25657 (pp_expr): do not abort on unknown input, just return.
25658 (eval): abort if there are pending chars.
25660 * attribute.cs (Attribute.Resolve): Positional parameters are
25661 optional. Deal with that case.
25663 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
25664 the Ansi/Unicode/Auto information for the type.
25666 (TypeContainer.DefineType): instantiate the EmitContext here, as
25667 we will be using it during the type definition (to resolve
25668 attributes) and during the emit phase.
25670 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
25671 to pull type information out of the attributes
25673 (Attribute.Resolve): track the constructor builder, and allow for
25674 multiple invocations (structs and classes will use this).
25676 * ecore.cs (MemberLookupFinal): new version with all the
25677 parameters customizable.
25679 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
25680 constructors. Return if the result value is null (as the error
25681 would have been flagged already by MemberLookupFinal)
25683 Do not allow instances of abstract classes or interfaces to be
25686 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
25687 We have to compare the assembly property here when dealing with
25688 FamANDAssem and Assembly access modifiers, because we might be
25689 creating an assembly from *modules* (that means that we are not
25690 getting TypeBuilders for types defined in other modules that are
25691 part of this assembly).
25693 (Method.Emit): If the method is marked abstract and has a body,
25696 (TypeContainer.DefineMembers): If both the defined member and the
25697 parent name match are methods, then do not emit any warnings: let
25698 the Method.Define routine take care of flagging warnings. But if
25699 there is a mismatch (method overrides something else, or method is
25700 overriwritten by something, then emit warning).
25702 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
25703 set to null, this means `do not check for the return type on the
25706 (Method.Define): set the return type for the method signature to
25707 null, so that we get methods with the same name and parameters and
25708 different return types. This is used to flag warning 114 (you are
25709 hiding a method, and you probably want to use the new/override
25712 * typemanager.cs (MemberLookup): Implemented proper access
25713 control, closing a long standing set of bug reports. The problem
25714 was that the Framework only has two bits: Public and NonPublic,
25715 and NonPublic includes private and protected methods, but we need
25716 to enforce the FamANDAssem, FamOrAssem and Family.
25718 2002-05-11 Miguel de Icaza <miguel@ximian.com>
25720 * statement.cs (GotoCase): Return true: Ammounts to giving up
25721 knowledge on whether we return or not, and letting the other case
25722 be responsible for it.
25724 2002-05-10 Miguel de Icaza <miguel@ximian.com>
25726 * driver.cs: Do not load directories for each file processed, only
25727 do it if there is a pattern.
25729 * ecore.cs: Report readonly assigns here as well, as we might have
25730 been resolved only by MemberAccess.
25732 (SimpleName.SimpleNameResolve): Also be useful for LValue
25733 resolution. We need this to propagate assign to local readonly variables
25735 * typemanager.cs: Use a ptrhashtable for the criteria, because we
25736 do not want to reuse potential criteria memory.
25738 * class.cs (MyEventBuilder): Set reflected_type;
25740 * ecore.cs (Constantify): Added support for constifying bools.
25742 (RootContext.LookupType): Added a cache for values looked up in
25743 the declaration space.
25745 * typemanager.cs (FindMembers): Now is a front-end to
25746 RealFindMembers, and provides a two-level hashtable-based cache to
25749 15% performance improvement: from 22.5 to 19.2 seconds.
25751 * expression.cs (IsParamsMethodApplicable): use foreach.
25752 (Invocation.DoResolve): ditto.
25753 (New.DoResolve): ditto.
25754 (ArrayCreation.DoResolve): ditto.
25756 * ecore.cs (FindMostEncompassingType): use foreach.
25758 * delegate.cs (NewDelegate.DoResolve): Use foreach
25760 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
25761 (RemoveMethods): use foreach.
25763 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
25764 nested foreach statements instead of for, and also break out of
25765 the inner loop once a match is found.
25767 (Invocation.OverloadResolve): Use foreach, simplify the code.
25769 2002-05-08 Miguel de Icaza <miguel@ximian.com>
25771 * cfold.cs (BinaryFold): During an enumeration evaluation context,
25772 we actually unwrap the expression to allow for extra information
25775 * expression.cs: Use Shr_Un on unsigned operations.
25777 2002-05-08 Ravi Pratap <ravi@ximian.com>
25779 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
25780 applicable operators was not being considered correctly. This closes
25781 the bug Miguel reported.
25783 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
25785 * attribute.cs: check that the type derives from System.Attribute
25786 and report the correct error in that case (moved the duplicate code to
25787 its own method, too).
25789 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
25791 * attribute.cs: lookup attribute type name as the spec says: first the
25792 bare attribute name and then name + "Attribute" (nant compiles with
25793 mcs after this fix).
25795 2002-05-07 Miguel de Icaza <miguel@ximian.com>
25797 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
25798 Because of the way we parse things, we should try to see if a
25799 UIntConstant can fit in an integer.
25801 2002-05-07 Ravi Pratap <ravi@ximian.com>
25803 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
25804 when we are in an explicit context.
25806 (ConvertReferenceExplicit): When converting from Iface type S to Class
25807 T make sure the rules are implemented as an OR.
25809 * parameter.cs (ParameterType): Make it a property for now although the
25810 purpose really isn't anything immediate.
25812 * expression.cs (Is*Applicable): Do better checking on the parameter type
25813 of a ref/out parameter. The ones from the system assemblies are already
25814 marked with the correct type so we don't need to do any correction.
25816 * ecore.cs (StandardConversionExists): Conversion from Interface types to
25817 the object type is standard too so include that.
25819 2002-05-06 Miguel de Icaza <miguel@ximian.com>
25821 * ecore.cs (StandardConversionExists): Augment with missing code:
25822 deal with IntConstant, LongConstants and Enumerations.
25824 * assign.cs: Report the error, instead of failing silently
25826 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
25827 typecontainer that they are declared, because the
25828 typecontainer/namespace will have the list of using clauses that
25829 need to be applied.
25831 Assembly Attributes were escaping the normal registration
25834 (EmitCode): Apply attributes within an EmitContext that represents
25835 the container they were declared on.
25837 * cs-parser.jay: Track bases for structs. How did I get this wrong?
25839 2002-05-06 Ravi Pratap <ravi@ximian.com>
25841 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
25842 Revamp completely - make much cleaner as we now operate only
25845 (FindMostSpecificSource, FindMostSpecificTarget): New methods
25846 to implement the logic detailed in the spec more correctly.
25848 (UserDefinedConversion): Update accordingly.
25850 2002-05-06 Miguel de Icaza <miguel@ximian.com>
25852 * statement.cs: Return flow analysis information up.
25854 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
25857 (token): Do not consume an extra character before calling
25860 2002-05-06 Piers Haken <piersh@friskit.com>
25862 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
25864 2002-05-06 Miguel de Icaza <miguel@ximian.com>
25866 * class.cs (Constructor.Emit): Set the IsStatic flag in the
25867 EmitContext during the instance constructor initializer
25868 resolution, to stop access to instance variables.
25870 This is mandated by the spec, last paragraph of the `constructor
25871 initializers' section.
25873 2002-05-05 Miguel de Icaza <miguel@ximian.com>
25875 * cs-parser.jay, class.cs (Accessor): new class used to represent
25876 an accessor (get or set). In the past we used `null' to represent
25877 a missing accessor. But this is ambiguous because there was no
25878 way to tell in abstract indexers/properties if one of them was
25881 Now there is a way of addressing that.
25883 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
25884 instead of FindMembers.
25886 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
25887 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
25889 * attribute.cs: Treat indexers and properties as the same in terms
25890 of applying attributes
25892 * ecore.cs (FindMostEncompassedType): Use statically initialized
25893 EmptyExpressions()s like we do elsewhere to avoid creating useless
25894 objects (and we take this out of the tight loop).
25896 (GetConversionOperators): Move the code to extract the actual
25897 operators to a separate routine to clean things up.
25899 2002-05-04 Miguel de Icaza <miguel@ximian.com>
25901 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
25902 events are always registered FieldBuilders.
25904 * class.cs (FieldBase): New class shared by Fields
25906 * delegate.cs: If we are a toplevel delegate, use our full name.
25907 If we are a nested delegate, then only use our tail name.
25909 2002-05-02 Ravi Pratap <ravi@ximian.com>
25911 * expression.cs (IsApplicable): Ensure that we add the "&" to
25912 ref/out types before comparing it with the type of the argument.
25914 (IsParamsMethodApplicable): Ditto.
25916 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
25919 * delegate.cs : Handle the case when we have more than one applicable
25920 method. Flag an error only when we finish checking all.
25922 2002-05-02 Miguel de Icaza <miguel@ximian.com>
25924 * expression.cs: Add support for boolean static initializers.
25926 2002-05-01 Miguel de Icaza <miguel@ximian.com>
25928 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
25930 * parameter.cs (ComputeParameterTypes,
25931 ComputeAndDefineParameterTypes): Better error handling: now we
25932 clear the `types' cache if we fail during any of the type lookups.
25933 We also return the status code correctly to our caller
25935 * delegate.cs: If we fail to define a delegate, abort the extra
25938 * expression.cs (Binary.ResolveOperator): for
25939 operator==(object,object) and operator !=(object, object) we also
25940 have to verify that there is an implicit conversion from one to
25943 (ArrayAccess.DoResolve): Array Access can operate on
25946 2002-04-30 Miguel de Icaza <miguel@ximian.com>
25948 * assign.cs (CompoundAssign): A new class used as a "flag" that
25949 the assignment actually is happening as part of a compound
25950 assignment operator.
25952 During compound assignment, a few new rules exist to enable things
25959 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
25960 to the type of x) if y is implicitly convertible to the type of x,
25961 and the operator is a builtin operator and the return type of the
25962 operator is explicitly convertible to the type of x.
25964 * rootcontext.cs: Reset warning level to 2. 4 catches various
25965 "interesting" features in mcs, we must clean this up at some
25966 point, but currently am trying to kill other bugs ;-)
25968 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
25969 in container classes as well.
25971 * expression.cs (Binary.ResolveOperator): Handle string case
25972 before anything else (as operator overloading does emit an error
25973 before doing anything else).
25975 This code could go away when we move to a table driven model, but
25976 i could not come up with a good plan last night.
25978 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
25980 * typemanager.cs (CSharpName): reimplementation using regex.
25981 * class.cs: added null check for fields in Emit
25982 * rootcontext.cs: set warninglevel to 4
25984 2002-04-29 Miguel de Icaza <miguel@ximian.com>
25986 * typemanager.cs (CSharpName): reimplemented with Lupus
25989 2002-04-28 Miguel de Icaza <miguel@ximian.com>
25991 * statement.cs (If): correclty implement Resolve, because we were
25992 not catching sem errors in there. The same process is needed
25994 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
25997 (Statement.Warning_DeadCodeFound): Factorize code.
25998 (While): Report dead code here too.
26000 (Statement): Added Resolve virtual method to allow
26001 for resolution split from the emit code.
26003 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26005 * statement.cs (EmitBoolExpression): No longer try to resolve the
26007 (MakeBoolean): New utility function that resolve, implicitly
26008 converts to boolean and tags the expression.
26011 (If, Do): Implement dead code elimination.
26012 (While): Implement loop inversion
26014 (Do, While, For, If): Resolve the expression prior to calling our
26017 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26020 - added method Report28 (warning: program has more than one entry point)
26021 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26022 - modified method Method.Define, the part at the end of the method
26024 * rootcontext.cs: added static public Location EntryPointLocation;
26026 * ../errors/cs0028.cs : Add test case for the above warning.
26029 - modified method CSharpName to allow arrays of primitive type to
26030 be printed nicely (e.g. instead of System.Int32[][] it now prints
26032 - added method CSharpSignature: returns the signature of a method
26033 in string format to be used in reporting errors, warnings, etc.
26035 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26038 2002-04-26 Ravi Pratap <ravi@ximian.com>
26040 * delegate.cs (Define): Fix extremely silly bug where I was
26041 setting the type of the 'object' parameter of the BeginInvoke
26042 method to System.IAsyncResult instead of System.Object ;-)
26044 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26046 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26049 (Constructor.Emit): return if we fail to initialize the
26050 constructor. Another door closed!
26052 * expression.cs (New.DoResolve): Improve error message (from -6 to
26053 1501). Use DeclaredOnly lookup to find the exact constructor.
26055 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26056 loop. This is useful.
26058 * cs-parser.jay: Adjust the default parameters so that destructors
26059 have the proper signature.
26061 2002-04-26 Martin Baulig <martin@gnome.org>
26063 * driver.cs (LoadAssembly): If `assembly' contains any characters
26064 which are only valid in path names and not in assembly names
26065 (currently slash, backslash and point), use Assembly.LoadFrom ()
26066 instead of Assembly.Load () on the `assembly' (before iteration
26067 over the link_paths).
26069 2002-04-26 Martin Baulig <martin@gnome.org>
26071 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26073 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26075 * class.cs (Property): use the new typemanager.MemberLookup
26077 (TypeContainer.MemberLookup): Implement using the
26078 TypeManager.MemberLookup now.
26080 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26081 and return MemberInfos, so that these can be used without an
26082 EmitContext (what we had before).
26084 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26086 * expression.cs: Fix the case where the argument to params if the
26087 type of the params. I omitted handling this before. Fixed
26089 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26091 * driver.cs: Call BootCorlib_PopulateCoreType
26093 * class.cs (Property.CheckBase): Check for properties only, not
26096 * interface.cs: Temporary hack: try/catch around the
26097 CustomAttributeBuilder, because I am getting an exception that I
26100 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26101 types whose definitions are required to be there (attributes are
26102 defined before standard types).
26104 Compute definitions as we boot the various types, as they are used
26105 immediately (value_type class will need object_type, but if we do
26106 not initialize object_type, we will pass a null, which will let
26107 the runtime pick the System.Object from the existing corlib, which
26108 is not what we want).
26110 2002-04-22 Patrik Torstensson <totte@labs2.com>
26112 * cs-tokenizer.cs: fixed a number of trim() issues.
26114 2002-04-22 Ravi Pratap <ravi@ximian.com>
26116 * expression.cs (Argument.Type): Ensure that we return the correct
26117 type when we have out or ref parameters [in which case we
26120 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26122 * class.cs (Property, Indexer): Allow extern modifier in there.
26124 * typemanager.cs (InitBaseTypes): Initializes object_type and
26125 value_type, since those will be used early on during the bootstrap
26126 process to compile corlib.
26128 (InitCoreTypes): Move code from here to InitBaseTypes.
26130 2002-04-21 Miguel de Icaza <miguel@ximian.com>
26132 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
26133 single-dimension arrays as using the ldlen opcode.
26135 Daniel Lewis discovered this optimization.
26137 * typemanager.cs: Add signature for System.Array::get_Length
26139 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26141 * statement.cs: report the error when the foreach does not apply to an
26142 array nor a collection.
26144 2002-04-19 Miguel de Icaza <miguel@ximian.com>
26146 * expression.cs: Add implicit conversions to the operator ~.
26148 * constant.cs (DecimalConstant.Emit): Emit decimal value.
26150 * typemanager.cs: Locate the decimal constructor.
26152 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26154 * attribute.cs: use the new property of TypeOf.
26155 * expression.cs: added 'get' property around typearg.
26157 These changes fix a build breaker reported by NickD. Is this the
26158 correct way to fix? If not, please, revert my changes and make it
26161 2002-04-17 Miguel de Icaza <miguel@ximian.com>
26163 * attribute.cs: Add support for typeof in attribute invocations.
26164 I am not sure that this is right though.
26166 2002-04-14 Duncan Mak <duncan@ximian.com>
26168 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
26169 Binary.Operator.Division case.
26171 2002-04-13 Ravi Pratap <ravi@ximian.com>
26173 * class.cs (DefineType): Ensure that we do a proper check on
26174 attribute types and also register it with the TypeManager.
26176 (TypeContainer.Targets): The default for attribute types is
26177 AttributeTargets.All.
26179 * attribute.cs (ApplyAttributes): Registering the attribute type
26180 is done elsewhere, not when we discover we have a Usage attribute.
26182 2002-04-12 Ravi Pratap <ravi@ximian.com>
26184 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
26185 and get rid of is_delegate parameter.
26187 * everywhere : update.
26189 2002-04-12 Ravi Pratap <ravi@ximian.com>
26191 * cs-parser.jay (compilation_unit): Revamp completely to use
26192 some new ideas that I got from Rhys' grammar to solve the problems
26193 with assembly level attributes.
26195 (outer_declaration): New grammar production.
26197 (attribute_sections): Add.
26199 (opt_attributes): Base on attribute_sections
26201 (namespace_declaration): Allow opt_attributes to tackle the case
26202 when we have assembly level attributes - we are clever in this
26205 * attribute.cs (ApplyAttributes): Do not worry about assembly
26206 attributes in the non-global context.
26208 * rootcontext.cs (AddGlobalAttributes): Go back to using this
26209 instead of SetGlobalAttributes.
26211 * class.cs, rootcontext.cs : Ensure we define and generate
26212 attribute types before anything else.
26214 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
26215 and flag the new error -20 for the case when the attribute type
26216 does not have valid targets specified. csc does not catch this.
26218 * ../errors/errors.txt : update for error # -20
26220 2002-04-11 Ravi Pratap <ravi@ximian.com>
26222 * support.cs (InternalParameters.ParameterModifier): Do some null
26223 checking and return sane values.
26225 * class.cs (Method.Define): If we are a PInvoke method, ensure
26226 that we are static and extern. Report error # 601
26228 * ../errors/cs0601.cs : Add test case for the above error.
26230 2002-04-07 Ravi Pratap <ravi@ximian.com>
26232 * rootcontext.cs (attribute_types): We need to keep type of
26233 all attribute types separately and emit code for them first.
26235 (RegisterAttribute) : Implement.
26237 * class.cs (DefineType): Check if the current Type is a custom
26238 attribute type and register it accordingly.
26240 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
26241 adding the first attribute twice and rename to
26243 (SetGlobalAttributes): this.
26245 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
26248 * attribute.cs (ApplyAttributes): Take an additional argument telling us
26249 if we are processing global arguments. Hmm, I am unsure of this.
26251 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26253 * expression.cs: added static array of strings to avoid calling
26254 Enum.ToString () for Operator in Binary. Significant recover of
26257 2002-04-10 Miguel de Icaza <miguel@ximian.com>
26259 * class.cs (FindMembers): Allow the Builders of the various
26260 members to be null. If they are skip them. This only happens
26261 during the PInvoke declaration.
26263 2002-04-09 Miguel de Icaza <miguel@ximian.com>
26265 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
26266 failure, so we do not keep going afterwards.
26268 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
26269 wanted to pass `false' as the `is_delegate' argument. If this is
26270 the case, why not use delegate_type == null to mean `is_delegate =
26271 false' and anything else as is_delegate = true.
26273 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
26275 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
26276 code for the section, not the beginning of the tests.
26278 2002-04-08 Miguel de Icaza <miguel@ximian.com>
26280 * cfold.cs: Handle operator + (Enum x, Underlying x)
26282 * expression.cs (Binary): same. Warn about errors where we have
26283 Enum/Enum in operator + as well.
26285 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
26288 - added support for switch(bool)
26289 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
26290 - add TableSwitchEmit() to handle table-based switch statements
26292 2002-04-05 Ravi Pratap <ravi@ximian.com>
26294 * expression.cs (Invocation.OverloadResolve): Factor out code which
26295 does parameter compatibility checking with arguments so that we can
26296 re-use the code even from Delegate.VerifyApplicability
26298 (VerifyArgumentsCompat): Move above code here.
26300 * delegate.cs (VerifyApplicability): Get rid of duplicate code
26301 and instead make a call to the above method.
26303 2002-03-31 Ravi Pratap <ravi@ximian.com>
26305 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
26306 We use it to keep track of classes which are attribute types.
26308 2002-04-02 Miguel de Icaza <miguel@ximian.com>
26310 * delegate.cs (Delegate.Define): Correctly define the types in the
26311 presence of fixed and array parameters.
26313 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
26316 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
26317 include NonPublic after the first iteration.
26319 * class.cs (Indexer.CheckBase): Only check if both parents are
26322 * cs-parser.jay (accessor_body): If empty, set to null.
26324 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
26325 same code path here to resolve constants names that we did have in
26326 MemberAccess.DoResolve. There is too much code duplicated here.
26328 2002-04-01 Miguel de Icaza <miguel@ximian.com>
26330 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
26332 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
26335 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
26336 tokens, numbers and strings.
26338 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
26341 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
26342 asyncronous parameters and the regular parameters.
26344 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
26345 specify the target directory.
26347 * expression.cs: (This.DoResolve): Simplify
26348 (As.Emit): Optimize, do not generate IsInst if the expression is
26349 always of the given type.
26351 (Is.DoResolve): Bug fix, we were reporting both always/never for
26354 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
26355 creating too many unnecessary arrays.
26357 2002-03-31 Miguel de Icaza <miguel@ximian.com>
26359 * class.cs (EmitFieldInitializer): Use Assign expression to assign
26360 fields instead of rolling our own initializer. Takes care of all
26361 implicit conversions, and drops unnecessary static checks/argument.
26363 2002-03-31 Dick Porter <dick@ximian.com>
26365 * driver.cs: use the GetDirectories() return values properly, and
26366 use "/" as path separator.
26368 2002-03-30 Miguel de Icaza <miguel@ximian.com>
26370 * expression.cs (Unary): Optimize - - expr into expr.
26371 (Binary): Optimize a + (-b) into a -b.
26373 * codegen.cs (CodeGen): Made all methods static.
26375 2002-03-29 Miguel de Icaza <miguel@ximian.com>
26379 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
26380 TypeBuilder property.
26382 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
26385 * tree.cs: Removed the various RecordXXXX, and replaced with a
26386 single RecordDecl. Removed all the accessor methods, and just
26387 left a single access point Type
26389 * enum.cs: Rename DefineEnum to DefineType.
26391 * decl.cs: New abstract method `DefineType' used to unify the
26392 Defines for Enumerations, Interfaces, TypeContainers and
26395 (FindType): Moved LookupInterfaceOrClass here. Moved the
26396 LookupBaseClasses method that used to live in class.cs and
26397 interface.cs here, and renamed to FindType.
26399 * delegate.cs: Implement DefineType. Take advantage of the
26400 refactored pattern for locating the parent builder without taking
26401 the parent_builder argument (which we know does not work if we are
26402 nested, and triggering a toplevel definition).
26404 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26406 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
26407 accessibility of a member has changed during override and report
26410 * class.cs (Method.Define, Property.Define): Only complain on
26411 overrides if the method is private, any other accessibility is
26412 fine (and since we just checked the permission is the same, we are
26415 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
26416 and elif are processed always. The other pre-processing
26417 directives are only processed if we are "taking" the path
26419 2002-03-29 Martin Baulig <martin@gnome.org>
26421 * class.cs (Method.Emit): Only emit symbolic debugging info if the
26422 current location is not Null.
26424 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
26425 a separate method so we can profile it.
26427 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
26428 `span.Seconds' are just seconds, but no minutes or hours.
26429 (MainDriver): Profile the CodeGen.SaveSymbols calls.
26431 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26433 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
26434 Remove the gratuitous set of Final:
26436 // If an interface implementation, then we can set Final.
26437 if (((flags & MethodAttributes.Abstract) == 0) &&
26438 implementing.DeclaringType.IsInterface)
26439 flags |= MethodAttributes.Final;
26441 I do not know what I was smoking when I used that.
26444 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
26445 step into fixing the name resolution issues for delegates and
26446 unifying the toplevel name resolution.
26448 2002-03-28 Martin Baulig <martin@gnome.org>
26450 * class.cs (Method.Emit): If we have a symbol writer, call its
26451 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
26452 tell it about the current method.
26454 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
26455 writer that we're going to emit the first byte of IL code for a new
26456 statement (a new source line).
26457 (EmitContext.EmitTopBlock): If we have a symbol writer, call
26458 EmitContext.Mark() before emitting any code.
26460 * location.cs (SymbolDocument): Return null when we're Null.
26462 * statement.cs (Statement): Moved the `Location loc' variable here.
26463 (Statement.EmitBoolExpression): If we have a symbol writer, call
26464 ec.Mark() before emitting any code to tell it that we're at the
26465 beginning of a new statement.
26466 (StatementExpression): Added `Location' argument to the constructor.
26467 (Block): Added public readonly variable `StartLocation' and public
26468 variable `EndLocation'. The latter is to be set using SetEndLocation().
26469 (Block): Added constructor which takes a start and end location.
26470 (Block.SetEndLocation): New method. This sets the end location.
26471 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
26472 local variables we create.
26473 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
26474 each statement and do also mark the begin and end of the block.
26476 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
26477 tell it the current lexer.Location, use Location.Null for the end of the
26479 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
26480 current block, set its end location using SetEndLocation().
26481 (statement_expression): StatementExpression constructor now takes the
26482 lexer.Location as additional argument.
26483 (for_statement, declare_local_variables): Likewise.
26484 (declare_local_variables): When creating a new implicit block, use the
26485 new Block constructor and pass it the lexer.Location.
26487 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26489 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
26490 members also on the parent interfaces recursively.
26492 2002-03-27 Miguel de Icaza <miguel@ximian.com>
26494 * report.cs: Use new formats, since Gonzalo finished the missing
26497 * expression.cs (Binary.ResolveOperator): added missing operator|
26498 operator& and operator^ for bool/bool.
26500 * cs-parser.jay: CheckDef now takes a Location argument that is
26501 used to report errors more precisly (instead of reporting the end
26502 of a definition, we try to track something which is a lot closer
26503 to the source of the problem).
26505 * cs-tokenizer.cs: Track global token use, so we can properly flag
26506 the use of #define/#undef after the first token has been seen.
26508 Also, rename the reportXXXX to Error_DescriptiveName
26510 * decl.cs (DeclSpace.IsTopLevel): Move property here from
26511 TypeContainer, so that Enum and Interface can use this too.
26513 * class.cs (TypeContainer.LookupInterfaceOrClass,
26514 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
26515 `builder' argument. Typically this was used to pass the parent
26516 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
26519 The problem is that a nested class could trigger the definition of
26520 a toplevel class, and the builder would be obviously wrong in that
26523 So we drop this argument, and we compute dynamically the
26524 TypeBuilder/ModuleBuilder (the correct information was available
26525 to us anyways from DeclSpace.Parent)
26527 * interface.cs (Interface.DefineInterface): Drop builder
26528 parameter cleanup like class.cs
26530 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
26533 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
26536 (Try.Emit): Propagate the returns value from the statement.
26538 (Return.Emit): Even if we are leavning
26540 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
26542 * modifiers.cs: Fix the computation of MethodAttributes flags.
26544 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
26546 * driver.cs: allow compilation of files that start with '/'.
26547 Add a default case when checking the argument of --target.
26549 2002-03-25 Miguel de Icaza <miguel@ximian.com>
26551 * interface.cs: Implement the same search algorithm for types in
26552 the interface code.
26554 * delegate.cs: Do not allow multiple definition.
26556 * Recovered ChangeLog that got accidentally amputated
26558 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
26560 * rootcontext.cs: Load manually enum to allow core classes to
26561 contain enumerations.
26563 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
26564 Update to new static methods in TypeManager.
26566 * typemanager.cs (GetMethod, GetConstructor): Use our
26567 implementation of FindMembers to find the members, since during
26568 corlib compilation, the types are TypeBuilders and GetMethod and
26569 GetConstructor do not work.
26571 Make all methods in TypeManager static.
26573 (InitCodeHelpers): Split the functionality from
26574 the InitCodeTypes function.
26576 * driver.cs: Call InitCodeHelpers after we have populated the
26579 * cs-parser.jay (delegate_declaration): we did not used to compute
26580 the delegate name correctly for void delegates.
26582 2002-03-24 Miguel de Icaza <miguel@ximian.com>
26584 * rootcontext.cs (RootContext): Init the interface_resolve_order
26585 and type_container_resolve_order always.
26587 (ResolveCore, BootstrapCorlib_ResolveClass,
26588 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
26589 compiler when compiling with --nostdlib
26591 * class.cs (TypeContainer.DefineType): Check that our parent is
26592 not null. This test is most important when we are bootstraping
26595 * codegen.cs: Split out the symbol writing code.
26597 2002-03-25 Martin Baulig <martin@gnome.org>
26599 * driver.cs (-g): Made -g an alias for --debug.
26601 2002-03-24 Martin Baulig <martin@gnome.org>
26603 * codegen.cs (SymbolWriter): New public variable. Returns the
26604 current symbol writer.
26605 (CodeGen): Added `bool want_debugging_support' argument to the
26606 constructor. If true, tell the ModuleBuild that we want debugging
26607 support and ask it for the ISymbolWriter.
26608 (Save): If we have a symbol writer, call it's Close() method after
26609 saving the assembly.
26611 * driver.c (--debug): New command line argument to create a
26612 debugger information file.
26614 * location.cs (SymbolDocument): New public property. Returns an
26615 ISymbolDocumentWriter object for the current source file or null
26616 if we don't have a symbol writer.
26618 2002-03-21 Miguel de Icaza <miguel@ximian.com>
26620 * driver.cs (LoadAssembly): Correctly return when all the paths
26621 have been tried and not before.
26623 * statement.cs (Switch.Emit): return the actual coverage for this
26624 statement (returns/not-returns)
26626 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
26627 switch of the statement if we are the last switch section. That
26628 kills two problems: try/catch problems (we used to emit an empty
26629 nop at the end) and switch statements where all branches would
26632 2002-03-19 Miguel de Icaza <miguel@ximian.com>
26634 * driver.cs: Add default assemblies (the equivalent to the
26635 Microsoft CSC.RSP file)
26637 * cs-tokenizer.cs: When updating `cols and setting it to zero,
26638 also update tokens_seen and set it to false.
26640 * driver.cs: Implement --recurse for Mike.
26642 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
26643 correctly splitting out the paths.
26645 2002-03-18 Miguel de Icaza <miguel@ximian.com>
26647 * interface.cs (Interface.PopulateProperty): Instead of using
26648 `parent' as the declaration space for the set parameters, use
26651 * support.cs (InternalParameters): InternalParameters constructor
26652 takes a DeclSpace instead of a TypeContainer.
26654 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
26655 types are being initialized, load the address of it before calling
26658 (New): Provide a mechanism to disable the generation of local
26659 value type temporaries when the caller will be providing us with
26660 an address to store it.
26662 (ArrayCreation.EmitDynamicInitializers): Use it.
26664 2002-03-17 Miguel de Icaza <miguel@ximian.com>
26666 * expression.cs (Invocation.EmitArguments): Only probe for array
26667 property if there is more than one argument. Sorry about that.
26669 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
26670 empty param arrays.
26672 * class.cs (Method.LabelParameters): Fix incorrect code path that
26673 prevented the `ParamArrayAttribute' from being applied to the
26676 2002-03-16 Miguel de Icaza <miguel@ximian.com>
26678 * support.cs (ReflectionParameters): Correctly compute whether the
26679 last argument is a params array. Fixes the problem with
26682 * typemanager.cs: Make the assemblies array always be non-null
26683 (empty, but non-null)
26685 * tree.cs (RecordDecl): New function that abstracts the recording
26686 of names. This reports error 101, and provides a pointer to the
26687 previous declaration. Fixes a crash in the compiler.
26689 * cs-parser.jay (constructor_declaration): Update to new grammar,
26690 and provide a constructor_body that can be empty.
26692 2002-03-15 Miguel de Icaza <miguel@ximian.com>
26694 * driver.cs: Add support for --resources.
26696 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
26697 Make all types for the various array helper methods be integer.
26699 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
26700 CheckState to ConvCast.
26702 (ConvCast): Now it takes a `checked' state argument, to avoid
26703 depending on the emit context for the conversion, and just using
26704 the resolve time setting.
26706 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
26707 instead of Invocation.EmitArguments. We do not emit the original
26708 arguments, instead we emit those which have been converted to
26709 unsigned int expressions.
26711 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
26713 * codegen.cs: ditto.
26715 * expression.cs (LocalVariableReference): Drop the use of the
26716 Store function that depended on the variable index.
26718 * statement.cs (VariableInfo): Drop the `Idx' property from this
26719 class, as this is not taking into account the indexes for
26720 temporaries tat we generate during the execution, getting the
26723 * class.cs: First emit class initializers, then call the parent
26726 * expression.cs (Binary): Fix opcode emision.
26727 (UnaryMutator.EmitCode): Support checked code generation
26729 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
26730 matches for events for both the Static and Instance scans,
26731 pointing to the same element. Fix that.
26733 2002-03-14 Miguel de Icaza <miguel@ximian.com>
26735 * rootcontext.cs (ResolveTree): Always set the
26736 interface_resolve_order, because nested interfaces will be calling
26739 * class.cs (GetInterfaceOrClass): Track the same resolution
26740 process used by TypeManager.LookupType. This fixes the nested
26741 type lookups in class declarations (separate path from
26744 (TypeContainer.DefineType): Also define nested interfaces.
26745 (TypeContainer.RegisterOrder): New public function used to
26746 register the order in which child interfaces need to be closed.
26748 Nested interfaces need to be closed after their parents have been
26751 * interface.cs (InterfaceAttr): Put all the logic for computing
26752 the interface attribute here.
26754 (DefineInterface): Register our interface order with the
26755 RootContext or with the TypeContainer depending on the case.
26757 2002-03-12 Miguel de Icaza <miguel@ximian.com>
26759 * cs-parser.jay: rework foreach statement to work with the new
26760 changes to the policy on SimpleNames.
26762 * report.cs: support Stacktrace on warnings as well.
26764 * makefile: drop --unsafe and /unsafe from the compile.
26766 2002-03-13 Ravi Pratap <ravi@ximian.com>
26768 * ecore.cs (StandardConversionExists): Modify to take an Expression
26769 as the first parameter. Ensure we do null -> reference type conversion
26772 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
26773 temporary Expression objects.
26775 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
26777 * interface.cs: workaround bug in method overloading resolution
26778 (there is already a bugzilla bug for it).
26780 2002-03-12 Miguel de Icaza <miguel@ximian.com>
26782 We could also solve this problem by having a separate path for
26783 performing type lookups, instead of DoResolve, we could have a
26784 ResolveType entry point, and only participating pieces of the
26785 production (simplename, deref, array) would implement this.
26787 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
26788 signal SimpleName to only resolve type names and not attempt to
26789 resolve anything else.
26791 * expression.cs (Cast): Set the flag.
26793 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
26795 * class.cs: Only report 108 if there is no `new' modifier.
26797 * cs-parser.jay: rework foreach statement to work with the new
26798 changes to the policy on SimpleNames.
26800 * report.cs: support Stacktrace on warnings as well.
26802 * makefile: drop --unsafe and /unsafe from the compile.
26804 2002-03-11 Miguel de Icaza <miguel@ximian.com>
26806 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
26807 lookups here, instead of doing that at parse time. This means
26808 that our grammar will not introduce `LocalVariableReferences' as
26809 expressions at this point. That solves the problem of code like
26813 static void Main ()
26817 This is only half the fix. The full fix requires parameters to
26818 also be handled in this way.
26820 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
26821 makes the use more obvious of the DeclSpace. The
26822 ec.TypeContainer.TypeBuilder is now only used to pull the
26823 TypeBuilder for it.
26825 My theory is that I can get rid of the TypeBuilder completely from
26826 the EmitContext, and have typecasts where it is used (from
26827 DeclSpace to where it matters).
26829 The only pending problem is that the code that implements Aliases
26830 is on TypeContainer, and probably should go in DeclSpace.
26832 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
26833 lookups here, instead of doing that at parse time. This means
26834 that our grammar will not introduce `LocalVariableReferences' as
26835 expressions at this point. That solves the problem of code like
26839 static void Main ()
26843 This is only half the fix. The full fix requires parameters to
26844 also be handled in this way.
26846 * class.cs (Property.DefineMethod): When implementing an interface
26847 method, set newslot, when implementing an abstract method, do not
26848 set the flag (before we tried never setting it, or always setting
26849 it, which is the difference).
26850 (Indexer.DefineMethod): same.
26851 (Method.DefineMethod): same.
26853 * ecore.cs: Only set the status used flag if we get back a Field.
26855 * attribute.cs: Temporary hack, so Paolo can keep working.
26857 2002-03-08 Ravi Pratap <ravi@ximian.com>
26859 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
26860 the unmanaged type in the case we have a MarshalAs attribute.
26862 (Resolve): Handle the case when we are parsing the special MarshalAs
26863 attribute [we need to store the unmanaged type to use later]
26865 * typemanager.cs (marshal_as_attr_type): Built in type for the
26866 MarshalAs Attribute.
26868 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
26869 on parameters and accordingly set the marshalling info.
26871 2002-03-09 Miguel de Icaza <miguel@ximian.com>
26873 * class.cs: Optimizing slightly by removing redundant code after
26874 we switched to the `NoTypes' return value.
26875 (Property.DefineMethod): use NoTypes here too.
26877 This fixes the bug I introduced in my last batch of changes.
26879 2002-03-05 Ravi Pratap <ravi@ximian.com>
26881 * tree.cs (RecordEnum): Add. We now keep track of enums too.
26883 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
26884 Enums since those are types too.
26886 * cs-parser.jay (enum_declaration): Record enums as we parse them.
26888 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
26889 thanks to a call during the lookup process.
26891 2002-03-07 Miguel de Icaza <miguel@ximian.com>
26893 * statement.cs (Foreach): Lots of work to accomodate a particular
26894 kind of foreach statement that I had not kept in mind. It is
26895 possible to have foreachs on classes that provide a GetEnumerator
26896 method that return objects that implement the "pattern" for using
26897 a foreach, there is no need to support GetEnumerator
26900 This is needed to compile nant.
26902 * decl.cs: Only report 114 if the member is not `Finalize' and if
26903 the warning level is at least 2.
26905 * class.cs: Moved the compare function from Method to
26908 (MethodSignature.InheritableMemberSignatureCompare): Add new
26909 filter function that is used to extract inheritable methods from a
26912 (Method.Define): Use the new `inheritable_method_signature_filter'
26915 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
26918 2002-03-06 Miguel de Icaza <miguel@ximian.com>
26920 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
26922 * cs-parser.jay: Add opt_semicolon to the interface declaration.
26924 * expression.cs: Pass location information to
26925 ConvertImplicitStandard.
26927 * class.cs: Added debugging code to track return values from
26930 2002-03-05 Miguel de Icaza <miguel@ximian.com>
26932 * expression.cs (Is.DoResolve): If either side of the `is' is an
26933 interface, do not flag the warning.
26935 * ecore.cs (ImplicitReferenceConversion): We need a separate test
26938 * report.cs: Allow for --fatal to be used with --probe.
26940 * typemanager.cs (NoTypes): Move the definition for the empty Type
26943 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
26945 (TypeContainer.DefineProxy): New function used to proxy to parent
26946 implementations when implementing interfaces.
26947 (TypeContainer.ParentImplements): used to lookup if our parent
26948 implements a public function that is required by an interface.
26949 (TypeContainer.VerifyPendingMethods): Hook this up.
26951 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
26952 `modules' and `assemblies' arraylists into arrays. We only grow
26953 these are the very early start up of the program, so this improves
26954 the speedof LookupType (nicely measured).
26956 * expression.cs (MakeByteBlob): Replaced unsafe code with
26957 BitConverter, as suggested by Paolo.
26959 * cfold.cs (ConstantFold.Binary): Special case: perform constant
26960 folding of string concatenation, but if either side is a string,
26961 and the other is not, then return null, and let the runtime use
26962 the concatenation on the string plus the object (using
26963 `Object.ToString').
26965 2002-03-04 Miguel de Icaza <miguel@ximian.com>
26967 Constant Folding has been implemented now.
26969 * expression.cs (Unary.Reduce): Do not throw an exception, catch
26970 the error instead on types that are not supported in one's
26973 * constant.cs (Constant and all children): New set of functions to
26974 perform implict and explicit conversions.
26976 * ecore.cs (EnumConstant): Implement the new functions to perform
26977 conversion by proxying to the child expression.
26979 * codegen.cs: (ConstantCheckState): Constant evaluation has its
26980 own separate setting that can not be turned off from the command
26981 line using --unchecked or --checked and is only controlled using
26982 the checked/unchecked statements and expressions. This setting is
26983 used by the constant folder to flag errors.
26985 * expression.cs (CheckedExpr, UncheckedExpr): Set the
26986 ConstantCheckState as well.
26988 During Resolve, they also have to flag the state, because the
26989 constant folder runs completely in the Resolve phase.
26991 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
26994 2002-03-01 Miguel de Icaza <miguel@ximian.com>
26996 * cfold.cs: New file, this file contains the constant folder.
26998 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
26999 argument to track whether we are using the resulting address to
27000 load or store a value and provide better error messages.
27002 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27003 new AddressOf arguments.
27005 * statement.cs (Foreach.EmitCollectionForeach): Update
27007 * expression.cs (Argument.Emit): Call AddressOf with proper
27008 arguments to track usage.
27010 (New.DoEmit): Call AddressOf with new arguments.
27012 (Unary.Emit): Adjust AddressOf call.
27014 2002-03-01 Ravi Pratap <ravi@ximian.com>
27016 * cs-parser.jay (member_access): Change the case for pre-defined types
27017 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27020 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27023 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27024 essentially like methods and apply attributes like MethodImplOptions to them too.
27026 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27029 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27030 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27033 * Update code everywhere accordingly.
27035 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27037 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27039 2002-02-28 Ravi Pratap <ravi@ximian.com>
27041 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27042 try performing lookups against those instead of jumping straight into using
27043 the 'using' clauses.
27045 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27047 (LookupType): Perform lookups in implicit parents too.
27049 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27050 sequence as RootContext.LookupType.
27052 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27053 the various cases of namespace lookups into this method.
27055 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27057 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27058 in positional arguments)
27060 * class.cs (Operator): Update the AllowedModifiers to contain
27063 * cs-parser.jay: Update operator declaration to allow for the
27064 operator body to be empty.
27066 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27069 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27071 * class.cs (Method.Emit): Label parameters.
27073 * driver.cs: Return 1 or 0 as the program exit code.
27075 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27077 * expression.cs: Special case the `null' object when trying to
27078 auto-compute the type, as anything can be explicitly converted to
27081 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27082 spotting this Paolo.
27084 (Expression.ImplicitNumericConversion): Perform comparissions of
27085 the type using the underlying type in the case of an enumeration
27086 rather than using the enumeration type for the compare.
27088 Cope with the underlying == type case, which is not possible to
27091 (Expression.ConvertNumericExplicit): Perform comparissions of
27092 the type using the underlying type in the case of an enumeration
27093 rather than using the enumeration type for the compare.
27095 * driver.cs: If the user does not supply an extension, assume .exe
27097 * cs-parser.jay (if_statement): Rewrote so that we can track the
27098 location for the if statement.
27100 * expression.cs (Binary.ConstantFold): Only concat strings when
27101 the operation is "+", not everything ;-)
27103 * statement.cs (Statement.EmitBoolExpression): Take a location
27105 (If, While, Do): Track location.
27107 * expression.cs (Binary.ResolveOperator): In the object + string
27108 case, I was missing a call to ConvertImplicit
27110 2002-02-25 Ravi Pratap <ravi@ximian.com>
27112 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
27113 Location arguments. Ensure we use RootContext.LookupType to do our work
27114 and not try to do a direct Type.GetType and ModuleBuilder.GetType
27116 * interface.cs (PopulateMethod): Handle the type of the parameter being
27119 * expression.cs (Invocation.BetterFunction): Handle the case when we
27120 have a params method with no fixed arguments and a call is made with no
27123 2002-02-25 Miguel de Icaza <miguel@ximian.com>
27125 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
27126 the verbatim-string-literal
27128 * support.cs (InternalParameters.ParameterModifier): handle null
27130 (InternalParameters.ParameterType): ditto.
27132 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
27133 duplicating the name of the variable parameter.
27134 (GetParameterByName): Fix bug where we were not looking up array
27135 paramters if they were the only present (thanks Paolo!).
27136 (GetParameterInfo): We only have an empty set of types if both
27137 fixed and array are set to null.
27138 (GetParameterInfo-idx): Handle FixedParameter == null
27140 * cs-parser.jay: Handle the case where there is no catch
27141 statements (missing null test).
27143 2002-02-22 Miguel de Icaza <miguel@ximian.com>
27145 * driver.cs (MainDriver): Be conservative on our command line
27148 Catch DirectoryNotFoundException when calling GetFiles.
27150 (SplitPathAndPattern): Used to split the input specification into
27151 a path and a pattern that we can feed to Directory.GetFiles.
27153 2002-02-21 Miguel de Icaza <miguel@ximian.com>
27155 * statement.cs (Fixed): Implement the last case of the Fixed
27156 statement (string handling).
27158 * expression.cs (StringPtr): New class used to return a char * to
27159 a string; Used by the Fixed statement.
27161 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
27163 * expression.cs (Binary.ResolveOperator): Remove redundant
27164 MemberLookup pn parent type.
27165 Optimize union call, we do not need a union if the types are the same.
27166 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
27169 Specialize the use of MemberLookup everywhere, instead of using
27170 the default settings.
27172 (StackAlloc): Implement stackalloc keyword.
27174 * cs-parser.jay: Add rule to parse stackalloc.
27176 * driver.cs: Handle /h, /help, /?
27178 * expression.cs (MakeByteBlob): Removed the hacks we had in place
27179 before we supported unsafe code.
27181 * makefile: add --unsafe to the self compilation of mcs.
27183 2002-02-20 Miguel de Icaza <miguel@ximian.com>
27185 * expression.cs (PointerArithmetic): New class that is used to
27186 perform pointer arithmetic.
27187 (Binary.Resolve): Handle pointer arithmetic
27188 Handle pointer comparission.
27189 (ArrayPtr): Utility expression class that is used to take the
27190 address of an array.
27192 (ElementAccess): Implement array access for pointers
27194 * statement.cs (Fixed): Implement fixed statement for arrays, we
27195 are missing one more case before we are done.
27197 * expression.cs (Indirection): Implement EmitAssign and set the
27198 ExprClass to Variable. This allows pointer dereferences to be
27199 treated as variables, and to have values assigned to them.
27201 * ecore.cs (Expression.StoreFromPtr): New utility function to
27202 store values dereferencing.
27204 2002-02-20 Ravi Pratap <ravi@ximian.com>
27206 * expression.cs (Binary.ResolveOperator): Ensure that we are
27207 not trying to operate on a void type - this fixes the reported
27210 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
27211 the parent implementation is sealed.
27213 * ../errors/cs0239.cs : Add.
27215 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
27217 * typemanager.cs (unverifiable_code_type): Corresponds to
27218 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
27219 which have unsafe code in them.
27221 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
27224 2002-02-19 Miguel de Icaza <miguel@ximian.com>
27226 * cs-tokenizer.cs: Add support for @"litreal strings"
27228 Make tokenizer accept pre-processor directives
27229 on any column (remove the old C-like limitation).
27231 * rootcontext.cs (EmitCode): Emit any global attributes.
27232 (AddGlobalAttributes): Used to keep track of assembly attributes.
27234 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
27236 * cs-parser.jay: Add support for global attributes.
27238 2002-02-17 Miguel de Icaza <miguel@ximian.com>
27240 * expression.cs (Indirection): New helper class. Unary will
27241 create Indirection classes to be able to implement the
27242 IMemoryLocation interface on it.
27244 2002-02-16 Miguel de Icaza <miguel@ximian.com>
27246 * cs-parser.jay (fixed_statement): reference the right statement.
27248 * statement.cs (Fixed.Emit): Finish implementing the fixed
27249 statement for the &x case.
27251 2002-02-14 Miguel de Icaza <miguel@ximian.com>
27253 * class.cs (Property.Define, Method.Define): Remove newslot when
27256 * modifiers.cs: My use of NewSlot when `Abstract' was set was
27257 wrong. NewSlot should only be used if the `new' keyword is present.
27259 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
27260 locating our system dir. Sorry about this.
27262 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27264 * driver.cs (GetSystemDir): Compute correctly the location of our
27265 system assemblies. I was using the compiler directory instead of
27266 the library directory.
27268 2002-02-13 Ravi Pratap <ravi@ximian.com>
27270 * expression.cs (BetterFunction): Put back in what Miguel commented out
27271 since it is the correct fix. The problem is elsewhere ;-)
27273 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
27274 parameters of the parms method are themselves compatible or not !
27276 (StandardConversionExists): Fix very dangerous bug where we were forgetting
27277 to check that a class implements an interface before saying that an implicit
27278 conversion was allowed. Use ImplementsInterface to do the checking.
27280 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27282 * class.cs (Method.Define): Track whether we are an explicit
27283 implementation or not. And only call DefineMethodOverride if we
27284 are an explicit implementation.
27286 (Property.DefineMethod): Ditto.
27288 2002-02-11 Ravi Pratap <ravi@ximian.com>
27290 * expression.cs (BetterFunction): Catch hideous bug which was
27291 preventing us from detecting ambiguous calls due to implicit casts i.e
27294 2002-01-29 Miguel de Icaza <miguel@ximian.com>
27296 * support.cs (Pair): Remove un-needed method. I figured why I was
27297 getting the error in cs-parser.jay, the variable in a foreach loop
27298 is readonly, and the compiler does not really treat this as a variable.
27300 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
27301 instead of EQUALS in grammar.
27303 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
27305 * expression.cs (Unary.DoResolve): Check whether the argument is
27308 2002-01-28 Miguel de Icaza <miguel@ximian.com>
27310 * support.cs: Api for Pair to set a value. Despite the fact that
27311 the variables are public the MS C# compiler refuses to compile
27312 code that accesses the field if the variable is part of a foreach
27315 * statement.cs (Fixed): Begin implementation of the fixed
27318 (Block.AddVariable): Return the VariableInfo on success and null
27319 on failure instead of true/false.
27321 * cs-parser.jay (foreach): Catch errors on variables already
27322 defined (we were ignoring this value before) and properly unwind
27323 the block hierarchy
27325 (fixed_statement): grammar for the fixed statement.
27327 2002-01-25 Miguel de Icaza <miguel@ximian.com>
27329 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
27330 pointer types to be incretemented.
27332 (SizeOf): Implement.
27334 * cs-parser.jay (pointer_member_access): Implement
27335 expr->IDENTIFIER production.
27337 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
27338 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
27341 (Unary): Implement indirection.
27343 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
27344 use in non-unsafe context).
27346 (SimpleName.DoResolve): Check for pointers in field access on safe
27349 (Expression.LoadFromPtr): Factor the load-indirect code in this
27350 function. This was duplicated in UnboxCast and ParameterReference
27352 2002-01-24 Miguel de Icaza <miguel@ximian.com>
27354 * expression.cs (ComposedCast): report an error if a pointer cast
27355 is used in a safe region.
27357 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
27358 pointer type casts in unsafe context.
27360 * codegen.cs (EmitContext): Set up IsUnsafe.
27362 * cs-parser.jay (non_expression_type): Add productions for pointer
27365 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
27366 code. We should not use force into static mode if the method is
27367 not virtual. Fixes bug in MIS
27369 * statement.cs (Do.Emit, While.Emit, For.Emit,
27370 Statement.EmitBoolExpression): Add support to Do and While to
27371 propagate infinite loop as `I do return' semantics.
27373 Improve the For case to also test for boolean constants.
27375 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
27376 to the list of attributes we can add.
27378 Remove `EmitContext' argument.
27380 * class.cs (Method.Define): Apply parameter attributes.
27381 (Constructor.Define): Apply parameter attributes.
27382 (MethodCore.LabelParameters): Move here the core of labeling
27385 * support.cs (ReflectionParameters.ParameterModifier,
27386 InternalParameters.ParameterModifier): Use IsByRef on the type and
27387 only return the OUT bit for these parameters instead of in/out/ref
27390 This is because I miss-understood things. The ParameterInfo.IsIn
27391 and IsOut represent whether the parameter has the [In] and [Out]
27394 2002-01-22 Miguel de Icaza <miguel@ximian.com>
27396 * ecore.cs (FieldExpr.Emit): Release temporaries.
27398 * assign.cs (LocalTemporary.Release): new function.
27400 * codegen.cs (EmitContext.GetTemporaryStorage,
27401 EmitContext.FreeTemporaryStorage): Rework the way we deal with
27402 temporary storage. Now we can "put back" localbuilders when we
27405 2002-01-21 Miguel de Icaza <miguel@ximian.com>
27407 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
27408 need to make a copy of the variable to generate verifiable code.
27410 2002-01-19 Miguel de Icaza <miguel@ximian.com>
27412 * driver.cs: Compute dynamically the system directory.
27414 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
27415 Slower, but more generally useful. Used by the abstract
27416 registering implementation.
27418 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
27419 the rules for the special rule on Type/instances. First check if
27420 we have the same name, and if so, try that special static path
27421 rather than the instance path.
27423 2002-01-18 Miguel de Icaza <miguel@ximian.com>
27425 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
27428 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
27429 Enum, ValueType, Delegate or Array for non-corlib compiles.
27431 * cs-tokenizer.cs: Catch long identifiers (645)
27433 * typemanager.cs (IndexerPropetyName): Ravi never tested this
27436 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
27437 fix, we were returning too early, so we were not registering
27438 pending methods from abstract classes.
27440 Do not register pending methods if the class is abstract.
27442 * expression.cs (Conditional.DoResolve): Report circular implicit
27443 conversions when we neecd to compute it for conditional
27446 (Is.DoResolve): If the expression is always of the provided type,
27447 flag warning 183. If the expression can not ever be of the
27448 provided type flag warning 184.
27450 * class.cs: Catch 169 as well.
27452 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
27455 2002-01-18 Nick Drochak <ndrochak@gol.com>
27457 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
27459 2002-01-17 Miguel de Icaza <miguel@ximian.com>
27461 * interface.cs: (PopulateMethod): Check for pointers being defined
27462 only if the unsafe context is active.
27463 (PopulateProperty): ditto.
27464 (PopulateIndexer): ditto.
27466 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
27467 specified. If pointers are present, make sure that they are
27468 present in an unsafe context.
27469 (Constructor, Constructor.Define): ditto.
27470 (Field, Field.Define): ditto.
27471 (Property, Property.Define): ditto.
27472 (Event, Event.Define): ditto.
27474 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
27475 hashtable if there are classes or structs defined.
27477 * expression.cs (LocalVariableReference.DoResolve): Simplify this
27478 code, as the constant resolution moved.
27480 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
27481 the metadata, so we can flag error 133.
27483 * decl.cs (MemberCore.UnsafeOK): New function to test that a
27484 pointer is being declared in an unsafe context.
27486 2002-01-16 Miguel de Icaza <miguel@ximian.com>
27488 * modifiers.cs (Modifiers.Check): Require a Location argument.
27489 Report error 227 for Unsafe use.
27491 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
27493 * statement.cs (For.Emit): If the test is null, then report that
27494 we do `return', as we wont reach anything afterwards.
27496 (Switch.SwitchGoverningType): Track the expression that matched
27499 * driver.cs: Allow negative numbers as an error code to flag.
27501 * cs-parser.jay: Handle 1551.
27503 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
27505 2002-01-15 Miguel de Icaza <miguel@ximian.com>
27507 * cs-parser.jay: Report 1518 (type declaration can only contain
27508 class, struct, interface, enum or delegate)
27510 (switch_label): Report 1523 (keywords `case' or `default' must
27513 (opt_switch_sections): Report 1522 (empty switch)
27515 * driver.cs: Report 1515 (response file specified multiple times)
27516 Report 1516 (Source file specified multiple times).
27518 * expression.cs (Argument.Resolve): Signal 1510
27520 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
27521 access not allowed in static code)
27523 2002-01-11 Ravi Pratap <ravi@ximian.com>
27525 * typemanager.cs (IsPointerType): Utility method which we are going
27528 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
27529 the object type, so we take care of that.
27531 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
27533 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
27534 added to non-params parameters :-)
27536 * typemanager.cs (CSharpName): Include 'void' type too.
27538 (void_ptr_type): Include in the set of core types.
27540 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
27543 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
27546 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
27547 completely forgotten about it.
27549 2002-01-10 Ravi Pratap <ravi@ximian.com>
27551 * cs-parser.jay (pointer_type): Add. This begins our implementation
27552 of parsing rules for unsafe code.
27554 (unsafe_statement): Implement.
27556 (embedded_statement): Modify to include the above.
27558 * statement.cs (Unsafe): Implement new class for unsafe blocks.
27560 * codegen.cs (EmitContext.InUnsafe): Add. This determines
27561 if the current context is an unsafe one.
27563 * cs-parser.jay (local_variable_pointer_type): Since local variable types
27564 are handled differently, we need separate rules for them.
27566 (local_variable_declaration): Update to use local_variable_pointer_type
27567 to allow variable declarations of unmanaged pointer types.
27569 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
27570 in unsafe contexts.
27572 * ../errors/cs0214.cs : Add.
27574 2002-01-16 Nick Drochak <ndrochak@gol.com>
27576 * makefile: remove 'response' file when cleaning.
27578 2002-01-15 Miguel de Icaza <miguel@ximian.com>
27580 * cs-parser.jay: Report 1524.
27582 2002-01-14 Miguel de Icaza <miguel@ximian.com>
27584 * typemanager.cs (RegisterMethod): drop checking if we have
27585 registered this from here
27587 2002-01-12 Miguel de Icaza <miguel@ximian.com>
27589 * class.cs (Method.EmitDestructor): Implement calling our base
27592 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
27593 value of InFinally.
27595 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
27596 this routine and will wrap the call in a try/catch block. Deal
27599 2002-01-11 Miguel de Icaza <miguel@ximian.com>
27601 * ecore.cs (Expression.MemberLookup): instead of taking a
27602 parameter `same_type' that was used to tell whether we could
27603 access private members we compute our containing type from the
27606 (FieldExpr): Added partial support for volatile fields. This does
27607 not work for volatile fields exposed from assemblies, as I can not
27608 figure out how to extract the modreq from it.
27610 Updated all the source files to use this.
27612 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
27613 because it is referenced by MemberLookup very often.
27615 2002-01-09 Ravi Pratap <ravi@ximian.com>
27617 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
27618 TypeBuilder.GetCustomAttributes to retrieve what we need.
27620 Get rid of redundant default_member_attr_type as this is the same as
27621 default_member_type which already exists.
27623 * interface.cs, attribute.cs : Update accordingly.
27625 2002-01-08 Miguel de Icaza <miguel@ximian.com>
27627 * typemanager.cs: Enable IndexerPropertyName again. It does not
27628 work for TYpeBuilders though. Ravi, can you please fix this?
27630 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
27632 * expression.cs (Argument.Emit): Handle the case of ref objects
27633 being passed to ref functions;
27635 (ParameterReference.EmitLoad): Loads the content of the pointer
27636 without dereferencing.
27638 2002-01-07 Miguel de Icaza <miguel@ximian.com>
27640 * cs-tokenizer.cs: Implemented the pre-processing expressions.
27642 2002-01-08 Ravi Pratap <ravi@ximian.com>
27644 * class.cs (Indexer.DefineMethod): Incorporate the interface
27645 type in the name of the method if we are doing explicit interface
27648 * expression.cs (ConversionExists): Remove as it is completely obsolete.
27650 (BetterConversion): Fix extremely trivial bug where we were referring to
27651 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
27654 * ../errors/bug16.cs : Add although we have fixed it.
27656 2002-01-07 Miguel de Icaza <miguel@ximian.com>
27658 * expression.cs (BaseIndexer): Begin implementation.
27660 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
27662 * cs-parser.jay (indexer_declarator): Use qualified_identifier
27663 production directly to remove a shift/reduce, and implement
27664 explicit interface implementation.
27666 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
27667 after a floating point suffix.
27669 * expression.cs (DoNumericPromotions): Improved the conversion for
27670 uint/uint. If we have a constant, we avoid doing a typecast to a
27673 * class.cs (Indexer): Implement explicit interface implementation
27676 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
27678 * class.cs: make the default instance constructor public and hidebysig.
27680 2001-01-03 Ravi Pratap <ravi@ximian.com>
27682 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
27683 so we can call it from elsewhere.
27685 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
27686 we emit it internally if the class has a defined indexer; otherwise the user
27687 emits it by decorating the class definition with the DefaultMemberAttribute.
27689 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
27690 attribute is not used on a type which defines an indexer.
27692 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
27693 character when we skip whitespace.
27695 * ../errors/cs0646.cs : Add.
27697 2002-01-03 Miguel de Icaza <miguel@ximian.com>
27699 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
27702 * makefile: Add practical target `mcs3.exe' which builds the third
27703 generation compiler.
27705 * expression.cs (New): Fix structures constructor calling.
27707 * class.cs (Property, Method, Indexer): Emit Final flag on the
27708 method if we are an interface implementation and we are not
27711 * ecore.cs (PropertyExpr): New public field `IsBase', tells
27712 whether this property is referencing a `base' method.
27714 * expression.cs (Invocation.EmitCall): take an extra argument:
27715 is_base, this is used to determine whether the `call' or
27716 `callvirt' opcode should be used.
27719 * delegate.cs: update EmitCall.
27721 * class.cs (Method.Define): Set NewSlot for the cases where we are
27722 not implementing an interface method.
27724 (Property.Define): ditto.
27726 2002-01-02 Miguel de Icaza <miguel@ximian.com>
27728 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
27729 'r'. Allows mcs to parse itself fully.
27731 2002-01-02 Ravi Pratap <ravi@ximian.com>
27733 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
27734 of the number of initializers that require the InitializeArray method.
27736 (CheckIndices): Store the Expression in all cases - not the plain value. Also
27737 update the above field where necessary.
27739 (MakeByteBlob): Update accordingly.
27741 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
27744 (EmitDynamicInitializers): Update in accordance with the new optimization.
27746 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
27747 same OpCode applies.
27749 * cs-parser.jay : Fix some glaring errors I introduced.
27751 2002-01-01 Ravi Pratap <ravi@ximian.com>
27753 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
27754 so that we can check for name clashes there too.
27756 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
27757 for interface indexers.
27759 * interfaces.cs (Define): Emit the default member attribute.
27761 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
27762 variable was being referred to while setting the value ;-)
27764 2002-01-01 Miguel de Icaza <miguel@ximian.com>
27766 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
27767 byte-by-byte information when we know the data is zero.
27769 Make the block always a multiple of 4, because
27770 DefineInitializedData has a bug.
27772 * assign.cs: Fix, we should assign from the temporary, not from
27775 * expression.cs (MakeByteBlob): Fix my incorrect code.
27777 2001-12-31 Miguel de Icaza <miguel@ximian.com>
27779 * typemanager.cs (EnumToUnderlying): This function is used to get
27780 the underlying type from an enumeration, because it does not
27783 * constant.cs: Use the I4_S form for values between -128 and 127.
27785 * statement.cs (Block.LookupLabel): Looks up a label.
27786 (Block): Drop support for labeled blocks.
27788 (LabeledStatement): New kind of statement that represents a label
27791 (Goto): Finally implement this bad boy.
27793 * cs-parser.jay: Update to reflect new mechanism to implement
27796 2001-12-30 Miguel de Icaza <miguel@ximian.com>
27798 * codegen.cs (EmitContext.This): a codegen property that keeps the
27799 a single instance of this instead of creating many different this
27802 * delegate.cs (Delegate.DoResolve): Update to use the property;
27804 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
27806 * expression.cs (BaseAccess.DoResolve): Ditto.
27808 2001-12-29 Ravi Pratap <ravi@ximian.com>
27810 * typemanager.cs (methodimpl_attr_type): Add to hold the type
27811 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
27813 (InitCoreTypes): Update accordingly.
27815 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
27816 so we can quickly store the state.
27818 (ApplyAttributes): Set the correct implementation flags
27819 for InternalCall methods.
27821 2001-12-29 Miguel de Icaza <miguel@ximian.com>
27823 * expression.cs (EmitCall): if a method is not virtual, then do
27824 not use callvirt on it.
27826 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
27827 user defined stuff) requires the use of stobj, which takes an
27828 address on the stack instead of an array and an index. So emit
27829 the Ldelema operation for it.
27831 (EmitStoreOpcode): Use stobj for valuetypes.
27833 (UnaryMutator.EmitCode): Use the right 1 value depending on
27834 whether we are dealing with int64/uint64, float or doubles.
27836 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
27837 constructors that I implemented last night.
27839 (Constructor.IsDefault): Fix to work properly for static
27842 * cs-parser.jay (CheckDef): report method signature errors.
27843 Update error number 103 to be 132.
27845 * decl.cs: New AdditionResult enumeration value: MethodExists.
27846 Although we do this check for methods later on in the semantic
27847 analysis, catching repeated default constructors is so easy that
27848 we catch these here.
27850 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
27853 (ParameterReference.EmitAssign, Emit): handle
27856 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
27857 (ArrayAccess.EmitStoreOpcode): ditto.
27859 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
27861 * expression.cs (MakeByteBlob): Complete all the missing types
27862 (uint, short, ushort, byte, sbyte)
27864 * class.cs: Only init instance field initializers on instance
27867 Rename `constructors' to instance_constructors.
27869 (TypeContainer.AddConstructor): Only add constructors to the list
27870 if it is not static.
27872 Make sure that we handle default_static_constructor independently
27873 everywhere where we handle instance_constructors
27875 2001-12-28 Miguel de Icaza <miguel@ximian.com>
27877 * class.cs: Do not lookup or create a base initializer for a
27878 static constructor.
27880 (ConstructorInitializer.Resolve): use the proper type to lookup
27883 * cs-parser.jay: Report error 1585 (modifiers between type and name).
27885 * enum.cs, interface.cs: Remove CloseType, this is taken care by
27888 * decl.cs: CloseType is now an virtual method, the default
27889 implementation just closes this type.
27891 2001-12-28 Ravi Pratap <ravi@ximian.com>
27893 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
27894 to PreserveSig by default. Also emit HideBySig on such methods.
27896 Basically, set the defaults to standard values.
27898 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
27899 argument, if candidate is better, it can't be worse than the best !
27901 (Invocation): Re-write bits to differentiate between methods being
27902 applicable in their expanded form and their normal form - for params
27905 Get rid of use_standard everywhere as only standard conversions are allowed
27906 in overload resolution.
27908 More spec conformance.
27910 2001-12-27 Miguel de Icaza <miguel@ximian.com>
27912 * driver.cs: Add --timestamp, to see where the compiler spends
27915 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
27916 `this' in static code.
27918 (SimpleName.DoResolve): Implement in terms of a helper function
27919 that allows static-references to be passed upstream to
27922 (Expression.ResolveWithSimpleName): Resolve specially simple
27923 names when called by MemberAccess to implement the special
27926 (Expression.ImplicitReferenceConversion): Handle conversions from
27927 Null to reference types before others, as Null's type is
27930 * expression.cs (Invocation.EmitCall): Handle the special case of
27931 calling methods declared on a reference type from a ValueType
27932 (Base classes System.Object and System.Enum)
27934 (MemberAccess.Resolve): Only perform lookups on Enumerations if
27935 the left hand side is a TypeExpr, not on every enumeration.
27937 (Binary.Resolve): If types are reference types, then do a cast to
27938 object on operators != and == of both arguments.
27940 * typemanager.cs (FindMembers): Extract instance and static
27941 members if requested.
27943 * interface.cs (PopulateProperty): Use void_type instead of null
27944 as the return type for the setter method.
27946 (PopulateIndexer): ditto.
27948 2001-12-27 Ravi Pratap <ravi@ximian.com>
27950 * support.cs (ReflectionParameters): Fix minor bug where we
27951 were examining the wrong parameter for the ParamArray attribute.
27953 Cope with requests for the type of the parameter at position
27954 greater than the params parameter's. We now return the element
27955 type of the params array as that makes more sense.
27957 * expression.cs (Invocation.IsParamsMethodApplicable): Update
27958 accordingly as we no longer have to extract the element type
27961 (Invocation.OverloadResolve): Update.
27963 2001-12-27 Miguel de Icaza <miguel@ximian.com>
27965 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
27966 against IEnumerator, test whether the return value is a descendant
27967 of the IEnumerator interface.
27969 * class.cs (Indexer.Define): Use an auxiliary method to implement
27970 the other bits of the method definition. Begin support for
27971 explicit interface implementation.
27973 (Property.DefineMethod): Use TypeManager.void_type instead of null
27974 for an empty return value.
27976 2001-12-26 Miguel de Icaza <miguel@ximian.com>
27978 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
27979 dealing with a FieldExpr which is composed of a FieldBuilder, in
27980 the code path we did extract the constant, but we should have
27981 obtained the underlying value to be able to cast it (otherwise we
27982 end up in an infinite loop, this is what Ravi was running into).
27984 (ArrayCreation.UpdateIndices): Arrays might be empty.
27986 (MemberAccess.ResolveMemberAccess): Add support for section
27987 14.5.4.1 that deals with the special case of E.I when E is a type
27988 and something else, that I can be a reference to a static member.
27990 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
27991 handle a particular array type to create byte blobs, it is just
27992 something we dont generate byteblobs for.
27994 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
27997 * location.cs (Push): remove the key from the hashtable that we
27998 are about to add. This happens for empty files.
28000 * driver.cs: Dispose files after we have parsed them.
28002 (tokenize): new function that only runs the tokenizer on its
28003 input, for speed testing.
28005 2001-12-26 Ravi Pratap <ravi@ximian.com>
28007 * class.cs (Event.Define): Define the private field only if there
28008 are no accessors defined.
28010 * expression.cs (ResolveMemberAccess): If there is no associated
28011 field with the event, that means we have an event defined with its
28012 own accessors and we should flag error cs0070 since transforming
28013 ourselves into a field is not valid in that case.
28015 * ecore.cs (SimpleName.DoResolve): Same as above.
28017 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28018 and charset to sane values.
28020 2001-12-25 Ravi Pratap <ravi@ximian.com>
28022 * assign.cs (DoResolve): Perform check on events only if they
28023 are being accessed outside the declaring type.
28025 * cs-parser.jay (event_declarations): Update rules to correctly
28026 set the type of the implicit parameter etc.
28028 (add_accessor, remove_accessor): Set current local parameters.
28030 * expression.cs (Binary): For delegate addition and subtraction,
28031 cast the return value from the method into the appropriate delegate
28034 2001-12-24 Ravi Pratap <ravi@ximian.com>
28036 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28037 of these as the workaround is unnecessary.
28039 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28040 delegate data - none of that is needed at all.
28042 Re-write bits to extract the instance expression and the delegate method
28045 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28048 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28049 of attaching attributes instead of duplicating code everywhere.
28051 * everywhere : Update code to do attribute emission using the above method.
28053 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28055 * expression.cs (IsParamsMethodApplicable): if there are not
28056 parameters, return immediately.
28058 * ecore.cs: The 0 literal can be implicity converted to an enum
28061 (SimpleName.DoResolve): First lookup the type, then lookup the
28064 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28065 want to get its address. If the InstanceExpression is not
28066 addressable, store the result in a temporary variable, then get
28069 * codegen.cs: Only display 219 errors on warning level or above.
28071 * expression.cs (ArrayAccess): Make it implement the
28072 IMemoryLocation interface.
28074 (Binary.DoResolve): handle the operator == (object a, object b)
28075 and operator != (object a, object b) without incurring into a
28076 BoxedCast (because 5 != o should never be performed).
28078 Handle binary enumerator operators.
28080 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28081 value type, otherwise use Ldelem_ref.
28083 Use precomputed names;
28085 (AddressOf): Implement address of
28087 * cs-parser.jay (labeled_statement): Fix recursive block
28088 addition by reworking the production.
28090 * expression.cs (New.DoEmit): New has a special case:
28092 If we are dealing with a ValueType, we have a few
28093 situations to deal with:
28095 * The target of New is a ValueType variable, that is
28096 easy, we just pass this as the variable reference
28098 * The target of New is being passed as an argument,
28099 to a boxing operation or a function that takes a
28102 In this case, we need to create a temporary variable
28103 that is the argument of New.
28106 2001-12-23 Ravi Pratap <ravi@ximian.com>
28108 * rootcontext.cs (LookupType): Check that current_type is not null before
28109 going about looking at nested types.
28111 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
28112 not implement the IAssignMethod interface any more.
28114 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
28115 where we tranform them into FieldExprs if they are being resolved from within
28116 the declaring type.
28118 * ecore.cs (SimpleName.DoResolve): Do the same here.
28120 * assign.cs (DoResolve, Emit): Clean up code considerably.
28122 * ../errors/bug10.cs : Add.
28124 * ../errors/cs0070.cs : Add.
28126 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
28128 * assign.cs : Get rid of EventIsLocal everywhere.
28130 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28132 * ecore.cs (ConvertIntLiteral): finished the implementation.
28134 * statement.cs (SwitchLabel): Convert the value we are using as a
28135 key before looking up the table.
28137 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28139 * codegen.cs (EmitTopBlock): Require a Location argument now.
28141 * cs-parser.jay (constructor_declarator): We need to setup
28142 current_local_parameters before we parse the
28143 opt_constructor_initializer, to allow the variables to be bound
28144 to the constructor arguments.
28146 * rootcontext.cs (LookupType): First lookup nested classes in our
28147 class and our parents before we go looking outside our class.
28149 * expression.cs (ConstantFold): Extract/debox the values at the
28152 * rootcontext.cs (EmitCode): Resolve the constants first before we
28153 resolve the types. This is not really needed, but it helps debugging.
28155 * statement.cs: report location.
28157 * cs-parser.jay: pass location to throw statement.
28159 * driver.cs: Small bug fix.
28161 * report.cs: Updated format to be 4-zero filled digits.
28163 2001-12-22 Ravi Pratap <ravi@ximian.com>
28165 * expression.cs (CheckIndices): Fix minor bug where the wrong
28166 variable was being referred to ;-)
28168 (DoEmit): Do not call EmitStaticInitializers when the
28169 underlying type is System.Object.
28171 2001-12-21 Ravi Pratap <ravi@ximian.com>
28173 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
28174 and do the usual workaround for SRE.
28176 * class.cs (MyEventBuilder.EventType): New member to get at the type
28177 of the event, quickly.
28179 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
28181 * assign.cs (Assign.DoResolve): Handle the case when the target
28182 is an EventExpr and perform the necessary checks.
28184 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
28187 (SimpleName.MemberStaticCheck): Include check for EventExpr.
28189 (EventExpr): Set the type in the constructor itself since we
28190 are meant to be born fully resolved.
28192 (EventExpr.Define): Revert code I wrote earlier.
28194 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
28195 instance expression is null. The instance expression is a This in that case
28196 or a null, depending on whether it is a static method or not.
28198 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
28199 refers to more than one method.
28201 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
28202 and accordingly flag errors.
28204 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28206 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
28208 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28210 * location.cs (ToString): Provide useful rutine.
28212 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28214 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
28215 objects, return the actual integral boxed.
28217 * statement.cs (SwitchLabel): define an ILLabel for each
28220 (Switch.CheckSwitch): If the value is a Literal, extract
28221 the underlying literal.
28223 Also in the unused hashtable we had, add the SwitchLabel so we can
28224 quickly look this value up.
28226 * constant.cs: Implement a bunch of new constants. Rewrite
28227 Literal based on this. Made changes everywhere to adapt to this.
28229 * expression.cs (Expression.MakeByteBlob): Optimize routine by
28230 dereferencing array only once, and also copes with enumrations.
28232 bytes are two bytes wide, not one.
28234 (Cast): Perform constant conversions.
28236 * ecore.cs (TryImplicitIntConversion): Return literals instead of
28237 wrappers to the literals here.
28239 * expression.cs (DoNumericPromotions): long literals can converted
28240 to ulong implicity (this is taken care of elsewhere, but I was
28241 missing this spot).
28243 * ecore.cs (Expression.Literalize): Make the return type Literal,
28244 to improve type checking.
28246 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
28248 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28250 * literal.cs: Revert code from ravi that checked the bounds. The
28251 bounds are sane by the definition of the type itself.
28253 * typemanager.cs: Fix implementation of ImplementsInterface. We
28254 need to actually look up in our parent hierarchy for interfaces
28257 * const.cs: Use the underlying type for enumerations
28259 * delegate.cs: Compute the basename for the delegate creation,
28260 that should fix the delegate test case, and restore the correct
28261 Type Lookup semantics in rootcontext
28263 * rootcontext.cs: Revert Ravi's last patch. The correct way of
28264 referencing a nested type with the Reflection API is using the "+"
28267 * cs-parser.jay: Do not require EOF token at the end.
28269 2001-12-20 Ravi Pratap <ravi@ximian.com>
28271 * rootcontext.cs (LookupType): Concatenate type names with
28272 a '.' instead of a '+' The test suite passes again.
28274 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
28275 field of the enumeration.
28277 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
28278 the case when the member is an EventExpr.
28280 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
28281 static has an associated instance expression.
28283 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
28285 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
28287 * class.cs (Event.Define): Register event and perform appropriate checks
28290 We define the Add and Remove methods even if the use provides none because
28291 in that case, we provide default implementations ourselves.
28293 Define a private field of the type of the event. This is done by the CSC compiler
28294 and we should be doing it too ;-)
28296 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
28297 More methods we use in code we generate.
28299 (multicast_delegate_type, delegate_type): Two separate types since the distinction
28302 (InitCoreTypes): Update accordingly for the above.
28304 * class.cs (Event.Emit): Generate code for default accessors that we provide
28306 (EmitDefaultMethod): Do the job in the above.
28308 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
28311 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28313 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
28314 builders even if we were missing one.
28316 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
28317 pass the Basename as our class name instead of the Name. The
28318 basename will be correctly composed for us.
28320 * parameter.cs (Paramters): Now takes a Location argument.
28322 * decl.cs (DeclSpace.LookupType): Removed convenience function and
28323 make all the code call directly LookupType in RootContext and take
28324 this chance to pass the Location information everywhere.
28326 * Everywhere: pass Location information.
28328 2001-12-19 Miguel de Icaza <miguel@ximian.com>
28330 * class.cs (Constructor.Define): Updated way of detecting the
28331 length of the parameters.
28333 (TypeContainer.DefineType): Use basename as the type name for
28336 (TypeContainer.Define): Do not recursively define types here, as
28337 definition is taken care in order by the RootContext.
28339 * tree.cs: Keep track of namespaces in a per-file basis.
28341 * parameter.cs (Parameter.ComputeSignature): Update to use
28344 (Parameters.GetSignature): ditto.
28346 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
28347 instead of a TypeContainer.
28349 (Interface.SemanticAnalysis): Use `this' instead of our parent to
28350 resolve names. Because we need to be resolve in our context, not
28353 * driver.cs: Implement response files.
28355 * class.cs (TypeContainer.DefineType): If we are defined, do not
28356 redefine ourselves.
28358 (Event.Emit): Emit the code for add/remove handlers.
28359 (Event.Define): Save the MethodBuilders for add/remove.
28361 * typemanager.cs: Use pair here too.
28363 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
28364 DictionaryEntry requires the first argument to be non-null.
28366 (enum_declaration): Compute full name for registering the
28369 (delegate_declaration): Instead of using
28370 formal_parameter_list, use opt_formal_parameter_list as the list
28373 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
28374 (EventParsing): New property that controls whether `add' and
28375 `remove' are returned as tokens or identifiers (for events);
28377 2001-12-19 Ravi Pratap <ravi@ximian.com>
28379 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
28380 use MyEventBuilder only and let it wrap the real builder for us.
28382 (MyEventBuilder): Revamp constructor etc.
28384 Implement all operations that we perform on EventBuilder in precisely the same
28387 (FindMembers): Update to use the EventBuilder member.
28389 (Event.Emit): Update accordingly.
28391 2001-12-18 Ravi Pratap <ravi@ximian.com>
28393 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
28394 by calling the appropriate methods.
28396 (GetCustomAttributes): Make stubs as they cannot possibly do anything
28399 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
28401 2001-12-17 Ravi Pratap <ravi@ximian.com>
28403 * delegate.cs (Delegate.Populate): Check that the return type
28404 and various parameters types are indeed accessible.
28406 * class.cs (Constructor.Define): Same here.
28408 (Field.Define): Ditto.
28410 (Event.Define): Ditto.
28412 (Operator.Define): Check that the underlying Method defined itself
28413 correctly - so it's MethodBuilder should not be null.
28415 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
28416 expression happens to be null.
28418 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
28419 members but as of now we don't seem to be able to do anything really useful with it.
28421 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
28422 not the EventBuilder.
28424 2001-12-18 Miguel de Icaza <miguel@ximian.com>
28426 * cs-tokenizer.cs: Add support for defines.
28427 Add support for #if, #elif, #else, #endif
28429 (eval_var): evaluates a variable.
28430 (eval): stubbed for evaluating functions.
28432 * cs-parser.jay: Pass the defines information
28434 * driver.cs: Add --define command line option.
28436 * decl.cs: Move MemberCore here.
28438 Make it the base class for DeclSpace. This allows us to catch and
28439 report 108 and 109 for everything now.
28441 * class.cs (TypeContainer.Define): Extract all the members
28442 before populating and emit the warning 108 (new keyword required
28443 to override) instead of having each member implement this.
28445 (MemberCore.Define): New abstract method, we will be using this in
28446 the warning reporting engine in Populate.
28448 (Operator.Define): Adjust to new MemberCore protocol.
28450 * const.cs (Const): This does not derive from Expression, it is a
28451 temporary object we use to create fields, it is a MemberCore.
28453 * class.cs (Method.Define): Allow the entry point to be in a
28456 * driver.cs: Rewrite the argument handler to clean it up a bit.
28458 * rootcontext.cs: Made it just an auxiliary namespace feature by
28459 making everything static.
28461 * driver.cs: Adapt code to use RootContext type name instead of
28464 * delegate.cs: Remove RootContext argument.
28466 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
28469 * class.cs (Event.Define): The lookup can fail.
28471 * cs-tokenizer.cs: Begin implementation of pre-procesor.
28473 * expression.cs: Resolve the this instance before invoking the code.
28475 2001-12-17 Miguel de Icaza <miguel@ximian.com>
28477 * cs-parser.jay: Add a production in element_access that allows
28478 the thing to become a "type" reference. This way we can parse
28479 things like "(string [])" as a type.
28481 Note that this still does not handle the more complex rules of
28485 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
28487 * ecore.cs: (CopyNewMethods): new utility function used to
28488 assemble the list of methods from running FindMembers.
28490 (MemberLookup): Rework FindMembers so that
28492 2001-12-16 Miguel de Icaza <miguel@ximian.com>
28494 * class.cs (TypeContainer): Remove Delegates who fail to be
28497 * delegate.cs (Populate): Verify that we dont get null return
28498 values. TODO: Check for AsAccessible.
28500 * cs-parser.jay: Use basename to emit error 574 (destructor should
28501 have the same name as container class), not the full name.
28503 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
28504 possible representation.
28506 Also implements integer type suffixes U and L.
28508 2001-12-15 Miguel de Icaza <miguel@ximian.com>
28510 * expression.cs (ArrayCreation.DoResolve): We need to do the
28511 argument resolution *always*.
28513 * decl.cs: Make this hold the namespace. Hold the root context as
28515 (LookupType): Move here.
28517 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
28519 * location.cs (Row, Name): Fixed the code, it was always returning
28520 references to the first file.
28522 * interface.cs: Register properties defined through interfaces.
28524 * driver.cs: Add support for globbing on the command line
28526 * class.cs (Field): Make it derive from MemberCore as well.
28529 2001-12-15 Ravi Pratap <ravi@ximian.com>
28531 * class.cs (Event::Define): Check that the type of the event is a delegate
28532 type else flag error #66.
28534 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
28537 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
28538 values of EntryPoint, CharSet etc etc.
28540 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
28542 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
28543 be null and we should ignore this. I am not sure if this is really clean. Apparently,
28544 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
28545 which needs this to do its work.
28547 * ../errors/cs0066.cs : Add.
28549 2001-12-14 Miguel de Icaza <miguel@ximian.com>
28551 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
28554 * class.cs: (MethodSignature.MethodSignature): Removed hack that
28555 clears out the parameters field.
28556 (MemberSignatureCompare): Cleanup
28558 (MemberCore): New base class used to share code between MethodCore
28561 (RegisterRequiredImplementations) BindingFlags.Public requires
28562 either BindingFlags.Instace or Static. Use instance here.
28564 (Property): Refactored code to cope better with the full spec.
28566 * parameter.cs (GetParameterInfo): Return an empty array instead
28569 * class.cs (Property): Abstract or extern properties have no bodies.
28571 * parameter.cs (GetParameterInfo): return a zero-sized array.
28573 * class.cs (TypeContainer.MethodModifiersValid): Move all the
28574 method modifier validation to the typecontainer so we can reuse
28575 this on properties.
28577 (MethodCore.ParameterTypes): return an empty sized array of types.
28579 (Property.Define): Test property modifier validity.
28581 Add tests for sealed/override too.
28583 (Method.Emit): abstract or extern methods have no bodies.
28585 2001-12-14 Ravi Pratap <ravi@ximian.com>
28587 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
28590 (Method::Define, ::Emit): Modify accordingly.
28592 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
28594 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
28596 * makefile: Pass in /unsafe.
28598 2001-12-13 Miguel de Icaza <miguel@ximian.com>
28600 * class.cs (MakeKey): Kill routine.
28602 * class.cs (TypeContainer.Define): Correctly define explicit
28603 method implementations (they require the full interface name plus
28606 * typemanager.cs: Deply the PtrHashtable here and stop using the
28607 lame keys. Things work so much better.
28609 This of course broke everyone who depended on `RegisterMethod' to
28610 do the `test for existance' test. This has to be done elsewhere.
28612 * support.cs (PtrHashtable): A hashtable that avoid comparing with
28613 the object stupid Equals method (because, that like fails all over
28614 the place). We still do not use it.
28616 * class.cs (TypeContainer.SetRequiredInterface,
28617 TypeContainer.RequireMethods): Killed these two routines and moved
28618 all the functionality to RegisterRequiredImplementations.
28620 (TypeContainer.RegisterRequiredImplementations): This routine now
28621 registers all the implementations required in an array for the
28622 interfaces and abstract methods. We use an array of structures
28623 which can be computed ahead of time to reduce memory usage and we
28624 also assume that lookups are cheap as most classes will not
28625 implement too many interfaces.
28627 We also avoid creating too many MethodSignatures.
28629 (TypeContainer.IsInterfaceMethod): Update and optionally does not
28630 clear the "pending" bit if we find that there are problems with
28633 (TypeContainer.VerifyPendingMethods): Update to report errors of
28634 methods that look like implementations but are not.
28636 (TypeContainer.Define): Add support for explicit interface method
28639 2001-12-12 Miguel de Icaza <miguel@ximian.com>
28641 * typemanager.cs: Keep track of the parameters here instead of
28642 being a feature of the TypeContainer.
28644 * class.cs: Drop the registration of parameters here, as
28645 InterfaceMethods are also interface declarations.
28647 * delegate.cs: Register methods with the TypeManager not only with
28648 the TypeContainer. This code was buggy.
28650 * interface.cs: Full registation here.
28652 2001-12-11 Miguel de Icaza <miguel@ximian.com>
28654 * expression.cs: Remove reducer for binary expressions, it can not
28657 * const.cs: Put here the code that used to go into constant.cs
28659 * constant.cs: Put here the code for constants, this is a new base
28660 class for Literals.
28662 * literal.cs: Make Literal derive from Constant.
28664 2001-12-09 Miguel de Icaza <miguel@ximian.com>
28666 * statement.cs (Return.Emit): Report error 157 if the user
28667 attempts to return from a finally block.
28669 (Return.Emit): Instead of emitting a return, jump to the end of
28672 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
28673 LocalBuilder to store the result of the function. ReturnLabel is
28674 the target where we jump.
28677 2001-12-09 Radek Doulik <rodo@ximian.com>
28679 * cs-parser.jay: remember alias in current namespace
28681 * ecore.cs (SimpleName::DoResolve): use aliases for types or
28684 * class.cs (LookupAlias): lookup alias in my_namespace
28686 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
28688 (LookupAlias): lookup alias in this and if needed in parent
28691 2001-12-08 Miguel de Icaza <miguel@ximian.com>
28695 * rootcontext.cs: (ModuleBuilder) Made static, first step into
28696 making things static. I need this to avoid passing the
28697 TypeContainer when calling ParameterType.
28699 * support.cs (InternalParameters.ParameterType): Remove ugly hack
28700 that did string manipulation to compute the type and then call
28701 GetType. Use Parameter.ParameterType instead.
28703 * cs-tokenizer.cs: Consume the suffix for floating values.
28705 * expression.cs (ParameterReference): figure out whether this is a
28706 reference parameter or not. Kill an extra variable by computing
28707 the arg_idx during emission.
28709 * parameter.cs (Parameters.GetParameterInfo): New overloaded
28710 function that returns whether a parameter is an out/ref value or not.
28712 (Parameter.ParameterType): The type of the parameter (base,
28713 without ref/out applied).
28715 (Parameter.Resolve): Perform resolution here.
28716 (Parameter.ExternalType): The full type (with ref/out applied).
28718 * statement.cs (Using.Emit, Using.EmitExpression): Implement
28719 support for expressions on the using statement.
28721 2001-12-07 Miguel de Icaza <miguel@ximian.com>
28723 * statement.cs (Using.EmitLocalVariableDecls): Split the
28724 localvariable handling of the using statement.
28726 (Block.EmitMeta): Keep track of variable count across blocks. We
28727 were reusing slots on separate branches of blocks.
28729 (Try.Emit): Emit the general code block, we were not emitting it.
28731 Check the type of the declaration to be an IDisposable or
28732 something that can be implicity converted to it.
28734 Emit conversions if required.
28736 * ecore.cs (EmptyExpression): New utility class.
28737 (Expression.ImplicitConversionExists): New utility function.
28739 2001-12-06 Miguel de Icaza <miguel@ximian.com>
28741 * statement.cs (Using): Implement.
28743 * expression.cs (LocalVariableReference): Support read only variables.
28745 * statement.cs: Remove the explicit emit for the Leave opcode.
28746 (VariableInfo): Add a readonly field.
28748 2001-12-05 Miguel de Icaza <miguel@ximian.com>
28750 * ecore.cs (ConvCast): new class used to encapsulate the various
28751 explicit integer conversions that works in both checked and
28752 unchecked contexts.
28754 (Expression.ConvertNumericExplicit): Use new ConvCast class to
28755 properly generate the overflow opcodes.
28757 2001-12-04 Miguel de Icaza <miguel@ximian.com>
28759 * statement.cs: The correct type for the EmptyExpression is the
28760 element_type, not the variable type. Ravi pointed this out.
28762 2001-12-04 Ravi Pratap <ravi@ximian.com>
28764 * class.cs (Method::Define): Handle PInvoke methods specially
28765 by using DefinePInvokeMethod instead of the usual one.
28767 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
28768 above to do the task of extracting information and defining the method.
28770 2001-12-04 Ravi Pratap <ravi@ximian.com>
28772 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
28773 of the condition for string type.
28775 (Emit): Move that here.
28777 (ArrayCreation::CheckIndices): Keep string literals in their expression
28780 (EmitDynamicInitializers): Handle strings appropriately.
28782 2001-12-04 Miguel de Icaza <miguel@ximian.com>
28784 * codegen.cs (EmitContext): Replace multiple variables with a
28785 single pointer to the current Switch statement.
28787 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
28790 2001-12-03 Miguel de Icaza <miguel@ximian.com>
28794 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
28797 (Foreach.Emit): Foreach on arrays was not setting
28798 up the loop variables (for break/continue).
28800 (GotoCase): Semi-implented.
28802 2001-12-03 Ravi Pratap <ravi@ximian.com>
28804 * attribute.cs (CheckAttribute): Handle system attributes by using
28805 Attribute.GetAttributes to examine information we need.
28807 (GetValidPlaces): Same here.
28809 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
28811 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
28813 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
28815 (Method::Define): Set appropriate flags if we have a DllImport attribute.
28817 (Method::Emit): Handle the case when we are a PInvoke method.
28819 2001-12-03 Miguel de Icaza <miguel@ximian.com>
28821 * expression.cs: Use ResolveWithSimpleName on compound names.
28823 2001-12-02 Ravi Pratap <ravi@ximian.com>
28825 * constant.cs (EmitConstant): Make sure we resolve the associated expression
28826 before trying to reduce it.
28828 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
28830 * constant.cs (LookupConstantValue): Implement.
28832 (EmitConstant): Use the above in emitting the constant.
28834 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
28835 that are user-defined by doing a LookupConstantValue on them.
28837 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
28840 2001-11-29 Miguel de Icaza <miguel@ximian.com>
28842 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
28844 (BaseAccess.DoResolve): Implement.
28846 (MemberAccess.DoResolve): Split this routine into a
28847 ResolveMemberAccess routine that can be used independently
28849 2001-11-28 Miguel de Icaza <miguel@ximian.com>
28851 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
28852 As that share bits of the implementation. Is returns a boolean,
28853 while As returns the Type that is being probed.
28855 2001-12-01 Ravi Pratap <ravi@ximian.com>
28857 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
28858 instead of a Literal - much easier.
28860 (EnumInTransit): Remove - utterly useless :-)
28862 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
28864 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
28866 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
28867 chain when we have no associated expression.
28869 2001-11-30 Ravi Pratap <ravi@ximian.com>
28871 * constant.cs (Define): Use Location while reporting the errror.
28873 Also emit a warning when 'new' is used and there is no inherited
28876 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
28879 (LookupEnumValue): Implement to lookup an enum member's value and define it
28882 (Populate): Re-write accordingly to use the above routine.
28884 2001-11-27 Miguel de Icaza <miguel@ximian.com>
28886 * expression.cs (This): Fix prototype for DoResolveLValue to
28887 override the base class DoResolveLValue.
28889 * cs-parser.cs: Report errors cs574 and cs575 (destructor
28892 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
28893 (we need to load the address of the field here). This fixes
28896 (FieldExpr.DoResolveLValue): Call the DoResolve
28897 function to initialize the Instance expression.
28899 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
28900 correctly the GetEnumerator operation on a value type.
28902 * cs-parser.jay: Add more simple parsing error catches.
28904 * statement.cs (Switch): Add support for string switches.
28905 Handle null specially.
28907 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
28909 2001-11-28 Ravi Pratap <ravi@ximian.com>
28911 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
28913 (declare_local_constant): New helper function.
28915 * statement.cs (AddConstant): Keep a separate record of constants
28917 (IsConstant): Implement to determine if a variable is a constant.
28919 (GetConstantExpression): Implement.
28921 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
28923 * statement.cs (IsVariableDefined): Re-write.
28925 2001-11-27 Ravi Pratap <ravi@ximian.com>
28927 * class.cs (TypeContainer::FindMembers): Look for constants
28928 in the case when we are looking for MemberTypes.Field
28930 * expression.cs (MemberAccess::DoResolve): Check that in the
28931 case we are a FieldExpr and a Literal, we are not being accessed
28932 by an instance reference.
28934 * cs-parser.jay (local_constant_declaration): Implement.
28936 (declaration_statement): Implement for constant declarations.
28938 2001-11-26 Miguel de Icaza <miguel@ximian.com>
28940 * statement.cs (Switch): Catch double defaults.
28942 (Switch): More work on the switch() statement
28943 implementation. It works for integral values now, need to finish
28947 2001-11-24 Miguel de Icaza <miguel@ximian.com>
28949 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
28950 integer literals into other integer literals. To be used by
28953 2001-11-24 Ravi Pratap <ravi@ximian.com>
28955 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
28958 (EmitDynamicInitializers): Cope with the above since we extract data
28959 directly from ArrayData now.
28961 (ExpectInitializers): Keep track of whether initializers are mandatory
28964 (Bounds): Make it a hashtable to prevent the same dimension being
28965 recorded for every element in that dimension.
28967 (EmitDynamicInitializers): Fix bug which prevented the Set array method
28970 Also fix bug which was causing the indices to be emitted in the reverse
28973 2001-11-24 Miguel de Icaza <miguel@ximian.com>
28975 * expression.cs (ArrayCreation): Implement the bits that Ravi left
28976 unfinished. They do not work, because the underlying code is
28979 2001-11-22 Miguel de Icaza <miguel@ximian.com>
28981 * cs-parser.jay: Remove bogus fixme.
28983 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
28984 on Switch statement.
28986 2001-11-23 Ravi Pratap <ravi@ximian.com>
28988 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
28991 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
28992 parameter. Apparently, any expression is allowed.
28994 (ValidateInitializers): Update accordingly.
28996 (CheckIndices): Fix some tricky bugs thanks to recursion.
28998 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
28999 I was being completely brain-dead.
29001 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29002 and re-write acordingly.
29004 (DelegateInvocation): Re-write accordingly.
29006 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29008 (MakeByteBlob): Handle types more correctly.
29010 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29011 initialization from expressions but it is incomplete because I am a complete
29014 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29016 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29017 on If. Basically, we have to return `true' (ie, we do return to
29018 our caller) only if both branches of the if return.
29020 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29021 short-circuit operators, handle them as short circuit operators.
29023 (Cast.DoResolve): Resolve type.
29024 (Cast.Cast): Take an expression as the target type.
29026 * cs-parser.jay (cast_expression): Remove old hack that only
29027 allowed a limited set of types to be handled. Now we take a
29028 unary_expression and we resolve to a type during semantic
29031 Use the grammar productions from Rhys to handle casts (this is
29032 not complete like Rhys syntax yet, we fail to handle that corner
29033 case that C# has regarding (-x), but we will get there.
29035 2001-11-22 Ravi Pratap <ravi@ximian.com>
29037 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29038 field which is an array type.
29040 * cs-parser.jay (declare_local_variables): Support array initialization too.
29042 * typemanager.cs (MakeKey): Implement.
29044 (everywhere): Use the above appropriately.
29046 * cs-parser.jay (for_statement): Update for array initialization while
29047 declaring variables.
29049 * ecore.cs : The error message was correct, it's the variable's names that
29050 were misleading ;-) Make the code more readable.
29052 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29053 the correct type etc.
29055 (ConvertExplicit): Handle Enum types by examining the underlying type.
29057 2001-11-21 Ravi Pratap <ravi@ximian.com>
29059 * parameter.cs (GetCallingConvention): Always return
29060 CallingConventions.Standard for now.
29062 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29064 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29065 and `r' after calling DoNumericPromotions.
29067 * ecore.cs: Fix error message (the types were in the wrong order).
29069 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29070 BindingFlags.Instance as well
29072 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29073 implicit int literal conversion in an empty cast so that we
29074 propagate the right type upstream.
29076 (UnboxCast): new class used to unbox value types.
29077 (Expression.ConvertExplicit): Add explicit type conversions done
29080 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29081 the target type before applying the implicit LongLiterals to ULong
29084 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29086 * cs-parser.jay (for_statement): Reworked the way For works: now
29087 we declare manually any variables that are introduced in
29088 for_initializer to solve the problem of having out-of-band code
29089 emition (that is what got for broken).
29091 (declaration_statement): Perform the actual variable declaration
29092 that used to be done in local_variable_declaration here.
29094 (local_variable_declaration): Do not declare anything, just pass
29095 the information on a DictionaryEntry
29097 2001-11-20 Ravi Pratap <ravi@ximian.com>
29099 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29100 re-write of the logic to now make it recursive.
29102 (UpdateIndices): Re-write accordingly.
29104 Store element data in a separate ArrayData list in the above methods.
29106 (MakeByteBlob): Implement to dump the array data into a byte array.
29108 2001-11-19 Ravi Pratap <ravi@ximian.com>
29110 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
29113 * constant.cs (Define): Implement.
29115 (EmitConstant): Re-write fully.
29117 Pass in location info.
29119 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
29122 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
29123 DictionaryEntry since we need location info too.
29125 (constant_declaration): Update accordingly.
29127 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
29128 code into another method : UpdateIndices.
29130 2001-11-18 Ravi Pratap <ravi@ximian.com>
29132 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
29133 some type checking etc.
29135 2001-11-17 Ravi Pratap <ravi@ximian.com>
29137 * expression.cs (ArrayCreation::ValidateInitializers): Implement
29138 bits to provide dimension info if the user skips doing that.
29140 Update second constructor to store the rank correctly.
29142 2001-11-16 Ravi Pratap <ravi@ximian.com>
29144 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
29145 and try to implement.
29147 * ../errors/cs0150.cs : Add.
29149 * ../errors/cs0178.cs : Add.
29151 2001-11-16 Miguel de Icaza <miguel@ximian.com>
29153 * statement.cs: Implement foreach on multi-dimensional arrays.
29155 * parameter.cs (Parameters.GetParameterByName): Also lookup the
29156 name of the params argument.
29158 * expression.cs: Use EmitStoreOpcode to get the right opcode while
29159 initializing the array.
29161 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
29162 we can use this elsewhere.
29164 * statement.cs: Finish implementation of foreach for single
29167 * cs-parser.jay: Use an out-of-band stack to pass information
29168 around, I wonder why I need this.
29170 foreach_block: Make the new foreach_block the current_block.
29172 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
29173 function used to return a static Parameters structure. Used for
29174 empty parameters, as those are created very frequently.
29176 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
29178 2001-11-15 Ravi Pratap <ravi@ximian.com>
29180 * interface.cs : Default modifier is private, not public. The
29181 make verify test passes again.
29183 2001-11-15 Ravi Pratap <ravi@ximian.com>
29185 * support.cs (ReflectionParameters): Fix logic to determine
29186 whether the last parameter is a params one. Test 9 passes again.
29188 * delegate.cs (Populate): Register the builders we define with
29189 RegisterParameterForBuilder. Test 19 passes again.
29191 * cs-parser.jay (property_declaration): Reference $6 instead
29192 of $$ to get at the location.
29194 (indexer_declaration): Similar stuff.
29196 (attribute): Ditto.
29198 * class.cs (Property): Register parameters for the Get and Set methods
29199 if they exist. Test 23 passes again.
29201 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
29202 call to EmitArguments as we are sure there aren't any params arguments.
29203 Test 32 passes again.
29205 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
29206 IndexOutOfRangeException.
29208 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
29209 Test 33 now passes again.
29211 2001-11-15 Miguel de Icaza <miguel@ximian.com>
29213 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
29214 broke a bunch of things. Will have to come up with a better way
29215 of tracking locations.
29217 * statement.cs: Implemented foreach for single dimension arrays.
29219 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29221 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
29222 an error. This removes the lookup from the critical path.
29224 * cs-parser.jay: Removed use of temporary_loc, which is completely
29227 2001-11-14 Miguel de Icaza <miguel@ximian.com>
29229 * support.cs (ReflectionParameters.ParameterModifier): Report
29230 whether the argument is a PARAMS argument or not.
29232 * class.cs: Set the attribute `ParamArrayAttribute' on the
29233 parameter argument.
29235 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
29236 and cons_param_array_attribute (ConstructorInfo for
29237 ParamArrayAttribute).,
29239 * codegen.cs: Emit the return using the `Return' statement, that
29240 way we can report the error correctly for missing return values.
29242 * class.cs (Method.Emit): Clean up.
29244 * expression.cs (Argument.Resolve): Take another argument: the
29245 location where this argument is used. Notice that this is not
29246 part of the "Argument" class as to reduce the size of the
29247 structure (we know the approximate location anyways).
29249 Test if the argument is a variable-reference, if not, then
29250 complain with a 206.
29252 (Argument.Emit): Emit addresses of variables.
29254 (Argument.FullDesc): Simplify.
29256 (Invocation.DoResolve): Update for Argument.Resolve.
29258 (ElementAccess.DoResolve): ditto.
29260 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
29261 method should be virtual, as this method is always virtual.
29263 (NewDelegate.DoResolve): Update for Argument.Resolve.
29265 * class.cs (ConstructorInitializer.DoResolve): ditto.
29267 * attribute.cs (Attribute.Resolve): ditto.
29269 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29271 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
29273 * expression.cs (ParameterReference): Drop IStackStorage and implement
29274 IAssignMethod instead.
29276 (LocalVariableReference): ditto.
29278 * ecore.cs (FieldExpr): Drop IStackStorage and implement
29279 IAssignMethod instead.
29281 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29283 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
29284 enumerations that are used in heavily used structures derive from
29285 byte in a laughable and pathetic attempt to reduce memory usage.
29286 This is the kind of pre-optimzations that you should not do at
29287 home without adult supervision.
29289 * expression.cs (UnaryMutator): New class, used to handle ++ and
29290 -- separatedly from the other unary operators. Cleans up the
29291 code, and kills the ExpressionStatement dependency in Unary.
29293 (Unary): Removed `method' and `Arguments' from this class, making
29294 it smaller, and moving it all to SimpleCall, so I can reuse this
29295 code in other locations and avoid creating a lot of transient data
29296 strucutres when not required.
29298 * cs-parser.jay: Adjust for new changes.
29300 2001-11-11 Miguel de Icaza <miguel@ximian.com>
29302 * enum.cs (Enum.Populate): If there is a failure during
29305 * cs-parser.jay (opt_enum_base): we used to catch type errors
29306 here, but this is really incorrect. The type error should be
29307 catched during semantic analysis.
29309 2001-12-11 Ravi Pratap <ravi@ximian.com>
29311 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
29312 current_local_parameters as expected since I, in my stupidity, had forgotten
29315 * attribute.cs (GetValidPlaces): Fix stupid bug.
29317 * class.cs (Method::Emit): Perform check on applicability of attributes.
29319 (Constructor::Emit): Ditto.
29321 (Field::Emit): Ditto.
29323 (Field.Location): Store location information.
29325 (Property, Event, Indexer, Operator): Ditto.
29327 * cs-parser.jay (field_declaration): Pass in location for each field.
29329 * ../errors/cs0592.cs : Add.
29331 2001-11-12 Ravi Pratap <ravi@ximian.com>
29333 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
29335 (InitCoreTypes): Update accordingly.
29337 (RegisterAttrType, LookupAttr): Implement.
29339 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
29340 info about the same.
29342 (Resolve): Update to populate the above as necessary.
29344 (Error592): Helper.
29346 (GetValidPlaces): Helper to the above.
29348 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
29350 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
29352 2001-11-12 Ravi Pratap <ravi@ximian.com>
29354 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
29356 * ../errors/cs0617.cs : Add.
29358 2001-11-11 Ravi Pratap <ravi@ximian.com>
29360 * enum.cs (Emit): Rename to Populate to be more consistent with what
29361 we expect it to do and when exactly it is called.
29363 * class.cs, rootcontext.cs : Update accordingly.
29365 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
29366 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
29368 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
29370 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
29371 of a fieldinfo using the above, when dealing with a FieldBuilder.
29373 2001-11-10 Ravi Pratap <ravi@ximian.com>
29375 * ../errors/cs0031.cs : Add.
29377 * ../errors/cs1008.cs : Add.
29379 * ../errrors/cs0543.cs : Add.
29381 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
29384 (FindMembers): Implement.
29386 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
29387 enums and delegates too.
29389 (enum_types): Rename to builder_to_enum.
29391 (delegate_types): Rename to builder_to_delegate.
29393 * delegate.cs (FindMembers): Implement.
29395 2001-11-09 Ravi Pratap <ravi@ximian.com>
29397 * typemanager.cs (IsEnumType): Implement.
29399 * enum.cs (Emit): Re-write parts to account for the underlying type
29400 better and perform checking etc.
29402 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
29403 of the underlying type.
29405 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
29408 * enum.cs (error31): Helper to report error #31.
29410 * cs-parser.jay (enum_declaration): Store location of each member too.
29412 * enum.cs (member_to_location): New hashtable.
29414 (AddEnumMember): Update location hashtable.
29416 (Emit): Use the location of each member while reporting errors.
29418 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29420 * cs-parser.jay: A for_initializer if is a
29421 local_variable_declaration really ammount to have an implicit
29422 block with the variable declaration and no initializer for for.
29424 * statement.cs (For.Emit): Cope with null initializers.
29426 This fixes the infinite loop on for initializers.
29428 2001-11-08 Miguel de Icaza <miguel@ximian.com>
29430 * enum.cs: More cleanup.
29432 * ecore.cs: Remove dead code.
29434 * class.cs (Property.Emit): More simplification.
29435 (Event.Emit): ditto.
29437 Reworked to have less levels of indentation.
29439 2001-11-08 Ravi Pratap <ravi@ximian.com>
29441 * class.cs (Property): Emit attributes.
29451 * enum.cs (Emit): Ditto.
29453 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
29456 * class.cs (Field, Event, etc.): Move attribute generation into the
29457 Emit method everywhere.
29459 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
29460 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
29461 as we had no way of defining nested enums !
29463 * rootcontext.cs : Adjust code accordingly.
29465 * typemanager.cs (AddEnumType): To keep track of enum types separately.
29467 2001-11-07 Ravi Pratap <ravi@ximian.com>
29469 * expression.cs (EvalConstantExpression): Move into ecore.cs
29471 * enum.cs (Enum): Rename some members and make them public and readonly
29472 according to our convention.
29474 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
29477 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
29479 (Enum::Emit): Write a simple version for now which doesn't try to compute
29480 expressions. I shall modify this to be more robust in just a while.
29482 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
29484 (TypeContainer::CloseType): Create the Enum types too.
29486 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
29488 * expression.cs (EvalConstantExpression): Get rid of completely.
29490 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
29491 user-defined values and other cases.
29493 (IsValidEnumLiteral): Helper function.
29495 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
29496 out there in the case we had a literal FieldExpr.
29498 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
29500 (Literalize): Revamp a bit to take two arguments.
29502 (EnumLiteral): New class which derives from Literal to wrap enum literals.
29504 2001-11-06 Ravi Pratap <ravi@ximian.com>
29506 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
29508 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
29510 (Resolve): Use the above to ensure we have proper initializers.
29512 2001-11-05 Ravi Pratap <ravi@ximian.com>
29514 * expression.cs (Expression::EvalConstantExpression): New method to
29515 evaluate constant expressions.
29517 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
29519 2001-11-07 Miguel de Icaza <miguel@ximian.com>
29521 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
29524 (Binary.ResolveOperator): Handle operator != (object a, object b)
29525 and operator == (object a, object b);
29527 (Binary.DoNumericPromotions): Indicate whether the numeric
29528 promotion was possible.
29530 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
29533 Made the ArrayAccess implement interface IAssignMethod instead of
29534 IStackStore as the order in which arguments are passed reflects
29537 * assign.cs: Instead of using expr.ExprClass to select the way of
29538 assinging, probe for the IStackStore/IAssignMethod interfaces.
29540 * typemanager.cs: Load InitializeArray definition.
29542 * rootcontext.cs (RootContext.MakeStaticData): Used to define
29543 static data that can be used to initialize arrays.
29545 2001-11-05 Miguel de Icaza <miguel@ximian.com>
29547 * expression.cs: Handle operator== and operator!= for booleans.
29549 (Conditioal.Reduce): Implement reducer for the ?: operator.
29551 (Conditional.Resolve): Implement dead code elimination.
29553 (Binary.Resolve): Catch string literals and return a new
29554 concatenated string.
29556 (Unary.Reduce): Implement reduction of unary expressions.
29558 * ecore.cs: Split out the expression core handling here.
29560 (Expression.Reduce): New method used to perform constant folding
29561 and CSE. This is needed to support constant-expressions.
29563 * statement.cs (Statement.EmitBoolExpression): Pass true and false
29564 targets, and optimize for !x.
29566 2001-11-04 Ravi Pratap <ravi@ximian.com>
29568 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
29569 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
29570 set custom atttributes.
29572 * literal.cs (Literal::GetValue): New abstract method to return the actual
29573 value of the literal, cast as an object.
29575 (*Literal): Implement GetValue method.
29577 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
29578 expressions to the arraylist but objects of type Argument.
29580 * class.cs (TypeContainer::Emit): Emit our attributes too.
29582 (Method::Emit, Constructor::Emit): Ditto.
29584 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
29585 to be ignoring earlier.
29587 2001-11-03 Ravi Pratap <ravi@ximian.com>
29589 * attribute.cs (AttributeSection::Define): Implement to do the business
29590 of constructing a CustomAttributeBuilder.
29592 (Attribute): New trivial class. Increases readability of code.
29594 * cs-parser.jay : Update accordingly.
29596 (positional_argument_list, named_argument_list, named_argument): New rules
29598 (attribute_arguments): Use the above so that we are more correct.
29600 2001-11-02 Ravi Pratap <ravi@ximian.com>
29602 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
29603 to perform all checks for a method with a params parameter.
29605 (Invocation::OverloadResolve): Update to use the above method and therefore
29606 cope correctly with params method invocations.
29608 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
29611 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
29612 constructors in our parent too because we can't afford to miss out on
29615 * attribute.cs (AttributeSection): New name for the class Attribute
29617 Other trivial changes to improve readability.
29619 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
29620 use the new class names.
29622 2001-11-01 Ravi Pratap <ravi@ximian.com>
29624 * class.cs (Method::Define): Complete definition for params types too
29626 (Indexer::Define): Ditto.
29628 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
29629 Cope everywhere with a request for info about the array parameter.
29631 2001-11-01 Ravi Pratap <ravi@ximian.com>
29633 * tree.cs (RecordNamespace): Fix up to check for the correct key.
29635 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
29636 local_variable_type to extract the string corresponding to the type.
29638 (local_variable_type): Fixup the action to use the new helper method.
29640 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
29643 * expression.cs : Clean out code which uses the above.
29645 2001-10-31 Ravi Pratap <ravi@ximian.com>
29647 * typemanager.cs (RegisterMethod): Check if we already have an existing key
29648 and bale out if necessary by returning a false.
29650 (RegisterProperty): Ditto.
29652 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
29653 and print out appropriate error messages.
29655 * interface.cs (everywhere): Ditto.
29657 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
29658 location to constructor.
29660 * class.cs (Property, Event, Indexer): Update accordingly.
29662 * ../errors/cs111.cs : Added.
29664 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
29665 of a method, as laid down by the spec.
29667 (Invocation::OverloadResolve): Use the above method.
29669 2001-10-31 Ravi Pratap <ravi@ximian.com>
29671 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
29672 now take a TypeContainer and a Parameters object.
29674 (ParameterData): Modify return type of ParameterModifier method to be
29675 Parameter.Modifier and not a string.
29677 (ReflectionParameters, InternalParameters): Update accordingly.
29679 * expression.cs (Argument::GetParameterModifier): Same here.
29681 * support.cs (InternalParameters::ParameterType): Find a better way of determining
29682 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
29683 symbol in it at all so maybe this is only for now.
29685 2001-10-30 Ravi Pratap <ravi@ximian.com>
29687 * support.cs (InternalParameters): Constructor now takes an extra argument
29688 which is the actual Parameters class.
29690 (ParameterDesc): Update to provide info on ref/out modifiers.
29692 * class.cs (everywhere): Update call to InternalParameters to pass in
29693 the second argument too.
29695 * support.cs (ParameterData): Add ParameterModifier, which is a method
29696 to return the modifier info [ref/out etc]
29698 (InternalParameters, ReflectionParameters): Implement the above.
29700 * expression.cs (Argument::ParameterModifier): Similar function to return
29701 info about the argument's modifiers.
29703 (Invocation::OverloadResolve): Update to take into account matching modifiers
29706 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
29707 a new SetFormalParameters object which we pass to InternalParameters.
29709 2001-10-30 Ravi Pratap <ravi@ximian.com>
29711 * expression.cs (NewArray): Merge into the ArrayCreation class.
29713 2001-10-29 Ravi Pratap <ravi@ximian.com>
29715 * expression.cs (NewArray): Merge classes NewBuiltinArray and
29716 NewUserdefinedArray into one as there wasn't much of a use in having
29719 * expression.cs (Argument): Change field's name to ArgType from Type.
29721 (Type): New readonly property which returns the proper type, taking into
29722 account ref/out modifiers.
29724 (everywhere): Adjust code accordingly for the above.
29726 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
29727 whether we are emitting for a ref or out parameter.
29729 * expression.cs (Argument::Emit): Use the above field to set the state.
29731 (LocalVariableReference::Emit): Update to honour the flag and emit the
29734 * parameter.cs (Attributes): Set the correct flags for ref parameters.
29736 * expression.cs (Argument::FullDesc): New function to provide a full desc.
29738 * support.cs (ParameterData): Add method ParameterDesc to the interface.
29740 (ReflectionParameters, InternalParameters): Implement the above method.
29742 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
29745 (Invocation::FullMethodDesc): Ditto.
29747 2001-10-29 Miguel de Icaza <miguel@ximian.com>
29749 * cs-parser.jay: Add extra production for the second form of array
29752 * expression.cs (ArrayCreation): Update to reflect the above
29755 * Small changes to prepare for Array initialization.
29757 2001-10-28 Miguel de Icaza <miguel@ximian.com>
29759 * typemanager.cs (ImplementsInterface): interface might be null;
29760 Deal with this problem;
29762 Also, we do store negative hits on the cache (null values), so use
29763 this instead of calling t.GetInterfaces on the type everytime.
29765 2001-10-28 Ravi Pratap <ravi@ximian.com>
29767 * typemanager.cs (IsBuiltinType): New method to help determine the same.
29769 * expression.cs (New::DoResolve): Get rid of array creation code and instead
29770 split functionality out into different classes.
29772 (New::FormArrayType): Move into NewBuiltinArray.
29774 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
29777 (NewBuiltinArray): New class to handle creation of built-in arrays.
29779 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
29780 account creation of one-dimensional arrays.
29782 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
29784 (NewUserdefinedArray::DoResolve): Implement.
29786 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
29788 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
29789 we maintain inside the TypeManager. This is necessary to perform lookups on the
29792 (LookupType): Update to perform GetType on the module builders too.
29794 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
29796 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
29798 2001-10-23 Ravi Pratap <ravi@ximian.com>
29800 * expression.cs (New::DoResolve): Implement guts of array creation.
29802 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
29804 2001-10-27 Miguel de Icaza <miguel@ximian.com>
29806 * expression.cs: Fix bug I introduced lsat night that broke
29809 (Expression.Resolve): Report a 246 error (can not resolve name)
29810 if we find a SimpleName in the stream.
29812 (Expression.ResolveLValue): Ditto.
29814 (Expression.ResolveWithSimpleName): This function is a variant of
29815 ResolveName, this one allows SimpleNames to be returned without a
29816 warning. The only consumer of SimpleNames is MemberAccess
29818 2001-10-26 Miguel de Icaza <miguel@ximian.com>
29820 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
29821 might arrive here. I have my doubts that this is correct.
29823 * statement.cs (Lock): Implement lock statement.
29825 * cs-parser.jay: Small fixes to support `lock' and `using'
29827 * cs-tokenizer.cs: Remove extra space
29829 * driver.cs: New flag --checked, allows to turn on integer math
29832 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
29833 Threading.Monitor.Exit
29835 2001-10-23 Miguel de Icaza <miguel@ximian.com>
29837 * expression.cs (IndexerAccess::DoResolveLValue): Set the
29838 Expression Class to be IndexerAccess.
29840 Notice that Indexer::DoResolve sets the eclass to Value.
29842 2001-10-22 Miguel de Icaza <miguel@ximian.com>
29844 * class.cs (TypeContainer::Emit): Emit code for indexers.
29846 * assign.cs (IAssignMethod): New interface implemented by Indexers
29847 and Properties for handling assignment.
29849 (Assign::Emit): Simplify and reuse code.
29851 * expression.cs (IndexerAccess, PropertyExpr): Implement
29852 IAssignMethod, clean up old code.
29854 2001-10-22 Ravi Pratap <ravi@ximian.com>
29856 * typemanager.cs (ImplementsInterface): New method to determine if a type
29857 implements a given interface. Provides a nice cache too.
29859 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
29862 (ConvertReferenceExplicit): Ditto.
29864 * delegate.cs (Delegate::Populate): Update to define the parameters on the
29865 various methods, with correct names etc.
29867 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
29868 Operator.UnaryNegation.
29870 * cs-parser.jay (operator_declarator): Be a little clever in the case where
29871 we have a unary plus or minus operator.
29873 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
29876 * everywhere : update accordingly.
29878 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
29881 * class.cs (Method::Define): For the case where we are implementing a method
29882 inherited from an interface, we need to set the MethodAttributes.Final flag too.
29883 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
29885 2001-10-21 Ravi Pratap <ravi@ximian.com>
29887 * interface.cs (FindMembers): Implement to work around S.R.E
29890 * typemanager.cs (IsInterfaceType): Implement.
29892 (FindMembers): Update to handle interface types too.
29894 * expression.cs (ImplicitReferenceConversion): Re-write bits which
29895 use IsAssignableFrom as that is not correct - it doesn't work.
29897 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
29898 and accordingly override EmitStatement.
29900 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
29901 using the correct logic :-)
29903 2001-10-19 Ravi Pratap <ravi@ximian.com>
29905 * ../errors/cs-11.cs : Add to demonstrate error -11
29907 2001-10-17 Miguel de Icaza <miguel@ximian.com>
29909 * assign.cs (Assign::Resolve): Resolve right hand side first, and
29910 then pass this as a hint to ResolveLValue.
29912 * expression.cs (FieldExpr): Add Location information
29914 (FieldExpr::LValueResolve): Report assignment to readonly
29917 (Expression::ExprClassFromMemberInfo): Pass location information.
29919 (Expression::ResolveLValue): Add new method that resolves an
29922 (Expression::DoResolveLValue): Default invocation calls
29925 (Indexers): New class used to keep track of indexers in a given
29928 (IStackStore): Renamed from LValue, as it did not really describe
29929 what this did. Also ResolveLValue is gone from this interface and
29930 now is part of Expression.
29932 (ElementAccess): Depending on the element access type
29934 * typemanager.cs: Add `indexer_name_type' as a Core type
29935 (System.Runtime.CompilerServices.IndexerNameAttribute)
29937 * statement.cs (Goto): Take a location.
29939 2001-10-18 Ravi Pratap <ravi@ximian.com>
29941 * delegate.cs (Delegate::VerifyDelegate): New method to verify
29942 if two delegates are compatible.
29944 (NewDelegate::DoResolve): Update to take care of the case when
29945 we instantiate a delegate from another delegate.
29947 * typemanager.cs (FindMembers): Don't even try to look up members
29948 of Delegate types for now.
29950 2001-10-18 Ravi Pratap <ravi@ximian.com>
29952 * delegate.cs (NewDelegate): New class to take care of delegate
29955 * expression.cs (New): Split the delegate related code out into
29956 the NewDelegate class.
29958 * delegate.cs (DelegateInvocation): New class to handle delegate
29961 * expression.cs (Invocation): Split out delegate related code into
29962 the DelegateInvocation class.
29964 2001-10-17 Ravi Pratap <ravi@ximian.com>
29966 * expression.cs (New::DoResolve): Implement delegate creation fully
29967 and according to the spec.
29969 (New::DoEmit): Update to handle delegates differently.
29971 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
29972 because of which we were printing out arguments in reverse order !
29974 * delegate.cs (VerifyMethod): Implement to check if the given method
29975 matches the delegate.
29977 (FullDelegateDesc): Implement.
29979 (VerifyApplicability): Implement.
29981 * expression.cs (Invocation::DoResolve): Update to accordingly handle
29982 delegate invocations too.
29984 (Invocation::Emit): Ditto.
29986 * ../errors/cs1593.cs : Added.
29988 * ../errors/cs1594.cs : Added.
29990 * delegate.cs (InstanceExpression, TargetMethod): New properties.
29992 2001-10-16 Ravi Pratap <ravi@ximian.com>
29994 * typemanager.cs (intptr_type): Core type for System.IntPtr
29996 (InitCoreTypes): Update for the same.
29998 (iasyncresult_type, asynccallback_type): Ditto.
30000 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30003 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30006 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30007 the builders for the 4 members of a delegate type :-)
30009 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30012 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30014 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30016 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30018 * statement.cs (Break::Emit): Implement.
30019 (Continue::Emit): Implement.
30021 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30022 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30023 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30024 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30027 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30028 properties that track the label for the current loop (begin of the
30029 loop and end of the loop).
30031 2001-10-15 Ravi Pratap <ravi@ximian.com>
30033 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30034 use of emitting anything at all.
30036 * class.cs, rootcontext.cs : Get rid of calls to the same.
30038 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30040 (Populate): Define the constructor correctly and set the implementation
30043 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30046 (AddDelegateType): Implement.
30048 (IsDelegateType): Implement helper method.
30050 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30052 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30053 and accordingly handle it.
30055 * delegate.cs (Populate): Take TypeContainer argument.
30056 Implement bits to define the Invoke method. However, I still haven't figured out
30057 how to take care of the native int bit :-(
30059 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30060 Qualify the name of the delegate, not its return type !
30062 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30065 (StandardConversionExists): Checking for array types turns out to be recursive.
30067 (ConvertReferenceExplicit): Implement array conversion.
30069 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30071 2001-10-12 Ravi Pratap <ravi@ximian.com>
30073 * cs-parser.jay (delegate_declaration): Store the fully qualified
30074 name as it is a type declaration.
30076 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30079 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30080 as TypeContainer::DefineType.
30082 (Populate): Method in which all the definition of the various methods (Invoke)
30085 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30088 (CloseDelegate): Finally creates the delegate.
30090 * class.cs (TypeContainer::DefineType): Update to define delegates.
30091 (Populate, Emit and CloseType): Do the same thing here too.
30093 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30094 delegates in all these operations.
30096 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30098 * expression.cs: LocalTemporary: a new expression used to
30099 reference a temporary that has been created.
30101 * assign.cs: Handle PropertyAccess back here, so that we can
30102 provide the proper semantic access to properties.
30104 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30105 a few more explicit conversions.
30107 * modifiers.cs: `NEW' modifier maps to HideBySig.
30109 * expression.cs (PropertyExpr): Make this into an
30110 ExpressionStatement, and support the EmitStatement code path.
30112 Perform get/set error checking, clean up the interface.
30114 * assign.cs: recognize PropertyExprs as targets, and if so, turn
30115 them into toplevel access objects.
30117 2001-10-12 Miguel de Icaza <miguel@ximian.com>
30119 * expression.cs: PropertyExpr::PropertyExpr: use work around the
30122 * typemanager.cs: Keep track here of our PropertyBuilders again to
30123 work around lameness in SRE.
30125 2001-10-11 Miguel de Icaza <miguel@ximian.com>
30127 * expression.cs (LValue::LValueResolve): New method in the
30128 interface, used to perform a second resolution pass for LValues.
30130 (This::DoResolve): Catch the use of this in static methods.
30132 (This::LValueResolve): Implement.
30134 (This::Store): Remove warning, assigning to `this' in structures
30137 (Invocation::Emit): Deal with invocation of
30138 methods on value types. We need to pass the address to structure
30139 methods rather than the object itself. (The equivalent code to
30140 emit "this" for structures leaves the entire structure on the
30141 stack instead of a pointer to it).
30143 (ParameterReference::DoResolve): Compute the real index for the
30144 argument based on whether the method takes or not a `this' pointer
30145 (ie, the method is static).
30147 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
30148 value types returned from functions when we need to invoke a
30149 method on the sturcture.
30152 2001-10-11 Ravi Pratap <ravi@ximian.com>
30154 * class.cs (TypeContainer::DefineType): Method to actually do the business of
30155 defining the type in the Modulebuilder or Typebuilder. This is to take
30156 care of nested types which need to be defined on the TypeBuilder using
30157 DefineNestedMethod.
30159 (TypeContainer::GetClassBases): Implement. Essentially the code from the
30160 methods in RootContext, only ported to be part of TypeContainer.
30162 (TypeContainer::GetInterfaceOrClass): Ditto.
30164 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
30166 * interface.cs (Interface::DefineInterface): New method. Does exactly
30167 what RootContext.CreateInterface did earlier, only it takes care of nested types
30170 (Interface::GetInterfaces): Move from RootContext here and port.
30172 (Interface::GetInterfaceByName): Same here.
30174 * rootcontext.cs (ResolveTree): Re-write.
30176 (PopulateTypes): Re-write.
30178 * class.cs (TypeContainer::Populate): Populate nested types too.
30179 (TypeContainer::Emit): Emit nested members too.
30181 * typemanager.cs (AddUserType): Do not make use of the FullName property,
30182 instead just use the name argument passed in as it is already fully
30185 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
30186 to TypeContainer mapping to see if a type is user-defined.
30188 * class.cs (TypeContainer::CloseType): Implement.
30190 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
30191 the default constructor.
30193 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
30196 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
30198 * interface.cs (CloseType): Create the type here.
30200 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
30203 Remove all the methods which are now in TypeContainer.
30205 2001-10-10 Ravi Pratap <ravi@ximian.com>
30207 * delegate.cs (Define): Re-write bits to define the delegate
30210 2001-10-10 Miguel de Icaza <miguel@ximian.com>
30212 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
30214 * expression.cs (ImplicitReferenceConversion): handle null as well
30215 as a source to convert to any reference type.
30217 * statement.cs (Return): Perform any implicit conversions to
30218 expected return type.
30220 Validate use of return statement.
30222 * codegen.cs (EmitContext): Pass the expected return type here.
30224 * class.cs (Method, Constructor, Property): Pass expected return
30225 type to EmitContext.
30227 2001-10-09 Miguel de Icaza <miguel@ximian.com>
30229 * expression.cs: Make DoResolve take an EmitContext instead of a
30232 Replaced `l' and `location' for `loc', for consistency.
30234 (Error, Warning): Remove unneeded Tc argument.
30236 * assign.cs, literal.cs, constant.cs: Update to new calling
30239 * codegen.cs: EmitContext now contains a flag indicating whether
30240 code is being generated in a static method or not.
30242 * cs-parser.jay: DecomposeQI, new function that replaces the old
30243 QualifiedIdentifier. Now we always decompose the assembled
30244 strings from qualified_identifier productions into a group of
30247 2001-10-08 Miguel de Icaza <miguel@ximian.com>
30249 * rootcontext.cs: Deal with field-less struct types correctly now
30250 by passing the size option to Define Type.
30252 * class.cs: Removed hack that created one static field.
30254 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30256 * statement.cs: Moved most of the code generation here.
30258 2001-10-09 Ravi Pratap <ravi@ximian.com>
30260 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
30263 (ElementAccess): Remove useless bits for now - keep checks as the spec
30266 2001-10-08 Ravi Pratap <ravi@ximian.com>
30268 * expression.cs (ElementAccess::DoResolve): Remove my crap code
30269 and start performing checks according to the spec.
30271 2001-10-07 Ravi Pratap <ravi@ximian.com>
30273 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
30274 rank_specifiers instead.
30276 (rank_specifiers): Change the order in which the rank specifiers are stored
30278 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
30280 * expression.cs (ElementAccess): Implement the LValue interface too.
30282 2001-10-06 Ravi Pratap <ravi@ximian.com>
30284 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
30285 except that user defined conversions are not included.
30287 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
30288 perform the conversion of the return type, if necessary.
30290 (New::DoResolve): Check whether we are creating an array or an object
30291 and accordingly do the needful.
30293 (New::Emit): Same here.
30295 (New::DoResolve): Implement guts of array creation.
30297 (New::FormLookupType): Helper function.
30299 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30301 * codegen.cs: Removed most of the code generation here, and move the
30302 corresponding code generation bits to the statement classes.
30304 Added support for try/catch/finalize and throw.
30306 * cs-parser.jay: Added support for try/catch/finalize.
30308 * class.cs: Catch static methods having the flags override,
30309 virtual or abstract.
30311 * expression.cs (UserCast): This user cast was not really doing
30312 what it was supposed to do. Which is to be born in fully resolved
30313 state. Parts of the resolution were being performed at Emit time!
30317 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30319 * expression.cs: Implicity convert the result from UserCast.
30321 2001-10-05 Ravi Pratap <ravi@ximian.com>
30323 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
30324 prevented it from working correctly.
30326 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
30327 merely ConvertImplicit.
30329 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30331 * typemanager.cs: Make the LookupTypeContainer function static,
30332 and not per-instance.
30334 * class.cs: Make static FindMembers (the one that takes a Type
30337 * codegen.cs: Add EmitForeach here.
30339 * cs-parser.jay: Make foreach a toplevel object instead of the
30340 inline expansion, as we need to perform semantic analysis on it.
30342 2001-10-05 Ravi Pratap <ravi@ximian.com>
30344 * expression.cs (Expression::ImplicitUserConversion): Rename to
30345 UserDefinedConversion.
30347 (Expression::UserDefinedConversion): Take an extra argument specifying
30348 whether we look for explicit user conversions too.
30350 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
30352 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
30354 (ExplicitUserConversion): Make it a call to UserDefinedConversion
30355 with the appropriate arguments.
30357 * cs-parser.jay (cast_expression): Record location too.
30359 * expression.cs (Cast): Record location info.
30361 (Expression::ConvertExplicit): Take location argument.
30363 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
30364 to determine if we are doing explicit conversions.
30366 (UserCast::Emit): Update accordingly.
30368 (Expression::ConvertExplicit): Report an error if everything fails.
30370 * ../errors/cs0030.cs : Add.
30372 2001-10-04 Miguel de Icaza <miguel@ximian.com>
30374 * modifiers.cs: If the ABSTRACT keyword is present, also set the
30375 virtual and newslot bits.
30377 * class.cs (TypeContainer::RegisterRequiredImplementations):
30378 Record methods we need.
30380 (TypeContainer::MakeKey): Helper function to make keys for
30381 MethodBases, since the Methodbase key is useless.
30383 (TypeContainer::Populate): Call RegisterRequiredImplementations
30384 before defining the methods.
30386 Create a mapping for method_builders_to_methods ahead of time
30387 instead of inside a tight loop.
30389 (::RequireMethods): Accept an object as the data to set into the
30390 hashtable so we can report interface vs abstract method mismatch.
30392 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30394 * report.cs: Make all of it static.
30396 * rootcontext.cs: Drop object_type and value_type computations, as
30397 we have those in the TypeManager anyways.
30399 Drop report instance variable too, now it is a global.
30401 * driver.cs: Use try/catch on command line handling.
30403 Add --probe option to debug the error reporting system with a test
30406 * report.cs: Add support for exiting program when a probe
30407 condition is reached.
30409 2001-10-03 Ravi Pratap <ravi@ximian.com>
30411 * expression.cs (Binary::DoNumericPromotions): Fix the case when
30412 we do a forcible conversion regardless of type, to check if
30413 ForceConversion returns a null.
30415 (Binary::error19): Use location to report error.
30417 (Unary::error23): Use location here too.
30419 * ../errors/cs0019.cs : Check in.
30421 * ../errors/cs0023.cs : Check in.
30423 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
30424 case of a non-null MethodInfo object with a length of 0 !
30426 (Binary::ResolveOperator): Flag error if overload resolution fails to find
30427 an applicable member - according to the spec :-)
30428 Also fix logic to find members in base types.
30430 (Unary::ResolveOperator): Same here.
30432 (Unary::report23): Change name to error23 and make first argument a TypeContainer
30433 as I was getting thoroughly confused between this and error19 :-)
30435 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
30436 (::FindMostEncompassedType): Implement.
30437 (::FindMostEncompassingType): Implement.
30438 (::StandardConversionExists): Implement.
30440 (UserImplicitCast): Re-vamp. We now need info about most specific
30441 source and target types so that we can do the necessary conversions.
30443 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
30444 mathematical union with no duplicates.
30446 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30448 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
30449 in order from base classes to child classes, so that we can in
30450 child classes look up in our parent for method names and
30451 attributes (required for handling abstract, virtual, new, override
30452 constructs: we need to instrospect our base class, and if we dont
30453 populate the classes in order, the introspection might be
30454 incorrect. For example, a method could query its parent before
30455 the parent has any methods and would determine that the parent has
30456 no abstract methods (while it could have had them)).
30458 (RootContext::CreateType): Record the order in which we define the
30461 2001-10-02 Miguel de Icaza <miguel@ximian.com>
30463 * class.cs (TypeContainer::Populate): Also method definitions can
30464 fail now, keep track of this.
30466 (TypeContainer::FindMembers): Implement support for
30467 DeclaredOnly/noDeclaredOnly flag.
30469 (Constructor::Emit) Return the ConstructorBuilder.
30471 (Method::Emit) Return the MethodBuilder.
30472 Check for abstract or virtual methods to be public.
30474 * rootcontext.cs (RootContext::CreateType): Register all the
30475 abstract methods required for the class to be complete and the
30476 interface methods that must be implemented.
30478 * cs-parser.jay: Report error 501 (method requires body if it is
30479 not marked abstract or extern).
30481 * expression.cs (TypeOf::Emit): Implement.
30483 * typemanager.cs: runtime_handle_type, new global type.
30485 * class.cs (Property::Emit): Generate code for properties.
30487 2001-10-02 Ravi Pratap <ravi@ximian.com>
30489 * expression.cs (Unary::ResolveOperator): Find operators on base type
30490 too - we now conform exactly to the spec.
30492 (Binary::ResolveOperator): Same here.
30494 * class.cs (Operator::Define): Fix minor quirk in the tests.
30496 * ../errors/cs0215.cs : Added.
30498 * ../errors/cs0556.cs : Added.
30500 * ../errors/cs0555.cs : Added.
30502 2001-10-01 Miguel de Icaza <miguel@ximian.com>
30504 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
30505 single integer which is really efficient
30507 2001-10-01 Ravi Pratap <ravi@ximian.com>
30509 * expression.cs (Expression::ImplicitUserConversion): Use location
30510 even in the case when we are examining True operators.
30512 * class.cs (Operator::Define): Perform extensive checks to conform
30513 with the rules for operator overloading in the spec.
30515 * expression.cs (Expression::ImplicitReferenceConversion): Implement
30516 some of the other conversions mentioned in the spec.
30518 * typemanager.cs (array_type): New static member for the System.Array built-in
30521 (cloneable_interface): For System.ICloneable interface.
30523 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
30524 we start resolving the tree and populating types.
30526 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
30528 2001-10-01 Miguel de Icaza <miguel@ximian.com>
30530 * expression.cs (Expression::ExprClassFromMemberInfo,
30531 Expression::Literalize): Create literal expressions from
30532 FieldInfos which are literals.
30534 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
30535 type casts, because they were wrong. The test suite in tests
30538 (ImplicitNumericConversion): ushort to ulong requires a widening
30541 Int32 constant to long requires widening cast as well.
30543 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
30544 for integers because the type on the stack is not i4.
30546 2001-09-30 Miguel de Icaza <miguel@ximian.com>
30548 * expression.cs (report118): require location argument.
30550 * parameter.cs: Do not dereference potential null value.
30552 * class.cs: Catch methods that lack the `new' keyword when
30553 overriding a name. Report warnings when `new' is used without
30554 anything being there to override.
30556 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
30558 * class.cs: Only add constructor to hashtable if it is non-null
30559 (as now constructors can fail on define).
30561 (TypeManager, Class, Struct): Take location arguments.
30563 Catch field instance initialization in structs as errors.
30565 accepting_filter: a new filter for FindMembers that is static so
30566 that we dont create an instance per invocation.
30568 (Constructor::Define): Catch errors where a struct constructor is
30571 * cs-parser.jay: Pass location information for various new
30574 * delegate.cs (Delegate): take a location argument.
30576 * driver.cs: Do not call EmitCode if there were problesm in the
30577 Definition of the types, as many Builders wont be there.
30579 * decl.cs (Decl::Decl): Require a location argument.
30581 * cs-tokenizer.cs: Handle properly hex constants that can not fit
30582 into integers, and find the most appropiate integer for it.
30584 * literal.cs: Implement ULongLiteral.
30586 * rootcontext.cs: Provide better information about the location of
30587 failure when CreateType fails.
30589 2001-09-29 Miguel de Icaza <miguel@ximian.com>
30591 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
30594 * expression.cs (Binary::CheckShiftArguments): Add missing type
30596 (Binary::ResolveOperator): Add type to the logical and and logical
30597 or, Bitwise And/Or and Exclusive Or code paths, it was missing
30600 (Binary::DoNumericPromotions): In the case where either argument
30601 is ulong (and most signed types combined with ulong cause an
30602 error) perform implicit integer constant conversions as well.
30604 2001-09-28 Miguel de Icaza <miguel@ximian.com>
30606 * expression.cs (UserImplicitCast): Method should always be
30608 (Invocation::BetterConversion): Simplified test for IntLiteral.
30610 (Expression::ImplicitNumericConversion): Split this routine out.
30611 Put the code that performs implicit constant integer conversions
30614 (Expression::Resolve): Become a wrapper around DoResolve so we can
30615 check eclass and type being set after resolve.
30617 (Invocation::Badness): Remove this dead function
30619 (Binary::ResolveOperator): Do not compute the expensive argumnets
30620 unless we have a union for it.
30622 (Probe::Emit): Is needs to do an isinst and then
30623 compare against null.
30625 (::CanConvert): Added Location argument. If the Location argument
30626 is null (Location.Null), then we do not report errors. This is
30627 used by the `probe' mechanism of the Explicit conversion. We do
30628 not want to generate an error for something that the user
30629 explicitly requested to be casted. But the pipeline for an
30630 explicit cast first tests for potential implicit casts.
30632 So for now, if the Location is null, it means `Probe only' to
30633 avoid adding another argument. Might have to revise this
30636 (ClassCast): New class used to type cast objects into arbitrary
30637 classes (used in Explicit Reference Conversions).
30639 Implement `as' as well.
30641 Reverted all the patches from Ravi below: they were broken:
30643 * The use of `level' as a mechanism to stop recursive
30644 invocations is wrong. That was there just to catch the
30645 bug with a strack trace but not as a way of addressing
30648 To fix the problem we have to *understand* what is going
30649 on and the interactions and come up with a plan, not
30650 just get things going.
30652 * The use of the type conversion cache that I proposed
30653 last night had an open topic: How does this work across
30654 protection domains. A user defined conversion might not
30655 be public in the location where we are applying the
30656 conversion, a different conversion might be selected
30657 (ie, private A->B (better) but public B->A (worse),
30658 inside A, A->B applies, but outside it, B->A will
30661 * On top of that (ie, even if the above is solved),
30662 conversions in a cache need to be abstract. Ie, `To
30663 convert from an Int to a Short use an OpcodeCast', not
30664 `To convert from an Int to a Short use the OpcodeCast on
30665 the variable 5' (which is what this patch was doing).
30667 2001-09-28 Ravi Pratap <ravi@ximian.com>
30669 * expression.cs (Invocation::ConversionExists): Re-write to use
30670 the conversion cache
30672 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
30673 cache all conversions done, not just user-defined ones.
30675 (Invocation::BetterConversion): The real culprit. Use ConversionExists
30676 to determine if a conversion exists instead of acutually trying to
30677 perform the conversion. It's faster too.
30679 (Expression::ConvertExplicit): Modify to use ConversionExists to check
30680 and only then attempt the implicit conversion.
30682 2001-09-28 Ravi Pratap <ravi@ximian.com>
30684 * expression.cs (ConvertImplicit): Use a cache for conversions
30685 already found. Check level of recursion and bail out if necessary.
30687 2001-09-28 Miguel de Icaza <miguel@ximian.com>
30689 * typemanager.cs (string_concat_string_string, string_concat_object_object):
30690 Export standard methods that we expect for string operations.
30692 * statement.cs (Block::UsageWarning): Track usage of variables and
30693 report the errors for not used variables.
30695 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
30698 2001-09-27 Miguel de Icaza <miguel@ximian.com>
30700 * codegen.cs: remove unnneded code
30702 * expression.cs: Removed BuiltinTypeAccess class
30704 Fix the order in which implicit conversions are
30707 The previous fixed dropped support for boxed conversions (adding a
30708 test to the test suite now)
30710 (UserImplicitCast::CanConvert): Remove test for source being null,
30711 that code is broken. We should not feed a null to begin with, if
30712 we do, then we should track the bug where the problem originates
30713 and not try to cover it up here.
30715 Return a resolved expression of type UserImplicitCast on success
30716 rather than true/false. Ravi: this is what I was talking about,
30717 the pattern is to use a static method as a "constructor" for
30720 Also, do not create arguments until the very last minute,
30721 otherwise we always create the arguments even for lookups that
30722 will never be performed.
30724 (UserImplicitCast::Resolve): Eliminate, objects of type
30725 UserImplicitCast are born in a fully resolved state.
30727 * typemanager.cs (InitCoreTypes): Init also value_type
30728 (System.ValueType).
30730 * expression.cs (Cast::Resolve): First resolve the child expression.
30732 (LValue): Add new method AddressOf to be used by
30735 Change the argument of Store to take an EmitContext instead of an
30736 ILGenerator, because things like FieldExpr need to be able to call
30737 their children expression to generate the instance code.
30739 (Expression::Error, Expression::Warning): Sugar functions for
30742 (Expression::MemberLookup): Accept a TypeContainer instead of a
30743 Report as the first argument.
30745 (Expression::ResolvePrimary): Killed. I still want to improve
30746 this as currently the code is just not right.
30748 (Expression::ResolveMemberAccess): Simplify, but it is still
30751 (Unary::Resolve): Catch errors in AddressOf operators.
30753 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
30754 index to a byte for the short-version, or the compiler will choose
30755 the wrong Emit call, which generates the wrong data.
30757 (ParameterReference::Emit, ::Store): same.
30759 (FieldExpr::AddressOf): Implement.
30761 * typemanager.cs: TypeManager: made public variable instead of
30764 * driver.cs: document --fatal.
30766 * report.cs (ErrorMessage, WarningMessage): new names for the old
30767 Error and Warning classes.
30769 * cs-parser.jay (member_access): Turn built-in access to types
30770 into a normal simplename
30772 2001-09-27 Ravi Pratap <ravi@ximian.com>
30774 * expression.cs (Invocation::BetterConversion): Fix to cope
30775 with q being null, since this was introducing a bug.
30777 * expression.cs (ConvertImplicit): Do built-in conversions first.
30779 2001-09-27 Ravi Pratap <ravi@ximian.com>
30781 * expression.cs (UserImplicitCast::Resolve): Fix bug.
30783 2001-09-27 Ravi Pratap <ravi@ximian.com>
30785 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
30786 I had introduced long ago (what's new ?).
30788 * expression.cs (UserImplicitCast::CanConvert): Static method to do
30789 the work of all the checking.
30790 (ConvertImplicit): Call CanConvert and only then create object if necessary.
30791 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
30793 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
30794 that is the right way.
30796 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
30797 overloading resolution. Use everywhere instead of cutting and pasting code.
30799 (Binary::ResolveOperator): Use MakeUnionSet.
30801 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
30802 we have to convert to bool types. Not complete yet.
30804 2001-09-27 Miguel de Icaza <miguel@ximian.com>
30806 * typemanager.cs (TypeManager::CSharpName): support ushort.
30808 * expression.cs (Expression::TryImplicitIntConversion): Attempts
30809 to provide an expression that performsn an implicit constant int
30810 conversion (section 6.1.6).
30811 (Expression::ConvertImplicitRequired): Reworked to include
30812 implicit constant expression conversions.
30814 (Expression::ConvertNumericExplicit): Finished.
30816 (Invocation::Emit): If InstanceExpression is null, then it means
30817 that we perform a call on this.
30819 2001-09-26 Miguel de Icaza <miguel@ximian.com>
30821 * expression.cs (Unary::Emit): Remove some dead code.
30822 (Probe): Implement Resolve and Emit for `is'.
30823 (Expression::ConvertImplicitRequired): Attempt to do constant
30824 expression conversions here. Maybe should be moved to
30825 ConvertImplicit, but I am not sure.
30826 (Expression::ImplicitLongConstantConversionPossible,
30827 Expression::ImplicitIntConstantConversionPossible): New functions
30828 that tell whether is it possible to apply an implicit constant
30829 expression conversion.
30831 (ConvertNumericExplicit): Started work on explicit numeric
30834 * cs-parser.jay: Update operator constants.
30836 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
30837 (Parameters::GetSignature): Hook up VerifyArgs here.
30838 (Parameters::VerifyArgs): Verifies that no two arguments have the
30841 * class.cs (Operator): Update the operator names to reflect the
30842 ones that the spec expects (as we are just stringizing the
30845 * expression.cs (Unary::ResolveOperator): Fix bug: Use
30846 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
30847 previous usage did only work for our methods.
30848 (Expression::ConvertImplicit): Handle decimal implicit numeric
30849 conversions as well.
30850 (Expression::InternalTypeConstructor): Used to invoke constructors
30851 on internal types for default promotions.
30853 (Unary::Emit): Implement special handling for the pre/post
30854 increment/decrement for overloaded operators, as they need to have
30855 the same semantics as the other operators.
30857 (Binary::ResolveOperator): ditto.
30858 (Invocation::ConversionExists): ditto.
30859 (UserImplicitCast::Resolve): ditto.
30861 2001-09-26 Ravi Pratap <ravi@ximian.com>
30863 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
30864 operator, return after emitting body. Regression tests pass again !
30866 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
30867 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
30868 (Invocation::OverloadResolve): Ditto.
30869 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
30871 * everywhere : update calls to the above methods accordingly.
30873 2001-09-26 Miguel de Icaza <miguel@ximian.com>
30875 * assign.cs (Assign): Make it inherit from ExpressionStatement.
30877 * expression.cs (ExpressionStatement): New base class used for
30878 expressions that can appear in statements, so that we can provide
30879 an alternate path to generate expression that do not leave a value
30882 (Expression::Emit, and all the derivatives): We no longer return
30883 whether a value is left on the stack or not. Every expression
30884 after being emitted leaves a single value on the stack.
30886 * codegen.cs (EmitContext::EmitStatementExpression): Use the
30887 facilties of ExpressionStatement if possible.
30889 * cs-parser.jay: Update statement_expression.
30891 2001-09-25 Miguel de Icaza <miguel@ximian.com>
30893 * driver.cs: Change the wording of message
30895 2001-09-25 Ravi Pratap <ravi@ximian.com>
30897 * expression.cs (Binary::ResolveOperator): Had forgottten to set
30898 the type of the expression to the return type of the method if
30899 we have an overloaded operator match ! The regression tests pass again !
30900 (Unary::ResolveOperator): Ditto.
30902 * expression.cs (Invocation::ConversionExists): Correct the member lookup
30903 to find "op_Implicit", not "implicit" ;-)
30904 (UserImplicitCast): New class to take care of user-defined implicit conversions.
30905 (ConvertImplicit, ForceConversion): Take TypeContainer argument
30907 * everywhere : Correct calls to the above accordingly.
30909 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
30910 (ConvertImplicit): Do user-defined conversion if it exists.
30912 2001-09-24 Miguel de Icaza <miguel@ximian.com>
30914 * assign.cs: track location.
30915 (Resolve): Use implicit conversions on assignment.
30917 * literal.cs: Oops. Not good, Emit of short access values should
30918 pass (Bytes) or the wrong argument will be selected.
30920 * expression.cs (Unary::Emit): Emit code for -expr.
30922 (Unary::ResolveOperator): Handle `Substract' for non-constants
30923 (substract from zero from the non-constants).
30924 Deal with Doubles as well.
30926 (Expression::ConvertImplicitRequired): New routine that reports an
30927 error if no implicit conversion exists.
30929 (Invocation::OverloadResolve): Store the converted implicit
30930 expressions if we make them
30932 2001-09-24 Ravi Pratap <ravi@ximian.com>
30934 * class.cs (ConstructorInitializer): Take a Location argument.
30935 (ConstructorBaseInitializer): Same here.
30936 (ConstructorThisInitializer): Same here.
30938 * cs-parser.jay : Update all calls accordingly.
30940 * expression.cs (Unary, Binary, New): Take location argument.
30941 Update accordingly everywhere.
30943 * cs-parser.jay : Update all calls to the above to take a location
30946 * class.cs : Ditto.
30948 2001-09-24 Ravi Pratap <ravi@ximian.com>
30950 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
30951 (Invocation::BetterConversion): Same here
30952 (Invocation::ConversionExists): Ditto.
30954 (Invocation::ConversionExists): Implement.
30956 2001-09-22 Ravi Pratap <ravi@ximian.com>
30958 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
30959 Also take an additional TypeContainer argument.
30961 * All over : Pass in TypeContainer as argument to OverloadResolve.
30963 * typemanager.cs (CSharpName): Update to check for the string type and return
30966 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
30969 2001-09-21 Ravi Pratap <ravi@ximian.com>
30971 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
30972 (Invocation::BetterFunction): Implement.
30973 (Invocation::BetterConversion): Implement.
30974 (Invocation::ConversionExists): Skeleton, no implementation yet.
30976 Okay, things work fine !
30978 2001-09-21 Miguel de Icaza <miguel@ximian.com>
30980 * typemanager.cs: declare and load enum_type, delegate_type and
30983 * expression.cs (Expression::Emit): Now emit returns a value that
30984 tells whether a value is left on the stack or not. This strategy
30985 might be reveted tomorrow with a mechanism that would address
30986 multiple assignments.
30987 (Expression::report118): Utility routine to report mismatches on
30990 (Unary::Report23): Report impossible type/operator combination
30993 (Unary::IsIncrementableNumber): Whether the type can be
30994 incremented or decremented with add.
30995 (Unary::ResolveOperator): Also allow enumerations to be bitwise
30997 (Unary::ResolveOperator): Implement ++, !, ~,
30999 (Invocation::Emit): Deal with new Emit convetion.
31001 * All Expression derivatives: Updated their Emit method to return
31002 whether they leave values on the stack or not.
31004 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31005 stack for expressions that are statements.
31007 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31009 * expression.cs (LValue): New interface. Must be implemented by
31011 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31014 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31015 interface for generating code, simplifies the code.
31017 2001-09-20 Ravi Pratap <ravi@ximian.com>
31019 * expression.cs (everywhere): Comment out return statements in ::Resolve
31020 methods to avoid the warnings.
31022 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31024 * driver.cs (parse): Report error 2001 if we can not open the
31027 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31030 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31033 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31034 otherwise nested blocks end up with the same index.
31036 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31038 * expression.cs: Instead of having FIXMEs in the Resolve
31039 functions, throw exceptions so it is obvious that we are facing a
31042 * cs-parser.jay (invocation_expression): Pass Location information.
31044 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31045 Use a basename for those routines because .NET does not like paths
31048 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31051 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31053 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31054 are loading the correct data types (throws an exception if not).
31055 (TypeManager::InitCoreTypes): Use CoreLookupType
31057 * expression.cs (Unary::ResolveOperator): return the child
31058 expression for expressions which are just +expr.
31059 (Unary::ResolveOperator): Return negative literals for -LITERAL
31060 expressions (otherwise they are Unary {Literal}).
31061 (Invocation::Badness): Take into account `Implicit constant
31062 expression conversions'.
31064 * literal.cs (LongLiteral): Implement long literal class.
31065 (IntLiteral): export the `Value' of the intliteral.
31067 2001-09-19 Ravi Pratap <ravi@ximian.com>
31069 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31071 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31072 instead of 'Operator'
31074 * expression.cs (Binary::ResolveOperator): Update accordingly.
31075 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31078 * cs-parser.jay (unary_expression): Update to use the new names.
31080 * gen-treedump.cs (GetUnary): Same here.
31082 * expression.cs (Unary::Resolve): Implement.
31083 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31084 operators are found instead of making noise ;-)
31085 (Unary::ResolveOperator): New method to do precisely the same thing which
31086 Binary::ResolveOperator does for Binary expressions.
31087 (Unary.method, .Arguments): Add.
31088 (Unary::OperName): Implement.
31089 (Unary::ForceConversion): Copy and Paste !
31091 * class.cs (Operator::Define): Fix a small bug for the case when we have
31094 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31095 for the inbuilt operators. Only overloading works for now ;-)
31097 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31099 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31100 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31102 * expression.cs (This::Emit): Implement.
31103 (This::Resolve): Implement.
31104 (TypeOf:Resolve): Implement.
31105 (Expression::ResolveSimpleName): Add an implicit this to instance
31107 (MemberAccess::Resolve): Deal with Parameters and Fields.
31108 Bind instance variable to Field expressions.
31109 (FieldExpr::Instance): New field used to track the expression that
31110 represents the object instance.
31111 (FieldExpr::Resolve): Track potential errors from MemberLookup not
31113 (FieldExpr::Emit): Implement.
31115 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
31116 the last instruction contains a return opcode to avoid generating
31117 the last `ret' instruction (this generates correct code, and it is
31118 nice to pass the peverify output).
31120 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
31121 initializer for static and instance variables.
31122 (Constructor::Emit): Allow initializer to be null in the case of
31123 static constructors. Only emit initializer for instance
31126 (TypeContainer::FindMembers): Return a null array if there are no
31129 Also fix the code for the MemberTypes.Method branch, as it was not
31130 scanning that for operators (or tried to access null variables before).
31132 * assign.cs (Assign::Emit): Handle instance and static fields.
31136 * driver.cs: Stop compilation if there are parse errors.
31138 * cs-parser.jay (constructor_declaration): Provide default base
31139 initializer for non-static constructors.
31140 (constructor_declarator): Do not provide a default base
31141 initializers if none was specified.
31142 Catch the fact that constructors should not have parameters.
31144 * class.cs: Do not emit parent class initializers for static
31145 constructors, that should be flagged as an error.
31147 2001-09-18 Ravi Pratap <ravi@ximian.com>
31149 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
31150 Move back code into TypeContainer::Populate.
31152 2001-09-18 Ravi Pratap <ravi@ximian.com>
31154 * class.cs (TypeContainer::AddConstructor): Fix the check to
31155 compare against Name, not Basename.
31156 (Operator::OpType): Change Plus and Minus to Add and Subtract.
31158 * cs-parser.jay : Update accordingly.
31160 * class.cs (TypeContainer::FindMembers): For the case where we are searching
31161 for methods, don't forget to look into the operators too.
31162 (RegisterMethodBuilder): Helper method to take care of this for
31163 methods, constructors and operators.
31164 (Operator::Define): Completely revamp.
31165 (Operator.OperatorMethod, MethodName): New fields.
31166 (TypeContainer::Populate): Move the registering of builders into
31167 RegisterMethodBuilder.
31168 (Operator::Emit): Re-write.
31170 * expression.cs (Binary::Emit): Comment out code path to emit method
31171 invocation stuff for the case when we have a user defined operator. I am
31172 just not able to get it right !
31174 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31176 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
31179 (Expression::MemberLookup): Provide a version that allows to
31180 specify the MemberTypes and BindingFlags.
31182 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
31183 so it was not fetching variable information from outer blocks.
31185 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
31186 Beforefieldinit as it was buggy.
31188 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
31189 that Ravi put here.
31191 * class.cs (Constructor::Emit): Only emit if block is not null.
31192 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
31193 deal with this by semantically definining it as if the user had
31196 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
31197 constructors as we now "emit" them at a higher level.
31199 (TypeContainer::DefineDefaultConstructor): Used to define the
31200 default constructors if none was provided.
31202 (ConstructorInitializer): Add methods Resolve and Emit.
31204 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
31206 2001-09-17 Ravi Pratap <ravi@ximian.com>
31208 * class.cs (TypeContainer::EmitDefaultConstructor): Register
31209 the default constructor builder with our hashtable for methodbuilders
31212 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
31213 and argument_count is 0 in which case we have a match.
31214 (Binary::ResolveOperator): More null checking and miscellaneous coding
31217 2001-09-17 Ravi Pratap <ravi@ximian.com>
31219 * rootcontext.cs (IsNameSpace): Compare against null.
31221 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
31223 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
31224 and Unary::Operator.
31226 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
31229 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
31230 we have overloaded operators.
31231 (Binary::ResolveOperator): Implement the part which does the operator overload
31234 * class.cs (Operator::Emit): Implement.
31235 (TypeContainer::Emit): Emit the operators we have too.
31237 * expression.cs (Binary::Emit): Update to emit the appropriate code for
31238 the case when we have a user-defined operator.
31240 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31242 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
31244 2001-09-16 Ravi Pratap <ravi@ximian.com>
31246 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
31247 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
31248 (Constructor::Emit): Implement.
31249 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
31250 if we have no work to do.
31251 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
31254 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
31255 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
31257 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
31260 2001-09-15 Ravi Pratap <ravi@ximian.com>
31262 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
31264 (Tree::RecordNamespace): Method to do what the name says ;-)
31265 (Tree::Namespaces): Property to get at the namespaces hashtable.
31267 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
31270 * rootcontext.cs (IsNamespace): Fixed it :-)
31272 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31274 * class.cs (TypeContainer::FindMembers): Add support for
31276 (MethodCore): New class that encapsulates both the shared aspects
31277 of a Constructor and a Method.
31278 (Method, Constructor): Factored pieces into MethodCore.
31280 * driver.cs: Added --fatal which makes errors throw exceptions.
31281 Load System assembly as well as part of the standard library.
31283 * report.cs: Allow throwing exceptions on errors for debugging.
31285 * modifiers.cs: Do not use `parent', instead use the real type
31286 container to evaluate permission settings.
31288 * class.cs: Put Ravi's patch back in. He is right, and we will
31289 have to cope with the
31291 2001-09-14 Ravi Pratap <ravi@ximian.com>
31293 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
31294 FamORAssem, not FamANDAssem.
31296 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31298 * driver.cs: Added --parse option that only parses its input files
31301 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
31302 incorrect. IsTopLevel is not used to tell whether an object is
31303 root_types or not (that can be achieved by testing this ==
31304 root_types). But to see if this is a top-level *class* (not
31305 necessarly our "toplevel" container).
31307 2001-09-14 Ravi Pratap <ravi@ximian.com>
31309 * enum.cs (Enum::Define): Modify to call the Lookup method on the
31310 parent instead of a direct call to GetType.
31312 2001-09-14 Ravi Pratap <ravi@ximian.com>
31314 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
31315 Modifiers.TypeAttr. This should just be a call to that method.
31317 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
31318 object so that we can determine if we are top-level or not.
31320 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
31323 * enum.cs (Enum::Define): Ditto.
31325 * modifiers.cs (FieldAttr): Re-write.
31327 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
31328 (TypeContainer::HaveStaticConstructor): New property to provide access
31329 to precisely that info.
31331 * modifiers.cs (MethodAttr): Re-write.
31332 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
31334 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
31335 of top-level types as claimed.
31337 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31339 * expression.cs (MemberLookup): Fruitless attempt to lookup
31340 constructors. Maybe I need to emit default constructors? That
31341 might be it (currently .NET emits this for me automatically).
31342 (Invocation::OverloadResolve): Cope with Arguments == null.
31343 (Invocation::EmitArguments): new function, shared by the new
31344 constructor and us.
31345 (Invocation::Emit): Handle static and instance methods. Emit
31346 proper call instruction for virtual or non-virtual invocations.
31347 (New::Emit): Implement.
31348 (New::Resolve): Implement.
31349 (MemberAccess:Resolve): Implement.
31350 (MethodGroupExpr::InstanceExpression): used conforming to the spec
31351 to track instances.
31352 (FieldExpr::Resolve): Set type.
31354 * support.cs: Handle empty arguments.
31356 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
31357 SimpleLookup): Auxiliary routines to help parse a qualifier
31360 Update qualifier_identifier rule.
31362 * codegen.cs: Removed debugging messages.
31364 * class.cs: Make this a global thing, this acts just as a "key" to
31365 objects that we might have around.
31367 (Populate): Only initialize method_builders_to_methods once.
31369 * expression.cs (PropertyExpr): Initialize type from the
31372 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
31373 Resolve pattern. Attempt to implicitly convert value to boolean.
31376 * expression.cs: Set the type for the int32/int32 argument case.
31377 (Binary::ResolveOperator): Set the return type to boolean for
31378 comparission operators
31380 * typemanager.cs: Remove debugging print code.
31382 (Invocation::Resolve): resolve type.
31384 * class.cs: Allocate a MemberInfo of the correct size, as the code
31385 elsewhere depends on the test to reflect the correct contents.
31387 (Method::) Keep track of parameters, due to System.Reflection holes
31389 (TypeContainer::Populate): Keep track of MethodBuilders to Method
31392 (TypeContainer::FindMembers): Use ArrayList and then copy an array
31393 of the exact size and return that.
31395 (Class::LookupMethodByBuilder): New function that maps
31396 MethodBuilders to its methods. Required to locate the information
31397 on methods because System.Reflection bit us again.
31399 * support.cs: New file, contains an interface ParameterData and
31400 two implementations: ReflectionParameters and InternalParameters
31401 used to access Parameter information. We will need to grow this
31404 * expression.cs (Invocation::GetParameterData): implement a cache
31405 and a wrapper around the ParameterData creation for methods.
31406 (Invocation::OverloadResolve): Use new code.
31408 2001-09-13 Ravi Pratap <ravi@ximian.com>
31410 * class.cs (TypeContainer::EmitField): Remove and move into
31411 (Field::Define): here and modify accordingly.
31412 (Field.FieldBuilder): New member.
31413 (TypeContainer::Populate): Update accordingly.
31414 (TypeContainer::FindMembers): Implement.
31416 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31418 * statement.cs: (VariableInfo::VariableType): New field to be
31419 initialized with the full type once it is resolved.
31421 2001-09-12 Miguel de Icaza <miguel@ximian.com>
31423 * parameter.cs (GetParameterInfo): Use a type cache to compute
31424 things only once, and to reuse this information
31426 * expression.cs (LocalVariableReference::Emit): Implement.
31427 (OpcodeCast::Emit): fix.
31429 (ParameterReference::Resolve): Implement.
31430 (ParameterReference::Emit): Implement.
31432 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
31433 that are expressions need to stay as Expressions.
31435 * typemanager.cs (CSharpName): Returns the C# name of a type if
31438 * expression.cs (Expression::ConvertImplicit): New function that
31439 implements implicit type conversions.
31441 (Expression::ImplicitReferenceConversion): Implements implicit
31442 reference conversions.
31444 (EmptyCast): New type for transparent casts.
31446 (OpcodeCast): New type for casts of types that are performed with
31447 a sequence of bytecodes.
31449 (BoxedCast): New type used for casting value types into reference
31450 types. Emits a box opcode.
31452 (Binary::DoNumericPromotions): Implements numeric promotions of
31453 and computation of the Binary::Type.
31455 (Binary::EmitBranchable): Optimization.
31457 (Binary::Emit): Implement code emission for expressions.
31459 * typemanager.cs (TypeManager): Added two new core types: sbyte
31462 2001-09-12 Ravi Pratap <ravi@ximian.com>
31464 * class.cs (TypeContainer::FindMembers): Method which does exactly
31465 what Type.FindMembers does, only we don't have to use reflection. No
31466 implementation yet.
31468 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
31469 typecontainer objects as we need to get at them.
31470 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
31472 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
31473 typecontainer object.
31475 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
31476 of just a Report object.
31478 2001-09-11 Ravi Pratap <ravi@ximian.com>
31480 * class.cs (Event::Define): Go back to using the prefixes "add_" and
31482 (TypeContainer::Populate): Now define the delegates of the type too.
31483 (TypeContainer.Delegates): Property to access the list of delegates defined
31486 * delegates.cs (Delegate::Define): Implement partially.
31488 * modifiers.cs (TypeAttr): Handle more flags.
31490 2001-09-11 Ravi Pratap <ravi@ximian.com>
31492 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
31494 (Operator::Define): Re-write logic to get types by using the LookupType method
31495 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
31496 (Indexer::Define): Ditto.
31497 (Event::Define): Ditto.
31498 (Property::Define): Ditto.
31500 2001-09-10 Ravi Pratap <ravi@ximian.com>
31502 * class.cs (TypeContainer::Populate): Now define operators too.
31503 (TypeContainer.Operators): New property to access the list of operators
31505 (Operator.OperatorMethodBuilder): New member to hold the method builder
31506 for the operator we are defining.
31507 (Operator::Define): Implement.
31509 2001-09-10 Ravi Pratap <ravi@ximian.com>
31511 * class.cs (Event::Define): Make the prefixes of the accessor methods
31512 addOn_ and removeOn_
31514 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
31515 of the location being passed in too. Ideally, this should go later since all
31516 error reporting should be done through the Report object.
31518 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
31519 (Populate): Iterate thru the indexers we have and define them too.
31520 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
31521 for the get and set accessors.
31522 (Indexer::Define): Implement.
31524 2001-09-09 Miguel de Icaza <miguel@ximian.com>
31526 * expression.cs (Binary::Resolve): Beginning of it. I scratched
31527 my previous implementation, did not work.
31529 * typemanager.cs: Add a couple of missing types (the longs).
31531 * literal.cs: Use TypeManager.bool_type instead of getting it.
31533 * expression.cs (EventExpr): New kind of expressions.
31534 (Expressio::ExprClassFromMemberInfo): finish
31536 2001-09-08 Miguel de Icaza <miguel@ximian.com>
31538 * assign.cs: Emit stores to static fields differently.
31540 2001-09-08 Ravi Pratap <ravi@ximian.com>
31542 * Merge in changes and adjust code to tackle conflicts. Backed out my
31543 code in Assign::Resolve ;-)
31545 2001-09-08 Ravi Pratap <ravi@ximian.com>
31547 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
31548 instead Report.Error and also pass in the location.
31549 (CSharpParser::Lexer): New readonly property to return the reference
31550 to the Tokenizer object.
31551 (declare_local_variables): Use Report.Error with location instead of plain
31555 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
31556 (Operator.CheckBinaryOperator): Ditto.
31558 * cs-parser.jay (operator_declarator): Update accordingly.
31560 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
31561 (CheckBinaryOperator): Same here.
31563 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
31564 on the name without any prefixes of namespace names etc. This is because we
31565 already might have something already fully qualified like
31566 'System.Console.WriteLine'
31568 * assign.cs (Resolve): Begin implementation. Stuck ;-)
31570 2001-09-07 Ravi Pratap <ravi@ximian.com>
31572 * cs-tokenizer.cs (location): Return a string which also contains
31575 * expression.cs (ElementAccess): New class for expressions of the
31576 type 'element access.'
31577 (BaseAccess): New class for expressions of the type 'base access.'
31578 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
31581 * cs-parser.jay (element_access): Implement action.
31582 (base_access): Implement actions.
31583 (checked_expression, unchecked_expression): Implement.
31585 * cs-parser.jay (local_variable_type): Correct and implement.
31586 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
31588 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
31590 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
31591 name and the specifiers.
31593 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
31595 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
31596 making them all public ;-)
31598 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
31601 2001-09-07 Miguel de Icaza <miguel@ximian.com>
31603 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
31605 (FieldExpr, PropertyExprs): New resolved expressions.
31606 (SimpleName::MemberStaticCheck): Perform static checks for access
31607 to non-static fields on static methods. Maybe this should be
31608 generalized for MemberAccesses.
31609 (SimpleName::ResolveSimpleName): More work on simple name
31612 * cs-parser.jay (primary_expression/qualified_identifier): track
31613 the parameter index.
31615 * codegen.cs (CodeGen::Save): Catch save exception, report error.
31616 (EmitContext::EmitBoolExpression): Chain to expression generation
31617 instead of temporary hack.
31618 (::EmitStatementExpression): Put generic expression code generation.
31620 * assign.cs (Assign::Emit): Implement variable assignments to
31621 local variables, parameters and fields.
31623 2001-09-06 Miguel de Icaza <miguel@ximian.com>
31625 * statement.cs (Block::GetVariableInfo): New method, returns the
31626 VariableInfo for a variable name in a block.
31627 (Block::GetVariableType): Implement in terms of GetVariableInfo
31629 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
31630 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
31632 2001-09-06 Ravi Pratap <ravi@ximian.com>
31634 * cs-parser.jay (operator_declaration): Continue on my quest : update
31635 to take attributes argument.
31636 (event_declaration): Ditto.
31637 (enum_declaration): Ditto.
31638 (indexer_declaration): Ditto.
31640 * class.cs (Operator::Operator): Update constructor accordingly.
31641 (Event::Event): Ditto.
31643 * delegate.cs (Delegate::Delegate): Same here.
31645 * enum.cs (Enum::Enum): Same here.
31647 2001-09-05 Ravi Pratap <ravi@ximian.com>
31649 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
31651 * ../tests/cs0658.cs : New file to demonstrate error 0658.
31653 * attribute.cs (Attributes): New class to encapsulate all attributes which were
31654 being passed around as an arraylist.
31655 (Attributes::AddAttribute): Method to add attribute sections.
31657 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
31658 (struct_declaration): Update accordingly.
31659 (constant_declaration): Update.
31660 (field_declaration): Update.
31661 (method_header): Update.
31662 (fixed_parameter): Update.
31663 (parameter_array): Ditto.
31664 (property_declaration): Ditto.
31665 (destructor_declaration): Ditto.
31667 * class.cs (Struct::Struct): Update constructors accordingly.
31668 (Class::Class): Ditto.
31669 (Field::Field): Ditto.
31670 (Method::Method): Ditto.
31671 (Property::Property): Ditto.
31672 (TypeContainer::OptAttribute): update property's return type.
31674 * interface.cs (Interface.opt_attributes): New member.
31675 (Interface::Interface): Update to take the extra Attributes argument.
31677 * parameter.cs (Parameter::Parameter): Ditto.
31679 * constant.cs (Constant::Constant): Ditto.
31681 * interface.cs (InterfaceMemberBase): New OptAttributes field.
31682 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
31683 the attributes as a parameter.
31684 (InterfaceProperty): Update constructor call.
31685 (InterfaceEvent): Ditto.
31686 (InterfaceMethod): Ditto.
31687 (InterfaceIndexer): Ditto.
31689 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
31690 pass the attributes too.
31691 (interface_event_declaration): Ditto.
31692 (interface_property_declaration): Ditto.
31693 (interface_method_declaration): Ditto.
31694 (interface_declaration): Ditto.
31696 2001-09-05 Miguel de Icaza <miguel@ximian.com>
31698 * class.cs (Method::Define): Track the "static Main" definition to
31699 create an entry point.
31701 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
31702 EntryPoint if we find it.
31704 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
31705 (EmitContext::ig): Make this variable public.
31707 * driver.cs: Make the default output file be the first file name
31708 with the .exe extension.
31710 Detect empty compilations
31712 Handle various kinds of output targets. Handle --target and
31713 rename -t to --dumper.
31715 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
31716 methods inherited from Expression return now an Expression. This
31717 will is used during the tree rewriting as we resolve them during
31720 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
31721 the spec. Missing entirely is the information about
31722 accessability of elements of it.
31724 (Expression::ExprClassFromMemberInfo): New constructor for
31725 Expressions that creates a fully initialized Expression based on
31726 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
31729 (Invocation::Resolve): Begin implementing resolution of invocations.
31731 * literal.cs (StringLiteral): Implement Emit.
31733 2001-09-05 Ravi Pratap <ravi@ximian.com>
31735 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
31738 2001-09-04 Ravi Pratap <ravi@ximian.com>
31740 * cs-parser.jay (attribute_arguments): Implement actions.
31741 (attribute): Fix bug in production. Implement action.
31742 (attribute_list): Implement.
31743 (attribute_target): Implement.
31744 (attribute_target_specifier, opt_target_specifier): Implement
31745 (CheckAttributeTarget): New method to check if the attribute target
31747 (attribute_section): Implement.
31748 (opt_attributes): Implement.
31750 * attribute.cs : New file to handle attributes.
31751 (Attribute): Class to hold attribute info.
31753 * cs-parser.jay (opt_attribute_target_specifier): Remove production
31754 (attribute_section): Modify production to use 2 different rules to
31755 achieve the same thing. 1 s/r conflict down !
31756 Clean out commented, useless, non-reducing dimension_separator rules.
31758 * class.cs (TypeContainer.attributes): New member to hold list
31759 of attributes for a type.
31760 (Struct::Struct): Modify to take one more argument, the attribute list.
31761 (Class::Class): Ditto.
31762 (Field::Field): Ditto.
31763 (Method::Method): Ditto.
31764 (Property::Property): Ditto.
31766 * cs-parser.jay (struct_declaration): Update constructor call to
31767 pass in the attributes too.
31768 (class_declaration): Ditto.
31769 (constant_declaration): Ditto.
31770 (field_declaration): Ditto.
31771 (method_header): Ditto.
31772 (fixed_parameter): Ditto.
31773 (parameter_array): Ditto.
31774 (property_declaration): Ditto.
31776 * constant.cs (Constant::Constant): Update constructor similarly.
31777 Use System.Collections.
31779 * parameter.cs (Parameter::Parameter): Update as above.
31781 2001-09-02 Ravi Pratap <ravi@ximian.com>
31783 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
31784 (TypeContainer.delegates): New member to hold list of delegates.
31786 * cs-parser.jay (delegate_declaration): Implement the action correctly
31787 this time as I seem to be on crack ;-)
31789 2001-09-02 Miguel de Icaza <miguel@ximian.com>
31791 * rootcontext.cs (RootContext::IsNamespace): new function, used to
31792 tell whether an identifier represents a namespace.
31794 * expression.cs (NamespaceExpr): A namespace expression, used only
31795 temporarly during expression resolution.
31796 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
31797 utility functions to resolve names on expressions.
31799 2001-09-01 Miguel de Icaza <miguel@ximian.com>
31801 * codegen.cs: Add hook for StatementExpressions.
31803 * class.cs: Fix inverted test for static flag in methods.
31805 2001-09-02 Ravi Pratap <ravi@ximian.com>
31807 * class.cs (Operator::CheckUnaryOperator): Correct error number used
31808 to make it coincide with MS' number.
31809 (Operator::CheckBinaryOperator): Ditto.
31811 * ../errors/errors.txt : Remove error numbers added earlier.
31813 * ../errors/cs1019.cs : Test case for error # 1019
31815 * ../errros/cs1020.cs : Test case for error # 1020
31817 * cs-parser.jay : Clean out commented cruft.
31818 (dimension_separators, dimension_separator): Comment out. Ostensibly not
31819 used anywhere - non-reducing rule.
31820 (namespace_declarations): Non-reducing rule - comment out.
31822 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
31823 with TypeContainer::AddEnum.
31825 * delegate.cs : New file for delegate handling classes.
31826 (Delegate): Class for declaring delegates.
31828 * makefile : Update.
31830 * cs-parser.jay (delegate_declaration): Implement.
31832 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
31834 * class.cs (Event::Define): Implement.
31835 (Event.EventBuilder): New member.
31837 * class.cs (TypeContainer::Populate): Update to define all enums and events
31839 (Events): New property for the events arraylist we hold. Shouldn't we move to using
31840 readonly fields for all these cases ?
31842 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
31844 * class.cs (Property): Revamp to use the convention of making fields readonly.
31845 Accordingly modify code elsewhere.
31847 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
31848 the Define method of the Property class.
31850 * class.cs : Clean up applied patch and update references to variables etc. Fix
31852 (TypeContainer::Populate): Update to define all the properties we have. Also
31853 define all enumerations.
31855 * enum.cs (Define): Implement.
31857 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
31859 * cs-parser.jay (overloadable_operator): The semantic value is an
31860 enum of the Operator class.
31861 (operator_declarator): Implement actions.
31862 (operator_declaration): Implement.
31864 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
31865 validity of definitions.
31866 (Operator::CheckBinaryOperator): Static method to check for binary operators
31867 (TypeContainer::AddOperator): New method to add an operator to a type.
31869 * cs-parser.jay (indexer_declaration): Added line to actually call the
31870 AddIndexer method so it gets added ;-)
31872 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
31873 already taken care of by the MS compiler ?
31875 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
31877 * class.cs (Operator): New class for operator declarations.
31878 (Operator::OpType): Enum for the various operators.
31880 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
31882 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
31883 ostensibly handle this in semantic analysis.
31885 * cs-parser.jay (general_catch_clause): Comment out
31886 (specific_catch_clauses, specific_catch_clause): Ditto.
31887 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
31888 (catch_args, opt_catch_args): New productions.
31889 (catch_clause): Rewrite to use the new productions above
31890 (catch_clauses): Modify accordingly.
31891 (opt_catch_clauses): New production to use in try_statement
31892 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
31893 and re-write the code in the actions to extract the specific and
31894 general catch clauses by being a little smart ;-)
31896 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
31897 Hooray, try and catch statements parse fine !
31899 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
31901 * statement.cs (Block::GetVariableType): Fix logic to extract the type
31902 string from the hashtable of variables.
31904 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
31905 I end up making that mistake ;-)
31906 (catch_clauses): Fixed gross error which made Key and Value of the
31907 DictionaryEntry the same : $1 !!
31909 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
31911 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
31913 * cs-parser.jay (event_declaration): Correct to remove the semicolon
31914 when the add and remove accessors are specified.
31916 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
31918 * cs-parser.jay (IndexerDeclaration): New helper class to hold
31919 information about indexer_declarator.
31920 (indexer_declarator): Implement actions.
31921 (parsing_indexer): New local boolean used to keep track of whether
31922 we are parsing indexers or properties. This is necessary because
31923 implicit_parameters come into picture even for the get accessor in the
31924 case of an indexer.
31925 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
31927 * class.cs (Indexer): New class for indexer declarations.
31928 (TypeContainer::AddIndexer): New method to add an indexer to a type.
31929 (TypeContainer::indexers): New member to hold list of indexers for the
31932 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
31934 * cs-parser.jay (add_accessor_declaration): Implement action.
31935 (remove_accessor_declaration): Implement action.
31936 (event_accessors_declaration): Implement
31937 (variable_declarators): swap statements for first rule - trivial.
31939 * class.cs (Event): New class to hold information about event
31941 (TypeContainer::AddEvent): New method to add an event to a type
31942 (TypeContainer::events): New member to hold list of events.
31944 * cs-parser.jay (event_declaration): Implement actions.
31946 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
31948 * cs-parser.jay (dim_separators): Implement. Make it a string
31949 concatenating all the commas together, just as they appear.
31950 (opt_dim_separators): Modify accordingly
31951 (rank_specifiers): Update accordingly. Basically do the same
31952 thing - instead, collect the brackets here.
31953 (opt_rank_sepcifiers): Modify accordingly.
31954 (array_type): Modify to actually return the complete type string
31955 instead of ignoring the rank_specifiers.
31956 (expression_list): Implement to collect the expressions
31957 (variable_initializer): Implement. We make it a list of expressions
31958 essentially so that we can handle the array_initializer case neatly too.
31959 (variable_initializer_list): Implement.
31960 (array_initializer): Make it a list of variable_initializers
31961 (opt_array_initializer): Modify accordingly.
31963 * expression.cs (New::NType): Add enumeration to help us
31964 keep track of whether we have an object/delegate creation
31965 or an array creation.
31966 (New:NewType, New::Rank, New::Indices, New::Initializers): New
31967 members to hold data about array creation.
31968 (New:New): Modify to update NewType
31969 (New:New): New Overloaded contructor for the array creation
31972 * cs-parser.jay (array_creation_expression): Implement to call
31973 the overloaded New constructor.
31975 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
31977 * class.cs (TypeContainer::Constructors): Return member
31978 constructors instead of returning null.
31980 2001-08-26 Miguel de Icaza <miguel@ximian.com>
31982 * typemanager.cs (InitCoreTypes): Initialize the various core
31983 types after we have populated the type manager with the user
31984 defined types (this distinction will be important later while
31985 compiling corlib.dll)
31987 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
31988 on Expression Classification. Now all expressions have a method
31989 `Resolve' and a method `Emit'.
31991 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
31992 generation from working. Also add some temporary debugging
31995 2001-08-24 Miguel de Icaza <miguel@ximian.com>
31997 * codegen.cs: Lots of code generation pieces. This is only the
31998 beginning, will continue tomorrow with more touches of polish. We
31999 handle the fundamentals of if, while, do, for, return. Others are
32000 trickier and I need to start working on invocations soon.
32002 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32005 * codegen.cs (EmitContext): New struct, used during code
32006 emission to keep a context. Most of the code generation will be
32009 * cs-parser.jay: Add embedded blocks to the list of statements of
32010 this block. So code generation proceeds in a top down fashion.
32012 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32014 * statement.cs: Add support for multiple child blocks.
32016 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32018 * codegen.cs (EmitCode): New function, will emit the code for a
32019 Block of code given a TypeContainer and its ILGenerator.
32021 * statement.cs (Block): Standard public readonly optimization.
32022 (Block::Block constructors): Link children.
32023 (Block::Child): Child Linker.
32024 (Block::EmitVariables): Emits IL variable declarations.
32026 * class.cs: Drop support for MethodGroups here, delay until
32028 (Method::): Applied the same simplification that I did before, and
32029 move from Properties to public readonly fields.
32030 (Method::ParameterTypes): Returns the parameter types for the
32031 function, and implements a cache that will be useful later when I
32032 do error checking and the semantic analysis on the methods is
32034 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32035 and made a method, optional argument tells whether this is a class
32036 or a structure to apply the `has-this' bit.
32037 (Method::GetCallingConvention): Implement, returns the calling
32039 (Method::Define): Defines the type, a second pass is performed
32040 later to populate the methods.
32042 (Constructor::ParameterTypes): implement a cache similar to the
32043 one on Method::ParameterTypes, useful later when we do semantic
32046 (TypeContainer::EmitMethod): New method. Emits methods.
32048 * expression.cs: Removed MethodGroup class from here.
32050 * parameter.cs (Parameters::GetCallingConvention): new method.
32052 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32054 * class.cs (TypeContainer::Populate): Drop RootContext from the
32057 (Constructor::CallingConvention): Returns the calling convention.
32058 (Constructor::ParameterTypes): Returns the constructor parameter
32061 (TypeContainer::AddConstructor): Keep track of default constructor
32062 and the default static constructor.
32064 (Constructor::) Another class that starts using `public readonly'
32065 instead of properties.
32067 (Constructor::IsDefault): Whether this is a default constructor.
32069 (Field::) use readonly public fields instead of properties also.
32071 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32072 track of static constructors; If none is used, turn on
32073 BeforeFieldInit in the TypeAttributes.
32075 * cs-parser.jay (opt_argument_list): now the return can be null
32076 for the cases where there are no arguments.
32078 (constructor_declarator): If there is no implicit `base' or
32079 `this', then invoke the default parent constructor.
32081 * modifiers.cs (MethodAttr): New static function maps a set of
32082 modifiers flags into a MethodAttributes enum
32083 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32084 MethodAttr, TypeAttr to represent the various mappings where the
32085 modifiers are used.
32086 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32088 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32090 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32093 * interface.cs (PopulateIndexer): Implemented the code generator
32094 for interface indexers.
32096 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32098 * interface.cs (InterfaceMemberBase): Now we track the new status
32101 (PopulateProperty): Implement property population. Woohoo! Got
32102 Methods and Properties going today.
32104 Removed all the properties for interfaces, and replaced them with
32105 `public readonly' fields.
32107 2001-08-16 Miguel de Icaza <miguel@ximian.com>
32109 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
32110 initialize their hashtables/arraylists only when they are needed
32111 instead of doing this always.
32113 * parameter.cs: Handle refs and out parameters.
32115 * cs-parser.jay: Use an ArrayList to construct the arguments
32116 instead of the ParameterCollection, and then cast that to a
32119 * parameter.cs: Drop the use of ParameterCollection and use
32120 instead arrays of Parameters.
32122 (GetParameterInfo): Use the Type, not the Name when resolving
32125 2001-08-13 Miguel de Icaza <miguel@ximian.com>
32127 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
32128 and instead use public readonly fields.
32130 * class.cs: Put back walking code for type containers.
32132 2001-08-11 Miguel de Icaza <miguel@ximian.com>
32134 * class.cs (MakeConstant): Code to define constants.
32136 * rootcontext.cs (LookupType): New function. Used to locate types
32139 2001-08-08 Miguel de Icaza <miguel@ximian.com>
32141 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
32142 this System.Reflection code is. Kudos to Microsoft
32144 * typemanager.cs: Implement a type cache and avoid loading all
32145 types at boot time. Wrap in LookupType the internals. This made
32146 the compiler so much faster. Wow. I rule!
32148 * driver.cs: Make sure we always load mscorlib first (for
32149 debugging purposes, nothing really important).
32151 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
32152 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
32154 * rootcontext.cs: Lookup types on their namespace; Lookup types
32155 on namespaces that have been imported using the `using' keyword.
32157 * class.cs (TypeContainer::TypeAttr): Virtualize.
32158 (Class::TypeAttr): Return attributes suitable for this bad boy.
32159 (Struct::TypeAttr): ditto.
32160 Handle nested classes.
32161 (TypeContainer::) Remove all the type visiting code, it is now
32162 replaced with the rootcontext.cs code
32164 * rootcontext.cs (GetClassBases): Added support for structs.
32166 2001-08-06 Miguel de Icaza <miguel@ximian.com>
32168 * interface.cs, statement.cs, class.cs, parameter.cs,
32169 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
32170 Drop use of TypeRefs, and use strings instead.
32172 2001-08-04 Miguel de Icaza <miguel@ximian.com>
32176 * class.cs (Struct::Struct): set the SEALED flags after
32177 checking the modifiers.
32178 (TypeContainer::TypeAttr): new property, returns the
32179 TypeAttributes for a class.
32181 * cs-parser.jay (type_list): Oops, list production was creating a
32182 new list of base types.
32184 * rootcontext.cs (StdLib): New property.
32185 (GetInterfaceTypeByName): returns an interface by type name, and
32186 encapsulates error handling here.
32187 (GetInterfaces): simplified.
32188 (ResolveTree): Encapsulated all the tree resolution here.
32189 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
32192 * driver.cs: Add support for --nostdlib, to avoid loading the
32193 default assemblies.
32194 (Main): Do not put tree resolution here.
32196 * rootcontext.cs: Beginning of the class resolution.
32198 2001-08-03 Miguel de Icaza <miguel@ximian.com>
32200 * rootcontext.cs: Provide better error reporting.
32202 * cs-parser.jay (interface_base): set our $$ to be interfaces.
32204 * rootcontext.cs (CreateInterface): Handle the case where there
32205 are no parent interfaces.
32207 (CloseTypes): Routine to flush types at the end.
32208 (CreateInterface): Track types.
32209 (GetInterfaces): Returns an array of Types from the list of
32210 defined interfaces.
32212 * typemanager.c (AddUserType): Mechanism to track user types (puts
32213 the type on the global type hash, and allows us to close it at the
32216 2001-08-02 Miguel de Icaza <miguel@ximian.com>
32218 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
32219 RecordInterface instead.
32221 * cs-parser.jay: Updated to reflect changes above.
32223 * decl.cs (Definition): Keep track of the TypeBuilder type that
32224 represents this type here. Not sure we will use it in the long
32225 run, but wont hurt for now.
32227 * driver.cs: Smaller changes to accomodate the new code.
32229 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
32232 * rootcontext.cs (CreateInterface): New method, used to create
32233 the System.TypeBuilder type for interfaces.
32234 (ResolveInterfaces): new entry point to resolve the interface
32236 (CodeGen): Property, used to keep track of the code generator.
32238 2001-07-26 Miguel de Icaza <miguel@ximian.com>
32240 * cs-parser.jay: Add a second production for delegate_declaration
32243 (enum_body): Put an opt_comma here instead of putting it on
32244 enum_body or enum_member_declarations so we can handle trailing
32245 commas on enumeration members. Gets rid of a shift/reduce.
32247 (type_list): Need a COMMA in the middle.
32249 (indexer_declaration): Tell tokenizer to recognize get/set
32251 * Remove old targets.
32253 * Re-add the parser target.
32255 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32257 * cs-parser.jay: Add precendence rules for a number of operators
32258 ot reduce the number of shift/reduce conflicts in the grammar.
32260 2001-07-17 Miguel de Icaza <miguel@ximian.com>
32262 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
32265 Get rid of old crufty code.
32267 * rootcontext.cs: Use this to keep track of the parsed
32268 representation and the defined types available to the program.
32270 * gen-treedump.cs: adjust for new convention.
32272 * type.cs: Split out the type manager, and the assembly builder
32275 * typemanager.cs: the type manager will live here now.
32277 * cil-codegen.cs: And the code generator here.
32279 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
32281 * makefile: Fixed up for easy making.
32283 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32285 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
32288 (unary_expression): Expand pre_increment_expression and
32289 post_decrement_expression to reduce a shift/reduce.
32291 2001-07-11 Simon Cozens
32293 * cs-tokenizer.cs: Hex numbers should begin with a 0.
32295 Improve allow_keyword_as_indent name.
32297 2001-06-19 Miguel de Icaza <miguel@ximian.com>
32299 * Adjustments for Beta2.
32301 2001-06-13 Miguel de Icaza <miguel@ximian.com>
32303 * decl.cs: Added `Define' abstract method.
32304 (InTransit): new property, used to catch recursive definitions.
32306 * interface.cs: Implement `Define'.
32308 * modifiers.cs: Map Modifiers.constants to
32309 System.Reflection.TypeAttribute flags.
32311 * class.cs: Keep track of types and user-defined types.
32312 (BuilderInit): New method for creating an assembly
32313 (ResolveType): New function to launch the resolution process, only
32314 used by interfaces for now.
32316 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
32317 that are inserted into the name space.
32319 2001-06-08 Miguel de Icaza <miguel@ximian.com>
32321 * ARGH. I have screwed up my tree so many times due to the use of
32322 rsync rather than using CVS. Going to fix this at once.
32324 * driver.cs: Objetify driver. Load assemblies, use assemblies to
32327 2001-06-07 Miguel de Icaza <miguel@ximian.com>
32329 * Experiment successful: Use System.Type rather that our own
32332 2001-05-25 Miguel de Icaza <miguel@ximian.com>
32334 * cs-parser.jay: Removed nsAliases from here.
32336 Use new namespaces, handle `using XXX;'
32338 * namespace.cs: Reimplemented namespace handling, use a recursive
32339 definition of the class. Now we can keep track of using clauses
32340 and catch invalid using clauses.
32342 2001-05-24 Miguel de Icaza <miguel@ximian.com>
32344 * gen-treedump.cs: Adapted for all the renaming.
32346 * expression.cs (Expression): this class now has a Type property
32347 which returns an expression Type.
32349 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
32350 `Type', as this has a different meaning now in the base
32352 2001-05-22 Miguel de Icaza <miguel@ximian.com>
32354 * interface.cs, class.cs: Removed from all the sources the
32355 references to signature computation, as we can not do method
32356 signature computation during the parsing time, as we are not
32357 trying to solve at that point distinguishing:
32361 void a (NS.Blah x) {}
32364 Which depending on the context might be valid or not, as we do not
32365 know if Blah is the same thing as NS.Blah at that point.
32367 * Redid everything so the code uses TypeRefs now instead of
32368 Types. TypeRefs are just temporary type placeholders, that need
32369 to be resolved. They initially have a pointer to a string and the
32370 current scope in which they are used. This is used later by the
32371 compiler to resolve the reference to an actual Type.
32373 * DeclSpace is no longer a CIR.Type, and neither are
32374 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
32375 are all DeclSpaces, but no Types.
32377 * type.cs (TypeRefManager): This implements the TypeRef manager,
32378 which keeps track of all the types that need to be resolved after
32379 the parsing has finished.
32381 2001-05-13 Miguel de Icaza <miguel@ximian.com>
32383 * ARGH. We are going to have to store `foreach' as a class rather
32384 than resolving it, as we need to verify error 1579 after name
32385 resolution. *OR* we could keep a flag that says `This request to
32386 IEnumerator comes from a foreach statement' which we can then use
32387 to generate the error.
32389 2001-05-10 Miguel de Icaza <miguel@ximian.com>
32391 * class.cs (TypeContainer.AddMethod): we now add methods to the
32392 MethodGroup instead of the method hashtable.
32394 * expression.cs: Add MethodGroup abstraction, which gets us one
32395 step closer to the specification in the way we handle method
32398 * cs-parser.jay (primary_expression): qualified_identifier now
32399 tried to match up an identifier to a local variable reference or
32400 to a parameter reference.
32402 current_local_parameters is now a parser global variable that
32403 points to the current parameters for the block, used during name
32406 (property_declaration): Now creates an implicit `value' argument to
32409 2001-05-09 Miguel de Icaza <miguel@ximian.com>
32411 * parameter.cs: Do not use `param' arguments as part of the
32412 signature, per the spec.
32414 2001-05-08 Miguel de Icaza <miguel@ximian.com>
32416 * decl.cs: Base class for classes, structs and interfaces. This
32417 is the "Declaration Space"
32419 * cs-parser.jay: Use CheckDef for checking declaration errors
32420 instead of having one on each function.
32422 * class.cs: Factor out some code for handling error handling in
32423 accordance to the "Declarations" section in the "Basic Concepts"
32424 chapter in the ECMA C# spec.
32426 * interface.cs: Make all interface member classes derive from
32427 InterfaceMemberBase.
32429 2001-05-07 Miguel de Icaza <miguel@ximian.com>
32431 * Many things: all interfaces are parsed and generated in
32432 gen-treedump. Support for member variables, constructors,
32433 destructors, properties, constants is there.
32435 Beginning of the IL backend, but very little done, just there for
32438 2001-04-29 Miguel de Icaza <miguel@ximian.com>
32440 * cs-parser.jay: Fix labeled statement.
32442 * cs-tokenizer.cs (escape): Escape " and ' always.
32443 ref_line, ref_name: keep track of the line/filename as instructed
32444 by #line by the compiler.
32447 2001-04-27 Miguel de Icaza <miguel@ximian.com>
32449 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
32450 to match the values in System.CodeDOM.
32452 Divid renamed to Divide.
32454 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
32456 (Statements.set): remove.
32458 * System.CodeDOM/CodeCatchClause.cs: always have a valid
32461 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
32462 falseStatements always have valid values.
32464 * cs-parser.jay: Use System.CodeDOM now.