1 2009-11-13 Marek Safar <marek.safar@gmail.com>
4 * generic.cs: Another missing TypeToCoreType, still too many to fix.
6 2009-11-13 Marek Safar <marek.safar@gmail.com>
10 * class.cs, delegate.cs, enum.cs: Constants have to be available
11 for parameters resolve.
13 2009-11-12 Marek Safar <marek.safar@gmail.com>
15 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
18 2009-11-12 Marek Safar <marek.safar@gmail.com>
20 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
21 with a statically known candidate set.
23 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
25 * generic.cs: Made type inflation for generic constraint checks
26 recursive. This fixes BGO #553655.
28 2009-11-11 Marek Safar <marek.safar@gmail.com>
30 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
33 2009-11-10 Marek Safar <marek.safar@gmail.com>
35 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
36 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
37 attribute.cs: Add some dynamic error checking.
39 2009-11-07 Marek Safar <marek.safar@gmail.com>
43 * expression.cs: Fixed mixed version of expression tree anonymous
46 2009-11-06 Marek Safar <marek.safar@gmail.com>
50 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
51 expression tree version of anonymous type with members declaration.
53 2009-11-05 Marek Safar <marek.safar@gmail.com>
55 * parameter.cs: Handle nullable parameter default expression.
57 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
58 class.cs, attribute.cs: Check for wrong dynamic arguments.
60 2009-11-05 Marek Safar <marek.safar@gmail.com>
62 * statement.cs: Dynamic statements.
64 2009-11-04 Marek Safar <marek.safar@gmail.com>
66 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
67 Compound assignments over dynamic type.
69 2009-11-03 Marek Safar <marek.safar@gmail.com>
71 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
72 constructor arguments.
74 2009-10-30 Marek Safar <marek.safar@gmail.com>
76 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
77 codegen.cs: Unary mutator on dynamic member access expression.
79 2009-10-29 Marek Safar <marek.safar@gmail.com>
82 * convert.cs: Don't eliminate explicit precission casts.
84 2009-10-28 Marek Safar <marek.safar@gmail.com>
88 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
89 expression.cs, statement.cs, ecore.cs: Quote any nested expression
92 2009-10-27 Marek Safar <marek.safar@gmail.com>
94 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
97 * class.cs: Allow nullable binary user operators.
99 2009-10-26 Marek Safar <marek.safar@gmail.com>
101 * expression.cs: Move binary expression optimization at the end of
104 2009-10-23 Marek Safar <marek.safar@gmail.com>
106 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
107 Separate NullConstant from NullLiteral.
109 2009-10-23 Marek Safar <marek.safar@gmail.com>
111 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
112 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
113 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
114 ModuleContainer. Add common unclosed member check routine.
116 2009-10-22 Marek Safar <marek.safar@gmail.com>
118 * argument.cs: Use literal flag for real literals only.
120 * dynamic.cs: Use correct return type for custom delegates.
122 2009-10-22 Marek Safar <marek.safar@gmail.com>
124 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
127 2009-10-22 Marek Safar <marek.safar@gmail.com>
129 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
131 2009-10-21 Marek Safar <marek.safar@gmail.com>
133 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
136 2009-10-21 Marek Safar <marek.safar@gmail.com>
138 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
141 2009-10-20 Marek Safar <marek.safar@gmail.com>
143 * argument.cs, dynamic.cs, expression.cs: Latest API update.
145 2009-10-19 Marek Safar <marek.safar@gmail.com>
147 * typemanager.cs, expression.cs: Dynamic array initializer.
149 2009-10-16 Marek Safar <marek.safar@gmail.com>
151 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
154 2009-10-16 Marek Safar <marek.safar@gmail.com>
156 A fix for bug #493523, #507067
157 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
158 standard nullable conversion using underlying standard conversion
159 and not full conversion.
161 2009-10-15 Marek Safar <marek.safar@gmail.com>
163 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
164 type in VerifyArgumentsCompat.
166 2009-10-15 Marek Safar <marek.safar@gmail.com>
168 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
169 Reject variable used with type arguments.
171 2009-10-14 Marek Safar <marek.safar@gmail.com>
173 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
174 Implement dynamic expressions assignment.
176 2009-10-14 Marek Safar <marek.safar@gmail.com>
178 * expression.cs: Build underlying expression when resolving unary
181 2009-10-14 Marek Safar <marek.safar@gmail.com>
183 * expression.cs: Emit enum array initializer using binary blob.
185 2009-10-08 Marek Safar <marek.safar@gmail.com>
187 * typemanager.cs, constant.cs: Optimize decimal constants which fit
190 2009-10-07 Marek Safar <marek.safar@gmail.com>
192 * typemanager.cs: Reset object_type.
194 * assign: Made SimpleAssign public.
196 2009-10-06 Marek Safar <marek.safar@gmail.com>
198 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
199 invocation assembly to IsThisOrFriendAssembly.
201 2009-10-05 Marek Safar <marek.safar@gmail.com>
203 * expression.cs: Equality comparison of generic parameter with
206 2009-10-05 Marek Safar <marek.safar@gmail.com>
208 A fix for bug #543570
209 * generic.cs: Import predefined constraints correctly.
211 2009-10-02 Marek Safar <marek.safar@gmail.com>
213 * ecore.cs: Don't crash on overloads with optional paremeters where
214 arguments count overflows.
216 * parameter.cs: Import optional parameter constants using optional
219 2009-10-01 Marek Safar <marek.safar@gmail.com>
221 * Makefile: Default is gmcs compiler.
223 2009-10-01 Marek Safar <marek.safar@gmail.com>
225 * cs-parser.jay: Fixed few NRE.
227 2009-10-01 Marek Safar <marek.safar@gmail.com>
229 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
231 2009-09-30 Marek Safar <marek.safar@gmail.com>
233 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
234 ShimExpression, ImplicitCast.
236 2009-09-30 Marek Safar <marek.safar@gmail.com>
238 A fix for bug #542959
239 * delegate.cs: Emit correct delegate instance variable when there
240 are static and non-static overloads.
242 2009-09-29 Marek Safar <marek.safar@gmail.com>
244 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
245 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
247 2009-09-28 Marek Safar <marek.safar@gmail.com>
249 A fix for bug #542487
250 * ecore.cs: Resolve extension methods hidden by properties.
252 2009-09-25 Marek Safar <marek.safar@gmail.com>
254 * expression.cs, ecore.cs: More dynamic binary expressions.
256 2009-09-22 Marek Safar <marek.safar@gmail.com>
258 * nullable.cs, expression.cs: Fixed null lifted conversion for
259 bitwise enum operations.
261 2009-09-22 Marek Safar <marek.safar@gmail.com>
263 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
264 values in checked context.
266 2009-09-22 Marek Safar <marek.safar@gmail.com>
268 * expression.cs, ecore.cs: Fixed array index constant conversion.
270 2009-09-20 Miguel de Icaza <miguel@novell.com>
272 * expression.cs: Do not crash when MemberLookup returns something
273 that is not a MemberExpr here. Report error 582 instead.
277 2009-09-18 Marek Safar <marek.safar@gmail.com>
279 * decl.cs, class.cs: Check protected property accessors.
281 2009-09-18 Marek Safar <marek.safar@gmail.com>
283 * dynamic.cs, assign.cs: Dynamic compound assignment.
285 2009-09-17 Marek Safar <marek.safar@gmail.com>
287 * expression.cs: Fixed compound assignment explicit conversion.
289 2009-09-17 Marek Safar <marek.safar@gmail.com>
291 * expression.cs, ecore.cs: Cannot infer variables from method group.
293 2009-09-16 Marek Safar <marek.safar@gmail.com>
295 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
296 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
297 codegen.cs: Dynamic binary operations scaffolding.
299 2009-09-15 Marek Safar <marek.safar@gmail.com>
301 * expression.cs: Fixes nullable promotion for enum type variables.
303 2009-09-11 Marek Safar <marek.safar@gmail.com>
305 * driver.cs, dynamic.cs: Reset more static variables.
307 2009-09-11 Marek Safar <marek.safar@gmail.com>
309 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
310 driver.cs: Introduced Expression::MakeExpression.
312 2009-09-11 Marek Safar <marek.safar@gmail.com>
314 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
316 2009-09-09 Marek Safar <marek.safar@gmail.com>
318 * eval.cs, report.cs: Use Console.Out for all eval error or warning
321 2009-09-09 Marek Safar <marek.safar@gmail.com>
323 A fix for bug #518707
324 * expression.cs (Is): Optimize only generic parameter type
325 expression probing value type generic parameter.
327 2009-09-09 Marek Safar <marek.safar@gmail.com>
329 A fix for bug #532571
330 * ecore.cs: Check for simple name type arguments used with
333 2009-09-08 Marek Safar <marek.safar@gmail.com>
335 A fix for bug #497421
336 * generic.cs (CheckConstraint): Don't use buildin types to check for
337 parameterless constructor.
339 2009-09-08 Marek Safar <marek.safar@gmail.com>
341 A fix for bug #537402
342 * generic.cs (CheckConstraint): Correctly inflate generic type
343 arguments when checking generic method.
345 2009-09-08 Marek Safar <marek.safar@gmail.com>
347 A fix for bug #536463
348 * decl.cs (AddToContainer): Don't report collision between explicit
349 and parameterless non-explicit members.
351 2009-09-08 Marek Safar <marek.safar@gmail.com>
353 * eval.cs: Reset more static stuff.
355 2009-09-07 Marek Safar <marek.safar@gmail.com>
357 A fix for bug #324625
358 * expression.cs, ecore.cs: Create nested generic type expression
359 using declaring and not current type.
361 2009-09-07 Marek Safar <marek.safar@gmail.com>
363 * *.cs: Changed Report class to accept various output printers and
364 be an instance class. An expression resolver can now use different
365 message reporter for each call and Report.Error can safely throw
366 an exception. Part of ongoing work to turn mcs into proper library.
368 2009-09-04 Marek Safar <marek.safar@gmail.com>
370 * statement.cs, ecore.cs: Removed error reporting from emit code.
372 2009-09-04 Marek Safar <marek.safar@gmail.com>
374 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
376 2009-09-03 Marek Safar <marek.safar@gmail.com>
378 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
379 parser checks out of constructors.
381 2009-09-02 Marek Safar <marek.safar@gmail.com>
383 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
385 2009-09-02 Marek Safar <marek.safar@gmail.com>
387 A fix for bug #535448
388 * anonymous.cs, class.cs: Copy return label between all contexts.
390 2009-09-02 Marek Safar <marek.safar@gmail.com>
392 A fix for bug #535395
393 * namespace.cs: Resolve context can be null.
395 2009-08-25 Marek Safar <marek.safar@gmail.com>
397 A fix for bug #533912
398 * generic.cs: Use correct context for constraints resolving.
400 2009-08-25 Marek Safar <marek.safar@gmail.com>
402 A fix for bug #532630
403 * driver.cs: Trim conditional symbols.
405 2009-08-25 Marek Safar <marek.safar@gmail.com>
407 * context.cs: New file.
409 * *.exe.sources, *.csproj: Updated.
411 2009-08-25 Marek Safar <marek.safar@gmail.com>
413 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
414 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
415 IMembercontext, some small cleanups.
417 2009-08-24 Marek Safar <marek.safar@gmail.com>
419 * *.cs: Split ResolveContext and EmitContext.
421 2009-08-24 Marek Safar <marek.safar@gmail.com>
423 * *.cs: Only ResolveContext implements IMemberContext.
425 2009-08-21 Marek Safar <marek.safar@gmail.com>
427 * *.cs: Renamed IResolveContext to IMemberContext.
429 2009-08-21 Marek Safar <marek.safar@gmail.com>
431 * *.cs: Detached ResolveContext from EmitContext.
433 2009-08-21 Marek Safar <marek.safar@gmail.com>
435 * codegen.cs: Moved flow-analysis to BlockContext.
437 2009-08-21 Marek Safar <marek.safar@gmail.com>
439 * *.cs: Detached BlockContext from EmitContext.
441 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
443 * statement.cs: avoid nullref when the return value of GetEnumerator()
444 does not contain any MoveNext() method.
446 2009-08-19 Marek Safar <marek.safar@gmail.com>
448 * *.cs: Removed IResolveContext::GenericDeclContainer.
450 2009-08-19 Marek Safar <marek.safar@gmail.com>
452 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
454 2009-08-19 Marek Safar <marek.safar@gmail.com>
456 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
457 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
459 2009-08-18 Marek Safar <marek.safar@gmail.com>
461 * *.cs: Removed boolean fields from EmitContext.
463 2009-08-18 Marek Safar <marek.safar@gmail.com>
465 * *.cs: Add IResolveContext::IsStatic.
467 2009-08-18 Marek Safar <marek.safar@gmail.com>
469 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
471 2009-08-17 Marek Safar <marek.safar@gmail.com>
473 * *.cs: Removed DeclContainer from EmitContext.
475 2009-08-17 Marek Safar <marek.safar@gmail.com>
477 * *.cs: Add IResolveContext::CurrentTypeParameters.
479 2009-08-14 Marek Safar <marek.safar@gmail.com>
481 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
483 2009-08-14 Marek Safar <marek.safar@gmail.com>
485 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
486 codegen.cs: Add IResolveContext::LookupExtensionMethod.
488 2009-08-13 Marek Safar <marek.safar@gmail.com>
490 * decl.cs: Look in PartialContainer for parent type parameters.
492 2009-08-13 Marek Safar <marek.safar@gmail.com>
494 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
495 codegen.cs: Add IResolveContext::LookupTypeParameter.
497 2009-08-13 Marek Safar <marek.safar@gmail.com>
499 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
500 Moved resolved logic from Emit to Resolve.
502 2009-08-13 Marek Safar <marek.safar@gmail.com>
504 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
505 codegen.cs: Reworked atttributes handling of ResolveContext.
507 2009-08-12 Marek Safar <marek.safar@gmail.com>
509 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
510 LookupNamespaceOrType to ResolveContext.
512 2009-08-12 Marek Safar <marek.safar@gmail.com>
514 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
515 class.cs: Removed unused parameters and methods.
517 2009-08-11 Marek Safar <marek.safar@gmail.com>
519 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
520 codegen.cs: Finding the best common type of a set of expressions for
523 2009-08-07 Marek Safar <marek.safar@gmail.com>
525 * dynamic.cs, expression.cs: More dynamic conversions.
527 2009-08-06 Miguel de Icaza <miguel@novell.com>
529 * generic.cs: This loop was incorrect, it was increment ii, but
530 checking for `i'. This was a change introduced to fix #327497,
533 * class.cs: Catch another case for cs0533 error, fixes #324782.
535 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
537 * typemanager.cs (GetGenericArguments): SRE returns null for
538 generic methods on type builder instances if they are not generic
539 themselves. For example, for Foo<int>::Bar() it returns null, but
540 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
542 2009-08-05 Marek Safar <marek.safar@gmail.com>
544 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
545 delegate.cs: Work on dynamic binding.
547 2009-08-04 Marek Safar <marek.safar@gmail.com>
549 A second fix for bug #525342
550 * class.cs: Attach partial method attributes to method
553 2009-08-03 Marek Safar <marek.safar@gmail.com>
555 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
558 * rootcontext.cs: Default to langversion v4.
560 2009-08-03 Marek Safar <marek.safar@gmail.com>
562 * pending.cs: Check return type before member info is set.
564 2009-08-03 Marek Safar <marek.safar@gmail.com>
566 * anonymous.cs: Fully initialize generic hoisted field expression.
568 2009-08-02 Miguel de Icaza <miguel@novell.com>
570 * cs-parser.jay: Flag variables declared on the interactive shell
571 as used to prevent the 168 warning about local variable not being
574 2009-07-31 Marek Safar <marek.safar@gmail.com>
576 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
577 attribute.cs: Emit dynamic export attribute.
579 2009-07-30 Marek Safar <marek.safar@gmail.com>
581 * expression.cs: More verifier work.
583 2009-07-29 Marek Safar <marek.safar@gmail.com>
585 * nullable.cs: Fixed SRE crash during corlib compilation.
587 2009-07-29 Marek Safar <marek.safar@gmail.com>
589 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
590 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
591 More TypeManager.TypeToCoreType needed.
593 2009-07-29 Marek Safar <marek.safar@gmail.com>
595 * anonymous.cs: Update after recent SRE fixes.
597 2009-07-28 Marek Safar <marek.safar@gmail.com>
599 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
600 version of GetFieldHandle for fields of generic types.
602 2009-07-27 Marek Safar <marek.safar@gmail.com>
604 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
605 ecore.cs: Add TypeManager.IsDynamicType,
606 PredefinedAttributes.Dynamic.
608 2009-07-27 Marek Safar <marek.safar@gmail.com>
610 A fix for bug #415375
611 * expression.cs: Fixed object and reference type parameter
614 2009-07-27 Marek Safar <marek.safar@gmail.com>
616 A fix for bug #525342
617 * class.cs: Attach partial method attributes to method
620 2009-07-24 Marek Safar <marek.safar@gmail.com>
622 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
625 2009-07-24 Marek Safar <marek.safar@gmail.com>
627 * anonymous.cs (MutateField): Add imported types handling.
629 2009-07-23 Marek Safar <marek.safar@gmail.com>
631 * expression.cs, delegate.cs: Moved arguments resolve into their
632 counterparts expressions. Removed argument resolve from
633 CollectionElementInitializer.
635 2009-07-23 Marek Safar <marek.safar@gmail.com>
637 A fix for bug #523683
638 * convert.cs, delegate.cs: Use common overload mechanism for method
639 group conversion check.
641 2009-07-22 Marek Safar <marek.safar@gmail.com>
643 A fix for bug #523899
644 * generics.cs: Exact type inference with other bound types.
646 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
648 Don't complain when the same type is implemented by the output
649 assembly as well as multiple referenced assemblies
650 * namespace.cs (RootNamespace.LookupTypeReflection): Add
651 'must_be_unique' flag.
652 (GlobalRootNamespace): Update to changes.
653 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
654 already have a type in hand.
656 2009-07-22 Marek Safar <marek.safar@gmail.com>
658 * expression.cs: More verifier instrumentation.
660 * statement.cs: Do proper throw expression conversion.
662 2009-07-22 Marek Safar <marek.safar@gmail.com>
664 A fix for bug #522789
665 * expression.cs: Mutate invocation return type.
667 2009-07-16 Marek Safar <marek.safar@gmail.com>
669 * anonymous.cs: Split assignable and readonly generated variable
672 2009-07-16 Marek Safar <marek.safar@gmail.com>
674 A fix for bug #521671
675 * statement.cs: Fixed crash when checking missing type.
677 2009-07-16 Marek Safar <marek.safar@gmail.com>
679 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
680 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
681 class.cs, driver.cs: Work on dynamic binding.
683 * dynamic.cs: New file.
685 * *.sources, *.proj: Updated.
687 2009-07-15 Marek Safar <marek.safar@gmail.com>
689 * expression.cs (Conditional): Avoid double Resolve.
691 2009-07-13 Marcus Griep <marcus@griep.us>
693 * ecore.cs: Fix obscure bug with resolving members of interfaces
694 that hide parent interface members. Fixes bug #444388 and corrects
697 2009-07-13 Marek Safar <marek.safar@gmail.com>
699 * expression.cs (LocalVariableReference): Bounce resolve.
701 2009-07-10 Marek Safar <marek.safar@gmail.com>
703 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
704 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
707 * support.cs: New dynamic type wrapper.
709 2009-07-08 Marek Safar <marek.safar@gmail.com>
711 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
712 typed local variable.
714 2009-07-06 Marek Safar <marek.safar@gmail.com>
716 A fix for bug #519005
717 * anonymous.cs: Use null_type as no return type placeholder.
719 2009-07-02 Marek Safar <marek.safar@gmail.com>
721 * generic.cs: Handle type inference of identical type parameters
722 with different bounds.
724 2009-07-01 Marek Safar <marek.safar@gmail.com>
726 * expression.cs, class.cs: Events variance.
728 * cs-parser.jay: Interface events error messages.
730 2009-07-01 Marek Safar <marek.safar@gmail.com>
732 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
734 2009-06-29 Marek Safar <marek.safar@gmail.com>
736 * parameter.cs, convert.cs, expression.cs, class.cs: Default
737 parameter expression can be value-type New.
739 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
741 2009-06-26 Marek Safar <marek.safar@gmail.com>
743 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
744 Implemented C# 4.0 named arguments.
746 2009-06-24 Marek Safar <marek.safar@gmail.com>
748 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
749 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
750 parameter modifier. Also fixes bug #515497.
752 2009-06-24 Marek Safar <marek.safar@gmail.com>
754 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
755 arguments expression to be implemented.
757 *.sources: Add argument.cs
759 2009-06-23 Marek Safar <marek.safar@gmail.com>
761 * parameter.cs: Moved GetParameterIndexByName to base class.
763 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
764 unused AType. Use argument's version of GetExpressionTree.
766 2009-06-22 Marek Safar <marek.safar@gmail.com>
768 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
771 2009-06-17 Marek Safar <marek.safar@gmail.com>
773 A fix for bug #514096
774 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
776 2009-06-17 Marek Safar <marek.safar@gmail.com>
778 * expression.cs: The first multi-dimensional array nested array
779 initializers was not checked.
781 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
783 2009-06-17 Marek Safar <marek.safar@gmail.com>
785 A fix for bug #513400
786 * nullable.cs (EmitEquality): Operands emit could be simplified for
787 built-in types when we now emit user operators differently.
789 2009-06-16 Marek Safar <marek.safar@gmail.com>
791 * ecore.cs: Report inaccessible delegate methods correctly.
793 2009-06-16 Marek Safar <marek.safar@gmail.com>
795 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
796 cs-parser.jay: Implemented C# 4.0 optional parameters.
798 2009-06-16 Marek Safar <marek.safar@gmail.com>
800 * driver.cs: Removed broken DefineManifestResource.
802 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
804 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
805 Use $(BOOTSTRAP_PROFILE) instead.
807 2009-06-12 Jb Evain <jbevain@novell.com>
809 * rootcontext.cs: add a Platform field.
810 * driver.cs: handle /platform.
811 * codegen.cs: pass the proper flags according to
812 the platform when saving the assembly.
814 2009-06-11 Marek Safar <marek.safar@gmail.com>
816 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
817 Add optional parameters grammar.
819 2009-06-10 Marek Safar <marek.safar@gmail.com>
821 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
822 driver.cs: Split lang version and metadata version.
824 2009-06-10 Marek Safar <marek.safar@gmail.com>
826 * decl.cs: Better overload ctor collision error message.
828 2009-06-05 Jb Evain <jbevain@novell.com>
830 * driver.cs (EmbededResource): avoid using an internal method
831 in gmcs to embed manifest resources.
833 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
835 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
836 the compiler from older mono versions (like moon's bots)
838 2009-06-04 Marek Safar <marek.safar@gmail.com>
840 * namespace.cs (LookupTypeReflection): Ignore collisions between
843 2009-06-04 Marek Safar <marek.safar@gmail.com>
845 * codegen.cs: Enabled generic type forwarders.
847 2009-06-04 Marek Safar <marek.safar@gmail.com>
849 * dmcs.*: Add another version of SRE compiler.
851 2009-06-03 Marek Safar <marek.safar@gmail.com>
853 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
854 generic-mcs.cs: Fixed variant type conversions.
856 2009-06-02 Marek Safar <marek.safar@gmail.com>
858 A fix for bug #507863
859 * codegen.cs: Fixes a crash on invalid string value attribute.
861 2009-06-01 Marek Safar <marek.safar@gmail.com>
863 A fix for bug #508334
864 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
865 cs-parser.jay: Fully import __arglist modifier.
867 2009-05-29 Marek Safar <marek.safar@gmail.com>
869 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
870 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
871 actually work with closed generic types.
873 2009-05-27 Alan McGovern <amcgovern@novell.com>
875 * class.cs, decl.cs, delegate.cs, parameter.cs:
876 Fix the build by replacing the use of 'var' with the actual type.
878 2009-05-27 Marek Safar <marek.safar@gmail.com>
880 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
881 cs-parser.jay, generic-mcs.cs: Report wrong variant types
884 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
887 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
888 Marek Safar <marek.safar@gmail.com>
890 A fix for bug #377509
891 * parameter.cs: Use predefined and not empty name for implicit
894 2009-05-21 Marek Safar <marek.safar@gmail.com>
896 * class.cs: Don't report wrong warnings for event fields.
898 2009-05-21 Marek Safar <marek.safar@gmail.com>
900 A fix for bug #504667
901 * class.cs: Check for static class using parent container instead of
904 2009-05-08 Marek Safar <marek.safar@gmail.com>
906 A fix for bug #496922
907 * expression.cs: Always use temporary variable when using object
910 2009-04-28 Marek Safar <marek.safar@gmail.com>
912 A fix for bug #495112
913 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
916 2009-04-27 Miguel de Icaza <miguel@novell.com>
918 * driver.cs: Add a flag to work as a replacement for CSC in VS.
920 2009-04-24 Miguel de Icaza <miguel@novell.com>
922 * complete.cs: No idea how gonzalo got a null in the list, but
925 2009-04-24 Miguel de Icaza <miguel@novell.com>
927 * complete.cs (CompletionElementInitializer): New completion class
928 to support completing inside a C# 3 element initializer, so this
929 allows completion for Silverlight situations where it is very
932 new TextBlock () { Fo<TAB>
934 (CompletionSimpleName): Expose the prefix that was
935 passed to the simple name.
937 * cs-parser.jay (object_or_collection_initializer): Add support
938 for element_initializers.
940 * expression.cs (CollectionOrObjectInitializers.DoResolve):
941 special case completion expressions as this method aggressively
942 collects data before it operates, and errors were being thrown
943 earlier than we were able to complete.
945 2009-04-23 Miguel de Icaza <miguel@novell.com>
947 * eval.cs: Make getcompletions silent and enable debugging output
948 if the -v option is passed.
950 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
951 Consider looking up the namespace that matches the prefix being
954 This is part of the support for allowing completions like:
955 `System.Co<TAB>' to complete to System.Console.
957 * complete.cs (CompletionSimpleName.AppendResults): Make this
960 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
962 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
963 COMPLETE_COMPLETION as internal.
965 2009-04-17 Miguel de Icaza <miguel@novell.com>
967 * complete.cs: Include namespace resolution in simple names as
968 well as global types and types in the using scope in the
971 * namespace.cs: Supporting infrastrcture to provide completions
972 based on the current using scope.
974 * eval.cs: Introduce an entry point that allows for initialization
975 to return a list of the files passed on the command line.
977 2009-04-14 Marek Safar <marek.safar@gmail.com>
979 A fix for bug #494243
980 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
982 2009-04-13 Marek Safar <marek.safar@gmail.com>
984 A fix for bug #493887
985 * statement.cs: Don't skip string multi-section with default or
986 null label when populating string hashtable.
988 2009-04-06 Marek Safar <marek.safar@gmail.com>
990 A fix for bug #492329
991 * expression.cs (New): Load variable when assigning type parameter
994 2009-04-06 Marek Safar <marek.safar@gmail.com>
996 A fix for bug #488960
997 * decl.cs: Compare MVAR types using non-null values.
999 2009-03-27 Marek Safar <marek.safar@gmail.com>
1001 * typemanager.cs, expression.cs: Removed unused nullable checks.
1003 2009-03-27 Marek Safar <marek.safar@gmail.com>
1005 * *.cs: Removed some gmcs conditionals.
1007 2009-03-26 Marek Safar <marek.safar@gmail.com>
1009 * generic.cs, support.cs: Moved generics stuff out of support.cs
1011 2009-03-24 Marek Safar <marek.safar@gmail.com>
1013 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1016 2009-03-23 Marek Safar <marek.safar@gmail.com>
1018 * attribute.cs: Consider all members for error reporting when
1019 checking named arguments.
1021 2009-03-23 Marek Safar <marek.safar@gmail.com>
1023 A fix for bug #487625
1024 * namespace.cs: Use a warning for all predefined type conflicts.
1026 2009-03-23 Marek Safar <marek.safar@gmail.com>
1028 A fix for bug #485706
1029 * statement.cs: Explicitly type catch type argument to pass verifier
1032 2009-03-22 Miguel de Icaza <miguel@novell.com>
1034 Initial support to provide code completion facilities to consumers
1035 of the evaluator API.
1037 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1038 support the completion engine. When we reach the end of the
1039 input stream instead of returning EOF, when this flag is true the
1040 tokenizer instead produces:
1042 One GENERATE_COMPLETION token: this token then must be
1043 handled in the grammar at every point where the user
1044 would likely request a completion.
1046 As many COMPLETE_COMPLETION tokens as necessary. These
1047 tokens are generated to assist the parser in unwinding and
1048 producing a valid parse tree.
1050 The parser rules do not have to be perfect, the parser needs to be
1051 augmented with judicious use of GENERATE_COMPLETION tokens to
1052 improve the areas where we can provide completion and the parser
1053 needs to add support for COMPLETE_COMPLETION tokens in productions
1056 It is common to not have enough support for COMPLETE_COMPLETION
1057 under certain rules and that even if we generated the
1058 GENERATE_COMPLETION token that the resulting tree will be invalid
1059 due to the missing rules that support COMPLETE_COMPLETION.
1061 The final EOF token is produced by having the parser notify the
1062 tokenizer when it reaches the root production that the next token
1065 * support.cs (CompletionResult): New Exception. This exception
1066 is thrown to return the completion results when one of the special
1067 completion expressions is reached.
1069 This exception is thrown by the completing ExpressionStatements
1070 classes that live in complete.cs
1072 * complete.cs (CompletingExpression): a new base class for
1073 completing expressions. This derives from the
1074 ExpressionStatement class and not from Expression as it allows
1075 completion to happen not only where expressions are expected in
1076 the grammar, but also where statements are expected.
1078 (CompletionSimpleName): A new class used to provide completions
1079 for SimpleNames. This currently only resolves to local
1080 variables from the evaluator context (GetVars call).
1082 (CompletionMemberAccess): Implements support for completing member
1085 * cs-parser.jay: Add support for completion in a few places.
1087 * eval.cs (GetCompletions): New public API for the evaluator that
1088 returns a list of possible completions given the input. The
1089 return value is an array of completions
1091 * anonymous.cs (Compatible): If the exception thrown from the
1092 resolved expression is a CompletionResult exception let that one
1093 through instead of printing a diagnostic error in the try/catch.
1095 2009-03-22 Miguel de Icaza <miguel@novell.com>
1099 * driver.cs (Main): Use Environment.Exit to quit quickly and
1100 prevent the compiler from doing the usual wait for helper thread
1103 This is to prevent a slowdown that was reported by Gonzalo on
1106 2009-03-19 Marek Safar <marek.safar@gmail.com>
1108 * ecore.cs: Load build-in types directly instead of accessing
1111 2009-03-18 Marek Safar <marek.safar@gmail.com>
1113 * ecore.cs: Always use unbox.any when available.
1115 2009-03-18 Marek Safar <marek.safar@gmail.com>
1117 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1119 2009-03-17 Marek Safar <marek.safar@gmail.com>
1121 * generic.cs: Removed obsolete version of type inference.
1123 2009-03-16 Marek Safar <marek.safar@gmail.com>
1125 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1126 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1127 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1128 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1130 2009-03-11 Marek Safar <marek.safar@gmail.com>
1132 A fix for bug #482996
1133 * anonymous.cs: Make sure we are not infering return type when
1134 checking type compatibility.
1136 2009-03-11 Marek Safar <marek.safar@gmail.com>
1138 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1139 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1140 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1141 attributes in their own structure. Needed when accessing their
1142 properties before they are resolved.
1144 2009-03-09 Marek Safar <marek.safar@gmail.com>
1146 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1147 hashtable (~10x faster).
1149 * driver.cs: Removed wrong Reset.
1151 2009-03-08 Marek Safar <marek.safar@gmail.com>
1153 * class.cs: Use correct common base type for unmanaged delayed
1156 * rootcontext.cs: Wrap unhandled exception.
1158 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1160 Make SeekableStreamReader self-tuning and arbitrarily seekable
1161 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1163 (SeekableStreamReader.Position.set): Use it. Simplify logic
1164 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1165 buffer size when the stream needs to be re-read from the beginning.
1167 2009-03-05 Marek Safar <marek.safar@gmail.com>
1169 A fix for bug #480100
1170 * parameter.cs: A parameter is not hoisted when used directly as ET.
1172 2009-03-04 Marek Safar <marek.safar@gmail.com>
1174 * statement.cs: Fixed an issue when using variable is of interface
1177 2009-03-03 Marek Safar <marek.safar@gmail.com>
1179 A fix for bug #480319
1180 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1182 2009-03-03 Marek Safar <marek.safar@gmail.com>
1184 A fix for bug #480867
1185 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1186 expression to have no valid type.
1188 2009-03-03 Marek Safar <marek.safar@gmail.com>
1190 A fix for bug #481258
1191 * class.cs: Set extension method flag in partial container.
1193 2009-03-03 Marek Safar <marek.safar@gmail.com>
1195 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1197 * attribute.cs: Add sanity check.
1199 2009-02-27 Marek Safar <marek.safar@gmail.com>
1201 * class.cs: Add external constructor error.
1203 2009-02-26 Marek Safar <marek.safar@gmail.com>
1205 A fix for bug #475354
1206 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1207 correctly user defined nullable equality operators.
1209 2009-02-25 Marek Safar <marek.safar@gmail.com>
1211 A fix for bug #479532
1212 * expression.cs: Implement NewInitialize::AddressOf.
1214 2009-02-25 Marek Safar <marek.safar@gmail.com>
1216 A fix for bug #413633
1217 * expression.cs: Iterate all base class-constraint types.
1219 2009-02-24 Marek Safar <marek.safar@gmail.com>
1221 A fix for bug #479209
1222 * literal.cs: Mutate null underlying type.
1224 2009-02-24 Marek Safar <marek.safar@gmail.com>
1226 A fix for bug #476295
1227 * convert.cs: Avoid wrapping implicitly convertible reference type.
1229 2009-02-23 Marek Safar <marek.safar@gmail.com>
1231 * iterators.cs: Create MemberName correctly.
1233 2009-02-23 Marek Safar <marek.safar@gmail.com>
1235 A fix for bug #478655
1236 * literal.cs: Check also underlying null type conversion.
1238 2009-02-21 Marek Safar <marek.safar@gmail.com>
1240 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1242 2009-02-20 Marek Safar <marek.safar@gmail.com>
1244 A fix for bug #477447
1245 * statement.cs: Add reference to correct parent storey when this
1246 is accessible from deep children storey (more than 1 level).
1248 2009-02-19 Marek Safar <marek.safar@gmail.com>
1250 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1251 * class.cs: Define base type members before setting up member cache.
1253 2009-02-18 Marek Safar <marek.safar@gmail.com>
1255 A fix for bug #477378
1256 * nullable.cs, expression.cs, statement.cs: More precise null type
1259 2009-02-18 Marek Safar <marek.safar@gmail.com>
1261 A fix for bug #472805
1262 * typemanager.cs, namespace.cs: Import only visible extension method
1265 2009-02-18 Marek Safar <marek.safar@gmail.com>
1267 A fix for bug #476895
1268 * attribute.cs: Use correct resolve context for attribute type.
1270 2009-02-18 Marek Safar <marek.safar@gmail.com>
1272 A fix for bug #476266
1273 * anonymous.cs: Mutate multi-dimensional arrays.
1275 2009-02-18 Marek Safar <marek.safar@gmail.com>
1277 A fix for bug #476400
1278 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1280 2009-02-18 Marek Safar <marek.safar@gmail.com>
1282 A fix for bug #476811
1283 * generics.cs: Fixed null-literal check.
1285 2009-02-17 Marek Safar <marek.safar@gmail.com>
1287 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1288 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1289 messing with static variables.
1291 2009-02-16 Marek Safar <marek.safar@gmail.com>
1293 A fix for bug #475965
1294 * generics.cs: Check generic parameter type after extracting from
1297 2009-02-16 Marek Safar <marek.safar@gmail.com>
1299 A fix for bug #475823
1300 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1303 2009-02-14 Marek Safar <marek.safar@gmail.com>
1305 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1306 Simplified event field definition using backing field and not
1307 field builder directly.
1309 * expression.cs (EmitLdArg): Optimize fast paths.
1311 2009-02-13 Marek Safar <marek.safar@gmail.com>
1313 A fix for bug #475327
1314 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1316 2009-02-13 Marek Safar <marek.safar@gmail.com>
1318 A fix for bug #475342
1319 * cs-parser.jay: Using 'super' instead of 'base' to call base
1320 constructor crashes compiler.
1322 2009-02-13 Marek Safar <marek.safar@gmail.com>
1324 A fix for bug #475354
1325 * expression.cs (Constantify): Add nullable types.
1327 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1329 2009-02-12 Marek Safar <marek.safar@gmail.com>
1331 A fix for bug #475246
1332 * expression.cs: More broken flowanalysis hacking needed.
1334 2009-02-12 Marek Safar <marek.safar@gmail.com>
1336 * attribute.cs: Compare only ref/out array modifiers.
1338 2009-02-11 Marek Safar <marek.safar@gmail.com>
1340 * statement.cs: Use member cache when looking for foreach members.
1342 2009-02-11 Marek Safar <marek.safar@gmail.com>
1344 * expression.cs: Don't expose internal initializer types.
1346 * statement.cs: Check also explicit conversions for goto case.
1348 2009-02-11 Marek Safar <marek.safar@gmail.com>
1350 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1352 2009-02-10 Marek Safar <marek.safar@gmail.com>
1354 * *.cs: Replace null-type with NullLiteral where appropriate.
1356 2009-02-09 Marek Safar <marek.safar@gmail.com>
1358 * expression.cs: Initializer of reference argument use temporary
1359 variable to be verifiable.
1361 * parameter.cs: Share EmitLdArg.
1363 2009-02-09 Marek Safar <marek.safar@gmail.com>
1365 A fix for bug #473559
1366 * class.cs: Fixed: Not reporting error about nested class with the
1369 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1371 Contributed under the MIT/X11 license.
1373 * generic.cs: Added VerifyVariantTypeParameters which performs new
1374 variance verification logic. The old logic, based on the spec, was
1375 wrong because the spec is full of LIES!
1377 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1379 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1382 * ecore.cs: Added calls to the new variance verification logic.
1385 * delegate.cs: Removed calls to the old variance verification logic.
1387 2009-02-06 Marek Safar <marek.safar@gmail.com>
1389 * delegate.cs: Use cached Invoke method directly.
1391 2009-02-06 Marek Safar <marek.safar@gmail.com>
1393 * expression.cs: Emit expression tree for hoisted variable access.
1395 2009-02-04 Marek Safar <marek.safar@gmail.com>
1397 * namespace.cs: Add better extension class check.
1399 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1401 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1403 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1405 This patch adds initial generic variance support to the compiler.
1406 It is contributed under the MIT/X11 license.
1408 * typemanager.cs: Modified ImplementsInterface to check variance.
1409 Added VerifyVariantTypeParameters which checks the specified type to see
1410 if it uses a variant type parameter as a type argument (which is not
1411 allowed). Added IsVariantOf which determins if the first type is a
1412 variant of the second. NOTE: This only supports reference types at
1413 the moment to conform with the current level of VM support. When the
1414 VM supports value types, this will follow step.
1416 * generic.cs: Added the Variance enum. Added a Variance property to
1417 TypeParameter and added variance support to definition phase. Added a
1418 Variance property to TypeParameterName. Also check to make sure that
1419 no variant types appear in generic method parameters.
1421 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1422 keywords if the langversion supports it.
1424 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1425 that variant types are only used in legal positions. Also added
1426 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1429 * decl.cs: Construct TypeParameter with the variance information.
1431 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1432 and ImplicitConversionStandard.
1434 * rootcontext.cs: Added new "Future" language version.
1436 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1437 type parameters are not used as type arguments in interface inheritance.
1438 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1439 parameters are not used as method return types. In MemberBase.
1440 ResolveMemberType, ensure that variant type parameters are not used
1441 as type arguments. Also call VerifyNoVariantTypeParameters on every
1442 set of parameters which are resolved.
1444 * delegate.cs: Modified Delegate.Define to ensure that variant
1445 parameters are not used as type arguments and that a contravariant
1446 parameter is not used as the return type. Also call
1447 VerifyNoVariantTypeParameters on the delegate parameters.
1449 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1450 to specify generic variance.
1452 * driver.cs: Added support for LanguageVersion.Future in the form of
1453 "-langversion:future".
1455 * generic-mcs.cs: Stubbed out new members in generic.cs.
1457 2009-02-03 Marek Safar <marek.safar@gmail.com>
1459 * class.cs, generic.cs: Emit type parameter constraints for nested
1462 2009-02-02 Marek Safar <marek.safar@gmail.com>
1464 A fix for bug #471213
1465 * class.cs: Avoid emitting backing field for abstract event fields.
1467 2009-02-01 Marek Safar <marek.safar@gmail.com>
1469 A fix for bug #359731
1470 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1473 2009-01-30 Marek Safar <marek.safar@gmail.com>
1475 A fix for bug #470767
1476 * statement.cs: Introduced BlockScopeExpression, needed when
1477 expression tree conversion has to emit scope variables.
1479 2009-01-29 Marek Safar <marek.safar@gmail.com>
1481 * class.cs: Remove duplicate CallingConvention.
1483 2009-01-29 Marek Safar <marek.safar@gmail.com>
1485 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1486 when I finally found the right naming convention.
1488 2009-01-29 Marek Safar <marek.safar@gmail.com>
1490 * cs-tokenizer.cs: Put back different open parens optimization.
1492 2009-01-28 Marek Safar <marek.safar@gmail.com>
1494 A fix for bug #470227
1495 * cs-tokenizer.cs: Remove too agressive parser optimization.
1497 2009-01-28 Marek Safar <marek.safar@gmail.com>
1499 A fix for bug #324319
1500 * class.cs: Remove too early base type resolve.
1502 2009-01-27 Marek Safar <marek.safar@gmail.com>
1504 A fix for bug #324319
1505 * ecore.cs: Explicitly type null when assigning to type argument to
1506 make pass verifier check.
1508 2009-01-27 Marek Safar <marek.safar@gmail.com>
1510 * anonymous.cs: Fixed recent regression when initializing captured
1513 2009-01-26 Marek Safar <marek.safar@gmail.com>
1515 A fix for bug #469019
1516 * anonymous.cs: Use all parent type parameters when instantiating
1517 nested generic storey.
1519 2009-01-26 Marek Safar <marek.safar@gmail.com>
1521 * expression.cs: Check for null instance methodgroup expression.
1523 2009-01-26 Marek Safar <marek.safar@gmail.com>
1525 A fix for bug #469244
1526 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1527 instance inside a conditional expression.
1529 2009-01-23 Marek Safar <marek.safar@gmail.com>
1531 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1532 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1533 GetElementType and HasElementType. IsValueType clean up.
1535 2009-01-23 Marek Safar <marek.safar@gmail.com>
1537 * nullable.cs: Use common EmitCall.
1539 * expression.cs: Emit constraint. for virtual calls only.
1541 2009-01-23 Marek Safar <marek.safar@gmail.com>
1543 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1544 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1545 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1548 2009-01-22 Jb Evain <jbevain@novell.com>
1550 * anonymous.cs: make anonymous types' ToString implementation
1551 match what csc outputs.
1553 2009-01-21 Marek Safar <marek.safar@gmail.com>
1555 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1558 2009-01-17 Marek Safar <marek.safar@gmail.com>
1560 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1563 2009-01-16 Marek Safar <marek.safar@gmail.com>
1565 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1568 2009-01-15 Marek Safar <marek.safar@gmail.com>
1570 A fix for bug #466634
1571 * statement.cs: Add reference for nested storey when only this
1574 2009-01-15 Marek Safar <marek.safar@gmail.com>
1576 A fix for bug #466474
1577 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1580 2009-01-15 Marek Safar <marek.safar@gmail.com>
1582 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1583 Fixed nested stories parent referencing process. Also fixes #463985.
1585 2009-01-06 Marek Safar <marek.safar@gmail.com>
1587 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1588 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1589 implementation. Also fixes #463108.
1591 2009-01-05 Marek Safar <marek.safar@gmail.com>
1593 A fix for bug #416109
1594 * decl.cs: Issue correct CLSAttribute warning location.
1596 2009-01-05 Marek Safar <marek.safar@gmail.com>
1598 A fix for bug #456775
1599 * attribute.cs: Use attribute owner scope when resolving attribute
1602 2009-01-05 Marek Safar <marek.safar@gmail.com>
1604 A fix for bug #457257
1605 * decl.cs: Fixed incorrect member declaring type comparison.
1607 2009-01-05 Marek Safar <marek.safar@gmail.com>
1609 A fix for bug #460896
1610 * driver.cs: Handle /RES resources as embeddable.
1612 2009-01-05 Marek Safar <marek.safar@gmail.com>
1614 A fix for bug #462515
1615 * ecore.cs: Report inacessible members upwards.
1617 2009-01-05 Marek Safar <marek.safar@gmail.com>
1619 A fix for bug #463190, #463192
1620 * decl.cs, namespace.cs: Also import internal extension classes.
1622 2009-01-04 Marek Safar <marek.safar@gmail.com>
1624 A fix for bug #463415
1625 * generic.cs: Use right index for RemoveDependentTypes.
1627 2009-01-02 Marek Safar <marek.safar@gmail.com>
1629 A fix for bug #463196
1630 * expression.cs: Fixed enum to null comparison.
1632 2009-01-02 Marek Safar <marek.safar@gmail.com>
1634 A fix for bug #463121
1635 * nullable.cs: Fixed nullable user equality operator comparison.
1637 2009-01-02 Marek Safar <marek.safar@gmail.com>
1639 A fix for bug #462950
1640 * class.cs, decl.cs: Use full explicit name when defining automatic
1641 property backing field.
1643 2009-01-02 Marek Safar <marek.safar@gmail.com>
1645 A fix for bug #462592
1646 * pending.cs: Emit type arguments for generic proxy method.
1648 2008-12-30 Marek Safar <marek.safar@gmail.com>
1650 * expression.cs (As): Mutate all type arguments.
1652 2008-12-29 Marek Safar <marek.safar@gmail.com>
1654 A fix for bug #462622
1655 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
1658 2008-12-29 Marek Safar <marek.safar@gmail.com>
1660 A fix for bug #450782
1661 * ecore.cs: Consider more variables of form V.I to be fixed.
1663 2008-12-29 Marek Safar <marek.safar@gmail.com>
1665 A fix for bug #460712
1666 * typemanager.cs: Core types could be imported.
1668 2008-12-28 Marek Safar <marek.safar@gmail.com>
1670 A fix for bugs #460847, #460772, #458049, #457339, #447807
1671 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
1672 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
1673 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
1674 user lambdas used inside query clauses.
1676 2008-12-18 Marek Safar <marek.safar@gmail.com>
1678 A fix for bug #460229
1679 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
1681 2008-12-18 Marek Safar <marek.safar@gmail.com>
1683 A fix for bug #459952
1684 * decl.cs, namespace.cs: Use common CheckAccessLevel.
1686 2008-12-18 Marek Safar <marek.safar@gmail.com>
1688 A fix for bug #459630
1689 * convert.cs: Enum to valuetype conversion is not allowed.
1691 2008-12-18 Marek Safar <marek.safar@gmail.com>
1693 A fix for bug #457087
1694 * generic.cs: Don't crash when constraint comes from type
1697 2008-12-16 Marek Safar <marek.safar@gmail.com>
1699 A fix for bug #459221
1700 * anonymous.cs, statement.cs: Delay only captured this
1703 2008-12-12 Marek Safar <marek.safar@gmail.com>
1705 A fix for bug #457489
1706 * anonymous.cs, statement.cs: Split anonymous storey instantiation
1707 and initialization to capture scope initializers correctly.
1709 2008-12-11 Marek Safar <marek.safar@gmail.com>
1711 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
1712 ParameterReference refactoring.
1714 2008-12-03 Marek Safar <marek.safar@gmail.com>
1716 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
1717 to be imported from any assembly.
1719 2008-12-03 Marek Safar <marek.safar@gmail.com>
1721 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
1722 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
1723 from anonymous method and lambda expression.
1725 2008-12-01 Marek Safar <marek.safar@gmail.com>
1727 A fix for bug #448560
1728 * expression.cs (As): Box any generic type arguments to be
1731 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1733 Add tripwire for implicit conversion bugs
1734 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
1736 (MethodGroupExpr.OverloadResolve): Add sanity check between
1737 IsApplicable and VerifyArgumentsCompat.
1738 (VerifyArgumentsCompat): Report CS1501 where appropriate.
1740 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
1742 Fix build break in System.Data_test
1743 * convert.cs (ImplicitConversionExists): Move NullLiteral
1745 (ImplicitStandardConversionExists): ... here.
1747 2008-11-28 Marek Safar <marek.safar@gmail.com>
1749 * literal.cs: Emit correctly explicit null to nullable cast.
1751 2008-11-28 Marek Safar <marek.safar@gmail.com>
1753 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
1756 2008-11-28 Marek Safar <marek.safar@gmail.com>
1758 A fix for bug #449005
1759 * convert.cs, nullable.cs: Use only one implicit nullable
1762 2008-11-27 Marek Safar <marek.safar@gmail.com>
1764 * convert.cs, literal.cs: More Convert cleanup is needed.
1766 2008-11-27 Marek Safar <marek.safar@gmail.com>
1768 * decl.cs, class.cs: Fixed misleading error message.
1770 2008-11-26 Marek Safar <marek.safar@gmail.com>
1772 A fix for bug #449005
1773 * nullable.cs (EmitEquality): Disable optimization for user operator
1776 2008-11-25 Marek Safar <marek.safar@gmail.com>
1778 A fix for bug #447027
1779 * anonymous.cs (HoistedVariable): Cache also outer access to deal
1780 with context variables stored as expression instances.
1782 2008-11-25 Marek Safar <marek.safar@gmail.com>
1784 A fix for bug #447027
1785 * delegate.cs: Fixed delegate VerifyMethod logic.
1787 2008-11-24 Marek Safar <marek.safar@gmail.com>
1789 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
1792 2008-11-21 Marek Safar <marek.safar@gmail.com>
1794 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
1795 member type resolve to follow normal flow, instead of random
1798 2008-11-21 Marek Safar <marek.safar@gmail.com>
1800 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
1803 2008-11-21 Marek Safar <marek.safar@gmail.com>
1805 * const.cs: Emit decimal array constant as literal.
1807 2008-11-20 Marek Safar <marek.safar@gmail.com>
1809 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
1811 2008-11-19 Marek Safar <marek.safar@gmail.com>
1813 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
1814 into real property (saves 8 MB for corlib compilation).
1816 2008-11-19 Marek Safar <marek.safar@gmail.com>
1818 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
1819 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
1820 generic-mcs.cs: Small cleanup of TypeArguments.
1822 2008-11-18 Marek Safar <marek.safar@gmail.com>
1824 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
1825 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
1826 of ConstructedType expression, renamed to GenericTypeExpr.
1828 2008-11-17 Marek Safar <marek.safar@gmail.com>
1830 A fix for bug #445303
1831 * location.cs (IsConditionalDefined): Handle undefined global
1834 2008-11-17 Marek Safar <marek.safar@gmail.com>
1836 A fix for bug #444678
1837 * expression.cs (TryReduceConstant): Always create new constant
1840 2008-11-17 Marek Safar <marek.safar@gmail.com>
1842 A fix for bug #444673
1843 * ecore.cs: Ignore open generic types when used as generic type
1846 2008-11-17 Marek Safar <marek.safar@gmail.com>
1848 A fix for bug #445458
1849 * expression.cs, cs-parser.jay: Don't crash when an expression
1852 2008-11-17 Marek Safar <marek.safar@gmail.com>
1854 A fix for bug #445464
1855 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
1856 inside unbound type.
1858 2008-11-14 Jb Evain <jbevain@novell.com>
1860 * driver.cs: ignore empty -nowarn argument such as
1861 the one in -nowarn:12,13,,.
1863 2008-11-13 Marek Safar <marek.safar@gmail.com>
1865 A fix for bug #444271
1866 * anonymous.cs: Rescan parent storeys when best candidate was
1869 2008-11-13 Marek Safar <marek.safar@gmail.com>
1871 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
1872 useless UnboundTypeExpression.
1874 * attribute.cs: Do check obsolete attribute on generic types.
1876 2008-11-12 Marek Safar <marek.safar@gmail.com>
1878 A fix for bugs #425680, #400139
1879 * ecore.cs, expression.cs: Trying to do some almost_matched_members
1882 2008-11-11 Marek Safar <marek.safar@gmail.com>
1884 A fix for bug #435747
1885 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
1886 compound value types assignment. Few micro optimizations added.
1888 2008-11-10 Marek Safar <marek.safar@gmail.com>
1890 A fix for bug #442610
1891 * anonymous.cs (MutateConstructor): More SRE hacking.
1893 2008-11-10 Marek Safar <marek.safar@gmail.com>
1895 A fix for bug #442579
1896 * ecore.cs: Also initialize expanded form of a method with 1 params
1899 2008-11-06 Marek Safar <marek.safar@gmail.com>
1901 * expression.cs (UnaryMutator): Do early l-side check.
1903 2008-11-05 Miguel de Icaza <miguel@novell.com>
1905 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
1906 Init, otherwise we would crash later on when checking for friend
1909 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
1910 Otherwise we never get any meaningful information as to what
1913 2008-11-05 Marek Safar <marek.safar@gmail.com>
1915 A fix for bug #436318
1916 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
1918 2008-11-05 Miguel de Icaza <miguel@novell.com>
1920 * namespace.cs: Turns out that it was a really bad idea to hide
1921 the errors for namespaces not found here in eval mode.
1923 * eval.cs: When we process using clauses, only enter those into
1924 the list of valid using clauses after they have been validated.
1926 The above change gives the proper semantics: it does not
1927 senselessly report the same errors with broken using statements by
1928 never storing them in the first place when they are invalid.
1930 2008-11-05 Marek Safar <marek.safar@gmail.com>
1932 A fix for bug #421839
1933 * cs-parser.jay: Remove expression from coalesce rule to force lower
1934 priority than the assignment operator.
1936 2008-11-05 Marek Safar <marek.safar@gmail.com>
1938 A fix for bug #437875
1939 * nullable.cs: Compile correctly method group operand used with null
1940 coalescing operator.
1942 2008-11-04 Marek Safar <marek.safar@gmail.com>
1944 A fix for bug #434589
1945 * expression.cs (Binary): Ignore lifted conversions when at least
1946 one operand is of reference type.
1948 2008-11-04 Marek Safar <marek.safar@gmail.com>
1950 * cs-parser.jay: Better syntax error report.
1952 2008-11-03 Marek Safar <marek.safar@gmail.com>
1954 A fix for bug #436792
1955 * cs-parser.jay: Use GetLocation to access location.
1957 2008-11-03 Marek Safar <marek.safar@gmail.com>
1959 A fix for bug #440774
1960 * cs-parser.jay: Also set current_array_type when parsing local
1963 2008-11-03 Marek Safar <marek.safar@gmail.com>
1965 A fix for bug #440785
1966 * expression.cs (As): Don't resolve self modifing expression
1969 2008-11-03 Marek Safar <marek.safar@gmail.com>
1971 A fix for bug #439447
1972 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
1974 2008-11-03 Marek Safar <marek.safar@gmail.com>
1976 A fix for bug #437571
1977 * cs-parser.jay: Fixes internal error for invalid expression
1980 2008-10-17 Marek Safar <marek.safar@gmail.com>
1982 * ecore.cs: Resolve correctly ambiguous params delegate methods.
1984 2008-10-17 Marek Safar <marek.safar@gmail.com>
1986 * generic.cs, anonymous.cs: Simplified GetDeclarations.
1988 2008-10-17 Marek Safar <marek.safar@gmail.com>
1990 * cs-tokenizer.cs: More precise cast parsing.
1992 2008-10-16 Martin Baulig <martin@ximian.com>
1994 * anonymous.cs (AnonymousMethodStorey): Put back the
1995 `hoisted_locals' hashtable and use it in EmitType().
1997 2008-10-15 Marek Safar <marek.safar@gmail.com>
1999 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2000 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2003 2008-10-14 Marek Safar <marek.safar@gmail.com>
2005 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2007 2008-10-14 Marek Safar <marek.safar@gmail.com>
2009 * statement.cs: Mutate scope initializers.
2011 2008-10-14 Marek Safar <marek.safar@gmail.com>
2013 * expression.cs: Use typeless value for This constant.
2015 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2017 2008-10-14 Marek Safar <marek.safar@gmail.com>
2019 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2022 2008-10-13 Marek Safar <marek.safar@gmail.com>
2024 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2027 2008-10-13 Marek Safar <marek.safar@gmail.com>
2029 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2030 parser and tokenizer. Fixes many ambiguities including #433258.
2032 2008-10-10 Marek Safar <marek.safar@gmail.com>
2034 * cs-parser.jay: Fixed missing accessor recovery.
2036 2008-10-10 Marek Safar <marek.safar@gmail.com>
2038 A fix for bug #433701
2039 * expression.cs: Better error message.
2041 2008-10-10 Marek Safar <marek.safar@gmail.com>
2043 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2045 * Makefile: Disabled unused debug symbols.
2047 Also fixes: #320556, #321097, #321656, #321876, #351316
2049 2008-10-09 Miguel de Icaza <miguel@novell.com>
2051 * eval.cs: rename "<interactive>" to "{interactive}", to work
2052 around a requirement in the compiler that this be a valid
2053 filename, and in Windows it is not (433886).
2055 2008-10-09 Marek Safar <marek.safar@gmail.com>
2057 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2059 2008-10-08 Marek Safar <marek.safar@gmail.com>
2061 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2062 cs-parser.jay: Generic type declaration and type arguments cleanup.
2064 2008-10-05 Marek Safar <marek.safar@gmail.com>
2066 * cs-parser.jay: Allow parsing weird array creation construct.
2068 2008-10-05 Marek Safar <marek.safar@gmail.com>
2070 * cs-parser.jay: Conflicts reduction.
2072 2008-10-04 Marek Safar <marek.safar@gmail.com>
2074 * cs-parser.jay: Conflicts reduction.
2076 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2079 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2080 property. Add a 'count' hint about the use of the shared vector.
2081 Ensure that we don't leak out dirty bits.
2082 (UsageVector.MergeChild): Throw away information about variables
2084 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2086 2008-10-03 Marek Safar <marek.safar@gmail.com>
2088 A fix for bug #431746
2089 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2090 parameters when iterator is created.
2092 2008-10-03 Marek Safar <marek.safar@gmail.com>
2094 A fix for bug #431827
2095 * expression.cs: Fixed right based pointer arithmetic operations
2098 2008-10-03 Marek Safar <marek.safar@gmail.com>
2100 A fix for bug #353779
2101 * assign.cs, expression.cs: Fixed compound assignment conversions.
2103 2008-10-02 Marek Safar <marek.safar@gmail.com>
2105 A fix for bug #375262
2106 * statement.cs: Refactor ArrayForeach to be usable with string
2107 indexer. Optimized single dimentional arrays foreach.
2109 2008-10-02 Marek Safar <marek.safar@gmail.com>
2111 A fix for bug #431255
2112 * anonymous.cs, expression.cs: Removed broken optimization.
2114 2008-10-01 Marek Safar <marek.safar@gmail.com>
2116 * anonymous.cs: Use full type parameters of parent generic
2117 containers. Removed unnecessary AddParentStoreyReference call.
2119 2008-10-01 Marek Safar <marek.safar@gmail.com>
2121 A fix for bug #324702
2122 * class.cs: Use better shorter names for explicit interface member
2125 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2127 2008-10-01 Marek Safar <marek.safar@gmail.com>
2129 * expression.cs: Use new interface to check fixed expression.
2131 2008-10-01 Marek Safar <marek.safar@gmail.com>
2133 A fix for bug #421101
2134 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2135 interface to check for fixed fixed-buffers.
2137 2008-10-01 Marek Safar <marek.safar@gmail.com>
2139 A fix for bug #429264
2140 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2142 * delegate.cs: Removed unnecessary casts.
2144 2008-09-30 Marek Safar <marek.safar@gmail.com>
2146 A fix for bug #352151
2147 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2148 class.cs: Fixed already defined explicit interface members check.
2150 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2152 cs-tokenizer.cs: Fix typo.
2154 2008-09-28 Miguel de Icaza <miguel@novell.com>
2156 * eval.cs (InteractiveBase): The quit command now just sets a
2157 flag, instead of calling Environment.Exit(), it is milder on
2160 CompiledMethod is now in Mono.CSharp, not nested inside
2161 the Evaluator, it was inconvenient to use.
2163 2008-09-27 Miguel de Icaza <miguel@novell.com>
2165 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2166 code to be invoked without having to reparse.
2168 2008-09-27 Miguel de Icaza <miguel@novell.com>
2170 * ecore.cs: The recent changes to FieldExpr broke this as well.
2171 Fixes LINQ queries in the interactive shell.
2173 * Multiple files: indentation fixing for the Mono coding
2174 guidelines for the switch statement.
2176 * eval.cs: Make the Evaluator API thread safe.
2178 2008-09-26 Marek Safar <marek.safar@gmail.com>
2180 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2181 constructor parsing.
2183 2008-09-26 Marek Safar <marek.safar@gmail.com>
2185 A fix for bug #325326
2186 * statement.cs: Check possible mistaken empty statement using
2187 explicit blocks only.
2189 2008-09-25 Miguel de Icaza <miguel@novell.com>
2191 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2192 RootNamespace.ComputeNamespaces to update the internal list of
2193 namespaces, this is no longer done for us.
2195 (InteractiveBase): Use the Evaluator APIs instead of calling into
2198 2008-09-25 Marek Safar <marek.safar@gmail.com>
2200 A fix for bug #429264
2201 * expression.cs: Missing mutator for access to multidimensional
2204 2008-09-25 Marek Safar <marek.safar@gmail.com>
2206 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2209 * driver.cs: Missing input argument check.
2211 2008-09-25 Marek Safar <marek.safar@gmail.com>
2213 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2214 expression.cs, statement.cs, rootcontext.cs, class.cs,
2215 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2218 2008-09-24 Miguel de Icaza <miguel@novell.com>
2220 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2221 fully constructed FieldExpr, fixes the regression introduced in
2224 * ecore.cs, expression.cs: Plug back the eclass initialization as
2225 otherwise it regresses `csharp'.
2227 2008-09-24 Marek Safar <marek.safar@gmail.com>
2229 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2230 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2231 phase to resolve phase. It resolves problems with expression trees
2232 and fixes bugs #323796, #325156.
2234 2008-09-23 Marek Safar <marek.safar@gmail.com>
2236 * codegen.cs: Report better error when symbol writer is missing.
2238 2008-09-23 Marek Safar <marek.safar@gmail.com>
2240 * codegen.cs: Set .NET symbol writer.
2242 * decl.cs: Guard against null generic arguments.
2244 * report.cs: Don't report exactly same additional details.
2246 2008-09-22 Marek Safar <marek.safar@gmail.com>
2248 A fix for bug #324917
2249 * cs-parser.jay: Add missing multidimensional non-expression type
2252 2008-09-22 Marek Safar <marek.safar@gmail.com>
2254 A fix for bug #428191
2255 * anonymous.cs: Create an outer generic fields also for non-storey
2258 2008-09-22 Marek Safar <marek.safar@gmail.com>
2260 A fix for bug #378294
2261 * class.cs: Make fixed size buffers gmcs feature only.
2263 2008-09-22 Marek Safar <marek.safar@gmail.com>
2265 A fix for bug #355622, #324993
2266 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2269 2008-09-19 Marek Safar <marek.safar@gmail.com>
2271 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2274 2008-09-19 Marek Safar <marek.safar@gmail.com>
2276 A fix for bug #416110
2277 * generic.cs: Struct constraint results in default ctor and
2278 ValueType base type constraint to be set.
2280 2008-09-19 Marek Safar <marek.safar@gmail.com>
2282 A fix for bug #423791
2283 * generic.cs: Fixed params output type type-inference.
2285 2008-09-19 Marek Safar <marek.safar@gmail.com>
2287 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2289 2008-09-19 Marek Safar <marek.safar@gmail.com>
2291 * cs-tokenizer.cs: Don't break on extra partial modifier.
2293 2008-09-19 Marek Safar <marek.safar@gmail.com>
2295 A fix for bug #427592
2296 * generic.cs: Use common parameter resolve method.
2298 2008-09-18 Marek Safar <marek.safar@gmail.com>
2300 A fix for bug #414758
2301 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2304 2008-09-18 Marek Safar <marek.safar@gmail.com>
2306 * driver.cs, namespace.cs: Read types and namespaces after all
2307 requested assemblies are loaded, fixes issues with System.Core
2308 auto-reference, and #419888.
2310 2008-09-18 Marek Safar <marek.safar@gmail.com>
2312 A fix for bug #417705
2313 * cs-parser.jay: Fixed as/is operator expression split.
2315 2008-09-18 Marek Safar <marek.safar@gmail.com>
2317 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2318 Fixed expression tree representation of empty new expression and
2319 new initializer expression.
2321 2008-09-18 Miguel de Icaza <miguel@novell.com>
2323 * eval.cs: Remove warning, keep reference to driver around.
2325 * Hide fields that do not need to be public.
2327 2008-09-17 Marek Safar <marek.safar@gmail.com>
2329 A fix for bug #426385
2330 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2331 conversion for array elements.
2333 2008-09-17 Marek Safar <marek.safar@gmail.com>
2335 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2336 void parsing conflicts.
2338 2008-09-15 Marek Safar <marek.safar@gmail.com>
2340 A fix for bug #425601
2341 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2342 System.Core only when there is no custom ExtensionAttribute
2345 2008-09-15 Miguel de Icaza <miguel@novell.com>
2347 * namespace.cs: Do not report CS0246 (name
2349 2008-09-12 Marek Safar <marek.safar@gmail.com>
2351 A fix for bug #425669
2352 * generic.cs: Don't cache generic static anonymous method
2355 2008-09-12 Marek Safar <marek.safar@gmail.com>
2357 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2358 conflicting constraints.
2360 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2362 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2365 2008-09-12 Marek Safar <marek.safar@gmail.com>
2367 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2368 to null pointer conversion fixes.
2370 2008-09-11 Marek Safar <marek.safar@gmail.com>
2372 * cs-parser.jay, expression.cs: An implicitly typed local variable
2373 declarator cannot use an array initializer.
2375 2008-09-11 Marek Safar <marek.safar@gmail.com>
2377 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2379 2008-09-11 Marek Safar <marek.safar@gmail.com>
2381 * generic.cs (InflatedConstraints): Don't crash when constraints
2384 * cs-parser.jay: const_declarator is a block.
2386 * constant.cs: Check for not allowed NaN conversions.
2388 2008-09-10 Miguel de Icaza <miguel@novell.com>
2390 * driver.cs: Drop --shell argument, the compiler is no longer a
2393 * eval.cs: Move most of the code that deals with evaluation into
2394 this file and document the public API from repl.cs
2396 * repl.cs: Remove from here.
2398 2008-09-10 Marek Safar <marek.safar@gmail.com>
2400 A fix for bug #424684
2401 * generic.cs: Generic class constraints must come first.
2403 2008-09-09 Miguel de Icaza <miguel@novell.com>
2405 * cs-parser.jay: Improve error reporting for syntax errors in
2406 statements and expressions, we now report the expected tokens
2407 instead of reporting the useless "; expected".
2409 Drop the strings from the token declaration, it turns out that
2410 they did not do what I thought they did. Instead they were adding
2411 two sets of tokens to the tables.
2413 2008-09-09 Marek Safar <marek.safar@gmail.com>
2415 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2416 delegate.cs: Share special type check.
2418 2008-09-09 Marek Safar <marek.safar@gmail.com>
2420 A fix for bug #423981
2421 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2423 2008-09-09 Marek Safar <marek.safar@gmail.com>
2425 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2428 2008-09-09 Marek Safar <marek.safar@gmail.com>
2430 A fix for bugs: #324750, #335946
2431 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2432 lookup rule to determine ?-based tokens.
2434 2008-09-08 Miguel de Icaza <miguel@novell.com>
2436 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2437 expressions (like event adding or removing) end up here, so we
2438 need to treat those as statements.
2440 Add LoadAssembly method.
2442 2008-09-04 Miguel de Icaza <miguel@novell.com>
2444 * repl.cs: Add Time method.
2446 2008-09-05 Marek Safar <marek.safar@gmail.com>
2448 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2450 2008-09-05 Miguel de Icaza <miguel@novell.com>
2452 * repl.cs: Add workaround for old compilers.
2454 2008-09-04 Jb Evain <jbevain@novell.com>
2456 * repl.cs (PrettyPrint): pretty print everything that
2457 implements IDictionary, as well as IEnumerables. Also,
2458 add a quit helper property.
2460 2008-09-04 Marek Safar <marek.safar@gmail.com>
2462 * constant.cs: Better error reporting for decimal literals.
2464 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2467 2008-09-04 Marek Safar <marek.safar@gmail.com>
2468 Miguel de Icaza <miguel@novell.com>
2470 A fix for bug #422951
2471 * assign.cs (Assign.DoResolve): Perform the type conversions
2472 checks before we attempt to initialize `New' initializers.
2474 2008-09-04 Marek Safar <marek.safar@gmail.com>
2476 A fix for bug #422853
2477 * delegate.cs (DelegateCreation): Add special handling for
2478 EmptyExpression.Null instance expression which is just another
2479 hack for undecided member instance exression.
2481 2008-09-04 Marek Safar <marek.safar@gmail.com>
2483 * expression.cs, ecore.cs: Emit full expression tree for reduced
2486 2008-09-04 Marek Safar <marek.safar@gmail.com>
2488 * expression.cs (This): Guard against multi-resolving.
2490 * ecore.cs, statement.cs (Throw): Simplified.
2492 * flowanalysis.cs: Also verify event fields.
2494 2008-09-04 Miguel de Icaza <miguel@novell.com>
2496 * assign.cs (Assign.DoResolve): Perform the type conversions
2497 checks before we attempt to initialize `New' initializers.
2499 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2501 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2504 * repl.cs: Update help.
2506 2008-09-03 Miguel de Icaza <miguel@novell.com>
2508 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2509 handling of the default config handling, including the special
2510 treatment of System.Core assembly.
2512 Fixes the REPL processing for LINQ.
2514 2008-09-03 Marek Safar <marek.safar@gmail.com>
2516 A fix for bug #422507
2517 * expression.cs (UnboxCast): Add missing child expression mutator.
2519 2008-09-03 Marek Safar <marek.safar@gmail.com>
2521 * driver.cs: Don't self reference System.Core assembly.
2523 2008-09-03 Marek Safar <marek.safar@gmail.com>
2525 A fix for bug #422507
2526 * expression.cs (StringConcat): Add missing type mutator.
2528 2008-09-03 Marek Safar <marek.safar@gmail.com>
2530 * generic.cs (TypeInferenceContext): Follow equality rule for
2531 constructed type lower bound type inference.
2533 2008-09-02 Miguel de Icaza <miguel@novell.com>
2535 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2536 <dblank@cs.brynmawr.edu> which updates the cursor position on
2539 2008-09-02 Marek Safar <marek.safar@gmail.com>
2541 A fix for bug #367145
2542 * driver.cs: Fixed import of extension methods when using -noconfig
2545 2008-09-02 Marek Safar <marek.safar@gmail.com>
2547 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2548 version from non-generic implementation instead.
2550 2008-09-01 Marek Safar <marek.safar@gmail.com>
2552 A fix for bug #418908
2553 * class.cs: Use AddScopeStatement for field initializers.
2555 2008-09-01 Marek Safar <marek.safar@gmail.com>
2557 A fix for bug #415385
2558 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2560 2008-09-01 Marek Safar <marek.safar@gmail.com>
2562 A fix for bug #421736
2563 * iterators.cs: Don't crash on unreachable iterators.
2565 2008-09-01 Marek Safar <marek.safar@gmail.com>
2567 A fix for bug #421628
2568 * parameter.cs, attribute.cs: Clone also parameter attributes.
2570 2008-08-30 Miguel de Icaza <miguel@novell.com>
2572 * namespace.cs (LookupType): In EvalMode, try to replace
2573 the TypeBuilder from our cache with a Type as Reflection.Emit does
2574 not like to mix code from older assemblies emitted and new
2577 This sounds like a serious Mono bug that prevents multiple
2578 assemblies to be generated and consumed at the same time.
2580 * cs-parser.jay (push_current_class): Do not make interactive
2581 classes internal or private, make them public as we currently
2582 generate each new class in a new assembly.
2584 2008-08-29 Miguel de Icaza <miguel@novell.com>
2586 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2587 remove types that are entered into the global namespace during
2588 parsing so that we can remove them on failure.
2590 * cs-parser.jay: Parsing: we now keep track of types that are
2591 entered into global variables and queue those in case the parsing
2594 This happens in a few situations: during partial-input, we invoke
2595 the parser repeatedly for example with the string "class X", this
2596 would cause X to be registed, and we need to remove this
2597 registration so that another parse attempt later with say "class X {"
2598 would actually work.
2600 Additionally, if there is an error in the resolution phase, for
2601 example: "class X : NonExistant {}" th
2603 * cs-parser.jay: Be more precise with the errors being raised,
2604 instead of flagging all exceptions during parsing to be attributed
2605 to the parsing process, distinguish those from errors happening in
2606 the actions and hint that using -v would produce the actual
2609 * repl.cs: Do not load all compiler references on each reset,
2610 doing the partial reset takes care of this.
2612 2008-08-28 Miguel de Icaza <miguel@novell.com>
2614 * repl.cs: Add support for loading all the files from
2615 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
2618 Introduce a micro-parser that is able to deambiguate on its input
2619 whether we are dealing with a compilation unit (namespace, class,
2620 interface, struct, delegate) declaration or a statement. This
2621 allows both declarations and statements to be entered.
2623 Set history size by default to 300 lines.
2625 Instead of distinguishing based on the parser.InteractiveResult,
2626 have only two cases: statements were parsed, or a compilation unit
2627 was. Always pull the Using statement additions from the
2628 compilation unit parse.
2630 * cs-tokenizer.cs: Rename tokens to better describe their intent
2631 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
2633 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
2634 EvalMode is used to trigger the lookup of global variables while
2635 StatementMode is used turn variable declarations into static
2638 * getline.cs: Allow history size to be set.
2640 2008-08-29 Marek Safar <marek.safar@gmail.com>
2642 A fix for bug #360755
2643 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
2645 2008-08-29 Marek Safar <marek.safar@gmail.com>
2647 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
2649 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
2650 member name, it is too confusing
2652 * decl.cs, class.cs: Don't report unused fields with attached attribute.
2654 * rootcontext.cs: Finally default to warning level 4.
2656 2008-08-28 Marek Safar <marek.safar@gmail.com>
2658 * class.cs (CheckBase): Ignore overloaded operators.
2660 2008-08-28 Marek Safar <marek.safar@gmail.com>
2662 A fix for bug #420830
2663 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
2665 2008-08-28 Marek Safar <marek.safar@gmail.com>
2667 A fix for bug #420832
2668 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
2670 2008-08-28 Marek Safar <marek.safar@gmail.com>
2672 A fix for bug #420386
2673 * nullables.cs: Fixed logic of nullable user comparison operators involving
2676 2008-08-28 Marek Safar <marek.safar@gmail.com>
2678 * attribute (IsClsCompliant): Use FALSE value for pointer types.
2680 2008-08-27 Miguel de Icaza <miguel@novell.com>
2682 * repl.cs: Add support for aborting the running code with C-c.
2684 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
2686 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
2688 2008-08-27 Miguel de Icaza <miguel@novell.com>
2690 * cs-parser.jay (interactive_statement_list): A new set of rules
2691 for hosting statements that uses the "interactive_" prefix.
2693 * repl.cs: Add support for parsing `using' as a statement or as a
2694 directive. Deambiguating before passing this to the parser.
2696 We need to distinguish statement_expressions that occur at the
2697 toplevel vs those that occur embedded into expressions.
2699 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
2700 that fixes the cursor key handling, and a history bug.
2702 2008-08-26 Miguel de Icaza <miguel@novell.com>
2704 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
2705 limitations in Console, instead the 2.0 bootstrap libraries now
2706 include the Console bits.
2708 Also, remove the use of Nullables from getline.cs
2712 Interactive support for the C# compiler. Use gmcs --shell to
2713 enter a read-eval-print loop shell.
2715 Docs: http://www.mono-project.com/CsharpRepl
2717 * sources: include repl.cs here and getline.cs for gmcs.exe,
2718 everything else is getline.cs impaired.
2720 * Makefile: when bootstrapping pass a special flag
2721 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
2722 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
2723 This distinguishes those two cases.
2725 * repl.cs: Support for a read-eval-print loop. Will be soon
2726 refactored into eval support and then REPL on top of it.
2728 * ecore.cs: If a simplename lookup fails, before erroring out,
2729 if we are in EvalMode to resolve the name to a declaration in the
2732 This means that variable declarations that happened in previous
2733 classes (as repl puts every statement in a separate class) are
2734 made visible in this way.
2736 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
2737 triggered an error due to the end of file being reached. This is
2738 used to do multi-line input, and notify the caller that the user
2739 needs to provide more text before a successful parse.
2741 Add new grammar rules after the INTERACTIVE_PARSER token is seen
2742 to drive the evaluation with a custom wrapper.
2744 * driver.cs: Add support for --shell, and refactor some code to be
2747 * namespace.cs: Add support for serializing the contents of the
2748 namespaces and reloading them.
2750 * getline.cs: A managed implementation of ReadLine under
2751 X11/Apache2 license terms. Easy to embed in other applications as
2754 * namespace.cs: Add some functions to save and restore the
2757 * rootcontext.cs: New public field.
2759 * cs-tokenizer.cs: Add support for one of the possible characters
2760 we introduce into the token stream.
2762 This patch does not affect the regular tokenization process, the
2763 only performance hit would happen if there is an invalid character
2764 on the input string.
2766 * support.cs: Move isatty helper routine here.
2768 * codegen.cs: Small cleanup, and add a mechanism to initialize the
2769 code generator for in-memory assemblies.
2771 2008-08-26 Marek Safar <marek.safar@gmail.com>
2773 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
2774 parameter cannot be always used as a type.
2776 2008-08-21 Marek Safar <marek.safar@gmail.com>
2778 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
2780 2008-08-21 Marek Safar <marek.safar@gmail.com>
2782 * convert.cs: Implement explicit array to IList<T> conversion.
2784 2008-08-20 Marek Safar <marek.safar@gmail.com>
2786 A fix for bug #362740
2787 * cs-tokenizer.cs: Handle UTF-16 surrogates.
2789 2008-08-20 Marek Safar <marek.safar@gmail.com>
2791 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
2792 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
2793 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
2794 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
2795 handling to use just one type of infrastructure and deal with generics
2798 2008-07-23 Martin Baulig <martin@ximian.com>
2800 *** Merged this from trunk revision 108527 ***
2803 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
2804 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
2807 2008-08-15 Marek Safar <marek.safar@gmail.com>
2809 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
2812 2008-08-15 Marek Safar <marek.safar@gmail.com>
2814 * delegate.cs: Fixed compiler crash when creating delegate using partial
2817 * typemanager.cs: MulticastDelegate is not a delegate.
2819 2008-08-14 Marek Safar <marek.safar@gmail.com>
2821 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
2824 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
2826 * cs-parser.jay (type): Allow 'var' in mcs too.
2827 (local_variable_type): Likewise.
2829 2008-08-14 Marek Safar <marek.safar@gmail.com>
2831 * driver.cs: Removed broken -noconfig variants.
2833 2008-08-14 Marek Safar <marek.safar@gmail.com>
2835 A fix for bug #417078
2836 * expression.cs: Emit correctly left side pointer operators.
2838 2008-08-13 Marek Safar <marek.safar@gmail.com>
2840 * generic.cs, lambda.cs: Inflate method generic arguments only.
2842 2008-08-12 Marek Safar <marek.safar@gmail.com>
2844 * class.cs: Fixed struct layout check regression.
2846 2008-08-12 Marek Safar <marek.safar@gmail.com>
2848 * cs-parser.jay, enum.cs: Simplified enum parsing.
2850 * decl.cs: Check all type parameters conflicts.
2852 * expression.cs, statement.cs, attribute.cs: More expression checks.
2854 2008-08-11 Marek Safar <marek.safar@gmail.com>
2856 * generic.cs: Add type inference types restriction.
2858 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
2859 anonymous.cs, expression.cs: Allocate less accessor parameters.
2861 2008-08-08 Marek Safar <marek.safar@gmail.com>
2863 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
2866 2008-08-08 Marek Safar <marek.safar@gmail.com>
2868 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
2870 2008-08-07 Marek Safar <marek.safar@gmail.com>
2872 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
2873 Also fixes #362146 and #381592.
2875 2008-08-07 Marek Safar <marek.safar@gmail.com>
2877 * ecore.cs: Reduced constant cannot be used as an attribute value.
2879 * cs-parser.jay: Base expression has to be a type.
2881 * expression.cs (Conditional): Uses ReducedExpression.
2883 2008-08-06 Marek Safar <marek.safar@gmail.com>
2885 A fix for bug #376826
2886 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
2887 address of hoisted local variable or parameter cannot be taken.
2889 2008-08-05 Marek Safar <marek.safar@gmail.com>
2891 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
2892 anonymous method inside checked/unchecked expression.
2894 2008-08-05 Marek Safar <marek.safar@gmail.com>
2896 * typemanager.cs (IsEqual): Guard against null.
2898 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
2899 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
2900 routine. Fixed few misleading conversion errors.
2902 2008-08-04 Marek Safar <marek.safar@gmail.com>
2904 * class.cs: Consider generics when checking cycles in struct layout.
2906 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
2908 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
2910 2008-08-04 Marek Safar <marek.safar@gmail.com>
2912 A fix for bug #414165
2913 * anonymous.cs: Use same anonymous implementation method for all anonymous
2916 2008-08-04 Marek Safar <marek.safar@gmail.com>
2918 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
2921 2008-08-04 Marek Safar <marek.safar@gmail.com>
2923 * cs-parser.jay: Typeof argument has to be a type expression.
2925 * namespace.cs: Check alias and namespace definitions collisions.
2927 * class.cs, pending.cs: Moved explicit interface accessor implementation
2930 * delegate.cs, expression.cs: Verify special name invocations.
2932 2008-08-01 Marek Safar <marek.safar@gmail.com>
2934 * cs-parser.jay: Don't choke on empty generic type arguments.
2936 * cs-tokenizer.cs: Handle escaped preprocessor directives.
2938 * expression.cs, ecore.cs: Minor expressions bugs.
2940 2008-08-01 Marek Safar <marek.safar@gmail.com>
2942 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
2943 and added more error handling.
2945 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
2947 * modifiers.cs, enum.cs: Fixed.
2949 2008-07-31 Jb Evain <jbevain@novell.com>
2951 * driver.cs: remove -pkg ability of smcs.
2953 2008-07-30 Marek Safar <marek.safar@gmail.com>
2955 * statement.cs (Switch): Correctly set empty default target for single
2958 2008-07-30 Marek Safar <marek.safar@gmail.com>
2960 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
2961 string switch statement implementation to use string dictionary which
2962 significantly (2-8x) improves performance of generated code.
2964 2008-07-29 Marek Safar <marek.safar@gmail.com>
2966 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
2967 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
2969 2008-07-29 Marek Safar <marek.safar@gmail.com>
2971 A fix for bug #412595
2972 * typemanager.cs, convert.cs, expression.cs: Some types are never
2973 convertible to each other.
2975 2008-07-29 Marek Safar <marek.safar@gmail.com>
2977 * nullable.cs (CreateNullConstant): An error messages update.
2979 2008-07-29 Marek Safar <marek.safar@gmail.com>
2981 A fix for bug #412595
2982 * cfold.cs: Don't cast undefined bool constant.
2984 2008-07-29 Martin Baulig <martin@ximian.com>
2987 (SymbolWriter.Reset): New public static method.
2990 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
2992 2008-07-28 Marek Safar <marek.safar@gmail.com>
2994 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
2996 * expression.cs (ElementAccess): Exact size allocation.
2998 2008-07-26 Marek Safar <marek.safar@gmail.com>
3000 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3002 2008-07-25 Marek Safar <marek.safar@gmail.com>
3004 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3006 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3009 2008-07-25 Marek Safar <marek.safar@gmail.com>
3011 A fix for bug #412217
3012 * assign.cs: Mutate also assignment type.
3014 2008-07-25 Marek Safar <marek.safar@gmail.com>
3016 A fix for bug #323644
3017 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3020 2008-07-25 Marek Safar <marek.safar@gmail.com>
3022 A fix for bug #412134
3023 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3024 non-enumerable operands when overloading equality or bitwise operators.
3026 2008-07-25 Marek Safar <marek.safar@gmail.com>
3028 * anonymous.cs: Cache closed generic anonymous method delegates.
3030 2008-07-24 Marek Safar <marek.safar@gmail.com>
3032 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3033 anonymous.cs, statement.cs: Always emit anonymous method as static method
3034 when is instance free. Use nesting for nested anynomous methods blocks.
3036 2008-07-23 Marek Safar <marek.safar@gmail.com>
3038 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3041 2008-07-23 Marek Safar <marek.safar@gmail.com>
3043 * expression.cs: Removed MakeSimpleCall.
3045 2008-07-23 Marek Safar <marek.safar@gmail.com>
3047 A fix for bug #323012
3048 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3049 Base method implementing interface has to be public.
3051 2008-07-23 Marek Safar <marek.safar@gmail.com>
3053 * cs-parser.jay: Don't break on missing argument.
3055 2008-07-22 Marek Safar <marek.safar@gmail.com>
3057 A fix for bug #320993
3058 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3059 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3061 2008-07-22 Marek Safar <marek.safar@gmail.com>
3063 A fix for bug #320748
3064 * convert.cs: Implicit user operators cannot convert to interfaces
3066 2008-07-22 Marek Safar <marek.safar@gmail.com>
3068 A fix for bug #312686
3069 * driver.cs: Ignore empty assembly references.
3071 2008-07-22 Marek Safar <marek.safar@gmail.com>
3073 A fix for bug #387040
3074 * ecore.cs: Skip constrains check for an explicit implementation.
3076 2008-07-21 Marek Safar <marek.safar@gmail.com>
3078 A fix for bug #409045
3079 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3080 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3081 identifiers are file specific unless passed as input arguments.
3083 2008-07-21 Marek Safar <marek.safar@gmail.com>
3085 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3086 to emit UnmanagedMarshal data under 2.0 profile.
3088 2008-07-21 Marek Safar <marek.safar@gmail.com>
3090 A fix for bug #410369
3091 * parameter.cs: Clone correctly ParamsParameter.
3093 2008-07-21 Marek Safar <marek.safar@gmail.com>
3095 * expression.cs (Argument): Always report type for type based expressions
3098 2008-07-18 Marek Safar <marek.safar@gmail.com>
3100 A fix for bug #410666
3101 * anonymous.cs: Correctly initialize generic storey reference.
3103 2008-07-18 Marek Safar <marek.safar@gmail.com>
3105 * convert.cs: Don't box same type arguments.
3107 2008-07-18 Marek Safar <marek.safar@gmail.com>
3109 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3110 Finished missing generic type mutators.
3112 2008-07-18 Marek Safar <marek.safar@gmail.com>
3114 * iterators.cs, statement.cs: Finished statements CloneTo.
3116 2008-07-18 Marek Safar <marek.safar@gmail.com>
3118 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3120 * expression.cs: Emit optimized default value expressions in expression tree
3123 2008-07-18 Marek Safar <marek.safar@gmail.com>
3125 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3127 2008-07-17 Marek Safar <marek.safar@gmail.com>
3129 A fix for bug #367536
3130 * cs-parser.jay: Check static constructor of generic types for an access
3133 2008-07-17 Marek Safar <marek.safar@gmail.com>
3135 A fix for bug #353800
3136 * lambda.cs: Emit ret for contextual statements.
3138 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3139 up emitting redundant ret for all anonymous methods with return.
3141 2008-07-17 Marek Safar <marek.safar@gmail.com>
3143 A fix for bug #365188
3144 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3145 create anonymous method storey in unreachable block.
3147 2008-07-17 Marek Safar <marek.safar@gmail.com>
3149 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3150 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3151 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3152 statement.cs: Fixed relevant defects found by Gendarme.
3154 2008-07-17 Marek Safar <marek.safar@gmail.com>
3156 A fix for bug #325291
3157 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3158 statement.cs: Replaced IAnonymousHost with top level block flag.
3160 2008-07-17 Marek Safar <marek.safar@gmail.com>
3162 * cs-parser.jay: Clean up unused open_parens.
3164 2008-07-17 Marek Safar <marek.safar@gmail.com>
3166 * ecore.cs: Custom error message for a range variable assignment.
3168 2008-07-16 Marek Safar <marek.safar@gmail.com>
3170 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3173 2008-07-16 Marek Safar <marek.safar@gmail.com>
3175 * literal.cs: Null literal is of object type.
3177 2008-07-16 Marek Safar <marek.safar@gmail.com>
3179 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3180 expression of nullable equality comparison.
3182 2008-07-15 Marek Safar <marek.safar@gmail.com>
3184 * expression.cs(PointerArithmetic): Removed redundant assignment.
3186 2008-07-15 Marek Safar <marek.safar@gmail.com>
3188 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3190 2008-07-14 Marek Safar <marek.safar@gmail.com>
3192 A fix for bug #408361
3193 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3194 they are replaced by GetMethod.
3196 2008-07-14 Marek Safar <marek.safar@gmail.com>
3198 A fix for bug #408721 by jeremie.laval@gmail.com
3199 * expression.cs (Indirection): Implemented CloneTo.
3201 2008-07-14 Marek Safar <marek.safar@gmail.com>
3203 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3206 2008-07-14 Marek Safar <marek.safar@gmail.com>
3208 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3210 2008-07-11 Marek Safar <marek.safar@gmail.com>
3212 * linq.cs: Reset tranparent parameter counter in probing mode.
3214 2008-07-11 Marek Safar <marek.safar@gmail.com>
3216 * anonymous.cs: Mutate anonymous method type.
3218 2008-07-11 Marek Safar <marek.safar@gmail.com>
3220 * ecore.cs, anonymous.cs: Mutate field expressions.
3222 2008-07-10 Marek Safar <marek.safar@gmail.com>
3224 A fix for bug #369670
3225 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3227 2008-07-10 Marek Safar <marek.safar@gmail.com>
3229 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3231 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3234 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3235 only one '>', and finds a '>>', abort the generic lookahead.
3237 2008-07-10 Marek Safar <marek.safar@gmail.com>
3239 A fix for bug #319902
3240 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3242 2008-07-10 Marek Safar <marek.safar@gmail.com>
3244 A fix for bug #406371
3245 * statement.cs: Moved EmitSymbolInfo to Block.
3247 2008-07-09 Marek Safar <marek.safar@gmail.com>
3249 * ecore.cs: Report better error for extension method overload failures.
3251 2008-07-09 Marek Safar <marek.safar@gmail.com>
3253 * expression.cs (Is): No need to box reference values.
3255 2008-07-09 Marek Safar <marek.safar@gmail.com>
3257 * class.cs: Use event resolve context when initializing CreateEmitContext.
3259 2008-07-09 Marek Safar <marek.safar@gmail.com>
3261 A fix for bug #394436
3262 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3263 method used inside expression trees. Added more LINQ to expression tree
3266 2008-07-08 Marek Safar <marek.safar@gmail.com>
3268 A fix for bug #378189, #370577
3269 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3272 2008-07-08 Marek Safar <marek.safar@gmail.com>
3274 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3277 2008-07-08 Marek Safar <marek.safar@gmail.com>
3279 A fix for bug #406702
3280 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3282 2008-07-07 Marek Safar <marek.safar@gmail.com>
3284 A fix for bug #406648
3285 * cs-parser.jay: Report nullable use in mcs for some cases.
3287 2008-07-07 Marek Safar <marek.safar@gmail.com>
3289 * ecore.cs: Improved argument mismatch error messages.
3291 2008-07-07 Marek Safar <marek.safar@gmail.com>
3293 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3295 2008-07-07 Marek Safar <marek.safar@gmail.com>
3297 * expression.cs (TypeOf): Mutate type argument.
3299 2008-07-04 Marek Safar <marek.safar@gmail.com>
3301 * class.cs: Report missing partial modifier for correct type.
3303 2008-07-04 Marek Safar <marek.safar@gmail.com>
3305 * ecore.cs, expression.cs (VariableReference): Variable property is
3308 2008-07-04 Marek Safar <marek.safar@gmail.com>
3310 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3312 2008-07-04 Marek Safar <marek.safar@gmail.com>
3314 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3317 2008-07-04 Marek Safar <marek.safar@gmail.com>
3319 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3320 anonymous method storey to an instance method when only "this" is hoisted.
3322 2008-07-03 Marek Safar <marek.safar@gmail.com>
3324 A fix for bug #321615
3325 * expression.cs: Pointer comparisons use unsigned operator.
3327 2008-07-03 Marek Safar <marek.safar@gmail.com>
3329 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3331 2008-07-02 Marek Safar <marek.safar@gmail.com>
3333 A fix for bug #404905
3334 * class.cs: Always initialize local unsafe variables.
3336 2008-06-30 Marek Safar <marek.safar@gmail.com>
3338 A fix for bug #396987
3339 * expression.cs (NewInitialize): Clear local temporary variable for next run
3341 2008-06-27 Marek Safar <marek.safar@gmail.com>
3343 A fix for bug #401020
3344 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3346 2008-06-27 Marek Safar <marek.safar@gmail.com>
3348 A fix for bug #398319
3349 * cs-parser.jay: Implemented undocumented base access expression inside
3352 2008-06-26 Marek Safar <marek.safar@gmail.com>
3354 A fix for bug #404227
3355 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3357 2008-06-26 Marek Safar <marek.safar@gmail.com>
3359 A fix for bug #404227
3360 * convert.cs: Fixed explicit array to interface cast.
3362 2008-06-26 Marek Safar <marek.safar@gmail.com>
3364 A fix for bug #403894
3365 * delegate.cs: Mutate DelegateInvocation type.
3367 2008-06-26 Marek Safar <marek.safar@gmail.com>
3369 A fix for bug #379348
3370 * delegate.cs: Box a load of generic parameters.
3372 2008-06-26 Marek Safar <marek.safar@gmail.com>
3374 * expression.cs: Add an array creation arguments mutate.
3376 2008-06-26 Marek Safar <marek.safar@gmail.com>
3378 A fix for bug #386068
3379 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3382 2008-06-25 Marek Safar <marek.safar@gmail.com>
3384 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3387 2008-06-25 Marek Safar <marek.safar@gmail.com>
3389 A fix for bug #403518
3390 * delegate.cs: Type correctly anonymous method new invocation.
3392 2008-06-24 Marek Safar <marek.safar@gmail.com>
3394 A fix for bug #394826
3395 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3398 2008-06-24 Marek Safar <marek.safar@gmail.com>
3400 A fix for bug #394826
3401 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3404 2008-06-24 Marek Safar <marek.safar@gmail.com>
3406 * class.cs: Clone indexer parameters for localized capturing.
3408 2008-06-24 Marek Safar <marek.safar@gmail.com>
3410 A fix for bug #402379
3411 * expression.cs: Don't crash when an object initializer resolve fails.
3413 2008-06-24 Marek Safar <marek.safar@gmail.com>
3415 A fix for bug #402888
3416 * expression.cs: Mutate conditional expression.
3418 2008-06-24 Marek Safar <marek.safar@gmail.com>
3420 A fix for bug #401012
3421 * class.cs: Keep StructLayout in shared container.
3423 2008-06-24 Marek Safar <marek.safar@gmail.com>
3425 A fix for bug #400438
3426 * decl.cs, class.cs: Only properties can be automatically implemented.
3428 2008-06-24 Marek Safar <marek.safar@gmail.com>
3430 * statement.cs (ChangeToIterator): Copy also labels.
3432 2008-06-23 Marek Safar <marek.safar@gmail.com>
3434 * ecore.cs: Pass type argument details to parent extension method.
3436 2008-06-23 Marek Safar <marek.safar@gmail.com>
3438 A fix for bug #375966
3439 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3441 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3443 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3445 2008-06-22 Marek Safar <marek.safar@gmail.com>
3447 A fix for bug #394347
3448 * anonymous.cs: Cache compatible delegates as compatibility check produces
3449 a new method every time.
3451 2008-06-20 Marek Safar <marek.safar@gmail.com>
3453 * anonymous.cs: Propagate storey reference for single references.
3455 2008-06-20 Marek Safar <marek.safar@gmail.com>
3457 A fix for bug #387615
3458 * assign.cs, expression.cs: Correctly clone compound assignment.
3460 2008-06-19 Marek Safar <marek.safar@gmail.com>
3462 A fix for bug #359611, #359604
3463 * anonymous.cs: Mutate all types of hoisted parameters.
3465 2008-06-19 Marek Safar <marek.safar@gmail.com>
3467 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3468 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3469 expression.cs, codegen.cs, statement.cs
3471 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3472 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3474 ** Anonymous methods, lambda expressions rewrite **
3476 Anonymous expressions are now resolved when an explicit block is resolved
3477 and they don't require any registration procedure anymore. Further,
3478 anonymous methods are defined when explicit block is emitted which allows
3479 better control of whole process and opens possibilities for more
3480 optimizations as well as alternative to reverse whole process.
3482 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3483 process consistent and to correctly emit hoisted generic methods when they
3484 have at least 1 hoisted variable.
3486 2008-06-17 Martin Baulig <martin@ximian.com>
3488 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3490 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3491 virtual property; check it in Emit().
3492 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3494 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3496 (Indexer.Define): Likewise.
3498 2008-06-17 Marek Safar <marek.safar@gmail.com>
3500 * convert.cs: Don't use IsInterface on type arguments.
3502 * delegate.cs: DelegateInvocation uses MethodInfo.
3504 * parameter.cs: Removed IsTypeParameter.
3506 * generic-mcs.cs: More missing stuff.
3508 2008-06-16 Martin Baulig <martin@ximian.com>
3511 (Modifiers.DEBUGGER_HIDDEN): New public const.
3514 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3517 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3518 (AbstractPropertyEventMethod): Likewise.
3519 (Constructor.Emit): Likewise.
3520 (SourceMethod.SetCompilerGenerated): Removed.
3522 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3526 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3527 if we're an `IteratorHost'.
3528 (AnonymousMethodMethod..ctor): Don't set
3529 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3532 2008-06-16 Marek Safar <marek.safar@gmail.com>
3534 * statement.cs: Clean-up foreach statements.
3536 2008-06-12 Marek Safar <marek.safar@gmail.com>
3538 * class.cs: Stop using public method which should not exist
3539 (MethodBuilder.SetGenericMethodSignature).
3541 2008-06-11 Martin Baulig <martin@ximian.com>
3544 (Location.LookupFile): Add `CompilationUnit' argument; when given
3545 a relative file name, make it relative to the directory the .cs
3546 file is located in instead of using the current directory.
3548 2008-06-11 Martin Baulig <martin@ximian.com>
3551 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3552 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3553 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3554 (SourceMethod.SetCompilerGenerated): Likewise.
3556 2008-06-11 Marek Safar <marek.safar@gmail.com>
3558 * codegen.cs, driver: Only write symbol file when it's asked for.
3560 2008-06-11 Marek Safar <marek.safar@gmail.com>
3562 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3564 2008-06-10 Martin Baulig <martin@ximian.com>
3566 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3568 2008-06-09 Marek Safar <marek.safar@gmail.com>
3570 A fix for bug #316290
3571 * expression.cs: Include decimal operators in predefined table.
3573 * parameters.cs: More readonlyness.
3575 2008-06-09 Marek Safar <marek.safar@gmail.com>
3577 A fix for bug #397213
3578 * cs-parser.jay: One more missing current_local_parameters reset.
3580 2008-06-09 Marek Safar <marek.safar@gmail.com>
3582 A fix for bug #396633
3583 * class.cs: Host backing field in partial container.
3585 2008-06-09 Marek Safar <marek.safar@gmail.com>
3587 A fix for bug #397068
3588 * expression.cs: Check both operand types when predefined operator is used.
3590 2008-06-05 Martin Baulig <martin@ximian.com>
3592 Merged the `debugger-kahalo' branch.
3595 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3596 we're an iterator method.
3597 (SourceMethod): Reflect latest symbol writer changes;
3598 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
3599 now `start_row' and `end_row'.
3600 (Constructor.Emit): Fix the logic whether to emit symbol information.
3602 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
3606 (CompilationUnit): New public class; derives from `SourceFile'.
3607 (SourceFileEntry.DefineSymbolInfo): New public method.
3608 (SourceFileEntry.SetChecksum): New public method.
3609 (Location): Encode hidden line numbers by using `column == 255';
3610 the .ctor now accepts `column == -1' to mark a hidden line number.
3611 (Location.Hidden): New public property.
3612 (Location.CheckPoint): Add `CompilationUnit'.
3613 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
3614 (Location.Push): Add `CompilationUnit compile_unit' argument.
3615 (Location.CompilationUnit): New public property.
3618 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
3620 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
3622 * driver.cs: `SourceFile' -> `CompilationUnit'.
3624 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
3626 * namespace.cs: `SourceFile' -> `CompilationUnit'.
3628 * cs-tokenizer.cs: Add support for `#pragma checksum' and
3632 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
3633 new symbol writer API to also pass the file.
3635 2008-06-05 Marek Safar <marek.safar@gmail.com>
3637 * statement.cs: Emit catch variable assignment using variable expression.
3639 2008-06-05 Marek Safar <marek.safar@gmail.com>
3641 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
3642 with other variable types.
3644 2008-06-04 Marek Safar <marek.safar@gmail.com>
3646 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
3647 GetLength method emit, it breaks resolve rules.
3649 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
3650 Marek Safar <marek.safar@gmail.com>
3652 A fix for bug #395542
3653 * cs-parser.jay: The trailing comma is allowed in anonymous type member
3656 2008-06-02 Marek Safar <marek.safar@gmail.com>
3658 A fix for bug #395287
3659 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
3661 2008-05-31 Marek Safar <marek.safar@gmail.com>
3663 A fix for bug #395845
3664 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
3665 non-nullable parameter type.
3667 2008-05-31 Marek Safar <marek.safar@gmail.com>
3669 * class.cs: Handle contructor initializer as a statement in top-level block.
3671 2008-05-30 Marek Safar <marek.safar@gmail.com>
3673 * attribute.cs: Don't mix old and new corlib types when emitting corlib
3674 security attributes.
3676 2008-05-24 Marek Safar <marek.safar@gmail.com>
3678 * ecore.cs, expression.cs: Small IVariable refactoring.
3680 2008-05-22 Marek Safar <marek.safar@gmail.com>
3682 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
3684 2008-05-21 Marek Safar <marek.safar@gmail.com>
3686 * cs-parser.jay: Removed redundant catch type check.
3688 2008-05-21 Marek Safar <marek.safar@gmail.com>
3690 A fix for bug #390372
3691 * nullable.cs: Set correct return type.
3693 2008-05-21 Marek Safar <marek.safar@gmail.com>
3695 A fix for bug #391062
3696 * typemanager.cs: Fixed crash when comparing null types.
3698 2008-05-21 Marek Safar <marek.safar@gmail.com>
3700 A fix for bug #391871
3701 * cs-parser.jay: Better error handling for invalid catch type.
3703 2008-05-20 Marek Safar <marek.safar@gmail.com>
3705 A fix for bug #392155
3706 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
3708 2008-05-15 Marek Safar <marek.safar@gmail.com>
3710 A fix for bug #390666
3711 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
3714 2008-05-15 Marek Safar <marek.safar@gmail.com>
3716 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
3719 2008-05-13 Marek Safar <marek.safar@gmail.com>
3721 A fix for bug #389625
3722 * delegate.cs, generic.cs: Some progress on method group return type
3725 2008-05-13 Marek Safar <marek.safar@gmail.com>
3727 A fix for bug #378419
3728 * namespace.cs: Inspect also parent namespaces not only namespace entries.
3730 2008-05-12 Marek Safar <marek.safar@gmail.com>
3732 * class.cs (Constructor): Added IsCompilerGenerated.
3734 2008-05-12 Marek Safar <marek.safar@gmail.com>
3736 * expression.cs: Enum binary operators can accept non-enum operand only when
3737 is implicitly convertible to underlying type.
3739 2008-05-12 Marek Safar <marek.safar@gmail.com>
3741 A fix for bug #389272
3742 * support.cs: Workaround System.InvalidOperationException for enums.
3744 2008-05-12 Marek Safar <marek.safar@gmail.com>
3746 A fix for bug #389073
3747 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
3749 2008-05-10 Marek Safar <marek.safar@gmail.com>
3751 * driver.cs: Split Parse.
3753 * location.cs (LookupFile): Uses string.Empty.
3755 2008-05-07 Marek Safar <marek.safar@gmail.com>
3757 * expression.cs, parameter.cs: Small ParameterReference clean up.
3759 2008-05-07 Marek Safar <marek.safar@gmail.com>
3761 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
3762 hack. Fixes #387502.
3764 2008-05-06 Martin Baulig <martin@ximian.com>
3766 * class.cs (Constructor.Emit): Fix the logic whether to emit
3769 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
3772 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
3773 InvalidOperationException when the iterator is before the start or
3776 2008-05-06 Marek Safar <marek.safar@gmail.com>
3778 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
3779 when left is nullable type.
3781 2008-05-06 Marek Safar <marek.safar@gmail.com>
3783 A fix for bug #386628
3784 * expression.cs (LocalVariableReference): Continue in resolving when
3785 variable is not assigned.
3787 2008-05-05 Marek Safar <marek.safar@gmail.com>
3789 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
3790 nullable operations.
3792 2008-05-04 Marek Safar <marek.safar@gmail.com>
3794 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
3795 it saves many redundant temporary variables for nullable operations.
3797 2008-05-03 Marek Safar <marek.safar@gmail.com>
3799 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
3801 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
3804 * nullable.cs: Constant coalescing operator optimizations.
3806 2008-05-03 Marek Safar <marek.safar@gmail.com>
3808 * constant.cs: Use unsigned conversion for values which are unsigned only.
3810 2008-05-03 Marek Safar <marek.safar@gmail.com>
3812 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
3813 coalescing operator as it should be.
3815 2008-05-02 Marek Safar <marek.safar@gmail.com>
3817 A fix for bug #371016
3818 * expression.cs: All predefined delegate operators require implicit method
3821 2008-05-02 Marek Safar <marek.safar@gmail.com>
3823 * constant.cs: Emit long constant as uint when fits the range.
3825 * convert.cs, expression.cs: Fixed few unsafe conversions.
3827 2008-05-02 Marek Safar <marek.safar@gmail.com>
3829 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
3831 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
3834 * convert.cs (ImplicitNumericConversion): Don't modify the type of
3836 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
3838 2008-05-01 Marek Safar <marek.safar@gmail.com>
3840 * constant.cs, literal.cs: IsLiteral property for error reporting.
3842 * ecore.cs, expression.cs: Implemented Property expression.
3844 2008-05-01 Marek Safar <marek.safar@gmail.com>
3846 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
3848 * nullable.cs: Implemented nullable coalescing null operator.
3850 * ecore.cs, expression.cs: Expression trees work.
3852 2008-05-01 Marek Safar <marek.safar@gmail.com>
3854 * ecore.cs: CreateExpressionTree is finally abstract.
3856 * expression.cs, linq.cs: Updated.
3858 2008-05-01 Marek Safar <marek.safar@gmail.com>
3860 * expression.cs, ecore.cs: Block base access expression inside expression
3863 2008-05-01 Marek Safar <marek.safar@gmail.com>
3865 A fix for bug #385058
3866 * expression.cs: User-defined operator implementations always take
3867 precedence over predefined operator implementations.
3869 2008-04-30 Marek Safar <marek.safar@gmail.com>
3871 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
3872 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
3873 expression tree conversions.
3875 2008-04-30 Marek Safar <marek.safar@gmail.com>
3877 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
3878 operators method details to Operator class.
3880 2008-04-30 Marek Safar <marek.safar@gmail.com>
3882 * anonymous.cs: Pass unsafe flags to anonymous container.
3884 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
3885 inside expression tree.
3887 2008-04-29 Martin Baulig <martin@ximian.com>
3889 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
3890 (Tokenizer.PopPosition): Also restore the `line'.
3892 2008-04-29 Marek Safar <marek.safar@gmail.com>
3894 * delegate.cs: Implemented Invoke expression.
3896 2008-04-29 Marek Safar <marek.safar@gmail.com>
3898 * expression.cs: Fixed equality reference comparison regression.
3900 2008-04-29 Marek Safar <marek.safar@gmail.com>
3902 * ecore.cs: Clean up EmptyCast hack.
3904 * expression.cs, nullable.cs: Implemented enum binary and unary operations
3905 using correct conversion rules. Also fixes #383993.
3907 2008-04-28 Martin Baulig <martin@ximian.com>
3909 * class.cs (Constructor.Emit): Don't emit debugging information
3910 for generated default .ctor's.
3912 2008-04-28 Marek Safar <marek.safar@gmail.com>
3914 * convert.cs: Empty-cast ushort to int conversion.
3916 2008-04-28 Marek Safar <marek.safar@gmail.com>
3918 A fix for bug #384191
3919 * ecore.cs, expression.cs: Fixed expression cloning.
3921 2008-04-28 Marek Safar <marek.safar@gmail.com>
3923 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
3925 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
3927 Fix #381559, test-638.cs, test-639.cs
3928 * assign.cs (CompoundAssign.Helper): New wrapper.
3929 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
3931 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
3932 Pass unconverted expressions to the params array creation expression.
3933 (FieldExpr.EmitAssign): Don't special-case StringConcat.
3934 (PropertyExpr.EmitAssign): Likewise.
3935 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
3936 element if it is of kind CompoundAssign.Helper.
3937 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
3938 first before anything else.
3939 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
3940 (ArrayAccess.LoadArrayAndArguments): Simplify.
3942 2008-04-27 Marek Safar <marek.safar@gmail.com>
3944 * expression.cs: Fixed cloning of typeof(void).
3946 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
3948 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
3949 (Assign.Emit): Likewise. Move it to ...
3950 (CompoundAssign.DoResolve): ... here and ...
3951 (CompoundAssign.Emit): ... here.
3952 (EventAddOrRemove): New helper to handle += and -= on events, and
3953 avoid the use of BinaryDelegates.
3954 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
3955 (EventExpr.EmitAddOrRemove): Improve.
3956 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
3958 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
3959 create VarExprs for 'foo.bar.var'.
3960 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
3961 is a highly inappropriate name for its functionality.
3963 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3965 Simplify handling of multiple assignments
3966 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
3968 (SimpleAssign): New. Class to be used for normal assignments.
3969 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
3970 * expression.cs, parameter.cs, statement.cs: Likewise.
3972 2008-04-25 Marek Safar <marek.safar@gmail.com>
3974 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
3975 for incompatible underlying types, more to come, uff.
3977 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
3980 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
3981 Handle 'leave_copy'.
3983 2008-04-25 Marek Safar <marek.safar@gmail.com>
3985 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
3987 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
3989 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
3990 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
3991 * statement.cs (While, Do, For): Allow test to have side effects.
3992 (For.DoEmit): Always emit InitStatement.
3995 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
3996 Always create SideEffectConstant.
3997 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
3998 of type EnumConstant.
4000 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4001 Handle 'right' being SideEffectConstant of type 'bool'.
4003 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4004 Use left.EmitBranchable instead of open coding it, so as to
4005 improve optimization opportunities.
4007 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4009 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4011 (Expression.EmitSideEffect): Document.
4013 2008-04-23 Marek Safar <marek.safar@gmail.com>
4015 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4017 2008-04-23 Marek Safar <marek.safar@gmail.com>
4019 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4021 2008-04-23 Marek Safar <marek.safar@gmail.com>
4023 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4024 conversion to expression tree.
4026 2008-04-23 Marek Safar <marek.safar@gmail.com>
4028 * ecore.cs: Removed unused expression.
4030 2008-04-22 Marek Safar <marek.safar@gmail.com>
4032 * expression.cs: Implemented NegateChecked and New expressions.
4034 2008-04-22 Marek Safar <marek.safar@gmail.com>
4036 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4038 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4041 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4042 needing final 'ret' instruction.
4044 2008-04-22 Marek Safar <marek.safar@gmail.com>
4046 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4048 2008-04-21 Marek Safar <marek.safar@gmail.com>
4050 * expression.cs: Emit ldnull and not null expression as an instance argument
4051 of static method expression calls.
4053 2008-04-21 Marek Safar <marek.safar@gmail.com>
4055 A fix for bug #378200
4056 * expression.cs: Fixed crash when creating parameterless expression tree
4059 2008-04-21 Marek Safar <marek.safar@gmail.com>
4061 A fix for bug #375297
4062 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4065 2008-04-21 Marek Safar <marek.safar@gmail.com>
4067 A fix for bug #377596
4068 * decl.cs, class.cs: Emit delegate type argument attributes.
4070 2008-04-21 Marek Safar <marek.safar@gmail.com>
4072 A fix for bug #365314
4073 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4075 2008-04-21 Marek Safar <marek.safar@gmail.com>
4077 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4080 2008-04-21 Marek Safar <marek.safar@gmail.com>
4082 * generic.cs (TypeParameter): Removed redundant location.
4084 2008-04-19 Marek Safar <marek.safar@gmail.com>
4086 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4087 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4088 FullNamedExpression in all declaration type expression, statements will come
4091 2008-04-18 Marek Safar <marek.safar@gmail.com>
4093 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4094 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4096 2008-04-18 Marek Safar <marek.safar@gmail.com>
4098 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4101 2008-04-17 Marek Safar <marek.safar@gmail.com>
4103 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4106 2008-04-17 Marek Safar <marek.safar@gmail.com>
4108 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4112 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4114 Hook up 'EmitSideEffect'
4115 * constant.cs (Constant.EmitSideEffect): New.
4116 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4117 (SideEffectConstant.EmitSideEffect): New.
4118 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4119 unconditional branch in EmitBranchable.
4120 (FieldExpr.EmitBranchable): New.
4121 * expression.cs (Unary.EmitSideEffect): New.
4122 (Binary.EmitSideEffect): New.
4123 (VariableReference.EmitSideEffect): New. Do nothing.
4125 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4127 Introduce 'EmitSideEffect'
4128 * ecore.cs (Expression.EmitSideEffect): New.
4129 (TypeCast): Rename from EmptyCast.
4131 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4132 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4133 * convert.cs, nullable.cs: Update to changes.
4135 2008-04-16 Marek Safar <marek.safar@gmail.com>
4137 * class.cs, cs-parser.jay: Early check for base types expression.
4139 2008-04-16 Marek Safar <marek.safar@gmail.com>
4141 * decl.cs (MemberName): Declare PrettyName as obsolete.
4143 2008-04-16 Marek Safar <marek.safar@gmail.com>
4145 * namespace.cs: Use MemberName comparison.
4147 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4150 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4152 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4153 (MemberName.FullyQualifiedName): New. Provides the functionality
4154 that users assume FullName would have.
4155 * ecore.cs, namespace.cs: Update to changes.
4157 * statement.cs (Using.assign): Make into ExpressionStatement.
4158 (Using.EmitPreTryBody): Simplify.
4160 2008-04-16 Marek Safar <marek.safar@gmail.com>
4162 * report.cs: ColorFormat is protected.
4164 * rootcontext.cs: Unused fields clean-up.
4166 * namespace.cs: Made UsingEntry name private.
4168 2008-04-16 Marek Safar <marek.safar@gmail.com>
4170 * cs-tokenizer.cs, location.cs: Removed unused field.
4172 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4173 Raja R Harinath <harinath@hurrynot.org>
4176 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4177 (SideEffectConstant.side_effect): Rename from 'right'.
4178 (SideEffectConstant..ctor): Normalize 'side_effect'.
4179 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4180 value of this constant.
4181 * cfold.cs: Update to changes.
4183 2008-04-15 Marek Safar <marek.safar@gmail.com>
4185 * cs-paser.jay: Removed unused variable.
4187 * driver.cs: Made Compile instance method.
4189 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4191 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4193 2008-04-15 Marek Safar <marek.safar@gmail.com>
4195 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4197 2008-04-13 Jb Evain <jbevain@novell.com>
4199 * namespace.cs: update the System.Core fullname for 2.1
4200 * driver.cs: update the list of required assemblies for 2.1.
4201 Merged from the Moonlight 2 branch.
4203 2008-04-11 Marek Safar <marek.safar@gmail.com>
4205 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4206 types and user defined operators. User operators arguments has to be checked
4207 for null value before invocation, which also means no operator is called
4208 when any argument is not convertible to unwrapped nullable type.
4210 2008-04-09 Marek Safar <marek.safar@gmail.com>
4212 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4213 of Unary expressions to follow operator overloading rules precisely.
4214 Also fixes #321794, #323794
4216 2008-04-08 Marek Safar <marek.safar@gmail.com>
4218 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4221 2008-04-08 Marek Safar <marek.safar@gmail.com>
4223 * expression.cs, ecore.cs: Implemented MemberInit expression.
4225 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4227 Fix mono/tests/exception4.cs
4228 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4229 ec.NeedReturnLabel () rather emitting a 'nop'.
4231 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4233 (TryCatch.SomeCodeFollows): Likewise.
4234 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4235 for 'break', 'continue' and 'return' statements inside a try.
4236 We're fairly sure that the generated IL stream will have more
4237 instructions textually following the try.
4238 (FlowBranchingTryCatch): Likewise.
4240 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4241 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4244 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4245 wrapper -- forward everything to CollectionForeach.
4246 (CollectionForeach.NonDisposableWrapper): New.
4247 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4248 instead of a pop + branch to end.
4250 2008-04-07 Marek Safar <marek.safar@gmail.com>
4252 A fix for bug #377485
4253 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4254 Propagate location for extension method groups. Report conversion failure at
4257 2008-04-07 Marek Safar <marek.safar@gmail.com>
4259 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4260 ListInit and Field expressions.
4262 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4264 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4265 Since $PC is always -1 inside the body of MoveNext, the fault
4267 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4268 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4269 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4271 The denouement! Fix #324708
4272 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4273 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4274 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4275 'finally' inside the finally clause.
4277 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4278 inside an iterator. Don't emit the body of the 'finally' inside
4279 the finally clause yet.
4281 Use the ResumableStatement infrastructure for MoveNext ()
4282 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4283 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4284 'old_resume_points'. Move dispatcher upfront.
4285 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4286 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4287 in an enumerator. This encodes the main fix in this patch series
4288 -- we can only jump into the first instruction of a try from the
4289 outside, but we want to emit try/finally regions in iterators and
4290 resume in the middle of them.
4292 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4294 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4295 of NeedReturnLabel here.
4297 Introduce a common point for emitting try/finally to IL
4298 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4299 features of the various subclasses, which are now driven by ...
4300 (ExceptionStatement.EmitPreTryBody): ... this and ...
4301 (ExceptionStatement.EmitTryBody): ... this and the original
4303 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4304 Remove DoEmit and update to follow above protocol.
4306 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4307 of the dispatcher are the same, skip emitting the 'switch'.
4308 * iterator.cs (Iterator.EmitDispose): Update to changes.
4310 Clean up handling of 'using' statement
4311 * statement.cs (UsingTemporary): New. Carved out of ...
4312 (Using): ... this. Simplify drastically. Handle exactly
4314 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4315 or Using as appropriate. If there are multiple variable declared,
4316 create nested Using statements.
4317 (resource_acquisition): Kill.
4319 * statement.cs (ExceptionStatement.EmitForDispose): Use
4320 EmitFinallyBody, not EmitFinally.
4322 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4323 * iterator.cs: Update to changes.
4325 Start using the ResumableStatement infrastructure
4326 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4327 (ResumableStatement.EmitForDispose): New.
4328 (ExceptionStatement): Override them.
4329 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4330 EmitForDispose to create the body of the Dispose method. Don't
4333 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4334 * statement.cs (Toplevel.AddResumePoint): ... here.
4335 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4336 * flowanalysis.cs (FlowBranchingIterator): New.
4337 * codegen.cs (EmitContext): Update to changes.
4339 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4340 (Iterator.old_resume_points): Rename from 'resume_points'.
4341 (Iterator.MoveNextStatement): Remove unused class.
4343 New infrastructure for try/finally in iterators (still unused)
4344 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4345 (FlowBranchingToplevel.AddResumePoint): Hook into
4346 ToplevelBlock.AddResumePoint.
4347 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4348 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4349 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4350 resume points and assign program-counter values.
4351 (ExceptionBlock.AddResumePoint): Collect resume points for
4352 de-muxer at the top of try block.
4353 * iterators.cs (Yield.CheckContext): Simplify.
4354 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4356 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4358 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4359 argument to an ExitStatement.
4360 (FlowBranchingException): Refactor saved origins code.
4361 * statement.cs (ExitStatement): Update to cahges.
4362 * iterator.cs (YieldBreak): Likewise.
4364 * statement.cs (ResumableStatement): New. Common base class for
4365 YieldReturn and ExceptionStatement.
4366 (ExitStatement): New. Common base class for Return and YieldBreak.
4367 (Return): Update to changes.
4368 * iterator.cs (YieldBreak): Likewise.
4369 * lambda.cs (ContextualReturn): Likewise.
4372 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4373 emit a meaningful error message.
4375 Fix #324765, #319508
4376 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4377 (VariableInfo.SetAssigned): Set it.
4378 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4379 determine if CS0219 or CS0168 is appropriate. Don't use
4380 flow-analysis information.
4381 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4382 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4383 (EmitContext.EndFlowBranching): ... this.
4385 2008-04-03 Marek Safar <marek.safar@gmail.com>
4387 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4389 2008-04-03 Marek Safar <marek.safar@gmail.com>
4391 A fix for bug #376508
4392 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4393 ImplicitConversionExists.
4395 2008-04-03 Marek Safar <marek.safar@gmail.com>
4397 * expression.cs (Binary): Added remaining binary operators to expression
4400 * nullable.cs: Optimize shift with null argument.
4402 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4404 Fix minor IL regression
4405 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4406 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4407 * cs-parser.jay (try_statement): Update to changes.
4409 * statement.cs (TryFinally.need_exc_block): Delete.
4410 (TryFinally): Update to changes.
4412 Now all ExceptionStatements are unconditional
4413 * statement.cs (CollectionForeach.DisposableWrapper): New.
4414 Extract out the try/finally code into a new wrapper.
4415 (CollectionForeach.Resolve): Use it to simplify the code.
4417 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4419 Start at simplifying ExceptionStatement semantics a bit
4420 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4421 * cs-parser.jay (try_statement): Update to changes.
4422 (opt_catch_clauses): Remove.
4423 * flowanalysis.cs: Update to changes.
4424 (FlowBranching.BranchingType.TryCatch): New.
4425 (FlowBranchingTryCatch): New.
4427 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4428 (FlowBranching.CreateBranching): Update to changes.
4429 (FlowBranchingBlock.AddSibling): Add sanity check.
4430 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4433 * iterators.cs (Iterator.MarkFinally): Remove.
4434 * statement.cs (ExceptionStatement): Update to changes.
4436 Add support for skipping over finally blocks at runtime. First
4437 in a series to fix #324708
4438 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4439 (Iterator.EmitMoveNext): Initialize it.
4440 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4441 branch over the body of the 'finally' clause.
4443 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4445 Avoid lopsided use of Foo/DoFoo names
4446 * statement.cs (ExpressionStatement.EmitFinallyBody):
4447 Rename from EmitFinally.
4448 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4449 * iterator.cs: Update to changes.
4451 2008-04-02 Marek Safar <marek.safar@gmail.com>
4453 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4454 based on UserOperatorCall. More binary nullable operators clean up.
4456 2008-04-02 Martin Baulig <martin@ximian.com>
4458 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4460 2008-04-02 Marek Safar <marek.safar@gmail.com>
4462 * nullable.cs: Merge user and empty conversions when lifting expression
4465 * expression.cs (StringConcat): Implemented expression tree representation.
4467 2008-04-01 Marek Safar <marek.safar@gmail.com>
4469 * nullable.cs: When lifting null literal and a user operator exists, no call
4472 2008-04-01 Marek Safar <marek.safar@gmail.com>
4474 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4477 2008-04-01 Marek Safar <marek.safar@gmail.com>
4479 * nullable.cs, expression.cs: Use namespace instead heavily nested
4480 monster abstract class.
4482 2008-04-01 Marek Safar <marek.safar@gmail.com>
4484 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4485 lifting of null literal and user operators. Clean up of some temporary
4488 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4490 Fix #368224, test-629.cs
4491 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4492 if it crossed an unwind-protect boundary.
4493 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4494 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4495 inside an unwind-protected region.
4496 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4497 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4498 'leave' instead of a 'br' if unwind-protected.
4499 (Iterator.EmitYieldBreak): Likewise.
4501 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4503 * driver.cs: Only define versioninfo resources if no win32 resource
4506 2008-03-28 Marek Safar <marek.safar@gmail.com>
4508 A fix for bug #372375
4509 * convert.cs: Fixed boxing of nullable types.
4511 2008-03-28 Marek Safar <marek.safar@gmail.com>
4513 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4516 2008-03-28 Marek Safar <marek.safar@gmail.com>
4518 A fix for bug #374619
4519 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4521 2008-03-27 Marek Safar <marek.safar@gmail.com>
4523 * lambda.cs: Check return type only for invocation.
4525 2008-03-27 Marek Safar <marek.safar@gmail.com>
4527 A fix for bug #374214
4528 * ecore.cs: Correctly report argument type mismatch.
4530 2008-03-27 Marek Safar <marek.safar@gmail.com>
4532 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4533 and not rely on broken IsEnum.
4535 2008-03-27 Marek Safar <marek.safar@gmail.com>
4537 * nullable.cs: New file, extracted from generic.cs.
4539 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4541 2008-03-27 Marek Safar <marek.safar@gmail.com>
4543 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4544 predefined comparison operators and null literals.
4546 * report.cs: New warning ID.
4548 2008-03-25 Marek Safar <marek.safar@gmail.com>
4550 A fix for bug #370577
4551 * lambda.cs: Check return type too.
4553 2008-03-25 Marek Safar <marek.safar@gmail.com>
4555 A fix for bug #372846
4556 * class.cs: Automatic properties can be declared as unsafe.
4558 2008-03-20 Marek Safar <marek.safar@gmail.com>
4560 * location.cs: Use string based concatenation.
4562 * expression.cs: LiftedBinaryOperator is gmcs only.
4564 2008-03-20 Marek Safar <marek.safar@gmail.com>
4566 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4567 conversions rules and expression trees.
4569 2008-03-19 Marek Safar <marek.safar@gmail.com>
4571 * delegate.cs: Use extension method source as delegate target.
4573 2008-03-19 Marek Safar <marek.safar@gmail.com>
4575 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4576 binary operations to be purely based on binary operations and optimized
4577 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4578 and other ET refactoring.
4580 * typemanager.cs: Fixed warning.
4582 2008-03-17 Marek Safar <marek.safar@gmail.com>
4584 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4586 * symbolwriter.cs: Fixed.
4588 2008-03-17 Marek Safar <marek.safar@gmail.com>
4590 * anonymous.cs, driver.cs: Reset anonymous types counters.
4592 2008-03-17 Marek Safar <marek.safar@gmail.com>
4594 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4596 * class.cs: Use fullname for all type member definitions.
4598 2008-02-19 Martin Baulig <martin@ximian.com>
4601 (IMethodData.EmitExtraSymbolInfo): New interface method.
4602 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
4603 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
4604 interface method here as an empty public virtual method.
4607 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
4608 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
4609 CodeGen.SymbolWriter.SetRealMethodName().
4611 2008-02-18 Martin Baulig <martin@ximian.com>
4614 (ScopeInfo.EmitType): Override this and emit debugging
4615 information for captured variables.
4616 (RootScopeInfo.EmitType): Override this and emit symbol
4617 information for a captured `this'.
4619 2008-02-15 Martin Baulig <martin@ximian.com>
4621 * iterators.cs: Emit debugging info.
4624 (EmitContext.Flags): Add `OmitDebuggingInfo'.
4625 (EmitContext.OmitDebuggingInfo): New public property.
4628 (While): Override Emit() and don't emit symbol info there; do it
4629 inside DoEmit() instead.
4630 (Block.Emit): Omit symbol information while emitting the scope
4631 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
4633 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
4634 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
4635 .ctor to make `IsIterator' work.
4637 2008-03-14 Martin Baulig <martin@ximian.com>
4639 * symbolwriter.cs: Added the new symbol writer function from the
4640 debugger's `terrania' branch; temporarily enclose them inside
4641 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
4644 2008-03-14 Martin Baulig <martin@ximian.com>
4647 (SymbolWriter): Make this a public static class.
4650 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
4651 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
4653 2008-03-14 Marek Safar <marek.safar@gmail.com>
4655 A fix for bug #370577
4656 * statement.cs, lambda.cs: Added extra limitations when dealing with void
4659 2008-03-14 Marek Safar <marek.safar@gmail.com>
4661 * typemanager.cs (CSharpName): Made 250 times faster.
4663 2008-03-13 Marek Safar <marek.safar@gmail.com>
4665 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
4667 2008-03-12 Marek Safar <marek.safar@gmail.com>
4669 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
4670 crash when predefined field does not exist.
4672 2008-03-12 Marek Safar <marek.safar@gmail.com>
4674 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
4676 2008-03-12 Marek Safar <marek.safar@gmail.com>
4678 * class.cs (FixedField): Don't crash when contructors are missing.
4680 2008-03-11 Marek Safar <marek.safar@gmail.com>
4682 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
4683 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
4684 check internal types accessibility for internal and external types.
4685 Replaced EnumToUnderlying by GetEnumUnderlyingType.
4687 2008-03-11 Marek Safar <marek.safar@gmail.com>
4689 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
4690 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
4691 attribute.cs, statement: Use corect instance of predefined types (work
4692 related to #364674).
4694 2008-03-07 Marek Safar <marek.safar@gmail.com>
4696 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
4698 2008-03-07 Marek Safar <marek.safar@gmail.com>
4700 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
4701 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
4702 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
4703 predefined types clean up, delayed predefined types members initialization
4704 (work related to #364674).
4706 2008-03-05 Marek Safar <marek.safar@gmail.com>
4708 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
4710 2008-03-05 Marek Safar <marek.safar@gmail.com>
4712 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
4713 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
4714 predefined types clean up (work related to #364674).
4716 2008-03-04 Marek Safar <marek.safar@gmail.com>
4718 * ecore.cs: Print an error message instead of throwing exception.
4720 2008-03-04 Marek Safar <marek.safar@gmail.com>
4722 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
4723 expression.cs, statement.cs: Unififed null literal representation.
4725 2008-03-03 Marek Safar <marek.safar@gmail.com>
4727 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
4728 expression.cs: Refactored binary operators resolve phase and improved speed.
4729 The nullable code is still missing and won't work correctly, more fixes
4732 It also fixes #323726, #324312, #324248, and many other unreported issues.
4734 2008-02-29 Zoltan Varga <vargaz@gmail.com>
4736 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
4739 2008-02-27 Marek Safar <marek.safar@gmail.com>
4741 * ecore.cs: Clean-up and split BetterConversion.
4743 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
4746 * enum.cs (EnumMember.Value): Only access 'value' if
4747 ResolveValue says it's ok.
4748 (EnumMember.DoResolveValue): Don't set prev_member.value.
4749 (Enum.GetDefinition): Reverse arguments of Equals --
4750 EnumMember.Value can return 'null'.
4752 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
4754 2008-02-22 Marek Safar <marek.safar@gmail.com>
4756 * generic.cs, expression.cs: More ongoing work on expression trees.
4758 2008-02-21 Marek Safar <marek.safar@gmail.com>
4760 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
4761 handle missing matches when mutiple operators exist.
4763 2008-02-20 Marek Safar <marek.safar@gmail.com>
4765 A fix for bug #363218
4766 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
4769 2008-02-20 Marek Safar <marek.safar@gmail.com>
4771 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
4772 update. This time to deal correctly with SideEffectConstant expression used
4773 as an argument for another constant folding.
4775 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
4777 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
4780 2008-02-19 Marek Safar <marek.safar@gmail.com>
4782 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
4784 2008-02-19 Marek Safar <marek.safar@gmail.com>
4786 A fix for bug #328136
4787 * expression.cs: Do not fold immediately LogicalAnd operators when the left
4788 side is a false constant, because we still need to evaluate the right-hand
4791 * statement.cs (If): Emit two types of boolean constants (simple constant,
4792 side-effect constant).
4794 2008-02-19 Marek Safar <marek.safar@gmail.com>
4796 * constant.cs (SideEffectConstant): Don't emit boolean constant.
4798 * expression.cs: Fold immediately LogicalAnd operators when both sides are
4801 2008-02-18 Marek Safar <marek.safar@gmail.com>
4803 A fix for bug #361457
4804 * ecore.cs (IsApplicable): Params methods have lower priority.
4806 * support.cs: Return correct parameter modifier for params types.
4808 2008-02-18 Marek Safar <marek.safar@gmail.com>
4810 * generic.cs (TypeParameter): Cache attribute target name.
4812 * support.cs: Removed unused variable.
4814 * typemanager.cs: Removed debugging leftover.
4816 * ecore.cs: Use local type instead of a property;
4818 * class.cs (VerifyMembers): Consider also parent to test whether type member
4821 * expression.cs (FullMethodDesc): Removed.
4823 * attribute.cs (IsValidArgumentType): Made static.
4825 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
4827 Cleanup to be more readable.
4828 * Makefile (GMCS_PROFILE): Remove.
4829 (COMPILER_NAME): New helper.
4831 2008-02-15 Miguel de Icaza <miguel@novell.com>
4833 * cs-tokenizer.cs: if a conditional expression happens inside a
4834 (...) this also means that we do not need to de-ambiguate between
4835 an parenthesized expression and a cast.
4839 * constant.cs (SideEffectConstant): a constant value that happens
4840 to have a side effect.
4842 Fixes the build regressions introduced by the fix for #359789
4844 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
4846 * expression.cs (Conditional.Emit): when emitting the ternary
4847 operator, use local variables to generate code verifiable code.
4849 The verifier cannot infer that the type on stack before the
4850 stloc.0 is executed is of type ParentB. This happens because the
4851 stack merge algorithm uses only parent types when deciding which
4852 is the common type. This is described in Part III 1.8.1.3 of ECMA
4855 This code compiled with mcs is not verifiable under MS. The MS
4856 verifier picks the first common interface of Foo and Bar, which is
4857 wrong, but doesn't use a full join type of the 2 interfaces.
4859 CSC uses a clever hack to compile such code in a verifiable
4860 way. It stores the intermediate values in a local variable with
4865 2008-02-14 Miguel de Icaza <miguel@novell.com>
4867 * expression.cs: Do not fold BitwiseAnd operators when the left
4868 side is a false constant, because we still need to evaluate the
4873 * support.cs: Instead of throwing an InternalErrorException when
4874 the position of the stream is outside the boundary of our buffer,
4875 reset the state of the reader, and restart the reading from the
4876 beginning of the file.
4878 2008-02-14 Marek Safar <marek.safar@gmail.com>
4880 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
4882 2008-02-14 Marek Safar <marek.safar@gmail.com>
4884 A fix for bug #361686
4885 * decl.cs: A protected types used inside a private class which parents
4886 derives from the protected class are accessible.
4888 2008-02-13 Marek Safar <marek.safar@gmail.com>
4890 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
4891 the parameterless constructor.
4893 2008-02-13 Marek Safar <marek.safar@gmail.com>
4895 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
4896 lookup methods to use standard member cache when doing member lookup.
4898 2008-02-12 Marek Safar <marek.safar@gmail.com>
4900 * driver.cs: Don't report full path for referenced module as assembly error.
4902 2008-02-12 Marek Safar <marek.safar@gmail.com>
4904 * Makefile: Fixed `qh' target to work on all machines.
4906 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
4907 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
4908 and HasElementType with TypeManager implementation.
4910 2008-02-08 Marek Safar <marek.safar@gmail.com>
4912 A fix for bugs #325134, #359749
4913 * expression.cs, ecore.cs: Try to resolve an extension method even if the
4914 first binds point to non-method member expression.
4916 2008-02-08 Marek Safar <marek.safar@gmail.com>
4918 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
4920 2008-02-08 Marek Safar <marek.safar@gmail.com>
4922 A fix for bugs #321394, #323028
4923 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
4924 Reworked naive IsAccessibleAs implementation to handle nested types.
4926 2008-02-05 Jb Evain <jbevain@novell.com>
4928 * class.cs: use generic type comparison for parameters
4931 2008-02-05 Marek Safar <marek.safar@gmail.com>
4933 A fix for bug #325372
4934 * class.cs: Use generic type comparison when testing method signatures.
4936 2008-02-05 Marek Safar <marek.safar@gmail.com>
4938 A fix for bug #357047
4939 * ecore.cs: Applied C# 3.0 changes to better conversion.
4941 2008-02-05 Marek Safar <marek.safar@gmail.com>
4943 A fix for bug #358374
4944 * cs-parser.jay: Correctly set modifiers for all constructor types.
4946 2008-02-04 Marek Safar <marek.safar@gmail.com>
4948 A fix for bug #355251
4949 * generic.cs: Added base class constraint based type inference.
4951 2008-02-01 Marek Safar <marek.safar@gmail.com>
4953 A fix for bug #357255
4954 * decl.cs: One more missing visibility check.
4956 2008-02-01 Marek Safar <marek.safar@gmail.com>
4958 * support.cs: Fixed broken return.
4960 2008-01-25 Marek Safar <marek.safar@gmail.com>
4962 * report.cs: Correctly reset warnings count after probing.
4964 2008-01-25 Martin Baulig <martin@ximian.com>
4967 (NamespaceEntry.SymbolFileID): Make this work again after
4968 MemberName.ToString() is gone.
4970 2008-01-25 Marek Safar <marek.safar@gmail.com>
4972 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
4975 2008-01-25 Marek Safar <marek.safar@gmail.com>
4977 * generic.cs: Use full implicit conversion for type inference fixing.
4979 2008-01-24 Marek Safar <marek.safar@gmail.com>
4981 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
4982 Fixed user operator conversions.
4984 2008-01-24 Marek Safar <marek.safar@gmail.com>
4986 * generic.cs: Do nullable type to null comparison optimization during
4989 2008-01-24 Marek Safar <marek.safar@gmail.com>
4991 A fix for bug #355163
4992 * generic.cs: Enabled l-value resolve on nullable expressions.
4994 2008-01-24 Marek Safar <marek.safar@gmail.com>
4996 A fix for bug #353986
4997 * class.cs: Ingore static ctors with parameters for any further checks.
4999 2008-01-24 Marek Safar <marek.safar@gmail.com>
5001 A fix for bug #354310
5002 * namespace.cs: Removed redundant check.
5004 2008-01-24 Marek Safar <marek.safar@gmail.com>
5006 A fix for bug #354928
5007 * expression.cs: ElementInitializers can be resolved only once.
5009 2008-01-24 Marek Safar <marek.safar@gmail.com>
5011 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5012 Condition expressions.
5014 2008-01-23 Marek Safar <marek.safar@gmail.com>
5016 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5018 2008-01-22 Marek Safar <marek.safar@gmail.com>
5020 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5023 * generic.cs: Implemented coalesce expression.
5025 2008-01-22 Marek Safar <marek.safar@gmail.com>
5027 A fix for bug #355145
5028 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5029 expression tree type inference.
5031 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5034 * expression.cs (Binary.IsUnsignedType): Fix typo.
5036 2008-01-22 Marek Safar <marek.safar@gmail.com>
5038 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5040 2008-01-22 Marek Safar <marek.safar@gmail.com>
5042 A fix for bug #355161
5043 * ecore.cs, expression.cs: Wider range of extension method supported
5046 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5048 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5049 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5052 2008-01-22 Marek Safar <marek.safar@gmail.com>
5054 A fix for bug #355148
5055 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5057 2008-01-22 Miguel de Icaza <miguel@novell.com>
5059 * expression.cs (CreateExpressionTree): Add support for or and
5060 logical or, and indent following the coding conventions.
5062 * typemanager.cs (LinqExpression): renamed from
5063 ExpressionTreeManager, for a shorter name.
5065 Use TypeManager.CoreLookupType to lookup types from our core
5066 assemblies and turn those into "Type" variables.
5068 Consumers that previously used "Namespace" and "Type" from this
5069 class should instead use the TypeExpression which is a type that
5070 is fully resolved (without involving the regular C# resolution
5073 This typically looks like this:
5075 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5076 new MemberAccess (texpr, name, type_arguments, loc)
5078 This avoids the problem in: #355178
5080 2008-01-21 Marek Safar <marek.safar@gmail.com>
5082 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5083 feature in parser only as we do in other cases.
5085 2008-01-21 Marek Safar <marek.safar@gmail.com>
5087 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5088 typemanager.cs: A refactoring of params arguments to reuse existing
5089 expressions (params -> array initializer) to emit params argument instead
5090 of specialized handling.
5091 It was required by expression tree implementation and it has other benefits
5092 as well, we now apply same optimization for params arguments as we do for
5095 2008-01-18 Marek Safar <marek.safar@gmail.com>
5097 A fix for bug #353526
5098 * generic.cs: A type inference of params arguments may not required any
5099 temporary array creation.
5101 2008-01-18 Marek Safar <marek.safar@gmail.com>
5103 A fix for bug #353534
5104 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5105 supported for delegates only.
5107 2008-01-18 Marek Safar <marek.safar@gmail.com>
5109 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5110 type for more than 1 candidates.
5112 2008-01-18 Marek Safar <marek.safar@gmail.com>
5114 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5117 2008-01-16 Marek Safar <marek.safar@gmail.com>
5119 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5120 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5121 operator) expressions.
5123 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5125 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5126 not accessed from the generated IL.
5128 2008-01-14 Marek Safar <marek.safar@gmail.com>
5130 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5131 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5132 statement.cs: The first expression tree implementation drop, mostly
5133 infrastructure work.
5135 2008-01-14 Marek Safar <marek.safar@gmail.com>
5137 * ecore.cs (IsNestedChild): Refactored.
5139 2008-01-11 Marek Safar <marek.safar@gmail.com>
5141 * lambda.cs: Don't use a cast on unknown expression statement.
5143 2008-01-10 Geoff Norton <gnorton@novell.com>
5145 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5148 2008-01-09 Marek Safar <marek.safar@gmail.com>
5150 * doc.cs: Report better /doc crash details.
5152 2008-01-09 Marek Safar <marek.safar@gmail.com>
5154 A fix for bug #352536
5155 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5157 2008-01-08 Marek Safar <marek.safar@gmail.com>
5159 A fix for bug #352287
5160 * ecore.cs, expression.cs: Do `this' access checking in all member access
5163 2008-01-08 Marek Safar <marek.safar@gmail.com>
5165 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5167 * report.cs: Reset message stacks.
5169 2008-01-08 Marek Safar <marek.safar@gmail.com>
5171 * generic.cs (InferInPhases): Correctly calculate params position.
5173 2008-01-08 Marek Safar <marek.safar@gmail.com>
5175 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5178 2008-01-07 Marek Safar <marek.safar@gmail.com>
5180 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5182 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5184 * driver.cs: Updated --help option.
5186 2008-01-07 Marek Safar <marek.safar@gmail.com>
5188 * generic.cs (InferParamsTypeArguments): Removed.
5189 (InferInPhases): Add params type inference.
5190 (LowerBoundInference): Fixed scoring mechanism.
5192 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5194 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5196 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5197 byte array for unsigned "baked" assemblies.
5199 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5201 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5202 array for assemblies that are not strongnamed.
5204 2008-01-04 Marek Safar <marek.safar@gmail.com>
5206 A fix for bug #351481
5207 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5208 declaring type for nested generic types.
5210 2008-01-04 Marek Safar <marek.safar@gmail.com>
5212 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5213 instead of ToString.
5215 2008-01-03 Marek Safar <marek.safar@gmail.com>
5217 A fix for bug #351047
5218 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5219 null and structs only when equality and inequality operators are defined
5220 either as an user-operators or predefined operators.
5222 2008-01-03 Marek Safar <marek.safar@gmail.com>
5224 A fix for bug #351047
5225 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5227 2008-01-03 Marek Safar <marek.safar@gmail.com>
5229 A fix for bug #351257
5230 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5232 2008-01-03 Marek Safar <marek.safar@gmail.com>
5234 A fix for bug #351157
5235 * class.cs (Using): Fixed yet another broken cloning.
5237 (Block): Put back more sensible default value for statements.
5239 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5241 * codegen.cs: Allow AssemblyVersion with only major version component.
5244 2007-12-29 Marek Safar <marek.safar@gmail.com>
5246 A fix for bug #324654
5247 * class.cs: Use FullName property as member name.
5249 2007-12-28 Marek Safar <marek.safar@gmail.com>
5251 A fix for bug #342117
5252 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5253 constructor constraint.
5255 2007-12-28 Marek Safar <marek.safar@gmail.com>
5257 A fix for bug #338273
5258 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5261 2007-12-28 Marek Safar <marek.safar@gmail.com>
5263 A fix for bug #350839
5264 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5266 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5268 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5271 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5273 * statement.cs: Changed some Hashtables to use HybridDictionaries
5274 instead. It was observed that some HashTables only contained a few
5275 items in the vast majority of cases. Since HybridDictionary is
5276 more efficient on small sets (<10 elements), "known_variables"
5277 from class ExplicitBlock as well as "labels" and "constants " from
5278 class Block were changed to HybridDictionaries.
5280 Atsai results: (56216kb->54987kb)
5282 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5285 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5287 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5290 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5292 * expression.cs: foreach loop to for loop, saved on allocation of
5293 enumerator (59333kb->59141kb)
5295 * statement.cs. Changed foreach loops to for loops, saved on
5296 allocation of enumerator (59141kb->59006kb)
5298 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5299 when constructed with no specified capacity. This was causing a
5300 few ArrayLists to allocate more memory than they would potentially
5301 need in the Block class and MemberCache class. Setting the
5302 ArrayLists to construct with a capacity of 1 saves some
5303 memory. (56216kb->55585kb)
5305 2007-12-27 Marek Safar <marek.safar@gmail.com>
5307 A fix for bug #347189 (2nd issue)
5308 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5311 2007-12-27 Miguel de Icaza <miguel@novell.com>
5313 * report.cs: Do not use colors if stdout and stderr are not a
5316 2007-12-27 Marek Safar <marek.safar@gmail.com>
5318 A fix for bug #346998
5319 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5322 2007-12-27 Marek Safar <marek.safar@gmail.com>
5324 A fix for bug #343465
5325 * class.cs: Explicit method name for nested types uses dots only.
5327 2007-12-27 Marek Safar <marek.safar@gmail.com>
5329 A fix for bug #343707
5330 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5332 2007-12-27 Marek Safar <marek.safar@gmail.com>
5334 * ecore.cs: Report type inference errors only when arguments count matches
5337 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5339 * expression.cs, report.cs: New warning.
5341 * typemanager.cs: Catch anonymous method type too.
5343 2007-12-23 Marek Safar <marek.safar@gmail.com>
5345 A fix for bug #346379
5346 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5348 2007-12-23 Marek Safar <marek.safar@gmail.com>
5350 A fix for bug #347359
5351 * expression.cs (Invocation): Don't resolve already resolved expression.
5353 2007-12-23 Marek Safar <marek.safar@gmail.com>
5355 A fix for bug #347189
5356 * class.cs (FixedField): Use non-dependent code only in the define phase.
5358 2007-12-23 Marek Safar <marek.safar@gmail.com>
5360 A fix for bug #348076
5361 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5363 2007-12-22 Marek Safar <marek.safar@gmail.com>
5365 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5366 discovered extension methods.
5368 2007-12-22 Marek Safar <marek.safar@gmail.com>
5370 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5373 2007-12-21 Miguel de Icaza <miguel@novell.com>
5375 * report.cs (ErrorMessage): Add support for using colors on
5376 terminals that support it.
5378 2007-12-21 Marek Safar <marek.safar@gmail.com>
5380 * ecore.cs: Use information about expanded params for error reporting.
5382 2007-12-21 Marek Safar <marek.safar@gmail.com>
5384 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5385 and logic for params overloads.
5387 2007-12-15 Miguel de Icaza <miguel@novell.com>
5389 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5390 as this is also created from the parser. Fixes #349034
5392 2007-12-12 Miguel de Icaza <miguel@novell.com>
5394 * statement.cs (Throw.CloneTo): it is valid to have empty
5395 expressions for throw.
5397 2007-12-03 Marek Safar <marek.safar@gmail.com>
5399 * cs-parser.jay: Set delegate constraint parsing region correctly.
5401 2007-12-03 Marek Safar <marek.safar@gmail.com>
5403 A fix for bug #345467
5404 * typemanager.cs (IsEqual): Compare generic parameters position only.
5406 2007-11-28 Marek Safar <marek.safar@gmail.com>
5408 * expression.cs (BaseAccess): Type arguments can be null.
5410 2007-11-27 Raja R Harinath <harinath@gmail.com>
5412 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5413 consistent even when an error has occured.
5414 (Switch.Resolve): Likewise.
5416 2007-11-22 Marek Safar <marek.safar@gmail.com>
5418 A fix for bug #334505
5419 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5422 2007-11-22 Marek Safar <marek.safar@gmail.com>
5424 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5425 refactorings required to resolve extension methods correctly when mixing
5426 generics and non-generics members.
5428 2007-11-20 Marek Safar <marek.safar@gmail.com>
5430 A fix for bug #342584
5431 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5434 2007-11-19 Marek Safar <marek.safar@gmail.com>
5436 A fix for bug #342512
5437 * delegate.cs: Use delegate argument expression when is available. Don't
5438 emit virtual call when class is sealed.
5440 2007-11-16 Marek Safar <marek.safar@gmail.com>
5442 A fix for bug #325423
5443 * assign.cs (FieldInitializer): Use resolved expression for emit.
5445 * class.cs: Print less confusing error message.
5447 2007-11-16 Marek Safar <marek.safar@gmail.com>
5449 * cs-tokenizer.cs: Removed GMCS ifdefs.
5451 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5454 * cs-parser.jay: Disabled nullable check.
5456 * generic-mcs: Copied more generic stuff.
5458 2007-11-16 Marek Safar <marek.safar@gmail.com>
5460 * gcs-parser.jay: Merged to cs-parser.jay.
5462 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5463 * *.csproj, *.sources: Updated to use only jay parser file.
5465 2007-11-16 Marek Safar <marek.safar@gmail.com>
5467 * gcs-parser.jay: Added nullable and default expression feature checks.
5469 2007-11-16 Marek Safar <marek.safar@gmail.com>
5471 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5472 it fixes many TODOs and hidden bugs.
5474 * expression: Removed duplicate error check.
5476 2007-11-15 Marek Safar <marek.safar@gmail.com>
5478 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5479 implicitly type local variable only when it is used in a declaration.
5481 2007-11-15 Marek Safar <marek.safar@gmail.com>
5483 * attribute.cs: Use CS0612 for empty strings.
5485 2007-11-14 Marek Safar <marek.safar@gmail.com>
5487 * lambda.cs, statement.cs: Contextual return may act as a statement.
5489 2007-11-14 Marek Safar <marek.safar@gmail.com>
5491 A fix for a regression cause by #324222
5492 * class.cs: Don't report unused even when it implements an interface.
5494 2007-11-13 Marek Safar <marek.safar@gmail.com>
5496 A fix for bug #341205
5497 * ecore.cs, expression.cs: Method group expression cannot do static
5498 method access with an instance reference check before overloading takes
5501 2007-11-13 Marek Safar <marek.safar@gmail.com>
5503 A fix for bug #325359
5504 * class.cs: Use predictable name for automatically generated property.
5506 2007-11-12 Marek Safar <marek.safar@gmail.com>
5508 A fix for bug #324996
5509 * expression.cs (Is): Handle case where D is nullable and T is not
5512 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5514 2007-11-12 Marek Safar <marek.safar@gmail.com>
5516 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5517 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5518 Flush small error reporting changes.
5520 2007-11-09 Marek Safar <marek.safar@gmail.com>
5522 A fix for bug #324996
5523 * expression.cs: Rewrote Is expression implementation to work with
5524 generics, nullable types, anonymous method. A const result expression
5525 uses existing infrastructure instead of custom not fully-featured one.
5527 2007-11-08 Marek Safar <marek.safar@gmail.com>
5529 A fix for bug #340202
5530 * class.cs: Consider generics for volatile field.
5532 2007-11-08 Marek Safar <marek.safar@gmail.com>
5534 A fix for bug #335594
5535 * expression.cs: Use conversion rules when handling string addition.
5537 2007-11-07 Marek Safar <marek.safar@gmail.com>
5539 A fix for bug #336651
5540 * expression.cs: Fixed a crash when probing is on.
5542 2007-11-07 Marek Safar <marek.safar@gmail.com>
5544 A fix for bug #324242
5545 * covert.cs: Added a conversion from any nullable-type with an
5546 underlying enum-type to the type System.Enum.
5548 2007-11-07 Marek Safar <marek.safar@gmail.com>
5550 A fix for bug #324222
5551 * class.cs: Report all non-used event fields.
5553 2007-11-07 Marek Safar <marek.safar@gmail.com>
5555 A fix for bug #325161
5556 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5557 qualifier for generic types.
5559 2007-11-07 Marek Safar <marek.safar@gmail.com>
5561 A fix for bug #322971
5562 * expression.cs, ecore.cs: Added intermediate result value check for
5565 2007-11-07 Marek Safar <marek.safar@gmail.com>
5567 A fix for bug #324754
5568 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5569 when it was requested.
5571 2007-11-07 Marek Safar <marek.safar@gmail.com>
5573 A fix for bug #325101
5574 * expression.cs: Do type not value comparison for `is' expression.
5576 2007-11-07 Marek Safar <marek.safar@gmail.com>
5578 A fix for bug #320236
5579 * convert.cs: Don't apply user conversion on underlying target type.
5581 2007-11-06 Marek Safar <marek.safar@gmail.com>
5583 * expression.cs: Don't use unresolved expression for error reporting.
5585 2007-11-06 Marek Safar <marek.safar@gmail.com>
5587 A fix for bugs #337712, #324490
5588 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5589 overloading resolution too.
5591 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5592 the process consistent and more robust.
5594 * expression.cs, linq.cs, report.cs: Update.
5596 2007-11-02 Marek Safar <marek.safar@gmail.com>
5598 A fix for bug #332909
5599 * attribute.cs: Resolve attributes in correct context using error
5602 * rootcontext.cs: Define Obsolete attribute members as core members.
5604 2007-11-02 Marek Safar <marek.safar@gmail.com>
5606 * statement.cs: Removed unused methods.
5608 2007-10-31 Wade Berrier <wberrier@novell.com>
5610 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
5611 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
5614 2007-10-31 Marek Safar <marek.safar@gmail.com>
5616 A fix for bug #338102
5617 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
5618 methods registered as non-generics.
5620 2007-10-31 Marek Safar <marek.safar@gmail.com>
5622 A fix for bugs #337712, #324490
5623 * delegate.cs: Delegate covariance and contravariance is not allowed for
5626 2007-10-31 Marek Safar <marek.safar@gmail.com>
5628 A fix for bug #337719
5629 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
5632 2007-10-30 Marek Safar <marek.safar@gmail.com>
5634 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
5636 2007-10-29 Marek Safar <marek.safar@gmail.com>
5638 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
5641 2007-10-29 Raja R Harinath <rharinath@novell.com>
5643 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
5645 2007-10-29 Marek Safar <marek.safar@gmail.com>
5647 A fix for bug #334652
5648 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
5649 extension methods when we have not found the best candidate in normal
5652 2007-10-27 Marek Safar <marek.safar@gmail.com>
5654 * AssemblyInfo.cs: Keep up-to-date.
5656 2007-10-27 Marek Safar <marek.safar@gmail.com>
5658 * Makefile: Fixed generics compiler name.
5660 2007-10-27 Marek Safar <marek.safar@gmail.com>
5662 * lambda.test: removed, lambda parsing is done differently.
5664 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
5666 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
5668 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
5670 2007-10-27 Marek Safar <marek.safar@gmail.com>
5672 * Makefile, *.sources : All C# compilers are in mcs folder.
5674 * *.cs: Use existing 2_1 define for smcs.
5676 2007-10-26 Marek Safar <marek.safar@gmail.com>
5678 A fix for bug #335847
5679 * assign.cs, expression.cs: Couple of changes to avoid creating a
5680 temporary variable for each object initializer assignment statement. It
5681 simplifies struct initialization too, otherwise two temporary variables
5683 Implemented optimization of redundant default element initializers.
5685 2007-10-25 Marek Safar <marek.safar@gmail.com>
5687 A fix for bug #336766
5688 * expression.cs (Class.CheckBase): Use generic name when method is
5691 2007-10-25 Marek Safar <marek.safar@gmail.com>
5693 A fix for bug #334737
5694 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
5695 variable and not variable argument for prepared copies.
5697 2007-10-24 Marek Safar <marek.safar@gmail.com>
5699 A fix for bug #325110
5700 * class.cs, expression.cs, attribute.cs: Use open generic method when
5701 checking conditional attribute.
5703 2007-10-24 Marek Safar <marek.safar@gmail.com>
5705 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
5706 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
5707 FeatureIsNotAvailable.
5709 2007-10-24 Marek Safar <marek.safar@gmail.com>
5711 ** C# 3.0 Partial methods
5713 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
5714 methods support. Because of member cache issue with generics only
5715 non-generics partial methods are fully supported.
5717 2007-10-23 Marek Safar <marek.safar@gmail.com>
5719 * class.cs, decl.cs: Rewrote member overloads check to cope with
5720 generics and to use member cache for member checking. It also improves
5721 performance and fixes remaining overloads issues.
5723 2007-10-20 Marek Safar <marek.safar@gmail.com>
5725 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
5726 roottypes.cs, typemanager.cs:
5728 A member cache creation logic changed to add members immediately and
5729 not rely on fallback. The member cache is now only prefered way
5730 how to access and find type declaration members. It saves 5 MB of memory
5731 during MWF compilation and makes code ready for more optimizations and
5732 clean-ups, it's also a pre-requirement for partial methods.
5734 2007-10-18 Raja R Harinath <harinath@gmail.com>
5736 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
5737 handling for generic parameters.
5739 2007-10-15 Marek Safar <marek.safar@gmail.com>
5741 * class.cs (FixedField): Removed redundant volatile check.
5743 2007-10-15 Marek Safar <marek.safar@gmail.com>
5745 * class.cs, decl.cs: Fixed overload members verification to do only one
5746 check per possible collision.
5748 2007-10-13 Marek Safar <marek.safar@gmail.com>
5750 A fix for bug #325478
5751 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
5752 and create only one disposable flags container.
5754 2007-10-12 Marek Safar <marek.safar@gmail.com>
5756 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
5757 * statement.cs (Fixed): Fixed variables cloning.
5759 2007-10-12 Marek Safar <marek.safar@gmail.com>
5761 A fix for bug #333342
5762 * class.cs (EventField): Don't mark value type event as synchronized.
5764 2007-10-12 Marek Safar <marek.safar@gmail.com>
5766 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
5767 inference to identify best candidate method correctly.
5768 (ProperyExpr): A range variable is read only and cannot be modified.
5770 2007-10-11 Marek Safar <marek.safar@gmail.com>
5772 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
5773 logic to identify best candidate method correctly.
5775 2007-10-11 Marek Safar <marek.safar@gmail.com>
5777 * location.cs (Equals, GetHashCode): Removed.
5779 2007-10-11 Marek Safar <marek.safar@gmail.com>
5781 * report.cs: Implemented message recorder. It is used mainly for lambda
5782 expressions to capture otherwise swallowed error messages.
5784 * anonymous.cs, lambda.cs.cs: Do full parameters check.
5786 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
5788 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
5790 * expression.cs (MemberAccess): Always report lookup failure.
5792 * location.cs: Implemented Equals, GetHashCode.
5794 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
5796 2007-10-10 Jb Evain <jbevain@novell.com>
5798 * codegen.cs: re-enable assembly version check.
5800 2007-10-09 Marek Safar <marek.safar@gmail.com>
5802 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
5805 * namespace.cs (UsingAlias): Do correct version check.
5807 2007-10-08 Marek Safar <marek.safar@gmail.com>
5809 * expresison.cs, ecore.cs: Issue extension method error message when
5812 * rootcontext.cs: Added ISO_2 compiler mode option.
5814 2007-10-08 Marek Safar <marek.safar@gmail.com>
5816 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
5819 2007-10-08 Marek Safar <marek.safar@gmail.com>
5821 * attribute.cs (GetString, GetBoolean): Work with both literal and
5824 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
5825 Moved method overload specific methods to MethodGroupExpr.
5827 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
5828 it should be less memory consuming.
5830 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
5832 * codegen.cs: remove the assembly version check until the buildbot is
5835 2007-10-07 Jb Evain <jbevain@novell.com>
5837 * attribute.cs (Attribute.GetString): if the value
5838 expression is a StringConstant, return its string value.
5840 2007-10-07 Jb Evain <jbevain@novell.com>
5842 * typemanager.cs: add `assembly_version_attribute_type`.
5843 * codegen.cs: on attribute emission, check that the
5844 AssemblyVersionAttribute doesn't overflow.
5846 2007-10-05 Marek Safar <marek.safar@gmail.com>
5848 A fix for bug #324677
5849 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
5850 parent container of a scope container with currently resolved one.
5852 2007-10-05 Marek Safar <marek.safar@gmail.com>
5854 A fix for bug #325534
5855 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
5858 2007-10-05 Marek Safar <marek.safar@gmail.com>
5860 A fix for bug #327504
5861 * class.cs (Operator.Define): Refactored implicit and explicit user
5862 operator conversion rules.
5864 2007-10-05 Marek Safar <marek.safar@gmail.com>
5866 A fix for bug #327520
5867 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
5869 2007-10-04 Marek Safar <marek.safar@gmail.com>
5871 A fix for bug #328022
5872 * class.cs (MethodData.Define): Use correct method to check whether
5873 a method implementents an accessor.
5875 2007-10-04 Marek Safar <marek.safar@gmail.com>
5877 A fix for bug #330069
5878 * statement.cs (Fixed.Resolve): Read the first array element only when
5879 an array is instantiated.
5881 2007-10-04 Marek Safar <marek.safar@gmail.com>
5883 * expression.cs, assign.cs, generics.cs: Print correct operator when
5884 compound assignment is used.
5886 2007-10-04 Marek Safar <marek.safar@gmail.com>
5888 A fix for bug #325841
5889 * expression.cs (ArrayAccess): Use full argument cloning only for
5890 string compound concatenation.
5892 2007-10-03 Marek Safar <marek.safar@gmail.com>
5894 A fix for bug #328774
5895 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
5897 (PropertyExpr.EmitAssign): Fixed string concatenation compound
5900 2007-10-03 Raja R Harinath <rharinath@novell.com>
5903 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
5904 Event accessibility checks here. Remove some bogus code that
5905 accidently made GenericMethods work.
5906 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
5908 2007-09-25 Marek Safar <marek.safar@gmail.com>
5910 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
5912 * statement.cs (Block): Refactored AddVariable to allow error handling
5915 * generic.cs: New stub.
5917 2007-09-23 Marek Safar <marek.safar@gmail.com>
5919 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
5922 2007-09-17 Marek Safar <marek.safar@gmail.com>
5924 * class.cs: Use partial container to record whether any partial part
5925 contains static field initializer and therefore default contructor has
5928 2007-09-14 Marek Safar <marek.safar@gmail.com>
5930 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
5931 mono-list when only one of two partial parts has defined accessibility
5934 2007-09-14 Marek Safar <marek.safar@gmail.com>
5936 A fix for bug #82845
5938 * class.cs (TypeContainer): Set correct resolve context for all field
5941 2007-09-13 Marek Safar <marek.safar@gmail.com>
5943 * assign.cs: Fixed a crash when field is resolved twice with an error.
5945 * codegen.cs: Changed InFieldInitializer to be flag.
5947 * anonymous.cs, ecore.cs, expression.cs: Update after
5948 IsInFieldInitializer rename.
5950 * const.cs: Removed unused parameter.
5952 * class.cs: Changed the way how we resolve and emit field initializers.
5953 The field initilizers have to have access to contructor block to emit
5954 compiler generated code.
5956 2007-09-13 Marek Safar <marek.safar@gmail.com>
5958 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
5959 generics use TypeContainer instead.
5961 2007-09-12 Marek Safar <marek.safar@gmail.com>
5963 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
5965 * lambda.cs (ResolveParameters): Use more powerful
5966 InflateGenericArgument.
5968 * parameters.cs: Better exception message.
5970 2007-09-10 Marek Safar <marek.safar@gmail.com>
5972 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
5973 correct expression block type.
5975 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
5977 * expression.cs (Invocation): Extracted method group resolve to
5980 2007-09-07 Marek Safar <marek.safar@gmail.com>
5982 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
5983 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
5985 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
5986 generic extension methods.
5988 2007-09-06 Marek Safar <marek.safar@gmail.com>
5990 A fix for bug #82676 (Do I get it right now?)
5991 * convert.cs (Binary.ResolveOperator): An interface is converted to the
5992 object before a standard conversion is applied.
5994 2007-09-06 Marek Safar <marek.safar@gmail.com>
5996 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
5999 2007-09-05 Marek Safar <marek.safar@gmail.com>
6001 A fix for bug #82676
6002 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6003 non-generic interface types.
6005 2007-09-05 Marek Safar <marek.safar@gmail.com>
6007 A fix for bug #82690
6008 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6010 2007-09-05 Marek Safar <marek.safar@gmail.com>
6012 A fix for bug #82571
6013 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6014 modifier for container based methods.
6016 2007-09-05 Marek Safar <marek.safar@gmail.com>
6018 A fix for bug #82676
6019 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6020 any interface-type T means to any of interface type T.
6022 2007-09-04 Marek Safar <marek.safar@gmail.com>
6024 * namespace.cs: We have 2 versions of System.Core assembly.
6026 2007-09-04 Marek Safar <marek.safar@gmail.com>
6028 A fix for bug #82652
6029 * class.cs (Class.GetClassBases): Compare types and not expressions.
6031 2007-09-04 Marek Safar <marek.safar@gmail.com>
6033 A fix for bug #82620
6034 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6035 actually never worked before.
6036 (IndexerAccess): Emit prepared arguments before they are modified.
6038 2007-09-04 Marek Safar <marek.safar@gmail.com>
6040 A fix for bug #82563
6041 * assign.cs: Revert wrong fix.
6043 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6045 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6046 Instead of ldelema/stdind we have to use temporary variables to handle
6047 cases like String.Concat (params string[]).
6049 2007-08-31 Marek Safar <marek.safar@gmail.com>
6051 * class.cs: EmitAttributes to Emit rename.
6053 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6055 (MemberCore.HasClsCompliantAttribute): Don't depend on
6056 GetClsCompliantAttributeValue execution.
6058 2007-08-31 Marek Safar <marek.safar@gmail.com>
6060 * anonymous.cs: Use shorter type prefix.
6062 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6065 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6066 variables when probing is on.
6068 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6069 unresolved variables.
6070 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6071 handle transparent identifiers.
6073 2007-08-26 Marek Safar <marek.safar@gmail.com>
6075 * attribute.cs (IsClsCompliant): Add nullable types test.
6077 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6079 * doc.cs : catch other types of exception than XmlException to
6080 report CS1570. Fixed bug #82565.
6082 2007-08-23 Marek Safar <marek.safar@gmail.com>
6084 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6085 The number of delegate parameters has to match.
6086 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6089 2007-08-21 Marek Safar <marek.safar@gmail.com>
6091 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6092 to fix problem with private arguments.
6094 2007-08-20 Marek Safar <marek.safar@gmail.com>
6096 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6098 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6100 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6101 empty. Add cloning suport.
6103 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6105 2007-08-20 Marek Safar <marek.safar@gmail.com>
6107 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6108 to create EmptyCast. It handles EmptyConstantCast specialization for
6111 2007-08-18 Marek Safar <marek.safar@gmail.com>
6113 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6114 (EmitArrayArgument): One routine for array arguments.
6115 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6117 2007-08-17 Marek Safar <marek.safar@gmail.com>
6119 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6121 2007-08-17 Marek Safar <marek.safar@gmail.com>
6123 * anonymous.cs: MemberLookupFinal update.
6125 * class.cs (ConstructorInitializer): Is expression based.
6127 * delegate.cs: MethodGroupExpr update.
6129 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6131 (Error_MemberLookupFailed): Customizable error override.
6132 (MethodGroupExpr): Keep queried type for later usage.
6133 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6136 * expression.cs: Error_MemberLookupFailed refactoring.
6137 (New.DoResolve): Resolve as much as possible.
6138 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6139 customization for invalid member types.
6141 * statement.cs: MethodGroupExpr update.
6143 2007-08-16 Marek Safar <marek.safar@gmail.com>
6145 * modifier.cs (Check): Check all modifiers and not only accessibility
6148 2007-08-16 Marek Safar <marek.safar@gmail.com>
6150 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6151 type and not an expression.
6153 2007-08-16 Marek Safar <marek.safar@gmail.com>
6155 * statement.cs (Catch.Clone): Type and variable can be null.
6157 2007-08-16 Marek Safar <marek.safar@gmail.com>
6159 A fix for bug #81979
6160 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6161 I am really not sure whether this is the best fix.
6163 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6166 2007-08-14 Marek Safar <marek.safar@gmail.com>
6168 ** C# 3.0 Object and collection initializers (major re-write)
6170 * assign.cs (DoResolve): Initializers are not assign related.
6172 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6173 used during collection or object initialization.
6175 * expression.cs (Error_InvalidArguments): Add initializers specific
6176 messages. More will come later because it requires some general
6178 (New.DoResolve): Better error handling for unsafe types.
6179 (EmptyExpressionStatement): New class.
6180 (ElementInitializer): An object initializer expression.
6181 (CollectionElementInitializer): A collection initializer expression.
6182 (CollectionOrObjectInitializers): A block of object or collection
6184 (NewInitialize): New expression with element/object initializers.
6186 * statement.cs: Reverted object/collection initializer hacks.
6188 * typemanager.cs (CSharpName): Filter __arglist type.
6190 2007-08-09 Marek Safar <marek.safar@gmail.com>
6192 ** C# 3.0 Anonymous Types (update to the latest standard)
6194 * expression.cs (Binary.ResolveOperator): Threat all null based types
6196 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6197 (AnonymousTypeParameter): Updated.
6199 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6200 (AnonymousTypeClass): New anonymous type container.
6202 * class.cs (AddField): Return operation result.
6204 * generic.cs: Another empty TypeArguments overload.
6206 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6207 are stored at top of normal hierarchy.
6209 * typemanager.cs (CSharpName): Filter anonymous types.
6211 2007-08-09 Marek Safar <marek.safar@gmail.com>
6213 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6214 as single Concat call. How could we miss that :-(
6216 2007-08-08 Marek Safar <marek.safar@gmail.com>
6218 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6220 2007-08-07 Miguel de Icaza <miguel@novell.com>
6222 * expression.cs: Fix the previous commit, the creation of the
6223 arguments array list needs also to be conditional on the arguments
6226 * class.cs: Add a little bit of help to help narrow down problems.
6228 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6229 not try to copy in that case.
6231 * driver.cs: When building SMCS, include a new different set of
6232 default assemblies here. Do this here so we can control whether
6233 to include the default assemblies with /noconfig.
6235 2007-08-03 Marek Safar <marek.safar@gmail.com>
6237 A fix for bug #81979
6238 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6241 2007-08-03 Marek Safar <marek.safar@gmail.com>
6243 A fix for bug #82300
6245 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6246 we are in probing scope.
6248 2007-08-03 Marek Safar <marek.safar@gmail.com>
6250 A fix for bug #82301
6252 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6253 (Statement.CloneTo): Clone and not map children blocks.
6255 2007-08-03 Marek Safar <marek.safar@gmail.com>
6257 A fix for bug #82299
6259 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6262 * statement.cs (Statement.CloneTo): Clone variables before statements
6263 to allow remaping of local variables.
6265 2007-08-03 Marek Safar <marek.safar@gmail.com>
6267 A fix for bug #82296
6270 * report.cs: Log crash details for future clone problems.
6272 * statement.cs (Return.Clone): Don't clone non-existent expression.
6274 2007-08-03 Raja R Harinath <harinath@gmail.com>
6276 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6277 (Class.AddBasesForPart): Move CS0537 check here from ...
6278 * cs-parser.jay (class_declaration): ... here. Move calling of
6279 'AddBasesForPart' to ...
6280 (class_bases): ... here.
6281 (struct_declaration, interface_declaration): Update to changes.
6283 2007-08-02 Marek Safar <marek.safar@gmail.com>
6285 A fix for bug #81923
6287 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6288 conversion is allowed.
6290 2007-08-02 Marek Safar <marek.safar@gmail.com>
6292 A fix for bug #81564
6294 * ecore.cs (EventExpr): Add IsBase handling.
6296 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6299 2007-08-02 Raja R Harinath <harinath@gmail.com>
6301 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6302 * cs-parser.jay: Some whitespace cleanups.
6303 (current_delegate): New.
6305 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6306 a dummy code block, and use 'type_name' instead of 'member_name'.
6307 (interface_declaration, class_declaration): Likewise.
6308 (delegate_declaration): Likewise. Rearrange slightly and use
6310 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6311 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6313 2007-08-02 Marek Safar <marek.safar@gmail.com>
6315 A fix for bug #82039
6317 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6320 * typemanager.cs (CSharpName): Split to string overload.
6322 2007-08-02 Marek Safar <marek.safar@gmail.com>
6325 * report.cs: Updated warning CS0472.
6327 2007-08-01 Marek Safar <marek.safar@gmail.com>
6329 A fix for bug #82181
6331 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6333 2007-08-01 Marek Safar <marek.safar@gmail.com>
6335 A fix for bug #82277
6336 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6338 2007-08-01 Marek Safar <marek.safar@gmail.com>
6340 ** C# 3.0 Type Inference (major bits are working)
6342 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6343 (.ImplicitStandardConversionExists): Uses compatible.
6344 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6345 (.InferReturnType): New method.
6346 (.Compatible): Refactored.
6347 (.ResolveParameters): Uses factory to create resolved parameters.
6348 (.CompatibleMethod): Add probing mode support.
6349 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6350 clearly distinguish between 2 different operations.
6351 (LambdaMethod): Moved to lambda.cs.
6352 (AnonymousMethod): Removed unused fields and methods.
6353 (AnonymousDelegate): Simplified.
6355 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6357 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6359 * delegate.cs (Delegate): New mehods to reduce code duplication.
6360 (.GetConstructor): New method.
6361 (.GetInvokeMethod): New method.
6362 (DelegateCreation): Updated.
6364 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6366 (OverloadResolve): Made probing little bit faster.
6368 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6371 * generic.cs (TypeInferenceContext): Dummy implementation.
6373 * iterators.cs: Updated after Resolve/Define rename.
6375 * lambda.cs (LambdaExpression)
6376 (.ResolveParameters): Handles both type of arguments and type inference too.
6378 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6379 (InflateTypes): Updated.
6381 * support.cs (InflateTypes): Changed signature and updated.
6383 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6384 (MemberLookup_FindMembers): More MS tricks.
6385 (GetParameterData): Ditto.
6386 (GetDelegateParameters): Uses quick path for dynamic types.
6388 2007-08-01 Marek Safar <marek.safar@gmail.com>
6390 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6393 2007-07-31 Marek Safar <marek.safar@gmail.com>
6395 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6398 2007-07-26 Jb Evain <jbevain@novell.com>
6400 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6401 which takes a boolean 'report_errors', similar to the GetMethod.
6402 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6403 in .net 2.1, do not report errors here.
6405 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6406 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6407 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6410 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6411 of the type InternalsVisibleToAttribute before the first call
6412 to CoreLookupType which is allowed to fail (third boolean parameter
6413 to true). Because, during the resolution for a type that is not
6414 immediately found, we try to check if the type is not defined in
6415 a friend assembly, and to do so, we need the
6416 InternalVisibleToAttribute.
6418 2007-07-23 Miguel de Icaza <miguel@novell.com>
6420 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6421 feature that allows structs to be compared against null and inline
6422 the result as true or false.
6424 Notice that the same code is not permitted inside a generic block
6425 of code that would do:
6427 class Foo<T> where T : struct {
6434 It is only allowed if the type of T is not bound (no where
6435 clause). In my opinion, this CSC 2 behavior is broken but people
6436 seem to be using it (IronRuby does, a few bug reports on bugzilla
6437 have it and some people have complained about it).
6439 All of the users that depend on this behavior have code that is
6442 * report.cs (Warning, Error): make these take object arguments,
6443 not strings, as that allows us to take advantage of Format.
6445 2007-07-20 William Holmes <billholmes54@gmail.com>
6447 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6448 Left member variable for the Count.
6449 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6450 MemberName.CountTypeArguments to avoid a NRE.
6452 This code is contributed under the MIT X11 license
6454 2007-07-18 Marek Safar <marek.safar@gmail.com>
6456 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6458 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6460 * doc.cs : generic method arguments are written as ``x while generic
6461 type arguments are `x. Combined with the previous change, fixed bug
6464 2007-07-18 Raja R Harinath <rharinath@novell.com>
6467 * expression.cs (Binary.ResolveOperator): When converting
6468 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6470 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6472 * doc.cs : when T: or whatever x: is specified, it does not really
6473 check the doc comment's syntax correctness. Fixed bug #82006.
6475 2007-07-18 Marek Safar <marek.safar@gmail.com>
6477 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6478 LambdaExpression better.
6480 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6482 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6484 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6485 as it can be generated.
6487 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6490 * lambda.cs (LambdaExpression): Refactored to share same code with
6491 AnonymousMethodExpression.
6493 2007-07-17 Marek Safar <marek.safar@gmail.com>
6495 * anonymous.cs (MakeName): Include host name for easier debugging.
6496 (LambdaMethod): New class for lambda spcecific stuff.
6498 * attribute.cs: Set EmitContext return type.
6500 * class.cs: Set EmitContext return type.
6502 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6503 with null/void meaning.
6505 * iterators.cs (ContainerType): Implemented.
6507 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6509 * statement.cs (Return): Updated to lambda expressions.
6510 (Block.CloneTo): Parent can be null.
6512 2007-07-13 Marek Safar <marek.safar@gmail.com>
6514 A fix for bug #81917
6515 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6517 * class.cs (FixedField): Check whether field is in unsafe scope.
6519 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6520 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6522 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6525 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6527 2007-07-13 Marek Safar <marek.safar@gmail.com>
6529 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6530 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6533 2007-07-13 Marek Safar <marek.safar@gmail.com>
6535 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6537 2007-07-13 Marek Safar <marek.safar@gmail.com>
6539 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6540 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6542 * codegen.cs(EmitContext): Add ProbingMode flag.
6544 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6546 * driver.cs: For now set both warning values.
6548 * ecore.cs (SimpleName): Name is readonly.
6549 (MethodGroup.OverloadResolve): One quick path for probing.
6551 * expression.cs (Unary): Set Oper r/o.
6552 (Binary): Set Oper r/o.
6553 (ParameterReference): Set few instance variables as r/o.
6554 (ParameterReference.DoResolveBase): Don't capture aruments when
6556 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6557 (Arglist): arguments are private.
6558 (SizeOf): type is private and r/o.
6559 (MemberAccess): arguments are private.
6561 * report.cs: Enhanced reporting on/off capabilities.
6563 * lambda.cs: Uses ec.IsInProbingMode.
6564 (ContextualReturn): Derives from return.
6566 * rootcontext.cs: For now set both warning values.
6568 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6570 (Return.Resolve): Don't die immediately.
6571 (Block.Resolve): Speed-up probing.
6572 (Block.CloneTo): Clone only child blocks.
6574 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6576 * iterators.cs: reverted Miguel's latest change (r81925) as it
6577 breaks the build in System.
6579 2007-07-13 Miguel de Icaza <miguel@novell.com>
6581 * iterators.cs (Yield.CheckContext): Check for the iterator type
6582 also here as we can call into Yield even in codepaths that are not
6584 (MethodOrOperator is the only path that was checked).
6586 In addition to the standard check, use a more specific check for
6587 constructors to report a more verbose error.
6589 2007-07-12 Miguel de Icaza <miguel@novell.com>
6591 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6592 report the warning and continue
6594 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6595 values on the stack on the call to Emit. Use EmitStatement if
6596 possible, or using Emit + Pop if not possible. Fixes #82064
6598 2007-07-12 Raja R Harinath <rharinath@novell.com>
6600 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
6601 avoid try...finally in some cases.
6603 2007-07-10 Marek Safar <marek.safar@gmail.com>
6605 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
6607 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
6608 instead of method. Re-use standard error handling.
6609 (ConstructorInitializer.Emit): Simplified.
6611 * delegate.cs: Updated after Invocation.EmitCall change.
6613 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
6614 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
6615 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
6616 method and don't permanently changing input arguments.
6617 (MethodGroupExpr): Introduced resolved best_candidate, when method group
6618 is resolved it has one of the candidates is the best one which is later
6619 used to emit. Removed a few unused method.
6620 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
6622 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
6623 (Binary.ResolveOperator): Ditto.
6624 (ConditionalLogicalOperator.DoResolve): Ditto.
6625 (Invocation): Uses method group.
6626 (Invocation.DoResolve): Simplified.
6627 (Invocation.EmitCall): Removed useless is_static.
6628 (Invocation.Emit): Delegate to method group.
6629 (Invocation.EmitStatement): Simplified.
6630 (New): Uses method group.
6631 (MemberAccess.DoResolve): Don't destroy original expression.
6633 * statement.cs (ForEach.Resolve): Use null for no method arguments.
6635 2007-07-04 Marek Safar <marek.safar@gmail.com>
6637 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
6640 * lambda.cs: Add custom error message type.
6642 2007-07-03 Marek Safar <marek.safar@gmail.com>
6644 * lambda.cs: Simplified little bit.
6646 * parameter.cs: Introduced ImplicitLambdaParameter.
6647 (Parameters.CreateFullyResolved): New factory instead of ctor.
6651 * delegate.cs: Updated parameter creation.
6653 2007-07-03 Marek Safar <marek.safar@gmail.com>
6655 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
6658 * generic.cs: Synchronized with gmcs.
6660 2007-07-03 Marek Safar <marek.safar@gmail.com>
6662 * class.cs (Indexer): Check return type as soon as possible.
6664 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
6667 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
6669 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
6671 * parameter.cs (Parameter): Use expression type when it is available.
6673 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
6674 method modifier for the first parameter only.
6676 2007-06-24 Marek Safar <marek.safar@gmail.com>
6678 A fix for bug #81938
6679 * typemanager.cs (ChangeType): Fixed couple of char conversions.
6681 * constant.cs: Tide up an exception message.
6683 2007-06-22 Marek Safar <marek.safar@gmail.com>
6685 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
6686 an uninitialized variable is used.
6688 * expression.cs (LocalVariableReference.DoResolve): Ditto.
6690 2007-06-22 Marek Safar <marek.safar@gmail.com>
6692 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
6693 not found error handling.
6695 * expression.cs (ArrayCreation): Removed redundant fields and little bit
6697 (ArrayCreation.ResolveArrayElement): To be ready to customization.
6698 (ArrayCreation.DoResolve): Simplified.
6699 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
6700 its own resolve process.
6701 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
6703 2007-06-20 Marek Safar <marek.safar@gmail.com>
6705 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
6708 2007-06-20 Marek Safar <marek.safar@gmail.com>
6710 * cs-tokenizer.cs: Removed var related stuff.
6712 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
6713 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
6714 a type and a keyword at same time.
6716 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
6719 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
6720 implicitly typed arrays, more changes will follow.
6722 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
6724 2007-06-19 Marek Safar <marek.safar@gmail.com>
6726 * ecore.cs (VarExpr): Removed Handled field.
6728 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
6729 build-in assign functionality.
6730 (ForEach.Resolve): Removed all implicitly typed local variable code and
6732 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
6733 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
6735 2007-06-18 Marek Safar <marek.safar@gmail.com>
6737 * assign.cs: Removed implicitly typed local variable check.
6739 * expression.cs (LocalVariableReference.DoResolve): Add check for self
6740 referencing implicitly typed local variable.
6741 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
6744 * statement.cs (Fixed): Removed unsupported implicitly typed local
6747 2007-06-15 Marek Safar <marek.safar@gmail.com>
6749 * decl.cs (MemberName): Moved all Unbound stuff to parser.
6751 2007-06-14 Marek Safar <marek.safar@gmail.com>
6753 A fix for bugs #81855 and #76274
6754 * attribute.cs (AttachTo): Always set owner for global attributes to
6757 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
6760 * cs-parser.jay: Assembly and module attributes must precede all other
6761 elements except using clauses and extern alias declarations.
6763 2007-06-13 Marek Safar <marek.safar@gmail.com>
6765 A fix for bug #81748
6767 * expression.cs: More checks for non ISO-1 features.
6769 2007-06-12 Marek Safar <marek.safar@gmail.com>
6771 A fix for bug #81807
6772 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
6773 present inside switch statement and it is required by nullable check.
6775 2007-06-12 Marek Safar <marek.safar@gmail.com>
6777 A fix for bug #81840
6778 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
6779 when type matching fails.
6781 * namespace.cs: Tiny error message change.
6783 2007-06-12 Marek Safar <marek.safar@gmail.com>
6785 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
6786 reporting. Added automatic property check.
6788 * class.cs: Updated after CheckAbstractAndExtern relocation.
6789 (AEventPropertyAccessor.GetSignatureForError): Customized.
6791 2007-06-11 Marek Safar <marek.safar@gmail.com>
6793 * class.cs (DefineBaseTypes): Base type can be undefined.
6795 * ecore.cs (TypeLookup): Minor refactoring.
6796 (DoResolveAsTypeStep): Removed redundant check.
6798 * namespace.cs (Lookup): Removed redundant check.
6800 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
6801 ResolveAsTypeTerminal step.
6802 (BootstrapCorlib_*): Simplified.
6803 (PopulateCoreType): Core types can be now external.
6805 2007-06-07 Marek Safar <marek.safar@gmail.com>
6807 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
6809 (InferTypeArguments): Infers anonymous expression type arguments.
6810 (Compatible): Split to Compatible and InferTypeArguments.
6812 * lambda.cs: Updated.
6814 2007-06-08 Marek Safar <marek.safar@gmail.com>
6816 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
6818 2007-06-07 Raja R Harinath <harinath@gmail.com>
6820 Fix #80477, cs0135-2.cs, cs0135-3.cs
6821 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
6822 names to the "known" variables list.
6823 (Block.CheckInvariantMeaningInBlock): Handle the fact the
6824 parameter names are also "known".
6825 (Block.CheckError136): Remove.
6826 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
6829 2007-06-07 Marek Safar <marek.safar@gmail.com>
6831 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
6833 2007-06-06 Marek Safar <marek.safar@gmail.com>
6835 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
6836 internal error not an user error.
6838 * expression.cs (IsApplicable): Refactored to make debugging easier.
6840 * support.cs: More tricks for non-mono runtimes.
6842 * typemanager.cs (CoreLookupType): Made public.
6843 (InitSystemCore): All linq specific stuff moved to linq.cs
6845 2007-06-05 Marek Safar <marek.safar@gmail.com>
6847 * typemanager.cs (CSharpSignature): One more missing build-in types
6849 More tricks for non-mono runtime.
6851 2007-06-05 Raja R Harinath <harinath@gmail.com>
6853 * statement.cs (Block.CheckError136_InParents): Remove.
6854 (Block.AddVariable): Use GetParameterInfo instead.
6855 (ToplevelBlock.ProcessArguments): Likewise.
6857 2007-06-04 Raja R Harinath <rharinath@novell.com>
6859 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
6861 (ToplevelBlock.GetParameterInfo): Split out of ...
6862 (ToplevelBlock.GetParameterRefernce): ... this.
6863 (ToplevelBlock.ParameterMap): Remove.
6864 * expression.cs (ParameterReference): Update to use
6865 ToplevelParameterInfo.
6867 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
6870 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
6871 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
6873 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
6874 (ToplevelBlock.ProcessParameters) ... here.
6875 (ToplevelBlock..ctor): Invoke it.
6877 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
6880 * statement.cs (IKnownVariable): New interface.
6881 (LocalInfo): Implement it.
6882 (ToplevelParameterInfo): New class.
6883 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
6884 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
6885 GetKnownVariableInfo.
6887 2007-06-03 Raja R Harinath <harinath@gmail.com>
6889 Partly speed up CS0136 error checks.
6890 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
6891 'recurse' parameter.
6892 (Block.DoCheckError136): Only check errors in parameters. Move
6893 local variable checks ...
6894 (Block.AddVariable): ... here, and ...
6895 (ToplevelBlock.ResolveMeta): ... here.
6897 2007-06-02 Raja R Harinath <harinath@gmail.com>
6899 * statement.cs (Block.IsChildOf): Remove.
6901 * statement.cs (Statement.Clone): Move special case code ...
6902 (Block.CloneTo): ... here.
6904 2007-05-29 Raja R Harinath <rharinath@novell.com>
6906 * statement.cs (ToplevelBlock.container): Remove field. It's
6907 redundant with 'Parent'.
6908 (ToplevelBlock.ContainerBlock): Remove accessor.
6909 (ToplevelBlock..ctor): Update to changes. Register anonymous
6910 child with parent here, ...
6911 * cs-parser.jay (end_anonymous): ... not here. Don't modify
6913 (start_anonymous): Don't save current_block.
6914 (top_current_block): Remove.
6916 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
6917 (Block.Resolve): Update to changes.
6918 (Block..ctor): Move setting of "correct" 'Toplevel'
6919 and 'Explicit' fields to ...
6920 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
6922 2007-05-27 Raja R Harinath <harinath@gmail.com>
6925 * statement.cs (Block.Implicit): Remove.
6926 (Block): Update to changes.
6927 * flowanalysis.cs: Likewise.
6929 Mildly speed up CheckInvariantMeaningInBlock
6930 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
6931 Recursively call AddKnownVariable to all enclosing blocks.
6932 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
6933 Remove recursive calls.
6934 (Block): Update to changes.
6936 New ExplicitBlock invariants
6937 * statement.cs (Block.Explicit): New field. It points to the
6938 immediately enclosing non-implicit block.
6939 (Block..ctor): Maintain the invariant.
6940 * cs-parser.jay: Take advantage of invariant.
6942 Introduce ExplicitBlock
6943 * statement.cs (ExplicitBlock): New.
6944 (ToplevelBlock): Derive from it.
6945 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
6947 (Block.Implicit): Update to changes.
6948 * cs-parser.jay: Update to changes.
6951 * codegen.cs (EmitContext.IsLastStatement): Remove.
6952 * statement.cs (Block.DoEmit): Update to changes.
6954 2007-05-25 Raja R Harinath <rharinath@novell.com>
6956 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
6957 modifying current_block directly.
6959 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
6961 * class.cs: Implemented automatic properties (C# 3.0)
6962 Thanks to Marek for the help.
6964 2007-05-23 Raja R Harinath <rharinath@novell.com>
6966 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
6967 variable as assigned, note also that all its components are
6969 (MyBitVector.SetRange): New. Function to set multiple bits to true.
6971 2007-05-19 Marek Safar <marek.safar@gmail.com>
6973 * anonymous.cs, class.cs: Emit Compiler generated attribute when
6974 member is marked as compiler generated.
6976 * decl.cs (MemberCore): Refactored ModFlags into property.
6978 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
6979 (Check): Check only accessibility modifiers.
6981 2007-05-18 Raja R Harinath <rharinath@novell.com>
6983 Track all assignable slots in one bit array
6984 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
6985 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
6986 logic from VariableMap constructor here. Use the same 'offset'
6987 variable that's later used for computing offsets of local
6989 * flowanalysis.cs (UsageVector.parameters): Remove.
6990 (UsageVector): Update to changes.
6991 (VariableMap): Remove.
6993 Avoid creating ParameterMap in every block
6994 * statement.cs (Block.ParameterMap): Move ...
6995 (ToplevelBlock.ParameterMap): ... here.
6996 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
6998 * flowanalysis.cs (FlowBranching.param_map): Remove.
6999 (FlowBranching.UsageVector): Update to changes.
7000 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7002 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7004 * expression.cs (ParameterReference): Distinguish between block
7005 where parameter was referenced and declared.
7007 2007-05-18 Marek Safar <marek.safar@gmail.com>
7009 * flowanalysis.cs, statement.cs: Put back improved error handling.
7011 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7015 Imporved object and collection initialization (C# 3.0).
7017 2007-05-15 Marek Safar <marek.safar@gmail.com>
7019 A fix for bug #81380
7020 * expression.cs (Is.DoResolve): Only value types have constant `is'
7023 2007-05-15 Raja R Harinath <rharinath@novell.com>
7025 * statement.cs (ToplevelBlock.child): Remove.
7027 2007-05-15 Raja R Harinath <harinath@gmail.com>
7029 Rationalize ResolveMeta: refactoring
7030 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7031 out constant handling code into ...
7032 (Block.DoResolveConstants): ... this.
7034 Rationalize ResolveMeta: kill local_map
7035 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7036 (Block.AssignableSlots): New.
7037 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7038 for locals -- move code from VariableMap here. Avoid unnecessary
7040 * flowanalysis.cs (FlowBranching.local_map): Remove.
7041 (FlowBranching..ctor): Use Block.AssignableSlots.
7042 (VariableMap): Remove unused constructors.
7044 2007-05-11 Raja R Harinath <rharinath@novell.com>
7046 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7048 2007-05-11 Marek Safar <marek.safar@gmail.com>
7050 * typemanager.cs (IsFriendAssembly): Should not be called for building
7053 2007-05-09 Marek Safar <marek.safar@gmail.com>
7055 * literal.cs (NullConstant): Print null in all cases.
7057 * expression.cs (Binary.ResolveOperator): Implemented delegate
7058 comparison based on C# 2.0 changes.
7060 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7062 This code is contributed under the MIT X11 license
7064 The following enables support for several C# 3.0 language features:
7066 * cs-tokenizer.cs: Added support for the "var" keyword.
7068 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7069 Added VarExpr class to facilitate type inferencing.
7071 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7072 to support anonymous types.
7074 * assign.cs: Added support for type inferencing and initialization.
7076 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7078 * expression.cs: Added implicit array support to ArrayCreation.
7079 Added 5 types and 1 interface:
7081 IInitializable Implementing classes can inject initializing
7082 statements after object instantiation.
7084 Initializer Stores data for object initialization.
7086 AnonymousType An expression for anonymous types.
7088 AnonymousTypeParameter Stores data about an anonymous type's field.
7090 NewInitialize An expression for object initialization.
7092 CollectionInitialize An expression for collection initialization.
7094 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7097 2007-05-06 Marek Safar <marek.safar@gmail.com>
7099 A fix for bug #81500
7100 * cs-tokenizer.cs: Add special handling for coalescing operator.
7102 2007-05-06 Marek Safar <marek.safar@gmail.com>
7104 A fix for bug #81529
7105 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7106 its value from base class until it is redefined.
7108 2007-05-02 Raja R Harinath <rharinath@novell.com>
7110 Fix regression in cs0631-3.cs
7111 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7112 fallback. Make error fallback catch more cases.
7114 2007-05-01 Miguel de Icaza <miguel@novell.com>
7116 * cs-parser.jay: Allow parameters in operator declarations to have
7119 2007-04-27 Miguel de Icaza <miguel@novell.com>
7121 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7124 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7125 inside the ContextualReturn, it does not have to be an
7126 ExpressionStatement.
7128 2007-04-24 Miguel de Icaza <miguel@novell.com>
7130 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7133 2007-04-23 Miguel de Icaza <miguel@novell.com>
7135 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7136 method in two methods: ResolveNoDefine and Resolve.
7138 ResolveNoDefine will stop just after ResolveTopBlock has been
7141 Resolve will then continue by creating a method and issuing the
7142 call to method.Define ().
7144 (AnonymousMethod): Split and implement the new Resolve and
7145 ResolveNoDefine as well.
7147 * lambda.cs (LambdaExpression): Split the anonymous method
7148 resolution code into a separate routine (CoreCompatibilityTest)
7149 from DoCompatibleTest.
7151 (LambdaExpression.TryBuild): New method, this method tries to
7152 build the LambdaExpression with the given set of types to be used
7153 as the types for the various parameters of the lambda expression.
7155 If the compilation succeed with the given types, the infered type
7156 of the Anonymous method is returned, otherwise null is returned.
7158 2007-04-23 Marek Safar <marek.safar@gmail.com>
7160 A fix for bug #81414
7161 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7163 2007-04-22 Miguel de Icaza <miguel@novell.com>
7165 * cs-tokenizer.cs: Change various identifiers here from the
7166 camelCasing to the recommended Linux-like style for instance
7167 variables from the Coding Guidelines.
7169 2007-04-19 Martin Baulig <martin@ximian.com>
7172 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7173 System.Enum to System.ValueType.
7175 2007-04-13 Martin Baulig <martin@ximian.com>
7177 Rewrote implicit reference conversions. We need to distinguish
7178 between implicit reference conversions (13.1.4) and implicit
7179 boxing conversions (13.1.5).
7181 According to the spec, there's an an implicit conversion
7182 "From a one-dimensional array-type S[] to IList<T> and base
7183 interfaces of this interface, provided there is an implicit
7184 reference conversion from S to T." Note that this does not
7185 include boxing conversions.
7188 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7189 (Convert.ImplicitReferenceConversion): Split into
7190 ImplicitReferenceConversionCore() and
7191 ImplicitBoxingConversionExist().
7192 (Convert.ImplicitReferenceConversionExists): Use the new
7193 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7195 2007-04-12 Martin Baulig <martin@ximian.com>
7197 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7198 `TypeManager.null_type' checks up to the top of the method.
7200 2007-04-11 Marek Safar <marek.safar@gmail.com>
7202 A fix for bug #81350
7203 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7206 2007-04-11 Martin Baulig <martin@ximian.com>
7208 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7209 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7210 to make this work for generic classes; fixes #79561.
7212 2007-04-11 Martin Baulig <martin@ximian.com>
7214 * expression.cs (As): Add support for nullable types; fixes #79371.
7216 2007-04-11 Martin Baulig <martin@ximian.com>
7218 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7219 `type.FullName' is null; fixes #80243.
7221 2007-04-11 Martin Baulig <martin@ximian.com>
7223 * expression.cs (Invocation.IsApplicable): Don't modify the method
7224 if type inference succeeded, but the method was not applicable.
7227 2007-04-10 Marek Safar <marek.safar@gmail.com>
7229 A fix for bug #81324
7230 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7231 internal and external namespaces containers.
7233 2007-04-10 Martin Baulig <martin@ximian.com>
7235 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7236 TypeManager.DropGenericMethodArguments() so we also call
7237 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7239 2007-04-10 Martin Baulig <martin@ximian.com>
7241 * iterators.cs (Iterator.CreateIterator): Don't crash if
7242 `method.ReturnType' is null. This happens if something went wrong
7243 while resolving that typ (we already reported an error in this case).
7245 2007-04-10 Martin Baulig <martin@ximian.com>
7247 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7248 generic interfaces; report the CS0144 directly.
7250 2007-04-10 Martin Baulig <martin@ximian.com>
7252 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7253 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7255 2007-04-10 Martin Baulig <martin@ximian.com>
7257 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7259 2007-04-09 Raja R Harinath <rharinath@novell.com>
7262 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7263 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7266 * statement.cs (For.Resolve): If resolution fails, use
7269 2007-04-08 Marek Safar <marek.safar@gmail.com>
7271 * anonymous.cs (MakeName): Make faster and zero-based.
7272 (VerifyExplicitParameterCompatibility): Back to mode where generic
7273 parameter is ignored.
7274 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7276 * class.cs (EmitType): Method can emit another new method.
7278 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7280 * driver.cs: Updated.
7282 * lambda.cs: Reuse predefined empty parameters.
7284 * parameter.cs: Updated
7286 * support.cs: Implemented InflateTypes.
7288 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7289 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7291 2007-04-03 Martin Baulig <martin@ximian.com>
7295 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7296 version of TypeManager.IsOverride() which also works with generic
7299 2007-04-03 Martin Baulig <martin@ximian.com>
7304 (Convert.ExplicitReferenceConversion): We need to cast when
7305 converting from IList<T> to S[].
7307 2007-04-01 Marek Safar <marek.safar@gmail.com>
7309 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7312 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7314 2007-03-31 Marek Safar <marek.safar@gmail.com>
7316 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7317 argument and return type inferring.
7319 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7320 (ReturnType): Turned to property.
7322 * statement.cs (Return): Implemented return type inferring.
7324 * support.cs (ReflectionParameters): Use local types if possible.
7326 2007-03-30 Raja R Harinath <rharinath@novell.com>
7328 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7329 (FlowBranching.UsageVector): Update to changes.
7331 Prepare to kill 'Reachability'
7332 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7333 argument of constructor.
7335 2007-03-29 Raja R Harinath <rharinath@novell.com>
7337 Prepare to kill 'Reachability'
7338 * flowanalysis.cs (UsageVector.is_unreachable): New.
7339 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7340 'reachability', and verify they're consistent.
7343 * expression.cs (New.EmitStatement): Handle type parameters here too.
7345 2007-03-29 Martin Baulig <martin@ximian.com>
7350 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7351 CompilerGeneratedClass.
7352 (ScopeInfo.EmitScopeInstance): Make this protected.
7353 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7354 `ec.CurrentAnonymousMethod.Scope == Scope'.
7356 * statement.cs (Block.ScopeInfo): Make this a property.
7358 2007-03-27 Raja R Harinath <harinath@gmail.com>
7360 Prepare to kill 'Reachability'
7361 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7362 (FlowBranching.UsageVector.Reachability): Remove property.
7363 (FlowBranching.UsageVector.IsUnreachable): New property.
7364 (FlowBranching.UsageVector.ResetBarrier): New.
7365 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7366 * codegen.cs, statement.cs: Update to changes.
7368 2007-03-27 Martin Baulig <martin@ximian.com>
7373 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7376 2007-03-26 Raja R Harinath <rharinath@novell.com>
7378 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7379 instead of TriState. Remove all mention of TriState.
7381 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7382 replaced by a boolean. Add boolean 'is_unreachable' field, check
7383 and maintain invariants.
7385 2007-03-25 Marek Safar <marek.safar@gmail.com>
7387 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7389 2007-03-25 Marek Safar <marek.safar@gmail.com>
7391 * expression.cs: Stop using obsolete 2.0 opcodes.
7393 2007-03-25 Marek Safar <marek.safar@gmail.com>
7395 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7396 one of the latests Martin's fixes.
7398 2007-03-23 Miguel de Icaza <miguel@novell.com>
7400 * expression.cs: On BigEndian systems, swap the bytes, temporary
7401 solution until we get a new bitconverter class.
7403 2007-03-23 Martin Baulig <martin@ximian.com>
7407 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7408 "Method" and "Method`1". Normally, a cache lookup is done on the
7409 "Method" form (ie. without the generic arity), but this one makes
7410 lookups on the full form work as well.
7412 2007-03-22 Raja R Harinath <rharinath@novell.com>
7414 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7417 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7419 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7420 ordered_member_list, to TypeBuilder to store members to be defined
7421 in the order they were parsed in.
7422 - ordered_explicit_member_list contains all properties indexers
7423 and methods that are defined as explicit implementation of an
7424 interface or base class.
7425 - ordered_member_list contains all properties indexers and methods
7426 that are not defined as explicit implementation of an interface
7429 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7430 functionality in these removed classes has been replaced with
7431 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7432 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7434 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7435 to CheckForDuplications inside GetMethod and SetMethod Define Method
7436 to handle method property and indexer name conflicts.
7440 All code is contributed under the MIT/X11 license.
7442 2007-03-20 Martin Baulig <martin@ximian.com>
7444 * class.cs (TypeContainer.Interfaces): Removed; they're now
7445 included in `TypeContainer.Types'.
7447 2007-03-20 Martin Baulig <martin@ximian.com>
7449 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7451 * class.cs (TypeContainer.CreateType): New public method. This is
7452 now called before DefineType() to create the TypeBuilders.
7453 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7454 has already been created by CreateType().
7455 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7456 don't resolve our base classes here; this has been moved into
7457 DefineBaseTypes(). We're now called from CreateType().
7458 (TypeContainer.DefineBaseTypes): New private method; resolve our
7459 base classes here. We're now called from DefineType().
7462 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7463 our types first to create all the TypeBuilders. After that, call
7464 TypeContainer.DefineType() on all the types which'll resolve their
7465 base classes and setup the resolve order.
7467 2007-03-20 Martin Baulig <martin@ximian.com>
7469 * class.cs (TypeContainer.Enums): Removed; they're now included in
7470 `TypeContainer.Types'.
7472 2007-03-20 Martin Baulig <martin@ximian.com>
7475 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7476 (TypeContainer.DoResolveMembers): Call DefineType() on our
7477 `compiler_generated' classes; moved here from DefineNestedTypes().
7480 (RootContext.ResolveTree): Call ResolveMembers() on all
7481 TypeContainer's in the `type_container_resolve_order'.
7483 2007-03-19 Marek Safar <marek.safar@gmail.com>
7485 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7487 2007-03-17 Marek Safar <marek.safar@gmail.com>
7489 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7490 implementation flags.
7492 2007-03-17 Marek Safar <marek.safar@gmail.com>
7494 * class.cs: More optimizations for type parameters.
7496 2007-03-15 Marek Safar <marek.safar@gmail.com>
7498 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7500 * ecore.cs, parameter.cs: More common code for both corlibs.
7502 * typemanager.cs (IsGenericMethod): Simplified.
7504 2007-03-15 Raja R Harinath <rharinath@novell.com>
7506 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7508 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7510 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7511 unconditionally. Simplify explanation.
7512 (Try.Resolve, Using.Resolve): Likewise.
7514 2007-03-15 Martin Baulig <martin@ximian.com>
7518 * decl.cs (DeclSpace): If we're a partial class, use our
7519 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7521 2007-03-15 Raja R Harinath <rharinath@novell.com>
7523 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7525 (FlowBranching.UsageVector): Update to changes.
7526 (FlowBranching.MergeSiblings): Likewise.
7527 * statement.cs: Likewise.
7529 2007-03-15 Martin Baulig <martin@ximian.com>
7534 (MemberCache): Added a special .ctor for type parameters.
7537 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7540 2007-03-09 Martin Baulig <martin@ximian.com>
7542 * enum.cs (Enum): Make this a TypeContainer.
7543 (EnumMember): Derive from `Const'.
7546 (Const.DoResolveValue): New protected virtual method; move most of
7547 the functionality of ResolveValue() here so we can override it in
7549 (Const.CreateConstantReference): Make this virtual.
7551 * class.cs (Kind): Add `Kind.Enum'.
7552 (TypeContainer.Emit): Don't emit the enums here; they're already
7553 in the `RootContext.typecontainer_resolve_order'.
7555 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7556 here; they're already in the `typecontainer_resolve_order'.
7558 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7559 TypeManager.DropGenericTypeArguments().
7562 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7563 (TypeManager.IsEnumType): Likewise.
7564 (TypeManager.EnumToUnderlying): Likewise.
7565 (TypeManager.IsEqual): Add support for enums.
7567 2007-03-12 Raja R Harinath <rharinath@novell.com>
7569 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7570 DefaultParameterValueAttribute to be undefined, say if System.dll
7573 2007-03-11 Marek Safar <marek.safar@gmail.com>
7575 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7578 2007-03-10 Marek Safar <marek.safar@gmail.com>
7580 * class.cs, parameter.cs: Unified parameters verification.
7582 2007-03-08 Martin Baulig <martin@ximian.com>
7584 * cs-parser.jay (constructor_header): Pass the location to the
7585 newly created TopLevelBlock.
7587 2007-03-07 Martin Baulig <martin@ximian.com>
7589 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7591 2007-03-06 Miguel de Icaza <miguel@novell.com>
7593 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7594 with the changes from David, fixes the build.
7596 2007-03-05 David Mitchell <dmitchell@logos.com>
7598 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
7599 and its base interfaces to a one-dimensional array type S[],
7600 provided there is an implicit or explicit reference conversion
7603 2007-03-03 Marek Safar <marek.safar@gmail.com>
7605 * cs-tokenizer.cs: Implemented basic linq grammar.
7607 * driver.cs: Set linq lang version on demand.
7609 2007-02-26 Marek Safar <marek.safar@gmail.com>
7611 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
7613 2007-02-25 Marek Safar <marek.safar@gmail.com>
7615 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
7618 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
7620 Check property and event extern attributes.
7622 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
7625 2007-02-24 Marek Safar <marek.safar@gmail.com>
7627 A fix for bug #80407
7628 * ecore.cs: Don't report ambiguity error when methods have same parent.
7630 2007-02-23 Marek Safar <marek.safar@gmail.com>
7632 A fix for bug #80878
7633 * class.cs, cs-parser.jay: Event property can host anonymous methods.
7635 2007-02-22 Marek Safar <marek.safar@gmail.com>
7637 * attribute.cs: Enable ExtensionAttribute presence test.
7639 2007-02-22 Marek Safar <marek.safar@gmail.com>
7641 * class.cs: Warn about missing GetHashCode only when Equals is override.
7643 * decl.cs: Check accessibility of type arguments.
7645 * typemanager.cs: Correctly report nullable array.
7647 2007-02-20 Marek Safar <marek.safar@gmail.com>
7649 * class.cs, report.cs: Capture more details when things go wrong.
7651 2007-02-20 Marek Safar <marek.safar@gmail.com>
7653 A fix for bug #80650
7654 * cs-parser.jay: Anonymous container starts at constructor declaration
7655 and not at block beginning because it has to be usable in constructor
7658 * statement.cs: Use context location and not block one for error reporting.
7660 2007-02-18 Marek Safar <marek.safar@gmail.com>
7662 A fix for bug #78712
7663 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
7666 2007-02-18 Marek Safar <marek.safar@gmail.com>
7668 A fix for bug #80493 by Atsushi Enomoto
7669 * cs-parser.jay: Ignore invalid attribute target.
7671 2007-02-18 Marek Safar <marek.safar@gmail.com>
7673 * cs-tokenizer.cs: Ignore '\0' as white space character.
7675 2007-02-17 Miguel de Icaza <miguel@novell.com>
7677 * cs-parser.jay: Add support for lambda expressions to the mcs
7680 * lambda.cs: Only clone when we are probing, not on the final call
7681 (Compatible is the final call).
7683 * statement.cs (CloneContext): Introduce class to provide block
7684 remapping during clone.
7686 All statements Clone themselves now.
7688 (Clone): special handling for blocks, when we clone a block, we
7689 register the block inside this routine, as children of the block
7690 might trigger a lookup.
7692 * expression.cs: Add support for CloneContext in all expressions.
7694 2007-02-17 Marek Safar <marek.safar@gmail.com>
7696 A fix for bug #80493
7697 * statement.cs: Report ambiguous warning when interfaces are not related.
7699 2007-02-15 Marek Safar <marek.safar@gmail.com>
7701 C# 3.0 extension methods.
7703 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
7704 cannot be used directly.
7706 * class.cs (Class.Emit): Emit extension attribute if any class method
7707 is extension method.
7708 (Method.Define): Add basic extension method validation conditions.
7709 (Method.Emit): Emit extension attribute for method.
7711 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
7712 extension method exists. Currently we follow same approach as Microsoft
7713 does, emit even if a method or a class are private but this can change
7716 * cs-parser.jay: Add handling of `this' keyword in method parameters
7719 * decl.cs (DeclSpace.IsStaticClass): New property.
7720 (MemberCache.FindExtensionMethods): Looks for extension methods with
7721 defined name and extension type.
7723 * doc.cs: Updated after OverloadResolve changes.
7725 * driver.cs: Add new soft reference to System.Core.dll.
7727 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
7728 (ExtensionMethodGroupExpr): Represents group of extension methods.
7730 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
7731 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
7732 to MethodGroupExpr and made non-static for easier customization.
7733 (Invocation.DoResolve): Add extension method lookup when no standard
7735 (MemberAccess.DoResolve): Try extension methods if no member exists.
7737 * modifiers.cs: Add METHOD_EXTENSION modifier.
7739 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
7740 as well as candidate extension type.
7741 (ComputeNamespaces): When assembly constains extension methods registers
7743 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
7744 extension method lookup.
7745 (Namespace.LookupExtensionMethod): Looks for extension method in this
7747 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
7748 find a method which matches name and extensionType.
7750 * parameter.cs (Parameter): Add This modifer.
7751 (HasExtensionMethodModifier): New property.
7752 (Resolve): Add extension parameter check.
7753 (ModFlags): turned to property to exclude this modifier as it is not real
7755 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
7757 * support.cs (ParameterData): Add ExtensionMethodType.
7758 (ReflectionParameters): Implemented ExtensionMethodType interface property.
7760 * typemanager.cs: Add type and ctor extension attribute type.
7762 2007-02-15 Miguel de Icaza <miguel@novell.com>
7764 * report.cs (DisableErrors, EnableErrors): used to prevent error
7765 output when we are "trying" to compile various methods with
7768 * ecore.cs (Expression): Add Clone method that calls the virtual
7769 CloneTo method. The current CloneTo method in Expression throws
7770 an exception so we can track down all the places where this must
7771 be implemented (not using abstract, because that would be a lot of
7772 up-front-work before we can start testing the implementation
7775 Important: we only need Clone capabilities for expressions created
7776 by the parser, as the expressions we will be cloning are
7777 expressions in the pre-resolved state. This vastly simplifies
7780 (SimpleName): Add CloneTo that does nothing.
7781 (EmptyCast): Add CloneTo.
7783 * expression.cs (Binary): Implement CloneTo.
7784 (Invocation.IsApplicable): Store the current ec in
7785 EmitContext.TempEc and restore it on return. This is used so we
7786 do not have to sprinkle hundres of methods with an extra
7787 EmitContext, we know that the only user is the lambda expression
7788 ImplicitConversionExists code.
7790 (Argument): Add Cloning capabilities.
7791 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
7792 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
7793 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
7794 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
7795 IndexerAccess): Add Clone capability.
7797 (LocalVariableReference, This): TODO: needs cloned Block mapping.
7799 (Argument): Add cloning capability.
7801 * assign.cs (Assign): Implement CloneTo.
7803 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
7805 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
7806 version by calling Convert with the EmitContext (that we are
7807 currently storing in ec, this is not great, but will do for now,
7808 to avoid passing EmitContext parameters to hundreds of functions
7809 that do not need them now).
7811 (SetExpression): Remove, it is not needed.
7813 (ContextualReturn): Implement CloneTo.
7815 * statement.cs (Statement): Implement cloning infrastructure,
7816 similar to expressions.
7818 (Block): Partial implementation of Clone for statements.
7820 (Return): Implement clone.
7822 * constant.cs (Constant.CloneTo): New method, does nothing.
7824 * codegen.cs (TempEc): Add a static EmitContext as a temporary
7825 solution, until we decide how to exactly do this.
7827 2007-02-14 Marek Safar <marek.safar@gmail.com>
7829 A fix for bug #80493
7830 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
7831 a property is override we need to use second accessor.
7833 2007-02-13 Marek Safar <marek.safar@gmail.com>
7835 A fix for bug #80418
7836 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
7839 2007-02-13 Marek Safar <marek.safar@gmail.com>
7841 Another fix for bug #80749
7842 * pending.cs: Abstract class has priority over interfaces.
7844 2007-02-13 Marek Safar <marek.safar@gmail.com>
7846 Another fix for bug #80749
7847 * pending.cs: Abstract class has priority over interfaces.
7849 2007-02-13 Marek Safar <marek.safar@gmail.com>
7851 Another fix for bug #80749
7852 * pending.cs: Abstract class has priority over interfaces.
7854 2007-02-13 Marek Safar <marek.safar@gmail.com>
7856 Another fix for bug #80749
7857 * pending.cs: Abstract class has priority over interfaces.
7859 2007-02-13 Marek Safar <marek.safar@gmail.com>
7861 * class.cs Better error message.
7863 * driver.cs: Add shorter versions of -optimize option.
7865 2007-02-13 Martin Baulig <martin@ximian.com>
7867 * class.cs (Constructor.Emit): Check the return value of
7868 ec.ResolveTopBlock() and return on error.
7870 2007-02-13 Raja R Harinath <rharinath@novell.com>
7872 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
7873 message to fix error message regression.
7875 2007-02-12 Marek Safar <marek.safar@gmail.com>
7877 * delegate.cs: Delegate creation expression cannot be of Nullable type.
7879 2007-02-12 Marek Safar <marek.safar@gmail.com>
7881 A fix for bug #80749
7882 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
7883 its parent container.
7885 * class.cs (DefineFieldInitializers): Each initializer can has different
7888 * const.cs: Updated.
7890 2007-02-11 Miguel de Icaza <miguel@novell.com>
7892 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
7893 now all the heavy lifting to check that embedded statements or
7894 expressions have the right form is done in the ContextualReturn.
7896 (ContextualReturn): New class.
7898 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
7899 method that can be invoked to report 201, so we do not replicate
7902 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
7904 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
7905 treating tabs as spaces.
7907 2007-02-09 Marek Safar <marek.safar@gmail.com>
7909 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
7910 * assign.cs: Use full implicit conversion for right side check.
7912 2007-02-09 Marek Safar <marek.safar@gmail.com>
7914 * statement.cs (Switch): Switch over boolean type is not standardized.
7916 2007-02-08 Marek Safar <marek.safar@gmail.com>
7918 A fix for bug #80755
7919 * decl.cs (FindBaseEvent): Don't use method cache for events.
7921 2007-02-07 Marek Safar <marek.safar@gmail.com>
7923 * cs-parser.jay: Better syntax error handling.
7925 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
7926 instead of underlying type value.
7928 2007-02-06 Marek Safar <marek.safar@gmail.com>
7930 * driver.cs: Check define identifier before is registered.
7932 * namespace.cs: Use existing error message.
7934 * report.cs: New warning.
7936 2007-02-06 Marek Safar <marek.safar@gmail.com>
7938 A fix for bug #80742
7939 * expression.cs: Delegate Invoke method can be called directly.
7941 2007-02-06 Marek Safar <marek.safar@gmail.com>
7943 A fix for bug #80676
7944 * class.cs (IsEntryPoint): The Main method can have params modifier.
7946 2007-02-04 Miguel de Icaza <miguel@novell.com>
7948 * parameter.cs (Parameter, Parameters): Add Clone method.
7950 * anonymous.cs (Compatible): Turn method into virtual method, so
7951 LambdaExpression can implement a different behavior.
7953 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
7954 out the basic checking here, so it can be used by
7957 * lambda.cs: Introduce "Compatible" function that will do the
7960 2007-02-02 Marek Safar <marek.safar@gmail.com>
7962 * attribute.cs: Unified one error message.
7964 * class.cs (Class): Use type attributes and not properties to test static
7966 (IsEntryPoint): Don's pass local variable.
7968 * convert.cs: Removed duplicate check.
7970 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
7972 * driver.cs: Don't crash when soft reference does not exist.
7974 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
7975 (UsingEntry): Removed redundant allocation.
7977 * parameter.cs: Add fast path for type parameters.
7979 * support.cs: Don't allocate attribute when it's not used.
7981 2007-01-30 Miguel de Icaza <miguel@novell.com>
7984 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
7985 this into a virtual method, so we can override it in LambdaExpression.
7987 * driver.cs: Improve diagnostics in case of failure.
7989 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
7990 write a function that is slightly more complex and that parses:
7992 type identifier [, type identifier]* )
7994 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
7997 (canEmpty ? i >= 0 : i > 0)
7999 2007-01-30 Raja R Harinath <rharinath@novell.com>
8001 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8002 exception on possibly valid code.
8004 2007-01-29 Raja R Harinath <rharinath@novell.com>
8006 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8008 (parse_opt_type_arguments): Remove. It's almost the same as
8010 (parse_namespace_or_typename): Use parse_less_than.
8012 2007-01-28 Miguel de Icaza <miguel@novell.com>
8014 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8015 this bug took a few hours to find, because the state saved and
8016 restored by PushPosition and PopPosition was ignoring the state of
8017 parse_generic_less_than.
8019 I can also now remove the handling of OP_LT and OP_GT, this solves
8022 * cs-tokenizer.cs: store the location for the ARROW token, we use
8025 (PushPosition, PopPosition): save/restore also `current_token',
8026 restore `parse_generic_less_than' (was missing).
8028 (parse_opt_type_arguments): use parse_type, not
8029 parse_namespace_or_typename to parse types.
8031 * lambda.cs: Empty new file, will eventually have the lambda
8032 expression implementation.
8034 * lambda.test: used to test the internal tokenizer.
8036 * report.cs (FeatureIsNotISO1): Rename from
8037 FeatureIsNotStandardized, because it was about the language level
8038 (1 vs 2) it was not about standarization.
8040 (FeatureRequiresLINQ): New.
8042 * support.cs (SeekableStreamReader): Only require that the reader
8043 is a TextReader, not a StreamReader, so we can plug StringReader.
8045 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8046 given position in the input stream the following tokens can be
8047 parsed as a type followed by an identifier.
8049 (is_punct): after a '(' if parse_type_and_parameter returns true,
8050 then return a special token OPEN_PARENS_LAMBDA which is used to
8051 avoid reduce/reduce errors in the grammar for the
8052 lambda_expression rules.
8054 (parse_type): implement a type parser inside the
8055 tokenizer, the parser only returns true or false depending on
8056 whether the input at a given position can be parsed as a type.
8058 (peek_token): new method used during type parsing.
8060 2007-01-28 Raja R Harinath <rharinath@novell.com>
8063 * anonymous.cs (ScopeInfo.InflateParameters): New.
8064 (AnonymousContainer.Resolve): Use it to redirect types of
8065 delegate parameters.
8067 2007-01-27 Raja R Harinath <rharinath@novell.com>
8070 * expression.cs (Error_InvalidArguments): Don't use two different
8071 messages for CS1503. Use ExtraInformation and
8072 SymbolRelatedToPreviousError instead.
8075 * decl.cs (DeclSpace.initialize_type_params): Don't access
8076 'type_params' of a partial class directly.
8078 2007-01-26 Miguel de Icaza <miguel@novell.com>
8080 * constant.cs: Removed a handful of out-of-range checks that were
8083 2007-01-25 Marek Safar <marek.safar@gmail.com>
8085 * expression.cs (CheckUselessComparison): Add additional check for char
8088 * namespace.cs: Fixed typo.
8090 2007-01-23 Miguel de Icaza <miguel@novell.com>
8092 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8093 gone, instead we inline the test, preventing the needless casts to
8094 longs, ulongs and doubles for the parameters, avoiding calls to
8095 methods that overchecked stuff, and instead inlined things
8098 2007-01-20 Marek Safar <marek.safar@gmail.com>
8100 * cs-parser.jay: Better parameter error handling.
8102 2007-01-17 Marek Safar <marek.safar@gmail.com>
8104 A fix for bug #80368, #80522
8105 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8106 whether array initializer contains constants only.
8107 (ArrayCreation.Emit): Use better formula to decide when
8108 are array initializers for static initialization.
8109 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8110 have to emit even constants otherwise they are pre-initialized.
8112 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8113 Raja R Harinath <rharinath@novell.com>
8115 Fix emit order of 'get' vs. 'set'.
8116 * support.cs (Accessors): New.
8117 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8118 Note the order in which accessors are declared in the source.
8119 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8120 Refactored from Property.Define and Indexer.Define.
8121 (PropertyBase.DefineAccessors): New helper that calls the above in
8122 appropriate order as noted by the parser.
8123 (Property.Define, Indexer.Define): Update to changes.
8124 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8126 2007-01-17 Raja R Harinath <rharinath@novell.com>
8128 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8129 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8130 there's an implicit conversion from the current type to the target
8131 type before converting the underlying constant.
8133 2007-01-16 Marek Safar <marek.safar@gmail.com>
8135 * const.cs (ResolveValue): Updated after constant conversion was made more
8138 * constant.cs (GetAttributableValue): constant to object conversion is
8139 used for attributes only.
8140 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8141 constant conversions.
8142 (LongConstant.ConvertImplicitly): Ditto.
8144 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8145 (ImplicitConversionStandard): Handle constant conversion as extra step.
8146 It solves the issue when constant conversion was called indirectly like
8147 inside array initializer and constant folding was skipped.
8149 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8152 * statement.cs(ImplicitConversionStandard): Updated after constant
8153 conversion was made more generic.
8155 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8157 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8158 Constraints, solves the problem where the compiler incorrectly
8159 reported that a type parameter was not constrained to a class (Bug
8162 2007-01-14 Marek Habersack <grendello@gmail.com>
8164 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8166 2007-01-14 Marek Safar <marek.safar@gmail.com>
8168 A fix for bug #80368
8169 * assign.cs (FieldInitializer): New class implements field
8170 initializer statement.
8172 * attribute.cs: Update after FieldMember rename.
8174 * class.cs (PropertyBasedMember): New common class for property based
8176 (InterfaceMemberBase): New base class for all members which can be used as
8177 an interface members.
8178 (MethodCore): Moved really common code to InterfaceMemberBase.
8179 (Method.Define): Equal and GetHasCode detection is relevant for methods
8181 (MethodData.Define): Don't assume that public event implements an
8182 interface automatically.
8183 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8185 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8186 (FieldMember): Merged with FieldBase.
8187 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8188 event extern modifier can be used.
8189 (EventField.EventFieldAccessor): Moved event field specific code here.
8190 (Event.AllowedModifiers): Even event can be extern.
8191 (Event.FindOutBaseMethod): New override specific to events.
8192 (Indexer.parameters): Reintroduce parameters because base class holds
8193 only properties common data.
8194 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8195 need do extra parameters check.
8197 * const.cs: Update after FieldMember rename.
8199 * decl.cs (MemberCache.FindBaseEvent): New method.
8201 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8202 to reflect that indexer is now derived from PropertyBased.
8204 * ecore.cs (GetMemberType): Made public.
8205 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8208 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8210 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8211 (RegisterEvent): Removed.
8212 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8213 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8215 2007-01-11 Raja R Harinath <rharinath@novell.com>
8218 * statement.cs (CollectionForeach.TryType): Prefer generic
8219 GetEnumerator over non-generic variant. Fix code to follow comments.
8221 2007-01-09 Raja R Harinath <rharinath@novell.com>
8224 * support.cs (ReflectionParameter): Don't use an invalid index on
8225 the generic parameter data.
8227 2007-01-08 Miguel de Icaza <miguel@novell.com>
8229 * driver.cs: Just add a tiny bit of infrastructure.
8231 2007-01-02 Marek Safar <marek.safar@gmail.com>
8233 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8234 where field type is struct from current assembly.
8236 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8239 2007-01-02 Marek Safar <marek.safar@gmail.com>
8241 A fix for bug #80381
8242 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8245 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8247 (Namespace.LookupType): Always use core types from corlib when speficied.
8249 * report.cs: A new warning.
8251 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8252 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8253 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8255 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8256 (InitCoreTypes): Set expression type of object_type and value_type
8257 immediately after lookup.
8259 2007-01-01 Miguel de Icaza <miguel@novell.com>
8261 * cs-tokenizer.cs: Accept Pc class characters (Connector
8262 Punctuation) as valid identifiers. Fixes #78259
8264 * expression.cs (Invocation.DoResolve): Moved the check for the
8265 use of `this' for doing method calls to the Invocation resolution
8266 step, after overload resolution has taken place instead of doing
8267 the check at the low-level `This.DoResolve' level.
8269 The `This.DoResolve'(appens before overload resolution, so it has
8270 no way of knowing if the method that will be called will be
8271 instace or static, triggering an erroneous report for cs0188 (Bug
8274 We now do the check for instance method invocations after we know
8275 what method will be called.
8277 (This.CheckThisUsage): Move the actual use of this structure
8278 checking into its own method and expose it.
8280 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8283 Exceptions: Null.ConvertImplicitly,
8284 Constant.ImplicitConversionRequired as there are too many call
8285 sites for passing the ec.
8287 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8288 EmitContext, if the value is null, then we do not try to provide
8289 the extra information from the error (If a userdefined conversion
8290 exists, as UserDefinedConversion requires a non null-EmitContext).
8294 2006-12-30 Raja R Harinath <rharinath@novell.com>
8296 * flowanalysis.cs (MyBitVector): Document some invariants.
8297 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8298 introduced below, and add a couple of others,
8300 2006-12-30 Marek Safar <marek.safar@gmail.com>
8302 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8303 GetPropertyFromAccessor and GetEventFromAccessor.
8305 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8306 overrides non-obsolete one.
8307 (Indexer.Define): Error message has been moved to the parser.
8309 * cs-parser.jay: Better syntax errors handling.
8311 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8312 when an invocation has no arguments.
8314 * ecore.cs: Removed not used caching.
8316 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8319 * report.cs: Add a new warning.
8321 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8323 * typemanager.cs (enumeration_type): Removed.
8324 (CSharpSignature): Reuses IsSpecialMethod.
8325 (IsEqual): Hack for MS BCL.
8326 (GetPropertyFromAccessor): New method.
8327 (GetEventFromAccessor): New method.
8328 (IsSpecialMethod): Fixed to handle more cases.
8330 2006-12-30 Marek Safar <marek.safar@gmail.com>
8332 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8333 Made white spaces array static.
8335 * ecore.cs (RemoveGenericArity): Optimized.
8337 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8339 (MyBitVector.initialize_vector): Simplified.
8341 2006-12-22 Miguel de Icaza <miguel@novell.com>
8343 * ecore.cs: Am not entirely happy with this hack, but it seems to
8344 address the issue in 80257 (a small test case for
8347 I set the MethodGroupExpr.Type to an internal compiler type
8348 (itself in this case) to force the resolution to take place. Why
8349 it does not take place with a null is beyond me.
8351 2006-12-20 Marek Safar <marek.safar@gmail.com>
8353 A fix for bug #80288
8354 * expression.cs (ResolveOperator): Consider user defined conversion for
8355 logical and operator too.
8356 (EmitBranchable): Optimization for logical and when full constant folding
8357 could not be applied but one operand is constant.
8359 2006-12-19 Marek Safar <marek.safar@gmail.com>
8361 * class.cs (GetClassBases): Write 5 times every day, will never use
8362 FullName for error reporting.
8364 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8366 2006-12-19 Martin Baulig <martin@ximian.com>
8368 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8369 the symbol file info here.
8371 2006-12-18 Marek Safar <marek.safar@gmail.com>
8373 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8374 of `elseif' is taking then following sections are not taking.
8375 Fixes an issue reported on mono mailing list.
8377 2006-12-18 Marek Safar <marek.safar@gmail.com>
8379 A fix for bug #80300
8380 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8381 a caller is not taking.
8383 2006-12-18 Raja R Harinath <rharinath@novell.com>
8385 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8386 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8387 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8388 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8389 * class.cs: Update to changes.
8391 2006-12-17 Marek Safar <marek.safar@gmail.com>
8393 A fix for bug #79934
8394 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8397 * class.cs (ResolveMembers): Register an iterator in current container and
8400 2006-12-16 Raja R Harinath <rharinath@novell.com>
8403 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8404 satisfy a params annotated parameter.
8406 2006-12-16 Marek Safar <marek.safar@gmail.com>
8408 A fix for bug #77014
8409 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8410 paramters correctly and not rely on hacks in Parameters class.
8411 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8413 (Invocation.VerifyArgumentsCompat): Ditto.
8414 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8417 * parameter.cs (HasParams): Don't assume that params is the last one.
8419 * support.cs (ReflectionParameters.ctor): Look for params attribute
8421 (ReflectionParameters.ParameterType): Removed hack when we returned last
8422 parameter for out of range parameters.
8423 (ParameterName, ParameterModifier): Ditto.
8425 2006-12-14 Marek Safar <marek.safar@gmail.com>
8427 A fix for bug #79987
8428 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8429 when assembly is not CLS compliant but type is. I have no idea why is this
8432 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8434 2006-12-13 Miguel de Icaza <miguel@novell.com>
8436 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8437 in struct constructors, they are basically no-ops.
8439 2006-12-12 Marek Safar <marek.safar@gmail.com>
8441 * cs-tokenizer.cs (Position): Save preprocessor status too.
8443 2006-12-12 Marek Safar <marek.safar@gmail.com>
8445 A fix for bug #77794
8446 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8448 2006-12-12 Marek Safar <marek.safar@gmail.com>
8450 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8452 (pp_expr): Report error for an invalid expression.
8453 (handle_preprocessing_directive): Simplified; add more error checking.
8455 2006-12-11 Marek Safar <marek.safar@gmail.com>
8457 A fix for bug #74939
8458 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8459 directives handling.
8461 2006-12-10 Marek Safar <marek.safar@gmail.com>
8463 A fix for bugs #80093, and #75984
8464 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8465 logic, it seems to me as it worked before "by coincidence".
8466 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8467 (cleanup): Enabled endif check.
8469 2006-12-09 Marek Safar <marek.safar@gmail.com>
8471 A fix for bug #80162
8472 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8473 enumerators are never ambiguous.
8475 2006-12-08 Raja R Harinath <rharinath@novell.com>
8478 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8480 2006-12-06 Marek Safar <marek.safar@gmail.com>
8482 A fix for bug #80144
8483 * class.cs (EventProperty.Define): Explicit implementation means
8484 that an even is used.
8486 2006-12-06 Marek Safar <marek.safar@gmail.com>
8488 Fixes the operators implementation (part II)
8490 * cfold.cs (DoConstantNumericPromotions): Renamed to
8491 DoBinaryNumericPromotions and simplified.
8492 (BinaryFold): Couple of conversion fixes; simplified.
8494 * constant.cs, ecore.cs, literal.cs
8495 (ToType): Renamed to ConvertImplicitly.
8496 (Reduce): Renamed to ConvertExplicitly.
8498 * class.cs, convert.cs: Updated.
8500 * expression.cs: TryReduce doesn't throw an exception.
8502 2006-12-01 Marek Safar <marek.safar@gmail.com>
8504 A fix for bug #80108
8505 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8508 2006-11-30 Marek Safar <marek.safar@gmail.com>
8510 Fixes unary operators implementation (part I)
8513 * cfold.cs (Error_CompileTimeOverflow): Made internal
8515 * const.cs (IConstant): Changed to use reference to constant and
8516 not constant itself.
8517 Updated IConstant implementations.
8519 * constant.cs (CreateConstant): New factory method.
8520 Updated IConstant implementation.
8522 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8524 * ecore.cs: Updated to use CreateConstantReference.
8526 * enum.cs: Reflects IConstant changes.
8528 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8530 * literal.cs (NullConstant): Change to be independently usable.
8532 2006-11-29 Martin Baulig <martin@ximian.com>
8534 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8535 we need to emit the scope initializer before calling the base .ctor.
8537 * anonymous.cs: Merged back from the new anonymous methods branch.
8538 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8540 * expression.cs (ParameterReference.DoResolveBase): Create a
8541 "normal" ScopeInfo when capturing parameters rather than using the
8542 root scope; this makes things work with anonymous methods having
8546 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8548 2006-11-22 Marek Safar <marek.safar@gmail.com>
8550 A fix for bug #79987
8551 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8552 check to a base class.
8553 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8554 only when assembly has missing attribute.
8555 * report.cs: Update.
8557 2006-11-21 Marek Safar <marek.safar@gmail.com>
8559 * cs-tokenizer.cs: Merged with gmcs version.
8561 2006-11-20 Marek Safar <marek.safar@gmail.com>
8564 * cs-parser.jay: Better error message when partial keyword is misplaced.
8566 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8568 A fix for bug #79810
8569 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8570 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8571 a RuntimeWrappedException by default.
8573 2006-11-18 Marek Safar <marek.safar@gmail.com>
8575 A fix for bug #79843
8576 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8578 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8580 2006-11-18 Marek Safar <marek.safar@gmail.com>
8582 * driver.cs, namespace.cs: Uses faster IndexOf version.
8584 2006-11-17 Marek Safar <marek.safar@gmail.com>
8586 A fix for bug #79941
8587 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8589 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8590 even if internal name is different.
8591 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8592 (UserDefinedConversion): Simplified as the operators cannot be internal.
8593 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8595 (MethodLookup): Replaced EmitContext with parentType.
8596 * expression.cs: Updated.
8598 2006-11-09 Raja R Harinath <rharinath@novell.com>
8600 * driver.cs (BadAssembly): Handle all the ugliness of
8601 DefineDynamicAssembly.
8603 2006-11-08 Raja R Harinath <rharinath@novell.com>
8605 Address parts of #58244 -- most of what's left is in the runtime
8606 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
8607 CS1509 error checks, and handle them for all assembly loads, not
8608 just the first invocation.
8609 (LoadModule): Likewise. Move handling of 'adder_method' ...
8610 * codegen.cs (AssemblyClass.AddModule): ... here.
8612 2006-11-02 Marek Safar <marek.safar@gmail.com>
8614 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
8615 IEnumerable<T> is ambiguous.
8617 2006-10-31 Marek Safar <marek.safar@gmail.com>
8619 A fix for bug #67689
8620 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
8621 GetEnumerator is ambiguous.
8623 * report.cs: Add new warning.
8625 2006-10-29 Marek Safar <marek.safar@gmail.com>
8627 A fix for bug #78602
8628 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8629 to protected member can be nested type.
8631 2006-10-28 Marek Safar <marek.safar@gmail.com>
8633 A fix for bug #78965
8634 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
8635 to protected member must derive from current type.
8637 2006-10-27 Marek Safar <marek.safar@gmail.com>
8639 assign.cs: Reuses error method.
8641 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
8642 instead of type for constants.
8643 (Expression.Error_ValueAssignment): Common error method.
8645 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
8648 2006-10-27 Marek Safar <marek.safar@gmail.com>
8650 A fix for bug #79081
8651 * expression.cs (MemberAccess.DoResolve): Check nested type
8654 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
8656 * doc.cs : nested delegates were not handled. Fixed bug #79754.
8658 2006-10-26 Marek Safar <marek.safar@gmail.com>
8660 A fix for bug #76591
8661 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
8663 2006-10-26 Marek Safar <marek.safar@gmail.com>
8665 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
8666 type forwarder of the same type multiple times.
8668 2006-10-26 Raja R Harinath <rharinath@novell.com>
8671 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
8672 instance as an rvalue, even when we later resolve as an lvalue.
8674 2006-10-25 Martin Baulig <martin@ximian.com>
8676 * anonymous.cs: Fix #79673.
8678 2006-10-24 Marek Safar <marek.safar@seznam.cz>
8680 A fix for bug #79666
8681 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
8682 ignored when is optimized (= default value) as its value is already set.
8684 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8686 A fix for bug #79724
8687 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
8688 TypeContainer for type lookup.
8690 2006-10-23 Marek Safar <marek.safar@seznam.cz>
8692 A fix for bug #79231
8693 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
8694 * expression.cs (OverloadResolve): Always convert type name for
8696 (ResolveNamespaceOrType): Don't confuse a nested type with any
8699 2006-10-18 Martin Baulig <martin@ximian.com>
8701 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
8703 2006-10-17 Miguel de Icaza <miguel@novell.com>
8705 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
8706 an int32, but requesting an int64 from the conversion
8708 2006-10-12 Martin Baulig <martin@ximian.com>
8711 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
8713 2006-10-12 Martin Baulig <martin@ximian.com>
8716 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
8718 2006-10-11 Miguel de Icaza <miguel@novell.com>
8720 * convert.cs: Remove broken code: I was doing the "Existance"
8721 tests for Implicit conversions.
8723 2006-10-10 Miguel de Icaza <miguel@novell.com>
8725 * convert.cs: Added one missing case in
8726 ImplicitStandardConversionExists uint64 to intptr.
8730 * typemanager.cs (uintptr_type): another core known type.
8732 * ecore.cs (OperatorCast): routine used to do cast operations that
8733 depend on op_Explicit. We could change some of the Decimal
8734 conversions to use this.
8736 This one has a probe mechanism that checks both types for an op_
8737 which it coudl be used to eliminate two classes: CastToDecimal
8738 and CastFromDecimal.
8740 * convert.cs: Implement the conversions documented in #59800
8742 2006-10-10 Martin Baulig <martin@ximian.com>
8744 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
8745 before RootScope.ResolveMembers().
8747 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
8748 `CurrentType' if appropriate.
8750 2006-10-09 Marek Safar <marek.safar@seznam.cz>
8752 A fix for bug #78568
8753 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
8754 when contains binary operators.
8755 * cs-parser.jay: Updated.
8757 2006-10-09 Martin Baulig <martin@ximian.com>
8760 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
8761 moved that into Define() and also do the other type parameter
8762 checks there. Fixes #79094. Added gtest-292.cs.
8765 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
8766 since that doesn't include type parameters; don't use `Ldelema'
8767 for type parameters. Fixes #78980. Added gtest-293.cs.
8769 2006-10-08 Marek Safar <marek.safar@seznam.cz>
8772 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
8773 conversion is allowed.
8775 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8777 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
8778 error reporting when no error occurs.
8780 2006-10-06 Marek Safar <marek.safar@seznam.cz>
8782 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
8785 2006-10-06 Raja R Harinath <rharinath@novell.com>
8788 * class.cs (DefineTypeBuilder): Check circular dependencies before
8789 setting the parent of the TypeBuilder.
8790 (CheckRecursiveDefinition): Don't use 'BaseType', since
8791 it may not be valid until after DefineTypeBuilder. Use
8792 'base_type' instead.
8794 2006-10-04 Martin Baulig <martin@ximian.com>
8796 Merged the Anonymous Methods patch.
8798 * anonymous.cs, iterators.cs: The new anonymous methods code.
8800 * statement.cs (Variable): New public abstract class.
8801 (LocalInfo.Variable): New public property.
8802 (LocalInfo.ResolveVariable): New public method.
8803 (Block.Flags): Add `IsIterator'.
8804 (Block.AddVariable): Improved the CS0136 check.
8805 (Block.AnonymousChildren): New public property.
8806 (Block.AddAnonymousChild): New public method.
8807 (ToplevelBlock): Update to use the new anonymous method framework.
8808 (ToplevelBlock.ctor): `container' is now a `Block' and not a
8809 `ToplevelBlock'; this is required to correctly implement the
8811 (Fixed, Using): Use `TemporaryVariable' instead of directly
8812 creating the `LocalBuilder'.
8814 * parameter.cs (Parameter.ResolveVariable): New public method.
8815 (Parameters.ResolveVariable): Likewise.
8817 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
8819 * class.cs (TypeContainer): Replaced the `iterators' list and
8820 corresponding methods with a list of `CompilerGeneratedClass'es.
8821 (TypeContainer.ResolveMembers): New public method.
8822 (Method): `IIteratorContainer' has been replaced by
8825 * expression.cs (VariableReference): New public abstract base
8826 class for `LocalVariableReference', `ParameterReference' and
8829 * codegen.cs (EmitContext): Removed `capture_context',
8830 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
8831 (EmitContext.EmitThis): Removed.
8833 * cs-parser.jay: Replace `iterator_container' with
8836 2006-10-04 Martin Baulig <martin@ximian.com>
8838 * generic.cs (GenericMethod): Don't make this abstract.
8839 (Constraints.Clone): Added dummy implementation.
8841 2006-10-04 Raja R Harinath <harinath@gmail.com>
8844 * namespace.cs (LookForAnyGenericType): Avoid nullref on
8845 'declspaces'. Avoid allocating arrays willy-nilly.
8848 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
8849 cases out of the switch.
8851 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8853 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
8854 message when non-generic type is used with the type arguments.
8855 * expression.cs: Updated.
8857 2006-09-28 Raja R Harinath <rharinath@novell.com>
8860 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
8861 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
8862 Change semantics slightly. Don't insist on having only one
8863 temporary EmptyExpression -- just throttle the creation of new ones.
8866 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
8867 non-interfaces too. If no methods are found, don't try to create
8870 2006-09-28 Marek Safar <marek.safar@seznam.cz>
8872 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
8875 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
8876 us produce better error message.
8878 2006-09-27 Marek Safar <marek.safar@seznam.cz>
8880 * expression.cs (Binary.ResolveOperator): Warn about a side effect
8881 of the `|' operator.
8883 * report.cs: A new warning added.
8885 2006-09-27 Martin Baulig <martin@ximian.com>
8887 * generic.cs (GenericMethod): Don't make this abstract.
8889 2006-09-27 Martin Baulig <martin@ximian.com>
8892 (InternalErrorException): Added overloaded ctor taking a params array.
8894 2006-09-26 Marek Safar <marek.safar@seznam.cz>
8896 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
8897 Fixed the cases when same error was reported twice.
8899 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
8900 now report symbol information.
8902 2006-09-25 Martin Baulig <martin@ximian.com>
8904 * class.cs: Completely unified with the gmcs version.
8906 2006-09-25 Martin Baulig <martin@ximian.com>
8908 * typemanager.cs (TypeManager.IsNullableType): New public function.
8909 (TypeManager.IsNullableTypeOf): Likewise.
8910 (TypeManager.IsNullableValueType): Likewise.
8912 * class.cs (MethodCore): Added the `GenericMethod' argument from
8913 gmcs and also unified all classes derived from `MethodCore' with gmcs.
8915 2006-09-24 Raja R Harinath <harinath@gmail.com>
8917 * convert.cs: Unify with gmcs version.
8919 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8921 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
8922 verify them as well.
8924 * report.cs: New warning.
8926 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8928 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
8929 for anonymous block with out argument.
8931 2006-09-24 Marek Safar <marek.safar@seznam.cz>
8933 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
8934 not used private events only.
8936 2006-09-23 Marek Safar <marek.safar@seznam.cz>
8938 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
8940 * const.cs (Const.Define): Check for constant type.
8941 (Const.IsConstantTypeValid): Looks for valid constant types.
8943 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
8945 * ecore.cs (EmptyConstantCast): New common class for all constant based
8948 * expression.cs (Is.DoResolve): Handle null constant especially.
8949 (New.DoResolve): Check for new void().
8950 (MemberAccess.DoResolve): Cope with all kind of nulls.
8952 * literal.cs (NullConstant): Uses EmptyConstantCast.
8953 (NullDefault): Based on EmptyConstantCast.
8954 (NullLiteral): Uses EmptyConstantCast.
8956 * statement.cs (Block.ResolveMeta): Check for constant type.
8958 2006-09-22 Martin Baulig <martin@ximian.com>
8960 * delegate.cs, attribute.cs: Merged with the gmcs versions.
8962 2006-09-22 Raja R Harinath <rharinath@novell.com>
8964 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
8968 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
8969 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
8972 2006-09-22 Martin Baulig <martin@ximian.com>
8974 * ecore.cs: Merged with the gmcs version.
8976 * generic.cs (ConstructedType): New dummy class.
8977 (TypeArguments): Don't make this abstract.
8980 (TypeManager.IsGenericTypeDefinition): New method.
8981 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
8983 2006-09-22 Raja R Harinath <rharinath@novell.com>
8985 * expression.cs (ComposedCast): Check for arrays of TypedReference
8986 before creating the type, not after.
8988 2006-09-21 Marek Safar <marek.safar@seznam.cz>
8990 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
8991 after ToType change.
8993 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
8994 when constant must be implicitly convertible.
8996 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
8998 * ecore.cs (NullCast): Derives from NullConstant.
9000 * expression.cs (Is.DoResolve): Removed useless variables.
9001 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9002 (New.Constantify): Add enum support.
9003 (MemberAccess.DoResolve): Add warning when accessing null constant or
9006 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9009 * literal.cs (NullConstant): New abstract class with common
9010 functionality for all null specializations.
9011 (NullDefault): Represents default(X) when result can be
9013 (NullLiteral): Updated.
9015 * report.cs: Add new warning.
9017 2006-09-21 Martin Baulig <martin@ximian.com>
9019 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9021 2006-09-21 Martin Baulig <martin@ximian.com>
9023 * generic.cs (GenericConstraints): New dummy class.
9024 (Constraints): Likewise.
9025 (TypeParameter): Likewise.
9026 (TypeParameterName): Likewise.
9027 (GenericMethod): Likewise.
9029 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9031 * decl.cs: Merged with the gmcs version.
9033 2006-09-21 Raja R Harinath <rharinath@novell.com>
9035 * generic.cs (TypeParameter): Implement IMemberContainer.
9036 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9038 * rootcontext.cs: Unify with gmcs version.
9040 * report.cs: Unify with gmcs version.
9041 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9042 from gmcs/generics.cs.
9043 * generics.cs (TypeParameter): New dummy class.
9045 * support.cs: Unify with gmcs version.
9047 2006-09-20 Raja R Harinath <rharinath@novell.com>
9049 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9050 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9052 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9053 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9054 * mcs.exe.sources: Add generic.cs.
9056 * codegen.cs: Unify with gmcs version.
9058 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9059 (EmitContext): Add GenericDeclContainer implementation.
9060 * decl.cs (MemberCore, DeclSpace): Likewise.
9061 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9063 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9064 MCS TypeManager has a corresponding dummy method.
9066 2006-09-19 Martin Baulig <martin@ximian.com>
9068 * expression.cs: Completely merged with the gmcs version.
9070 2006-09-19 Martin Baulig <martin@ximian.com>
9072 * expression.cs (Invocation): Merged with the gmcs version.
9073 (ArrayAccess.GetStoreOpcode): Likewise.
9075 2006-09-19 Martin Baulig <martin@ximian.com>
9078 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9079 (TypeManager.IsGenericMethodDefinition): Likewise.
9081 2006-09-19 Martin Baulig <martin@ximian.com>
9084 (TypeManager.IsEqual): Moved the gmcs implementation here.
9085 (TypeManager.DropGenericTypeArguments): Likewise.
9086 (TypeManager.DropGenericMethodArguments): Likewise.
9087 (TypeManager.GetTypeArguments): Moved here from gmcs.
9088 (TypeManager.HasGenericArguments): Likewise.
9090 2006-09-19 Martin Baulig <martin@ximian.com>
9092 * expression.cs (Binary): Merged with the gmcs version.
9094 2006-09-19 Martin Baulig <martin@ximian.com>
9096 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9098 2006-09-19 Martin Baulig <martin@ximian.com>
9100 * typemanager.cs: Merged with the gmcs version.
9102 2006-09-16 Raja R Harinath <rharinath@novell.com>
9104 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9105 * driver.cs: Likewise.
9107 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9110 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9111 only if parent type is class.
9112 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9115 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9118 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9120 * typemanager.cs(CSharpName): Converts NullType to null.
9122 2006-09-15 Martin Baulig <martin@ximian.com>
9125 (TypeManager.GetMethodName): Added mcs implementation.
9126 (TypeManager.IsEqual): Likewise.
9129 (SimpleName.RemoveGenericArity): Added dummy implementation.
9131 * pending.cs: Merged with the gmcs version.
9133 2006-09-15 Martin Baulig <martin@ximian.com>
9135 * statement.cs: Merge with the gmcs version.
9137 2006-09-15 Martin Baulig <martin@ximian.com>
9139 * statement.cs (Switch): Merge with the gmcs implementation
9140 (without nullables), which is newer.
9142 2006-09-15 Martin Baulig <martin@ximian.com>
9144 * statement.cs (Block.Variables): Make this public.
9145 (ToplevelBlock.Parameters): Make this a property.
9146 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9148 2006-09-15 Martin Baulig <martin@ximian.com>
9150 * namespace.cs: Merge with the gmcs version.
9152 2006-09-15 Martin Baulig <martin@ximian.com>
9154 * decl.cs (MemberName): Minor code cleanups.
9156 2006-09-15 Martin Baulig <martin@ximian.com>
9158 * parameter.cs: Merge with the gmcs version.
9160 2006-09-15 Martin Baulig <martin@ximian.com>
9162 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9163 and an error in mcs.
9165 2006-09-15 Martin Baulig <martin@ximian.com>
9167 * flowanalysis.cs: Merged from GMCS; added the generics code into
9168 a `GMCS_SOURCE' conditional so we can share this file.
9170 2006-09-08 Martin Baulig <martin@ximian.com>
9172 * typemanager.cs (TypeManager.interlocked_type): New public field.
9173 (TypeManager.int_interlocked_compare-exchange): New public field.
9174 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9175 enumerator types here and call InitGenericCoreTypes().
9176 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9177 after calling InitEnumUnderlyingTypes().
9180 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9181 `classes_second_stage'.
9183 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9185 * assign.cs, ecore.cs, expression.cs: Share error message text.
9186 * class.cs (FieldMember.Define): Check for varible of static type.
9187 * driver.cs (LoadAssembly): Uses error output for errors.
9188 * statement.cs: Updated.
9190 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9192 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9195 2006-09-07 Martin Baulig <martin@ximian.com>
9198 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9200 2006-08-29 Miguel de Icaza <miguel@novell.com>
9202 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9204 2006-08-17 Miguel de Icaza <miguel@novell.com>
9206 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9207 #52019 and #79064, the use of the \uXXXX sequence in source code
9208 to represent unicode characters.
9210 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9212 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9214 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9216 2006-08-13 Miguel de Icaza <miguel@novell.com>
9218 * assign.cs: Catch attempts to assign to a method groups in += and
9221 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9224 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9226 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9228 * class.cs (Method.Define): Issue a warning when generic method looks like
9230 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9233 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9235 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9237 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9238 search all base interfaces as a member can be ambiguous.
9239 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9240 Constructor member type filter.
9241 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9242 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9243 reporting for returned memberinfos.
9244 * report.cs: Updated.
9245 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9246 version to work on all runtimes.
9247 (TypeManager.RealMemberLookup): Removed members filtering.
9249 2006-08-08 Raja R Harinath <rharinath@novell.com>
9251 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9252 (PropertyExpr.EmitAssign): Likewise.
9253 * expression.cs (Indirection.EmitAssign): Likewise.
9254 (LocalVariableReference.EmitAssign): Likewise.
9255 (ParameterReference.EmitAssign): Likewise.
9256 (Invocation.EmitArguments): Likewise.
9257 (ArrayAccess.EmitAssign): Likewise.
9258 (IndexerAccess.EmitAssign): Likewise.
9259 (This.EmitAssign): Likewise.
9260 (ConditionalLogicalOperator.Emit): Likewise.
9263 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9264 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9265 leave it in after returning it.
9266 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9268 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9270 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9273 2006-08-03 Raja R Harinath <rharinath@novell.com>
9275 Fix cs0146-3.cs and cs0146-4.cs.
9276 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9277 enclosing types don't depend on the current type.
9279 2006-08-02 Raja R Harinath <rharinath@novell.com>
9282 * class.cs (TypeContainer.DoDefineMembers): Use
9283 FindBaseMemberWithSameName on Parent, since we're interested in
9284 whether we hide inherited members or not.
9285 (FindBaseMemberWithSameName): Make slightly more robust.
9287 Fix the non-generic testcase from #77396
9288 * decl.cs (DeclSpace.DeclContainer): Remove override.
9290 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9291 declspaces for doppelgangers too.
9292 (UsingEntry): Implement IResolveContext.
9293 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9294 'this' as the resolve context.
9295 (LocalAliasEntry): Likewise.
9297 Implement parts of #77403
9298 * roottypes.cs (RootDeclSpace): New. Used to represent the
9299 toplevel declaration space. Each namespace declaration introduces
9300 a "partial" root declaretion space.
9301 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9302 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9303 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9304 from 'current_namespace.SlaveDeclSpace'.
9305 (namespace_declaration): Likewise.
9306 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9307 check. It can't happen now.
9308 * decl.cs (DeclSpace.LookupType): Likewise.
9309 * driver.cs (MainDriver): Sanity check.
9311 2006-08-01 Raja R Harinath <rharinath@novell.com>
9313 * decl.cs (DeclSpace.FindNestedType): Remove.
9314 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9315 LookupTypeContainer to get the container of the nested type.
9316 * class.cs (TypeContainer.FindNestedType): Make non-override.
9318 2006-07-31 Raja R Harinath <rharinath@novell.com>
9320 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9321 * class.cs (TypeContainer.PartialContainer): ... here.
9322 (TypeContainer.AddBasesForPart): New helper.
9323 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9325 * cs-parser.jay (current_class): Convert to DeclSpace.
9326 (struct_declaration, interface_declaration, class_declaration):
9327 Use AddBasesForPart instead of .Bases directly.
9328 * const.cs, iterators.cs: Update to changes.
9330 2006-07-28 Raja R Harinath <rharinath@novell.com>
9332 * class.cs (TypeContainer.AddMemberType): Rename from
9334 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9335 (AddTypeContainer): New. Combine AddClassOrStruct and
9337 (AddPartial): Update. Add 'is_partial' argument.
9338 * roottypes.cs: Update to changes.
9339 * cs-parser.jay (push_current_class): New helper for handling
9340 current_container and current_class.
9341 (struct_declaration, interface_declaration, class_declaration):
9344 2006-07-26 Raja R Harinath <rharinath@novell.com>
9346 * roottypes.cs: Rename from tree.cs.
9348 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9349 * tree.cs (Tree, ITreeDump): Remove types.
9350 * rootcontext.cs (tree, Tree): Remove fields.
9351 (root, ToplevelTypes): New.
9352 * *.cs: Update to rename.
9354 * tree.cs (Tree.RecordDecl): Remove.
9355 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9357 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9359 2006-07-23 Raja R Harinath <harinath@gmail.com>
9361 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9362 DoFlowAnalysis and OmitStructFlowAnalysis here.
9363 (ec.With): Rename from WithUnsafe and generalize.
9364 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9365 (ec.WithFlowAnalyis): New.
9366 * ecore.cs, expression.cs, statement.cs: Update.
9368 2006-07-22 Raja R Harinath <harinath@gmail.com>
9370 * statement.cs (Block.ResolveMeta): Simplify slightly.
9372 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9373 multiple boolean fields. Convert InUnsafe, constant_check_state,
9374 check_state to flags.
9375 (CheckState, ConstantCheckState): Update.
9376 (InUnsafe): New read-only property.
9377 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9379 (WithUnsafe): New helper similar to WithCheckState.
9380 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9381 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9383 2006-07-21 Raja R Harinath <rharinath@novell.com>
9385 Make comparisons use the same IL irrespective of whether they're
9386 in a 'checked' or 'unchecked' context: one of the issues in #78899
9387 * codegen.cs (EmitContext.CheckState): Make read-only property.
9388 (EmitContext.ConstantCheckState): Likewise.
9389 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9390 helper that implement a save/restore stack for CheckState
9391 values. This is the only way to change check-state.
9392 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9393 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9394 (CheckedExpr.EmitBranchable): New forwarding method.
9395 (UnCheckedExpr): Likewise.
9396 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9397 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9398 (Checked.Resolve, checked.DoEmit): Likewise.
9400 2006-07-20 Miguel de Icaza <miguel@novell.com>
9402 * anonymous.cs: Cache the resolved anonymous delegate, and return
9403 this so that the ResolveTopBlock is only triggered once, not
9406 Currently we trigger ResolvetopBlock twice due to a first pass of
9407 argument check compatibility, and a second pass that does the
9410 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9412 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9414 * rootcontext.cs (Reset): Add helper_classes.
9416 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9419 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9422 2006-07-13 Miguel de Icaza <miguel@novell.com>
9424 * statement.cs (Lock): Handle expressions of type
9425 TypeManager.null_type specially. Fixes #78770
9427 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9429 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9432 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9434 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9435 for accessors as well.
9436 * ecore.cs (EventExpr): Add AccessorTable.
9438 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9441 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9442 for CS0122 where appropriate.
9443 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9445 (Filter): Assembly can be null in the case of top level attributes.
9447 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9451 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9452 is done at global level.
9454 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9456 A fix for #77002, Implemented TypeForwarder support.
9458 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9459 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9460 * typemanager.cs (): Add type_forwarder_attr_type.
9462 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9464 * report.cs: Add CS0469 warning.
9466 2006-06-21 Martin Baulig <martin@ximian.com>
9468 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9469 the `try'-block, so we also report CS0016 etc. there.
9471 2006-06-21 Martin Baulig <martin@ximian.com>
9474 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9476 2006-06-21 Martin Baulig <martin@ximian.com>
9478 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9479 also report CS1686 for parameters.
9481 2006-06-21 Martin Baulig <martin@ximian.com>
9483 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9484 instead of an error if the value is not implicitly convertible to
9485 the switch types; fixes #77964.
9487 2006-06-21 Raja R Harinath <rharinath@novell.com>
9490 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9491 FieldBuilder is null.
9494 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9495 'left' and 'right' before error-checking.
9497 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9499 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9501 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9502 (FieldExpr.DoResolve): likewise.
9503 (PropertyExpr.InstanceResolve): likewise.
9504 (EventExpr.InstanceResolve): likewise.
9506 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9508 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9509 attribute applicable tests for attribute argument.
9511 2006-06-02 Raja R Harinath <rharinath@novell.com>
9514 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9515 (Binary.OverloadResolve_PredefinedIntegral): New.
9516 (Binary.OverloadResolve_PredefinedFloating): New.
9517 (Binary.OverloadResolve_PredefinedString): New.
9518 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9519 Follow the standard more closely, and treat numeric promotions in
9520 terms of overload resolution.
9521 (Binary.CheckShiftArguments): Simplify.
9523 2006-06-01 Raja R Harinath <rharinath@novell.com>
9525 * flowanalysis.cs (MyBitVector): Simplify representation.
9526 (MyBitVector.Clone): Avoid allocating BitArray.
9527 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9528 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9529 (*): Update. Change all references to MyBitVector.And and
9530 MyBitVector.Or to &= and |=.
9532 2006-05-29 Raja R Harinath <rharinath@novell.com>
9535 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9536 to param arguments too.
9538 2006-05-26 Miguel de Icaza <miguel@novell.com>
9540 * cs-parser.jay: Catch another parsing form for arglist being
9541 followed by other arguments. Fixes #78313.
9543 2006-05-24 Raja R Harinath <rharinath@novell.com>
9545 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9546 checking of out parameters to ...
9547 (FlowBranchingToplevel.Merge): ... here.
9548 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9549 set, propagate the origin upward, and only complain if there was
9551 (FlowBranchingException.AddContinueOrigin): Likewise.
9552 (FlowBranchingException.AddReturnOrigin): Likewise.
9553 (FlowBranchingException.AddGotoOrigin): Likewise.
9555 2006-05-23 Raja R Harinath <rharinath@novell.com>
9557 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9558 unreachable, skip it.
9559 (FlowBranchingException.Merge): Always propagate jumps, even if
9560 the finally block renders subsequent code unreachable.
9562 2006-05-18 Raja R Harinath <rharinath@novell.com>
9565 * statement.cs (Goto.Resolve): Move responsibility for resolving
9566 'goto' to FlowBranching.AddGotoOrigin.
9567 (Goto.SetResolvedTarget): New. Callback to set the
9568 LabeledStatement that's the target of the goto.
9569 (Goto.DoEmit): Use Leave instead of Br when crossing an
9570 unwind-protect boundary.
9571 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9572 LookupLabel and adjust to new semantics.
9573 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9574 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9575 Goto.SetResolvedTarget to update target.
9576 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9577 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9578 AddBreakOrigin & co. Delay propagation until ...
9579 (FlowBranchingException.Merge): ... this.
9581 * statement.cs (Block.Resolve): Always depend on flow-branching to
9582 determine unreachability. Kill workaround that originally emitted
9583 only one statement after an "unreachable" label (see infloop in
9586 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9587 This is still "wrong", but anything better would probably need a
9588 multi-pass algorithm.
9589 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9590 usage vector. Force current usage vector to be reachable, to
9591 optimistically signify backward jumps.
9592 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9594 (FlowBranchingLabeled.Merge): New. If no backward jump was
9595 detected, return the original salted-away usage vector instead,
9596 updated with appropriate changes. Print unreachable warning if
9598 * statement.cs (Block.Resolve): Don't print unreachable warning on
9599 a labeled statement.
9601 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
9603 * driver.cs: Pass filename without path to AssemblyBuilder's
9604 AddResourceFile. Fixes bug #78407.
9606 2006-05-17 Raja R Harinath <rharinath@novell.com>
9608 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
9609 * flowanalysis.cs (FlowBranchingLabeled): ... here.
9610 (FlowBranching.MergeChild): Overwrite
9611 reachability information from Labeled branchings too.
9613 2006-05-16 Raja R Harinath <rharinath@novell.com>
9615 * statement.cs (Goto.Resolve): Merge jump origins here ...
9616 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
9618 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
9619 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
9620 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
9621 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
9623 * statement.cs (Goto.Resolve): ... not here.
9624 (Goto.Emit): Remove CS1632 check.
9626 2006-05-14 Marek Safar <marek.safar@seznam.cz>
9628 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
9631 2006-05-11 Raja R Harinath <rharinath@novell.com>
9633 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
9634 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
9635 (FlowBranchingException.Label): Likewise.
9637 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
9639 (MyBitVector.Or): Use it to avoid losing information (Count).
9640 (FlowBranching.MergeOrigins): Likewise.
9642 * flowanalysis.cs (UsageVector.IsDirty): Remove.
9643 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
9644 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
9645 (UsageVector.ToString): Simplify.
9646 (UsageVector.MergeSiblings): Move here from ...
9647 (FlowBranching.Merge): ... here.
9648 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
9651 2006-05-10 Raja R Harinath <rharinath@novell.com>
9653 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
9654 null bitvector is treated as all-true.
9656 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
9657 (MyBitVector): Rationalize invariants. 'vector != null' implies
9658 that we have our own copy of the bitvector. Otherwise,
9659 'InheritsFrom == null' implies all inherited bits are true.
9661 2006-05-09 Marek Safar <marek.safar@seznam.cz>
9663 * statement.cs (LocalInfo): Add IsConstant.
9664 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
9665 local variable for constants.
9667 2006-05-09 Raja R Harinath <rharinath@novell.com>
9669 * flowanalysis.cs (MyBitVector.Empty): New.
9670 (MyBitVector): Don't allow InheritedFrom to be null.
9671 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
9672 (UsageVector, FlowBranching): Update to changes.
9674 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
9675 recursion. The 'Parent == null' condition isn't sufficient for
9677 (FlowBranching.AddBreakOrigin): Likewise.
9678 (FlowBranching.AddContinueOrigin): Likewise.
9679 (FlowBranching.AddReturnOrigin): Likewise.
9680 (FlowBranching.StealFinallyClauses): Likewise.
9681 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
9682 (FlowBranching.CheckOutParameters): Likewise.
9683 (FlowBranchingToplevel): Terminate all the above recursions here.
9684 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
9685 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
9687 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
9689 (FlowBranchingToplevel): New. Empty for now.
9690 (FlowBranching.MergeTopBlock): Update.
9691 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
9692 branching for the anonymous delegate.
9693 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
9695 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
9696 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
9697 information at the start of the merge. Reorganize.
9699 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9701 * class.cs (MethodData.Define): Method cannot implement interface accessor.
9703 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9705 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
9706 to newly introduced ctor.
9708 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
9709 message to one place.
9710 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
9713 2006-05-07 Marek Safar <marek.safar@seznam.cz>
9715 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
9717 * ecore.cs (Expression.ResolveAsConstant): Updated.
9719 * statement.cs (ResolveMeta): Updated.
9721 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9723 * cs-parser.jay: __arglist cannot be used in initializer.
9725 2006-05-06 Marek Safar <marek.safar@seznam.cz>
9728 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
9731 2006-05-05 Raja R Harinath <rharinath@novell.com>
9733 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
9734 (LabeledStatement): Add 'name' parameter.
9735 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
9736 (Block.AddLabel): Update to changes.
9737 * cs-parser.jay (labeled_statement): Likewise.
9739 * flowanalysis.cs (BranchingType.Labeled): New.
9740 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
9741 (FlowBranchingLabeled): New. Does nothing for now, but will
9742 eventually handle 'goto' flows.
9743 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
9744 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
9745 that's terminated ...
9746 (Block.Resolve): ... here.
9748 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
9749 (UsageVector.MergeFinallyOrigins): Likewise.
9750 (FlowBranching.InTryOrCatch): Likewise.
9751 (FlowBranching.AddFinallyVector): Likewise.
9752 (FlowBranchingException): Update to changes.
9755 * statement.cs (Return.Resolve): Move error checking to ...
9756 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
9757 (FlowBranchingException): Handle return origins like break and
9759 (FlowBranching.UsageVector.CheckOutParameters): Remove.
9761 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9764 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
9767 2006-05-04 Marek Safar <marek.safar@seznam.cz>
9770 * class.cs (MethodData.Define): Do public accessor check only when method
9771 implements an interface.
9773 2006-05-04 Raja R Harinath <rharinath@novell.com>
9775 Remove special handling of 'break'
9776 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
9777 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
9778 (UsageVector.Break): Remove.
9779 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
9781 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
9783 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
9784 UsageVector.Breaks (). Don't set NeedsReturnLabel.
9786 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9789 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
9790 be the interface member.
9792 2006-05-03 Marek Safar <marek.safar@seznam.cz>
9795 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
9796 for emitting small (int) values.
9798 2006-05-03 Raja R Harinath <rharinath@novell.com>
9801 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
9802 control-flow passes through the 'finally' after merging-in all the
9803 control-flows from 'try' and the 'catch' clauses.
9805 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
9806 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
9807 always true at the only non-recursive entry point.
9808 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
9809 FlowBranchingBreakable.
9810 (FlowBranchingLoop): Remove.
9811 * statement.cs (Return.DoResolve): Update to changes.
9814 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
9815 (FlowBranching.CreateBranching): Handle it: create a
9816 FlowBranchingContinuable.
9817 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
9818 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
9819 except that it handles the 'continue' command.
9820 (FlowBranching.UsageVector.MergeOrigins): Rename from
9822 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
9823 except that it overrides AddContinueOrigin.
9824 (FlowBranchingException): Override AddContinueOrigin, similar to
9826 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
9827 Create a new branching around the embedded statement.
9828 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
9829 control flow after the embedded statement.
9830 (Continue.Resolve): Move all error checking to AddContinueOrigin.
9832 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
9833 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
9834 FlowBranchingBreakable.
9835 (FlowBranchingSwitch): Remove.
9838 * statement.cs (Break.Resolve): Simplify. Move responsibility for
9839 error reporting to ...
9840 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
9841 Rename from 'AddBreakVector'. Add new location argument. Return
9842 a bool indicating whether the 'break' crosses an unwind-protect.
9843 (FlowBranchingException.AddBreakOrigin): Add.
9844 (FlowBranchingException.Merge): Propagate 'break's to surrounding
9845 flowbranching after updating with the effects of the 'finally'
9847 (FlowBranchingBreakable): New common base class for
9848 FlowBranchingLoop and FlowBranchingSwitch.
9850 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
9852 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
9854 2006-05-02 Raja R Harinath <rharinath@novell.com>
9856 * statement.cs (Do.Resolve): If the loop is infinite, set the
9858 (While.Resolve, For.Resolve): Set a barrier after the embedded
9859 statement. There's no direct control flow that goes from the end
9860 of the embedded statement to the end of the loop.
9861 * flowanalysis.cs (FlowBranching.Infinite): Remove.
9862 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
9863 above ensure that the reachability is correctly computed.
9865 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
9866 (UsageVector.MergeBreakOrigins): If the current path is
9867 unreachable, treat it as if all parameters/locals are initialized.
9868 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
9869 infinite loops before merging-in break origins.
9871 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
9872 (Reachability.Reachable): Split part into ...
9873 (Reachability.Unreachable): ... this. Simplify.
9874 (Reachability.IsUnreachable): Use 'Unreachable' instead.
9876 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
9877 (Reachability.SetThrowsSometimes): Likewise.
9878 (FlowBranchingBlock.MergeTopBlock): Don't compare against
9879 TriState.Always, use corresponding property.
9880 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
9881 (Block.Resolve): Likewise. Remove some redundant checks.
9883 2006-05-02 Raja R Harinath <harinath@gmail.com>
9885 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
9886 (Reachability.Meet): Don't bother checking AlwaysThrows --
9887 barrier is always set.
9888 (FlowBranchingBlock.Merge): Likewise.
9890 2006-05-01 Raja R Harinath <harinath@gmail.com>
9892 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
9893 checks for unreachable.
9895 2006-05-01 Marek Safar <marek.safar@seznam.cz>
9898 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
9900 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
9901 whether field is really assigned.
9903 2006-04-30 Raja R Harinath <harinath@gmail.com>
9905 * flowanalysis.cs (Reachability): Make 4-argument constructor
9907 (Reachability.Meet): Rename from 'And'. Remove static variant.
9908 (Reachability.Always): Rename from the highly misleading
9909 'Reachability.Never'.
9910 (FlowBranching.Merge): Update to changes. Mark an impossible
9911 situation with a 'throw'.
9912 (*): Update to changes.
9914 2006-04-29 Raja R Harinath <harinath@gmail.com>
9916 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
9918 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
9919 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
9920 (*): Update to changes.
9921 * statement.cs: Update to changes.
9923 2006-04-28 Marek Safar <marek.safar@seznam.cz>
9926 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
9928 2006-04-28 Raja R Harinath <harinath@gmail.com>
9930 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
9933 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
9934 argument to two arguments: an usage-vector and a bool. Move call
9935 to FlowBranching.Merge () ...
9936 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
9938 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
9939 handling of loop and switch reachability to ...
9940 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
9942 2006-04-27 Raja R Harinath <harinath@gmail.com>
9944 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
9945 handling to FlowBranchingLoop.InLoop.
9946 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
9948 2006-04-26 Marek Safar <marek.safar@seznam.cz>
9951 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
9952 anonymous method is allowed from AnonymousContainer here.
9954 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
9956 2006-04-24 Raja R Harinath <rharinath@novell.com>
9959 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
9961 2006-04-23 Marek Safar <marek.safar@seznam.cz>
9964 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
9965 (DoubleConstant.Reduce): Ditto.
9967 2006-04-23 Raja R Harinath <rharinath@novell.com>
9969 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
9970 Remove 'lvalue_right_side' argument. Move parts to ...
9971 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
9972 (LocalVariable.DoResolveLValue): ... these.
9974 2006-04-21 Raja R Harinath <rharinath@novell.com>
9977 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
9978 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
9979 (LocalVariableReference.DoResolveBase): Use it to implement new
9981 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
9982 (Argument.Resolve): Simplify. Move CS1510 check ...
9983 * ecore.cs (Expression.ResolveLValue): ... here.
9984 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
9985 (PropertyExpr.DoResolveLValue): Likewise.
9986 (FieldExpr.Report_AssignToReadonly): Likewise.
9987 (FieldExpr.DoResolve): Add 'out_access' argument. Use
9988 LValueMemberAccess or LValueMemberOutAccess on instance depending
9990 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
9991 DoResolve as appropriate.
9993 2006-04-20 Raja R Harinath <rharinath@novell.com>
9996 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
9997 implicit conversions on 'out' and 'ref' arguments.
9999 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10000 improve clarity. Remove dead code.
10003 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10004 (Catch.Resolve): Resolve VarBlock if it exists.
10006 2006-04-19 Miguel de Icaza <miguel@novell.com>
10008 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10009 twice, this was some residual code, the enumerator was emitted
10010 properly in the two branche of if later.
10012 2006-04-19 Raja R Harinath <rharinath@novell.com>
10014 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10015 cast is never an lvalue.
10016 (Cast.DoResolve, Cast.ResolveRest): Combine.
10017 (Argument.Emit): Simplify slightly. Move 'Expr is
10018 IMemoryLocation' check ...
10019 (Argument.Resolve): ... here.
10020 (Argument.Error_LValueRequired): Remove. Inline into only user.
10022 Simplifications. Fix cs0191-2.cs
10023 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10024 CS1649 and CS1651 to ...
10025 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10026 the actual selection of the error code and message to a lookup
10027 table. Add a dummy return value to simplify callsites.
10028 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10029 readonly fields of other instances of the same type. Move CS0197
10031 * expression.cs (Argument.Resolve): ... here. Simplify code.
10032 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10033 resolution of an out or ref argument. The code simplification
10034 above uses this invariant.
10036 2006-04-18 Raja R Harinath <rharinath@novell.com>
10038 Possibly fix #77752. Fix cs1690-[4-7].cs.
10039 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10040 CheckMarshallByRefAccess. Drop parameter.
10041 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10043 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10044 InstanceExpression.
10045 * report.cs (AllWarnings): Add CS1690.
10046 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10047 for ref access too.
10048 (LocalVariableReference.DoResolveBase): Update.
10050 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10052 * class.cs (MethodOrOperator): Moved common parts from method class.
10053 detect obsolete attributes.
10054 (Method.Define): Simplified as it reuses code from base.
10055 (Constructor.ValidAttributeTargets): Fixed issue found during
10057 (Destructor.ValidAttributeTargets): Fixed issue found during
10059 (Operator): Finished refactoring set off by #78020. Operator class is now
10060 ordinary method class.
10062 * anonymous.cs: Updated.
10064 * decl.cs (DeclSpace): Add IsGeneric
10066 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10068 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10070 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10072 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10073 detect obsolete attributes.
10074 (Method.CreateEmitContext): Moved to MethodOrOperator.
10076 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10079 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10080 customized exception to make crash detection easier.
10081 (MethodOrOperator): Started to work on new base class for methods and
10083 (Method): Derives from MethodOrOperator.
10084 (Constructor.Emit): Emits its own attributes.
10085 (AbstractPropertyEventMethod.Emit): Ditto.
10086 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10088 (Operator.Emit): It's temporary more tricky than should be.
10090 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10092 * report.cs (InternalErrorException): Add ctor with inner exception.
10094 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10097 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10100 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10103 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10106 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10108 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10109 attribute is present and Guid not.
10110 (Interface.ApplyAttributeBuilder): Ditto.
10112 * attribute.cs: Add error message.
10114 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10118 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10119 sources (it's composite) so hold them in extra array as they are used in
10120 Emit phase only. It worked in the previous versions by mistake.
10121 (Attribute.Emit): Emit attribute for more owners when exist.
10123 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10124 it has now different behaviour.
10126 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10128 * constant.cs (Constant.IsDefaultInitializer): New method.
10130 * class.cs: Updated.
10132 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10133 re-initialize default values. It saves KBs almost for every assembly.
10134 Thanks Zoltan for the idea.
10135 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10136 (ArrayCreation.DoResolve): Resolve only once.
10137 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10138 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10140 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10142 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10145 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10147 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10148 in an embedded statement too.
10150 2006-04-01 Raja R Harinath <rharinath@novell.com>
10153 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10155 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10159 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10162 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10164 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10166 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10169 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10170 LocalTemporary change.
10172 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10174 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10175 initializers optimization.
10176 (ClassOrStruct.TypeAttr): Moved from modifiers.
10177 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10178 (FieldBase.ResolveInitializer): Resolves initializer.
10179 (FieldBase.HasDefaultInitializer): New property.
10181 * cs-parser.jay: Removed message.
10183 * expression.cs (CompilerGeneratedThis): New specialization.
10185 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10187 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10189 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10191 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10193 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10194 be now EnumConstants only.
10196 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10198 * attribute.cs, driver.cs: Reset more caches.
10200 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10202 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10204 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10206 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10207 for easier reuse. Updated all overrides.
10208 (IntegralConstant): New base class for all integral constants.
10209 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10210 of the constant range, report custom error.
10211 (UIntConstant.Reduce): Fixed uint conversion.
10213 * ecore.cs, literal.cs: Reduce updates.
10215 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10219 * class.cs (Constructor.Define): Removed extra if for default ctors.
10220 A patch from Atsushi Enomoto.
10222 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10224 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10225 GetAttributableValue.
10227 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10230 * convert.cs (ImplicitConversionRequired): Error message moved to
10233 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10234 automatic implicit conversion of an output value.
10235 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10237 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10239 (TypeOf.GetAttributableValue): Add extra handling for object type.
10241 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10242 special error message.
10244 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10246 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10248 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10249 compatible with MS runtime.
10251 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10253 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10254 attribute arguments here.
10256 * class.cs (Indexer.Define): The check was moved to attribute class.
10258 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10260 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10261 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10264 2006-03-22 Raja R Harinath <rharinath@novell.com>
10266 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10267 mcs to keep code differences small.
10268 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10269 * typemanager.cs (parameter_default_value_attribute_type): New.
10270 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10273 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10275 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10277 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10279 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10281 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10284 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10286 * doc-bootstrap.cs : fix build.
10288 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10290 * expression.cs (StringConcat.Append): Issue a warning when empty string
10291 is going to append.
10293 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10295 * assign.cs (CompoundAssign.ResolveSource): Removed.
10297 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10300 * class.cs (TypeContainer.FindMethods): Removed.
10301 (TypeContainer.CheckMemberUsage): Made static.
10303 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10305 * constant.cs (CheckRange): Removed unused type argument.
10306 (CheckUnsigned): Removed unused type argument.
10308 * cs-parser.jay: Updated after MemberAccess clean up.
10309 Uses Length for empty string test.
10311 * cs-tokenizer.cs: Uses Length for empty string test.
10312 (IsCastToken): Made static.
10313 (is_hex): Made static.
10314 (real_type_suffix): Made static.
10316 * decl.cs (SetupCache): Made static.
10317 (OnGenerateDocComment): Removed unused ds argument.
10319 * delegate.cs (VerifyDelegate): Removed unused argument.
10321 * doc.cs: Uses Length for empty string test.
10323 * driver.cs: Uses Length for empty string test.
10325 * enum.cs (IsValidEnumType): Made static
10327 * expression.cs (EnumLiftUp): Removed unused argument.
10328 (ResolveMethodGroup): Ditto.
10329 (BetterConversion): Ditto.
10330 (GetVarargsTypes): Ditto.
10331 (UpdateIndices): Ditto.
10332 (ValidateInitializers): Ditto.
10333 (MemberAccess.ctor): Ditto.
10334 (GetIndexersForType): Ditto.
10336 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10338 * iterators.cs: Updated after MemberAccess clean up.
10340 * location.cs: Uses Length for empty string test.
10342 * namespace.cs: Uses Length for empty string test.
10344 * report.cs (CheckWarningCode): Made static.
10346 * statement.cs (LabeledStatement): Removed unused argument.
10348 * typemanager.cs (FilterNone): Removed.
10350 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10352 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10355 * class.cs: Updated.
10357 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10359 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10361 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10365 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10366 reporting, it's more tricky than I thought.
10368 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10372 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10374 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10375 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10376 Add more error reporting; Fixed issue with params.
10378 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10380 * cs-parser.jay: AnonymousMethod requires host container.
10382 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10384 2006-03-18 Raja R Harinath <harinath@gmail.com>
10386 * class.cs: Change 'TypeContainer ds' constructor argument to
10387 'DeclSpace parent'. Some classes were missed below due to
10388 different naming convention.
10390 * class.cs (MemberCore.Parent): Delete. This makes the
10391 ParentContainer changes below enforceable by the compiler.
10393 Treat pointers to enclosing declaration space as 'DeclSpace', not
10395 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10396 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10398 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10400 (Block.AddThisVariable): Likewise.
10401 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10402 (AbstractPropertyEventMethod.Emit): Likewise.
10403 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10404 (GetMethod.Define, SetMethod.Define): Likewise.
10405 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10406 (DelegateMethod.EmitMethod): Likewise.
10408 Fix regression test-partial-13.cs.
10409 Rationalize use of PartialContainer. Ensure that the partial
10410 class semantics can be tied to type-correctness, i.e., any
10411 violation will cause a compile error.
10412 * class.cs, const.cs: Access all fields that belong to class
10413 TypeContainer via ParentContainer. Arguments of EmitContexts and
10414 Resolve()-like functions still use 'Parent'.
10416 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10417 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10418 (PropertyMethod.CheckModifiers): Remove unused argument.
10419 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10422 2006-03-17 Raja R Harinath <harinath@gmail.com>
10424 Make semantics of PartialContainer simpler.
10425 * decl.cs (DeclSpace.IsPartial): Remove.
10426 * class.cs (TypeContainer.IsPartial): Likewise.
10427 (TypeContainer..ctor): Set PartialContainer to point to self.
10428 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10429 (TypeContainer.FindNestedType): Likewise.
10430 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10432 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10434 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10436 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10438 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10441 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10443 * class.cs (Operator.Define): An error for base conversion was not
10444 reported correctly.
10446 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10448 * iterator.cs : yield break is allowed in try statement which has
10449 catch clauses. Fixed bug #77767.
10451 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10453 A fix for #77593, #77574.
10455 * class.cs (MethodCore.CheckBase): Another if for operator.
10457 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10459 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10462 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10463 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10466 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10469 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10470 Updated after another emitcontext usage was clean up. It should help us to
10471 synchronize with gmcs easier.
10473 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10477 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10478 (Event.Define): ditto
10479 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10481 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10482 Removed redundant code and set NewSlot for Invoke method too.
10484 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10485 (Parameters.MergeGenerated): New method. Use this method when you merge
10486 compiler generated argument with user arguments.
10488 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10490 * attribute.cs (ResolveAsTypeTerminal): Removed.
10492 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10493 specialization for predefined types; 30% speed up.
10494 Finally placed obsolete check to right place.
10495 (Expression.ResolveType): Removed.
10497 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10498 Updated after ResolveType was removed.
10500 * expression.cs (Cast.ctor): Check void cast.
10501 (Binary.ResolveAsTypeTerminal): Is never type.
10502 (Conditional.ResolveAsTypeTerminal): Is never type.
10504 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10506 2006-03-01 Raja R Harinath <rharinath@novell.com>
10509 * expression.cs (ParameterReference.DoResolveBase): Change return
10511 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10515 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10518 * typemanager.cs (GetFullNameSignature): Don't nullref on
10519 protected accessors.
10521 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10523 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10524 these two separated members to simplify the code.
10525 (Attribute.Resolve): Refactored to use new fields and methods.
10526 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10527 implemented obsolete attribute checking.
10528 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10529 implemented obsolete checking again. It look line never ending quest ;-)
10530 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10532 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10534 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10536 *class.cs (Property.Define): Add RegisterProperty call.
10538 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10539 argument groups (only 2).
10541 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10542 encoding expression to arguments.
10543 (Expression.ExprClassToResolveFlags): Just turned to property.
10545 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10546 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10547 optimized as well as implemented support for zero-length attributes.
10549 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10550 Add caching of PropertyInfo's.
10552 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10554 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10555 error multiple times.
10557 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10559 New partial class implementation.
10560 A fix for #77027, #77029, #77403
10562 * attribute.cs (Attributable): Made attributes protected.
10564 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10565 the replacements of ClassPart and PartialContainer.
10566 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10567 (TypeContainer.AddInterface): Ditto.
10568 (TypeContainer.AddPartial): The main method for partial classes. It checks
10569 for errors and merges ModFlags and attributes. At the end class is added to
10570 partial_parts list.
10571 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10573 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10574 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10575 from the rest of partial classes.
10576 (TypeContainer.GetClassBases): Simplified.
10577 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10579 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10580 (TypeContainer.HasExplicitLayout): Uses Flags now.
10581 (PartialContainer): Removed.
10582 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10583 (StaticClass): Was merged with Class.
10584 (Class.GetClassBases): class and static class bases are verified here.
10585 (Class.TypeAttr): Added static attributes when class is static.
10586 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10587 (MemberBase): In some cases we need to call parent container for partial
10588 class. It should be eliminated but it's not easy now.
10590 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10592 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10593 partial classed to accumulate class comments.
10594 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10596 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10598 * driver.cs (MainDriver): Tree.GetDecl was removed.
10600 * modifiers.cs (Modifiers): Add partial modifier.
10602 * tree.cs (Tree.decl): Removed.
10603 (RootTypes): Started to use this class more often for root types
10606 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10610 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
10611 external interface does not have an attribute.
10613 2006-02-22 Marek Safar <marek.safar@seznam.cz>
10615 Another prerequisites for new partial classs implementation.
10617 * attribute.cs (Attribute.Equal): Implemented.
10618 (Attribute.Emit): Changed as attributes can be applied more than twice.
10619 (Attributes.Emit): Check for duplicate attributes here.
10621 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
10622 as a parameter, clean-up.
10624 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10628 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
10629 contains obsolete attribute check which can in some cases look for base
10630 type of current class which is not initialized yet.
10631 (TypeContainer.BaseType): Replacement of ptype.
10633 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
10635 2006-02-11 Marek Safar <marek.safar@seznam.cz>
10637 First of prerequisites for new partial classs implemention.
10639 * attribute.cs (Attributable): Extended by ResolveContext;
10640 Attributes finally have correct context for resolving in all cases.
10641 (AttachTo): Attribute owner is assigned here.
10643 * codegen.cs (IResolveContext): Introduce new interface to hold
10644 all information needed in resolving phase.
10645 (EmitContext): Implements IResolveContext; more clean-up needed here.
10647 * decl.cs (MemberCore): Implemented IResolveContext.
10649 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
10650 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
10651 parameter.cs, statement.cs, tree.cs, typemanager.cs:
10652 Refactored to use new IResolveContext instead of EmitContext; cleanup
10654 2006-02-06 Miguel de Icaza <miguel@novell.com>
10656 * codegen.cs (EmitScopeInitFromBlock): check here the
10657 capture_context, there is no need to make two calls to the
10660 * anonymous.cs: Add some debugging messages that might help me
10661 track other instances of this problem in the future (the
10662 regression of test 467).
10664 * cs-parser.jay: track the variable block, as we need to initalize
10665 any captured variables declared in this block for the "catch"
10666 portion of the "Try" statement.
10668 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
10669 scope initialization for captured variables.
10671 Also, move the emit for the variables after the block location has
10674 2006-02-06 Marek Safar <marek.safar@seznam.cz>
10676 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
10678 2006-02-02 Miguel de Icaza <miguel@novell.com>
10680 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
10681 commit yesterday, the initialization for the roots is necessary.
10682 What is not necessary is the scope activation.
10684 2006-02-02 Raja R Harinath <rharinath@novell.com>
10686 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
10687 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
10689 (Argument.Resolve): Remove CS0206 checks.
10691 2006-02-01 Miguel de Icaza <miguel@novell.com>
10693 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
10694 scopes for all the roots, the scopes will now be emitted when the
10695 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
10697 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
10698 code. This reduces a lot of existing cruft.
10700 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
10701 that the ScopeInfo is generated as we enter the scope, not at the
10702 time of use, which is what we used to do before.
10704 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
10705 every time a Block is about to be emitted if we have a
10708 2006-02-01 Raja R Harinath <rharinath@novell.com>
10710 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
10712 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
10714 * typemanager.cs (cons_param_array_attribute): Make private.
10715 (Reset): Set it to null.
10716 (InitCoreHelpers): Don't initialize it.
10717 (ConsParamArrayAttribute): New. Initialize it as needed.
10718 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
10720 2006-01-31 Miguel de Icaza <miguel@novell.com>
10722 * expression.cs: There might be errors reported during the
10723 selection of applicable methods. If there are errors, do not
10724 continue execution as it will lead the compiler to crash.
10726 2006-01-30 Miguel de Icaza <miguel@novell.com>
10728 * expression.cs: Member access is not allowed on anonymous
10729 methods. Fixes #77402.
10731 2006-01-30 Raja R Harinath <rharinath@novell.com>
10734 * cs-parser.jay (VariableDeclaration): Don't set
10735 current_array_type to null.
10736 (field_declaration, event_declaration, declaration_statement):
10737 Set it to null here.
10739 2006-01-28 Raja R Harinath <harinath@gmail.com>
10741 * typemanager.cs (GenericParameterPosition): New.
10744 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
10746 * doc.cs : To process "include" elements, first we should create
10747 another list than XmlNodeList, because it could result in node
10748 removal, which could result in that the XmlNodeList gives up
10749 yielding next node.
10751 (Also made code identical to gmcs again.)
10753 2006-01-25 Miguel de Icaza <miguel@novell.com>
10755 * ecore.cs: Introduce an error report that we were not catching
10756 before, if not silent, we must report the error. Gonzalo ran into
10759 2006-01-23 Miguel de Icaza <miguel@novell.com>
10761 A fix for bug: #76957
10763 * iterators.cs (MoveNextMethod.CreateMethodHost): call
10764 ComputeMethodHost before creating the method, this is a new
10767 * anonymous.cs (AnonymousContainer): Now we track all the scopes
10768 that this method references (RegisterScope). The actual scope
10769 where the method is hosted is computed with the ComputeMethodHost
10770 before we create the method.
10772 Moved the Deepest routine here.
10774 (AnonymousContainer.ComputeMethodHost): New routine used to
10775 compute the proper ScopeInfo that will host the anonymous method.
10777 (ScopeInfo): Deal with multiple roots. The problem was that we
10778 did not have a unique root where all ScopeInfos could be hanged
10779 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
10782 Remove AdjustMethodScope which is now computed at the end. Remove
10783 LinkScope which did a partial link, instead link all ScopeInfos
10784 before code generation from the new "LinkScopes" routine.
10786 Simplify all the Add* routines as they no longer need to maintain
10787 the tree, they just need to record that they are using variables
10790 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
10791 routines to produce the forest of ScopeInfo trees.
10793 * class.cs (TypeContainer.AppendMethod): This is just like
10794 AddMethod, but ensures that an interface implementation method
10795 (IEnumerable.XXX) is not inserted at the beginning of the queue of
10796 methods, but at the end.
10798 We use this functionality to ensure that the generated MoveNext
10799 method in the iterator class is resolved/emitted before the
10800 enumerator methods created.
10802 This is required because the MoveNext method computes the right
10803 ScopeInfo for the method. And the other methods will eventually
10804 need to resolve and fetch information computed from the anonymous
10807 2006-01-21 Raja R Harinath <harinath@gmail.com>
10808 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10810 Fix rest of #76995.
10811 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
10812 the 'aliases' hash.
10813 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
10814 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
10816 2006-01-18 Raja R Harinath <rharinath@novell.com>
10818 Fix #76656, cs0231-2.cs.
10819 * cs-parser.jay (formal_parameter_list): Make error case catch
10821 (parenthesized_expression_0): Add CS1026 check.
10822 (invocation_expression): Remove unused { $$ = lexer.Location }.
10824 2006-01-17 Raja R Harinath <rharinath@novell.com>
10827 * cs-parser.jay (statement_expression): Don't list out the
10828 individual statement-expressions. Convert syntax error into
10831 2006-01-16 Raja R Harinath <rharinath@novell.com>
10834 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
10835 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
10836 CheckIntermediateModification.
10837 (FieldExpr.DoResolve): Add new two-argument version that
10838 allows us to resolve the InstanceExpression as an lvalue.
10839 The one-argument variant is now just a wrapper.
10840 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
10841 Resolve the lhs as an lvalue if the it has a value type.
10842 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
10843 from Assign.DoResolve.
10844 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
10845 resolved as an lvalue.
10846 (PropertyExpr.DoResolve): Update.
10847 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
10848 has a value type. Move CS1612 check here from
10849 CheckIntermediateModification.
10850 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
10851 * expression.cs (EmptyExpression.OutAccess): New. Used as the
10852 'right_side' of a ResolveLValue on an 'out' argument.
10853 (EmptyExpression.LValueMemberAccess): New. Used as the
10854 'right_side' of a propagated ResolveLValue on a value type.
10855 (LocalVariableReference.DoResolveBase): Recognize
10856 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
10858 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
10859 EmptyExpression.Null.
10861 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
10863 * typemanager.cs : added IsGenericParameter(). In mcs it always
10865 * doc.cs : for generic parameters, use GenericParameterPosition,
10868 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
10870 * expression.cs: Fix Console.WriteLine ((this = x).foo);
10872 2006-01-12 Miguel de Icaza <miguel@novell.com>
10874 This fixes the problem where we used ldfld instead of ldflda to
10875 load the "THIS" pointer on captured parameters, when THIS is a
10876 value type. See bug #77205.
10878 * iterators.cs (CapturedThisReference.Emit): Pass false to
10879 EmitThis (we do not need the address).
10881 * codegen.cs (EmitThis): it needs to know whether we need the
10882 address of `this' or not. This is used by value types.
10884 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
10885 every other call passes false.
10887 2006-01-12 Raja R Harinath <rharinath@novell.com>
10890 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
10892 * expression.cs (Invocation.OverloadResolve): Update.
10893 (Invocation.DoResolve): Avoid double resolution of invocation.
10895 2006-01-11 Raja R Harinath <rharinath@novell.com>
10898 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
10899 unary negation of floating point types as 0-expr; negation cannot
10900 overflow in floating point types.
10903 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
10904 on operands of 'void' type.
10907 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
10908 and ExclusiveOr for boolean constants too.
10910 2006-01-09 Raja R Harinath <rharinath@novell.com>
10913 * expression.cs (Invocation.OverloadResolve): Replace reflected
10914 override methods with their base virtual methods, rather than
10915 skipping over them.
10916 * typemanager.cs (TypeManager.GetOverride): New.
10918 2006-01-05 Jb Evain <jbevain@gmail.com>
10920 * class.cs (Property.Define, Indexer.Define): do not tag the
10921 properties as SpecialName | RTSpecialName.
10923 2006-01-04 Miguel de Icaza <miguel@novell.com>
10925 * class.cs (MethodCore.IsDuplicateImplementation): This method was
10926 doing a low-level comparission of parameter types. It was lacking
10927 a check for __argslist.
10929 2005-12-30 Miguel de Icaza <miguel@novell.com>
10931 * expression.cs (ParameterReference.DoResolveBase): Allow
10932 reference parameters if they are local to this block.
10934 This allows the ref and out parameters of a delegate to be used in
10935 an anonymous method, for example:
10937 delegate void set (out int x);
10939 set s = delegate (out int x){
10943 This is used by functionality introduced late in the C# language.
10945 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
10946 method that take ref and out parameters.
10948 Fixes #77119 which was a late change in the spec.
10950 2005-12-23 Miguel de Icaza <miguel@novell.com>
10952 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
10953 parent if its the same scope. Fixes #77060.
10955 2005-12-21 Miguel de Icaza <miguel@novell.com>
10957 * driver.cs: Report the case of no source files and no -out:
10960 2005-12-20 Raja R Harinath <rharinath@novell.com>
10963 * expression.cs (ComposedCast.GetSignatureForError): Define.
10965 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
10969 * namespace.cs (NamespaceEntry): Add extern_aliases as a
10970 ListDictionary, to contain the ExternAliasEntry entries (in
10971 addition to the NamespaceEntry.aliases hashtable). This field is
10972 shared between the original entry and its doppelganger (bodyless
10974 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
10975 extern_aliases field.
10976 (NamespaceEntry.Lookup): Move the IsImplicit check after the
10977 lookup in extern_aliases.
10979 2005-12-16 Raja R Harinath <rharinath@novell.com>
10982 * class.cs (TypeContainer.Mark_HasEquals): New.
10983 (TypeContainer.Mark_HasGetHashCode): New.
10984 (ClassPart): Override them.
10985 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
10988 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
10989 'parent' argument to the base constructor.
10991 Remove all mention of TypeContainer from decl.cs.
10992 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
10993 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
10994 (DeclSpace.DeclSpace): Likewise.
10995 (DeclSpace.DefineMembers): Remove unused argument.
10996 * cs-parser.jay (pop_current_class): Update to changes. Simplify
10997 debugging check -- we don't care if the debug code throws an
10998 InvalidCastException instead of an InternalErrorException.
10999 * class.cs (TypeContainer.DefineMembers): Update to changes.
11000 (TypeContainer.DoDefineMembers): Likewise.
11001 (TypeContainer.GetMethods): Likewise.
11002 (PropertyMember.Define): Likewise.
11003 (MemberBase.Parent): New property that forwards to
11004 MemberCore.Parent, but ensures that we get a TypeContainer.
11005 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11006 (RootContext.PopulateTypes): Likewise. Remove special case code
11007 for !RootContext.StdLib: DefineMembers is idempotent.
11009 2005-12-14 Miguel de Icaza <miguel@novell.com>
11011 * convert.cs (ExplicitConversionCore): Check the return value from
11012 ExplicitConversionCore which can return null on failure. Fixes #76914
11014 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11016 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11018 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11020 * doc.cs : The search for referenced namespace was insufficient to
11021 get global one as it used to do. Fixed bug #76965.
11023 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11025 * doc.cs : check name in cref in the last phase that whether it is
11028 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11030 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11033 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11035 * doc.cs : so it turned out that we cannot skip override check for
11036 interface members. Fixed bug #76954.
11038 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11040 * cs-tokenizer.cs : fixed bug #75984:
11041 - #warning and #error should not be handled when the source line
11043 - #line is not checked strictly when the source line is disabled.
11044 - #define and #undef is on the other hand checked strictly at any
11047 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11049 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11052 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11054 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11056 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11057 event initializers.
11058 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11059 (FieldBase.Initializer): Initializer is now optional.
11060 (EventField.Define): Only event field can have initializer.
11062 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11064 * const.cs (Const): Reuse initializer.
11066 * cs-parser.jay: Updated after FieldBase changes.
11067 Added current_array_type to simplify array initializers.
11069 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11071 * expression.cs, iterators.cs: Updated.
11073 * namespace.cs (NamespaceEntry): Made UsingFound private.
11075 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11077 * parameterCollection.cs: Obsolete, removed.
11078 * parser.cs: Obsolete, removed.
11080 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11083 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11085 * enum.cs (Enum.Define): Set obsolete context here.
11087 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11090 - FindDocumentedMember() now expects 1) paramList as null
11091 when "we don't have to check the number of parameters" and
11092 2) Type.EmptyTypes when "there is no arguments".
11093 - Introduced FoundMember struct to hold the exact type which was
11094 used to find the documented member (the above change broke
11095 test-xml-044; it might be better just to use DeclaringType than
11096 what MS does, like this change does, but it depends on usage.)
11098 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11100 * doc.cs : documented member might be from DeclaringType for nested
11101 types. Fixed bug #76782.
11103 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11105 * anonymous.cs: Have the param code handle leaving copies on the
11106 stack etc. Allows anonymous params to take part in the assignment
11107 code (++, +=, etc). Fixes bug #76550
11109 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11110 it down to the anon code.
11112 * iterators.cs: Use dummy var here
11114 * codegen.cs: Handle new vars
11116 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11119 * class.cs (MethodData.Define): Set proper Obsolete context.
11121 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11123 (FieldExpr.DoResolve): Ditto.
11125 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11128 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11129 parent is not obsolete.
11131 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11133 * doc.cs : (FindDocumentedMember) find parameterless members first
11134 and get CS0419 in the early stage. Fixed first case of bug #76727.
11136 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11139 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11140 no error was reported.
11142 *expression.cs (Binary.DoResolve): left can be null.
11144 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11147 * class.cs (MethodData.Emit): Parameters should be labeled first.
11149 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11152 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11154 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11156 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11158 * class.cs (MethodCore): Parameter clean up.
11159 (IMethodData): Added ParameterInfo.
11160 (MethodData): Parameter clean up.
11161 (Indexer.Define): Parameter clean up.
11173 * typemanager.cs: Parameter clean up.
11175 * delegate.cs (Define): Get rid of duplicated code.
11177 * expression.cs (ParameterReference): Removed useless parameters
11179 (Invocation): Ditto.
11181 * parameter.cs (ParamsParameter): New class, params specialization.
11182 (ArglistParameter): Attemp to separate arglist.
11183 (Parameter): Refactored to be reusable and faster.
11184 (Parameter.Modifier): Made understandable.
11185 (Parameters): Changed to be used as a class for `this' assembly
11186 parameters. Refactored to use new specialized classes.
11188 * support.cs (ParameterData): Added Types property.
11189 (InternalParameters): Deleted.
11191 2005-08-20 Martin Baulig <martin@ximian.com>
11193 Merging this patch from GMCS to fix #75867.
11195 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11196 scope if we don't already have it.
11198 2005-11-17 Martin Baulig <martin@ximian.com>
11201 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11202 inherit the scope from our parent. Fixes #76653.
11204 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11206 * doc.cs : the previous patch does not actually fix the bug.
11207 PropertyInfo override check is now implemented and really fixed it.
11208 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11210 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11212 * doc.cs : apply "override filter" also to properties.
11215 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11217 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11218 no need to check overrides. For classes, omit those results from
11219 interfaces since they must exist in the class. Fixed bug #76726.
11221 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11223 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11224 with different parameters. Fixed the second problem in #76685.
11226 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11228 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11229 get expected 'protected' access in CheckValidFamilyAccess()).
11232 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11234 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11235 Fixed bug #76705. CS1569 was incorrectly commented out.
11237 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11239 * doc.cs : use Invocation.IsOverride() to do real override check.
11240 * expression.cs : made Invocation.IsOverride() internal.
11242 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11244 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11245 TypeBuilder.FindMembers() and filter overriden base members out.
11248 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11250 * doc.cs : ref/out parameters are represented as '@' (instead of
11251 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11253 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11255 * doc.cs : when there was no '.' in cref to methods in doc comment,
11256 then parameters were missing in the output. Fixed bug #76691.
11258 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11260 * driver.cs : don't output docs when there is an error.
11263 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11266 Now it should detect indexers. Fixed primary concern in bug #76685.
11267 Fixed CS0419 message to not show the identical member signature in
11270 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11272 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11273 instead of Type.FindMembers() since it does not handle events.
11276 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11278 * codegen.cs: Fixed typo (speficied -> specified).
11280 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11283 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11285 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11287 * attribute.cs: Changed error message.
11289 * cs-tokenizer.cs: One more check.
11291 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11293 * statement.cs (Block.Resolve): Ignore empty statement.
11295 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11297 * report.cs: Made error/warning methods more strict to avoid
11300 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11301 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11302 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11303 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11305 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11307 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11308 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11310 * class.cs (TypeContainer.IsComImport): New property.
11311 (Constructor.Define): Create proper ctor for ComImport types.
11313 * expression.cs (New.CheckComImport): Fixed.
11315 2005-11-07 Miguel de Icaza <miguel@novell.com>
11317 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11318 that a parameter has been captured does not mean that we do not
11319 have to do the rest of the processing. This fixes the second part
11320 of #76592. If there was another anonymous method capturing
11321 values in the past, the Scope would never be set for the second
11322 method that captured the same parameter.
11324 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11325 properly manipulate the stack. Second part of fix for #76592.
11327 * expression.cs (New): Add support for invoking "new" on
11328 interfaces that have been flagged with the ComImport attribute and
11329 the CoClass. Fixes #76637
11331 * statement.cs (Try.DoEmit): When a variable is captured, do not
11332 try to emit the vi.LocalBuilder variable as it has been captured.
11333 Create a temporary variable and store the results on the
11334 FieldBuilder. Fixes #76642
11336 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11338 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11340 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11342 * expression.cs (Binary.DoResolve): Added && optimalization.
11344 * typemanager.cs (AddUserType): Removed useless argument.
11346 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11348 * statement.cs (Block.variables): Uses ListDictionary.
11350 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11353 * class.cs (PartialContainer.EmitType): Customized to emit
11354 security attributes.
11355 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11356 for partial classes.
11358 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11361 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11362 access has to be fixed.
11364 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11366 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11369 * ecore.cs (NullCast.Reduce): Implemented.
11371 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11374 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11376 (Foreach.Resolve): Catch null properly.
11378 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11380 * cs-tokenizer.cs: Warning text fix.
11382 * driver.cs: AllWarningNumbers exposed on public interface.
11384 * report.cs (): Reviewed warning numbers.
11385 (IsValidWarning): Use binary search.
11387 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11389 * driver.cs: Implemeted resource visibility.
11390 (Resources): New class for code sharing between /res: and
11393 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11396 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11399 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11402 * ecore.cs (NullCast): Child is contant only.
11404 * literal.cs (NullLiteral.Reduce): null can be converted to any
11407 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11409 * driver.cs: Use Encoding.Default as default code page instead
11412 2005-10-27 Raja R Harinath <rharinath@novell.com>
11415 * expression.cs (Invocation.Error_InvalidArguments): Handle
11416 __arglist parameters.
11417 (Invocation.VerifyArgumentsCompat): Likewise.
11418 * support.cs (ReflectionParameters.GetSignatureForError): Print
11419 __arglist parameters.
11420 (InternalParamters.GetSignatureForError): Likewise.
11421 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11423 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11425 * attribute.cs (GetPropertyValue): Made public.
11427 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11429 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11431 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11434 * driver.cs: Reflect method name change.
11436 * statement.cs (Try.Resolve): Warn when try has both general
11437 exception handlers.
11439 * typemanager.cs: runtime_compatibility_attr_type new predefined
11442 2005-10-26 Raja R Harinath <harinath@gmail.com>
11445 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11446 treat it as an empty parameter list.
11448 2005-10-26 Raja R Harinath <rharinath@novell.com>
11451 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11452 ResolveAsTypeStep silent.
11453 * statement.cs (Block.AddConstant): Mark block as used.
11454 (Block.ResolveMeta): Avoid piling on error messages
11455 if a constant initializer resolution fails.
11457 2005-10-25 Raja R Harinath <rharinath@novell.com>
11459 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11461 (NamespaceEntry.VerifyAllUsing): New.
11462 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11463 behaviour. Delegates actual resolution of alias to ...
11464 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11465 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11467 * driver.cs (Driver.MainDriver): Update.
11469 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11470 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11472 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11474 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11475 RootNamespace.DefineNamespacesForAll.
11477 2005-10-24 Raja R Harinath <harinath@gmail.com>
11479 * typemanager.cs (assemblies, external_aliases, modules)
11480 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11481 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11482 overhead. Move resposibility ...
11483 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11484 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11486 2005-10-23 Raja R Harinath <harinath@gmail.com>
11488 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11489 cached_namespaces. Improve usage.
11490 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11491 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11492 Move from GlobalRootNamespace and simplify.
11493 (RootNamespace.Global): Make instance variable.
11494 (RootNamespace.RootNamespace): Add "alias name" parameter.
11495 (GlobalRootNamespace): Simplify drastically.
11496 (Namespace.Lookup): Don't use GetNamespace.
11497 * typemanager.cs (GetRootNamespace): Rename from
11498 ComputeNamespaceForAlias.
11499 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11501 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11503 * anonymous.cs (AnonymousContainer): Don't crash when container
11506 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11508 * expression.cs (Binary.DoResolve): Warn when comparing same
11511 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11514 * expression.cs (Binary.DoResolve): It looks like there are no
11515 convetsion rules in enum context.
11517 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11519 Add support for extern alias qualifiers.
11520 * typemanager.cs: Move some LookupTypeReflection code
11521 to namespace.cs, to have cleaner code. Added some methods
11522 to help us keep track of the extern aliased references.
11523 * driver.cs: Add suport for extern alias assemblies on command
11524 line and check for their warnings/errors. Also keep track of the
11525 extern aliased assemblies.
11526 * namespace.cs: Move the global functionality of Namespace
11527 to GlobalRootNamespace/RootNamespace. Now the global namespace
11528 is GlobalRootNamespace.Globa. Also the code moved from
11529 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11530 Finally added LocalAliasEntry (AliasEntry before) and
11531 ExternAliasEntry, to handle alias statements.
11532 * cs-parser.jay: Add support in the grammar for extern alias
11534 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11535 Update callings to Namespace (now in GlobalRootNamespace).
11537 2005-10-18 Raja R Harinath <rharinath@novell.com>
11540 * class.cs (TypeContainer.DefineType): Move updating of
11541 topological sort earlier in the code.
11542 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11544 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11547 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11549 * constant.cs (Constant.TryReduce): Moved from Cast class.
11550 (Reduce): Made little bit more OO and fixed missing conversions.
11552 * ecore.cs (Reduce): Implemented.
11553 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11555 * literal.cs (Reduce): Implemented.
11557 * class.cs: Reverted Miguel's wrong commit.
11559 2005-10-14 Miguel de Icaza <miguel@novell.com>
11561 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11563 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11565 * cs-parser.jay, expression.cs : CS0214 was missing error location
11566 for constants. Fixed bug #76404.
11568 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11571 * convert.cs (ExplicitConversionCore): Fixed object->enum
11574 2005-10-10 Raja R Harinath <rharinath@novell.com>
11576 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11577 InstanceExpression.
11578 (PropertyExpr.EmitCall): Likewise.
11579 * expression.cs (Invocation.EmitArguments): Handle case where
11581 (Invocation.EmitCall): Avoid allocating temporary variable if
11582 there are no arguments.
11584 2005-10-07 Raja R Harinath <rharinath@novell.com>
11587 * convert.cs (ImplicitConversionStandard): Move conversion of
11588 void* to arbitrary pointer types ...
11589 (ExplicitConversionStandard): .. here.
11590 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11591 error to always print typenames.
11593 2005-10-07 Raja R Harinath <rharinath@novell.com>
11595 * convert.cs (GetConversionOperator): Rename from
11596 GetConversionOperators. Move operator selection code from ...
11597 (UserDefinedConversion): ... here.
11599 2005-10-06 Marek Safar <marek.safar@seznam.cz>
11601 * convert.cs (ExplicitConversionCore): Removed duplicate enum
11604 2005-10-05 Marek Safar <marek.safar@seznam.cz>
11606 * assign.cs (Assign.DoResolve): Error method changed.
11608 * cfold.cs (DoConstantNumericPromotions): Error method changed.
11610 * const.cs (ResolveValue): Reset in_transit immediately.
11612 * constant.cs: Error method changed.
11614 * convert.cs: Removed useless location parameter.
11615 (ExplicitNumericConversion): Don't do double enum check.
11616 (ExplicitConversionCore): Renamed from ExplicitConversion.
11617 (ExplicitUnsafe): Extracted from ExplicitConversion.
11618 (ExplicitConversion): Uses for error reporting.
11620 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
11622 (ResolveBoolean): Uses common error method.
11623 (CastToDecimal): Get rid of ec.
11624 (CastFromDecimal): Optimized.
11625 (ConvCast): Get rid of ec.
11627 * enum.cs (ResolveValue): Reset in_transit immediately.
11628 (Emit): Return after first error.
11630 * expression.cs: Convert changes.
11632 * literal.cs: Error method changed.
11634 * statement.cs: Error method changed.
11636 2005-10-03 Raja R Harinath <rharinath@novell.com>
11638 * support.cs (SeekableStreamReader.Position): Don't error out when
11639 the requested position is just beyond the end of the current
11642 2005-09-28 Raja R Harinath <rharinath@novell.com>
11644 * support.cs (SeekableStreamReader): Simplify drastically. Don't
11645 try to keep in sync with the byte count of the underlying Stream.
11646 However, this limits us to a window size of 2048 characters: i.e.,
11647 the maximum lookahead of our lexer/parser can be 2048 characters.
11649 2005-09-28 Marek Safar <marek.safar@seznam.cz>
11652 * driver.cs: Fix compilation files with full root path.
11654 2005-09-25 Miguel de Icaza <miguel@novell.com>
11656 * report.cs (SymbolRelatedToPreviousError): Format the output so
11657 it does not use an open parenthesis that is never closed.
11659 * driver.cs: Follow coding guidelines
11661 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11664 * const.cs (Const.ResolveValue): Check for assigning non-null
11665 value to reference type.
11667 2005-09-27 Marek Safar <marek.safar@seznam.cz>
11669 * anonymous.cs: Implemented ExprClassName.
11671 * assign.cs (Assign.DoResolve): Don't chrash when type is not
11674 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
11677 * class.cs (StaticClass.DefineContainerMembers): Report protected
11680 * codegen.cs: if(ed) PRODUCTION.
11682 * convert.cs (Error_CannotImplicitConversion): Better error
11685 * cs-parser.jay: More error checks.
11687 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
11689 * driver.cs (CSCParseOption): Enabled wrong option check.
11691 * ecore.cs (Expression.ExprClassName): Turned to property.
11692 (MemberExpr.CheckIntermediateModification): For checking boxed
11693 value types modification.
11695 * statement.cs (Fixed.Resolve): Expression type must be
11696 convertible to fixed type.
11697 (CollectionForeach.GetEnumeratorFilter,TryType):
11698 Small refactoring for easier error checking.
11700 2005-09-26 Marek Safar <marek.safar@seznam.cz>
11702 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
11705 * class.cs (GeneratedBaseInitializer): New class for customization
11706 compiler generated initializers.
11707 (MemberBase.DoDefine): Check Obsolete attribute here.
11708 (FieldMember.DoDefine): Ditto.
11710 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
11713 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
11714 (MemberCore.GetObsoleteAttribute): Removed argument.
11715 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
11716 (MemberCore.CheckObsoleteType): New helper.
11720 * statement.cs: Updates after MemberCore changes.
11722 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
11723 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
11725 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
11726 obsolete attribute for compiler construct.
11727 (As.DoResolve): Cache result.
11729 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
11731 2005-09-26 Raja R Harinath <rharinath@novell.com>
11734 * expression.cs (This.VerifyFixed): In a value type T, the type of
11735 'this' is T&, iow, 'this' is either an out or ref parameter. In a
11736 value type R, 'this' is treated as a value parameter.
11738 2005-09-22 Miguel de Icaza <miguel@novell.com>
11740 * statement.cs (Lock): Use the TemporaryVariable class instead of
11741 manually using local variables as those do not work when variables
11744 * ecore.cs: Moved the TemporaryVariable class from being a nested
11745 class inside Foreach to be a public class that can be employed in
11748 2005-09-19 Marek Safar <marek.safar@seznam.cz>
11750 * cs-parser.jay: interface_accessors replaced by
11751 accessor_declarations.
11753 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
11756 * statement.cs (GotoCase.Resolve): Convert null constant to
11758 (SwitchLabel.ResolveAndReduce): Ditto.
11759 (SwitchLabel.NullStringCase): Custom null stamp.
11760 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
11762 typemanager.cs (CSharpSignature): Don't skip first argument
11765 2005-09-18 Miguel de Icaza <miguel@novell.com>
11767 * driver.cs: Set InEmacs based on the environment variable EMACS.
11769 * location.cs (InEmacs): in this mode, do not report column
11770 location as it confuses Emacs.
11772 2005-09-16 Marek Safar <marek.safar@seznam.cz>
11774 * cfold.cs, constant.cs, convert.cs, ecore.cs,
11775 expression.cs, iterators.cs, literal.cs: Store constants and
11778 * class.cs (MemberBase.ShortName): Pass location.
11780 * cs-parser.jay: Some location fixes.
11782 * ecore.cs (Expression.Location): Made virtual.
11784 2005-09-05 Miguel de Icaza <miguel@novell.com>
11786 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
11787 if the underlying types are the same, otherwise we need to produce
11788 code that will do the proper cast.
11790 This was exposed by Marek's constant rewrite which produced
11791 invalid code for the call site:
11793 enum X : long { a }
11794 void Method (X v) {}
11798 This fixes test-49.cs
11800 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11802 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
11803 Type/Object should be allowed as well. Fixed bug #75968.
11805 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
11807 * expression.cs : (Binary.DoResolve): when one is enum constant and
11808 another is constant 0, then return enum one *as enum type*.
11811 2005-09-02 Raja R Harinath <rharinath@novell.com>
11813 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
11817 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
11818 flow-branching for LocalVariableReferences in case we were invoked
11819 from a MemberAccess.
11820 * expression.cs (LocalVariableReference.VerifyAssigned): New.
11822 (LocalVariableReference.DoResolveBase): ... this.
11823 (MemberAccess.Resolve): Do the check that was disabled during
11826 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11829 (PartialContainer.Create): check abstract/sealed/static strictly
11830 but abstract/sealed can exist only at one side. Fixed bug #75883.
11832 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
11835 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
11836 specified, don't default to UnmanagedType.I4.
11838 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
11840 * expression.cs : conditional operator should check possibly
11841 incorrect assign expression. Fixed bug #75946.
11843 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11845 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
11846 Reverting the change. gmcs is much complex than mcs on this matter.
11848 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
11850 * cs-tokenizer.cs : To read another token ahead of the actual
11851 consumption, use new SavedToken and cache token instead of moving
11852 back the stream with SeekableStreamReader (it seemed problematic).
11854 driver.cs : Thus use StreamReader directly.
11855 * support.cs : Thus removed SeekableStreamReader.
11857 2005-08-30 Raja R Harinath <rharinath@novell.com>
11860 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
11861 (ScopeInfo.EmitScopeType): Use it to construct field names from
11862 names of captured locals.
11865 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
11866 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
11867 Pass 'target_type' to BoxedCast. Don't default to 'object'.
11868 (ExplicitConversion): Remove enum cases already handled by
11869 implicit conversion. Move implicit conversion check to the beginning.
11870 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
11871 * expression.cs (ArrayCreation.EmitDynamicInitializers):
11872 Don't treat System.Enum as a struct.
11874 2005-08-30 Jb Evain <jbevain@gmail.com>
11876 * attribute.cs: handles as expression in parameters.
11878 2005-08-30 Raja R Harinath <rharinath@novell.com>
11881 * class.cs (TypeContainer.VerifyClsName): Don't use a
11882 PartialContainer when verifying CLS compliance.
11883 (AbstractPropertyEventMethod): Set Parent here, ...
11884 (PropertyMethod): ... not here.
11886 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
11888 * attribute.cs : escaped attribute name should not be allowed to be
11889 resolved (e.g. @class as classAttribute). Fixed bug #75930.
11891 2005-08-29 Raja R Harinath <rharinath@novell.com>
11894 * convert.cs (ImplicitStandardConversionExists): Allow zero also
11895 when converting a long constant to unsigned long.
11896 * expression.cs (Invocation.OverloadResolve): Add sanity check to
11897 detect where IsApplicable and VerifyArgumentsCompat disagree.
11899 2005-08-29 Raja R Harinath <rharinath@novell.com>
11900 and Carlos Alberto Cortez <carlos@unixmexico.org>
11903 * class.cs (TypeContainer.CanElideInitializer): New helper.
11904 (TypeContainer.EmitFieldInitializers): Use it to determine if we
11905 can safely emitting the initializer of a field.
11907 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11909 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
11910 allowed inside a switch (without loop). Fixed bug #75433.
11912 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
11914 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
11915 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
11917 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11919 * driver.cs : kinda reverting the default encoding changes (not exact
11920 revert since I noticed that "codepage:reset" might not work fine).
11922 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11924 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
11925 Location. Now getter and setter store location correctly.
11926 (errors/cs0111-12.cs now reports the expected location.)
11928 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
11930 * driver.cs : Use default encoding on the environment.
11931 Removed (now that) extra parameter for SeekableStreamReader.
11932 * support.cs : (SeekableStreamReader) third .ctor() argument for
11933 StreamReader is not required (always true). preamble size could
11934 be acquired in simpler and safe way.
11936 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
11938 * cs-parser.jay: report CS0642 at warning level 3
11939 and report CS0642 for an if else statement also
11940 fixes bug #74745. Patch by John Luke (and a bit
11942 Removed extra CS0642 warning check for "while",
11944 * statement.cs: In Block.Resolve(), CS0642 check
11945 is reimplemented to check a sequence of an empty
11946 statement and a block.
11948 Both fix bug #66777.
11950 2005-08-24 Marek Safar <marek.safar@seznam.cz>
11952 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
11953 detection until I fix it.
11955 * cs-tokenizer.cs: Changed error message.
11957 * cs-parser.jay: Fixed 2 error locations.
11959 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
11960 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
11963 * enum.cs (GetSignatureForError): Fixed.
11965 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
11969 * typemanager.cs (RegisterProperty): Removed.
11971 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
11973 2005-08-24 Raja R Harinath <rharinath@novell.com>
11976 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
11977 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
11979 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11981 * expression.cs : tiny fix is required for not warning positive ulong.
11984 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11986 * expression.cs : add CS0652 check for constant and integral
11987 expression. Fixed bug #53974.
11989 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11991 * expression.cs : in DoNumericPromotions(), check if there is implicit
11992 conversion overload for string (to check CS0034). Fixed bug #52492.
11994 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
11996 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
11998 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12000 * ecore.cs : report location when it is *not* Null.
12002 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12008 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12009 correctly. Fixed bug #75721.
12011 2005-08-23 Raja R Harinath <rharinath@novell.com>
12013 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12014 loop that performs 'min (pos, char_count)'.
12017 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12018 converted value in Operator.OnesComplement.
12020 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12022 * anonymous.cs: If the anon method is pulled into a helper class,
12023 it needs to be `internal' not `private'. Fixes runtime behavior on
12026 2005-08-20 Martin Baulig <martin@ximian.com>
12028 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12029 scope if we don't already have it.
12031 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12032 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12035 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12038 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12039 is a partial class.
12041 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12043 The big constants rewrite
12044 Fix #75746, #75685 and more
12045 As a side effect saved 1MB for MWF ;-)
12047 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12048 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12049 enum based for corlib compilation.
12051 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12054 * class.cs (FixedField.Define): Use ResolveAsConstant.
12056 * const.cs (IConstant): Interface constants and enums.
12057 (Const.ResolveValue): New method for constant resolvning.
12058 (ExternalConstant): Constants from imported assemblies.
12060 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12061 conversion; like enums.
12062 (Constant.ToType): Converts this constant to different type.
12063 (Constant.Increment): Adds 1.
12065 * convert.cs (ImplicitConversionRequired): Simplified.
12067 * cs-parser.jay: Create EnumMember directly.
12069 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12071 * doc.cs (GenerateEnumDocComment): Removed.
12073 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12074 (ConvertIntLiteral): Removed.
12075 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12077 * enum.cs (EnumMember): Implement IConstant.
12078 (Enum.IsValidEnumConstant): Removed.
12079 (Enum.GetNextDefaultValue): Removed.
12080 (Enum.FindMembers): Updated.
12081 (Enum.GenerateDocComment): Iterate enum members.
12083 * expression.cs (Cast.TryReduce): Handle enums correctly.
12084 (New.Constantify): Made public.
12085 (MemberAccess.DoResolve): Removed contant specific if(s).
12087 * literal.cs (NullLiteral): Implement new abstract methods.
12089 * statement.cs (GotoCase.Resolve): Use new constant methods.
12090 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12092 * typemanager.cs (LookupEnum): Removed.
12093 (IsEnumType): Fixed to work with corlib.
12094 (RegisterConstant): Removed.
12095 (LookupConstant): Removed.
12096 (GetConstant): Changed to work with IConstant.
12098 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12100 * location.cs : Fixed overflown (>255) column number.
12102 2005-08-03 Raja R Harinath <rharinath@novell.com>
12104 First cut of the qualified-alias-member feature.
12105 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12107 * cs-parser.jay (DOUBLE_COLON): New token.
12108 (namespace_or_type_name): Add rule for recognizing
12109 qualified-alias-members.
12110 (primary_expression): Likewise.
12111 (element_access): Allow QualifiedAliasMember as a possible
12112 type-bearing expression.
12113 (local_variable_type, local_variable_pointer_type): Likewise.
12114 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12115 aliases in the current and enclosing namespace declarations.
12116 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12117 * decl.cs (MemberName.is_double_colon): New.
12118 (MemberName.MemberName): Add new constructor for alias-member.
12119 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12120 * expression.cs (QualifiedAliasMember): New expression type.
12122 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12124 * location.cs : it borked when no argument was specified.
12126 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12128 * location.cs : tiny ToString() format fix.
12130 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12132 * statement.cs : oops, it was missing.
12134 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12136 A set of fixes for precise line/column location.
12139 "token" field now holds a file/line "delta", a line number offset
12140 from the segment, and a column number. See also:
12141 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12142 December/009508.html
12143 Removed static IsNull. Use instance IsNull property instead.
12144 * cs-tokenizer.cs :
12145 For some tokens it stores Location. For Identifier it stores
12146 LocatedToken which is a pair of string name and location.
12147 Column numbers are adjusted only at getChar().
12149 Use Location.ToString() for reporting (it now contains column).
12151 Largely modified to use LocatedToken instead of
12152 string (IDENTIFIER), and to acquire Location from some tokens.
12153 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12154 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12156 Now MemberName holds Location. DeclSpace.ctor() receives Location
12157 as a parameter. Removed extra parameters to all derived classes.
12158 Replaced Location.IsNull() with instance property.
12159 * assign.cs, expression.cs :
12160 Added .ctor() overload that omits Location.
12162 Added "nameEscaped" flag that indicates the identifier was escaped
12163 in the source file. This fixes bug #57047.
12165 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12167 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12168 New method, looking for lo-case imported cls type.
12170 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12173 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12175 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12177 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12178 all_imported_types.
12179 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12181 Optimized to save 3.5 MB for SWF compilation.
12183 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12185 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12186 (PartialContainer.Create): Moved logic AddToContainer.
12187 (PartialContainer.MarkForDuplicationCheck): Shares name.
12189 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12192 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12194 (Namespace.GetSignatureForError): New method.
12196 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12197 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12199 2005-08-01 Raja R Harinath <rharinath@novell.com>
12202 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12203 member lookup rather than qualifier_type, since qualifier_type can
12206 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12208 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12211 2005-07-31 Miguel de Icaza <miguel@novell.com>
12213 * statement.cs: Copy the local exception into the exception
12214 captured local. Fixes 75674
12216 2005-07-31 Raja R Harinath <harinath@gmail.com>
12219 * expression.cs (Invocation.OverloadResolve): Don't report error
12220 CS1501 if error CS1502 has been reported.
12221 (New.DoResolve): Delegate CS1501 reporting to
12222 Invocation.OverloadResolve.
12225 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12226 invariant-meaning-in-block property in an enclosing block if
12229 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12231 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12232 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12233 (Switch.CheckSwitch): Just save 50kb for SWF.
12235 2005-07-27 Martin Baulig <martin@ximian.com>
12237 * anonymous.cs (CaptureContext.AddField): Added
12238 `AnonymousContainer am' argument; compute its toplevel scope if
12239 it's not already computed. Fixes #75649.
12241 2005-07-26 Raja R Harinath <rharinath@novell.com>
12244 * class.cs (Constructor.Emit): Reset block to null if the block
12247 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12249 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12251 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12253 * class.cs (MethodData.Define): Check whether accessor implementing
12254 interface is public.
12256 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12258 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12261 * namespace.cs (LookupType): Moved same type check to...
12263 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12264 with the same name.
12266 2005-07-21 Raja R Harinath <rharinath@novell.com>
12268 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12269 already found a typebuilder.
12270 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12271 MemberNames, not strings.
12273 * const.cs (Error_ExpressionMustBeConst):
12274 Rename from Error_EpressionMustBeConst.
12275 * const.cs, class.cs, statement.cd: Update.
12277 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12281 * const.cs (Const.LookupConstantValue): Report missing contant expression
12283 (Error_EpressionMustBeConstant): Only one error method.
12285 * class.cs, statement.c: Updated.
12287 2005-07-20 Raja R Harinath <rharinath@novell.com>
12289 * statement.cs (Block.Flags): Add back HasVarargs.
12290 (Block.flags): Make protected.
12291 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12293 * typemanager.cs (types, typecontainers, user_types): Remove.
12294 (UserTypes, TypeContainers): Likewise.
12295 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12296 (CleanUp, Reset): Update.
12297 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12298 (GetNestedType): Use Type.GetNestedType.
12299 (CoreLookupType): Take two arguments, the namespace and the
12300 basename of the type. Update to use the Namespace.Lookup
12302 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12303 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12304 string concatenation and substring matches.
12305 * class.cs, enum.cs, delegate.cs: Update to changes.
12307 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12309 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12310 Expression and made virtual.
12312 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12313 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12315 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12317 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12320 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12323 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12326 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12327 AssemblyCultureAttribute is not used on executable.
12330 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12332 2005-07-16 Raja R Harinath <rharinath@novell.com>
12335 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12336 New. Reports CS0252/CS0253.
12337 Mostly taken from preliminary patch by Duncak Mak.
12338 (Binary.DoResolveOperator): Store results of operator lookup.
12339 Use them to detect if we need to warn about unintended reference
12342 2005-07-15 Raja R Harinath <rharinath@novell.com>
12345 * namespace.cs (Namespace.Lookup): Add back location parameter.
12346 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12347 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12349 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12350 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12351 (Namespace.LookupType): ... this.
12352 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12354 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12355 purported to handle pointers.
12356 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12359 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12361 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12364 2005-07-15 Raja R Harinath <rharinath@novell.com>
12366 * namespace.cs (Namespace.Lookup): Drop location parameter.
12367 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12368 (NamespaceEntry.Lookup): ... this.
12369 (NamespaceEntry.Error_AmbiguousTypeReference):
12370 Move here from DeclSpace.
12371 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12373 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12374 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12375 Move to NamespaceEntry.
12376 * delegate.cs, expression.cs: Update to changes.
12378 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12380 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12381 CheckAttributeType and refactored.
12382 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12383 ResolveAsTypeTerminal error handling.
12384 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12386 (GetSignatureForError): Print errors in same way.
12389 * codegen.cs: Reflect attribute GetSignatureForError change.
12392 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12394 * namespace.cs (UsingEntry): Refactored to make fields private.
12397 statement.cs: Error_UnexpectedKind has extra parameter.
12399 2005-07-14 Raja R Harinath <rharinath@novell.com>
12401 * ecore.cs (IAlias): Remove.
12402 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12403 that implement the interface.
12404 * namespace.cs (Namespace): Likewise.
12405 (Namespace.declspaces): Renamed from 'defined_names'.
12406 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12407 DeclSpace instead of an IAlias.
12408 * tree.cs (Tree.AddDecl): Update.
12410 2005-07-12 Raja R Harinath <rharinath@novell.com>
12412 * statement.cs (Block.Flags); Remove HasVarargs.
12413 (Block.HasVarargs): Move to ToplevelBlock.
12414 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12415 (Block.Variables): Make protected. Initialize variable hashtable
12417 (Block.AddVariable): Update.
12418 (Block.Resolve): Update to changes.
12419 (ToplevelBlock.HasVarargs): New boolean.
12420 (ToplevelBlock.ThisVariable): Move here from Block.
12421 (ToplevelBlock.AddThisVariable): Likewise.
12422 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12423 * expression.cs (This.ResolveBase): Update to changes.
12424 (ArglistAccess.DoResolve): Likewise.
12426 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12429 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12431 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12432 not used and not used & assigned.
12433 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12435 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12438 * expression.cs (Is.DoResolve): null is never provided type.
12440 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12443 * cs-parser.jay: Less strict event error rule to catch more errors.
12445 2005-07-08 Martin Baulig <martin@ximian.com>
12447 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12448 gettter (allowed) or setter (not allowed).
12450 * class.cs (Accessor): Implement IIteratorContainer.
12451 (Accessor.Yields): New public field.
12452 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12453 per-accessor basis.
12456 (get_accessor_declaration, set_accessor_declaration): Set the
12457 `yields' flag on the accessor, not the property.
12458 (property_declaration): Do the iterators check on a per-accessor
12459 basis and not for the whole property.
12461 2005-07-08 Martin Baulig <martin@ximian.com>
12463 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12464 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12466 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12469 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12470 (ExtractSecurityPermissionSet): Cope with self referencing security
12471 attributes properly.
12473 * driver.cs (SetOutputFile): Made public property OutputFile.
12475 2005-07-07 Raja R Harinath <rharinath@novell.com>
12478 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12479 has_nonstatic_fields. Make into a FieldBase pointer.
12480 (TypeContainer.AddField): Add CS0282 check.
12481 (TypeContainer.EmitType): Update.
12483 2005-07-06 Miguel de Icaza <miguel@novell.com>
12485 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12486 compare if they start with __.
12488 2005-07-06 Raja R Harinath <rharinath@novell.com>
12490 * statement.cs (Switch.SwitchGoverningType): Only look at
12491 UserCasts that don't need implicit standard conversions to one of
12492 the allowed switch types (Fixes test-322.cs).
12493 (LocalInfo.Resolve): Re-enable sanity-test.
12495 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12497 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12499 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12501 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12503 2005-07-06 Raja R Harinath <rharinath@novell.com>
12506 * ecore.cs (SimpleName.GetSignatureForError): Add.
12507 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12508 (MemberAccess.GetSignatureForError): Add.
12510 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12512 The big error and warning messages review.
12542 * typemanager.cs: Updated.
12544 * class.cs: (MethodCore.SetYields): Moved here to share.
12545 (PropertyMethod.Define): Moved iterator setup here.
12547 * iterators.cs: Add orig_method to have full access to parent
12550 2005-07-05 Raja R Harinath <rharinath@novell.com>
12552 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12553 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12554 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12555 variable of struct type.
12556 * expression.cs (Unary.ResolveOperator): Update to change.
12557 (Indirection.VerifyFixed): Likewise.
12558 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12559 (ParameterReference.VerifyFixed): Value parameters are fixed.
12560 (This.VerifyFixed): Treat 'this' as a value parameter.
12561 * statement.cs (LocalInfo.IsFixed): Remove.
12563 2005-07-01 Martin Baulig <martin@ximian.com>
12565 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12566 `ec.EmitThis ()' to get the correct scope.
12568 2005-07-01 Martin Baulig <martin@ximian.com>
12570 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12571 instance is a ParameterReference; fixes #75299.
12573 2005-07-01 Martin Baulig <martin@ximian.com>
12575 Reverted Marek's latest patch (r46725):
12576 - it contains structural changes which are neither mentioned in
12577 the ChangeLog nor explained anywhere; for example the additional
12578 argument of EmitContext's and Iterator's .ctor's and the
12579 TypeContainer.DefineMembers() change.
12580 - structural changes like this should go in in seperate patches
12581 and not be hidden in a huge patch which just seems to affect
12582 warnings and errors.
12583 a big and hard to understand patch.
12584 - it breaks iterators and causes regressions, for instance in
12587 2005-06-30 Raja R Harinath <rharinath@novell.com>
12590 * expression.cs (Indexers.map): Remove.
12591 (Indexers.Append): Filter out inaccessible setters and getters.
12592 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12595 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12596 Refactored from ...
12597 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12598 (FieldExpr.Emit, PropertyExpr.Emit): Update.
12599 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
12600 * expression.cs (Invocation.EmitCall): Add CS0120 check.
12602 2005-06-30 Marek Safar <marek.safar@seznam.cz>
12605 * class.cs (FieldBase.GetInitializerExpression): One more field
12608 2005-06-28 Miguel de Icaza <miguel@novell.com>
12610 * pending.cs: Do not define a proxy if the base method is virtual,
12611 it will be picked up by the runtime (bug 75270).
12613 2005-06-08 Martin Baulig <martin@ximian.com>
12615 The big Iterators rewrite :-)
12617 * iterators.cs: Rewrite this to use the anonymous methods framework.
12619 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
12620 before the TypeContainers; see 2test-21.cs.
12623 (TypeContainer.DefineType): Don't create a new EmitContext if we
12624 already have one (this only happens if we're an Iterator).
12625 (TypeContainer.Define): Also call Define() on all our iterators.
12626 (Method.CreateEmitContext): Added support for iterators.
12629 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
12630 (AnonymousContainer.CreateMethodHost): Moved here from
12631 AnonymousMethod and made abstract.
12632 (AnonymousContainer.CreateScopeType): New abstract method.
12633 (AnonymousContainer.IsIterator): New public property.
12634 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
12635 get the ScopeTypeBuilder rather than manually defining it here.
12636 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
12639 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
12640 before RootContext.DefineTypes().
12642 * codegen.cs (EmitContext.RemapToProxy): Removed.
12643 (EmitContext.CurrentAnonymousMethod): Changed type from
12644 AnonymousMethod -> AnonymousContainer.
12645 (EmitContext.ResolveTopBlock): Protect from being called twice.
12646 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
12647 (EmitContext.EmitThis): Removed the iterators hacks; use the
12648 anonymous methods framework for that.
12651 (ToplevelBlock.Container): Make this a property, not a field.
12652 (ToplevelBlock.ReParent): New public method; move the
12653 ToplevelBlock into a new container.
12654 (Foreach.TemporaryVariable): Simplify.
12656 2005-06-05 Martin Baulig <martin@ximian.com>
12658 * statement.cs (LocalInfo.CompilerGenerated): New flag.
12659 (Block.AddTemporaryVariable): New public method; creates a new
12660 `LocalInfo' for a temporary variable.
12661 (Block.EmitMeta): Create the LocalBuilders for all the temporary
12663 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
12664 non-iterator variables.
12666 2005-06-05 Martin Baulig <martin@ximian.com>
12668 * statement.cs (Foreach.TemporaryVariable): Create the
12669 LocalBuilder in the Emit phase and not in Resolve since in some
12670 situations, we don't have an ILGenerator during Resolve; see
12671 2test-19.cs for an example.
12673 2005-06-04 Martin Baulig <martin@ximian.com>
12675 **** Merged r45395 from GCS ****
12677 The big Foreach rewrite - Part II.
12679 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
12680 with `PropertyInfo ienumerator_getcurrent'.
12682 * codegen.cs (VariableStorage): Removed.
12685 (Foreach): Derive from Statement, not ExceptionStatement.
12686 (Foreach.CollectionForeach): New nested class. Moved all the code
12687 dealing with collection foreach here.
12688 (Foreach.ForeachHelperMethods): Removed.
12689 (Foreach.TemporaryVariable): Implement IMemoryLocation.
12691 2005-05-23 Martin Baulig <martin@ximian.com>
12693 * statement.cs (Try.DoResolve): Don't create a `finally' if we
12694 don't need to. Fix #75014.
12696 2005-05-20 Martin Baulig <martin@ximian.com>
12698 Merged r44808 from GMCS.
12700 * class.cs (TypeContainer.CircularDepException): Removed.
12701 (TypeContainer.DefineType): Removed the `InTransit' stuff.
12702 (TypeContainer.CheckRecursiveDefinition): Check for circular class
12703 (CS0146) and interface (CS0529) dependencies here.
12705 2005-06-21 Raja R Harinath <rharinath@novell.com>
12707 * expression.cs (Invocation.EmitCall): Fix initialization
12708 'this_call' to reflect current behaviour. Fix indentation.
12710 * convert.cs (FindMostEncompassedType): Add two trivial special
12711 cases (number_of_types == 0 || number_of_types == 1).
12712 (FindMostEncompasingType): Likewise.
12714 2005-06-17 Raja R Harinath <rharinath@novell.com>
12716 Some cleanups preparing for the fix of #75283.
12717 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
12719 (EventExpr.InstanceResolve): Likewise.
12720 (EventExpr.DoResolve): Remove redundant checks.
12722 2005-06-10 Duncan Mak <duncan@novell.com>
12724 * cs-tokenizer.cs (process_directives): New flag for controlling
12725 the processing of preprocessor directives.
12726 (x_token): After seeing a '#', return Token.NONE instead of going
12727 to handle_preprocessing_directive() when not processing
12728 directives. This avoids unnecessary processing during the token peek in
12733 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
12734 the existing error reporting methods instead of Report.Error.
12736 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
12737 after Raja's rewrite.
12739 2005-06-08 Miguel de Icaza <miguel@novell.com>
12741 * class.cs: Small fix.
12743 2005-06-08 Raja R Harinath <rharinath@novell.com>
12746 * class.cs (GetPartialBases): Fix return value check of
12747 part.GetClassBases.
12749 2005-06-07 Raja R Harinath <rharinath@novell.com>
12751 Ensure that partial classes are registered in their enclosing
12752 namespace. Initial part of fix of #75160.
12753 * tree.cs (Tree.RecordDecl): Add new namespace argument.
12754 Register declspace with namespace here, not in
12755 DeclSpace.RecordDecl.
12756 * cs-parser.jay: Pass namespace to RecordDecl.
12757 * class.cs (PartialContainer.Create): Likewise.
12758 (ClassPart.DefineType): New sanity-check. Throws an exception if
12760 * decl.cs (Declspace.RecordDecl): Remove.
12761 * namespace.cs (NamespaceEntry.DefineName): Remove.
12763 2005-06-06 Marek Safar <marek.safar@seznam.cz>
12765 * rootcontext.cs: Reset TargetExt as well.
12767 2005-06-03 Raja R Harinath <rharinath@novell.com>
12769 * ecore.cs (Expression.Resolve): Emit CS0654 error when
12770 -langversion:ISO-1.
12772 2005-06-02 Raja R Harinath <rharinath@novell.com>
12774 Fix #75080, cs0119.cs.
12775 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
12777 (Expression.Resolve): ... this. Use it. Remove bogus code
12778 allowing ExprClass.Type and ExprClass.Namespace for
12779 ResolveFlags.VariableOrValue.
12780 (Expression.Resolve) [1-argument variant]: Change default resolve
12781 flags based on language version.
12782 (Expression.Error_UnexpectedKind): Use a simple string array
12783 rather than an ArrayList.
12784 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
12785 not ExprClass.Type.
12786 (TypeOfVoid.DoResolve): Likewise.
12787 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
12788 flags argument -- it always has the same value.
12790 2005-05-31 Raja R Harinath <rharinath@novell.com>
12793 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
12794 Use it in the error message.
12795 * assign.cs, expression.cs, statement.cs: Update.
12797 2005-05-30 Raja R Harinath <rharinath@novell.com>
12800 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
12801 the "almostMatchedMember" case too.
12802 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
12803 that failed the accessibility checks to 'almost_match'.
12805 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
12807 * attribute.cs: Use internal MethodBuilder methods to set
12808 ExactSpelling and SetLastError on PInvoke methods, instead
12809 of passing them via charset. Fixes #75060.
12811 2005-05-27 Raja R Harinath <rharinath@novell.com>
12813 * parameter.cs (Parameter): Remove TODO comment.
12814 (Parameter.DefineParameter): Remove Location parameter.
12815 (Parameters.LabelParameters): Likewise.
12816 * class.cs (Constructor.Emit): Update to change.
12817 (MethodData.Emit): Likewise.
12818 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
12819 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
12821 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
12824 Removed Parameters.Location and added Parameter.Location instead.
12825 Removed Location parameter from Emit() and GetSignature().
12832 Modified all related calls.
12834 2005-05-26 Raja R Harinath <rharinath@novell.com>
12836 Improve user-defined conversion handling.
12837 * convert.cs (GetConversionOperators): Rewrite. Return only the
12838 applicable operators.
12839 (AddConversionOperators): New. Helper for GetConversionOperators.
12840 (FindMostEncompassedType, FindMostEncompassingType): Verify that
12841 there is only one most encompassed/encompassing type.
12842 (FindMostSpecificSource, FindMostSpecificTarget): Remove
12843 "applicable operator" handling.
12844 (UserConversion): Move cache here from GetConversionOperators.
12845 Directly cache the chosen operator, rather than the whole
12847 (ExplicitNumericConversion): Fix buggy implementation of Decimal
12848 case. Allow conversion of decimal to sbyte and byte too.
12849 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
12850 New static methods. Used to avoid allocating EmptyExpressions in
12853 2005-05-24 Duncan Mak <duncan@novell.com>
12855 * ecore.cs (CastFromDecimal): New class for casting a decimal to
12856 another class, used in Convert.ExplicitNumericConversion.
12857 (CastToDecimal): New class, similar to above, but casts to
12858 System.Decimal, used in Convert.ImplicitNumericConversion and also
12859 in explicit convesion from double/float to decimal.
12861 * convert.cs (ImplicitNumericConversion): Handle implicit
12862 conversions to System.Decimal.
12863 (ExplicitNumericConversion): handle explicit conversions to
12868 2005-05-20 Miguel de Icaza <miguel@novell.com>
12870 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
12871 know the type at this stage, just break through. Fixes #75008
12873 2005-05-19 Martin Baulig <martin@ximian.com>
12876 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
12877 to disable error reporting.
12879 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
12880 here since we don't want to report an error; see the new test-336.cs.
12882 2005-05-19 Raja R Harinath <rharinath@novell.com>
12884 * statement.cs (ToplevelBlock.GetParameterReference)
12885 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
12886 Move here from class Block.
12887 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
12888 * expression.cs (ParameterReference.DoResolveBase): Likewise.
12890 2005-05-18 Martin Baulig <martin@ximian.com>
12895 (FlowBranching.Reachability): Add non-static public And() and Or()
12897 (FlowBranchingSwitch): New class; do the `break_origins' thing
12898 like in FlowBranchingLoop.
12899 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
12900 reachability, not just locals and parameters.
12901 (FlowBranching.MergeChild): Remove some of the hacks for loop and
12902 switch; MergeBreakOrigins() now takes care of that.
12904 2005-05-18 Martin Baulig <martin@ximian.com>
12906 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
12907 a loop and may leave it, reset the barrier; fixes #74974.
12909 2005-05-17 Marek Safar <marek.safar@seznam.cz>
12911 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
12914 * cs-parser.jay: Catch more lexical errors.
12916 * report.cs: Add one more Error method.
12919 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
12921 2005-05-17 Martin Baulig <martin@ximian.com>
12923 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
12926 2005-05-16 Raja R Harinath <rharinath@novell.com>
12928 Fix test-382.cs. Emit values of decimal constants.
12929 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
12931 (TypeContainer.AddField): ... this.
12932 (TypeContainer.EmitFieldInitializers): Allow the list of fields
12933 with initializers to include 'Const's.
12934 (ClassPart.RegisterFieldForInitialization): Forward to
12936 * const.cs (Const.Const): Pass initializer to base class.
12937 (Const.Define): In case of decimal constants, register them for
12938 initialization in a static constructor.
12940 2005-05-14 Martin Baulig <martin@ximian.com>
12942 * statement.cs (Block.Resolve): Correctly handle unreachable code;
12943 do not call ResolveUnreachable() on unreachable statements in
12944 here, see the comment in the source code.
12946 2005-05-13 Raja R Harinath <rharinath@novell.com>
12949 * expression.cs (BinaryResolveOperator): If one of the operands of
12950 an equality comparison is 'null' and the other is a pointer type,
12951 convert the null to a NullPointer.
12952 * convert.cs (ImplicitReferenceConversion): If the expression is a
12953 NullLiteral and the target type is a pointer type, return a
12954 NullPointer instead.
12955 (ImplicitConversionStandard): Likewise.
12957 2005-05-13 Marek Safar <marek.safar@seznam.cz>
12959 * cs-parser.jay: Set readonly context based on special constructs.
12961 * expression.cs (LocalVariableReference.DoResolveBase): Improved
12962 readonly variable error handling.
12964 * rootcontext.cs (EmitCode): Don't verify members when error
12967 * statement.cs (LocalInfo): Add reaodnly context information.
12968 (SetReadOnlyContext, GetReadOnlyContext): New methods.
12970 2005-05-13 Raja R Harinath <rharinath@novell.com>
12972 * statement.cs (Block.Resolve): Revert change below. Modify fix
12973 for #74041 to initialize 'resolved' to false only for explicit
12974 blocks. Fixes #74873.
12976 2005-05-12 Raja R Harinath <harinath@gmail.com>
12979 * typemanager.cs (unmanaged_enclosing_types): New.
12980 (IsUnmanagedType): Avoid infloops by using
12981 'unmanaged_enclosing_types' to talk with recursive invocations.
12983 2005-05-13 Martin Baulig <martin@ximian.com>
12985 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
12986 instance variable, not a local. Fix #74873.
12987 (Block.ResolveUnreachable): Set it to true here.
12989 2005-05-11 Duncan Mak <duncan@novell.com>
12991 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
12992 continuing to process for 'arg'.
12993 (handle_preprocessing_directive): Check the argument of the #endif
12994 directive and report error CS1025 if there are any trailing
12997 According to the C# spec, having even whitespace after the #endif
12998 directive is illegal; however, because we call arg.TrimEnd ()
12999 beforehand, we have the same behavior as csc, allowing whitespace
13000 after the directive.
13004 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13008 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13009 (Constructor.GetObsoleteAttribute): Implemented correctly.
13011 2005-05-10 Martin Baulig <martin@ximian.com>
13013 * support.cs (ReflectionParameters.ParameterModifier): Use
13014 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13015 and `ParameterAttributes.In'. Fixes #74884.
13017 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13019 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13021 * expression.cs (Argument.GetParameterModifier): Turned to property.
13022 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13024 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13027 2005-05-09 Raja R Harinath <rharinath@novell.com>
13030 * decl.cs (MemberCache.AddMethods): Register override methods,
13031 rather than non-override methods.
13032 * typemanager.cs (RegisterOverride): New.
13033 (IsOverride): Update.
13035 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13039 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13040 recursive declaration.
13042 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13044 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13046 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13048 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13050 2005-05-05 Raja R Harinath <rharinath@novell.com>
13053 * decl.cs (DeclSpace.FamilyAccessible):
13054 Use TypeManager.IsNestedFamilyAccessible.
13056 Fix reopened #64812.
13057 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13060 2005-05-04 Raja R Harinath <rharinath@novell.com>
13061 Abin Thomas <projectmonokochi@rediffmail.com>
13062 Anoob V E <projectmonokochi@rediffmail.com>
13063 Harilal P R <projectmonokochi@rediffmail.com>
13066 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13067 allow access to all static members.
13069 2005-05-04 Martin Baulig <martin@ximian.com>
13071 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13073 2005-05-04 Martin Baulig <martin@ximian.com>
13077 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13078 section at the end; make things work if `default' is not the last
13081 2005-05-04 Martin Baulig <martin@ximian.com>
13085 * statement.cs (Switch): Replaced the `got_default' field with a
13086 `default_section' one.
13087 (Switch.CheckSwitch): Set `default_section' here.
13088 (Switch.Resolve): If we're a constant switch and the constant is
13089 not found, use the default section.
13091 2005-05-03 Martin Baulig <martin@ximian.com>
13093 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13095 * statement.cs (Foreach.ArrayForeach): New nested class.
13096 (Foreach.TemporaryVariable): New nested class.
13097 (Foreach.EmitArrayForeach): Removed; this is now in the new
13098 ArrayForeach class.
13100 2005-05-03 Raja R Harinath <rharinath@novell.com>
13102 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13104 (VerifyPendingMethods): Revert change below.
13106 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13107 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13108 that used to trigger warning -28. Remove warning -28.
13109 * expression.cs (Invocation.OverloadResolve): Use
13110 TypeManager.IsOverride to distinguish override methods.
13113 * pending.cs (VerifyPendingMethods): If a base type implements the
13114 requested interface, don't bother checking individual methods of
13115 the base type. As a side-effect, this prevents the creation of
13116 unnecessary proxies.
13118 2005-05-02 Martin Baulig <martin@ximian.com>
13122 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13123 Also `And' the locals if the old vector is null.
13124 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13125 null; in this case we basically reset all the variables.
13127 2005-05-02 Martin Baulig <martin@ximian.com>
13131 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13132 Added `FlowBranching branching' argument; always `and' the
13133 variables instead of `or'ing them unless we're an infinite loop.
13135 * statement.cs (While.Resolve): Create a new sibling unless we're
13138 2005-05-02 Martin Baulig <martin@ximian.com>
13142 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13143 arguments; use it instead of creating a new TopLevelBlock.
13144 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13145 our ConstructorInitializer.
13148 (TopLevelBlock.TopLevelBranching): New public property.
13149 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13150 and create our `TopLevelBranching'.
13152 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13153 anonymous method host, use `block.TopLevelBranching' rather than
13154 creating a new branching.
13156 2005-04-20 Miguel de Icaza <miguel@novell.com>
13158 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13159 a ScopeInfo, if any of the current children is a child of the new
13160 entry, move those children there.
13162 2005-04-30 Martin Baulig <martin@ximian.com>
13164 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13165 at the beginning of a SwitchSection. Fix #73335.
13167 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13170 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13172 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13173 (FieldExpr.DoResolve): Obsolete members are ignored for field
13176 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13178 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13179 of arrays detection.
13181 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13183 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13185 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13188 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13190 * cs-parser.jay: Use the prefered version of -unsafe in error
13193 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13195 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13198 2005-04-20 John Luke <john.luke@gmail.com>
13200 * driver.cs: fix typo in error message, --outout to --output
13202 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13204 * codegen.cs (InRefOutArgumentResolving): New field.
13206 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13207 fields outside contructor.
13209 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13211 2005-04-19 Miguel de Icaza <miguel@novell.com>
13213 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13214 parameter code was not completed ever, so it was not as up-to-date
13215 as local variables. Must finish it.
13217 The bug fix was to compare the Toplevel of the block, not the
13218 current block. Thanks for Ben for pointing this out.
13220 2005-04-19 Raja R Harinath <rharinath@novell.com>
13222 * decl.cs (AddMethods): Use the declaring type of the problem
13223 method to determine if we want to squash a warning.
13225 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13227 * attribute.cs: Removed debug output.
13229 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13231 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13234 2005-04-18 Raja R Harinath <rharinath@novell.com>
13237 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13238 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13239 all null comparisons against reference types.
13241 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13244 * class.cs (TypeContainer.CircularDepException) New nested
13246 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13247 (TypeContainer.DefineType): Removed error, reset InTransit before
13249 (Class.DefineType): Throw exception when is in Transit.
13250 Catch exception and report error.
13251 (Struct.DefineType): Throw exception when is in Transit.
13252 Catch exception and report error.
13253 (Interface.DefineType): Throw exception when is in Transit.
13254 Catch exception and report error.
13256 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13257 handle nested exception handlers.
13259 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13262 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13263 InFinally and InCatch storage.
13265 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13266 (Catch.Resolve): Set and Restore ec.InCatch.
13267 (Try.Resolve): Set and Restore ec.InFinally.
13268 (Try.HasCatch): True when try has catch.
13270 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13272 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13273 for the same event member, so exclude such cases from warning 419.
13276 2005-04-16 Miguel de Icaza <miguel@novell.com>
13278 * expression.cs (Binary.ResolveOperator): Apply patch from John
13279 Luke to fix bug 59864: operators &, | and ^ on enumerations
13280 require that the same enum type on both sides.
13282 * driver.cs: Add warnings to old flag usage, this is to assist
13283 people who produce Makefiles and hope that the Makefiles will be
13286 * class.cs (TypeContainer.EmitType): Moved the definition of the
13287 special $PRIVATE$ field from the resolve phase to the Emit phase.
13288 During resolve we do not know if we are a struct with
13289 HasExplicitLayout, we know this only after the attributes for the
13292 Set the FieldOffset to zero on the dummy field that we create for
13293 the class. Fixes 74590.
13295 2005-04-16 Raja R Harinath <rharinath@novell.com>
13298 * ecore.cs (PropertyExpr.resolved): New.
13299 (DoResolve): Use it to handle a case of double resolution here.
13300 Handle a case of identical-name-and-type-name.
13301 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13302 resolution by storing the results of expression resolution back
13303 into the "probes" array.
13305 2005-04-15 Raja R Harinath <rharinath@novell.com>
13307 Fix cs0208-7.cs and cs0208-8.cs.
13308 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13309 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13310 error reporting to point out the reason a struct is not unmanaged.
13312 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13314 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13315 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13317 2005-04-13 Raja R Harinath <rharinath@novell.com>
13320 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13321 IdenticalNameAndTypeName here.
13322 (EventExpr.InstanceResolve): Likewise.
13324 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13326 C# 2.0 DefaultCharSetAttribute implementation
13328 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13329 which allows us to set GlobalNamespace for every resolve.
13330 (Attribute.ResolveArguments): Cut from Resolve.
13331 (Attribute.GetCharSetValue): Returns CharSet named argument.
13332 (Attribute.DefinePInvokeMethod): Gets default charset from
13334 (GlobalAttribute.ResolveAsTypeStep): Override.
13335 (GlobalAttribute.ResolveArguments): Override.
13337 * class.cs (TypeAttr): Is protected.
13339 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13340 (ModuleClass.DefaultCharSetType): New memeber.
13341 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13343 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13344 charset from module.
13346 * delegate.cs (TypeAttr): Override.
13347 (Delegate.DefineType): Use this TypeAttr.
13349 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13350 at very early stage (before types are defined) to resolve model
13351 module attributes. It will probably not work with corlib but it
13354 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13355 charset from module.
13357 * typemanager.cs (default_charset_type): New type.
13359 2005-04-13 Raja R Harinath <rharinath@novell.com>
13361 * decl.cs (MemberCache.AddMethods): Don't warn if
13362 System.Object.Finalize has buggy MethodAttributes.
13364 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13367 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13369 * doc.cs : detect ambiguous reference to overloaded members.
13370 Fixed bug #71603. MS 1.1 csc does not detect it.
13372 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13374 * doc.cs : delegates must not be referenced with parameters.
13377 2005-04-12 Miguel de Icaza <miguel@novell.com>
13379 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13381 2005-04-10 Miguel de Icaza <miguel@novell.com>
13383 * driver.cs (MainDriver): Stop processing if the CLS stage found
13386 (CompilerCallableEntryPoint.InvokeCompiler): Always
13387 reset after execution; Take a TextWriter argument for the
13390 * report.cs: Use the error stream instead of hardcoding stderr.
13392 2005-04-09 Miguel de Icaza <miguel@novell.com>
13394 * class.cs: Reduce code paths to test, too small of an
13395 optimization to make it worth the extra testing. Always perform
13398 2005-04-08 Raja R Harinath <rharinath@novell.com>
13401 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13402 operators that had errors reported on them.
13404 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13406 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13408 (Attribute.Resolve): Add named argument type checking.
13410 * class.cs (FixedField.Define): Use IsPrimitiveType
13412 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13414 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13415 unsafe parameter types.
13417 * statement.cs (Using.ResolveExpression): Add better error description.
13419 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13421 2005-04-08 Raja R Harinath <rharinath@novell.com>
13424 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13425 AttributeUsageAttribute in the emitcontext of the attribute class,
13426 not in the emitcontext of the attributable entity it was attached to.
13427 * cs-parser.jay: Use 'current_class', not 'current_container',
13428 when creating a GlobalAttribute.
13430 2005-04-08 Alp Toker <alp@atoker.com>
13432 * pending.cs: The fix to #58413 failed to compile methods implementing
13433 interfaces with/without params modifiers and vice versa, even though
13434 params modifiers aren't part of the signature. Make the modifier check
13435 less strict as in csc.
13437 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13438 Anoob V E <projectmonokochi@rediffmail.com>
13439 Harilal P R <projectmonokochi@rediffmail.com>
13442 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13443 modifiers of pending methods.
13444 (PendingImplementation.PendingImplementation): Initialize it.
13445 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13446 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13447 with ParameterData. Add check for modifiers.
13448 * class.cs (MethodData.Define): Update to changes.
13450 2005-04-07 Raja R Harinath <rharinath@novell.com>
13452 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13454 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13456 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13459 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13462 * typemanager.cs: Registered RequiredAttributeAttribute.
13464 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13466 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13467 Warning CS0169 is back at level 3.
13468 (IMethodData.SetMemberIsUsed): New method.
13470 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13471 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13473 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13475 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13477 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13480 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13483 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13484 to avoid the problems with nested types.
13486 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13487 Anoob V.E <projectmonokochi@rediffmail.com>
13488 Harilal P.R <projectmonokochi@rediffmail.com>
13489 Raja R Harinath <rharinath@novell.com>
13492 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13494 * typemanager (GetConstructor): Make public.
13496 2005-04-05 John Luke <john.luke@gmail.com>
13497 Raja R Harinath <rharinath@novell.com>
13500 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13501 struct too. Return false quicker in a few cases.
13502 (VerifyUnManaged): Use it.
13504 2005-04-05 Raja R Harinath <rharinath@novell.com>
13507 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13508 not 'unreachable_seen'.
13510 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13512 * attribute.cs (Attribute.GetValue): Removed unused.
13514 * codegen.cs (CodeGen.TrimExt): Removed unused.
13516 * cs-parser.jay (output): Removed unused.
13518 * cs-tokenizer.cs (hex_digits): Removed unused.
13520 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13522 * expression.cs (Indirection.LoadExprValue): Removed unused.
13523 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13525 * iterators.cs (Iterator.param_types): Removed unused.
13527 * statement.cs (Goto.block): Removed unused.
13528 (ToplevelBlock.did): Removed unused.
13529 (Switch.ResolveConstantSwitch): Removed unused.
13531 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13533 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13536 2005-04-01 Raja R Harinath <rharinath@novell.com>
13538 Fix #74232 and cs0208-3.cs.
13539 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13540 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13541 unmanaged type. Don't use FieldBuilders when 't' is a
13542 TypeBuilder. Use ModFlags and MemberType fields.
13543 * class.cs (MemberBase.member_type): Rename from MemberType.
13544 (MemberBase.MemberType): New property. Determines member_type on
13546 (MemberBase.DoDefine): Don't initialize MemberType here.
13547 (FieldMember.Define): Likewise.
13549 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13552 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13553 Attributes are emitted there.
13555 2005-04-01 Raja R Harinath <rharinath@novell.com>
13557 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13558 keyword in 'partial enum' too.
13559 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13561 Report from Kamil Skalski <nazgul@omega.pl>.
13564 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13565 have partial containers too.
13567 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13568 in block' checks to Block.CheckInvariantMeaningInBlock.
13569 * statement.cs (Block.GetKnownVariableInfo): Make private.
13570 (Block.IsVariableUsedInChildBlock): Remove.
13571 (Block.IsVariableUsedInBlock): Likewise.
13572 (Block.CheckInvariantMeaningInBlock): New. Show location of
13573 conflicting declaration.
13574 (Block.AddVariable): Make error messages less long-winded and more
13575 specific. Show location of conflicting declaration.
13576 * parameter.cs (Parameters.Location): New readonly property.
13578 2005-03-31 Raja R Harinath <rharinath@novell.com>
13580 Clean up semantics of invoking ResolveMemberAccess.
13581 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13582 can have an instance, ensure that we pass in a non-TypeExpression
13583 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13584 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13585 argument. Update to changes and simplify.
13586 (FieldExpr.Emitinstance): Remove CS0120 check.
13587 (PropertyExpr.EmitInstance): Likewise.
13588 * expression.cs (Argument.Resolve): Likewise.
13589 (Invocation.DoResolve): Update to changes in semantics of
13590 InstanceExpression.
13592 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13595 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13598 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
13600 2005-03-31 Raja R Harinath <rharinath@novell.com>
13602 Fix difference in behaviour with commandline invocation.
13603 * driver.cs (Driver.Reset): New.
13604 (CompilerCallableEntryPoint): Call it.
13606 * statement.cs (If.Resolve): Avoid spurious "uninitialized
13607 variable" warnings if the boolean expression failed to resolve.
13609 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
13611 * attribute.cs: Fix the union of several permissions when some of them
13612 are unrestricted (so the result isn't an unrestricted permission set).
13615 2005-03-30 Raja R Harinath <rharinath@novell.com>
13617 * ecore.cs (MemberExpr): New class. Convert from interface
13619 (MemberExpr.ResolveMemberAccess): Refactor and move here from
13620 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
13622 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
13623 (MethodGroupExpr.IsExplicitImpl): Remove.
13624 (Expression.GetFieldFromEvent): Remove.
13625 (SimpleName.MemberStaticCheck): Remove.
13626 (SimpleName.DoSimpleNameResolve): Update to changes.
13627 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
13628 (MemberAccess.IdenticalNameAndTypeName): Remove.
13629 (MemberAccess.error176): Move to MemberExpr.
13630 (MemberAccess.DoResolve): Update to changes.
13631 (BaseAccess.DoResolve): Likewise.
13633 2005-03-30 Marek Safar <marek.safar@seznam.cz>
13635 C# 2.0 Conditional attribute class implementation
13637 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
13638 Analyzes class whether it has attribute which has ConditionalAttribute
13639 and its condition is not defined.
13641 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
13642 (Class.IsExcluded): New method. Search for at least one defined
13643 condition in ConditionalAttribute of attribute class.
13645 2005-03-30 Raja R Harinath <rharinath@novell.com>
13647 * ecore.cs (PropertyExpr): Derive from Expression, not
13648 ExpressionStatement.
13649 (PropertyExpr.EmitStatement): Remove.
13651 2005-03-29 Raja R Harinath <rharinath@novell.com>
13654 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
13655 internal field "value__" of an enum be private. The examples for
13656 "value__" that I found on MSDN all used FieldAttributes.Private.
13658 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
13659 Don't mention IL method attribute names.
13661 Fix #47991. Remove a TODO.
13662 * statement.cs (Block.Toplevel): Make into a field.
13663 (Block.Parameters): Move into ToplevelBlock.
13664 (Block.known_variables): Rename from child_variable_names.
13665 (Block.Block): Remove variants that take Parameters. Initialize
13666 'Toplevel' with the immediately surrounding toplevel block.
13667 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
13668 LocalInfo parameter.
13669 (Block.GetKnownVariableInfo): New.
13670 (Block.IsVariableNameUsedInChildBlock): Update.
13671 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
13672 the block, even though it may not be in scope.
13673 (Block.AddVariable): Remove Parameters parameter. Use
13674 Toplevel.Parameters instead.
13675 (Block.AddConstant): Remove Parameters parameter.
13676 (Block.GetParameterReference): Update to use Toplevel.Parameters.
13677 (Block.IsParamaterReference): Likewise.
13678 (Block.IsLocalParameter): Likewise. Simplify a lot.
13679 (ToplevelBlock.Parameters): New. Moved from Block.
13680 (ToplevelBlock.ToplevelBlock): Update to changes. Always
13681 initialize Parameters to a non-null value.
13682 * cs-parser.jay: Update to changes.
13683 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
13684 simple names that mean different things in the same block. Use
13685 Block.IsVariableNameUsedInBlock.
13687 2005-03-28 Raja R Harinath <rharinath@novell.com>
13689 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
13690 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
13691 GetTypeHandle. It is possible for a reflected type to derive from
13692 a TypeBuilder (e.g., int[] derives from the TypeBuilder
13693 System.Array during mscorlib compilation).
13694 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
13695 contain a method_hash, don't create one either. Don't create a
13696 deep copy of the base cache's method_hash.
13697 (MemberCache.SetupCache): Rename back from DeepCopy.
13698 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
13699 already initialized. If we see an override function, add its
13700 underlying base virtual function to the member_hash too.
13702 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
13704 2005-03-26 Raja R Harinath <harinath@acm.org>
13707 * assign.cs (Assign.DoResolve): When the RHS of an assignment
13708 fails to resolve, ensure that the LHS is still resolved as an
13711 2005-03-25 Raja R Harinath <harinath@acm.org>
13713 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
13715 (Enum.current_ec): Remove.
13716 (Enum.LookupEnumValue): Remove EmitContext argument.
13717 Just uses the one created during DefineType.
13718 (Enum.FindMembers): Update.
13719 * expression.cs (MemberAccess.DoResolve): Update.
13721 2005-03-22 Marek Safar <marek.safar@seznam.cz>
13723 * assign.cs (Assign.DoResolve): Check for CS1717 when
13724 source and target are same (uses Equals).
13726 * expression.cs (LocalVariableReference, ParameterReference,
13727 This): Implemented Equals, GetHashCode.
13729 * statement.cs (Block.GetParameterReference): Removed useless
13732 2005-03-22 Raja R Harinath <rharinath@novell.com>
13735 * statement.cs (Block.AddVariable): Ensure that we skip implicit
13736 blocks before deciding whether the error is cs0136 or cs0128.
13738 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
13739 (using_alias_directive, using_namespace_directive): Pass
13740 MemberName, not an expression to Namespace.UsingAlias and
13742 (MakeName): Use the MemberName of the namespace.
13743 * namespace.cs (Namespace.MemberName): New.
13744 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
13745 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
13747 * decl.cs (MemberName.Name): Make readonly.
13748 (MemberName.FromDotted): New "constructor".
13749 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
13750 (MemberCore.Name): Compute from MemberName on demand.
13751 (MemberCore.SetMemberName): Provide a way to change the
13753 (MemberCore.AddToContainer): Don't take a fullname parameter.
13754 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
13755 fully qualified name of the container to the member name.
13756 (TypeContainer.AddToTypeContainer): Use a fully qualified name
13757 only if the type is a member of the root container.
13758 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
13759 MemberName.Left rather than searching for an embedded ".".
13760 (PartialContainer.CreatePart): Update to changes in RootContext.
13761 (MemberBase.ShortName): Turn into a property. Use
13762 MemberCore.SetMemberName.
13763 (MemberBase.ExplicitInterfaceName): Remove.
13764 (MemberBase.UpdateMemberName): Remove.
13765 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
13766 (PropertyBase.SetMemberName): New override.
13767 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
13768 (Tree.GetDecl): New.
13769 (Tree.AllDecls): Rename from Decls.
13770 * attribute.cs, enum.cs, report.cs: Update to changes.
13771 * driver.cs (MainDriver): Use MemberName.FromDotted on
13772 RootContext.MainClass.
13774 2005-03-21 Marek Safar <marek.safar@seznam.cz>
13776 * class.cs (FixedField.Define): Check for CS1664 and more sanity
13779 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
13781 2005-03-18 Marek Safar <marek.safar@seznam.cz>
13783 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
13784 property accessor modifiers.
13786 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
13787 fixed buffer attribute (CS1716).
13788 (PropertyMethod.HasCustomAccessModifier): When property accessor
13789 has custom modifier.
13791 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
13793 (PropertyExpr.DoResolveLValue): Add CS0272.
13795 2005-03-17 Miguel de Icaza <miguel@novell.com>
13797 * convert.cs: When converting to a pointer, use the proper Conv.U
13798 or Conv.I depending on the source data type.
13800 * cs-tokenizer.cs: Make the size for large decimal constants,
13803 2005-03-17 Martin Baulig <martin@ximian.com>
13805 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
13806 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
13808 2005-03-17 Martin Baulig <martin@ximian.com>
13810 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
13811 to bool so we can return an error condition.
13812 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
13815 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
13817 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
13820 2005-03-16 Raja R Harinath <rharinath@novell.com>
13822 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
13823 Refactor to avoid traversing the list of assemblies, and to avoid
13824 string concatenation.
13825 * typemanager.cs (guid_attr_type): Remove.
13826 (negative_hits, pointers, references): Remove hashes.
13828 (GetConstructedType): New. Uses type_hash to handle constructed
13829 types (arrays, references, pointers).
13830 (GetReferenceType, GetPointerType): Use it.
13831 (GetNestedType): New. Uses type_hash to handle nested types of
13833 (LookupType, LookupTypeDirect): Remove.
13834 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
13835 'types' hash and LookupTypeReflection directly.
13836 (params_string, params_object): Use GetConstructedType.
13837 * namespace.cs (Namespace.cached_types): New. Cache of reflected
13839 (Namespace.Lookup): Use cached_types.
13840 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
13841 provided by old TypeManager.LookupType.
13842 * rootcontext.cs (MakeFQN): Remove.
13843 * decl.cs (DeclSpace.MakeFQN): Likewise.
13844 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
13845 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
13846 TypeManager.GetConstructedType.
13847 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
13849 2005-03-15 Marek Safar <marek.safar@seznam.cz>
13851 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
13854 * cs-parser.jay: Reports CS1527 for any namespace element.
13856 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
13859 * expression.cs (ParameterReference.IsAssigned): Changed error to
13861 (Error_WrongNumArguments): Moved CS0245 detection here.
13863 * statement.cs (Return.Resolve): Add CS1622 report.
13865 2005-03-11 Marek Safar <marek.safar@seznam.cz>
13867 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
13869 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
13871 * attribute.cs expression.cs: Get rid of some allocations.
13873 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
13875 * doc.cs : just eliminate the latest change.
13877 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13879 * doc.cs : commented out the latest change. It breaks xml-030.cs
13881 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13883 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
13884 fail. So invoke CreateType() in FindDocumentedType().
13886 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
13888 * cs-tokenizer.cs : added IsKeyword().
13889 * doc.cs : Detect keyword incorrectly used as identifier.
13890 Allow identifiers prefixed by @.
13892 2005-03-10 Marek Safar <marek.safar@seznam.cz>
13894 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
13895 It caused exception in namespace resolving (again!).
13897 * class.cs (Class.ctor): Removed exit.
13898 (PropertyMethod.ctor): ditto.
13900 * codegen.cs (Codegen.Reset): Reset static data.
13901 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
13903 * cs-tokenizer.cs (Cleanup): Removed.
13905 * driver.cs (GetSystemDir): Rewrote to one line command.
13906 It caused problem with unloaded dynamic modules.
13907 (UnixParseOption): Removed Exit.
13908 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
13909 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
13910 Now can be mcs used as library.
13912 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
13915 * location.cs (Reset): Reset static data.
13917 * namespace.cs (Reset): Reset static data.
13919 * report.cs (Report.Reset): Reset static data.
13921 * rootcontext.cs (RootContext.Reset): Reset static data.
13923 * tree.cs (RootTypes.ctor): Use Location.Null
13925 * typemanager.cs (TypeManager.Reset): Reset static data.
13926 (CoreLookupType): Removed Exit.
13927 (TypeHandle.Reset): Reset static data.
13929 2005-03-10 Raja R Harinath <rharinath@novell.com>
13932 * typemanager.cs (ComputeNamespaces): Import namespaces from
13933 referenced modules too.
13935 2005-03-09 Raja R Harinath <rharinath@novell.com>
13937 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
13940 2005-03-09 Raja R Harinath <rharinath@novell.com>
13942 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
13943 enclosing DeclSpace. This ensures that a name-lookup populates
13944 more caches and there are fewer 'TypeExpression's. Carve out
13945 nested type lookup into ...
13946 (LookupNestedTypeInHierarchy): ... this.
13948 2005-03-09 Raja R Harinath <rharinath@novell.com>
13950 Clean up a few partial-class semantics.
13951 Fixes test-357.cs and cs1618-2.cs.
13952 * cs-parser.jay (struct_declaration): Use 'current_class' as
13953 parent of newly-created struct. Remove call to Register ().
13954 Use 'pop_current_class' to complete handing the current struct.
13955 (interface_declaration): Likewise.
13956 (class_declaration): Likewise.
13957 (enum_declaration): Use 'current_class' as parent of newly created
13959 (delegate_declaration): Likewise.
13960 (pop_current_class): New function. This is used to handle closing
13961 up the 'current_class' and 'current_container', and pointing them
13962 to the enclosing class/container.
13963 (CSharpParser): Initialize 'current_class' too.
13964 * decl.cs (MemberCore): Add check for invariant: a partial
13965 container is not a parsed entity, and thus does not enclose any
13967 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
13968 (DeclSpace.BaseTypeExpr): Use it.
13969 (DeclSpace.LookupType): Add check for invariant.
13970 * class.cs (TypeContainer): Add check for invariant: a nested
13971 class should have the same NamespaceEntry as its enclosing class.
13972 (TypeContainer.EmitFieldInitializers): Make virtual.
13973 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
13975 (TypeContainer.Register): Remove.
13976 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
13977 null. Use TypeResolveEmitContext for resolving base types and
13978 interfaces. Move initialization of Parts.TypeBuilder here from
13980 (TypeContainer.DefineNestedTypes): ... here.
13981 (PartialContainer): Take a Namespace not a NamespaceEntry.
13982 (PartialContainer.Create): Don't use Register. Call the
13983 appropriate Add... function directly.
13984 (ClassPart): Take both the PartialContainer and the enclosing
13985 class as constructor arguments.
13986 (ClassPart.EmitFieldInitializers): Override.
13987 (ClassPart.PartFindNestedTypes): Remove.
13988 (FieldBase.GetInitializerExpression): Resolve the initializer
13989 expression in the emit context of the enclosing class.
13990 * tree.cs (RootTypes): Remove Register ().
13992 2005-03-08 Marek Safar <marek.safar@seznam.cz>
13994 * cs-parser.jay: Removed CS0134.
13996 * driver.cs: Removed CS1901.
13998 * expression.cs (SizeOf.DoResolve): Don't report CS0233
13999 for predefined types.
14001 2005-03-07 Duncan Mak <duncan@novell.com>
14003 * codegen.cs (Save): Catch UnauthorizedAccessException as
14004 well. Fixes bug #73454.
14006 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14008 * cs-tokenizer.cs (xtoken): Add CS1035.
14010 * class.cs (MethodData.Define): Add CS0683.
14011 (FieldMember.ctor): Add CS0681.
14013 2005-03-07 Raja R Harinath <rharinath@novell.com>
14015 * ecore.cs (SimpleName.DoResolve): Rename from
14016 SimpleName.DoResolveAllowStatic.
14017 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14018 Pass 'intermediate' flag to MemberStaticCheck.
14019 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14020 of "intermediate" lookups via MemberAccess.
14021 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14022 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14024 2005-03-07 Raja R Harinath <rharinath@novell.com>
14027 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14028 slipped in because of variable names that are identical to a
14029 builtin type's BCL equivalent ('string String;', 'int Int32;').
14030 (PropertyExpr.EmitInstance): Likewise.
14032 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14034 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14036 * report.cs (warning_ignore_table): Made public.
14038 2005-03-04 Raja R Harinath <rharinath@novell.com>
14041 * class.cs (MethodData.Emit): Pass 'container' to
14042 container.GetObsoleteAttribute instead of 'container.Parent'.
14044 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14046 * cs-parser.jay: Add 1534 error test.
14048 * iterators.cs (Yield.CheckContext): Add error 1629.
14049 (Iterator.ctor): Save unsafe modifier.
14050 (MoveNextMethod.DoEmit): Restore unsafe context.
14052 * namespace.cs (UsingAlias): Better error message.
14054 2005-03-03 Dan Winship <danw@novell.com>
14056 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14057 the warning message [#73219]
14059 2005-03-03 Raja R Harinath <rharinath@novell.com>
14061 Fix compile with MCS 1.0.0.0.
14062 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14063 w_restore to not depend on string constant folding.
14065 2005-03-03 Raja R Harinath <rharinath@novell.com>
14067 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14068 CS0246 check to users who passed 'silent = false'.
14069 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14071 (SimpleName.SimpleNameResolve): Update.
14072 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14073 (MemberAccess.IdenticalNameAndTypeName): Update.
14074 * doc.cs (FindDocumentedTypeNonArray): Update.
14076 2005-03-03 Raja R Harinath <rharinath@novell.com>
14078 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14079 * parameters.cs (ComputeAndDefineParameters): Remove.
14080 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14081 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14082 Use GetParameterInfo.
14084 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14086 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14088 2005-03-02 Raja R Harinath <rharinath@novell.com>
14090 Unify DeclSpace.LookupType and DeclSpace.FindType.
14091 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14092 is in charge of defining nested types on demand.
14093 (DeclSpace.LookupType): Use it when the current_type is a
14094 TypeBuilder. Use LookupTypeDirect for reflected types.
14095 (DeclSpace.FindType): Remove.
14096 (DeclSpace.LookupInterfaceOrClass): Likewise.
14097 (DeclSpace.DefineTypeAndParents): Likewise.
14098 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14099 DeclSpace.LookupType.
14100 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14101 * typemanager.cs (LookupType): Simplify.
14102 (AddUserType): Remove type from negative_hits.
14103 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14104 * class.cs (TypeContainer.FindMembers): Move handling of nested
14106 (TypeContainer.FindMembers_NestedTypes): ... here.
14107 (TypeContainer.FindNestedType): Implement override.
14108 (ClassPart.FindNestedType): Delegate to PartialContainer.
14109 (ClassPart.PartFindNestedType): Looks up the nested types of the
14112 2005-03-02 Martin Baulig <martin@ximian.com>
14114 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14115 static constructor in static classes.
14117 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14119 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14120 sizeParamIndex is not specified.
14122 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14125 * report.cs (WarningMessage.IsEnabled): Missing null check.
14127 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14129 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14130 in the fields and not in the properties.
14132 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14134 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14137 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14139 * attribute.cs: Small refactoring (improved robustness).
14140 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14141 (ValidateGuid): Removed.
14142 (Resolve): Removed referenced to above mentioned.
14143 (GetAttributeUsage): Made private and changed to work without
14145 (GetIndexerAttributeValue): Don't crash.
14146 (GetConditionalAttributeValue): Ditto.
14147 (GetClsCompliantAttributeValue): Ditto.
14148 (ExtractSecurityPermissionSet): All attributes exceptions are
14150 (GetPropertyValue): New helper.
14151 (GetMethodImplOptions): New method.
14152 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14153 some missing properties.
14155 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14156 (Method.ApplyAttributeBuilder): Updated.
14158 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14161 2005-02-28 Raja R Harinath <rharinath@novell.com>
14164 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14165 non-simple types (array, pointer, reference).
14167 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14169 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14171 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14173 (Method.CheckBase): Catch wrong destructor here.
14174 (MethodData.Define): Add errors 550, 668.
14176 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14178 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14180 * pending.cs (VerifyPendingMethods): Add error 551.
14182 * typemanager.cs (CSharpName): Next error report helper.
14184 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14186 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14187 attributes. Removed useless attribute double check.
14188 It saves almost 2MBs for corlib.
14190 2005-02-25 Raja R Harinath <rharinath@novell.com>
14193 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14194 called twice in case of error.
14196 2005-02-23 Chris Toshok <toshok@ximian.com>
14198 Fix compiler portions of #72827.
14199 * statement.cs (Block.Emit): call Begin/EndScope on the
14200 EmitContext instead of the ILGenerator.
14202 * codegen.cs (EmitContext.BeginScope): new method, call
14203 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14205 (EmitContext.BeginScope): same, but EndScope and CloseScope
14207 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14208 offset and call the superclass's OpenScope(int) with it.
14209 (SymbolWriter.CloseScope): get the current il
14210 offset and call superclass's CloseScope(int) with it.
14212 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14214 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14215 CS1677 for out and ref as well.
14217 * class.cs (Method.Define): Add error CS1599 detection.
14219 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14221 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14223 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14225 * support.cs.cs (ModifierDesc): New helper method.
14227 2005-02-23 Raja R Harinath <rharinath@novell.com>
14228 Abin Thomas <projectmonokochi@rediffmail.com>
14229 Anoob V E <projectmonokochi@rediffmail.com>
14230 Harilal P R <projectmonokochi@rediffmail.com>
14232 Fix #57851, #72718.
14233 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14234 MemberLookup (used for error reporting) actually returns a result.
14235 Fix error report number (122, not 112).
14237 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14238 Anoob V E <projectmonokochi@rediffmail.com>
14239 Harilal P R <projectmonokochi@rediffmail.com>
14242 * pending.cs (PendingImplementation.GetAbstractMethods):
14243 Find NonPublic members too.
14245 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14247 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14250 * class.cs (MethodCore.CheckMethodAgainstBase):
14251 Add error 239 report.
14253 2005-02-21 Raja R Harinath <rharinath@novell.com>
14256 * expression.cs (Invocation.IsApplicable): Make public.
14257 (Invocation.IsParamsMethodApplicable): Likewise.
14258 * delegate.cs (Delegate.VerifyApplicability): Don't use
14259 Invocation.VerifyArgumentCompat for parameter applicability
14260 testing. Use Invocation.IsApplicable and
14261 Invocation.IsParamsMethodApplicable.
14263 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14265 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14267 * class.cs (Operator.Define): Add error 217 report.
14269 2005-02-21 Raja R Harinath <rharinath@novell.com>
14271 * namespace.cs (UsingEntry.Resolve): Undo change below.
14273 2005-02-21 Raja R Harinath <rharinath@novell.com>
14276 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14277 disable the error message when the extended MemberLookup also
14279 (Expression.MemberLookupFinal): Update.
14280 (SimpleName.DoSimpleNameResolve): Update.
14281 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14282 Don't use MemberLookupFinal.
14283 (New.DoResolve): Update.
14284 (BaseAccess.CommonResolve): Update.
14286 2005-02-21 Raja R Harinath <rharinath@novell.com>
14289 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14290 occured previously, don't resolve again.
14292 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14295 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14296 argument. Call ResolveAttributeUsage for unresolved.
14297 when types doesn't match ctor arguments.
14299 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14300 for nested attribute classes.
14301 (Class.attribute_usage): Removed.
14302 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14303 for attribute class.
14305 * ecore.cs (IsAttribute): Removed.
14307 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14309 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14311 (attribute_types): Removed.
14312 (EmitCode): Global attributes are emited as the latest.
14314 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14316 * class.cs (EmitFieldInitializers): Don't emit field initializer
14317 for default values when optimilization is on.
14319 * constant.cs (Constant.IsDefaultValue): New property.
14321 * driver.cs: Add /optimize handling.
14325 * literal.cs: Implement new IsDefaultValue property.
14327 * rootcontext.cs (Optimize): New field, holds /optimize option.
14329 2005-02-18 Raja R Harinath <rharinath@novell.com>
14331 Fix crasher in re-opened #72347.
14332 * namespace.cs (Namespace.Lookup): Return null if
14333 DeclSpace.DefineType returns null.
14336 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14338 2005-02-18 Raja R Harinath <rharinath@novell.com>
14340 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14341 now returns null if it cannot resolve to an lvalue.
14342 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14343 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14344 returned null. Remove check for SimpleName.
14345 (EventExpr.DoResolveLValue): New.
14346 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14347 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14349 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14350 avoid CS0131 error.
14351 (Unary.ResolveOperator): Move CS0211 check ...
14352 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14354 (Unary.DoResolveLValue): Simplify.
14355 (AddressOf.DoResolveLValue): New.
14356 (ArrayAccess.DoResolveLValue): New.
14358 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14360 * attribute.cs (Attribute.Resolve): Add arguments casting for
14361 when types doesn't match ctor arguments.
14363 2005-02-16 Raja R Harinath <rharinath@novell.com>
14365 Fix parts of #63202.
14366 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14367 lookup of operator in base type. Ensure that all checks happen
14368 when the operator resolves to an "op_..." method.
14370 2005-02-15 Raja R Harinath <rharinath@novell.com>
14373 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14374 'ignore_cs0104' parameter. Pass it to ...
14375 (NamespaceEntry.Lookup): ... this.
14376 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14377 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14378 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14379 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14380 Update. Request that cs0104 errors be ignored.
14381 (ComposedCast.ResolveAsTypeStep): Update.
14383 2005-02-14 Raja R Harinath <rharinath@novell.com>
14386 * expression.cs (Invocation.BetterFunction): Remove support for
14387 comparing virtual functions and their overrides.
14388 (Invocation.IsOverride): New.
14389 (Invocation.OverloadResolve): Don't consider 'override' functions
14390 during candidate selection. Store them in a lookaside list.
14391 If the selected method is a 'virtual' function, use the list to
14392 find any overrides that are closer to the LHS type.
14394 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14396 * expression.cs (New.DoResolve): Add complex core type reduction.
14397 (New.Constantify): Converts complex core type syntax like 'new int ()'
14398 to simple constant.
14400 2005-02-14 Raja R Harinath <rharinath@novell.com>
14402 * decl.cs (EntryType.EntryType): New constructor to create an
14403 updated copy of a cache entry.
14404 (MemberCache.AddMethods): Use it.
14405 (MemberCache.ClearDeclaredOnly): Remove.
14406 (MemberCache.MemberCache): Update.
14408 2005-02-11 Miguel de Icaza <miguel@novell.com>
14410 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14411 variable. This one is represents the actual low-level declaration
14412 of the method, as opposed to the semantic level `IsStatic'.
14414 An anonymous method which is hosted into a static method might be
14415 actually an instance method. IsStatic would reflect the
14416 container, while MethodIsStatic represents the actual code
14419 * expression.cs (ParameterReference): Use the new MethodIsStatic
14420 instead of IsStatic.
14422 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14423 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14424 set on the current EmitContext.
14426 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14427 resolve our casted expression as an LValue. This triggers the
14428 proper LValue processing that is later required by Assign.
14432 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14434 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14436 C# 2.0 Fixed buffer implementation
14438 * anonymous.cs: Update after RegisterHelperClass renaming.
14440 * attribute.cs (AttributeTester.fixed_buffer_cache):
14441 Cache of external fixed buffers.
14442 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14443 implementation if field is fixed buffer else null.
14446 (TypeContainer.AddField): Accept FieldMember instead of Field.
14447 (FieldBase.IsFieldClsCompliant): Extracted code from
14448 VerifyClsCompliance descendant customization.
14449 (FixedField): New class handles fixed buffer fields.
14450 (FixedFieldExternal): Keeps information about imported fixed
14452 (IFixedField): Make access to internal or external fixed buffer
14455 * cs-parser.jay: Add fixed buffer parsing.
14457 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14460 * expression.cs (Indirection): Extended implementation to accept
14461 fixed buffer field.
14462 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14463 (ElementAccess.MakePointerAccess): Get type as parameter.
14464 (DoResolve): Add fixed buffer field expression conversion.
14465 (DoResolveLValue): Ditto.
14466 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14467 (ArrayPtr): Derives from FixedBufferPtr.
14468 (ArrayPtr.Emit): Add extra emit for array elements.
14470 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14472 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14473 for compiler generated types.
14474 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14476 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14477 and consume less memory.
14478 (Fixed.Resolve): Add fixed buffer case.
14480 * typemanager.cs (compiler_generated_attr_ctor,
14481 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14482 (HasElementType): Add our own implementation to work on every
14485 2005-02-11 Miguel de Icaza <miguel@novell.com>
14487 * anonymous.cs (CaptureContext): Track whether `this' has been
14490 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14491 only captured `this' if it was implicitly done (instance
14492 methods/variables were used).
14494 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14495 `this' must be captured.
14497 2005-01-30 Miguel de Icaza <miguel@novell.com>
14499 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14500 is null it means that there has been no need to capture anything,
14501 so we just create a sibling.
14503 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14505 Just a partial fix. The other half is fairly elusive.
14507 2005-02-10 Raja R Harinath <rharinath@novell.com>
14509 Fix #52586, cs0121-4.cs.
14510 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14511 and return a hashtable.
14512 (MemberCache.ClearDeclaredOnly): New.
14513 (MemberCache.MemberCache): Update to change. Make a deep copy of
14514 the method_hash of a base type too.
14515 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14516 type methods. Overwrite entries with the same MethodHandle so
14517 that the ReflectedType is correct. The process leaves in base
14518 virtual functions and their overrides as distinct entries.
14519 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14520 matters since it was boxed in a ArrayList before.
14521 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14523 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14524 case of a virtual function and its override (choose the overload
14526 (Invocation.OverloadResolve): Avoid 'override' members during
14527 'applicable_type' calculation.
14529 2005-02-09 Raja R Harinath <rharinath@novell.com>
14531 Combine two near-redundant caches.
14532 * typemanager.cs (method_params): Rename from method_internal_params.
14533 (TypeManager.GetParameterData): New. Replace
14534 Invocation.GetParameterData.
14535 (TypeManager.LookupParametersByBuilder): Remove.
14536 * expression.cs (Invocation.method_parameter_cache): Remove.
14537 (Invocation.GetParameterData): Remove.
14539 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14542 2005-02-08 Raja R Harinath <rharinath@novell.com>
14545 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14546 TypeManager.multicast_delegate_type is null, resolve it by looking
14547 up "System.MulticastDelegate".
14548 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14550 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14551 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14552 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14555 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14556 (LabeledStatement.AddReference): New. Set 'referenced'.
14557 (Goto.Resolve): Use it.
14559 2005-02-05 John Luke <john.luke@gmail.com>
14561 * driver.cs: remove duplicate -doc line in Usage ()
14563 2005-02-04 Raja R Harinath <rharinath@novell.com>
14565 * location.cs (Location.AddFile): Fix CS2002 error report.
14567 2005-02-02 Martin Baulig <martin@ximian.com>
14569 * delegate.cs (Delegate.DefineType): Report an internal error if
14570 TypeManager.multicast_delegate_type is null. See bug #72015 for
14573 2005-02-02 Raja R Harinath <rharinath@novell.com>
14575 Fix a crasher in a variant of #31984.
14576 * const.cs (Constant.CheckBase): New override that defers the
14577 new-or-override check in case the base type hasn't been populated
14579 (Constant.Define): Ensure the new-or-override check is performed.
14581 2005-02-01 Duncan Mak <duncan@ximian.com>
14583 * const.cs (LookupConstantValue): Check that `ce' is not null
14584 before calling GetValue ().
14586 2005-02-01 Raja R Harinath <rharinath@novell.com>
14588 Fix test-334.cs (#69519).
14589 * cs-parser.jay (using_alias_directive): Pass in an expression to
14590 NamespaceEntry.UsingAlias.
14591 (using_namespace_directive): Pass in an expression to
14592 NamespaceEntry.Using.
14593 (namespace_name): Don't flatten to a string.
14594 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14595 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14597 (NamespaceEntry.UsingEntry): Likewise.
14598 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
14600 (NamespaceEntry.LookupForUsing): Remove.
14601 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
14603 (NamespaceEntry.Lookup): Remove support for dotted names.
14605 2005-02-01 Raja R Harinath <rharinath@novell.com>
14607 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
14609 (NamespaceEntry.ImplicitParent): Compute on demand.
14610 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
14611 parallels the current.
14612 (NamespaceEntry.LookupForUsing): Use it.
14613 (NamespaceEntry.Lookup): If the current namespace-entry is
14614 implicit, don't search aliases and using tables.
14616 2005-02-01 Raja R Harinath <rharinath@novell.com>
14619 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
14621 (TypeContainer.BaseCache): Compute on demand.
14622 (TypeContainer.FindMembers): Define constants and types if they're
14623 not already created.
14624 (FieldMember.Define): Move resetting of ec.InUnsafe before error
14626 * const.cs (Constant.Define): Make idempotent.
14628 2005-01-29 Miguel de Icaza <miguel@novell.com>
14630 * pending.cs: Produce better code (no nops produced by using Ldarg
14633 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
14634 i - 1' it should be arg + 1.
14638 2005-01-28 Raja R Harinath <rharinath@novell.com>
14640 * attribute.cs (Attribute.CheckAttributeType): Make private
14642 (Attribute.ResolveType): Make virtual.
14643 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
14644 handling of RootContext.Tree.Types.
14646 2005-01-27 Raja R Harinath <rharinath@novell.com>
14648 Update attribute-handling to use the SimpleName/MemberAccess
14650 * cs-parser.jay (attribute): Pass in an expression to the
14651 constructors of Attribute and GlobalAttribute.
14652 * attribute.cs (Attribute): Take an expression for the name.
14653 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
14654 passed in attribute name expression.
14655 (Attribute.CheckAttributeType): Use it.
14656 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
14657 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
14658 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
14659 argument to prevent error messages if the lookup fails.
14661 2005-01-27 Marek Safar <marek.safar@seznam.cz>
14663 * expression.cs (Indirection): Implemented IVariable interface
14664 to support indirection in AddressOf operator.
14665 (PointerArithmetic.Emit): Add optimalization for case where
14666 result can be precomputed.
14668 2005-01-26 Martin Baulig <martin@ximian.com>
14670 * class.cs (TypeContainer.AttributeTargets): Return the correct
14671 AttributeTargets depending on our `Kind' instead of throwing an
14672 exception; fixes #71632.
14674 2005-01-26 Marek Safar <marek.safar@seznam.cz>
14677 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
14680 2005-01-25 Raja R Harinath <rharinath@novell.com>
14683 * expression.cs (MemberAccess.DoResolve): Don't complain with
14684 cs0572 when the LHS of a member access has identical name and type
14687 2005-01-25 Marek Safar <marek.safar@seznam.cz>
14690 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
14692 Create custom PermissionSet only for PermissionSetAttribute.
14694 2005-01-24 Marek Safar <marek.safar@seznam.cz>
14697 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
14698 delegates in static class.
14700 2005-01-24 Martin Baulig <martin@ximian.com>
14702 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
14703 merging an implicit block, just use its reachability.
14705 * statement.cs (Block.Resolve): Make the unreachable code check
14706 work wrt. implicit blocks; see test-337 from #63842.
14708 2005-01-21 Alp Toker <alp@atoker.com>
14710 * cs-parser.jay: destructor_declaration's container is PartialContainer
14711 not Class when partial types are used, so use Kind prop instead of
14714 2005-01-22 Miguel de Icaza <miguel@ximian.com>
14716 * cs-parser.jay: Improve error reporting when an interface
14717 declares new types.
14719 2005-01-20 Dick Porter <dick@ximian.com>
14721 * support.cs: SeekableStreamReader fix from Sandor Dobos
14722 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
14723 chars are read. Fixes bug 70369.
14725 2005-01-20 Raja R Harinath <rharinath@novell.com>
14727 * cs-parser.jay (catch_clause): Simplify current_block handling
14730 2005-01-17 Miguel de Icaza <miguel@ximian.com>
14732 * convert.cs (ImplicitStandardConversionExists): Synchronize the
14733 code with ImplicitStandardConversion to handle the implicit
14734 conversion of method groups into valid delegate invocations.
14736 The problem is that in parameter handling we were using this code
14737 path. Fixes bug #64698
14739 2005-01-19 Raja R Harinath <rharinath@novell.com>
14741 * cs-parser.jay: Fix several infelicities.
14742 - Avoid assigning to the parser value stack. Code like
14743 '$3 = null' is unclean. Synthesize a value for the code block
14745 - Avoid using oob_stack for storing location information. Use ...
14746 (_mark_): ... this. New (empty) rule. Saves the current location
14748 (foreach_statement): Avoid using oob_stack for current_block
14749 handling. Use technique used in for_statement and
14750 using_statement. Synthesize a value for the code block to store
14751 additional intermediate information.
14753 2005-01-13 Miguel de Icaza <miguel@ximian.com>
14755 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
14756 of a different type is only allowed to private fields of a
14757 containing type, not on fields of a base class.
14759 See test-174.cs and error cs0122-9.cs
14761 2005-01-13 Raja R Harinath <rharinath@novell.com>
14763 Fix test-335.cs (bug #58126).
14764 * cs-parser.jay (argument): Split out non-expression parts of the
14765 rule into 'non_simple_argument'.
14766 (invocation_expression): Support parenthesized invocations with
14767 multiple arguments, and with single non-simple arguments.
14769 2005-01-13 Raja R Harinath <rharinath@novell.com>
14771 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
14774 2005-01-12 Raja R Harinath <rharinath@novell.com>
14776 Fix cs0038-1.cs, cs1640-6.cs.
14777 * ecore.cs (Expression.Resolve): Remove special-case for
14778 SimpleName in error-handling.
14779 (Expression.almostMatchedMembers): Relax access permission to
14781 (Expression.MemberLookupFailed): Handle duplicates in
14782 almostMatchedMembers list.
14783 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
14784 * expression.cs (New.DoResolve): Report CS1540 for more cases.
14785 * typemanager.cs (GetFullNameSignature): Use the MethodBase
14786 overload if the passed in MemberInfo is a MethodBase.
14788 2005-01-12 Marek Safar <marek.safar@seznam.cz>
14791 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
14792 for non-CAS & merge permission sets properly.
14794 2005-01-11 Raja R Harinath <rharinath@novell.com>
14796 Improve standard-compliance of simple name and member access
14797 resolution. Fixes bugs #52697, #57200, #67520, #69519.
14798 * ecore.cs (FullNamedExpression): New abstract base class
14799 for Namespaces and TypeExpressions.
14800 (ResolveFlags.SimpleName): Remove.
14801 (SimpleName): Remove support for dotted names.
14802 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
14803 DeclSpace.FindType and DeclSpace.LookupType.
14804 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
14805 (Expression.ExprClassName): Make member function.
14806 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
14807 a namespace. Remove creation of dotted "SimpleName"s.
14808 (MemberAccess.DoResolve): Likewise.
14809 * decl.cs (DeclSpace.Cache): Make private.
14810 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
14811 (DeclSpace.FindType): Update.
14812 (DeclSpace.LookupType): Move here from RootContext. Return a
14813 FullNamedExpression.
14814 * namespace.cs (Namespace): Derive from FullNamedExpression
14815 so that it can be part of expression resolution.
14816 (Namespace.Lookup): Return an FullNamedExpression.
14817 (NamespaceEntry.LookupAlias): Lookup aliases only in current
14819 * rootcontext.cs (NamespaceLookup): Remove.
14820 (LookupType): Move to DeclSpace.
14821 * attribute.cs (CheckAttributeType): Update.
14822 * doc.cs (FindDocumentedType): Remove allowAlias argument.
14823 (FindDocumentedTypeNonArray): Likewise.
14825 2005-01-11 Raja R Harinath <rharinath@novell.com>
14827 Fix cs0509.cs, cs1632.cs.
14828 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
14829 is the same as IsInterface.
14830 (TypeContainer.GetClassBases): Likewise.
14831 * statement.cs (LabeledStatement.ig): New field.
14832 (LabeledStatement.LabelTarget): Save ILGenerator which created the
14834 (LabeledStatement.DoEmit): Check that the label was created with
14835 the same ILGenerator.
14837 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14840 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
14841 accessors to its properties.
14843 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
14844 from accessors to property.
14846 2005-01-10 Marek Safar <marek.safar@seznam.cz>
14849 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
14850 only for overrides.
14852 2005-01-08 Miguel de Icaza <miguel@ximian.com>
14854 * attribute.cs: Check for null and empty strings.
14856 I have lost another battle to Paolo.
14858 2005-01-07 Marek Safar <marek.safar@seznam.cz>
14861 * class.cs (PropertyMethod): Set Parent field in ctors.
14862 (SetMethod.InternalParameters): Add unsafe switch hack.
14863 Override MarkForDuplicationCheck where it is appropriate.
14865 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
14866 It says whether container allows members with the same name.
14867 Base default is no.
14868 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
14869 Removed is_method parameter.
14871 2005-01-06 Duncan Mak <duncan@ximian.com>
14873 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
14874 because the previous change led to incorrect reporting of CS1032
14875 ("Cannot define/undefine preprocessor symbols after first token in
14876 file"). Instead of using `tokens_seen' as the only flag that
14877 triggers CS1040, introduce `comments_seen'. This new flag is used
14878 to signify having seen comments on the current line, so it is
14879 unset after a newline.
14881 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14883 * doc.cs : When searching for a type, find nested type too.
14884 This fixes bug #71040.
14886 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
14889 - Warn missing member comment on those classes which also does not
14890 have doc comments. Fixed bug #71041.
14891 - Don't warn missing doc comment on default constructor.
14894 2005-01-06 Duncan Mak <duncan@ximian.com>
14896 * cs-tokenizer.cs (xtoken): After handling traditional C-style
14897 comments, set `tokens_seen' to true. This allows us to detect
14898 misplaced preprocessor directives (i.e. not at the beginning of
14899 the a line, nor after whitespaces). In that case, report error
14900 CS1040. This fixes bug #56460.
14902 * cs-parser.jay (interface_member_declaration): Add checks for
14903 IsExplicitImpl, and report CS0541 error if an interface member is
14904 defined as an explicit interface declaration.
14906 2005-01-06 Marek Safar <marek.safar@seznam.cz>
14909 * class.cs (PropertyMethod): Set Parent field in ctors.
14910 (SetMethod.InternalParameters): Add unsafe switch hack.
14912 * decl.cs (MemberCore.Parent): Cannot be readonly.
14914 2005-01-06 Raja R Harinath <rharinath@novell.com>
14916 * decl.cs (DeclSpace.ResolveType): Remove.
14917 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
14918 Merge in code from ...
14919 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
14920 * class.cs, enum.cs: Update to changes.
14922 2005-01-06 Miguel de Icaza <miguel@ximian.com>
14924 * anonymous.cs: Ensure that we init the scope of our parent if it
14925 has not been initialized yet.
14927 2004-12-30 Duncan Mak <duncan@ximian.com>
14929 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
14930 if field.FieldBuilder is null. Fixes #70758.
14932 * convert.cs: Fixed some typos and updated some of the comments.
14933 (ImplicitStandardConversionExists):
14934 (TryImplicitIntConversion): If `target_type' is an interface and
14935 the type of `ic' implements this interface, return true or a new
14936 BoxedCast instead of null. This fixes #70468.
14938 2004-12-29 Duncan Mak <duncan@ximian.com>
14940 * expression.cs (Argument.Emit): Check that Expr is
14941 IMemoryLocation before casting to it, and report CS1510 otherwise.
14945 2004-12-21 Ben Maurer <bmaurer@ximian.com>
14947 * statement.cs (Block.ThisVariable): remove the recursion here, to
14948 make the --profile more sane.
14950 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
14952 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
14953 assembly, by JB Evain.
14955 2004-12-17 Raja R Harinath <rharinath@novell.com>
14957 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
14958 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
14959 "parent" refers to enclosing type/class. "base" refers to superclass.
14961 2004-12-17 Raja R Harinath <rharinath@novell.com>
14963 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
14964 Ensure that we only have GlobalAttributes.
14965 * attribute.cs (Attribute.Emit): Make non-virtual.
14966 (GlobalAttribute.Emit): Remove.
14967 (Attribute.Resolve): Make virtual.
14968 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
14969 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
14970 the argument. Don't create one.
14971 (Attribute.GetObsoleteAttribute): Likewise.
14972 (Attribute.GetClsCompliantAttributeValue): Likewise.
14973 * class.cs, decl.cs: Update to changes.
14975 2004-12-17 Marek Safar <marek.safar@seznam.cz>
14977 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
14979 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
14981 * statement.cs (Foreach.Resolve): Add error 186 report.
14983 2004-12-16 Marek Safar <marek.safar@seznam.cz>
14985 * expression.cs (Conditional.DoResolve): Add warning 429.
14987 * statement.cs (If.Resolve): Add warning 665.
14989 2004-12-16 Raja R Harinath <rharinath@novell.com>
14991 New invariant: RootContext.Tree.Types.NamespaceEntry == null
14992 except when in the parser, and in GlobalAttribute.
14993 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
14994 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
14995 RootContext.Tree.Types.NamespaceEntry once work is done.
14996 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
14997 and resets RootContext.Tree.Types.NamespaceEntry.
14999 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15001 * cs-parser.jay: Don't create a block for every variable.
15003 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15005 * location.cs: Provide extra information.
15007 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15008 variables from the captured environment, it is the ldarg_0.
15010 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15012 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15015 * class.cs: Changed warning level for 169 to avoid developer
15016 displeasure from warning flooding. It will be changed back when they
15017 fix most of current BCL warnings.
15019 * RootContext.cs: Pushed default WarningLevel to 3.
15021 * statement.cs: Removed unused variable.
15023 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15025 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15026 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15027 Add error 502 report.
15028 (StaticClass.DefineType): Add error 441 report.
15029 (Class.AllowedModifiersProp): New virtual property as temporary
15030 extension to AllowedModifiers.
15031 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15032 to share implementation with StaticClass and don't call virtual
15035 * driver.cs (MainDriver): Add error 1558 test.
15037 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15038 report. Moved error 36 test here.
15040 * statement.cs (Throw.Resolve): Add error 724 report.
15042 * typemanager.cs: Add out_attribute_type core type.
15044 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15046 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15048 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15050 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15053 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15055 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15056 Add error 3023 report.
15057 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15059 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15062 2004-12-12 John Luke <john.luke@gmail.com>
15064 * driver.cs (AddArgs): take -- into account when
15065 adding arguments, fixes bug 65710
15067 2004-12-12 Martin Baulig <martin@ximian.com>
15069 * expression.cs (Unary.TryReduceNegative): Added support for
15070 SByteConstant and ByteConstant.
15071 (Unary.Reduce): Check error values from TryReduceNegative().
15073 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15075 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15076 and report exception as error 182.
15078 2004-12-10 Raja R Harinath <rharinath@novell.com>
15080 * driver.cs (Main): Fix message when there are warnings.
15082 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15084 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15086 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15088 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15089 Reduced number of warnings.
15091 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15093 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15095 * driver.cs: Removed message.
15097 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15099 2004-12-08 <vargaz@freemail.hu>
15101 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15103 2004-12-08 Martin Baulig <martin@ximian.com>
15105 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15106 instead of a CS3002 for properties and indexer.
15108 2004-12-08 Martin Baulig <martin@ximian.com>
15110 * decl.cs (MemberName.ToString): Make this work again.
15112 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15114 * attribute.cs (Resolve): Add error 591 detection.
15116 * class.cs (FieldMember.Define): Add error 1547 detection.
15117 (Indexer.Define): Add error 620 detection.
15118 (Operator.Define): Add error 590 detection.
15120 * ecore.cs: Missing argument for error 79.
15122 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15125 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15128 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15131 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15133 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15134 Some operator comments were suppressed.
15135 * doc.cs : Implicit/explicit operator name in doc comments are like
15136 "op_Explicit(type)~returnType", so added suffix handling.
15138 2004-12-07 Martin Baulig <martin@ximian.com>
15141 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15142 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15143 (DeclSpace.ec): New protected field; store the EmitContext here.
15144 (DeclSpace.EmitContext): New public property; moved here from
15146 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15149 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15150 (Enum.Emit): Don't create a new EmitContext.
15152 * delegate.cs (Delegate.DefineType): Always create the
15155 * iterators.cs (Iterators.DefineIterator): Create a new
15156 EmitContext and store it in `ec'.
15158 2004-08-24 Martin Baulig <martin@ximian.com>
15161 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15162 this for accessibility checks.
15163 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15164 IsNestedFamilyAccessible.
15165 (TypeManager.IsSubclassOf): New method, do what the name actually
15168 2004-12-06 Raja R Harinath <rharinath@novell.com>
15170 Fix crash on cs0657-17.cs.
15171 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15172 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15173 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15174 the case where the NamespaceEntry gets overwritten.
15176 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15178 Fixed #69195, #56821
15179 * ecore.cs (ResolveBoolean): Tiny refactoring.
15181 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15182 of right expression resolving when left is false constant and
15183 operator is LogicalAnd OR true constant and operator is LogicalOr.
15185 * statement.cs (ResolveUnreachable): Always reports warning.
15187 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15189 * class.cs: Distinguish between 1721 and 1722 (just a little help
15190 for the programmer).
15192 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15194 * delegate.cs: Only allow this on new versions of the language.
15196 2004-12-02 Duncan Mak <duncan@ximian.com>
15198 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15200 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15201 here as a static method. Take an additional bool out parameter
15202 `must_do_cs1540_check' for signaling to InstanceResolve.
15203 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15204 member field from PropertyExpr class and made it an argument of
15205 the method instead.
15206 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15207 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15208 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15209 and `remove_accessor' as well as InstanceResolve: report CS0122
15214 2004-12-03 Raja R Harinath <rharinath@novell.com>
15216 Fix test-327.cs, test-328.cs, and put in early infrastructure
15217 for eventually fixing #52697.
15218 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15219 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15220 from other methods.
15221 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15222 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15223 (VerifyUsing, error246): Update.
15224 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15225 'NamespaceEntry.LookupNamespaceOrType'.
15227 2004-12-03 Martin Baulig <martin@ximian.com>
15229 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15230 method as our child, call AnonymousMethod.Compatible() on it.
15232 2004-12-03 Raja R Harinath <rharinath@novell.com>
15234 Disable XML documentation support in 'basic' profile.
15235 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15236 Redirect XmlElement to System.Object.
15237 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15238 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15239 * mcs.exe.sources: Add doc-bootstrap.cs.
15240 * doc-bootstrap.cs: New file. Contains empty stub implementation
15243 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15245 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15246 comments are allowed.
15248 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15250 * delegate.cs: Add checks for subtypes in paramaters and return values
15251 in VerifyMethod () to add support for Covariance/Contravariance
15254 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15256 * report.cs: Remove extra closing parenthesis.
15258 * convert.cs (Error_CannotImplicitConversion): If the name of the
15259 types are the same, provide some extra information.
15261 * class.cs (FieldBase): Use an unused bit field from the field to
15262 encode the `has_offset' property from the FieldMember. This saves
15263 a couple of Ks on bootstrap compilation.
15265 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15266 method as our child, return the AnonymousMethod resolved
15269 * expression.cs (New.DoResolve): Allow return values from
15270 NewDelegate to also include AnonymousMethods.
15274 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15277 * attribute.cs (Resolve): Improved implementation of params
15278 attribute arguments.
15280 * support.cs (ParameterData): Add HasParams to be faster.
15282 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15284 all things are for /doc support:
15286 * doc.cs: new file that supports XML documentation generation.
15287 * mcs.exe.sources: added doc.cs.
15289 Handle /doc command line option.
15290 Report error 2006 instead of 5 for missing file name for /doc.
15291 Generate XML documentation when required, after type resolution.
15293 Added support for picking up documentation (/// and /** ... */),
15294 including a new XmlCommentState enumeration.
15296 Added lines to fill Documentation element for field, constant,
15297 property, indexer, method, constructor, destructor, operator, event
15298 and class, struct, interface, delegate, enum.
15299 Added lines to warn incorrect comment.
15301 Added Documentation field (passed only when /doc was specified).
15303 Added DocComment, DocCommentHeader, GenerateDocComment() and
15304 OnGenerateDocComment() and some supporting private members for
15305 /doc feature to MemberCore.
15307 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15309 Added overriden DocCommentHeader.
15311 Added overriden DocCommentHeader and GenerateDocComment().
15313 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15315 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15316 unwrapping the enumeration values, chain to
15317 DoConstantNumericPromotions again, so we can promote things to the
15318 fundamental types (takes care of enums that are bytes, sbytes).
15322 2004-12-01 Raja R Harinath <rharinath@novell.com>
15324 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15325 Fix long-standing bug in type-lookup. Use FindType instead of
15326 LookupType when ec.ResolvingTypeTree.
15327 (Attribute.ResolveType, Attribute.Resolve)
15328 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15330 (Attributes.Search): Remove internal version. Update.
15331 (Attributes.SearchMulti): Update.
15332 (Attributes.GetClsCompliantAttribute): Remove.
15333 (Attributes.GetIndexerNameAttribute): Remove.
15334 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15335 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15336 * class.cs (Indexer.Define): Likewise.
15338 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15341 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15342 MarshallByReference members access.
15344 * expression.cs: Use CheckMarshallByRefAccess;
15345 Better error CS0197 message.
15347 * report.cs: Print whole related error message.
15349 2004-11-30 Raja R Harinath <rharinath@novell.com>
15351 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15352 the current directory to help debugging.
15354 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15356 * class (GetClassBases): Better error 60 report.
15357 (EventProperty): Disabled warning 67 detection.
15359 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15362 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15364 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15367 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15370 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15372 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15374 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15376 * attribute.cs (Attribute.Resolve): Refine error reporting and
15377 report a cs0117 if the identifier does not exist, to distinguish
15378 from 0617 which is a miss-use of the actual identifier.
15380 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15381 between cs0070 and cs0079.
15383 * class.cs (MemberBase.DoDefine): When reporting a wrong
15384 accessibility level, we use MethodCore to compare instead of
15385 Method (this was a regression in some refactoring effort).
15387 So now we correctly report cs0056 again.
15389 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15390 testing the target_type (which was known to be object_type) and
15391 not the source type (which is anonymous_method).
15393 Fixed reporting of error cs1660.
15395 * expression.cs (UserCast.Source): Expose the underlying cast.
15397 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15398 allowed types to find a match to int32 first (most common).
15400 In addition, it ignores any ImplicitUserConversions that did an
15401 internal implicit conversion (as the switch statement allows only
15402 one integral conversion to exist).
15404 * class.cs (PartialContainer.Create): rename `name' to
15405 `member_name' for clarity. Then replace the string calls with a
15406 call to MemberName.GetPartialName, as now using
15407 MemberName.ToString is an error (this is due to the side effects
15408 it had, that were fixed in the past).
15410 This will restore the error reporting on a number of partial class
15411 errors that were missusing this (and getting an exception as a
15412 results, which is now just a plain textual warning, because
15413 yyparse debug output would crash otherwise).
15415 2004-11-26 Raja R Harinath <rharinath@novell.com>
15417 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15419 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15421 * rootcontext.cs (LookupType): Make sure to cache lookups that
15422 don't give us a negative result. This saves about 5% of corlib
15425 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15427 * report.cs (AbstractMessage.Print): messages are sent to stderr
15429 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15430 non-interface in the list of interfaces (at this point, either
15431 parent was properly set, or a base class is being listed in the
15432 interfaces section).
15434 This flags error 1722, and resolves the crash from bug 69259.
15436 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15438 * statement.cs (Using.EmitExpressionFinally): make this work right
15439 for valuetypes. Fixes 69926.
15441 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15443 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15444 converted to an enum" here, before we try to change the underlying
15445 type. This code exists, but it is a different code path than the
15446 one used while encoding constants.
15448 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15449 old bug: when converting from the null literal to a pointer,
15450 return an EmptyCast, not the NullLiteral.
15452 This fixes #69921, the recent null_type changes probably made this
15453 bug more prominent.
15455 (ImplicitReferenceConversionExists): In addition, resynchronized
15456 the code here, so it matches the same code in
15457 ImplicitReferenceConversionExists for the `from any class-type S
15458 to any interface-type T'.
15461 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15463 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15465 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15467 * cs-parser.jay: Use verbosity accordingly.
15469 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15471 * expression.cs (Unary.ResolveOperator): Do not report warning;
15472 AddressOf reads from variable.
15474 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15476 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15480 * attribute.cs (Attributable): Removed CheckTargets.
15481 (Attributes.Emit): Explicit attribute targets are tested here.
15483 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15484 not enabled for interfaces.
15486 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15487 (GetAssemblyName): Ouch next bug there.
15489 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15491 * expression.cs: Error 275 added.
15493 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15495 Fix bug #69177 (Implemented decimal constant support)
15497 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15498 (BinaryFold): Add DecimalConstant.
15500 * const.cs (Define): Decimal constant
15502 (ChangeType): Add decimal type handling.
15503 (LookupConstantValue): Don't set value for decimal type but
15504 emit DecimalConstantAttribute. Needed for constant optimization.
15506 * constant.cs (ToDecimal): New method.
15507 (ConvertToDecimal): New method.
15508 (IntConstant): Implemented ConvertToDecimal.
15509 (DecimalConstant.Emit): Emit optimized version for decimals in
15512 * expression.cs (ResolveOperator): Changed order of constant
15513 reduction to work correctly with native types which have
15514 overloaded operators.
15515 (ResolveMemberAccess): Extract constant value from attribute
15518 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15520 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15521 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15522 (ChangeType): Decimal is special.
15523 (TypeToCoreType): Add decimal type.
15525 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15527 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15530 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15532 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15535 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15537 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15539 * pending.cs (PendingImplementation): Grab only interfaces.
15541 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15543 * statement.cs (ForeachHelperMethods): Add location member and
15544 error 202 detection.
15546 2004-11-19 Raja R Harinath <rharinath@novell.com>
15548 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15549 automatically handled by executable.make.
15550 (PROGRAM): Make profile-specific.
15552 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15554 * expression.cs (DoResolveBase): Fixed wrong warning for out
15557 2004-11-18 Martin Baulig <martin@ximian.com>
15559 Merged latest changes into gmcs. Please keep this comment in
15560 here, it makes it easier for me to see what changed in MCS since
15561 the last time I merged.
15563 2004-11-17 Raja R Harinath <rharinath@novell.com>
15565 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15566 (TypeHandle.GetMemberCache): New.
15567 (TypeHandle.TypeHandle): Update.
15568 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15569 (TypeManager.LookupParentInterfacesCache):
15570 Rename from LookupInterfaceCache. Optimize slightly.
15571 (TypeManager.MemberLookup_FindMembers): Update.
15572 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15573 multi-type variant.
15574 (AddCacheContents): Rename from AddHashtable.
15575 * class.cs (TypeContainer.parent_container): Remove.
15576 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15577 (TypeContainer.DoDefineMembers): Don't initialize it.
15578 Update to name changes.
15580 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15582 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15583 that factors the code to check access modifiers on override.
15585 (PropertyBase): Use the code here.
15587 Patch from Lluis S'anchez, fixes bug #69361.
15589 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15591 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15592 routine that is used to report the use of a captured variable
15593 whose address has been taken.
15595 There are two checks: one when variables are being captured and
15596 the other check is when the address of a variable is taken.
15598 (because an anonymous methods might be resolved before *or* after
15599 the address has been taken) and
15601 * expression.cs (Conditional.DoResolve): Remove the special
15602 casing that Martin added to trueExpr and falseExpr being both
15603 NullLiteral. We get the right behavior now just by introducing
15604 the null_type into the compiler.
15606 * convert.cs (ExplicitConversion): Change the code to use
15607 null_type instead of testing `expr is NullLiteral'.
15608 (ImplicitConversionStandard): use null_type too.
15609 (ImplicitReferenceConversionExists): use null_type too.
15610 (ImplicitReferenceConversion): use null_type too.
15612 * literal.cs: The type of `NullLiteral' is now null_type instead
15614 (Resolve): Set the type here.
15616 * typemanager.cs: Introduce null_type.
15618 2004-11-17 Martin Baulig <martin@ximian.com>
15620 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
15621 direction, like FindMembers() does. Fixes #69546, testcase is in
15624 2004-11-16 Martin Baulig <martin@ximian.com>
15626 This is based on a patch from Marek Safar, see bug #69082.
15627 Fixes bugs #63705 and #67130.
15629 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
15630 method; create a MemberCache for an interface type and cache the
15633 * decl.cs (IMemberContainer.ParentContainer): Removed.
15634 (IMemberContainer.ParentCache): New property.
15635 (MemberCache.SetupCacheForInterface): Removed.
15636 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
15637 to create a cache for an interface's "parent".
15639 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
15642 2004-11-16 Martin Baulig <martin@ximian.com>
15644 Merged back from gmcs; these changes already went into gmcs a
15645 couple of weeks ago.
15648 (TypeManager.AddUserType): Removed the `ifaces' argument.
15649 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
15651 (TypeManager.AddUserInterface): Removed.
15652 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
15654 (TypeManager.GetInterfaces): Likewise.
15655 (TypeManager.GetExplicitInterfaces): Likewise.
15657 * ecore.cs (TypeExpr.GetInterfaces): Removed.
15659 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
15660 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
15662 2004-11-14 Ben Maurer <bmaurer@ximian.com>
15664 * statement.cs: Avoid adding bools to a hashtable.
15666 2004-11-07 Miguel de Icaza <miguel@ximian.com>
15668 * expression.cs (Invocation.OverloadResolve): Flag error if we are
15669 calling an unsafe method from a safe location.
15671 2004-11-06 Marek Safar <marek.safar@seznam.cz>
15674 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
15676 2004-11-06 Miguel de Icaza <miguel@ximian.com>
15678 * namespace.cs (VerifyUsing): use GetPartialName instead of
15681 2004-11-05 Miguel de Icaza <miguel@ximian.com>
15683 * statement.cs (Return.Resolve): Fix regression in typo: if
15684 `in_exc', we have to request a NeedReturnLabel, this was a typo
15685 introduced in the anonymous method check-in. Fixes #69131.
15687 * Indexers were using the ShortName when defining themselves,
15688 causing a regression in the compiler bootstrap when applying the
15689 patch from 2004-11-02 (first part), now they use their full name
15690 and the bug is gone.
15692 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
15694 * driver.cs: Strip the path from the names of embedded resources. Fixes
15697 2004-11-04 Raja R Harinath <rharinath@novell.com>
15699 Fix error message regression: cs0104-2.cs.
15700 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
15701 (AliasEntry.Resolve): Update.
15702 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
15704 (RootContext.LookupType): Update.
15706 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
15708 * cs-parser.jay: Add support for handling accessor modifiers
15709 * class: Add support port accessor modifiers and error checking,
15710 define PropertyMethod.Define as virtual (not abstract anymore)
15711 * ecore.cs: Add checking for proeprties access with access modifiers
15712 * iterators.cs: Modify Accessor constructor call based in the modified
15714 2004-11-02 Ben Maurer <bmaurer@ximian.com>
15716 * expression.cs (StringConcat): Handle being called twice,
15717 as when we have a concat in a field init with more than two
15720 2004-11-02 Miguel de Icaza <miguel@ximian.com>
15722 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
15723 special case explicit implementations, we should always produce
15724 the .property or .event declaration.
15726 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
15727 since it will not return correct data if people use this
15728 unresolved in the presence of using statements (see test-313).
15730 * class.cs (MethodData.Define): If we are an explicit interface
15731 implementation, set the method name to the full name of the
15732 interface plus the name of the method.
15734 Notice that using the method.MethodName.GetFullName() does not
15735 work, as it will only contain the name as declared on the source
15736 file (it can be a shorthand in the presence of using statements)
15737 and not the fully qualifed type name, for example:
15741 class D : ICloneable {
15742 object ICloneable.Clone () {
15746 Would produce a method called `ICloneable.Clone' instead of
15747 `System.ICloneable.Clone'.
15749 * namespace.cs (Alias.Resolve): Use GetPartialName.
15751 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15753 * cs-parser.jay: Add error 1055 report.
15755 2004-11-01 Miguel de Icaza <miguel@ximian.com>
15757 * assign.cs (Assign.DoResolve): Only do the transform of
15758 assignment into a New if the types are compatible, if not, fall
15759 through and let the implicit code deal with the errors and with
15760 the necessary conversions.
15762 2004-11-01 Marek Safar <marek.safar@seznam.cz>
15764 * cs-parser.jay: Add error 1031 report.
15766 * cs-tokenizer.cs: Add location for error 1038.
15768 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15770 * cs-parser.jay: Add error 1016 report.
15772 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15774 * cs-parser.jay: Add errors 1575,1611 report.
15776 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15778 * cs-parser.jay: Add error 1001 report.
15780 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15783 * attribute.cs (GetMarshal): Add method argument for
15784 caller identification.
15786 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
15787 agument for GetMarshal and RuntimeMissingSupport.
15789 2004-10-31 Marek Safar <marek.safar@seznam.cz>
15791 * attribute.cs (ExtractSecurityPermissionSet): Removed
15792 TypeManager.code_access_permission_type.
15794 * typemanager.cs: Removed TypeManager.code_access_permission_type.
15796 2004-10-27 Miguel de Icaza <miguel@ximian.com>
15798 * expression.cs (LocalVariableReference.DoResolveLValue): Check
15799 for obsolete use of a variable here. Fixes regression on errors
15800 cs0619-25 and cs0619-26.
15802 2004-10-27 Marek Safar <marek.safar@seznam.cz>
15804 Fix #62358, implemented security attribute encoding.
15806 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
15807 Tests permitted SecurityAction for assembly or other types.
15808 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
15809 data from SecurityPermissionAttribute to PermisionSet class.
15811 * class.cs (ApplyAttributeBuilder): Added special handling
15812 for System.Security.Permissions.SecurityAttribute based types.
15814 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
15815 special handling for System.Security.Permissions.SecurityAttribute
15818 * enum.cs (ApplyAttributeBuilder): Added special handling
15819 for System.Security.Permissions.SecurityAttribute based types.
15821 * parameter.cs (ApplyAttributeBuilder): Added special handling
15822 for System.Security.Permissions.SecurityAttribute based types.
15824 * rootcontext.cs: Next 2 core types.
15826 * typemanager.cs (TypeManager.security_permission_attr_type):
15827 Built in type for the SecurityPermission Attribute.
15828 (code_access_permission_type): Build in type.
15830 2004-10-17 Miguel de Icaza <miguel@ximian.com>
15832 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
15833 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
15834 all of this information into
15835 EmitContext.EmitCapturedVariableInstance.
15837 * codegen.cs (EmitCapturedVariableInstance): move here the
15838 funcionality of emitting an ldarg.0 in the presence of a
15839 remapping. This centralizes the instance emit code.
15841 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
15842 then emit a load of this: it means that we have reached the
15843 topmost ScopeInfo: the one that contains the pointer to the
15844 instance of the class hosting the anonymous method.
15846 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
15847 captures to the topmost CaptureContext.
15849 2004-10-12 Miguel de Icaza <miguel@ximian.com>
15851 * expression.cs (LocalVariableReference): Move the knowledge about
15852 the iterators into codegen's EmitCapturedVariableInstance.
15854 2004-10-11 Miguel de Icaza <miguel@ximian.com>
15856 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
15857 all code paths return a value from an anonymous method (it is the
15858 same as the 161 error, but for anonymous methods).
15860 2004-10-08 Miguel de Icaza <miguel@ximian.com>
15862 The introduction of anonymous methods in the compiler changed
15863 various ways of doing things in the compiler. The most
15864 significant one is the hard split between the resolution phase
15865 and the emission phases of the compiler.
15867 For instance, routines that referenced local variables no
15868 longer can safely create temporary variables during the
15869 resolution phase: they must do so from the emission phase,
15870 since the variable might have been "captured", hence access to
15871 it can not be done with the local-variable operations from the runtime.
15875 (Block.Flags): New flag `IsTopLevel' to indicate that this block
15876 is a toplevel block.
15878 (ToplevelBlock): A new kind of Block, these are the blocks that
15879 are created by the parser for all toplevel method bodies. These
15880 include methods, accessors and anonymous methods.
15882 These contain some extra information not found in regular blocks:
15883 A pointer to an optional CaptureContext (for tracking captured
15884 local variables and parameters). A pointer to the parent
15887 (Return.Resolve): Catch missmatches when returning a value from an
15888 anonymous method (error 1662).
15889 Invoke NeedReturnLabel from the Resolve phase instead of the emit
15892 (Break.Resolve): ditto.
15894 (SwitchLabel): instead of defining the labels during the
15895 resolution phase, we now turned the public ILLabel and ILLabelCode
15896 labels into methods called GetILLabelCode() and GetILLabel() that
15897 only define the label during the Emit phase.
15899 (GotoCase): Track the SwitchLabel instead of the computed label
15900 (its contained therein). Emit the code by using
15901 SwitchLabel.GetILLabelCode ().
15903 (LocalInfo.Flags.Captured): A new flag has been introduce to track
15904 whether the Local has been captured or not.
15906 (LocalInfo.IsCaptured): New property, used to tell whether the
15907 local has been captured.
15909 * anonymous.cs: Vastly updated to contain the anonymous method
15912 The main classes here are: CaptureContext which tracks any
15913 captured information for a toplevel block and ScopeInfo used to
15914 track the activation frames for various local variables.
15916 Each toplevel block has an optional capture context associated
15917 with it. When a method contains an anonymous method both the
15918 toplevel method and the anonymous method will create a capture
15919 context. When variables or parameters are captured, they are
15920 recorded on the CaptureContext that owns them, for example:
15924 MyDelegate d = delegate {
15929 Here `a' will be recorded as captured on the toplevel
15930 CapturedContext, the inner captured context will not have anything
15931 (it will only have data if local variables or parameters from it
15932 are captured in a nested anonymous method.
15934 The ScopeInfo is used to track the activation frames for local
15935 variables, for example:
15937 for (int i = 0; i < 10; i++)
15938 for (int j = 0; j < 10; j++){
15939 MyDelegate d = delegate {
15944 At runtime this captures a single captured variable `i', but it
15945 captures 10 different versions of the variable `j'. The variable
15946 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
15947 recorded on a child.
15949 The toplevel ScopeInfo will also track information like the `this'
15950 pointer if instance variables were referenced (this is necessary
15951 as the anonymous method lives inside a nested class in the host
15952 type of the method).
15954 (AnonymousMethod): Expanded to track the Toplevel, implement
15955 `AnonymousMethod.Compatible' to tell whether an anonymous method
15956 can be converted to a target delegate type.
15958 The routine now also produces the anonymous method content
15960 (AnonymousDelegate): A helper class that derives from
15961 DelegateCreation, this is used to generate the code necessary to
15962 produce the delegate for the anonymous method that was created.
15964 * assign.cs: API adjustments for new changes in
15965 Convert.ImplicitStandardConversionExists.
15967 * class.cs: Adjustments to cope with the fact that now toplevel
15968 blocks are of type `ToplevelBlock'.
15970 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
15971 insteda of standard blocks.
15973 Flag errors if params arguments are passed to anonymous methods.
15975 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
15976 `CurrentAnonymousMethod' which points to the current Anonymous
15977 Method. The variable points to the AnonymousMethod class that
15978 holds the code being compiled. It is set in the new EmitContext
15979 created for the anonymous method.
15981 (EmitContext.Phase): Introduce a variable and an enumeration to
15982 assist in enforcing some rules about when and where we are allowed
15983 to invoke certain methods (EmitContext.NeedsReturnLabel is the
15984 only one that enfonces this right now).
15986 (EmitContext.HaveCaptureInfo): new helper method that returns
15987 whether we have a CapturedContext initialized.
15989 (EmitContext.CaptureVariable): New method used to register that a
15990 LocalInfo must be flagged for capturing.
15992 (EmitContext.CapturedParameter): New method used to register that a
15993 parameters must be flagged for capturing.
15995 (EmitContext.CapturedField): New method used to register that a
15996 field must be flagged for capturing.
15998 (EmitContext.HaveCapturedVariables,
15999 EmitContext.HaveCapturedFields): Return whether there are captured
16000 variables or fields.
16002 (EmitContext.EmitMethodHostInstance): This is used to emit the
16003 instance for the anonymous method. The instance might be null
16004 (static methods), this (for anonymous methods that capture nothing
16005 and happen to live side-by-side with the current method body) or a
16006 more complicated expression if the method has a CaptureContext.
16008 (EmitContext.EmitTopBlock): Routine that drives the emission of
16009 code: it will first resolve the top block, then emit any metadata
16010 and then emit the code. The split is done so that we can extract
16011 any anonymous methods and flag any captured variables/parameters.
16013 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16014 during this phase, the ILGenerator should not be used as labels
16015 and local variables declared here might not be accessible to any
16016 code that is part of an anonymous method.
16018 Exceptions to this include the temporary variables that are
16019 created by some statements internally for holding temporary
16022 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16025 (EmitContext.TemporaryReturn): This method is typically called
16026 from the Emit phase, and its the only place where we allow the
16027 ReturnLabel to be defined other than the EmitMeta. The reason is
16028 that otherwise we would have to duplicate a lot of logic in the
16029 Resolve phases of various methods that today is on the Emit
16032 (EmitContext.NeedReturnLabel): This no longer creates the label,
16033 as the ILGenerator is not valid during the resolve phase.
16035 (EmitContext.EmitThis): Extended the knowledge in this class to
16036 work in anonymous methods in addition to iterators.
16038 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16039 code is necessary on the stack to access the instance to a local
16040 variable (the variable will be accessed as a field).
16042 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16043 EmitContext.EmitAddressOfParameter): Routines to support
16044 parameters (not completed at this point).
16046 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16047 will also remove the parameters.
16049 * convert.cs (Convert): Define a `ConstantEC' which points to a
16050 null. This is just to prefity some code that uses
16051 ImplicitStandardConversion code and do not have an EmitContext
16054 The idea is to flag explicitly that at that point in time, it is
16055 known that the conversion will not trigger the delegate checking
16056 code in implicit conversions (which requires a valid
16059 Everywhere: pass new EmitContext parameter since
16060 ImplicitStandardConversionExists now requires it to check for
16061 anonymous method conversions.
16063 (Convert.ImplicitStandardConversionExists): If the type of an
16064 expression is the anonymous_method_type, and the type is a
16065 delegate, we invoke the AnonymousMethod.Compatible method to check
16066 whether an implicit conversion is possible.
16068 (Convert.ImplicitConversionStandard): Only do implicit method
16069 group conversions if the language level is not ISO_1.
16071 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16072 MethodInfo for the Invoke method. used by Delegate and
16075 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16076 method conversions if the target type is a delegate.
16078 Removed extra debugging nops.
16080 (LocalVariableReference): Turn the `local_info' into a public
16083 Add `prepared' field, the same hack used for FieldExprs to cope
16084 with composed assignments, as Local variables do not necessarily
16085 operate purely on the stack as they used to: they can be captured
16088 Add `temp' for a temporary result, like fields.
16090 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16092 It now copes with Local variables that are captured and emits the
16093 proper instance variable to load it from a field in the captured
16096 (ParameterReference.DoResolveBase): During the resolve phase,
16097 capture parameters if we are in an anonymous method.
16099 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16100 anonymous method, use the EmitContext helper routines to emit the
16101 parameter reference.
16103 * iterators.cs: Set RemapToProxy to true/false during the
16106 * parameters.cs (GetParameterByName): New helper method.
16108 * typemanager.cs (anonymous_method_type) a new type that
16109 represents an anonyous method. This is always an internal type,
16110 used as a fencepost to test against the anonymous-methodness of an
16113 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16115 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16117 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16119 2004-10-18 Martin Baulig <martin@ximian.com>
16121 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16122 `Type' directly, but call ResolveType() on it.
16123 (Catch.Resolve): Likewise.
16124 (Foreach.Resolve): Likewise.
16126 2004-10-18 Martin Baulig <martin@ximian.com>
16128 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16129 `Type' directly, but call ResolveType() on it.
16130 (Probe.DoResolve): Likewise.
16131 (ArrayCreation.LookupType): Likewise.
16132 (TypeOf.DoResolve): Likewise.
16133 (SizeOf.DoResolve): Likewise.
16135 2004-10-18 Martin Baulig <martin@ximian.com>
16137 * expression.cs (Invocation.BetterFunction): Put back
16138 TypeManager.TypeToCoreType().
16140 2004-10-18 Raja R Harinath <rharinath@novell.com>
16142 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16145 2004-10-18 Martin Baulig <martin@ximian.com>
16147 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16148 `Type' directly, but call ResolveType() on it.
16150 2004-10-18 Martin Baulig <martin@ximian.com>
16152 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16153 `Type' directly, but call ResolveType() on it.
16154 (MemberBase.DoDefine): Likewise.
16156 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16157 `Type' directly, but call ResolveType() on it.
16158 (ComposedCast.DoResolveAsTypeStep): Likewise.
16160 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16161 `Type' directly, but call ResolveType() on it.
16163 2004-10-17 John Luke <john.luke@gmail.com>
16165 * class.cs (Operator.GetSignatureForError): use CSharpName
16167 * parameter.cs (Parameter.GetSignatureForError): Returns
16168 correct name even if was not defined.
16170 2004-10-13 Raja R Harinath <rharinath@novell.com>
16173 * class.cs (TypeContainer.EmitContext): New property.
16174 (DefineNestedTypes): Create an emitcontext for each part.
16175 (MethodCore.DoDefineParameters): Use container's emitcontext.
16176 Pass type array to InternalParameters.
16177 (MemberBase.DoDefine): Use container's emitcontext.
16178 (FieldMember.Define): Likewise.
16179 (Event.Define): Likewise.
16180 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16181 Pass type array to InternalParameters.
16182 (SetIndexerMethod.GetParameterInfo): Likewise.
16183 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16184 * delegate.cs (Define): Pass emitcontext to
16185 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16186 array to InternalParameters.
16187 * expression.cs (ParameterReference.DoResolveBase): Pass
16188 emitcontext to GetParameterInfo.
16189 (ComposedCast.DoResolveAsTypeStep): Remove check on
16190 ec.ResolvingTypeTree.
16191 * parameter.cs (Parameter.Resolve): Change argument to
16192 EmitContext. Use ResolveAsTypeTerminal.
16193 (Parameter.GetSignature): Change argument to EmitContext.
16194 (Parameters.ComputeSignature): Likewise.
16195 (Parameters.ComputeParameterTypes): Likewise.
16196 (Parameters.GetParameterInfo): Likewise.
16197 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16198 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16199 * support.cs (InternalParameters..ctor): Remove variant that takes
16201 * typemanager.cs (system_intptr_expr): New.
16202 (InitExpressionTypes): Initialize it.
16204 2004-10-12 Chris Toshok <toshok@ximian.com>
16206 * cs-parser.jay: fix location for try_statement and catch_clause.
16208 2004-10-11 Martin Baulig <martin@ximian.com>
16210 * report.cs: Don't make --fatal abort on warnings, we have
16211 -warnaserror for that.
16213 2004-10-07 Raja R Harinath <rharinath@novell.com>
16215 More DeclSpace.ResolveType avoidance.
16216 * decl.cs (MemberCore.InUnsafe): New property.
16217 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16218 with newly created EmitContext.
16219 (FieldMember.Define): Likewise.
16220 * delegate.cs (Delegate.Define): Likewise.
16221 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16222 only if normal name-lookup fails.
16223 (TypeExpr.DoResolve): Enable error-checking.
16224 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16225 (SizeOf.DoResolve): Likewise.
16226 (ComposedCast.DoResolveAsTypeStep): Likewise.
16227 (StackAlloc.DoResolve): Likewise.
16228 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16229 (Block.Unsafe): New property.
16230 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16231 (Unsafe): Set 'unsafe' flag of contained block.
16232 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16233 (Fixed.Resolve): Likewise.
16234 (Catch.Resolve): Likewise.
16235 (Using.ResolveLocalVariableDecls): Likewise.
16236 (Foreach.Resolve): Likewise.
16238 2004-10-05 John Luke <john.luke@gmail.com>
16240 * cs-parser.jay: add location to error CS0175
16242 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16244 * ecore.cs (Expression.Constantity): Add support for turning null
16247 * const.cs (Const.Define): Allow constants to be reference types
16248 as long as the value is Null.
16250 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16252 * namespace.cs (NamespaceEntry.Using): No matter which warning
16253 level is set, check if this namespace name has already been added.
16255 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16257 * expression.cs: reftype [!=]= null should always use br[true,false].
16260 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16263 * attribute.cs: Enum conversion moved to
16264 GetAttributeArgumentExpression to be applied to the all
16267 2004-10-01 Raja R Harinath <rharinath@novell.com>
16269 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16270 * class.c (TypeContainer.DefineType): Flag error if
16271 base types aren't accessible due to access permissions.
16272 * decl.cs (DeclSpace.ResolveType): Move logic to
16273 Expression.ResolveAsTypeTerminal.
16274 (DeclSpace.ResolveTypeExpr): Thin layer over
16275 Expression.ResolveAsTypeTerminal.
16276 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16277 Refactor code into NestedAccess. Use it.
16278 (DeclSpace.NestedAccess): New.
16279 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16280 argument to silence errors. Check access permissions.
16281 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16282 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16283 (Cast.DoResolve): Likewise.
16284 (New.DoResolve): Likewise.
16285 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16286 (TypeOf.DoResolve): Likewise.
16288 * expression.cs (Invocation.BetterConversion): Return the Type of
16289 the better conversion. Implement section 14.4.2.3 more faithfully.
16290 (Invocation.BetterFunction): Make boolean. Make correspondence to
16291 section 14.4.2.2 explicit.
16292 (Invocation.OverloadResolve): Update.
16293 (Invocation): Remove is_base field.
16294 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16295 (Invocation.Emit): Likewise.
16297 2004-09-27 Raja R Harinath <rharinath@novell.com>
16299 * README: Update to changes.
16301 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16303 * cs-parser.jay: Reverted 642 warning fix.
16305 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16308 * decl.cs (FindMemberWithSameName): Indexer can have more than
16311 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16313 * expression.cs (LocalVariableReference.DoResolveLValue):
16314 Do not report warning 219 for out values.
16315 (EmptyExpression.Null): New member to avoid extra allocations.
16317 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16319 * cs-parser.jay: Fix wrong warning 642 report.
16321 * cs-tokenizer.cs (CheckNextToken): New helper;
16322 Inspect next character if is same as expected.
16324 2004-09-23 Martin Baulig <martin@ximian.com>
16326 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16327 (Convert.ImplicitReferenceConversionExists): Likewise.
16329 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16331 * class.cs (Operator.Define): Add error 448 and 559 report.
16333 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16335 * class.cs (MemberBase.IsTypePermitted): New protected
16336 method for checking error CS0610.
16338 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16340 * class.cs (TypeContainer.HasExplicitLayout): New property
16341 Returns whether container has StructLayout attribute set Explicit.
16342 (FieldMember): New abstract class for consts and fields.
16343 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16344 (Field): Reuse FieldMember.
16346 * const.cs (Const): Reuse FieldMember.
16348 * rootcontext.cs: EmitConstants call moved to class.
16350 2004-09-22 Martin Baulig <martin@ximian.com>
16352 Thanks to Peter Sestoft for this bug report.
16354 * expression.cs (Conditional): If both the `trueExpr' and the
16355 `falseExpr' is a NullLiteral, return a NullLiteral.
16357 2004-09-22 Martin Baulig <martin@ximian.com>
16359 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16360 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16361 for the "get_Current" call.
16363 2004-09-22 Martin Baulig <martin@ximian.com>
16365 Marek and me just fixed one of our oldest bugs: #28562 :-)
16367 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16369 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16370 we're an EnumConstant, just return that.
16371 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16372 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16373 to get the value which'll actually be written into the attribute.
16374 However, we have to use GetValue() to access the attribute's value
16377 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16379 * constant.cs (Constant.IsNegative): New abstract property
16382 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16383 (StackAlloc.DoResolve): Reused IsNegative.
16385 2004-09-21 Martin Baulig <martin@ximian.com>
16387 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16388 if we're used in an iterator, we may be called from different
16391 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16392 we actually have an exception block.
16394 2004-09-20 John Luke <jluke@cfl.rr.com>
16396 * class.cs, cs-parser.jay: Improve the error report for 1520:
16397 report the actual line where the error happens, not where the
16398 class was declared.
16400 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16401 Pass location information that was available elsewhere.
16403 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16405 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16406 runtime to delay sign assemblies.
16408 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16410 * cs-parser.jay: Do not report the stack trace, this is barely
16413 2004-08-22 John Luke <john.luke@gmail.com>
16415 * driver.cs : check that a resource id is not already used
16416 before adding it, report CS1508 if it is, bug #63637
16418 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16420 * ecore.cs: Removed dead code.
16422 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16424 * class.cs: Do not report warning CS0067 on the interfaces.
16426 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16428 * cs-parser.jay: Add error 504 report.
16430 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16432 * rootcontext.cs: WarningLevel is 4 by default now.
16434 * statement.cs (Fixed.Resolve): Do not null
16437 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16440 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16441 deep search when property is not virtual.
16442 (PropertyExpr.ResolveAccessors): Make one call for both
16445 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16448 * statement.cs: Error 152 report constains also location.
16450 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16453 * const.cs: Explicitly set constant as static.
16455 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16458 * cs-parser.jay: Add error 1017 report.
16460 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16462 Fixed bug #59980, #64224
16463 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16465 * typemanager.cs (IsSpecialMethod): Simplified
16467 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16469 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16470 condition with better params.
16472 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16475 * attribute.cs (Resolve): Property has to have both
16478 2004-09-14 Martin Baulig <martin@ximian.com>
16480 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16482 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16485 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16486 called and is obsolete then this member suppress message
16487 when call is inside next [Obsolete] method or type.
16489 * expression.cs: Use TestObsoleteMethodUsage member.
16491 2004-09-14 Martin Baulig <martin@ximian.com>
16493 * cs-parser.jay: Sync a bit with the GMCS version.
16495 2004-09-14 Martin Baulig <martin@ximian.com>
16497 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16498 (CSharpParser.yacc_verbose_flag): New public field.
16500 * genericparser.cs: Removed.
16502 2004-09-14 Raja R Harinath <rharinath@novell.com>
16504 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16506 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16508 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16510 2004-09-10 Martin Baulig <martin@ximian.com>
16512 Backported my MemberName changes from GMCS into MCS.
16514 - we are now using a special `MemberName' class instead of using
16515 strings; in GMCS, the `MemberName' also contains the type
16518 - changed the grammar rules a bit:
16519 * the old `member_name' is now a `namespace_or_type_name':
16520 The rule is that we use `namespace_or_type_name' everywhere
16521 where we expect either a "member name" (GetEnumerator) or a
16522 "member name" with an explicit interface name
16523 (IEnumerable.GetEnumerator).
16524 In GMCS, the explicit interface name may include type arguments
16525 (IEnumerable<T>.GetEnumerator).
16526 * we use `member_name' instead of just `IDENTIFIER' for
16528 The rule is that we use `member_name' wherever a member may
16529 have type parameters in GMCS.
16531 * decl.cs (MemberName): New public class.
16532 (MemberCore.MemberName): New public readonly field.
16533 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16534 (DeclSpace): Likewise.
16536 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16537 * enum.cs (Enum.ctor): Likewise.
16539 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16541 (AliasEntry.ctor): Take a MemberName, not an Expression.
16542 (AliasEntry.UsingAlias): Likewise.
16544 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16545 (IMethodData.MemberName): Changed type from string to MemberName.
16546 (MemberBase.ExplicitInterfaceName): Likewise.
16547 (AbstractPropertyEventMethod.SetupName): Make this private.
16548 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16549 argument; compute the member name here.
16550 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16551 on the `member.MemberName' and the `prefix'.
16553 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16555 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16556 thus, we get a `MemberName' instead of a `string'. These
16557 declarations may have type parameters in GMCS.
16558 (interface_method_declaration, delegate_declaration): Likewise.
16559 (class_declaration, interface_declaration): Likewise.
16560 (method_header): Use `namespace_or_type_name' instead of
16561 `member_name'. We may be an explicit interface implementation.
16562 (property_declaration, event_declaration): Likewise.
16563 (member_name): This is now just an `IDENTIFIER', not a
16564 `namespace_or_type_name'.
16565 (type_name, interface_type): Removed.
16566 (namespace_or_type_name): Return a MemberName, not an Expression.
16567 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16568 call GetTypeExpression() on the MemberName to get an expression.
16569 (IndexerDeclaration.interface_type): Changed type from string to
16571 (MakeName): Operate on MemberName's instead of string's.
16573 2004-09-13 Raja R Harinath <rharinath@novell.com>
16576 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16577 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16578 lookup to avoid symbols introduced by 'using'.
16579 * rootcontext.cs (NamespaceLookup): Update.
16581 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16583 * class.cs (TypeContainer.DoDefineMembers): Do not call
16584 DefineDefaultConstructor for static classes.
16586 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16588 * attribute.cs (Attribute.Resolve): Add error 653 report.
16590 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16592 (Method.ApplyAttributeBuilder): Add error 685 report.
16593 (Operator.Define): Add error 564 report.
16595 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16597 * expression.cs (Invocation.DoResolve): Add error
16598 245 and 250 report.
16600 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
16603 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16605 * class.cs (ConstructorInitializer.Resolve):
16606 Wrong error number (515->516).
16608 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16610 * class.cs (Indexer.Define): Add error 631 report.
16612 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16614 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
16616 2004-09-11 Marek Safar <marek.safar@seznam.cz>
16618 * expression.cs (Probe.DoResolve): Add error CS0241 report.
16620 2004-09-10 Marek Safar <marek.safar@seznam.cz>
16622 * cs-parser.jay: Added error CS0241 report.
16624 2004-09-10 Raja R Harinath <rharinath@novell.com>
16626 * cs-parser.jay (fixed_statement): Introduce a scope for the
16627 declaration in the 'fixed' statement.
16629 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16631 * cs-parser.jay: Added CS0230 error report.
16633 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16635 * cs-parser.jay: Added errors CS0231 and CS0257 report.
16637 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16639 * expression.cs (Argument.Resolve): Added error CS0192 and
16642 2004-09-09 Marek Safar <marek.safar@seznam.cz>
16644 C# 2.0 #pragma warning feature
16646 * cs-tokenizer.cs (PreProcessPragma): New method;
16647 Handles #pragma directive.
16649 * report.cs (WarningRegions): New class; Support
16650 class for #pragma warning directive. It tests whether
16651 warning is enabled for a given line.
16653 2004-09-08 Miguel de Icaza <miguel@ximian.com>
16655 * const.cs: Add more descriptive error report, tahnks to
16658 2004-09-08 Marek Safar <marek.safar@seznam.cz>
16660 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
16662 2004-09-07 Miguel de Icaza <miguel@ximian.com>
16664 * expression.cs: Apply patch from Ben: Remove dead code from
16665 ArrayCreation, and remove the TurnintoConstant call in const.cs,
16666 as that code just threw an exception anwyays.
16668 * const.cs: Remove the call to the turnintoconstant, for details
16671 * literal.cs: The type of the null-literal is the null type; So
16672 we use a placeholder type (literal.cs:System.Null, defined here)
16675 * expression.cs (Conditional.DoResolve): Remove some old code that
16676 is no longer needed, conversions have been fixed.
16678 (ArrayCreationExpression.DoResolve): Return false if we fail to
16679 resolve the inner expression.
16681 2004-09-07 Raja R Harinath <rharinath@novell.com>
16684 * cs-parser.jay (delegate_declaration): Record a delegate
16685 declaration as a type declaration.
16686 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
16688 2004-09-06 Miguel de Icaza <miguel@ximian.com>
16690 * parameter.cs: Do not crash if the type can not be resolved.
16692 * expression.cs: Report errors with unsafe pointers, fixes #64896
16694 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
16696 * expression.cs: Pointer arith always needs to do a conv.i
16697 if the operand is a long. fix 65320
16699 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16701 Fixed cs0619-37.cs, cs0619-38.cs
16703 * enum.cs (GetObsoleteAttribute): Removed.
16705 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
16706 on Enum member is double staged. The first is tested member
16709 2004-09-04 Marek Safar <marek.safar@seznam.cz>
16711 Fixed #56986, #63631, #65231
16713 * class.cs: (TypeContainer.AddToMemberContainer): New method,
16714 adds member to name container.
16715 (TypeContainer.AddToTypeContainer): New method, adds type to
16717 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
16718 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
16719 AddOperator): Simplified by reusing AddToMemberContainer.
16720 (TypeContainer.UserDefinedStaticConstructor): Changed to property
16722 (Method.CheckForDuplications): Fixed implementation to test all
16724 (MemberBase): Detection whether member is explicit interface
16725 implementation is now in constructor.
16726 (MemberBase.UpdateMemberName): Handles IndexerName.
16727 (Accessor): Changed to keep also location information.
16728 (AbstractPropertyEventMethod): Is derived from MemberCore.
16729 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
16730 will be emited or not.
16731 (PropertyBase.AreAccessorsDuplicateImplementation):
16732 Tests whether accessors are not in collision with some method.
16733 (Operator): Is derived from MethodCore to simplify common
16736 * decl.cs (Flags.TestMethodDuplication): Test for duplication
16738 (DeclSpace.AddToContainer): Adds the member to defined_names
16739 table. It tests for duplications and enclosing name conflicts.
16741 * enum.cs (EnumMember): Clean up to reuse the base structures
16743 2004-09-03 Martin Baulig <martin@ximian.com>
16745 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
16746 into TypeContainer, to make partial classes work again.
16748 2004-09-03 Martin Baulig <martin@ximian.com>
16750 * rootcontext.cs (RootContext.V2): Removed.
16752 2004-03-23 Martin Baulig <martin@ximian.com>
16754 * expression.cs (Invocation.OverloadResolve): Added `bool
16755 may_fail' argument and use it instead of the Location.IsNull() hack.
16757 2004-09-03 Martin Baulig <martin@ximian.com>
16759 Merged latest changes into gmcs. Please keep this comment in
16760 here, it makes it easier for me to see what changed in MCS since
16761 the last time I merged.
16763 2004-09-03 Raja R Harinath <rharinath@novell.com>
16766 * expression.cs (BetterConversion): Don't allow either conversion
16767 to be null. Remove redundant implicit conversion test when 'q ==
16768 null' -- when this function is invoked, we already know that the
16769 implicit conversion exists.
16770 (BetterFunction): Assume that 'best' is non-null. Remove
16771 redundant reimplementation of IsApplicable when 'best' is null.
16772 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
16773 number of arguments.
16774 (IsAncestralType): Extract from OverloadResolve.
16775 (OverloadResolve): Make robust to the MethodGroupExpr being
16776 unsorted. Implement all the logic of Section 14.5.5.1, and
16777 support overloading of methods from multiple applicable types.
16778 Clean up logic somewhat. Don't pass null methods to BetterFunction.
16780 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
16781 (RealError, Warning): Append type of report to related symbol.
16783 2004-09-03 Marek Safar <marek.safar@seznam.cz>
16785 * enum.cs: Fixed CLS-Compliance checks for enum members.
16786 Error tests cs3008-8.cs, cs3014-8.cs
16788 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16790 Fixed bug #62342, #63102
16791 * class.cs: ImplementIndexer uses member.IsExplicitImpl
16792 like ImplementMethod.
16794 2004-09-02 Marek Safar <marek.safar@seznam.cz>
16796 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16799 2004-09-02 Martin Baulig <martin@ximian.com>
16801 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
16802 TypeManager.GetArgumentTypes() rather than calling GetParameters()
16805 2004-09-01 Marek Safar <marek.safar@seznam.cz>
16807 C# 2.0 Static classes implemented
16809 * class.cs (TypeContainer): instance_constructors,
16810 initialized_fields, initialized_static_fields,
16811 default_constructor, base_inteface_types are protected to be
16812 accessible from StaticClass.
16813 (TypeContainer.DefineDefaultConstructor): New virtual method
16814 for custom default constructor generating
16815 (StaticClass): New class to handle "Static classes" feature.
16817 * cs-parser.jay: Handle static keyword on class like instance
16820 * driver.cs: Added "/langversion" command line switch with two
16821 options (iso-1, default).
16823 2004-08-31 Marek Safar <marek.safar@seznam.cz>
16825 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
16827 2004-08-31 Miguel de Icaza <miguel@ximian.com>
16829 * delegate.cs: Style.
16831 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
16833 * delegate.cs: Add seperate instance expr field for miguel.
16835 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16837 * PointerArithmetic (Resolve): make sure we are not doing
16838 pointer arith on void*. Also, make sure we are resolved
16839 by not setting eclass until resolve.
16841 All callers: Make sure that PointerArithmetic gets resolved.
16843 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
16845 * ArrayCreation (LookupType): If the type does not resolve
16846 to an array, give an error.
16848 2004-08-27 Marek Safar <marek.safar@seznam.cz>
16850 * statement.cs (Try.Resolve): Fixed bug #64222
16852 2004-08-27 Martin Baulig <martin@ximian.com>
16855 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
16858 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16860 * ecore.cs (Constantify): Get underlying type via
16861 System.Enum.GetUnderlyingType to avoid StackOverflow on the
16862 Windows in special cases.
16864 2004-08-26 Marek Safar <marek.safar@seznam.cz>
16866 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
16867 for obtaining also private methods.
16868 (GetRemoveMethod): Used GetRemoveMethod (true)
16869 for obtaining also private methods.
16871 2004-08-24 Martin Baulig <martin@ximian.com>
16873 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
16874 MethodAttributes.HideBySig for operators.
16876 2004-08-23 Martin Baulig <martin@ximian.com>
16878 Back to the old error reporting system :-)
16880 * report.cs (Message): Removed.
16881 (Report.MessageData, ErrorData, WarningData): Removed.
16882 (Report.Error, Warning): Back to the old system.
16884 2004-08-23 Martin Baulig <martin@ximian.com>
16886 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
16888 * class.cs (TypeContainer.ParentContainer): New public virtual
16889 method; replaces the explicit interface implementation.
16890 (ClassPart.ParentContainer): Override.
16892 2004-08-23 Martin Baulig <martin@ximian.com>
16894 * statement.cs (Switch): Added support for constant switches; see
16895 #59428 or test-285.cs.
16897 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16900 * statement.cs (GetEnumeratorFilter): Removed useless
16901 logic because C# specs is strict. GetEnumerator must be
16904 2004-08-22 Martin Baulig <martin@ximian.com>
16906 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
16907 a switch and may break, reset the barrier. Fixes #59867.
16909 2004-08-22 Marek Safar <marek.safar@seznam.cz>
16911 CLS-Compliance speed up (~5% for corlib)
16913 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
16914 New method. Tests container for CLS-Compliant names
16916 * class.cs (TypeContainer.VerifyClsName): New method.
16917 Checks whether container name is CLS Compliant.
16918 (Constructor): Implements IMethodData.
16920 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
16921 low-case table for CLS Compliance test.
16922 (MemberCache.VerifyClsParameterConflict): New method.
16923 Checks method parameters for CS3006 error.
16925 * enum.cs (EnumMember): Is derived from MemberCore.
16926 (Enum.VerifyClsName): Optimized for better performance.
16928 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16930 * report.cs: Renamed Error_T to Error and changed all
16933 2004-08-06 Marek Safar <marek.safar@seznam.cz>
16935 * class.cs (TypeContainer.IndexerArrayList): New inner class
16936 container for indexers.
16937 (TypeContainer.DefaultIndexerName): New constant for default
16938 indexer name. Replaced all "Item" with this constant.
16939 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
16941 * typemanager.cs (TypeManager.default_member_ctor): Cache here
16942 DefaultMemberAttribute constructor.
16944 2004-08-05 Martin Baulig <martin@ximian.com>
16946 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
16949 2004-08-05 Marek Safar <marek.safar@seznam.cz>
16951 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
16952 multi platforms problem.
16954 * compiler.csproj: Included shared files.
16956 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16958 Fix bug 60333, 55971 in the more general way
16959 * attribute.cs (Attribute.GetAttributeArgumentExpression):
16960 Added arg_type argument for constant conversion.
16961 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
16963 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16966 * class.cs (TypeContainer ): New inner classes MethodArrayList,
16967 OperatorArrayList, MethodCoreArrayList for typecontainer
16968 containers. Changed class member types to these new types.
16969 (MethodArrayList.DefineMembers): Added test for CS0659.
16971 2004-08-04 Miguel de Icaza <miguel@ximian.com>
16973 * cfold.cs: Synchronize the folding with the code in expression.cs
16974 Binary.DoNumericPromotions for uint operands.
16976 * attribute.cs: Revert patch from Raja, it introduced a regression
16977 while building Blam-1.2.1 (hard to isolate a test case).
16979 2004-08-04 Marek Safar <marek.safar@seznam.cz>
16983 (TypeContainer.Define): Renamed to DefineContainerMembers because of
16985 (MethodCore.parent_method): New member. The method we're overriding
16986 if this is an override method.
16987 (MethodCore.CheckBase): Moved from Method class and made common.
16988 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
16990 (MethodCore.CheckForDuplications): New abstract method. For custom
16991 member duplication search in a container
16992 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
16993 method and its return type.
16994 (Event.conflict_symbol): New member. Symbol with same name in the
16998 (MemberCache.FindMemberWithSameName): New method. The method
16999 is looking for conflict with inherited symbols.
17001 2004-08-04 Martin Baulig <martin@ximian.com>
17003 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17005 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17007 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17009 * report.cs (Message): New enum for better error, warning reference in
17011 (MessageData): New inner abstract class. It generally handles printing of
17012 error and warning messages.
17013 Removed unused Error, Warning, Message methods.
17015 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17017 Fix for cs0592-8.cs test
17019 (Attributable.ValidAttributeTargets): Made public.
17020 (Attribute.ExplicitTarget): New member for explicit target value.
17021 (Attribute.CheckTargets): Now we translate explicit attribute
17022 target to Target here.
17024 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17026 * ecore.cs (MethodGroupExpr): new IsBase property.
17028 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17030 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17031 rather than an instance expr.
17033 (DelegateCreation.Emit): Use the method group rather than
17034 the instance expression. Also, if you have base.Foo as the
17035 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17037 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17039 (NewDelegate.DoResolve): Only check for the existance of Invoke
17040 if the method is going to be needed. Use MethodGroupExpr.
17042 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17044 * expression.cs: For pointer arith., make sure to use
17045 the size of the type, not the size of the pointer to
17048 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17051 * class.cs (Class): Added error CS0502 test.
17053 2004-08-03 John Luke <jluke@cfl.rr.com>
17054 Raja R Harinath <rharinath@novell.com>
17057 * attribute.cs (Attribute.complained_before): New flag.
17058 (Attribute.ResolveType, Attribute.Resolve),
17059 (Attribute.DefinePInvokeMethod): Set it.
17060 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17062 2004-08-03 Martin Baulig <martin@ximian.com>
17064 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17065 use a user-defined operator; we still need to do numeric
17066 promotions in case one argument is a builtin type and the other
17067 one has an implicit conversion to that type. Fixes #62322.
17069 2004-08-02 Martin Baulig <martin@ximian.com>
17071 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17072 (LocalInfo.IsThis): New public property.
17073 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17075 2004-08-01 Martin Baulig <martin@ximian.com>
17077 * class.cs (TypeContainer.GetClassBases): Don't set the default
17078 here since we may get called from GetPartialBases().
17079 (TypeContainer.DefineType): If GetClassBases() didn't return a
17080 parent, use the default one.
17082 2004-07-30 Duncan Mak <duncan@ximian.com>
17084 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17086 2004-07-30 Martin Baulig <martin@ximian.com>
17088 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17090 * class.cs (SourceMethod): New public class, derive from the
17091 symbol writer's ISourceMethod.
17092 (Method): Use the new symbol writer API.
17094 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17095 as argument and use the new symbol writer.
17098 (SourceFile): Implement the symbol writer's ISourceFile.
17099 (Location.SymbolDocument): Removed.
17100 (Location.SourceFile): New public property.
17102 * symbolwriter.cs: Use the new symbol writer API.
17104 2004-07-30 Raja R Harinath <rharinath@novell.com>
17106 * Makefile (install-local): Remove. Functionality moved to
17109 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17111 * Makefile: Install mcs.exe.config file together with mcs.exe.
17112 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17113 correct runtime version.
17115 2004-07-25 Martin Baulig <martin@ximian.com>
17118 (TypeContainer.RegisterOrder): Removed, this was unused.
17119 (TypeContainer, interface_order): Removed.
17120 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17121 TypeContainer as argument since we can also be called with a
17122 `PartialContainer' for a partial class/struct/interface.
17123 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17124 of checking whether we're an `Interface' - we could be a
17125 `PartialContainer'.
17126 (PartialContainer.Register): Override; call
17127 AddClass()/AddStruct()/AddInterface() on our parent.
17129 * cs-parser.jay (interface_member_declaration): Add things to the
17130 `current_container', not the `current_class'.
17132 * rootcontext.cs (RegisterOrder): The overloaded version which
17133 takes an `Interface' was unused, removed.
17135 * typemanager.cs (TypeManager.LookupInterface): Return a
17136 `TypeContainer', not an `Interface'.
17137 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17138 contain a `PartialContainer' for an interface, so check it's
17139 `Kind' to figure out what it is.
17141 2004-07-25 Martin Baulig <martin@ximian.com>
17143 * class.cs (Class.DefaultTypeAttributes): New public constant.
17144 (Struct.DefaultTypeAttributes): Likewise.
17145 (Interface.DefaultTypeAttributes): Likewise.
17146 (PartialContainer.TypeAttr): Override this and add the
17147 DefaultTypeAttributes.
17149 2004-07-25 Martin Baulig <martin@ximian.com>
17151 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17152 we can just use the `Parent' field instead.
17154 2004-07-25 Martin Baulig <martin@ximian.com>
17156 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17158 2004-07-25 Martin Baulig <martin@ximian.com>
17160 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17161 our parts before defining any methods.
17162 (TypeContainer.VerifyImplements): Make this virtual.
17163 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17164 on our PartialContainer.
17166 2004-07-25 Martin Baulig <martin@ximian.com>
17168 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17170 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17171 argument, we can just use the `Parent' field instead.
17174 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17175 (MemberBase.DoDefine): Likewise.
17177 2004-07-24 Martin Baulig <martin@ximian.com>
17179 * decl.cs (MemberCore.Parent): New public field.
17180 (DeclSpace.Parent): Moved to MemberCore.
17182 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17183 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17185 (FieldBase, Field, Operator): Likewise.
17186 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17187 (EventField, Event): Likewise.
17189 2004-07-23 Martin Baulig <martin@ximian.com>
17191 * class.cs (PartialContainer): New public class.
17192 (ClassPart): New public class.
17193 (TypeContainer): Added support for partial classes.
17194 (TypeContainer.GetClassBases): Splitted some of the functionality
17195 out into GetNormalBases() and GetPartialBases().
17197 * cs-tokenizer.cs (Token.PARTIAL): New token.
17198 (Tokenizer.consume_identifier): Added some hacks to recognize
17199 `partial', but only if it's immediately followed by `class',
17200 `struct' or `interface'.
17202 * cs-parser.jay: Added support for partial clases.
17204 2004-07-23 Martin Baulig <martin@ximian.com>
17206 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17207 a `DeclSpace' and also made it readonly.
17208 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17209 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17210 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17212 * cs-parser.jay: Pass the `current_class', not the
17213 `current_container' (at the moment, this is still the same thing)
17214 to a new Method, Property, Event, Indexer or Constructor.
17216 2004-07-23 Martin Baulig <martin@ximian.com>
17218 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17219 and removed the `current_interface' one.
17220 (struct_declaration, class_declaration, interface_declaration):
17221 Set `current_class' to the newly created class/struct/interface;
17222 set their `Bases' and call Register() before parsing their body.
17224 2004-07-23 Martin Baulig <martin@ximian.com>
17226 * class.cs (Kind): New public enum.
17227 (TypeContainer): Made this class abstract.
17228 (TypeContainer.Kind): New public readonly field.
17229 (TypeContainer.CheckDef): New public method; moved here from
17231 (TypeContainer.Register): New public abstract method.
17232 (TypeContainer.GetPendingImplementations): New public abstract
17234 (TypeContainer.GetClassBases): Removed the `is_class' and
17235 `is_iface' parameters.
17236 (TypeContainer.DefineNestedTypes): Formerly known as
17238 (ClassOrStruct): Made this class abstract.
17240 * tree.cs (RootTypes): New public type.
17242 2004-07-20 Martin Baulig <martin@ximian.com>
17244 * tree.cs (Tree.RecordNamespace): Removed.
17245 (Tree.Namespaces): Removed.
17247 * rootcontext.cs (RootContext.IsNamespace): Removed.
17249 * cs-parser.jay (namespace_declaration): Just create a new
17250 NamespaceEntry here.
17252 2004-07-20 Martin Baulig <martin@ximian.com>
17254 * statement.cs (ExceptionStatement): New abstract class. This is
17255 now used as a base class for everyone who's using `finally'.
17256 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17257 our local variables before using them.
17259 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17260 virtual method. This is used by Yield.Resolve() to "steal" an
17261 outer block's `finally' clauses.
17262 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17265 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17266 version which takes an ExceptionStatement. This version must be
17267 used to create exception branchings.
17270 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17271 (Iterator.EmitMoveNext): Added exception support; protect the
17272 block with a `fault' clause, properly handle 'finally' clauses.
17273 (Iterator.EmitDispose): Run all the `finally' clauses here.
17275 2004-07-20 Martin Baulig <martin@ximian.com>
17277 * iterator.cs: This is the first of a set of changes in the
17278 iterator code. Match the spec more closely: if we're an
17279 IEnumerable, then GetEnumerator() must be called. The first time
17280 GetEnumerator() is called, it returns the current instance; all
17281 subsequent invocations (if any) must create a copy.
17283 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17285 * expression.cs: Resolve the constant expression before returning
17288 2004-07-19 Martin Baulig <martin@ximian.com>
17290 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17291 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17292 the return type of the new EmitContext.
17294 2004-07-18 Martin Baulig <martin@ximian.com>
17296 * class.cs (Property.Define): Fix iterators.
17298 * iterators.cs (Iterator.Define): Moved the
17299 `container.AddInterator (this)' call here from the .ctor; only do
17300 it if we resolved successfully.
17302 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17304 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17305 `true' for preprocessing directives that we parse. The return
17306 value indicates whether we should return to regular tokenizing or
17307 not, not whether it was parsed successfully.
17309 In the past if we were in: #if false ... #line #endif, we would
17310 resume parsing after `#line'. See bug 61604.
17312 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17313 building: IsEnumType should return true only for enums, not for
17314 enums or System.Enum itself. This fixes #61593.
17316 Likely what happened is that corlib was wrong: mcs depended on
17317 this bug in some places. The bug got fixed, we had to add the
17318 hack, which caused bug 61593.
17320 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17321 that was a workaround for the older conditions.
17323 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17325 * assign.cs: IAssignMethod has a new interface, as documented
17326 inline. All assignment code now uses this new api.
17328 * ecore.cs, expression.cs: All classes which implement
17329 IAssignMethod now use the new interface.
17331 * expression.cs (Invocation): add a hack to EmitCall so that
17332 IndexerAccess can be the target of a compound assignment without
17333 evaluating its arguments twice.
17335 * statement.cs: Handle changes in Invocation api.
17337 2004-07-16 Martin Baulig <martin@ximian.com>
17339 * iterators.cs: Rewrote this. We're now using one single Proxy
17340 class for both the IEnumerable and the IEnumerator interface and
17341 `Iterator' derives from Class so we can use the high-level API.
17343 * class.cs (TypeContainer.AddIterator): New method.
17344 (TypeContainer.DoDefineType): New protected virtual method, which
17345 is called from DefineType().
17346 (TypeContainer.DoDefineMembers): Call DefineType() and
17347 DefineMembers() on all our iterators.
17348 (TypeContainer.Emit): Call Emit() on all our iterators.
17349 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17351 * codegen.cs (EmitContext.CurrentIterator): New public field.
17353 2004-07-15 Martin Baulig <martin@ximian.com>
17356 (TypeManager.not_supported_exception_type): New type.
17358 2004-07-14 Martin Baulig <martin@ximian.com>
17360 * iterators.cs: Use real error numbers.
17362 2004-07-14 Martin Baulig <martin@ximian.com>
17364 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17365 requires this to be a System.Collection.IEnumerable and not a
17366 class implementing that interface.
17367 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17369 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17371 * class.cs: Fixed previous fix, it broke some error tests.
17373 2004-07-12 Martin Baulig <martin@ximian.com>
17375 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17378 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17380 * assign.cs (LocalTemporary): Add new argument: is_address,If
17381 `is_address' is true, then the value that we store is the address
17382 to the real value, and not the value itself.
17384 * ecore.cs (PropertyExpr): use the new local temporary
17385 stuff to allow us to handle X.Y += z (where X is a struct)
17387 2004-07-08 Martin Baulig <martin@ximian.com>
17389 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17390 not always return, just like we're doing in Using.Resolve().
17392 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17394 * cs-parser.jay (fixed_statement): flag this as Pinned.
17396 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17398 * typemanager.cs (TypeManager): Removed MakePinned method, this
17399 mechanism is replaced with the .NET 2.x compatible mechanism of
17400 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17402 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17403 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17404 `IsFixed' property which has a different meaning.
17406 2004-07-02 Raja R Harinath <rharinath@novell.com>
17408 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17409 visible from inside a nested class, not just the names of the
17410 immediately enclosing class.
17411 Fix for bug #60730.
17413 2004-06-24 Raja R Harinath <rharinath@novell.com>
17415 * expression.cs (BetterConversion): Remove buggy special-case
17416 handling of "implicit constant expression conversions". At this
17417 point, we already know that the conversion is possible -- we're
17418 only checking to see which is better.
17420 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17422 * cs-parser.jay: Added error CS0210 test.
17424 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17426 * cs-parser.jay: Added error CS0134 test.
17428 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17431 * cs-parser.jay: Added error CS0145 test.
17433 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17435 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17437 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17439 * expression.cs (StackAlloc.Resolve): The argument may not
17440 be a constant; deal with this case.
17442 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17444 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17445 GetIndexerAttributeValue.
17446 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17448 * class.cs (Indexer.Define): Added error tests for CS0415,
17451 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17453 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17456 2004-06-23 Martin Baulig <martin@ximian.com>
17458 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17459 neither return nor throw, reset the barrier as well. Fixes #60457.
17461 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17463 * class.cs : EventAttributes is now set to None by default.
17464 This fixes bug #60459.
17466 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17469 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17470 Don't throw exception but return null (it's sufficient now).
17472 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17474 * typemanager.cs (GetArgumentTypes): Faster implementation.
17476 2004-06-18 Martin Baulig <martin@ximian.com>
17478 * attribute.cs (Attribute.Resolve): Check whether we're an
17479 EmptyCast which a Constant child. Fixes #60333.
17481 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17483 * statement.cs (EmitCollectionForeach): Account for the fact that
17484 not all valuetypes are in areas which we can take the address of.
17485 For these variables, we store to a temporary variable. Also, make
17486 sure that we dont emit a `callvirt' on a valuetype method.
17488 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17490 * expression.cs (StackAlloc.DoReSolve): Added test for
17491 negative parameter (CS0247).
17493 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17496 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17498 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17501 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17504 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17506 Fix bug #58254 & cs1555.cs, cs1556.cs
17507 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17509 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17511 * cs-parser.jay: Added error CS1669 test for indexers.
17513 2004-06-11 Martin Baulig <martin@ximian.com>
17515 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17516 call this twice: for params and varargs methods.
17518 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17521 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17523 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17525 * attribute.cs (Attribute.GetValidTargets): Made public.
17528 (AbstractPropertyEventMethod): New class for better code sharing.
17529 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17531 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17533 2004-06-11 Raja R Harinath <rharinath@novell.com>
17536 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17537 that the call to Resolve is part of a MemberAccess.
17538 (Expression.Resolve): Use it for SimpleName resolution.
17539 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17540 Add 'intermediate' boolean argument.
17541 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17542 error message when the SimpleName can be resolved ambiguously
17543 between an expression and a type.
17544 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17546 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17547 call on the left-side.
17549 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17552 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17554 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17556 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17558 2004-06-11 Martin Baulig <martin@ximian.com>
17560 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17561 varargs methods if applicable.
17563 2004-06-11 Martin Baulig <martin@ximian.com>
17565 * expression.cs (Invocation.EmitCall): Don't use
17566 `method.CallingConvention == CallingConventions.VarArgs' since the
17567 method could also have `CallingConventions.HasThis'.
17569 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17571 * class.cs (Event.GetSignatureForError): Implemented.
17572 Fixed crash in error test cs3010.cs
17574 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17576 * cs-tokenizer.cs: Change the way we track __arglist to be
17577 consistent with the other keywords.
17579 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17581 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17584 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17586 * codegen.cs: Check that all referenced assemblies have a strongname
17587 before strongnaming the compiled assembly. If not report error CS1577.
17588 Fix bug #56563. Patch by Jackson Harper.
17589 * typemanager.cs: Added a method to return all referenced assemblies.
17590 Fix bug #56563. Patch by Jackson Harper.
17592 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17595 (Method.ApplyAttributeBuilder): Moved and added conditional
17596 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
17599 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
17601 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17604 * class.cs: (EventField.attribute_targets): Changed default target.
17606 2004-06-08 Martin Baulig <martin@ximian.com>
17608 * expression.cs (Invocation.EmitCall): Enable varargs methods.
17610 2004-06-08 Martin Baulig <martin@ximian.com>
17612 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
17614 2004-06-07 Martin Baulig <martin@ximian.com>
17616 Added support for varargs methods.
17618 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
17621 * cs-parser.jay: Added support for `__arglist'.
17623 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
17625 * expression.cs (Argument.AType): Added `ArgList'.
17626 (Invocation): Added support for varargs methods.
17627 (ArglistAccess): New public class.
17628 (Arglist): New public class.
17630 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
17632 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
17633 a method's top-level block if the method has varargs.
17635 * support.cs (ReflectionParameters, InternalParameters): Added
17636 support for varargs methods.
17638 2004-06-07 Miguel de Icaza <miguel@ximian.com>
17640 * class.cs: Provide location in indexer error report.
17642 * driver.cs: Use standard names.
17644 * namespace.cs: Catch the use of using after a namespace has been
17645 declared also on using aliases.
17647 2004-06-03 Raja R Harinath <rharinath@novell.com>
17650 * typemanager.cs (closure_private_ok, closure_invocation_type)
17651 (closure_qualifier_type, closure_invocation_assembly)
17652 (FilterWithClosure): Move to ...
17653 (Closure): New internal nested class.
17654 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
17655 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
17656 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
17657 (MemberLookup, MemberLookupFailed): Use it.
17658 * expression.cs (New.DoResolve): Treat the lookup for the
17659 constructor as being qualified by the 'new'ed type.
17660 (Indexers.GetIndexersForTypeOrInterface): Update.
17662 2004-06-03 Marek Safar <marek.safar@seznam.cz>
17665 (GetConditionalAttributeValue): New method. Returns
17666 condition of ConditionalAttribute.
17667 (SearchMulti): New method. Returns all attributes of type 't'.
17668 Use it when attribute is AllowMultiple = true.
17669 (IsConditionalMethodExcluded): New method.
17672 (Method.IsExcluded): Implemented. Returns true if method has conditional
17673 attribute and the conditions is not defined (method is excluded).
17674 (IMethodData): Extended interface for ConditionalAttribute support.
17675 (PropertyMethod.IsExcluded): Implemented.
17678 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
17681 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
17684 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
17686 * expression.cs (ArrayCreationExpression): Make this just an
17687 `expression'. It can't be a statement, so the code here was
17690 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17693 * typemanager.cs (GetFullNameSignature): New method for
17696 2004-06-02 Marek Safar <marek.safar@seznam.cz>
17699 * class.cs (MemberBase.GetSignatureForError): New virtual method.
17700 Use this method when MethodBuilder is null.
17701 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
17702 Added test for error CS0626 (MONO reports error for this situation).
17703 (IMethodData.GetSignatureForError): Extended interface.
17705 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17708 (AttributeTester.GetObsoleteAttribute): Returns instance of
17709 ObsoleteAttribute when type is obsolete.
17712 (TypeContainer.VerifyObsoleteAttribute): Override.
17713 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
17714 (MethodCode.VerifyObsoleteAttribute): Override.
17715 (MemberBase.VerifyObsoleteAttribute): Override.
17718 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
17719 and report proper error.
17722 Delegate.VerifyObsoleteAttribute): Override.
17725 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
17726 and report proper error.
17727 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
17730 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
17734 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
17735 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
17736 Added test for ObsoleteAttribute.
17739 (Catch): Derived from Statement.
17741 2004-06-01 Marek Safar <marek.safar@seznam.cz>
17743 Fixed bug #59071 & cs0160.cs
17745 * statement.cs (Try.Resolve): Check here whether order of catch
17746 clauses matches their dependencies.
17748 2004-05-31 Miguel de Icaza <miguel@ximian.com>
17750 * Reverted patch to namespace.cs (Use lookuptypedirect). This
17751 caused a regression: #59343. Referencing nested classes from an
17752 assembly stopped working.
17754 2004-05-31 Martin Baulig <martin@ximian.com>
17756 MCS is now frozen for beta 2.
17758 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17760 * convert.cs: add a trivial cache for overload operator resolution.
17762 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17764 * decl.cs: If possible, use lookuptypedirect here. We can only do
17765 this if there is no `.' after the namespace. Avoids using
17766 LookupType, which does lots of slow processing.
17767 (FindNestedType) New method, does what it says :-).
17768 * namespace.cs: use LookupTypeDirect.
17769 * rootcontext.cs: use membercache, if possible.
17770 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
17772 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17775 According to the spec,
17777 In a member access of the form E.I, if E is a single identifier,
17778 and if the meaning of E as a simple-name (§7.5.2) is a constant,
17779 field, property, localvariable, or parameter with the same type as
17780 the meaning of E as a type-name (§3.8), then both possible
17781 meanings of E are permitted.
17783 We did not check that E as a simple-name had the same type as E as
17786 This trivial check gives us 5-7% on bootstrap time.
17788 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
17790 * expression.cs (Invocation.OverloadResolve): Avoid the
17791 use of hashtables and boxing here by allocating on demand.
17793 2004-05-30 Martin Baulig <martin@ximian.com>
17795 * rootcontext.cs (RootContext.LookupType): Don't cache things if
17796 we're doing a silent lookup. Don't try to lookup nested types in
17797 TypeManager.object_type (thanks to Ben Maurer).
17799 2004-05-30 Martin Baulig <martin@ximian.com>
17801 Committing a patch from Ben Maurer.
17803 * rootcontext.cs (RootContext.LookupType): Cache negative results.
17805 2004-05-29 Martin Baulig <martin@ximian.com>
17807 * class.cs (IMethodData.ShouldIgnore): New method.
17809 * typemanager.cs (TypeManager.MethodFlags): Don't take a
17810 `Location' argument, we don't need it anywhere. Use
17811 `IMethodData.ShouldIgnore ()' instead of
17812 `MethodData.GetMethodFlags ()'.
17813 (TypeManager.AddMethod): Removed.
17814 (TypeManager.AddMethod2): Renamed to AddMethod.
17816 2004-05-29 Martin Baulig <martin@ximian.com>
17818 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
17820 * convert.cs (Convert.ImplicitReferenceConversion): If we're
17821 converting from a class type S to an interface type and we already
17822 have an object on the stack, don't box it again. Fixes #52578.
17824 2004-05-29 Martin Baulig <martin@ximian.com>
17826 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17827 Added support for `params' parameters. Fixes #59267.
17829 2004-05-29 Martin Baulig <martin@ximian.com>
17831 * literal.cs (NullPointer): Provide a private .ctor which sets
17832 `type' to TypeManager.object_type. Fixes #59048.
17834 2004-05-29 Martin Baulig <martin@ximian.com>
17836 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
17837 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
17839 * ecore.cs (EventExpr.instance_expr): Make the field private.
17841 2004-05-26 Marek Safar <marek.safar@seznam.cz>
17843 Fixed bug #50080 & cs0214-2.cs
17844 * expression.cs (Cast.DoResolve): Check unsafe context here.
17846 * statement.cs (Resolve.DoResolve): Likewise.
17848 2004-05-26 Martin Baulig <martin@ximian.com>
17850 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
17852 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
17853 (RootContext.LookupType): Pass down the `silent' flag.
17855 2004-05-25 Martin Baulig <martin@ximian.com>
17858 (MethodGroupExpr.IdenticalTypeName): New public property.
17859 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
17860 expression actually refers to a type.
17862 2004-05-25 Martin Baulig <martin@ximian.com>
17864 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
17865 for #56176 and made it actually work.
17867 2004-05-25 Martin Baulig <martin@ximian.com>
17869 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
17870 (FieldExpr, PropertyExpr): Override and implement
17871 CacheTemporaries. Fixes #52279.
17873 2004-05-25 Miguel de Icaza <miguel@ximian.com>
17875 * location.cs: In the new compiler listing a file twice is a
17876 warning, not an error.
17878 2004-05-24 Martin Baulig <martin@ximian.com>
17880 * enum.cs (Enum.DefineType): For the `BaseType' to be a
17881 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
17883 2004-05-24 Martin Baulig <martin@ximian.com>
17885 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
17886 walking the `using' list. Fixes #53921.
17888 2004-05-24 Martin Baulig <martin@ximian.com>
17890 * const.cs (Const.LookupConstantValue): Added support for
17891 EmptyCast's; fixes #55251.
17893 2004-05-24 Martin Baulig <martin@ximian.com>
17895 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
17896 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
17897 which does the CS0135 check. The reason is that we first need to
17898 check whether the variable actually exists.
17900 2004-05-24 Martin Baulig <martin@ximian.com>
17902 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
17903 than RootContext.LookupType() to find the explicit interface
17904 type. Fixes #58584.
17906 2004-05-24 Raja R Harinath <rharinath@novell.com>
17908 * Makefile: Simplify. Use executable.make.
17909 * mcs.exe.sources: New file. List of sources of mcs.exe.
17911 2004-05-24 Anders Carlsson <andersca@gnome.org>
17915 Use the invariant culture when doing String.Compare for CLS case
17918 2004-05-23 Martin Baulig <martin@ximian.com>
17920 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
17921 don't have any dots. Fixes #52622, added cs0246-8.cs.
17923 * namespace.cs (NamespaceEntry.Lookup): Likewise.
17925 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17927 * class.cs (MemberBase.Define): Reuse MemberType member for
17928 resolved type. Other methods can use it too.
17930 2004-05-23 Martin Baulig <martin@ximian.com>
17932 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
17933 the variable also exists in the current block (otherwise, we need
17934 to report a CS0103). Fixes #58670.
17936 2004-05-23 Martin Baulig <martin@ximian.com>
17938 * flowanalysis.cs (Reachability.Reachable): Compute this
17939 on-the-fly rather than storing it as a field.
17941 2004-05-23 Martin Baulig <martin@ximian.com>
17943 * flowanalysis.cs (Reachability.And): Manually compute the
17944 resulting `barrier' from the reachability.
17946 2004-05-23 Marek Safar <marek.safar@seznam.cz>
17949 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
17950 instance of ObsoleteAttribute when symbol is obsolete.
17953 (IMethodData): Extended interface for ObsoleteAttribute support.
17955 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17957 * attribute.cs: Fix bug #55970
17959 2004-05-22 Marek Safar <marek.safar@seznam.cz>
17963 (GetObsoleteAttribute): New method. Creates the instance of
17965 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
17966 ObsoleteAttribute when member is obsolete.
17967 (AttributeTester.Report_ObsoleteMessage): Common method for
17968 Obsolete error/warning reporting.
17971 (TypeContainer.base_classs_type): New member for storing parent type.
17974 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
17975 for this MemberCore.
17977 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17979 * attribute.cs, const.cs: Fix bug #58590
17981 2004-05-21 Martin Baulig <martin@ximian.com>
17983 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
17984 out parameters if the end of the method is unreachable. Fixes
17987 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17989 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
17990 Hari was right, why extra method.
17992 2004-05-21 Marek Safar <marek.safar@seznam.cz>
17994 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
17996 2004-05-20 Martin Baulig <martin@ximian.com>
17998 Merged this back from gmcs to keep the differences to a minumum.
18000 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18001 instead of a Declspace.
18002 (Attribute.ResolveType): Likewise.
18003 (Attributes.Search): Likewise.
18004 (Attributes.Contains): Likewise.
18005 (Attributes.GetClsCompliantAttribute): Likewise.
18007 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18009 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18012 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18014 Fix bug #58688 (MCS does not report error when the same attribute
18017 * attribute.cs (Attribute.Emit): Distinction between null and default.
18019 2004-05-19 Raja R Harinath <rharinath@novell.com>
18021 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18022 of a top-level attribute without an attribute target.
18023 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18025 (Attribute.Conditional_GetConditionName),
18026 (Attribute.Obsolete_GetObsoleteMessage): Update.
18027 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18028 part of ScanForIndexerName.
18029 (Attribute.CanIgnoreInvalidAttribute): New function.
18030 (Attribute.ScanForIndexerName): Move to ...
18031 (Attributes.ScanForIndexerName): ... here.
18032 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18033 (Attributes.Search): New internal variant that can choose not to
18034 complain if types aren't resolved. The original signature now
18036 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18037 complaints suppressed.
18038 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18039 only if it not useful.
18040 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18041 top-level for attributes that are shared between the assembly
18042 and a top-level class.
18043 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18044 * class.cs: Update to reflect changes.
18045 (DefineIndexers): Fuse loops.
18046 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18047 a couple more variants of attribute names.
18049 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18051 Fix bug #52585 (Implemented explicit attribute declaration)
18054 (Attributable.ValidAttributeTargets): New abstract method. It gets
18055 list of valid attribute targets for explicit target declaration.
18056 (Attribute.Target): It holds target itself.
18057 (AttributeSection): Removed.
18058 (Attribute.CheckTargets): New method. It checks whether attribute
18059 target is valid for the current element.
18062 (EventProperty): New class. For events that are declared like
18063 property (with add and remove accessors).
18064 (EventField): New class. For events that are declared like field.
18067 * cs-parser.jay: Implemented explicit attribute target declaration.
18069 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18070 Override ValidAttributeTargets.
18073 (ReturnParameter): Class for applying custom attributes on
18075 (ParameterAtribute): New class. Class for applying custom
18076 attributes on the parameter type.
18078 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18080 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18083 (Method): Allow UNSAFE here.
18085 * modifiers.cs: Support unsafe reporting.
18087 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18089 * decl.cs: Fix bug #58478.
18091 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18093 * statement.cs: When checking for unreachable code on an EmptyStatement,
18094 set the location. Fixes bug #58488.
18096 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18098 * driver.cs: Add -pkg handling.
18100 From Gonzalo: UseShelLExecute=false
18102 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18105 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18107 (Attribute.IsClsCompliaceRequired): Moved to base for better
18109 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18110 when attribute is AttributeUsageAttribute.
18111 (Attribute.GetValidTargets): Simplified.
18112 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18113 attribute for this type.
18114 (Attribute.ApplyAttributes): Method renamed to Emit and make
18116 (GlobalAttributeSection): New class for special handling of global
18117 attributes (assembly, module).
18118 (AttributeSection.Emit): New method.
18120 * class.cs: Implemented Attributable abstract methods.
18121 (MethodCore.LabelParameters): Moved to Parameter class.
18122 (Accessor): Is back simple class.
18123 (PropertyMethod): Implemented Attributable abstract class.
18124 (DelegateMethod): Implemented Attributable abstract class.
18125 (Event): New constructor for disctintion between normal Event
18126 and Event with accessors.
18128 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18130 * codegen.cs, const.cs, decl.cs, delegate.cs:
18131 (CommonAssemblyModulClass): Implemented Attributable abstract class
18134 * enum.cs: Implement IAttributeSupport interface.
18135 (EnumMember): New class for emum members. Implemented Attributable
18139 (ParameterBase): Is abstract.
18140 (ReturnParameter): New class for easier [return:] attribute handling.
18142 * typemanager.cs: Removed builder_to_attr.
18144 2004-05-11 Raja R Harinath <rharinath@novell.com>
18147 * attribute.cs (Attribute.GetPositionalValue): New function.
18148 * class.cs (TypeContainer.VerifyMembers): New function.
18149 (TypeContainer.Emit): Use it.
18150 (ClassOrStruct): New base class for Class and Struct.
18151 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18152 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18154 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18155 then each non-static field should have a FieldOffset attribute.
18156 Otherwise, none of the fields should have a FieldOffset attribute.
18157 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18158 and FieldOffset attributes.
18159 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18160 (TypeManager.field_offset_attribute_type): New core types.
18161 (TypeManager.InitCoreTypes): Initialize them.
18163 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18165 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18166 Return correct type.
18169 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18171 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18172 be implicitly converted to ulong.
18174 * expression.cs: The logic for allowing operator &, | and ^ worked
18175 was wrong, it worked before because we did not report an error in
18176 an else branch. Fixes 57895.
18178 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18179 allow volatile fields to be reference types.
18181 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18183 * driver.cs: Add support for /debug-
18185 2004-05-07 Raja R Harinath <rharinath@novell.com>
18187 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18188 Add a 'complain' parameter to silence errors.
18189 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18190 silently overlooked type-resolutions.
18191 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18192 to reflect changes.
18193 (Attributes.Search): New function.
18194 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18195 (Attributes.GetAttributeFullName): Remove hack.
18196 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18197 Update to reflect changes.
18198 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18199 Use Attributes.Search instead of nested loops.
18201 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18204 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18205 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18206 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18208 * report.cs: (Report.Warning): Renamed to Warning_T because of
18209 parameter collision.
18211 2004-05-05 Raja R Harinath <rharinath@novell.com>
18213 * expression.cs (MemberAccess.ResolveMemberAccess):
18214 Exit with non-zero status after Report.Error.
18215 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18217 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18219 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18221 * support.cs: Don't hang when the file is empty.
18223 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18225 * support.cs: In SeekableStreamReader, compute the preamble size of the
18226 underlying stream. Position changes should take into account that initial
18229 2004-05-03 Todd Berman <tberman@sevenl.net>
18231 * driver.cs: remove unused GetSysVersion function.
18233 2004-05-03 Todd Berman <tberman@sevenl.net>
18235 * driver.cs: Remove the hack from saturday, as well as the hack
18236 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18237 link_paths to get that bit proper.
18239 2004-05-01 Todd Berman <tberman@sevenl.net>
18241 * driver.cs: Try a LoadFrom before a Load, this checks the current
18242 path. This is currently a bug in mono that is be fixed, however, this
18243 provides a workaround for now. This will be removed when the bug
18246 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18248 * CryptoConvert.cs: Updated to latest version. Fix issue with
18249 incomplete key pairs (#57941).
18251 2004-05-01 Todd Berman <tberman@sevenl.net>
18253 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18256 2004-04-30 Jackson Harper <jackson@ximian.com>
18258 * codegen.cs: Open keys readonly.
18260 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18262 * typemanager.cs: don't report cyclic struct layout when a struct
18263 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18264 which has 2 Pango.Rectangle fields.
18266 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18268 * expression.cs: Handle IntPtr comparisons with IL code
18269 rather than a method call.
18271 2004-04-29 Martin Baulig <martin@ximian.com>
18273 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18274 the list of PropertyInfo's in class hierarchy and find the
18275 accessor. Fixes #56013.
18277 2004-04-29 Martin Baulig <martin@ximian.com>
18279 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18281 2004-04-29 Martin Baulig <martin@ximian.com>
18283 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18285 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18287 2004-04-29 Martin Baulig <martin@ximian.com>
18289 * class.cs (ConstructorInitializer.Resolve): Check whether the
18290 parent .ctor is accessible. Fixes #52146.
18292 2004-04-29 Martin Baulig <martin@ximian.com>
18294 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18296 * statement.cs (Using.EmitLocalVariableDecls): Use
18297 TypeManager.idisposable_type, not typeof (IDisposable).
18298 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18300 2004-04-29 Martin Baulig <martin@ximian.com>
18302 * class.cs (Event.Define): Don't emit the field and don't set
18303 RTSpecialName and SpecialName for events on interfaces. Fixes
18306 2004-04-29 Raja R Harinath <rharinath@novell.com>
18308 Refactor Attribute.ApplyAttributes.
18309 * attribute.cs (Attributable): New base class for objects that can
18310 have Attributes applied on them.
18311 (Attribute): Make AttributeUsage fields public.
18312 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18313 (Attribute.IsInternalCall): New property.
18314 (Attribute.UsageAttr): Convert to a public read-only property.
18315 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18316 (Attribute.ResolveType, Attribute.Resolve)
18317 (Attribute.ScanForIndexerName): Update to reflect changes.
18318 (Attribute.CheckAttributeTarget): Re-format.
18319 (Attribute.ApplyAttributes): Refactor, to various
18320 Attributable.ApplyAttributeBuilder methods.
18321 * decl.cs (MemberCore): Make Attributable.
18322 * class.cs (Accessor): Make Attributable.
18323 (MethodData.ApplyAttributes): Use proper attribute types, not
18325 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18326 (TypeContainer.ApplyAttributeBuilder)
18327 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18328 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18329 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18330 (Operator.ApplyAttributeBuilder): New factored-out methods.
18331 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18332 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18333 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18334 * parameter.cs (ParameterBase): New Attributable base class
18335 that can also represent Return types.
18336 (Parameter): Update to the changes.
18338 2004-04-29 Jackson Harper <jackson@ximian.com>
18340 * driver.cs: Prefer the corlib system version when looking for
18341 assemblies in the GAC. This is still a hack, but its a better hack
18344 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18346 * decl.cs, enum.cs: Improved error 3005 reporting.
18348 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18349 (related_symbols): New private member for list of symbols
18350 related to reported error/warning.
18352 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18354 2004-04-29 Martin Baulig <martin@ximian.com>
18356 * ecore.cs (Expression.Constantify): If we're an enum and
18357 TypeManager.TypeToCoreType() doesn't give us another type, use
18358 t.UnderlyingSystemType. Fixes #56178.
18360 2004-04-29 Martin Baulig <martin@ximian.com>
18362 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18363 interfaces and for each interface, only add members directly
18364 declared in that interface. Fixes #53255.
18366 2004-04-28 Martin Baulig <martin@ximian.com>
18368 * expression.cs (ConditionalLogicalOperator): Use a temporary
18369 variable for `left' to avoid that we evaluate it more than once;
18372 2004-04-28 Martin Baulig <martin@ximian.com>
18374 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18377 2004-04-28 Martin Baulig <martin@ximian.com>
18379 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18382 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18383 whether the type is not void (CS1547).
18385 2004-04-28 Martin Baulig <martin@ximian.com>
18387 * expression.cs (Unary.DoResolveLValue): Override this and report
18388 CS0131 for anything but Operator.Indirection.
18390 2004-04-28 Martin Baulig <martin@ximian.com>
18392 Committing a patch from Ben Maurer; see bug #50820.
18394 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18397 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18400 2004-04-28 Martin Baulig <martin@ximian.com>
18402 Committing a patch from Ben Maurer; see bug #50820.
18404 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18407 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18410 2004-04-28 Martin Baulig <martin@ximian.com>
18412 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18413 (Block.AddLabel): Call DoLookupLabel() to only search in the
18416 2004-04-28 Martin Baulig <martin@ximian.com>
18418 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18419 comparing StringConstants and NullLiterals in Equality and Inequality.
18421 2004-04-28 Jackson Harper <jackson@ximian.com>
18423 * driver.cs: Attempt to load referenced assemblies from the
18424 GAC. This is the quick and dirty version of this method that
18425 doesnt take into account versions and just takes the first
18426 canidate found. Will be good enough for now as we will not have more
18427 then one version installed into the GAC until I update this method.
18429 2004-04-28 Martin Baulig <martin@ximian.com>
18431 * typemanager.cs (TypeManager.CheckStructCycles): New public
18432 static method to check for cycles in the struct layout.
18434 * rootcontext.cs (RootContext.PopulateTypes): Call
18435 TypeManager.CheckStructCycles() for each TypeContainer.
18436 [Note: We only need to visit each type once.]
18438 2004-04-28 Martin Baulig <martin@ximian.com>
18440 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18442 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18443 success and added `out object value'. Use a `bool resolved' field
18444 to check whether we've already been called rather than
18445 `ConstantValue != null' since this breaks for NullLiterals.
18447 2004-04-28 Raja R Harinath <rharinath@novell.com>
18449 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18450 setting of this flag, since the 'set' method may be non-public.
18452 2004-04-28 Raja R Harinath <rharinath@novell.com>
18454 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18455 check on current_vector.Block.
18457 2004-04-27 Martin Baulig <martin@ximian.com>
18459 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18460 a field initializer. Fixes #56459.
18462 2004-04-27 Martin Baulig <martin@ximian.com>
18464 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18465 we're not attempting to use an indexer. Fixes #52154.
18467 2004-04-27 Martin Baulig <martin@ximian.com>
18469 * statement.cs (Return): Don't create a return label if we don't
18470 need it; reverts my change from January 20th. Thanks to Ben
18473 2004-04-27 Martin Baulig <martin@ximian.com>
18475 According to the spec, `goto' can only leave a nested scope, but
18478 * statement.cs (Block.LookupLabel): Only lookup in the current
18479 block, don't recurse into parent or child blocks.
18480 (Block.AddLabel): Check in parent and child blocks, report
18481 CS0140/CS0158 if we find a duplicate.
18482 (Block): Removed this indexer for label lookups.
18483 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18484 this already does the error reporting for us.
18487 (FlowBranching.UsageVector.Block): New public variable; may be null.
18488 (FlowBranching.CreateSibling): Added `Block' argument.
18489 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18490 label for the target of a `goto' and check whether we're not
18491 leaving a `finally'.
18493 2004-04-27 Martin Baulig <martin@ximian.com>
18495 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18496 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18499 2004-04-27 Martin Baulig <martin@ximian.com>
18501 * statement.cs (Block.AddLabel): Also check for implicit blocks
18502 and added a CS0158 check.
18504 2004-04-27 Martin Baulig <martin@ximian.com>
18506 * flowanalysis.cs (FlowBranchingLoop): New class.
18507 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18508 UsageVector's instead of an ArrayList.
18509 (FlowBranching.Label): Likewise.
18510 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18511 (FlowBranching.AddBreakVector): New method.
18513 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18515 * attribute.cs: Small regression fix: only convert the type if we
18516 the type is different, fixes System.Drawing build.
18518 2004-04-27 Martin Baulig <martin@ximian.com>
18520 * attribute.cs (Attribute.Resolve): If we have a constant value
18521 for a named field or property, implicity convert it to the correct
18524 2004-04-27 Raja R Harinath <rharinath@novell.com>
18526 * statement.cs (Block.Block): Implicit blocks share
18527 'child_variable_names' fields with parent blocks.
18528 (Block.AddChildVariableNames): Remove.
18529 (Block.AddVariable): Mark variable as "used by a child block" in
18530 every surrounding block.
18531 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18532 been used in a child block, complain about violation of "Invariant
18533 meaning in blocks" rule.
18534 * cs-parser.jay (declare_local_variables): Don't use
18535 AddChildVariableNames.
18536 (foreach_statement): Don't create an implicit block: 'foreach'
18537 introduces a scope.
18539 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18541 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18542 converting from 0L to ulong. Fixes 57522.
18544 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18546 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18547 derived class hides via 'new' keyword field from base class (test-242.cs).
18548 TODO: Handle this in the more general way.
18550 * class.cs (CheckBase): Ditto.
18552 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18554 * decl.cs (caching_flags): New member for storing cached values
18556 (MemberCore.Flags): New enum where bit flags for caching_flags
18558 (MemberCore.cls_compliance): Moved to caching_flags.
18559 (DeclSpace.Created): Moved to caching_flags.
18561 * class.cs: Use caching_flags instead of DeclSpace.Created
18563 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18565 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18566 if we are only a derived class, not a nested class.
18568 * typemanager.cs: Same as above, but do this at the MemberLookup
18569 level (used by field and methods, properties are handled in
18570 PropertyExpr). Allow for the qualified access if we are a nested
18573 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18575 * class.cs: Refactoring.
18576 (IMethodData): New inteface; Holds links to parent members
18577 to avoid member duplication (reduced memory allocation).
18578 (Method): Implemented IMethodData interface.
18579 (PropertyBase): New inner classes for get/set methods.
18580 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18581 (Event): New inner classes for add/remove methods.
18582 (Event.DelegateMethod): Implemented IMethodData interface.
18584 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18585 EmitContext (related to class.cs refactoring).
18587 2004-04-21 Raja R Harinath <rharinath@novell.com>
18589 * delegate.cs (Delegate.VerifyApplicability): If the number of
18590 arguments are the same as the number of parameters, first try to
18591 verify applicability ignoring any 'params' modifier on the last
18595 2004-04-16 Raja R Harinath <rharinath@novell.com>
18597 * class.cs (TypeContainer.AddIndexer): Use
18598 'ExplicitInterfaceName' to determine if interface name was
18599 explicitly specified. 'InterfaceType' is not initialized at this time.
18600 (TypeContainer.DefineIndexers): Remove use of temporary list. The
18601 Indexers array is already in the required order. Initialize
18602 'IndexerName' only if there are normal indexers.
18603 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
18604 (TypeContainer.Emit): Emit DefaultMember attribute only if
18605 IndexerName is initialized.
18608 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
18610 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
18613 2004-04-15 Raja R Harinath <rharinath@novell.com>
18615 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
18619 * attribute.cs (Attribute.Resolve): Check for duplicate named
18623 2004-04-15 Miguel de Icaza <miguel@ximian.com>
18625 * iterators.cs (MarkYield): track whether we are in an exception,
18626 and generate code accordingly. Use a temporary value to store the
18627 result for our state.
18629 I had ignored a bit the interaction of try/catch with iterators
18630 since their behavior was not entirely obvious, but now it is
18631 possible to verify that our behavior is the same as MS .NET 2.0
18635 2004-04-14 Miguel de Icaza <miguel@ximian.com>
18637 * iterators.cs: Avoid creating temporaries if there is no work to
18640 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
18641 Enumerations, use TypeManager.EnumToUnderlying and call
18644 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
18647 (This.Emit): Use EmitContext.EmitThis to emit our
18650 (This.EmitAssign): Ditto.
18652 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
18653 codepaths, we will move all the functionality into
18656 (FieldExpr.EmitAssign): Ditto.
18658 This fixes several hidden bugs that I uncovered while doing a code
18659 review of this today.
18661 * codegen.cs (EmitThis): reworked so the semantics are more clear
18662 and also support value types "this" instances.
18664 * iterators.cs: Changed so that for iterators in value types, we
18665 do not pass the value type as a parameter.
18667 Initialization of the enumerator helpers is now done in the caller
18668 instead of passing the parameters to the constructors and having
18669 the constructor set the fields.
18671 The fields have now `assembly' visibility instead of private.
18673 2004-04-11 Miguel de Icaza <miguel@ximian.com>
18675 * expression.cs (Argument.Resolve): Check if fields passed as ref
18676 or out are contained in a MarshalByRefObject.
18678 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
18679 another compiler type.
18681 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
18683 * class.cs (Indexer.Define): use the new name checking method.
18684 Also, return false on an error.
18685 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
18686 (is_identifier_[start/part]_character): make static.
18688 2004-04-10 Miguel de Icaza <miguel@ximian.com>
18690 * expression.cs (Binary.ResolveOperator): Do no append strings
18691 twice: since we can be invoked more than once (array evaluation)
18692 on the same concatenation, take care of this here. Based on a fix
18693 from Ben (bug #56454)
18695 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
18697 * codegen.cs: Fix another case where CS1548 must be reported (when
18698 delay-sign isn't specified and no private is available #56564). Fix
18699 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
18700 error when MCS is used on the MS runtime and we need to delay-sign
18701 (which seems unsupported by AssemblyBuilder - see #56621).
18703 2004-04-08 Marek Safar <marek.safar@seznam.cz>
18705 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
18706 (TypeManager.ComputeNamespaces): Faster implementation for
18709 * compiler.csproj: Updated AssemblyName to mcs.
18711 2004-04-07 Miguel de Icaza <miguel@ximian.com>
18713 * rootcontext.cs: Add new types to the boot resolution.
18715 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
18716 MulticastDelegate is not allowed.
18718 * typemanager.cs: Add new types to lookup: System.TypedReference
18721 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
18722 check for TypedReference or ArgIterator, they are not allowed.
18724 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
18725 makes us properly catch 1510 in some conditions (see bug 56016 for
18728 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
18730 * CryptoConvert.cs: update from corlib version
18733 2004-04-05 Miguel de Icaza <miguel@ximian.com>
18735 * class.cs (Indexer.Define): Check indexername declaration
18737 2004-04-05 Marek Safar <marek.safar@seznam.cz>
18739 * attribute.cs (IsClsCompliant): Fixed problem with handling
18740 all three states (compliant, not-compliant, undetected).
18742 2004-03-30 Marek Safar <marek.safar@seznam.cz>
18744 * attribute.cs (Attribute): Location is now public.
18745 (Resolve): Store resolved arguments (pos_values) in attribute class.
18746 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
18747 (GetClsCompliantAttributeValue): New method that gets
18748 CLSCompliantAttribute value.
18749 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
18750 if exists else null.
18751 (AttributeTester): New class for CLS-Compliant verification routines.
18753 * class.cs (Emit): Add CLS-Compliant verification.
18754 (Method.GetSignatureForError): Implemented.
18755 (Constructor.GetSignatureForError): Implemented
18756 (Constructor.HasCompliantArgs): Returns if constructor has
18757 CLS-Compliant arguments.
18758 (Constructor.Emit): Override.
18759 (Construcor.IsIdentifierClsCompliant): New method; For constructors
18760 is needed to test only parameters.
18761 (FieldBase.GetSignatureForError): Implemented.
18762 (TypeContainer): New member for storing base interfaces.
18763 (TypeContainer.FindMembers): Search in base interfaces too.
18765 * codegen.cs (GetClsComplianceAttribute): New method that gets
18766 assembly or module CLSCompliantAttribute value.
18767 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
18769 (ModuleClass.Emit): Add error 3012 test.
18771 * const.cs (Emit): Override and call base for CLS-Compliant tests.
18773 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
18774 state for all decl types.
18775 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
18776 if CLS-Compliant tests are required.
18777 (IsClsCompliaceRequired): New method. Analyze whether code
18778 must be CLS-Compliant.
18779 (IsExposedFromAssembly): New method. Returns true when MemberCore
18780 is exposed from assembly.
18781 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
18782 value or gets cached value.
18783 (HasClsCompliantAttribute): New method. Returns true if MemberCore
18784 is explicitly marked with CLSCompliantAttribute.
18785 (IsIdentifierClsCompliant): New abstract method. This method is
18786 used to testing error 3005.
18787 (IsIdentifierAndParamClsCompliant): New method. Common helper method
18788 for identifier and parameters CLS-Compliant testing.
18789 (VerifyClsCompliance): New method. The main virtual method for
18790 CLS-Compliant verifications.
18791 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
18792 null. I don't know why is null (too many public members !).
18793 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
18794 and get value of first CLSCompliantAttribute that found.
18796 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
18797 (VerifyClsCompliance): Override and add extra tests.
18799 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
18800 clscheck- disable CLS-Compliant verification event if assembly is has
18801 CLSCompliantAttribute(true).
18803 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
18804 ApllyAttribute is now called in emit section as in the other cases.
18805 Possible future Emit integration.
18806 (IsIdentifierClsCompliant): New override.
18807 (VerifyClsCompliance): New override.
18808 (GetEnumeratorName): Returns full enum name.
18810 * parameter.cs (GetSignatureForError): Implemented.
18812 * report.cs (WarningData): New struct for Warning message information.
18813 (LocationOfPreviousError): New method.
18814 (Warning): New method. Reports warning based on the warning table.
18815 (Error_T): New method. Reports error based on the error table.
18817 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
18818 verifications are done here.
18820 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
18822 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
18823 CLSCompliantAttribute.
18824 (all_imported_types): New member holds all imported types from other
18826 (LoadAllImportedTypes): New method fills static table with exported types
18827 from all referenced assemblies.
18828 (Modules): New property returns all assembly modules.
18830 2004-03-30 Miguel de Icaza <miguel@ximian.com>
18832 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
18833 throwing a parser error.
18835 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
18836 which removes the hardcoded get_/set_ prefixes for properties, as
18837 IL allows for the properties to be named something else.
18841 * expression.cs: Do not override operand before we know if it is
18842 non-null. Fix 56207
18844 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18846 * typemanager.cs: support for pinned variables.
18848 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18850 * decl.cs, typemanager.cs: Avoid using an arraylist
18851 as a buffer if there is only one result set.
18853 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
18855 * expression.cs: Make sure you cant call a static method
18856 with an instance expression, bug #56174.
18858 2004-03-29 Miguel de Icaza <miguel@ximian.com>
18860 * class.cs (IsDuplicateImplementation): Improve error reporting to
18861 flag 663 (method only differs in parameter modifier).
18863 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
18864 in preprocessor directives.
18866 * location.cs (LookupFile): Allow for the empty path.
18868 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
18869 better approach for some of that patch, but its failing with the
18870 CharSet enumeration. For now try/catch will do.
18872 * typemanager.cs: Do not crash if a struct does not have fields.
18875 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18877 * expression.cs: cs0213, cant fix a fixed expression.
18880 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18882 * cs-parser.jay: detect invalid embeded statements gracefully.
18885 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
18887 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
18890 the invocation type may not be a subclass of the tye of the item/
18891 The type of the item must be a subclass of the invocation item.
18896 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
18898 * attribute.cs: Added methods to get a string and a bool from an
18899 attribute. Required to information from AssemblyKeyFileAttribute,
18900 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
18901 * codegen.cs: Modified AssemblyName creation to include support for
18902 strongnames. Catch additional exceptions to report them as CS1548.
18903 * compiler.csproj: Updated include CryptoConvert.cs.
18904 * compiler.csproj.user: Removed file - user specific configuration.
18905 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
18906 Mono.Security assembly. The original class is maintained and tested in
18907 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
18908 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
18909 like CSC 8.0 (C# v2) supports.
18910 * Makefile: Added CryptoConvert.cs to mcs sources.
18911 * rootcontext.cs: Added new options for strongnames.
18913 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
18915 * driver.cs: For --expect-error, report error code `2'
18916 if the program compiled with no errors, error code `1' if
18917 it compiled with an error other than the one expected.
18919 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
18921 * compiler.csproj: Updated for Visual Studio .NET 2003.
18922 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
18923 * compiler.sln: Updated for Visual Studio .NET 2003.
18925 2004-03-24 Ravi Pratap M <ravi@ximian.com>
18927 * expression.cs: Fix bug #47234. We basically need to apply the
18928 rule that we prefer the conversion of null to a reference type
18929 when faced with a conversion to 'object' (csc behaviour).
18931 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18933 * statement.cs: Shorter form for foreach, eliminates
18934 a local variable. r=Martin.
18936 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18938 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
18939 checks if we can use brtrue/brfalse to test for 0.
18940 * expression.cs: use the above in the test for using brtrue/brfalse.
18941 cleanup code a bit.
18943 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18945 * expression.cs: Rewrite string concat stuff. Benefits:
18947 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
18948 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
18949 rather than a concat chain.
18951 * typemanager.cs: Add lookups for more concat overloads.
18953 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
18955 * expression.cs: Emit shorter il code for array init.
18972 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
18974 * statement.cs: Before, two switch blocks would be merged if the
18975 total size of the blocks (end_item - begin_item + 1) was less than
18976 two times the combined sizes of the blocks.
18978 Now, it will only merge if after the merge at least half of the
18983 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
18985 * class.cs : csc build fix for GetMethods(). See bug #52503.
18987 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
18989 * expression.cs: Make sure fp comparisons work with NaN.
18990 This fixes bug #54303. Mig approved this patch a long
18991 time ago, but we were not able to test b/c the runtime
18994 2004-03-19 Miguel de Icaza <miguel@ximian.com>
18996 * ecore.cs (TypExpr.GetHashCode): implement this overload.
18998 2004-03-19 Martin Baulig <martin@ximian.com>
19000 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19001 error here and not in our caller.
19003 2004-03-19 Martin Baulig <martin@ximian.com>
19005 * interface.cs: Completely killed this file.
19006 (Interface): We're now a TypeContainer and live in class.cs.
19008 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19009 argument; we're now also called for interfaces.
19010 (TypeContainer.DefineMembers): Allow this method being called
19012 (TypeContainer.GetMethods): New public method; formerly known as
19013 Interface.GetMethod(). This is used by PendingImplementation.
19014 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19015 it's now private and non-static.
19016 (Interface): Moved this here; it's now implemented similar to
19018 (Method, Property, Event, Indexer): Added `bool is_interface'
19019 argument to their .ctor's.
19020 (MemberBase.IsInterface): New public field.
19022 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19023 instances instead of InterfaceMethod, InterfaceProperty, etc.
19024 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19025 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19027 2004-03-19 Martin Baulig <martin@ximian.com>
19029 * class.cs (MethodCore.IsDuplicateImplementation): New private
19030 method which does the CS0111 checking.
19031 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19032 Use IsDuplicateImplementation().
19034 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19036 * decl.cs (FindMemberToOverride): New method to find the correct
19037 method or property to override in the base class.
19039 - Make Method/Property use the above method to find the
19040 version in the base class.
19041 - Remove the InheritableMemberSignatureCompare as it is now
19044 This patch makes large code bases much faster to compile, as it is
19045 O(n) rather than O(n^2) to do this validation.
19047 Also, it fixes bug 52458 which is that nested classes are not
19048 taken into account when finding the base class member.
19050 Reviewed/Approved by Martin.
19052 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19054 * interface.cs: In all interface classes removed redundant
19055 member initialization.
19057 2004-03-16 Martin Baulig <martin@ximian.com>
19059 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19061 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19063 * decl.cs (DefineTypeAndParents): New helper method to define a
19064 type's containers before the type itself is defined; This is a
19065 bug exposed by the recent changes to Windows.Forms when an
19066 implemented interface was defined inside a class that had not been
19069 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19071 (Check): Loop correctly to report errors modifiers
19072 (UNSAFE was not in the loop, since it was the same as TOP).
19074 * interface.cs: Every interface member now takes a ModFlags,
19075 instead of a "is_new" bool, which we set on the base MemberCore.
19077 Every place where we called "UnsafeOk" in the interface, now we
19078 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19079 the unsafe settings from the member declaration instead of the
19080 container interface.
19082 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19084 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19085 `set_indexer_name' to the pending bits (one per type).
19087 We fixed a bug today that was picking the wrong method to
19088 override, since for properties the existing InterfaceMethod code
19089 basically ignored the method name. Now we make sure that the
19090 method name is one of the valid indexer names.
19092 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19094 * support.cs (SeekableStreamReader): Keep track of stream byte
19095 positions and don't mix them with character offsets to the buffer.
19097 Patch from Gustavo Giráldez
19099 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19101 * interface.cs (InterfaceSetGetBase): Removed double member
19102 initialization, base class does it as well.
19104 2004-03-13 Martin Baulig <martin@ximian.com>
19106 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19107 when compiling corlib.
19109 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19111 * convert.cs (ExplicitConversion): We were reporting an error on
19112 certain conversions (object_type source to a value type, when the
19113 expression was `null') before we had a chance to pass it through
19114 the user defined conversions.
19116 * driver.cs: Replace / and \ in resource specifications to dots.
19119 * class.cs: Add check for duplicate operators. Fixes 52477
19121 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19123 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19124 that are in the middle of the statements, not only at the end.
19127 * class.cs (TypeContainer.AddField): No longer set the
19128 `HaveStaticConstructor' flag, now we call it
19129 `UserDefineStaticConstructor' to diferentiate the slightly
19130 semantic difference.
19132 The situation is that we were not adding BeforeFieldInit (from
19133 Modifiers.TypeAttr) to classes that could have it.
19134 BeforeFieldInit should be set to classes that have no static
19139 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19141 And most importantly Zoltan's comment:
19143 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19145 "I think beforefieldinit means 'it's ok to initialize the type sometime
19146 before its static fields are used', i.e. initialization does not need
19147 to be triggered by the first access to the type. Setting this flag
19148 helps the JIT to compile better code, since it can run the static
19149 constructor at JIT time, and does not need to generate code to call it
19150 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19151 this flag for lots of classes like String.
19153 csc sets this flag if the type does not have an explicit static
19154 constructor. The reasoning seems to be that if there are only static
19155 initalizers for a type, and no static constructor, then the programmer
19156 does not care when this initialization happens, so beforefieldinit
19159 This bug prevents the AOT compiler from being usable, since it
19160 generates so many calls to mono_runtime_class_init that the AOT code
19161 is much slower than the JITted code. The JITted code is faster,
19162 because it does not generate these calls if the vtable is type is
19163 already initialized, which is true in the majority of cases. But the
19164 AOT compiler can't do this."
19166 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19168 * class.cs (MethodData.Emit): Refactor the code so symbolic
19169 information is generated for destructors; For some reasons we
19170 were taking a code path that did not generate symbolic information
19173 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19175 * class.cs: Create a Constructor.CheckBase method that
19176 takes care of all validation type code. The method
19177 contains some code that was moved from Define.
19179 It also includes new code that checks for duplicate ctors.
19180 This fixes bug #55148.
19182 2004-03-09 Joshua Tauberer <tauberer@for.net>
19184 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19185 a { ... }-style array creation invokes EmitStaticInitializers
19186 which is not good for reference-type arrays. String, decimal
19187 and now null constants (NullCast) are not counted toward
19188 static initializers.
19190 2004-03-05 Martin Baulig <martin@ximian.com>
19192 * location.cs (SourceFile.HasLineDirective): New public field;
19193 specifies whether the file contains or is referenced by a "#line"
19195 (Location.DefineSymbolDocuments): Ignore source files which
19196 either contain or are referenced by a "#line" directive.
19198 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19200 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19201 direct access to our parent, so check the method inline there.
19203 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19205 * expression.cs (Invocation.EmitCall): Miguel's last commit
19206 caused a regression. If you had:
19211 In Foo the implict this would be null.
19213 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19215 * expression.cs (Invocation.EmitCall): If the method is not
19216 virtual, do not emit a CallVirt to it, use Call.
19218 * typemanager.cs (GetFullNameSignature): Improve the method to
19219 cope with ".ctor" and replace it with the type name.
19221 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19222 as an argument the ConstructorBuilder where it is being defined,
19223 to catch the recursive constructor invocations.
19225 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19227 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19228 routines to check if a type is an enumerable/enumerator allow
19229 classes that implement the IEnumerable or IEnumerator interfaces.
19231 * class.cs (Property, Operator): Implement IIteratorContainer, and
19232 implement SetYields.
19234 (Property.Define): Do the block swapping for get_methods in the
19235 context of iterators. We need to check if Properties also
19236 include indexers or not.
19238 (Operator): Assign the Block before invoking the
19239 OperatorMethod.Define, so we can trigger the Iterator code
19242 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19243 Property and Operator classes are not created when we parse the
19244 declarator but until we have the block completed, so we use a
19245 singleton SimpleIteratorContainer.Simple to flag whether the
19246 SetYields has been invoked.
19248 We propagate this setting then to the Property or the Operator to
19249 allow the `yield' to function.
19251 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19253 * codegen.cs: Implemented attribute support for modules.
19254 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19255 Assembly/Module functionality.
19257 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19258 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19259 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19261 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19263 * interface.cs (FindMembers): The operation is performed on all base
19264 interfaces and not only on the first. It is required for future CLS Compliance patch.
19266 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19268 * statement.cs, codegen.cs:
19269 This patch deals with patterns such as:
19271 public class List : IEnumerable {
19273 public MyEnumerator GetEnumerator () {
19274 return new MyEnumerator(this);
19277 IEnumerator IEnumerable.GetEnumerator () {
19281 public struct MyEnumerator : IEnumerator {
19286 Before, there were a few things we did wrong:
19287 1) we would emit callvirt on a struct, which is illegal
19288 2) we emited ldarg when we needed to emit ldarga
19289 3) we would mistakenly call the interface methods on an enumerator
19290 type that derived from IEnumerator and was in another assembly. For example:
19292 public class MyEnumerator : IEnumerator
19294 Would have the interface methods called, even if there were public impls of the
19295 method. In a struct, this lead to invalid IL code.
19297 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19299 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19302 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19304 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19306 * cs-parser.jay: Fix small regression: we were not testing V2
19307 compiler features correctly.
19309 * interface.cs: If the emit context is null, then create one
19311 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19313 * decl.cs (GetSignatureForError): New virtual method to get full name
19314 for error messages.
19316 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19317 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19319 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19320 Duplicated members and code in these classes has been removed.
19321 Better encapsulation in these classes.
19323 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19325 * assign.cs (Assign.DoResolve): When dealing with compound
19326 assignments, there is a new rule in ECMA C# 2.4 (might have been
19327 there before, but it is documented here) that states that in:
19331 If b is of type int, and the `op' is a shift-operator, then the
19332 above is evaluated as:
19336 * expression.cs (Binary.ResolveOperator): Instead of testing for
19337 int/uint/long/ulong, try to implicitly convert to any of those
19338 types and use that in pointer arithmetic.
19340 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19341 method to print information for from the type, not from the
19342 null-method we were given.
19344 2004-02-01 Duncan Mak <duncan@ximian.com>
19346 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19347 parsing for cmd, fixes bug #53694.
19349 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19351 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19352 in the member name duplication tests. Property and operator name duplication
19353 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19355 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19357 * interface.cs (PopulateMethod): Fixed crash when interface method
19358 returns not existing type (error test cs0246-3.cs).
19360 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19362 * cs-parser.jay (interface_accessors): Re-write actions to also
19363 store attributes attached to get and set methods. Fix spelling
19366 (inteface_property_declaration): Modify accordingly.
19368 (InterfaceAccessorInfo): New helper class to store information to pass
19369 around between rules that use interface_accessors.
19371 * interface.cs (Emit): Apply attributes on the get and set
19372 accessors of properties and indexers too.
19374 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19375 right MethodBuilder when applying attributes to the get and set accessors.
19377 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19379 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19381 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19383 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19385 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19387 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19388 changes that treat `yield' specially when present before `break'
19389 or `return' tokens.
19391 * cs-tokenizer.cs: yield is no longer a keyword.
19393 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19395 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19396 setting for default constructors.
19397 For default constructors are almost every time set wrong Modifier. The
19398 generated IL code has been alright. But inside mcs this values was
19399 wrong and this was reason why several of my CLS Compliance tests
19402 2004-01-22 Martin Baulig <martin@ximian.com>
19404 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19405 not a QualifiedIdentifier. This is what `type_name_expression'
19406 was previously doing.
19407 (type_name_expression): Removed; the code is now in
19408 `namespace_or_type_name'.
19409 (qualified_identifier): Removed, use `namespace_or_type_name'
19411 (QualifiedIdentifier): Removed this class.
19413 2004-01-22 Martin Baulig <martin@ximian.com>
19415 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19416 not a string as alias name.
19418 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19420 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19421 #52730 bug, and instead compute correctly the need to use a
19422 temporary variable when requesting an address based on the
19423 static/instace modified of the field and the constructor.
19425 2004-01-21 Martin Baulig <martin@ximian.com>
19427 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19428 class and namespace before looking up aliases. Fixes #52517.
19430 2004-01-21 Martin Baulig <martin@ximian.com>
19432 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19433 assinged in a 'try'; fixes exception4.cs.
19435 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19436 * class.cs : Implemented parameter-less constructor for TypeContainer
19438 * decl.cs: Attributes are now stored here. New property OptAttributes
19440 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19442 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19444 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19446 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19447 (CSharpSignature): New method for indexer and property signature.
19449 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19451 * pending.cs (IsVirtualFilter): Faster implementation.
19453 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19455 * typemanager.cs: Avoid inclusion of same assembly more than once.
19457 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19459 * cs-parser.jay: Fixed problem where the last assembly attribute
19460 has been applied also to following declaration (class, struct, etc.)
19462 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19464 * class.cs: Added error CS0538, CS0539 reporting.
19465 Fixed crash on Microsoft runtime when field type is void.
19467 * cs-parser.jay: Added error CS0537 reporting.
19469 * pending.cs: Added error CS0535 reporting.
19470 Improved error report for errors CS0536, CS0534.
19472 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19474 Merge a few bits from the Anonymous Method MCS tree.
19476 * statement.cs (ToplevelBlock): New class for toplevel methods,
19477 will hold anonymous methods, lifted variables.
19479 * cs-parser.jay: Create toplevel blocks for delegates and for
19480 regular blocks of code.
19482 2004-01-20 Martin Baulig <martin@ximian.com>
19484 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19485 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19486 and `NeedExplicitReturn'; added `IsLastStatement'.
19487 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19488 have a `ReturnLabel' or we're not unreachable.
19490 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19491 child's reachability; don't just override ours with it. Fixes
19492 #58058 (lluis's example).
19493 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19494 InFinally(), InLoop(), InSwitch() and
19495 BreakCrossesTryCatchBoundary() methods.
19497 * statement.cs (Return): Do all error checking in Resolve().
19498 Unless we are the last statement in a top-level block, always
19499 create a return label and jump to it.
19500 (Break, Continue): Do all error checking in Resolve(); also make
19501 sure we aren't leaving a `finally'.
19502 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19503 statement in a top-level block.
19504 (Block.Flags): Added `IsDestructor'.
19505 (Block.IsDestructor): New public property.
19507 2004-01-20 Martin Baulig <martin@ximian.com>
19509 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19511 2004-01-20 Martin Baulig <martin@ximian.com>
19513 * statement.cs (Statement.ResolveUnreachable): New public method.
19514 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19515 (Block.Resolve): Resolve unreachable statements.
19517 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19519 * expression.cs: We need to fix the case where we do
19520 not have a temp variable here.
19522 * assign.cs: Only expression compound assignments need
19523 temporary variables.
19525 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19527 * flowanalysis.cs: Reduce memory allocation in a few ways:
19528 - A block with no variables should not allocate a bit
19530 - A method with no out parameters does not need any tracking
19531 for assignment of the parameters, so we need not allocate
19534 public readonly Type[] VariableTypes;
19535 public readonly string[] VariableNames;
19536 Are redundant. The data is already stored in the variable
19537 map, so we need not allocate another array for it.
19538 - We need to add alot of checks for if (params | locals) == null
19539 due to the first two changes.
19541 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19543 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19544 implement IMemoryLocation, we store a copy on a local variable and
19545 take the address of it. Patch from Benjamin Jemlich
19547 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19548 to use a special "type_name_expression" rule which reduces the
19549 number of "QualifiedIdentifier" classes created, and instead
19550 directly creates MemberAccess expressions.
19552 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19554 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19555 that fixes #52853. Null literal assignment to ValueType
19557 * class.cs (MethodData.Emit): Instead of checking the name of the
19558 method to determine if its a destructor, create a new derived
19559 class from Method called Destructor, and test for that.
19561 * cs-parser.jay: Create a Destructor object instead of a Method.
19563 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19567 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19569 * expression.cs (Binary.ResolveOperator): Perform an implicit
19570 conversion from MethodGroups to their delegate types on the
19571 Addition operation.
19573 * delegate.cs: Introduce a new class DelegateCreation that is the
19574 base class for `NewDelegate' and `ImplicitDelegateCreation',
19575 factor some code in here.
19577 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19578 conversion from MethodGroups to compatible delegate types.
19580 * ecore.cs (Expression.Resolve): Do not flag error 654
19581 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19582 we allow conversions from MethodGroups to delegate types now.
19584 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19585 assignments in v2 either.
19587 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19589 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19590 static read-only fields in ctors.
19592 Applied patch from Benjamin Jemlich
19594 * expression.cs (UnaryMutator): Avoid leaking local variables.
19596 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19598 * cs-tokenizer.cs (IsCastToken): Allow the various native types
19599 here to return true, as they can be used like this:
19601 (XXX) int.MEMBER ()
19603 Fixed 49836 and all the other dups
19605 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
19607 * driver.cs: Implement /win32res and /win32icon.
19609 2004-01-08 Miguel de Icaza <miguel@ximian.com>
19611 * cs-parser.jay: Add a rule to improve error handling for the
19612 common mistake of placing modifiers after the type.
19614 2004-01-07 Miguel de Icaza <miguel@ximian.com>
19616 * cs-parser.jay (interface_event_declaration): Catch
19617 initialization of events on interfaces, and report cs0068
19619 * cs-parser.jay (interface_event_declaration): Catch
19620 initialization of events.
19622 * ecore.cs: Better report missing constructors.
19624 * expression.cs (Binary.ResolveOperator): My previous bug fix had
19625 the error reporting done in the wrong place. Fix.
19627 * expression.cs (Binary.ResolveOperator): Catch the
19628 operator + (E x, E y) error earlier, and later allow for implicit
19629 conversions in operator +/- (E e, U x) from U to the underlying
19632 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
19633 52596, if the container class is abstract, the default constructor
19634 is protected otherwise its public (before, we were always public).
19636 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
19639 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
19640 Jemlich that fixes bug #52597, MCS was generating invalid code for
19641 idisposable structs. Thanks to Ben for following up with this
19644 2004-01-06 Miguel de Icaza <miguel@ximian.com>
19646 * driver.cs: Allow assemblies without code to be generated, fixes
19649 2004-01-07 Nick Drochak <ndrochak@gol.com>
19651 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
19653 2004-01-05 Miguel de Icaza <miguel@ximian.com>
19655 * cs-parser.jay: Add rules to improve error reporting if fields or
19656 methods are declared at the namespace level (error 116)
19658 * Add rules to catch event add/remove
19660 2004-01-04 David Sheldon <dave-mono@earth.li>
19662 * expression.cs: Added matching ")" to error message for
19665 2004-01-03 Todd Berman <tberman@gentoo.org>
19667 * ecore.cs, attribute.cs:
19668 Applying fix from #52429.
19670 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19672 * ecore.cs, expression.cs, statement.cs:
19673 Total rewrite of how we handle branching. We
19674 now handle complex boolean expressions with fewer
19675 jumps. As well if (x == 0) no longer emits a ceq.
19677 if (x is Foo) is much faster now, because we generate
19680 Overall, we get a pretty big improvement on our benchmark
19681 tests. The code we generate is smaller and more readable.
19683 I did a full two-stage bootstrap. The patch was reviewed
19684 by Martin and Miguel.
19686 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19688 * cs-parser.jay: Make primary_expression not take a QI.
19689 we dont need this because the member_access rule covers
19690 us here. So we replace the rule with just IDENTIFIER.
19692 This has two good effects. First, we remove a s/r conflict.
19693 Second, we allocate many fewer QualifiedIdentifier objects.
19695 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19697 * attribute.cs: Handle MarshalAs attributes as pseudo, and
19698 set the correct information via SRE. This prevents
19699 hanging on the MS runtime. Fixes #29374.
19701 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
19703 * convert.cs: correctly handle conversions to value types
19704 from Enum and ValueType as unboxing conversions.
19706 Fixes bug #52569. Patch by Benjamin Jemlich.
19708 2004-01-02 Ravi Pratap <ravi@ximian.com>
19710 * expression.cs (BetterConversion): Prefer int -> uint
19711 over int -> ulong (csc's behaviour). This fixed bug #52046.
19713 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
19715 * decl.cs (MemberCache.FindMembers): now returns a
19718 * typemanager.cs: In general, go with with ^^.
19719 (CopyNewMethods): take an IList.
19720 (RealMemberLookup): Only allocate an arraylist
19721 if we copy from two sets of methods.
19723 This change basically does two things:
19724 1) Fewer array lists allocated due to CopyNewMethods.
19725 2) the explicit cast in MemberList costed ALOT.
19727 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
19729 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
19730 a hashtable to avoid needless string allocations when an identifier is
19731 used more than once (the common case).
19733 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19735 * pending.cs: MS's TypeBuilder.GetInterfaces ()
19736 is broken, it will not return anything. So, we
19737 have to use the information we have in mcs to
19740 * typemanager.cs: Add a cache for GetInterfaces,
19741 since this will now be used more often (due to ^^)
19743 (GetExplicitInterfaces) New method that gets the
19744 declared, not effective, interfaces on a type
19745 builder (eg, if you have interface IFoo, interface
19746 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
19749 This patch makes MCS able to bootstrap itself on
19752 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
19754 * expression.cs: Remove the Nop's that Miguel put
19757 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19759 * report.cs, codegen.cs: Give the real stack trace to
19760 the error when an exception is thrown.
19762 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19764 * decl.cs: only allocate hashtables for ifaces if
19767 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
19769 * expression.cs: fix the error from cs0121-2.cs
19770 (a parent interface has two child interfaces that
19771 have a function with the same name and 0 params
19772 and the function is called through the parent).
19774 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
19776 * class.cs, rootcontext.cs, typmanager.cs: do not
19779 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
19781 * codegen.cs: remove stack for the ec flow branching.
19782 It is already a linked list, so no need.
19784 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
19786 * Makefile: Allow custom profiler here.
19788 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19790 * typemanager.cs (LookupType):
19791 - Use a static char [], because split takes
19792 a param array for args, so it was allocating
19794 - Do not store true in a hashtable, it boxes.
19796 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
19798 * flowanalysis.cs: bytify common enums.
19800 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19802 * modifiers.cs: Add a new set of flags for the
19803 flags allowed on explicit interface impls.
19804 * cs-parser.jay: catch the use of modifiers in
19805 interfaces correctly.
19806 * class.cs: catch private void IFoo.Blah ().
19808 All related to bug #50572.
19810 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19812 * decl.cs: Rewrite the consistant accessability checking.
19813 Accessability is not linear, it must be implemented in
19814 a tableish way. Fixes #49704.
19816 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
19818 * expression.cs: Handle negation in a checked context.
19819 We must use subtraction from zero. Fixes #38674.
19821 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19823 * class.cs: Ignore static void main in DLLs.
19824 * rootcontext.cs: Handle the target type here,
19825 since we are have to access it from class.cs
19826 * driver.cs: account for the above.
19828 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
19830 * report.cs: Give line numbers and files if available.
19832 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
19834 * driver.cs: Implement /addmodule.
19836 * typemanager.cs: Change 'modules' field so it now contains Modules not
19839 2003-12-20 Martin Baulig <martin@ximian.com>
19841 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
19842 (FieldBase.IsAssigned): Removed this field.
19843 (FieldBase.SetAssigned): New public method.
19844 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
19846 2003-12-20 Martin Baulig <martin@ximian.com>
19848 * expression.cs (LocalVariableReference.DoResolve): Don't set
19849 `vi.Used' if we're called from DoResolveLValue().
19851 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
19852 returns the usage vector it just merged into the current one -
19853 pass this one to UsageWarning().
19854 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
19855 of the `EmitContext', don't call this recursively on our children.
19857 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
19859 * driver.cs: Implement /target:module.
19861 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
19863 * support.cs (CharArrayHashtable): New helper class.
19865 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
19866 char arrays, not strings, so we can avoid creating a string in
19867 consume_identifier if the identifier is a keyword.
19869 2003-12-16 Martin Baulig <martin@ximian.com>
19871 * statement.cs (LocalInfo.Assigned): Removed this property.
19872 (LocalInfo.Flags): Removed `Assigned'.
19873 (LocalInfo.IsAssigned): New public method; takes the EmitContext
19874 and uses flow analysis.
19875 (Block.UsageWarning): Made this method private.
19876 (Block.Resolve): Call UsageWarning() if appropriate.
19878 * expression.cs (LocalVariableReference.DoResolve): Always set
19879 LocalInfo.Used here.
19881 2003-12-13 Martin Baulig <martin@ximian.com>
19883 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
19884 any value here; we're now using flow analysis to figure out
19885 whether a statement/block returns a value.
19887 2003-12-13 Martin Baulig <martin@ximian.com>
19889 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
19891 (FlowBranching.MergeFinally): Don't call
19892 `branching.CheckOutParameters()' here, this is called in
19894 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
19895 when adding the `finally' vector.
19897 2003-12-13 Martin Baulig <martin@ximian.com>
19900 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
19901 actually work and also fix #48962.
19903 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
19905 * decl.cs: Do not check System.Object for nested types,
19906 since we know it does not have any. Big bang for buck:
19909 Run 1: 8.35 seconds
19910 Run 2: 8.32 seconds
19911 corlib: 17.99 seconds
19913 Run 1: 8.17 seconds
19914 Run 2: 8.17 seconds
19915 corlib: 17.39 seconds
19917 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
19919 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
19920 time we are returning 0 members, so we save alot here.
19922 2003-12-11 Martin Baulig <martin@ximian.com>
19924 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
19925 `MergeChild()', also just take the `FlowBranching' as argument;
19926 call Merge() on it and return the result.
19927 (FlowBranching.Merge): We don't need to do anything if we just
19930 2003-12-11 Martin Baulig <martin@ximian.com>
19932 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
19933 them in an `ArrayList' to reduce memory usage. Thanks to Ben
19934 Maurer for this idea.
19936 2003-12-11 Martin Baulig <martin@ximian.com>
19938 * flowanalysis.cs (MergeResult): This class is now gone; we now
19939 use the `UsageVector' for this. The reason for this is that if a
19940 branching just has one sibling, we don't need to "merge" them at
19941 all - that's the next step to do.
19942 (FlowBranching.Merge): We now return a `UsageVector' instead of a
19945 2003-12-11 Martin Baulig <martin@ximian.com>
19947 Reworked flow analyis and made it more precise and bug-free. The
19948 most important change is that we're now using a special `Reachability'
19949 class instead of having "magic" meanings of `FlowReturns'. I'll
19950 do some more cleanups and optimizations and also add some more
19951 documentation this week.
19953 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
19954 largely reworked this class.
19955 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
19956 the new `Reachability' class instead of having "magic" values here.
19957 (FlowBranching): We're now using an instance of `Reachability'
19958 instead of having separate `Returns', `Breaks' etc. fields.
19960 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
19961 based on flow analysis; ignore the return value of block.Emit ().
19963 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
19965 * driver.cs typemanager.cs: Find the mono extensions to corlib even
19966 if they are private.
19968 2003-12-09 Martin Baulig <martin@ximian.com>
19970 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
19971 call them directly on the UsageVector.
19973 2003-12-09 Martin Baulig <martin@ximian.com>
19975 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
19976 Changed return type from `FlowReturns' to `Reachability'.
19978 2003-12-09 Martin Baulig <martin@ximian.com>
19980 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
19981 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
19982 `Reachable' fields with a single `Reachability' one.
19984 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
19986 * class.cs (FindMembers): Remove foreach's.
19991 Run 1: 8.74 seconds
19992 Run 2: 8.71 seconds
19995 Run 1: 8.64 seconds
19996 Run 2: 8.58 seconds
19999 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20004 This patch does a few things:
20005 1. EmptyStatement is now a singleton, so it is never reallocated.
20006 2. All blah is EmptyStatement constructs have been changed to
20007 blah == EmptyStatement.Value, which is much faster and valid
20008 now that EmptyStatement is a singleton.
20009 3. When resolving a block, rather than allocating a new array for
20010 the non-empty statements, empty statements are replaced with
20011 EmptyStatement.Value
20012 4. Some recursive functions have been made non-recursive.
20013 Mainly the performance impact is from (3), however (1) and (2) are needed for
20014 this to work. (4) does not make a big difference in normal situations, however
20015 it makes the profile look saner.
20020 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20021 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20022 Total memory allocated: 56397 KB
20025 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20026 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20027 Total memory allocated: 55666 KB
20029 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20031 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20032 than the hashtable in a hashtable version
20034 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20035 we always end up concating a string. This results in a huge perf
20036 loss, because many strings have to be tracked by the GC. In this
20037 patch, we first use a hashtable that works with two keys, so that
20038 the strings do not need to be concat'ed.
20042 Run 1: 8.74 seconds
20043 Run 2: 8.71 seconds
20046 Run 1: 8.65 seconds
20047 Run 2: 8.56 seconds
20049 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20051 * Makefile: Add a new target `do-time' that does a quick and simple
20052 profile, leaving easy to parse output.
20054 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20056 * codegen.cs (Init): Create the dynamic assembly with
20057 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20059 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20061 * support.cs: Make the PtrHashtable use only one
20062 instance of its comparer.
20064 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20066 * typemanager.cs: Fix lookup of GetNamespaces.
20068 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20070 * expression.cs: Removed redundant line.
20072 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20073 ArrayLists, use for loops with bounds.
20075 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20078 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20079 arraylists, use for loop with bounds.
20081 The above three changes give us a 0.071 second performance
20082 improvement out of 3.294 seconds down to 3.223. On my machine
20083 the above changes reduced the memory usage by 1,387 KB during
20084 compiler bootstrap.
20086 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20087 QualifiedIdentifiers. Before we created a new string through
20088 concatenation, and mostly later on, the result would be
20089 manipulated by DecomposeQI through string manipulation.
20091 This reduced the compiler memory usage for bootstrapping from
20092 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20093 compile times in 0.05 seconds.
20095 2003-11-28 Dick Porter <dick@ximian.com>
20097 * support.cs: Do string compares with the Invariant culture.
20105 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20106 the comparison is done with the Invariant culture.
20108 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20110 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20111 GetEnumerator method.
20113 (ProbeCollectionType): Iterate starting at the most specific type
20114 upwards looking for a GetEnumerator
20116 * expression.cs: Shift count can be up to 31 for int/uint and 63
20119 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20121 * statement.cs (Block.LookupLabel): Also look for the label on the
20122 children blocks. Use a hash table to keep track of visited
20125 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20126 we actually did transform the other operand, otherwise fall back
20127 to the common codepath that casts to long.
20129 * cs-tokenizer.cs: Use the same code pattern as the int case.
20130 Maybe I should do the parsing myself, and avoid depending on the
20131 Parse routines to get this done.
20133 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20135 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20136 which fixes bug 51347. This time test it.
20138 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20139 attributes for example can not tell the difference between these.
20140 The difference was only a syntax feature of the language.
20142 * attribute.cs: Apply attributes to delegates.
20144 * delegate.cs: Call the apply attributes method.
20146 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20148 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20149 comparing 0 vs Byte.MinValue, not the value
20151 (ImplicitConversionRequired): When reporting a conversion error,
20152 use error 31 to print out the constant error instead of the
20155 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20156 which fixes bug 51347.
20158 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20160 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20161 which fixes the -warnaserror command line option.
20163 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20165 * cfold.cs (DoNumericPromotions): During constant folding of
20166 additions on UIntConstant, special case intconstants with
20167 IntConstants like we do on the expression binary operator.
20169 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20171 * convert.cs (ImplicitReferenceConversion): We were missing a case
20172 (System.Enum are not value types or class types, so we need to
20173 classify them separatedly).
20175 * driver.cs: We do not support error 2007.
20177 2003-11-12 Jackson Harper <jackson@ximian.com>
20179 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20180 system directory. Also use the full file name so users can
20181 libraries names mscorlib-o-tron.dll in a non system dir.
20183 2003-11-10 Martin Baulig <martin@ximian.com>
20185 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20186 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20187 calling `ResolveType()' on them, directly assign their `Type'.
20189 2003-11-08 Martin Baulig <martin@ximian.com>
20191 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20192 return value and the `out parent' parameter.
20193 (TypeContainer.DefineType): Moved the CS0644 check into
20194 GetClassBases(). Don't pass the interface types to the
20195 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20196 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20198 * ecore.cs (TypeExpr.IsAttribute): New property.
20199 (TypeExpr.GetInterfaces): New method.
20201 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20202 TypeExpr instead of a Type.
20203 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20204 (Interface.DefineType): Don't pass the interface types to the
20205 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20206 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20208 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20209 instead of a `Type[]'.
20210 (TypeManager.RegisterBuilder): Likewise.
20211 (TypeManager.AddUserInterface): Likewise.
20212 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20213 `Type[]' and also return a `TypeExpr[]'.
20214 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20216 2003-11-08 Martin Baulig <martin@ximian.com>
20218 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20221 2003-11-08 Martin Baulig <martin@ximian.com>
20223 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20224 TypeManager.ResolveExpressionTypes().
20226 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20227 instead of an Expression.
20228 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20229 (TypeExpression): New public class; formerly known as `TypeExpr'.
20231 * expression.cs (ComposedCast): Derive from TypeExpr.
20233 * typemanager.cs (TypeManager.system_*_expr): These are now
20234 TypExpr's instead of Expression's.
20235 (TypeManager.ResolveExpressionTypes): New public static function;
20236 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20239 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20241 * expression.cs (New.DoResolve): Do not dereference value that
20242 might be a null return.
20244 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20245 sure that the constant value has the right type. Fixes an
20246 unreported bug, similar to 50425.
20248 * const.cs (Const.LookupConstantValue): Call
20249 ImplicitStandardConversionExists before doing a conversion to
20250 avoid havng the TypeManager.ChangeType do conversions.
20252 Reduced the number of casts used
20254 (Const.ChangeType): New routine to enable reuse of the constant
20255 type changing code from statement.
20257 * typemanager.cs (ChangeType): Move common initialization to
20258 static global variables.
20262 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20263 every value type to go through, even if it was void. Fix that.
20265 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20266 character of the define, and the is_identifier_part_character for
20267 the rest of the string.
20269 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20271 * expression.cs (UnaryMutator.EmitCode): When I updated
20272 LocalVariableReference.DoResolve, I overdid it, and dropped an
20273 optimization done on local variable references.
20275 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20277 * ecore.cs: Convert the return from Ldlen into an int.
20279 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20281 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20282 the accessibility, this is a special case for toplevel non-public
20283 classes (internal for instance).
20285 2003-10-20 Nick Drochak <ndrochak@gol.com>
20287 * ecore.cs: Fix typo and build. Needed another right paren.
20289 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20291 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20292 `internal' case regular and protected, but not allowing protected
20293 to be evaluated later. Bug 49840
20295 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20297 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20298 to kb.Nlast, and not the kb.nFirst to isolate the switch
20301 Extract the underlying type, so enumerations of long/ulong are
20302 treated like long/ulong.
20304 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20306 * expression.cs (New): Overload the meaning of RequestedType to
20307 track the possible creation of the NewDelegate type, since
20308 DoResolve is invoked more than once for new constructors on field
20311 See bugs: #48800 and #37014
20313 * cs-parser.jay (declare_local_constants): Take an arraylist
20314 instead of a single constant.
20316 (local_constant_declaration): It should take a
20317 constant_declarators, not a constant_declarator. Fixes 49487
20319 * convert.cs: Fix error report.
20321 2003-10-13 Jackson Harper <jackson@ximian.com>
20323 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20326 2003-10-09 Martin Baulig <martin@ximian.com>
20328 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20330 (MethodCore.DoDefineParameters): Removed the TypeContainer
20331 argument; use the DeclSpace which was passed to the .ctor instead.
20332 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20333 TypeContainer; we only need a DeclSpace here.
20335 2003-10-09 Martin Baulig <martin@ximian.com>
20337 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20339 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20340 EmitContext's .ctor.
20342 2003-10-09 Martin Baulig <martin@ximian.com>
20344 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20345 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20346 AsAccessible(), moved them as well.
20348 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20350 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20352 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20354 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20356 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20357 generation for >=, as spotted by Paolo, bug 48679.
20358 Patch from David Waite.
20360 * cs-tokenizer.cs: Add handling for #pragma.
20362 * cs-parser.jay: Allow for both yield and yield return in the
20363 syntax. The anti-cobolization of C# fight will go on!
20365 * class.cs (TypeBuilder.DefineType): Catch error condition here
20366 (Parent.DefineType erroring out and returning null).
20368 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20369 coping with enumerations variables, we were mistakenly processing
20370 them as a regular value type instead of built-in types. Fixes the
20373 * typemanager.cs (IsBuiltinOrEnum): New method.
20375 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20377 * cs-parser.jay: Upgrade: yield now needs the return clause.
20379 2003-09-19 Martin Baulig <martin@ximian.com>
20381 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20382 `MemberCache parent' argument. Normally, an interface doesn't
20383 have a parent type except System.Object, but we use this in gmcs
20384 for generic type parameters.
20386 2003-09-18 Martin Baulig <martin@ximian.com>
20388 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20389 on `type.IsInterface'; don't check whether the type has a parent
20390 to determine whether it's an interface.
20392 2003-09-15 Martin Baulig <martin@ximian.com>
20394 * class.cs (TypeContainer.DefineType): Added an error flag to
20395 avoid reporting duplicate CS0146's ("class definition is
20398 * driver.cs (Driver.MainDriver): Abort if
20399 RootContext.ResolveTree() reported any errors.
20401 2003-09-07 Martin Baulig <martin@ximian.com>
20403 * report.cs (Error, Warning): Added overloaded versions which take
20404 a `params object[] args' and call String.Format().
20406 2003-09-07 Martin Baulig <martin@ximian.com>
20408 * decl.cs (DeclSpace..ctor): Don't call
20409 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20410 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20411 (DeclSpace.RecordDecl): New method.
20413 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20415 2003-09-02 Ravi Pratap <ravi@ximian.com>
20417 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20418 value attributes to be applied to ParameterBuilders.
20420 * class.cs (MethodCore.LabelParameters): Make static and more
20421 generic so that it can be used from other places - like interface
20422 methods, for instance.
20424 * interface.cs (Interface.Emit): Call LabelParameters before
20425 emitting attributes on the InterfaceMethod.
20427 2003-08-26 Martin Baulig <martin@ximian.com>
20429 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20430 resolving aliases; fixes #47927.
20432 2003-08-26 Martin Baulig <martin@ximian.com>
20434 * statement.cs (Using.DoResolve): This is internally emitting a
20435 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20436 do not always return. Fixes #47681.
20438 2003-08-26 Martin Baulig <martin@ximian.com>
20440 * decl.cs (MemberCore): Moved WarningNotHiding(),
20441 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20443 (AdditionResult): Make this nested in DeclSpace.
20444 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20445 argument; call NamespaceEntry.Define() unless we're nested in a
20448 * namespace.cs (Namespace.DefineName): New public function. This
20449 is called from DeclSpace's .ctor to add
20450 (Namespace.Lookup): Include DeclSpaces in the lookup.
20452 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20454 * const.cs (Const): Derive from MemberBase, not MemberCore.
20456 2003-08-25 Martin Baulig <martin@ximian.com>
20458 * convert.cs (Convert.ExplicitReferenceConversion): When
20459 converting from an interface type to a class, unbox if the target
20460 type is a struct type. Fixes #47822.
20462 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20464 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20467 2003-08-22 Martin Baulig <martin@ximian.com>
20469 * class.cs (TypeManager.DefineType): When defining a nested type,
20470 call DefineType() on our parent; fixes #47801.
20472 2003-08-22 Martin Baulig <martin@ximian.com>
20474 * class.cs (MethodData.Define): While checking if a method is an
20475 interface implementation, improve the test a bit more to fix #47654.
20477 2003-08-22 Martin Baulig <martin@ximian.com>
20479 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20480 correctly; fixes #47722.
20482 2003-08-22 Martin Baulig <martin@ximian.com>
20484 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20485 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20487 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20489 2003-08-22 Martin Baulig <martin@ximian.com>
20491 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20492 can only be assigned in static constructors. Fixes #47161.
20494 2003-08-22 Martin Baulig <martin@ximian.com>
20496 Rewrote and improved the flow analysis code.
20498 * flowbranching.cs (FlowBranching): Make this class abstract.
20499 (FlowBranching.CreateBranching): New static function to create a
20500 new flow branching.
20501 (FlowBranchingBlock, FlowBranchingException): New classes.
20502 (FlowBranching.UsageVector.Type): New public readonly field.
20503 (FlowBranching.UsageVector.Breaks): Removed the setter.
20504 (FlowBranching.UsageVector.Returns): Removed the setter.
20505 (FlowBranching.UsageVector): Added Break(), Return(),
20506 NeverReachable() and Throw() methods to modify the reachability.
20507 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20508 done by FlowBranching.Merge().
20509 (FlowBranching.UsageVector.MergeChild): New method; merges the
20510 merge result into the current vector.
20511 (FlowBranching.Merge): New abstract method to merge a branching.
20513 2003-08-12 Martin Baulig <martin@ximian.com>
20515 * expression.cs (Indirection.CacheTemporaries): Create the
20516 LocalTemporary with the pointer type, not its element type.
20518 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20520 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20521 token was a keyword or not.
20523 Add `error' options where an IDENTIFIER was expected; Provide
20524 CheckToken and CheckIdentifierToken convenience error reporting
20527 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20529 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20530 NameSpaceEntry NameSpaceEntry.
20532 (LookupInterfaceOrClass): Avoid creating a full qualified name
20533 from namespace and name: avoid doing lookups when we know the
20534 namespace is non-existant. Use new Tree.LookupByNamespace which
20535 looks up DeclSpaces based on their namespace, name pair.
20537 * driver.cs: Provide a new `parser verbose' to display the
20538 exception thrown during parsing. This is turned off by default
20539 now, so the output of a failure from mcs is more graceful.
20541 * namespace.cs: Track all the namespaces defined in a hashtable
20544 (IsNamespace): New method
20546 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20548 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20549 we know that we need to concatenate (full typename can never be
20554 * statement.cs: Use a bitfield; Do not initialize to null things
20555 which are done by the constructor by default.
20557 * cs-parser.jay: bug fix, parameter was 4, not 3.
20559 * expression.cs: Just use the property;
20561 * statement.cs: No need for GetVariableInfo method.
20563 2003-08-08 Martin Baulig <martin@ximian.com>
20565 * flowanalysis.cs (FlowReturns): This is now nested in the
20566 `FlowBranching' class.
20567 (MyBitVector): Moved this here from statement.cs.
20568 (FlowBranching.SiblingType): New enum type.
20569 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20571 2003-08-07 Martin Baulig <martin@ximian.com>
20573 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20574 `FlowBranching' class and called `BranchingType'.
20576 2003-08-07 Martin Baulig <martin@ximian.com>
20578 * flowanalysis.cs: Moved all the control flow analysis code into
20581 2003-08-07 Martin Baulig <martin@ximian.com>
20583 * assign.cs (Assign.DoResolve): `target' must either be an
20584 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20587 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20589 * expression.cs (BinaryMethod): This kind of expression is created by the
20590 Binary class if it determines that the operator has to be handled
20593 (BinaryDelegate): This kind of expression is created if we are
20594 dealing with a + or - operator on delegates.
20596 (Binary): remove method, argumetns, and DelegateOperator: when
20597 dealing with methods,
20599 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
20601 * statement.cs (Block): use bitfields for the three extra booleans
20602 we had in use. Remove unused topblock parameter.
20604 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
20606 * assign.cs: Drop extra unneeded tests.
20608 2003-08-06 Miguel de Icaza <miguel@ximian.com>
20610 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
20612 * statement.cs (Foreach): Use VariableStorage instead of
20615 * codegen.cs (VariableStorage): New class used by clients that
20616 require a variable stored: locals or fields for variables that
20617 need to live across yield.
20619 Maybe provide a convenience api for EmitThis+EmitLoad?
20621 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
20624 2003-08-05 Miguel de Icaza <miguel@ximian.com>
20626 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
20627 RemapParameterLValue): New methods that are used to turn a
20628 precomputed FieldInfo into an expression like this:
20632 The idea is to use this instead of making LocalVariableReference
20633 have more than one meaning.
20635 * cs-parser.jay: Add error production to BASE.
20637 * ecore.cs: Deal with TypeManager.GetField returning null, which
20638 is now a valid return value.
20640 (FieldExprNoAddress): New expression for Fields whose address can
20643 * expression.cs (LocalVariableReference): During the resolve
20644 phases, create new expressions if we are in a remapping context.
20645 Remove code that dealt with remapping here.
20647 (ParameterReference): same.
20649 (ProxyInstance): New expression, like the `This' expression, but
20650 it is born fully resolved. We know what we are doing, so remove
20651 the errors that are targeted to user-provided uses of `this'.
20653 * statement.cs (Foreach): our variable is now stored as an
20654 Expression; During resolution, follow the protocol, dont just
20655 assume it will return this.
20657 2003-08-06 Martin Baulig <martin@ximian.com>
20659 * support.cs (SeekableStreamReader.cs): New public class.
20661 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
20662 SeekableStreamReader instead of the normal StreamReader.
20664 2003-08-04 Martin Baulig <martin@ximian.com>
20666 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
20667 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
20668 deambiguate casts and delegate invocations.
20669 (parenthesized_expression): Use the new tokens to ensure this is
20670 not a cast of method invocation.
20672 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
20673 when reading a `)' and Deambiguate_CloseParens () was previously
20676 * expression.cs (ParenthesizedExpression): New class. This is
20677 just used for the CS0075 test.
20678 (Binary.DoResolve): Check for CS0075.
20680 2003-07-29 Ravi Pratap <ravi@ximian.com>
20682 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
20683 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
20684 reference comparison.
20686 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
20687 examine the ReturnType for equality - this is necessary in the
20688 cases of implicit and explicit operators whose signature also
20689 includes the return type.
20691 2003-07-26 Miguel de Icaza <miguel@ximian.com>
20693 * namespace.cs: Cache the result of the namespace computation,
20694 instead of computing it every time.
20696 2003-07-24 Miguel de Icaza <miguel@ximian.com>
20698 * decl.cs: Use a global arraylist that we reuse over invocations
20699 to avoid excesive memory consumption. Reduces memory usage on an
20700 mcs compile by one meg (45 average).
20702 * typemanager.cs (LookupTypeReflection): In .NET pointers are
20703 private, work around that.
20705 2003-07-23 Miguel de Icaza <miguel@ximian.com>
20707 * literal.cs (IntLiteral): Define Zero and One static literals.
20709 * cs-parser.jay (integer_literal): use static literals to reduce
20710 memory usage for the most used literals (0, 1 and -1). 211kb
20711 reduced in memory usage.
20713 Replace all calls to `new ArrayList' with `new
20714 ArrayList(4)' which is a good average number for most allocations,
20715 and also requires only 16 bytes of memory for its buffer by
20718 This reduced MCS memory usage in seven megabytes for the RSS after
20721 2003-07-28 Ravi Pratap <ravi@ximian.com>
20723 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
20724 handle params methods the correct way by forming only one
20725 applicable set with params and normal methods in them. Earlier we
20726 were looking at params methods only if we found no normal methods
20727 which was not the correct thing to do.
20729 (Invocation.BetterFunction): Take separate arguments indicating
20730 when candidate and the best method are params methods in their
20733 This fixes bugs #43367 and #46199.
20735 * attribute.cs: Documentation updates.
20737 (CheckAttribute): Rename to CheckAttributeTarget.
20738 (GetValidPlaces): Rename to GetValidTargets.
20740 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
20741 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
20745 2003-07-28 Martin Baulig <martin@ximian.com>
20747 * class.cs (TypeContainer.DefineMembers): Use the base type's full
20748 name when looking up the base class of a nested class. Fixes #46977.
20750 2003-07-26 Martin Baulig <martin@ximian.com>
20752 * expression.cs (Indexers.Indexer): New nested struct; contains
20753 getter, setter and the indexer's type.
20754 (Indexers.Properties): This is now an ArrayList of
20755 Indexers.Indexer's.
20756 (IndexerAccess.DoResolveLValue): Correctly set the type if the
20757 indexer doesn't have any getters.
20759 * assign.cs (Assign.DoResolve): Also do the implicit conversions
20760 for embedded property and indexer assignments.
20762 2003-07-26 Martin Baulig <martin@ximian.com>
20764 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
20765 preprocessor directive is not the first non-whitespace character
20768 2003-07-26 Martin Baulig <martin@ximian.com>
20770 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
20771 namespace parsing, follow the spec more closely.
20773 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
20774 NamespaceEntry.Lookup().
20776 2003-07-25 Martin Baulig <martin@ximian.com>
20778 * MethodCore.cs (OverridesSomething): New public field; it's set
20779 from TypeContainer.DefineMembers if this method overrides
20780 something (which doesn't need to be a method). Fix #39462.
20782 2003-07-25 Ravi Pratap <ravi@ximian.com>
20784 * typemanager.cs (GetMembers): Ensure that the list of members is
20785 reversed. This keeps things in sync.
20787 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
20788 find an AttributeUsage attribute.
20790 * expression.cs (Invocation.OverloadResolve): Perform the check
20791 which disallows Invoke to be directly called on a Delegate.
20793 (Error_InvokeOnDelegate): Report error cs1533.
20795 2003-07-25 Martin Baulig <martin@ximian.com>
20797 * expression.cs (Indexers.GetIndexersForType): Only look in the
20798 interface hierarchy if the requested type is already an
20799 interface. Fixes #46788 while keeping #46502 fixed.
20801 2003-07-25 Martin Baulig <martin@ximian.com>
20803 * class.cs (TypeContainer.DefineMembers): Check whether all
20804 readonly fields have been assigned and report warning CS0649 if
20807 * statement.cs (LocalInfo.IsFixed): Always return true if this is
20810 2003-07-24 Ravi Pratap <ravi@ximian.com>
20812 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
20813 returned from GetMethods to make things consistent with the
20814 assumptions MCS makes about ordering of methods.
20816 This should comprehensively fix bug #45127 and it does :-)
20818 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
20819 ordering is actually reverse.
20821 * Clean up some debug messages I left lying around.
20823 * interface.cs (Populate*): Get rid of code which emits attributes
20824 since the stage in which we emit attributes is the 'Emit' stage,
20825 not the define stage.
20827 (Emit): Move attribute emission for interface members here.
20829 2003-07-22 Ravi Pratap <ravi@ximian.com>
20831 * expression.cs (Invocation.OverloadResolve): Follow the spec more
20832 closely: we eliminate methods in base types when we have an
20833 applicable method in a top-level type.
20835 Please see section 14.5.5.1 for an exact description of what goes
20838 This fixes bug #45127 and a host of other related to corlib compilation.
20840 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
20841 array is the method corresponding to the top-level type (this is
20842 because of the changes made to icall.c) so we change this
20845 (MethodGroupExpr.Name): This too.
20847 * typemanager.cs (GetElementType): New method which does the right
20848 thing when compiling corlib.
20850 * everywhere: Make use of the above in the relevant places.
20852 2003-07-22 Martin Baulig <martin@ximian.com>
20854 * cs-parser.jay (invocation_expression): Moved
20855 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
20856 `cast_expression', but create a InvocationOrCast which later
20857 resolves to either an Invocation or a Cast.
20859 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
20860 method; call this before EmitStatement() to make sure that this
20861 expression can be used as a statement.
20863 * expression.cs (InvocationOrCast): New class; resolves to either
20864 an Invocation or a Cast.
20866 * statement.cs (StatementExpression): Call ResolveStatement() on
20867 the ExpressionStatement before emitting it.
20869 2003-07-21 Martin Baulig <martin@ximian.com>
20871 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
20872 `ref' and `out' attributes match; fixes #46220.
20873 (MemberAccess.ResolveMemberAccess): You can't reference a type
20874 through an expression; fixes #33180.
20875 (Indexers.GetIndexersForType): Don't return the indexers from
20876 interfaces the class implements; fixes #46502.
20878 2003-07-21 Martin Baulig <martin@ximian.com>
20880 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
20881 CS0661 checks; fixes bug #30442.
20883 2003-07-21 Martin Baulig <martin@ximian.com>
20885 * decl.cs (AdditionResult): Added `Error'.
20887 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
20889 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
20890 makes cs0031.cs actually work.
20892 2003-07-20 Martin Baulig <martin@ximian.com>
20894 * namespace.cs: Fixed that bug which caused a crash when compiling
20895 the debugger's GUI.
20897 2003-07-20 Miguel de Icaza <miguel@ximian.com>
20899 * typemanager.cs (LookupTypeReflection): Never expose types which
20900 are NotPublic, NestedPrivate, NestedAssembly, or
20901 NestedFamANDAssem. We used to return these, and later do a check
20902 that would report a meaningful error, but the problem is that we
20903 would not get the real match, if there was a name override.
20905 2003-07-18 Miguel de Icaza <miguel@ximian.com>
20907 * namespace.cs (Namespace, Name): Do not compute the namespace
20908 name dynamically, compute it in the constructor. This reduced
20909 memory usage by 1697 KB.
20911 * driver.cs: Use --pause to pause at the end.
20913 2003-07-17 Peter Williams <peter@newton.cx>
20915 * Makefile: Change the name of the test target so that it doesn't
20916 conflict with the recursive test target.
20918 2003-07-17 Miguel de Icaza <miguel@ximian.com>
20920 * expression.cs (LocalVariableReference.Emit, EmitAssign,
20921 AddressOf): Do not use EmitThis, that was wrong, use the actual
20924 2003-07-15 Miguel de Icaza <miguel@ximian.com>
20926 * class.cs (MethodData.Define): While checking if a method is an
20927 interface implementation, improve the test: If we are not public
20928 (use new test here: use the computed MethodAttributes directly,
20929 instead of the parsed modifier flags) check if the `implementing'
20930 method comes from an interface or not.
20932 * pending.cs (VerifyPendingMethods): Slightly better error
20935 * makefile: add test target that does the mcs bootstrap.
20937 2003-07-16 Ravi Pratap <ravi@ximian.com>
20939 * interface.cs (Define): Do nothing here since there are no
20940 members to populate etc. Move the attribute emission out of here
20941 since this was just totally the wrong place to put it. Attribute
20942 application happens during the 'Emit' phase, not in the 'Define'
20945 (Emit): Add this method and move the attribute emission here
20947 * rootcontext.cs (EmitCode): Call the Emit method on interface
20950 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20952 * expression.cs (OverloadResolve): Report error only if Location
20953 is not 'Null' which means that there was a probe going on.
20955 2003-07-14 Martin Baulig <martin@ximian.com>
20957 * expression.cs (ConditionalLogicalOperator): New public class to
20958 implement user defined conditional logical operators.
20959 This is section 14.11.2 in the spec and bug #40505.
20961 2003-07-14 Martin Baulig <martin@ximian.com>
20963 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
20965 2003-07-14 Martin Baulig <martin@ximian.com>
20967 * codegen.cs (EmitContext.InFixedInitializer): New public field.
20969 * ecore.cs (IVariable.VerifyFixed): New interface method.
20971 * expression.cs (Unary.ResolveOperator): When resolving the `&'
20972 operator, check whether the variable is actually fixed. Fixes bug
20973 #36055. Set a variable definitely assigned when taking its
20974 address as required by the spec.
20976 * statement.cs (LocalInfo.IsFixed): New field.
20977 (LocalInfo.MakePinned): Set `IsFixed' to true.
20979 2003-07-14 Ravi Pratap M <ravi@ximian.com>
20981 * attribute.cs (Attribute.Resolve): While doing a Member lookup
20982 for .ctors, ensure that we only ask for members declared in the
20983 attribute type (BindingFlags.DeclaredOnly).
20987 * expression.cs (Error_WrongNumArguments): Report error 1501
20988 correctly the way CSC does.
20990 2003-07-13 Martin Baulig <martin@ximian.com>
20992 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
20993 lookup on the fully qualified name, to make things like "X.X" work
20994 where "X.X" is a fully qualified type name, but we also have a
20995 namespace "X" in the using list. Fixes #41975.
20997 2003-07-13 Martin Baulig <martin@ximian.com>
20999 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21000 function. If we're a CompoundAssign, we need to create an embedded
21001 CompoundAssign, not an embedded Assign.
21002 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21005 2003-07-13 Martin Baulig <martin@ximian.com>
21007 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21008 work to fix bug #46088.
21010 2003-07-13 Ravi Pratap <ravi@ximian.com>
21012 * class.cs (Operator.Emit): Do not emit attributes here - it is
21013 taken care of by the Method class that we delegate too. This takes
21014 care of bug #45876.
21016 2003-07-10 Martin Baulig <martin@ximian.com>
21018 * expression.cs (TypeOfVoid): New class.
21019 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21021 2003-07-10 Martin Baulig <martin@ximian.com>
21023 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21026 2003-07-10 Martin Baulig <martin@ximian.com>
21028 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21029 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21031 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21033 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21035 2003-07-10 Martin Baulig <martin@ximian.com>
21037 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21038 of decimal. Fixes #42850.
21040 NOTE: I also fixed the created byte blob, but this doesn't work on
21041 the MS runtime and csc never produces any byte blobs for decimal
21044 2003-07-10 Martin Baulig <martin@ximian.com>
21046 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21047 structs; fixes #32068.
21048 (Block.AddChildVariableNames): Fixed #44302.
21050 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21052 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21054 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21056 * attribute.cs: And this test is onger needed.
21058 2003-07-08 Martin Baulig <martin@ximian.com>
21060 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21061 inaccessible types. Fixes #36313.
21063 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21065 * namespace.cs (NamespaceEntry): Create implicit entries for all
21066 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21067 implicit entries for N1.N2 and N1.
21069 2003-07-08 Martin Baulig <martin@ximian.com>
21071 Rewrote the handling of namespaces to fix a lot of the issues
21072 wrt. `using' aliases etc.
21074 * namespace.cs (Namespace): Splitted this class into a
21075 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21077 * typemanager.cs (TypeManager.IsNamespace): Removed.
21078 (TypeManager.ComputeNamespaces): Only compute namespaces from
21079 loaded assemblies here, not the namespaces from the assembly we're
21080 currently compiling.
21082 2003-07-08 Martin Baulig <martin@ximian.com>
21084 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21086 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21088 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21091 I thought about the memory savings here, but LookupTypeReflection
21092 is used under already very constrained scenarios. Compiling
21093 corlib or mcs only exposes one hit, so it would not really reduce
21094 any memory consumption.
21096 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21098 * typemanager.cs: fixes bug #45889 by only adding public types from
21099 other assemblies to the list of known types.
21101 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21103 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21104 on the type we resolved.
21106 2003-07-05 Martin Baulig <martin@ximian.com>
21108 * pending.cs (PendingImplementation.ParentImplements): Don't
21109 create the proxy if the parent is abstract.
21111 * class.cs (TypeContainer.DefineIndexers): Process explicit
21112 interface implementations first. Fixes #37714.
21114 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21116 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21117 defined recursively; but since we modify the input parameters
21118 (left is set to `this' temporarily), we reset this value if the
21119 left_is_explicit is false, which gives the original semantics to
21122 * literal.cs (NullPointer): new class used to represent a null
21123 literal in a pointer context.
21125 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21126 type is a pointer, use a NullPointer object instead of a
21127 NullLiteral. Closes 43687
21129 (ExplicitConversion): Convert pointer values using
21130 the conv opcode to the proper type.
21132 * ecore.cs (New): change ValueTypeVariable property into a method,
21133 that returns whether the valuetype is suitable for being used.
21135 * expression.cs (Binary.DoNumericPromotions): Only return if we
21136 the int constant was a valid uint, and we can return both left and
21137 right as uints. If not, we continue processing, to trigger the
21138 type conversion. This fixes 39018.
21140 * statement.cs (Block.EmitMeta): During constant resolution, set
21141 the CurrentBlock property on the emitcontext, so that we resolve
21142 constants propertly.
21144 2003-07-02 Martin Baulig <martin@ximian.com>
21146 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21147 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21149 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21150 than emitting it here.
21152 * statement.cs: Fixed some more flow analysis bugs.
21154 2003-07-02 Martin Baulig <martin@ximian.com>
21156 * class.cs (MethodData.Define): When implementing interface
21157 methods, set Final unless we're Virtual.
21159 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21160 check work for interface methods.
21162 2003-07-01 Martin Baulig <martin@ximian.com>
21164 * ecore.cs (EmitContext.This): Replaced this property with a
21165 GetThis() method which takes a Location argument. This ensures
21166 that we get the correct error location for a CS0188.
21168 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21170 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21171 ImplicitStandardConversion.
21173 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21175 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21177 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21180 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21182 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21185 (MethodData.Define): Turn off initlocals for unsafe methods.
21187 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21189 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21190 complete; Fixes #37521.
21192 * delegate.cs: Use Modifiers.TypeAttr to compute the
21193 TypeAttributes, instead of rolling our own. This makes the flags
21194 correct for the delegates.
21196 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21198 * class.cs (Constructor.Define): Set the private flag for static
21199 constructors as well.
21201 * cs-parser.jay (statement_expression): Set the return value to
21202 null, to avoid a crash when we catch an error.
21204 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21206 * cs-parser.jay: Applied patch from Jackson that adds support for
21207 extern and unsafe modifiers to destructor declarations.
21209 * expression.cs: Report error 21 if the user is trying to index a
21212 * driver.cs: Add an error message, suggested by the bug report.
21214 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21215 if we do not have a ": this ()" constructor initializer. Fixes 45149
21217 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21219 * namespace.cs: Add some information to reduce FAQs.
21221 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21223 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21224 underlying enumeration types. Fixes #43915.
21226 * expression.cs: Treat ushort/short as legal values to be used in
21227 bitwise operations.
21229 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21231 * delegate.cs: transfer custom attributes for paramenters from
21232 the delegate declaration to Invoke and BeginInvoke.
21234 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21236 * attribute.cs: handle custom marshalers and emit marshal info
21239 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21241 * makefile.gnu: Added anonymous.cs to the compiler sources.
21243 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21245 * iterators.cs: Change the name of the proxy class to include two
21248 * cs-parser.jay: Update grammar to include anonymous methods.
21250 * anonymous.cs: new file.
21252 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21254 * class.cs (Field.Define): Add missing test for pointers and
21257 2003-05-27 Ravi Pratap <ravi@ximian.com>
21259 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21260 we use the stobj opcode.
21262 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21263 since it wasn't the correct fix.
21265 It still is puzzling that we are required to use stobj for IntPtr
21266 which seems to be a ValueType.
21268 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21270 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21271 during regular simple name resolution. Now, the trick is that
21272 instead of returning for processing the simplename, we do a
21273 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21274 contextual lookup type). If a match is found, return that, if
21275 not, return for further composition.
21277 This fixes long-standing 30485.
21279 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21280 using the address to initialize an object, do an Stobj instead of
21281 using the regular Stelem.
21283 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21284 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21285 Because if we are a BaseIndexerAccess that value will be true.
21288 * statement.cs (GotoCase.Resolve): Return after reporting an
21289 error, do not attempt to continue.
21291 * expression.cs (PointerArithmetic.Emit): If our operand is a
21292 long, convert our constants to match the operand before
21293 multiplying. Convert to I type before adding. Fixes 43670.
21295 2003-05-14 Ravi Pratap <ravi@ximian.com>
21297 * enum.cs (ImplicitConversionExists) : Rename to
21298 ImplicitEnumConversionExists to remove ambiguity.
21300 * ecore.cs (NullCast): New type of cast expression class which
21301 basically is very similar to EmptyCast with the difference being
21302 it still is a constant since it is used only to cast a null to
21304 (eg. (string) null)
21306 * convert.cs (ImplicitReferenceConversion): When casting a null
21307 literal, we return a NullCast.
21309 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21310 should be around anymore.
21312 The renaming (reported was slightly wrong). Corrections:
21314 ConvertImplicitStandard -> ImplicitConversionStandard
21315 ConvertExplicitStandard -> ExplicitConversionStandard
21317 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21318 before passing them in !
21320 * convert.cs (ImplicitConversionStandard): When comparing for
21321 equal expr and target types, ensure that expr is not a
21324 In general, we must not be checking (expr_type ==
21325 target_type) in the top level conversion methods
21326 (ImplicitConversion, ExplicitConversion etc). This checking is
21327 done in the methods that they delegate to.
21329 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21331 * convert.cs: Move Error_CannotConvertType,
21332 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21333 ImplicitNumericConversion, ImplicitConversionExists,
21334 ImplicitUserConversionExists, StandardConversionExists,
21335 FindMostEncompassedType, FindMostSpecificSource,
21336 FindMostSpecificTarget, ImplicitUserConversion,
21337 ExplicitUserConversion, GetConversionOperators,
21338 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21339 TryImplicitIntConversion, Error_CannotConvertImplicit,
21340 ConvertImplicitRequired, ConvertNumericExplicit,
21341 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21342 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21345 Perform the following renames:
21347 StandardConversionExists -> ImplicitStandardConversionExists
21348 ConvertImplicit -> ImplicitConversion
21349 ConvertImplicitStandard -> ImplicitStandardConversion
21350 TryImplicitIntConversion -> ImplicitIntConversion
21351 ConvertImplicitRequired -> ImplicitConversionRequired
21352 ConvertNumericExplicit -> ExplicitNumericConversion
21353 ConvertReferenceExplicit -> ExplicitReferenceConversion
21354 ConvertExplicit -> ExplicitConversion
21355 ConvertExplicitStandard -> ExplicitStandardConversion
21357 2003-05-19 Martin Baulig <martin@ximian.com>
21359 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21360 (TypeInfo): Added support for structs having structs as fields.
21362 * ecore.cs (FieldExpr): Implement IVariable.
21363 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21364 VariableInfo for the field.
21366 2003-05-18 Martin Baulig <martin@ximian.com>
21368 * expression.cs (This.DoResolve): Report a CS0027 if we're
21369 emitting a field initializer.
21371 2003-05-18 Martin Baulig <martin@ximian.com>
21373 * expression.cs (This.ResolveBase): New public function.
21374 (This.DoResolve): Check for CS0188.
21376 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21379 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21380 `instance_expression' to null if we don't have any non-static
21383 2003-05-18 Martin Baulig <martin@ximian.com>
21385 Reworked the way how local variables and parameters are handled by
21386 the flow analysis code.
21388 * statement.cs (TypeInfo, VariableMap): New public classes.
21389 (VariableInfo): New public class. This is now responsible for
21390 checking whether a variable has been assigned. It is used for
21391 parameters and local variables.
21392 (Block.EmitMeta): Take the InternalParameters as argument; compute
21393 the layout of the flow vectors here.
21394 (Block.LocalMap, Block.ParameterMap): New public properties.
21395 (FlowBranching): The .ctor doesn't get the InternalParameters
21396 anymore since Block.EmitMeta() now computes the layout of the flow
21398 (MyStructInfo): This class is now known as `StructInfo' and nested
21399 in `TypeInfo'; we don't access this directly anymore.
21401 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21402 property and removed IsAssigned(), IsFieldAssigned(),
21403 SetAssigned() and SetFieldAssigned(); we now call them on the
21404 VariableInfo so we don't need to duplicate this code everywhere.
21406 * expression.cs (ParameterReference): Added `Block block' argument
21408 (LocalVariableReference, ParameterReference, This): The new
21409 VariableInfo class is now responsible for all the definite
21412 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21413 IsParameterAssigned, SetParameterAssigned): Removed.
21415 2003-05-18 Martin Baulig <martin@ximian.com>
21417 * typemanager.cs (InitCoreTypes): Try calling
21418 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21419 the 3-args-version. Corlib now also needs our `void_type'.
21420 (GetMethod): Added overloaded version which takes an optional
21421 `bool report_errors' to allow lookups of optional methods.
21423 2003-05-12 Martin Baulig <martin@ximian.com>
21425 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21426 only used for locals and not for parameters.
21428 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21430 * support.cs (InternalParameters.ParameterType): Return the
21431 ExternalType of the parameter.
21433 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21436 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21438 * class.cs (MethodData.Define): Do not set the `newslot' on
21439 interface members, if they are also flagged as "override".
21441 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21442 better code for ++i and i++. This only works for static fields
21443 and local variables.
21445 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21446 want to pull the DeclSpace out of the builder_to_declspace instead
21447 of the TypeBuilder (like in TypeContainer.FindMembers).
21449 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21450 instead of LookupTypeContainer. Fixes the crash on .NET for
21451 looking up interface members.
21453 * const.cs: Create our own emit context during the Definition
21454 stage, so that constants are evaluated in the proper context, when
21455 a recursive definition happens.
21457 2003-05-11 Martin Baulig <martin@ximian.com>
21459 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21460 new block for a switch section.
21461 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21462 the adding/lookup in the switch block. Fixes #39828.
21464 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21466 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21467 functionality: I needed to convert the data after I had performed
21468 the add/sub operation into the operands type size.
21470 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21471 pass the type for the box operation, otherwise the resulting
21472 object would have been of type object.
21474 (BoxedCast): Add constructor to specify the type to box as.
21476 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21478 * iterators.cs: I was reusing the `count' variable inadvertently,
21479 take steps to not allow this to happen.
21481 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21483 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21484 by creating an array at the point where the params starts and
21485 putting all those arguments there, then adjusting the size of the
21488 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21490 * expression.cs (New.AddressOf): Implement interface
21491 IMemoryLocation. This is used when the `new' operator is used in
21492 the context of an invocation to a method on a value type.
21494 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21497 * namespace.cs: Also check the using aliases here.
21499 * driver.cs: Move the test for using validity after the types have
21500 been entered, so we do a single pass that also includes the using
21503 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21504 in the regular case. CreateSiblingForFinally is doing extra
21507 * attribute.cs (GetAttributeArgumentExpression): Store the result
21508 on an out value, and use the return value to indicate failure
21509 instead of using null (which is a valid return for Constant.GetValue).
21511 * statement.cs: Perform the analysis flow for the increment
21512 portion after the statement, because this will be the real flow of
21513 execution. Fixes #42385
21515 * codegen.cs (EmitContext.EmitArgument,
21516 EmitContext.EmitStoreArgument): New helper functions when the
21517 RemapToProxy flag is set.
21519 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21522 Add support for remapping parameters.
21524 * iterators.cs: Propagate parameter values; Store parameter
21525 values in the proxy classes.
21527 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21529 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21530 need a proxy reference; I do not know what I was thinking
21532 * cs-parser.jay (constructor_initializer): catch another error,
21533 and display nice message.
21535 (field_declaration): catch void field declaration
21536 to flag a better error.
21538 * class.cs (MemberBase.CheckBase): Report an error instead of a
21539 warning if a new protected member is declared in a struct.
21540 (Field.Define): catch the error of readonly/volatile.
21542 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21544 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21545 volatile variable is taken
21547 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21549 * statement.cs (Fixed.Resolve): Report an error if we are not in
21552 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21554 * typemanager.cs: reuse the code that handles type clashes for
21555 delegates and enumerations.
21557 * class.cs (Report28): Always report.
21559 * expression.cs (EncodeAsAttribute): Allow nulls here.
21561 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21563 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21564 the functionality for testing whether an expression is valid for
21565 an attribute here. Also handle the case of arrays of elements
21568 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21569 encoding a linear array into an array of objects that are suitable
21570 to be passed to an CustomAttributeBuilder.
21572 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21574 * ecore.cs: (FieldExpr): Handle field remapping here.
21576 * iteratators.cs: Pass the instance variable (if the method is an
21577 instance method) to the constructors, so we can access the field
21578 variables on the class.
21580 TODO: Test this with structs. I think the THIS variable on
21581 structs might have to be a pointer, and not a refenrece
21583 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21585 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21586 local variables to fields in a proxy class.
21588 * iterators.cs (PopulateProxy): Rename our internal fields to
21590 Create a <THIS> field if we are an instance method, so we can
21591 reference our parent container variables.
21592 (MapVariable): Called back from the EmitContext code to enter a
21593 new variable to field mapping into the proxy class (we just create
21597 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21598 for using the remapped locals to fields.
21600 I placed the code here, because that gives the same semantics to
21601 local variables, and only changes the Emit code.
21603 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
21604 statements inside iterators.
21605 (VariableInfo): Add a FieldBuilder for the cases when we are
21606 remapping local variables to fields in a proxy class
21608 * ecore.cs (SimpleNameResolve): Avoid testing two times for
21609 current_block != null.
21611 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
21612 not cope with strings, as it has been moved to the
21613 TableSwitchEmit. Fixed bug in switch generation.
21615 * expression.cs (New.DoResolve): Provide more context for the user
21616 when reporting an error.
21618 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
21621 * expression.cs (MemberAccess.DoResolve): When we get a type back,
21622 check the permissions for it. Note than in a type-resolution
21623 context the check was already present in DeclSpace.ResolveType,
21624 but was missing from the MemberAccess.
21626 (ArrayCreation.CheckIndices): warn if the user has
21627 more nested levels of expressions, but there are no more
21628 dimensions specified. Avoids crash on bug 41906.
21630 2003-04-26 Miguel de Icaza <miguel@ximian.com>
21632 * statement.cs (Block): replace Implicit bool, for a generic
21634 New flag: `Unchecked'. This is used during the EmitMeta phase
21635 (which is out-of-line with the regular Resolve/Emit process for a
21636 statement, as this is done ahead of time, but still gets a chance
21637 to call constant resolve).
21639 (Block.Flags): new enum for adding a new flag.
21641 (Block.EmitMeta): track the state of unchecked.
21643 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
21644 to enable constant resolution to work there as well.
21646 2003-04-22 Miguel de Icaza <miguel@ximian.com>
21648 * typemanager.cs (ienumerable_type): Also look up
21649 System.Collections.IEnumerable.
21651 2003-04-21 Miguel de Icaza <miguel@ximian.com>
21653 TODO: Test more than one conditional per method.
21655 * class.cs (Indexer.Define): Report the location where the user is
21656 referencing the unsupported feature.
21658 (MethodData): Overload the use of `conditionals' to
21659 minimize the creation of needless ArrayLists. This saves roughly
21660 212kb on my machine.
21662 (Method): Implement the new IIteratorContainer interface.
21663 (Method.SetYields): Implement the method by setting the ModFlags
21664 to contain METHOD_YIELDS.
21666 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
21667 which just got set to null.
21669 * iterators.cs: New file.
21671 (Yield, YieldBreak): New statements.
21673 * statement.cs (Return.Resolve): Flag an error if we are used in
21674 an iterator method.
21676 * codegen.cs (InIterator): New flag set if the code is being
21677 compiled in an iterator method.
21679 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
21680 internal modifier, and we just use it to avoid adding extra
21681 fields, as this is seldom used.
21683 * cs-parser.jay: Add yield_statement (yield and yield break).
21685 * driver.cs: New flag -v2 to turn on version 2 features.
21687 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
21688 hashtable when v2 is enabled.
21690 2003-04-20 Miguel de Icaza <miguel@ximian.com>
21692 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
21693 there is already a namespace defined with this name.
21695 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
21696 people upgraded their corlibs.
21698 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
21699 always use fully qualified types, no need to use the compiler
21702 (TypeManager.IsNamespace): Use binarysearch.
21704 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
21705 AddDelegate): I did not quite use the new IsValid API properly: I
21706 have to pass the short-name and the fullname. I was passing only
21707 the basename instead of the fullname sometimes.
21709 (TypeContainer.DefineType): call NamespaceClash.
21711 * interface.cs (Interface.DefineType): use NamespaceClash before
21714 * delegate.cs (Delegate.DefineType): use NamespaceClash before
21717 * enum.cs: (Enum.DefineType): use NamespaceClash before
21720 * typemanager.cs (: 3-line patch that gives us some tasty 11%
21721 speed increase. First, use the negative_hits cache when we get a
21722 negative. Second, add the type with its full original name
21723 instead of the new . and + encoded name (reflection uses + to
21724 separate type from a nested type). Use LookupTypeReflection
21725 directly which bypasses the type->name hashtable (that we already
21726 know does not contain the type.
21728 * decl.cs (DeclSpace.ResolveTypeExpr): track the
21729 location/container type.
21731 * driver.cs: When passing utf8, use directly the UTF8Encoding.
21733 2003-04-19 Miguel de Icaza <miguel@ximian.com>
21735 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
21737 * delegate.cs (NewDelegate.Resolve): Test whether an instance
21738 method is being referenced in the method group from a static
21739 context, and report error 120 if so.
21741 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
21744 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
21745 is created, we create the A namespace).
21747 * cs-parser.jay: A namespace also introduces a DeclarationFound.
21750 2003-04-18 Miguel de Icaza <miguel@ximian.com>
21752 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
21753 invocation to ModuleBuilder.GetType with the same values will
21754 return a new type instance, so we need to cache its return
21757 * expression.cs (Binary.ResolveOperator): Only allow the compare
21758 operators on enums if they are of the same type.
21760 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
21761 types of ValueType on their own case. Before we were giving them
21762 the same treatment as objects.
21764 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
21765 fullname. Short name is used to compare against container name.
21766 Fullname is used to check against defined namespace names.
21768 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
21769 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
21771 (Method.CheckBase): Call parent.
21772 (MemberBase.CheckBase): Check for protected members on sealed
21774 (PropertyBase.CheckBase): Call parent.
21775 (Field.Define): Call parent.
21777 * report.cs: Negative error codes are now mapped to 8000 - code,
21778 so that the display is render more nicely.
21780 * typemanager.cs: Do not use try/catch, instead report a regular
21783 (GetPointerType, GetReferenceType): These methods provide
21784 mechanisms to obtain the T* and T& from a T. We had the code
21785 previously scattered around the code base, and it also used
21786 TypeManager.LookupType that would go through plenty of caches.
21787 This one goes directly to the type source.
21789 In some places we did the Type.GetType followed by
21790 ModuleBuilder.GetType, but not in others, so this unifies the
21791 processing as well.
21793 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
21794 statements now that we have namespace information.
21796 * typemanager.cs (IsNamespace): New method, returns whether the
21797 string presented is a namespace or not.
21799 (ComputeNamespaces): New public entry point, computes the list of
21800 available namespaces, using the GetNamespaces API call in Mono, or
21801 the slower version in MS.NET.
21803 Now before we start the semantic analysis phase, we have a
21804 complete list of namespaces including everything that the user has
21807 Deleted old code to cache namespaces in .nsc files.
21809 2003-04-17 Miguel de Icaza <miguel@ximian.com>
21811 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
21812 class/struct location definition Location for the implicit
21813 constructor location.
21815 (Operator.Define): Use the location of the operator for the
21816 implicit Method definition.
21818 (Constructor.Emit): use the constructor location for the implicit
21819 base initializer constructor.
21821 * ecore.cs: Remove ITypeExpression. This interface is now gone,
21822 and the Expression class now contains two new methods:
21824 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
21825 isolate type lookup from the rest of the resolution process.
21827 Since we use Expressions to hold type definitions due to the way
21828 we parse the input we have historically overloaded Resolve to
21829 perform the Type lookups if a special flag is passed. Now this is
21830 eliminated and two methods take their place.
21832 The differences in the two methods between xStep and xTerminal is
21833 that xStep is involved in our current lookup system that uses
21834 SimpleNames to compose a name, while xTerminal is used just to
21835 catch the case where the simplename lookup failed.
21837 2003-04-16 Miguel de Icaza <miguel@ximian.com>
21839 * expression.cs (ResolveMemberAccess): Remove redundant code.
21840 TypeExpr expressions are always born fully resolved.
21842 * interface.cs (PopulateMethod): Do not lookup the types twice.
21843 We were doing it once during SemanticAnalysis and once during
21846 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
21847 in local variable type definitions, were being returned as a
21848 SimpleName (we decomposed everything into a string), that is
21849 because primary_expression was being used instead of a type in the
21850 grammar (reduce/reduce conflicts).
21852 The part that was wrong is that we converted the expression into a
21853 string (an oversimplification in one hand, compounded with primary
21854 expressions doing string concatenation).
21860 Would return "A.B.C[]" as a SimpleName. This stopped things like
21861 using clauses from working on this particular context. And a type
21862 was being matched directly against "A.B.C[]".
21864 We now use the correct approach, and allow for ComposedCast to be
21865 part of the unary expression. So the "A.B.C []" become a composed
21866 cast of "A.B.C" (as a nested group of MemberAccess with a
21867 SimpleName at the end) plus the rank composition "[]".
21871 2003-04-10 Miguel de Icaza <miguel@ximian.com>
21873 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
21874 for the access level checking.
21876 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
21877 `TypeContainer container', because I kept getting confused when I
21878 was debugging this code.
21880 * expression.cs (Indexers): Instead of tracking getters/setters,
21881 we now track them in parallel. We create one arraylist less, but
21882 most importantly it is possible now for the LValue code to find a
21883 matching get for a set.
21885 (IndexerAccess.DoResolveLValue): Update the code.
21886 GetIndexersForType has been modified already to extract all the
21887 indexers from a type. The code assumed it did not.
21889 Also make the code set the correct return type for the indexer.
21890 This was fixed a long time ago for properties, but was missing for
21891 indexers. It used to be void_type.
21893 (Binary.Emit): Test first for doubles instead of
21894 floats, as they are more common.
21896 (Binary.EmitBranchable): Use the .un version of the branch opcodes
21897 when dealing with floats and the <=, >= operators. This fixes bug
21900 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
21901 to load the array value by emitting a load on the foreach variable
21902 type. This was incorrect.
21904 We now emit the code to load an element using the the array
21905 variable type, and then we emit the conversion operator.
21909 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
21911 * attribute.cs: Avoid allocation of ArrayLists in the common case.
21913 2003-04-09 Miguel de Icaza <miguel@ximian.com>
21915 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
21916 test for protection before we test for signatures.
21918 (MethodSignature.ToString): implement.
21920 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
21921 to the case where we reduced into a LongConstant.
21923 * decl.cs (CheckAccessLevel): If the type is an array, we can not
21924 depend on whether the information is acurrate, because the
21925 Microsoft runtime will always claim that the array type is public,
21926 regardless of the real state.
21928 If the type is a pointer, another problem happens: the type is
21929 reported as non-public in Microsoft.
21931 In both cases we have to call CheckAccessLevel recursively with
21932 the underlying type as the argument to be tested.
21934 2003-04-08 Miguel de Icaza <miguel@ximian.com>
21936 * assign.cs (Assign.Emit): If we are dealing with a compound
21937 assignment expression, we should use the code path that stores the
21938 intermediate result in a temporary value. This fixes #40903.
21940 *expression.cs (Indirection.ToString): Provide ToString method for
21943 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
21945 * class.cs: Null out fields holding references to Block objects so
21946 they can be garbage collected.
21948 * expression.cs (OverloadResolve): Remove unused local.
21950 2003-04-07 Martin Baulig <martin@ximian.com>
21952 * codegen.cs (EmitContext.CurrentFile): New public field.
21953 (EmitContext.Mark): Use the CurrentFile to check whether the
21954 location is in the correct file.
21955 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
21957 2003-04-07 Martin Baulig <martin@ximian.com>
21959 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
21961 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
21962 location. [FIXME: The location argument which gets passed to this
21963 method is sometimes wrong!]
21965 2003-04-07 Nick Drochak <ndrochak@gol.com>
21967 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
21969 2003-04-07 Miguel de Icaza <miguel@ximian.com>
21971 * expression.cs (Indirection.EmitAssign): We were using the
21972 temporary, but returning immediately instead of continuing the
21975 2003-04-06 Martin Baulig <martin@ximian.com>
21977 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
21978 if it's a nested child, but also deriving from the outer class.
21981 * typemanager.cs (IsNestedChildOf): Make this work if it's a
21982 nested child, but also deriving from the outer class. See
21984 (FilterWithClosure): We may access private members of the outer
21985 class if we're a nested child and deriving from the outer class.
21986 (RealMemberLookup): Only set `closure_private_ok' if the
21987 `original_bf' contained BindingFlags.NonPublic.
21989 2003-04-05 Martin Baulig <martin@ximian.com>
21991 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
21993 2003-04-02 Miguel de Icaza <miguel@ximian.com>
21995 * class.cs (Event.Define): Do not allow abstract events to have
21998 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22000 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22001 block in event declarations.
22003 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22004 value type, get its address.
22006 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22007 leaving a class on the stack instead of a boolean value (int
22008 0/1). Change the code so we compare against null, and then the
22009 result against zero.
22011 * class.cs (TypeContainer.GetClassBases): We were checking for the
22012 parent class being sealed too late.
22014 * expression.cs (Binary.Emit): For <= and >= when dealing with
22015 floating point values, use cgt.un and clt.un instead of cgt and
22018 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22020 * statement.cs: Apply the same optimization as MS: skip the
22021 GetEnumerator returning an IEnumerator, and use the one returning a
22022 CharEnumerator instead. This allows us to avoid the try-finally block
22025 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22027 * cs-parser.jay: Attributes cannot be applied to
22028 namespaces. Fixes #40473
22030 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22033 (Add*): check if the name is valid using the full name for constants,
22034 fields, properties and events.
22036 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22038 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22039 char constants to be part of the enumeration.
22041 * expression.cs (Conditional.DoResolve): Add support for operator
22042 true. Implements the missing functionality from 14.12
22044 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22045 operator true/false as required by the spec.
22047 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22048 implicit conversion to boolean.
22050 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22051 also one where the type implements `operator true'.
22053 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22054 get an expression that will invoke operator true based on an
22057 (GetConversionOperators): Removed the hack that called op_True
22060 (Expression.ResolveBoolean): Move this from Statement.
22062 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22064 * ecore.cs (FieldExpr): do not allow initialization of initonly
22065 fields on derived classes
22067 2003-03-13 Martin Baulig <martin@ximian.com>
22069 * statement.cs (Block.Emit): Call ig.BeginScope() and
22070 ig.EndScope() when compiling with debugging info; call
22071 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22073 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22075 * expression.cs (Indexers): Do not construct immediately, allow
22076 for new members to be appended as we go. Fixes 38143
22078 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22080 * expression.cs: save/restore context when resolving an unchecked
22083 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22085 * cfold.cs: Catch division by zero in modulus operator during
22088 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22090 * interface.cs (Interface.DefineMembers): Avoid defining members
22093 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22095 * driver.cs: handle the +/- options for -noconfig
22097 * statement.cs (Unckeched.Resolve): Also track the state of
22098 unchecked in the Resolve phase.
22100 2003-02-27 Martin Baulig <martin@ximian.com>
22102 * ecore.cs (Expression.MemberLookup): Don't create a
22103 MethodGroupExpr for something which is not a method. Fixes #38291.
22105 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22107 * class.cs (MemberBase.CheckParameters): Also check that the type
22108 is unmanaged if it is a pointer.
22110 * expression.cs (SizeOf.Resolve): Add location information.
22112 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22113 a managed type is declared.
22115 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22116 parameter modifiers as well. Fixes bug 38606
22118 * class.cs: Very sad. Am backing out the speed up changes
22119 introduced by the ArrayList -> Array in the TypeContainer, as they
22120 were not actually that much faster, and introduced a bug (no error
22121 reports on duplicated methods).
22123 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22124 source first, this will guarantee that we have a valid expression
22125 before calling in lower levels functions that will require a
22126 resolved object. Then use this original_source in the
22127 target.ResolveLValue instead of the original source that was
22130 Another change. Use target.Resolve instead of LValueResolve.
22131 Although we are resolving for LValues, we will let the Assign code
22132 take care of that (it will be called again from Resolve). This
22133 basically allows code like this:
22135 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22136 class Y { void A (X x) { x [0] += o; }
22138 The problem was that the indexer was trying to resolve for
22139 set_Item (idx, object o) and never finding one. The real set_Item
22140 was set_Item (idx, X). By delaying the process we get the right
22145 2003-02-23 Martin Baulig <martin@ximian.com>
22147 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22148 while calling DoEmit ().
22150 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22151 source files; if you use the #line directive inside a method, the
22152 compiler stops emitting line numbers for the debugger until it
22153 reaches the end of the method or another #line directive which
22154 restores the original file.
22156 2003-02-23 Martin Baulig <martin@ximian.com>
22158 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22160 2003-02-23 Martin Baulig <martin@ximian.com>
22162 * statement.cs (Block.AddChildVariableNames): We need to call this
22163 recursively, not just for our immediate children.
22165 2003-02-23 Martin Baulig <martin@ximian.com>
22167 * class.cs (Event.Define): Always make the field private, like csc does.
22169 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22170 actually work, fixes bug #37521.
22172 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22174 * delegate.cs: When creating the various temporary "Parameters"
22175 classes, make sure that we call the ComputeAndDefineParameterTypes
22176 on those new parameters (just like we do with the formal ones), to
22177 allow them to be resolved in the context of the DeclSpace.
22179 This fixes the bug that Dick observed in Bugzilla #38530.
22181 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22183 * expression.cs (ResolveMemberAccess): When resolving a constant,
22184 do not attempt to pull a constant if the value was not able to
22185 generate a valid constant.
22187 * const.cs (LookupConstantValue): Do not report more errors than required.
22189 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22191 * expression.cs: fixes bug #38328.
22193 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22195 * class.cs: Changed all the various members that can be part of a
22196 class from being an ArrayList to be an Array of the right type.
22197 During the DefineType type_list, interface_list, delegate_list and
22198 enum_list are turned into types, interfaces, delegates and enums
22201 And during the member population, indexer_list, event_list,
22202 constant_list, field_list, instance_constructor_list, method_list,
22203 operator_list and property_list are turned into their real arrays.
22205 Although we could probably perform this operation earlier, for
22206 good error reporting we need to keep the lists and remove the
22207 lists for longer than required.
22209 This optimization was triggered by Paolo profiling the compiler
22210 speed on the output of `gen-sample-program.pl' perl script.
22212 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22213 not crash in methods like MemberLookupFailed that use this field.
22215 This problem arises when the compiler fails to resolve a type
22216 during interface type definition for example.
22218 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22220 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22221 inherit from System.Object, so we have to stop at null, not only
22222 when reaching System.Object.
22224 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22226 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22227 DeclaredOnly because the parent indexer might have had a different
22228 name, but did not loop until the top of the hierarchy was reached.
22230 The problem this one fixes is 35492: when a class implemented an
22231 indexer from an interface, we were getting the interface method
22232 (which was abstract) and we were flagging an error (can not invoke
22235 This also keeps bug 33089 functioning, and test-148 functioning.
22237 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22238 out if a method is special is to see if it is declared in a
22239 property or event, or whether it is one of the predefined operator
22240 names. This should fix correctly #36804.
22242 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22244 The goal here is to remove the dependency on EmptyCast.Peel ().
22245 Killing it completely.
22247 The problem is that currently in a number of places where
22248 constants are expected, we have to "probe" for an EmptyCast, and
22249 Peel, which is not the correct thing to do, as this will be
22250 repetitive and will likely lead to errors.
22252 The idea is to remove any EmptyCasts that are used in casts that
22253 can be reduced to constants, so we only have to cope with
22256 This bug hunt was triggered by Bug 37363 and the desire to remove
22257 the duplicate pattern where we were "peeling" emptycasts to check
22258 whether they were constants. Now constants will always be
22261 * ecore.cs: Use an enumconstant here instead of wrapping with
22264 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22265 throwing me off. By handling this we can get rid of a few hacks.
22267 * statement.cs (Switch): Removed Peel() code.
22269 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22271 * class.cs: Location information for error 508
22273 * expression.cs (New.DoResolve): Add a guard against double
22274 resolution of an expression.
22276 The New DoResolve might be called twice when initializing field
22277 expressions (see EmitFieldInitializers, the call to
22278 GetInitializerExpression will perform a resolve on the expression,
22279 and later the assign will trigger another resolution
22281 This leads to bugs (#37014)
22283 * delegate.cs: The signature for EndInvoke should contain any ref
22284 or out parameters as well. We were not doing this in the past.
22286 * class.cs (Field.Define): Do not overwrite the type definition
22287 inside the `volatile' group. Turns out that volatile enumerations
22288 were changing the type here to perform a validity test, which
22291 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22293 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22294 and structs, we do not want to load the instance variable
22296 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22297 enum_type has to be handled like an object reference (implicit
22298 conversions exists from this to object), but the regular IsClass
22299 and IsValueType tests will never return true for this one.
22301 Also we use TypeManager.IsValueType instead of type.IsValueType,
22302 just for consistency with the rest of the code (this is only
22303 needed if we ever use the construct exposed by test-180.cs inside
22304 corlib, which we dont today).
22306 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22308 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22311 2003-02-09 Martin Baulig <martin@ximian.com>
22313 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22314 (Namespace.DefineNamespaces): New static public method; this is
22315 called when we're compiling with debugging to add all namespaces
22316 to the symbol file.
22318 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22319 pass it to the Namespace's .ctor.
22321 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22322 and MethodBase arguments; pass the namespace ID to the symwriter;
22323 pass the MethodBase instead of the token to the symwriter.
22324 (SymbolWriter.DefineNamespace): New method to add a namespace to
22327 2003-02-09 Martin Baulig <martin@ximian.com>
22329 * symbolwriter.cs: New file. This is a wrapper around
22330 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22331 methods here in near future.
22333 2003-02-09 Martin Baulig <martin@ximian.com>
22335 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22336 ILGenerator.MarkSequencePoint() which are actually used by the
22339 2003-02-09 Martin Baulig <martin@ximian.com>
22341 * location.cs (SourceFile): New public sealed class. This
22342 contains the name and an index which is used in the location's token.
22343 (Location): Reserve an appropriate number of bits in the token for
22344 the source file instead of walking over that list, this gives us a
22345 really huge performance improvement when compiling with debugging.
22347 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22348 `SourceFile' argument instead of a string.
22349 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22350 but don't parse/tokenize here, we need to generate the list of all
22351 source files before we do that.
22352 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22355 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22356 instead of a string.
22358 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22361 2003-02-09 Martin Baulig <martin@ximian.com>
22363 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22364 filename on `#line default'.
22366 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22368 * statement.cs: don't clear the pinned var when the fixed statement
22369 returns from the method (fixes bug#37752).
22371 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22373 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22376 2003-02-07 Martin Baulig <martin@ximian.com>
22378 * driver.cs: Removed the `--debug-args' command line argument.
22380 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22381 automatically by the AsssemblyBuilder.
22382 (CodeGen.InitializeSymbolWriter): We don't need to call any
22383 initialization function on the symbol writer anymore. This method
22384 doesn't take any arguments.
22386 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22388 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22389 from referenced assemblies as well.
22391 2003-02-02 Martin Baulig <martin@ximian.com>
22393 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22395 2003-02-02 Martin Baulig <martin@ximian.com>
22397 * class.cs (Constructor.Emit): Open the symbol writer before
22398 emitting the constructor initializer.
22399 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22400 single-stepping through constructor initializers.
22402 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22404 * class.cs: Handle error 549: do not allow virtual methods in
22407 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22409 * decl.cs: Check access levels when resolving types
22411 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22413 * statement.cs: Add parameters and locals set in catch blocks that might
22414 return to set vector
22416 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22418 * class.cs (Operator): Set the SpecialName flags for operators.
22420 * expression.cs (Invocation.DoResolve): Only block calls to
22421 accessors and operators on SpecialName methods.
22423 (Cast.TryReduce): Handle conversions from char constants.
22426 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22428 * statement.cs: small memory and time optimization in FlowBranching.
22430 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22432 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22433 problem that the last fix but in the other sid (Set).
22435 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22436 access when there is no indexer in the hierarchy.
22438 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22440 * class.cs: Combine some if statements.
22442 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22444 * driver.cs: fixed bug #37187.
22446 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22448 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22449 any indexer, it's needed to build a list with all the indexers in the
22450 hierarchy (AllGetters), else we have problems. Fixes #35653.
22452 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22454 * class.cs (MethodData.Define): It is wrong for an interface
22455 implementation to be static in both cases: explicit and implicit.
22456 We were only handling this in one case.
22458 Improve the if situation there to not have negations.
22460 * class.cs (Field.Define): Turns out that we do not need to check
22461 the unsafe bit on field definition, only on usage. Remove the test.
22463 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22465 * driver.cs: use assembly.Location instead of Codebase (the latest
22466 patch made mcs fail when using MS assemblies).
22468 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22470 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22471 get the path to *corlib.dll.
22473 2003-01-21 Nick Drochak <ndrochak@gol.com>
22477 * typemanager.cs: Remove compiler warnings
22479 2003-01-20 Duncan Mak <duncan@ximian.com>
22481 * AssemblyInfo.cs: Bump the version number to 0.19.
22483 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22485 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22487 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22489 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22491 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22493 * cs-parser.jay: Small fix: we were not comparing the constructor
22494 name correctly. Thanks to Zoltan for the initial pointer.
22496 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22498 * cs-tokenizer.cs: Set file name when specified with #line
22500 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22502 * cs-parser.jay: Only perform the constructor checks here if we
22503 are named like the class; This will help provider a better
22504 error. The constructor path is taken when a type definition is
22505 not found, but most likely the user forgot to add the type, so
22506 report that rather than the constructor error.
22508 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22510 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22513 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22515 * cs-parser.jay: Add cleanup call.
22517 2003-01-13 Duncan Mak <duncan@ximian.com>
22519 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22520 consistent with other methods.
22522 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22524 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22526 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22528 * attribute.cs: only set GuidAttr to true when we have a
22531 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22535 * typemanager.cs: fixes to allow mcs compile corlib with the new
22536 Type.IsSubclassOf fix.
22538 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22540 * expression.cs (LocalVariableReference.DoResolve): Classify a
22541 constant as a value, not as a variable. Also, set the type for
22544 * cs-parser.jay (fixed_statement): take a type instead of a
22545 pointer_type, so we can produce a better error message later.
22547 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22550 (For.DoEmit): Make inifinite loops have a
22551 non-conditional branch back.
22553 (Fixed.DoEmit): First populate the pinned variables, then emit the
22554 statement, then clear the variables. Before I was emitting the
22555 code once for each fixed piece.
22558 2003-01-08 Martin Baulig <martin@ximian.com>
22560 * statement.cs (FlowBranching.MergeChild): A break in a
22561 SWITCH_SECTION does not leave a loop. Fixes #36155.
22563 2003-01-08 Martin Baulig <martin@ximian.com>
22565 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22566 lives in the same number space than `param_map'. Fixes #36154.
22568 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22570 * cs-parser.jay (constructor_declaration): Set the
22571 Constructor.ModFlags before probing for it. This makes the
22572 compiler report 514, 515 and 132 (the code was there, but got
22575 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22576 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22577 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22579 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22581 * enum.cs: create the enum static fields using the enum type.
22583 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22585 * class.cs: don't try to create the ParamBuilder for the return
22586 type if it's not needed (and handle it breaking for the ms runtime
22589 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22591 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22593 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22595 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22596 the command. This showed up while compiling the JANET source
22597 code, which used \r as its only newline separator.
22599 2002-12-28 Miguel de Icaza <miguel@ximian.com>
22601 * class.cs (Method.Define): If we are an operator (because it
22602 reuses our code), then set the SpecialName and HideBySig. #36128
22604 2002-12-22 Miguel de Icaza <miguel@ximian.com>
22606 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
22607 exception, report error 120 `object reference required'.
22609 * driver.cs: Add --pause option, used during to measure the size
22610 of the process as it goes with --timestamp.
22612 * expression.cs (Invocation.DoResolve): Do not allow methods with
22613 SpecialName to be invoked.
22615 2002-12-21 Miguel de Icaza <miguel@ximian.com>
22617 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
22618 number before adding it.
22620 2002-12-21 Ravi Pratap <ravi@ximian.com>
22622 * ecore.cs (StandardImplicitConversion): When in an unsafe
22623 context, we allow conversion between void * to any other pointer
22624 type. This fixes bug #35973.
22626 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
22628 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
22629 is not thrown when extensionless outputs are used
22631 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22633 * rootcontext.cs: fixed compilation of corlib.
22635 2002-12-19 Miguel de Icaza <miguel@ximian.com>
22637 * attribute.cs (Attributes.Contains): Add new method.
22639 * class.cs (MethodCore.LabelParameters): if the parameter is an
22640 `out' parameter, check that no attribute `[In]' has been passed.
22642 * enum.cs: Handle the `value__' name in an enumeration.
22644 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
22646 * decl.cs: Added special case to allow overrides on "protected
22649 2002-12-18 Ravi Pratap <ravi@ximian.com>
22651 * attribute.cs (Attributes.AddAttributeSection): Rename to this
22652 since it makes much more sense.
22654 (Attributes.ctor): Don't require a Location parameter.
22656 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
22658 * attribute.cs (ApplyAttributes): Remove extra Location parameters
22659 since we already have that information per attribute.
22661 * everywhere : make appropriate changes.
22663 * class.cs (LabelParameters): Write the code which actually
22664 applies attributes to the return type. We can't do this on the MS
22665 .NET runtime so we flag a warning in the case an exception is
22668 2002-12-18 Miguel de Icaza <miguel@ximian.com>
22670 * const.cs: Handle implicit null conversions here too.
22672 2002-12-17 Ravi Pratap <ravi@ximian.com>
22674 * class.cs (MethodCore.LabelParameters): Remove the extra
22675 Type [] parameter since it is completely unnecessary. Instead
22676 pass in the method's attributes so that we can extract
22677 the "return" attribute.
22679 2002-12-17 Miguel de Icaza <miguel@ximian.com>
22681 * cs-parser.jay (parse): Use Report.Error to flag errors instead
22682 of ignoring it and letting the compile continue.
22684 * typemanager.cs (ChangeType): use an extra argument to return an
22685 error condition instead of throwing an exception.
22687 2002-12-15 Miguel de Icaza <miguel@ximian.com>
22689 * expression.cs (Unary.TryReduce): mimic the code for the regular
22690 code path. Perform an implicit cast in the cases where we can
22691 implicitly convert to one of the integral types, and then reduce
22692 based on that constant. This fixes bug #35483.
22694 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22696 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
22698 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22700 * namespace.cs: fixed bug #35489.
22702 2002-12-12 Miguel de Icaza <miguel@ximian.com>
22704 * class.cs: Remove some dead code.
22706 * cs-parser.jay: Estimate the number of methods needed
22707 (RootContext.MethodCount);
22709 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
22710 numbers instead of StringBuilders.
22712 * support.cs (PtrHashtable): Add constructor with initial size;
22713 We can now reduce reallocations of the method table.
22715 2002-12-10 Ravi Pratap <ravi@ximian.com>
22717 * attribute.cs (ApplyAttributes): Keep track of the emitted
22718 attributes on a per-target basis. This fixes bug #35413.
22720 2002-12-10 Miguel de Icaza <miguel@ximian.com>
22722 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
22723 default to the Windows 1252 encoding.
22725 (UnixParseOption): Support version, thanks to Alp for the missing
22728 * AssemblyInfo.cs: Add nice assembly information.
22730 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
22733 * cs-parser.jay: Allow a trailing comma before the close bracked
22734 in the attribute_section production.
22736 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
22737 address of the instance was being taken, I will take this out,
22738 because we take the address of the object immediately here.
22740 2002-12-09 Ravi Pratap <ravi@ximian.com>
22742 * typemanager.cs (AreMultipleAllowed): Take care of the most
22743 obvious case where attribute type is not in the current assembly -
22746 2002-12-08 Miguel de Icaza <miguel@ximian.com>
22748 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
22749 definitions, instead of doing that afterwards.
22751 Also we use a nice little hack, depending on the constructor, we
22752 know if we are a "composed" name or a simple name. Hence, we
22753 avoid the IndexOf test, and we avoid
22755 * codegen.cs: Add code to assist in a bug reporter to track down
22756 the source of a compiler crash.
22758 2002-12-07 Ravi Pratap <ravi@ximian.com>
22760 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
22761 types have been emitted for a given element and flag an error
22762 if something which does not have AllowMultiple set is used more
22765 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
22766 attribute types and their corresponding AllowMultiple properties
22768 (AreMultipleAllowed): Check the property for a given type.
22770 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
22771 property in the case we have a TypeContainer.
22773 (Attributes.AddAttribute): Detect duplicates and just skip on
22774 adding them. This trivial fix catches a pretty gross error in our
22775 attribute emission - global attributes were being emitted twice!
22777 Bugzilla bug #33187 is now fixed.
22779 2002-12-06 Miguel de Icaza <miguel@ximian.com>
22781 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
22782 instead of pp_and).
22784 * expression.cs (Binary.ResolveOperator): I can only use the
22785 Concat (string, string, string) and Concat (string, string,
22786 string, string) if the child is actually a concatenation of
22789 2002-12-04 Miguel de Icaza <miguel@ximian.com>
22791 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
22792 context where we need a 2-character lookahead.
22794 * pending.cs (PendingImplementation): Rework so we can keep track
22795 of interface types all the time, and flag those which were
22796 implemented by parents as optional.
22798 2002-12-03 Miguel de Icaza <miguel@ximian.com>
22800 * expression.cs (Binary.ResolveOperator): Use
22801 String.Concat(string,string,string) or
22802 String.Concat(string,string,string,string) when possible.
22804 * typemanager: More helper methods.
22807 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
22809 * pending.cs: remove the bogus return from GetMissingInterfaces()
22810 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
22812 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22814 * namespace.cs: avoid duplicated 'using xxx' being added to
22815 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
22816 when we get more than one 'using' statement for the same namespace.
22817 Report a CS0105 warning for it.
22819 2002-11-30 Miguel de Icaza <miguel@ximian.com>
22821 * cs-tokenizer.cs (consume_identifier): use read directly, instead
22822 of calling getChar/putback, uses internal knowledge of it.
22824 (xtoken): Reorder tokenizer so most common patterns are checked
22825 first. This reduces the compilation time in another 5% (from 8.11s
22826 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
22828 The parsing time is 22% of the compilation in mcs, and from that
22829 64% is spent on the tokenization process.
22831 I tried using a binary search for keywords, but this is slower
22832 than the hashtable. Another option would be to do a couple of
22835 * Not use a StringBuilder, instead use an array of chars,
22836 with a set value. Notice that this way we could catch
22837 the 645 error without having to do it *afterwards*.
22839 * We could write a hand-parser to avoid the hashtable
22840 compares altogether.
22842 The identifier consumption process takes 37% of the tokenization
22843 time. Another 15% is spent on is_number. 56% of the time spent
22844 on is_number is spent on Int64.Parse:
22846 * We could probably choose based on the string length to
22847 use Int32.Parse or Int64.Parse and avoid all the 64-bit
22850 Another 3% is spend on wrapping `xtoken' in the `token' function.
22852 Handle 0xa0 as whitespace (#34752)
22854 2002-11-26 Miguel de Icaza <miguel@ximian.com>
22856 * typemanager.cs (IsCLRType): New routine to tell whether a type
22857 is one of the builtin types.
22859 Maybe it needs to use TypeCodes to be faster. Maybe we could use
22860 typecode in more places instead of doing pointer comparissions.
22861 We could leverage some knowledge about the way the typecodes are
22864 New code to cache namespaces in assemblies, it is currently not
22865 invoked, to be used soon.
22867 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
22869 * expression.cs (Binary.ResolveOperator): specially handle
22870 strings, and do not perform user-defined operator overloading for
22873 2002-11-24 Miguel de Icaza <miguel@ximian.com>
22875 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
22876 internalcall as it is a pretty simple operation; Avoid whenever
22877 possible to call Char.IsLetter.
22879 (consume_identifier): Cut by half the number of
22880 hashtable calls by merging the is_keyword and GetKeyword behavior.
22882 Do not short-circuit, because if we do, we
22883 report errors (ie, #if false && true would produce an invalid
22887 2002-11-24 Martin Baulig <martin@ximian.com>
22889 * expression.cs (Cast.TryReduce): If we're in checked syntax,
22890 check constant ranges and report a CS0221. Fixes #33186.
22892 2002-11-24 Martin Baulig <martin@ximian.com>
22894 * cs-parser.jay: Make this work for uninitialized variable
22895 declarations in the `for' initializer. Fixes #32416.
22897 2002-11-24 Martin Baulig <martin@ximian.com>
22899 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
22900 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
22902 2002-11-24 Martin Baulig <martin@ximian.com>
22904 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
22905 argument; if true, we also check for user-defined conversions.
22906 This is only needed if both arguments are of a user-defined type.
22907 Fixes #30443, added test-175.cs.
22908 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
22910 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
22912 2002-11-24 Martin Baulig <martin@ximian.com>
22914 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
22915 function to get the store opcode.
22916 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
22917 only emit the Ldelema if the store opcode is Stobj. You must run
22918 both test-34 and test-167 to test this. Fixes #34529.
22920 2002-11-23 Martin Baulig <martin@ximian.com>
22922 * ecore.cs (Expression.MemberLookup): Added additional
22923 `qualifier_type' argument which is used when we're being called
22924 from MemberAccess.DoResolve() and null if we're called from a
22926 (Expression.MemberLookupFailed): New method to report errors; this
22927 does the CS1540 check and reports the correct error message.
22929 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
22930 argument for the CS1540 check and redone the way how we're dealing
22931 with private members. See the comment in the source code for details.
22932 (FilterWithClosure): Reverted this back to revision 1.197; renamed
22933 `closure_start_type' to `closure_qualifier_type' and check whether
22934 it's not null. It was not this filter being broken, it was just
22935 being called with the wrong arguments.
22937 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
22938 and pass it the correct `qualifier_type'; this also does the error
22941 2002-11-22 Miguel de Icaza <miguel@ximian.com>
22943 * expression.cs (Invocation.EmitParams): If the we are dealing
22944 with a non-built-in value type, load its address as well.
22946 (ArrayCreation): Use a a pretty constant instead
22947 of the hardcoded value 2. Use 6 instead of 2 for the number of
22948 static initializers.
22950 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
22951 because they are not really value types, just glorified integers.
22953 * driver.cs: Do not append .exe, the CSC compiler does not do it.
22955 * ecore.cs: Remove redundant code for enumerations, make them use
22956 the same code path as everything else, fixes the casting issue
22957 with enumerations in Windows.Forms.
22959 * attribute.cs: Do only cast to string if it is a string, the
22960 validation happens later.
22962 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
22963 people upgrade their corlibs.
22965 * ecore.cs: Oops, enumerations were not following the entire code path
22967 2002-11-21 Miguel de Icaza <miguel@ximian.com>
22969 * typemanager.cs (FilterWithClosure): Commented out the test for
22970 1540 in typemanager.cs, as it has problems when accessing
22971 protected methods from a parent class (see test-174.cs).
22973 * attribute.cs (Attribute.ValidateGuid): new method.
22974 (Attribute.Resolve): Use above.
22976 2002-11-19 Miguel de Icaza <miguel@ximian.com>
22978 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
22980 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
22981 handling for enumerations, as we only needed the TypeContainer
22982 functionality to begin with (this is required for the fix below to
22983 work for enums that reference constants in a container class for
22986 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
22988 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
22989 a valid TypeBuilder to perform lookups on.o
22991 * class.cs (InheritableMemberSignatureCompare): Use true in the
22992 call to GetGetMethod and GetSetMethod, because we are comparing
22993 the signature, and we need to get the methods *even* if they are
22996 (PropertyBase.CheckBase): ditto.
22998 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
22999 GotoCase.Resolve): Use Peel on EmpytCasts.
23001 * ecore.cs (EmptyCast): drop child, add Peel method.
23003 2002-11-17 Martin Baulig <martin@ximian.com>
23005 * ecore.cs (EmptyCast.Child): New public property.
23007 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23008 label resolved to an EmptyCast. Fixes #34162.
23009 (GotoCase.Resolve): Likewise.
23010 (Block.EmitMeta): Likewise.
23012 2002-11-17 Martin Baulig <martin@ximian.com>
23014 * expression.cs (Invocation.BetterConversion): Prefer int over
23015 uint; short over ushort; long over ulong for integer literals.
23016 Use ImplicitConversionExists instead of StandardConversionExists
23017 since we also need to check for user-defined implicit conversions.
23018 Fixes #34165. Added test-173.cs.
23020 2002-11-16 Martin Baulig <martin@ximian.com>
23022 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23023 with the `true' and `false' literals. Fixes #33151.
23025 2002-11-16 Martin Baulig <martin@ximian.com>
23027 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23028 October 22nd; don't do the cs1540 check for static members.
23030 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23031 now using our own filter here and doing the cs1540 check again.
23033 2002-11-16 Martin Baulig <martin@ximian.com>
23035 * support.cs (InternalParameters): Don't crash if we don't have
23036 any fixed parameters. Fixes #33532.
23038 2002-11-16 Martin Baulig <martin@ximian.com>
23040 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23041 when looking up static methods to make this work on Windows.
23044 2002-11-16 Martin Baulig <martin@ximian.com>
23046 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23047 a setter rather than using PropertyInfo.CanWrite.
23049 2002-11-15 Nick Drochak <ndrochak@gol.com>
23051 * class.cs: Allow acces to block member by subclasses. Fixes build
23054 2002-11-14 Martin Baulig <martin@ximian.com>
23056 * class.cs (Constructor.Emit): Added the extern/block check.
23059 2002-11-14 Martin Baulig <martin@ximian.com>
23061 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23062 iteration while looking for indexers, this is needed because the
23063 indexer may have a different name in our base classes. Fixed the
23064 error reporting (no indexers at all, not get accessor, no
23065 overloaded match). Fixes bug #33089.
23066 (IndexerAccess.DoResolveLValue): Likewise.
23068 2002-11-14 Martin Baulig <martin@ximian.com>
23070 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23071 indexers. Fixes the first part of bug #33089.
23072 (MethodSignature.InheritableMemberSignatureCompare): Added support
23075 2002-11-13 Ravi Pratap <ravi@ximian.com>
23077 * attribute.cs (Attribute.Resolve): Catch the
23078 NullReferenceException and report it since it isn't supposed to
23081 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23083 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23084 LogicalOr and LogicalAnd that can benefit from recursively
23085 handling EmitBranchable. The code now should be nice for Paolo.
23087 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23089 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23090 the Type lookups, as we perform quite a number of lookups on
23091 non-Types. This can be removed once we can deterministically tell
23092 whether we have a type or a namespace in advance.
23094 But this might require special hacks from our corlib.
23098 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23099 and double which avoids a conversion from an integer to a double.
23101 * expression.cs: tiny optimization, avoid calling IsConstant,
23102 because it effectively performs the lookup twice.
23104 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23106 But a bogus return here to keep the semantics of the old code
23107 until the Mono runtime is fixed.
23109 * pending.cs (GetMissingInterfaces): New method used to remove all
23110 the interfaces that are already implemented by our parent
23111 classes from the list of pending methods.
23113 * interface.cs: Add checks for calls after ResolveTypeExpr.
23115 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23117 * class.cs (Class.Emit): Report warning 67: event not used if the
23118 warning level is beyond 3.
23120 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23121 being a NullLiteral.
23123 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23126 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23127 path that might fail if a type can not be resolved.
23129 * expression.cs (Binary.Emit): Emit unsigned versions of the
23132 * driver.cs: use error 5.
23134 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23136 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23138 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23140 * cs-parser.jay (switch_section): A beautiful patch from Martin
23141 Baulig that fixed 33094.
23143 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23145 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23146 Check whether the base is abstract and report an error if so.
23148 * expression.cs (IndexerAccess.DoResolveLValue,
23149 IndexerAccess.DoResolve): ditto.
23151 (Invocation.DoResolve): ditto.
23153 (Invocation.FullMethodDesc): Improve the report string.
23155 * statement.cs (Block): Eliminate IsVariableDefined as it is
23156 basically just a wrapper for GetVariableInfo.
23158 * ecore.cs (SimpleName): Use new
23160 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23161 type, as we return the actual parameter ref/unref state on a
23164 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23166 * support.cs: Return proper flags REF/OUT fixing the previous
23169 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23170 not used to mean `ref' but `ref or out' in ParameterReference
23172 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23173 full type signature instead of calling TypeManger.CSharpName
23176 * support.cs (InternalParameters.ParameterDesc): Do not compare
23177 directly to the modflags, because REF/OUT will actually be bitsets
23180 * delegate.cs (VerifyMethod): Check also the modifiers.
23182 * cs-tokenizer.cs: Fix bug where floating point values with an
23183 exponent where a sign was missing was ignored.
23185 * driver.cs: Allow multiple assemblies to be specified in a single
23188 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23190 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23191 because identifiers after a parenthesis would end up in this kind
23192 of production, and we needed to desamiguate it for having casts
23195 (UserDefinedType *) xxx
23197 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23199 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23200 we should set on the Bindingflags.NonPublic, but not turn on
23201 private_ok. private_ok controls whether a Private member is
23202 returned (this is chekced on the filter routine), while the
23203 BindingFlags.NonPublic just controls whether private/protected
23204 will be allowed. This fixes the problem part of the problem of
23205 private properties being allowed to be used in derived classes.
23207 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23208 so we can call the children DoResolveLValue method (this will
23209 properly signal errors on lvalue assignments to base properties)
23211 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23212 getter are null, and we have a property info, we know that this
23213 happened because the lookup failed, so we report an error 122 for
23214 protection level violation.
23216 We also silently return if setter and getter are null in the
23217 resolve functions, this condition only happens if we have flagged
23218 the error before. This is the other half of the problem.
23220 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23221 not have accessibility information, that is why we were returning
23222 true in the filter function in typemanager.cs.
23224 To properly report 122 (property is inaccessible because of its
23225 protection level) correctly, we report this error in ResolveAccess
23226 by failing if both the setter and the getter are lacking (ie, the
23229 DoResolve and DoLResolve have been modified to check for both
23230 setter/getter being null and returning silently, the reason being
23231 that I did not want to put the knowledge about this error in upper
23234 int old = Report.Errors;
23235 x = new PropertyExpr (...);
23236 if (old != Report.Errors)
23241 So the property expr is returned, but it is invalid, so the error
23242 will be flagged during the resolve process.
23244 * class.cs: Remove InheritablePropertySignatureCompare from the
23245 class, as we no longer depend on the property signature to compute
23246 whether it is possible to implement a method or not.
23248 The reason is that calling PropertyInfo.GetGetMethod will return
23249 null (in .NET, in Mono it works, and we should change this), in
23250 cases where the Get Method does not exist in that particular
23255 class X { public virtual int A { get { return 1; } } }
23257 class Z : Y { public override int A { get { return 2; } } }
23259 Would fail in Z because the parent (Y) would not have the property
23260 defined. So we avoid this completely now (because the alternative
23261 fix was ugly and slow), and we now depend exclusively on the
23264 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23265 reference method, instead of using the property.
23267 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23268 routines are gone now.
23270 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23271 names, they were incorrectly named.
23273 * cs-tokenizer.cs: Return are more gentle token on failure.
23275 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23276 had an out-of-sync index variable, which caused it to remove from
23277 the list of pending methods the wrong method sometimes.
23279 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23281 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23282 CanWrite, because those refer to this particular instance of the
23283 property, and do not take into account the fact that we can
23284 override single members of a property.
23286 Constructor requires an EmitContext. The resolution process does
23287 not happen here, but we need to compute the accessors before,
23288 because the resolution does not always happen for properties.
23290 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23291 subclass, before we did not update this flag, but we did update
23294 (GetAccessors): Drop this routine, as it did not work in the
23295 presence of partially overwritten set/get methods.
23297 Notice that this broke the cs1540 detection, but that will require
23300 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23304 * driver.cs: issue a warning instead of an error if we don't support
23305 debugging for the platform. Also ignore a couple of errors that may
23306 arise when trying to write the symbols. Undo my previous patch.
23308 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23310 * driver.cs: ignore /debug switch except for Unix platforms.
23312 2002-10-23 Nick Drochak <ndrochak@gol.com>
23314 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23316 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23318 * driver.cs: Do not make mcs-debug conditional, so we do not break
23319 builds that use it.
23321 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23322 review this patch. But basically after all the children variables
23323 have been merged, the value of "Breaks" was not being set to
23324 new_breaks for Switch blocks. I think that it should be set after
23325 it has executed. Currently I set this to the value of new_breaks,
23326 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23327 conservative, but I do not understand this code very well.
23329 I did not break anything in the build, so that is good ;-)
23331 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23333 2002-10-20 Mark Crichton <crichton@gimp.org>
23335 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23337 2002-10-20 Nick Drochak <ndrochak@gol.com>
23339 * cfold.cs: Fixed compile blocker.
23341 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23343 * driver.cs: I was chekcing the key, not the file.
23345 2002-10-19 Ravi Pratap <ravi@ximian.com>
23347 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23348 message that we were generating - we just need to silently return
23351 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23353 * class.cs (Event.Define): Change my previous commit, as this
23354 breaks the debugger. This is a temporary hack, as it seems like
23355 the compiler is generating events incorrectly to begin with.
23357 * expression.cs (Binary.ResolveOperator): Added support for
23358 "U operator - (E x, E y)"
23360 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23363 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23364 init-only variables, but this path did not take into account that
23365 there might be also instance readonly variables. Correct this
23368 This fixes bug 32253
23370 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23373 * driver.cs: Change the extension for modules to `netmodule'
23375 * cs-parser.jay: Improved slightly the location tracking for
23376 the debugger symbols.
23378 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23379 modifiers that were specified instead of the hardcoded value
23380 (FamAndAssem). This was basically ignoring the static modifier,
23381 and others. Fixes 32429.
23383 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23384 fixed a bug in the process (32476)
23386 * expression.cs (ArrayAccess.EmitAssign): Patch from
23387 hwang_rob@yahoo.ca that fixes bug 31834.3
23389 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23391 * driver.cs: Make the module extension .netmodule.
23393 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23395 * driver.cs: Report an error if the resource file is not found
23396 instead of crashing.
23398 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23399 false, like Emit does.
23401 2002-10-16 Nick Drochak <ndrochak@gol.com>
23403 * typemanager.cs: Remove unused private member. Also reported mcs
23404 bug to report this as a warning like csc.
23406 2002-10-15 Martin Baulig <martin@gnome.org>
23408 * statement.cs (Statement.Emit): Made this a virtual method; emits
23409 the line number info and calls DoEmit().
23410 (Statement.DoEmit): New protected abstract method, formerly knows
23411 as Statement.Emit().
23413 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23415 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23417 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23418 have fixed a remaining problem: not every AddXXXX was adding a
23419 fully qualified name.
23421 Now everyone registers a fully qualified name in the DeclSpace as
23422 being defined instead of the partial name.
23424 Downsides: we are slower than we need to be due to the excess
23425 copies and the names being registered this way.
23427 The reason for this is that we currently depend (on the corlib
23428 bootstrap for instance) that types are fully qualified, because
23429 we dump all the types in the namespace, and we should really have
23430 types inserted into the proper namespace, so we can only store the
23431 basenames in the defined_names array.
23433 2002-10-10 Martin Baulig <martin@gnome.org>
23435 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23436 from bug #31834, see the bug report for a testcase which is
23439 2002-10-10 Martin Baulig <martin@gnome.org>
23441 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23442 flow analysis code for this.
23444 * statement.cs (Do, While, For): Tell the flow analysis code about
23446 (FlowBranching.UsageVector): Added support for infinite loops.
23447 (Block.Resolve): Moved the dead code elimination here and use flow
23450 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23452 * class.cs (Field.Define): Catch cycles on struct type
23455 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23456 fields if the fields are static. We only need to check instance
23459 * expression.cs (As.DoResolve): Test for reference type.
23461 * statement.cs (Using.ResolveExpression): Use
23462 ConvertImplicitRequired, not ConvertImplicit which reports an
23464 (Using.ResolveLocalVariableDecls): ditto.
23466 * expression.cs (Binary.ResolveOperator): Report errors in a few
23467 places where we had to.
23469 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23471 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23473 * expression.cs: Use StoreFromPtr instead of extracting the type
23474 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23476 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23477 an enumeration value to a System.Enum, but System.Enum is not a
23478 value type, but an class type, so we need to box.
23480 (Expression.ConvertExplicit): One codepath could return
23481 errors but not flag them. Fix this. Fixes #31853
23483 * parameter.cs (Resolve): Do not allow void as a parameter type.
23485 2002-10-06 Martin Baulig <martin@gnome.org>
23487 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23488 if it's a class type and not a struct. Fixes #31815.
23490 2002-10-06 Martin Baulig <martin@gnome.org>
23492 * statement.cs: Reworked the flow analysis code a bit to make it
23493 usable for dead code elimination.
23495 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23497 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23499 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23501 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23502 to fix the test 165, will investigate deeper.
23504 2002-10-04 Martin Baulig <martin@gnome.org>
23506 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23507 finally blocks actually work.
23508 (Try.Resolve): We don't need to create a sibling for `finally' if
23509 there is no finally block.
23511 2002-10-04 Martin Baulig <martin@gnome.org>
23513 * class.cs (Constructor.Define): The default accessibility for a
23514 non-default constructor is private, not public.
23516 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23518 * class.cs (Constructor): Make AllowedModifiers public, add
23521 * cs-parser.jay: Perform the modifiers test here, as the
23522 constructor for the Constructor class usually receives a zero
23523 because of the way we create it (first we create, later we
23524 customize, and we were never checking the modifiers).
23526 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23527 is a version of LookupTypeReflection that includes the type-name
23528 cache. This can be used as a fast path for functions that know
23529 the fully qualified name and are only calling into *.GetType() to
23530 obtain a composed type.
23532 This is also used by TypeManager.LookupType during its type
23535 (LookupType): We now also track the real type name, as sometimes
23536 we can get a quey for the real type name from things like
23537 ComposedCast. This fixes bug 31422.
23539 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23540 complete type fullname, it does not have to go through the type
23541 resolution system to obtain the composed version of the type (for
23542 obtaining arrays or pointers).
23544 (Conditional.Emit): Use the EmitBoolExpression to
23545 generate nicer code, as requested by Paolo.
23547 (ArrayCreation.CheckIndices): Use the patch from
23548 hwang_rob@yahoo.ca to validate the array initializers.
23550 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23552 * class.cs (ConstructorInitializer.Emit): simplify code by using
23553 Invocation.EmitCall, and at the same time, fix the bugs in calling
23554 parent constructors that took variable arguments.
23556 * ecore.cs (Expression.ConvertNumericExplicit,
23557 Expression.ImplicitNumericConversion): Remove the code that
23558 manually wrapped decimal (InternalTypeConstructor call is now gone
23561 * expression.cs (Cast.TryReduce): Also handle decimal types when
23562 trying to perform a constant fold on the type.
23564 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23566 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23567 that only turned off an error report, and did nothing else.
23569 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23571 * driver.cs: Handle and ignore /fullpaths
23573 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23575 * expression.cs (Binary.ResolveOperator): Catch the case where
23576 DoNumericPromotions returns true,
23578 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23580 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23582 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23585 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23587 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23588 conversion exists, but it is also required that the conversion be
23589 performed. This manifested in "(Type64Enum) 2".
23591 * class.cs (TypeManager.AddMethod): The fix is not to change
23592 AddEnum, because that one was using a fully qualified name (every
23593 DeclSpace derivative does), but to change the AddMethod routine
23594 that was using an un-namespaced name. This now correctly reports
23595 the duplicated name.
23597 Revert patch until I can properly fix it. The issue
23598 is that we have a shared Type space across all namespaces
23599 currently, which is wrong.
23601 Options include making the Namespace a DeclSpace, and merge
23602 current_namespace/current_container in the parser.
23604 2002-09-25 Miguel de Icaza <miguel@ximian.com>
23606 * cs-parser.jay: Improve error reporting when we get a different
23607 kind of expression in local_variable_type and
23608 local_variable_pointer_type.
23610 Propagate this to avoid missleading errors being reported.
23612 * ecore.cs (ImplicitReferenceConversion): treat
23613 TypeManager.value_type as a target just like object_type. As
23618 Is valid, and needs to result in the int 1 being boxed before it
23619 is assigned to the value type v.
23621 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
23622 to validate the enumeration name.
23624 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
23625 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
23626 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
23628 * ecore.cs (TryImplicitIntConversion): When doing an
23629 implicit-enumeration-conversion, check if the type is 64-bits and
23630 perform a conversion before passing to EnumConstant.
23632 2002-09-23 Miguel de Icaza <miguel@ximian.com>
23634 * decl.cs (Error_AmbiguousTypeReference); New routine used to
23635 report ambiguous type references. Unlike the MS version, we
23636 report what the ambiguity is. Innovation at work ;-)
23638 (DeclSpace.FindType): Require a location argument to
23639 display when we display an ambiguous error.
23641 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
23643 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
23645 * expression.cs (EmitDynamicInitializers): Apply patch from
23646 hwang_rob@yahoo.ca that fixes the order in which we emit our
23649 2002-09-21 Martin Baulig <martin@gnome.org>
23651 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
23652 delegate takes no arguments.
23654 2002-09-20 Miguel de Icaza <miguel@ximian.com>
23656 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
23659 * expression.cs: Extract the underlying type.
23661 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
23663 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
23665 2002-09-19 Miguel de Icaza <miguel@ximian.com>
23667 * class.cs (TypeContainer.DefineType): We can not use the nice
23668 PackingSize with the size set to 1 DefineType method, because it
23669 will not allow us to define the interfaces that the struct
23672 This completes the fixing of bug 27287
23674 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
23675 means also structs. This fixes part of the problem.
23676 (Expresion.ImplicitReferenceConversionExists): ditto.
23678 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
23679 error if there were no errors reported during the type lookup
23680 process, to avoid duplicates or redundant errors. Without this
23681 you would get an ambiguous errors plus a type not found. We have
23682 beaten the user enough with the first error.
23684 (DeclSparce.FindType): Emit a warning if we have an ambiguous
23687 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
23688 during the resolution process, stop the lookup, this avoids
23689 repeated error reports (same error twice).
23691 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
23693 * typemanager.cs (LookupType): Redo the type lookup code to match
23694 the needs of System.Reflection.
23696 The issue is that System.Reflection requires references to nested
23697 types to begin with a "+" sign instead of a dot. So toplevel
23698 types look like: "NameSpace.TopLevelClass", and nested ones look
23699 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
23702 2002-09-19 Martin Baulig <martin@gnome.org>
23704 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
23705 says that a method always returns or always throws an exception,
23706 don't report the CS0161.
23708 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
23709 set `Returns = new_returns'.
23711 2002-09-19 Martin Baulig <martin@gnome.org>
23713 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
23714 to an enum constant, check for a CS0176.
23716 2002-09-18 Miguel de Icaza <miguel@ximian.com>
23718 * class.cs (TypeContainer.CheckPairedOperators): Now we check
23719 for operators that must be in pairs and report errors.
23721 * ecore.cs (SimpleName.DoResolveType): During the initial type
23722 resolution process, when we define types recursively, we must
23723 check first for types in our current scope before we perform
23724 lookups in the enclosing scopes.
23726 * expression.cs (MakeByteBlob): Handle Decimal blobs.
23728 (Invocation.VerifyArgumentsCompat): Call
23729 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
23730 I thought we were supposed to always call this, but there are a
23731 few places in the code where we dont do it.
23733 2002-09-17 Miguel de Icaza <miguel@ximian.com>
23735 * driver.cs: Add support in -linkres and -resource to specify the
23736 name of the identifier.
23738 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23740 * ecore.cs (StandardConversionExists): Sync with the conversion
23741 code: allow anything-* to void* conversions.
23743 (FindMostSpecificSource): Use an Expression argument
23744 instead of a Type, because we might be handed over a Literal which
23745 gets a few more implicit conversions that plain types do not. So
23746 this information was being lost.
23748 Also, we drop the temporary type-holder expression when not
23751 2002-09-17 Martin Baulig <martin@gnome.org>
23753 * class.cs (PropertyBase.CheckBase): Don't check the base class if
23754 this is an explicit interface implementation.
23756 2002-09-17 Martin Baulig <martin@gnome.org>
23758 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
23759 different `IndexerName' attributes.
23761 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
23762 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
23763 virtual CommonResolve().
23765 2002-09-16 Miguel de Icaza <miguel@ximian.com>
23767 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
23768 and convert that to the UnderlyingType.
23770 * statement.cs (Foreach.Resolve): Indexers are just like variables
23771 or PropertyAccesses.
23773 * cs-tokenizer.cs (consume_string): Track line numbers and columns
23774 inside quoted strings, we were not doing this before.
23776 2002-09-16 Martin Baulig <martin@gnome.org>
23778 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
23779 resolve it. This is needed for the definite assignment check of the
23780 instance expression, fixes bug #29846.
23781 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
23783 2002-09-16 Nick Drochak <ndrochak@gol.com>
23785 * parameter.cs: Fix compile error. Cannot reference static member
23786 from an instance object. Is this an mcs bug?
23788 2002-09-14 Martin Baulig <martin@gnome.org>
23790 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
23791 multiple times. Fixes bug #30295, added test-166.cs.
23793 2002-09-14 Martin Baulig <martin@gnome.org>
23795 * statement.cs (Block.Emit): Don't emit unreachable code.
23796 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
23797 `break' statements.
23798 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
23800 2002-09-14 Martin Baulig <martin@gnome.org>
23802 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
23805 2002-09-14 Martin Baulig <martin@gnome.org>
23807 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
23808 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
23809 be false on the ms runtime.
23811 2002-09-13 Martin Baulig <martin@gnome.org>
23813 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
23814 the CS0038 error message.
23816 2002-09-12 Miguel de Icaza <miguel@ximian.com>
23818 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
23819 constant inside, return it.
23821 2002-09-12 Martin Baulig <martin@gnome.org>
23823 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
23824 implicit conversion can be done between enum types.
23826 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
23827 check whether an implicit conversion to the current enum's UnderlyingType
23828 exists and report an error if not.
23830 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
23831 without debugging support.
23833 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
23834 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
23836 2002-09-12 Martin Baulig <martin@gnome.org>
23838 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
23840 * ecore.cs (IMemberExpr.DeclaringType): New property.
23841 (SimpleName.SimpleNameResolve): Check whether we're accessing a
23842 nonstatic member of an outer type (CS0038).
23844 2002-09-11 Miguel de Icaza <miguel@ximian.com>
23846 * driver.cs: Activate the using-error detector at warning level
23847 4 (at least for MS-compatible APIs).
23849 * namespace.cs (VerifyUsing): Small buglett fix.
23851 * pending.cs (PendingImplementation): pass the container pointer.
23853 * interface.cs (GetMethods): Allow for recursive definition. Long
23854 term, I would like to move every type to support recursive
23855 definitions, not the current ordering mechanism that we have right
23858 The situation is this: Attributes are handled before interfaces,
23859 so we can apply attributes to interfaces. But some attributes
23860 implement interfaces, we will now handle the simple cases
23861 (recursive definitions will just get an error).
23863 * parameter.cs: Only invalidate types at the end if we fail to
23866 2002-09-09 Martin Baulig <martin@gnome.org>
23868 * ecore.cs (PropertyExpr.Emit): Also check for
23869 TypeManager.system_int_array_get_length so this'll also work when
23870 compiling corlib. Fixes #30003.
23872 2002-09-09 Martin Baulig <martin@gnome.org>
23874 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
23875 and throw an exception if we can't get the type's size. Fixed #30040,
23878 2002-09-09 Martin Baulig <martin@gnome.org>
23880 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
23882 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
23883 context. Fixes bug #30027.
23885 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
23886 virtual functions. Fixes bug #30043, added test-164.cs.
23888 2002-09-08 Ravi Pratap <ravi@ximian.com>
23890 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
23892 2002-09-08 Nick Drochak <ndrochak@gol.com>
23894 * driver.cs: Use an object to get the windows codepage since it's not a
23897 2002-09-08 Miguel de Icaza <miguel@ximian.com>
23899 * statement.cs (For.Emit): for infinite loops (test == null)
23900 return whether there is a break inside, not always "true".
23902 * namespace.cs (UsingEntry): New struct to hold the name of the
23903 using definition, the location where it is defined, and whether it
23904 has been used in a successful type lookup.
23906 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
23911 2002-09-06 Ravi Pratap <ravi@ximian.com>
23913 * attribute.cs : Fix incorrect code which relied on catching
23914 a NullReferenceException to detect a null being passed in
23915 where an object was expected.
23917 2002-09-06 Miguel de Icaza <miguel@ximian.com>
23919 * statement.cs (Try): flag the catch variable as assigned
23921 * expression.cs (Cast): Simplified by using ResolveType instead of
23922 manually resolving.
23924 * statement.cs (Catch): Fix bug by using ResolveType.
23926 2002-09-06 Ravi Pratap <ravi@ximian.com>
23928 * expression.cs (BetterConversion): Special case for when we have
23929 a NullLiteral as the argument and we have to choose between string
23930 and object types - we choose string the way csc does.
23932 * attribute.cs (Attribute.Resolve): Catch the
23933 NullReferenceException and report error #182 since the Mono
23934 runtime no more has the bug and having this exception raised means
23935 we tried to select a constructor which takes an object and is
23938 2002-09-05 Ravi Pratap <ravi@ximian.com>
23940 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
23941 message (1502, 1503) when we can't locate a method after overload
23942 resolution. This is much more informative and closes the bug
23945 * interface.cs (PopulateMethod): Return if there are no argument
23946 types. Fixes a NullReferenceException bug.
23948 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
23949 expressions too. Previously we were checking only in one place for
23950 positional arguments leaving out named arguments.
23952 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
23953 type to the enum type is not allowed. Remove code corresponding to
23956 (ConvertNumericExplicit): Allow explicit conversions from
23957 the underlying type to enum type. This precisely follows the spec
23958 and closes a bug filed by Gonzalo.
23960 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23963 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
23965 2002-09-03 Miguel de Icaza <miguel@ximian.com>
23967 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
23968 it was important that we stored the right value after the
23969 reduction in `converted'.
23971 2002-09-04 Martin Baulig <martin@gnome.org>
23973 * location.cs (Location.SymbolDocument): Use full pathnames for the
23976 2002-08-30 Miguel de Icaza <miguel@ximian.com>
23978 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
23979 of the expression resolve mechanism, because that will catch the
23980 SimpleName error failures.
23982 (Conditional): If we can not resolve the
23983 expression, return, do not crash.
23985 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23988 (location): display token name instead of its number.
23990 2002-08-28 Martin Baulig <martin@gnome.org>
23992 * expression.cs (Binary.ResolveOperator): Don't silently return
23993 but return an error if an operator cannot be applied between two
23996 2002-08-28 Martin Baulig <martin@gnome.org>
23998 * class.cs (Constructor.Define): Set the permission attributes
23999 correctly instead of making all constructors public.
24001 2002-08-28 Martin Baulig <martin@gnome.org>
24003 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24004 for private members before reporting a CS0103; if we find anything,
24007 2002-08-28 Martin Baulig <martin@gnome.org>
24009 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24010 to check whether `closure_start_type == closure_invocation_type',
24011 we also need to check whether `m.DeclaringType == closure_invocation_type'
24012 before bypassing the permission checks. We might be accessing
24013 protected/private members from the base class.
24014 (TypeManager.RealMemberLookup): Only set private_ok if private
24015 members were requested via BindingFlags.NonPublic.
24017 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24019 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24020 MethodGroupExpr.IsExplicitImpl if appropriate.
24021 (Invocation.DoResolve): Don't report the CS0120 for explicit
24022 interface implementations.
24024 2002-08-27 Martin Baulig <martin@gnome.org>
24026 * expression.cs (Invocation.DoResolve): If this is a static
24027 method and we don't have an InstanceExpression, we must report
24030 2002-08-25 Martin Baulig <martin@gnome.org>
24032 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24033 `==' between a valuetype and an object.
24035 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24037 * ecore.cs (TypeExpr): Provide a ToString method.
24039 2002-08-24 Martin Baulig <martin@gnome.org>
24041 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24042 now called proggie.dbg and it's a binary file.
24044 2002-08-23 Martin Baulig <martin@gnome.org>
24046 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24048 2002-08-23 Martin Baulig <martin@gnome.org>
24050 * struct.cs (MyStructInfo.ctor): Make this work with empty
24051 structs; it's not allowed to use foreach() on null.
24053 2002-08-23 Martin Baulig <martin@gnome.org>
24055 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24056 writer the full pathname of the generated assembly.
24058 2002-08-23 Martin Baulig <martin@gnome.org>
24060 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24061 A `finally' block never returns or breaks; improved handling of
24064 2002-08-23 Martin Baulig <martin@gnome.org>
24066 * statement.cs (Throw.Resolve): Allow `throw null'.
24068 2002-08-23 Martin Baulig <martin@gnome.org>
24070 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24071 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24072 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24073 MemberLookup would return a wrong event if this is an explicit
24074 interface implementation and the class has an event with the same
24077 2002-08-23 Martin Baulig <martin@gnome.org>
24079 * statement.cs (Block.AddChildVariableNames): New public method.
24080 (Block.AddChildVariableName): Likewise.
24081 (Block.IsVariableNameUsedInChildBlock): Likewise.
24082 (Block.AddVariable): Check whether a variable name has already
24083 been used in a child block.
24085 * cs-parser.jay (declare_local_variables): Mark all variable names
24086 from the current block as being used in a child block in the
24089 2002-08-23 Martin Baulig <martin@gnome.org>
24091 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24092 find the symbol writer.
24094 * driver.cs: csc also allows the arguments to /define being
24095 separated by commas, not only by semicolons.
24097 2002-08-23 Martin Baulig <martin@gnome.org>
24099 * interface.cs (Interface.GetMembers): Added static check for events.
24101 2002-08-15 Martin Baulig <martin@gnome.org>
24103 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24104 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24106 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24107 why the MethodData.EmitDestructor() change was necessary.
24109 2002-08-20 Martin Baulig <martin@gnome.org>
24111 * class.cs (TypeContainer.FindMembers): Added static check for events.
24113 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24115 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24116 use Type.GetEvents(), not Type.FindMembers().
24118 2002-08-20 Martin Baulig <martin@gnome.org>
24120 * decl.cs (MemberCache): Added a special method cache which will
24121 be used for method-only searched. This ensures that a method
24122 search will return a MethodInfo with the correct ReflectedType for
24125 2002-08-20 Martin Baulig <martin@gnome.org>
24127 * decl.cs (DeclSpace.FindMembers): Made this public.
24129 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24131 * delegate.cs: fixed build on windows.
24132 [FIXME: Filed as bug #29150: MCS must report these errors.]
24134 2002-08-19 Ravi Pratap <ravi@ximian.com>
24136 * ecore.cs (StandardConversionExists): Return a false
24137 if we are trying to convert the void type to anything else
24138 since that is not allowed.
24140 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24141 we flag error 70 in the event an event is trying to be accessed
24142 directly from outside the declaring type.
24144 2002-08-20 Martin Baulig <martin@gnome.org>
24146 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24147 MemberCache from typemanager.cs to decl.cs.
24149 2002-08-19 Martin Baulig <martin@gnome.org>
24151 * class.cs (TypeContainer): Implement IMemberContainer.
24152 (TypeContainer.DefineMembers): Create the MemberCache.
24153 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24154 return public members if BindingFlags.Public was given, check
24155 whether members are static.
24157 2002-08-16 Martin Baulig <martin@gnome.org>
24159 * decl.cs (DeclSpace.Define): Splitted this in Define and
24160 DefineMembers. DefineMembers is called first and initializes the
24163 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24164 DefineMembers() on all our DeclSpaces.
24166 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24167 but call DefineMembers() on all nested interfaces. We call their
24168 Define() in our new Define() function.
24170 * interface.cs (Interface): Implement IMemberContainer.
24171 (Interface.Define): Moved all code except the attribute stuf to
24173 (Interface.DefineMembers): Initialize the member cache.
24175 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24176 need this anymore since we can use MemberCache.FindMembers directly.
24178 2002-08-19 Martin Baulig <martin@gnome.org>
24180 * typemanager.cs (MemberCache): When creating the cache for an
24181 interface type, add all inherited members.
24182 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24183 to `out bool used_cache' and documented it.
24184 (TypeManager.MemberLookup): If we already used the cache in the first
24185 iteration, we don't need to do the interfaces check.
24187 2002-08-19 Martin Baulig <martin@gnome.org>
24189 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24190 here from IMemberFinder and don't implement this interface anymore.
24191 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24193 * typemanager.cs (IMemberFinder): This interface is now only used by
24194 classes which actually support the member cache.
24195 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24196 since we only put DeclSpaces into this Hashtable.
24197 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24198 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24200 2002-08-16 Martin Baulig <martin@gnome.org>
24202 * typemanager.cs (ICachingMemberFinder): Removed.
24203 (IMemberFinder.MemberCache): New property.
24204 (TypeManager.FindMembers): Merged this with RealFindMembers().
24205 This function will never be called from TypeManager.MemberLookup()
24206 so we can't use the cache here, just the IMemberFinder.
24207 (TypeManager.MemberLookup_FindMembers): Check whether the
24208 IMemberFinder has a MemberCache and call the cache's FindMembers
24210 (MemberCache): Rewrote larger parts of this yet another time and
24211 cleaned it up a bit.
24213 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24215 * driver.cs (LoadArgs): Support quoting.
24217 (Usage): Show the CSC-like command line arguments.
24219 Improved a few error messages.
24221 2002-08-15 Martin Baulig <martin@gnome.org>
24223 * typemanager.cs (IMemberContainer.Type): New property.
24224 (IMemberContainer.IsInterface): New property.
24226 The following changes are conditional to BROKEN_RUNTIME, which is
24227 defined at the top of the file.
24229 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24230 class'es members, but add all members from TypeHandle.ObjectType
24231 if we're an interface.
24232 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24233 is the current type.
24234 (MemberCache.CacheEntry.Container): Removed this field.
24235 (TypeHandle.GetMembers): Include inherited members.
24237 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24239 * typemanager.cs: fixed compilation and added a comment on a field that
24242 2002-08-15 Martin Baulig <martin@gnome.org>
24244 * class.cs (ConstructorInitializer.Resolve): In the
24245 Expression.MemberLookup call, use the queried_type as
24248 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24249 declared' attribute, it's always true.
24250 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24251 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24252 temporary wrapper for FindMembers which tells MemberLookup whether
24253 members from the base classes are included in the return value.
24254 This will go away soon.
24255 (TypeManager.MemberLookup): Use this temporary hack here; once the
24256 new MemberCache is completed, we don't need to do the DeclaredOnly
24257 looping here anymore since the MemberCache will take care of this.
24258 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24259 (MemberCache): When creating the MemberCache for a class, get
24260 members from the current class and all its base classes.
24261 (MemberCache.CacheEntry.Container): New field. This is a
24262 temporary hack until the Mono runtime is fixed to distinguish
24263 between ReflectedType and DeclaringType. It allows us to use MCS
24264 with both the MS runtime and the unfixed Mono runtime without
24265 problems and without accecting performance.
24266 (MemberCache.SearchMembers): The DeclaredOnly looping from
24267 TypeManager.MemberLookup is now done here.
24269 2002-08-14 Martin Baulig <martin@gnome.org>
24271 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24272 Type.GetFields on dynamic types but get the fields from the
24273 corresponding TypeContainer.
24274 (MyStructInfo.GetStructInfo): Added check for enum types.
24276 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24277 (MemberList.SyncRoot): Implemented.
24278 (TypeManager.FilterWithClosure): No need to check permissions if
24279 closure_start_type == closure_invocation_type, don't crash if
24280 closure_invocation_type is null.
24282 2002-08-13 Martin Baulig <martin@gnome.org>
24284 Rewrote TypeContainer.FindMembers to use a member cache. This
24285 gives us a speed increase of about 35% for the self-hosting MCS
24286 build and of about 15-20% for the class libs (both on GNU/Linux).
24288 * report.cs (Timer): New class to get enhanced profiling. This
24289 whole class is "TIMER" conditional since it remarkably slows down
24292 * class.cs (MemberList): New class. This is an IList wrapper
24293 which we're now using instead of passing MemberInfo[]'s around to
24294 avoid copying this array unnecessarily.
24295 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24296 (ICachingMemberFinder, IMemberContainer): New interface.
24297 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24298 has already been checked, otherwise use it for the name comparision.
24299 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24300 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24301 if possible. Returns a MemberList, not a MemberInfo [].
24302 (TypeHandle): New class, implements IMemberContainer. We create
24303 one instance of this class per type, it contains a MemberCache
24304 which is used to do the member lookups.
24305 (MemberCache): New class. Each instance of this class contains
24306 all members of a type and a name-based hash table.
24307 (MemberCache.FindMembers): This is our new member lookup
24308 function. First, it looks up all members of the requested name in
24309 the hash table. Then, it walks this list and sorts out all
24310 applicable members and returns them.
24312 2002-08-13 Martin Baulig <martin@gnome.org>
24314 In addition to a nice code cleanup, this gives us a performance
24315 increase of about 1.4% on GNU/Linux - not much, but it's already
24316 half a second for the self-hosting MCS compilation.
24318 * typemanager.cs (IMemberFinder): New interface. It is used by
24319 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24320 Enum, Delegate or Interface.
24321 (TypeManager.finder_to_member_finder): New PtrHashtable.
24322 (TypeManager.finder_to_container): Removed.
24323 (TypeManager.finder_to_delegate): Removed.
24324 (TypeManager.finder_to_interface): Removed.
24325 (TypeManager.finder_to_enum): Removed.
24327 * interface.cs (Interface): Implement IMemberFinder.
24329 * delegate.cs (Delegate): Implement IMemberFinder.
24331 * enum.cs (Enum): Implement IMemberFinder.
24333 * class.cs (TypeContainer): Implement IMemberFinder.
24335 2002-08-12 Martin Baulig <martin@gnome.org>
24337 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24339 2002-08-12 Martin Baulig <martin@gnome.org>
24341 * ecore.cs (ITypeExpression): New interface for expressions which
24343 (TypeExpression): Renamed to TypeLookupExpression.
24344 (Expression.DoResolve): If we're doing a types-only lookup, the
24345 expression must implement the ITypeExpression interface and we
24346 call DoResolveType() on it.
24347 (SimpleName): Implement the new ITypeExpression interface.
24348 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24349 hack, the situation that we're only looking up types can't happen
24350 anymore when this method is called. Moved the type lookup code to
24351 DoResolveType() and call it.
24352 (SimpleName.DoResolveType): This ITypeExpression interface method
24353 is now doing the types-only lookup.
24354 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24355 (ResolveFlags): Added MaskExprClass.
24357 * expression.cs (MemberAccess): Implement the ITypeExpression
24359 (MemberAccess.DoResolve): Added support for a types-only lookup
24360 when we're called via ITypeExpression.DoResolveType().
24361 (ComposedCast): Implement the ITypeExpression interface.
24363 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24364 Expression.Resolve() with ResolveFlags.Type instead.
24366 2002-08-12 Martin Baulig <martin@gnome.org>
24368 * interface.cs (Interface.Define): Apply attributes.
24370 * attribute.cs (Attribute.ApplyAttributes): Added support for
24371 interface attributes.
24373 2002-08-11 Martin Baulig <martin@gnome.org>
24375 * statement.cs (Block.Emit): Only check the "this" variable if we
24376 do not always throw an exception.
24378 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24379 whether the property has a set accessor.
24381 2002-08-11 Martin Baulig <martin@gnome.org>
24383 Added control flow analysis support for structs.
24385 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24386 with control flow analysis turned off.
24387 (IVariable): New interface.
24388 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24389 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24390 (FieldExpr.DoResolve): Resolve the instance expression with flow
24391 analysis turned off and do the definite assignment check after the
24392 resolving when we know what the expression will resolve to.
24394 * expression.cs (LocalVariableReference, ParameterReference):
24395 Implement the new IVariable interface, only call the flow analysis
24396 code if ec.DoFlowAnalysis is true.
24397 (This): Added constructor which takes a Block argument. Implement
24398 the new IVariable interface.
24399 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24400 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24401 This does the definite assignment checks for struct members.
24403 * class.cs (Constructor.Emit): If this is a non-static `struct'
24404 constructor which doesn't have any initializer, call
24405 Block.AddThisVariable() to tell the flow analysis code that all
24406 struct elements must be initialized before control returns from
24409 * statement.cs (MyStructInfo): New public class.
24410 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24411 argument to this indexer. If non-zero, check an individual struct
24412 member, not the whole struct.
24413 (FlowBranching.CheckOutParameters): Check struct members.
24414 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24415 overloaded versions of these methods which take an additional
24416 `int field_idx' argument to check struct members.
24417 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24418 overloaded versions of these methods which take an additional
24419 `string field_name' argument to check struct member.s
24420 (VariableInfo): Implement the IVariable interface.
24421 (VariableInfo.StructInfo): New public property. Returns the
24422 MyStructInfo instance of the variable if it's a struct or null.
24423 (Block.AddThisVariable): New public method. This is called from
24424 Constructor.Emit() for non-static `struct' constructor which do
24425 not have any initializer. It creates a special variable for the
24426 "this" instance variable which will be checked by the flow
24427 analysis code to ensure that all of the struct's fields are
24428 initialized before control returns from the constructor.
24429 (UsageVector): Added support for struct members. If a
24430 variable/parameter is a struct with N members, we reserve a slot
24431 in the usage vector for each member. A struct is considered fully
24432 initialized if either the struct itself (slot 0) or all its
24433 members are initialized.
24435 2002-08-08 Martin Baulig <martin@gnome.org>
24437 * driver.cs (Driver.MainDriver): Only report an error CS5001
24438 if there were no compilation errors.
24440 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24441 `UnsafeContext' property to determine whether the parent is in
24442 unsafe context rather than checking the parent's ModFlags:
24443 classes nested in an unsafe class are unsafe as well.
24445 2002-08-08 Martin Baulig <martin@gnome.org>
24447 * statement.cs (UsageVector.MergeChildren): Distinguish between
24448 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24449 we return. Added test17() and test18() to test-154.cs.
24451 2002-08-08 Martin Baulig <martin@gnome.org>
24453 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24454 Family access, make sure the invoking type isn't a subclass of the
24455 queried type (that'd be a CS1540).
24457 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24458 this method which takes an additional `Type invocation_type'.
24460 * expression.cs (BaseAccess.DoResolve): Use the base type as
24461 invocation and query type.
24462 (MemberAccess.DoResolve): If the lookup failed and we're about to
24463 report a CS0122, try a lookup with the ec.ContainerType - if this
24464 succeeds, we must report a CS1540.
24466 2002-08-08 Martin Baulig <martin@gnome.org>
24468 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24469 (MethodGroupExpr): Implement the IMemberExpr interface.
24471 * expression (MemberAccess.ResolveMemberAccess): No need to have
24472 any special code for MethodGroupExprs anymore, they're now
24475 2002-08-08 Martin Baulig <martin@gnome.org>
24477 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24478 Family, FamANDAssem and FamORAssem permissions.
24479 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24481 2002-08-08 Martin Baulig <martin@gnome.org>
24483 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24484 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24487 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24489 * driver.cs: implemented /resource option to embed managed resources.
24491 2002-08-07 Martin Baulig <martin@gnome.org>
24493 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24494 (FieldBase.HasFieldInitializer): New public property.
24495 (FieldBase.GetInitializerExpression): New public method. Resolves and
24496 returns the field initializer and makes sure it is only resolved once.
24497 (TypeContainer.EmitFieldInitializers): Call
24498 FieldBase.GetInitializerExpression to get the initializer, this ensures
24499 that it isn't resolved multiple times.
24501 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24502 the resolving process (SimpleName/MemberLookup) that we're currently
24503 emitting a field initializer (which must not access any instance members,
24504 this is an error CS0236).
24506 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24507 argument, if the `IsFieldInitializer' flag is set, we must report and
24508 error CS0236 and not an error CS0120.
24510 2002-08-07 Martin Baulig <martin@gnome.org>
24512 * ecore.cs (IMemberExpr): New public interface.
24513 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24514 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24515 if the expression is an IMemberExpr.
24517 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24518 to be null, implicitly default to `this' if we're non-static in
24519 this case. Simplified the code a lot by using the new IMemberExpr
24520 interface. Also fixed bug #28176 here.
24522 2002-08-06 Martin Baulig <martin@gnome.org>
24524 * cs-parser.jay (SimpleLookup): Removed. We need to create
24525 ParameterReferences during semantic analysis so that we can do a
24526 type-only search when resolving Cast, TypeOf and SizeOf.
24527 (block): Pass the `current_local_parameters' to the Block's
24530 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24531 argument to the constructor.
24532 (ConstructorInitializer.Resolve): Create a temporary implicit
24533 block with the parameters.
24535 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24536 references here if we aren't doing a type-only search.
24538 * statement.cs (Block): Added constructor which takes a
24539 `Parameters parameters' argument.
24540 (Block.Parameters): New public property.
24542 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24543 to `Parameters' and made it public readonly.
24545 2002-08-06 Martin Baulig <martin@gnome.org>
24547 * ecore.cs (Expression.Warning): Made this public as well.
24549 * report.cs (Report.Debug): Print the contents of collections.
24551 2002-08-06 Martin Baulig <martin@gnome.org>
24553 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24554 used to tell Resolve() which kinds of expressions it may return.
24555 (Expression.Resolve): Added overloaded version of this method which
24556 takes a `ResolveFlags flags' argument. This can be used to tell
24557 Resolve() which kinds of expressions it may return. Reports a
24559 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24560 ResolveFlags.SimpleName.
24561 (Expression.Error118): Added overloaded version of this method which
24562 takes a `ResolveFlags flags' argument. It uses the flags to determine
24563 which kinds of expressions are allowed.
24565 * expression.cs (Argument.ResolveMethodGroup): New public method.
24566 Resolves an argument, but allows a MethodGroup to be returned.
24567 This is used when invoking a delegate.
24569 * TODO: Updated a bit.
24571 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24573 Fixed compilation with csc.
24575 * ecore.cs: Expression.Error made public. Is this correct? Should
24576 Warning be made public too?
24578 * expression.cs: use ea.Location instead of ea.loc.
24579 [FIXME: Filed as bug #28607: MCS must report these errors.]
24581 2002-08-06 Martin Baulig <martin@gnome.org>
24583 * ecore.cs (Expression.loc): Moved the location here instead of
24584 duplicating it in all derived classes.
24585 (Expression.Location): New public property.
24586 (Expression.Error, Expression.Warning): Made them non-static and
24587 removed the location argument.
24588 (Expression.Warning): Added overloaded version which takes an
24589 `int level' argument.
24590 (Expression.Error118): Make this non-static and removed the
24591 expression and location arguments.
24592 (TypeExpr): Added location argument to the constructor.
24594 * expression.cs (StaticCallExpr): Added location argument to
24596 (Indirection, PointerArithmetic): Likewise.
24597 (CheckedExpr, UnCheckedExpr): Likewise.
24598 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
24599 (StringPtr): Likewise.
24602 2002-08-05 Martin Baulig <martin@gnome.org>
24604 * expression.cs (BaseAccess.DoResolve): Actually report errors.
24606 * assign.cs (Assign.DoResolve): Check whether the source
24607 expression is a value or variable.
24609 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
24610 while resolving the corresponding blocks.
24612 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
24613 an error, don't silently return null.
24615 * statement.cs (Block.AddVariable): Do the error reporting here
24616 and distinguish between CS0128 and CS0136.
24617 (Block.DoResolve): Report all unused labels (warning CS0164).
24618 (LabeledStatement): Pass the location to the constructor.
24619 (LabeledStatement.HasBeenReferenced): New property.
24620 (LabeledStatement.Resolve): Set it to true here.
24622 * statement.cs (Return.Emit): Return success even after reporting
24623 a type mismatch error (CS0126 or CS0127), this is what csc does and
24624 it avoids confusing the users with any consecutive errors.
24626 2002-08-05 Martin Baulig <martin@gnome.org>
24628 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
24630 * const.cs (Const.LookupConstantValue): Catch circular definitions.
24632 * expression.cs (MemberAccess.DoResolve): Silently return if an
24633 error has already been reported.
24635 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
24636 error has already been reported.
24638 2002-08-05 Martin Baulig <martin@gnome.org>
24640 * statement.cs (UsageVector): Only initialize the `parameters'
24641 vector if we actually have any "out" parameters.
24643 2002-08-05 Martin Baulig <martin@gnome.org>
24645 * expression.cs (Binary.ResolveOperator): When combining delegates,
24646 they must have the same type.
24648 2002-08-05 Martin Baulig <martin@gnome.org>
24650 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
24651 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
24652 work with the ms runtime and we also don't need it: if we're a
24653 PropertyBuilder and not in the `indexer_arguments' hash, then we
24654 are a property and not an indexer.
24656 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
24657 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
24658 since the latter one doesn't work with the ms runtime.
24660 2002-08-03 Martin Baulig <martin@gnome.org>
24662 Fixed bugs #27998 and #22735.
24664 * class.cs (Method.IsOperator): New public field.
24665 (Method.CheckBase): Report CS0111 if there's already a method
24666 with the same parameters in the current class. Report CS0508 when
24667 attempting to change the return type of an inherited method.
24668 (MethodData.Emit): Report CS0179 if a method doesn't have a body
24669 and it's not marked abstract or extern.
24670 (PropertyBase): New abstract base class for Property and Indexer.
24671 (PropertyBase.CheckBase): Moved here from Property and made it work
24673 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
24674 the same so we can reuse it there.
24675 (Property, Indexer): Derive from PropertyBase.
24676 (MethodSignature.inheritable_property_signature_filter): New delegate
24677 to find properties and indexers.
24679 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
24680 argument and improved error reporting.
24682 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
24683 EmptyReadOnlyParameters and made it a property.
24685 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
24686 version of this method which takes a `PropertyInfo indexer'.
24687 (TypeManager.RegisterIndexer): New method.
24689 * class.cs: Added myself as author of this file :-)
24691 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24693 * class.cs: fixed compilation on windoze.
24695 2002-08-03 Martin Baulig <martin@gnome.org>
24697 * interface.cs (Interface.GetInterfaceBases): Check whether all
24698 base interfaces are at least as accessible than the current one.
24700 * class.cs (TypeContainer.GetClassBases): Check whether base types
24701 are at least as accessible than the current type.
24702 (TypeContainer.AsAccessible): Implemented and made non-static.
24703 (MemberBase.CheckParameters): Report errors if the accessibility
24706 * delegate.cs (Delegate.Delegate): The default visibility is
24707 internal for top-level types and private for nested types.
24708 (Delegate.Define): Report errors if the accessibility checks fail.
24710 * enum.cs (Enum.Enum): The default visibility is internal for
24711 top-level types and private for nested types.
24712 (Enum.DefineType): Compute the correct visibility.
24714 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
24715 function which takes a `bool is_toplevel' instead of a TypeContainer.
24717 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
24720 2002-08-02 Martin Baulig <martin@gnome.org>
24722 * expression.cs (LocalVariableReferenc): Added constructor which
24723 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
24724 (LocalVariableReference.IsReadOnly): New property.
24725 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
24726 variable is readonly, use our own readonly flag to do this; you can
24727 use the new constructor to get a writable reference to a read-only
24730 * cs-parser.jay (foreach_statement, using_statement): Get a writable
24731 reference to the local variable.
24733 2002-08-01 Miguel de Icaza <miguel@ximian.com>
24735 * rootcontext.cs (ResolveCore): Also include System.Exception
24737 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
24738 we reach an EmptyStatement.
24740 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
24743 * expression.cs (Binary.ResolveOperator): Check error result in
24746 use brtrue/brfalse directly and avoid compares to null.
24748 2002-08-02 Martin Baulig <martin@gnome.org>
24750 * class.cs (TypeContainer.Define): Define all nested interfaces here.
24751 Fixes bug #28407, added test-155.cs.
24753 2002-08-01 Martin Baulig <martin@gnome.org>
24755 * class.cs (Event.EmitDefaultMethod): Make this work with static
24756 events. Fixes #28311, added verify-3.cs.
24758 2002-08-01 Martin Baulig <martin@gnome.org>
24760 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
24761 `is_disposable' fields.
24762 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
24763 `hm.is_disposable' if we're using the collection pattern.
24764 (Foreach.EmitCollectionForeach): Use the correct type for the
24765 enumerator's local variable, only emit the try/finally block if
24766 necessary (fixes #27713).
24768 2002-08-01 Martin Baulig <martin@gnome.org>
24770 * ecore.cs (Expression.report118): Renamed to Error118 and made
24773 * statement.cs (Throw.Resolve): Check whether the expression is of
24774 the correct type (CS0118) and whether the type derives from
24775 System.Exception (CS0155).
24776 (Catch.Resolve): New method. Do the type lookup here and check
24777 whether it derives from System.Exception (CS0155).
24778 (Catch.CatchType, Catch.IsGeneral): New public properties.
24780 * typemanager.cs (TypeManager.exception_type): Added.
24782 2002-07-31 Miguel de Icaza <miguel@ximian.com>
24784 * driver.cs: Updated About function.
24786 2002-07-31 Martin Baulig <martin@gnome.org>
24788 Implemented Control Flow Analysis.
24790 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
24791 (EmitContext.CurrentBranching): Added.
24792 (EmitContext.StartFlowBranching): Added.
24793 (EmitContext.EndFlowBranching): Added.
24794 (EmitContext.KillFlowBranching): Added.
24795 (EmitContext.IsVariableAssigned): Added.
24796 (EmitContext.SetVariableAssigned): Added.
24797 (EmitContext.IsParameterAssigned): Added.
24798 (EmitContext.SetParameterAssigned): Added.
24799 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
24800 Added control flow analysis stuff here.
24802 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
24803 resolve the expression as lvalue.
24804 (LocalVariableReference.DoResolve): Check whether the variable has
24805 already been assigned.
24806 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
24807 the parameter as assigned here.
24808 (ParameterReference.DoResolve): Check whether the parameter has already
24810 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
24811 expression as lvalue.
24813 * statement.cs (FlowBranching): New class for the flow analysis code.
24814 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
24815 (LabeledStatement.IsDefined): New public property.
24816 (LabeledStatement.AddUsageVector): New public method to tell flow
24817 analyis that the label may be reached via a forward jump.
24818 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
24820 (VariableInfo.Number): New public field. This is used by flow analysis
24821 to number all locals of a block.
24822 (Block.CountVariables): New public property. This is the number of
24823 local variables in this block (including the locals from all parent
24825 (Block.EmitMeta): Number all the variables.
24827 * statement.cs: Added flow analysis support to all classes.
24829 2002-07-31 Martin Baulig <martin@gnome.org>
24831 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
24832 To get debugging messages, compile mcs with /define:MCS_DEBUG and
24833 then use this argument.
24835 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
24837 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
24838 use this to specify /define options.
24840 2002-07-29 Martin Baulig <martin@gnome.org>
24842 * statement.cs (Fixed): Moved all code that does variable lookups
24843 and resolvings from Emit to Resolve.
24845 * statement.cs (For): Moved all code that does variable lookups
24846 and resolvings from Emit to Resolve.
24848 * statement.cs (Using): Moved all code that does variable lookups
24849 and resolvings from Emit to Resolve.
24851 2002-07-29 Martin Baulig <martin@gnome.org>
24853 * attribute.cs (Attribute.Resolve): Explicitly catch a
24854 System.NullReferenceException when creating the
24855 CustromAttributeBuilder and report a different warning message.
24857 2002-07-29 Martin Baulig <martin@gnome.org>
24859 * support.cs (ParameterData.ParameterName): Added method to
24860 get the name of a parameter.
24862 * typemanager.cs (TypeManager.IsValueType): New public method.
24864 2002-07-29 Martin Baulig <martin@gnome.org>
24866 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
24867 is a flag which specifies that it's either ref or out.
24868 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
24869 the out parameter to `out Parameter.Modifier mod', also set the
24870 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
24872 * support.cs (InternalParameters.ParameterModifier): Distinguish
24873 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24874 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24876 * expression.cs (Argument.GetParameterModifier): Distinguish
24877 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
24878 Parameter.Modifier.ISBYREF flag if it's either ref or out.
24880 2002-07-29 Martin Baulig <martin@gnome.org>
24882 * expression.cs (ParameterReference.ParameterReference): Added
24883 `Location loc' argument to the constructor.
24885 * cs-parser.jay: Pass location to ParameterReference.
24887 2002-07-28 Miguel de Icaza <miguel@ximian.com>
24889 * statement.cs (Try): Initialize the location.
24891 * cs-parser.jay: pass location to Try.
24893 * expression.cs (Unary.Reduce): Change the prototype to return
24894 whether a constant fold could be performed or not. The result is
24895 returned in an out parameters. In the case of Indirection and
24896 AddressOf, we want to perform the full tests.
24898 2002-07-26 Miguel de Icaza <miguel@ximian.com>
24900 * statement.cs (Statement.Emit): Flag dead code.
24902 2002-07-27 Andrew Birkett <andy@nobugs.org>
24904 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
24906 2002-07-27 Martin Baulig <martin@gnome.org>
24908 * class.cs (MethodData.Define): Put back call to
24909 TypeManager.AddMethod(), accidentally commented this out.
24911 * report.cs (Debug): New public method to print debugging information,
24912 this is `[Conditional ("DEBUG")]'.
24914 2002-07-26 Martin Baulig <martin@gnome.org>
24916 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
24917 (switch_statement): Push the current_block to the switch_stack and
24918 pop it again when we're done with the switch.
24919 (switch_section): The new block is a child of the current_block.
24920 Fixes bug #24007, added test-152.cs.
24922 2002-07-27 Martin Baulig <martin@gnome.org>
24924 * expression.cs (Invocation.EmitArguments): When calling a varargs
24925 function with only its fixed arguments, we need to pass an empty
24928 2002-07-27 Martin Baulig <martin@gnome.org>
24930 Mono 0.13 has been released.
24932 2002-07-25 Miguel de Icaza <miguel@ximian.com>
24934 * driver.cs: Rename --resource to --linkres, because that is what
24935 we do currently, we dont support --resource yet.
24937 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
24939 2002-07-25 Martin Baulig <martin@gnome.org>
24941 * class.cs (MethodData): New public class. This is a `method builder'
24942 class for a method or one accessor of a Property/Indexer/Event.
24943 (MethodData.GetMethodFlags): Moved here from MemberBase.
24944 (MethodData.ApplyAttributes): Likewise.
24945 (MethodData.ApplyObsoleteAttribute): Likewise.
24946 (MethodData.ApplyConditionalAttribute): Likewise.
24947 (MethodData.ApplyDllImportAttribute): Likewise.
24948 (MethodData.CheckAbstractAndExternal): Likewise.
24949 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
24950 (MethodData.Emit): Formerly known as Method.Emit().
24951 (MemberBase): Moved everything which was specific to a single
24952 accessor/method to MethodData.
24953 (Method): Create a new MethodData and call Define() and Emit() on it.
24954 (Property, Indexer, Event): Create a new MethodData objects for each
24955 accessor and call Define() and Emit() on them.
24957 2002-07-25 Martin Baulig <martin@gnome.org>
24959 Made MethodCore derive from MemberBase to reuse the code from there.
24960 MemberBase now also checks for attributes.
24962 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
24963 (MemberBase.GetMethodFlags): Moved here from class Method and marked
24965 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
24966 `CallingConventions cc' and `Attributes opt_attrs' arguments.
24967 (MemberBase.ApplyAttributes): New virtual method; applies the
24968 attributes to a method or accessor.
24969 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
24970 (MemberBase.ApplyConditionalAttribute): Likewise.
24971 (MemberBase.ApplyDllImportAttribute): Likewise.
24972 (MemberBase.CheckAbstractAndExternal): Likewise.
24973 (MethodCore.ParameterTypes): This is now a property instead of a
24974 method, it's initialized from DoDefineParameters().
24975 (MethodCore.ParameterInfo): Removed the set accessor.
24976 (MethodCore.DoDefineParameters): New protected virtual method to
24977 initialize ParameterTypes and ParameterInfo.
24978 (Method.GetReturnType): We can now simply return the MemberType.
24979 (Method.GetMethodFlags): Override the MemberBase version and add
24980 the conditional flags.
24981 (Method.CheckBase): Moved some code from Define() here, call
24982 DoDefineParameters() here.
24983 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
24984 here to avoid some larger code duplication.
24985 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
24986 ensure that abstract and external accessors don't declare a body.
24988 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
24989 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
24990 lookup in the attribute's parent classes, so we need to abort as soon
24991 as we found the first match.
24992 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
24993 the attribute has no arguments.
24995 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
24998 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25000 * cs-parser.jay: reverted previous patch.
25002 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25004 * cs-parser.jay: fixed bug #22119.
25006 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25008 * attribute.cs: fixed compilation. The error was:
25009 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25010 be assigned to before control leaves the current method."
25011 [FIXME: Filed as bug #28186: MCS must report this error.]
25013 2002-07-25 Martin Baulig <martin@gnome.org>
25015 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25016 method to pull the condition name ouf of a Conditional attribute.
25017 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25018 the obsolete message and error flag out of an Obsolete attribute.
25020 * class.cs (Method.GetMethodFlags): New public method to get the
25021 TypeManager.MethodFlags for this method.
25022 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25024 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25025 if we're overriding a virtual function, set the new private variable
25026 `parent_method'; call the new TypeManager.AddMethod().
25028 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25029 the MethodBuilder and the Method in a PtrHashtable.
25030 (TypeManager.builder_to_method): Added for this purpose.
25031 (TypeManager.MethodFlags): Added IsObsoleteError.
25032 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25033 Obsolete and Conditional arguments in MethodBuilders. If we discover
25034 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25035 the message from the attribute.
25037 2002-07-24 Martin Baulig <martin@gnome.org>
25039 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25040 preprocessor directives, ensure that the argument to #define/#undef is
25041 exactly one identifier and that it's actually an identifier.
25043 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25046 2002-07-24 Martin Baulig <martin@gnome.org>
25048 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25049 initialize it to TypeManager.object_type in the constructor.
25050 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25051 of the `hm.get_current' method if we're using the collection pattern.
25052 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25053 for the explicit conversion to make it work when we're using the collection
25054 pattern and the `Current' property has a different return type than `object'.
25057 2002-07-24 Martin Baulig <martin@gnome.org>
25059 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25060 does not match, but don't report any errors. This method is called in
25061 order for all methods in a MethodGroupExpr until a matching method is
25062 found, so we don't want to bail out if the first method doesn't match.
25063 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25064 matches, report the 123. Fixes #28070.
25066 2002-07-24 Martin Baulig <martin@gnome.org>
25068 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25069 TypeManager.TypeToCoreType() to the top of the method so the
25070 following equality checks will work. Fixes #28107.
25072 2002-07-24 Martin Baulig <martin@gnome.org>
25074 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25075 operand is of type uint, and the other operand is of type sbyte,
25076 short or int, the operands are converted to type long." -
25077 Actually do what this comment already told us. Fixes bug #28106,
25080 2002-07-24 Martin Baulig <martin@gnome.org>
25082 * class.cs (MethodBase): New abstract class. This is now a base
25083 class for Property, Indexer and Event to avoid some code duplication
25084 in their Define() and DefineMethods() methods.
25085 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25086 generic methods for Define() and DefineMethods().
25087 (FieldBase): Derive from MemberBase, not MemberCore.
25088 (Property): Derive from MemberBase, not MemberCore.
25089 (Property.DefineMethod): Moved all the code from this method to the
25090 new MethodBase.DefineAccessor(), just call it with appropriate
25092 (Property.Define): Call the new Property.DoDefine(), this does some
25093 sanity checks and we don't need to duplicate the code everywhere.
25094 (Event): Derive from MemberBase, not MemberCore.
25095 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25096 accessors, this will also make them work with interface events.
25097 (Indexer): Derive from MemberBase, not MemberCore.
25098 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25099 (Indexer.Define): Use the new MethodBase functions.
25101 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25102 argument to the constructor.
25103 (Interface.FindMembers): Added support for interface events.
25104 (Interface.PopluateEvent): Implemented.
25106 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25108 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25110 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25111 but this is required to check for a method name being the same as
25112 the containing class.
25116 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25118 * interface.cs: initialize variable.
25120 2002-07-23 Martin Baulig <martin@gnome.org>
25122 Implemented the IndexerName attribute in interfaces.
25124 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25125 name if this is an explicit interface implementation.
25126 (Indexer.InterfaceIndexerName): New public variable. If we're
25127 implementing an interface indexer, this is the IndexerName in that
25128 interface. Otherwise, it's the IndexerName.
25129 (Indexer.DefineMethod): If we're implementing interface indexer,
25130 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25131 and Pending.ImplementIndexer methods.
25132 (Indexer.Define): Also define the PropertyBuilder if we're
25133 implementing an interface indexer and this is neither an explicit
25134 interface implementation nor do the IndexerName match the one in
25137 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25138 If a method is defined here, then we always need to create a proxy
25139 for it. This is used when implementing interface indexers.
25140 (Pending.IsInterfaceIndexer): New public method.
25141 (Pending.ImplementIndexer): New public method.
25142 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25143 This is used when implementing interface indexers to define a proxy
25145 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25146 define a proxy if necessary.
25148 * interface.cs (Interface.IndexerName): New public variable.
25149 (Interface.PopulateIndexer): Set the IndexerName.
25150 (Interface.DefineIndexers): New private method. Populate all the
25151 indexers and make sure their IndexerNames match.
25153 * typemanager.cs (IndexerPropertyName): Added support for interface
25156 2002-07-22 Martin Baulig <martin@gnome.org>
25158 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25159 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25160 ret if HasReturnLabel.
25161 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25164 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25165 and set the ec.LoopBeginTryCatchLevel.
25166 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25167 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25168 the current ec.TryCatchLevel, the branch goes out of an exception
25169 block. In this case, we need to use Leave and not Br.
25171 2002-07-22 Martin Baulig <martin@gnome.org>
25173 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25174 block unless the block does not always return or it is contained in
25175 another try { ... } catch { ... } block. Fixes bug #26506.
25176 Added verify-1.cs to the test suite.
25178 2002-07-22 Martin Baulig <martin@gnome.org>
25180 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25181 then we do not always return. Fixes bug #24985.
25183 2002-07-22 Martin Baulig <martin@gnome.org>
25185 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25186 lookup on a per-class level; ie. walk up the class hierarchy until we
25187 found at least one applicable method, then choose the best among them.
25188 Fixes bug #24463 and test-29.cs.
25190 2002-07-22 Martin Baulig <martin@gnome.org>
25192 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25193 return types of the methods. The return type is not part of the
25194 signature and we must not check it to make the `new' modifier work.
25195 Fixes bug #27999, also added test-147.cs.
25196 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25198 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25199 on the method's return type.
25201 2002-07-21 Martin Baulig <martin@gnome.org>
25203 * assign.cs: Make this work if the rightmost source is a constant and
25204 we need to do an implicit type conversion. Also adding a few more tests
25205 to test-38.cs which should have caught this.
25207 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25208 target in the makefile for this. The makefile.gnu is primarily intended
25209 for end-users who don't want to debug the compiler.
25211 2002-07-21 Martin Baulig <martin@gnome.org>
25213 * assign.cs: Improved the Assign class so it can now handle embedded
25214 assignments (X = Y = Z = something). As a side-effect this'll now also
25215 consume less local variables. test-38.cs now passes with MCS, added
25216 a few new test cases to that test.
25218 2002-07-20 Martin Baulig <martin@gnome.org>
25220 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25221 instructions. Fixes bug #27977, also added test-146.cs.
25223 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25225 * cs-tokenizer.cs: fixed getHex ().
25227 2002-07-19 Martin Baulig <martin@gnome.org>
25229 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25230 not Type.GetType() to lookup the array type. This is needed when
25231 we're constructing an array of a user-defined type.
25232 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25233 single-dimensional arrays, but also for single-dimensial arrays of
25236 2002-07-19 Martin Baulig <martin@gnome.org>
25238 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25239 this function is called, it's not allowed to share LocalBuilders
25240 among ILGenerators.
25242 2002-07-19 Martin Baulig <martin@gnome.org>
25244 * expression.cs (Argument.Resolve): Report an error 118 when trying
25245 to pass a type as argument.
25247 2002-07-18 Martin Baulig <martin@gnome.org>
25249 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25250 Conv_R_Un for the signed `long' type.
25252 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25254 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25255 `expr' for the temporary result, as that will fail if we do
25256 multiple resolves on the same expression.
25258 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25260 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25261 ec.TypeContainer for looking up aliases.
25263 * class.cs (TypeContainer): Remove LookupAlias from here.
25265 * decl.cs (DeclSpace); Move here.
25267 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25269 * class.cs (FindMembers): Only call filter if the constructor
25270 bulider is not null.
25272 Also handle delegates in `NestedTypes' now. Now we will perform
25273 type lookups using the standard resolution process. This also
25276 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25277 This uses Expressions (the limited kind that can be parsed by the
25278 tree) instead of strings.
25280 * expression.cs (ComposedCast.ToString): Implement, used to flag
25281 errors since now we have to render expressions.
25283 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25286 * ecore.cs (SimpleName.ToString): ditto.
25288 * cs-parser.jay: Instead of using strings to assemble types, use
25289 Expressions to assemble the type (using SimpleName, ComposedCast,
25290 MemberAccess). This should fix the type lookups in declarations,
25291 because we were using a different code path for this.
25293 * statement.cs (Block.Resolve): Continue processing statements
25294 even when there is an error.
25296 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25298 * class.cs (Event.Define): Also remove the `remove' method from
25299 the list of pending items.
25301 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25302 generate more compact code.
25304 2002-07-17 Martin Baulig <martin@gnome.org>
25306 * const.cs (Const.LookupConstantValue): Add support for constant
25307 `unchecked' and `checked' expressions.
25308 Also adding test case test-140.cs for this.
25310 2002-07-17 Martin Baulig <martin@gnome.org>
25312 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25313 check whether mi.ReturnType implements the IEnumerator interface; the
25314 `==' and the IsAssignableFrom() will fail in this situation.
25316 2002-07-16 Ravi Pratap <ravi@ximian.com>
25318 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25321 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25323 * expression.cs: fixed bug #27811.
25325 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25327 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25328 Molaro: when we are a ref, the value already contains a pointer
25329 value, do not take the address of it.
25331 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25332 * removed mb-parser.jay and mb-tokenizer.cs
25334 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25336 * expression.cs: check against the building corlib void type.
25338 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25340 * ecore.cs: fix for valuetype static readonly fields: when
25341 initializing them, we need their address, not the address of a copy.
25343 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25345 * typemanager.cs: register also enum_type in corlib.
25347 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25349 * class.cs: allow calling this (but not base) initializers in structs.
25351 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25353 * ecore.cs: make sure we compare against the building base types
25356 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25358 * typemanager.cs: fix TypeToCoreType() to handle void and object
25359 (corlib gets no more typerefs after this change).
25361 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25363 * expression.cs (ArrayCreation.EmitArrayArguments): use
25364 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25366 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25367 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25368 array indexes, the runtime actually forbids them.
25370 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25371 for array arguments here.
25373 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25374 instead of the default for ValueTypes.
25376 (New.DoEmit): Use IsValueType instead of
25377 IsSubclassOf (value_type)
25378 (New.DoResolve): ditto.
25379 (Invocation.EmitCall): ditto.
25381 * assign.cs (Assign): ditto.
25383 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25384 Statements *are* currently doing part of their resolution during
25387 Expressions do always resolve during resolve, but statements are
25388 only required to propagate resolution to their children.
25390 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25392 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25394 (LoadAssembly): Do not add the dll if it is already specified
25396 (MainDriver): Add the System directory to the link path at the end,
25397 after all the other -L arguments.
25399 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25400 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25401 ldelem.u1) and using the opposite for sbytes.
25403 This fixes Digger, and we can finally run it.
25405 * driver.cs (UnixParseOption): Move the option parsing here.
25406 (CSCParseOption): Implement CSC-like parsing of options.
25408 We now support both modes of operation, the old Unix way, and the
25409 new CSC-like way. This should help those who wanted to make cross
25410 platform makefiles.
25412 The only thing broken is that /r:, /reference: and /lib: are not
25413 implemented, because I want to make those have the same semantics
25414 as the CSC compiler has, and kill once and for all the confussion
25415 around this. Will be doing this tomorrow.
25417 * statement.cs (Unsafe.Resolve): The state is checked during
25418 resolve, not emit, so we have to set the flags for IsUnsfe here.
25420 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25422 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25423 not catch the Error_ObjectRefRequired in SimpleName (as it is
25424 possible to have a class/instance variable name that later gets
25425 deambiguated), we have to check this here.
25427 2002-07-10 Ravi Pratap <ravi@ximian.com>
25429 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25430 make static and put into Expression.
25432 (Event.Define): Register the private field of the event with the
25433 TypeManager so that GetFieldFromEvent can get at it.
25435 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25436 keep track of the private field associated with an event which
25439 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25442 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25444 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25446 * expression.cs (Binary.EmitBranchable): this routine emits the
25447 Binary expression in a branchable context. This basically means:
25448 we need to branch somewhere, not just get the value on the stack.
25450 This works together with Statement.EmitBoolExpression.
25452 * statement.cs (Statement.EmitBoolExpression): Use
25455 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25457 * statement.cs (For): Reduce the number of jumps in loops.
25459 (For): Implement loop inversion for the For statement.
25461 (Break): We can be breaking out of a Try/Catch controlled section
25462 (foreach might have an implicit try/catch clause), so we need to
25463 use Leave instead of Br.
25465 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25466 now). If the instace expression supports IMemoryLocation, we use
25467 the AddressOf method from the IMemoryLocation to extract the
25468 address instead of emitting the instance.
25470 This showed up with `This', as we were emitting the instance
25471 always (Emit) instead of the Address of This. Particularly
25472 interesting when This is a value type, as we dont want the Emit
25473 effect (which was to load the object).
25475 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25477 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25479 * statement.cs (Checked): Set the CheckedState during the resolve
25480 process too, as the ConvCast operations track the checked state on
25481 the resolve process, and not emit.
25483 * cs-parser.jay (namespace_member_declaration): Flag that we have
25484 found a declaration when we do. This is used to flag error 1529
25486 * driver.cs: Report ok when we display the help only.
25488 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25490 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25492 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25494 * cs-tokenizer.cs (define): We also have to track locally the
25495 defines. AllDefines is just used for the Conditional Attribute,
25496 but we also need the local defines for the current source code.
25498 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25500 * statement.cs (While, For, Do): These loops can exit through a
25501 Break statement, use this information to tell whether the
25502 statement is the last piece of code.
25504 (Break): Flag that we break.
25506 * codegen.cs (EmitContexts): New `Breaks' state variable.
25508 2002-07-03 Martin Baulig <martin@gnome.org>
25510 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25511 modifiers in method declarations in structs. Otherwise, you won't
25512 be able to override things like Object.Equals().
25514 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25516 * class.cs (Method, Property, Indexer): Do not allow the public
25517 modifier to be used in explicit interface implementations.
25519 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25520 override modifiers in method declarations in structs
25522 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25524 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25525 integer or real overflow, report an error
25527 2002-07-02 Martin Baulig <martin@gnome.org>
25529 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25530 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25531 to tell the runtime about our newly created System.Object and
25532 System.ValueType types.
25534 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25536 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25537 struct instead of Ldarg/Starg.
25539 2002-07-02 Martin Baulig <martin@gnome.org>
25541 * expression.cs (Indirection.Indirection): Call
25542 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25544 2002-07-02 Martin Baulig <martin@gnome.org>
25546 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25547 ValueType, call TypeManager.TypeToCoreType() on it.
25548 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25549 the OpCodes.Newarr argument.
25551 2002-07-02 Martin Baulig <martin@gnome.org>
25553 * expression.cs (Invocation.EmitCall): When compiling corlib,
25554 replace all calls to the system's System.Array type to calls to
25555 the newly created one.
25557 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25558 System.Array methods.
25559 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25560 from the system's System.Array type which must be replaced.
25562 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25564 * typemanager.cs: load unverifiable_code_ctor so we can build
25565 corlib using the correct type. Avoid using GetTypeCode() with
25567 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25568 TypeManager.object_type to allow building corlib.
25570 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25572 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25574 2002-07-01 Martin Baulig <martin@gnome.org>
25576 * class.cs: Make the last change actually work, we need to check
25577 whether `ifaces != null' to avoid a crash.
25579 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25581 * class.cs: when we build structs without fields that implement
25582 interfaces, we need to add the interfaces separately, since there is
25583 no API to both set the size and add the interfaces at type creation
25586 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25588 * expression.cs: the dimension arguments to the array constructors
25589 need to be converted if they are a long.
25591 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25593 * class.cs: don't emit ldarg.0 if there is no parent constructor
25594 (fixes showstopper for corlib).
25596 2002-06-29 Martin Baulig <martin@gnome.org>
25598 MCS now compiles corlib on GNU/Linux :-)
25600 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
25601 ie. check for MethodImplOptions.InternalCall.
25603 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
25604 and TypeManager.attribute_type are null, so we must explicitly check
25605 whether parent is not null to find out whether it's an attribute type.
25606 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
25607 and SetBuilder, not only if the property is neither abstract nor external.
25608 This is necessary to set the MethodImplOptions on the accessor methods.
25609 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
25610 SetBuilder, see Property.Emit().
25612 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
25613 populate "System.Object", "System.ValueType" and "System.Attribute" since
25614 they've already been populated from BootCorlib_PopulateCoreTypes().
25616 2002-06-29 Martin Baulig <martin@gnome.org>
25618 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
25619 is the NullLiteral, we also need to make sure that target_type is not
25622 2002-06-29 Martin Baulig <martin@gnome.org>
25624 * rootcontext.cs (RootContext.ResolveCore): We must initialize
25625 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
25626 before calling BootstrapCorlib_ResolveDelegate ().
25628 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25630 * statement.cs: fixed build-breaker. All tests passed ok.
25632 2002-06-27 Martin Baulig <martin@gnome.org>
25634 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
25635 for System.Decimal when compiling corlib.
25637 2002-06-27 Martin Baulig <martin@gnome.org>
25639 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
25640 switch blocks which contain nothing but a default clause.
25642 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
25644 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
25646 2002-06-27 Martin Baulig <martin@gnome.org>
25648 * ecore.cs (PropertyExpr.PropertyExpr): Call
25649 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
25651 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
25652 is already a TypeBuilder.
25654 2002-06-27 Martin Baulig <martin@gnome.org>
25656 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
25657 `target_type == TypeManager.array_type', not IsAssignableFrom() in
25658 the "from an array-type to System.Array" case. This makes it work
25659 when compiling corlib.
25661 2002-06-27 Martin Baulig <martin@gnome.org>
25663 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
25664 non-static PropertyExpr, set its InstanceExpression. This makes
25665 the `ICollection.Count' property work in System/Array.cs.
25667 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
25669 * driver.cs: Made error handling more consistent. Errors now
25670 tracked by Report class, so many methods which used to return int
25671 now return void. Main() now prints success/failure and
25672 errors/warnings message.
25674 Renamed '--probe' compiler argument to '--expect-error'. Removed
25675 the magic number return values (123 and 124). Now, if the
25676 expected error occurs, the compiler exits with success (exit value
25677 0). If the compilation completes without seeing that particular
25678 error, the compiler exits with failure (exit value 1). The
25679 makefile in mcs/errors has been changed to handle the new behaviour.
25681 * report.cs: Made 'expected error' number a property and renamed
25682 it from 'Probe' to 'ExpectedError'.
25684 * genericparser.cs: Removed error handling support, since it is
25685 now all done by Report class.
25687 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
25688 class, so parse() no longer returns an int.
25690 * namespace.cs: Use Report.Error instead of GenericParser.error
25692 2002-06-22 Miguel de Icaza <miguel@ximian.com>
25694 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
25695 TypeContainer.AddOperator): At the front of the list put the
25696 explicit implementations, so they get resolved/defined first.
25698 2002-06-21 Miguel de Icaza <miguel@ximian.com>
25700 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
25701 interface type is implemented by this TypeContainer. Used during
25702 explicit interface implementation.
25704 (Property.Define, Indexer.Define, Method.Define): Validate that
25705 the given interface in the explicit implementation is one of the
25706 base classes for the containing type.
25708 Also if we are explicitly implementing an interface, but there is
25709 no match in the pending implementation table, report an error.
25711 (Property.Define): Only define the property if we are
25712 not explicitly implementing a property from an interface. Use the
25713 correct name also for those properties (the same CSC uses,
25714 although that is really not needed).
25716 (Property.Emit): Do not emit attributes for explicitly implemented
25717 properties, as there is no TypeBuilder.
25719 (Indexer.Emit): ditto.
25721 Hiding then means that we do not really *implement* a pending
25722 implementation, which makes code fail.
25724 2002-06-22 Martin Baulig <martin@gnome.org>
25726 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
25727 the return value of Object.GetType(). [FIXME: we need to do this whenever
25728 we get a type back from the reflection library].
25730 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
25732 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
25734 2002-06-20 Miguel de Icaza <miguel@ximian.com>
25736 * attribute.cs: Return null if we can not look up the type.
25738 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
25739 the interface types found.
25741 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
25742 interface types found.
25744 * typemanager.cs (GetInterfaces): Make this routine returns alll
25745 the interfaces and work around the lame differences between
25746 System.Type and System.Reflection.Emit.TypeBuilder in the results
25747 result for GetInterfaces.
25749 (ExpandInterfaces): Given an array of interface types, expand and
25750 eliminate repeated ocurrences of an interface. This expands in
25751 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
25754 2002-06-21 Martin Baulig <martin@gnome.org>
25756 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
25759 2002-06-21 Martin Baulig <martin@gnome.org>
25761 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
25762 and called with one of the core types, return the corresponding typebuilder for
25765 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
25768 2002-06-21 Martin Baulig <martin@gnome.org>
25770 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
25771 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
25772 (Expression.ConvertReferenceExplicit): Likewise.
25774 * expression.cs (ElementAccess.DoResolve): Likewise.
25775 (ElementAccess.DoResolveLValue): Likewise.
25777 2002-06-10 Martin Baulig <martin@gnome.org>
25779 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
25780 add the "value" parameter to the parameter list.
25782 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
25785 2002-06-19 Miguel de Icaza <miguel@ximian.com>
25787 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
25788 the argument to an int, uint, long or ulong, per the spec. Also
25789 catch negative constants in array creation.
25791 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
25793 * class.cs: do not allow the same interface to appear twice in
25794 the definition list.
25796 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
25798 * ecore.cs: don't use ldlen with System.Array.
25800 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
25802 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
25804 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
25806 * modifiers.cs: produce correct field attributes for protected
25807 internal. Easy fix so miguel can work on ther harder stuff:-)
25809 2002-06-18 Miguel de Icaza <miguel@ximian.com>
25811 * pending.cs: New file. Move the code from class.cs here.
25812 Support clearning the pending flag for all methods (when not doing
25813 explicit interface implementation).
25815 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
25817 * rootcontext.cs: added a couple more types needed to bootstrap.
25819 2002-06-17 Miguel de Icaza <miguel@ximian.com>
25821 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
25822 constructor in the type, instead of any constructor in the type
25823 hierarchy. Thanks to Paolo for finding this bug (it showed up as
25824 a bug in the Mono runtime when applying the params attribute).
25826 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25827 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
25829 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
25831 * expression.cs (Unary.ResolveOperator): Use TypeManager
25832 to resolve the type.
25834 2002-06-13 Ravi Pratap <ravi@ximian.com>
25836 * cs-parser.jay (enum_member_declaration): Pass in the attributes
25839 * enum.cs (AddEnumMember): Add support to store the attributes associated
25840 with each member too.
25842 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
25843 field builders too - this takes care of the enum member case.
25845 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
25847 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
25848 address-of operator on both value types and pointers.
25850 2002-06-10 Martin Baulig <martin@gnome.org>
25852 * interface.cs (Interface.PopulateIndexer): Add the indexer's
25853 PropertyBuilder to the `property_builders' list.
25855 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
25856 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
25857 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
25858 find any indexers which are inherited from an interface.
25860 2002-06-09 Martin Baulig <martin@gnome.org>
25862 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
25863 the same type as the constant if necessary. There's also a test-130.cs
25866 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
25868 * typemanager.cs (TypeManager.ChangeType): Previously known as
25869 Enum.ChangeEnumType().
25871 2002-06-09 Martin Baulig <martin@gnome.org>
25873 * expression.cs (Cast.TryReduce): Added support for consts.
25875 2002-06-08 Ravi Pratap <ravi@ximian.com>
25877 * class.cs (Accessor): Hold attributes information so we can pass
25880 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
25881 Modify to pass in attributes attached to the methods.
25883 (add_accessor_declaration, remove_accessor_declaration): Ditto.
25885 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
25886 to handle the Accessor kind :-)
25888 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
25890 2002-06-08 Martin Baulig <martin@gnome.org>
25892 * expression.cs (Unary.TryReduceNegative): Added support for
25895 2002-06-08 Martin Baulig <martin@gnome.org>
25897 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
25898 name can't be found in the `defined_names' - the caller will do a
25899 MemberLookup in this case and thus find methods in System.Enum
25900 such as Enum.IsDefined().
25902 2002-06-08 Martin Baulig <martin@gnome.org>
25904 * enum.cs (Enum.ChangeEnumType): This is a custom version of
25905 Convert.ChangeType() which works with TypeBuilder created types.
25906 (Enum.LookupEnumValue, Enum.Define): Use it here.
25908 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
25909 `TypeBuilder.BaseType != null' check.
25910 (TypeContainer.FindMembers): Only lookup parent members if we
25911 actually have a parent.
25912 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
25913 (ConstructorInitializer.Resolve): Likewise.
25915 * interface.cs (Interface.FindMembers): Added
25916 `TypeBuilder.BaseType != null' check.
25918 * rootcontext.cs (RootContext.ResolveCore): Added
25919 "System.Runtime.CompilerServices.IndexerNameAttribute" to
25920 classes_second_stage.
25922 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
25923 debug_type and trace_type when compiling with --nostdlib.
25925 2002-06-07 Martin Baulig <martin@gnome.org>
25927 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
25928 (AddField): Set it to true when adding a non-static field.
25929 (DefineType): Use `have_nonstatic_fields' to find out whether we
25930 have non-static fields, not `Fields != null'.
25932 2002-06-02 Miguel de Icaza <miguel@ximian.com>
25934 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
25935 dereferencing a null on the static-field code path)
25937 2002-05-30 Martin Baulig <martin@gnome.org>
25939 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
25940 to take command line arguments. Use reflection to call the new
25941 custom `Initialize' function on the symbol writer and pass it the
25942 command line arguments.
25944 * driver.cs (--debug-args): New command line argument to pass command
25945 line arguments to the symbol writer.
25947 2002-05-28 Miguel de Icaza <miguel@ximian.com>
25949 * assign.cs (DoResolve): Forgot to do the implicit conversion to
25950 the target type for indexers and properties. Thanks to Joe for
25953 2002-05-27 Miguel de Icaza <miguel@ximian.com>
25955 * typemanager.cs (MethodFlags): returns the method flags
25956 (Obsolete/ShouldIgnore) that control warning emission and whether
25957 the invocation should be made, or ignored.
25959 * expression.cs (Invocation.Emit): Remove previous hack, we should
25960 not do this on matching a base type, we should do this based on an attribute
25962 Only emit calls to System.Diagnostics.Debug and
25963 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
25964 on the command line.
25966 * rootcontext.cs: Global settings for tracing and debugging.
25968 * cs-tokenizer.cs (define): New utility function to track
25969 defines. Set the global settings for TRACE and DEBUG if found.
25971 2002-05-25 Ravi Pratap <ravi@ximian.com>
25973 * interface.cs (Populate*): Pass in the TypeContainer as well as
25974 the DeclSpace as parameters so that we can create EmitContexts and
25975 then use that to apply attributes etc.
25977 (PopulateMethod, PopulateEvent, PopulateProperty)
25978 (PopulateIndexer): Apply attributes everywhere.
25980 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
25983 (ApplyAttributes): Update accordingly.
25985 We now apply interface attributes for all members too.
25987 2002-05-26 Miguel de Icaza <miguel@ximian.com>
25989 * class.cs (Indexer.Define); Correctly check if we are explicit
25990 implementation (instead of checking the Name for a ".", we
25991 directly look up if the InterfaceType was specified).
25993 Delay the creation of the PropertyBuilder.
25995 Only create the PropertyBuilder if we are not an explicit
25996 interface implementation. This means that explicit interface
25997 implementation members do not participate in regular function
25998 lookups, and hence fixes another major ambiguity problem in
25999 overload resolution (that was the visible effect).
26001 (DefineMethod): Return whether we are doing an interface
26004 * typemanager.cs: Temporary hack until we get attributes in
26005 interfaces (Ravi is working on that) and we get IndexerName
26006 support in interfaces.
26008 * interface.cs: Register the indexers as properties.
26010 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26011 warning, I have verified that this is a bug in the .NET runtime
26012 (JavaScript suffers of the same problem).
26014 * typemanager.cs (MemberLookup): When looking up members for
26015 interfaces, the parent of an interface is the implicit
26016 System.Object (so we succeed in searches of Object methods in an
26017 interface method invocation. Example: IEnumerable x; x.ToString
26020 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26022 * class.cs (Event): Events should also register if they do
26023 implement the methods that an interface requires.
26025 * typemanager.cs (MemberLookup); use the new GetInterfaces
26028 (GetInterfaces): The code used to lookup interfaces for a type is
26029 used in more than one place, factor it here.
26031 * driver.cs: Track the errors at the bottom of the file, we kept
26034 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26035 instance if the method we are calling is static!
26037 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26039 * attribute.cs (ApplyAttributes): Make this function filter out
26040 the IndexerName attribute (as that attribute in reality is never
26041 applied) and return the string constant for the IndexerName
26044 * class.cs (TypeContainer.Emit): Validate that all the indexers
26045 have the same IndexerName attribute, and if so, set the
26046 DefaultName attribute on the class.
26048 * typemanager.cs: The return value might contain other stuff (not
26049 only methods). For instance, consider a method with an "Item"
26050 property and an Item method.
26052 * class.cs: If there is a problem with the parameter types,
26055 2002-05-24 Ravi Pratap <ravi@ximian.com>
26057 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26058 looks at user defined conversion after making a call to
26059 StandardConversionExists - we need this for overload resolution.
26061 * expression.cs : Update accordingly the various method calls.
26063 This fixes 2 bugs filed against implicit user defined conversions
26065 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26067 * statement.cs: Track the result of the assignment.
26069 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26071 * expression.cs (MemberAccess): Improved error reporting for
26072 inaccessible members.
26074 2002-05-22 Martin Baulig <martin@gnome.org>
26076 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26077 itself with debugging support.
26079 2002-05-22 Martin Baulig <martin@gnome.org>
26081 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26082 Removed, this isn't needed anymore.
26084 2002-05-20 Martin Baulig <martin@gnome.org>
26086 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26087 be underlying type for an enum.
26089 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26091 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26092 that splits out the loading of just the core types.
26094 * rootcontext.cs (ResolveCore): Split the struct resolution in
26095 two, so we can load the enumeration underlying types before any
26098 * expression.cs (Is): Bandaid until we fix properly Switch (see
26099 bug #24985 for details).
26101 * typemanager.cs (ImplementsInterface): The hashtable will contain
26102 a null if there are no interfaces implemented.
26104 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26106 * cs-parser.jay (indexer_declarator): It is fine to have array
26109 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26111 * typemanager.cs: (RegisterBuilder): New function used to register
26112 TypeBuilders that implement interfaces. Since
26113 TypeBuilder.GetInterfaces (as usual) does not work with lame
26115 (AddUserType): register interfaces.
26117 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26118 dealing with TypeBuilder. Also, arrays are showing up as
26119 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26120 methods can not be invoked on them!
26122 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26123 (ImplicitReferenceConversionExists): Split out from
26124 StandardConversionExists.
26126 * expression.cs (As): We were only implementing one of the three
26127 cases for the as operator. We now implement them all.
26128 (Is): Implement the various other cases for Is as well.
26130 * typemanager.cs (CACHE): New define used to control if we want or
26131 not the FindMembers cache. Seems to have a negative impact on
26132 performance currently
26134 (MemberLookup): Nested types have full acess to
26135 enclosing type members
26137 Remove code that coped with instance/static returns for events, we
26138 now catch this in RealFindMembers.
26140 (RealFindMembers): only perform static lookup if the instance
26141 lookup did not return a type or an event.
26143 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26145 * assign.cs (CompoundAssign): We pass more semantic information
26146 now to Compound Assignments than we did before: now we have all
26147 the information at hand, and now we resolve the target *before* we
26148 do the expression expansion, which allows the "CacheValue" method
26149 to have the effect we intended (before, a [x] += 1 would generate
26150 two differen ArrayAccess expressions from the ElementAccess,
26151 during the resolution process).
26153 (CompoundAssign.DoResolve): Resolve target and original_source here.
26155 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26157 * expression.cs (ArrayAccess): dropped debugging information.
26159 * typemanager.cs: Small bug fix: I was always returning i_members,
26160 instead of one of i_members or s_members (depending on which had
26163 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26164 method is invoked before any code generation takes place, and it
26165 is a mechanism to inform that the expression will be invoked more
26166 than once, and that the method should use temporary values to
26167 avoid having side effects
26169 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26171 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26174 * expression.cs (Indirection, ArrayAccess): Add support for
26175 CacheTemporaries in these two bad boys.
26177 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26178 ldobj or ldind_ref.
26179 (StoreFromPtr): Handle stobj as well.
26181 * expression.cs (UnaryMutator): Share more code.
26183 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26184 down: I was not tracking the Filter function as well, which
26185 was affecting the results of the cache.
26187 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26189 * attribute.cs: Remove the hack to handle the CharSet property on
26192 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26194 * attribute.cs (DoResolve): More uglyness, we now only try to
26195 resolve the attribute partially, to extract the CharSet
26196 information (only if we are a StructLayout attribute). Otherwise
26198 (GetExtraTypeInfo): Add some code to conditionally kill in the
26199 future this. I am more and more convinced that the .NET
26200 framework has special code to handle the attribute setting on
26203 * expression.cs (IsParamsMethodApplicable): Revert my previous
26204 foreach change here, it was wrong.
26206 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26208 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26209 (pp_expr): do not abort on unknown input, just return.
26210 (eval): abort if there are pending chars.
26212 * attribute.cs (Attribute.Resolve): Positional parameters are
26213 optional. Deal with that case.
26215 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26216 the Ansi/Unicode/Auto information for the type.
26218 (TypeContainer.DefineType): instantiate the EmitContext here, as
26219 we will be using it during the type definition (to resolve
26220 attributes) and during the emit phase.
26222 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26223 to pull type information out of the attributes
26225 (Attribute.Resolve): track the constructor builder, and allow for
26226 multiple invocations (structs and classes will use this).
26228 * ecore.cs (MemberLookupFinal): new version with all the
26229 parameters customizable.
26231 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26232 constructors. Return if the result value is null (as the error
26233 would have been flagged already by MemberLookupFinal)
26235 Do not allow instances of abstract classes or interfaces to be
26238 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26239 We have to compare the assembly property here when dealing with
26240 FamANDAssem and Assembly access modifiers, because we might be
26241 creating an assembly from *modules* (that means that we are not
26242 getting TypeBuilders for types defined in other modules that are
26243 part of this assembly).
26245 (Method.Emit): If the method is marked abstract and has a body,
26248 (TypeContainer.DefineMembers): If both the defined member and the
26249 parent name match are methods, then do not emit any warnings: let
26250 the Method.Define routine take care of flagging warnings. But if
26251 there is a mismatch (method overrides something else, or method is
26252 overriwritten by something, then emit warning).
26254 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26255 set to null, this means `do not check for the return type on the
26258 (Method.Define): set the return type for the method signature to
26259 null, so that we get methods with the same name and parameters and
26260 different return types. This is used to flag warning 114 (you are
26261 hiding a method, and you probably want to use the new/override
26264 * typemanager.cs (MemberLookup): Implemented proper access
26265 control, closing a long standing set of bug reports. The problem
26266 was that the Framework only has two bits: Public and NonPublic,
26267 and NonPublic includes private and protected methods, but we need
26268 to enforce the FamANDAssem, FamOrAssem and Family.
26270 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26272 * statement.cs (GotoCase): Return true: Ammounts to giving up
26273 knowledge on whether we return or not, and letting the other case
26274 be responsible for it.
26276 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26278 * driver.cs: Do not load directories for each file processed, only
26279 do it if there is a pattern.
26281 * ecore.cs: Report readonly assigns here as well, as we might have
26282 been resolved only by MemberAccess.
26284 (SimpleName.SimpleNameResolve): Also be useful for LValue
26285 resolution. We need this to propagate assign to local readonly variables
26287 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26288 do not want to reuse potential criteria memory.
26290 * class.cs (MyEventBuilder): Set reflected_type;
26292 * ecore.cs (Constantify): Added support for constifying bools.
26294 (RootContext.LookupType): Added a cache for values looked up in
26295 the declaration space.
26297 * typemanager.cs (FindMembers): Now is a front-end to
26298 RealFindMembers, and provides a two-level hashtable-based cache to
26301 15% performance improvement: from 22.5 to 19.2 seconds.
26303 * expression.cs (IsParamsMethodApplicable): use foreach.
26304 (Invocation.DoResolve): ditto.
26305 (New.DoResolve): ditto.
26306 (ArrayCreation.DoResolve): ditto.
26308 * ecore.cs (FindMostEncompassingType): use foreach.
26310 * delegate.cs (NewDelegate.DoResolve): Use foreach
26312 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26313 (RemoveMethods): use foreach.
26315 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26316 nested foreach statements instead of for, and also break out of
26317 the inner loop once a match is found.
26319 (Invocation.OverloadResolve): Use foreach, simplify the code.
26321 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26323 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26324 we actually unwrap the expression to allow for extra information
26327 * expression.cs: Use Shr_Un on unsigned operations.
26329 2002-05-08 Ravi Pratap <ravi@ximian.com>
26331 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26332 applicable operators was not being considered correctly. This closes
26333 the bug Miguel reported.
26335 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26337 * attribute.cs: check that the type derives from System.Attribute
26338 and report the correct error in that case (moved the duplicate code to
26339 its own method, too).
26341 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26343 * attribute.cs: lookup attribute type name as the spec says: first the
26344 bare attribute name and then name + "Attribute" (nant compiles with
26345 mcs after this fix).
26347 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26349 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26350 Because of the way we parse things, we should try to see if a
26351 UIntConstant can fit in an integer.
26353 2002-05-07 Ravi Pratap <ravi@ximian.com>
26355 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26356 when we are in an explicit context.
26358 (ConvertReferenceExplicit): When converting from Iface type S to Class
26359 T make sure the rules are implemented as an OR.
26361 * parameter.cs (ParameterType): Make it a property for now although the
26362 purpose really isn't anything immediate.
26364 * expression.cs (Is*Applicable): Do better checking on the parameter type
26365 of a ref/out parameter. The ones from the system assemblies are already
26366 marked with the correct type so we don't need to do any correction.
26368 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26369 the object type is standard too so include that.
26371 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26373 * ecore.cs (StandardConversionExists): Augment with missing code:
26374 deal with IntConstant, LongConstants and Enumerations.
26376 * assign.cs: Report the error, instead of failing silently
26378 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26379 typecontainer that they are declared, because the
26380 typecontainer/namespace will have the list of using clauses that
26381 need to be applied.
26383 Assembly Attributes were escaping the normal registration
26386 (EmitCode): Apply attributes within an EmitContext that represents
26387 the container they were declared on.
26389 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26391 2002-05-06 Ravi Pratap <ravi@ximian.com>
26393 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26394 Revamp completely - make much cleaner as we now operate only
26397 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26398 to implement the logic detailed in the spec more correctly.
26400 (UserDefinedConversion): Update accordingly.
26402 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26404 * statement.cs: Return flow analysis information up.
26406 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26409 (token): Do not consume an extra character before calling
26412 2002-05-06 Piers Haken <piersh@friskit.com>
26414 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26416 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26418 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26419 EmitContext during the instance constructor initializer
26420 resolution, to stop access to instance variables.
26422 This is mandated by the spec, last paragraph of the `constructor
26423 initializers' section.
26425 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26427 * cs-parser.jay, class.cs (Accessor): new class used to represent
26428 an accessor (get or set). In the past we used `null' to represent
26429 a missing accessor. But this is ambiguous because there was no
26430 way to tell in abstract indexers/properties if one of them was
26433 Now there is a way of addressing that.
26435 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26436 instead of FindMembers.
26438 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26439 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26441 * attribute.cs: Treat indexers and properties as the same in terms
26442 of applying attributes
26444 * ecore.cs (FindMostEncompassedType): Use statically initialized
26445 EmptyExpressions()s like we do elsewhere to avoid creating useless
26446 objects (and we take this out of the tight loop).
26448 (GetConversionOperators): Move the code to extract the actual
26449 operators to a separate routine to clean things up.
26451 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26453 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26454 events are always registered FieldBuilders.
26456 * class.cs (FieldBase): New class shared by Fields
26458 * delegate.cs: If we are a toplevel delegate, use our full name.
26459 If we are a nested delegate, then only use our tail name.
26461 2002-05-02 Ravi Pratap <ravi@ximian.com>
26463 * expression.cs (IsApplicable): Ensure that we add the "&" to
26464 ref/out types before comparing it with the type of the argument.
26466 (IsParamsMethodApplicable): Ditto.
26468 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26471 * delegate.cs : Handle the case when we have more than one applicable
26472 method. Flag an error only when we finish checking all.
26474 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26476 * expression.cs: Add support for boolean static initializers.
26478 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26480 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26482 * parameter.cs (ComputeParameterTypes,
26483 ComputeAndDefineParameterTypes): Better error handling: now we
26484 clear the `types' cache if we fail during any of the type lookups.
26485 We also return the status code correctly to our caller
26487 * delegate.cs: If we fail to define a delegate, abort the extra
26490 * expression.cs (Binary.ResolveOperator): for
26491 operator==(object,object) and operator !=(object, object) we also
26492 have to verify that there is an implicit conversion from one to
26495 (ArrayAccess.DoResolve): Array Access can operate on
26498 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26500 * assign.cs (CompoundAssign): A new class used as a "flag" that
26501 the assignment actually is happening as part of a compound
26502 assignment operator.
26504 During compound assignment, a few new rules exist to enable things
26511 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26512 to the type of x) if y is implicitly convertible to the type of x,
26513 and the operator is a builtin operator and the return type of the
26514 operator is explicitly convertible to the type of x.
26516 * rootcontext.cs: Reset warning level to 2. 4 catches various
26517 "interesting" features in mcs, we must clean this up at some
26518 point, but currently am trying to kill other bugs ;-)
26520 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26521 in container classes as well.
26523 * expression.cs (Binary.ResolveOperator): Handle string case
26524 before anything else (as operator overloading does emit an error
26525 before doing anything else).
26527 This code could go away when we move to a table driven model, but
26528 i could not come up with a good plan last night.
26530 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26532 * typemanager.cs (CSharpName): reimplementation using regex.
26533 * class.cs: added null check for fields in Emit
26534 * rootcontext.cs: set warninglevel to 4
26536 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26538 * typemanager.cs (CSharpName): reimplemented with Lupus
26541 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26543 * statement.cs (If): correclty implement Resolve, because we were
26544 not catching sem errors in there. The same process is needed
26546 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26549 (Statement.Warning_DeadCodeFound): Factorize code.
26550 (While): Report dead code here too.
26552 (Statement): Added Resolve virtual method to allow
26553 for resolution split from the emit code.
26555 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26557 * statement.cs (EmitBoolExpression): No longer try to resolve the
26559 (MakeBoolean): New utility function that resolve, implicitly
26560 converts to boolean and tags the expression.
26563 (If, Do): Implement dead code elimination.
26564 (While): Implement loop inversion
26566 (Do, While, For, If): Resolve the expression prior to calling our
26569 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26572 - added method Report28 (warning: program has more than one entry point)
26573 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26574 - modified method Method.Define, the part at the end of the method
26576 * rootcontext.cs: added static public Location EntryPointLocation;
26578 * ../errors/cs0028.cs : Add test case for the above warning.
26581 - modified method CSharpName to allow arrays of primitive type to
26582 be printed nicely (e.g. instead of System.Int32[][] it now prints
26584 - added method CSharpSignature: returns the signature of a method
26585 in string format to be used in reporting errors, warnings, etc.
26587 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26590 2002-04-26 Ravi Pratap <ravi@ximian.com>
26592 * delegate.cs (Define): Fix extremely silly bug where I was
26593 setting the type of the 'object' parameter of the BeginInvoke
26594 method to System.IAsyncResult instead of System.Object ;-)
26596 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26598 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
26601 (Constructor.Emit): return if we fail to initialize the
26602 constructor. Another door closed!
26604 * expression.cs (New.DoResolve): Improve error message (from -6 to
26605 1501). Use DeclaredOnly lookup to find the exact constructor.
26607 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
26608 loop. This is useful.
26610 * cs-parser.jay: Adjust the default parameters so that destructors
26611 have the proper signature.
26613 2002-04-26 Martin Baulig <martin@gnome.org>
26615 * driver.cs (LoadAssembly): If `assembly' contains any characters
26616 which are only valid in path names and not in assembly names
26617 (currently slash, backslash and point), use Assembly.LoadFrom ()
26618 instead of Assembly.Load () on the `assembly' (before iteration
26619 over the link_paths).
26621 2002-04-26 Martin Baulig <martin@gnome.org>
26623 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
26625 2002-04-25 Miguel de Icaza <miguel@ximian.com>
26627 * class.cs (Property): use the new typemanager.MemberLookup
26629 (TypeContainer.MemberLookup): Implement using the
26630 TypeManager.MemberLookup now.
26632 * typemanager.cs: Make MemberLookup a function of the TypeManager,
26633 and return MemberInfos, so that these can be used without an
26634 EmitContext (what we had before).
26636 2002-04-24 Miguel de Icaza <miguel@ximian.com>
26638 * expression.cs: Fix the case where the argument to params if the
26639 type of the params. I omitted handling this before. Fixed
26641 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26643 * driver.cs: Call BootCorlib_PopulateCoreType
26645 * class.cs (Property.CheckBase): Check for properties only, not
26648 * interface.cs: Temporary hack: try/catch around the
26649 CustomAttributeBuilder, because I am getting an exception that I
26652 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
26653 types whose definitions are required to be there (attributes are
26654 defined before standard types).
26656 Compute definitions as we boot the various types, as they are used
26657 immediately (value_type class will need object_type, but if we do
26658 not initialize object_type, we will pass a null, which will let
26659 the runtime pick the System.Object from the existing corlib, which
26660 is not what we want).
26662 2002-04-22 Patrik Torstensson <totte@labs2.com>
26664 * cs-tokenizer.cs: fixed a number of trim() issues.
26666 2002-04-22 Ravi Pratap <ravi@ximian.com>
26668 * expression.cs (Argument.Type): Ensure that we return the correct
26669 type when we have out or ref parameters [in which case we
26672 2002-04-22 Miguel de Icaza <miguel@ximian.com>
26674 * class.cs (Property, Indexer): Allow extern modifier in there.
26676 * typemanager.cs (InitBaseTypes): Initializes object_type and
26677 value_type, since those will be used early on during the bootstrap
26678 process to compile corlib.
26680 (InitCoreTypes): Move code from here to InitBaseTypes.
26682 2002-04-21 Miguel de Icaza <miguel@ximian.com>
26684 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
26685 single-dimension arrays as using the ldlen opcode.
26687 Daniel Lewis discovered this optimization.
26689 * typemanager.cs: Add signature for System.Array::get_Length
26691 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26693 * statement.cs: report the error when the foreach does not apply to an
26694 array nor a collection.
26696 2002-04-19 Miguel de Icaza <miguel@ximian.com>
26698 * expression.cs: Add implicit conversions to the operator ~.
26700 * constant.cs (DecimalConstant.Emit): Emit decimal value.
26702 * typemanager.cs: Locate the decimal constructor.
26704 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26706 * attribute.cs: use the new property of TypeOf.
26707 * expression.cs: added 'get' property around typearg.
26709 These changes fix a build breaker reported by NickD. Is this the
26710 correct way to fix? If not, please, revert my changes and make it
26713 2002-04-17 Miguel de Icaza <miguel@ximian.com>
26715 * attribute.cs: Add support for typeof in attribute invocations.
26716 I am not sure that this is right though.
26718 2002-04-14 Duncan Mak <duncan@ximian.com>
26720 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
26721 Binary.Operator.Division case.
26723 2002-04-13 Ravi Pratap <ravi@ximian.com>
26725 * class.cs (DefineType): Ensure that we do a proper check on
26726 attribute types and also register it with the TypeManager.
26728 (TypeContainer.Targets): The default for attribute types is
26729 AttributeTargets.All.
26731 * attribute.cs (ApplyAttributes): Registering the attribute type
26732 is done elsewhere, not when we discover we have a Usage attribute.
26734 2002-04-12 Ravi Pratap <ravi@ximian.com>
26736 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
26737 and get rid of is_delegate parameter.
26739 * everywhere : update.
26741 2002-04-12 Ravi Pratap <ravi@ximian.com>
26743 * cs-parser.jay (compilation_unit): Revamp completely to use
26744 some new ideas that I got from Rhys' grammar to solve the problems
26745 with assembly level attributes.
26747 (outer_declaration): New grammar production.
26749 (attribute_sections): Add.
26751 (opt_attributes): Base on attribute_sections
26753 (namespace_declaration): Allow opt_attributes to tackle the case
26754 when we have assembly level attributes - we are clever in this
26757 * attribute.cs (ApplyAttributes): Do not worry about assembly
26758 attributes in the non-global context.
26760 * rootcontext.cs (AddGlobalAttributes): Go back to using this
26761 instead of SetGlobalAttributes.
26763 * class.cs, rootcontext.cs : Ensure we define and generate
26764 attribute types before anything else.
26766 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
26767 and flag the new error -20 for the case when the attribute type
26768 does not have valid targets specified. csc does not catch this.
26770 * ../errors/errors.txt : update for error # -20
26772 2002-04-11 Ravi Pratap <ravi@ximian.com>
26774 * support.cs (InternalParameters.ParameterModifier): Do some null
26775 checking and return sane values.
26777 * class.cs (Method.Define): If we are a PInvoke method, ensure
26778 that we are static and extern. Report error # 601
26780 * ../errors/cs0601.cs : Add test case for the above error.
26782 2002-04-07 Ravi Pratap <ravi@ximian.com>
26784 * rootcontext.cs (attribute_types): We need to keep type of
26785 all attribute types separately and emit code for them first.
26787 (RegisterAttribute) : Implement.
26789 * class.cs (DefineType): Check if the current Type is a custom
26790 attribute type and register it accordingly.
26792 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
26793 adding the first attribute twice and rename to
26795 (SetGlobalAttributes): this.
26797 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
26800 * attribute.cs (ApplyAttributes): Take an additional argument telling us
26801 if we are processing global arguments. Hmm, I am unsure of this.
26803 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26805 * expression.cs: added static array of strings to avoid calling
26806 Enum.ToString () for Operator in Binary. Significant recover of
26809 2002-04-10 Miguel de Icaza <miguel@ximian.com>
26811 * class.cs (FindMembers): Allow the Builders of the various
26812 members to be null. If they are skip them. This only happens
26813 during the PInvoke declaration.
26815 2002-04-09 Miguel de Icaza <miguel@ximian.com>
26817 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
26818 failure, so we do not keep going afterwards.
26820 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
26821 wanted to pass `false' as the `is_delegate' argument. If this is
26822 the case, why not use delegate_type == null to mean `is_delegate =
26823 false' and anything else as is_delegate = true.
26825 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
26827 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
26828 code for the section, not the beginning of the tests.
26830 2002-04-08 Miguel de Icaza <miguel@ximian.com>
26832 * cfold.cs: Handle operator + (Enum x, Underlying x)
26834 * expression.cs (Binary): same. Warn about errors where we have
26835 Enum/Enum in operator + as well.
26837 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
26840 - added support for switch(bool)
26841 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
26842 - add TableSwitchEmit() to handle table-based switch statements
26844 2002-04-05 Ravi Pratap <ravi@ximian.com>
26846 * expression.cs (Invocation.OverloadResolve): Factor out code which
26847 does parameter compatibility checking with arguments so that we can
26848 re-use the code even from Delegate.VerifyApplicability
26850 (VerifyArgumentsCompat): Move above code here.
26852 * delegate.cs (VerifyApplicability): Get rid of duplicate code
26853 and instead make a call to the above method.
26855 2002-03-31 Ravi Pratap <ravi@ximian.com>
26857 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
26858 We use it to keep track of classes which are attribute types.
26860 2002-04-02 Miguel de Icaza <miguel@ximian.com>
26862 * delegate.cs (Delegate.Define): Correctly define the types in the
26863 presence of fixed and array parameters.
26865 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
26868 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
26869 include NonPublic after the first iteration.
26871 * class.cs (Indexer.CheckBase): Only check if both parents are
26874 * cs-parser.jay (accessor_body): If empty, set to null.
26876 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
26877 same code path here to resolve constants names that we did have in
26878 MemberAccess.DoResolve. There is too much code duplicated here.
26880 2002-04-01 Miguel de Icaza <miguel@ximian.com>
26882 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
26884 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
26887 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
26888 tokens, numbers and strings.
26890 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
26893 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
26894 asyncronous parameters and the regular parameters.
26896 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
26897 specify the target directory.
26899 * expression.cs: (This.DoResolve): Simplify
26900 (As.Emit): Optimize, do not generate IsInst if the expression is
26901 always of the given type.
26903 (Is.DoResolve): Bug fix, we were reporting both always/never for
26906 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
26907 creating too many unnecessary arrays.
26909 2002-03-31 Miguel de Icaza <miguel@ximian.com>
26911 * class.cs (EmitFieldInitializer): Use Assign expression to assign
26912 fields instead of rolling our own initializer. Takes care of all
26913 implicit conversions, and drops unnecessary static checks/argument.
26915 2002-03-31 Dick Porter <dick@ximian.com>
26917 * driver.cs: use the GetDirectories() return values properly, and
26918 use "/" as path separator.
26920 2002-03-30 Miguel de Icaza <miguel@ximian.com>
26922 * expression.cs (Unary): Optimize - - expr into expr.
26923 (Binary): Optimize a + (-b) into a -b.
26925 * codegen.cs (CodeGen): Made all methods static.
26927 2002-03-29 Miguel de Icaza <miguel@ximian.com>
26931 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
26932 TypeBuilder property.
26934 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
26937 * tree.cs: Removed the various RecordXXXX, and replaced with a
26938 single RecordDecl. Removed all the accessor methods, and just
26939 left a single access point Type
26941 * enum.cs: Rename DefineEnum to DefineType.
26943 * decl.cs: New abstract method `DefineType' used to unify the
26944 Defines for Enumerations, Interfaces, TypeContainers and
26947 (FindType): Moved LookupInterfaceOrClass here. Moved the
26948 LookupBaseClasses method that used to live in class.cs and
26949 interface.cs here, and renamed to FindType.
26951 * delegate.cs: Implement DefineType. Take advantage of the
26952 refactored pattern for locating the parent builder without taking
26953 the parent_builder argument (which we know does not work if we are
26954 nested, and triggering a toplevel definition).
26956 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26958 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
26959 accessibility of a member has changed during override and report
26962 * class.cs (Method.Define, Property.Define): Only complain on
26963 overrides if the method is private, any other accessibility is
26964 fine (and since we just checked the permission is the same, we are
26967 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
26968 and elif are processed always. The other pre-processing
26969 directives are only processed if we are "taking" the path
26971 2002-03-29 Martin Baulig <martin@gnome.org>
26973 * class.cs (Method.Emit): Only emit symbolic debugging info if the
26974 current location is not Null.
26976 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
26977 a separate method so we can profile it.
26979 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
26980 `span.Seconds' are just seconds, but no minutes or hours.
26981 (MainDriver): Profile the CodeGen.SaveSymbols calls.
26983 2002-03-28 Miguel de Icaza <miguel@ximian.com>
26985 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
26986 Remove the gratuitous set of Final:
26988 // If an interface implementation, then we can set Final.
26989 if (((flags & MethodAttributes.Abstract) == 0) &&
26990 implementing.DeclaringType.IsInterface)
26991 flags |= MethodAttributes.Final;
26993 I do not know what I was smoking when I used that.
26996 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
26997 step into fixing the name resolution issues for delegates and
26998 unifying the toplevel name resolution.
27000 2002-03-28 Martin Baulig <martin@gnome.org>
27002 * class.cs (Method.Emit): If we have a symbol writer, call its
27003 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27004 tell it about the current method.
27006 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27007 writer that we're going to emit the first byte of IL code for a new
27008 statement (a new source line).
27009 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27010 EmitContext.Mark() before emitting any code.
27012 * location.cs (SymbolDocument): Return null when we're Null.
27014 * statement.cs (Statement): Moved the `Location loc' variable here.
27015 (Statement.EmitBoolExpression): If we have a symbol writer, call
27016 ec.Mark() before emitting any code to tell it that we're at the
27017 beginning of a new statement.
27018 (StatementExpression): Added `Location' argument to the constructor.
27019 (Block): Added public readonly variable `StartLocation' and public
27020 variable `EndLocation'. The latter is to be set using SetEndLocation().
27021 (Block): Added constructor which takes a start and end location.
27022 (Block.SetEndLocation): New method. This sets the end location.
27023 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27024 local variables we create.
27025 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27026 each statement and do also mark the begin and end of the block.
27028 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27029 tell it the current lexer.Location, use Location.Null for the end of the
27031 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27032 current block, set its end location using SetEndLocation().
27033 (statement_expression): StatementExpression constructor now takes the
27034 lexer.Location as additional argument.
27035 (for_statement, declare_local_variables): Likewise.
27036 (declare_local_variables): When creating a new implicit block, use the
27037 new Block constructor and pass it the lexer.Location.
27039 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27041 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27042 members also on the parent interfaces recursively.
27044 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27046 * report.cs: Use new formats, since Gonzalo finished the missing
27049 * expression.cs (Binary.ResolveOperator): added missing operator|
27050 operator& and operator^ for bool/bool.
27052 * cs-parser.jay: CheckDef now takes a Location argument that is
27053 used to report errors more precisly (instead of reporting the end
27054 of a definition, we try to track something which is a lot closer
27055 to the source of the problem).
27057 * cs-tokenizer.cs: Track global token use, so we can properly flag
27058 the use of #define/#undef after the first token has been seen.
27060 Also, rename the reportXXXX to Error_DescriptiveName
27062 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27063 TypeContainer, so that Enum and Interface can use this too.
27065 * class.cs (TypeContainer.LookupInterfaceOrClass,
27066 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27067 `builder' argument. Typically this was used to pass the parent
27068 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27071 The problem is that a nested class could trigger the definition of
27072 a toplevel class, and the builder would be obviously wrong in that
27075 So we drop this argument, and we compute dynamically the
27076 TypeBuilder/ModuleBuilder (the correct information was available
27077 to us anyways from DeclSpace.Parent)
27079 * interface.cs (Interface.DefineInterface): Drop builder
27080 parameter cleanup like class.cs
27082 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27085 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27088 (Try.Emit): Propagate the returns value from the statement.
27090 (Return.Emit): Even if we are leavning
27092 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27094 * modifiers.cs: Fix the computation of MethodAttributes flags.
27096 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27098 * driver.cs: allow compilation of files that start with '/'.
27099 Add a default case when checking the argument of --target.
27101 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27103 * interface.cs: Implement the same search algorithm for types in
27104 the interface code.
27106 * delegate.cs: Do not allow multiple definition.
27108 * Recovered ChangeLog that got accidentally amputated
27110 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27112 * rootcontext.cs: Load manually enum to allow core classes to
27113 contain enumerations.
27115 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27116 Update to new static methods in TypeManager.
27118 * typemanager.cs (GetMethod, GetConstructor): Use our
27119 implementation of FindMembers to find the members, since during
27120 corlib compilation, the types are TypeBuilders and GetMethod and
27121 GetConstructor do not work.
27123 Make all methods in TypeManager static.
27125 (InitCodeHelpers): Split the functionality from
27126 the InitCodeTypes function.
27128 * driver.cs: Call InitCodeHelpers after we have populated the
27131 * cs-parser.jay (delegate_declaration): we did not used to compute
27132 the delegate name correctly for void delegates.
27134 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27136 * rootcontext.cs (RootContext): Init the interface_resolve_order
27137 and type_container_resolve_order always.
27139 (ResolveCore, BootstrapCorlib_ResolveClass,
27140 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27141 compiler when compiling with --nostdlib
27143 * class.cs (TypeContainer.DefineType): Check that our parent is
27144 not null. This test is most important when we are bootstraping
27147 * codegen.cs: Split out the symbol writing code.
27149 2002-03-25 Martin Baulig <martin@gnome.org>
27151 * driver.cs (-g): Made -g an alias for --debug.
27153 2002-03-24 Martin Baulig <martin@gnome.org>
27155 * codegen.cs (SymbolWriter): New public variable. Returns the
27156 current symbol writer.
27157 (CodeGen): Added `bool want_debugging_support' argument to the
27158 constructor. If true, tell the ModuleBuild that we want debugging
27159 support and ask it for the ISymbolWriter.
27160 (Save): If we have a symbol writer, call it's Close() method after
27161 saving the assembly.
27163 * driver.c (--debug): New command line argument to create a
27164 debugger information file.
27166 * location.cs (SymbolDocument): New public property. Returns an
27167 ISymbolDocumentWriter object for the current source file or null
27168 if we don't have a symbol writer.
27170 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27172 * driver.cs (LoadAssembly): Correctly return when all the paths
27173 have been tried and not before.
27175 * statement.cs (Switch.Emit): return the actual coverage for this
27176 statement (returns/not-returns)
27178 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27179 switch of the statement if we are the last switch section. That
27180 kills two problems: try/catch problems (we used to emit an empty
27181 nop at the end) and switch statements where all branches would
27184 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27186 * driver.cs: Add default assemblies (the equivalent to the
27187 Microsoft CSC.RSP file)
27189 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27190 also update tokens_seen and set it to false.
27192 * driver.cs: Implement --recurse for Mike.
27194 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27195 correctly splitting out the paths.
27197 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27199 * interface.cs (Interface.PopulateProperty): Instead of using
27200 `parent' as the declaration space for the set parameters, use
27203 * support.cs (InternalParameters): InternalParameters constructor
27204 takes a DeclSpace instead of a TypeContainer.
27206 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27207 types are being initialized, load the address of it before calling
27210 (New): Provide a mechanism to disable the generation of local
27211 value type temporaries when the caller will be providing us with
27212 an address to store it.
27214 (ArrayCreation.EmitDynamicInitializers): Use it.
27216 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27218 * expression.cs (Invocation.EmitArguments): Only probe for array
27219 property if there is more than one argument. Sorry about that.
27221 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27222 empty param arrays.
27224 * class.cs (Method.LabelParameters): Fix incorrect code path that
27225 prevented the `ParamArrayAttribute' from being applied to the
27228 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27230 * support.cs (ReflectionParameters): Correctly compute whether the
27231 last argument is a params array. Fixes the problem with
27234 * typemanager.cs: Make the assemblies array always be non-null
27235 (empty, but non-null)
27237 * tree.cs (RecordDecl): New function that abstracts the recording
27238 of names. This reports error 101, and provides a pointer to the
27239 previous declaration. Fixes a crash in the compiler.
27241 * cs-parser.jay (constructor_declaration): Update to new grammar,
27242 and provide a constructor_body that can be empty.
27244 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27246 * driver.cs: Add support for --resources.
27248 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27249 Make all types for the various array helper methods be integer.
27251 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27252 CheckState to ConvCast.
27254 (ConvCast): Now it takes a `checked' state argument, to avoid
27255 depending on the emit context for the conversion, and just using
27256 the resolve time setting.
27258 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27259 instead of Invocation.EmitArguments. We do not emit the original
27260 arguments, instead we emit those which have been converted to
27261 unsigned int expressions.
27263 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27265 * codegen.cs: ditto.
27267 * expression.cs (LocalVariableReference): Drop the use of the
27268 Store function that depended on the variable index.
27270 * statement.cs (VariableInfo): Drop the `Idx' property from this
27271 class, as this is not taking into account the indexes for
27272 temporaries tat we generate during the execution, getting the
27275 * class.cs: First emit class initializers, then call the parent
27278 * expression.cs (Binary): Fix opcode emision.
27279 (UnaryMutator.EmitCode): Support checked code generation
27281 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27282 matches for events for both the Static and Instance scans,
27283 pointing to the same element. Fix that.
27285 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27287 * rootcontext.cs (ResolveTree): Always set the
27288 interface_resolve_order, because nested interfaces will be calling
27291 * class.cs (GetInterfaceOrClass): Track the same resolution
27292 process used by TypeManager.LookupType. This fixes the nested
27293 type lookups in class declarations (separate path from
27296 (TypeContainer.DefineType): Also define nested interfaces.
27297 (TypeContainer.RegisterOrder): New public function used to
27298 register the order in which child interfaces need to be closed.
27300 Nested interfaces need to be closed after their parents have been
27303 * interface.cs (InterfaceAttr): Put all the logic for computing
27304 the interface attribute here.
27306 (DefineInterface): Register our interface order with the
27307 RootContext or with the TypeContainer depending on the case.
27309 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27311 * cs-parser.jay: rework foreach statement to work with the new
27312 changes to the policy on SimpleNames.
27314 * report.cs: support Stacktrace on warnings as well.
27316 * makefile: drop --unsafe and /unsafe from the compile.
27318 2002-03-13 Ravi Pratap <ravi@ximian.com>
27320 * ecore.cs (StandardConversionExists): Modify to take an Expression
27321 as the first parameter. Ensure we do null -> reference type conversion
27324 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27325 temporary Expression objects.
27327 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27329 * interface.cs: workaround bug in method overloading resolution
27330 (there is already a bugzilla bug for it).
27332 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27334 We could also solve this problem by having a separate path for
27335 performing type lookups, instead of DoResolve, we could have a
27336 ResolveType entry point, and only participating pieces of the
27337 production (simplename, deref, array) would implement this.
27339 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27340 signal SimpleName to only resolve type names and not attempt to
27341 resolve anything else.
27343 * expression.cs (Cast): Set the flag.
27345 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27347 * class.cs: Only report 108 if there is no `new' modifier.
27349 * cs-parser.jay: rework foreach statement to work with the new
27350 changes to the policy on SimpleNames.
27352 * report.cs: support Stacktrace on warnings as well.
27354 * makefile: drop --unsafe and /unsafe from the compile.
27356 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27358 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27359 lookups here, instead of doing that at parse time. This means
27360 that our grammar will not introduce `LocalVariableReferences' as
27361 expressions at this point. That solves the problem of code like
27365 static void Main ()
27369 This is only half the fix. The full fix requires parameters to
27370 also be handled in this way.
27372 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27373 makes the use more obvious of the DeclSpace. The
27374 ec.TypeContainer.TypeBuilder is now only used to pull the
27375 TypeBuilder for it.
27377 My theory is that I can get rid of the TypeBuilder completely from
27378 the EmitContext, and have typecasts where it is used (from
27379 DeclSpace to where it matters).
27381 The only pending problem is that the code that implements Aliases
27382 is on TypeContainer, and probably should go in DeclSpace.
27384 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27385 lookups here, instead of doing that at parse time. This means
27386 that our grammar will not introduce `LocalVariableReferences' as
27387 expressions at this point. That solves the problem of code like
27391 static void Main ()
27395 This is only half the fix. The full fix requires parameters to
27396 also be handled in this way.
27398 * class.cs (Property.DefineMethod): When implementing an interface
27399 method, set newslot, when implementing an abstract method, do not
27400 set the flag (before we tried never setting it, or always setting
27401 it, which is the difference).
27402 (Indexer.DefineMethod): same.
27403 (Method.DefineMethod): same.
27405 * ecore.cs: Only set the status used flag if we get back a Field.
27407 * attribute.cs: Temporary hack, so Paolo can keep working.
27409 2002-03-08 Ravi Pratap <ravi@ximian.com>
27411 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27412 the unmanaged type in the case we have a MarshalAs attribute.
27414 (Resolve): Handle the case when we are parsing the special MarshalAs
27415 attribute [we need to store the unmanaged type to use later]
27417 * typemanager.cs (marshal_as_attr_type): Built in type for the
27418 MarshalAs Attribute.
27420 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27421 on parameters and accordingly set the marshalling info.
27423 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27425 * class.cs: Optimizing slightly by removing redundant code after
27426 we switched to the `NoTypes' return value.
27427 (Property.DefineMethod): use NoTypes here too.
27429 This fixes the bug I introduced in my last batch of changes.
27431 2002-03-05 Ravi Pratap <ravi@ximian.com>
27433 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27435 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27436 Enums since those are types too.
27438 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27440 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27441 thanks to a call during the lookup process.
27443 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27445 * statement.cs (Foreach): Lots of work to accomodate a particular
27446 kind of foreach statement that I had not kept in mind. It is
27447 possible to have foreachs on classes that provide a GetEnumerator
27448 method that return objects that implement the "pattern" for using
27449 a foreach, there is no need to support GetEnumerator
27452 This is needed to compile nant.
27454 * decl.cs: Only report 114 if the member is not `Finalize' and if
27455 the warning level is at least 2.
27457 * class.cs: Moved the compare function from Method to
27460 (MethodSignature.InheritableMemberSignatureCompare): Add new
27461 filter function that is used to extract inheritable methods from a
27464 (Method.Define): Use the new `inheritable_method_signature_filter'
27467 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27470 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27472 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27474 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27476 * expression.cs: Pass location information to
27477 ConvertImplicitStandard.
27479 * class.cs: Added debugging code to track return values from
27482 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27484 * expression.cs (Is.DoResolve): If either side of the `is' is an
27485 interface, do not flag the warning.
27487 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27490 * report.cs: Allow for --fatal to be used with --probe.
27492 * typemanager.cs (NoTypes): Move the definition for the empty Type
27495 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27497 (TypeContainer.DefineProxy): New function used to proxy to parent
27498 implementations when implementing interfaces.
27499 (TypeContainer.ParentImplements): used to lookup if our parent
27500 implements a public function that is required by an interface.
27501 (TypeContainer.VerifyPendingMethods): Hook this up.
27503 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27504 `modules' and `assemblies' arraylists into arrays. We only grow
27505 these are the very early start up of the program, so this improves
27506 the speedof LookupType (nicely measured).
27508 * expression.cs (MakeByteBlob): Replaced unsafe code with
27509 BitConverter, as suggested by Paolo.
27511 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27512 folding of string concatenation, but if either side is a string,
27513 and the other is not, then return null, and let the runtime use
27514 the concatenation on the string plus the object (using
27515 `Object.ToString').
27517 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27519 Constant Folding has been implemented now.
27521 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27522 the error instead on types that are not supported in one's
27525 * constant.cs (Constant and all children): New set of functions to
27526 perform implict and explicit conversions.
27528 * ecore.cs (EnumConstant): Implement the new functions to perform
27529 conversion by proxying to the child expression.
27531 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27532 own separate setting that can not be turned off from the command
27533 line using --unchecked or --checked and is only controlled using
27534 the checked/unchecked statements and expressions. This setting is
27535 used by the constant folder to flag errors.
27537 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27538 ConstantCheckState as well.
27540 During Resolve, they also have to flag the state, because the
27541 constant folder runs completely in the Resolve phase.
27543 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27546 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27548 * cfold.cs: New file, this file contains the constant folder.
27550 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27551 argument to track whether we are using the resulting address to
27552 load or store a value and provide better error messages.
27554 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27555 new AddressOf arguments.
27557 * statement.cs (Foreach.EmitCollectionForeach): Update
27559 * expression.cs (Argument.Emit): Call AddressOf with proper
27560 arguments to track usage.
27562 (New.DoEmit): Call AddressOf with new arguments.
27564 (Unary.Emit): Adjust AddressOf call.
27566 2002-03-01 Ravi Pratap <ravi@ximian.com>
27568 * cs-parser.jay (member_access): Change the case for pre-defined types
27569 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27572 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27575 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27576 essentially like methods and apply attributes like MethodImplOptions to them too.
27578 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27581 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27582 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27585 * Update code everywhere accordingly.
27587 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27589 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27591 2002-02-28 Ravi Pratap <ravi@ximian.com>
27593 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27594 try performing lookups against those instead of jumping straight into using
27595 the 'using' clauses.
27597 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
27599 (LookupType): Perform lookups in implicit parents too.
27601 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
27602 sequence as RootContext.LookupType.
27604 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
27605 the various cases of namespace lookups into this method.
27607 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27609 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
27610 in positional arguments)
27612 * class.cs (Operator): Update the AllowedModifiers to contain
27615 * cs-parser.jay: Update operator declaration to allow for the
27616 operator body to be empty.
27618 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
27621 2002-02-27 Miguel de Icaza <miguel@ximian.com>
27623 * class.cs (Method.Emit): Label parameters.
27625 * driver.cs: Return 1 or 0 as the program exit code.
27627 2002-02-26 Miguel de Icaza <miguel@ximian.com>
27629 * expression.cs: Special case the `null' object when trying to
27630 auto-compute the type, as anything can be explicitly converted to
27633 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
27634 spotting this Paolo.
27636 (Expression.ImplicitNumericConversion): Perform comparissions of
27637 the type using the underlying type in the case of an enumeration
27638 rather than using the enumeration type for the compare.
27640 Cope with the underlying == type case, which is not possible to
27643 (Expression.ConvertNumericExplicit): Perform comparissions of
27644 the type using the underlying type in the case of an enumeration
27645 rather than using the enumeration type for the compare.
27647 * driver.cs: If the user does not supply an extension, assume .exe
27649 * cs-parser.jay (if_statement): Rewrote so that we can track the
27650 location for the if statement.
27652 * expression.cs (Binary.ConstantFold): Only concat strings when
27653 the operation is "+", not everything ;-)
27655 * statement.cs (Statement.EmitBoolExpression): Take a location
27657 (If, While, Do): Track location.
27659 * expression.cs (Binary.ResolveOperator): In the object + string
27660 case, I was missing a call to ConvertImplicit
27662 2002-02-25 Ravi Pratap <ravi@ximian.com>
27664 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
27665 Location arguments. Ensure we use RootContext.LookupType to do our work
27666 and not try to do a direct Type.GetType and ModuleBuilder.GetType
27668 * interface.cs (PopulateMethod): Handle the type of the parameter being
27671 * expression.cs (Invocation.BetterFunction): Handle the case when we
27672 have a params method with no fixed arguments and a call is made with no
27675 2002-02-25 Miguel de Icaza <miguel@ximian.com>
27677 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
27678 the verbatim-string-literal
27680 * support.cs (InternalParameters.ParameterModifier): handle null
27682 (InternalParameters.ParameterType): ditto.
27684 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
27685 duplicating the name of the variable parameter.
27686 (GetParameterByName): Fix bug where we were not looking up array
27687 paramters if they were the only present (thanks Paolo!).
27688 (GetParameterInfo): We only have an empty set of types if both
27689 fixed and array are set to null.
27690 (GetParameterInfo-idx): Handle FixedParameter == null
27692 * cs-parser.jay: Handle the case where there is no catch
27693 statements (missing null test).
27695 2002-02-22 Miguel de Icaza <miguel@ximian.com>
27697 * driver.cs (MainDriver): Be conservative on our command line
27700 Catch DirectoryNotFoundException when calling GetFiles.
27702 (SplitPathAndPattern): Used to split the input specification into
27703 a path and a pattern that we can feed to Directory.GetFiles.
27705 2002-02-21 Miguel de Icaza <miguel@ximian.com>
27707 * statement.cs (Fixed): Implement the last case of the Fixed
27708 statement (string handling).
27710 * expression.cs (StringPtr): New class used to return a char * to
27711 a string; Used by the Fixed statement.
27713 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
27715 * expression.cs (Binary.ResolveOperator): Remove redundant
27716 MemberLookup pn parent type.
27717 Optimize union call, we do not need a union if the types are the same.
27718 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
27721 Specialize the use of MemberLookup everywhere, instead of using
27722 the default settings.
27724 (StackAlloc): Implement stackalloc keyword.
27726 * cs-parser.jay: Add rule to parse stackalloc.
27728 * driver.cs: Handle /h, /help, /?
27730 * expression.cs (MakeByteBlob): Removed the hacks we had in place
27731 before we supported unsafe code.
27733 * makefile: add --unsafe to the self compilation of mcs.
27735 2002-02-20 Miguel de Icaza <miguel@ximian.com>
27737 * expression.cs (PointerArithmetic): New class that is used to
27738 perform pointer arithmetic.
27739 (Binary.Resolve): Handle pointer arithmetic
27740 Handle pointer comparission.
27741 (ArrayPtr): Utility expression class that is used to take the
27742 address of an array.
27744 (ElementAccess): Implement array access for pointers
27746 * statement.cs (Fixed): Implement fixed statement for arrays, we
27747 are missing one more case before we are done.
27749 * expression.cs (Indirection): Implement EmitAssign and set the
27750 ExprClass to Variable. This allows pointer dereferences to be
27751 treated as variables, and to have values assigned to them.
27753 * ecore.cs (Expression.StoreFromPtr): New utility function to
27754 store values dereferencing.
27756 2002-02-20 Ravi Pratap <ravi@ximian.com>
27758 * expression.cs (Binary.ResolveOperator): Ensure that we are
27759 not trying to operate on a void type - this fixes the reported
27762 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
27763 the parent implementation is sealed.
27765 * ../errors/cs0239.cs : Add.
27767 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
27769 * typemanager.cs (unverifiable_code_type): Corresponds to
27770 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
27771 which have unsafe code in them.
27773 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
27776 2002-02-19 Miguel de Icaza <miguel@ximian.com>
27778 * cs-tokenizer.cs: Add support for @"litreal strings"
27780 Make tokenizer accept pre-processor directives
27781 on any column (remove the old C-like limitation).
27783 * rootcontext.cs (EmitCode): Emit any global attributes.
27784 (AddGlobalAttributes): Used to keep track of assembly attributes.
27786 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
27788 * cs-parser.jay: Add support for global attributes.
27790 2002-02-17 Miguel de Icaza <miguel@ximian.com>
27792 * expression.cs (Indirection): New helper class. Unary will
27793 create Indirection classes to be able to implement the
27794 IMemoryLocation interface on it.
27796 2002-02-16 Miguel de Icaza <miguel@ximian.com>
27798 * cs-parser.jay (fixed_statement): reference the right statement.
27800 * statement.cs (Fixed.Emit): Finish implementing the fixed
27801 statement for the &x case.
27803 2002-02-14 Miguel de Icaza <miguel@ximian.com>
27805 * class.cs (Property.Define, Method.Define): Remove newslot when
27808 * modifiers.cs: My use of NewSlot when `Abstract' was set was
27809 wrong. NewSlot should only be used if the `new' keyword is present.
27811 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
27812 locating our system dir. Sorry about this.
27814 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27816 * driver.cs (GetSystemDir): Compute correctly the location of our
27817 system assemblies. I was using the compiler directory instead of
27818 the library directory.
27820 2002-02-13 Ravi Pratap <ravi@ximian.com>
27822 * expression.cs (BetterFunction): Put back in what Miguel commented out
27823 since it is the correct fix. The problem is elsewhere ;-)
27825 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
27826 parameters of the parms method are themselves compatible or not !
27828 (StandardConversionExists): Fix very dangerous bug where we were forgetting
27829 to check that a class implements an interface before saying that an implicit
27830 conversion was allowed. Use ImplementsInterface to do the checking.
27832 2002-02-13 Miguel de Icaza <miguel@ximian.com>
27834 * class.cs (Method.Define): Track whether we are an explicit
27835 implementation or not. And only call DefineMethodOverride if we
27836 are an explicit implementation.
27838 (Property.DefineMethod): Ditto.
27840 2002-02-11 Ravi Pratap <ravi@ximian.com>
27842 * expression.cs (BetterFunction): Catch hideous bug which was
27843 preventing us from detecting ambiguous calls due to implicit casts i.e
27846 2002-01-29 Miguel de Icaza <miguel@ximian.com>
27848 * support.cs (Pair): Remove un-needed method. I figured why I was
27849 getting the error in cs-parser.jay, the variable in a foreach loop
27850 is readonly, and the compiler does not really treat this as a variable.
27852 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
27853 instead of EQUALS in grammar.
27855 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
27857 * expression.cs (Unary.DoResolve): Check whether the argument is
27860 2002-01-28 Miguel de Icaza <miguel@ximian.com>
27862 * support.cs: Api for Pair to set a value. Despite the fact that
27863 the variables are public the MS C# compiler refuses to compile
27864 code that accesses the field if the variable is part of a foreach
27867 * statement.cs (Fixed): Begin implementation of the fixed
27870 (Block.AddVariable): Return the VariableInfo on success and null
27871 on failure instead of true/false.
27873 * cs-parser.jay (foreach): Catch errors on variables already
27874 defined (we were ignoring this value before) and properly unwind
27875 the block hierarchy
27877 (fixed_statement): grammar for the fixed statement.
27879 2002-01-25 Miguel de Icaza <miguel@ximian.com>
27881 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
27882 pointer types to be incretemented.
27884 (SizeOf): Implement.
27886 * cs-parser.jay (pointer_member_access): Implement
27887 expr->IDENTIFIER production.
27889 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
27890 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
27893 (Unary): Implement indirection.
27895 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
27896 use in non-unsafe context).
27898 (SimpleName.DoResolve): Check for pointers in field access on safe
27901 (Expression.LoadFromPtr): Factor the load-indirect code in this
27902 function. This was duplicated in UnboxCast and ParameterReference
27904 2002-01-24 Miguel de Icaza <miguel@ximian.com>
27906 * expression.cs (ComposedCast): report an error if a pointer cast
27907 is used in a safe region.
27909 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
27910 pointer type casts in unsafe context.
27912 * codegen.cs (EmitContext): Set up IsUnsafe.
27914 * cs-parser.jay (non_expression_type): Add productions for pointer
27917 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
27918 code. We should not use force into static mode if the method is
27919 not virtual. Fixes bug in MIS
27921 * statement.cs (Do.Emit, While.Emit, For.Emit,
27922 Statement.EmitBoolExpression): Add support to Do and While to
27923 propagate infinite loop as `I do return' semantics.
27925 Improve the For case to also test for boolean constants.
27927 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
27928 to the list of attributes we can add.
27930 Remove `EmitContext' argument.
27932 * class.cs (Method.Define): Apply parameter attributes.
27933 (Constructor.Define): Apply parameter attributes.
27934 (MethodCore.LabelParameters): Move here the core of labeling
27937 * support.cs (ReflectionParameters.ParameterModifier,
27938 InternalParameters.ParameterModifier): Use IsByRef on the type and
27939 only return the OUT bit for these parameters instead of in/out/ref
27942 This is because I miss-understood things. The ParameterInfo.IsIn
27943 and IsOut represent whether the parameter has the [In] and [Out]
27946 2002-01-22 Miguel de Icaza <miguel@ximian.com>
27948 * ecore.cs (FieldExpr.Emit): Release temporaries.
27950 * assign.cs (LocalTemporary.Release): new function.
27952 * codegen.cs (EmitContext.GetTemporaryStorage,
27953 EmitContext.FreeTemporaryStorage): Rework the way we deal with
27954 temporary storage. Now we can "put back" localbuilders when we
27957 2002-01-21 Miguel de Icaza <miguel@ximian.com>
27959 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
27960 need to make a copy of the variable to generate verifiable code.
27962 2002-01-19 Miguel de Icaza <miguel@ximian.com>
27964 * driver.cs: Compute dynamically the system directory.
27966 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
27967 Slower, but more generally useful. Used by the abstract
27968 registering implementation.
27970 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
27971 the rules for the special rule on Type/instances. First check if
27972 we have the same name, and if so, try that special static path
27973 rather than the instance path.
27975 2002-01-18 Miguel de Icaza <miguel@ximian.com>
27977 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
27980 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
27981 Enum, ValueType, Delegate or Array for non-corlib compiles.
27983 * cs-tokenizer.cs: Catch long identifiers (645)
27985 * typemanager.cs (IndexerPropetyName): Ravi never tested this
27988 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
27989 fix, we were returning too early, so we were not registering
27990 pending methods from abstract classes.
27992 Do not register pending methods if the class is abstract.
27994 * expression.cs (Conditional.DoResolve): Report circular implicit
27995 conversions when we neecd to compute it for conditional
27998 (Is.DoResolve): If the expression is always of the provided type,
27999 flag warning 183. If the expression can not ever be of the
28000 provided type flag warning 184.
28002 * class.cs: Catch 169 as well.
28004 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28007 2002-01-18 Nick Drochak <ndrochak@gol.com>
28009 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28011 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28013 * interface.cs: (PopulateMethod): Check for pointers being defined
28014 only if the unsafe context is active.
28015 (PopulateProperty): ditto.
28016 (PopulateIndexer): ditto.
28018 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28019 specified. If pointers are present, make sure that they are
28020 present in an unsafe context.
28021 (Constructor, Constructor.Define): ditto.
28022 (Field, Field.Define): ditto.
28023 (Property, Property.Define): ditto.
28024 (Event, Event.Define): ditto.
28026 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28027 hashtable if there are classes or structs defined.
28029 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28030 code, as the constant resolution moved.
28032 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28033 the metadata, so we can flag error 133.
28035 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28036 pointer is being declared in an unsafe context.
28038 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28040 * modifiers.cs (Modifiers.Check): Require a Location argument.
28041 Report error 227 for Unsafe use.
28043 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28045 * statement.cs (For.Emit): If the test is null, then report that
28046 we do `return', as we wont reach anything afterwards.
28048 (Switch.SwitchGoverningType): Track the expression that matched
28051 * driver.cs: Allow negative numbers as an error code to flag.
28053 * cs-parser.jay: Handle 1551.
28055 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28057 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28059 * cs-parser.jay: Report 1518 (type declaration can only contain
28060 class, struct, interface, enum or delegate)
28062 (switch_label): Report 1523 (keywords `case' or `default' must
28065 (opt_switch_sections): Report 1522 (empty switch)
28067 * driver.cs: Report 1515 (response file specified multiple times)
28068 Report 1516 (Source file specified multiple times).
28070 * expression.cs (Argument.Resolve): Signal 1510
28072 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28073 access not allowed in static code)
28075 2002-01-11 Ravi Pratap <ravi@ximian.com>
28077 * typemanager.cs (IsPointerType): Utility method which we are going
28080 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28081 the object type, so we take care of that.
28083 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28085 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28086 added to non-params parameters :-)
28088 * typemanager.cs (CSharpName): Include 'void' type too.
28090 (void_ptr_type): Include in the set of core types.
28092 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28095 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28098 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28099 completely forgotten about it.
28101 2002-01-10 Ravi Pratap <ravi@ximian.com>
28103 * cs-parser.jay (pointer_type): Add. This begins our implementation
28104 of parsing rules for unsafe code.
28106 (unsafe_statement): Implement.
28108 (embedded_statement): Modify to include the above.
28110 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28112 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28113 if the current context is an unsafe one.
28115 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28116 are handled differently, we need separate rules for them.
28118 (local_variable_declaration): Update to use local_variable_pointer_type
28119 to allow variable declarations of unmanaged pointer types.
28121 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28122 in unsafe contexts.
28124 * ../errors/cs0214.cs : Add.
28126 2002-01-16 Nick Drochak <ndrochak@gol.com>
28128 * makefile: remove 'response' file when cleaning.
28130 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28132 * cs-parser.jay: Report 1524.
28134 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28136 * typemanager.cs (RegisterMethod): drop checking if we have
28137 registered this from here
28139 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28141 * class.cs (Method.EmitDestructor): Implement calling our base
28144 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28145 value of InFinally.
28147 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28148 this routine and will wrap the call in a try/catch block. Deal
28151 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28153 * ecore.cs (Expression.MemberLookup): instead of taking a
28154 parameter `same_type' that was used to tell whether we could
28155 access private members we compute our containing type from the
28158 (FieldExpr): Added partial support for volatile fields. This does
28159 not work for volatile fields exposed from assemblies, as I can not
28160 figure out how to extract the modreq from it.
28162 Updated all the source files to use this.
28164 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28165 because it is referenced by MemberLookup very often.
28167 2002-01-09 Ravi Pratap <ravi@ximian.com>
28169 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28170 TypeBuilder.GetCustomAttributes to retrieve what we need.
28172 Get rid of redundant default_member_attr_type as this is the same as
28173 default_member_type which already exists.
28175 * interface.cs, attribute.cs : Update accordingly.
28177 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28179 * typemanager.cs: Enable IndexerPropertyName again. It does not
28180 work for TYpeBuilders though. Ravi, can you please fix this?
28182 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28184 * expression.cs (Argument.Emit): Handle the case of ref objects
28185 being passed to ref functions;
28187 (ParameterReference.EmitLoad): Loads the content of the pointer
28188 without dereferencing.
28190 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28192 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28194 2002-01-08 Ravi Pratap <ravi@ximian.com>
28196 * class.cs (Indexer.DefineMethod): Incorporate the interface
28197 type in the name of the method if we are doing explicit interface
28200 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28202 (BetterConversion): Fix extremely trivial bug where we were referring to
28203 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28206 * ../errors/bug16.cs : Add although we have fixed it.
28208 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28210 * expression.cs (BaseIndexer): Begin implementation.
28212 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28214 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28215 production directly to remove a shift/reduce, and implement
28216 explicit interface implementation.
28218 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28219 after a floating point suffix.
28221 * expression.cs (DoNumericPromotions): Improved the conversion for
28222 uint/uint. If we have a constant, we avoid doing a typecast to a
28225 * class.cs (Indexer): Implement explicit interface implementation
28228 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28230 * class.cs: make the default instance constructor public and hidebysig.
28232 2001-01-03 Ravi Pratap <ravi@ximian.com>
28234 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28235 so we can call it from elsewhere.
28237 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28238 we emit it internally if the class has a defined indexer; otherwise the user
28239 emits it by decorating the class definition with the DefaultMemberAttribute.
28241 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28242 attribute is not used on a type which defines an indexer.
28244 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28245 character when we skip whitespace.
28247 * ../errors/cs0646.cs : Add.
28249 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28251 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28254 * makefile: Add practical target `mcs3.exe' which builds the third
28255 generation compiler.
28257 * expression.cs (New): Fix structures constructor calling.
28259 * class.cs (Property, Method, Indexer): Emit Final flag on the
28260 method if we are an interface implementation and we are not
28263 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28264 whether this property is referencing a `base' method.
28266 * expression.cs (Invocation.EmitCall): take an extra argument:
28267 is_base, this is used to determine whether the `call' or
28268 `callvirt' opcode should be used.
28271 * delegate.cs: update EmitCall.
28273 * class.cs (Method.Define): Set NewSlot for the cases where we are
28274 not implementing an interface method.
28276 (Property.Define): ditto.
28278 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28280 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28281 'r'. Allows mcs to parse itself fully.
28283 2002-01-02 Ravi Pratap <ravi@ximian.com>
28285 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28286 of the number of initializers that require the InitializeArray method.
28288 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28289 update the above field where necessary.
28291 (MakeByteBlob): Update accordingly.
28293 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28296 (EmitDynamicInitializers): Update in accordance with the new optimization.
28298 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28299 same OpCode applies.
28301 * cs-parser.jay : Fix some glaring errors I introduced.
28303 2002-01-01 Ravi Pratap <ravi@ximian.com>
28305 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28306 so that we can check for name clashes there too.
28308 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28309 for interface indexers.
28311 * interfaces.cs (Define): Emit the default member attribute.
28313 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28314 variable was being referred to while setting the value ;-)
28316 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28318 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28319 byte-by-byte information when we know the data is zero.
28321 Make the block always a multiple of 4, because
28322 DefineInitializedData has a bug.
28324 * assign.cs: Fix, we should assign from the temporary, not from
28327 * expression.cs (MakeByteBlob): Fix my incorrect code.
28329 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28331 * typemanager.cs (EnumToUnderlying): This function is used to get
28332 the underlying type from an enumeration, because it does not
28335 * constant.cs: Use the I4_S form for values between -128 and 127.
28337 * statement.cs (Block.LookupLabel): Looks up a label.
28338 (Block): Drop support for labeled blocks.
28340 (LabeledStatement): New kind of statement that represents a label
28343 (Goto): Finally implement this bad boy.
28345 * cs-parser.jay: Update to reflect new mechanism to implement
28348 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28350 * codegen.cs (EmitContext.This): a codegen property that keeps the
28351 a single instance of this instead of creating many different this
28354 * delegate.cs (Delegate.DoResolve): Update to use the property;
28356 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28358 * expression.cs (BaseAccess.DoResolve): Ditto.
28360 2001-12-29 Ravi Pratap <ravi@ximian.com>
28362 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28363 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28365 (InitCoreTypes): Update accordingly.
28367 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28368 so we can quickly store the state.
28370 (ApplyAttributes): Set the correct implementation flags
28371 for InternalCall methods.
28373 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28375 * expression.cs (EmitCall): if a method is not virtual, then do
28376 not use callvirt on it.
28378 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28379 user defined stuff) requires the use of stobj, which takes an
28380 address on the stack instead of an array and an index. So emit
28381 the Ldelema operation for it.
28383 (EmitStoreOpcode): Use stobj for valuetypes.
28385 (UnaryMutator.EmitCode): Use the right 1 value depending on
28386 whether we are dealing with int64/uint64, float or doubles.
28388 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28389 constructors that I implemented last night.
28391 (Constructor.IsDefault): Fix to work properly for static
28394 * cs-parser.jay (CheckDef): report method signature errors.
28395 Update error number 103 to be 132.
28397 * decl.cs: New AdditionResult enumeration value: MethodExists.
28398 Although we do this check for methods later on in the semantic
28399 analysis, catching repeated default constructors is so easy that
28400 we catch these here.
28402 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28405 (ParameterReference.EmitAssign, Emit): handle
28408 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28409 (ArrayAccess.EmitStoreOpcode): ditto.
28411 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28413 * expression.cs (MakeByteBlob): Complete all the missing types
28414 (uint, short, ushort, byte, sbyte)
28416 * class.cs: Only init instance field initializers on instance
28419 Rename `constructors' to instance_constructors.
28421 (TypeContainer.AddConstructor): Only add constructors to the list
28422 if it is not static.
28424 Make sure that we handle default_static_constructor independently
28425 everywhere where we handle instance_constructors
28427 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28429 * class.cs: Do not lookup or create a base initializer for a
28430 static constructor.
28432 (ConstructorInitializer.Resolve): use the proper type to lookup
28435 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28437 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28440 * decl.cs: CloseType is now an virtual method, the default
28441 implementation just closes this type.
28443 2001-12-28 Ravi Pratap <ravi@ximian.com>
28445 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28446 to PreserveSig by default. Also emit HideBySig on such methods.
28448 Basically, set the defaults to standard values.
28450 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28451 argument, if candidate is better, it can't be worse than the best !
28453 (Invocation): Re-write bits to differentiate between methods being
28454 applicable in their expanded form and their normal form - for params
28457 Get rid of use_standard everywhere as only standard conversions are allowed
28458 in overload resolution.
28460 More spec conformance.
28462 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28464 * driver.cs: Add --timestamp, to see where the compiler spends
28467 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28468 `this' in static code.
28470 (SimpleName.DoResolve): Implement in terms of a helper function
28471 that allows static-references to be passed upstream to
28474 (Expression.ResolveWithSimpleName): Resolve specially simple
28475 names when called by MemberAccess to implement the special
28478 (Expression.ImplicitReferenceConversion): Handle conversions from
28479 Null to reference types before others, as Null's type is
28482 * expression.cs (Invocation.EmitCall): Handle the special case of
28483 calling methods declared on a reference type from a ValueType
28484 (Base classes System.Object and System.Enum)
28486 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28487 the left hand side is a TypeExpr, not on every enumeration.
28489 (Binary.Resolve): If types are reference types, then do a cast to
28490 object on operators != and == of both arguments.
28492 * typemanager.cs (FindMembers): Extract instance and static
28493 members if requested.
28495 * interface.cs (PopulateProperty): Use void_type instead of null
28496 as the return type for the setter method.
28498 (PopulateIndexer): ditto.
28500 2001-12-27 Ravi Pratap <ravi@ximian.com>
28502 * support.cs (ReflectionParameters): Fix minor bug where we
28503 were examining the wrong parameter for the ParamArray attribute.
28505 Cope with requests for the type of the parameter at position
28506 greater than the params parameter's. We now return the element
28507 type of the params array as that makes more sense.
28509 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28510 accordingly as we no longer have to extract the element type
28513 (Invocation.OverloadResolve): Update.
28515 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28517 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28518 against IEnumerator, test whether the return value is a descendant
28519 of the IEnumerator interface.
28521 * class.cs (Indexer.Define): Use an auxiliary method to implement
28522 the other bits of the method definition. Begin support for
28523 explicit interface implementation.
28525 (Property.DefineMethod): Use TypeManager.void_type instead of null
28526 for an empty return value.
28528 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28530 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28531 dealing with a FieldExpr which is composed of a FieldBuilder, in
28532 the code path we did extract the constant, but we should have
28533 obtained the underlying value to be able to cast it (otherwise we
28534 end up in an infinite loop, this is what Ravi was running into).
28536 (ArrayCreation.UpdateIndices): Arrays might be empty.
28538 (MemberAccess.ResolveMemberAccess): Add support for section
28539 14.5.4.1 that deals with the special case of E.I when E is a type
28540 and something else, that I can be a reference to a static member.
28542 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28543 handle a particular array type to create byte blobs, it is just
28544 something we dont generate byteblobs for.
28546 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28549 * location.cs (Push): remove the key from the hashtable that we
28550 are about to add. This happens for empty files.
28552 * driver.cs: Dispose files after we have parsed them.
28554 (tokenize): new function that only runs the tokenizer on its
28555 input, for speed testing.
28557 2001-12-26 Ravi Pratap <ravi@ximian.com>
28559 * class.cs (Event.Define): Define the private field only if there
28560 are no accessors defined.
28562 * expression.cs (ResolveMemberAccess): If there is no associated
28563 field with the event, that means we have an event defined with its
28564 own accessors and we should flag error cs0070 since transforming
28565 ourselves into a field is not valid in that case.
28567 * ecore.cs (SimpleName.DoResolve): Same as above.
28569 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28570 and charset to sane values.
28572 2001-12-25 Ravi Pratap <ravi@ximian.com>
28574 * assign.cs (DoResolve): Perform check on events only if they
28575 are being accessed outside the declaring type.
28577 * cs-parser.jay (event_declarations): Update rules to correctly
28578 set the type of the implicit parameter etc.
28580 (add_accessor, remove_accessor): Set current local parameters.
28582 * expression.cs (Binary): For delegate addition and subtraction,
28583 cast the return value from the method into the appropriate delegate
28586 2001-12-24 Ravi Pratap <ravi@ximian.com>
28588 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28589 of these as the workaround is unnecessary.
28591 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28592 delegate data - none of that is needed at all.
28594 Re-write bits to extract the instance expression and the delegate method
28597 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
28600 * attribute.cs (ApplyAttributes): New method to take care of common tasks
28601 of attaching attributes instead of duplicating code everywhere.
28603 * everywhere : Update code to do attribute emission using the above method.
28605 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28607 * expression.cs (IsParamsMethodApplicable): if there are not
28608 parameters, return immediately.
28610 * ecore.cs: The 0 literal can be implicity converted to an enum
28613 (SimpleName.DoResolve): First lookup the type, then lookup the
28616 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
28617 want to get its address. If the InstanceExpression is not
28618 addressable, store the result in a temporary variable, then get
28621 * codegen.cs: Only display 219 errors on warning level or above.
28623 * expression.cs (ArrayAccess): Make it implement the
28624 IMemoryLocation interface.
28626 (Binary.DoResolve): handle the operator == (object a, object b)
28627 and operator != (object a, object b) without incurring into a
28628 BoxedCast (because 5 != o should never be performed).
28630 Handle binary enumerator operators.
28632 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
28633 value type, otherwise use Ldelem_ref.
28635 Use precomputed names;
28637 (AddressOf): Implement address of
28639 * cs-parser.jay (labeled_statement): Fix recursive block
28640 addition by reworking the production.
28642 * expression.cs (New.DoEmit): New has a special case:
28644 If we are dealing with a ValueType, we have a few
28645 situations to deal with:
28647 * The target of New is a ValueType variable, that is
28648 easy, we just pass this as the variable reference
28650 * The target of New is being passed as an argument,
28651 to a boxing operation or a function that takes a
28654 In this case, we need to create a temporary variable
28655 that is the argument of New.
28658 2001-12-23 Ravi Pratap <ravi@ximian.com>
28660 * rootcontext.cs (LookupType): Check that current_type is not null before
28661 going about looking at nested types.
28663 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
28664 not implement the IAssignMethod interface any more.
28666 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
28667 where we tranform them into FieldExprs if they are being resolved from within
28668 the declaring type.
28670 * ecore.cs (SimpleName.DoResolve): Do the same here.
28672 * assign.cs (DoResolve, Emit): Clean up code considerably.
28674 * ../errors/bug10.cs : Add.
28676 * ../errors/cs0070.cs : Add.
28678 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
28680 * assign.cs : Get rid of EventIsLocal everywhere.
28682 2001-12-23 Miguel de Icaza <miguel@ximian.com>
28684 * ecore.cs (ConvertIntLiteral): finished the implementation.
28686 * statement.cs (SwitchLabel): Convert the value we are using as a
28687 key before looking up the table.
28689 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28691 * codegen.cs (EmitTopBlock): Require a Location argument now.
28693 * cs-parser.jay (constructor_declarator): We need to setup
28694 current_local_parameters before we parse the
28695 opt_constructor_initializer, to allow the variables to be bound
28696 to the constructor arguments.
28698 * rootcontext.cs (LookupType): First lookup nested classes in our
28699 class and our parents before we go looking outside our class.
28701 * expression.cs (ConstantFold): Extract/debox the values at the
28704 * rootcontext.cs (EmitCode): Resolve the constants first before we
28705 resolve the types. This is not really needed, but it helps debugging.
28707 * statement.cs: report location.
28709 * cs-parser.jay: pass location to throw statement.
28711 * driver.cs: Small bug fix.
28713 * report.cs: Updated format to be 4-zero filled digits.
28715 2001-12-22 Ravi Pratap <ravi@ximian.com>
28717 * expression.cs (CheckIndices): Fix minor bug where the wrong
28718 variable was being referred to ;-)
28720 (DoEmit): Do not call EmitStaticInitializers when the
28721 underlying type is System.Object.
28723 2001-12-21 Ravi Pratap <ravi@ximian.com>
28725 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
28726 and do the usual workaround for SRE.
28728 * class.cs (MyEventBuilder.EventType): New member to get at the type
28729 of the event, quickly.
28731 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
28733 * assign.cs (Assign.DoResolve): Handle the case when the target
28734 is an EventExpr and perform the necessary checks.
28736 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
28739 (SimpleName.MemberStaticCheck): Include check for EventExpr.
28741 (EventExpr): Set the type in the constructor itself since we
28742 are meant to be born fully resolved.
28744 (EventExpr.Define): Revert code I wrote earlier.
28746 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
28747 instance expression is null. The instance expression is a This in that case
28748 or a null, depending on whether it is a static method or not.
28750 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
28751 refers to more than one method.
28753 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
28754 and accordingly flag errors.
28756 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28758 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
28760 2001-12-22 Miguel de Icaza <miguel@ximian.com>
28762 * location.cs (ToString): Provide useful rutine.
28764 2001-12-21 Miguel de Icaza <miguel@ximian.com>
28766 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
28767 objects, return the actual integral boxed.
28769 * statement.cs (SwitchLabel): define an ILLabel for each
28772 (Switch.CheckSwitch): If the value is a Literal, extract
28773 the underlying literal.
28775 Also in the unused hashtable we had, add the SwitchLabel so we can
28776 quickly look this value up.
28778 * constant.cs: Implement a bunch of new constants. Rewrite
28779 Literal based on this. Made changes everywhere to adapt to this.
28781 * expression.cs (Expression.MakeByteBlob): Optimize routine by
28782 dereferencing array only once, and also copes with enumrations.
28784 bytes are two bytes wide, not one.
28786 (Cast): Perform constant conversions.
28788 * ecore.cs (TryImplicitIntConversion): Return literals instead of
28789 wrappers to the literals here.
28791 * expression.cs (DoNumericPromotions): long literals can converted
28792 to ulong implicity (this is taken care of elsewhere, but I was
28793 missing this spot).
28795 * ecore.cs (Expression.Literalize): Make the return type Literal,
28796 to improve type checking.
28798 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
28800 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28802 * literal.cs: Revert code from ravi that checked the bounds. The
28803 bounds are sane by the definition of the type itself.
28805 * typemanager.cs: Fix implementation of ImplementsInterface. We
28806 need to actually look up in our parent hierarchy for interfaces
28809 * const.cs: Use the underlying type for enumerations
28811 * delegate.cs: Compute the basename for the delegate creation,
28812 that should fix the delegate test case, and restore the correct
28813 Type Lookup semantics in rootcontext
28815 * rootcontext.cs: Revert Ravi's last patch. The correct way of
28816 referencing a nested type with the Reflection API is using the "+"
28819 * cs-parser.jay: Do not require EOF token at the end.
28821 2001-12-20 Ravi Pratap <ravi@ximian.com>
28823 * rootcontext.cs (LookupType): Concatenate type names with
28824 a '.' instead of a '+' The test suite passes again.
28826 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
28827 field of the enumeration.
28829 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
28830 the case when the member is an EventExpr.
28832 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
28833 static has an associated instance expression.
28835 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
28837 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
28839 * class.cs (Event.Define): Register event and perform appropriate checks
28842 We define the Add and Remove methods even if the use provides none because
28843 in that case, we provide default implementations ourselves.
28845 Define a private field of the type of the event. This is done by the CSC compiler
28846 and we should be doing it too ;-)
28848 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
28849 More methods we use in code we generate.
28851 (multicast_delegate_type, delegate_type): Two separate types since the distinction
28854 (InitCoreTypes): Update accordingly for the above.
28856 * class.cs (Event.Emit): Generate code for default accessors that we provide
28858 (EmitDefaultMethod): Do the job in the above.
28860 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
28863 2001-12-20 Miguel de Icaza <miguel@ximian.com>
28865 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
28866 builders even if we were missing one.
28868 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
28869 pass the Basename as our class name instead of the Name. The
28870 basename will be correctly composed for us.
28872 * parameter.cs (Paramters): Now takes a Location argument.
28874 * decl.cs (DeclSpace.LookupType): Removed convenience function and
28875 make all the code call directly LookupType in RootContext and take
28876 this chance to pass the Location information everywhere.
28878 * Everywhere: pass Location information.
28880 2001-12-19 Miguel de Icaza <miguel@ximian.com>
28882 * class.cs (Constructor.Define): Updated way of detecting the
28883 length of the parameters.
28885 (TypeContainer.DefineType): Use basename as the type name for
28888 (TypeContainer.Define): Do not recursively define types here, as
28889 definition is taken care in order by the RootContext.
28891 * tree.cs: Keep track of namespaces in a per-file basis.
28893 * parameter.cs (Parameter.ComputeSignature): Update to use
28896 (Parameters.GetSignature): ditto.
28898 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
28899 instead of a TypeContainer.
28901 (Interface.SemanticAnalysis): Use `this' instead of our parent to
28902 resolve names. Because we need to be resolve in our context, not
28905 * driver.cs: Implement response files.
28907 * class.cs (TypeContainer.DefineType): If we are defined, do not
28908 redefine ourselves.
28910 (Event.Emit): Emit the code for add/remove handlers.
28911 (Event.Define): Save the MethodBuilders for add/remove.
28913 * typemanager.cs: Use pair here too.
28915 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
28916 DictionaryEntry requires the first argument to be non-null.
28918 (enum_declaration): Compute full name for registering the
28921 (delegate_declaration): Instead of using
28922 formal_parameter_list, use opt_formal_parameter_list as the list
28925 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
28926 (EventParsing): New property that controls whether `add' and
28927 `remove' are returned as tokens or identifiers (for events);
28929 2001-12-19 Ravi Pratap <ravi@ximian.com>
28931 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
28932 use MyEventBuilder only and let it wrap the real builder for us.
28934 (MyEventBuilder): Revamp constructor etc.
28936 Implement all operations that we perform on EventBuilder in precisely the same
28939 (FindMembers): Update to use the EventBuilder member.
28941 (Event.Emit): Update accordingly.
28943 2001-12-18 Ravi Pratap <ravi@ximian.com>
28945 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
28946 by calling the appropriate methods.
28948 (GetCustomAttributes): Make stubs as they cannot possibly do anything
28951 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
28953 2001-12-17 Ravi Pratap <ravi@ximian.com>
28955 * delegate.cs (Delegate.Populate): Check that the return type
28956 and various parameters types are indeed accessible.
28958 * class.cs (Constructor.Define): Same here.
28960 (Field.Define): Ditto.
28962 (Event.Define): Ditto.
28964 (Operator.Define): Check that the underlying Method defined itself
28965 correctly - so it's MethodBuilder should not be null.
28967 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
28968 expression happens to be null.
28970 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
28971 members but as of now we don't seem to be able to do anything really useful with it.
28973 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
28974 not the EventBuilder.
28976 2001-12-18 Miguel de Icaza <miguel@ximian.com>
28978 * cs-tokenizer.cs: Add support for defines.
28979 Add support for #if, #elif, #else, #endif
28981 (eval_var): evaluates a variable.
28982 (eval): stubbed for evaluating functions.
28984 * cs-parser.jay: Pass the defines information
28986 * driver.cs: Add --define command line option.
28988 * decl.cs: Move MemberCore here.
28990 Make it the base class for DeclSpace. This allows us to catch and
28991 report 108 and 109 for everything now.
28993 * class.cs (TypeContainer.Define): Extract all the members
28994 before populating and emit the warning 108 (new keyword required
28995 to override) instead of having each member implement this.
28997 (MemberCore.Define): New abstract method, we will be using this in
28998 the warning reporting engine in Populate.
29000 (Operator.Define): Adjust to new MemberCore protocol.
29002 * const.cs (Const): This does not derive from Expression, it is a
29003 temporary object we use to create fields, it is a MemberCore.
29005 * class.cs (Method.Define): Allow the entry point to be in a
29008 * driver.cs: Rewrite the argument handler to clean it up a bit.
29010 * rootcontext.cs: Made it just an auxiliary namespace feature by
29011 making everything static.
29013 * driver.cs: Adapt code to use RootContext type name instead of
29016 * delegate.cs: Remove RootContext argument.
29018 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29021 * class.cs (Event.Define): The lookup can fail.
29023 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29025 * expression.cs: Resolve the this instance before invoking the code.
29027 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29029 * cs-parser.jay: Add a production in element_access that allows
29030 the thing to become a "type" reference. This way we can parse
29031 things like "(string [])" as a type.
29033 Note that this still does not handle the more complex rules of
29037 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29039 * ecore.cs: (CopyNewMethods): new utility function used to
29040 assemble the list of methods from running FindMembers.
29042 (MemberLookup): Rework FindMembers so that
29044 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29046 * class.cs (TypeContainer): Remove Delegates who fail to be
29049 * delegate.cs (Populate): Verify that we dont get null return
29050 values. TODO: Check for AsAccessible.
29052 * cs-parser.jay: Use basename to emit error 574 (destructor should
29053 have the same name as container class), not the full name.
29055 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29056 possible representation.
29058 Also implements integer type suffixes U and L.
29060 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29062 * expression.cs (ArrayCreation.DoResolve): We need to do the
29063 argument resolution *always*.
29065 * decl.cs: Make this hold the namespace. Hold the root context as
29067 (LookupType): Move here.
29069 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29071 * location.cs (Row, Name): Fixed the code, it was always returning
29072 references to the first file.
29074 * interface.cs: Register properties defined through interfaces.
29076 * driver.cs: Add support for globbing on the command line
29078 * class.cs (Field): Make it derive from MemberCore as well.
29081 2001-12-15 Ravi Pratap <ravi@ximian.com>
29083 * class.cs (Event::Define): Check that the type of the event is a delegate
29084 type else flag error #66.
29086 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29089 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29090 values of EntryPoint, CharSet etc etc.
29092 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29094 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29095 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29096 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29097 which needs this to do its work.
29099 * ../errors/cs0066.cs : Add.
29101 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29103 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29106 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29107 clears out the parameters field.
29108 (MemberSignatureCompare): Cleanup
29110 (MemberCore): New base class used to share code between MethodCore
29113 (RegisterRequiredImplementations) BindingFlags.Public requires
29114 either BindingFlags.Instace or Static. Use instance here.
29116 (Property): Refactored code to cope better with the full spec.
29118 * parameter.cs (GetParameterInfo): Return an empty array instead
29121 * class.cs (Property): Abstract or extern properties have no bodies.
29123 * parameter.cs (GetParameterInfo): return a zero-sized array.
29125 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29126 method modifier validation to the typecontainer so we can reuse
29127 this on properties.
29129 (MethodCore.ParameterTypes): return an empty sized array of types.
29131 (Property.Define): Test property modifier validity.
29133 Add tests for sealed/override too.
29135 (Method.Emit): abstract or extern methods have no bodies.
29137 2001-12-14 Ravi Pratap <ravi@ximian.com>
29139 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29142 (Method::Define, ::Emit): Modify accordingly.
29144 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29146 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29148 * makefile: Pass in /unsafe.
29150 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29152 * class.cs (MakeKey): Kill routine.
29154 * class.cs (TypeContainer.Define): Correctly define explicit
29155 method implementations (they require the full interface name plus
29158 * typemanager.cs: Deply the PtrHashtable here and stop using the
29159 lame keys. Things work so much better.
29161 This of course broke everyone who depended on `RegisterMethod' to
29162 do the `test for existance' test. This has to be done elsewhere.
29164 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29165 the object stupid Equals method (because, that like fails all over
29166 the place). We still do not use it.
29168 * class.cs (TypeContainer.SetRequiredInterface,
29169 TypeContainer.RequireMethods): Killed these two routines and moved
29170 all the functionality to RegisterRequiredImplementations.
29172 (TypeContainer.RegisterRequiredImplementations): This routine now
29173 registers all the implementations required in an array for the
29174 interfaces and abstract methods. We use an array of structures
29175 which can be computed ahead of time to reduce memory usage and we
29176 also assume that lookups are cheap as most classes will not
29177 implement too many interfaces.
29179 We also avoid creating too many MethodSignatures.
29181 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29182 clear the "pending" bit if we find that there are problems with
29185 (TypeContainer.VerifyPendingMethods): Update to report errors of
29186 methods that look like implementations but are not.
29188 (TypeContainer.Define): Add support for explicit interface method
29191 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29193 * typemanager.cs: Keep track of the parameters here instead of
29194 being a feature of the TypeContainer.
29196 * class.cs: Drop the registration of parameters here, as
29197 InterfaceMethods are also interface declarations.
29199 * delegate.cs: Register methods with the TypeManager not only with
29200 the TypeContainer. This code was buggy.
29202 * interface.cs: Full registation here.
29204 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29206 * expression.cs: Remove reducer for binary expressions, it can not
29209 * const.cs: Put here the code that used to go into constant.cs
29211 * constant.cs: Put here the code for constants, this is a new base
29212 class for Literals.
29214 * literal.cs: Make Literal derive from Constant.
29216 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29218 * statement.cs (Return.Emit): Report error 157 if the user
29219 attempts to return from a finally block.
29221 (Return.Emit): Instead of emitting a return, jump to the end of
29224 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29225 LocalBuilder to store the result of the function. ReturnLabel is
29226 the target where we jump.
29229 2001-12-09 Radek Doulik <rodo@ximian.com>
29231 * cs-parser.jay: remember alias in current namespace
29233 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29236 * class.cs (LookupAlias): lookup alias in my_namespace
29238 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29240 (LookupAlias): lookup alias in this and if needed in parent
29243 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29247 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29248 making things static. I need this to avoid passing the
29249 TypeContainer when calling ParameterType.
29251 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29252 that did string manipulation to compute the type and then call
29253 GetType. Use Parameter.ParameterType instead.
29255 * cs-tokenizer.cs: Consume the suffix for floating values.
29257 * expression.cs (ParameterReference): figure out whether this is a
29258 reference parameter or not. Kill an extra variable by computing
29259 the arg_idx during emission.
29261 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29262 function that returns whether a parameter is an out/ref value or not.
29264 (Parameter.ParameterType): The type of the parameter (base,
29265 without ref/out applied).
29267 (Parameter.Resolve): Perform resolution here.
29268 (Parameter.ExternalType): The full type (with ref/out applied).
29270 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29271 support for expressions on the using statement.
29273 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29275 * statement.cs (Using.EmitLocalVariableDecls): Split the
29276 localvariable handling of the using statement.
29278 (Block.EmitMeta): Keep track of variable count across blocks. We
29279 were reusing slots on separate branches of blocks.
29281 (Try.Emit): Emit the general code block, we were not emitting it.
29283 Check the type of the declaration to be an IDisposable or
29284 something that can be implicity converted to it.
29286 Emit conversions if required.
29288 * ecore.cs (EmptyExpression): New utility class.
29289 (Expression.ImplicitConversionExists): New utility function.
29291 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29293 * statement.cs (Using): Implement.
29295 * expression.cs (LocalVariableReference): Support read only variables.
29297 * statement.cs: Remove the explicit emit for the Leave opcode.
29298 (VariableInfo): Add a readonly field.
29300 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29302 * ecore.cs (ConvCast): new class used to encapsulate the various
29303 explicit integer conversions that works in both checked and
29304 unchecked contexts.
29306 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29307 properly generate the overflow opcodes.
29309 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29311 * statement.cs: The correct type for the EmptyExpression is the
29312 element_type, not the variable type. Ravi pointed this out.
29314 2001-12-04 Ravi Pratap <ravi@ximian.com>
29316 * class.cs (Method::Define): Handle PInvoke methods specially
29317 by using DefinePInvokeMethod instead of the usual one.
29319 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29320 above to do the task of extracting information and defining the method.
29322 2001-12-04 Ravi Pratap <ravi@ximian.com>
29324 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29325 of the condition for string type.
29327 (Emit): Move that here.
29329 (ArrayCreation::CheckIndices): Keep string literals in their expression
29332 (EmitDynamicInitializers): Handle strings appropriately.
29334 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29336 * codegen.cs (EmitContext): Replace multiple variables with a
29337 single pointer to the current Switch statement.
29339 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29342 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29346 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29349 (Foreach.Emit): Foreach on arrays was not setting
29350 up the loop variables (for break/continue).
29352 (GotoCase): Semi-implented.
29354 2001-12-03 Ravi Pratap <ravi@ximian.com>
29356 * attribute.cs (CheckAttribute): Handle system attributes by using
29357 Attribute.GetAttributes to examine information we need.
29359 (GetValidPlaces): Same here.
29361 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29363 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29365 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29367 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29369 (Method::Emit): Handle the case when we are a PInvoke method.
29371 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29373 * expression.cs: Use ResolveWithSimpleName on compound names.
29375 2001-12-02 Ravi Pratap <ravi@ximian.com>
29377 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29378 before trying to reduce it.
29380 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29382 * constant.cs (LookupConstantValue): Implement.
29384 (EmitConstant): Use the above in emitting the constant.
29386 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29387 that are user-defined by doing a LookupConstantValue on them.
29389 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29392 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29394 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29396 (BaseAccess.DoResolve): Implement.
29398 (MemberAccess.DoResolve): Split this routine into a
29399 ResolveMemberAccess routine that can be used independently
29401 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29403 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29404 As that share bits of the implementation. Is returns a boolean,
29405 while As returns the Type that is being probed.
29407 2001-12-01 Ravi Pratap <ravi@ximian.com>
29409 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29410 instead of a Literal - much easier.
29412 (EnumInTransit): Remove - utterly useless :-)
29414 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29416 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29418 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29419 chain when we have no associated expression.
29421 2001-11-30 Ravi Pratap <ravi@ximian.com>
29423 * constant.cs (Define): Use Location while reporting the errror.
29425 Also emit a warning when 'new' is used and there is no inherited
29428 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29431 (LookupEnumValue): Implement to lookup an enum member's value and define it
29434 (Populate): Re-write accordingly to use the above routine.
29436 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29438 * expression.cs (This): Fix prototype for DoResolveLValue to
29439 override the base class DoResolveLValue.
29441 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29444 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29445 (we need to load the address of the field here). This fixes
29448 (FieldExpr.DoResolveLValue): Call the DoResolve
29449 function to initialize the Instance expression.
29451 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29452 correctly the GetEnumerator operation on a value type.
29454 * cs-parser.jay: Add more simple parsing error catches.
29456 * statement.cs (Switch): Add support for string switches.
29457 Handle null specially.
29459 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29461 2001-11-28 Ravi Pratap <ravi@ximian.com>
29463 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29465 (declare_local_constant): New helper function.
29467 * statement.cs (AddConstant): Keep a separate record of constants
29469 (IsConstant): Implement to determine if a variable is a constant.
29471 (GetConstantExpression): Implement.
29473 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29475 * statement.cs (IsVariableDefined): Re-write.
29477 2001-11-27 Ravi Pratap <ravi@ximian.com>
29479 * class.cs (TypeContainer::FindMembers): Look for constants
29480 in the case when we are looking for MemberTypes.Field
29482 * expression.cs (MemberAccess::DoResolve): Check that in the
29483 case we are a FieldExpr and a Literal, we are not being accessed
29484 by an instance reference.
29486 * cs-parser.jay (local_constant_declaration): Implement.
29488 (declaration_statement): Implement for constant declarations.
29490 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29492 * statement.cs (Switch): Catch double defaults.
29494 (Switch): More work on the switch() statement
29495 implementation. It works for integral values now, need to finish
29499 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29501 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29502 integer literals into other integer literals. To be used by
29505 2001-11-24 Ravi Pratap <ravi@ximian.com>
29507 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29510 (EmitDynamicInitializers): Cope with the above since we extract data
29511 directly from ArrayData now.
29513 (ExpectInitializers): Keep track of whether initializers are mandatory
29516 (Bounds): Make it a hashtable to prevent the same dimension being
29517 recorded for every element in that dimension.
29519 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29522 Also fix bug which was causing the indices to be emitted in the reverse
29525 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29527 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29528 unfinished. They do not work, because the underlying code is
29531 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29533 * cs-parser.jay: Remove bogus fixme.
29535 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29536 on Switch statement.
29538 2001-11-23 Ravi Pratap <ravi@ximian.com>
29540 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29543 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29544 parameter. Apparently, any expression is allowed.
29546 (ValidateInitializers): Update accordingly.
29548 (CheckIndices): Fix some tricky bugs thanks to recursion.
29550 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29551 I was being completely brain-dead.
29553 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29554 and re-write acordingly.
29556 (DelegateInvocation): Re-write accordingly.
29558 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29560 (MakeByteBlob): Handle types more correctly.
29562 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29563 initialization from expressions but it is incomplete because I am a complete
29566 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29568 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29569 on If. Basically, we have to return `true' (ie, we do return to
29570 our caller) only if both branches of the if return.
29572 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29573 short-circuit operators, handle them as short circuit operators.
29575 (Cast.DoResolve): Resolve type.
29576 (Cast.Cast): Take an expression as the target type.
29578 * cs-parser.jay (cast_expression): Remove old hack that only
29579 allowed a limited set of types to be handled. Now we take a
29580 unary_expression and we resolve to a type during semantic
29583 Use the grammar productions from Rhys to handle casts (this is
29584 not complete like Rhys syntax yet, we fail to handle that corner
29585 case that C# has regarding (-x), but we will get there.
29587 2001-11-22 Ravi Pratap <ravi@ximian.com>
29589 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29590 field which is an array type.
29592 * cs-parser.jay (declare_local_variables): Support array initialization too.
29594 * typemanager.cs (MakeKey): Implement.
29596 (everywhere): Use the above appropriately.
29598 * cs-parser.jay (for_statement): Update for array initialization while
29599 declaring variables.
29601 * ecore.cs : The error message was correct, it's the variable's names that
29602 were misleading ;-) Make the code more readable.
29604 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
29605 the correct type etc.
29607 (ConvertExplicit): Handle Enum types by examining the underlying type.
29609 2001-11-21 Ravi Pratap <ravi@ximian.com>
29611 * parameter.cs (GetCallingConvention): Always return
29612 CallingConventions.Standard for now.
29614 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29616 * expression.cs (Binary.ResolveOperator): Update the values of `l'
29617 and `r' after calling DoNumericPromotions.
29619 * ecore.cs: Fix error message (the types were in the wrong order).
29621 * statement.cs (Foreach.ProbeCollectionType): Need to pass
29622 BindingFlags.Instance as well
29624 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
29625 implicit int literal conversion in an empty cast so that we
29626 propagate the right type upstream.
29628 (UnboxCast): new class used to unbox value types.
29629 (Expression.ConvertExplicit): Add explicit type conversions done
29632 (Expression.ImplicitNumericConversion): Oops, forgot to test for
29633 the target type before applying the implicit LongLiterals to ULong
29636 2001-11-21 Miguel de Icaza <miguel@ximian.com>
29638 * cs-parser.jay (for_statement): Reworked the way For works: now
29639 we declare manually any variables that are introduced in
29640 for_initializer to solve the problem of having out-of-band code
29641 emition (that is what got for broken).
29643 (declaration_statement): Perform the actual variable declaration
29644 that used to be done in local_variable_declaration here.
29646 (local_variable_declaration): Do not declare anything, just pass
29647 the information on a DictionaryEntry
29649 2001-11-20 Ravi Pratap <ravi@ximian.com>
29651 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
29652 re-write of the logic to now make it recursive.
29654 (UpdateIndices): Re-write accordingly.
29656 Store element data in a separate ArrayData list in the above methods.
29658 (MakeByteBlob): Implement to dump the array data into a byte array.
29660 2001-11-19 Ravi Pratap <ravi@ximian.com>
29662 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
29665 * constant.cs (Define): Implement.
29667 (EmitConstant): Re-write fully.
29669 Pass in location info.
29671 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
29674 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
29675 DictionaryEntry since we need location info too.
29677 (constant_declaration): Update accordingly.
29679 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
29680 code into another method : UpdateIndices.
29682 2001-11-18 Ravi Pratap <ravi@ximian.com>
29684 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
29685 some type checking etc.
29687 2001-11-17 Ravi Pratap <ravi@ximian.com>
29689 * expression.cs (ArrayCreation::ValidateInitializers): Implement
29690 bits to provide dimension info if the user skips doing that.
29692 Update second constructor to store the rank correctly.
29694 2001-11-16 Ravi Pratap <ravi@ximian.com>
29696 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
29697 and try to implement.
29699 * ../errors/cs0150.cs : Add.
29701 * ../errors/cs0178.cs : Add.
29703 2001-11-16 Miguel de Icaza <miguel@ximian.com>
29705 * statement.cs: Implement foreach on multi-dimensional arrays.
29707 * parameter.cs (Parameters.GetParameterByName): Also lookup the
29708 name of the params argument.
29710 * expression.cs: Use EmitStoreOpcode to get the right opcode while
29711 initializing the array.
29713 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
29714 we can use this elsewhere.
29716 * statement.cs: Finish implementation of foreach for single
29719 * cs-parser.jay: Use an out-of-band stack to pass information
29720 around, I wonder why I need this.
29722 foreach_block: Make the new foreach_block the current_block.
29724 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
29725 function used to return a static Parameters structure. Used for
29726 empty parameters, as those are created very frequently.
29728 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
29730 2001-11-15 Ravi Pratap <ravi@ximian.com>
29732 * interface.cs : Default modifier is private, not public. The
29733 make verify test passes again.
29735 2001-11-15 Ravi Pratap <ravi@ximian.com>
29737 * support.cs (ReflectionParameters): Fix logic to determine
29738 whether the last parameter is a params one. Test 9 passes again.
29740 * delegate.cs (Populate): Register the builders we define with
29741 RegisterParameterForBuilder. Test 19 passes again.
29743 * cs-parser.jay (property_declaration): Reference $6 instead
29744 of $$ to get at the location.
29746 (indexer_declaration): Similar stuff.
29748 (attribute): Ditto.
29750 * class.cs (Property): Register parameters for the Get and Set methods
29751 if they exist. Test 23 passes again.
29753 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
29754 call to EmitArguments as we are sure there aren't any params arguments.
29755 Test 32 passes again.
29757 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
29758 IndexOutOfRangeException.
29760 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
29761 Test 33 now passes again.
29763 2001-11-15 Miguel de Icaza <miguel@ximian.com>
29765 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
29766 broke a bunch of things. Will have to come up with a better way
29767 of tracking locations.
29769 * statement.cs: Implemented foreach for single dimension arrays.
29771 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29773 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
29774 an error. This removes the lookup from the critical path.
29776 * cs-parser.jay: Removed use of temporary_loc, which is completely
29779 2001-11-14 Miguel de Icaza <miguel@ximian.com>
29781 * support.cs (ReflectionParameters.ParameterModifier): Report
29782 whether the argument is a PARAMS argument or not.
29784 * class.cs: Set the attribute `ParamArrayAttribute' on the
29785 parameter argument.
29787 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
29788 and cons_param_array_attribute (ConstructorInfo for
29789 ParamArrayAttribute).,
29791 * codegen.cs: Emit the return using the `Return' statement, that
29792 way we can report the error correctly for missing return values.
29794 * class.cs (Method.Emit): Clean up.
29796 * expression.cs (Argument.Resolve): Take another argument: the
29797 location where this argument is used. Notice that this is not
29798 part of the "Argument" class as to reduce the size of the
29799 structure (we know the approximate location anyways).
29801 Test if the argument is a variable-reference, if not, then
29802 complain with a 206.
29804 (Argument.Emit): Emit addresses of variables.
29806 (Argument.FullDesc): Simplify.
29808 (Invocation.DoResolve): Update for Argument.Resolve.
29810 (ElementAccess.DoResolve): ditto.
29812 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
29813 method should be virtual, as this method is always virtual.
29815 (NewDelegate.DoResolve): Update for Argument.Resolve.
29817 * class.cs (ConstructorInitializer.DoResolve): ditto.
29819 * attribute.cs (Attribute.Resolve): ditto.
29821 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29823 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
29825 * expression.cs (ParameterReference): Drop IStackStorage and implement
29826 IAssignMethod instead.
29828 (LocalVariableReference): ditto.
29830 * ecore.cs (FieldExpr): Drop IStackStorage and implement
29831 IAssignMethod instead.
29833 2001-11-13 Miguel de Icaza <miguel@ximian.com>
29835 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
29836 enumerations that are used in heavily used structures derive from
29837 byte in a laughable and pathetic attempt to reduce memory usage.
29838 This is the kind of pre-optimzations that you should not do at
29839 home without adult supervision.
29841 * expression.cs (UnaryMutator): New class, used to handle ++ and
29842 -- separatedly from the other unary operators. Cleans up the
29843 code, and kills the ExpressionStatement dependency in Unary.
29845 (Unary): Removed `method' and `Arguments' from this class, making
29846 it smaller, and moving it all to SimpleCall, so I can reuse this
29847 code in other locations and avoid creating a lot of transient data
29848 strucutres when not required.
29850 * cs-parser.jay: Adjust for new changes.
29852 2001-11-11 Miguel de Icaza <miguel@ximian.com>
29854 * enum.cs (Enum.Populate): If there is a failure during
29857 * cs-parser.jay (opt_enum_base): we used to catch type errors
29858 here, but this is really incorrect. The type error should be
29859 catched during semantic analysis.
29861 2001-12-11 Ravi Pratap <ravi@ximian.com>
29863 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
29864 current_local_parameters as expected since I, in my stupidity, had forgotten
29867 * attribute.cs (GetValidPlaces): Fix stupid bug.
29869 * class.cs (Method::Emit): Perform check on applicability of attributes.
29871 (Constructor::Emit): Ditto.
29873 (Field::Emit): Ditto.
29875 (Field.Location): Store location information.
29877 (Property, Event, Indexer, Operator): Ditto.
29879 * cs-parser.jay (field_declaration): Pass in location for each field.
29881 * ../errors/cs0592.cs : Add.
29883 2001-11-12 Ravi Pratap <ravi@ximian.com>
29885 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
29887 (InitCoreTypes): Update accordingly.
29889 (RegisterAttrType, LookupAttr): Implement.
29891 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
29892 info about the same.
29894 (Resolve): Update to populate the above as necessary.
29896 (Error592): Helper.
29898 (GetValidPlaces): Helper to the above.
29900 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
29902 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
29904 2001-11-12 Ravi Pratap <ravi@ximian.com>
29906 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
29908 * ../errors/cs0617.cs : Add.
29910 2001-11-11 Ravi Pratap <ravi@ximian.com>
29912 * enum.cs (Emit): Rename to Populate to be more consistent with what
29913 we expect it to do and when exactly it is called.
29915 * class.cs, rootcontext.cs : Update accordingly.
29917 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
29918 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
29920 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
29922 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
29923 of a fieldinfo using the above, when dealing with a FieldBuilder.
29925 2001-11-10 Ravi Pratap <ravi@ximian.com>
29927 * ../errors/cs0031.cs : Add.
29929 * ../errors/cs1008.cs : Add.
29931 * ../errrors/cs0543.cs : Add.
29933 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
29936 (FindMembers): Implement.
29938 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
29939 enums and delegates too.
29941 (enum_types): Rename to builder_to_enum.
29943 (delegate_types): Rename to builder_to_delegate.
29945 * delegate.cs (FindMembers): Implement.
29947 2001-11-09 Ravi Pratap <ravi@ximian.com>
29949 * typemanager.cs (IsEnumType): Implement.
29951 * enum.cs (Emit): Re-write parts to account for the underlying type
29952 better and perform checking etc.
29954 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
29955 of the underlying type.
29957 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
29960 * enum.cs (error31): Helper to report error #31.
29962 * cs-parser.jay (enum_declaration): Store location of each member too.
29964 * enum.cs (member_to_location): New hashtable.
29966 (AddEnumMember): Update location hashtable.
29968 (Emit): Use the location of each member while reporting errors.
29970 2001-11-09 Miguel de Icaza <miguel@ximian.com>
29972 * cs-parser.jay: A for_initializer if is a
29973 local_variable_declaration really ammount to have an implicit
29974 block with the variable declaration and no initializer for for.
29976 * statement.cs (For.Emit): Cope with null initializers.
29978 This fixes the infinite loop on for initializers.
29980 2001-11-08 Miguel de Icaza <miguel@ximian.com>
29982 * enum.cs: More cleanup.
29984 * ecore.cs: Remove dead code.
29986 * class.cs (Property.Emit): More simplification.
29987 (Event.Emit): ditto.
29989 Reworked to have less levels of indentation.
29991 2001-11-08 Ravi Pratap <ravi@ximian.com>
29993 * class.cs (Property): Emit attributes.
30003 * enum.cs (Emit): Ditto.
30005 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30008 * class.cs (Field, Event, etc.): Move attribute generation into the
30009 Emit method everywhere.
30011 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30012 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30013 as we had no way of defining nested enums !
30015 * rootcontext.cs : Adjust code accordingly.
30017 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30019 2001-11-07 Ravi Pratap <ravi@ximian.com>
30021 * expression.cs (EvalConstantExpression): Move into ecore.cs
30023 * enum.cs (Enum): Rename some members and make them public and readonly
30024 according to our convention.
30026 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30029 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30031 (Enum::Emit): Write a simple version for now which doesn't try to compute
30032 expressions. I shall modify this to be more robust in just a while.
30034 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30036 (TypeContainer::CloseType): Create the Enum types too.
30038 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30040 * expression.cs (EvalConstantExpression): Get rid of completely.
30042 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30043 user-defined values and other cases.
30045 (IsValidEnumLiteral): Helper function.
30047 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30048 out there in the case we had a literal FieldExpr.
30050 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30052 (Literalize): Revamp a bit to take two arguments.
30054 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30056 2001-11-06 Ravi Pratap <ravi@ximian.com>
30058 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30060 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30062 (Resolve): Use the above to ensure we have proper initializers.
30064 2001-11-05 Ravi Pratap <ravi@ximian.com>
30066 * expression.cs (Expression::EvalConstantExpression): New method to
30067 evaluate constant expressions.
30069 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30071 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30073 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30076 (Binary.ResolveOperator): Handle operator != (object a, object b)
30077 and operator == (object a, object b);
30079 (Binary.DoNumericPromotions): Indicate whether the numeric
30080 promotion was possible.
30082 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30085 Made the ArrayAccess implement interface IAssignMethod instead of
30086 IStackStore as the order in which arguments are passed reflects
30089 * assign.cs: Instead of using expr.ExprClass to select the way of
30090 assinging, probe for the IStackStore/IAssignMethod interfaces.
30092 * typemanager.cs: Load InitializeArray definition.
30094 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30095 static data that can be used to initialize arrays.
30097 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30099 * expression.cs: Handle operator== and operator!= for booleans.
30101 (Conditioal.Reduce): Implement reducer for the ?: operator.
30103 (Conditional.Resolve): Implement dead code elimination.
30105 (Binary.Resolve): Catch string literals and return a new
30106 concatenated string.
30108 (Unary.Reduce): Implement reduction of unary expressions.
30110 * ecore.cs: Split out the expression core handling here.
30112 (Expression.Reduce): New method used to perform constant folding
30113 and CSE. This is needed to support constant-expressions.
30115 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30116 targets, and optimize for !x.
30118 2001-11-04 Ravi Pratap <ravi@ximian.com>
30120 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30121 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30122 set custom atttributes.
30124 * literal.cs (Literal::GetValue): New abstract method to return the actual
30125 value of the literal, cast as an object.
30127 (*Literal): Implement GetValue method.
30129 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30130 expressions to the arraylist but objects of type Argument.
30132 * class.cs (TypeContainer::Emit): Emit our attributes too.
30134 (Method::Emit, Constructor::Emit): Ditto.
30136 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30137 to be ignoring earlier.
30139 2001-11-03 Ravi Pratap <ravi@ximian.com>
30141 * attribute.cs (AttributeSection::Define): Implement to do the business
30142 of constructing a CustomAttributeBuilder.
30144 (Attribute): New trivial class. Increases readability of code.
30146 * cs-parser.jay : Update accordingly.
30148 (positional_argument_list, named_argument_list, named_argument): New rules
30150 (attribute_arguments): Use the above so that we are more correct.
30152 2001-11-02 Ravi Pratap <ravi@ximian.com>
30154 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30155 to perform all checks for a method with a params parameter.
30157 (Invocation::OverloadResolve): Update to use the above method and therefore
30158 cope correctly with params method invocations.
30160 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30163 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30164 constructors in our parent too because we can't afford to miss out on
30167 * attribute.cs (AttributeSection): New name for the class Attribute
30169 Other trivial changes to improve readability.
30171 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30172 use the new class names.
30174 2001-11-01 Ravi Pratap <ravi@ximian.com>
30176 * class.cs (Method::Define): Complete definition for params types too
30178 (Indexer::Define): Ditto.
30180 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30181 Cope everywhere with a request for info about the array parameter.
30183 2001-11-01 Ravi Pratap <ravi@ximian.com>
30185 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30187 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30188 local_variable_type to extract the string corresponding to the type.
30190 (local_variable_type): Fixup the action to use the new helper method.
30192 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30195 * expression.cs : Clean out code which uses the above.
30197 2001-10-31 Ravi Pratap <ravi@ximian.com>
30199 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30200 and bale out if necessary by returning a false.
30202 (RegisterProperty): Ditto.
30204 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30205 and print out appropriate error messages.
30207 * interface.cs (everywhere): Ditto.
30209 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30210 location to constructor.
30212 * class.cs (Property, Event, Indexer): Update accordingly.
30214 * ../errors/cs111.cs : Added.
30216 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30217 of a method, as laid down by the spec.
30219 (Invocation::OverloadResolve): Use the above method.
30221 2001-10-31 Ravi Pratap <ravi@ximian.com>
30223 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30224 now take a TypeContainer and a Parameters object.
30226 (ParameterData): Modify return type of ParameterModifier method to be
30227 Parameter.Modifier and not a string.
30229 (ReflectionParameters, InternalParameters): Update accordingly.
30231 * expression.cs (Argument::GetParameterModifier): Same here.
30233 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30234 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30235 symbol in it at all so maybe this is only for now.
30237 2001-10-30 Ravi Pratap <ravi@ximian.com>
30239 * support.cs (InternalParameters): Constructor now takes an extra argument
30240 which is the actual Parameters class.
30242 (ParameterDesc): Update to provide info on ref/out modifiers.
30244 * class.cs (everywhere): Update call to InternalParameters to pass in
30245 the second argument too.
30247 * support.cs (ParameterData): Add ParameterModifier, which is a method
30248 to return the modifier info [ref/out etc]
30250 (InternalParameters, ReflectionParameters): Implement the above.
30252 * expression.cs (Argument::ParameterModifier): Similar function to return
30253 info about the argument's modifiers.
30255 (Invocation::OverloadResolve): Update to take into account matching modifiers
30258 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30259 a new SetFormalParameters object which we pass to InternalParameters.
30261 2001-10-30 Ravi Pratap <ravi@ximian.com>
30263 * expression.cs (NewArray): Merge into the ArrayCreation class.
30265 2001-10-29 Ravi Pratap <ravi@ximian.com>
30267 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30268 NewUserdefinedArray into one as there wasn't much of a use in having
30271 * expression.cs (Argument): Change field's name to ArgType from Type.
30273 (Type): New readonly property which returns the proper type, taking into
30274 account ref/out modifiers.
30276 (everywhere): Adjust code accordingly for the above.
30278 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30279 whether we are emitting for a ref or out parameter.
30281 * expression.cs (Argument::Emit): Use the above field to set the state.
30283 (LocalVariableReference::Emit): Update to honour the flag and emit the
30286 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30288 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30290 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30292 (ReflectionParameters, InternalParameters): Implement the above method.
30294 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30297 (Invocation::FullMethodDesc): Ditto.
30299 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30301 * cs-parser.jay: Add extra production for the second form of array
30304 * expression.cs (ArrayCreation): Update to reflect the above
30307 * Small changes to prepare for Array initialization.
30309 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30311 * typemanager.cs (ImplementsInterface): interface might be null;
30312 Deal with this problem;
30314 Also, we do store negative hits on the cache (null values), so use
30315 this instead of calling t.GetInterfaces on the type everytime.
30317 2001-10-28 Ravi Pratap <ravi@ximian.com>
30319 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30321 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30322 split functionality out into different classes.
30324 (New::FormArrayType): Move into NewBuiltinArray.
30326 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30329 (NewBuiltinArray): New class to handle creation of built-in arrays.
30331 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30332 account creation of one-dimensional arrays.
30334 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30336 (NewUserdefinedArray::DoResolve): Implement.
30338 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30340 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30341 we maintain inside the TypeManager. This is necessary to perform lookups on the
30344 (LookupType): Update to perform GetType on the module builders too.
30346 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30348 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30350 2001-10-23 Ravi Pratap <ravi@ximian.com>
30352 * expression.cs (New::DoResolve): Implement guts of array creation.
30354 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30356 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30358 * expression.cs: Fix bug I introduced lsat night that broke
30361 (Expression.Resolve): Report a 246 error (can not resolve name)
30362 if we find a SimpleName in the stream.
30364 (Expression.ResolveLValue): Ditto.
30366 (Expression.ResolveWithSimpleName): This function is a variant of
30367 ResolveName, this one allows SimpleNames to be returned without a
30368 warning. The only consumer of SimpleNames is MemberAccess
30370 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30372 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30373 might arrive here. I have my doubts that this is correct.
30375 * statement.cs (Lock): Implement lock statement.
30377 * cs-parser.jay: Small fixes to support `lock' and `using'
30379 * cs-tokenizer.cs: Remove extra space
30381 * driver.cs: New flag --checked, allows to turn on integer math
30384 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30385 Threading.Monitor.Exit
30387 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30389 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30390 Expression Class to be IndexerAccess.
30392 Notice that Indexer::DoResolve sets the eclass to Value.
30394 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30396 * class.cs (TypeContainer::Emit): Emit code for indexers.
30398 * assign.cs (IAssignMethod): New interface implemented by Indexers
30399 and Properties for handling assignment.
30401 (Assign::Emit): Simplify and reuse code.
30403 * expression.cs (IndexerAccess, PropertyExpr): Implement
30404 IAssignMethod, clean up old code.
30406 2001-10-22 Ravi Pratap <ravi@ximian.com>
30408 * typemanager.cs (ImplementsInterface): New method to determine if a type
30409 implements a given interface. Provides a nice cache too.
30411 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30414 (ConvertReferenceExplicit): Ditto.
30416 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30417 various methods, with correct names etc.
30419 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30420 Operator.UnaryNegation.
30422 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30423 we have a unary plus or minus operator.
30425 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30428 * everywhere : update accordingly.
30430 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30433 * class.cs (Method::Define): For the case where we are implementing a method
30434 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30435 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30437 2001-10-21 Ravi Pratap <ravi@ximian.com>
30439 * interface.cs (FindMembers): Implement to work around S.R.E
30442 * typemanager.cs (IsInterfaceType): Implement.
30444 (FindMembers): Update to handle interface types too.
30446 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30447 use IsAssignableFrom as that is not correct - it doesn't work.
30449 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30450 and accordingly override EmitStatement.
30452 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30453 using the correct logic :-)
30455 2001-10-19 Ravi Pratap <ravi@ximian.com>
30457 * ../errors/cs-11.cs : Add to demonstrate error -11
30459 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30461 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30462 then pass this as a hint to ResolveLValue.
30464 * expression.cs (FieldExpr): Add Location information
30466 (FieldExpr::LValueResolve): Report assignment to readonly
30469 (Expression::ExprClassFromMemberInfo): Pass location information.
30471 (Expression::ResolveLValue): Add new method that resolves an
30474 (Expression::DoResolveLValue): Default invocation calls
30477 (Indexers): New class used to keep track of indexers in a given
30480 (IStackStore): Renamed from LValue, as it did not really describe
30481 what this did. Also ResolveLValue is gone from this interface and
30482 now is part of Expression.
30484 (ElementAccess): Depending on the element access type
30486 * typemanager.cs: Add `indexer_name_type' as a Core type
30487 (System.Runtime.CompilerServices.IndexerNameAttribute)
30489 * statement.cs (Goto): Take a location.
30491 2001-10-18 Ravi Pratap <ravi@ximian.com>
30493 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30494 if two delegates are compatible.
30496 (NewDelegate::DoResolve): Update to take care of the case when
30497 we instantiate a delegate from another delegate.
30499 * typemanager.cs (FindMembers): Don't even try to look up members
30500 of Delegate types for now.
30502 2001-10-18 Ravi Pratap <ravi@ximian.com>
30504 * delegate.cs (NewDelegate): New class to take care of delegate
30507 * expression.cs (New): Split the delegate related code out into
30508 the NewDelegate class.
30510 * delegate.cs (DelegateInvocation): New class to handle delegate
30513 * expression.cs (Invocation): Split out delegate related code into
30514 the DelegateInvocation class.
30516 2001-10-17 Ravi Pratap <ravi@ximian.com>
30518 * expression.cs (New::DoResolve): Implement delegate creation fully
30519 and according to the spec.
30521 (New::DoEmit): Update to handle delegates differently.
30523 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30524 because of which we were printing out arguments in reverse order !
30526 * delegate.cs (VerifyMethod): Implement to check if the given method
30527 matches the delegate.
30529 (FullDelegateDesc): Implement.
30531 (VerifyApplicability): Implement.
30533 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30534 delegate invocations too.
30536 (Invocation::Emit): Ditto.
30538 * ../errors/cs1593.cs : Added.
30540 * ../errors/cs1594.cs : Added.
30542 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30544 2001-10-16 Ravi Pratap <ravi@ximian.com>
30546 * typemanager.cs (intptr_type): Core type for System.IntPtr
30548 (InitCoreTypes): Update for the same.
30550 (iasyncresult_type, asynccallback_type): Ditto.
30552 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30555 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30558 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30559 the builders for the 4 members of a delegate type :-)
30561 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30564 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30566 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30568 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30570 * statement.cs (Break::Emit): Implement.
30571 (Continue::Emit): Implement.
30573 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30574 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30575 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30576 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30579 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30580 properties that track the label for the current loop (begin of the
30581 loop and end of the loop).
30583 2001-10-15 Ravi Pratap <ravi@ximian.com>
30585 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30586 use of emitting anything at all.
30588 * class.cs, rootcontext.cs : Get rid of calls to the same.
30590 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30592 (Populate): Define the constructor correctly and set the implementation
30595 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30598 (AddDelegateType): Implement.
30600 (IsDelegateType): Implement helper method.
30602 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
30604 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
30605 and accordingly handle it.
30607 * delegate.cs (Populate): Take TypeContainer argument.
30608 Implement bits to define the Invoke method. However, I still haven't figured out
30609 how to take care of the native int bit :-(
30611 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
30612 Qualify the name of the delegate, not its return type !
30614 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
30617 (StandardConversionExists): Checking for array types turns out to be recursive.
30619 (ConvertReferenceExplicit): Implement array conversion.
30621 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
30623 2001-10-12 Ravi Pratap <ravi@ximian.com>
30625 * cs-parser.jay (delegate_declaration): Store the fully qualified
30626 name as it is a type declaration.
30628 * delegate.cs (ReturnType, Name): Rename members to these. Make them
30631 (DefineDelegate): Renamed from Define. Does the same thing essentially,
30632 as TypeContainer::DefineType.
30634 (Populate): Method in which all the definition of the various methods (Invoke)
30637 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
30640 (CloseDelegate): Finally creates the delegate.
30642 * class.cs (TypeContainer::DefineType): Update to define delegates.
30643 (Populate, Emit and CloseType): Do the same thing here too.
30645 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
30646 delegates in all these operations.
30648 2001-10-14 Miguel de Icaza <miguel@ximian.com>
30650 * expression.cs: LocalTemporary: a new expression used to
30651 reference a temporary that has been created.
30653 * assign.cs: Handle PropertyAccess back here, so that we can
30654 provide the proper semantic access to properties.
30656 * expression.cs (Expression::ConvertReferenceExplicit): Implement
30657 a few more explicit conversions.
30659 * modifiers.cs: `NEW' modifier maps to HideBySig.
30661 * expression.cs (PropertyExpr): Make this into an
30662 ExpressionStatement, and support the EmitStatement code path.
30664 Perform get/set error checking, clean up the interface.
30666 * assign.cs: recognize PropertyExprs as targets, and if so, turn
30667 them into toplevel access objects.
30669 2001-10-12 Miguel de Icaza <miguel@ximian.com>
30671 * expression.cs: PropertyExpr::PropertyExpr: use work around the
30674 * typemanager.cs: Keep track here of our PropertyBuilders again to
30675 work around lameness in SRE.
30677 2001-10-11 Miguel de Icaza <miguel@ximian.com>
30679 * expression.cs (LValue::LValueResolve): New method in the
30680 interface, used to perform a second resolution pass for LValues.
30682 (This::DoResolve): Catch the use of this in static methods.
30684 (This::LValueResolve): Implement.
30686 (This::Store): Remove warning, assigning to `this' in structures
30689 (Invocation::Emit): Deal with invocation of
30690 methods on value types. We need to pass the address to structure
30691 methods rather than the object itself. (The equivalent code to
30692 emit "this" for structures leaves the entire structure on the
30693 stack instead of a pointer to it).
30695 (ParameterReference::DoResolve): Compute the real index for the
30696 argument based on whether the method takes or not a `this' pointer
30697 (ie, the method is static).
30699 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
30700 value types returned from functions when we need to invoke a
30701 method on the sturcture.
30704 2001-10-11 Ravi Pratap <ravi@ximian.com>
30706 * class.cs (TypeContainer::DefineType): Method to actually do the business of
30707 defining the type in the Modulebuilder or Typebuilder. This is to take
30708 care of nested types which need to be defined on the TypeBuilder using
30709 DefineNestedMethod.
30711 (TypeContainer::GetClassBases): Implement. Essentially the code from the
30712 methods in RootContext, only ported to be part of TypeContainer.
30714 (TypeContainer::GetInterfaceOrClass): Ditto.
30716 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
30718 * interface.cs (Interface::DefineInterface): New method. Does exactly
30719 what RootContext.CreateInterface did earlier, only it takes care of nested types
30722 (Interface::GetInterfaces): Move from RootContext here and port.
30724 (Interface::GetInterfaceByName): Same here.
30726 * rootcontext.cs (ResolveTree): Re-write.
30728 (PopulateTypes): Re-write.
30730 * class.cs (TypeContainer::Populate): Populate nested types too.
30731 (TypeContainer::Emit): Emit nested members too.
30733 * typemanager.cs (AddUserType): Do not make use of the FullName property,
30734 instead just use the name argument passed in as it is already fully
30737 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
30738 to TypeContainer mapping to see if a type is user-defined.
30740 * class.cs (TypeContainer::CloseType): Implement.
30742 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
30743 the default constructor.
30745 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
30748 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
30750 * interface.cs (CloseType): Create the type here.
30752 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
30755 Remove all the methods which are now in TypeContainer.
30757 2001-10-10 Ravi Pratap <ravi@ximian.com>
30759 * delegate.cs (Define): Re-write bits to define the delegate
30762 2001-10-10 Miguel de Icaza <miguel@ximian.com>
30764 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
30766 * expression.cs (ImplicitReferenceConversion): handle null as well
30767 as a source to convert to any reference type.
30769 * statement.cs (Return): Perform any implicit conversions to
30770 expected return type.
30772 Validate use of return statement.
30774 * codegen.cs (EmitContext): Pass the expected return type here.
30776 * class.cs (Method, Constructor, Property): Pass expected return
30777 type to EmitContext.
30779 2001-10-09 Miguel de Icaza <miguel@ximian.com>
30781 * expression.cs: Make DoResolve take an EmitContext instead of a
30784 Replaced `l' and `location' for `loc', for consistency.
30786 (Error, Warning): Remove unneeded Tc argument.
30788 * assign.cs, literal.cs, constant.cs: Update to new calling
30791 * codegen.cs: EmitContext now contains a flag indicating whether
30792 code is being generated in a static method or not.
30794 * cs-parser.jay: DecomposeQI, new function that replaces the old
30795 QualifiedIdentifier. Now we always decompose the assembled
30796 strings from qualified_identifier productions into a group of
30799 2001-10-08 Miguel de Icaza <miguel@ximian.com>
30801 * rootcontext.cs: Deal with field-less struct types correctly now
30802 by passing the size option to Define Type.
30804 * class.cs: Removed hack that created one static field.
30806 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30808 * statement.cs: Moved most of the code generation here.
30810 2001-10-09 Ravi Pratap <ravi@ximian.com>
30812 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
30815 (ElementAccess): Remove useless bits for now - keep checks as the spec
30818 2001-10-08 Ravi Pratap <ravi@ximian.com>
30820 * expression.cs (ElementAccess::DoResolve): Remove my crap code
30821 and start performing checks according to the spec.
30823 2001-10-07 Ravi Pratap <ravi@ximian.com>
30825 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
30826 rank_specifiers instead.
30828 (rank_specifiers): Change the order in which the rank specifiers are stored
30830 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
30832 * expression.cs (ElementAccess): Implement the LValue interface too.
30834 2001-10-06 Ravi Pratap <ravi@ximian.com>
30836 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
30837 except that user defined conversions are not included.
30839 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
30840 perform the conversion of the return type, if necessary.
30842 (New::DoResolve): Check whether we are creating an array or an object
30843 and accordingly do the needful.
30845 (New::Emit): Same here.
30847 (New::DoResolve): Implement guts of array creation.
30849 (New::FormLookupType): Helper function.
30851 2001-10-07 Miguel de Icaza <miguel@ximian.com>
30853 * codegen.cs: Removed most of the code generation here, and move the
30854 corresponding code generation bits to the statement classes.
30856 Added support for try/catch/finalize and throw.
30858 * cs-parser.jay: Added support for try/catch/finalize.
30860 * class.cs: Catch static methods having the flags override,
30861 virtual or abstract.
30863 * expression.cs (UserCast): This user cast was not really doing
30864 what it was supposed to do. Which is to be born in fully resolved
30865 state. Parts of the resolution were being performed at Emit time!
30869 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30871 * expression.cs: Implicity convert the result from UserCast.
30873 2001-10-05 Ravi Pratap <ravi@ximian.com>
30875 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
30876 prevented it from working correctly.
30878 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
30879 merely ConvertImplicit.
30881 2001-10-05 Miguel de Icaza <miguel@ximian.com>
30883 * typemanager.cs: Make the LookupTypeContainer function static,
30884 and not per-instance.
30886 * class.cs: Make static FindMembers (the one that takes a Type
30889 * codegen.cs: Add EmitForeach here.
30891 * cs-parser.jay: Make foreach a toplevel object instead of the
30892 inline expansion, as we need to perform semantic analysis on it.
30894 2001-10-05 Ravi Pratap <ravi@ximian.com>
30896 * expression.cs (Expression::ImplicitUserConversion): Rename to
30897 UserDefinedConversion.
30899 (Expression::UserDefinedConversion): Take an extra argument specifying
30900 whether we look for explicit user conversions too.
30902 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
30904 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
30906 (ExplicitUserConversion): Make it a call to UserDefinedConversion
30907 with the appropriate arguments.
30909 * cs-parser.jay (cast_expression): Record location too.
30911 * expression.cs (Cast): Record location info.
30913 (Expression::ConvertExplicit): Take location argument.
30915 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
30916 to determine if we are doing explicit conversions.
30918 (UserCast::Emit): Update accordingly.
30920 (Expression::ConvertExplicit): Report an error if everything fails.
30922 * ../errors/cs0030.cs : Add.
30924 2001-10-04 Miguel de Icaza <miguel@ximian.com>
30926 * modifiers.cs: If the ABSTRACT keyword is present, also set the
30927 virtual and newslot bits.
30929 * class.cs (TypeContainer::RegisterRequiredImplementations):
30930 Record methods we need.
30932 (TypeContainer::MakeKey): Helper function to make keys for
30933 MethodBases, since the Methodbase key is useless.
30935 (TypeContainer::Populate): Call RegisterRequiredImplementations
30936 before defining the methods.
30938 Create a mapping for method_builders_to_methods ahead of time
30939 instead of inside a tight loop.
30941 (::RequireMethods): Accept an object as the data to set into the
30942 hashtable so we can report interface vs abstract method mismatch.
30944 2001-10-03 Miguel de Icaza <miguel@ximian.com>
30946 * report.cs: Make all of it static.
30948 * rootcontext.cs: Drop object_type and value_type computations, as
30949 we have those in the TypeManager anyways.
30951 Drop report instance variable too, now it is a global.
30953 * driver.cs: Use try/catch on command line handling.
30955 Add --probe option to debug the error reporting system with a test
30958 * report.cs: Add support for exiting program when a probe
30959 condition is reached.
30961 2001-10-03 Ravi Pratap <ravi@ximian.com>
30963 * expression.cs (Binary::DoNumericPromotions): Fix the case when
30964 we do a forcible conversion regardless of type, to check if
30965 ForceConversion returns a null.
30967 (Binary::error19): Use location to report error.
30969 (Unary::error23): Use location here too.
30971 * ../errors/cs0019.cs : Check in.
30973 * ../errors/cs0023.cs : Check in.
30975 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
30976 case of a non-null MethodInfo object with a length of 0 !
30978 (Binary::ResolveOperator): Flag error if overload resolution fails to find
30979 an applicable member - according to the spec :-)
30980 Also fix logic to find members in base types.
30982 (Unary::ResolveOperator): Same here.
30984 (Unary::report23): Change name to error23 and make first argument a TypeContainer
30985 as I was getting thoroughly confused between this and error19 :-)
30987 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
30988 (::FindMostEncompassedType): Implement.
30989 (::FindMostEncompassingType): Implement.
30990 (::StandardConversionExists): Implement.
30992 (UserImplicitCast): Re-vamp. We now need info about most specific
30993 source and target types so that we can do the necessary conversions.
30995 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
30996 mathematical union with no duplicates.
30998 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31000 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31001 in order from base classes to child classes, so that we can in
31002 child classes look up in our parent for method names and
31003 attributes (required for handling abstract, virtual, new, override
31004 constructs: we need to instrospect our base class, and if we dont
31005 populate the classes in order, the introspection might be
31006 incorrect. For example, a method could query its parent before
31007 the parent has any methods and would determine that the parent has
31008 no abstract methods (while it could have had them)).
31010 (RootContext::CreateType): Record the order in which we define the
31013 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31015 * class.cs (TypeContainer::Populate): Also method definitions can
31016 fail now, keep track of this.
31018 (TypeContainer::FindMembers): Implement support for
31019 DeclaredOnly/noDeclaredOnly flag.
31021 (Constructor::Emit) Return the ConstructorBuilder.
31023 (Method::Emit) Return the MethodBuilder.
31024 Check for abstract or virtual methods to be public.
31026 * rootcontext.cs (RootContext::CreateType): Register all the
31027 abstract methods required for the class to be complete and the
31028 interface methods that must be implemented.
31030 * cs-parser.jay: Report error 501 (method requires body if it is
31031 not marked abstract or extern).
31033 * expression.cs (TypeOf::Emit): Implement.
31035 * typemanager.cs: runtime_handle_type, new global type.
31037 * class.cs (Property::Emit): Generate code for properties.
31039 2001-10-02 Ravi Pratap <ravi@ximian.com>
31041 * expression.cs (Unary::ResolveOperator): Find operators on base type
31042 too - we now conform exactly to the spec.
31044 (Binary::ResolveOperator): Same here.
31046 * class.cs (Operator::Define): Fix minor quirk in the tests.
31048 * ../errors/cs0215.cs : Added.
31050 * ../errors/cs0556.cs : Added.
31052 * ../errors/cs0555.cs : Added.
31054 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31056 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31057 single integer which is really efficient
31059 2001-10-01 Ravi Pratap <ravi@ximian.com>
31061 * expression.cs (Expression::ImplicitUserConversion): Use location
31062 even in the case when we are examining True operators.
31064 * class.cs (Operator::Define): Perform extensive checks to conform
31065 with the rules for operator overloading in the spec.
31067 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31068 some of the other conversions mentioned in the spec.
31070 * typemanager.cs (array_type): New static member for the System.Array built-in
31073 (cloneable_interface): For System.ICloneable interface.
31075 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31076 we start resolving the tree and populating types.
31078 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31080 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31082 * expression.cs (Expression::ExprClassFromMemberInfo,
31083 Expression::Literalize): Create literal expressions from
31084 FieldInfos which are literals.
31086 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31087 type casts, because they were wrong. The test suite in tests
31090 (ImplicitNumericConversion): ushort to ulong requires a widening
31093 Int32 constant to long requires widening cast as well.
31095 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31096 for integers because the type on the stack is not i4.
31098 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31100 * expression.cs (report118): require location argument.
31102 * parameter.cs: Do not dereference potential null value.
31104 * class.cs: Catch methods that lack the `new' keyword when
31105 overriding a name. Report warnings when `new' is used without
31106 anything being there to override.
31108 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31110 * class.cs: Only add constructor to hashtable if it is non-null
31111 (as now constructors can fail on define).
31113 (TypeManager, Class, Struct): Take location arguments.
31115 Catch field instance initialization in structs as errors.
31117 accepting_filter: a new filter for FindMembers that is static so
31118 that we dont create an instance per invocation.
31120 (Constructor::Define): Catch errors where a struct constructor is
31123 * cs-parser.jay: Pass location information for various new
31126 * delegate.cs (Delegate): take a location argument.
31128 * driver.cs: Do not call EmitCode if there were problesm in the
31129 Definition of the types, as many Builders wont be there.
31131 * decl.cs (Decl::Decl): Require a location argument.
31133 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31134 into integers, and find the most appropiate integer for it.
31136 * literal.cs: Implement ULongLiteral.
31138 * rootcontext.cs: Provide better information about the location of
31139 failure when CreateType fails.
31141 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31143 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31146 * expression.cs (Binary::CheckShiftArguments): Add missing type
31148 (Binary::ResolveOperator): Add type to the logical and and logical
31149 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31152 (Binary::DoNumericPromotions): In the case where either argument
31153 is ulong (and most signed types combined with ulong cause an
31154 error) perform implicit integer constant conversions as well.
31156 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31158 * expression.cs (UserImplicitCast): Method should always be
31160 (Invocation::BetterConversion): Simplified test for IntLiteral.
31162 (Expression::ImplicitNumericConversion): Split this routine out.
31163 Put the code that performs implicit constant integer conversions
31166 (Expression::Resolve): Become a wrapper around DoResolve so we can
31167 check eclass and type being set after resolve.
31169 (Invocation::Badness): Remove this dead function
31171 (Binary::ResolveOperator): Do not compute the expensive argumnets
31172 unless we have a union for it.
31174 (Probe::Emit): Is needs to do an isinst and then
31175 compare against null.
31177 (::CanConvert): Added Location argument. If the Location argument
31178 is null (Location.Null), then we do not report errors. This is
31179 used by the `probe' mechanism of the Explicit conversion. We do
31180 not want to generate an error for something that the user
31181 explicitly requested to be casted. But the pipeline for an
31182 explicit cast first tests for potential implicit casts.
31184 So for now, if the Location is null, it means `Probe only' to
31185 avoid adding another argument. Might have to revise this
31188 (ClassCast): New class used to type cast objects into arbitrary
31189 classes (used in Explicit Reference Conversions).
31191 Implement `as' as well.
31193 Reverted all the patches from Ravi below: they were broken:
31195 * The use of `level' as a mechanism to stop recursive
31196 invocations is wrong. That was there just to catch the
31197 bug with a strack trace but not as a way of addressing
31200 To fix the problem we have to *understand* what is going
31201 on and the interactions and come up with a plan, not
31202 just get things going.
31204 * The use of the type conversion cache that I proposed
31205 last night had an open topic: How does this work across
31206 protection domains. A user defined conversion might not
31207 be public in the location where we are applying the
31208 conversion, a different conversion might be selected
31209 (ie, private A->B (better) but public B->A (worse),
31210 inside A, A->B applies, but outside it, B->A will
31213 * On top of that (ie, even if the above is solved),
31214 conversions in a cache need to be abstract. Ie, `To
31215 convert from an Int to a Short use an OpcodeCast', not
31216 `To convert from an Int to a Short use the OpcodeCast on
31217 the variable 5' (which is what this patch was doing).
31219 2001-09-28 Ravi Pratap <ravi@ximian.com>
31221 * expression.cs (Invocation::ConversionExists): Re-write to use
31222 the conversion cache
31224 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31225 cache all conversions done, not just user-defined ones.
31227 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31228 to determine if a conversion exists instead of acutually trying to
31229 perform the conversion. It's faster too.
31231 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31232 and only then attempt the implicit conversion.
31234 2001-09-28 Ravi Pratap <ravi@ximian.com>
31236 * expression.cs (ConvertImplicit): Use a cache for conversions
31237 already found. Check level of recursion and bail out if necessary.
31239 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31241 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31242 Export standard methods that we expect for string operations.
31244 * statement.cs (Block::UsageWarning): Track usage of variables and
31245 report the errors for not used variables.
31247 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31250 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31252 * codegen.cs: remove unnneded code
31254 * expression.cs: Removed BuiltinTypeAccess class
31256 Fix the order in which implicit conversions are
31259 The previous fixed dropped support for boxed conversions (adding a
31260 test to the test suite now)
31262 (UserImplicitCast::CanConvert): Remove test for source being null,
31263 that code is broken. We should not feed a null to begin with, if
31264 we do, then we should track the bug where the problem originates
31265 and not try to cover it up here.
31267 Return a resolved expression of type UserImplicitCast on success
31268 rather than true/false. Ravi: this is what I was talking about,
31269 the pattern is to use a static method as a "constructor" for
31272 Also, do not create arguments until the very last minute,
31273 otherwise we always create the arguments even for lookups that
31274 will never be performed.
31276 (UserImplicitCast::Resolve): Eliminate, objects of type
31277 UserImplicitCast are born in a fully resolved state.
31279 * typemanager.cs (InitCoreTypes): Init also value_type
31280 (System.ValueType).
31282 * expression.cs (Cast::Resolve): First resolve the child expression.
31284 (LValue): Add new method AddressOf to be used by
31287 Change the argument of Store to take an EmitContext instead of an
31288 ILGenerator, because things like FieldExpr need to be able to call
31289 their children expression to generate the instance code.
31291 (Expression::Error, Expression::Warning): Sugar functions for
31294 (Expression::MemberLookup): Accept a TypeContainer instead of a
31295 Report as the first argument.
31297 (Expression::ResolvePrimary): Killed. I still want to improve
31298 this as currently the code is just not right.
31300 (Expression::ResolveMemberAccess): Simplify, but it is still
31303 (Unary::Resolve): Catch errors in AddressOf operators.
31305 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31306 index to a byte for the short-version, or the compiler will choose
31307 the wrong Emit call, which generates the wrong data.
31309 (ParameterReference::Emit, ::Store): same.
31311 (FieldExpr::AddressOf): Implement.
31313 * typemanager.cs: TypeManager: made public variable instead of
31316 * driver.cs: document --fatal.
31318 * report.cs (ErrorMessage, WarningMessage): new names for the old
31319 Error and Warning classes.
31321 * cs-parser.jay (member_access): Turn built-in access to types
31322 into a normal simplename
31324 2001-09-27 Ravi Pratap <ravi@ximian.com>
31326 * expression.cs (Invocation::BetterConversion): Fix to cope
31327 with q being null, since this was introducing a bug.
31329 * expression.cs (ConvertImplicit): Do built-in conversions first.
31331 2001-09-27 Ravi Pratap <ravi@ximian.com>
31333 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31335 2001-09-27 Ravi Pratap <ravi@ximian.com>
31337 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31338 I had introduced long ago (what's new ?).
31340 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31341 the work of all the checking.
31342 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31343 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31345 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31346 that is the right way.
31348 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31349 overloading resolution. Use everywhere instead of cutting and pasting code.
31351 (Binary::ResolveOperator): Use MakeUnionSet.
31353 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31354 we have to convert to bool types. Not complete yet.
31356 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31358 * typemanager.cs (TypeManager::CSharpName): support ushort.
31360 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31361 to provide an expression that performsn an implicit constant int
31362 conversion (section 6.1.6).
31363 (Expression::ConvertImplicitRequired): Reworked to include
31364 implicit constant expression conversions.
31366 (Expression::ConvertNumericExplicit): Finished.
31368 (Invocation::Emit): If InstanceExpression is null, then it means
31369 that we perform a call on this.
31371 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31373 * expression.cs (Unary::Emit): Remove some dead code.
31374 (Probe): Implement Resolve and Emit for `is'.
31375 (Expression::ConvertImplicitRequired): Attempt to do constant
31376 expression conversions here. Maybe should be moved to
31377 ConvertImplicit, but I am not sure.
31378 (Expression::ImplicitLongConstantConversionPossible,
31379 Expression::ImplicitIntConstantConversionPossible): New functions
31380 that tell whether is it possible to apply an implicit constant
31381 expression conversion.
31383 (ConvertNumericExplicit): Started work on explicit numeric
31386 * cs-parser.jay: Update operator constants.
31388 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31389 (Parameters::GetSignature): Hook up VerifyArgs here.
31390 (Parameters::VerifyArgs): Verifies that no two arguments have the
31393 * class.cs (Operator): Update the operator names to reflect the
31394 ones that the spec expects (as we are just stringizing the
31397 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31398 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31399 previous usage did only work for our methods.
31400 (Expression::ConvertImplicit): Handle decimal implicit numeric
31401 conversions as well.
31402 (Expression::InternalTypeConstructor): Used to invoke constructors
31403 on internal types for default promotions.
31405 (Unary::Emit): Implement special handling for the pre/post
31406 increment/decrement for overloaded operators, as they need to have
31407 the same semantics as the other operators.
31409 (Binary::ResolveOperator): ditto.
31410 (Invocation::ConversionExists): ditto.
31411 (UserImplicitCast::Resolve): ditto.
31413 2001-09-26 Ravi Pratap <ravi@ximian.com>
31415 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31416 operator, return after emitting body. Regression tests pass again !
31418 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31419 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31420 (Invocation::OverloadResolve): Ditto.
31421 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31423 * everywhere : update calls to the above methods accordingly.
31425 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31427 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31429 * expression.cs (ExpressionStatement): New base class used for
31430 expressions that can appear in statements, so that we can provide
31431 an alternate path to generate expression that do not leave a value
31434 (Expression::Emit, and all the derivatives): We no longer return
31435 whether a value is left on the stack or not. Every expression
31436 after being emitted leaves a single value on the stack.
31438 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31439 facilties of ExpressionStatement if possible.
31441 * cs-parser.jay: Update statement_expression.
31443 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31445 * driver.cs: Change the wording of message
31447 2001-09-25 Ravi Pratap <ravi@ximian.com>
31449 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31450 the type of the expression to the return type of the method if
31451 we have an overloaded operator match ! The regression tests pass again !
31452 (Unary::ResolveOperator): Ditto.
31454 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31455 to find "op_Implicit", not "implicit" ;-)
31456 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31457 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31459 * everywhere : Correct calls to the above accordingly.
31461 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31462 (ConvertImplicit): Do user-defined conversion if it exists.
31464 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31466 * assign.cs: track location.
31467 (Resolve): Use implicit conversions on assignment.
31469 * literal.cs: Oops. Not good, Emit of short access values should
31470 pass (Bytes) or the wrong argument will be selected.
31472 * expression.cs (Unary::Emit): Emit code for -expr.
31474 (Unary::ResolveOperator): Handle `Substract' for non-constants
31475 (substract from zero from the non-constants).
31476 Deal with Doubles as well.
31478 (Expression::ConvertImplicitRequired): New routine that reports an
31479 error if no implicit conversion exists.
31481 (Invocation::OverloadResolve): Store the converted implicit
31482 expressions if we make them
31484 2001-09-24 Ravi Pratap <ravi@ximian.com>
31486 * class.cs (ConstructorInitializer): Take a Location argument.
31487 (ConstructorBaseInitializer): Same here.
31488 (ConstructorThisInitializer): Same here.
31490 * cs-parser.jay : Update all calls accordingly.
31492 * expression.cs (Unary, Binary, New): Take location argument.
31493 Update accordingly everywhere.
31495 * cs-parser.jay : Update all calls to the above to take a location
31498 * class.cs : Ditto.
31500 2001-09-24 Ravi Pratap <ravi@ximian.com>
31502 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31503 (Invocation::BetterConversion): Same here
31504 (Invocation::ConversionExists): Ditto.
31506 (Invocation::ConversionExists): Implement.
31508 2001-09-22 Ravi Pratap <ravi@ximian.com>
31510 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31511 Also take an additional TypeContainer argument.
31513 * All over : Pass in TypeContainer as argument to OverloadResolve.
31515 * typemanager.cs (CSharpName): Update to check for the string type and return
31518 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31521 2001-09-21 Ravi Pratap <ravi@ximian.com>
31523 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31524 (Invocation::BetterFunction): Implement.
31525 (Invocation::BetterConversion): Implement.
31526 (Invocation::ConversionExists): Skeleton, no implementation yet.
31528 Okay, things work fine !
31530 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31532 * typemanager.cs: declare and load enum_type, delegate_type and
31535 * expression.cs (Expression::Emit): Now emit returns a value that
31536 tells whether a value is left on the stack or not. This strategy
31537 might be reveted tomorrow with a mechanism that would address
31538 multiple assignments.
31539 (Expression::report118): Utility routine to report mismatches on
31542 (Unary::Report23): Report impossible type/operator combination
31545 (Unary::IsIncrementableNumber): Whether the type can be
31546 incremented or decremented with add.
31547 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31549 (Unary::ResolveOperator): Implement ++, !, ~,
31551 (Invocation::Emit): Deal with new Emit convetion.
31553 * All Expression derivatives: Updated their Emit method to return
31554 whether they leave values on the stack or not.
31556 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31557 stack for expressions that are statements.
31559 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31561 * expression.cs (LValue): New interface. Must be implemented by
31563 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31566 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31567 interface for generating code, simplifies the code.
31569 2001-09-20 Ravi Pratap <ravi@ximian.com>
31571 * expression.cs (everywhere): Comment out return statements in ::Resolve
31572 methods to avoid the warnings.
31574 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31576 * driver.cs (parse): Report error 2001 if we can not open the
31579 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31582 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31585 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31586 otherwise nested blocks end up with the same index.
31588 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31590 * expression.cs: Instead of having FIXMEs in the Resolve
31591 functions, throw exceptions so it is obvious that we are facing a
31594 * cs-parser.jay (invocation_expression): Pass Location information.
31596 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31597 Use a basename for those routines because .NET does not like paths
31600 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
31603 2001-09-19 Miguel de Icaza <miguel@ximian.com>
31605 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
31606 are loading the correct data types (throws an exception if not).
31607 (TypeManager::InitCoreTypes): Use CoreLookupType
31609 * expression.cs (Unary::ResolveOperator): return the child
31610 expression for expressions which are just +expr.
31611 (Unary::ResolveOperator): Return negative literals for -LITERAL
31612 expressions (otherwise they are Unary {Literal}).
31613 (Invocation::Badness): Take into account `Implicit constant
31614 expression conversions'.
31616 * literal.cs (LongLiteral): Implement long literal class.
31617 (IntLiteral): export the `Value' of the intliteral.
31619 2001-09-19 Ravi Pratap <ravi@ximian.com>
31621 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
31623 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
31624 instead of 'Operator'
31626 * expression.cs (Binary::ResolveOperator): Update accordingly.
31627 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
31630 * cs-parser.jay (unary_expression): Update to use the new names.
31632 * gen-treedump.cs (GetUnary): Same here.
31634 * expression.cs (Unary::Resolve): Implement.
31635 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
31636 operators are found instead of making noise ;-)
31637 (Unary::ResolveOperator): New method to do precisely the same thing which
31638 Binary::ResolveOperator does for Binary expressions.
31639 (Unary.method, .Arguments): Add.
31640 (Unary::OperName): Implement.
31641 (Unary::ForceConversion): Copy and Paste !
31643 * class.cs (Operator::Define): Fix a small bug for the case when we have
31646 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
31647 for the inbuilt operators. Only overloading works for now ;-)
31649 2001-09-18 Miguel de Icaza <miguel@ximian.com>
31651 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
31652 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
31654 * expression.cs (This::Emit): Implement.
31655 (This::Resolve): Implement.
31656 (TypeOf:Resolve): Implement.
31657 (Expression::ResolveSimpleName): Add an implicit this to instance
31659 (MemberAccess::Resolve): Deal with Parameters and Fields.
31660 Bind instance variable to Field expressions.
31661 (FieldExpr::Instance): New field used to track the expression that
31662 represents the object instance.
31663 (FieldExpr::Resolve): Track potential errors from MemberLookup not
31665 (FieldExpr::Emit): Implement.
31667 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
31668 the last instruction contains a return opcode to avoid generating
31669 the last `ret' instruction (this generates correct code, and it is
31670 nice to pass the peverify output).
31672 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
31673 initializer for static and instance variables.
31674 (Constructor::Emit): Allow initializer to be null in the case of
31675 static constructors. Only emit initializer for instance
31678 (TypeContainer::FindMembers): Return a null array if there are no
31681 Also fix the code for the MemberTypes.Method branch, as it was not
31682 scanning that for operators (or tried to access null variables before).
31684 * assign.cs (Assign::Emit): Handle instance and static fields.
31688 * driver.cs: Stop compilation if there are parse errors.
31690 * cs-parser.jay (constructor_declaration): Provide default base
31691 initializer for non-static constructors.
31692 (constructor_declarator): Do not provide a default base
31693 initializers if none was specified.
31694 Catch the fact that constructors should not have parameters.
31696 * class.cs: Do not emit parent class initializers for static
31697 constructors, that should be flagged as an error.
31699 2001-09-18 Ravi Pratap <ravi@ximian.com>
31701 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
31702 Move back code into TypeContainer::Populate.
31704 2001-09-18 Ravi Pratap <ravi@ximian.com>
31706 * class.cs (TypeContainer::AddConstructor): Fix the check to
31707 compare against Name, not Basename.
31708 (Operator::OpType): Change Plus and Minus to Add and Subtract.
31710 * cs-parser.jay : Update accordingly.
31712 * class.cs (TypeContainer::FindMembers): For the case where we are searching
31713 for methods, don't forget to look into the operators too.
31714 (RegisterMethodBuilder): Helper method to take care of this for
31715 methods, constructors and operators.
31716 (Operator::Define): Completely revamp.
31717 (Operator.OperatorMethod, MethodName): New fields.
31718 (TypeContainer::Populate): Move the registering of builders into
31719 RegisterMethodBuilder.
31720 (Operator::Emit): Re-write.
31722 * expression.cs (Binary::Emit): Comment out code path to emit method
31723 invocation stuff for the case when we have a user defined operator. I am
31724 just not able to get it right !
31726 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31728 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
31731 (Expression::MemberLookup): Provide a version that allows to
31732 specify the MemberTypes and BindingFlags.
31734 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
31735 so it was not fetching variable information from outer blocks.
31737 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
31738 Beforefieldinit as it was buggy.
31740 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
31741 that Ravi put here.
31743 * class.cs (Constructor::Emit): Only emit if block is not null.
31744 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
31745 deal with this by semantically definining it as if the user had
31748 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
31749 constructors as we now "emit" them at a higher level.
31751 (TypeContainer::DefineDefaultConstructor): Used to define the
31752 default constructors if none was provided.
31754 (ConstructorInitializer): Add methods Resolve and Emit.
31756 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
31758 2001-09-17 Ravi Pratap <ravi@ximian.com>
31760 * class.cs (TypeContainer::EmitDefaultConstructor): Register
31761 the default constructor builder with our hashtable for methodbuilders
31764 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
31765 and argument_count is 0 in which case we have a match.
31766 (Binary::ResolveOperator): More null checking and miscellaneous coding
31769 2001-09-17 Ravi Pratap <ravi@ximian.com>
31771 * rootcontext.cs (IsNameSpace): Compare against null.
31773 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
31775 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
31776 and Unary::Operator.
31778 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
31781 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
31782 we have overloaded operators.
31783 (Binary::ResolveOperator): Implement the part which does the operator overload
31786 * class.cs (Operator::Emit): Implement.
31787 (TypeContainer::Emit): Emit the operators we have too.
31789 * expression.cs (Binary::Emit): Update to emit the appropriate code for
31790 the case when we have a user-defined operator.
31792 2001-09-17 Miguel de Icaza <miguel@ximian.com>
31794 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
31796 2001-09-16 Ravi Pratap <ravi@ximian.com>
31798 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
31799 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
31800 (Constructor::Emit): Implement.
31801 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
31802 if we have no work to do.
31803 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
31806 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
31807 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
31809 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
31812 2001-09-15 Ravi Pratap <ravi@ximian.com>
31814 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
31816 (Tree::RecordNamespace): Method to do what the name says ;-)
31817 (Tree::Namespaces): Property to get at the namespaces hashtable.
31819 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
31822 * rootcontext.cs (IsNamespace): Fixed it :-)
31824 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31826 * class.cs (TypeContainer::FindMembers): Add support for
31828 (MethodCore): New class that encapsulates both the shared aspects
31829 of a Constructor and a Method.
31830 (Method, Constructor): Factored pieces into MethodCore.
31832 * driver.cs: Added --fatal which makes errors throw exceptions.
31833 Load System assembly as well as part of the standard library.
31835 * report.cs: Allow throwing exceptions on errors for debugging.
31837 * modifiers.cs: Do not use `parent', instead use the real type
31838 container to evaluate permission settings.
31840 * class.cs: Put Ravi's patch back in. He is right, and we will
31841 have to cope with the
31843 2001-09-14 Ravi Pratap <ravi@ximian.com>
31845 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
31846 FamORAssem, not FamANDAssem.
31848 2001-09-14 Miguel de Icaza <miguel@ximian.com>
31850 * driver.cs: Added --parse option that only parses its input files
31853 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
31854 incorrect. IsTopLevel is not used to tell whether an object is
31855 root_types or not (that can be achieved by testing this ==
31856 root_types). But to see if this is a top-level *class* (not
31857 necessarly our "toplevel" container).
31859 2001-09-14 Ravi Pratap <ravi@ximian.com>
31861 * enum.cs (Enum::Define): Modify to call the Lookup method on the
31862 parent instead of a direct call to GetType.
31864 2001-09-14 Ravi Pratap <ravi@ximian.com>
31866 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
31867 Modifiers.TypeAttr. This should just be a call to that method.
31869 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
31870 object so that we can determine if we are top-level or not.
31872 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
31875 * enum.cs (Enum::Define): Ditto.
31877 * modifiers.cs (FieldAttr): Re-write.
31879 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
31880 (TypeContainer::HaveStaticConstructor): New property to provide access
31881 to precisely that info.
31883 * modifiers.cs (MethodAttr): Re-write.
31884 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
31886 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
31887 of top-level types as claimed.
31889 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31891 * expression.cs (MemberLookup): Fruitless attempt to lookup
31892 constructors. Maybe I need to emit default constructors? That
31893 might be it (currently .NET emits this for me automatically).
31894 (Invocation::OverloadResolve): Cope with Arguments == null.
31895 (Invocation::EmitArguments): new function, shared by the new
31896 constructor and us.
31897 (Invocation::Emit): Handle static and instance methods. Emit
31898 proper call instruction for virtual or non-virtual invocations.
31899 (New::Emit): Implement.
31900 (New::Resolve): Implement.
31901 (MemberAccess:Resolve): Implement.
31902 (MethodGroupExpr::InstanceExpression): used conforming to the spec
31903 to track instances.
31904 (FieldExpr::Resolve): Set type.
31906 * support.cs: Handle empty arguments.
31908 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
31909 SimpleLookup): Auxiliary routines to help parse a qualifier
31912 Update qualifier_identifier rule.
31914 * codegen.cs: Removed debugging messages.
31916 * class.cs: Make this a global thing, this acts just as a "key" to
31917 objects that we might have around.
31919 (Populate): Only initialize method_builders_to_methods once.
31921 * expression.cs (PropertyExpr): Initialize type from the
31924 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
31925 Resolve pattern. Attempt to implicitly convert value to boolean.
31928 * expression.cs: Set the type for the int32/int32 argument case.
31929 (Binary::ResolveOperator): Set the return type to boolean for
31930 comparission operators
31932 * typemanager.cs: Remove debugging print code.
31934 (Invocation::Resolve): resolve type.
31936 * class.cs: Allocate a MemberInfo of the correct size, as the code
31937 elsewhere depends on the test to reflect the correct contents.
31939 (Method::) Keep track of parameters, due to System.Reflection holes
31941 (TypeContainer::Populate): Keep track of MethodBuilders to Method
31944 (TypeContainer::FindMembers): Use ArrayList and then copy an array
31945 of the exact size and return that.
31947 (Class::LookupMethodByBuilder): New function that maps
31948 MethodBuilders to its methods. Required to locate the information
31949 on methods because System.Reflection bit us again.
31951 * support.cs: New file, contains an interface ParameterData and
31952 two implementations: ReflectionParameters and InternalParameters
31953 used to access Parameter information. We will need to grow this
31956 * expression.cs (Invocation::GetParameterData): implement a cache
31957 and a wrapper around the ParameterData creation for methods.
31958 (Invocation::OverloadResolve): Use new code.
31960 2001-09-13 Ravi Pratap <ravi@ximian.com>
31962 * class.cs (TypeContainer::EmitField): Remove and move into
31963 (Field::Define): here and modify accordingly.
31964 (Field.FieldBuilder): New member.
31965 (TypeContainer::Populate): Update accordingly.
31966 (TypeContainer::FindMembers): Implement.
31968 2001-09-13 Miguel de Icaza <miguel@ximian.com>
31970 * statement.cs: (VariableInfo::VariableType): New field to be
31971 initialized with the full type once it is resolved.
31973 2001-09-12 Miguel de Icaza <miguel@ximian.com>
31975 * parameter.cs (GetParameterInfo): Use a type cache to compute
31976 things only once, and to reuse this information
31978 * expression.cs (LocalVariableReference::Emit): Implement.
31979 (OpcodeCast::Emit): fix.
31981 (ParameterReference::Resolve): Implement.
31982 (ParameterReference::Emit): Implement.
31984 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
31985 that are expressions need to stay as Expressions.
31987 * typemanager.cs (CSharpName): Returns the C# name of a type if
31990 * expression.cs (Expression::ConvertImplicit): New function that
31991 implements implicit type conversions.
31993 (Expression::ImplicitReferenceConversion): Implements implicit
31994 reference conversions.
31996 (EmptyCast): New type for transparent casts.
31998 (OpcodeCast): New type for casts of types that are performed with
31999 a sequence of bytecodes.
32001 (BoxedCast): New type used for casting value types into reference
32002 types. Emits a box opcode.
32004 (Binary::DoNumericPromotions): Implements numeric promotions of
32005 and computation of the Binary::Type.
32007 (Binary::EmitBranchable): Optimization.
32009 (Binary::Emit): Implement code emission for expressions.
32011 * typemanager.cs (TypeManager): Added two new core types: sbyte
32014 2001-09-12 Ravi Pratap <ravi@ximian.com>
32016 * class.cs (TypeContainer::FindMembers): Method which does exactly
32017 what Type.FindMembers does, only we don't have to use reflection. No
32018 implementation yet.
32020 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32021 typecontainer objects as we need to get at them.
32022 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32024 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32025 typecontainer object.
32027 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32028 of just a Report object.
32030 2001-09-11 Ravi Pratap <ravi@ximian.com>
32032 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32034 (TypeContainer::Populate): Now define the delegates of the type too.
32035 (TypeContainer.Delegates): Property to access the list of delegates defined
32038 * delegates.cs (Delegate::Define): Implement partially.
32040 * modifiers.cs (TypeAttr): Handle more flags.
32042 2001-09-11 Ravi Pratap <ravi@ximian.com>
32044 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32046 (Operator::Define): Re-write logic to get types by using the LookupType method
32047 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32048 (Indexer::Define): Ditto.
32049 (Event::Define): Ditto.
32050 (Property::Define): Ditto.
32052 2001-09-10 Ravi Pratap <ravi@ximian.com>
32054 * class.cs (TypeContainer::Populate): Now define operators too.
32055 (TypeContainer.Operators): New property to access the list of operators
32057 (Operator.OperatorMethodBuilder): New member to hold the method builder
32058 for the operator we are defining.
32059 (Operator::Define): Implement.
32061 2001-09-10 Ravi Pratap <ravi@ximian.com>
32063 * class.cs (Event::Define): Make the prefixes of the accessor methods
32064 addOn_ and removeOn_
32066 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32067 of the location being passed in too. Ideally, this should go later since all
32068 error reporting should be done through the Report object.
32070 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32071 (Populate): Iterate thru the indexers we have and define them too.
32072 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32073 for the get and set accessors.
32074 (Indexer::Define): Implement.
32076 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32078 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32079 my previous implementation, did not work.
32081 * typemanager.cs: Add a couple of missing types (the longs).
32083 * literal.cs: Use TypeManager.bool_type instead of getting it.
32085 * expression.cs (EventExpr): New kind of expressions.
32086 (Expressio::ExprClassFromMemberInfo): finish
32088 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32090 * assign.cs: Emit stores to static fields differently.
32092 2001-09-08 Ravi Pratap <ravi@ximian.com>
32094 * Merge in changes and adjust code to tackle conflicts. Backed out my
32095 code in Assign::Resolve ;-)
32097 2001-09-08 Ravi Pratap <ravi@ximian.com>
32099 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32100 instead Report.Error and also pass in the location.
32101 (CSharpParser::Lexer): New readonly property to return the reference
32102 to the Tokenizer object.
32103 (declare_local_variables): Use Report.Error with location instead of plain
32107 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32108 (Operator.CheckBinaryOperator): Ditto.
32110 * cs-parser.jay (operator_declarator): Update accordingly.
32112 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32113 (CheckBinaryOperator): Same here.
32115 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32116 on the name without any prefixes of namespace names etc. This is because we
32117 already might have something already fully qualified like
32118 'System.Console.WriteLine'
32120 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32122 2001-09-07 Ravi Pratap <ravi@ximian.com>
32124 * cs-tokenizer.cs (location): Return a string which also contains
32127 * expression.cs (ElementAccess): New class for expressions of the
32128 type 'element access.'
32129 (BaseAccess): New class for expressions of the type 'base access.'
32130 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32133 * cs-parser.jay (element_access): Implement action.
32134 (base_access): Implement actions.
32135 (checked_expression, unchecked_expression): Implement.
32137 * cs-parser.jay (local_variable_type): Correct and implement.
32138 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32140 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32142 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32143 name and the specifiers.
32145 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32147 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32148 making them all public ;-)
32150 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32153 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32155 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32157 (FieldExpr, PropertyExprs): New resolved expressions.
32158 (SimpleName::MemberStaticCheck): Perform static checks for access
32159 to non-static fields on static methods. Maybe this should be
32160 generalized for MemberAccesses.
32161 (SimpleName::ResolveSimpleName): More work on simple name
32164 * cs-parser.jay (primary_expression/qualified_identifier): track
32165 the parameter index.
32167 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32168 (EmitContext::EmitBoolExpression): Chain to expression generation
32169 instead of temporary hack.
32170 (::EmitStatementExpression): Put generic expression code generation.
32172 * assign.cs (Assign::Emit): Implement variable assignments to
32173 local variables, parameters and fields.
32175 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32177 * statement.cs (Block::GetVariableInfo): New method, returns the
32178 VariableInfo for a variable name in a block.
32179 (Block::GetVariableType): Implement in terms of GetVariableInfo
32181 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32182 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32184 2001-09-06 Ravi Pratap <ravi@ximian.com>
32186 * cs-parser.jay (operator_declaration): Continue on my quest : update
32187 to take attributes argument.
32188 (event_declaration): Ditto.
32189 (enum_declaration): Ditto.
32190 (indexer_declaration): Ditto.
32192 * class.cs (Operator::Operator): Update constructor accordingly.
32193 (Event::Event): Ditto.
32195 * delegate.cs (Delegate::Delegate): Same here.
32197 * enum.cs (Enum::Enum): Same here.
32199 2001-09-05 Ravi Pratap <ravi@ximian.com>
32201 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32203 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32205 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32206 being passed around as an arraylist.
32207 (Attributes::AddAttribute): Method to add attribute sections.
32209 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32210 (struct_declaration): Update accordingly.
32211 (constant_declaration): Update.
32212 (field_declaration): Update.
32213 (method_header): Update.
32214 (fixed_parameter): Update.
32215 (parameter_array): Ditto.
32216 (property_declaration): Ditto.
32217 (destructor_declaration): Ditto.
32219 * class.cs (Struct::Struct): Update constructors accordingly.
32220 (Class::Class): Ditto.
32221 (Field::Field): Ditto.
32222 (Method::Method): Ditto.
32223 (Property::Property): Ditto.
32224 (TypeContainer::OptAttribute): update property's return type.
32226 * interface.cs (Interface.opt_attributes): New member.
32227 (Interface::Interface): Update to take the extra Attributes argument.
32229 * parameter.cs (Parameter::Parameter): Ditto.
32231 * constant.cs (Constant::Constant): Ditto.
32233 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32234 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32235 the attributes as a parameter.
32236 (InterfaceProperty): Update constructor call.
32237 (InterfaceEvent): Ditto.
32238 (InterfaceMethod): Ditto.
32239 (InterfaceIndexer): Ditto.
32241 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32242 pass the attributes too.
32243 (interface_event_declaration): Ditto.
32244 (interface_property_declaration): Ditto.
32245 (interface_method_declaration): Ditto.
32246 (interface_declaration): Ditto.
32248 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32250 * class.cs (Method::Define): Track the "static Main" definition to
32251 create an entry point.
32253 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32254 EntryPoint if we find it.
32256 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32257 (EmitContext::ig): Make this variable public.
32259 * driver.cs: Make the default output file be the first file name
32260 with the .exe extension.
32262 Detect empty compilations
32264 Handle various kinds of output targets. Handle --target and
32265 rename -t to --dumper.
32267 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32268 methods inherited from Expression return now an Expression. This
32269 will is used during the tree rewriting as we resolve them during
32272 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32273 the spec. Missing entirely is the information about
32274 accessability of elements of it.
32276 (Expression::ExprClassFromMemberInfo): New constructor for
32277 Expressions that creates a fully initialized Expression based on
32278 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32281 (Invocation::Resolve): Begin implementing resolution of invocations.
32283 * literal.cs (StringLiteral): Implement Emit.
32285 2001-09-05 Ravi Pratap <ravi@ximian.com>
32287 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32290 2001-09-04 Ravi Pratap <ravi@ximian.com>
32292 * cs-parser.jay (attribute_arguments): Implement actions.
32293 (attribute): Fix bug in production. Implement action.
32294 (attribute_list): Implement.
32295 (attribute_target): Implement.
32296 (attribute_target_specifier, opt_target_specifier): Implement
32297 (CheckAttributeTarget): New method to check if the attribute target
32299 (attribute_section): Implement.
32300 (opt_attributes): Implement.
32302 * attribute.cs : New file to handle attributes.
32303 (Attribute): Class to hold attribute info.
32305 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32306 (attribute_section): Modify production to use 2 different rules to
32307 achieve the same thing. 1 s/r conflict down !
32308 Clean out commented, useless, non-reducing dimension_separator rules.
32310 * class.cs (TypeContainer.attributes): New member to hold list
32311 of attributes for a type.
32312 (Struct::Struct): Modify to take one more argument, the attribute list.
32313 (Class::Class): Ditto.
32314 (Field::Field): Ditto.
32315 (Method::Method): Ditto.
32316 (Property::Property): Ditto.
32318 * cs-parser.jay (struct_declaration): Update constructor call to
32319 pass in the attributes too.
32320 (class_declaration): Ditto.
32321 (constant_declaration): Ditto.
32322 (field_declaration): Ditto.
32323 (method_header): Ditto.
32324 (fixed_parameter): Ditto.
32325 (parameter_array): Ditto.
32326 (property_declaration): Ditto.
32328 * constant.cs (Constant::Constant): Update constructor similarly.
32329 Use System.Collections.
32331 * parameter.cs (Parameter::Parameter): Update as above.
32333 2001-09-02 Ravi Pratap <ravi@ximian.com>
32335 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32336 (TypeContainer.delegates): New member to hold list of delegates.
32338 * cs-parser.jay (delegate_declaration): Implement the action correctly
32339 this time as I seem to be on crack ;-)
32341 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32343 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32344 tell whether an identifier represents a namespace.
32346 * expression.cs (NamespaceExpr): A namespace expression, used only
32347 temporarly during expression resolution.
32348 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32349 utility functions to resolve names on expressions.
32351 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32353 * codegen.cs: Add hook for StatementExpressions.
32355 * class.cs: Fix inverted test for static flag in methods.
32357 2001-09-02 Ravi Pratap <ravi@ximian.com>
32359 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32360 to make it coincide with MS' number.
32361 (Operator::CheckBinaryOperator): Ditto.
32363 * ../errors/errors.txt : Remove error numbers added earlier.
32365 * ../errors/cs1019.cs : Test case for error # 1019
32367 * ../errros/cs1020.cs : Test case for error # 1020
32369 * cs-parser.jay : Clean out commented cruft.
32370 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32371 used anywhere - non-reducing rule.
32372 (namespace_declarations): Non-reducing rule - comment out.
32374 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32375 with TypeContainer::AddEnum.
32377 * delegate.cs : New file for delegate handling classes.
32378 (Delegate): Class for declaring delegates.
32380 * makefile : Update.
32382 * cs-parser.jay (delegate_declaration): Implement.
32384 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32386 * class.cs (Event::Define): Implement.
32387 (Event.EventBuilder): New member.
32389 * class.cs (TypeContainer::Populate): Update to define all enums and events
32391 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32392 readonly fields for all these cases ?
32394 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32396 * class.cs (Property): Revamp to use the convention of making fields readonly.
32397 Accordingly modify code elsewhere.
32399 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32400 the Define method of the Property class.
32402 * class.cs : Clean up applied patch and update references to variables etc. Fix
32404 (TypeContainer::Populate): Update to define all the properties we have. Also
32405 define all enumerations.
32407 * enum.cs (Define): Implement.
32409 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32411 * cs-parser.jay (overloadable_operator): The semantic value is an
32412 enum of the Operator class.
32413 (operator_declarator): Implement actions.
32414 (operator_declaration): Implement.
32416 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32417 validity of definitions.
32418 (Operator::CheckBinaryOperator): Static method to check for binary operators
32419 (TypeContainer::AddOperator): New method to add an operator to a type.
32421 * cs-parser.jay (indexer_declaration): Added line to actually call the
32422 AddIndexer method so it gets added ;-)
32424 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32425 already taken care of by the MS compiler ?
32427 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32429 * class.cs (Operator): New class for operator declarations.
32430 (Operator::OpType): Enum for the various operators.
32432 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32434 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32435 ostensibly handle this in semantic analysis.
32437 * cs-parser.jay (general_catch_clause): Comment out
32438 (specific_catch_clauses, specific_catch_clause): Ditto.
32439 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32440 (catch_args, opt_catch_args): New productions.
32441 (catch_clause): Rewrite to use the new productions above
32442 (catch_clauses): Modify accordingly.
32443 (opt_catch_clauses): New production to use in try_statement
32444 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32445 and re-write the code in the actions to extract the specific and
32446 general catch clauses by being a little smart ;-)
32448 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32449 Hooray, try and catch statements parse fine !
32451 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32453 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32454 string from the hashtable of variables.
32456 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32457 I end up making that mistake ;-)
32458 (catch_clauses): Fixed gross error which made Key and Value of the
32459 DictionaryEntry the same : $1 !!
32461 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32463 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32465 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32466 when the add and remove accessors are specified.
32468 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32470 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32471 information about indexer_declarator.
32472 (indexer_declarator): Implement actions.
32473 (parsing_indexer): New local boolean used to keep track of whether
32474 we are parsing indexers or properties. This is necessary because
32475 implicit_parameters come into picture even for the get accessor in the
32476 case of an indexer.
32477 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32479 * class.cs (Indexer): New class for indexer declarations.
32480 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32481 (TypeContainer::indexers): New member to hold list of indexers for the
32484 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32486 * cs-parser.jay (add_accessor_declaration): Implement action.
32487 (remove_accessor_declaration): Implement action.
32488 (event_accessors_declaration): Implement
32489 (variable_declarators): swap statements for first rule - trivial.
32491 * class.cs (Event): New class to hold information about event
32493 (TypeContainer::AddEvent): New method to add an event to a type
32494 (TypeContainer::events): New member to hold list of events.
32496 * cs-parser.jay (event_declaration): Implement actions.
32498 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32500 * cs-parser.jay (dim_separators): Implement. Make it a string
32501 concatenating all the commas together, just as they appear.
32502 (opt_dim_separators): Modify accordingly
32503 (rank_specifiers): Update accordingly. Basically do the same
32504 thing - instead, collect the brackets here.
32505 (opt_rank_sepcifiers): Modify accordingly.
32506 (array_type): Modify to actually return the complete type string
32507 instead of ignoring the rank_specifiers.
32508 (expression_list): Implement to collect the expressions
32509 (variable_initializer): Implement. We make it a list of expressions
32510 essentially so that we can handle the array_initializer case neatly too.
32511 (variable_initializer_list): Implement.
32512 (array_initializer): Make it a list of variable_initializers
32513 (opt_array_initializer): Modify accordingly.
32515 * expression.cs (New::NType): Add enumeration to help us
32516 keep track of whether we have an object/delegate creation
32517 or an array creation.
32518 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32519 members to hold data about array creation.
32520 (New:New): Modify to update NewType
32521 (New:New): New Overloaded contructor for the array creation
32524 * cs-parser.jay (array_creation_expression): Implement to call
32525 the overloaded New constructor.
32527 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32529 * class.cs (TypeContainer::Constructors): Return member
32530 constructors instead of returning null.
32532 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32534 * typemanager.cs (InitCoreTypes): Initialize the various core
32535 types after we have populated the type manager with the user
32536 defined types (this distinction will be important later while
32537 compiling corlib.dll)
32539 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32540 on Expression Classification. Now all expressions have a method
32541 `Resolve' and a method `Emit'.
32543 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32544 generation from working. Also add some temporary debugging
32547 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32549 * codegen.cs: Lots of code generation pieces. This is only the
32550 beginning, will continue tomorrow with more touches of polish. We
32551 handle the fundamentals of if, while, do, for, return. Others are
32552 trickier and I need to start working on invocations soon.
32554 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32557 * codegen.cs (EmitContext): New struct, used during code
32558 emission to keep a context. Most of the code generation will be
32561 * cs-parser.jay: Add embedded blocks to the list of statements of
32562 this block. So code generation proceeds in a top down fashion.
32564 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32566 * statement.cs: Add support for multiple child blocks.
32568 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32570 * codegen.cs (EmitCode): New function, will emit the code for a
32571 Block of code given a TypeContainer and its ILGenerator.
32573 * statement.cs (Block): Standard public readonly optimization.
32574 (Block::Block constructors): Link children.
32575 (Block::Child): Child Linker.
32576 (Block::EmitVariables): Emits IL variable declarations.
32578 * class.cs: Drop support for MethodGroups here, delay until
32580 (Method::): Applied the same simplification that I did before, and
32581 move from Properties to public readonly fields.
32582 (Method::ParameterTypes): Returns the parameter types for the
32583 function, and implements a cache that will be useful later when I
32584 do error checking and the semantic analysis on the methods is
32586 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32587 and made a method, optional argument tells whether this is a class
32588 or a structure to apply the `has-this' bit.
32589 (Method::GetCallingConvention): Implement, returns the calling
32591 (Method::Define): Defines the type, a second pass is performed
32592 later to populate the methods.
32594 (Constructor::ParameterTypes): implement a cache similar to the
32595 one on Method::ParameterTypes, useful later when we do semantic
32598 (TypeContainer::EmitMethod): New method. Emits methods.
32600 * expression.cs: Removed MethodGroup class from here.
32602 * parameter.cs (Parameters::GetCallingConvention): new method.
32604 2001-08-21 Miguel de Icaza <miguel@ximian.com>
32606 * class.cs (TypeContainer::Populate): Drop RootContext from the
32609 (Constructor::CallingConvention): Returns the calling convention.
32610 (Constructor::ParameterTypes): Returns the constructor parameter
32613 (TypeContainer::AddConstructor): Keep track of default constructor
32614 and the default static constructor.
32616 (Constructor::) Another class that starts using `public readonly'
32617 instead of properties.
32619 (Constructor::IsDefault): Whether this is a default constructor.
32621 (Field::) use readonly public fields instead of properties also.
32623 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
32624 track of static constructors; If none is used, turn on
32625 BeforeFieldInit in the TypeAttributes.
32627 * cs-parser.jay (opt_argument_list): now the return can be null
32628 for the cases where there are no arguments.
32630 (constructor_declarator): If there is no implicit `base' or
32631 `this', then invoke the default parent constructor.
32633 * modifiers.cs (MethodAttr): New static function maps a set of
32634 modifiers flags into a MethodAttributes enum
32635 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
32636 MethodAttr, TypeAttr to represent the various mappings where the
32637 modifiers are used.
32638 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
32640 2001-08-19 Miguel de Icaza <miguel@ximian.com>
32642 * parameter.cs (GetParameterInfo): Fix bug where there would be no
32645 * interface.cs (PopulateIndexer): Implemented the code generator
32646 for interface indexers.
32648 2001-08-17 Miguel de Icaza <miguel@ximian.com>
32650 * interface.cs (InterfaceMemberBase): Now we track the new status
32653 (PopulateProperty): Implement property population. Woohoo! Got
32654 Methods and Properties going today.
32656 Removed all the properties for interfaces, and replaced them with
32657 `public readonly' fields.
32659 2001-08-16 Miguel de Icaza <miguel@ximian.com>
32661 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
32662 initialize their hashtables/arraylists only when they are needed
32663 instead of doing this always.
32665 * parameter.cs: Handle refs and out parameters.
32667 * cs-parser.jay: Use an ArrayList to construct the arguments
32668 instead of the ParameterCollection, and then cast that to a
32671 * parameter.cs: Drop the use of ParameterCollection and use
32672 instead arrays of Parameters.
32674 (GetParameterInfo): Use the Type, not the Name when resolving
32677 2001-08-13 Miguel de Icaza <miguel@ximian.com>
32679 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
32680 and instead use public readonly fields.
32682 * class.cs: Put back walking code for type containers.
32684 2001-08-11 Miguel de Icaza <miguel@ximian.com>
32686 * class.cs (MakeConstant): Code to define constants.
32688 * rootcontext.cs (LookupType): New function. Used to locate types
32691 2001-08-08 Miguel de Icaza <miguel@ximian.com>
32693 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
32694 this System.Reflection code is. Kudos to Microsoft
32696 * typemanager.cs: Implement a type cache and avoid loading all
32697 types at boot time. Wrap in LookupType the internals. This made
32698 the compiler so much faster. Wow. I rule!
32700 * driver.cs: Make sure we always load mscorlib first (for
32701 debugging purposes, nothing really important).
32703 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
32704 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
32706 * rootcontext.cs: Lookup types on their namespace; Lookup types
32707 on namespaces that have been imported using the `using' keyword.
32709 * class.cs (TypeContainer::TypeAttr): Virtualize.
32710 (Class::TypeAttr): Return attributes suitable for this bad boy.
32711 (Struct::TypeAttr): ditto.
32712 Handle nested classes.
32713 (TypeContainer::) Remove all the type visiting code, it is now
32714 replaced with the rootcontext.cs code
32716 * rootcontext.cs (GetClassBases): Added support for structs.
32718 2001-08-06 Miguel de Icaza <miguel@ximian.com>
32720 * interface.cs, statement.cs, class.cs, parameter.cs,
32721 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
32722 Drop use of TypeRefs, and use strings instead.
32724 2001-08-04 Miguel de Icaza <miguel@ximian.com>
32728 * class.cs (Struct::Struct): set the SEALED flags after
32729 checking the modifiers.
32730 (TypeContainer::TypeAttr): new property, returns the
32731 TypeAttributes for a class.
32733 * cs-parser.jay (type_list): Oops, list production was creating a
32734 new list of base types.
32736 * rootcontext.cs (StdLib): New property.
32737 (GetInterfaceTypeByName): returns an interface by type name, and
32738 encapsulates error handling here.
32739 (GetInterfaces): simplified.
32740 (ResolveTree): Encapsulated all the tree resolution here.
32741 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
32744 * driver.cs: Add support for --nostdlib, to avoid loading the
32745 default assemblies.
32746 (Main): Do not put tree resolution here.
32748 * rootcontext.cs: Beginning of the class resolution.
32750 2001-08-03 Miguel de Icaza <miguel@ximian.com>
32752 * rootcontext.cs: Provide better error reporting.
32754 * cs-parser.jay (interface_base): set our $$ to be interfaces.
32756 * rootcontext.cs (CreateInterface): Handle the case where there
32757 are no parent interfaces.
32759 (CloseTypes): Routine to flush types at the end.
32760 (CreateInterface): Track types.
32761 (GetInterfaces): Returns an array of Types from the list of
32762 defined interfaces.
32764 * typemanager.c (AddUserType): Mechanism to track user types (puts
32765 the type on the global type hash, and allows us to close it at the
32768 2001-08-02 Miguel de Icaza <miguel@ximian.com>
32770 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
32771 RecordInterface instead.
32773 * cs-parser.jay: Updated to reflect changes above.
32775 * decl.cs (Definition): Keep track of the TypeBuilder type that
32776 represents this type here. Not sure we will use it in the long
32777 run, but wont hurt for now.
32779 * driver.cs: Smaller changes to accomodate the new code.
32781 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
32784 * rootcontext.cs (CreateInterface): New method, used to create
32785 the System.TypeBuilder type for interfaces.
32786 (ResolveInterfaces): new entry point to resolve the interface
32788 (CodeGen): Property, used to keep track of the code generator.
32790 2001-07-26 Miguel de Icaza <miguel@ximian.com>
32792 * cs-parser.jay: Add a second production for delegate_declaration
32795 (enum_body): Put an opt_comma here instead of putting it on
32796 enum_body or enum_member_declarations so we can handle trailing
32797 commas on enumeration members. Gets rid of a shift/reduce.
32799 (type_list): Need a COMMA in the middle.
32801 (indexer_declaration): Tell tokenizer to recognize get/set
32803 * Remove old targets.
32805 * Re-add the parser target.
32807 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32809 * cs-parser.jay: Add precendence rules for a number of operators
32810 ot reduce the number of shift/reduce conflicts in the grammar.
32812 2001-07-17 Miguel de Icaza <miguel@ximian.com>
32814 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
32817 Get rid of old crufty code.
32819 * rootcontext.cs: Use this to keep track of the parsed
32820 representation and the defined types available to the program.
32822 * gen-treedump.cs: adjust for new convention.
32824 * type.cs: Split out the type manager, and the assembly builder
32827 * typemanager.cs: the type manager will live here now.
32829 * cil-codegen.cs: And the code generator here.
32831 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
32833 * makefile: Fixed up for easy making.
32835 2001-07-13 Simon Cozens <simon@simon-cozens.org>
32837 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
32840 (unary_expression): Expand pre_increment_expression and
32841 post_decrement_expression to reduce a shift/reduce.
32843 2001-07-11 Simon Cozens
32845 * cs-tokenizer.cs: Hex numbers should begin with a 0.
32847 Improve allow_keyword_as_indent name.
32849 2001-06-19 Miguel de Icaza <miguel@ximian.com>
32851 * Adjustments for Beta2.
32853 2001-06-13 Miguel de Icaza <miguel@ximian.com>
32855 * decl.cs: Added `Define' abstract method.
32856 (InTransit): new property, used to catch recursive definitions.
32858 * interface.cs: Implement `Define'.
32860 * modifiers.cs: Map Modifiers.constants to
32861 System.Reflection.TypeAttribute flags.
32863 * class.cs: Keep track of types and user-defined types.
32864 (BuilderInit): New method for creating an assembly
32865 (ResolveType): New function to launch the resolution process, only
32866 used by interfaces for now.
32868 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
32869 that are inserted into the name space.
32871 2001-06-08 Miguel de Icaza <miguel@ximian.com>
32873 * ARGH. I have screwed up my tree so many times due to the use of
32874 rsync rather than using CVS. Going to fix this at once.
32876 * driver.cs: Objetify driver. Load assemblies, use assemblies to
32879 2001-06-07 Miguel de Icaza <miguel@ximian.com>
32881 * Experiment successful: Use System.Type rather that our own
32884 2001-05-25 Miguel de Icaza <miguel@ximian.com>
32886 * cs-parser.jay: Removed nsAliases from here.
32888 Use new namespaces, handle `using XXX;'
32890 * namespace.cs: Reimplemented namespace handling, use a recursive
32891 definition of the class. Now we can keep track of using clauses
32892 and catch invalid using clauses.
32894 2001-05-24 Miguel de Icaza <miguel@ximian.com>
32896 * gen-treedump.cs: Adapted for all the renaming.
32898 * expression.cs (Expression): this class now has a Type property
32899 which returns an expression Type.
32901 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
32902 `Type', as this has a different meaning now in the base
32904 2001-05-22 Miguel de Icaza <miguel@ximian.com>
32906 * interface.cs, class.cs: Removed from all the sources the
32907 references to signature computation, as we can not do method
32908 signature computation during the parsing time, as we are not
32909 trying to solve at that point distinguishing:
32913 void a (NS.Blah x) {}
32916 Which depending on the context might be valid or not, as we do not
32917 know if Blah is the same thing as NS.Blah at that point.
32919 * Redid everything so the code uses TypeRefs now instead of
32920 Types. TypeRefs are just temporary type placeholders, that need
32921 to be resolved. They initially have a pointer to a string and the
32922 current scope in which they are used. This is used later by the
32923 compiler to resolve the reference to an actual Type.
32925 * DeclSpace is no longer a CIR.Type, and neither are
32926 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
32927 are all DeclSpaces, but no Types.
32929 * type.cs (TypeRefManager): This implements the TypeRef manager,
32930 which keeps track of all the types that need to be resolved after
32931 the parsing has finished.
32933 2001-05-13 Miguel de Icaza <miguel@ximian.com>
32935 * ARGH. We are going to have to store `foreach' as a class rather
32936 than resolving it, as we need to verify error 1579 after name
32937 resolution. *OR* we could keep a flag that says `This request to
32938 IEnumerator comes from a foreach statement' which we can then use
32939 to generate the error.
32941 2001-05-10 Miguel de Icaza <miguel@ximian.com>
32943 * class.cs (TypeContainer.AddMethod): we now add methods to the
32944 MethodGroup instead of the method hashtable.
32946 * expression.cs: Add MethodGroup abstraction, which gets us one
32947 step closer to the specification in the way we handle method
32950 * cs-parser.jay (primary_expression): qualified_identifier now
32951 tried to match up an identifier to a local variable reference or
32952 to a parameter reference.
32954 current_local_parameters is now a parser global variable that
32955 points to the current parameters for the block, used during name
32958 (property_declaration): Now creates an implicit `value' argument to
32961 2001-05-09 Miguel de Icaza <miguel@ximian.com>
32963 * parameter.cs: Do not use `param' arguments as part of the
32964 signature, per the spec.
32966 2001-05-08 Miguel de Icaza <miguel@ximian.com>
32968 * decl.cs: Base class for classes, structs and interfaces. This
32969 is the "Declaration Space"
32971 * cs-parser.jay: Use CheckDef for checking declaration errors
32972 instead of having one on each function.
32974 * class.cs: Factor out some code for handling error handling in
32975 accordance to the "Declarations" section in the "Basic Concepts"
32976 chapter in the ECMA C# spec.
32978 * interface.cs: Make all interface member classes derive from
32979 InterfaceMemberBase.
32981 2001-05-07 Miguel de Icaza <miguel@ximian.com>
32983 * Many things: all interfaces are parsed and generated in
32984 gen-treedump. Support for member variables, constructors,
32985 destructors, properties, constants is there.
32987 Beginning of the IL backend, but very little done, just there for
32990 2001-04-29 Miguel de Icaza <miguel@ximian.com>
32992 * cs-parser.jay: Fix labeled statement.
32994 * cs-tokenizer.cs (escape): Escape " and ' always.
32995 ref_line, ref_name: keep track of the line/filename as instructed
32996 by #line by the compiler.
32999 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33001 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33002 to match the values in System.CodeDOM.
33004 Divid renamed to Divide.
33006 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33008 (Statements.set): remove.
33010 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33013 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33014 falseStatements always have valid values.
33016 * cs-parser.jay: Use System.CodeDOM now.