1 2010-03-26 Marek Safar <marek.safar@gmail.com>
3 * cs-parser.jay: Report invalid constraint types.
5 2010-03-16 Jb Evain <jbevain@novell.com>
7 * Makefile: rename the net_2_1 profile to moonlight.
9 2010-03-11 Marek Safar <marek.safar@gmail.com>
11 * statement.cs, cs-parser.jay: Use correct location for empty
14 2010-03-11 Marek Safar <marek.safar@gmail.com>
16 * cs-parser.jay: Disable Location from expression.
18 * generic.cs: Check constraints for overrides in the parser.
20 2010-03-09 Marek Safar <marek.safar@gmail.com>
22 * cs-parser.jay (GetLocation): Use an expression when available.
24 2010-03-04 Marek Safar <marek.safar@gmail.com>
27 * ecore.cs (FieldExpr): Don't optimize cross reference loads.
29 2010-03-04 Marek Safar <marek.safar@gmail.com>
31 A patch by kornelpal@gmail.com
33 * dynamic.cs, anonymous.cs, rootcontext.cs, class.cs: Don't make
34 compiler generated classes sealed by default. Emit and close top
35 level compiler generated classes as well.
37 * support.cs: Use RuntimeHelpers.GetHashCode.
39 2010-03-03 Rolf Bjarne Kvinge <RKvinge@novell.com>
41 * Makefile: We need to use the internal bootstrapping gmcs for
42 net_2_1_bootstrap too now.
44 2010-03-02 Raja R Harinath <harinath@hurrynot.org>
46 * expression.cs (IndexerAccess.ResolveAccessor): Add CS1540 check.
48 2010-03-02 Marek Safar <marek.safar@gmail.com>
50 * cs-tokenizer.cs: Missed few locations in previous fix.
52 2010-03-02 Marek Safar <marek.safar@gmail.com>
54 * cs-tokenizer.cs, argument.cs, dynamic.cs, assign.cs, anonymous.cs,
55 nullable.cs, expression.cs, statement.cs, cs-parser.jay, cfold.cs:
56 Report correct location for operator errors.
58 2010-03-02 Marek Safar <marek.safar@gmail.com>
60 * typemanager.cs (IsDynamicType): Don't check external types when
61 the attribute is not external.
63 2010-02-24 Marek Safar <marek.safar@gmail.com>
66 * decl.cs (IsExposedFromAssembly): Use PartialContainer for parent
69 2010-02-24 Marek Safar <marek.safar@gmail.com>
72 * ecore.cs: Fixed type comparison.
74 2010-02-08 Miguel de Icaza <miguel@novell.com>
76 * namespace.cs (CompletionGetTypesStartingWith): Do not include
77 private types in the completion results.
79 * cs-parser.jay: Bubble completions after "from x in ?" and "from x
82 2010-02-17 Marek Safar <marek.safar@gmail.com>
84 * generic.cs, field.cs, decl.cs, cs-parser.jay: Simplify special
87 2010-02-14 Miguel de Icaza <miguel@novell.com>
89 * eval.cs: Do not do the report printer dance unless the user has
90 set the DescribeTypes feature.
92 2010-02-10 Marek Safar <marek.safar@gmail.com>
94 * argument.cs, dynamic.cs, expression.cs: Track RC API changes.
96 2010-02-08 Marek Safar <marek.safar@gmail.com>
99 * anonymous.cs: Fixed TypeBuilder* check.
101 2010-02-06 Miguel de Icaza <miguel@novell.com>
103 * eval.cs (CompileBlock): Also undo if there are problems during
104 semantic analysis, fixes various cases where invalid C# code would
105 be reported, but the internal changes would not be undone.
107 2010-02-03 Miguel de Icaza <miguel@novell.com>
109 * driver.cs: Change the --fatal flag to allow a number to be
110 passed, this ignores the first N fatal errors. Useful to debug
111 errors that do not happen on the first hit.
113 * cs-parser.jay (invocation_expression): accept both the
114 CLOSE_PARENS and COMPLETE_COMPLETION, this allows completions
115 inside an invocation.
117 * driver.cs: Expose FatalErrors.
119 * eval.cs: Initialize the printer's Fatal property from the
120 Driver's FatalError flag, this allows csharp --fatal to work
123 Add support for calling Describe (typeof (TYPE)) if the expression
126 2010-02-02 Marek Safar <marek.safar@gmail.com>
128 A fix for bug #574991
129 * rootcontext.cs, class.cs, driver.cs: Hide enhanced warnings behind
132 2010-02-02 Marek Safar <marek.safar@gmail.com>
134 A fix for bug #575986
135 * expression.cs: Don't mutate typeof type definitions.
137 2010-01-28 Marek Safar <marek.safar@gmail.com>
139 * decl.cs: Use only one set of modifiers.
141 2010-01-26 Marek Safar <marek.safar@gmail.com>
143 A fix for bug #573329
144 * eval.cs: Don't disable error reporting completely on silent mode.
146 2010-01-25 Marek Safar <marek.safar@gmail.com>
148 A fix for bug #573312
149 * constant.cs, expression.cs, ecore.cs: Emit correct offset for
150 pointer index of unknown size types greater than 2.
152 2010-01-15 Marek Safar <marek.safar@gmail.com>
154 * *.cs: Use only 1 member kind enum.
156 2010-01-15 Marek Safar <marek.safar@gmail.com>
158 * *.cs: Add event specification.
160 2010-01-14 Marek Safar <marek.safar@gmail.com>
162 * membercache.cs: Extracted from decl.cs.
164 * *.cs: Put more infrastructure in place.
166 2010-01-13 Marek Safar <marek.safar@gmail.com>
168 * *.cs: Add property specification, unused yet.
170 2010-01-13 Marek Safar <marek.safar@gmail.com>
172 * property.cs: Move all property based declarations into a new file.
174 2010-01-13 Marek Safar <marek.safar at gmail.com>
176 * expression.cs (Conditional): Resolve reduced expression.
178 2010-01-13 Marek Safar <marek.safar at gmail.com>
180 * *.cs: Introduced non-generic method specification.
182 2010-01-07 Marek Safar <marek.safar@gmail.com>
184 * method.cs: Move all method based declarations into a new file.
186 2010-01-07 Marek Safar <marek.safar@gmail.com>
188 * *.cs: Extract field specification.
190 2009-12-17 Marek Safar <marek.safar@gmail.com>
192 * field.cs: Extracted from class.cs
194 2009-12-15 Marek Safar <marek.safar@gmail.com>
196 * attribute.cs (GetFixedBuffer): Work on field definition only.
198 2009-12-15 Marek Safar <marek.safar@gmail.com>
200 * *.cs: Clean up NET_4_0 conditional where possible.
202 2009-12-14 Rodrigo Kumpera <rkumpera@novell.com>
204 support.cs (DynamicType): Assembly property returns the assembly builder.
205 This is required due to how compiler context works in corlib.
207 2009-12-14 Marek Safar <marek.safar@gmail.com>
209 A fix for bug #564376
210 * assign.cs (LocalTemporary): Removed no longer needed special
213 2009-12-11 Marek Safar <marek.safar@gmail.com>
215 * modifiers.cs, decl.cs, iterators.cs, const.cs, anonymous.cs,
216 class.cs, delegate.cs, cs-parser.jay, enum.cs: Turn modifiers into
217 enum for easier debugging.
219 2009-12-10 Marek Safar <marek.safar@gmail.com>
221 * decl.cs, anonymous.cs, class.cs: Sealed Define it's now main entry
224 * parameter.cs, delegate.cs, dynamic.cs: Don't use builder methods
227 2009-12-10 Marek Safar <marek.safar@gmail.com>
229 * cs-parser.jay, statement.cs: Handle parser error in code
232 2009-12-10 Marek Safar <marek.safar@gmail.com>
234 * ecore.cs: Ignore base imported methods when they are already
237 * eval.cs: Handle non-existent keys.
239 * report.cs, driver.cs: Make fatal work with console printer only.
241 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
243 * typemanager.cs (MakeGenericMethod): Fix stupid mistake.
245 2009-12-08 Rodrigo Kumpera <rkumpera@novell.com>
247 * typemanager.cs: Add MakeGenericMethod that checks if the method
248 is really the generic method definition.
250 ecore.cs (MethodGroupExpr:IsApplicable): Use new TypeManager function
251 to inflate generic methods.
253 2009-12-08 Marek Safar <marek.safar@gmail.com>
255 A fix for bug #561149
256 * anonymous.cs: Use actual type parameters when checking for generic
259 2009-12-08 Marek Safar <marek.safar@gmail.com>
261 A fix for bug #561369
262 * expression.cs (DoNumericPromotion): Fixed typo.
264 2009-12-08 Marek Safar <marek.safar@gmail.com>
266 *.cs: Moving to generics world.
268 cs-parser.jay: Removed current_array_type.
270 2009-12-07 Marek Safar <marek.safar@gmail.com>
272 *.cs: Moving to generics world.
274 2009-12-04 Marek Safar <marek.safar@gmail.com>
276 *.cs: Moving to generics world (day 2).
278 2009-12-03 Marek Safar <marek.safar@gmail.com>
280 *.cs: Moving to generics world.
282 2009-12-02 Marek Safar <marek.safar@gmail.com>
284 * typemanager.cs, parameter.cs, class.cs, delegate.cs, attribute.cs:
285 Encode dynamic type attribute for elements where attributes cannot
288 2009-12-01 Marek Safar <marek.safar@gmail.com>
290 argument.cs, assign.cs, expression.cs, cs-parser.jay: Named
293 2009-12-01 Marek Safar <marek.safar@gmail.com>
295 A fix for bug #360455
296 * class.cs: Never report a unused warning for generic events to
297 workaround wrong expression type.
299 2009-11-30 Marek Safar <marek.safar@gmail.com>
301 A fix for bug #558305
302 * decl.cs, class.cs: Check partial method definitions using correct
305 2009-11-30 Marek Safar <marek.safar@gmail.com>
307 * argument.cs: Don't cache rarely used dynamic flag.
309 2009-11-27 Marek Safar <marek.safar@gmail.com>
311 * cs-parser.jay: Use jay global stacks (saves over 3MB for corlib).
313 2009-11-27 Marek Safar <marek.safar@gmail.com>
315 * ecore.cs (SimpleName): Removed no longer needed in_transit as
316 Resolve is now non-reentrant (saves ~0.6MB for corlib).
318 2009-11-26 Marek Safar <marek.safar@gmail.com>
320 A fix for bug #545081
321 * decl.cs: Check private nested types of nested types recursively.
323 2009-11-26 Marek Safar <marek.safar@gmail.com>
325 A fix for bug #558305
326 * location.cs: Ignore self referencing #line directive
328 2009-11-26 Marek Safar <marek.safar@gmail.com>
330 A fix for bug #558292
331 * class.cs: Allow single unsafe fixed buffer fields.
333 2009-11-26 Marek Safar <marek.safar@gmail.com>
335 * expression: Optimize few more zero-based operations.
337 2009-11-26 Marek Safar <marek.safar@gmail.com>
339 * cs-tokenizer.cs, cs-parser.jay: Simplify literal parsing, also
340 avoids boxing of literal values.
342 2009-11-26 Marek Safar <marek.safar@gmail.com>
344 * cs-tokenizer.cs, argument.cs, eval.cs, linq.cs, decl.cs,
345 expression.cs, ecore.cs, location.cs, cs-parser.jay, attribute.cs,
346 codegen.cs: LocatedToken redesing to avoid excessive allocation and
347 boxing (saves ~7MB for corlib). Also fixes presise token location.
349 2009-11-25 Marek Safar <marek.safar@gmail.com>
351 * ecore.cs, cs-parser.jay: Keep parser structures local. Share
354 2009-11-24 Marek Safar <marek.safar@gmail.com>
356 * expression.cs: Lower static array initializer barrier.
358 * support.cs, driver.cs: Share reader buffer.
360 2009-11-23 Marek Safar <marek.safar@gmail.com>
362 * cs-tokenizer.cs, support.cs: Some tokenizer optimizations.
364 2009-11-23 Marek Safar <marek.safar@gmail.com>
366 * cs-tokenizer.cs, support.cs: Use Dictionary instead of Hashtable,
367 cleanup some obsolete code.
369 2009-11-20 Marek Safar <marek.safar@gmail.com>
371 * context.cs, expression.cs, ecore.cs, complete.cs: Cleaned up
374 2009-11-20 Marek Safar <marek.safar@gmail.com>
376 * *.cs: Resolved expressions are never resolved again, this helps to
377 uncover some not easy to find bugs and improve the performance.
379 2009-11-19 Marek Safar <marek.safar@gmail.com>
381 * *.cs: Made constant expressions fully compatible with any other
384 2009-11-19 Marek Safar <marek.safar@gmail.com>
386 * *.cs: DoResolve is a worker method and has to be protected.
388 2009-11-18 Marek Safar <marek.safar@gmail.com>
390 * *.cs: More context specific handling.
392 2009-11-17 Marek Safar <marek.safar@gmail.com>
394 * *.cs: More context specific handling.
396 2009-11-16 Marek Safar <marek.safar@gmail.com>
398 * dynamic.cs, class.cs: Removed few fixed user types conversions.
400 * symbolwriter.cs: Uses public ILOffset.
402 2009-11-13 Marek Safar <marek.safar@gmail.com>
404 A fix for bug #553650
405 * generic.cs: Another missing TypeToCoreType, still too many to fix.
407 2009-11-13 Marek Safar <marek.safar@gmail.com>
409 A fix for bug #555170
411 * class.cs, delegate.cs, enum.cs: Constants have to be available
412 for parameters resolve.
414 2009-11-12 Marek Safar <marek.safar@gmail.com>
416 * typemanager.cs, argument.cs, support.cs, delegate.cs: Dynamic
419 2009-11-12 Marek Safar <marek.safar@gmail.com>
421 * argument.cs, context.cs, expression.cs, ecore.cs: Dynamic binding
422 with a statically known candidate set.
424 2009-11-11 Scott Peterson <lunchtimemama@gmail.com>
426 * generic.cs: Made type inflation for generic constraint checks
427 recursive. This fixes BGO #553655.
429 2009-11-11 Marek Safar <marek.safar@gmail.com>
431 * dynamic.cs, decl.cs, expression.cs, ecore.cs: More dynamic type
434 2009-11-10 Marek Safar <marek.safar@gmail.com>
436 * typemanager.cs, generic.cs, parameter.cs, argument.cs, dynamic.cs,
437 linq.cs, rootcontext.cs, ecore.cs, class.cs, delegate.cs,
438 attribute.cs: Add some dynamic error checking.
440 2009-11-07 Marek Safar <marek.safar@gmail.com>
442 A fix for bug #553465
444 * expression.cs: Fixed mixed version of expression tree anonymous
447 2009-11-06 Marek Safar <marek.safar@gmail.com>
449 A fix for bug #553031
451 * linq.cs, expression.cs, class.cs, cs-parser.jay: Initialize
452 expression tree version of anonymous type with members declaration.
454 2009-11-05 Marek Safar <marek.safar@gmail.com>
456 * parameter.cs: Handle nullable parameter default expression.
458 * argument.cs, dynamic.cs, expression.cs, support.cs, ecore.cs,
459 class.cs, attribute.cs: Check for wrong dynamic arguments.
461 2009-11-05 Marek Safar <marek.safar@gmail.com>
463 * statement.cs: Dynamic statements.
465 2009-11-04 Marek Safar <marek.safar@gmail.com>
467 * dynamic.cs, assign.cs, context.cs, expression.cs, ecore.cs:
468 Compound assignments over dynamic type.
470 2009-11-03 Marek Safar <marek.safar@gmail.com>
472 * argument.cs, dynamic.cs, expression.cs, delegate.cs: Dynamic
473 constructor arguments.
475 2009-10-30 Marek Safar <marek.safar@gmail.com>
477 * dynamic.cs, convert.cs, assign.cs, constant.cs, expression.cs,
478 codegen.cs: Unary mutator on dynamic member access expression.
480 2009-10-29 Marek Safar <marek.safar@gmail.com>
482 A fix for bug #550580
483 * convert.cs: Don't eliminate explicit precission casts.
485 2009-10-28 Marek Safar <marek.safar@gmail.com>
487 A fix for bug #550404
489 * parameter.cs, iterators.cs, context.cs, anonymous.cs,
490 expression.cs, statement.cs, ecore.cs: Quote any nested expression
493 2009-10-27 Marek Safar <marek.safar@gmail.com>
495 * constant.cs, nullable.cs: Create nullable-null as LiftedNull
498 * class.cs: Allow nullable binary user operators.
500 2009-10-26 Marek Safar <marek.safar@gmail.com>
502 * expression.cs: Move binary expression optimization at the end of
505 2009-10-23 Marek Safar <marek.safar@gmail.com>
507 * constant.cs, nullable.cs, expression.cs, literal.cs, cfold.cs:
508 Separate NullConstant from NullLiteral.
510 2009-10-23 Marek Safar <marek.safar@gmail.com>
512 * typemanager.cs, eval.cs, decl.cs, roottypes.cs, context.cs,
513 anonymous.cs, expression.cs, rootcontext.cs, ecore.cs, class.cs,
514 flowanalysis.cs, cs-parser.jay, driver.cs, codegen.cs: Split
515 ModuleContainer. Add common unclosed member check routine.
517 2009-10-22 Marek Safar <marek.safar@gmail.com>
519 * argument.cs: Use literal flag for real literals only.
521 * dynamic.cs: Use correct return type for custom delegates.
523 2009-10-22 Marek Safar <marek.safar@gmail.com>
525 * dynamic.cs, expression.cs: Pass logical binary flag to dynamic
528 2009-10-22 Marek Safar <marek.safar@gmail.com>
530 * dynamic.cs, ecore.cs: Dynamic invocation with void return type.
532 2009-10-21 Marek Safar <marek.safar@gmail.com>
534 * dynamic.cs, convert.cs, expression.cs, ecore.cs: Wrap array index
537 2009-10-21 Marek Safar <marek.safar@gmail.com>
539 * typemanager.cs, dynamic.cs, expression.cs: Don't resolve runtime
542 2009-10-20 Marek Safar <marek.safar@gmail.com>
544 * argument.cs, dynamic.cs, expression.cs: Latest API update.
546 2009-10-19 Marek Safar <marek.safar@gmail.com>
548 * typemanager.cs, expression.cs: Dynamic array initializer.
550 2009-10-16 Marek Safar <marek.safar@gmail.com>
552 * typemanager.cs, rootcontext.cs: Clear -nostdlib flag when object
555 2009-10-16 Marek Safar <marek.safar@gmail.com>
557 A fix for bug #493523, #507067
558 * convert.cs, nullable.cs, expression.cs: Do implicit and explicit
559 standard nullable conversion using underlying standard conversion
560 and not full conversion.
562 2009-10-15 Marek Safar <marek.safar@gmail.com>
564 * dynamic.cs, expression.cs, ecore.cs, delegate.cs: Check return
565 type in VerifyArgumentsCompat.
567 2009-10-15 Marek Safar <marek.safar@gmail.com>
569 * nullable.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
570 Reject variable used with type arguments.
572 2009-10-14 Marek Safar <marek.safar@gmail.com>
574 * argument.cs, dynamic.cs, assign.cs, expression.cs, ecore.cs:
575 Implement dynamic expressions assignment.
577 2009-10-14 Marek Safar <marek.safar@gmail.com>
579 * expression.cs: Build underlying expression when resolving unary
582 2009-10-14 Marek Safar <marek.safar@gmail.com>
584 * expression.cs: Emit enum array initializer using binary blob.
586 2009-10-08 Marek Safar <marek.safar@gmail.com>
588 * typemanager.cs, constant.cs: Optimize decimal constants which fit
591 2009-10-07 Marek Safar <marek.safar@gmail.com>
593 * typemanager.cs: Reset object_type.
595 * assign: Made SimpleAssign public.
597 2009-10-06 Marek Safar <marek.safar@gmail.com>
599 * typemanager.cs, decl.cs, namespace.cs, ecore.cs, class.cs: Pass
600 invocation assembly to IsThisOrFriendAssembly.
602 2009-10-05 Marek Safar <marek.safar@gmail.com>
604 * expression.cs: Equality comparison of generic parameter with
607 2009-10-05 Marek Safar <marek.safar@gmail.com>
609 A fix for bug #543570
610 * generic.cs: Import predefined constraints correctly.
612 2009-10-02 Marek Safar <marek.safar@gmail.com>
614 * ecore.cs: Don't crash on overloads with optional paremeters where
615 arguments count overflows.
617 * parameter.cs: Import optional parameter constants using optional
620 2009-10-01 Marek Safar <marek.safar@gmail.com>
622 * Makefile: Default is gmcs compiler.
624 2009-10-01 Marek Safar <marek.safar@gmail.com>
626 * cs-parser.jay: Fixed few NRE.
628 2009-10-01 Marek Safar <marek.safar@gmail.com>
630 * cs-parser.jay, driver.cs: Expose parser exception in verbose mode.
632 2009-09-30 Marek Safar <marek.safar@gmail.com>
634 * linq.cs, convert.cs, assign.cs, expression.cs, ecore.cs: Add
635 ShimExpression, ImplicitCast.
637 2009-09-30 Marek Safar <marek.safar@gmail.com>
639 A fix for bug #542959
640 * delegate.cs: Emit correct delegate instance variable when there
641 are static and non-static overloads.
643 2009-09-29 Marek Safar <marek.safar@gmail.com>
645 * dynamic.cs, linq.cs, anonymous.cs, expression.cs, statement.cs,
646 ecore.cs, cs-parser.jay: Unary expression dynamic compiler.
648 2009-09-28 Marek Safar <marek.safar@gmail.com>
650 A fix for bug #542487
651 * ecore.cs: Resolve extension methods hidden by properties.
653 2009-09-25 Marek Safar <marek.safar@gmail.com>
655 * expression.cs, ecore.cs: More dynamic binary expressions.
657 2009-09-22 Marek Safar <marek.safar@gmail.com>
659 * nullable.cs, expression.cs: Fixed null lifted conversion for
660 bitwise enum operations.
662 2009-09-22 Marek Safar <marek.safar@gmail.com>
664 * convert.cs, ecore.cs: Fixed explicit unsafe coversion of long
665 values in checked context.
667 2009-09-22 Marek Safar <marek.safar@gmail.com>
669 * expression.cs, ecore.cs: Fixed array index constant conversion.
671 2009-09-20 Miguel de Icaza <miguel@novell.com>
673 * expression.cs: Do not crash when MemberLookup returns something
674 that is not a MemberExpr here. Report error 582 instead.
678 2009-09-18 Marek Safar <marek.safar@gmail.com>
680 * decl.cs, class.cs: Check protected property accessors.
682 2009-09-18 Marek Safar <marek.safar@gmail.com>
684 * dynamic.cs, assign.cs: Dynamic compound assignment.
686 2009-09-17 Marek Safar <marek.safar@gmail.com>
688 * expression.cs: Fixed compound assignment explicit conversion.
690 2009-09-17 Marek Safar <marek.safar@gmail.com>
692 * expression.cs, ecore.cs: Cannot infer variables from method group.
694 2009-09-16 Marek Safar <marek.safar@gmail.com>
696 * argument.cs, dynamic.cs, convert.cs, context.cs, anonymous.cs,
697 constant.cs, nullable.cs, expression.cs, literal.cs, ecore.cs,
698 codegen.cs: Dynamic binary operations scaffolding.
700 2009-09-15 Marek Safar <marek.safar@gmail.com>
702 * expression.cs: Fixes nullable promotion for enum type variables.
704 2009-09-11 Marek Safar <marek.safar@gmail.com>
706 * driver.cs, dynamic.cs: Reset more static variables.
708 2009-09-11 Marek Safar <marek.safar@gmail.com>
710 * dynamic.cs, expression.cs, rootcontext.cs, namespace.cs, ecore.cs,
711 driver.cs: Introduced Expression::MakeExpression.
713 2009-09-11 Marek Safar <marek.safar@gmail.com>
715 * eval.cs: Exposed MessageOutput instead of cleaning up eval API.
717 2009-09-09 Marek Safar <marek.safar@gmail.com>
719 * eval.cs, report.cs: Use Console.Out for all eval error or warning
722 2009-09-09 Marek Safar <marek.safar@gmail.com>
724 A fix for bug #518707
725 * expression.cs (Is): Optimize only generic parameter type
726 expression probing value type generic parameter.
728 2009-09-09 Marek Safar <marek.safar@gmail.com>
730 A fix for bug #532571
731 * ecore.cs: Check for simple name type arguments used with
734 2009-09-08 Marek Safar <marek.safar@gmail.com>
736 A fix for bug #497421
737 * generic.cs (CheckConstraint): Don't use buildin types to check for
738 parameterless constructor.
740 2009-09-08 Marek Safar <marek.safar@gmail.com>
742 A fix for bug #537402
743 * generic.cs (CheckConstraint): Correctly inflate generic type
744 arguments when checking generic method.
746 2009-09-08 Marek Safar <marek.safar@gmail.com>
748 A fix for bug #536463
749 * decl.cs (AddToContainer): Don't report collision between explicit
750 and parameterless non-explicit members.
752 2009-09-08 Marek Safar <marek.safar@gmail.com>
754 * eval.cs: Reset more static stuff.
756 2009-09-07 Marek Safar <marek.safar@gmail.com>
758 A fix for bug #324625
759 * expression.cs, ecore.cs: Create nested generic type expression
760 using declaring and not current type.
762 2009-09-07 Marek Safar <marek.safar@gmail.com>
764 * *.cs: Changed Report class to accept various output printers and
765 be an instance class. An expression resolver can now use different
766 message reporter for each call and Report.Error can safely throw
767 an exception. Part of ongoing work to turn mcs into proper library.
769 2009-09-04 Marek Safar <marek.safar@gmail.com>
771 * statement.cs, ecore.cs: Removed error reporting from emit code.
773 2009-09-04 Marek Safar <marek.safar@gmail.com>
775 * cs-parser.jay, parameter.cs: Moved parser check out of constructor
777 2009-09-03 Marek Safar <marek.safar@gmail.com>
779 * anonymous.cs, expression.cs, statement.cs, cs-parser.jay: Moved
780 parser checks out of constructors.
782 2009-09-02 Marek Safar <marek.safar@gmail.com>
784 * expression.cs, statement.cs, ecore.cs: Use common Report.Error.
786 2009-09-02 Marek Safar <marek.safar@gmail.com>
788 A fix for bug #535448
789 * anonymous.cs, class.cs: Copy return label between all contexts.
791 2009-09-02 Marek Safar <marek.safar@gmail.com>
793 A fix for bug #535395
794 * namespace.cs: Resolve context can be null.
796 2009-08-25 Marek Safar <marek.safar@gmail.com>
798 A fix for bug #533912
799 * generic.cs: Use correct context for constraints resolving.
801 2009-08-25 Marek Safar <marek.safar@gmail.com>
803 A fix for bug #532630
804 * driver.cs: Trim conditional symbols.
806 2009-08-25 Marek Safar <marek.safar@gmail.com>
808 * context.cs: New file.
810 * *.exe.sources, *.csproj: Updated.
812 2009-08-25 Marek Safar <marek.safar@gmail.com>
814 * generic.cs, parameter.cs, decl.cs, statement.cs, namespace.cs,
815 class.cs, generic-mcs.cs, codegen.cs: Add GetSignatureForError to
816 IMembercontext, some small cleanups.
818 2009-08-24 Marek Safar <marek.safar@gmail.com>
820 * *.cs: Split ResolveContext and EmitContext.
822 2009-08-24 Marek Safar <marek.safar@gmail.com>
824 * *.cs: Only ResolveContext implements IMemberContext.
826 2009-08-21 Marek Safar <marek.safar@gmail.com>
828 * *.cs: Renamed IResolveContext to IMemberContext.
830 2009-08-21 Marek Safar <marek.safar@gmail.com>
832 * *.cs: Detached ResolveContext from EmitContext.
834 2009-08-21 Marek Safar <marek.safar@gmail.com>
836 * codegen.cs: Moved flow-analysis to BlockContext.
838 2009-08-21 Marek Safar <marek.safar@gmail.com>
840 * *.cs: Detached BlockContext from EmitContext.
842 2009-08-20 Gonzalo Paniagua Javier <gonzalo@novell.com>
844 * statement.cs: avoid nullref when the return value of GetEnumerator()
845 does not contain any MoveNext() method.
847 2009-08-19 Marek Safar <marek.safar@gmail.com>
849 * *.cs: Removed IResolveContext::GenericDeclContainer.
851 2009-08-19 Marek Safar <marek.safar@gmail.com>
853 * class.cs, delegate.cs: Changed Delegate to be TypeContainer based.
855 2009-08-19 Marek Safar <marek.safar@gmail.com>
857 * generic.cs, iterators.cs, expression.cs, statement.cs, ecore.cs,
858 cs-parser.jay, attribute.cs, codegen.cs: Better error reports.
860 2009-08-18 Marek Safar <marek.safar@gmail.com>
862 * *.cs: Removed boolean fields from EmitContext.
864 2009-08-18 Marek Safar <marek.safar@gmail.com>
866 * *.cs: Add IResolveContext::IsStatic.
868 2009-08-18 Marek Safar <marek.safar@gmail.com>
870 * *.cs: Moved TopBlock's methods from EmitContext to TopBlock.
872 2009-08-17 Marek Safar <marek.safar@gmail.com>
874 * *.cs: Removed DeclContainer from EmitContext.
876 2009-08-17 Marek Safar <marek.safar@gmail.com>
878 * *.cs: Add IResolveContext::CurrentTypeParameters.
880 2009-08-14 Marek Safar <marek.safar@gmail.com>
882 * *.cs: Removed TypeContainer and ContainerType from EmitContext.
884 2009-08-14 Marek Safar <marek.safar@gmail.com>
886 * decl.cs, expression.cs, namespace.cs, ecore.cs, class.cs,
887 codegen.cs: Add IResolveContext::LookupExtensionMethod.
889 2009-08-13 Marek Safar <marek.safar@gmail.com>
891 * decl.cs: Look in PartialContainer for parent type parameters.
893 2009-08-13 Marek Safar <marek.safar@gmail.com>
895 * decl.cs, namespace.cs, ecore.cs, class.cs, attribute.cs,
896 codegen.cs: Add IResolveContext::LookupTypeParameter.
898 2009-08-13 Marek Safar <marek.safar@gmail.com>
900 * lambda.cs, expression.cs, statement.cs, namespace.cs, ecore.cs:
901 Moved resolved logic from Emit to Resolve.
903 2009-08-13 Marek Safar <marek.safar@gmail.com>
905 * parameter.cs, decl.cs, roottypes.cs, class.cs, attribute.cs,
906 codegen.cs: Reworked atttributes handling of ResolveContext.
908 2009-08-12 Marek Safar <marek.safar@gmail.com>
910 * decl.cs, ecore.cs, class.cs, attribute.cs, codegen.cs: Pushed
911 LookupNamespaceOrType to ResolveContext.
913 2009-08-12 Marek Safar <marek.safar@gmail.com>
915 * typemanager.cs, decl.cs, expression.cs, namespace.cs, ecore.cs,
916 class.cs: Removed unused parameters and methods.
918 2009-08-11 Marek Safar <marek.safar@gmail.com>
920 * generic.cs, lambda.cs, anonymous.cs, statement.cs, generic-mcs.cs,
921 codegen.cs: Finding the best common type of a set of expressions for
924 2009-08-07 Marek Safar <marek.safar@gmail.com>
926 * dynamic.cs, expression.cs: More dynamic conversions.
928 2009-08-06 Miguel de Icaza <miguel@novell.com>
930 * generic.cs: This loop was incorrect, it was increment ii, but
931 checking for `i'. This was a change introduced to fix #327497,
934 * class.cs: Catch another case for cs0533 error, fixes #324782.
936 2009-08-06 Rodrigo Kumpera <rkumpera@novell.com>
938 * typemanager.cs (GetGenericArguments): SRE returns null for
939 generic methods on type builder instances if they are not generic
940 themselves. For example, for Foo<int>::Bar() it returns null, but
941 not for Foo<int>::Bar<>() or Foo<int>::Bar<double>().
943 2009-08-05 Marek Safar <marek.safar@gmail.com>
945 * argument.cs, dynamic.cs, expression.cs, ecore.cs, class.cs,
946 delegate.cs: Work on dynamic binding.
948 2009-08-04 Marek Safar <marek.safar@gmail.com>
950 A second fix for bug #525342
951 * class.cs: Attach partial method attributes to method
954 2009-08-03 Marek Safar <marek.safar@gmail.com>
956 * typemanager.cs, parameter.cs, support.cs, class.cs: Dynamic type
959 * rootcontext.cs: Default to langversion v4.
961 2009-08-03 Marek Safar <marek.safar@gmail.com>
963 * pending.cs: Check return type before member info is set.
965 2009-08-03 Marek Safar <marek.safar@gmail.com>
967 * anonymous.cs: Fully initialize generic hoisted field expression.
969 2009-08-02 Miguel de Icaza <miguel@novell.com>
971 * cs-parser.jay: Flag variables declared on the interactive shell
972 as used to prevent the 168 warning about local variable not being
975 2009-07-31 Marek Safar <marek.safar@gmail.com>
977 * parameter.cs, dynamic.cs, support.cs, class.cs, delegate.cs,
978 attribute.cs: Emit dynamic export attribute.
980 2009-07-30 Marek Safar <marek.safar@gmail.com>
982 * expression.cs: More verifier work.
984 2009-07-29 Marek Safar <marek.safar@gmail.com>
986 * nullable.cs: Fixed SRE crash during corlib compilation.
988 2009-07-29 Marek Safar <marek.safar@gmail.com>
990 * generic.cs, typemanager.cs, decl.cs, iterators.cs, convert.cs,
991 nullable.cs, expression.cs, ecore.cs, class.cs, attribute.cs:
992 More TypeManager.TypeToCoreType needed.
994 2009-07-29 Marek Safar <marek.safar@gmail.com>
996 * anonymous.cs: Update after recent SRE fixes.
998 2009-07-28 Marek Safar <marek.safar@gmail.com>
1000 * typemanager.cs, expression.cs, ecore.cs, delegate.cs: Use correct
1001 version of GetFieldHandle for fields of generic types.
1003 2009-07-27 Marek Safar <marek.safar@gmail.com>
1005 * typemanager.cs, argument.cs, convert.cs, assign.cs, expression.cs,
1006 ecore.cs: Add TypeManager.IsDynamicType,
1007 PredefinedAttributes.Dynamic.
1009 2009-07-27 Marek Safar <marek.safar@gmail.com>
1011 A fix for bug #415375
1012 * expression.cs: Fixed object and reference type parameter
1015 2009-07-27 Marek Safar <marek.safar@gmail.com>
1017 A fix for bug #525342
1018 * class.cs: Attach partial method attributes to method
1021 2009-07-24 Marek Safar <marek.safar@gmail.com>
1023 * argument.cs, dynamic.cs, expression.cs, class.cs, attribute.cs:
1026 2009-07-24 Marek Safar <marek.safar@gmail.com>
1028 * anonymous.cs (MutateField): Add imported types handling.
1030 2009-07-23 Marek Safar <marek.safar@gmail.com>
1032 * expression.cs, delegate.cs: Moved arguments resolve into their
1033 counterparts expressions. Removed argument resolve from
1034 CollectionElementInitializer.
1036 2009-07-23 Marek Safar <marek.safar@gmail.com>
1038 A fix for bug #523683
1039 * convert.cs, delegate.cs: Use common overload mechanism for method
1040 group conversion check.
1042 2009-07-22 Marek Safar <marek.safar@gmail.com>
1044 A fix for bug #523899
1045 * generics.cs: Exact type inference with other bound types.
1047 2009-07-22 Raja R Harinath <harinath@hurrynot.org>
1049 Don't complain when the same type is implemented by the output
1050 assembly as well as multiple referenced assemblies
1051 * namespace.cs (RootNamespace.LookupTypeReflection): Add
1052 'must_be_unique' flag.
1053 (GlobalRootNamespace): Update to changes.
1054 (Namespace.LookupType): Pass 'must_be_unique' only when we don't
1055 already have a type in hand.
1057 2009-07-22 Marek Safar <marek.safar@gmail.com>
1059 * expression.cs: More verifier instrumentation.
1061 * statement.cs: Do proper throw expression conversion.
1063 2009-07-22 Marek Safar <marek.safar@gmail.com>
1065 A fix for bug #522789
1066 * expression.cs: Mutate invocation return type.
1068 2009-07-16 Marek Safar <marek.safar@gmail.com>
1070 * anonymous.cs: Split assignable and readonly generated variable
1073 2009-07-16 Marek Safar <marek.safar@gmail.com>
1075 A fix for bug #521671
1076 * statement.cs: Fixed crash when checking missing type.
1078 2009-07-16 Marek Safar <marek.safar@gmail.com>
1080 * typemanager.cs, generic.cs, argument.cs, linq.cs, convert.cs,
1081 assign.cs, expression.cs, statement.cs, support.cs, ecore.cs,
1082 class.cs, driver.cs: Work on dynamic binding.
1084 * dynamic.cs: New file.
1086 * *.sources, *.proj: Updated.
1088 2009-07-15 Marek Safar <marek.safar@gmail.com>
1090 * expression.cs (Conditional): Avoid double Resolve.
1092 2009-07-13 Marcus Griep <marcus@griep.us>
1094 * ecore.cs: Fix obscure bug with resolving members of interfaces
1095 that hide parent interface members. Fixes bug #444388 and corrects
1098 2009-07-13 Marek Safar <marek.safar@gmail.com>
1100 * expression.cs (LocalVariableReference): Bounce resolve.
1102 2009-07-10 Marek Safar <marek.safar@gmail.com>
1104 * typemanager.cs, lambda.cs, parameter.cs, convert.cs, anonymous.cs,
1105 expression.cs, literal.cs, ecore.cs, complete.cs: Moved internal
1108 * support.cs: New dynamic type wrapper.
1110 2009-07-08 Marek Safar <marek.safar@gmail.com>
1112 * ecore.cs, cs-parser.jay: Better error reporting for implicitly
1113 typed local variable.
1115 2009-07-06 Marek Safar <marek.safar@gmail.com>
1117 A fix for bug #519005
1118 * anonymous.cs: Use null_type as no return type placeholder.
1120 2009-07-02 Marek Safar <marek.safar@gmail.com>
1122 * generic.cs: Handle type inference of identical type parameters
1123 with different bounds.
1125 2009-07-01 Marek Safar <marek.safar@gmail.com>
1127 * expression.cs, class.cs: Events variance.
1129 * cs-parser.jay: Interface events error messages.
1131 2009-07-01 Marek Safar <marek.safar@gmail.com>
1133 * generic.cs, argument.cs: Updated type inference logic to C# 4.0.
1135 2009-06-29 Marek Safar <marek.safar@gmail.com>
1137 * parameter.cs, convert.cs, expression.cs, class.cs: Default
1138 parameter expression can be value-type New.
1140 * cs-parser.jay: Clean up too many parameter modifier boolean flags.
1142 2009-06-26 Marek Safar <marek.safar@gmail.com>
1144 * generic.cs, argument.cs, expression.cs, ecore.cs, cs-parser.jay:
1145 Implemented C# 4.0 named arguments.
1147 2009-06-24 Marek Safar <marek.safar@gmail.com>
1149 * typemanager.cs, parameter.cs, iterators.cs, convert.cs,
1150 expression.cs, ecore.cs, delegate.cs: Removed unnecessary ArgList
1151 parameter modifier. Also fixes bug #515497.
1153 2009-06-24 Marek Safar <marek.safar@gmail.com>
1155 * *.cs: Replaced ArrayList with Arguments in need of a nonsequential
1156 arguments expression to be implemented.
1158 *.sources: Add argument.cs
1160 2009-06-23 Marek Safar <marek.safar@gmail.com>
1162 * parameter.cs: Moved GetParameterIndexByName to base class.
1164 * expression.cs, statement.cs, ecore.cs, delegate.cs: Removed
1165 unused AType. Use argument's version of GetExpressionTree.
1167 2009-06-22 Marek Safar <marek.safar@gmail.com>
1169 * expression.cs, cs-parser.jay, attribute.cs, codegen.cs: Named
1172 2009-06-17 Marek Safar <marek.safar@gmail.com>
1174 A fix for bug #514096
1175 * class.cs: Allow IntPtr/UIntPtr fields to be volatile.
1177 2009-06-17 Marek Safar <marek.safar@gmail.com>
1179 * expression.cs: The first multi-dimensional array nested array
1180 initializers was not checked.
1182 * statement.cs (Switch): Fixed error message to reflect 2.0 changes.
1184 2009-06-17 Marek Safar <marek.safar@gmail.com>
1186 A fix for bug #513400
1187 * nullable.cs (EmitEquality): Operands emit could be simplified for
1188 built-in types when we now emit user operators differently.
1190 2009-06-16 Marek Safar <marek.safar@gmail.com>
1192 * ecore.cs: Report inaccessible delegate methods correctly.
1194 2009-06-16 Marek Safar <marek.safar@gmail.com>
1196 * parameter.cs, expression.cs, ecore.cs, class.cs, delegate.cs,
1197 cs-parser.jay: Implemented C# 4.0 optional parameters.
1199 2009-06-16 Marek Safar <marek.safar@gmail.com>
1201 * driver.cs: Removed broken DefineManifestResource.
1203 2009-06-16 Raja R Harinath <harinath@hurrynot.org>
1205 * Makefile [net_2_0_bootstrap]: Don't explicitly mention net_1_1.
1206 Use $(BOOTSTRAP_PROFILE) instead.
1208 2009-06-12 Jb Evain <jbevain@novell.com>
1210 * rootcontext.cs: add a Platform field.
1211 * driver.cs: handle /platform.
1212 * codegen.cs: pass the proper flags according to
1213 the platform when saving the assembly.
1215 2009-06-11 Marek Safar <marek.safar@gmail.com>
1217 * parameter.cs, const.cs, report.cs, cs-parser.jay, attribute.cs:
1218 Add optional parameters grammar.
1220 2009-06-10 Marek Safar <marek.safar@gmail.com>
1222 * eval.cs, anonymous.cs, report.cs, rootcontext.cs, cs-parser.jay,
1223 driver.cs: Split lang version and metadata version.
1225 2009-06-10 Marek Safar <marek.safar@gmail.com>
1227 * decl.cs: Better overload ctor collision error message.
1229 2009-06-05 Jb Evain <jbevain@novell.com>
1231 * driver.cs (EmbededResource): avoid using an internal method
1232 in gmcs to embed manifest resources.
1234 2009-06-04 Sebastien Pouliot <sebastien@ximian.com>
1236 * generic.cs, parameter.cs: Avoid using 'var' so we can bootstrap
1237 the compiler from older mono versions (like moon's bots)
1239 2009-06-04 Marek Safar <marek.safar@gmail.com>
1241 * namespace.cs (LookupTypeReflection): Ignore collisions between
1244 2009-06-04 Marek Safar <marek.safar@gmail.com>
1246 * codegen.cs: Enabled generic type forwarders.
1248 2009-06-04 Marek Safar <marek.safar@gmail.com>
1250 * dmcs.*: Add another version of SRE compiler.
1252 2009-06-03 Marek Safar <marek.safar@gmail.com>
1254 * generic.cs, typemanager.cs, parameter.cs, convert.cs,
1255 generic-mcs.cs: Fixed variant type conversions.
1257 2009-06-02 Marek Safar <marek.safar@gmail.com>
1259 A fix for bug #507863
1260 * codegen.cs: Fixes a crash on invalid string value attribute.
1262 2009-06-01 Marek Safar <marek.safar@gmail.com>
1264 A fix for bug #508334
1265 * typemanager.cs, parameter.cs, convert.cs, expression.cs, ecore.cs,
1266 cs-parser.jay: Fully import __arglist modifier.
1268 2009-05-29 Marek Safar <marek.safar@gmail.com>
1270 * generic.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs,
1271 delegate.cs, generic-mcs.cs: Rewrote type variance checks to
1272 actually work with closed generic types.
1274 2009-05-27 Alan McGovern <amcgovern@novell.com>
1276 * class.cs, decl.cs, delegate.cs, parameter.cs:
1277 Fix the build by replacing the use of 'var' with the actual type.
1279 2009-05-27 Marek Safar <marek.safar@gmail.com>
1281 * generic.cs, parameter.cs, decl.cs, ecore.cs, class.cs, delegate.cs
1282 cs-parser.jay, generic-mcs.cs: Report wrong variant types
1285 * driver.cs, rootcontext.cs, report.cs: Add 3.0 language version
1288 2009-05-26 Rodrigo Kumpera <rkumpera@novell.com>
1289 Marek Safar <marek.safar@gmail.com>
1291 A fix for bug #377509
1292 * parameter.cs: Use predefined and not empty name for implicit
1295 2009-05-21 Marek Safar <marek.safar@gmail.com>
1297 * class.cs: Don't report wrong warnings for event fields.
1299 2009-05-21 Marek Safar <marek.safar@gmail.com>
1301 A fix for bug #504667
1302 * class.cs: Check for static class using parent container instead of
1305 2009-05-08 Marek Safar <marek.safar@gmail.com>
1307 A fix for bug #496922
1308 * expression.cs: Always use temporary variable when using object
1311 2009-04-28 Marek Safar <marek.safar@gmail.com>
1313 A fix for bug #495112
1314 * class.cs (IsUnmanagedType): Handle recursive unmanaged types using
1317 2009-04-27 Miguel de Icaza <miguel@novell.com>
1319 * driver.cs: Add a flag to work as a replacement for CSC in VS.
1321 2009-04-24 Miguel de Icaza <miguel@novell.com>
1323 * complete.cs: No idea how gonzalo got a null in the list, but
1326 2009-04-24 Miguel de Icaza <miguel@novell.com>
1328 * complete.cs (CompletionElementInitializer): New completion class
1329 to support completing inside a C# 3 element initializer, so this
1330 allows completion for Silverlight situations where it is very
1333 new TextBlock () { Fo<TAB>
1335 (CompletionSimpleName): Expose the prefix that was
1336 passed to the simple name.
1338 * cs-parser.jay (object_or_collection_initializer): Add support
1339 for element_initializers.
1341 * expression.cs (CollectionOrObjectInitializers.DoResolve):
1342 special case completion expressions as this method aggressively
1343 collects data before it operates, and errors were being thrown
1344 earlier than we were able to complete.
1346 2009-04-23 Miguel de Icaza <miguel@novell.com>
1348 * eval.cs: Make getcompletions silent and enable debugging output
1349 if the -v option is passed.
1351 * namespace.cs (NamespaceEntry.CompletionGetTypesStartingWith):
1352 Consider looking up the namespace that matches the prefix being
1355 This is part of the support for allowing completions like:
1356 `System.Co<TAB>' to complete to System.Console.
1358 * complete.cs (CompletionSimpleName.AppendResults): Make this
1361 2009-04-21 Raja R Harinath <harinath@hurrynot.org>
1363 * cs-parser.jay (GetTokenName): Mark GENERATE_COMPLETION and
1364 COMPLETE_COMPLETION as internal.
1366 2009-04-17 Miguel de Icaza <miguel@novell.com>
1368 * complete.cs: Include namespace resolution in simple names as
1369 well as global types and types in the using scope in the
1372 * namespace.cs: Supporting infrastrcture to provide completions
1373 based on the current using scope.
1375 * eval.cs: Introduce an entry point that allows for initialization
1376 to return a list of the files passed on the command line.
1378 2009-04-14 Marek Safar <marek.safar@gmail.com>
1380 A fix for bug #494243
1381 * report.cs (SymbolRelatedToPreviousError): Fixed NRE.
1383 2009-04-13 Marek Safar <marek.safar@gmail.com>
1385 A fix for bug #493887
1386 * statement.cs: Don't skip string multi-section with default or
1387 null label when populating string hashtable.
1389 2009-04-06 Marek Safar <marek.safar@gmail.com>
1391 A fix for bug #492329
1392 * expression.cs (New): Load variable when assigning type parameter
1395 2009-04-06 Marek Safar <marek.safar@gmail.com>
1397 A fix for bug #488960
1398 * decl.cs: Compare MVAR types using non-null values.
1400 2009-03-27 Marek Safar <marek.safar@gmail.com>
1402 * typemanager.cs, expression.cs: Removed unused nullable checks.
1404 2009-03-27 Marek Safar <marek.safar@gmail.com>
1406 * *.cs: Removed some gmcs conditionals.
1408 2009-03-26 Marek Safar <marek.safar@gmail.com>
1410 * generic.cs, support.cs: Moved generics stuff out of support.cs
1412 2009-03-24 Marek Safar <marek.safar@gmail.com>
1414 * ecore.cs, expression.cs: Use queried type for MethodGroupExpr
1417 2009-03-23 Marek Safar <marek.safar@gmail.com>
1419 * attribute.cs: Consider all members for error reporting when
1420 checking named arguments.
1422 2009-03-23 Marek Safar <marek.safar@gmail.com>
1424 A fix for bug #487625
1425 * namespace.cs: Use a warning for all predefined type conflicts.
1427 2009-03-23 Marek Safar <marek.safar@gmail.com>
1429 A fix for bug #485706
1430 * statement.cs: Explicitly type catch type argument to pass verifier
1433 2009-03-22 Miguel de Icaza <miguel@novell.com>
1435 Initial support to provide code completion facilities to consumers
1436 of the evaluator API.
1438 * cs-tokenizer.cs (CompleteOnEOF): this new property is used to
1439 support the completion engine. When we reach the end of the
1440 input stream instead of returning EOF, when this flag is true the
1441 tokenizer instead produces:
1443 One GENERATE_COMPLETION token: this token then must be
1444 handled in the grammar at every point where the user
1445 would likely request a completion.
1447 As many COMPLETE_COMPLETION tokens as necessary. These
1448 tokens are generated to assist the parser in unwinding and
1449 producing a valid parse tree.
1451 The parser rules do not have to be perfect, the parser needs to be
1452 augmented with judicious use of GENERATE_COMPLETION tokens to
1453 improve the areas where we can provide completion and the parser
1454 needs to add support for COMPLETE_COMPLETION tokens in productions
1457 It is common to not have enough support for COMPLETE_COMPLETION
1458 under certain rules and that even if we generated the
1459 GENERATE_COMPLETION token that the resulting tree will be invalid
1460 due to the missing rules that support COMPLETE_COMPLETION.
1462 The final EOF token is produced by having the parser notify the
1463 tokenizer when it reaches the root production that the next token
1466 * support.cs (CompletionResult): New Exception. This exception
1467 is thrown to return the completion results when one of the special
1468 completion expressions is reached.
1470 This exception is thrown by the completing ExpressionStatements
1471 classes that live in complete.cs
1473 * complete.cs (CompletingExpression): a new base class for
1474 completing expressions. This derives from the
1475 ExpressionStatement class and not from Expression as it allows
1476 completion to happen not only where expressions are expected in
1477 the grammar, but also where statements are expected.
1479 (CompletionSimpleName): A new class used to provide completions
1480 for SimpleNames. This currently only resolves to local
1481 variables from the evaluator context (GetVars call).
1483 (CompletionMemberAccess): Implements support for completing member
1486 * cs-parser.jay: Add support for completion in a few places.
1488 * eval.cs (GetCompletions): New public API for the evaluator that
1489 returns a list of possible completions given the input. The
1490 return value is an array of completions
1492 * anonymous.cs (Compatible): If the exception thrown from the
1493 resolved expression is a CompletionResult exception let that one
1494 through instead of printing a diagnostic error in the try/catch.
1496 2009-03-22 Miguel de Icaza <miguel@novell.com>
1500 * driver.cs (Main): Use Environment.Exit to quit quickly and
1501 prevent the compiler from doing the usual wait for helper thread
1504 This is to prevent a slowdown that was reported by Gonzalo on
1507 2009-03-19 Marek Safar <marek.safar@gmail.com>
1509 * ecore.cs: Load build-in types directly instead of accessing
1512 2009-03-18 Marek Safar <marek.safar@gmail.com>
1514 * ecore.cs: Always use unbox.any when available.
1516 2009-03-18 Marek Safar <marek.safar@gmail.com>
1518 * class.cs: Always set TypeAttributes.BeforeFieldInit conditionally.
1520 2009-03-17 Marek Safar <marek.safar@gmail.com>
1522 * generic.cs: Removed obsolete version of type inference.
1524 2009-03-16 Marek Safar <marek.safar@gmail.com>
1526 * typemanager.cs, decl.cs, roottypes.cs, anonymous.cs, nullable.cs,
1527 expression.cs, rootcontext.cs, namespace.cs, ecore.cs, class.cs,
1528 delegate.cs, flowanalysis.cs, cs-parser.jay, driver.cs,
1529 attribute.cs, codegen.cs: Changed RootTypes to be ModuleContainer.
1531 2009-03-11 Marek Safar <marek.safar@gmail.com>
1533 A fix for bug #482996
1534 * anonymous.cs: Make sure we are not infering return type when
1535 checking type compatibility.
1537 2009-03-11 Marek Safar <marek.safar@gmail.com>
1539 * typemanager.cs, generic.cs, parameter.cs, decl.cs, const.cs,
1540 rootcontext.cs, namespace.cs, class.cs, delegate.cs, driver.cs,
1541 generic-mcs.cs, attribute.cs, codegen.cs: Maintain predefined
1542 attributes in their own structure. Needed when accessing their
1543 properties before they are resolved.
1545 2009-03-09 Marek Safar <marek.safar@gmail.com>
1547 * cs-tokenizer.cs: Optimized GetKeyword using an array instead of
1548 hashtable (~10x faster).
1550 * driver.cs: Removed wrong Reset.
1552 2009-03-08 Marek Safar <marek.safar@gmail.com>
1554 * class.cs: Use correct common base type for unmanaged delayed
1557 * rootcontext.cs: Wrap unhandled exception.
1559 2009-03-06 Raja R Harinath <harinath@hurrynot.org>
1561 Make SeekableStreamReader self-tuning and arbitrarily seekable
1562 * support.cs (SeekableStreamReader.ResetStream): New. Allocates
1564 (SeekableStreamReader.Position.set): Use it. Simplify logic
1565 which, as a side-effect, makes it arbitrarily-seekable. Tune the
1566 buffer size when the stream needs to be re-read from the beginning.
1568 2009-03-05 Marek Safar <marek.safar@gmail.com>
1570 A fix for bug #480100
1571 * parameter.cs: A parameter is not hoisted when used directly as ET.
1573 2009-03-04 Marek Safar <marek.safar@gmail.com>
1575 * statement.cs: Fixed an issue when using variable is of interface
1578 2009-03-03 Marek Safar <marek.safar@gmail.com>
1580 A fix for bug #480319
1581 * report.cs, driver.cs: Support -warnaserror-:<warning list> option.
1583 2009-03-03 Marek Safar <marek.safar@gmail.com>
1585 A fix for bug #480867
1586 * typemanager.cs, expression.cs, ecore.cs: Changed method group
1587 expression to have no valid type.
1589 2009-03-03 Marek Safar <marek.safar@gmail.com>
1591 A fix for bug #481258
1592 * class.cs: Set extension method flag in partial container.
1594 2009-03-03 Marek Safar <marek.safar@gmail.com>
1596 * statement.cs, typemanager.cs: Use expression for StringEmitter.
1598 * attribute.cs: Add sanity check.
1600 2009-02-27 Marek Safar <marek.safar@gmail.com>
1602 * class.cs: Add external constructor error.
1604 2009-02-26 Marek Safar <marek.safar@gmail.com>
1606 A fix for bug #475354
1607 * convert.cs, nullable.cs, expression.cs, statement.cs: Emit
1608 correctly user defined nullable equality operators.
1610 2009-02-25 Marek Safar <marek.safar@gmail.com>
1612 A fix for bug #479532
1613 * expression.cs: Implement NewInitialize::AddressOf.
1615 2009-02-25 Marek Safar <marek.safar@gmail.com>
1617 A fix for bug #413633
1618 * expression.cs: Iterate all base class-constraint types.
1620 2009-02-24 Marek Safar <marek.safar@gmail.com>
1622 A fix for bug #479209
1623 * literal.cs: Mutate null underlying type.
1625 2009-02-24 Marek Safar <marek.safar@gmail.com>
1627 A fix for bug #476295
1628 * convert.cs: Avoid wrapping implicitly convertible reference type.
1630 2009-02-23 Marek Safar <marek.safar@gmail.com>
1632 * iterators.cs: Create MemberName correctly.
1634 2009-02-23 Marek Safar <marek.safar@gmail.com>
1636 A fix for bug #478655
1637 * literal.cs: Check also underlying null type conversion.
1639 2009-02-21 Marek Safar <marek.safar@gmail.com>
1641 * generic.cs, ecore.cs, class.cs: Removed redundant AsAccessible.
1643 2009-02-20 Marek Safar <marek.safar@gmail.com>
1645 A fix for bug #477447
1646 * statement.cs: Add reference to correct parent storey when this
1647 is accessible from deep children storey (more than 1 level).
1649 2009-02-19 Marek Safar <marek.safar@gmail.com>
1651 A fix for bug #475860 by David Mitchell <dmitchell@logos.com>
1652 * class.cs: Define base type members before setting up member cache.
1654 2009-02-18 Marek Safar <marek.safar@gmail.com>
1656 A fix for bug #477378
1657 * nullable.cs, expression.cs, statement.cs: More precise null type
1660 2009-02-18 Marek Safar <marek.safar@gmail.com>
1662 A fix for bug #472805
1663 * typemanager.cs, namespace.cs: Import only visible extension method
1666 2009-02-18 Marek Safar <marek.safar@gmail.com>
1668 A fix for bug #476895
1669 * attribute.cs: Use correct resolve context for attribute type.
1671 2009-02-18 Marek Safar <marek.safar@gmail.com>
1673 A fix for bug #476266
1674 * anonymous.cs: Mutate multi-dimensional arrays.
1676 2009-02-18 Marek Safar <marek.safar@gmail.com>
1678 A fix for bug #476400
1679 * statement.cs, expression.cs: Removed wrong Dispose optimization.
1681 2009-02-18 Marek Safar <marek.safar@gmail.com>
1683 A fix for bug #476811
1684 * generics.cs: Fixed null-literal check.
1686 2009-02-17 Marek Safar <marek.safar@gmail.com>
1688 * typemanager.cs, convert.cs, flowanalysis.cs, driver.cs,
1689 expression.cs, ecore.cs, rootcontext.cs, eval.cs, class.cs: More
1690 messing with static variables.
1692 2009-02-16 Marek Safar <marek.safar@gmail.com>
1694 A fix for bug #475965
1695 * generics.cs: Check generic parameter type after extracting from
1698 2009-02-16 Marek Safar <marek.safar@gmail.com>
1700 A fix for bug #475823
1701 * convert.cs, expression.cs, literal.cs, ecore.cs, cfold.cs: Add
1704 2009-02-14 Marek Safar <marek.safar@gmail.com>
1706 * modifiers.cs, decl.cs, ecore.cs, class.cs, flowanalysis.cs:
1707 Simplified event field definition using backing field and not
1708 field builder directly.
1710 * expression.cs (EmitLdArg): Optimize fast paths.
1712 2009-02-13 Marek Safar <marek.safar@gmail.com>
1714 A fix for bug #475327
1715 * expression.cs (ArrayCreation): Don't mutate values optimized away.
1717 2009-02-13 Marek Safar <marek.safar@gmail.com>
1719 A fix for bug #475342
1720 * cs-parser.jay: Using 'super' instead of 'base' to call base
1721 constructor crashes compiler.
1723 2009-02-13 Marek Safar <marek.safar@gmail.com>
1725 A fix for bug #475354
1726 * expression.cs (Constantify): Add nullable types.
1728 * const.cs (EmitDecimalConstant): Avoid explicit cast.
1730 2009-02-12 Marek Safar <marek.safar@gmail.com>
1732 A fix for bug #475246
1733 * expression.cs: More broken flowanalysis hacking needed.
1735 2009-02-12 Marek Safar <marek.safar@gmail.com>
1737 * attribute.cs: Compare only ref/out array modifiers.
1739 2009-02-11 Marek Safar <marek.safar@gmail.com>
1741 * statement.cs: Use member cache when looking for foreach members.
1743 2009-02-11 Marek Safar <marek.safar@gmail.com>
1745 * expression.cs: Don't expose internal initializer types.
1747 * statement.cs: Check also explicit conversions for goto case.
1749 2009-02-11 Marek Safar <marek.safar@gmail.com>
1751 * convert.cs, statement.cs: Removed usage of IsAssignableFrom.
1753 2009-02-10 Marek Safar <marek.safar@gmail.com>
1755 * *.cs: Replace null-type with NullLiteral where appropriate.
1757 2009-02-09 Marek Safar <marek.safar@gmail.com>
1759 * expression.cs: Initializer of reference argument use temporary
1760 variable to be verifiable.
1762 * parameter.cs: Share EmitLdArg.
1764 2009-02-09 Marek Safar <marek.safar@gmail.com>
1766 A fix for bug #473559
1767 * class.cs: Fixed: Not reporting error about nested class with the
1770 2009-02-06 Scott Peterson <lunchtimemama@gmail.com>
1772 Contributed under the MIT/X11 license.
1774 * generic.cs: Added VerifyVariantTypeParameters which performs new
1775 variance verification logic. The old logic, based on the spec, was
1776 wrong because the spec is full of LIES!
1778 * generic-mcs.cs: Stubbed out the VerifyVariantTypeParameters method.
1780 *typemanager.cs: Moved variance verification logic to GenericTypeExpr.
1783 * ecore.cs: Added calls to the new variance verification logic.
1786 * delegate.cs: Removed calls to the old variance verification logic.
1788 2009-02-06 Marek Safar <marek.safar@gmail.com>
1790 * delegate.cs: Use cached Invoke method directly.
1792 2009-02-06 Marek Safar <marek.safar@gmail.com>
1794 * expression.cs: Emit expression tree for hoisted variable access.
1796 2009-02-04 Marek Safar <marek.safar@gmail.com>
1798 * namespace.cs: Add better extension class check.
1800 2009-02-05 Scott Peterson <lunchtimemama@gmail.com>
1802 * generic.cs: Fixed typeo (TypeParameter.Variacne).
1804 2009-02-04 Scott Peterson <lunchtimemama@gmail.com>
1806 This patch adds initial generic variance support to the compiler.
1807 It is contributed under the MIT/X11 license.
1809 * typemanager.cs: Modified ImplementsInterface to check variance.
1810 Added VerifyVariantTypeParameters which checks the specified type to see
1811 if it uses a variant type parameter as a type argument (which is not
1812 allowed). Added IsVariantOf which determins if the first type is a
1813 variant of the second. NOTE: This only supports reference types at
1814 the moment to conform with the current level of VM support. When the
1815 VM supports value types, this will follow step.
1817 * generic.cs: Added the Variance enum. Added a Variance property to
1818 TypeParameter and added variance support to definition phase. Added a
1819 Variance property to TypeParameterName. Also check to make sure that
1820 no variant types appear in generic method parameters.
1822 * cs-tokenizer.cs: Modified parse_less_than to tokenize the variance
1823 keywords if the langversion supports it.
1825 * parameter.cs: Added Parameter.VerifyNoVariantTypeParameters to ensure
1826 that variant types are only used in legal positions. Also added
1827 ParametersCompiled.VerifyNoVariantTypeParameters to check all of its
1830 * decl.cs: Construct TypeParameter with the variance information.
1832 * convert.cs: Checks variance in ImplicitReferenceConversionExists
1833 and ImplicitConversionStandard.
1835 * rootcontext.cs: Added new "Future" language version.
1837 * class.cs: In TypeContainer.DoDefineMembers, ensure that contravariant
1838 type parameters are not used as type arguments in interface inheritance.
1839 In MemberBase.DoMemberDependentChecks, ensure that contravariant type
1840 parameters are not used as method return types. In MemberBase.
1841 ResolveMemberType, ensure that variant type parameters are not used
1842 as type arguments. Also call VerifyNoVariantTypeParameters on every
1843 set of parameters which are resolved.
1845 * delegate.cs: Modified Delegate.Define to ensure that variant
1846 parameters are not used as type arguments and that a contravariant
1847 parameter is not used as the return type. Also call
1848 VerifyNoVariantTypeParameters on the delegate parameters.
1850 * cs-parser.jay: Modified grammar to support "in" and "out" keywords
1851 to specify generic variance.
1853 * driver.cs: Added support for LanguageVersion.Future in the form of
1854 "-langversion:future".
1856 * generic-mcs.cs: Stubbed out new members in generic.cs.
1858 2009-02-03 Marek Safar <marek.safar@gmail.com>
1860 * class.cs, generic.cs: Emit type parameter constraints for nested
1863 2009-02-02 Marek Safar <marek.safar@gmail.com>
1865 A fix for bug #471213
1866 * class.cs: Avoid emitting backing field for abstract event fields.
1868 2009-02-01 Marek Safar <marek.safar@gmail.com>
1870 A fix for bug #359731
1871 * cs-tokenizer.cs, cs-parser.jay: Correctly parse nested query
1874 2009-01-30 Marek Safar <marek.safar@gmail.com>
1876 A fix for bug #470767
1877 * statement.cs: Introduced BlockScopeExpression, needed when
1878 expression tree conversion has to emit scope variables.
1880 2009-01-29 Marek Safar <marek.safar@gmail.com>
1882 * class.cs: Remove duplicate CallingConvention.
1884 2009-01-29 Marek Safar <marek.safar@gmail.com>
1886 *.cs: Rename Parameters to ParametersCompiled and ParametersImported
1887 when I finally found the right naming convention.
1889 2009-01-29 Marek Safar <marek.safar@gmail.com>
1891 * cs-tokenizer.cs: Put back different open parens optimization.
1893 2009-01-28 Marek Safar <marek.safar@gmail.com>
1895 A fix for bug #470227
1896 * cs-tokenizer.cs: Remove too agressive parser optimization.
1898 2009-01-28 Marek Safar <marek.safar@gmail.com>
1900 A fix for bug #324319
1901 * class.cs: Remove too early base type resolve.
1903 2009-01-27 Marek Safar <marek.safar@gmail.com>
1905 A fix for bug #324319
1906 * ecore.cs: Explicitly type null when assigning to type argument to
1907 make pass verifier check.
1909 2009-01-27 Marek Safar <marek.safar@gmail.com>
1911 * anonymous.cs: Fixed recent regression when initializing captured
1914 2009-01-26 Marek Safar <marek.safar@gmail.com>
1916 A fix for bug #469019
1917 * anonymous.cs: Use all parent type parameters when instantiating
1918 nested generic storey.
1920 2009-01-26 Marek Safar <marek.safar@gmail.com>
1922 * expression.cs: Check for null instance methodgroup expression.
1924 2009-01-26 Marek Safar <marek.safar@gmail.com>
1926 A fix for bug #469244
1927 * cs-tokenizer.cs, cs-parser.jay: Fixed parsing of nullable type
1928 instance inside a conditional expression.
1930 2009-01-23 Marek Safar <marek.safar@gmail.com>
1932 * typemanager.cs, generic.cs, parameter.cs, decl.cs, anonymous.cs,
1933 expression.cs, report.cs, ecore.cs, attribute.cs: Use common
1934 GetElementType and HasElementType. IsValueType clean up.
1936 2009-01-23 Marek Safar <marek.safar@gmail.com>
1938 * nullable.cs: Use common EmitCall.
1940 * expression.cs: Emit constraint. for virtual calls only.
1942 2009-01-23 Marek Safar <marek.safar@gmail.com>
1944 * typemanager.cs, generic.cs, eval.cs, convert.cs, const.cs,
1945 expression.cs, statement.cs, rootcontext.cs, ecore.cs, class.cs,
1946 driver.cs, attribute.cs, enum.cs: Split IsValueType and IsStruct
1949 2009-01-22 Jb Evain <jbevain@novell.com>
1951 * anonymous.cs: make anonymous types' ToString implementation
1952 match what csc outputs.
1954 2009-01-21 Marek Safar <marek.safar@gmail.com>
1956 * typemanager.cs, ecore.cs, iterator.cs: TypeLookupExpression clean
1959 2009-01-17 Marek Safar <marek.safar@gmail.com>
1961 * convert.cs, ecore.cs: Explicitly casts type arguments to pass
1964 2009-01-16 Marek Safar <marek.safar@gmail.com>
1966 * nullable.cs (LiftedBinaryOperator): Check for all possible null
1969 2009-01-15 Marek Safar <marek.safar@gmail.com>
1971 A fix for bug #466634
1972 * statement.cs: Add reference for nested storey when only this
1975 2009-01-15 Marek Safar <marek.safar@gmail.com>
1977 A fix for bug #466474
1978 * codegen.cs: Emit SecurityPermissionAttribute when -unsafe option
1981 2009-01-15 Marek Safar <marek.safar@gmail.com>
1983 * iterators.cs, anonymous.cs, expression.cs, statement.cs, ecore.cs:
1984 Fixed nested stories parent referencing process. Also fixes #463985.
1986 2009-01-06 Marek Safar <marek.safar@gmail.com>
1988 * decl.cs, iterators.cs, expression.cs, statement.cs, doc.cs,
1989 class.cs, cs-parser.jay, codegen.cs: Clean up destructor
1990 implementation. Also fixes #463108.
1992 2009-01-05 Marek Safar <marek.safar@gmail.com>
1994 A fix for bug #416109
1995 * decl.cs: Issue correct CLSAttribute warning location.
1997 2009-01-05 Marek Safar <marek.safar@gmail.com>
1999 A fix for bug #456775
2000 * attribute.cs: Use attribute owner scope when resolving attribute
2003 2009-01-05 Marek Safar <marek.safar@gmail.com>
2005 A fix for bug #457257
2006 * decl.cs: Fixed incorrect member declaring type comparison.
2008 2009-01-05 Marek Safar <marek.safar@gmail.com>
2010 A fix for bug #460896
2011 * driver.cs: Handle /RES resources as embeddable.
2013 2009-01-05 Marek Safar <marek.safar@gmail.com>
2015 A fix for bug #462515
2016 * ecore.cs: Report inacessible members upwards.
2018 2009-01-05 Marek Safar <marek.safar@gmail.com>
2020 A fix for bug #463190, #463192
2021 * decl.cs, namespace.cs: Also import internal extension classes.
2023 2009-01-04 Marek Safar <marek.safar@gmail.com>
2025 A fix for bug #463415
2026 * generic.cs: Use right index for RemoveDependentTypes.
2028 2009-01-02 Marek Safar <marek.safar@gmail.com>
2030 A fix for bug #463196
2031 * expression.cs: Fixed enum to null comparison.
2033 2009-01-02 Marek Safar <marek.safar@gmail.com>
2035 A fix for bug #463121
2036 * nullable.cs: Fixed nullable user equality operator comparison.
2038 2009-01-02 Marek Safar <marek.safar@gmail.com>
2040 A fix for bug #462950
2041 * class.cs, decl.cs: Use full explicit name when defining automatic
2042 property backing field.
2044 2009-01-02 Marek Safar <marek.safar@gmail.com>
2046 A fix for bug #462592
2047 * pending.cs: Emit type arguments for generic proxy method.
2049 2008-12-30 Marek Safar <marek.safar@gmail.com>
2051 * expression.cs (As): Mutate all type arguments.
2053 2008-12-29 Marek Safar <marek.safar@gmail.com>
2055 A fix for bug #462622
2056 * anonymous.cs: Resolve anonymous type GetHashCode in unchecked
2059 2008-12-29 Marek Safar <marek.safar@gmail.com>
2061 A fix for bug #450782
2062 * ecore.cs: Consider more variables of form V.I to be fixed.
2064 2008-12-29 Marek Safar <marek.safar@gmail.com>
2066 A fix for bug #460712
2067 * typemanager.cs: Core types could be imported.
2069 2008-12-28 Marek Safar <marek.safar@gmail.com>
2071 A fix for bugs #460847, #460772, #458049, #457339, #447807
2072 * generic.cs, parameter.cs, lambda.cs, linq.cs, anonymous.cs
2073 statement.cs, ecore.cs, class.cs, delegate.cs, flowanalysis.cs
2074 cs-parser.jay, driver.cs: LINQ implementation upgrade to deal with
2075 user lambdas used inside query clauses.
2077 2008-12-18 Marek Safar <marek.safar@gmail.com>
2079 A fix for bug #460229
2080 * cs-tokenizer.cs: Ignore wrongly placed BOM markers.
2082 2008-12-18 Marek Safar <marek.safar@gmail.com>
2084 A fix for bug #459952
2085 * decl.cs, namespace.cs: Use common CheckAccessLevel.
2087 2008-12-18 Marek Safar <marek.safar@gmail.com>
2089 A fix for bug #459630
2090 * convert.cs: Enum to valuetype conversion is not allowed.
2092 2008-12-18 Marek Safar <marek.safar@gmail.com>
2094 A fix for bug #457087
2095 * generic.cs: Don't crash when constraint comes from type
2098 2008-12-16 Marek Safar <marek.safar@gmail.com>
2100 A fix for bug #459221
2101 * anonymous.cs, statement.cs: Delay only captured this
2104 2008-12-12 Marek Safar <marek.safar@gmail.com>
2106 A fix for bug #457489
2107 * anonymous.cs, statement.cs: Split anonymous storey instantiation
2108 and initialization to capture scope initializers correctly.
2110 2008-12-11 Marek Safar <marek.safar@gmail.com>
2112 * generic.cs, parameter.cs, expression.cs, statement.cs, doc.cs:
2113 ParameterReference refactoring.
2115 2008-12-03 Marek Safar <marek.safar@gmail.com>
2117 * typemanager.cs, namespace.cs, driver.cs: Allow ExtensionAttribute
2118 to be imported from any assembly.
2120 2008-12-03 Marek Safar <marek.safar@gmail.com>
2122 * parameter.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs
2123 statement.cs, class.cs, cs-parser.jay: Removed duplicate parameters
2124 from anonymous method and lambda expression.
2126 2008-12-01 Marek Safar <marek.safar@gmail.com>
2128 A fix for bug #448560
2129 * expression.cs (As): Box any generic type arguments to be
2132 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2134 Add tripwire for implicit conversion bugs
2135 * ecore.cs (MethodGroupExpr.Error_ArgumentCountWrong): New helper
2137 (MethodGroupExpr.OverloadResolve): Add sanity check between
2138 IsApplicable and VerifyArgumentsCompat.
2139 (VerifyArgumentsCompat): Report CS1501 where appropriate.
2141 2008-11-29 Raja R Harinath <harinath@hurrynot.org>
2143 Fix build break in System.Data_test
2144 * convert.cs (ImplicitConversionExists): Move NullLiteral
2146 (ImplicitStandardConversionExists): ... here.
2148 2008-11-28 Marek Safar <marek.safar@gmail.com>
2150 * literal.cs: Emit correctly explicit null to nullable cast.
2152 2008-11-28 Marek Safar <marek.safar@gmail.com>
2154 * ecore.cs, generics.cs: Fixed crash when type arguments fail to
2157 2008-11-28 Marek Safar <marek.safar@gmail.com>
2159 A fix for bug #449005
2160 * convert.cs, nullable.cs: Use only one implicit nullable
2163 2008-11-27 Marek Safar <marek.safar@gmail.com>
2165 * convert.cs, literal.cs: More Convert cleanup is needed.
2167 2008-11-27 Marek Safar <marek.safar@gmail.com>
2169 * decl.cs, class.cs: Fixed misleading error message.
2171 2008-11-26 Marek Safar <marek.safar@gmail.com>
2173 A fix for bug #449005
2174 * nullable.cs (EmitEquality): Disable optimization for user operator
2177 2008-11-25 Marek Safar <marek.safar@gmail.com>
2179 A fix for bug #447027
2180 * anonymous.cs (HoistedVariable): Cache also outer access to deal
2181 with context variables stored as expression instances.
2183 2008-11-25 Marek Safar <marek.safar@gmail.com>
2185 A fix for bug #447027
2186 * delegate.cs: Fixed delegate VerifyMethod logic.
2188 2008-11-24 Marek Safar <marek.safar@gmail.com>
2190 * ecore.cs, delegate.cs: MethodGroup expressions can be applicable
2193 2008-11-21 Marek Safar <marek.safar@gmail.com>
2195 * typemanager.cs, decl.cs, anonymous.cs, class.cs, enum.cs: Rewrote
2196 member type resolve to follow normal flow, instead of random
2199 2008-11-21 Marek Safar <marek.safar@gmail.com>
2201 * iterators.cs (GetEnumeratorStatement): Re-use already resolved
2204 2008-11-21 Marek Safar <marek.safar@gmail.com>
2206 * const.cs: Emit decimal array constant as literal.
2208 2008-11-20 Marek Safar <marek.safar@gmail.com>
2210 * iterators.cs, ecore.cs: Removed CurrentBlock statement.
2212 2008-11-19 Marek Safar <marek.safar@gmail.com>
2214 * eval.cs, location.cs, driver.cs (Location.SourceFiles): Turned
2215 into real property (saves 8 MB for corlib compilation).
2217 2008-11-19 Marek Safar <marek.safar@gmail.com>
2219 * generic.cs, lambda.cs, linq.cs, iterators.cs, anonymous.cs,
2220 nullable.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay
2221 generic-mcs.cs: Small cleanup of TypeArguments.
2223 2008-11-18 Marek Safar <marek.safar@gmail.com>
2225 * generic.cs, iterators.cs, anonymous.cs, nullable.cs, ecore.cs,
2226 expression.cs, namespace.cs, generic-mcs.cs, class.cs: Small cleanup
2227 of ConstructedType expression, renamed to GenericTypeExpr.
2229 2008-11-17 Marek Safar <marek.safar@gmail.com>
2231 A fix for bug #445303
2232 * location.cs (IsConditionalDefined): Handle undefined global
2235 2008-11-17 Marek Safar <marek.safar@gmail.com>
2237 A fix for bug #444678
2238 * expression.cs (TryReduceConstant): Always create new constant
2241 2008-11-17 Marek Safar <marek.safar@gmail.com>
2243 A fix for bug #444673
2244 * ecore.cs: Ignore open generic types when used as generic type
2247 2008-11-17 Marek Safar <marek.safar@gmail.com>
2249 A fix for bug #445458
2250 * expression.cs, cs-parser.jay: Don't crash when an expression
2253 2008-11-17 Marek Safar <marek.safar@gmail.com>
2255 A fix for bug #445464
2256 * expression.cs, cs-parser.jay: Fixed typeof of non-generic type
2257 inside unbound type.
2259 2008-11-14 Jb Evain <jbevain@novell.com>
2261 * driver.cs: ignore empty -nowarn argument such as
2262 the one in -nowarn:12,13,,.
2264 2008-11-13 Marek Safar <marek.safar@gmail.com>
2266 A fix for bug #444271
2267 * anonymous.cs: Rescan parent storeys when best candidate was
2270 2008-11-13 Marek Safar <marek.safar@gmail.com>
2272 * generic.cs, expression.cs, ecore.cs, cs-parser.jay: Removed
2273 useless UnboundTypeExpression.
2275 * attribute.cs: Do check obsolete attribute on generic types.
2277 2008-11-12 Marek Safar <marek.safar@gmail.com>
2279 A fix for bugs #425680, #400139
2280 * ecore.cs, expression.cs: Trying to do some almost_matched_members
2283 2008-11-11 Marek Safar <marek.safar@gmail.com>
2285 A fix for bug #435747
2286 * assign.cs, expression.cs: Cleanup New assignment to emit correcly
2287 compound value types assignment. Few micro optimizations added.
2289 2008-11-10 Marek Safar <marek.safar@gmail.com>
2291 A fix for bug #442610
2292 * anonymous.cs (MutateConstructor): More SRE hacking.
2294 2008-11-10 Marek Safar <marek.safar@gmail.com>
2296 A fix for bug #442579
2297 * ecore.cs: Also initialize expanded form of a method with 1 params
2300 2008-11-06 Marek Safar <marek.safar@gmail.com>
2302 * expression.cs (UnaryMutator): Do early l-side check.
2304 2008-11-05 Miguel de Icaza <miguel@novell.com>
2306 * codegen.cs (InitDynamic): also setup Assembly.Name like we do in
2307 Init, otherwise we would crash later on when checking for friend
2310 * eval.cs: Do not hide errors from invalid calls to LoadAssembly.
2311 Otherwise we never get any meaningful information as to what
2314 2008-11-05 Marek Safar <marek.safar@gmail.com>
2316 A fix for bug #436318
2317 * driver.cs, report.cs: Add -warnaserror:Wn to command line options.
2319 2008-11-05 Miguel de Icaza <miguel@novell.com>
2321 * namespace.cs: Turns out that it was a really bad idea to hide
2322 the errors for namespaces not found here in eval mode.
2324 * eval.cs: When we process using clauses, only enter those into
2325 the list of valid using clauses after they have been validated.
2327 The above change gives the proper semantics: it does not
2328 senselessly report the same errors with broken using statements by
2329 never storing them in the first place when they are invalid.
2331 2008-11-05 Marek Safar <marek.safar@gmail.com>
2333 A fix for bug #421839
2334 * cs-parser.jay: Remove expression from coalesce rule to force lower
2335 priority than the assignment operator.
2337 2008-11-05 Marek Safar <marek.safar@gmail.com>
2339 A fix for bug #437875
2340 * nullable.cs: Compile correctly method group operand used with null
2341 coalescing operator.
2343 2008-11-04 Marek Safar <marek.safar@gmail.com>
2345 A fix for bug #434589
2346 * expression.cs (Binary): Ignore lifted conversions when at least
2347 one operand is of reference type.
2349 2008-11-04 Marek Safar <marek.safar@gmail.com>
2351 * cs-parser.jay: Better syntax error report.
2353 2008-11-03 Marek Safar <marek.safar@gmail.com>
2355 A fix for bug #436792
2356 * cs-parser.jay: Use GetLocation to access location.
2358 2008-11-03 Marek Safar <marek.safar@gmail.com>
2360 A fix for bug #440774
2361 * cs-parser.jay: Also set current_array_type when parsing local
2364 2008-11-03 Marek Safar <marek.safar@gmail.com>
2366 A fix for bug #440785
2367 * expression.cs (As): Don't resolve self modifing expression
2370 2008-11-03 Marek Safar <marek.safar@gmail.com>
2372 A fix for bug #439447
2373 * cs-tokenizer.cs: Tokenize surrogates only where allowed.
2375 2008-11-03 Marek Safar <marek.safar@gmail.com>
2377 A fix for bug #437571
2378 * cs-parser.jay: Fixes internal error for invalid expression
2381 2008-10-17 Marek Safar <marek.safar@gmail.com>
2383 * ecore.cs: Resolve correctly ambiguous params delegate methods.
2385 2008-10-17 Marek Safar <marek.safar@gmail.com>
2387 * generic.cs, anonymous.cs: Simplified GetDeclarations.
2389 2008-10-17 Marek Safar <marek.safar@gmail.com>
2391 * cs-tokenizer.cs: More precise cast parsing.
2393 2008-10-16 Martin Baulig <martin@ximian.com>
2395 * anonymous.cs (AnonymousMethodStorey): Put back the
2396 `hoisted_locals' hashtable and use it in EmitType().
2398 2008-10-15 Marek Safar <marek.safar@gmail.com>
2400 * cs-tokenizer.cs, nullable.cs, expression.cs, statement.cs,
2401 cs-parser.jay: Tokenizer optimizations and memory reduction, saves
2404 2008-10-14 Marek Safar <marek.safar@gmail.com>
2406 * cs-tokenizer.cs: Add bool type to the list of valid cast tokens.
2408 2008-10-14 Marek Safar <marek.safar@gmail.com>
2410 * statement.cs: Mutate scope initializers.
2412 2008-10-14 Marek Safar <marek.safar@gmail.com>
2414 * expression.cs: Use typeless value for This constant.
2416 * ecore.cs: Access FieldInfo via GetConstructedFieldInfo.
2418 2008-10-14 Marek Safar <marek.safar@gmail.com>
2420 * cs-tokenizer.cs, cs-parser.jay: Unify context sensite keyword
2423 2008-10-13 Marek Safar <marek.safar@gmail.com>
2425 * cs-tokenizer.cs: Add missing alias qualifier and dotted generic
2428 2008-10-13 Marek Safar <marek.safar@gmail.com>
2430 * cs-tokenizer.cs, expression.cs, cs-parser.jay: Reworked parens
2431 parser and tokenizer. Fixes many ambiguities including #433258.
2433 2008-10-10 Marek Safar <marek.safar@gmail.com>
2435 * cs-parser.jay: Fixed missing accessor recovery.
2437 2008-10-10 Marek Safar <marek.safar@gmail.com>
2439 A fix for bug #433701
2440 * expression.cs: Better error message.
2442 2008-10-10 Marek Safar <marek.safar@gmail.com>
2444 * cs-parser.jay, expression.cs: Start reporting real parser errors.
2446 * Makefile: Disabled unused debug symbols.
2448 Also fixes: #320556, #321097, #321656, #321876, #351316
2450 2008-10-09 Miguel de Icaza <miguel@novell.com>
2452 * eval.cs: rename "<interactive>" to "{interactive}", to work
2453 around a requirement in the compiler that this be a valid
2454 filename, and in Windows it is not (433886).
2456 2008-10-09 Marek Safar <marek.safar@gmail.com>
2458 * cs-tokenizer.cs, cs-parser.jay: Fixed more subtle parser problems
2460 2008-10-08 Marek Safar <marek.safar@gmail.com>
2462 * cs-tokenizer.cs, eval.cs, anonymous.cs, statement.cs, class.cs
2463 cs-parser.jay: Generic type declaration and type arguments cleanup.
2465 2008-10-05 Marek Safar <marek.safar@gmail.com>
2467 * cs-parser.jay: Allow parsing weird array creation construct.
2469 2008-10-05 Marek Safar <marek.safar@gmail.com>
2471 * cs-parser.jay: Conflicts reduction.
2473 2008-10-04 Marek Safar <marek.safar@gmail.com>
2475 * cs-parser.jay: Conflicts reduction.
2477 2008-10-04 Raja R Harinath <harinath@hurrynot.org>
2480 * flowanalysis.cs (MyBitvector.MakeShared): Rename from 'Shared'
2481 property. Add a 'count' hint about the use of the shared vector.
2482 Ensure that we don't leak out dirty bits.
2483 (UsageVector.MergeChild): Throw away information about variables
2485 Based on patch and analysis by Moritz Kroll <Moritz.Kroll@gmx.de>.
2487 2008-10-03 Marek Safar <marek.safar@gmail.com>
2489 A fix for bug #431746
2490 * iterators.cs, anonymous.cs: Re-initialize hoisted iterator
2491 parameters when iterator is created.
2493 2008-10-03 Marek Safar <marek.safar@gmail.com>
2495 A fix for bug #431827
2496 * expression.cs: Fixed right based pointer arithmetic operations
2499 2008-10-03 Marek Safar <marek.safar@gmail.com>
2501 A fix for bug #353779
2502 * assign.cs, expression.cs: Fixed compound assignment conversions.
2504 2008-10-02 Marek Safar <marek.safar@gmail.com>
2506 A fix for bug #375262
2507 * statement.cs: Refactor ArrayForeach to be usable with string
2508 indexer. Optimized single dimentional arrays foreach.
2510 2008-10-02 Marek Safar <marek.safar@gmail.com>
2512 A fix for bug #431255
2513 * anonymous.cs, expression.cs: Removed broken optimization.
2515 2008-10-01 Marek Safar <marek.safar@gmail.com>
2517 * anonymous.cs: Use full type parameters of parent generic
2518 containers. Removed unnecessary AddParentStoreyReference call.
2520 2008-10-01 Marek Safar <marek.safar@gmail.com>
2522 A fix for bug #324702
2523 * class.cs: Use better shorter names for explicit interface member
2526 * ecore.cs, typemanager.cs: Convert only mscorlib predefined names.
2528 2008-10-01 Marek Safar <marek.safar@gmail.com>
2530 * expression.cs: Use new interface to check fixed expression.
2532 2008-10-01 Marek Safar <marek.safar@gmail.com>
2534 A fix for bug #421101
2535 * expression.cs, statement.cs, ecore.cs: Use IFixedExpression
2536 interface to check for fixed fixed-buffers.
2538 2008-10-01 Marek Safar <marek.safar@gmail.com>
2540 A fix for bug #429264
2541 * assign.cs, anonymous.cs, ecore.cs: More type mutators added.
2543 * delegate.cs: Removed unnecessary casts.
2545 2008-09-30 Marek Safar <marek.safar@gmail.com>
2547 A fix for bug #352151
2548 * decl.cs, iterators.cs, anonymous.cs, report.cs, namespace.cs,
2549 class.cs: Fixed already defined explicit interface members check.
2551 2008-09-29 Rodrigo Kumpera <rkumpera@novell.com>
2553 cs-tokenizer.cs: Fix typo.
2555 2008-09-28 Miguel de Icaza <miguel@novell.com>
2557 * eval.cs (InteractiveBase): The quit command now just sets a
2558 flag, instead of calling Environment.Exit(), it is milder on
2561 CompiledMethod is now in Mono.CSharp, not nested inside
2562 the Evaluator, it was inconvenient to use.
2564 2008-09-27 Miguel de Icaza <miguel@novell.com>
2566 * eval.cs (Evaluator): Introduce Compile method, to allow compiled
2567 code to be invoked without having to reparse.
2569 2008-09-27 Miguel de Icaza <miguel@novell.com>
2571 * ecore.cs: The recent changes to FieldExpr broke this as well.
2572 Fixes LINQ queries in the interactive shell.
2574 * Multiple files: indentation fixing for the Mono coding
2575 guidelines for the switch statement.
2577 * eval.cs: Make the Evaluator API thread safe.
2579 2008-09-26 Marek Safar <marek.safar@gmail.com>
2581 * anonymous.cs, statement.cs, class.cs, cs-parser.jay: Simplified
2582 constructor parsing.
2584 2008-09-26 Marek Safar <marek.safar@gmail.com>
2586 A fix for bug #325326
2587 * statement.cs: Check possible mistaken empty statement using
2588 explicit blocks only.
2590 2008-09-25 Miguel de Icaza <miguel@novell.com>
2592 * eval.cs (LoadAssembly, ReferenceAssembly): Call
2593 RootNamespace.ComputeNamespaces to update the internal list of
2594 namespaces, this is no longer done for us.
2596 (InteractiveBase): Use the Evaluator APIs instead of calling into
2599 2008-09-25 Marek Safar <marek.safar@gmail.com>
2601 A fix for bug #429264
2602 * expression.cs: Missing mutator for access to multidimensional
2605 2008-09-25 Marek Safar <marek.safar@gmail.com>
2607 * class.cs, statement: Emit DebuggerHidden attribute for iterator
2610 * driver.cs: Missing input argument check.
2612 2008-09-25 Marek Safar <marek.safar@gmail.com>
2614 * typemanager.cs, generic.cs, eval.cs, decl.cs, anonymous.cs,
2615 expression.cs, statement.cs, rootcontext.cs, class.cs,
2616 cs-parser.jay, driver.cs, generic-mcs.cs, enum.cs: Removed obsolete
2619 2008-09-24 Miguel de Icaza <miguel@novell.com>
2621 * ecore.cs (FieldExpr): Only initialize eclass when we return a
2622 fully constructed FieldExpr, fixes the regression introduced in
2625 * ecore.cs, expression.cs: Plug back the eclass initialization as
2626 otherwise it regresses `csharp'.
2628 2008-09-24 Marek Safar <marek.safar@gmail.com>
2630 * typemanager.cs, decl.cs, convert.cs, assign.cs, expression.cs,
2631 ecore.cs, attribute.cs: Moved obsolete method checks from emit
2632 phase to resolve phase. It resolves problems with expression trees
2633 and fixes bugs #323796, #325156.
2635 2008-09-23 Marek Safar <marek.safar@gmail.com>
2637 * codegen.cs: Report better error when symbol writer is missing.
2639 2008-09-23 Marek Safar <marek.safar@gmail.com>
2641 * codegen.cs: Set .NET symbol writer.
2643 * decl.cs: Guard against null generic arguments.
2645 * report.cs: Don't report exactly same additional details.
2647 2008-09-22 Marek Safar <marek.safar@gmail.com>
2649 A fix for bug #324917
2650 * cs-parser.jay: Add missing multidimensional non-expression type
2653 2008-09-22 Marek Safar <marek.safar@gmail.com>
2655 A fix for bug #428191
2656 * anonymous.cs: Create an outer generic fields also for non-storey
2659 2008-09-22 Marek Safar <marek.safar@gmail.com>
2661 A fix for bug #378294
2662 * class.cs: Make fixed size buffers gmcs feature only.
2664 2008-09-22 Marek Safar <marek.safar@gmail.com>
2666 A fix for bug #355622, #324993
2667 * assign.cs, const.cs, class.cs: Create new EmitContext for each
2670 2008-09-19 Marek Safar <marek.safar@gmail.com>
2672 * nullable.cs, expression.cs, namespace.cs, delegate.cs: Duplicate
2675 2008-09-19 Marek Safar <marek.safar@gmail.com>
2677 A fix for bug #416110
2678 * generic.cs: Struct constraint results in default ctor and
2679 ValueType base type constraint to be set.
2681 2008-09-19 Marek Safar <marek.safar@gmail.com>
2683 A fix for bug #423791
2684 * generic.cs: Fixed params output type type-inference.
2686 2008-09-19 Marek Safar <marek.safar@gmail.com>
2688 * cs-parser.jay, expression.cs: Fixed few expression crashes.
2690 2008-09-19 Marek Safar <marek.safar@gmail.com>
2692 * cs-tokenizer.cs: Don't break on extra partial modifier.
2694 2008-09-19 Marek Safar <marek.safar@gmail.com>
2696 A fix for bug #427592
2697 * generic.cs: Use common parameter resolve method.
2699 2008-09-18 Marek Safar <marek.safar@gmail.com>
2701 A fix for bug #414758
2702 * expression.cs, ecore.cs: Fixed crash when accessing non-static
2705 2008-09-18 Marek Safar <marek.safar@gmail.com>
2707 * driver.cs, namespace.cs: Read types and namespaces after all
2708 requested assemblies are loaded, fixes issues with System.Core
2709 auto-reference, and #419888.
2711 2008-09-18 Marek Safar <marek.safar@gmail.com>
2713 A fix for bug #417705
2714 * cs-parser.jay: Fixed as/is operator expression split.
2716 2008-09-18 Marek Safar <marek.safar@gmail.com>
2718 * const.cs, expression.cs, statement.cs, ecore.cs, cs-parser.jay:
2719 Fixed expression tree representation of empty new expression and
2720 new initializer expression.
2722 2008-09-18 Miguel de Icaza <miguel@novell.com>
2724 * eval.cs: Remove warning, keep reference to driver around.
2726 * Hide fields that do not need to be public.
2728 2008-09-17 Marek Safar <marek.safar@gmail.com>
2730 A fix for bug #426385
2731 * expression.cs (ImplicitlyTypedArrayCreation): Use full implicit
2732 conversion for array elements.
2734 2008-09-17 Marek Safar <marek.safar@gmail.com>
2736 * expression.cs, statement.cs, class.cs, cs-parser.jay: Fixed
2737 void parsing conflicts.
2739 2008-09-15 Marek Safar <marek.safar@gmail.com>
2741 A fix for bug #425601
2742 * driver.cs, typemanager.cs, namespace.cs: Automatically reference
2743 System.Core only when there is no custom ExtensionAttribute
2746 2008-09-15 Miguel de Icaza <miguel@novell.com>
2748 * namespace.cs: Do not report CS0246 (name
2750 2008-09-12 Marek Safar <marek.safar@gmail.com>
2752 A fix for bug #425669
2753 * generic.cs: Don't cache generic static anonymous method
2756 2008-09-12 Marek Safar <marek.safar@gmail.com>
2758 * generic.cs, class.cs, delegate.cs: Check recursive inherited
2759 conflicting constraints.
2761 2008-09-12 Raja R Harinath <harinath@hurrynot.org>
2763 * cs-tokenizer.cs (consume_identifier): Allow partial methods in
2766 2008-09-12 Marek Safar <marek.safar@gmail.com>
2768 * literal.cs, convert.cs, expression.cs, statement.cs: More null
2769 to null pointer conversion fixes.
2771 2008-09-11 Marek Safar <marek.safar@gmail.com>
2773 * cs-parser.jay, expression.cs: An implicitly typed local variable
2774 declarator cannot use an array initializer.
2776 2008-09-11 Marek Safar <marek.safar@gmail.com>
2778 * cs-parser.jay: Reduced number of printed tokens, add sorting.
2780 2008-09-11 Marek Safar <marek.safar@gmail.com>
2782 * generic.cs (InflatedConstraints): Don't crash when constraints
2785 * cs-parser.jay: const_declarator is a block.
2787 * constant.cs: Check for not allowed NaN conversions.
2789 2008-09-10 Miguel de Icaza <miguel@novell.com>
2791 * driver.cs: Drop --shell argument, the compiler is no longer a
2794 * eval.cs: Move most of the code that deals with evaluation into
2795 this file and document the public API from repl.cs
2797 * repl.cs: Remove from here.
2799 2008-09-10 Marek Safar <marek.safar@gmail.com>
2801 A fix for bug #424684
2802 * generic.cs: Generic class constraints must come first.
2804 2008-09-09 Miguel de Icaza <miguel@novell.com>
2806 * cs-parser.jay: Improve error reporting for syntax errors in
2807 statements and expressions, we now report the expected tokens
2808 instead of reporting the useless "; expected".
2810 Drop the strings from the token declaration, it turns out that
2811 they did not do what I thought they did. Instead they were adding
2812 two sets of tokens to the tables.
2814 2008-09-09 Marek Safar <marek.safar@gmail.com>
2816 * typemanager.cs, generic.cs, parameter.cs, expression.cs, class.cs,
2817 delegate.cs: Share special type check.
2819 2008-09-09 Marek Safar <marek.safar@gmail.com>
2821 A fix for bug #423981
2822 * expression.cs (EmitBranchable): Correctly emit inverted float conditions.
2824 2008-09-09 Marek Safar <marek.safar@gmail.com>
2826 * ecore.cs (ReducedConstantExpression): Implemented ConvertExplicitly and
2829 2008-09-09 Marek Safar <marek.safar@gmail.com>
2831 A fix for bugs: #324750, #335946
2832 * cs-tokenizer.cs, cs-parser.jay, expression.cs: Use a custom
2833 lookup rule to determine ?-based tokens.
2835 2008-09-08 Miguel de Icaza <miguel@novell.com>
2837 * repl.cs (OptionalAssign.EmitStatement): It is possible that some
2838 expressions (like event adding or removing) end up here, so we
2839 need to treat those as statements.
2841 Add LoadAssembly method.
2843 2008-09-04 Miguel de Icaza <miguel@novell.com>
2845 * repl.cs: Add Time method.
2847 2008-09-05 Marek Safar <marek.safar@gmail.com>
2849 * cs-tokenizer.cs: Fixed swaped UTF-16 surrogates parsing.
2851 2008-09-05 Miguel de Icaza <miguel@novell.com>
2853 * repl.cs: Add workaround for old compilers.
2855 2008-09-04 Jb Evain <jbevain@novell.com>
2857 * repl.cs (PrettyPrint): pretty print everything that
2858 implements IDictionary, as well as IEnumerables. Also,
2859 add a quit helper property.
2861 2008-09-04 Marek Safar <marek.safar@gmail.com>
2863 * constant.cs: Better error reporting for decimal literals.
2865 * class.cs, attribute.cs, typemanager.cs: Emit more fixed buffer
2868 2008-09-04 Marek Safar <marek.safar@gmail.com>
2869 Miguel de Icaza <miguel@novell.com>
2871 A fix for bug #422951
2872 * assign.cs (Assign.DoResolve): Perform the type conversions
2873 checks before we attempt to initialize `New' initializers.
2875 2008-09-04 Marek Safar <marek.safar@gmail.com>
2877 A fix for bug #422853
2878 * delegate.cs (DelegateCreation): Add special handling for
2879 EmptyExpression.Null instance expression which is just another
2880 hack for undecided member instance exression.
2882 2008-09-04 Marek Safar <marek.safar@gmail.com>
2884 * expression.cs, ecore.cs: Emit full expression tree for reduced
2887 2008-09-04 Marek Safar <marek.safar@gmail.com>
2889 * expression.cs (This): Guard against multi-resolving.
2891 * ecore.cs, statement.cs (Throw): Simplified.
2893 * flowanalysis.cs: Also verify event fields.
2895 2008-09-04 Miguel de Icaza <miguel@novell.com>
2897 * assign.cs (Assign.DoResolve): Perform the type conversions
2898 checks before we attempt to initialize `New' initializers.
2900 * repl.cs (PrettyPrint): Add Hashtable prettyprint
2902 * anonymous.cs (AnonymousTypeClass): On EvalMode make the class
2905 * repl.cs: Update help.
2907 2008-09-03 Miguel de Icaza <miguel@novell.com>
2909 * driver.cs (ProcessDefaultConfig): Now it encapsulates all the
2910 handling of the default config handling, including the special
2911 treatment of System.Core assembly.
2913 Fixes the REPL processing for LINQ.
2915 2008-09-03 Marek Safar <marek.safar@gmail.com>
2917 A fix for bug #422507
2918 * expression.cs (UnboxCast): Add missing child expression mutator.
2920 2008-09-03 Marek Safar <marek.safar@gmail.com>
2922 * driver.cs: Don't self reference System.Core assembly.
2924 2008-09-03 Marek Safar <marek.safar@gmail.com>
2926 A fix for bug #422507
2927 * expression.cs (StringConcat): Add missing type mutator.
2929 2008-09-03 Marek Safar <marek.safar@gmail.com>
2931 * generic.cs (TypeInferenceContext): Follow equality rule for
2932 constructed type lower bound type inference.
2934 2008-09-02 Miguel de Icaza <miguel@novell.com>
2936 * getline.cs (CmdRefresh): Apply patch from Douglas S. Blank
2937 <dblank@cs.brynmawr.edu> which updates the cursor position on
2940 2008-09-02 Marek Safar <marek.safar@gmail.com>
2942 A fix for bug #367145
2943 * driver.cs: Fixed import of extension methods when using -noconfig
2946 2008-09-02 Marek Safar <marek.safar@gmail.com>
2948 * iterator.cs: Don't emit GetEnumerator method twice but call a generic
2949 version from non-generic implementation instead.
2951 2008-09-01 Marek Safar <marek.safar@gmail.com>
2953 A fix for bug #418908
2954 * class.cs: Use AddScopeStatement for field initializers.
2956 2008-09-01 Marek Safar <marek.safar@gmail.com>
2958 A fix for bug #415385
2959 * ecore.cs, convert.cs: Do method group conversion for equal group types.
2961 2008-09-01 Marek Safar <marek.safar@gmail.com>
2963 A fix for bug #421736
2964 * iterators.cs: Don't crash on unreachable iterators.
2966 2008-09-01 Marek Safar <marek.safar@gmail.com>
2968 A fix for bug #421628
2969 * parameter.cs, attribute.cs: Clone also parameter attributes.
2971 2008-08-30 Miguel de Icaza <miguel@novell.com>
2973 * namespace.cs (LookupType): In EvalMode, try to replace
2974 the TypeBuilder from our cache with a Type as Reflection.Emit does
2975 not like to mix code from older assemblies emitted and new
2978 This sounds like a serious Mono bug that prevents multiple
2979 assemblies to be generated and consumed at the same time.
2981 * cs-parser.jay (push_current_class): Do not make interactive
2982 classes internal or private, make them public as we currently
2983 generate each new class in a new assembly.
2985 2008-08-29 Miguel de Icaza <miguel@novell.com>
2987 * decl.cs, roottypes.cs, class.cs:: Add an infrastructure to
2988 remove types that are entered into the global namespace during
2989 parsing so that we can remove them on failure.
2991 * cs-parser.jay: Parsing: we now keep track of types that are
2992 entered into global variables and queue those in case the parsing
2995 This happens in a few situations: during partial-input, we invoke
2996 the parser repeatedly for example with the string "class X", this
2997 would cause X to be registed, and we need to remove this
2998 registration so that another parse attempt later with say "class X {"
2999 would actually work.
3001 Additionally, if there is an error in the resolution phase, for
3002 example: "class X : NonExistant {}" th
3004 * cs-parser.jay: Be more precise with the errors being raised,
3005 instead of flagging all exceptions during parsing to be attributed
3006 to the parsing process, distinguish those from errors happening in
3007 the actions and hint that using -v would produce the actual
3010 * repl.cs: Do not load all compiler references on each reset,
3011 doing the partial reset takes care of this.
3013 2008-08-28 Miguel de Icaza <miguel@novell.com>
3015 * repl.cs: Add support for loading all the files from
3016 ~/.config/csharp/*cs as startup scripts and ~/.config/csharp/*.dll
3019 Introduce a micro-parser that is able to deambiguate on its input
3020 whether we are dealing with a compilation unit (namespace, class,
3021 interface, struct, delegate) declaration or a statement. This
3022 allows both declarations and statements to be entered.
3024 Set history size by default to 300 lines.
3026 Instead of distinguishing based on the parser.InteractiveResult,
3027 have only two cases: statements were parsed, or a compilation unit
3028 was. Always pull the Using statement additions from the
3029 compilation unit parse.
3031 * cs-tokenizer.cs: Rename tokens to better describe their intent
3032 (EvalStatementParserCharacter and EvalCompilationUnitParserCharacter).
3034 * rootcontext.cs: Split EvalMode into EvalMode and StatementMode.
3035 EvalMode is used to trigger the lookup of global variables while
3036 StatementMode is used turn variable declarations into static
3039 * getline.cs: Allow history size to be set.
3041 2008-08-29 Marek Safar <marek.safar@gmail.com>
3043 A fix for bug #360755
3044 * ecore.cs (SimpleName): Exclude indexers from simple name resolve.
3046 2008-08-29 Marek Safar <marek.safar@gmail.com>
3048 * generic.cs, iterators.cs, codegen.cs: Removed unused variable.
3050 * typemanager.cs, statement.cs, ecore.cs, enum.cs: Don't reconstruct enum
3051 member name, it is too confusing
3053 * decl.cs, class.cs: Don't report unused fields with attached attribute.
3055 * rootcontext.cs: Finally default to warning level 4.
3057 2008-08-28 Marek Safar <marek.safar@gmail.com>
3059 * class.cs (CheckBase): Ignore overloaded operators.
3061 2008-08-28 Marek Safar <marek.safar@gmail.com>
3063 A fix for bug #420830
3064 * expression.cs, cs-parser.jay: Put back InvocationOrCast expression.
3066 2008-08-28 Marek Safar <marek.safar@gmail.com>
3068 A fix for bug #420832
3069 * anonymous.cs, iterators.cs: Also clone hoisted this iterator variable.
3071 2008-08-28 Marek Safar <marek.safar@gmail.com>
3073 A fix for bug #420386
3074 * nullables.cs: Fixed logic of nullable user comparison operators involving
3077 2008-08-28 Marek Safar <marek.safar@gmail.com>
3079 * attribute (IsClsCompliant): Use FALSE value for pointer types.
3081 2008-08-27 Miguel de Icaza <miguel@novell.com>
3083 * repl.cs: Add support for aborting the running code with C-c.
3085 2008-08-27 Raja R Harinath <harinath@hurrynot.org>
3087 * cs-parser.jay (CS1002): Dump 'yyToken' with Report.ExtraInformation.
3089 2008-08-27 Miguel de Icaza <miguel@novell.com>
3091 * cs-parser.jay (interactive_statement_list): A new set of rules
3092 for hosting statements that uses the "interactive_" prefix.
3094 * repl.cs: Add support for parsing `using' as a statement or as a
3095 directive. Deambiguating before passing this to the parser.
3097 We need to distinguish statement_expressions that occur at the
3098 toplevel vs those that occur embedded into expressions.
3100 * getline.cs: Applied patch from Stuart Carnie <stuart.carnie@gmail.com>
3101 that fixes the cursor key handling, and a history bug.
3103 2008-08-26 Miguel de Icaza <miguel@novell.com>
3105 * Makefile: Drop BOOTSTRAP_COMPILER as that was masking the
3106 limitations in Console, instead the 2.0 bootstrap libraries now
3107 include the Console bits.
3109 Also, remove the use of Nullables from getline.cs
3113 Interactive support for the C# compiler. Use gmcs --shell to
3114 enter a read-eval-print loop shell.
3116 Docs: http://www.mono-project.com/CsharpRepl
3118 * sources: include repl.cs here and getline.cs for gmcs.exe,
3119 everything else is getline.cs impaired.
3121 * Makefile: when bootstrapping pass a special flag
3122 BOOTSTRAP_COMPILER which we use to prevent failures in compilation
3123 as we use NET_2_0 define to pull 2.0 APIs from System.Console.
3124 This distinguishes those two cases.
3126 * repl.cs: Support for a read-eval-print loop. Will be soon
3127 refactored into eval support and then REPL on top of it.
3129 * ecore.cs: If a simplename lookup fails, before erroring out,
3130 if we are in EvalMode to resolve the name to a declaration in the
3133 This means that variable declarations that happened in previous
3134 classes (as repl puts every statement in a separate class) are
3135 made visible in this way.
3137 * cs-parser.jay: UnexpectedEOF, a new flag that is set if we
3138 triggered an error due to the end of file being reached. This is
3139 used to do multi-line input, and notify the caller that the user
3140 needs to provide more text before a successful parse.
3142 Add new grammar rules after the INTERACTIVE_PARSER token is seen
3143 to drive the evaluation with a custom wrapper.
3145 * driver.cs: Add support for --shell, and refactor some code to be
3148 * namespace.cs: Add support for serializing the contents of the
3149 namespaces and reloading them.
3151 * getline.cs: A managed implementation of ReadLine under
3152 X11/Apache2 license terms. Easy to embed in other applications as
3155 * namespace.cs: Add some functions to save and restore the
3158 * rootcontext.cs: New public field.
3160 * cs-tokenizer.cs: Add support for one of the possible characters
3161 we introduce into the token stream.
3163 This patch does not affect the regular tokenization process, the
3164 only performance hit would happen if there is an invalid character
3165 on the input string.
3167 * support.cs: Move isatty helper routine here.
3169 * codegen.cs: Small cleanup, and add a mechanism to initialize the
3170 code generator for in-memory assemblies.
3172 2008-08-26 Marek Safar <marek.safar@gmail.com>
3174 * generic.cs, ecore.cs, delegate.cs, cs-parser.jay, expression.cs: A type
3175 parameter cannot be always used as a type.
3177 2008-08-21 Marek Safar <marek.safar@gmail.com>
3179 * convert.cs, expression.cs: Use single ExplicitReferenceConversion routine.
3181 2008-08-21 Marek Safar <marek.safar@gmail.com>
3183 * convert.cs: Implement explicit array to IList<T> conversion.
3185 2008-08-20 Marek Safar <marek.safar@gmail.com>
3187 A fix for bug #362740
3188 * cs-tokenizer.cs: Handle UTF-16 surrogates.
3190 2008-08-20 Marek Safar <marek.safar@gmail.com>
3192 * generic.cs, support.cs, typemanager.cs, lambda.cs, parameter.cs,
3193 pending.cs, ecore.cs, linq.cs, class.cs, decl.cs, delegate.cs,
3194 flowanalysis.cs, iterators.cs, cs-parser.jay, convert.cs, anonymous.cs,
3195 expression.cs, attribute.cs, statement.cs, doc.cs: Refactored parameters
3196 handling to use just one type of infrastructure and deal with generics
3199 2008-07-23 Martin Baulig <martin@ximian.com>
3201 *** Merged this from trunk revision 108527 ***
3204 (ExplicitBlock.EmitSymbolInfo): Moved to `ToplevelBlock'.
3205 (ToplevelBlock.EmitSymbolInfo): Tell the symbol writer about the
3208 2008-08-15 Marek Safar <marek.safar@gmail.com>
3210 * ecore.cs, linq.cs, const.cs, expression.cs, statement.cs: More robust
3213 2008-08-15 Marek Safar <marek.safar@gmail.com>
3215 * delegate.cs: Fixed compiler crash when creating delegate using partial
3218 * typemanager.cs: MulticastDelegate is not a delegate.
3220 2008-08-14 Marek Safar <marek.safar@gmail.com>
3222 * expression.cs, ecore.cs, anonymous.cs, class.cs: Fixed missing error
3225 2008-08-14 Raja R Harinath <harinath@hurrynot.org>
3227 * cs-parser.jay (type): Allow 'var' in mcs too.
3228 (local_variable_type): Likewise.
3230 2008-08-14 Marek Safar <marek.safar@gmail.com>
3232 * driver.cs: Removed broken -noconfig variants.
3234 2008-08-14 Marek Safar <marek.safar@gmail.com>
3236 A fix for bug #417078
3237 * expression.cs: Emit correctly left side pointer operators.
3239 2008-08-13 Marek Safar <marek.safar@gmail.com>
3241 * generic.cs, lambda.cs: Inflate method generic arguments only.
3243 2008-08-12 Marek Safar <marek.safar@gmail.com>
3245 * class.cs: Fixed struct layout check regression.
3247 2008-08-12 Marek Safar <marek.safar@gmail.com>
3249 * cs-parser.jay, enum.cs: Simplified enum parsing.
3251 * decl.cs: Check all type parameters conflicts.
3253 * expression.cs, statement.cs, attribute.cs: More expression checks.
3255 2008-08-11 Marek Safar <marek.safar@gmail.com>
3257 * generic.cs: Add type inference types restriction.
3259 * parameter.cs, class.cs, delegate.cs, iterators.cs, cs-parser.jay,
3260 anonymous.cs, expression.cs: Allocate less accessor parameters.
3262 2008-08-08 Marek Safar <marek.safar@gmail.com>
3264 * typemanager.cs, ecore.cs: Ambiguous operators can come from different
3267 2008-08-08 Marek Safar <marek.safar@gmail.com>
3269 * convert.cs, delegate.cs: Fixed delegate compatibility conversion.
3271 2008-08-07 Marek Safar <marek.safar@gmail.com>
3273 * class.cs, decl.cs, iterator.cs, ecore.cs: Refactor base type resolving.
3274 Also fixes #362146 and #381592.
3276 2008-08-07 Marek Safar <marek.safar@gmail.com>
3278 * ecore.cs: Reduced constant cannot be used as an attribute value.
3280 * cs-parser.jay: Base expression has to be a type.
3282 * expression.cs (Conditional): Uses ReducedExpression.
3284 2008-08-06 Marek Safar <marek.safar@gmail.com>
3286 A fix for bug #376826
3287 * parameter.cs, ecore.cs, anonymous.cs, expression.cs, statement.cs: An
3288 address of hoisted local variable or parameter cannot be taken.
3290 2008-08-05 Marek Safar <marek.safar@gmail.com>
3292 * ecore.cs, constant.cs, expression.cs, statement.cs: Resolve correctly
3293 anonymous method inside checked/unchecked expression.
3295 2008-08-05 Marek Safar <marek.safar@gmail.com>
3297 * typemanager.cs (IsEqual): Guard against null.
3299 * ecore.cs, class.cs, convert.cs, const.cs, constant.cs, expression.cs,
3300 attribute.cs, enum.cs, statement.cs: Pass EmitContext to constant conversion
3301 routine. Fixed few misleading conversion errors.
3303 2008-08-04 Marek Safar <marek.safar@gmail.com>
3305 * class.cs: Consider generics when checking cycles in struct layout.
3307 2008-08-04 Raja R Harinath <harinath@hurrynot.org>
3309 * cs-tokenizer.cs (get_cmd_arg): Simplify. Don't be too pedantic.
3311 2008-08-04 Marek Safar <marek.safar@gmail.com>
3313 A fix for bug #414165
3314 * anonymous.cs: Use same anonymous implementation method for all anonymous
3317 2008-08-04 Marek Safar <marek.safar@gmail.com>
3319 * generic.cs, anonymous.cs, statement.cs: Emit inherited anonymous method
3322 2008-08-04 Marek Safar <marek.safar@gmail.com>
3324 * cs-parser.jay: Typeof argument has to be a type expression.
3326 * namespace.cs: Check alias and namespace definitions collisions.
3328 * class.cs, pending.cs: Moved explicit interface accessor implementation
3331 * delegate.cs, expression.cs: Verify special name invocations.
3333 2008-08-01 Marek Safar <marek.safar@gmail.com>
3335 * cs-parser.jay: Don't choke on empty generic type arguments.
3337 * cs-tokenizer.cs: Handle escaped preprocessor directives.
3339 * expression.cs, ecore.cs: Minor expressions bugs.
3341 2008-08-01 Marek Safar <marek.safar@gmail.com>
3343 * cs-parser.jay: Removed duplicate interface declaration (fixes 2 conflicts)
3344 and added more error handling.
3346 * class.cs, iterators.cs, anonymous.cs: Removed useless interface parameter.
3348 * modifiers.cs, enum.cs: Fixed.
3350 2008-07-31 Jb Evain <jbevain@novell.com>
3352 * driver.cs: remove -pkg ability of smcs.
3354 2008-07-30 Marek Safar <marek.safar@gmail.com>
3356 * statement.cs (Switch): Correctly set empty default target for single
3359 2008-07-30 Marek Safar <marek.safar@gmail.com>
3361 * typemanager.cs, assign.cs, driver.cs, expression.cs, statement.cs: Rewrote
3362 string switch statement implementation to use string dictionary which
3363 significantly (2-8x) improves performance of generated code.
3365 2008-07-29 Marek Safar <marek.safar@gmail.com>
3367 A fix for bug #412880 by Atsushi Enomoto <atsushi@ximian.com>
3368 * modifiers.cs (GetDescription): Fixed FamANDAssem case.
3370 2008-07-29 Marek Safar <marek.safar@gmail.com>
3372 A fix for bug #412595
3373 * typemanager.cs, convert.cs, expression.cs: Some types are never
3374 convertible to each other.
3376 2008-07-29 Marek Safar <marek.safar@gmail.com>
3378 * nullable.cs (CreateNullConstant): An error messages update.
3380 2008-07-29 Marek Safar <marek.safar@gmail.com>
3382 A fix for bug #412595
3383 * cfold.cs: Don't cast undefined bool constant.
3385 2008-07-29 Martin Baulig <martin@ximian.com>
3388 (SymbolWriter.Reset): New public static method.
3391 (CompilerCallableEntryPoint.Reset): Call SymbolWriter.Reset().
3393 2008-07-28 Marek Safar <marek.safar@gmail.com>
3395 * cs-tokenizer.cs (IsLambdaOpenParens): Optimized using more stop tokens.
3397 * expression.cs (ElementAccess): Exact size allocation.
3399 2008-07-26 Marek Safar <marek.safar@gmail.com>
3401 * driver.cs: Replaced outdated UnixParseOption with CSCParseOption.
3403 2008-07-25 Marek Safar <marek.safar@gmail.com>
3405 * flowanalysis.cs (StructInfo): Fixed detection of dynamic types.
3407 * class.cs: Removed $PRIVATE$ field hack which caused problems during
3410 2008-07-25 Marek Safar <marek.safar@gmail.com>
3412 A fix for bug #412217
3413 * assign.cs: Mutate also assignment type.
3415 2008-07-25 Marek Safar <marek.safar@gmail.com>
3417 A fix for bug #323644
3418 * typemanager.cs (IsValidProperty): Verify DefaultMemberName when checking
3421 2008-07-25 Marek Safar <marek.safar@gmail.com>
3423 A fix for bug #412134
3424 * expression.cs (ResolveOperatorEnum): Do implicit conversion of
3425 non-enumerable operands when overloading equality or bitwise operators.
3427 2008-07-25 Marek Safar <marek.safar@gmail.com>
3429 * anonymous.cs: Cache closed generic anonymous method delegates.
3431 2008-07-24 Marek Safar <marek.safar@gmail.com>
3433 * lambda.cs, linq.cs, class.cs, iterators.cs, cs-parser.jay, assign.cs,
3434 anonymous.cs, statement.cs: Always emit anonymous method as static method
3435 when is instance free. Use nesting for nested anynomous methods blocks.
3437 2008-07-23 Marek Safar <marek.safar@gmail.com>
3439 * anonymous.cs (MutateGenericMethod): Added extra code path for imported
3442 2008-07-23 Marek Safar <marek.safar@gmail.com>
3444 * expression.cs: Removed MakeSimpleCall.
3446 2008-07-23 Marek Safar <marek.safar@gmail.com>
3448 A fix for bug #323012
3449 * class.cs, pending.cs: Emit proxy for indexers when they differ in name.
3450 Base method implementing interface has to be public.
3452 2008-07-23 Marek Safar <marek.safar@gmail.com>
3454 * cs-parser.jay: Don't break on missing argument.
3456 2008-07-22 Marek Safar <marek.safar@gmail.com>
3458 A fix for bug #320993
3459 * report.cs, parameter.cs, class.cs, decl.cs, delegate.cs, attribute.cs,
3460 enum.cs, codegen.cs: Report CLS compliance errors as warnings.
3462 2008-07-22 Marek Safar <marek.safar@gmail.com>
3464 A fix for bug #320748
3465 * convert.cs: Implicit user operators cannot convert to interfaces
3467 2008-07-22 Marek Safar <marek.safar@gmail.com>
3469 A fix for bug #312686
3470 * driver.cs: Ignore empty assembly references.
3472 2008-07-22 Marek Safar <marek.safar@gmail.com>
3474 A fix for bug #387040
3475 * ecore.cs: Skip constrains check for an explicit implementation.
3477 2008-07-21 Marek Safar <marek.safar@gmail.com>
3479 A fix for bug #409045
3480 * cs-tokenizer.cs, rootcontext.cs, class.cs, location.cs, delegate.cs,
3481 cs-parser.jay, driver.cs, expression.cs, attribute.cs: Conditional
3482 identifiers are file specific unless passed as input arguments.
3484 2008-07-21 Marek Safar <marek.safar@gmail.com>
3486 * typemanager.cs, parameter.cs, class.cs, attribute.cs: Use an attribute
3487 to emit UnmanagedMarshal data under 2.0 profile.
3489 2008-07-21 Marek Safar <marek.safar@gmail.com>
3491 A fix for bug #410369
3492 * parameter.cs: Clone correctly ParamsParameter.
3494 2008-07-21 Marek Safar <marek.safar@gmail.com>
3496 * expression.cs (Argument): Always report type for type based expressions
3499 2008-07-18 Marek Safar <marek.safar@gmail.com>
3501 A fix for bug #410666
3502 * anonymous.cs: Correctly initialize generic storey reference.
3504 2008-07-18 Marek Safar <marek.safar@gmail.com>
3506 * convert.cs: Don't box same type arguments.
3508 2008-07-18 Marek Safar <marek.safar@gmail.com>
3510 * ecore.cs, linq.cs, delegate.cs, constant.cs, nullable.cs, expression.cs:
3511 Finished missing generic type mutators.
3513 2008-07-18 Marek Safar <marek.safar@gmail.com>
3515 * iterators.cs, statement.cs: Finished statements CloneTo.
3517 2008-07-18 Marek Safar <marek.safar@gmail.com>
3519 * anonymous.cs: ExpressionTreeProxy is of Value type expression.
3521 * expression.cs: Emit optimized default value expressions in expression tree
3524 2008-07-18 Marek Safar <marek.safar@gmail.com>
3526 * ecore.cs, cs-parser.jay, statement.cs: Error reporting fixes.
3528 2008-07-17 Marek Safar <marek.safar@gmail.com>
3530 A fix for bug #367536
3531 * cs-parser.jay: Check static constructor of generic types for an access
3534 2008-07-17 Marek Safar <marek.safar@gmail.com>
3536 A fix for bug #353800
3537 * lambda.cs: Emit ret for contextual statements.
3539 * codegen.cs: Keep both resolved and unreachable flags, otherwise we end
3540 up emitting redundant ret for all anonymous methods with return.
3542 2008-07-17 Marek Safar <marek.safar@gmail.com>
3544 A fix for bug #365188
3545 * ecore.cs, anonymous.cs, expression.cs, codegen.cs, statement.cs: Don't
3546 create anonymous method storey in unreachable block.
3548 2008-07-17 Marek Safar <marek.safar@gmail.com>
3550 * generic.cs, typemanager.cs, cs-tokenizer.cs, parameter.cs, namespace.cs,
3551 class.cs, delegate.cs, flowanalysis.cs, iterators.cs, anonymous.cs,
3552 driver.cs, nullable.cs, expression.cs, attribute.cs, codegen.cs,
3553 statement.cs: Fixed relevant defects found by Gendarme.
3555 2008-07-17 Marek Safar <marek.safar@gmail.com>
3557 A fix for bug #325291
3558 * modifiers.cs, class.cs, cs-parser.jay, anonymous.cs, codegen.cs,
3559 statement.cs: Replaced IAnonymousHost with top level block flag.
3561 2008-07-17 Marek Safar <marek.safar@gmail.com>
3563 * cs-parser.jay: Clean up unused open_parens.
3565 2008-07-17 Marek Safar <marek.safar@gmail.com>
3567 * ecore.cs: Custom error message for a range variable assignment.
3569 2008-07-16 Marek Safar <marek.safar@gmail.com>
3571 * constant.cs, typemanager.cs: Emit empty string ("") as string.Empty field
3574 2008-07-16 Marek Safar <marek.safar@gmail.com>
3576 * literal.cs: Null literal is of object type.
3578 2008-07-16 Marek Safar <marek.safar@gmail.com>
3580 * nullable.cs (LiftedBinaryOperator): Always lift unwrapped nullable
3581 expression of nullable equality comparison.
3583 2008-07-15 Marek Safar <marek.safar@gmail.com>
3585 * expression.cs(PointerArithmetic): Removed redundant assignment.
3587 2008-07-15 Marek Safar <marek.safar@gmail.com>
3589 * decl.cs (GetSignatureForError): Report full namespace name for containers.
3591 2008-07-14 Marek Safar <marek.safar@gmail.com>
3593 A fix for bug #408361
3594 * anonymous.cs (MutateGenericMethod): Store generic type arguments before
3595 they are replaced by GetMethod.
3597 2008-07-14 Marek Safar <marek.safar@gmail.com>
3599 A fix for bug #408721 by jeremie.laval@gmail.com
3600 * expression.cs (Indirection): Implemented CloneTo.
3602 2008-07-14 Marek Safar <marek.safar@gmail.com>
3604 * statement.cs (AssignableSlots): Temporary disabled variable initialization
3607 2008-07-14 Marek Safar <marek.safar@gmail.com>
3609 * report.cs (EnableReporting): Don't reinitialize 0-based values.
3611 2008-07-11 Marek Safar <marek.safar@gmail.com>
3613 * linq.cs: Reset tranparent parameter counter in probing mode.
3615 2008-07-11 Marek Safar <marek.safar@gmail.com>
3617 * anonymous.cs: Mutate anonymous method type.
3619 2008-07-11 Marek Safar <marek.safar@gmail.com>
3621 * ecore.cs, anonymous.cs: Mutate field expressions.
3623 2008-07-10 Marek Safar <marek.safar@gmail.com>
3625 A fix for bug #369670
3626 * linq.cs, statement.cs: Use explicit block for query expressions variables.
3628 2008-07-10 Marek Safar <marek.safar@gmail.com>
3630 * report.cs, ecore.cs: Flush recorder only when silent mode is off.
3632 2008-07-10 Raja R Harinath <harinath@hurrynot.org>
3635 * cs-tokenizer.cs (is_punct): If a generic lookahead is looking
3636 only one '>', and finds a '>>', abort the generic lookahead.
3638 2008-07-10 Marek Safar <marek.safar@gmail.com>
3640 A fix for bug #319902
3641 * cs-tokenizer.cs: Always look-ahed for `>=' when tokenizing `>'.
3643 2008-07-10 Marek Safar <marek.safar@gmail.com>
3645 A fix for bug #406371
3646 * statement.cs: Moved EmitSymbolInfo to Block.
3648 2008-07-09 Marek Safar <marek.safar@gmail.com>
3650 * ecore.cs: Report better error for extension method overload failures.
3652 2008-07-09 Marek Safar <marek.safar@gmail.com>
3654 * expression.cs (Is): No need to box reference values.
3656 2008-07-09 Marek Safar <marek.safar@gmail.com>
3658 * class.cs: Use event resolve context when initializing CreateEmitContext.
3660 2008-07-09 Marek Safar <marek.safar@gmail.com>
3662 A fix for bug #394436
3663 * anonymous.cs, class.cs, expression.cs, lambda.cs: Emit correctly extension
3664 method used inside expression trees. Added more LINQ to expression tree
3667 2008-07-08 Marek Safar <marek.safar@gmail.com>
3669 A fix for bug #378189, #370577
3670 * lambda.cs, ecore.cs: Implemented 3.0 enhancement to better conversion
3673 2008-07-08 Marek Safar <marek.safar@gmail.com>
3675 * anonymous.cs, class.cs, decl.cs: Emit CompilerGenerated attribute
3678 2008-07-08 Marek Safar <marek.safar@gmail.com>
3680 A fix for bug #406702
3681 * anonymous.cs: Always park anonymous method in the nearest parent storey.
3683 2008-07-07 Marek Safar <marek.safar@gmail.com>
3685 A fix for bug #406648
3686 * cs-parser.jay: Report nullable use in mcs for some cases.
3688 2008-07-07 Marek Safar <marek.safar@gmail.com>
3690 * ecore.cs: Improved argument mismatch error messages.
3692 2008-07-07 Marek Safar <marek.safar@gmail.com>
3694 * anonymous.cs: Don't cache generic delegates when reference MVAR argument.
3696 2008-07-07 Marek Safar <marek.safar@gmail.com>
3698 * expression.cs (TypeOf): Mutate type argument.
3700 2008-07-04 Marek Safar <marek.safar@gmail.com>
3702 * class.cs: Report missing partial modifier for correct type.
3704 2008-07-04 Marek Safar <marek.safar@gmail.com>
3706 * ecore.cs, expression.cs (VariableReference): Variable property is
3709 2008-07-04 Marek Safar <marek.safar@gmail.com>
3711 * ecore.cs, convert.cs: Made OpcodeCast more memory efficient.
3713 2008-07-04 Marek Safar <marek.safar@gmail.com>
3715 * anonymous.cs, class.cs, lambda.cs, iterator.cs: Cache static anonymous
3718 2008-07-04 Marek Safar <marek.safar@gmail.com>
3720 * anonymous.cs, class.cs, expression.cs, iterator.cs, statement.cs: Reduce
3721 anonymous method storey to an instance method when only "this" is hoisted.
3723 2008-07-03 Marek Safar <marek.safar@gmail.com>
3725 A fix for bug #321615
3726 * expression.cs: Pointer comparisons use unsigned operator.
3728 2008-07-03 Marek Safar <marek.safar@gmail.com>
3730 * expression.cs: Fixed native pointer conversions. Also fixes #321615.
3732 2008-07-02 Marek Safar <marek.safar@gmail.com>
3734 A fix for bug #404905
3735 * class.cs: Always initialize local unsafe variables.
3737 2008-06-30 Marek Safar <marek.safar@gmail.com>
3739 A fix for bug #396987
3740 * expression.cs (NewInitialize): Clear local temporary variable for next run
3742 2008-06-27 Marek Safar <marek.safar@gmail.com>
3744 A fix for bug #401020
3745 * ecore.cs: Both types and modifiers have to match for ref and out arguments
3747 2008-06-27 Marek Safar <marek.safar@gmail.com>
3749 A fix for bug #398319
3750 * cs-parser.jay: Implemented undocumented base access expression inside
3753 2008-06-26 Marek Safar <marek.safar@gmail.com>
3755 A fix for bug #404227
3756 * cs-parser.jay: Parse namespace declaration using qualified identifier.
3758 2008-06-26 Marek Safar <marek.safar@gmail.com>
3760 A fix for bug #404227
3761 * convert.cs: Fixed explicit array to interface cast.
3763 2008-06-26 Marek Safar <marek.safar@gmail.com>
3765 A fix for bug #403894
3766 * delegate.cs: Mutate DelegateInvocation type.
3768 2008-06-26 Marek Safar <marek.safar@gmail.com>
3770 A fix for bug #379348
3771 * delegate.cs: Box a load of generic parameters.
3773 2008-06-26 Marek Safar <marek.safar@gmail.com>
3775 * expression.cs: Add an array creation arguments mutate.
3777 2008-06-26 Marek Safar <marek.safar@gmail.com>
3779 A fix for bug #386068
3780 * anonymous.cs, expression.cs: Emit correctly hoisted expression tree
3783 2008-06-25 Marek Safar <marek.safar@gmail.com>
3785 * ecore.cs, expression.cs: Fixed broken TypeCast clone, implemented few more
3788 2008-06-25 Marek Safar <marek.safar@gmail.com>
3790 A fix for bug #403518
3791 * delegate.cs: Type correctly anonymous method new invocation.
3793 2008-06-24 Marek Safar <marek.safar@gmail.com>
3795 A fix for bug #394826
3796 * anonymous.cs: Fully qualify members when resolving anonymous type internal
3799 2008-06-24 Marek Safar <marek.safar@gmail.com>
3801 A fix for bug #394826
3802 * anonymous.cs, iterators.cs: Construct generic storey only when is really
3805 2008-06-24 Marek Safar <marek.safar@gmail.com>
3807 * class.cs: Clone indexer parameters for localized capturing.
3809 2008-06-24 Marek Safar <marek.safar@gmail.com>
3811 A fix for bug #402379
3812 * expression.cs: Don't crash when an object initializer resolve fails.
3814 2008-06-24 Marek Safar <marek.safar@gmail.com>
3816 A fix for bug #402888
3817 * expression.cs: Mutate conditional expression.
3819 2008-06-24 Marek Safar <marek.safar@gmail.com>
3821 A fix for bug #401012
3822 * class.cs: Keep StructLayout in shared container.
3824 2008-06-24 Marek Safar <marek.safar@gmail.com>
3826 A fix for bug #400438
3827 * decl.cs, class.cs: Only properties can be automatically implemented.
3829 2008-06-24 Marek Safar <marek.safar@gmail.com>
3831 * statement.cs (ChangeToIterator): Copy also labels.
3833 2008-06-23 Marek Safar <marek.safar@gmail.com>
3835 * ecore.cs: Pass type argument details to parent extension method.
3837 2008-06-23 Marek Safar <marek.safar@gmail.com>
3839 A fix for bug #375966
3840 * delegate.cs: Fixed IsTypeCovariant generic type conversions.
3842 2008-06-23 Raja R Harinath <harinath@hurrynot.org>
3844 * Makefile (bootstrap-libs): Pass NO_DIR_CHECK to sub-make.
3846 2008-06-22 Marek Safar <marek.safar@gmail.com>
3848 A fix for bug #394347
3849 * anonymous.cs: Cache compatible delegates as compatibility check produces
3850 a new method every time.
3852 2008-06-20 Marek Safar <marek.safar@gmail.com>
3854 * anonymous.cs: Propagate storey reference for single references.
3856 2008-06-20 Marek Safar <marek.safar@gmail.com>
3858 A fix for bug #387615
3859 * assign.cs, expression.cs: Correctly clone compound assignment.
3861 2008-06-19 Marek Safar <marek.safar@gmail.com>
3863 A fix for bug #359611, #359604
3864 * anonymous.cs: Mutate all types of hoisted parameters.
3866 2008-06-19 Marek Safar <marek.safar@gmail.com>
3868 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, linq.cs, class.cs
3869 delegate.cs, iterators.cs, cs-parser.jay, assign.cs, anonymous.cs, driver.cs
3870 expression.cs, codegen.cs, statement.cs
3872 Fixes bugs: #318652, #323223, #234779, #325069, #325476, #332532, #334465,
3873 #345907, #349190, #353276, #355256, #359617, #378542, #384584, #396530
3875 ** Anonymous methods, lambda expressions rewrite **
3877 Anonymous expressions are now resolved when an explicit block is resolved
3878 and they don't require any registration procedure anymore. Further,
3879 anonymous methods are defined when explicit block is emitted which allows
3880 better control of whole process and opens possibilities for more
3881 optimizations as well as alternative to reverse whole process.
3883 A concept of `MutateHoistedGenericType' was introduced to keep the resolve
3884 process consistent and to correctly emit hoisted generic methods when they
3885 have at least 1 hoisted variable.
3887 2008-06-17 Martin Baulig <martin@ximian.com>
3889 * class.cs: Also emit the `[DebuggerHidden]' attribute on the main
3891 (AbstractPropertyEventMethod.IsDebuggerHidden): New protected
3892 virtual property; check it in Emit().
3893 (PropertyMethod.IsDebuggerHidden): Override, check whether we're
3895 (MethodOrOperator.ResolveMethods): Set `DEBUGGER_HIDDEN' if we're
3897 (Indexer.Define): Likewise.
3899 2008-06-17 Marek Safar <marek.safar@gmail.com>
3901 * convert.cs: Don't use IsInterface on type arguments.
3903 * delegate.cs: DelegateInvocation uses MethodInfo.
3905 * parameter.cs: Removed IsTypeParameter.
3907 * generic-mcs.cs: More missing stuff.
3909 2008-06-16 Martin Baulig <martin@ximian.com>
3912 (Modifiers.DEBUGGER_HIDDEN): New public const.
3915 (TypeManager.GetDebuggerHiddenAttribute): New public static method.
3918 (MethodOrOperator.Emit): Check `Modifiers.DEBUGGER_HIDDEN'.
3919 (AbstractPropertyEventMethod): Likewise.
3920 (Constructor.Emit): Likewise.
3921 (SourceMethod.SetCompilerGenerated): Removed.
3923 * iterator.cs: Set `Modifiers.DEBUGGER_HIDDEN' everywhere except
3927 (RootScopeInfo.DoDefineMembers): Set `Modifiers.DEBUGGER_HIDDEN'
3928 if we're an `IteratorHost'.
3929 (AnonymousMethodMethod..ctor): Don't set
3930 `Modifiers.COMPILER_GENERATED'; csc only sets this on the class,
3933 2008-06-16 Marek Safar <marek.safar@gmail.com>
3935 * statement.cs: Clean-up foreach statements.
3937 2008-06-12 Marek Safar <marek.safar@gmail.com>
3939 * class.cs: Stop using public method which should not exist
3940 (MethodBuilder.SetGenericMethodSignature).
3942 2008-06-11 Martin Baulig <martin@ximian.com>
3945 (Location.LookupFile): Add `CompilationUnit' argument; when given
3946 a relative file name, make it relative to the directory the .cs
3947 file is located in instead of using the current directory.
3949 2008-06-11 Martin Baulig <martin@ximian.com>
3952 (IMethodData.EmitExtraSymbolInfo): Added `SourceMethod' argument.
3953 (MethodOrOperator.EmitExtraSymbolInfo): Likewise.
3954 (SourceMethod.SetRealMethodName): Moved here from the symbol writer.
3955 (SourceMethod.SetCompilerGenerated): Likewise.
3957 2008-06-11 Marek Safar <marek.safar@gmail.com>
3959 * codegen.cs, driver: Only write symbol file when it's asked for.
3961 2008-06-11 Marek Safar <marek.safar@gmail.com>
3963 * codegen.cs: Don't use assembly writer error handling for symbol writer.
3965 2008-06-10 Martin Baulig <martin@ximian.com>
3967 * symbolwriter.cs: Reflect latest MarkSequencePoint() API changes.
3969 2008-06-09 Marek Safar <marek.safar@gmail.com>
3971 A fix for bug #316290
3972 * expression.cs: Include decimal operators in predefined table.
3974 * parameters.cs: More readonlyness.
3976 2008-06-09 Marek Safar <marek.safar@gmail.com>
3978 A fix for bug #397213
3979 * cs-parser.jay: One more missing current_local_parameters reset.
3981 2008-06-09 Marek Safar <marek.safar@gmail.com>
3983 A fix for bug #396633
3984 * class.cs: Host backing field in partial container.
3986 2008-06-09 Marek Safar <marek.safar@gmail.com>
3988 A fix for bug #397068
3989 * expression.cs: Check both operand types when predefined operator is used.
3991 2008-06-05 Martin Baulig <martin@ximian.com>
3993 Merged the `debugger-kahalo' branch.
3996 (MethodData.Emit): Call SymbolWriter.SetCompilerGenerated() if
3997 we're an iterator method.
3998 (SourceMethod): Reflect latest symbol writer changes;
3999 SymbolWriter.OpenMethod() now takes a `ICompileUnit' argument and
4000 now `start_row' and `end_row'.
4001 (Constructor.Emit): Fix the logic whether to emit symbol information.
4003 * iterator.cs: Call SymbolWriter.SetCompilerGenerated() on all the
4007 (CompilationUnit): New public class; derives from `SourceFile'.
4008 (SourceFileEntry.DefineSymbolInfo): New public method.
4009 (SourceFileEntry.SetChecksum): New public method.
4010 (Location): Encode hidden line numbers by using `column == 255';
4011 the .ctor now accepts `column == -1' to mark a hidden line number.
4012 (Location.Hidden): New public property.
4013 (Location.CheckPoint): Add `CompilationUnit'.
4014 (Location.SourceFiles): Change return type to `CompilationUnit[]'.
4015 (Location.Push): Add `CompilationUnit compile_unit' argument.
4016 (Location.CompilationUnit): New public property.
4019 (ToplevelBlock.Emit): Add `ec.Mark (EndLocation)'.
4021 * cs-parser.jay: `SourceFile' -> `CompilationUnit'.
4023 * driver.cs: `SourceFile' -> `CompilationUnit'.
4025 * cs-tokenizer.cs: `SourceFile' -> `CompilationUnit'.
4027 * namespace.cs: `SourceFile' -> `CompilationUnit'.
4029 * cs-tokenizer.cs: Add support for `#pragma checksum' and
4033 (SymbolWriter.MarkSequencePoint): Take a `Location' and use the
4034 new symbol writer API to also pass the file.
4036 2008-06-05 Marek Safar <marek.safar@gmail.com>
4038 * statement.cs: Emit catch variable assignment using variable expression.
4040 2008-06-05 Marek Safar <marek.safar@gmail.com>
4042 * ecore.cs, expression.cs, statement.cs: Make TemporaryVariable compatible
4043 with other variable types.
4045 2008-06-04 Marek Safar <marek.safar@gmail.com>
4047 * ecore.cs, expression.cs, statement.cs, typemanager.cs: Removed custom
4048 GetLength method emit, it breaks resolve rules.
4050 2008-06-02 Atsushi Enomoto <atsushi@ximian.com>
4051 Marek Safar <marek.safar@gmail.com>
4053 A fix for bug #395542
4054 * cs-parser.jay: The trailing comma is allowed in anonymous type member
4057 2008-06-02 Marek Safar <marek.safar@gmail.com>
4059 A fix for bug #395287
4060 * class.cs, modifiers.cs: Automatic properties method base modifiers checks.
4062 2008-05-31 Marek Safar <marek.safar@gmail.com>
4064 A fix for bug #395845
4065 * class.cs, nullable.cs: User unary operator is allowed to have nullable and
4066 non-nullable parameter type.
4068 2008-05-31 Marek Safar <marek.safar@gmail.com>
4070 * class.cs: Handle contructor initializer as a statement in top-level block.
4072 2008-05-30 Marek Safar <marek.safar@gmail.com>
4074 * attribute.cs: Don't mix old and new corlib types when emitting corlib
4075 security attributes.
4077 2008-05-24 Marek Safar <marek.safar@gmail.com>
4079 * ecore.cs, expression.cs: Small IVariable refactoring.
4081 2008-05-22 Marek Safar <marek.safar@gmail.com>
4083 * assign.cs (LocalTemporary): Implemented CreateExpressionTree.
4085 2008-05-21 Marek Safar <marek.safar@gmail.com>
4087 * cs-parser.jay: Removed redundant catch type check.
4089 2008-05-21 Marek Safar <marek.safar@gmail.com>
4091 A fix for bug #390372
4092 * nullable.cs: Set correct return type.
4094 2008-05-21 Marek Safar <marek.safar@gmail.com>
4096 A fix for bug #391062
4097 * typemanager.cs: Fixed crash when comparing null types.
4099 2008-05-21 Marek Safar <marek.safar@gmail.com>
4101 A fix for bug #391871
4102 * cs-parser.jay: Better error handling for invalid catch type.
4104 2008-05-20 Marek Safar <marek.safar@gmail.com>
4106 A fix for bug #392155
4107 * cs-tokenizer.cs: Fixed casting of byte and decimal expression.
4109 2008-05-15 Marek Safar <marek.safar@gmail.com>
4111 A fix for bug #390666
4112 * ecore.cs (BetterExpressionConversion): Unwrap each Expression<T>
4115 2008-05-15 Marek Safar <marek.safar@gmail.com>
4117 * class.cs, expression.cs, statement.cs: Removed a hack, setting block flag
4120 2008-05-13 Marek Safar <marek.safar@gmail.com>
4122 A fix for bug #389625
4123 * delegate.cs, generic.cs: Some progress on method group return type
4126 2008-05-13 Marek Safar <marek.safar@gmail.com>
4128 A fix for bug #378419
4129 * namespace.cs: Inspect also parent namespaces not only namespace entries.
4131 2008-05-12 Marek Safar <marek.safar@gmail.com>
4133 * class.cs (Constructor): Added IsCompilerGenerated.
4135 2008-05-12 Marek Safar <marek.safar@gmail.com>
4137 * expression.cs: Enum binary operators can accept non-enum operand only when
4138 is implicitly convertible to underlying type.
4140 2008-05-12 Marek Safar <marek.safar@gmail.com>
4142 A fix for bug #389272
4143 * support.cs: Workaround System.InvalidOperationException for enums.
4145 2008-05-12 Marek Safar <marek.safar@gmail.com>
4147 A fix for bug #389073
4148 * convert.cs: More undocumented explicit IntPtr/UIntPtr conversions.
4150 2008-05-10 Marek Safar <marek.safar@gmail.com>
4152 * driver.cs: Split Parse.
4154 * location.cs (LookupFile): Uses string.Empty.
4156 2008-05-07 Marek Safar <marek.safar@gmail.com>
4158 * expression.cs, parameter.cs: Small ParameterReference clean up.
4160 2008-05-07 Marek Safar <marek.safar@gmail.com>
4162 * anonymous.cs, codegen.cs, convert.cs, ecore.cs: Removed uber ugly TempEc
4163 hack. Fixes #387502.
4165 2008-05-06 Martin Baulig <martin@ximian.com>
4167 * class.cs (Constructor.Emit): Fix the logic whether to emit
4170 2008-05-06 Raja R Harinath <harinath@hurrynot.org>
4173 * iterators.cs (Iterator.CurrentBlock.DoEmit): Don't emit
4174 InvalidOperationException when the iterator is before the start or
4177 2008-05-06 Marek Safar <marek.safar@gmail.com>
4179 * nullable.cs (NullCoalescingOperator): Result is underlying type of left,
4180 when left is nullable type.
4182 2008-05-06 Marek Safar <marek.safar@gmail.com>
4184 A fix for bug #386628
4185 * expression.cs (LocalVariableReference): Continue in resolving when
4186 variable is not assigned.
4188 2008-05-05 Marek Safar <marek.safar@gmail.com>
4190 * nullable.cs, statement.cs (Unwrap): Store non-variable expression in all
4191 nullable operations.
4193 2008-05-04 Marek Safar <marek.safar@gmail.com>
4195 * nullable.cs, statement.cs (Unwrap): Don't duplicate variable expressions,
4196 it saves many redundant temporary variables for nullable operations.
4198 2008-05-03 Marek Safar <marek.safar@gmail.com>
4200 * assign.cs: EventAddOrRemove is a statement and cannot have a type.
4202 * cfold.cs, constant.cs, expression.cs: Share Error_OperatorCannotBeApplied
4205 * nullable.cs: Constant coalescing operator optimizations.
4207 2008-05-03 Marek Safar <marek.safar@gmail.com>
4209 * constant.cs: Use unsigned conversion for values which are unsigned only.
4211 2008-05-03 Marek Safar <marek.safar@gmail.com>
4213 * convert.cs, literal.cs, nullabel.cs, typemanager.cs: Implemeted null
4214 coalescing operator as it should be.
4216 2008-05-02 Marek Safar <marek.safar@gmail.com>
4218 A fix for bug #371016
4219 * expression.cs: All predefined delegate operators require implicit method
4222 2008-05-02 Marek Safar <marek.safar@gmail.com>
4224 * constant.cs: Emit long constant as uint when fits the range.
4226 * convert.cs, expression.cs: Fixed few unsafe conversions.
4228 2008-05-02 Marek Safar <marek.safar@gmail.com>
4230 * convert.cs, literal.cs: Don't wrap implicit reference conversion to object
4232 2008-05-02 Raja R Harinath <harinath@hurrynot.org>
4235 * convert.cs (ImplicitNumericConversion): Don't modify the type of
4237 * ecore.cs (EmptyCast.Create): Flatten nested EmptyCasts.
4239 2008-05-01 Marek Safar <marek.safar@gmail.com>
4241 * constant.cs, literal.cs: IsLiteral property for error reporting.
4243 * ecore.cs, expression.cs: Implemented Property expression.
4245 2008-05-01 Marek Safar <marek.safar@gmail.com>
4247 * class.cs, modifiers.cs, flowanalysis.cs: New BACKING_FIELD flag.
4249 * nullable.cs: Implemented nullable coalescing null operator.
4251 * ecore.cs, expression.cs: Expression trees work.
4253 2008-05-01 Marek Safar <marek.safar@gmail.com>
4255 * ecore.cs: CreateExpressionTree is finally abstract.
4257 * expression.cs, linq.cs: Updated.
4259 2008-05-01 Marek Safar <marek.safar@gmail.com>
4261 * expression.cs, ecore.cs: Block base access expression inside expression
4264 2008-05-01 Marek Safar <marek.safar@gmail.com>
4266 A fix for bug #385058
4267 * expression.cs: User-defined operator implementations always take
4268 precedence over predefined operator implementations.
4270 2008-04-30 Marek Safar <marek.safar@gmail.com>
4272 * assign.cs, anonymous.cs, lambda.cs, nullable.cs, ecore.cs, linq.cs,
4273 class.cs, iterators.cs, expression.cs, attribute.cs: Filled a few more
4274 expression tree conversions.
4276 2008-04-30 Marek Safar <marek.safar@gmail.com>
4278 * typemanager.cs, ecore.cs, class.cs, expression.cs, doc.cs: Merged all
4279 operators method details to Operator class.
4281 2008-04-30 Marek Safar <marek.safar@gmail.com>
4283 * anonymous.cs: Pass unsafe flags to anonymous container.
4285 * ecore.cs, expression.cs, statement.cs: Block unsafe pointer operations
4286 inside expression tree.
4288 2008-04-29 Martin Baulig <martin@ximian.com>
4290 * cs-tokenizer.cs (Tokenizer.Position): Added `line'.
4291 (Tokenizer.PopPosition): Also restore the `line'.
4293 2008-04-29 Marek Safar <marek.safar@gmail.com>
4295 * delegate.cs: Implemented Invoke expression.
4297 2008-04-29 Marek Safar <marek.safar@gmail.com>
4299 * expression.cs: Fixed equality reference comparison regression.
4301 2008-04-29 Marek Safar <marek.safar@gmail.com>
4303 * ecore.cs: Clean up EmptyCast hack.
4305 * expression.cs, nullable.cs: Implemented enum binary and unary operations
4306 using correct conversion rules. Also fixes #383993.
4308 2008-04-28 Martin Baulig <martin@ximian.com>
4310 * class.cs (Constructor.Emit): Don't emit debugging information
4311 for generated default .ctor's.
4313 2008-04-28 Marek Safar <marek.safar@gmail.com>
4315 * convert.cs: Empty-cast ushort to int conversion.
4317 2008-04-28 Marek Safar <marek.safar@gmail.com>
4319 A fix for bug #384191
4320 * ecore.cs, expression.cs: Fixed expression cloning.
4322 2008-04-28 Marek Safar <marek.safar@gmail.com>
4324 * ecore.cs, delegate.cs, assign.cs: Few tweaks for recent changes.
4326 2008-04-28 Raja R Harinath <harinath@hurrynot.org>
4328 Fix #381559, test-638.cs, test-639.cs
4329 * assign.cs (CompoundAssign.Helper): New wrapper.
4330 (CompoundAssign.DoResolve): Use it to wrap the nested 'target'
4332 * ecore.cs (MethodGroupExpr.VerifyArgumentsCompat) <params arguments>:
4333 Pass unconverted expressions to the params array creation expression.
4334 (FieldExpr.EmitAssign): Don't special-case StringConcat.
4335 (PropertyExpr.EmitAssign): Likewise.
4336 * expression.cs (ArrayCreation.ResolveArrayElement): Keep track of the
4337 element if it is of kind CompoundAssign.Helper.
4338 (ArrayCreation.Emit): If we saw a CompoundAssign.Helper, emit it
4339 first before anything else.
4340 (ArrayAccess.EmitAssign): Don't special-case StringConcat.
4341 (ArrayAccess.LoadArrayAndArguments): Simplify.
4343 2008-04-27 Marek Safar <marek.safar@gmail.com>
4345 * expression.cs: Fixed cloning of typeof(void).
4347 2008-04-27 Raja R Harinath <harinath@hurrynot.org>
4349 * assign.cs (Assign.DoResolve): Remove support for EventExprs.
4350 (Assign.Emit): Likewise. Move it to ...
4351 (CompoundAssign.DoResolve): ... here and ...
4352 (CompoundAssign.Emit): ... here.
4353 (EventAddOrRemove): New helper to handle += and -= on events, and
4354 avoid the use of BinaryDelegates.
4355 * ecore.cs (EventExpr.DoResolveLValue): Emit CS0070 unconditionally.
4356 (EventExpr.EmitAddOrRemove): Improve.
4357 * delegate.cs (DelegateInvocation.DoResolve): Simplify slightly.
4359 * cs-parser.jay (type) <namespace_or_type_name variant>: Don't
4360 create VarExprs for 'foo.bar.var'.
4361 * ecore.cs (VarExpr.InferType): Rename from DoResolveLValue, which
4362 is a highly inappropriate name for its functionality.
4364 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4366 Simplify handling of multiple assignments
4367 * assign.cs (Assign): Clear out all 'embedded assign' gunk. Make
4369 (SimpleAssign): New. Class to be used for normal assignments.
4370 * anonymous.cs, class.cs, cs-parser.jay: Update to changes.
4371 * expression.cs, parameter.cs, statement.cs: Likewise.
4373 2008-04-25 Marek Safar <marek.safar@gmail.com>
4375 * ecore.cs, expression.cs, nullable.cs: Implemeted enum binary add operation
4376 for incompatible underlying types, more to come, uff.
4378 2008-04-26 Raja R Harinath <harinath@hurrynot.org>
4381 * expression.cs (VariableReference.EmitAssign) <source is NewInstance>:
4382 Handle 'leave_copy'.
4384 2008-04-25 Marek Safar <marek.safar@gmail.com>
4386 * expression.cs, nullable.cs: Implemented UnaryPlus expression.
4388 2008-04-24 Raja R Harinath <harinath@hurrynot.org>
4390 Fix test-636.cs. Sprinkle a few more 'EmitSideEffect's around
4391 * expression.cs (Unary.TryReduceConstant): Unwrap SideEffectConstant.
4392 * statement.cs (While, Do, For): Allow test to have side effects.
4393 (For.DoEmit): Always emit InitStatement.
4396 * expression.cs (Binary.DoResolve) <BitwiseAnd with zero constant>:
4397 Always create SideEffectConstant.
4398 (Binary.EnumLiftUp): Don't assume that the enumeration constant is
4399 of type EnumConstant.
4401 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4402 Handle 'right' being SideEffectConstant of type 'bool'.
4404 * expression.cs (Binary.EmitBranchable) <Equality with constant>:
4405 Use left.EmitBranchable instead of open coding it, so as to
4406 improve optimization opportunities.
4408 * constant.cs (SideEffectConstant.EmitSideEffect): Simplify slightly.
4410 * ecore.cs (Expression.EmitBranchable): Document some non-obvious
4412 (Expression.EmitSideEffect): Document.
4414 2008-04-23 Marek Safar <marek.safar@gmail.com>
4416 * expression.cs: Implemented NewArrayBounds, TypeIs, and TypeAs expressions.
4418 2008-04-23 Marek Safar <marek.safar@gmail.com>
4420 * constant.cs, statement.cs: Use EmitSideEffect for constant if statement.
4422 2008-04-23 Marek Safar <marek.safar@gmail.com>
4424 * ecore.cs, expression.cs, delegate.cs: Implemeted delegate instantiation
4425 conversion to expression tree.
4427 2008-04-23 Marek Safar <marek.safar@gmail.com>
4429 * ecore.cs: Removed unused expression.
4431 2008-04-22 Marek Safar <marek.safar@gmail.com>
4433 * expression.cs: Implemented NegateChecked and New expressions.
4435 2008-04-22 Marek Safar <marek.safar@gmail.com>
4437 * convert.cs, nullable.cs, expression.cs: Implemented Negate expression.
4439 2008-04-22 Raja R Harinath <harinath@hurrynot.org>
4442 * anonymous.cs (AnonymousMethodExpression.DoResolve): Mark as
4443 needing final 'ret' instruction.
4445 2008-04-22 Marek Safar <marek.safar@gmail.com>
4447 * expression.cs: Disabled lifted binary conversion on ISO-1 profiles.
4449 2008-04-21 Marek Safar <marek.safar@gmail.com>
4451 * expression.cs: Emit ldnull and not null expression as an instance argument
4452 of static method expression calls.
4454 2008-04-21 Marek Safar <marek.safar@gmail.com>
4456 A fix for bug #378200
4457 * expression.cs: Fixed crash when creating parameterless expression tree
4460 2008-04-21 Marek Safar <marek.safar@gmail.com>
4462 A fix for bug #375297
4463 * anonymous.cs: Fixed crash when inferring from null argument anonymous
4466 2008-04-21 Marek Safar <marek.safar@gmail.com>
4468 A fix for bug #377596
4469 * decl.cs, class.cs: Emit delegate type argument attributes.
4471 2008-04-21 Marek Safar <marek.safar@gmail.com>
4473 A fix for bug #365314
4474 * generic.cs, ecore.cs: Type parameter declaration cannot be of generic type
4476 2008-04-21 Marek Safar <marek.safar@gmail.com>
4478 * cs-parser.jay, expression.cs: ComposedCast can work with type expressions
4481 2008-04-21 Marek Safar <marek.safar@gmail.com>
4483 * generic.cs (TypeParameter): Removed redundant location.
4485 2008-04-19 Marek Safar <marek.safar@gmail.com>
4487 * generic.cs, parameter.cs, namespace.cs, ecore.cs, class.cs, decl.cs,
4488 delegate.cs, iterators.cs, cs-parser.jay, const.cs, enum.cs: Use
4489 FullNamedExpression in all declaration type expression, statements will come
4492 2008-04-18 Marek Safar <marek.safar@gmail.com>
4494 * generic.cs, namespace.cs, ecore.cs, class.cs, decl.cs, generic-mcs.cs,
4495 nullable.cs, expression.cs, enum.cs, doc.cs: Cleaning up type expressions.
4497 2008-04-18 Marek Safar <marek.safar@gmail.com>
4499 * parameter.cs, delegate.cs, cs-parser.jay, expression.cs: Removed unused
4502 2008-04-17 Marek Safar <marek.safar@gmail.com>
4504 * decl.cs, class.cs, generic.cs: Verify partial parts type parameters and
4507 2008-04-17 Marek Safar <marek.safar@gmail.com>
4509 * decl.cs, class.cs, cs-parser.jay, ecore.cs, expression.cs: Unify all type
4513 2008-04-17 Raja R Harinath <harinath@hurrynot.org>
4515 Hook up 'EmitSideEffect'
4516 * constant.cs (Constant.EmitSideEffect): New.
4517 (SideEffectConstant.Emit): Simplify. Use EmitSideEffect.
4518 (SideEffectConstant.EmitSideEffect): New.
4519 * ecore.cs (BoxedCast.EmitBranchable): Remove. We can't use an
4520 unconditional branch in EmitBranchable.
4521 (FieldExpr.EmitBranchable): New.
4522 * expression.cs (Unary.EmitSideEffect): New.
4523 (Binary.EmitSideEffect): New.
4524 (VariableReference.EmitSideEffect): New. Do nothing.
4526 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4528 Introduce 'EmitSideEffect'
4529 * ecore.cs (Expression.EmitSideEffect): New.
4530 (TypeCast): Rename from EmptyCast.
4532 (EmptyCast.EmitBranchable, EmptyCast.EmitSideEffect): Implement.
4533 (BoxedCast.EmitBranchable, BoxedCast.EmitSideEffect): Implement.
4534 * convert.cs, nullable.cs: Update to changes.
4536 2008-04-16 Marek Safar <marek.safar@gmail.com>
4538 * class.cs, cs-parser.jay: Early check for base types expression.
4540 2008-04-16 Marek Safar <marek.safar@gmail.com>
4542 * decl.cs (MemberName): Declare PrettyName as obsolete.
4544 2008-04-16 Marek Safar <marek.safar@gmail.com>
4546 * namespace.cs: Use MemberName comparison.
4548 2008-04-16 Raja R Harinath <harinath@hurrynot.org>
4551 * decl.cs (MemberName.PrettyName): New. Replaces the misnamed
4553 (MemberName.MethodName, MemberName.GetSignatureForError): Improve.
4554 (MemberName.FullyQualifiedName): New. Provides the functionality
4555 that users assume FullName would have.
4556 * ecore.cs, namespace.cs: Update to changes.
4558 * statement.cs (Using.assign): Make into ExpressionStatement.
4559 (Using.EmitPreTryBody): Simplify.
4561 2008-04-16 Marek Safar <marek.safar@gmail.com>
4563 * report.cs: ColorFormat is protected.
4565 * rootcontext.cs: Unused fields clean-up.
4567 * namespace.cs: Made UsingEntry name private.
4569 2008-04-16 Marek Safar <marek.safar@gmail.com>
4571 * cs-tokenizer.cs, location.cs: Removed unused field.
4573 2008-04-16 Jan Oravec <jan.oravec@6com.sk>
4574 Raja R Harinath <harinath@hurrynot.org>
4577 * constant.cs (SideEffectConstant.value): Rename from 'left'.
4578 (SideEffectConstant.side_effect): Rename from 'right'.
4579 (SideEffectConstant..ctor): Normalize 'side_effect'.
4580 (SideEffectConstant.Emit): Emit 'value', not 'side_effect' as the
4581 value of this constant.
4582 * cfold.cs: Update to changes.
4584 2008-04-15 Marek Safar <marek.safar@gmail.com>
4586 * cs-paser.jay: Removed unused variable.
4588 * driver.cs: Made Compile instance method.
4590 2008-04-15 Raja R Harinath <harinath@hurrynot.org>
4592 * flowanalysis.cs (FlowBranching.MergeChild): Simplify.
4594 2008-04-15 Marek Safar <marek.safar@gmail.com>
4596 * cs-paser.jay, namespace.cs: Simplified handling of namespace imports.
4598 2008-04-13 Jb Evain <jbevain@novell.com>
4600 * namespace.cs: update the System.Core fullname for 2.1
4601 * driver.cs: update the list of required assemblies for 2.1.
4602 Merged from the Moonlight 2 branch.
4604 2008-04-11 Marek Safar <marek.safar@gmail.com>
4606 * assign.cs, ecore.cs, expression.cs, nullable.cs: More work on nullable
4607 types and user defined operators. User operators arguments has to be checked
4608 for null value before invocation, which also means no operator is called
4609 when any argument is not convertible to unwrapped nullable type.
4611 2008-04-09 Marek Safar <marek.safar@gmail.com>
4613 * convert.cs, ecore.cs, expression.cs, nullable.cs: Initial refactoring
4614 of Unary expressions to follow operator overloading rules precisely.
4615 Also fixes #321794, #323794
4617 2008-04-08 Marek Safar <marek.safar@gmail.com>
4619 * cs-parser.jay, expression.cs: Don't wrap Indirection expression in Unary
4622 2008-04-08 Marek Safar <marek.safar@gmail.com>
4624 * expression.cs, ecore.cs: Implemented MemberInit expression.
4626 2008-04-08 Raja R Harinath <harinath@hurrynot.org>
4628 Fix mono/tests/exception4.cs
4629 * statement.cs (ExceptionStatement, TryCatch): Revert to using
4630 ec.NeedReturnLabel () rather emitting a 'nop'.
4632 * statement.cs (ExceptionStatement.SomeCodeFollows): A hook for a
4634 (TryCatch.SomeCodeFollows): Likewise.
4635 * flowanalysis.cs (FlowBranchingException): Call 'SomeCodeFollows'
4636 for 'break', 'continue' and 'return' statements inside a try.
4637 We're fairly sure that the generated IL stream will have more
4638 instructions textually following the try.
4639 (FlowBranchingTryCatch): Likewise.
4641 * statement.cs (Throw.Resolve): Move CS0156 and CS0724 testing ...
4642 * flowanalysis.cs (FlowBranching.CheckRethrow): ... here and to its
4645 * statement.cs (CollectionForeach.DisposableWrapper): Make a true
4646 wrapper -- forward everything to CollectionForeach.
4647 (CollectionForeach.NonDisposableWrapper): New.
4648 (CollectionForeach.EmitFinallyBody): Use 'endfinally' instruction
4649 instead of a pop + branch to end.
4651 2008-04-07 Marek Safar <marek.safar@gmail.com>
4653 A fix for bug #377485
4654 * assign.cs, expression.cs, decl.cs, class.cs, ecore.cs, namespace.cs:
4655 Propagate location for extension method groups. Report conversion failure at
4658 2008-04-07 Marek Safar <marek.safar@gmail.com>
4660 * anonymous.cs, expression.cs, ecore.cs, typemanager.cs: Implemented
4661 ListInit and Field expressions.
4663 2008-04-06 Raja R Harinath <harinath@hurrynot.org>
4665 * iterators.cs (Iterator.EmitMoveNext): Remove try/fault wrapper.
4666 Since $PC is always -1 inside the body of MoveNext, the fault
4668 * flowanalysis.cs (FlowBranchingException.EmitFinally): Kill.
4669 * statement.cs (ExceptionStatement.emit_finally): Likewise.
4670 (ExceptionStatement.ResolveFinally): Drop 'branching' argument.
4672 The denouement! Fix #324708
4673 * iterators.cs (Iterator.EmitMoveNext): Reset $PC to -1 on entry.
4674 (Iterator.EmitYieldBreak): We no longer need to reset $PC.
4675 * statement.cs (ExceptionStatement.DoEmit): Actually emit the
4676 'finally' inside the finally clause.
4678 * statement.cs (ExceptionStatement.DoEmit): Emit try/finally block
4679 inside an iterator. Don't emit the body of the 'finally' inside
4680 the finally clause yet.
4682 Use the ResumableStatement infrastructure for MoveNext ()
4683 * iterators.cs (Iterator.EmitMoveNext_NoResumePoints): New.
4684 (Iterator.EmitMoveNext): Use 'resume_points'. Get rid of
4685 'old_resume_points'. Move dispatcher upfront.
4686 (Iterator.MarkYield): Mark the 'resume_point' of a Yield.
4687 * statement.cs (ExceptionStatement.DoEmit): Emit a dispatcher if
4688 in an enumerator. This encodes the main fix in this patch series
4689 -- we can only jump into the first instruction of a try from the
4690 outside, but we want to emit try/finally regions in iterators and
4691 resume in the middle of them.
4693 2008-04-05 Raja R Harinath <harinath@hurrynot.org>
4695 * statement.cs (ExceptionStatement.ResolveFinally): Move setting
4696 of NeedReturnLabel here.
4698 Introduce a common point for emitting try/finally to IL
4699 * statement.cs (ExceptionStatement.DoEmit): New. Combines all the
4700 features of the various subclasses, which are now driven by ...
4701 (ExceptionStatement.EmitPreTryBody): ... this and ...
4702 (ExceptionStatement.EmitTryBody): ... this and the original
4704 (TryFinally, Lock, Using, UsingTemporary, DisposableWrapper):
4705 Remove DoEmit and update to follow above protocol.
4707 * statement.cs (ExceptionStatement.EmitForDispose): If all labels
4708 of the dispatcher are the same, skip emitting the 'switch'.
4709 * iterator.cs (Iterator.EmitDispose): Update to changes.
4711 Clean up handling of 'using' statement
4712 * statement.cs (UsingTemporary): New. Carved out of ...
4713 (Using): ... this. Simplify drastically. Handle exactly
4715 * cs-parser.jay (using_statement): Split. Create UsingTemporary
4716 or Using as appropriate. If there are multiple variable declared,
4717 create nested Using statements.
4718 (resource_acquisition): Kill.
4720 * statement.cs (ExceptionStatement.EmitForDispose): Use
4721 EmitFinallyBody, not EmitFinally.
4723 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Remove.
4724 * iterator.cs: Update to changes.
4726 Start using the ResumableStatement infrastructure
4727 * statement.cs (ResumeableStatement.PrepareForDispose): New.
4728 (ResumableStatement.EmitForDispose): New.
4729 (ExceptionStatement): Override them.
4730 * iterators.cs (Iterator.EmitDispose): Use PrepareForDispose and
4731 EmitForDispose to create the body of the Dispose method. Don't
4734 * iterator.cs (Iterator.AddResumePoint): Move here from ...
4735 * statement.cs (Toplevel.AddResumePoint): ... here.
4736 (Toplevel.MoveNextStatement.Resolve): Create FlowBranchingIterator.
4737 * flowanalysis.cs (FlowBranchingIterator): New.
4738 * codegen.cs (EmitContext): Update to changes.
4740 * iterators.cs (Iterator.OldResumePoint): Rename from ResumePoint.
4741 (Iterator.old_resume_points): Rename from 'resume_points'.
4742 (Iterator.MoveNextStatement): Remove unused class.
4744 New infrastructure for try/finally in iterators (still unused)
4745 * flowanalysis.cs (FlowBranching.AddResumePoint): New.
4746 (FlowBranchingToplevel.AddResumePoint): Hook into
4747 ToplevelBlock.AddResumePoint.
4748 (FlowBranchingTryCatch): Move CS01626 and CS01631 checks here.
4749 (FlowBranchingException): Hook into ExceptionBlock.AddResumePoint.
4750 * statement.cs (ToplevelBlock.AddResumePoint): New. Collect
4751 resume points and assign program-counter values.
4752 (ExceptionBlock.AddResumePoint): Collect resume points for
4753 de-muxer at the top of try block.
4754 * iterators.cs (Yield.CheckContext): Simplify.
4755 (Yield.Resolve): Use FlowBranching.AddResumePoint.
4757 2008-04-04 Raja R Harinath <harinath@hurrynot.org>
4759 * flowanalysis.cs (FlowBranching.AddReturnOrigin): Change Location
4760 argument to an ExitStatement.
4761 (FlowBranchingException): Refactor saved origins code.
4762 * statement.cs (ExitStatement): Update to cahges.
4763 * iterator.cs (YieldBreak): Likewise.
4765 * statement.cs (ResumableStatement): New. Common base class for
4766 YieldReturn and ExceptionStatement.
4767 (ExitStatement): New. Common base class for Return and YieldBreak.
4768 (Return): Update to changes.
4769 * iterator.cs (YieldBreak): Likewise.
4770 * lambda.cs (ContextualReturn): Likewise.
4773 * ecore.cs (Expression.ResolveAsTypeStep): If '!silent' attempt to
4774 emit a meaningful error message.
4776 Fix #324765, #319508
4777 * flowanalysis.cs (VariableInfo.IsEverAssigned): New.
4778 (VariableInfo.SetAssigned): Set it.
4779 * statement.cs (Block.UsageWarning): Use 'IsEverAssigned' to
4780 determine if CS0219 or CS0168 is appropriate. Don't use
4781 flow-analysis information.
4782 (Block.Resolve): Use ec.EndFlowBranching, not ec.DoEndFlowBranching.
4783 * codegen.cs (EmitContext.DoEndFlowBranching): Kill. Inline into ...
4784 (EmitContext.EndFlowBranching): ... this.
4786 2008-04-03 Marek Safar <marek.safar@gmail.com>
4788 * class.cs, typemanager.cs: Emit volatile field with IsVolatile modifier.
4790 2008-04-03 Marek Safar <marek.safar@gmail.com>
4792 A fix for bug #376508
4793 * convert.cs, expression.cs: Fixed difference between ImplicitConversion and
4794 ImplicitConversionExists.
4796 2008-04-03 Marek Safar <marek.safar@gmail.com>
4798 * expression.cs (Binary): Added remaining binary operators to expression
4801 * nullable.cs: Optimize shift with null argument.
4803 2008-04-03 Raja R Harinath <harinath@hurrynot.org>
4805 Fix minor IL regression
4806 * statement.cs (TryCatch..ctor): Add 'inside_try_finally' argument.
4807 (TryCatch.DoEmit): Use it to avoid creating another ExceptionBlock.
4808 * cs-parser.jay (try_statement): Update to changes.
4810 * statement.cs (TryFinally.need_exc_block): Delete.
4811 (TryFinally): Update to changes.
4813 Now all ExceptionStatements are unconditional
4814 * statement.cs (CollectionForeach.DisposableWrapper): New.
4815 Extract out the try/finally code into a new wrapper.
4816 (CollectionForeach.Resolve): Use it to simplify the code.
4818 2008-04-02 Raja R Harinath <harinath@hurrynot.org>
4820 Start at simplifying ExceptionStatement semantics a bit
4821 * statement.cs (TryCatch, TryFinally): Split 'Try' into two pieces.
4822 * cs-parser.jay (try_statement): Update to changes.
4823 (opt_catch_clauses): Remove.
4824 * flowanalysis.cs: Update to changes.
4825 (FlowBranching.BranchingType.TryCatch): New.
4826 (FlowBranchingTryCatch): New.
4828 * flowanalysis.cs (FlowBranching.BranchingType.SwitchSection): Kill.
4829 (FlowBranching.CreateBranching): Update to changes.
4830 (FlowBranchingBlock.AddSibling): Add sanity check.
4831 * codegen.cs (EmitContext.StartFlowBranching) <Block variant>:
4834 * iterators.cs (Iterator.MarkFinally): Remove.
4835 * statement.cs (ExceptionStatement): Update to changes.
4837 Add support for skipping over finally blocks at runtime. First
4838 in a series to fix #324708
4839 * iterators.cs (Iterator.SkipFinally): New LocalBuilder.
4840 (Iterator.EmitMoveNext): Initialize it.
4841 * statement.cs (ExceptionStatement.EmitFinally): Use it to emit a
4842 branch over the body of the 'finally' clause.
4844 2008-03-31 Raja R Harinath <harinath@hurrynot.org>
4846 Avoid lopsided use of Foo/DoFoo names
4847 * statement.cs (ExpressionStatement.EmitFinallyBody):
4848 Rename from EmitFinally.
4849 (ExpressionStatement.EmitFinally): Rename from DoEmitFinally.
4850 * iterator.cs: Update to changes.
4852 2008-04-02 Marek Safar <marek.safar@gmail.com>
4854 * ecore.cs, expression.cs, nullable.cs: ConditionalLogicalOperator is now
4855 based on UserOperatorCall. More binary nullable operators clean up.
4857 2008-04-02 Martin Baulig <martin@ximian.com>
4859 * symbolwriter.cs: Remove the `#if !DISABLE_TERRANIA_CHANGES' conditionals.
4861 2008-04-02 Marek Safar <marek.safar@gmail.com>
4863 * nullable.cs: Merge user and empty conversions when lifting expression
4866 * expression.cs (StringConcat): Implemented expression tree representation.
4868 2008-04-01 Marek Safar <marek.safar@gmail.com>
4870 * nullable.cs: When lifting null literal and a user operator exists, no call
4873 2008-04-01 Marek Safar <marek.safar@gmail.com>
4875 * nullable.cs, ecore.cs, expression.cs: Convert null arithmetic to lifted
4878 2008-04-01 Marek Safar <marek.safar@gmail.com>
4880 * nullable.cs, expression.cs: Use namespace instead heavily nested
4881 monster abstract class.
4883 2008-04-01 Marek Safar <marek.safar@gmail.com>
4885 * ecore.cs, convert.cs, constant.cs, nullable.cs, expression.cs: Implemented
4886 lifting of null literal and user operators. Clean up of some temporary
4889 2008-03-30 Raja R Harinath <harinath@hurrynot.org>
4891 Fix #368224, test-629.cs
4892 * flowanalysis.cs (FlowBranching.StealFinallyClauses): Return true
4893 if it crossed an unwind-protect boundary.
4894 * iterators.cs (Yield.CheckContext): Relax check for 'yield break'.
4895 (Yield.Resolve, Yield.DoEmit): Track whether the yield occurs
4896 inside an unwind-protected region.
4897 (YieldBreak.Resolve, YieldBreak.DoEmit): Likewise.
4898 (Iterator.MarkYield): Add 'unwind_protect' parameter. Emit a
4899 'leave' instead of a 'br' if unwind-protected.
4900 (Iterator.EmitYieldBreak): Likewise.
4902 2008-03-29 Gert Driesen <drieseng@users.sourceforge.net>
4904 * driver.cs: Only define versioninfo resources if no win32 resource
4907 2008-03-28 Marek Safar <marek.safar@gmail.com>
4909 A fix for bug #372375
4910 * convert.cs: Fixed boxing of nullable types.
4912 2008-03-28 Marek Safar <marek.safar@gmail.com>
4914 * typemanager.cs: Initialize InternalsVisibleTo as the very first optional
4917 2008-03-28 Marek Safar <marek.safar@gmail.com>
4919 A fix for bug #374619
4920 * nullable.cs: Fixed guarding of EmitBitwiseBoolean.
4922 2008-03-27 Marek Safar <marek.safar@gmail.com>
4924 * lambda.cs: Check return type only for invocation.
4926 2008-03-27 Marek Safar <marek.safar@gmail.com>
4928 A fix for bug #374214
4929 * ecore.cs: Correctly report argument type mismatch.
4931 2008-03-27 Marek Safar <marek.safar@gmail.com>
4933 * convert.cs (ImplicitReferenceConversionCore): Correctly compare enum type
4934 and not rely on broken IsEnum.
4936 2008-03-27 Marek Safar <marek.safar@gmail.com>
4938 * nullable.cs: New file, extracted from generic.cs.
4940 * generic.cs, generic-mcs.cs, *.csproj, *.sources: Updated.
4942 2008-03-27 Marek Safar <marek.safar@gmail.com>
4944 * generic.cs, convert.cs, generic-mcs.cs, expression.cs: Added lifting of
4945 predefined comparison operators and null literals.
4947 * report.cs: New warning ID.
4949 2008-03-25 Marek Safar <marek.safar@gmail.com>
4951 A fix for bug #370577
4952 * lambda.cs: Check return type too.
4954 2008-03-25 Marek Safar <marek.safar@gmail.com>
4956 A fix for bug #372846
4957 * class.cs: Automatic properties can be declared as unsafe.
4959 2008-03-20 Marek Safar <marek.safar@gmail.com>
4961 * location.cs: Use string based concatenation.
4963 * expression.cs: LiftedBinaryOperator is gmcs only.
4965 2008-03-20 Marek Safar <marek.safar@gmail.com>
4967 * generic.cs, literal.cs, ecore.cs, expression.cs: Ongoing work on nullable
4968 conversions rules and expression trees.
4970 2008-03-19 Marek Safar <marek.safar@gmail.com>
4972 * delegate.cs: Use extension method source as delegate target.
4974 2008-03-19 Marek Safar <marek.safar@gmail.com>
4976 * generic.cs, generic-mcs.cs, expression.cs, ecore.cs: Rewrote nullable
4977 binary operations to be purely based on binary operations and optimized
4978 emitted code (30% less in some cases). Introduced ReducedExpression for ETs
4979 and other ET refactoring.
4981 * typemanager.cs: Fixed warning.
4983 2008-03-17 Marek Safar <marek.safar@gmail.com>
4985 * class.cs, decl.cs, delegate.cs: Do protected modifier check on each member
4987 * symbolwriter.cs: Fixed.
4989 2008-03-17 Marek Safar <marek.safar@gmail.com>
4991 * anonymous.cs, driver.cs: Reset anonymous types counters.
4993 2008-03-17 Marek Safar <marek.safar@gmail.com>
4995 * ecore.cs (MethodGroupExpr): Skip first candidate, it's already the best.
4997 * class.cs: Use fullname for all type member definitions.
4999 2008-02-19 Martin Baulig <martin@ximian.com>
5002 (IMethodData.EmitExtraSymbolInfo): New interface method.
5003 (MethodData.Emit): Call method.EmitExtraSymbolInfo().
5004 (MethodOrOperator.EmitExtraSymbolInfo): Implement this new
5005 interface method here as an empty public virtual method.
5008 (AnonymousMethodMethod.ctor): Added `string real_name' argument.
5009 (AnonymousMethodMethod.EmitExtraSymbolInfo): Override and call
5010 CodeGen.SymbolWriter.SetRealMethodName().
5012 2008-02-18 Martin Baulig <martin@ximian.com>
5015 (ScopeInfo.EmitType): Override this and emit debugging
5016 information for captured variables.
5017 (RootScopeInfo.EmitType): Override this and emit symbol
5018 information for a captured `this'.
5020 2008-02-15 Martin Baulig <martin@ximian.com>
5022 * iterators.cs: Emit debugging info.
5025 (EmitContext.Flags): Add `OmitDebuggingInfo'.
5026 (EmitContext.OmitDebuggingInfo): New public property.
5029 (While): Override Emit() and don't emit symbol info there; do it
5030 inside DoEmit() instead.
5031 (Block.Emit): Omit symbol information while emitting the scope
5032 initializers; don't ec.Mark() the `EndLocation'. Fix the lexical
5034 (ExplicitBlock.IsIterator): Moved here from `ToplevelBlock'.
5035 (ToplevelBlock.MakeIterator): Pass the `flags' to `ExplicitBlock's
5036 .ctor to make `IsIterator' work.
5038 2008-03-14 Martin Baulig <martin@ximian.com>
5040 * symbolwriter.cs: Added the new symbol writer function from the
5041 debugger's `terrania' branch; temporarily enclose them inside
5042 `#if !DISABLE_TERRANIA_CHANGES' conditionals until I'm back from
5045 2008-03-14 Martin Baulig <martin@ximian.com>
5048 (SymbolWriter): Make this a public static class.
5051 (CodeGen.SymbolWriter): Removed; use the new static `SymbolWriter'
5052 class instead of using `if (CodeGen.SymbolWriter != null)' everywhere.
5054 2008-03-14 Marek Safar <marek.safar@gmail.com>
5056 A fix for bug #370577
5057 * statement.cs, lambda.cs: Added extra limitations when dealing with void
5060 2008-03-14 Marek Safar <marek.safar@gmail.com>
5062 * typemanager.cs (CSharpName): Made 250 times faster.
5064 2008-03-13 Marek Safar <marek.safar@gmail.com>
5066 * ecore.cs, expression.cs: Emit conversion for ET shift argument.
5068 2008-03-12 Marek Safar <marek.safar@gmail.com>
5070 * generic.cs, typemanager.cs, enum.cs, codegen.cs, statement.cs: Try not to
5071 crash when predefined field does not exist.
5073 2008-03-12 Marek Safar <marek.safar@gmail.com>
5075 * ecore.cs (PropertyExpr): Fixed IsSingleDimensionalArrayLength regression.
5077 2008-03-12 Marek Safar <marek.safar@gmail.com>
5079 * class.cs (FixedField): Don't crash when contructors are missing.
5081 2008-03-11 Marek Safar <marek.safar@gmail.com>
5083 * typemanager.cs, namespace.cs, literal.cs, ecore.cs, class.cs, decl.cs,
5084 convert.cs, constant.cs, expression.cs, statement.cs: Use same method to
5085 check internal types accessibility for internal and external types.
5086 Replaced EnumToUnderlying by GetEnumUnderlyingType.
5088 2008-03-11 Marek Safar <marek.safar@gmail.com>
5090 * support.cs, typemanager.cs, pending.cs, ecore.cs, class.cs, delegate.cs
5091 convert.cs, const.cs, anonymous.cs, constant.cs, expression.cs,
5092 attribute.cs, statement: Use corect instance of predefined types (work
5093 related to #364674).
5095 2008-03-07 Marek Safar <marek.safar@gmail.com>
5097 * expression.cs (TypeOfVoid): Fixed predefined method initialization.
5099 2008-03-07 Marek Safar <marek.safar@gmail.com>
5101 * generic.cs, typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs,
5102 class.cs, delegate.cs, iterators.cs, const.cs, constant.cs, driver.cs,
5103 expression.cs, attribute.cs, codegen.cs, statement.cs: TypeManager optional
5104 predefined types clean up, delayed predefined types members initialization
5105 (work related to #364674).
5107 2008-03-05 Marek Safar <marek.safar@gmail.com>
5109 * typemanager.cs (IsFriendAssembly): InternalsVisibleTo is not mandatory.
5111 2008-03-05 Marek Safar <marek.safar@gmail.com>
5113 * typemanager.cs, parameter.cs, rootcontext.cs, ecore.cs, class.cs, decl.cs,
5114 delegate.cs, convert.cs, driver.cs, attribute.cs, codegen.cs: TypeManager
5115 predefined types clean up (work related to #364674).
5117 2008-03-04 Marek Safar <marek.safar@gmail.com>
5119 * ecore.cs: Print an error message instead of throwing exception.
5121 2008-03-04 Marek Safar <marek.safar@gmail.com>
5123 * generic.cs, typemanager.cs, literal.cs, convert.cs, cfold.cs, constant.cs,
5124 expression.cs, statement.cs: Unififed null literal representation.
5126 2008-03-03 Marek Safar <marek.safar@gmail.com>
5128 * anonymous.cs, cfold.cs, convert.cs, delegate.cs, doc.cs, ecore.cs,
5129 expression.cs: Refactored binary operators resolve phase and improved speed.
5130 The nullable code is still missing and won't work correctly, more fixes
5133 It also fixes #323726, #324312, #324248, and many other unreported issues.
5135 2008-02-29 Zoltan Varga <vargaz@gmail.com>
5137 * report.cs (FeatureIsNotAvailable): Use 'mcs1' instead of 'mcs', and 'mcs'
5140 2008-02-27 Marek Safar <marek.safar@gmail.com>
5142 * ecore.cs: Clean-up and split BetterConversion.
5144 2008-02-25 Raja R Harinath <harinath@hurrynot.org>
5147 * enum.cs (EnumMember.Value): Only access 'value' if
5148 ResolveValue says it's ok.
5149 (EnumMember.DoResolveValue): Don't set prev_member.value.
5150 (Enum.GetDefinition): Reverse arguments of Equals --
5151 EnumMember.Value can return 'null'.
5153 * statement.cs (Switch.Error_AlreadyOccurs): Fix typo in name.
5155 2008-02-22 Marek Safar <marek.safar@gmail.com>
5157 * generic.cs, expression.cs: More ongoing work on expression trees.
5159 2008-02-21 Marek Safar <marek.safar@gmail.com>
5161 * class.cs, typemanager.cs: Rewrote operator matching logic to correctly
5162 handle missing matches when mutiple operators exist.
5164 2008-02-20 Marek Safar <marek.safar@gmail.com>
5166 A fix for bug #363218
5167 * expression.cs (ArrayCreation.Clone): Deal with multi-dimensional
5170 2008-02-20 Marek Safar <marek.safar@gmail.com>
5172 * expression.cs, constant.cs, cfold.cs: Yet another side-effect constant
5173 update. This time to deal correctly with SideEffectConstant expression used
5174 as an argument for another constant folding.
5176 2008-02-20 Raja R Harinath <harinath@hurrynot.org>
5178 * typemanager.cs (DropGenericMethodArguments): Ensure we get an underlying
5181 2008-02-19 Marek Safar <marek.safar@gmail.com>
5183 * constant.cs, cfold.cs: SideEffectConstant results can apply for folding.
5185 2008-02-19 Marek Safar <marek.safar@gmail.com>
5187 A fix for bug #328136
5188 * expression.cs: Do not fold immediately LogicalAnd operators when the left
5189 side is a false constant, because we still need to evaluate the right-hand
5192 * statement.cs (If): Emit two types of boolean constants (simple constant,
5193 side-effect constant).
5195 2008-02-19 Marek Safar <marek.safar@gmail.com>
5197 * constant.cs (SideEffectConstant): Don't emit boolean constant.
5199 * expression.cs: Fold immediately LogicalAnd operators when both sides are
5202 2008-02-18 Marek Safar <marek.safar@gmail.com>
5204 A fix for bug #361457
5205 * ecore.cs (IsApplicable): Params methods have lower priority.
5207 * support.cs: Return correct parameter modifier for params types.
5209 2008-02-18 Marek Safar <marek.safar@gmail.com>
5211 * generic.cs (TypeParameter): Cache attribute target name.
5213 * support.cs: Removed unused variable.
5215 * typemanager.cs: Removed debugging leftover.
5217 * ecore.cs: Use local type instead of a property;
5219 * class.cs (VerifyMembers): Consider also parent to test whether type member
5222 * expression.cs (FullMethodDesc): Removed.
5224 * attribute.cs (IsValidArgumentType): Made static.
5226 2008-02-17 Raja R Harinath <harinath@hurrynot.org>
5228 Cleanup to be more readable.
5229 * Makefile (GMCS_PROFILE): Remove.
5230 (COMPILER_NAME): New helper.
5232 2008-02-15 Miguel de Icaza <miguel@novell.com>
5234 * cs-tokenizer.cs: if a conditional expression happens inside a
5235 (...) this also means that we do not need to de-ambiguate between
5236 an parenthesized expression and a cast.
5240 * constant.cs (SideEffectConstant): a constant value that happens
5241 to have a side effect.
5243 Fixes the build regressions introduced by the fix for #359789
5245 2008-02-14 Rodrigo Kumpera <rkumpera@novell.com>
5247 * expression.cs (Conditional.Emit): when emitting the ternary
5248 operator, use local variables to generate code verifiable code.
5250 The verifier cannot infer that the type on stack before the
5251 stloc.0 is executed is of type ParentB. This happens because the
5252 stack merge algorithm uses only parent types when deciding which
5253 is the common type. This is described in Part III 1.8.1.3 of ECMA
5256 This code compiled with mcs is not verifiable under MS. The MS
5257 verifier picks the first common interface of Foo and Bar, which is
5258 wrong, but doesn't use a full join type of the 2 interfaces.
5260 CSC uses a clever hack to compile such code in a verifiable
5261 way. It stores the intermediate values in a local variable with
5266 2008-02-14 Miguel de Icaza <miguel@novell.com>
5268 * expression.cs: Do not fold BitwiseAnd operators when the left
5269 side is a false constant, because we still need to evaluate the
5274 * support.cs: Instead of throwing an InternalErrorException when
5275 the position of the stream is outside the boundary of our buffer,
5276 reset the state of the reader, and restart the reading from the
5277 beginning of the file.
5279 2008-02-14 Marek Safar <marek.safar@gmail.com>
5281 * generic.cs (TypeParameter.GetMembers): Is not supported operation.
5283 2008-02-14 Marek Safar <marek.safar@gmail.com>
5285 A fix for bug #361686
5286 * decl.cs: A protected types used inside a private class which parents
5287 derives from the protected class are accessible.
5289 2008-02-13 Marek Safar <marek.safar@gmail.com>
5291 * generic.cs (ConstraintChecker): Use cached member lookup when looking for
5292 the parameterless constructor.
5294 2008-02-13 Marek Safar <marek.safar@gmail.com>
5296 * generic.cs, typemanager.cs, iterators.cs, codegen.cs: Refactored core
5297 lookup methods to use standard member cache when doing member lookup.
5299 2008-02-12 Marek Safar <marek.safar@gmail.com>
5301 * driver.cs: Don't report full path for referenced module as assembly error.
5303 2008-02-12 Marek Safar <marek.safar@gmail.com>
5305 * Makefile: Fixed `qh' target to work on all machines.
5307 * report.cs, typemanager.cs, parameter.cs, ecore.cs, class.cs, anonymous.cs,
5308 expression.cs, codegen.cs, statement.cs, doc.cs: Replaced type IsSubclassOf
5309 and HasElementType with TypeManager implementation.
5311 2008-02-08 Marek Safar <marek.safar@gmail.com>
5313 A fix for bugs #325134, #359749
5314 * expression.cs, ecore.cs: Try to resolve an extension method even if the
5315 first binds point to non-method member expression.
5317 2008-02-08 Marek Safar <marek.safar@gmail.com>
5319 * cs-parser.jay: Null coalescing operator is not part of ISO-1.
5321 2008-02-08 Marek Safar <marek.safar@gmail.com>
5323 A fix for bugs #321394, #323028
5324 * generic.cs, parameter.cs, ecore.cs, class.cs, decl.cs, delegate.cs:
5325 Reworked naive IsAccessibleAs implementation to handle nested types.
5327 2008-02-05 Jb Evain <jbevain@novell.com>
5329 * class.cs: use generic type comparison for parameters
5332 2008-02-05 Marek Safar <marek.safar@gmail.com>
5334 A fix for bug #325372
5335 * class.cs: Use generic type comparison when testing method signatures.
5337 2008-02-05 Marek Safar <marek.safar@gmail.com>
5339 A fix for bug #357047
5340 * ecore.cs: Applied C# 3.0 changes to better conversion.
5342 2008-02-05 Marek Safar <marek.safar@gmail.com>
5344 A fix for bug #358374
5345 * cs-parser.jay: Correctly set modifiers for all constructor types.
5347 2008-02-04 Marek Safar <marek.safar@gmail.com>
5349 A fix for bug #355251
5350 * generic.cs: Added base class constraint based type inference.
5352 2008-02-01 Marek Safar <marek.safar@gmail.com>
5354 A fix for bug #357255
5355 * decl.cs: One more missing visibility check.
5357 2008-02-01 Marek Safar <marek.safar@gmail.com>
5359 * support.cs: Fixed broken return.
5361 2008-01-25 Marek Safar <marek.safar@gmail.com>
5363 * report.cs: Correctly reset warnings count after probing.
5365 2008-01-25 Martin Baulig <martin@ximian.com>
5368 (NamespaceEntry.SymbolFileID): Make this work again after
5369 MemberName.ToString() is gone.
5371 2008-01-25 Marek Safar <marek.safar@gmail.com>
5373 * expression.cs: Implemented Divide, Equal, ExclusiveOr, GreaterThanOrEqual
5376 2008-01-25 Marek Safar <marek.safar@gmail.com>
5378 * generic.cs: Use full implicit conversion for type inference fixing.
5380 2008-01-24 Marek Safar <marek.safar@gmail.com>
5382 * ecore.cs, expression.cs, generic.cs: Implemented Convert, ConvertChecked.
5383 Fixed user operator conversions.
5385 2008-01-24 Marek Safar <marek.safar@gmail.com>
5387 * generic.cs: Do nullable type to null comparison optimization during
5390 2008-01-24 Marek Safar <marek.safar@gmail.com>
5392 A fix for bug #355163
5393 * generic.cs: Enabled l-value resolve on nullable expressions.
5395 2008-01-24 Marek Safar <marek.safar@gmail.com>
5397 A fix for bug #353986
5398 * class.cs: Ingore static ctors with parameters for any further checks.
5400 2008-01-24 Marek Safar <marek.safar@gmail.com>
5402 A fix for bug #354310
5403 * namespace.cs: Removed redundant check.
5405 2008-01-24 Marek Safar <marek.safar@gmail.com>
5407 A fix for bug #354928
5408 * expression.cs: ElementInitializers can be resolved only once.
5410 2008-01-24 Marek Safar <marek.safar@gmail.com>
5412 * convert.cs, ecore.cs, expression.cs, generic.cs: Implemented Coalesce and
5413 Condition expressions.
5415 2008-01-23 Marek Safar <marek.safar@gmail.com>
5417 * codegen.cs: Fixed AssemblyBuilder initialization on other platforms.
5419 2008-01-22 Marek Safar <marek.safar@gmail.com>
5421 * ecore.cs, expression.cs, generic.cs: Implicit bool? to bool conversion is
5424 * generic.cs: Implemented coalesce expression.
5426 2008-01-22 Marek Safar <marek.safar@gmail.com>
5428 A fix for bug #355145
5429 * anonymous.cs, convert.cs, ecore.cs, generic.cs, lambda.cs: Implemented
5430 expression tree type inference.
5432 2008-01-22 Raja R Harinath <harinath@hurrynot.org>
5435 * expression.cs (Binary.IsUnsignedType): Fix typo.
5437 2008-01-22 Marek Safar <marek.safar@gmail.com>
5439 * ecore.cs, expression.cs, generic.cs: Implemented NewArrayInit expression.
5441 2008-01-22 Marek Safar <marek.safar@gmail.com>
5443 A fix for bug #355161
5444 * ecore.cs, expression.cs: Wider range of extension method supported
5447 2008-01-22 Gert Driesen <drieseng@users.sourceforge.net>
5449 * codegen.cs: Use magic value for AssemblyBuilderAccess to instruct
5450 AssemblyBuilder to operate in compiler context. Fixes mcs part of
5453 2008-01-22 Marek Safar <marek.safar@gmail.com>
5455 A fix for bug #355148
5456 * ecore.cs, expression.cs: Correctly report misused ref and out modifiers.
5458 2008-01-22 Miguel de Icaza <miguel@novell.com>
5460 * expression.cs (CreateExpressionTree): Add support for or and
5461 logical or, and indent following the coding conventions.
5463 * typemanager.cs (LinqExpression): renamed from
5464 ExpressionTreeManager, for a shorter name.
5466 Use TypeManager.CoreLookupType to lookup types from our core
5467 assemblies and turn those into "Type" variables.
5469 Consumers that previously used "Namespace" and "Type" from this
5470 class should instead use the TypeExpression which is a type that
5471 is fully resolved (without involving the regular C# resolution
5474 This typically looks like this:
5476 TypeExpression texpr = new TypeExpression (LinqExpression.expression_type, loc);
5477 new MemberAccess (texpr, name, type_arguments, loc)
5479 This avoids the problem in: #355178
5481 2008-01-21 Marek Safar <marek.safar@gmail.com>
5483 * cs-parser.jay, expression.cs: Check `namespace alias qualifier' language
5484 feature in parser only as we do in other cases.
5486 2008-01-21 Marek Safar <marek.safar@gmail.com>
5488 * attribute.cs, ecore.cs, class.cs, delegate.cs, expression.cs, linq.cs,
5489 typemanager.cs: A refactoring of params arguments to reuse existing
5490 expressions (params -> array initializer) to emit params argument instead
5491 of specialized handling.
5492 It was required by expression tree implementation and it has other benefits
5493 as well, we now apply same optimization for params arguments as we do for
5496 2008-01-18 Marek Safar <marek.safar@gmail.com>
5498 A fix for bug #353526
5499 * generic.cs: A type inference of params arguments may not required any
5500 temporary array creation.
5502 2008-01-18 Marek Safar <marek.safar@gmail.com>
5504 A fix for bug #353534
5505 * generic.cs, ecore.cs, expression.cs: A method group type inference is
5506 supported for delegates only.
5508 2008-01-18 Marek Safar <marek.safar@gmail.com>
5510 * generic.cs: Fixed 3.0 type inference fixing phase to determine a unique
5511 type for more than 1 candidates.
5513 2008-01-18 Marek Safar <marek.safar@gmail.com>
5515 * typemanager.cs, ecore.cs, expression.cs: Implemented ArrayLength and Call
5518 2008-01-16 Marek Safar <marek.safar@gmail.com>
5520 * generic.cs, typemanager.cs, lambda.cs, parameter.cs, ecore.cs, constant.cs,
5521 expression.cs: Implemented Add, And, AndAlso, and ArrayIndex (without unary
5522 operator) expressions.
5524 2008-01-16 Zoltan Varga <vargaz@gmail.com>
5526 * statement.cs: Avoid declaring an IL variable for this_variable since it is
5527 not accessed from the generated IL.
5529 2008-01-14 Marek Safar <marek.safar@gmail.com>
5531 * typemanager.cs, lambda.cs, parameter.cs, ecore.cs, class.cs, delegate.cs,
5532 iterators.cs, convert.cs, assign.cs, anonymous.cs, expression.cs,
5533 statement.cs: The first expression tree implementation drop, mostly
5534 infrastructure work.
5536 2008-01-14 Marek Safar <marek.safar@gmail.com>
5538 * ecore.cs (IsNestedChild): Refactored.
5540 2008-01-11 Marek Safar <marek.safar@gmail.com>
5542 * lambda.cs: Don't use a cast on unknown expression statement.
5544 2008-01-10 Geoff Norton <gnorton@novell.com>
5546 * cs-tokenizer.cs: One more token to distinguish between method and lambda
5549 2008-01-09 Marek Safar <marek.safar@gmail.com>
5551 * doc.cs: Report better /doc crash details.
5553 2008-01-09 Marek Safar <marek.safar@gmail.com>
5555 A fix for bug #352536
5556 * ecore.cs, assign.cs, codegen.cs: Check event assignments.
5558 2008-01-08 Marek Safar <marek.safar@gmail.com>
5560 A fix for bug #352287
5561 * ecore.cs, expression.cs: Do `this' access checking in all member access
5564 2008-01-08 Marek Safar <marek.safar@gmail.com>
5566 * rootcontext.cs, driver.cs: Switch to linq mode by default.
5568 * report.cs: Reset message stacks.
5570 2008-01-08 Marek Safar <marek.safar@gmail.com>
5572 * generic.cs (InferInPhases): Correctly calculate params position.
5574 2008-01-08 Marek Safar <marek.safar@gmail.com>
5576 * cs-tokenizer.cs: No need to parse full string when parsing lambda
5579 2008-01-07 Marek Safar <marek.safar@gmail.com>
5581 * cs-tokenizer.cs: Enabled lambda arguments micro-parser for all profiles.
5583 * decl.cs (LookupNamespaceOrType): Don't cache names which caused an error.
5585 * driver.cs: Updated --help option.
5587 2008-01-07 Marek Safar <marek.safar@gmail.com>
5589 * generic.cs (InferParamsTypeArguments): Removed.
5590 (InferInPhases): Add params type inference.
5591 (LowerBoundInference): Fixed scoring mechanism.
5593 * cs-tokenizer.cs (PreProcessPragma): Use Location instead of line.
5595 2008-01-06 Gert Driesen <drieseng@users.sourceforge.net>
5597 * typemanager.cs: On 2.0 profile, GetPublicKeyToken returns an empty
5598 byte array for unsigned "baked" assemblies.
5600 2008-01-05 Gert Driesen <drieseng@users.sourceforge.net>
5602 * codegen.cs: AssemblyName.GetPublicKey returns a zero-length byte
5603 array for assemblies that are not strongnamed.
5605 2008-01-04 Marek Safar <marek.safar@gmail.com>
5607 A fix for bug #351481
5608 * expression.cs (MemberAccess.ResolveNamespaceOrType): Use correct
5609 declaring type for nested generic types.
5611 2008-01-04 Marek Safar <marek.safar@gmail.com>
5613 * namespace.cs, class.cs, decl.cs, cs-parser.jay: Use GetSignatureForError
5614 instead of ToString.
5616 2008-01-03 Marek Safar <marek.safar@gmail.com>
5618 A fix for bug #351047
5619 * expression.cs (Binary.ResolveOperator): Allow equality operators between
5620 null and structs only when equality and inequality operators are defined
5621 either as an user-operators or predefined operators.
5623 2008-01-03 Marek Safar <marek.safar@gmail.com>
5625 A fix for bug #351047
5626 * generic.cs, typemanager.cs, class.cs: New IsReferenceType helper method.
5628 2008-01-03 Marek Safar <marek.safar@gmail.com>
5630 A fix for bug #351257
5631 * cs-tokenizer.cs: Advance line number for '\r' correctly.
5633 2008-01-03 Marek Safar <marek.safar@gmail.com>
5635 A fix for bug #351157
5636 * class.cs (Using): Fixed yet another broken cloning.
5638 (Block): Put back more sensible default value for statements.
5640 2008-01-01 Gert Driesen <drieseng@users.sourceforge.net>
5642 * codegen.cs: Allow AssemblyVersion with only major version component.
5645 2007-12-29 Marek Safar <marek.safar@gmail.com>
5647 A fix for bug #324654
5648 * class.cs: Use FullName property as member name.
5650 2007-12-28 Marek Safar <marek.safar@gmail.com>
5652 A fix for bug #342117
5653 * generic.cs (ConstraintChecker): Struct constraint also satisfies default
5654 constructor constraint.
5656 2007-12-28 Marek Safar <marek.safar@gmail.com>
5658 A fix for bug #338273
5659 * class.cs (ProbertyBase): Access modifier checks are required for overrides
5662 2007-12-28 Marek Safar <marek.safar@gmail.com>
5664 A fix for bug #350839
5665 * ecore.cs (MethodroupExpr): Probing hacks are no longer required.
5667 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5669 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5672 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5674 * statement.cs: Changed some Hashtables to use HybridDictionaries
5675 instead. It was observed that some HashTables only contained a few
5676 items in the vast majority of cases. Since HybridDictionary is
5677 more efficient on small sets (<10 elements), "known_variables"
5678 from class ExplicitBlock as well as "labels" and "constants " from
5679 class Block were changed to HybridDictionaries.
5681 Atsai results: (56216kb->54987kb)
5683 Miguel results (bootstrap of mcs): 59819kb -> 59290kb
5686 2007-12-27 AdTsai (http://code.google.com/u/AdTsai/)
5688 Reviewed by Ben Maurer, Miguel de Icaza, patches from Google's
5691 http://code.google.com/p/google-highly-open-participation-mono/issues/detail?id=4
5693 * expression.cs: foreach loop to for loop, saved on allocation of
5694 enumerator (59333kb->59141kb)
5696 * statement.cs. Changed foreach loops to for loops, saved on
5697 allocation of enumerator (59141kb->59006kb)
5699 * decl.cs: ArrayLists in .NET 1.1 allocate 16 elements by default
5700 when constructed with no specified capacity. This was causing a
5701 few ArrayLists to allocate more memory than they would potentially
5702 need in the Block class and MemberCache class. Setting the
5703 ArrayLists to construct with a capacity of 1 saves some
5704 memory. (56216kb->55585kb)
5706 2007-12-27 Marek Safar <marek.safar@gmail.com>
5708 A fix for bug #347189 (2nd issue)
5709 * expression.cs (MemberAccess): Nested type can be found in base non-generic
5712 2007-12-27 Miguel de Icaza <miguel@novell.com>
5714 * report.cs: Do not use colors if stdout and stderr are not a
5717 2007-12-27 Marek Safar <marek.safar@gmail.com>
5719 A fix for bug #346998
5720 * ecore.cs (MethodGroupExpr): Implemented override filter for generic
5723 2007-12-27 Marek Safar <marek.safar@gmail.com>
5725 A fix for bug #343465
5726 * class.cs: Explicit method name for nested types uses dots only.
5728 2007-12-27 Marek Safar <marek.safar@gmail.com>
5730 A fix for bug #343707
5731 * cs-tokenizer.cs: Advance line number for mixed CR/LF files correctly.
5733 2007-12-27 Marek Safar <marek.safar@gmail.com>
5735 * ecore.cs: Report type inference errors only when arguments count matches
5738 * generic.cs (NullCoalescingOperator): Cannot be applied to null.
5740 * expression.cs, report.cs: New warning.
5742 * typemanager.cs: Catch anonymous method type too.
5744 2007-12-23 Marek Safar <marek.safar@gmail.com>
5746 A fix for bug #346379
5747 * expression.cs (UnaryMutator): Emit size of type for pointer mutator.
5749 2007-12-23 Marek Safar <marek.safar@gmail.com>
5751 A fix for bug #347359
5752 * expression.cs (Invocation): Don't resolve already resolved expression.
5754 2007-12-23 Marek Safar <marek.safar@gmail.com>
5756 A fix for bug #347189
5757 * class.cs (FixedField): Use non-dependent code only in the define phase.
5759 2007-12-23 Marek Safar <marek.safar@gmail.com>
5761 A fix for bug #348076
5762 * ecore.cs (FieldExpr.DoResolve): Allow any variable based expression.
5764 2007-12-22 Marek Safar <marek.safar@gmail.com>
5766 * ecore.cs (MethodGroupExpr.OverloadResolve): Set type arguments for
5767 discovered extension methods.
5769 2007-12-22 Marek Safar <marek.safar@gmail.com>
5771 * ecore.cs, namespace.cs, expression.cs: Removed broken ResolveGeneric
5774 2007-12-21 Miguel de Icaza <miguel@novell.com>
5776 * report.cs (ErrorMessage): Add support for using colors on
5777 terminals that support it.
5779 2007-12-21 Marek Safar <marek.safar@gmail.com>
5781 * ecore.cs: Use information about expanded params for error reporting.
5783 2007-12-21 Marek Safar <marek.safar@gmail.com>
5785 * ecore.cs, generic.cs, delegate.cs: Refactoring of method overloading code
5786 and logic for params overloads.
5788 2007-12-15 Miguel de Icaza <miguel@novell.com>
5790 * generic.cs (NullCoalescingOperator.CloneTo): implement this one,
5791 as this is also created from the parser. Fixes #349034
5793 2007-12-12 Miguel de Icaza <miguel@novell.com>
5795 * statement.cs (Throw.CloneTo): it is valid to have empty
5796 expressions for throw.
5798 2007-12-03 Marek Safar <marek.safar@gmail.com>
5800 * cs-parser.jay: Set delegate constraint parsing region correctly.
5802 2007-12-03 Marek Safar <marek.safar@gmail.com>
5804 A fix for bug #345467
5805 * typemanager.cs (IsEqual): Compare generic parameters position only.
5807 2007-11-28 Marek Safar <marek.safar@gmail.com>
5809 * expression.cs (BaseAccess): Type arguments can be null.
5811 2007-11-27 Raja R Harinath <harinath@gmail.com>
5813 * statement.cs (Block.Resolve): Ensure flow-branching tree is
5814 consistent even when an error has occured.
5815 (Switch.Resolve): Likewise.
5817 2007-11-22 Marek Safar <marek.safar@gmail.com>
5819 A fix for bug #334505
5820 * class.cs: Don't ignore InternalsVisibleTo attribute for internal
5823 2007-11-22 Marek Safar <marek.safar@gmail.com>
5825 * ecore.cs, typemanager.cs, delegate.cs, expression.cs: The first of
5826 refactorings required to resolve extension methods correctly when mixing
5827 generics and non-generics members.
5829 2007-11-20 Marek Safar <marek.safar@gmail.com>
5831 A fix for bug #342584
5832 * convert.cs: Added not documented explicit IntPtr/UIntPtr to enum
5835 2007-11-19 Marek Safar <marek.safar@gmail.com>
5837 A fix for bug #342512
5838 * delegate.cs: Use delegate argument expression when is available. Don't
5839 emit virtual call when class is sealed.
5841 2007-11-16 Marek Safar <marek.safar@gmail.com>
5843 A fix for bug #325423
5844 * assign.cs (FieldInitializer): Use resolved expression for emit.
5846 * class.cs: Print less confusing error message.
5848 2007-11-16 Marek Safar <marek.safar@gmail.com>
5850 * cs-tokenizer.cs: Removed GMCS ifdefs.
5852 * rootcontext.cs, report.cs: Report unavailable gmcs features used by
5855 * cs-parser.jay: Disabled nullable check.
5857 * generic-mcs: Copied more generic stuff.
5859 2007-11-16 Marek Safar <marek.safar@gmail.com>
5861 * gcs-parser.jay: Merged to cs-parser.jay.
5863 * generic.cs, typemanager.cs, cs-tokenizer.cs, linq.cs, Makefile
5864 * *.csproj, *.sources: Updated to use only jay parser file.
5866 2007-11-16 Marek Safar <marek.safar@gmail.com>
5868 * gcs-parser.jay: Added nullable and default expression feature checks.
5870 2007-11-16 Marek Safar <marek.safar@gmail.com>
5872 * gcs-parser.jay, cs-parser.jay, class.cs: Unified parameters parsing,
5873 it fixes many TODOs and hidden bugs.
5875 * expression: Removed duplicate error check.
5877 2007-11-15 Marek Safar <marek.safar@gmail.com>
5879 * gcs-parser.jay, statement.cs, decl.cs, ecore.cs: Try to resolve an
5880 implicitly type local variable only when it is used in a declaration.
5882 2007-11-15 Marek Safar <marek.safar@gmail.com>
5884 * attribute.cs: Use CS0612 for empty strings.
5886 2007-11-14 Marek Safar <marek.safar@gmail.com>
5888 * lambda.cs, statement.cs: Contextual return may act as a statement.
5890 2007-11-14 Marek Safar <marek.safar@gmail.com>
5892 A fix for a regression cause by #324222
5893 * class.cs: Don't report unused even when it implements an interface.
5895 2007-11-13 Marek Safar <marek.safar@gmail.com>
5897 A fix for bug #341205
5898 * ecore.cs, expression.cs: Method group expression cannot do static
5899 method access with an instance reference check before overloading takes
5902 2007-11-13 Marek Safar <marek.safar@gmail.com>
5904 A fix for bug #325359
5905 * class.cs: Use predictable name for automatically generated property.
5907 2007-11-12 Marek Safar <marek.safar@gmail.com>
5909 A fix for bug #324996
5910 * expression.cs (Is): Handle case where D is nullable and T is not
5913 * generics.cs (Nullable.HasValue): Nullable HasValue expression.
5915 2007-11-12 Marek Safar <marek.safar@gmail.com>
5917 * generic.cs, literal.cs, ecore.cs, class.cs, delegate.cs, const.cs,
5918 anonymous.cs, expression.cs, attribute.cs, codegen.cs, statement.cs:
5919 Flush small error reporting changes.
5921 2007-11-09 Marek Safar <marek.safar@gmail.com>
5923 A fix for bug #324996
5924 * expression.cs: Rewrote Is expression implementation to work with
5925 generics, nullable types, anonymous method. A const result expression
5926 uses existing infrastructure instead of custom not fully-featured one.
5928 2007-11-08 Marek Safar <marek.safar@gmail.com>
5930 A fix for bug #340202
5931 * class.cs: Consider generics for volatile field.
5933 2007-11-08 Marek Safar <marek.safar@gmail.com>
5935 A fix for bug #335594
5936 * expression.cs: Use conversion rules when handling string addition.
5938 2007-11-07 Marek Safar <marek.safar@gmail.com>
5940 A fix for bug #336651
5941 * expression.cs: Fixed a crash when probing is on.
5943 2007-11-07 Marek Safar <marek.safar@gmail.com>
5945 A fix for bug #324242
5946 * covert.cs: Added a conversion from any nullable-type with an
5947 underlying enum-type to the type System.Enum.
5949 2007-11-07 Marek Safar <marek.safar@gmail.com>
5951 A fix for bug #324222
5952 * class.cs: Report all non-used event fields.
5954 2007-11-07 Marek Safar <marek.safar@gmail.com>
5956 A fix for bug #325161
5957 * cs-parser.jay, gcs-parser.jay, decl.cs: Implemented namespace alias
5958 qualifier for generic types.
5960 2007-11-07 Marek Safar <marek.safar@gmail.com>
5962 A fix for bug #322971
5963 * expression.cs, ecore.cs: Added intermediate result value check for
5966 2007-11-07 Marek Safar <marek.safar@gmail.com>
5968 A fix for bug #324754
5969 * cs-parser.jay, gcs-parser.jay, class.cs: Try to create an interator
5970 when it was requested.
5972 2007-11-07 Marek Safar <marek.safar@gmail.com>
5974 A fix for bug #325101
5975 * expression.cs: Do type not value comparison for `is' expression.
5977 2007-11-07 Marek Safar <marek.safar@gmail.com>
5979 A fix for bug #320236
5980 * convert.cs: Don't apply user conversion on underlying target type.
5982 2007-11-06 Marek Safar <marek.safar@gmail.com>
5984 * expression.cs: Don't use unresolved expression for error reporting.
5986 2007-11-06 Marek Safar <marek.safar@gmail.com>
5988 A fix for bugs #337712, #324490
5989 * ecore.cs (MethodGroupExpr): Refactored to handle delegate method
5990 overloading resolution too.
5992 * delegate.cs: Uses MethodGroupExpr for overloading resolution. It makes
5993 the process consistent and more robust.
5995 * expression.cs, linq.cs, report.cs: Update.
5997 2007-11-02 Marek Safar <marek.safar@gmail.com>
5999 A fix for bug #332909
6000 * attribute.cs: Resolve attributes in correct context using error
6003 * rootcontext.cs: Define Obsolete attribute members as core members.
6005 2007-11-02 Marek Safar <marek.safar@gmail.com>
6007 * statement.cs: Removed unused methods.
6009 2007-10-31 Wade Berrier <wberrier@novell.com>
6011 * Makefile: reenable copy of gmcs.exe.config, but include it in EXTRA
6012 DIST (it doesn't get included because PROGRAM isn't defined to be gmcs
6015 2007-10-31 Marek Safar <marek.safar@gmail.com>
6017 A fix for bug #338102
6018 * decl.cs (CheckExistingMembersOverloads): Workaround issue with generic
6019 methods registered as non-generics.
6021 2007-10-31 Marek Safar <marek.safar@gmail.com>
6023 A fix for bugs #337712, #324490
6024 * delegate.cs: Delegate covariance and contravariance is not allowed for
6027 2007-10-31 Marek Safar <marek.safar@gmail.com>
6029 A fix for bug #337719
6030 * cs-tokenizer.cs: Restore identifier buffer when parsing contextual
6033 2007-10-30 Marek Safar <marek.safar@gmail.com>
6035 * Makefile (net_2_0_bootstrap/mcs.exe.config): Reverted copy gmcs.exe.config.
6037 2007-10-29 Marek Safar <marek.safar@gmail.com>
6039 * cs-tokenizer.cs, gcs-parser.jay, driver.cs: Fixed parsing of nested
6042 2007-10-29 Raja R Harinath <rharinath@novell.com>
6044 * Makefile (net_2_0_bootstrap/mcs.exe.config): Copy gmcs.exe.config.
6046 2007-10-29 Marek Safar <marek.safar@gmail.com>
6048 A fix for bug #334652
6049 * ecore.cs (MethodGroupExpr.OverloadResolve): Do also lookup for
6050 extension methods when we have not found the best candidate in normal
6053 2007-10-27 Marek Safar <marek.safar@gmail.com>
6055 * AssemblyInfo.cs: Keep up-to-date.
6057 2007-10-27 Marek Safar <marek.safar@gmail.com>
6059 * Makefile: Fixed generics compiler name.
6061 2007-10-27 Marek Safar <marek.safar@gmail.com>
6063 * lambda.test: removed, lambda parsing is done differently.
6065 * gen-il.cs, gen-treedump.cs, old-code.cs : Obsolete.
6067 2007-10-27 Gert Driesen <drieseng@users.sourceforge.net>
6069 * Makefile: Removed dependency on gmcs.exe.config. Fixes build.
6071 2007-10-27 Marek Safar <marek.safar@gmail.com>
6073 * Makefile, *.sources : All C# compilers are in mcs folder.
6075 * *.cs: Use existing 2_1 define for smcs.
6077 2007-10-26 Marek Safar <marek.safar@gmail.com>
6079 A fix for bug #335847
6080 * assign.cs, expression.cs: Couple of changes to avoid creating a
6081 temporary variable for each object initializer assignment statement. It
6082 simplifies struct initialization too, otherwise two temporary variables
6084 Implemented optimization of redundant default element initializers.
6086 2007-10-25 Marek Safar <marek.safar@gmail.com>
6088 A fix for bug #336766
6089 * expression.cs (Class.CheckBase): Use generic name when method is
6092 2007-10-25 Marek Safar <marek.safar@gmail.com>
6094 A fix for bug #334737
6095 * expression.cs (IndexerAccess.EmitAssign): Emit local temporary
6096 variable and not variable argument for prepared copies.
6098 2007-10-24 Marek Safar <marek.safar@gmail.com>
6100 A fix for bug #325110
6101 * class.cs, expression.cs, attribute.cs: Use open generic method when
6102 checking conditional attribute.
6104 2007-10-24 Marek Safar <marek.safar@gmail.com>
6106 * report.cs, cs-tokenizer.cs, class.cs, cs-parser.jay, anonymous.cs,
6107 expression.cs, statement.cs: Renamed method FeatureIsNotISO to
6108 FeatureIsNotAvailable.
6110 2007-10-24 Marek Safar <marek.safar@gmail.com>
6112 ** C# 3.0 Partial methods
6114 * cs-tokenizer.cs, support.cs, class.cs, decl.cs: Implemented partial
6115 methods support. Because of member cache issue with generics only
6116 non-generics partial methods are fully supported.
6118 2007-10-23 Marek Safar <marek.safar@gmail.com>
6120 * class.cs, decl.cs: Rewrote member overloads check to cope with
6121 generics and to use member cache for member checking. It also improves
6122 performance and fixes remaining overloads issues.
6124 2007-10-20 Marek Safar <marek.safar@gmail.com>
6126 * class.cs, const.cs, decl.cs, delegate.cs, enum.cs, generic.cs,
6127 roottypes.cs, typemanager.cs:
6129 A member cache creation logic changed to add members immediately and
6130 not rely on fallback. The member cache is now only prefered way
6131 how to access and find type declaration members. It saves 5 MB of memory
6132 during MWF compilation and makes code ready for more optimizations and
6133 clean-ups, it's also a pre-requirement for partial methods.
6135 2007-10-18 Raja R Harinath <harinath@gmail.com>
6137 * ecore.cs (Expression.Error_ValueCannotBeConverted): Add special
6138 handling for generic parameters.
6140 2007-10-15 Marek Safar <marek.safar@gmail.com>
6142 * class.cs (FixedField): Removed redundant volatile check.
6144 2007-10-15 Marek Safar <marek.safar@gmail.com>
6146 * class.cs, decl.cs: Fixed overload members verification to do only one
6147 check per possible collision.
6149 2007-10-13 Marek Safar <marek.safar@gmail.com>
6151 A fix for bug #325478
6152 * anonymous.cs (AnonymousContainer.Compatible): Merge are flags together
6153 and create only one disposable flags container.
6155 2007-10-12 Marek Safar <marek.safar@gmail.com>
6157 A fix for bug #332442 by Alexandre Gomes <alexmipego@gmail.com>
6158 * statement.cs (Fixed): Fixed variables cloning.
6160 2007-10-12 Marek Safar <marek.safar@gmail.com>
6162 A fix for bug #333342
6163 * class.cs (EventField): Don't mark value type event as synchronized.
6165 2007-10-12 Marek Safar <marek.safar@gmail.com>
6167 * ecore.cs, anonymous.cs (MethodGroupExpr): Use score from type
6168 inference to identify best candidate method correctly.
6169 (ProperyExpr): A range variable is read only and cannot be modified.
6171 2007-10-11 Marek Safar <marek.safar@gmail.com>
6173 * ecore.cs, delegate.cs (MethodGroupExpr): Refactored best candidate
6174 logic to identify best candidate method correctly.
6176 2007-10-11 Marek Safar <marek.safar@gmail.com>
6178 * location.cs (Equals, GetHashCode): Removed.
6180 2007-10-11 Marek Safar <marek.safar@gmail.com>
6182 * report.cs: Implemented message recorder. It is used mainly for lambda
6183 expressions to capture otherwise swallowed error messages.
6185 * anonymous.cs, lambda.cs.cs: Do full parameters check.
6187 * ecore.cs (ExtensionMethodGroup): Report binding failure at the botton
6189 (MethodGroupExpr.DoResolve): Use message recorder for error handling.
6191 * expression.cs (MemberAccess): Always report lookup failure.
6193 * location.cs: Implemented Equals, GetHashCode.
6195 * statement.cs (Return.DoResolve): Fixed hardcoded error argument.
6197 2007-10-10 Jb Evain <jbevain@novell.com>
6199 * codegen.cs: re-enable assembly version check.
6201 2007-10-09 Marek Safar <marek.safar@gmail.com>
6203 * report.cs, anonymous.cs, driver.cs, expression.cs: Added few ISO-2
6206 * namespace.cs (UsingAlias): Do correct version check.
6208 2007-10-08 Marek Safar <marek.safar@gmail.com>
6210 * expresison.cs, ecore.cs: Issue extension method error message when
6213 * rootcontext.cs: Added ISO_2 compiler mode option.
6215 2007-10-08 Marek Safar <marek.safar@gmail.com>
6217 * expresison.cs (UnaryMutator.ResolveOperator): Print more useful error
6220 2007-10-08 Marek Safar <marek.safar@gmail.com>
6222 * attribute.cs (GetString, GetBoolean): Work with both literal and
6225 * ecore.cs, expresison.cs, delegate.cs (Invocation, MethodGroupExpr):
6226 Moved method overload specific methods to MethodGroupExpr.
6228 (IndexerAccess): Re-wrote resolving mechanism, fixed many issues and
6229 it should be less memory consuming.
6231 Mon Oct 8 09:29:15 CEST 2007 Paolo Molaro <lupus@ximian.com>
6233 * codegen.cs: remove the assembly version check until the buildbot is
6236 2007-10-07 Jb Evain <jbevain@novell.com>
6238 * attribute.cs (Attribute.GetString): if the value
6239 expression is a StringConstant, return its string value.
6241 2007-10-07 Jb Evain <jbevain@novell.com>
6243 * typemanager.cs: add `assembly_version_attribute_type`.
6244 * codegen.cs: on attribute emission, check that the
6245 AssemblyVersionAttribute doesn't overflow.
6247 2007-10-05 Marek Safar <marek.safar@gmail.com>
6249 A fix for bug #324677
6250 * anonymous.cs, decl.cs: Yes another anonymous container hack. Overwrite
6251 parent container of a scope container with currently resolved one.
6253 2007-10-05 Marek Safar <marek.safar@gmail.com>
6255 A fix for bug #325534
6256 * class.cs (Invocation.DoResolve): Check invocation of object finalizer
6259 2007-10-05 Marek Safar <marek.safar@gmail.com>
6261 A fix for bug #327504
6262 * class.cs (Operator.Define): Refactored implicit and explicit user
6263 operator conversion rules.
6265 2007-10-05 Marek Safar <marek.safar@gmail.com>
6267 A fix for bug #327520
6268 * ecore.cs (ExtensionMethodGroupExpr): Emit resolved extension argument.
6270 2007-10-04 Marek Safar <marek.safar@gmail.com>
6272 A fix for bug #328022
6273 * class.cs (MethodData.Define): Use correct method to check whether
6274 a method implementents an accessor.
6276 2007-10-04 Marek Safar <marek.safar@gmail.com>
6278 A fix for bug #330069
6279 * statement.cs (Fixed.Resolve): Read the first array element only when
6280 an array is instantiated.
6282 2007-10-04 Marek Safar <marek.safar@gmail.com>
6284 * expression.cs, assign.cs, generics.cs: Print correct operator when
6285 compound assignment is used.
6287 2007-10-04 Marek Safar <marek.safar@gmail.com>
6289 A fix for bug #325841
6290 * expression.cs (ArrayAccess): Use full argument cloning only for
6291 string compound concatenation.
6293 2007-10-03 Marek Safar <marek.safar@gmail.com>
6295 A fix for bug #328774
6296 * ecore.cs (FieldExpr.EmitAssign): Fixed string concatenation compound
6298 (PropertyExpr.EmitAssign): Fixed string concatenation compound
6301 2007-10-03 Raja R Harinath <rharinath@novell.com>
6304 * ecore.cs (SimpleName.DoSimpleNameResolve): Handle Property and
6305 Event accessibility checks here. Remove some bogus code that
6306 accidently made GenericMethods work.
6307 (PropertyExpr.IsAccessibleFrom, EventExpr.IsAccessibleFrom): New.
6309 2007-09-25 Marek Safar <marek.safar@gmail.com>
6311 * expression.cs (ArrayCreation): Fixed cloning of an implicit types.
6313 * statement.cs (Block): Refactored AddVariable to allow error handling
6316 * generic.cs: New stub.
6318 2007-09-23 Marek Safar <marek.safar@gmail.com>
6320 * anonymous.cs, codegen.cs: Changed InferReturnType to be EmitContext
6323 2007-09-17 Marek Safar <marek.safar@gmail.com>
6325 * class.cs: Use partial container to record whether any partial part
6326 contains static field initializer and therefore default contructor has
6329 2007-09-14 Marek Safar <marek.safar@gmail.com>
6331 * class.cs (TypeContainer.AddPartial): Fixed an issue reported on
6332 mono-list when only one of two partial parts has defined accessibility
6335 2007-09-14 Marek Safar <marek.safar@gmail.com>
6337 A fix for bug #82845
6339 * class.cs (TypeContainer): Set correct resolve context for all field
6342 2007-09-13 Marek Safar <marek.safar@gmail.com>
6344 * assign.cs: Fixed a crash when field is resolved twice with an error.
6346 * codegen.cs: Changed InFieldInitializer to be flag.
6348 * anonymous.cs, ecore.cs, expression.cs: Update after
6349 IsInFieldInitializer rename.
6351 * const.cs: Removed unused parameter.
6353 * class.cs: Changed the way how we resolve and emit field initializers.
6354 The field initilizers have to have access to contructor block to emit
6355 compiler generated code.
6357 2007-09-13 Marek Safar <marek.safar@gmail.com>
6359 * expression.cs (MemberAccess.DoResolve): DeclSpace is broken by
6360 generics use TypeContainer instead.
6362 2007-09-12 Marek Safar <marek.safar@gmail.com>
6364 * generic.cs (TypeInferenceContext.InflateGenericArgument): Stub.
6366 * lambda.cs (ResolveParameters): Use more powerful
6367 InflateGenericArgument.
6369 * parameters.cs: Better exception message.
6371 2007-09-10 Marek Safar <marek.safar@gmail.com>
6373 * anonymous.cs (AnonymousMethodExpression.CompatibleChecks): Report
6374 correct expression block type.
6376 * ecore.cs (Expression.Error_MemberLookupFailed): Made virtual.
6378 * expression.cs (Invocation): Extracted method group resolve to
6381 2007-09-07 Marek Safar <marek.safar@gmail.com>
6383 * ecore.cs (Expression.MemberLookupFinal): Removed unused loc parameter.
6384 (MethodGroupExpr.ResolveGeneric): Use existing method group instance.
6386 * expression.cs (MemberAccess.DoResolve): Uses generic resolver for
6387 generic extension methods.
6389 2007-09-06 Marek Safar <marek.safar@gmail.com>
6391 A fix for bug #82676 (Do I get it right now?)
6392 * convert.cs (Binary.ResolveOperator): An interface is converted to the
6393 object before a standard conversion is applied.
6395 2007-09-06 Marek Safar <marek.safar@gmail.com>
6397 * convert.cs (ImplicitReferenceConversionCore): Reverted wrong fix of
6400 2007-09-05 Marek Safar <marek.safar@gmail.com>
6402 A fix for bug #82676
6403 * convert.cs (ImplicitReferenceConversionCore): Check both sides for
6404 non-generic interface types.
6406 2007-09-05 Marek Safar <marek.safar@gmail.com>
6408 A fix for bug #82690
6409 * ecore.cs (PropertyExpr.EmitAssign): Leave a copy does just that.
6411 2007-09-05 Marek Safar <marek.safar@gmail.com>
6413 A fix for bug #82571
6414 * anonymous.cs (AnonymousMethod.DoCreateMethodHost): Use internal
6415 modifier for container based methods.
6417 2007-09-05 Marek Safar <marek.safar@gmail.com>
6419 A fix for bug #82676
6420 * convert.cs (ImplicitReferenceConversionCore): From any class-type S to
6421 any interface-type T means to any of interface type T.
6423 2007-09-04 Marek Safar <marek.safar@gmail.com>
6425 * namespace.cs: We have 2 versions of System.Core assembly.
6427 2007-09-04 Marek Safar <marek.safar@gmail.com>
6429 A fix for bug #82652
6430 * class.cs (Class.GetClassBases): Compare types and not expressions.
6432 2007-09-04 Marek Safar <marek.safar@gmail.com>
6434 A fix for bug #82620
6435 * expression.cs (Invocation.EmitArguments): Duplicate params arguments
6436 actually never worked before.
6437 (IndexerAccess): Emit prepared arguments before they are modified.
6439 2007-09-04 Marek Safar <marek.safar@gmail.com>
6441 A fix for bug #82563
6442 * assign.cs: Revert wrong fix.
6444 * expression.cs (VariableReference.EmitAssign): Handle ref reference
6446 (ArrayAccess): Changed the way we emit compound (prepared) assignments.
6447 Instead of ldelema/stdind we have to use temporary variables to handle
6448 cases like String.Concat (params string[]).
6450 2007-08-31 Marek Safar <marek.safar@gmail.com>
6452 * class.cs: EmitAttributes to Emit rename.
6454 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Parent can be
6456 (MemberCore.HasClsCompliantAttribute): Don't depend on
6457 GetClsCompliantAttributeValue execution.
6459 2007-08-31 Marek Safar <marek.safar@gmail.com>
6461 * anonymous.cs: Use shorter type prefix.
6463 * ecore.cs (SimpleName.DoSimpleNameResolve): Use transparent identifiers
6466 * expression.cs (LocalVariableReference.DoResolveBase): Don't capture
6467 variables when probing is on.
6469 * statement.cs (LocaLInfo.Clone): Clone correctly resolved and
6470 unresolved variables.
6471 (TopLevelBlock.GetTransparentIdentifier): Default implementation doesn't
6472 handle transparent identifiers.
6474 2007-08-26 Marek Safar <marek.safar@gmail.com>
6476 * attribute.cs (IsClsCompliant): Add nullable types test.
6478 2007-08-24 Atsushi Enomoto <atsushi@ximian.com>
6480 * doc.cs : catch other types of exception than XmlException to
6481 report CS1570. Fixed bug #82565.
6483 2007-08-23 Marek Safar <marek.safar@gmail.com>
6485 * anonymous.cs (AnonymousMethodExpressin.ExplicitTypeInference):
6486 The number of delegate parameters has to match.
6487 (AnonymousMethodExpressin.VerifyParameterCompatibility): Handles generic
6490 2007-08-21 Marek Safar <marek.safar@gmail.com>
6492 * anonymous.cs (AnonymousMethod): Generate private anonymous method
6493 to fix problem with private arguments.
6495 2007-08-20 Marek Safar <marek.safar@gmail.com>
6497 * anonymous.cs (AnonymousTypeClass): An anonymous type can be empty.
6499 * decl.cs (MemberName): Ignore generic type with no generic arguments.
6501 * expression.cs (AnonymousTypeDeclaration): An anonymous type can be
6502 empty. Add cloning suport.
6504 * roottypes.cs (GetAnonymousType): Fixed argument comparison logic.
6506 2007-08-20 Marek Safar <marek.safar@gmail.com>
6508 * convert.cs, ecore.cs, expression.cs, literal.cs: Use factory method
6509 to create EmptyCast. It handles EmptyConstantCast specialization for
6512 2007-08-18 Marek Safar <marek.safar@gmail.com>
6514 * expression.cs (Binary.is_unsigned): Handle unsafe types too.
6515 (EmitArrayArgument): One routine for array arguments.
6516 (ArrayCreation.MakeByteBlob): Fixed an array alignment.
6518 2007-08-17 Marek Safar <marek.safar@gmail.com>
6520 * cs-tokenizer.cs (GetKeyword): Handle from keyword in a different way.
6522 2007-08-17 Marek Safar <marek.safar@gmail.com>
6524 * anonymous.cs: MemberLookupFinal update.
6526 * class.cs (ConstructorInitializer): Is expression based.
6528 * delegate.cs: MethodGroupExpr update.
6530 * ecore.cs (Error_MemberLookupFailed): Improved to report better error
6532 (Error_MemberLookupFailed): Customizable error override.
6533 (MethodGroupExpr): Keep queried type for later usage.
6534 (MethodGroupExpr.OverloadResolve): Catch errors related to overload
6537 * expression.cs: Error_MemberLookupFailed refactoring.
6538 (New.DoResolve): Resolve as much as possible.
6539 (ElementInitializer.Error_MemberLookupFailed): Object initializer
6540 customization for invalid member types.
6542 * statement.cs: MethodGroupExpr update.
6544 2007-08-16 Marek Safar <marek.safar@gmail.com>
6546 * modifier.cs (Check): Check all modifiers and not only accessibility
6549 2007-08-16 Marek Safar <marek.safar@gmail.com>
6551 * ecore.cs (Expression.Error_ValueCannotBeConverted): Report always a
6552 type and not an expression.
6554 2007-08-16 Marek Safar <marek.safar@gmail.com>
6556 * statement.cs (Catch.Clone): Type and variable can be null.
6558 2007-08-16 Marek Safar <marek.safar@gmail.com>
6560 A fix for bug #81979
6561 * assign.cs (Assign.Emit): Prepare arguments for string concatenation.
6562 I am really not sure whether this is the best fix.
6564 * expression.cs (VariableReference.EmitAssign): Do prepare_load test
6567 2007-08-14 Marek Safar <marek.safar@gmail.com>
6569 ** C# 3.0 Object and collection initializers (major re-write)
6571 * assign.cs (DoResolve): Initializers are not assign related.
6573 * codegen.cs (EmitContext.CurrentInitializerVariable): Holds a varible
6574 used during collection or object initialization.
6576 * expression.cs (Error_InvalidArguments): Add initializers specific
6577 messages. More will come later because it requires some general
6579 (New.DoResolve): Better error handling for unsafe types.
6580 (EmptyExpressionStatement): New class.
6581 (ElementInitializer): An object initializer expression.
6582 (CollectionElementInitializer): A collection initializer expression.
6583 (CollectionOrObjectInitializers): A block of object or collection
6585 (NewInitialize): New expression with element/object initializers.
6587 * statement.cs: Reverted object/collection initializer hacks.
6589 * typemanager.cs (CSharpName): Filter __arglist type.
6591 2007-08-09 Marek Safar <marek.safar@gmail.com>
6593 ** C# 3.0 Anonymous Types (update to the latest standard)
6595 * expression.cs (Binary.ResolveOperator): Threat all null based types
6597 (AnonymousTypeDeclaration): Renamed from AnonymousType and simplified.
6598 (AnonymousTypeParameter): Updated.
6600 * anonymous.cs (CompilerGeneratedClass): Add custom name overload.
6601 (AnonymousTypeClass): New anonymous type container.
6603 * class.cs (AddField): Return operation result.
6605 * generic.cs: Another empty TypeArguments overload.
6607 * roottypes.cs (AddAnonymousType, GetAnonymousType): Anonymous types
6608 are stored at top of normal hierarchy.
6610 * typemanager.cs (CSharpName): Filter anonymous types.
6612 2007-08-09 Marek Safar <marek.safar@gmail.com>
6614 * expression.cs (StringConcat.Append): Handle 3 and more concatenation
6615 as single Concat call. How could we miss that :-(
6617 2007-08-08 Marek Safar <marek.safar@gmail.com>
6619 * expression.cs (ArrayCreation.CloneTo): Allocate exact size.
6621 2007-08-07 Miguel de Icaza <miguel@novell.com>
6623 * expression.cs: Fix the previous commit, the creation of the
6624 arguments array list needs also to be conditional on the arguments
6627 * class.cs: Add a little bit of help to help narrow down problems.
6629 * expression.cs (ArrayCreation.CloneTo): Argument can be null, do
6630 not try to copy in that case.
6632 * driver.cs: When building SMCS, include a new different set of
6633 default assemblies here. Do this here so we can control whether
6634 to include the default assemblies with /noconfig.
6636 2007-08-03 Marek Safar <marek.safar@gmail.com>
6638 A fix for bug #81979
6639 * expression.cs (TypeOf.GetAttributableValue): Check for type arguments
6642 2007-08-03 Marek Safar <marek.safar@gmail.com>
6644 A fix for bug #82300
6646 * anonymous.cs (AnonymousContainer.Define): Don't define anything when
6647 we are in probing scope.
6649 2007-08-03 Marek Safar <marek.safar@gmail.com>
6651 A fix for bug #82301
6653 * statement.cs (Catch.CloneTo): Clone blocks in the right order.
6654 (Statement.CloneTo): Clone and not map children blocks.
6656 2007-08-03 Marek Safar <marek.safar@gmail.com>
6658 A fix for bug #82299
6660 * expression.cs (LocalVariableReference.CloneTo): Remap local info
6663 * statement.cs (Statement.CloneTo): Clone variables before statements
6664 to allow remaping of local variables.
6666 2007-08-03 Marek Safar <marek.safar@gmail.com>
6668 A fix for bug #82296
6671 * report.cs: Log crash details for future clone problems.
6673 * statement.cs (Return.Clone): Don't clone non-existent expression.
6675 2007-08-03 Raja R Harinath <harinath@gmail.com>
6677 * class.cs (TypeContainer.AddBasesForPart): Make virtual.
6678 (Class.AddBasesForPart): Move CS0537 check here from ...
6679 * cs-parser.jay (class_declaration): ... here. Move calling of
6680 'AddBasesForPart' to ...
6681 (class_bases): ... here.
6682 (struct_declaration, interface_declaration): Update to changes.
6684 2007-08-02 Marek Safar <marek.safar@gmail.com>
6686 A fix for bug #81923
6688 * statement.cs (Using.ResolveLocalVariableDecls): Only non-user implicit
6689 conversion is allowed.
6691 2007-08-02 Marek Safar <marek.safar@gmail.com>
6693 A fix for bug #81564
6695 * ecore.cs (EventExpr): Add IsBase handling.
6697 * expression.cs (BaseAccess.CommonResolve): Events can use base accessor
6700 2007-08-02 Raja R Harinath <harinath@gmail.com>
6702 Reduce some differences between cs-parser.jay in mcs/ and gmcs/.
6703 * cs-parser.jay: Some whitespace cleanups.
6704 (current_delegate): New.
6706 (struct_declaration): Make similar to gmcs/cs-parser.jay -- add
6707 a dummy code block, and use 'type_name' instead of 'member_name'.
6708 (interface_declaration, class_declaration): Likewise.
6709 (delegate_declaration): Likewise. Rearrange slightly and use
6711 * cs-tokenizer.cs (handle_where): Rename from handle_constraints.
6712 (GetKeyword): Update to change. Use '!foo' instead of 'foo == false'.
6714 2007-08-02 Marek Safar <marek.safar@gmail.com>
6716 A fix for bug #82039
6718 * ecore.cs (TypeLookup.GetSignatureForError): Use name when type is not
6721 * typemanager.cs (CSharpName): Split to string overload.
6723 2007-08-02 Marek Safar <marek.safar@gmail.com>
6726 * report.cs: Updated warning CS0472.
6728 2007-08-01 Marek Safar <marek.safar@gmail.com>
6730 A fix for bug #82181
6732 * cs-tokenizer.cs: Ignore partial keyword inside block expression.
6734 2007-08-01 Marek Safar <marek.safar@gmail.com>
6736 A fix for bug #82277
6737 * statememnt.cs (Block.Clone): Don't clone explicit blocks twice.
6739 2007-08-01 Marek Safar <marek.safar@gmail.com>
6741 ** C# 3.0 Type Inference (major bits are working)
6743 * anonymous.cs (AnonymousMethodExpression): Removed refactored fields.
6744 (.ImplicitStandardConversionExists): Uses compatible.
6745 (.ExplicitTypeInference): Infers type arguments based on explicit arguments
6746 (.InferReturnType): New method.
6747 (.Compatible): Refactored.
6748 (.ResolveParameters): Uses factory to create resolved parameters.
6749 (.CompatibleMethod): Add probing mode support.
6750 (AnonymousContainer): Removed unused fields. Split Define and Resolve to
6751 clearly distinguish between 2 different operations.
6752 (LambdaMethod): Moved to lambda.cs.
6753 (AnonymousMethod): Removed unused fields and methods.
6754 (AnonymousDelegate): Simplified.
6756 * codegen.cs (ResolveTopBlock): Updated renamed Resolve to Define.
6758 * convert. cs (ImplicitConversionStandard): Compatible works differently.
6760 * delegate.cs (Delegate): New mehods to reduce code duplication.
6761 (.GetConstructor): New method.
6762 (.GetInvokeMethod): New method.
6763 (DelegateCreation): Updated.
6765 * ecore.cs (ResolveOverloadExtensions): Don't crash when extension method
6767 (OverloadResolve): Made probing little bit faster.
6769 * expression.cs (ParameterReference.DoResolveLValue): Reference can be null
6772 * generic.cs (TypeInferenceContext): Dummy implementation.
6774 * iterators.cs: Updated after Resolve/Define rename.
6776 * lambda.cs (LambdaExpression)
6777 (.ResolveParameters): Handles both type of arguments and type inference too.
6779 * parameter.cs (ImplicitLambdaParameter.Resolve): Sanity check.
6780 (InflateTypes): Updated.
6782 * support.cs (InflateTypes): Changed signature and updated.
6784 * typemanager.cs (LookupMemberCache): Better dynamic type check.
6785 (MemberLookup_FindMembers): More MS tricks.
6786 (GetParameterData): Ditto.
6787 (GetDelegateParameters): Uses quick path for dynamic types.
6789 2007-08-01 Marek Safar <marek.safar@gmail.com>
6791 * class.cs (MethodData.Define): EmitContext is required for generic stuff
6794 2007-07-31 Marek Safar <marek.safar@gmail.com>
6796 * statement.cs (ProcessParameters): Don't crash when parameters have wrong
6799 2007-07-26 Jb Evain <jbevain@novell.com>
6801 * typemanager.cs (TypeManager.GetConstructor): Add a method overload
6802 which takes a boolean 'report_errors', similar to the GetMethod.
6803 (InitCodeHelpers): StructLayoutAttribute.ctor(int16) is not visible
6804 in .net 2.1, do not report errors here.
6806 * typemanager.cs (TypeManager.InitCoreTypes): System.ArgIterator,
6807 System.Runtime.CompilerServices.RequiredAttributeAttribute and
6808 System.Runtime.CompilerServices.TypeForwardedToAttribute are internal
6811 * typemanager.cs (TypeManager.InitCoreTypes): Move the resolution
6812 of the type InternalsVisibleToAttribute before the first call
6813 to CoreLookupType which is allowed to fail (third boolean parameter
6814 to true). Because, during the resolution for a type that is not
6815 immediately found, we try to check if the type is not defined in
6816 a friend assembly, and to do so, we need the
6817 InternalVisibleToAttribute.
6819 2007-07-23 Miguel de Icaza <miguel@novell.com>
6821 * expression.cs (Binary): Add support for the brain-dead CSC 2.x
6822 feature that allows structs to be compared against null and inline
6823 the result as true or false.
6825 Notice that the same code is not permitted inside a generic block
6826 of code that would do:
6828 class Foo<T> where T : struct {
6835 It is only allowed if the type of T is not bound (no where
6836 clause). In my opinion, this CSC 2 behavior is broken but people
6837 seem to be using it (IronRuby does, a few bug reports on bugzilla
6838 have it and some people have complained about it).
6840 All of the users that depend on this behavior have code that is
6843 * report.cs (Warning, Error): make these take object arguments,
6844 not strings, as that allows us to take advantage of Format.
6846 2007-07-20 William Holmes <billholmes54@gmail.com>
6848 * decl.cs: Changed MemberName.CountTypeArguments to also check the
6849 Left member variable for the Count.
6850 * doc.cs: Changed DocUtil.GetMethodDocCommentName to call
6851 MemberName.CountTypeArguments to avoid a NRE.
6853 This code is contributed under the MIT X11 license
6855 2007-07-18 Marek Safar <marek.safar@gmail.com>
6857 * cs-tokenizer.cs: Improved lambda parsing and removed old code.
6859 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6861 * doc.cs : generic method arguments are written as ``x while generic
6862 type arguments are `x. Combined with the previous change, fixed bug
6865 2007-07-18 Raja R Harinath <rharinath@novell.com>
6868 * expression.cs (Binary.ResolveOperator): When converting
6869 'a + (- b)' to 'a - b', ensure that the unary '-' is discarded.
6871 2007-07-18 Atsushi Enomoto <atsushi@ximian.com>
6873 * doc.cs : when T: or whatever x: is specified, it does not really
6874 check the doc comment's syntax correctness. Fixed bug #82006.
6876 2007-07-18 Marek Safar <marek.safar@gmail.com>
6878 * anonymous.cs (AnonymouseMethodExpression): Refactored to work with
6879 LambdaExpression better.
6881 * cs-tokenizer.cs: Changed a way how we detect lambda parameters.
6883 * driver.cs (LambdaTypeParseTest): Removed, tested method is gone.
6885 * ecore.cs (Expression.MemberLookupFailed): Don't show currect context
6886 as it can be generated.
6888 * expression.cs (Invocation.Error_InvalidArguments): Show correct
6891 * lambda.cs (LambdaExpression): Refactored to share same code with
6892 AnonymousMethodExpression.
6894 2007-07-17 Marek Safar <marek.safar@gmail.com>
6896 * anonymous.cs (MakeName): Include host name for easier debugging.
6897 (LambdaMethod): New class for lambda spcecific stuff.
6899 * attribute.cs: Set EmitContext return type.
6901 * class.cs: Set EmitContext return type.
6903 * codegen.cs (EmitContext): Return type cannot be null to stop messing
6904 with null/void meaning.
6906 * iterators.cs (ContainerType): Implemented.
6908 * rootcontext.cs: Set value of TypeManager.bool_type at early stage.
6910 * statement.cs (Return): Updated to lambda expressions.
6911 (Block.CloneTo): Parent can be null.
6913 2007-07-13 Marek Safar <marek.safar@gmail.com>
6915 A fix for bug #81917
6916 * attribute.cs (AttributeTester.GetFixedBuffer): More robust testing.
6918 * class.cs (FixedField): Check whether field is in unsafe scope.
6920 * ecore.cs (FieldExpr.DoResolve): Create fixed buffer expression here.
6921 (FieldExpr.Emit): Fixed buffers cannot be volatile.
6923 * expression.cs (ElementAccess.Resolve): Move fixed buffers resolve to
6926 * statement.cs (Fixed.Resolve): Simplified fixed buffers.
6928 2007-07-13 Marek Safar <marek.safar@gmail.com>
6930 * cs-tokenizer.cs, class.cs, decl.cs, driver.cs, namespace.cs,
6931 rootcontext.cs, expression.cs, statement.cs: Updated to use WarningLevel
6934 2007-07-13 Marek Safar <marek.safar@gmail.com>
6936 * ecore.cs (FieldExpr.AddressOf): Less confusing warning message.
6938 2007-07-13 Marek Safar <marek.safar@gmail.com>
6940 * anonymous.cs (AnonymousMethodExpression): Parameters are r/o.
6941 (AnonymousContainer.ResolveNoDefine): Another ec to aec flag conversion.
6943 * codegen.cs(EmitContext): Add ProbingMode flag.
6945 * delegate.cs (DelegateInvocation): Set few instance variables as r/o.
6947 * driver.cs: For now set both warning values.
6949 * ecore.cs (SimpleName): Name is readonly.
6950 (MethodGroup.OverloadResolve): One quick path for probing.
6952 * expression.cs (Unary): Set Oper r/o.
6953 (Binary): Set Oper r/o.
6954 (ParameterReference): Set few instance variables as r/o.
6955 (ParameterReference.DoResolveBase): Don't capture aruments when
6957 (Invocation.CloneTo): Fixed typo, looks easy, yeah.
6958 (Arglist): arguments are private.
6959 (SizeOf): type is private and r/o.
6960 (MemberAccess): arguments are private.
6962 * report.cs: Enhanced reporting on/off capabilities.
6964 * lambda.cs: Uses ec.IsInProbingMode.
6965 (ContextualReturn): Derives from return.
6967 * rootcontext.cs: For now set both warning values.
6969 * statement.cs (CloneContext.RemapBlockCopy): Remaps block to cloned
6971 (Return.Resolve): Don't die immediately.
6972 (Block.Resolve): Speed-up probing.
6973 (Block.CloneTo): Clone only child blocks.
6975 Fri Jul 13 11:19:28 CEST 2007 Paolo Molaro <lupus@ximian.com>
6977 * iterators.cs: reverted Miguel's latest change (r81925) as it
6978 breaks the build in System.
6980 2007-07-13 Miguel de Icaza <miguel@novell.com>
6982 * iterators.cs (Yield.CheckContext): Check for the iterator type
6983 also here as we can call into Yield even in codepaths that are not
6985 (MethodOrOperator is the only path that was checked).
6987 In addition to the standard check, use a more specific check for
6988 constructors to report a more verbose error.
6990 2007-07-12 Miguel de Icaza <miguel@novell.com>
6992 * ecore.cs (FieldExpr.AddressOf): Do not stop processing here,
6993 report the warning and continue
6995 * statement.cs (Using.EmitLocalVariableDecls): We were leaving
6996 values on the stack on the call to Emit. Use EmitStatement if
6997 possible, or using Emit + Pop if not possible. Fixes #82064
6999 2007-07-12 Raja R Harinath <rharinath@novell.com>
7001 * expression.cs (Invocation.IsApplicable): Reorganize slightly to
7002 avoid try...finally in some cases.
7004 2007-07-10 Marek Safar <marek.safar@gmail.com>
7006 * attribute.cs (Attribute.ResolveConstructor): Uses method group.
7008 * class.cs (ConstructorInitializer.Resolve): Use and keep method group
7009 instead of method. Re-use standard error handling.
7010 (ConstructorInitializer.Emit): Simplified.
7012 * delegate.cs: Updated after Invocation.EmitCall change.
7014 * ecore.cs (GetOperatorTrueOrFalse): Uses MethodGroupExpr only.
7015 (SimpleName.SimpleNameResolve): Set and reset in_transit flag correctly.
7016 (ExtensionMethodGroupExpr): Refactored to use same OverloadResolve
7017 method and don't permanently changing input arguments.
7018 (MethodGroupExpr): Introduced resolved best_candidate, when method group
7019 is resolved it has one of the candidates is the best one which is later
7020 used to emit. Removed a few unused method.
7021 (MethodGroupExpr.MakeUnionSet): Moved from Invocation, it belongs here.
7023 * expression.cs (StaticCallExpr.MakeSimpleCall): Uses method group.
7024 (Binary.ResolveOperator): Ditto.
7025 (ConditionalLogicalOperator.DoResolve): Ditto.
7026 (Invocation): Uses method group.
7027 (Invocation.DoResolve): Simplified.
7028 (Invocation.EmitCall): Removed useless is_static.
7029 (Invocation.Emit): Delegate to method group.
7030 (Invocation.EmitStatement): Simplified.
7031 (New): Uses method group.
7032 (MemberAccess.DoResolve): Don't destroy original expression.
7034 * statement.cs (ForEach.Resolve): Use null for no method arguments.
7036 2007-07-04 Marek Safar <marek.safar@gmail.com>
7038 * ecore.cs (VarExpr.DoResolveLValue): More restriction checks.
7041 * lambda.cs: Add custom error message type.
7043 2007-07-03 Marek Safar <marek.safar@gmail.com>
7045 * lambda.cs: Simplified little bit.
7047 * parameter.cs: Introduced ImplicitLambdaParameter.
7048 (Parameters.CreateFullyResolved): New factory instead of ctor.
7052 * delegate.cs: Updated parameter creation.
7054 2007-07-03 Marek Safar <marek.safar@gmail.com>
7056 * ecore.cs (SimpleName.GetSignatureForError): Display correctly generic
7059 * generic.cs: Synchronized with gmcs.
7061 2007-07-03 Marek Safar <marek.safar@gmail.com>
7063 * class.cs (Indexer): Check return type as soon as possible.
7065 * cs-parser.jay: Initialize implicit_value_parameter_type for interface
7068 * ecore.cs (VarExpr.DoResolveLValue): Set eclass value.
7070 * expression.cs (Invocation.Error_InvalidArguments): Show type only.
7072 * parameter.cs (Parameter): Use expression type when it is available.
7074 * support.cs (ReflectionParameters.ParameterDesc): Show an extension
7075 method modifier for the first parameter only.
7077 2007-06-24 Marek Safar <marek.safar@gmail.com>
7079 A fix for bug #81938
7080 * typemanager.cs (ChangeType): Fixed couple of char conversions.
7082 * constant.cs: Tide up an exception message.
7084 2007-06-22 Marek Safar <marek.safar@gmail.com>
7086 * ecore.cs (SimpleName.DoSimpleNameResolve): Better error reporting when
7087 an uninitialized variable is used.
7089 * expression.cs (LocalVariableReference.DoResolve): Ditto.
7091 2007-06-22 Marek Safar <marek.safar@gmail.com>
7093 * ecore.cs (SimpleName.TypeOrNamespaceNotFound): Allow to override type
7094 not found error handling.
7096 * expression.cs (ArrayCreation): Removed redundant fields and little bit
7098 (ArrayCreation.ResolveArrayElement): To be ready to customization.
7099 (ArrayCreation.DoResolve): Simplified.
7100 (ImplicitlyTypedArrayCreation.DoResolve): Implicitly typed arrays have
7101 its own resolve process.
7102 (ImplicitlyTypedArrayCreation.ResolveArrayElement): Conversion magic.
7104 2007-06-20 Marek Safar <marek.safar@gmail.com>
7106 * namespace.cs (NamespaceEntry.Error_AmbiguousTypeReference): Print
7109 2007-06-20 Marek Safar <marek.safar@gmail.com>
7111 * cs-tokenizer.cs: Removed var related stuff.
7113 * ecore.cs (Expression.ResolveAsContextualType): Introduced new method.
7114 (VarExpr): Changed to derive from SimpleName. VarExpr now behaves as
7115 a type and a keyword at same time.
7117 * decl.cs (MembeName.GetTypeExpression): Create VarExpr when type name
7120 * expression.cs (ImplicitlyTypedArrayCreation): New empty class for
7121 implicitly typed arrays, more changes will follow.
7123 * statement.cs (LocalInfo.Resolve): Resolve type as contextual type.
7125 2007-06-19 Marek Safar <marek.safar@gmail.com>
7127 * ecore.cs (VarExpr): Removed Handled field.
7129 * statement.cs (Using.ResolveLocalVariableDecls): Refactored to use
7130 build-in assign functionality.
7131 (ForEach.Resolve): Removed all implicitly typed local variable code and
7133 (ArrayForeach.Resolve): Infer implicitly typed local variable here.
7134 (CollectionForeach.Resolve): Infer implicitly typed local variable here.
7136 2007-06-18 Marek Safar <marek.safar@gmail.com>
7138 * assign.cs: Removed implicitly typed local variable check.
7140 * expression.cs (LocalVariableReference.DoResolve): Add check for self
7141 referencing implicitly typed local variable.
7142 (LocalVariableReference.DoResolveLValue): Infer implicitly typed local
7145 * statement.cs (Fixed): Removed unsupported implicitly typed local
7148 2007-06-15 Marek Safar <marek.safar@gmail.com>
7150 * decl.cs (MemberName): Moved all Unbound stuff to parser.
7152 2007-06-14 Marek Safar <marek.safar@gmail.com>
7154 A fix for bugs #81855 and #76274
7155 * attribute.cs (AttachTo): Always set owner for global attributes to
7158 * ecore.cs (Error_TypeDoesNotContainDefinition): A type location can be
7161 * cs-parser.jay: Assembly and module attributes must precede all other
7162 elements except using clauses and extern alias declarations.
7164 2007-06-13 Marek Safar <marek.safar@gmail.com>
7166 A fix for bug #81748
7168 * expression.cs: More checks for non ISO-1 features.
7170 2007-06-12 Marek Safar <marek.safar@gmail.com>
7172 A fix for bug #81807
7173 * statement.cs(Switch.TableSwitchEmit): Define null label when it's not
7174 present inside switch statement and it is required by nullable check.
7176 2007-06-12 Marek Safar <marek.safar@gmail.com>
7178 A fix for bug #81840
7179 * ecore.cs (SimpleName.ResolveAsTypeStep): Look for non-generic type
7180 when type matching fails.
7182 * namespace.cs: Tiny error message change.
7184 2007-06-12 Marek Safar <marek.safar@gmail.com>
7186 * decl.cs (CheckAbstractAndExtern): Moved to MemberCore for easier error
7187 reporting. Added automatic property check.
7189 * class.cs: Updated after CheckAbstractAndExtern relocation.
7190 (AEventPropertyAccessor.GetSignatureForError): Customized.
7192 2007-06-11 Marek Safar <marek.safar@gmail.com>
7194 * class.cs (DefineBaseTypes): Base type can be undefined.
7196 * ecore.cs (TypeLookup): Minor refactoring.
7197 (DoResolveAsTypeStep): Removed redundant check.
7199 * namespace.cs (Lookup): Removed redundant check.
7201 * rootcontext.cs (BootstrapCorlib_ResolveType): Uses normal
7202 ResolveAsTypeTerminal step.
7203 (BootstrapCorlib_*): Simplified.
7204 (PopulateCoreType): Core types can be now external.
7206 2007-06-07 Marek Safar <marek.safar@gmail.com>
7208 * anonymous.cs (VerifyExplicitParameterCompatibility): Add flag to do
7210 (InferTypeArguments): Infers anonymous expression type arguments.
7211 (Compatible): Split to Compatible and InferTypeArguments.
7213 * lambda.cs: Updated.
7215 2007-06-08 Marek Safar <marek.safar@gmail.com>
7217 * anonymous.cs (AnonymousContainer): Marked as compiler generated.
7219 2007-06-07 Raja R Harinath <harinath@gmail.com>
7221 Fix #80477, cs0135-2.cs, cs0135-3.cs
7222 * statement.cs (ToplevelBlock.ProcessParameters): Add parameter
7223 names to the "known" variables list.
7224 (Block.CheckInvariantMeaningInBlock): Handle the fact the
7225 parameter names are also "known".
7226 (Block.CheckError136): Remove.
7227 (ExplicitBlock.CloneTo): New. Set 'known_variables' in target to
7230 2007-06-07 Marek Safar <marek.safar@gmail.com>
7232 * ecore.cs (MethodGroupExpr.OverloadResolve): Print full method definition.
7234 2007-06-06 Marek Safar <marek.safar@gmail.com>
7236 * ecore.cs (SimpleName.Emit): Emitting unresolved simple name is
7237 internal error not an user error.
7239 * expression.cs (IsApplicable): Refactored to make debugging easier.
7241 * support.cs: More tricks for non-mono runtimes.
7243 * typemanager.cs (CoreLookupType): Made public.
7244 (InitSystemCore): All linq specific stuff moved to linq.cs
7246 2007-06-05 Marek Safar <marek.safar@gmail.com>
7248 * typemanager.cs (CSharpSignature): One more missing build-in types
7250 More tricks for non-mono runtime.
7252 2007-06-05 Raja R Harinath <harinath@gmail.com>
7254 * statement.cs (Block.CheckError136_InParents): Remove.
7255 (Block.AddVariable): Use GetParameterInfo instead.
7256 (ToplevelBlock.ProcessArguments): Likewise.
7258 2007-06-04 Raja R Harinath <rharinath@novell.com>
7260 * statement.cs (ToplevelBlock.CloneTo): New. Copy over parameter
7262 (ToplevelBlock.GetParameterInfo): Split out of ...
7263 (ToplevelBlock.GetParameterRefernce): ... this.
7264 (ToplevelBlock.ParameterMap): Remove.
7265 * expression.cs (ParameterReference): Update to use
7266 ToplevelParameterInfo.
7268 * statement.cs (ToplevelBlock.ProcessParameters): Workaround some
7271 * flowanalysis.cs (FlowBranching.CheckOutParameters): Move ...
7272 * statement.cs (ToplevelBlock.CheckOutParameters): ... here.
7274 * statement.cs (ToplevelBlock.ResolveMeta): Move CS0136 checks ...
7275 (ToplevelBlock.ProcessParameters) ... here.
7276 (ToplevelBlock..ctor): Invoke it.
7278 * statement.cs (ToplevelBlock.ResolveMeta): Add sanity checks for
7281 * statement.cs (IKnownVariable): New interface.
7282 (LocalInfo): Implement it.
7283 (ToplevelParameterInfo): New class.
7284 (ExplicitBlock.AddKnownVariable): Use IKnownVariable.
7285 (ExplicitBlock.GetKnownVariable): Likewise. Rename from
7286 GetKnownVariableInfo.
7288 2007-06-03 Raja R Harinath <harinath@gmail.com>
7290 Partly speed up CS0136 error checks.
7291 * statement.cs (ExplicitBlock.GetKnownVariableInfo): Remove
7292 'recurse' parameter.
7293 (Block.DoCheckError136): Only check errors in parameters. Move
7294 local variable checks ...
7295 (Block.AddVariable): ... here, and ...
7296 (ToplevelBlock.ResolveMeta): ... here.
7298 2007-06-02 Raja R Harinath <harinath@gmail.com>
7300 * statement.cs (Block.IsChildOf): Remove.
7302 * statement.cs (Statement.Clone): Move special case code ...
7303 (Block.CloneTo): ... here.
7305 2007-05-29 Raja R Harinath <rharinath@novell.com>
7307 * statement.cs (ToplevelBlock.container): Remove field. It's
7308 redundant with 'Parent'.
7309 (ToplevelBlock.ContainerBlock): Remove accessor.
7310 (ToplevelBlock..ctor): Update to changes. Register anonymous
7311 child with parent here, ...
7312 * cs-parser.jay (end_anonymous): ... not here. Don't modify
7314 (start_anonymous): Don't save current_block.
7315 (top_current_block): Remove.
7317 * statement.cs (Block.Flags): Remove IsExplicit and IsToplevel flags.
7318 (Block.Resolve): Update to changes.
7319 (Block..ctor): Move setting of "correct" 'Toplevel'
7320 and 'Explicit' fields to ...
7321 (ExplicitBlock..ctor, ToplevelBlock..ctor): ... here.
7323 2007-05-27 Raja R Harinath <harinath@gmail.com>
7326 * statement.cs (Block.Implicit): Remove.
7327 (Block): Update to changes.
7328 * flowanalysis.cs: Likewise.
7330 Mildly speed up CheckInvariantMeaningInBlock
7331 * statement.cs (ExplicitBlock.AddKnownVariable): Move here from Block.
7332 Recursively call AddKnownVariable to all enclosing blocks.
7333 (ExplicitBlock.GetKnownVariableInfo): Move here from Block.
7334 Remove recursive calls.
7335 (Block): Update to changes.
7337 New ExplicitBlock invariants
7338 * statement.cs (Block.Explicit): New field. It points to the
7339 immediately enclosing non-implicit block.
7340 (Block..ctor): Maintain the invariant.
7341 * cs-parser.jay: Take advantage of invariant.
7343 Introduce ExplicitBlock
7344 * statement.cs (ExplicitBlock): New.
7345 (ToplevelBlock): Derive from it.
7346 (Block.Flags.IsExplicit): Rename from '...Implicit' and invert
7348 (Block.Implicit): Update to changes.
7349 * cs-parser.jay: Update to changes.
7352 * codegen.cs (EmitContext.IsLastStatement): Remove.
7353 * statement.cs (Block.DoEmit): Update to changes.
7355 2007-05-25 Raja R Harinath <rharinath@novell.com>
7357 * cs-parser.jay: Use 'start_block' and 'end_block' rather than
7358 modifying current_block directly.
7360 2007-05-23 Scott Peterson <lunchtimemama@gmail.com>
7362 * class.cs: Implemented automatic properties (C# 3.0)
7363 Thanks to Marek for the help.
7365 2007-05-23 Raja R Harinath <rharinath@novell.com>
7367 * flowanalysis.cs (VariableInfo.SetAssigned): When noting a
7368 variable as assigned, note also that all its components are
7370 (MyBitVector.SetRange): New. Function to set multiple bits to true.
7372 2007-05-19 Marek Safar <marek.safar@gmail.com>
7374 * anonymous.cs, class.cs: Emit Compiler generated attribute when
7375 member is marked as compiler generated.
7377 * decl.cs (MemberCore): Refactored ModFlags into property.
7379 * modifiers.cs: Add new modifier (COMPILER_GENERATED).
7380 (Check): Check only accessibility modifiers.
7382 2007-05-18 Raja R Harinath <rharinath@novell.com>
7384 Track all assignable slots in one bit array
7385 * statement.cs (ToplevelBlock.ParameterMap): Convert into array.
7386 (ToplevelBlock.ResolveMeta): Don't create a VariableMap. Move
7387 logic from VariableMap constructor here. Use the same 'offset'
7388 variable that's later used for computing offsets of local
7390 * flowanalysis.cs (UsageVector.parameters): Remove.
7391 (UsageVector): Update to changes.
7392 (VariableMap): Remove.
7394 Avoid creating ParameterMap in every block
7395 * statement.cs (Block.ParameterMap): Move ...
7396 (ToplevelBlock.ParameterMap): ... here.
7397 (ToplevelBlock.ResolveMeta): Create VariableMap for parameters
7399 * flowanalysis.cs (FlowBranching.param_map): Remove.
7400 (FlowBranching.UsageVector): Update to changes.
7401 (FlowBranchingToplevel.CheckOutParameters): Likewise.
7403 * statement.cs (Block.CloneTo): Clone Toplevel field too.
7405 * expression.cs (ParameterReference): Distinguish between block
7406 where parameter was referenced and declared.
7408 2007-05-18 Marek Safar <marek.safar@gmail.com>
7410 * flowanalysis.cs, statement.cs: Put back improved error handling.
7412 2007-05-15 Scott Peterson <lunchtimemama@gmail.com>
7416 Imporved object and collection initialization (C# 3.0).
7418 2007-05-15 Marek Safar <marek.safar@gmail.com>
7420 A fix for bug #81380
7421 * expression.cs (Is.DoResolve): Only value types have constant `is'
7424 2007-05-15 Raja R Harinath <rharinath@novell.com>
7426 * statement.cs (ToplevelBlock.child): Remove.
7428 2007-05-15 Raja R Harinath <harinath@gmail.com>
7430 Rationalize ResolveMeta: refactoring
7431 (Block.ResolveMeta): Remove wrong or superfluous comments. Carve
7432 out constant handling code into ...
7433 (Block.DoResolveConstants): ... this.
7435 Rationalize ResolveMeta: kill local_map
7436 * statement.cs (Block.local_map, Block.LocalMap): Remove.
7437 (Block.AssignableSlots): New.
7438 (Block.ResolveMeta): Make protected. Don't create a VariableMap
7439 for locals -- move code from VariableMap here. Avoid unnecessary
7441 * flowanalysis.cs (FlowBranching.local_map): Remove.
7442 (FlowBranching..ctor): Use Block.AssignableSlots.
7443 (VariableMap): Remove unused constructors.
7445 2007-05-11 Raja R Harinath <rharinath@novell.com>
7447 * Makefile [PROFILE=net_2_0_bootstrap]: Add special-case rules.
7449 2007-05-11 Marek Safar <marek.safar@gmail.com>
7451 * typemanager.cs (IsFriendAssembly): Should not be called for building
7454 2007-05-09 Marek Safar <marek.safar@gmail.com>
7456 * literal.cs (NullConstant): Print null in all cases.
7458 * expression.cs (Binary.ResolveOperator): Implemented delegate
7459 comparison based on C# 2.0 changes.
7461 2007-04-28 Scott Peterson <lunchtimemama@gmail.com>
7463 This code is contributed under the MIT X11 license
7465 The following enables support for several C# 3.0 language features:
7467 * cs-tokenizer.cs: Added support for the "var" keyword.
7469 * ecore.cs: Refactored TypeLookupExpression.DoResolveAsTypeStep().
7470 Added VarExpr class to facilitate type inferencing.
7472 * class.cs: Added IDictionary field AnonymousTypes to TypeContainer
7473 to support anonymous types.
7475 * assign.cs: Added support for type inferencing and initialization.
7477 * anonymous.cs: Added AnonymousClass class to enable anonymous types.
7479 * expression.cs: Added implicit array support to ArrayCreation.
7480 Added 5 types and 1 interface:
7482 IInitializable Implementing classes can inject initializing
7483 statements after object instantiation.
7485 Initializer Stores data for object initialization.
7487 AnonymousType An expression for anonymous types.
7489 AnonymousTypeParameter Stores data about an anonymous type's field.
7491 NewInitialize An expression for object initialization.
7493 CollectionInitialize An expression for collection initialization.
7495 * statement.cs: Added "var" keyword support to the foreach, using, and fixed
7498 2007-05-06 Marek Safar <marek.safar@gmail.com>
7500 A fix for bug #81500
7501 * cs-tokenizer.cs: Add special handling for coalescing operator.
7503 2007-05-06 Marek Safar <marek.safar@gmail.com>
7505 A fix for bug #81529
7506 * attribute.cs (GetAttributeUsage): AttributeUsage attribute inherits
7507 its value from base class until it is redefined.
7509 2007-05-02 Raja R Harinath <rharinath@novell.com>
7511 Fix regression in cs0631-3.cs
7512 * cs-parser.jay (operator_declarator): Add opt_attributes to error
7513 fallback. Make error fallback catch more cases.
7515 2007-05-01 Miguel de Icaza <miguel@novell.com>
7517 * cs-parser.jay: Allow parameters in operator declarations to have
7520 2007-04-27 Miguel de Icaza <miguel@novell.com>
7522 * statement.cs (If.CloneTo): Only clone the FalseStatement if it
7525 * lambda.cs (ContextualReturn.Resolve): An expression is valid
7526 inside the ContextualReturn, it does not have to be an
7527 ExpressionStatement.
7529 2007-04-24 Miguel de Icaza <miguel@novell.com>
7531 * lambda.cs (ContextualReturn.Resolve): if the return type is not
7534 2007-04-23 Miguel de Icaza <miguel@novell.com>
7536 * anonymous.cs (AnonymousContainer): split the virtual Resolve
7537 method in two methods: ResolveNoDefine and Resolve.
7539 ResolveNoDefine will stop just after ResolveTopBlock has been
7542 Resolve will then continue by creating a method and issuing the
7543 call to method.Define ().
7545 (AnonymousMethod): Split and implement the new Resolve and
7546 ResolveNoDefine as well.
7548 * lambda.cs (LambdaExpression): Split the anonymous method
7549 resolution code into a separate routine (CoreCompatibilityTest)
7550 from DoCompatibleTest.
7552 (LambdaExpression.TryBuild): New method, this method tries to
7553 build the LambdaExpression with the given set of types to be used
7554 as the types for the various parameters of the lambda expression.
7556 If the compilation succeed with the given types, the infered type
7557 of the Anonymous method is returned, otherwise null is returned.
7559 2007-04-23 Marek Safar <marek.safar@gmail.com>
7561 A fix for bug #81414
7562 * delegate.cs: Better fix, moved ApplyAttributes from Define to Emit.
7564 2007-04-22 Miguel de Icaza <miguel@novell.com>
7566 * cs-tokenizer.cs: Change various identifiers here from the
7567 camelCasing to the recommended Linux-like style for instance
7568 variables from the Coding Guidelines.
7570 2007-04-19 Martin Baulig <martin@ximian.com>
7573 (Convert.ImplicitReferenceConversionCore): Allow conversions from
7574 System.Enum to System.ValueType.
7576 2007-04-13 Martin Baulig <martin@ximian.com>
7578 Rewrote implicit reference conversions. We need to distinguish
7579 between implicit reference conversions (13.1.4) and implicit
7580 boxing conversions (13.1.5).
7582 According to the spec, there's an an implicit conversion
7583 "From a one-dimensional array-type S[] to IList<T> and base
7584 interfaces of this interface, provided there is an implicit
7585 reference conversion from S to T." Note that this does not
7586 include boxing conversions.
7589 (Convert.ImplicitTypeParameterBoxingConversion): New method.
7590 (Convert.ImplicitReferenceConversion): Split into
7591 ImplicitReferenceConversionCore() and
7592 ImplicitBoxingConversionExist().
7593 (Convert.ImplicitReferenceConversionExists): Use the new
7594 ImplicitReferenceConversionCore() and ImplicitBoxingConversionExists().
7596 2007-04-12 Martin Baulig <martin@ximian.com>
7598 * convert.cs (Convert.ImplicitReferenceConversion): Move the
7599 `TypeManager.null_type' checks up to the top of the method.
7601 2007-04-11 Marek Safar <marek.safar@gmail.com>
7603 A fix for bug #81350
7604 * class.cs, decl.cs, ecore.cs, namespace.cs: The optimization for private
7607 2007-04-11 Martin Baulig <martin@ximian.com>
7609 * statement.cs (Foreach.CollectionForeach.ProbeCollectionType):
7610 Use `TypeManager.GetInterfaces(t)' rather than `t.GetInterfaces()'
7611 to make this work for generic classes; fixes #79561.
7613 2007-04-11 Martin Baulig <martin@ximian.com>
7615 * expression.cs (As): Add support for nullable types; fixes #79371.
7617 2007-04-11 Martin Baulig <martin@ximian.com>
7619 * doc.cs (DocUtil.GetSignatureForDoc): Don't crash if
7620 `type.FullName' is null; fixes #80243.
7622 2007-04-11 Martin Baulig <martin@ximian.com>
7624 * expression.cs (Invocation.IsApplicable): Don't modify the method
7625 if type inference succeeded, but the method was not applicable.
7628 2007-04-10 Marek Safar <marek.safar@gmail.com>
7630 A fix for bug #81324
7631 * namespace.cs (Namespace.LookupExtensionMethod): Always inspect both
7632 internal and external namespaces containers.
7634 2007-04-10 Martin Baulig <martin@ximian.com>
7636 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Use
7637 TypeManager.DropGenericMethodArguments() so we also call
7638 IMethodData.SetMemberIsUsed() for generic methods. Fixes #80357.
7640 2007-04-10 Martin Baulig <martin@ximian.com>
7642 * iterators.cs (Iterator.CreateIterator): Don't crash if
7643 `method.ReturnType' is null. This happens if something went wrong
7644 while resolving that typ (we already reported an error in this case).
7646 2007-04-10 Martin Baulig <martin@ximian.com>
7648 * expression.cs (New.DoResolve): Don't call CheckComImport() on
7649 generic interfaces; report the CS0144 directly.
7651 2007-04-10 Martin Baulig <martin@ximian.com>
7653 * ecore.cs (MemberExpr.ResolveMemberExpr): If `left' is a
7654 `TypeExpr', call ResolveAsTypeTerminal() on it; fixes #81180.
7656 2007-04-10 Martin Baulig <martin@ximian.com>
7658 * expression.cs (New.DoEmitTypeParameter): Fix #81109.
7660 2007-04-09 Raja R Harinath <rharinath@novell.com>
7663 * flowanalysis.cs (UsageVector.MergeChild): Handle child.Block == null.
7664 * statement.cs: Use KillFlowBranching only in ResolveUnreachable.
7667 * statement.cs (For.Resolve): If resolution fails, use
7670 2007-04-08 Marek Safar <marek.safar@gmail.com>
7672 * anonymous.cs (MakeName): Make faster and zero-based.
7673 (VerifyExplicitParameterCompatibility): Back to mode where generic
7674 parameter is ignored.
7675 (AnonymousMethodMethod.Emit): Decorate method as compiler generated.
7677 * class.cs (EmitType): Method can emit another new method.
7679 * cs-tokenizer.cs (IsLinqEnabled): Fixes static cctor race.
7681 * driver.cs: Updated.
7683 * lambda.cs: Reuse predefined empty parameters.
7685 * parameter.cs: Updated
7687 * support.cs: Implemented InflateTypes.
7689 * typemanager.cs (GetFullName): Don't use FullName as it can be null.
7690 (InitSystemCore): Introduced to isolate 3.0 dependencies.
7692 2007-04-03 Martin Baulig <martin@ximian.com>
7696 * statement.cs (Foreach.CollectionForeach.TryType): Use a custom
7697 version of TypeManager.IsOverride() which also works with generic
7700 2007-04-03 Martin Baulig <martin@ximian.com>
7705 (Convert.ExplicitReferenceConversion): We need to cast when
7706 converting from IList<T> to S[].
7708 2007-04-01 Marek Safar <marek.safar@gmail.com>
7710 * decl.cs (FindExtensionMethods): Consider all candidates with same name
7713 * expression.cs (MemberAccess.DoResolve): Cache resolved expression.
7715 2007-03-31 Marek Safar <marek.safar@gmail.com>
7717 * anonymous.cs (AnonymousMethodExpression.Compatible): Handles both
7718 argument and return type inferring.
7720 * codegen.cs (InferReturnType): Flag whether return can be inferred.
7721 (ReturnType): Turned to property.
7723 * statement.cs (Return): Implemented return type inferring.
7725 * support.cs (ReflectionParameters): Use local types if possible.
7727 2007-03-30 Raja R Harinath <rharinath@novell.com>
7729 * flowanalysis.cs (FlowBranching.Reachability): Remove.
7730 (FlowBranching.UsageVector): Update to changes.
7732 Prepare to kill 'Reachability'
7733 * flowanalysis.cs (UsageVector): Remove 'Reachability' from
7734 argument of constructor.
7736 2007-03-29 Raja R Harinath <rharinath@novell.com>
7738 Prepare to kill 'Reachability'
7739 * flowanalysis.cs (UsageVector.is_unreachable): New.
7740 (UsageVector): Update to maintain 'is_unreachable' in parallel to
7741 'reachability', and verify they're consistent.
7744 * expression.cs (New.EmitStatement): Handle type parameters here too.
7746 2007-03-29 Martin Baulig <martin@ximian.com>
7751 (ScopeInfo.ctor): Use `Modifiers.PUBLIC' if we're a nested
7752 CompilerGeneratedClass.
7753 (ScopeInfo.EmitScopeInstance): Make this protected.
7754 (CapturedVariable.EmitInstance): Use `Ldarg_0' if
7755 `ec.CurrentAnonymousMethod.Scope == Scope'.
7757 * statement.cs (Block.ScopeInfo): Make this a property.
7759 2007-03-27 Raja R Harinath <harinath@gmail.com>
7761 Prepare to kill 'Reachability'
7762 * flowanalysis.cs (FlowBranching.Reachability): Make class private.
7763 (FlowBranching.UsageVector.Reachability): Remove property.
7764 (FlowBranching.UsageVector.IsUnreachable): New property.
7765 (FlowBranching.UsageVector.ResetBarrier): New.
7766 (FlowBranching.UsageVector, FlowBranchingLabeled): Update to changes.
7767 * codegen.cs, statement.cs: Update to changes.
7769 2007-03-27 Martin Baulig <martin@ximian.com>
7774 (DeclSpace.LookupNestedTypeInHierarchy): Correctly handle nested
7777 2007-03-26 Raja R Harinath <rharinath@novell.com>
7779 * flowanalysis.cs (FlowBranching.Reachability): Use a boolean
7780 instead of TriState. Remove all mention of TriState.
7782 * flowanalysis.cs (FlowBranching.Reachability): Prepare to be
7783 replaced by a boolean. Add boolean 'is_unreachable' field, check
7784 and maintain invariants.
7786 2007-03-25 Marek Safar <marek.safar@gmail.com>
7788 * anonymous.cs: Restored checks disabled for uninflated anonymous methods.
7790 2007-03-25 Marek Safar <marek.safar@gmail.com>
7792 * expression.cs: Stop using obsolete 2.0 opcodes.
7794 2007-03-25 Marek Safar <marek.safar@gmail.com>
7796 * enum.cs (EnumMember.Define): Fixed regression and slowdown caused by
7797 one of the latests Martin's fixes.
7799 2007-03-23 Miguel de Icaza <miguel@novell.com>
7801 * expression.cs: On BigEndian systems, swap the bytes, temporary
7802 solution until we get a new bitconverter class.
7804 2007-03-23 Martin Baulig <martin@ximian.com>
7808 * decl.cs (MemberCache.AddMembers): Add generic methods both as
7809 "Method" and "Method`1". Normally, a cache lookup is done on the
7810 "Method" form (ie. without the generic arity), but this one makes
7811 lookups on the full form work as well.
7813 2007-03-22 Raja R Harinath <rharinath@novell.com>
7815 * flowanalysis.cs (Reachability): Reorganize slightly, and remove
7818 2007-03-20 Bill Holmes <billholmes54@gmail.com>
7820 Added 2 MemberCoreArrayList objects, ordered_explicit_member_list and
7821 ordered_member_list, to TypeBuilder to store members to be defined
7822 in the order they were parsed in.
7823 - ordered_explicit_member_list contains all properties indexers
7824 and methods that are defined as explicit implementation of an
7825 interface or base class.
7826 - ordered_member_list contains all properties indexers and methods
7827 that are not defined as explicit implementation of an interface
7830 Removed MethodArrayList and IndexerArrayList from TypeBuilder. The
7831 functionality in these removed classes has been replaced with
7832 ComputeIndexerName, EmitIndexerName, HasEqualss, HasGetHashCode, and
7833 CheckEqualsAndGetHashCode members defined and called in the TypeBuilderClass.
7835 Adding CheckForDuplications to PropertyBase.PropertyMethod and calls
7836 to CheckForDuplications inside GetMethod and SetMethod Define Method
7837 to handle method property and indexer name conflicts.
7841 All code is contributed under the MIT/X11 license.
7843 2007-03-20 Martin Baulig <martin@ximian.com>
7845 * class.cs (TypeContainer.Interfaces): Removed; they're now
7846 included in `TypeContainer.Types'.
7848 2007-03-20 Martin Baulig <martin@ximian.com>
7850 Fix #77963, #80314 and #81019. Added gtest-317, ..., gtest-320.
7852 * class.cs (TypeContainer.CreateType): New public method. This is
7853 now called before DefineType() to create the TypeBuilders.
7854 (TypeContainer.DefineType): Don't create the TypeBuilder here; it
7855 has already been created by CreateType().
7856 (TypeContainer.DefineTypeBuilder): Renamed into CreateTypeBuilder();
7857 don't resolve our base classes here; this has been moved into
7858 DefineBaseTypes(). We're now called from CreateType().
7859 (TypeContainer.DefineBaseTypes): New private method; resolve our
7860 base classes here. We're now called from DefineType().
7863 (RootContext.ResolveTree): Call TypeContainer.CreateType() on all
7864 our types first to create all the TypeBuilders. After that, call
7865 TypeContainer.DefineType() on all the types which'll resolve their
7866 base classes and setup the resolve order.
7868 2007-03-20 Martin Baulig <martin@ximian.com>
7870 * class.cs (TypeContainer.Enums): Removed; they're now included in
7871 `TypeContainer.Types'.
7873 2007-03-20 Martin Baulig <martin@ximian.com>
7876 (TypeContainer.DefineType): Don't call ResolveMembers() here.
7877 (TypeContainer.DoResolveMembers): Call DefineType() on our
7878 `compiler_generated' classes; moved here from DefineNestedTypes().
7881 (RootContext.ResolveTree): Call ResolveMembers() on all
7882 TypeContainer's in the `type_container_resolve_order'.
7884 2007-03-19 Marek Safar <marek.safar@gmail.com>
7886 * class.cs: Use corlib to handle InternalMethodImplAttribute.
7888 2007-03-17 Marek Safar <marek.safar@gmail.com>
7890 * class.cs (EventFieldAccessor.EmitMethod): Don't override existing
7891 implementation flags.
7893 2007-03-17 Marek Safar <marek.safar@gmail.com>
7895 * class.cs: More optimizations for type parameters.
7897 2007-03-15 Marek Safar <marek.safar@gmail.com>
7899 * anonymous.cs (AnomymousMethod): Can be now hosted in generic container.
7901 * ecore.cs, parameter.cs: More common code for both corlibs.
7903 * typemanager.cs (IsGenericMethod): Simplified.
7905 2007-03-15 Raja R Harinath <rharinath@novell.com>
7907 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7909 * statement.cs, iterators.cs, lambda.cs: Update to changes.
7911 * statement.cs (Lock.Resolve): Invoke 'ec.NeedReturnLabel'
7912 unconditionally. Simplify explanation.
7913 (Try.Resolve, Using.Resolve): Likewise.
7915 2007-03-15 Martin Baulig <martin@ximian.com>
7919 * decl.cs (DeclSpace): If we're a partial class, use our
7920 `PartialContainer's `TypeParameters' and `CurrentTypeParameters'.
7922 2007-03-15 Raja R Harinath <rharinath@novell.com>
7924 * flowanalysis.cs (FlowBranching.Reachability): Remove handling of
7926 (FlowBranching.UsageVector): Update to changes.
7927 (FlowBranching.MergeSiblings): Likewise.
7928 * statement.cs: Likewise.
7930 2007-03-15 Martin Baulig <martin@ximian.com>
7935 (MemberCache): Added a special .ctor for type parameters.
7938 (TypeManager.MemberLookup_FindMembers): `TypeParameter' now has a
7941 2007-03-09 Martin Baulig <martin@ximian.com>
7943 * enum.cs (Enum): Make this a TypeContainer.
7944 (EnumMember): Derive from `Const'.
7947 (Const.DoResolveValue): New protected virtual method; move most of
7948 the functionality of ResolveValue() here so we can override it in
7950 (Const.CreateConstantReference): Make this virtual.
7952 * class.cs (Kind): Add `Kind.Enum'.
7953 (TypeContainer.Emit): Don't emit the enums here; they're already
7954 in the `RootContext.typecontainer_resolve_order'.
7956 * rootcontext.cs (RootContext.EmitCode): Don't emit the enums
7957 here; they're already in the `typecontainer_resolve_order'.
7959 * ecore.cs (EnumConstant.ConvertImplicitly): Add
7960 TypeManager.DropGenericTypeArguments().
7963 (TypeManager.CSharpEnumValue): Add DropGenericTypeArguments().
7964 (TypeManager.IsEnumType): Likewise.
7965 (TypeManager.EnumToUnderlying): Likewise.
7966 (TypeManager.IsEqual): Add support for enums.
7968 2007-03-12 Raja R Harinath <rharinath@novell.com>
7970 * typemanager.cs (InitCoreTypes) [NET_2_0]: Allow
7971 DefaultParameterValueAttribute to be undefined, say if System.dll
7974 2007-03-11 Marek Safar <marek.safar@gmail.com>
7976 * ecore.cs, parameter.cs, typemanager.cs: Another gmcs fix to work with
7979 2007-03-10 Marek Safar <marek.safar@gmail.com>
7981 * class.cs, parameter.cs: Unified parameters verification.
7983 2007-03-08 Martin Baulig <martin@ximian.com>
7985 * cs-parser.jay (constructor_header): Pass the location to the
7986 newly created TopLevelBlock.
7988 2007-03-07 Martin Baulig <martin@ximian.com>
7990 * statement.cs (Block.Resolve): Don't crash on error; bug #80715.
7992 2007-03-06 Miguel de Icaza <miguel@novell.com>
7994 * convert.cs (ExplicitReferenceConversionExists): Sync this method
7995 with the changes from David, fixes the build.
7997 2007-03-05 David Mitchell <dmitchell@logos.com>
7999 * convert.cs: Implement From System.Collecitons.Generic.IList<T>
8000 and its base interfaces to a one-dimensional array type S[],
8001 provided there is an implicit or explicit reference conversion
8004 2007-03-03 Marek Safar <marek.safar@gmail.com>
8006 * cs-tokenizer.cs: Implemented basic linq grammar.
8008 * driver.cs: Set linq lang version on demand.
8010 2007-02-26 Marek Safar <marek.safar@gmail.com>
8012 * cs-parser.jay, expression.cs: Compile empty __arglist correctly.
8014 2007-02-25 Marek Safar <marek.safar@gmail.com>
8016 * attribute.cs: Replaced DefinePInvoke in favor of S.R.E implementation
8019 * class.cs (InterfaceMemberBase): Share common `extern' modifier checks
8021 Check property and event extern attributes.
8023 * codegen.cs (ModuleClass): HasDefaultCharSet when module defined global
8026 2007-02-24 Marek Safar <marek.safar@gmail.com>
8028 A fix for bug #80407
8029 * ecore.cs: Don't report ambiguity error when methods have same parent.
8031 2007-02-23 Marek Safar <marek.safar@gmail.com>
8033 A fix for bug #80878
8034 * class.cs, cs-parser.jay: Event property can host anonymous methods.
8036 2007-02-22 Marek Safar <marek.safar@gmail.com>
8038 * attribute.cs: Enable ExtensionAttribute presence test.
8040 2007-02-22 Marek Safar <marek.safar@gmail.com>
8042 * class.cs: Warn about missing GetHashCode only when Equals is override.
8044 * decl.cs: Check accessibility of type arguments.
8046 * typemanager.cs: Correctly report nullable array.
8048 2007-02-20 Marek Safar <marek.safar@gmail.com>
8050 * class.cs, report.cs: Capture more details when things go wrong.
8052 2007-02-20 Marek Safar <marek.safar@gmail.com>
8054 A fix for bug #80650
8055 * cs-parser.jay: Anonymous container starts at constructor declaration
8056 and not at block beginning because it has to be usable in constructor
8059 * statement.cs: Use context location and not block one for error reporting.
8061 2007-02-18 Marek Safar <marek.safar@gmail.com>
8063 A fix for bug #78712
8064 * class.cs.cs, decl.cs, ecore.cs: LookupAnyGeneric inspects nested types
8067 2007-02-18 Marek Safar <marek.safar@gmail.com>
8069 A fix for bug #80493 by Atsushi Enomoto
8070 * cs-parser.jay: Ignore invalid attribute target.
8072 2007-02-18 Marek Safar <marek.safar@gmail.com>
8074 * cs-tokenizer.cs: Ignore '\0' as white space character.
8076 2007-02-17 Miguel de Icaza <miguel@novell.com>
8078 * cs-parser.jay: Add support for lambda expressions to the mcs
8081 * lambda.cs: Only clone when we are probing, not on the final call
8082 (Compatible is the final call).
8084 * statement.cs (CloneContext): Introduce class to provide block
8085 remapping during clone.
8087 All statements Clone themselves now.
8089 (Clone): special handling for blocks, when we clone a block, we
8090 register the block inside this routine, as children of the block
8091 might trigger a lookup.
8093 * expression.cs: Add support for CloneContext in all expressions.
8095 2007-02-17 Marek Safar <marek.safar@gmail.com>
8097 A fix for bug #80493
8098 * statement.cs: Report ambiguous warning when interfaces are not related.
8100 2007-02-15 Marek Safar <marek.safar@gmail.com>
8102 C# 3.0 extension methods.
8104 * attribute.cs (Error_MisusedExtensionAttribute): Extension attribute
8105 cannot be used directly.
8107 * class.cs (Class.Emit): Emit extension attribute if any class method
8108 is extension method.
8109 (Method.Define): Add basic extension method validation conditions.
8110 (Method.Emit): Emit extension attribute for method.
8112 * codegen.cs (AssemblyClass): Emit extension attribute if at least one
8113 extension method exists. Currently we follow same approach as Microsoft
8114 does, emit even if a method or a class are private but this can change
8117 * cs-parser.jay: Add handling of `this' keyword in method parameters
8120 * decl.cs (DeclSpace.IsStaticClass): New property.
8121 (MemberCache.FindExtensionMethods): Looks for extension methods with
8122 defined name and extension type.
8124 * doc.cs: Updated after OverloadResolve changes.
8126 * driver.cs: Add new soft reference to System.Core.dll.
8128 * ecore.cs (MethodLookup): Can return only MethodGroupExpr.
8129 (ExtensionMethodGroupExpr): Represents group of extension methods.
8131 * expression.cs (Invocation): Moved methods BetterConversion, MoreSpecific,
8132 BetterFunction, IsOverride, IsAncestralType, OverloadResolve
8133 to MethodGroupExpr and made non-static for easier customization.
8134 (Invocation.DoResolve): Add extension method lookup when no standard
8136 (MemberAccess.DoResolve): Try extension methods if no member exists.
8138 * modifiers.cs: Add METHOD_EXTENSION modifier.
8140 * namespace.cs (RegisterExtensionMethodClass): Register class namespace
8141 as well as candidate extension type.
8142 (ComputeNamespaces): When assembly constains extension methods registers
8144 (Namespace.RegisterExternalExtensionMethodClass): Register type for later
8145 extension method lookup.
8146 (Namespace.LookupExtensionMethod): Looks for extension method in this
8148 (NamespaceEntry.LookupExtensionMethod): Does extension methods lookup to
8149 find a method which matches name and extensionType.
8151 * parameter.cs (Parameter): Add This modifer.
8152 (HasExtensionMethodModifier): New property.
8153 (Resolve): Add extension parameter check.
8154 (ModFlags): turned to property to exclude this modifier as it is not real
8156 (Parameters): Implemented ExtensionMethodType and HasExtensionMethodType.
8158 * support.cs (ParameterData): Add ExtensionMethodType.
8159 (ReflectionParameters): Implemented ExtensionMethodType interface property.
8161 * typemanager.cs: Add type and ctor extension attribute type.
8163 2007-02-15 Miguel de Icaza <miguel@novell.com>
8165 * report.cs (DisableErrors, EnableErrors): used to prevent error
8166 output when we are "trying" to compile various methods with
8169 * ecore.cs (Expression): Add Clone method that calls the virtual
8170 CloneTo method. The current CloneTo method in Expression throws
8171 an exception so we can track down all the places where this must
8172 be implemented (not using abstract, because that would be a lot of
8173 up-front-work before we can start testing the implementation
8176 Important: we only need Clone capabilities for expressions created
8177 by the parser, as the expressions we will be cloning are
8178 expressions in the pre-resolved state. This vastly simplifies
8181 (SimpleName): Add CloneTo that does nothing.
8182 (EmptyCast): Add CloneTo.
8184 * expression.cs (Binary): Implement CloneTo.
8185 (Invocation.IsApplicable): Store the current ec in
8186 EmitContext.TempEc and restore it on return. This is used so we
8187 do not have to sprinkle hundres of methods with an extra
8188 EmitContext, we know that the only user is the lambda expression
8189 ImplicitConversionExists code.
8191 (Argument): Add Cloning capabilities.
8192 (LocalVariableReference, ParenthesizedExpression, Unary, Probe,
8193 Cast, Conditional, ArrayCreation, InvocationOrCast, Invocation,
8194 ArglistAccess, ArgList, TypeOf, SizeOf, CheckedExpr,
8195 UnCheckedExpr, ElementAccess, BaseAccess, BaseIndexerAccess,
8196 IndexerAccess): Add Clone capability.
8198 (LocalVariableReference, This): TODO: needs cloned Block mapping.
8200 (Argument): Add cloning capability.
8202 * assign.cs (Assign): Implement CloneTo.
8204 * anonymous.cs (ImplicitStandardConversionExists): Make virtual.
8206 * lambda.cs (ImplicitStandardConversionExists): Implement lambda
8207 version by calling Convert with the EmitContext (that we are
8208 currently storing in ec, this is not great, but will do for now,
8209 to avoid passing EmitContext parameters to hundreds of functions
8210 that do not need them now).
8212 (SetExpression): Remove, it is not needed.
8214 (ContextualReturn): Implement CloneTo.
8216 * statement.cs (Statement): Implement cloning infrastructure,
8217 similar to expressions.
8219 (Block): Partial implementation of Clone for statements.
8221 (Return): Implement clone.
8223 * constant.cs (Constant.CloneTo): New method, does nothing.
8225 * codegen.cs (TempEc): Add a static EmitContext as a temporary
8226 solution, until we decide how to exactly do this.
8228 2007-02-14 Marek Safar <marek.safar@gmail.com>
8230 A fix for bug #80493
8231 * class.cs (FindOutBaseMethod): When the base accessor does not exist and
8232 a property is override we need to use second accessor.
8234 2007-02-13 Marek Safar <marek.safar@gmail.com>
8236 A fix for bug #80418
8237 * attribute.cs, class.cs: Use correct calling conventions for pinvoke
8240 2007-02-13 Marek Safar <marek.safar@gmail.com>
8242 Another fix for bug #80749
8243 * pending.cs: Abstract class has priority over interfaces.
8245 2007-02-13 Marek Safar <marek.safar@gmail.com>
8247 Another fix for bug #80749
8248 * pending.cs: Abstract class has priority over interfaces.
8250 2007-02-13 Marek Safar <marek.safar@gmail.com>
8252 Another fix for bug #80749
8253 * pending.cs: Abstract class has priority over interfaces.
8255 2007-02-13 Marek Safar <marek.safar@gmail.com>
8257 Another fix for bug #80749
8258 * pending.cs: Abstract class has priority over interfaces.
8260 2007-02-13 Marek Safar <marek.safar@gmail.com>
8262 * class.cs Better error message.
8264 * driver.cs: Add shorter versions of -optimize option.
8266 2007-02-13 Martin Baulig <martin@ximian.com>
8268 * class.cs (Constructor.Emit): Check the return value of
8269 ec.ResolveTopBlock() and return on error.
8271 2007-02-13 Raja R Harinath <rharinath@novell.com>
8273 * ecore.cs (Error_InvalidExpressionStatement): Add a comma to error
8274 message to fix error message regression.
8276 2007-02-12 Marek Safar <marek.safar@gmail.com>
8278 * delegate.cs: Delegate creation expression cannot be of Nullable type.
8280 2007-02-12 Marek Safar <marek.safar@gmail.com>
8282 A fix for bug #80749
8283 * assign.cs (FieldInitializer): FieldInitializer has to keep track of
8284 its parent container.
8286 * class.cs (DefineFieldInitializers): Each initializer can has different
8289 * const.cs: Updated.
8291 2007-02-11 Miguel de Icaza <miguel@novell.com>
8293 * lambda.cs (LambdaExpression.Compatible): Remove some early code,
8294 now all the heavy lifting to check that embedded statements or
8295 expressions have the right form is done in the ContextualReturn.
8297 (ContextualReturn): New class.
8299 * ecore.cs (Error_InvalidExpressionStatement): Make a helper
8300 method that can be invoked to report 201, so we do not replicate
8303 * cs-parser.jay: Reuse Error_InvalidExpressionStatement.
8305 * cs-tokenizer.cs (xtoken): Correctly compute the column, it was
8306 treating tabs as spaces.
8308 2007-02-09 Marek Safar <marek.safar@gmail.com>
8310 A fix for bug #80315 by martin.voelkle@gmail.com (Martin Voelkle)
8311 * assign.cs: Use full implicit conversion for right side check.
8313 2007-02-09 Marek Safar <marek.safar@gmail.com>
8315 * statement.cs (Switch): Switch over boolean type is not standardized.
8317 2007-02-08 Marek Safar <marek.safar@gmail.com>
8319 A fix for bug #80755
8320 * decl.cs (FindBaseEvent): Don't use method cache for events.
8322 2007-02-07 Marek Safar <marek.safar@gmail.com>
8324 * cs-parser.jay: Better syntax error handling.
8326 * ecore.cs, enum.cs, statement.cs, typemanager.cs: Print enum member name
8327 instead of underlying type value.
8329 2007-02-06 Marek Safar <marek.safar@gmail.com>
8331 * driver.cs: Check define identifier before is registered.
8333 * namespace.cs: Use existing error message.
8335 * report.cs: New warning.
8337 2007-02-06 Marek Safar <marek.safar@gmail.com>
8339 A fix for bug #80742
8340 * expression.cs: Delegate Invoke method can be called directly.
8342 2007-02-06 Marek Safar <marek.safar@gmail.com>
8344 A fix for bug #80676
8345 * class.cs (IsEntryPoint): The Main method can have params modifier.
8347 2007-02-04 Miguel de Icaza <miguel@novell.com>
8349 * parameter.cs (Parameter, Parameters): Add Clone method.
8351 * anonymous.cs (Compatible): Turn method into virtual method, so
8352 LambdaExpression can implement a different behavior.
8354 (CompatibleChecks, VerifyExplicitParameterCompatibility): Factor
8355 out the basic checking here, so it can be used by
8358 * lambda.cs: Introduce "Compatible" function that will do the
8361 2007-02-02 Marek Safar <marek.safar@gmail.com>
8363 * attribute.cs: Unified one error message.
8365 * class.cs (Class): Use type attributes and not properties to test static
8367 (IsEntryPoint): Don's pass local variable.
8369 * convert.cs: Removed duplicate check.
8371 * decl.cs, doc.cs, ecore.cs (LookupType): Renamed to LookupNamespaceOrType.
8373 * driver.cs: Don't crash when soft reference does not exist.
8375 * namespace.cs (EnsureNamespace): Renamed to RegisterNamespace.
8376 (UsingEntry): Removed redundant allocation.
8378 * parameter.cs: Add fast path for type parameters.
8380 * support.cs: Don't allocate attribute when it's not used.
8382 2007-01-30 Miguel de Icaza <miguel@novell.com>
8385 (AnonymousMethodExpression.ImplicitStandardConversionExists): turn
8386 this into a virtual method, so we can override it in LambdaExpression.
8388 * driver.cs: Improve diagnostics in case of failure.
8390 * cs-tokenizer.cs: Instead of trying to parse a type and a name,
8391 write a function that is slightly more complex and that parses:
8393 type identifier [, type identifier]* )
8395 The old function would return incorrectly a OPEN_PARENS_LAMBDA for
8398 (canEmpty ? i >= 0 : i > 0)
8400 2007-01-30 Raja R Harinath <rharinath@novell.com>
8402 * cs-tokenizer.cs (parse_namespace_or_typename): Don't throw an
8403 exception on possibly valid code.
8405 2007-01-29 Raja R Harinath <rharinath@novell.com>
8407 * cs-tokenizer.cs (is_punct) ['<']: Update to changes in
8409 (parse_opt_type_arguments): Remove. It's almost the same as
8411 (parse_namespace_or_typename): Use parse_less_than.
8413 2007-01-28 Miguel de Icaza <miguel@novell.com>
8415 * cs-tokenizer.cs: Typo fix, its not GMCS_SOURCES but GMCS_SOURCE,
8416 this bug took a few hours to find, because the state saved and
8417 restored by PushPosition and PopPosition was ignoring the state of
8418 parse_generic_less_than.
8420 I can also now remove the handling of OP_LT and OP_GT, this solves
8423 * cs-tokenizer.cs: store the location for the ARROW token, we use
8426 (PushPosition, PopPosition): save/restore also `current_token',
8427 restore `parse_generic_less_than' (was missing).
8429 (parse_opt_type_arguments): use parse_type, not
8430 parse_namespace_or_typename to parse types.
8432 * lambda.cs: Empty new file, will eventually have the lambda
8433 expression implementation.
8435 * lambda.test: used to test the internal tokenizer.
8437 * report.cs (FeatureIsNotISO1): Rename from
8438 FeatureIsNotStandardized, because it was about the language level
8439 (1 vs 2) it was not about standarization.
8441 (FeatureRequiresLINQ): New.
8443 * support.cs (SeekableStreamReader): Only require that the reader
8444 is a TextReader, not a StreamReader, so we can plug StringReader.
8446 * cs-tokenizer.cs (parse_type_and_parameter): Returns true if at a
8447 given position in the input stream the following tokens can be
8448 parsed as a type followed by an identifier.
8450 (is_punct): after a '(' if parse_type_and_parameter returns true,
8451 then return a special token OPEN_PARENS_LAMBDA which is used to
8452 avoid reduce/reduce errors in the grammar for the
8453 lambda_expression rules.
8455 (parse_type): implement a type parser inside the
8456 tokenizer, the parser only returns true or false depending on
8457 whether the input at a given position can be parsed as a type.
8459 (peek_token): new method used during type parsing.
8461 2007-01-28 Raja R Harinath <rharinath@novell.com>
8464 * anonymous.cs (ScopeInfo.InflateParameters): New.
8465 (AnonymousContainer.Resolve): Use it to redirect types of
8466 delegate parameters.
8468 2007-01-27 Raja R Harinath <rharinath@novell.com>
8471 * expression.cs (Error_InvalidArguments): Don't use two different
8472 messages for CS1503. Use ExtraInformation and
8473 SymbolRelatedToPreviousError instead.
8476 * decl.cs (DeclSpace.initialize_type_params): Don't access
8477 'type_params' of a partial class directly.
8479 2007-01-26 Miguel de Icaza <miguel@novell.com>
8481 * constant.cs: Removed a handful of out-of-range checks that were
8484 2007-01-25 Marek Safar <marek.safar@gmail.com>
8486 * expression.cs (CheckUselessComparison): Add additional check for char
8489 * namespace.cs: Fixed typo.
8491 2007-01-23 Miguel de Icaza <miguel@novell.com>
8493 * constant.cs: Bloat removal, CheckRange and CheckUnsigned are
8494 gone, instead we inline the test, preventing the needless casts to
8495 longs, ulongs and doubles for the parameters, avoiding calls to
8496 methods that overchecked stuff, and instead inlined things
8499 2007-01-20 Marek Safar <marek.safar@gmail.com>
8501 * cs-parser.jay: Better parameter error handling.
8503 2007-01-17 Marek Safar <marek.safar@gmail.com>
8505 A fix for bug #80368, #80522
8506 * expression.cs (ArrayCreation.only_constant_initializers): Indicates
8507 whether array initializer contains constants only.
8508 (ArrayCreation.Emit): Use better formula to decide when
8509 are array initializers for static initialization.
8510 (ArrayCreation.EmitDynamicInitializers): When the array is small enough we
8511 have to emit even constants otherwise they are pre-initialized.
8513 2007-01-17 Bill Holmes <bill.holmes@ansys.com>
8514 Raja R Harinath <rharinath@novell.com>
8516 Fix emit order of 'get' vs. 'set'.
8517 * support.cs (Accessors): New.
8518 * cs-parser.jay (accessor_declarations): Use it instead of 'Pair'.
8519 Note the order in which accessors are declared in the source.
8520 * class.cs (PropertyBase.DefineGet, PropertyBase.DefineSet): New.
8521 Refactored from Property.Define and Indexer.Define.
8522 (PropertyBase.DefineAccessors): New helper that calls the above in
8523 appropriate order as noted by the parser.
8524 (Property.Define, Indexer.Define): Update to changes.
8525 (PropertyBase.SetMethod.PropertyInfo): Don't return a null.
8527 2007-01-17 Raja R Harinath <rharinath@novell.com>
8529 Fix cs0029-6.cs and gcs0029-2.cs (regression)
8530 * ecore.cs (EmptyConstantCast.ConvertImplicitly): Check that
8531 there's an implicit conversion from the current type to the target
8532 type before converting the underlying constant.
8534 2007-01-16 Marek Safar <marek.safar@gmail.com>
8536 * const.cs (ResolveValue): Updated after constant conversion was made more
8539 * constant.cs (GetAttributableValue): constant to object conversion is
8540 used for attributes only.
8541 (IntConstant.ConvertImplicitly): Moved from convert to be used in all
8542 constant conversions.
8543 (LongConstant.ConvertImplicitly): Ditto.
8545 * convert.cs (ImplicitNumericConversion): Extracted constant bussiness.
8546 (ImplicitConversionStandard): Handle constant conversion as extra step.
8547 It solves the issue when constant conversion was called indirectly like
8548 inside array initializer and constant folding was skipped.
8550 * literal.cs (NullLiteral.ConvertImplicitly): Fixed an issue exposed by
8553 * statement.cs(ImplicitConversionStandard): Updated after constant
8554 conversion was made more generic.
8556 2007-01-16 Sergey P. Kondratyev <se@unicom.tomica.ru>
8558 * expression.cs (As.DoResolve): Use GenericConstraints instead of
8559 Constraints, solves the problem where the compiler incorrectly
8560 reported that a type parameter was not constrained to a class (Bug
8563 2007-01-14 Marek Habersack <grendello@gmail.com>
8565 * doc-bootstrap.cs: Fix a compilation problem in the bootstrap phase.
8567 2007-01-14 Marek Safar <marek.safar@gmail.com>
8569 A fix for bug #80368
8570 * assign.cs (FieldInitializer): New class implements field
8571 initializer statement.
8573 * attribute.cs: Update after FieldMember rename.
8575 * class.cs (PropertyBasedMember): New common class for property based
8577 (InterfaceMemberBase): New base class for all members which can be used as
8578 an interface members.
8579 (MethodCore): Moved really common code to InterfaceMemberBase.
8580 (Method.Define): Equal and GetHasCode detection is relevant for methods
8582 (MethodData.Define): Don't assume that public event implements an
8583 interface automatically.
8584 (MethodData.DefineMethodBuilder): Issue an error even if only extern
8586 (MemberBase): Moved all interface speficic code to InterfaceMemberBase.
8587 (FieldMember): Merged with FieldBase.
8588 (EventProperty.AEventPropertyAccessor): New specialization to check whether
8589 event extern modifier can be used.
8590 (EventField.EventFieldAccessor): Moved event field specific code here.
8591 (Event.AllowedModifiers): Even event can be extern.
8592 (Event.FindOutBaseMethod): New override specific to events.
8593 (Indexer.parameters): Reintroduce parameters because base class holds
8594 only properties common data.
8595 (Indexer.CheckForDuplications): Indexers are threated as methods so we
8596 need do extra parameters check.
8598 * const.cs: Update after FieldMember rename.
8600 * decl.cs (MemberCache.FindBaseEvent): New method.
8602 * doc.cs (GetMethodDocCommentName): Accept parameters as extra argument
8603 to reflect that indexer is now derived from PropertyBased.
8605 * ecore.cs (GetMemberType): Made public.
8606 (EventExpr.ResolveMemberAccess): Use right event cache and checks for
8609 * flowanalysis.cs, statement.cs: Update after FieldMember rename.
8611 * typemanager.cs (CSharpSignature): Correctly print event accessors.
8612 (RegisterEvent): Removed.
8613 (RegisterPrivateFieldOfEvent): Renamed to RegisterEventField.
8614 (GetPrivateFieldOfEvent): Renamed to GetEventField.
8616 2007-01-11 Raja R Harinath <rharinath@novell.com>
8619 * statement.cs (CollectionForeach.TryType): Prefer generic
8620 GetEnumerator over non-generic variant. Fix code to follow comments.
8622 2007-01-09 Raja R Harinath <rharinath@novell.com>
8625 * support.cs (ReflectionParameter): Don't use an invalid index on
8626 the generic parameter data.
8628 2007-01-08 Miguel de Icaza <miguel@novell.com>
8630 * driver.cs: Just add a tiny bit of infrastructure.
8632 2007-01-02 Marek Safar <marek.safar@gmail.com>
8634 * class.cs (VerifyMembers): Fixed an crash reported on mono mailing list
8635 where field type is struct from current assembly.
8637 * ecore.cs (EnumConstant.AsString): Report an enum member name whenever
8640 2007-01-02 Marek Safar <marek.safar@gmail.com>
8642 A fix for bug #80381
8643 * attribute.cs (AttributeTester.RegisterNonObsoleteType): Registers
8646 * namespace.cs (GlobalRootNamespace.LookupTypeReflection): Better error
8648 (Namespace.LookupType): Always use core types from corlib when speficied.
8650 * report.cs: A new warning.
8652 * rootcontext.cs (BootstrapCorlib_ResolveInterface,
8653 BootstrapCorlib_ResolveClass): Register type as non-obsolete type.
8654 (ResolveCore): Add missing System.Runtime.InteropServices._Attribute.
8656 * typemanager.cs (CoreLookupType): Register type as non-obsolete type.
8657 (InitCoreTypes): Set expression type of object_type and value_type
8658 immediately after lookup.
8660 2007-01-01 Miguel de Icaza <miguel@novell.com>
8662 * cs-tokenizer.cs: Accept Pc class characters (Connector
8663 Punctuation) as valid identifiers. Fixes #78259
8665 * expression.cs (Invocation.DoResolve): Moved the check for the
8666 use of `this' for doing method calls to the Invocation resolution
8667 step, after overload resolution has taken place instead of doing
8668 the check at the low-level `This.DoResolve' level.
8670 The `This.DoResolve'(appens before overload resolution, so it has
8671 no way of knowing if the method that will be called will be
8672 instace or static, triggering an erroneous report for cs0188 (Bug
8675 We now do the check for instance method invocations after we know
8676 what method will be called.
8678 (This.CheckThisUsage): Move the actual use of this structure
8679 checking into its own method and expose it.
8681 * Everywhere that called Error_ValueCannotBeConverted: pass a new
8684 Exceptions: Null.ConvertImplicitly,
8685 Constant.ImplicitConversionRequired as there are too many call
8686 sites for passing the ec.
8688 * ecore.cs (Expression.Error_ValueCannotBeConverted): Take an
8689 EmitContext, if the value is null, then we do not try to provide
8690 the extra information from the error (If a userdefined conversion
8691 exists, as UserDefinedConversion requires a non null-EmitContext).
8695 2006-12-30 Raja R Harinath <rharinath@novell.com>
8697 * flowanalysis.cs (MyBitVector): Document some invariants.
8698 (MyBitVector.Or, MyBitVector.And): Reimplement the optimizations
8699 introduced below, and add a couple of others,
8701 2006-12-30 Marek Safar <marek.safar@gmail.com>
8703 * attribute.cs (GetMethodObsoleteAttribute): Uses new
8704 GetPropertyFromAccessor and GetEventFromAccessor.
8706 * class.cs (MethodCore.CheckBase): A new warning when obsolete member
8707 overrides non-obsolete one.
8708 (Indexer.Define): Error message has been moved to the parser.
8710 * cs-parser.jay: Better syntax errors handling.
8712 * delegate.cs (NewDelegate.DoResolve): Issue less confusing error message
8713 when an invocation has no arguments.
8715 * ecore.cs: Removed not used caching.
8717 * expression.cs (IsSpecialMethodInvocation): Reuses TypeManager
8720 * report.cs: Add a new warning.
8722 * support.cs (ReflectionParameters): Implements Equals, GetHashCode.
8724 * typemanager.cs (enumeration_type): Removed.
8725 (CSharpSignature): Reuses IsSpecialMethod.
8726 (IsEqual): Hack for MS BCL.
8727 (GetPropertyFromAccessor): New method.
8728 (GetEventFromAccessor): New method.
8729 (IsSpecialMethod): Fixed to handle more cases.
8731 2006-12-30 Marek Safar <marek.safar@gmail.com>
8733 * cs-tokenizer.cs (PreProcessDefinition, handle_preprocessing_directive):
8734 Made white spaces array static.
8736 * ecore.cs (RemoveGenericArity): Optimized.
8738 * flowanalysis.cs (MyBitVector.Or, MyBitVector.And): Optimized (up to
8740 (MyBitVector.initialize_vector): Simplified.
8742 2006-12-22 Miguel de Icaza <miguel@novell.com>
8744 * ecore.cs: Am not entirely happy with this hack, but it seems to
8745 address the issue in 80257 (a small test case for
8748 I set the MethodGroupExpr.Type to an internal compiler type
8749 (itself in this case) to force the resolution to take place. Why
8750 it does not take place with a null is beyond me.
8752 2006-12-20 Marek Safar <marek.safar@gmail.com>
8754 A fix for bug #80288
8755 * expression.cs (ResolveOperator): Consider user defined conversion for
8756 logical and operator too.
8757 (EmitBranchable): Optimization for logical and when full constant folding
8758 could not be applied but one operand is constant.
8760 2006-12-19 Marek Safar <marek.safar@gmail.com>
8762 * class.cs (GetClassBases): Write 5 times every day, will never use
8763 FullName for error reporting.
8765 * decl.cs (AsAccessible, CheckAccessLevel): Always unpack arrays first.
8767 2006-12-19 Martin Baulig <martin@ximian.com>
8769 * statement.cs (LocalInfo.EmitSymbolInfo): New public method; emit
8770 the symbol file info here.
8772 2006-12-18 Marek Safar <marek.safar@gmail.com>
8774 * cs-tokenizer.cs (handle_preprocessing_directive): When previous section
8775 of `elseif' is taking then following sections are not taking.
8776 Fixes an issue reported on mono mailing list.
8778 2006-12-18 Marek Safar <marek.safar@gmail.com>
8780 A fix for bug #80300
8781 * cs-tokenizer.cs (PreProcessDefinition): Do no define/undefine when
8782 a caller is not taking.
8784 2006-12-18 Raja R Harinath <rharinath@novell.com>
8786 * anonymous.cs: Change several TypeContainer declarations to DeclSpace.
8787 (CompilerGeneratedClass): Use parent.PartialContainer unconditionally.
8788 (RootScopeInfo, AnonymousMethodMethod): Update to changes.
8789 * iterator.cs: Change several TypeContainer declarations to DeclSpace.
8790 * class.cs: Update to changes.
8792 2006-12-17 Marek Safar <marek.safar@gmail.com>
8794 A fix for bug #79934
8795 * anonymous.cs (CompilerGeneratedClass): Register class in a shared
8798 * class.cs (ResolveMembers): Register an iterator in current container and
8801 2006-12-16 Raja R Harinath <rharinath@novell.com>
8804 * expression.cs (VerifyArgumentsCompat): Allow zero arguments to
8805 satisfy a params annotated parameter.
8807 2006-12-16 Marek Safar <marek.safar@gmail.com>
8809 A fix for bug #77014
8810 * expression.cs (Invocation.BetterFunction): Fixed to cope with dynamic
8811 paramters correctly and not rely on hacks in Parameters class.
8812 (Invocation.IsParamsMethodApplicable): Changed to accept params parameter
8814 (Invocation.VerifyArgumentsCompat): Ditto.
8815 (Invocation.EmitArguments): Changed to correctly emit params arguments at
8818 * parameter.cs (HasParams): Don't assume that params is the last one.
8820 * support.cs (ReflectionParameters.ctor): Look for params attribute
8822 (ReflectionParameters.ParameterType): Removed hack when we returned last
8823 parameter for out of range parameters.
8824 (ParameterName, ParameterModifier): Ditto.
8826 2006-12-14 Marek Safar <marek.safar@gmail.com>
8828 A fix for bug #79987
8829 * decl.cs (DeclSpace.VerifyClsCompliance): External names cache is null
8830 when assembly is not CLS compliant but type is. I have no idea why is this
8833 * typemanager.cs (Reset): Invalidate AllClsTopLevelTypes cache.
8835 2006-12-13 Miguel de Icaza <miguel@novell.com>
8837 * class.cs (ConstructorInitializer.Resolve): Allow for ":this()"
8838 in struct constructors, they are basically no-ops.
8840 2006-12-12 Marek Safar <marek.safar@gmail.com>
8842 * cs-tokenizer.cs (Position): Save preprocessor status too.
8844 2006-12-12 Marek Safar <marek.safar@gmail.com>
8846 A fix for bug #77794
8847 * cs-tokenizer.cs (consume_identifier): Check for correct partial context.
8849 2006-12-12 Marek Safar <marek.safar@gmail.com>
8851 * cs-tokenizer.cs (get_cmd_arg): Support CR as the line terminator.
8853 (pp_expr): Report error for an invalid expression.
8854 (handle_preprocessing_directive): Simplified; add more error checking.
8856 2006-12-11 Marek Safar <marek.safar@gmail.com>
8858 A fix for bug #74939
8859 * cs-tokenizer.cs (is_punct): We cannot simply disable preprocessor
8860 directives handling.
8862 2006-12-10 Marek Safar <marek.safar@gmail.com>
8864 A fix for bugs #80093, and #75984
8865 * cs-tokenizer.cs (handle_preprocessing_directive): Fixed #if/#else/#endif
8866 logic, it seems to me as it worked before "by coincidence".
8867 (xtoken): Simplified to use reworked handle_preprocessing_directive.
8868 (cleanup): Enabled endif check.
8870 2006-12-09 Marek Safar <marek.safar@gmail.com>
8872 A fix for bug #80162
8873 * statement.cs (CollectionForeach.TryType): Generics and non-generics
8874 enumerators are never ambiguous.
8876 2006-12-08 Raja R Harinath <rharinath@novell.com>
8879 * cs-tokenizer.cs (parse_less_than): Recognize double-colons too.
8881 2006-12-06 Marek Safar <marek.safar@gmail.com>
8883 A fix for bug #80144
8884 * class.cs (EventProperty.Define): Explicit implementation means
8885 that an even is used.
8887 2006-12-06 Marek Safar <marek.safar@gmail.com>
8889 Fixes the operators implementation (part II)
8891 * cfold.cs (DoConstantNumericPromotions): Renamed to
8892 DoBinaryNumericPromotions and simplified.
8893 (BinaryFold): Couple of conversion fixes; simplified.
8895 * constant.cs, ecore.cs, literal.cs
8896 (ToType): Renamed to ConvertImplicitly.
8897 (Reduce): Renamed to ConvertExplicitly.
8899 * class.cs, convert.cs: Updated.
8901 * expression.cs: TryReduce doesn't throw an exception.
8903 2006-12-01 Marek Safar <marek.safar@gmail.com>
8905 A fix for bug #80108
8906 * ecore.cs (EventExpr.EmitAddOrRemove): Don't crash when right side is not
8909 2006-11-30 Marek Safar <marek.safar@gmail.com>
8911 Fixes unary operators implementation (part I)
8914 * cfold.cs (Error_CompileTimeOverflow): Made internal
8916 * const.cs (IConstant): Changed to use reference to constant and
8917 not constant itself.
8918 Updated IConstant implementations.
8920 * constant.cs (CreateConstant): New factory method.
8921 Updated IConstant implementation.
8923 * convert.cs (ImplicitStandardConversionExists): Uses compiler Equals.
8925 * ecore.cs: Updated to use CreateConstantReference.
8927 * enum.cs: Reflects IConstant changes.
8929 * expression.cs (Unary): Reimplemented +,-,~ to conform C# standard.
8931 * literal.cs (NullConstant): Change to be independently usable.
8933 2006-11-29 Martin Baulig <martin@ximian.com>
8935 * class.cs (Constructor.Emit): Correctly handle anonymous methods;
8936 we need to emit the scope initializer before calling the base .ctor.
8938 * anonymous.cs: Merged back from the new anonymous methods branch.
8939 (AnonymousMethodHost): Renamed to `RootScopeInfo'.
8941 * expression.cs (ParameterReference.DoResolveBase): Create a
8942 "normal" ScopeInfo when capturing parameters rather than using the
8943 root scope; this makes things work with anonymous methods having
8947 (ToplevelBlock.AnonymousMethodHost): Renamed into `RootScope'.
8949 2006-11-22 Marek Safar <marek.safar@gmail.com>
8951 A fix for bug #79987
8952 * class.cs (VerifyClsCompliance): Move redundant CLS compliance attribute
8953 check to a base class.
8954 * decl.cs (VerifyClsCompliance): Warn that CLS compliance cannot be tested
8955 only when assembly has missing attribute.
8956 * report.cs: Update.
8958 2006-11-21 Marek Safar <marek.safar@gmail.com>
8960 * cs-tokenizer.cs: Merged with gmcs version.
8962 2006-11-20 Marek Safar <marek.safar@gmail.com>
8965 * cs-parser.jay: Better error message when partial keyword is misplaced.
8967 2006-11-19 Gert Driesen <drieseng@users.sourceforge.net>
8969 A fix for bug #79810
8970 report.cs: CS1058 only applies to 2.0 profile (gmcs).
8971 codegen.cs: on 2.0 profile, non-exception throwables are wrapped in
8972 a RuntimeWrappedException by default.
8974 2006-11-18 Marek Safar <marek.safar@gmail.com>
8976 A fix for bug #79843
8977 * delegate.cs (Delegate.VerifyMethod): Fixed covariance and contravariance
8979 (DelegateCreation.Error_NoMatchingMethodForDelegate): Ditto.
8981 2006-11-18 Marek Safar <marek.safar@gmail.com>
8983 * driver.cs, namespace.cs: Uses faster IndexOf version.
8985 2006-11-17 Marek Safar <marek.safar@gmail.com>
8987 A fix for bug #79941
8988 * class.cs (MemberCore.IsDuplicateImplementation): Add more tricks for
8990 (Operator.Define): Implicit/Explicit operator of same type is duplicate
8991 even if internal name is different.
8992 * convert.cs (GetConversionOperator): Replaced EmitContext with parentType.
8993 (UserDefinedConversion): Simplified as the operators cannot be internal.
8994 * ecore.cs (Error_ValueCannotBeConverted): Take account of user
8996 (MethodLookup): Replaced EmitContext with parentType.
8997 * expression.cs: Updated.
8999 2006-11-09 Raja R Harinath <rharinath@novell.com>
9001 * driver.cs (BadAssembly): Handle all the ugliness of
9002 DefineDynamicAssembly.
9004 2006-11-08 Raja R Harinath <rharinath@novell.com>
9006 Address parts of #58244 -- most of what's left is in the runtime
9007 * driver.cs (LoadAssembly): Simplify slightly. Add CS0009 and
9008 CS1509 error checks, and handle them for all assembly loads, not
9009 just the first invocation.
9010 (LoadModule): Likewise. Move handling of 'adder_method' ...
9011 * codegen.cs (AssemblyClass.AddModule): ... here.
9013 2006-11-02 Marek Safar <marek.safar@gmail.com>
9015 * statement.cs.cs (CollectionForeach.TryType): Issue a error when
9016 IEnumerable<T> is ambiguous.
9018 2006-10-31 Marek Safar <marek.safar@gmail.com>
9020 A fix for bug #67689
9021 * statement.cs.cs (CollectionForeach.TryType): Issue a warning when
9022 GetEnumerator is ambiguous.
9024 * report.cs: Add new warning.
9026 2006-10-29 Marek Safar <marek.safar@gmail.com>
9028 A fix for bug #78602
9029 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9030 to protected member can be nested type.
9032 2006-10-28 Marek Safar <marek.safar@gmail.com>
9034 A fix for bug #78965
9035 ecore.cs (PropertyExpr.InstanceResolve): The qualifier for access
9036 to protected member must derive from current type.
9038 2006-10-27 Marek Safar <marek.safar@gmail.com>
9040 assign.cs: Reuses error method.
9042 ecore.cs (Expression.Error_ValueCannotBeConverted): Report a value
9043 instead of type for constants.
9044 (Expression.Error_ValueAssignment): Common error method.
9046 * expression.cs (UnaryMutator.ResolveOperator): Value cannot be used
9049 2006-10-27 Marek Safar <marek.safar@gmail.com>
9051 A fix for bug #79081
9052 * expression.cs (MemberAccess.DoResolve): Check nested type
9055 2006-10-27 Atsushi Enomoto <atsushi@ximian.com>
9057 * doc.cs : nested delegates were not handled. Fixed bug #79754.
9059 2006-10-26 Marek Safar <marek.safar@gmail.com>
9061 A fix for bug #76591
9062 * cs-tokenizer.cs (IsCastToken): Enable a cast of anonymous method.
9064 2006-10-26 Marek Safar <marek.safar@gmail.com>
9066 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Don't allow to have
9067 type forwarder of the same type multiple times.
9069 2006-10-26 Raja R Harinath <rharinath@novell.com>
9072 * ecore.cs (PropertyExpr.InstanceResolve): Always resolve the
9073 instance as an rvalue, even when we later resolve as an lvalue.
9075 2006-10-25 Martin Baulig <martin@ximian.com>
9077 * anonymous.cs: Fix #79673.
9079 2006-10-24 Marek Safar <marek.safar@seznam.cz>
9081 A fix for bug #79666
9082 expression.cs (ArrayCreation.GetAttributableValue): An initializer can be
9083 ignored when is optimized (= default value) as its value is already set.
9085 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9087 A fix for bug #79724
9088 * report.cs (SymbolRelatedToPreviousError): Uses DeclSpace instead of
9089 TypeContainer for type lookup.
9091 2006-10-23 Marek Safar <marek.safar@seznam.cz>
9093 A fix for bug #79231
9094 * ecore.cs (ResolveAsBaseTerminal): Removed redundant error test.
9095 * expression.cs (OverloadResolve): Always convert type name for
9097 (ResolveNamespaceOrType): Don't confuse a nested type with any
9100 2006-10-18 Martin Baulig <martin@ximian.com>
9102 * anonymous.cs: Propagate the IsStatic state, fixes the crasher in banshee.
9104 2006-10-17 Miguel de Icaza <miguel@novell.com>
9106 * convert.cs: Fix typo, fixes the test-535.cs, we were casting to
9107 an int32, but requesting an int64 from the conversion
9109 2006-10-12 Martin Baulig <martin@ximian.com>
9112 (AnonymousContainer.Resolve): Inflate the `ReturnType'. Fixes #79592.
9114 2006-10-12 Martin Baulig <martin@ximian.com>
9117 (Using.EmitLocalVariableDeclFinally): Small fix for iterators.
9119 2006-10-11 Miguel de Icaza <miguel@novell.com>
9121 * convert.cs: Remove broken code: I was doing the "Existance"
9122 tests for Implicit conversions.
9124 2006-10-10 Miguel de Icaza <miguel@novell.com>
9126 * convert.cs: Added one missing case in
9127 ImplicitStandardConversionExists uint64 to intptr.
9131 * typemanager.cs (uintptr_type): another core known type.
9133 * ecore.cs (OperatorCast): routine used to do cast operations that
9134 depend on op_Explicit. We could change some of the Decimal
9135 conversions to use this.
9137 This one has a probe mechanism that checks both types for an op_
9138 which it coudl be used to eliminate two classes: CastToDecimal
9139 and CastFromDecimal.
9141 * convert.cs: Implement the conversions documented in #59800
9143 2006-10-10 Martin Baulig <martin@ximian.com>
9145 * iterators.cs (Iterator.Resolve): Call RootScope.ResolveType()
9146 before RootScope.ResolveMembers().
9148 * anonymous.cs (ScopeInfo.CapturedScope.ctor): Use the child's
9149 `CurrentType' if appropriate.
9151 2006-10-09 Marek Safar <marek.safar@seznam.cz>
9153 A fix for bug #78568
9154 * cs-tokenizer.cs (Deambiguate_CloseParens): Expression cannot be cast
9155 when contains binary operators.
9156 * cs-parser.jay: Updated.
9158 2006-10-09 Martin Baulig <martin@ximian.com>
9161 (Delegate.DefineType): Don't call TypeParameter.Resolve() here;
9162 moved that into Define() and also do the other type parameter
9163 checks there. Fixes #79094. Added gtest-292.cs.
9166 (ArrayCreation.EmitDynamicInitializers): Use `etype.IsValueType'
9167 since that doesn't include type parameters; don't use `Ldelema'
9168 for type parameters. Fixes #78980. Added gtest-293.cs.
9170 2006-10-08 Marek Safar <marek.safar@seznam.cz>
9173 * convert.cs (ExplicitReferenceConversion): Only enum to enum value
9174 conversion is allowed.
9176 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9178 * ecore.cs (Expression.MemberLookup): Don't register any symbol for
9179 error reporting when no error occurs.
9181 2006-10-06 Marek Safar <marek.safar@seznam.cz>
9183 * cfold.cs (ConstantFold.BinaryFold): Report an error when the conversion
9186 2006-10-06 Raja R Harinath <rharinath@novell.com>
9189 * class.cs (DefineTypeBuilder): Check circular dependencies before
9190 setting the parent of the TypeBuilder.
9191 (CheckRecursiveDefinition): Don't use 'BaseType', since
9192 it may not be valid until after DefineTypeBuilder. Use
9193 'base_type' instead.
9195 2006-10-04 Martin Baulig <martin@ximian.com>
9197 Merged the Anonymous Methods patch.
9199 * anonymous.cs, iterators.cs: The new anonymous methods code.
9201 * statement.cs (Variable): New public abstract class.
9202 (LocalInfo.Variable): New public property.
9203 (LocalInfo.ResolveVariable): New public method.
9204 (Block.Flags): Add `IsIterator'.
9205 (Block.AddVariable): Improved the CS0136 check.
9206 (Block.AnonymousChildren): New public property.
9207 (Block.AddAnonymousChild): New public method.
9208 (ToplevelBlock): Update to use the new anonymous method framework.
9209 (ToplevelBlock.ctor): `container' is now a `Block' and not a
9210 `ToplevelBlock'; this is required to correctly implement the
9212 (Fixed, Using): Use `TemporaryVariable' instead of directly
9213 creating the `LocalBuilder'.
9215 * parameter.cs (Parameter.ResolveVariable): New public method.
9216 (Parameters.ResolveVariable): Likewise.
9218 * ecore.cs (TemporaryVariable): Use the new `Variable' framework.
9220 * class.cs (TypeContainer): Replaced the `iterators' list and
9221 corresponding methods with a list of `CompilerGeneratedClass'es.
9222 (TypeContainer.ResolveMembers): New public method.
9223 (Method): `IIteratorContainer' has been replaced by
9226 * expression.cs (VariableReference): New public abstract base
9227 class for `LocalVariableReference', `ParameterReference' and
9230 * codegen.cs (EmitContext): Removed `capture_context',
9231 `HaveCaptureInfo', `EmitScopeInitFromBlock()' and `Capture*()'.
9232 (EmitContext.EmitThis): Removed.
9234 * cs-parser.jay: Replace `iterator_container' with
9237 2006-10-04 Martin Baulig <martin@ximian.com>
9239 * generic.cs (GenericMethod): Don't make this abstract.
9240 (Constraints.Clone): Added dummy implementation.
9242 2006-10-04 Raja R Harinath <harinath@gmail.com>
9245 * namespace.cs (LookForAnyGenericType): Avoid nullref on
9246 'declspaces'. Avoid allocating arrays willy-nilly.
9249 * cfold.cs (BinaryFold): Move boolean Equality and Inequality
9250 cases out of the switch.
9252 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9254 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Better error
9255 message when non-generic type is used with the type arguments.
9256 * expression.cs: Updated.
9258 2006-09-28 Raja R Harinath <rharinath@novell.com>
9261 * convert.cs (Convert.ImplicitStandardConversionExists): Avoid infloop.
9262 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
9263 Change semantics slightly. Don't insist on having only one
9264 temporary EmptyExpression -- just throttle the creation of new ones.
9267 * ecore.cs (Expression.MemberLookup): Enable CS0229 errors for
9268 non-interfaces too. If no methods are found, don't try to create
9271 2006-09-28 Marek Safar <marek.safar@seznam.cz>
9273 * ecore.cs (ResolveAsTypeStep): Print better error when type can be
9276 * namespace.cs (Namespace.LookForAnyGenericType): New method to help
9277 us produce better error message.
9279 2006-09-27 Marek Safar <marek.safar@seznam.cz>
9281 * expression.cs (Binary.ResolveOperator): Warn about a side effect
9282 of the `|' operator.
9284 * report.cs: A new warning added.
9286 2006-09-27 Martin Baulig <martin@ximian.com>
9288 * generic.cs (GenericMethod): Don't make this abstract.
9290 2006-09-27 Martin Baulig <martin@ximian.com>
9293 (InternalErrorException): Added overloaded ctor taking a params array.
9295 2006-09-26 Marek Safar <marek.safar@seznam.cz>
9297 * class.cs, codegen.cs, const.cs, cs-tokenizer.cs, driver.cs, ecore.cs:
9298 Fixed the cases when same error was reported twice.
9300 * report.cs (SymbolRelatedToPreviousError): Simplified as all our messages
9301 now report symbol information.
9303 2006-09-25 Martin Baulig <martin@ximian.com>
9305 * class.cs: Completely unified with the gmcs version.
9307 2006-09-25 Martin Baulig <martin@ximian.com>
9309 * typemanager.cs (TypeManager.IsNullableType): New public function.
9310 (TypeManager.IsNullableTypeOf): Likewise.
9311 (TypeManager.IsNullableValueType): Likewise.
9313 * class.cs (MethodCore): Added the `GenericMethod' argument from
9314 gmcs and also unified all classes derived from `MethodCore' with gmcs.
9316 2006-09-24 Raja R Harinath <harinath@gmail.com>
9318 * convert.cs: Unify with gmcs version.
9320 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9322 * decl.cs (DeclSpace.VerifyClsCompliance): When type has type parameters
9323 verify them as well.
9325 * report.cs: New warning.
9327 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9329 * anonymous.cs (AnonymousMethod.Compatible): Cannot generate arguments
9330 for anonymous block with out argument.
9332 2006-09-24 Marek Safar <marek.safar@seznam.cz>
9334 * class.cs (ClassOrStruct.VerifyMembers): Fixed to report correctly
9335 not used private events only.
9337 2006-09-23 Marek Safar <marek.safar@seznam.cz>
9339 * cfold.cs (BinaryFold): On the guest to unify empty constant cast.
9341 * const.cs (Const.Define): Check for constant type.
9342 (Const.IsConstantTypeValid): Looks for valid constant types.
9344 * convert.cs (ImplicitReferenceConversion): NullCast to EmptyConstantCast.
9346 * ecore.cs (EmptyConstantCast): New common class for all constant based
9349 * expression.cs (Is.DoResolve): Handle null constant especially.
9350 (New.DoResolve): Check for new void().
9351 (MemberAccess.DoResolve): Cope with all kind of nulls.
9353 * literal.cs (NullConstant): Uses EmptyConstantCast.
9354 (NullDefault): Based on EmptyConstantCast.
9355 (NullLiteral): Uses EmptyConstantCast.
9357 * statement.cs (Block.ResolveMeta): Check for constant type.
9359 2006-09-22 Martin Baulig <martin@ximian.com>
9361 * delegate.cs, attribute.cs: Merged with the gmcs versions.
9363 2006-09-22 Raja R Harinath <rharinath@novell.com>
9365 * literal.cs (NullDefault): The type of default(IFoo) is 'IFoo',
9369 * typemanager.cs (Closure.Filter): Consider PrivateScope attributes.
9370 * decl.cs (DeclSpace.FindMemberToOverride): Likewise. Reorganize
9373 2006-09-22 Martin Baulig <martin@ximian.com>
9375 * ecore.cs: Merged with the gmcs version.
9377 * generic.cs (ConstructedType): New dummy class.
9378 (TypeArguments): Don't make this abstract.
9381 (TypeManager.IsGenericTypeDefinition): New method.
9382 (TypeManager.GetGenericFieldDefinition): Moved here from gmcs.
9384 2006-09-22 Raja R Harinath <rharinath@novell.com>
9386 * expression.cs (ComposedCast): Check for arrays of TypedReference
9387 before creating the type, not after.
9389 2006-09-21 Marek Safar <marek.safar@seznam.cz>
9391 * cfold.cs, const.cs, enum.cs, statement.cs: Updated
9392 after ToType change.
9394 * constant.cs (Constant.ImplicitConversionRequired): Designed to used
9395 when constant must be implicitly convertible.
9397 * convert.cs (ImplicitReferenceConversion): Reuse ToType.
9399 * ecore.cs (NullCast): Derives from NullConstant.
9401 * expression.cs (Is.DoResolve): Removed useless variables.
9402 (Conditional.DoResolve): Quick hack for `Foo () ? null : null'.
9403 (New.Constantify): Add enum support.
9404 (MemberAccess.DoResolve): Add warning when accessing null constant or
9407 * generic.cs (GenericConstraints.IsReferenceType): Another dummy
9410 * literal.cs (NullConstant): New abstract class with common
9411 functionality for all null specializations.
9412 (NullDefault): Represents default(X) when result can be
9414 (NullLiteral): Updated.
9416 * report.cs: Add new warning.
9418 2006-09-21 Martin Baulig <martin@ximian.com>
9420 * generic.cs (GenericTypeParameterBuilder): Removed this ugly hack.
9422 2006-09-21 Martin Baulig <martin@ximian.com>
9424 * generic.cs (GenericConstraints): New dummy class.
9425 (Constraints): Likewise.
9426 (TypeParameter): Likewise.
9427 (TypeParameterName): Likewise.
9428 (GenericMethod): Likewise.
9430 * typemanager.cs (TypeManager.GetGenericArguments): New method.
9432 * decl.cs: Merged with the gmcs version.
9434 2006-09-21 Raja R Harinath <rharinath@novell.com>
9436 * generic.cs (TypeParameter): Implement IMemberContainer.
9437 (GenericTypeParameterBuilder): New. An abominable repugnant hack.
9439 * rootcontext.cs: Unify with gmcs version.
9441 * report.cs: Unify with gmcs version.
9442 * typemanager.cs (AddTypeParameter, LookupTypeParameter): Move
9443 from gmcs/generics.cs.
9444 * generics.cs (TypeParameter): New dummy class.
9446 * support.cs: Unify with gmcs version.
9448 2006-09-20 Raja R Harinath <rharinath@novell.com>
9450 * ecore.cs (MethodGroupExpr.ResolveGeneric): New dummy method.
9451 * expression.cs (MemberAccess, BaseAccess): Remove GMCS_SOURCE #ifdef.
9453 * decl.cs (MemberName): Unify with gmcs, except for GetTypeExpression.
9454 * generic.cs (TypeArguments): New dummy class to help avoid #ifdefs.
9455 * mcs.exe.sources: Add generic.cs.
9457 * codegen.cs: Unify with gmcs version.
9459 * codegen.cs (IResolveContent.GenericDeclContainer): Copy from gmcs.
9460 (EmitContext): Add GenericDeclContainer implementation.
9461 * decl.cs (MemberCore, DeclSpace): Likewise.
9462 * namespace.cs: Remove #ifdef GMCS_SOURCE.
9464 * namespace.cs (GetTypeInAssembly): Remove #ifdef GMCS_SOURCE.
9465 MCS TypeManager has a corresponding dummy method.
9467 2006-09-19 Martin Baulig <martin@ximian.com>
9469 * expression.cs: Completely merged with the gmcs version.
9471 2006-09-19 Martin Baulig <martin@ximian.com>
9473 * expression.cs (Invocation): Merged with the gmcs version.
9474 (ArrayAccess.GetStoreOpcode): Likewise.
9476 2006-09-19 Martin Baulig <martin@ximian.com>
9479 (TypeManager.IsGenericMethod): Moved here from ../gmcs/generic.cs.
9480 (TypeManager.IsGenericMethodDefinition): Likewise.
9482 2006-09-19 Martin Baulig <martin@ximian.com>
9485 (TypeManager.IsEqual): Moved the gmcs implementation here.
9486 (TypeManager.DropGenericTypeArguments): Likewise.
9487 (TypeManager.DropGenericMethodArguments): Likewise.
9488 (TypeManager.GetTypeArguments): Moved here from gmcs.
9489 (TypeManager.HasGenericArguments): Likewise.
9491 2006-09-19 Martin Baulig <martin@ximian.com>
9493 * expression.cs (Binary): Merged with the gmcs version.
9495 2006-09-19 Martin Baulig <martin@ximian.com>
9497 * expression.cs (Probe, As, Is): Merged with the gmcs version.
9499 2006-09-19 Martin Baulig <martin@ximian.com>
9501 * typemanager.cs: Merged with the gmcs version.
9503 2006-09-16 Raja R Harinath <rharinath@novell.com>
9505 * AssemblyInfo.cs [GMCS_SOURCE]: Unify with gmcs source.
9506 * driver.cs: Likewise.
9508 2006-09-16 Marek Safar <marek.safar@seznam.cz>
9511 * class.cs (MethodCore.VerifyClsCompliance): Do check for abstract members
9512 only if parent type is class.
9513 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Fixed missing cache
9516 2006-09-15 Marek Safar <marek.safar@seznam.cz>
9519 * expression.cs(MemberAccess.DoResolve): Don't crash when not allowed
9521 * typemanager.cs(CSharpName): Converts NullType to null.
9523 2006-09-15 Martin Baulig <martin@ximian.com>
9526 (TypeManager.GetMethodName): Added mcs implementation.
9527 (TypeManager.IsEqual): Likewise.
9530 (SimpleName.RemoveGenericArity): Added dummy implementation.
9532 * pending.cs: Merged with the gmcs version.
9534 2006-09-15 Martin Baulig <martin@ximian.com>
9536 * statement.cs: Merge with the gmcs version.
9538 2006-09-15 Martin Baulig <martin@ximian.com>
9540 * statement.cs (Switch): Merge with the gmcs implementation
9541 (without nullables), which is newer.
9543 2006-09-15 Martin Baulig <martin@ximian.com>
9545 * statement.cs (Block.Variables): Make this public.
9546 (ToplevelBlock.Parameters): Make this a property.
9547 (Throw.Resolve): Use `TypeManager.IsSubclassOf ()'.
9549 2006-09-15 Martin Baulig <martin@ximian.com>
9551 * namespace.cs: Merge with the gmcs version.
9553 2006-09-15 Martin Baulig <martin@ximian.com>
9555 * decl.cs (MemberName): Minor code cleanups.
9557 2006-09-15 Martin Baulig <martin@ximian.com>
9559 * parameter.cs: Merge with the gmcs version.
9561 2006-09-15 Martin Baulig <martin@ximian.com>
9563 * enum.cs: Merge with the gmcs version: 3005 is a warning in gmcs
9564 and an error in mcs.
9566 2006-09-15 Martin Baulig <martin@ximian.com>
9568 * flowanalysis.cs: Merged from GMCS; added the generics code into
9569 a `GMCS_SOURCE' conditional so we can share this file.
9571 2006-09-08 Martin Baulig <martin@ximian.com>
9573 * typemanager.cs (TypeManager.interlocked_type): New public field.
9574 (TypeManager.int_interlocked_compare-exchange): New public field.
9575 (TypeManager.InitEnumUnderlyingTypes): Also initialize the
9576 enumerator types here and call InitGenericCoreTypes().
9577 (TypeManager.InitCoreTypes): Call InitEnumeratorTypes() right
9578 after calling InitEnumUnderlyingTypes().
9581 (RootContext.ResolveCore): Added `System.Threading.Interlocked' to
9582 `classes_second_stage'.
9584 2006-09-14 Marek Safar <marek.safar@seznam.cz>
9586 * assign.cs, ecore.cs, expression.cs: Share error message text.
9587 * class.cs (FieldMember.Define): Check for varible of static type.
9588 * driver.cs (LoadAssembly): Uses error output for errors.
9589 * statement.cs: Updated.
9591 2006-09-08 Marek Safar <marek.safar@seznam.cz>
9593 * expression.cs (Error_OperatorCannotBeApplied): Report type instead of
9596 2006-09-07 Martin Baulig <martin@ximian.com>
9599 (MainDriver): Revert r62663 from Marek; see #70506 for details.
9601 2006-08-29 Miguel de Icaza <miguel@novell.com>
9603 * cs-parser.jay: Turn 1522 into a warning, instead of an error #79210
9605 2006-08-17 Miguel de Icaza <miguel@novell.com>
9607 * cs-tokenizer.cs: Apply patch from Atsushi Enomoto that fixes
9608 #52019 and #79064, the use of the \uXXXX sequence in source code
9609 to represent unicode characters.
9611 2006-08-15 Marek Safar <marek.safar@seznam.cz>
9613 * expression.cs (SizeOf.DoResolve): Check for void type. Fixed enum types
9615 * class.cs, ecore.cs, statement.cs: Merged to one error message.
9617 2006-08-13 Miguel de Icaza <miguel@novell.com>
9619 * assign.cs: Catch attempts to assign to a method groups in += and
9622 2006-08-13 Marek Safar <marek.safar@seznam.cz>
9625 * cs-parser.jay: Don't destroy current array type by typeof of array's.
9627 2006-08-12 Marek Safar <marek.safar@seznam.cz>
9629 * class.cs (Method.Define): Issue a warning when generic method looks like
9631 * decl.cs (MemberCore.GetSignatureForError): Print member type arguments
9634 2006-08-09 Marek Safar <marek.safar@seznam.cz>
9636 * anonymous.cs(AnonymousDelegate.Emit): Uses Constructor filter when
9638 * decl.cs (MemberCache.FindMembers): When container is interface we need to
9639 search all base interfaces as a member can be ambiguous.
9640 * delegate.cs (Delegate.FindMembers): Fixed to return valid data for
9641 Constructor member type filter.
9642 (Delegate.ResolveConstructorMethod) Uses Constructor filter.
9643 * ecore.cs: (Expression.MemberLookup): Implemented ambiguity error/warning
9644 reporting for returned memberinfos.
9645 * report.cs: Updated.
9646 * typemanager.cs (TypeManager.LookupBaseInterfacesCache): Uses TypeManager
9647 version to work on all runtimes.
9648 (TypeManager.RealMemberLookup): Removed members filtering.
9650 2006-08-08 Raja R Harinath <rharinath@novell.com>
9652 * ecore.cs (FieldExpr.EmitAssign): Release temporary.
9653 (PropertyExpr.EmitAssign): Likewise.
9654 * expression.cs (Indirection.EmitAssign): Likewise.
9655 (LocalVariableReference.EmitAssign): Likewise.
9656 (ParameterReference.EmitAssign): Likewise.
9657 (Invocation.EmitArguments): Likewise.
9658 (ArrayAccess.EmitAssign): Likewise.
9659 (IndexerAccess.EmitAssign): Likewise.
9660 (This.EmitAssign): Likewise.
9661 (ConditionalLogicalOperator.Emit): Likewise.
9664 * codegen.cs (EmitContext.GetTemporaryLocal): Simplify. Use Stack
9665 instead of ArrayList. If the hashtable has a LocalBuilder, don't
9666 leave it in after returning it.
9667 (EmitContext.FreeTemporaryLocal): Simplify. Update to changes.
9669 2006-08-06 Marek Safar <marek.safar@seznam.cz>
9671 * expresssion.cs (IndexerAccess.DoResolve): Fixed to report correct error
9674 2006-08-03 Raja R Harinath <rharinath@novell.com>
9676 Fix cs0146-3.cs and cs0146-4.cs.
9677 * class.cs (TypeManager.CheckRecursiveDefinition): Check that
9678 enclosing types don't depend on the current type.
9680 2006-08-02 Raja R Harinath <rharinath@novell.com>
9683 * class.cs (TypeContainer.DoDefineMembers): Use
9684 FindBaseMemberWithSameName on Parent, since we're interested in
9685 whether we hide inherited members or not.
9686 (FindBaseMemberWithSameName): Make slightly more robust.
9688 Fix the non-generic testcase from #77396
9689 * decl.cs (DeclSpace.DeclContainer): Remove override.
9691 * namespace.cs (NamespaceEntry.Doppelganger): Create slave
9692 declspaces for doppelgangers too.
9693 (UsingEntry): Implement IResolveContext.
9694 (UsingEntry.Resolve): Don't set ToplevelTypes.Namespace. Use
9695 'this' as the resolve context.
9696 (LocalAliasEntry): Likewise.
9698 Implement parts of #77403
9699 * roottypes.cs (RootDeclSpace): New. Used to represent the
9700 toplevel declaration space. Each namespace declaration introduces
9701 a "partial" root declaretion space.
9702 * namespace.cs (NamespaceEntry.SlaveDeclSpace): New.
9703 (NamespaceEntry.ctor): Create a SlaveDeclSpace if necessary.
9704 * cs-parser.jay (CSharpParser.ctor): Initialize 'current_class'
9705 from 'current_namespace.SlaveDeclSpace'.
9706 (namespace_declaration): Likewise.
9707 * class.cs (TypeContainer.ctor): Remove parent==ToplevelTypes
9708 check. It can't happen now.
9709 * decl.cs (DeclSpace.LookupType): Likewise.
9710 * driver.cs (MainDriver): Sanity check.
9712 2006-08-01 Raja R Harinath <rharinath@novell.com>
9714 * decl.cs (DeclSpace.FindNestedType): Remove.
9715 (DeclSpace.LookupNestedTypeINHierarchy): Use PartialContainer and
9716 LookupTypeContainer to get the container of the nested type.
9717 * class.cs (TypeContainer.FindNestedType): Make non-override.
9719 2006-07-31 Raja R Harinath <rharinath@novell.com>
9721 * decl.cs (DeclSpace.PartialContainer): Move field from ...
9722 * class.cs (TypeContainer.PartialContainer): ... here.
9723 (TypeContainer.AddBasesForPart): New helper.
9724 (MemberBase.ParentContainer): Remove. Use Parent.PartialContainer
9726 * cs-parser.jay (current_class): Convert to DeclSpace.
9727 (struct_declaration, interface_declaration, class_declaration):
9728 Use AddBasesForPart instead of .Bases directly.
9729 * const.cs, iterators.cs: Update to changes.
9731 2006-07-28 Raja R Harinath <rharinath@novell.com>
9733 * class.cs (TypeContainer.AddMemberType): Rename from
9735 (TypeContainer.AddMember): Rename from AddToMemberContainer.
9736 (AddTypeContainer): New. Combine AddClassOrStruct and
9738 (AddPartial): Update. Add 'is_partial' argument.
9739 * roottypes.cs: Update to changes.
9740 * cs-parser.jay (push_current_class): New helper for handling
9741 current_container and current_class.
9742 (struct_declaration, interface_declaration, class_declaration):
9745 2006-07-26 Raja R Harinath <rharinath@novell.com>
9747 * roottypes.cs: Rename from tree.cs.
9749 Rename RootContext.Tree.Types to RootContext.ToplevelTypes.
9750 * tree.cs (Tree, ITreeDump): Remove types.
9751 * rootcontext.cs (tree, Tree): Remove fields.
9752 (root, ToplevelTypes): New.
9753 * *.cs: Update to rename.
9755 * tree.cs (Tree.RecordDecl): Remove.
9756 (RootTypes.AddToTypeContainer): Record the toplevel type in its
9758 * class.cs, cs-parser.jay: Remove mention of RecordDecl.
9760 2006-07-23 Raja R Harinath <harinath@gmail.com>
9762 * codegen.cs (EmitContext.Flags): Move InCatch, InFinally,
9763 DoFlowAnalysis and OmitStructFlowAnalysis here.
9764 (ec.With): Rename from WithUnsafe and generalize.
9765 (ec.WithCheckState): Remove. All users can be handled by 'With'.
9766 (ec.WithFlowAnalyis): New.
9767 * ecore.cs, expression.cs, statement.cs: Update.
9769 2006-07-22 Raja R Harinath <harinath@gmail.com>
9771 * statement.cs (Block.ResolveMeta): Simplify slightly.
9773 * codegen.cs (EmitContext.Flags): New enum. Used to represent the
9774 multiple boolean fields. Convert InUnsafe, constant_check_state,
9775 check_state to flags.
9776 (CheckState, ConstantCheckState): Update.
9777 (InUnsafe): New read-only property.
9778 (FlagsHandle): Rename from CheckStateHandle and convert to handle
9780 (WithUnsafe): New helper similar to WithCheckState.
9781 * statement.cs (Block.ResolveMeta): Use WithUnsafe.
9782 (Unsafe.Resolve, Unsafe.DoEmit): Likewise.
9784 2006-07-21 Raja R Harinath <rharinath@novell.com>
9786 Make comparisons use the same IL irrespective of whether they're
9787 in a 'checked' or 'unchecked' context: one of the issues in #78899
9788 * codegen.cs (EmitContext.CheckState): Make read-only property.
9789 (EmitContext.ConstantCheckState): Likewise.
9790 (EmitContext.CheckStateHandle, EmitContext.WithCheckState): New
9791 helper that implement a save/restore stack for CheckState
9792 values. This is the only way to change check-state.
9793 * ecore.cs (Expression.ExpressionToArrayArgument): Use WithCheckState.
9794 * expression.cs (CheckedExpr.DoResolve, CheckedExpr.Emit): Likewise.
9795 (CheckedExpr.EmitBranchable): New forwarding method.
9796 (UnCheckedExpr): Likewise.
9797 * statement.cs (Block.ResolveMeta): Use WithCheckState.
9798 (Unchecked.Resolve, Unchecked.DoEmit): Likewise.
9799 (Checked.Resolve, checked.DoEmit): Likewise.
9801 2006-07-20 Miguel de Icaza <miguel@novell.com>
9803 * anonymous.cs: Cache the resolved anonymous delegate, and return
9804 this so that the ResolveTopBlock is only triggered once, not
9807 Currently we trigger ResolvetopBlock twice due to a first pass of
9808 argument check compatibility, and a second pass that does the
9811 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9813 * annonymous.cs (AnonymousMethod.CreateScopeType): Fixed nested type
9815 * rootcontext.cs (Reset): Add helper_classes.
9817 2006-07-15 Marek Safar <marek.safar@seznam.cz>
9820 * statement.cs (Switch.SimpleSwitchEmit): Handle case null at any position
9823 2006-07-13 Miguel de Icaza <miguel@novell.com>
9825 * statement.cs (Lock): Handle expressions of type
9826 TypeManager.null_type specially. Fixes #78770
9828 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9830 * expression.cs (Binary.ResolveOperator): Don't crash when null is assigned
9833 2006-07-08 Marek Safar <marek.safar@seznam.cz>
9835 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Fixed to look
9836 for accessors as well.
9837 * ecore.cs (EventExpr): Add AccessorTable.
9839 2006-07-01 Marek Safar <marek.safar@seznam.cz>
9842 * attribute.cs, class.cs, ecore.cs : Add missing location of related symbol
9843 for CS0122 where appropriate.
9844 * typemanager.cs (IsNestedChildOf): Type can be null in the case of top
9846 (Filter): Assembly can be null in the case of top level attributes.
9848 2006-06-25 Marek Safar <marek.safar@seznam.cz>
9852 * ecore.cs (Expression.MemberLookupFailed): Don't crash when failed lookup
9853 is done at global level.
9855 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9857 A fix for #77002, Implemented TypeForwarder support.
9859 * attribute.cs (Attribute.GetArgumentType): Reads type argument.
9860 * expression.cs (TypeOf.TypeArgument): Exposes typeof type.
9861 * typemanager.cs (): Add type_forwarder_attr_type.
9863 2006-06-24 Marek Safar <marek.safar@seznam.cz>
9865 * report.cs: Add CS0469 warning.
9867 2006-06-21 Martin Baulig <martin@ximian.com>
9869 * codegen.cs (CodeGen.Save): Moved the symbol file generation into
9870 the `try'-block, so we also report CS0016 etc. there.
9872 2006-06-21 Martin Baulig <martin@ximian.com>
9875 (Delegate.VerifyMethod): Allow `params' methods; fixes #78678.
9877 2006-06-21 Martin Baulig <martin@ximian.com>
9879 * expression.cs (Unary.ResolveOperator): In `Operator.AddressOf',
9880 also report CS1686 for parameters.
9882 2006-06-21 Martin Baulig <martin@ximian.com>
9884 * statement.cs (GotoCase.Resolve): Report a warning (CS0469)
9885 instead of an error if the value is not implicitly convertible to
9886 the switch types; fixes #77964.
9888 2006-06-21 Raja R Harinath <rharinath@novell.com>
9891 * class.cs (FieldBase.ResolveInitializer): Stop resolution if
9892 FieldBuilder is null.
9895 * expression.cs (Binary.CheckShiftArguments): Don't overwrite original
9896 'left' and 'right' before error-checking.
9898 2006-06-16 Juraj Skripsky <js@hotfeet.ch>
9900 * ecore.cs (SimpleName.Error_ObjectRefRequired): Do not truncate the name.
9902 (MemberExpr.EmitInstance): Use GetSignatureForError () to get full name.
9903 (FieldExpr.DoResolve): likewise.
9904 (PropertyExpr.InstanceResolve): likewise.
9905 (EventExpr.InstanceResolve): likewise.
9907 2006-06-04 Marek Safar <marek.safar@seznam.cz>
9909 * parameter.cs (Parameter.ApplyAttributeBuilder): More DefaultValue
9910 attribute applicable tests for attribute argument.
9912 2006-06-02 Raja R Harinath <rharinath@novell.com>
9915 * expression.cs (Binary.DoNumericPromotions): Remove and rewrite.
9916 (Binary.OverloadResolve_PredefinedIntegral): New.
9917 (Binary.OverloadResolve_PredefinedFloating): New.
9918 (Binary.OverloadResolve_PredefinedString): New.
9919 (Binary.ResolveOperator): Use those instead of DoNumericPromotions.
9920 Follow the standard more closely, and treat numeric promotions in
9921 terms of overload resolution.
9922 (Binary.CheckShiftArguments): Simplify.
9924 2006-06-01 Raja R Harinath <rharinath@novell.com>
9926 * flowanalysis.cs (MyBitVector): Simplify representation.
9927 (MyBitVector.Clone): Avoid allocating BitArray.
9928 (MyBitVector.operator&): Rename from MyBitVector.And and make symmetric.
9929 (MyBitVector.operator|): Likewise, with MyBitVector.Or.
9930 (*): Update. Change all references to MyBitVector.And and
9931 MyBitVector.Or to &= and |=.
9933 2006-05-29 Raja R Harinath <rharinath@novell.com>
9936 * cs-parser.jay (formal_parameter_list): Extend the pattern below
9937 to param arguments too.
9939 2006-05-26 Miguel de Icaza <miguel@novell.com>
9941 * cs-parser.jay: Catch another parsing form for arglist being
9942 followed by other arguments. Fixes #78313.
9944 2006-05-24 Raja R Harinath <rharinath@novell.com>
9946 * flowanalysis.cs (FlowBranchingToplevel.AddReturnOrigin): Move
9947 checking of out parameters to ...
9948 (FlowBranchingToplevel.Merge): ... here.
9949 (FlowBranchingException.AddBreakOrigin): If 'finally_vector' is
9950 set, propagate the origin upward, and only complain if there was
9952 (FlowBranchingException.AddContinueOrigin): Likewise.
9953 (FlowBranchingException.AddReturnOrigin): Likewise.
9954 (FlowBranchingException.AddGotoOrigin): Likewise.
9956 2006-05-23 Raja R Harinath <rharinath@novell.com>
9958 * flowanalysis.cs (UsageVector.MergeOrigins): If an origin is
9959 unreachable, skip it.
9960 (FlowBranchingException.Merge): Always propagate jumps, even if
9961 the finally block renders subsequent code unreachable.
9963 2006-05-18 Raja R Harinath <rharinath@novell.com>
9966 * statement.cs (Goto.Resolve): Move responsibility for resolving
9967 'goto' to FlowBranching.AddGotoOrigin.
9968 (Goto.SetResolvedTarget): New. Callback to set the
9969 LabeledStatement that's the target of the goto.
9970 (Goto.DoEmit): Use Leave instead of Br when crossing an
9971 unwind-protect boundary.
9972 * flowanalysis.cs (FlowBranching.AddGotoOrigin): Rename from
9973 LookupLabel and adjust to new semantics.
9974 (FlowBranchingToplevel.AddGotoOrigin): Likewise.
9975 (FlowBranchingBlock.AddGotoOrigin): Likewise. Use
9976 Goto.SetResolvedTarget to update target.
9977 (FlowBranchingLabeled.AddGotoOrigin): Likewise.
9978 (FlowBranchingException.AddGotoOrigin): Rewrite to be similar to
9979 AddBreakOrigin & co. Delay propagation until ...
9980 (FlowBranchingException.Merge): ... this.
9982 * statement.cs (Block.Resolve): Always depend on flow-branching to
9983 determine unreachability. Kill workaround that originally emitted
9984 only one statement after an "unreachable" label (see infloop in
9987 Fix #77869, #76148, #77755, #75255 and a host of other bugs.
9988 This is still "wrong", but anything better would probably need a
9989 multi-pass algorithm.
9990 * flowanalysis.cs (FlowBranchingLabeled): Salt away a copy of the
9991 usage vector. Force current usage vector to be reachable, to
9992 optimistically signify backward jumps.
9993 (FlowBranchingLabeled.LookupLabel): Note if a backward jump is
9995 (FlowBranchingLabeled.Merge): New. If no backward jump was
9996 detected, return the original salted-away usage vector instead,
9997 updated with appropriate changes. Print unreachable warning if
9999 * statement.cs (Block.Resolve): Don't print unreachable warning on
10000 a labeled statement.
10002 2006-05-17 Gert Driesen <drieseng@users.sourceforge.net>
10004 * driver.cs: Pass filename without path to AssemblyBuilder's
10005 AddResourceFile. Fixes bug #78407.
10007 2006-05-17 Raja R Harinath <rharinath@novell.com>
10009 * statement.cs (LabeledStatement.Resolve): Move merging of origins ...
10010 * flowanalysis.cs (FlowBranchingLabeled): ... here.
10011 (FlowBranching.MergeChild): Overwrite
10012 reachability information from Labeled branchings too.
10014 2006-05-16 Raja R Harinath <rharinath@novell.com>
10016 * statement.cs (Goto.Resolve): Merge jump origins here ...
10017 * flowanalysis.cs (FlowBranching.Label): ... rather than here.
10019 * flowanalysis.cs (FlowBranching.LookupLabel): Move CS0159 check ...
10020 (FlowBranchingToplevel.LookupLabel): ... here. Add CS1632 check.
10021 (FlowBranchingGoto.LookupLabel): New. Handle back jumps.
10022 (FlowBranchingBlock.LookupLabel): Call LabeledStatement.AddReference
10024 * statement.cs (Goto.Resolve): ... not here.
10025 (Goto.Emit): Remove CS1632 check.
10027 2006-05-14 Marek Safar <marek.safar@seznam.cz>
10029 * ecore.cs (Expression.ResolveAsTypeTerminal): Fixed type in the obsolete
10032 2006-05-11 Raja R Harinath <rharinath@novell.com>
10034 * flowanalysis.cs (UsageVector.MergeJumpOrigins): Kill.
10035 (FlowBranchingBlock.Label): Use UsageVector.MergeOrigins.
10036 (FlowBranchingException.Label): Likewise.
10038 * flowanalysis.cs (MyBitVector.SetAll): New. Sets all bits to the
10040 (MyBitVector.Or): Use it to avoid losing information (Count).
10041 (FlowBranching.MergeOrigins): Likewise.
10043 * flowanalysis.cs (UsageVector.IsDirty): Remove.
10044 (UsageVector.Parameters, UsageVector.ParameterVector): Likewise.
10045 (UsageVector.Locals, UsageVector.LocalVector): Likewise.
10046 (UsageVector.ToString): Simplify.
10047 (UsageVector.MergeSiblings): Move here from ...
10048 (FlowBranching.Merge): ... here.
10049 (FlowBranchingToplevel.CheckOutParameters): Take an UsageVector,
10052 2006-05-10 Raja R Harinath <rharinath@novell.com>
10054 * flowanalysis.cs (UsageVector.MergeOrigins): Simplify, now that a
10055 null bitvector is treated as all-true.
10057 * flowanalysis.cs (MyBitVector.And, MyBitVector.Or): Make lazier.
10058 (MyBitVector): Rationalize invariants. 'vector != null' implies
10059 that we have our own copy of the bitvector. Otherwise,
10060 'InheritsFrom == null' implies all inherited bits are true.
10062 2006-05-09 Marek Safar <marek.safar@seznam.cz>
10064 * statement.cs (LocalInfo): Add IsConstant.
10065 (LocalInfo.DeclareLocal): Moved from EmitMeta and changed to don't emit
10066 local variable for constants.
10068 2006-05-09 Raja R Harinath <rharinath@novell.com>
10070 * flowanalysis.cs (MyBitVector.Empty): New.
10071 (MyBitVector): Don't allow InheritedFrom to be null.
10072 (MyBitVector.And, MyBitVector.Or): Treat 'null' as all-ones.
10073 (UsageVector, FlowBranching): Update to changes.
10075 * flowanalysis.cs (FlowBranching.InTryWithCatch): Don't terminate
10076 recursion. The 'Parent == null' condition isn't sufficient for
10078 (FlowBranching.AddBreakOrigin): Likewise.
10079 (FlowBranching.AddContinueOrigin): Likewise.
10080 (FlowBranching.AddReturnOrigin): Likewise.
10081 (FlowBranching.StealFinallyClauses): Likewise.
10082 (FlowBranching.MergeTopBlock): Move to FlowBranchingToplevel.
10083 (FlowBranching.CheckOutParameters): Likewise.
10084 (FlowBranchingToplevel): Terminate all the above recursions here.
10085 (FlowBranchingToplevel.End): Rename from MergeTopBlock.
10086 * codegen.cs (EmitContext.ResolveTopBlock): Update to changes.
10088 * flowanalysis.cs (BranchingType.Toplevel): New. Represents a
10090 (FlowBranchingToplevel): New. Empty for now.
10091 (FlowBranching.MergeTopBlock): Update.
10092 * codegen.cs (EmitContext.ResolveTopBlock): Create a Toplevel
10093 branching for the anonymous delegate.
10094 (EmitContext.StartFlowBranching): Add ToplevelBlock variant.
10096 * flowanalysis.cs (UsageVector.MergeOrigins): Reorganize.
10097 (UsageVector.MergeJumpOrigins): Don't ignore current reachability
10098 information at the start of the merge. Reorganize.
10100 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10102 * class.cs (MethodData.Define): Method cannot implement interface accessor.
10104 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10106 * expression.cs (QualifiedAliasMember.ResolveAsTypeStep): Pass location
10107 to newly introduced ctor.
10109 * namespace.cs (Namespace.Error_NamespaceDoesNotExist): Moved an error
10110 message to one place.
10111 (GlobalRootNamespace.Error_NamespaceDoesNotExist): Custom message for
10114 2006-05-07 Marek Safar <marek.safar@seznam.cz>
10116 * const.cs (Const.Error_ExpressionMustBeConstant): Better error message.
10118 * ecore.cs (Expression.ResolveAsConstant): Updated.
10120 * statement.cs (ResolveMeta): Updated.
10122 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10124 * cs-parser.jay: __arglist cannot be used in initializer.
10126 2006-05-06 Marek Safar <marek.safar@seznam.cz>
10129 * namespace.cs (LocalAliasEntry.DoResolve): Don't allow to access nested
10132 2006-05-05 Raja R Harinath <rharinath@novell.com>
10134 * statement.cs (EmptyStatement.ResolveUnreachable): Override.
10135 (LabeledStatement): Add 'name' parameter.
10136 (LabeledStatement.Name, LabeledStatement.JumpOrigins): New.
10137 (Block.AddLabel): Update to changes.
10138 * cs-parser.jay (labeled_statement): Likewise.
10140 * flowanalysis.cs (BranchingType.Labeled): New.
10141 (UsageVector.MergeOrigins): Remove unused 'branching' argument.
10142 (FlowBranchingLabeled): New. Does nothing for now, but will
10143 eventually handle 'goto' flows.
10144 * codegen.cs (StartFlowBranching): Add new LabeledStatement variant.
10145 * statement.cs (LabeledStatement.Resolve): Create a FlowBranching
10146 that's terminated ...
10147 (Block.Resolve): ... here.
10149 * flowanalysis.cs (UsageVector.MergeFinally): Remove.
10150 (UsageVector.MergeFinallyOrigins): Likewise.
10151 (FlowBranching.InTryOrCatch): Likewise.
10152 (FlowBranching.AddFinallyVector): Likewise.
10153 (FlowBranchingException): Update to changes.
10156 * statement.cs (Return.Resolve): Move error checking to ...
10157 * flowbranching.cs (FlowBranching.AddReturnOrigin): ... this.
10158 (FlowBranchingException): Handle return origins like break and
10160 (FlowBranching.UsageVector.CheckOutParameters): Remove.
10162 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10165 * class.cs (TypeContainer.FindMembers): Includes event method in the methods
10168 2006-05-04 Marek Safar <marek.safar@seznam.cz>
10171 * class.cs (MethodData.Define): Do public accessor check only when method
10172 implements an interface.
10174 2006-05-04 Raja R Harinath <rharinath@novell.com>
10176 Remove special handling of 'break'
10177 * flowanalysis.cs (Reachability): Remove all mention of 'breaks'.
10178 (Reachability.Meet): Simplify. Remove 'do_breaks' argument.
10179 (UsageVector.Break): Remove.
10180 (FlowBranching.Merge): Use 'Reachable.IsUnreachable' to determine
10182 (FlowBranchingBreakable.Merge): Don't ResetBreaks.
10184 * statement.cs (Break.Resolve): Call UsageVector.Goto (), not
10185 UsageVector.Breaks (). Don't set NeedsReturnLabel.
10187 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10190 * pending.cs (PendingImplementation.BaseImplements): A found member cannot
10191 be the interface member.
10193 2006-05-03 Marek Safar <marek.safar@seznam.cz>
10196 * constant.cs (LongConstant.EmitLong): Fixed to catch also negative values
10197 for emitting small (int) values.
10199 2006-05-03 Raja R Harinath <rharinath@novell.com>
10202 * flowanalysis.cs (FlowBranchingException.Merge): Ensure
10203 control-flow passes through the 'finally' after merging-in all the
10204 control-flows from 'try' and the 'catch' clauses.
10206 * flowanalysis.cs (FlowBranching.IsLoop): Remove.
10207 (FlowBranching.IsTryOrCatch): Remove 'is_return' parameter. It's
10208 always true at the only non-recursive entry point.
10209 (FlowBranching.CreateBranching) [BranchingType.Loop]: Return a
10210 FlowBranchingBreakable.
10211 (FlowBranchingLoop): Remove.
10212 * statement.cs (Return.DoResolve): Update to changes.
10215 * flowanalysis.cs (FlowBranching.BranchingType.Embedded): New.
10216 (FlowBranching.CreateBranching): Handle it: create a
10217 FlowBranchingContinuable.
10218 (FlowBranching.BreakCrossesExceptionBoundary): Remove.
10219 (FlowBranching.AddContinueOrigin): Similar to AddBreakOrigin,
10220 except that it handles the 'continue' command.
10221 (FlowBranching.UsageVector.MergeOrigins): Rename from
10223 (FlowBranchingContinuable): Similar to FlowBranchingBreakable,
10224 except that it overrides AddContinueOrigin.
10225 (FlowBranchingException): Override AddContinueOrigin, similar to
10227 * statement.cs (While.Resolve, Foreach.ArrayForeach.Resolve):
10228 Create a new branching around the embedded statement.
10229 (Do.Resolve, For.Resolve): Likewise. Do reachability analysis for
10230 control flow after the embedded statement.
10231 (Continue.Resolve): Move all error checking to AddContinueOrigin.
10233 * flowanalysis.cs (FlowBranching.IsSwitch): Remove.
10234 (FlowBranching.CreateBranching) [BranchingType.Switch]: Create a
10235 FlowBranchingBreakable.
10236 (FlowBranchingSwitch): Remove.
10239 * statement.cs (Break.Resolve): Simplify. Move responsibility for
10240 error reporting to ...
10241 * flowanalysis.cs (FlowBranching.AddBreakOrigin) ... this.
10242 Rename from 'AddBreakVector'. Add new location argument. Return
10243 a bool indicating whether the 'break' crosses an unwind-protect.
10244 (FlowBranchingException.AddBreakOrigin): Add.
10245 (FlowBranchingException.Merge): Propagate 'break's to surrounding
10246 flowbranching after updating with the effects of the 'finally'
10248 (FlowBranchingBreakable): New common base class for
10249 FlowBranchingLoop and FlowBranchingSwitch.
10251 * statement.cs (Foreach.ArrayForeach.Resolve): Set barrier after
10252 embedded statement.
10253 (Foreach.CollectionForeach.Resolve): Remove extraneous flowbranching.
10255 2006-05-02 Raja R Harinath <rharinath@novell.com>
10257 * statement.cs (Do.Resolve): If the loop is infinite, set the
10259 (While.Resolve, For.Resolve): Set a barrier after the embedded
10260 statement. There's no direct control flow that goes from the end
10261 of the embedded statement to the end of the loop.
10262 * flowanalysis.cs (FlowBranching.Infinite): Remove.
10263 (FlowBranchingLoop.Merge): Don't look at 'Infinite'. The changes
10264 above ensure that the reachability is correctly computed.
10266 * flowanalysis.cs (Reachability.ResetBarrier): Remove.
10267 (UsageVector.MergeBreakOrigins): If the current path is
10268 unreachable, treat it as if all parameters/locals are initialized.
10269 (FlowBranchingLoop.Merge): Don't clear any barriers. Handle
10270 infinite loops before merging-in break origins.
10272 * flowanalysis.cs (Reachability.Meet): Simplify code handling 'returns'.
10273 (Reachability.Reachable): Split part into ...
10274 (Reachability.Unreachable): ... this. Simplify.
10275 (Reachability.IsUnreachable): Use 'Unreachable' instead.
10277 * flowanalysis.cs (Reachability.SetReturnsSometimes): Remove.
10278 (Reachability.SetThrowsSometimes): Likewise.
10279 (FlowBranchingBlock.MergeTopBlock): Don't compare against
10280 TriState.Always, use corresponding property.
10281 * statement.cs (Lock.Resolve, Try.Resolve, Using.Resolve): Likewise.
10282 (Block.Resolve): Likewise. Remove some redundant checks.
10284 2006-05-02 Raja R Harinath <harinath@gmail.com>
10286 * flowanalysis.cs (UsageVector.Throw): Set barrier too.
10287 (Reachability.Meet): Don't bother checking AlwaysThrows --
10288 barrier is always set.
10289 (FlowBranchingBlock.Merge): Likewise.
10291 2006-05-01 Raja R Harinath <harinath@gmail.com>
10293 * codegen.cs (EmitContext.ResolveTopBlock): Remove redundant
10294 checks for unreachable.
10296 2006-05-01 Marek Safar <marek.safar@seznam.cz>
10299 * flowanalysis.cs (UsageVector.IsAssigned): Add flag to ignore short path.
10301 * statement.cs (Block.UsageWarning): Uses newly introduced flag to detect
10302 whether field is really assigned.
10304 2006-04-30 Raja R Harinath <harinath@gmail.com>
10306 * flowanalysis.cs (Reachability): Make 4-argument constructor
10308 (Reachability.Meet): Rename from 'And'. Remove static variant.
10309 (Reachability.Always): Rename from the highly misleading
10310 'Reachability.Never'.
10311 (FlowBranching.Merge): Update to changes. Mark an impossible
10312 situation with a 'throw'.
10313 (*): Update to changes.
10315 2006-04-29 Raja R Harinath <harinath@gmail.com>
10317 * flowanalysis.cs (TriState): Rename from FlowBranching.FlowReturns.
10318 Remove 'Undefined'.
10319 (FlowBranching.TriState_Meet): Rename from AndFlowReturns. Simplify.
10320 (FlowBranching.TriState_Max): Rename from OrFlowReturns. Simplify.
10321 (*): Update to changes.
10322 * statement.cs: Update to changes.
10324 2006-04-28 Marek Safar <marek.safar@seznam.cz>
10327 *class.cs (Method.FindOutBaseMethod): Base method cannot be property method.
10329 2006-04-28 Raja R Harinath <harinath@gmail.com>
10331 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't create a
10334 * flowanalysis.cs (UsageVector.MergeChild): Change FlowBranching
10335 argument to two arguments: an usage-vector and a bool. Move call
10336 to FlowBranching.Merge () ...
10337 (FlowBranching.MergeChild, FlowBranching.MergeTopBlock): ... here.
10339 * flowanalysis.cs (UsageVector.MergeChild): Move special-case
10340 handling of loop and switch reachability to ...
10341 (FlowBranchingLoop.Merge, FlowBranchingSwitch.Merge): ... these.
10343 2006-04-27 Raja R Harinath <harinath@gmail.com>
10345 * flowanalysis.cs (FlowBranching.InLoop): Move special-case
10346 handling to FlowBranchingLoop.InLoop.
10347 (FlowBranching.InSwitch): Likewise, to FlowBranchingSwitch.
10349 2006-04-26 Marek Safar <marek.safar@seznam.cz>
10352 * anonymous.cs (AnonymousMethod.DoResolve): Moved the check whether
10353 anonymous method is allowed from AnonymousContainer here.
10355 * attribute.cs, codegen.cs (EmitContext): Add IsAnonymousMethodAllowed.
10357 2006-04-24 Raja R Harinath <rharinath@novell.com>
10360 * flowanalysis.cs (MyBitVector.Or): Add null check on argument.
10362 2006-04-23 Marek Safar <marek.safar@seznam.cz>
10365 * constant.cs (FloatConstant.Reduce): Add range checking for checked context.
10366 (DoubleConstant.Reduce): Ditto.
10368 2006-04-23 Raja R Harinath <rharinath@novell.com>
10370 * expression.cs (LocalVariableReference.DoResolveBase): Simplify.
10371 Remove 'lvalue_right_side' argument. Move parts to ...
10372 (LocalVariableReference.ResolveLocalInfo, LocalVariable.DoResolve)
10373 (LocalVariable.DoResolveLValue): ... these.
10375 2006-04-21 Raja R Harinath <rharinath@novell.com>
10378 * codegen.cs (EmitContext.InRefOutArgumentResolving): Remove.
10379 * expression.cs (EmptyExpression.LValueMemberOutAccess): New.
10380 (LocalVariableReference.DoResolveBase): Use it to implement new
10382 (IndexerAccess.DoResolveLValue): Handle LValueMemberOutAccess.
10383 (Argument.Resolve): Simplify. Move CS1510 check ...
10384 * ecore.cs (Expression.ResolveLValue): ... here.
10385 (UnboxCast.DoResolveLValue): Handle LValueMemberOutAccess.
10386 (PropertyExpr.DoResolveLValue): Likewise.
10387 (FieldExpr.Report_AssignToReadonly): Likewise.
10388 (FieldExpr.DoResolve): Add 'out_access' argument. Use
10389 LValueMemberAccess or LValueMemberOutAccess on instance depending
10391 (FieldExpr.DoResolveLValue): Pass 'out_access' argument to
10392 DoResolve as appropriate.
10394 2006-04-20 Raja R Harinath <rharinath@novell.com>
10397 * expression.cs (Invocation.VerifyArgumentsCompat): Don't try
10398 implicit conversions on 'out' and 'ref' arguments.
10400 * expression.cs (Invocation.VerifyArgumentsCompat): Reorganize to
10401 improve clarity. Remove dead code.
10404 * statement.cs (Block.UsageWarning): Allow VariableInfo to be null.
10405 (Catch.Resolve): Resolve VarBlock if it exists.
10407 2006-04-19 Miguel de Icaza <miguel@novell.com>
10409 * statement.cs (Foreach.EmitFinally): Do not emit the enumerator
10410 twice, this was some residual code, the enumerator was emitted
10411 properly in the two branche of if later.
10413 2006-04-19 Raja R Harinath <rharinath@novell.com>
10415 * expression.cs (Cast.ResolveLValue): Remove. The result of a
10416 cast is never an lvalue.
10417 (Cast.DoResolve, Cast.ResolveRest): Combine.
10418 (Argument.Emit): Simplify slightly. Move 'Expr is
10419 IMemoryLocation' check ...
10420 (Argument.Resolve): ... here.
10421 (Argument.Error_LValueRequired): Remove. Inline into only user.
10423 Simplifications. Fix cs0191-2.cs
10424 * ecore.cs (FieldExpr.DoResolve): Move handling of CS0192, CS0198,
10425 CS1649 and CS1651 to ...
10426 (FieldExpr.Report_AssignToReadonly): ... this. Simplify by moving
10427 the actual selection of the error code and message to a lookup
10428 table. Add a dummy return value to simplify callsites.
10429 (FieldExpr.ResolveLValue): Don't allow a constructor to write to
10430 readonly fields of other instances of the same type. Move CS0197
10432 * expression.cs (Argument.Resolve): ... here. Simplify code.
10433 Ensure that ec.InRefOutArgumentResolving is only set during LValue
10434 resolution of an out or ref argument. The code simplification
10435 above uses this invariant.
10437 2006-04-18 Raja R Harinath <rharinath@novell.com>
10439 Possibly fix #77752. Fix cs1690-[4-7].cs.
10440 * ecore.cs (Expression.CheckMarshalByRefAccess): Renamed from
10441 CheckMarshallByRefAccess. Drop parameter.
10442 (FieldExpr.CheckMarshalByRefAccess): Update. Change CS1690 to a
10444 (FieldExpr.DoResolve): Call CheckMarshalByRefAccess on
10445 InstanceExpression.
10446 * report.cs (AllWarnings): Add CS1690.
10447 * expression.cs (Argument.Resolve): Use EmptyExpression.OutAccess
10448 for ref access too.
10449 (LocalVariableReference.DoResolveBase): Update.
10451 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10453 * class.cs (MethodOrOperator): Moved common parts from method class.
10454 detect obsolete attributes.
10455 (Method.Define): Simplified as it reuses code from base.
10456 (Constructor.ValidAttributeTargets): Fixed issue found during
10458 (Destructor.ValidAttributeTargets): Fixed issue found during
10460 (Operator): Finished refactoring set off by #78020. Operator class is now
10461 ordinary method class.
10463 * anonymous.cs: Updated.
10465 * decl.cs (DeclSpace): Add IsGeneric
10467 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10469 * class.cs (Constructor.Emit): Don't emit the attributes twice.
10471 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10473 * class.cs (Operator.Emit): Extracted code from MethodData to correctly
10474 detect obsolete attributes.
10475 (Method.CreateEmitContext): Moved to MethodOrOperator.
10477 2006-04-09 Marek Safar <marek.safar@seznam.cz>
10480 * class.cs (TypeContainer.MemberCoreArrayList.DefineContainerMembers): Throw
10481 customized exception to make crash detection easier.
10482 (MethodOrOperator): Started to work on new base class for methods and
10484 (Method): Derives from MethodOrOperator.
10485 (Constructor.Emit): Emits its own attributes.
10486 (AbstractPropertyEventMethod.Emit): Ditto.
10487 (Operator): Derives from MethodOrOperator, will refactor fully in extra
10489 (Operator.Emit): It's temporary more tricky than should be.
10491 * doc.cs (GetMethodDocCommentName): Updated after operator changes.
10493 * report.cs (InternalErrorException): Add ctor with inner exception.
10495 2006-04-08 Marek Safar <marek.safar@seznam.cz>
10498 * ecore.cs (SimpleName.ResolveAsTypeStep): Report better error when type is
10501 2006-04-07 Marek Safar <marek.safar@seznam.cz>
10504 * expression.cs (ArrayCreation.GetAttributableValue): Creates correctly typed
10507 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10509 * class.cs (Class.ApplyAttributeBuilder): Report an error when ComImport
10510 attribute is present and Guid not.
10511 (Interface.ApplyAttributeBuilder): Ditto.
10513 * attribute.cs: Add error message.
10515 2006-04-06 Marek Safar <marek.safar@seznam.cz>
10519 * attribute.cs (Attribute.AttachTo): The attribute can have multiple
10520 sources (it's composite) so hold them in extra array as they are used in
10521 Emit phase only. It worked in the previous versions by mistake.
10522 (Attribute.Emit): Emit attribute for more owners when exist.
10524 * codegen.cs, class.cs: Updated to don't re-attach attribute twice as now
10525 it has now different behaviour.
10527 2006-04-04 Marek Safar <marek.safar@seznam.cz>
10529 * constant.cs (Constant.IsDefaultInitializer): New method.
10531 * class.cs: Updated.
10533 * expression.cs (ArrayCreation.CheckIndices): Add an optimization to don't
10534 re-initialize default values. It saves KBs almost for every assembly.
10535 Thanks Zoltan for the idea.
10536 (ArrayCreation.ResolveInitializers): Renamed from ValidateInitializers.
10537 (ArrayCreation.DoResolve): Resolve only once.
10538 (ArrayCreation.Emit): Emit static initializer only when it is faster.
10539 (ArrayCreation.GetAttributableValue): Cope with optimized values.
10541 2006-04-03 Zoltan Varga <vargaz@gmail.com>
10543 * report.cs (Warning, Error): Add 0-, 1-, and 2- argument specializations.
10546 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10548 * assign.cs (Assign.DoResolve): Assignment to same variable can occur
10549 in an embedded statement too.
10551 2006-04-01 Raja R Harinath <rharinath@novell.com>
10554 * statement.cs (Switch.EmitObjectInteger) [ulong]: Remove bad cast.
10556 2006-04-01 Marek Safar <marek.safar@seznam.cz>
10560 * class.cs (TypeContainer.AddPartial): Don't report an error when modifier
10563 * modifiers.cs: Add DEFAULT_ACCESS_MODIFER.
10565 2006-03-31 Marek Safar <marek.safar@seznam.cz>
10567 * assign.cs (LocalTemporary): Don't require ILGenerator in the resolve
10570 * anonymous.cs, assign.cs, ecore.cs, expression.cs: Updated after
10571 LocalTemporary change.
10573 * class.cs (ClassOrStruct.DefineDefaultConstructor): Moved from
10575 (ClassOrStruct.DefineFieldInitializers): Implemented static field
10576 initializers optimization.
10577 (ClassOrStruct.TypeAttr): Moved from modifiers.
10578 (Constructor.CheckBase): Don't crash when static ctor has parameters.
10579 (FieldBase.ResolveInitializer): Resolves initializer.
10580 (FieldBase.HasDefaultInitializer): New property.
10582 * cs-parser.jay: Removed message.
10584 * expression.cs (CompilerGeneratedThis): New specialization.
10586 * modifiers.cs (TypeAttr): Moved to ClassOrStruct.TypeAttr
10588 2006-03-28 Marek Safar <marek.safar@seznam.cz>
10590 * cs-parser.jay, cs-tokenizer.cs: On demand Stack allocation.
10592 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10594 * ecore.cs (Expression.ResolveAsConstant): Clean up, enum constants should
10595 be now EnumConstants only.
10597 2006-03-27 Marek Safar <marek.safar@seznam.cz>
10599 * attribute.cs, driver.cs: Reset more caches.
10601 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10603 * cs-tokenizer.cs (adjust_real): Uses float.Parse for float literals.
10605 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10607 * constant.cs (Constant.Reduce): Replaced EmitContext with single bool
10608 for easier reuse. Updated all overrides.
10609 (IntegralConstant): New base class for all integral constants.
10610 (IntegralConstant.Error_ValueCannotBeConverted): When assigned value if out
10611 of the constant range, report custom error.
10612 (UIntConstant.Reduce): Fixed uint conversion.
10614 * ecore.cs, literal.cs: Reduce updates.
10616 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10620 * class.cs (Constructor.Define): Removed extra if for default ctors.
10621 A patch from Atsushi Enomoto.
10623 2006-03-26 Marek Safar <marek.safar@seznam.cz>
10625 * attribute.cs (Attribute.ResolveConstructor): Conversion was moved to
10626 GetAttributableValue.
10628 * constant.cs (Constant.GetAttributableValue): Does implicit conversion
10631 * convert.cs (ImplicitConversionRequired): Error message moved to
10634 * ecore.cs (Expression.GetAttributableValue): Add type parameter for
10635 automatic implicit conversion of an output value.
10636 (EnumConstant.GetAttributableValue): Don't reduce the enum constants.
10638 * expression.cs (ArrayCreation.GetAttributableValue): Add element type
10640 (TypeOf.GetAttributableValue): Add extra handling for object type.
10642 * literal.cs (DoubleLiteral.Error_ValueCannotBeConverted): Doubles can have
10643 special error message.
10645 2006-03-25 Marek Safar <marek.safar@seznam.cz>
10647 * class.cs (Constructor.Emit): Don't crash when struct ctor is
10649 (Constructor.ApplyAttributeBuilder): Transform MethodImplAttribute to be
10650 compatible with MS runtime.
10652 2006-03-23 Marek Safar <marek.safar@seznam.cz>
10654 * attribute.cs (Attribute.ResolveConstructor): Check for an invalid
10655 attribute arguments here.
10657 * class.cs (Indexer.Define): The check was moved to attribute class.
10659 2006-03-22 Marek Safar <marek.safar@seznam.cz>
10661 * assign.cs, class.cs, codegen.cs, convert.cs, decl.cs, ecore.cs,
10662 expression.cs, typemanager.cs: Minor changes from gmcs to make merging
10665 2006-03-22 Raja R Harinath <rharinath@novell.com>
10667 Support ParameterDefaultValueAttribute in gmcs. Also applied to
10668 mcs to keep code differences small.
10669 * attribute.cs (Attribute.GetParameterDefaultValue): New.
10670 * typemanager.cs (parameter_default_value_attribute_type): New.
10671 * parameter.cs (Parameter.ApplyAttributeBuilder): Use them. Add
10674 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10676 * expression.cs (StringConcat.Append): Reverted back to no warning state.
10678 2006-03-21 Marek Safar <marek.safar@seznam.cz>
10680 * const.cs (Error_ConstantCanBeInitializedWithNullOnly): Share a message.
10682 * statement.cs (Block.ResolveMeta): Look for wrong object constants in
10685 2006-03-21 Atsushi Enomoto <atsushi@ximian.com>
10687 * doc-bootstrap.cs : fix build.
10689 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10691 * expression.cs (StringConcat.Append): Issue a warning when empty string
10692 is going to append.
10694 2006-03-20 Marek Safar <marek.safar@seznam.cz>
10696 * assign.cs (CompoundAssign.ResolveSource): Removed.
10698 * attribute.cs (ResolvePossibleAttributeType): Updated after MemberAccess
10701 * class.cs (TypeContainer.FindMethods): Removed.
10702 (TypeContainer.CheckMemberUsage): Made static.
10704 * codegen.cs (GetAssemblyName): Uses Length for empty string test.
10706 * constant.cs (CheckRange): Removed unused type argument.
10707 (CheckUnsigned): Removed unused type argument.
10709 * cs-parser.jay: Updated after MemberAccess clean up.
10710 Uses Length for empty string test.
10712 * cs-tokenizer.cs: Uses Length for empty string test.
10713 (IsCastToken): Made static.
10714 (is_hex): Made static.
10715 (real_type_suffix): Made static.
10717 * decl.cs (SetupCache): Made static.
10718 (OnGenerateDocComment): Removed unused ds argument.
10720 * delegate.cs (VerifyDelegate): Removed unused argument.
10722 * doc.cs: Uses Length for empty string test.
10724 * driver.cs: Uses Length for empty string test.
10726 * enum.cs (IsValidEnumType): Made static
10728 * expression.cs (EnumLiftUp): Removed unused argument.
10729 (ResolveMethodGroup): Ditto.
10730 (BetterConversion): Ditto.
10731 (GetVarargsTypes): Ditto.
10732 (UpdateIndices): Ditto.
10733 (ValidateInitializers): Ditto.
10734 (MemberAccess.ctor): Ditto.
10735 (GetIndexersForType): Ditto.
10737 * flowanalysis.cs: (MergeFinally): Removed unused argument.
10739 * iterators.cs: Updated after MemberAccess clean up.
10741 * location.cs: Uses Length for empty string test.
10743 * namespace.cs: Uses Length for empty string test.
10745 * report.cs (CheckWarningCode): Made static.
10747 * statement.cs (LabeledStatement): Removed unused argument.
10749 * typemanager.cs (FilterNone): Removed.
10751 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10753 * codegen.cs (EmitContext.TestObsoleteMethodUsage): Removed as it become
10756 * class.cs: Updated.
10758 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10760 * cs-parser.jay.cs: __arglist is not allowed for delegates.
10762 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10766 * expression.cs (VerifyArgumentsCompat): Reverted to double error
10767 reporting, it's more tricky than I thought.
10769 2006-03-18 Marek Safar <marek.safar@seznam.cz>
10773 * anonymous.cs.cs (AnonymousMethod): Add host to allow access to
10775 (AnonymousMethod.ImplicitStandardConversionExists): New method.
10776 (AnonymousMethod.Compatible): Moved parameter resolving to DoResolve.
10777 Add more error reporting; Fixed issue with params.
10779 * convert.cs (ImplicitStandardConversionExists): Returned conversion check.
10781 * cs-parser.jay: AnonymousMethod requires host container.
10783 * delegate.cs (NewDelegate.DoResolve): Updated after Compatible changes.
10785 2006-03-18 Raja R Harinath <harinath@gmail.com>
10787 * class.cs: Change 'TypeContainer ds' constructor argument to
10788 'DeclSpace parent'. Some classes were missed below due to
10789 different naming convention.
10791 * class.cs (MemberCore.Parent): Delete. This makes the
10792 ParentContainer changes below enforceable by the compiler.
10794 Treat pointers to enclosing declaration space as 'DeclSpace', not
10796 * class.cs, const.cs, delegate.cs, enum.cs, iterator.cs: Change
10797 'TypeContainer parent' constructor argument to 'DeclSpace parent'.
10799 * statement.cs (LocalInfo..ctor): Use DeclSpace argument instead
10801 (Block.AddThisVariable): Likewise.
10802 * class.cs (MethodData.Define, MethodData.Emit): Likewise.
10803 (AbstractPropertyEventMethod.Emit): Likewise.
10804 (AbstractPropertyEventMethod.EmitMethod): Likewise.
10805 (GetMethod.Define, SetMethod.Define): Likewise.
10806 (PropertyMethod.Define, DelegateMethod.Define): Likewise.
10807 (DelegateMethod.EmitMethod): Likewise.
10809 Fix regression test-partial-13.cs.
10810 Rationalize use of PartialContainer. Ensure that the partial
10811 class semantics can be tied to type-correctness, i.e., any
10812 violation will cause a compile error.
10813 * class.cs, const.cs: Access all fields that belong to class
10814 TypeContainer via ParentContainer. Arguments of EmitContexts and
10815 Resolve()-like functions still use 'Parent'.
10817 * class.cs (SourceMethod): Use DeclSpace, not TypeContainer.
10818 (*.CreateEmitContext): Change TypeContainer argument to DeclSpace.
10819 (PropertyMethod.CheckModifiers): Remove unused argument.
10820 * codegen.cs (EmitContext..ctor): Change TypeContainer argument to
10823 2006-03-17 Raja R Harinath <harinath@gmail.com>
10825 Make semantics of PartialContainer simpler.
10826 * decl.cs (DeclSpace.IsPartial): Remove.
10827 * class.cs (TypeContainer.IsPartial): Likewise.
10828 (TypeContainer..ctor): Set PartialContainer to point to self.
10829 (TypeContainer.GetClsCompliantAttributeValue): Don't use IsPartial.
10830 (TypeContainer.FindNestedType): Likewise.
10831 (MemberCore.ParentContainer): Simplify. Remove deprecation.
10833 2006-03-17 Marek Safar <marek.safar@seznam.cz>
10835 * typemanager.cs.cs (GetInterfaces): Don't recreate 0-sized arrays.
10837 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10839 * class.cs (FieldMember.Emit): ParentContainer is real parent for partial
10842 2006-03-15 Marek Safar <marek.safar@seznam.cz>
10844 * class.cs (Operator.Define): An error for base conversion was not
10845 reported correctly.
10847 2006-03-14 Atsushi Enomoto <atsushi@ximian.com>
10849 * iterator.cs : yield break is allowed in try statement which has
10850 catch clauses. Fixed bug #77767.
10852 2006-03-13 Marek Safar <marek.safar@seznam.cz>
10854 A fix for #77593, #77574.
10856 * class.cs (MethodCore.CheckBase): Another if for operator.
10858 2006-03-09 Marek Safar <marek.safar@seznam.cz>
10860 * anonymous.cs (AnonymousMethod.Compatible): Don't crash when parameters
10863 * delegate.cs (Delegate.GetInvokeMethod): Use emitcontext free MemberLookup.
10864 (DelegateCreation.ImplicitStandardConversionExists): New method for just
10867 *ecore.cs (Expression.MemberLookup): Don't ask for emitcontext when it's
10870 * assign.cs, constant.cs, convert.cs, delegate.cs, expression.cs:
10871 Updated after another emitcontext usage was clean up. It should help us to
10872 synchronize with gmcs easier.
10874 2006-03-04 Marek Safar <marek.safar@seznam.cz>
10878 * class.cs (SetMethod.DefineParameters): Uses new parameters type ctor.
10879 (Event.Define): ditto
10880 (SetIndexerMethod.DefineParameters): Uses Parameters.MergeGenerated.
10882 * delegate.cs (Delegate.Define): Uses Parameters.MergeGenerated.
10883 Removed redundant code and set NewSlot for Invoke method too.
10885 * parameter.cs (Parameters.ctor): Add custom, type ctor.
10886 (Parameters.MergeGenerated): New method. Use this method when you merge
10887 compiler generated argument with user arguments.
10889 2006-03-03 Marek Safar <marek.safar@seznam.cz>
10891 * attribute.cs (ResolveAsTypeTerminal): Removed.
10893 * ecore.cs (Expression.ResolveAsTypeTerminal): Make virtual to allow
10894 specialization for predefined types; 30% speed up.
10895 Finally placed obsolete check to right place.
10896 (Expression.ResolveType): Removed.
10898 * enum.cs, expression.cs, parameter.cs, statement.cs, typemanager.cs:
10899 Updated after ResolveType was removed.
10901 * expression.cs (Cast.ctor): Check void cast.
10902 (Binary.ResolveAsTypeTerminal): Is never type.
10903 (Conditional.ResolveAsTypeTerminal): Is never type.
10905 * rootcontext.cs (ResolveCore): Set base type to simplify some code later.
10907 2006-03-01 Raja R Harinath <rharinath@novell.com>
10910 * expression.cs (ParameterReference.DoResolveBase): Change return
10912 (ParameterReference.DoResolve, ParameterReference.DoResolveLValue):
10916 * ecore.cs (PropertyExpr.InstanceResolve): Fix CS1540 check.
10919 * typemanager.cs (GetFullNameSignature): Don't nullref on
10920 protected accessors.
10922 2006-02-27 Marek Safar <marek.safar@seznam.cz>
10924 * attribute.cs (Attribute.PosArguments, Attribute.NamedArguments): Use
10925 these two separated members to simplify the code.
10926 (Attribute.Resolve): Refactored to use new fields and methods.
10927 (Attribute.ResolveConstructor): Extracted from ResolveArguments and
10928 implemented obsolete attribute checking.
10929 (Attribute.ResolveNamedArguments): Extracted from ResolveArguments and
10930 implemented obsolete checking again. It look line never ending quest ;-)
10931 (GlobalAttribute.ResolveConstructor): Need to override as the rest.
10933 * cfold.cs (BinaryFold): TryReduce throws an exception to indicate error.
10935 * constanct.cs (TryReduce): Throws OverflowException to indicate error.
10937 *class.cs (Property.Define): Add RegisterProperty call.
10939 * cs-parser.jay: Replaced ArrayList with fixed array for attribute
10940 argument groups (only 2).
10942 * ecore.cs (Expression.GetAttributableValue): New virtual method used for
10943 encoding expression to arguments.
10944 (Expression.ExprClassToResolveFlags): Just turned to property.
10946 * expression.cs (ArrayCreation.ValidateInitializers): Slightly optimized.
10947 (ArrayCreation.GetAttributableValue): Renamed from EncodeAsAttribute and
10948 optimized as well as implemented support for zero-length attributes.
10950 * typemanager.cs (TypeManager.RegisterProperty, TypeManager.GetProperty):
10951 Add caching of PropertyInfo's.
10953 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10955 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Don't report
10956 error multiple times.
10958 2006-02-25 Marek Safar <marek.safar@seznam.cz>
10960 New partial class implementation.
10961 A fix for #77027, #77029, #77403
10963 * attribute.cs (Attributable): Made attributes protected.
10965 * class.cs (TypeContainer): Add PartialContainer and partial_parts as
10966 the replacements of ClassPart and PartialContainer.
10967 (TypeContainer.AddClassOrStruct): Call RecordDecl here.
10968 (TypeContainer.AddInterface): Ditto.
10969 (TypeContainer.AddPartial): The main method for partial classes. It checks
10970 for errors and merges ModFlags and attributes. At the end class is added to
10971 partial_parts list.
10972 (TYpeContainer.DefineDefaultConstructor): Checks whether default ctor is
10974 (TypeContainer.GetClsCompliantAttributeValue): Cope with partial class too.
10975 (TypeContainer.GetNormalPartialBases): Resolves base classes and interfaces
10976 from the rest of partial classes.
10977 (TypeContainer.GetClassBases): Simplified.
10978 (TypeContainer.DefineTypeBuilder): New method, mostly extracted from
10980 (TypeContainer.DefineDefaultConstructor): Is used by derived classes.
10981 (TypeContainer.HasExplicitLayout): Uses Flags now.
10982 (PartialContainer): Removed.
10983 (ClassOrStruct.AddToContainer): Moved enclosing member name check here.
10984 (StaticClass): Was merged with Class.
10985 (Class.GetClassBases): class and static class bases are verified here.
10986 (Class.TypeAttr): Added static attributes when class is static.
10987 (Struct.RegisterFieldForInitialization): Moved from TypeContainer.
10988 (MemberBase): In some cases we need to call parent container for partial
10989 class. It should be eliminated but it's not easy now.
10991 * cs-parser.jay: Replaced all PartialContainer with AddPartial.
10993 * decls.cs (MemberCore.DocComment): Introduced new property as is used by
10994 partial classed to accumulate class comments.
10995 (MemberCore.GetClsCompliantAttributeValue): Moved from TypeContainer.
10997 * doc.cs (GenerateTypeDocComment): Partial classes clean up.
10999 * driver.cs (MainDriver): Tree.GetDecl was removed.
11001 * modifiers.cs (Modifiers): Add partial modifier.
11003 * tree.cs (Tree.decl): Removed.
11004 (RootTypes): Started to use this class more often for root types
11007 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11011 * attribute.cs (AttributeTester.GetCoClassAttribute): Don't crash when
11012 external interface does not have an attribute.
11014 2006-02-22 Marek Safar <marek.safar@seznam.cz>
11016 Another prerequisites for new partial classs implementation.
11018 * attribute.cs (Attribute.Equal): Implemented.
11019 (Attribute.Emit): Changed as attributes can be applied more than twice.
11020 (Attributes.Emit): Check for duplicate attributes here.
11022 * class.cs, decl.cs, delegate.cs, doc.cs, enum.cs: Don't pass DeclSpace
11023 as a parameter, clean-up.
11025 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11029 * class.cs (TypeContainer.DefineType): Cannot use ResolveType because it
11030 contains obsolete attribute check which can in some cases look for base
11031 type of current class which is not initialized yet.
11032 (TypeContainer.BaseType): Replacement of ptype.
11034 * decl.cs (MemberCore.CheckObsoleteType): Reuse existing code.
11036 2006-02-11 Marek Safar <marek.safar@seznam.cz>
11038 First of prerequisites for new partial classs implemention.
11040 * attribute.cs (Attributable): Extended by ResolveContext;
11041 Attributes finally have correct context for resolving in all cases.
11042 (AttachTo): Attribute owner is assigned here.
11044 * codegen.cs (IResolveContext): Introduce new interface to hold
11045 all information needed in resolving phase.
11046 (EmitContext): Implements IResolveContext; more clean-up needed here.
11048 * decl.cs (MemberCore): Implemented IResolveContext.
11050 * anonymous.cs, attribute.cs, class.cs, codegen.cs, const.cs,
11051 decl.cs, ecore.cs, enum.cs, expression.cs, iterators.cs, namespace.cs,
11052 parameter.cs, statement.cs, tree.cs, typemanager.cs:
11053 Refactored to use new IResolveContext instead of EmitContext; cleanup
11055 2006-02-06 Miguel de Icaza <miguel@novell.com>
11057 * codegen.cs (EmitScopeInitFromBlock): check here the
11058 capture_context, there is no need to make two calls to the
11061 * anonymous.cs: Add some debugging messages that might help me
11062 track other instances of this problem in the future (the
11063 regression of test 467).
11065 * cs-parser.jay: track the variable block, as we need to initalize
11066 any captured variables declared in this block for the "catch"
11067 portion of the "Try" statement.
11069 * statement.cs (Try.Emit): If the "Catch" has a VarBlock, emit any
11070 scope initialization for captured variables.
11072 Also, move the emit for the variables after the block location has
11075 2006-02-06 Marek Safar <marek.safar@seznam.cz>
11077 * ecore.cs (PropertyExpr.FindAccessors): Just made flags const.
11079 2006-02-02 Miguel de Icaza <miguel@novell.com>
11081 * anonymous.cs (CaptureContext.EmitInitScope): I was wrong in the
11082 commit yesterday, the initialization for the roots is necessary.
11083 What is not necessary is the scope activation.
11085 2006-02-02 Raja R Harinath <rharinath@novell.com>
11087 * ecore.cs (PropertyExpr.DoResolveLValue): Add CS0206 check.
11088 * expression.cs (IndexerAccess.DoResolveLValue): Add CS1612 and
11090 (Argument.Resolve): Remove CS0206 checks.
11092 2006-02-01 Miguel de Icaza <miguel@novell.com>
11094 * anonymous.cs (CaptureContext.EmitInitScope): Do not emit the
11095 scopes for all the roots, the scopes will now be emitted when the
11096 Blocks are entered. [This change was wrong, fixed on 2006-02-02]
11098 (CaptureContext.EmitScopeInitFromBlock): Simply emit the ScopeInfo
11099 code. This reduces a lot of existing cruft.
11101 * statement.cs (Block.Emit): Call EmitScopeInitFromBlock here, so
11102 that the ScopeInfo is generated as we enter the scope, not at the
11103 time of use, which is what we used to do before.
11105 * codegen.cs (EmitScopeInitFromBlock): New routine, this is called
11106 every time a Block is about to be emitted if we have a
11109 2006-02-01 Raja R Harinath <rharinath@novell.com>
11111 * typemanager.cs (NoTypes, NoTypeExprs): Remove.
11113 * *.cs: Use Type.EmptyTypes instead of TypeManager.NoTypes.
11115 * typemanager.cs (cons_param_array_attribute): Make private.
11116 (Reset): Set it to null.
11117 (InitCoreHelpers): Don't initialize it.
11118 (ConsParamArrayAttribute): New. Initialize it as needed.
11119 * parameter.cs (ParamsParameter.ApplyAttribute): Update to change.
11121 2006-01-31 Miguel de Icaza <miguel@novell.com>
11123 * expression.cs: There might be errors reported during the
11124 selection of applicable methods. If there are errors, do not
11125 continue execution as it will lead the compiler to crash.
11127 2006-01-30 Miguel de Icaza <miguel@novell.com>
11129 * expression.cs: Member access is not allowed on anonymous
11130 methods. Fixes #77402.
11132 2006-01-30 Raja R Harinath <rharinath@novell.com>
11135 * cs-parser.jay (VariableDeclaration): Don't set
11136 current_array_type to null.
11137 (field_declaration, event_declaration, declaration_statement):
11138 Set it to null here.
11140 2006-01-28 Raja R Harinath <harinath@gmail.com>
11142 * typemanager.cs (GenericParameterPosition): New.
11145 2006-01-28 Atsushi Enomoto <atsushi@ximian.com>
11147 * doc.cs : To process "include" elements, first we should create
11148 another list than XmlNodeList, because it could result in node
11149 removal, which could result in that the XmlNodeList gives up
11150 yielding next node.
11152 (Also made code identical to gmcs again.)
11154 2006-01-25 Miguel de Icaza <miguel@novell.com>
11156 * ecore.cs: Introduce an error report that we were not catching
11157 before, if not silent, we must report the error. Gonzalo ran into
11160 2006-01-23 Miguel de Icaza <miguel@novell.com>
11162 A fix for bug: #76957
11164 * iterators.cs (MoveNextMethod.CreateMethodHost): call
11165 ComputeMethodHost before creating the method, this is a new
11168 * anonymous.cs (AnonymousContainer): Now we track all the scopes
11169 that this method references (RegisterScope). The actual scope
11170 where the method is hosted is computed with the ComputeMethodHost
11171 before we create the method.
11173 Moved the Deepest routine here.
11175 (AnonymousContainer.ComputeMethodHost): New routine used to
11176 compute the proper ScopeInfo that will host the anonymous method.
11178 (ScopeInfo): Deal with multiple roots. The problem was that we
11179 did not have a unique root where all ScopeInfos could be hanged
11180 from. Remove `topmost' ScopeInfo, and instead keep an arraylist
11183 Remove AdjustMethodScope which is now computed at the end. Remove
11184 LinkScope which did a partial link, instead link all ScopeInfos
11185 before code generation from the new "LinkScopes" routine.
11187 Simplify all the Add* routines as they no longer need to maintain
11188 the tree, they just need to record that they are using variables
11191 (IsAncestor, GetAncestorScopes, GetParentScope, LinkScope): New
11192 routines to produce the forest of ScopeInfo trees.
11194 * class.cs (TypeContainer.AppendMethod): This is just like
11195 AddMethod, but ensures that an interface implementation method
11196 (IEnumerable.XXX) is not inserted at the beginning of the queue of
11197 methods, but at the end.
11199 We use this functionality to ensure that the generated MoveNext
11200 method in the iterator class is resolved/emitted before the
11201 enumerator methods created.
11203 This is required because the MoveNext method computes the right
11204 ScopeInfo for the method. And the other methods will eventually
11205 need to resolve and fetch information computed from the anonymous
11208 2006-01-21 Raja R Harinath <harinath@gmail.com>
11209 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11211 Fix rest of #76995.
11212 * namespace.cs (NamespaceEntry.UsingExternalAliases): Don't add to
11213 the 'aliases' hash.
11214 (NamespaceEntry.LookupAlias): Lookup 'extern_aliases' hash too.
11215 (NamespaceEntry.VerifyUsing): Resolve external aliases too.
11217 2006-01-18 Raja R Harinath <rharinath@novell.com>
11219 Fix #76656, cs0231-2.cs.
11220 * cs-parser.jay (formal_parameter_list): Make error case catch
11222 (parenthesized_expression_0): Add CS1026 check.
11223 (invocation_expression): Remove unused { $$ = lexer.Location }.
11225 2006-01-17 Raja R Harinath <rharinath@novell.com>
11228 * cs-parser.jay (statement_expression): Don't list out the
11229 individual statement-expressions. Convert syntax error into
11232 2006-01-16 Raja R Harinath <rharinath@novell.com>
11235 * ecore.cs (MemberAccess.CheckIntermediateModification): Remove.
11236 (UnboxCast.DoResolveLValue): New. Move CS0445 check from
11237 CheckIntermediateModification.
11238 (FieldExpr.DoResolve): Add new two-argument version that
11239 allows us to resolve the InstanceExpression as an lvalue.
11240 The one-argument variant is now just a wrapper.
11241 (FieldExpr.DoResolveLValue): Use two-argument DoResolve.
11242 Resolve the lhs as an lvalue if the it has a value type.
11243 (FieldExpr.AssignToReadonly): Move CS1648 and CS1650 checks
11244 from Assign.DoResolve.
11245 (PropertyExpr.InstanceResolve): Allow InstanceExpression to be
11246 resolved as an lvalue.
11247 (PropertyExpr.DoResolve): Update.
11248 (PropertyExpr.DoResolveLValue): Resolve the lhs as an lvalue if it
11249 has a value type. Move CS1612 check here from
11250 CheckIntermediateModification.
11251 * assign.cs (Assign.DoResolve): Remove CS1648 and CS1650 checks.
11252 * expression.cs (EmptyExpression.OutAccess): New. Used as the
11253 'right_side' of a ResolveLValue on an 'out' argument.
11254 (EmptyExpression.LValueMemberAccess): New. Used as the
11255 'right_side' of a propagated ResolveLValue on a value type.
11256 (LocalVariableReference.DoResolveBase): Recognize
11257 EmptyExpression.OutAccess and EmptyExpression.LValueMemberAccess.
11259 (Argument.Resolve): Use EmptyExpression.OutAccess rather than
11260 EmptyExpression.Null.
11262 2006-01-16 Atsushi Enomoto <atsushi@ximian.com>
11264 * typemanager.cs : added IsGenericParameter(). In mcs it always
11266 * doc.cs : for generic parameters, use GenericParameterPosition,
11269 2006-01-12 Ben Maurer <bmaurer@andrew.cmu.edu>
11271 * expression.cs: Fix Console.WriteLine ((this = x).foo);
11273 2006-01-12 Miguel de Icaza <miguel@novell.com>
11275 This fixes the problem where we used ldfld instead of ldflda to
11276 load the "THIS" pointer on captured parameters, when THIS is a
11277 value type. See bug #77205.
11279 * iterators.cs (CapturedThisReference.Emit): Pass false to
11280 EmitThis (we do not need the address).
11282 * codegen.cs (EmitThis): it needs to know whether we need the
11283 address of `this' or not. This is used by value types.
11285 * expression.cs (This.AddressOf): Pass true to the EmitThis call,
11286 every other call passes false.
11288 2006-01-12 Raja R Harinath <rharinath@novell.com>
11291 * typemanager.cs (TryGetBaseDefinition): Rename from the mis-named
11293 * expression.cs (Invocation.OverloadResolve): Update.
11294 (Invocation.DoResolve): Avoid double resolution of invocation.
11296 2006-01-11 Raja R Harinath <rharinath@novell.com>
11299 * expression.cs (Unary.Emit): When in /checked+ mode, don't emit
11300 unary negation of floating point types as 0-expr; negation cannot
11301 overflow in floating point types.
11304 * expression.cs (MemberAccess.DoResolve): Disallow the use of '.'
11305 on operands of 'void' type.
11308 * cfold.cs (BinaryFold): Implement folding of BinaryOr, BinaryAnd
11309 and ExclusiveOr for boolean constants too.
11311 2006-01-09 Raja R Harinath <rharinath@novell.com>
11314 * expression.cs (Invocation.OverloadResolve): Replace reflected
11315 override methods with their base virtual methods, rather than
11316 skipping over them.
11317 * typemanager.cs (TypeManager.GetOverride): New.
11319 2006-01-05 Jb Evain <jbevain@gmail.com>
11321 * class.cs (Property.Define, Indexer.Define): do not tag the
11322 properties as SpecialName | RTSpecialName.
11324 2006-01-04 Miguel de Icaza <miguel@novell.com>
11326 * class.cs (MethodCore.IsDuplicateImplementation): This method was
11327 doing a low-level comparission of parameter types. It was lacking
11328 a check for __argslist.
11330 2005-12-30 Miguel de Icaza <miguel@novell.com>
11332 * expression.cs (ParameterReference.DoResolveBase): Allow
11333 reference parameters if they are local to this block.
11335 This allows the ref and out parameters of a delegate to be used in
11336 an anonymous method, for example:
11338 delegate void set (out int x);
11340 set s = delegate (out int x){
11344 This is used by functionality introduced late in the C# language.
11346 * anonymous.cs (AnonymousMethod.Compatible): Allow anonymous
11347 method that take ref and out parameters.
11349 Fixes #77119 which was a late change in the spec.
11351 2005-12-23 Miguel de Icaza <miguel@novell.com>
11353 * anonymous.cs (ScopeInfo.LinkScope): Do not link the scope to its
11354 parent if its the same scope. Fixes #77060.
11356 2005-12-21 Miguel de Icaza <miguel@novell.com>
11358 * driver.cs: Report the case of no source files and no -out:
11361 2005-12-20 Raja R Harinath <rharinath@novell.com>
11364 * expression.cs (ComposedCast.GetSignatureForError): Define.
11366 2005-12-18 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11370 * namespace.cs (NamespaceEntry): Add extern_aliases as a
11371 ListDictionary, to contain the ExternAliasEntry entries (in
11372 addition to the NamespaceEntry.aliases hashtable). This field is
11373 shared between the original entry and its doppelganger (bodyless
11375 (NamespaceEntry.UsingExternalAlias): Add the extern alias entry to
11376 extern_aliases field.
11377 (NamespaceEntry.Lookup): Move the IsImplicit check after the
11378 lookup in extern_aliases.
11380 2005-12-16 Raja R Harinath <rharinath@novell.com>
11383 * class.cs (TypeContainer.Mark_HasEquals): New.
11384 (TypeContainer.Mark_HasGetHashCode): New.
11385 (ClassPart): Override them.
11386 (MethodCore.CheckBase): Use them instead of referring to Parent.Methods.
11389 * enum.cs (EnumMember.EnumMember): Pass the parent_enum as the
11390 'parent' argument to the base constructor.
11392 Remove all mention of TypeContainer from decl.cs.
11393 * decl.cs (MemberCore.Parent): Change into a DeclSpace.
11394 (MemberCore.MemberCore): Change type of 'parent' argument to DeclSpace.
11395 (DeclSpace.DeclSpace): Likewise.
11396 (DeclSpace.DefineMembers): Remove unused argument.
11397 * cs-parser.jay (pop_current_class): Update to changes. Simplify
11398 debugging check -- we don't care if the debug code throws an
11399 InvalidCastException instead of an InternalErrorException.
11400 * class.cs (TypeContainer.DefineMembers): Update to changes.
11401 (TypeContainer.DoDefineMembers): Likewise.
11402 (TypeContainer.GetMethods): Likewise.
11403 (PropertyMember.Define): Likewise.
11404 (MemberBase.Parent): New property that forwards to
11405 MemberCore.Parent, but ensures that we get a TypeContainer.
11406 * rootcontext.cs (RootContext.PopulateCoreType): Update to changes.
11407 (RootContext.PopulateTypes): Likewise. Remove special case code
11408 for !RootContext.StdLib: DefineMembers is idempotent.
11410 2005-12-14 Miguel de Icaza <miguel@novell.com>
11412 * convert.cs (ExplicitConversionCore): Check the return value from
11413 ExplicitConversionCore which can return null on failure. Fixes #76914
11415 2005-12-13 Marek Safar <marek.safar@seznam.cz>
11417 * class.cs (Method.ApplyAttributeBuilder): Test out modifier properly.
11419 2005-12-11 Atsushi Enomoto <atsushi@ximian.com>
11421 * doc.cs : The search for referenced namespace was insufficient to
11422 get global one as it used to do. Fixed bug #76965.
11424 2005-12-10 Atsushi Enomoto <atsushi@ximian.com>
11426 * doc.cs : check name in cref in the last phase that whether it is
11429 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11431 * cs-tokenizer.cs : reverted the latest change: it somehow broke
11434 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11436 * doc.cs : so it turned out that we cannot skip override check for
11437 interface members. Fixed bug #76954.
11439 2005-12-09 Atsushi Enomoto <atsushi@ximian.com>
11441 * cs-tokenizer.cs : fixed bug #75984:
11442 - #warning and #error should not be handled when the source line
11444 - #line is not checked strictly when the source line is disabled.
11445 - #define and #undef is on the other hand checked strictly at any
11448 2005-12-08 Atsushi Enomoto <atsushi@ximian.com>
11450 * cs-tokenizer.cs : missing Location (actually, filename) in one of
11453 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11455 * attribute.cs (GlobalAttribute.ctor): Pass NamespaceEntry only.
11457 * class.cs (EmitFieldInitializers): Simplified and fixed to work with
11458 event initializers.
11459 (FieldBase.EmitInitializer): Moved from TypeContainer and simplified.
11460 (FieldBase.Initializer): Initializer is now optional.
11461 (EventField.Define): Only event field can have initializer.
11463 * codegen.cs (EmitContext): DeclSpace is not readonly (small hack).
11465 * const.cs (Const): Reuse initializer.
11467 * cs-parser.jay: Updated after FieldBase changes.
11468 Added current_array_type to simplify array initializers.
11470 * ecore.cs (NullCast.IsDefaultValue): Implemented.
11472 * expression.cs, iterators.cs: Updated.
11474 * namespace.cs (NamespaceEntry): Made UsingFound private.
11476 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11478 * parameterCollection.cs: Obsolete, removed.
11479 * parser.cs: Obsolete, removed.
11481 2005-12-05 Marek Safar <marek.safar@seznam.cz>
11484 * class.cs (Constructor.Emit): Set obsolete checking for whole context.
11486 * enum.cs (Enum.Define): Set obsolete context here.
11488 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11491 - FindDocumentedMember() now expects 1) paramList as null
11492 when "we don't have to check the number of parameters" and
11493 2) Type.EmptyTypes when "there is no arguments".
11494 - Introduced FoundMember struct to hold the exact type which was
11495 used to find the documented member (the above change broke
11496 test-xml-044; it might be better just to use DeclaringType than
11497 what MS does, like this change does, but it depends on usage.)
11499 2005-12-05 Atsushi Enomoto <atsushi@ximian.com>
11501 * doc.cs : documented member might be from DeclaringType for nested
11502 types. Fixed bug #76782.
11504 2005-12-03 Ben Maurer <bmaurer@ximian.com>
11506 * anonymous.cs: Have the param code handle leaving copies on the
11507 stack etc. Allows anonymous params to take part in the assignment
11508 code (++, +=, etc). Fixes bug #76550
11510 * expression.cs: Handle the prepare_for_load/leave_copy by passing
11511 it down to the anon code.
11513 * iterators.cs: Use dummy var here
11515 * codegen.cs: Handle new vars
11517 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11520 * class.cs (MethodData.Define): Set proper Obsolete context.
11522 * ecore.cs (FieldExpr.ResolveMemberAccess): Don't check [Obsolete] in
11524 (FieldExpr.DoResolve): Ditto.
11526 2005-12-01 Marek Safar <marek.safar@seznam.cz>
11529 * class.cs (MethodCore.DoDefineParameters): Test [Obsolete] only when
11530 parent is not obsolete.
11532 2005-12-01 Atsushi Enomoto <atsushi@ximian.com>
11534 * doc.cs : (FindDocumentedMember) find parameterless members first
11535 and get CS0419 in the early stage. Fixed first case of bug #76727.
11537 2005-11-30 Marek Safar <marek.safar@seznam.cz>
11540 * ecore.cs (Expression.ResolveAsConstant): Report constant error only when
11541 no error was reported.
11543 *expression.cs (Binary.DoResolve): left can be null.
11545 2005-11-22 Marek Safar <marek.safar@seznam.cz>
11548 * class.cs (MethodData.Emit): Parameters should be labeled first.
11550 2005-11-21 Marek Safar <marek.safar@seznam.cz>
11553 * parameter.cs (Parameter.ApplyAttributeBuilder): Fixed `ref' detection.
11555 2005-11-18 Marek Safar <marek.safar@seznam.cz>
11557 * attribute.cs (AreParametersCompliant): Moved to Parameter.
11559 * class.cs (MethodCore): Parameter clean up.
11560 (IMethodData): Added ParameterInfo.
11561 (MethodData): Parameter clean up.
11562 (Indexer.Define): Parameter clean up.
11574 * typemanager.cs: Parameter clean up.
11576 * delegate.cs (Define): Get rid of duplicated code.
11578 * expression.cs (ParameterReference): Removed useless parameters
11580 (Invocation): Ditto.
11582 * parameter.cs (ParamsParameter): New class, params specialization.
11583 (ArglistParameter): Attemp to separate arglist.
11584 (Parameter): Refactored to be reusable and faster.
11585 (Parameter.Modifier): Made understandable.
11586 (Parameters): Changed to be used as a class for `this' assembly
11587 parameters. Refactored to use new specialized classes.
11589 * support.cs (ParameterData): Added Types property.
11590 (InternalParameters): Deleted.
11592 2005-08-20 Martin Baulig <martin@ximian.com>
11594 Merging this patch from GMCS to fix #75867.
11596 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
11597 scope if we don't already have it.
11599 2005-11-17 Martin Baulig <martin@ximian.com>
11602 (CaptureContext.EmitMethodHostInstance): Use `Ldarg_0' if we
11603 inherit the scope from our parent. Fixes #76653.
11605 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11607 * doc.cs : the previous patch does not actually fix the bug.
11608 PropertyInfo override check is now implemented and really fixed it.
11609 * expression.cs : Invocation.IsAncestralType() is used from doc.cs.
11611 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11613 * doc.cs : apply "override filter" also to properties.
11616 2005-11-16 Atsushi Enomoto <atsushi@ximian.com>
11618 * doc.cs : renamed FindMembers() to FindMethodBase(). For interfaces,
11619 no need to check overrides. For classes, omit those results from
11620 interfaces since they must exist in the class. Fixed bug #76726.
11622 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11624 * typemanager.cs : (GetFullNameSignature) differentiate indexers
11625 with different parameters. Fixed the second problem in #76685.
11627 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11629 * doc.cs : (FindDocumentedMember) pass invocation_type as well (to
11630 get expected 'protected' access in CheckValidFamilyAccess()).
11633 2005-11-15 Atsushi Enomoto <atsushi@ximian.com>
11635 * doc.cs : (GenerateTypeDocComment) Fields could be FixedField.
11636 Fixed bug #76705. CS1569 was incorrectly commented out.
11638 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11640 * doc.cs : use Invocation.IsOverride() to do real override check.
11641 * expression.cs : made Invocation.IsOverride() internal.
11643 2005-11-14 Atsushi Enomoto <atsushi@ximian.com>
11645 * doc.cs : use TypeManager.FindMembers() instead of (possible)
11646 TypeBuilder.FindMembers() and filter overriden base members out.
11649 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11651 * doc.cs : ref/out parameters are represented as '@' (instead of
11652 '&' in type FullName). Fixed bug #76630 (additionally crefs).
11654 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11656 * doc.cs : when there was no '.' in cref to methods in doc comment,
11657 then parameters were missing in the output. Fixed bug #76691.
11659 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11661 * driver.cs : don't output docs when there is an error.
11664 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11667 Now it should detect indexers. Fixed primary concern in bug #76685.
11668 Fixed CS0419 message to not show the identical member signature in
11671 2005-11-13 Atsushi Enomoto <atsushi@ximian.com>
11673 * doc.cs : (FindDocumentedMember) use TypeManager.MemberLookup()
11674 instead of Type.FindMembers() since it does not handle events.
11677 2005-11-12 Gert Driesen <drieseng@users.sourceforge.net>
11679 * codegen.cs: Fixed typo (speficied -> specified).
11681 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11684 * doc.cs (FindDocumentedTypeNonArray): Don't resolve again.
11686 2005-11-11 Marek Safar <marek.safar@seznam.cz>
11688 * attribute.cs: Changed error message.
11690 * cs-tokenizer.cs: One more check.
11692 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11694 * statement.cs (Block.Resolve): Ignore empty statement.
11696 2005-11-10 Marek Safar <marek.safar@seznam.cz>
11698 * report.cs: Made error/warning methods more strict to avoid
11701 * anonymous.cs, attribute.cs, class.cs, codegen.cs, constant.cs,
11702 convert.cs, cs-parser.jay, cs-tokenizer.cs, decl.cs, delegate.cs,
11703 doc.cs, driver.cs, ecore.cs, expression.cs, location.cs,
11704 namespace.cs, parameter.cs, statement.cs, typemanager.cs: Updated.
11706 2005-11-08 Marek Safar <marek.safar@seznam.cz>
11708 * attribute.cs (Attribute.GetCoClassAttributeValue): New method.
11709 (AttributeTester.GetCoClassAttribute): Get CoClassAttribute.
11711 * class.cs (TypeContainer.IsComImport): New property.
11712 (Constructor.Define): Create proper ctor for ComImport types.
11714 * expression.cs (New.CheckComImport): Fixed.
11716 2005-11-07 Miguel de Icaza <miguel@novell.com>
11718 * anonymous.cs (CaptureContext.AddParameterToContext): The fact
11719 that a parameter has been captured does not mean that we do not
11720 have to do the rest of the processing. This fixes the second part
11721 of #76592. If there was another anonymous method capturing
11722 values in the past, the Scope would never be set for the second
11723 method that captured the same parameter.
11725 (CaptureContext.EmitAssignParameter): When `leave_copy' is passed,
11726 properly manipulate the stack. Second part of fix for #76592.
11728 * expression.cs (New): Add support for invoking "new" on
11729 interfaces that have been flagged with the ComImport attribute and
11730 the CoClass. Fixes #76637
11732 * statement.cs (Try.DoEmit): When a variable is captured, do not
11733 try to emit the vi.LocalBuilder variable as it has been captured.
11734 Create a temporary variable and store the results on the
11735 FieldBuilder. Fixes #76642
11737 2005-11-07 Marek Safar <marek.safar@seznam.cz>
11739 * class.cs (CheckPairedOperators): Made compilable with csc 2.0.
11741 * ecore.cs (InstanceResolve): Fixed CS1540 detection.
11743 * expression.cs (Binary.DoResolve): Added && optimalization.
11745 * typemanager.cs (AddUserType): Removed useless argument.
11747 2005-11-04 Marek Safar <marek.safar@seznam.cz>
11749 * statement.cs (Block.variables): Uses ListDictionary.
11751 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11754 * class.cs (PartialContainer.EmitType): Customized to emit
11755 security attributes.
11756 (ClassPart.ApplyAttributeBuilder): Transform security attribute
11757 for partial classes.
11759 2005-11-03 Marek Safar <marek.safar@seznam.cz>
11762 * expression.cs (ElementAccess.DoResolveLValue): Fixed buffer
11763 access has to be fixed.
11765 * typemanager.cs (IsUnmanagedType): Wrong common field type.
11767 2005-11-01 Marek Safar <marek.safar@seznam.cz>
11770 * ecore.cs (NullCast.Reduce): Implemented.
11772 * expression.cs (ArrayCreation.CheckIndices): Correcly check
11775 * statement.cs (SwitchLabel.ResolveAndReduce): Catch null
11777 (Foreach.Resolve): Catch null properly.
11779 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11781 * cs-tokenizer.cs: Warning text fix.
11783 * driver.cs: AllWarningNumbers exposed on public interface.
11785 * report.cs (): Reviewed warning numbers.
11786 (IsValidWarning): Use binary search.
11788 2005-10-29 Marek Safar <marek.safar@seznam.cz>
11790 * driver.cs: Implemeted resource visibility.
11791 (Resources): New class for code sharing between /res: and
11794 2005-10-28 Marek Safar <marek.safar@seznam.cz>
11797 * cfold.cs (ConstantFold.BinaryFold): Implemented null cast
11800 * convert (Convert.ImplicitReferenceConversion): NullCast holds
11803 * ecore.cs (NullCast): Child is contant only.
11805 * literal.cs (NullLiteral.Reduce): null can be converted to any
11808 2005-10-28 Kornél Pál <kornelpal@hotmail.com>
11810 * driver.cs: Use Encoding.Default as default code page instead
11813 2005-10-27 Raja R Harinath <rharinath@novell.com>
11816 * expression.cs (Invocation.Error_InvalidArguments): Handle
11817 __arglist parameters.
11818 (Invocation.VerifyArgumentsCompat): Likewise.
11819 * support.cs (ReflectionParameters.GetSignatureForError): Print
11820 __arglist parameters.
11821 (InternalParamters.GetSignatureForError): Likewise.
11822 * parameter.cs (Parameters.GetSignatureForError): Likewise.
11824 2005-10-26 Marek Safar <marek.safar@seznam.cz>
11826 * attribute.cs (GetPropertyValue): Made public.
11828 * codegen.cs (AssemblyClass): ResolveClsCompliance renamed to
11830 Add new property WrapNonExceptionThrows to handle 2.0 assembly
11832 (AssemblyClass.Emit): Emit RuntimeCompatibilityAttribute when it
11835 * driver.cs: Reflect method name change.
11837 * statement.cs (Try.Resolve): Warn when try has both general
11838 exception handlers.
11840 * typemanager.cs: runtime_compatibility_attr_type new predefined
11843 2005-10-26 Raja R Harinath <harinath@gmail.com>
11846 * pending.cs (InterfaceMethod): Allow tm.args [i] to be null --
11847 treat it as an empty parameter list.
11849 2005-10-26 Raja R Harinath <rharinath@novell.com>
11852 * ecore.cs (SimpleName.DoSimpleNameResolve): Make fall-back
11853 ResolveAsTypeStep silent.
11854 * statement.cs (Block.AddConstant): Mark block as used.
11855 (Block.ResolveMeta): Avoid piling on error messages
11856 if a constant initializer resolution fails.
11858 2005-10-25 Raja R Harinath <rharinath@novell.com>
11860 * namespace.cs (RootNamespace.VerifyUsingForAll, Namespace.VerifyUsing):
11862 (NamespaceEntry.VerifyAllUsing): New.
11863 (NamespaceEntry.AliasEntry.Resolve): New. Handles common error
11864 behaviour. Delegates actual resolution of alias to ...
11865 (NamespaceEntry.DoResolve): ... this. Renamed from Resolve.
11866 (NamespaceEntry.LocalAliasEntry, NamespaceEntry.ExternAliasEntry):
11868 * driver.cs (Driver.MainDriver): Update.
11870 * namespace.cs (NamespaceEntry.DefineNamespace): Remove.
11871 (NamespaceEntry.SymbolFileID): Make into a on-demand computed
11873 (Namespace.DefineNamespaces, RootNamespace.DefineNamespacesForAll):
11875 * symbolwriter.cs (SymbolWriter.Initialize): Don't call
11876 RootNamespace.DefineNamespacesForAll.
11878 2005-10-24 Raja R Harinath <harinath@gmail.com>
11880 * typemanager.cs (assemblies, external_aliases, modules)
11881 (AddAssembly, AddExternAlias, AddModule GetAssemblies, Modules)
11882 (ComputeNamespaces, GetRootNamespace): Remove extra staging
11883 overhead. Move resposibility ...
11884 * namespace.cs (GlobalRootNamespace): ... here. Update to changes.
11885 * driver.cs, attribute.cs, codegen.cs: Update to changes.
11887 2005-10-23 Raja R Harinath <harinath@gmail.com>
11889 * namespace.cs (RootNamespace.all_namespaces): Renamed from
11890 cached_namespaces. Improve usage.
11891 (RootNamespace.Reset, RootNamespace.RegisterNamespace)
11892 (RootNamespace.VerifyUsingForAll, RootNamespace.DefineNamespacesForAll):
11893 Move from GlobalRootNamespace and simplify.
11894 (RootNamespace.Global): Make instance variable.
11895 (RootNamespace.RootNamespace): Add "alias name" parameter.
11896 (GlobalRootNamespace): Simplify drastically.
11897 (Namespace.Lookup): Don't use GetNamespace.
11898 * typemanager.cs (GetRootNamespace): Rename from
11899 ComputeNamespaceForAlias.
11900 (NamespaceClash): Use Global.IsNamespace instead of GetNamespace.
11902 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11904 * anonymous.cs (AnonymousContainer): Don't crash when container
11907 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11909 * expression.cs (Binary.DoResolve): Warn when comparing same
11912 2005-10-23 Marek Safar <marek.safar@seznam.cz>
11915 * expression.cs (Binary.DoResolve): It looks like there are no
11916 convetsion rules in enum context.
11918 2005-10-19 Carlos Alberto Cortez <calberto.cortez@gmail.com>
11920 Add support for extern alias qualifiers.
11921 * typemanager.cs: Move some LookupTypeReflection code
11922 to namespace.cs, to have cleaner code. Added some methods
11923 to help us keep track of the extern aliased references.
11924 * driver.cs: Add suport for extern alias assemblies on command
11925 line and check for their warnings/errors. Also keep track of the
11926 extern aliased assemblies.
11927 * namespace.cs: Move the global functionality of Namespace
11928 to GlobalRootNamespace/RootNamespace. Now the global namespace
11929 is GlobalRootNamespace.Globa. Also the code moved from
11930 typemanager.cs lives in GlobalRootNames.cs/RootNamespace.cs.
11931 Finally added LocalAliasEntry (AliasEntry before) and
11932 ExternAliasEntry, to handle alias statements.
11933 * cs-parser.jay: Add support in the grammar for extern alias
11935 * doc.cs, delegate.cs, expression.cs ecore.cs, symbolwriter.cs:
11936 Update callings to Namespace (now in GlobalRootNamespace).
11938 2005-10-18 Raja R Harinath <rharinath@novell.com>
11941 * class.cs (TypeContainer.DefineType): Move updating of
11942 topological sort earlier in the code.
11943 * decl.cs (DeclSpace.ResolveBaseTypeExpr): Don't use TypeBuilder.
11945 2005-10-18 Marek Safar <marek.safar@seznam.cz>
11948 * cfold.cs (BinaryFold): Reduce constant in enum conversion.
11950 * constant.cs (Constant.TryReduce): Moved from Cast class.
11951 (Reduce): Made little bit more OO and fixed missing conversions.
11953 * ecore.cs (Reduce): Implemented.
11954 (Binary.EnumLiftUp): New method to upgrade values to enum values.
11956 * literal.cs (Reduce): Implemented.
11958 * class.cs: Reverted Miguel's wrong commit.
11960 2005-10-14 Miguel de Icaza <miguel@novell.com>
11962 * ecore.cs (GetMemberType): Report the correct mapping for the MemberCore
11964 2005-10-14 Atsushi Enomoto <atsushi@ximian.com>
11966 * cs-parser.jay, expression.cs : CS0214 was missing error location
11967 for constants. Fixed bug #76404.
11969 2005-10-11 Marek Safar <marek.safar@seznam.cz>
11972 * convert.cs (ExplicitConversionCore): Fixed object->enum
11975 2005-10-10 Raja R Harinath <rharinath@novell.com>
11977 * ecore.cs (PropertyExpr.Emit): Use Invocation.EmitCall to emit
11978 InstanceExpression.
11979 (PropertyExpr.EmitCall): Likewise.
11980 * expression.cs (Invocation.EmitArguments): Handle case where
11982 (Invocation.EmitCall): Avoid allocating temporary variable if
11983 there are no arguments.
11985 2005-10-07 Raja R Harinath <rharinath@novell.com>
11988 * convert.cs (ImplicitConversionStandard): Move conversion of
11989 void* to arbitrary pointer types ...
11990 (ExplicitConversionStandard): .. here.
11991 * ecore.cs (Expression.Error_ValueCannotBeConverted): Fix CS0266
11992 error to always print typenames.
11994 2005-10-07 Raja R Harinath <rharinath@novell.com>
11996 * convert.cs (GetConversionOperator): Rename from
11997 GetConversionOperators. Move operator selection code from ...
11998 (UserDefinedConversion): ... here.
12000 2005-10-06 Marek Safar <marek.safar@seznam.cz>
12002 * convert.cs (ExplicitConversionCore): Removed duplicate enum
12005 2005-10-05 Marek Safar <marek.safar@seznam.cz>
12007 * assign.cs (Assign.DoResolve): Error method changed.
12009 * cfold.cs (DoConstantNumericPromotions): Error method changed.
12011 * const.cs (ResolveValue): Reset in_transit immediately.
12013 * constant.cs: Error method changed.
12015 * convert.cs: Removed useless location parameter.
12016 (ExplicitNumericConversion): Don't do double enum check.
12017 (ExplicitConversionCore): Renamed from ExplicitConversion.
12018 (ExplicitUnsafe): Extracted from ExplicitConversion.
12019 (ExplicitConversion): Uses for error reporting.
12021 * ecore.cs (Error_ValueCannotBeConverted): More logic for more
12023 (ResolveBoolean): Uses common error method.
12024 (CastToDecimal): Get rid of ec.
12025 (CastFromDecimal): Optimized.
12026 (ConvCast): Get rid of ec.
12028 * enum.cs (ResolveValue): Reset in_transit immediately.
12029 (Emit): Return after first error.
12031 * expression.cs: Convert changes.
12033 * literal.cs: Error method changed.
12035 * statement.cs: Error method changed.
12037 2005-10-03 Raja R Harinath <rharinath@novell.com>
12039 * support.cs (SeekableStreamReader.Position): Don't error out when
12040 the requested position is just beyond the end of the current
12043 2005-09-28 Raja R Harinath <rharinath@novell.com>
12045 * support.cs (SeekableStreamReader): Simplify drastically. Don't
12046 try to keep in sync with the byte count of the underlying Stream.
12047 However, this limits us to a window size of 2048 characters: i.e.,
12048 the maximum lookahead of our lexer/parser can be 2048 characters.
12050 2005-09-28 Marek Safar <marek.safar@seznam.cz>
12053 * driver.cs: Fix compilation files with full root path.
12055 2005-09-25 Miguel de Icaza <miguel@novell.com>
12057 * report.cs (SymbolRelatedToPreviousError): Format the output so
12058 it does not use an open parenthesis that is never closed.
12060 * driver.cs: Follow coding guidelines
12062 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12065 * const.cs (Const.ResolveValue): Check for assigning non-null
12066 value to reference type.
12068 2005-09-27 Marek Safar <marek.safar@seznam.cz>
12070 * anonymous.cs: Implemented ExprClassName.
12072 * assign.cs (Assign.DoResolve): Don't chrash when type is not
12075 * attribute.cs (ResolveArguments): Enabled MethodImplOptions
12078 * class.cs (StaticClass.DefineContainerMembers): Report protected
12081 * codegen.cs: if(ed) PRODUCTION.
12083 * convert.cs (Error_CannotImplicitConversion): Better error
12086 * cs-parser.jay: More error checks.
12088 * cs-tokenizer.cs (consume_identifier): Fixed Miguel's revert.
12090 * driver.cs (CSCParseOption): Enabled wrong option check.
12092 * ecore.cs (Expression.ExprClassName): Turned to property.
12093 (MemberExpr.CheckIntermediateModification): For checking boxed
12094 value types modification.
12096 * statement.cs (Fixed.Resolve): Expression type must be
12097 convertible to fixed type.
12098 (CollectionForeach.GetEnumeratorFilter,TryType):
12099 Small refactoring for easier error checking.
12101 2005-09-26 Marek Safar <marek.safar@seznam.cz>
12103 * attribute.cs (Attribute.Resolve): Check Obsolete attribute for
12106 * class.cs (GeneratedBaseInitializer): New class for customization
12107 compiler generated initializers.
12108 (MemberBase.DoDefine): Check Obsolete attribute here.
12109 (FieldMember.DoDefine): Ditto.
12111 * const.cs (ExternalConstant.CreateDecimal): Builder for decimal
12114 * decl.cs (MemberCore.EmitContext): Returns valid current ec.
12115 (MemberCore.GetObsoleteAttribute): Removed argument.
12116 (MemberCore.CheckObsoleteness): Obsolete attributes are hierarchic.
12117 (MemberCore.CheckObsoleteType): New helper.
12121 * statement.cs: Updates after MemberCore changes.
12123 * ecore.cs (TypeExpr.ResolveType): Check type obsoleteness here.
12124 (FieldExpr.ResolveMemberAccess): Fixed decimal constants checks.
12126 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't check
12127 obsolete attribute for compiler construct.
12128 (As.DoResolve): Cache result.
12130 * iterators.cs (Define_Constructor): Use GeneratedBaseInitializer.
12132 2005-09-26 Raja R Harinath <rharinath@novell.com>
12135 * expression.cs (This.VerifyFixed): In a value type T, the type of
12136 'this' is T&, iow, 'this' is either an out or ref parameter. In a
12137 value type R, 'this' is treated as a value parameter.
12139 2005-09-22 Miguel de Icaza <miguel@novell.com>
12141 * statement.cs (Lock): Use the TemporaryVariable class instead of
12142 manually using local variables as those do not work when variables
12145 * ecore.cs: Moved the TemporaryVariable class from being a nested
12146 class inside Foreach to be a public class that can be employed in
12149 2005-09-19 Marek Safar <marek.safar@seznam.cz>
12151 * cs-parser.jay: interface_accessors replaced by
12152 accessor_declarations.
12154 * ecore.cs, literal.cs, statement.cs: NullLiteral holds null
12157 * statement.cs (GotoCase.Resolve): Convert null constant to
12159 (SwitchLabel.ResolveAndReduce): Ditto.
12160 (SwitchLabel.NullStringCase): Custom null stamp.
12161 (Switch.SimpleSwitchEmit): Fix from NullLiteral to NullStringCase.
12163 typemanager.cs (CSharpSignature): Don't skip first argument
12166 2005-09-18 Miguel de Icaza <miguel@novell.com>
12168 * driver.cs: Set InEmacs based on the environment variable EMACS.
12170 * location.cs (InEmacs): in this mode, do not report column
12171 location as it confuses Emacs.
12173 2005-09-16 Marek Safar <marek.safar@seznam.cz>
12175 * cfold.cs, constant.cs, convert.cs, ecore.cs,
12176 expression.cs, iterators.cs, literal.cs: Store constants and
12179 * class.cs (MemberBase.ShortName): Pass location.
12181 * cs-parser.jay: Some location fixes.
12183 * ecore.cs (Expression.Location): Made virtual.
12185 2005-09-05 Miguel de Icaza <miguel@novell.com>
12187 * expression.cs (Cast.TryReduce): Only reduce to an EnumConstant
12188 if the underlying types are the same, otherwise we need to produce
12189 code that will do the proper cast.
12191 This was exposed by Marek's constant rewrite which produced
12192 invalid code for the call site:
12194 enum X : long { a }
12195 void Method (X v) {}
12199 This fixes test-49.cs
12201 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12203 * attribute.cs : (Attribute.IsValidArgumentType): array of string/
12204 Type/Object should be allowed as well. Fixed bug #75968.
12206 2005-09-05 Atsushi Enomoto <atsushi@ximian.com>
12208 * expression.cs : (Binary.DoResolve): when one is enum constant and
12209 another is constant 0, then return enum one *as enum type*.
12212 2005-09-02 Raja R Harinath <rharinath@novell.com>
12214 * attribute.cs (GetMarshal): Work even if "DefineCustom" is
12218 * ecore.cs (SimpleNameResolve.DoSimpleNameResolve): Disable
12219 flow-branching for LocalVariableReferences in case we were invoked
12220 from a MemberAccess.
12221 * expression.cs (LocalVariableReference.VerifyAssigned): New.
12223 (LocalVariableReference.DoResolveBase): ... this.
12224 (MemberAccess.Resolve): Do the check that was disabled during
12227 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12230 (PartialContainer.Create): check abstract/sealed/static strictly
12231 but abstract/sealed can exist only at one side. Fixed bug #75883.
12233 2005-09-01 Kornél Pál <kornelpal@hotmail.com>
12236 * attribute.cs (Attribute.GetMarshal): If ArraySubType is not
12237 specified, don't default to UnmanagedType.I4.
12239 2005-09-01 Atsushi Enomoto <atsushi@ximian.com>
12241 * expression.cs : conditional operator should check possibly
12242 incorrect assign expression. Fixed bug #75946.
12244 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12246 * cs-tokenizer.cs, cs-parser.jay, driver.cs, support.cs :
12247 Reverting the change. gmcs is much complex than mcs on this matter.
12249 2005-08-31 Atsushi Enomoto <atsushi@ximian.com>
12251 * cs-tokenizer.cs : To read another token ahead of the actual
12252 consumption, use new SavedToken and cache token instead of moving
12253 back the stream with SeekableStreamReader (it seemed problematic).
12255 driver.cs : Thus use StreamReader directly.
12256 * support.cs : Thus removed SeekableStreamReader.
12258 2005-08-30 Raja R Harinath <rharinath@novell.com>
12261 * anonymous.cs (ScopeInfo.MakeFieldName): New helper.
12262 (ScopeInfo.EmitScopeType): Use it to construct field names from
12263 names of captured locals.
12266 * ecore.cs (BoxedCast.BoxedCast) [1-argument variant]: Remove.
12267 * convert.cs (ImplicitReferenceConversion, TryImplicitIntConversion):
12268 Pass 'target_type' to BoxedCast. Don't default to 'object'.
12269 (ExplicitConversion): Remove enum cases already handled by
12270 implicit conversion. Move implicit conversion check to the beginning.
12271 * delegate.cs (DelegateCreation.ResolveMethodGroupExpr): Update.
12272 * expression.cs (ArrayCreation.EmitDynamicInitializers):
12273 Don't treat System.Enum as a struct.
12275 2005-08-30 Jb Evain <jbevain@gmail.com>
12277 * attribute.cs: handles as expression in parameters.
12279 2005-08-30 Raja R Harinath <rharinath@novell.com>
12282 * class.cs (TypeContainer.VerifyClsName): Don't use a
12283 PartialContainer when verifying CLS compliance.
12284 (AbstractPropertyEventMethod): Set Parent here, ...
12285 (PropertyMethod): ... not here.
12287 2005-08-30 Atsushi Enomoto <atsushi@ximian.com>
12289 * attribute.cs : escaped attribute name should not be allowed to be
12290 resolved (e.g. @class as classAttribute). Fixed bug #75930.
12292 2005-08-29 Raja R Harinath <rharinath@novell.com>
12295 * convert.cs (ImplicitStandardConversionExists): Allow zero also
12296 when converting a long constant to unsigned long.
12297 * expression.cs (Invocation.OverloadResolve): Add sanity check to
12298 detect where IsApplicable and VerifyArgumentsCompat disagree.
12300 2005-08-29 Raja R Harinath <rharinath@novell.com>
12301 and Carlos Alberto Cortez <carlos@unixmexico.org>
12304 * class.cs (TypeContainer.CanElideInitializer): New helper.
12305 (TypeContainer.EmitFieldInitializers): Use it to determine if we
12306 can safely emitting the initializer of a field.
12308 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12310 * statement.cs : (Continue.Resolve()) Unlike break, continue is not
12311 allowed inside a switch (without loop). Fixed bug #75433.
12313 2005-08-26 Kornél Pál <kornelpal@hotmail.com>
12315 * AssemblyInfo.cs: Using Consts.MonoVersion instead of MonoVersion.cs.
12316 * mcs.exe.sources: Using Consts.MonoVersion instead of MonoVersion.cs.
12318 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12320 * driver.cs : kinda reverting the default encoding changes (not exact
12321 revert since I noticed that "codepage:reset" might not work fine).
12323 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12325 * class.cs : (AbstractPropertyEventMethod) SetupName() now takes
12326 Location. Now getter and setter store location correctly.
12327 (errors/cs0111-12.cs now reports the expected location.)
12329 2005-08-25 Atsushi Enomoto <atsushi@ximian.com>
12331 * driver.cs : Use default encoding on the environment.
12332 Removed (now that) extra parameter for SeekableStreamReader.
12333 * support.cs : (SeekableStreamReader) third .ctor() argument for
12334 StreamReader is not required (always true). preamble size could
12335 be acquired in simpler and safe way.
12337 2005-08-24 Atsushi Enomoto <atsushi@ximian.com>
12339 * cs-parser.jay: report CS0642 at warning level 3
12340 and report CS0642 for an if else statement also
12341 fixes bug #74745. Patch by John Luke (and a bit
12343 Removed extra CS0642 warning check for "while",
12345 * statement.cs: In Block.Resolve(), CS0642 check
12346 is reimplemented to check a sequence of an empty
12347 statement and a block.
12349 Both fix bug #66777.
12351 2005-08-24 Marek Safar <marek.safar@seznam.cz>
12353 * attribute.cs (GetMethodObsoleteAttribute): Disabled obsolete properties
12354 detection until I fix it.
12356 * cs-tokenizer.cs: Changed error message.
12358 * cs-parser.jay: Fixed 2 error locations.
12360 * ecore.cs (Error_TypeDoesNotContainDefinition): Share error message.
12361 (PropertyExpr.Error_PropertyNotFound): First attempt to detect non C#
12364 * enum.cs (GetSignatureForError): Fixed.
12366 * expression.cs (Invocation.IsSpecialMethodInvocation): Improved special
12370 * typemanager.cs (RegisterProperty): Removed.
12372 * statement.cs (CheckInvariantMeaningInBlock): Changed error message.
12374 2005-08-24 Raja R Harinath <rharinath@novell.com>
12377 * expression.cs (ArrayAccess.EmitLoadOpcode): Emit ldelem.i for pointers.
12378 (ArrayAccess.GetStoreOpcode): Return stelem.i for pointers.
12380 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12382 * expression.cs : tiny fix is required for not warning positive ulong.
12385 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12387 * expression.cs : add CS0652 check for constant and integral
12388 expression. Fixed bug #53974.
12390 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12392 * expression.cs : in DoNumericPromotions(), check if there is implicit
12393 conversion overload for string (to check CS0034). Fixed bug #52492.
12395 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12397 * cs-tokenizer.cs : Check newline in char constant. Fixed bug #75245.
12399 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12401 * ecore.cs : report location when it is *not* Null.
12403 2005-08-23 Atsushi Enomoto <atsushi@ximian.com>
12409 Added OmitStructFlowAnalysis to EmitContext to handle CS0165 check
12410 correctly. Fixed bug #75721.
12412 2005-08-23 Raja R Harinath <rharinath@novell.com>
12414 * support.cs (SeekableStreamReader.Position): Avoid an expensive
12415 loop that performs 'min (pos, char_count)'.
12418 * expression.cs (Unary.ResolveOperator): Don't discard implicit
12419 converted value in Operator.OnesComplement.
12421 2005-08-22 Ben Maurer <bmaurer@ximian.com>
12423 * anonymous.cs: If the anon method is pulled into a helper class,
12424 it needs to be `internal' not `private'. Fixes runtime behavior on
12427 2005-08-20 Martin Baulig <martin@ximian.com>
12429 * anonymous.cs (CaptureContext.CaptureThis): Create the topmost
12430 scope if we don't already have it.
12432 * expression.cs (Invocation.EmitCall): Use `ec.EmitThis ()' rather
12433 than `ig.Emit (OpCodes.Ldarg_0)' to make it work inside iterators;
12436 2005-08-17 Marek Safar <marek.safar@seznam.cz>
12439 * decl.cs (DeclSpace.VerifyClsCompliance): Skip when collision object
12440 is a partial class.
12442 2005-08-16 Marek Safar <marek.safar@seznam.cz>
12444 The big constants rewrite
12445 Fix #75746, #75685 and more
12446 As a side effect saved 1MB for MWF ;-)
12448 * attribute.cs (GetAttributeArgumentExpression): Use ToType, GetTypedValue.
12449 (GetMarshal, GetMethodImplOptions, GetLayoutKindValue): Values are not
12450 enum based for corlib compilation.
12452 * cfold.cs (BinaryFold): Convert operand for enum additions. Fixed enum
12455 * class.cs (FixedField.Define): Use ResolveAsConstant.
12457 * const.cs (IConstant): Interface constants and enums.
12458 (Const.ResolveValue): New method for constant resolvning.
12459 (ExternalConstant): Constants from imported assemblies.
12461 * constant.cs (Constant.GetTypedValue): Used to get constant with forced
12462 conversion; like enums.
12463 (Constant.ToType): Converts this constant to different type.
12464 (Constant.Increment): Adds 1.
12466 * convert.cs (ImplicitConversionRequired): Simplified.
12468 * cs-parser.jay: Create EnumMember directly.
12470 * decl.cs (MemberCore.CheckObsoleteness): Checks for ObsoleteAttribute presence.
12472 * doc.cs (GenerateEnumDocComment): Removed.
12474 * ecore.cs (Expression.ResolveAsConstant): New constant specific method.
12475 (ConvertIntLiteral): Removed.
12476 (FieldExpr.ResolveMemberAccess): Refactored to remove constant specific if(s).
12478 * enum.cs (EnumMember): Implement IConstant.
12479 (Enum.IsValidEnumConstant): Removed.
12480 (Enum.GetNextDefaultValue): Removed.
12481 (Enum.FindMembers): Updated.
12482 (Enum.GenerateDocComment): Iterate enum members.
12484 * expression.cs (Cast.TryReduce): Handle enums correctly.
12485 (New.Constantify): Made public.
12486 (MemberAccess.DoResolve): Removed contant specific if(s).
12488 * literal.cs (NullLiteral): Implement new abstract methods.
12490 * statement.cs (GotoCase.Resolve): Use new constant methods.
12491 (SwitchLabel.ResolveAndReduce): Use new constant methods.
12493 * typemanager.cs (LookupEnum): Removed.
12494 (IsEnumType): Fixed to work with corlib.
12495 (RegisterConstant): Removed.
12496 (LookupConstant): Removed.
12497 (GetConstant): Changed to work with IConstant.
12499 2005-08-04 Atsushi Enomoto <atsushi@ximian.com>
12501 * location.cs : Fixed overflown (>255) column number.
12503 2005-08-03 Raja R Harinath <rharinath@novell.com>
12505 First cut of the qualified-alias-member feature.
12506 * cs-tokenizer.cs (Tokenizer.is_punct): Recognize the double-colon
12508 * cs-parser.jay (DOUBLE_COLON): New token.
12509 (namespace_or_type_name): Add rule for recognizing
12510 qualified-alias-members.
12511 (primary_expression): Likewise.
12512 (element_access): Allow QualifiedAliasMember as a possible
12513 type-bearing expression.
12514 (local_variable_type, local_variable_pointer_type): Likewise.
12515 * namespace.cs (NamespaceEntry.LookupAlias): New. Looks up
12516 aliases in the current and enclosing namespace declarations.
12517 (NamespaceEntry.UsingAlias): Add CS0440 warning.
12518 * decl.cs (MemberName.is_double_colon): New.
12519 (MemberName.MemberName): Add new constructor for alias-member.
12520 (MemberName.GetTypeExpression): Generate QualifiedAliasMember too.
12521 * expression.cs (QualifiedAliasMember): New expression type.
12523 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12525 * location.cs : it borked when no argument was specified.
12527 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12529 * location.cs : tiny ToString() format fix.
12531 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12533 * statement.cs : oops, it was missing.
12535 2005-08-02 Atsushi Enomoto <atsushi@ximian.com>
12537 A set of fixes for precise line/column location.
12540 "token" field now holds a file/line "delta", a line number offset
12541 from the segment, and a column number. See also:
12542 http://lists.ximian.com/pipermail/mono-devel-list/2004-
12543 December/009508.html
12544 Removed static IsNull. Use instance IsNull property instead.
12545 * cs-tokenizer.cs :
12546 For some tokens it stores Location. For Identifier it stores
12547 LocatedToken which is a pair of string name and location.
12548 Column numbers are adjusted only at getChar().
12550 Use Location.ToString() for reporting (it now contains column).
12552 Largely modified to use LocatedToken instead of
12553 string (IDENTIFIER), and to acquire Location from some tokens.
12554 * namespace.cs, decl.cs, ecore.cs, class.cs, delegate.cs,
12555 iterators.cs, const.cs, anonymous.cs, tree.cs, enum.cs,
12557 Now MemberName holds Location. DeclSpace.ctor() receives Location
12558 as a parameter. Removed extra parameters to all derived classes.
12559 Replaced Location.IsNull() with instance property.
12560 * assign.cs, expression.cs :
12561 Added .ctor() overload that omits Location.
12563 Added "nameEscaped" flag that indicates the identifier was escaped
12564 in the source file. This fixes bug #57047.
12566 2005-08-02 Marek Safar <marek.safar@seznam.cz>
12568 * attribute.cs (AttributeTester.GetImportedIgnoreCaseClsType):
12569 New method, looking for lo-case imported cls type.
12571 * decl.cs (DeclSpace.VerifyClsCompliance): Check CS3005 for types
12574 * driver.cs: Removed VerifyTopLevelNameClsCompliance usage.
12576 * enum (Enum.VerifyClsCompliance): Hardcode non-compliant types.
12578 * typemanager.cs (TypeManager.AllClsTopLevelTypes): Renamed from
12579 all_imported_types.
12580 (TypeManager.LoadAllImportedTypes): Lo-case imported types.
12582 Optimized to save 3.5 MB for SWF compilation.
12584 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12586 * class.cs (AddToTypeContainer): Use inheritance insted of if(s).
12587 (PartialContainer.Create): Moved logic AddToContainer.
12588 (PartialContainer.MarkForDuplicationCheck): Shares name.
12590 * decl.cs (DeclSpace.AddToContainer): Check name collisions at one
12593 * namespace.cs (Namespace.AddDeclSpace): Lazy declspaces
12595 (Namespace.GetSignatureForError): New method.
12597 * tree.cs (Tree.RecordDecl): Moved to AddToContainer.
12598 (RootTypes.AddToTypeContainer): se inheritance insted of if(s).
12600 2005-08-01 Raja R Harinath <rharinath@novell.com>
12603 * ecore.cs (Expression.MemberLookupFailed): Use queried_type for
12604 member lookup rather than qualifier_type, since qualifier_type can
12607 2005-08-01 Marek Safar <marek.safar@seznam.cz>
12609 * enum.cs (Enum.VerifyClsName): Fixed to allow not CLSCompliant
12612 2005-07-31 Miguel de Icaza <miguel@novell.com>
12614 * statement.cs: Copy the local exception into the exception
12615 captured local. Fixes 75674
12617 2005-07-31 Raja R Harinath <harinath@gmail.com>
12620 * expression.cs (Invocation.OverloadResolve): Don't report error
12621 CS1501 if error CS1502 has been reported.
12622 (New.DoResolve): Delegate CS1501 reporting to
12623 Invocation.OverloadResolve.
12626 * statement.cs (Block.CheckInvariantMeaningInBlock): Verify
12627 invariant-meaning-in-block property in an enclosing block if
12630 2005-07-29 Marek Safar <marek.safar@seznam.cz>
12632 * statement.cs (SwitchLabel.ResolveAndReduce): Refactored.
12633 (SwitchLabel.Erorr_AlreadyOccurs): Share error message.
12634 (Switch.CheckSwitch): Just save 50kb for SWF.
12636 2005-07-27 Martin Baulig <martin@ximian.com>
12638 * anonymous.cs (CaptureContext.AddField): Added
12639 `AnonymousContainer am' argument; compute its toplevel scope if
12640 it's not already computed. Fixes #75649.
12642 2005-07-26 Raja R Harinath <rharinath@novell.com>
12645 * class.cs (Constructor.Emit): Reset block to null if the block
12648 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12650 * class.cs (TypeContainer.VerifyMembers): Be compatible in warning 169.
12652 2005-07-25 Marek Safar <marek.safar@seznam.cz>
12654 * class.cs (MethodData.Define): Check whether accessor implementing
12655 interface is public.
12657 * driver.cs (Driver.parse): Try to be smart and check for `MZ' header.
12659 2005-07-22 Marek Safar <marek.safar@seznam.cz>
12662 * namespace.cs (LookupType): Moved same type check to...
12664 * typemanager.cs (LookupTypeReflection): Don't allow to import more types
12665 with the same name.
12667 2005-07-21 Raja R Harinath <rharinath@novell.com>
12669 * namespace.cs (NamespaceLookupType): Avoid a string allocation when we
12670 already found a typebuilder.
12671 * class.cs (MethodCore.IsDuplicateImplementation): Compare
12672 MemberNames, not strings.
12674 * const.cs (Error_ExpressionMustBeConst):
12675 Rename from Error_EpressionMustBeConst.
12676 * const.cs, class.cs, statement.cd: Update.
12678 2005-07-21 Marek Safar <marek.safar@seznam.cz>
12682 * const.cs (Const.LookupConstantValue): Report missing contant expression
12684 (Error_EpressionMustBeConstant): Only one error method.
12686 * class.cs, statement.c: Updated.
12688 2005-07-20 Raja R Harinath <rharinath@novell.com>
12690 * statement.cs (Block.Flags): Add back HasVarargs.
12691 (Block.flags): Make protected.
12692 (ToplevelBlock.HasVarargs): Convert to a property that updates flags.
12694 * typemanager.cs (types, typecontainers, user_types): Remove.
12695 (UserTypes, TypeContainers): Likewise.
12696 (HandleDuplicate, AddDelegateType, AddEnumType): Likewise.
12697 (CleanUp, Reset): Update.
12698 (AddUserType): Combine variants. Now, only updates builder_to_declspace.
12699 (GetNestedType): Use Type.GetNestedType.
12700 (CoreLookupType): Take two arguments, the namespace and the
12701 basename of the type. Update to use the Namespace.Lookup
12703 (InitEnumUnderlyingTypes, InitCoreTypes): Update.
12704 (RealMemberLookup): Use IsNestedChildOf instead of playing with
12705 string concatenation and substring matches.
12706 * class.cs, enum.cs, delegate.cs: Update to changes.
12708 2005-07-20 Marek Safar <marek.safar@seznam.cz>
12710 * constant.cs (Constant.Error_ConstantValueCannotBeConverted): Moved from
12711 Expression and made virtual.
12713 * convert.cs (ImplicitReferenceConversionExists): Skip for value types.
12714 (ImplicitStandardConversionExists): Fixed `byte' typo ?
12716 * ecore.cs (Expression.Error_ConstantValueCannotBeConverted): Moved.
12718 * literal.cs (NullLiteral.Error_ConstantValueCannotBeConverted): Customize
12721 * convert.cs, ecore.cs, enum.cs: Reflect Error_ConstantValueCannotBeConverted
12724 2005-07-18 Marek Safar <marek.safar@seznam.cz>
12727 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Check whether
12728 AssemblyCultureAttribute is not used on executable.
12731 * typemanager.cs: Add System.Reflection.AssemblyCultureAttribute.
12733 2005-07-16 Raja R Harinath <rharinath@novell.com>
12736 * expression.cs (Binary.Warning_UnintendeReferenceComparison):
12737 New. Reports CS0252/CS0253.
12738 Mostly taken from preliminary patch by Duncak Mak.
12739 (Binary.DoResolveOperator): Store results of operator lookup.
12740 Use them to detect if we need to warn about unintended reference
12743 2005-07-15 Raja R Harinath <rharinath@novell.com>
12746 * namespace.cs (Namespace.Lookup): Add back location parameter.
12747 (Namespace.LookupType): Add CS0436 report. Add location parameter.
12748 * delegate.cs, ecore.cs, expression.cs: Update to changes.
12750 * codegen.cs (EmitContext.DeclSpace): Make readonly.
12751 * namespace.cs (Namespace.Lookup): Carve out type lookup into ...
12752 (Namespace.LookupType): ... this.
12753 (NamespaceEntry.GetUsingTable): Allocate only one zero-sized array
12755 * typemanager.cs (LookupTypeReflection): Remove buggy code that
12756 purported to handle pointers.
12757 (char_ptr_type, void_ptr_type): Use GetPointerType rather than
12760 2005-07-15 Marek Safar <marek.safar@seznam.cz>
12762 * expression.cs (MemberAccess.ResolveNamespaceOrType): Don't report nested
12765 2005-07-15 Raja R Harinath <rharinath@novell.com>
12767 * namespace.cs (Namespace.Lookup): Drop location parameter.
12768 (NamespaceEntry.LookupAlias): Remove. Merge into ...
12769 (NamespaceEntry.Lookup): ... this.
12770 (NamespaceEntry.Error_AmbiguousTypeReference):
12771 Move here from DeclSpace.
12772 (NamespaceEntry.LookupNamespaceOrType): Move support for dotted
12774 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): ... here.
12775 * decl.cs (DeclSpace.ErrorAmbiguousTypeReference):
12776 Move to NamespaceEntry.
12777 * delegate.cs, expression.cs: Update to changes.
12779 2005-07-14 Marek Safar <marek.safar@seznam.cz>
12781 * attribute.cs (Attribute.ResolveAttributeType): Renamed from
12782 CheckAttributeType and refactored.
12783 (Attribute.ResolvePossibleAttributeType): Changed to reuse
12784 ResolveAsTypeTerminal error handling.
12785 (ResolveAsTypeTerminal): Introduced because of global attributes extra
12787 (GetSignatureForError): Print errors in same way.
12790 * codegen.cs: Reflect attribute GetSignatureForError change.
12793 * expression.cs: Add silent parameter to ResolveAsTypeStep.
12795 * namespace.cs (UsingEntry): Refactored to make fields private.
12798 statement.cs: Error_UnexpectedKind has extra parameter.
12800 2005-07-14 Raja R Harinath <rharinath@novell.com>
12802 * ecore.cs (IAlias): Remove.
12803 * decl.cs (DeclSpace): Don't derive from IAlias. Remove members
12804 that implement the interface.
12805 * namespace.cs (Namespace): Likewise.
12806 (Namespace.declspaces): Renamed from 'defined_names'.
12807 (Namespace.AddDeclSpace): Renamed from 'DefineName'. Take a
12808 DeclSpace instead of an IAlias.
12809 * tree.cs (Tree.AddDecl): Update.
12811 2005-07-12 Raja R Harinath <rharinath@novell.com>
12813 * statement.cs (Block.Flags); Remove HasVarargs.
12814 (Block.HasVarargs): Move to ToplevelBlock.
12815 (Block.ThisVariable, Block.AddThisVariable): Likewise.
12816 (Block.Variables): Make protected. Initialize variable hashtable
12818 (Block.AddVariable): Update.
12819 (Block.Resolve): Update to changes.
12820 (ToplevelBlock.HasVarargs): New boolean.
12821 (ToplevelBlock.ThisVariable): Move here from Block.
12822 (ToplevelBlock.AddThisVariable): Likewise.
12823 (ToplevelBlock.IsThisAssigned): New. Forwards call to this_variable.
12824 * expression.cs (This.ResolveBase): Update to changes.
12825 (ArglistAccess.DoResolve): Likewise.
12827 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12830 * ecore.cs, class.cs: Use SetAssigned instead of direct access.
12832 * class.cs (TypeContainer.VerifyMembers): Distinguish between
12833 not used and not used & assigned.
12834 (FieldBase.ASSIGNED): Moved to MemberCore.Flags.
12836 2005-07-11 Marek Safar <marek.safar@seznam.cz>
12839 * expression.cs (Is.DoResolve): null is never provided type.
12841 2005-07-08 Marek Safar <marek.safar@seznam.cz>
12844 * cs-parser.jay: Less strict event error rule to catch more errors.
12846 2005-07-08 Martin Baulig <martin@ximian.com>
12848 Fix test-iter-10.cs - distinguish whether we `yield' in a property
12849 gettter (allowed) or setter (not allowed).
12851 * class.cs (Accessor): Implement IIteratorContainer.
12852 (Accessor.Yields): New public field.
12853 (PropertyBase.PropertyMethod.Define): Handle iterators on a
12854 per-accessor basis.
12857 (get_accessor_declaration, set_accessor_declaration): Set the
12858 `yields' flag on the accessor, not the property.
12859 (property_declaration): Do the iterators check on a per-accessor
12860 basis and not for the whole property.
12862 2005-07-08 Martin Baulig <martin@ximian.com>
12864 * anonymous.cs (CaptureContext.EmitParameterInstance): Correctly
12865 handle parameters in nested scopes; fixes #74808; see gtest-188.cs.
12867 2005-07-07 Marek Safar <marek.safar@seznam.cz>
12870 * attribute.cs (orig_sec_assembly): Holds original version of assembly.
12871 (ExtractSecurityPermissionSet): Cope with self referencing security
12872 attributes properly.
12874 * driver.cs (SetOutputFile): Made public property OutputFile.
12876 2005-07-07 Raja R Harinath <rharinath@novell.com>
12879 * class.cs (TypeContainer.first_nonstatic_field): Rename from
12880 has_nonstatic_fields. Make into a FieldBase pointer.
12881 (TypeContainer.AddField): Add CS0282 check.
12882 (TypeContainer.EmitType): Update.
12884 2005-07-06 Miguel de Icaza <miguel@novell.com>
12886 * cs-tokenizer.cs (consume_identifier): Do not create strings to
12887 compare if they start with __.
12889 2005-07-06 Raja R Harinath <rharinath@novell.com>
12891 * statement.cs (Switch.SwitchGoverningType): Only look at
12892 UserCasts that don't need implicit standard conversions to one of
12893 the allowed switch types (Fixes test-322.cs).
12894 (LocalInfo.Resolve): Re-enable sanity-test.
12896 2005-07-06 Marek Safar <marek.safar@seznam.cz>
12898 * cs-tokenizer.cs (consume_identifier): Detect double undescores
12900 * ecore.cs (FieldExpr.AddressOf): Changed volatile error to warning.
12902 * expression.cs (Invocation.DoResolve): Report error CS0245 here.
12904 2005-07-06 Raja R Harinath <rharinath@novell.com>
12907 * ecore.cs (SimpleName.GetSignatureForError): Add.
12908 * expression.cs (MemberAccess.DoResolve): Don't clobber 'expr' field.
12909 (MemberAccess.GetSignatureForError): Add.
12911 2005-07-05 Marek Safar <marek.safar@seznam.cz>
12913 The big error and warning messages review.
12943 * typemanager.cs: Updated.
12945 * class.cs: (MethodCore.SetYields): Moved here to share.
12946 (PropertyMethod.Define): Moved iterator setup here.
12948 * iterators.cs: Add orig_method to have full access to parent
12951 2005-07-05 Raja R Harinath <rharinath@novell.com>
12953 Make 'fixed variable' handling standards compliant. Fix #70807, #72729.
12954 * ecore.cs (IVariable.VerifyFixed): Remove 'is_expression' parameter.
12955 (FieldExpr.VerifyFixed): Ensure that the field is part of a fixed
12956 variable of struct type.
12957 * expression.cs (Unary.ResolveOperator): Update to change.
12958 (Indirection.VerifyFixed): Likewise.
12959 (LocalVariableReference.VerifyFixed): A local variable is always fixed.
12960 (ParameterReference.VerifyFixed): Value parameters are fixed.
12961 (This.VerifyFixed): Treat 'this' as a value parameter.
12962 * statement.cs (LocalInfo.IsFixed): Remove.
12964 2005-07-01 Martin Baulig <martin@ximian.com>
12966 * iterators.cs (Iterator.CapturedThisReference.Emit): Use
12967 `ec.EmitThis ()' to get the correct scope.
12969 2005-07-01 Martin Baulig <martin@ximian.com>
12971 * ecore.cs (FieldExpr.DoResolve): Don't capture the field if it's
12972 instance is a ParameterReference; fixes #75299.
12974 2005-07-01 Martin Baulig <martin@ximian.com>
12976 Reverted Marek's latest patch (r46725):
12977 - it contains structural changes which are neither mentioned in
12978 the ChangeLog nor explained anywhere; for example the additional
12979 argument of EmitContext's and Iterator's .ctor's and the
12980 TypeContainer.DefineMembers() change.
12981 - structural changes like this should go in in seperate patches
12982 and not be hidden in a huge patch which just seems to affect
12983 warnings and errors.
12984 a big and hard to understand patch.
12985 - it breaks iterators and causes regressions, for instance in
12988 2005-06-30 Raja R Harinath <rharinath@novell.com>
12991 * expression.cs (Indexers.map): Remove.
12992 (Indexers.Append): Filter out inaccessible setters and getters.
12993 (IndexerAccess.DoResolve, IndexerAccess.DoResolveLValue): Update.
12996 * ecore.cs (MemberExpr.EmitInstance): New. Add CS0120 check.
12997 Refactored from ...
12998 (FieldExpr.EmitInstance, PropertyExpr.EmitInstance): ... these.
12999 (FieldExpr.Emit, PropertyExpr.Emit): Update.
13000 (FieldExpr.EmitAssign, PropertyExpr.EmitAssign): Update.
13001 * expression.cs (Invocation.EmitCall): Add CS0120 check.
13003 2005-06-30 Marek Safar <marek.safar@seznam.cz>
13006 * class.cs (FieldBase.GetInitializerExpression): One more field
13009 2005-06-28 Miguel de Icaza <miguel@novell.com>
13011 * pending.cs: Do not define a proxy if the base method is virtual,
13012 it will be picked up by the runtime (bug 75270).
13014 2005-06-08 Martin Baulig <martin@ximian.com>
13016 The big Iterators rewrite :-)
13018 * iterators.cs: Rewrite this to use the anonymous methods framework.
13020 * rootcontext.cs (RootContext.DefineTypes): Define Delegates
13021 before the TypeContainers; see 2test-21.cs.
13024 (TypeContainer.DefineType): Don't create a new EmitContext if we
13025 already have one (this only happens if we're an Iterator).
13026 (TypeContainer.Define): Also call Define() on all our iterators.
13027 (Method.CreateEmitContext): Added support for iterators.
13030 (AnonymousContainer): New abstract base class for `AnonymousMethod'.
13031 (AnonymousContainer.CreateMethodHost): Moved here from
13032 AnonymousMethod and made abstract.
13033 (AnonymousContainer.CreateScopeType): New abstract method.
13034 (AnonymousContainer.IsIterator): New public property.
13035 (ScopeInfo.EmitScopeType): Call CreateScopeType() on our Host to
13036 get the ScopeTypeBuilder rather than manually defining it here.
13037 (ScopeInfo.EmitScopeInstance): New public method; correctly handle
13040 * driver.cs (Driver.MainDriver): Call TypeManager.InitCodeHelpers()
13041 before RootContext.DefineTypes().
13043 * codegen.cs (EmitContext.RemapToProxy): Removed.
13044 (EmitContext.CurrentAnonymousMethod): Changed type from
13045 AnonymousMethod -> AnonymousContainer.
13046 (EmitContext.ResolveTopBlock): Protect from being called twice.
13047 (EmitContext.MapVariable, RemapParameter(LValue)): Removed.
13048 (EmitContext.EmitThis): Removed the iterators hacks; use the
13049 anonymous methods framework for that.
13052 (ToplevelBlock.Container): Make this a property, not a field.
13053 (ToplevelBlock.ReParent): New public method; move the
13054 ToplevelBlock into a new container.
13055 (Foreach.TemporaryVariable): Simplify.
13057 2005-06-05 Martin Baulig <martin@ximian.com>
13059 * statement.cs (LocalInfo.CompilerGenerated): New flag.
13060 (Block.AddTemporaryVariable): New public method; creates a new
13061 `LocalInfo' for a temporary variable.
13062 (Block.EmitMeta): Create the LocalBuilders for all the temporary
13064 (Foreach.TemporaryVariable): Use Block.AddTemporaryVariable() for
13065 non-iterator variables.
13067 2005-06-05 Martin Baulig <martin@ximian.com>
13069 * statement.cs (Foreach.TemporaryVariable): Create the
13070 LocalBuilder in the Emit phase and not in Resolve since in some
13071 situations, we don't have an ILGenerator during Resolve; see
13072 2test-19.cs for an example.
13074 2005-06-04 Martin Baulig <martin@ximian.com>
13076 **** Merged r45395 from GCS ****
13078 The big Foreach rewrite - Part II.
13080 * typemanager.cs (TypeManager.object_getcurrent_void): Replaced
13081 with `PropertyInfo ienumerator_getcurrent'.
13083 * codegen.cs (VariableStorage): Removed.
13086 (Foreach): Derive from Statement, not ExceptionStatement.
13087 (Foreach.CollectionForeach): New nested class. Moved all the code
13088 dealing with collection foreach here.
13089 (Foreach.ForeachHelperMethods): Removed.
13090 (Foreach.TemporaryVariable): Implement IMemoryLocation.
13092 2005-05-23 Martin Baulig <martin@ximian.com>
13094 * statement.cs (Try.DoResolve): Don't create a `finally' if we
13095 don't need to. Fix #75014.
13097 2005-05-20 Martin Baulig <martin@ximian.com>
13099 Merged r44808 from GMCS.
13101 * class.cs (TypeContainer.CircularDepException): Removed.
13102 (TypeContainer.DefineType): Removed the `InTransit' stuff.
13103 (TypeContainer.CheckRecursiveDefinition): Check for circular class
13104 (CS0146) and interface (CS0529) dependencies here.
13106 2005-06-21 Raja R Harinath <rharinath@novell.com>
13108 * expression.cs (Invocation.EmitCall): Fix initialization
13109 'this_call' to reflect current behaviour. Fix indentation.
13111 * convert.cs (FindMostEncompassedType): Add two trivial special
13112 cases (number_of_types == 0 || number_of_types == 1).
13113 (FindMostEncompasingType): Likewise.
13115 2005-06-17 Raja R Harinath <rharinath@novell.com>
13117 Some cleanups preparing for the fix of #75283.
13118 * ecore.cs (PropertyExpr.InstanceResolve): Tighten conditions for
13120 (EventExpr.InstanceResolve): Likewise.
13121 (EventExpr.DoResolve): Remove redundant checks.
13123 2005-06-10 Duncan Mak <duncan@novell.com>
13125 * cs-tokenizer.cs (process_directives): New flag for controlling
13126 the processing of preprocessor directives.
13127 (x_token): After seeing a '#', return Token.NONE instead of going
13128 to handle_preprocessing_directive() when not processing
13129 directives. This avoids unnecessary processing during the token peek in
13134 * cs-tokenizer.cs (handle_preprocessing_directive, xtoken): Use
13135 the existing error reporting methods instead of Report.Error.
13137 * convert.cs (priv_fmt_expr): Remove. It's not needed anymore
13138 after Raja's rewrite.
13140 2005-06-08 Miguel de Icaza <miguel@novell.com>
13142 * class.cs: Small fix.
13144 2005-06-08 Raja R Harinath <rharinath@novell.com>
13147 * class.cs (GetPartialBases): Fix return value check of
13148 part.GetClassBases.
13150 2005-06-07 Raja R Harinath <rharinath@novell.com>
13152 Ensure that partial classes are registered in their enclosing
13153 namespace. Initial part of fix of #75160.
13154 * tree.cs (Tree.RecordDecl): Add new namespace argument.
13155 Register declspace with namespace here, not in
13156 DeclSpace.RecordDecl.
13157 * cs-parser.jay: Pass namespace to RecordDecl.
13158 * class.cs (PartialContainer.Create): Likewise.
13159 (ClassPart.DefineType): New sanity-check. Throws an exception if
13161 * decl.cs (Declspace.RecordDecl): Remove.
13162 * namespace.cs (NamespaceEntry.DefineName): Remove.
13164 2005-06-06 Marek Safar <marek.safar@seznam.cz>
13166 * rootcontext.cs: Reset TargetExt as well.
13168 2005-06-03 Raja R Harinath <rharinath@novell.com>
13170 * ecore.cs (Expression.Resolve): Emit CS0654 error when
13171 -langversion:ISO-1.
13173 2005-06-02 Raja R Harinath <rharinath@novell.com>
13175 Fix #75080, cs0119.cs.
13176 * ecore.cs (Expression.ExprClassToResolveFlags): New. Broken out
13178 (Expression.Resolve): ... this. Use it. Remove bogus code
13179 allowing ExprClass.Type and ExprClass.Namespace for
13180 ResolveFlags.VariableOrValue.
13181 (Expression.Resolve) [1-argument variant]: Change default resolve
13182 flags based on language version.
13183 (Expression.Error_UnexpectedKind): Use a simple string array
13184 rather than an ArrayList.
13185 * expression.cs (TypeOf.DoResolve): Set eclass to ExprClass.Value,
13186 not ExprClass.Type.
13187 (TypeOfVoid.DoResolve): Likewise.
13188 (MemberAccess.DoResolve) [3-argument variant]: Make private. Drop
13189 flags argument -- it always has the same value.
13191 2005-05-31 Raja R Harinath <rharinath@novell.com>
13194 * ecore.cs (Expression.ResolveLValue): Add a Location parameter.
13195 Use it in the error message.
13196 * assign.cs, expression.cs, statement.cs: Update.
13198 2005-05-30 Raja R Harinath <rharinath@novell.com>
13201 * ecore.cs (Expression.MemberLookupFailed): Add CS0122 check in
13202 the "almostMatchedMember" case too.
13203 * typemanager.cs (Closure.CheckValidFamilyAccess): Add anything
13204 that failed the accessibility checks to 'almost_match'.
13206 2005-05-27 Vladimir Vukicevic <vladimir@pobox.com>
13208 * attribute.cs: Use internal MethodBuilder methods to set
13209 ExactSpelling and SetLastError on PInvoke methods, instead
13210 of passing them via charset. Fixes #75060.
13212 2005-05-27 Raja R Harinath <rharinath@novell.com>
13214 * parameter.cs (Parameter): Remove TODO comment.
13215 (Parameter.DefineParameter): Remove Location parameter.
13216 (Parameters.LabelParameters): Likewise.
13217 * class.cs (Constructor.Emit): Update to change.
13218 (MethodData.Emit): Likewise.
13219 * anonymous.cs (AnonymousMethod.EmitMethod): Likewise.
13220 * delegate.cs (Delegate.Define, Delegate.Emit): Likewise.
13222 2005-05-27 Atsushi Enomoto <atsushi@ximian.com>
13225 Removed Parameters.Location and added Parameter.Location instead.
13226 Removed Location parameter from Emit() and GetSignature().
13233 Modified all related calls.
13235 2005-05-26 Raja R Harinath <rharinath@novell.com>
13237 Improve user-defined conversion handling.
13238 * convert.cs (GetConversionOperators): Rewrite. Return only the
13239 applicable operators.
13240 (AddConversionOperators): New. Helper for GetConversionOperators.
13241 (FindMostEncompassedType, FindMostEncompassingType): Verify that
13242 there is only one most encompassed/encompassing type.
13243 (FindMostSpecificSource, FindMostSpecificTarget): Remove
13244 "applicable operator" handling.
13245 (UserConversion): Move cache here from GetConversionOperators.
13246 Directly cache the chosen operator, rather than the whole
13248 (ExplicitNumericConversion): Fix buggy implementation of Decimal
13249 case. Allow conversion of decimal to sbyte and byte too.
13250 * expression.cs (EmptyExpression.Grab, EmptyExpression.Release):
13251 New static methods. Used to avoid allocating EmptyExpressions in
13254 2005-05-24 Duncan Mak <duncan@novell.com>
13256 * ecore.cs (CastFromDecimal): New class for casting a decimal to
13257 another class, used in Convert.ExplicitNumericConversion.
13258 (CastToDecimal): New class, similar to above, but casts to
13259 System.Decimal, used in Convert.ImplicitNumericConversion and also
13260 in explicit convesion from double/float to decimal.
13262 * convert.cs (ImplicitNumericConversion): Handle implicit
13263 conversions to System.Decimal.
13264 (ExplicitNumericConversion): handle explicit conversions to
13269 2005-05-20 Miguel de Icaza <miguel@novell.com>
13271 * typemanager.cs (EnumToUnderlying): Do not throw if we do not
13272 know the type at this stage, just break through. Fixes #75008
13274 2005-05-19 Martin Baulig <martin@ximian.com>
13277 (ImplicitDelegateCreation.Check): Added `bool check_only' argument
13278 to disable error reporting.
13280 * convert.cs (Convert.ImplicitStandardConversionExists): Use it
13281 here since we don't want to report an error; see the new test-336.cs.
13283 2005-05-19 Raja R Harinath <rharinath@novell.com>
13285 * statement.cs (ToplevelBlock.GetParameterReference)
13286 (ToplevelBlock.IsParameterReference,ToplevelBlock.IsLocalParameter):
13287 Move here from class Block.
13288 * ecore.cs (SimpleName.SimpleNameResolve): Update to changes.
13289 * expression.cs (ParameterReference.DoResolveBase): Likewise.
13291 2005-05-18 Martin Baulig <martin@ximian.com>
13296 (FlowBranching.Reachability): Add non-static public And() and Or()
13298 (FlowBranchingSwitch): New class; do the `break_origins' thing
13299 like in FlowBranchingLoop.
13300 (FlowBranching.UsageVector.MergeBreakOrigins): Also merge the
13301 reachability, not just locals and parameters.
13302 (FlowBranching.MergeChild): Remove some of the hacks for loop and
13303 switch; MergeBreakOrigins() now takes care of that.
13305 2005-05-18 Martin Baulig <martin@ximian.com>
13307 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
13308 a loop and may leave it, reset the barrier; fixes #74974.
13310 2005-05-17 Marek Safar <marek.safar@seznam.cz>
13312 * attribute.cs (Attribute.ResolveArguments): GuidAttribute check
13315 * cs-parser.jay: Catch more lexical errors.
13317 * report.cs: Add one more Error method.
13320 * typemanager.cs: Register System.Runtime.InteropServices.GuidAttribute
13322 2005-05-17 Martin Baulig <martin@ximian.com>
13324 * expression.cs (Argument.Resolve): Turn on flow analysis; fix
13327 2005-05-16 Raja R Harinath <rharinath@novell.com>
13329 Fix test-382.cs. Emit values of decimal constants.
13330 * class.cs (TypeContainer.RegisterFieldForInitialization): New.
13332 (TypeContainer.AddField): ... this.
13333 (TypeContainer.EmitFieldInitializers): Allow the list of fields
13334 with initializers to include 'Const's.
13335 (ClassPart.RegisterFieldForInitialization): Forward to
13337 * const.cs (Const.Const): Pass initializer to base class.
13338 (Const.Define): In case of decimal constants, register them for
13339 initialization in a static constructor.
13341 2005-05-14 Martin Baulig <martin@ximian.com>
13343 * statement.cs (Block.Resolve): Correctly handle unreachable code;
13344 do not call ResolveUnreachable() on unreachable statements in
13345 here, see the comment in the source code.
13347 2005-05-13 Raja R Harinath <rharinath@novell.com>
13350 * expression.cs (BinaryResolveOperator): If one of the operands of
13351 an equality comparison is 'null' and the other is a pointer type,
13352 convert the null to a NullPointer.
13353 * convert.cs (ImplicitReferenceConversion): If the expression is a
13354 NullLiteral and the target type is a pointer type, return a
13355 NullPointer instead.
13356 (ImplicitConversionStandard): Likewise.
13358 2005-05-13 Marek Safar <marek.safar@seznam.cz>
13360 * cs-parser.jay: Set readonly context based on special constructs.
13362 * expression.cs (LocalVariableReference.DoResolveBase): Improved
13363 readonly variable error handling.
13365 * rootcontext.cs (EmitCode): Don't verify members when error
13368 * statement.cs (LocalInfo): Add reaodnly context information.
13369 (SetReadOnlyContext, GetReadOnlyContext): New methods.
13371 2005-05-13 Raja R Harinath <rharinath@novell.com>
13373 * statement.cs (Block.Resolve): Revert change below. Modify fix
13374 for #74041 to initialize 'resolved' to false only for explicit
13375 blocks. Fixes #74873.
13377 2005-05-12 Raja R Harinath <harinath@gmail.com>
13380 * typemanager.cs (unmanaged_enclosing_types): New.
13381 (IsUnmanagedType): Avoid infloops by using
13382 'unmanaged_enclosing_types' to talk with recursive invocations.
13384 2005-05-13 Martin Baulig <martin@ximian.com>
13386 * statement.cs (Block.Resolve): Make the `bool unresolved' flag an
13387 instance variable, not a local. Fix #74873.
13388 (Block.ResolveUnreachable): Set it to true here.
13390 2005-05-11 Duncan Mak <duncan@novell.com>
13392 * cs-tokenizer.cs (get_cmd_arg): Check that 'c' is not -1 before
13393 continuing to process for 'arg'.
13394 (handle_preprocessing_directive): Check the argument of the #endif
13395 directive and report error CS1025 if there are any trailing
13398 According to the C# spec, having even whitespace after the #endif
13399 directive is illegal; however, because we call arg.TrimEnd ()
13400 beforehand, we have the same behavior as csc, allowing whitespace
13401 after the directive.
13405 2005-05-11 Marek Safar <marek.safar@seznam.cz>
13409 * class.cs (ConstructorInitializer.GetOverloadedConstructor): Removed.
13410 (Constructor.GetObsoleteAttribute): Implemented correctly.
13412 2005-05-10 Martin Baulig <martin@ximian.com>
13414 * support.cs (ReflectionParameters.ParameterModifier): Use
13415 `Parameter.Modifier.REF' if we both have `ParameterAttributes.Out'
13416 and `ParameterAttributes.In'. Fixes #74884.
13418 2005-05-10 Marek Safar <marek.safar@seznam.cz>
13420 * class.cs (Method.Define): Catch attempt for Finalizer declaration.
13422 * expression.cs (Argument.GetParameterModifier): Turned to property.
13423 (Invocation.Error_InvalidArguments): Add more descriptive errors.
13425 * parameter.cs (Parameter.GetModifierSignature): Translates modifier to
13428 2005-05-09 Raja R Harinath <rharinath@novell.com>
13431 * decl.cs (MemberCache.AddMethods): Register override methods,
13432 rather than non-override methods.
13433 * typemanager.cs (RegisterOverride): New.
13434 (IsOverride): Update.
13436 2005-05-09 Marek Safar <marek.safar@seznam.cz>
13440 * ecore.cs (SimpleName.SimpleNameResolve): Add in_transit to catch
13441 recursive declaration.
13443 * statement.cs (Block.ResolveMeta): Report any error in resolving.
13445 2005-05-06 Marek Safar <marek.safar@seznam.cz>
13447 * cfold (DoConstantNumericPromotions): Don't try to convert 0 enum.
13449 * expression.cs (Binary.DoResolve): (x && 0) is always 0.
13451 2005-05-05 Raja R Harinath <rharinath@novell.com>
13454 * decl.cs (DeclSpace.FamilyAccessible):
13455 Use TypeManager.IsNestedFamilyAccessible.
13457 Fix reopened #64812.
13458 * typemanager.cs (Closure.Filter): Introduce checks for 'protected
13461 2005-05-04 Raja R Harinath <rharinath@novell.com>
13462 Abin Thomas <projectmonokochi@rediffmail.com>
13463 Anoob V E <projectmonokochi@rediffmail.com>
13464 Harilal P R <projectmonokochi@rediffmail.com>
13467 * typemanager.cs (Closure.CheckValidFamilyAccess): Don't blindly
13468 allow access to all static members.
13470 2005-05-04 Martin Baulig <martin@ximian.com>
13472 * ecore.cs (FieldExpr.DoResolveLValue): Always call fb.SetAssigned().
13474 2005-05-04 Martin Baulig <martin@ximian.com>
13478 * statement.cs (Switch.SimpleSwitchEmit): Always emit the default
13479 section at the end; make things work if `default' is not the last
13482 2005-05-04 Martin Baulig <martin@ximian.com>
13486 * statement.cs (Switch): Replaced the `got_default' field with a
13487 `default_section' one.
13488 (Switch.CheckSwitch): Set `default_section' here.
13489 (Switch.Resolve): If we're a constant switch and the constant is
13490 not found, use the default section.
13492 2005-05-03 Martin Baulig <martin@ximian.com>
13494 * expression.cs (ArrayAccess.EmitGetLength): New public method.
13496 * statement.cs (Foreach.ArrayForeach): New nested class.
13497 (Foreach.TemporaryVariable): New nested class.
13498 (Foreach.EmitArrayForeach): Removed; this is now in the new
13499 ArrayForeach class.
13501 2005-05-03 Raja R Harinath <rharinath@novell.com>
13503 * pending.cs (BaseImplements): Move the #74773 fix here. This is
13505 (VerifyPendingMethods): Revert change below.
13507 * typemanager.cs (IsOverride, RegisterNonOverride): New.
13508 * decl.cs (MemberCache.AddMethod): Register "non-override" methods
13509 that used to trigger warning -28. Remove warning -28.
13510 * expression.cs (Invocation.OverloadResolve): Use
13511 TypeManager.IsOverride to distinguish override methods.
13514 * pending.cs (VerifyPendingMethods): If a base type implements the
13515 requested interface, don't bother checking individual methods of
13516 the base type. As a side-effect, this prevents the creation of
13517 unnecessary proxies.
13519 2005-05-02 Martin Baulig <martin@ximian.com>
13523 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
13524 Also `And' the locals if the old vector is null.
13525 (FlowBranching.UsageVector.BitVector.And): Allow `vector' being
13526 null; in this case we basically reset all the variables.
13528 2005-05-02 Martin Baulig <martin@ximian.com>
13532 * flowanalysis.cs (FlowBranching.UsageVector.MergeBreakOrigins):
13533 Added `FlowBranching branching' argument; always `and' the
13534 variables instead of `or'ing them unless we're an infinite loop.
13536 * statement.cs (While.Resolve): Create a new sibling unless we're
13539 2005-05-02 Martin Baulig <martin@ximian.com>
13543 * class.cs (ConstructorInitializer.Resolve): Added `Block block'
13544 arguments; use it instead of creating a new TopLevelBlock.
13545 (Constructor.Emit): Call `block.ResolveMeta ()' before resolving
13546 our ConstructorInitializer.
13549 (TopLevelBlock.TopLevelBranching): New public property.
13550 (TopLevelBlock.ResolveMeta): New public method; call ResolveMeta()
13551 and create our `TopLevelBranching'.
13553 * codegen.cs (EmitContext.ResolveTopBlock): If we're not an
13554 anonymous method host, use `block.TopLevelBranching' rather than
13555 creating a new branching.
13557 2005-04-20 Miguel de Icaza <miguel@novell.com>
13559 * anonymous.cs (ScopeInfo.AddChild): when adding a new child to
13560 a ScopeInfo, if any of the current children is a child of the new
13561 entry, move those children there.
13563 2005-04-30 Martin Baulig <martin@ximian.com>
13565 * statement.cs (Switch.SimpleSwitchEmit): Reset `default_at_end'
13566 at the beginning of a SwitchSection. Fix #73335.
13568 2005-04-27 Marek Safar <marek.safar@seznam.cz>
13571 * class.cs (EmitFieldInitializers): Use FieldExpr in initializer.
13573 * ecore.cs (FieldExpr): Add a new ctor with in_initializer.
13574 (FieldExpr.DoResolve): Obsolete members are ignored for field
13577 2005-04-26 Marek Safar <marek.safar@seznam.cz>
13579 * attribute.cs (AreOverloadedMethodParamsClsCompliant): Add array
13580 of arrays detection.
13582 * class.cs (Interface.VerifyClsCompliance): Add base interfaces
13584 (Field.VerifyClsCompliance): Volatile fields are not compliant.
13586 * decl.cs (MemberCache.VerifyClsParameterConflict): Add array of
13589 2005-04-25 Ben Maurer <bmaurer@ximian.com>
13591 * cs-parser.jay: Use the prefered version of -unsafe in error
13594 2005-04-22 Marek Safar <marek.safar@seznam.cz>
13596 * driver.cs (CompilerCallableEntryPoint.Invoke): Reset under any
13599 2005-04-20 John Luke <john.luke@gmail.com>
13601 * driver.cs: fix typo in error message, --outout to --output
13603 2005-04-20 Marek Safar <marek.safar@seznam.cz>
13605 * codegen.cs (InRefOutArgumentResolving): New field.
13607 * ecore.cs (FieldExpr.DoResolve): Check for assigning to readonly
13608 fields outside contructor.
13610 * expression.cs (Argument.Resolve): Set InRefOutArgumentResolving.
13612 2005-04-19 Miguel de Icaza <miguel@novell.com>
13614 * anonymous.cs (CaptureContext.EmitParameterInstance): The
13615 parameter code was not completed ever, so it was not as up-to-date
13616 as local variables. Must finish it.
13618 The bug fix was to compare the Toplevel of the block, not the
13619 current block. Thanks for Ben for pointing this out.
13621 2005-04-19 Raja R Harinath <rharinath@novell.com>
13623 * decl.cs (AddMethods): Use the declaring type of the problem
13624 method to determine if we want to squash a warning.
13626 2005-04-19 Marek Safar <marek.safar@seznam.cz>
13628 * attribute.cs: Removed debug output.
13630 * decl.cs (MemberCache.AddMethods): Fixed Finalize ignoring.
13632 * driver.cs (Driver.parse): Synchronize parser ErrorOutput with
13635 2005-04-18 Raja R Harinath <rharinath@novell.com>
13638 * expression.cs (Binary.EqualsNullIsReferenceEquals): New.
13639 (Binary.DoResolveOperator): Use it to avoid blindly optimizing out
13640 all null comparisons against reference types.
13642 2005-04-18 Marek Safar <marek.safar@seznam.cz>
13645 * class.cs (TypeContainer.CircularDepException) New nested
13647 (GetPartialBases, GetNormalBases, GetClassBases): Removed error.
13648 (TypeContainer.DefineType): Removed error, reset InTransit before
13650 (Class.DefineType): Throw exception when is in Transit.
13651 Catch exception and report error.
13652 (Struct.DefineType): Throw exception when is in Transit.
13653 Catch exception and report error.
13654 (Interface.DefineType): Throw exception when is in Transit.
13655 Catch exception and report error.
13657 * codegen.cs: Add InCatch,InFinally to EmitContext to easily
13658 handle nested exception handlers.
13660 * flowanalysis.cs (InTryWithCatch): New method, search for try with
13663 * iterators.cs (Yield.CheckContext): Add CS1626 report. Updated
13664 InFinally and InCatch storage.
13666 * statement.cs (Throw.Resolve): Use InCatch, InFinally from ec.
13667 (Catch.Resolve): Set and Restore ec.InCatch.
13668 (Try.Resolve): Set and Restore ec.InFinally.
13669 (Try.HasCatch): True when try has catch.
13671 2005-04-17 Atsushi Enomoto <atsushi@ximian.com>
13673 * doc.cs : In some cases FilterName returns MonoEvent and MonoField
13674 for the same event member, so exclude such cases from warning 419.
13677 2005-04-16 Miguel de Icaza <miguel@novell.com>
13679 * expression.cs (Binary.ResolveOperator): Apply patch from John
13680 Luke to fix bug 59864: operators &, | and ^ on enumerations
13681 require that the same enum type on both sides.
13683 * driver.cs: Add warnings to old flag usage, this is to assist
13684 people who produce Makefiles and hope that the Makefiles will be
13687 * class.cs (TypeContainer.EmitType): Moved the definition of the
13688 special $PRIVATE$ field from the resolve phase to the Emit phase.
13689 During resolve we do not know if we are a struct with
13690 HasExplicitLayout, we know this only after the attributes for the
13693 Set the FieldOffset to zero on the dummy field that we create for
13694 the class. Fixes 74590.
13696 2005-04-16 Raja R Harinath <rharinath@novell.com>
13699 * ecore.cs (PropertyExpr.resolved): New.
13700 (DoResolve): Use it to handle a case of double resolution here.
13701 Handle a case of identical-name-and-type-name.
13702 * expression.cs (ArrayCreation.CheckIndices): Avoid double
13703 resolution by storing the results of expression resolution back
13704 into the "probes" array.
13706 2005-04-15 Raja R Harinath <rharinath@novell.com>
13708 Fix cs0208-7.cs and cs0208-8.cs.
13709 * typemanager.cs (IsUnmanagedType): Arrays are not allowed
13710 (cf. ECMA standard, behaviour of CSC 1.1 and CSC 2.0). Improve
13711 error reporting to point out the reason a struct is not unmanaged.
13713 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13715 * doc.cs : In FindDocumentedType(), avoid TypeExpr.ResolveType() and
13716 just use TypeExpr.Type. This fixes bug #74595 when merged to gmcs.
13718 2005-04-13 Raja R Harinath <rharinath@novell.com>
13721 * ecore.cs (PropertyExpr.InstanceResolve): Handle a case of
13722 IdenticalNameAndTypeName here.
13723 (EventExpr.InstanceResolve): Likewise.
13725 2005-04-13 Marek Safar <marek.safar@seznam.cz>
13727 C# 2.0 DefaultCharSetAttribute implementation
13729 * attribute.cs (Attribute.ResolveAsTypeStep): New protected method
13730 which allows us to set GlobalNamespace for every resolve.
13731 (Attribute.ResolveArguments): Cut from Resolve.
13732 (Attribute.GetCharSetValue): Returns CharSet named argument.
13733 (Attribute.DefinePInvokeMethod): Gets default charset from
13735 (GlobalAttribute.ResolveAsTypeStep): Override.
13736 (GlobalAttribute.ResolveArguments): Override.
13738 * class.cs (TypeAttr): Is protected.
13740 * codegen.cs (ModuleClass.DefaultCharSet): New member.
13741 (ModuleClass.DefaultCharSetType): New memeber.
13742 (ModuleClass.ResolveAttributes): Resolves DefaultCharSetAttribute.
13744 * decl.cs (Decl.TypeAttr): New protected virtual. Returns default
13745 charset from module.
13747 * delegate.cs (TypeAttr): Override.
13748 (Delegate.DefineType): Use this TypeAttr.
13750 * driver.cs (Driver.MainDriver): Call Module.ResolveAttributes
13751 at very early stage (before types are defined) to resolve model
13752 module attributes. It will probably not work with corlib but it
13755 * enum.cs (Enum.TypeAttr): New protected virtual. Returns default
13756 charset from module.
13758 * typemanager.cs (default_charset_type): New type.
13760 2005-04-13 Raja R Harinath <rharinath@novell.com>
13762 * decl.cs (MemberCache.AddMethods): Don't warn if
13763 System.Object.Finalize has buggy MethodAttributes.
13765 * typemanager.cs (IsUnmanagedType): Restore !IsValueType check
13768 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13770 * doc.cs : detect ambiguous reference to overloaded members.
13771 Fixed bug #71603. MS 1.1 csc does not detect it.
13773 2005-04-13 Atsushi Enomoto <atsushi@ximian.com>
13775 * doc.cs : delegates must not be referenced with parameters.
13778 2005-04-12 Miguel de Icaza <miguel@novell.com>
13780 * typemanager.cs (IsUnmanagedType): Arrays are allowed.
13782 2005-04-10 Miguel de Icaza <miguel@novell.com>
13784 * driver.cs (MainDriver): Stop processing if the CLS stage found
13787 (CompilerCallableEntryPoint.InvokeCompiler): Always
13788 reset after execution; Take a TextWriter argument for the
13791 * report.cs: Use the error stream instead of hardcoding stderr.
13793 2005-04-09 Miguel de Icaza <miguel@novell.com>
13795 * class.cs: Reduce code paths to test, too small of an
13796 optimization to make it worth the extra testing. Always perform
13799 2005-04-08 Raja R Harinath <rharinath@novell.com>
13802 * class.cs (OperatorArrayList.CheckPairedOperators): Skip
13803 operators that had errors reported on them.
13805 2005-04-08 Marek Safar <marek.safar@seznam.cz>
13807 * attribute.cs (Attribute.IsValidArgumentType): Test valid named
13809 (Attribute.Resolve): Add named argument type checking.
13811 * class.cs (FixedField.Define): Use IsPrimitiveType
13813 * expression.cs (Binary.ResolveOperator): Reflect IsCLRType renaming.
13815 * iterators.cs (Iterator.DefineIterator): Add check for arglist and
13816 unsafe parameter types.
13818 * statement.cs (Using.ResolveExpression): Add better error description.
13820 * typemanager.cs (IsCLRType): Renamed to IsPrimitiveType.
13822 2005-04-08 Raja R Harinath <rharinath@novell.com>
13825 * attribute.cs (Attribute.GetAttributeUsage): Resolve
13826 AttributeUsageAttribute in the emitcontext of the attribute class,
13827 not in the emitcontext of the attributable entity it was attached to.
13828 * cs-parser.jay: Use 'current_class', not 'current_container',
13829 when creating a GlobalAttribute.
13831 2005-04-08 Alp Toker <alp@atoker.com>
13833 * pending.cs: The fix to #58413 failed to compile methods implementing
13834 interfaces with/without params modifiers and vice versa, even though
13835 params modifiers aren't part of the signature. Make the modifier check
13836 less strict as in csc.
13838 2005-04-07 Abin Thomas <projectmonokochi@rediffmail.com>
13839 Anoob V E <projectmonokochi@rediffmail.com>
13840 Harilal P R <projectmonokochi@rediffmail.com>
13843 * pending.cs (TypeAndMethods.mods): New. Store the parameter
13844 modifiers of pending methods.
13845 (PendingImplementation.PendingImplementation): Initialize it.
13846 Add Parameter.Modifier [][] mods and initialize it with ParameterData.
13847 (PendingImplementation.InterFaceMethod): Repalce Type[] argument
13848 with ParameterData. Add check for modifiers.
13849 * class.cs (MethodData.Define): Update to changes.
13851 2005-04-07 Raja R Harinath <rharinath@novell.com>
13853 * ecore.cs (Expression.IsAccessorAccessible): Clarify code somewhat.
13855 2005-04-07 Marek Safar <marek.safar@seznam.cz>
13857 * class.cs (PropertyMethod.Define): Check private accessor in abstract
13860 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't allow RequiredAttribute
13863 * typemanager.cs: Registered RequiredAttributeAttribute.
13865 2005-04-06 Marek Safar <marek.safar@seznam.cz>
13867 * class.cs (VerifyMembers): Doesn't need EmitContext argument.
13868 Warning CS0169 is back at level 3.
13869 (IMethodData.SetMemberIsUsed): New method.
13871 * decl.cs (IsUsed): New value; moved from FieldBase.Status
13872 (SetMemberIsUsed, IsUsed): New methods, encapsulate IsUsed.
13874 * delegate.cs (ResolveMethodGroupExpr): Call SetMemberIsUsed.
13876 * ecore.cs (FieldExpr.ResolveMemberAccess): Call SetMemberIsUsed for
13878 (PropertyExpr.ResolveAccessors): Call SetMemberIsUsed when delegate
13881 * expression.cs (OverloadResolve): Call SetMemberIsUsed. when method
13884 * rootcontext.cs (RootContext.EmitCode): Call VerifyMembers in extra run
13885 to avoid the problems with nested types.
13887 2005-04-05 Abin Thomas <projectmonokochi@rediffmail.com>
13888 Anoob V.E <projectmonokochi@rediffmail.com>
13889 Harilal P.R <projectmonokochi@rediffmail.com>
13890 Raja R Harinath <rharinath@novell.com>
13893 * delegate.cs (Define): Emit ParamArrayAttribute for 'params'
13895 * typemanager (GetConstructor): Make public.
13897 2005-04-05 John Luke <john.luke@gmail.com>
13898 Raja R Harinath <rharinath@novell.com>
13901 * typemanager.cs (IsUnmanagedType): Check non-public fields of a
13902 struct too. Return false quicker in a few cases.
13903 (VerifyUnManaged): Use it.
13905 2005-04-05 Raja R Harinath <rharinath@novell.com>
13908 * statement.cs (Block.Resolve): Initialize 'unreachable' to false,
13909 not 'unreachable_seen'.
13911 2005-04-04 Marek Safar <marek.safar@seznam.cz>
13913 * attribute.cs (Attribute.GetValue): Removed unused.
13915 * codegen.cs (CodeGen.TrimExt): Removed unused.
13917 * cs-parser.jay (output): Removed unused.
13919 * cs-tokenizer.cs (hex_digits): Removed unused.
13921 * enum.cs (MapToInternalType, GetEnumeratorName): Removed unused.
13923 * expression.cs (Indirection.LoadExprValue): Removed unused.
13924 (ArrayCreation.ExpressionToArrayArgument): Removed unused.
13926 * iterators.cs (Iterator.param_types): Removed unused.
13928 * statement.cs (Goto.block): Removed unused.
13929 (ToplevelBlock.did): Removed unused.
13930 (Switch.ResolveConstantSwitch): Removed unused.
13932 2005-04-01 Ben Maurer <bmaurer@ximian.com>
13934 * rootcontext.cs: Allow mcs to bootstrap with the compilation
13937 2005-04-01 Raja R Harinath <rharinath@novell.com>
13939 Fix #74232 and cs0208-3.cs.
13940 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0208 check.
13941 * typemanager.cs (IsUnmanagedType): Don't allow 'object' as an
13942 unmanaged type. Don't use FieldBuilders when 't' is a
13943 TypeBuilder. Use ModFlags and MemberType fields.
13944 * class.cs (MemberBase.member_type): Rename from MemberType.
13945 (MemberBase.MemberType): New property. Determines member_type on
13947 (MemberBase.DoDefine): Don't initialize MemberType here.
13948 (FieldMember.Define): Likewise.
13950 2005-04-01 Marek Safar <marek.safar@seznam.cz>
13953 * class.cs (Event.Emit): Call Add/Remove emit even for interfaces.
13954 Attributes are emitted there.
13956 2005-04-01 Raja R Harinath <rharinath@novell.com>
13958 * cs-tokenizer.cs (consume_identifier): Treat 'partial' as a
13959 keyword in 'partial enum' too.
13960 * cs-parser.jay (enum_declaration): Add CS0267 check ('partial enum'
13962 Report from Kamil Skalski <nazgul@omega.pl>.
13965 * rootcontext.cs (ResolveTree): The 'root.Interfaces' list can
13966 have partial containers too.
13968 * ecore.cs (SimpleName.SimpleNameResolve): Move 'invariant meaning
13969 in block' checks to Block.CheckInvariantMeaningInBlock.
13970 * statement.cs (Block.GetKnownVariableInfo): Make private.
13971 (Block.IsVariableUsedInChildBlock): Remove.
13972 (Block.IsVariableUsedInBlock): Likewise.
13973 (Block.CheckInvariantMeaningInBlock): New. Show location of
13974 conflicting declaration.
13975 (Block.AddVariable): Make error messages less long-winded and more
13976 specific. Show location of conflicting declaration.
13977 * parameter.cs (Parameters.Location): New readonly property.
13979 2005-03-31 Raja R Harinath <rharinath@novell.com>
13981 Clean up semantics of invoking ResolveMemberAccess.
13982 * ecore.cs (SimpleName.DoSimpleNameResolve): If a MemberExpression
13983 can have an instance, ensure that we pass in a non-TypeExpression
13984 to ResolveMemberAccess. Tighten up IdenticalNameAndTypeName checks.
13985 (MemberExpr.DoSimpleNameResolve): Remove type_is_inferred
13986 argument. Update to changes and simplify.
13987 (FieldExpr.Emitinstance): Remove CS0120 check.
13988 (PropertyExpr.EmitInstance): Likewise.
13989 * expression.cs (Argument.Resolve): Likewise.
13990 (Invocation.DoResolve): Update to changes in semantics of
13991 InstanceExpression.
13993 2005-03-31 Marek Safar <marek.safar@seznam.cz>
13996 * class.cs (AbstractPropertyEventMethod.EmitMethod): Enable emit method
13999 * decl.cs (MemberCache.AddMethods): Fix infinite loop.
14001 2005-03-31 Raja R Harinath <rharinath@novell.com>
14003 Fix difference in behaviour with commandline invocation.
14004 * driver.cs (Driver.Reset): New.
14005 (CompilerCallableEntryPoint): Call it.
14007 * statement.cs (If.Resolve): Avoid spurious "uninitialized
14008 variable" warnings if the boolean expression failed to resolve.
14010 2005-03-30 Sebastien Pouliot <sebastien@ximian.com>
14012 * attribute.cs: Fix the union of several permissions when some of them
14013 are unrestricted (so the result isn't an unrestricted permission set).
14016 2005-03-30 Raja R Harinath <rharinath@novell.com>
14018 * ecore.cs (MemberExpr): New class. Convert from interface
14020 (MemberExpr.ResolveMemberAccess): Refactor and move here from
14021 MemberAccess.ResolveMemberAccess. Tighten up pre-conditions and
14023 (MethodGroupExpr, FieldExpr, PropertyExpr, EventExpr): Update.
14024 (MethodGroupExpr.IsExplicitImpl): Remove.
14025 (Expression.GetFieldFromEvent): Remove.
14026 (SimpleName.MemberStaticCheck): Remove.
14027 (SimpleName.DoSimpleNameResolve): Update to changes.
14028 * expression.cs (MemberAccess.ResolveMemberAccess): Refactor.
14029 (MemberAccess.IdenticalNameAndTypeName): Remove.
14030 (MemberAccess.error176): Move to MemberExpr.
14031 (MemberAccess.DoResolve): Update to changes.
14032 (BaseAccess.DoResolve): Likewise.
14034 2005-03-30 Marek Safar <marek.safar@seznam.cz>
14036 C# 2.0 Conditional attribute class implementation
14038 * attribute.cs (AttributeTester.IsAttributeExcluded): New method.
14039 Analyzes class whether it has attribute which has ConditionalAttribute
14040 and its condition is not defined.
14042 * class.cs (Class.ApplyAttributeBuilder): Add IsAttributeExcluded check.
14043 (Class.IsExcluded): New method. Search for at least one defined
14044 condition in ConditionalAttribute of attribute class.
14046 2005-03-30 Raja R Harinath <rharinath@novell.com>
14048 * ecore.cs (PropertyExpr): Derive from Expression, not
14049 ExpressionStatement.
14050 (PropertyExpr.EmitStatement): Remove.
14052 2005-03-29 Raja R Harinath <rharinath@novell.com>
14055 * expression.cs (MemberAccess.ResolveMemberAccess): Allow the
14056 internal field "value__" of an enum be private. The examples for
14057 "value__" that I found on MSDN all used FieldAttributes.Private.
14059 * decl.cs (MemberCache.AddMethods): Use C# terminology in warning.
14060 Don't mention IL method attribute names.
14062 Fix #47991. Remove a TODO.
14063 * statement.cs (Block.Toplevel): Make into a field.
14064 (Block.Parameters): Move into ToplevelBlock.
14065 (Block.known_variables): Rename from child_variable_names.
14066 (Block.Block): Remove variants that take Parameters. Initialize
14067 'Toplevel' with the immediately surrounding toplevel block.
14068 (Block.AddKnownVariable): Rename from AddChildVariableName. Add a
14069 LocalInfo parameter.
14070 (Block.GetKnownVariableInfo): New.
14071 (Block.IsVariableNameUsedInChildBlock): Update.
14072 (Block.IsVariableNameUsedInBlock): New. Checks if a name is used in
14073 the block, even though it may not be in scope.
14074 (Block.AddVariable): Remove Parameters parameter. Use
14075 Toplevel.Parameters instead.
14076 (Block.AddConstant): Remove Parameters parameter.
14077 (Block.GetParameterReference): Update to use Toplevel.Parameters.
14078 (Block.IsParamaterReference): Likewise.
14079 (Block.IsLocalParameter): Likewise. Simplify a lot.
14080 (ToplevelBlock.Parameters): New. Moved from Block.
14081 (ToplevelBlock.ToplevelBlock): Update to changes. Always
14082 initialize Parameters to a non-null value.
14083 * cs-parser.jay: Update to changes.
14084 * ecore.cs (SimpleName.SimpleNameResolve): Emit cs0136 error for
14085 simple names that mean different things in the same block. Use
14086 Block.IsVariableNameUsedInBlock.
14088 2005-03-28 Raja R Harinath <rharinath@novell.com>
14090 * typemanager.cs (TypeHandle.BaseType): Make into an IMemberContainer.
14091 (TypeHandle.TypeHandle): Use LookupMemberCache rather than
14092 GetTypeHandle. It is possible for a reflected type to derive from
14093 a TypeBuilder (e.g., int[] derives from the TypeBuilder
14094 System.Array during mscorlib compilation).
14095 * decl.cs (MemberCache.MemberCache): If the base cache doesn't
14096 contain a method_hash, don't create one either. Don't create a
14097 deep copy of the base cache's method_hash.
14098 (MemberCache.SetupCache): Rename back from DeepCopy.
14099 (MemberCache.AddMethods): Rewrite, now that method_hash isn't
14100 already initialized. If we see an override function, add its
14101 underlying base virtual function to the member_hash too.
14103 * enum.cs (Enum.LookupEnumValue): Remove debugging code.
14105 2005-03-26 Raja R Harinath <harinath@acm.org>
14108 * assign.cs (Assign.DoResolve): When the RHS of an assignment
14109 fails to resolve, ensure that the LHS is still resolved as an
14112 2005-03-25 Raja R Harinath <harinath@acm.org>
14114 * enum.cs (Enum.DefineType): Set ec.InEnumContext and
14116 (Enum.current_ec): Remove.
14117 (Enum.LookupEnumValue): Remove EmitContext argument.
14118 Just uses the one created during DefineType.
14119 (Enum.FindMembers): Update.
14120 * expression.cs (MemberAccess.DoResolve): Update.
14122 2005-03-22 Marek Safar <marek.safar@seznam.cz>
14124 * assign.cs (Assign.DoResolve): Check for CS1717 when
14125 source and target are same (uses Equals).
14127 * expression.cs (LocalVariableReference, ParameterReference,
14128 This): Implemented Equals, GetHashCode.
14130 * statement.cs (Block.GetParameterReference): Removed useless
14133 2005-03-22 Raja R Harinath <rharinath@novell.com>
14136 * statement.cs (Block.AddVariable): Ensure that we skip implicit
14137 blocks before deciding whether the error is cs0136 or cs0128.
14139 * cs-parser.jay: Pass MemberName to RootContext.Tree.RecordDecl.
14140 (using_alias_directive, using_namespace_directive): Pass
14141 MemberName, not an expression to Namespace.UsingAlias and
14143 (MakeName): Use the MemberName of the namespace.
14144 * namespace.cs (Namespace.MemberName): New.
14145 (UsingEntry.UsingEntry): Take a MemberName, not an expression.
14146 (AliasEntry.AliasEntry, Namespace.Using, Namespace.UsingAlias):
14148 * decl.cs (MemberName.Name): Make readonly.
14149 (MemberName.FromDotted): New "constructor".
14150 (MemberName.Equals, MemberName.GetHashCode): Implement overrides.
14151 (MemberCore.Name): Compute from MemberName on demand.
14152 (MemberCore.SetMemberName): Provide a way to change the
14154 (MemberCore.AddToContainer): Don't take a fullname parameter.
14155 * class.cs (TypeContainer.AddToMemberContainer): Don't add the
14156 fully qualified name of the container to the member name.
14157 (TypeContainer.AddToTypeContainer): Use a fully qualified name
14158 only if the type is a member of the root container.
14159 (TypeContainer.AddMethod, TypeContainer.AddProperty): Use
14160 MemberName.Left rather than searching for an embedded ".".
14161 (PartialContainer.CreatePart): Update to changes in RootContext.
14162 (MemberBase.ShortName): Turn into a property. Use
14163 MemberCore.SetMemberName.
14164 (MemberBase.ExplicitInterfaceName): Remove.
14165 (MemberBase.UpdateMemberName): Remove.
14166 (AbstractPropertyEventMethod.UpdateName): Use SetMemberName.
14167 (PropertyBase.SetMemberName): New override.
14168 * tree.cs (Tree.RecordDecl): Take a MemberName and use it as hash key.
14169 (Tree.GetDecl): New.
14170 (Tree.AllDecls): Rename from Decls.
14171 * attribute.cs, enum.cs, report.cs: Update to changes.
14172 * driver.cs (MainDriver): Use MemberName.FromDotted on
14173 RootContext.MainClass.
14175 2005-03-21 Marek Safar <marek.safar@seznam.cz>
14177 * class.cs (FixedField.Define): Check for CS1664 and more sanity
14180 * expression.cs (ElementAccess.DoResolveLValue): Check for CS1708.
14182 2005-03-18 Marek Safar <marek.safar@seznam.cz>
14184 * modifiers.cs (Modifiers.PROPERTY_CUSTOM): New constant for
14185 property accessor modifiers.
14187 * class.cs (FieldMember.ApplyAttributeBuilder): Don't allow apply
14188 fixed buffer attribute (CS1716).
14189 (PropertyMethod.HasCustomAccessModifier): When property accessor
14190 has custom modifier.
14192 * ecore (PropertyExpr.DoResolve): Add CS0271 for custom accessor
14194 (PropertyExpr.DoResolveLValue): Add CS0272.
14196 2005-03-17 Miguel de Icaza <miguel@novell.com>
14198 * convert.cs: When converting to a pointer, use the proper Conv.U
14199 or Conv.I depending on the source data type.
14201 * cs-tokenizer.cs: Make the size for large decimal constants,
14204 2005-03-17 Martin Baulig <martin@ximian.com>
14206 * anonymous.cs (AnonymousMethod.method_modifiers): Change default
14207 from `Modifiers.INTERNAL' to `Modifiers.PRIVATE'. Fixes #73260.
14209 2005-03-17 Martin Baulig <martin@ximian.com>
14211 * anonymous.cs (AnonymousMethod.EmitMethod): Changed return type
14212 to bool so we can return an error condition.
14213 (AnonymousDelegate.Emit): Check whether AnonymousMethod.EmitMethod()
14216 2005-03-16 Zoltan Varga <vargaz@freemail.hu>
14218 * attribute.cs: Encode ThrowOnUnmappableChar and BestFitMapping
14221 2005-03-16 Raja R Harinath <rharinath@novell.com>
14223 Remove TypeManager.LookupType and TypeManager.LookupTypeDirect.
14224 Refactor to avoid traversing the list of assemblies, and to avoid
14225 string concatenation.
14226 * typemanager.cs (guid_attr_type): Remove.
14227 (negative_hits, pointers, references): Remove hashes.
14229 (GetConstructedType): New. Uses type_hash to handle constructed
14230 types (arrays, references, pointers).
14231 (GetReferenceType, GetPointerType): Use it.
14232 (GetNestedType): New. Uses type_hash to handle nested types of
14234 (LookupType, LookupTypeDirect): Remove.
14235 (CoreLookupType): Inline parts of old LookupTypeDirect code. Use
14236 'types' hash and LookupTypeReflection directly.
14237 (params_string, params_object): Use GetConstructedType.
14238 * namespace.cs (Namespace.cached_types): New. Cache of reflected
14240 (Namespace.Lookup): Use cached_types.
14241 (NamespaceEntry.LookupNamespaceOrType): Inline the functionality
14242 provided by old TypeManager.LookupType.
14243 * rootcontext.cs (MakeFQN): Remove.
14244 * decl.cs (DeclSpace.MakeFQN): Likewise.
14245 (DeclSpace.LookupType): Use TypeManager.GetNestedType.
14246 * expression.cs (ComposedCast.DoResolveAsTypeStep): Use
14247 TypeManager.GetConstructedType.
14248 * tree.cs (decl_ns_hash, LookupByNamespace): Remove.
14250 2005-03-15 Marek Safar <marek.safar@seznam.cz>
14252 * class.cs (MethodCore.CheckBase): Report CS1715 for properties and
14255 * cs-parser.jay: Reports CS1527 for any namespace element.
14257 * delegate.cs (DelegateCreation.Error_NoMatchingMethodForDelegate):
14260 * expression.cs (ParameterReference.IsAssigned): Changed error to
14262 (Error_WrongNumArguments): Moved CS0245 detection here.
14264 * statement.cs (Return.Resolve): Add CS1622 report.
14266 2005-03-11 Marek Safar <marek.safar@seznam.cz>
14268 * class.cs (StaticClass.DefineContainerMembers): Added CS0720.
14270 2005-03-11 Zoltan Varga <vargaz@freemail.hu>
14272 * attribute.cs expression.cs: Get rid of some allocations.
14274 2004-03-11 Atsushi Enomoto <atsushi@ximian.com>
14276 * doc.cs : just eliminate the latest change.
14278 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14280 * doc.cs : commented out the latest change. It breaks xml-030.cs
14282 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14284 * doc.cs : When TypeBuilder did not create Type yet, GetEvents() will
14285 fail. So invoke CreateType() in FindDocumentedType().
14287 2004-03-10 Atsushi Enomoto <atsushi@ximian.com>
14289 * cs-tokenizer.cs : added IsKeyword().
14290 * doc.cs : Detect keyword incorrectly used as identifier.
14291 Allow identifiers prefixed by @.
14293 2005-03-10 Marek Safar <marek.safar@seznam.cz>
14295 * attributes.cs (Attributes.Emit): Continue after CheckTargets.
14296 It caused exception in namespace resolving (again!).
14298 * class.cs (Class.ctor): Removed exit.
14299 (PropertyMethod.ctor): ditto.
14301 * codegen.cs (Codegen.Reset): Reset static data.
14302 (Codegen.ResolveTopBlock): Forward error status from ResolveMeta.
14304 * cs-tokenizer.cs (Cleanup): Removed.
14306 * driver.cs (GetSystemDir): Rewrote to one line command.
14307 It caused problem with unloaded dynamic modules.
14308 (UnixParseOption): Removed Exit.
14309 (CompilerCallableEntryPoint.InvokeCompiler): Make static.
14310 (CompilerCallableEntryPoint.Reset): Reset suitable static data.
14311 Now can be mcs used as library.
14313 * ecore.cs (Expression.ResolveBoolean): Use Location.Null for
14316 * location.cs (Reset): Reset static data.
14318 * namespace.cs (Reset): Reset static data.
14320 * report.cs (Report.Reset): Reset static data.
14322 * rootcontext.cs (RootContext.Reset): Reset static data.
14324 * tree.cs (RootTypes.ctor): Use Location.Null
14326 * typemanager.cs (TypeManager.Reset): Reset static data.
14327 (CoreLookupType): Removed Exit.
14328 (TypeHandle.Reset): Reset static data.
14330 2005-03-10 Raja R Harinath <rharinath@novell.com>
14333 * typemanager.cs (ComputeNamespaces): Import namespaces from
14334 referenced modules too.
14336 2005-03-09 Raja R Harinath <rharinath@novell.com>
14338 * class.cs (TypeContainer.AddToMemberContainer): Use "." rather
14341 2005-03-09 Raja R Harinath <rharinath@novell.com>
14343 * decl.cs (DeclSpace.LookupType): Don't loop but recurse into
14344 enclosing DeclSpace. This ensures that a name-lookup populates
14345 more caches and there are fewer 'TypeExpression's. Carve out
14346 nested type lookup into ...
14347 (LookupNestedTypeInHierarchy): ... this.
14349 2005-03-09 Raja R Harinath <rharinath@novell.com>
14351 Clean up a few partial-class semantics.
14352 Fixes test-357.cs and cs1618-2.cs.
14353 * cs-parser.jay (struct_declaration): Use 'current_class' as
14354 parent of newly-created struct. Remove call to Register ().
14355 Use 'pop_current_class' to complete handing the current struct.
14356 (interface_declaration): Likewise.
14357 (class_declaration): Likewise.
14358 (enum_declaration): Use 'current_class' as parent of newly created
14360 (delegate_declaration): Likewise.
14361 (pop_current_class): New function. This is used to handle closing
14362 up the 'current_class' and 'current_container', and pointing them
14363 to the enclosing class/container.
14364 (CSharpParser): Initialize 'current_class' too.
14365 * decl.cs (MemberCore): Add check for invariant: a partial
14366 container is not a parsed entity, and thus does not enclose any
14368 (DeclSpace.TypeResolveEmitContext): Expose 'type_resolve_ec'.
14369 (DeclSpace.BaseTypeExpr): Use it.
14370 (DeclSpace.LookupType): Add check for invariant.
14371 * class.cs (TypeContainer): Add check for invariant: a nested
14372 class should have the same NamespaceEntry as its enclosing class.
14373 (TypeContainer.EmitFieldInitializers): Make virtual.
14374 (TypeContainer.DefineDefaultConstructor): Adhere to invariant in
14376 (TypeContainer.Register): Remove.
14377 (TypeContainer.DefineType): Set the 'ec' of a PartialContainer to
14378 null. Use TypeResolveEmitContext for resolving base types and
14379 interfaces. Move initialization of Parts.TypeBuilder here from
14381 (TypeContainer.DefineNestedTypes): ... here.
14382 (PartialContainer): Take a Namespace not a NamespaceEntry.
14383 (PartialContainer.Create): Don't use Register. Call the
14384 appropriate Add... function directly.
14385 (ClassPart): Take both the PartialContainer and the enclosing
14386 class as constructor arguments.
14387 (ClassPart.EmitFieldInitializers): Override.
14388 (ClassPart.PartFindNestedTypes): Remove.
14389 (FieldBase.GetInitializerExpression): Resolve the initializer
14390 expression in the emit context of the enclosing class.
14391 * tree.cs (RootTypes): Remove Register ().
14393 2005-03-08 Marek Safar <marek.safar@seznam.cz>
14395 * cs-parser.jay: Removed CS0134.
14397 * driver.cs: Removed CS1901.
14399 * expression.cs (SizeOf.DoResolve): Don't report CS0233
14400 for predefined types.
14402 2005-03-07 Duncan Mak <duncan@novell.com>
14404 * codegen.cs (Save): Catch UnauthorizedAccessException as
14405 well. Fixes bug #73454.
14407 2005-03-07 Marek Safar <marek.safar@seznam.cz>
14409 * cs-tokenizer.cs (xtoken): Add CS1035.
14411 * class.cs (MethodData.Define): Add CS0683.
14412 (FieldMember.ctor): Add CS0681.
14414 2005-03-07 Raja R Harinath <rharinath@novell.com>
14416 * ecore.cs (SimpleName.DoResolve): Rename from
14417 SimpleName.DoResolveAllowStatic.
14418 (SimpleName.DoSimpleNameResolve): Remove 'allow_static' argument.
14419 Pass 'intermediate' flag to MemberStaticCheck.
14420 (SimpleName.MemberStaticCheck): Skip "static check" only in case
14421 of "intermediate" lookups via MemberAccess.
14422 (SimpleName.IdenticalNameAndTypeName): New. Carved out of ...
14423 * expression.cs (MemberAccess.IdenticalNameAndTypeName): ... this.
14425 2005-03-07 Raja R Harinath <rharinath@novell.com>
14428 * ecore.cs (FieldExpr.EmitInstance): Catch cases of CS0120 that
14429 slipped in because of variable names that are identical to a
14430 builtin type's BCL equivalent ('string String;', 'int Int32;').
14431 (PropertyExpr.EmitInstance): Likewise.
14433 2005-03-04 Marek Safar <marek.safar@seznam.cz>
14435 * cs-tokenizer.cs (PreProcessPragma): Add warning 1633, 1635.
14437 * report.cs (warning_ignore_table): Made public.
14439 2005-03-04 Raja R Harinath <rharinath@novell.com>
14442 * class.cs (MethodData.Emit): Pass 'container' to
14443 container.GetObsoleteAttribute instead of 'container.Parent'.
14445 2005-03-03 Marek Safar <marek.safar@seznam.cz>
14447 * cs-parser.jay: Add 1534 error test.
14449 * iterators.cs (Yield.CheckContext): Add error 1629.
14450 (Iterator.ctor): Save unsafe modifier.
14451 (MoveNextMethod.DoEmit): Restore unsafe context.
14453 * namespace.cs (UsingAlias): Better error message.
14455 2005-03-03 Dan Winship <danw@novell.com>
14457 * convert.cs (Error_CannotImplicitConversion): fix two bugs in
14458 the warning message [#73219]
14460 2005-03-03 Raja R Harinath <rharinath@novell.com>
14462 Fix compile with MCS 1.0.0.0.
14463 * cs-tokenizer.cs (PreProcessPragma): Simplify w_disable and
14464 w_restore to not depend on string constant folding.
14466 2005-03-03 Raja R Harinath <rharinath@novell.com>
14468 * decl.cs (DeclSpace.LookupType): Remove 'silent' argument. Move
14469 CS0246 check to users who passed 'silent = false'.
14470 * ecore.cs (TypeLookupExpression.DoResolveAsTypeStep): Add CS0246
14472 (SimpleName.SimpleNameResolve): Update.
14473 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add CS0246 check.
14474 (MemberAccess.IdenticalNameAndTypeName): Update.
14475 * doc.cs (FindDocumentedTypeNonArray): Update.
14477 2005-03-03 Raja R Harinath <rharinath@novell.com>
14479 * codegen.cs (EmitContext): Remove ResolvingTypeTree.
14480 * parameters.cs (ComputeAndDefineParameters): Remove.
14481 * decl.cs (ResolveBaseTypeExpr): Don't set ResolvingTypeTree.
14482 * delegate.cs (Define): Don't invoke ComputeAndDefineParameters.
14483 Use GetParameterInfo.
14485 2005-03-02 Marek Safar <marek.safar@seznam.cz>
14487 * report.cs (StaticClass.DefineContainerMembers): Add warning 628.
14489 2005-03-02 Raja R Harinath <rharinath@novell.com>
14491 Unify DeclSpace.LookupType and DeclSpace.FindType.
14492 * decl.cs (DeclSpace.FindNestedType): New virtual function. This
14493 is in charge of defining nested types on demand.
14494 (DeclSpace.LookupType): Use it when the current_type is a
14495 TypeBuilder. Use LookupTypeDirect for reflected types.
14496 (DeclSpace.FindType): Remove.
14497 (DeclSpace.LookupInterfaceOrClass): Likewise.
14498 (DeclSpace.DefineTypeAndParents): Likewise.
14499 * ecore.cs (SimpleName.ResolveAsTypeStep): Just call
14500 DeclSpace.LookupType.
14501 * doc.cs (FindDocumentedTypeNonArray): Use DeclSpace.LookupType.
14502 * typemanager.cs (LookupType): Simplify.
14503 (AddUserType): Remove type from negative_hits.
14504 * namespace.cs (Namespace.Lookup): Use TypeManager.LookupTypeDirect.
14505 * class.cs (TypeContainer.FindMembers): Move handling of nested
14507 (TypeContainer.FindMembers_NestedTypes): ... here.
14508 (TypeContainer.FindNestedType): Implement override.
14509 (ClassPart.FindNestedType): Delegate to PartialContainer.
14510 (ClassPart.PartFindNestedType): Looks up the nested types of the
14513 2005-03-02 Martin Baulig <martin@ximian.com>
14515 * class.cs (TypeContainer.DoDefineMembers): We also need a default
14516 static constructor in static classes.
14518 2005-03-01 Zoltan Varga <vargaz@freemail.hu>
14520 * attribute.cs: Pass -1 to DefineLPArrayInternal if sizeConst or
14521 sizeParamIndex is not specified.
14523 2005-03-01 Marek Safar <marek.safar@seznam.cz>
14526 * report.cs (WarningMessage.IsEnabled): Missing null check.
14528 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14530 * attribute.cs (DefinePInvokeMethod): Fix, all data are stored
14531 in the fields and not in the properties.
14533 2005-02-28 Zoltan Varga <vargaz@freemail.hu>
14535 * attribute.cs (GetMarshal): Marshal SizeConst and SizeParamIndex
14538 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14540 * attribute.cs: Small refactoring (improved robustness).
14541 (ImplOptions, UnmanagedType, UsageAttribute): Removed members.
14542 (ValidateGuid): Removed.
14543 (Resolve): Removed referenced to above mentioned.
14544 (GetAttributeUsage): Made private and changed to work without
14546 (GetIndexerAttributeValue): Don't crash.
14547 (GetConditionalAttributeValue): Ditto.
14548 (GetClsCompliantAttributeValue): Ditto.
14549 (ExtractSecurityPermissionSet): All attributes exceptions are
14551 (GetPropertyValue): New helper.
14552 (GetMethodImplOptions): New method.
14553 (DefinePInvokeMethod): Reuse common code. Implemented handling of
14554 some missing properties.
14556 * class.cs (ClassOrStruct.ApplyAttributeBuilder): Updated.
14557 (Method.ApplyAttributeBuilder): Updated.
14559 * decl.cs (DeclSpace.ApplyAttributeBuilder): Don't catch shared
14562 2005-02-28 Raja R Harinath <rharinath@novell.com>
14565 * report.cs (Report.SymbolRelatedToPreviousError): Handle
14566 non-simple types (array, pointer, reference).
14568 2005-02-28 Marek Safar <marek.safar@seznam.cz>
14570 * cs-parser.jay: Add errors 1617, 650, 1007, 531, 547, 548
14572 * class.cs (MethodCore.IsDuplicateImplementation): Special error
14574 (Method.CheckBase): Catch wrong destructor here.
14575 (MethodData.Define): Add errors 550, 668.
14577 * cs-tokenizer.cs (PreProcessPragma): Add warning 1634.
14579 * ecore.cs (PropertyExpr.DoResolveLValue): Fixed wrong error code.
14581 * pending.cs (VerifyPendingMethods): Add error 551.
14583 * typemanager.cs (CSharpName): Next error report helper.
14585 2005-02-25 Marek Safar <marek.safar@seznam.cz>
14587 * attribute.cs (Atttribute.Resolve): Add cache for parameter-less
14588 attributes. Removed useless attribute double check.
14589 It saves almost 2MBs for corlib.
14591 2005-02-25 Raja R Harinath <rharinath@novell.com>
14594 * statement.cs (ExpressionStatement.Resolve): Make robust to being
14595 called twice in case of error.
14597 2005-02-23 Chris Toshok <toshok@ximian.com>
14599 Fix compiler portions of #72827.
14600 * statement.cs (Block.Emit): call Begin/EndScope on the
14601 EmitContext instead of the ILGenerator.
14603 * codegen.cs (EmitContext.BeginScope): new method, call
14604 ILGenerator.BeginScope as well as the SymbolWriter's OpenScope (if
14606 (EmitContext.BeginScope): same, but EndScope and CloseScope
14608 * symbolwriter.cs (SymbolWriter.OpenScope): get the current il
14609 offset and call the superclass's OpenScope(int) with it.
14610 (SymbolWriter.CloseScope): get the current il
14611 offset and call superclass's CloseScope(int) with it.
14613 2005-02-23 Marek Safar <marek.safar@seznam.cz>
14615 * anonymous.cs (AnonymousMethod.Compatible): Fixed to report
14616 CS1677 for out and ref as well.
14618 * class.cs (Method.Define): Add error CS1599 detection.
14620 * cs-parser.jay: Add CS1609, CS1670, CS1627 detection.
14622 * cs-tokenizer.cs (xtoken): Add error CS1646 detection.
14624 * delegate.cs (Delegate.Define): Add error CS1599 detection.
14626 * support.cs.cs (ModifierDesc): New helper method.
14628 2005-02-23 Raja R Harinath <rharinath@novell.com>
14629 Abin Thomas <projectmonokochi@rediffmail.com>
14630 Anoob V E <projectmonokochi@rediffmail.com>
14631 Harilal P R <projectmonokochi@rediffmail.com>
14633 Fix #57851, #72718.
14634 * class.cs (ConstructorBuilder.Resolve): Make sure that the second
14635 MemberLookup (used for error reporting) actually returns a result.
14636 Fix error report number (122, not 112).
14638 2005-02-22 Abin Thomas <projectmonokochi@rediffmail.com>
14639 Anoob V E <projectmonokochi@rediffmail.com>
14640 Harilal P R <projectmonokochi@rediffmail.com>
14643 * pending.cs (PendingImplementation.GetAbstractMethods):
14644 Find NonPublic members too.
14646 2005-02-22 Marek Safar <marek.safar@seznam.cz>
14648 * expression.cs.cs (ConditionalLogicalOperator.DoResolve):
14651 * class.cs (MethodCore.CheckMethodAgainstBase):
14652 Add error 239 report.
14654 2005-02-21 Raja R Harinath <rharinath@novell.com>
14657 * expression.cs (Invocation.IsApplicable): Make public.
14658 (Invocation.IsParamsMethodApplicable): Likewise.
14659 * delegate.cs (Delegate.VerifyApplicability): Don't use
14660 Invocation.VerifyArgumentCompat for parameter applicability
14661 testing. Use Invocation.IsApplicable and
14662 Invocation.IsParamsMethodApplicable.
14664 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14666 * ecore.cs (PropertyExpr.DoResolve): Add error 214 report.
14668 * class.cs (Operator.Define): Add error 217 report.
14670 2005-02-21 Raja R Harinath <rharinath@novell.com>
14672 * namespace.cs (UsingEntry.Resolve): Undo change below.
14674 2005-02-21 Raja R Harinath <rharinath@novell.com>
14677 * ecore.cs (Expression.MemberLookupFailed): Add argument to
14678 disable the error message when the extended MemberLookup also
14680 (Expression.MemberLookupFinal): Update.
14681 (SimpleName.DoSimpleNameResolve): Update.
14682 * expression.cs (MemberAccess.ResolveNamespaceOrType):
14683 Don't use MemberLookupFinal.
14684 (New.DoResolve): Update.
14685 (BaseAccess.CommonResolve): Update.
14687 2005-02-21 Raja R Harinath <rharinath@novell.com>
14690 * attribute.cs (Attribute.ResolveType): If a 'resolve_error' had
14691 occured previously, don't resolve again.
14693 2005-02-21 Marek Safar <marek.safar@seznam.cz>
14696 * attribute.cs (Attribute.GetAttributeUsage): Add EmitContext
14697 argument. Call ResolveAttributeUsage for unresolved.
14698 when types doesn't match ctor arguments.
14700 * class.cs (DoDefineMembers.TypeContainer): Removed safety check
14701 for nested attribute classes.
14702 (Class.attribute_usage): Removed.
14703 (Class.ResolveAttributeUsage): Resolves AttributeUsageAttribute
14704 for attribute class.
14706 * ecore.cs (IsAttribute): Removed.
14708 * namespace.cs (UsingEntry.Resolve): Don't destroy NamespaceEntry.
14710 * rootcontext.cs (RegisterAttribute): Removed, attributes are
14712 (attribute_types): Removed.
14713 (EmitCode): Global attributes are emited as the latest.
14715 2005-02-18 Marek Safar <marek.safar@seznam.cz>
14717 * class.cs (EmitFieldInitializers): Don't emit field initializer
14718 for default values when optimilization is on.
14720 * constant.cs (Constant.IsDefaultValue): New property.
14722 * driver.cs: Add /optimize handling.
14726 * literal.cs: Implement new IsDefaultValue property.
14728 * rootcontext.cs (Optimize): New field, holds /optimize option.
14730 2005-02-18 Raja R Harinath <rharinath@novell.com>
14732 Fix crasher in re-opened #72347.
14733 * namespace.cs (Namespace.Lookup): Return null if
14734 DeclSpace.DefineType returns null.
14737 * expression.cs (Argument.Resolve): Handle a case of CS0120 here.
14739 2005-02-18 Raja R Harinath <rharinath@novell.com>
14741 Fix remainder of #63202. Change semantics of DoResolveLValue: it
14742 now returns null if it cannot resolve to an lvalue.
14743 * ecore.cs (Expression.DoResolveLValue): Return 'null' by default.
14744 (Expression.ResolveLValue): Emit CS0131 error if DoResolveLValue
14745 returned null. Remove check for SimpleName.
14746 (EventExpr.DoResolveLValue): New.
14747 * iterators.cs (Iterator.FieldExpression.DoResolveLValue): New.
14748 * expression.cs (Argument.Error_LValueRequired): New. Move CS1510
14750 (Argument.Resolve): ... here. Use it. Use DoResolveLValue to
14751 avoid CS0131 error.
14752 (Unary.ResolveOperator): Move CS0211 check ...
14753 (Unary.DoResolve): ... here. Use DoResolveLValue to avoid
14755 (Unary.DoResolveLValue): Simplify.
14756 (AddressOf.DoResolveLValue): New.
14757 (ArrayAccess.DoResolveLValue): New.
14759 2005-02-16 Marek Safar <marek.safar@seznam.cz>
14761 * attribute.cs (Attribute.Resolve): Add arguments casting for
14762 when types doesn't match ctor arguments.
14764 2005-02-16 Raja R Harinath <rharinath@novell.com>
14766 Fix parts of #63202.
14767 * expression.cs (UnaryMutator.ResolveOperator): Remove redundant
14768 lookup of operator in base type. Ensure that all checks happen
14769 when the operator resolves to an "op_..." method.
14771 2005-02-15 Raja R Harinath <rharinath@novell.com>
14774 * namespace.cs (NamespaceEntry.LookupNamespaceOrType): Add
14775 'ignore_cs0104' parameter. Pass it to ...
14776 (NamespaceEntry.Lookup): ... this.
14777 * decl.cs (DeclSpace.LookupType): Add 'ignore_cs0104' parameter.
14778 * ecore.cs (SimpleName.ResolveAsTypeStep): Update.
14779 (TypeLookupExpression.DoResolveAsTypeStep): Update.
14780 * expression.cs (MemberAccess.IdenticalNameAndTypeName):
14781 Update. Request that cs0104 errors be ignored.
14782 (ComposedCast.ResolveAsTypeStep): Update.
14784 2005-02-14 Raja R Harinath <rharinath@novell.com>
14787 * expression.cs (Invocation.BetterFunction): Remove support for
14788 comparing virtual functions and their overrides.
14789 (Invocation.IsOverride): New.
14790 (Invocation.OverloadResolve): Don't consider 'override' functions
14791 during candidate selection. Store them in a lookaside list.
14792 If the selected method is a 'virtual' function, use the list to
14793 find any overrides that are closer to the LHS type.
14795 2005-02-14 Marek Safar <marek.safar@seznam.cz>
14797 * expression.cs (New.DoResolve): Add complex core type reduction.
14798 (New.Constantify): Converts complex core type syntax like 'new int ()'
14799 to simple constant.
14801 2005-02-14 Raja R Harinath <rharinath@novell.com>
14803 * decl.cs (EntryType.EntryType): New constructor to create an
14804 updated copy of a cache entry.
14805 (MemberCache.AddMethods): Use it.
14806 (MemberCache.ClearDeclaredOnly): Remove.
14807 (MemberCache.MemberCache): Update.
14809 2005-02-11 Miguel de Icaza <miguel@novell.com>
14811 * codegen.cs (EmitContext): Introduce the `MethodIsStatic'
14812 variable. This one is represents the actual low-level declaration
14813 of the method, as opposed to the semantic level `IsStatic'.
14815 An anonymous method which is hosted into a static method might be
14816 actually an instance method. IsStatic would reflect the
14817 container, while MethodIsStatic represents the actual code
14820 * expression.cs (ParameterReference): Use the new MethodIsStatic
14821 instead of IsStatic.
14823 * anonymous.cs (AnonymousMethod.Compatible): Pass the
14824 Modifiers.STATIC to the Anonymous' Method EmitContext if static is
14825 set on the current EmitContext.
14827 * expression.cs (Cast): Overload DoResolveLValue so we can pass
14828 resolve our casted expression as an LValue. This triggers the
14829 proper LValue processing that is later required by Assign.
14833 * cs-tokenizer.cs (pp_and): recurse on pp_and, fixes #61903.
14835 2005-02-11 Marek Safar <marek.safar@seznam.cz>
14837 C# 2.0 Fixed buffer implementation
14839 * anonymous.cs: Update after RegisterHelperClass renaming.
14841 * attribute.cs (AttributeTester.fixed_buffer_cache):
14842 Cache of external fixed buffers.
14843 (AttributeTester.GetFixedBuffer): Returns IFixedBuffer
14844 implementation if field is fixed buffer else null.
14847 (TypeContainer.AddField): Accept FieldMember instead of Field.
14848 (FieldBase.IsFieldClsCompliant): Extracted code from
14849 VerifyClsCompliance descendant customization.
14850 (FixedField): New class handles fixed buffer fields.
14851 (FixedFieldExternal): Keeps information about imported fixed
14853 (IFixedField): Make access to internal or external fixed buffer
14856 * cs-parser.jay: Add fixed buffer parsing.
14858 * ecore.cs (FieldExpr.Emit): Add special emit case for fixed
14861 * expression.cs (Indirection): Extended implementation to accept
14862 fixed buffer field.
14863 (PointerArithmetic.Emit): Get element from fixed buffer as well.
14864 (ElementAccess.MakePointerAccess): Get type as parameter.
14865 (DoResolve): Add fixed buffer field expression conversion.
14866 (DoResolveLValue): Ditto.
14867 (FixedBufferPtr): New class. Moved most of original ArrayPtr.
14868 (ArrayPtr): Derives from FixedBufferPtr.
14869 (ArrayPtr.Emit): Add extra emit for array elements.
14871 * flowanalysis.cs.cs (StructInfo): Use FieldMember.
14873 * rootcontext.cs (CloseTypes): Emit CompilerGenerated attribute
14874 for compiler generated types.
14875 (RegisterCompilerGeneratedType): Renamed from RegisterHelperClass.
14877 * statement.cs (Fixed): Refactored to be easier add fixed buffer
14878 and consume less memory.
14879 (Fixed.Resolve): Add fixed buffer case.
14881 * typemanager.cs (compiler_generated_attr_ctor,
14882 fixed_buffer_attr_ctor): Add new 2.0 compiler attributes.
14883 (HasElementType): Add our own implementation to work on every
14886 2005-02-11 Miguel de Icaza <miguel@novell.com>
14888 * anonymous.cs (CaptureContext): Track whether `this' has been
14891 * expression.cs (This.ResolveBase): Call CaptureThis. Before we
14892 only captured `this' if it was implicitly done (instance
14893 methods/variables were used).
14895 * codegen.cs (EmitContext.CaptureThis): New method to flag that
14896 `this' must be captured.
14898 2005-01-30 Miguel de Icaza <miguel@novell.com>
14900 * anonymous.cs (CreateMethodHost): If there Scope.ScopeTypeBuilder
14901 is null it means that there has been no need to capture anything,
14902 so we just create a sibling.
14904 Renamed `EmitHelperClasses' to `EmitAnonymousHelperClasses'
14906 Just a partial fix. The other half is fairly elusive.
14908 2005-02-10 Raja R Harinath <rharinath@novell.com>
14910 Fix #52586, cs0121-4.cs.
14911 * decl.cs (MemberCache.DeepCopy): Rename from SetupCache. Take
14912 and return a hashtable.
14913 (MemberCache.ClearDeclaredOnly): New.
14914 (MemberCache.MemberCache): Update to change. Make a deep copy of
14915 the method_hash of a base type too.
14916 (MemberCache.AddMethods): Adapt to having a deep copy of the base
14917 type methods. Overwrite entries with the same MethodHandle so
14918 that the ReflectedType is correct. The process leaves in base
14919 virtual functions and their overrides as distinct entries.
14920 (CacheEntry): Now a class instead of a struct. It shouldn't alter
14921 matters since it was boxed in a ArrayList before.
14922 (CacheEntry.Member, CacheEntry.EntryType): Remove 'readonly'
14924 * expression.cs (Invocation.BetterFunction): Simplify. Handle the
14925 case of a virtual function and its override (choose the overload
14927 (Invocation.OverloadResolve): Avoid 'override' members during
14928 'applicable_type' calculation.
14930 2005-02-09 Raja R Harinath <rharinath@novell.com>
14932 Combine two near-redundant caches.
14933 * typemanager.cs (method_params): Rename from method_internal_params.
14934 (TypeManager.GetParameterData): New. Replace
14935 Invocation.GetParameterData.
14936 (TypeManager.LookupParametersByBuilder): Remove.
14937 * expression.cs (Invocation.method_parameter_cache): Remove.
14938 (Invocation.GetParameterData): Remove.
14940 * anonymous.cs, attribute.cs, convert.cs, delegate.cs:
14943 2005-02-08 Raja R Harinath <rharinath@novell.com>
14946 * delegate.cs (Delegate.DefineType): When bootstrapping corlib, if
14947 TypeManager.multicast_delegate_type is null, resolve it by looking
14948 up "System.MulticastDelegate".
14949 * rootcontext.cs (RootContext.ResolveCore): Simplify.
14951 2005-02-07 Abin Thomas (NOSIP) <projectmonokochi@rediffmail.com>
14952 Anoob V.E (NOSIP) <projectmonokochi@rediffmail.com>
14953 Harilal P.R (NOSIP) <projectmonokochi@rediffmail.com>
14956 * statement.cs (LabeledStatement.Resolve): Don't set 'referenced'.
14957 (LabeledStatement.AddReference): New. Set 'referenced'.
14958 (Goto.Resolve): Use it.
14960 2005-02-05 John Luke <john.luke@gmail.com>
14962 * driver.cs: remove duplicate -doc line in Usage ()
14964 2005-02-04 Raja R Harinath <rharinath@novell.com>
14966 * location.cs (Location.AddFile): Fix CS2002 error report.
14968 2005-02-02 Martin Baulig <martin@ximian.com>
14970 * delegate.cs (Delegate.DefineType): Report an internal error if
14971 TypeManager.multicast_delegate_type is null. See bug #72015 for
14974 2005-02-02 Raja R Harinath <rharinath@novell.com>
14976 Fix a crasher in a variant of #31984.
14977 * const.cs (Constant.CheckBase): New override that defers the
14978 new-or-override check in case the base type hasn't been populated
14980 (Constant.Define): Ensure the new-or-override check is performed.
14982 2005-02-01 Duncan Mak <duncan@ximian.com>
14984 * const.cs (LookupConstantValue): Check that `ce' is not null
14985 before calling GetValue ().
14987 2005-02-01 Raja R Harinath <rharinath@novell.com>
14989 Fix test-334.cs (#69519).
14990 * cs-parser.jay (using_alias_directive): Pass in an expression to
14991 NamespaceEntry.UsingAlias.
14992 (using_namespace_directive): Pass in an expression to
14993 NamespaceEntry.Using.
14994 (namespace_name): Don't flatten to a string.
14995 * namespace.cs (NamespaceEntry.AliasEntry): Store an expression.
14996 (NamespaceEntry.AliasEntry.Resolve): Lookup using
14998 (NamespaceEntry.UsingEntry): Likewise.
14999 (NamespaceEntry.Using,NamespaceEntry.UsingAlias): Update to
15001 (NamespaceEntry.LookupForUsing): Remove.
15002 (NamespaceEntry.LookupNamespaceOrType): Add support for dotted
15004 (NamespaceEntry.Lookup): Remove support for dotted names.
15006 2005-02-01 Raja R Harinath <rharinath@novell.com>
15008 * namespace.cs (NamespaceEntry.NamespaceEntry): Simplify, and
15010 (NamespaceEntry.ImplicitParent): Compute on demand.
15011 (NamespaceEntry.Doppelganger): New implicit namespace-entry that
15012 parallels the current.
15013 (NamespaceEntry.LookupForUsing): Use it.
15014 (NamespaceEntry.Lookup): If the current namespace-entry is
15015 implicit, don't search aliases and using tables.
15017 2005-02-01 Raja R Harinath <rharinath@novell.com>
15020 * class.cs (TypeContainer.DoDefineMembers): Don't initialize
15022 (TypeContainer.BaseCache): Compute on demand.
15023 (TypeContainer.FindMembers): Define constants and types if they're
15024 not already created.
15025 (FieldMember.Define): Move resetting of ec.InUnsafe before error
15027 * const.cs (Constant.Define): Make idempotent.
15029 2005-01-29 Miguel de Icaza <miguel@novell.com>
15031 * pending.cs: Produce better code (no nops produced by using Ldarg
15034 * pending.cs (PendingImplementation.DefineProxy): It was not `arg
15035 i - 1' it should be arg + 1.
15039 2005-01-28 Raja R Harinath <rharinath@novell.com>
15041 * attribute.cs (Attribute.CheckAttributeType): Make private
15043 (Attribute.ResolveType): Make virtual.
15044 (GlobalAttribute.ResolveType,GlobalAttribute.Resolve): Simplify
15045 handling of RootContext.Tree.Types.
15047 2005-01-27 Raja R Harinath <rharinath@novell.com>
15049 Update attribute-handling to use the SimpleName/MemberAccess
15051 * cs-parser.jay (attribute): Pass in an expression to the
15052 constructors of Attribute and GlobalAttribute.
15053 * attribute.cs (Attribute): Take an expression for the name.
15054 (Attribute.ResolvePossibleAttributeTypes): New. Resolves the
15055 passed in attribute name expression.
15056 (Attribute.CheckAttributeType): Use it.
15057 * ecore.cs (FullNamedExpression.ResolveAsTypeStep): New.
15058 * expression.cs (MemberAccess.ResolveAsTypeStep): Move body to ...
15059 (MemberAccess.ResolveNamespaceOrType): ... here. Add 'silent'
15060 argument to prevent error messages if the lookup fails.
15062 2005-01-27 Marek Safar <marek.safar@seznam.cz>
15064 * expression.cs (Indirection): Implemented IVariable interface
15065 to support indirection in AddressOf operator.
15066 (PointerArithmetic.Emit): Add optimalization for case where
15067 result can be precomputed.
15069 2005-01-26 Martin Baulig <martin@ximian.com>
15071 * class.cs (TypeContainer.AttributeTargets): Return the correct
15072 AttributeTargets depending on our `Kind' instead of throwing an
15073 exception; fixes #71632.
15075 2005-01-26 Marek Safar <marek.safar@seznam.cz>
15078 * expression.cs (MemberAccess.ResolveMemberAccess): Add CS0176 test for
15081 2005-01-25 Raja R Harinath <rharinath@novell.com>
15084 * expression.cs (MemberAccess.DoResolve): Don't complain with
15085 cs0572 when the LHS of a member access has identical name and type
15088 2005-01-25 Marek Safar <marek.safar@seznam.cz>
15091 * attribute.cs (ExtractSecurityPermissionSet): Catch exceptions from
15093 Create custom PermissionSet only for PermissionSetAttribute.
15095 2005-01-24 Marek Safar <marek.safar@seznam.cz>
15098 * class.cs (StaticClass.DefineContainerMembers): Enable enums and
15099 delegates in static class.
15101 2005-01-24 Martin Baulig <martin@ximian.com>
15103 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
15104 merging an implicit block, just use its reachability.
15106 * statement.cs (Block.Resolve): Make the unreachable code check
15107 work wrt. implicit blocks; see test-337 from #63842.
15109 2005-01-21 Alp Toker <alp@atoker.com>
15111 * cs-parser.jay: destructor_declaration's container is PartialContainer
15112 not Class when partial types are used, so use Kind prop instead of
15115 2005-01-22 Miguel de Icaza <miguel@ximian.com>
15117 * cs-parser.jay: Improve error reporting when an interface
15118 declares new types.
15120 2005-01-20 Dick Porter <dick@ximian.com>
15122 * support.cs: SeekableStreamReader fix from Sandor Dobos
15123 (dobos_s@ibcnet.hu) to cope with Position setting when multibyte
15124 chars are read. Fixes bug 70369.
15126 2005-01-20 Raja R Harinath <rharinath@novell.com>
15128 * cs-parser.jay (catch_clause): Simplify current_block handling
15131 2005-01-17 Miguel de Icaza <miguel@ximian.com>
15133 * convert.cs (ImplicitStandardConversionExists): Synchronize the
15134 code with ImplicitStandardConversion to handle the implicit
15135 conversion of method groups into valid delegate invocations.
15137 The problem is that in parameter handling we were using this code
15138 path. Fixes bug #64698
15140 2005-01-19 Raja R Harinath <rharinath@novell.com>
15142 * cs-parser.jay: Fix several infelicities.
15143 - Avoid assigning to the parser value stack. Code like
15144 '$3 = null' is unclean. Synthesize a value for the code block
15146 - Avoid using oob_stack for storing location information. Use ...
15147 (_mark_): ... this. New (empty) rule. Saves the current location
15149 (foreach_statement): Avoid using oob_stack for current_block
15150 handling. Use technique used in for_statement and
15151 using_statement. Synthesize a value for the code block to store
15152 additional intermediate information.
15154 2005-01-13 Miguel de Icaza <miguel@ximian.com>
15156 * ecore.cs (IsAccessorAccessible): Accessibility to private fields
15157 of a different type is only allowed to private fields of a
15158 containing type, not on fields of a base class.
15160 See test-174.cs and error cs0122-9.cs
15162 2005-01-13 Raja R Harinath <rharinath@novell.com>
15164 Fix test-335.cs (bug #58126).
15165 * cs-parser.jay (argument): Split out non-expression parts of the
15166 rule into 'non_simple_argument'.
15167 (invocation_expression): Support parenthesized invocations with
15168 multiple arguments, and with single non-simple arguments.
15170 2005-01-13 Raja R Harinath <rharinath@novell.com>
15172 * cs-tokenizer.cs (xtoken): Reset 'comments_seen' in a couple more
15175 2005-01-12 Raja R Harinath <rharinath@novell.com>
15177 Fix cs0038-1.cs, cs1640-6.cs.
15178 * ecore.cs (Expression.Resolve): Remove special-case for
15179 SimpleName in error-handling.
15180 (Expression.almostMatchedMembers): Relax access permission to
15182 (Expression.MemberLookupFailed): Handle duplicates in
15183 almostMatchedMembers list.
15184 (SimpleName.DoSimpleNameResolve): Catch CS0038 errors earlier.
15185 * expression.cs (New.DoResolve): Report CS1540 for more cases.
15186 * typemanager.cs (GetFullNameSignature): Use the MethodBase
15187 overload if the passed in MemberInfo is a MethodBase.
15189 2005-01-12 Marek Safar <marek.safar@seznam.cz>
15192 * attribute.cs (ExtractSecurityPermissionSet): Don't report error
15193 for non-CAS & merge permission sets properly.
15195 2005-01-11 Raja R Harinath <rharinath@novell.com>
15197 Improve standard-compliance of simple name and member access
15198 resolution. Fixes bugs #52697, #57200, #67520, #69519.
15199 * ecore.cs (FullNamedExpression): New abstract base class
15200 for Namespaces and TypeExpressions.
15201 (ResolveFlags.SimpleName): Remove.
15202 (SimpleName): Remove support for dotted names.
15203 (SimpleName.ResolveAsTypeStep): Simplify. Now just a wrapper to
15204 DeclSpace.FindType and DeclSpace.LookupType.
15205 (SimpleName.DoSimpleNameResolve): Remove support for dotted names.
15206 (Expression.ExprClassName): Make member function.
15207 * expression.cs (MemberAccess.ResolveAsTypeStep): Support LHS being
15208 a namespace. Remove creation of dotted "SimpleName"s.
15209 (MemberAccess.DoResolve): Likewise.
15210 * decl.cs (DeclSpace.Cache): Make private.
15211 (DeclSpace.LookupInterfaceOrClass): Return a FullNamedExpression.
15212 (DeclSpace.FindType): Update.
15213 (DeclSpace.LookupType): Move here from RootContext. Return a
15214 FullNamedExpression.
15215 * namespace.cs (Namespace): Derive from FullNamedExpression
15216 so that it can be part of expression resolution.
15217 (Namespace.Lookup): Return an FullNamedExpression.
15218 (NamespaceEntry.LookupAlias): Lookup aliases only in current
15220 * rootcontext.cs (NamespaceLookup): Remove.
15221 (LookupType): Move to DeclSpace.
15222 * attribute.cs (CheckAttributeType): Update.
15223 * doc.cs (FindDocumentedType): Remove allowAlias argument.
15224 (FindDocumentedTypeNonArray): Likewise.
15226 2005-01-11 Raja R Harinath <rharinath@novell.com>
15228 Fix cs0509.cs, cs1632.cs.
15229 * class.cs (TypeContainer.GetNormalBases): Don't assume !IsClass
15230 is the same as IsInterface.
15231 (TypeContainer.GetClassBases): Likewise.
15232 * statement.cs (LabeledStatement.ig): New field.
15233 (LabeledStatement.LabelTarget): Save ILGenerator which created the
15235 (LabeledStatement.DoEmit): Check that the label was created with
15236 the same ILGenerator.
15238 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15241 * attribute.cs (GetMethodObsoleteAttribute): Need to transform
15242 accessors to its properties.
15244 * ecore.cs (PropertyExpr): Add AccessorTable to help track back
15245 from accessors to property.
15247 2005-01-10 Marek Safar <marek.safar@seznam.cz>
15250 * class.cs (MethodCore.CheckBase): Test base method obsoleteness
15251 only for overrides.
15253 2005-01-08 Miguel de Icaza <miguel@ximian.com>
15255 * attribute.cs: Check for null and empty strings.
15257 I have lost another battle to Paolo.
15259 2005-01-07 Marek Safar <marek.safar@seznam.cz>
15262 * class.cs (PropertyMethod): Set Parent field in ctors.
15263 (SetMethod.InternalParameters): Add unsafe switch hack.
15264 Override MarkForDuplicationCheck where it is appropriate.
15266 * decl.cs (MemberCore.MarkForDuplicationCheck): New method.
15267 It says whether container allows members with the same name.
15268 Base default is no.
15269 (DeclSpace.AddToContainer): Use MarkForDuplicationCheck.
15270 Removed is_method parameter.
15272 2005-01-06 Duncan Mak <duncan@ximian.com>
15274 * cs-tokenizer.cs (xtoken): Redo the work for signaling CS1040
15275 because the previous change led to incorrect reporting of CS1032
15276 ("Cannot define/undefine preprocessor symbols after first token in
15277 file"). Instead of using `tokens_seen' as the only flag that
15278 triggers CS1040, introduce `comments_seen'. This new flag is used
15279 to signify having seen comments on the current line, so it is
15280 unset after a newline.
15282 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15284 * doc.cs : When searching for a type, find nested type too.
15285 This fixes bug #71040.
15287 2005-01-06 Atsushi Enomoto <atsushi@ximian.com>
15290 - Warn missing member comment on those classes which also does not
15291 have doc comments. Fixed bug #71041.
15292 - Don't warn missing doc comment on default constructor.
15295 2005-01-06 Duncan Mak <duncan@ximian.com>
15297 * cs-tokenizer.cs (xtoken): After handling traditional C-style
15298 comments, set `tokens_seen' to true. This allows us to detect
15299 misplaced preprocessor directives (i.e. not at the beginning of
15300 the a line, nor after whitespaces). In that case, report error
15301 CS1040. This fixes bug #56460.
15303 * cs-parser.jay (interface_member_declaration): Add checks for
15304 IsExplicitImpl, and report CS0541 error if an interface member is
15305 defined as an explicit interface declaration.
15307 2005-01-06 Marek Safar <marek.safar@seznam.cz>
15310 * class.cs (PropertyMethod): Set Parent field in ctors.
15311 (SetMethod.InternalParameters): Add unsafe switch hack.
15313 * decl.cs (MemberCore.Parent): Cannot be readonly.
15315 2005-01-06 Raja R Harinath <rharinath@novell.com>
15317 * decl.cs (DeclSpace.ResolveType): Remove.
15318 (DeclSpace.ResolveBaseTypeExpr): Rename from ResolveTypeExpr.
15319 Merge in code from ...
15320 (DeclSpace.GetTypeResolvingEmitContext): ... here. Remove.
15321 * class.cs, enum.cs: Update to changes.
15323 2005-01-06 Miguel de Icaza <miguel@ximian.com>
15325 * anonymous.cs: Ensure that we init the scope of our parent if it
15326 has not been initialized yet.
15328 2004-12-30 Duncan Mak <duncan@ximian.com>
15330 * typemanager.cs (TypeManager.CheckStructCycles): Don't crash here
15331 if field.FieldBuilder is null. Fixes #70758.
15333 * convert.cs: Fixed some typos and updated some of the comments.
15334 (ImplicitStandardConversionExists):
15335 (TryImplicitIntConversion): If `target_type' is an interface and
15336 the type of `ic' implements this interface, return true or a new
15337 BoxedCast instead of null. This fixes #70468.
15339 2004-12-29 Duncan Mak <duncan@ximian.com>
15341 * expression.cs (Argument.Emit): Check that Expr is
15342 IMemoryLocation before casting to it, and report CS1510 otherwise.
15346 2004-12-21 Ben Maurer <bmaurer@ximian.com>
15348 * statement.cs (Block.ThisVariable): remove the recursion here, to
15349 make the --profile more sane.
15351 2004-12-17 Carlos Cortez <calberto.cortez@gmail.com>
15353 * driver.cs: Patch to handle a xsp bug that prevents to reference an .exe
15354 assembly, by JB Evain.
15356 2004-12-17 Raja R Harinath <rharinath@novell.com>
15358 * class.cs, decl.cs, ecore.cs, iterators.cs, pending.cs,
15359 rootcontext.cs, typemanager.cs: Make nomenclature consistent.
15360 "parent" refers to enclosing type/class. "base" refers to superclass.
15362 2004-12-17 Raja R Harinath <rharinath@novell.com>
15364 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15365 Ensure that we only have GlobalAttributes.
15366 * attribute.cs (Attribute.Emit): Make non-virtual.
15367 (GlobalAttribute.Emit): Remove.
15368 (Attribute.Resolve): Make virtual.
15369 (GlobalAttribute.Resolve): New. Set Rootcontext.Tree.Types.NamespaceEntry.
15370 (Attribute.GetConditionalAttributeValue): Take an EmitContext as
15371 the argument. Don't create one.
15372 (Attribute.GetObsoleteAttribute): Likewise.
15373 (Attribute.GetClsCompliantAttributeValue): Likewise.
15374 * class.cs, decl.cs: Update to changes.
15376 2004-12-17 Marek Safar <marek.safar@seznam.cz>
15378 * delegate.cs (NewDelegate.DoResolve): Add error 149 report.
15380 * ecore.cs (Expression.MemberLookupFailed): Fixed error 143.
15382 * statement.cs (Foreach.Resolve): Add error 186 report.
15384 2004-12-16 Marek Safar <marek.safar@seznam.cz>
15386 * expression.cs (Conditional.DoResolve): Add warning 429.
15388 * statement.cs (If.Resolve): Add warning 665.
15390 2004-12-16 Raja R Harinath <rharinath@novell.com>
15392 New invariant: RootContext.Tree.Types.NamespaceEntry == null
15393 except when in the parser, and in GlobalAttribute.
15394 * driver.cs (MainDriver): Reset RootContext.Tree.Types.NamespaceEntry.
15395 * attribute.cs (GlobalAttribute.CheckAttributeType): Reset
15396 RootContext.Tree.Types.NamespaceEntry once work is done.
15397 (GlobalAttribute.Emit): New. Wrapper for Attribute.Emit, but sets
15398 and resets RootContext.Tree.Types.NamespaceEntry.
15400 2004-12-15 Marek Safar <marek.safar@seznam.cz>
15402 * cs-parser.jay: Don't create a block for every variable.
15404 2004-12-14 Miguel de Icaza <miguel@ximian.com>
15406 * location.cs: Provide extra information.
15408 * statement.cs: The instance is not `ldarg_0.THIS' when accessing
15409 variables from the captured environment, it is the ldarg_0.
15411 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15413 * cs-parser.jay: Changed warning level for 642 to 4 until Miguel
15416 * class.cs: Changed warning level for 169 to avoid developer
15417 displeasure from warning flooding. It will be changed back when they
15418 fix most of current BCL warnings.
15420 * RootContext.cs: Pushed default WarningLevel to 3.
15422 * statement.cs: Removed unused variable.
15424 2004-12-14 Marek Safar <marek.safar@seznam.cz>
15426 * class.cs (TypeContainer.GetClassBases): Add error 1521 report.
15427 (TypeContainer.MethodModifiersValid): Refactored to use MemberCore.
15428 Add error 502 report.
15429 (StaticClass.DefineType): Add error 441 report.
15430 (Class.AllowedModifiersProp): New virtual property as temporary
15431 extension to AllowedModifiers.
15432 (Class.DefineType): Add error 418 report. Moved ModFlags check here
15433 to share implementation with StaticClass and don't call virtual
15436 * driver.cs (MainDriver): Add error 1558 test.
15438 * parameter.cs (Parameter.ApplyAttributeBuilder): Add error 662
15439 report. Moved error 36 test here.
15441 * statement.cs (Throw.Resolve): Add error 724 report.
15443 * typemanager.cs: Add out_attribute_type core type.
15445 2004-12-13 Marek Safar <marek.safar@seznam.cz>
15447 * class.cs (TypeContainer.VerifyClsCompliance): Add error
15449 (PropertyBase.VerifyClsCompliance): Add errror 3025 report.
15451 * codegen.cs (ModuleClass.ApplyAttributeBuilder): Add error
15454 * decl.cs (MemberCore.VerifyClsCompliance): Add warning 3021.
15456 * parameter.cs (ReturnParameter.ApplyAttributeBuilder):
15457 Add error 3023 report.
15458 (Parameter.ApplyAttributeBuilder): Add error 3022 report.
15460 * tree.cs (RootTypes.IsClsCompliaceRequired): Add fake
15463 2004-12-12 John Luke <john.luke@gmail.com>
15465 * driver.cs (AddArgs): take -- into account when
15466 adding arguments, fixes bug 65710
15468 2004-12-12 Martin Baulig <martin@ximian.com>
15470 * expression.cs (Unary.TryReduceNegative): Added support for
15471 SByteConstant and ByteConstant.
15472 (Unary.Reduce): Check error values from TryReduceNegative().
15474 2004-12-10 Marek Safar <marek.safar@seznam.cz>
15476 * attributes.cs (Attribute.Resolve): Avoid multiple error report
15477 and report exception as error 182.
15479 2004-12-10 Raja R Harinath <rharinath@novell.com>
15481 * driver.cs (Main): Fix message when there are warnings.
15483 2004-12-09 Miguel de Icaza <miguel@ximian.com>
15485 * delegate.cs: Fixed my fix from yesterday, sorry about that.
15487 2004-12-09 Marek Safar <marek.safar@seznam.cz>
15489 * anonymous.cs, class.cs, convert.cs, doc.cs, support.cs:
15490 Reduced number of warnings.
15492 * class.cs (TypeContainer.VerifyClsCompliance): One if is enough.
15494 2004-12-08 Miguel de Icaza <miguel@ximian.com>
15496 * driver.cs: Removed message.
15498 * delegate.cs: Fix bug introduced in 1.1.x: 70219.
15500 2004-12-08 <vargaz@freemail.hu>
15502 * cs-tokenizer.cs: Add workaround for NET 2.0 beta 1 csc bug.
15504 2004-12-08 Martin Baulig <martin@ximian.com>
15506 * class.cs (TypeContainer.VerifyClsCompliance): Report a CS3003
15507 instead of a CS3002 for properties and indexer.
15509 2004-12-08 Martin Baulig <martin@ximian.com>
15511 * decl.cs (MemberName.ToString): Make this work again.
15513 2004-12-08 Marek Safar <marek.safar@seznam.cz>
15515 * attribute.cs (Resolve): Add error 591 detection.
15517 * class.cs (FieldMember.Define): Add error 1547 detection.
15518 (Indexer.Define): Add error 620 detection.
15519 (Operator.Define): Add error 590 detection.
15521 * ecore.cs: Missing argument for error 79.
15523 * expression.cs (ComposedCast.DoResolveAsTypeStep): Add error 611
15526 2004-12-07 Marek Safar <marek.safar@seznam.cz>
15529 * assign.cs.cs (Assign.DoResolve): Reports error 1648 for value types
15532 2004-12-07 Atsushi Enomoto <atsushi@ximian.com>
15534 * cs-parser.jay : handle doc comments on implicit/explicit operators.
15535 Some operator comments were suppressed.
15536 * doc.cs : Implicit/explicit operator name in doc comments are like
15537 "op_Explicit(type)~returnType", so added suffix handling.
15539 2004-12-07 Martin Baulig <martin@ximian.com>
15542 (MemberCore.GetObsoleteAttribute): Don't create a new EmitContext.
15543 (MemberCore.GetClsCompliantAttributeValue): Likewise.
15544 (DeclSpace.ec): New protected field; store the EmitContext here.
15545 (DeclSpace.EmitContext): New public property; moved here from
15547 (DeclSpace.GetClsCompliantAttributeValue): Don't create a new
15550 * enum.cs (Enum.Define): Store the EmitContext in the `ec' field.
15551 (Enum.Emit): Don't create a new EmitContext.
15553 * delegate.cs (Delegate.DefineType): Always create the
15556 * iterators.cs (Iterators.DefineIterator): Create a new
15557 EmitContext and store it in `ec'.
15559 2004-08-24 Martin Baulig <martin@ximian.com>
15562 (TypeManager.IsSubclassOf): Renamed to IsFamilyAccessible; use
15563 this for accessibility checks.
15564 (TypeManager.IsSubclassOrNestedChildOf): Renamed to
15565 IsNestedFamilyAccessible.
15566 (TypeManager.IsSubclassOf): New method, do what the name actually
15569 2004-12-06 Raja R Harinath <rharinath@novell.com>
15571 Fix crash on cs0657-17.cs.
15572 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
15573 Use RootContext.Tree.Types, not 'new RootTypes ()'.
15574 * attribute.cs (GlobalAttribute.CheckAttributeType): Narrow down
15575 the case where the NamespaceEntry gets overwritten.
15577 2004-12-06 Marek Safar <marek.safar@seznam.cz>
15579 Fixed #69195, #56821
15580 * ecore.cs (ResolveBoolean): Tiny refactoring.
15582 * expression.cs (Binary.DoResolve): Add warning 429 and skipping
15583 of right expression resolving when left is false constant and
15584 operator is LogicalAnd OR true constant and operator is LogicalOr.
15586 * statement.cs (ResolveUnreachable): Always reports warning.
15588 2004-12-05 Miguel de Icaza <miguel@ximian.com>
15590 * class.cs: Distinguish between 1721 and 1722 (just a little help
15591 for the programmer).
15593 2004-12-03 Miguel de Icaza <miguel@ximian.com>
15595 * delegate.cs: Only allow this on new versions of the language.
15597 2004-12-02 Duncan Mak <duncan@ximian.com>
15599 * ecore.cs (PropertyExpr.IsAccessorAccessible): Moved to
15601 (Expression.IsAccessorAccessible): Moved from the PropertyExpr to
15602 here as a static method. Take an additional bool out parameter
15603 `must_do_cs1540_check' for signaling to InstanceResolve.
15604 (PropertyExpr.InstanceResolve): Removed the `must_do_cs1540_check'
15605 member field from PropertyExpr class and made it an argument of
15606 the method instead.
15607 (EventExpr.InstanceResolve): Copied from PropertyExpr, removed the
15608 check for MarshalByRefObject, and report CS0122 instead of CS1540.
15609 (EventExpr.DoResolve): Call IsAccessorAccessible on `add_accessor'
15610 and `remove_accessor' as well as InstanceResolve: report CS0122
15615 2004-12-03 Raja R Harinath <rharinath@novell.com>
15617 Fix test-327.cs, test-328.cs, and put in early infrastructure
15618 for eventually fixing #52697.
15619 * namespace.cs (NamespaceEntry.LookupForUsing): New method.
15620 (NamespaceEntry.LookupNamespaceOrType): New method, refactored
15621 from other methods.
15622 (NamespaceEntry.Lookup): Remove 'ignore_using' flag.
15623 (AliasEntry.Resolve, UsingEntry.Resolve): Use 'LookupForUsing'.
15624 (VerifyUsing, error246): Update.
15625 * rootcontext.cs (RootContext.NamespaceLookup): Just use
15626 'NamespaceEntry.LookupNamespaceOrType'.
15628 2004-12-03 Martin Baulig <martin@ximian.com>
15630 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15631 method as our child, call AnonymousMethod.Compatible() on it.
15633 2004-12-03 Raja R Harinath <rharinath@novell.com>
15635 Disable XML documentation support in 'basic' profile.
15636 * decl.cs, class.cs [BOOTSTRAP_WITH_OLDLIB]: Don't import System.Xml.
15637 Redirect XmlElement to System.Object.
15638 * driver.cs, enum.cs, rootcontext.cs: Don't reference System.Xml.
15639 * doc.cs [BOOTSTRAP_WITH_OLDLIB]: Disable compile.
15640 * mcs.exe.sources: Add doc-bootstrap.cs.
15641 * doc-bootstrap.cs: New file. Contains empty stub implementation
15644 2004-12-03 Atsushi Enomoto <atsushi@ximian.com>
15646 * cs-tokenizer.cs : Only '////' is rejected. Other non-whitespace
15647 comments are allowed.
15649 2004-12-03 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15651 * delegate.cs: Add checks for subtypes in paramaters and return values
15652 in VerifyMethod () to add support for Covariance/Contravariance
15655 2004-12-02 Miguel de Icaza <miguel@ximian.com>
15657 * report.cs: Remove extra closing parenthesis.
15659 * convert.cs (Error_CannotImplicitConversion): If the name of the
15660 types are the same, provide some extra information.
15662 * class.cs (FieldBase): Use an unused bit field from the field to
15663 encode the `has_offset' property from the FieldMember. This saves
15664 a couple of Ks on bootstrap compilation.
15666 * delegate.cs (NewDelegate.DoResolve): If we have an anonymous
15667 method as our child, return the AnonymousMethod resolved
15670 * expression.cs (New.DoResolve): Allow return values from
15671 NewDelegate to also include AnonymousMethods.
15675 2004-12-02 Marek Safar <marek.safar@seznam.cz>
15678 * attribute.cs (Resolve): Improved implementation of params
15679 attribute arguments.
15681 * support.cs (ParameterData): Add HasParams to be faster.
15683 2004-12-02 Atsushi Enomoto <atsushi@ximian.com>
15685 all things are for /doc support:
15687 * doc.cs: new file that supports XML documentation generation.
15688 * mcs.exe.sources: added doc.cs.
15690 Handle /doc command line option.
15691 Report error 2006 instead of 5 for missing file name for /doc.
15692 Generate XML documentation when required, after type resolution.
15694 Added support for picking up documentation (/// and /** ... */),
15695 including a new XmlCommentState enumeration.
15697 Added lines to fill Documentation element for field, constant,
15698 property, indexer, method, constructor, destructor, operator, event
15699 and class, struct, interface, delegate, enum.
15700 Added lines to warn incorrect comment.
15702 Added Documentation field (passed only when /doc was specified).
15704 Added DocComment, DocCommentHeader, GenerateDocComment() and
15705 OnGenerateDocComment() and some supporting private members for
15706 /doc feature to MemberCore.
15708 Added GenerateDocComment() on TypeContainer, MethodCore and Operator.
15710 Added overriden DocCommentHeader.
15712 Added overriden DocCommentHeader and GenerateDocComment().
15714 2004-12-01 Miguel de Icaza <miguel@ximian.com>
15716 * cfold.cs (ConstantFold.DoConstantNumericPromotions): After
15717 unwrapping the enumeration values, chain to
15718 DoConstantNumericPromotions again, so we can promote things to the
15719 fundamental types (takes care of enums that are bytes, sbytes).
15723 2004-12-01 Raja R Harinath <rharinath@novell.com>
15725 * attribute.cs (Attribute.CheckAttributeType): Remove complain flag.
15726 Fix long-standing bug in type-lookup. Use FindType instead of
15727 LookupType when ec.ResolvingTypeTree.
15728 (Attribute.ResolveType, Attribute.Resolve)
15729 (Attribute.DefinePInvokeMethod,GlobalAttribute.CheckAttributeType):
15731 (Attributes.Search): Remove internal version. Update.
15732 (Attributes.SearchMulti): Update.
15733 (Attributes.GetClsCompliantAttribute): Remove.
15734 (Attributes.GetIndexerNameAttribute): Remove.
15735 * decl.cs (MemberCore.GetClsCompliantAttributeValue): Update to changes.
15736 (DeclSpace.GetClsCompliantAttributeValue): Likewise.
15737 * class.cs (Indexer.Define): Likewise.
15739 2004-12-01 Marek Safar <marek.safar@seznam.cz>
15742 * ecore.cs: CheckMarshallByRefAccess new virtual method for testing
15743 MarshallByReference members access.
15745 * expression.cs: Use CheckMarshallByRefAccess;
15746 Better error CS0197 message.
15748 * report.cs: Print whole related error message.
15750 2004-11-30 Raja R Harinath <rharinath@novell.com>
15752 * Makefile (mcs.exe) [PROFILE=default]: Keep a copy of mcs.exe in
15753 the current directory to help debugging.
15755 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15757 * class (GetClassBases): Better error 60 report.
15758 (EventProperty): Disabled warning 67 detection.
15760 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15763 * cfold.cs (Assign.DoResolve): Add subtraction for DecimalConstant.
15765 * constant.cs (DecimalConstant.Emit): Don't use int ctor for
15768 2004-11-29 Marek Safar <marek.safar@seznam.cz>
15771 * assign.cs (Assign.DoResolve): Add error 1648, 1650 report.
15773 * decl.cs (MemberCore.MemberName): Error 1648 in compiler.
15775 2004-11-26 Miguel de Icaza <miguel@ximian.com>
15777 * attribute.cs (Attribute.Resolve): Refine error reporting and
15778 report a cs0117 if the identifier does not exist, to distinguish
15779 from 0617 which is a miss-use of the actual identifier.
15781 * ecore.cs (EventExpr.Emit): Refine error report and distinguish
15782 between cs0070 and cs0079.
15784 * class.cs (MemberBase.DoDefine): When reporting a wrong
15785 accessibility level, we use MethodCore to compare instead of
15786 Method (this was a regression in some refactoring effort).
15788 So now we correctly report cs0056 again.
15790 * convert.cs (ImplicitReferenceConversion): Corrected typo, I was
15791 testing the target_type (which was known to be object_type) and
15792 not the source type (which is anonymous_method).
15794 Fixed reporting of error cs1660.
15796 * expression.cs (UserCast.Source): Expose the underlying cast.
15798 * statement.cs (Switch.SwitchGoverningType): Sort the list of
15799 allowed types to find a match to int32 first (most common).
15801 In addition, it ignores any ImplicitUserConversions that did an
15802 internal implicit conversion (as the switch statement allows only
15803 one integral conversion to exist).
15805 * class.cs (PartialContainer.Create): rename `name' to
15806 `member_name' for clarity. Then replace the string calls with a
15807 call to MemberName.GetPartialName, as now using
15808 MemberName.ToString is an error (this is due to the side effects
15809 it had, that were fixed in the past).
15811 This will restore the error reporting on a number of partial class
15812 errors that were missusing this (and getting an exception as a
15813 results, which is now just a plain textual warning, because
15814 yyparse debug output would crash otherwise).
15816 2004-11-26 Raja R Harinath <rharinath@novell.com>
15818 * Makefile (PROGRAM_INSTALL_DIR): Remove.
15820 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15822 * rootcontext.cs (LookupType): Make sure to cache lookups that
15823 don't give us a negative result. This saves about 5% of corlib
15826 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15828 * report.cs (AbstractMessage.Print): messages are sent to stderr
15830 * class.cs (TypeContainer.GetClassBases): It is an error to have a
15831 non-interface in the list of interfaces (at this point, either
15832 parent was properly set, or a base class is being listed in the
15833 interfaces section).
15835 This flags error 1722, and resolves the crash from bug 69259.
15837 2004-11-25 Ben Maurer <bmaurer@ximian.com>
15839 * statement.cs (Using.EmitExpressionFinally): make this work right
15840 for valuetypes. Fixes 69926.
15842 2004-11-25 Miguel de Icaza <miguel@ximian.com>
15844 * const.cs (Const.ChangeType): Cope with the "0 literal can be
15845 converted to an enum" here, before we try to change the underlying
15846 type. This code exists, but it is a different code path than the
15847 one used while encoding constants.
15849 * convert.cs (ImplicitReferenceConversionExists): A surprisingly
15850 old bug: when converting from the null literal to a pointer,
15851 return an EmptyCast, not the NullLiteral.
15853 This fixes #69921, the recent null_type changes probably made this
15854 bug more prominent.
15856 (ImplicitReferenceConversionExists): In addition, resynchronized
15857 the code here, so it matches the same code in
15858 ImplicitReferenceConversionExists for the `from any class-type S
15859 to any interface-type T'.
15862 2004-11-25 Marek Safar <marek.safar@seznam.cz>
15864 * cfold.cs (BinaryFold): Add addition for DecimalConstant.
15866 2004-11-24 Miguel de Icaza <miguel@ximian.com>
15868 * cs-parser.jay: Use verbosity accordingly.
15870 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15872 * expression.cs (Unary.ResolveOperator): Do not report warning;
15873 AddressOf reads from variable.
15875 (LocalVariableReferences.DoResolveBase): Improved my previous fix.
15877 2004-11-24 Marek Safar <marek.safar@seznam.cz>
15881 * attribute.cs (Attributable): Removed CheckTargets.
15882 (Attributes.Emit): Explicit attribute targets are tested here.
15884 * class.cs (EventField.ValidAttributeTargets): Explicit target "field" is
15885 not enabled for interfaces.
15887 * codegen.cs (CommonAssemblyModulClass.AddAttributes): Removed CheckTargets.
15888 (GetAssemblyName): Ouch next bug there.
15890 2004-11-23 Carlos Alberto Cortez <calberto.cortez@gmail.com>
15892 * expression.cs: Error 275 added.
15894 2004-11-23 Marek Safar <marek.safar@seznam.cz>
15896 Fix bug #69177 (Implemented decimal constant support)
15898 * cfold.cs (DoConstantNumericPromotions: Add DecimalConstant.
15899 (BinaryFold): Add DecimalConstant.
15901 * const.cs (Define): Decimal constant
15903 (ChangeType): Add decimal type handling.
15904 (LookupConstantValue): Don't set value for decimal type but
15905 emit DecimalConstantAttribute. Needed for constant optimization.
15907 * constant.cs (ToDecimal): New method.
15908 (ConvertToDecimal): New method.
15909 (IntConstant): Implemented ConvertToDecimal.
15910 (DecimalConstant.Emit): Emit optimized version for decimals in
15913 * expression.cs (ResolveOperator): Changed order of constant
15914 reduction to work correctly with native types which have
15915 overloaded operators.
15916 (ResolveMemberAccess): Extract constant value from attribute
15919 * rootcontext.cs (ResolveCore): Add DecimalConstantAttribute.
15921 * typemanager.cs (TypeManager): Add decimal_constant_attribute_type,
15922 void_decimal_ctor_int_arg, decimal_constant_attribute_ctor.
15923 (ChangeType): Decimal is special.
15924 (TypeToCoreType): Add decimal type.
15926 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15928 * convert.cs (ImplicitConversionRequired): Add error cs0642 for
15931 2004-11-22 Marek Safar <marek.safar@seznam.cz>
15933 * class.cs (EventField.ApplyAttributeBuilder): Fix error
15936 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15938 * class.cs (MemberBase.DoDefine): Fix error cs0508 report.
15940 * pending.cs (PendingImplementation): Grab only interfaces.
15942 2004-11-19 Marek Safar <marek.safar@seznam.cz>
15944 * statement.cs (ForeachHelperMethods): Add location member and
15945 error 202 detection.
15947 2004-11-19 Raja R Harinath <rharinath@novell.com>
15949 * Makefile (EXTRA_DISTFILES): Remove mcs.exe.config. It's
15950 automatically handled by executable.make.
15951 (PROGRAM): Make profile-specific.
15953 2004-11-18 Marek Safar <marek.safar@seznam.cz>
15955 * expression.cs (DoResolveBase): Fixed wrong warning for out
15958 2004-11-18 Martin Baulig <martin@ximian.com>
15960 Merged latest changes into gmcs. Please keep this comment in
15961 here, it makes it easier for me to see what changed in MCS since
15962 the last time I merged.
15964 2004-11-17 Raja R Harinath <rharinath@novell.com>
15966 * typemanager.cs (TypeHandle.GetTypeHandle): Make private.
15967 (TypeHandle.GetMemberCache): New.
15968 (TypeHandle.TypeHandle): Update.
15969 (TypeManager.LookupMemberCache): Rewritten from LookupMemberContainer.
15970 (TypeManager.LookupParentInterfacesCache):
15971 Rename from LookupInterfaceCache. Optimize slightly.
15972 (TypeManager.MemberLookup_FindMembers): Update.
15973 * decl.cs (MemberCache.MemberCache): Set Container to null in the
15974 multi-type variant.
15975 (AddCacheContents): Rename from AddHashtable.
15976 * class.cs (TypeContainer.parent_container): Remove.
15977 (TypeContainer.VerifyClsCompliance): Don't use parent_container.
15978 (TypeContainer.DoDefineMembers): Don't initialize it.
15979 Update to name changes.
15981 2004-11-17 Miguel de Icaza <miguel@ximian.com>
15983 * class.cs (MethodCore.CheckAccessModifiers): New helper routine
15984 that factors the code to check access modifiers on override.
15986 (PropertyBase): Use the code here.
15988 Patch from Lluis S'anchez, fixes bug #69361.
15990 2004-11-15 Miguel de Icaza <miguel@ximian.com>
15992 * anonymous.cs (AnonymousMethod.Error_AddressOfCapturedVar): New
15993 routine that is used to report the use of a captured variable
15994 whose address has been taken.
15996 There are two checks: one when variables are being captured and
15997 the other check is when the address of a variable is taken.
15999 (because an anonymous methods might be resolved before *or* after
16000 the address has been taken) and
16002 * expression.cs (Conditional.DoResolve): Remove the special
16003 casing that Martin added to trueExpr and falseExpr being both
16004 NullLiteral. We get the right behavior now just by introducing
16005 the null_type into the compiler.
16007 * convert.cs (ExplicitConversion): Change the code to use
16008 null_type instead of testing `expr is NullLiteral'.
16009 (ImplicitConversionStandard): use null_type too.
16010 (ImplicitReferenceConversionExists): use null_type too.
16011 (ImplicitReferenceConversion): use null_type too.
16013 * literal.cs: The type of `NullLiteral' is now null_type instead
16015 (Resolve): Set the type here.
16017 * typemanager.cs: Introduce null_type.
16019 2004-11-17 Martin Baulig <martin@ximian.com>
16021 * decl.cs (MemberCache.AddHashtable): Add entries in the opposite
16022 direction, like FindMembers() does. Fixes #69546, testcase is in
16025 2004-11-16 Martin Baulig <martin@ximian.com>
16027 This is based on a patch from Marek Safar, see bug #69082.
16028 Fixes bugs #63705 and #67130.
16030 * typemanager.cs (TypeManager.LookupInterfaceCache): New public
16031 method; create a MemberCache for an interface type and cache the
16034 * decl.cs (IMemberContainer.ParentContainer): Removed.
16035 (IMemberContainer.ParentCache): New property.
16036 (MemberCache.SetupCacheForInterface): Removed.
16037 (MemberCache..ctor): Added .ctor which takes a `Type[]'; use this
16038 to create a cache for an interface's "parent".
16040 * class.cs (TypeContainer.DoDefineMembers): Setup cache for
16043 2004-11-16 Martin Baulig <martin@ximian.com>
16045 Merged back from gmcs; these changes already went into gmcs a
16046 couple of weeks ago.
16049 (TypeManager.AddUserType): Removed the `ifaces' argument.
16050 (TypeManager.RegisterBuilder): Take a `Type []' instead of a
16052 (TypeManager.AddUserInterface): Removed.
16053 (TypeManager.ExpandInterfaces): Return a `Type []' instead of a
16055 (TypeManager.GetInterfaces): Likewise.
16056 (TypeManager.GetExplicitInterfaces): Likewise.
16058 * ecore.cs (TypeExpr.GetInterfaces): Removed.
16060 * class.cs (TypeContainer.base_class_type): Replaced with `ptype'.
16061 (TypeContainer.base_inteface_types): Replaced with `ifaces'.
16063 2004-11-14 Ben Maurer <bmaurer@ximian.com>
16065 * statement.cs: Avoid adding bools to a hashtable.
16067 2004-11-07 Miguel de Icaza <miguel@ximian.com>
16069 * expression.cs (Invocation.OverloadResolve): Flag error if we are
16070 calling an unsafe method from a safe location.
16072 2004-11-06 Marek Safar <marek.safar@seznam.cz>
16075 * codegen.cs (ApplyAttributeBuilder): Do not return; it is only warning.
16077 2004-11-06 Miguel de Icaza <miguel@ximian.com>
16079 * namespace.cs (VerifyUsing): use GetPartialName instead of
16082 2004-11-05 Miguel de Icaza <miguel@ximian.com>
16084 * statement.cs (Return.Resolve): Fix regression in typo: if
16085 `in_exc', we have to request a NeedReturnLabel, this was a typo
16086 introduced in the anonymous method check-in. Fixes #69131.
16088 * Indexers were using the ShortName when defining themselves,
16089 causing a regression in the compiler bootstrap when applying the
16090 patch from 2004-11-02 (first part), now they use their full name
16091 and the bug is gone.
16093 2004-11-04 Zoltan Varga <vargaz@freemail.hu>
16095 * driver.cs: Strip the path from the names of embedded resources. Fixes
16098 2004-11-04 Raja R Harinath <rharinath@novell.com>
16100 Fix error message regression: cs0104-2.cs.
16101 * namespace.cs (NamespaceEntry.Lookup): Remove 'silent' flag.
16102 (AliasEntry.Resolve): Update.
16103 * rootcontext.cs (RootContext.NamespaceLookup): Update. Remove
16105 (RootContext.LookupType): Update.
16107 2004-11-03 Carlos Alberto Cortez <carlos@unixmexico.org>
16109 * cs-parser.jay: Add support for handling accessor modifiers
16110 * class: Add support port accessor modifiers and error checking,
16111 define PropertyMethod.Define as virtual (not abstract anymore)
16112 * ecore.cs: Add checking for proeprties access with access modifiers
16113 * iterators.cs: Modify Accessor constructor call based in the modified
16115 2004-11-02 Ben Maurer <bmaurer@ximian.com>
16117 * expression.cs (StringConcat): Handle being called twice,
16118 as when we have a concat in a field init with more than two
16121 2004-11-02 Miguel de Icaza <miguel@ximian.com>
16123 * class.cs (Event.Define, Indexer.Define, Property.Define): Do not
16124 special case explicit implementations, we should always produce
16125 the .property or .event declaration.
16127 * decl.cs (MemberName): Renamed GetFullName to GetPartialName
16128 since it will not return correct data if people use this
16129 unresolved in the presence of using statements (see test-313).
16131 * class.cs (MethodData.Define): If we are an explicit interface
16132 implementation, set the method name to the full name of the
16133 interface plus the name of the method.
16135 Notice that using the method.MethodName.GetFullName() does not
16136 work, as it will only contain the name as declared on the source
16137 file (it can be a shorthand in the presence of using statements)
16138 and not the fully qualifed type name, for example:
16142 class D : ICloneable {
16143 object ICloneable.Clone () {
16147 Would produce a method called `ICloneable.Clone' instead of
16148 `System.ICloneable.Clone'.
16150 * namespace.cs (Alias.Resolve): Use GetPartialName.
16152 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16154 * cs-parser.jay: Add error 1055 report.
16156 2004-11-01 Miguel de Icaza <miguel@ximian.com>
16158 * assign.cs (Assign.DoResolve): Only do the transform of
16159 assignment into a New if the types are compatible, if not, fall
16160 through and let the implicit code deal with the errors and with
16161 the necessary conversions.
16163 2004-11-01 Marek Safar <marek.safar@seznam.cz>
16165 * cs-parser.jay: Add error 1031 report.
16167 * cs-tokenizer.cs: Add location for error 1038.
16169 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16171 * cs-parser.jay: Add error 1016 report.
16173 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16175 * cs-parser.jay: Add errors 1575,1611 report.
16177 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16179 * cs-parser.jay: Add error 1001 report.
16181 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16184 * attribute.cs (GetMarshal): Add method argument for
16185 caller identification.
16187 * class.cs, codegen.cs, enum.cs, parameter.cs: Added
16188 agument for GetMarshal and RuntimeMissingSupport.
16190 2004-10-31 Marek Safar <marek.safar@seznam.cz>
16192 * attribute.cs (ExtractSecurityPermissionSet): Removed
16193 TypeManager.code_access_permission_type.
16195 * typemanager.cs: Removed TypeManager.code_access_permission_type.
16197 2004-10-27 Miguel de Icaza <miguel@ximian.com>
16199 * expression.cs (LocalVariableReference.DoResolveLValue): Check
16200 for obsolete use of a variable here. Fixes regression on errors
16201 cs0619-25 and cs0619-26.
16203 2004-10-27 Marek Safar <marek.safar@seznam.cz>
16205 Fix #62358, implemented security attribute encoding.
16207 * attribute.cs (Attribute.CheckSecurityActionValididy): New method.
16208 Tests permitted SecurityAction for assembly or other types.
16209 (Assembly.ExtractSecurityPermissionSet): New method. Transforms
16210 data from SecurityPermissionAttribute to PermisionSet class.
16212 * class.cs (ApplyAttributeBuilder): Added special handling
16213 for System.Security.Permissions.SecurityAttribute based types.
16215 * codegen.cs (AssemblyClass.ApplyAttributeBuilder): Added
16216 special handling for System.Security.Permissions.SecurityAttribute
16219 * enum.cs (ApplyAttributeBuilder): Added special handling
16220 for System.Security.Permissions.SecurityAttribute based types.
16222 * parameter.cs (ApplyAttributeBuilder): Added special handling
16223 for System.Security.Permissions.SecurityAttribute based types.
16225 * rootcontext.cs: Next 2 core types.
16227 * typemanager.cs (TypeManager.security_permission_attr_type):
16228 Built in type for the SecurityPermission Attribute.
16229 (code_access_permission_type): Build in type.
16231 2004-10-17 Miguel de Icaza <miguel@ximian.com>
16233 * expression.cs (LocalVariableReference.DoResolveBase, Emit):
16234 Remove the tests for `ec.RemapToProxy' from here, and encapsulate
16235 all of this information into
16236 EmitContext.EmitCapturedVariableInstance.
16238 * codegen.cs (EmitCapturedVariableInstance): move here the
16239 funcionality of emitting an ldarg.0 in the presence of a
16240 remapping. This centralizes the instance emit code.
16242 (EmitContext.EmitThis): If the ScopeInfo contains a THIS field,
16243 then emit a load of this: it means that we have reached the
16244 topmost ScopeInfo: the one that contains the pointer to the
16245 instance of the class hosting the anonymous method.
16247 * anonymous.cs (AddField, HaveCapturedFields): Propagate field
16248 captures to the topmost CaptureContext.
16250 2004-10-12 Miguel de Icaza <miguel@ximian.com>
16252 * expression.cs (LocalVariableReference): Move the knowledge about
16253 the iterators into codegen's EmitCapturedVariableInstance.
16255 2004-10-11 Miguel de Icaza <miguel@ximian.com>
16257 * codegen.cs (EmitContext.ResolveTopBlock): Emit a 1643 when not
16258 all code paths return a value from an anonymous method (it is the
16259 same as the 161 error, but for anonymous methods).
16261 2004-10-08 Miguel de Icaza <miguel@ximian.com>
16263 The introduction of anonymous methods in the compiler changed
16264 various ways of doing things in the compiler. The most
16265 significant one is the hard split between the resolution phase
16266 and the emission phases of the compiler.
16268 For instance, routines that referenced local variables no
16269 longer can safely create temporary variables during the
16270 resolution phase: they must do so from the emission phase,
16271 since the variable might have been "captured", hence access to
16272 it can not be done with the local-variable operations from the runtime.
16276 (Block.Flags): New flag `IsTopLevel' to indicate that this block
16277 is a toplevel block.
16279 (ToplevelBlock): A new kind of Block, these are the blocks that
16280 are created by the parser for all toplevel method bodies. These
16281 include methods, accessors and anonymous methods.
16283 These contain some extra information not found in regular blocks:
16284 A pointer to an optional CaptureContext (for tracking captured
16285 local variables and parameters). A pointer to the parent
16288 (Return.Resolve): Catch missmatches when returning a value from an
16289 anonymous method (error 1662).
16290 Invoke NeedReturnLabel from the Resolve phase instead of the emit
16293 (Break.Resolve): ditto.
16295 (SwitchLabel): instead of defining the labels during the
16296 resolution phase, we now turned the public ILLabel and ILLabelCode
16297 labels into methods called GetILLabelCode() and GetILLabel() that
16298 only define the label during the Emit phase.
16300 (GotoCase): Track the SwitchLabel instead of the computed label
16301 (its contained therein). Emit the code by using
16302 SwitchLabel.GetILLabelCode ().
16304 (LocalInfo.Flags.Captured): A new flag has been introduce to track
16305 whether the Local has been captured or not.
16307 (LocalInfo.IsCaptured): New property, used to tell whether the
16308 local has been captured.
16310 * anonymous.cs: Vastly updated to contain the anonymous method
16313 The main classes here are: CaptureContext which tracks any
16314 captured information for a toplevel block and ScopeInfo used to
16315 track the activation frames for various local variables.
16317 Each toplevel block has an optional capture context associated
16318 with it. When a method contains an anonymous method both the
16319 toplevel method and the anonymous method will create a capture
16320 context. When variables or parameters are captured, they are
16321 recorded on the CaptureContext that owns them, for example:
16325 MyDelegate d = delegate {
16330 Here `a' will be recorded as captured on the toplevel
16331 CapturedContext, the inner captured context will not have anything
16332 (it will only have data if local variables or parameters from it
16333 are captured in a nested anonymous method.
16335 The ScopeInfo is used to track the activation frames for local
16336 variables, for example:
16338 for (int i = 0; i < 10; i++)
16339 for (int j = 0; j < 10; j++){
16340 MyDelegate d = delegate {
16345 At runtime this captures a single captured variable `i', but it
16346 captures 10 different versions of the variable `j'. The variable
16347 `i' will be recorded on the toplevel ScopeInfo, while `j' will be
16348 recorded on a child.
16350 The toplevel ScopeInfo will also track information like the `this'
16351 pointer if instance variables were referenced (this is necessary
16352 as the anonymous method lives inside a nested class in the host
16353 type of the method).
16355 (AnonymousMethod): Expanded to track the Toplevel, implement
16356 `AnonymousMethod.Compatible' to tell whether an anonymous method
16357 can be converted to a target delegate type.
16359 The routine now also produces the anonymous method content
16361 (AnonymousDelegate): A helper class that derives from
16362 DelegateCreation, this is used to generate the code necessary to
16363 produce the delegate for the anonymous method that was created.
16365 * assign.cs: API adjustments for new changes in
16366 Convert.ImplicitStandardConversionExists.
16368 * class.cs: Adjustments to cope with the fact that now toplevel
16369 blocks are of type `ToplevelBlock'.
16371 * cs-parser.jay: Now we produce ToplevelBlocks for toplevel blocks
16372 insteda of standard blocks.
16374 Flag errors if params arguments are passed to anonymous methods.
16376 * codegen.cs (EmitContext): Replace `InAnonymousMethod' with
16377 `CurrentAnonymousMethod' which points to the current Anonymous
16378 Method. The variable points to the AnonymousMethod class that
16379 holds the code being compiled. It is set in the new EmitContext
16380 created for the anonymous method.
16382 (EmitContext.Phase): Introduce a variable and an enumeration to
16383 assist in enforcing some rules about when and where we are allowed
16384 to invoke certain methods (EmitContext.NeedsReturnLabel is the
16385 only one that enfonces this right now).
16387 (EmitContext.HaveCaptureInfo): new helper method that returns
16388 whether we have a CapturedContext initialized.
16390 (EmitContext.CaptureVariable): New method used to register that a
16391 LocalInfo must be flagged for capturing.
16393 (EmitContext.CapturedParameter): New method used to register that a
16394 parameters must be flagged for capturing.
16396 (EmitContext.CapturedField): New method used to register that a
16397 field must be flagged for capturing.
16399 (EmitContext.HaveCapturedVariables,
16400 EmitContext.HaveCapturedFields): Return whether there are captured
16401 variables or fields.
16403 (EmitContext.EmitMethodHostInstance): This is used to emit the
16404 instance for the anonymous method. The instance might be null
16405 (static methods), this (for anonymous methods that capture nothing
16406 and happen to live side-by-side with the current method body) or a
16407 more complicated expression if the method has a CaptureContext.
16409 (EmitContext.EmitTopBlock): Routine that drives the emission of
16410 code: it will first resolve the top block, then emit any metadata
16411 and then emit the code. The split is done so that we can extract
16412 any anonymous methods and flag any captured variables/parameters.
16414 (EmitContext.ResolveTopBlock): Triggers the resolution phase,
16415 during this phase, the ILGenerator should not be used as labels
16416 and local variables declared here might not be accessible to any
16417 code that is part of an anonymous method.
16419 Exceptions to this include the temporary variables that are
16420 created by some statements internally for holding temporary
16423 (EmitContext.EmitMeta): New routine, in charge of emitting all the
16426 (EmitContext.TemporaryReturn): This method is typically called
16427 from the Emit phase, and its the only place where we allow the
16428 ReturnLabel to be defined other than the EmitMeta. The reason is
16429 that otherwise we would have to duplicate a lot of logic in the
16430 Resolve phases of various methods that today is on the Emit
16433 (EmitContext.NeedReturnLabel): This no longer creates the label,
16434 as the ILGenerator is not valid during the resolve phase.
16436 (EmitContext.EmitThis): Extended the knowledge in this class to
16437 work in anonymous methods in addition to iterators.
16439 (EmitContext.EmitCapturedVariableInstance): This emits whatever
16440 code is necessary on the stack to access the instance to a local
16441 variable (the variable will be accessed as a field).
16443 (EmitContext.EmitParameter, EmitContext.EmitAssignParameter,
16444 EmitContext.EmitAddressOfParameter): Routines to support
16445 parameters (not completed at this point).
16447 Removals: Removed RemapLocal and RemapLocalLValue. We probably
16448 will also remove the parameters.
16450 * convert.cs (Convert): Define a `ConstantEC' which points to a
16451 null. This is just to prefity some code that uses
16452 ImplicitStandardConversion code and do not have an EmitContext
16455 The idea is to flag explicitly that at that point in time, it is
16456 known that the conversion will not trigger the delegate checking
16457 code in implicit conversions (which requires a valid
16460 Everywhere: pass new EmitContext parameter since
16461 ImplicitStandardConversionExists now requires it to check for
16462 anonymous method conversions.
16464 (Convert.ImplicitStandardConversionExists): If the type of an
16465 expression is the anonymous_method_type, and the type is a
16466 delegate, we invoke the AnonymousMethod.Compatible method to check
16467 whether an implicit conversion is possible.
16469 (Convert.ImplicitConversionStandard): Only do implicit method
16470 group conversions if the language level is not ISO_1.
16472 * delegate.cs (Delegate.GetInvokeMethod): Common method to get the
16473 MethodInfo for the Invoke method. used by Delegate and
16476 * expression.cs (Binary.DoNumericPromotions): only allow anonymous
16477 method conversions if the target type is a delegate.
16479 Removed extra debugging nops.
16481 (LocalVariableReference): Turn the `local_info' into a public
16484 Add `prepared' field, the same hack used for FieldExprs to cope
16485 with composed assignments, as Local variables do not necessarily
16486 operate purely on the stack as they used to: they can be captured
16489 Add `temp' for a temporary result, like fields.
16491 Refactor DoResolve and DoResolveLValue into DoResolveBase.
16493 It now copes with Local variables that are captured and emits the
16494 proper instance variable to load it from a field in the captured
16497 (ParameterReference.DoResolveBase): During the resolve phase,
16498 capture parameters if we are in an anonymous method.
16500 (ParameterReference.Emit, ParameterReference.AddressOf): If in an
16501 anonymous method, use the EmitContext helper routines to emit the
16502 parameter reference.
16504 * iterators.cs: Set RemapToProxy to true/false during the
16507 * parameters.cs (GetParameterByName): New helper method.
16509 * typemanager.cs (anonymous_method_type) a new type that
16510 represents an anonyous method. This is always an internal type,
16511 used as a fencepost to test against the anonymous-methodness of an
16514 2004-10-20 Marek Safar <marek.safar@seznam.cz>
16516 * class.cs (MethodCore.CheckBase): Add errors 505, 533, 544,
16518 (PropertyBase.FindOutParentMethod): Add errors 545, 546 report.
16520 2004-10-18 Martin Baulig <martin@ximian.com>
16522 * statement.cs (Fixed.Resolve): Don't access the TypeExpr's
16523 `Type' directly, but call ResolveType() on it.
16524 (Catch.Resolve): Likewise.
16525 (Foreach.Resolve): Likewise.
16527 2004-10-18 Martin Baulig <martin@ximian.com>
16529 * expression.cs (Cast.DoResolve): Don't access the TypeExpr's
16530 `Type' directly, but call ResolveType() on it.
16531 (Probe.DoResolve): Likewise.
16532 (ArrayCreation.LookupType): Likewise.
16533 (TypeOf.DoResolve): Likewise.
16534 (SizeOf.DoResolve): Likewise.
16536 2004-10-18 Martin Baulig <martin@ximian.com>
16538 * expression.cs (Invocation.BetterFunction): Put back
16539 TypeManager.TypeToCoreType().
16541 2004-10-18 Raja R Harinath <rharinath@novell.com>
16543 * class.cs (FieldMember.DoDefine): Reset ec.InUnsafe after doing
16546 2004-10-18 Martin Baulig <martin@ximian.com>
16548 * parameter.cs (Parameter.Resolve): Don't access the TypeExpr's
16549 `Type' directly, but call ResolveType() on it.
16551 2004-10-18 Martin Baulig <martin@ximian.com>
16553 * class.cs (FieldMember.Define): Don't access the TypeExpr's
16554 `Type' directly, but call ResolveType() on it.
16555 (MemberBase.DoDefine): Likewise.
16557 * expression.cs (New.DoResolve): Don't access the TypeExpr's
16558 `Type' directly, but call ResolveType() on it.
16559 (ComposedCast.DoResolveAsTypeStep): Likewise.
16561 * statement.cs (LocalInfo.Resolve): Don't access the TypeExpr's
16562 `Type' directly, but call ResolveType() on it.
16564 2004-10-17 John Luke <john.luke@gmail.com>
16566 * class.cs (Operator.GetSignatureForError): use CSharpName
16568 * parameter.cs (Parameter.GetSignatureForError): Returns
16569 correct name even if was not defined.
16571 2004-10-13 Raja R Harinath <rharinath@novell.com>
16574 * class.cs (TypeContainer.EmitContext): New property.
16575 (DefineNestedTypes): Create an emitcontext for each part.
16576 (MethodCore.DoDefineParameters): Use container's emitcontext.
16577 Pass type array to InternalParameters.
16578 (MemberBase.DoDefine): Use container's emitcontext.
16579 (FieldMember.Define): Likewise.
16580 (Event.Define): Likewise.
16581 (SetMethod.GetParameterInfo): Change argument to EmitContext.
16582 Pass type array to InternalParameters.
16583 (SetIndexerMethod.GetParameterInfo): Likewise.
16584 (SetMethod.Define): Pass emitcontext to GetParameterInfo.
16585 * delegate.cs (Define): Pass emitcontext to
16586 ComputeAndDefineParameterTypes and GetParameterInfo. Pass type
16587 array to InternalParameters.
16588 * expression.cs (ParameterReference.DoResolveBase): Pass
16589 emitcontext to GetParameterInfo.
16590 (ComposedCast.DoResolveAsTypeStep): Remove check on
16591 ec.ResolvingTypeTree.
16592 * parameter.cs (Parameter.Resolve): Change argument to
16593 EmitContext. Use ResolveAsTypeTerminal.
16594 (Parameter.GetSignature): Change argument to EmitContext.
16595 (Parameters.ComputeSignature): Likewise.
16596 (Parameters.ComputeParameterTypes): Likewise.
16597 (Parameters.GetParameterInfo): Likewise.
16598 (Parameters.ComputeAndDefineParameterTypes): Likewise.
16599 Re-use ComputeParameterTypes. Set ec.ResolvingTypeTree.
16600 * support.cs (InternalParameters..ctor): Remove variant that takes
16602 * typemanager.cs (system_intptr_expr): New.
16603 (InitExpressionTypes): Initialize it.
16605 2004-10-12 Chris Toshok <toshok@ximian.com>
16607 * cs-parser.jay: fix location for try_statement and catch_clause.
16609 2004-10-11 Martin Baulig <martin@ximian.com>
16611 * report.cs: Don't make --fatal abort on warnings, we have
16612 -warnaserror for that.
16614 2004-10-07 Raja R Harinath <rharinath@novell.com>
16616 More DeclSpace.ResolveType avoidance.
16617 * decl.cs (MemberCore.InUnsafe): New property.
16618 * class.cs (MemberBase.DoDefine): Use ResolveAsTypeTerminal
16619 with newly created EmitContext.
16620 (FieldMember.Define): Likewise.
16621 * delegate.cs (Delegate.Define): Likewise.
16622 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup with alias
16623 only if normal name-lookup fails.
16624 (TypeExpr.DoResolve): Enable error-checking.
16625 * expression.cs (ArrayCreation.DoResolve): Use ResolveAsTypeTerminal.
16626 (SizeOf.DoResolve): Likewise.
16627 (ComposedCast.DoResolveAsTypeStep): Likewise.
16628 (StackAlloc.DoResolve): Likewise.
16629 * statement.cs (Block.Flags): Add new flag 'Unsafe'.
16630 (Block.Unsafe): New property.
16631 (Block.EmitMeta): Set ec.InUnsafe as appropriate.
16632 (Unsafe): Set 'unsafe' flag of contained block.
16633 (LocalInfo.Resolve): Use ResolveAsTypeTerminal.
16634 (Fixed.Resolve): Likewise.
16635 (Catch.Resolve): Likewise.
16636 (Using.ResolveLocalVariableDecls): Likewise.
16637 (Foreach.Resolve): Likewise.
16639 2004-10-05 John Luke <john.luke@gmail.com>
16641 * cs-parser.jay: add location to error CS0175
16643 2004-10-04 Miguel de Icaza <miguel@ximian.com>
16645 * ecore.cs (Expression.Constantity): Add support for turning null
16648 * const.cs (Const.Define): Allow constants to be reference types
16649 as long as the value is Null.
16651 2004-10-04 Juraj Skripsky <js@hotfeet.ch>
16653 * namespace.cs (NamespaceEntry.Using): No matter which warning
16654 level is set, check if this namespace name has already been added.
16656 2004-10-03 Ben Maurer <bmaurer@ximian.com>
16658 * expression.cs: reftype [!=]= null should always use br[true,false].
16661 2004-10-03 Marek Safar <marek.safar@seznam.cz>
16664 * attribute.cs: Enum conversion moved to
16665 GetAttributeArgumentExpression to be applied to the all
16668 2004-10-01 Raja R Harinath <rharinath@novell.com>
16670 Fix #65833, test-300.cs, cs0122-5.cs, cs0122-6.cs.
16671 * class.c (TypeContainer.DefineType): Flag error if
16672 base types aren't accessible due to access permissions.
16673 * decl.cs (DeclSpace.ResolveType): Move logic to
16674 Expression.ResolveAsTypeTerminal.
16675 (DeclSpace.ResolveTypeExpr): Thin layer over
16676 Expression.ResolveAsTypeTerminal.
16677 (DeclSpace.CheckAccessLevel, DeclSpace.FamilyAccess):
16678 Refactor code into NestedAccess. Use it.
16679 (DeclSpace.NestedAccess): New.
16680 * ecore.cs (Expression.ResolveAsTypeTerminal): Add new
16681 argument to silence errors. Check access permissions.
16682 (TypeExpr.DoResolve, TypeExpr.ResolveType): Update.
16683 * expression.cs (ProbeExpr.DoResolve): Use ResolveAsTypeTerminal.
16684 (Cast.DoResolve): Likewise.
16685 (New.DoResolve): Likewise.
16686 (InvocationOrCast.DoResolve,ResolveStatement): Likewise.
16687 (TypeOf.DoResolve): Likewise.
16689 * expression.cs (Invocation.BetterConversion): Return the Type of
16690 the better conversion. Implement section 14.4.2.3 more faithfully.
16691 (Invocation.BetterFunction): Make boolean. Make correspondence to
16692 section 14.4.2.2 explicit.
16693 (Invocation.OverloadResolve): Update.
16694 (Invocation): Remove is_base field.
16695 (Invocation.DoResolve): Don't use is_base. Use mg.IsBase.
16696 (Invocation.Emit): Likewise.
16698 2004-09-27 Raja R Harinath <rharinath@novell.com>
16700 * README: Update to changes.
16702 2004-09-24 Marek Safar <marek.safar@seznam.cz>
16704 * cs-parser.jay: Reverted 642 warning fix.
16706 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16709 * decl.cs (FindMemberWithSameName): Indexer can have more than
16712 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16714 * expression.cs (LocalVariableReference.DoResolveLValue):
16715 Do not report warning 219 for out values.
16716 (EmptyExpression.Null): New member to avoid extra allocations.
16718 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16720 * cs-parser.jay: Fix wrong warning 642 report.
16722 * cs-tokenizer.cs (CheckNextToken): New helper;
16723 Inspect next character if is same as expected.
16725 2004-09-23 Martin Baulig <martin@ximian.com>
16727 * convert.cs (Convert.ImplicitReferenceConversion): Some code cleanup.
16728 (Convert.ImplicitReferenceConversionExists): Likewise.
16730 2004-09-23 Marek Safar <marek.safar@seznam.cz>
16732 * class.cs (Operator.Define): Add error 448 and 559 report.
16734 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16736 * class.cs (MemberBase.IsTypePermitted): New protected
16737 method for checking error CS0610.
16739 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16741 * class.cs (TypeContainer.HasExplicitLayout): New property
16742 Returns whether container has StructLayout attribute set Explicit.
16743 (FieldMember): New abstract class for consts and fields.
16744 (FieldMember.ApplyAttributeBuilder): Add error 636 and 637 report.
16745 (Field): Reuse FieldMember.
16747 * const.cs (Const): Reuse FieldMember.
16749 * rootcontext.cs: EmitConstants call moved to class.
16751 2004-09-22 Martin Baulig <martin@ximian.com>
16753 Thanks to Peter Sestoft for this bug report.
16755 * expression.cs (Conditional): If both the `trueExpr' and the
16756 `falseExpr' is a NullLiteral, return a NullLiteral.
16758 2004-09-22 Martin Baulig <martin@ximian.com>
16760 * statement.cs (Foreach.EmitCollectionForeach): If we're in an
16761 iterator, use `enumerator.EmitThis()' instead of `ec.EmitThis()'
16762 for the "get_Current" call.
16764 2004-09-22 Martin Baulig <martin@ximian.com>
16766 Marek and me just fixed one of our oldest bugs: #28562 :-)
16768 * ecore.cs (EnumConstant.GetValueAsEnumType): New public method.
16770 * attribute.cs (Attribute.GetAttributeArgumentExpression): If
16771 we're an EnumConstant, just return that.
16772 (Attribute.Resolve): GetAttributeArgumentExpression() may give us
16773 an EnumConstant. In this case, we need to use GetValueAsEnumType()
16774 to get the value which'll actually be written into the attribute.
16775 However, we have to use GetValue() to access the attribute's value
16778 2004-09-22 Marek Safar <marek.safar@seznam.cz>
16780 * constant.cs (Constant.IsNegative): New abstract property
16783 * expression.cs (ArrayAccess.DoResolve): Add warning 251.
16784 (StackAlloc.DoResolve): Reused IsNegative.
16786 2004-09-21 Martin Baulig <martin@ximian.com>
16788 * codegen.cs (VariableStorage): Don't store the ILGenerator here;
16789 if we're used in an iterator, we may be called from different
16792 * statement.cs (Foreach.EmitFinally): Only emit an `Endfinally' if
16793 we actually have an exception block.
16795 2004-09-20 John Luke <jluke@cfl.rr.com>
16797 * class.cs, cs-parser.jay: Improve the error report for 1520:
16798 report the actual line where the error happens, not where the
16799 class was declared.
16801 * assign.cs, delegate.cs, ecore.cs, expression.cs, statement.cs:
16802 Pass location information that was available elsewhere.
16804 2004-09-19 Sebastien Pouliot <sebastien@ximian.com>
16806 * codegen.cs: Fix bug #56621. It is now possible to use MCS on the MS
16807 runtime to delay sign assemblies.
16809 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16811 * cs-parser.jay: Do not report the stack trace, this is barely
16814 2004-08-22 John Luke <john.luke@gmail.com>
16816 * driver.cs : check that a resource id is not already used
16817 before adding it, report CS1508 if it is, bug #63637
16819 2004-09-19 Miguel de Icaza <miguel@ximian.com>
16821 * ecore.cs: Removed dead code.
16823 2004-09-18 Marek Safar <marek.safar@seznam.cz>
16825 * class.cs: Do not report warning CS0067 on the interfaces.
16827 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16829 * cs-parser.jay: Add error 504 report.
16831 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16833 * rootcontext.cs: WarningLevel is 4 by default now.
16835 * statement.cs (Fixed.Resolve): Do not null
16838 2004-09-16 Marek Safar <marek.safar@seznam.cz>
16841 * ecore.cs (PropertyExpr.FindAccessors): Do not perform
16842 deep search when property is not virtual.
16843 (PropertyExpr.ResolveAccessors): Make one call for both
16846 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16849 * statement.cs: Error 152 report constains also location.
16851 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16854 * const.cs: Explicitly set constant as static.
16856 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16859 * cs-parser.jay: Add error 1017 report.
16861 2004-09-15 Marek Safar <marek.safar@seznam.cz>
16863 Fixed bug #59980, #64224
16864 * expression.cs (Invocation.DoResolve): Fixed error CS0571 test.
16866 * typemanager.cs (IsSpecialMethod): Simplified
16868 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16870 * decl.cs (MemberCore.Emit): Resuscitated VerifyObsoleteAttribute
16871 condition with better params.
16873 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16876 * attribute.cs (Resolve): Property has to have both
16879 2004-09-14 Martin Baulig <martin@ximian.com>
16881 * decl.cs (MemberCore.Emit): Always call VerifyObsoleteAttribute().
16883 2004-09-14 Marek Safar <marek.safar@seznam.cz>
16886 * codegen.cs (TestObsoleteMethodUsage): Trace when method is
16887 called and is obsolete then this member suppress message
16888 when call is inside next [Obsolete] method or type.
16890 * expression.cs: Use TestObsoleteMethodUsage member.
16892 2004-09-14 Martin Baulig <martin@ximian.com>
16894 * cs-parser.jay: Sync a bit with the GMCS version.
16896 2004-09-14 Martin Baulig <martin@ximian.com>
16898 * cs-parser.jay (CSharpParser): Don't derive from GenericsParser.
16899 (CSharpParser.yacc_verbose_flag): New public field.
16901 * genericparser.cs: Removed.
16903 2004-09-14 Raja R Harinath <rharinath@novell.com>
16905 * cs-parser.jay (event_declaration): Re-enable cs0071 error.
16907 2004-09-13 Marek Safar <marek.safar@seznam.cz>
16909 * class.cs (MethodCore.CheckBase): Fix bug #65757.
16911 2004-09-10 Martin Baulig <martin@ximian.com>
16913 Backported my MemberName changes from GMCS into MCS.
16915 - we are now using a special `MemberName' class instead of using
16916 strings; in GMCS, the `MemberName' also contains the type
16919 - changed the grammar rules a bit:
16920 * the old `member_name' is now a `namespace_or_type_name':
16921 The rule is that we use `namespace_or_type_name' everywhere
16922 where we expect either a "member name" (GetEnumerator) or a
16923 "member name" with an explicit interface name
16924 (IEnumerable.GetEnumerator).
16925 In GMCS, the explicit interface name may include type arguments
16926 (IEnumerable<T>.GetEnumerator).
16927 * we use `member_name' instead of just `IDENTIFIER' for
16929 The rule is that we use `member_name' wherever a member may
16930 have type parameters in GMCS.
16932 * decl.cs (MemberName): New public class.
16933 (MemberCore.MemberName): New public readonly field.
16934 (MemberCore.ctor): Take a `MemberName' argument, not a string.
16935 (DeclSpace): Likewise.
16937 * delegate.cs (Delegate.ctor): Take a MemberName, not a string.
16938 * enum.cs (Enum.ctor): Likewise.
16940 * namespace.cs (AliasEntry.Alias): Changed type from Expression to
16942 (AliasEntry.ctor): Take a MemberName, not an Expression.
16943 (AliasEntry.UsingAlias): Likewise.
16945 * class.cs (TypeContainer.ctor): Take a MemberName, not a string.
16946 (IMethodData.MemberName): Changed type from string to MemberName.
16947 (MemberBase.ExplicitInterfaceName): Likewise.
16948 (AbstractPropertyEventMethod.SetupName): Make this private.
16949 (AbstractPropertyEventMethod.ctor): Added `string prefix'
16950 argument; compute the member name here.
16951 (AbstractPropertyEventMethod.UpdateName): Recompute the name based
16952 on the `member.MemberName' and the `prefix'.
16954 * cs-parser.jay (attribute_name): Use `namespace_or_type_name',
16956 (struct_declaration): Use `member_name' instead of `IDENTIFIER';
16957 thus, we get a `MemberName' instead of a `string'. These
16958 declarations may have type parameters in GMCS.
16959 (interface_method_declaration, delegate_declaration): Likewise.
16960 (class_declaration, interface_declaration): Likewise.
16961 (method_header): Use `namespace_or_type_name' instead of
16962 `member_name'. We may be an explicit interface implementation.
16963 (property_declaration, event_declaration): Likewise.
16964 (member_name): This is now just an `IDENTIFIER', not a
16965 `namespace_or_type_name'.
16966 (type_name, interface_type): Removed.
16967 (namespace_or_type_name): Return a MemberName, not an Expression.
16968 (primary_expression): Use `member_name' instead of `IDENTIFIER';
16969 call GetTypeExpression() on the MemberName to get an expression.
16970 (IndexerDeclaration.interface_type): Changed type from string to
16972 (MakeName): Operate on MemberName's instead of string's.
16974 2004-09-13 Raja R Harinath <rharinath@novell.com>
16977 * namespace.cs (AliasEntry.Resolve): Implement section 16.3.1.
16978 (NamespaceEntry.Lookup): Add new argument to flag if we want the
16979 lookup to avoid symbols introduced by 'using'.
16980 * rootcontext.cs (NamespaceLookup): Update.
16982 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16984 * class.cs (TypeContainer.DoDefineMembers): Do not call
16985 DefineDefaultConstructor for static classes.
16987 2004-09-12 Marek Safar <marek.safar@seznam.cz>
16989 * attribute.cs (Attribute.Resolve): Add error 653 report.
16991 * class.cs (Class.ApplyAttributeBuilder): Add error 641
16993 (Method.ApplyAttributeBuilder): Add error 685 report.
16994 (Operator.Define): Add error 564 report.
16996 * cs-tokenizer.cs (handle_hex): Add error 1013 report.
16998 * expression.cs (Invocation.DoResolve): Add error
16999 245 and 250 report.
17001 * parameter.cs (Parameter.ApplyAttributeBuilder): Add
17004 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17006 * class.cs (ConstructorInitializer.Resolve):
17007 Wrong error number (515->516).
17009 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17011 * class.cs (Indexer.Define): Add error 631 report.
17013 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17015 * ecore.cs (Error_NegativeArrayIndex): Fix 248 error.
17017 2004-09-11 Marek Safar <marek.safar@seznam.cz>
17019 * expression.cs (Probe.DoResolve): Add error CS0241 report.
17021 2004-09-10 Marek Safar <marek.safar@seznam.cz>
17023 * cs-parser.jay: Added error CS0241 report.
17025 2004-09-10 Raja R Harinath <rharinath@novell.com>
17027 * cs-parser.jay (fixed_statement): Introduce a scope for the
17028 declaration in the 'fixed' statement.
17030 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17032 * cs-parser.jay: Added CS0230 error report.
17034 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17036 * cs-parser.jay: Added errors CS0231 and CS0257 report.
17038 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17040 * expression.cs (Argument.Resolve): Added error CS0192 and
17043 2004-09-09 Marek Safar <marek.safar@seznam.cz>
17045 C# 2.0 #pragma warning feature
17047 * cs-tokenizer.cs (PreProcessPragma): New method;
17048 Handles #pragma directive.
17050 * report.cs (WarningRegions): New class; Support
17051 class for #pragma warning directive. It tests whether
17052 warning is enabled for a given line.
17054 2004-09-08 Miguel de Icaza <miguel@ximian.com>
17056 * const.cs: Add more descriptive error report, tahnks to
17059 2004-09-08 Marek Safar <marek.safar@seznam.cz>
17061 * ecore.cs (FieldExpr.DoResolveLValue): Fixed CS0198 report.
17063 2004-09-07 Miguel de Icaza <miguel@ximian.com>
17065 * expression.cs: Apply patch from Ben: Remove dead code from
17066 ArrayCreation, and remove the TurnintoConstant call in const.cs,
17067 as that code just threw an exception anwyays.
17069 * const.cs: Remove the call to the turnintoconstant, for details
17072 * literal.cs: The type of the null-literal is the null type; So
17073 we use a placeholder type (literal.cs:System.Null, defined here)
17076 * expression.cs (Conditional.DoResolve): Remove some old code that
17077 is no longer needed, conversions have been fixed.
17079 (ArrayCreationExpression.DoResolve): Return false if we fail to
17080 resolve the inner expression.
17082 2004-09-07 Raja R Harinath <rharinath@novell.com>
17085 * cs-parser.jay (delegate_declaration): Record a delegate
17086 declaration as a type declaration.
17087 Reported by Jo Vermeulen <jo@lumumba.luc.ac.be>.
17089 2004-09-06 Miguel de Icaza <miguel@ximian.com>
17091 * parameter.cs: Do not crash if the type can not be resolved.
17093 * expression.cs: Report errors with unsafe pointers, fixes #64896
17095 2004-09-06 Ben Maurer <bmaurer@users.sourceforge.net>
17097 * expression.cs: Pointer arith always needs to do a conv.i
17098 if the operand is a long. fix 65320
17100 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17102 Fixed cs0619-37.cs, cs0619-38.cs
17104 * enum.cs (GetObsoleteAttribute): Removed.
17106 * expression.cs (MemberAccess.DoResolve): Test for [Obsolete]
17107 on Enum member is double staged. The first is tested member
17110 2004-09-04 Marek Safar <marek.safar@seznam.cz>
17112 Fixed #56986, #63631, #65231
17114 * class.cs: (TypeContainer.AddToMemberContainer): New method,
17115 adds member to name container.
17116 (TypeContainer.AddToTypeContainer): New method, adds type to
17118 (AddConstant, AddEnum, AddClassOrStruct, AddDelegate, AddMethod,
17119 AddConstructor, AddInterface, AddField, AddProperty, AddEvent,
17120 AddOperator): Simplified by reusing AddToMemberContainer.
17121 (TypeContainer.UserDefinedStaticConstructor): Changed to property
17123 (Method.CheckForDuplications): Fixed implementation to test all
17125 (MemberBase): Detection whether member is explicit interface
17126 implementation is now in constructor.
17127 (MemberBase.UpdateMemberName): Handles IndexerName.
17128 (Accessor): Changed to keep also location information.
17129 (AbstractPropertyEventMethod): Is derived from MemberCore.
17130 (AbstractPropertyEventMethod.IsDummy): Says whether accessor
17131 will be emited or not.
17132 (PropertyBase.AreAccessorsDuplicateImplementation):
17133 Tests whether accessors are not in collision with some method.
17134 (Operator): Is derived from MethodCore to simplify common
17137 * decl.cs (Flags.TestMethodDuplication): Test for duplication
17139 (DeclSpace.AddToContainer): Adds the member to defined_names
17140 table. It tests for duplications and enclosing name conflicts.
17142 * enum.cs (EnumMember): Clean up to reuse the base structures
17144 2004-09-03 Martin Baulig <martin@ximian.com>
17146 * class.cs (TypeContainer.DefineDefaultConstructor): Put this back
17147 into TypeContainer, to make partial classes work again.
17149 2004-09-03 Martin Baulig <martin@ximian.com>
17151 * rootcontext.cs (RootContext.V2): Removed.
17153 2004-03-23 Martin Baulig <martin@ximian.com>
17155 * expression.cs (Invocation.OverloadResolve): Added `bool
17156 may_fail' argument and use it instead of the Location.IsNull() hack.
17158 2004-09-03 Martin Baulig <martin@ximian.com>
17160 Merged latest changes into gmcs. Please keep this comment in
17161 here, it makes it easier for me to see what changed in MCS since
17162 the last time I merged.
17164 2004-09-03 Raja R Harinath <rharinath@novell.com>
17167 * expression.cs (BetterConversion): Don't allow either conversion
17168 to be null. Remove redundant implicit conversion test when 'q ==
17169 null' -- when this function is invoked, we already know that the
17170 implicit conversion exists.
17171 (BetterFunction): Assume that 'best' is non-null. Remove
17172 redundant reimplementation of IsApplicable when 'best' is null.
17173 (IsParamsMethodApplicable, IsApplicable): Add new parameter for
17174 number of arguments.
17175 (IsAncestralType): Extract from OverloadResolve.
17176 (OverloadResolve): Make robust to the MethodGroupExpr being
17177 unsorted. Implement all the logic of Section 14.5.5.1, and
17178 support overloading of methods from multiple applicable types.
17179 Clean up logic somewhat. Don't pass null methods to BetterFunction.
17181 * report.cs (SymbolRelatedToPreviousError): Cleanup output.
17182 (RealError, Warning): Append type of report to related symbol.
17184 2004-09-03 Marek Safar <marek.safar@seznam.cz>
17186 * enum.cs: Fixed CLS-Compliance checks for enum members.
17187 Error tests cs3008-8.cs, cs3014-8.cs
17189 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17191 Fixed bug #62342, #63102
17192 * class.cs: ImplementIndexer uses member.IsExplicitImpl
17193 like ImplementMethod.
17195 2004-09-02 Marek Safar <marek.safar@seznam.cz>
17197 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17200 2004-09-02 Martin Baulig <martin@ximian.com>
17202 * statement.cs (Using.EmitLocalVariableDeclFinally): Use
17203 TypeManager.GetArgumentTypes() rather than calling GetParameters()
17206 2004-09-01 Marek Safar <marek.safar@seznam.cz>
17208 C# 2.0 Static classes implemented
17210 * class.cs (TypeContainer): instance_constructors,
17211 initialized_fields, initialized_static_fields,
17212 default_constructor, base_inteface_types are protected to be
17213 accessible from StaticClass.
17214 (TypeContainer.DefineDefaultConstructor): New virtual method
17215 for custom default constructor generating
17216 (StaticClass): New class to handle "Static classes" feature.
17218 * cs-parser.jay: Handle static keyword on class like instance
17221 * driver.cs: Added "/langversion" command line switch with two
17222 options (iso-1, default).
17224 2004-08-31 Marek Safar <marek.safar@seznam.cz>
17226 * ecore.cs (FieldExpr.Resolve): Fixed bug #64689.
17228 2004-08-31 Miguel de Icaza <miguel@ximian.com>
17230 * delegate.cs: Style.
17232 2004-08-31 Ben Maurer <bmaurer@users.sourceforge.net>
17234 * delegate.cs: Add seperate instance expr field for miguel.
17236 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17238 * PointerArithmetic (Resolve): make sure we are not doing
17239 pointer arith on void*. Also, make sure we are resolved
17240 by not setting eclass until resolve.
17242 All callers: Make sure that PointerArithmetic gets resolved.
17244 2004-08-29 Ben Maurer <bmaurer@users.sourceforge.net>
17246 * ArrayCreation (LookupType): If the type does not resolve
17247 to an array, give an error.
17249 2004-08-27 Marek Safar <marek.safar@seznam.cz>
17251 * statement.cs (Try.Resolve): Fixed bug #64222
17253 2004-08-27 Martin Baulig <martin@ximian.com>
17256 (TC.OperatorArrayList.OperatorEntry.CheckPairedOperators): Don't
17259 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17261 * ecore.cs (Constantify): Get underlying type via
17262 System.Enum.GetUnderlyingType to avoid StackOverflow on the
17263 Windows in special cases.
17265 2004-08-26 Marek Safar <marek.safar@seznam.cz>
17267 * typemanager.cs (GetAddMethod): Used GetAddMethod (true)
17268 for obtaining also private methods.
17269 (GetRemoveMethod): Used GetRemoveMethod (true)
17270 for obtaining also private methods.
17272 2004-08-24 Martin Baulig <martin@ximian.com>
17274 * class.cs (Method.Define): Set MethodAttributes.SpecialName and
17275 MethodAttributes.HideBySig for operators.
17277 2004-08-23 Martin Baulig <martin@ximian.com>
17279 Back to the old error reporting system :-)
17281 * report.cs (Message): Removed.
17282 (Report.MessageData, ErrorData, WarningData): Removed.
17283 (Report.Error, Warning): Back to the old system.
17285 2004-08-23 Martin Baulig <martin@ximian.com>
17287 * decl.cs (IMemberContainer.Parent): Renamed to ParentContainer.
17289 * class.cs (TypeContainer.ParentContainer): New public virtual
17290 method; replaces the explicit interface implementation.
17291 (ClassPart.ParentContainer): Override.
17293 2004-08-23 Martin Baulig <martin@ximian.com>
17295 * statement.cs (Switch): Added support for constant switches; see
17296 #59428 or test-285.cs.
17298 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17301 * statement.cs (GetEnumeratorFilter): Removed useless
17302 logic because C# specs is strict. GetEnumerator must be
17305 2004-08-22 Martin Baulig <martin@ximian.com>
17307 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
17308 a switch and may break, reset the barrier. Fixes #59867.
17310 2004-08-22 Marek Safar <marek.safar@seznam.cz>
17312 CLS-Compliance speed up (~5% for corlib)
17314 * attribute.cs (AttributeTester.VerifyTopLevelNameClsCompliance):
17315 New method. Tests container for CLS-Compliant names
17317 * class.cs (TypeContainer.VerifyClsName): New method.
17318 Checks whether container name is CLS Compliant.
17319 (Constructor): Implements IMethodData.
17321 * decl.cs (MemberCache.GetPublicMembers ): New method. Builds
17322 low-case table for CLS Compliance test.
17323 (MemberCache.VerifyClsParameterConflict): New method.
17324 Checks method parameters for CS3006 error.
17326 * enum.cs (EnumMember): Is derived from MemberCore.
17327 (Enum.VerifyClsName): Optimized for better performance.
17329 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17331 * report.cs: Renamed Error_T to Error and changed all
17334 2004-08-06 Marek Safar <marek.safar@seznam.cz>
17336 * class.cs (TypeContainer.IndexerArrayList): New inner class
17337 container for indexers.
17338 (TypeContainer.DefaultIndexerName): New constant for default
17339 indexer name. Replaced all "Item" with this constant.
17340 (TypeContainer.DefineIndexers): Moved to IndexerArrayList class.
17342 * typemanager.cs (TypeManager.default_member_ctor): Cache here
17343 DefaultMemberAttribute constructor.
17345 2004-08-05 Martin Baulig <martin@ximian.com>
17347 * flowanalysis.cs (FlowBranching.UsageVector.MergeJumpOrigins):
17350 2004-08-05 Marek Safar <marek.safar@seznam.cz>
17352 * mcs.exe.sources: $(EXTRA_SOURCES) are now here to avoid
17353 multi platforms problem.
17355 * compiler.csproj: Included shared files.
17357 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17359 Fix bug 60333, 55971 in the more general way
17360 * attribute.cs (Attribute.GetAttributeArgumentExpression):
17361 Added arg_type argument for constant conversion.
17362 (Attribute.Resolve): Reuse GetAttributeArgumentExpression.
17364 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17367 * class.cs (TypeContainer ): New inner classes MethodArrayList,
17368 OperatorArrayList, MethodCoreArrayList for typecontainer
17369 containers. Changed class member types to these new types.
17370 (MethodArrayList.DefineMembers): Added test for CS0659.
17372 2004-08-04 Miguel de Icaza <miguel@ximian.com>
17374 * cfold.cs: Synchronize the folding with the code in expression.cs
17375 Binary.DoNumericPromotions for uint operands.
17377 * attribute.cs: Revert patch from Raja, it introduced a regression
17378 while building Blam-1.2.1 (hard to isolate a test case).
17380 2004-08-04 Marek Safar <marek.safar@seznam.cz>
17384 (TypeContainer.Define): Renamed to DefineContainerMembers because of
17386 (MethodCore.parent_method): New member. The method we're overriding
17387 if this is an override method.
17388 (MethodCore.CheckBase): Moved from Method class and made common.
17389 (MethodCore.CheckMethodAgainstBase): Moved from MemberBase and made
17391 (MethodCore.CheckForDuplications): New abstract method. For custom
17392 member duplication search in a container
17393 (MethodCore.FindOutParentMethod): New abstract method. Gets parent
17394 method and its return type.
17395 (Event.conflict_symbol): New member. Symbol with same name in the
17399 (MemberCache.FindMemberWithSameName): New method. The method
17400 is looking for conflict with inherited symbols.
17402 2004-08-04 Martin Baulig <martin@ximian.com>
17404 * codegen.cs (VariableStorage.EmitLoadAddress): New public method.
17406 * statement.cs (Foreach.EmitFinally): Make this work for valuetypes.
17408 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17410 * report.cs (Message): New enum for better error, warning reference in
17412 (MessageData): New inner abstract class. It generally handles printing of
17413 error and warning messages.
17414 Removed unused Error, Warning, Message methods.
17416 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17418 Fix for cs0592-8.cs test
17420 (Attributable.ValidAttributeTargets): Made public.
17421 (Attribute.ExplicitTarget): New member for explicit target value.
17422 (Attribute.CheckTargets): Now we translate explicit attribute
17423 target to Target here.
17425 2004-08-03 Ben Maurer <bmaurer@ximian.com>
17427 * ecore.cs (MethodGroupExpr): new IsBase property.
17429 * expression.cs (BaseAccess): Set IsBase on MethodGroupExpr.
17431 * delegate.cs (DelegateCreation): store a MethodGroupExpr
17432 rather than an instance expr.
17434 (DelegateCreation.Emit): Use the method group rather than
17435 the instance expression. Also, if you have base.Foo as the
17436 method for a delegate, make sure to emit ldftn, not ldftnvirt.
17438 (ResolveMethodGroupExpr): Use the MethodGroupExpr.
17440 (NewDelegate.DoResolve): Only check for the existance of Invoke
17441 if the method is going to be needed. Use MethodGroupExpr.
17443 (NewDelegate.Emit): Remove, DelegateCreation implements this.
17445 * expression.cs: For pointer arith., make sure to use
17446 the size of the type, not the size of the pointer to
17449 2004-08-03 Marek Safar <marek.safar@seznam.cz>
17452 * class.cs (Class): Added error CS0502 test.
17454 2004-08-03 John Luke <jluke@cfl.rr.com>
17455 Raja R Harinath <rharinath@novell.com>
17458 * attribute.cs (Attribute.complained_before): New flag.
17459 (Attribute.ResolveType, Attribute.Resolve),
17460 (Attribute.DefinePInvokeMethod): Set it.
17461 (Attributes.Search): Pass 'complain' to Attribute.ResolveType.
17463 2004-08-03 Martin Baulig <martin@ximian.com>
17465 * expression.cs (Binary.ResolveOperator): Don't abort if we can't
17466 use a user-defined operator; we still need to do numeric
17467 promotions in case one argument is a builtin type and the other
17468 one has an implicit conversion to that type. Fixes #62322.
17470 2004-08-02 Martin Baulig <martin@ximian.com>
17472 * statement.cs (LocalInfo.Flags): Added `IsThis'.
17473 (LocalInfo.IsThis): New public property.
17474 (Block.EmitMeta): Don't create a LocalBuilder for `this'.
17476 2004-08-01 Martin Baulig <martin@ximian.com>
17478 * class.cs (TypeContainer.GetClassBases): Don't set the default
17479 here since we may get called from GetPartialBases().
17480 (TypeContainer.DefineType): If GetClassBases() didn't return a
17481 parent, use the default one.
17483 2004-07-30 Duncan Mak <duncan@ximian.com>
17485 * Makefile (mcs2.exe, mcs3.exe): add $(EXTRA_SOURCES).
17487 2004-07-30 Martin Baulig <martin@ximian.com>
17489 * Makefile (EXTRA_SOURCES): List the symbol writer's sources here.
17491 * class.cs (SourceMethod): New public class, derive from the
17492 symbol writer's ISourceMethod.
17493 (Method): Use the new symbol writer API.
17495 * codegen.cs (CodeGen.InitializeSymbolWriter): Take the filename
17496 as argument and use the new symbol writer.
17499 (SourceFile): Implement the symbol writer's ISourceFile.
17500 (Location.SymbolDocument): Removed.
17501 (Location.SourceFile): New public property.
17503 * symbolwriter.cs: Use the new symbol writer API.
17505 2004-07-30 Raja R Harinath <rharinath@novell.com>
17507 * Makefile (install-local): Remove. Functionality moved to
17510 2004-07-28 Lluis Sanchez Gual <lluis@novell.com>
17512 * Makefile: Install mcs.exe.config file together with mcs.exe.
17513 * mcs.exe.config: Added supportedRuntime entry to make sure it runs in the
17514 correct runtime version.
17516 2004-07-25 Martin Baulig <martin@ximian.com>
17519 (TypeContainer.RegisterOrder): Removed, this was unused.
17520 (TypeContainer, interface_order): Removed.
17521 (TypeContainer.AddClass, AddStruct, AddInterface): Take a
17522 TypeContainer as argument since we can also be called with a
17523 `PartialContainer' for a partial class/struct/interface.
17524 (TypeContainer.IsInterface): Use `Kind == Kind.Interface' instead
17525 of checking whether we're an `Interface' - we could be a
17526 `PartialContainer'.
17527 (PartialContainer.Register): Override; call
17528 AddClass()/AddStruct()/AddInterface() on our parent.
17530 * cs-parser.jay (interface_member_declaration): Add things to the
17531 `current_container', not the `current_class'.
17533 * rootcontext.cs (RegisterOrder): The overloaded version which
17534 takes an `Interface' was unused, removed.
17536 * typemanager.cs (TypeManager.LookupInterface): Return a
17537 `TypeContainer', not an `Interface'.
17538 (TypeManager.IsInterfaceType): The `builder_to_declspace' may
17539 contain a `PartialContainer' for an interface, so check it's
17540 `Kind' to figure out what it is.
17542 2004-07-25 Martin Baulig <martin@ximian.com>
17544 * class.cs (Class.DefaultTypeAttributes): New public constant.
17545 (Struct.DefaultTypeAttributes): Likewise.
17546 (Interface.DefaultTypeAttributes): Likewise.
17547 (PartialContainer.TypeAttr): Override this and add the
17548 DefaultTypeAttributes.
17550 2004-07-25 Martin Baulig <martin@ximian.com>
17552 * decl.cs (DeclSpace.Emit): Removed the `TypeContainer' argument,
17553 we can just use the `Parent' field instead.
17555 2004-07-25 Martin Baulig <martin@ximian.com>
17557 * class.cs (TypeContainer.Emit): Renamed to EmitType().
17559 2004-07-25 Martin Baulig <martin@ximian.com>
17561 * class.cs (TypeContainer.DefineMembers): Call DefineMembers() on
17562 our parts before defining any methods.
17563 (TypeContainer.VerifyImplements): Make this virtual.
17564 (ClassPart.VerifyImplements): Override and call VerifyImplements()
17565 on our PartialContainer.
17567 2004-07-25 Martin Baulig <martin@ximian.com>
17569 * iterators.cs (Iterator.Define): Renamed to DefineIterator().
17571 * decl.cs (DeclSpace.Define): Removed the `TypeContainer'
17572 argument, we can just use the `Parent' field instead.
17575 (MemberBase.CheckBase): Removed the `TypeContainer' argument.
17576 (MemberBase.DoDefine): Likewise.
17578 2004-07-24 Martin Baulig <martin@ximian.com>
17580 * decl.cs (MemberCore.Parent): New public field.
17581 (DeclSpace.Parent): Moved to MemberCore.
17583 * class.cs (MethodCore.ds): Removed; use `Parent' instead.
17584 (MemberBase.ctor): Added TypeContainer argument, pass it to our
17586 (FieldBase, Field, Operator): Likewise.
17587 (EventProperty.ctor): Take a TypeContainer instead of a DeclSpace.
17588 (EventField, Event): Likewise.
17590 2004-07-23 Martin Baulig <martin@ximian.com>
17592 * class.cs (PartialContainer): New public class.
17593 (ClassPart): New public class.
17594 (TypeContainer): Added support for partial classes.
17595 (TypeContainer.GetClassBases): Splitted some of the functionality
17596 out into GetNormalBases() and GetPartialBases().
17598 * cs-tokenizer.cs (Token.PARTIAL): New token.
17599 (Tokenizer.consume_identifier): Added some hacks to recognize
17600 `partial', but only if it's immediately followed by `class',
17601 `struct' or `interface'.
17603 * cs-parser.jay: Added support for partial clases.
17605 2004-07-23 Martin Baulig <martin@ximian.com>
17607 * class.cs (MethodCore.ds): Made this a `TypeContainer' instead of
17608 a `DeclSpace' and also made it readonly.
17609 (MethodCore.ctor): Take a TypeContainer instead of a DeclSpace.
17610 (Method.ctor, Constructor.ctor, Destruktor.ctor): Likewise.
17611 (PropertyBase.ctor, Property.ctor, Indexer.ctor): Likewise.
17613 * cs-parser.jay: Pass the `current_class', not the
17614 `current_container' (at the moment, this is still the same thing)
17615 to a new Method, Property, Event, Indexer or Constructor.
17617 2004-07-23 Martin Baulig <martin@ximian.com>
17619 * cs-parser.jay (CSharpParser): Added a new `current_class' field
17620 and removed the `current_interface' one.
17621 (struct_declaration, class_declaration, interface_declaration):
17622 Set `current_class' to the newly created class/struct/interface;
17623 set their `Bases' and call Register() before parsing their body.
17625 2004-07-23 Martin Baulig <martin@ximian.com>
17627 * class.cs (Kind): New public enum.
17628 (TypeContainer): Made this class abstract.
17629 (TypeContainer.Kind): New public readonly field.
17630 (TypeContainer.CheckDef): New public method; moved here from
17632 (TypeContainer.Register): New public abstract method.
17633 (TypeContainer.GetPendingImplementations): New public abstract
17635 (TypeContainer.GetClassBases): Removed the `is_class' and
17636 `is_iface' parameters.
17637 (TypeContainer.DefineNestedTypes): Formerly known as
17639 (ClassOrStruct): Made this class abstract.
17641 * tree.cs (RootTypes): New public type.
17643 2004-07-20 Martin Baulig <martin@ximian.com>
17645 * tree.cs (Tree.RecordNamespace): Removed.
17646 (Tree.Namespaces): Removed.
17648 * rootcontext.cs (RootContext.IsNamespace): Removed.
17650 * cs-parser.jay (namespace_declaration): Just create a new
17651 NamespaceEntry here.
17653 2004-07-20 Martin Baulig <martin@ximian.com>
17655 * statement.cs (ExceptionStatement): New abstract class. This is
17656 now used as a base class for everyone who's using `finally'.
17657 (Using.ResolveLocalVariableDecls): Actually ResolveLValue() all
17658 our local variables before using them.
17660 * flowanalysis.cs (FlowBranching.StealFinallyClauses): New public
17661 virtual method. This is used by Yield.Resolve() to "steal" an
17662 outer block's `finally' clauses.
17663 (FlowBranchingException): The .ctor now takes an ExceptionStatement
17666 * codegen.cs (EmitContext.StartFlowBranching): Added overloaded
17667 version which takes an ExceptionStatement. This version must be
17668 used to create exception branchings.
17671 (Yield.Resolve): "Steal" all `finally' clauses from containing blocks.
17672 (Iterator.EmitMoveNext): Added exception support; protect the
17673 block with a `fault' clause, properly handle 'finally' clauses.
17674 (Iterator.EmitDispose): Run all the `finally' clauses here.
17676 2004-07-20 Martin Baulig <martin@ximian.com>
17678 * iterator.cs: This is the first of a set of changes in the
17679 iterator code. Match the spec more closely: if we're an
17680 IEnumerable, then GetEnumerator() must be called. The first time
17681 GetEnumerator() is called, it returns the current instance; all
17682 subsequent invocations (if any) must create a copy.
17684 2004-07-19 Miguel de Icaza <miguel@ximian.com>
17686 * expression.cs: Resolve the constant expression before returning
17689 2004-07-19 Martin Baulig <martin@ximian.com>
17691 * iterators.cs (Iterator.MapVariable): Don't define fields twice.
17692 (Iterator.MoveNextMethod.DoEmit): Use `TypeManager.int32_type' as
17693 the return type of the new EmitContext.
17695 2004-07-18 Martin Baulig <martin@ximian.com>
17697 * class.cs (Property.Define): Fix iterators.
17699 * iterators.cs (Iterator.Define): Moved the
17700 `container.AddInterator (this)' call here from the .ctor; only do
17701 it if we resolved successfully.
17703 2004-07-17 Miguel de Icaza <miguel@ximian.com>
17705 * cs-tokenizer.cs (handle_preprocessing_directive): Do not return
17706 `true' for preprocessing directives that we parse. The return
17707 value indicates whether we should return to regular tokenizing or
17708 not, not whether it was parsed successfully.
17710 In the past if we were in: #if false ... #line #endif, we would
17711 resume parsing after `#line'. See bug 61604.
17713 * typemanager.cs: Removed an old hack from Gonzalo to get corlib
17714 building: IsEnumType should return true only for enums, not for
17715 enums or System.Enum itself. This fixes #61593.
17717 Likely what happened is that corlib was wrong: mcs depended on
17718 this bug in some places. The bug got fixed, we had to add the
17719 hack, which caused bug 61593.
17721 * expression.cs (ArrayAccess.GetStoreOpCode): Remove an old hack
17722 that was a workaround for the older conditions.
17724 2004-07-16 Ben Maurer <bmaurer@ximian.com>
17726 * assign.cs: IAssignMethod has a new interface, as documented
17727 inline. All assignment code now uses this new api.
17729 * ecore.cs, expression.cs: All classes which implement
17730 IAssignMethod now use the new interface.
17732 * expression.cs (Invocation): add a hack to EmitCall so that
17733 IndexerAccess can be the target of a compound assignment without
17734 evaluating its arguments twice.
17736 * statement.cs: Handle changes in Invocation api.
17738 2004-07-16 Martin Baulig <martin@ximian.com>
17740 * iterators.cs: Rewrote this. We're now using one single Proxy
17741 class for both the IEnumerable and the IEnumerator interface and
17742 `Iterator' derives from Class so we can use the high-level API.
17744 * class.cs (TypeContainer.AddIterator): New method.
17745 (TypeContainer.DoDefineType): New protected virtual method, which
17746 is called from DefineType().
17747 (TypeContainer.DoDefineMembers): Call DefineType() and
17748 DefineMembers() on all our iterators.
17749 (TypeContainer.Emit): Call Emit() on all our iterators.
17750 (TypeContainer.CloseType): Call CloseType() on all our iterators.
17752 * codegen.cs (EmitContext.CurrentIterator): New public field.
17754 2004-07-15 Martin Baulig <martin@ximian.com>
17757 (TypeManager.not_supported_exception_type): New type.
17759 2004-07-14 Martin Baulig <martin@ximian.com>
17761 * iterators.cs: Use real error numbers.
17763 2004-07-14 Martin Baulig <martin@ximian.com>
17765 * iterator.cs (IteratorHandle.IsIEnumerable): The spec explicitly
17766 requires this to be a System.Collection.IEnumerable and not a
17767 class implementing that interface.
17768 (IteratorHandle.IsIEnumerator): Likewise, for IEnumerator.
17770 2004-07-13 Marek Safar <marek.safar@seznam.cz>
17772 * class.cs: Fixed previous fix, it broke some error tests.
17774 2004-07-12 Martin Baulig <martin@ximian.com>
17776 * enum.cs (Enum.Define): Call Emit() to emit the attributes.
17779 2004-07-09 Miguel de Icaza <miguel@ximian.com>
17781 * assign.cs (LocalTemporary): Add new argument: is_address,If
17782 `is_address' is true, then the value that we store is the address
17783 to the real value, and not the value itself.
17785 * ecore.cs (PropertyExpr): use the new local temporary
17786 stuff to allow us to handle X.Y += z (where X is a struct)
17788 2004-07-08 Martin Baulig <martin@ximian.com>
17790 * statement.cs (Lock.Resolve): Set ec.NeedReturnLabel() if we do
17791 not always return, just like we're doing in Using.Resolve().
17793 2004-07-07 Miguel de Icaza <miguel@ximian.com>
17795 * cs-parser.jay (fixed_statement): flag this as Pinned.
17797 2004-07-06 Miguel de Icaza <miguel@ximian.com>
17799 * typemanager.cs (TypeManager): Removed MakePinned method, this
17800 mechanism is replaced with the .NET 2.x compatible mechanism of
17801 calling `ILGenerator.DeclareLocal (Type t, bool pinned)'.
17803 * statement.cs (LocalInfo): Remove MakePinned, add Pinned property
17804 Rename `Fixed' to `Pinned' as a flag, to distinguish from the
17805 `IsFixed' property which has a different meaning.
17807 2004-07-02 Raja R Harinath <rharinath@novell.com>
17809 * ecore.cs (DoSimpleNameResolve): Expand CS0038 check to all names
17810 visible from inside a nested class, not just the names of the
17811 immediately enclosing class.
17812 Fix for bug #60730.
17814 2004-06-24 Raja R Harinath <rharinath@novell.com>
17816 * expression.cs (BetterConversion): Remove buggy special-case
17817 handling of "implicit constant expression conversions". At this
17818 point, we already know that the conversion is possible -- we're
17819 only checking to see which is better.
17821 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17823 * cs-parser.jay: Added error CS0210 test.
17825 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17827 * cs-parser.jay: Added error CS0134 test.
17829 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17832 * cs-parser.jay: Added error CS0145 test.
17834 2004-06-24 Marek Safar <marek.safar@seznam.cz>
17836 * class.cs (Operator.Define): Added test for errors CS0553, CS0554.
17838 2004-06-23 Ben Maurer <bmaurer@ximian.com>
17840 * expression.cs (StackAlloc.Resolve): The argument may not
17841 be a constant; deal with this case.
17843 2004-06-23 Marek Safar <marek.safar@seznam.cz>
17845 * attribute.cs (IndexerName_GetIndexerName): Renamed to
17846 GetIndexerAttributeValue.
17847 (ScanForIndexerName): Renamed to GetIndexerNameAttribute.
17849 * class.cs (Indexer.Define): Added error tests for CS0415,
17852 2004-06-23 Miguel de Icaza <miguel@ximian.com>
17854 * attribute.cs (Attribute.Resolve): Keep field code in sync with
17857 2004-06-23 Martin Baulig <martin@ximian.com>
17859 * flowanalysis.cs (UsageVector.MergeChild): If we're a loop and we
17860 neither return nor throw, reset the barrier as well. Fixes #60457.
17862 2004-06-22 Atsushi Enomoto <atsushi@ximian.com>
17864 * class.cs : EventAttributes is now set to None by default.
17865 This fixes bug #60459.
17867 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17870 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
17871 Don't throw exception but return null (it's sufficient now).
17873 2004-06-18 Marek Safar <marek.safar@seznam.cz>
17875 * typemanager.cs (GetArgumentTypes): Faster implementation.
17877 2004-06-18 Martin Baulig <martin@ximian.com>
17879 * attribute.cs (Attribute.Resolve): Check whether we're an
17880 EmptyCast which a Constant child. Fixes #60333.
17882 2004-06-17 Ben Maurer <bmaurer@ximian.com>
17884 * statement.cs (EmitCollectionForeach): Account for the fact that
17885 not all valuetypes are in areas which we can take the address of.
17886 For these variables, we store to a temporary variable. Also, make
17887 sure that we dont emit a `callvirt' on a valuetype method.
17889 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17891 * expression.cs (StackAlloc.DoReSolve): Added test for
17892 negative parameter (CS0247).
17894 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17897 * class.cs: (Event.DelegateMethod.Emit): Added synchronization flag.
17899 2004-06-15 Marek Safar <marek.safar@seznam.cz>
17902 * expression.cs: (Binary.DoNumericPromotions): Added conversion for
17905 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17907 Fix bug #58254 & cs1555.cs, cs1556.cs
17908 * driver.cs (MainDriver): Added tests for errors CS1555, CS1556.
17910 2004-06-14 Marek Safar <marek.safar@seznam.cz>
17912 * cs-parser.jay: Added error CS1669 test for indexers.
17914 2004-06-11 Martin Baulig <martin@ximian.com>
17916 * expression.cs (Invocation.IsParamsMethodApplicable): We need to
17917 call this twice: for params and varargs methods.
17919 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17922 (FieldBase.DoDefine, PropertyBase.DoDefine): Added error test CS0610.
17924 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17926 * attribute.cs (Attribute.GetValidTargets): Made public.
17929 (AbstractPropertyEventMethod): New class for better code sharing.
17930 (AbstractPropertyEventMethod.ApplyAttributeBuilder): Add error
17932 (PropertyMethod, DelegateMethod): Derived from AbstractPropertyEventMethod
17934 2004-06-11 Raja R Harinath <rharinath@novell.com>
17937 * ecore.cs (ResolveFlags): Add new 'Intermediate' flag to tell
17938 that the call to Resolve is part of a MemberAccess.
17939 (Expression.Resolve): Use it for SimpleName resolution.
17940 (SimpleName.SimpleNameResolve, SimpleName.DoResolveAllowStatic):
17941 Add 'intermediate' boolean argument.
17942 (SimpleName.DoSimpleNameResolve): Likewise. Use it to disable an
17943 error message when the SimpleName can be resolved ambiguously
17944 between an expression and a type.
17945 * expression.cs (MemberAccess.IdenticalNameAndTypeName): Make
17947 (MemberAccess.Resolve): Pass 'Intermediate' flag to the Resolve()
17948 call on the left-side.
17950 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17953 (MethodCore.VerifyClsCompliance): Added test for error CS3000.
17955 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17957 * attribute.cs (Attribute.Emit): Fixed error CS0579 reporting.
17959 2004-06-11 Martin Baulig <martin@ximian.com>
17961 * expression.cs (Invocation.EmitCall): Use OpCodes.Callvirt for
17962 varargs methods if applicable.
17964 2004-06-11 Martin Baulig <martin@ximian.com>
17966 * expression.cs (Invocation.EmitCall): Don't use
17967 `method.CallingConvention == CallingConventions.VarArgs' since the
17968 method could also have `CallingConventions.HasThis'.
17970 2004-06-11 Marek Safar <marek.safar@seznam.cz>
17972 * class.cs (Event.GetSignatureForError): Implemented.
17973 Fixed crash in error test cs3010.cs
17975 2004-06-10 Miguel de Icaza <miguel@ximian.com>
17977 * cs-tokenizer.cs: Change the way we track __arglist to be
17978 consistent with the other keywords.
17980 2004-06-09 Miguel de Icaza <miguel@ximian.com>
17982 * codegen.cs: FAQ avoider: turn 1577 into a warning for now until
17985 2004-06-09 Sebastien Pouliot <sebastien@ximian.com>
17987 * codegen.cs: Check that all referenced assemblies have a strongname
17988 before strongnaming the compiled assembly. If not report error CS1577.
17989 Fix bug #56563. Patch by Jackson Harper.
17990 * typemanager.cs: Added a method to return all referenced assemblies.
17991 Fix bug #56563. Patch by Jackson Harper.
17993 2004-06-08 Marek Safar <marek.safar@seznam.cz>
17996 (Method.ApplyAttributeBuilder): Moved and added conditional
17997 attribute error tests (CS0577, CS0578, CS0243, CS0582, CS0629).
18000 (DelegateCreation.ResolveMethodGroupExpr): Added error CS1618 test.
18002 2004-06-08 Marek Safar <marek.safar@seznam.cz>
18005 * class.cs: (EventField.attribute_targets): Changed default target.
18007 2004-06-08 Martin Baulig <martin@ximian.com>
18009 * expression.cs (Invocation.EmitCall): Enable varargs methods.
18011 2004-06-08 Martin Baulig <martin@ximian.com>
18013 * rootcontext.cs (ResolveCore): Added "System.RuntimeArgumentHandle".
18015 2004-06-07 Martin Baulig <martin@ximian.com>
18017 Added support for varargs methods.
18019 * cs-tokenizer.cs (Token.ARGLIST): New token for the `__arglist'
18022 * cs-parser.jay: Added support for `__arglist'.
18024 * decl.cs (MemberCache.AddMethods): Don't ignore varargs methods.
18026 * expression.cs (Argument.AType): Added `ArgList'.
18027 (Invocation): Added support for varargs methods.
18028 (ArglistAccess): New public class.
18029 (Arglist): New public class.
18031 * parameter.cs (Parameter.Modifier): Added `ARGLIST'.
18033 * statement.cs (Block.Flags): Added `HasVarargs'. We set this on
18034 a method's top-level block if the method has varargs.
18036 * support.cs (ReflectionParameters, InternalParameters): Added
18037 support for varargs methods.
18039 2004-06-07 Miguel de Icaza <miguel@ximian.com>
18041 * class.cs: Provide location in indexer error report.
18043 * driver.cs: Use standard names.
18045 * namespace.cs: Catch the use of using after a namespace has been
18046 declared also on using aliases.
18048 2004-06-03 Raja R Harinath <rharinath@novell.com>
18051 * typemanager.cs (closure_private_ok, closure_invocation_type)
18052 (closure_qualifier_type, closure_invocation_assembly)
18053 (FilterWithClosure): Move to ...
18054 (Closure): New internal nested class.
18055 (Closure.CheckValidFamilyAccess): Split out from Closure.Filter.
18056 (MemberLookup, RealMemberLookup): Add new almost_match parameter.
18057 * ecore.cs (almostMatchedMembers): New variable to help report CS1540.
18058 (MemberLookup, MemberLookupFailed): Use it.
18059 * expression.cs (New.DoResolve): Treat the lookup for the
18060 constructor as being qualified by the 'new'ed type.
18061 (Indexers.GetIndexersForTypeOrInterface): Update.
18063 2004-06-03 Marek Safar <marek.safar@seznam.cz>
18066 (GetConditionalAttributeValue): New method. Returns
18067 condition of ConditionalAttribute.
18068 (SearchMulti): New method. Returns all attributes of type 't'.
18069 Use it when attribute is AllowMultiple = true.
18070 (IsConditionalMethodExcluded): New method.
18073 (Method.IsExcluded): Implemented. Returns true if method has conditional
18074 attribute and the conditions is not defined (method is excluded).
18075 (IMethodData): Extended interface for ConditionalAttribute support.
18076 (PropertyMethod.IsExcluded): Implemented.
18079 (MemberCore.Flags): Excluded_Undetected, Excluded new caching flags.
18082 (Invocation.IsMethodExcluded): Checks the ConditionalAttribute
18085 2004-06-02 Ben Maurer <bmaurer@users.sourceforge.net>
18087 * expression.cs (ArrayCreationExpression): Make this just an
18088 `expression'. It can't be a statement, so the code here was
18091 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18094 * typemanager.cs (GetFullNameSignature): New method for
18097 2004-06-02 Marek Safar <marek.safar@seznam.cz>
18100 * class.cs (MemberBase.GetSignatureForError): New virtual method.
18101 Use this method when MethodBuilder is null.
18102 (MethodData.DefineMethodBuilder): Encapsulated code to the new method.
18103 Added test for error CS0626 (MONO reports error for this situation).
18104 (IMethodData.GetSignatureForError): Extended interface.
18106 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18109 (AttributeTester.GetObsoleteAttribute): Returns instance of
18110 ObsoleteAttribute when type is obsolete.
18113 (TypeContainer.VerifyObsoleteAttribute): Override.
18114 (Method.GetSignatureForError): New method for usage when MethodBuilder is null.
18115 (MethodCode.VerifyObsoleteAttribute): Override.
18116 (MemberBase.VerifyObsoleteAttribute): Override.
18119 (MemberCore.CheckUsageOfObsoleteAttribute): Tests presence of ObsoleteAttribute
18120 and report proper error.
18123 Delegate.VerifyObsoleteAttribute): Override.
18126 (Expression.CheckObsoleteAttribute): Tests presence of ObsoleteAttribute
18127 and report proper error.
18128 (FieldExpr.DoResolve): Added tests for ObsoleteAttribute.
18131 (Enum.GetObsoleteAttribute): Returns ObsoleteAttribute for both enum type
18135 (Probe.DoResolve, Cast.DoResolve, LocalVariableReference.DoResolve,
18136 New.DoResolve, SizeOf.DoResolve, TypeOf.DoResolce, MemberAccess.DoResolve):
18137 Added test for ObsoleteAttribute.
18140 (Catch): Derived from Statement.
18142 2004-06-01 Marek Safar <marek.safar@seznam.cz>
18144 Fixed bug #59071 & cs0160.cs
18146 * statement.cs (Try.Resolve): Check here whether order of catch
18147 clauses matches their dependencies.
18149 2004-05-31 Miguel de Icaza <miguel@ximian.com>
18151 * Reverted patch to namespace.cs (Use lookuptypedirect). This
18152 caused a regression: #59343. Referencing nested classes from an
18153 assembly stopped working.
18155 2004-05-31 Martin Baulig <martin@ximian.com>
18157 MCS is now frozen for beta 2.
18159 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18161 * convert.cs: add a trivial cache for overload operator resolution.
18163 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18165 * decl.cs: If possible, use lookuptypedirect here. We can only do
18166 this if there is no `.' after the namespace. Avoids using
18167 LookupType, which does lots of slow processing.
18168 (FindNestedType) New method, does what it says :-).
18169 * namespace.cs: use LookupTypeDirect.
18170 * rootcontext.cs: use membercache, if possible.
18171 * typemanager.cs (LookupTypeDirect): Cache negative hits too.
18173 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18176 According to the spec,
18178 In a member access of the form E.I, if E is a single identifier,
18179 and if the meaning of E as a simple-name (§7.5.2) is a constant,
18180 field, property, localvariable, or parameter with the same type as
18181 the meaning of E as a type-name (§3.8), then both possible
18182 meanings of E are permitted.
18184 We did not check that E as a simple-name had the same type as E as
18187 This trivial check gives us 5-7% on bootstrap time.
18189 2004-05-30 Ben Maurer <bmaurer@users.sourceforge.net>
18191 * expression.cs (Invocation.OverloadResolve): Avoid the
18192 use of hashtables and boxing here by allocating on demand.
18194 2004-05-30 Martin Baulig <martin@ximian.com>
18196 * rootcontext.cs (RootContext.LookupType): Don't cache things if
18197 we're doing a silent lookup. Don't try to lookup nested types in
18198 TypeManager.object_type (thanks to Ben Maurer).
18200 2004-05-30 Martin Baulig <martin@ximian.com>
18202 Committing a patch from Ben Maurer.
18204 * rootcontext.cs (RootContext.LookupType): Cache negative results.
18206 2004-05-29 Martin Baulig <martin@ximian.com>
18208 * class.cs (IMethodData.ShouldIgnore): New method.
18210 * typemanager.cs (TypeManager.MethodFlags): Don't take a
18211 `Location' argument, we don't need it anywhere. Use
18212 `IMethodData.ShouldIgnore ()' instead of
18213 `MethodData.GetMethodFlags ()'.
18214 (TypeManager.AddMethod): Removed.
18215 (TypeManager.AddMethod2): Renamed to AddMethod.
18217 2004-05-29 Martin Baulig <martin@ximian.com>
18219 Committing a patch from Benjamin Jemlich <pcgod@gmx.net>.
18221 * convert.cs (Convert.ImplicitReferenceConversion): If we're
18222 converting from a class type S to an interface type and we already
18223 have an object on the stack, don't box it again. Fixes #52578.
18225 2004-05-29 Martin Baulig <martin@ximian.com>
18227 * class.cs (ConstructorInitializer.GetOverloadedConstructor):
18228 Added support for `params' parameters. Fixes #59267.
18230 2004-05-29 Martin Baulig <martin@ximian.com>
18232 * literal.cs (NullPointer): Provide a private .ctor which sets
18233 `type' to TypeManager.object_type. Fixes #59048.
18235 2004-05-29 Martin Baulig <martin@ximian.com>
18237 * expression.cs (MemberAccess.ResolveMemberAccess): If we're an
18238 EventExpr, set `ee.InstanceExpression = left'. Fixes #59188.
18240 * ecore.cs (EventExpr.instance_expr): Make the field private.
18242 2004-05-26 Marek Safar <marek.safar@seznam.cz>
18244 Fixed bug #50080 & cs0214-2.cs
18245 * expression.cs (Cast.DoResolve): Check unsafe context here.
18247 * statement.cs (Resolve.DoResolve): Likewise.
18249 2004-05-26 Martin Baulig <martin@ximian.com>
18251 * namespace.cs (NamespaceEntry.Lookup): Added `bool silent'.
18253 * rootcontext.cs (RootContext.NamespaceLookup): Added `bool silent'.
18254 (RootContext.LookupType): Pass down the `silent' flag.
18256 2004-05-25 Martin Baulig <martin@ximian.com>
18259 (MethodGroupExpr.IdenticalTypeName): New public property.
18260 (Invocation.DoResolve): Don't report a CS0176 if the "instance"
18261 expression actually refers to a type.
18263 2004-05-25 Martin Baulig <martin@ximian.com>
18265 * expression.cs (Invocation.DoResolve): Applied Ben Maurer's patch
18266 for #56176 and made it actually work.
18268 2004-05-25 Martin Baulig <martin@ximian.com>
18270 * ecore.cs (Expression.CacheTemporaries): Make this virtual.
18271 (FieldExpr, PropertyExpr): Override and implement
18272 CacheTemporaries. Fixes #52279.
18274 2004-05-25 Miguel de Icaza <miguel@ximian.com>
18276 * location.cs: In the new compiler listing a file twice is a
18277 warning, not an error.
18279 2004-05-24 Martin Baulig <martin@ximian.com>
18281 * enum.cs (Enum.DefineType): For the `BaseType' to be a
18282 TypeLookupExpression; otherwise, report a CS1008. Fixes #58571.
18284 2004-05-24 Martin Baulig <martin@ximian.com>
18286 * decl.cs (DeclSpace.FindType): Try doing an alias lookup before
18287 walking the `using' list. Fixes #53921.
18289 2004-05-24 Martin Baulig <martin@ximian.com>
18291 * const.cs (Const.LookupConstantValue): Added support for
18292 EmptyCast's; fixes #55251.
18294 2004-05-24 Martin Baulig <martin@ximian.com>
18296 * ecore.cs (SimpleName.SimpleNameResolve): Renamed to
18297 DoSimpleNameResolve() and provide a SimpleNameResolve() wrapper
18298 which does the CS0135 check. The reason is that we first need to
18299 check whether the variable actually exists.
18301 2004-05-24 Martin Baulig <martin@ximian.com>
18303 * class.cs (MemberBase.DoDefine): Use DeclSpace.FindType() rather
18304 than RootContext.LookupType() to find the explicit interface
18305 type. Fixes #58584.
18307 2004-05-24 Raja R Harinath <rharinath@novell.com>
18309 * Makefile: Simplify. Use executable.make.
18310 * mcs.exe.sources: New file. List of sources of mcs.exe.
18312 2004-05-24 Anders Carlsson <andersca@gnome.org>
18316 Use the invariant culture when doing String.Compare for CLS case
18319 2004-05-23 Martin Baulig <martin@ximian.com>
18321 * decl.cs (DeclSpace.FindType): Only check the `using' list if we
18322 don't have any dots. Fixes #52622, added cs0246-8.cs.
18324 * namespace.cs (NamespaceEntry.Lookup): Likewise.
18326 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18328 * class.cs (MemberBase.Define): Reuse MemberType member for
18329 resolved type. Other methods can use it too.
18331 2004-05-23 Martin Baulig <martin@ximian.com>
18333 * ecore.cs (SimpleName.SimpleNameResolve): Only report a CS0135 if
18334 the variable also exists in the current block (otherwise, we need
18335 to report a CS0103). Fixes #58670.
18337 2004-05-23 Martin Baulig <martin@ximian.com>
18339 * flowanalysis.cs (Reachability.Reachable): Compute this
18340 on-the-fly rather than storing it as a field.
18342 2004-05-23 Martin Baulig <martin@ximian.com>
18344 * flowanalysis.cs (Reachability.And): Manually compute the
18345 resulting `barrier' from the reachability.
18347 2004-05-23 Marek Safar <marek.safar@seznam.cz>
18350 * attribute.cs (AttributeTester.GetMethodObsoleteAttribute): Returns
18351 instance of ObsoleteAttribute when symbol is obsolete.
18354 (IMethodData): Extended interface for ObsoleteAttribute support.
18356 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18358 * attribute.cs: Fix bug #55970
18360 2004-05-22 Marek Safar <marek.safar@seznam.cz>
18364 (GetObsoleteAttribute): New method. Creates the instance of
18366 (AttributeTester.GetMemberObsoleteAttribute): Returns instance of
18367 ObsoleteAttribute when member is obsolete.
18368 (AttributeTester.Report_ObsoleteMessage): Common method for
18369 Obsolete error/warning reporting.
18372 (TypeContainer.base_classs_type): New member for storing parent type.
18375 (MemberCore.GetObsoleteAttribute): Returns instance of ObsoleteAttribute
18376 for this MemberCore.
18378 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18380 * attribute.cs, const.cs: Fix bug #58590
18382 2004-05-21 Martin Baulig <martin@ximian.com>
18384 * flowanalysis.cs (FlowBranching.MergeTopBlock): Don't check for
18385 out parameters if the end of the method is unreachable. Fixes
18388 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18390 * codegen.cs, cs-parser.jay: Removed SetAttributes method.
18391 Hari was right, why extra method.
18393 2004-05-21 Marek Safar <marek.safar@seznam.cz>
18395 * attribute.cs, cs-parser.jay: Fix errors/cs0579-7.cs.
18397 2004-05-20 Martin Baulig <martin@ximian.com>
18399 Merged this back from gmcs to keep the differences to a minumum.
18401 * attribute.cs (Attribute.CheckAttributeType): Take an EmitContext
18402 instead of a Declspace.
18403 (Attribute.ResolveType): Likewise.
18404 (Attributes.Search): Likewise.
18405 (Attributes.Contains): Likewise.
18406 (Attributes.GetClsCompliantAttribute): Likewise.
18408 * class.cs (TypeContainer.VerifyMembers): Added EmitContext
18410 (MethodData.ApplyAttributes): Take an EmitContext instead of a
18413 2004-05-19 Marek Safar <marek.safar@seznam.cz>
18415 Fix bug #58688 (MCS does not report error when the same attribute
18418 * attribute.cs (Attribute.Emit): Distinction between null and default.
18420 2004-05-19 Raja R Harinath <rharinath@novell.com>
18422 * cs-parser.jay (attribute): Create a GlobalAttribute for the case
18423 of a top-level attribute without an attribute target.
18424 * attribute.cs (Attribute.Error_AttributeConstructorMismatch):
18426 (Attribute.Conditional_GetConditionName),
18427 (Attribute.Obsolete_GetObsoleteMessage): Update.
18428 (Attribute.IndexerName_GetIndexerName): New. Attribute-specific
18429 part of ScanForIndexerName.
18430 (Attribute.CanIgnoreInvalidAttribute): New function.
18431 (Attribute.ScanForIndexerName): Move to ...
18432 (Attributes.ScanForIndexerName): ... here.
18433 (Attributes.Attrs): Rename from now-misnamed AttributeSections.
18434 (Attributes.Search): New internal variant that can choose not to
18435 complain if types aren't resolved. The original signature now
18437 (Attributes.GetClsCompliantAttribute): Use internal variant, with
18438 complaints suppressed.
18439 (GlobalAttribute.CheckAttributeType): Overwrite ds.NamespaceEntry
18440 only if it not useful.
18441 (CanIgnoreInvalidAttribute): Ignore assembly attribute errors at
18442 top-level for attributes that are shared between the assembly
18443 and a top-level class.
18444 * parameter.cs (ImplicitParameter): Rename from ParameterAtribute.
18445 * class.cs: Update to reflect changes.
18446 (DefineIndexers): Fuse loops.
18447 * codegen.cs (GetAssemblyName): Update to reflect changes. Accept
18448 a couple more variants of attribute names.
18450 2004-05-18 Marek Safar <marek.safar@seznam.cz>
18452 Fix bug #52585 (Implemented explicit attribute declaration)
18455 (Attributable.ValidAttributeTargets): New abstract method. It gets
18456 list of valid attribute targets for explicit target declaration.
18457 (Attribute.Target): It holds target itself.
18458 (AttributeSection): Removed.
18459 (Attribute.CheckTargets): New method. It checks whether attribute
18460 target is valid for the current element.
18463 (EventProperty): New class. For events that are declared like
18464 property (with add and remove accessors).
18465 (EventField): New class. For events that are declared like field.
18468 * cs-parser.jay: Implemented explicit attribute target declaration.
18470 * class.cs, decl.cs, delegate.cs, enum.cs, parameter.cs:
18471 Override ValidAttributeTargets.
18474 (ReturnParameter): Class for applying custom attributes on
18476 (ParameterAtribute): New class. Class for applying custom
18477 attributes on the parameter type.
18479 2004-05-17 Miguel de Icaza <miguel@ximian.com>
18481 * class.cs (MemberBase.DoDefine): Pass UNSAFE on interface
18484 (Method): Allow UNSAFE here.
18486 * modifiers.cs: Support unsafe reporting.
18488 2004-05-17 Marek Safar <marek.safar@seznam.cz>
18490 * decl.cs: Fix bug #58478.
18492 2004-05-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18494 * statement.cs: When checking for unreachable code on an EmptyStatement,
18495 set the location. Fixes bug #58488.
18497 2004-05-13 Miguel de Icaza <miguel@ximian.com>
18499 * driver.cs: Add -pkg handling.
18501 From Gonzalo: UseShelLExecute=false
18503 2004-05-12 Marek Safar <marek.safar@seznam.cz>
18506 (Attribute.GetAttributeTargets): New method. Gets AttributeTargets
18508 (Attribute.IsClsCompliaceRequired): Moved to base for better
18510 (Attribute.UsageAttribute): New property for AttributeUsageAttribute
18511 when attribute is AttributeUsageAttribute.
18512 (Attribute.GetValidTargets): Simplified.
18513 (Attribute.GetAttributeUsage): New method returns AttributeUsage
18514 attribute for this type.
18515 (Attribute.ApplyAttributes): Method renamed to Emit and make
18517 (GlobalAttributeSection): New class for special handling of global
18518 attributes (assembly, module).
18519 (AttributeSection.Emit): New method.
18521 * class.cs: Implemented Attributable abstract methods.
18522 (MethodCore.LabelParameters): Moved to Parameter class.
18523 (Accessor): Is back simple class.
18524 (PropertyMethod): Implemented Attributable abstract class.
18525 (DelegateMethod): Implemented Attributable abstract class.
18526 (Event): New constructor for disctintion between normal Event
18527 and Event with accessors.
18529 * cs-parser.jay: Used new Event ctor and GlobalAttributeSection.
18531 * codegen.cs, const.cs, decl.cs, delegate.cs:
18532 (CommonAssemblyModulClass): Implemented Attributable abstract class
18535 * enum.cs: Implement IAttributeSupport interface.
18536 (EnumMember): New class for emum members. Implemented Attributable
18540 (ParameterBase): Is abstract.
18541 (ReturnParameter): New class for easier [return:] attribute handling.
18543 * typemanager.cs: Removed builder_to_attr.
18545 2004-05-11 Raja R Harinath <rharinath@novell.com>
18548 * attribute.cs (Attribute.GetPositionalValue): New function.
18549 * class.cs (TypeContainer.VerifyMembers): New function.
18550 (TypeContainer.Emit): Use it.
18551 (ClassOrStruct): New base class for Class and Struct.
18552 (ClassOrStruct.ApplyAttributeBuilder): New function. Note if
18553 StructLayout(LayoutKind.Explicit) was ascribed to the struct or
18555 (ClassOrStruct.VerifyMembers): If the struct is explicitly laid out,
18556 then each non-static field should have a FieldOffset attribute.
18557 Otherwise, none of the fields should have a FieldOffset attribute.
18558 * rootcontext.cs (RootContext.ResolveCore): Resolve StructLayout
18559 and FieldOffset attributes.
18560 * typemanager.cs (TypeManager.struct_layout_attribute_type)
18561 (TypeManager.field_offset_attribute_type): New core types.
18562 (TypeManager.InitCoreTypes): Initialize them.
18564 2004-05-11 Michal Moskal <malekith@pld-linux.org>
18566 * class.cs (Event.RemoveDelegateMethod.DelegateMethodInfo):
18567 Return correct type.
18570 2004-05-09 Miguel de Icaza <miguel@ximian.com>
18572 * expression.cs (Binary.DoNumericPromotions): 0 long constant can
18573 be implicitly converted to ulong.
18575 * expression.cs: The logic for allowing operator &, | and ^ worked
18576 was wrong, it worked before because we did not report an error in
18577 an else branch. Fixes 57895.
18579 * class.cs: Applied patch from iain@mccoy.id.au Iain McCoy to
18580 allow volatile fields to be reference types.
18582 2004-05-07 Miguel de Icaza <miguel@ximian.com>
18584 * driver.cs: Add support for /debug-
18586 2004-05-07 Raja R Harinath <rharinath@novell.com>
18588 * attribute.cs (Attribute.CheckAttributeType, Attribute.ResolveType):
18589 Add a 'complain' parameter to silence errors.
18590 (Attribute.Resolve): Update to changes. Put in sanity check to catch
18591 silently overlooked type-resolutions.
18592 (Attribute.ScanForIndexerName, Attribute.DefinePInvokeMethod): Update
18593 to reflect changes.
18594 (Attributes.Search): New function.
18595 (Attributes.Contains, Attributes.GetClsCompliantAttribute): Use Search.
18596 (Attributes.GetAttributeFullName): Remove hack.
18597 * class.cs (MethodCore.LabelParameters, MethodData.ApplyAttributes):
18598 Update to reflect changes.
18599 * codegen.cs (CommonAssemblyModulClass.GetClsCompliantAttribute):
18600 Use Attributes.Search instead of nested loops.
18602 2004-05-07 Marek Safar <marek.safar@seznam.cz>
18605 (MemberCore.Flags): Extended for caching presence of CLSCompliantAttribute.
18606 (MemberCore.VerifyClsCompliance): Implemented CS3019 error report.
18607 (DeclSpace.GetClsCompliantAttributeValue): Returns simple bool.
18609 * report.cs: (Report.Warning): Renamed to Warning_T because of
18610 parameter collision.
18612 2004-05-05 Raja R Harinath <rharinath@novell.com>
18614 * expression.cs (MemberAccess.ResolveMemberAccess):
18615 Exit with non-zero status after Report.Error.
18616 * rootcontext.cs (RootContext.BootstrapCorlib_ResolveDelegate):
18618 * typemanager.cs (TypeManager.CoreLookupType): Likewise.
18620 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18622 * support.cs: Don't hang when the file is empty.
18624 2004-05-04 Lluis Sanchez Gual <lluis@ximian.com>
18626 * support.cs: In SeekableStreamReader, compute the preamble size of the
18627 underlying stream. Position changes should take into account that initial
18630 2004-05-03 Todd Berman <tberman@sevenl.net>
18632 * driver.cs: remove unused GetSysVersion function.
18634 2004-05-03 Todd Berman <tberman@sevenl.net>
18636 * driver.cs: Remove the hack from saturday, as well as the hack
18637 from jackson (LoadAssemblyFromGac), also adds the CWD to the
18638 link_paths to get that bit proper.
18640 2004-05-01 Todd Berman <tberman@sevenl.net>
18642 * driver.cs: Try a LoadFrom before a Load, this checks the current
18643 path. This is currently a bug in mono that is be fixed, however, this
18644 provides a workaround for now. This will be removed when the bug
18647 2004-05-01 Sebastien Pouliot <sebastien@ximian.com>
18649 * CryptoConvert.cs: Updated to latest version. Fix issue with
18650 incomplete key pairs (#57941).
18652 2004-05-01 Todd Berman <tberman@sevenl.net>
18654 * driver.cs: Remove '.' from path_chars, now System.* loads properly
18657 2004-04-30 Jackson Harper <jackson@ximian.com>
18659 * codegen.cs: Open keys readonly.
18661 2004-04-30 Gonzalo Paniagua Javier <gonzalo@ximian.com>
18663 * typemanager.cs: don't report cyclic struct layout when a struct
18664 contains 2 or more fields of the same type. Failed for Pango.AttrShape
18665 which has 2 Pango.Rectangle fields.
18667 2004-04-29 Ben Maurer <bmaurer@users.sourceforge.net>
18669 * expression.cs: Handle IntPtr comparisons with IL code
18670 rather than a method call.
18672 2004-04-29 Martin Baulig <martin@ximian.com>
18674 * ecore.cs (PropertyExpr.FindAccessor): New private method. Walk
18675 the list of PropertyInfo's in class hierarchy and find the
18676 accessor. Fixes #56013.
18678 2004-04-29 Martin Baulig <martin@ximian.com>
18680 * typemanager.cs (TypeManager.CheckStructCycles): Fixed.
18682 2004-04-29 Martin Baulig <martin@ximian.com>
18684 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18686 * ecore.cs (FieldExpr.AddressOf): Make this work for valuetypes.
18688 2004-04-29 Martin Baulig <martin@ximian.com>
18690 * class.cs (ConstructorInitializer.Resolve): Check whether the
18691 parent .ctor is accessible. Fixes #52146.
18693 2004-04-29 Martin Baulig <martin@ximian.com>
18695 Applying a patch from Benjamin Jemlich <pcgod@gmx.net>.
18697 * statement.cs (Using.EmitLocalVariableDecls): Use
18698 TypeManager.idisposable_type, not typeof (IDisposable).
18699 (Foreach.EmitCollectionForeach): Added support for valuetypes.
18701 2004-04-29 Martin Baulig <martin@ximian.com>
18703 * class.cs (Event.Define): Don't emit the field and don't set
18704 RTSpecialName and SpecialName for events on interfaces. Fixes
18707 2004-04-29 Raja R Harinath <rharinath@novell.com>
18709 Refactor Attribute.ApplyAttributes.
18710 * attribute.cs (Attributable): New base class for objects that can
18711 have Attributes applied on them.
18712 (Attribute): Make AttributeUsage fields public.
18713 (Attribute.GetFieldValue, Attribute.GetMarshal): Make non-static.
18714 (Attribute.IsInternalCall): New property.
18715 (Attribute.UsageAttr): Convert to a public read-only property.
18716 (Attribute.CheckAttributeType): Use a DeclSpace, not an EmitContext.
18717 (Attribute.ResolveType, Attribute.Resolve)
18718 (Attribute.ScanForIndexerName): Update to reflect changes.
18719 (Attribute.CheckAttributeTarget): Re-format.
18720 (Attribute.ApplyAttributes): Refactor, to various
18721 Attributable.ApplyAttributeBuilder methods.
18722 * decl.cs (MemberCore): Make Attributable.
18723 * class.cs (Accessor): Make Attributable.
18724 (MethodData.ApplyAttributes): Use proper attribute types, not
18726 (TypeContainer.LabelParameters): Pass Parameter to ApplyAttributes.
18727 (TypeContainer.ApplyAttributeBuilder)
18728 (Method.ApplyAttributeBuilder, Constructor.ApplyAttributeBuilder)
18729 (Field.ApplyAttributeBuilder, Accessor.ApplyAttributeBuilder)
18730 (PropertyBase.ApplyAttributeBuilder, Event.ApplyAttributeBuilder)
18731 (Operator.ApplyAttributeBuilder): New factored-out methods.
18732 * const.cs (Const.ApplyAttributeBuilder): Likewise.
18733 * delegate.cs (Delegate.ApplyAttributeBuilder): Likewise.
18734 * enum.cs (Enum.ApplyAttributeBuilder): Likewise.
18735 * parameter.cs (ParameterBase): New Attributable base class
18736 that can also represent Return types.
18737 (Parameter): Update to the changes.
18739 2004-04-29 Jackson Harper <jackson@ximian.com>
18741 * driver.cs: Prefer the corlib system version when looking for
18742 assemblies in the GAC. This is still a hack, but its a better hack
18745 2004-04-29 Marek Safar <marek.safar@seznam.cz>
18747 * decl.cs, enum.cs: Improved error 3005 reporting.
18749 * report.cs (SymbolRelatedToPreviousError): New method for error reporting.
18750 (related_symbols): New private member for list of symbols
18751 related to reported error/warning.
18753 * tree.cs: Do not use now obsolete Report.LocationOfPreviousError.
18755 2004-04-29 Martin Baulig <martin@ximian.com>
18757 * ecore.cs (Expression.Constantify): If we're an enum and
18758 TypeManager.TypeToCoreType() doesn't give us another type, use
18759 t.UnderlyingSystemType. Fixes #56178.
18761 2004-04-29 Martin Baulig <martin@ximian.com>
18763 * decl.cs (MemberCache.SetupCacheForInterface): Look over all our
18764 interfaces and for each interface, only add members directly
18765 declared in that interface. Fixes #53255.
18767 2004-04-28 Martin Baulig <martin@ximian.com>
18769 * expression.cs (ConditionalLogicalOperator): Use a temporary
18770 variable for `left' to avoid that we evaluate it more than once;
18773 2004-04-28 Martin Baulig <martin@ximian.com>
18775 * expression.cs (ComposedCast.DoResolveAsTypeStep): Don't allow
18778 2004-04-28 Martin Baulig <martin@ximian.com>
18780 * statement.cs (LocalInfo.Resolve): Check whether the type is not
18783 * class.cs (MemberBase.CheckParameters, FieldBase.DoDefine): Check
18784 whether the type is not void (CS1547).
18786 2004-04-28 Martin Baulig <martin@ximian.com>
18788 * expression.cs (Unary.DoResolveLValue): Override this and report
18789 CS0131 for anything but Operator.Indirection.
18791 2004-04-28 Martin Baulig <martin@ximian.com>
18793 Committing a patch from Ben Maurer; see bug #50820.
18795 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18798 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18801 2004-04-28 Martin Baulig <martin@ximian.com>
18803 Committing a patch from Ben Maurer; see bug #50820.
18805 * typemanager.cs (TypeManager.FilterWithClosure): Added CS1540
18808 * ecore.cs (Expression.MemberLookupFailed): Added CS1540 check for
18811 2004-04-28 Martin Baulig <martin@ximian.com>
18813 * statement.cs (Block.LookupLabel): Also lookup in implicit child blocks.
18814 (Block.AddLabel): Call DoLookupLabel() to only search in the
18817 2004-04-28 Martin Baulig <martin@ximian.com>
18819 * cfold.cs (ConstantFold.BinaryFold): Added special support for
18820 comparing StringConstants and NullLiterals in Equality and Inequality.
18822 2004-04-28 Jackson Harper <jackson@ximian.com>
18824 * driver.cs: Attempt to load referenced assemblies from the
18825 GAC. This is the quick and dirty version of this method that
18826 doesnt take into account versions and just takes the first
18827 canidate found. Will be good enough for now as we will not have more
18828 then one version installed into the GAC until I update this method.
18830 2004-04-28 Martin Baulig <martin@ximian.com>
18832 * typemanager.cs (TypeManager.CheckStructCycles): New public
18833 static method to check for cycles in the struct layout.
18835 * rootcontext.cs (RootContext.PopulateTypes): Call
18836 TypeManager.CheckStructCycles() for each TypeContainer.
18837 [Note: We only need to visit each type once.]
18839 2004-04-28 Martin Baulig <martin@ximian.com>
18841 * constant.cs (StringConstant.Emit): Emit Ldnull if we're null.
18843 * const.cs (Const.LookupConstantValue): Return a `bool' signalling
18844 success and added `out object value'. Use a `bool resolved' field
18845 to check whether we've already been called rather than
18846 `ConstantValue != null' since this breaks for NullLiterals.
18848 2004-04-28 Raja R Harinath <rharinath@novell.com>
18850 * driver.cs (Driver.MainDriver) [IsModuleOnly]: Open code the
18851 setting of this flag, since the 'set' method may be non-public.
18853 2004-04-28 Raja R Harinath <rharinath@novell.com>
18855 * flowanalysis.cs (FlowBranchingException.LookupLabel): Add a null
18856 check on current_vector.Block.
18858 2004-04-27 Martin Baulig <martin@ximian.com>
18860 * expression.cs (BaseAccess.CommonResolve): Don't allow `base' in
18861 a field initializer. Fixes #56459.
18863 2004-04-27 Martin Baulig <martin@ximian.com>
18865 * ecore.cs (PropertyExpr.DoResolve/DoResolveLValue): Check whether
18866 we're not attempting to use an indexer. Fixes #52154.
18868 2004-04-27 Martin Baulig <martin@ximian.com>
18870 * statement.cs (Return): Don't create a return label if we don't
18871 need it; reverts my change from January 20th. Thanks to Ben
18874 2004-04-27 Martin Baulig <martin@ximian.com>
18876 According to the spec, `goto' can only leave a nested scope, but
18879 * statement.cs (Block.LookupLabel): Only lookup in the current
18880 block, don't recurse into parent or child blocks.
18881 (Block.AddLabel): Check in parent and child blocks, report
18882 CS0140/CS0158 if we find a duplicate.
18883 (Block): Removed this indexer for label lookups.
18884 (Goto.Resolve): Call LookupLabel() on our current FlowBranching;
18885 this already does the error reporting for us.
18888 (FlowBranching.UsageVector.Block): New public variable; may be null.
18889 (FlowBranching.CreateSibling): Added `Block' argument.
18890 (FlowBranching.LookupLabel): New public virtual method. Lookup a
18891 label for the target of a `goto' and check whether we're not
18892 leaving a `finally'.
18894 2004-04-27 Martin Baulig <martin@ximian.com>
18896 * flowanalysis.cs (FlowBranching.UsageVector.MergeChild): If we're
18897 a finite loop block, also do the ALWAYS->SOMETIMES for throws (not
18900 2004-04-27 Martin Baulig <martin@ximian.com>
18902 * statement.cs (Block.AddLabel): Also check for implicit blocks
18903 and added a CS0158 check.
18905 2004-04-27 Martin Baulig <martin@ximian.com>
18907 * flowanalysis.cs (FlowBranchingLoop): New class.
18908 (FlowBranching.UsageVector.MergeJumpOrigins): Take a list of
18909 UsageVector's instead of an ArrayList.
18910 (FlowBranching.Label): Likewise.
18911 (FlowBranching.UsageVector.MergeBreakOrigins): New method.
18912 (FlowBranching.AddBreakVector): New method.
18914 2004-04-27 Miguel de Icaza <miguel@ximian.com>
18916 * attribute.cs: Small regression fix: only convert the type if we
18917 the type is different, fixes System.Drawing build.
18919 2004-04-27 Martin Baulig <martin@ximian.com>
18921 * attribute.cs (Attribute.Resolve): If we have a constant value
18922 for a named field or property, implicity convert it to the correct
18925 2004-04-27 Raja R Harinath <rharinath@novell.com>
18927 * statement.cs (Block.Block): Implicit blocks share
18928 'child_variable_names' fields with parent blocks.
18929 (Block.AddChildVariableNames): Remove.
18930 (Block.AddVariable): Mark variable as "used by a child block" in
18931 every surrounding block.
18932 * ecore.cs (SimpleName.SimpleNameResolve): If the name has already
18933 been used in a child block, complain about violation of "Invariant
18934 meaning in blocks" rule.
18935 * cs-parser.jay (declare_local_variables): Don't use
18936 AddChildVariableNames.
18937 (foreach_statement): Don't create an implicit block: 'foreach'
18938 introduces a scope.
18940 2004-04-23 Miguel de Icaza <miguel@ximian.com>
18942 * convert.cs (ImplicitNumericConversion): 0 is also positive when
18943 converting from 0L to ulong. Fixes 57522.
18945 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18947 * decl.cs (FindMemberToOverride): Fix wrong warning for case when
18948 derived class hides via 'new' keyword field from base class (test-242.cs).
18949 TODO: Handle this in the more general way.
18951 * class.cs (CheckBase): Ditto.
18953 2004-04-22 Marek Safar <marek.safar@seznam.cz>
18955 * decl.cs (caching_flags): New member for storing cached values
18957 (MemberCore.Flags): New enum where bit flags for caching_flags
18959 (MemberCore.cls_compliance): Moved to caching_flags.
18960 (DeclSpace.Created): Moved to caching_flags.
18962 * class.cs: Use caching_flags instead of DeclSpace.Created
18964 2004-04-21 Miguel de Icaza <miguel@ximian.com>
18966 * ecore.cs (PropertyExpr.GetAccesor): Only perform the 1540 check
18967 if we are only a derived class, not a nested class.
18969 * typemanager.cs: Same as above, but do this at the MemberLookup
18970 level (used by field and methods, properties are handled in
18971 PropertyExpr). Allow for the qualified access if we are a nested
18974 2004-04-21 Marek Safar <marek.safar@seznam.cz>
18976 * class.cs: Refactoring.
18977 (IMethodData): New inteface; Holds links to parent members
18978 to avoid member duplication (reduced memory allocation).
18979 (Method): Implemented IMethodData interface.
18980 (PropertyBase): New inner classes for get/set methods.
18981 (PropertyBase.PropertyMethod): Implemented IMethodData interface
18982 (Event): New inner classes for add/remove methods.
18983 (Event.DelegateMethod): Implemented IMethodData interface.
18985 * cs-parser.jay: Pass DeclSpace to Event class for creation of valid
18986 EmitContext (related to class.cs refactoring).
18988 2004-04-21 Raja R Harinath <rharinath@novell.com>
18990 * delegate.cs (Delegate.VerifyApplicability): If the number of
18991 arguments are the same as the number of parameters, first try to
18992 verify applicability ignoring any 'params' modifier on the last
18996 2004-04-16 Raja R Harinath <rharinath@novell.com>
18998 * class.cs (TypeContainer.AddIndexer): Use
18999 'ExplicitInterfaceName' to determine if interface name was
19000 explicitly specified. 'InterfaceType' is not initialized at this time.
19001 (TypeContainer.DefineIndexers): Remove use of temporary list. The
19002 Indexers array is already in the required order. Initialize
19003 'IndexerName' only if there are normal indexers.
19004 (TypeContainer.DoDefineMembers): Don't initialize IndexerName.
19005 (TypeContainer.Emit): Emit DefaultMember attribute only if
19006 IndexerName is initialized.
19009 2004-04-15 Benjamin Jemlich <pcgod@gmx.net>
19011 * enum.cs (Enum.DefineType): Don't allow char as type for enum.
19014 2004-04-15 Raja R Harinath <rharinath@novell.com>
19016 * attribute.cs (Attribute.CheckAttributeType): Check for ambiguous
19020 * attribute.cs (Attribute.Resolve): Check for duplicate named
19024 2004-04-15 Miguel de Icaza <miguel@ximian.com>
19026 * iterators.cs (MarkYield): track whether we are in an exception,
19027 and generate code accordingly. Use a temporary value to store the
19028 result for our state.
19030 I had ignored a bit the interaction of try/catch with iterators
19031 since their behavior was not entirely obvious, but now it is
19032 possible to verify that our behavior is the same as MS .NET 2.0
19036 2004-04-14 Miguel de Icaza <miguel@ximian.com>
19038 * iterators.cs: Avoid creating temporaries if there is no work to
19041 * expression.cs (ArrayAccess.EmitLoadOpcode): If dealing with
19042 Enumerations, use TypeManager.EnumToUnderlying and call
19045 Based on the patch from Benjamin Jemlich (pcgod@gmx.net), fixes
19048 (This.Emit): Use EmitContext.EmitThis to emit our
19051 (This.EmitAssign): Ditto.
19053 * ecore.cs (FieldExpr.Emit): Remove RemapToProxy special
19054 codepaths, we will move all the functionality into
19057 (FieldExpr.EmitAssign): Ditto.
19059 This fixes several hidden bugs that I uncovered while doing a code
19060 review of this today.
19062 * codegen.cs (EmitThis): reworked so the semantics are more clear
19063 and also support value types "this" instances.
19065 * iterators.cs: Changed so that for iterators in value types, we
19066 do not pass the value type as a parameter.
19068 Initialization of the enumerator helpers is now done in the caller
19069 instead of passing the parameters to the constructors and having
19070 the constructor set the fields.
19072 The fields have now `assembly' visibility instead of private.
19074 2004-04-11 Miguel de Icaza <miguel@ximian.com>
19076 * expression.cs (Argument.Resolve): Check if fields passed as ref
19077 or out are contained in a MarshalByRefObject.
19079 * typemanager.cs, rootcontext.cs: Add System.Marshalbyrefobject as
19080 another compiler type.
19082 2004-04-06 Ben Maurer <bmaurer@users.sourceforge.net>
19084 * class.cs (Indexer.Define): use the new name checking method.
19085 Also, return false on an error.
19086 * cs-tokenizer.cs (IsValidIdentifier): Checks for a valid identifier.
19087 (is_identifier_[start/part]_character): make static.
19089 2004-04-10 Miguel de Icaza <miguel@ximian.com>
19091 * expression.cs (Binary.ResolveOperator): Do no append strings
19092 twice: since we can be invoked more than once (array evaluation)
19093 on the same concatenation, take care of this here. Based on a fix
19094 from Ben (bug #56454)
19096 2004-04-08 Sebastien Pouliot <sebastien@ximian.com>
19098 * codegen.cs: Fix another case where CS1548 must be reported (when
19099 delay-sign isn't specified and no private is available #56564). Fix
19100 loading the ECMA "key" to delay-sign an assembly. Report a CS1548
19101 error when MCS is used on the MS runtime and we need to delay-sign
19102 (which seems unsupported by AssemblyBuilder - see #56621).
19104 2004-04-08 Marek Safar <marek.safar@seznam.cz>
19106 * typemanager.cs (TypeManager.TypeToCoreType): Handle IntPtr too.
19107 (TypeManager.ComputeNamespaces): Faster implementation for
19110 * compiler.csproj: Updated AssemblyName to mcs.
19112 2004-04-07 Miguel de Icaza <miguel@ximian.com>
19114 * rootcontext.cs: Add new types to the boot resolution.
19116 * ecore.cs (TypeExpr.CanInheritFrom): Inheriting from
19117 MulticastDelegate is not allowed.
19119 * typemanager.cs: Add new types to lookup: System.TypedReference
19122 * paramter.cs (Parameter.Resolve): if we are an out/ref parameter,
19123 check for TypedReference or ArgIterator, they are not allowed.
19125 * ecore.cs (BoxedCast): Set the eclass to ExprClass.Value, this
19126 makes us properly catch 1510 in some conditions (see bug 56016 for
19129 2004-04-06 Bernie Solomon <bernard@ugsolutions.com>
19131 * CryptoConvert.cs: update from corlib version
19134 2004-04-05 Miguel de Icaza <miguel@ximian.com>
19136 * class.cs (Indexer.Define): Check indexername declaration
19138 2004-04-05 Marek Safar <marek.safar@seznam.cz>
19140 * attribute.cs (IsClsCompliant): Fixed problem with handling
19141 all three states (compliant, not-compliant, undetected).
19143 2004-03-30 Marek Safar <marek.safar@seznam.cz>
19145 * attribute.cs (Attribute): Location is now public.
19146 (Resolve): Store resolved arguments (pos_values) in attribute class.
19147 Attribute extractors (now GetClsCompliantAttributeValue) can reuse them.
19148 (GetClsCompliantAttributeValue): New method that gets
19149 CLSCompliantAttribute value.
19150 (GetClsCompliantAttribute): Returns CLSCompliantAttribute for DeclSpace
19151 if exists else null.
19152 (AttributeTester): New class for CLS-Compliant verification routines.
19154 * class.cs (Emit): Add CLS-Compliant verification.
19155 (Method.GetSignatureForError): Implemented.
19156 (Constructor.GetSignatureForError): Implemented
19157 (Constructor.HasCompliantArgs): Returns if constructor has
19158 CLS-Compliant arguments.
19159 (Constructor.Emit): Override.
19160 (Construcor.IsIdentifierClsCompliant): New method; For constructors
19161 is needed to test only parameters.
19162 (FieldBase.GetSignatureForError): Implemented.
19163 (TypeContainer): New member for storing base interfaces.
19164 (TypeContainer.FindMembers): Search in base interfaces too.
19166 * codegen.cs (GetClsComplianceAttribute): New method that gets
19167 assembly or module CLSCompliantAttribute value.
19168 (ResolveClsCompliance): New method that resolve CLSCompliantAttribute
19170 (ModuleClass.Emit): Add error 3012 test.
19172 * const.cs (Emit): Override and call base for CLS-Compliant tests.
19174 * decl.cs (ClsComplianceValue): New enum that holds CLS-Compliant
19175 state for all decl types.
19176 (MemberCore.Emit): Emit is now virtual and call VerifyClsCompliance
19177 if CLS-Compliant tests are required.
19178 (IsClsCompliaceRequired): New method. Analyze whether code
19179 must be CLS-Compliant.
19180 (IsExposedFromAssembly): New method. Returns true when MemberCore
19181 is exposed from assembly.
19182 (GetClsCompliantAttributeValue): New method. Resolve CLSCompliantAttribute
19183 value or gets cached value.
19184 (HasClsCompliantAttribute): New method. Returns true if MemberCore
19185 is explicitly marked with CLSCompliantAttribute.
19186 (IsIdentifierClsCompliant): New abstract method. This method is
19187 used to testing error 3005.
19188 (IsIdentifierAndParamClsCompliant): New method. Common helper method
19189 for identifier and parameters CLS-Compliant testing.
19190 (VerifyClsCompliance): New method. The main virtual method for
19191 CLS-Compliant verifications.
19192 (CheckAccessLevel): In one special case (System.Drawing) was TypeBuilder
19193 null. I don't know why is null (too many public members !).
19194 (GetClsCompliantAttributeValue). New method. Goes through class hierarchy
19195 and get value of first CLSCompliantAttribute that found.
19197 * delegate.cs (Emit): Override and call base for CLS-Compliant tests.
19198 (VerifyClsCompliance): Override and add extra tests.
19200 * driver.cs (CSCParseOption): New command line options (clscheck[+|-]).
19201 clscheck- disable CLS-Compliant verification event if assembly is has
19202 CLSCompliantAttribute(true).
19204 * enum.cs (Emit): Override and call base for CLS-Compliant tests.
19205 ApllyAttribute is now called in emit section as in the other cases.
19206 Possible future Emit integration.
19207 (IsIdentifierClsCompliant): New override.
19208 (VerifyClsCompliance): New override.
19209 (GetEnumeratorName): Returns full enum name.
19211 * parameter.cs (GetSignatureForError): Implemented.
19213 * report.cs (WarningData): New struct for Warning message information.
19214 (LocationOfPreviousError): New method.
19215 (Warning): New method. Reports warning based on the warning table.
19216 (Error_T): New method. Reports error based on the error table.
19218 * rootcontext.cs (EmitCode): Added new Emit(s) because CLS-Compliant
19219 verifications are done here.
19221 * tree.cs (RecordDecl): Used new LocationOfPreviousError method.
19223 * typemanager.cs (cls_compliant_attribute_type): New member thath holds
19224 CLSCompliantAttribute.
19225 (all_imported_types): New member holds all imported types from other
19227 (LoadAllImportedTypes): New method fills static table with exported types
19228 from all referenced assemblies.
19229 (Modules): New property returns all assembly modules.
19231 2004-03-30 Miguel de Icaza <miguel@ximian.com>
19233 * cs-parser.jay: Add a rule to catch wrong event syntax instead of
19234 throwing a parser error.
19236 * ecore.cs (PropertyExpr.GetAccessor): Apply patch from Patrik Reali
19237 which removes the hardcoded get_/set_ prefixes for properties, as
19238 IL allows for the properties to be named something else.
19242 * expression.cs: Do not override operand before we know if it is
19243 non-null. Fix 56207
19245 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19247 * typemanager.cs: support for pinned variables.
19249 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19251 * decl.cs, typemanager.cs: Avoid using an arraylist
19252 as a buffer if there is only one result set.
19254 2004-03-29 Ben Maurer <bmaurer@users.sourceforge.net>
19256 * expression.cs: Make sure you cant call a static method
19257 with an instance expression, bug #56174.
19259 2004-03-29 Miguel de Icaza <miguel@ximian.com>
19261 * class.cs (IsDuplicateImplementation): Improve error reporting to
19262 flag 663 (method only differs in parameter modifier).
19264 * cs-tokenizer.cs: Do not require whitespace when a ( or " will do
19265 in preprocessor directives.
19267 * location.cs (LookupFile): Allow for the empty path.
19269 * attribute.cs (DefinePInvokeMethod): Fix 56148; I would like a
19270 better approach for some of that patch, but its failing with the
19271 CharSet enumeration. For now try/catch will do.
19273 * typemanager.cs: Do not crash if a struct does not have fields.
19276 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19278 * expression.cs: cs0213, cant fix a fixed expression.
19281 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19283 * cs-parser.jay: detect invalid embeded statements gracefully.
19286 2004-03-28 Ben Maurer <bmaurer@users.sourceforge.net>
19288 * ecore.cs, typemanager.cs: Correct impl of cs1540 check.
19291 the invocation type may not be a subclass of the tye of the item/
19292 The type of the item must be a subclass of the invocation item.
19297 2004-03-25 Sebastien Pouliot <sebastien@ximian.com>
19299 * attribute.cs: Added methods to get a string and a bool from an
19300 attribute. Required to information from AssemblyKeyFileAttribute,
19301 AttributeKeyNameAttribute (string) and AssemblyDelaySign (bool).
19302 * codegen.cs: Modified AssemblyName creation to include support for
19303 strongnames. Catch additional exceptions to report them as CS1548.
19304 * compiler.csproj: Updated include CryptoConvert.cs.
19305 * compiler.csproj.user: Removed file - user specific configuration.
19306 * CryptoConvert.cs: New. A COPY of the class CryptoConvert from
19307 Mono.Security assembly. The original class is maintained and tested in
19308 /mcs/class/Mono.Security/Mono.Security.Cryptography/CryptoConvert.cs.
19309 * drivers.cs: Added support for /keyfile, /keycontainer and /delaysign
19310 like CSC 8.0 (C# v2) supports.
19311 * Makefile: Added CryptoConvert.cs to mcs sources.
19312 * rootcontext.cs: Added new options for strongnames.
19314 2004-03-24 Ben Maurer <bmaurer@users.sourceforge.net>
19316 * driver.cs: For --expect-error, report error code `2'
19317 if the program compiled with no errors, error code `1' if
19318 it compiled with an error other than the one expected.
19320 2004-03-24 Sebastien Pouliot <sebastien@ximian.com>
19322 * compiler.csproj: Updated for Visual Studio .NET 2003.
19323 * compiler.csproj.user: Updated for Visual Studio .NET 2003.
19324 * compiler.sln: Updated for Visual Studio .NET 2003.
19326 2004-03-24 Ravi Pratap M <ravi@ximian.com>
19328 * expression.cs: Fix bug #47234. We basically need to apply the
19329 rule that we prefer the conversion of null to a reference type
19330 when faced with a conversion to 'object' (csc behaviour).
19332 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19334 * statement.cs: Shorter form for foreach, eliminates
19335 a local variable. r=Martin.
19337 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19339 * constant.cs, ecore.cs, literal.cs: New prop IsZeroInteger that
19340 checks if we can use brtrue/brfalse to test for 0.
19341 * expression.cs: use the above in the test for using brtrue/brfalse.
19342 cleanup code a bit.
19344 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19346 * expression.cs: Rewrite string concat stuff. Benefits:
19348 - "a" + foo + "b" + "c" becomes "a" + foo + "bc"
19349 - "a" + foo + "b" + bar + "c" + baz ... uses concat (string []).
19350 rather than a concat chain.
19352 * typemanager.cs: Add lookups for more concat overloads.
19354 2004-03-23 Ben Maurer <bmaurer@users.sourceforge.net>
19356 * expression.cs: Emit shorter il code for array init.
19373 2004-03-22 Ben Maurer <bmaurer@users.sourceforge.net>
19375 * statement.cs: Before, two switch blocks would be merged if the
19376 total size of the blocks (end_item - begin_item + 1) was less than
19377 two times the combined sizes of the blocks.
19379 Now, it will only merge if after the merge at least half of the
19384 2004-03-20 Atsushi Enomoto <atsushi@ximian.com>
19386 * class.cs : csc build fix for GetMethods(). See bug #52503.
19388 2004-03-20 Ben Maurer <bmaurer@users.sourceforge.net>
19390 * expression.cs: Make sure fp comparisons work with NaN.
19391 This fixes bug #54303. Mig approved this patch a long
19392 time ago, but we were not able to test b/c the runtime
19395 2004-03-19 Miguel de Icaza <miguel@ximian.com>
19397 * ecore.cs (TypExpr.GetHashCode): implement this overload.
19399 2004-03-19 Martin Baulig <martin@ximian.com>
19401 * class.cs (MemberCore.IsDuplicateImplementation): Report the
19402 error here and not in our caller.
19404 2004-03-19 Martin Baulig <martin@ximian.com>
19406 * interface.cs: Completely killed this file.
19407 (Interface): We're now a TypeContainer and live in class.cs.
19409 * class.cs (TypeContainer.GetClassBases): Added `bool is_iface'
19410 argument; we're now also called for interfaces.
19411 (TypeContainer.DefineMembers): Allow this method being called
19413 (TypeContainer.GetMethods): New public method; formerly known as
19414 Interface.GetMethod(). This is used by PendingImplementation.
19415 (TypeContainer.EmitDefaultMemberAttr): Moved here from Interface;
19416 it's now private and non-static.
19417 (Interface): Moved this here; it's now implemented similar to
19419 (Method, Property, Event, Indexer): Added `bool is_interface'
19420 argument to their .ctor's.
19421 (MemberBase.IsInterface): New public field.
19423 * cs-parser.jay: Create normal Method, Property, Event, Indexer
19424 instances instead of InterfaceMethod, InterfaceProperty, etc.
19425 (opt_interface_base): Removed; we now use `opt_class_base' instead.
19426 (InterfaceAccessorInfo): Create `Get' and `Set' Accessor's.
19428 2004-03-19 Martin Baulig <martin@ximian.com>
19430 * class.cs (MethodCore.IsDuplicateImplementation): New private
19431 method which does the CS0111 checking.
19432 (Method.CheckBase, Constructor.CheckBase, PropertyBase.CheckBase):
19433 Use IsDuplicateImplementation().
19435 2004-03-17 Ben Maurer <bmaurer@users.sourceforge.net>
19437 * decl.cs (FindMemberToOverride): New method to find the correct
19438 method or property to override in the base class.
19440 - Make Method/Property use the above method to find the
19441 version in the base class.
19442 - Remove the InheritableMemberSignatureCompare as it is now
19445 This patch makes large code bases much faster to compile, as it is
19446 O(n) rather than O(n^2) to do this validation.
19448 Also, it fixes bug 52458 which is that nested classes are not
19449 taken into account when finding the base class member.
19451 Reviewed/Approved by Martin.
19453 2004-03-17 Marek Safar <marek.safar@seznam.cz>
19455 * interface.cs: In all interface classes removed redundant
19456 member initialization.
19458 2004-03-16 Martin Baulig <martin@ximian.com>
19460 * class.cs (TypeContainer.GetClassBases): Fix the CS0528 check.
19462 2004-03-15 Miguel de Icaza <miguel@ximian.com>
19464 * decl.cs (DefineTypeAndParents): New helper method to define a
19465 type's containers before the type itself is defined; This is a
19466 bug exposed by the recent changes to Windows.Forms when an
19467 implemented interface was defined inside a class that had not been
19470 * modifiers.cs (MethodAttr): All methods in C# are HideBySig.
19472 (Check): Loop correctly to report errors modifiers
19473 (UNSAFE was not in the loop, since it was the same as TOP).
19475 * interface.cs: Every interface member now takes a ModFlags,
19476 instead of a "is_new" bool, which we set on the base MemberCore.
19478 Every place where we called "UnsafeOk" in the interface, now we
19479 call the proper member (InterfaceMethod.UnsafeOK) instead to get
19480 the unsafe settings from the member declaration instead of the
19481 container interface.
19483 * cs-parser.jay (opt_new): Allow unsafe here per the spec.
19485 * pending.cs (TypeAndMethods): Add `get_indexer_name' and
19486 `set_indexer_name' to the pending bits (one per type).
19488 We fixed a bug today that was picking the wrong method to
19489 override, since for properties the existing InterfaceMethod code
19490 basically ignored the method name. Now we make sure that the
19491 method name is one of the valid indexer names.
19493 2004-03-14 Gustavo Giráldez <gustavo.giraldez@gmx.net>
19495 * support.cs (SeekableStreamReader): Keep track of stream byte
19496 positions and don't mix them with character offsets to the buffer.
19498 Patch from Gustavo Giráldez
19500 2004-03-15 Marek Safar <marek.safar@seznam.cz>
19502 * interface.cs (InterfaceSetGetBase): Removed double member
19503 initialization, base class does it as well.
19505 2004-03-13 Martin Baulig <martin@ximian.com>
19507 * class.cs: Reverted Miguel's latest commit; it makes mcs crash
19508 when compiling corlib.
19510 2004-03-13 Miguel de Icaza <miguel@ximian.com>
19512 * convert.cs (ExplicitConversion): We were reporting an error on
19513 certain conversions (object_type source to a value type, when the
19514 expression was `null') before we had a chance to pass it through
19515 the user defined conversions.
19517 * driver.cs: Replace / and \ in resource specifications to dots.
19520 * class.cs: Add check for duplicate operators. Fixes 52477
19522 2004-03-11 Miguel de Icaza <miguel@ximian.com>
19524 * statement.cs (Switch.SimpleSwitchEmit): Deal with default labels
19525 that are in the middle of the statements, not only at the end.
19528 * class.cs (TypeContainer.AddField): No longer set the
19529 `HaveStaticConstructor' flag, now we call it
19530 `UserDefineStaticConstructor' to diferentiate the slightly
19531 semantic difference.
19533 The situation is that we were not adding BeforeFieldInit (from
19534 Modifiers.TypeAttr) to classes that could have it.
19535 BeforeFieldInit should be set to classes that have no static
19540 http://www.yoda.arachsys.com/csharp/beforefieldinit.html
19542 And most importantly Zoltan's comment:
19544 http://bugzilla.ximian.com/show_bug.cgi?id=44229
19546 "I think beforefieldinit means 'it's ok to initialize the type sometime
19547 before its static fields are used', i.e. initialization does not need
19548 to be triggered by the first access to the type. Setting this flag
19549 helps the JIT to compile better code, since it can run the static
19550 constructor at JIT time, and does not need to generate code to call it
19551 (possibly lots of times) at runtime. Unfortunately, mcs does not set
19552 this flag for lots of classes like String.
19554 csc sets this flag if the type does not have an explicit static
19555 constructor. The reasoning seems to be that if there are only static
19556 initalizers for a type, and no static constructor, then the programmer
19557 does not care when this initialization happens, so beforefieldinit
19560 This bug prevents the AOT compiler from being usable, since it
19561 generates so many calls to mono_runtime_class_init that the AOT code
19562 is much slower than the JITted code. The JITted code is faster,
19563 because it does not generate these calls if the vtable is type is
19564 already initialized, which is true in the majority of cases. But the
19565 AOT compiler can't do this."
19567 2004-03-10 Miguel de Icaza <miguel@ximian.com>
19569 * class.cs (MethodData.Emit): Refactor the code so symbolic
19570 information is generated for destructors; For some reasons we
19571 were taking a code path that did not generate symbolic information
19574 2004-03-11 Ben Maurer <bmaurer@users.sourceforge.net>
19576 * class.cs: Create a Constructor.CheckBase method that
19577 takes care of all validation type code. The method
19578 contains some code that was moved from Define.
19580 It also includes new code that checks for duplicate ctors.
19581 This fixes bug #55148.
19583 2004-03-09 Joshua Tauberer <tauberer@for.net>
19585 * expression.cs (ArrayCreation): Fix: More than 6 nulls in
19586 a { ... }-style array creation invokes EmitStaticInitializers
19587 which is not good for reference-type arrays. String, decimal
19588 and now null constants (NullCast) are not counted toward
19589 static initializers.
19591 2004-03-05 Martin Baulig <martin@ximian.com>
19593 * location.cs (SourceFile.HasLineDirective): New public field;
19594 specifies whether the file contains or is referenced by a "#line"
19596 (Location.DefineSymbolDocuments): Ignore source files which
19597 either contain or are referenced by a "#line" directive.
19599 2004-02-29 Ben Maurer <bmaurer@users.sourceforge.net>
19601 * class.cs (Method.CheckBase): Avoid using FindMembers, we have
19602 direct access to our parent, so check the method inline there.
19604 2004-02-27 Ben Maurer <bmaurer@users.sourceforge.net>
19606 * expression.cs (Invocation.EmitCall): Miguel's last commit
19607 caused a regression. If you had:
19612 In Foo the implict this would be null.
19614 2004-02-27 Miguel de Icaza <miguel@ximian.com>
19616 * expression.cs (Invocation.EmitCall): If the method is not
19617 virtual, do not emit a CallVirt to it, use Call.
19619 * typemanager.cs (GetFullNameSignature): Improve the method to
19620 cope with ".ctor" and replace it with the type name.
19622 * class.cs (ConstructorInitializer.Resolve): Now the method takes
19623 as an argument the ConstructorBuilder where it is being defined,
19624 to catch the recursive constructor invocations.
19626 2004-02-26 Miguel de Icaza <miguel@ximian.com>
19628 * iterators.cs (IteratorHandler.IsIEnumerator, IsIEnumerable): New
19629 routines to check if a type is an enumerable/enumerator allow
19630 classes that implement the IEnumerable or IEnumerator interfaces.
19632 * class.cs (Property, Operator): Implement IIteratorContainer, and
19633 implement SetYields.
19635 (Property.Define): Do the block swapping for get_methods in the
19636 context of iterators. We need to check if Properties also
19637 include indexers or not.
19639 (Operator): Assign the Block before invoking the
19640 OperatorMethod.Define, so we can trigger the Iterator code
19643 * cs-parser.jay (SimpleIteratorContainer): new helper class. Both
19644 Property and Operator classes are not created when we parse the
19645 declarator but until we have the block completed, so we use a
19646 singleton SimpleIteratorContainer.Simple to flag whether the
19647 SetYields has been invoked.
19649 We propagate this setting then to the Property or the Operator to
19650 allow the `yield' to function.
19652 2004-02-25 Marek Safar <marek.safar@seznam.cz>
19654 * codegen.cs: Implemented attribute support for modules.
19655 New AssemblyClass, ModuleClass and CommonAssemblyModulClass for
19656 Assembly/Module functionality.
19658 * attribute.cs, class.cs, cs-parser.jay, delegate.cs, driver.cs, enum.cs
19659 interface.cs, rootcontext.cs, statement.cs, typemanager.cs:
19660 Updated dependencies on CodeGen.ModuleBuilder and CodeGen.AssemblyBuilder.
19662 2004-02-16 Marek Safar <marek.safar@seznam.cz>
19664 * interface.cs (FindMembers): The operation is performed on all base
19665 interfaces and not only on the first. It is required for future CLS Compliance patch.
19667 2004-02-12 Ben Maurer <bmaurer@users.sourceforge.net>
19669 * statement.cs, codegen.cs:
19670 This patch deals with patterns such as:
19672 public class List : IEnumerable {
19674 public MyEnumerator GetEnumerator () {
19675 return new MyEnumerator(this);
19678 IEnumerator IEnumerable.GetEnumerator () {
19682 public struct MyEnumerator : IEnumerator {
19687 Before, there were a few things we did wrong:
19688 1) we would emit callvirt on a struct, which is illegal
19689 2) we emited ldarg when we needed to emit ldarga
19690 3) we would mistakenly call the interface methods on an enumerator
19691 type that derived from IEnumerator and was in another assembly. For example:
19693 public class MyEnumerator : IEnumerator
19695 Would have the interface methods called, even if there were public impls of the
19696 method. In a struct, this lead to invalid IL code.
19698 2004-02-11 Marek Safar <marek.safar@seznam.cz>
19700 * const.cs: Const is now derived from FieldBase. Method EmitConstant name
19703 * delegate.cs (Define): Fixed crash when delegate type is undefined.
19705 2004-02-11 Miguel de Icaza <miguel@ximian.com>
19707 * cs-parser.jay: Fix small regression: we were not testing V2
19708 compiler features correctly.
19710 * interface.cs: If the emit context is null, then create one
19712 2004-02-09 Marek Safar <marek.safar@seznam.cz>
19714 * decl.cs (GetSignatureForError): New virtual method to get full name
19715 for error messages.
19717 * attribute.cs (IAttributeSupport): New interface for attribute setting.
19718 Now it is possible to rewrite ApplyAttributes method to be less if/else.
19720 * interface.cs : All InterfaceXXX classes are now derived from MemberCore.
19721 Duplicated members and code in these classes has been removed.
19722 Better encapsulation in these classes.
19724 2004-02-07 Miguel de Icaza <miguel@ximian.com>
19726 * assign.cs (Assign.DoResolve): When dealing with compound
19727 assignments, there is a new rule in ECMA C# 2.4 (might have been
19728 there before, but it is documented here) that states that in:
19732 If b is of type int, and the `op' is a shift-operator, then the
19733 above is evaluated as:
19737 * expression.cs (Binary.ResolveOperator): Instead of testing for
19738 int/uint/long/ulong, try to implicitly convert to any of those
19739 types and use that in pointer arithmetic.
19741 * delegate.cs (Error_NoMatchingMethodForDelegate): Compute the
19742 method to print information for from the type, not from the
19743 null-method we were given.
19745 2004-02-01 Duncan Mak <duncan@ximian.com>
19747 * cs-tokenizer.cs (get_cmd_arg): Skip over whitespace before
19748 parsing for cmd, fixes bug #53694.
19750 2004-02-04 Marek Safar <marek.safar@seznam.cz>
19752 * class.cs, decl.cs: Fixed problem where IndexerName attribute was ignored
19753 in the member name duplication tests. Property and operator name duplication
19754 was missing too (error tests cs0102-{2,3,4,5}.cs, cs0111-{3,4}.cs).
19756 2004-02-03 Marek Safar <marek.safar@seznam.cz>
19758 * interface.cs (PopulateMethod): Fixed crash when interface method
19759 returns not existing type (error test cs0246-3.cs).
19761 2004-02-02 Ravi Pratap M <ravi@ximian.com>
19763 * cs-parser.jay (interface_accessors): Re-write actions to also
19764 store attributes attached to get and set methods. Fix spelling
19767 (inteface_property_declaration): Modify accordingly.
19769 (InterfaceAccessorInfo): New helper class to store information to pass
19770 around between rules that use interface_accessors.
19772 * interface.cs (Emit): Apply attributes on the get and set
19773 accessors of properties and indexers too.
19775 * attribute.cs (ApplyAttributes): Modify accordingly to use the
19776 right MethodBuilder when applying attributes to the get and set accessors.
19778 2004-01-31 Miguel de Icaza <miguel@ximian.com>
19780 * cs-tokenizer.cs: Applied patch from Marek Safar to fix bug 53386
19782 2004-01-26 Miguel de Icaza <miguel@ximian.com>
19784 * cs-tokenizer.cs: Handle #line hidden from PDC bits.
19786 2004-01-25 Miguel de Icaza <miguel@ximian.com>
19788 * cs-parser.jay: Remove YIELD token, instead use the new grammar
19789 changes that treat `yield' specially when present before `break'
19790 or `return' tokens.
19792 * cs-tokenizer.cs: yield is no longer a keyword.
19794 2004-01-23 Marek Safar <marek.safar@seznam.cz>
19796 * cs-parser.jay, class.cs (DefineDefaultConstructor): Fixed ModFlags
19797 setting for default constructors.
19798 For default constructors are almost every time set wrong Modifier. The
19799 generated IL code has been alright. But inside mcs this values was
19800 wrong and this was reason why several of my CLS Compliance tests
19803 2004-01-22 Martin Baulig <martin@ximian.com>
19805 * cs-parser.jay (namespace_or_type_name): Return an Expression,
19806 not a QualifiedIdentifier. This is what `type_name_expression'
19807 was previously doing.
19808 (type_name_expression): Removed; the code is now in
19809 `namespace_or_type_name'.
19810 (qualified_identifier): Removed, use `namespace_or_type_name'
19812 (QualifiedIdentifier): Removed this class.
19814 2004-01-22 Martin Baulig <martin@ximian.com>
19816 * namespace.cs (NamespaceEntry.UsingAlias): Take an Expression,
19817 not a string as alias name.
19819 2004-01-21 Miguel de Icaza <miguel@ximian.com>
19821 * ecore.cs (FieldInfo.AddressOf): Revert patch from previous
19822 #52730 bug, and instead compute correctly the need to use a
19823 temporary variable when requesting an address based on the
19824 static/instace modified of the field and the constructor.
19826 2004-01-21 Martin Baulig <martin@ximian.com>
19828 * ecore.cs (SimpleName.ResolveAsTypeStep): Lookup in the current
19829 class and namespace before looking up aliases. Fixes #52517.
19831 2004-01-21 Martin Baulig <martin@ximian.com>
19833 * flowanalysis.cs (UsageVector.Merge): Allow variables being
19834 assinged in a 'try'; fixes exception4.cs.
19836 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19837 * class.cs : Implemented parameter-less constructor for TypeContainer
19839 * decl.cs: Attributes are now stored here. New property OptAttributes
19841 * delegate.cs, enum.cs, interface.cs: Removed attribute member.
19843 * rootcontext.cs, tree.cs: Now use parameter-less constructor of TypeContainer
19845 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19847 * typemanager.cs (CSharpSignature): Now reports also inner class name.
19848 (CSharpSignature): New method for indexer and property signature.
19850 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19852 * pending.cs (IsVirtualFilter): Faster implementation.
19854 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19856 * typemanager.cs: Avoid inclusion of same assembly more than once.
19858 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19860 * cs-parser.jay: Fixed problem where the last assembly attribute
19861 has been applied also to following declaration (class, struct, etc.)
19863 2004-01-21 Marek Safar <marek.safar@seznam.cz>
19865 * class.cs: Added error CS0538, CS0539 reporting.
19866 Fixed crash on Microsoft runtime when field type is void.
19868 * cs-parser.jay: Added error CS0537 reporting.
19870 * pending.cs: Added error CS0535 reporting.
19871 Improved error report for errors CS0536, CS0534.
19873 2004-01-20 Miguel de Icaza <miguel@ximian.com>
19875 Merge a few bits from the Anonymous Method MCS tree.
19877 * statement.cs (ToplevelBlock): New class for toplevel methods,
19878 will hold anonymous methods, lifted variables.
19880 * cs-parser.jay: Create toplevel blocks for delegates and for
19881 regular blocks of code.
19883 2004-01-20 Martin Baulig <martin@ximian.com>
19885 * codegen.cs (EmitContext): Removed `InTry', `InCatch',
19886 `InFinally', `InLoop', `TryCatchLevel', `LoopBeginTryCatchLevel'
19887 and `NeedExplicitReturn'; added `IsLastStatement'.
19888 (EmitContext.EmitTopBlock): Emit the explicit "ret" if we either
19889 have a `ReturnLabel' or we're not unreachable.
19891 * flowanalysis.cs (FlowBranching.MergeChild): Actually merge the
19892 child's reachability; don't just override ours with it. Fixes
19893 #58058 (lluis's example).
19894 (FlowBranching): Added public InTryOrCatch(), InCatch(),
19895 InFinally(), InLoop(), InSwitch() and
19896 BreakCrossesTryCatchBoundary() methods.
19898 * statement.cs (Return): Do all error checking in Resolve().
19899 Unless we are the last statement in a top-level block, always
19900 create a return label and jump to it.
19901 (Break, Continue): Do all error checking in Resolve(); also make
19902 sure we aren't leaving a `finally'.
19903 (Block.DoEmit): Set `ec.IsLastStatement' when emitting the last
19904 statement in a top-level block.
19905 (Block.Flags): Added `IsDestructor'.
19906 (Block.IsDestructor): New public property.
19908 2004-01-20 Martin Baulig <martin@ximian.com>
19910 * statement.cs (Break.DoEmit): Set ec.NeedExplicitReturn; fixes #52427.
19912 2004-01-20 Martin Baulig <martin@ximian.com>
19914 * statement.cs (Statement.ResolveUnreachable): New public method.
19915 (If, While): Do the dead-code elimination in Resolve(), not in Emit().
19916 (Block.Resolve): Resolve unreachable statements.
19918 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19920 * expression.cs: We need to fix the case where we do
19921 not have a temp variable here.
19923 * assign.cs: Only expression compound assignments need
19924 temporary variables.
19926 2004-01-19 Ben Maurer <bmaurer@users.sourceforge.net>
19928 * flowanalysis.cs: Reduce memory allocation in a few ways:
19929 - A block with no variables should not allocate a bit
19931 - A method with no out parameters does not need any tracking
19932 for assignment of the parameters, so we need not allocate
19935 public readonly Type[] VariableTypes;
19936 public readonly string[] VariableNames;
19937 Are redundant. The data is already stored in the variable
19938 map, so we need not allocate another array for it.
19939 - We need to add alot of checks for if (params | locals) == null
19940 due to the first two changes.
19942 2004-01-18 Miguel de Icaza <miguel@ximian.com>
19944 * ecore.cs (FieldExpr.AddressOf): For ValueTypes that do not
19945 implement IMemoryLocation, we store a copy on a local variable and
19946 take the address of it. Patch from Benjamin Jemlich
19948 * cs-parser.jay: Applied patch from Ben Maurer to the "type" rule
19949 to use a special "type_name_expression" rule which reduces the
19950 number of "QualifiedIdentifier" classes created, and instead
19951 directly creates MemberAccess expressions.
19953 2004-01-17 Miguel de Icaza <miguel@ximian.com>
19955 * convert.cs: Applied patch from Benjamin Jemlich (pcgod@gmx.net)
19956 that fixes #52853. Null literal assignment to ValueType
19958 * class.cs (MethodData.Emit): Instead of checking the name of the
19959 method to determine if its a destructor, create a new derived
19960 class from Method called Destructor, and test for that.
19962 * cs-parser.jay: Create a Destructor object instead of a Method.
19964 Based on a fix from Benjamin Jemlich (pcgod@gmx.net)
19968 2004-01-16 Miguel de Icaza <miguel@ximian.com>
19970 * expression.cs (Binary.ResolveOperator): Perform an implicit
19971 conversion from MethodGroups to their delegate types on the
19972 Addition operation.
19974 * delegate.cs: Introduce a new class DelegateCreation that is the
19975 base class for `NewDelegate' and `ImplicitDelegateCreation',
19976 factor some code in here.
19978 * convert.cs (Convert.ImplicitConversionStandard): Add an implicit
19979 conversion from MethodGroups to compatible delegate types.
19981 * ecore.cs (Expression.Resolve): Do not flag error 654
19982 (Methodgroupd needs parenthesis) if running on the V2 compiler, as
19983 we allow conversions from MethodGroups to delegate types now.
19985 * assign.cs (Assign.DoResolve): Do not flag errors on methodgroup
19986 assignments in v2 either.
19988 2004-01-10 Miguel de Icaza <miguel@ximian.com>
19990 * ecore.cs (FieldExpr.AddressOf): Fix generated IL for accessing
19991 static read-only fields in ctors.
19993 Applied patch from Benjamin Jemlich
19995 * expression.cs (UnaryMutator): Avoid leaking local variables.
19997 2004-01-09 Miguel de Icaza <miguel@ximian.com>
19999 * cs-tokenizer.cs (IsCastToken): Allow the various native types
20000 here to return true, as they can be used like this:
20002 (XXX) int.MEMBER ()
20004 Fixed 49836 and all the other dups
20006 2004-01-09 Zoltan Varga <vargaz@freemail.hu>
20008 * driver.cs: Implement /win32res and /win32icon.
20010 2004-01-08 Miguel de Icaza <miguel@ximian.com>
20012 * cs-parser.jay: Add a rule to improve error handling for the
20013 common mistake of placing modifiers after the type.
20015 2004-01-07 Miguel de Icaza <miguel@ximian.com>
20017 * cs-parser.jay (interface_event_declaration): Catch
20018 initialization of events on interfaces, and report cs0068
20020 * cs-parser.jay (interface_event_declaration): Catch
20021 initialization of events.
20023 * ecore.cs: Better report missing constructors.
20025 * expression.cs (Binary.ResolveOperator): My previous bug fix had
20026 the error reporting done in the wrong place. Fix.
20028 * expression.cs (Binary.ResolveOperator): Catch the
20029 operator + (E x, E y) error earlier, and later allow for implicit
20030 conversions in operator +/- (E e, U x) from U to the underlying
20033 * class.cs (TypeContainer.DefineDefaultConstructor): Fix bug
20034 52596, if the container class is abstract, the default constructor
20035 is protected otherwise its public (before, we were always public).
20037 * statement.cs (Fixed.Resolve): Catch a couple more errors in the
20040 (Using.EmitLocalVariableDecls): Applied patch from Benjamin
20041 Jemlich that fixes bug #52597, MCS was generating invalid code for
20042 idisposable structs. Thanks to Ben for following up with this
20045 2004-01-06 Miguel de Icaza <miguel@ximian.com>
20047 * driver.cs: Allow assemblies without code to be generated, fixes
20050 2004-01-07 Nick Drochak <ndrochak@gol.com>
20052 * attribute.cs: Remove unneeded catch variables. Eliminates a warning.
20054 2004-01-05 Miguel de Icaza <miguel@ximian.com>
20056 * cs-parser.jay: Add rules to improve error reporting if fields or
20057 methods are declared at the namespace level (error 116)
20059 * Add rules to catch event add/remove
20061 2004-01-04 David Sheldon <dave-mono@earth.li>
20063 * expression.cs: Added matching ")" to error message for
20066 2004-01-03 Todd Berman <tberman@gentoo.org>
20068 * ecore.cs, attribute.cs:
20069 Applying fix from #52429.
20071 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20073 * ecore.cs, expression.cs, statement.cs:
20074 Total rewrite of how we handle branching. We
20075 now handle complex boolean expressions with fewer
20076 jumps. As well if (x == 0) no longer emits a ceq.
20078 if (x is Foo) is much faster now, because we generate
20081 Overall, we get a pretty big improvement on our benchmark
20082 tests. The code we generate is smaller and more readable.
20084 I did a full two-stage bootstrap. The patch was reviewed
20085 by Martin and Miguel.
20087 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20089 * cs-parser.jay: Make primary_expression not take a QI.
20090 we dont need this because the member_access rule covers
20091 us here. So we replace the rule with just IDENTIFIER.
20093 This has two good effects. First, we remove a s/r conflict.
20094 Second, we allocate many fewer QualifiedIdentifier objects.
20096 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20098 * attribute.cs: Handle MarshalAs attributes as pseudo, and
20099 set the correct information via SRE. This prevents
20100 hanging on the MS runtime. Fixes #29374.
20102 2004-01-03 Ben Maurer <bmaurer@users.sourceforge.net>
20104 * convert.cs: correctly handle conversions to value types
20105 from Enum and ValueType as unboxing conversions.
20107 Fixes bug #52569. Patch by Benjamin Jemlich.
20109 2004-01-02 Ravi Pratap <ravi@ximian.com>
20111 * expression.cs (BetterConversion): Prefer int -> uint
20112 over int -> ulong (csc's behaviour). This fixed bug #52046.
20114 2004-01-02 Ben Maurer <bmaurer@users.sourceforge.net>
20116 * decl.cs (MemberCache.FindMembers): now returns a
20119 * typemanager.cs: In general, go with with ^^.
20120 (CopyNewMethods): take an IList.
20121 (RealMemberLookup): Only allocate an arraylist
20122 if we copy from two sets of methods.
20124 This change basically does two things:
20125 1) Fewer array lists allocated due to CopyNewMethods.
20126 2) the explicit cast in MemberList costed ALOT.
20128 2004-01-02 Zoltan Varga <vargaz@freemail.hu>
20130 * cs-tokenizer.cs (consume_identifier) driver.cs: Cache identifiers in
20131 a hashtable to avoid needless string allocations when an identifier is
20132 used more than once (the common case).
20134 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20136 * pending.cs: MS's TypeBuilder.GetInterfaces ()
20137 is broken, it will not return anything. So, we
20138 have to use the information we have in mcs to
20141 * typemanager.cs: Add a cache for GetInterfaces,
20142 since this will now be used more often (due to ^^)
20144 (GetExplicitInterfaces) New method that gets the
20145 declared, not effective, interfaces on a type
20146 builder (eg, if you have interface IFoo, interface
20147 IBar, Foo : IFoo, Bar : Foo, IBar, GetExplInt (Bar) ==
20150 This patch makes MCS able to bootstrap itself on
20153 2004-01-01 Ben Maurer <bmaurer@users.sourceforge.net>
20155 * expression.cs: Remove the Nop's that Miguel put
20158 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20160 * report.cs, codegen.cs: Give the real stack trace to
20161 the error when an exception is thrown.
20163 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20165 * decl.cs: only allocate hashtables for ifaces if
20168 2003-12-31 Ben Maurer <bmaurer@users.sourceforge.net>
20170 * expression.cs: fix the error from cs0121-2.cs
20171 (a parent interface has two child interfaces that
20172 have a function with the same name and 0 params
20173 and the function is called through the parent).
20175 2003-12-30 Ben Maurer <bmaurer@users.sourceforge.net>
20177 * class.cs, rootcontext.cs, typmanager.cs: do not
20180 2003-12-28 Ben Maurer <bmaurer@users.sourceforge.net>
20182 * codegen.cs: remove stack for the ec flow branching.
20183 It is already a linked list, so no need.
20185 2003-12-27 Ben Maurer <bmaurer@users.sourceforge.net>
20187 * Makefile: Allow custom profiler here.
20189 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20191 * typemanager.cs (LookupType):
20192 - Use a static char [], because split takes
20193 a param array for args, so it was allocating
20195 - Do not store true in a hashtable, it boxes.
20197 2003-12-26 Ben Maurer <bmaurer@users.sourceforge.net>
20199 * flowanalysis.cs: bytify common enums.
20201 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20203 * modifiers.cs: Add a new set of flags for the
20204 flags allowed on explicit interface impls.
20205 * cs-parser.jay: catch the use of modifiers in
20206 interfaces correctly.
20207 * class.cs: catch private void IFoo.Blah ().
20209 All related to bug #50572.
20211 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20213 * decl.cs: Rewrite the consistant accessability checking.
20214 Accessability is not linear, it must be implemented in
20215 a tableish way. Fixes #49704.
20217 2003-12-25 Ben Maurer <bmaurer@users.sourceforge.net>
20219 * expression.cs: Handle negation in a checked context.
20220 We must use subtraction from zero. Fixes #38674.
20222 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20224 * class.cs: Ignore static void main in DLLs.
20225 * rootcontext.cs: Handle the target type here,
20226 since we are have to access it from class.cs
20227 * driver.cs: account for the above.
20229 2003-12-23 Ben Maurer <bmaurer@users.sourceforge.net>
20231 * report.cs: Give line numbers and files if available.
20233 2003-12-20 Zoltan Varga <vargaz@freemail.hu>
20235 * driver.cs: Implement /addmodule.
20237 * typemanager.cs: Change 'modules' field so it now contains Modules not
20240 2003-12-20 Martin Baulig <martin@ximian.com>
20242 * class.cs (TypeContainer.DefineMembers): Don't do the CS0649 check here.
20243 (FieldBase.IsAssigned): Removed this field.
20244 (FieldBase.SetAssigned): New public method.
20245 (TypeContainer.Emit): Make the CS0169/CS0649 checks actually work.
20247 2003-12-20 Martin Baulig <martin@ximian.com>
20249 * expression.cs (LocalVariableReference.DoResolve): Don't set
20250 `vi.Used' if we're called from DoResolveLValue().
20252 * statement.cs (Block.DoResolve): `ec.DoEndFlowBranching()' now
20253 returns the usage vector it just merged into the current one -
20254 pass this one to UsageWarning().
20255 (Block.UsageWarning): Take the `FlowBranching.UsageVector' instead
20256 of the `EmitContext', don't call this recursively on our children.
20258 2003-12-19 Zoltan Varga <vargaz@freemail.hu>
20260 * driver.cs: Implement /target:module.
20262 2003-12-18 Zoltan Varga <vargaz@freemail.hu>
20264 * support.cs (CharArrayHashtable): New helper class.
20266 * cs-tokenizer.cs: Store keywords in a hashtable indexed by
20267 char arrays, not strings, so we can avoid creating a string in
20268 consume_identifier if the identifier is a keyword.
20270 2003-12-16 Martin Baulig <martin@ximian.com>
20272 * statement.cs (LocalInfo.Assigned): Removed this property.
20273 (LocalInfo.Flags): Removed `Assigned'.
20274 (LocalInfo.IsAssigned): New public method; takes the EmitContext
20275 and uses flow analysis.
20276 (Block.UsageWarning): Made this method private.
20277 (Block.Resolve): Call UsageWarning() if appropriate.
20279 * expression.cs (LocalVariableReference.DoResolve): Always set
20280 LocalInfo.Used here.
20282 2003-12-13 Martin Baulig <martin@ximian.com>
20284 * statement.cs (Statement.DoEmit, Statement.Emit): Don't return
20285 any value here; we're now using flow analysis to figure out
20286 whether a statement/block returns a value.
20288 2003-12-13 Martin Baulig <martin@ximian.com>
20290 * flowanalysis.cs (UsageVector.MergeFinallyOrigins): Made this
20292 (FlowBranching.MergeFinally): Don't call
20293 `branching.CheckOutParameters()' here, this is called in
20295 (FlowBranchingException.AddSibling): Call MergeFinallyOrigins()
20296 when adding the `finally' vector.
20298 2003-12-13 Martin Baulig <martin@ximian.com>
20301 (UsageVector.MergeJumpOrigins, FlowBranching.Label): Make this
20302 actually work and also fix #48962.
20304 2003-12-12 Ben Maurer <bmaurer@users.sourceforge.net>
20306 * decl.cs: Do not check System.Object for nested types,
20307 since we know it does not have any. Big bang for buck:
20310 Run 1: 8.35 seconds
20311 Run 2: 8.32 seconds
20312 corlib: 17.99 seconds
20314 Run 1: 8.17 seconds
20315 Run 2: 8.17 seconds
20316 corlib: 17.39 seconds
20318 2003-12-11 Ben Maurer <bmaurer@users.sourceforge.net>
20320 * class.cs (FindMembers): Allocate arraylists on demand. Most of the
20321 time we are returning 0 members, so we save alot here.
20323 2003-12-11 Martin Baulig <martin@ximian.com>
20325 * flowanalysis.cs (UsageVector.MergeResult): Renamed this back to
20326 `MergeChild()', also just take the `FlowBranching' as argument;
20327 call Merge() on it and return the result.
20328 (FlowBranching.Merge): We don't need to do anything if we just
20331 2003-12-11 Martin Baulig <martin@ximian.com>
20333 * flowanalysis.cs: Use a list of `UsageVector's instead of storing
20334 them in an `ArrayList' to reduce memory usage. Thanks to Ben
20335 Maurer for this idea.
20337 2003-12-11 Martin Baulig <martin@ximian.com>
20339 * flowanalysis.cs (MergeResult): This class is now gone; we now
20340 use the `UsageVector' for this. The reason for this is that if a
20341 branching just has one sibling, we don't need to "merge" them at
20342 all - that's the next step to do.
20343 (FlowBranching.Merge): We now return a `UsageVector' instead of a
20346 2003-12-11 Martin Baulig <martin@ximian.com>
20348 Reworked flow analyis and made it more precise and bug-free. The
20349 most important change is that we're now using a special `Reachability'
20350 class instead of having "magic" meanings of `FlowReturns'. I'll
20351 do some more cleanups and optimizations and also add some more
20352 documentation this week.
20354 * flowanalysis.cs (Reachability): Added `Throws' and `Barrier';
20355 largely reworked this class.
20356 (FlowReturns): Removed `Unreachable' and `Exception'; we now use
20357 the new `Reachability' class instead of having "magic" values here.
20358 (FlowBranching): We're now using an instance of `Reachability'
20359 instead of having separate `Returns', `Breaks' etc. fields.
20361 * codegen.cs (EmitContext.EmitTopBlock): Set `has_ret' solely
20362 based on flow analysis; ignore the return value of block.Emit ().
20364 2003-12-10 Zoltan Varga <vargaz@freemail.hu>
20366 * driver.cs typemanager.cs: Find the mono extensions to corlib even
20367 if they are private.
20369 2003-12-09 Martin Baulig <martin@ximian.com>
20371 * flowanalyis.cs (FlowBranching.Return, Goto, Throw): Removed;
20372 call them directly on the UsageVector.
20374 2003-12-09 Martin Baulig <martin@ximian.com>
20376 * flowanalysis.cs (FlowBranching.MergeChild, MergeTopBlock):
20377 Changed return type from `FlowReturns' to `Reachability'.
20379 2003-12-09 Martin Baulig <martin@ximian.com>
20381 * flowanalysis.cs (FlowBranching.Reachability): New sealed class.
20382 (FlowBranching.MergeResult): Replaced the `Returns', `Breaks' and
20383 `Reachable' fields with a single `Reachability' one.
20385 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20387 * class.cs (FindMembers): Remove foreach's.
20392 Run 1: 8.74 seconds
20393 Run 2: 8.71 seconds
20396 Run 1: 8.64 seconds
20397 Run 2: 8.58 seconds
20400 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20405 This patch does a few things:
20406 1. EmptyStatement is now a singleton, so it is never reallocated.
20407 2. All blah is EmptyStatement constructs have been changed to
20408 blah == EmptyStatement.Value, which is much faster and valid
20409 now that EmptyStatement is a singleton.
20410 3. When resolving a block, rather than allocating a new array for
20411 the non-empty statements, empty statements are replaced with
20412 EmptyStatement.Value
20413 4. Some recursive functions have been made non-recursive.
20414 Mainly the performance impact is from (3), however (1) and (2) are needed for
20415 this to work. (4) does not make a big difference in normal situations, however
20416 it makes the profile look saner.
20421 9.25user 0.23system 0:10.28elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20422 9.34user 0.13system 0:10.23elapsed 92%CPU (0avgtext+0avgdata 0maxresident)k
20423 Total memory allocated: 56397 KB
20426 9.13user 0.09system 0:09.64elapsed 95%CPU (0avgtext+0avgdata 0maxresident)k
20427 8.96user 0.24system 0:10.13elapsed 90%CPU (0avgtext+0avgdata 0maxresident)k
20428 Total memory allocated: 55666 KB
20430 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20432 * support.cs: Rewrite DoubleHash to use its own impl. Is faster
20433 than the hashtable in a hashtable version
20435 * decl.cs: Right now, whenever we try to lookup a type inside a namespace,
20436 we always end up concating a string. This results in a huge perf
20437 loss, because many strings have to be tracked by the GC. In this
20438 patch, we first use a hashtable that works with two keys, so that
20439 the strings do not need to be concat'ed.
20443 Run 1: 8.74 seconds
20444 Run 2: 8.71 seconds
20447 Run 1: 8.65 seconds
20448 Run 2: 8.56 seconds
20450 2003-12-08 Ben Maurer <bmaurer@users.sourceforge.net>
20452 * Makefile: Add a new target `do-time' that does a quick and simple
20453 profile, leaving easy to parse output.
20455 2003-12-08 Zoltan Varga <vargaz@freemail.hu>
20457 * codegen.cs (Init): Create the dynamic assembly with
20458 AssemblyBuilderAccess.Save, to enable some optimizations in the runtime.
20460 2003-12-02 Ben Maurer <bmaurer@users.sourceforge.net>
20462 * support.cs: Make the PtrHashtable use only one
20463 instance of its comparer.
20465 2003-11-30 Zoltan Varga <vargaz@freemail.hu>
20467 * typemanager.cs: Fix lookup of GetNamespaces.
20469 2003-11-29 Miguel de Icaza <miguel@ximian.com>
20471 * expression.cs: Removed redundant line.
20473 * statement.cs (Block.Resolve, Block.Emit): Avoid foreach on
20474 ArrayLists, use for loops with bounds.
20476 * flowanalysis.cs (FlowBranching.Merge): Avoid foreach on
20479 * expression.cs (Invocation.OverloadResolve): Avoid foreach on
20480 arraylists, use for loop with bounds.
20482 The above three changes give us a 0.071 second performance
20483 improvement out of 3.294 seconds down to 3.223. On my machine
20484 the above changes reduced the memory usage by 1,387 KB during
20485 compiler bootstrap.
20487 * cs-parser.jay (QualifiedIdentifier): New class used to represent
20488 QualifiedIdentifiers. Before we created a new string through
20489 concatenation, and mostly later on, the result would be
20490 manipulated by DecomposeQI through string manipulation.
20492 This reduced the compiler memory usage for bootstrapping from
20493 59380 KB to 59007 KB on my machine, 373 KB, and also reduced the
20494 compile times in 0.05 seconds.
20496 2003-11-28 Dick Porter <dick@ximian.com>
20498 * support.cs: Do string compares with the Invariant culture.
20506 * class.cs: Use the char forms of IndexOf and LastIndexOf, so that
20507 the comparison is done with the Invariant culture.
20509 2003-11-27 Miguel de Icaza <miguel@ximian.com>
20511 * statement.cs (Foreach.TryType): Use DeclaredOnly to find the
20512 GetEnumerator method.
20514 (ProbeCollectionType): Iterate starting at the most specific type
20515 upwards looking for a GetEnumerator
20517 * expression.cs: Shift count can be up to 31 for int/uint and 63
20520 2003-11-26 Miguel de Icaza <miguel@ximian.com>
20522 * statement.cs (Block.LookupLabel): Also look for the label on the
20523 children blocks. Use a hash table to keep track of visited
20526 * cfold.cs (IntConstant to UIntConstant mapping): Only return if
20527 we actually did transform the other operand, otherwise fall back
20528 to the common codepath that casts to long.
20530 * cs-tokenizer.cs: Use the same code pattern as the int case.
20531 Maybe I should do the parsing myself, and avoid depending on the
20532 Parse routines to get this done.
20534 2003-11-25 Miguel de Icaza <miguel@ximian.com>
20536 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20537 which fixes bug 51347. This time test it.
20539 * expression.cs: Make TypeOfVoid derive from TypeOf, so code in
20540 attributes for example can not tell the difference between these.
20541 The difference was only a syntax feature of the language.
20543 * attribute.cs: Apply attributes to delegates.
20545 * delegate.cs: Call the apply attributes method.
20547 2003-11-24 Miguel de Icaza <miguel@ximian.com>
20549 * convert.cs (TryImplicitIntConversion): One line bug fix: we were
20550 comparing 0 vs Byte.MinValue, not the value
20552 (ImplicitConversionRequired): When reporting a conversion error,
20553 use error 31 to print out the constant error instead of the
20556 * expression.cs: Apply fix from l_m@pacbell.net (Laurent Morichetti),
20557 which fixes bug 51347.
20559 2003-11-22 Miguel de Icaza <miguel@ximian.com>
20561 * driver.cs: Applied patch from gert.driesen@pandora.be (Gert Driesen)
20562 which fixes the -warnaserror command line option.
20564 2003-11-21 Miguel de Icaza <miguel@ximian.com>
20566 * cfold.cs (DoNumericPromotions): During constant folding of
20567 additions on UIntConstant, special case intconstants with
20568 IntConstants like we do on the expression binary operator.
20570 2003-11-12 Miguel de Icaza <miguel@ximian.com>
20572 * convert.cs (ImplicitReferenceConversion): We were missing a case
20573 (System.Enum are not value types or class types, so we need to
20574 classify them separatedly).
20576 * driver.cs: We do not support error 2007.
20578 2003-11-12 Jackson Harper <jackson@ximian.com>
20580 * driver.cs: Use corlib.dll or mscorlib.dll when looking up the
20581 system directory. Also use the full file name so users can
20582 libraries names mscorlib-o-tron.dll in a non system dir.
20584 2003-11-10 Martin Baulig <martin@ximian.com>
20586 * typemanager.cs (TypeManager.ResolveExpressionTypes): Removed.
20587 (TypeManager.InitCoreTypes): Initialize them here, but instead of
20588 calling `ResolveType()' on them, directly assign their `Type'.
20590 2003-11-08 Martin Baulig <martin@ximian.com>
20592 * class.cs (TypeContainer.GetClassBases): Use TypeExpr's for the
20593 return value and the `out parent' parameter.
20594 (TypeContainer.DefineType): Moved the CS0644 check into
20595 GetClassBases(). Don't pass the interface types to the
20596 `builder.DefineType()'/`builder.DefineNestedType()', but resolve
20597 them later and then call `TypeBuilder.AddInterfaceImplementation()'.
20599 * ecore.cs (TypeExpr.IsAttribute): New property.
20600 (TypeExpr.GetInterfaces): New method.
20602 * interface.cs (Interface.GetInterfaceTypeByName): Return a
20603 TypeExpr instead of a Type.
20604 (Interface.GetInterfaceBases): Return TypeExpr's instead of Type's.
20605 (Interface.DefineType): Don't pass the interface types to the
20606 `builder.Definetype()'/`builder.DefineNestedType()', but resolve
20607 them later and then call `TypeBulider.AddInterfaceImplementation()'.
20609 * typemanager.cs (TypeManager.AddUserType): Take a `TypeExpr[]'
20610 instead of a `Type[]'.
20611 (TypeManager.RegisterBuilder): Likewise.
20612 (TypeManager.AddUserInterface): Likewise.
20613 (TypeManager.ExpandInterfaces): Take a `Type[]' instead of a
20614 `Type[]' and also return a `TypeExpr[]'.
20615 (TypeManager.GetInterfaces): Return a `TypeExpr[]'.
20617 2003-11-08 Martin Baulig <martin@ximian.com>
20619 * decl.cs (DeclSpace.ResolveTypeExpr): Return a TypeExpr, not an
20622 2003-11-08 Martin Baulig <martin@ximian.com>
20624 * decl.cs (DeclSpace.GetTypeResolveEmitContext): Call
20625 TypeManager.ResolveExpressionTypes().
20627 * ecore.cs (Expression.ResolveAsTypeTerminal): Return a TypeExpr
20628 instead of an Expression.
20629 (TypeExpr): This is now an abstract base class for `TypeExpression'.
20630 (TypeExpression): New public class; formerly known as `TypeExpr'.
20632 * expression.cs (ComposedCast): Derive from TypeExpr.
20634 * typemanager.cs (TypeManager.system_*_expr): These are now
20635 TypExpr's instead of Expression's.
20636 (TypeManager.ResolveExpressionTypes): New public static function;
20637 called from DeclSpace.GetTypeResolveEmitContext() to resolve all
20640 2003-11-06 Miguel de Icaza <miguel@ximian.com>
20642 * expression.cs (New.DoResolve): Do not dereference value that
20643 might be a null return.
20645 * statement.cs (Block.EmitMeta): Use the Const.ChangeType to make
20646 sure that the constant value has the right type. Fixes an
20647 unreported bug, similar to 50425.
20649 * const.cs (Const.LookupConstantValue): Call
20650 ImplicitStandardConversionExists before doing a conversion to
20651 avoid havng the TypeManager.ChangeType do conversions.
20653 Reduced the number of casts used
20655 (Const.ChangeType): New routine to enable reuse of the constant
20656 type changing code from statement.
20658 * typemanager.cs (ChangeType): Move common initialization to
20659 static global variables.
20663 * convert.cs (ImplicitReferenceConversion): Somehow we allowed
20664 every value type to go through, even if it was void. Fix that.
20666 * cs-tokenizer.cs: Use is_identifier_start_character on the start
20667 character of the define, and the is_identifier_part_character for
20668 the rest of the string.
20670 2003-11-05 Miguel de Icaza <miguel@ximian.com>
20672 * expression.cs (UnaryMutator.EmitCode): When I updated
20673 LocalVariableReference.DoResolve, I overdid it, and dropped an
20674 optimization done on local variable references.
20676 2003-11-04 Miguel de Icaza <miguel@ximian.com>
20678 * ecore.cs: Convert the return from Ldlen into an int.
20680 2003-10-20 Miguel de Icaza <miguel@ximian.com>
20682 * decl.cs (DeclSpace.GetAccessLevel): Handle NotPublic case for
20683 the accessibility, this is a special case for toplevel non-public
20684 classes (internal for instance).
20686 2003-10-20 Nick Drochak <ndrochak@gol.com>
20688 * ecore.cs: Fix typo and build. Needed another right paren.
20690 2003-10-19 Miguel de Icaza <miguel@ximian.com>
20692 * ecore.cs: Applied fix from Ben Maurer. We were handling in the
20693 `internal' case regular and protected, but not allowing protected
20694 to be evaluated later. Bug 49840
20696 2003-10-15 Miguel de Icaza <miguel@ximian.com>
20698 * statement.cs (Switch.TableSwitchEmit): Compare the upper bound
20699 to kb.Nlast, and not the kb.nFirst to isolate the switch
20702 Extract the underlying type, so enumerations of long/ulong are
20703 treated like long/ulong.
20705 2003-10-14 Miguel de Icaza <miguel@ximian.com>
20707 * expression.cs (New): Overload the meaning of RequestedType to
20708 track the possible creation of the NewDelegate type, since
20709 DoResolve is invoked more than once for new constructors on field
20712 See bugs: #48800 and #37014
20714 * cs-parser.jay (declare_local_constants): Take an arraylist
20715 instead of a single constant.
20717 (local_constant_declaration): It should take a
20718 constant_declarators, not a constant_declarator. Fixes 49487
20720 * convert.cs: Fix error report.
20722 2003-10-13 Jackson Harper <jackson@ximian.com>
20724 * typemanager.cs (TypeToCoreType): Add float and double this fixes
20727 2003-10-09 Martin Baulig <martin@ximian.com>
20729 * class.cs (MethodCore): Added additional `DeclSpace ds' argument
20731 (MethodCore.DoDefineParameters): Removed the TypeContainer
20732 argument; use the DeclSpace which was passed to the .ctor instead.
20733 (MethodCore.CheckParameter): Take a DeclSpace instead of a
20734 TypeContainer; we only need a DeclSpace here.
20736 2003-10-09 Martin Baulig <martin@ximian.com>
20738 * class.cs (MethodData): Added additional `DeclSpace ds' argument
20740 (MethodData.Define, MethodData.Emit): Pass the `ds' to the
20741 EmitContext's .ctor.
20743 2003-10-09 Martin Baulig <martin@ximian.com>
20745 * decl.cs (DeclSpace.AsAccessible): Moved here from TypeContainer.
20746 (AccessLevel, CheckAccessLevel, GetAccessLevel): They're used by
20747 AsAccessible(), moved them as well.
20749 * class.cs (TypeContainer.AsAccessible): Moved to DeclSpace.
20751 2003-10-08 Atsushi Enomoto <ginga@kit.hi-ho.ne.jp>
20753 * cs-parser.jay : Renamed yyName to yyNames related to jay.
20755 2003-10-07 Miguel de Icaza <miguel@ximian.com>
20757 * expression.cs (Binary.Emit.GreatherThanOrEqual): Fix the code
20758 generation for >=, as spotted by Paolo, bug 48679.
20759 Patch from David Waite.
20761 * cs-tokenizer.cs: Add handling for #pragma.
20763 * cs-parser.jay: Allow for both yield and yield return in the
20764 syntax. The anti-cobolization of C# fight will go on!
20766 * class.cs (TypeBuilder.DefineType): Catch error condition here
20767 (Parent.DefineType erroring out and returning null).
20769 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
20770 coping with enumerations variables, we were mistakenly processing
20771 them as a regular value type instead of built-in types. Fixes the
20774 * typemanager.cs (IsBuiltinOrEnum): New method.
20776 2003-09-30 Miguel de Icaza <miguel@ximian.com>
20778 * cs-parser.jay: Upgrade: yield now needs the return clause.
20780 2003-09-19 Martin Baulig <martin@ximian.com>
20782 * decl.cs (MemberCache.SetupCacheForInterface): Take a
20783 `MemberCache parent' argument. Normally, an interface doesn't
20784 have a parent type except System.Object, but we use this in gmcs
20785 for generic type parameters.
20787 2003-09-18 Martin Baulig <martin@ximian.com>
20789 * typemanager.cs (TypeHandle.ctor): Set `IsInterface' solely based
20790 on `type.IsInterface'; don't check whether the type has a parent
20791 to determine whether it's an interface.
20793 2003-09-15 Martin Baulig <martin@ximian.com>
20795 * class.cs (TypeContainer.DefineType): Added an error flag to
20796 avoid reporting duplicate CS0146's ("class definition is
20799 * driver.cs (Driver.MainDriver): Abort if
20800 RootContext.ResolveTree() reported any errors.
20802 2003-09-07 Martin Baulig <martin@ximian.com>
20804 * report.cs (Error, Warning): Added overloaded versions which take
20805 a `params object[] args' and call String.Format().
20807 2003-09-07 Martin Baulig <martin@ximian.com>
20809 * decl.cs (DeclSpace..ctor): Don't call
20810 NamespaceEntry.DefineName() here; do it in RecordDecl() which is
20811 called from Tree.RecordDecl(). Fixes the CS0101 reporting.
20812 (DeclSpace.RecordDecl): New method.
20814 * tree.cs (Tree.RecordDecl): Call ds.RecordDecl().
20816 2003-09-02 Ravi Pratap <ravi@ximian.com>
20818 * attribute.cs (CheckAttributeTarget): Ensure that we allow return
20819 value attributes to be applied to ParameterBuilders.
20821 * class.cs (MethodCore.LabelParameters): Make static and more
20822 generic so that it can be used from other places - like interface
20823 methods, for instance.
20825 * interface.cs (Interface.Emit): Call LabelParameters before
20826 emitting attributes on the InterfaceMethod.
20828 2003-08-26 Martin Baulig <martin@ximian.com>
20830 * ecore.cs (SimpleName.SimpleNameResolve): Look for members before
20831 resolving aliases; fixes #47927.
20833 2003-08-26 Martin Baulig <martin@ximian.com>
20835 * statement.cs (Using.DoResolve): This is internally emitting a
20836 try/finally clause, so we need to set ec.NeedExplicitReturn if we
20837 do not always return. Fixes #47681.
20839 2003-08-26 Martin Baulig <martin@ximian.com>
20841 * decl.cs (MemberCore): Moved WarningNotHiding(),
20842 Error_CannotChangeAccessModifiers() and CheckMethodAgainstBase()
20844 (AdditionResult): Make this nested in DeclSpace.
20845 (DeclSpace.ctor): The .ctor now takes an additional NamespaceEntry
20846 argument; call NamespaceEntry.Define() unless we're nested in a
20849 * namespace.cs (Namespace.DefineName): New public function. This
20850 is called from DeclSpace's .ctor to add
20851 (Namespace.Lookup): Include DeclSpaces in the lookup.
20853 * class.cs (Operator): Derive from MemberBase, not MemberCore.
20855 * const.cs (Const): Derive from MemberBase, not MemberCore.
20857 2003-08-25 Martin Baulig <martin@ximian.com>
20859 * convert.cs (Convert.ExplicitReferenceConversion): When
20860 converting from an interface type to a class, unbox if the target
20861 type is a struct type. Fixes #47822.
20863 2003-08-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
20865 * typemanager.cs: fixed the values of MethodFlags. Closes #47855 and
20868 2003-08-22 Martin Baulig <martin@ximian.com>
20870 * class.cs (TypeManager.DefineType): When defining a nested type,
20871 call DefineType() on our parent; fixes #47801.
20873 2003-08-22 Martin Baulig <martin@ximian.com>
20875 * class.cs (MethodData.Define): While checking if a method is an
20876 interface implementation, improve the test a bit more to fix #47654.
20878 2003-08-22 Martin Baulig <martin@ximian.com>
20880 * expression.cs (Probe.DoResolve): Check whether `expr' resolved
20881 correctly; fixes #47722.
20883 2003-08-22 Martin Baulig <martin@ximian.com>
20885 * expression.cs (UnaryMutator.ResolveVariable): If the target is a
20886 LocalVariableReference, ensure it's not read-only. Fixes #47536.
20888 * statement.cs (Fixed.DoResolve): Make all variables read-only.
20890 2003-08-22 Martin Baulig <martin@ximian.com>
20892 * ecore.cs (FieldExpr.DoResolveLValue): Static read-only fields
20893 can only be assigned in static constructors. Fixes #47161.
20895 2003-08-22 Martin Baulig <martin@ximian.com>
20897 Rewrote and improved the flow analysis code.
20899 * flowbranching.cs (FlowBranching): Make this class abstract.
20900 (FlowBranching.CreateBranching): New static function to create a
20901 new flow branching.
20902 (FlowBranchingBlock, FlowBranchingException): New classes.
20903 (FlowBranching.UsageVector.Type): New public readonly field.
20904 (FlowBranching.UsageVector.Breaks): Removed the setter.
20905 (FlowBranching.UsageVector.Returns): Removed the setter.
20906 (FlowBranching.UsageVector): Added Break(), Return(),
20907 NeverReachable() and Throw() methods to modify the reachability.
20908 (FlowBranching.UsageVector.MergeChildren): Removed, this is now
20909 done by FlowBranching.Merge().
20910 (FlowBranching.UsageVector.MergeChild): New method; merges the
20911 merge result into the current vector.
20912 (FlowBranching.Merge): New abstract method to merge a branching.
20914 2003-08-12 Martin Baulig <martin@ximian.com>
20916 * expression.cs (Indirection.CacheTemporaries): Create the
20917 LocalTemporary with the pointer type, not its element type.
20919 2003-08-10 Miguel de Icaza <miguel@ximian.com>
20921 * cs-parser.jay: FIRST_KEYWORD, LAST_KEYWORD: used to know if a
20922 token was a keyword or not.
20924 Add `error' options where an IDENTIFIER was expected; Provide
20925 CheckToken and CheckIdentifierToken convenience error reporting
20928 Do not use `DeclSpace.Namespace', use `DeclSpace.NamespaceEntry'.
20930 * decl.cs: Rename `NamespaceEntry Namespace' public field into
20931 NameSpaceEntry NameSpaceEntry.
20933 (LookupInterfaceOrClass): Avoid creating a full qualified name
20934 from namespace and name: avoid doing lookups when we know the
20935 namespace is non-existant. Use new Tree.LookupByNamespace which
20936 looks up DeclSpaces based on their namespace, name pair.
20938 * driver.cs: Provide a new `parser verbose' to display the
20939 exception thrown during parsing. This is turned off by default
20940 now, so the output of a failure from mcs is more graceful.
20942 * namespace.cs: Track all the namespaces defined in a hashtable
20945 (IsNamespace): New method
20947 2003-08-09 Miguel de Icaza <miguel@ximian.com>
20949 * namespace.cs: Remove redundant call; Avoid using MakeFQN when
20950 we know that we need to concatenate (full typename can never be
20955 * statement.cs: Use a bitfield; Do not initialize to null things
20956 which are done by the constructor by default.
20958 * cs-parser.jay: bug fix, parameter was 4, not 3.
20960 * expression.cs: Just use the property;
20962 * statement.cs: No need for GetVariableInfo method.
20964 2003-08-08 Martin Baulig <martin@ximian.com>
20966 * flowanalysis.cs (FlowReturns): This is now nested in the
20967 `FlowBranching' class.
20968 (MyBitVector): Moved this here from statement.cs.
20969 (FlowBranching.SiblingType): New enum type.
20970 (FlowBranching.CreateSibling): Added `SiblingType' argument.
20972 2003-08-07 Martin Baulig <martin@ximian.com>
20974 * flowanalysis.cs (FlowBranchingType): This is now nested in the
20975 `FlowBranching' class and called `BranchingType'.
20977 2003-08-07 Martin Baulig <martin@ximian.com>
20979 * flowanalysis.cs: Moved all the control flow analysis code into
20982 2003-08-07 Martin Baulig <martin@ximian.com>
20984 * assign.cs (Assign.DoResolve): `target' must either be an
20985 IAssignMethod or an EventAccess; report a CS0131 otherwise. Fixes
20988 2003-08-07 Miguel de Icaza <miguel@ximian.com>
20990 * expression.cs (BinaryMethod): This kind of expression is created by the
20991 Binary class if it determines that the operator has to be handled
20994 (BinaryDelegate): This kind of expression is created if we are
20995 dealing with a + or - operator on delegates.
20997 (Binary): remove method, argumetns, and DelegateOperator: when
20998 dealing with methods,
21000 * ecore.cs (EventExpr.EmitAddOrRemove): Update to new layout.
21002 * statement.cs (Block): use bitfields for the three extra booleans
21003 we had in use. Remove unused topblock parameter.
21005 * codegen.cs: Remove unecessary argument to Block.EmitTopBlock
21007 * assign.cs: Drop extra unneeded tests.
21009 2003-08-06 Miguel de Icaza <miguel@ximian.com>
21011 * iterators.cs (Mapvariable): provide a mechanism to use prefixes.
21013 * statement.cs (Foreach): Use VariableStorage instead of
21016 * codegen.cs (VariableStorage): New class used by clients that
21017 require a variable stored: locals or fields for variables that
21018 need to live across yield.
21020 Maybe provide a convenience api for EmitThis+EmitLoad?
21022 (GetTemporaryLocal, FreeTemporaryLocal): Recycle
21025 2003-08-05 Miguel de Icaza <miguel@ximian.com>
21027 * codegen.cs (RemapLocal, RemapLocalLValue, RemapParameter,
21028 RemapParameterLValue): New methods that are used to turn a
21029 precomputed FieldInfo into an expression like this:
21033 The idea is to use this instead of making LocalVariableReference
21034 have more than one meaning.
21036 * cs-parser.jay: Add error production to BASE.
21038 * ecore.cs: Deal with TypeManager.GetField returning null, which
21039 is now a valid return value.
21041 (FieldExprNoAddress): New expression for Fields whose address can
21044 * expression.cs (LocalVariableReference): During the resolve
21045 phases, create new expressions if we are in a remapping context.
21046 Remove code that dealt with remapping here.
21048 (ParameterReference): same.
21050 (ProxyInstance): New expression, like the `This' expression, but
21051 it is born fully resolved. We know what we are doing, so remove
21052 the errors that are targeted to user-provided uses of `this'.
21054 * statement.cs (Foreach): our variable is now stored as an
21055 Expression; During resolution, follow the protocol, dont just
21056 assume it will return this.
21058 2003-08-06 Martin Baulig <martin@ximian.com>
21060 * support.cs (SeekableStreamReader.cs): New public class.
21062 * cs-tokenizer.cs, cs-parser.jay, driver.cs: Use the new
21063 SeekableStreamReader instead of the normal StreamReader.
21065 2003-08-04 Martin Baulig <martin@ximian.com>
21067 * cs-parser.jay (CLOSE_PARENS_CAST, CLOSE_PARENS_NO_CAST,
21068 CLOSE_PARENS_OPEN_PARENS, CLOSE_PARENS_MINUS): New tokens to
21069 deambiguate casts and delegate invocations.
21070 (parenthesized_expression): Use the new tokens to ensure this is
21071 not a cast of method invocation.
21073 * cs-tokenizer.cs (is_punct): Return one of the new special tokens
21074 when reading a `)' and Deambiguate_CloseParens () was previously
21077 * expression.cs (ParenthesizedExpression): New class. This is
21078 just used for the CS0075 test.
21079 (Binary.DoResolve): Check for CS0075.
21081 2003-07-29 Ravi Pratap <ravi@ximian.com>
21083 * expression.cs (Invocation.MakeUnionSet): Patch from Lluis
21084 Sanchez : use TypeManager.ArrayContainsMethod instead of a direct
21085 reference comparison.
21087 (TypeManager.ArrayContainsMethod): When we have a MethodInfo, also
21088 examine the ReturnType for equality - this is necessary in the
21089 cases of implicit and explicit operators whose signature also
21090 includes the return type.
21092 2003-07-26 Miguel de Icaza <miguel@ximian.com>
21094 * namespace.cs: Cache the result of the namespace computation,
21095 instead of computing it every time.
21097 2003-07-24 Miguel de Icaza <miguel@ximian.com>
21099 * decl.cs: Use a global arraylist that we reuse over invocations
21100 to avoid excesive memory consumption. Reduces memory usage on an
21101 mcs compile by one meg (45 average).
21103 * typemanager.cs (LookupTypeReflection): In .NET pointers are
21104 private, work around that.
21106 2003-07-23 Miguel de Icaza <miguel@ximian.com>
21108 * literal.cs (IntLiteral): Define Zero and One static literals.
21110 * cs-parser.jay (integer_literal): use static literals to reduce
21111 memory usage for the most used literals (0, 1 and -1). 211kb
21112 reduced in memory usage.
21114 Replace all calls to `new ArrayList' with `new
21115 ArrayList(4)' which is a good average number for most allocations,
21116 and also requires only 16 bytes of memory for its buffer by
21119 This reduced MCS memory usage in seven megabytes for the RSS after
21122 2003-07-28 Ravi Pratap <ravi@ximian.com>
21124 * expression.cs (Invocation.OverloadResolve): Fix the algorithm to
21125 handle params methods the correct way by forming only one
21126 applicable set with params and normal methods in them. Earlier we
21127 were looking at params methods only if we found no normal methods
21128 which was not the correct thing to do.
21130 (Invocation.BetterFunction): Take separate arguments indicating
21131 when candidate and the best method are params methods in their
21134 This fixes bugs #43367 and #46199.
21136 * attribute.cs: Documentation updates.
21138 (CheckAttribute): Rename to CheckAttributeTarget.
21139 (GetValidPlaces): Rename to GetValidTargets.
21141 * expression.cs (Invocation.IsParamsMethodApplicable): Fix trivial
21142 bug - use Convert.ImplicitConversion, not ImplicitUserConversion!
21146 2003-07-28 Martin Baulig <martin@ximian.com>
21148 * class.cs (TypeContainer.DefineMembers): Use the base type's full
21149 name when looking up the base class of a nested class. Fixes #46977.
21151 2003-07-26 Martin Baulig <martin@ximian.com>
21153 * expression.cs (Indexers.Indexer): New nested struct; contains
21154 getter, setter and the indexer's type.
21155 (Indexers.Properties): This is now an ArrayList of
21156 Indexers.Indexer's.
21157 (IndexerAccess.DoResolveLValue): Correctly set the type if the
21158 indexer doesn't have any getters.
21160 * assign.cs (Assign.DoResolve): Also do the implicit conversions
21161 for embedded property and indexer assignments.
21163 2003-07-26 Martin Baulig <martin@ximian.com>
21165 * cs-tokenizer.cs (Tokenizer.xtoken): Report a CS1040 if a
21166 preprocessor directive is not the first non-whitespace character
21169 2003-07-26 Martin Baulig <martin@ximian.com>
21171 * namespace.cs (NamespaceEntry.Lookup): New method; rewrote the
21172 namespace parsing, follow the spec more closely.
21174 * rootcontext.cs (RootContext.NamespaceLookup): Use the new
21175 NamespaceEntry.Lookup().
21177 2003-07-25 Martin Baulig <martin@ximian.com>
21179 * MethodCore.cs (OverridesSomething): New public field; it's set
21180 from TypeContainer.DefineMembers if this method overrides
21181 something (which doesn't need to be a method). Fix #39462.
21183 2003-07-25 Ravi Pratap <ravi@ximian.com>
21185 * typemanager.cs (GetMembers): Ensure that the list of members is
21186 reversed. This keeps things in sync.
21188 * attribute.cs (Attribute.CheckAttribute): Break as soon as we
21189 find an AttributeUsage attribute.
21191 * expression.cs (Invocation.OverloadResolve): Perform the check
21192 which disallows Invoke to be directly called on a Delegate.
21194 (Error_InvokeOnDelegate): Report error cs1533.
21196 2003-07-25 Martin Baulig <martin@ximian.com>
21198 * expression.cs (Indexers.GetIndexersForType): Only look in the
21199 interface hierarchy if the requested type is already an
21200 interface. Fixes #46788 while keeping #46502 fixed.
21202 2003-07-25 Martin Baulig <martin@ximian.com>
21204 * class.cs (TypeContainer.DefineMembers): Check whether all
21205 readonly fields have been assigned and report warning CS0649 if
21208 * statement.cs (LocalInfo.IsFixed): Always return true if this is
21211 2003-07-24 Ravi Pratap <ravi@ximian.com>
21213 * decl.cs (MemberCache.AddMethods): Reverse the order of the array
21214 returned from GetMethods to make things consistent with the
21215 assumptions MCS makes about ordering of methods.
21217 This should comprehensively fix bug #45127 and it does :-)
21219 * ecore.cs (MethodGroupExpr.DeclaringType): Correct bug - the
21220 ordering is actually reverse.
21222 * Clean up some debug messages I left lying around.
21224 * interface.cs (Populate*): Get rid of code which emits attributes
21225 since the stage in which we emit attributes is the 'Emit' stage,
21226 not the define stage.
21228 (Emit): Move attribute emission for interface members here.
21230 2003-07-22 Ravi Pratap <ravi@ximian.com>
21232 * expression.cs (Invocation.OverloadResolve): Follow the spec more
21233 closely: we eliminate methods in base types when we have an
21234 applicable method in a top-level type.
21236 Please see section 14.5.5.1 for an exact description of what goes
21239 This fixes bug #45127 and a host of other related to corlib compilation.
21241 * ecore.cs (MethodGroupExpr.DeclaringType): The element in the
21242 array is the method corresponding to the top-level type (this is
21243 because of the changes made to icall.c) so we change this
21246 (MethodGroupExpr.Name): This too.
21248 * typemanager.cs (GetElementType): New method which does the right
21249 thing when compiling corlib.
21251 * everywhere: Make use of the above in the relevant places.
21253 2003-07-22 Martin Baulig <martin@ximian.com>
21255 * cs-parser.jay (invocation_expression): Moved
21256 `OPEN_PARENS expression CLOSE_PARENS unary_expression' here from
21257 `cast_expression', but create a InvocationOrCast which later
21258 resolves to either an Invocation or a Cast.
21260 * ecore.cs (ExpressionStatement.ResolveStatement): New virtual
21261 method; call this before EmitStatement() to make sure that this
21262 expression can be used as a statement.
21264 * expression.cs (InvocationOrCast): New class; resolves to either
21265 an Invocation or a Cast.
21267 * statement.cs (StatementExpression): Call ResolveStatement() on
21268 the ExpressionStatement before emitting it.
21270 2003-07-21 Martin Baulig <martin@ximian.com>
21272 * expression.cs (Invocation.VerifyArgumentsCompat): Check whether
21273 `ref' and `out' attributes match; fixes #46220.
21274 (MemberAccess.ResolveMemberAccess): You can't reference a type
21275 through an expression; fixes #33180.
21276 (Indexers.GetIndexersForType): Don't return the indexers from
21277 interfaces the class implements; fixes #46502.
21279 2003-07-21 Martin Baulig <martin@ximian.com>
21281 * class.cs (TypeContainer.CheckPairedOperators): Added CS0660 and
21282 CS0661 checks; fixes bug #30442.
21284 2003-07-21 Martin Baulig <martin@ximian.com>
21286 * decl.cs (AdditionResult): Added `Error'.
21288 * enum.cs (AddEnumMember): Report a CS0076 if name is `value__'.
21290 * typemanager.cs (TypeManager.ChangeType): Catch exceptions;
21291 makes cs0031.cs actually work.
21293 2003-07-20 Martin Baulig <martin@ximian.com>
21295 * namespace.cs: Fixed that bug which caused a crash when compiling
21296 the debugger's GUI.
21298 2003-07-20 Miguel de Icaza <miguel@ximian.com>
21300 * typemanager.cs (LookupTypeReflection): Never expose types which
21301 are NotPublic, NestedPrivate, NestedAssembly, or
21302 NestedFamANDAssem. We used to return these, and later do a check
21303 that would report a meaningful error, but the problem is that we
21304 would not get the real match, if there was a name override.
21306 2003-07-18 Miguel de Icaza <miguel@ximian.com>
21308 * namespace.cs (Namespace, Name): Do not compute the namespace
21309 name dynamically, compute it in the constructor. This reduced
21310 memory usage by 1697 KB.
21312 * driver.cs: Use --pause to pause at the end.
21314 2003-07-17 Peter Williams <peter@newton.cx>
21316 * Makefile: Change the name of the test target so that it doesn't
21317 conflict with the recursive test target.
21319 2003-07-17 Miguel de Icaza <miguel@ximian.com>
21321 * expression.cs (LocalVariableReference.Emit, EmitAssign,
21322 AddressOf): Do not use EmitThis, that was wrong, use the actual
21325 2003-07-15 Miguel de Icaza <miguel@ximian.com>
21327 * class.cs (MethodData.Define): While checking if a method is an
21328 interface implementation, improve the test: If we are not public
21329 (use new test here: use the computed MethodAttributes directly,
21330 instead of the parsed modifier flags) check if the `implementing'
21331 method comes from an interface or not.
21333 * pending.cs (VerifyPendingMethods): Slightly better error
21336 * makefile: add test target that does the mcs bootstrap.
21338 2003-07-16 Ravi Pratap <ravi@ximian.com>
21340 * interface.cs (Define): Do nothing here since there are no
21341 members to populate etc. Move the attribute emission out of here
21342 since this was just totally the wrong place to put it. Attribute
21343 application happens during the 'Emit' phase, not in the 'Define'
21346 (Emit): Add this method and move the attribute emission here
21348 * rootcontext.cs (EmitCode): Call the Emit method on interface
21351 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21353 * expression.cs (OverloadResolve): Report error only if Location
21354 is not 'Null' which means that there was a probe going on.
21356 2003-07-14 Martin Baulig <martin@ximian.com>
21358 * expression.cs (ConditionalLogicalOperator): New public class to
21359 implement user defined conditional logical operators.
21360 This is section 14.11.2 in the spec and bug #40505.
21362 2003-07-14 Martin Baulig <martin@ximian.com>
21364 * ecore.cs (FieldExpr.DoResolveLValue): Fixed bug #46198.
21366 2003-07-14 Martin Baulig <martin@ximian.com>
21368 * codegen.cs (EmitContext.InFixedInitializer): New public field.
21370 * ecore.cs (IVariable.VerifyFixed): New interface method.
21372 * expression.cs (Unary.ResolveOperator): When resolving the `&'
21373 operator, check whether the variable is actually fixed. Fixes bug
21374 #36055. Set a variable definitely assigned when taking its
21375 address as required by the spec.
21377 * statement.cs (LocalInfo.IsFixed): New field.
21378 (LocalInfo.MakePinned): Set `IsFixed' to true.
21380 2003-07-14 Ravi Pratap M <ravi@ximian.com>
21382 * attribute.cs (Attribute.Resolve): While doing a Member lookup
21383 for .ctors, ensure that we only ask for members declared in the
21384 attribute type (BindingFlags.DeclaredOnly).
21388 * expression.cs (Error_WrongNumArguments): Report error 1501
21389 correctly the way CSC does.
21391 2003-07-13 Martin Baulig <martin@ximian.com>
21393 * expression.cs (MemberAccess.ResolveAsTypeStep): Try to do a type
21394 lookup on the fully qualified name, to make things like "X.X" work
21395 where "X.X" is a fully qualified type name, but we also have a
21396 namespace "X" in the using list. Fixes #41975.
21398 2003-07-13 Martin Baulig <martin@ximian.com>
21400 * assign.cs (Assign.GetEmbeddedAssign): New protected virtual
21401 function. If we're a CompoundAssign, we need to create an embedded
21402 CompoundAssign, not an embedded Assign.
21403 (Assign.DoResolve): Make this work for embedded CompoundAssign's.
21406 2003-07-13 Martin Baulig <martin@ximian.com>
21408 * typemanager.cs (TypeManager.IsNestedChildOf): Make this actually
21409 work to fix bug #46088.
21411 2003-07-13 Ravi Pratap <ravi@ximian.com>
21413 * class.cs (Operator.Emit): Do not emit attributes here - it is
21414 taken care of by the Method class that we delegate too. This takes
21415 care of bug #45876.
21417 2003-07-10 Martin Baulig <martin@ximian.com>
21419 * expression.cs (TypeOfVoid): New class.
21420 (TypeOf): Report a CS0673 if it's System.Void. Fixes #42264.
21422 2003-07-10 Martin Baulig <martin@ximian.com>
21424 * class.cs (MethodCore.DoDefineParameters): Added CS0225 check;
21427 2003-07-10 Martin Baulig <martin@ximian.com>
21429 * rootcontext.cs (RootContext.NamespaceLookup): Take a DeclSpace,
21430 not a NamespaceEntry, so we can use DeclSpace.CheckAccessLevel().
21432 * decl.cs (DeclSpace.FindType): Use DeclSpace.CheckAccessLevel().
21434 * typemanager.cs (TypeManager.IsAccessibleFrom): Removed.
21436 2003-07-10 Martin Baulig <martin@ximian.com>
21438 * expression.cs (ArrayCreation): Don't use a byte blob for arrays
21439 of decimal. Fixes #42850.
21441 NOTE: I also fixed the created byte blob, but this doesn't work on
21442 the MS runtime and csc never produces any byte blobs for decimal
21445 2003-07-10 Martin Baulig <martin@ximian.com>
21447 * statement.cs (StructInfo.GetStructInfo): Catch deep cycles in
21448 structs; fixes #32068.
21449 (Block.AddChildVariableNames): Fixed #44302.
21451 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21453 * namespace.cs: fixed compilation with csc. It's bugzilla #44302.
21455 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21457 * attribute.cs: And this test is onger needed.
21459 2003-07-08 Martin Baulig <martin@ximian.com>
21461 * rootcontext.cs (RootContext.NamespaceLookup): Ignore
21462 inaccessible types. Fixes #36313.
21464 * decl.cs (DeclSpace.FindType): Ignore inaccessible types.
21466 * namespace.cs (NamespaceEntry): Create implicit entries for all
21467 namespaces; ie. if we have `namespace N1.N2.N3 { ... }', we create
21468 implicit entries for N1.N2 and N1.
21470 2003-07-08 Martin Baulig <martin@ximian.com>
21472 Rewrote the handling of namespaces to fix a lot of the issues
21473 wrt. `using' aliases etc.
21475 * namespace.cs (Namespace): Splitted this class into a
21476 per-assembly `Namespace' and a per-file `NamespaceEntry'.
21478 * typemanager.cs (TypeManager.IsNamespace): Removed.
21479 (TypeManager.ComputeNamespaces): Only compute namespaces from
21480 loaded assemblies here, not the namespaces from the assembly we're
21481 currently compiling.
21483 2003-07-08 Martin Baulig <martin@ximian.com>
21485 * rootcontext.cs, class.cs: Fixed the CS1530 reporting.
21487 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21489 * typemanager.cs: Reverted patch from Gonzalo, my previous patch
21492 I thought about the memory savings here, but LookupTypeReflection
21493 is used under already very constrained scenarios. Compiling
21494 corlib or mcs only exposes one hit, so it would not really reduce
21495 any memory consumption.
21497 2003-07-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
21499 * typemanager.cs: fixes bug #45889 by only adding public types from
21500 other assemblies to the list of known types.
21502 2003-07-07 Miguel de Icaza <miguel@ximian.com>
21504 * attribute.cs (Attribute.Resolve): Add call to CheckAccessLevel
21505 on the type we resolved.
21507 2003-07-05 Martin Baulig <martin@ximian.com>
21509 * pending.cs (PendingImplementation.ParentImplements): Don't
21510 create the proxy if the parent is abstract.
21512 * class.cs (TypeContainer.DefineIndexers): Process explicit
21513 interface implementations first. Fixes #37714.
21515 2003-07-04 Miguel de Icaza <miguel@ximian.com>
21517 * expression.cs (MemberAccess.ResolveMemberAccess): Events are
21518 defined recursively; but since we modify the input parameters
21519 (left is set to `this' temporarily), we reset this value if the
21520 left_is_explicit is false, which gives the original semantics to
21523 * literal.cs (NullPointer): new class used to represent a null
21524 literal in a pointer context.
21526 * convert.cs (Convert.ImplicitReferenceConversion): Is the target
21527 type is a pointer, use a NullPointer object instead of a
21528 NullLiteral. Closes 43687
21530 (ExplicitConversion): Convert pointer values using
21531 the conv opcode to the proper type.
21533 * ecore.cs (New): change ValueTypeVariable property into a method,
21534 that returns whether the valuetype is suitable for being used.
21536 * expression.cs (Binary.DoNumericPromotions): Only return if we
21537 the int constant was a valid uint, and we can return both left and
21538 right as uints. If not, we continue processing, to trigger the
21539 type conversion. This fixes 39018.
21541 * statement.cs (Block.EmitMeta): During constant resolution, set
21542 the CurrentBlock property on the emitcontext, so that we resolve
21543 constants propertly.
21545 2003-07-02 Martin Baulig <martin@ximian.com>
21547 * codegen.cs (EmitContext.NeedExplicitReturn): New public variable.
21548 (EmitContext.EmitTopBlock): Emit an explicit return if it's set.
21550 * statement.cs (Try.Resolve): Set ec.NeedExplicitReturn rather
21551 than emitting it here.
21553 * statement.cs: Fixed some more flow analysis bugs.
21555 2003-07-02 Martin Baulig <martin@ximian.com>
21557 * class.cs (MethodData.Define): When implementing interface
21558 methods, set Final unless we're Virtual.
21560 * decl.cs (MemberCore.CheckMethodAgainstBase): Make the CS0506
21561 check work for interface methods.
21563 2003-07-01 Martin Baulig <martin@ximian.com>
21565 * ecore.cs (EmitContext.This): Replaced this property with a
21566 GetThis() method which takes a Location argument. This ensures
21567 that we get the correct error location for a CS0188.
21569 2003-07-01 Miguel de Icaza <miguel@ximian.com>
21571 * ecore.cs: (Convert.ConvertIntLiteral): Add test for
21572 ImplicitStandardConversion.
21574 * class.cs (TypeContainer.GetClassBases): Small bug fix for 45649.
21576 2003-07-01 Zoltan Varga <vargaz@freemail.hu>
21578 * expression.cs (ResolveOperator): Fix Concat (string, string, string)
21581 2003-06-30 Miguel de Icaza <miguel@ximian.com>
21583 * class.cs (Constructor.Define): Turn off initlocals for unsafe
21586 (MethodData.Define): Turn off initlocals for unsafe methods.
21588 2003-06-29 Miguel de Icaza <miguel@ximian.com>
21590 * decl.cs (DeclSpace.CheckAccessLevel): Make this routine
21591 complete; Fixes #37521.
21593 * delegate.cs: Use Modifiers.TypeAttr to compute the
21594 TypeAttributes, instead of rolling our own. This makes the flags
21595 correct for the delegates.
21597 2003-06-28 Miguel de Icaza <miguel@ximian.com>
21599 * class.cs (Constructor.Define): Set the private flag for static
21600 constructors as well.
21602 * cs-parser.jay (statement_expression): Set the return value to
21603 null, to avoid a crash when we catch an error.
21605 2003-06-24 Miguel de Icaza <miguel@ximian.com>
21607 * cs-parser.jay: Applied patch from Jackson that adds support for
21608 extern and unsafe modifiers to destructor declarations.
21610 * expression.cs: Report error 21 if the user is trying to index a
21613 * driver.cs: Add an error message, suggested by the bug report.
21615 * class.cs (TypeContainer.Emit): Only call EmitFieldInitializers
21616 if we do not have a ": this ()" constructor initializer. Fixes 45149
21618 2003-06-14 Miguel de Icaza <miguel@ximian.com>
21620 * namespace.cs: Add some information to reduce FAQs.
21622 2003-06-13 Miguel de Icaza <miguel@ximian.com>
21624 * cfold.cs (BinaryFold): BitwiseAnd, BitwiseOr: handle other
21625 underlying enumeration types. Fixes #43915.
21627 * expression.cs: Treat ushort/short as legal values to be used in
21628 bitwise operations.
21630 Wed Jun 4 13:19:04 CEST 2003 Paolo Molaro <lupus@ximian.com>
21632 * delegate.cs: transfer custom attributes for paramenters from
21633 the delegate declaration to Invoke and BeginInvoke.
21635 Tue Jun 3 11:11:08 CEST 2003 Paolo Molaro <lupus@ximian.com>
21637 * attribute.cs: handle custom marshalers and emit marshal info
21640 2003-05-28 Hector E. Gomez Morales <hgomez_36@flashmail.com>
21642 * makefile.gnu: Added anonymous.cs to the compiler sources.
21644 2003-05-28 Miguel de Icaza <miguel@ximian.com>
21646 * iterators.cs: Change the name of the proxy class to include two
21649 * cs-parser.jay: Update grammar to include anonymous methods.
21651 * anonymous.cs: new file.
21653 2003-05-27 Miguel de Icaza <miguel@ximian.com>
21655 * class.cs (Field.Define): Add missing test for pointers and
21658 2003-05-27 Ravi Pratap <ravi@ximian.com>
21660 * expression.cs (ArrayAccess.GetStoreOpCode): For System.IntPtr,
21661 we use the stobj opcode.
21663 (ArrayCreation.EmitDynamicInitializers): Revert Miguel's patch
21664 since it wasn't the correct fix.
21666 It still is puzzling that we are required to use stobj for IntPtr
21667 which seems to be a ValueType.
21669 2003-05-26 Miguel de Icaza <miguel@ximian.com>
21671 * ecore.cs (SimpleName.SimpleNameResolve): Consider using aliases
21672 during regular simple name resolution. Now, the trick is that
21673 instead of returning for processing the simplename, we do a
21674 TypeManager.LookupType (ie, a rooted lookup as opposed to a
21675 contextual lookup type). If a match is found, return that, if
21676 not, return for further composition.
21678 This fixes long-standing 30485.
21680 * expression.cs (ArrayCreation.EmitDynamicInitializers): When
21681 using the address to initialize an object, do an Stobj instead of
21682 using the regular Stelem.
21684 (IndexerAccess.Emit, IndexerAccess.EmitAssign):
21685 Pass `is_base_indexer' to Invocation.EmitCall instead of false.
21686 Because if we are a BaseIndexerAccess that value will be true.
21689 * statement.cs (GotoCase.Resolve): Return after reporting an
21690 error, do not attempt to continue.
21692 * expression.cs (PointerArithmetic.Emit): If our operand is a
21693 long, convert our constants to match the operand before
21694 multiplying. Convert to I type before adding. Fixes 43670.
21696 2003-05-14 Ravi Pratap <ravi@ximian.com>
21698 * enum.cs (ImplicitConversionExists) : Rename to
21699 ImplicitEnumConversionExists to remove ambiguity.
21701 * ecore.cs (NullCast): New type of cast expression class which
21702 basically is very similar to EmptyCast with the difference being
21703 it still is a constant since it is used only to cast a null to
21705 (eg. (string) null)
21707 * convert.cs (ImplicitReferenceConversion): When casting a null
21708 literal, we return a NullCast.
21710 * literal.cs (NullLiteralTyped): Remove - I don't see why this
21711 should be around anymore.
21713 The renaming (reported was slightly wrong). Corrections:
21715 ConvertImplicitStandard -> ImplicitConversionStandard
21716 ConvertExplicitStandard -> ExplicitConversionStandard
21718 * expression.cs (StaticCallExpr.MakeSimpleCall): Resolve arguments
21719 before passing them in !
21721 * convert.cs (ImplicitConversionStandard): When comparing for
21722 equal expr and target types, ensure that expr is not a
21725 In general, we must not be checking (expr_type ==
21726 target_type) in the top level conversion methods
21727 (ImplicitConversion, ExplicitConversion etc). This checking is
21728 done in the methods that they delegate to.
21730 2003-05-20 Miguel de Icaza <miguel@ximian.com>
21732 * convert.cs: Move Error_CannotConvertType,
21733 ImplicitReferenceConversion, ImplicitReferenceConversionExists,
21734 ImplicitNumericConversion, ImplicitConversionExists,
21735 ImplicitUserConversionExists, StandardConversionExists,
21736 FindMostEncompassedType, FindMostSpecificSource,
21737 FindMostSpecificTarget, ImplicitUserConversion,
21738 ExplicitUserConversion, GetConversionOperators,
21739 UserDefinedConversion, ConvertImplicit, ConvertImplicitStandard,
21740 TryImplicitIntConversion, Error_CannotConvertImplicit,
21741 ConvertImplicitRequired, ConvertNumericExplicit,
21742 ExplicitReferenceConversionExists, ConvertReferenceExplicit,
21743 ConvertExplicit, ConvertExplicitStandard from the ecore.cs into
21746 Perform the following renames:
21748 StandardConversionExists -> ImplicitStandardConversionExists
21749 ConvertImplicit -> ImplicitConversion
21750 ConvertImplicitStandard -> ImplicitStandardConversion
21751 TryImplicitIntConversion -> ImplicitIntConversion
21752 ConvertImplicitRequired -> ImplicitConversionRequired
21753 ConvertNumericExplicit -> ExplicitNumericConversion
21754 ConvertReferenceExplicit -> ExplicitReferenceConversion
21755 ConvertExplicit -> ExplicitConversion
21756 ConvertExplicitStandard -> ExplicitStandardConversion
21758 2003-05-19 Martin Baulig <martin@ximian.com>
21760 * statement.cs (TypeInfo.StructInfo): Made this type protected.
21761 (TypeInfo): Added support for structs having structs as fields.
21763 * ecore.cs (FieldExpr): Implement IVariable.
21764 (FieldExpr.DoResolve): Call VariableInfo.GetSubStruct() to get the
21765 VariableInfo for the field.
21767 2003-05-18 Martin Baulig <martin@ximian.com>
21769 * expression.cs (This.DoResolve): Report a CS0027 if we're
21770 emitting a field initializer.
21772 2003-05-18 Martin Baulig <martin@ximian.com>
21774 * expression.cs (This.ResolveBase): New public function.
21775 (This.DoResolve): Check for CS0188.
21777 * codegen.cs (EmitContext.This): Just call This.ResolveBase(), not
21780 * ecore.cs (MethodGroupExpr.DoResolve): Set the
21781 `instance_expression' to null if we don't have any non-static
21784 2003-05-18 Martin Baulig <martin@ximian.com>
21786 Reworked the way how local variables and parameters are handled by
21787 the flow analysis code.
21789 * statement.cs (TypeInfo, VariableMap): New public classes.
21790 (VariableInfo): New public class. This is now responsible for
21791 checking whether a variable has been assigned. It is used for
21792 parameters and local variables.
21793 (Block.EmitMeta): Take the InternalParameters as argument; compute
21794 the layout of the flow vectors here.
21795 (Block.LocalMap, Block.ParameterMap): New public properties.
21796 (FlowBranching): The .ctor doesn't get the InternalParameters
21797 anymore since Block.EmitMeta() now computes the layout of the flow
21799 (MyStructInfo): This class is now known as `StructInfo' and nested
21800 in `TypeInfo'; we don't access this directly anymore.
21802 * ecore.cs (IVariable): Added `VariableInfo VariableInfo'
21803 property and removed IsAssigned(), IsFieldAssigned(),
21804 SetAssigned() and SetFieldAssigned(); we now call them on the
21805 VariableInfo so we don't need to duplicate this code everywhere.
21807 * expression.cs (ParameterReference): Added `Block block' argument
21809 (LocalVariableReference, ParameterReference, This): The new
21810 VariableInfo class is now responsible for all the definite
21813 * codegen.cs (EmitContext.IsVariableAssigned, SetVariableAssigned,
21814 IsParameterAssigned, SetParameterAssigned): Removed.
21816 2003-05-18 Martin Baulig <martin@ximian.com>
21818 * typemanager.cs (InitCoreTypes): Try calling
21819 SetCorlibTypeBuilders() with 4 args; if that fails, fall back to
21820 the 3-args-version. Corlib now also needs our `void_type'.
21821 (GetMethod): Added overloaded version which takes an optional
21822 `bool report_errors' to allow lookups of optional methods.
21824 2003-05-12 Martin Baulig <martin@ximian.com>
21826 * statement.cs (VariableInfo): Renamed to LocalInfo since it's
21827 only used for locals and not for parameters.
21829 2003-05-12 Miguel de Icaza <miguel@ximian.com>
21831 * support.cs (InternalParameters.ParameterType): Return the
21832 ExternalType of the parameter.
21834 * parameter.cs (Parameter.ExternalType): drop the two arguments,
21837 2003-05-11 Miguel de Icaza <miguel@ximian.com>
21839 * class.cs (MethodData.Define): Do not set the `newslot' on
21840 interface members, if they are also flagged as "override".
21842 * expression.cs (UnaryMutator.EmitCode): Simple workaround to emit
21843 better code for ++i and i++. This only works for static fields
21844 and local variables.
21846 * typemanager.cs (LookupDeclSpace): Add new method, sometimes we
21847 want to pull the DeclSpace out of the builder_to_declspace instead
21848 of the TypeBuilder (like in TypeContainer.FindMembers).
21850 * class.cs (TypeContainer.FindMembers): Use LookupDeclSpace
21851 instead of LookupTypeContainer. Fixes the crash on .NET for
21852 looking up interface members.
21854 * const.cs: Create our own emit context during the Definition
21855 stage, so that constants are evaluated in the proper context, when
21856 a recursive definition happens.
21858 2003-05-11 Martin Baulig <martin@ximian.com>
21860 * statement.cs (Block.CreateSwitchBlock): New method. Creates a
21861 new block for a switch section.
21862 (Block.AddLabel, Block.LookupLabel): If we're a switch section, do
21863 the adding/lookup in the switch block. Fixes #39828.
21865 2003-05-09 Miguel de Icaza <miguel@ximian.com>
21867 * expression.cs (UnaryMutator.LoadOneAndEmitOp): Missing
21868 functionality: I needed to convert the data after I had performed
21869 the add/sub operation into the operands type size.
21871 * ecore.cs (ImplicitReferenceConversion): When boxing an interface
21872 pass the type for the box operation, otherwise the resulting
21873 object would have been of type object.
21875 (BoxedCast): Add constructor to specify the type to box as.
21877 2003-05-07 Miguel de Icaza <miguel@ximian.com>
21879 * iterators.cs: I was reusing the `count' variable inadvertently,
21880 take steps to not allow this to happen.
21882 2003-05-06 Miguel de Icaza <miguel@ximian.com>
21884 * attribute.cs (Attribute.Resolve): Params attributes are encoded
21885 by creating an array at the point where the params starts and
21886 putting all those arguments there, then adjusting the size of the
21889 2003-05-05 Miguel de Icaza <miguel@ximian.com>
21891 * expression.cs (New.AddressOf): Implement interface
21892 IMemoryLocation. This is used when the `new' operator is used in
21893 the context of an invocation to a method on a value type.
21895 See http://bugzilla.ximian.com/show_bug.cgi?id=#42390 for an
21898 * namespace.cs: Also check the using aliases here.
21900 * driver.cs: Move the test for using validity after the types have
21901 been entered, so we do a single pass that also includes the using
21904 * statement.cs (Try.Resolve): Avoid crashing if there is a failure
21905 in the regular case. CreateSiblingForFinally is doing extra
21908 * attribute.cs (GetAttributeArgumentExpression): Store the result
21909 on an out value, and use the return value to indicate failure
21910 instead of using null (which is a valid return for Constant.GetValue).
21912 * statement.cs: Perform the analysis flow for the increment
21913 portion after the statement, because this will be the real flow of
21914 execution. Fixes #42385
21916 * codegen.cs (EmitContext.EmitArgument,
21917 EmitContext.EmitStoreArgument): New helper functions when the
21918 RemapToProxy flag is set.
21920 * expression.cs (ParameterReference.EmitLdarg): Expose this useful
21923 Add support for remapping parameters.
21925 * iterators.cs: Propagate parameter values; Store parameter
21926 values in the proxy classes.
21928 2003-05-04 Miguel de Icaza <miguel@ximian.com>
21930 * ecore.cs (FieldExpr): Fix an obvious bug. static fields do not
21931 need a proxy reference; I do not know what I was thinking
21933 * cs-parser.jay (constructor_initializer): catch another error,
21934 and display nice message.
21936 (field_declaration): catch void field declaration
21937 to flag a better error.
21939 * class.cs (MemberBase.CheckBase): Report an error instead of a
21940 warning if a new protected member is declared in a struct.
21941 (Field.Define): catch the error of readonly/volatile.
21943 * ecore.cs (FieldExpr.EmitAssign): reuse the field lookup.
21945 (FieldExpr.AddressOf): ditto. Catch error where the address of a
21946 volatile variable is taken
21948 2003-05-02 Miguel de Icaza <miguel@ximian.com>
21950 * statement.cs (Fixed.Resolve): Report an error if we are not in
21953 2003-05-01 Miguel de Icaza <miguel@ximian.com>
21955 * typemanager.cs: reuse the code that handles type clashes for
21956 delegates and enumerations.
21958 * class.cs (Report28): Always report.
21960 * expression.cs (EncodeAsAttribute): Allow nulls here.
21962 2003-04-28 Miguel de Icaza <miguel@ximian.com>
21964 * attribute.cs (Attribute.GetAttributeArgumentExpression): Moved
21965 the functionality for testing whether an expression is valid for
21966 an attribute here. Also handle the case of arrays of elements
21969 * expression.cs (ArrayCreation.EncodeAsAttribute): Add support for
21970 encoding a linear array into an array of objects that are suitable
21971 to be passed to an CustomAttributeBuilder.
21973 * delegate.cs: Check unsafe types being used outside of an Unsafe context.
21975 * ecore.cs: (FieldExpr): Handle field remapping here.
21977 * iteratators.cs: Pass the instance variable (if the method is an
21978 instance method) to the constructors, so we can access the field
21979 variables on the class.
21981 TODO: Test this with structs. I think the THIS variable on
21982 structs might have to be a pointer, and not a refenrece
21984 2003-04-27 Miguel de Icaza <miguel@ximian.com>
21986 * codegen.cs (EmitContext.Mapvariable): Adds a mechanism to map
21987 local variables to fields in a proxy class.
21989 * iterators.cs (PopulateProxy): Rename our internal fields to
21991 Create a <THIS> field if we are an instance method, so we can
21992 reference our parent container variables.
21993 (MapVariable): Called back from the EmitContext code to enter a
21994 new variable to field mapping into the proxy class (we just create
21998 (LocalVariableReference.{Emit,EmitAssign,AddressOf}): Add support
21999 for using the remapped locals to fields.
22001 I placed the code here, because that gives the same semantics to
22002 local variables, and only changes the Emit code.
22004 * statement.cs (Fixed.Resolve): it is not allowed to have fixed
22005 statements inside iterators.
22006 (VariableInfo): Add a FieldBuilder for the cases when we are
22007 remapping local variables to fields in a proxy class
22009 * ecore.cs (SimpleNameResolve): Avoid testing two times for
22010 current_block != null.
22012 * statement.cs (Swithc.SimpleSwitchEmit): Removed code that did
22013 not cope with strings, as it has been moved to the
22014 TableSwitchEmit. Fixed bug in switch generation.
22016 * expression.cs (New.DoResolve): Provide more context for the user
22017 when reporting an error.
22019 * ecore.cs (Expression.LoadFromPtr): Use ldind_i when loading
22022 * expression.cs (MemberAccess.DoResolve): When we get a type back,
22023 check the permissions for it. Note than in a type-resolution
22024 context the check was already present in DeclSpace.ResolveType,
22025 but was missing from the MemberAccess.
22027 (ArrayCreation.CheckIndices): warn if the user has
22028 more nested levels of expressions, but there are no more
22029 dimensions specified. Avoids crash on bug 41906.
22031 2003-04-26 Miguel de Icaza <miguel@ximian.com>
22033 * statement.cs (Block): replace Implicit bool, for a generic
22035 New flag: `Unchecked'. This is used during the EmitMeta phase
22036 (which is out-of-line with the regular Resolve/Emit process for a
22037 statement, as this is done ahead of time, but still gets a chance
22038 to call constant resolve).
22040 (Block.Flags): new enum for adding a new flag.
22042 (Block.EmitMeta): track the state of unchecked.
22044 (Unchecked): Set the "UnChecked" flags on any blocks we enclose,
22045 to enable constant resolution to work there as well.
22047 2003-04-22 Miguel de Icaza <miguel@ximian.com>
22049 * typemanager.cs (ienumerable_type): Also look up
22050 System.Collections.IEnumerable.
22052 2003-04-21 Miguel de Icaza <miguel@ximian.com>
22054 TODO: Test more than one conditional per method.
22056 * class.cs (Indexer.Define): Report the location where the user is
22057 referencing the unsupported feature.
22059 (MethodData): Overload the use of `conditionals' to
22060 minimize the creation of needless ArrayLists. This saves roughly
22061 212kb on my machine.
22063 (Method): Implement the new IIteratorContainer interface.
22064 (Method.SetYields): Implement the method by setting the ModFlags
22065 to contain METHOD_YIELDS.
22067 * expression.cs (Unary.ResolveOperator): Use expr_type, not Expr,
22068 which just got set to null.
22070 * iterators.cs: New file.
22072 (Yield, YieldBreak): New statements.
22074 * statement.cs (Return.Resolve): Flag an error if we are used in
22075 an iterator method.
22077 * codegen.cs (InIterator): New flag set if the code is being
22078 compiled in an iterator method.
22080 * modifiers.cs: New flag METHOD_YIELDS. This modifier is an
22081 internal modifier, and we just use it to avoid adding extra
22082 fields, as this is seldom used.
22084 * cs-parser.jay: Add yield_statement (yield and yield break).
22086 * driver.cs: New flag -v2 to turn on version 2 features.
22088 * cs-tokenizer.cs (Tokenizer): Add yield and __yield to the
22089 hashtable when v2 is enabled.
22091 2003-04-20 Miguel de Icaza <miguel@ximian.com>
22093 * typemanager.cs (TypeManager.NamespaceClash): Use to check if
22094 there is already a namespace defined with this name.
22096 (TypeManager.InitCoreTypes): Remove the temporary workaround, as
22097 people upgraded their corlibs.
22099 (TypeManager.CoreLookupType): Use LookupTypeDirect, as we
22100 always use fully qualified types, no need to use the compiler
22103 (TypeManager.IsNamespace): Use binarysearch.
22105 * class.cs (AddClass, AddStruct, AddInterface, AddEvent,
22106 AddDelegate): I did not quite use the new IsValid API properly: I
22107 have to pass the short-name and the fullname. I was passing only
22108 the basename instead of the fullname sometimes.
22110 (TypeContainer.DefineType): call NamespaceClash.
22112 * interface.cs (Interface.DefineType): use NamespaceClash before
22115 * delegate.cs (Delegate.DefineType): use NamespaceClash before
22118 * enum.cs: (Enum.DefineType): use NamespaceClash before
22121 * typemanager.cs (: 3-line patch that gives us some tasty 11%
22122 speed increase. First, use the negative_hits cache when we get a
22123 negative. Second, add the type with its full original name
22124 instead of the new . and + encoded name (reflection uses + to
22125 separate type from a nested type). Use LookupTypeReflection
22126 directly which bypasses the type->name hashtable (that we already
22127 know does not contain the type.
22129 * decl.cs (DeclSpace.ResolveTypeExpr): track the
22130 location/container type.
22132 * driver.cs: When passing utf8, use directly the UTF8Encoding.
22134 2003-04-19 Miguel de Icaza <miguel@ximian.com>
22136 * decl.cs (ResolveTypeExpr): Mirror check acess here too.
22138 * delegate.cs (NewDelegate.Resolve): Test whether an instance
22139 method is being referenced in the method group from a static
22140 context, and report error 120 if so.
22142 * expression.cs, ecore.cs (Error_UnexpectedKind): New name for
22145 * typemanager.cs: Add intermediate namespaces (if a namespace A.B
22146 is created, we create the A namespace).
22148 * cs-parser.jay: A namespace also introduces a DeclarationFound.
22151 2003-04-18 Miguel de Icaza <miguel@ximian.com>
22153 * typemanager.cs (GetReferenceType, GetPointerType): In .NET each
22154 invocation to ModuleBuilder.GetType with the same values will
22155 return a new type instance, so we need to cache its return
22158 * expression.cs (Binary.ResolveOperator): Only allow the compare
22159 operators on enums if they are of the same type.
22161 * ecore.cs (Expression.ImplicitReferenceConversion): handle target
22162 types of ValueType on their own case. Before we were giving them
22163 the same treatment as objects.
22165 * decl.cs (DeclSpace.IsValid): IsValid takes the short name and
22166 fullname. Short name is used to compare against container name.
22167 Fullname is used to check against defined namespace names.
22169 * class.cs (AddProperty, AddField, AddClass, AddStruct, AddEnum,
22170 AddDelegate, AddEvent): Pass new parameter to DeclSpace.IsValid
22172 (Method.CheckBase): Call parent.
22173 (MemberBase.CheckBase): Check for protected members on sealed
22175 (PropertyBase.CheckBase): Call parent.
22176 (Field.Define): Call parent.
22178 * report.cs: Negative error codes are now mapped to 8000 - code,
22179 so that the display is render more nicely.
22181 * typemanager.cs: Do not use try/catch, instead report a regular
22184 (GetPointerType, GetReferenceType): These methods provide
22185 mechanisms to obtain the T* and T& from a T. We had the code
22186 previously scattered around the code base, and it also used
22187 TypeManager.LookupType that would go through plenty of caches.
22188 This one goes directly to the type source.
22190 In some places we did the Type.GetType followed by
22191 ModuleBuilder.GetType, but not in others, so this unifies the
22192 processing as well.
22194 * namespace.cs (VerifyUsing): Perform a non-lazy approach to using
22195 statements now that we have namespace information.
22197 * typemanager.cs (IsNamespace): New method, returns whether the
22198 string presented is a namespace or not.
22200 (ComputeNamespaces): New public entry point, computes the list of
22201 available namespaces, using the GetNamespaces API call in Mono, or
22202 the slower version in MS.NET.
22204 Now before we start the semantic analysis phase, we have a
22205 complete list of namespaces including everything that the user has
22208 Deleted old code to cache namespaces in .nsc files.
22210 2003-04-17 Miguel de Icaza <miguel@ximian.com>
22212 * class.cs: (TypeContainer.DefineDefaultConstructor): Use the
22213 class/struct location definition Location for the implicit
22214 constructor location.
22216 (Operator.Define): Use the location of the operator for the
22217 implicit Method definition.
22219 (Constructor.Emit): use the constructor location for the implicit
22220 base initializer constructor.
22222 * ecore.cs: Remove ITypeExpression. This interface is now gone,
22223 and the Expression class now contains two new methods:
22225 ResolveAsTypeStep and ResolveAsTypeTerminal. This is used to
22226 isolate type lookup from the rest of the resolution process.
22228 Since we use Expressions to hold type definitions due to the way
22229 we parse the input we have historically overloaded Resolve to
22230 perform the Type lookups if a special flag is passed. Now this is
22231 eliminated and two methods take their place.
22233 The differences in the two methods between xStep and xTerminal is
22234 that xStep is involved in our current lookup system that uses
22235 SimpleNames to compose a name, while xTerminal is used just to
22236 catch the case where the simplename lookup failed.
22238 2003-04-16 Miguel de Icaza <miguel@ximian.com>
22240 * expression.cs (ResolveMemberAccess): Remove redundant code.
22241 TypeExpr expressions are always born fully resolved.
22243 * interface.cs (PopulateMethod): Do not lookup the types twice.
22244 We were doing it once during SemanticAnalysis and once during
22247 * cs-parser.jay: Due to our hack in the grammar, things like A.B[]
22248 in local variable type definitions, were being returned as a
22249 SimpleName (we decomposed everything into a string), that is
22250 because primary_expression was being used instead of a type in the
22251 grammar (reduce/reduce conflicts).
22253 The part that was wrong is that we converted the expression into a
22254 string (an oversimplification in one hand, compounded with primary
22255 expressions doing string concatenation).
22261 Would return "A.B.C[]" as a SimpleName. This stopped things like
22262 using clauses from working on this particular context. And a type
22263 was being matched directly against "A.B.C[]".
22265 We now use the correct approach, and allow for ComposedCast to be
22266 part of the unary expression. So the "A.B.C []" become a composed
22267 cast of "A.B.C" (as a nested group of MemberAccess with a
22268 SimpleName at the end) plus the rank composition "[]".
22272 2003-04-10 Miguel de Icaza <miguel@ximian.com>
22274 * decl.cs (CheckAccessLevel): Implement the NestedPrivate rules
22275 for the access level checking.
22277 * class.cs: Cosmetic changes. Renamed `TypeContainer parent' to
22278 `TypeContainer container', because I kept getting confused when I
22279 was debugging this code.
22281 * expression.cs (Indexers): Instead of tracking getters/setters,
22282 we now track them in parallel. We create one arraylist less, but
22283 most importantly it is possible now for the LValue code to find a
22284 matching get for a set.
22286 (IndexerAccess.DoResolveLValue): Update the code.
22287 GetIndexersForType has been modified already to extract all the
22288 indexers from a type. The code assumed it did not.
22290 Also make the code set the correct return type for the indexer.
22291 This was fixed a long time ago for properties, but was missing for
22292 indexers. It used to be void_type.
22294 (Binary.Emit): Test first for doubles instead of
22295 floats, as they are more common.
22297 (Binary.EmitBranchable): Use the .un version of the branch opcodes
22298 when dealing with floats and the <=, >= operators. This fixes bug
22301 * statement.cs (Foreach.EmitArrayForeach): bug fix: The code used
22302 to load the array value by emitting a load on the foreach variable
22303 type. This was incorrect.
22305 We now emit the code to load an element using the the array
22306 variable type, and then we emit the conversion operator.
22310 2003-04-10 Zoltan Varga <vargaz@freemail.hu>
22312 * attribute.cs: Avoid allocation of ArrayLists in the common case.
22314 2003-04-09 Miguel de Icaza <miguel@ximian.com>
22316 * class.cs (MethodSignature.InheritableMemberSignatureCompare):
22317 test for protection before we test for signatures.
22319 (MethodSignature.ToString): implement.
22321 * expression.cs (Unary.TryReduceNegative): Add missing minus sign
22322 to the case where we reduced into a LongConstant.
22324 * decl.cs (CheckAccessLevel): If the type is an array, we can not
22325 depend on whether the information is acurrate, because the
22326 Microsoft runtime will always claim that the array type is public,
22327 regardless of the real state.
22329 If the type is a pointer, another problem happens: the type is
22330 reported as non-public in Microsoft.
22332 In both cases we have to call CheckAccessLevel recursively with
22333 the underlying type as the argument to be tested.
22335 2003-04-08 Miguel de Icaza <miguel@ximian.com>
22337 * assign.cs (Assign.Emit): If we are dealing with a compound
22338 assignment expression, we should use the code path that stores the
22339 intermediate result in a temporary value. This fixes #40903.
22341 *expression.cs (Indirection.ToString): Provide ToString method for
22344 2003-04-08 Zoltan Varga <vargaz@freemail.hu>
22346 * class.cs: Null out fields holding references to Block objects so
22347 they can be garbage collected.
22349 * expression.cs (OverloadResolve): Remove unused local.
22351 2003-04-07 Martin Baulig <martin@ximian.com>
22353 * codegen.cs (EmitContext.CurrentFile): New public field.
22354 (EmitContext.Mark): Use the CurrentFile to check whether the
22355 location is in the correct file.
22356 (EmitContext.EmitTopBlock): Initialize CurrentFile here.
22358 2003-04-07 Martin Baulig <martin@ximian.com>
22360 * ecore.cs (Expression.ResolveBoolean): Don't call ec.Mark().
22362 * codegen.cs (EmitContext.EmitTopBlock): Don't call Mark() on the
22363 location. [FIXME: The location argument which gets passed to this
22364 method is sometimes wrong!]
22366 2003-04-07 Nick Drochak <ndrochak@gol.com>
22368 * codegen.cs: Be more verbose when we can't find the symbol writer dll.
22370 2003-04-07 Miguel de Icaza <miguel@ximian.com>
22372 * expression.cs (Indirection.EmitAssign): We were using the
22373 temporary, but returning immediately instead of continuing the
22376 2003-04-06 Martin Baulig <martin@ximian.com>
22378 * ecore.cs (SimpleName.SimpleNameResolve): Don't report an error
22379 if it's a nested child, but also deriving from the outer class.
22382 * typemanager.cs (IsNestedChildOf): Make this work if it's a
22383 nested child, but also deriving from the outer class. See
22385 (FilterWithClosure): We may access private members of the outer
22386 class if we're a nested child and deriving from the outer class.
22387 (RealMemberLookup): Only set `closure_private_ok' if the
22388 `original_bf' contained BindingFlags.NonPublic.
22390 2003-04-05 Martin Baulig <martin@ximian.com>
22392 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #40670.
22394 2003-04-02 Miguel de Icaza <miguel@ximian.com>
22396 * class.cs (Event.Define): Do not allow abstract events to have
22399 2003-04-01 Miguel de Icaza <miguel@ximian.com>
22401 * cs-parser.jay: Add error productions for ADD/REMOVE missing a
22402 block in event declarations.
22404 * ecore.cs (FieldExpr.AddressOf): If our instance expression is a
22405 value type, get its address.
22407 * expression.cs (Is.Emit): For action `LeaveOnStack' we were
22408 leaving a class on the stack instead of a boolean value (int
22409 0/1). Change the code so we compare against null, and then the
22410 result against zero.
22412 * class.cs (TypeContainer.GetClassBases): We were checking for the
22413 parent class being sealed too late.
22415 * expression.cs (Binary.Emit): For <= and >= when dealing with
22416 floating point values, use cgt.un and clt.un instead of cgt and
22419 2003-04-01 Zoltan Varga <vargaz@freemail.hu>
22421 * statement.cs: Apply the same optimization as MS: skip the
22422 GetEnumerator returning an IEnumerator, and use the one returning a
22423 CharEnumerator instead. This allows us to avoid the try-finally block
22426 2003-03-31 Gaurav Vaish <gvaish_mono@lycos.com>
22428 * cs-parser.jay: Attributes cannot be applied to
22429 namespaces. Fixes #40473
22431 2003-03-31 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22434 (Add*): check if the name is valid using the full name for constants,
22435 fields, properties and events.
22437 2003-03-28 Miguel de Icaza <miguel@ximian.com>
22439 * enum.cs (Enum.DefineType, Enum.IsValidEnumConstant): Also allow
22440 char constants to be part of the enumeration.
22442 * expression.cs (Conditional.DoResolve): Add support for operator
22443 true. Implements the missing functionality from 14.12
22445 * class.cs (TypeContainer.CheckPairedOperators): Report error for missmatch on
22446 operator true/false as required by the spec.
22448 * expression.cs (Unary.ResolveOperator): In LogicalNot, do an
22449 implicit conversion to boolean.
22451 * statement.cs (Statement.ResolveBoolean): A boolean expression is
22452 also one where the type implements `operator true'.
22454 * ecore.cs (Expression.GetOperatorTrue): New helper routine to
22455 get an expression that will invoke operator true based on an
22458 (GetConversionOperators): Removed the hack that called op_True
22461 (Expression.ResolveBoolean): Move this from Statement.
22463 2003-03-17 Miguel de Icaza <miguel@ximian.com>
22465 * ecore.cs (FieldExpr): do not allow initialization of initonly
22466 fields on derived classes
22468 2003-03-13 Martin Baulig <martin@ximian.com>
22470 * statement.cs (Block.Emit): Call ig.BeginScope() and
22471 ig.EndScope() when compiling with debugging info; call
22472 LocalBuilder.SetLocalSymInfo _after_ opening the scope.
22474 2003-03-08 Miguel de Icaza <miguel@ximian.com>
22476 * expression.cs (Indexers): Do not construct immediately, allow
22477 for new members to be appended as we go. Fixes 38143
22479 2003-03-07 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22481 * expression.cs: save/restore context when resolving an unchecked
22484 2003-03-05 Miguel de Icaza <miguel@ximian.com>
22486 * cfold.cs: Catch division by zero in modulus operator during
22489 2003-03-03 Miguel de Icaza <miguel@ximian.com>
22491 * interface.cs (Interface.DefineMembers): Avoid defining members
22494 2003-02-27 Miguel de Icaza <miguel@ximian.com>
22496 * driver.cs: handle the +/- options for -noconfig
22498 * statement.cs (Unckeched.Resolve): Also track the state of
22499 unchecked in the Resolve phase.
22501 2003-02-27 Martin Baulig <martin@ximian.com>
22503 * ecore.cs (Expression.MemberLookup): Don't create a
22504 MethodGroupExpr for something which is not a method. Fixes #38291.
22506 2003-02-25 Miguel de Icaza <miguel@ximian.com>
22508 * class.cs (MemberBase.CheckParameters): Also check that the type
22509 is unmanaged if it is a pointer.
22511 * expression.cs (SizeOf.Resolve): Add location information.
22513 * statement.cs (Block.EmitMeta): Flag error (208) if a pointer to
22514 a managed type is declared.
22516 * expression.cs (Invocation.VerifyArgumentsCompat): Check for the
22517 parameter modifiers as well. Fixes bug 38606
22519 * class.cs: Very sad. Am backing out the speed up changes
22520 introduced by the ArrayList -> Array in the TypeContainer, as they
22521 were not actually that much faster, and introduced a bug (no error
22522 reports on duplicated methods).
22524 * assign.cs (CompoundAssign.DoLResolve): Resolve the original
22525 source first, this will guarantee that we have a valid expression
22526 before calling in lower levels functions that will require a
22527 resolved object. Then use this original_source in the
22528 target.ResolveLValue instead of the original source that was
22531 Another change. Use target.Resolve instead of LValueResolve.
22532 Although we are resolving for LValues, we will let the Assign code
22533 take care of that (it will be called again from Resolve). This
22534 basically allows code like this:
22536 class X { X operator + (X x, object o) {} X this [int idx] { get; set; } }
22537 class Y { void A (X x) { x [0] += o; }
22539 The problem was that the indexer was trying to resolve for
22540 set_Item (idx, object o) and never finding one. The real set_Item
22541 was set_Item (idx, X). By delaying the process we get the right
22546 2003-02-23 Martin Baulig <martin@ximian.com>
22548 * statement.cs (Block.Emit): Override this and set ec.CurrentBlock
22549 while calling DoEmit ().
22551 * codegen.cs (EmitContext.Mark): Don't mark locations in other
22552 source files; if you use the #line directive inside a method, the
22553 compiler stops emitting line numbers for the debugger until it
22554 reaches the end of the method or another #line directive which
22555 restores the original file.
22557 2003-02-23 Martin Baulig <martin@ximian.com>
22559 * statement.cs (FlowBranching.UsageVector.MergeChildren): Fix bug #37708.
22561 2003-02-23 Martin Baulig <martin@ximian.com>
22563 * statement.cs (Block.AddChildVariableNames): We need to call this
22564 recursively, not just for our immediate children.
22566 2003-02-23 Martin Baulig <martin@ximian.com>
22568 * class.cs (Event.Define): Always make the field private, like csc does.
22570 * typemanager.cs (TypeManager.RealMemberLookup): Make events
22571 actually work, fixes bug #37521.
22573 2003-02-23 Miguel de Icaza <miguel@ximian.com>
22575 * delegate.cs: When creating the various temporary "Parameters"
22576 classes, make sure that we call the ComputeAndDefineParameterTypes
22577 on those new parameters (just like we do with the formal ones), to
22578 allow them to be resolved in the context of the DeclSpace.
22580 This fixes the bug that Dick observed in Bugzilla #38530.
22582 2003-02-22 Miguel de Icaza <miguel@ximian.com>
22584 * expression.cs (ResolveMemberAccess): When resolving a constant,
22585 do not attempt to pull a constant if the value was not able to
22586 generate a valid constant.
22588 * const.cs (LookupConstantValue): Do not report more errors than required.
22590 2003-02-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22592 * expression.cs: fixes bug #38328.
22594 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22596 * class.cs: Changed all the various members that can be part of a
22597 class from being an ArrayList to be an Array of the right type.
22598 During the DefineType type_list, interface_list, delegate_list and
22599 enum_list are turned into types, interfaces, delegates and enums
22602 And during the member population, indexer_list, event_list,
22603 constant_list, field_list, instance_constructor_list, method_list,
22604 operator_list and property_list are turned into their real arrays.
22606 Although we could probably perform this operation earlier, for
22607 good error reporting we need to keep the lists and remove the
22608 lists for longer than required.
22610 This optimization was triggered by Paolo profiling the compiler
22611 speed on the output of `gen-sample-program.pl' perl script.
22613 * decl.cs (DeclSpace.ResolveType): Set the ContainerType, so we do
22614 not crash in methods like MemberLookupFailed that use this field.
22616 This problem arises when the compiler fails to resolve a type
22617 during interface type definition for example.
22619 2003-02-18 Miguel de Icaza <miguel@ximian.com>
22621 * expression.cs (Indexers.GetIndexersForType): Interfaces do not
22622 inherit from System.Object, so we have to stop at null, not only
22623 when reaching System.Object.
22625 2003-02-17 Miguel de Icaza <miguel@ximian.com>
22627 * expression.cs: (Indexers.GetIndexersForType): Martin's fix used
22628 DeclaredOnly because the parent indexer might have had a different
22629 name, but did not loop until the top of the hierarchy was reached.
22631 The problem this one fixes is 35492: when a class implemented an
22632 indexer from an interface, we were getting the interface method
22633 (which was abstract) and we were flagging an error (can not invoke
22636 This also keeps bug 33089 functioning, and test-148 functioning.
22638 * typemanager.cs (IsSpecialMethod): The correct way of figuring
22639 out if a method is special is to see if it is declared in a
22640 property or event, or whether it is one of the predefined operator
22641 names. This should fix correctly #36804.
22643 2003-02-15 Miguel de Icaza <miguel@ximian.com>
22645 The goal here is to remove the dependency on EmptyCast.Peel ().
22646 Killing it completely.
22648 The problem is that currently in a number of places where
22649 constants are expected, we have to "probe" for an EmptyCast, and
22650 Peel, which is not the correct thing to do, as this will be
22651 repetitive and will likely lead to errors.
22653 The idea is to remove any EmptyCasts that are used in casts that
22654 can be reduced to constants, so we only have to cope with
22657 This bug hunt was triggered by Bug 37363 and the desire to remove
22658 the duplicate pattern where we were "peeling" emptycasts to check
22659 whether they were constants. Now constants will always be
22662 * ecore.cs: Use an enumconstant here instead of wrapping with
22665 * expression.cs (Cast.TryReduce): Ah, the tricky EnumConstant was
22666 throwing me off. By handling this we can get rid of a few hacks.
22668 * statement.cs (Switch): Removed Peel() code.
22670 2003-02-14 Miguel de Icaza <miguel@ximian.com>
22672 * class.cs: Location information for error 508
22674 * expression.cs (New.DoResolve): Add a guard against double
22675 resolution of an expression.
22677 The New DoResolve might be called twice when initializing field
22678 expressions (see EmitFieldInitializers, the call to
22679 GetInitializerExpression will perform a resolve on the expression,
22680 and later the assign will trigger another resolution
22682 This leads to bugs (#37014)
22684 * delegate.cs: The signature for EndInvoke should contain any ref
22685 or out parameters as well. We were not doing this in the past.
22687 * class.cs (Field.Define): Do not overwrite the type definition
22688 inside the `volatile' group. Turns out that volatile enumerations
22689 were changing the type here to perform a validity test, which
22692 2003-02-12 Miguel de Icaza <miguel@ximian.com>
22694 * ecore.cs (FieldExpr.AddressOf): In the particular case of This
22695 and structs, we do not want to load the instance variable
22697 (ImplicitReferenceConversion, ImplicitReferenceConversionExists):
22698 enum_type has to be handled like an object reference (implicit
22699 conversions exists from this to object), but the regular IsClass
22700 and IsValueType tests will never return true for this one.
22702 Also we use TypeManager.IsValueType instead of type.IsValueType,
22703 just for consistency with the rest of the code (this is only
22704 needed if we ever use the construct exposed by test-180.cs inside
22705 corlib, which we dont today).
22707 2003-02-12 Zoltan Varga <vargaz@freemail.hu>
22709 * attribute.cs (ApplyAttributes): apply all MethodImplAttributes, not
22712 2003-02-09 Martin Baulig <martin@ximian.com>
22714 * namespace.cs (Namespace..ctor): Added SourceFile argument.
22715 (Namespace.DefineNamespaces): New static public method; this is
22716 called when we're compiling with debugging to add all namespaces
22717 to the symbol file.
22719 * tree.cs (Tree.RecordNamespace): Added SourceFile argument and
22720 pass it to the Namespace's .ctor.
22722 * symbolwriter.cs (SymbolWriter.OpenMethod): Added TypeContainer
22723 and MethodBase arguments; pass the namespace ID to the symwriter;
22724 pass the MethodBase instead of the token to the symwriter.
22725 (SymbolWriter.DefineNamespace): New method to add a namespace to
22728 2003-02-09 Martin Baulig <martin@ximian.com>
22730 * symbolwriter.cs: New file. This is a wrapper around
22731 ISymbolWriter with a cleaner API. We'll dynamically Invoke()
22732 methods here in near future.
22734 2003-02-09 Martin Baulig <martin@ximian.com>
22736 * codegen.cs (EmitContext.Mark): Just pass the arguments to
22737 ILGenerator.MarkSequencePoint() which are actually used by the
22740 2003-02-09 Martin Baulig <martin@ximian.com>
22742 * location.cs (SourceFile): New public sealed class. This
22743 contains the name and an index which is used in the location's token.
22744 (Location): Reserve an appropriate number of bits in the token for
22745 the source file instead of walking over that list, this gives us a
22746 really huge performance improvement when compiling with debugging.
22748 * driver.cs (Driver.parse, Driver.tokenize_file): Take a
22749 `SourceFile' argument instead of a string.
22750 (Driver.ProcessFile): Add all the files via Location.AddFile(),
22751 but don't parse/tokenize here, we need to generate the list of all
22752 source files before we do that.
22753 (Driver.ProcessFiles): New static function. Parses/tokenizes all
22756 * cs-parser.jay (CSharpParser): Take a `SourceFile' argument
22757 instead of a string.
22759 * cs-tokenizer.cs (Tokenizer): Take `SourceFile' argument instead
22762 2003-02-09 Martin Baulig <martin@ximian.com>
22764 * cs-tokenizer.cs (Tokenizer.PreProcessLine): Also reset the
22765 filename on `#line default'.
22767 Sat Feb 8 17:03:16 CET 2003 Paolo Molaro <lupus@ximian.com>
22769 * statement.cs: don't clear the pinned var when the fixed statement
22770 returns from the method (fixes bug#37752).
22772 Sat Feb 8 12:58:06 CET 2003 Paolo Molaro <lupus@ximian.com>
22774 * typemanager.cs: fix from mathpup@mylinuxisp.com (Marcus Urban)
22777 2003-02-07 Martin Baulig <martin@ximian.com>
22779 * driver.cs: Removed the `--debug-args' command line argument.
22781 * codegen.cs (CodeGen.SaveSymbols): Removed, this is now done
22782 automatically by the AsssemblyBuilder.
22783 (CodeGen.InitializeSymbolWriter): We don't need to call any
22784 initialization function on the symbol writer anymore. This method
22785 doesn't take any arguments.
22787 2003-02-03 Miguel de Icaza <miguel@ximian.com>
22789 * driver.cs: (AddAssemblyAndDeps, LoadAssembly): Enter the types
22790 from referenced assemblies as well.
22792 2003-02-02 Martin Baulig <martin@ximian.com>
22794 * class.cs (MethodData.Emit): Generate debugging info for external methods.
22796 2003-02-02 Martin Baulig <martin@ximian.com>
22798 * class.cs (Constructor.Emit): Open the symbol writer before
22799 emitting the constructor initializer.
22800 (ConstructorInitializer.Emit): Call ec.Mark() to allow
22801 single-stepping through constructor initializers.
22803 2003-01-30 Miguel de Icaza <miguel@ximian.com>
22805 * class.cs: Handle error 549: do not allow virtual methods in
22808 2003-02-01 Jackson Harper <jackson@latitudegeo.com>
22810 * decl.cs: Check access levels when resolving types
22812 2003-01-31 Jackson Harper <jackson@latitudegeo.com>
22814 * statement.cs: Add parameters and locals set in catch blocks that might
22815 return to set vector
22817 2003-01-29 Miguel de Icaza <miguel@ximian.com>
22819 * class.cs (Operator): Set the SpecialName flags for operators.
22821 * expression.cs (Invocation.DoResolve): Only block calls to
22822 accessors and operators on SpecialName methods.
22824 (Cast.TryReduce): Handle conversions from char constants.
22827 Tue Jan 28 17:30:57 CET 2003 Paolo Molaro <lupus@ximian.com>
22829 * statement.cs: small memory and time optimization in FlowBranching.
22831 2003-01-28 Pedro Mart <yoros@wanadoo.es>
22833 * expression.cs (IndexerAccess.DoResolveLValue): Resolve the same
22834 problem that the last fix but in the other sid (Set).
22836 * expression.cs (IndexerAccess.DoResolve): Fix a problem with a null
22837 access when there is no indexer in the hierarchy.
22839 2003-01-27 Jackson Harper <jackson@latitudegeo.com>
22841 * class.cs: Combine some if statements.
22843 2003-01-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22845 * driver.cs: fixed bug #37187.
22847 2003-01-27 Pedro Martinez Juliá <yoros@wanadoo.es>
22849 * expression.cs (IndexerAccess.DoResolve): Before trying to resolve
22850 any indexer, it's needed to build a list with all the indexers in the
22851 hierarchy (AllGetters), else we have problems. Fixes #35653.
22853 2003-01-23 Miguel de Icaza <miguel@ximian.com>
22855 * class.cs (MethodData.Define): It is wrong for an interface
22856 implementation to be static in both cases: explicit and implicit.
22857 We were only handling this in one case.
22859 Improve the if situation there to not have negations.
22861 * class.cs (Field.Define): Turns out that we do not need to check
22862 the unsafe bit on field definition, only on usage. Remove the test.
22864 2003-01-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22866 * driver.cs: use assembly.Location instead of Codebase (the latest
22867 patch made mcs fail when using MS assemblies).
22869 2003-01-21 Tim Haynes <thaynes@openlinksw.com>
22871 * driver.cs: use DirectorySeparatorChar instead of a hardcoded "/" to
22872 get the path to *corlib.dll.
22874 2003-01-21 Nick Drochak <ndrochak@gol.com>
22878 * typemanager.cs: Remove compiler warnings
22880 2003-01-20 Duncan Mak <duncan@ximian.com>
22882 * AssemblyInfo.cs: Bump the version number to 0.19.
22884 2003-01-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22886 * cs-tokenizer.cs: little fixes to line numbering when #line is used.
22888 2003-01-18 Zoltan Varga <vargaz@freemail.hu>
22890 * class.cs (Constructor::Emit): Emit debugging info for constructors.
22892 2003-01-17 Miguel de Icaza <miguel@ximian.com>
22894 * cs-parser.jay: Small fix: we were not comparing the constructor
22895 name correctly. Thanks to Zoltan for the initial pointer.
22897 2003-01-16 Jackson Harper <jackson@latitudegeo.com>
22899 * cs-tokenizer.cs: Set file name when specified with #line
22901 2003-01-15 Miguel de Icaza <miguel@ximian.com>
22903 * cs-parser.jay: Only perform the constructor checks here if we
22904 are named like the class; This will help provider a better
22905 error. The constructor path is taken when a type definition is
22906 not found, but most likely the user forgot to add the type, so
22907 report that rather than the constructor error.
22909 Tue Jan 14 10:36:49 CET 2003 Paolo Molaro <lupus@ximian.com>
22911 * class.cs, rootcontext.cs: small changes to avoid unnecessary memory
22914 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22916 * cs-parser.jay: Add cleanup call.
22918 2003-01-13 Duncan Mak <duncan@ximian.com>
22920 * cs-tokenizer.cs (Cleanup): Rename to 'cleanup' to make it more
22921 consistent with other methods.
22923 2003-01-13 Jackson Harper <jackson@latitudegeo.com>
22925 * cs-tokenizer.cs: Add Cleanup method, also fix #region error messages.
22927 Sun Jan 12 19:58:42 CET 2003 Paolo Molaro <lupus@ximian.com>
22929 * attribute.cs: only set GuidAttr to true when we have a
22932 2003-01-09 Gonzalo Paniagua Javier <gonzalo@ximian.com>
22936 * typemanager.cs: fixes to allow mcs compile corlib with the new
22937 Type.IsSubclassOf fix.
22939 2003-01-08 Miguel de Icaza <miguel@ximian.com>
22941 * expression.cs (LocalVariableReference.DoResolve): Classify a
22942 constant as a value, not as a variable. Also, set the type for
22945 * cs-parser.jay (fixed_statement): take a type instead of a
22946 pointer_type, so we can produce a better error message later.
22948 * statement.cs (Fixed.Resolve): Flag types that are not pointers
22951 (For.DoEmit): Make inifinite loops have a
22952 non-conditional branch back.
22954 (Fixed.DoEmit): First populate the pinned variables, then emit the
22955 statement, then clear the variables. Before I was emitting the
22956 code once for each fixed piece.
22959 2003-01-08 Martin Baulig <martin@ximian.com>
22961 * statement.cs (FlowBranching.MergeChild): A break in a
22962 SWITCH_SECTION does not leave a loop. Fixes #36155.
22964 2003-01-08 Martin Baulig <martin@ximian.com>
22966 * statement.cs (FlowBranching.CheckOutParameters): `struct_params'
22967 lives in the same number space than `param_map'. Fixes #36154.
22969 2003-01-07 Miguel de Icaza <miguel@ximian.com>
22971 * cs-parser.jay (constructor_declaration): Set the
22972 Constructor.ModFlags before probing for it. This makes the
22973 compiler report 514, 515 and 132 (the code was there, but got
22976 * statement.cs (Goto.Resolve): Set `Returns' to ALWAYS.
22977 (GotoDefault.Resolve): Set `Returns' to ALWAYS.
22978 (GotoCase.Resolve): Set `Returns' to ALWAYS.
22980 Tue Jan 7 18:32:24 CET 2003 Paolo Molaro <lupus@ximian.com>
22982 * enum.cs: create the enum static fields using the enum type.
22984 Tue Jan 7 18:23:44 CET 2003 Paolo Molaro <lupus@ximian.com>
22986 * class.cs: don't try to create the ParamBuilder for the return
22987 type if it's not needed (and handle it breaking for the ms runtime
22990 2003-01-06 Jackson Harper <jackson@latitudegeo.com>
22992 * cs-tokenizer.cs: Add REGION flag to #region directives, and add checks to make sure that regions are being poped correctly
22994 2002-12-29 Miguel de Icaza <miguel@ximian.com>
22996 * cs-tokenizer.cs (get_cmd_arg): Fixups to allow \r to terminate
22997 the command. This showed up while compiling the JANET source
22998 code, which used \r as its only newline separator.
23000 2002-12-28 Miguel de Icaza <miguel@ximian.com>
23002 * class.cs (Method.Define): If we are an operator (because it
23003 reuses our code), then set the SpecialName and HideBySig. #36128
23005 2002-12-22 Miguel de Icaza <miguel@ximian.com>
23007 * ecore.cs (FieldExpr.DoResolve): Instead of throwing an
23008 exception, report error 120 `object reference required'.
23010 * driver.cs: Add --pause option, used during to measure the size
23011 of the process as it goes with --timestamp.
23013 * expression.cs (Invocation.DoResolve): Do not allow methods with
23014 SpecialName to be invoked.
23016 2002-12-21 Miguel de Icaza <miguel@ximian.com>
23018 * cs-tokenizer.cs: Small fix to the parser: compute the ascii
23019 number before adding it.
23021 2002-12-21 Ravi Pratap <ravi@ximian.com>
23023 * ecore.cs (StandardImplicitConversion): When in an unsafe
23024 context, we allow conversion between void * to any other pointer
23025 type. This fixes bug #35973.
23027 2002-12-20 Jackson Harper <jackson@latitudegeo.com>
23029 * codegen.cs: Use Path.GetFileNameWithoutExtension so an exception
23030 is not thrown when extensionless outputs are used
23032 2002-12-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23034 * rootcontext.cs: fixed compilation of corlib.
23036 2002-12-19 Miguel de Icaza <miguel@ximian.com>
23038 * attribute.cs (Attributes.Contains): Add new method.
23040 * class.cs (MethodCore.LabelParameters): if the parameter is an
23041 `out' parameter, check that no attribute `[In]' has been passed.
23043 * enum.cs: Handle the `value__' name in an enumeration.
23045 2002-12-14 Jaroslaw Kowalski <jarek@atm.com.pl>
23047 * decl.cs: Added special case to allow overrides on "protected
23050 2002-12-18 Ravi Pratap <ravi@ximian.com>
23052 * attribute.cs (Attributes.AddAttributeSection): Rename to this
23053 since it makes much more sense.
23055 (Attributes.ctor): Don't require a Location parameter.
23057 * rootcontext.cs (AddGlobalAttributeSection): Rename again.
23059 * attribute.cs (ApplyAttributes): Remove extra Location parameters
23060 since we already have that information per attribute.
23062 * everywhere : make appropriate changes.
23064 * class.cs (LabelParameters): Write the code which actually
23065 applies attributes to the return type. We can't do this on the MS
23066 .NET runtime so we flag a warning in the case an exception is
23069 2002-12-18 Miguel de Icaza <miguel@ximian.com>
23071 * const.cs: Handle implicit null conversions here too.
23073 2002-12-17 Ravi Pratap <ravi@ximian.com>
23075 * class.cs (MethodCore.LabelParameters): Remove the extra
23076 Type [] parameter since it is completely unnecessary. Instead
23077 pass in the method's attributes so that we can extract
23078 the "return" attribute.
23080 2002-12-17 Miguel de Icaza <miguel@ximian.com>
23082 * cs-parser.jay (parse): Use Report.Error to flag errors instead
23083 of ignoring it and letting the compile continue.
23085 * typemanager.cs (ChangeType): use an extra argument to return an
23086 error condition instead of throwing an exception.
23088 2002-12-15 Miguel de Icaza <miguel@ximian.com>
23090 * expression.cs (Unary.TryReduce): mimic the code for the regular
23091 code path. Perform an implicit cast in the cases where we can
23092 implicitly convert to one of the integral types, and then reduce
23093 based on that constant. This fixes bug #35483.
23095 2002-12-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23097 * typemanager.cs: fixed cut & paste error in GetRemoveMethod.
23099 2002-12-13 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23101 * namespace.cs: fixed bug #35489.
23103 2002-12-12 Miguel de Icaza <miguel@ximian.com>
23105 * class.cs: Remove some dead code.
23107 * cs-parser.jay: Estimate the number of methods needed
23108 (RootContext.MethodCount);
23110 * cs-tokenizer.cs: Use char arrays for parsing identifiers and
23111 numbers instead of StringBuilders.
23113 * support.cs (PtrHashtable): Add constructor with initial size;
23114 We can now reduce reallocations of the method table.
23116 2002-12-10 Ravi Pratap <ravi@ximian.com>
23118 * attribute.cs (ApplyAttributes): Keep track of the emitted
23119 attributes on a per-target basis. This fixes bug #35413.
23121 2002-12-10 Miguel de Icaza <miguel@ximian.com>
23123 * driver.cs (MainDriver): On rotor encoding 28591 does not exist,
23124 default to the Windows 1252 encoding.
23126 (UnixParseOption): Support version, thanks to Alp for the missing
23129 * AssemblyInfo.cs: Add nice assembly information.
23131 * cs-tokenizer.cs: Add fix from Felix to the #if/#else handler
23134 * cs-parser.jay: Allow a trailing comma before the close bracked
23135 in the attribute_section production.
23137 * ecore.cs (FieldExpr.AddressOf): Until I figure out why the
23138 address of the instance was being taken, I will take this out,
23139 because we take the address of the object immediately here.
23141 2002-12-09 Ravi Pratap <ravi@ximian.com>
23143 * typemanager.cs (AreMultipleAllowed): Take care of the most
23144 obvious case where attribute type is not in the current assembly -
23147 2002-12-08 Miguel de Icaza <miguel@ximian.com>
23149 * ecore.cs (SimpleName.DoResolve): First perform lookups on using
23150 definitions, instead of doing that afterwards.
23152 Also we use a nice little hack, depending on the constructor, we
23153 know if we are a "composed" name or a simple name. Hence, we
23154 avoid the IndexOf test, and we avoid
23156 * codegen.cs: Add code to assist in a bug reporter to track down
23157 the source of a compiler crash.
23159 2002-12-07 Ravi Pratap <ravi@ximian.com>
23161 * attribute.cs (Attribute.ApplyAttributes) : Keep track of which attribute
23162 types have been emitted for a given element and flag an error
23163 if something which does not have AllowMultiple set is used more
23166 * typemanager.cs (RegisterAttributeAllowMultiple): Keep track of
23167 attribute types and their corresponding AllowMultiple properties
23169 (AreMultipleAllowed): Check the property for a given type.
23171 * attribute.cs (Attribute.ApplyAttributes): Register the AllowMultiple
23172 property in the case we have a TypeContainer.
23174 (Attributes.AddAttribute): Detect duplicates and just skip on
23175 adding them. This trivial fix catches a pretty gross error in our
23176 attribute emission - global attributes were being emitted twice!
23178 Bugzilla bug #33187 is now fixed.
23180 2002-12-06 Miguel de Icaza <miguel@ximian.com>
23182 * cs-tokenizer.cs (pp_expr): Properly recurse here (use pp_expr
23183 instead of pp_and).
23185 * expression.cs (Binary.ResolveOperator): I can only use the
23186 Concat (string, string, string) and Concat (string, string,
23187 string, string) if the child is actually a concatenation of
23190 2002-12-04 Miguel de Icaza <miguel@ximian.com>
23192 * cs-tokenizer.cs: Small fix, because decimal_digits is used in a
23193 context where we need a 2-character lookahead.
23195 * pending.cs (PendingImplementation): Rework so we can keep track
23196 of interface types all the time, and flag those which were
23197 implemented by parents as optional.
23199 2002-12-03 Miguel de Icaza <miguel@ximian.com>
23201 * expression.cs (Binary.ResolveOperator): Use
23202 String.Concat(string,string,string) or
23203 String.Concat(string,string,string,string) when possible.
23205 * typemanager: More helper methods.
23208 Tue Dec 3 19:32:04 CET 2002 Paolo Molaro <lupus@ximian.com>
23210 * pending.cs: remove the bogus return from GetMissingInterfaces()
23211 (see the 2002-11-06 entry: the mono runtime is now fixed in cvs).
23213 2002-12-02 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23215 * namespace.cs: avoid duplicated 'using xxx' being added to
23216 using_clauses. This prevents mcs from issuing and 'ambiguous type' error
23217 when we get more than one 'using' statement for the same namespace.
23218 Report a CS0105 warning for it.
23220 2002-11-30 Miguel de Icaza <miguel@ximian.com>
23222 * cs-tokenizer.cs (consume_identifier): use read directly, instead
23223 of calling getChar/putback, uses internal knowledge of it.
23225 (xtoken): Reorder tokenizer so most common patterns are checked
23226 first. This reduces the compilation time in another 5% (from 8.11s
23227 average to 7.73s for bootstrapping mcs on my Mobile p4/1.8ghz).
23229 The parsing time is 22% of the compilation in mcs, and from that
23230 64% is spent on the tokenization process.
23232 I tried using a binary search for keywords, but this is slower
23233 than the hashtable. Another option would be to do a couple of
23236 * Not use a StringBuilder, instead use an array of chars,
23237 with a set value. Notice that this way we could catch
23238 the 645 error without having to do it *afterwards*.
23240 * We could write a hand-parser to avoid the hashtable
23241 compares altogether.
23243 The identifier consumption process takes 37% of the tokenization
23244 time. Another 15% is spent on is_number. 56% of the time spent
23245 on is_number is spent on Int64.Parse:
23247 * We could probably choose based on the string length to
23248 use Int32.Parse or Int64.Parse and avoid all the 64-bit
23251 Another 3% is spend on wrapping `xtoken' in the `token' function.
23253 Handle 0xa0 as whitespace (#34752)
23255 2002-11-26 Miguel de Icaza <miguel@ximian.com>
23257 * typemanager.cs (IsCLRType): New routine to tell whether a type
23258 is one of the builtin types.
23260 Maybe it needs to use TypeCodes to be faster. Maybe we could use
23261 typecode in more places instead of doing pointer comparissions.
23262 We could leverage some knowledge about the way the typecodes are
23265 New code to cache namespaces in assemblies, it is currently not
23266 invoked, to be used soon.
23268 * decl.cs (DeclSpace.MakeFQN): Simple optimization.
23270 * expression.cs (Binary.ResolveOperator): specially handle
23271 strings, and do not perform user-defined operator overloading for
23274 2002-11-24 Miguel de Icaza <miguel@ximian.com>
23276 * cs-tokenizer.cs: Avoid calling Char.IsDigit which is an
23277 internalcall as it is a pretty simple operation; Avoid whenever
23278 possible to call Char.IsLetter.
23280 (consume_identifier): Cut by half the number of
23281 hashtable calls by merging the is_keyword and GetKeyword behavior.
23283 Do not short-circuit, because if we do, we
23284 report errors (ie, #if false && true would produce an invalid
23288 2002-11-24 Martin Baulig <martin@ximian.com>
23290 * expression.cs (Cast.TryReduce): If we're in checked syntax,
23291 check constant ranges and report a CS0221. Fixes #33186.
23293 2002-11-24 Martin Baulig <martin@ximian.com>
23295 * cs-parser.jay: Make this work for uninitialized variable
23296 declarations in the `for' initializer. Fixes #32416.
23298 2002-11-24 Martin Baulig <martin@ximian.com>
23300 * ecore.cs (Expression.ConvertExplicit): Make casting from/to
23301 System.Enum actually work. Fixes bug #32269, added verify-6.cs.
23303 2002-11-24 Martin Baulig <martin@ximian.com>
23305 * expression.cs (Binary.DoNumericPromotions): Added `check_user_conv'
23306 argument; if true, we also check for user-defined conversions.
23307 This is only needed if both arguments are of a user-defined type.
23308 Fixes #30443, added test-175.cs.
23309 (Binary.ForceConversion): Pass the location argument to ConvertImplicit.
23311 * ecore.cs (Expression.ImplicitUserConversionExists): New method.
23313 2002-11-24 Martin Baulig <martin@ximian.com>
23315 * expression.cs (ArrayAccess.GetStoreOpcode): New public static
23316 function to get the store opcode.
23317 (Invocation.EmitParams): Call ArrayAccess.GetStoreOpcode() and
23318 only emit the Ldelema if the store opcode is Stobj. You must run
23319 both test-34 and test-167 to test this. Fixes #34529.
23321 2002-11-23 Martin Baulig <martin@ximian.com>
23323 * ecore.cs (Expression.MemberLookup): Added additional
23324 `qualifier_type' argument which is used when we're being called
23325 from MemberAccess.DoResolve() and null if we're called from a
23327 (Expression.MemberLookupFailed): New method to report errors; this
23328 does the CS1540 check and reports the correct error message.
23330 * typemanager.cs (MemberLookup): Added additional `qualifier_type'
23331 argument for the CS1540 check and redone the way how we're dealing
23332 with private members. See the comment in the source code for details.
23333 (FilterWithClosure): Reverted this back to revision 1.197; renamed
23334 `closure_start_type' to `closure_qualifier_type' and check whether
23335 it's not null. It was not this filter being broken, it was just
23336 being called with the wrong arguments.
23338 * expression.cs (MemberAccess.DoResolve): use MemberLookupFinal()
23339 and pass it the correct `qualifier_type'; this also does the error
23342 2002-11-22 Miguel de Icaza <miguel@ximian.com>
23344 * expression.cs (Invocation.EmitParams): If the we are dealing
23345 with a non-built-in value type, load its address as well.
23347 (ArrayCreation): Use a a pretty constant instead
23348 of the hardcoded value 2. Use 6 instead of 2 for the number of
23349 static initializers.
23351 (ArrayCreation.EmitDynamicInitializers): Peel enumerations,
23352 because they are not really value types, just glorified integers.
23354 * driver.cs: Do not append .exe, the CSC compiler does not do it.
23356 * ecore.cs: Remove redundant code for enumerations, make them use
23357 the same code path as everything else, fixes the casting issue
23358 with enumerations in Windows.Forms.
23360 * attribute.cs: Do only cast to string if it is a string, the
23361 validation happens later.
23363 * typemanager.cs: Temproary hack to avoid a bootstrap issue until
23364 people upgrade their corlibs.
23366 * ecore.cs: Oops, enumerations were not following the entire code path
23368 2002-11-21 Miguel de Icaza <miguel@ximian.com>
23370 * typemanager.cs (FilterWithClosure): Commented out the test for
23371 1540 in typemanager.cs, as it has problems when accessing
23372 protected methods from a parent class (see test-174.cs).
23374 * attribute.cs (Attribute.ValidateGuid): new method.
23375 (Attribute.Resolve): Use above.
23377 2002-11-19 Miguel de Icaza <miguel@ximian.com>
23379 * enum.cs: In FindMembers, perform a recursive lookup for values. (34308)
23381 * ecore.cs (SimpleName.SimpleNameResolve): Remove the special
23382 handling for enumerations, as we only needed the TypeContainer
23383 functionality to begin with (this is required for the fix below to
23384 work for enums that reference constants in a container class for
23387 * codegen.cs (EmitContext): Make TypeContainer a DeclSpace.
23389 * enum.cs (Enum.Define): Use `this' instead of parent, so we have
23390 a valid TypeBuilder to perform lookups on.o
23392 * class.cs (InheritableMemberSignatureCompare): Use true in the
23393 call to GetGetMethod and GetSetMethod, because we are comparing
23394 the signature, and we need to get the methods *even* if they are
23397 (PropertyBase.CheckBase): ditto.
23399 * statement.cs (Switch.ResolveAndReduce, Block.EmitMeta,
23400 GotoCase.Resolve): Use Peel on EmpytCasts.
23402 * ecore.cs (EmptyCast): drop child, add Peel method.
23404 2002-11-17 Martin Baulig <martin@ximian.com>
23406 * ecore.cs (EmptyCast.Child): New public property.
23408 * statement.cs (SwitchLabel.ResolveAndReduce): Check whether the
23409 label resolved to an EmptyCast. Fixes #34162.
23410 (GotoCase.Resolve): Likewise.
23411 (Block.EmitMeta): Likewise.
23413 2002-11-17 Martin Baulig <martin@ximian.com>
23415 * expression.cs (Invocation.BetterConversion): Prefer int over
23416 uint; short over ushort; long over ulong for integer literals.
23417 Use ImplicitConversionExists instead of StandardConversionExists
23418 since we also need to check for user-defined implicit conversions.
23419 Fixes #34165. Added test-173.cs.
23421 2002-11-16 Martin Baulig <martin@ximian.com>
23423 * expression.cs (Binary.EmitBranchable): Eliminate comparisions
23424 with the `true' and `false' literals. Fixes #33151.
23426 2002-11-16 Martin Baulig <martin@ximian.com>
23428 * typemanager.cs (RealMemberLookup): Reverted Miguel's patch from
23429 October 22nd; don't do the cs1540 check for static members.
23431 * ecore.cs (PropertyExpr.ResolveAccessors): Rewrote this; we're
23432 now using our own filter here and doing the cs1540 check again.
23434 2002-11-16 Martin Baulig <martin@ximian.com>
23436 * support.cs (InternalParameters): Don't crash if we don't have
23437 any fixed parameters. Fixes #33532.
23439 2002-11-16 Martin Baulig <martin@ximian.com>
23441 * decl.cs (MemberCache.AddMethods): Use BindingFlags.FlattenHierarchy
23442 when looking up static methods to make this work on Windows.
23445 2002-11-16 Martin Baulig <martin@ximian.com>
23447 * ecore.cs (PropertyExpr.VerifyAssignable): Check whether we have
23448 a setter rather than using PropertyInfo.CanWrite.
23450 2002-11-15 Nick Drochak <ndrochak@gol.com>
23452 * class.cs: Allow acces to block member by subclasses. Fixes build
23455 2002-11-14 Martin Baulig <martin@ximian.com>
23457 * class.cs (Constructor.Emit): Added the extern/block check.
23460 2002-11-14 Martin Baulig <martin@ximian.com>
23462 * expression.cs (IndexerAccess.DoResolve): Do a DeclaredOnly
23463 iteration while looking for indexers, this is needed because the
23464 indexer may have a different name in our base classes. Fixed the
23465 error reporting (no indexers at all, not get accessor, no
23466 overloaded match). Fixes bug #33089.
23467 (IndexerAccess.DoResolveLValue): Likewise.
23469 2002-11-14 Martin Baulig <martin@ximian.com>
23471 * class.cs (PropertyBase.CheckBase): Make this work for multiple
23472 indexers. Fixes the first part of bug #33089.
23473 (MethodSignature.InheritableMemberSignatureCompare): Added support
23476 2002-11-13 Ravi Pratap <ravi@ximian.com>
23478 * attribute.cs (Attribute.Resolve): Catch the
23479 NullReferenceException and report it since it isn't supposed to
23482 2002-11-12 Miguel de Icaza <miguel@ximian.com>
23484 * expression.cs (Binary.EmitBranchable): Also handle the cases for
23485 LogicalOr and LogicalAnd that can benefit from recursively
23486 handling EmitBranchable. The code now should be nice for Paolo.
23488 2002-11-08 Miguel de Icaza <miguel@ximian.com>
23490 * typemanager.cs (LookupType): Added a negative-hit hashtable for
23491 the Type lookups, as we perform quite a number of lookups on
23492 non-Types. This can be removed once we can deterministically tell
23493 whether we have a type or a namespace in advance.
23495 But this might require special hacks from our corlib.
23499 * ecore.cs (TryImplicitIntConversion): Handle conversions to float
23500 and double which avoids a conversion from an integer to a double.
23502 * expression.cs: tiny optimization, avoid calling IsConstant,
23503 because it effectively performs the lookup twice.
23505 2002-11-06 Miguel de Icaza <miguel@ximian.com>
23507 But a bogus return here to keep the semantics of the old code
23508 until the Mono runtime is fixed.
23510 * pending.cs (GetMissingInterfaces): New method used to remove all
23511 the interfaces that are already implemented by our parent
23512 classes from the list of pending methods.
23514 * interface.cs: Add checks for calls after ResolveTypeExpr.
23516 2002-11-05 Miguel de Icaza <miguel@ximian.com>
23518 * class.cs (Class.Emit): Report warning 67: event not used if the
23519 warning level is beyond 3.
23521 * ecore.cs (Expression.ConvertExplicit): Missed a check for expr
23522 being a NullLiteral.
23524 * cs-parser.jay: Fix, Gonzalo reverted the order of the rank
23527 * class.cs (TypeContainer.GetClassBases): Cover a missing code
23528 path that might fail if a type can not be resolved.
23530 * expression.cs (Binary.Emit): Emit unsigned versions of the
23533 * driver.cs: use error 5.
23535 2002-11-02 Gonzalo Paniagua Javier <gonzalo@gnome-db.org>
23537 * cs-parser.jay: simplified a rule and 5 SR conflicts dissapeared.
23539 2002-11-01 Miguel de Icaza <miguel@ximian.com>
23541 * cs-parser.jay (switch_section): A beautiful patch from Martin
23542 Baulig that fixed 33094.
23544 2002-10-31 Miguel de Icaza <miguel@ximian.com>
23546 * ecore.cs (PropertyExpr.DoResolveLValue, PropertyExpr.DoResolve):
23547 Check whether the base is abstract and report an error if so.
23549 * expression.cs (IndexerAccess.DoResolveLValue,
23550 IndexerAccess.DoResolve): ditto.
23552 (Invocation.DoResolve): ditto.
23554 (Invocation.FullMethodDesc): Improve the report string.
23556 * statement.cs (Block): Eliminate IsVariableDefined as it is
23557 basically just a wrapper for GetVariableInfo.
23559 * ecore.cs (SimpleName): Use new
23561 * support.cs (ReflectionParamter.ParameterType): We unwrap the
23562 type, as we return the actual parameter ref/unref state on a
23565 2002-10-30 Miguel de Icaza <miguel@ximian.com>
23567 * support.cs: Return proper flags REF/OUT fixing the previous
23570 * expression.cs: Reverted last patch, that was wrong. Is_ref is
23571 not used to mean `ref' but `ref or out' in ParameterReference
23573 * delegate.cs (FullDelegateDesc): use ParameterDesc to get the
23574 full type signature instead of calling TypeManger.CSharpName
23577 * support.cs (InternalParameters.ParameterDesc): Do not compare
23578 directly to the modflags, because REF/OUT will actually be bitsets
23581 * delegate.cs (VerifyMethod): Check also the modifiers.
23583 * cs-tokenizer.cs: Fix bug where floating point values with an
23584 exponent where a sign was missing was ignored.
23586 * driver.cs: Allow multiple assemblies to be specified in a single
23589 2002-10-28 Miguel de Icaza <miguel@ximian.com>
23591 * cs-parser.jay: Ugly. We had to add a multiplicative_expression,
23592 because identifiers after a parenthesis would end up in this kind
23593 of production, and we needed to desamiguate it for having casts
23596 (UserDefinedType *) xxx
23598 2002-10-24 Miguel de Icaza <miguel@ximian.com>
23600 * typemanager.cs (RealMemberLookup): when we deal with a subclass,
23601 we should set on the Bindingflags.NonPublic, but not turn on
23602 private_ok. private_ok controls whether a Private member is
23603 returned (this is chekced on the filter routine), while the
23604 BindingFlags.NonPublic just controls whether private/protected
23605 will be allowed. This fixes the problem part of the problem of
23606 private properties being allowed to be used in derived classes.
23608 * expression.cs (BaseAccess): Provide an DoResolveLValue method,
23609 so we can call the children DoResolveLValue method (this will
23610 properly signal errors on lvalue assignments to base properties)
23612 * ecore.cs (PropertyExpr.ResolveAccessors): If both setter and
23613 getter are null, and we have a property info, we know that this
23614 happened because the lookup failed, so we report an error 122 for
23615 protection level violation.
23617 We also silently return if setter and getter are null in the
23618 resolve functions, this condition only happens if we have flagged
23619 the error before. This is the other half of the problem.
23621 (PropertyExpr.ResolveAccessors): Turns out that PropertyInfo does
23622 not have accessibility information, that is why we were returning
23623 true in the filter function in typemanager.cs.
23625 To properly report 122 (property is inaccessible because of its
23626 protection level) correctly, we report this error in ResolveAccess
23627 by failing if both the setter and the getter are lacking (ie, the
23630 DoResolve and DoLResolve have been modified to check for both
23631 setter/getter being null and returning silently, the reason being
23632 that I did not want to put the knowledge about this error in upper
23635 int old = Report.Errors;
23636 x = new PropertyExpr (...);
23637 if (old != Report.Errors)
23642 So the property expr is returned, but it is invalid, so the error
23643 will be flagged during the resolve process.
23645 * class.cs: Remove InheritablePropertySignatureCompare from the
23646 class, as we no longer depend on the property signature to compute
23647 whether it is possible to implement a method or not.
23649 The reason is that calling PropertyInfo.GetGetMethod will return
23650 null (in .NET, in Mono it works, and we should change this), in
23651 cases where the Get Method does not exist in that particular
23656 class X { public virtual int A { get { return 1; } } }
23658 class Z : Y { public override int A { get { return 2; } } }
23660 Would fail in Z because the parent (Y) would not have the property
23661 defined. So we avoid this completely now (because the alternative
23662 fix was ugly and slow), and we now depend exclusively on the
23665 (PropertyBase.CheckBase): Use a method-base mechanism to find our
23666 reference method, instead of using the property.
23668 * typemanager.cs (GetPropertyGetter, GetPropertySetter): These
23669 routines are gone now.
23671 * typemanager.cs (GetPropertyGetter, GetPropertySetter): swap the
23672 names, they were incorrectly named.
23674 * cs-tokenizer.cs: Return are more gentle token on failure.
23676 * pending.cs (PendingImplementation.InterfaceMethod): This routine
23677 had an out-of-sync index variable, which caused it to remove from
23678 the list of pending methods the wrong method sometimes.
23680 2002-10-22 Miguel de Icaza <miguel@ximian.com>
23682 * ecore.cs (PropertyExpr): Do not use PropertyInfo.CanRead,
23683 CanWrite, because those refer to this particular instance of the
23684 property, and do not take into account the fact that we can
23685 override single members of a property.
23687 Constructor requires an EmitContext. The resolution process does
23688 not happen here, but we need to compute the accessors before,
23689 because the resolution does not always happen for properties.
23691 * typemanager.cs (RealMemberLookup): Set private_ok if we are a
23692 subclass, before we did not update this flag, but we did update
23695 (GetAccessors): Drop this routine, as it did not work in the
23696 presence of partially overwritten set/get methods.
23698 Notice that this broke the cs1540 detection, but that will require
23701 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23705 * driver.cs: issue a warning instead of an error if we don't support
23706 debugging for the platform. Also ignore a couple of errors that may
23707 arise when trying to write the symbols. Undo my previous patch.
23709 2002-10-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23711 * driver.cs: ignore /debug switch except for Unix platforms.
23713 2002-10-23 Nick Drochak <ndrochak@gol.com>
23715 * makefile: Remove mcs2.exe and mcs3.exe on 'make clean'
23717 2002-10-21 Miguel de Icaza <miguel@ximian.com>
23719 * driver.cs: Do not make mcs-debug conditional, so we do not break
23720 builds that use it.
23722 * statement.cs (UsageVector.MergeChildren): I would like Martin to
23723 review this patch. But basically after all the children variables
23724 have been merged, the value of "Breaks" was not being set to
23725 new_breaks for Switch blocks. I think that it should be set after
23726 it has executed. Currently I set this to the value of new_breaks,
23727 but only if new_breaks is FlowReturn.ALWAYS, which is a bit
23728 conservative, but I do not understand this code very well.
23730 I did not break anything in the build, so that is good ;-)
23732 * cs-tokenizer.cs: Also allow \r in comments as a line separator.
23734 2002-10-20 Mark Crichton <crichton@gimp.org>
23736 * cfold.cs: Fixed compile blocker. Really fixed it this time.
23738 2002-10-20 Nick Drochak <ndrochak@gol.com>
23740 * cfold.cs: Fixed compile blocker.
23742 2002-10-20 Miguel de Icaza <miguel@ximian.com>
23744 * driver.cs: I was chekcing the key, not the file.
23746 2002-10-19 Ravi Pratap <ravi@ximian.com>
23748 * ecore.cs (UserDefinedConversion): Get rid of the bogus error
23749 message that we were generating - we just need to silently return
23752 2002-10-19 Miguel de Icaza <miguel@ximian.com>
23754 * class.cs (Event.Define): Change my previous commit, as this
23755 breaks the debugger. This is a temporary hack, as it seems like
23756 the compiler is generating events incorrectly to begin with.
23758 * expression.cs (Binary.ResolveOperator): Added support for
23759 "U operator - (E x, E y)"
23761 * cfold.cs (BinaryFold): Added support for "U operator - (E x, E
23764 * ecore.cs (FieldExpr.AddressOf): We had a special code path for
23765 init-only variables, but this path did not take into account that
23766 there might be also instance readonly variables. Correct this
23769 This fixes bug 32253
23771 * delegate.cs (NewDelegate.DoResolve): Catch creation of unsafe
23774 * driver.cs: Change the extension for modules to `netmodule'
23776 * cs-parser.jay: Improved slightly the location tracking for
23777 the debugger symbols.
23779 * class.cs (Event.Define): Use Modifiers.FieldAttr on the
23780 modifiers that were specified instead of the hardcoded value
23781 (FamAndAssem). This was basically ignoring the static modifier,
23782 and others. Fixes 32429.
23784 * statement.cs (Switch.SimpleSwitchEmit): Simplified the code, and
23785 fixed a bug in the process (32476)
23787 * expression.cs (ArrayAccess.EmitAssign): Patch from
23788 hwang_rob@yahoo.ca that fixes bug 31834.3
23790 2002-10-18 Miguel de Icaza <miguel@ximian.com>
23792 * driver.cs: Make the module extension .netmodule.
23794 2002-10-16 Miguel de Icaza <miguel@ximian.com>
23796 * driver.cs: Report an error if the resource file is not found
23797 instead of crashing.
23799 * ecore.cs (PropertyExpr.EmitAssign): Pass IsBase instead of
23800 false, like Emit does.
23802 2002-10-16 Nick Drochak <ndrochak@gol.com>
23804 * typemanager.cs: Remove unused private member. Also reported mcs
23805 bug to report this as a warning like csc.
23807 2002-10-15 Martin Baulig <martin@gnome.org>
23809 * statement.cs (Statement.Emit): Made this a virtual method; emits
23810 the line number info and calls DoEmit().
23811 (Statement.DoEmit): New protected abstract method, formerly knows
23812 as Statement.Emit().
23814 * codegen.cs (EmitContext.Mark): Check whether we have a symbol writer.
23816 2002-10-11 Miguel de Icaza <miguel@ximian.com>
23818 * class.cs: Following the comment from 2002-09-26 to AddMethod, I
23819 have fixed a remaining problem: not every AddXXXX was adding a
23820 fully qualified name.
23822 Now everyone registers a fully qualified name in the DeclSpace as
23823 being defined instead of the partial name.
23825 Downsides: we are slower than we need to be due to the excess
23826 copies and the names being registered this way.
23828 The reason for this is that we currently depend (on the corlib
23829 bootstrap for instance) that types are fully qualified, because
23830 we dump all the types in the namespace, and we should really have
23831 types inserted into the proper namespace, so we can only store the
23832 basenames in the defined_names array.
23834 2002-10-10 Martin Baulig <martin@gnome.org>
23836 * expression.cs (ArrayAccess.EmitStoreOpcode): Reverted the patch
23837 from bug #31834, see the bug report for a testcase which is
23840 2002-10-10 Martin Baulig <martin@gnome.org>
23842 * codegen.cs (EmitContext.Breaks): Removed, we're now using the
23843 flow analysis code for this.
23845 * statement.cs (Do, While, For): Tell the flow analysis code about
23847 (FlowBranching.UsageVector): Added support for infinite loops.
23848 (Block.Resolve): Moved the dead code elimination here and use flow
23851 2002-10-09 Miguel de Icaza <miguel@ximian.com>
23853 * class.cs (Field.Define): Catch cycles on struct type
23856 * typemanager.cs (IsUnmanagedtype): Do not recursively check
23857 fields if the fields are static. We only need to check instance
23860 * expression.cs (As.DoResolve): Test for reference type.
23862 * statement.cs (Using.ResolveExpression): Use
23863 ConvertImplicitRequired, not ConvertImplicit which reports an
23865 (Using.ResolveLocalVariableDecls): ditto.
23867 * expression.cs (Binary.ResolveOperator): Report errors in a few
23868 places where we had to.
23870 * typemanager.cs (IsUnmanagedtype): Finish implementation.
23872 2002-10-08 Miguel de Icaza <miguel@ximian.com>
23874 * expression.cs: Use StoreFromPtr instead of extracting the type
23875 and then trying to use Stelem. Patch is from hwang_rob@yahoo.ca
23877 * ecore.cs (ImplicitReferenceConversion): It is possible to assign
23878 an enumeration value to a System.Enum, but System.Enum is not a
23879 value type, but an class type, so we need to box.
23881 (Expression.ConvertExplicit): One codepath could return
23882 errors but not flag them. Fix this. Fixes #31853
23884 * parameter.cs (Resolve): Do not allow void as a parameter type.
23886 2002-10-06 Martin Baulig <martin@gnome.org>
23888 * statemenc.cs (FlowBranching.SetParameterAssigned): Don't crash
23889 if it's a class type and not a struct. Fixes #31815.
23891 2002-10-06 Martin Baulig <martin@gnome.org>
23893 * statement.cs: Reworked the flow analysis code a bit to make it
23894 usable for dead code elimination.
23896 2002-10-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
23898 * cs-parser.jay: allow empty source files. Fixes bug #31781.
23900 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23902 * expression.cs (ComposedCast.DoResolveType): A quick workaround
23903 to fix the test 165, will investigate deeper.
23905 2002-10-04 Martin Baulig <martin@gnome.org>
23907 * statement.cs (FlowBranching.UsageVector.MergeChildren): Make
23908 finally blocks actually work.
23909 (Try.Resolve): We don't need to create a sibling for `finally' if
23910 there is no finally block.
23912 2002-10-04 Martin Baulig <martin@gnome.org>
23914 * class.cs (Constructor.Define): The default accessibility for a
23915 non-default constructor is private, not public.
23917 2002-10-04 Miguel de Icaza <miguel@ximian.com>
23919 * class.cs (Constructor): Make AllowedModifiers public, add
23922 * cs-parser.jay: Perform the modifiers test here, as the
23923 constructor for the Constructor class usually receives a zero
23924 because of the way we create it (first we create, later we
23925 customize, and we were never checking the modifiers).
23927 * typemanager.cs (Typemanager.LookupTypeDirect): This new function
23928 is a version of LookupTypeReflection that includes the type-name
23929 cache. This can be used as a fast path for functions that know
23930 the fully qualified name and are only calling into *.GetType() to
23931 obtain a composed type.
23933 This is also used by TypeManager.LookupType during its type
23936 (LookupType): We now also track the real type name, as sometimes
23937 we can get a quey for the real type name from things like
23938 ComposedCast. This fixes bug 31422.
23940 * expression.cs (ComposedCast.Resolve): Since we are obtaining a
23941 complete type fullname, it does not have to go through the type
23942 resolution system to obtain the composed version of the type (for
23943 obtaining arrays or pointers).
23945 (Conditional.Emit): Use the EmitBoolExpression to
23946 generate nicer code, as requested by Paolo.
23948 (ArrayCreation.CheckIndices): Use the patch from
23949 hwang_rob@yahoo.ca to validate the array initializers.
23951 2002-10-03 Miguel de Icaza <miguel@ximian.com>
23953 * class.cs (ConstructorInitializer.Emit): simplify code by using
23954 Invocation.EmitCall, and at the same time, fix the bugs in calling
23955 parent constructors that took variable arguments.
23957 * ecore.cs (Expression.ConvertNumericExplicit,
23958 Expression.ImplicitNumericConversion): Remove the code that
23959 manually wrapped decimal (InternalTypeConstructor call is now gone
23962 * expression.cs (Cast.TryReduce): Also handle decimal types when
23963 trying to perform a constant fold on the type.
23965 * typemanager.cs (IsUnmanagedtype): Partially implemented.
23967 * parameter.cs: Removed ResolveAndDefine, as it was not needed, as
23968 that only turned off an error report, and did nothing else.
23970 2002-10-02 Miguel de Icaza <miguel@ximian.com>
23972 * driver.cs: Handle and ignore /fullpaths
23974 2002-10-01 Miguel de Icaza <miguel@ximian.com>
23976 * expression.cs (Binary.ResolveOperator): Catch the case where
23977 DoNumericPromotions returns true,
23979 (Binary.DoNumericPromotions): Simplify the code, and the tests.
23981 2002-09-27 Miguel de Icaza <miguel@ximian.com>
23983 * ecore.cs (EventExpr.Emit): Instead of emitting an exception,
23986 2002-09-26 Miguel de Icaza <miguel@ximian.com>
23988 * ecore.cs (ConvertNumericExplicit): It is not enough that the
23989 conversion exists, but it is also required that the conversion be
23990 performed. This manifested in "(Type64Enum) 2".
23992 * class.cs (TypeManager.AddMethod): The fix is not to change
23993 AddEnum, because that one was using a fully qualified name (every
23994 DeclSpace derivative does), but to change the AddMethod routine
23995 that was using an un-namespaced name. This now correctly reports
23996 the duplicated name.
23998 Revert patch until I can properly fix it. The issue
23999 is that we have a shared Type space across all namespaces
24000 currently, which is wrong.
24002 Options include making the Namespace a DeclSpace, and merge
24003 current_namespace/current_container in the parser.
24005 2002-09-25 Miguel de Icaza <miguel@ximian.com>
24007 * cs-parser.jay: Improve error reporting when we get a different
24008 kind of expression in local_variable_type and
24009 local_variable_pointer_type.
24011 Propagate this to avoid missleading errors being reported.
24013 * ecore.cs (ImplicitReferenceConversion): treat
24014 TypeManager.value_type as a target just like object_type. As
24019 Is valid, and needs to result in the int 1 being boxed before it
24020 is assigned to the value type v.
24022 * class.cs (TypeContainer.AddEnum): Use the basename, not the name
24023 to validate the enumeration name.
24025 * expression.cs (ArrayAccess.EmitAssign): Mimic the same test from
24026 EmitDynamicInitializers for the criteria to use Ldelema. Thanks
24027 to hwang_rob@yahoo.ca for finding the bug and providing a patch.
24029 * ecore.cs (TryImplicitIntConversion): When doing an
24030 implicit-enumeration-conversion, check if the type is 64-bits and
24031 perform a conversion before passing to EnumConstant.
24033 2002-09-23 Miguel de Icaza <miguel@ximian.com>
24035 * decl.cs (Error_AmbiguousTypeReference); New routine used to
24036 report ambiguous type references. Unlike the MS version, we
24037 report what the ambiguity is. Innovation at work ;-)
24039 (DeclSpace.FindType): Require a location argument to
24040 display when we display an ambiguous error.
24042 * ecore.cs: (SimpleName.DoResolveType): Pass location to FindType.
24044 * interface.cs (GetInterfaceTypeByName): Pass location to FindType.
24046 * expression.cs (EmitDynamicInitializers): Apply patch from
24047 hwang_rob@yahoo.ca that fixes the order in which we emit our
24050 2002-09-21 Martin Baulig <martin@gnome.org>
24052 * delegate.cs (Delegate.VerifyApplicability): Make this work if the
24053 delegate takes no arguments.
24055 2002-09-20 Miguel de Icaza <miguel@ximian.com>
24057 * constant.cs: Use Conv_U8 instead of Conv_I8 when loading longs
24060 * expression.cs: Extract the underlying type.
24062 * ecore.cs (StoreFromPtr): Use TypeManager.IsEnumType instad of IsEnum
24064 * decl.cs (FindType): Sorry about this, fixed the type lookup bug.
24066 2002-09-19 Miguel de Icaza <miguel@ximian.com>
24068 * class.cs (TypeContainer.DefineType): We can not use the nice
24069 PackingSize with the size set to 1 DefineType method, because it
24070 will not allow us to define the interfaces that the struct
24073 This completes the fixing of bug 27287
24075 * ecore.cs (Expresion.ImplicitReferenceConversion): `class-type S'
24076 means also structs. This fixes part of the problem.
24077 (Expresion.ImplicitReferenceConversionExists): ditto.
24079 * decl.cs (DeclSparce.ResolveType): Only report the type-not-found
24080 error if there were no errors reported during the type lookup
24081 process, to avoid duplicates or redundant errors. Without this
24082 you would get an ambiguous errors plus a type not found. We have
24083 beaten the user enough with the first error.
24085 (DeclSparce.FindType): Emit a warning if we have an ambiguous
24088 * ecore.cs (SimpleName.DoResolveType): If an error is emitted
24089 during the resolution process, stop the lookup, this avoids
24090 repeated error reports (same error twice).
24092 * rootcontext.cs: Emit a warning if we have an ambiguous reference.
24094 * typemanager.cs (LookupType): Redo the type lookup code to match
24095 the needs of System.Reflection.
24097 The issue is that System.Reflection requires references to nested
24098 types to begin with a "+" sign instead of a dot. So toplevel
24099 types look like: "NameSpace.TopLevelClass", and nested ones look
24100 like "Namespace.TopLevelClass+Nested", with arbitrary nesting
24103 2002-09-19 Martin Baulig <martin@gnome.org>
24105 * codegen.cs (EmitContext.EmitTopBlock): If control flow analysis
24106 says that a method always returns or always throws an exception,
24107 don't report the CS0161.
24109 * statement.cs (FlowBranching.UsageVector.MergeChildren): Always
24110 set `Returns = new_returns'.
24112 2002-09-19 Martin Baulig <martin@gnome.org>
24114 * expression.cs (MemberAccess.ResolveMemberAccess): When resolving
24115 to an enum constant, check for a CS0176.
24117 2002-09-18 Miguel de Icaza <miguel@ximian.com>
24119 * class.cs (TypeContainer.CheckPairedOperators): Now we check
24120 for operators that must be in pairs and report errors.
24122 * ecore.cs (SimpleName.DoResolveType): During the initial type
24123 resolution process, when we define types recursively, we must
24124 check first for types in our current scope before we perform
24125 lookups in the enclosing scopes.
24127 * expression.cs (MakeByteBlob): Handle Decimal blobs.
24129 (Invocation.VerifyArgumentsCompat): Call
24130 TypeManager.TypeToCoreType on the parameter_type.GetElementType.
24131 I thought we were supposed to always call this, but there are a
24132 few places in the code where we dont do it.
24134 2002-09-17 Miguel de Icaza <miguel@ximian.com>
24136 * driver.cs: Add support in -linkres and -resource to specify the
24137 name of the identifier.
24139 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24141 * ecore.cs (StandardConversionExists): Sync with the conversion
24142 code: allow anything-* to void* conversions.
24144 (FindMostSpecificSource): Use an Expression argument
24145 instead of a Type, because we might be handed over a Literal which
24146 gets a few more implicit conversions that plain types do not. So
24147 this information was being lost.
24149 Also, we drop the temporary type-holder expression when not
24152 2002-09-17 Martin Baulig <martin@gnome.org>
24154 * class.cs (PropertyBase.CheckBase): Don't check the base class if
24155 this is an explicit interface implementation.
24157 2002-09-17 Martin Baulig <martin@gnome.org>
24159 * class.cs (PropertyBase.CheckBase): Make this work for indexers with
24160 different `IndexerName' attributes.
24162 * expression.cs (BaseIndexerAccess): Rewrote this class to use IndexerAccess.
24163 (IndexerAccess): Added special protected ctor for BaseIndexerAccess and
24164 virtual CommonResolve().
24166 2002-09-16 Miguel de Icaza <miguel@ximian.com>
24168 * enum.cs (LookupEnumValue): Use the EnumConstant declared type,
24169 and convert that to the UnderlyingType.
24171 * statement.cs (Foreach.Resolve): Indexers are just like variables
24172 or PropertyAccesses.
24174 * cs-tokenizer.cs (consume_string): Track line numbers and columns
24175 inside quoted strings, we were not doing this before.
24177 2002-09-16 Martin Baulig <martin@gnome.org>
24179 * ecore.cs (MethodGroupExpr.DoResolve): If we have an instance expression,
24180 resolve it. This is needed for the definite assignment check of the
24181 instance expression, fixes bug #29846.
24182 (PropertyExpr.DoResolve, EventExpr.DoResolve): Likewise.
24184 2002-09-16 Nick Drochak <ndrochak@gol.com>
24186 * parameter.cs: Fix compile error. Cannot reference static member
24187 from an instance object. Is this an mcs bug?
24189 2002-09-14 Martin Baulig <martin@gnome.org>
24191 * decl.cs (MemberCache.SetupCacheForInterface): Don't add an interface
24192 multiple times. Fixes bug #30295, added test-166.cs.
24194 2002-09-14 Martin Baulig <martin@gnome.org>
24196 * statement.cs (Block.Emit): Don't emit unreachable code.
24197 (Switch.SimpleSwitchEmit, Switch.TableSwitchEmit): Check for missing
24198 `break' statements.
24199 (Goto.Emit, Continue.Emit): Set ec.Breaks = true.
24201 2002-09-14 Martin Baulig <martin@gnome.org>
24203 * parameter.cs (Parameter.Attributes): Make this work if Modifier.ISBYREF
24206 2002-09-14 Martin Baulig <martin@gnome.org>
24208 * typemanager.cs (TypeManager.IsNestedChildOf): This must return false
24209 if `type == parent' since in this case `type.IsSubclassOf (parent)' will
24210 be false on the ms runtime.
24212 2002-09-13 Martin Baulig <martin@gnome.org>
24214 * ecore.cs (SimpleName.SimpleNameResolve): Include the member name in
24215 the CS0038 error message.
24217 2002-09-12 Miguel de Icaza <miguel@ximian.com>
24219 * expression.cs (CheckedExpr, UnCheckedExpr): If we have a
24220 constant inside, return it.
24222 2002-09-12 Martin Baulig <martin@gnome.org>
24224 * cfold.cs (ConstantFold.DoConstantNumericPromotions): Check whether an
24225 implicit conversion can be done between enum types.
24227 * enum.cs (Enum.LookupEnumValue): If the value is an EnumConstant,
24228 check whether an implicit conversion to the current enum's UnderlyingType
24229 exists and report an error if not.
24231 * codegen.cs (CodeGen.Init): Delete the symbol file when compiling
24232 without debugging support.
24234 * delegate.cs (Delegate.CloseDelegate): Removed, use CloseType instead.
24235 Fixes bug #30235. Thanks to Ricardo Fernández Pascual.
24237 2002-09-12 Martin Baulig <martin@gnome.org>
24239 * typemanager.cs (TypeManager.IsNestedChildOf): New method.
24241 * ecore.cs (IMemberExpr.DeclaringType): New property.
24242 (SimpleName.SimpleNameResolve): Check whether we're accessing a
24243 nonstatic member of an outer type (CS0038).
24245 2002-09-11 Miguel de Icaza <miguel@ximian.com>
24247 * driver.cs: Activate the using-error detector at warning level
24248 4 (at least for MS-compatible APIs).
24250 * namespace.cs (VerifyUsing): Small buglett fix.
24252 * pending.cs (PendingImplementation): pass the container pointer.
24254 * interface.cs (GetMethods): Allow for recursive definition. Long
24255 term, I would like to move every type to support recursive
24256 definitions, not the current ordering mechanism that we have right
24259 The situation is this: Attributes are handled before interfaces,
24260 so we can apply attributes to interfaces. But some attributes
24261 implement interfaces, we will now handle the simple cases
24262 (recursive definitions will just get an error).
24264 * parameter.cs: Only invalidate types at the end if we fail to
24267 2002-09-09 Martin Baulig <martin@gnome.org>
24269 * ecore.cs (PropertyExpr.Emit): Also check for
24270 TypeManager.system_int_array_get_length so this'll also work when
24271 compiling corlib. Fixes #30003.
24273 2002-09-09 Martin Baulig <martin@gnome.org>
24275 * expression.cs (ArrayCreation.MakeByteBlob): Added support for enums
24276 and throw an exception if we can't get the type's size. Fixed #30040,
24279 2002-09-09 Martin Baulig <martin@gnome.org>
24281 * ecore.cs (PropertyExpr.DoResolve): Added check for static properies.
24283 * expression.cs (SizeOf.DoResolve): Sizeof is only allowed in unsafe
24284 context. Fixes bug #30027.
24286 * delegate.cs (NewDelegate.Emit): Use OpCodes.Ldvirtftn for
24287 virtual functions. Fixes bug #30043, added test-164.cs.
24289 2002-09-08 Ravi Pratap <ravi@ximian.com>
24291 * attribute.cs : Fix a small NullRef crash thanks to my stupidity.
24293 2002-09-08 Nick Drochak <ndrochak@gol.com>
24295 * driver.cs: Use an object to get the windows codepage since it's not a
24298 2002-09-08 Miguel de Icaza <miguel@ximian.com>
24300 * statement.cs (For.Emit): for infinite loops (test == null)
24301 return whether there is a break inside, not always "true".
24303 * namespace.cs (UsingEntry): New struct to hold the name of the
24304 using definition, the location where it is defined, and whether it
24305 has been used in a successful type lookup.
24307 * rootcontext.cs (NamespaceLookup): Use UsingEntries instead of
24312 2002-09-06 Ravi Pratap <ravi@ximian.com>
24314 * attribute.cs : Fix incorrect code which relied on catching
24315 a NullReferenceException to detect a null being passed in
24316 where an object was expected.
24318 2002-09-06 Miguel de Icaza <miguel@ximian.com>
24320 * statement.cs (Try): flag the catch variable as assigned
24322 * expression.cs (Cast): Simplified by using ResolveType instead of
24323 manually resolving.
24325 * statement.cs (Catch): Fix bug by using ResolveType.
24327 2002-09-06 Ravi Pratap <ravi@ximian.com>
24329 * expression.cs (BetterConversion): Special case for when we have
24330 a NullLiteral as the argument and we have to choose between string
24331 and object types - we choose string the way csc does.
24333 * attribute.cs (Attribute.Resolve): Catch the
24334 NullReferenceException and report error #182 since the Mono
24335 runtime no more has the bug and having this exception raised means
24336 we tried to select a constructor which takes an object and is
24339 2002-09-05 Ravi Pratap <ravi@ximian.com>
24341 * expression.cs (Invocation.OverloadResolve): Flag a nicer error
24342 message (1502, 1503) when we can't locate a method after overload
24343 resolution. This is much more informative and closes the bug
24346 * interface.cs (PopulateMethod): Return if there are no argument
24347 types. Fixes a NullReferenceException bug.
24349 * attribute.cs (Attribute.Resolve): Ensure we allow TypeOf
24350 expressions too. Previously we were checking only in one place for
24351 positional arguments leaving out named arguments.
24353 * ecore.cs (ImplicitNumericConversion): Conversion from underlying
24354 type to the enum type is not allowed. Remove code corresponding to
24357 (ConvertNumericExplicit): Allow explicit conversions from
24358 the underlying type to enum type. This precisely follows the spec
24359 and closes a bug filed by Gonzalo.
24361 2002-09-04 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24364 * compiler.csproj.user: patch from Adam Chester (achester@bigpond.com).
24366 2002-09-03 Miguel de Icaza <miguel@ximian.com>
24368 * statement.cs (SwitchLabel.ResolveAndReduce): In the string case,
24369 it was important that we stored the right value after the
24370 reduction in `converted'.
24372 2002-09-04 Martin Baulig <martin@gnome.org>
24374 * location.cs (Location.SymbolDocument): Use full pathnames for the
24377 2002-08-30 Miguel de Icaza <miguel@ximian.com>
24379 * expression.cs (ComposedCast): Use DeclSparce.ResolveType instead
24380 of the expression resolve mechanism, because that will catch the
24381 SimpleName error failures.
24383 (Conditional): If we can not resolve the
24384 expression, return, do not crash.
24386 2002-08-29 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24389 (location): display token name instead of its number.
24391 2002-08-28 Martin Baulig <martin@gnome.org>
24393 * expression.cs (Binary.ResolveOperator): Don't silently return
24394 but return an error if an operator cannot be applied between two
24397 2002-08-28 Martin Baulig <martin@gnome.org>
24399 * class.cs (Constructor.Define): Set the permission attributes
24400 correctly instead of making all constructors public.
24402 2002-08-28 Martin Baulig <martin@gnome.org>
24404 * ecore.cs (Expression.DoResolve): Do a TypeManager.MemberLook
24405 for private members before reporting a CS0103; if we find anything,
24408 2002-08-28 Martin Baulig <martin@gnome.org>
24410 * typemanager.cs (TypeManager.FilterWithClosure): It's not enough
24411 to check whether `closure_start_type == closure_invocation_type',
24412 we also need to check whether `m.DeclaringType == closure_invocation_type'
24413 before bypassing the permission checks. We might be accessing
24414 protected/private members from the base class.
24415 (TypeManager.RealMemberLookup): Only set private_ok if private
24416 members were requested via BindingFlags.NonPublic.
24418 * ecore.cs (MethodGroupExpr.IsExplicitImpl): New property.
24420 * expression.cs (MemberAccess.ResolveMemberAccess): Set
24421 MethodGroupExpr.IsExplicitImpl if appropriate.
24422 (Invocation.DoResolve): Don't report the CS0120 for explicit
24423 interface implementations.
24425 2002-08-27 Martin Baulig <martin@gnome.org>
24427 * expression.cs (Invocation.DoResolve): If this is a static
24428 method and we don't have an InstanceExpression, we must report
24431 2002-08-25 Martin Baulig <martin@gnome.org>
24433 * expression.cs (Binary.ResolveOperator): Don't allow `!=' and
24434 `==' between a valuetype and an object.
24436 2002-08-25 Miguel de Icaza <miguel@ximian.com>
24438 * ecore.cs (TypeExpr): Provide a ToString method.
24440 2002-08-24 Martin Baulig <martin@gnome.org>
24442 * codegen.cs (CodeGen.InitMonoSymbolWriter): The symbol file is
24443 now called proggie.dbg and it's a binary file.
24445 2002-08-23 Martin Baulig <martin@gnome.org>
24447 * decl.cs (MemberCache.AddMethods): Ignore varargs methods.
24449 2002-08-23 Martin Baulig <martin@gnome.org>
24451 * struct.cs (MyStructInfo.ctor): Make this work with empty
24452 structs; it's not allowed to use foreach() on null.
24454 2002-08-23 Martin Baulig <martin@gnome.org>
24456 * codegen.cs (CodeGen.InitMonoSymbolWriter): Tell the symbol
24457 writer the full pathname of the generated assembly.
24459 2002-08-23 Martin Baulig <martin@gnome.org>
24461 * statements.cs (FlowBranching.UsageVector.MergeChildren):
24462 A `finally' block never returns or breaks; improved handling of
24465 2002-08-23 Martin Baulig <martin@gnome.org>
24467 * statement.cs (Throw.Resolve): Allow `throw null'.
24469 2002-08-23 Martin Baulig <martin@gnome.org>
24471 * expression.cs (MemberAccess.ResolveMemberAccess): If this is an
24472 EventExpr, don't do a DeclaredOnly MemberLookup, but check whether
24473 `ee.EventInfo.DeclaringType == ec.ContainerType'. The
24474 MemberLookup would return a wrong event if this is an explicit
24475 interface implementation and the class has an event with the same
24478 2002-08-23 Martin Baulig <martin@gnome.org>
24480 * statement.cs (Block.AddChildVariableNames): New public method.
24481 (Block.AddChildVariableName): Likewise.
24482 (Block.IsVariableNameUsedInChildBlock): Likewise.
24483 (Block.AddVariable): Check whether a variable name has already
24484 been used in a child block.
24486 * cs-parser.jay (declare_local_variables): Mark all variable names
24487 from the current block as being used in a child block in the
24490 2002-08-23 Martin Baulig <martin@gnome.org>
24492 * codegen.cs (CodeGen.InitializeSymbolWriter): Abort if we can't
24493 find the symbol writer.
24495 * driver.cs: csc also allows the arguments to /define being
24496 separated by commas, not only by semicolons.
24498 2002-08-23 Martin Baulig <martin@gnome.org>
24500 * interface.cs (Interface.GetMembers): Added static check for events.
24502 2002-08-15 Martin Baulig <martin@gnome.org>
24504 * class.cs (MethodData.EmitDestructor): In the Expression.MemberLookup
24505 call, use ec.ContainerType.BaseType as queried_type and invocation_type.
24507 * ecore.cs (Expression.MemberLookup): Added documentation and explained
24508 why the MethodData.EmitDestructor() change was necessary.
24510 2002-08-20 Martin Baulig <martin@gnome.org>
24512 * class.cs (TypeContainer.FindMembers): Added static check for events.
24514 * decl.cs (MemberCache.AddMembers): Handle events like normal members.
24516 * typemanager.cs (TypeHandle.GetMembers): When queried for events only,
24517 use Type.GetEvents(), not Type.FindMembers().
24519 2002-08-20 Martin Baulig <martin@gnome.org>
24521 * decl.cs (MemberCache): Added a special method cache which will
24522 be used for method-only searched. This ensures that a method
24523 search will return a MethodInfo with the correct ReflectedType for
24526 2002-08-20 Martin Baulig <martin@gnome.org>
24528 * decl.cs (DeclSpace.FindMembers): Made this public.
24530 2002-08-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24532 * delegate.cs: fixed build on windows.
24533 [FIXME: Filed as bug #29150: MCS must report these errors.]
24535 2002-08-19 Ravi Pratap <ravi@ximian.com>
24537 * ecore.cs (StandardConversionExists): Return a false
24538 if we are trying to convert the void type to anything else
24539 since that is not allowed.
24541 * delegate.cs (DelegateInvocation.DoResolve): Ensure that
24542 we flag error 70 in the event an event is trying to be accessed
24543 directly from outside the declaring type.
24545 2002-08-20 Martin Baulig <martin@gnome.org>
24547 * typemanager.cs, decl.cs: Moved MemberList, IMemberContainer and
24548 MemberCache from typemanager.cs to decl.cs.
24550 2002-08-19 Martin Baulig <martin@gnome.org>
24552 * class.cs (TypeContainer): Implement IMemberContainer.
24553 (TypeContainer.DefineMembers): Create the MemberCache.
24554 (TypeContainer.FindMembers): Do better BindingFlags checking; only
24555 return public members if BindingFlags.Public was given, check
24556 whether members are static.
24558 2002-08-16 Martin Baulig <martin@gnome.org>
24560 * decl.cs (DeclSpace.Define): Splitted this in Define and
24561 DefineMembers. DefineMembers is called first and initializes the
24564 * rootcontext.cs (RootContext.DefineMembers): New function. Calls
24565 DefineMembers() on all our DeclSpaces.
24567 * class.cs (TypeContainer.Define): Moved all code to DefineMembers(),
24568 but call DefineMembers() on all nested interfaces. We call their
24569 Define() in our new Define() function.
24571 * interface.cs (Interface): Implement IMemberContainer.
24572 (Interface.Define): Moved all code except the attribute stuf to
24574 (Interface.DefineMembers): Initialize the member cache.
24576 * typemanager.cs (IMemberFinder): Removed this interface, we don't
24577 need this anymore since we can use MemberCache.FindMembers directly.
24579 2002-08-19 Martin Baulig <martin@gnome.org>
24581 * typemanager.cs (MemberCache): When creating the cache for an
24582 interface type, add all inherited members.
24583 (TypeManager.MemberLookup_FindMembers): Changed `ref bool searching'
24584 to `out bool used_cache' and documented it.
24585 (TypeManager.MemberLookup): If we already used the cache in the first
24586 iteration, we don't need to do the interfaces check.
24588 2002-08-19 Martin Baulig <martin@gnome.org>
24590 * decl.cs (DeclSpace.FindMembers): New abstract method. Moved this
24591 here from IMemberFinder and don't implement this interface anymore.
24592 (DeclSpace.MemberCache): Moved here from IMemberFinder.
24594 * typemanager.cs (IMemberFinder): This interface is now only used by
24595 classes which actually support the member cache.
24596 (TypeManager.builder_to_member_finder): Renamed to builder_to_declspace
24597 since we only put DeclSpaces into this Hashtable.
24598 (MemberLookup_FindMembers): Use `builder_to_declspace' if the type is
24599 a dynamic type and TypeHandle.GetTypeHandle() otherwise.
24601 2002-08-16 Martin Baulig <martin@gnome.org>
24603 * typemanager.cs (ICachingMemberFinder): Removed.
24604 (IMemberFinder.MemberCache): New property.
24605 (TypeManager.FindMembers): Merged this with RealFindMembers().
24606 This function will never be called from TypeManager.MemberLookup()
24607 so we can't use the cache here, just the IMemberFinder.
24608 (TypeManager.MemberLookup_FindMembers): Check whether the
24609 IMemberFinder has a MemberCache and call the cache's FindMembers
24611 (MemberCache): Rewrote larger parts of this yet another time and
24612 cleaned it up a bit.
24614 2002-08-15 Miguel de Icaza <miguel@ximian.com>
24616 * driver.cs (LoadArgs): Support quoting.
24618 (Usage): Show the CSC-like command line arguments.
24620 Improved a few error messages.
24622 2002-08-15 Martin Baulig <martin@gnome.org>
24624 * typemanager.cs (IMemberContainer.Type): New property.
24625 (IMemberContainer.IsInterface): New property.
24627 The following changes are conditional to BROKEN_RUNTIME, which is
24628 defined at the top of the file.
24630 * typemanager.cs (MemberCache.MemberCache): Don't add the base
24631 class'es members, but add all members from TypeHandle.ObjectType
24632 if we're an interface.
24633 (MemberCache.AddMembers): Set the Declared flag if member.DeclaringType
24634 is the current type.
24635 (MemberCache.CacheEntry.Container): Removed this field.
24636 (TypeHandle.GetMembers): Include inherited members.
24638 2002-08-14 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24640 * typemanager.cs: fixed compilation and added a comment on a field that
24643 2002-08-15 Martin Baulig <martin@gnome.org>
24645 * class.cs (ConstructorInitializer.Resolve): In the
24646 Expression.MemberLookup call, use the queried_type as
24649 * typemanager.cs (IMemberContainer.GetMembers): Removed the `bool
24650 declared' attribute, it's always true.
24651 (IMemberContainer.Parent, IMemberContainer.Name): New properties.
24652 (TypeManager.MemberLookup_FindMembers): [FIXME FIXME FIXME] Added
24653 temporary wrapper for FindMembers which tells MemberLookup whether
24654 members from the base classes are included in the return value.
24655 This will go away soon.
24656 (TypeManager.MemberLookup): Use this temporary hack here; once the
24657 new MemberCache is completed, we don't need to do the DeclaredOnly
24658 looping here anymore since the MemberCache will take care of this.
24659 (TypeManager.IsSubclassOrNestedChildOf): Allow `type == parent'.
24660 (MemberCache): When creating the MemberCache for a class, get
24661 members from the current class and all its base classes.
24662 (MemberCache.CacheEntry.Container): New field. This is a
24663 temporary hack until the Mono runtime is fixed to distinguish
24664 between ReflectedType and DeclaringType. It allows us to use MCS
24665 with both the MS runtime and the unfixed Mono runtime without
24666 problems and without accecting performance.
24667 (MemberCache.SearchMembers): The DeclaredOnly looping from
24668 TypeManager.MemberLookup is now done here.
24670 2002-08-14 Martin Baulig <martin@gnome.org>
24672 * statement.cs (MyStructInfo.MyStructInfo): Don't call
24673 Type.GetFields on dynamic types but get the fields from the
24674 corresponding TypeContainer.
24675 (MyStructInfo.GetStructInfo): Added check for enum types.
24677 * typemanager.cs (MemberList.IsSynchronized): Implemented.
24678 (MemberList.SyncRoot): Implemented.
24679 (TypeManager.FilterWithClosure): No need to check permissions if
24680 closure_start_type == closure_invocation_type, don't crash if
24681 closure_invocation_type is null.
24683 2002-08-13 Martin Baulig <martin@gnome.org>
24685 Rewrote TypeContainer.FindMembers to use a member cache. This
24686 gives us a speed increase of about 35% for the self-hosting MCS
24687 build and of about 15-20% for the class libs (both on GNU/Linux).
24689 * report.cs (Timer): New class to get enhanced profiling. This
24690 whole class is "TIMER" conditional since it remarkably slows down
24693 * class.cs (MemberList): New class. This is an IList wrapper
24694 which we're now using instead of passing MemberInfo[]'s around to
24695 avoid copying this array unnecessarily.
24696 (IMemberFinder.FindMember): Return a MemberList, not a MemberInfo [].
24697 (ICachingMemberFinder, IMemberContainer): New interface.
24698 (TypeManager.FilterWithClosure): If `criteria' is null, the name
24699 has already been checked, otherwise use it for the name comparision.
24700 (TypeManager.FindMembers): Renamed to RealMemberFinder and
24701 provided wrapper which tries to use ICachingMemberFinder.FindMembers
24702 if possible. Returns a MemberList, not a MemberInfo [].
24703 (TypeHandle): New class, implements IMemberContainer. We create
24704 one instance of this class per type, it contains a MemberCache
24705 which is used to do the member lookups.
24706 (MemberCache): New class. Each instance of this class contains
24707 all members of a type and a name-based hash table.
24708 (MemberCache.FindMembers): This is our new member lookup
24709 function. First, it looks up all members of the requested name in
24710 the hash table. Then, it walks this list and sorts out all
24711 applicable members and returns them.
24713 2002-08-13 Martin Baulig <martin@gnome.org>
24715 In addition to a nice code cleanup, this gives us a performance
24716 increase of about 1.4% on GNU/Linux - not much, but it's already
24717 half a second for the self-hosting MCS compilation.
24719 * typemanager.cs (IMemberFinder): New interface. It is used by
24720 TypeManager.FindMembers to call FindMembers on a TypeContainer,
24721 Enum, Delegate or Interface.
24722 (TypeManager.finder_to_member_finder): New PtrHashtable.
24723 (TypeManager.finder_to_container): Removed.
24724 (TypeManager.finder_to_delegate): Removed.
24725 (TypeManager.finder_to_interface): Removed.
24726 (TypeManager.finder_to_enum): Removed.
24728 * interface.cs (Interface): Implement IMemberFinder.
24730 * delegate.cs (Delegate): Implement IMemberFinder.
24732 * enum.cs (Enum): Implement IMemberFinder.
24734 * class.cs (TypeContainer): Implement IMemberFinder.
24736 2002-08-12 Martin Baulig <martin@gnome.org>
24738 * ecore.cs (TypeExpr.DoResolveType): Mark this as virtual.
24740 2002-08-12 Martin Baulig <martin@gnome.org>
24742 * ecore.cs (ITypeExpression): New interface for expressions which
24744 (TypeExpression): Renamed to TypeLookupExpression.
24745 (Expression.DoResolve): If we're doing a types-only lookup, the
24746 expression must implement the ITypeExpression interface and we
24747 call DoResolveType() on it.
24748 (SimpleName): Implement the new ITypeExpression interface.
24749 (SimpleName.SimpleNameResolve): Removed the ec.OnlyLookupTypes
24750 hack, the situation that we're only looking up types can't happen
24751 anymore when this method is called. Moved the type lookup code to
24752 DoResolveType() and call it.
24753 (SimpleName.DoResolveType): This ITypeExpression interface method
24754 is now doing the types-only lookup.
24755 (TypeExpr, TypeLookupExpression): Implement ITypeExpression.
24756 (ResolveFlags): Added MaskExprClass.
24758 * expression.cs (MemberAccess): Implement the ITypeExpression
24760 (MemberAccess.DoResolve): Added support for a types-only lookup
24761 when we're called via ITypeExpression.DoResolveType().
24762 (ComposedCast): Implement the ITypeExpression interface.
24764 * codegen.cs (EmitContext.OnlyLookupTypes): Removed. Call
24765 Expression.Resolve() with ResolveFlags.Type instead.
24767 2002-08-12 Martin Baulig <martin@gnome.org>
24769 * interface.cs (Interface.Define): Apply attributes.
24771 * attribute.cs (Attribute.ApplyAttributes): Added support for
24772 interface attributes.
24774 2002-08-11 Martin Baulig <martin@gnome.org>
24776 * statement.cs (Block.Emit): Only check the "this" variable if we
24777 do not always throw an exception.
24779 * ecore.cs (PropertyExpr.DoResolveLValue): Implemented, check
24780 whether the property has a set accessor.
24782 2002-08-11 Martin Baulig <martin@gnome.org>
24784 Added control flow analysis support for structs.
24786 * ecore.cs (ResolveFlags): Added `DisableFlowAnalysis' to resolve
24787 with control flow analysis turned off.
24788 (IVariable): New interface.
24789 (SimpleName.SimpleNameResolve): If MemberAccess.ResolveMemberAccess
24790 returns an IMemberExpr, call DoResolve/DoResolveLValue on it.
24791 (FieldExpr.DoResolve): Resolve the instance expression with flow
24792 analysis turned off and do the definite assignment check after the
24793 resolving when we know what the expression will resolve to.
24795 * expression.cs (LocalVariableReference, ParameterReference):
24796 Implement the new IVariable interface, only call the flow analysis
24797 code if ec.DoFlowAnalysis is true.
24798 (This): Added constructor which takes a Block argument. Implement
24799 the new IVariable interface.
24800 (MemberAccess.DoResolve, MemberAccess.DoResolveLValue): Call
24801 DoResolve/DoResolveLValue on the result of ResolveMemberLookup().
24802 This does the definite assignment checks for struct members.
24804 * class.cs (Constructor.Emit): If this is a non-static `struct'
24805 constructor which doesn't have any initializer, call
24806 Block.AddThisVariable() to tell the flow analysis code that all
24807 struct elements must be initialized before control returns from
24810 * statement.cs (MyStructInfo): New public class.
24811 (UsageVector.this [VariableInfo vi]): Added `int field_idx'
24812 argument to this indexer. If non-zero, check an individual struct
24813 member, not the whole struct.
24814 (FlowBranching.CheckOutParameters): Check struct members.
24815 (FlowBranching.IsVariableAssigned, SetVariableAssigned): Added
24816 overloaded versions of these methods which take an additional
24817 `int field_idx' argument to check struct members.
24818 (FlowBranching.IsParameterAssigned, SetParameterAssigned): Added
24819 overloaded versions of these methods which take an additional
24820 `string field_name' argument to check struct member.s
24821 (VariableInfo): Implement the IVariable interface.
24822 (VariableInfo.StructInfo): New public property. Returns the
24823 MyStructInfo instance of the variable if it's a struct or null.
24824 (Block.AddThisVariable): New public method. This is called from
24825 Constructor.Emit() for non-static `struct' constructor which do
24826 not have any initializer. It creates a special variable for the
24827 "this" instance variable which will be checked by the flow
24828 analysis code to ensure that all of the struct's fields are
24829 initialized before control returns from the constructor.
24830 (UsageVector): Added support for struct members. If a
24831 variable/parameter is a struct with N members, we reserve a slot
24832 in the usage vector for each member. A struct is considered fully
24833 initialized if either the struct itself (slot 0) or all its
24834 members are initialized.
24836 2002-08-08 Martin Baulig <martin@gnome.org>
24838 * driver.cs (Driver.MainDriver): Only report an error CS5001
24839 if there were no compilation errors.
24841 * codegen.cs (EmitContext.EmitContext): Use the DeclSpace's
24842 `UnsafeContext' property to determine whether the parent is in
24843 unsafe context rather than checking the parent's ModFlags:
24844 classes nested in an unsafe class are unsafe as well.
24846 2002-08-08 Martin Baulig <martin@gnome.org>
24848 * statement.cs (UsageVector.MergeChildren): Distinguish between
24849 `Breaks' and `Returns' everywhere, don't set `Breaks' anymore if
24850 we return. Added test17() and test18() to test-154.cs.
24852 2002-08-08 Martin Baulig <martin@gnome.org>
24854 * typemanager.cs (TypeManager.FilterWithClosure): If we have
24855 Family access, make sure the invoking type isn't a subclass of the
24856 queried type (that'd be a CS1540).
24858 * ecore.cs (Expression.MemberLookup): Added overloaded version of
24859 this method which takes an additional `Type invocation_type'.
24861 * expression.cs (BaseAccess.DoResolve): Use the base type as
24862 invocation and query type.
24863 (MemberAccess.DoResolve): If the lookup failed and we're about to
24864 report a CS0122, try a lookup with the ec.ContainerType - if this
24865 succeeds, we must report a CS1540.
24867 2002-08-08 Martin Baulig <martin@gnome.org>
24869 * ecore.cs (IMemberExpr): Added `bool IsInstance' property.
24870 (MethodGroupExpr): Implement the IMemberExpr interface.
24872 * expression (MemberAccess.ResolveMemberAccess): No need to have
24873 any special code for MethodGroupExprs anymore, they're now
24876 2002-08-08 Martin Baulig <martin@gnome.org>
24878 * typemanager.cs (TypeManager.FilterWithClosure): Check Assembly,
24879 Family, FamANDAssem and FamORAssem permissions.
24880 (TypeManager.IsSubclassOrNestedChildOf): New public method.
24882 2002-08-08 Martin Baulig <martin@gnome.org>
24884 * statement.cs (FlowBranchingType): Added LOOP_BLOCK.
24885 (UsageVector.MergeChildren): `break' breaks unless we're in a switch
24888 Thu Aug 8 10:28:07 CEST 2002 Paolo Molaro <lupus@ximian.com>
24890 * driver.cs: implemented /resource option to embed managed resources.
24892 2002-08-07 Martin Baulig <martin@gnome.org>
24894 * class.cs (FieldBase.Initializer): Renamed to `init' and made private.
24895 (FieldBase.HasFieldInitializer): New public property.
24896 (FieldBase.GetInitializerExpression): New public method. Resolves and
24897 returns the field initializer and makes sure it is only resolved once.
24898 (TypeContainer.EmitFieldInitializers): Call
24899 FieldBase.GetInitializerExpression to get the initializer, this ensures
24900 that it isn't resolved multiple times.
24902 * codegen.cs (EmitContext): Added `bool IsFieldInitialier'. This tells
24903 the resolving process (SimpleName/MemberLookup) that we're currently
24904 emitting a field initializer (which must not access any instance members,
24905 this is an error CS0236).
24907 * ecore.cs (SimpleName.Error_ObjectRefRequired): Added EmitContext
24908 argument, if the `IsFieldInitializer' flag is set, we must report and
24909 error CS0236 and not an error CS0120.
24911 2002-08-07 Martin Baulig <martin@gnome.org>
24913 * ecore.cs (IMemberExpr): New public interface.
24914 (FieldExpr, PropertyExpr, EventExpr): Implement IMemberExpr.
24915 (SimpleName.SimpleNameResolve): Call MemberAccess.ResolveMemberAccess
24916 if the expression is an IMemberExpr.
24918 * expression.cs (MemberAccess.ResolveMemberAccess): Allow `left'
24919 to be null, implicitly default to `this' if we're non-static in
24920 this case. Simplified the code a lot by using the new IMemberExpr
24921 interface. Also fixed bug #28176 here.
24923 2002-08-06 Martin Baulig <martin@gnome.org>
24925 * cs-parser.jay (SimpleLookup): Removed. We need to create
24926 ParameterReferences during semantic analysis so that we can do a
24927 type-only search when resolving Cast, TypeOf and SizeOf.
24928 (block): Pass the `current_local_parameters' to the Block's
24931 * class.cs (ConstructorInitializer): Added `Parameters parameters'
24932 argument to the constructor.
24933 (ConstructorInitializer.Resolve): Create a temporary implicit
24934 block with the parameters.
24936 * ecore.cs (SimpleName.SimpleNameResolve): Resolve parameter
24937 references here if we aren't doing a type-only search.
24939 * statement.cs (Block): Added constructor which takes a
24940 `Parameters parameters' argument.
24941 (Block.Parameters): New public property.
24943 * support.cs (InternalParameters.Parameters): Renamed `parameters'
24944 to `Parameters' and made it public readonly.
24946 2002-08-06 Martin Baulig <martin@gnome.org>
24948 * ecore.cs (Expression.Warning): Made this public as well.
24950 * report.cs (Report.Debug): Print the contents of collections.
24952 2002-08-06 Martin Baulig <martin@gnome.org>
24954 * ecore.cs (Expression.ResolveFlags): New [Flags] enum. This is
24955 used to tell Resolve() which kinds of expressions it may return.
24956 (Expression.Resolve): Added overloaded version of this method which
24957 takes a `ResolveFlags flags' argument. This can be used to tell
24958 Resolve() which kinds of expressions it may return. Reports a
24960 (Expression.ResolveWithSimpleName): Removed, use Resolve() with
24961 ResolveFlags.SimpleName.
24962 (Expression.Error118): Added overloaded version of this method which
24963 takes a `ResolveFlags flags' argument. It uses the flags to determine
24964 which kinds of expressions are allowed.
24966 * expression.cs (Argument.ResolveMethodGroup): New public method.
24967 Resolves an argument, but allows a MethodGroup to be returned.
24968 This is used when invoking a delegate.
24970 * TODO: Updated a bit.
24972 2002-08-06 Gonzalo Paniagua Javier <gonzalo@ximian.com>
24974 Fixed compilation with csc.
24976 * ecore.cs: Expression.Error made public. Is this correct? Should
24977 Warning be made public too?
24979 * expression.cs: use ea.Location instead of ea.loc.
24980 [FIXME: Filed as bug #28607: MCS must report these errors.]
24982 2002-08-06 Martin Baulig <martin@gnome.org>
24984 * ecore.cs (Expression.loc): Moved the location here instead of
24985 duplicating it in all derived classes.
24986 (Expression.Location): New public property.
24987 (Expression.Error, Expression.Warning): Made them non-static and
24988 removed the location argument.
24989 (Expression.Warning): Added overloaded version which takes an
24990 `int level' argument.
24991 (Expression.Error118): Make this non-static and removed the
24992 expression and location arguments.
24993 (TypeExpr): Added location argument to the constructor.
24995 * expression.cs (StaticCallExpr): Added location argument to
24997 (Indirection, PointerArithmetic): Likewise.
24998 (CheckedExpr, UnCheckedExpr): Likewise.
24999 (ArrayAccess, IndexerAccess, UserCast, ArrayPtr): Likewise.
25000 (StringPtr): Likewise.
25003 2002-08-05 Martin Baulig <martin@gnome.org>
25005 * expression.cs (BaseAccess.DoResolve): Actually report errors.
25007 * assign.cs (Assign.DoResolve): Check whether the source
25008 expression is a value or variable.
25010 * statement.cs (Try.Resolve): Set ec.InTry/InCatch/InFinally
25011 while resolving the corresponding blocks.
25013 * interface.cs (Interface.GetInterfaceTypeByName): Actually report
25014 an error, don't silently return null.
25016 * statement.cs (Block.AddVariable): Do the error reporting here
25017 and distinguish between CS0128 and CS0136.
25018 (Block.DoResolve): Report all unused labels (warning CS0164).
25019 (LabeledStatement): Pass the location to the constructor.
25020 (LabeledStatement.HasBeenReferenced): New property.
25021 (LabeledStatement.Resolve): Set it to true here.
25023 * statement.cs (Return.Emit): Return success even after reporting
25024 a type mismatch error (CS0126 or CS0127), this is what csc does and
25025 it avoids confusing the users with any consecutive errors.
25027 2002-08-05 Martin Baulig <martin@gnome.org>
25029 * enum.cs (Enum.LookupEnumValue): Catch circular definitions.
25031 * const.cs (Const.LookupConstantValue): Catch circular definitions.
25033 * expression.cs (MemberAccess.DoResolve): Silently return if an
25034 error has already been reported.
25036 * ecore.cs (Expression.MemberLookupFinal): Silently return if an
25037 error has already been reported.
25039 2002-08-05 Martin Baulig <martin@gnome.org>
25041 * statement.cs (UsageVector): Only initialize the `parameters'
25042 vector if we actually have any "out" parameters.
25044 2002-08-05 Martin Baulig <martin@gnome.org>
25046 * expression.cs (Binary.ResolveOperator): When combining delegates,
25047 they must have the same type.
25049 2002-08-05 Martin Baulig <martin@gnome.org>
25051 * typemanager.cs (TypeManager.GetArgumentTypes): Don't call
25052 PropertyInfo.GetIndexParameters() on dynamic types, this doesn't
25053 work with the ms runtime and we also don't need it: if we're a
25054 PropertyBuilder and not in the `indexer_arguments' hash, then we
25055 are a property and not an indexer.
25057 * class.cs (TypeContainer.AsAccessible): Use Type.IsArray,
25058 Type.IsPointer and Type.IsByRef instead of Type.HasElementType
25059 since the latter one doesn't work with the ms runtime.
25061 2002-08-03 Martin Baulig <martin@gnome.org>
25063 Fixed bugs #27998 and #22735.
25065 * class.cs (Method.IsOperator): New public field.
25066 (Method.CheckBase): Report CS0111 if there's already a method
25067 with the same parameters in the current class. Report CS0508 when
25068 attempting to change the return type of an inherited method.
25069 (MethodData.Emit): Report CS0179 if a method doesn't have a body
25070 and it's not marked abstract or extern.
25071 (PropertyBase): New abstract base class for Property and Indexer.
25072 (PropertyBase.CheckBase): Moved here from Property and made it work
25074 (PropertyBase.Emit): Moved here from Property.Emit, Indexer.Emit is
25075 the same so we can reuse it there.
25076 (Property, Indexer): Derive from PropertyBase.
25077 (MethodSignature.inheritable_property_signature_filter): New delegate
25078 to find properties and indexers.
25080 * decl.cs (MemberCore.CheckMethodAgainstBase): Added `string name'
25081 argument and improved error reporting.
25083 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): Renamed to
25084 EmptyReadOnlyParameters and made it a property.
25086 * typemanager.cs (TypeManager.GetArgumentTypes): Added overloaded
25087 version of this method which takes a `PropertyInfo indexer'.
25088 (TypeManager.RegisterIndexer): New method.
25090 * class.cs: Added myself as author of this file :-)
25092 2002-08-03 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25094 * class.cs: fixed compilation on windoze.
25096 2002-08-03 Martin Baulig <martin@gnome.org>
25098 * interface.cs (Interface.GetInterfaceBases): Check whether all
25099 base interfaces are at least as accessible than the current one.
25101 * class.cs (TypeContainer.GetClassBases): Check whether base types
25102 are at least as accessible than the current type.
25103 (TypeContainer.AsAccessible): Implemented and made non-static.
25104 (MemberBase.CheckParameters): Report errors if the accessibility
25107 * delegate.cs (Delegate.Delegate): The default visibility is
25108 internal for top-level types and private for nested types.
25109 (Delegate.Define): Report errors if the accessibility checks fail.
25111 * enum.cs (Enum.Enum): The default visibility is internal for
25112 top-level types and private for nested types.
25113 (Enum.DefineType): Compute the correct visibility.
25115 * modifiers.cs (Modifiers.TypeAttr): Added a version of this
25116 function which takes a `bool is_toplevel' instead of a TypeContainer.
25118 * typemanager.cs (TypeManager.IsBuiltinType): `void' is also a
25121 2002-08-02 Martin Baulig <martin@gnome.org>
25123 * expression.cs (LocalVariableReferenc): Added constructor which
25124 takes additional `VariableInfo vi' and `bool is_readonly' arguments.
25125 (LocalVariableReference.IsReadOnly): New property.
25126 (LocalVariableReference.DoResolveLValue): Report a CS1604 if the
25127 variable is readonly, use our own readonly flag to do this; you can
25128 use the new constructor to get a writable reference to a read-only
25131 * cs-parser.jay (foreach_statement, using_statement): Get a writable
25132 reference to the local variable.
25134 2002-08-01 Miguel de Icaza <miguel@ximian.com>
25136 * rootcontext.cs (ResolveCore): Also include System.Exception
25138 * statement.cs (Block.Emit): Do not emit the dead-code warnings if
25139 we reach an EmptyStatement.
25141 (Catch.DoResolve, Throw.DoResolve): Throwing the System.Exception
25144 * expression.cs (Binary.ResolveOperator): Check error result in
25147 use brtrue/brfalse directly and avoid compares to null.
25149 2002-08-02 Martin Baulig <martin@gnome.org>
25151 * class.cs (TypeContainer.Define): Define all nested interfaces here.
25152 Fixes bug #28407, added test-155.cs.
25154 2002-08-01 Martin Baulig <martin@gnome.org>
25156 * class.cs (Event.EmitDefaultMethod): Make this work with static
25157 events. Fixes #28311, added verify-3.cs.
25159 2002-08-01 Martin Baulig <martin@gnome.org>
25161 * statement.cs (ForeachHelperMethods): Added `enumerator_type' and
25162 `is_disposable' fields.
25163 (Foreach.GetEnumeratorFilter): Set `hm.enumerator_type' and
25164 `hm.is_disposable' if we're using the collection pattern.
25165 (Foreach.EmitCollectionForeach): Use the correct type for the
25166 enumerator's local variable, only emit the try/finally block if
25167 necessary (fixes #27713).
25169 2002-08-01 Martin Baulig <martin@gnome.org>
25171 * ecore.cs (Expression.report118): Renamed to Error118 and made
25174 * statement.cs (Throw.Resolve): Check whether the expression is of
25175 the correct type (CS0118) and whether the type derives from
25176 System.Exception (CS0155).
25177 (Catch.Resolve): New method. Do the type lookup here and check
25178 whether it derives from System.Exception (CS0155).
25179 (Catch.CatchType, Catch.IsGeneral): New public properties.
25181 * typemanager.cs (TypeManager.exception_type): Added.
25183 2002-07-31 Miguel de Icaza <miguel@ximian.com>
25185 * driver.cs: Updated About function.
25187 2002-07-31 Martin Baulig <martin@gnome.org>
25189 Implemented Control Flow Analysis.
25191 * codegen.cs (EmitContext.DoFlowAnalysis): New public variable.
25192 (EmitContext.CurrentBranching): Added.
25193 (EmitContext.StartFlowBranching): Added.
25194 (EmitContext.EndFlowBranching): Added.
25195 (EmitContext.KillFlowBranching): Added.
25196 (EmitContext.IsVariableAssigned): Added.
25197 (EmitContext.SetVariableAssigned): Added.
25198 (EmitContext.IsParameterAssigned): Added.
25199 (EmitContext.SetParameterAssigned): Added.
25200 (EmitContext.EmitTopBlock): Added `InternalParameters ip' argument.
25201 Added control flow analysis stuff here.
25203 * expression.cs (Unary.DoResolve): If the operator is Oper.AddressOf,
25204 resolve the expression as lvalue.
25205 (LocalVariableReference.DoResolve): Check whether the variable has
25206 already been assigned.
25207 (ParameterReference.DoResolveLValue): Override lvalue resolve to mark
25208 the parameter as assigned here.
25209 (ParameterReference.DoResolve): Check whether the parameter has already
25211 (Argument.Resolve): If it's a `ref' or `out' argument, resolve the
25212 expression as lvalue.
25214 * statement.cs (FlowBranching): New class for the flow analysis code.
25215 (Goto): Resolve the label in Resolve, not in Emit; added flow analysis.
25216 (LabeledStatement.IsDefined): New public property.
25217 (LabeledStatement.AddUsageVector): New public method to tell flow
25218 analyis that the label may be reached via a forward jump.
25219 (GotoCase): Lookup and resolve the label in Resolve, not in Emit; added
25221 (VariableInfo.Number): New public field. This is used by flow analysis
25222 to number all locals of a block.
25223 (Block.CountVariables): New public property. This is the number of
25224 local variables in this block (including the locals from all parent
25226 (Block.EmitMeta): Number all the variables.
25228 * statement.cs: Added flow analysis support to all classes.
25230 2002-07-31 Martin Baulig <martin@gnome.org>
25232 * driver.cs: Added "--mcs-debug" argument if MCS_DEBUG is defined.
25233 To get debugging messages, compile mcs with /define:MCS_DEBUG and
25234 then use this argument.
25236 * report.cs (Report.Debug): Renamed to conditional to "MCS_DEBUG".
25238 * makefile.gnu (MCS_FLAGS): Include $(MCS_DEFINES), the user may
25239 use this to specify /define options.
25241 2002-07-29 Martin Baulig <martin@gnome.org>
25243 * statement.cs (Fixed): Moved all code that does variable lookups
25244 and resolvings from Emit to Resolve.
25246 * statement.cs (For): Moved all code that does variable lookups
25247 and resolvings from Emit to Resolve.
25249 * statement.cs (Using): Moved all code that does variable lookups
25250 and resolvings from Emit to Resolve.
25252 2002-07-29 Martin Baulig <martin@gnome.org>
25254 * attribute.cs (Attribute.Resolve): Explicitly catch a
25255 System.NullReferenceException when creating the
25256 CustromAttributeBuilder and report a different warning message.
25258 2002-07-29 Martin Baulig <martin@gnome.org>
25260 * support.cs (ParameterData.ParameterName): Added method to
25261 get the name of a parameter.
25263 * typemanager.cs (TypeManager.IsValueType): New public method.
25265 2002-07-29 Martin Baulig <martin@gnome.org>
25267 * parameter.cs (Parameter.Modifier): Added `ISBYREF = 8'. This
25268 is a flag which specifies that it's either ref or out.
25269 (Parameter.GetParameterInfo (DeclSpace, int, out bool)): Changed
25270 the out parameter to `out Parameter.Modifier mod', also set the
25271 Parameter.Modifier.ISBYREF flag on it if it's either ref or out.
25273 * support.cs (InternalParameters.ParameterModifier): Distinguish
25274 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25275 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25277 * expression.cs (Argument.GetParameterModifier): Distinguish
25278 between Parameter.Modifier.OUT and Parameter.Modifier.REF, set the
25279 Parameter.Modifier.ISBYREF flag if it's either ref or out.
25281 2002-07-29 Martin Baulig <martin@gnome.org>
25283 * expression.cs (ParameterReference.ParameterReference): Added
25284 `Location loc' argument to the constructor.
25286 * cs-parser.jay: Pass location to ParameterReference.
25288 2002-07-28 Miguel de Icaza <miguel@ximian.com>
25290 * statement.cs (Try): Initialize the location.
25292 * cs-parser.jay: pass location to Try.
25294 * expression.cs (Unary.Reduce): Change the prototype to return
25295 whether a constant fold could be performed or not. The result is
25296 returned in an out parameters. In the case of Indirection and
25297 AddressOf, we want to perform the full tests.
25299 2002-07-26 Miguel de Icaza <miguel@ximian.com>
25301 * statement.cs (Statement.Emit): Flag dead code.
25303 2002-07-27 Andrew Birkett <andy@nobugs.org>
25305 * expression.cs (Unary.Reduce): Handle AddressOf and Indirection.
25307 2002-07-27 Martin Baulig <martin@gnome.org>
25309 * class.cs (MethodData.Define): Put back call to
25310 TypeManager.AddMethod(), accidentally commented this out.
25312 * report.cs (Debug): New public method to print debugging information,
25313 this is `[Conditional ("DEBUG")]'.
25315 2002-07-26 Martin Baulig <martin@gnome.org>
25317 * cs-parser.jay (CSharpParser): Added `Stack switch_stack'.
25318 (switch_statement): Push the current_block to the switch_stack and
25319 pop it again when we're done with the switch.
25320 (switch_section): The new block is a child of the current_block.
25321 Fixes bug #24007, added test-152.cs.
25323 2002-07-27 Martin Baulig <martin@gnome.org>
25325 * expression.cs (Invocation.EmitArguments): When calling a varargs
25326 function with only its fixed arguments, we need to pass an empty
25329 2002-07-27 Martin Baulig <martin@gnome.org>
25331 Mono 0.13 has been released.
25333 2002-07-25 Miguel de Icaza <miguel@ximian.com>
25335 * driver.cs: Rename --resource to --linkres, because that is what
25336 we do currently, we dont support --resource yet.
25338 * cs-tokenizer.cs: Fix test for reporting endif mismatches.
25340 2002-07-25 Martin Baulig <martin@gnome.org>
25342 * class.cs (MethodData): New public class. This is a `method builder'
25343 class for a method or one accessor of a Property/Indexer/Event.
25344 (MethodData.GetMethodFlags): Moved here from MemberBase.
25345 (MethodData.ApplyAttributes): Likewise.
25346 (MethodData.ApplyObsoleteAttribute): Likewise.
25347 (MethodData.ApplyConditionalAttribute): Likewise.
25348 (MethodData.ApplyDllImportAttribute): Likewise.
25349 (MethodData.CheckAbstractAndExternal): Likewise.
25350 (MethodData.Define): Formerly knows as MemberBase.DefineMethod().
25351 (MethodData.Emit): Formerly known as Method.Emit().
25352 (MemberBase): Moved everything which was specific to a single
25353 accessor/method to MethodData.
25354 (Method): Create a new MethodData and call Define() and Emit() on it.
25355 (Property, Indexer, Event): Create a new MethodData objects for each
25356 accessor and call Define() and Emit() on them.
25358 2002-07-25 Martin Baulig <martin@gnome.org>
25360 Made MethodCore derive from MemberBase to reuse the code from there.
25361 MemberBase now also checks for attributes.
25363 * class.cs (MethodCore): Derive from MemberBase, not MemberCore.
25364 (MemberBase.GetMethodFlags): Moved here from class Method and marked
25366 (MemberBase.DefineAccessor): Renamed to DefineMethod(), added
25367 `CallingConventions cc' and `Attributes opt_attrs' arguments.
25368 (MemberBase.ApplyAttributes): New virtual method; applies the
25369 attributes to a method or accessor.
25370 (MemberBase.ApplyObsoleteAttribute): New protected virtual method.
25371 (MemberBase.ApplyConditionalAttribute): Likewise.
25372 (MemberBase.ApplyDllImportAttribute): Likewise.
25373 (MemberBase.CheckAbstractAndExternal): Likewise.
25374 (MethodCore.ParameterTypes): This is now a property instead of a
25375 method, it's initialized from DoDefineParameters().
25376 (MethodCore.ParameterInfo): Removed the set accessor.
25377 (MethodCore.DoDefineParameters): New protected virtual method to
25378 initialize ParameterTypes and ParameterInfo.
25379 (Method.GetReturnType): We can now simply return the MemberType.
25380 (Method.GetMethodFlags): Override the MemberBase version and add
25381 the conditional flags.
25382 (Method.CheckBase): Moved some code from Define() here, call
25383 DoDefineParameters() here.
25384 (Method.Define): Use DoDefine() and DefineMethod() from MemberBase
25385 here to avoid some larger code duplication.
25386 (Property.Emit, Indexer.Emit): Call CheckAbstractAndExternal() to
25387 ensure that abstract and external accessors don't declare a body.
25389 * attribute.cs (Attribute.GetValidPieces): Make this actually work:
25390 `System.Attribute.GetCustomAttributes (attr.Type)' does a recursive
25391 lookup in the attribute's parent classes, so we need to abort as soon
25392 as we found the first match.
25393 (Attribute.Obsolete_GetObsoleteMessage): Return the empty string if
25394 the attribute has no arguments.
25396 * typemanager.cs (TypeManager.AddMethod): Now takes a MemberBase instead
25399 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25401 * cs-parser.jay: reverted previous patch.
25403 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25405 * cs-parser.jay: fixed bug #22119.
25407 2002-07-24 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25409 * attribute.cs: fixed compilation. The error was:
25410 "attribute.cs(571,17): error CS0177: The out parameter 'is_error' must
25411 be assigned to before control leaves the current method."
25412 [FIXME: Filed as bug #28186: MCS must report this error.]
25414 2002-07-25 Martin Baulig <martin@gnome.org>
25416 * attribute.cs (Attribute.Conditional_GetConditionName): New static
25417 method to pull the condition name ouf of a Conditional attribute.
25418 (Attribute.Obsolete_GetObsoleteMessage): New static method to pull
25419 the obsolete message and error flag out of an Obsolete attribute.
25421 * class.cs (Method.GetMethodFlags): New public method to get the
25422 TypeManager.MethodFlags for this method.
25423 (Method.ApplyConditionalAttribute, Method.ApplyObsoleteAttribute): New
25425 (Method.Define): Get and apply the Obsolete and Conditional attributes;
25426 if we're overriding a virtual function, set the new private variable
25427 `parent_method'; call the new TypeManager.AddMethod().
25429 * typemanager.cs (TypeManager.AddMethod): New static method. Stores
25430 the MethodBuilder and the Method in a PtrHashtable.
25431 (TypeManager.builder_to_method): Added for this purpose.
25432 (TypeManager.MethodFlags): Added IsObsoleteError.
25433 (TypeManager.GetMethodFlags): Added `Location loc' argument. Lookup
25434 Obsolete and Conditional arguments in MethodBuilders. If we discover
25435 an Obsolete attribute, emit an appropriate warning 618 / error 619 with
25436 the message from the attribute.
25438 2002-07-24 Martin Baulig <martin@gnome.org>
25440 * cs-tokenizer.cs: Eat up trailing whitespaces and one-line comments in
25441 preprocessor directives, ensure that the argument to #define/#undef is
25442 exactly one identifier and that it's actually an identifier.
25444 Some weeks ago I did a `#define DEBUG 1' myself and wondered why this
25447 2002-07-24 Martin Baulig <martin@gnome.org>
25449 * statement.cs (Foreach.ForeachHelperMethods): Added `Type element_type',
25450 initialize it to TypeManager.object_type in the constructor.
25451 (Foreach.GetEnumeratorFilter): Set `hm.element_type' to the return type
25452 of the `hm.get_current' method if we're using the collection pattern.
25453 (Foreach.EmitCollectionForeach): Use `hm.element_type' as the source type
25454 for the explicit conversion to make it work when we're using the collection
25455 pattern and the `Current' property has a different return type than `object'.
25458 2002-07-24 Martin Baulig <martin@gnome.org>
25460 * delegate.cs (Delegate.VerifyMethod): Simply return null if the method
25461 does not match, but don't report any errors. This method is called in
25462 order for all methods in a MethodGroupExpr until a matching method is
25463 found, so we don't want to bail out if the first method doesn't match.
25464 (NewDelegate.DoResolve): If none of the methods in the MethodGroupExpr
25465 matches, report the 123. Fixes #28070.
25467 2002-07-24 Martin Baulig <martin@gnome.org>
25469 * expression.cs (ArrayAccess.EmitStoreOpcode): Moved the
25470 TypeManager.TypeToCoreType() to the top of the method so the
25471 following equality checks will work. Fixes #28107.
25473 2002-07-24 Martin Baulig <martin@gnome.org>
25475 * cfold.cs (ConstantFold.DoConstantNumericPromotions): "If either
25476 operand is of type uint, and the other operand is of type sbyte,
25477 short or int, the operands are converted to type long." -
25478 Actually do what this comment already told us. Fixes bug #28106,
25481 2002-07-24 Martin Baulig <martin@gnome.org>
25483 * class.cs (MethodBase): New abstract class. This is now a base
25484 class for Property, Indexer and Event to avoid some code duplication
25485 in their Define() and DefineMethods() methods.
25486 (MethodBase.DoDefine, MethodBase.DefineAccessor): Provide virtual
25487 generic methods for Define() and DefineMethods().
25488 (FieldBase): Derive from MemberBase, not MemberCore.
25489 (Property): Derive from MemberBase, not MemberCore.
25490 (Property.DefineMethod): Moved all the code from this method to the
25491 new MethodBase.DefineAccessor(), just call it with appropriate
25493 (Property.Define): Call the new Property.DoDefine(), this does some
25494 sanity checks and we don't need to duplicate the code everywhere.
25495 (Event): Derive from MemberBase, not MemberCore.
25496 (Event.Define): Use the new MethodBase.DefineAccessor() to define the
25497 accessors, this will also make them work with interface events.
25498 (Indexer): Derive from MemberBase, not MemberCore.
25499 (Indexer.DefineMethod): Removed, call MethodBase.DefineAccessor() insstead.
25500 (Indexer.Define): Use the new MethodBase functions.
25502 * interface.cs (InterfaceEvent.InterfaceEvent): Added `Location loc'
25503 argument to the constructor.
25504 (Interface.FindMembers): Added support for interface events.
25505 (Interface.PopluateEvent): Implemented.
25507 Added test-149.cs for this. This also fixes bugs #26067 and #24256.
25509 2002-07-22 Miguel de Icaza <miguel@ximian.com>
25511 * class.cs (TypeContainer.AddMethod): Adding methods do not use IsValid,
25512 but this is required to check for a method name being the same as
25513 the containing class.
25517 2002-07-22 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25519 * interface.cs: initialize variable.
25521 2002-07-23 Martin Baulig <martin@gnome.org>
25523 Implemented the IndexerName attribute in interfaces.
25525 * class.cs (TypeContainer.DefineIndexers): Don't set the indexer
25526 name if this is an explicit interface implementation.
25527 (Indexer.InterfaceIndexerName): New public variable. If we're
25528 implementing an interface indexer, this is the IndexerName in that
25529 interface. Otherwise, it's the IndexerName.
25530 (Indexer.DefineMethod): If we're implementing interface indexer,
25531 set InterfaceIndexerName. Use the new Pending.IsInterfaceIndexer
25532 and Pending.ImplementIndexer methods.
25533 (Indexer.Define): Also define the PropertyBuilder if we're
25534 implementing an interface indexer and this is neither an explicit
25535 interface implementation nor do the IndexerName match the one in
25538 * pending.cs (TypeAndMethods): Added `MethodInfo [] need_proxy'.
25539 If a method is defined here, then we always need to create a proxy
25540 for it. This is used when implementing interface indexers.
25541 (Pending.IsInterfaceIndexer): New public method.
25542 (Pending.ImplementIndexer): New public method.
25543 (Pending.InterfaceMethod): Added `MethodInfo need_proxy' argument.
25544 This is used when implementing interface indexers to define a proxy
25546 (Pending.VerifyPendingMethods): Look in the `need_proxy' array and
25547 define a proxy if necessary.
25549 * interface.cs (Interface.IndexerName): New public variable.
25550 (Interface.PopulateIndexer): Set the IndexerName.
25551 (Interface.DefineIndexers): New private method. Populate all the
25552 indexers and make sure their IndexerNames match.
25554 * typemanager.cs (IndexerPropertyName): Added support for interface
25557 2002-07-22 Martin Baulig <martin@gnome.org>
25559 * codegen.cs (EmitContext.HasReturnLabel): New public variable.
25560 (EmitContext.EmitTopBlock): Always mark the ReturnLabel and emit a
25561 ret if HasReturnLabel.
25562 (EmitContext.TryCatchLevel, LoopBeginTryCatchLevel): New public
25565 * statement.cs (Do.Emit, While.Emit, For.Emit, Foreach.Emit): Save
25566 and set the ec.LoopBeginTryCatchLevel.
25567 (Try.Emit): Increment the ec.TryCatchLevel while emitting the block.
25568 (Continue.Emit): If the ec.LoopBeginTryCatchLevel is smaller than
25569 the current ec.TryCatchLevel, the branch goes out of an exception
25570 block. In this case, we need to use Leave and not Br.
25572 2002-07-22 Martin Baulig <martin@gnome.org>
25574 * statement.cs (Try.Emit): Emit an explicit ret after the end of the
25575 block unless the block does not always return or it is contained in
25576 another try { ... } catch { ... } block. Fixes bug #26506.
25577 Added verify-1.cs to the test suite.
25579 2002-07-22 Martin Baulig <martin@gnome.org>
25581 * statement.cs (Switch.TableSwitchEmit): If we don't have a default,
25582 then we do not always return. Fixes bug #24985.
25584 2002-07-22 Martin Baulig <martin@gnome.org>
25586 * expression.cs (Invocation.OverloadedResolve): Do the BetterFunction()
25587 lookup on a per-class level; ie. walk up the class hierarchy until we
25588 found at least one applicable method, then choose the best among them.
25589 Fixes bug #24463 and test-29.cs.
25591 2002-07-22 Martin Baulig <martin@gnome.org>
25593 * typemanager.cs (TypeManager.ArrayContainsMethod): Don't check the
25594 return types of the methods. The return type is not part of the
25595 signature and we must not check it to make the `new' modifier work.
25596 Fixes bug #27999, also added test-147.cs.
25597 (TypeManager.TypeToCoreType): Added TypeManager.type_type.
25599 * expression.cs (Invocation.DoResolve): Call TypeManager.TypeToCoreType()
25600 on the method's return type.
25602 2002-07-21 Martin Baulig <martin@gnome.org>
25604 * assign.cs: Make this work if the rightmost source is a constant and
25605 we need to do an implicit type conversion. Also adding a few more tests
25606 to test-38.cs which should have caught this.
25608 * makefile.gnu: Disable debugging, there's already the mcs-mono2.exe
25609 target in the makefile for this. The makefile.gnu is primarily intended
25610 for end-users who don't want to debug the compiler.
25612 2002-07-21 Martin Baulig <martin@gnome.org>
25614 * assign.cs: Improved the Assign class so it can now handle embedded
25615 assignments (X = Y = Z = something). As a side-effect this'll now also
25616 consume less local variables. test-38.cs now passes with MCS, added
25617 a few new test cases to that test.
25619 2002-07-20 Martin Baulig <martin@gnome.org>
25621 * expression.cs (Binary.EmitBranchable): Emit correct unsigned branch
25622 instructions. Fixes bug #27977, also added test-146.cs.
25624 2002-07-19 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25626 * cs-tokenizer.cs: fixed getHex ().
25628 2002-07-19 Martin Baulig <martin@gnome.org>
25630 * expression.cs (Invocation.EmitParams): Use TypeManager.LookupType(),
25631 not Type.GetType() to lookup the array type. This is needed when
25632 we're constructing an array of a user-defined type.
25633 (ArrayAccess.EmitDynamicInitializers): Only emit the Ldelema for
25634 single-dimensional arrays, but also for single-dimensial arrays of
25637 2002-07-19 Martin Baulig <martin@gnome.org>
25639 * expression.cs (New.DoEmit): Create a new LocalTemporary each time
25640 this function is called, it's not allowed to share LocalBuilders
25641 among ILGenerators.
25643 2002-07-19 Martin Baulig <martin@gnome.org>
25645 * expression.cs (Argument.Resolve): Report an error 118 when trying
25646 to pass a type as argument.
25648 2002-07-18 Martin Baulig <martin@gnome.org>
25650 * ecore.cs (Expression.ImplicitNumericConversion): Don't emit a
25651 Conv_R_Un for the signed `long' type.
25653 2002-07-15 Miguel de Icaza <miguel@ximian.com>
25655 * expression.cs (MemberAccess.DoResolve): Do not reuse the field
25656 `expr' for the temporary result, as that will fail if we do
25657 multiple resolves on the same expression.
25659 2002-07-05 Miguel de Icaza <miguel@ximian.com>
25661 * ecore.cs (SimpleNameResolve): Use ec.DeclSpace instead of
25662 ec.TypeContainer for looking up aliases.
25664 * class.cs (TypeContainer): Remove LookupAlias from here.
25666 * decl.cs (DeclSpace); Move here.
25668 2002-07-01 Miguel de Icaza <miguel@ximian.com>
25670 * class.cs (FindMembers): Only call filter if the constructor
25671 bulider is not null.
25673 Also handle delegates in `NestedTypes' now. Now we will perform
25674 type lookups using the standard resolution process. This also
25677 * decl.cs (DeclSpace.ResolveType): New type resolution routine.
25678 This uses Expressions (the limited kind that can be parsed by the
25679 tree) instead of strings.
25681 * expression.cs (ComposedCast.ToString): Implement, used to flag
25682 errors since now we have to render expressions.
25684 (ArrayCreation): Kill FormElementType. Use ComposedCasts in
25687 * ecore.cs (SimpleName.ToString): ditto.
25689 * cs-parser.jay: Instead of using strings to assemble types, use
25690 Expressions to assemble the type (using SimpleName, ComposedCast,
25691 MemberAccess). This should fix the type lookups in declarations,
25692 because we were using a different code path for this.
25694 * statement.cs (Block.Resolve): Continue processing statements
25695 even when there is an error.
25697 2002-07-17 Miguel de Icaza <miguel@ximian.com>
25699 * class.cs (Event.Define): Also remove the `remove' method from
25700 the list of pending items.
25702 * expression.cs (ParameterReference): Use ldarg.N (0..3) to
25703 generate more compact code.
25705 2002-07-17 Martin Baulig <martin@gnome.org>
25707 * const.cs (Const.LookupConstantValue): Add support for constant
25708 `unchecked' and `checked' expressions.
25709 Also adding test case test-140.cs for this.
25711 2002-07-17 Martin Baulig <martin@gnome.org>
25713 * statement.cs (Foreach.GetEnumeratorFilter): When compiling corlib,
25714 check whether mi.ReturnType implements the IEnumerator interface; the
25715 `==' and the IsAssignableFrom() will fail in this situation.
25717 2002-07-16 Ravi Pratap <ravi@ximian.com>
25719 * ecore.cs (SimpleName.SimpleNameResolve) : Apply Gonzalo's fix
25722 2002-07-16 Gonzalo Paniagua Javier <gonzalo@ximian.com>
25724 * expression.cs: fixed bug #27811.
25726 2002-07-14 Miguel de Icaza <miguel@ximian.com>
25728 * expression.cs (ParameterReference.AddressOf): Patch from Paolo
25729 Molaro: when we are a ref, the value already contains a pointer
25730 value, do not take the address of it.
25732 2002-07-14 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
25733 * removed mb-parser.jay and mb-tokenizer.cs
25735 Sat Jul 13 19:38:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25737 * expression.cs: check against the building corlib void type.
25739 Sat Jul 13 19:35:58 CEST 2002 Paolo Molaro <lupus@ximian.com>
25741 * ecore.cs: fix for valuetype static readonly fields: when
25742 initializing them, we need their address, not the address of a copy.
25744 Sat Jul 13 17:32:53 CEST 2002 Paolo Molaro <lupus@ximian.com>
25746 * typemanager.cs: register also enum_type in corlib.
25748 Sat Jul 13 15:59:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25750 * class.cs: allow calling this (but not base) initializers in structs.
25752 Sat Jul 13 15:12:06 CEST 2002 Paolo Molaro <lupus@ximian.com>
25754 * ecore.cs: make sure we compare against the building base types
25757 Sat Jul 13 15:10:32 CEST 2002 Paolo Molaro <lupus@ximian.com>
25759 * typemanager.cs: fix TypeToCoreType() to handle void and object
25760 (corlib gets no more typerefs after this change).
25762 2002-07-12 Miguel de Icaza <miguel@ximian.com>
25764 * expression.cs (ArrayCreation.EmitArrayArguments): use
25765 Conv.Ovf.U4 for unsigned and Conv.Ovf.I4 for signed.
25767 (ArrayAccess.LoadArrayAndArguments): Use Conv_Ovf_I and
25768 Conv_Ovf_I_Un for the array arguments. Even if C# allows longs as
25769 array indexes, the runtime actually forbids them.
25771 * ecore.cs (ExpressionToArrayArgument): Move the conversion code
25772 for array arguments here.
25774 * expression.cs (EmitLoadOpcode): System.Char is a U2, use that
25775 instead of the default for ValueTypes.
25777 (New.DoEmit): Use IsValueType instead of
25778 IsSubclassOf (value_type)
25779 (New.DoResolve): ditto.
25780 (Invocation.EmitCall): ditto.
25782 * assign.cs (Assign): ditto.
25784 * statement.cs (Unsafe): Ok, so I got the semantics wrong.
25785 Statements *are* currently doing part of their resolution during
25788 Expressions do always resolve during resolve, but statements are
25789 only required to propagate resolution to their children.
25791 2002-07-11 Miguel de Icaza <miguel@ximian.com>
25793 * driver.cs (CSCParseOption): Finish the /r: and /lib: support.
25795 (LoadAssembly): Do not add the dll if it is already specified
25797 (MainDriver): Add the System directory to the link path at the end,
25798 after all the other -L arguments.
25800 * expression.cs (ArrayAccess.EmitLoadOpcode): I was using the
25801 wrong opcode for loading bytes and bools (ldelem.i1 instead of
25802 ldelem.u1) and using the opposite for sbytes.
25804 This fixes Digger, and we can finally run it.
25806 * driver.cs (UnixParseOption): Move the option parsing here.
25807 (CSCParseOption): Implement CSC-like parsing of options.
25809 We now support both modes of operation, the old Unix way, and the
25810 new CSC-like way. This should help those who wanted to make cross
25811 platform makefiles.
25813 The only thing broken is that /r:, /reference: and /lib: are not
25814 implemented, because I want to make those have the same semantics
25815 as the CSC compiler has, and kill once and for all the confussion
25816 around this. Will be doing this tomorrow.
25818 * statement.cs (Unsafe.Resolve): The state is checked during
25819 resolve, not emit, so we have to set the flags for IsUnsfe here.
25821 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25823 * expression.cs (MemberAccess.ResolveMemberAccess): Since we can
25824 not catch the Error_ObjectRefRequired in SimpleName (as it is
25825 possible to have a class/instance variable name that later gets
25826 deambiguated), we have to check this here.
25828 2002-07-10 Ravi Pratap <ravi@ximian.com>
25830 * class.cs (TypeContainer.GetFieldFromEvent): Move away from here,
25831 make static and put into Expression.
25833 (Event.Define): Register the private field of the event with the
25834 TypeManager so that GetFieldFromEvent can get at it.
25836 (TypeManager.RegisterPrivateFieldOfEvent): Implement to
25837 keep track of the private field associated with an event which
25840 (TypeManager.GetPrivateFieldOfEvent): Implement to get at the
25843 * ecore.cs (GetFieldFromEvent): RE-write to use the above methods.
25845 2002-07-10 Miguel de Icaza <miguel@ximian.com>
25847 * expression.cs (Binary.EmitBranchable): this routine emits the
25848 Binary expression in a branchable context. This basically means:
25849 we need to branch somewhere, not just get the value on the stack.
25851 This works together with Statement.EmitBoolExpression.
25853 * statement.cs (Statement.EmitBoolExpression): Use
25856 2002-07-09 Miguel de Icaza <miguel@ximian.com>
25858 * statement.cs (For): Reduce the number of jumps in loops.
25860 (For): Implement loop inversion for the For statement.
25862 (Break): We can be breaking out of a Try/Catch controlled section
25863 (foreach might have an implicit try/catch clause), so we need to
25864 use Leave instead of Br.
25866 * ecore.cs (FieldExpr.AddressOf): Fix for test-139 (augmented
25867 now). If the instace expression supports IMemoryLocation, we use
25868 the AddressOf method from the IMemoryLocation to extract the
25869 address instead of emitting the instance.
25871 This showed up with `This', as we were emitting the instance
25872 always (Emit) instead of the Address of This. Particularly
25873 interesting when This is a value type, as we dont want the Emit
25874 effect (which was to load the object).
25876 2002-07-08 Miguel de Icaza <miguel@ximian.com>
25878 * attribute.cs: Pass the entry point to the DefinePInvokeMethod
25880 * statement.cs (Checked): Set the CheckedState during the resolve
25881 process too, as the ConvCast operations track the checked state on
25882 the resolve process, and not emit.
25884 * cs-parser.jay (namespace_member_declaration): Flag that we have
25885 found a declaration when we do. This is used to flag error 1529
25887 * driver.cs: Report ok when we display the help only.
25889 2002-07-06 Andrew Birkett <adb@tardis.ed.ac.uk>
25891 * cs-tokenizer.cs (xtoken): Improve handling of string literals.
25893 2002-07-04 Miguel de Icaza <miguel@ximian.com>
25895 * cs-tokenizer.cs (define): We also have to track locally the
25896 defines. AllDefines is just used for the Conditional Attribute,
25897 but we also need the local defines for the current source code.
25899 2002-07-03 Miguel de Icaza <miguel@ximian.com>
25901 * statement.cs (While, For, Do): These loops can exit through a
25902 Break statement, use this information to tell whether the
25903 statement is the last piece of code.
25905 (Break): Flag that we break.
25907 * codegen.cs (EmitContexts): New `Breaks' state variable.
25909 2002-07-03 Martin Baulig <martin@gnome.org>
25911 * class.cs (TypeContainer.MethodModifiersValid): Allow override
25912 modifiers in method declarations in structs. Otherwise, you won't
25913 be able to override things like Object.Equals().
25915 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25917 * class.cs (Method, Property, Indexer): Do not allow the public
25918 modifier to be used in explicit interface implementations.
25920 (TypeContainer.MethodModifiersValid): Catch virtual, abstract and
25921 override modifiers in method declarations in structs
25923 2002-07-02 Andrew Birkett <adb@tardis.ed.ac.uk>
25925 * cs-tokenizer.cs (adjust_int, adjust_real): Do not abort on
25926 integer or real overflow, report an error
25928 2002-07-02 Martin Baulig <martin@gnome.org>
25930 * typemanager.cs (TypeManager.InitCoreTypes): When compiling
25931 corlib, dynamically call AssemblyBuilder.SetCorlibTypeBuilders()
25932 to tell the runtime about our newly created System.Object and
25933 System.ValueType types.
25935 2002-07-02 Miguel de Icaza <miguel@ximian.com>
25937 * expression.cs (This): Use Stobj/Ldobj when we are a member of a
25938 struct instead of Ldarg/Starg.
25940 2002-07-02 Martin Baulig <martin@gnome.org>
25942 * expression.cs (Indirection.Indirection): Call
25943 TypeManager.TypeToCoreType() on `expr.Type.GetElementType ()'.
25945 2002-07-02 Martin Baulig <martin@gnome.org>
25947 * expression.cs (ArrayAccess.EmitStoreOpcode): If the type is a
25948 ValueType, call TypeManager.TypeToCoreType() on it.
25949 (Invocations.EmitParams): Call TypeManager.TypeToCoreType() on
25950 the OpCodes.Newarr argument.
25952 2002-07-02 Martin Baulig <martin@gnome.org>
25954 * expression.cs (Invocation.EmitCall): When compiling corlib,
25955 replace all calls to the system's System.Array type to calls to
25956 the newly created one.
25958 * typemanager.cs (TypeManager.InitCodeHelpers): Added a few more
25959 System.Array methods.
25960 (TypeManager.InitCoreTypes): When compiling corlib, get the methods
25961 from the system's System.Array type which must be replaced.
25963 Tue Jul 2 19:05:05 CEST 2002 Paolo Molaro <lupus@ximian.com>
25965 * typemanager.cs: load unverifiable_code_ctor so we can build
25966 corlib using the correct type. Avoid using GetTypeCode() with
25968 * rootcontext.cs: uses TypeManager.unverifiable_code_ctor and
25969 TypeManager.object_type to allow building corlib.
25971 Tue Jul 2 19:03:19 CEST 2002 Paolo Molaro <lupus@ximian.com>
25973 * ecore.cs: handle System.Enum separately in LoadFromPtr().
25975 2002-07-01 Martin Baulig <martin@gnome.org>
25977 * class.cs: Make the last change actually work, we need to check
25978 whether `ifaces != null' to avoid a crash.
25980 Mon Jul 1 16:15:03 CEST 2002 Paolo Molaro <lupus@ximian.com>
25982 * class.cs: when we build structs without fields that implement
25983 interfaces, we need to add the interfaces separately, since there is
25984 no API to both set the size and add the interfaces at type creation
25987 Mon Jul 1 14:50:47 CEST 2002 Paolo Molaro <lupus@ximian.com>
25989 * expression.cs: the dimension arguments to the array constructors
25990 need to be converted if they are a long.
25992 Mon Jul 1 12:26:12 CEST 2002 Paolo Molaro <lupus@ximian.com>
25994 * class.cs: don't emit ldarg.0 if there is no parent constructor
25995 (fixes showstopper for corlib).
25997 2002-06-29 Martin Baulig <martin@gnome.org>
25999 MCS now compiles corlib on GNU/Linux :-)
26001 * attribute.cs (Attribute.ApplyAttributes): Treat Accessors like Method,
26002 ie. check for MethodImplOptions.InternalCall.
26004 * class.cs (TypeContainer.DefineType): When compiling corlib, both parent
26005 and TypeManager.attribute_type are null, so we must explicitly check
26006 whether parent is not null to find out whether it's an attribute type.
26007 (Property.Emit): Always call Attribute.ApplyAttributes() on the GetBuilder
26008 and SetBuilder, not only if the property is neither abstract nor external.
26009 This is necessary to set the MethodImplOptions on the accessor methods.
26010 (Indexer.Emit): Call Attribute.ApplyAttributes() on the GetBuilder and
26011 SetBuilder, see Property.Emit().
26013 * rootcontext.cs (RootContext.PopulateTypes): When compiling corlib, don't
26014 populate "System.Object", "System.ValueType" and "System.Attribute" since
26015 they've already been populated from BootCorlib_PopulateCoreTypes().
26017 2002-06-29 Martin Baulig <martin@gnome.org>
26019 * ecore.cs (Expression.ImplicitReferenceConversionExists): If expr
26020 is the NullLiteral, we also need to make sure that target_type is not
26023 2002-06-29 Martin Baulig <martin@gnome.org>
26025 * rootcontext.cs (RootContext.ResolveCore): We must initialize
26026 `TypeManager.multicast_delegate_type' and `TypeManager.delegate_type'
26027 before calling BootstrapCorlib_ResolveDelegate ().
26029 2002-06-27 Gonzalo Paniagua Javier <gonzalo@ximian.com>
26031 * statement.cs: fixed build-breaker. All tests passed ok.
26033 2002-06-27 Martin Baulig <martin@gnome.org>
26035 * typemanager.cs (TypeManager.VerifyUnManaged): Added explicit check
26036 for System.Decimal when compiling corlib.
26038 2002-06-27 Martin Baulig <martin@gnome.org>
26040 * statement.cs (Switch.TableSwitchEmit): Make this work with empty
26041 switch blocks which contain nothing but a default clause.
26043 2002-06-26 Andrew <adb@tardis.ed.ac.uk>
26045 * ../errors/cs1501-3.cs: Added new test for struct ctr typechecks.
26047 2002-06-27 Martin Baulig <martin@gnome.org>
26049 * ecore.cs (PropertyExpr.PropertyExpr): Call
26050 TypeManager.TypeToCoreType() on the `pi.PropertyType'.
26052 * typemanager.cs (TypeManager.TypeToCoreType): Return if the type
26053 is already a TypeBuilder.
26055 2002-06-27 Martin Baulig <martin@gnome.org>
26057 * ecore.cs (Expression.ImplicitReferenceConversionExists): Use
26058 `target_type == TypeManager.array_type', not IsAssignableFrom() in
26059 the "from an array-type to System.Array" case. This makes it work
26060 when compiling corlib.
26062 2002-06-27 Martin Baulig <martin@gnome.org>
26064 * ecore.cs (Expression.SimpleNameResolve): If the expression is a
26065 non-static PropertyExpr, set its InstanceExpression. This makes
26066 the `ICollection.Count' property work in System/Array.cs.
26068 2002-06-25 Andrew Birkett <adb@tardis.ed.ac.uk>
26070 * driver.cs: Made error handling more consistent. Errors now
26071 tracked by Report class, so many methods which used to return int
26072 now return void. Main() now prints success/failure and
26073 errors/warnings message.
26075 Renamed '--probe' compiler argument to '--expect-error'. Removed
26076 the magic number return values (123 and 124). Now, if the
26077 expected error occurs, the compiler exits with success (exit value
26078 0). If the compilation completes without seeing that particular
26079 error, the compiler exits with failure (exit value 1). The
26080 makefile in mcs/errors has been changed to handle the new behaviour.
26082 * report.cs: Made 'expected error' number a property and renamed
26083 it from 'Probe' to 'ExpectedError'.
26085 * genericparser.cs: Removed error handling support, since it is
26086 now all done by Report class.
26088 * cs-parser.jay, mb-parser.jay: Errors are tracked by Report
26089 class, so parse() no longer returns an int.
26091 * namespace.cs: Use Report.Error instead of GenericParser.error
26093 2002-06-22 Miguel de Icaza <miguel@ximian.com>
26095 * class.cs (TypeContainer.AddMethod, TypeContainer.AddIndexer,
26096 TypeContainer.AddOperator): At the front of the list put the
26097 explicit implementations, so they get resolved/defined first.
26099 2002-06-21 Miguel de Icaza <miguel@ximian.com>
26101 * class.cs (TypeContainer.VerifyImplements): Verifies that a given
26102 interface type is implemented by this TypeContainer. Used during
26103 explicit interface implementation.
26105 (Property.Define, Indexer.Define, Method.Define): Validate that
26106 the given interface in the explicit implementation is one of the
26107 base classes for the containing type.
26109 Also if we are explicitly implementing an interface, but there is
26110 no match in the pending implementation table, report an error.
26112 (Property.Define): Only define the property if we are
26113 not explicitly implementing a property from an interface. Use the
26114 correct name also for those properties (the same CSC uses,
26115 although that is really not needed).
26117 (Property.Emit): Do not emit attributes for explicitly implemented
26118 properties, as there is no TypeBuilder.
26120 (Indexer.Emit): ditto.
26122 Hiding then means that we do not really *implement* a pending
26123 implementation, which makes code fail.
26125 2002-06-22 Martin Baulig <martin@gnome.org>
26127 * ecore.cs (Expression.Constantify): Call TypeManager.TypeToCoreType() on
26128 the return value of Object.GetType(). [FIXME: we need to do this whenever
26129 we get a type back from the reflection library].
26131 Fri Jun 21 13:37:57 CEST 2002 Paolo Molaro <lupus@ximian.com>
26133 * typemanager.cs: make ExpandInterfaces() slip duplicated interfaces.
26135 2002-06-20 Miguel de Icaza <miguel@ximian.com>
26137 * attribute.cs: Return null if we can not look up the type.
26139 * class.cs (TypeContainer.GetClassBases): Use ExpandInterfaces on
26140 the interface types found.
26142 * interface.cs (Interface.GetInterfaceBases): Use ExpandInterfaces on the
26143 interface types found.
26145 * typemanager.cs (GetInterfaces): Make this routine returns alll
26146 the interfaces and work around the lame differences between
26147 System.Type and System.Reflection.Emit.TypeBuilder in the results
26148 result for GetInterfaces.
26150 (ExpandInterfaces): Given an array of interface types, expand and
26151 eliminate repeated ocurrences of an interface. This expands in
26152 context like: IA; IB : IA; IC : IA, IB; the interface "IC" to
26155 2002-06-21 Martin Baulig <martin@gnome.org>
26157 * typemanager.cs (TypeManager.EnumToUnderlying): It's now safe to call this function
26160 2002-06-21 Martin Baulig <martin@gnome.org>
26162 * typemanager.cs (TypeManager.TypeToCoreType): New function. When compiling corlib
26163 and called with one of the core types, return the corresponding typebuilder for
26166 * expression.cs (ArrayAccess.DoResolve): Call TypeManager.TypeToCoreType() on the
26169 2002-06-21 Martin Baulig <martin@gnome.org>
26171 * ecore.cs (Expression.ExplicitReferenceConversionExists): Use
26172 `target_type.IsArray' instead of `target_type.IsSubclassOf (TypeManager.array_type)'.
26173 (Expression.ConvertReferenceExplicit): Likewise.
26175 * expression.cs (ElementAccess.DoResolve): Likewise.
26176 (ElementAccess.DoResolveLValue): Likewise.
26178 2002-06-10 Martin Baulig <martin@gnome.org>
26180 * interface.cs (Interface.PopulateIndexer): When creating the setter, we need to
26181 add the "value" parameter to the parameter list.
26183 * statement.cs (Fixed.Emit): Pass the return value of the child block's Emit()
26186 2002-06-19 Miguel de Icaza <miguel@ximian.com>
26188 * expression.cs (ArrayCreation.ExpressionToArrayArgument): Convert
26189 the argument to an int, uint, long or ulong, per the spec. Also
26190 catch negative constants in array creation.
26192 Thu Jun 20 17:56:48 CEST 2002 Paolo Molaro <lupus@ximian.com>
26194 * class.cs: do not allow the same interface to appear twice in
26195 the definition list.
26197 Wed Jun 19 22:33:37 CEST 2002 Paolo Molaro <lupus@ximian.com>
26199 * ecore.cs: don't use ldlen with System.Array.
26201 Wed Jun 19 20:57:40 CEST 2002 Paolo Molaro <lupus@ximian.com>
26203 * ecore.cs: stobj requires a type argument. Handle indirect stores on enums.
26205 Wed Jun 19 20:17:59 CEST 2002 Paolo Molaro <lupus@ximian.com>
26207 * modifiers.cs: produce correct field attributes for protected
26208 internal. Easy fix so miguel can work on ther harder stuff:-)
26210 2002-06-18 Miguel de Icaza <miguel@ximian.com>
26212 * pending.cs: New file. Move the code from class.cs here.
26213 Support clearning the pending flag for all methods (when not doing
26214 explicit interface implementation).
26216 Tue Jun 18 10:36:22 CEST 2002 Paolo Molaro <lupus@ximian.com>
26218 * rootcontext.cs: added a couple more types needed to bootstrap.
26220 2002-06-17 Miguel de Icaza <miguel@ximian.com>
26222 * typemanager.cs (GetConstructor): Use DeclaredOnly to look the
26223 constructor in the type, instead of any constructor in the type
26224 hierarchy. Thanks to Paolo for finding this bug (it showed up as
26225 a bug in the Mono runtime when applying the params attribute).
26227 2002-06-16 Rafael Teixeira <rafaelteixeirabr@hotmail.com>
26228 * changed namespace.cs to use "GenericParser.error(...)" instead of "CSharpParser.error(...)"
26230 2002-06-14 Rachel Hestilow <hestilow@ximian.com>
26232 * expression.cs (Unary.ResolveOperator): Use TypeManager
26233 to resolve the type.
26235 2002-06-13 Ravi Pratap <ravi@ximian.com>
26237 * cs-parser.jay (enum_member_declaration): Pass in the attributes
26240 * enum.cs (AddEnumMember): Add support to store the attributes associated
26241 with each member too.
26243 * attribute.cs (CheckAttribute, ApplyAttributes): Update to handle
26244 field builders too - this takes care of the enum member case.
26246 2002-06-10 Rachel Hestilow <hestilow@ximian.com>
26248 * typemanager.cs (TypeManager.VerifyUnManaged): Allow
26249 address-of operator on both value types and pointers.
26251 2002-06-10 Martin Baulig <martin@gnome.org>
26253 * interface.cs (Interface.PopulateIndexer): Add the indexer's
26254 PropertyBuilder to the `property_builders' list.
26256 * expression.cs (Indexers.GetIndexersForTypeOrInterface): New private method.
26257 (Indexers.GetIndexersForType): Call GetIndexersForTypeOrInterface() on the
26258 `lookup_type' and all its interfaces. Unfortunately, Type.FindMembers() won't
26259 find any indexers which are inherited from an interface.
26261 2002-06-09 Martin Baulig <martin@gnome.org>
26263 * const.cs (Const.LookupConstantValue): Convert `Expr' to a literal of
26264 the same type as the constant if necessary. There's also a test-130.cs
26267 * enum.cs (Enum.ChangeEnumType): Moved to typemanager.cs and made public.
26269 * typemanager.cs (TypeManager.ChangeType): Previously known as
26270 Enum.ChangeEnumType().
26272 2002-06-09 Martin Baulig <martin@gnome.org>
26274 * expression.cs (Cast.TryReduce): Added support for consts.
26276 2002-06-08 Ravi Pratap <ravi@ximian.com>
26278 * class.cs (Accessor): Hold attributes information so we can pass
26281 * cs-parser.jay (get_accessor_declaration, set_accessor_declaration):
26282 Modify to pass in attributes attached to the methods.
26284 (add_accessor_declaration, remove_accessor_declaration): Ditto.
26286 * attribute.cs (ApplyAttributes, CheckAttribute): Update accordingly
26287 to handle the Accessor kind :-)
26289 * class.cs (Property.Emit, Event.Emit): Apply attributes to the accessors
26291 2002-06-08 Martin Baulig <martin@gnome.org>
26293 * expression.cs (Unary.TryReduceNegative): Added support for
26296 2002-06-08 Martin Baulig <martin@gnome.org>
26298 * enum.cs (Enum.LookupEnumValue): Don't report an error if the
26299 name can't be found in the `defined_names' - the caller will do a
26300 MemberLookup in this case and thus find methods in System.Enum
26301 such as Enum.IsDefined().
26303 2002-06-08 Martin Baulig <martin@gnome.org>
26305 * enum.cs (Enum.ChangeEnumType): This is a custom version of
26306 Convert.ChangeType() which works with TypeBuilder created types.
26307 (Enum.LookupEnumValue, Enum.Define): Use it here.
26309 * class.cs (TypeContainer.RegisterRequiredImplementations): Added
26310 `TypeBuilder.BaseType != null' check.
26311 (TypeContainer.FindMembers): Only lookup parent members if we
26312 actually have a parent.
26313 (Method.EmitDestructor): Added `ec.ContainerType.BaseType != null' check.
26314 (ConstructorInitializer.Resolve): Likewise.
26316 * interface.cs (Interface.FindMembers): Added
26317 `TypeBuilder.BaseType != null' check.
26319 * rootcontext.cs (RootContext.ResolveCore): Added
26320 "System.Runtime.CompilerServices.IndexerNameAttribute" to
26321 classes_second_stage.
26323 * typemanager.cs (TypeManager.InitCoreTypes): Don't initialize
26324 debug_type and trace_type when compiling with --nostdlib.
26326 2002-06-07 Martin Baulig <martin@gnome.org>
26328 * class.cs (TypeContainer): Added `have_nonstatic_fields' field.
26329 (AddField): Set it to true when adding a non-static field.
26330 (DefineType): Use `have_nonstatic_fields' to find out whether we
26331 have non-static fields, not `Fields != null'.
26333 2002-06-02 Miguel de Icaza <miguel@ximian.com>
26335 * ecore.cs (SimpleNameResolve): Removed simple bug (we were
26336 dereferencing a null on the static-field code path)
26338 2002-05-30 Martin Baulig <martin@gnome.org>
26340 * codegen.cs (InitMonoSymbolWriter): Added `string[] args' argument
26341 to take command line arguments. Use reflection to call the new
26342 custom `Initialize' function on the symbol writer and pass it the
26343 command line arguments.
26345 * driver.cs (--debug-args): New command line argument to pass command
26346 line arguments to the symbol writer.
26348 2002-05-28 Miguel de Icaza <miguel@ximian.com>
26350 * assign.cs (DoResolve): Forgot to do the implicit conversion to
26351 the target type for indexers and properties. Thanks to Joe for
26354 2002-05-27 Miguel de Icaza <miguel@ximian.com>
26356 * typemanager.cs (MethodFlags): returns the method flags
26357 (Obsolete/ShouldIgnore) that control warning emission and whether
26358 the invocation should be made, or ignored.
26360 * expression.cs (Invocation.Emit): Remove previous hack, we should
26361 not do this on matching a base type, we should do this based on an attribute
26363 Only emit calls to System.Diagnostics.Debug and
26364 System.Diagnostics.Trace if the TRACE and DEBUG defines are passed
26365 on the command line.
26367 * rootcontext.cs: Global settings for tracing and debugging.
26369 * cs-tokenizer.cs (define): New utility function to track
26370 defines. Set the global settings for TRACE and DEBUG if found.
26372 2002-05-25 Ravi Pratap <ravi@ximian.com>
26374 * interface.cs (Populate*): Pass in the TypeContainer as well as
26375 the DeclSpace as parameters so that we can create EmitContexts and
26376 then use that to apply attributes etc.
26378 (PopulateMethod, PopulateEvent, PopulateProperty)
26379 (PopulateIndexer): Apply attributes everywhere.
26381 * attribute.cs (CheckAttribute): Include InterfaceMethod, InterfaceEvent
26384 (ApplyAttributes): Update accordingly.
26386 We now apply interface attributes for all members too.
26388 2002-05-26 Miguel de Icaza <miguel@ximian.com>
26390 * class.cs (Indexer.Define); Correctly check if we are explicit
26391 implementation (instead of checking the Name for a ".", we
26392 directly look up if the InterfaceType was specified).
26394 Delay the creation of the PropertyBuilder.
26396 Only create the PropertyBuilder if we are not an explicit
26397 interface implementation. This means that explicit interface
26398 implementation members do not participate in regular function
26399 lookups, and hence fixes another major ambiguity problem in
26400 overload resolution (that was the visible effect).
26402 (DefineMethod): Return whether we are doing an interface
26405 * typemanager.cs: Temporary hack until we get attributes in
26406 interfaces (Ravi is working on that) and we get IndexerName
26407 support in interfaces.
26409 * interface.cs: Register the indexers as properties.
26411 * attribute.cs (Attribute.Resolve): Catch the error, and emit a
26412 warning, I have verified that this is a bug in the .NET runtime
26413 (JavaScript suffers of the same problem).
26415 * typemanager.cs (MemberLookup): When looking up members for
26416 interfaces, the parent of an interface is the implicit
26417 System.Object (so we succeed in searches of Object methods in an
26418 interface method invocation. Example: IEnumerable x; x.ToString
26421 2002-05-25 Miguel de Icaza <miguel@ximian.com>
26423 * class.cs (Event): Events should also register if they do
26424 implement the methods that an interface requires.
26426 * typemanager.cs (MemberLookup); use the new GetInterfaces
26429 (GetInterfaces): The code used to lookup interfaces for a type is
26430 used in more than one place, factor it here.
26432 * driver.cs: Track the errors at the bottom of the file, we kept
26435 * delegate.cs (NewDelegate.Emit): We have to emit a null as the
26436 instance if the method we are calling is static!
26438 2002-05-24 Miguel de Icaza <miguel@ximian.com>
26440 * attribute.cs (ApplyAttributes): Make this function filter out
26441 the IndexerName attribute (as that attribute in reality is never
26442 applied) and return the string constant for the IndexerName
26445 * class.cs (TypeContainer.Emit): Validate that all the indexers
26446 have the same IndexerName attribute, and if so, set the
26447 DefaultName attribute on the class.
26449 * typemanager.cs: The return value might contain other stuff (not
26450 only methods). For instance, consider a method with an "Item"
26451 property and an Item method.
26453 * class.cs: If there is a problem with the parameter types,
26456 2002-05-24 Ravi Pratap <ravi@ximian.com>
26458 * ecore.cs (ImplicitConversionExists): Wrapper function which also
26459 looks at user defined conversion after making a call to
26460 StandardConversionExists - we need this for overload resolution.
26462 * expression.cs : Update accordingly the various method calls.
26464 This fixes 2 bugs filed against implicit user defined conversions
26466 2002-05-22 Miguel de Icaza <miguel@ximian.com>
26468 * statement.cs: Track the result of the assignment.
26470 2002-05-21 Miguel de Icaza <miguel@ximian.com>
26472 * expression.cs (MemberAccess): Improved error reporting for
26473 inaccessible members.
26475 2002-05-22 Martin Baulig <martin@gnome.org>
26477 * makefile (mcs-mono2.exe): New target. This is mcs compiled with
26478 itself with debugging support.
26480 2002-05-22 Martin Baulig <martin@gnome.org>
26482 * typemanager.cs ("System.Runtime.InteropServices.StructLayoutAttribute"):
26483 Removed, this isn't needed anymore.
26485 2002-05-20 Martin Baulig <martin@gnome.org>
26487 * typemanager.cs (InitEnumUnderlyingTypes): "System.Char" can't
26488 be underlying type for an enum.
26490 2002-05-20 Miguel de Icaza <miguel@ximian.com>
26492 * typemanager.cs (InitEnumUnderlyingTypes): New helper function
26493 that splits out the loading of just the core types.
26495 * rootcontext.cs (ResolveCore): Split the struct resolution in
26496 two, so we can load the enumeration underlying types before any
26499 * expression.cs (Is): Bandaid until we fix properly Switch (see
26500 bug #24985 for details).
26502 * typemanager.cs (ImplementsInterface): The hashtable will contain
26503 a null if there are no interfaces implemented.
26505 2002-05-18 Miguel de Icaza <miguel@ximian.com>
26507 * cs-parser.jay (indexer_declarator): It is fine to have array
26510 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26512 * typemanager.cs: (RegisterBuilder): New function used to register
26513 TypeBuilders that implement interfaces. Since
26514 TypeBuilder.GetInterfaces (as usual) does not work with lame
26516 (AddUserType): register interfaces.
26518 (ImplementsInterface): Use the builder_to_ifaces hash if we are
26519 dealing with TypeBuilder. Also, arrays are showing up as
26520 SymbolTypes, which are not TypeBuilders, but whose GetInterfaces
26521 methods can not be invoked on them!
26523 * ecore.cs (ExplicitReferenceConversionExists): Made public.
26524 (ImplicitReferenceConversionExists): Split out from
26525 StandardConversionExists.
26527 * expression.cs (As): We were only implementing one of the three
26528 cases for the as operator. We now implement them all.
26529 (Is): Implement the various other cases for Is as well.
26531 * typemanager.cs (CACHE): New define used to control if we want or
26532 not the FindMembers cache. Seems to have a negative impact on
26533 performance currently
26535 (MemberLookup): Nested types have full acess to
26536 enclosing type members
26538 Remove code that coped with instance/static returns for events, we
26539 now catch this in RealFindMembers.
26541 (RealFindMembers): only perform static lookup if the instance
26542 lookup did not return a type or an event.
26544 2002-05-17 Miguel de Icaza <miguel@ximian.com>
26546 * assign.cs (CompoundAssign): We pass more semantic information
26547 now to Compound Assignments than we did before: now we have all
26548 the information at hand, and now we resolve the target *before* we
26549 do the expression expansion, which allows the "CacheValue" method
26550 to have the effect we intended (before, a [x] += 1 would generate
26551 two differen ArrayAccess expressions from the ElementAccess,
26552 during the resolution process).
26554 (CompoundAssign.DoResolve): Resolve target and original_source here.
26556 2002-05-16 Miguel de Icaza <miguel@ximian.com>
26558 * expression.cs (ArrayAccess): dropped debugging information.
26560 * typemanager.cs: Small bug fix: I was always returning i_members,
26561 instead of one of i_members or s_members (depending on which had
26564 * assign.cs (IAssignMethod.CacheTemporaries): New method. This
26565 method is invoked before any code generation takes place, and it
26566 is a mechanism to inform that the expression will be invoked more
26567 than once, and that the method should use temporary values to
26568 avoid having side effects
26570 (Assign.Emit): Call CacheTemporaries in the IAssignMethod.
26572 * ecore.cs (Expression.CacheTemporaries): Provide empty default
26575 * expression.cs (Indirection, ArrayAccess): Add support for
26576 CacheTemporaries in these two bad boys.
26578 * ecore.cs (LoadFromPtr): figure out on our own if we need to use
26579 ldobj or ldind_ref.
26580 (StoreFromPtr): Handle stobj as well.
26582 * expression.cs (UnaryMutator): Share more code.
26584 * typemanager.cs (FindMembers): Thanks to Paolo for tracking this
26585 down: I was not tracking the Filter function as well, which
26586 was affecting the results of the cache.
26588 2002-05-15 Miguel de Icaza <miguel@ximian.com>
26590 * attribute.cs: Remove the hack to handle the CharSet property on
26593 2002-05-14 Miguel de Icaza <miguel@ximian.com>
26595 * attribute.cs (DoResolve): More uglyness, we now only try to
26596 resolve the attribute partially, to extract the CharSet
26597 information (only if we are a StructLayout attribute). Otherwise
26599 (GetExtraTypeInfo): Add some code to conditionally kill in the
26600 future this. I am more and more convinced that the .NET
26601 framework has special code to handle the attribute setting on
26604 * expression.cs (IsParamsMethodApplicable): Revert my previous
26605 foreach change here, it was wrong.
26607 2002-05-13 Miguel de Icaza <miguel@ximian.com>
26609 * cs-tokenizer.cs: (pp_primary): Eat the ')' at the end.
26610 (pp_expr): do not abort on unknown input, just return.
26611 (eval): abort if there are pending chars.
26613 * attribute.cs (Attribute.Resolve): Positional parameters are
26614 optional. Deal with that case.
26616 * class.cs (DefineType): Call Attribute.GetExtraTypeInfo to fetch
26617 the Ansi/Unicode/Auto information for the type.
26619 (TypeContainer.DefineType): instantiate the EmitContext here, as
26620 we will be using it during the type definition (to resolve
26621 attributes) and during the emit phase.
26623 * attribute.cs (Attribute.GetExtraTypeInfo): This routine is used
26624 to pull type information out of the attributes
26626 (Attribute.Resolve): track the constructor builder, and allow for
26627 multiple invocations (structs and classes will use this).
26629 * ecore.cs (MemberLookupFinal): new version with all the
26630 parameters customizable.
26632 * expression.cs (New.DoResolve): Use MemberLookupFinal to locate
26633 constructors. Return if the result value is null (as the error
26634 would have been flagged already by MemberLookupFinal)
26636 Do not allow instances of abstract classes or interfaces to be
26639 * class.cs: (MethodSignature.InheritableMemberSignatureCompare):
26640 We have to compare the assembly property here when dealing with
26641 FamANDAssem and Assembly access modifiers, because we might be
26642 creating an assembly from *modules* (that means that we are not
26643 getting TypeBuilders for types defined in other modules that are
26644 part of this assembly).
26646 (Method.Emit): If the method is marked abstract and has a body,
26649 (TypeContainer.DefineMembers): If both the defined member and the
26650 parent name match are methods, then do not emit any warnings: let
26651 the Method.Define routine take care of flagging warnings. But if
26652 there is a mismatch (method overrides something else, or method is
26653 overriwritten by something, then emit warning).
26655 (MethodSignature.MemberSignatureCompare): If the sig.ret_type is
26656 set to null, this means `do not check for the return type on the
26659 (Method.Define): set the return type for the method signature to
26660 null, so that we get methods with the same name and parameters and
26661 different return types. This is used to flag warning 114 (you are
26662 hiding a method, and you probably want to use the new/override
26665 * typemanager.cs (MemberLookup): Implemented proper access
26666 control, closing a long standing set of bug reports. The problem
26667 was that the Framework only has two bits: Public and NonPublic,
26668 and NonPublic includes private and protected methods, but we need
26669 to enforce the FamANDAssem, FamOrAssem and Family.
26671 2002-05-11 Miguel de Icaza <miguel@ximian.com>
26673 * statement.cs (GotoCase): Return true: Ammounts to giving up
26674 knowledge on whether we return or not, and letting the other case
26675 be responsible for it.
26677 2002-05-10 Miguel de Icaza <miguel@ximian.com>
26679 * driver.cs: Do not load directories for each file processed, only
26680 do it if there is a pattern.
26682 * ecore.cs: Report readonly assigns here as well, as we might have
26683 been resolved only by MemberAccess.
26685 (SimpleName.SimpleNameResolve): Also be useful for LValue
26686 resolution. We need this to propagate assign to local readonly variables
26688 * typemanager.cs: Use a ptrhashtable for the criteria, because we
26689 do not want to reuse potential criteria memory.
26691 * class.cs (MyEventBuilder): Set reflected_type;
26693 * ecore.cs (Constantify): Added support for constifying bools.
26695 (RootContext.LookupType): Added a cache for values looked up in
26696 the declaration space.
26698 * typemanager.cs (FindMembers): Now is a front-end to
26699 RealFindMembers, and provides a two-level hashtable-based cache to
26702 15% performance improvement: from 22.5 to 19.2 seconds.
26704 * expression.cs (IsParamsMethodApplicable): use foreach.
26705 (Invocation.DoResolve): ditto.
26706 (New.DoResolve): ditto.
26707 (ArrayCreation.DoResolve): ditto.
26709 * ecore.cs (FindMostEncompassingType): use foreach.
26711 * delegate.cs (NewDelegate.DoResolve): Use foreach
26713 * ecore.cs (Expression.FindMostSpecificSource): Use foreach.
26714 (RemoveMethods): use foreach.
26716 * expression.cs (Invocation.MakeUnionSet): Optimization: Use two
26717 nested foreach statements instead of for, and also break out of
26718 the inner loop once a match is found.
26720 (Invocation.OverloadResolve): Use foreach, simplify the code.
26722 2002-05-08 Miguel de Icaza <miguel@ximian.com>
26724 * cfold.cs (BinaryFold): During an enumeration evaluation context,
26725 we actually unwrap the expression to allow for extra information
26728 * expression.cs: Use Shr_Un on unsigned operations.
26730 2002-05-08 Ravi Pratap <ravi@ximian.com>
26732 * ecore.cs (FindMostEncompass*): Fix trivial bug where the set of
26733 applicable operators was not being considered correctly. This closes
26734 the bug Miguel reported.
26736 Wed May 8 16:40:50 CEST 2002 Paolo Molaro <lupus@ximian.com>
26738 * attribute.cs: check that the type derives from System.Attribute
26739 and report the correct error in that case (moved the duplicate code to
26740 its own method, too).
26742 Wed May 8 11:50:31 CEST 2002 Paolo Molaro <lupus@ximian.com>
26744 * attribute.cs: lookup attribute type name as the spec says: first the
26745 bare attribute name and then name + "Attribute" (nant compiles with
26746 mcs after this fix).
26748 2002-05-07 Miguel de Icaza <miguel@ximian.com>
26750 * expression.cs (Unary.TryReduceNegative): Ah! Tricky! Tricky!
26751 Because of the way we parse things, we should try to see if a
26752 UIntConstant can fit in an integer.
26754 2002-05-07 Ravi Pratap <ravi@ximian.com>
26756 * ecore.cs (GetConversionOperators): Do not pick up op_True operators
26757 when we are in an explicit context.
26759 (ConvertReferenceExplicit): When converting from Iface type S to Class
26760 T make sure the rules are implemented as an OR.
26762 * parameter.cs (ParameterType): Make it a property for now although the
26763 purpose really isn't anything immediate.
26765 * expression.cs (Is*Applicable): Do better checking on the parameter type
26766 of a ref/out parameter. The ones from the system assemblies are already
26767 marked with the correct type so we don't need to do any correction.
26769 * ecore.cs (StandardConversionExists): Conversion from Interface types to
26770 the object type is standard too so include that.
26772 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26774 * ecore.cs (StandardConversionExists): Augment with missing code:
26775 deal with IntConstant, LongConstants and Enumerations.
26777 * assign.cs: Report the error, instead of failing silently
26779 * rootcontext.cs (AddGlobalAttributes): Track attributes on the
26780 typecontainer that they are declared, because the
26781 typecontainer/namespace will have the list of using clauses that
26782 need to be applied.
26784 Assembly Attributes were escaping the normal registration
26787 (EmitCode): Apply attributes within an EmitContext that represents
26788 the container they were declared on.
26790 * cs-parser.jay: Track bases for structs. How did I get this wrong?
26792 2002-05-06 Ravi Pratap <ravi@ximian.com>
26794 * ecore.cs (FindMostEncompassingType, FindMostEncompassedType):
26795 Revamp completely - make much cleaner as we now operate only
26798 (FindMostSpecificSource, FindMostSpecificTarget): New methods
26799 to implement the logic detailed in the spec more correctly.
26801 (UserDefinedConversion): Update accordingly.
26803 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26805 * statement.cs: Return flow analysis information up.
26807 * cs-tokenizer.cs (adjust_real): Share code between LITERAL_DOUBLE
26810 (token): Do not consume an extra character before calling
26813 2002-05-06 Piers Haken <piersh@friskit.com>
26815 * cs-parser.jay: add 'override' attribute to System.Object.Finalize
26817 2002-05-06 Miguel de Icaza <miguel@ximian.com>
26819 * class.cs (Constructor.Emit): Set the IsStatic flag in the
26820 EmitContext during the instance constructor initializer
26821 resolution, to stop access to instance variables.
26823 This is mandated by the spec, last paragraph of the `constructor
26824 initializers' section.
26826 2002-05-05 Miguel de Icaza <miguel@ximian.com>
26828 * cs-parser.jay, class.cs (Accessor): new class used to represent
26829 an accessor (get or set). In the past we used `null' to represent
26830 a missing accessor. But this is ambiguous because there was no
26831 way to tell in abstract indexers/properties if one of them was
26834 Now there is a way of addressing that.
26836 * expression.cs (Indexers.GetIndexersForType): Use TypeManager.MemberLookup
26837 instead of FindMembers.
26839 * class.cs (TypeContainer.EmitFieldInitializer): Do not typecast
26840 the result of Assign.Resolve as Assign, but rather as ExpressionStatement.
26842 * attribute.cs: Treat indexers and properties as the same in terms
26843 of applying attributes
26845 * ecore.cs (FindMostEncompassedType): Use statically initialized
26846 EmptyExpressions()s like we do elsewhere to avoid creating useless
26847 objects (and we take this out of the tight loop).
26849 (GetConversionOperators): Move the code to extract the actual
26850 operators to a separate routine to clean things up.
26852 2002-05-04 Miguel de Icaza <miguel@ximian.com>
26854 * ecore.cs (FieldExpr): Remove un-needed tests for null, since now
26855 events are always registered FieldBuilders.
26857 * class.cs (FieldBase): New class shared by Fields
26859 * delegate.cs: If we are a toplevel delegate, use our full name.
26860 If we are a nested delegate, then only use our tail name.
26862 2002-05-02 Ravi Pratap <ravi@ximian.com>
26864 * expression.cs (IsApplicable): Ensure that we add the "&" to
26865 ref/out types before comparing it with the type of the argument.
26867 (IsParamsMethodApplicable): Ditto.
26869 (Argument.Type): Use TypeManager.LookupType instead of Type.GetType -
26872 * delegate.cs : Handle the case when we have more than one applicable
26873 method. Flag an error only when we finish checking all.
26875 2002-05-02 Miguel de Icaza <miguel@ximian.com>
26877 * expression.cs: Add support for boolean static initializers.
26879 2002-05-01 Miguel de Icaza <miguel@ximian.com>
26881 * attribute.cs: Use proper cast for Events, since we use a MyEventBuilder.
26883 * parameter.cs (ComputeParameterTypes,
26884 ComputeAndDefineParameterTypes): Better error handling: now we
26885 clear the `types' cache if we fail during any of the type lookups.
26886 We also return the status code correctly to our caller
26888 * delegate.cs: If we fail to define a delegate, abort the extra
26891 * expression.cs (Binary.ResolveOperator): for
26892 operator==(object,object) and operator !=(object, object) we also
26893 have to verify that there is an implicit conversion from one to
26896 (ArrayAccess.DoResolve): Array Access can operate on
26899 2002-04-30 Miguel de Icaza <miguel@ximian.com>
26901 * assign.cs (CompoundAssign): A new class used as a "flag" that
26902 the assignment actually is happening as part of a compound
26903 assignment operator.
26905 During compound assignment, a few new rules exist to enable things
26912 x op= y can be evaluated as x = (T) (x op y) (ie, an explicit cast
26913 to the type of x) if y is implicitly convertible to the type of x,
26914 and the operator is a builtin operator and the return type of the
26915 operator is explicitly convertible to the type of x.
26917 * rootcontext.cs: Reset warning level to 2. 4 catches various
26918 "interesting" features in mcs, we must clean this up at some
26919 point, but currently am trying to kill other bugs ;-)
26921 * ecore.cs (SimpleName.SimpleNameResolve): Perform member lookups
26922 in container classes as well.
26924 * expression.cs (Binary.ResolveOperator): Handle string case
26925 before anything else (as operator overloading does emit an error
26926 before doing anything else).
26928 This code could go away when we move to a table driven model, but
26929 i could not come up with a good plan last night.
26931 2002-04-30 Lawrence Pit <loz@cable.a2000.nl>
26933 * typemanager.cs (CSharpName): reimplementation using regex.
26934 * class.cs: added null check for fields in Emit
26935 * rootcontext.cs: set warninglevel to 4
26937 2002-04-29 Miguel de Icaza <miguel@ximian.com>
26939 * typemanager.cs (CSharpName): reimplemented with Lupus
26942 2002-04-28 Miguel de Icaza <miguel@ximian.com>
26944 * statement.cs (If): correclty implement Resolve, because we were
26945 not catching sem errors in there. The same process is needed
26947 (Return, StatementExpression, For, While, Do, Throw, Lock): Implement Resolve
26950 (Statement.Warning_DeadCodeFound): Factorize code.
26951 (While): Report dead code here too.
26953 (Statement): Added Resolve virtual method to allow
26954 for resolution split from the emit code.
26956 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26958 * statement.cs (EmitBoolExpression): No longer try to resolve the
26960 (MakeBoolean): New utility function that resolve, implicitly
26961 converts to boolean and tags the expression.
26964 (If, Do): Implement dead code elimination.
26965 (While): Implement loop inversion
26967 (Do, While, For, If): Resolve the expression prior to calling our
26970 2002-04-22 Lawrence Pit <loz@cable.a2000.nl>
26973 - added method Report28 (warning: program has more than one entry point)
26974 - added method IsEntryPoint, implements paragraph 10.1 of the spec
26975 - modified method Method.Define, the part at the end of the method
26977 * rootcontext.cs: added static public Location EntryPointLocation;
26979 * ../errors/cs0028.cs : Add test case for the above warning.
26982 - modified method CSharpName to allow arrays of primitive type to
26983 be printed nicely (e.g. instead of System.Int32[][] it now prints
26985 - added method CSharpSignature: returns the signature of a method
26986 in string format to be used in reporting errors, warnings, etc.
26988 * support.cs: InternalParameters.ParameterDesc variable tmp initialized
26991 2002-04-26 Ravi Pratap <ravi@ximian.com>
26993 * delegate.cs (Define): Fix extremely silly bug where I was
26994 setting the type of the 'object' parameter of the BeginInvoke
26995 method to System.IAsyncResult instead of System.Object ;-)
26997 2002-04-26 Miguel de Icaza <miguel@ximian.com>
26999 * class.cs (ConstructorInitializer.Resolve): Also use DeclaredOnly
27002 (Constructor.Emit): return if we fail to initialize the
27003 constructor. Another door closed!
27005 * expression.cs (New.DoResolve): Improve error message (from -6 to
27006 1501). Use DeclaredOnly lookup to find the exact constructor.
27008 * typemanager.cs (MemberLookup): If DeclaredOnly is set, do not
27009 loop. This is useful.
27011 * cs-parser.jay: Adjust the default parameters so that destructors
27012 have the proper signature.
27014 2002-04-26 Martin Baulig <martin@gnome.org>
27016 * driver.cs (LoadAssembly): If `assembly' contains any characters
27017 which are only valid in path names and not in assembly names
27018 (currently slash, backslash and point), use Assembly.LoadFrom ()
27019 instead of Assembly.Load () on the `assembly' (before iteration
27020 over the link_paths).
27022 2002-04-26 Martin Baulig <martin@gnome.org>
27024 * cs-tokenizer.cs (is_hex): Correctly handle lowercase chars.
27026 2002-04-25 Miguel de Icaza <miguel@ximian.com>
27028 * class.cs (Property): use the new typemanager.MemberLookup
27030 (TypeContainer.MemberLookup): Implement using the
27031 TypeManager.MemberLookup now.
27033 * typemanager.cs: Make MemberLookup a function of the TypeManager,
27034 and return MemberInfos, so that these can be used without an
27035 EmitContext (what we had before).
27037 2002-04-24 Miguel de Icaza <miguel@ximian.com>
27039 * expression.cs: Fix the case where the argument to params if the
27040 type of the params. I omitted handling this before. Fixed
27042 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27044 * driver.cs: Call BootCorlib_PopulateCoreType
27046 * class.cs (Property.CheckBase): Check for properties only, not
27049 * interface.cs: Temporary hack: try/catch around the
27050 CustomAttributeBuilder, because I am getting an exception that I
27053 * rootcontext.cs (BootCorlib_PopulateCoreType): Populate some
27054 types whose definitions are required to be there (attributes are
27055 defined before standard types).
27057 Compute definitions as we boot the various types, as they are used
27058 immediately (value_type class will need object_type, but if we do
27059 not initialize object_type, we will pass a null, which will let
27060 the runtime pick the System.Object from the existing corlib, which
27061 is not what we want).
27063 2002-04-22 Patrik Torstensson <totte@labs2.com>
27065 * cs-tokenizer.cs: fixed a number of trim() issues.
27067 2002-04-22 Ravi Pratap <ravi@ximian.com>
27069 * expression.cs (Argument.Type): Ensure that we return the correct
27070 type when we have out or ref parameters [in which case we
27073 2002-04-22 Miguel de Icaza <miguel@ximian.com>
27075 * class.cs (Property, Indexer): Allow extern modifier in there.
27077 * typemanager.cs (InitBaseTypes): Initializes object_type and
27078 value_type, since those will be used early on during the bootstrap
27079 process to compile corlib.
27081 (InitCoreTypes): Move code from here to InitBaseTypes.
27083 2002-04-21 Miguel de Icaza <miguel@ximian.com>
27085 * ecore.cs (PropertyExpr): Optimize calls to Array::get_Length on
27086 single-dimension arrays as using the ldlen opcode.
27088 Daniel Lewis discovered this optimization.
27090 * typemanager.cs: Add signature for System.Array::get_Length
27092 2002-04-20 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27094 * statement.cs: report the error when the foreach does not apply to an
27095 array nor a collection.
27097 2002-04-19 Miguel de Icaza <miguel@ximian.com>
27099 * expression.cs: Add implicit conversions to the operator ~.
27101 * constant.cs (DecimalConstant.Emit): Emit decimal value.
27103 * typemanager.cs: Locate the decimal constructor.
27105 2002-04-17 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27107 * attribute.cs: use the new property of TypeOf.
27108 * expression.cs: added 'get' property around typearg.
27110 These changes fix a build breaker reported by NickD. Is this the
27111 correct way to fix? If not, please, revert my changes and make it
27114 2002-04-17 Miguel de Icaza <miguel@ximian.com>
27116 * attribute.cs: Add support for typeof in attribute invocations.
27117 I am not sure that this is right though.
27119 2002-04-14 Duncan Mak <duncan@ximian.com>
27121 * cfold.cs (BinaryFold): Catch DivideByZeroException in the
27122 Binary.Operator.Division case.
27124 2002-04-13 Ravi Pratap <ravi@ximian.com>
27126 * class.cs (DefineType): Ensure that we do a proper check on
27127 attribute types and also register it with the TypeManager.
27129 (TypeContainer.Targets): The default for attribute types is
27130 AttributeTargets.All.
27132 * attribute.cs (ApplyAttributes): Registering the attribute type
27133 is done elsewhere, not when we discover we have a Usage attribute.
27135 2002-04-12 Ravi Pratap <ravi@ximian.com>
27137 * expression.cs (VerifyArgumentsCompat): Implement Miguel's suggestion
27138 and get rid of is_delegate parameter.
27140 * everywhere : update.
27142 2002-04-12 Ravi Pratap <ravi@ximian.com>
27144 * cs-parser.jay (compilation_unit): Revamp completely to use
27145 some new ideas that I got from Rhys' grammar to solve the problems
27146 with assembly level attributes.
27148 (outer_declaration): New grammar production.
27150 (attribute_sections): Add.
27152 (opt_attributes): Base on attribute_sections
27154 (namespace_declaration): Allow opt_attributes to tackle the case
27155 when we have assembly level attributes - we are clever in this
27158 * attribute.cs (ApplyAttributes): Do not worry about assembly
27159 attributes in the non-global context.
27161 * rootcontext.cs (AddGlobalAttributes): Go back to using this
27162 instead of SetGlobalAttributes.
27164 * class.cs, rootcontext.cs : Ensure we define and generate
27165 attribute types before anything else.
27167 * attribute.cs (CheckAttribute and GetValidPlaces): Handle the exception
27168 and flag the new error -20 for the case when the attribute type
27169 does not have valid targets specified. csc does not catch this.
27171 * ../errors/errors.txt : update for error # -20
27173 2002-04-11 Ravi Pratap <ravi@ximian.com>
27175 * support.cs (InternalParameters.ParameterModifier): Do some null
27176 checking and return sane values.
27178 * class.cs (Method.Define): If we are a PInvoke method, ensure
27179 that we are static and extern. Report error # 601
27181 * ../errors/cs0601.cs : Add test case for the above error.
27183 2002-04-07 Ravi Pratap <ravi@ximian.com>
27185 * rootcontext.cs (attribute_types): We need to keep type of
27186 all attribute types separately and emit code for them first.
27188 (RegisterAttribute) : Implement.
27190 * class.cs (DefineType): Check if the current Type is a custom
27191 attribute type and register it accordingly.
27193 * rootcontext.cs (AddGlobalAttributes): Fix silly bug where we were
27194 adding the first attribute twice and rename to
27196 (SetGlobalAttributes): this.
27198 * rootcontext.cs (NamespaceLookup): Run through the aliases too and perform
27201 * attribute.cs (ApplyAttributes): Take an additional argument telling us
27202 if we are processing global arguments. Hmm, I am unsure of this.
27204 2002-04-12 Gonzalo Paniagua Javier <gonzalo@ximian.com>
27206 * expression.cs: added static array of strings to avoid calling
27207 Enum.ToString () for Operator in Binary. Significant recover of
27210 2002-04-10 Miguel de Icaza <miguel@ximian.com>
27212 * class.cs (FindMembers): Allow the Builders of the various
27213 members to be null. If they are skip them. This only happens
27214 during the PInvoke declaration.
27216 2002-04-09 Miguel de Icaza <miguel@ximian.com>
27218 * parameter.cs (Parameters.ComputeParameterTypes): Flag the
27219 failure, so we do not keep going afterwards.
27221 * expression.cs: (Invocation.OverloadResolve): I believe Ravi
27222 wanted to pass `false' as the `is_delegate' argument. If this is
27223 the case, why not use delegate_type == null to mean `is_delegate =
27224 false' and anything else as is_delegate = true.
27226 Tue Apr 9 05:40:12 2002 Piers Haken <piersh@friskit.com>
27228 * statement.cs: fixed SimpleSwitchEmit to make 'goto case' goto the
27229 code for the section, not the beginning of the tests.
27231 2002-04-08 Miguel de Icaza <miguel@ximian.com>
27233 * cfold.cs: Handle operator + (Enum x, Underlying x)
27235 * expression.cs (Binary): same. Warn about errors where we have
27236 Enum/Enum in operator + as well.
27238 Mon Apr 8 06:29:03 2002 Piers Haken <piersh@friskit.com>
27241 - added support for switch(bool)
27242 - optimize loading of I8/U8 constants (ldc.i4, iconv_i8)
27243 - add TableSwitchEmit() to handle table-based switch statements
27245 2002-04-05 Ravi Pratap <ravi@ximian.com>
27247 * expression.cs (Invocation.OverloadResolve): Factor out code which
27248 does parameter compatibility checking with arguments so that we can
27249 re-use the code even from Delegate.VerifyApplicability
27251 (VerifyArgumentsCompat): Move above code here.
27253 * delegate.cs (VerifyApplicability): Get rid of duplicate code
27254 and instead make a call to the above method.
27256 2002-03-31 Ravi Pratap <ravi@ximian.com>
27258 * typemanager.cs (attribute_type): Corresponds to System.Attribute.
27259 We use it to keep track of classes which are attribute types.
27261 2002-04-02 Miguel de Icaza <miguel@ximian.com>
27263 * delegate.cs (Delegate.Define): Correctly define the types in the
27264 presence of fixed and array parameters.
27266 * class.cs (TypeContainers.FindMembers): Use NonPublic flag while
27269 * ecore.cs (Expression.MemberLookup): Reset binding flags to not
27270 include NonPublic after the first iteration.
27272 * class.cs (Indexer.CheckBase): Only check if both parents are
27275 * cs-parser.jay (accessor_body): If empty, set to null.
27277 * ecore.cs (SimpleName.SimpleNameResolve): We did not have the
27278 same code path here to resolve constants names that we did have in
27279 MemberAccess.DoResolve. There is too much code duplicated here.
27281 2002-04-01 Miguel de Icaza <miguel@ximian.com>
27283 * statement.cs, makefile: Drop Statementcollection and just use ArrayLists
27285 * ecore.cs: Optimize UserDefinedConversion by minimizing the calls
27288 * cs-tokenizer.cs: Reuse a single StringBuilder for assembling
27289 tokens, numbers and strings.
27291 * ecore.cs (MethodGroupExpr): Make Emit warn about missing
27294 * delegate.cs: Use ComputeAndDefineParameterTypes for both the
27295 asyncronous parameters and the regular parameters.
27297 * codegen.cs (CodeGen.Init): Use the constructor that allows us to
27298 specify the target directory.
27300 * expression.cs: (This.DoResolve): Simplify
27301 (As.Emit): Optimize, do not generate IsInst if the expression is
27302 always of the given type.
27304 (Is.DoResolve): Bug fix, we were reporting both always/never for
27307 * (Invocation.MakeUnionSet): Simplify vastly and optimize, we were
27308 creating too many unnecessary arrays.
27310 2002-03-31 Miguel de Icaza <miguel@ximian.com>
27312 * class.cs (EmitFieldInitializer): Use Assign expression to assign
27313 fields instead of rolling our own initializer. Takes care of all
27314 implicit conversions, and drops unnecessary static checks/argument.
27316 2002-03-31 Dick Porter <dick@ximian.com>
27318 * driver.cs: use the GetDirectories() return values properly, and
27319 use "/" as path separator.
27321 2002-03-30 Miguel de Icaza <miguel@ximian.com>
27323 * expression.cs (Unary): Optimize - - expr into expr.
27324 (Binary): Optimize a + (-b) into a -b.
27326 * codegen.cs (CodeGen): Made all methods static.
27328 2002-03-29 Miguel de Icaza <miguel@ximian.com>
27332 * decl.cs: Rename `definition' into `TypeBuilder' and drop the
27333 TypeBuilder property.
27335 * cs-parser.jay: Drop the use of RecordXXX and use RecordDecl
27338 * tree.cs: Removed the various RecordXXXX, and replaced with a
27339 single RecordDecl. Removed all the accessor methods, and just
27340 left a single access point Type
27342 * enum.cs: Rename DefineEnum to DefineType.
27344 * decl.cs: New abstract method `DefineType' used to unify the
27345 Defines for Enumerations, Interfaces, TypeContainers and
27348 (FindType): Moved LookupInterfaceOrClass here. Moved the
27349 LookupBaseClasses method that used to live in class.cs and
27350 interface.cs here, and renamed to FindType.
27352 * delegate.cs: Implement DefineType. Take advantage of the
27353 refactored pattern for locating the parent builder without taking
27354 the parent_builder argument (which we know does not work if we are
27355 nested, and triggering a toplevel definition).
27357 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27359 * decl.cs (MemberCore.CheckMethodAgainstBase): Test if the
27360 accessibility of a member has changed during override and report
27363 * class.cs (Method.Define, Property.Define): Only complain on
27364 overrides if the method is private, any other accessibility is
27365 fine (and since we just checked the permission is the same, we are
27368 * cs-tokenizer.cs: only line, region, endregion, if, endif, else
27369 and elif are processed always. The other pre-processing
27370 directives are only processed if we are "taking" the path
27372 2002-03-29 Martin Baulig <martin@gnome.org>
27374 * class.cs (Method.Emit): Only emit symbolic debugging info if the
27375 current location is not Null.
27377 * codegen.cs (CodeGen.SaveSymbols): Split out symbol writing code into
27378 a separate method so we can profile it.
27380 * driver.cs (ShowTime): We need to use `(int) span.TotalSeconds' since
27381 `span.Seconds' are just seconds, but no minutes or hours.
27382 (MainDriver): Profile the CodeGen.SaveSymbols calls.
27384 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27386 * class.cs (Method.Define), (Property.Define), (Indexer.Define):
27387 Remove the gratuitous set of Final:
27389 // If an interface implementation, then we can set Final.
27390 if (((flags & MethodAttributes.Abstract) == 0) &&
27391 implementing.DeclaringType.IsInterface)
27392 flags |= MethodAttributes.Final;
27394 I do not know what I was smoking when I used that.
27397 * cs-parser.jay, delegate.cs: Make Delegate be a DeclSpace, first
27398 step into fixing the name resolution issues for delegates and
27399 unifying the toplevel name resolution.
27401 2002-03-28 Martin Baulig <martin@gnome.org>
27403 * class.cs (Method.Emit): If we have a symbol writer, call its
27404 OpenMethod(), CloseMethod() and SetMethodSourceRange() methods to
27405 tell it about the current method.
27407 * codegen.cs (EmitContext.Mark): New public method. Tell the symbol
27408 writer that we're going to emit the first byte of IL code for a new
27409 statement (a new source line).
27410 (EmitContext.EmitTopBlock): If we have a symbol writer, call
27411 EmitContext.Mark() before emitting any code.
27413 * location.cs (SymbolDocument): Return null when we're Null.
27415 * statement.cs (Statement): Moved the `Location loc' variable here.
27416 (Statement.EmitBoolExpression): If we have a symbol writer, call
27417 ec.Mark() before emitting any code to tell it that we're at the
27418 beginning of a new statement.
27419 (StatementExpression): Added `Location' argument to the constructor.
27420 (Block): Added public readonly variable `StartLocation' and public
27421 variable `EndLocation'. The latter is to be set using SetEndLocation().
27422 (Block): Added constructor which takes a start and end location.
27423 (Block.SetEndLocation): New method. This sets the end location.
27424 (Block.EmitMeta): If we have a symbol writer, tell it the names of the
27425 local variables we create.
27426 (Block.Emit): If we have a symbol writer, call ec.Mark() before emitting
27427 each statement and do also mark the begin and end of the block.
27429 * cs-parser.jay (block : OPEN_BRACE): Use the new `Block' constructor to
27430 tell it the current lexer.Location, use Location.Null for the end of the
27432 (block : OPEN_BRACE opt_statement_list CLOSE_BRACE): When closing the
27433 current block, set its end location using SetEndLocation().
27434 (statement_expression): StatementExpression constructor now takes the
27435 lexer.Location as additional argument.
27436 (for_statement, declare_local_variables): Likewise.
27437 (declare_local_variables): When creating a new implicit block, use the
27438 new Block constructor and pass it the lexer.Location.
27440 2002-03-28 Miguel de Icaza <miguel@ximian.com>
27442 * ecore.cs (Expression.MemberLookup): On interfaces, lookup
27443 members also on the parent interfaces recursively.
27445 2002-03-27 Miguel de Icaza <miguel@ximian.com>
27447 * report.cs: Use new formats, since Gonzalo finished the missing
27450 * expression.cs (Binary.ResolveOperator): added missing operator|
27451 operator& and operator^ for bool/bool.
27453 * cs-parser.jay: CheckDef now takes a Location argument that is
27454 used to report errors more precisly (instead of reporting the end
27455 of a definition, we try to track something which is a lot closer
27456 to the source of the problem).
27458 * cs-tokenizer.cs: Track global token use, so we can properly flag
27459 the use of #define/#undef after the first token has been seen.
27461 Also, rename the reportXXXX to Error_DescriptiveName
27463 * decl.cs (DeclSpace.IsTopLevel): Move property here from
27464 TypeContainer, so that Enum and Interface can use this too.
27466 * class.cs (TypeContainer.LookupInterfaceOrClass,
27467 GetInterfaceOrClass, GetClassBases, DefineType): Drop the
27468 `builder' argument. Typically this was used to pass the parent
27469 builder (a ModuleBuilder or a TypeBuilder from whoever triggered
27472 The problem is that a nested class could trigger the definition of
27473 a toplevel class, and the builder would be obviously wrong in that
27476 So we drop this argument, and we compute dynamically the
27477 TypeBuilder/ModuleBuilder (the correct information was available
27478 to us anyways from DeclSpace.Parent)
27480 * interface.cs (Interface.DefineInterface): Drop builder
27481 parameter cleanup like class.cs
27483 * enum.cs (Enum.DefineEnum): Drop builder parameter. Clean up
27486 * statement.cs (Switch.EmitObjectInteger): Emit short/ushort
27489 (Try.Emit): Propagate the returns value from the statement.
27491 (Return.Emit): Even if we are leavning
27493 * driver.cs: Catch IOExpcetion for Directory.GetFiles as well.
27495 * modifiers.cs: Fix the computation of MethodAttributes flags.
27497 Tue Mar 26 21:14:36 CET 2002 Paolo Molaro <lupus@ximian.com>
27499 * driver.cs: allow compilation of files that start with '/'.
27500 Add a default case when checking the argument of --target.
27502 2002-03-25 Miguel de Icaza <miguel@ximian.com>
27504 * interface.cs: Implement the same search algorithm for types in
27505 the interface code.
27507 * delegate.cs: Do not allow multiple definition.
27509 * Recovered ChangeLog that got accidentally amputated
27511 * interface.cs (Interface.DefineInterface): Prevent from double definitions.
27513 * rootcontext.cs: Load manually enum to allow core classes to
27514 contain enumerations.
27516 * enum.cs, ecore.cs, driver.cs, attribute.cs, class.cs, expression.cs:
27517 Update to new static methods in TypeManager.
27519 * typemanager.cs (GetMethod, GetConstructor): Use our
27520 implementation of FindMembers to find the members, since during
27521 corlib compilation, the types are TypeBuilders and GetMethod and
27522 GetConstructor do not work.
27524 Make all methods in TypeManager static.
27526 (InitCodeHelpers): Split the functionality from
27527 the InitCodeTypes function.
27529 * driver.cs: Call InitCodeHelpers after we have populated the
27532 * cs-parser.jay (delegate_declaration): we did not used to compute
27533 the delegate name correctly for void delegates.
27535 2002-03-24 Miguel de Icaza <miguel@ximian.com>
27537 * rootcontext.cs (RootContext): Init the interface_resolve_order
27538 and type_container_resolve_order always.
27540 (ResolveCore, BootstrapCorlib_ResolveClass,
27541 BootstrapCorlib_ResolveStruct): New functions to bootstrap the
27542 compiler when compiling with --nostdlib
27544 * class.cs (TypeContainer.DefineType): Check that our parent is
27545 not null. This test is most important when we are bootstraping
27548 * codegen.cs: Split out the symbol writing code.
27550 2002-03-25 Martin Baulig <martin@gnome.org>
27552 * driver.cs (-g): Made -g an alias for --debug.
27554 2002-03-24 Martin Baulig <martin@gnome.org>
27556 * codegen.cs (SymbolWriter): New public variable. Returns the
27557 current symbol writer.
27558 (CodeGen): Added `bool want_debugging_support' argument to the
27559 constructor. If true, tell the ModuleBuild that we want debugging
27560 support and ask it for the ISymbolWriter.
27561 (Save): If we have a symbol writer, call it's Close() method after
27562 saving the assembly.
27564 * driver.c (--debug): New command line argument to create a
27565 debugger information file.
27567 * location.cs (SymbolDocument): New public property. Returns an
27568 ISymbolDocumentWriter object for the current source file or null
27569 if we don't have a symbol writer.
27571 2002-03-21 Miguel de Icaza <miguel@ximian.com>
27573 * driver.cs (LoadAssembly): Correctly return when all the paths
27574 have been tried and not before.
27576 * statement.cs (Switch.Emit): return the actual coverage for this
27577 statement (returns/not-returns)
27579 (Switch.SimpleSwitchEmit): Do not generate jumps to the end of the
27580 switch of the statement if we are the last switch section. That
27581 kills two problems: try/catch problems (we used to emit an empty
27582 nop at the end) and switch statements where all branches would
27585 2002-03-19 Miguel de Icaza <miguel@ximian.com>
27587 * driver.cs: Add default assemblies (the equivalent to the
27588 Microsoft CSC.RSP file)
27590 * cs-tokenizer.cs: When updating `cols and setting it to zero,
27591 also update tokens_seen and set it to false.
27593 * driver.cs: Implement --recurse for Mike.
27595 * driver.cs (SplitPathAndPattern): Small bug fix, I was not
27596 correctly splitting out the paths.
27598 2002-03-18 Miguel de Icaza <miguel@ximian.com>
27600 * interface.cs (Interface.PopulateProperty): Instead of using
27601 `parent' as the declaration space for the set parameters, use
27604 * support.cs (InternalParameters): InternalParameters constructor
27605 takes a DeclSpace instead of a TypeContainer.
27607 * expression.cs (ArrayCreation.EmitDynamicInitializers): If value
27608 types are being initialized, load the address of it before calling
27611 (New): Provide a mechanism to disable the generation of local
27612 value type temporaries when the caller will be providing us with
27613 an address to store it.
27615 (ArrayCreation.EmitDynamicInitializers): Use it.
27617 2002-03-17 Miguel de Icaza <miguel@ximian.com>
27619 * expression.cs (Invocation.EmitArguments): Only probe for array
27620 property if there is more than one argument. Sorry about that.
27622 * class.cs (Invocation.EmitArguments): Fix to emit arguments for
27623 empty param arrays.
27625 * class.cs (Method.LabelParameters): Fix incorrect code path that
27626 prevented the `ParamArrayAttribute' from being applied to the
27629 2002-03-16 Miguel de Icaza <miguel@ximian.com>
27631 * support.cs (ReflectionParameters): Correctly compute whether the
27632 last argument is a params array. Fixes the problem with
27635 * typemanager.cs: Make the assemblies array always be non-null
27636 (empty, but non-null)
27638 * tree.cs (RecordDecl): New function that abstracts the recording
27639 of names. This reports error 101, and provides a pointer to the
27640 previous declaration. Fixes a crash in the compiler.
27642 * cs-parser.jay (constructor_declaration): Update to new grammar,
27643 and provide a constructor_body that can be empty.
27645 2002-03-15 Miguel de Icaza <miguel@ximian.com>
27647 * driver.cs: Add support for --resources.
27649 * expression.cs: (FetchGetMethod, FetchAddressMethod, EmitAssign):
27650 Make all types for the various array helper methods be integer.
27652 * ecore.cs (Expression.ConvertNumericExplicit): Pass the
27653 CheckState to ConvCast.
27655 (ConvCast): Now it takes a `checked' state argument, to avoid
27656 depending on the emit context for the conversion, and just using
27657 the resolve time setting.
27659 * expression.cs (ArrayCreation.EmitArrayArguments): New function,
27660 instead of Invocation.EmitArguments. We do not emit the original
27661 arguments, instead we emit those which have been converted to
27662 unsigned int expressions.
27664 * statement.cs (Block.EmitMeta): Drop tracking of indexes.
27666 * codegen.cs: ditto.
27668 * expression.cs (LocalVariableReference): Drop the use of the
27669 Store function that depended on the variable index.
27671 * statement.cs (VariableInfo): Drop the `Idx' property from this
27672 class, as this is not taking into account the indexes for
27673 temporaries tat we generate during the execution, getting the
27676 * class.cs: First emit class initializers, then call the parent
27679 * expression.cs (Binary): Fix opcode emision.
27680 (UnaryMutator.EmitCode): Support checked code generation
27682 * ecore.cs (MemberLookup): TypeManager.FindMembers will return
27683 matches for events for both the Static and Instance scans,
27684 pointing to the same element. Fix that.
27686 2002-03-14 Miguel de Icaza <miguel@ximian.com>
27688 * rootcontext.cs (ResolveTree): Always set the
27689 interface_resolve_order, because nested interfaces will be calling
27692 * class.cs (GetInterfaceOrClass): Track the same resolution
27693 process used by TypeManager.LookupType. This fixes the nested
27694 type lookups in class declarations (separate path from
27697 (TypeContainer.DefineType): Also define nested interfaces.
27698 (TypeContainer.RegisterOrder): New public function used to
27699 register the order in which child interfaces need to be closed.
27701 Nested interfaces need to be closed after their parents have been
27704 * interface.cs (InterfaceAttr): Put all the logic for computing
27705 the interface attribute here.
27707 (DefineInterface): Register our interface order with the
27708 RootContext or with the TypeContainer depending on the case.
27710 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27712 * cs-parser.jay: rework foreach statement to work with the new
27713 changes to the policy on SimpleNames.
27715 * report.cs: support Stacktrace on warnings as well.
27717 * makefile: drop --unsafe and /unsafe from the compile.
27719 2002-03-13 Ravi Pratap <ravi@ximian.com>
27721 * ecore.cs (StandardConversionExists): Modify to take an Expression
27722 as the first parameter. Ensure we do null -> reference type conversion
27725 * Everywhere : update calls accordingly, making use of MyEmptyExpr to store
27726 temporary Expression objects.
27728 Wed Mar 13 12:32:40 CET 2002 Paolo Molaro <lupus@ximian.com>
27730 * interface.cs: workaround bug in method overloading resolution
27731 (there is already a bugzilla bug for it).
27733 2002-03-12 Miguel de Icaza <miguel@ximian.com>
27735 We could also solve this problem by having a separate path for
27736 performing type lookups, instead of DoResolve, we could have a
27737 ResolveType entry point, and only participating pieces of the
27738 production (simplename, deref, array) would implement this.
27740 * codegen.cs (EmitContext): New field OnlyLookupTypes used to
27741 signal SimpleName to only resolve type names and not attempt to
27742 resolve anything else.
27744 * expression.cs (Cast): Set the flag.
27746 * ecore.cs (SimpleName): Use the OnlyLookupTypes flag
27748 * class.cs: Only report 108 if there is no `new' modifier.
27750 * cs-parser.jay: rework foreach statement to work with the new
27751 changes to the policy on SimpleNames.
27753 * report.cs: support Stacktrace on warnings as well.
27755 * makefile: drop --unsafe and /unsafe from the compile.
27757 2002-03-11 Miguel de Icaza <miguel@ximian.com>
27759 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27760 lookups here, instead of doing that at parse time. This means
27761 that our grammar will not introduce `LocalVariableReferences' as
27762 expressions at this point. That solves the problem of code like
27766 static void Main ()
27770 This is only half the fix. The full fix requires parameters to
27771 also be handled in this way.
27773 * Everywhere: Use ec.DeclSpace on calls to LookupType, as this
27774 makes the use more obvious of the DeclSpace. The
27775 ec.TypeContainer.TypeBuilder is now only used to pull the
27776 TypeBuilder for it.
27778 My theory is that I can get rid of the TypeBuilder completely from
27779 the EmitContext, and have typecasts where it is used (from
27780 DeclSpace to where it matters).
27782 The only pending problem is that the code that implements Aliases
27783 is on TypeContainer, and probably should go in DeclSpace.
27785 * ecore.cs (SimpleName.SimpleNameResolve): Perform local variable
27786 lookups here, instead of doing that at parse time. This means
27787 that our grammar will not introduce `LocalVariableReferences' as
27788 expressions at this point. That solves the problem of code like
27792 static void Main ()
27796 This is only half the fix. The full fix requires parameters to
27797 also be handled in this way.
27799 * class.cs (Property.DefineMethod): When implementing an interface
27800 method, set newslot, when implementing an abstract method, do not
27801 set the flag (before we tried never setting it, or always setting
27802 it, which is the difference).
27803 (Indexer.DefineMethod): same.
27804 (Method.DefineMethod): same.
27806 * ecore.cs: Only set the status used flag if we get back a Field.
27808 * attribute.cs: Temporary hack, so Paolo can keep working.
27810 2002-03-08 Ravi Pratap <ravi@ximian.com>
27812 * attribute.cs (Attribute.UnmanagedType): This is to keep track of
27813 the unmanaged type in the case we have a MarshalAs attribute.
27815 (Resolve): Handle the case when we are parsing the special MarshalAs
27816 attribute [we need to store the unmanaged type to use later]
27818 * typemanager.cs (marshal_as_attr_type): Built in type for the
27819 MarshalAs Attribute.
27821 * attribute.cs (ApplyAttributes): Recognize the MarshalAs attribute
27822 on parameters and accordingly set the marshalling info.
27824 2002-03-09 Miguel de Icaza <miguel@ximian.com>
27826 * class.cs: Optimizing slightly by removing redundant code after
27827 we switched to the `NoTypes' return value.
27828 (Property.DefineMethod): use NoTypes here too.
27830 This fixes the bug I introduced in my last batch of changes.
27832 2002-03-05 Ravi Pratap <ravi@ximian.com>
27834 * tree.cs (RecordEnum): Add. We now keep track of enums too.
27836 * class.cs (LookupInterfaceOrClass): Check against the list of recorded
27837 Enums since those are types too.
27839 * cs-parser.jay (enum_declaration): Record enums as we parse them.
27841 * enum.cs (DefineEnum): Return if the TypeBuilder has already been defined
27842 thanks to a call during the lookup process.
27844 2002-03-07 Miguel de Icaza <miguel@ximian.com>
27846 * statement.cs (Foreach): Lots of work to accomodate a particular
27847 kind of foreach statement that I had not kept in mind. It is
27848 possible to have foreachs on classes that provide a GetEnumerator
27849 method that return objects that implement the "pattern" for using
27850 a foreach, there is no need to support GetEnumerator
27853 This is needed to compile nant.
27855 * decl.cs: Only report 114 if the member is not `Finalize' and if
27856 the warning level is at least 2.
27858 * class.cs: Moved the compare function from Method to
27861 (MethodSignature.InheritableMemberSignatureCompare): Add new
27862 filter function that is used to extract inheritable methods from a
27865 (Method.Define): Use the new `inheritable_method_signature_filter'
27868 * cs-tokenizer.cs (get_cmd_arg): Do not add white space to the
27871 2002-03-06 Miguel de Icaza <miguel@ximian.com>
27873 * ecore.cs (Expression.ConvertReferenceExplicit): Removed dead code.
27875 * cs-parser.jay: Add opt_semicolon to the interface declaration.
27877 * expression.cs: Pass location information to
27878 ConvertImplicitStandard.
27880 * class.cs: Added debugging code to track return values from
27883 2002-03-05 Miguel de Icaza <miguel@ximian.com>
27885 * expression.cs (Is.DoResolve): If either side of the `is' is an
27886 interface, do not flag the warning.
27888 * ecore.cs (ImplicitReferenceConversion): We need a separate test
27891 * report.cs: Allow for --fatal to be used with --probe.
27893 * typemanager.cs (NoTypes): Move the definition for the empty Type
27896 * class.cs (TypeContainer.FindMembers): Also look for methods defined by
27898 (TypeContainer.DefineProxy): New function used to proxy to parent
27899 implementations when implementing interfaces.
27900 (TypeContainer.ParentImplements): used to lookup if our parent
27901 implements a public function that is required by an interface.
27902 (TypeContainer.VerifyPendingMethods): Hook this up.
27904 * typemanager.cs (TypeManager, AddModule, AddAssembly): Make the
27905 `modules' and `assemblies' arraylists into arrays. We only grow
27906 these are the very early start up of the program, so this improves
27907 the speedof LookupType (nicely measured).
27909 * expression.cs (MakeByteBlob): Replaced unsafe code with
27910 BitConverter, as suggested by Paolo.
27912 * cfold.cs (ConstantFold.Binary): Special case: perform constant
27913 folding of string concatenation, but if either side is a string,
27914 and the other is not, then return null, and let the runtime use
27915 the concatenation on the string plus the object (using
27916 `Object.ToString').
27918 2002-03-04 Miguel de Icaza <miguel@ximian.com>
27920 Constant Folding has been implemented now.
27922 * expression.cs (Unary.Reduce): Do not throw an exception, catch
27923 the error instead on types that are not supported in one's
27926 * constant.cs (Constant and all children): New set of functions to
27927 perform implict and explicit conversions.
27929 * ecore.cs (EnumConstant): Implement the new functions to perform
27930 conversion by proxying to the child expression.
27932 * codegen.cs: (ConstantCheckState): Constant evaluation has its
27933 own separate setting that can not be turned off from the command
27934 line using --unchecked or --checked and is only controlled using
27935 the checked/unchecked statements and expressions. This setting is
27936 used by the constant folder to flag errors.
27938 * expression.cs (CheckedExpr, UncheckedExpr): Set the
27939 ConstantCheckState as well.
27941 During Resolve, they also have to flag the state, because the
27942 constant folder runs completely in the Resolve phase.
27944 * statement.cs (Checked, Unchecked): Set the ConstantCheckState as
27947 2002-03-01 Miguel de Icaza <miguel@ximian.com>
27949 * cfold.cs: New file, this file contains the constant folder.
27951 * ecore.cs (IMemoryLocation.AddressOf): Now takes an extra
27952 argument to track whether we are using the resulting address to
27953 load or store a value and provide better error messages.
27955 (FieldExpr.Emit, FieldExpr.EmitAssign, FieldExpr.AddressOf): Use
27956 new AddressOf arguments.
27958 * statement.cs (Foreach.EmitCollectionForeach): Update
27960 * expression.cs (Argument.Emit): Call AddressOf with proper
27961 arguments to track usage.
27963 (New.DoEmit): Call AddressOf with new arguments.
27965 (Unary.Emit): Adjust AddressOf call.
27967 2002-03-01 Ravi Pratap <ravi@ximian.com>
27969 * cs-parser.jay (member_access): Change the case for pre-defined types
27970 to use a MemberAccess instead of a SimpleName. Thanks to Felix again for
27973 * class.cs (Operator::Emit): If we are abstract or extern, we don't have
27976 * attribute.cs (CheckAttribute, ApplyAttribute): Ensure that we treat operators
27977 essentially like methods and apply attributes like MethodImplOptions to them too.
27979 * ecore.cs (SimpleName.SimpleNameResolve): Perform a check on ec.TypeContainer.TypeBuilder
27982 * codegen.cs (EmitContext): The constructor now takes in an extra argument specifying the
27983 DeclSpace as the distinction is important. We provide sane defaults as usually the TypeContainer
27986 * Update code everywhere accordingly.
27988 * ecore.cs : Change references to ec.TypeContainer to ec.DeclSpace where appropriate.
27990 * cs-parser.jay (enum_declaration): Set the current namespace of the enum.
27992 2002-02-28 Ravi Pratap <ravi@ximian.com>
27994 * rootcontext.cs (LookupType): As we cycle through the chain of namespaces
27995 try performing lookups against those instead of jumping straight into using
27996 the 'using' clauses.
27998 (ImplicitParent): Add. Thanks to Felix Arrese-Igor for this idea.
28000 (LookupType): Perform lookups in implicit parents too.
28002 * class.cs (GetInterfaceOrClass): Modify to perform the exact same lookup
28003 sequence as RootContext.LookupType.
28005 * rootcontext.cs (NamespaceLookup): Split out code from LookupType which tries
28006 the various cases of namespace lookups into this method.
28008 2002-03-01 Miguel de Icaza <miguel@ximian.com>
28010 * cs-parser.jay: Add support for [Attribute ()] (empty arguments
28011 in positional arguments)
28013 * class.cs (Operator): Update the AllowedModifiers to contain
28016 * cs-parser.jay: Update operator declaration to allow for the
28017 operator body to be empty.
28019 * cs-tokenizer.cs: Added '\u' unicode support in strings and hex
28022 2002-02-27 Miguel de Icaza <miguel@ximian.com>
28024 * class.cs (Method.Emit): Label parameters.
28026 * driver.cs: Return 1 or 0 as the program exit code.
28028 2002-02-26 Miguel de Icaza <miguel@ximian.com>
28030 * expression.cs: Special case the `null' object when trying to
28031 auto-compute the type, as anything can be explicitly converted to
28034 * ecore.cs (Expression.ConvertExplicit): Bug fix, thanks for
28035 spotting this Paolo.
28037 (Expression.ImplicitNumericConversion): Perform comparissions of
28038 the type using the underlying type in the case of an enumeration
28039 rather than using the enumeration type for the compare.
28041 Cope with the underlying == type case, which is not possible to
28044 (Expression.ConvertNumericExplicit): Perform comparissions of
28045 the type using the underlying type in the case of an enumeration
28046 rather than using the enumeration type for the compare.
28048 * driver.cs: If the user does not supply an extension, assume .exe
28050 * cs-parser.jay (if_statement): Rewrote so that we can track the
28051 location for the if statement.
28053 * expression.cs (Binary.ConstantFold): Only concat strings when
28054 the operation is "+", not everything ;-)
28056 * statement.cs (Statement.EmitBoolExpression): Take a location
28058 (If, While, Do): Track location.
28060 * expression.cs (Binary.ResolveOperator): In the object + string
28061 case, I was missing a call to ConvertImplicit
28063 2002-02-25 Ravi Pratap <ravi@ximian.com>
28065 * parameter.cs (Parameter.ExternalType): Take in extra DeclSpace and
28066 Location arguments. Ensure we use RootContext.LookupType to do our work
28067 and not try to do a direct Type.GetType and ModuleBuilder.GetType
28069 * interface.cs (PopulateMethod): Handle the type of the parameter being
28072 * expression.cs (Invocation.BetterFunction): Handle the case when we
28073 have a params method with no fixed arguments and a call is made with no
28076 2002-02-25 Miguel de Icaza <miguel@ximian.com>
28078 * cs-tokenizer.cs: Add support for the quote-escape-sequence in
28079 the verbatim-string-literal
28081 * support.cs (InternalParameters.ParameterModifier): handle null
28083 (InternalParameters.ParameterType): ditto.
28085 * parameter.cs (VerifyArgs): Also check if the fixed parameter is
28086 duplicating the name of the variable parameter.
28087 (GetParameterByName): Fix bug where we were not looking up array
28088 paramters if they were the only present (thanks Paolo!).
28089 (GetParameterInfo): We only have an empty set of types if both
28090 fixed and array are set to null.
28091 (GetParameterInfo-idx): Handle FixedParameter == null
28093 * cs-parser.jay: Handle the case where there is no catch
28094 statements (missing null test).
28096 2002-02-22 Miguel de Icaza <miguel@ximian.com>
28098 * driver.cs (MainDriver): Be conservative on our command line
28101 Catch DirectoryNotFoundException when calling GetFiles.
28103 (SplitPathAndPattern): Used to split the input specification into
28104 a path and a pattern that we can feed to Directory.GetFiles.
28106 2002-02-21 Miguel de Icaza <miguel@ximian.com>
28108 * statement.cs (Fixed): Implement the last case of the Fixed
28109 statement (string handling).
28111 * expression.cs (StringPtr): New class used to return a char * to
28112 a string; Used by the Fixed statement.
28114 * typemanager.cs: Add char_ptr_type. Add get_OffsetToStringData method.
28116 * expression.cs (Binary.ResolveOperator): Remove redundant
28117 MemberLookup pn parent type.
28118 Optimize union call, we do not need a union if the types are the same.
28119 (Unary.ResolveOperator): REmove redundant MemberLookup on parent
28122 Specialize the use of MemberLookup everywhere, instead of using
28123 the default settings.
28125 (StackAlloc): Implement stackalloc keyword.
28127 * cs-parser.jay: Add rule to parse stackalloc.
28129 * driver.cs: Handle /h, /help, /?
28131 * expression.cs (MakeByteBlob): Removed the hacks we had in place
28132 before we supported unsafe code.
28134 * makefile: add --unsafe to the self compilation of mcs.
28136 2002-02-20 Miguel de Icaza <miguel@ximian.com>
28138 * expression.cs (PointerArithmetic): New class that is used to
28139 perform pointer arithmetic.
28140 (Binary.Resolve): Handle pointer arithmetic
28141 Handle pointer comparission.
28142 (ArrayPtr): Utility expression class that is used to take the
28143 address of an array.
28145 (ElementAccess): Implement array access for pointers
28147 * statement.cs (Fixed): Implement fixed statement for arrays, we
28148 are missing one more case before we are done.
28150 * expression.cs (Indirection): Implement EmitAssign and set the
28151 ExprClass to Variable. This allows pointer dereferences to be
28152 treated as variables, and to have values assigned to them.
28154 * ecore.cs (Expression.StoreFromPtr): New utility function to
28155 store values dereferencing.
28157 2002-02-20 Ravi Pratap <ravi@ximian.com>
28159 * expression.cs (Binary.ResolveOperator): Ensure that we are
28160 not trying to operate on a void type - this fixes the reported
28163 * decl.cs (CheckMethodAgainstBase): Do not allow overriding if
28164 the parent implementation is sealed.
28166 * ../errors/cs0239.cs : Add.
28168 * attribute.cs (ApplyAttributes): Handle Modulebuilders too.
28170 * typemanager.cs (unverifiable_code_type): Corresponds to
28171 System.Security.UnverifiableCodeAttribute. We need to emit this for modules
28172 which have unsafe code in them.
28174 * rootcontext.cs (EmitCode): Emit the above attribute when we are in an
28177 2002-02-19 Miguel de Icaza <miguel@ximian.com>
28179 * cs-tokenizer.cs: Add support for @"litreal strings"
28181 Make tokenizer accept pre-processor directives
28182 on any column (remove the old C-like limitation).
28184 * rootcontext.cs (EmitCode): Emit any global attributes.
28185 (AddGlobalAttributes): Used to keep track of assembly attributes.
28187 * attribute.cs (ApplyAttributes): Support AssemblyAttributes.
28189 * cs-parser.jay: Add support for global attributes.
28191 2002-02-17 Miguel de Icaza <miguel@ximian.com>
28193 * expression.cs (Indirection): New helper class. Unary will
28194 create Indirection classes to be able to implement the
28195 IMemoryLocation interface on it.
28197 2002-02-16 Miguel de Icaza <miguel@ximian.com>
28199 * cs-parser.jay (fixed_statement): reference the right statement.
28201 * statement.cs (Fixed.Emit): Finish implementing the fixed
28202 statement for the &x case.
28204 2002-02-14 Miguel de Icaza <miguel@ximian.com>
28206 * class.cs (Property.Define, Method.Define): Remove newslot when
28209 * modifiers.cs: My use of NewSlot when `Abstract' was set was
28210 wrong. NewSlot should only be used if the `new' keyword is present.
28212 * driver.cs (GetSystemDir): Use CodeBase instead of FullName for
28213 locating our system dir. Sorry about this.
28215 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28217 * driver.cs (GetSystemDir): Compute correctly the location of our
28218 system assemblies. I was using the compiler directory instead of
28219 the library directory.
28221 2002-02-13 Ravi Pratap <ravi@ximian.com>
28223 * expression.cs (BetterFunction): Put back in what Miguel commented out
28224 since it is the correct fix. The problem is elsewhere ;-)
28226 (IsParamsMethodApplicable): Fix bug where we were not checking that the fixed
28227 parameters of the parms method are themselves compatible or not !
28229 (StandardConversionExists): Fix very dangerous bug where we were forgetting
28230 to check that a class implements an interface before saying that an implicit
28231 conversion was allowed. Use ImplementsInterface to do the checking.
28233 2002-02-13 Miguel de Icaza <miguel@ximian.com>
28235 * class.cs (Method.Define): Track whether we are an explicit
28236 implementation or not. And only call DefineMethodOverride if we
28237 are an explicit implementation.
28239 (Property.DefineMethod): Ditto.
28241 2002-02-11 Ravi Pratap <ravi@ximian.com>
28243 * expression.cs (BetterFunction): Catch hideous bug which was
28244 preventing us from detecting ambiguous calls due to implicit casts i.e
28247 2002-01-29 Miguel de Icaza <miguel@ximian.com>
28249 * support.cs (Pair): Remove un-needed method. I figured why I was
28250 getting the error in cs-parser.jay, the variable in a foreach loop
28251 is readonly, and the compiler does not really treat this as a variable.
28253 * cs-parser.jay (fixed_statement): Fix grammar. Use ASSIGN
28254 instead of EQUALS in grammar.
28256 * typemanager.cs (VerifyUnmanaged): Report correct error (208)
28258 * expression.cs (Unary.DoResolve): Check whether the argument is
28261 2002-01-28 Miguel de Icaza <miguel@ximian.com>
28263 * support.cs: Api for Pair to set a value. Despite the fact that
28264 the variables are public the MS C# compiler refuses to compile
28265 code that accesses the field if the variable is part of a foreach
28268 * statement.cs (Fixed): Begin implementation of the fixed
28271 (Block.AddVariable): Return the VariableInfo on success and null
28272 on failure instead of true/false.
28274 * cs-parser.jay (foreach): Catch errors on variables already
28275 defined (we were ignoring this value before) and properly unwind
28276 the block hierarchy
28278 (fixed_statement): grammar for the fixed statement.
28280 2002-01-25 Miguel de Icaza <miguel@ximian.com>
28282 * expression.cs (UnaryMutator.IsIncrementableNumber): Allow also
28283 pointer types to be incretemented.
28285 (SizeOf): Implement.
28287 * cs-parser.jay (pointer_member_access): Implement
28288 expr->IDENTIFIER production.
28290 * expression.cs (IndexerAccess.DoResolve, ArrayAccess.DoResolve,
28291 MemberAccess.DoResolve, Invocation.DoResolve): Check for pointers
28294 (Unary): Implement indirection.
28296 * ecore.cs (Expression.UnsafeError): Reports error 214 (pointer
28297 use in non-unsafe context).
28299 (SimpleName.DoResolve): Check for pointers in field access on safe
28302 (Expression.LoadFromPtr): Factor the load-indirect code in this
28303 function. This was duplicated in UnboxCast and ParameterReference
28305 2002-01-24 Miguel de Icaza <miguel@ximian.com>
28307 * expression.cs (ComposedCast): report an error if a pointer cast
28308 is used in a safe region.
28310 * ecore.cs (Expression.ConvertExplicit): Add rules for implicit
28311 pointer type casts in unsafe context.
28313 * codegen.cs (EmitContext): Set up IsUnsafe.
28315 * cs-parser.jay (non_expression_type): Add productions for pointer
28318 * expression.cs (Invocation.EmitCall): Remove chunk of buggy
28319 code. We should not use force into static mode if the method is
28320 not virtual. Fixes bug in MIS
28322 * statement.cs (Do.Emit, While.Emit, For.Emit,
28323 Statement.EmitBoolExpression): Add support to Do and While to
28324 propagate infinite loop as `I do return' semantics.
28326 Improve the For case to also test for boolean constants.
28328 * attribute.cs (Attribute.ApplyAttributes): Add ParameterBuilder
28329 to the list of attributes we can add.
28331 Remove `EmitContext' argument.
28333 * class.cs (Method.Define): Apply parameter attributes.
28334 (Constructor.Define): Apply parameter attributes.
28335 (MethodCore.LabelParameters): Move here the core of labeling
28338 * support.cs (ReflectionParameters.ParameterModifier,
28339 InternalParameters.ParameterModifier): Use IsByRef on the type and
28340 only return the OUT bit for these parameters instead of in/out/ref
28343 This is because I miss-understood things. The ParameterInfo.IsIn
28344 and IsOut represent whether the parameter has the [In] and [Out]
28347 2002-01-22 Miguel de Icaza <miguel@ximian.com>
28349 * ecore.cs (FieldExpr.Emit): Release temporaries.
28351 * assign.cs (LocalTemporary.Release): new function.
28353 * codegen.cs (EmitContext.GetTemporaryStorage,
28354 EmitContext.FreeTemporaryStorage): Rework the way we deal with
28355 temporary storage. Now we can "put back" localbuilders when we
28358 2002-01-21 Miguel de Icaza <miguel@ximian.com>
28360 * ecore.cs (FieldExpr.Emit): Handle initonly fields specially: we
28361 need to make a copy of the variable to generate verifiable code.
28363 2002-01-19 Miguel de Icaza <miguel@ximian.com>
28365 * driver.cs: Compute dynamically the system directory.
28367 * ecore.cs (CopyNewMethods): reworked, exposed, made public.
28368 Slower, but more generally useful. Used by the abstract
28369 registering implementation.
28371 * expression.cs (ResolveMemberAccess): Reorder the way we evaluate
28372 the rules for the special rule on Type/instances. First check if
28373 we have the same name, and if so, try that special static path
28374 rather than the instance path.
28376 2002-01-18 Miguel de Icaza <miguel@ximian.com>
28378 * cs-parser.jay: Emit 642 (warning: possible empty statement) for
28381 * class.cs (TypeBuilder.DefineType): Do not allow inheritance from
28382 Enum, ValueType, Delegate or Array for non-corlib compiles.
28384 * cs-tokenizer.cs: Catch long identifiers (645)
28386 * typemanager.cs (IndexerPropetyName): Ravi never tested this
28389 * class.cs (TypeContainer.RegisterRequiredImplementations): Bug
28390 fix, we were returning too early, so we were not registering
28391 pending methods from abstract classes.
28393 Do not register pending methods if the class is abstract.
28395 * expression.cs (Conditional.DoResolve): Report circular implicit
28396 conversions when we neecd to compute it for conditional
28399 (Is.DoResolve): If the expression is always of the provided type,
28400 flag warning 183. If the expression can not ever be of the
28401 provided type flag warning 184.
28403 * class.cs: Catch 169 as well.
28405 * ecore.cs (FieldExpr): For now in AddressOf mark as assigned and
28408 2002-01-18 Nick Drochak <ndrochak@gol.com>
28410 * makefile: remove path to beta2 csc.exe. path to csc.exe must be in PATH instead.
28412 2002-01-17 Miguel de Icaza <miguel@ximian.com>
28414 * interface.cs: (PopulateMethod): Check for pointers being defined
28415 only if the unsafe context is active.
28416 (PopulateProperty): ditto.
28417 (PopulateIndexer): ditto.
28419 * class.cs (Method, Method.Define): Allow `unsafe' modifier to be
28420 specified. If pointers are present, make sure that they are
28421 present in an unsafe context.
28422 (Constructor, Constructor.Define): ditto.
28423 (Field, Field.Define): ditto.
28424 (Property, Property.Define): ditto.
28425 (Event, Event.Define): ditto.
28427 * interface.cs (Interface.GetInterfaceTypeByName): Only lookup the
28428 hashtable if there are classes or structs defined.
28430 * expression.cs (LocalVariableReference.DoResolve): Simplify this
28431 code, as the constant resolution moved.
28433 * statement.cs (Block.EmitMeta): Resolve all constants as we emit
28434 the metadata, so we can flag error 133.
28436 * decl.cs (MemberCore.UnsafeOK): New function to test that a
28437 pointer is being declared in an unsafe context.
28439 2002-01-16 Miguel de Icaza <miguel@ximian.com>
28441 * modifiers.cs (Modifiers.Check): Require a Location argument.
28442 Report error 227 for Unsafe use.
28444 * typemanager.cs: Remove IsPointerType, we should be using Type.IsPointer
28446 * statement.cs (For.Emit): If the test is null, then report that
28447 we do `return', as we wont reach anything afterwards.
28449 (Switch.SwitchGoverningType): Track the expression that matched
28452 * driver.cs: Allow negative numbers as an error code to flag.
28454 * cs-parser.jay: Handle 1551.
28456 * namespace.cs: Add 1537 checking (repeated using alias namespaces).
28458 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28460 * cs-parser.jay: Report 1518 (type declaration can only contain
28461 class, struct, interface, enum or delegate)
28463 (switch_label): Report 1523 (keywords `case' or `default' must
28466 (opt_switch_sections): Report 1522 (empty switch)
28468 * driver.cs: Report 1515 (response file specified multiple times)
28469 Report 1516 (Source file specified multiple times).
28471 * expression.cs (Argument.Resolve): Signal 1510
28473 (BaseAccess.Resolve, BaseIndexer.Resolve): Signal 1511 (base
28474 access not allowed in static code)
28476 2002-01-11 Ravi Pratap <ravi@ximian.com>
28478 * typemanager.cs (IsPointerType): Utility method which we are going
28481 * ecore.cs (ImplicitReferenceConversion): A pointer type cannot be cast to
28482 the object type, so we take care of that.
28484 * expression.cs (FullMethodDesc): Also include the return type in descriptions.
28486 * support.cs (ParameterDesc): Fix minor bug which was causing params tags to be
28487 added to non-params parameters :-)
28489 * typemanager.cs (CSharpName): Include 'void' type too.
28491 (void_ptr_type): Include in the set of core types.
28493 * ecore.cs (ConvertImplicit): Make use of ConvertImplicitStandard instead of
28496 (ConvertImplicitStandard): Handle standard implicit pointer conversions when we have
28499 * cs-parser.jay (local_variable_pointer_type): Add support for 'void *' as I had
28500 completely forgotten about it.
28502 2002-01-10 Ravi Pratap <ravi@ximian.com>
28504 * cs-parser.jay (pointer_type): Add. This begins our implementation
28505 of parsing rules for unsafe code.
28507 (unsafe_statement): Implement.
28509 (embedded_statement): Modify to include the above.
28511 * statement.cs (Unsafe): Implement new class for unsafe blocks.
28513 * codegen.cs (EmitContext.InUnsafe): Add. This determines
28514 if the current context is an unsafe one.
28516 * cs-parser.jay (local_variable_pointer_type): Since local variable types
28517 are handled differently, we need separate rules for them.
28519 (local_variable_declaration): Update to use local_variable_pointer_type
28520 to allow variable declarations of unmanaged pointer types.
28522 * expression.cs (Unary.ResolveOperator): Ensure that the '&' operator is used only
28523 in unsafe contexts.
28525 * ../errors/cs0214.cs : Add.
28527 2002-01-16 Nick Drochak <ndrochak@gol.com>
28529 * makefile: remove 'response' file when cleaning.
28531 2002-01-15 Miguel de Icaza <miguel@ximian.com>
28533 * cs-parser.jay: Report 1524.
28535 2002-01-14 Miguel de Icaza <miguel@ximian.com>
28537 * typemanager.cs (RegisterMethod): drop checking if we have
28538 registered this from here
28540 2002-01-12 Miguel de Icaza <miguel@ximian.com>
28542 * class.cs (Method.EmitDestructor): Implement calling our base
28545 * statement.cs (Try.Emit): Fix to reset the InFinally to the old
28546 value of InFinally.
28548 * codegen.cs (EmitContext.EmitTopBlock): Destructors will call
28549 this routine and will wrap the call in a try/catch block. Deal
28552 2002-01-11 Miguel de Icaza <miguel@ximian.com>
28554 * ecore.cs (Expression.MemberLookup): instead of taking a
28555 parameter `same_type' that was used to tell whether we could
28556 access private members we compute our containing type from the
28559 (FieldExpr): Added partial support for volatile fields. This does
28560 not work for volatile fields exposed from assemblies, as I can not
28561 figure out how to extract the modreq from it.
28563 Updated all the source files to use this.
28565 * codegen.cs (EmitContext): Compute ContainerType ahead of time,
28566 because it is referenced by MemberLookup very often.
28568 2002-01-09 Ravi Pratap <ravi@ximian.com>
28570 * typemanager.cs (IndexerPropertyName): If we have a TypeBuilder, use
28571 TypeBuilder.GetCustomAttributes to retrieve what we need.
28573 Get rid of redundant default_member_attr_type as this is the same as
28574 default_member_type which already exists.
28576 * interface.cs, attribute.cs : Update accordingly.
28578 2002-01-08 Miguel de Icaza <miguel@ximian.com>
28580 * typemanager.cs: Enable IndexerPropertyName again. It does not
28581 work for TYpeBuilders though. Ravi, can you please fix this?
28583 * cs-tokenizer.cs: Accept _ as a name in pp-expressions.
28585 * expression.cs (Argument.Emit): Handle the case of ref objects
28586 being passed to ref functions;
28588 (ParameterReference.EmitLoad): Loads the content of the pointer
28589 without dereferencing.
28591 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28593 * cs-tokenizer.cs: Implemented the pre-processing expressions.
28595 2002-01-08 Ravi Pratap <ravi@ximian.com>
28597 * class.cs (Indexer.DefineMethod): Incorporate the interface
28598 type in the name of the method if we are doing explicit interface
28601 * expression.cs (ConversionExists): Remove as it is completely obsolete.
28603 (BetterConversion): Fix extremely trivial bug where we were referring to
28604 ConversionExists instead of StandardConversionExists ! Hooray, things are fine
28607 * ../errors/bug16.cs : Add although we have fixed it.
28609 2002-01-07 Miguel de Icaza <miguel@ximian.com>
28611 * expression.cs (BaseIndexer): Begin implementation.
28613 * class.cs (TypeContainer.IsInterfaceMethod): Bug fix.
28615 * cs-parser.jay (indexer_declarator): Use qualified_identifier
28616 production directly to remove a shift/reduce, and implement
28617 explicit interface implementation.
28619 * cs-tokenizer.cs: Fix tokenizer, it was consuming one extra char
28620 after a floating point suffix.
28622 * expression.cs (DoNumericPromotions): Improved the conversion for
28623 uint/uint. If we have a constant, we avoid doing a typecast to a
28626 * class.cs (Indexer): Implement explicit interface implementation
28629 Sat Jan 5 16:08:23 CET 2002 Paolo Molaro <lupus@ximian.com>
28631 * class.cs: make the default instance constructor public and hidebysig.
28633 2001-01-03 Ravi Pratap <ravi@ximian.com>
28635 * interface.cs (EmitDefaultMemberAttr): Make this helper method static
28636 so we can call it from elsewhere.
28638 * class.cs (TypeContainer.Emit): Emit the attribute here too. The rule is that
28639 we emit it internally if the class has a defined indexer; otherwise the user
28640 emits it by decorating the class definition with the DefaultMemberAttribute.
28642 * attribute.cs (ApplyAttributes): Perform checks to see that the DefaultMember
28643 attribute is not used on a type which defines an indexer.
28645 * cs-tokenizer.cs (get_cmd_arg): Ensure we trim whitespace and also include the tab
28646 character when we skip whitespace.
28648 * ../errors/cs0646.cs : Add.
28650 2002-01-03 Miguel de Icaza <miguel@ximian.com>
28652 * ecore.cs (SimpleName.ResolveSimpleName): Report error 120
28655 * makefile: Add practical target `mcs3.exe' which builds the third
28656 generation compiler.
28658 * expression.cs (New): Fix structures constructor calling.
28660 * class.cs (Property, Method, Indexer): Emit Final flag on the
28661 method if we are an interface implementation and we are not
28664 * ecore.cs (PropertyExpr): New public field `IsBase', tells
28665 whether this property is referencing a `base' method.
28667 * expression.cs (Invocation.EmitCall): take an extra argument:
28668 is_base, this is used to determine whether the `call' or
28669 `callvirt' opcode should be used.
28672 * delegate.cs: update EmitCall.
28674 * class.cs (Method.Define): Set NewSlot for the cases where we are
28675 not implementing an interface method.
28677 (Property.Define): ditto.
28679 2002-01-02 Miguel de Icaza <miguel@ximian.com>
28681 * cs-tokenizer.cs: (Tokenizer.escape): Escape '\r' as '\r' not as
28682 'r'. Allows mcs to parse itself fully.
28684 2002-01-02 Ravi Pratap <ravi@ximian.com>
28686 * expression.cs (ArrayCreation.num_automatic_initializers): Keep track
28687 of the number of initializers that require the InitializeArray method.
28689 (CheckIndices): Store the Expression in all cases - not the plain value. Also
28690 update the above field where necessary.
28692 (MakeByteBlob): Update accordingly.
28694 (DoEmit): Call EmitStaticInitializers only if the number of initializers is
28697 (EmitDynamicInitializers): Update in accordance with the new optimization.
28699 (ArrayAccess.EmitStoreOpcode): Include char type along with short and ushort - the
28700 same OpCode applies.
28702 * cs-parser.jay : Fix some glaring errors I introduced.
28704 2002-01-01 Ravi Pratap <ravi@ximian.com>
28706 * parameters.cs (AddVariable, AddConstant): Pass in current_local_parameters
28707 so that we can check for name clashes there too.
28709 * typemanager.cs (default_member_attr_type): The attribute that we need to emit
28710 for interface indexers.
28712 * interfaces.cs (Define): Emit the default member attribute.
28714 * expression.cs (MakeByteBlob): Fix extremely trivial bug where the wrong
28715 variable was being referred to while setting the value ;-)
28717 2002-01-01 Miguel de Icaza <miguel@ximian.com>
28719 * expression.cs (MakeByteBlob): Optimize: we do not need to fill
28720 byte-by-byte information when we know the data is zero.
28722 Make the block always a multiple of 4, because
28723 DefineInitializedData has a bug.
28725 * assign.cs: Fix, we should assign from the temporary, not from
28728 * expression.cs (MakeByteBlob): Fix my incorrect code.
28730 2001-12-31 Miguel de Icaza <miguel@ximian.com>
28732 * typemanager.cs (EnumToUnderlying): This function is used to get
28733 the underlying type from an enumeration, because it does not
28736 * constant.cs: Use the I4_S form for values between -128 and 127.
28738 * statement.cs (Block.LookupLabel): Looks up a label.
28739 (Block): Drop support for labeled blocks.
28741 (LabeledStatement): New kind of statement that represents a label
28744 (Goto): Finally implement this bad boy.
28746 * cs-parser.jay: Update to reflect new mechanism to implement
28749 2001-12-30 Miguel de Icaza <miguel@ximian.com>
28751 * codegen.cs (EmitContext.This): a codegen property that keeps the
28752 a single instance of this instead of creating many different this
28755 * delegate.cs (Delegate.DoResolve): Update to use the property;
28757 * ecore.cs (SimpleName.SimpleNameResolve): Ditto
28759 * expression.cs (BaseAccess.DoResolve): Ditto.
28761 2001-12-29 Ravi Pratap <ravi@ximian.com>
28763 * typemanager.cs (methodimpl_attr_type): Add to hold the type
28764 corresponding to System.Runtime.CompilerServices.MethodImplAttribute.
28766 (InitCoreTypes): Update accordingly.
28768 * attribute.cs (Resolve): Remember if the attribute is a MethodImplAttribute
28769 so we can quickly store the state.
28771 (ApplyAttributes): Set the correct implementation flags
28772 for InternalCall methods.
28774 2001-12-29 Miguel de Icaza <miguel@ximian.com>
28776 * expression.cs (EmitCall): if a method is not virtual, then do
28777 not use callvirt on it.
28779 (ArrayAccess.EmitAssign): storing non-builtin value types (ie,
28780 user defined stuff) requires the use of stobj, which takes an
28781 address on the stack instead of an array and an index. So emit
28782 the Ldelema operation for it.
28784 (EmitStoreOpcode): Use stobj for valuetypes.
28786 (UnaryMutator.EmitCode): Use the right 1 value depending on
28787 whether we are dealing with int64/uint64, float or doubles.
28789 * class.cs (TypeContainer.AddConstructor): Fix the logic to define
28790 constructors that I implemented last night.
28792 (Constructor.IsDefault): Fix to work properly for static
28795 * cs-parser.jay (CheckDef): report method signature errors.
28796 Update error number 103 to be 132.
28798 * decl.cs: New AdditionResult enumeration value: MethodExists.
28799 Although we do this check for methods later on in the semantic
28800 analysis, catching repeated default constructors is so easy that
28801 we catch these here.
28803 * expression.cs (Binary.DoNumericPromotions): Fix the uint64 type
28806 (ParameterReference.EmitAssign, Emit): handle
28809 (ArrayAccess.EmitLoadOpcode): Handle bool type here.
28810 (ArrayAccess.EmitStoreOpcode): ditto.
28812 * cs-tokenizer.cs (is_punct): Eliminated empty computation.
28814 * expression.cs (MakeByteBlob): Complete all the missing types
28815 (uint, short, ushort, byte, sbyte)
28817 * class.cs: Only init instance field initializers on instance
28820 Rename `constructors' to instance_constructors.
28822 (TypeContainer.AddConstructor): Only add constructors to the list
28823 if it is not static.
28825 Make sure that we handle default_static_constructor independently
28826 everywhere where we handle instance_constructors
28828 2001-12-28 Miguel de Icaza <miguel@ximian.com>
28830 * class.cs: Do not lookup or create a base initializer for a
28831 static constructor.
28833 (ConstructorInitializer.Resolve): use the proper type to lookup
28836 * cs-parser.jay: Report error 1585 (modifiers between type and name).
28838 * enum.cs, interface.cs: Remove CloseType, this is taken care by
28841 * decl.cs: CloseType is now an virtual method, the default
28842 implementation just closes this type.
28844 2001-12-28 Ravi Pratap <ravi@ximian.com>
28846 * attribute.cs (DefinePInvokeMethod): Set the implementation flags
28847 to PreserveSig by default. Also emit HideBySig on such methods.
28849 Basically, set the defaults to standard values.
28851 * expression.cs (Invocation.BetterFunction): We need to make sure that for each
28852 argument, if candidate is better, it can't be worse than the best !
28854 (Invocation): Re-write bits to differentiate between methods being
28855 applicable in their expanded form and their normal form - for params
28858 Get rid of use_standard everywhere as only standard conversions are allowed
28859 in overload resolution.
28861 More spec conformance.
28863 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28865 * driver.cs: Add --timestamp, to see where the compiler spends
28868 * ecore.cs (SimpleName.DoResolve): Do not create an implicit
28869 `this' in static code.
28871 (SimpleName.DoResolve): Implement in terms of a helper function
28872 that allows static-references to be passed upstream to
28875 (Expression.ResolveWithSimpleName): Resolve specially simple
28876 names when called by MemberAccess to implement the special
28879 (Expression.ImplicitReferenceConversion): Handle conversions from
28880 Null to reference types before others, as Null's type is
28883 * expression.cs (Invocation.EmitCall): Handle the special case of
28884 calling methods declared on a reference type from a ValueType
28885 (Base classes System.Object and System.Enum)
28887 (MemberAccess.Resolve): Only perform lookups on Enumerations if
28888 the left hand side is a TypeExpr, not on every enumeration.
28890 (Binary.Resolve): If types are reference types, then do a cast to
28891 object on operators != and == of both arguments.
28893 * typemanager.cs (FindMembers): Extract instance and static
28894 members if requested.
28896 * interface.cs (PopulateProperty): Use void_type instead of null
28897 as the return type for the setter method.
28899 (PopulateIndexer): ditto.
28901 2001-12-27 Ravi Pratap <ravi@ximian.com>
28903 * support.cs (ReflectionParameters): Fix minor bug where we
28904 were examining the wrong parameter for the ParamArray attribute.
28906 Cope with requests for the type of the parameter at position
28907 greater than the params parameter's. We now return the element
28908 type of the params array as that makes more sense.
28910 * expression.cs (Invocation.IsParamsMethodApplicable): Update
28911 accordingly as we no longer have to extract the element type
28914 (Invocation.OverloadResolve): Update.
28916 2001-12-27 Miguel de Icaza <miguel@ximian.com>
28918 * statement.cs (Foreach.GetEnumeratorFilter): Do not compare
28919 against IEnumerator, test whether the return value is a descendant
28920 of the IEnumerator interface.
28922 * class.cs (Indexer.Define): Use an auxiliary method to implement
28923 the other bits of the method definition. Begin support for
28924 explicit interface implementation.
28926 (Property.DefineMethod): Use TypeManager.void_type instead of null
28927 for an empty return value.
28929 2001-12-26 Miguel de Icaza <miguel@ximian.com>
28931 * expression.cs (MemberAccess.ResolveMemberAccess): if we are
28932 dealing with a FieldExpr which is composed of a FieldBuilder, in
28933 the code path we did extract the constant, but we should have
28934 obtained the underlying value to be able to cast it (otherwise we
28935 end up in an infinite loop, this is what Ravi was running into).
28937 (ArrayCreation.UpdateIndices): Arrays might be empty.
28939 (MemberAccess.ResolveMemberAccess): Add support for section
28940 14.5.4.1 that deals with the special case of E.I when E is a type
28941 and something else, that I can be a reference to a static member.
28943 (ArrayCreation.MakeByteBlob): It is not an error to not be able to
28944 handle a particular array type to create byte blobs, it is just
28945 something we dont generate byteblobs for.
28947 * cs-tokenizer.cs (get_cmd_arg): Ignore \r in commands and
28950 * location.cs (Push): remove the key from the hashtable that we
28951 are about to add. This happens for empty files.
28953 * driver.cs: Dispose files after we have parsed them.
28955 (tokenize): new function that only runs the tokenizer on its
28956 input, for speed testing.
28958 2001-12-26 Ravi Pratap <ravi@ximian.com>
28960 * class.cs (Event.Define): Define the private field only if there
28961 are no accessors defined.
28963 * expression.cs (ResolveMemberAccess): If there is no associated
28964 field with the event, that means we have an event defined with its
28965 own accessors and we should flag error cs0070 since transforming
28966 ourselves into a field is not valid in that case.
28968 * ecore.cs (SimpleName.DoResolve): Same as above.
28970 * attribute.cs (DefinePInvokeMethod): Set the default calling convention
28971 and charset to sane values.
28973 2001-12-25 Ravi Pratap <ravi@ximian.com>
28975 * assign.cs (DoResolve): Perform check on events only if they
28976 are being accessed outside the declaring type.
28978 * cs-parser.jay (event_declarations): Update rules to correctly
28979 set the type of the implicit parameter etc.
28981 (add_accessor, remove_accessor): Set current local parameters.
28983 * expression.cs (Binary): For delegate addition and subtraction,
28984 cast the return value from the method into the appropriate delegate
28987 2001-12-24 Ravi Pratap <ravi@ximian.com>
28989 * typemanager.cs (RegisterDelegateData, GetDelegateData): Get rid
28990 of these as the workaround is unnecessary.
28992 * delegate.cs (NewDelegate.DoResolve): Get rid of bits which registered
28993 delegate data - none of that is needed at all.
28995 Re-write bits to extract the instance expression and the delegate method
28998 * expression.cs (Binary.ResolveOperator): Handle the '-' binary operator
29001 * attribute.cs (ApplyAttributes): New method to take care of common tasks
29002 of attaching attributes instead of duplicating code everywhere.
29004 * everywhere : Update code to do attribute emission using the above method.
29006 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29008 * expression.cs (IsParamsMethodApplicable): if there are not
29009 parameters, return immediately.
29011 * ecore.cs: The 0 literal can be implicity converted to an enum
29014 (SimpleName.DoResolve): First lookup the type, then lookup the
29017 (FieldExpr.Emit): If the InstanceExpression is a ValueType, we
29018 want to get its address. If the InstanceExpression is not
29019 addressable, store the result in a temporary variable, then get
29022 * codegen.cs: Only display 219 errors on warning level or above.
29024 * expression.cs (ArrayAccess): Make it implement the
29025 IMemoryLocation interface.
29027 (Binary.DoResolve): handle the operator == (object a, object b)
29028 and operator != (object a, object b) without incurring into a
29029 BoxedCast (because 5 != o should never be performed).
29031 Handle binary enumerator operators.
29033 (EmitLoadOpcode): Use Ldelema if the object we are loading is a
29034 value type, otherwise use Ldelem_ref.
29036 Use precomputed names;
29038 (AddressOf): Implement address of
29040 * cs-parser.jay (labeled_statement): Fix recursive block
29041 addition by reworking the production.
29043 * expression.cs (New.DoEmit): New has a special case:
29045 If we are dealing with a ValueType, we have a few
29046 situations to deal with:
29048 * The target of New is a ValueType variable, that is
29049 easy, we just pass this as the variable reference
29051 * The target of New is being passed as an argument,
29052 to a boxing operation or a function that takes a
29055 In this case, we need to create a temporary variable
29056 that is the argument of New.
29059 2001-12-23 Ravi Pratap <ravi@ximian.com>
29061 * rootcontext.cs (LookupType): Check that current_type is not null before
29062 going about looking at nested types.
29064 * ecore.cs (EventExpr.EmitAddOrRemove): Rename from EmitAssign as we do
29065 not implement the IAssignMethod interface any more.
29067 * expression.cs (MemberAccess.ResolveMemberAccess): Handle EventExprs specially
29068 where we tranform them into FieldExprs if they are being resolved from within
29069 the declaring type.
29071 * ecore.cs (SimpleName.DoResolve): Do the same here.
29073 * assign.cs (DoResolve, Emit): Clean up code considerably.
29075 * ../errors/bug10.cs : Add.
29077 * ../errors/cs0070.cs : Add.
29079 * typemanager.cs : Use PtrHashtable for Delegate data hashtable etc.
29081 * assign.cs : Get rid of EventIsLocal everywhere.
29083 2001-12-23 Miguel de Icaza <miguel@ximian.com>
29085 * ecore.cs (ConvertIntLiteral): finished the implementation.
29087 * statement.cs (SwitchLabel): Convert the value we are using as a
29088 key before looking up the table.
29090 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29092 * codegen.cs (EmitTopBlock): Require a Location argument now.
29094 * cs-parser.jay (constructor_declarator): We need to setup
29095 current_local_parameters before we parse the
29096 opt_constructor_initializer, to allow the variables to be bound
29097 to the constructor arguments.
29099 * rootcontext.cs (LookupType): First lookup nested classes in our
29100 class and our parents before we go looking outside our class.
29102 * expression.cs (ConstantFold): Extract/debox the values at the
29105 * rootcontext.cs (EmitCode): Resolve the constants first before we
29106 resolve the types. This is not really needed, but it helps debugging.
29108 * statement.cs: report location.
29110 * cs-parser.jay: pass location to throw statement.
29112 * driver.cs: Small bug fix.
29114 * report.cs: Updated format to be 4-zero filled digits.
29116 2001-12-22 Ravi Pratap <ravi@ximian.com>
29118 * expression.cs (CheckIndices): Fix minor bug where the wrong
29119 variable was being referred to ;-)
29121 (DoEmit): Do not call EmitStaticInitializers when the
29122 underlying type is System.Object.
29124 2001-12-21 Ravi Pratap <ravi@ximian.com>
29126 * ecore.cs (EventExpr.Resolve): Implement to correctly set the type
29127 and do the usual workaround for SRE.
29129 * class.cs (MyEventBuilder.EventType): New member to get at the type
29130 of the event, quickly.
29132 * expression.cs (Binary.ResolveOperator): Handle delegate addition.
29134 * assign.cs (Assign.DoResolve): Handle the case when the target
29135 is an EventExpr and perform the necessary checks.
29137 * ecore.cs (EventExpr.EmitAssign): Implement the IAssignMethod
29140 (SimpleName.MemberStaticCheck): Include check for EventExpr.
29142 (EventExpr): Set the type in the constructor itself since we
29143 are meant to be born fully resolved.
29145 (EventExpr.Define): Revert code I wrote earlier.
29147 * delegate.cs (NewDelegate.Resolve): Handle the case when the MethodGroup's
29148 instance expression is null. The instance expression is a This in that case
29149 or a null, depending on whether it is a static method or not.
29151 Also flag an error if the reference to a method is ambiguous i.e the MethodGroupExpr
29152 refers to more than one method.
29154 * assign.cs (DoResolve): Check whether the event belongs to the same Type container
29155 and accordingly flag errors.
29157 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29159 * statement.cs (Throw.Emit): Add support for re-throwing exceptions.
29161 2001-12-22 Miguel de Icaza <miguel@ximian.com>
29163 * location.cs (ToString): Provide useful rutine.
29165 2001-12-21 Miguel de Icaza <miguel@ximian.com>
29167 * ecore.cs (Expression.ConvertIntLiteral): Do not return Constant
29168 objects, return the actual integral boxed.
29170 * statement.cs (SwitchLabel): define an ILLabel for each
29173 (Switch.CheckSwitch): If the value is a Literal, extract
29174 the underlying literal.
29176 Also in the unused hashtable we had, add the SwitchLabel so we can
29177 quickly look this value up.
29179 * constant.cs: Implement a bunch of new constants. Rewrite
29180 Literal based on this. Made changes everywhere to adapt to this.
29182 * expression.cs (Expression.MakeByteBlob): Optimize routine by
29183 dereferencing array only once, and also copes with enumrations.
29185 bytes are two bytes wide, not one.
29187 (Cast): Perform constant conversions.
29189 * ecore.cs (TryImplicitIntConversion): Return literals instead of
29190 wrappers to the literals here.
29192 * expression.cs (DoNumericPromotions): long literals can converted
29193 to ulong implicity (this is taken care of elsewhere, but I was
29194 missing this spot).
29196 * ecore.cs (Expression.Literalize): Make the return type Literal,
29197 to improve type checking.
29199 * rootcontext.cs: Lookup for nested classes in our class hierarchy.
29201 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29203 * literal.cs: Revert code from ravi that checked the bounds. The
29204 bounds are sane by the definition of the type itself.
29206 * typemanager.cs: Fix implementation of ImplementsInterface. We
29207 need to actually look up in our parent hierarchy for interfaces
29210 * const.cs: Use the underlying type for enumerations
29212 * delegate.cs: Compute the basename for the delegate creation,
29213 that should fix the delegate test case, and restore the correct
29214 Type Lookup semantics in rootcontext
29216 * rootcontext.cs: Revert Ravi's last patch. The correct way of
29217 referencing a nested type with the Reflection API is using the "+"
29220 * cs-parser.jay: Do not require EOF token at the end.
29222 2001-12-20 Ravi Pratap <ravi@ximian.com>
29224 * rootcontext.cs (LookupType): Concatenate type names with
29225 a '.' instead of a '+' The test suite passes again.
29227 * enum.cs (Enum.DefineEnum): Set RTSpecialName on the 'value__'
29228 field of the enumeration.
29230 * expression.cs (MemberAccess.ResolveMemberAccess): Add support for
29231 the case when the member is an EventExpr.
29233 * ecore.cs (EventExpr.InstanceExpression): Every event which is not
29234 static has an associated instance expression.
29236 * typemanager.cs (RegisterEvent): The usual workaround, now for events.
29238 (GetAddMethod, GetRemoveMethod): Workarounds, as usual.
29240 * class.cs (Event.Define): Register event and perform appropriate checks
29243 We define the Add and Remove methods even if the use provides none because
29244 in that case, we provide default implementations ourselves.
29246 Define a private field of the type of the event. This is done by the CSC compiler
29247 and we should be doing it too ;-)
29249 * typemanager.cs (delegate_combine_delegate_delegate, delegate_remove_delegate_delegate):
29250 More methods we use in code we generate.
29252 (multicast_delegate_type, delegate_type): Two separate types since the distinction
29255 (InitCoreTypes): Update accordingly for the above.
29257 * class.cs (Event.Emit): Generate code for default accessors that we provide
29259 (EmitDefaultMethod): Do the job in the above.
29261 * delegate.cs (DefineDelegate): Use TypeManager.multicast_delegate_type in the
29264 2001-12-20 Miguel de Icaza <miguel@ximian.com>
29266 * class.cs (Indexer.Define): Fix bug, we were setting both Get/Set
29267 builders even if we were missing one.
29269 * interface.cs, class.cs, enum.cs: When calling DefineNestedType
29270 pass the Basename as our class name instead of the Name. The
29271 basename will be correctly composed for us.
29273 * parameter.cs (Paramters): Now takes a Location argument.
29275 * decl.cs (DeclSpace.LookupType): Removed convenience function and
29276 make all the code call directly LookupType in RootContext and take
29277 this chance to pass the Location information everywhere.
29279 * Everywhere: pass Location information.
29281 2001-12-19 Miguel de Icaza <miguel@ximian.com>
29283 * class.cs (Constructor.Define): Updated way of detecting the
29284 length of the parameters.
29286 (TypeContainer.DefineType): Use basename as the type name for
29289 (TypeContainer.Define): Do not recursively define types here, as
29290 definition is taken care in order by the RootContext.
29292 * tree.cs: Keep track of namespaces in a per-file basis.
29294 * parameter.cs (Parameter.ComputeSignature): Update to use
29297 (Parameters.GetSignature): ditto.
29299 * interface.cs (InterfaceMethod.GetSignature): Take a DeclSpace
29300 instead of a TypeContainer.
29302 (Interface.SemanticAnalysis): Use `this' instead of our parent to
29303 resolve names. Because we need to be resolve in our context, not
29306 * driver.cs: Implement response files.
29308 * class.cs (TypeContainer.DefineType): If we are defined, do not
29309 redefine ourselves.
29311 (Event.Emit): Emit the code for add/remove handlers.
29312 (Event.Define): Save the MethodBuilders for add/remove.
29314 * typemanager.cs: Use pair here too.
29316 * cs-parser.jay: Replaced use of DictionaryEntry for Pair because
29317 DictionaryEntry requires the first argument to be non-null.
29319 (enum_declaration): Compute full name for registering the
29322 (delegate_declaration): Instead of using
29323 formal_parameter_list, use opt_formal_parameter_list as the list
29326 * cs-tokenizer.cs (PropertyParsing): renamed from `properties'
29327 (EventParsing): New property that controls whether `add' and
29328 `remove' are returned as tokens or identifiers (for events);
29330 2001-12-19 Ravi Pratap <ravi@ximian.com>
29332 * class.cs (Event.Define): Revamp use of EventBuilder completely. We now
29333 use MyEventBuilder only and let it wrap the real builder for us.
29335 (MyEventBuilder): Revamp constructor etc.
29337 Implement all operations that we perform on EventBuilder in precisely the same
29340 (FindMembers): Update to use the EventBuilder member.
29342 (Event.Emit): Update accordingly.
29344 2001-12-18 Ravi Pratap <ravi@ximian.com>
29346 * class.cs (MyEventBuilder.Set*): Chain to the underlying builder
29347 by calling the appropriate methods.
29349 (GetCustomAttributes): Make stubs as they cannot possibly do anything
29352 (Event.Emit): Use MyEventBuilder everywhere - even to set attributes.
29354 2001-12-17 Ravi Pratap <ravi@ximian.com>
29356 * delegate.cs (Delegate.Populate): Check that the return type
29357 and various parameters types are indeed accessible.
29359 * class.cs (Constructor.Define): Same here.
29361 (Field.Define): Ditto.
29363 (Event.Define): Ditto.
29365 (Operator.Define): Check that the underlying Method defined itself
29366 correctly - so it's MethodBuilder should not be null.
29368 * delegate.cs (DelegateInvocation.DoResolve): Bale out if the type of the Instance
29369 expression happens to be null.
29371 * class.cs (MyEventBuilder): Workaround for SRE lameness. Implement various abstract
29372 members but as of now we don't seem to be able to do anything really useful with it.
29374 (FindMembers): Handle events separately by returning the MyEventBuilder of the event,
29375 not the EventBuilder.
29377 2001-12-18 Miguel de Icaza <miguel@ximian.com>
29379 * cs-tokenizer.cs: Add support for defines.
29380 Add support for #if, #elif, #else, #endif
29382 (eval_var): evaluates a variable.
29383 (eval): stubbed for evaluating functions.
29385 * cs-parser.jay: Pass the defines information
29387 * driver.cs: Add --define command line option.
29389 * decl.cs: Move MemberCore here.
29391 Make it the base class for DeclSpace. This allows us to catch and
29392 report 108 and 109 for everything now.
29394 * class.cs (TypeContainer.Define): Extract all the members
29395 before populating and emit the warning 108 (new keyword required
29396 to override) instead of having each member implement this.
29398 (MemberCore.Define): New abstract method, we will be using this in
29399 the warning reporting engine in Populate.
29401 (Operator.Define): Adjust to new MemberCore protocol.
29403 * const.cs (Const): This does not derive from Expression, it is a
29404 temporary object we use to create fields, it is a MemberCore.
29406 * class.cs (Method.Define): Allow the entry point to be in a
29409 * driver.cs: Rewrite the argument handler to clean it up a bit.
29411 * rootcontext.cs: Made it just an auxiliary namespace feature by
29412 making everything static.
29414 * driver.cs: Adapt code to use RootContext type name instead of
29417 * delegate.cs: Remove RootContext argument.
29419 * class.cs: (Struct, TypeContainer, Class): Remove RootContext
29422 * class.cs (Event.Define): The lookup can fail.
29424 * cs-tokenizer.cs: Begin implementation of pre-procesor.
29426 * expression.cs: Resolve the this instance before invoking the code.
29428 2001-12-17 Miguel de Icaza <miguel@ximian.com>
29430 * cs-parser.jay: Add a production in element_access that allows
29431 the thing to become a "type" reference. This way we can parse
29432 things like "(string [])" as a type.
29434 Note that this still does not handle the more complex rules of
29438 * delegate.cs (Delegate.Populate): Register the delegage constructor builder here.
29440 * ecore.cs: (CopyNewMethods): new utility function used to
29441 assemble the list of methods from running FindMembers.
29443 (MemberLookup): Rework FindMembers so that
29445 2001-12-16 Miguel de Icaza <miguel@ximian.com>
29447 * class.cs (TypeContainer): Remove Delegates who fail to be
29450 * delegate.cs (Populate): Verify that we dont get null return
29451 values. TODO: Check for AsAccessible.
29453 * cs-parser.jay: Use basename to emit error 574 (destructor should
29454 have the same name as container class), not the full name.
29456 * cs-tokenizer.cs (adjust_int): Fit the integer in the best
29457 possible representation.
29459 Also implements integer type suffixes U and L.
29461 2001-12-15 Miguel de Icaza <miguel@ximian.com>
29463 * expression.cs (ArrayCreation.DoResolve): We need to do the
29464 argument resolution *always*.
29466 * decl.cs: Make this hold the namespace. Hold the root context as
29468 (LookupType): Move here.
29470 * enum.cs, class.cs, interface.cs: Adapt to new hierarchy.
29472 * location.cs (Row, Name): Fixed the code, it was always returning
29473 references to the first file.
29475 * interface.cs: Register properties defined through interfaces.
29477 * driver.cs: Add support for globbing on the command line
29479 * class.cs (Field): Make it derive from MemberCore as well.
29482 2001-12-15 Ravi Pratap <ravi@ximian.com>
29484 * class.cs (Event::Define): Check that the type of the event is a delegate
29485 type else flag error #66.
29487 Also, re-use TypeContainer.MethodModifiersValid here too as the rules are the
29490 * attribute.cs (DefinePInvokeMethod): Handle named arguments and process
29491 values of EntryPoint, CharSet etc etc.
29493 Pass in the values to TypeBuilder.DefinePInvokeMethod; determine Type etc neatly.
29495 * class.cs (FindMembers): If a method is in transit, its MethodBuilder will
29496 be null and we should ignore this. I am not sure if this is really clean. Apparently,
29497 there's no way of avoiding hitting this because the call is coming from SimpleName.DoResolve,
29498 which needs this to do its work.
29500 * ../errors/cs0066.cs : Add.
29502 2001-12-14 Miguel de Icaza <miguel@ximian.com>
29504 * typemanager.cs: (GetPropertyGetter, GetPropertyGetter): New
29507 * class.cs: (MethodSignature.MethodSignature): Removed hack that
29508 clears out the parameters field.
29509 (MemberSignatureCompare): Cleanup
29511 (MemberCore): New base class used to share code between MethodCore
29514 (RegisterRequiredImplementations) BindingFlags.Public requires
29515 either BindingFlags.Instace or Static. Use instance here.
29517 (Property): Refactored code to cope better with the full spec.
29519 * parameter.cs (GetParameterInfo): Return an empty array instead
29522 * class.cs (Property): Abstract or extern properties have no bodies.
29524 * parameter.cs (GetParameterInfo): return a zero-sized array.
29526 * class.cs (TypeContainer.MethodModifiersValid): Move all the
29527 method modifier validation to the typecontainer so we can reuse
29528 this on properties.
29530 (MethodCore.ParameterTypes): return an empty sized array of types.
29532 (Property.Define): Test property modifier validity.
29534 Add tests for sealed/override too.
29536 (Method.Emit): abstract or extern methods have no bodies.
29538 2001-12-14 Ravi Pratap <ravi@ximian.com>
29540 * class.cs (Method.IsPInvoke): Get rid of it as it is an expensive
29543 (Method::Define, ::Emit): Modify accordingly.
29545 * expression.cs (Invocation::OverloadResolve): Handle error # 121.
29547 (ArrayCreation::MakeByteBlob): Handle floats and doubles.
29549 * makefile: Pass in /unsafe.
29551 2001-12-13 Miguel de Icaza <miguel@ximian.com>
29553 * class.cs (MakeKey): Kill routine.
29555 * class.cs (TypeContainer.Define): Correctly define explicit
29556 method implementations (they require the full interface name plus
29559 * typemanager.cs: Deply the PtrHashtable here and stop using the
29560 lame keys. Things work so much better.
29562 This of course broke everyone who depended on `RegisterMethod' to
29563 do the `test for existance' test. This has to be done elsewhere.
29565 * support.cs (PtrHashtable): A hashtable that avoid comparing with
29566 the object stupid Equals method (because, that like fails all over
29567 the place). We still do not use it.
29569 * class.cs (TypeContainer.SetRequiredInterface,
29570 TypeContainer.RequireMethods): Killed these two routines and moved
29571 all the functionality to RegisterRequiredImplementations.
29573 (TypeContainer.RegisterRequiredImplementations): This routine now
29574 registers all the implementations required in an array for the
29575 interfaces and abstract methods. We use an array of structures
29576 which can be computed ahead of time to reduce memory usage and we
29577 also assume that lookups are cheap as most classes will not
29578 implement too many interfaces.
29580 We also avoid creating too many MethodSignatures.
29582 (TypeContainer.IsInterfaceMethod): Update and optionally does not
29583 clear the "pending" bit if we find that there are problems with
29586 (TypeContainer.VerifyPendingMethods): Update to report errors of
29587 methods that look like implementations but are not.
29589 (TypeContainer.Define): Add support for explicit interface method
29592 2001-12-12 Miguel de Icaza <miguel@ximian.com>
29594 * typemanager.cs: Keep track of the parameters here instead of
29595 being a feature of the TypeContainer.
29597 * class.cs: Drop the registration of parameters here, as
29598 InterfaceMethods are also interface declarations.
29600 * delegate.cs: Register methods with the TypeManager not only with
29601 the TypeContainer. This code was buggy.
29603 * interface.cs: Full registation here.
29605 2001-12-11 Miguel de Icaza <miguel@ximian.com>
29607 * expression.cs: Remove reducer for binary expressions, it can not
29610 * const.cs: Put here the code that used to go into constant.cs
29612 * constant.cs: Put here the code for constants, this is a new base
29613 class for Literals.
29615 * literal.cs: Make Literal derive from Constant.
29617 2001-12-09 Miguel de Icaza <miguel@ximian.com>
29619 * statement.cs (Return.Emit): Report error 157 if the user
29620 attempts to return from a finally block.
29622 (Return.Emit): Instead of emitting a return, jump to the end of
29625 * codegen.cs (EmitContext): ReturnValue, ReturnLabel: new
29626 LocalBuilder to store the result of the function. ReturnLabel is
29627 the target where we jump.
29630 2001-12-09 Radek Doulik <rodo@ximian.com>
29632 * cs-parser.jay: remember alias in current namespace
29634 * ecore.cs (SimpleName::DoResolve): use aliases for types or
29637 * class.cs (LookupAlias): lookup alias in my_namespace
29639 * namespace.cs (UsingAlias): add alias, namespace_or_type pair to
29641 (LookupAlias): lookup alias in this and if needed in parent
29644 2001-12-08 Miguel de Icaza <miguel@ximian.com>
29648 * rootcontext.cs: (ModuleBuilder) Made static, first step into
29649 making things static. I need this to avoid passing the
29650 TypeContainer when calling ParameterType.
29652 * support.cs (InternalParameters.ParameterType): Remove ugly hack
29653 that did string manipulation to compute the type and then call
29654 GetType. Use Parameter.ParameterType instead.
29656 * cs-tokenizer.cs: Consume the suffix for floating values.
29658 * expression.cs (ParameterReference): figure out whether this is a
29659 reference parameter or not. Kill an extra variable by computing
29660 the arg_idx during emission.
29662 * parameter.cs (Parameters.GetParameterInfo): New overloaded
29663 function that returns whether a parameter is an out/ref value or not.
29665 (Parameter.ParameterType): The type of the parameter (base,
29666 without ref/out applied).
29668 (Parameter.Resolve): Perform resolution here.
29669 (Parameter.ExternalType): The full type (with ref/out applied).
29671 * statement.cs (Using.Emit, Using.EmitExpression): Implement
29672 support for expressions on the using statement.
29674 2001-12-07 Miguel de Icaza <miguel@ximian.com>
29676 * statement.cs (Using.EmitLocalVariableDecls): Split the
29677 localvariable handling of the using statement.
29679 (Block.EmitMeta): Keep track of variable count across blocks. We
29680 were reusing slots on separate branches of blocks.
29682 (Try.Emit): Emit the general code block, we were not emitting it.
29684 Check the type of the declaration to be an IDisposable or
29685 something that can be implicity converted to it.
29687 Emit conversions if required.
29689 * ecore.cs (EmptyExpression): New utility class.
29690 (Expression.ImplicitConversionExists): New utility function.
29692 2001-12-06 Miguel de Icaza <miguel@ximian.com>
29694 * statement.cs (Using): Implement.
29696 * expression.cs (LocalVariableReference): Support read only variables.
29698 * statement.cs: Remove the explicit emit for the Leave opcode.
29699 (VariableInfo): Add a readonly field.
29701 2001-12-05 Miguel de Icaza <miguel@ximian.com>
29703 * ecore.cs (ConvCast): new class used to encapsulate the various
29704 explicit integer conversions that works in both checked and
29705 unchecked contexts.
29707 (Expression.ConvertNumericExplicit): Use new ConvCast class to
29708 properly generate the overflow opcodes.
29710 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29712 * statement.cs: The correct type for the EmptyExpression is the
29713 element_type, not the variable type. Ravi pointed this out.
29715 2001-12-04 Ravi Pratap <ravi@ximian.com>
29717 * class.cs (Method::Define): Handle PInvoke methods specially
29718 by using DefinePInvokeMethod instead of the usual one.
29720 * attribute.cs (DefinePInvokeMethod): Implement as this is what is called
29721 above to do the task of extracting information and defining the method.
29723 2001-12-04 Ravi Pratap <ravi@ximian.com>
29725 * expression.cs (ArrayCreation::EmitStaticInitializers): Get rid
29726 of the condition for string type.
29728 (Emit): Move that here.
29730 (ArrayCreation::CheckIndices): Keep string literals in their expression
29733 (EmitDynamicInitializers): Handle strings appropriately.
29735 2001-12-04 Miguel de Icaza <miguel@ximian.com>
29737 * codegen.cs (EmitContext): Replace multiple variables with a
29738 single pointer to the current Switch statement.
29740 * statement.cs (GotoDefault, Switch): Adjust to cleaned up
29743 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29747 * statement.cs (GotoDefault), cs-parser.jay: Implement `goto
29750 (Foreach.Emit): Foreach on arrays was not setting
29751 up the loop variables (for break/continue).
29753 (GotoCase): Semi-implented.
29755 2001-12-03 Ravi Pratap <ravi@ximian.com>
29757 * attribute.cs (CheckAttribute): Handle system attributes by using
29758 Attribute.GetAttributes to examine information we need.
29760 (GetValidPlaces): Same here.
29762 * class.cs (Method::Define): Catch invalid use of extern and abstract together.
29764 * typemanager.cs (dllimport_type): Core type for System.DllImportAttribute.
29766 * class.cs (Method.IsPinvoke): Used to determine if we are a PInvoke method.
29768 (Method::Define): Set appropriate flags if we have a DllImport attribute.
29770 (Method::Emit): Handle the case when we are a PInvoke method.
29772 2001-12-03 Miguel de Icaza <miguel@ximian.com>
29774 * expression.cs: Use ResolveWithSimpleName on compound names.
29776 2001-12-02 Ravi Pratap <ravi@ximian.com>
29778 * constant.cs (EmitConstant): Make sure we resolve the associated expression
29779 before trying to reduce it.
29781 * typemanager.cs (RegisterConstant, LookupConstant): Implement.
29783 * constant.cs (LookupConstantValue): Implement.
29785 (EmitConstant): Use the above in emitting the constant.
29787 * expression.cs (MemberAccess::ResolveMemberAccess): Handle constants
29788 that are user-defined by doing a LookupConstantValue on them.
29790 (SimpleName::DoResolve): When we have a FieldExpr, cope with constants
29793 2001-11-29 Miguel de Icaza <miguel@ximian.com>
29795 * expression.cs (BaseAccess, BaseIndexer): Also split this out.
29797 (BaseAccess.DoResolve): Implement.
29799 (MemberAccess.DoResolve): Split this routine into a
29800 ResolveMemberAccess routine that can be used independently
29802 2001-11-28 Miguel de Icaza <miguel@ximian.com>
29804 * expression.cs (Probe, Is, As): Split Probe in two classes Is and
29805 As that share bits of the implementation. Is returns a boolean,
29806 while As returns the Type that is being probed.
29808 2001-12-01 Ravi Pratap <ravi@ximian.com>
29810 * enum.cs (LookupEnumValue): Re-write various bits, return an object value
29811 instead of a Literal - much easier.
29813 (EnumInTransit): Remove - utterly useless :-)
29815 (Populate): Re-write bits - remove duplicate code etc. The code is much neater now.
29817 * expression.cs (MemberLookup): Cope with user-defined enums when they are in transit.
29819 * enum.cs (LookupEnumValue): Auto-compute next values by going down the dependency
29820 chain when we have no associated expression.
29822 2001-11-30 Ravi Pratap <ravi@ximian.com>
29824 * constant.cs (Define): Use Location while reporting the errror.
29826 Also emit a warning when 'new' is used and there is no inherited
29829 * enum.cs (EnumInTransit): Used to tell if an enum type is in the process of being
29832 (LookupEnumValue): Implement to lookup an enum member's value and define it
29835 (Populate): Re-write accordingly to use the above routine.
29837 2001-11-27 Miguel de Icaza <miguel@ximian.com>
29839 * expression.cs (This): Fix prototype for DoResolveLValue to
29840 override the base class DoResolveLValue.
29842 * cs-parser.cs: Report errors cs574 and cs575 (destructor
29845 * ecore.cs (FieldExpr.EmitAssign): Handle value types specially
29846 (we need to load the address of the field here). This fixes
29849 (FieldExpr.DoResolveLValue): Call the DoResolve
29850 function to initialize the Instance expression.
29852 * statement.cs (Foreach.Emit): Fix the bug where we did not invoke
29853 correctly the GetEnumerator operation on a value type.
29855 * cs-parser.jay: Add more simple parsing error catches.
29857 * statement.cs (Switch): Add support for string switches.
29858 Handle null specially.
29860 * literal.cs (NullLiteral): Make NullLiteral objects singletons.
29862 2001-11-28 Ravi Pratap <ravi@ximian.com>
29864 * cs-parser.jay (local_constant_declaration): Use declare_local_constant.
29866 (declare_local_constant): New helper function.
29868 * statement.cs (AddConstant): Keep a separate record of constants
29870 (IsConstant): Implement to determine if a variable is a constant.
29872 (GetConstantExpression): Implement.
29874 * expression.cs (LocalVariableReference): Handle the case when it is a constant.
29876 * statement.cs (IsVariableDefined): Re-write.
29878 2001-11-27 Ravi Pratap <ravi@ximian.com>
29880 * class.cs (TypeContainer::FindMembers): Look for constants
29881 in the case when we are looking for MemberTypes.Field
29883 * expression.cs (MemberAccess::DoResolve): Check that in the
29884 case we are a FieldExpr and a Literal, we are not being accessed
29885 by an instance reference.
29887 * cs-parser.jay (local_constant_declaration): Implement.
29889 (declaration_statement): Implement for constant declarations.
29891 2001-11-26 Miguel de Icaza <miguel@ximian.com>
29893 * statement.cs (Switch): Catch double defaults.
29895 (Switch): More work on the switch() statement
29896 implementation. It works for integral values now, need to finish
29900 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29902 * ecore.cs (Expression.ConvertIntLiteral): New function to convert
29903 integer literals into other integer literals. To be used by
29906 2001-11-24 Ravi Pratap <ravi@ximian.com>
29908 * expression.cs (ArrayCreation): Get rid of ArrayExprs : we save
29911 (EmitDynamicInitializers): Cope with the above since we extract data
29912 directly from ArrayData now.
29914 (ExpectInitializers): Keep track of whether initializers are mandatory
29917 (Bounds): Make it a hashtable to prevent the same dimension being
29918 recorded for every element in that dimension.
29920 (EmitDynamicInitializers): Fix bug which prevented the Set array method
29923 Also fix bug which was causing the indices to be emitted in the reverse
29926 2001-11-24 Miguel de Icaza <miguel@ximian.com>
29928 * expression.cs (ArrayCreation): Implement the bits that Ravi left
29929 unfinished. They do not work, because the underlying code is
29932 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29934 * cs-parser.jay: Remove bogus fixme.
29936 * statement.cs (Switch, SwitchSection, SwithLabel): Started work
29937 on Switch statement.
29939 2001-11-23 Ravi Pratap <ravi@ximian.com>
29941 * typemanager.cs (IsDelegateType, IsEnumType): Fix logic to determine
29944 * expression.cs (ArrayCreation::CheckIndices): Get rid of the require_constant
29945 parameter. Apparently, any expression is allowed.
29947 (ValidateInitializers): Update accordingly.
29949 (CheckIndices): Fix some tricky bugs thanks to recursion.
29951 * delegate.cs (NewDelegate::DoResolve): Re-write large portions as
29952 I was being completely brain-dead.
29954 (VerifyMethod, VerifyApplicability, VerifyDelegate): Make static
29955 and re-write acordingly.
29957 (DelegateInvocation): Re-write accordingly.
29959 * expression.cs (ArrayCreation::Emit): Handle string initialization separately.
29961 (MakeByteBlob): Handle types more correctly.
29963 * expression.cs (ArrayCreation:Emit): Write preliminary code to do
29964 initialization from expressions but it is incomplete because I am a complete
29967 2001-11-22 Miguel de Icaza <miguel@ximian.com>
29969 * statement.cs (If.Emit): Fix a bug that generated incorrect code
29970 on If. Basically, we have to return `true' (ie, we do return to
29971 our caller) only if both branches of the if return.
29973 * expression.cs (Binary.Emit): LogicalOr and LogicalAnd are
29974 short-circuit operators, handle them as short circuit operators.
29976 (Cast.DoResolve): Resolve type.
29977 (Cast.Cast): Take an expression as the target type.
29979 * cs-parser.jay (cast_expression): Remove old hack that only
29980 allowed a limited set of types to be handled. Now we take a
29981 unary_expression and we resolve to a type during semantic
29984 Use the grammar productions from Rhys to handle casts (this is
29985 not complete like Rhys syntax yet, we fail to handle that corner
29986 case that C# has regarding (-x), but we will get there.
29988 2001-11-22 Ravi Pratap <ravi@ximian.com>
29990 * class.cs (EmitFieldInitializer): Take care of the case when we have a
29991 field which is an array type.
29993 * cs-parser.jay (declare_local_variables): Support array initialization too.
29995 * typemanager.cs (MakeKey): Implement.
29997 (everywhere): Use the above appropriately.
29999 * cs-parser.jay (for_statement): Update for array initialization while
30000 declaring variables.
30002 * ecore.cs : The error message was correct, it's the variable's names that
30003 were misleading ;-) Make the code more readable.
30005 (MemberAccess::DoResolve): Fix the code which handles Enum literals to set
30006 the correct type etc.
30008 (ConvertExplicit): Handle Enum types by examining the underlying type.
30010 2001-11-21 Ravi Pratap <ravi@ximian.com>
30012 * parameter.cs (GetCallingConvention): Always return
30013 CallingConventions.Standard for now.
30015 2001-11-22 Miguel de Icaza <miguel@ximian.com>
30017 * expression.cs (Binary.ResolveOperator): Update the values of `l'
30018 and `r' after calling DoNumericPromotions.
30020 * ecore.cs: Fix error message (the types were in the wrong order).
30022 * statement.cs (Foreach.ProbeCollectionType): Need to pass
30023 BindingFlags.Instance as well
30025 * ecore.cs (Expression.TryImplicitIntConversion): Wrap the result
30026 implicit int literal conversion in an empty cast so that we
30027 propagate the right type upstream.
30029 (UnboxCast): new class used to unbox value types.
30030 (Expression.ConvertExplicit): Add explicit type conversions done
30033 (Expression.ImplicitNumericConversion): Oops, forgot to test for
30034 the target type before applying the implicit LongLiterals to ULong
30037 2001-11-21 Miguel de Icaza <miguel@ximian.com>
30039 * cs-parser.jay (for_statement): Reworked the way For works: now
30040 we declare manually any variables that are introduced in
30041 for_initializer to solve the problem of having out-of-band code
30042 emition (that is what got for broken).
30044 (declaration_statement): Perform the actual variable declaration
30045 that used to be done in local_variable_declaration here.
30047 (local_variable_declaration): Do not declare anything, just pass
30048 the information on a DictionaryEntry
30050 2001-11-20 Ravi Pratap <ravi@ximian.com>
30052 * expression.cs (ArrayCreation::CheckIndices): The story continues :-) Complete
30053 re-write of the logic to now make it recursive.
30055 (UpdateIndices): Re-write accordingly.
30057 Store element data in a separate ArrayData list in the above methods.
30059 (MakeByteBlob): Implement to dump the array data into a byte array.
30061 2001-11-19 Ravi Pratap <ravi@ximian.com>
30063 * expression.cs (ArrayCreation): Factor out some code from ValidateInitializers
30066 * constant.cs (Define): Implement.
30068 (EmitConstant): Re-write fully.
30070 Pass in location info.
30072 * class.cs (Populate, Emit): Call Constant::Define and Constant::EmitConstant
30075 * cs-parser.jay (constant_declarator): Use VariableDeclaration instead of
30076 DictionaryEntry since we need location info too.
30078 (constant_declaration): Update accordingly.
30080 * expression.cs (ArrayCreation): Make ValidateInitializers simpler by factoring
30081 code into another method : UpdateIndices.
30083 2001-11-18 Ravi Pratap <ravi@ximian.com>
30085 * expression.cs (ArrayCreation::ValidateInitializers): Update to perform
30086 some type checking etc.
30088 2001-11-17 Ravi Pratap <ravi@ximian.com>
30090 * expression.cs (ArrayCreation::ValidateInitializers): Implement
30091 bits to provide dimension info if the user skips doing that.
30093 Update second constructor to store the rank correctly.
30095 2001-11-16 Ravi Pratap <ravi@ximian.com>
30097 * expression.cs (ArrayCreation::ValidateInitializers): Poke around
30098 and try to implement.
30100 * ../errors/cs0150.cs : Add.
30102 * ../errors/cs0178.cs : Add.
30104 2001-11-16 Miguel de Icaza <miguel@ximian.com>
30106 * statement.cs: Implement foreach on multi-dimensional arrays.
30108 * parameter.cs (Parameters.GetParameterByName): Also lookup the
30109 name of the params argument.
30111 * expression.cs: Use EmitStoreOpcode to get the right opcode while
30112 initializing the array.
30114 (ArrayAccess.EmitStoreOpcode): move the opcode generation here, so
30115 we can use this elsewhere.
30117 * statement.cs: Finish implementation of foreach for single
30120 * cs-parser.jay: Use an out-of-band stack to pass information
30121 around, I wonder why I need this.
30123 foreach_block: Make the new foreach_block the current_block.
30125 * parameter.cs (Parameters.GetEmptyReadOnlyParameters): New
30126 function used to return a static Parameters structure. Used for
30127 empty parameters, as those are created very frequently.
30129 * cs-parser.jay, class.cs: Use GetEmptyReadOnlyParameters
30131 2001-11-15 Ravi Pratap <ravi@ximian.com>
30133 * interface.cs : Default modifier is private, not public. The
30134 make verify test passes again.
30136 2001-11-15 Ravi Pratap <ravi@ximian.com>
30138 * support.cs (ReflectionParameters): Fix logic to determine
30139 whether the last parameter is a params one. Test 9 passes again.
30141 * delegate.cs (Populate): Register the builders we define with
30142 RegisterParameterForBuilder. Test 19 passes again.
30144 * cs-parser.jay (property_declaration): Reference $6 instead
30145 of $$ to get at the location.
30147 (indexer_declaration): Similar stuff.
30149 (attribute): Ditto.
30151 * class.cs (Property): Register parameters for the Get and Set methods
30152 if they exist. Test 23 passes again.
30154 * expression.cs (ArrayCreation::Emit): Pass null for the method in the
30155 call to EmitArguments as we are sure there aren't any params arguments.
30156 Test 32 passes again.
30158 * suppor.cs (ParameterDesc, ParameterModifier): Fix trivial bug causing
30159 IndexOutOfRangeException.
30161 * class.cs (Property::Define): Register property using TypeManager.RegisterProperty
30162 Test 33 now passes again.
30164 2001-11-15 Miguel de Icaza <miguel@ximian.com>
30166 * cs-parser.jay: Kill horrendous hack ($??? = lexer.Location) that
30167 broke a bunch of things. Will have to come up with a better way
30168 of tracking locations.
30170 * statement.cs: Implemented foreach for single dimension arrays.
30172 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30174 * enum.cs (Enum.Emit): Delay the lookup of loc until we run into
30175 an error. This removes the lookup from the critical path.
30177 * cs-parser.jay: Removed use of temporary_loc, which is completely
30180 2001-11-14 Miguel de Icaza <miguel@ximian.com>
30182 * support.cs (ReflectionParameters.ParameterModifier): Report
30183 whether the argument is a PARAMS argument or not.
30185 * class.cs: Set the attribute `ParamArrayAttribute' on the
30186 parameter argument.
30188 * typemanager.cs: Define param_array_type (ParamArrayAttribute)
30189 and cons_param_array_attribute (ConstructorInfo for
30190 ParamArrayAttribute).,
30192 * codegen.cs: Emit the return using the `Return' statement, that
30193 way we can report the error correctly for missing return values.
30195 * class.cs (Method.Emit): Clean up.
30197 * expression.cs (Argument.Resolve): Take another argument: the
30198 location where this argument is used. Notice that this is not
30199 part of the "Argument" class as to reduce the size of the
30200 structure (we know the approximate location anyways).
30202 Test if the argument is a variable-reference, if not, then
30203 complain with a 206.
30205 (Argument.Emit): Emit addresses of variables.
30207 (Argument.FullDesc): Simplify.
30209 (Invocation.DoResolve): Update for Argument.Resolve.
30211 (ElementAccess.DoResolve): ditto.
30213 * delegate.cs (DelegateInvocation.Emit): Invocation of Invoke
30214 method should be virtual, as this method is always virtual.
30216 (NewDelegate.DoResolve): Update for Argument.Resolve.
30218 * class.cs (ConstructorInitializer.DoResolve): ditto.
30220 * attribute.cs (Attribute.Resolve): ditto.
30222 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30224 * statement.cs (Foreach.Emit): Use EmitAssign instead of Store.
30226 * expression.cs (ParameterReference): Drop IStackStorage and implement
30227 IAssignMethod instead.
30229 (LocalVariableReference): ditto.
30231 * ecore.cs (FieldExpr): Drop IStackStorage and implement
30232 IAssignMethod instead.
30234 2001-11-13 Miguel de Icaza <miguel@ximian.com>
30236 * parameter.cs, expression.cs, class.cs, ecore.cs: Made all
30237 enumerations that are used in heavily used structures derive from
30238 byte in a laughable and pathetic attempt to reduce memory usage.
30239 This is the kind of pre-optimzations that you should not do at
30240 home without adult supervision.
30242 * expression.cs (UnaryMutator): New class, used to handle ++ and
30243 -- separatedly from the other unary operators. Cleans up the
30244 code, and kills the ExpressionStatement dependency in Unary.
30246 (Unary): Removed `method' and `Arguments' from this class, making
30247 it smaller, and moving it all to SimpleCall, so I can reuse this
30248 code in other locations and avoid creating a lot of transient data
30249 strucutres when not required.
30251 * cs-parser.jay: Adjust for new changes.
30253 2001-11-11 Miguel de Icaza <miguel@ximian.com>
30255 * enum.cs (Enum.Populate): If there is a failure during
30258 * cs-parser.jay (opt_enum_base): we used to catch type errors
30259 here, but this is really incorrect. The type error should be
30260 catched during semantic analysis.
30262 2001-12-11 Ravi Pratap <ravi@ximian.com>
30264 * cs-parser.jay (operator_declarator, conversion_operator_declarator): Set
30265 current_local_parameters as expected since I, in my stupidity, had forgotten
30268 * attribute.cs (GetValidPlaces): Fix stupid bug.
30270 * class.cs (Method::Emit): Perform check on applicability of attributes.
30272 (Constructor::Emit): Ditto.
30274 (Field::Emit): Ditto.
30276 (Field.Location): Store location information.
30278 (Property, Event, Indexer, Operator): Ditto.
30280 * cs-parser.jay (field_declaration): Pass in location for each field.
30282 * ../errors/cs0592.cs : Add.
30284 2001-11-12 Ravi Pratap <ravi@ximian.com>
30286 * typemanager.cs (attribute_usage_type): New static member for System.AttributeUsage.
30288 (InitCoreTypes): Update accordingly.
30290 (RegisterAttrType, LookupAttr): Implement.
30292 * attribute.cs (Attribute.Targets, AllowMultiple, Inherited): New fields to hold
30293 info about the same.
30295 (Resolve): Update to populate the above as necessary.
30297 (Error592): Helper.
30299 (GetValidPlaces): Helper to the above.
30301 (CheckAttribute): Implement to perform validity of attributes on declarative elements.
30303 * class.cs (TypeContainer::Emit): Update attribute emission code to perform checking etc.
30305 2001-11-12 Ravi Pratap <ravi@ximian.com>
30307 * attribute.cs (Attribute::Resolve): Expand to handle named arguments too.
30309 * ../errors/cs0617.cs : Add.
30311 2001-11-11 Ravi Pratap <ravi@ximian.com>
30313 * enum.cs (Emit): Rename to Populate to be more consistent with what
30314 we expect it to do and when exactly it is called.
30316 * class.cs, rootcontext.cs : Update accordingly.
30318 * typemanager.cs (RegisterField, GetValue): Workarounds for the fact that
30319 FieldInfo.GetValue does not work on dynamic types ! S.R.E lameness strikes again !
30321 * enum.cs (Populate): Register fields with TypeManager.RegisterField.
30323 * expression.cs (MemberAccess.DoResolve): Adjust code to obtain the value
30324 of a fieldinfo using the above, when dealing with a FieldBuilder.
30326 2001-11-10 Ravi Pratap <ravi@ximian.com>
30328 * ../errors/cs0031.cs : Add.
30330 * ../errors/cs1008.cs : Add.
30332 * ../errrors/cs0543.cs : Add.
30334 * enum.cs (DefineEnum): Check the underlying type and report an error if not a valid
30337 (FindMembers): Implement.
30339 * typemanager.cs (FindMembers): Re-write to call the appropriate methods for
30340 enums and delegates too.
30342 (enum_types): Rename to builder_to_enum.
30344 (delegate_types): Rename to builder_to_delegate.
30346 * delegate.cs (FindMembers): Implement.
30348 2001-11-09 Ravi Pratap <ravi@ximian.com>
30350 * typemanager.cs (IsEnumType): Implement.
30352 * enum.cs (Emit): Re-write parts to account for the underlying type
30353 better and perform checking etc.
30355 (GetNextDefaultValue): Helper to ensure we don't overshoot max value
30356 of the underlying type.
30358 * literal.cs (GetValue methods everywhere): Perform bounds checking and return
30361 * enum.cs (error31): Helper to report error #31.
30363 * cs-parser.jay (enum_declaration): Store location of each member too.
30365 * enum.cs (member_to_location): New hashtable.
30367 (AddEnumMember): Update location hashtable.
30369 (Emit): Use the location of each member while reporting errors.
30371 2001-11-09 Miguel de Icaza <miguel@ximian.com>
30373 * cs-parser.jay: A for_initializer if is a
30374 local_variable_declaration really ammount to have an implicit
30375 block with the variable declaration and no initializer for for.
30377 * statement.cs (For.Emit): Cope with null initializers.
30379 This fixes the infinite loop on for initializers.
30381 2001-11-08 Miguel de Icaza <miguel@ximian.com>
30383 * enum.cs: More cleanup.
30385 * ecore.cs: Remove dead code.
30387 * class.cs (Property.Emit): More simplification.
30388 (Event.Emit): ditto.
30390 Reworked to have less levels of indentation.
30392 2001-11-08 Ravi Pratap <ravi@ximian.com>
30394 * class.cs (Property): Emit attributes.
30404 * enum.cs (Emit): Ditto.
30406 * rootcontext.cs (ResolveTree, EmitCode, CloseTypes): Do the same for
30409 * class.cs (Field, Event, etc.): Move attribute generation into the
30410 Emit method everywhere.
30412 * enum.cs (Enum): Revamp to use the same definition semantics as delegates so
30413 we have a DefineEnum, CloseEnum etc. The previous way of doing things was not right
30414 as we had no way of defining nested enums !
30416 * rootcontext.cs : Adjust code accordingly.
30418 * typemanager.cs (AddEnumType): To keep track of enum types separately.
30420 2001-11-07 Ravi Pratap <ravi@ximian.com>
30422 * expression.cs (EvalConstantExpression): Move into ecore.cs
30424 * enum.cs (Enum): Rename some members and make them public and readonly
30425 according to our convention.
30427 * modifiers.cs (EnumAttr): Implement as we need to set only visibility flags,
30430 * enum.cs (Enum::Define): Use the above instead of TypeAttr.
30432 (Enum::Emit): Write a simple version for now which doesn't try to compute
30433 expressions. I shall modify this to be more robust in just a while.
30435 * class.cs (TypeContainer::Emit): Make sure we include Enums too.
30437 (TypeContainer::CloseType): Create the Enum types too.
30439 * attribute.cs (Resolve): Use the new Reduce method instead of EvalConstantExpression.
30441 * expression.cs (EvalConstantExpression): Get rid of completely.
30443 * enum.cs (Enum::Emit): Use the new expression reducer. Implement assigning
30444 user-defined values and other cases.
30446 (IsValidEnumLiteral): Helper function.
30448 * expression.cs (ExprClassfromMemberInfo): Modify to not do any literalizing
30449 out there in the case we had a literal FieldExpr.
30451 (MemberAccess:DoResolve): Do the literalizing of the FieldExpr here.
30453 (Literalize): Revamp a bit to take two arguments.
30455 (EnumLiteral): New class which derives from Literal to wrap enum literals.
30457 2001-11-06 Ravi Pratap <ravi@ximian.com>
30459 * cs-parser.jay (compilation_unit): Remove extra opt_attributes for now.
30461 * expression.cs (ArrayCreation::ValidateInitializers): Implement.
30463 (Resolve): Use the above to ensure we have proper initializers.
30465 2001-11-05 Ravi Pratap <ravi@ximian.com>
30467 * expression.cs (Expression::EvalConstantExpression): New method to
30468 evaluate constant expressions.
30470 * attribute.cs (Attribute::Resolve): Modify bits to use the above function.
30472 2001-11-07 Miguel de Icaza <miguel@ximian.com>
30474 * expression.cs (ArrayCreation.Emit): Some bits to initialize data
30477 (Binary.ResolveOperator): Handle operator != (object a, object b)
30478 and operator == (object a, object b);
30480 (Binary.DoNumericPromotions): Indicate whether the numeric
30481 promotion was possible.
30483 (ArrayAccess.DoResolve, ArrayAccess.Emit, ArrayAccess.EmitAssign):
30486 Made the ArrayAccess implement interface IAssignMethod instead of
30487 IStackStore as the order in which arguments are passed reflects
30490 * assign.cs: Instead of using expr.ExprClass to select the way of
30491 assinging, probe for the IStackStore/IAssignMethod interfaces.
30493 * typemanager.cs: Load InitializeArray definition.
30495 * rootcontext.cs (RootContext.MakeStaticData): Used to define
30496 static data that can be used to initialize arrays.
30498 2001-11-05 Miguel de Icaza <miguel@ximian.com>
30500 * expression.cs: Handle operator== and operator!= for booleans.
30502 (Conditioal.Reduce): Implement reducer for the ?: operator.
30504 (Conditional.Resolve): Implement dead code elimination.
30506 (Binary.Resolve): Catch string literals and return a new
30507 concatenated string.
30509 (Unary.Reduce): Implement reduction of unary expressions.
30511 * ecore.cs: Split out the expression core handling here.
30513 (Expression.Reduce): New method used to perform constant folding
30514 and CSE. This is needed to support constant-expressions.
30516 * statement.cs (Statement.EmitBoolExpression): Pass true and false
30517 targets, and optimize for !x.
30519 2001-11-04 Ravi Pratap <ravi@ximian.com>
30521 * attribute.cs (Attribute::Resolve): Implement guts. Note that resolution
30522 of an attribute gives us a CustomAttributeBuilder which we use accordingly to
30523 set custom atttributes.
30525 * literal.cs (Literal::GetValue): New abstract method to return the actual
30526 value of the literal, cast as an object.
30528 (*Literal): Implement GetValue method.
30530 * cs-parser.jay (positional_argument_list, named_argument_list): Add not just plain
30531 expressions to the arraylist but objects of type Argument.
30533 * class.cs (TypeContainer::Emit): Emit our attributes too.
30535 (Method::Emit, Constructor::Emit): Ditto.
30537 * cs-parser.jay (constructor_declaration): Set attributes too, which we seemed
30538 to be ignoring earlier.
30540 2001-11-03 Ravi Pratap <ravi@ximian.com>
30542 * attribute.cs (AttributeSection::Define): Implement to do the business
30543 of constructing a CustomAttributeBuilder.
30545 (Attribute): New trivial class. Increases readability of code.
30547 * cs-parser.jay : Update accordingly.
30549 (positional_argument_list, named_argument_list, named_argument): New rules
30551 (attribute_arguments): Use the above so that we are more correct.
30553 2001-11-02 Ravi Pratap <ravi@ximian.com>
30555 * expression.cs (Invocation::IsParamsMethodApplicable): Implement
30556 to perform all checks for a method with a params parameter.
30558 (Invocation::OverloadResolve): Update to use the above method and therefore
30559 cope correctly with params method invocations.
30561 * support.cs (InternalParameters::ParameterDesc): Provide a desc for
30564 * class.cs (ConstructorInitializer::Resolve): Make sure we look for Non-public
30565 constructors in our parent too because we can't afford to miss out on
30568 * attribute.cs (AttributeSection): New name for the class Attribute
30570 Other trivial changes to improve readability.
30572 * cs-parser.jay (opt_attributes, attribute_section etc.): Modify to
30573 use the new class names.
30575 2001-11-01 Ravi Pratap <ravi@ximian.com>
30577 * class.cs (Method::Define): Complete definition for params types too
30579 (Indexer::Define): Ditto.
30581 * support.cs (InternalParameters::ParameterType, ParameterDesc, ParameterModifier):
30582 Cope everywhere with a request for info about the array parameter.
30584 2001-11-01 Ravi Pratap <ravi@ximian.com>
30586 * tree.cs (RecordNamespace): Fix up to check for the correct key.
30588 * cs-parser.jay (GetQualifiedIdentifier): New Helper method used in
30589 local_variable_type to extract the string corresponding to the type.
30591 (local_variable_type): Fixup the action to use the new helper method.
30593 * codegen.cs : Get rid of RefOrOutParameter, it's not the right way to
30596 * expression.cs : Clean out code which uses the above.
30598 2001-10-31 Ravi Pratap <ravi@ximian.com>
30600 * typemanager.cs (RegisterMethod): Check if we already have an existing key
30601 and bale out if necessary by returning a false.
30603 (RegisterProperty): Ditto.
30605 * class.cs (everywhere): Check the return value from TypeManager.RegisterMethod
30606 and print out appropriate error messages.
30608 * interface.cs (everywhere): Ditto.
30610 * cs-parser.jay (property_declaration, event_declaration, indexer_declaration): Pass
30611 location to constructor.
30613 * class.cs (Property, Event, Indexer): Update accordingly.
30615 * ../errors/cs111.cs : Added.
30617 * expression.cs (Invocation::IsApplicable): New static method to determine applicability
30618 of a method, as laid down by the spec.
30620 (Invocation::OverloadResolve): Use the above method.
30622 2001-10-31 Ravi Pratap <ravi@ximian.com>
30624 * support.cs (InternalParameters): Get rid of crap taking in duplicate info. We
30625 now take a TypeContainer and a Parameters object.
30627 (ParameterData): Modify return type of ParameterModifier method to be
30628 Parameter.Modifier and not a string.
30630 (ReflectionParameters, InternalParameters): Update accordingly.
30632 * expression.cs (Argument::GetParameterModifier): Same here.
30634 * support.cs (InternalParameters::ParameterType): Find a better way of determining
30635 if we are a ref/out parameter. Actually, the type shouldn't be holding the '&'
30636 symbol in it at all so maybe this is only for now.
30638 2001-10-30 Ravi Pratap <ravi@ximian.com>
30640 * support.cs (InternalParameters): Constructor now takes an extra argument
30641 which is the actual Parameters class.
30643 (ParameterDesc): Update to provide info on ref/out modifiers.
30645 * class.cs (everywhere): Update call to InternalParameters to pass in
30646 the second argument too.
30648 * support.cs (ParameterData): Add ParameterModifier, which is a method
30649 to return the modifier info [ref/out etc]
30651 (InternalParameters, ReflectionParameters): Implement the above.
30653 * expression.cs (Argument::ParameterModifier): Similar function to return
30654 info about the argument's modifiers.
30656 (Invocation::OverloadResolve): Update to take into account matching modifiers
30659 * class.cs (Indexer::Define): Actually define a Parameter object and put it onto
30660 a new SetFormalParameters object which we pass to InternalParameters.
30662 2001-10-30 Ravi Pratap <ravi@ximian.com>
30664 * expression.cs (NewArray): Merge into the ArrayCreation class.
30666 2001-10-29 Ravi Pratap <ravi@ximian.com>
30668 * expression.cs (NewArray): Merge classes NewBuiltinArray and
30669 NewUserdefinedArray into one as there wasn't much of a use in having
30672 * expression.cs (Argument): Change field's name to ArgType from Type.
30674 (Type): New readonly property which returns the proper type, taking into
30675 account ref/out modifiers.
30677 (everywhere): Adjust code accordingly for the above.
30679 * codegen.cs (EmitContext.RefOrOutParameter): New field to determine
30680 whether we are emitting for a ref or out parameter.
30682 * expression.cs (Argument::Emit): Use the above field to set the state.
30684 (LocalVariableReference::Emit): Update to honour the flag and emit the
30687 * parameter.cs (Attributes): Set the correct flags for ref parameters.
30689 * expression.cs (Argument::FullDesc): New function to provide a full desc.
30691 * support.cs (ParameterData): Add method ParameterDesc to the interface.
30693 (ReflectionParameters, InternalParameters): Implement the above method.
30695 * expression.cs (Invocation::OverloadResolve): Use the new desc methods in
30698 (Invocation::FullMethodDesc): Ditto.
30700 2001-10-29 Miguel de Icaza <miguel@ximian.com>
30702 * cs-parser.jay: Add extra production for the second form of array
30705 * expression.cs (ArrayCreation): Update to reflect the above
30708 * Small changes to prepare for Array initialization.
30710 2001-10-28 Miguel de Icaza <miguel@ximian.com>
30712 * typemanager.cs (ImplementsInterface): interface might be null;
30713 Deal with this problem;
30715 Also, we do store negative hits on the cache (null values), so use
30716 this instead of calling t.GetInterfaces on the type everytime.
30718 2001-10-28 Ravi Pratap <ravi@ximian.com>
30720 * typemanager.cs (IsBuiltinType): New method to help determine the same.
30722 * expression.cs (New::DoResolve): Get rid of array creation code and instead
30723 split functionality out into different classes.
30725 (New::FormArrayType): Move into NewBuiltinArray.
30727 (Invocation::EmitArguments): Get rid of the MethodBase argument. Appears
30730 (NewBuiltinArray): New class to handle creation of built-in arrays.
30732 (NewBuiltinArray::DoResolve): Implement guts of array creation. Also take into
30733 account creation of one-dimensional arrays.
30735 (::Emit): Implement to use Newarr and Newobj opcodes accordingly.
30737 (NewUserdefinedArray::DoResolve): Implement.
30739 * cs-parser.jay (local_variable_type): Fix up to add the rank to the variable too.
30741 * typemanager.cs (AddModule): Used to add a ModuleBuilder to the list of modules
30742 we maintain inside the TypeManager. This is necessary to perform lookups on the
30745 (LookupType): Update to perform GetType on the module builders too.
30747 * driver.cs (Driver): Add the ModuleBuilder to the list maintained by the TypeManager.
30749 * exprssion.cs (NewUserdefinedArray::Emit): Implement.
30751 2001-10-23 Ravi Pratap <ravi@ximian.com>
30753 * expression.cs (New::DoResolve): Implement guts of array creation.
30755 (New::FormLookupType): Rename to FormArrayType and modify ever so slightly.
30757 2001-10-27 Miguel de Icaza <miguel@ximian.com>
30759 * expression.cs: Fix bug I introduced lsat night that broke
30762 (Expression.Resolve): Report a 246 error (can not resolve name)
30763 if we find a SimpleName in the stream.
30765 (Expression.ResolveLValue): Ditto.
30767 (Expression.ResolveWithSimpleName): This function is a variant of
30768 ResolveName, this one allows SimpleNames to be returned without a
30769 warning. The only consumer of SimpleNames is MemberAccess
30771 2001-10-26 Miguel de Icaza <miguel@ximian.com>
30773 * expression.cs (Invocation::DoResolve): Catch SimpleNames that
30774 might arrive here. I have my doubts that this is correct.
30776 * statement.cs (Lock): Implement lock statement.
30778 * cs-parser.jay: Small fixes to support `lock' and `using'
30780 * cs-tokenizer.cs: Remove extra space
30782 * driver.cs: New flag --checked, allows to turn on integer math
30785 * typemanger.cs: Load methodinfos for Threading.Monitor.Enter and
30786 Threading.Monitor.Exit
30788 2001-10-23 Miguel de Icaza <miguel@ximian.com>
30790 * expression.cs (IndexerAccess::DoResolveLValue): Set the
30791 Expression Class to be IndexerAccess.
30793 Notice that Indexer::DoResolve sets the eclass to Value.
30795 2001-10-22 Miguel de Icaza <miguel@ximian.com>
30797 * class.cs (TypeContainer::Emit): Emit code for indexers.
30799 * assign.cs (IAssignMethod): New interface implemented by Indexers
30800 and Properties for handling assignment.
30802 (Assign::Emit): Simplify and reuse code.
30804 * expression.cs (IndexerAccess, PropertyExpr): Implement
30805 IAssignMethod, clean up old code.
30807 2001-10-22 Ravi Pratap <ravi@ximian.com>
30809 * typemanager.cs (ImplementsInterface): New method to determine if a type
30810 implements a given interface. Provides a nice cache too.
30812 * expression.cs (ImplicitReferenceConversion): Update checks to use the above
30815 (ConvertReferenceExplicit): Ditto.
30817 * delegate.cs (Delegate::Populate): Update to define the parameters on the
30818 various methods, with correct names etc.
30820 * class.cs (Operator::OpType): New members Operator.UnaryPlus and
30821 Operator.UnaryNegation.
30823 * cs-parser.jay (operator_declarator): Be a little clever in the case where
30824 we have a unary plus or minus operator.
30826 * expression.cs (Unary): Rename memebers of Operator enum to UnaryPlus and
30829 * everywhere : update accordingly.
30831 * everywhere : Change Negate and BitComplement to LogicalNot and OnesComplement
30834 * class.cs (Method::Define): For the case where we are implementing a method
30835 inherited from an interface, we need to set the MethodAttributes.Final flag too.
30836 Also set MethodAttributes.NewSlot and MethodAttributes.HideBySig.
30838 2001-10-21 Ravi Pratap <ravi@ximian.com>
30840 * interface.cs (FindMembers): Implement to work around S.R.E
30843 * typemanager.cs (IsInterfaceType): Implement.
30845 (FindMembers): Update to handle interface types too.
30847 * expression.cs (ImplicitReferenceConversion): Re-write bits which
30848 use IsAssignableFrom as that is not correct - it doesn't work.
30850 * delegate.cs (DelegateInvocation): Derive from ExpressionStatement
30851 and accordingly override EmitStatement.
30853 * expression.cs (ConvertReferenceExplicit): Re-write similary, this time
30854 using the correct logic :-)
30856 2001-10-19 Ravi Pratap <ravi@ximian.com>
30858 * ../errors/cs-11.cs : Add to demonstrate error -11
30860 2001-10-17 Miguel de Icaza <miguel@ximian.com>
30862 * assign.cs (Assign::Resolve): Resolve right hand side first, and
30863 then pass this as a hint to ResolveLValue.
30865 * expression.cs (FieldExpr): Add Location information
30867 (FieldExpr::LValueResolve): Report assignment to readonly
30870 (Expression::ExprClassFromMemberInfo): Pass location information.
30872 (Expression::ResolveLValue): Add new method that resolves an
30875 (Expression::DoResolveLValue): Default invocation calls
30878 (Indexers): New class used to keep track of indexers in a given
30881 (IStackStore): Renamed from LValue, as it did not really describe
30882 what this did. Also ResolveLValue is gone from this interface and
30883 now is part of Expression.
30885 (ElementAccess): Depending on the element access type
30887 * typemanager.cs: Add `indexer_name_type' as a Core type
30888 (System.Runtime.CompilerServices.IndexerNameAttribute)
30890 * statement.cs (Goto): Take a location.
30892 2001-10-18 Ravi Pratap <ravi@ximian.com>
30894 * delegate.cs (Delegate::VerifyDelegate): New method to verify
30895 if two delegates are compatible.
30897 (NewDelegate::DoResolve): Update to take care of the case when
30898 we instantiate a delegate from another delegate.
30900 * typemanager.cs (FindMembers): Don't even try to look up members
30901 of Delegate types for now.
30903 2001-10-18 Ravi Pratap <ravi@ximian.com>
30905 * delegate.cs (NewDelegate): New class to take care of delegate
30908 * expression.cs (New): Split the delegate related code out into
30909 the NewDelegate class.
30911 * delegate.cs (DelegateInvocation): New class to handle delegate
30914 * expression.cs (Invocation): Split out delegate related code into
30915 the DelegateInvocation class.
30917 2001-10-17 Ravi Pratap <ravi@ximian.com>
30919 * expression.cs (New::DoResolve): Implement delegate creation fully
30920 and according to the spec.
30922 (New::DoEmit): Update to handle delegates differently.
30924 (Invocation::FullMethodDesc): Fix major stupid bug thanks to me
30925 because of which we were printing out arguments in reverse order !
30927 * delegate.cs (VerifyMethod): Implement to check if the given method
30928 matches the delegate.
30930 (FullDelegateDesc): Implement.
30932 (VerifyApplicability): Implement.
30934 * expression.cs (Invocation::DoResolve): Update to accordingly handle
30935 delegate invocations too.
30937 (Invocation::Emit): Ditto.
30939 * ../errors/cs1593.cs : Added.
30941 * ../errors/cs1594.cs : Added.
30943 * delegate.cs (InstanceExpression, TargetMethod): New properties.
30945 2001-10-16 Ravi Pratap <ravi@ximian.com>
30947 * typemanager.cs (intptr_type): Core type for System.IntPtr
30949 (InitCoreTypes): Update for the same.
30951 (iasyncresult_type, asynccallback_type): Ditto.
30953 * delegate.cs (Populate): Fix to use System.Intptr as it is indeed
30956 * typemanager.cs (AddDelegateType): Store a pointer to the Delegate class
30959 * delegate.cs (ConstructorBuilder, InvokeBuilder, ...): New members to hold
30960 the builders for the 4 members of a delegate type :-)
30962 (Populate): Define the BeginInvoke and EndInvoke methods on the delegate
30965 * expression.cs (New::DoResolve): Implement guts for delegate creation.
30967 * ../errors/errors.txt : Update for an error (-11) which only we catch :-)
30969 2001-10-15 Miguel de Icaza <miguel@ximian.com>
30971 * statement.cs (Break::Emit): Implement.
30972 (Continue::Emit): Implement.
30974 (For::Emit): Track old being/end loops; Set Begin loop, ack end loop
30975 (While::Emit): Track old being/end loops; Set Begin loop, ack end loop
30976 (Do::Emit): Track old being/end loops; Set Begin loop, ack end loop
30977 (Foreach::Emit): Track old being/end loops; Set Begin loop, ack
30980 * codegen.cs (EmitContext::LoopEnd, EmitContext::LoopBegin): New
30981 properties that track the label for the current loop (begin of the
30982 loop and end of the loop).
30984 2001-10-15 Ravi Pratap <ravi@ximian.com>
30986 * delegate.cs (Emit): Get rid of it as there doesn't seem to be any ostensible
30987 use of emitting anything at all.
30989 * class.cs, rootcontext.cs : Get rid of calls to the same.
30991 * delegate.cs (DefineDelegate): Make sure the class we define is also sealed.
30993 (Populate): Define the constructor correctly and set the implementation
30996 * typemanager.cs (delegate_types): New hashtable to hold delegates that
30999 (AddDelegateType): Implement.
31001 (IsDelegateType): Implement helper method.
31003 * delegate.cs (DefineDelegate): Use AddDelegateType instead of AddUserType.
31005 * expression.cs (New::DoResolve): Check if we are trying to instantiate a delegate type
31006 and accordingly handle it.
31008 * delegate.cs (Populate): Take TypeContainer argument.
31009 Implement bits to define the Invoke method. However, I still haven't figured out
31010 how to take care of the native int bit :-(
31012 * cs-parser.jay (delegate_declaration): Fixed the bug that I had introduced :-)
31013 Qualify the name of the delegate, not its return type !
31015 * expression.cs (ImplicitReferenceConversion): Implement guts of implicit array
31018 (StandardConversionExists): Checking for array types turns out to be recursive.
31020 (ConvertReferenceExplicit): Implement array conversion.
31022 (ExplicitReferenceConversionExists): New method to determine precisely that :-)
31024 2001-10-12 Ravi Pratap <ravi@ximian.com>
31026 * cs-parser.jay (delegate_declaration): Store the fully qualified
31027 name as it is a type declaration.
31029 * delegate.cs (ReturnType, Name): Rename members to these. Make them
31032 (DefineDelegate): Renamed from Define. Does the same thing essentially,
31033 as TypeContainer::DefineType.
31035 (Populate): Method in which all the definition of the various methods (Invoke)
31038 (Emit): Emit any code, if necessary. I am not sure about this really, but let's
31041 (CloseDelegate): Finally creates the delegate.
31043 * class.cs (TypeContainer::DefineType): Update to define delegates.
31044 (Populate, Emit and CloseType): Do the same thing here too.
31046 * rootcontext.cs (ResolveTree, PopulateTypes, EmitCode, CloseTypes): Include
31047 delegates in all these operations.
31049 2001-10-14 Miguel de Icaza <miguel@ximian.com>
31051 * expression.cs: LocalTemporary: a new expression used to
31052 reference a temporary that has been created.
31054 * assign.cs: Handle PropertyAccess back here, so that we can
31055 provide the proper semantic access to properties.
31057 * expression.cs (Expression::ConvertReferenceExplicit): Implement
31058 a few more explicit conversions.
31060 * modifiers.cs: `NEW' modifier maps to HideBySig.
31062 * expression.cs (PropertyExpr): Make this into an
31063 ExpressionStatement, and support the EmitStatement code path.
31065 Perform get/set error checking, clean up the interface.
31067 * assign.cs: recognize PropertyExprs as targets, and if so, turn
31068 them into toplevel access objects.
31070 2001-10-12 Miguel de Icaza <miguel@ximian.com>
31072 * expression.cs: PropertyExpr::PropertyExpr: use work around the
31075 * typemanager.cs: Keep track here of our PropertyBuilders again to
31076 work around lameness in SRE.
31078 2001-10-11 Miguel de Icaza <miguel@ximian.com>
31080 * expression.cs (LValue::LValueResolve): New method in the
31081 interface, used to perform a second resolution pass for LValues.
31083 (This::DoResolve): Catch the use of this in static methods.
31085 (This::LValueResolve): Implement.
31087 (This::Store): Remove warning, assigning to `this' in structures
31090 (Invocation::Emit): Deal with invocation of
31091 methods on value types. We need to pass the address to structure
31092 methods rather than the object itself. (The equivalent code to
31093 emit "this" for structures leaves the entire structure on the
31094 stack instead of a pointer to it).
31096 (ParameterReference::DoResolve): Compute the real index for the
31097 argument based on whether the method takes or not a `this' pointer
31098 (ie, the method is static).
31100 * codegen.cs (EmitContext::GetTemporaryStorage): Used to store
31101 value types returned from functions when we need to invoke a
31102 method on the sturcture.
31105 2001-10-11 Ravi Pratap <ravi@ximian.com>
31107 * class.cs (TypeContainer::DefineType): Method to actually do the business of
31108 defining the type in the Modulebuilder or Typebuilder. This is to take
31109 care of nested types which need to be defined on the TypeBuilder using
31110 DefineNestedMethod.
31112 (TypeContainer::GetClassBases): Implement. Essentially the code from the
31113 methods in RootContext, only ported to be part of TypeContainer.
31115 (TypeContainer::GetInterfaceOrClass): Ditto.
31117 (TypeContainer::LookupInterfaceOrClass, ::MakeFQN): Ditto.
31119 * interface.cs (Interface::DefineInterface): New method. Does exactly
31120 what RootContext.CreateInterface did earlier, only it takes care of nested types
31123 (Interface::GetInterfaces): Move from RootContext here and port.
31125 (Interface::GetInterfaceByName): Same here.
31127 * rootcontext.cs (ResolveTree): Re-write.
31129 (PopulateTypes): Re-write.
31131 * class.cs (TypeContainer::Populate): Populate nested types too.
31132 (TypeContainer::Emit): Emit nested members too.
31134 * typemanager.cs (AddUserType): Do not make use of the FullName property,
31135 instead just use the name argument passed in as it is already fully
31138 (FindMembers): Check in the Builders to TypeContainer mapping instead of the name
31139 to TypeContainer mapping to see if a type is user-defined.
31141 * class.cs (TypeContainer::CloseType): Implement.
31143 (TypeContainer::DefineDefaultConstructor): Use Basename, not Name while creating
31144 the default constructor.
31146 (TypeContainer::Populate): Fix minor bug which led to creating default constructors
31149 (Constructor::IsDefault): Fix up logic to determine if it is the default constructor
31151 * interface.cs (CloseType): Create the type here.
31153 * rootcontext.cs (CloseTypes): Re-write to recursively close types by running through
31156 Remove all the methods which are now in TypeContainer.
31158 2001-10-10 Ravi Pratap <ravi@ximian.com>
31160 * delegate.cs (Define): Re-write bits to define the delegate
31163 2001-10-10 Miguel de Icaza <miguel@ximian.com>
31165 * makefile: Renamed the compiler to `mcs.exe' instead of compiler.exe
31167 * expression.cs (ImplicitReferenceConversion): handle null as well
31168 as a source to convert to any reference type.
31170 * statement.cs (Return): Perform any implicit conversions to
31171 expected return type.
31173 Validate use of return statement.
31175 * codegen.cs (EmitContext): Pass the expected return type here.
31177 * class.cs (Method, Constructor, Property): Pass expected return
31178 type to EmitContext.
31180 2001-10-09 Miguel de Icaza <miguel@ximian.com>
31182 * expression.cs: Make DoResolve take an EmitContext instead of a
31185 Replaced `l' and `location' for `loc', for consistency.
31187 (Error, Warning): Remove unneeded Tc argument.
31189 * assign.cs, literal.cs, constant.cs: Update to new calling
31192 * codegen.cs: EmitContext now contains a flag indicating whether
31193 code is being generated in a static method or not.
31195 * cs-parser.jay: DecomposeQI, new function that replaces the old
31196 QualifiedIdentifier. Now we always decompose the assembled
31197 strings from qualified_identifier productions into a group of
31200 2001-10-08 Miguel de Icaza <miguel@ximian.com>
31202 * rootcontext.cs: Deal with field-less struct types correctly now
31203 by passing the size option to Define Type.
31205 * class.cs: Removed hack that created one static field.
31207 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31209 * statement.cs: Moved most of the code generation here.
31211 2001-10-09 Ravi Pratap <ravi@ximian.com>
31213 * expression.cs (New::DoResolve): Revert changes for array creation, doesn't
31216 (ElementAccess): Remove useless bits for now - keep checks as the spec
31219 2001-10-08 Ravi Pratap <ravi@ximian.com>
31221 * expression.cs (ElementAccess::DoResolve): Remove my crap code
31222 and start performing checks according to the spec.
31224 2001-10-07 Ravi Pratap <ravi@ximian.com>
31226 * cs-parser.jay (type_suffix*): Remove - they are redundant. Use
31227 rank_specifiers instead.
31229 (rank_specifiers): Change the order in which the rank specifiers are stored
31231 (local_variable_declaration): Use opt_rank_specifier instead of type_suffixes.
31233 * expression.cs (ElementAccess): Implement the LValue interface too.
31235 2001-10-06 Ravi Pratap <ravi@ximian.com>
31237 * expression.cs (ConvertExplicitStandard): Add. Same as ConvertExplicit
31238 except that user defined conversions are not included.
31240 (UserDefinedConversion): Update to use the ConvertExplicitStandard to
31241 perform the conversion of the return type, if necessary.
31243 (New::DoResolve): Check whether we are creating an array or an object
31244 and accordingly do the needful.
31246 (New::Emit): Same here.
31248 (New::DoResolve): Implement guts of array creation.
31250 (New::FormLookupType): Helper function.
31252 2001-10-07 Miguel de Icaza <miguel@ximian.com>
31254 * codegen.cs: Removed most of the code generation here, and move the
31255 corresponding code generation bits to the statement classes.
31257 Added support for try/catch/finalize and throw.
31259 * cs-parser.jay: Added support for try/catch/finalize.
31261 * class.cs: Catch static methods having the flags override,
31262 virtual or abstract.
31264 * expression.cs (UserCast): This user cast was not really doing
31265 what it was supposed to do. Which is to be born in fully resolved
31266 state. Parts of the resolution were being performed at Emit time!
31270 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31272 * expression.cs: Implicity convert the result from UserCast.
31274 2001-10-05 Ravi Pratap <ravi@ximian.com>
31276 * expression.cs (Expression::FindMostEncompassingType): Fix bug which
31277 prevented it from working correctly.
31279 (ConvertExplicit): Make the first try, a call to ConvertImplicitStandard, not
31280 merely ConvertImplicit.
31282 2001-10-05 Miguel de Icaza <miguel@ximian.com>
31284 * typemanager.cs: Make the LookupTypeContainer function static,
31285 and not per-instance.
31287 * class.cs: Make static FindMembers (the one that takes a Type
31290 * codegen.cs: Add EmitForeach here.
31292 * cs-parser.jay: Make foreach a toplevel object instead of the
31293 inline expansion, as we need to perform semantic analysis on it.
31295 2001-10-05 Ravi Pratap <ravi@ximian.com>
31297 * expression.cs (Expression::ImplicitUserConversion): Rename to
31298 UserDefinedConversion.
31300 (Expression::UserDefinedConversion): Take an extra argument specifying
31301 whether we look for explicit user conversions too.
31303 (Expression::ImplicitUserConversion): Make it a call to UserDefinedConversion.
31305 (UserDefinedConversion): Incorporate support for user defined explicit conversions.
31307 (ExplicitUserConversion): Make it a call to UserDefinedConversion
31308 with the appropriate arguments.
31310 * cs-parser.jay (cast_expression): Record location too.
31312 * expression.cs (Cast): Record location info.
31314 (Expression::ConvertExplicit): Take location argument.
31316 (UserImplicitCast): Change name to UserCast. Take an extra constructor argument
31317 to determine if we are doing explicit conversions.
31319 (UserCast::Emit): Update accordingly.
31321 (Expression::ConvertExplicit): Report an error if everything fails.
31323 * ../errors/cs0030.cs : Add.
31325 2001-10-04 Miguel de Icaza <miguel@ximian.com>
31327 * modifiers.cs: If the ABSTRACT keyword is present, also set the
31328 virtual and newslot bits.
31330 * class.cs (TypeContainer::RegisterRequiredImplementations):
31331 Record methods we need.
31333 (TypeContainer::MakeKey): Helper function to make keys for
31334 MethodBases, since the Methodbase key is useless.
31336 (TypeContainer::Populate): Call RegisterRequiredImplementations
31337 before defining the methods.
31339 Create a mapping for method_builders_to_methods ahead of time
31340 instead of inside a tight loop.
31342 (::RequireMethods): Accept an object as the data to set into the
31343 hashtable so we can report interface vs abstract method mismatch.
31345 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31347 * report.cs: Make all of it static.
31349 * rootcontext.cs: Drop object_type and value_type computations, as
31350 we have those in the TypeManager anyways.
31352 Drop report instance variable too, now it is a global.
31354 * driver.cs: Use try/catch on command line handling.
31356 Add --probe option to debug the error reporting system with a test
31359 * report.cs: Add support for exiting program when a probe
31360 condition is reached.
31362 2001-10-03 Ravi Pratap <ravi@ximian.com>
31364 * expression.cs (Binary::DoNumericPromotions): Fix the case when
31365 we do a forcible conversion regardless of type, to check if
31366 ForceConversion returns a null.
31368 (Binary::error19): Use location to report error.
31370 (Unary::error23): Use location here too.
31372 * ../errors/cs0019.cs : Check in.
31374 * ../errors/cs0023.cs : Check in.
31376 * expression.cs (Expression.MemberLookup): Return null for a rather esoteric
31377 case of a non-null MethodInfo object with a length of 0 !
31379 (Binary::ResolveOperator): Flag error if overload resolution fails to find
31380 an applicable member - according to the spec :-)
31381 Also fix logic to find members in base types.
31383 (Unary::ResolveOperator): Same here.
31385 (Unary::report23): Change name to error23 and make first argument a TypeContainer
31386 as I was getting thoroughly confused between this and error19 :-)
31388 * expression.cs (Expression::ImplicitUserConversion): Re-write fully
31389 (::FindMostEncompassedType): Implement.
31390 (::FindMostEncompassingType): Implement.
31391 (::StandardConversionExists): Implement.
31393 (UserImplicitCast): Re-vamp. We now need info about most specific
31394 source and target types so that we can do the necessary conversions.
31396 (Invocation::MakeUnionSet): Completely re-write to make sure we form a proper
31397 mathematical union with no duplicates.
31399 2001-10-03 Miguel de Icaza <miguel@ximian.com>
31401 * rootcontext.cs (RootContext::PopulateTypes): Populate containers
31402 in order from base classes to child classes, so that we can in
31403 child classes look up in our parent for method names and
31404 attributes (required for handling abstract, virtual, new, override
31405 constructs: we need to instrospect our base class, and if we dont
31406 populate the classes in order, the introspection might be
31407 incorrect. For example, a method could query its parent before
31408 the parent has any methods and would determine that the parent has
31409 no abstract methods (while it could have had them)).
31411 (RootContext::CreateType): Record the order in which we define the
31414 2001-10-02 Miguel de Icaza <miguel@ximian.com>
31416 * class.cs (TypeContainer::Populate): Also method definitions can
31417 fail now, keep track of this.
31419 (TypeContainer::FindMembers): Implement support for
31420 DeclaredOnly/noDeclaredOnly flag.
31422 (Constructor::Emit) Return the ConstructorBuilder.
31424 (Method::Emit) Return the MethodBuilder.
31425 Check for abstract or virtual methods to be public.
31427 * rootcontext.cs (RootContext::CreateType): Register all the
31428 abstract methods required for the class to be complete and the
31429 interface methods that must be implemented.
31431 * cs-parser.jay: Report error 501 (method requires body if it is
31432 not marked abstract or extern).
31434 * expression.cs (TypeOf::Emit): Implement.
31436 * typemanager.cs: runtime_handle_type, new global type.
31438 * class.cs (Property::Emit): Generate code for properties.
31440 2001-10-02 Ravi Pratap <ravi@ximian.com>
31442 * expression.cs (Unary::ResolveOperator): Find operators on base type
31443 too - we now conform exactly to the spec.
31445 (Binary::ResolveOperator): Same here.
31447 * class.cs (Operator::Define): Fix minor quirk in the tests.
31449 * ../errors/cs0215.cs : Added.
31451 * ../errors/cs0556.cs : Added.
31453 * ../errors/cs0555.cs : Added.
31455 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31457 * cs-tokenizer.cs: Reimplemented Location to be a struct with a
31458 single integer which is really efficient
31460 2001-10-01 Ravi Pratap <ravi@ximian.com>
31462 * expression.cs (Expression::ImplicitUserConversion): Use location
31463 even in the case when we are examining True operators.
31465 * class.cs (Operator::Define): Perform extensive checks to conform
31466 with the rules for operator overloading in the spec.
31468 * expression.cs (Expression::ImplicitReferenceConversion): Implement
31469 some of the other conversions mentioned in the spec.
31471 * typemanager.cs (array_type): New static member for the System.Array built-in
31474 (cloneable_interface): For System.ICloneable interface.
31476 * driver.cs (Driver::Driver): Initialize TypeManager's core types even before
31477 we start resolving the tree and populating types.
31479 * ../errors/errors.txt : Update for error numbers -7, -8, -9, -10
31481 2001-10-01 Miguel de Icaza <miguel@ximian.com>
31483 * expression.cs (Expression::ExprClassFromMemberInfo,
31484 Expression::Literalize): Create literal expressions from
31485 FieldInfos which are literals.
31487 (ConvertNumericExplicit, ImplicitNumericConversion): Fix a few
31488 type casts, because they were wrong. The test suite in tests
31491 (ImplicitNumericConversion): ushort to ulong requires a widening
31494 Int32 constant to long requires widening cast as well.
31496 * literal.cs (LongLiteral::EmitLong): Do not generate i4 constants
31497 for integers because the type on the stack is not i4.
31499 2001-09-30 Miguel de Icaza <miguel@ximian.com>
31501 * expression.cs (report118): require location argument.
31503 * parameter.cs: Do not dereference potential null value.
31505 * class.cs: Catch methods that lack the `new' keyword when
31506 overriding a name. Report warnings when `new' is used without
31507 anything being there to override.
31509 * modifiers.cs: Handle `NEW' as MethodAttributes.NewSlot.
31511 * class.cs: Only add constructor to hashtable if it is non-null
31512 (as now constructors can fail on define).
31514 (TypeManager, Class, Struct): Take location arguments.
31516 Catch field instance initialization in structs as errors.
31518 accepting_filter: a new filter for FindMembers that is static so
31519 that we dont create an instance per invocation.
31521 (Constructor::Define): Catch errors where a struct constructor is
31524 * cs-parser.jay: Pass location information for various new
31527 * delegate.cs (Delegate): take a location argument.
31529 * driver.cs: Do not call EmitCode if there were problesm in the
31530 Definition of the types, as many Builders wont be there.
31532 * decl.cs (Decl::Decl): Require a location argument.
31534 * cs-tokenizer.cs: Handle properly hex constants that can not fit
31535 into integers, and find the most appropiate integer for it.
31537 * literal.cs: Implement ULongLiteral.
31539 * rootcontext.cs: Provide better information about the location of
31540 failure when CreateType fails.
31542 2001-09-29 Miguel de Icaza <miguel@ximian.com>
31544 * rootcontext.cs (RootContext::PopulateTypes): Populates structs
31547 * expression.cs (Binary::CheckShiftArguments): Add missing type
31549 (Binary::ResolveOperator): Add type to the logical and and logical
31550 or, Bitwise And/Or and Exclusive Or code paths, it was missing
31553 (Binary::DoNumericPromotions): In the case where either argument
31554 is ulong (and most signed types combined with ulong cause an
31555 error) perform implicit integer constant conversions as well.
31557 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31559 * expression.cs (UserImplicitCast): Method should always be
31561 (Invocation::BetterConversion): Simplified test for IntLiteral.
31563 (Expression::ImplicitNumericConversion): Split this routine out.
31564 Put the code that performs implicit constant integer conversions
31567 (Expression::Resolve): Become a wrapper around DoResolve so we can
31568 check eclass and type being set after resolve.
31570 (Invocation::Badness): Remove this dead function
31572 (Binary::ResolveOperator): Do not compute the expensive argumnets
31573 unless we have a union for it.
31575 (Probe::Emit): Is needs to do an isinst and then
31576 compare against null.
31578 (::CanConvert): Added Location argument. If the Location argument
31579 is null (Location.Null), then we do not report errors. This is
31580 used by the `probe' mechanism of the Explicit conversion. We do
31581 not want to generate an error for something that the user
31582 explicitly requested to be casted. But the pipeline for an
31583 explicit cast first tests for potential implicit casts.
31585 So for now, if the Location is null, it means `Probe only' to
31586 avoid adding another argument. Might have to revise this
31589 (ClassCast): New class used to type cast objects into arbitrary
31590 classes (used in Explicit Reference Conversions).
31592 Implement `as' as well.
31594 Reverted all the patches from Ravi below: they were broken:
31596 * The use of `level' as a mechanism to stop recursive
31597 invocations is wrong. That was there just to catch the
31598 bug with a strack trace but not as a way of addressing
31601 To fix the problem we have to *understand* what is going
31602 on and the interactions and come up with a plan, not
31603 just get things going.
31605 * The use of the type conversion cache that I proposed
31606 last night had an open topic: How does this work across
31607 protection domains. A user defined conversion might not
31608 be public in the location where we are applying the
31609 conversion, a different conversion might be selected
31610 (ie, private A->B (better) but public B->A (worse),
31611 inside A, A->B applies, but outside it, B->A will
31614 * On top of that (ie, even if the above is solved),
31615 conversions in a cache need to be abstract. Ie, `To
31616 convert from an Int to a Short use an OpcodeCast', not
31617 `To convert from an Int to a Short use the OpcodeCast on
31618 the variable 5' (which is what this patch was doing).
31620 2001-09-28 Ravi Pratap <ravi@ximian.com>
31622 * expression.cs (Invocation::ConversionExists): Re-write to use
31623 the conversion cache
31625 (Expression::ConvertImplicit): Automatic bailing out if level != 0. Also
31626 cache all conversions done, not just user-defined ones.
31628 (Invocation::BetterConversion): The real culprit. Use ConversionExists
31629 to determine if a conversion exists instead of acutually trying to
31630 perform the conversion. It's faster too.
31632 (Expression::ConvertExplicit): Modify to use ConversionExists to check
31633 and only then attempt the implicit conversion.
31635 2001-09-28 Ravi Pratap <ravi@ximian.com>
31637 * expression.cs (ConvertImplicit): Use a cache for conversions
31638 already found. Check level of recursion and bail out if necessary.
31640 2001-09-28 Miguel de Icaza <miguel@ximian.com>
31642 * typemanager.cs (string_concat_string_string, string_concat_object_object):
31643 Export standard methods that we expect for string operations.
31645 * statement.cs (Block::UsageWarning): Track usage of variables and
31646 report the errors for not used variables.
31648 * expression.cs (Conditional::Resolve, ::Emit): Implement ?:
31651 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31653 * codegen.cs: remove unnneded code
31655 * expression.cs: Removed BuiltinTypeAccess class
31657 Fix the order in which implicit conversions are
31660 The previous fixed dropped support for boxed conversions (adding a
31661 test to the test suite now)
31663 (UserImplicitCast::CanConvert): Remove test for source being null,
31664 that code is broken. We should not feed a null to begin with, if
31665 we do, then we should track the bug where the problem originates
31666 and not try to cover it up here.
31668 Return a resolved expression of type UserImplicitCast on success
31669 rather than true/false. Ravi: this is what I was talking about,
31670 the pattern is to use a static method as a "constructor" for
31673 Also, do not create arguments until the very last minute,
31674 otherwise we always create the arguments even for lookups that
31675 will never be performed.
31677 (UserImplicitCast::Resolve): Eliminate, objects of type
31678 UserImplicitCast are born in a fully resolved state.
31680 * typemanager.cs (InitCoreTypes): Init also value_type
31681 (System.ValueType).
31683 * expression.cs (Cast::Resolve): First resolve the child expression.
31685 (LValue): Add new method AddressOf to be used by
31688 Change the argument of Store to take an EmitContext instead of an
31689 ILGenerator, because things like FieldExpr need to be able to call
31690 their children expression to generate the instance code.
31692 (Expression::Error, Expression::Warning): Sugar functions for
31695 (Expression::MemberLookup): Accept a TypeContainer instead of a
31696 Report as the first argument.
31698 (Expression::ResolvePrimary): Killed. I still want to improve
31699 this as currently the code is just not right.
31701 (Expression::ResolveMemberAccess): Simplify, but it is still
31704 (Unary::Resolve): Catch errors in AddressOf operators.
31706 (LocalVariableReference::Emit, ::Store, ::AddressOf): typecast
31707 index to a byte for the short-version, or the compiler will choose
31708 the wrong Emit call, which generates the wrong data.
31710 (ParameterReference::Emit, ::Store): same.
31712 (FieldExpr::AddressOf): Implement.
31714 * typemanager.cs: TypeManager: made public variable instead of
31717 * driver.cs: document --fatal.
31719 * report.cs (ErrorMessage, WarningMessage): new names for the old
31720 Error and Warning classes.
31722 * cs-parser.jay (member_access): Turn built-in access to types
31723 into a normal simplename
31725 2001-09-27 Ravi Pratap <ravi@ximian.com>
31727 * expression.cs (Invocation::BetterConversion): Fix to cope
31728 with q being null, since this was introducing a bug.
31730 * expression.cs (ConvertImplicit): Do built-in conversions first.
31732 2001-09-27 Ravi Pratap <ravi@ximian.com>
31734 * expression.cs (UserImplicitCast::Resolve): Fix bug.
31736 2001-09-27 Ravi Pratap <ravi@ximian.com>
31738 * class.cs (TypeContainer::AddConstructor): Fix a stupid bug
31739 I had introduced long ago (what's new ?).
31741 * expression.cs (UserImplicitCast::CanConvert): Static method to do
31742 the work of all the checking.
31743 (ConvertImplicit): Call CanConvert and only then create object if necessary.
31744 (UserImplicitCast::CanConvert, ::Resolve): Re-write.
31746 (Unary::Operator): Rename Add and Subtract to Addition and Subtraction because
31747 that is the right way.
31749 (Invocation::MakeUnionSet): Convenience function to make unions of sets for
31750 overloading resolution. Use everywhere instead of cutting and pasting code.
31752 (Binary::ResolveOperator): Use MakeUnionSet.
31754 (UserImplicitCast::CanConvert, ::Resolve): Update to take care of the case when
31755 we have to convert to bool types. Not complete yet.
31757 2001-09-27 Miguel de Icaza <miguel@ximian.com>
31759 * typemanager.cs (TypeManager::CSharpName): support ushort.
31761 * expression.cs (Expression::TryImplicitIntConversion): Attempts
31762 to provide an expression that performsn an implicit constant int
31763 conversion (section 6.1.6).
31764 (Expression::ConvertImplicitRequired): Reworked to include
31765 implicit constant expression conversions.
31767 (Expression::ConvertNumericExplicit): Finished.
31769 (Invocation::Emit): If InstanceExpression is null, then it means
31770 that we perform a call on this.
31772 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31774 * expression.cs (Unary::Emit): Remove some dead code.
31775 (Probe): Implement Resolve and Emit for `is'.
31776 (Expression::ConvertImplicitRequired): Attempt to do constant
31777 expression conversions here. Maybe should be moved to
31778 ConvertImplicit, but I am not sure.
31779 (Expression::ImplicitLongConstantConversionPossible,
31780 Expression::ImplicitIntConstantConversionPossible): New functions
31781 that tell whether is it possible to apply an implicit constant
31782 expression conversion.
31784 (ConvertNumericExplicit): Started work on explicit numeric
31787 * cs-parser.jay: Update operator constants.
31789 * parameter.cs (Parameters::GetParameterInfo): Hook up VerifyArgs
31790 (Parameters::GetSignature): Hook up VerifyArgs here.
31791 (Parameters::VerifyArgs): Verifies that no two arguments have the
31794 * class.cs (Operator): Update the operator names to reflect the
31795 ones that the spec expects (as we are just stringizing the
31798 * expression.cs (Unary::ResolveOperator): Fix bug: Use
31799 MethodInfo's ReturnType instead of LookupMethodByBuilder as the
31800 previous usage did only work for our methods.
31801 (Expression::ConvertImplicit): Handle decimal implicit numeric
31802 conversions as well.
31803 (Expression::InternalTypeConstructor): Used to invoke constructors
31804 on internal types for default promotions.
31806 (Unary::Emit): Implement special handling for the pre/post
31807 increment/decrement for overloaded operators, as they need to have
31808 the same semantics as the other operators.
31810 (Binary::ResolveOperator): ditto.
31811 (Invocation::ConversionExists): ditto.
31812 (UserImplicitCast::Resolve): ditto.
31814 2001-09-26 Ravi Pratap <ravi@ximian.com>
31816 * expression.cs (Unary::Emit and Binary::Emit): If we have an overloaded
31817 operator, return after emitting body. Regression tests pass again !
31819 * expression.cs (ConvertImplicit): Take TypeContainer as first argument
31820 (Unary::ForceConversion, Binary::ForceConversion): Ditto.
31821 (Invocation::OverloadResolve): Ditto.
31822 (Invocation::BetterFunction, BetterConversion, ConversionExists): Ditto.
31824 * everywhere : update calls to the above methods accordingly.
31826 2001-09-26 Miguel de Icaza <miguel@ximian.com>
31828 * assign.cs (Assign): Make it inherit from ExpressionStatement.
31830 * expression.cs (ExpressionStatement): New base class used for
31831 expressions that can appear in statements, so that we can provide
31832 an alternate path to generate expression that do not leave a value
31835 (Expression::Emit, and all the derivatives): We no longer return
31836 whether a value is left on the stack or not. Every expression
31837 after being emitted leaves a single value on the stack.
31839 * codegen.cs (EmitContext::EmitStatementExpression): Use the
31840 facilties of ExpressionStatement if possible.
31842 * cs-parser.jay: Update statement_expression.
31844 2001-09-25 Miguel de Icaza <miguel@ximian.com>
31846 * driver.cs: Change the wording of message
31848 2001-09-25 Ravi Pratap <ravi@ximian.com>
31850 * expression.cs (Binary::ResolveOperator): Had forgottten to set
31851 the type of the expression to the return type of the method if
31852 we have an overloaded operator match ! The regression tests pass again !
31853 (Unary::ResolveOperator): Ditto.
31855 * expression.cs (Invocation::ConversionExists): Correct the member lookup
31856 to find "op_Implicit", not "implicit" ;-)
31857 (UserImplicitCast): New class to take care of user-defined implicit conversions.
31858 (ConvertImplicit, ForceConversion): Take TypeContainer argument
31860 * everywhere : Correct calls to the above accordingly.
31862 * expression.cs (UserImplicitCast::Resolve, ::Emit): Implement.
31863 (ConvertImplicit): Do user-defined conversion if it exists.
31865 2001-09-24 Miguel de Icaza <miguel@ximian.com>
31867 * assign.cs: track location.
31868 (Resolve): Use implicit conversions on assignment.
31870 * literal.cs: Oops. Not good, Emit of short access values should
31871 pass (Bytes) or the wrong argument will be selected.
31873 * expression.cs (Unary::Emit): Emit code for -expr.
31875 (Unary::ResolveOperator): Handle `Substract' for non-constants
31876 (substract from zero from the non-constants).
31877 Deal with Doubles as well.
31879 (Expression::ConvertImplicitRequired): New routine that reports an
31880 error if no implicit conversion exists.
31882 (Invocation::OverloadResolve): Store the converted implicit
31883 expressions if we make them
31885 2001-09-24 Ravi Pratap <ravi@ximian.com>
31887 * class.cs (ConstructorInitializer): Take a Location argument.
31888 (ConstructorBaseInitializer): Same here.
31889 (ConstructorThisInitializer): Same here.
31891 * cs-parser.jay : Update all calls accordingly.
31893 * expression.cs (Unary, Binary, New): Take location argument.
31894 Update accordingly everywhere.
31896 * cs-parser.jay : Update all calls to the above to take a location
31899 * class.cs : Ditto.
31901 2001-09-24 Ravi Pratap <ravi@ximian.com>
31903 * expression.cs (Invocation::BetterFunction): Take TypeContainer argument
31904 (Invocation::BetterConversion): Same here
31905 (Invocation::ConversionExists): Ditto.
31907 (Invocation::ConversionExists): Implement.
31909 2001-09-22 Ravi Pratap <ravi@ximian.com>
31911 * expression.cs (OverloadResolve): Improve some more to catch errors 1502 and 1503
31912 Also take an additional TypeContainer argument.
31914 * All over : Pass in TypeContainer as argument to OverloadResolve.
31916 * typemanager.cs (CSharpName): Update to check for the string type and return
31919 * expression.cs (Invocation::FullMethodDesc): New static method to return a string fully describing
31922 2001-09-21 Ravi Pratap <ravi@ximian.com>
31924 * expression.cs (Invocation::OverloadResolve): Re-write to conform more to the spec.
31925 (Invocation::BetterFunction): Implement.
31926 (Invocation::BetterConversion): Implement.
31927 (Invocation::ConversionExists): Skeleton, no implementation yet.
31929 Okay, things work fine !
31931 2001-09-21 Miguel de Icaza <miguel@ximian.com>
31933 * typemanager.cs: declare and load enum_type, delegate_type and
31936 * expression.cs (Expression::Emit): Now emit returns a value that
31937 tells whether a value is left on the stack or not. This strategy
31938 might be reveted tomorrow with a mechanism that would address
31939 multiple assignments.
31940 (Expression::report118): Utility routine to report mismatches on
31943 (Unary::Report23): Report impossible type/operator combination
31946 (Unary::IsIncrementableNumber): Whether the type can be
31947 incremented or decremented with add.
31948 (Unary::ResolveOperator): Also allow enumerations to be bitwise
31950 (Unary::ResolveOperator): Implement ++, !, ~,
31952 (Invocation::Emit): Deal with new Emit convetion.
31954 * All Expression derivatives: Updated their Emit method to return
31955 whether they leave values on the stack or not.
31957 * codegen.cs (CodeGen::EmitStatement): Pop values left on the
31958 stack for expressions that are statements.
31960 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31962 * expression.cs (LValue): New interface. Must be implemented by
31964 (LocalVariableReference, ParameterReference, FieldExpr): Implement
31967 * assign.cs (Assign::Emit, Assign::Resolve): Use new LValue
31968 interface for generating code, simplifies the code.
31970 2001-09-20 Ravi Pratap <ravi@ximian.com>
31972 * expression.cs (everywhere): Comment out return statements in ::Resolve
31973 methods to avoid the warnings.
31975 2001-09-20 Miguel de Icaza <miguel@ximian.com>
31977 * driver.cs (parse): Report error 2001 if we can not open the
31980 * expression.cs (SimpleName::ResolveSimpleName): Error if we can
31983 * cs-parser.jay (QualifierIdentifier): Pass location to SimpleName
31986 * statement.cs (Block::EmitMeta): Reuse the count across all the variables,
31987 otherwise nested blocks end up with the same index.
31989 * codegen.cs (CodeGen::EmitTopBlock): Pass initial sequence
31991 * expression.cs: Instead of having FIXMEs in the Resolve
31992 functions, throw exceptions so it is obvious that we are facing a
31995 * cs-parser.jay (invocation_expression): Pass Location information.
31997 * codegen.cs (CodeGen::Save, CodeGen::CodeGen, CodeGen::Basename):
31998 Use a basename for those routines because .NET does not like paths
32001 * class.cs (TypeContainer::AddMethod): Do not call DefineName if the name was
32004 2001-09-19 Miguel de Icaza <miguel@ximian.com>
32006 * typemanager.cs (TypeManager::CoreLookupType): A function to make sure that we
32007 are loading the correct data types (throws an exception if not).
32008 (TypeManager::InitCoreTypes): Use CoreLookupType
32010 * expression.cs (Unary::ResolveOperator): return the child
32011 expression for expressions which are just +expr.
32012 (Unary::ResolveOperator): Return negative literals for -LITERAL
32013 expressions (otherwise they are Unary {Literal}).
32014 (Invocation::Badness): Take into account `Implicit constant
32015 expression conversions'.
32017 * literal.cs (LongLiteral): Implement long literal class.
32018 (IntLiteral): export the `Value' of the intliteral.
32020 2001-09-19 Ravi Pratap <ravi@ximian.com>
32022 * expression.cs (Binary::Emit): Finally get the emission right ! Woo!
32024 * class.cs (Operator::Define): Change the methodname prefix to 'op_'
32025 instead of 'Operator'
32027 * expression.cs (Binary::ResolveOperator): Update accordingly.
32028 (Unary::Operator): Change names to 'Add' and 'Subtract' instead 'Plus'
32031 * cs-parser.jay (unary_expression): Update to use the new names.
32033 * gen-treedump.cs (GetUnary): Same here.
32035 * expression.cs (Unary::Resolve): Implement.
32036 (Binary::ResolveOperator): Re-write bits to quietly continue if no overloaded
32037 operators are found instead of making noise ;-)
32038 (Unary::ResolveOperator): New method to do precisely the same thing which
32039 Binary::ResolveOperator does for Binary expressions.
32040 (Unary.method, .Arguments): Add.
32041 (Unary::OperName): Implement.
32042 (Unary::ForceConversion): Copy and Paste !
32044 * class.cs (Operator::Define): Fix a small bug for the case when we have
32047 * expression.cs (Unary::Emit): Implement. Need to find the right Opcodes
32048 for the inbuilt operators. Only overloading works for now ;-)
32050 2001-09-18 Miguel de Icaza <miguel@ximian.com>
32052 * expression.cs (CheckedExpr::Resolve, CheckedExpr::Emit,
32053 UnCheckedExpr::Resolve, UnCheckedExpr::Emit): Implement.
32055 * expression.cs (This::Emit): Implement.
32056 (This::Resolve): Implement.
32057 (TypeOf:Resolve): Implement.
32058 (Expression::ResolveSimpleName): Add an implicit this to instance
32060 (MemberAccess::Resolve): Deal with Parameters and Fields.
32061 Bind instance variable to Field expressions.
32062 (FieldExpr::Instance): New field used to track the expression that
32063 represents the object instance.
32064 (FieldExpr::Resolve): Track potential errors from MemberLookup not
32066 (FieldExpr::Emit): Implement.
32068 * codegen.cs (EmitIf, EmitStatement, EmitBlock): Propagate whether
32069 the last instruction contains a return opcode to avoid generating
32070 the last `ret' instruction (this generates correct code, and it is
32071 nice to pass the peverify output).
32073 * class.cs (TypeContainer::EmitFieldInitializers): Implement field
32074 initializer for static and instance variables.
32075 (Constructor::Emit): Allow initializer to be null in the case of
32076 static constructors. Only emit initializer for instance
32079 (TypeContainer::FindMembers): Return a null array if there are no
32082 Also fix the code for the MemberTypes.Method branch, as it was not
32083 scanning that for operators (or tried to access null variables before).
32085 * assign.cs (Assign::Emit): Handle instance and static fields.
32089 * driver.cs: Stop compilation if there are parse errors.
32091 * cs-parser.jay (constructor_declaration): Provide default base
32092 initializer for non-static constructors.
32093 (constructor_declarator): Do not provide a default base
32094 initializers if none was specified.
32095 Catch the fact that constructors should not have parameters.
32097 * class.cs: Do not emit parent class initializers for static
32098 constructors, that should be flagged as an error.
32100 2001-09-18 Ravi Pratap <ravi@ximian.com>
32102 * class.cs (RegisterMethodBuilder): Remove : it's unnecessary.
32103 Move back code into TypeContainer::Populate.
32105 2001-09-18 Ravi Pratap <ravi@ximian.com>
32107 * class.cs (TypeContainer::AddConstructor): Fix the check to
32108 compare against Name, not Basename.
32109 (Operator::OpType): Change Plus and Minus to Add and Subtract.
32111 * cs-parser.jay : Update accordingly.
32113 * class.cs (TypeContainer::FindMembers): For the case where we are searching
32114 for methods, don't forget to look into the operators too.
32115 (RegisterMethodBuilder): Helper method to take care of this for
32116 methods, constructors and operators.
32117 (Operator::Define): Completely revamp.
32118 (Operator.OperatorMethod, MethodName): New fields.
32119 (TypeContainer::Populate): Move the registering of builders into
32120 RegisterMethodBuilder.
32121 (Operator::Emit): Re-write.
32123 * expression.cs (Binary::Emit): Comment out code path to emit method
32124 invocation stuff for the case when we have a user defined operator. I am
32125 just not able to get it right !
32127 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32129 * expression.cs (Expression::OverloadResolve): Drop TypeContainer
32132 (Expression::MemberLookup): Provide a version that allows to
32133 specify the MemberTypes and BindingFlags.
32135 * statement.cs (Block::GetVariableInfo): Forgot to recurse here,
32136 so it was not fetching variable information from outer blocks.
32138 * modifiers.cs: (Modifiers::TypeAttr): Invert condition on
32139 Beforefieldinit as it was buggy.
32141 * rootcontext.cs (::LookupInterfaceOrClass): Removed an Error -200
32142 that Ravi put here.
32144 * class.cs (Constructor::Emit): Only emit if block is not null.
32145 (TypeContainer::EmitDefaultConstructor): Removed routine, now we
32146 deal with this by semantically definining it as if the user had
32149 (TypeContainer::FindMembers): Removed ad-hoc hack to deal with
32150 constructors as we now "emit" them at a higher level.
32152 (TypeContainer::DefineDefaultConstructor): Used to define the
32153 default constructors if none was provided.
32155 (ConstructorInitializer): Add methods Resolve and Emit.
32157 * expression.cs: Cast to ConstructorInfo instead of MethodInfo
32159 2001-09-17 Ravi Pratap <ravi@ximian.com>
32161 * class.cs (TypeContainer::EmitDefaultConstructor): Register
32162 the default constructor builder with our hashtable for methodbuilders
32165 * expression.cs (Invocation::OverloadResolve): Add a check for pd == null
32166 and argument_count is 0 in which case we have a match.
32167 (Binary::ResolveOperator): More null checking and miscellaneous coding
32170 2001-09-17 Ravi Pratap <ravi@ximian.com>
32172 * rootcontext.cs (IsNameSpace): Compare against null.
32174 * everywhere : Correct spelling to 'Greater' and to 'Subtract'
32176 * class.cs (Operator::OpType): Change names to match the ones in Binary::Operator
32177 and Unary::Operator.
32179 * cs-parser.jay (operator_declaration, CheckBinaryOperator, CheckUnaryOperator): Update
32182 * expression.cs (Binary::method): New member to hold the MethodBase for the case when
32183 we have overloaded operators.
32184 (Binary::ResolveOperator): Implement the part which does the operator overload
32187 * class.cs (Operator::Emit): Implement.
32188 (TypeContainer::Emit): Emit the operators we have too.
32190 * expression.cs (Binary::Emit): Update to emit the appropriate code for
32191 the case when we have a user-defined operator.
32193 2001-09-17 Miguel de Icaza <miguel@ximian.com>
32195 * rootcontext.cs: Fix bug: tree.Namespaces might be null.
32197 2001-09-16 Ravi Pratap <ravi@ximian.com>
32199 * class.cs (EmitStaticFieldInitializers, EmitFieldInitializers): Make public.
32200 (TypeContainer::EmitConstructor): Remove and move code into Contructor::Emit.
32201 (Constructor::Emit): Implement.
32202 (EmitStaticFieldInitializers, EmitFieldInitializers): Ensure we return immediately
32203 if we have no work to do.
32204 (TypeContainer::Emit): Pass in TypeContainer as argument to the constructor's
32207 * interface.cs (Interface::InterfaceAttr): Re-write to be more correct and complete.
32208 (Interface::IsTopLevel): Add. Same as TypeContainer::IsTopLevel.
32210 * class.cs (TypeContainer::IsTopLevel): Modify to use parent.Parent instead
32213 2001-09-15 Ravi Pratap <ravi@ximian.com>
32215 * tree.cs (Tree::namespaces): New hashtable to keep track of namespaces
32217 (Tree::RecordNamespace): Method to do what the name says ;-)
32218 (Tree::Namespaces): Property to get at the namespaces hashtable.
32220 * cs-parser.jay (namespace_declaration): Call RecordNamespace to
32223 * rootcontext.cs (IsNamespace): Fixed it :-)
32225 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32227 * class.cs (TypeContainer::FindMembers): Add support for
32229 (MethodCore): New class that encapsulates both the shared aspects
32230 of a Constructor and a Method.
32231 (Method, Constructor): Factored pieces into MethodCore.
32233 * driver.cs: Added --fatal which makes errors throw exceptions.
32234 Load System assembly as well as part of the standard library.
32236 * report.cs: Allow throwing exceptions on errors for debugging.
32238 * modifiers.cs: Do not use `parent', instead use the real type
32239 container to evaluate permission settings.
32241 * class.cs: Put Ravi's patch back in. He is right, and we will
32242 have to cope with the
32244 2001-09-14 Ravi Pratap <ravi@ximian.com>
32246 * modifiers.cs (TypeAttr, MethodAttr, FieldAttr): Map protected internal to
32247 FamORAssem, not FamANDAssem.
32249 2001-09-14 Miguel de Icaza <miguel@ximian.com>
32251 * driver.cs: Added --parse option that only parses its input files
32254 * class.cs: Reverted last change from Ravi to IsTopLevel. That is
32255 incorrect. IsTopLevel is not used to tell whether an object is
32256 root_types or not (that can be achieved by testing this ==
32257 root_types). But to see if this is a top-level *class* (not
32258 necessarly our "toplevel" container).
32260 2001-09-14 Ravi Pratap <ravi@ximian.com>
32262 * enum.cs (Enum::Define): Modify to call the Lookup method on the
32263 parent instead of a direct call to GetType.
32265 2001-09-14 Ravi Pratap <ravi@ximian.com>
32267 * class.cs (TypeContainer::TypeAttr): Remove property code and move it into
32268 Modifiers.TypeAttr. This should just be a call to that method.
32270 * modifiers.cs (TypeAttr): Re-write and take an extra argument, the TypeContainer
32271 object so that we can determine if we are top-level or not.
32273 * delegate.cs (Delegate::Define): Update call to TypeAttr method to pass in the
32276 * enum.cs (Enum::Define): Ditto.
32278 * modifiers.cs (FieldAttr): Re-write.
32280 * class.cs (TypeContainer::IsTopLevel): Change accessibility to public.
32281 (TypeContainer::HaveStaticConstructor): New property to provide access
32282 to precisely that info.
32284 * modifiers.cs (MethodAttr): Re-write.
32285 (EventAttr): Remove altogether as there seems to be no ostensible use for it.
32287 * class.cs (TypeContainer::IsTopLevel): Re-write. root_types doesn't seem to be the parent
32288 of top-level types as claimed.
32290 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32292 * expression.cs (MemberLookup): Fruitless attempt to lookup
32293 constructors. Maybe I need to emit default constructors? That
32294 might be it (currently .NET emits this for me automatically).
32295 (Invocation::OverloadResolve): Cope with Arguments == null.
32296 (Invocation::EmitArguments): new function, shared by the new
32297 constructor and us.
32298 (Invocation::Emit): Handle static and instance methods. Emit
32299 proper call instruction for virtual or non-virtual invocations.
32300 (New::Emit): Implement.
32301 (New::Resolve): Implement.
32302 (MemberAccess:Resolve): Implement.
32303 (MethodGroupExpr::InstanceExpression): used conforming to the spec
32304 to track instances.
32305 (FieldExpr::Resolve): Set type.
32307 * support.cs: Handle empty arguments.
32309 * cs-parser.jay (CompositeLookup, QualifierIdentifier,
32310 SimpleLookup): Auxiliary routines to help parse a qualifier
32313 Update qualifier_identifier rule.
32315 * codegen.cs: Removed debugging messages.
32317 * class.cs: Make this a global thing, this acts just as a "key" to
32318 objects that we might have around.
32320 (Populate): Only initialize method_builders_to_methods once.
32322 * expression.cs (PropertyExpr): Initialize type from the
32325 * codegen.cs (EmitContext::EmitBoolExpression): Use propper
32326 Resolve pattern. Attempt to implicitly convert value to boolean.
32329 * expression.cs: Set the type for the int32/int32 argument case.
32330 (Binary::ResolveOperator): Set the return type to boolean for
32331 comparission operators
32333 * typemanager.cs: Remove debugging print code.
32335 (Invocation::Resolve): resolve type.
32337 * class.cs: Allocate a MemberInfo of the correct size, as the code
32338 elsewhere depends on the test to reflect the correct contents.
32340 (Method::) Keep track of parameters, due to System.Reflection holes
32342 (TypeContainer::Populate): Keep track of MethodBuilders to Method
32345 (TypeContainer::FindMembers): Use ArrayList and then copy an array
32346 of the exact size and return that.
32348 (Class::LookupMethodByBuilder): New function that maps
32349 MethodBuilders to its methods. Required to locate the information
32350 on methods because System.Reflection bit us again.
32352 * support.cs: New file, contains an interface ParameterData and
32353 two implementations: ReflectionParameters and InternalParameters
32354 used to access Parameter information. We will need to grow this
32357 * expression.cs (Invocation::GetParameterData): implement a cache
32358 and a wrapper around the ParameterData creation for methods.
32359 (Invocation::OverloadResolve): Use new code.
32361 2001-09-13 Ravi Pratap <ravi@ximian.com>
32363 * class.cs (TypeContainer::EmitField): Remove and move into
32364 (Field::Define): here and modify accordingly.
32365 (Field.FieldBuilder): New member.
32366 (TypeContainer::Populate): Update accordingly.
32367 (TypeContainer::FindMembers): Implement.
32369 2001-09-13 Miguel de Icaza <miguel@ximian.com>
32371 * statement.cs: (VariableInfo::VariableType): New field to be
32372 initialized with the full type once it is resolved.
32374 2001-09-12 Miguel de Icaza <miguel@ximian.com>
32376 * parameter.cs (GetParameterInfo): Use a type cache to compute
32377 things only once, and to reuse this information
32379 * expression.cs (LocalVariableReference::Emit): Implement.
32380 (OpcodeCast::Emit): fix.
32382 (ParameterReference::Resolve): Implement.
32383 (ParameterReference::Emit): Implement.
32385 * cs-parser.jay: Fix bug introduced by Ravi, variable initializers
32386 that are expressions need to stay as Expressions.
32388 * typemanager.cs (CSharpName): Returns the C# name of a type if
32391 * expression.cs (Expression::ConvertImplicit): New function that
32392 implements implicit type conversions.
32394 (Expression::ImplicitReferenceConversion): Implements implicit
32395 reference conversions.
32397 (EmptyCast): New type for transparent casts.
32399 (OpcodeCast): New type for casts of types that are performed with
32400 a sequence of bytecodes.
32402 (BoxedCast): New type used for casting value types into reference
32403 types. Emits a box opcode.
32405 (Binary::DoNumericPromotions): Implements numeric promotions of
32406 and computation of the Binary::Type.
32408 (Binary::EmitBranchable): Optimization.
32410 (Binary::Emit): Implement code emission for expressions.
32412 * typemanager.cs (TypeManager): Added two new core types: sbyte
32415 2001-09-12 Ravi Pratap <ravi@ximian.com>
32417 * class.cs (TypeContainer::FindMembers): Method which does exactly
32418 what Type.FindMembers does, only we don't have to use reflection. No
32419 implementation yet.
32421 * typemanager.cs (typecontainers): New hashtable to hold the corresponding
32422 typecontainer objects as we need to get at them.
32423 (TypeManager::AddUserType): Overload to take an extra argument, the TypeContainer.
32425 * rootcontext.cs : Correspondingly modify called to AddUserType to pass the
32426 typecontainer object.
32428 * expression.cs (MemberLookup): Modify signature to take a RootContext object instead
32429 of just a Report object.
32431 2001-09-11 Ravi Pratap <ravi@ximian.com>
32433 * class.cs (Event::Define): Go back to using the prefixes "add_" and
32435 (TypeContainer::Populate): Now define the delegates of the type too.
32436 (TypeContainer.Delegates): Property to access the list of delegates defined
32439 * delegates.cs (Delegate::Define): Implement partially.
32441 * modifiers.cs (TypeAttr): Handle more flags.
32443 2001-09-11 Ravi Pratap <ravi@ximian.com>
32445 * class.cs (Indexer::Define): Fix for loop iteration condition to be just <
32447 (Operator::Define): Re-write logic to get types by using the LookupType method
32448 instead of blindly doing a Type.GetType ! How stupid can I get ;-) ?
32449 (Indexer::Define): Ditto.
32450 (Event::Define): Ditto.
32451 (Property::Define): Ditto.
32453 2001-09-10 Ravi Pratap <ravi@ximian.com>
32455 * class.cs (TypeContainer::Populate): Now define operators too.
32456 (TypeContainer.Operators): New property to access the list of operators
32458 (Operator.OperatorMethodBuilder): New member to hold the method builder
32459 for the operator we are defining.
32460 (Operator::Define): Implement.
32462 2001-09-10 Ravi Pratap <ravi@ximian.com>
32464 * class.cs (Event::Define): Make the prefixes of the accessor methods
32465 addOn_ and removeOn_
32467 * genericparser.cs (GenericParser::error): Overloaded method to handle the case
32468 of the location being passed in too. Ideally, this should go later since all
32469 error reporting should be done through the Report object.
32471 * class.cs (TypeContainer.Indexers): New property to access the list of indexers.
32472 (Populate): Iterate thru the indexers we have and define them too.
32473 (Indexer.GetMethodBuilder, .SetMethodBuilder): New members to hold the method builders
32474 for the get and set accessors.
32475 (Indexer::Define): Implement.
32477 2001-09-09 Miguel de Icaza <miguel@ximian.com>
32479 * expression.cs (Binary::Resolve): Beginning of it. I scratched
32480 my previous implementation, did not work.
32482 * typemanager.cs: Add a couple of missing types (the longs).
32484 * literal.cs: Use TypeManager.bool_type instead of getting it.
32486 * expression.cs (EventExpr): New kind of expressions.
32487 (Expressio::ExprClassFromMemberInfo): finish
32489 2001-09-08 Miguel de Icaza <miguel@ximian.com>
32491 * assign.cs: Emit stores to static fields differently.
32493 2001-09-08 Ravi Pratap <ravi@ximian.com>
32495 * Merge in changes and adjust code to tackle conflicts. Backed out my
32496 code in Assign::Resolve ;-)
32498 2001-09-08 Ravi Pratap <ravi@ximian.com>
32500 * cs-parser.jay (CheckAttributeTarget): Modify call to error to use
32501 instead Report.Error and also pass in the location.
32502 (CSharpParser::Lexer): New readonly property to return the reference
32503 to the Tokenizer object.
32504 (declare_local_variables): Use Report.Error with location instead of plain
32508 * class.cs (Operator::CheckUnaryOperator): Move into cs-parser.jay.
32509 (Operator.CheckBinaryOperator): Ditto.
32511 * cs-parser.jay (operator_declarator): Update accordingly.
32513 * cs-parser.jay (CheckUnaryOperator): Modify to use Report.Error
32514 (CheckBinaryOperator): Same here.
32516 * rootcontext.cs (LookupType): Add an extra lookup which simply does a lookup
32517 on the name without any prefixes of namespace names etc. This is because we
32518 already might have something already fully qualified like
32519 'System.Console.WriteLine'
32521 * assign.cs (Resolve): Begin implementation. Stuck ;-)
32523 2001-09-07 Ravi Pratap <ravi@ximian.com>
32525 * cs-tokenizer.cs (location): Return a string which also contains
32528 * expression.cs (ElementAccess): New class for expressions of the
32529 type 'element access.'
32530 (BaseAccess): New class for expressions of the type 'base access.'
32531 (CheckedExpr, UnCheckedExpr): New classes for Checked and Unchecked expressions
32534 * cs-parser.jay (element_access): Implement action.
32535 (base_access): Implement actions.
32536 (checked_expression, unchecked_expression): Implement.
32538 * cs-parser.jay (local_variable_type): Correct and implement.
32539 (type_suffixes, type_suffix_list, type_suffix): Implement actions.
32541 * cs-tokenizer.cs (real_type_suffix): Comment out the extra getchar.
32543 * cs-parser.jay (rank_specifiers): Remove space while concatenating the type's
32544 name and the specifiers.
32546 * interface.cs (InterfaceAttr): New property to return the corresponding TypeAttributes
32548 * rootcontext.cs (CreateInterface): Use the InterfaceAttr property instead of
32549 making them all public ;-)
32551 * cs-parser.jay (error): Remove entirely as we have an implementation in the base
32554 2001-09-07 Miguel de Icaza <miguel@ximian.com>
32556 * expression.cs (ExprClassFromMemberInfo): Return FieldExpr and
32558 (FieldExpr, PropertyExprs): New resolved expressions.
32559 (SimpleName::MemberStaticCheck): Perform static checks for access
32560 to non-static fields on static methods. Maybe this should be
32561 generalized for MemberAccesses.
32562 (SimpleName::ResolveSimpleName): More work on simple name
32565 * cs-parser.jay (primary_expression/qualified_identifier): track
32566 the parameter index.
32568 * codegen.cs (CodeGen::Save): Catch save exception, report error.
32569 (EmitContext::EmitBoolExpression): Chain to expression generation
32570 instead of temporary hack.
32571 (::EmitStatementExpression): Put generic expression code generation.
32573 * assign.cs (Assign::Emit): Implement variable assignments to
32574 local variables, parameters and fields.
32576 2001-09-06 Miguel de Icaza <miguel@ximian.com>
32578 * statement.cs (Block::GetVariableInfo): New method, returns the
32579 VariableInfo for a variable name in a block.
32580 (Block::GetVariableType): Implement in terms of GetVariableInfo
32582 * literal.cs (IntLiteral::Emit, FloatLiteral::Emit,
32583 DoubleLiteral::Emit, CharLiteral::Emit, BoolLiteral::Emit): Implement
32585 2001-09-06 Ravi Pratap <ravi@ximian.com>
32587 * cs-parser.jay (operator_declaration): Continue on my quest : update
32588 to take attributes argument.
32589 (event_declaration): Ditto.
32590 (enum_declaration): Ditto.
32591 (indexer_declaration): Ditto.
32593 * class.cs (Operator::Operator): Update constructor accordingly.
32594 (Event::Event): Ditto.
32596 * delegate.cs (Delegate::Delegate): Same here.
32598 * enum.cs (Enum::Enum): Same here.
32600 2001-09-05 Ravi Pratap <ravi@ximian.com>
32602 * cs-parser.jay (CheckAttributeTarget): Update to use the right error number.
32604 * ../tests/cs0658.cs : New file to demonstrate error 0658.
32606 * attribute.cs (Attributes): New class to encapsulate all attributes which were
32607 being passed around as an arraylist.
32608 (Attributes::AddAttribute): Method to add attribute sections.
32610 * cs-parser.jay (opt_attributes): Modify actions to use the new Attributes class.
32611 (struct_declaration): Update accordingly.
32612 (constant_declaration): Update.
32613 (field_declaration): Update.
32614 (method_header): Update.
32615 (fixed_parameter): Update.
32616 (parameter_array): Ditto.
32617 (property_declaration): Ditto.
32618 (destructor_declaration): Ditto.
32620 * class.cs (Struct::Struct): Update constructors accordingly.
32621 (Class::Class): Ditto.
32622 (Field::Field): Ditto.
32623 (Method::Method): Ditto.
32624 (Property::Property): Ditto.
32625 (TypeContainer::OptAttribute): update property's return type.
32627 * interface.cs (Interface.opt_attributes): New member.
32628 (Interface::Interface): Update to take the extra Attributes argument.
32630 * parameter.cs (Parameter::Parameter): Ditto.
32632 * constant.cs (Constant::Constant): Ditto.
32634 * interface.cs (InterfaceMemberBase): New OptAttributes field.
32635 (InterfaceMemberBase::InterfaceMemberBase): Update constructor to take
32636 the attributes as a parameter.
32637 (InterfaceProperty): Update constructor call.
32638 (InterfaceEvent): Ditto.
32639 (InterfaceMethod): Ditto.
32640 (InterfaceIndexer): Ditto.
32642 * cs-parser.jay (interface_indexer_declaration): Update call to constructor to
32643 pass the attributes too.
32644 (interface_event_declaration): Ditto.
32645 (interface_property_declaration): Ditto.
32646 (interface_method_declaration): Ditto.
32647 (interface_declaration): Ditto.
32649 2001-09-05 Miguel de Icaza <miguel@ximian.com>
32651 * class.cs (Method::Define): Track the "static Main" definition to
32652 create an entry point.
32654 * rootcontext.cs (RootContext::EntryPoint): MethodInfo that holds the
32655 EntryPoint if we find it.
32657 * codegen.cs (EmitContext::EmitInvocation): Emit invocations.
32658 (EmitContext::ig): Make this variable public.
32660 * driver.cs: Make the default output file be the first file name
32661 with the .exe extension.
32663 Detect empty compilations
32665 Handle various kinds of output targets. Handle --target and
32666 rename -t to --dumper.
32668 * expression.cs, literal.cs, assign.cs, constant.cs: All `Resolve'
32669 methods inherited from Expression return now an Expression. This
32670 will is used during the tree rewriting as we resolve them during
32673 (Expression::MemberLookup): Implements the MemberLookup (7.3) from
32674 the spec. Missing entirely is the information about
32675 accessability of elements of it.
32677 (Expression::ExprClassFromMemberInfo): New constructor for
32678 Expressions that creates a fully initialized Expression based on
32679 a MemberInfo that is one of Eventinfo, FieldINfo, PropertyInfo or
32682 (Invocation::Resolve): Begin implementing resolution of invocations.
32684 * literal.cs (StringLiteral): Implement Emit.
32686 2001-09-05 Ravi Pratap <ravi@ximian.com>
32688 * cs-parser.jay (error): Add new modifier because we are hiding an inherited
32691 2001-09-04 Ravi Pratap <ravi@ximian.com>
32693 * cs-parser.jay (attribute_arguments): Implement actions.
32694 (attribute): Fix bug in production. Implement action.
32695 (attribute_list): Implement.
32696 (attribute_target): Implement.
32697 (attribute_target_specifier, opt_target_specifier): Implement
32698 (CheckAttributeTarget): New method to check if the attribute target
32700 (attribute_section): Implement.
32701 (opt_attributes): Implement.
32703 * attribute.cs : New file to handle attributes.
32704 (Attribute): Class to hold attribute info.
32706 * cs-parser.jay (opt_attribute_target_specifier): Remove production
32707 (attribute_section): Modify production to use 2 different rules to
32708 achieve the same thing. 1 s/r conflict down !
32709 Clean out commented, useless, non-reducing dimension_separator rules.
32711 * class.cs (TypeContainer.attributes): New member to hold list
32712 of attributes for a type.
32713 (Struct::Struct): Modify to take one more argument, the attribute list.
32714 (Class::Class): Ditto.
32715 (Field::Field): Ditto.
32716 (Method::Method): Ditto.
32717 (Property::Property): Ditto.
32719 * cs-parser.jay (struct_declaration): Update constructor call to
32720 pass in the attributes too.
32721 (class_declaration): Ditto.
32722 (constant_declaration): Ditto.
32723 (field_declaration): Ditto.
32724 (method_header): Ditto.
32725 (fixed_parameter): Ditto.
32726 (parameter_array): Ditto.
32727 (property_declaration): Ditto.
32729 * constant.cs (Constant::Constant): Update constructor similarly.
32730 Use System.Collections.
32732 * parameter.cs (Parameter::Parameter): Update as above.
32734 2001-09-02 Ravi Pratap <ravi@ximian.com>
32736 * class.cs (TypeContainer::AddDelegate): New method to add a delegate.
32737 (TypeContainer.delegates): New member to hold list of delegates.
32739 * cs-parser.jay (delegate_declaration): Implement the action correctly
32740 this time as I seem to be on crack ;-)
32742 2001-09-02 Miguel de Icaza <miguel@ximian.com>
32744 * rootcontext.cs (RootContext::IsNamespace): new function, used to
32745 tell whether an identifier represents a namespace.
32747 * expression.cs (NamespaceExpr): A namespace expression, used only
32748 temporarly during expression resolution.
32749 (Expression::ResolveSimpleName, ::ResolvePrimary, ::ResolveName):
32750 utility functions to resolve names on expressions.
32752 2001-09-01 Miguel de Icaza <miguel@ximian.com>
32754 * codegen.cs: Add hook for StatementExpressions.
32756 * class.cs: Fix inverted test for static flag in methods.
32758 2001-09-02 Ravi Pratap <ravi@ximian.com>
32760 * class.cs (Operator::CheckUnaryOperator): Correct error number used
32761 to make it coincide with MS' number.
32762 (Operator::CheckBinaryOperator): Ditto.
32764 * ../errors/errors.txt : Remove error numbers added earlier.
32766 * ../errors/cs1019.cs : Test case for error # 1019
32768 * ../errros/cs1020.cs : Test case for error # 1020
32770 * cs-parser.jay : Clean out commented cruft.
32771 (dimension_separators, dimension_separator): Comment out. Ostensibly not
32772 used anywhere - non-reducing rule.
32773 (namespace_declarations): Non-reducing rule - comment out.
32775 * enum.cs (Enum::AddEnum): Rename to AddEnumMember as I was getting confused
32776 with TypeContainer::AddEnum.
32778 * delegate.cs : New file for delegate handling classes.
32779 (Delegate): Class for declaring delegates.
32781 * makefile : Update.
32783 * cs-parser.jay (delegate_declaration): Implement.
32785 2001-09-01 Ravi Pratap <ravi@che.iitm.ac.in>
32787 * class.cs (Event::Define): Implement.
32788 (Event.EventBuilder): New member.
32790 * class.cs (TypeContainer::Populate): Update to define all enums and events
32792 (Events): New property for the events arraylist we hold. Shouldn't we move to using
32793 readonly fields for all these cases ?
32795 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32797 * class.cs (Property): Revamp to use the convention of making fields readonly.
32798 Accordingly modify code elsewhere.
32800 * class.cs : Apply patch from Mr. Mandar <go_mono@hotmail.com> for implementing
32801 the Define method of the Property class.
32803 * class.cs : Clean up applied patch and update references to variables etc. Fix
32805 (TypeContainer::Populate): Update to define all the properties we have. Also
32806 define all enumerations.
32808 * enum.cs (Define): Implement.
32810 2001-08-31 Ravi Pratap <ravi@che.iitm.ac.in>
32812 * cs-parser.jay (overloadable_operator): The semantic value is an
32813 enum of the Operator class.
32814 (operator_declarator): Implement actions.
32815 (operator_declaration): Implement.
32817 * class.cs (Operator::CheckUnaryOperator): New static method to help in checking
32818 validity of definitions.
32819 (Operator::CheckBinaryOperator): Static method to check for binary operators
32820 (TypeContainer::AddOperator): New method to add an operator to a type.
32822 * cs-parser.jay (indexer_declaration): Added line to actually call the
32823 AddIndexer method so it gets added ;-)
32825 * ../errors/errors.txt : Update to include new error numbers. Are these numbers
32826 already taken care of by the MS compiler ?
32828 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32830 * class.cs (Operator): New class for operator declarations.
32831 (Operator::OpType): Enum for the various operators.
32833 2001-08-29 Ravi Pratap <ravi@che.iitm.ac.in>
32835 * class.cs (TypeContainer::AddIndexer): Remove FIXME comment. We
32836 ostensibly handle this in semantic analysis.
32838 * cs-parser.jay (general_catch_clause): Comment out
32839 (specific_catch_clauses, specific_catch_clause): Ditto.
32840 (opt_general_catch_clause, opt_specific_catch_clauses): Ditto
32841 (catch_args, opt_catch_args): New productions.
32842 (catch_clause): Rewrite to use the new productions above
32843 (catch_clauses): Modify accordingly.
32844 (opt_catch_clauses): New production to use in try_statement
32845 (try_statement): Revamp. Basically, we get rid of one unnecessary rule
32846 and re-write the code in the actions to extract the specific and
32847 general catch clauses by being a little smart ;-)
32849 * ../tests/try.cs : Fix. It's not 'finalize' my friend, it's 'finally' !
32850 Hooray, try and catch statements parse fine !
32852 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32854 * statement.cs (Block::GetVariableType): Fix logic to extract the type
32855 string from the hashtable of variables.
32857 * cs-parser.jay (event_accessor_declarations): Trivial fix. Man, how did
32858 I end up making that mistake ;-)
32859 (catch_clauses): Fixed gross error which made Key and Value of the
32860 DictionaryEntry the same : $1 !!
32862 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32864 * cs-tokenizer.cs (initTokens): Add keywords 'add' and 'remove'
32866 * cs-parser.jay (event_declaration): Correct to remove the semicolon
32867 when the add and remove accessors are specified.
32869 2001-08-28 Ravi Pratap <ravi@che.iitm.ac.in>
32871 * cs-parser.jay (IndexerDeclaration): New helper class to hold
32872 information about indexer_declarator.
32873 (indexer_declarator): Implement actions.
32874 (parsing_indexer): New local boolean used to keep track of whether
32875 we are parsing indexers or properties. This is necessary because
32876 implicit_parameters come into picture even for the get accessor in the
32877 case of an indexer.
32878 (get_accessor_declaration, set_accessor_declaration): Correspondingly modified.
32880 * class.cs (Indexer): New class for indexer declarations.
32881 (TypeContainer::AddIndexer): New method to add an indexer to a type.
32882 (TypeContainer::indexers): New member to hold list of indexers for the
32885 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32887 * cs-parser.jay (add_accessor_declaration): Implement action.
32888 (remove_accessor_declaration): Implement action.
32889 (event_accessors_declaration): Implement
32890 (variable_declarators): swap statements for first rule - trivial.
32892 * class.cs (Event): New class to hold information about event
32894 (TypeContainer::AddEvent): New method to add an event to a type
32895 (TypeContainer::events): New member to hold list of events.
32897 * cs-parser.jay (event_declaration): Implement actions.
32899 2001-08-27 Ravi Pratap <ravi@che.iitm.ac.in>
32901 * cs-parser.jay (dim_separators): Implement. Make it a string
32902 concatenating all the commas together, just as they appear.
32903 (opt_dim_separators): Modify accordingly
32904 (rank_specifiers): Update accordingly. Basically do the same
32905 thing - instead, collect the brackets here.
32906 (opt_rank_sepcifiers): Modify accordingly.
32907 (array_type): Modify to actually return the complete type string
32908 instead of ignoring the rank_specifiers.
32909 (expression_list): Implement to collect the expressions
32910 (variable_initializer): Implement. We make it a list of expressions
32911 essentially so that we can handle the array_initializer case neatly too.
32912 (variable_initializer_list): Implement.
32913 (array_initializer): Make it a list of variable_initializers
32914 (opt_array_initializer): Modify accordingly.
32916 * expression.cs (New::NType): Add enumeration to help us
32917 keep track of whether we have an object/delegate creation
32918 or an array creation.
32919 (New:NewType, New::Rank, New::Indices, New::Initializers): New
32920 members to hold data about array creation.
32921 (New:New): Modify to update NewType
32922 (New:New): New Overloaded contructor for the array creation
32925 * cs-parser.jay (array_creation_expression): Implement to call
32926 the overloaded New constructor.
32928 2001-08-26 Ravi Pratap <ravi@che.iitm.ac.in>
32930 * class.cs (TypeContainer::Constructors): Return member
32931 constructors instead of returning null.
32933 2001-08-26 Miguel de Icaza <miguel@ximian.com>
32935 * typemanager.cs (InitCoreTypes): Initialize the various core
32936 types after we have populated the type manager with the user
32937 defined types (this distinction will be important later while
32938 compiling corlib.dll)
32940 * expression.cs, literal.cs, assign.cs, constant.cs: Started work
32941 on Expression Classification. Now all expressions have a method
32942 `Resolve' and a method `Emit'.
32944 * codegen.cs, cs-parser.jay: Fixed the bug that stopped code
32945 generation from working. Also add some temporary debugging
32948 2001-08-24 Miguel de Icaza <miguel@ximian.com>
32950 * codegen.cs: Lots of code generation pieces. This is only the
32951 beginning, will continue tomorrow with more touches of polish. We
32952 handle the fundamentals of if, while, do, for, return. Others are
32953 trickier and I need to start working on invocations soon.
32955 * gen-treedump.cs: Bug fix, use s.Increment here instead of
32958 * codegen.cs (EmitContext): New struct, used during code
32959 emission to keep a context. Most of the code generation will be
32962 * cs-parser.jay: Add embedded blocks to the list of statements of
32963 this block. So code generation proceeds in a top down fashion.
32965 2001-08-23 Miguel de Icaza <miguel@ximian.com>
32967 * statement.cs: Add support for multiple child blocks.
32969 2001-08-22 Miguel de Icaza <miguel@ximian.com>
32971 * codegen.cs (EmitCode): New function, will emit the code for a
32972 Block of code given a TypeContainer and its ILGenerator.
32974 * statement.cs (Block): Standard public readonly optimization.
32975 (Block::Block constructors): Link children.
32976 (Block::Child): Child Linker.
32977 (Block::EmitVariables): Emits IL variable declarations.
32979 * class.cs: Drop support for MethodGroups here, delay until
32981 (Method::): Applied the same simplification that I did before, and
32982 move from Properties to public readonly fields.
32983 (Method::ParameterTypes): Returns the parameter types for the
32984 function, and implements a cache that will be useful later when I
32985 do error checking and the semantic analysis on the methods is
32987 (Constructor::GetCallingConvention): Renamed from CallingConvetion
32988 and made a method, optional argument tells whether this is a class
32989 or a structure to apply the `has-this' bit.
32990 (Method::GetCallingConvention): Implement, returns the calling
32992 (Method::Define): Defines the type, a second pass is performed
32993 later to populate the methods.
32995 (Constructor::ParameterTypes): implement a cache similar to the
32996 one on Method::ParameterTypes, useful later when we do semantic
32999 (TypeContainer::EmitMethod): New method. Emits methods.
33001 * expression.cs: Removed MethodGroup class from here.
33003 * parameter.cs (Parameters::GetCallingConvention): new method.
33005 2001-08-21 Miguel de Icaza <miguel@ximian.com>
33007 * class.cs (TypeContainer::Populate): Drop RootContext from the
33010 (Constructor::CallingConvention): Returns the calling convention.
33011 (Constructor::ParameterTypes): Returns the constructor parameter
33014 (TypeContainer::AddConstructor): Keep track of default constructor
33015 and the default static constructor.
33017 (Constructor::) Another class that starts using `public readonly'
33018 instead of properties.
33020 (Constructor::IsDefault): Whether this is a default constructor.
33022 (Field::) use readonly public fields instead of properties also.
33024 (TypeContainer::TypeAttr, TypeContainer::AddConstructor): Keep
33025 track of static constructors; If none is used, turn on
33026 BeforeFieldInit in the TypeAttributes.
33028 * cs-parser.jay (opt_argument_list): now the return can be null
33029 for the cases where there are no arguments.
33031 (constructor_declarator): If there is no implicit `base' or
33032 `this', then invoke the default parent constructor.
33034 * modifiers.cs (MethodAttr): New static function maps a set of
33035 modifiers flags into a MethodAttributes enum
33036 (FieldAttr): renamed from `Map'. So now we have FieldAttr,
33037 MethodAttr, TypeAttr to represent the various mappings where the
33038 modifiers are used.
33039 (FieldAttr): Map also `readonly' to `FieldAttributes.InitOnly'
33041 2001-08-19 Miguel de Icaza <miguel@ximian.com>
33043 * parameter.cs (GetParameterInfo): Fix bug where there would be no
33046 * interface.cs (PopulateIndexer): Implemented the code generator
33047 for interface indexers.
33049 2001-08-17 Miguel de Icaza <miguel@ximian.com>
33051 * interface.cs (InterfaceMemberBase): Now we track the new status
33054 (PopulateProperty): Implement property population. Woohoo! Got
33055 Methods and Properties going today.
33057 Removed all the properties for interfaces, and replaced them with
33058 `public readonly' fields.
33060 2001-08-16 Miguel de Icaza <miguel@ximian.com>
33062 * interface.cs (AddEvent, AddMethod, AddIndexer, AddProperty):
33063 initialize their hashtables/arraylists only when they are needed
33064 instead of doing this always.
33066 * parameter.cs: Handle refs and out parameters.
33068 * cs-parser.jay: Use an ArrayList to construct the arguments
33069 instead of the ParameterCollection, and then cast that to a
33072 * parameter.cs: Drop the use of ParameterCollection and use
33073 instead arrays of Parameters.
33075 (GetParameterInfo): Use the Type, not the Name when resolving
33078 2001-08-13 Miguel de Icaza <miguel@ximian.com>
33080 * parameter.cs: Eliminate the properties Name, Type and ModFlags,
33081 and instead use public readonly fields.
33083 * class.cs: Put back walking code for type containers.
33085 2001-08-11 Miguel de Icaza <miguel@ximian.com>
33087 * class.cs (MakeConstant): Code to define constants.
33089 * rootcontext.cs (LookupType): New function. Used to locate types
33092 2001-08-08 Miguel de Icaza <miguel@ximian.com>
33094 * rootcontext.cs: OH MY! My trick works! It is amazing how nice
33095 this System.Reflection code is. Kudos to Microsoft
33097 * typemanager.cs: Implement a type cache and avoid loading all
33098 types at boot time. Wrap in LookupType the internals. This made
33099 the compiler so much faster. Wow. I rule!
33101 * driver.cs: Make sure we always load mscorlib first (for
33102 debugging purposes, nothing really important).
33104 * Renamespaced things that were on `CSC' to `CIR'. Maybe I should
33105 have moved to `CSC' rather than `CIR'. Oh man! The confussion!
33107 * rootcontext.cs: Lookup types on their namespace; Lookup types
33108 on namespaces that have been imported using the `using' keyword.
33110 * class.cs (TypeContainer::TypeAttr): Virtualize.
33111 (Class::TypeAttr): Return attributes suitable for this bad boy.
33112 (Struct::TypeAttr): ditto.
33113 Handle nested classes.
33114 (TypeContainer::) Remove all the type visiting code, it is now
33115 replaced with the rootcontext.cs code
33117 * rootcontext.cs (GetClassBases): Added support for structs.
33119 2001-08-06 Miguel de Icaza <miguel@ximian.com>
33121 * interface.cs, statement.cs, class.cs, parameter.cs,
33122 rootcontext.cs, gen-treedump.cs, enum.cs, cs-parse.jay:
33123 Drop use of TypeRefs, and use strings instead.
33125 2001-08-04 Miguel de Icaza <miguel@ximian.com>
33129 * class.cs (Struct::Struct): set the SEALED flags after
33130 checking the modifiers.
33131 (TypeContainer::TypeAttr): new property, returns the
33132 TypeAttributes for a class.
33134 * cs-parser.jay (type_list): Oops, list production was creating a
33135 new list of base types.
33137 * rootcontext.cs (StdLib): New property.
33138 (GetInterfaceTypeByName): returns an interface by type name, and
33139 encapsulates error handling here.
33140 (GetInterfaces): simplified.
33141 (ResolveTree): Encapsulated all the tree resolution here.
33142 (CreateClass, GetClassBases, GetInterfaceOrClass): Create class
33145 * driver.cs: Add support for --nostdlib, to avoid loading the
33146 default assemblies.
33147 (Main): Do not put tree resolution here.
33149 * rootcontext.cs: Beginning of the class resolution.
33151 2001-08-03 Miguel de Icaza <miguel@ximian.com>
33153 * rootcontext.cs: Provide better error reporting.
33155 * cs-parser.jay (interface_base): set our $$ to be interfaces.
33157 * rootcontext.cs (CreateInterface): Handle the case where there
33158 are no parent interfaces.
33160 (CloseTypes): Routine to flush types at the end.
33161 (CreateInterface): Track types.
33162 (GetInterfaces): Returns an array of Types from the list of
33163 defined interfaces.
33165 * typemanager.c (AddUserType): Mechanism to track user types (puts
33166 the type on the global type hash, and allows us to close it at the
33169 2001-08-02 Miguel de Icaza <miguel@ximian.com>
33171 * tree.cs: Removed RecordType, added RecordClass, RecordStruct and
33172 RecordInterface instead.
33174 * cs-parser.jay: Updated to reflect changes above.
33176 * decl.cs (Definition): Keep track of the TypeBuilder type that
33177 represents this type here. Not sure we will use it in the long
33178 run, but wont hurt for now.
33180 * driver.cs: Smaller changes to accomodate the new code.
33182 Call ResolveInterfaceBases, Call ResolveClassBases, Save assembly
33185 * rootcontext.cs (CreateInterface): New method, used to create
33186 the System.TypeBuilder type for interfaces.
33187 (ResolveInterfaces): new entry point to resolve the interface
33189 (CodeGen): Property, used to keep track of the code generator.
33191 2001-07-26 Miguel de Icaza <miguel@ximian.com>
33193 * cs-parser.jay: Add a second production for delegate_declaration
33196 (enum_body): Put an opt_comma here instead of putting it on
33197 enum_body or enum_member_declarations so we can handle trailing
33198 commas on enumeration members. Gets rid of a shift/reduce.
33200 (type_list): Need a COMMA in the middle.
33202 (indexer_declaration): Tell tokenizer to recognize get/set
33204 * Remove old targets.
33206 * Re-add the parser target.
33208 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33210 * cs-parser.jay: Add precendence rules for a number of operators
33211 ot reduce the number of shift/reduce conflicts in the grammar.
33213 2001-07-17 Miguel de Icaza <miguel@ximian.com>
33215 * tree.cs: moved IGenerator interface and renamed it to ITreeDump
33218 Get rid of old crufty code.
33220 * rootcontext.cs: Use this to keep track of the parsed
33221 representation and the defined types available to the program.
33223 * gen-treedump.cs: adjust for new convention.
33225 * type.cs: Split out the type manager, and the assembly builder
33228 * typemanager.cs: the type manager will live here now.
33230 * cil-codegen.cs: And the code generator here.
33232 2001-07-14 Sean MacIsaac <macisaac@ximian.com>
33234 * makefile: Fixed up for easy making.
33236 2001-07-13 Simon Cozens <simon@simon-cozens.org>
33238 * cs-parser.jay (rank_specifier): Remove a conflict by reordering
33241 (unary_expression): Expand pre_increment_expression and
33242 post_decrement_expression to reduce a shift/reduce.
33244 2001-07-11 Simon Cozens
33246 * cs-tokenizer.cs: Hex numbers should begin with a 0.
33248 Improve allow_keyword_as_indent name.
33250 2001-06-19 Miguel de Icaza <miguel@ximian.com>
33252 * Adjustments for Beta2.
33254 2001-06-13 Miguel de Icaza <miguel@ximian.com>
33256 * decl.cs: Added `Define' abstract method.
33257 (InTransit): new property, used to catch recursive definitions.
33259 * interface.cs: Implement `Define'.
33261 * modifiers.cs: Map Modifiers.constants to
33262 System.Reflection.TypeAttribute flags.
33264 * class.cs: Keep track of types and user-defined types.
33265 (BuilderInit): New method for creating an assembly
33266 (ResolveType): New function to launch the resolution process, only
33267 used by interfaces for now.
33269 * cs-parser.jay: Keep track of Classes, Structs and Interfaces
33270 that are inserted into the name space.
33272 2001-06-08 Miguel de Icaza <miguel@ximian.com>
33274 * ARGH. I have screwed up my tree so many times due to the use of
33275 rsync rather than using CVS. Going to fix this at once.
33277 * driver.cs: Objetify driver. Load assemblies, use assemblies to
33280 2001-06-07 Miguel de Icaza <miguel@ximian.com>
33282 * Experiment successful: Use System.Type rather that our own
33285 2001-05-25 Miguel de Icaza <miguel@ximian.com>
33287 * cs-parser.jay: Removed nsAliases from here.
33289 Use new namespaces, handle `using XXX;'
33291 * namespace.cs: Reimplemented namespace handling, use a recursive
33292 definition of the class. Now we can keep track of using clauses
33293 and catch invalid using clauses.
33295 2001-05-24 Miguel de Icaza <miguel@ximian.com>
33297 * gen-treedump.cs: Adapted for all the renaming.
33299 * expression.cs (Expression): this class now has a Type property
33300 which returns an expression Type.
33302 (Probe::, New::, TypeOf::, SizeOf::, Constant::): renamed from
33303 `Type', as this has a different meaning now in the base
33305 2001-05-22 Miguel de Icaza <miguel@ximian.com>
33307 * interface.cs, class.cs: Removed from all the sources the
33308 references to signature computation, as we can not do method
33309 signature computation during the parsing time, as we are not
33310 trying to solve at that point distinguishing:
33314 void a (NS.Blah x) {}
33317 Which depending on the context might be valid or not, as we do not
33318 know if Blah is the same thing as NS.Blah at that point.
33320 * Redid everything so the code uses TypeRefs now instead of
33321 Types. TypeRefs are just temporary type placeholders, that need
33322 to be resolved. They initially have a pointer to a string and the
33323 current scope in which they are used. This is used later by the
33324 compiler to resolve the reference to an actual Type.
33326 * DeclSpace is no longer a CIR.Type, and neither are
33327 TypeContainers (Class and Struct) nor Interfaces nor Enums. They
33328 are all DeclSpaces, but no Types.
33330 * type.cs (TypeRefManager): This implements the TypeRef manager,
33331 which keeps track of all the types that need to be resolved after
33332 the parsing has finished.
33334 2001-05-13 Miguel de Icaza <miguel@ximian.com>
33336 * ARGH. We are going to have to store `foreach' as a class rather
33337 than resolving it, as we need to verify error 1579 after name
33338 resolution. *OR* we could keep a flag that says `This request to
33339 IEnumerator comes from a foreach statement' which we can then use
33340 to generate the error.
33342 2001-05-10 Miguel de Icaza <miguel@ximian.com>
33344 * class.cs (TypeContainer.AddMethod): we now add methods to the
33345 MethodGroup instead of the method hashtable.
33347 * expression.cs: Add MethodGroup abstraction, which gets us one
33348 step closer to the specification in the way we handle method
33351 * cs-parser.jay (primary_expression): qualified_identifier now
33352 tried to match up an identifier to a local variable reference or
33353 to a parameter reference.
33355 current_local_parameters is now a parser global variable that
33356 points to the current parameters for the block, used during name
33359 (property_declaration): Now creates an implicit `value' argument to
33362 2001-05-09 Miguel de Icaza <miguel@ximian.com>
33364 * parameter.cs: Do not use `param' arguments as part of the
33365 signature, per the spec.
33367 2001-05-08 Miguel de Icaza <miguel@ximian.com>
33369 * decl.cs: Base class for classes, structs and interfaces. This
33370 is the "Declaration Space"
33372 * cs-parser.jay: Use CheckDef for checking declaration errors
33373 instead of having one on each function.
33375 * class.cs: Factor out some code for handling error handling in
33376 accordance to the "Declarations" section in the "Basic Concepts"
33377 chapter in the ECMA C# spec.
33379 * interface.cs: Make all interface member classes derive from
33380 InterfaceMemberBase.
33382 2001-05-07 Miguel de Icaza <miguel@ximian.com>
33384 * Many things: all interfaces are parsed and generated in
33385 gen-treedump. Support for member variables, constructors,
33386 destructors, properties, constants is there.
33388 Beginning of the IL backend, but very little done, just there for
33391 2001-04-29 Miguel de Icaza <miguel@ximian.com>
33393 * cs-parser.jay: Fix labeled statement.
33395 * cs-tokenizer.cs (escape): Escape " and ' always.
33396 ref_line, ref_name: keep track of the line/filename as instructed
33397 by #line by the compiler.
33400 2001-04-27 Miguel de Icaza <miguel@ximian.com>
33402 * System.CodeDOM/CodeBinaryOperatorExpression.cs: Rearrange enum
33403 to match the values in System.CodeDOM.
33405 Divid renamed to Divide.
33407 * System.CodeDOM/CodeForLoopStatement.cs: Always have valid
33409 (Statements.set): remove.
33411 * System.CodeDOM/CodeCatchClause.cs: always have a valid
33414 * System.CodeDOM/CodeIfStatement.cs: trueStatements and
33415 falseStatements always have valid values.
33417 * cs-parser.jay: Use System.CodeDOM now.