| commit | ed421a64825501e0bdfe848c9decf05d270a9adb | |
| author | Herbert Xu <herbert@gondor.apana.org.au> | |
| Thu, 26 Mar 2009 07:59:10 +0000 (26 00:59 -0700) | ||
| committer | Chris Wright <chrisw@sous-sol.org> | |
| Thu, 2 Apr 2009 20:55:15 +0000 (2 13:55 -0700) | ||
| tree | cfddb33fb23892da9549c183dadaab8a66583d2b | treesnapshot (tar.gz zip) |
| parent | 813352bc3317b1104212667ce227a901a8d49908 | commitdiff |
GRO: Disable GRO on legacy netif_rx path
[ Upstream commit 8f1ead2d1a626ed0c85b3d2c2046a49081d5933f ]
When I fixed the GRO crash in the legacy receive path I used
napi_complete to replace __napi_complete. Unfortunately they're
not the same when NETPOLL is enabled, which may result in us
not calling __napi_complete at all.
What's more, we really do need to keep the __napi_complete call
within the IRQ-off section since in theory an IRQ can occur in
between and fill up the backlog to the maximum, causing us to
lock up.
Since we can't seem to find a fix that works properly right now,
this patch reverts all the GRO support from the netif_rx path.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
[ Upstream commit 8f1ead2d1a626ed0c85b3d2c2046a49081d5933f ]
When I fixed the GRO crash in the legacy receive path I used
napi_complete to replace __napi_complete. Unfortunately they're
not the same when NETPOLL is enabled, which may result in us
not calling __napi_complete at all.
What's more, we really do need to keep the __napi_complete call
within the IRQ-off section since in theory an IRQ can occur in
between and fill up the backlog to the maximum, causing us to
lock up.
Since we can't seem to find a fix that works properly right now,
this patch reverts all the GRO support from the netif_rx path.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
| net/core/dev.c | diffblobblamehistory |