| commit | 813352bc3317b1104212667ce227a901a8d49908 | |
| author | Stephen Hemminger <shemminger@vyatta.com> | |
| Thu, 26 Mar 2009 04:01:47 +0000 (25 21:01 -0700) | ||
| committer | Chris Wright <chrisw@sous-sol.org> | |
| Thu, 2 Apr 2009 20:55:15 +0000 (2 13:55 -0700) | ||
| tree | bd3fe078411bd58fd12309276c6c9d83b66af526 | treesnapshot (tar.gz zip) |
| parent | dcd2d49aa7d2b6405457e042cd5f92e247ff0e10 | commitdiff |
bridge: bad error handling when adding invalid ether address
[ Upstream commit cda6d377ec6b2ee2e58d563d0bd7eb313e0165df ]
This fixes an crash when empty bond device is added to a bridge.
If an interface with invalid ethernet address (all zero) is added
to a bridge, then bridge code detects it when setting up the forward
databas entry. But the error unwind is broken, the bridge port object
can get freed twice: once when ref count went to zeo, and once by kfree.
Since object is never really accessible, just free it.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
[ Upstream commit cda6d377ec6b2ee2e58d563d0bd7eb313e0165df ]
This fixes an crash when empty bond device is added to a bridge.
If an interface with invalid ethernet address (all zero) is added
to a bridge, then bridge code detects it when setting up the forward
databas entry. But the error unwind is broken, the bridge port object
can get freed twice: once when ref count went to zeo, and once by kfree.
Since object is never really accessible, just free it.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
| net/bridge/br_if.c | diffblobblamehistory |