mtd: physmap: fix NULL pointer dereference in error path
[linux-2.6/linux-loongson.git] / drivers / mtd / maps / physmap.c
blob229718222db710e27fc980fb68ca287d9553e99d
1 /*
2 * Normal mappings of chips in physical memory
4 * Copyright (C) 2003 MontaVista Software Inc.
5 * Author: Jun Sun, jsun@mvista.com or jsun@junsun.net
7 * 031022 - [jsun] add run-time configure and partition setup
8 */
10 #include <linux/module.h>
11 #include <linux/types.h>
12 #include <linux/kernel.h>
13 #include <linux/init.h>
14 #include <linux/slab.h>
15 #include <linux/device.h>
16 #include <linux/platform_device.h>
17 #include <linux/mtd/mtd.h>
18 #include <linux/mtd/map.h>
19 #include <linux/mtd/partitions.h>
20 #include <linux/mtd/physmap.h>
21 #include <linux/mtd/concat.h>
22 #include <linux/io.h>
24 #define MAX_RESOURCES 4
26 struct physmap_flash_info {
27 struct mtd_info *mtd[MAX_RESOURCES];
28 struct mtd_info *cmtd;
29 struct map_info map[MAX_RESOURCES];
30 #ifdef CONFIG_MTD_PARTITIONS
31 int nr_parts;
32 struct mtd_partition *parts;
33 #endif
36 static int physmap_flash_remove(struct platform_device *dev)
38 struct physmap_flash_info *info;
39 struct physmap_flash_data *physmap_data;
40 int i;
42 info = platform_get_drvdata(dev);
43 if (info == NULL)
44 return 0;
45 platform_set_drvdata(dev, NULL);
47 physmap_data = dev->dev.platform_data;
49 if (info->cmtd) {
50 #ifdef CONFIG_MTD_PARTITIONS
51 if (info->nr_parts || physmap_data->nr_parts)
52 del_mtd_partitions(info->cmtd);
53 else
54 del_mtd_device(info->cmtd);
55 #else
56 del_mtd_device(info->cmtd);
57 #endif
59 #ifdef CONFIG_MTD_PARTITIONS
60 if (info->nr_parts)
61 kfree(info->parts);
62 #endif
64 #ifdef CONFIG_MTD_CONCAT
65 if (info->cmtd != info->mtd[0])
66 mtd_concat_destroy(info->cmtd);
67 #endif
69 for (i = 0; i < MAX_RESOURCES; i++) {
70 if (info->mtd[i] != NULL)
71 map_destroy(info->mtd[i]);
73 return 0;
76 static const char *rom_probe_types[] = {
77 "cfi_probe",
78 "jedec_probe",
79 "qinfo_probe",
80 "map_rom",
81 NULL };
82 #ifdef CONFIG_MTD_PARTITIONS
83 static const char *part_probe_types[] = { "cmdlinepart", "RedBoot", NULL };
84 #endif
86 static int physmap_flash_probe(struct platform_device *dev)
88 struct physmap_flash_data *physmap_data;
89 struct physmap_flash_info *info;
90 const char **probe_type;
91 int err = 0;
92 int i;
93 int devices_found = 0;
95 physmap_data = dev->dev.platform_data;
96 if (physmap_data == NULL)
97 return -ENODEV;
99 info = devm_kzalloc(&dev->dev, sizeof(struct physmap_flash_info),
100 GFP_KERNEL);
101 if (info == NULL) {
102 err = -ENOMEM;
103 goto err_out;
106 platform_set_drvdata(dev, info);
108 for (i = 0; i < dev->num_resources; i++) {
109 printk(KERN_NOTICE "physmap platform flash device: %.8llx at %.8llx\n",
110 (unsigned long long)(dev->resource[i].end - dev->resource[i].start + 1),
111 (unsigned long long)dev->resource[i].start);
113 if (!devm_request_mem_region(&dev->dev,
114 dev->resource[i].start,
115 dev->resource[i].end - dev->resource[i].start + 1,
116 dev_name(&dev->dev))) {
117 dev_err(&dev->dev, "Could not reserve memory region\n");
118 err = -ENOMEM;
119 goto err_out;
122 info->map[i].name = dev_name(&dev->dev);
123 info->map[i].phys = dev->resource[i].start;
124 info->map[i].size = dev->resource[i].end - dev->resource[i].start + 1;
125 info->map[i].bankwidth = physmap_data->width;
126 info->map[i].set_vpp = physmap_data->set_vpp;
127 info->map[i].pfow_base = physmap_data->pfow_base;
129 info->map[i].virt = devm_ioremap(&dev->dev, info->map[i].phys,
130 info->map[i].size);
131 if (info->map[i].virt == NULL) {
132 dev_err(&dev->dev, "Failed to ioremap flash region\n");
133 err = EIO;
134 goto err_out;
137 simple_map_init(&info->map[i]);
139 probe_type = rom_probe_types;
140 for (; info->mtd[i] == NULL && *probe_type != NULL; probe_type++)
141 info->mtd[i] = do_map_probe(*probe_type, &info->map[i]);
142 if (info->mtd[i] == NULL) {
143 dev_err(&dev->dev, "map_probe failed\n");
144 err = -ENXIO;
145 goto err_out;
146 } else {
147 devices_found++;
149 info->mtd[i]->owner = THIS_MODULE;
152 if (devices_found == 1) {
153 info->cmtd = info->mtd[0];
154 } else if (devices_found > 1) {
156 * We detected multiple devices. Concatenate them together.
158 #ifdef CONFIG_MTD_CONCAT
159 info->cmtd = mtd_concat_create(info->mtd, devices_found, dev_name(&dev->dev));
160 if (info->cmtd == NULL)
161 err = -ENXIO;
162 #else
163 printk(KERN_ERR "physmap-flash: multiple devices "
164 "found but MTD concat support disabled.\n");
165 err = -ENXIO;
166 #endif
168 if (err)
169 goto err_out;
171 #ifdef CONFIG_MTD_PARTITIONS
172 err = parse_mtd_partitions(info->cmtd, part_probe_types,
173 &info->parts, 0);
174 if (err > 0) {
175 add_mtd_partitions(info->cmtd, info->parts, err);
176 info->nr_parts = err;
177 return 0;
180 if (physmap_data->nr_parts) {
181 printk(KERN_NOTICE "Using physmap partition information\n");
182 add_mtd_partitions(info->cmtd, physmap_data->parts,
183 physmap_data->nr_parts);
184 return 0;
186 #endif
188 add_mtd_device(info->cmtd);
189 return 0;
191 err_out:
192 physmap_flash_remove(dev);
193 return err;
196 #ifdef CONFIG_PM
197 static int physmap_flash_suspend(struct platform_device *dev, pm_message_t state)
199 struct physmap_flash_info *info = platform_get_drvdata(dev);
200 int ret = 0;
201 int i;
203 for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
204 if (info->mtd[i]->suspend) {
205 ret = info->mtd[i]->suspend(info->mtd[i]);
206 if (ret)
207 goto fail;
210 return 0;
211 fail:
212 for (--i; i >= 0; --i)
213 if (info->mtd[i]->suspend) {
214 BUG_ON(!info->mtd[i]->resume);
215 info->mtd[i]->resume(info->mtd[i]);
218 return ret;
221 static int physmap_flash_resume(struct platform_device *dev)
223 struct physmap_flash_info *info = platform_get_drvdata(dev);
224 int i;
226 for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
227 if (info->mtd[i]->resume)
228 info->mtd[i]->resume(info->mtd[i]);
230 return 0;
233 static void physmap_flash_shutdown(struct platform_device *dev)
235 struct physmap_flash_info *info = platform_get_drvdata(dev);
236 int i;
238 for (i = 0; i < MAX_RESOURCES && info->mtd[i]; i++)
239 if (info->mtd[i]->suspend && info->mtd[i]->resume)
240 if (info->mtd[i]->suspend(info->mtd[i]) == 0)
241 info->mtd[i]->resume(info->mtd[i]);
243 #else
244 #define physmap_flash_suspend NULL
245 #define physmap_flash_resume NULL
246 #define physmap_flash_shutdown NULL
247 #endif
249 static struct platform_driver physmap_flash_driver = {
250 .probe = physmap_flash_probe,
251 .remove = physmap_flash_remove,
252 .suspend = physmap_flash_suspend,
253 .resume = physmap_flash_resume,
254 .shutdown = physmap_flash_shutdown,
255 .driver = {
256 .name = "physmap-flash",
257 .owner = THIS_MODULE,
262 #ifdef CONFIG_MTD_PHYSMAP_COMPAT
263 static struct physmap_flash_data physmap_flash_data = {
264 .width = CONFIG_MTD_PHYSMAP_BANKWIDTH,
267 static struct resource physmap_flash_resource = {
268 .start = CONFIG_MTD_PHYSMAP_START,
269 .end = CONFIG_MTD_PHYSMAP_START + CONFIG_MTD_PHYSMAP_LEN - 1,
270 .flags = IORESOURCE_MEM,
273 static struct platform_device physmap_flash = {
274 .name = "physmap-flash",
275 .id = 0,
276 .dev = {
277 .platform_data = &physmap_flash_data,
279 .num_resources = 1,
280 .resource = &physmap_flash_resource,
283 void physmap_configure(unsigned long addr, unsigned long size,
284 int bankwidth, void (*set_vpp)(struct map_info *, int))
286 physmap_flash_resource.start = addr;
287 physmap_flash_resource.end = addr + size - 1;
288 physmap_flash_data.width = bankwidth;
289 physmap_flash_data.set_vpp = set_vpp;
292 #ifdef CONFIG_MTD_PARTITIONS
293 void physmap_set_partitions(struct mtd_partition *parts, int num_parts)
295 physmap_flash_data.nr_parts = num_parts;
296 physmap_flash_data.parts = parts;
298 #endif
299 #endif
301 static int __init physmap_init(void)
303 int err;
305 err = platform_driver_register(&physmap_flash_driver);
306 #ifdef CONFIG_MTD_PHYSMAP_COMPAT
307 if (err == 0)
308 platform_device_register(&physmap_flash);
309 #endif
311 return err;
314 static void __exit physmap_exit(void)
316 #ifdef CONFIG_MTD_PHYSMAP_COMPAT
317 platform_device_unregister(&physmap_flash);
318 #endif
319 platform_driver_unregister(&physmap_flash_driver);
322 module_init(physmap_init);
323 module_exit(physmap_exit);
325 MODULE_LICENSE("GPL");
326 MODULE_AUTHOR("David Woodhouse <dwmw2@infradead.org>");
327 MODULE_DESCRIPTION("Generic configurable MTD map driver");
329 /* legacy platform drivers can't hotplug or coldplg */
330 #ifndef CONFIG_MTD_PHYSMAP_COMPAT
331 /* work with hotplug and coldplug */
332 MODULE_ALIAS("platform:physmap-flash");
333 #endif