| commit | d88be46507ffa20e69a237d5c7bfead253ad7c69 | |
| author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | |
| Sun, 20 Dec 2009 18:22:33 +0000 (20 19:22 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Wed, 6 Jan 2010 23:17:09 +0000 (6 15:17 -0800) | ||
| tree | 26f4fcaeedb7b809ca8c6f4a3fb83aa13bbb2485 | treesnapshot (tar.gz zip) |
| parent | d9b7ad9d124b0d3154bf0fe64ca5425827de498b | commitdiff |
pata_cmd64x: fix overclocking of UDMA0-2 modes
commit 509426bd46ad0903dca409803e0ee3d30f99f1e8 upstream.
adev->dma_mode stores the transfer mode value not UDMA mode number
so the condition in cmd64x_set_dmamode() is always true and the higher
UDMA clock is always selected. This can potentially result in data
corruption when UDMA33 device is used, when 40-wire cable is used or
when the error recovery code decides to lower the device speed down.
The issue was introduced in the commit 6a40da0 ("libata cmd64x: whack
into a shape that looks like the documentation") which goes back to
kernel 2.6.20.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 509426bd46ad0903dca409803e0ee3d30f99f1e8 upstream.
adev->dma_mode stores the transfer mode value not UDMA mode number
so the condition in cmd64x_set_dmamode() is always true and the higher
UDMA clock is always selected. This can potentially result in data
corruption when UDMA33 device is used, when 40-wire cable is used or
when the error recovery code decides to lower the device speed down.
The issue was introduced in the commit 6a40da0 ("libata cmd64x: whack
into a shape that looks like the documentation") which goes back to
kernel 2.6.20.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/ata/pata_cmd64x.c | diffblobblamehistory |