| commit | 509426bd46ad0903dca409803e0ee3d30f99f1e8 | |
| author | Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> | |
| Sun, 20 Dec 2009 18:22:33 +0000 (20 19:22 +0100) | ||
| committer | Jeff Garzik <jgarzik@redhat.com> | |
| Sun, 20 Dec 2009 20:42:12 +0000 (20 15:42 -0500) | ||
| tree | 628568a77c1b5e0f14c7241ec3e4a9a81c5dcada | treesnapshot (tar.gz zip) |
| parent | 06393afde321b0fd7626b2d0966ebcaf6077de93 | commitdiff |
pata_cmd64x: fix overclocking of UDMA0-2 modes
adev->dma_mode stores the transfer mode value not UDMA mode number
so the condition in cmd64x_set_dmamode() is always true and the higher
UDMA clock is always selected. This can potentially result in data
corruption when UDMA33 device is used, when 40-wire cable is used or
when the error recovery code decides to lower the device speed down.
The issue was introduced in the commit 6a40da0 ("libata cmd64x: whack
into a shape that looks like the documentation") which goes back to
kernel 2.6.20.
Cc: stable@kernel.org
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
adev->dma_mode stores the transfer mode value not UDMA mode number
so the condition in cmd64x_set_dmamode() is always true and the higher
UDMA clock is always selected. This can potentially result in data
corruption when UDMA33 device is used, when 40-wire cable is used or
when the error recovery code decides to lower the device speed down.
The issue was introduced in the commit 6a40da0 ("libata cmd64x: whack
into a shape that looks like the documentation") which goes back to
kernel 2.6.20.
Cc: stable@kernel.org
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
| drivers/ata/pata_cmd64x.c | diffblobblamehistory |