2 * Copyright(c) 2004-2005 Intel Corporation. All rights reserved.
4 * This program is free software; you can redistribute it and/or modify it
5 * under the terms of the GNU General Public License as published by the
6 * Free Software Foundation; either version 2 of the License, or
7 * (at your option) any later version.
9 * This program is distributed in the hope that it will be useful, but
10 * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
11 * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
14 * You should have received a copy of the GNU General Public License along
15 * with this program; if not, write to the Free Software Foundation, Inc.,
16 * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
18 * The full GNU General Public License is included in this distribution in the
19 * file called LICENSE.
23 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
25 #include <linux/kernel.h>
26 #include <linux/module.h>
27 #include <linux/device.h>
28 #include <linux/sched.h>
29 #include <linux/sysdev.h>
31 #include <linux/types.h>
32 #include <linux/string.h>
33 #include <linux/netdevice.h>
34 #include <linux/inetdevice.h>
36 #include <linux/sysfs.h>
37 #include <linux/ctype.h>
38 #include <linux/inet.h>
39 #include <linux/rtnetlink.h>
40 #include <linux/etherdevice.h>
41 #include <net/net_namespace.h>
42 #include <net/netns/generic.h>
43 #include <linux/nsproxy.h>
47 #define to_dev(obj) container_of(obj, struct device, kobj)
48 #define to_bond(cd) ((struct bonding *)(netdev_priv(to_net_dev(cd))))
51 * "show" function for the bond_masters attribute.
52 * The class parameter is ignored.
54 static ssize_t
bonding_show_bonds(struct class *cls
,
55 struct class_attribute
*attr
,
58 struct net
*net
= current
->nsproxy
->net_ns
;
59 struct bond_net
*bn
= net_generic(net
, bond_net_id
);
65 list_for_each_entry(bond
, &bn
->dev_list
, bond_list
) {
66 if (res
> (PAGE_SIZE
- IFNAMSIZ
)) {
67 /* not enough space for another interface name */
68 if ((PAGE_SIZE
- res
) > 10)
70 res
+= sprintf(buf
+ res
, "++more++ ");
73 res
+= sprintf(buf
+ res
, "%s ", bond
->dev
->name
);
76 buf
[res
-1] = '\n'; /* eat the leftover space */
82 static struct net_device
*bond_get_by_name(struct net
*net
, const char *ifname
)
84 struct bond_net
*bn
= net_generic(net
, bond_net_id
);
87 list_for_each_entry(bond
, &bn
->dev_list
, bond_list
) {
88 if (strncmp(bond
->dev
->name
, ifname
, IFNAMSIZ
) == 0)
95 * "store" function for the bond_masters attribute. This is what
96 * creates and deletes entire bonds.
98 * The class parameter is ignored.
102 static ssize_t
bonding_store_bonds(struct class *cls
,
103 struct class_attribute
*attr
,
104 const char *buffer
, size_t count
)
106 struct net
*net
= current
->nsproxy
->net_ns
;
107 char command
[IFNAMSIZ
+ 1] = {0, };
111 sscanf(buffer
, "%16s", command
); /* IFNAMSIZ*/
112 ifname
= command
+ 1;
113 if ((strlen(command
) <= 1) ||
114 !dev_valid_name(ifname
))
117 if (command
[0] == '+') {
118 pr_info("%s is being created...\n", ifname
);
119 rv
= bond_create(net
, ifname
);
122 pr_info("%s already exists.\n", ifname
);
124 pr_info("%s creation failed.\n", ifname
);
127 } else if (command
[0] == '-') {
128 struct net_device
*bond_dev
;
131 bond_dev
= bond_get_by_name(net
, ifname
);
133 pr_info("%s is being deleted...\n", ifname
);
134 unregister_netdevice(bond_dev
);
136 pr_err("unable to delete non-existent %s\n", ifname
);
143 /* Always return either count or an error. If you return 0, you'll
144 * get called forever, which is bad.
149 pr_err("no command found in bonding_masters. Use +ifname or -ifname.\n");
153 /* class attribute for bond_masters file. This ends up in /sys/class/net */
154 static CLASS_ATTR(bonding_masters
, S_IWUSR
| S_IRUGO
,
155 bonding_show_bonds
, bonding_store_bonds
);
157 int bond_create_slave_symlinks(struct net_device
*master
,
158 struct net_device
*slave
)
160 char linkname
[IFNAMSIZ
+7];
163 /* first, create a link from the slave back to the master */
164 ret
= sysfs_create_link(&(slave
->dev
.kobj
), &(master
->dev
.kobj
),
168 /* next, create a link from the master to the slave */
169 sprintf(linkname
, "slave_%s", slave
->name
);
170 ret
= sysfs_create_link(&(master
->dev
.kobj
), &(slave
->dev
.kobj
),
176 void bond_destroy_slave_symlinks(struct net_device
*master
,
177 struct net_device
*slave
)
179 char linkname
[IFNAMSIZ
+7];
181 sysfs_remove_link(&(slave
->dev
.kobj
), "master");
182 sprintf(linkname
, "slave_%s", slave
->name
);
183 sysfs_remove_link(&(master
->dev
.kobj
), linkname
);
188 * Show the slaves in the current bond.
190 static ssize_t
bonding_show_slaves(struct device
*d
,
191 struct device_attribute
*attr
, char *buf
)
195 struct bonding
*bond
= to_bond(d
);
197 read_lock(&bond
->lock
);
198 bond_for_each_slave(bond
, slave
, i
) {
199 if (res
> (PAGE_SIZE
- IFNAMSIZ
)) {
200 /* not enough space for another interface name */
201 if ((PAGE_SIZE
- res
) > 10)
202 res
= PAGE_SIZE
- 10;
203 res
+= sprintf(buf
+ res
, "++more++ ");
206 res
+= sprintf(buf
+ res
, "%s ", slave
->dev
->name
);
208 read_unlock(&bond
->lock
);
210 buf
[res
-1] = '\n'; /* eat the leftover space */
215 * Set the slaves in the current bond. The bond interface must be
216 * up for this to succeed.
217 * This is supposed to be only thin wrapper for bond_enslave and bond_release.
218 * All hard work should be done there.
220 static ssize_t
bonding_store_slaves(struct device
*d
,
221 struct device_attribute
*attr
,
222 const char *buffer
, size_t count
)
224 char command
[IFNAMSIZ
+ 1] = { 0, };
226 int res
, ret
= count
;
227 struct net_device
*dev
;
228 struct bonding
*bond
= to_bond(d
);
231 return restart_syscall();
233 sscanf(buffer
, "%16s", command
); /* IFNAMSIZ*/
234 ifname
= command
+ 1;
235 if ((strlen(command
) <= 1) ||
236 !dev_valid_name(ifname
))
239 dev
= __dev_get_by_name(dev_net(bond
->dev
), ifname
);
241 pr_info("%s: Interface %s does not exist!\n",
242 bond
->dev
->name
, ifname
);
247 switch (command
[0]) {
249 pr_info("%s: Adding slave %s.\n", bond
->dev
->name
, dev
->name
);
250 res
= bond_enslave(bond
->dev
, dev
);
254 pr_info("%s: Removing slave %s.\n", bond
->dev
->name
, dev
->name
);
255 res
= bond_release(bond
->dev
, dev
);
267 pr_err("no command found in slaves file for bond %s. Use +ifname or -ifname.\n",
276 static DEVICE_ATTR(slaves
, S_IRUGO
| S_IWUSR
, bonding_show_slaves
,
277 bonding_store_slaves
);
280 * Show and set the bonding mode. The bond interface must be down to
283 static ssize_t
bonding_show_mode(struct device
*d
,
284 struct device_attribute
*attr
, char *buf
)
286 struct bonding
*bond
= to_bond(d
);
288 return sprintf(buf
, "%s %d\n",
289 bond_mode_tbl
[bond
->params
.mode
].modename
,
293 static ssize_t
bonding_store_mode(struct device
*d
,
294 struct device_attribute
*attr
,
295 const char *buf
, size_t count
)
297 int new_value
, ret
= count
;
298 struct bonding
*bond
= to_bond(d
);
300 if (bond
->dev
->flags
& IFF_UP
) {
301 pr_err("unable to update mode of %s because interface is up.\n",
307 new_value
= bond_parse_parm(buf
, bond_mode_tbl
);
309 pr_err("%s: Ignoring invalid mode value %.*s.\n",
310 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
314 if ((new_value
== BOND_MODE_ALB
||
315 new_value
== BOND_MODE_TLB
) &&
316 bond
->params
.arp_interval
) {
317 pr_err("%s: %s mode is incompatible with arp monitoring.\n",
318 bond
->dev
->name
, bond_mode_tbl
[new_value
].modename
);
323 bond
->params
.mode
= new_value
;
324 bond_set_mode_ops(bond
, bond
->params
.mode
);
325 pr_info("%s: setting mode to %s (%d).\n",
326 bond
->dev
->name
, bond_mode_tbl
[new_value
].modename
,
331 static DEVICE_ATTR(mode
, S_IRUGO
| S_IWUSR
,
332 bonding_show_mode
, bonding_store_mode
);
335 * Show and set the bonding transmit hash method.
336 * The bond interface must be down to change the xmit hash policy.
338 static ssize_t
bonding_show_xmit_hash(struct device
*d
,
339 struct device_attribute
*attr
,
342 struct bonding
*bond
= to_bond(d
);
344 return sprintf(buf
, "%s %d\n",
345 xmit_hashtype_tbl
[bond
->params
.xmit_policy
].modename
,
346 bond
->params
.xmit_policy
);
349 static ssize_t
bonding_store_xmit_hash(struct device
*d
,
350 struct device_attribute
*attr
,
351 const char *buf
, size_t count
)
353 int new_value
, ret
= count
;
354 struct bonding
*bond
= to_bond(d
);
356 if (bond
->dev
->flags
& IFF_UP
) {
357 pr_err("%s: Interface is up. Unable to update xmit policy.\n",
363 new_value
= bond_parse_parm(buf
, xmit_hashtype_tbl
);
365 pr_err("%s: Ignoring invalid xmit hash policy value %.*s.\n",
367 (int)strlen(buf
) - 1, buf
);
371 bond
->params
.xmit_policy
= new_value
;
372 bond_set_mode_ops(bond
, bond
->params
.mode
);
373 pr_info("%s: setting xmit hash policy to %s (%d).\n",
375 xmit_hashtype_tbl
[new_value
].modename
, new_value
);
380 static DEVICE_ATTR(xmit_hash_policy
, S_IRUGO
| S_IWUSR
,
381 bonding_show_xmit_hash
, bonding_store_xmit_hash
);
384 * Show and set arp_validate.
386 static ssize_t
bonding_show_arp_validate(struct device
*d
,
387 struct device_attribute
*attr
,
390 struct bonding
*bond
= to_bond(d
);
392 return sprintf(buf
, "%s %d\n",
393 arp_validate_tbl
[bond
->params
.arp_validate
].modename
,
394 bond
->params
.arp_validate
);
397 static ssize_t
bonding_store_arp_validate(struct device
*d
,
398 struct device_attribute
*attr
,
399 const char *buf
, size_t count
)
402 struct bonding
*bond
= to_bond(d
);
404 new_value
= bond_parse_parm(buf
, arp_validate_tbl
);
406 pr_err("%s: Ignoring invalid arp_validate value %s\n",
407 bond
->dev
->name
, buf
);
410 if (new_value
&& (bond
->params
.mode
!= BOND_MODE_ACTIVEBACKUP
)) {
411 pr_err("%s: arp_validate only supported in active-backup mode.\n",
415 pr_info("%s: setting arp_validate to %s (%d).\n",
416 bond
->dev
->name
, arp_validate_tbl
[new_value
].modename
,
419 bond
->params
.arp_validate
= new_value
;
424 static DEVICE_ATTR(arp_validate
, S_IRUGO
| S_IWUSR
, bonding_show_arp_validate
,
425 bonding_store_arp_validate
);
428 * Show and store fail_over_mac. User only allowed to change the
429 * value when there are no slaves.
431 static ssize_t
bonding_show_fail_over_mac(struct device
*d
,
432 struct device_attribute
*attr
,
435 struct bonding
*bond
= to_bond(d
);
437 return sprintf(buf
, "%s %d\n",
438 fail_over_mac_tbl
[bond
->params
.fail_over_mac
].modename
,
439 bond
->params
.fail_over_mac
);
442 static ssize_t
bonding_store_fail_over_mac(struct device
*d
,
443 struct device_attribute
*attr
,
444 const char *buf
, size_t count
)
447 struct bonding
*bond
= to_bond(d
);
449 if (bond
->slave_cnt
!= 0) {
450 pr_err("%s: Can't alter fail_over_mac with slaves in bond.\n",
455 new_value
= bond_parse_parm(buf
, fail_over_mac_tbl
);
457 pr_err("%s: Ignoring invalid fail_over_mac value %s.\n",
458 bond
->dev
->name
, buf
);
462 bond
->params
.fail_over_mac
= new_value
;
463 pr_info("%s: Setting fail_over_mac to %s (%d).\n",
464 bond
->dev
->name
, fail_over_mac_tbl
[new_value
].modename
,
470 static DEVICE_ATTR(fail_over_mac
, S_IRUGO
| S_IWUSR
,
471 bonding_show_fail_over_mac
, bonding_store_fail_over_mac
);
474 * Show and set the arp timer interval. There are two tricky bits
475 * here. First, if ARP monitoring is activated, then we must disable
476 * MII monitoring. Second, if the ARP timer isn't running, we must
479 static ssize_t
bonding_show_arp_interval(struct device
*d
,
480 struct device_attribute
*attr
,
483 struct bonding
*bond
= to_bond(d
);
485 return sprintf(buf
, "%d\n", bond
->params
.arp_interval
);
488 static ssize_t
bonding_store_arp_interval(struct device
*d
,
489 struct device_attribute
*attr
,
490 const char *buf
, size_t count
)
492 int new_value
, ret
= count
;
493 struct bonding
*bond
= to_bond(d
);
495 if (sscanf(buf
, "%d", &new_value
) != 1) {
496 pr_err("%s: no arp_interval value specified.\n",
502 pr_err("%s: Invalid arp_interval value %d not in range 1-%d; rejected.\n",
503 bond
->dev
->name
, new_value
, INT_MAX
);
507 if (bond
->params
.mode
== BOND_MODE_ALB
||
508 bond
->params
.mode
== BOND_MODE_TLB
) {
509 pr_info("%s: ARP monitoring cannot be used with ALB/TLB. Only MII monitoring is supported on %s.\n",
510 bond
->dev
->name
, bond
->dev
->name
);
514 pr_info("%s: Setting ARP monitoring interval to %d.\n",
515 bond
->dev
->name
, new_value
);
516 bond
->params
.arp_interval
= new_value
;
517 if (bond
->params
.miimon
) {
518 pr_info("%s: ARP monitoring cannot be used with MII monitoring. %s Disabling MII monitoring.\n",
519 bond
->dev
->name
, bond
->dev
->name
);
520 bond
->params
.miimon
= 0;
521 if (delayed_work_pending(&bond
->mii_work
)) {
522 cancel_delayed_work(&bond
->mii_work
);
523 flush_workqueue(bond
->wq
);
526 if (!bond
->params
.arp_targets
[0]) {
527 pr_info("%s: ARP monitoring has been set up, but no ARP targets have been specified.\n",
530 if (bond
->dev
->flags
& IFF_UP
) {
531 /* If the interface is up, we may need to fire off
532 * the ARP timer. If the interface is down, the
533 * timer will get fired off when the open function
536 if (!delayed_work_pending(&bond
->arp_work
)) {
537 if (bond
->params
.mode
== BOND_MODE_ACTIVEBACKUP
)
538 INIT_DELAYED_WORK(&bond
->arp_work
,
539 bond_activebackup_arp_mon
);
541 INIT_DELAYED_WORK(&bond
->arp_work
,
542 bond_loadbalance_arp_mon
);
544 queue_delayed_work(bond
->wq
, &bond
->arp_work
, 0);
551 static DEVICE_ATTR(arp_interval
, S_IRUGO
| S_IWUSR
,
552 bonding_show_arp_interval
, bonding_store_arp_interval
);
555 * Show and set the arp targets.
557 static ssize_t
bonding_show_arp_targets(struct device
*d
,
558 struct device_attribute
*attr
,
562 struct bonding
*bond
= to_bond(d
);
564 for (i
= 0; i
< BOND_MAX_ARP_TARGETS
; i
++) {
565 if (bond
->params
.arp_targets
[i
])
566 res
+= sprintf(buf
+ res
, "%pI4 ",
567 &bond
->params
.arp_targets
[i
]);
570 buf
[res
-1] = '\n'; /* eat the leftover space */
574 static ssize_t
bonding_store_arp_targets(struct device
*d
,
575 struct device_attribute
*attr
,
576 const char *buf
, size_t count
)
579 int i
= 0, done
= 0, ret
= count
;
580 struct bonding
*bond
= to_bond(d
);
583 targets
= bond
->params
.arp_targets
;
584 newtarget
= in_aton(buf
+ 1);
587 if ((newtarget
== 0) || (newtarget
== htonl(INADDR_BROADCAST
))) {
588 pr_err("%s: invalid ARP target %pI4 specified for addition\n",
589 bond
->dev
->name
, &newtarget
);
593 /* look for an empty slot to put the target in, and check for dupes */
594 for (i
= 0; (i
< BOND_MAX_ARP_TARGETS
) && !done
; i
++) {
595 if (targets
[i
] == newtarget
) { /* duplicate */
596 pr_err("%s: ARP target %pI4 is already present\n",
597 bond
->dev
->name
, &newtarget
);
601 if (targets
[i
] == 0) {
602 pr_info("%s: adding ARP target %pI4.\n",
603 bond
->dev
->name
, &newtarget
);
605 targets
[i
] = newtarget
;
609 pr_err("%s: ARP target table is full!\n",
615 } else if (buf
[0] == '-') {
616 if ((newtarget
== 0) || (newtarget
== htonl(INADDR_BROADCAST
))) {
617 pr_err("%s: invalid ARP target %pI4 specified for removal\n",
618 bond
->dev
->name
, &newtarget
);
623 for (i
= 0; (i
< BOND_MAX_ARP_TARGETS
) && !done
; i
++) {
624 if (targets
[i
] == newtarget
) {
626 pr_info("%s: removing ARP target %pI4.\n",
627 bond
->dev
->name
, &newtarget
);
628 for (j
= i
; (j
< (BOND_MAX_ARP_TARGETS
-1)) && targets
[j
+1]; j
++)
629 targets
[j
] = targets
[j
+1];
636 pr_info("%s: unable to remove nonexistent ARP target %pI4.\n",
637 bond
->dev
->name
, &newtarget
);
642 pr_err("no command found in arp_ip_targets file for bond %s. Use +<addr> or -<addr>.\n",
651 static DEVICE_ATTR(arp_ip_target
, S_IRUGO
| S_IWUSR
, bonding_show_arp_targets
, bonding_store_arp_targets
);
654 * Show and set the up and down delays. These must be multiples of the
655 * MII monitoring value, and are stored internally as the multiplier.
656 * Thus, we must translate to MS for the real world.
658 static ssize_t
bonding_show_downdelay(struct device
*d
,
659 struct device_attribute
*attr
,
662 struct bonding
*bond
= to_bond(d
);
664 return sprintf(buf
, "%d\n", bond
->params
.downdelay
* bond
->params
.miimon
);
667 static ssize_t
bonding_store_downdelay(struct device
*d
,
668 struct device_attribute
*attr
,
669 const char *buf
, size_t count
)
671 int new_value
, ret
= count
;
672 struct bonding
*bond
= to_bond(d
);
674 if (!(bond
->params
.miimon
)) {
675 pr_err("%s: Unable to set down delay as MII monitoring is disabled\n",
681 if (sscanf(buf
, "%d", &new_value
) != 1) {
682 pr_err("%s: no down delay value specified.\n", bond
->dev
->name
);
687 pr_err("%s: Invalid down delay value %d not in range %d-%d; rejected.\n",
688 bond
->dev
->name
, new_value
, 1, INT_MAX
);
692 if ((new_value
% bond
->params
.miimon
) != 0) {
693 pr_warning("%s: Warning: down delay (%d) is not a multiple of miimon (%d), delay rounded to %d ms\n",
694 bond
->dev
->name
, new_value
,
696 (new_value
/ bond
->params
.miimon
) *
697 bond
->params
.miimon
);
699 bond
->params
.downdelay
= new_value
/ bond
->params
.miimon
;
700 pr_info("%s: Setting down delay to %d.\n",
702 bond
->params
.downdelay
* bond
->params
.miimon
);
709 static DEVICE_ATTR(downdelay
, S_IRUGO
| S_IWUSR
,
710 bonding_show_downdelay
, bonding_store_downdelay
);
712 static ssize_t
bonding_show_updelay(struct device
*d
,
713 struct device_attribute
*attr
,
716 struct bonding
*bond
= to_bond(d
);
718 return sprintf(buf
, "%d\n", bond
->params
.updelay
* bond
->params
.miimon
);
722 static ssize_t
bonding_store_updelay(struct device
*d
,
723 struct device_attribute
*attr
,
724 const char *buf
, size_t count
)
726 int new_value
, ret
= count
;
727 struct bonding
*bond
= to_bond(d
);
729 if (!(bond
->params
.miimon
)) {
730 pr_err("%s: Unable to set up delay as MII monitoring is disabled\n",
736 if (sscanf(buf
, "%d", &new_value
) != 1) {
737 pr_err("%s: no up delay value specified.\n",
743 pr_err("%s: Invalid down delay value %d not in range %d-%d; rejected.\n",
744 bond
->dev
->name
, new_value
, 1, INT_MAX
);
748 if ((new_value
% bond
->params
.miimon
) != 0) {
749 pr_warning("%s: Warning: up delay (%d) is not a multiple of miimon (%d), updelay rounded to %d ms\n",
750 bond
->dev
->name
, new_value
,
752 (new_value
/ bond
->params
.miimon
) *
753 bond
->params
.miimon
);
755 bond
->params
.updelay
= new_value
/ bond
->params
.miimon
;
756 pr_info("%s: Setting up delay to %d.\n",
758 bond
->params
.updelay
* bond
->params
.miimon
);
764 static DEVICE_ATTR(updelay
, S_IRUGO
| S_IWUSR
,
765 bonding_show_updelay
, bonding_store_updelay
);
768 * Show and set the LACP interval. Interface must be down, and the mode
769 * must be set to 802.3ad mode.
771 static ssize_t
bonding_show_lacp(struct device
*d
,
772 struct device_attribute
*attr
,
775 struct bonding
*bond
= to_bond(d
);
777 return sprintf(buf
, "%s %d\n",
778 bond_lacp_tbl
[bond
->params
.lacp_fast
].modename
,
779 bond
->params
.lacp_fast
);
782 static ssize_t
bonding_store_lacp(struct device
*d
,
783 struct device_attribute
*attr
,
784 const char *buf
, size_t count
)
786 int new_value
, ret
= count
;
787 struct bonding
*bond
= to_bond(d
);
789 if (bond
->dev
->flags
& IFF_UP
) {
790 pr_err("%s: Unable to update LACP rate because interface is up.\n",
796 if (bond
->params
.mode
!= BOND_MODE_8023AD
) {
797 pr_err("%s: Unable to update LACP rate because bond is not in 802.3ad mode.\n",
803 new_value
= bond_parse_parm(buf
, bond_lacp_tbl
);
805 if ((new_value
== 1) || (new_value
== 0)) {
806 bond
->params
.lacp_fast
= new_value
;
807 pr_info("%s: Setting LACP rate to %s (%d).\n",
808 bond
->dev
->name
, bond_lacp_tbl
[new_value
].modename
,
811 pr_err("%s: Ignoring invalid LACP rate value %.*s.\n",
812 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
818 static DEVICE_ATTR(lacp_rate
, S_IRUGO
| S_IWUSR
,
819 bonding_show_lacp
, bonding_store_lacp
);
821 static ssize_t
bonding_show_ad_select(struct device
*d
,
822 struct device_attribute
*attr
,
825 struct bonding
*bond
= to_bond(d
);
827 return sprintf(buf
, "%s %d\n",
828 ad_select_tbl
[bond
->params
.ad_select
].modename
,
829 bond
->params
.ad_select
);
833 static ssize_t
bonding_store_ad_select(struct device
*d
,
834 struct device_attribute
*attr
,
835 const char *buf
, size_t count
)
837 int new_value
, ret
= count
;
838 struct bonding
*bond
= to_bond(d
);
840 if (bond
->dev
->flags
& IFF_UP
) {
841 pr_err("%s: Unable to update ad_select because interface is up.\n",
847 new_value
= bond_parse_parm(buf
, ad_select_tbl
);
849 if (new_value
!= -1) {
850 bond
->params
.ad_select
= new_value
;
851 pr_info("%s: Setting ad_select to %s (%d).\n",
852 bond
->dev
->name
, ad_select_tbl
[new_value
].modename
,
855 pr_err("%s: Ignoring invalid ad_select value %.*s.\n",
856 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
862 static DEVICE_ATTR(ad_select
, S_IRUGO
| S_IWUSR
,
863 bonding_show_ad_select
, bonding_store_ad_select
);
866 * Show and set the number of peer notifications to send after a failover event.
868 static ssize_t
bonding_show_num_peer_notif(struct device
*d
,
869 struct device_attribute
*attr
,
872 struct bonding
*bond
= to_bond(d
);
873 return sprintf(buf
, "%d\n", bond
->params
.num_peer_notif
);
876 static ssize_t
bonding_store_num_peer_notif(struct device
*d
,
877 struct device_attribute
*attr
,
878 const char *buf
, size_t count
)
880 struct bonding
*bond
= to_bond(d
);
881 int err
= kstrtou8(buf
, 10, &bond
->params
.num_peer_notif
);
882 return err
? err
: count
;
884 static DEVICE_ATTR(num_grat_arp
, S_IRUGO
| S_IWUSR
,
885 bonding_show_num_peer_notif
, bonding_store_num_peer_notif
);
886 static DEVICE_ATTR(num_unsol_na
, S_IRUGO
| S_IWUSR
,
887 bonding_show_num_peer_notif
, bonding_store_num_peer_notif
);
890 * Show and set the MII monitor interval. There are two tricky bits
891 * here. First, if MII monitoring is activated, then we must disable
892 * ARP monitoring. Second, if the timer isn't running, we must
895 static ssize_t
bonding_show_miimon(struct device
*d
,
896 struct device_attribute
*attr
,
899 struct bonding
*bond
= to_bond(d
);
901 return sprintf(buf
, "%d\n", bond
->params
.miimon
);
904 static ssize_t
bonding_store_miimon(struct device
*d
,
905 struct device_attribute
*attr
,
906 const char *buf
, size_t count
)
908 int new_value
, ret
= count
;
909 struct bonding
*bond
= to_bond(d
);
911 if (sscanf(buf
, "%d", &new_value
) != 1) {
912 pr_err("%s: no miimon value specified.\n",
918 pr_err("%s: Invalid miimon value %d not in range %d-%d; rejected.\n",
919 bond
->dev
->name
, new_value
, 1, INT_MAX
);
923 pr_info("%s: Setting MII monitoring interval to %d.\n",
924 bond
->dev
->name
, new_value
);
925 bond
->params
.miimon
= new_value
;
926 if (bond
->params
.updelay
)
927 pr_info("%s: Note: Updating updelay (to %d) since it is a multiple of the miimon value.\n",
929 bond
->params
.updelay
* bond
->params
.miimon
);
930 if (bond
->params
.downdelay
)
931 pr_info("%s: Note: Updating downdelay (to %d) since it is a multiple of the miimon value.\n",
933 bond
->params
.downdelay
* bond
->params
.miimon
);
934 if (bond
->params
.arp_interval
) {
935 pr_info("%s: MII monitoring cannot be used with ARP monitoring. Disabling ARP monitoring...\n",
937 bond
->params
.arp_interval
= 0;
938 if (bond
->params
.arp_validate
) {
939 bond
->params
.arp_validate
=
940 BOND_ARP_VALIDATE_NONE
;
942 if (delayed_work_pending(&bond
->arp_work
)) {
943 cancel_delayed_work(&bond
->arp_work
);
944 flush_workqueue(bond
->wq
);
948 if (bond
->dev
->flags
& IFF_UP
) {
949 /* If the interface is up, we may need to fire off
950 * the MII timer. If the interface is down, the
951 * timer will get fired off when the open function
954 if (!delayed_work_pending(&bond
->mii_work
)) {
955 INIT_DELAYED_WORK(&bond
->mii_work
,
957 queue_delayed_work(bond
->wq
,
965 static DEVICE_ATTR(miimon
, S_IRUGO
| S_IWUSR
,
966 bonding_show_miimon
, bonding_store_miimon
);
969 * Show and set the primary slave. The store function is much
970 * simpler than bonding_store_slaves function because it only needs to
971 * handle one interface name.
972 * The bond must be a mode that supports a primary for this be
975 static ssize_t
bonding_show_primary(struct device
*d
,
976 struct device_attribute
*attr
,
980 struct bonding
*bond
= to_bond(d
);
982 if (bond
->primary_slave
)
983 count
= sprintf(buf
, "%s\n", bond
->primary_slave
->dev
->name
);
988 static ssize_t
bonding_store_primary(struct device
*d
,
989 struct device_attribute
*attr
,
990 const char *buf
, size_t count
)
994 struct bonding
*bond
= to_bond(d
);
997 return restart_syscall();
999 read_lock(&bond
->lock
);
1000 write_lock_bh(&bond
->curr_slave_lock
);
1002 if (!USES_PRIMARY(bond
->params
.mode
)) {
1003 pr_info("%s: Unable to set primary slave; %s is in mode %d\n",
1004 bond
->dev
->name
, bond
->dev
->name
, bond
->params
.mode
);
1006 bond_for_each_slave(bond
, slave
, i
) {
1008 (slave
->dev
->name
, buf
,
1009 strlen(slave
->dev
->name
)) == 0) {
1010 pr_info("%s: Setting %s as primary slave.\n",
1011 bond
->dev
->name
, slave
->dev
->name
);
1012 bond
->primary_slave
= slave
;
1013 strcpy(bond
->params
.primary
, slave
->dev
->name
);
1014 bond_select_active_slave(bond
);
1019 /* if we got here, then we didn't match the name of any slave */
1021 if (strlen(buf
) == 0 || buf
[0] == '\n') {
1022 pr_info("%s: Setting primary slave to None.\n",
1024 bond
->primary_slave
= NULL
;
1025 bond_select_active_slave(bond
);
1027 pr_info("%s: Unable to set %.*s as primary slave as it is not a slave.\n",
1028 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
1032 write_unlock_bh(&bond
->curr_slave_lock
);
1033 read_unlock(&bond
->lock
);
1034 unblock_netpoll_tx();
1039 static DEVICE_ATTR(primary
, S_IRUGO
| S_IWUSR
,
1040 bonding_show_primary
, bonding_store_primary
);
1043 * Show and set the primary_reselect flag.
1045 static ssize_t
bonding_show_primary_reselect(struct device
*d
,
1046 struct device_attribute
*attr
,
1049 struct bonding
*bond
= to_bond(d
);
1051 return sprintf(buf
, "%s %d\n",
1052 pri_reselect_tbl
[bond
->params
.primary_reselect
].modename
,
1053 bond
->params
.primary_reselect
);
1056 static ssize_t
bonding_store_primary_reselect(struct device
*d
,
1057 struct device_attribute
*attr
,
1058 const char *buf
, size_t count
)
1060 int new_value
, ret
= count
;
1061 struct bonding
*bond
= to_bond(d
);
1063 if (!rtnl_trylock())
1064 return restart_syscall();
1066 new_value
= bond_parse_parm(buf
, pri_reselect_tbl
);
1067 if (new_value
< 0) {
1068 pr_err("%s: Ignoring invalid primary_reselect value %.*s.\n",
1070 (int) strlen(buf
) - 1, buf
);
1075 bond
->params
.primary_reselect
= new_value
;
1076 pr_info("%s: setting primary_reselect to %s (%d).\n",
1077 bond
->dev
->name
, pri_reselect_tbl
[new_value
].modename
,
1081 read_lock(&bond
->lock
);
1082 write_lock_bh(&bond
->curr_slave_lock
);
1083 bond_select_active_slave(bond
);
1084 write_unlock_bh(&bond
->curr_slave_lock
);
1085 read_unlock(&bond
->lock
);
1086 unblock_netpoll_tx();
1091 static DEVICE_ATTR(primary_reselect
, S_IRUGO
| S_IWUSR
,
1092 bonding_show_primary_reselect
,
1093 bonding_store_primary_reselect
);
1096 * Show and set the use_carrier flag.
1098 static ssize_t
bonding_show_carrier(struct device
*d
,
1099 struct device_attribute
*attr
,
1102 struct bonding
*bond
= to_bond(d
);
1104 return sprintf(buf
, "%d\n", bond
->params
.use_carrier
);
1107 static ssize_t
bonding_store_carrier(struct device
*d
,
1108 struct device_attribute
*attr
,
1109 const char *buf
, size_t count
)
1111 int new_value
, ret
= count
;
1112 struct bonding
*bond
= to_bond(d
);
1115 if (sscanf(buf
, "%d", &new_value
) != 1) {
1116 pr_err("%s: no use_carrier value specified.\n",
1121 if ((new_value
== 0) || (new_value
== 1)) {
1122 bond
->params
.use_carrier
= new_value
;
1123 pr_info("%s: Setting use_carrier to %d.\n",
1124 bond
->dev
->name
, new_value
);
1126 pr_info("%s: Ignoring invalid use_carrier value %d.\n",
1127 bond
->dev
->name
, new_value
);
1132 static DEVICE_ATTR(use_carrier
, S_IRUGO
| S_IWUSR
,
1133 bonding_show_carrier
, bonding_store_carrier
);
1137 * Show and set currently active_slave.
1139 static ssize_t
bonding_show_active_slave(struct device
*d
,
1140 struct device_attribute
*attr
,
1144 struct bonding
*bond
= to_bond(d
);
1147 read_lock(&bond
->curr_slave_lock
);
1148 curr
= bond
->curr_active_slave
;
1149 read_unlock(&bond
->curr_slave_lock
);
1151 if (USES_PRIMARY(bond
->params
.mode
) && curr
)
1152 count
= sprintf(buf
, "%s\n", curr
->dev
->name
);
1156 static ssize_t
bonding_store_active_slave(struct device
*d
,
1157 struct device_attribute
*attr
,
1158 const char *buf
, size_t count
)
1161 struct slave
*slave
;
1162 struct slave
*old_active
= NULL
;
1163 struct slave
*new_active
= NULL
;
1164 struct bonding
*bond
= to_bond(d
);
1166 if (!rtnl_trylock())
1167 return restart_syscall();
1170 read_lock(&bond
->lock
);
1171 write_lock_bh(&bond
->curr_slave_lock
);
1173 if (!USES_PRIMARY(bond
->params
.mode
))
1174 pr_info("%s: Unable to change active slave; %s is in mode %d\n",
1175 bond
->dev
->name
, bond
->dev
->name
, bond
->params
.mode
);
1177 bond_for_each_slave(bond
, slave
, i
) {
1179 (slave
->dev
->name
, buf
,
1180 strlen(slave
->dev
->name
)) == 0) {
1181 old_active
= bond
->curr_active_slave
;
1183 if (new_active
== old_active
) {
1185 pr_info("%s: %s is already the current active slave.\n",
1193 (new_active
->link
== BOND_LINK_UP
) &&
1194 IS_UP(new_active
->dev
)) {
1195 pr_info("%s: Setting %s as active slave.\n",
1198 bond_change_active_slave(bond
, new_active
);
1201 pr_info("%s: Could not set %s as active slave; either %s is down or the link is down.\n",
1211 /* if we got here, then we didn't match the name of any slave */
1213 if (strlen(buf
) == 0 || buf
[0] == '\n') {
1214 pr_info("%s: Setting active slave to None.\n",
1216 bond
->primary_slave
= NULL
;
1217 bond_select_active_slave(bond
);
1219 pr_info("%s: Unable to set %.*s as active slave as it is not a slave.\n",
1220 bond
->dev
->name
, (int)strlen(buf
) - 1, buf
);
1224 write_unlock_bh(&bond
->curr_slave_lock
);
1225 read_unlock(&bond
->lock
);
1226 unblock_netpoll_tx();
1233 static DEVICE_ATTR(active_slave
, S_IRUGO
| S_IWUSR
,
1234 bonding_show_active_slave
, bonding_store_active_slave
);
1238 * Show link status of the bond interface.
1240 static ssize_t
bonding_show_mii_status(struct device
*d
,
1241 struct device_attribute
*attr
,
1245 struct bonding
*bond
= to_bond(d
);
1247 read_lock(&bond
->curr_slave_lock
);
1248 curr
= bond
->curr_active_slave
;
1249 read_unlock(&bond
->curr_slave_lock
);
1251 return sprintf(buf
, "%s\n", curr
? "up" : "down");
1253 static DEVICE_ATTR(mii_status
, S_IRUGO
, bonding_show_mii_status
, NULL
);
1257 * Show current 802.3ad aggregator ID.
1259 static ssize_t
bonding_show_ad_aggregator(struct device
*d
,
1260 struct device_attribute
*attr
,
1264 struct bonding
*bond
= to_bond(d
);
1266 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1267 struct ad_info ad_info
;
1268 count
= sprintf(buf
, "%d\n",
1269 (bond_3ad_get_active_agg_info(bond
, &ad_info
))
1270 ? 0 : ad_info
.aggregator_id
);
1275 static DEVICE_ATTR(ad_aggregator
, S_IRUGO
, bonding_show_ad_aggregator
, NULL
);
1279 * Show number of active 802.3ad ports.
1281 static ssize_t
bonding_show_ad_num_ports(struct device
*d
,
1282 struct device_attribute
*attr
,
1286 struct bonding
*bond
= to_bond(d
);
1288 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1289 struct ad_info ad_info
;
1290 count
= sprintf(buf
, "%d\n",
1291 (bond_3ad_get_active_agg_info(bond
, &ad_info
))
1292 ? 0 : ad_info
.ports
);
1297 static DEVICE_ATTR(ad_num_ports
, S_IRUGO
, bonding_show_ad_num_ports
, NULL
);
1301 * Show current 802.3ad actor key.
1303 static ssize_t
bonding_show_ad_actor_key(struct device
*d
,
1304 struct device_attribute
*attr
,
1308 struct bonding
*bond
= to_bond(d
);
1310 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1311 struct ad_info ad_info
;
1312 count
= sprintf(buf
, "%d\n",
1313 (bond_3ad_get_active_agg_info(bond
, &ad_info
))
1314 ? 0 : ad_info
.actor_key
);
1319 static DEVICE_ATTR(ad_actor_key
, S_IRUGO
, bonding_show_ad_actor_key
, NULL
);
1323 * Show current 802.3ad partner key.
1325 static ssize_t
bonding_show_ad_partner_key(struct device
*d
,
1326 struct device_attribute
*attr
,
1330 struct bonding
*bond
= to_bond(d
);
1332 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1333 struct ad_info ad_info
;
1334 count
= sprintf(buf
, "%d\n",
1335 (bond_3ad_get_active_agg_info(bond
, &ad_info
))
1336 ? 0 : ad_info
.partner_key
);
1341 static DEVICE_ATTR(ad_partner_key
, S_IRUGO
, bonding_show_ad_partner_key
, NULL
);
1345 * Show current 802.3ad partner mac.
1347 static ssize_t
bonding_show_ad_partner_mac(struct device
*d
,
1348 struct device_attribute
*attr
,
1352 struct bonding
*bond
= to_bond(d
);
1354 if (bond
->params
.mode
== BOND_MODE_8023AD
) {
1355 struct ad_info ad_info
;
1356 if (!bond_3ad_get_active_agg_info(bond
, &ad_info
))
1357 count
= sprintf(buf
, "%pM\n", ad_info
.partner_system
);
1362 static DEVICE_ATTR(ad_partner_mac
, S_IRUGO
, bonding_show_ad_partner_mac
, NULL
);
1365 * Show the queue_ids of the slaves in the current bond.
1367 static ssize_t
bonding_show_queue_id(struct device
*d
,
1368 struct device_attribute
*attr
,
1371 struct slave
*slave
;
1373 struct bonding
*bond
= to_bond(d
);
1375 if (!rtnl_trylock())
1376 return restart_syscall();
1378 read_lock(&bond
->lock
);
1379 bond_for_each_slave(bond
, slave
, i
) {
1380 if (res
> (PAGE_SIZE
- IFNAMSIZ
- 6)) {
1381 /* not enough space for another interface_name:queue_id pair */
1382 if ((PAGE_SIZE
- res
) > 10)
1383 res
= PAGE_SIZE
- 10;
1384 res
+= sprintf(buf
+ res
, "++more++ ");
1387 res
+= sprintf(buf
+ res
, "%s:%d ",
1388 slave
->dev
->name
, slave
->queue_id
);
1390 read_unlock(&bond
->lock
);
1392 buf
[res
-1] = '\n'; /* eat the leftover space */
1398 * Set the queue_ids of the slaves in the current bond. The bond
1399 * interface must be enslaved for this to work.
1401 static ssize_t
bonding_store_queue_id(struct device
*d
,
1402 struct device_attribute
*attr
,
1403 const char *buffer
, size_t count
)
1405 struct slave
*slave
, *update_slave
;
1406 struct bonding
*bond
= to_bond(d
);
1410 struct net_device
*sdev
= NULL
;
1412 if (!rtnl_trylock())
1413 return restart_syscall();
1415 /* delim will point to queue id if successful */
1416 delim
= strchr(buffer
, ':');
1421 * Terminate string that points to device name and bump it
1422 * up one, so we can read the queue id there.
1425 if (sscanf(++delim
, "%hd\n", &qid
) != 1)
1428 /* Check buffer length, valid ifname and queue id */
1429 if (strlen(buffer
) > IFNAMSIZ
||
1430 !dev_valid_name(buffer
) ||
1431 qid
> bond
->params
.tx_queues
)
1434 /* Get the pointer to that interface if it exists */
1435 sdev
= __dev_get_by_name(dev_net(bond
->dev
), buffer
);
1439 read_lock(&bond
->lock
);
1441 /* Search for thes slave and check for duplicate qids */
1442 update_slave
= NULL
;
1443 bond_for_each_slave(bond
, slave
, i
) {
1444 if (sdev
== slave
->dev
)
1446 * We don't need to check the matching
1447 * slave for dups, since we're overwriting it
1449 update_slave
= slave
;
1450 else if (qid
&& qid
== slave
->queue_id
) {
1451 goto err_no_cmd_unlock
;
1456 goto err_no_cmd_unlock
;
1458 /* Actually set the qids for the slave */
1459 update_slave
->queue_id
= qid
;
1461 read_unlock(&bond
->lock
);
1467 read_unlock(&bond
->lock
);
1469 pr_info("invalid input for queue_id set for %s.\n",
1475 static DEVICE_ATTR(queue_id
, S_IRUGO
| S_IWUSR
, bonding_show_queue_id
,
1476 bonding_store_queue_id
);
1480 * Show and set the all_slaves_active flag.
1482 static ssize_t
bonding_show_slaves_active(struct device
*d
,
1483 struct device_attribute
*attr
,
1486 struct bonding
*bond
= to_bond(d
);
1488 return sprintf(buf
, "%d\n", bond
->params
.all_slaves_active
);
1491 static ssize_t
bonding_store_slaves_active(struct device
*d
,
1492 struct device_attribute
*attr
,
1493 const char *buf
, size_t count
)
1495 int i
, new_value
, ret
= count
;
1496 struct bonding
*bond
= to_bond(d
);
1497 struct slave
*slave
;
1499 if (sscanf(buf
, "%d", &new_value
) != 1) {
1500 pr_err("%s: no all_slaves_active value specified.\n",
1506 if (new_value
== bond
->params
.all_slaves_active
)
1509 if ((new_value
== 0) || (new_value
== 1)) {
1510 bond
->params
.all_slaves_active
= new_value
;
1512 pr_info("%s: Ignoring invalid all_slaves_active value %d.\n",
1513 bond
->dev
->name
, new_value
);
1518 bond_for_each_slave(bond
, slave
, i
) {
1519 if (!bond_is_active_slave(slave
)) {
1521 slave
->inactive
= 0;
1523 slave
->inactive
= 1;
1529 static DEVICE_ATTR(all_slaves_active
, S_IRUGO
| S_IWUSR
,
1530 bonding_show_slaves_active
, bonding_store_slaves_active
);
1533 * Show and set the number of IGMP membership reports to send on link failure
1535 static ssize_t
bonding_show_resend_igmp(struct device
*d
,
1536 struct device_attribute
*attr
,
1539 struct bonding
*bond
= to_bond(d
);
1541 return sprintf(buf
, "%d\n", bond
->params
.resend_igmp
);
1544 static ssize_t
bonding_store_resend_igmp(struct device
*d
,
1545 struct device_attribute
*attr
,
1546 const char *buf
, size_t count
)
1548 int new_value
, ret
= count
;
1549 struct bonding
*bond
= to_bond(d
);
1551 if (sscanf(buf
, "%d", &new_value
) != 1) {
1552 pr_err("%s: no resend_igmp value specified.\n",
1558 if (new_value
< 0 || new_value
> 255) {
1559 pr_err("%s: Invalid resend_igmp value %d not in range 0-255; rejected.\n",
1560 bond
->dev
->name
, new_value
);
1565 pr_info("%s: Setting resend_igmp to %d.\n",
1566 bond
->dev
->name
, new_value
);
1567 bond
->params
.resend_igmp
= new_value
;
1572 static DEVICE_ATTR(resend_igmp
, S_IRUGO
| S_IWUSR
,
1573 bonding_show_resend_igmp
, bonding_store_resend_igmp
);
1575 static struct attribute
*per_bond_attrs
[] = {
1576 &dev_attr_slaves
.attr
,
1577 &dev_attr_mode
.attr
,
1578 &dev_attr_fail_over_mac
.attr
,
1579 &dev_attr_arp_validate
.attr
,
1580 &dev_attr_arp_interval
.attr
,
1581 &dev_attr_arp_ip_target
.attr
,
1582 &dev_attr_downdelay
.attr
,
1583 &dev_attr_updelay
.attr
,
1584 &dev_attr_lacp_rate
.attr
,
1585 &dev_attr_ad_select
.attr
,
1586 &dev_attr_xmit_hash_policy
.attr
,
1587 &dev_attr_num_grat_arp
.attr
,
1588 &dev_attr_num_unsol_na
.attr
,
1589 &dev_attr_miimon
.attr
,
1590 &dev_attr_primary
.attr
,
1591 &dev_attr_primary_reselect
.attr
,
1592 &dev_attr_use_carrier
.attr
,
1593 &dev_attr_active_slave
.attr
,
1594 &dev_attr_mii_status
.attr
,
1595 &dev_attr_ad_aggregator
.attr
,
1596 &dev_attr_ad_num_ports
.attr
,
1597 &dev_attr_ad_actor_key
.attr
,
1598 &dev_attr_ad_partner_key
.attr
,
1599 &dev_attr_ad_partner_mac
.attr
,
1600 &dev_attr_queue_id
.attr
,
1601 &dev_attr_all_slaves_active
.attr
,
1602 &dev_attr_resend_igmp
.attr
,
1606 static struct attribute_group bonding_group
= {
1608 .attrs
= per_bond_attrs
,
1612 * Initialize sysfs. This sets up the bonding_masters file in
1615 int bond_create_sysfs(void)
1619 ret
= netdev_class_create_file(&class_attr_bonding_masters
);
1621 * Permit multiple loads of the module by ignoring failures to
1622 * create the bonding_masters sysfs file. Bonding devices
1623 * created by second or subsequent loads of the module will
1624 * not be listed in, or controllable by, bonding_masters, but
1625 * will have the usual "bonding" sysfs directory.
1627 * This is done to preserve backwards compatibility for
1628 * initscripts/sysconfig, which load bonding multiple times to
1629 * configure multiple bonding devices.
1631 if (ret
== -EEXIST
) {
1632 /* Is someone being kinky and naming a device bonding_master? */
1633 if (__dev_get_by_name(&init_net
,
1634 class_attr_bonding_masters
.attr
.name
))
1635 pr_err("network device named %s already exists in sysfs",
1636 class_attr_bonding_masters
.attr
.name
);
1645 * Remove /sys/class/net/bonding_masters.
1647 void bond_destroy_sysfs(void)
1649 netdev_class_remove_file(&class_attr_bonding_masters
);
1653 * Initialize sysfs for each bond. This sets up and registers
1654 * the 'bondctl' directory for each individual bond under /sys/class/net.
1656 void bond_prepare_sysfs_group(struct bonding
*bond
)
1658 bond
->dev
->sysfs_groups
[0] = &bonding_group
;