drm: simplify error printing in drm_debugfs_create_files
[linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git] / drivers / gpu / drm / drm_debugfs.c
blobb9dc2629ea9aec5f8f7fd583be1e070e4871828f
1 /**
2 * \file drm_debugfs.c
3 * debugfs support for DRM
5 * \author Ben Gamari <bgamari@gmail.com>
6 */
8 /*
9 * Created: Sun Dec 21 13:08:50 2008 by bgamari@gmail.com
11 * Copyright 2008 Ben Gamari <bgamari@gmail.com>
13 * Permission is hereby granted, free of charge, to any person obtaining a
14 * copy of this software and associated documentation files (the "Software"),
15 * to deal in the Software without restriction, including without limitation
16 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
17 * and/or sell copies of the Software, and to permit persons to whom the
18 * Software is furnished to do so, subject to the following conditions:
20 * The above copyright notice and this permission notice (including the next
21 * paragraph) shall be included in all copies or substantial portions of the
22 * Software.
24 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
25 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
26 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
27 * VA LINUX SYSTEMS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
28 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
29 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
30 * OTHER DEALINGS IN THE SOFTWARE.
33 #include <linux/debugfs.h>
34 #include <linux/seq_file.h>
35 #include <linux/slab.h>
36 #include "drmP.h"
38 #if defined(CONFIG_DEBUG_FS)
40 /***************************************************
41 * Initialization, etc.
42 **************************************************/
44 static struct drm_info_list drm_debugfs_list[] = {
45 {"name", drm_name_info, 0},
46 {"vm", drm_vm_info, 0},
47 {"clients", drm_clients_info, 0},
48 {"queues", drm_queues_info, 0},
49 {"bufs", drm_bufs_info, 0},
50 {"gem_names", drm_gem_name_info, DRIVER_GEM},
51 #if DRM_DEBUG_CODE
52 {"vma", drm_vma_info, 0},
53 #endif
55 #define DRM_DEBUGFS_ENTRIES ARRAY_SIZE(drm_debugfs_list)
58 static int drm_debugfs_open(struct inode *inode, struct file *file)
60 struct drm_info_node *node = inode->i_private;
62 return single_open(file, node->info_ent->show, node);
66 static const struct file_operations drm_debugfs_fops = {
67 .owner = THIS_MODULE,
68 .open = drm_debugfs_open,
69 .read = seq_read,
70 .llseek = seq_lseek,
71 .release = single_release,
75 /**
76 * Initialize a given set of debugfs files for a device
78 * \param files The array of files to create
79 * \param count The number of files given
80 * \param root DRI debugfs dir entry.
81 * \param minor device minor number
82 * \return Zero on success, non-zero on failure
84 * Create a given set of debugfs files represented by an array of
85 * gdm_debugfs_lists in the given root directory.
87 int drm_debugfs_create_files(struct drm_info_list *files, int count,
88 struct dentry *root, struct drm_minor *minor)
90 struct drm_device *dev = minor->dev;
91 struct dentry *ent;
92 struct drm_info_node *tmp;
93 int i, ret;
95 for (i = 0; i < count; i++) {
96 u32 features = files[i].driver_features;
98 if (features != 0 &&
99 (dev->driver->driver_features & features) != features)
100 continue;
102 tmp = kmalloc(sizeof(struct drm_info_node), GFP_KERNEL);
103 if (tmp == NULL) {
104 ret = -1;
105 goto fail;
107 ent = debugfs_create_file(files[i].name, S_IFREG | S_IRUGO,
108 root, tmp, &drm_debugfs_fops);
109 if (!ent) {
110 DRM_ERROR("Cannot create /sys/kernel/debug/dri/%s/%s\n",
111 root->d_name.name, files[i].name);
112 kfree(tmp);
113 ret = -1;
114 goto fail;
117 tmp->minor = minor;
118 tmp->dent = ent;
119 tmp->info_ent = &files[i];
120 list_add(&(tmp->list), &(minor->debugfs_nodes.list));
122 return 0;
124 fail:
125 drm_debugfs_remove_files(files, count, minor);
126 return ret;
128 EXPORT_SYMBOL(drm_debugfs_create_files);
131 * Initialize the DRI debugfs filesystem for a device
133 * \param dev DRM device
134 * \param minor device minor number
135 * \param root DRI debugfs dir entry.
137 * Create the DRI debugfs root entry "/sys/kernel/debug/dri", the device debugfs root entry
138 * "/sys/kernel/debug/dri/%minor%/", and each entry in debugfs_list as
139 * "/sys/kernel/debug/dri/%minor%/%name%".
141 int drm_debugfs_init(struct drm_minor *minor, int minor_id,
142 struct dentry *root)
144 struct drm_device *dev = minor->dev;
145 char name[64];
146 int ret;
148 INIT_LIST_HEAD(&minor->debugfs_nodes.list);
149 sprintf(name, "%d", minor_id);
150 minor->debugfs_root = debugfs_create_dir(name, root);
151 if (!minor->debugfs_root) {
152 DRM_ERROR("Cannot create /sys/kernel/debug/dri/%s\n", name);
153 return -1;
156 ret = drm_debugfs_create_files(drm_debugfs_list, DRM_DEBUGFS_ENTRIES,
157 minor->debugfs_root, minor);
158 if (ret) {
159 debugfs_remove(minor->debugfs_root);
160 minor->debugfs_root = NULL;
161 DRM_ERROR("Failed to create core drm debugfs files\n");
162 return ret;
165 if (dev->driver->debugfs_init) {
166 ret = dev->driver->debugfs_init(minor);
167 if (ret) {
168 DRM_ERROR("DRM: Driver failed to initialize "
169 "/sys/kernel/debug/dri.\n");
170 return ret;
173 return 0;
178 * Remove a list of debugfs files
180 * \param files The list of files
181 * \param count The number of files
182 * \param minor The minor of which we should remove the files
183 * \return always zero.
185 * Remove all debugfs entries created by debugfs_init().
187 int drm_debugfs_remove_files(struct drm_info_list *files, int count,
188 struct drm_minor *minor)
190 struct list_head *pos, *q;
191 struct drm_info_node *tmp;
192 int i;
194 for (i = 0; i < count; i++) {
195 list_for_each_safe(pos, q, &minor->debugfs_nodes.list) {
196 tmp = list_entry(pos, struct drm_info_node, list);
197 if (tmp->info_ent == &files[i]) {
198 debugfs_remove(tmp->dent);
199 list_del(pos);
200 kfree(tmp);
204 return 0;
206 EXPORT_SYMBOL(drm_debugfs_remove_files);
209 * Cleanup the debugfs filesystem resources.
211 * \param minor device minor number.
212 * \return always zero.
214 * Remove all debugfs entries created by debugfs_init().
216 int drm_debugfs_cleanup(struct drm_minor *minor)
218 struct drm_device *dev = minor->dev;
220 if (!minor->debugfs_root)
221 return 0;
223 if (dev->driver->debugfs_cleanup)
224 dev->driver->debugfs_cleanup(minor);
226 drm_debugfs_remove_files(drm_debugfs_list, DRM_DEBUGFS_ENTRIES, minor);
228 debugfs_remove(minor->debugfs_root);
229 minor->debugfs_root = NULL;
231 return 0;
234 #endif /* CONFIG_DEBUG_FS */