drivers/ata/pata_ali.c

   1 /*
   2  * pata_ali.c   - ALI 15x3 PATA for new ATA layer
   3  *                        (C) 2005 Red Hat Inc
   4  *
   5  * based in part upon
   6  * linux/drivers/ide/pci/alim15x3.c             Version 0.17    2003/01/02
   7  *
   8  *  Copyright (C) 1998-2000 Michel Aubry, Maintainer
   9  *  Copyright (C) 1998-2000 Andrzej Krzysztofowicz, Maintainer
  10  *  Copyright (C) 1999-2000 CJ, cjtsai@ali.com.tw, Maintainer
  11  *
  12  *  Copyright (C) 1998-2000 Andre Hedrick (andre@linux-ide.org)
  13  *  May be copied or modified under the terms of the GNU General Public License
  14  *  Copyright (C) 2002 Alan Cox <alan@redhat.com>
  15  *  ALi (now ULi M5228) support by Clear Zhang <Clear.Zhang@ali.com.tw>
  16  *
  17  *  Documentation
  18  *      Chipset documentation available under NDA only
  19  *
  20  *  TODO/CHECK
  21  *      Cannot have ATAPI on both master & slave for rev < c2 (???) but
  22  *      otherwise should do atapi DMA (For now for old we do PIO only for
  23  *      ATAPI)
  24  *      Review Sunblade workaround.
  25  */
  26
  27 #include <linux/kernel.h>
  28 #include <linux/module.h>
  29 #include <linux/pci.h>
  30 #include <linux/init.h>
  31 #include <linux/blkdev.h>
  32 #include <linux/delay.h>
  33 #include <scsi/scsi_host.h>
  34 #include <linux/libata.h>
  35 #include <linux/dmi.h>
  36
  37 #define DRV_NAME "pata_ali"
  38 #define DRV_VERSION "0.7.8"
  39
  40 static int ali_atapi_dma = 0;
  41 module_param_named(atapi_dma, ali_atapi_dma, int, 0644);
  42 MODULE_PARM_DESC(atapi_dma, "Enable ATAPI DMA (0=disable, 1=enable)");
  43
  44 static struct pci_dev *ali_isa_bridge;
  45
  46 /*
  47  *      Cable special cases
  48  */
  49
  50 static const struct dmi_system_id cable_dmi_table[] = {
  51         {
  52                 .ident = "HP Pavilion N5430",
  53                 .matches = {
  54                         DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
  55                         DMI_MATCH(DMI_BOARD_VERSION, "OmniBook N32N-736"),
  56                 },
  57         },
  58         {
  59                 .ident = "Toshiba Satelite S1800-814",
  60                 .matches = {
  61                         DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
  62                         DMI_MATCH(DMI_PRODUCT_NAME, "S1800-814"),
  63                 },
  64         },
  65         { }
  66 };
  67
  68 static int ali_cable_override(struct pci_dev *pdev)
  69 {
  70         /* Fujitsu P2000 */
  71         if (pdev->subsystem_vendor == 0x10CF && pdev->subsystem_device == 0x10AF)
  72                 return 1;
  73         /* Mitac 8317 (Winbook-A) and relatives */
  74         if (pdev->subsystem_vendor == 0x1071 && pdev->subsystem_device == 0x8317)
  75                 return 1;
  76         /* Systems by DMI */
  77         if (dmi_check_system(cable_dmi_table))
  78                 return 1;
  79         return 0;
  80 }
  81
  82 /**
  83  *      ali_c2_cable_detect     -       cable detection
  84  *      @ap: ATA port
  85  *
  86  *      Perform cable detection for C2 and later revisions
  87  */
  88
  89 static int ali_c2_cable_detect(struct ata_port *ap)
  90 {
  91         struct pci_dev *pdev = to_pci_dev(ap->host->dev);
  92         u8 ata66;
  93
  94         /* Certain laptops use short but suitable cables and don't
  95            implement the detect logic */
  96
  97         if (ali_cable_override(pdev))
  98                 return ATA_CBL_PATA40_SHORT;
  99
 100         /* Host view cable detect 0x4A bit 0 primary bit 1 secondary
 101            Bit set for 40 pin */
 102         pci_read_config_byte(pdev, 0x4A, &ata66);
 103         if (ata66 & (1 << ap->port_no))
 104                 return ATA_CBL_PATA40;
 105         else
 106                 return ATA_CBL_PATA80;
 107 }
 108
 109 /**
 110  *      ali_20_filter           -       filter for earlier ALI DMA
 111  *      @ap: ALi ATA port
 112  *      @adev: attached device
 113  *
 114  *      Ensure that we do not do DMA on CD devices. We may be able to
 115  *      fix that later on. Also ensure we do not do UDMA on WDC drives
 116  */
 117
 118 static unsigned long ali_20_filter(struct ata_device *adev, unsigned long mask)
 119 {
 120         char model_num[ATA_ID_PROD_LEN + 1];
 121         /* No DMA on anything but a disk for now */
 122         if (adev->class != ATA_DEV_ATA)
 123                 mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA);
 124         ata_id_c_string(adev->id, model_num, ATA_ID_PROD, sizeof(model_num));
 125         if (strstr(model_num, "WDC"))
 126                 return mask &= ~ATA_MASK_UDMA;
 127         return ata_bmdma_mode_filter(adev, mask);
 128 }
 129
 130 /**
 131  *      ali_fifo_control        -       FIFO manager
 132  *      @ap: ALi channel to control
 133  *      @adev: device for FIFO control
 134  *      @on: 0 for off 1 for on
 135  *
 136  *      Enable or disable the FIFO on a given device. Because of the way the
 137  *      ALi FIFO works it provides a boost on ATA disk but can be confused by
 138  *      ATAPI and we must therefore manage it.
 139  */
 140
 141 static void ali_fifo_control(struct ata_port *ap, struct ata_device *adev, int on)
 142 {
 143         struct pci_dev *pdev = to_pci_dev(ap->host->dev);
 144         int pio_fifo = 0x54 + ap->port_no;
 145         u8 fifo;
 146         int shift = 4 * adev->devno;
 147
 148         /* ATA - FIFO on set nibble to 0x05, ATAPI - FIFO off, set nibble to
 149            0x00. Not all the docs agree but the behaviour we now use is the
 150            one stated in the BIOS Programming Guide */
 151
 152         pci_read_config_byte(pdev, pio_fifo, &fifo);
 153         fifo &= ~(0x0F << shift);
 154         fifo |= (on << shift);
 155         pci_write_config_byte(pdev, pio_fifo, fifo);
 156 }
 157
 158 /**
 159  *      ali_program_modes       -       load mode registers
 160  *      @ap: ALi channel to load
 161  *      @adev: Device the timing is for
 162  *      @cmd: Command timing
 163  *      @data: Data timing
 164  *      @ultra: UDMA timing or zero for off
 165  *
 166  *      Loads the timing registers for cmd/data and disable UDMA if
 167  *      ultra is zero. If ultra is set then load and enable the UDMA
 168  *      timing but do not touch the command/data timing.
 169  */
 170
 171 static void ali_program_modes(struct ata_port *ap, struct ata_device *adev, struct ata_timing *t, u8 ultra)
 172 {
 173         struct pci_dev *pdev = to_pci_dev(ap->host->dev);
 174         int cas = 0x58 + 4 * ap->port_no;       /* Command timing */
 175         int cbt = 0x59 + 4 * ap->port_no;       /* Command timing */
 176         int drwt = 0x5A + 4 * ap->port_no + adev->devno; /* R/W timing */
 177         int udmat = 0x56 + ap->port_no; /* UDMA timing */
 178         int shift = 4 * adev->devno;
 179         u8 udma;
 180
 181         if (t != NULL) {
 182                 t->setup = clamp_val(t->setup, 1, 8) & 7;
 183                 t->act8b = clamp_val(t->act8b, 1, 8) & 7;
 184                 t->rec8b = clamp_val(t->rec8b, 1, 16) & 15;
 185                 t->active = clamp_val(t->active, 1, 8) & 7;
 186                 t->recover = clamp_val(t->recover, 1, 16) & 15;
 187
 188                 pci_write_config_byte(pdev, cas, t->setup);
 189                 pci_write_config_byte(pdev, cbt, (t->act8b << 4) | t->rec8b);
 190                 pci_write_config_byte(pdev, drwt, (t->active << 4) | t->recover);
 191         }
 192
 193         /* Set up the UDMA enable */
 194         pci_read_config_byte(pdev, udmat, &udma);
 195         udma &= ~(0x0F << shift);
 196         udma |= ultra << shift;
 197         pci_write_config_byte(pdev, udmat, udma);
 198 }
 199
 200 /**
 201  *      ali_set_piomode -       set initial PIO mode data
 202  *      @ap: ATA interface
 203  *      @adev: ATA device
 204  *
 205  *      Program the ALi registers for PIO mode. FIXME: add timings for
 206  *      PIO5.
 207  */
 208
 209 static void ali_set_piomode(struct ata_port *ap, struct ata_device *adev)
 210 {
 211         struct ata_device *pair = ata_dev_pair(adev);
 212         struct ata_timing t;
 213         unsigned long T =  1000000000 / 33333;  /* PCI clock based */
 214
 215         ata_timing_compute(adev, adev->pio_mode, &t, T, 1);
 216         if (pair) {
 217                 struct ata_timing p;
 218                 ata_timing_compute(pair, pair->pio_mode, &p, T, 1);
 219                 ata_timing_merge(&p, &t, &t, ATA_TIMING_SETUP|ATA_TIMING_8BIT);
 220                 if (pair->dma_mode) {
 221                         ata_timing_compute(pair, pair->dma_mode, &p, T, 1);
 222                         ata_timing_merge(&p, &t, &t, ATA_TIMING_SETUP|ATA_TIMING_8BIT);
 223                 }
 224         }
 225
 226         /* PIO FIFO is only permitted on ATA disk */
 227         if (adev->class != ATA_DEV_ATA)
 228                 ali_fifo_control(ap, adev, 0x00);
 229         ali_program_modes(ap, adev, &t, 0);
 230         if (adev->class == ATA_DEV_ATA)
 231                 ali_fifo_control(ap, adev, 0x05);
 232
 233 }
 234
 235 /**
 236  *      ali_set_dmamode -       set initial DMA mode data
 237  *      @ap: ATA interface
 238  *      @adev: ATA device
 239  *
 240  *      FIXME: MWDMA timings
 241  */
 242
 243 static void ali_set_dmamode(struct ata_port *ap, struct ata_device *adev)
 244 {
 245         static u8 udma_timing[7] = { 0xC, 0xB, 0xA, 0x9, 0x8, 0xF, 0xD };
 246         struct ata_device *pair = ata_dev_pair(adev);
 247         struct ata_timing t;
 248         unsigned long T =  1000000000 / 33333;  /* PCI clock based */
 249         struct pci_dev *pdev = to_pci_dev(ap->host->dev);
 250
 251
 252         if (adev->class == ATA_DEV_ATA)
 253                 ali_fifo_control(ap, adev, 0x08);
 254
 255         if (adev->dma_mode >= XFER_UDMA_0) {
 256                 ali_program_modes(ap, adev, NULL, udma_timing[adev->dma_mode - XFER_UDMA_0]);
 257                 if (adev->dma_mode >= XFER_UDMA_3) {
 258                         u8 reg4b;
 259                         pci_read_config_byte(pdev, 0x4B, &reg4b);
 260                         reg4b |= 1;
 261                         pci_write_config_byte(pdev, 0x4B, reg4b);
 262                 }
 263         } else {
 264                 ata_timing_compute(adev, adev->dma_mode, &t, T, 1);
 265                 if (pair) {
 266                         struct ata_timing p;
 267                         ata_timing_compute(pair, pair->pio_mode, &p, T, 1);
 268                         ata_timing_merge(&p, &t, &t, ATA_TIMING_SETUP|ATA_TIMING_8BIT);
 269                         if (pair->dma_mode) {
 270                                 ata_timing_compute(pair, pair->dma_mode, &p, T, 1);
 271                                 ata_timing_merge(&p, &t, &t, ATA_TIMING_SETUP|ATA_TIMING_8BIT);
 272                         }
 273                 }
 274                 ali_program_modes(ap, adev, &t, 0);
 275         }
 276 }
 277
 278 /**
 279  *      ali_warn_atapi_dma      -       Warn about ATAPI DMA disablement
 280  *      @adev: Device
 281  *
 282  *      Whine about ATAPI DMA disablement if @adev is an ATAPI device.
 283  *      Can be used as ->dev_config.
 284  */
 285
 286 static void ali_warn_atapi_dma(struct ata_device *adev)
 287 {
 288         struct ata_eh_context *ehc = &adev->link->eh_context;
 289         int print_info = ehc->i.flags & ATA_EHI_PRINTINFO;
 290
 291         if (print_info && adev->class == ATA_DEV_ATAPI && !ali_atapi_dma) {
 292                 ata_dev_printk(adev, KERN_WARNING,
 293                                "WARNING: ATAPI DMA disabled for reliablity issues.  It can be enabled\n");
 294                 ata_dev_printk(adev, KERN_WARNING,
 295                                "WARNING: via pata_ali.atapi_dma modparam or corresponding sysfs node.\n");
 296         }
 297 }
 298
 299 /**
 300  *      ali_lock_sectors        -       Keep older devices to 255 sector mode
 301  *      @adev: Device
 302  *
 303  *      Called during the bus probe for each device that is found. We use
 304  *      this call to lock the sector count of the device to 255 or less on
 305  *      older ALi controllers. If we didn't do this then large I/O's would
 306  *      require LBA48 commands which the older ALi requires are issued by
 307  *      slower PIO methods
 308  */
 309
 310 static void ali_lock_sectors(struct ata_device *adev)
 311 {
 312         adev->max_sectors = 255;
 313         ali_warn_atapi_dma(adev);
 314 }
 315
 316 /**
 317  *      ali_check_atapi_dma     -       DMA check for most ALi controllers
 318  *      @adev: Device
 319  *
 320  *      Called to decide whether commands should be sent by DMA or PIO
 321  */
 322
 323 static int ali_check_atapi_dma(struct ata_queued_cmd *qc)
 324 {
 325         if (!ali_atapi_dma) {
 326                 /* FIXME: pata_ali can't do ATAPI DMA reliably but the
 327                  * IDE alim15x3 driver can.  I tried lots of things
 328                  * but couldn't find what the actual difference was.
 329                  * If you got an idea, please write it to
 330                  * linux-ide@vger.kernel.org and cc htejun@gmail.com.
 331                  *
 332                  * Disable ATAPI DMA for now.
 333                  */
 334                 return -EOPNOTSUPP;
 335         }
 336
 337         /* If its not a media command, its not worth it */
 338         if (atapi_cmd_type(qc->cdb[0]) == ATAPI_MISC)
 339                 return -EOPNOTSUPP;
 340         return 0;
 341 }
 342
 343 static void ali_c2_c3_postreset(struct ata_link *link, unsigned int *classes)
 344 {
 345         u8 r;
 346         int port_bit = 4 << link->ap->port_no;
 347
 348         /* If our bridge is an ALI 1533 then do the extra work */
 349         if (ali_isa_bridge) {
 350                 /* Tristate and re-enable the bus signals */
 351                 pci_read_config_byte(ali_isa_bridge, 0x58, &r);
 352                 r &= ~port_bit;
 353                 pci_write_config_byte(ali_isa_bridge, 0x58, r);
 354                 r |= port_bit;
 355                 pci_write_config_byte(ali_isa_bridge, 0x58, r);
 356         }
 357         ata_sff_postreset(link, classes);
 358 }
 359
 360 static struct scsi_host_template ali_sht = {
 361         ATA_BMDMA_SHT(DRV_NAME),
 362 };
 363
 364 /*
 365  *      Port operations for PIO only ALi
 366  */
 367
 368 static struct ata_port_operations ali_early_port_ops = {
 369         .inherits       = &ata_sff_port_ops,
 370         .cable_detect   = ata_cable_40wire,
 371         .set_piomode    = ali_set_piomode,
 372         .sff_data_xfer  = ata_sff_data_xfer32,
 373 };
 374
 375 static const struct ata_port_operations ali_dma_base_ops = {
 376         .inherits       = &ata_bmdma32_port_ops,
 377         .set_piomode    = ali_set_piomode,
 378         .set_dmamode    = ali_set_dmamode,
 379 };
 380
 381 /*
 382  *      Port operations for DMA capable ALi without cable
 383  *      detect
 384  */
 385 static struct ata_port_operations ali_20_port_ops = {
 386         .inherits       = &ali_dma_base_ops,
 387         .cable_detect   = ata_cable_40wire,
 388         .mode_filter    = ali_20_filter,
 389         .check_atapi_dma = ali_check_atapi_dma,
 390         .dev_config     = ali_lock_sectors,
 391 };
 392
 393 /*
 394  *      Port operations for DMA capable ALi with cable detect
 395  */
 396 static struct ata_port_operations ali_c2_port_ops = {
 397         .inherits       = &ali_dma_base_ops,
 398         .check_atapi_dma = ali_check_atapi_dma,
 399         .cable_detect   = ali_c2_cable_detect,
 400         .dev_config     = ali_lock_sectors,
 401         .postreset      = ali_c2_c3_postreset,
 402 };
 403
 404 /*
 405  *      Port operations for DMA capable ALi with cable detect
 406  */
 407 static struct ata_port_operations ali_c4_port_ops = {
 408         .inherits       = &ali_dma_base_ops,
 409         .check_atapi_dma = ali_check_atapi_dma,
 410         .cable_detect   = ali_c2_cable_detect,
 411         .dev_config     = ali_lock_sectors,
 412 };
 413
 414 /*
 415  *      Port operations for DMA capable ALi with cable detect and LBA48
 416  */
 417 static struct ata_port_operations ali_c5_port_ops = {
 418         .inherits       = &ali_dma_base_ops,
 419         .check_atapi_dma = ali_check_atapi_dma,
 420         .dev_config     = ali_warn_atapi_dma,
 421         .cable_detect   = ali_c2_cable_detect,
 422 };
 423
 424
 425 /**
 426  *      ali_init_chipset        -       chip setup function
 427  *      @pdev: PCI device of ATA controller
 428  *
 429  *      Perform the setup on the device that must be done both at boot
 430  *      and at resume time.
 431  */
 432
 433 static void ali_init_chipset(struct pci_dev *pdev)
 434 {
 435         u8 tmp;
 436         struct pci_dev *north;
 437
 438         /*
 439          * The chipset revision selects the driver operations and
 440          * mode data.
 441          */
 442
 443         if (pdev->revision <= 0x20) {
 444                 pci_read_config_byte(pdev, 0x53, &tmp);
 445                 tmp |= 0x03;
 446                 pci_write_config_byte(pdev, 0x53, tmp);
 447         } else {
 448                 pci_read_config_byte(pdev, 0x4a, &tmp);
 449                 pci_write_config_byte(pdev, 0x4a, tmp | 0x20);
 450                 pci_read_config_byte(pdev, 0x4B, &tmp);
 451                 if (pdev->revision < 0xC2)
 452                         /* 1543-E/F, 1543C-C, 1543C-D, 1543C-E */
 453                         /* Clear CD-ROM DMA write bit */
 454                         tmp &= 0x7F;
 455                 /* Cable and UDMA */
 456                 pci_write_config_byte(pdev, 0x4B, tmp | 0x09);
 457                 /*
 458                  * CD_ROM DMA on (0x53 bit 0). Enable this even if we want
 459                  * to use PIO. 0x53 bit 1 (rev 20 only) - enable FIFO control
 460                  * via 0x54/55.
 461                  */
 462                 pci_read_config_byte(pdev, 0x53, &tmp);
 463                 if (pdev->revision >= 0xc7)
 464                         tmp |= 0x03;
 465                 else
 466                         tmp |= 0x01;    /* CD_ROM enable for DMA */
 467                 pci_write_config_byte(pdev, 0x53, tmp);
 468         }
 469         north = pci_get_bus_and_slot(0, PCI_DEVFN(0,0));
 470         if (north && north->vendor == PCI_VENDOR_ID_AL && ali_isa_bridge) {
 471                 /* Configure the ALi bridge logic. For non ALi rely on BIOS.
 472                    Set the south bridge enable bit */
 473                 pci_read_config_byte(ali_isa_bridge, 0x79, &tmp);
 474                 if (pdev->revision == 0xC2)
 475                         pci_write_config_byte(ali_isa_bridge, 0x79, tmp | 0x04);
 476                 else if (pdev->revision > 0xC2 && pdev->revision < 0xC5)
 477                         pci_write_config_byte(ali_isa_bridge, 0x79, tmp | 0x02);
 478         }
 479         pci_dev_put(north);
 480         ata_pci_bmdma_clear_simplex(pdev);
 481 }
 482 /**
 483  *      ali_init_one            -       discovery callback
 484  *      @pdev: PCI device ID
 485  *      @id: PCI table info
 486  *
 487  *      An ALi IDE interface has been discovered. Figure out what revision
 488  *      and perform configuration work before handing it to the ATA layer
 489  */
 490
 491 static int ali_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
 492 {
 493         static const struct ata_port_info info_early = {
 494                 .flags = ATA_FLAG_SLAVE_POSS,
 495                 .pio_mask = ATA_PIO4,
 496                 .port_ops = &ali_early_port_ops
 497         };
 498         /* Revision 0x20 added DMA */
 499         static const struct ata_port_info info_20 = {
 500                 .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
 501                 .pio_mask = ATA_PIO4,
 502                 .mwdma_mask = ATA_MWDMA2,
 503                 .port_ops = &ali_20_port_ops
 504         };
 505         /* Revision 0x20 with support logic added UDMA */
 506         static const struct ata_port_info info_20_udma = {
 507                 .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
 508                 .pio_mask = ATA_PIO4,
 509                 .mwdma_mask = ATA_MWDMA2,
 510                 .udma_mask = ATA_UDMA2,
 511                 .port_ops = &ali_20_port_ops
 512         };
 513         /* Revision 0xC2 adds UDMA66 */
 514         static const struct ata_port_info info_c2 = {
 515                 .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
 516                 .pio_mask = ATA_PIO4,
 517                 .mwdma_mask = ATA_MWDMA2,
 518                 .udma_mask = ATA_UDMA4,
 519                 .port_ops = &ali_c2_port_ops
 520         };
 521         /* Revision 0xC3 is UDMA66 for now */
 522         static const struct ata_port_info info_c3 = {
 523                 .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
 524                 .pio_mask = ATA_PIO4,
 525                 .mwdma_mask = ATA_MWDMA2,
 526                 .udma_mask = ATA_UDMA4,
 527                 .port_ops = &ali_c2_port_ops
 528         };
 529         /* Revision 0xC4 is UDMA100 */
 530         static const struct ata_port_info info_c4 = {
 531                 .flags = ATA_FLAG_SLAVE_POSS | ATA_FLAG_PIO_LBA48,
 532                 .pio_mask = ATA_PIO4,
 533                 .mwdma_mask = ATA_MWDMA2,
 534                 .udma_mask = ATA_UDMA5,
 535                 .port_ops = &ali_c4_port_ops
 536         };
 537         /* Revision 0xC5 is UDMA133 with LBA48 DMA */
 538         static const struct ata_port_info info_c5 = {
 539                 .flags = ATA_FLAG_SLAVE_POSS,
 540                 .pio_mask = ATA_PIO4,
 541                 .mwdma_mask = ATA_MWDMA2,
 542                 .udma_mask = ATA_UDMA6,
 543                 .port_ops = &ali_c5_port_ops
 544         };
 545
 546         const struct ata_port_info *ppi[] = { NULL, NULL };
 547         u8 tmp;
 548         int rc;
 549
 550         rc = pcim_enable_device(pdev);
 551         if (rc)
 552                 return rc;
 553
 554         /*
 555          * The chipset revision selects the driver operations and
 556          * mode data.
 557          */
 558
 559         if (pdev->revision < 0x20) {
 560                 ppi[0] = &info_early;
 561         } else if (pdev->revision < 0xC2) {
 562                 ppi[0] = &info_20;
 563         } else if (pdev->revision == 0xC2) {
 564                 ppi[0] = &info_c2;
 565         } else if (pdev->revision == 0xC3) {
 566                 ppi[0] = &info_c3;
 567         } else if (pdev->revision == 0xC4) {
 568                 ppi[0] = &info_c4;
 569         } else
 570                 ppi[0] = &info_c5;
 571
 572         ali_init_chipset(pdev);
 573
 574         if (ali_isa_bridge && pdev->revision >= 0x20 && pdev->revision < 0xC2) {
 575                 /* Are we paired with a UDMA capable chip */
 576                 pci_read_config_byte(ali_isa_bridge, 0x5E, &tmp);
 577                 if ((tmp & 0x1E) == 0x12)
 578                         ppi[0] = &info_20_udma;
 579         }
 580
 581         return ata_pci_sff_init_one(pdev, ppi, &ali_sht, NULL);
 582 }
 583
 584 #ifdef CONFIG_PM
 585 static int ali_reinit_one(struct pci_dev *pdev)
 586 {
 587         struct ata_host *host = dev_get_drvdata(&pdev->dev);
 588         int rc;
 589
 590         rc = ata_pci_device_do_resume(pdev);
 591         if (rc)
 592                 return rc;
 593         ali_init_chipset(pdev);
 594         ata_host_resume(host);
 595         return 0;
 596 }
 597 #endif
 598
 599 static const struct pci_device_id ali[] = {
 600         { PCI_VDEVICE(AL, PCI_DEVICE_ID_AL_M5228), },
 601         { PCI_VDEVICE(AL, PCI_DEVICE_ID_AL_M5229), },
 602
 603         { },
 604 };
 605
 606 static struct pci_driver ali_pci_driver = {
 607         .name           = DRV_NAME,
 608         .id_table       = ali,
 609         .probe          = ali_init_one,
 610         .remove         = ata_pci_remove_one,
 611 #ifdef CONFIG_PM
 612         .suspend        = ata_pci_device_suspend,
 613         .resume         = ali_reinit_one,
 614 #endif
 615 };
 616
 617 static int __init ali_init(void)
 618 {
 619         int ret;
 620         ali_isa_bridge = pci_get_device(PCI_VENDOR_ID_AL, PCI_DEVICE_ID_AL_M1533, NULL);
 621
 622         ret = pci_register_driver(&ali_pci_driver);
 623         if (ret < 0)
 624                 pci_dev_put(ali_isa_bridge);
 625         return ret;
 626 }
 627
 628
 629 static void __exit ali_exit(void)
 630 {
 631         pci_unregister_driver(&ali_pci_driver);
 632         pci_dev_put(ali_isa_bridge);
 633 }
 634
 635
 636 MODULE_AUTHOR("Alan Cox");
 637 MODULE_DESCRIPTION("low-level driver for ALi PATA");
 638 MODULE_LICENSE("GPL");
 639 MODULE_DEVICE_TABLE(pci, ali);
 640 MODULE_VERSION(DRV_VERSION);
 641
 642 module_init(ali_init);
 643 module_exit(ali_exit);