PCI: rpaphp: Fix a memleak; slot->location string was never freed
[linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git] / drivers / pci / hotplug / rpaphp_slot.c
blob865b0b7ef20c4164ed8578abfa5e93bc5b28d7b4
1 /*
2 * RPA Virtual I/O device functions
3 * Copyright (C) 2004 Linda Xie <lxie@us.ibm.com>
5 * All rights reserved.
7 * This program is free software; you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License as published by
9 * the Free Software Foundation; either version 2 of the License, or (at
10 * your option) any later version.
12 * This program is distributed in the hope that it will be useful, but
13 * WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
15 * NON INFRINGEMENT. See the GNU General Public License for more
16 * details.
18 * You should have received a copy of the GNU General Public License
19 * along with this program; if not, write to the Free Software
20 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
22 * Send feedback to <lxie@us.ibm.com>
25 #include <linux/kernel.h>
26 #include <linux/module.h>
27 #include <linux/kobject.h>
28 #include <linux/sysfs.h>
29 #include <linux/pci.h>
30 #include <linux/string.h>
31 #include <linux/slab.h>
33 #include <asm/rtas.h>
34 #include "rpaphp.h"
36 static ssize_t location_read_file (struct hotplug_slot *php_slot, char *buf)
38 char *value;
39 int retval = -ENOENT;
40 struct slot *slot = (struct slot *)php_slot->private;
42 if (!slot)
43 return retval;
45 value = slot->location;
46 retval = sprintf (buf, "%s\n", value);
47 return retval;
50 static struct hotplug_slot_attribute php_attr_location = {
51 .attr = {.name = "phy_location", .mode = S_IFREG | S_IRUGO},
52 .show = location_read_file,
55 /* free up the memory used by a slot */
56 static void rpaphp_release_slot(struct hotplug_slot *hotplug_slot)
58 struct slot *slot = (struct slot *) hotplug_slot->private;
59 dealloc_slot_struct(slot);
62 void dealloc_slot_struct(struct slot *slot)
64 kfree(slot->hotplug_slot->info);
65 kfree(slot->hotplug_slot->name);
66 kfree(slot->hotplug_slot);
67 kfree(slot->location);
68 kfree(slot);
71 struct slot *alloc_slot_struct(struct device_node *dn,
72 int drc_index, char *drc_name, int power_domain)
74 struct slot *slot;
76 slot = kzalloc(sizeof(struct slot), GFP_KERNEL);
77 if (!slot)
78 goto error_nomem;
79 slot->hotplug_slot = kzalloc(sizeof(struct hotplug_slot), GFP_KERNEL);
80 if (!slot->hotplug_slot)
81 goto error_slot;
82 slot->hotplug_slot->info = kzalloc(sizeof(struct hotplug_slot_info),
83 GFP_KERNEL);
84 if (!slot->hotplug_slot->info)
85 goto error_hpslot;
86 slot->hotplug_slot->name = kmalloc(BUS_ID_SIZE + 1, GFP_KERNEL);
87 if (!slot->hotplug_slot->name)
88 goto error_info;
89 slot->location = kmalloc(strlen(drc_name) + 1, GFP_KERNEL);
90 if (!slot->location)
91 goto error_name;
92 slot->name = slot->hotplug_slot->name;
93 slot->dn = dn;
94 slot->index = drc_index;
95 strcpy(slot->location, drc_name);
96 slot->power_domain = power_domain;
97 slot->hotplug_slot->private = slot;
98 slot->hotplug_slot->ops = &rpaphp_hotplug_slot_ops;
99 slot->hotplug_slot->release = &rpaphp_release_slot;
101 return (slot);
103 error_name:
104 kfree(slot->hotplug_slot->name);
105 error_info:
106 kfree(slot->hotplug_slot->info);
107 error_hpslot:
108 kfree(slot->hotplug_slot);
109 error_slot:
110 kfree(slot);
111 error_nomem:
112 return NULL;
115 static int is_registered(struct slot *slot)
117 struct slot *tmp_slot;
119 list_for_each_entry(tmp_slot, &rpaphp_slot_head, rpaphp_slot_list) {
120 if (!strcmp(tmp_slot->name, slot->name))
121 return 1;
123 return 0;
126 int rpaphp_deregister_slot(struct slot *slot)
128 int retval = 0;
129 struct hotplug_slot *php_slot = slot->hotplug_slot;
131 dbg("%s - Entry: deregistering slot=%s\n",
132 __FUNCTION__, slot->name);
134 list_del(&slot->rpaphp_slot_list);
136 /* remove "phy_location" file */
137 sysfs_remove_file(&php_slot->kobj, &php_attr_location.attr);
139 retval = pci_hp_deregister(php_slot);
140 if (retval)
141 err("Problem unregistering a slot %s\n", slot->name);
143 dbg("%s - Exit: rc[%d]\n", __FUNCTION__, retval);
144 return retval;
146 EXPORT_SYMBOL_GPL(rpaphp_deregister_slot);
148 int rpaphp_register_slot(struct slot *slot)
150 struct hotplug_slot *php_slot = slot->hotplug_slot;
151 int retval;
153 dbg("%s registering slot:path[%s] index[%x], name[%s] pdomain[%x] type[%d]\n",
154 __FUNCTION__, slot->dn->full_name, slot->index, slot->name,
155 slot->power_domain, slot->type);
157 /* should not try to register the same slot twice */
158 if (is_registered(slot)) {
159 err("rpaphp_register_slot: slot[%s] is already registered\n", slot->name);
160 retval = -EAGAIN;
161 goto register_fail;
164 retval = pci_hp_register(php_slot);
165 if (retval) {
166 err("pci_hp_register failed with error %d\n", retval);
167 goto register_fail;
170 /* create "phy_location" file */
171 retval = sysfs_create_file(&php_slot->kobj, &php_attr_location.attr);
172 if (retval) {
173 err("sysfs_create_file failed with error %d\n", retval);
174 goto sysfs_fail;
177 /* add slot to our internal list */
178 list_add(&slot->rpaphp_slot_list, &rpaphp_slot_head);
179 info("Slot [%s](PCI location=%s) registered\n", slot->name,
180 slot->location);
181 return 0;
183 sysfs_fail:
184 pci_hp_deregister(php_slot);
185 register_fail:
186 return retval;
189 int rpaphp_get_power_status(struct slot *slot, u8 * value)
191 int rc = 0, level;
193 rc = rtas_get_power_level(slot->power_domain, &level);
194 if (rc < 0) {
195 err("failed to get power-level for slot(%s), rc=0x%x\n",
196 slot->location, rc);
197 return rc;
200 dbg("%s the power level of slot %s(pwd-domain:0x%x) is %d\n",
201 __FUNCTION__, slot->name, slot->power_domain, level);
202 *value = level;
204 return rc;
207 int rpaphp_set_attention_status(struct slot *slot, u8 status)
209 int rc;
211 /* status: LED_OFF or LED_ON */
212 rc = rtas_set_indicator(DR_INDICATOR, slot->index, status);
213 if (rc < 0)
214 err("slot(name=%s location=%s index=0x%x) set attention-status(%d) failed! rc=0x%x\n",
215 slot->name, slot->location, slot->index, status, rc);
217 return rc;