slub: add ability to list alloc / free callers per slab
[linux-2.6/cjktty.git] / arch / mips / mm / cerr-sb1.c
blob4c72e650f9b61fecb3ff699b6232d49a9d4e0448
1 /*
2 * Copyright (C) 2001,2002,2003 Broadcom Corporation
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU General Public License
6 * as published by the Free Software Foundation; either version 2
7 * of the License, or (at your option) any later version.
9 * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
14 * You should have received a copy of the GNU General Public License
15 * along with this program; if not, write to the Free Software
16 * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
18 #include <linux/sched.h>
19 #include <asm/mipsregs.h>
20 #include <asm/sibyte/sb1250.h>
21 #include <asm/sibyte/sb1250_regs.h>
23 #if !defined(CONFIG_SIBYTE_BUS_WATCHER) || defined(CONFIG_SIBYTE_BW_TRACE)
24 #include <asm/io.h>
25 #include <asm/sibyte/sb1250_scd.h>
26 #endif
29 * We'd like to dump the L2_ECC_TAG register on errors, but errata make
30 * that unsafe... So for now we don't. (BCM1250/BCM112x erratum SOC-48.)
32 #undef DUMP_L2_ECC_TAG_ON_ERROR
34 /* SB1 definitions */
36 /* XXX should come from config1 XXX */
37 #define SB1_CACHE_INDEX_MASK 0x1fe0
39 #define CP0_ERRCTL_RECOVERABLE (1 << 31)
40 #define CP0_ERRCTL_DCACHE (1 << 30)
41 #define CP0_ERRCTL_ICACHE (1 << 29)
42 #define CP0_ERRCTL_MULTIBUS (1 << 23)
43 #define CP0_ERRCTL_MC_TLB (1 << 15)
44 #define CP0_ERRCTL_MC_TIMEOUT (1 << 14)
46 #define CP0_CERRI_TAG_PARITY (1 << 29)
47 #define CP0_CERRI_DATA_PARITY (1 << 28)
48 #define CP0_CERRI_EXTERNAL (1 << 26)
50 #define CP0_CERRI_IDX_VALID(c) (!((c) & CP0_CERRI_EXTERNAL))
51 #define CP0_CERRI_DATA (CP0_CERRI_DATA_PARITY)
53 #define CP0_CERRD_MULTIPLE (1 << 31)
54 #define CP0_CERRD_TAG_STATE (1 << 30)
55 #define CP0_CERRD_TAG_ADDRESS (1 << 29)
56 #define CP0_CERRD_DATA_SBE (1 << 28)
57 #define CP0_CERRD_DATA_DBE (1 << 27)
58 #define CP0_CERRD_EXTERNAL (1 << 26)
59 #define CP0_CERRD_LOAD (1 << 25)
60 #define CP0_CERRD_STORE (1 << 24)
61 #define CP0_CERRD_FILLWB (1 << 23)
62 #define CP0_CERRD_COHERENCY (1 << 22)
63 #define CP0_CERRD_DUPTAG (1 << 21)
65 #define CP0_CERRD_DPA_VALID(c) (!((c) & CP0_CERRD_EXTERNAL))
66 #define CP0_CERRD_IDX_VALID(c) \
67 (((c) & (CP0_CERRD_LOAD | CP0_CERRD_STORE)) ? (!((c) & CP0_CERRD_EXTERNAL)) : 0)
68 #define CP0_CERRD_CAUSES \
69 (CP0_CERRD_LOAD | CP0_CERRD_STORE | CP0_CERRD_FILLWB | CP0_CERRD_COHERENCY | CP0_CERRD_DUPTAG)
70 #define CP0_CERRD_TYPES \
71 (CP0_CERRD_TAG_STATE | CP0_CERRD_TAG_ADDRESS | CP0_CERRD_DATA_SBE | CP0_CERRD_DATA_DBE | CP0_CERRD_EXTERNAL)
72 #define CP0_CERRD_DATA (CP0_CERRD_DATA_SBE | CP0_CERRD_DATA_DBE)
74 static uint32_t extract_ic(unsigned short addr, int data);
75 static uint32_t extract_dc(unsigned short addr, int data);
77 static inline void breakout_errctl(unsigned int val)
79 if (val & CP0_ERRCTL_RECOVERABLE)
80 printk(" recoverable");
81 if (val & CP0_ERRCTL_DCACHE)
82 printk(" dcache");
83 if (val & CP0_ERRCTL_ICACHE)
84 printk(" icache");
85 if (val & CP0_ERRCTL_MULTIBUS)
86 printk(" multiple-buserr");
87 printk("\n");
90 static inline void breakout_cerri(unsigned int val)
92 if (val & CP0_CERRI_TAG_PARITY)
93 printk(" tag-parity");
94 if (val & CP0_CERRI_DATA_PARITY)
95 printk(" data-parity");
96 if (val & CP0_CERRI_EXTERNAL)
97 printk(" external");
98 printk("\n");
101 static inline void breakout_cerrd(unsigned int val)
103 switch (val & CP0_CERRD_CAUSES) {
104 case CP0_CERRD_LOAD:
105 printk(" load,");
106 break;
107 case CP0_CERRD_STORE:
108 printk(" store,");
109 break;
110 case CP0_CERRD_FILLWB:
111 printk(" fill/wb,");
112 break;
113 case CP0_CERRD_COHERENCY:
114 printk(" coherency,");
115 break;
116 case CP0_CERRD_DUPTAG:
117 printk(" duptags,");
118 break;
119 default:
120 printk(" NO CAUSE,");
121 break;
123 if (!(val & CP0_CERRD_TYPES))
124 printk(" NO TYPE");
125 else {
126 if (val & CP0_CERRD_MULTIPLE)
127 printk(" multi-err");
128 if (val & CP0_CERRD_TAG_STATE)
129 printk(" tag-state");
130 if (val & CP0_CERRD_TAG_ADDRESS)
131 printk(" tag-address");
132 if (val & CP0_CERRD_DATA_SBE)
133 printk(" data-SBE");
134 if (val & CP0_CERRD_DATA_DBE)
135 printk(" data-DBE");
136 if (val & CP0_CERRD_EXTERNAL)
137 printk(" external");
139 printk("\n");
142 #ifndef CONFIG_SIBYTE_BUS_WATCHER
144 static void check_bus_watcher(void)
146 uint32_t status, l2_err, memio_err;
147 #ifdef DUMP_L2_ECC_TAG_ON_ERROR
148 uint64_t l2_tag;
149 #endif
151 /* Destructive read, clears register and interrupt */
152 status = csr_in32(IOADDR(A_SCD_BUS_ERR_STATUS));
153 /* Bit 31 is always on, but there's no #define for that */
154 if (status & ~(1UL << 31)) {
155 l2_err = csr_in32(IOADDR(A_BUS_L2_ERRORS));
156 #ifdef DUMP_L2_ECC_TAG_ON_ERROR
157 l2_tag = in64(IO_SPACE_BASE | A_L2_ECC_TAG);
158 #endif
159 memio_err = csr_in32(IOADDR(A_BUS_MEM_IO_ERRORS));
160 printk("Bus watcher error counters: %08x %08x\n", l2_err, memio_err);
161 printk("\nLast recorded signature:\n");
162 printk("Request %02x from %d, answered by %d with Dcode %d\n",
163 (unsigned int)(G_SCD_BERR_TID(status) & 0x3f),
164 (int)(G_SCD_BERR_TID(status) >> 6),
165 (int)G_SCD_BERR_RID(status),
166 (int)G_SCD_BERR_DCODE(status));
167 #ifdef DUMP_L2_ECC_TAG_ON_ERROR
168 printk("Last L2 tag w/ bad ECC: %016llx\n", l2_tag);
169 #endif
170 } else {
171 printk("Bus watcher indicates no error\n");
174 #else
175 extern void check_bus_watcher(void);
176 #endif
178 asmlinkage void sb1_cache_error(void)
180 uint32_t errctl, cerr_i, cerr_d, dpalo, dpahi, eepc, res;
181 unsigned long long cerr_dpa;
183 #ifdef CONFIG_SIBYTE_BW_TRACE
184 /* Freeze the trace buffer now */
185 #if defined(CONFIG_SIBYTE_BCM1x55) || defined(CONFIG_SIBYTE_BCM1x80)
186 csr_out32(M_BCM1480_SCD_TRACE_CFG_FREEZE, IO_SPACE_BASE | A_SCD_TRACE_CFG);
187 #else
188 csr_out32(M_SCD_TRACE_CFG_FREEZE, IO_SPACE_BASE | A_SCD_TRACE_CFG);
189 #endif
190 printk("Trace buffer frozen\n");
191 #endif
193 printk("Cache error exception on CPU %x:\n",
194 (read_c0_prid() >> 25) & 0x7);
196 __asm__ __volatile__ (
197 " .set push\n\t"
198 " .set mips64\n\t"
199 " .set noat\n\t"
200 " mfc0 %0, $26\n\t"
201 " mfc0 %1, $27\n\t"
202 " mfc0 %2, $27, 1\n\t"
203 " dmfc0 $1, $27, 3\n\t"
204 " dsrl32 %3, $1, 0 \n\t"
205 " sll %4, $1, 0 \n\t"
206 " mfc0 %5, $30\n\t"
207 " .set pop"
208 : "=r" (errctl), "=r" (cerr_i), "=r" (cerr_d),
209 "=r" (dpahi), "=r" (dpalo), "=r" (eepc));
211 cerr_dpa = (((uint64_t)dpahi) << 32) | dpalo;
212 printk(" c0_errorepc == %08x\n", eepc);
213 printk(" c0_errctl == %08x", errctl);
214 breakout_errctl(errctl);
215 if (errctl & CP0_ERRCTL_ICACHE) {
216 printk(" c0_cerr_i == %08x", cerr_i);
217 breakout_cerri(cerr_i);
218 if (CP0_CERRI_IDX_VALID(cerr_i)) {
219 /* Check index of EPC, allowing for delay slot */
220 if (((eepc & SB1_CACHE_INDEX_MASK) != (cerr_i & SB1_CACHE_INDEX_MASK)) &&
221 ((eepc & SB1_CACHE_INDEX_MASK) != ((cerr_i & SB1_CACHE_INDEX_MASK) - 4)))
222 printk(" cerr_i idx doesn't match eepc\n");
223 else {
224 res = extract_ic(cerr_i & SB1_CACHE_INDEX_MASK,
225 (cerr_i & CP0_CERRI_DATA) != 0);
226 if (!(res & cerr_i))
227 printk("...didn't see indicated icache problem\n");
231 if (errctl & CP0_ERRCTL_DCACHE) {
232 printk(" c0_cerr_d == %08x", cerr_d);
233 breakout_cerrd(cerr_d);
234 if (CP0_CERRD_DPA_VALID(cerr_d)) {
235 printk(" c0_cerr_dpa == %010llx\n", cerr_dpa);
236 if (!CP0_CERRD_IDX_VALID(cerr_d)) {
237 res = extract_dc(cerr_dpa & SB1_CACHE_INDEX_MASK,
238 (cerr_d & CP0_CERRD_DATA) != 0);
239 if (!(res & cerr_d))
240 printk("...didn't see indicated dcache problem\n");
241 } else {
242 if ((cerr_dpa & SB1_CACHE_INDEX_MASK) != (cerr_d & SB1_CACHE_INDEX_MASK))
243 printk(" cerr_d idx doesn't match cerr_dpa\n");
244 else {
245 res = extract_dc(cerr_d & SB1_CACHE_INDEX_MASK,
246 (cerr_d & CP0_CERRD_DATA) != 0);
247 if (!(res & cerr_d))
248 printk("...didn't see indicated problem\n");
254 check_bus_watcher();
257 * Calling panic() when a fatal cache error occurs scrambles the
258 * state of the system (and the cache), making it difficult to
259 * investigate after the fact. However, if you just stall the CPU,
260 * the other CPU may keep on running, which is typically very
261 * undesirable.
263 #ifdef CONFIG_SB1_CERR_STALL
264 while (1)
266 #else
267 panic("unhandled cache error");
268 #endif
272 /* Parity lookup table. */
273 static const uint8_t parity[256] = {
274 0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,1,0,0,1,0,1,1,0,0,1,1,0,1,0,0,1,
275 1,0,0,1,0,1,1,0,0,1,1,0,1,0,0,1,0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,
276 1,0,0,1,0,1,1,0,0,1,1,0,1,0,0,1,0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,
277 0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,1,0,0,1,0,1,1,0,0,1,1,0,1,0,0,1,
278 1,0,0,1,0,1,1,0,0,1,1,0,1,0,0,1,0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,
279 0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,1,0,0,1,0,1,1,0,0,1,1,0,1,0,0,1,
280 0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0,1,0,0,1,0,1,1,0,0,1,1,0,1,0,0,1,
281 1,0,0,1,0,1,1,0,0,1,1,0,1,0,0,1,0,1,1,0,1,0,0,1,1,0,0,1,0,1,1,0
284 /* Masks to select bits for Hamming parity, mask_72_64[i] for bit[i] */
285 static const uint64_t mask_72_64[8] = {
286 0x0738C808099264FFULL,
287 0x38C808099264FF07ULL,
288 0xC808099264FF0738ULL,
289 0x08099264FF0738C8ULL,
290 0x099264FF0738C808ULL,
291 0x9264FF0738C80809ULL,
292 0x64FF0738C8080992ULL,
293 0xFF0738C808099264ULL
296 /* Calculate the parity on a range of bits */
297 static char range_parity(uint64_t dword, int max, int min)
299 char parity = 0;
300 int i;
301 dword >>= min;
302 for (i=max-min; i>=0; i--) {
303 if (dword & 0x1)
304 parity = !parity;
305 dword >>= 1;
307 return parity;
310 /* Calculate the 4-bit even byte-parity for an instruction */
311 static unsigned char inst_parity(uint32_t word)
313 int i, j;
314 char parity = 0;
315 for (j=0; j<4; j++) {
316 char byte_parity = 0;
317 for (i=0; i<8; i++) {
318 if (word & 0x80000000)
319 byte_parity = !byte_parity;
320 word <<= 1;
322 parity <<= 1;
323 parity |= byte_parity;
325 return parity;
328 static uint32_t extract_ic(unsigned short addr, int data)
330 unsigned short way;
331 int valid;
332 uint32_t taghi, taglolo, taglohi;
333 unsigned long long taglo, va;
334 uint64_t tlo_tmp;
335 uint8_t lru;
336 int res = 0;
338 printk("Icache index 0x%04x ", addr);
339 for (way = 0; way < 4; way++) {
340 /* Index-load-tag-I */
341 __asm__ __volatile__ (
342 " .set push \n\t"
343 " .set noreorder \n\t"
344 " .set mips64 \n\t"
345 " .set noat \n\t"
346 " cache 4, 0(%3) \n\t"
347 " mfc0 %0, $29 \n\t"
348 " dmfc0 $1, $28 \n\t"
349 " dsrl32 %1, $1, 0 \n\t"
350 " sll %2, $1, 0 \n\t"
351 " .set pop"
352 : "=r" (taghi), "=r" (taglohi), "=r" (taglolo)
353 : "r" ((way << 13) | addr));
355 taglo = ((unsigned long long)taglohi << 32) | taglolo;
356 if (way == 0) {
357 lru = (taghi >> 14) & 0xff;
358 printk("[Bank %d Set 0x%02x] LRU > %d %d %d %d > MRU\n",
359 ((addr >> 5) & 0x3), /* bank */
360 ((addr >> 7) & 0x3f), /* index */
361 (lru & 0x3),
362 ((lru >> 2) & 0x3),
363 ((lru >> 4) & 0x3),
364 ((lru >> 6) & 0x3));
366 va = (taglo & 0xC0000FFFFFFFE000ULL) | addr;
367 if ((taglo & (1 << 31)) && (((taglo >> 62) & 0x3) == 3))
368 va |= 0x3FFFF00000000000ULL;
369 valid = ((taghi >> 29) & 1);
370 if (valid) {
371 tlo_tmp = taglo & 0xfff3ff;
372 if (((taglo >> 10) & 1) ^ range_parity(tlo_tmp, 23, 0)) {
373 printk(" ** bad parity in VTag0/G/ASID\n");
374 res |= CP0_CERRI_TAG_PARITY;
376 if (((taglo >> 11) & 1) ^ range_parity(taglo, 63, 24)) {
377 printk(" ** bad parity in R/VTag1\n");
378 res |= CP0_CERRI_TAG_PARITY;
381 if (valid ^ ((taghi >> 27) & 1)) {
382 printk(" ** bad parity for valid bit\n");
383 res |= CP0_CERRI_TAG_PARITY;
385 printk(" %d [VA %016llx] [Vld? %d] raw tags: %08X-%016llX\n",
386 way, va, valid, taghi, taglo);
388 if (data) {
389 uint32_t datahi, insta, instb;
390 uint8_t predecode;
391 int offset;
393 /* (hit all banks and ways) */
394 for (offset = 0; offset < 4; offset++) {
395 /* Index-load-data-I */
396 __asm__ __volatile__ (
397 " .set push\n\t"
398 " .set noreorder\n\t"
399 " .set mips64\n\t"
400 " .set noat\n\t"
401 " cache 6, 0(%3) \n\t"
402 " mfc0 %0, $29, 1\n\t"
403 " dmfc0 $1, $28, 1\n\t"
404 " dsrl32 %1, $1, 0 \n\t"
405 " sll %2, $1, 0 \n\t"
406 " .set pop \n"
407 : "=r" (datahi), "=r" (insta), "=r" (instb)
408 : "r" ((way << 13) | addr | (offset << 3)));
409 predecode = (datahi >> 8) & 0xff;
410 if (((datahi >> 16) & 1) != (uint32_t)range_parity(predecode, 7, 0)) {
411 printk(" ** bad parity in predecode\n");
412 res |= CP0_CERRI_DATA_PARITY;
414 /* XXXKW should/could check predecode bits themselves */
415 if (((datahi >> 4) & 0xf) ^ inst_parity(insta)) {
416 printk(" ** bad parity in instruction a\n");
417 res |= CP0_CERRI_DATA_PARITY;
419 if ((datahi & 0xf) ^ inst_parity(instb)) {
420 printk(" ** bad parity in instruction b\n");
421 res |= CP0_CERRI_DATA_PARITY;
423 printk(" %05X-%08X%08X", datahi, insta, instb);
425 printk("\n");
428 return res;
431 /* Compute the ECC for a data doubleword */
432 static uint8_t dc_ecc(uint64_t dword)
434 uint64_t t;
435 uint32_t w;
436 uint8_t p;
437 int i;
439 p = 0;
440 for (i = 7; i >= 0; i--)
442 p <<= 1;
443 t = dword & mask_72_64[i];
444 w = (uint32_t)(t >> 32);
445 p ^= (parity[w>>24] ^ parity[(w>>16) & 0xFF]
446 ^ parity[(w>>8) & 0xFF] ^ parity[w & 0xFF]);
447 w = (uint32_t)(t & 0xFFFFFFFF);
448 p ^= (parity[w>>24] ^ parity[(w>>16) & 0xFF]
449 ^ parity[(w>>8) & 0xFF] ^ parity[w & 0xFF]);
451 return p;
454 struct dc_state {
455 unsigned char val;
456 char *name;
459 static struct dc_state dc_states[] = {
460 { 0x00, "INVALID" },
461 { 0x0f, "COH-SHD" },
462 { 0x13, "NCO-E-C" },
463 { 0x19, "NCO-E-D" },
464 { 0x16, "COH-E-C" },
465 { 0x1c, "COH-E-D" },
466 { 0xff, "*ERROR*" }
469 #define DC_TAG_VALID(state) \
470 (((state) == 0x0) || ((state) == 0xf) || ((state) == 0x13) || \
471 ((state) == 0x19) || ((state) == 0x16) || ((state) == 0x1c))
473 static char *dc_state_str(unsigned char state)
475 struct dc_state *dsc = dc_states;
476 while (dsc->val != 0xff) {
477 if (dsc->val == state)
478 break;
479 dsc++;
481 return dsc->name;
484 static uint32_t extract_dc(unsigned short addr, int data)
486 int valid, way;
487 unsigned char state;
488 uint32_t taghi, taglolo, taglohi;
489 unsigned long long taglo, pa;
490 uint8_t ecc, lru;
491 int res = 0;
493 printk("Dcache index 0x%04x ", addr);
494 for (way = 0; way < 4; way++) {
495 __asm__ __volatile__ (
496 " .set push\n\t"
497 " .set noreorder\n\t"
498 " .set mips64\n\t"
499 " .set noat\n\t"
500 " cache 5, 0(%3)\n\t" /* Index-load-tag-D */
501 " mfc0 %0, $29, 2\n\t"
502 " dmfc0 $1, $28, 2\n\t"
503 " dsrl32 %1, $1, 0\n\t"
504 " sll %2, $1, 0\n\t"
505 " .set pop"
506 : "=r" (taghi), "=r" (taglohi), "=r" (taglolo)
507 : "r" ((way << 13) | addr));
509 taglo = ((unsigned long long)taglohi << 32) | taglolo;
510 pa = (taglo & 0xFFFFFFE000ULL) | addr;
511 if (way == 0) {
512 lru = (taghi >> 14) & 0xff;
513 printk("[Bank %d Set 0x%02x] LRU > %d %d %d %d > MRU\n",
514 ((addr >> 11) & 0x2) | ((addr >> 5) & 1), /* bank */
515 ((addr >> 6) & 0x3f), /* index */
516 (lru & 0x3),
517 ((lru >> 2) & 0x3),
518 ((lru >> 4) & 0x3),
519 ((lru >> 6) & 0x3));
521 state = (taghi >> 25) & 0x1f;
522 valid = DC_TAG_VALID(state);
523 printk(" %d [PA %010llx] [state %s (%02x)] raw tags: %08X-%016llX\n",
524 way, pa, dc_state_str(state), state, taghi, taglo);
525 if (valid) {
526 if (((taglo >> 11) & 1) ^ range_parity(taglo, 39, 26)) {
527 printk(" ** bad parity in PTag1\n");
528 res |= CP0_CERRD_TAG_ADDRESS;
530 if (((taglo >> 10) & 1) ^ range_parity(taglo, 25, 13)) {
531 printk(" ** bad parity in PTag0\n");
532 res |= CP0_CERRD_TAG_ADDRESS;
534 } else {
535 res |= CP0_CERRD_TAG_STATE;
538 if (data) {
539 uint32_t datalohi, datalolo, datahi;
540 unsigned long long datalo;
541 int offset;
542 char bad_ecc = 0;
544 for (offset = 0; offset < 4; offset++) {
545 /* Index-load-data-D */
546 __asm__ __volatile__ (
547 " .set push\n\t"
548 " .set noreorder\n\t"
549 " .set mips64\n\t"
550 " .set noat\n\t"
551 " cache 7, 0(%3)\n\t" /* Index-load-data-D */
552 " mfc0 %0, $29, 3\n\t"
553 " dmfc0 $1, $28, 3\n\t"
554 " dsrl32 %1, $1, 0 \n\t"
555 " sll %2, $1, 0 \n\t"
556 " .set pop"
557 : "=r" (datahi), "=r" (datalohi), "=r" (datalolo)
558 : "r" ((way << 13) | addr | (offset << 3)));
559 datalo = ((unsigned long long)datalohi << 32) | datalolo;
560 ecc = dc_ecc(datalo);
561 if (ecc != datahi) {
562 int bits = 0;
563 bad_ecc |= 1 << (3-offset);
564 ecc ^= datahi;
565 while (ecc) {
566 if (ecc & 1) bits++;
567 ecc >>= 1;
569 res |= (bits == 1) ? CP0_CERRD_DATA_SBE : CP0_CERRD_DATA_DBE;
571 printk(" %02X-%016llX", datahi, datalo);
573 printk("\n");
574 if (bad_ecc)
575 printk(" dwords w/ bad ECC: %d %d %d %d\n",
576 !!(bad_ecc & 8), !!(bad_ecc & 4),
577 !!(bad_ecc & 2), !!(bad_ecc & 1));
580 return res;