| blob | 1ec68083a9290b8844cf24986aa11c7a7368fb8a |
1 #!/usr/bin/perl -w
2 # (c) 2001, Dave Jones. (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
6 # Licensed under the terms of the GNU GPL License version 2
54 Options:
59 --emacs emacs compile window format
60 --terse one line per report
73 is all off)
75 literally
78 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
79 with potential errors corrected to the preferred
80 checkpatch style
85 runtime errors.
89 EOM
92 }
114 }
115 }
118 }
120 GetOptions(
158 }
159 }
164 }
180 }
181 }
190 }
192 }
193 }
203 ## no critic
206 }
213 }
219 }
226 }
227 }
232 }
233 }
243 __user|
244 __kernel|
245 __force|
246 __iomem|
247 __must_check|
248 __init_refok|
249 __kprobes|
250 __ref|
251 __rcu
259 # Notes to $Attribute:
260 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
262 const|
263 __percpu|
264 __nocast|
265 __safe|
266 __bitwise__|
267 __packed__|
268 __packed2__|
269 __naked|
270 __maybe_unused|
271 __always_unused|
272 __noreturn|
273 __used|
274 __cold|
275 __noclone|
276 __deprecated|
277 __read_mostly|
278 __kprobes|
280 ____cacheline_aligned|
281 ____cacheline_aligned_in_smp|
282 ____cacheline_internodealigned_in_smp|
283 __weak
304 <=|>=|==|!=|
305 =>|->|<<|>>|<|>|!|~|
333 atomic_t
334 )};
338 (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
340 panic|
343 )};
352 To:|
353 Cc:
354 )};
375 );
380 );
384 );
390 ["debugfs_create_(?:file|u8|u16|u32|u64|x8|x16|x32|x64|size_t|atomic_t|bool|blob|regset32|u32_array)", 2],
393 );
395 #Create a search pattern for all these functions to speed up a loop below
400 }
405 )};
408 irq|
409 memory
410 )};
411 # memory.h: ARM has a custom one
424 )
433 )
437 $NonptrType
442 }
443 build_types();
447 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
448 # requires at least perl version v5.10.0
449 # Any use must be runtime checked with $^V
462 }
467 }
491 }
492 }
493 }
517 }
519 }
527 }
531 }
536 }
540 }
548 }
550 }
551 }
569 }
574 }
578 }
582 }
586 }
597 );
602 }
603 }
605 }
628 # If there's a name left after stripping spaces and
629 # leading quotes, and the address doesn't have both
630 # leading and trailing angle brackets, the address
631 # is invalid. ie:
632 # "joe smith joe@smith.com" bad
633 # "joe smith <joe@smith.com" bad
638 }
639 }
649 }
652 }
666 }
672 }
675 }
683 }
684 }
687 }
700 }
702 }
705 }
708 }
712 }
717 # Drop the diff line leader and expand tabs
721 # Pick the indent from the front of the line.
725 }
736 }
737 }
748 # Always copy over the diff marker.
754 # Comments we are wacking completly including the begin
755 # and end, all to $;.
762 }
768 }
775 }
777 # A \ in a string means ignore the next character.
783 }
784 # Regular quotes.
793 }
794 }
796 #print "c<$c> SQ<$sanitise_quote>\n";
805 }
806 }
810 }
812 # The pathname on a #include may be surrounded by '<' and '>'.
817 # The whole of a #error is a string.
821 }
824 }
831 }
854 #warn "CSB: blk<$blk> remain<$remain>\n";
855 # If we are about to drop off the end, pull in more
856 # context.
867 }
868 # Bail if there is no further context.
869 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
872 }
876 }
877 }
882 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
884 # Handle nested #if/#else.
891 }
893 # Statement ends at the ';' or a close '}' at the
894 # outermost level.
897 }
899 # An else is really a conditional as long as its not else if
906 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
907 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
908 }
913 }
921 #warn "CSB: mark coff<$coff>\n";
922 }
923 }
927 }
935 }
937 }
938 }
939 # Preprocessor commands end at the newline unless escaped.
945 }
947 }
948 # We are truly at the end, so shuffle to the next line.
953 }
958 #warn "STATEMENT<$statement>\n";
959 #warn "CONDITION<$condition>\n";
961 #print "coff<$coff> soff<$off> loff<$loff>\n";
965 }
970 # Strip the diff line prefixes and rip blank lines at start and end.
978 }
986 }
1007 }
1008 }
1016 # Grab the first conditional/block pair.
1019 #print "F: c<$condition> s<$statement> remain<$remain>\n";
1023 }
1025 # Pull in the following conditional/block pairs and see if they
1026 # could continue the statement.
1030 #print "C: c<$condition> s<$statement> remain<$remain>\n";
1032 #print "C: push\n";
1034 }
1037 }
1056 # Handle nested #if/#else.
1063 }
1066 ##print "C<$c>L<$level><$open$close>O<$off>\n";
1070 }
1077 }
1078 }
1082 }
1085 }
1088 }
1094 }
1100 }
1106 }
1111 }
1116 }
1121 # Catch a comment on the end of the line itself.
1125 # Look through the context and try and figure out if there is a
1126 # comment.
1131 #warn " $line\n";
1134 }
1137 }
1140 }
1144 }
1145 }
1149 }
1154 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1155 ##print "CMMT: $cmt\n";
1158 }
1171 }
1174 }
1186 }
1187 }
1191 }
1203 }
1223 }
1244 }
1273 # Assume all arms of the conditional end as this
1274 # one does, and continue as if the #endif was not here.
1291 }
1322 }
1334 }
1367 }
1382 }
1391 }
1395 }
1399 }
1400 }
1403 }
1412 DEFINE_\S+
1413 )$|
1417 case|
1421 \#|
1422 \#\#|
1428 # Check for modifiers.
1439 }
1440 }
1445 }
1446 build_types();
1449 }
1450 }
1460 }
1468 }
1474 }
1480 }
1484 }
1493 }
1495 }
1503 }
1505 }
1513 }
1515 }
1521 ##print "absolute<$absolute>\n";
1523 # See if any suffix of this path is a path within the tree.
1526 ##print "file<$file>\n";
1528 }
1529 }
1532 }
1534 # It is, so see if the prefix is acceptable.
1538 ##print "prefix<$prefix>\n";
1542 }
1543 }
1551 }
1559 }
1567 }
1575 }
1584 #convert leading spaces to tabs
1586 #Remove spaces before a tab
1590 }
1604 }
1616 }
1617 }
1620 }
1651 # Trace the real file/line as we go.
1663 # suppression flags
1671 # Pre-scan the patch sanitizing the lines.
1672 # Pre-scan the patch looking for any __setup documentation.
1673 #
1679 sanitise_line_reset();
1691 }
1692 #next;
1693 }
1700 }
1703 # Guestimate if this is a continuing comment. Run
1704 # the context looking for a comment "edge". If this
1705 # edge is a close comment then we must be in a comment
1706 # at context start.
1713 #print "RAW<$rawlines[$ln - 1]>\n";
1719 }
1720 }
1723 }
1725 # Guestimate if this is a continuing comment. If this
1726 # is the start of a diff block and this line starts
1727 # ' *' then it is very likely a comment.
1730 {
1732 }
1734 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1738 # Standardise the strings and chars within the input to
1739 # simplify matching -- only bother with positive lines.
1741 }
1748 }
1750 #print "==>$rawline\n";
1751 #print "-->$line\n";
1755 }
1756 }
1769 #extract the line range in the file after the patch is applied
1778 }
1779 annotate_reset();
1788 # track the line number as we move through the hunk, note that
1789 # new versions of GNU diff omit the leading space on completely
1790 # blank context lines so we need to count that too.
1795 # Measure the line length and indent.
1798 # Track the previous line.
1803 #warn "line<$line>\n";
1807 }
1811 #make up the handle for any error we report on this line
1819 # extract the filename as it passes
1835 }
1839 "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1840 }
1842 }
1849 }
1851 }
1861 # Check for incorrect file permissions
1868 }
1869 }
1871 # Check the patch for a signoff:
1875 }
1877 # Check signature styles
1889 }
1896 }
1897 }
1904 }
1906 }
1913 }
1914 }
1925 # Don't force email to have quotes
1926 # Allow just an angle bracketed address
1932 }
1933 }
1935 # Check for duplicate signatures
1944 }
1945 }
1947 # Check for old stable address
1951 }
1953 # Check for unwanted Gerrit info
1957 }
1959 # Check for wrappage within a valid hunk of the file
1964 }
1966 # Check for absolute kernel paths.
1973 #
1976 }
1977 }
1978 }
1980 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1991 }
1993 # Check if it's the start of a commit log
1994 # (not a header line and we haven't seen the patch filename)
2000 }
2002 # Check if there is UTF-8 in a commit log when a mail header has explicitly
2003 # declined it, i.e defined some charset where it is missing.
2008 }
2014 }
2016 # ignore non-hunk lines and lines being removed
2019 #trailing whitespace
2026 }
2033 }
2036 }
2038 # Check for FSF mailing addresses.
2046 "Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.\n" . $herevet)
2047 }
2049 # check for Kconfig help text having a real description
2050 # Only applies when adding the entry originally, after that we do not have
2051 # sufficient context to determine whether it is indeed long enough.
2071 }
2080 }
2082 }
2084 "please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);
2085 #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
2086 }
2088 # discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
2092 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2093 }
2103 };
2106 "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
2107 }
2109 # check for DT compatible documentation
2128 }
2135 "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
2136 }
2137 }
2138 }
2140 # check we are in a valid source file if not then ignore this hunk
2143 #line length limit
2146 !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
2149 {
2152 }
2154 # Check for user-visible strings broken across lines, which breaks the ability
2155 # to grep for the string. Make exceptions when the previous string ends in a
2156 # newline (multiple lines in one string constant) or '\t', '\r', ';', or '{'
2157 # (common in inline assembly) or is a octal \123 or hexadecimal \xaf value
2163 }
2165 # check for spaces before a quoted newline
2171 }
2173 }
2175 # check for adding lines without a newline.
2176 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
2179 }
2181 # Blackfin: use hi/lo macros
2187 }
2192 }
2193 }
2195 # check we are in a valid source file C or perl if not then ignore this hunk
2198 # at the beginning of a line any tabs must come first and anything
2199 # more than 8 must use tabs.
2208 }
2209 }
2211 # check for space before tabs.
2221 }
2222 }
2224 # check for && or || at the start of a line
2228 }
2230 # check multi-line statement indentation matches previous line
2232 $prevline =~ /^\+([ \t]*)((?:$c90_Keywords(?:\s+if)\s*)|(?:$Declare\s*)?(?:$Ident|\(\s*\*\s*$Ident\s*\))\s*|$Ident\s*=\s*$Ident\s*)\(.*(\&\&|\|\||,)\s*$/) {
2255 }
2256 }
2257 }
2258 }
2266 }
2267 }
2275 }
2284 }
2293 }
2295 # check for missing blank lines after declarations
2297 # actual declarations
2299 # function pointer declarations
2301 # foo bar; where foo is some local typedef or #define
2303 # known declaration macros
2305 # for "else if" which can look like "$Ident $Ident"
2307 # other possible extensions of declaration lines
2309 # not starting a section or a macro "\" extended line
2311 # looks like a declaration
2313 # function pointer declarations
2315 # foo bar; where foo is some local typedef or #define
2317 # known declaration macros
2319 # start of struct or union or enum
2321 # start or end of block or continuation of declaration
2323 # bitfield continuation
2325 # other possible extensions of declaration lines
2327 # indentation of previous and current line are the same
2331 }
2333 # check for spaces at the beginning of a line.
2334 # Exceptions:
2335 # 1) within comments
2336 # 2) indented preprocessor commands
2337 # 3) hanging labels
2344 }
2345 }
2347 # check we are in a valid C source file if not then ignore this hunk
2350 # check indentation of any line with a bare else
2351 # if the previous line is a break or return and is indented 1 tab more...
2357 }
2358 }
2360 # discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
2363 "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2364 }
2366 # check for RCS/CVS revision markers
2370 }
2372 # Blackfin: don't use __builtin_bfin_[cs]sync
2377 }
2382 }
2384 # check for old HOTPLUG __dev<foo> section markings
2388 }
2390 # Check for potential 'bare' types
2393 #print "LINE<$line>\n";
2401 #print "linenr<$linenr> <$stat>\n";
2402 # If this statement has no statement boundaries within
2403 # it there is no point in retrying a statement scan
2404 # until we hit end of it.
2407 #print "skip<$line_nr_next>\n";
2409 }
2411 # Find the real next line.
2417 }
2422 # Ignore goto labels.
2425 # Ignore functions being called
2430 # declarations always start with types
2431 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
2436 # definitions in global scope can only start with types
2439 }
2441 # any (foo ... *) is a pointer cast, and foo is a type
2444 }
2446 # Check for any sort of function declaration.
2447 # int foo(something bar, other baz);
2448 # void (*store_gdt)(x86_descr_ptr *);
2449 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
2457 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
2460 }
2461 }
2462 }
2464 }
2466 #
2467 # Checks which may be anchored in the context.
2468 #
2470 # Check for switch () and associated case and default
2471 # statements should be at the same indent.
2485 }
2486 }
2490 }
2491 }
2493 # if/while/etc brace do not go on next line, unless defining a do while loop,
2494 # or if that brace on the next line is for something else
2503 }
2514 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2517 }
2519 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2520 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2526 }
2530 {
2536 }
2537 }
2538 }
2540 # Check relative indent for conditionals and blocks.
2541 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2549 # Make sure we remove the line prefixes as we have
2550 # none on the first line, and are going to readd them
2551 # where necessary.
2554 # Find out how long the conditional actually is.
2558 # We want to check the first line inside the block
2559 # starting at the end of the conditional, so remove:
2560 # 1) any blank line termination
2561 # 2) any opening brace { on end of the line
2562 # 3) any do (...) {
2569 }
2573 }
2575 # Also ignore a loop construct at the end of a
2576 # preprocessor statement.
2580 }
2587 # If we see an #else/#elif then the code
2588 # is not linear.
2591 }
2593 # Ignore:
2594 # 1) blank lines, they should be at 0,
2595 # 2) preprocessor lines, and
2596 # 3) labels.
2604 }
2605 }
2606 }
2611 # Check if either of these lines are modified, else
2612 # this is not this patch's fault.
2616 }
2619 }
2621 #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2626 "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2627 }
2628 }
2630 # Track the 'values' across context and added lines.
2640 }
2643 #ignore lines not being added
2646 # TEST: allow direct testing of the type matcher.
2654 }
2656 }
2657 # TEST: allow direct testing of the attribute matcher.
2665 }
2667 }
2669 # check for initialisation to aggregates open brace on the next line
2674 }
2676 #
2677 # Checks which are anchored on the added line.
2678 #
2680 # check for malformed paths in #include statements (uses RAW line)
2686 }
2690 }
2691 }
2693 # no C99 // comments
2702 }
2703 }
2704 }
2705 # Remove C99 comments.
2709 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
2710 # the whole statement.
2711 #print "APW <$lines[$realline_next - 1]>\n";
2717 # Handle definitions which produce identifiers with
2718 # a prefix:
2719 # XXX(foo);
2720 # EXPORT_SYMBOL(something_foo);
2724 #print "FOO C name<$name>\n";
2735 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
2739 }
2740 }
2745 #print "FOO B <$lines[$linenr - 1]>\n";
2747 }
2752 }
2754 # check for global initialisers.
2761 }
2762 }
2763 # check for static initialisers.
2770 }
2771 }
2773 # check for static const char * arrays.
2778 }
2780 # check for static char foo[] = "bar" declarations.
2785 }
2787 # check for non-global char *foo[] = {"bar", ...} declarations.
2792 }
2794 # check for function declarations without arguments like "int foo()"
2800 }
2801 }
2803 # check for uses of DEFINE_PCI_DEVICE_TABLE
2808 $fixed[$linenr - 1] =~ s/\b(?:static\s+|)DEFINE_PCI_DEVICE_TABLE\s*\(\s*(\w+)\s*\)\s*=\s*/static const struct pci_device_id $1\[\] = /;
2809 }
2810 }
2812 # check for new typedefs, only function parameters and sparse annotations
2813 # make sense.
2821 }
2823 # * goes on variable not on type
2824 # (char*[ const])
2826 #print "AA<$1>\n";
2829 # Should start with a space.
2831 # Should not end with a space.
2833 # '*'s should not have spaces between.
2835 }
2837 ## print "1: from<$from> to<$to> ident<$ident>\n";
2847 }
2848 }
2849 }
2851 #print "BB<$1>\n";
2854 # Should start with a space.
2856 # Should not end with a space.
2858 # '*'s should not have spaces between.
2860 }
2861 # Modifiers should have spaces.
2864 ## print "2: from<$from> to<$to> ident<$ident>\n";
2875 }
2876 }
2877 }
2879 # # no BUG() or BUG_ON()
2880 # if ($line =~ /\b(BUG|BUG_ON)\b/) {
2881 # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
2882 # print "$herecurr";
2883 # $clean = 0;
2884 # }
2888 "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
2889 }
2891 # check for uses of printk_ratelimit
2895 }
2897 # printk should use KERN_* levels. Note that follow on printk's on the
2898 # same line do not need a level, so we use the current block context
2899 # to try and find and validate the current printk. In summary the current
2900 # printk includes all preceding printk's which have no newline on the end.
2901 # we assume the first bad printk is the one to report.
2905 #print "CHECK<$lines[$ln - 1]\n";
2906 # we have a preceding printk if it ends
2907 # with "\n" ignore it, else it is to blame
2911 }
2913 }
2914 }
2918 }
2919 }
2928 "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . $herecurr);
2929 }
2937 }
2938 }
2947 }
2949 # function brace can't be on same line, except for #defines of do while,
2950 # or if closed on same line
2955 }
2957 # open braces for enum, union and struct go on the same line.
2962 }
2964 # missing space after union, struct or enum definition
2971 }
2972 }
2974 # Function pointer declarations
2975 # check spacing between type, funcptr, and args
2976 # canonical declaration is "type (*funcptr)(args...)"
2985 # the $Declare variable will capture all spaces after the type
2986 # so check it for a missing trailing missing space but pointer return types
2987 # don't need a space so don't warn for those.
2992 }
2997 }
2999 # unnecessary space "type (*funcptr)(args...)"
3000 # This test is not currently implemented because these declarations are
3001 # equivalent to
3002 # int foo(int bar, ...)
3003 # and this is form shouldn't/doesn't generate a checkpatch warning.
3004 #
3005 # elsif ($declare =~ /\s{2,}$/) {
3006 # WARN("SPACING",
3007 # "Multiple spaces after return type\n" . $herecurr);
3008 # }
3010 # unnecessary space "type ( *funcptr)(args...)"
3015 }
3017 # unnecessary space "type (* funcptr)(args...)"
3022 }
3024 # unnecessary space "type (*funcptr )(args...)"
3029 }
3031 # unnecessary space "type (*funcptr) (args...)"
3036 }
3040 s/^(.\s*)$Declare\s*\(\s*\*\s*$Ident\s*\)\s*\(/$1 . $declare . $post_declare_space . '(*' . $funcname . ')('/ex;
3041 }
3042 }
3044 # check for spacing round square brackets; allowed:
3045 # 1. with a type on the left -- int [] a;
3046 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
3047 # 3. inside a curly brace -- = { [0...10] = 5 }
3058 }
3059 }
3060 }
3062 # check for spaces between functions and their parentheses.
3068 # Ignore those directives where spaces _are_ permitted.
3074 {
3075 # cpp #define statements have non-optional spaces, ie
3076 # if there is a space between the name and the open
3077 # parenthesis it is simply not a parameter group.
3080 # cpp #elif statement condition may start with a (
3083 # If this whole things ends with a type its most
3084 # likely a typedef for a function.
3093 }
3094 }
3095 }
3097 # Check operator spacing.
3103 <<=|>>=|<=|>=|==|!=|
3105 =>|->|<<|>>|<|>|=|!|~|
3111 ## print("element count: <" . $#elements . ">\n");
3112 ## foreach my $el (@elements) {
3113 ## print("el: <$el>\n");
3114 ## }
3122 }
3133 ## print("n: <$n> good: <$good>\n");
3137 # Pick up the preceding and succeeding characters.
3142 }
3165 }
3174 # Pull out the value of this operator.
3177 # Get the full operator variant.
3180 # Ignore operators passed as parameters.
3184 # # Ignore comments
3185 # } elsif ($op =~ /^$;+$/) {
3187 # ; should have either the end of line or a space or \ after it
3195 }
3196 }
3198 # // is a comment
3201 # : when part of a bitfield
3203 # skip the bitfield test for now
3205 # No spaces for:
3206 # ->
3214 }
3216 }
3217 }
3219 # , must have a space on the right.
3227 }
3228 }
3230 # '*' as part of a type definition -- reported already.
3232 #warn "'*' is part of type\n";
3234 # unary operators should have a space before and
3235 # none after. May be left adjacent to another
3236 # unary operator, or a cast
3246 }
3247 }
3248 }
3250 # A unary '*' may be const
3258 }
3260 }
3261 }
3263 # unary ++ and unary -- are allowed no space on one side.
3270 }
3271 }
3278 }
3279 }
3286 }
3288 }
3289 }
3291 # << and >> may either have or not have spaces both sides
3297 {
3304 }
3306 }
3307 }
3309 # A colon needs no spaces before when it is
3310 # terminating a case value or a label.
3317 }
3318 }
3320 # All the others need spaces both sides.
3324 # Ignore email addresses <foo@bar>
3329 {
3331 }
3333 # messages are ERROR, but ?: are CHK
3343 }
3345 }
3346 }
3347 }
3350 ## print("n: <$n> GOOD: <$good>\n");
3353 }
3357 }
3361 }
3364 }
3366 # check for whitespace before a non-naked semicolon
3373 }
3374 }
3376 # check for multiple assignments
3380 }
3382 ## # check for multiple declarations, allowing for a function declaration
3383 ## # continuation.
3384 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
3385 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
3386 ##
3387 ## # Remove any bracketed sections to ensure we do not
3388 ## # falsly report the parameters of functions.
3389 ## my $ln = $line;
3390 ## while ($ln =~ s/\([^\(\)]*\)//g) {
3391 ## }
3392 ## if ($ln =~ /,/) {
3393 ## WARN("MULTIPLE_DECLARATION",
3394 ## "declaring multiple variables together should be avoided\n" . $herecurr);
3395 ## }
3396 ## }
3398 #need space before brace following if, while, etc
3405 }
3406 }
3408 ## # check for blank lines before declarations
3409 ## if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
3410 ## $prevrawline =~ /^.\s*$/) {
3411 ## WARN("SPACING",
3412 ## "No blank lines before declarations\n" . $hereprev);
3413 ## }
3414 ##
3416 # closing brace should have a space following it when it has anything
3417 # on the line
3424 }
3425 }
3427 # check spacing on square brackets
3434 }
3435 }
3442 }
3443 }
3445 # check spacing on parentheses
3453 }
3454 }
3463 }
3464 }
3466 #goto labels aren't indented, allow a single space however
3474 }
3475 }
3477 # return is not a function
3487 }
3491 }
3492 }
3494 # unnecessary return in a void function
3495 # at end-of-function, with the previous line a single leading tab, then return;
3496 # and the line before that not a goto label target like "out:"
3504 }
3506 # if statements using unnecessary parentheses - ie: if ((foo == bar))
3512 if ($line =~ /\bif\s*(?:\(\s*){$count,$count}$LvalOrFunc\s*($Compare)\s*$LvalOrFunc(?:\s*\)){$count,$count}/) {
3517 }
3518 }
3520 # Return of what appears to be an errno should normally be -'ve
3526 }
3527 }
3529 # Need a space before open parenthesis after if, while etc
3536 }
3537 }
3539 # Check for illegal assignment in if conditional -- and check for trailing
3540 # statements after the conditional.
3548 ##print "stat<$stat> stat_next<$stat_next>\n";
3551 # If the statement carries leading newlines,
3552 # then count those as offsets.
3560 }
3561 }
3570 }
3572 # Find out what is on the end of the line after the
3573 # conditional.
3579 {
3580 # Find out how long the conditional actually is.
3589 }
3593 }
3594 }
3596 # Check for bitwise tests written as boolean
3602 |
3607 {
3610 }
3612 # if and else should not have general statements after it
3619 }
3620 }
3621 # if should not continue a brace
3626 }
3627 # case and default should not have general statements after them
3633 {
3636 }
3638 # Check for }<nl>else {, these must be at the same
3639 # indent level to be relevant to each other.
3644 }
3650 # Find out what is on the end of the line after the
3651 # conditional.
3658 }
3659 }
3661 #Specific variable tests
3665 #gcc binary extension
3673 }
3674 }
3676 #CamelCase
3679 #Ignore Page<foo> variants
3681 #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
3687 seed_camelcase_includes();
3691 }
3692 }
3697 }
3698 }
3699 }
3700 }
3702 #no spaces allowed after \ in define
3708 }
3709 }
3711 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
3718 {
3725 }
3726 }
3727 }
3729 # multi-statement macros should be enclosed in a do while loop, grab the
3730 # first statement and ensure its the whole macro if its not enclosed
3731 # in a known good container
3741 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
3742 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
3750 # Flatten any parentheses and braces
3754 {
3755 }
3757 # Flatten any obvious string concatentation.
3760 {
3761 }
3765 module_param_named|
3766 MODULE_PARM_DESC|
3767 DECLARE_PER_CPU|
3768 DEFINE_PER_CPU|
3769 __typeof__\(|
3770 union|
3771 struct|
3775 #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
3779 $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
3784 $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ && # do {...} while (...); // do {...} while (...)
3790 {
3797 }
3805 }
3806 }
3808 # check for line continuations outside of #defines, preprocessor #, and asm
3817 }
3818 }
3820 # do {} while (0) macro tests:
3821 # single-statement macros do not need to be enclosed in do while (0) loop,
3822 # macro should not end with a semicolon
3836 if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
3846 }
3852 }
3856 }
3864 }
3868 }
3869 }
3871 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
3872 # all assignments may have only one of the following with an assignment:
3873 # .
3874 # ALIGN(...)
3875 # VMLINUX_SYMBOL(...)
3879 }
3881 # check for redundant bracing round if etc
3885 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
3886 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
3896 # If the condition carries leading newlines, then count those as offsets.
3901 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
3903 # We have looked at and allowed this specific line.
3913 #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
3915 #print "APW: ALLOWED: cond<$cond>\n";
3917 }
3919 #print "APW: ALLOWED: block<$block>\n";
3921 }
3923 #print "APW: ALLOWED: lines block<$block>\n";
3925 }
3927 }
3932 }
3940 }
3941 }
3942 }
3943 }
3948 # Check the pre-context.
3950 #print "APW: ALLOWED: pre<$1>\n";
3952 }
3957 # Check the condition.
3959 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
3962 }
3964 #print "APW: ALLOWED: cond<$cond>\n";
3966 }
3968 #print "APW: ALLOWED: block<$block>\n";
3970 }
3972 #print "APW: ALLOWED: lines block<$block>\n";
3974 }
3975 # Check the post-context.
3980 }
3982 #print "APW: ALLOWED: chunk-1 block<$block>\n";
3984 }
3985 }
3992 }
3996 }
3997 }
3999 # check for unnecessary blank lines around braces
4003 }
4007 }
4009 # no volatiles please
4013 "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
4014 }
4016 # warn about #if 0
4021 }
4023 # check for needless "if (<foo>) fn(<foo>)" uses
4029 }
4030 }
4032 # check for unnecessary "Out of Memory" messages
4041 # print("line: <$line>\nprevline: <$prevline>\ns: <$s>\nc: <$c>\n\n\n");
4043 if ($c =~ /(?:^|\n)[ \+]\s*(?:$Type\s*)?\Q$testval\E\s*=\s*(?:\([^\)]*\)\s*)?\s*(?:devm_)?(?:[kv][czm]alloc(?:_node|_array)?\b|kstrdup|(?:dev_)?alloc_skb)/) {
4046 }
4047 }
4049 # check for bad placement of section $InitAttribute (e.g.: __initdata)
4052 if ($line =~ /^\+\s*static\s+(?:const\s+)?(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*[=;]/) {
4062 $fixed[$linenr - 1] =~ s/(\bstatic\s+(?:const\s+)?)(?:$attr\s+)?($NonptrTypeWithAttr)\s+(?:$attr\s+)?($Ident(?:\[[^]]*\])?)\s*([=;])\s*/"$1" . trim(string_find_replace($2, "\\s*$attr\\s*", " ")) . " " . trim(string_find_replace($3, "\\s*$attr\\s*", "")) . " $attr" . ("$4" eq ";" ? ";" : " = ")/e;
4063 }
4064 }
4065 }
4067 # check for $InitAttributeData (ie: __initdata) with const
4078 }
4079 }
4081 # check for $InitAttributeConst (ie: __initconst) without const
4093 }
4094 }
4096 # don't use __constant_<foo> functions outside of include/uapi/
4098 $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {
4106 }
4107 }
4109 # prefer usleep_range over udelay
4112 # ignore udelay's < 10, however
4115 "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $herecurr);
4116 }
4120 }
4121 }
4123 # warn about unexpectedly long msleep's
4127 "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $herecurr);
4128 }
4129 }
4131 # check for comparisons of jiffies
4134 "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr);
4135 }
4137 # check for comparisons of get_jiffies_64()
4140 "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
4141 }
4143 # warn about #ifdefs in C files
4144 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
4145 # print "#ifdef in C files should be avoided\n";
4146 # print "$herecurr";
4147 # $clean = 0;
4148 # }
4150 # warn about spacing in #ifdefs
4157 }
4159 }
4161 # check for spinlock_t definitions without a comment.
4168 }
4169 }
4170 # check for memory barriers without a comment.
4171 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
4175 }
4176 }
4177 # check of hardware specific defines
4178 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
4181 }
4183 # Check that the storage class is at the beginning of a declaration
4187 }
4189 # check the location of the inline attribute, that it is between
4190 # storage class and type.
4195 }
4197 # Check for __inline__ and __inline, prefer inline
4205 }
4206 }
4208 # Check for __attribute__ packed, prefer __packed
4213 }
4215 # Check for __attribute__ aligned, prefer __aligned
4220 }
4222 # Check for __attribute__ format(printf, prefer __printf
4226 "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr) &&
4228 $fixed[$linenr - 1] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
4230 }
4231 }
4233 # Check for __attribute__ format(scanf, prefer __scanf
4237 "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr) &&
4239 $fixed[$linenr - 1] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
4240 }
4241 }
4243 # check for sizeof(&)
4247 }
4249 # check for sizeof without parenthesis
4254 $fixed[$linenr - 1] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
4255 }
4256 }
4258 # check for line continuations in quoted strings with odd counts of "
4262 }
4264 # check for struct spinlock declarations
4268 }
4270 # check for seq_printf uses that could be seq_puts
4278 }
4279 }
4280 }
4282 # Check for misused memsets
4297 }
4298 }
4300 # Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)
4304 "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . $herecurr) &&
4306 $fixed[$linenr - 1] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;
4307 }
4308 }
4310 # typecasts on min/max could be min_t/max_t
4328 }
4331 }
4332 }
4334 # check usleep_range arguments
4342 "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
4346 "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
4347 }
4348 }
4350 # check for naked sscanf
4362 }
4365 }
4367 # check for simple sscanf that should be kstrto<foo>
4376 }
4384 }
4385 }
4386 }
4388 # check for new externs in .h files.
4395 }
4396 }
4398 # check for new externs in .c files.
4401 {
4408 }
4411 {
4414 }
4419 }
4423 {
4426 }
4428 # checks for new __setup's
4435 }
4436 }
4438 # check for pointless casting of kmalloc return
4441 "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
4442 }
4444 # alloc style
4445 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
4447 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
4450 }
4452 # check for k[mz]alloc with multiplies that could be kmalloc_array/kcalloc
4454 $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/) {
4469 }
4470 $fixed[$linenr - 1] =~ s/\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*(k[mz]alloc)\s*\(\s*($FuncArg)\s*\*\s*($FuncArg)/$1 . ' = ' . "$newfunc(" . trim($r1) . ', ' . trim($r2)/e;
4472 }
4473 }
4474 }
4476 # check for krealloc arg reuse
4481 }
4483 # check for alloc argument mismatch
4487 }
4489 # check for multiple semicolons
4495 }
4496 }
4498 # check for case / default statements not preceeded by break/fallthrough/switch
4516 }
4520 }
4521 }
4523 # check for switch/default statements without a break;
4532 }
4535 }
4537 # check for gcc specific __FUNCTION__
4543 }
4544 }
4546 # check for use of yield()
4550 }
4552 # check for comparisons against true and false
4568 }
4573 ## maybe suggesting a correct construct would better
4574 ## "Using comparison to $otype is error prone. Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
4576 }
4577 }
4579 # check for semaphores initialized locked
4583 }
4585 # recommend kstrto* over simple_strto* and strict_strto*
4589 }
4591 # check for __initcall(), use device_initcall() explicitly or more appropriate function please
4594 "please use device_initcall() or more appropriate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
4595 }
4597 # check for various ops structs, ensure they are const.
4599 address_space_operations|
4600 backlight_ops|
4601 block_device_operations|
4602 dentry_operations|
4603 dev_pm_ops|
4604 dma_map_ops|
4605 extent_io_ops|
4606 file_lock_operations|
4607 file_operations|
4608 hv_ops|
4609 ide_dma_ops|
4610 intel_dvo_dev_ops|
4611 item_operations|
4612 iwl_ops|
4613 kgdb_arch|
4614 kgdb_io|
4615 kset_uevent_ops|
4616 lock_manager_operations|
4617 microcode_ops|
4618 mtrr_ops|
4619 neigh_ops|
4620 nlmsvc_binding|
4621 pci_raw_ops|
4622 pipe_buf_operations|
4623 platform_hibernation_ops|
4624 platform_suspend_ops|
4625 proto_ops|
4626 rpc_pipe_ops|
4627 seq_operations|
4628 snd_ac97_build_ops|
4629 soc_pcmcia_socket_ops|
4630 stacktrace_ops|
4631 sysfs_ops|
4632 tty_operations|
4633 usb_mon_operations|
4640 }
4642 # use of NR_CPUS is usually wrong
4643 # ignore definitions of NR_CPUS and usage to define arrays as likely right
4650 {
4652 "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
4653 }
4655 # Use of __ARCH_HAS_<FOO> or ARCH_HAVE_<BAR> is wrong.
4659 }
4661 # check for %L{u,d,i} in strings
4670 }
4671 }
4673 # whine mightly about in_atomic
4681 }
4682 }
4684 # check for lockdep_set_novalidate_class
4692 }
4693 }
4698 "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
4699 }
4701 # Mode permission misuses where it seems decimal should be octal
4702 # This uses a shortcut match to avoid unnecessary uses of a slow foreach loop
4713 }
4724 }
4725 }
4726 }
4727 }
4728 }
4730 # If we have no input at all, then there is nothing to report on
4731 # so just keep quiet.
4734 }
4736 # In mailback mode only produce a report in the negative, for
4737 # things that appear to be patches.
4740 }
4742 # This is not a patch, and we are are in 'no-patch' mode so
4743 # just keep quiet.
4746 }
4751 }
4755 }
4764 }
4771 }
4773 # If there were whitespace errors which cleanpatch can fix
4774 # then suggest that.
4779 }
4780 }
4799 }
4802 }
4803 }
4810 Do _NOT_ trust the results written to this file.
4813 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
4816 EOM
4817 }
4818 }
4822 }
4827 If any of these errors are false positives, please report
4829 EOM
4830 }
4833 }