perf report: Treat an argument as a symbol filter
[linux-2.6.git] / tools / perf / builtin-report.c
blobc00545806bb70ff19cf39e626ddb5ac220eac0da
1 /*
2 * builtin-report.c
4 * Builtin report command: Analyze the perf.data input file,
5 * look up and read DSOs and symbol information and display
6 * a histogram of results, along various sorting keys.
7 */
8 #include "builtin.h"
10 #include "util/util.h"
12 #include "util/annotate.h"
13 #include "util/color.h"
14 #include <linux/list.h>
15 #include "util/cache.h"
16 #include <linux/rbtree.h>
17 #include "util/symbol.h"
18 #include "util/callchain.h"
19 #include "util/strlist.h"
20 #include "util/values.h"
22 #include "perf.h"
23 #include "util/debug.h"
24 #include "util/evlist.h"
25 #include "util/evsel.h"
26 #include "util/header.h"
27 #include "util/session.h"
28 #include "util/tool.h"
30 #include "util/parse-options.h"
31 #include "util/parse-events.h"
33 #include "util/thread.h"
34 #include "util/sort.h"
35 #include "util/hist.h"
37 #include <linux/bitmap.h>
39 struct perf_report {
40 struct perf_tool tool;
41 struct perf_session *session;
42 char const *input_name;
43 bool force, use_tui, use_stdio;
44 bool hide_unresolved;
45 bool dont_use_callchains;
46 bool show_full_info;
47 bool show_threads;
48 bool inverted_callchain;
49 struct perf_read_values show_threads_values;
50 const char *pretty_printing_style;
51 symbol_filter_t annotate_init;
52 const char *cpu_list;
53 const char *symbol_filter_str;
54 DECLARE_BITMAP(cpu_bitmap, MAX_NR_CPUS);
57 static int perf_report__add_branch_hist_entry(struct perf_tool *tool,
58 struct addr_location *al,
59 struct perf_sample *sample,
60 struct perf_evsel *evsel,
61 struct machine *machine)
63 struct perf_report *rep = container_of(tool, struct perf_report, tool);
64 struct symbol *parent = NULL;
65 int err = 0;
66 unsigned i;
67 struct hist_entry *he;
68 struct branch_info *bi, *bx;
70 if ((sort__has_parent || symbol_conf.use_callchain)
71 && sample->callchain) {
72 err = machine__resolve_callchain(machine, evsel, al->thread,
73 sample->callchain, &parent);
74 if (err)
75 return err;
78 bi = machine__resolve_bstack(machine, al->thread,
79 sample->branch_stack);
80 if (!bi)
81 return -ENOMEM;
83 for (i = 0; i < sample->branch_stack->nr; i++) {
84 if (rep->hide_unresolved && !(bi[i].from.sym && bi[i].to.sym))
85 continue;
87 * The report shows the percentage of total branches captured
88 * and not events sampled. Thus we use a pseudo period of 1.
90 he = __hists__add_branch_entry(&evsel->hists, al, parent,
91 &bi[i], 1);
92 if (he) {
93 struct annotation *notes;
94 err = -ENOMEM;
95 bx = he->branch_info;
96 if (bx->from.sym && use_browser > 0) {
97 notes = symbol__annotation(bx->from.sym);
98 if (!notes->src
99 && symbol__alloc_hist(bx->from.sym) < 0)
100 goto out;
102 err = symbol__inc_addr_samples(bx->from.sym,
103 bx->from.map,
104 evsel->idx,
105 bx->from.al_addr);
106 if (err)
107 goto out;
110 if (bx->to.sym && use_browser > 0) {
111 notes = symbol__annotation(bx->to.sym);
112 if (!notes->src
113 && symbol__alloc_hist(bx->to.sym) < 0)
114 goto out;
116 err = symbol__inc_addr_samples(bx->to.sym,
117 bx->to.map,
118 evsel->idx,
119 bx->to.al_addr);
120 if (err)
121 goto out;
123 evsel->hists.stats.total_period += 1;
124 hists__inc_nr_events(&evsel->hists, PERF_RECORD_SAMPLE);
125 err = 0;
126 } else
127 return -ENOMEM;
129 out:
130 return err;
133 static int perf_evsel__add_hist_entry(struct perf_evsel *evsel,
134 struct addr_location *al,
135 struct perf_sample *sample,
136 struct machine *machine)
138 struct symbol *parent = NULL;
139 int err = 0;
140 struct hist_entry *he;
142 if ((sort__has_parent || symbol_conf.use_callchain) && sample->callchain) {
143 err = machine__resolve_callchain(machine, evsel, al->thread,
144 sample->callchain, &parent);
145 if (err)
146 return err;
149 he = __hists__add_entry(&evsel->hists, al, parent, sample->period);
150 if (he == NULL)
151 return -ENOMEM;
153 if (symbol_conf.use_callchain) {
154 err = callchain_append(he->callchain,
155 &evsel->hists.callchain_cursor,
156 sample->period);
157 if (err)
158 return err;
161 * Only in the newt browser we are doing integrated annotation,
162 * so we don't allocated the extra space needed because the stdio
163 * code will not use it.
165 if (al->sym != NULL && use_browser > 0) {
166 struct annotation *notes = symbol__annotation(he->ms.sym);
168 assert(evsel != NULL);
170 err = -ENOMEM;
171 if (notes->src == NULL && symbol__alloc_hist(he->ms.sym) < 0)
172 goto out;
174 err = hist_entry__inc_addr_samples(he, evsel->idx, al->addr);
177 evsel->hists.stats.total_period += sample->period;
178 hists__inc_nr_events(&evsel->hists, PERF_RECORD_SAMPLE);
179 out:
180 return err;
184 static int process_sample_event(struct perf_tool *tool,
185 union perf_event *event,
186 struct perf_sample *sample,
187 struct perf_evsel *evsel,
188 struct machine *machine)
190 struct perf_report *rep = container_of(tool, struct perf_report, tool);
191 struct addr_location al;
193 if (perf_event__preprocess_sample(event, machine, &al, sample,
194 rep->annotate_init) < 0) {
195 fprintf(stderr, "problem processing %d event, skipping it.\n",
196 event->header.type);
197 return -1;
200 if (al.filtered || (rep->hide_unresolved && al.sym == NULL))
201 return 0;
203 if (rep->cpu_list && !test_bit(sample->cpu, rep->cpu_bitmap))
204 return 0;
206 if (sort__branch_mode == 1) {
207 if (perf_report__add_branch_hist_entry(tool, &al, sample,
208 evsel, machine)) {
209 pr_debug("problem adding lbr entry, skipping event\n");
210 return -1;
212 } else {
213 if (al.map != NULL)
214 al.map->dso->hit = 1;
216 if (perf_evsel__add_hist_entry(evsel, &al, sample, machine)) {
217 pr_debug("problem incrementing symbol period, skipping event\n");
218 return -1;
221 return 0;
224 static int process_read_event(struct perf_tool *tool,
225 union perf_event *event,
226 struct perf_sample *sample __used,
227 struct perf_evsel *evsel,
228 struct machine *machine __used)
230 struct perf_report *rep = container_of(tool, struct perf_report, tool);
232 if (rep->show_threads) {
233 const char *name = evsel ? event_name(evsel) : "unknown";
234 perf_read_values_add_value(&rep->show_threads_values,
235 event->read.pid, event->read.tid,
236 event->read.id,
237 name,
238 event->read.value);
241 dump_printf(": %d %d %s %" PRIu64 "\n", event->read.pid, event->read.tid,
242 evsel ? event_name(evsel) : "FAIL",
243 event->read.value);
245 return 0;
248 static int perf_report__setup_sample_type(struct perf_report *rep)
250 struct perf_session *self = rep->session;
252 if (!(self->sample_type & PERF_SAMPLE_CALLCHAIN)) {
253 if (sort__has_parent) {
254 ui__warning("Selected --sort parent, but no "
255 "callchain data. Did you call "
256 "'perf record' without -g?\n");
257 return -EINVAL;
259 if (symbol_conf.use_callchain) {
260 ui__warning("Selected -g but no callchain data. Did "
261 "you call 'perf record' without -g?\n");
262 return -1;
264 } else if (!rep->dont_use_callchains &&
265 callchain_param.mode != CHAIN_NONE &&
266 !symbol_conf.use_callchain) {
267 symbol_conf.use_callchain = true;
268 if (callchain_register_param(&callchain_param) < 0) {
269 ui__warning("Can't register callchain "
270 "params.\n");
271 return -EINVAL;
275 if (sort__branch_mode == 1) {
276 if (!(self->sample_type & PERF_SAMPLE_BRANCH_STACK)) {
277 fprintf(stderr, "selected -b but no branch data."
278 " Did you call perf record without"
279 " -b?\n");
280 return -1;
284 return 0;
287 extern volatile int session_done;
289 static void sig_handler(int sig __used)
291 session_done = 1;
294 static size_t hists__fprintf_nr_sample_events(struct hists *self,
295 const char *evname, FILE *fp)
297 size_t ret;
298 char unit;
299 unsigned long nr_events = self->stats.nr_events[PERF_RECORD_SAMPLE];
301 nr_events = convert_unit(nr_events, &unit);
302 ret = fprintf(fp, "# Events: %lu%c", nr_events, unit);
303 if (evname != NULL)
304 ret += fprintf(fp, " %s", evname);
305 return ret + fprintf(fp, "\n#\n");
308 static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist,
309 struct perf_report *rep,
310 const char *help)
312 struct perf_evsel *pos;
314 list_for_each_entry(pos, &evlist->entries, node) {
315 struct hists *hists = &pos->hists;
316 const char *evname = event_name(pos);
318 hists__fprintf_nr_sample_events(hists, evname, stdout);
319 hists__fprintf(hists, NULL, false, true, 0, 0, stdout);
320 fprintf(stdout, "\n\n");
323 if (sort_order == default_sort_order &&
324 parent_pattern == default_parent_pattern) {
325 fprintf(stdout, "#\n# (%s)\n#\n", help);
327 if (rep->show_threads) {
328 bool style = !strcmp(rep->pretty_printing_style, "raw");
329 perf_read_values_display(stdout, &rep->show_threads_values,
330 style);
331 perf_read_values_destroy(&rep->show_threads_values);
335 return 0;
338 static int __cmd_report(struct perf_report *rep)
340 int ret = -EINVAL;
341 u64 nr_samples;
342 struct perf_session *session = rep->session;
343 struct perf_evsel *pos;
344 struct map *kernel_map;
345 struct kmap *kernel_kmap;
346 const char *help = "For a higher level overview, try: perf report --sort comm,dso";
348 signal(SIGINT, sig_handler);
350 if (rep->cpu_list) {
351 ret = perf_session__cpu_bitmap(session, rep->cpu_list,
352 rep->cpu_bitmap);
353 if (ret)
354 goto out_delete;
357 if (use_browser <= 0)
358 perf_session__fprintf_info(session, stdout, rep->show_full_info);
360 if (rep->show_threads)
361 perf_read_values_init(&rep->show_threads_values);
363 ret = perf_report__setup_sample_type(rep);
364 if (ret)
365 goto out_delete;
367 ret = perf_session__process_events(session, &rep->tool);
368 if (ret)
369 goto out_delete;
371 kernel_map = session->host_machine.vmlinux_maps[MAP__FUNCTION];
372 kernel_kmap = map__kmap(kernel_map);
373 if (kernel_map == NULL ||
374 (kernel_map->dso->hit &&
375 (kernel_kmap->ref_reloc_sym == NULL ||
376 kernel_kmap->ref_reloc_sym->addr == 0))) {
377 const struct dso *kdso = kernel_map->dso;
379 ui__warning(
380 "Kernel address maps (/proc/{kallsyms,modules}) were restricted.\n\n"
381 "Check /proc/sys/kernel/kptr_restrict before running 'perf record'.\n\n%s\n\n"
382 "Samples in kernel modules can't be resolved as well.\n\n",
383 RB_EMPTY_ROOT(&kdso->symbols[MAP__FUNCTION]) ?
384 "As no suitable kallsyms nor vmlinux was found, kernel samples\n"
385 "can't be resolved." :
386 "If some relocation was applied (e.g. kexec) symbols may be misresolved.");
389 if (dump_trace) {
390 perf_session__fprintf_nr_events(session, stdout);
391 goto out_delete;
394 if (verbose > 3)
395 perf_session__fprintf(session, stdout);
397 if (verbose > 2)
398 perf_session__fprintf_dsos(session, stdout);
400 nr_samples = 0;
401 list_for_each_entry(pos, &session->evlist->entries, node) {
402 struct hists *hists = &pos->hists;
404 if (pos->idx == 0)
405 hists->symbol_filter_str = rep->symbol_filter_str;
407 hists__collapse_resort(hists);
408 hists__output_resort(hists);
409 nr_samples += hists->stats.nr_events[PERF_RECORD_SAMPLE];
412 if (nr_samples == 0) {
413 ui__warning("The %s file has no samples!\n", session->filename);
414 goto out_delete;
417 if (use_browser > 0) {
418 perf_evlist__tui_browse_hists(session->evlist, help,
419 NULL, NULL, 0);
420 } else
421 perf_evlist__tty_browse_hists(session->evlist, rep, help);
423 out_delete:
425 * Speed up the exit process, for large files this can
426 * take quite a while.
428 * XXX Enable this when using valgrind or if we ever
429 * librarize this command.
431 * Also experiment with obstacks to see how much speed
432 * up we'll get here.
434 * perf_session__delete(session);
436 return ret;
439 static int
440 parse_callchain_opt(const struct option *opt, const char *arg, int unset)
442 struct perf_report *rep = (struct perf_report *)opt->value;
443 char *tok, *tok2;
444 char *endptr;
447 * --no-call-graph
449 if (unset) {
450 rep->dont_use_callchains = true;
451 return 0;
454 symbol_conf.use_callchain = true;
456 if (!arg)
457 return 0;
459 tok = strtok((char *)arg, ",");
460 if (!tok)
461 return -1;
463 /* get the output mode */
464 if (!strncmp(tok, "graph", strlen(arg)))
465 callchain_param.mode = CHAIN_GRAPH_ABS;
467 else if (!strncmp(tok, "flat", strlen(arg)))
468 callchain_param.mode = CHAIN_FLAT;
470 else if (!strncmp(tok, "fractal", strlen(arg)))
471 callchain_param.mode = CHAIN_GRAPH_REL;
473 else if (!strncmp(tok, "none", strlen(arg))) {
474 callchain_param.mode = CHAIN_NONE;
475 symbol_conf.use_callchain = false;
477 return 0;
480 else
481 return -1;
483 /* get the min percentage */
484 tok = strtok(NULL, ",");
485 if (!tok)
486 goto setup;
488 callchain_param.min_percent = strtod(tok, &endptr);
489 if (tok == endptr)
490 return -1;
492 /* get the print limit */
493 tok2 = strtok(NULL, ",");
494 if (!tok2)
495 goto setup;
497 if (tok2[0] != 'c') {
498 callchain_param.print_limit = strtoul(tok2, &endptr, 0);
499 tok2 = strtok(NULL, ",");
500 if (!tok2)
501 goto setup;
504 /* get the call chain order */
505 if (!strcmp(tok2, "caller"))
506 callchain_param.order = ORDER_CALLER;
507 else if (!strcmp(tok2, "callee"))
508 callchain_param.order = ORDER_CALLEE;
509 else
510 return -1;
511 setup:
512 if (callchain_register_param(&callchain_param) < 0) {
513 fprintf(stderr, "Can't register callchain params\n");
514 return -1;
516 return 0;
519 static int
520 parse_branch_mode(const struct option *opt __used, const char *str __used, int unset)
522 sort__branch_mode = !unset;
523 return 0;
526 int cmd_report(int argc, const char **argv, const char *prefix __used)
528 struct perf_session *session;
529 struct stat st;
530 bool has_br_stack = false;
531 int ret = -1;
532 char callchain_default_opt[] = "fractal,0.5,callee";
533 const char * const report_usage[] = {
534 "perf report [<options>]",
535 NULL
537 struct perf_report report = {
538 .tool = {
539 .sample = process_sample_event,
540 .mmap = perf_event__process_mmap,
541 .comm = perf_event__process_comm,
542 .exit = perf_event__process_task,
543 .fork = perf_event__process_task,
544 .lost = perf_event__process_lost,
545 .read = process_read_event,
546 .attr = perf_event__process_attr,
547 .event_type = perf_event__process_event_type,
548 .tracing_data = perf_event__process_tracing_data,
549 .build_id = perf_event__process_build_id,
550 .ordered_samples = true,
551 .ordering_requires_timestamps = true,
553 .pretty_printing_style = "normal",
555 const struct option options[] = {
556 OPT_STRING('i', "input", &report.input_name, "file",
557 "input file name"),
558 OPT_INCR('v', "verbose", &verbose,
559 "be more verbose (show symbol address, etc)"),
560 OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace,
561 "dump raw trace in ASCII"),
562 OPT_STRING('k', "vmlinux", &symbol_conf.vmlinux_name,
563 "file", "vmlinux pathname"),
564 OPT_STRING(0, "kallsyms", &symbol_conf.kallsyms_name,
565 "file", "kallsyms pathname"),
566 OPT_BOOLEAN('f', "force", &report.force, "don't complain, do it"),
567 OPT_BOOLEAN('m', "modules", &symbol_conf.use_modules,
568 "load module symbols - WARNING: use only with -k and LIVE kernel"),
569 OPT_BOOLEAN('n', "show-nr-samples", &symbol_conf.show_nr_samples,
570 "Show a column with the number of samples"),
571 OPT_BOOLEAN('T', "threads", &report.show_threads,
572 "Show per-thread event counters"),
573 OPT_STRING(0, "pretty", &report.pretty_printing_style, "key",
574 "pretty printing style key: normal raw"),
575 OPT_BOOLEAN(0, "tui", &report.use_tui, "Use the TUI interface"),
576 OPT_BOOLEAN(0, "stdio", &report.use_stdio,
577 "Use the stdio interface"),
578 OPT_STRING('s', "sort", &sort_order, "key[,key2...]",
579 "sort by key(s): pid, comm, dso, symbol, parent, dso_to,"
580 " dso_from, symbol_to, symbol_from, mispredict"),
581 OPT_BOOLEAN(0, "showcpuutilization", &symbol_conf.show_cpu_utilization,
582 "Show sample percentage for different cpu modes"),
583 OPT_STRING('p', "parent", &parent_pattern, "regex",
584 "regex filter to identify parent, see: '--sort parent'"),
585 OPT_BOOLEAN('x', "exclude-other", &symbol_conf.exclude_other,
586 "Only display entries with parent-match"),
587 OPT_CALLBACK_DEFAULT('g', "call-graph", &report, "output_type,min_percent[,print_limit],call_order",
588 "Display callchains using output_type (graph, flat, fractal, or none) , min percent threshold, optional print limit and callchain order. "
589 "Default: fractal,0.5,callee", &parse_callchain_opt, callchain_default_opt),
590 OPT_BOOLEAN('G', "inverted", &report.inverted_callchain,
591 "alias for inverted call graph"),
592 OPT_STRING('d', "dsos", &symbol_conf.dso_list_str, "dso[,dso...]",
593 "only consider symbols in these dsos"),
594 OPT_STRING('c', "comms", &symbol_conf.comm_list_str, "comm[,comm...]",
595 "only consider symbols in these comms"),
596 OPT_STRING('S', "symbols", &symbol_conf.sym_list_str, "symbol[,symbol...]",
597 "only consider these symbols"),
598 OPT_STRING(0, "symbol-filter", &report.symbol_filter_str, "filter",
599 "only show symbols that (partially) match with this filter"),
600 OPT_STRING('w', "column-widths", &symbol_conf.col_width_list_str,
601 "width[,width...]",
602 "don't try to adjust column width, use these fixed values"),
603 OPT_STRING('t', "field-separator", &symbol_conf.field_sep, "separator",
604 "separator for columns, no spaces will be added between "
605 "columns '.' is reserved."),
606 OPT_BOOLEAN('U', "hide-unresolved", &report.hide_unresolved,
607 "Only display entries resolved to a symbol"),
608 OPT_STRING(0, "symfs", &symbol_conf.symfs, "directory",
609 "Look for files with symbols relative to this directory"),
610 OPT_STRING('C', "cpu", &report.cpu_list, "cpu",
611 "list of cpus to profile"),
612 OPT_BOOLEAN('I', "show-info", &report.show_full_info,
613 "Display extended information about perf.data file"),
614 OPT_BOOLEAN(0, "source", &symbol_conf.annotate_src,
615 "Interleave source code with assembly code (default)"),
616 OPT_BOOLEAN(0, "asm-raw", &symbol_conf.annotate_asm_raw,
617 "Display raw encoding of assembly instructions (default)"),
618 OPT_STRING('M', "disassembler-style", &disassembler_style, "disassembler style",
619 "Specify disassembler style (e.g. -M intel for intel syntax)"),
620 OPT_BOOLEAN(0, "show-total-period", &symbol_conf.show_total_period,
621 "Show a column with the sum of periods"),
622 OPT_CALLBACK_NOOPT('b', "branch-stack", &sort__branch_mode, "",
623 "use branch records for histogram filling", parse_branch_mode),
624 OPT_END()
627 argc = parse_options(argc, argv, options, report_usage, 0);
629 if (report.use_stdio)
630 use_browser = 0;
631 else if (report.use_tui)
632 use_browser = 1;
634 if (report.inverted_callchain)
635 callchain_param.order = ORDER_CALLER;
637 if (!report.input_name || !strlen(report.input_name)) {
638 if (!fstat(STDIN_FILENO, &st) && S_ISFIFO(st.st_mode))
639 report.input_name = "-";
640 else
641 report.input_name = "perf.data";
643 session = perf_session__new(report.input_name, O_RDONLY,
644 report.force, false, &report.tool);
645 if (session == NULL)
646 return -ENOMEM;
648 report.session = session;
650 has_br_stack = perf_header__has_feat(&session->header,
651 HEADER_BRANCH_STACK);
653 if (sort__branch_mode == -1 && has_br_stack)
654 sort__branch_mode = 1;
656 /* sort__branch_mode could be 0 if --no-branch-stack */
657 if (sort__branch_mode == 1) {
659 * if no sort_order is provided, then specify
660 * branch-mode specific order
662 if (sort_order == default_sort_order)
663 sort_order = "comm,dso_from,symbol_from,"
664 "dso_to,symbol_to";
668 if (strcmp(report.input_name, "-") != 0) {
669 setup_browser(true);
670 } else {
671 use_browser = 0;
675 * Only in the newt browser we are doing integrated annotation,
676 * so don't allocate extra space that won't be used in the stdio
677 * implementation.
679 if (use_browser > 0) {
680 symbol_conf.priv_size = sizeof(struct annotation);
681 report.annotate_init = symbol__annotate_init;
683 * For searching by name on the "Browse map details".
684 * providing it only in verbose mode not to bloat too
685 * much struct symbol.
687 if (verbose) {
689 * XXX: Need to provide a less kludgy way to ask for
690 * more space per symbol, the u32 is for the index on
691 * the ui browser.
692 * See symbol__browser_index.
694 symbol_conf.priv_size += sizeof(u32);
695 symbol_conf.sort_by_name = true;
699 if (symbol__init() < 0)
700 goto error;
702 setup_sorting(report_usage, options);
704 if (parent_pattern != default_parent_pattern) {
705 if (sort_dimension__add("parent") < 0)
706 goto error;
709 * Only show the parent fields if we explicitly
710 * sort that way. If we only use parent machinery
711 * for filtering, we don't want it.
713 if (!strstr(sort_order, "parent"))
714 sort_parent.elide = 1;
715 } else
716 symbol_conf.exclude_other = false;
718 if (argc) {
720 * Special case: if there's an argument left then assume that
721 * it's a symbol filter:
723 if (argc > 1)
724 usage_with_options(report_usage, options);
726 report.symbol_filter_str = argv[0];
729 sort_entry__setup_elide(&sort_comm, symbol_conf.comm_list, "comm", stdout);
731 if (sort__branch_mode == 1) {
732 sort_entry__setup_elide(&sort_dso_from, symbol_conf.dso_from_list, "dso_from", stdout);
733 sort_entry__setup_elide(&sort_dso_to, symbol_conf.dso_to_list, "dso_to", stdout);
734 sort_entry__setup_elide(&sort_sym_from, symbol_conf.sym_from_list, "sym_from", stdout);
735 sort_entry__setup_elide(&sort_sym_to, symbol_conf.sym_to_list, "sym_to", stdout);
736 } else {
737 sort_entry__setup_elide(&sort_dso, symbol_conf.dso_list, "dso", stdout);
738 sort_entry__setup_elide(&sort_sym, symbol_conf.sym_list, "symbol", stdout);
741 ret = __cmd_report(&report);
742 error:
743 perf_session__delete(session);
744 return ret;