6 use t
::lib
::TestBuilder
;
10 use Test
::More tests
=> 58;
17 use Koha
::DateUtils
qw( dt_from_string output_pref );
23 use lib
$FindBin::Bin
;
24 use_ok
('C4::Reserves');
27 my $schema = Koha
::Database
->new->schema;
28 $schema->storage->txn_begin;
30 my $builder = t
::lib
::TestBuilder
->new();
31 my $dbh = C4
::Context
->dbh;
33 # Create two random branches
34 my $branch_1 = $builder->build({ source
=> 'Branch' })->{ branchcode
};
35 my $branch_2 = $builder->build({ source
=> 'Branch' })->{ branchcode
};
37 my $category = $builder->build({ source
=> 'Category' });
39 my $borrowers_count = 5;
41 $dbh->do('DELETE FROM itemtypes');
42 $dbh->do('DELETE FROM reserves');
43 my $insert_sth = $dbh->prepare('INSERT INTO itemtypes (itemtype) VALUES (?)');
44 $insert_sth->execute('CAN');
45 $insert_sth->execute('CANNOT');
46 $insert_sth->execute('DUMMY');
47 $insert_sth->execute('ONLY1');
49 # Setup Test------------------------
50 # Create a biblio instance for testing
51 my ($bibnum, $title, $bibitemnum) = create_helper_biblio
('DUMMY');
53 # Create item instance for testing.
54 my ($item_bibnum, $item_bibitemnum, $itemnumber)
55 = AddItem
({ homebranch
=> $branch_1, holdingbranch
=> $branch_1 } , $bibnum);
57 # Create some borrowers
59 foreach (1..$borrowers_count) {
60 my $borrowernumber = AddMember
(
61 firstname
=> 'my firstname',
62 surname
=> 'my surname ' . $_,
63 categorycode
=> $category->{categorycode
},
64 branchcode
=> $branch_1,
66 push @borrowernumbers, $borrowernumber;
69 my $biblionumber = $bibnum;
71 # Create five item level holds
72 foreach my $borrowernumber ( @borrowernumbers ) {
78 my $priority = C4
::Reserves
::CalculatePriority
( $biblionumber ),
83 my $checkitem = $itemnumber,
88 my $biblio = Koha
::Biblios
->find( $biblionumber );
89 my $holds = $biblio->holds;
90 is
( $holds->count, $borrowers_count, 'Test GetReserves()' );
91 is
( $holds->next->priority, 1, "Reserve 1 has a priority of 1" );
92 is
( $holds->next->priority, 2, "Reserve 2 has a priority of 2" );
93 is
( $holds->next->priority, 3, "Reserve 3 has a priority of 3" );
94 is
( $holds->next->priority, 4, "Reserve 4 has a priority of 4" );
95 is
( $holds->next->priority, 5, "Reserve 5 has a priority of 5" );
97 my $item = Koha
::Items
->find( $itemnumber );
98 $holds = $item->current_holds;
99 my $first_hold = $holds->next;
100 my $reservedate = $first_hold->reservedate;
101 my $borrowernumber = $first_hold->borrowernumber;
102 my $branch_1code = $first_hold->branchcode;
103 my $reserve_id = $first_hold->reserve_id;
104 is
( $reservedate, output_pref
({ dt
=> dt_from_string
, dateformat
=> 'iso', dateonly
=> 1 }), "holds_placed_today should return a valid reserve date");
105 is
( $borrowernumber, $borrowernumbers[0], "holds_placed_today should return a valid borrowernumber");
106 is
( $branch_1code, $branch_1, "holds_placed_today should return a valid branchcode");
107 ok
($reserve_id, "Test holds_placed_today()");
109 my $hold = Koha
::Holds
->find( $reserve_id );
110 ok
( $hold, "Koha::Holds found the hold" );
111 my $hold_biblio = $hold->biblio();
112 ok
( $hold_biblio, "Got biblio using biblio() method" );
113 ok
( $hold_biblio == $hold->biblio(), "biblio method returns stashed biblio" );
114 my $hold_item = $hold->item();
115 ok
( $hold_item, "Got item using item() method" );
116 ok
( $hold_item == $hold->item(), "item method returns stashed item" );
117 my $hold_branch = $hold->branch();
118 ok
( $hold_branch, "Got branch using branch() method" );
119 ok
( $hold_branch == $hold->branch(), "branch method returns stashed branch" );
120 my $hold_found = $hold->found();
121 $hold->set({ found
=> 'W'})->store();
122 is
( Koha
::Holds
->waiting()->count(), 1, "Koha::Holds->waiting returns waiting holds" );
124 my ( $reserve ) = GetReservesFromBorrowernumber
($borrowernumbers[0]);
125 ok
( $reserve->{'borrowernumber'} eq $borrowernumbers[0], "Test GetReservesFromBorrowernumber()");
128 ok
( GetReserveCount
( $borrowernumbers[0] ), "Test GetReserveCount()" );
131 CancelReserve
({ 'reserve_id' => $reserve_id });
132 $holds = $biblio->holds;
133 is
( $holds->count, $borrowers_count - 1, "Test CancelReserve()" );
135 $holds = $item->current_holds;
136 $first_hold = $holds->next;
137 $borrowernumber = $first_hold->borrowernumber;
138 $branch_1code = $first_hold->branchcode;
139 $reserve_id = $first_hold->reserve_id;
142 reserve_id
=> $reserve_id,
144 branchcode
=> $branch_1,
145 itemnumber
=> $itemnumber,
146 suspend_until
=> output_pref
( { dt
=> dt_from_string
( "2013-01-01", "iso" ), dateonly
=> 1 } ),
149 $reserve = GetReserve
( $reserve_id );
150 ok
( $reserve->{'priority'} eq '4', "Test GetReserve(), priority changed correctly" );
151 ok
( $reserve->{'suspend'}, "Test GetReserve(), suspend hold" );
152 is
( $reserve->{'suspend_until'}, '2013-01-01 00:00:00', "Test GetReserve(), suspend until date" );
154 ToggleSuspend
( $reserve_id );
155 $reserve = GetReserve
( $reserve_id );
156 ok
( !$reserve->{'suspend'}, "Test ToggleSuspend(), no date" );
158 ToggleSuspend
( $reserve_id, '2012-01-01' );
159 $reserve = GetReserve
( $reserve_id );
160 is
( $reserve->{'suspend_until'}, '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
162 AutoUnsuspendReserves
();
163 $reserve = GetReserve
( $reserve_id );
164 ok
( !$reserve->{'suspend'}, "Test AutoUnsuspendReserves()" );
167 borrowernumber
=> $borrowernumber,
168 biblionumber
=> $biblionumber,
170 suspend_until
=> '2012-01-01',
172 $reserve = GetReserve
( $reserve_id );
173 is
( $reserve->{'suspend'}, 1, "Test SuspendAll()" );
174 is
( $reserve->{'suspend_until'}, '2012-01-01 00:00:00', "Test SuspendAll(), with date" );
177 borrowernumber
=> $borrowernumber,
178 biblionumber
=> $biblionumber,
181 $reserve = GetReserve
( $reserve_id );
182 is
( $reserve->{'suspend'}, 0, "Test resuming with SuspendAll()" );
183 is
( $reserve->{'suspend_until'}, undef, "Test resuming with SuspendAll(), should have no suspend until date" );
185 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
199 ( $reserve ) = GetReservesFromBorrowernumber
($borrowernumber);
200 my $reserveid = C4
::Reserves
::GetReserveId
(
202 biblionumber
=> $biblionumber,
203 borrowernumber
=> $borrowernumber
206 is
( $reserveid, $reserve->{reserve_id
}, "Test GetReserveId" );
207 ModReserveMinusPriority
( $itemnumber, $reserve->{'reserve_id'} );
208 ( $reserve ) = GetReservesFromBorrowernumber
($borrowernumber);
209 ok
( $reserve->{'itemnumber'} eq $itemnumber, "Test ModReserveMinusPriority()" );
212 my $reserve2 = GetReserveInfo
( $reserve->{'reserve_id'} );
213 ok
( $reserve->{'reserve_id'} eq $reserve2->{'reserve_id'}, "Test GetReserveInfo()" );
216 $holds = $biblio->holds;
217 $hold = $holds->next;
218 AlterPriority
( 'top', $hold->reserve_id );
219 $reserve = GetReserve
( $reserve->{'reserve_id'} );
220 is
( $reserve->{'priority'}, '1', "Test AlterPriority(), move to top" );
222 AlterPriority
( 'down', $reserve->{'reserve_id'} );
223 $reserve = GetReserve
( $reserve->{'reserve_id'} );
224 is
( $reserve->{'priority'}, '2', "Test AlterPriority(), move down" );
226 AlterPriority
( 'up', $reserve->{'reserve_id'} );
227 $reserve = GetReserve
( $reserve->{'reserve_id'} );
228 is
( $reserve->{'priority'}, '1', "Test AlterPriority(), move up" );
230 AlterPriority
( 'bottom', $reserve->{'reserve_id'} );
231 $reserve = GetReserve
( $reserve->{'reserve_id'} );
232 is
( $reserve->{'priority'}, '5', "Test AlterPriority(), move to bottom" );
234 # Regression test for bug 2394
236 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
237 # a patron is not permittedo to request an item whose homebranch (i.e.,
238 # owner of the item) is different from the patron's own library.
239 # However, if canreservefromotherbranches is turned ON, the patron can
240 # create such hold requests.
242 # Note that canreservefromotherbranches has no effect if
243 # IndependentBranches is OFF.
245 my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio
('DUMMY');
246 my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
247 = AddItem
({ homebranch
=> $branch_2, holdingbranch
=> $branch_2 } , $foreign_bibnum);
248 $dbh->do('DELETE FROM issuingrules');
250 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
251 VALUES (?, ?, ?, ?, ?)},
253 '*', '*', '*', 25, 99
256 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
257 VALUES (?, ?, ?, ?, ?)},
259 '*', '*', 'CANNOT', 0, 99
262 # make sure some basic sysprefs are set
263 t
::lib
::Mocks
::mock_preference
('ReservesControlBranch', 'ItemHomeLibrary');
264 t
::lib
::Mocks
::mock_preference
('item-level_itypes', 1);
266 # if IndependentBranches is OFF, a $branch_1 patron can reserve an $branch_2 item
267 t
::lib
::Mocks
::mock_preference
('IndependentBranches', 0);
269 CanItemBeReserved
($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
270 '$branch_1 patron allowed to reserve $branch_2 item with IndependentBranches OFF (bug 2394)'
273 # if IndependentBranches is OFF, a $branch_1 patron cannot reserve an $branch_2 item
274 t
::lib
::Mocks
::mock_preference
('IndependentBranches', 1);
275 t
::lib
::Mocks
::mock_preference
('canreservefromotherbranches', 0);
277 CanItemBeReserved
($borrowernumbers[0], $foreign_itemnumber) eq 'cannotReserveFromOtherBranches',
278 '$branch_1 patron NOT allowed to reserve $branch_2 item with IndependentBranches ON ... (bug 2394)'
281 # ... unless canreservefromotherbranches is ON
282 t
::lib
::Mocks
::mock_preference
('canreservefromotherbranches', 1);
284 CanItemBeReserved
($borrowernumbers[0], $foreign_itemnumber) eq 'OK',
285 '... unless canreservefromotherbranches is ON (bug 2394)'
288 # Regression test for bug 11336
289 ($bibnum, $title, $bibitemnum) = create_helper_biblio
('DUMMY');
290 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem
({ homebranch
=> $branch_1, holdingbranch
=> $branch_1 } , $bibnum);
299 my $reserveid1 = C4
::Reserves
::GetReserveId
(
301 biblionumber
=> $bibnum,
302 borrowernumber
=> $borrowernumbers[0]
306 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem
({ homebranch
=> $branch_1, holdingbranch
=> $branch_1 } , $bibnum);
314 my $reserveid2 = C4
::Reserves
::GetReserveId
(
316 biblionumber
=> $bibnum,
317 borrowernumber
=> $borrowernumbers[1]
321 CancelReserve
({ reserve_id
=> $reserveid1 });
323 $reserve2 = GetReserve
( $reserveid2 );
324 is
( $reserve2->{priority
}, 1, "After cancelreserve, the 2nd reserve becomes the first on the waiting list" );
326 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem
({ homebranch
=> $branch_1, holdingbranch
=> $branch_1 } , $bibnum);
334 my $reserveid3 = C4
::Reserves
::GetReserveId
(
336 biblionumber
=> $bibnum,
337 borrowernumber
=> $borrowernumbers[0]
341 my $reserve3 = GetReserve
( $reserveid3 );
342 is
( $reserve3->{priority
}, 2, "New reserve for patron 0, the reserve has a priority = 2" );
344 ModReserve
({ reserve_id
=> $reserveid2, rank
=> 'del' });
345 $reserve3 = GetReserve
( $reserveid3 );
346 is
( $reserve3->{priority
}, 1, "After ModReserve, the 3rd reserve becomes the first on the waiting list" );
348 ModItem
({ damaged
=> 1 }, $item_bibnum, $itemnumber);
349 t
::lib
::Mocks
::mock_preference
( 'AllowHoldsOnDamagedItems', 1 );
350 is
( CanItemBeReserved
( $borrowernumbers[0], $itemnumber), 'OK', "Patron can reserve damaged item with AllowHoldsOnDamagedItems enabled" );
351 ok
( defined( ( CheckReserves
($itemnumber) )[1] ), "Hold can be trapped for damaged item with AllowHoldsOnDamagedItems enabled" );
353 $hold = Koha
::Hold
->new(
355 borrowernumber
=> $borrowernumbers[0],
356 itemnumber
=> $itemnumber,
357 biblionumber
=> $item_bibnum,
360 is
( CanItemBeReserved
( $borrowernumbers[0], $itemnumber ),
362 "Patron cannot place a second item level hold for a given item" );
365 t
::lib
::Mocks
::mock_preference
( 'AllowHoldsOnDamagedItems', 0 );
366 ok
( CanItemBeReserved
( $borrowernumbers[0], $itemnumber) eq 'damaged', "Patron cannot reserve damaged item with AllowHoldsOnDamagedItems disabled" );
367 ok
( !defined( ( CheckReserves
($itemnumber) )[1] ), "Hold cannot be trapped for damaged item with AllowHoldsOnDamagedItems disabled" );
369 # Regression test for bug 9532
370 ($bibnum, $title, $bibitemnum) = create_helper_biblio
('CANNOT');
371 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem
({ homebranch
=> $branch_1, holdingbranch
=> $branch_1, itype
=> 'CANNOT' } , $bibnum);
380 CanItemBeReserved
( $borrowernumbers[0], $itemnumber), 'tooManyReserves',
381 "cannot request item if policy that matches on item-level item type forbids it"
383 ModItem
({ itype
=> 'CAN' }, $item_bibnum, $itemnumber);
385 CanItemBeReserved
( $borrowernumbers[0], $itemnumber) eq 'OK',
386 "can request item if policy that matches on item type allows it"
389 t
::lib
::Mocks
::mock_preference
('item-level_itypes', 0);
390 ModItem
({ itype
=> undef }, $item_bibnum, $itemnumber);
392 CanItemBeReserved
( $borrowernumbers[0], $itemnumber) eq 'tooManyReserves',
393 "cannot request item if policy that matches on bib-level item type forbids it (bug 9532)"
397 # Test branch item rules
399 $dbh->do('DELETE FROM issuingrules');
401 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
402 VALUES (?, ?, ?, ?)},
406 $dbh->do('DELETE FROM branch_item_rules');
407 $dbh->do('DELETE FROM default_branch_circ_rules');
408 $dbh->do('DELETE FROM default_branch_item_rules');
409 $dbh->do('DELETE FROM default_circ_rules');
411 INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
413 }, {}, $branch_1, 'CANNOT', 0, 'homebranch');
415 INSERT INTO branch_item_rules (branchcode, itemtype, holdallowed, returnbranch)
417 }, {}, $branch_1, 'CAN', 1, 'homebranch');
418 ($bibnum, $title, $bibitemnum) = create_helper_biblio
('CANNOT');
419 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem
(
420 { homebranch
=> $branch_1, holdingbranch
=> $branch_1, itype
=> 'CANNOT' } , $bibnum);
421 is
(CanItemBeReserved
($borrowernumbers[0], $itemnumber), 'notReservable',
422 "CanItemBeReserved should returns 'notReservable'");
424 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem
(
425 { homebranch
=> $branch_2, holdingbranch
=> $branch_1, itype
=> 'CAN' } , $bibnum);
426 is
(CanItemBeReserved
($borrowernumbers[0], $itemnumber),
427 'cannotReserveFromOtherBranches',
428 "CanItemBeReserved should returns 'cannotReserveFromOtherBranches'");
430 ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem
(
431 { homebranch
=> $branch_1, holdingbranch
=> $branch_1, itype
=> 'CAN' } , $bibnum);
432 is
(CanItemBeReserved
($borrowernumbers[0], $itemnumber), 'OK',
433 "CanItemBeReserved should returns 'OK'");
436 t
::lib
::Mocks
::mock_preference
( 'item-level_itypes', 1 );
437 t
::lib
::Mocks
::mock_preference
( 'ReservesControlBranch', 'PatronLibrary' );
439 $dbh->do('DELETE FROM reserves');
440 $dbh->do('DELETE FROM issues');
441 $dbh->do('DELETE FROM items');
442 $dbh->do('DELETE FROM biblio');
444 ( $bibnum, $title, $bibitemnum ) = create_helper_biblio
('ONLY1');
445 ( $item_bibnum, $item_bibitemnum, $itemnumber )
446 = AddItem
( { homebranch
=> $branch_1, holdingbranch
=> $branch_1 }, $bibnum );
449 q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed, holds_per_record)
450 VALUES (?, ?, ?, ?, ?)},
452 '*', '*', 'ONLY1', 1, 99
454 is
( CanItemBeReserved
( $borrowernumbers[0], $itemnumber ),
455 'OK', 'Patron can reserve item with hold limit of 1, no holds placed' );
457 my $res_id = AddReserve
( $branch_1, $borrowernumbers[0], $bibnum, '', 1, );
459 is
( CanItemBeReserved
( $borrowernumbers[0], $itemnumber ),
460 'tooManyReserves', 'Patron cannot reserve item with hold limit of 1, 1 bib level hold placed' );
463 # Helper method to set up a Biblio.
464 sub create_helper_biblio
{
465 my $itemtype = shift;
466 my $bib = MARC
::Record
->new();
467 my $title = 'Silence in the library';
469 MARC
::Field
->new('100', ' ', ' ', a
=> 'Moffat, Steven'),
470 MARC
::Field
->new('245', ' ', ' ', a
=> $title),
471 MARC
::Field
->new('942', ' ', ' ', c
=> $itemtype),
473 return ($bibnum, $title, $bibitemnum) = AddBiblio
($bib, '');