t/db_dependent/Members.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19
  20 use Test::More tests => 61;
  21 use Test::MockModule;
  22 use Data::Dumper;
  23 use C4::Context;
  24
  25 BEGIN {
  26         use_ok('C4::Members');
  27 }
  28
  29 my $dbh = C4::Context->dbh;
  30
  31 # Start transaction
  32 $dbh->{AutoCommit} = 0;
  33 $dbh->{RaiseError} = 1;
  34
  35 my $CARDNUMBER   = 'TESTCARD01';
  36 my $FIRSTNAME    = 'Marie';
  37 my $SURNAME      = 'Mcknight';
  38 my $CATEGORYCODE = 'S';
  39 my $BRANCHCODE   = 'CPL';
  40
  41 my $CHANGED_FIRSTNAME = "Marry Ann";
  42 my $EMAIL             = "Marie\@email.com";
  43 my $EMAILPRO          = "Marie\@work.com";
  44 my $ETHNICITY         = "German";
  45 my $PHONE             = "555-12123";
  46
  47 # XXX should be randomised and checked against the database
  48 my $IMPOSSIBLE_CARDNUMBER = "XYZZZ999";
  49
  50 # XXX make a non-commit transaction and rollback rather than insert/delete
  51
  52 #my ($usernum, $userid, $usercnum, $userfirstname, $usersurname, $userbranch, $branchname, $userflags, $emailaddress, $branchprinter)= @_;
  53 my @USERENV = (
  54     1,
  55     'test',
  56     'MASTERTEST',
  57     'Test',
  58     'Test',
  59     't',
  60     'Test',
  61     0,
  62 );
  63 my $BRANCH_IDX = 5;
  64
  65 C4::Context->_new_userenv ('DUMMY_SESSION_ID');
  66 C4::Context->set_userenv ( @USERENV );
  67
  68 my $userenv = C4::Context->userenv
  69   or BAIL_OUT("No userenv");
  70
  71 # Make a borrower for testing
  72 my %data = (
  73     cardnumber => $CARDNUMBER,
  74     firstname =>  $FIRSTNAME,
  75     surname => $SURNAME,
  76     categorycode => $CATEGORYCODE,
  77     branchcode => $BRANCHCODE,
  78     dateofbirth => '',
  79     dateexpiry => '9999-12-31',
  80     userid => 'tomasito'
  81 );
  82
  83 testAgeAccessors(\%data); #Age accessor tests don't touch the db so it is safe to run them with just the object.
  84
  85 my $addmem=AddMember(%data);
  86 ok($addmem, "AddMember()");
  87
  88 # It's not really a Move, it's a Copy.
  89 my $result = MoveMemberToDeleted($addmem);
  90 ok($result,"MoveMemberToDeleted()");
  91
  92 my $sth = $dbh->prepare("SELECT * from borrowers WHERE borrowernumber=?");
  93 $sth->execute($addmem);
  94 my $MemberAdded = $sth->fetchrow_hashref;
  95
  96 $sth = $dbh->prepare("SELECT * from deletedborrowers WHERE borrowernumber=?");
  97 $sth->execute($addmem);
  98 my $MemberMoved = $sth->fetchrow_hashref;
  99
 100 is_deeply($MemberMoved,$MemberAdded,"Confirm MoveMemberToDeleted.");
 101
 102 my $member=GetMemberDetails("",$CARDNUMBER)
 103   or BAIL_OUT("Cannot read member with card $CARDNUMBER");
 104
 105 ok ( $member->{firstname}    eq $FIRSTNAME    &&
 106      $member->{surname}      eq $SURNAME      &&
 107      $member->{categorycode} eq $CATEGORYCODE &&
 108      $member->{branchcode}   eq $BRANCHCODE
 109      , "Got member")
 110   or diag("Mismatching member details: ".Dumper(\%data, $member));
 111
 112 is($member->{dateofbirth}, undef, "Empty dates handled correctly");
 113
 114 $member->{firstname} = $CHANGED_FIRSTNAME;
 115 $member->{email}     = $EMAIL;
 116 $member->{ethnicity} = $ETHNICITY;
 117 $member->{phone}     = $PHONE;
 118 $member->{emailpro}  = $EMAILPRO;
 119 ModMember(%$member);
 120 my $changedmember=GetMemberDetails("",$CARDNUMBER);
 121 ok ( $changedmember->{firstname} eq $CHANGED_FIRSTNAME &&
 122      $changedmember->{email}     eq $EMAIL             &&
 123      $changedmember->{ethnicity} eq $ETHNICITY         &&
 124      $changedmember->{phone}     eq $PHONE             &&
 125      $changedmember->{emailpro}  eq $EMAILPRO
 126      , "Member Changed")
 127   or diag("Mismatching member details: ".Dumper($member, $changedmember));
 128
 129 C4::Context->set_preference( 'CardnumberLength', '' );
 130 C4::Context->clear_syspref_cache();
 131
 132 my $checkcardnum=C4::Members::checkcardnumber($CARDNUMBER, "");
 133 is ($checkcardnum, "1", "Card No. in use");
 134
 135 $checkcardnum=C4::Members::checkcardnumber($IMPOSSIBLE_CARDNUMBER, "");
 136 is ($checkcardnum, "0", "Card No. not used");
 137
 138 C4::Context->set_preference( 'CardnumberLength', '4' );
 139 C4::Context->clear_syspref_cache();
 140
 141 $checkcardnum=C4::Members::checkcardnumber($IMPOSSIBLE_CARDNUMBER, "");
 142 is ($checkcardnum, "2", "Card number is too long");
 143
 144
 145
 146 C4::Context->set_preference( 'AutoEmailPrimaryAddress', 'OFF' );
 147 C4::Context->clear_syspref_cache();
 148
 149 my $notice_email = GetNoticeEmailAddress($member->{'borrowernumber'});
 150 is ($notice_email, $EMAIL, "GetNoticeEmailAddress returns correct value when AutoEmailPrimaryAddress is off");
 151
 152 C4::Context->set_preference( 'AutoEmailPrimaryAddress', 'emailpro' );
 153 C4::Context->clear_syspref_cache();
 154
 155 $notice_email = GetNoticeEmailAddress($member->{'borrowernumber'});
 156 is ($notice_email, $EMAILPRO, "GetNoticeEmailAddress returns correct value when AutoEmailPrimaryAddress is emailpro");
 157
 158 ok(!$member->{is_expired}, "GetMemberDetails() indicates that patron is not expired");
 159 ModMember(borrowernumber => $member->{'borrowernumber'}, dateexpiry => '2001-01-1');
 160 $member = GetMemberDetails($member->{'borrowernumber'});
 161 ok($member->{is_expired}, "GetMemberDetails() indicates that patron is expired");
 162
 163
 164 my $message_type = 'B';
 165 my $message = 'my message';
 166 my $messages_count = GetMessagesCount($member->{borrowernumber}, $message_type, $BRANCHCODE);
 167 is( $messages_count, 0, 'GetMessagesCount returns the number of messages correclty' );
 168
 169 is( AddMessage(), undef, 'AddMessage without argument returns undef' );
 170 is( AddMessage(undef, $message_type, $message, $BRANCHCODE), undef,  'AddMessage without the borrower number returns undef' );
 171 is( AddMessage($member->{borrowernumber}, undef, $message, $BRANCHCODE), undef,  'AddMessage without the message type returns undef' );
 172 is( AddMessage($member->{borrowernumber}, $message_type, undef, $BRANCHCODE), undef,  'AddMessage without the message returns undef' );
 173 is( AddMessage($member->{borrowernumber}, $message_type, $message, undef), undef,  'AddMessage without the branch code returns undef' );
 174 is( AddMessage($member->{borrowernumber}, $message_type, $message, $BRANCHCODE), 1,  'AddMessage functions correctly' );
 175
 176 $messages_count = GetMessagesCount();
 177 is( $messages_count, 0, 'GetMessagesCount without argument returns 0' );
 178 $messages_count = GetMessagesCount(undef, $message_type, $BRANCHCODE);
 179 is( $messages_count, '0', 'GetMessagesCount without the borrower number returns the number of messages' );
 180 $messages_count = GetMessagesCount($member->{borrowernumber}, undef, $BRANCHCODE);
 181 is( $messages_count, '1', 'GetMessagesCount without the message type returns the total number of messages' );
 182 $messages_count = GetMessagesCount($member->{borrowernumber}, $message_type, undef);
 183 is( $messages_count, '1', 'GetMessagesCount without the branchcode returns the total number of messages' );
 184 $messages_count = GetMessagesCount($member->{borrowernumber}, $message_type, $BRANCHCODE);
 185 is( $messages_count, '1', 'GetMessagesCount returns the number of messages correctly' );
 186
 187 my $messages = GetMessages();
 188 is( @$messages, 0, 'GetMessages without argument returns 0' );
 189 $messages = GetMessages($member->{borrowernumber}, $message_type, $BRANCHCODE);
 190 is( @$messages, 1, 'GetMessages returns the correct number of messages' );
 191 is( $messages->[0]->{borrowernumber}, $member->{borrowernumber}, 'GetMessages returns the borrower number correctly' );
 192 is( $messages->[0]->{message_type}, $message_type, 'GetMessages returns the message type correclty' );
 193 is( $messages->[0]->{message}, $message, 'GetMessages returns the message correctly' );
 194 is( $messages->[0]->{branchcode}, $BRANCHCODE, 'GetMessages returns the branch code correctly' );
 195
 196 $messages_count = GetMessagesCount($member->{borrowernumber}, $message_type, $BRANCHCODE);
 197 is( $messages_count, 1, 'GetMessagesCount returns the number of messages correclty' );
 198
 199 DeleteMessage();
 200 $messages = GetMessages($member->{borrowernumber}, $message_type, $BRANCHCODE);
 201 is( @$messages, 1, 'DeleteMessage without message id does not delete messages' );
 202 DeleteMessage($messages->[0]->{message_id});
 203 $messages = GetMessages($member->{borrowernumber}, $message_type, $BRANCHCODE);
 204 is( @$messages, 0, 'DeleteMessage deletes a message correctly' );
 205
 206
 207 # clean up
 208 DelMember($member->{borrowernumber});
 209 my $borrower = GetMember( cardnumber => $CARDNUMBER );
 210 is( $borrower, undef, 'DelMember should remove the patron' );
 211
 212 # Check_Userid tests
 213 %data = (
 214     cardnumber   => "123456789",
 215     firstname    => "Tomasito",
 216     surname      => "None",
 217     categorycode => "S",
 218     branchcode   => "MPL",
 219     dateofbirth  => '',
 220     dateexpiry   => '9999-12-31',
 221 );
 222 # Add a new borrower
 223 my $borrowernumber = AddMember( %data );
 224 is( Check_Userid( 'tomasito.non', $borrowernumber ), 1,
 225     'recently created userid -> unique (borrowernumber passed)' );
 226 is( Check_Userid( 'tomasitoxxx', $borrowernumber ), 1,
 227     'non-existent userid -> unique (borrowernumber passed)' );
 228 is( Check_Userid( 'tomasito.none', '' ), 0,
 229     'userid exists (blank borrowernumber)' );
 230 is( Check_Userid( 'tomasitoxxx', '' ), 1,
 231     'non-existent userid -> unique (blank borrowernumber)' );
 232
 233 # Add a new borrower with the same userid but different cardnumber
 234 $data{ cardnumber } = "987654321";
 235 my $new_borrowernumber = AddMember( %data );
 236 is( Check_Userid( 'tomasito.none', '' ), 0,
 237     'userid not unique (blank borrowernumber)' );
 238 is( Check_Userid( 'tomasito.none', $new_borrowernumber ), 0,
 239     'userid not unique (second borrowernumber passed)' );
 240 $borrower = GetMember( borrowernumber => $new_borrowernumber );
 241 ok( $borrower->{userid} ne 'tomasito', "Borrower with duplicate userid has new userid generated" );
 242
 243 $data{ cardnumber } = "234567890";
 244 $data{userid} = 'a_user_id';
 245 $borrowernumber = AddMember( %data );
 246 $borrower = GetMember( borrowernumber => $borrowernumber );
 247 is( $borrower->{userid}, $data{userid}, 'AddMember should insert the given userid' );
 248
 249 # Regression tests for BZ13502
 250 ## Remove all entries with userid='' (should be only 1 max)
 251 $dbh->do(q|DELETE FROM borrowers WHERE userid = ''|);
 252 ## And create a patron with a userid=''
 253 $borrowernumber = AddMember( categorycode => 'S', branchcode => 'MPL' );
 254 $dbh->do(q|UPDATE borrowers SET userid = '' WHERE borrowernumber = ?|, undef, $borrowernumber);
 255 # Create another patron and verify the userid has been generated
 256 $borrowernumber = AddMember( categorycode => 'S', branchcode => 'MPL' );
 257 ok( $borrowernumber > 0, 'AddMember should have inserted the patron even if no userid is given' );
 258 $borrower = GetMember( borrowernumber => $borrowernumber );
 259 ok( $borrower->{userid},  'A userid should have been generated correctly' );
 260
 261 # Regression tests for BZ12226
 262 is( Check_Userid( C4::Context->config('user'), '' ), 0,
 263     'Check_Userid should return 0 for the DB user (Bug 12226)');
 264
 265 subtest 'GetMemberAccountBalance' => sub {
 266
 267     plan tests => 10;
 268
 269     my $members_mock = new Test::MockModule('C4::Members');
 270     $members_mock->mock( 'GetMemberAccountRecords', sub {
 271         my ($borrowernumber) = @_;
 272         if ($borrowernumber) {
 273             my @accountlines = (
 274             { amountoutstanding => '7', accounttype => 'Rent' },
 275             { amountoutstanding => '5', accounttype => 'Res' },
 276             { amountoutstanding => '3', accounttype => 'Pay' } );
 277             return ( 15, \@accountlines );
 278         }
 279         else {
 280             my @accountlines;
 281             return ( 0, \@accountlines );
 282         }
 283     });
 284
 285     my $person = GetMemberDetails(undef,undef);
 286     ok( !$person , 'Expected no member details from undef,undef' );
 287     $person = GetMemberDetails(undef,'987654321');
 288     is( $person->{amountoutstanding}, 15,
 289         'Expected 15 outstanding for cardnumber.');
 290     $borrowernumber = $person->{borrowernumber};
 291     $person = GetMemberDetails($borrowernumber,undef);
 292     is( $person->{amountoutstanding}, 15,
 293         'Expected 15 outstanding for borrowernumber.');
 294     $person = GetMemberDetails($borrowernumber,'987654321');
 295     is( $person->{amountoutstanding}, 15,
 296         'Expected 15 outstanding for both borrowernumber and cardnumber.');
 297
 298     # do not count holds charges
 299     C4::Context->set_preference( 'HoldsInNoissuesCharge', '1' );
 300     C4::Context->set_preference( 'ManInvInNoissuesCharge', '0' );
 301     my ($total, $total_minus_charges,
 302         $other_charges) = C4::Members::GetMemberAccountBalance(123);
 303     is( $total, 15 , "Total calculated correctly");
 304     is( $total_minus_charges, 15, "Holds charges are not count if HoldsInNoissuesCharge=1");
 305     is( $other_charges, 0, "Holds charges are not considered if HoldsInNoissuesCharge=1");
 306
 307     C4::Context->set_preference( 'HoldsInNoissuesCharge', '0' );
 308     ($total, $total_minus_charges,
 309         $other_charges) = C4::Members::GetMemberAccountBalance(123);
 310     is( $total, 15 , "Total calculated correctly");
 311     is( $total_minus_charges, 10, "Holds charges are count if HoldsInNoissuesCharge=0");
 312     is( $other_charges, 5, "Holds charges are considered if HoldsInNoissuesCharge=1");
 313
 314     $dbh->rollback();
 315 };
 316
 317 sub _find_member {
 318     my ($resultset) = @_;
 319     my $found = $resultset && grep( { $_->{cardnumber} && $_->{cardnumber} eq $CARDNUMBER } @$resultset );
 320     return $found;
 321 }
 322
 323 ### ------------------------------------- ###
 324 ### Testing GetAge() / SetAge() functions ###
 325 ### ------------------------------------- ###
 326 #USES the package $member-variable to mock a koha.borrowers-object
 327 sub testAgeAccessors {
 328     my ($member) = @_;
 329     my $original_dateofbirth = $member->{dateofbirth};
 330
 331     ##Testing GetAge()
 332     my $age=GetAge("1992-08-14", "2011-01-19");
 333     is ($age, "18", "Age correct");
 334
 335     $age=GetAge("2011-01-19", "1992-01-19");
 336     is ($age, "-19", "Birthday In the Future");
 337
 338     ##Testing SetAge() for now()
 339     my $dt_now = DateTime->now();
 340     $age = DateTime::Duration->new(years => 12, months => 6, days => 1);
 341     C4::Members::SetAge( $member, $age );
 342     $age = C4::Members::GetAge( $member->{dateofbirth} );
 343     is ($age, '12', "SetAge 12 years");
 344
 345     $age = DateTime::Duration->new(years => 18, months => 12, days => 31);
 346     C4::Members::SetAge( $member, $age );
 347     $age = C4::Members::GetAge( $member->{dateofbirth} );
 348     is ($age, '19', "SetAge 18+1 years"); #This is a special case, where months=>12 and days=>31 constitute one full year, hence we get age 19 instead of 18.
 349
 350     $age = DateTime::Duration->new(years => 18, months => 12, days => 30);
 351     C4::Members::SetAge( $member, $age );
 352     $age = C4::Members::GetAge( $member->{dateofbirth} );
 353     is ($age, '19', "SetAge 18 years");
 354
 355     $age = DateTime::Duration->new(years => 0, months => 1, days => 1);
 356     C4::Members::SetAge( $member, $age );
 357     $age = C4::Members::GetAge( $member->{dateofbirth} );
 358     is ($age, '0', "SetAge 0 years");
 359
 360     $age = '0018-12-31';
 361     C4::Members::SetAge( $member, $age );
 362     $age = C4::Members::GetAge( $member->{dateofbirth} );
 363     is ($age, '19', "SetAge ISO_Date 18+1 years"); #This is a special case, where months=>12 and days=>31 constitute one full year, hence we get age 19 instead of 18.
 364
 365     $age = '0018-12-30';
 366     C4::Members::SetAge( $member, $age );
 367     $age = C4::Members::GetAge( $member->{dateofbirth} );
 368     is ($age, '19', "SetAge ISO_Date 18 years");
 369
 370     $age = '18-1-1';
 371     eval { C4::Members::SetAge( $member, $age ); };
 372     is ((length $@ > 1), '1', "SetAge ISO_Date $age years FAILS");
 373
 374     $age = '0018-01-01';
 375     eval { C4::Members::SetAge( $member, $age ); };
 376     is ((length $@ == 0), '1', "SetAge ISO_Date $age years succeeds");
 377
 378     ##Testing SetAge() for relative_date
 379     my $relative_date = DateTime->new(year => 3010, month => 3, day => 15);
 380
 381     $age = DateTime::Duration->new(years => 10, months => 3);
 382     C4::Members::SetAge( $member, $age, $relative_date );
 383     $age = C4::Members::GetAge( $member->{dateofbirth}, $relative_date->ymd() );
 384     is ($age, '10', "SetAge, 10 years and 3 months old person was born on ".$member->{dateofbirth}." if todays is ".$relative_date->ymd());
 385
 386     $age = DateTime::Duration->new(years => 112, months => 1, days => 1);
 387     C4::Members::SetAge( $member, $age, $relative_date );
 388     $age = C4::Members::GetAge( $member->{dateofbirth}, $relative_date->ymd() );
 389     is ($age, '112', "SetAge, 112 years, 1 months and 1 days old person was born on ".$member->{dateofbirth}." if today is ".$relative_date->ymd());
 390
 391     $age = '0112-01-01';
 392     C4::Members::SetAge( $member, $age, $relative_date );
 393     $age = C4::Members::GetAge( $member->{dateofbirth}, $relative_date->ymd() );
 394     is ($age, '112', "SetAge ISO_Date, 112 years, 1 months and 1 days old person was born on ".$member->{dateofbirth}." if today is ".$relative_date->ymd());
 395
 396     $member->{dateofbirth} = $original_dateofbirth; #It is polite to revert made changes in the unit tests.
 397 } #sub testAgeAccessors
 398
 399 1;