t/db_dependent/Circulation.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19
  20 use DateTime;
  21 use C4::Biblio;
  22 use C4::Branch;
  23 use C4::Items;
  24 use C4::Members;
  25 use C4::Reserves;
  26 use C4::Overdues qw(UpdateFine);
  27 use Koha::DateUtils;
  28 use Koha::Database;
  29
  30 use Test::More tests => 61;
  31
  32 BEGIN {
  33     use_ok('C4::Circulation');
  34 }
  35
  36 my $dbh = C4::Context->dbh;
  37 my $schema = Koha::Database->new()->schema();
  38
  39 # Start transaction
  40 $dbh->{AutoCommit} = 0;
  41 $dbh->{RaiseError} = 1;
  42
  43 # Start with a clean slate
  44 $dbh->do('DELETE FROM issues');
  45
  46 my $CircControl = C4::Context->preference('CircControl');
  47 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
  48
  49 my $item = {
  50     homebranch => 'MPL',
  51     holdingbranch => 'MPL'
  52 };
  53
  54 my $borrower = {
  55     branchcode => 'MPL'
  56 };
  57
  58 # No userenv, PickupLibrary
  59 C4::Context->set_preference('CircControl', 'PickupLibrary');
  60 is(
  61     C4::Context->preference('CircControl'),
  62     'PickupLibrary',
  63     'CircControl changed to PickupLibrary'
  64 );
  65 is(
  66     C4::Circulation::_GetCircControlBranch($item, $borrower),
  67     $item->{$HomeOrHoldingBranch},
  68     '_GetCircControlBranch returned item branch (no userenv defined)'
  69 );
  70
  71 # No userenv, PatronLibrary
  72 C4::Context->set_preference('CircControl', 'PatronLibrary');
  73 is(
  74     C4::Context->preference('CircControl'),
  75     'PatronLibrary',
  76     'CircControl changed to PatronLibrary'
  77 );
  78 is(
  79     C4::Circulation::_GetCircControlBranch($item, $borrower),
  80     $borrower->{branchcode},
  81     '_GetCircControlBranch returned borrower branch'
  82 );
  83
  84 # No userenv, ItemHomeLibrary
  85 C4::Context->set_preference('CircControl', 'ItemHomeLibrary');
  86 is(
  87     C4::Context->preference('CircControl'),
  88     'ItemHomeLibrary',
  89     'CircControl changed to ItemHomeLibrary'
  90 );
  91 is(
  92     $item->{$HomeOrHoldingBranch},
  93     C4::Circulation::_GetCircControlBranch($item, $borrower),
  94     '_GetCircControlBranch returned item branch'
  95 );
  96
  97 # Now, set a userenv
  98 C4::Context->_new_userenv('xxx');
  99 C4::Context->set_userenv(0,0,0,'firstname','surname', 'MPL', 'Midway Public Library', '', '', '');
 100 is(C4::Context->userenv->{branch}, 'MPL', 'userenv set');
 101
 102 # Userenv set, PickupLibrary
 103 C4::Context->set_preference('CircControl', 'PickupLibrary');
 104 is(
 105     C4::Context->preference('CircControl'),
 106     'PickupLibrary',
 107     'CircControl changed to PickupLibrary'
 108 );
 109 is(
 110     C4::Circulation::_GetCircControlBranch($item, $borrower),
 111     'MPL',
 112     '_GetCircControlBranch returned current branch'
 113 );
 114
 115 # Userenv set, PatronLibrary
 116 C4::Context->set_preference('CircControl', 'PatronLibrary');
 117 is(
 118     C4::Context->preference('CircControl'),
 119     'PatronLibrary',
 120     'CircControl changed to PatronLibrary'
 121 );
 122 is(
 123     C4::Circulation::_GetCircControlBranch($item, $borrower),
 124     $borrower->{branchcode},
 125     '_GetCircControlBranch returned borrower branch'
 126 );
 127
 128 # Userenv set, ItemHomeLibrary
 129 C4::Context->set_preference('CircControl', 'ItemHomeLibrary');
 130 is(
 131     C4::Context->preference('CircControl'),
 132     'ItemHomeLibrary',
 133     'CircControl changed to ItemHomeLibrary'
 134 );
 135 is(
 136     C4::Circulation::_GetCircControlBranch($item, $borrower),
 137     $item->{$HomeOrHoldingBranch},
 138     '_GetCircControlBranch returned item branch'
 139 );
 140
 141 # Reset initial configuration
 142 C4::Context->set_preference('CircControl', $CircControl);
 143 is(
 144     C4::Context->preference('CircControl'),
 145     $CircControl,
 146     'CircControl reset to its initial value'
 147 );
 148
 149 # Set a simple circ policy
 150 $dbh->do('DELETE FROM issuingrules');
 151 $dbh->do(
 152     q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
 153                                 maxissueqty, issuelength, lengthunit,
 154                                 renewalsallowed, renewalperiod,
 155                                 norenewalbefore, auto_renew,
 156                                 fine, chargeperiod)
 157       VALUES (?, ?, ?, ?,
 158               ?, ?, ?,
 159               ?, ?,
 160               ?, ?,
 161               ?, ?
 162              )
 163     },
 164     {},
 165     '*', '*', '*', 25,
 166     20, 14, 'days',
 167     1, 7,
 168     '', 0,
 169     .10, 1
 170 );
 171
 172 # Test C4::Circulation::ProcessOfflinePayment
 173 my $sth = C4::Context->dbh->prepare("SELECT COUNT(*) FROM accountlines WHERE amount = '-123.45' AND accounttype = 'Pay'");
 174 $sth->execute();
 175 my ( $original_count ) = $sth->fetchrow_array();
 176
 177 C4::Context->dbh->do("INSERT INTO borrowers ( cardnumber, surname, firstname, categorycode, branchcode ) VALUES ( '99999999999', 'Hall', 'Kyle', 'S', 'MPL' )");
 178
 179 C4::Circulation::ProcessOfflinePayment({ cardnumber => '99999999999', amount => '123.45' });
 180
 181 $sth->execute();
 182 my ( $new_count ) = $sth->fetchrow_array();
 183
 184 ok( $new_count == $original_count  + 1, 'ProcessOfflinePayment makes payment correctly' );
 185
 186 C4::Context->dbh->do("DELETE FROM accountlines WHERE borrowernumber IN ( SELECT borrowernumber FROM borrowers WHERE cardnumber = '99999999999' )");
 187 C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'");
 188 C4::Context->dbh->do("DELETE FROM accountlines");
 189 {
 190 # CanBookBeRenewed tests
 191
 192     # Generate test biblio
 193     my $biblio = MARC::Record->new();
 194     my $title = 'Silence in the library';
 195     $biblio->append_fields(
 196         MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
 197         MARC::Field->new('245', ' ', ' ', a => $title),
 198     );
 199
 200     my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
 201
 202     my $barcode = 'R00000342';
 203     my $branch = 'MPL';
 204
 205     my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
 206         {
 207             homebranch       => $branch,
 208             holdingbranch    => $branch,
 209             barcode          => $barcode,
 210             replacementprice => 12.00
 211         },
 212         $biblionumber
 213     );
 214
 215     my $barcode2 = 'R00000343';
 216     my ( $item_bibnum2, $item_bibitemnum2, $itemnumber2 ) = AddItem(
 217         {
 218             homebranch       => $branch,
 219             holdingbranch    => $branch,
 220             barcode          => $barcode2,
 221             replacementprice => 23.00
 222         },
 223         $biblionumber
 224     );
 225
 226     my $barcode3 = 'R00000346';
 227     my ( $item_bibnum3, $item_bibitemnum3, $itemnumber3 ) = AddItem(
 228         {
 229             homebranch       => $branch,
 230             holdingbranch    => $branch,
 231             barcode          => $barcode3,
 232             replacementprice => 23.00
 233         },
 234         $biblionumber
 235     );
 236
 237     # Create borrowers
 238     my %renewing_borrower_data = (
 239         firstname =>  'John',
 240         surname => 'Renewal',
 241         categorycode => 'S',
 242         branchcode => $branch,
 243     );
 244
 245     my %reserving_borrower_data = (
 246         firstname =>  'Katrin',
 247         surname => 'Reservation',
 248         categorycode => 'S',
 249         branchcode => $branch,
 250     );
 251
 252     my %hold_waiting_borrower_data = (
 253         firstname =>  'Kyle',
 254         surname => 'Reservation',
 255         categorycode => 'S',
 256         branchcode => $branch,
 257     );
 258
 259     my $renewing_borrowernumber = AddMember(%renewing_borrower_data);
 260     my $reserving_borrowernumber = AddMember(%reserving_borrower_data);
 261     my $hold_waiting_borrowernumber = AddMember(%hold_waiting_borrower_data);
 262
 263     my $renewing_borrower = GetMember( borrowernumber => $renewing_borrowernumber );
 264
 265     my $constraint     = 'a';
 266     my $bibitems       = '';
 267     my $priority       = '1';
 268     my $resdate        = undef;
 269     my $expdate        = undef;
 270     my $notes          = '';
 271     my $checkitem      = undef;
 272     my $found          = undef;
 273
 274     my $issue = AddIssue( $renewing_borrower, $barcode);
 275     my $datedue = dt_from_string( $issue->date_due() );
 276     is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
 277
 278     my $issue2 = AddIssue( $renewing_borrower, $barcode2);
 279     $datedue = dt_from_string( $issue->date_due() );
 280     is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
 281
 282     my $borrowing_borrowernumber = GetItemIssue($itemnumber)->{borrowernumber};
 283     is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
 284
 285     my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
 286     is( $renewokay, 1, 'Can renew, no holds for this title or item');
 287
 288
 289     # Biblio-level hold, renewal test
 290     AddReserve(
 291         $branch, $reserving_borrowernumber, $biblionumber,
 292         $constraint, $bibitems,  $priority, $resdate, $expdate, $notes,
 293         $title, $checkitem, $found
 294     );
 295
 296     # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
 297     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
 298     C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 1 );
 299     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 300     is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 301     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
 302     is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 303
 304     # Now let's add an item level hold, we should no longer be able to renew the item
 305     my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
 306         {
 307             borrowernumber => $hold_waiting_borrowernumber,
 308             biblionumber   => $biblionumber,
 309             itemnumber     => $itemnumber,
 310             branchcode     => $branch,
 311             priority       => 3,
 312         }
 313     );
 314     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 315     is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
 316     $hold->delete();
 317
 318     # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
 319     # be able to renew these items
 320     $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
 321         {
 322             borrowernumber => $hold_waiting_borrowernumber,
 323             biblionumber   => $biblionumber,
 324             itemnumber     => $itemnumber3,
 325             branchcode     => $branch,
 326             priority       => 0,
 327             found          => 'W'
 328         }
 329     );
 330     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 331     is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 332     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
 333     is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 334     C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 0 );
 335
 336     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 337     is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
 338     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
 339
 340     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
 341     is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
 342     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
 343
 344     my $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber});
 345     my $reserving_borrower = GetMember( borrowernumber => $reserving_borrowernumber );
 346     AddIssue($reserving_borrower, $barcode3);
 347     my $reserve = $dbh->selectrow_hashref(
 348         'SELECT * FROM old_reserves WHERE reserve_id = ?',
 349         { Slice => {} },
 350         $reserveid
 351     );
 352     is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
 353
 354     # Item-level hold, renewal test
 355     AddReserve(
 356         $branch, $reserving_borrowernumber, $biblionumber,
 357         $constraint, $bibitems,  $priority, $resdate, $expdate, $notes,
 358         $title, $itemnumber, $found
 359     );
 360
 361     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
 362     is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
 363     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
 364
 365     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2, 1);
 366     is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
 367
 368
 369     # Items can't fill hold for reasons
 370     ModItem({ notforloan => 1 }, $biblionumber, $itemnumber);
 371     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
 372     is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
 373     ModItem({ notforloan => 0, itype => '' }, $biblionumber, $itemnumber,1);
 374
 375     # FIXME: Add more for itemtype not for loan etc.
 376
 377     $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, itemnumber => $itemnumber, borrowernumber => $reserving_borrowernumber});
 378     CancelReserve({ reserve_id => $reserveid });
 379
 380     # Test automatic renewal before value for "norenewalbefore" in policy is set
 381     my $barcode4 = '11235813';
 382     my ( $item_bibnum4, $item_bibitemnum4, $itemnumber4 ) = AddItem(
 383         {
 384             homebranch       => $branch,
 385             holdingbranch    => $branch,
 386             barcode          => $barcode4,
 387             replacementprice => 16.00
 388         },
 389         $biblionumber
 390     );
 391
 392     AddIssue( $renewing_borrower, $barcode4, undef, undef, undef, undef, { auto_renew => 1 } );
 393     ( $renewokay, $error ) =
 394       CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
 395     is( $renewokay, 0, 'Cannot renew, renewal is automatic' );
 396     is( $error, 'auto_renew',
 397         'Cannot renew, renewal is automatic (returned code is auto_renew)' );
 398
 399     # set policy to require that loans cannot be
 400     # renewed until seven days prior to the due date
 401     $dbh->do('UPDATE issuingrules SET norenewalbefore = 7');
 402     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 403     is( $renewokay, 0, 'Cannot renew, renewal is premature');
 404     is( $error, 'too_soon', 'Cannot renew, renewal is premature (returned code is too_soon)');
 405     is(
 406         GetSoonestRenewDate($renewing_borrowernumber, $itemnumber),
 407         $datedue->clone->add(days => -7),
 408         'renewals permitted 7 days before due date, as expected',
 409     );
 410
 411     # Test automatic renewal again
 412     ( $renewokay, $error ) =
 413       CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
 414     is( $renewokay, 0, 'Cannot renew, renewal is automatic and premature' );
 415     is( $error, 'auto_too_soon',
 416 'Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
 417     );
 418
 419     # Too many renewals
 420
 421     # set policy to forbid renewals
 422     $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
 423
 424     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 425     is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
 426     is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
 427
 428     # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
 429     C4::Context->set_preference('WhenLostForgiveFine','1');
 430     C4::Context->set_preference('WhenLostChargeReplacementFee','1');
 431
 432     C4::Overdues::UpdateFine( $itemnumber, $renewing_borrower->{borrowernumber},
 433         15.00, q{}, Koha::DateUtils::output_pref($datedue) );
 434
 435     LostItem( $itemnumber, 1 );
 436
 437     my $item = $schema->resultset('Item')->find( $itemnumber );
 438     ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
 439
 440     my $total_due = $dbh->selectrow_array(
 441         'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
 442         undef, $renewing_borrower->{borrowernumber}
 443     );
 444
 445     ok( $total_due == 12, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
 446
 447     C4::Context->dbh->do("DELETE FROM accountlines");
 448
 449     C4::Context->set_preference('WhenLostForgiveFine','0');
 450     C4::Context->set_preference('WhenLostChargeReplacementFee','0');
 451
 452     C4::Overdues::UpdateFine( $itemnumber2, $renewing_borrower->{borrowernumber},
 453         15.00, q{}, Koha::DateUtils::output_pref($datedue) );
 454
 455     LostItem( $itemnumber2, 0 );
 456
 457     my $item2 = $schema->resultset('Item')->find( $itemnumber2 );
 458     ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
 459
 460     $total_due = $dbh->selectrow_array(
 461         'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
 462         undef, $renewing_borrower->{borrowernumber}
 463     );
 464
 465     ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
 466
 467     my $now = dt_from_string();
 468     my $future = dt_from_string();
 469     $future->add( days => 7 );
 470     my $units = C4::Overdues::get_chargeable_units('days', $future, $now, 'MPL');
 471     ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
 472 }
 473
 474 {
 475     # GetUpcomingDueIssues tests
 476     my $barcode  = 'R00000342';
 477     my $barcode2 = 'R00000343';
 478     my $barcode3 = 'R00000344';
 479     my $branch   = 'MPL';
 480
 481     #Create another record
 482     my $biblio2 = MARC::Record->new();
 483     my $title2 = 'Something is worng here';
 484     $biblio2->append_fields(
 485         MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
 486         MARC::Field->new('245', ' ', ' ', a => $title2),
 487     );
 488     my ($biblionumber2, $biblioitemnumber2) = AddBiblio($biblio2, '');
 489
 490     #Create third item
 491     AddItem(
 492         {
 493             homebranch       => $branch,
 494             holdingbranch    => $branch,
 495             barcode          => $barcode3
 496         },
 497         $biblionumber2
 498     );
 499
 500     # Create a borrower
 501     my %a_borrower_data = (
 502         firstname =>  'Fridolyn',
 503         surname => 'SOMERS',
 504         categorycode => 'S',
 505         branchcode => $branch,
 506     );
 507
 508     my $a_borrower_borrowernumber = AddMember(%a_borrower_data);
 509     my $a_borrower = GetMember( borrowernumber => $a_borrower_borrowernumber );
 510
 511     my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
 512     my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
 513     my $today = DateTime->today(time_zone => C4::Context->tz());
 514
 515     my $issue = AddIssue( $a_borrower, $barcode, $yesterday );
 516     my $datedue = dt_from_string( $issue->date_due() );
 517     my $issue2 = AddIssue( $a_borrower, $barcode2, $two_days_ahead );
 518     my $datedue2 = dt_from_string( $issue->date_due() );
 519
 520     my $upcoming_dues;
 521
 522     # GetUpcomingDueIssues tests
 523     for my $i(0..1) {
 524         $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
 525         is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
 526     }
 527
 528     #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
 529     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
 530     is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
 531
 532     for my $i(3..5) {
 533         $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
 534         is ( scalar( @$upcoming_dues ), 1,
 535             "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
 536     }
 537
 538     # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
 539
 540     my $issue3 = AddIssue( $a_borrower, $barcode3, $today );
 541
 542     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
 543     is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
 544
 545     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
 546     is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
 547
 548     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
 549     is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
 550
 551     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 }  );
 552     is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
 553
 554     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
 555     is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
 556
 557     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
 558     is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
 559
 560 }
 561
 562 {
 563     my $barcode  = '1234567890';
 564     my $branch   = 'MPL';
 565
 566     my $biblio = MARC::Record->new();
 567     my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
 568
 569     #Create third item
 570     my ( undef, undef, $itemnumber ) = AddItem(
 571         {
 572             homebranch       => $branch,
 573             holdingbranch    => $branch,
 574             barcode          => $barcode
 575         },
 576         $biblionumber
 577     );
 578
 579     # Create a borrower
 580     my %a_borrower_data = (
 581         firstname =>  'Kyle',
 582         surname => 'Hall',
 583         categorycode => 'S',
 584         branchcode => $branch,
 585     );
 586
 587     my $borrowernumber = AddMember(%a_borrower_data);
 588
 589     UpdateFine( $itemnumber, $borrowernumber, 0 );
 590
 591     my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $itemnumber );
 592     my $count = $hr->{count};
 593
 594     is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
 595 }
 596
 597 $dbh->rollback;
 598
 599 1;