t/db_dependent/Circulation.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19
  20 use DateTime;
  21 use t::lib::Mocks;
  22 use C4::Biblio;
  23 use C4::Branch;
  24 use C4::Items;
  25 use C4::Members;
  26 use C4::Reserves;
  27 use C4::Overdues qw(UpdateFine CalcFine);
  28 use Koha::DateUtils;
  29 use Koha::Database;
  30
  31 use t::lib::TestBuilder;
  32
  33 use Test::More tests => 87;
  34
  35 BEGIN {
  36     use_ok('C4::Circulation');
  37 }
  38
  39 my $schema = Koha::Database->schema;
  40 $schema->storage->txn_begin;
  41 my $builder = t::lib::TestBuilder->new;
  42 my $dbh = C4::Context->dbh;
  43
  44 # Start transaction
  45 $dbh->{RaiseError} = 1;
  46
  47 # Start with a clean slate
  48 $dbh->do('DELETE FROM issues');
  49
  50 my $library = $builder->build({
  51     source => 'Branch',
  52 });
  53 my $library2 = $builder->build({
  54     source => 'Branch',
  55 });
  56 my $itemtype = $builder->build(
  57     {   source => 'Itemtype',
  58         value  => { notforloan => undef, rentalcharge => 0 }
  59     }
  60 )->{itemtype};
  61
  62 my $CircControl = C4::Context->preference('CircControl');
  63 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
  64
  65 my $item = {
  66     homebranch => $library2->{branchcode},
  67     holdingbranch => $library2->{branchcode}
  68 };
  69
  70 my $borrower = {
  71     branchcode => $library2->{branchcode}
  72 };
  73
  74 # No userenv, PickupLibrary
  75 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
  76 is(
  77     C4::Context->preference('CircControl'),
  78     'PickupLibrary',
  79     'CircControl changed to PickupLibrary'
  80 );
  81 is(
  82     C4::Circulation::_GetCircControlBranch($item, $borrower),
  83     $item->{$HomeOrHoldingBranch},
  84     '_GetCircControlBranch returned item branch (no userenv defined)'
  85 );
  86
  87 # No userenv, PatronLibrary
  88 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
  89 is(
  90     C4::Context->preference('CircControl'),
  91     'PatronLibrary',
  92     'CircControl changed to PatronLibrary'
  93 );
  94 is(
  95     C4::Circulation::_GetCircControlBranch($item, $borrower),
  96     $borrower->{branchcode},
  97     '_GetCircControlBranch returned borrower branch'
  98 );
  99
 100 # No userenv, ItemHomeLibrary
 101 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
 102 is(
 103     C4::Context->preference('CircControl'),
 104     'ItemHomeLibrary',
 105     'CircControl changed to ItemHomeLibrary'
 106 );
 107 is(
 108     $item->{$HomeOrHoldingBranch},
 109     C4::Circulation::_GetCircControlBranch($item, $borrower),
 110     '_GetCircControlBranch returned item branch'
 111 );
 112
 113 # Now, set a userenv
 114 C4::Context->_new_userenv('xxx');
 115 C4::Context->set_userenv(0,0,0,'firstname','surname', $library2->{branchcode}, 'Midway Public Library', '', '', '');
 116 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
 117
 118 # Userenv set, PickupLibrary
 119 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
 120 is(
 121     C4::Context->preference('CircControl'),
 122     'PickupLibrary',
 123     'CircControl changed to PickupLibrary'
 124 );
 125 is(
 126     C4::Circulation::_GetCircControlBranch($item, $borrower),
 127     $library2->{branchcode},
 128     '_GetCircControlBranch returned current branch'
 129 );
 130
 131 # Userenv set, PatronLibrary
 132 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
 133 is(
 134     C4::Context->preference('CircControl'),
 135     'PatronLibrary',
 136     'CircControl changed to PatronLibrary'
 137 );
 138 is(
 139     C4::Circulation::_GetCircControlBranch($item, $borrower),
 140     $borrower->{branchcode},
 141     '_GetCircControlBranch returned borrower branch'
 142 );
 143
 144 # Userenv set, ItemHomeLibrary
 145 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
 146 is(
 147     C4::Context->preference('CircControl'),
 148     'ItemHomeLibrary',
 149     'CircControl changed to ItemHomeLibrary'
 150 );
 151 is(
 152     C4::Circulation::_GetCircControlBranch($item, $borrower),
 153     $item->{$HomeOrHoldingBranch},
 154     '_GetCircControlBranch returned item branch'
 155 );
 156
 157 # Reset initial configuration
 158 t::lib::Mocks::mock_preference('CircControl', $CircControl);
 159 is(
 160     C4::Context->preference('CircControl'),
 161     $CircControl,
 162     'CircControl reset to its initial value'
 163 );
 164
 165 # Set a simple circ policy
 166 $dbh->do('DELETE FROM issuingrules');
 167 $dbh->do(
 168     q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
 169                                 maxissueqty, issuelength, lengthunit,
 170                                 renewalsallowed, renewalperiod,
 171                                 norenewalbefore, auto_renew,
 172                                 fine, chargeperiod)
 173       VALUES (?, ?, ?, ?,
 174               ?, ?, ?,
 175               ?, ?,
 176               ?, ?,
 177               ?, ?
 178              )
 179     },
 180     {},
 181     '*', '*', '*', 25,
 182     20, 14, 'days',
 183     1, 7,
 184     undef, 0,
 185     .10, 1
 186 );
 187
 188 # Test C4::Circulation::ProcessOfflinePayment
 189 my $sth = C4::Context->dbh->prepare("SELECT COUNT(*) FROM accountlines WHERE amount = '-123.45' AND accounttype = 'Pay'");
 190 $sth->execute();
 191 my ( $original_count ) = $sth->fetchrow_array();
 192
 193 C4::Context->dbh->do("INSERT INTO borrowers ( cardnumber, surname, firstname, categorycode, branchcode ) VALUES ( '99999999999', 'Hall', 'Kyle', 'S', ? )", undef, $library2->{branchcode} );
 194
 195 C4::Circulation::ProcessOfflinePayment({ cardnumber => '99999999999', amount => '123.45' });
 196
 197 $sth->execute();
 198 my ( $new_count ) = $sth->fetchrow_array();
 199
 200 ok( $new_count == $original_count  + 1, 'ProcessOfflinePayment makes payment correctly' );
 201
 202 C4::Context->dbh->do("DELETE FROM accountlines WHERE borrowernumber IN ( SELECT borrowernumber FROM borrowers WHERE cardnumber = '99999999999' )");
 203 C4::Context->dbh->do("DELETE FROM borrowers WHERE cardnumber = '99999999999'");
 204 C4::Context->dbh->do("DELETE FROM accountlines");
 205 {
 206 # CanBookBeRenewed tests
 207
 208     # Generate test biblio
 209     my $biblio = MARC::Record->new();
 210     my $title = 'Silence in the library';
 211     $biblio->append_fields(
 212         MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
 213         MARC::Field->new('245', ' ', ' ', a => $title),
 214     );
 215
 216     my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
 217
 218     my $barcode = 'R00000342';
 219     my $branch = $library2->{branchcode};
 220
 221     my ( $item_bibnum, $item_bibitemnum, $itemnumber ) = AddItem(
 222         {
 223             homebranch       => $branch,
 224             holdingbranch    => $branch,
 225             barcode          => $barcode,
 226             replacementprice => 12.00,
 227             itype            => $itemtype
 228         },
 229         $biblionumber
 230     );
 231
 232     my $barcode2 = 'R00000343';
 233     my ( $item_bibnum2, $item_bibitemnum2, $itemnumber2 ) = AddItem(
 234         {
 235             homebranch       => $branch,
 236             holdingbranch    => $branch,
 237             barcode          => $barcode2,
 238             replacementprice => 23.00,
 239             itype            => $itemtype
 240         },
 241         $biblionumber
 242     );
 243
 244     my $barcode3 = 'R00000346';
 245     my ( $item_bibnum3, $item_bibitemnum3, $itemnumber3 ) = AddItem(
 246         {
 247             homebranch       => $branch,
 248             holdingbranch    => $branch,
 249             barcode          => $barcode3,
 250             replacementprice => 23.00,
 251             itype            => $itemtype
 252         },
 253         $biblionumber
 254     );
 255
 256
 257
 258
 259     # Create borrowers
 260     my %renewing_borrower_data = (
 261         firstname =>  'John',
 262         surname => 'Renewal',
 263         categorycode => 'S',
 264         branchcode => $branch,
 265     );
 266
 267     my %reserving_borrower_data = (
 268         firstname =>  'Katrin',
 269         surname => 'Reservation',
 270         categorycode => 'S',
 271         branchcode => $branch,
 272     );
 273
 274     my %hold_waiting_borrower_data = (
 275         firstname =>  'Kyle',
 276         surname => 'Reservation',
 277         categorycode => 'S',
 278         branchcode => $branch,
 279     );
 280
 281     my %restricted_borrower_data = (
 282         firstname =>  'Alice',
 283         surname => 'Reservation',
 284         categorycode => 'S',
 285         debarred => '3228-01-01',
 286         branchcode => $branch,
 287     );
 288
 289     my $renewing_borrowernumber = AddMember(%renewing_borrower_data);
 290     my $reserving_borrowernumber = AddMember(%reserving_borrower_data);
 291     my $hold_waiting_borrowernumber = AddMember(%hold_waiting_borrower_data);
 292     my $restricted_borrowernumber = AddMember(%restricted_borrower_data);
 293
 294     my $renewing_borrower = GetMember( borrowernumber => $renewing_borrowernumber );
 295     my $restricted_borrower = GetMember( borrowernumber => $restricted_borrowernumber );
 296
 297     my $bibitems       = '';
 298     my $priority       = '1';
 299     my $resdate        = undef;
 300     my $expdate        = undef;
 301     my $notes          = '';
 302     my $checkitem      = undef;
 303     my $found          = undef;
 304
 305     my $issue = AddIssue( $renewing_borrower, $barcode);
 306     my $datedue = dt_from_string( $issue->date_due() );
 307     is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
 308
 309     my $issue2 = AddIssue( $renewing_borrower, $barcode2);
 310     $datedue = dt_from_string( $issue->date_due() );
 311     is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
 312
 313
 314     my $borrowing_borrowernumber = GetItemIssue($itemnumber)->{borrowernumber};
 315     is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
 316
 317     my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
 318     is( $renewokay, 1, 'Can renew, no holds for this title or item');
 319
 320
 321     # Biblio-level hold, renewal test
 322     AddReserve(
 323         $branch, $reserving_borrowernumber, $biblionumber,
 324         $bibitems,  $priority, $resdate, $expdate, $notes,
 325         $title, $checkitem, $found
 326     );
 327
 328     # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
 329     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
 330     t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
 331     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 332     is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 333     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
 334     is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 335
 336     # Now let's add an item level hold, we should no longer be able to renew the item
 337     my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
 338         {
 339             borrowernumber => $hold_waiting_borrowernumber,
 340             biblionumber   => $biblionumber,
 341             itemnumber     => $itemnumber,
 342             branchcode     => $branch,
 343             priority       => 3,
 344         }
 345     );
 346     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 347     is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
 348     $hold->delete();
 349
 350     # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
 351     # be able to renew these items
 352     $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
 353         {
 354             borrowernumber => $hold_waiting_borrowernumber,
 355             biblionumber   => $biblionumber,
 356             itemnumber     => $itemnumber3,
 357             branchcode     => $branch,
 358             priority       => 0,
 359             found          => 'W'
 360         }
 361     );
 362     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 363     is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 364     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
 365     is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 366     t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
 367
 368     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 369     is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
 370     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
 371
 372     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
 373     is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
 374     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
 375
 376     my $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, borrowernumber => $reserving_borrowernumber});
 377     my $reserving_borrower = GetMember( borrowernumber => $reserving_borrowernumber );
 378     AddIssue($reserving_borrower, $barcode3);
 379     my $reserve = $dbh->selectrow_hashref(
 380         'SELECT * FROM old_reserves WHERE reserve_id = ?',
 381         { Slice => {} },
 382         $reserveid
 383     );
 384     is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
 385
 386     # Item-level hold, renewal test
 387     AddReserve(
 388         $branch, $reserving_borrowernumber, $biblionumber,
 389         $bibitems,  $priority, $resdate, $expdate, $notes,
 390         $title, $itemnumber, $found
 391     );
 392
 393     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
 394     is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
 395     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
 396
 397     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2, 1);
 398     is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
 399
 400     # Items can't fill hold for reasons
 401     ModItem({ notforloan => 1 }, $biblionumber, $itemnumber);
 402     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber, 1);
 403     is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
 404     ModItem({ notforloan => 0, itype => $itemtype }, $biblionumber, $itemnumber,1);
 405
 406     # FIXME: Add more for itemtype not for loan etc.
 407
 408     # Restricted users cannot renew when RestrictionBlockRenewing is enabled
 409     my $barcode5 = 'R00000347';
 410     my ( $item_bibnum5, $item_bibitemnum5, $itemnumber5 ) = AddItem(
 411         {
 412             homebranch       => $branch,
 413             holdingbranch    => $branch,
 414             barcode          => $barcode5,
 415             replacementprice => 23.00,
 416             itype            => $itemtype
 417         },
 418         $biblionumber
 419     );
 420     my $datedue5 = AddIssue($restricted_borrower, $barcode5);
 421     is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
 422
 423     t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
 424     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2);
 425     is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
 426     ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $itemnumber5);
 427     is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
 428
 429     # Users cannot renew an overdue item
 430     my $barcode6 = 'R00000348';
 431     my ( $item_bibnum6, $item_bibitemnum6, $itemnumber6 ) = AddItem(
 432         {
 433             homebranch       => $branch,
 434             holdingbranch    => $branch,
 435             barcode          => $barcode6,
 436             replacementprice => 23.00,
 437             itype            => $itemtype
 438         },
 439         $biblionumber
 440     );
 441
 442     my $barcode7 = 'R00000349';
 443     my ( $item_bibnum7, $item_bibitemnum7, $itemnumber7 ) = AddItem(
 444         {
 445             homebranch       => $branch,
 446             holdingbranch    => $branch,
 447             barcode          => $barcode7,
 448             replacementprice => 23.00,
 449             itype            => $itemtype
 450         },
 451         $biblionumber
 452     );
 453     my $datedue6 = AddIssue( $renewing_borrower, $barcode6);
 454     is (defined $datedue6, 1, "Item 2 checked out, due date: $datedue6");
 455
 456     my $now = dt_from_string();
 457     my $five_weeks = DateTime::Duration->new(weeks => 5);
 458     my $five_weeks_ago = $now - $five_weeks;
 459
 460     my $passeddatedue1 = AddIssue($renewing_borrower, $barcode7, $five_weeks_ago);
 461     is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
 462
 463     my ( $fine ) = CalcFine( GetItem(undef, $barcode7), $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
 464     C4::Overdues::UpdateFine(
 465         {
 466             issue_id       => $passeddatedue1->id(),
 467             itemnumber     => $itemnumber7,
 468             borrowernumber => $renewing_borrower->{borrowernumber},
 469             amount         => $fine,
 470             type           => 'FU',
 471             due            => Koha::DateUtils::output_pref($five_weeks_ago)
 472         }
 473     );
 474     AddRenewal( $renewing_borrower->{borrowernumber}, $itemnumber7, $branch );
 475     $fine = $schema->resultset('Accountline')->single( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $itemnumber7 } );
 476     is( $fine->accounttype, 'F', 'Fine on renewed item is closed out properly' );
 477     $fine->delete();
 478
 479     t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
 480     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber6);
 481     is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
 482     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber7);
 483     is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
 484
 485
 486     $reserveid = C4::Reserves::GetReserveId({ biblionumber => $biblionumber, itemnumber => $itemnumber, borrowernumber => $reserving_borrowernumber});
 487     CancelReserve({ reserve_id => $reserveid });
 488
 489     # Bug 14101
 490     # Test automatic renewal before value for "norenewalbefore" in policy is set
 491     # In this case automatic renewal is not permitted prior to due date
 492     my $barcode4 = '11235813';
 493     my ( $item_bibnum4, $item_bibitemnum4, $itemnumber4 ) = AddItem(
 494         {
 495             homebranch       => $branch,
 496             holdingbranch    => $branch,
 497             barcode          => $barcode4,
 498             replacementprice => 16.00,
 499             itype            => $itemtype
 500         },
 501         $biblionumber
 502     );
 503
 504     $issue = AddIssue( $renewing_borrower, $barcode4, undef, undef, undef, undef, { auto_renew => 1 } );
 505     ( $renewokay, $error ) =
 506       CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
 507     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
 508     is( $error, 'auto_too_soon',
 509         'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
 510
 511     # Bug 7413
 512     # Test premature manual renewal
 513     $dbh->do('UPDATE issuingrules SET norenewalbefore = 7');
 514
 515     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 516     is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
 517     is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
 518
 519     # Bug 14395
 520     # Test 'exact time' setting for syspref NoRenewalBeforePrecision
 521     t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
 522     is(
 523         GetSoonestRenewDate( $renewing_borrowernumber, $itemnumber ),
 524         $datedue->clone->add( days => -7 ),
 525         'Bug 14395: Renewals permitted 7 days before due date, as expected'
 526     );
 527
 528     # Bug 14395
 529     # Test 'date' setting for syspref NoRenewalBeforePrecision
 530     t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
 531     is(
 532         GetSoonestRenewDate( $renewing_borrowernumber, $itemnumber ),
 533         $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
 534         'Bug 14395: Renewals permitted 7 days before due date, as expected'
 535     );
 536
 537     # Bug 14101
 538     # Test premature automatic renewal
 539     ( $renewokay, $error ) =
 540       CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
 541     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
 542     is( $error, 'auto_too_soon',
 543         'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
 544     );
 545
 546     # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
 547     # and test automatic renewal again
 548     $dbh->do('UPDATE issuingrules SET norenewalbefore = 0');
 549     ( $renewokay, $error ) =
 550       CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
 551     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
 552     is( $error, 'auto_too_soon',
 553         'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
 554     );
 555
 556     # Change policy so that loans can be renewed 99 days prior to the due date
 557     # and test automatic renewal again
 558     $dbh->do('UPDATE issuingrules SET norenewalbefore = 99');
 559     ( $renewokay, $error ) =
 560       CanBookBeRenewed( $renewing_borrowernumber, $itemnumber4 );
 561     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
 562     is( $error, 'auto_renew',
 563         'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
 564     );
 565
 566     # Too many renewals
 567
 568     # set policy to forbid renewals
 569     $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
 570
 571     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber);
 572     is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
 573     is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
 574
 575     # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
 576     t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
 577     t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
 578
 579     C4::Overdues::UpdateFine(
 580         {
 581             issue_id       => $issue->id(),
 582             itemnumber     => $itemnumber,
 583             borrowernumber => $renewing_borrower->{borrowernumber},
 584             amount         => 15.00,
 585             type           => q{},
 586             due            => Koha::DateUtils::output_pref($datedue)
 587         }
 588     );
 589
 590     LostItem( $itemnumber, 1 );
 591
 592     my $item = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber);
 593     ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
 594
 595     my $total_due = $dbh->selectrow_array(
 596         'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
 597         undef, $renewing_borrower->{borrowernumber}
 598     );
 599
 600     ok( $total_due == 12, 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
 601
 602     C4::Context->dbh->do("DELETE FROM accountlines");
 603
 604     t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
 605     t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
 606
 607     C4::Overdues::UpdateFine(
 608         {
 609             issue_id       => $issue2->id(),
 610             itemnumber     => $itemnumber2,
 611             borrowernumber => $renewing_borrower->{borrowernumber},
 612             amount         => 15.00,
 613             type           => q{},
 614             due            => Koha::DateUtils::output_pref($datedue)
 615         }
 616     );
 617
 618     LostItem( $itemnumber2, 0 );
 619
 620     my $item2 = Koha::Database->new()->schema()->resultset('Item')->find($itemnumber2);
 621     ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
 622
 623     $total_due = $dbh->selectrow_array(
 624         'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
 625         undef, $renewing_borrower->{borrowernumber}
 626     );
 627
 628     ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
 629
 630     my $future = dt_from_string();
 631     $future->add( days => 7 );
 632     my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
 633     ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
 634
 635     # Users cannot renew any item if there is an overdue item
 636     t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
 637     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber6);
 638     is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
 639     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber7);
 640     is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
 641
 642   }
 643
 644 {
 645     # GetUpcomingDueIssues tests
 646     my $barcode  = 'R00000342';
 647     my $barcode2 = 'R00000343';
 648     my $barcode3 = 'R00000344';
 649     my $branch   = $library2->{branchcode};
 650
 651     #Create another record
 652     my $biblio2 = MARC::Record->new();
 653     my $title2 = 'Something is worng here';
 654     $biblio2->append_fields(
 655         MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
 656         MARC::Field->new('245', ' ', ' ', a => $title2),
 657     );
 658     my ($biblionumber2, $biblioitemnumber2) = AddBiblio($biblio2, '');
 659
 660     #Create third item
 661     AddItem(
 662         {
 663             homebranch       => $branch,
 664             holdingbranch    => $branch,
 665             barcode          => $barcode3,
 666             itype            => $itemtype
 667         },
 668         $biblionumber2
 669     );
 670
 671     # Create a borrower
 672     my %a_borrower_data = (
 673         firstname =>  'Fridolyn',
 674         surname => 'SOMERS',
 675         categorycode => 'S',
 676         branchcode => $branch,
 677     );
 678
 679     my $a_borrower_borrowernumber = AddMember(%a_borrower_data);
 680     my $a_borrower = GetMember( borrowernumber => $a_borrower_borrowernumber );
 681
 682     my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
 683     my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
 684     my $today = DateTime->today(time_zone => C4::Context->tz());
 685
 686     my $issue = AddIssue( $a_borrower, $barcode, $yesterday );
 687     my $datedue = dt_from_string( $issue->date_due() );
 688     my $issue2 = AddIssue( $a_borrower, $barcode2, $two_days_ahead );
 689     my $datedue2 = dt_from_string( $issue->date_due() );
 690
 691     my $upcoming_dues;
 692
 693     # GetUpcomingDueIssues tests
 694     for my $i(0..1) {
 695         $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
 696         is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
 697     }
 698
 699     #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
 700     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
 701     is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
 702
 703     for my $i(3..5) {
 704         $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
 705         is ( scalar( @$upcoming_dues ), 1,
 706             "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
 707     }
 708
 709     # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
 710
 711     my $issue3 = AddIssue( $a_borrower, $barcode3, $today );
 712
 713     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
 714     is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
 715
 716     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
 717     is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
 718
 719     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
 720     is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
 721
 722     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 }  );
 723     is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
 724
 725     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
 726     is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
 727
 728     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
 729     is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
 730
 731 }
 732
 733 {
 734     my $barcode  = '1234567890';
 735     my $branch   = $library2->{branchcode};
 736
 737     my $biblio = MARC::Record->new();
 738     my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
 739
 740     #Create third item
 741     my ( undef, undef, $itemnumber ) = AddItem(
 742         {
 743             homebranch       => $branch,
 744             holdingbranch    => $branch,
 745             barcode          => $barcode,
 746             itype            => $itemtype
 747         },
 748         $biblionumber
 749     );
 750
 751     # Create a borrower
 752     my %a_borrower_data = (
 753         firstname =>  'Kyle',
 754         surname => 'Hall',
 755         categorycode => 'S',
 756         branchcode => $branch,
 757     );
 758
 759     my $borrowernumber = AddMember(%a_borrower_data);
 760
 761     my $issue = AddIssue( GetMember( borrowernumber => $borrowernumber ), $barcode );
 762     UpdateFine(
 763         {
 764             issue_id       => $issue->id(),
 765             itemnumber     => $itemnumber,
 766             borrowernumber => $borrowernumber,
 767             amount         => 0,
 768             type           => q{}
 769         }
 770     );
 771
 772     my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $itemnumber );
 773     my $count = $hr->{count};
 774
 775     is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
 776 }
 777
 778 {
 779     $dbh->do('DELETE FROM issues');
 780     $dbh->do('DELETE FROM items');
 781     $dbh->do('DELETE FROM issuingrules');
 782     $dbh->do(
 783         q{
 784         INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, maxissueqty, issuelength, lengthunit, renewalsallowed, renewalperiod,
 785                     norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
 786         },
 787         {},
 788         '*', '*', '*', 25,
 789         20,  14,  'days',
 790         1,   7,
 791         undef,  0,
 792         .10, 1
 793     );
 794     my $biblio = MARC::Record->new();
 795     my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $biblio, '' );
 796
 797     my $barcode1 = '1234';
 798     my ( undef, undef, $itemnumber1 ) = AddItem(
 799         {
 800             homebranch    => $library2->{branchcode},
 801             holdingbranch => $library2->{branchcode},
 802             barcode       => $barcode1,
 803             itype         => $itemtype
 804         },
 805         $biblionumber
 806     );
 807     my $barcode2 = '4321';
 808     my ( undef, undef, $itemnumber2 ) = AddItem(
 809         {
 810             homebranch    => $library2->{branchcode},
 811             holdingbranch => $library2->{branchcode},
 812             barcode       => $barcode2,
 813             itype         => $itemtype
 814         },
 815         $biblionumber
 816     );
 817
 818     my $borrowernumber1 = AddMember(
 819         firstname    => 'Kyle',
 820         surname      => 'Hall',
 821         categorycode => 'S',
 822         branchcode   => $library2->{branchcode},
 823     );
 824     my $borrowernumber2 = AddMember(
 825         firstname    => 'Chelsea',
 826         surname      => 'Hall',
 827         categorycode => 'S',
 828         branchcode   => $library2->{branchcode},
 829     );
 830
 831     my $borrower1 = GetMember( borrowernumber => $borrowernumber1 );
 832     my $borrower2 = GetMember( borrowernumber => $borrowernumber2 );
 833
 834     my $issue = AddIssue( $borrower1, $barcode1 );
 835
 836     my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
 837     is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
 838
 839     AddReserve(
 840         $library2->{branchcode}, $borrowernumber2, $biblionumber,
 841         '',  1, undef, undef, '',
 842         undef, undef, undef
 843     );
 844
 845     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
 846     t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
 847     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
 848     is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
 849
 850     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
 851     t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
 852     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
 853     is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
 854
 855     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
 856     t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
 857     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
 858     is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
 859
 860     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
 861     t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
 862     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
 863     is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
 864
 865     # Setting item not checked out to be not for loan but holdable
 866     ModItem({ notforloan => -1 }, $biblionumber, $itemnumber2);
 867
 868     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $itemnumber1 );
 869     is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
 870 }
 871
 872 {
 873     # Don't allow renewing onsite checkout
 874     my $barcode  = 'R00000XXX';
 875     my $branch   = $library->{branchcode};
 876
 877     #Create another record
 878     my $biblio = MARC::Record->new();
 879     $biblio->append_fields(
 880         MARC::Field->new('100', ' ', ' ', a => 'Anonymous'),
 881         MARC::Field->new('245', ' ', ' ', a => 'A title'),
 882     );
 883     my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
 884
 885     my (undef, undef, $itemnumber) = AddItem(
 886         {
 887             homebranch       => $branch,
 888             holdingbranch    => $branch,
 889             barcode          => $barcode,
 890             itype            => $itemtype
 891         },
 892         $biblionumber
 893     );
 894
 895     my $borrowernumber = AddMember(
 896         firstname =>  'fn',
 897         surname => 'dn',
 898         categorycode => 'S',
 899         branchcode => $branch,
 900     );
 901
 902     my $borrower = GetMember( borrowernumber => $borrowernumber );
 903     my $issue = AddIssue( $borrower, $barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
 904     my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $itemnumber );
 905     is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
 906     is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
 907 }
 908
 909 {
 910     my $library = $builder->build({ source => 'Branch' });
 911
 912     my $biblio = MARC::Record->new();
 913     my ($biblionumber, $biblioitemnumber) = AddBiblio($biblio, '');
 914
 915     my $barcode = 'just a barcode';
 916     my ( undef, undef, $itemnumber ) = AddItem(
 917         {
 918             homebranch       => $library->{branchcode},
 919             holdingbranch    => $library->{branchcode},
 920             barcode          => $barcode,
 921             itype            => $itemtype
 922         },
 923         $biblionumber,
 924     );
 925
 926     my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode} } } );
 927
 928     my $issue = AddIssue( GetMember( borrowernumber => $patron->{borrowernumber} ), $barcode );
 929     UpdateFine(
 930         {
 931             issue_id       => $issue->id(),
 932             itemnumber     => $itemnumber,
 933             borrowernumber => $patron->{borrowernumber},
 934             amount         => 1,
 935             type           => q{}
 936         }
 937     );
 938     UpdateFine(
 939         {
 940             issue_id       => $issue->id(),
 941             itemnumber     => $itemnumber,
 942             borrowernumber => $patron->{borrowernumber},
 943             amount         => 2,
 944             type           => q{}
 945         }
 946     );
 947     is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
 948 }
 949
 950 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
 951     plan tests => 23;
 952
 953     my $homebranch    = $builder->build( { source => 'Branch' } );
 954     my $holdingbranch = $builder->build( { source => 'Branch' } );
 955     my $otherbranch   = $builder->build( { source => 'Branch' } );
 956     my $patron_1      = $builder->build( { source => 'Borrower' } );
 957     my $patron_2      = $builder->build( { source => 'Borrower' } );
 958
 959     my $biblioitem = $builder->build( { source => 'Biblioitem' } );
 960     my $item = $builder->build(
 961         {   source => 'Item',
 962             value  => {
 963                 homebranch    => $homebranch->{branchcode},
 964                 holdingbranch => $holdingbranch->{branchcode},
 965                 notforloan    => 0,
 966                 itemlost      => 0,
 967                 withdrawn     => 0,
 968                 biblionumber  => $biblioitem->{biblionumber}
 969             }
 970         }
 971     );
 972
 973     set_userenv($holdingbranch);
 974
 975     my $issue = AddIssue( $patron_1, $item->{barcode} );
 976     is( ref($issue), 'Koha::Schema::Result::Issue' );    # FIXME Should be Koha::Issue
 977
 978     my ( $error, $question, $alerts );
 979
 980     # AllowReturnToBranch == anywhere
 981     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
 982     ## Can be issued from homebranch
 983     set_userenv($homebranch);
 984     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
 985     is( keys(%$error) + keys(%$alerts),        0 );
 986     is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
 987     ## Can be issued from holdingbranch
 988     set_userenv($holdingbranch);
 989     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
 990     is( keys(%$error) + keys(%$alerts),        0 );
 991     is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
 992     ## Can be issued from another branch
 993     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
 994     is( keys(%$error) + keys(%$alerts),        0 );
 995     is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
 996
 997     # AllowReturnToBranch == holdingbranch
 998     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
 999     ## Cannot be issued from homebranch
1000     set_userenv($homebranch);
1001     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1002     is( keys(%$question) + keys(%$alerts),  0 );
1003     is( exists $error->{RETURN_IMPOSSIBLE}, 1 );
1004     is( $error->{branch_to_return},         $holdingbranch->{branchcode} );
1005     ## Can be issued from holdinbranch
1006     set_userenv($holdingbranch);
1007     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1008     is( keys(%$error) + keys(%$alerts),        0 );
1009     is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
1010     ## Cannot be issued from another branch
1011     set_userenv($otherbranch);
1012     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1013     is( keys(%$question) + keys(%$alerts),  0 );
1014     is( exists $error->{RETURN_IMPOSSIBLE}, 1 );
1015     is( $error->{branch_to_return},         $holdingbranch->{branchcode} );
1016
1017     # AllowReturnToBranch == homebranch
1018     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1019     ## Can be issued from holdinbranch
1020     set_userenv($homebranch);
1021     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1022     is( keys(%$error) + keys(%$alerts),        0 );
1023     is( exists $question->{ISSUED_TO_ANOTHER}, 1 );
1024     ## Cannot be issued from holdinbranch
1025     set_userenv($holdingbranch);
1026     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1027     is( keys(%$question) + keys(%$alerts),  0 );
1028     is( exists $error->{RETURN_IMPOSSIBLE}, 1 );
1029     is( $error->{branch_to_return},         $homebranch->{branchcode} );
1030     ## Cannot be issued from holdinbranch
1031     set_userenv($otherbranch);
1032     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1033     is( keys(%$question) + keys(%$alerts),  0 );
1034     is( exists $error->{RETURN_IMPOSSIBLE}, 1 );
1035     is( $error->{branch_to_return},         $homebranch->{branchcode} );
1036
1037     # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1038 };
1039
1040 subtest 'AddIssue & AllowReturnToBranch' => sub {
1041     plan tests => 9;
1042
1043     my $homebranch    = $builder->build( { source => 'Branch' } );
1044     my $holdingbranch = $builder->build( { source => 'Branch' } );
1045     my $otherbranch   = $builder->build( { source => 'Branch' } );
1046     my $patron_1      = $builder->build( { source => 'Borrower' } );
1047     my $patron_2      = $builder->build( { source => 'Borrower' } );
1048
1049     my $biblioitem = $builder->build( { source => 'Biblioitem' } );
1050     my $item = $builder->build(
1051         {   source => 'Item',
1052             value  => {
1053                 homebranch    => $homebranch->{branchcode},
1054                 holdingbranch => $holdingbranch->{branchcode},
1055                 notforloan    => 0,
1056                 itemlost      => 0,
1057                 withdrawn     => 0,
1058                 biblionumber  => $biblioitem->{biblionumber}
1059             }
1060         }
1061     );
1062
1063     set_userenv($holdingbranch);
1064
1065     my $ref_issue = 'Koha::Schema::Result::Issue'; # FIXME Should be Koha::Issue
1066     my $issue = AddIssue( $patron_1, $item->{barcode} );
1067
1068     my ( $error, $question, $alerts );
1069
1070     # AllowReturnToBranch == homebranch
1071     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1072     ## Can be issued from homebranch
1073     set_userenv($homebranch);
1074     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1075     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1076     ## Can be issued from holdinbranch
1077     set_userenv($holdingbranch);
1078     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1079     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1080     ## Can be issued from another branch
1081     set_userenv($otherbranch);
1082     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1083     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1084
1085     # AllowReturnToBranch == holdinbranch
1086     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1087     ## Cannot be issued from homebranch
1088     set_userenv($homebranch);
1089     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1090     ## Can be issued from holdingbranch
1091     set_userenv($holdingbranch);
1092     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1093     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1094     ## Cannot be issued from another branch
1095     set_userenv($otherbranch);
1096     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1097
1098     # AllowReturnToBranch == homebranch
1099     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1100     ## Can be issued from homebranch
1101     set_userenv($homebranch);
1102     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue );
1103     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1104     ## Cannot be issued from holdinbranch
1105     set_userenv($holdingbranch);
1106     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1107     ## Cannot be issued from another branch
1108     set_userenv($otherbranch);
1109     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '' );
1110     # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1111 };
1112
1113
1114 sub set_userenv {
1115     my ( $library ) = @_;
1116     C4::Context->set_userenv(0,0,0,'firstname','surname', $library->{branchcode}, $library->{branchname}, '', '', '');
1117 }
1118
1119 1;