t/db_dependent/Koha/Item.t

   1 #!/usr/bin/perl
   2
   3 # Copyright 2019 Koha Development team
   4 #
   5 # This file is part of Koha
   6 #
   7 # Koha is free software; you can redistribute it and/or modify it
   8 # under the terms of the GNU General Public License as published by
   9 # the Free Software Foundation; either version 3 of the License, or
  10 # (at your option) any later version.
  11 #
  12 # Koha is distributed in the hope that it will be useful, but
  13 # WITHOUT ANY WARRANTY; without even the implied warranty of
  14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  15 # GNU General Public License for more details.
  16 #
  17 # You should have received a copy of the GNU General Public License
  18 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  19
  20 use Modern::Perl;
  21
  22 use Test::More tests => 4;
  23
  24 use C4::Biblio;
  25
  26 use Koha::Items;
  27 use Koha::Database;
  28
  29 use t::lib::TestBuilder;
  30 use t::lib::Mocks;
  31
  32 my $schema  = Koha::Database->new->schema;
  33 my $builder = t::lib::TestBuilder->new;
  34
  35 subtest 'hidden_in_opac() tests' => sub {
  36
  37     plan tests => 4;
  38
  39     $schema->storage->txn_begin;
  40
  41     my $item  = $builder->build_sample_item({ itemlost => 2 });
  42     my $rules = {};
  43
  44     # disable hidelostitems as it interteres with OpachiddenItems for the calculation
  45     t::lib::Mocks::mock_preference( 'hidelostitems', 0 );
  46
  47     ok( !$item->hidden_in_opac, 'No rules passed, shouldn\'t hide' );
  48     ok( !$item->hidden_in_opac({ rules => $rules }), 'Empty rules passed, shouldn\'t hide' );
  49
  50     # enable hidelostitems to verify correct behaviour
  51     t::lib::Mocks::mock_preference( 'hidelostitems', 1 );
  52     ok( $item->hidden_in_opac, 'Even with no rules, item should hide because of hidelostitems syspref' );
  53
  54     # disable hidelostitems
  55     t::lib::Mocks::mock_preference( 'hidelostitems', 0 );
  56     my $withdrawn = $item->withdrawn + 1; # make sure this attribute doesn't match
  57
  58     $rules = { withdrawn => [$withdrawn], itype => [ $item->itype ] };
  59
  60     ok( $item->hidden_in_opac({ rules => $rules }), 'Rule matching itype passed, should hide' );
  61
  62
  63
  64     $schema->storage->txn_rollback;
  65 };
  66
  67 subtest 'has_pending_hold() tests' => sub {
  68
  69     plan tests => 2;
  70
  71     $schema->storage->txn_begin;
  72
  73     my $dbh = C4::Context->dbh;
  74     my $item  = $builder->build_sample_item({ itemlost => 0 });
  75     my $itemnumber = $item->itemnumber;
  76
  77     $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber) VALUES ('Clamp',42,$itemnumber)");
  78     ok( $item->has_pending_hold, "Yes, we have a pending hold");
  79     $dbh->do("DELETE FROM tmp_holdsqueue WHERE itemnumber=$itemnumber");
  80     ok( !$item->has_pending_hold, "We don't have a pending hold if nothing in the tmp_holdsqueue");
  81
  82     $schema->storage->txn_rollback;
  83 };
  84
  85 subtest "as_marc_field() tests" => sub {
  86
  87     my $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 1 } );
  88
  89     my @schema_columns = $schema->resultset('Item')->result_source->columns;
  90     my @mapped_columns = grep { exists $mss->{'items.'.$_} } @schema_columns;
  91
  92     plan tests => 2 * (scalar @mapped_columns + 1) + 1;
  93
  94     $schema->storage->txn_begin;
  95
  96     my $item = $builder->build_sample_item;
  97
  98     # Tests with the mss parameter
  99     my $marc_field = $item->as_marc_field({ mss => $mss });
 100
 101     is(
 102         $marc_field->tag,
 103         $mss->{'items.itemnumber'}[0]->{tagfield},
 104         'Generated field set the right tag number'
 105     );
 106
 107     foreach my $column ( @mapped_columns ) {
 108         my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
 109         is( $marc_field->subfield($tagsubfield),
 110             $item->$column, "Value is mapped correctly for column $column" );
 111     }
 112
 113     # Tests without the mss parameter
 114     $marc_field = $item->as_marc_field();
 115
 116     is(
 117         $marc_field->tag,
 118         $mss->{'items.itemnumber'}[0]->{tagfield},
 119         'Generated field set the right tag number'
 120     );
 121
 122     foreach my $column (@mapped_columns) {
 123         my $tagsubfield = $mss->{ 'items.' . $column }[0]->{tagsubfield};
 124         is( $marc_field->subfield($tagsubfield),
 125             $item->$column, "Value is mapped correctly for column $column" );
 126     }
 127
 128     my $unmapped_subfield = Koha::MarcSubfieldStructure->new(
 129         {
 130             frameworkcode => '',
 131             tagfield      => $mss->{'items.itemnumber'}[0]->{tagfield},
 132             tagsubfield   => 'X',
 133         }
 134     )->store;
 135
 136     $mss = C4::Biblio::GetMarcSubfieldStructure( '', { unsafe => 0 } );
 137     my @unlinked_subfields;
 138     push @unlinked_subfields, X => 'Something weird';
 139     $item->more_subfields_xml( C4::Items::_get_unlinked_subfields_xml( \@unlinked_subfields ) )->store;
 140
 141     $marc_field = $item->as_marc_field;
 142     is( scalar $marc_field->subfield('X'), 'Something weird', 'more_subfield_xml is considered' );
 143
 144     $schema->storage->txn_rollback;
 145 };
 146
 147 subtest 'pickup_locations' => sub {
 148     plan tests => 114;
 149
 150     $schema->storage->txn_begin;
 151
 152     my $dbh = C4::Context->dbh;
 153
 154     # Cleanup database
 155     Koha::Holds->search->delete;
 156     Koha::Patrons->search->delete;
 157     Koha::Items->search->delete;
 158     Koha::Libraries->search->delete;
 159     $dbh->do('DELETE FROM issues');
 160     Koha::CirculationRules->search->delete;
 161     Koha::CirculationRules->set_rules(
 162         {
 163             categorycode => undef,
 164             itemtype     => undef,
 165             branchcode   => undef,
 166             rules        => {
 167                 reservesallowed => 25,
 168             }
 169         }
 170     );
 171
 172     my $root1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );
 173     my $root2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { ft_local_hold_group => 1 } } );
 174
 175     my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } );
 176     my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } );
 177     my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0 } } );
 178     my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1 } } );
 179
 180     my $group1_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library1->branchcode } } );
 181     my $group1_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root1->id, branchcode => $library2->branchcode } } );
 182
 183     my $group2_1 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library3->branchcode } } );
 184     my $group2_2 = $builder->build_object( { class => 'Koha::Library::Groups', value => { parent_id => $root2->id, branchcode => $library4->branchcode } } );
 185
 186     my $biblioitem  = $builder->build( { source => 'Biblioitem' } );
 187
 188     my $item1  = Koha::Item->new({
 189         biblionumber     => $biblioitem->{biblionumber},
 190         biblioitemnumber => $biblioitem->{biblioitemnumber},
 191         homebranch       => $library1->branchcode,
 192         holdingbranch    => $library2->branchcode,
 193         barcode          => '1',
 194         itype            => 'test',
 195     })->store;
 196
 197     my $item3  = Koha::Item->new({
 198         biblionumber     => $biblioitem->{biblionumber},
 199         biblioitemnumber => $biblioitem->{biblioitemnumber},
 200         homebranch       => $library3->branchcode,
 201         holdingbranch    => $library4->branchcode,
 202         barcode          => '3',
 203         itype            => 'test',
 204     })->store;
 205
 206     my $patron1 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library1->branchcode, firstname => '1' } } );
 207     my $patron4 = $builder->build_object( { class => 'Koha::Patrons', value => { branchcode => $library4->branchcode, firstname => '4' } } );
 208
 209     my $results = {
 210         "1-1-1-any" => 3,
 211         "1-1-1-holdgroup" => 2,
 212         "1-1-1-patrongroup" => 2,
 213         "1-1-1-homebranch" => 1,
 214         "1-1-1-holdingbranch" => 1,
 215         "1-1-2-any" => 3,
 216         "1-1-2-holdgroup" => 2,
 217         "1-1-2-patrongroup" => 2,
 218         "1-1-2-homebranch" => 1,
 219         "1-1-2-holdingbranch" => 1,
 220         "1-1-3-any" => 3,
 221         "1-1-3-holdgroup" => 2,
 222         "1-1-3-patrongroup" => 2,
 223         "1-1-3-homebranch" => 1,
 224         "1-1-3-holdingbranch" => 1,
 225         "1-4-1-any" => 0,
 226         "1-4-1-holdgroup" => 0,
 227         "1-4-1-patrongroup" => 0,
 228         "1-4-1-homebranch" => 0,
 229         "1-4-1-holdingbranch" => 0,
 230         "1-4-2-any" => 3,
 231         "1-4-2-holdgroup" => 2,
 232         "1-4-2-patrongroup" => 1,
 233         "1-4-2-homebranch" => 1,
 234         "1-4-2-holdingbranch" => 1,
 235         "1-4-3-any" => 0,
 236         "1-4-3-holdgroup" => 0,
 237         "1-4-3-patrongroup" => 0,
 238         "1-4-3-homebranch" => 0,
 239         "1-4-3-holdingbranch" => 0,
 240         "3-1-1-any" => 0,
 241         "3-1-1-holdgroup" => 0,
 242         "3-1-1-patrongroup" => 0,
 243         "3-1-1-homebranch" => 0,
 244         "3-1-1-holdingbranch" => 0,
 245         "3-1-2-any" => 3,
 246         "3-1-2-holdgroup" => 1,
 247         "3-1-2-patrongroup" => 2,
 248         "3-1-2-homebranch" => 0,
 249         "3-1-2-holdingbranch" => 1,
 250         "3-1-3-any" => 0,
 251         "3-1-3-holdgroup" => 0,
 252         "3-1-3-patrongroup" => 0,
 253         "3-1-3-homebranch" => 0,
 254         "3-1-3-holdingbranch" => 0,
 255         "3-4-1-any" => 0,
 256         "3-4-1-holdgroup" => 0,
 257         "3-4-1-patrongroup" => 0,
 258         "3-4-1-homebranch" => 0,
 259         "3-4-1-holdingbranch" => 0,
 260         "3-4-2-any" => 3,
 261         "3-4-2-holdgroup" => 1,
 262         "3-4-2-patrongroup" => 1,
 263         "3-4-2-homebranch" => 0,
 264         "3-4-2-holdingbranch" => 1,
 265         "3-4-3-any" => 3,
 266         "3-4-3-holdgroup" => 1,
 267         "3-4-3-patrongroup" => 1,
 268         "3-4-3-homebranch" => 0,
 269         "3-4-3-holdingbranch" => 1
 270     };
 271
 272     sub _doTest {
 273         my ( $item, $patron, $ha, $hfp, $results ) = @_;
 274
 275         Koha::CirculationRules->set_rules(
 276             {
 277                 branchcode => undef,
 278                 itemtype   => undef,
 279                 rules => {
 280                     holdallowed => $ha,
 281                     hold_fulfillment_policy => $hfp,
 282                     returnbranch => 'any'
 283                 }
 284             }
 285         );
 286         my @pl = $item->pickup_locations( { patron => $patron} );
 287         my $ha_value=$ha==3?'holdgroup':($ha==2?'any':'homebranch');
 288
 289         foreach my $pickup_location (@pl) {
 290             is( ref($pickup_location), 'Koha::Library', 'Object type is correct' );
 291         }
 292
 293         ok(
 294             scalar(@pl) == $results->{
 295                     $item->barcode . '-'
 296                   . $patron->firstname . '-'
 297                   . $ha . '-'
 298                   . $hfp
 299             },
 300             'item'
 301               . $item->barcode
 302               . ', patron'
 303               . $patron->firstname
 304               . ', holdallowed: '
 305               . $ha_value
 306               . ', hold_fulfillment_policy: '
 307               . $hfp
 308               . ' should return '
 309               . $results->{
 310                     $item->barcode . '-'
 311                   . $patron->firstname . '-'
 312                   . $ha . '-'
 313                   . $hfp
 314               }
 315               . ' but returns '
 316               . scalar(@pl)
 317         );
 318
 319     }
 320
 321
 322     foreach my $item ($item1, $item3) {
 323         foreach my $patron ($patron1, $patron4) {
 324             #holdallowed 1: homebranch, 2: any, 3: holdgroup
 325             foreach my $ha (1, 2, 3) {
 326                 foreach my $hfp ('any', 'holdgroup', 'patrongroup', 'homebranch', 'holdingbranch') {
 327                     _doTest($item, $patron, $ha, $hfp, $results);
 328                 }
 329             }
 330         }
 331     }
 332
 333     $schema->storage->txn_rollback;
 334 };