Bug 18624: Run time errors when searching authorities with Elastic search 5.3
[koha.git] / reserve / request.pl
blob7cda03dce2fbc1e01d39317394ba2cb17a81b543
1 #!/usr/bin/perl
4 #written 2/1/00 by chris@katipo.oc.nz
5 # Copyright 2000-2002 Katipo Communications
6 # Parts Copyright 2011 Catalyst IT
8 # This file is part of Koha.
10 # Koha is free software; you can redistribute it and/or modify it
11 # under the terms of the GNU General Public License as published by
12 # the Free Software Foundation; either version 3 of the License, or
13 # (at your option) any later version.
15 # Koha is distributed in the hope that it will be useful, but
16 # WITHOUT ANY WARRANTY; without even the implied warranty of
17 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18 # GNU General Public License for more details.
20 # You should have received a copy of the GNU General Public License
21 # along with Koha; if not, see <http://www.gnu.org/licenses>.
23 =head1 request.pl
25 script to place reserves/requests
27 =cut
29 use Modern::Perl;
31 use CGI qw ( -utf8 );
32 use List::MoreUtils qw/uniq/;
33 use Date::Calc qw/Date_to_Days/;
34 use C4::Output;
35 use C4::Auth;
36 use C4::Reserves;
37 use C4::Biblio;
38 use C4::Items;
39 use C4::Koha;
40 use C4::Circulation;
41 use Koha::DateUtils;
42 use C4::Utils::DataTables::Members;
43 use C4::Members;
44 use C4::Search; # enabled_staff_search_views
46 use Koha::Biblios;
47 use Koha::DateUtils;
48 use Koha::Checkouts;
49 use Koha::Holds;
50 use Koha::Items;
51 use Koha::ItemTypes;
52 use Koha::Libraries;
53 use Koha::Patrons;
55 my $dbh = C4::Context->dbh;
56 my $input = new CGI;
57 my ( $template, $borrowernumber, $cookie, $flags ) = get_template_and_user(
59 template_name => "reserve/request.tt",
60 query => $input,
61 type => "intranet",
62 authnotrequired => 0,
63 flagsrequired => { reserveforothers => 'place_holds' },
67 my $multihold = $input->param('multi_hold');
68 $template->param(multi_hold => $multihold);
69 my $showallitems = $input->param('showallitems');
71 my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } };
73 # Select borrowers infos
74 my $findborrower = $input->param('findborrower');
75 $findborrower = '' unless defined $findborrower;
76 $findborrower =~ s|,| |g;
77 my $borrowernumber_hold = $input->param('borrowernumber') || '';
78 my $messageborrower;
79 my $warnings;
80 my $messages;
81 my $exceeded_maxreserves;
82 my $exceeded_holds_per_record;
84 my $date = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 });
85 my $action = $input->param('action');
86 $action ||= q{};
88 if ( $action eq 'move' ) {
89 my $where = $input->param('where');
90 my $reserve_id = $input->param('reserve_id');
91 AlterPriority( $where, $reserve_id );
92 } elsif ( $action eq 'cancel' ) {
93 my $reserve_id = $input->param('reserve_id');
94 CancelReserve({ reserve_id => $reserve_id });
95 } elsif ( $action eq 'setLowestPriority' ) {
96 my $reserve_id = $input->param('reserve_id');
97 ToggleLowestPriority( $reserve_id );
98 } elsif ( $action eq 'toggleSuspend' ) {
99 my $reserve_id = $input->param('reserve_id');
100 my $suspend_until = $input->param('suspend_until');
101 ToggleSuspend( $reserve_id, $suspend_until );
104 if ($findborrower) {
105 my $patron = Koha::Patrons->find( { cardnumber => $findborrower } );
106 if ( $patron ) {
107 $borrowernumber_hold = $patron->borrowernumber;
108 } else {
109 my $dt_params = { iDisplayLength => -1 };
110 my $results = C4::Utils::DataTables::Members::search(
112 searchmember => $findborrower,
113 dt_params => $dt_params,
116 my $borrowers = $results->{patrons};
117 if ( scalar @$borrowers == 1 ) {
118 $borrowernumber_hold = $borrowers->[0]->{borrowernumber};
119 } elsif ( @$borrowers ) {
120 $template->param( borrowers => $borrowers );
121 } else {
122 $messageborrower = "'$findborrower'";
127 my @biblionumbers = ();
128 my $biblionumbers = $input->param('biblionumbers');
129 if ($multihold) {
130 @biblionumbers = split '/', $biblionumbers;
131 } else {
132 push @biblionumbers, $input->multi_param('biblionumber');
136 # If we have the borrowernumber because we've performed an action, then we
137 # don't want to try to place another reserve.
138 if ($borrowernumber_hold && !$action) {
139 my $patron = Koha::Patrons->find( $borrowernumber_hold );
140 my $diffbranch;
142 # we check the reserves of the user, and if they can reserve a document
143 # FIXME At this time we have a simple count of reservs, but, later, we could improve the infos "title" ...
145 my $reserves_count =
146 GetReserveCount( $patron->borrowernumber );
148 my $new_reserves_count = scalar( @biblionumbers );
150 my $maxreserves = C4::Context->preference('maxreserves');
151 if ( $maxreserves
152 && ( $reserves_count + $new_reserves_count > $maxreserves ) )
154 my $new_reserves_allowed =
155 $maxreserves - $reserves_count > 0
156 ? $maxreserves - $reserves_count
157 : 0;
158 $warnings = 1;
159 $exceeded_maxreserves = 1;
160 $template->param(
161 new_reserves_allowed => $new_reserves_allowed,
162 new_reserves_count => $new_reserves_count,
163 reserves_count => $reserves_count,
164 maxreserves => $maxreserves,
168 # we check the date expiry of the borrower (only if there is an expiry date, otherwise, set to 1 (warn)
169 my $expiry_date = $patron->dateexpiry;
170 my $expiry = 0; # flag set if patron account has expired
171 if ($expiry_date and $expiry_date ne '0000-00-00' and
172 Date_to_Days(split /-/,$date) > Date_to_Days(split /-/,$expiry_date)) {
173 $expiry = 1;
176 # check if the borrower make the reserv in a different branch
177 if ( $patron->branchcode ne C4::Context->userenv->{'branch'} ) {
178 $diffbranch = 1;
181 my $is_debarred = $patron->is_debarred;
182 $template->param(
183 borrowernumber => $patron->borrowernumber,
184 borrowersurname => $patron->surname,
185 borrowerfirstname => $patron->firstname,
186 borrowerstreetaddress => $patron->address,
187 borrowercity => $patron->city,
188 borrowerphone => $patron->phone,
189 borrowermobile => $patron->mobile,
190 borrowerfax => $patron->fax,
191 borrowerphonepro => $patron->phonepro,
192 borroweremail => $patron->email,
193 borroweremailpro => $patron->emailpro,
194 cardnumber => $patron->cardnumber,
195 expiry => $expiry,
196 diffbranch => $diffbranch,
197 messages => $messages,
198 warnings => $warnings,
199 restricted => $is_debarred,
200 amount_outstanding => GetMemberAccountRecords($patron->borrowernumber),
204 $template->param( messageborrower => $messageborrower );
206 # FIXME launch another time GetMember perhaps until (Joubu: Why?)
207 my $patron = Koha::Patrons->find( $borrowernumber_hold );
209 my $logged_in_patron = Koha::Patrons->find( $borrowernumber );
211 my $itemdata_enumchron = 0;
212 my @biblioloop = ();
213 foreach my $biblionumber (@biblionumbers) {
214 next unless $biblionumber =~ m|^\d+$|;
216 my %biblioloopiter = ();
218 my $biblio = Koha::Biblios->find( $biblionumber );
220 my $force_hold_level;
221 if ( $patron ) {
222 { # CanBookBeReserved
223 my $canReserve = CanBookBeReserved( $patron->borrowernumber, $biblionumber );
224 $canReserve //= '';
225 if ( $canReserve eq 'OK' ) {
227 #All is OK and we can continue
229 elsif ( $canReserve eq 'tooManyReserves' ) {
230 $exceeded_maxreserves = 1;
232 elsif ( $canReserve eq 'tooManyHoldsForThisRecord' ) {
233 $exceeded_holds_per_record = 1;
234 $biblioloopiter{$canReserve} = 1;
236 elsif ( $canReserve eq 'ageRestricted' ) {
237 $template->param( $canReserve => 1 );
238 $biblioloopiter{$canReserve} = 1;
240 else {
241 $biblioloopiter{$canReserve} = 1;
245 # For multiple holds per record, if a patron has previously placed a hold,
246 # the patron can only place more holds of the same type. That is, if the
247 # patron placed a record level hold, all the holds the patron places must
248 # be record level. If the patron placed an item level hold, all holds
249 # the patron places must be item level
250 my $holds = Koha::Holds->search(
252 borrowernumber => $patron->borrowernumber,
253 biblionumber => $biblionumber,
254 found => undef,
257 $force_hold_level = $holds->forced_hold_level();
258 $biblioloopiter{force_hold_level} = $force_hold_level;
259 $template->param( force_hold_level => $force_hold_level );
261 # For a librarian to be able to place multiple record holds for a patron for a record,
262 # we must find out what the maximum number of holds they can place for the patron is
263 my $max_holds_for_record = GetMaxPatronHoldsForRecord( $patron->borrowernumber, $biblionumber );
264 my $remaining_holds_for_record = $max_holds_for_record - $holds->count();
265 $biblioloopiter{remaining_holds_for_record} = $max_holds_for_record;
266 $template->param( max_holds_for_record => $max_holds_for_record );
267 $template->param( remaining_holds_for_record => $remaining_holds_for_record );
269 { # alreadypossession
270 # Check to see if patron is allowed to place holds on records where the
271 # patron already has an item from that record checked out
272 my $alreadypossession;
273 if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions')
274 && CheckIfIssuedToPatron( $patron->borrowernumber, $biblionumber ) )
276 $template->param( alreadypossession => $alreadypossession, );
282 my $count = Koha::Holds->search( { biblionumber => $biblionumber } )->count();
283 my $totalcount = $count;
285 # FIXME think @optionloop, is maybe obsolete, or must be switchable by a systeme preference fixed rank or not
286 # make priorities options
288 my @optionloop;
289 for ( 1 .. $count + 1 ) {
290 push(
291 @optionloop,
293 num => $_,
294 selected => ( $_ == $count + 1 ),
298 # adding a fixed value for priority options
299 my $fixedRank = $count+1;
301 my %itemnumbers_of_biblioitem;
303 my @hostitems = get_hostitemnumbers_of($biblionumber);
304 my @itemnumbers;
305 if (@hostitems){
306 $template->param('hostitemsflag' => 1);
307 push(@itemnumbers, @hostitems);
310 my $items = Koha::Items->search({ -or => { biblionumber => $biblionumber, itemnumber => { in => \@itemnumbers } } });
312 unless ( $items->count ) {
313 # FIXME Then why do we continue?
314 $template->param('noitems' => 1);
315 $biblioloopiter{noitems} = 1;
318 ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers,
319 ## when by definition all of the itemnumber have the same biblioitemnumber
320 my ( $iteminfos_of );
321 while ( my $item = $items->next ) {
322 $item = $item->unblessed;
323 my $biblioitemnumber = $item->{biblioitemnumber};
324 my $itemnumber = $item->{itemnumber};
325 push( @{ $itemnumbers_of_biblioitem{$biblioitemnumber} }, $itemnumber );
326 $iteminfos_of->{$itemnumber} = $item;
329 ## Should be same as biblionumber
330 my @biblioitemnumbers = keys %itemnumbers_of_biblioitem;
332 ## Hash of biblioitemnumber to 'biblioitem' table records
333 my $biblioiteminfos_of = GetBiblioItemInfosOf(@biblioitemnumbers);
335 my $frameworkcode = GetFrameworkCode( $biblionumber );
336 my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode });
337 my $notforloan_label_of = { map { $_->authorised_value => $_->lib } @notforloan_avs };
339 my @bibitemloop;
341 my @available_itemtypes;
342 foreach my $biblioitemnumber (@biblioitemnumbers) {
343 my $biblioitem = $biblioiteminfos_of->{$biblioitemnumber};
344 my $num_available = 0;
345 my $num_override = 0;
346 my $hiddencount = 0;
348 $biblioitem->{force_hold_level} = $force_hold_level;
350 if ( $biblioitem->{biblioitemnumber} ne $biblionumber ) {
351 $biblioitem->{hostitemsflag} = 1;
354 $biblioloopiter{description} = $biblioitem->{description};
355 $biblioloopiter{itypename} = $biblioitem->{description};
356 if ( $biblioitem->{itemtype} ) {
358 $biblioitem->{description} =
359 $itemtypes->{ $biblioitem->{itemtype} }{description};
361 $biblioloopiter{imageurl} =
362 getitemtypeimagelocation( 'intranet',
363 $itemtypes->{ $biblioitem->{itemtype} }{imageurl} );
366 foreach my $itemnumber ( @{ $itemnumbers_of_biblioitem{$biblioitemnumber} } ) {
367 my $item = $iteminfos_of->{$itemnumber};
369 $item->{force_hold_level} = $force_hold_level;
371 unless (C4::Context->preference('item-level_itypes')) {
372 $item->{itype} = $biblioitem->{itemtype};
375 $item->{itypename} = $itemtypes->{ $item->{itype} }{description};
376 $item->{imageurl} = getitemtypeimagelocation( 'intranet', $itemtypes->{ $item->{itype} }{imageurl} );
377 $item->{homebranch} = $item->{homebranch};
379 # if the holdingbranch is different than the homebranch, we show the
380 # holdingbranch of the document too
381 if ( $item->{homebranch} ne $item->{holdingbranch} ) {
382 $item->{holdingbranch} = $item->{holdingbranch};
385 if($item->{biblionumber} ne $biblionumber){
386 $item->{hostitemsflag} = 1;
387 $item->{hosttitle} = Koha::Biblios->find( $item->{biblionumber} )->title;
390 # if the item is currently on loan, we display its return date and
391 # change the background color
392 my $issue = Koha::Checkouts->find( { itemnumber => $itemnumber } );
393 if ( $issue ) {
394 $item->{date_due} = $issue->date_due;
395 $item->{backgroundcolor} = 'onloan';
398 # checking reserve
399 my $holds = Koha::Items->find( $itemnumber )->current_holds;
400 if ( my $first_hold = $holds->next ) {
401 my $p = Koha::Patrons->find( $first_hold->borrowernumber );
403 $item->{backgroundcolor} = 'reserved';
404 $item->{reservedate} = output_pref({ dt => dt_from_string( $first_hold->reservedate ), dateonly => 1 }); # FIXME Should be formatted in the template
405 $item->{ReservedForBorrowernumber} = $p->borrowernumber;
406 $item->{ReservedForSurname} = $p->surname;
407 $item->{ReservedForFirstname} = $p->firstname;
408 $item->{ExpectedAtLibrary} = $first_hold->branchcode;
409 $item->{waitingdate} = $first_hold->waitingdate;
412 # Management of the notforloan document
413 if ( $item->{notforloan} ) {
414 $item->{backgroundcolor} = 'other';
415 $item->{notforloanvalue} =
416 $notforloan_label_of->{ $item->{notforloan} };
419 # Management of lost or long overdue items
420 if ( $item->{itemlost} ) {
422 # FIXME localized strings should never be in Perl code
423 $item->{message} =
424 $item->{itemlost} == 1 ? "(lost)"
425 : $item->{itemlost} == 2 ? "(long overdue)"
426 : "";
427 $item->{backgroundcolor} = 'other';
428 if ($logged_in_patron->category->hidelostitems && !$showallitems) {
429 $item->{hide} = 1;
430 $hiddencount++;
434 # Check the transit status
435 my ( $transfertwhen, $transfertfrom, $transfertto ) =
436 GetTransfers($itemnumber);
438 if ( defined $transfertwhen && $transfertwhen ne '' ) {
439 $item->{transfertwhen} = output_pref({ dt => dt_from_string( $transfertwhen ), dateonly => 1 });
440 $item->{transfertfrom} = $transfertfrom;
441 $item->{transfertto} = $transfertto;
442 $item->{nocancel} = 1;
445 # If there is no loan, return and transfer, we show a checkbox.
446 $item->{notforloan} ||= 0;
448 # if independent branches is on we need to check if the person can reserve
449 # for branches they arent logged in to
450 if ( C4::Context->preference("IndependentBranches") ) {
451 if (! C4::Context->preference("canreservefromotherbranches")){
452 # cant reserve items so need to check if item homebranch and userenv branch match if not we cant reserve
453 my $userenv = C4::Context->userenv;
454 unless ( C4::Context->IsSuperLibrarian ) {
455 $item->{cantreserve} = 1 if ( $item->{homebranch} ne $userenv->{branch} );
460 if ( $patron ) {
461 my $patron_unblessed = $patron->unblessed;
462 my $branch = C4::Circulation::_GetCircControlBranch($item, $patron_unblessed);
464 my $branchitemrule = GetBranchItemRule( $branch, $item->{'itype'} );
466 $item->{'holdallowed'} = $branchitemrule->{'holdallowed'};
468 my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber );
469 $item->{not_holdable} = $can_item_be_reserved unless ( $can_item_be_reserved eq 'OK' );
471 $item->{item_level_holds} = OPACItemHoldsAllowed( $item, $patron_unblessed);
473 if (
474 !$item->{cantreserve}
475 && !$exceeded_maxreserves
476 && IsAvailableForItemLevelRequest($item, $patron_unblessed)
477 && $can_item_be_reserved eq 'OK'
480 $item->{available} = 1;
481 $num_available++;
483 push( @available_itemtypes, $item->{itype} );
485 elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) {
486 # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
487 $item->{override} = 1;
488 $num_override++;
491 # If none of the conditions hold true, then neither override nor available is set and the item cannot be checked
493 # Show serial enumeration when needed
494 if ($item->{enumchron}) {
495 $itemdata_enumchron = 1;
499 push @{ $biblioitem->{itemloop} }, $item;
502 if ( $num_override == scalar( @{ $biblioitem->{itemloop} } ) ) { # That is, if all items require an override
503 $template->param( override_required => 1 );
504 } elsif ( $num_available == 0 ) {
505 $template->param( none_available => 1 );
506 $biblioloopiter{warn} = 1;
507 $biblioloopiter{none_avail} = 1;
509 $template->param( hiddencount => $hiddencount);
511 push @bibitemloop, $biblioitem;
514 @available_itemtypes = uniq( @available_itemtypes );
515 $template->param( available_itemtypes => \@available_itemtypes );
517 # existingreserves building
518 my @reserveloop;
519 my @reserves = Koha::Holds->search( { biblionumber => $biblionumber }, { order_by => 'priority' } );
520 foreach my $res (
521 sort {
522 my $a_found = $a->found() || '';
523 my $b_found = $a->found() || '';
524 $a_found cmp $b_found;
525 } @reserves
528 my $priority = $res->priority();
529 my %reserve;
530 my @optionloop;
531 for ( my $i = 1 ; $i <= $totalcount ; $i++ ) {
532 push(
533 @optionloop,
535 num => $i,
536 selected => ( $i == $priority ),
541 if ( $res->is_found() ) {
542 $reserve{'holdingbranch'} = $res->item()->holdingbranch();
543 $reserve{'biblionumber'} = $res->item()->biblionumber();
544 $reserve{'barcodenumber'} = $res->item()->barcode();
545 $reserve{'wbrcode'} = $res->branchcode();
546 $reserve{'itemnumber'} = $res->itemnumber();
547 $reserve{'wbrname'} = $res->branch()->branchname();
549 if ( $reserve{'holdingbranch'} eq $reserve{'wbrcode'} ) {
551 # Just because the holdingbranch matches the reserve branch doesn't mean the item
552 # has arrived at the destination, check for an open transfer for the item as well
553 my ( $transfertwhen, $transfertfrom, $transferto ) =
554 C4::Circulation::GetTransfers( $res->itemnumber() );
555 if ( not $transferto or $transferto ne $res->branchcode() ) {
556 $reserve{'atdestination'} = 1;
560 # set found to 1 if reserve is waiting for patron pickup
561 $reserve{'found'} = $res->is_found();
562 $reserve{'intransit'} = $res->is_in_transit();
564 elsif ( $res->priority() > 0 ) {
565 if ( my $item = $res->item() ) {
566 $reserve{'itemnumber'} = $item->id();
567 $reserve{'barcodenumber'} = $item->barcode();
568 $reserve{'item_level_hold'} = 1;
572 # get borrowers reserve info
573 if ( C4::Context->preference('HidePatronName') ) {
574 $reserve{'hidename'} = 1;
575 $reserve{'cardnumber'} = $res->borrower()->cardnumber();
577 $reserve{'expirationdate'} = output_pref( { dt => dt_from_string( $res->expirationdate ), dateonly => 1 } )
578 unless ( !defined( $res->expirationdate ) || $res->expirationdate eq '0000-00-00' );
579 $reserve{'date'} = output_pref( { dt => dt_from_string( $res->reservedate ), dateonly => 1 } );
580 $reserve{'borrowernumber'} = $res->borrowernumber();
581 $reserve{'biblionumber'} = $res->biblionumber();
582 $reserve{'borrowernumber'} = $res->borrowernumber();
583 $reserve{'firstname'} = $res->borrower()->firstname();
584 $reserve{'surname'} = $res->borrower()->surname();
585 $reserve{'notes'} = $res->reservenotes();
586 $reserve{'waiting_date'} = $res->waitingdate();
587 $reserve{'ccode'} = $res->item() ? $res->item()->ccode() : undef;
588 $reserve{'barcode'} = $res->item() ? $res->item()->barcode() : undef;
589 $reserve{'priority'} = $res->priority();
590 $reserve{'lowestPriority'} = $res->lowestPriority();
591 $reserve{'optionloop'} = \@optionloop;
592 $reserve{'suspend'} = $res->suspend();
593 $reserve{'suspend_until'} = $res->suspend_until();
594 $reserve{'reserve_id'} = $res->reserve_id();
595 $reserve{itemtype} = $res->itemtype();
596 $reserve{branchcode} = $res->branchcode();
598 push( @reserveloop, \%reserve );
601 # get the time for the form name...
602 my $time = time();
604 $template->param(
605 time => $time,
606 fixedRank => $fixedRank,
609 # display infos
610 $template->param(
611 optionloop => \@optionloop,
612 bibitemloop => \@bibitemloop,
613 itemdata_enumchron => $itemdata_enumchron,
614 date => $date,
615 biblionumber => $biblionumber,
616 findborrower => $findborrower,
617 title => $biblio->title,
618 author => $biblio->author,
619 holdsview => 1,
620 C4::Search::enabled_staff_search_views,
622 if ( $patron ) {
623 $template->param( borrower_branchcode => $patron->branchcode );
626 $biblioloopiter{biblionumber} = $biblionumber;
627 $biblioloopiter{title} = $biblio->title;
628 $biblioloopiter{rank} = $fixedRank;
629 $biblioloopiter{reserveloop} = \@reserveloop;
631 if (@reserveloop) {
632 $template->param( reserveloop => \@reserveloop );
635 push @biblioloop, \%biblioloopiter;
638 $template->param( biblioloop => \@biblioloop );
639 $template->param( biblionumbers => $biblionumbers );
640 $template->param( exceeded_maxreserves => $exceeded_maxreserves );
641 $template->param( exceeded_holds_per_record => $exceeded_holds_per_record );
643 if ($multihold) {
644 $template->param( multi_hold => 1 );
647 if ( C4::Context->preference( 'AllowHoldDateInFuture' ) ) {
648 $template->param( reserve_in_future => 1 );
651 $template->param(
652 SuspendHoldsIntranet => C4::Context->preference('SuspendHoldsIntranet'),
653 AutoResumeSuspendedHolds => C4::Context->preference('AutoResumeSuspendedHolds'),
656 # printout the page
657 output_html_with_http_headers $input, $cookie, $template->output;
659 sub sort_borrowerlist {
660 my $borrowerslist = shift;
661 my $ref = [];
662 push @{$ref}, sort {
663 uc( $a->{surname} . $a->{firstname} ) cmp
664 uc( $b->{surname} . $b->{firstname} )
665 } @{$borrowerslist};
666 return $ref;