3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
20 use Test
::More tests
=> 7;
23 use List
::MoreUtils
qw( uniq );
25 use t
::lib
::Mocks
qw( mock_preference );
33 my $schema = Koha
::Database
->new->schema;
34 $schema->storage->txn_begin;
35 my $dbh = C4
::Context
->dbh;
37 subtest
'GetMarcSubfieldStructureFromKohaField' => sub {
41 tagfield tagsubfield liblibrarian libopac repeatable mandatory kohafield tab
42 authorised_value authtypecode value_builder isurl hidden frameworkcode
43 seealso link defaultvalue maxlength
46 # biblio.biblionumber must be mapped so this should return something
47 my $marc_subfield_structure = GetMarcSubfieldStructureFromKohaField
('biblio.biblionumber', '');
49 ok
(defined $marc_subfield_structure, "There is a result");
50 is
(ref $marc_subfield_structure, "HASH", "Result is a hashref");
51 foreach my $col (@columns) {
52 ok
(exists $marc_subfield_structure->{$col}, "Hashref contains key '$col'");
54 is
($marc_subfield_structure->{kohafield
}, 'biblio.biblionumber', "Result is the good result");
55 like
($marc_subfield_structure->{tagfield
}, qr/^\d{3}$/, "tagfield is a valid tagfield");
57 # foo.bar does not exist so this should return undef
58 $marc_subfield_structure = GetMarcSubfieldStructureFromKohaField
('foo.bar', '');
59 is
($marc_subfield_structure, undef, "invalid kohafield returns undef");
64 my $biblio_module = new Test
::MockModule
('C4::Biblio');
66 'GetMarcSubfieldStructure',
70 my ( $title_field, $title_subfield ) = get_title_field
();
71 my ( $isbn_field, $isbn_subfield ) = get_isbn_field
();
72 my ( $issn_field, $issn_subfield ) = get_issn_field
();
73 my ( $biblionumber_field, $biblionumber_subfield ) = ( '999', 'c' );
74 my ( $biblioitemnumber_field, $biblioitemnumber_subfield ) = ( '999', '9' );
75 my ( $itemnumber_field, $itemnumber_subfield ) = get_itemnumber_field
();
78 'biblio.title' => { tagfield
=> $title_field, tagsubfield
=> $title_subfield },
79 'biblio.biblionumber' => { tagfield
=> $biblionumber_field, tagsubfield
=> $biblionumber_subfield },
80 'biblioitems.isbn' => { tagfield
=> $isbn_field, tagsubfield
=> $isbn_subfield },
81 'biblioitems.issn' => { tagfield
=> $issn_field, tagsubfield
=> $issn_subfield },
82 'biblioitems.biblioitemnumber' => { tagfield
=> $biblioitemnumber_field, tagsubfield
=> $biblioitemnumber_subfield },
83 'items.itemnumber' => { tagfield
=> $itemnumber_subfield, tagsubfield
=> $itemnumber_subfield },
88 my $currency = new Test
::MockModule
('Koha::Acquisition::Currencies');
92 return Koha
::Acquisition
::Currency
->new(
104 my $marcflavour = shift;
105 t
::lib
::Mocks
::mock_preference
('marcflavour', $marcflavour);
107 my $isbn = '0590353403';
108 my $title = 'Foundation';
110 # Generate a record with just the ISBN
111 my $marc_record = MARC
::Record
->new;
112 $marc_record->append_fields( create_isbn_field
( $isbn, $marcflavour ) );
114 # Add the record to the DB
115 my( $biblionumber, $biblioitemnumber ) = AddBiblio
( $marc_record, '' );
116 my $data = GetBiblioData
( $biblionumber );
117 is
( $data->{ isbn
}, $isbn,
118 '(GetBiblioData) ISBN correctly retireved.');
119 is
( $data->{ title
}, undef,
120 '(GetBiblioData) Title field is empty in fresh biblio.');
122 my ( $isbn_field, $isbn_subfield ) = get_isbn_field
();
123 my $marc = GetMarcBiblio
( $biblionumber );
124 is
( $marc->subfield( $isbn_field, $isbn_subfield ), $isbn, );
127 my $field = create_title_field
( $title, $marcflavour );
128 $marc_record->append_fields( $field );
129 ModBiblio
( $marc_record, $biblionumber ,'' );
130 $data = GetBiblioData
( $biblionumber );
131 is
( $data->{ title
}, $title,
132 'ModBiblio correctly added the title field, and GetBiblioData.');
133 is
( $data->{ isbn
}, $isbn, '(ModBiblio) ISBN is still there after ModBiblio.');
134 $marc = GetMarcBiblio
( $biblionumber );
135 my ( $title_field, $title_subfield ) = get_title_field
();
136 is
( $marc->subfield( $title_field, $title_subfield ), $title, );
138 my $itemdata = GetBiblioItemData
( $biblioitemnumber );
139 is
( $itemdata->{ title
}, $title,
140 'First test of GetBiblioItemData to get same result of previous two GetBiblioData tests.');
141 is
( $itemdata->{ isbn
}, $isbn,
142 'Second test checking it returns the correct isbn.');
145 $field = MARC
::Field
->new(
147 'a' => 'Auction catalogs',
151 $marc_record->append_fields($field);
152 $success = ModBiblio
($marc_record,$biblionumber,'');
157 ok
($success, "ModBiblio handles authority-linked 655");
160 $field->delete_subfields('a');
161 $marc_record->append_fields($field);
162 $success = ModBiblio
($marc_record,$biblionumber,'');
167 ok
($success, "ModBiblio handles 655 with authority link but no heading");
170 $field->delete_subfields('9');
171 $marc_record->append_fields($field);
172 $success = ModBiblio
($marc_record,$biblionumber,'');
177 ok
($success, "ModBiblio handles 655 with no subfields");
179 ## Testing GetMarcISSN
181 $issns = GetMarcISSN
( $marc_record, $marcflavour );
182 is
( $issns->[0], undef,
183 'GetMarcISSN handles records without the ISSN field (list is empty)' );
184 is
( scalar @
$issns, 0,
185 'GetMarcISSN handles records without the ISSN field (count is 0)' );
187 my $issn = '1234-1234';
188 $field = create_issn_field
( $issn, $marcflavour );
189 $marc_record->append_fields($field);
190 $issns = GetMarcISSN
( $marc_record, $marcflavour );
191 is
( $issns->[0], $issn,
192 'GetMarcISSN handles records with a single ISSN field (first element is correct)' );
193 is
( scalar @
$issns, 1,
194 'GetMARCISSN handles records with a single ISSN field (count is 1)');
195 # Add multiple ISSN field
196 my @more_issns = qw
/1111-1111 2222-2222 3333-3333/;
197 foreach (@more_issns) {
198 $field = create_issn_field
( $_, $marcflavour );
199 $marc_record->append_fields($field);
201 $issns = GetMarcISSN
( $marc_record, $marcflavour );
202 is
( scalar @
$issns, 4,
203 'GetMARCISSN handles records with multiple ISSN fields (count correct)');
204 # Create an empty ISSN
205 $field = create_issn_field
( "", $marcflavour );
206 $marc_record->append_fields($field);
207 $issns = GetMarcISSN
( $marc_record, $marcflavour );
208 is
( scalar @
$issns, 4,
209 'GetMARCISSN skips empty ISSN fields (Bug 12674)');
211 ## Testing GetMarcControlnumber
213 $controlnumber = GetMarcControlnumber
( $marc_record, $marcflavour );
214 is
( $controlnumber, '', 'GetMarcControlnumber handles records without 001' );
216 $field = MARC
::Field
->new( '001', '' );
217 $marc_record->append_fields($field);
218 $controlnumber = GetMarcControlnumber
( $marc_record, $marcflavour );
219 is
( $controlnumber, '', 'GetMarcControlnumber handles records with empty 001' );
221 $field = $marc_record->field('001');
222 $field->update('123456789X');
223 $controlnumber = GetMarcControlnumber
( $marc_record, $marcflavour );
224 is
( $controlnumber, '123456789X', 'GetMarcControlnumber handles records with 001' );
226 ## Testing GetMarcISBN
227 my $record_for_isbn = MARC
::Record
->new();
228 my $isbns = GetMarcISBN
( $record_for_isbn, $marcflavour );
229 is
( scalar @
$isbns, 0, '(GetMarcISBN) The record contains no ISBN');
232 $isbn_field = create_isbn_field
( $isbn, $marcflavour );
233 $record_for_isbn->append_fields( $isbn_field );
234 $isbns = GetMarcISBN
( $record_for_isbn, $marcflavour );
235 is
( scalar @
$isbns, 1, '(GetMarcISBN) The record contains one ISBN');
236 is
( $isbns->[0], $isbn, '(GetMarcISBN) The record contains our ISBN');
238 # We add 3 more ISBNs
239 $record_for_isbn = MARC
::Record
->new();
240 my @more_isbns = qw
/1111111111 2222222222 3333333333 444444444/;
241 foreach (@more_isbns) {
242 $field = create_isbn_field
( $_, $marcflavour );
243 $record_for_isbn->append_fields($field);
245 $isbns = GetMarcISBN
( $record_for_isbn, $marcflavour );
246 is
( scalar @
$isbns, 4, '(GetMarcISBN) The record contains 4 ISBNs');
247 for my $i (0 .. $#more_isbns) {
248 is
( $isbns->[$i], $more_isbns[$i],
249 "(GetMarcISBN) Correctly retrieves ISBN #". ($i + 1));
252 is
( GetMarcPrice
( $record_for_isbn, $marcflavour ), 100,
253 "GetMarcPrice returns the correct value");
254 my $newincbiblioitemnumber=$biblioitemnumber+1;
255 $dbh->do("UPDATE biblioitems SET biblioitemnumber = ? WHERE biblionumber = ?;", undef, $newincbiblioitemnumber, $biblionumber );
256 my $updatedrecord = GetMarcBiblio
($biblionumber, 0);
257 my $frameworkcode = GetFrameworkCode
($biblionumber);
258 my ( $biblioitem_tag, $biblioitem_subfield ) = GetMarcFromKohaField
( "biblioitems.biblioitemnumber", $frameworkcode );
259 die qq{No biblioitemnumber tag
for framework
"$frameworkcode"} unless $biblioitem_tag;
260 my $biblioitemnumbertotest;
261 if ( $biblioitem_tag < 10 ) {
262 $biblioitemnumbertotest = $updatedrecord->field($biblioitem_tag)->data();
264 $biblioitemnumbertotest = $updatedrecord->field($biblioitem_tag)->subfield($biblioitem_subfield);
266 is
($newincbiblioitemnumber, $biblioitemnumbertotest, 'Check newincbiblioitemnumber');
268 # test for GetMarcNotes
269 my $a1= GetMarcNotes
( $marc_record, $marcflavour );
270 my $field2 = MARC
::Field
->new( $marcflavour eq 'UNIMARC'?
300: 555, 0, '', a
=> 'Some text', u
=> 'http://url-1.com', u
=> 'nohttp://something_else' );
271 $marc_record->append_fields( $field2 );
272 my $a2= GetMarcNotes
( $marc_record, $marcflavour );
273 is
( ( $marcflavour eq 'UNIMARC' && @
$a2 == @
$a1 + 1 ) ||
274 ( $marcflavour ne 'UNIMARC' && @
$a2 == @
$a1 + 3 ), 1,
275 'Check the number of returned notes of GetMarcNotes' );
277 # test for GetMarcUrls
278 $marc_record->append_fields(
279 MARC
::Field
->new( '856', '', '', u
=> ' https://koha-community.org ' ),
280 MARC
::Field
->new( '856', '', '', u
=> 'koha-community.org' ),
282 my $marcurl = GetMarcUrls
( $marc_record, $marcflavour );
283 is
( @
$marcurl, 2, 'GetMarcUrls returns two URLs' );
284 like
( $marcurl->[0]->{MARCURL
}, qr/^https/, 'GetMarcUrls did not stumble over a preceding space' );
285 ok
( $marcflavour ne 'MARC21' || $marcurl->[1]->{MARCURL
} =~ /^http:\/\
//,
286 'GetMarcUrls prefixed a MARC21 URL with http://' );
289 sub get_title_field
{
290 my $marc_flavour = C4
::Context
->preference('marcflavour');
291 return ( $marc_flavour eq 'UNIMARC' ) ?
( '200', 'a' ) : ( '245', 'a' );
295 my $marc_flavour = C4
::Context
->preference('marcflavour');
296 return ( $marc_flavour eq 'UNIMARC' ) ?
( '010', 'a' ) : ( '020', 'a' );
300 my $marc_flavour = C4
::Context
->preference('marcflavour');
301 return ( $marc_flavour eq 'UNIMARC' ) ?
( '011', 'a' ) : ( '022', 'a' );
304 sub get_itemnumber_field
{
305 my $marc_flavour = C4
::Context
->preference('marcflavour');
306 return ( $marc_flavour eq 'UNIMARC' ) ?
( '995', '9' ) : ( '952', '9' );
309 sub create_title_field
{
310 my ( $title, $marcflavour ) = @_;
312 my ( $title_field, $title_subfield ) = get_title_field
();
313 my $field = MARC
::Field
->new( $title_field, '', '', $title_subfield => $title );
318 sub create_isbn_field
{
319 my ( $isbn, $marcflavour ) = @_;
321 my ( $isbn_field, $isbn_subfield ) = get_isbn_field
();
322 my $field = MARC
::Field
->new( $isbn_field, '', '', $isbn_subfield => $isbn );
324 # Add the price subfield
325 my $price_subfield = ( $marcflavour eq 'UNIMARC' ) ?
'd' : 'c';
326 $field->add_subfields( $price_subfield => '$100' );
331 sub create_issn_field
{
332 my ( $issn, $marcflavour ) = @_;
334 my ( $issn_field, $issn_subfield ) = get_issn_field
();
335 my $field = MARC
::Field
->new( $issn_field, '', '', $issn_subfield => $issn );
340 subtest
'MARC21' => sub {
343 $schema->storage->txn_rollback;
344 $schema->storage->txn_begin;
347 subtest
'UNIMARC' => sub {
349 run_tests
('UNIMARC');
350 $schema->storage->txn_rollback;
351 $schema->storage->txn_begin;
354 subtest
'NORMARC' => sub {
356 run_tests
('NORMARC');
357 $schema->storage->txn_rollback;
358 $schema->storage->txn_begin;
361 subtest
'IsMarcStructureInternal' => sub {
363 my $tagslib = GetMarcStructure
();
365 for my $tag ( sort keys %$tagslib ) {
367 for my $subfield ( sort keys %{ $tagslib->{$tag} } ) {
368 push @internals, $subfield if IsMarcStructureInternal
($tagslib->{$tag}{$subfield});
371 @internals = uniq
@internals;
372 is
( scalar(@internals), 4, 'expect four internals');
373 is
( grep( /^lib$/, @internals ), 1, 'check lib' );
374 is
( grep( /^tab$/, @internals ), 1, 'check tab' );
375 is
( grep( /^mandatory$/, @internals ), 1, 'check mandatory' );
376 is
( grep( /^repeatable$/, @internals ), 1, 'check repeatable' );
377 is
( grep( /^a$/, @internals ), 0, 'no subfield a' );
380 subtest
'deletedbiblio_metadata' => sub {
383 my ($biblionumber, $biblioitemnumber) = AddBiblio
(MARC
::Record
->new, '');
384 my $biblio_metadata = C4
::Biblio
::GetXmlBiblio
( $biblionumber );
385 C4
::Biblio
::DelBiblio
( $biblionumber );
386 my ( $moved ) = $dbh->selectrow_array(q
|SELECT biblionumber FROM deletedbiblio WHERE biblionumber
=?
|, undef, $biblionumber);
387 is
( $moved, $biblionumber, 'Found in deletedbiblio' );
388 ( $moved ) = $dbh->selectrow_array(q
|SELECT biblionumber FROM deletedbiblio_metadata WHERE biblionumber
=?
|, undef, $biblionumber);
389 is
( $moved, $biblionumber, 'Found in deletedbiblio_metadata' );