Bug 11046: Add the form YYY-? for uncertain years
[koha.git] / reserve / request.pl
blob7a60b857bceff87fa6c6e21da29250e3dd0b500f
1 #!/usr/bin/perl
4 #written 2/1/00 by chris@katipo.oc.nz
5 # Copyright 2000-2002 Katipo Communications
6 # Parts Copyright 2011 Catalyst IT
8 # This file is part of Koha.
10 # Koha is free software; you can redistribute it and/or modify it
11 # under the terms of the GNU General Public License as published by
12 # the Free Software Foundation; either version 3 of the License, or
13 # (at your option) any later version.
15 # Koha is distributed in the hope that it will be useful, but
16 # WITHOUT ANY WARRANTY; without even the implied warranty of
17 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18 # GNU General Public License for more details.
20 # You should have received a copy of the GNU General Public License
21 # along with Koha; if not, see <http://www.gnu.org/licenses>.
23 =head1 request.pl
25 script to place reserves/requests
27 =cut
29 use Modern::Perl;
31 use CGI qw ( -utf8 );
32 use List::MoreUtils qw/uniq/;
33 use Date::Calc qw/Date_to_Days/;
34 use C4::Output;
35 use C4::Auth;
36 use C4::Reserves;
37 use C4::Biblio;
38 use C4::Items;
39 use C4::Koha;
40 use C4::Circulation;
41 use Koha::DateUtils;
42 use C4::Utils::DataTables::Members;
43 use C4::Members;
44 use C4::Search; # enabled_staff_search_views
46 use Koha::Biblios;
47 use Koha::DateUtils;
48 use Koha::Checkouts;
49 use Koha::Holds;
50 use Koha::IssuingRules;
51 use Koha::Items;
52 use Koha::ItemTypes;
53 use Koha::Libraries;
54 use Koha::Patrons;
56 my $dbh = C4::Context->dbh;
57 my $input = new CGI;
58 my ( $template, $borrowernumber, $cookie, $flags ) = get_template_and_user(
60 template_name => "reserve/request.tt",
61 query => $input,
62 type => "intranet",
63 authnotrequired => 0,
64 flagsrequired => { reserveforothers => 'place_holds' },
68 my $multihold = $input->param('multi_hold');
69 $template->param(multi_hold => $multihold);
70 my $showallitems = $input->param('showallitems');
72 my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } };
74 # Select borrowers infos
75 my $findborrower = $input->param('findborrower');
76 $findborrower = '' unless defined $findborrower;
77 $findborrower =~ s|,| |g;
78 my $borrowernumber_hold = $input->param('borrowernumber') || '';
79 my $messageborrower;
80 my $warnings;
81 my $messages;
82 my $exceeded_maxreserves;
83 my $exceeded_holds_per_record;
85 my $date = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 });
86 my $action = $input->param('action');
87 $action ||= q{};
89 if ( $action eq 'move' ) {
90 my $where = $input->param('where');
91 my $reserve_id = $input->param('reserve_id');
92 AlterPriority( $where, $reserve_id );
93 } elsif ( $action eq 'cancel' ) {
94 my $reserve_id = $input->param('reserve_id');
95 my $hold = Koha::Holds->find( $reserve_id );
96 $hold->cancel if $hold;
97 } elsif ( $action eq 'setLowestPriority' ) {
98 my $reserve_id = $input->param('reserve_id');
99 ToggleLowestPriority( $reserve_id );
100 } elsif ( $action eq 'toggleSuspend' ) {
101 my $reserve_id = $input->param('reserve_id');
102 my $suspend_until = $input->param('suspend_until');
103 ToggleSuspend( $reserve_id, $suspend_until );
106 if ($findborrower) {
107 my $patron = Koha::Patrons->find( { cardnumber => $findborrower } );
108 if ( $patron ) {
109 $borrowernumber_hold = $patron->borrowernumber;
110 } else {
111 my $dt_params = { iDisplayLength => -1 };
112 my $results = C4::Utils::DataTables::Members::search(
114 searchmember => $findborrower,
115 dt_params => $dt_params,
118 my $borrowers = $results->{patrons};
119 if ( scalar @$borrowers == 1 ) {
120 $borrowernumber_hold = $borrowers->[0]->{borrowernumber};
121 } elsif ( @$borrowers ) {
122 $template->param( borrowers => $borrowers );
123 } else {
124 $messageborrower = "'$findborrower'";
129 my @biblionumbers = ();
130 my $biblionumbers = $input->param('biblionumbers');
131 if ($multihold) {
132 @biblionumbers = split '/', $biblionumbers;
133 } else {
134 push @biblionumbers, $input->multi_param('biblionumber');
138 # If we have the borrowernumber because we've performed an action, then we
139 # don't want to try to place another reserve.
140 if ($borrowernumber_hold && !$action) {
141 my $patron = Koha::Patrons->find( $borrowernumber_hold );
142 my $diffbranch;
144 # we check the reserves of the user, and if they can reserve a document
145 # FIXME At this time we have a simple count of reservs, but, later, we could improve the infos "title" ...
147 my $reserves_count = $patron->holds->count;
149 my $new_reserves_count = scalar( @biblionumbers );
151 my $maxreserves = C4::Context->preference('maxreserves');
152 if ( $maxreserves
153 && ( $reserves_count + $new_reserves_count > $maxreserves ) )
155 my $new_reserves_allowed =
156 $maxreserves - $reserves_count > 0
157 ? $maxreserves - $reserves_count
158 : 0;
159 $warnings = 1;
160 $exceeded_maxreserves = 1;
161 $template->param(
162 new_reserves_allowed => $new_reserves_allowed,
163 new_reserves_count => $new_reserves_count,
164 reserves_count => $reserves_count,
165 maxreserves => $maxreserves,
169 # we check the date expiry of the borrower (only if there is an expiry date, otherwise, set to 1 (warn)
170 my $expiry_date = $patron->dateexpiry;
171 my $expiry = 0; # flag set if patron account has expired
172 if ($expiry_date and $expiry_date ne '0000-00-00' and
173 Date_to_Days(split /-/,$date) > Date_to_Days(split /-/,$expiry_date)) {
174 $expiry = 1;
177 # check if the borrower make the reserv in a different branch
178 if ( $patron->branchcode ne C4::Context->userenv->{'branch'} ) {
179 $diffbranch = 1;
182 my $is_debarred = $patron->is_debarred;
183 $template->param(
184 borrowernumber => $patron->borrowernumber,
185 borrowersurname => $patron->surname,
186 borrowerfirstname => $patron->firstname,
187 borrowerstreetaddress => $patron->address,
188 borrowercity => $patron->city,
189 borrowerphone => $patron->phone,
190 borrowermobile => $patron->mobile,
191 borrowerfax => $patron->fax,
192 borrowerphonepro => $patron->phonepro,
193 borroweremail => $patron->email,
194 borroweremailpro => $patron->emailpro,
195 cardnumber => $patron->cardnumber,
196 expiry => $expiry,
197 diffbranch => $diffbranch,
198 messages => $messages,
199 warnings => $warnings,
200 restricted => $is_debarred,
201 amount_outstanding => GetMemberAccountRecords($patron->borrowernumber),
205 $template->param( messageborrower => $messageborrower );
207 # FIXME launch another time GetMember perhaps until (Joubu: Why?)
208 my $patron = Koha::Patrons->find( $borrowernumber_hold );
210 my $logged_in_patron = Koha::Patrons->find( $borrowernumber );
212 my $itemdata_enumchron = 0;
213 my @biblioloop = ();
214 foreach my $biblionumber (@biblionumbers) {
215 next unless $biblionumber =~ m|^\d+$|;
217 my %biblioloopiter = ();
219 my $biblio = Koha::Biblios->find( $biblionumber );
221 my $force_hold_level;
222 if ( $patron ) {
223 { # CanBookBeReserved
224 my $canReserve = CanBookBeReserved( $patron->borrowernumber, $biblionumber );
225 $canReserve //= '';
226 if ( $canReserve eq 'OK' ) {
228 #All is OK and we can continue
230 elsif ( $canReserve eq 'tooManyReserves' ) {
231 $exceeded_maxreserves = 1;
233 elsif ( $canReserve eq 'tooManyHoldsForThisRecord' ) {
234 $exceeded_holds_per_record = 1;
235 $biblioloopiter{$canReserve} = 1;
237 elsif ( $canReserve eq 'ageRestricted' ) {
238 $template->param( $canReserve => 1 );
239 $biblioloopiter{$canReserve} = 1;
241 else {
242 $biblioloopiter{$canReserve} = 1;
246 # For multiple holds per record, if a patron has previously placed a hold,
247 # the patron can only place more holds of the same type. That is, if the
248 # patron placed a record level hold, all the holds the patron places must
249 # be record level. If the patron placed an item level hold, all holds
250 # the patron places must be item level
251 my $holds = Koha::Holds->search(
253 borrowernumber => $patron->borrowernumber,
254 biblionumber => $biblionumber,
255 found => undef,
258 $force_hold_level = $holds->forced_hold_level();
259 $biblioloopiter{force_hold_level} = $force_hold_level;
260 $template->param( force_hold_level => $force_hold_level );
262 # For a librarian to be able to place multiple record holds for a patron for a record,
263 # we must find out what the maximum number of holds they can place for the patron is
264 my $max_holds_for_record = GetMaxPatronHoldsForRecord( $patron->borrowernumber, $biblionumber );
265 my $remaining_holds_for_record = $max_holds_for_record - $holds->count();
266 $biblioloopiter{remaining_holds_for_record} = $max_holds_for_record;
267 $template->param( max_holds_for_record => $max_holds_for_record );
268 $template->param( remaining_holds_for_record => $remaining_holds_for_record );
270 { # alreadypossession
271 # Check to see if patron is allowed to place holds on records where the
272 # patron already has an item from that record checked out
273 if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions')
274 && CheckIfIssuedToPatron( $patron->borrowernumber, $biblionumber ) )
276 $template->param( alreadypossession => 1, );
282 my $count = Koha::Holds->search( { biblionumber => $biblionumber } )->count();
283 my $totalcount = $count;
285 # FIXME think @optionloop, is maybe obsolete, or must be switchable by a systeme preference fixed rank or not
286 # make priorities options
288 my @optionloop;
289 for ( 1 .. $count + 1 ) {
290 push(
291 @optionloop,
293 num => $_,
294 selected => ( $_ == $count + 1 ),
298 # adding a fixed value for priority options
299 my $fixedRank = $count+1;
301 my %itemnumbers_of_biblioitem;
303 my @hostitems = get_hostitemnumbers_of($biblionumber);
304 my @itemnumbers;
305 if (@hostitems){
306 $template->param('hostitemsflag' => 1);
307 push(@itemnumbers, @hostitems);
310 my $items = Koha::Items->search({ -or => { biblionumber => $biblionumber, itemnumber => { in => \@itemnumbers } } });
312 unless ( $items->count ) {
313 # FIXME Then why do we continue?
314 $template->param('noitems' => 1);
315 $biblioloopiter{noitems} = 1;
318 ## Here we go backwards again to create hash of biblioitemnumber to itemnumbers,
319 ## when by definition all of the itemnumber have the same biblioitemnumber
320 my ( $iteminfos_of );
321 while ( my $item = $items->next ) {
322 $item = $item->unblessed;
323 my $biblioitemnumber = $item->{biblioitemnumber};
324 my $itemnumber = $item->{itemnumber};
325 push( @{ $itemnumbers_of_biblioitem{$biblioitemnumber} }, $itemnumber );
326 $iteminfos_of->{$itemnumber} = $item;
329 ## Should be same as biblionumber
330 my @biblioitemnumbers = keys %itemnumbers_of_biblioitem;
332 ## Hash of biblioitemnumber to 'biblioitem' table records
333 my $biblioiteminfos_of = GetBiblioItemInfosOf(@biblioitemnumbers);
335 my $frameworkcode = GetFrameworkCode( $biblionumber );
336 my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode });
337 my $notforloan_label_of = { map { $_->authorised_value => $_->lib } @notforloan_avs };
339 my @bibitemloop;
341 my @available_itemtypes;
342 foreach my $biblioitemnumber (@biblioitemnumbers) {
343 my $biblioitem = $biblioiteminfos_of->{$biblioitemnumber};
344 my $num_available = 0;
345 my $num_override = 0;
346 my $hiddencount = 0;
348 $biblioitem->{force_hold_level} = $force_hold_level;
350 if ( $biblioitem->{biblioitemnumber} ne $biblionumber ) {
351 $biblioitem->{hostitemsflag} = 1;
354 $biblioloopiter{description} = $biblioitem->{description};
355 $biblioloopiter{itypename} = $biblioitem->{description};
356 if ( $biblioitem->{itemtype} ) {
358 $biblioitem->{description} =
359 $itemtypes->{ $biblioitem->{itemtype} }{description};
361 $biblioloopiter{imageurl} =
362 getitemtypeimagelocation( 'intranet',
363 $itemtypes->{ $biblioitem->{itemtype} }{imageurl} );
366 foreach my $itemnumber ( @{ $itemnumbers_of_biblioitem{$biblioitemnumber} } ) {
367 my $item = $iteminfos_of->{$itemnumber};
369 $item->{force_hold_level} = $force_hold_level;
371 unless (C4::Context->preference('item-level_itypes')) {
372 $item->{itype} = $biblioitem->{itemtype};
375 $item->{itypename} = $itemtypes->{ $item->{itype} }{description};
376 $item->{imageurl} = getitemtypeimagelocation( 'intranet', $itemtypes->{ $item->{itype} }{imageurl} );
377 $item->{homebranch} = $item->{homebranch};
379 # if the holdingbranch is different than the homebranch, we show the
380 # holdingbranch of the document too
381 if ( $item->{homebranch} ne $item->{holdingbranch} ) {
382 $item->{holdingbranch} = $item->{holdingbranch};
385 if($item->{biblionumber} ne $biblionumber){
386 $item->{hostitemsflag} = 1;
387 $item->{hosttitle} = Koha::Biblios->find( $item->{biblionumber} )->title;
390 # if the item is currently on loan, we display its return date and
391 # change the background color
392 my $issue = Koha::Checkouts->find( { itemnumber => $itemnumber } );
393 if ( $issue ) {
394 $item->{date_due} = $issue->date_due;
395 $item->{backgroundcolor} = 'onloan';
398 # checking reserve
399 my $item_object = Koha::Items->find( $itemnumber );
400 my $holds = $item_object->current_holds;
401 if ( my $first_hold = $holds->next ) {
402 my $p = Koha::Patrons->find( $first_hold->borrowernumber );
404 $item->{backgroundcolor} = 'reserved';
405 $item->{reservedate} = output_pref({ dt => dt_from_string( $first_hold->reservedate ), dateonly => 1 }); # FIXME Should be formatted in the template
406 $item->{ReservedForBorrowernumber} = $p->borrowernumber;
407 $item->{ReservedForSurname} = $p->surname;
408 $item->{ReservedForFirstname} = $p->firstname;
409 $item->{ExpectedAtLibrary} = $first_hold->branchcode;
410 $item->{waitingdate} = $first_hold->waitingdate;
413 # Management of the notforloan document
414 if ( $item->{notforloan} ) {
415 $item->{backgroundcolor} = 'other';
416 $item->{notforloanvalue} =
417 $notforloan_label_of->{ $item->{notforloan} };
420 # Management of lost or long overdue items
421 if ( $item->{itemlost} ) {
423 # FIXME localized strings should never be in Perl code
424 $item->{message} =
425 $item->{itemlost} == 1 ? "(lost)"
426 : $item->{itemlost} == 2 ? "(long overdue)"
427 : "";
428 $item->{backgroundcolor} = 'other';
429 if ($logged_in_patron->category->hidelostitems && !$showallitems) {
430 $item->{hide} = 1;
431 $hiddencount++;
435 # Check the transit status
436 my ( $transfertwhen, $transfertfrom, $transfertto ) =
437 GetTransfers($itemnumber);
439 if ( defined $transfertwhen && $transfertwhen ne '' ) {
440 $item->{transfertwhen} = output_pref({ dt => dt_from_string( $transfertwhen ), dateonly => 1 });
441 $item->{transfertfrom} = $transfertfrom;
442 $item->{transfertto} = $transfertto;
443 $item->{nocancel} = 1;
446 # If there is no loan, return and transfer, we show a checkbox.
447 $item->{notforloan} ||= 0;
449 # if independent branches is on we need to check if the person can reserve
450 # for branches they arent logged in to
451 if ( C4::Context->preference("IndependentBranches") ) {
452 if (! C4::Context->preference("canreservefromotherbranches")){
453 # cant reserve items so need to check if item homebranch and userenv branch match if not we cant reserve
454 my $userenv = C4::Context->userenv;
455 unless ( C4::Context->IsSuperLibrarian ) {
456 $item->{cantreserve} = 1 if ( $item->{homebranch} ne $userenv->{branch} );
461 if ( $patron ) {
462 my $patron_unblessed = $patron->unblessed;
463 my $branch = C4::Circulation::_GetCircControlBranch($item, $patron_unblessed);
465 my $branchitemrule = GetBranchItemRule( $branch, $item->{'itype'} );
467 $item->{'holdallowed'} = $branchitemrule->{'holdallowed'};
469 my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber );
470 $item->{not_holdable} = $can_item_be_reserved unless ( $can_item_be_reserved eq 'OK' );
472 $item->{item_level_holds} = Koha::IssuingRules->get_opacitemholds_policy( { item => $item_object, patron => $patron } );
474 if (
475 !$item->{cantreserve}
476 && !$exceeded_maxreserves
477 && IsAvailableForItemLevelRequest($item, $patron_unblessed)
478 && $can_item_be_reserved eq 'OK'
481 $item->{available} = 1;
482 $num_available++;
484 push( @available_itemtypes, $item->{itype} );
486 elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) {
487 # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
488 $item->{override} = 1;
489 $num_override++;
491 push( @available_itemtypes, $item->{itype} );
494 # If none of the conditions hold true, then neither override nor available is set and the item cannot be checked
496 # Show serial enumeration when needed
497 if ($item->{enumchron}) {
498 $itemdata_enumchron = 1;
502 push @{ $biblioitem->{itemloop} }, $item;
505 if ( $num_override == scalar( @{ $biblioitem->{itemloop} } ) ) { # That is, if all items require an override
506 $template->param( override_required => 1 );
507 } elsif ( $num_available == 0 ) {
508 $template->param( none_available => 1 );
509 $biblioloopiter{warn} = 1;
510 $biblioloopiter{none_avail} = 1;
512 $template->param( hiddencount => $hiddencount);
514 push @bibitemloop, $biblioitem;
517 @available_itemtypes = uniq( @available_itemtypes );
518 $template->param( available_itemtypes => \@available_itemtypes );
520 # existingreserves building
521 my @reserveloop;
522 my @reserves = Koha::Holds->search( { biblionumber => $biblionumber }, { order_by => 'priority' } );
523 foreach my $res (
524 sort {
525 my $a_found = $a->found() || '';
526 my $b_found = $a->found() || '';
527 $a_found cmp $b_found;
528 } @reserves
531 my $priority = $res->priority();
532 my %reserve;
533 my @optionloop;
534 for ( my $i = 1 ; $i <= $totalcount ; $i++ ) {
535 push(
536 @optionloop,
538 num => $i,
539 selected => ( $i == $priority ),
544 if ( $res->is_found() ) {
545 $reserve{'holdingbranch'} = $res->item()->holdingbranch();
546 $reserve{'biblionumber'} = $res->item()->biblionumber();
547 $reserve{'barcodenumber'} = $res->item()->barcode();
548 $reserve{'wbrcode'} = $res->branchcode();
549 $reserve{'itemnumber'} = $res->itemnumber();
550 $reserve{'wbrname'} = $res->branch()->branchname();
552 if ( $reserve{'holdingbranch'} eq $reserve{'wbrcode'} ) {
554 # Just because the holdingbranch matches the reserve branch doesn't mean the item
555 # has arrived at the destination, check for an open transfer for the item as well
556 my ( $transfertwhen, $transfertfrom, $transferto ) =
557 C4::Circulation::GetTransfers( $res->itemnumber() );
558 if ( not $transferto or $transferto ne $res->branchcode() ) {
559 $reserve{'atdestination'} = 1;
563 # set found to 1 if reserve is waiting for patron pickup
564 $reserve{'found'} = $res->is_found();
565 $reserve{'intransit'} = $res->is_in_transit();
567 elsif ( $res->priority() > 0 ) {
568 if ( my $item = $res->item() ) {
569 $reserve{'itemnumber'} = $item->id();
570 $reserve{'barcodenumber'} = $item->barcode();
571 $reserve{'item_level_hold'} = 1;
575 # get borrowers reserve info
576 if ( C4::Context->preference('HidePatronName') ) {
577 $reserve{'hidename'} = 1;
578 $reserve{'cardnumber'} = $res->borrower()->cardnumber();
580 $reserve{'expirationdate'} = output_pref( { dt => dt_from_string( $res->expirationdate ), dateonly => 1 } )
581 unless ( !defined( $res->expirationdate ) || $res->expirationdate eq '0000-00-00' );
582 $reserve{'date'} = output_pref( { dt => dt_from_string( $res->reservedate ), dateonly => 1 } );
583 $reserve{'borrowernumber'} = $res->borrowernumber();
584 $reserve{'biblionumber'} = $res->biblionumber();
585 $reserve{'borrowernumber'} = $res->borrowernumber();
586 $reserve{'firstname'} = $res->borrower()->firstname();
587 $reserve{'surname'} = $res->borrower()->surname();
588 $reserve{'notes'} = $res->reservenotes();
589 $reserve{'waiting_date'} = $res->waitingdate();
590 $reserve{'ccode'} = $res->item() ? $res->item()->ccode() : undef;
591 $reserve{'barcode'} = $res->item() ? $res->item()->barcode() : undef;
592 $reserve{'priority'} = $res->priority();
593 $reserve{'lowestPriority'} = $res->lowestPriority();
594 $reserve{'optionloop'} = \@optionloop;
595 $reserve{'suspend'} = $res->suspend();
596 $reserve{'suspend_until'} = $res->suspend_until();
597 $reserve{'reserve_id'} = $res->reserve_id();
598 $reserve{itemtype} = $res->itemtype();
599 $reserve{branchcode} = $res->branchcode();
601 push( @reserveloop, \%reserve );
604 # get the time for the form name...
605 my $time = time();
607 $template->param(
608 time => $time,
609 fixedRank => $fixedRank,
612 # display infos
613 $template->param(
614 optionloop => \@optionloop,
615 bibitemloop => \@bibitemloop,
616 itemdata_enumchron => $itemdata_enumchron,
617 date => $date,
618 biblionumber => $biblionumber,
619 findborrower => $findborrower,
620 title => $biblio->title,
621 author => $biblio->author,
622 holdsview => 1,
623 C4::Search::enabled_staff_search_views,
625 if ( $patron ) {
626 $template->param( borrower_branchcode => $patron->branchcode );
629 $biblioloopiter{biblionumber} = $biblionumber;
630 $biblioloopiter{title} = $biblio->title;
631 $biblioloopiter{rank} = $fixedRank;
632 $biblioloopiter{reserveloop} = \@reserveloop;
634 if (@reserveloop) {
635 $template->param( reserveloop => \@reserveloop );
638 push @biblioloop, \%biblioloopiter;
641 $template->param( biblioloop => \@biblioloop );
642 $template->param( biblionumbers => $biblionumbers );
643 $template->param( exceeded_maxreserves => $exceeded_maxreserves );
644 $template->param( exceeded_holds_per_record => $exceeded_holds_per_record );
646 if ($multihold) {
647 $template->param( multi_hold => 1 );
650 if ( C4::Context->preference( 'AllowHoldDateInFuture' ) ) {
651 $template->param( reserve_in_future => 1 );
654 $template->param(
655 SuspendHoldsIntranet => C4::Context->preference('SuspendHoldsIntranet'),
656 AutoResumeSuspendedHolds => C4::Context->preference('AutoResumeSuspendedHolds'),
659 # printout the page
660 output_html_with_http_headers $input, $cookie, $template->output;
662 sub sort_borrowerlist {
663 my $borrowerslist = shift;
664 my $ref = [];
665 push @{$ref}, sort {
666 uc( $a->{surname} . $a->{firstname} ) cmp
667 uc( $b->{surname} . $b->{firstname} )
668 } @{$borrowerslist};
669 return $ref;