Bug 19977: Open only .pref files in Local Use tab (sysprefs)
[koha.git] / t / db_dependent / Members.t
blobac928b2352a13cd688a8f9187e9bb396e9bba03e
1 #!/usr/bin/perl
3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
18 use Modern::Perl;
20 use Test::More tests => 62;
21 use Test::MockModule;
22 use Test::Exception;
24 use Data::Dumper qw/Dumper/;
25 use C4::Context;
26 use Koha::Database;
27 use Koha::Holds;
28 use Koha::List::Patron;
29 use Koha::Patrons;
31 use t::lib::Mocks;
32 use t::lib::TestBuilder;
34 BEGIN {
35 use_ok('C4::Members');
38 my $schema = Koha::Database->schema;
39 $schema->storage->txn_begin;
40 my $builder = t::lib::TestBuilder->new;
41 my $dbh = C4::Context->dbh;
43 # Remove invalid guarantorid's as long as we have no FK
44 $dbh->do("UPDATE borrowers b1 LEFT JOIN borrowers b2 ON b2.borrowernumber=b1.guarantorid SET b1.guarantorid=NULL where b1.guarantorid IS NOT NULL AND b2.borrowernumber IS NULL");
46 my $library1 = $builder->build({
47 source => 'Branch',
48 });
49 my $library2 = $builder->build({
50 source => 'Branch',
51 });
52 my $patron_category = $builder->build({ source => 'Category' });
53 my $CARDNUMBER = 'TESTCARD01';
54 my $FIRSTNAME = 'Marie';
55 my $SURNAME = 'Mcknight';
56 my $BRANCHCODE = $library1->{branchcode};
58 my $CHANGED_FIRSTNAME = "Marry Ann";
59 my $EMAIL = "Marie\@email.com";
60 my $EMAILPRO = "Marie\@work.com";
61 my $PHONE = "555-12123";
63 # XXX should be randomised and checked against the database
64 my $IMPOSSIBLE_CARDNUMBER = "XYZZZ999";
66 #my ($usernum, $userid, $usercnum, $userfirstname, $usersurname, $userbranch, $branchname, $userflags, $emailaddress, $branchprinter)= @_;
67 my @USERENV = (
69 'test',
70 'MASTERTEST',
71 'Test',
72 'Test',
73 't',
74 'Test',
77 my $BRANCH_IDX = 5;
79 C4::Context->_new_userenv ('DUMMY_SESSION_ID');
80 C4::Context->set_userenv ( @USERENV );
82 my $userenv = C4::Context->userenv
83 or BAIL_OUT("No userenv");
85 # Make a borrower for testing
86 my %data = (
87 cardnumber => $CARDNUMBER,
88 firstname => $FIRSTNAME . q{ },
89 surname => $SURNAME,
90 categorycode => $patron_category->{categorycode},
91 branchcode => $BRANCHCODE,
92 dateofbirth => '',
93 dateexpiry => '9999-12-31',
94 userid => 'tomasito'
97 my $addmem=AddMember(%data);
98 ok($addmem, "AddMember()");
100 my $member = Koha::Patrons->find( { cardnumber => $CARDNUMBER } )
101 or BAIL_OUT("Cannot read member with card $CARDNUMBER");
102 $member = $member->unblessed;
104 ok ( $member->{firstname} eq $FIRSTNAME &&
105 $member->{surname} eq $SURNAME &&
106 $member->{categorycode} eq $patron_category->{categorycode} &&
107 $member->{branchcode} eq $BRANCHCODE
108 , "Got member")
109 or diag("Mismatching member details: ".Dumper(\%data, $member));
111 is($member->{dateofbirth}, undef, "Empty dates handled correctly");
113 $member->{firstname} = $CHANGED_FIRSTNAME . q{ };
114 $member->{email} = $EMAIL;
115 $member->{phone} = $PHONE;
116 $member->{emailpro} = $EMAILPRO;
117 ModMember(%$member);
118 my $changedmember = Koha::Patrons->find( { cardnumber => $CARDNUMBER } )->unblessed;
119 ok ( $changedmember->{firstname} eq $CHANGED_FIRSTNAME &&
120 $changedmember->{email} eq $EMAIL &&
121 $changedmember->{phone} eq $PHONE &&
122 $changedmember->{emailpro} eq $EMAILPRO
123 , "Member Changed")
124 or diag("Mismatching member details: ".Dumper($member, $changedmember));
126 t::lib::Mocks::mock_preference( 'CardnumberLength', '' );
127 C4::Context->clear_syspref_cache();
129 my $checkcardnum=C4::Members::checkcardnumber($CARDNUMBER, "");
130 is ($checkcardnum, "1", "Card No. in use");
132 $checkcardnum=C4::Members::checkcardnumber($IMPOSSIBLE_CARDNUMBER, "");
133 is ($checkcardnum, "0", "Card No. not used");
135 t::lib::Mocks::mock_preference( 'CardnumberLength', '4' );
136 C4::Context->clear_syspref_cache();
138 $checkcardnum=C4::Members::checkcardnumber($IMPOSSIBLE_CARDNUMBER, "");
139 is ($checkcardnum, "2", "Card number is too long");
142 # Check_Userid tests
143 %data = (
144 cardnumber => "123456789",
145 firstname => "Tomasito",
146 surname => "None",
147 categorycode => $patron_category->{categorycode},
148 branchcode => $library2->{branchcode},
149 dateofbirth => '',
150 debarred => '',
151 dateexpiry => '',
152 dateenrolled => '',
154 # Add a new borrower
155 my $borrowernumber = AddMember( %data );
156 is( Check_Userid( 'tomasito.non', $borrowernumber ), 1,
157 'recently created userid -> unique (borrowernumber passed)' );
158 is( Check_Userid( 'tomasitoxxx', $borrowernumber ), 1,
159 'non-existent userid -> unique (borrowernumber passed)' );
160 is( Check_Userid( 'tomasito.none', '' ), 0,
161 'userid exists (blank borrowernumber)' );
162 is( Check_Userid( 'tomasitoxxx', '' ), 1,
163 'non-existent userid -> unique (blank borrowernumber)' );
165 my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
166 is( $borrower->{dateofbirth}, undef, 'AddMember should undef dateofbirth if empty string is given');
167 is( $borrower->{debarred}, undef, 'AddMember should undef debarred if empty string is given');
168 isnt( $borrower->{dateexpiry}, '0000-00-00', 'AddMember should not set dateexpiry to 0000-00-00 if empty string is given');
169 isnt( $borrower->{dateenrolled}, '0000-00-00', 'AddMember should not set dateenrolled to 0000-00-00 if empty string is given');
171 ModMember( borrowernumber => $borrowernumber, dateofbirth => '', debarred => '', dateexpiry => '', dateenrolled => '' );
172 $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
173 is( $borrower->{dateofbirth}, undef, 'ModMember should undef dateofbirth if empty string is given');
174 is( $borrower->{debarred}, undef, 'ModMember should undef debarred if empty string is given');
175 isnt( $borrower->{dateexpiry}, '0000-00-00', 'ModMember should not set dateexpiry to 0000-00-00 if empty string is given');
176 isnt( $borrower->{dateenrolled}, '0000-00-00', 'ModMember should not set dateenrolled to 0000-00-00 if empty string is given');
178 ModMember( borrowernumber => $borrowernumber, dateofbirth => '1970-01-01', debarred => '2042-01-01', dateexpiry => '9999-12-31', dateenrolled => '2015-09-06' );
179 $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
180 is( $borrower->{dateofbirth}, '1970-01-01', 'ModMember should correctly set dateofbirth if a valid date is given');
181 is( $borrower->{debarred}, '2042-01-01', 'ModMember should correctly set debarred if a valid date is given');
182 is( $borrower->{dateexpiry}, '9999-12-31', 'ModMember should correctly set dateexpiry if a valid date is given');
183 is( $borrower->{dateenrolled}, '2015-09-06', 'ModMember should correctly set dateenrolled if a valid date is given');
185 # Add a new borrower with the same userid but different cardnumber
186 $data{ cardnumber } = "987654321";
187 my $new_borrowernumber = AddMember( %data );
188 is( Check_Userid( 'tomasito.none', '' ), 0,
189 'userid not unique (blank borrowernumber)' );
190 is( Check_Userid( 'tomasito.none', $new_borrowernumber ), 0,
191 'userid not unique (second borrowernumber passed)' );
192 $borrower = Koha::Patrons->find( $new_borrowernumber )->unblessed;
193 ok( $borrower->{userid} ne 'tomasito', "Borrower with duplicate userid has new userid generated" );
195 $data{ cardnumber } = "234567890";
196 $data{userid} = 'a_user_id';
197 $borrowernumber = AddMember( %data );
198 $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
199 is( $borrower->{userid}, $data{userid}, 'AddMember should insert the given userid' );
201 subtest 'ModMember should not update userid if not true' => sub {
202 plan tests => 3;
203 ModMember( borrowernumber => $borrowernumber, firstname => 'Tomas', userid => '' );
204 $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
205 is ( $borrower->{userid}, $data{userid}, 'ModMember should not update the userid with an empty string' );
206 ModMember( borrowernumber => $borrowernumber, firstname => 'Tomas', userid => 0 );
207 $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
208 is ( $borrower->{userid}, $data{userid}, 'ModMember should not update the userid with an 0');
209 ModMember( borrowernumber => $borrowernumber, firstname => 'Tomas', userid => undef );
210 $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
211 is ( $borrower->{userid}, $data{userid}, 'ModMember should not update the userid with an undefined value');
214 #Regression tests for bug 10612
215 my $library3 = $builder->build({
216 source => 'Branch',
218 $builder->build({
219 source => 'Category',
220 value => {
221 categorycode => 'STAFFER',
222 description => 'Staff dont batch del',
223 category_type => 'S',
227 $builder->build({
228 source => 'Category',
229 value => {
230 categorycode => 'CIVILIAN',
231 description => 'Civilian batch del',
232 category_type => 'A',
236 $builder->build({
237 source => 'Category',
238 value => {
239 categorycode => 'KIDclamp',
240 description => 'Kid to be guaranteed',
241 category_type => 'C',
245 my $borrower1 = $builder->build({
246 source => 'Borrower',
247 value => {
248 categorycode=>'STAFFER',
249 branchcode => $library3->{branchcode},
250 dateexpiry => '2015-01-01',
251 guarantorid=> undef,
254 my $bor1inlist = $borrower1->{borrowernumber};
255 my $borrower2 = $builder->build({
256 source => 'Borrower',
257 value => {
258 categorycode=>'STAFFER',
259 branchcode => $library3->{branchcode},
260 dateexpiry => '2015-01-01',
261 guarantorid=> undef,
265 my $guarantee = $builder->build({
266 source => 'Borrower',
267 value => {
268 categorycode=>'KIDclamp',
269 branchcode => $library3->{branchcode},
270 dateexpiry => '2015-01-01',
271 guarantorid=> undef, # will be filled later
275 my $bor2inlist = $borrower2->{borrowernumber};
277 $builder->build({
278 source => 'OldIssue',
279 value => {
280 borrowernumber => $bor2inlist,
281 timestamp => '2016-01-01',
285 # The following calls to GetBorrowersToExpunge are assuming that the pref
286 # IndependentBranches is off.
287 t::lib::Mocks::mock_preference('IndependentBranches', 0);
289 my $owner = AddMember (categorycode => 'STAFFER', branchcode => $library2->{branchcode} );
290 my $list1 = AddPatronList( { name => 'Test List 1', owner => $owner } );
291 my @listpatrons = ($bor1inlist, $bor2inlist);
292 AddPatronsToList( { list => $list1, borrowernumbers => \@listpatrons });
293 my $patstodel = GetBorrowersToExpunge( {patron_list_id => $list1->patron_list_id() } );
294 is( scalar(@$patstodel),0,'No staff deleted from list of all staff');
295 ModMember( borrowernumber => $bor2inlist, categorycode => 'CIVILIAN' );
296 $patstodel = GetBorrowersToExpunge( {patron_list_id => $list1->patron_list_id()} );
297 ok( scalar(@$patstodel)== 1 && $patstodel->[0]->{'borrowernumber'} eq $bor2inlist,'Staff patron not deleted from list');
298 $patstodel = GetBorrowersToExpunge( {branchcode => $library3->{branchcode},patron_list_id => $list1->patron_list_id() } );
299 ok( scalar(@$patstodel) == 1 && $patstodel->[0]->{'borrowernumber'} eq $bor2inlist,'Staff patron not deleted by branchcode and list');
300 $patstodel = GetBorrowersToExpunge( {expired_before => '2015-01-02', patron_list_id => $list1->patron_list_id() } );
301 ok( scalar(@$patstodel) == 1 && $patstodel->[0]->{'borrowernumber'} eq $bor2inlist,'Staff patron not deleted by expirationdate and list');
302 $patstodel = GetBorrowersToExpunge( {not_borrowed_since => '2016-01-02', patron_list_id => $list1->patron_list_id() } );
303 ok( scalar(@$patstodel) == 1 && $patstodel->[0]->{'borrowernumber'} eq $bor2inlist,'Staff patron not deleted by last issue date');
305 ModMember( borrowernumber => $bor1inlist, categorycode => 'CIVILIAN' );
306 ModMember( borrowernumber => $guarantee->{borrowernumber} ,guarantorid=>$bor1inlist );
308 $patstodel = GetBorrowersToExpunge( {patron_list_id => $list1->patron_list_id()} );
309 ok( scalar(@$patstodel)== 1 && $patstodel->[0]->{'borrowernumber'} eq $bor2inlist,'Guarantor patron not deleted from list');
310 $patstodel = GetBorrowersToExpunge( {branchcode => $library3->{branchcode},patron_list_id => $list1->patron_list_id() } );
311 ok( scalar(@$patstodel) == 1 && $patstodel->[0]->{'borrowernumber'} eq $bor2inlist,'Guarantor patron not deleted by branchcode and list');
312 $patstodel = GetBorrowersToExpunge( {expired_before => '2015-01-02', patron_list_id => $list1->patron_list_id() } );
313 ok( scalar(@$patstodel) == 1 && $patstodel->[0]->{'borrowernumber'} eq $bor2inlist,'Guarantor patron not deleted by expirationdate and list');
314 $patstodel = GetBorrowersToExpunge( {not_borrowed_since => '2016-01-02', patron_list_id => $list1->patron_list_id() } );
315 ok( scalar(@$patstodel) == 1 && $patstodel->[0]->{'borrowernumber'} eq $bor2inlist,'Guarantor patron not deleted by last issue date');
316 ModMember( borrowernumber => $guarantee->{borrowernumber}, guarantorid=>'' );
318 $builder->build({
319 source => 'Issue',
320 value => {
321 borrowernumber => $bor2inlist,
324 $patstodel = GetBorrowersToExpunge( {patron_list_id => $list1->patron_list_id()} );
325 is( scalar(@$patstodel),1,'Borrower with issue not deleted from list');
326 $patstodel = GetBorrowersToExpunge( {branchcode => $library3->{branchcode},patron_list_id => $list1->patron_list_id() } );
327 is( scalar(@$patstodel),1,'Borrower with issue not deleted by branchcode and list');
328 $patstodel = GetBorrowersToExpunge( {category_code => 'CIVILIAN',patron_list_id => $list1->patron_list_id() } );
329 is( scalar(@$patstodel),1,'Borrower with issue not deleted by category_code and list');
330 $patstodel = GetBorrowersToExpunge( {expired_before => '2015-01-02',patron_list_id => $list1->patron_list_id() } );
331 is( scalar(@$patstodel),1,'Borrower with issue not deleted by expiration_date and list');
332 $builder->schema->resultset( 'Issue' )->delete_all;
333 $patstodel = GetBorrowersToExpunge( {patron_list_id => $list1->patron_list_id()} );
334 ok( scalar(@$patstodel)== 2,'Borrowers without issue deleted from list');
335 $patstodel = GetBorrowersToExpunge( {category_code => 'CIVILIAN',patron_list_id => $list1->patron_list_id() } );
336 is( scalar(@$patstodel),2,'Borrowers without issues deleted by category_code and list');
337 $patstodel = GetBorrowersToExpunge( {expired_before => '2015-01-02',patron_list_id => $list1->patron_list_id() } );
338 is( scalar(@$patstodel),2,'Borrowers without issues deleted by expiration_date and list');
339 $patstodel = GetBorrowersToExpunge( {not_borrowed_since => '2016-01-02', patron_list_id => $list1->patron_list_id() } );
340 is( scalar(@$patstodel),2,'Borrowers without issues deleted by last issue date');
342 # Test GetBorrowersToExpunge and TrackLastPatronActivity
343 $dbh->do(q|UPDATE borrowers SET lastseen=NULL|);
344 $builder->build({ source => 'Borrower', value => { lastseen => '2016-01-01 01:01:01', categorycode => 'CIVILIAN', guarantorid => undef } } );
345 $builder->build({ source => 'Borrower', value => { lastseen => '2016-02-02 02:02:02', categorycode => 'CIVILIAN', guarantorid => undef } } );
346 $builder->build({ source => 'Borrower', value => { lastseen => '2016-03-03 03:03:03', categorycode => 'CIVILIAN', guarantorid => undef } } );
347 $patstodel = GetBorrowersToExpunge( { last_seen => '1999-12-12' });
348 is( scalar @$patstodel, 0, 'TrackLastPatronActivity - 0 patrons must be deleted' );
349 $patstodel = GetBorrowersToExpunge( { last_seen => '2016-02-15' });
350 is( scalar @$patstodel, 2, 'TrackLastPatronActivity - 2 patrons must be deleted' );
351 $patstodel = GetBorrowersToExpunge( { last_seen => '2016-04-04' });
352 is( scalar @$patstodel, 3, 'TrackLastPatronActivity - 3 patrons must be deleted' );
353 my $patron2 = $builder->build({ source => 'Borrower', value => { lastseen => undef } });
354 t::lib::Mocks::mock_preference( 'TrackLastPatronActivity', '0' );
355 Koha::Patrons->find( $patron2->{borrowernumber} )->track_login;
356 is( Koha::Patrons->find( $patron2->{borrowernumber} )->lastseen, undef, 'Lastseen should not be changed' );
357 Koha::Patrons->find( $patron2->{borrowernumber} )->track_login({ force => 1 });
358 isnt( Koha::Patrons->find( $patron2->{borrowernumber} )->lastseen, undef, 'Lastseen should be changed now' );
360 # Regression tests for BZ13502
361 ## Remove all entries with userid='' (should be only 1 max)
362 $dbh->do(q|DELETE FROM borrowers WHERE userid = ''|);
363 ## And create a patron with a userid=''
364 $borrowernumber = AddMember( categorycode => $patron_category->{categorycode}, branchcode => $library2->{branchcode} );
365 $dbh->do(q|UPDATE borrowers SET userid = '' WHERE borrowernumber = ?|, undef, $borrowernumber);
366 # Create another patron and verify the userid has been generated
367 $borrowernumber = AddMember( categorycode => $patron_category->{categorycode}, branchcode => $library2->{branchcode} );
368 ok( $borrowernumber > 0, 'AddMember should have inserted the patron even if no userid is given' );
369 $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
370 ok( $borrower->{userid}, 'A userid should have been generated correctly' );
372 # Regression tests for BZ12226
373 is( Check_Userid( C4::Context->config('user'), '' ), 0,
374 'Check_Userid should return 0 for the DB user (Bug 12226)');
376 subtest 'GetMemberAccountRecords' => sub {
378 plan tests => 2;
380 my $borrowernumber = $builder->build({ source => 'Borrower' })->{ borrowernumber };
381 my $accountline_1 = $builder->build({
382 source => 'Accountline',
383 value => {
384 borrowernumber => $borrowernumber,
385 amountoutstanding => 64.60
389 my ($total,undef,undef) = GetMemberAccountRecords( $borrowernumber );
390 is( $total , 64.60, "Rounding works correctly in total calculation (single value)" );
392 my $accountline_2 = $builder->build({
393 source => 'Accountline',
394 value => {
395 borrowernumber => $borrowernumber,
396 amountoutstanding => 10.65
400 ($total,undef,undef) = GetMemberAccountRecords( $borrowernumber );
401 is( $total , 75.25, "Rounding works correctly in total calculation (multiple values)" );
405 subtest 'GetMemberAccountBalance' => sub {
407 plan tests => 6;
409 my $members_mock = new Test::MockModule('C4::Members');
410 $members_mock->mock( 'GetMemberAccountRecords', sub {
411 my ($borrowernumber) = @_;
412 if ($borrowernumber) {
413 my @accountlines = (
414 { amountoutstanding => '7', accounttype => 'Rent' },
415 { amountoutstanding => '5', accounttype => 'Res' },
416 { amountoutstanding => '3', accounttype => 'Pay' } );
417 return ( 15, \@accountlines );
419 else {
420 my @accountlines;
421 return ( 0, \@accountlines );
425 # do not count holds charges
426 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', '1' );
427 t::lib::Mocks::mock_preference( 'ManInvInNoissuesCharge', '0' );
428 my ($total, $total_minus_charges,
429 $other_charges) = C4::Members::GetMemberAccountBalance(123);
430 is( $total, 15 , "Total calculated correctly");
431 is( $total_minus_charges, 15, "Holds charges are not count if HoldsInNoissuesCharge=1");
432 is( $other_charges, 0, "Holds charges are not considered if HoldsInNoissuesCharge=1");
434 t::lib::Mocks::mock_preference( 'HoldsInNoissuesCharge', '0' );
435 ($total, $total_minus_charges,
436 $other_charges) = C4::Members::GetMemberAccountBalance(123);
437 is( $total, 15 , "Total calculated correctly");
438 is( $total_minus_charges, 10, "Holds charges are count if HoldsInNoissuesCharge=0");
439 is( $other_charges, 5, "Holds charges are considered if HoldsInNoissuesCharge=1");
442 subtest 'purgeSelfRegistration' => sub {
443 plan tests => 2;
445 #purge unverified
446 my $d=360;
447 C4::Members::DeleteUnverifiedOpacRegistrations($d);
448 foreach(1..3) {
449 $dbh->do("INSERT INTO borrower_modifications (timestamp, borrowernumber, verification_token) VALUES ('2014-01-01 01:02:03',0,?)", undef, (scalar localtime)."_$_");
451 is( C4::Members::DeleteUnverifiedOpacRegistrations($d), 3, 'Test for DeleteUnverifiedOpacRegistrations' );
453 #purge members in temporary category
454 my $c= 'XYZ';
455 $dbh->do("INSERT IGNORE INTO categories (categorycode) VALUES ('$c')");
456 t::lib::Mocks::mock_preference('PatronSelfRegistrationDefaultCategory', $c );
457 t::lib::Mocks::mock_preference('PatronSelfRegistrationExpireTemporaryAccountsDelay', 360);
458 C4::Members::DeleteExpiredOpacRegistrations();
459 $dbh->do("INSERT INTO borrowers (surname, address, city, branchcode, categorycode, dateenrolled) VALUES ('Testaabbcc', 'Street 1', 'CITY', ?, '$c', '2014-01-01 01:02:03')", undef, $library1->{branchcode});
460 is( C4::Members::DeleteExpiredOpacRegistrations(), 1, 'Test for DeleteExpiredOpacRegistrations');
463 sub _find_member {
464 my ($resultset) = @_;
465 my $found = $resultset && grep( { $_->{cardnumber} && $_->{cardnumber} eq $CARDNUMBER } @$resultset );
466 return $found;
469 # Regression tests for BZ15343
470 my $password="";
471 ( $borrowernumber, $password ) = AddMember_Opac(surname=>"Dick",firstname=>'Philip',branchcode => $library2->{branchcode});
472 is( $password =~ /^[a-zA-Z]{10}$/ , 1, 'Test for autogenerated password if none submitted');
473 ( $borrowernumber, $password ) = AddMember_Opac(surname=>"Deckard",firstname=>"Rick",password=>"Nexus-6",branchcode => $library2->{branchcode});
474 is( $password eq "Nexus-6", 1, 'Test password used if submitted');
475 $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
476 my $hashed_up = Koha::AuthUtils::hash_password("Nexus-6", $borrower->{password});
477 is( $borrower->{password} eq $hashed_up, 1, 'Check password hash equals hash of submitted password' );
479 subtest 'Trivial test for AddMember_Auto' => sub {
480 plan tests => 3;
481 my $members_mock = Test::MockModule->new( 'C4::Members' );
482 $members_mock->mock( 'fixup_cardnumber', sub { 12345; } );
483 my $library = $builder->build({ source => 'Branch' });
484 my $category = $builder->build({ source => 'Category' });
485 my %borr = AddMember_Auto( surname=> 'Dick3', firstname => 'Philip', branchcode => $library->{branchcode}, categorycode => $category->{categorycode}, password => '34567890' );
486 ok( $borr{borrowernumber}, 'Borrower hash contains borrowernumber' );
487 is( $borr{cardnumber}, 12345, 'Borrower hash contains cardnumber' );
488 my $patron = Koha::Patrons->find( $borr{borrowernumber} );
489 isnt( $patron, undef, 'Patron found' );
492 $schema->storage->txn_rollback;
494 subtest 'AddMember (invalid categorycode) tests' => sub {
495 plan tests => 1;
497 $schema->storage->txn_begin;
499 my $category = $builder->build_object({ class => 'Koha::Patron::Categories' });
500 my $category_id = $category->id;
501 # Remove category to make sure the id is not on the DB
502 $category->delete;
504 my $patron_data = {
505 categorycode => $category_id
508 throws_ok
509 { AddMember( %{ $patron_data } ); }
510 'Koha::Exceptions::BadParameter',
511 'AddMember raises an exception on invalid categorycode';
513 $schema->storage->txn_rollback;