Bug 17530: (QA follow-up) Replace our variable by cached value
[koha.git] / t / db_dependent / ArticleRequests.t
blobc0b92b612f913faedbad0623eaf9f06d581ca79c
1 #!/usr/bin/perl
3 # This file is part of Koha.
5 # Koha is free software; you can redistribute it and/or modify it
6 # under the terms of the GNU General Public License as published by
7 # the Free Software Foundation; either version 3 of the License, or
8 # (at your option) any later version.
10 # Koha is distributed in the hope that it will be useful, but
11 # WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
15 # You should have received a copy of the GNU General Public License
16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
18 use Modern::Perl;
20 use POSIX qw(strftime);
22 use Test::More tests => 56;
24 use t::lib::TestBuilder;
25 use t::lib::Mocks;
27 use Koha::Database;
28 use Koha::Biblio;
29 use Koha::Notice::Messages;
30 use Koha::Patron;
31 use Koha::Library::Group;
32 use Koha::IssuingRules;
33 use Koha::Caches;
35 BEGIN {
36 use_ok('Koha::ArticleRequest');
37 use_ok('Koha::ArticleRequests');
38 use_ok('Koha::ArticleRequest::Status');
41 my $schema = Koha::Database->new()->schema();
42 $schema->storage->txn_begin();
43 my $builder = t::lib::TestBuilder->new;
44 our $cache = Koha::Caches->get_instance;
46 my $dbh = C4::Context->dbh;
47 $dbh->{RaiseError} = 1;
49 $dbh->do("DELETE FROM issuingrules");
51 my $biblio = Koha::Biblio->new()->store();
52 ok( $biblio->id, 'Koha::Biblio created' );
54 my $biblioitem = $schema->resultset('Biblioitem')->new(
56 biblionumber => $biblio->id
58 )->insert();
59 ok( $biblioitem->id, 'biblioitem created' );
61 my $itype = $builder->build({ source => 'Itemtype' });
62 my $item = Koha::Item->new(
64 biblionumber => $biblio->id,
65 biblioitemnumber => $biblioitem->id,
66 itype => $itype->{itemtype},
68 )->store();
69 ok( $item->id, 'Koha::Item created' );
71 my $branch = $builder->build({ source => 'Branch' });
72 my $category = $builder->build({ source => 'Category' });
73 my $patron = $builder->build_object({
74 class => 'Koha::Patrons',
75 value => {
76 categorycode => $category->{categorycode},
77 branchcode => $branch->{branchcode},
78 flags => 1,# superlibrarian
80 });
81 ok( $patron->id, 'Koha::Patron created' );
82 my $patron_2 = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 0 } });
84 # store
85 Koha::Notice::Messages->delete;
86 my $article_request_title = 'an article request title';
87 my $article_request = Koha::ArticleRequest->new(
89 borrowernumber => $patron->id,
90 biblionumber => $biblio->id,
91 itemnumber => $item->id,
92 title => $article_request_title,
94 )->store();
96 my $notify_message = Koha::Notice::Messages->search->next;
97 is( $notify_message->letter_code, "AR_".Koha::ArticleRequest::Status::Pending);
98 # Default AR_PROCESSING template content "Title: <<article_requests.title>>"
99 like( $notify_message->content, qr{Title: $article_request_title}, 'Values from article_requests table must be fetched for the notification' );
101 $article_request = Koha::ArticleRequests->find( $article_request->id );
102 ok( $article_request->id, 'Koha::ArticleRequest created' );
103 is( $article_request->status, Koha::ArticleRequest::Status::Pending, 'New article request has status of Open' );
104 is( $article_request->updated_on, undef, 'New article request has not an updated_on date set yet' );
106 # process
107 Koha::Notice::Messages->delete;
108 $article_request->process();
109 $notify_message = Koha::Notice::Messages->search->next;
110 is( $notify_message->letter_code, "AR_".Koha::ArticleRequest::Status::Processing);
111 is( $article_request->status, Koha::ArticleRequest::Status::Processing, '$ar->process() changes status to Processing' );
112 isnt( $article_request->updated_on, undef, 'Updated article request has an updated_on date set' );
114 # complete
115 $article_request->complete();
116 is( $article_request->status, Koha::ArticleRequest::Status::Completed, '$ar->complete() changes status to Completed' );
118 # cancel
119 $article_request->cancel();
120 is( $article_request->status, Koha::ArticleRequest::Status::Canceled, '$ar->complete() changes status to Canceled' );
121 $article_request->status(Koha::ArticleRequest::Status::Pending);
122 $article_request->store();
124 is( $article_request->biblio->id, $biblio->id, '$ar->biblio() gets corresponding Koha::Biblio object' );
125 is( $article_request->item->id, $item->id, '$ar->item() gets corresponding Koha::Item object' );
126 is( $article_request->borrower->id, $patron->id, '$ar->borrower() gets corresponding Koha::Patron object' );
128 my $ar = $patron->article_requests();
129 is( ref($ar), 'Koha::ArticleRequests', '$patron->article_requests returns Koha::ArticleRequests object' );
130 is( $ar->next->id, $article_request->id, 'Returned article request matches' );
132 is( $patron->article_requests_current()->count(), 1, 'Open request returned for article_requests_current' );
133 $article_request->process();
134 is( $patron->article_requests_current()->count(), 1, 'Processing request returned for article_requests_current' );
135 $article_request->complete();
136 is( $patron->article_requests_current()->count(), 0, 'Completed request not returned for article_requests_current' );
137 $article_request->cancel();
138 is( $patron->article_requests_current()->count(), 0, 'Canceled request not returned for article_requests_current' );
140 $article_request->status(Koha::ArticleRequest::Status::Pending);
141 $article_request->store();
143 is( $patron->article_requests_finished()->count(), 0, 'Open request returned for article_requests_finished' );
144 $article_request->process();
145 is( $patron->article_requests_finished()->count(), 0, 'Processing request returned for article_requests_finished' );
146 $article_request->complete();
147 $article_request->cancel();
148 is( $patron->article_requests_finished()->count(), 1, 'Canceled request not returned for article_requests_finished' );
150 $article_request->status(Koha::ArticleRequest::Status::Pending);
151 $article_request->store();
153 $ar = $biblio->article_requests();
154 is( ref($ar), 'Koha::ArticleRequests', '$biblio->article_requests returns Koha::ArticleRequests object' );
155 is( $ar->next->id, $article_request->id, 'Returned article request matches' );
157 is( $biblio->article_requests_current()->count(), 1, 'Open request returned for article_requests_current' );
158 $article_request->process();
159 is( $biblio->article_requests_current()->count(), 1, 'Processing request returned for article_requests_current' );
160 $article_request->complete();
161 is( $biblio->article_requests_current()->count(), 0, 'Completed request not returned for article_requests_current' );
162 $article_request->cancel();
163 is( $biblio->article_requests_current()->count(), 0, 'Canceled request not returned for article_requests_current' );
165 $article_request->status(Koha::ArticleRequest::Status::Pending);
166 $article_request->store();
168 is( $biblio->article_requests_finished()->count(), 0, 'Open request returned for article_requests_finished' );
169 $article_request->process();
170 is( $biblio->article_requests_finished()->count(), 0, 'Processing request returned for article_requests_finished' );
171 $article_request->complete();
172 $article_request->cancel();
173 is( $biblio->article_requests_finished()->count(), 1, 'Canceled request not returned for article_requests_finished' );
175 my $rule;
176 $rule = $schema->resultset('Issuingrule')
177 ->new( { categorycode => '*', itemtype => '*', branchcode => '*', article_requests => 'yes' } )->insert();
178 ok( $biblio->can_article_request($patron), 'Record is requestable with rule type yes' );
179 is( $biblio->article_request_type($patron), 'yes', 'Biblio article request type is yes' );
180 ok( $item->can_article_request($patron), 'Item is requestable with rule type yes' );
181 is( $item->article_request_type($patron), 'yes', 'Item article request type is yes' );
182 $rule->delete();
184 $rule = $schema->resultset('Issuingrule')
185 ->new( { categorycode => '*', itemtype => '*', branchcode => '*', article_requests => 'bib_only' } )->insert();
186 ok( $biblio->can_article_request($patron), 'Record is requestable with rule type bib_only' );
187 is( $biblio->article_request_type($patron), 'bib_only', 'Biblio article request type is bib_only' );
188 ok( !$item->can_article_request($patron), 'Item is not requestable with rule type bib_only' );
189 is( $item->article_request_type($patron), 'bib_only', 'Item article request type is bib_only' );
190 $rule->delete();
192 $rule = $schema->resultset('Issuingrule')
193 ->new( { categorycode => '*', itemtype => '*', branchcode => '*', article_requests => 'item_only' } )->insert();
194 ok( $biblio->can_article_request($patron), 'Record is requestable with rule type item_only' );
195 is( $biblio->article_request_type($patron), 'item_only', 'Biblio article request type is item_only' );
196 ok( $item->can_article_request($patron), 'Item is not requestable with rule type item_only' );
197 is( $item->article_request_type($patron), 'item_only', 'Item article request type is item_only' );
198 $rule->delete();
200 $rule = $schema->resultset('Issuingrule')
201 ->new( { categorycode => '*', itemtype => '*', branchcode => '*', article_requests => 'no' } )->insert();
202 ok( !$biblio->can_article_request($patron), 'Record is requestable with rule type no' );
203 is( $biblio->article_request_type($patron), 'no', 'Biblio article request type is no' );
204 ok( !$item->can_article_request($patron), 'Item is not requestable with rule type no' );
205 is( $item->article_request_type($patron), 'no', 'Item article request type is no' );
206 $rule->delete();
208 subtest 'search_limited' => sub {
209 plan tests => 2;
210 C4::Context->_new_userenv('xxx');
211 my $nb_article_requests = Koha::ArticleRequests->count;
213 my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1' } )->store;
214 my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2' } )->store;
215 Koha::Library::Group->new({ parent_id => $group_1->id, branchcode => $patron->branchcode })->store();
216 Koha::Library::Group->new({ parent_id => $group_2->id, branchcode => $patron_2->branchcode })->store();
217 set_logged_in_user( $patron ); # Is superlibrarian
218 is( Koha::ArticleRequests->search_limited->count, $nb_article_requests, 'Koha::ArticleRequests->search_limited should return all article requests for superlibrarian' );
219 set_logged_in_user( $patron_2 ); # Is restricted
220 is( Koha::ArticleRequests->search_limited->count, 0, 'Koha::ArticleRequests->search_limited should not return all article requests for restricted patron' );
223 subtest 'may_article_request' => sub {
224 plan tests => 6;
226 # mocking
227 t::lib::Mocks::mock_preference('ArticleRequests', 1);
228 $cache->set_in_cache( Koha::IssuingRules::GUESSED_ITEMTYPES_KEY, {
229 '*' => { 'CR' => 1 },
230 'S' => { '*' => 1 },
231 'PT' => { 'BK' => 1 },
234 # tests for class method call
235 is( Koha::Biblio->may_article_request({ itemtype => 'CR' }), 1, 'SER/* should be true' );
236 is( Koha::Biblio->may_article_request({ itemtype => 'CR', categorycode => 'S' }), 1, 'SER/S should be true' );
237 is( Koha::Biblio->may_article_request({ itemtype => 'CR', categorycode => 'PT' }), '', 'SER/PT should be false' );
239 # tests for instance method call
240 my $builder = t::lib::TestBuilder->new;
241 my $biblio = $builder->build_object({ class => 'Koha::Biblios' });
242 my $biblioitem = $builder->build_object({ class => 'Koha::Biblioitems', value => { biblionumber => $biblio->biblionumber, itemtype => 'BK' }});
243 is( $biblio->may_article_request, '', 'BK/* false' );
244 is( $biblio->may_article_request({ categorycode => 'S' }), 1, 'BK/S true' );
245 is( $biblio->may_article_request({ categorycode => 'PT' }), 1, 'BK/PT true' );
247 # Cleanup
248 $cache->clear_from_cache( Koha::IssuingRules::GUESSED_ITEMTYPES_KEY );
251 $schema->storage->txn_rollback();
253 sub set_logged_in_user {
254 my ($patron) = @_;
255 C4::Context->set_userenv(
256 $patron->borrowernumber, $patron->userid,
257 $patron->cardnumber, 'firstname',
258 'surname', $patron->library->branchcode,
259 'Midway Public Library', $patron->flags,
260 '', ''