t/db_dependent/Holds.t

   1 #!/usr/bin/perl
   2
   3 use strict;
   4 use warnings;
   5
   6 use t::lib::Mocks;
   7 use C4::Context;
   8 use C4::Branch;
   9
  10 use Test::More tests => 22;
  11 use MARC::Record;
  12 use C4::Biblio;
  13 use C4::Items;
  14 use C4::Members;
  15
  16 BEGIN {
  17     use FindBin;
  18     use lib $FindBin::Bin;
  19     use_ok('C4::Reserves');
  20 }
  21
  22 my $dbh = C4::Context->dbh;
  23
  24 # Start transaction
  25 $dbh->{AutoCommit} = 0;
  26 $dbh->{RaiseError} = 1;
  27
  28 my $borrowers_count = 5;
  29
  30 # Setup Test------------------------
  31 # Helper biblio.
  32 diag("Creating biblio instance for testing.");
  33 my ($bibnum, $title, $bibitemnum) = create_helper_biblio();
  34
  35 # Helper item for that biblio.
  36 diag("Creating item instance for testing.");
  37 my ($item_bibnum, $item_bibitemnum, $itemnumber) = AddItem({ homebranch => 'CPL', holdingbranch => 'CPL' } , $bibnum);
  38
  39 # Create some borrowers
  40 my @borrowernumbers;
  41 foreach (1..$borrowers_count) {
  42     my $borrowernumber = AddMember(
  43         firstname =>  'my firstname',
  44         surname => 'my surname ' . $_,
  45         categorycode => 'S',
  46         branchcode => 'CPL',
  47     );
  48     push @borrowernumbers, $borrowernumber;
  49 }
  50
  51 my $biblionumber   = $bibnum;
  52
  53 my @branches = GetBranchesLoop();
  54 my $branch = $branches[0][0]{value};
  55
  56 # Create five item level holds
  57 foreach my $borrowernumber ( @borrowernumbers ) {
  58     AddReserve(
  59         $branch,
  60         $borrowernumber,
  61         $biblionumber,
  62         my $constraint = 'a',
  63         my $bibitems = q{},
  64         my $priority,
  65         my $resdate,
  66         my $expdate,
  67         my $notes = q{},
  68         $title,
  69         my $checkitem = $itemnumber,
  70         my $found,
  71     );
  72 }
  73
  74
  75 my ($count, $reserves) = GetReservesFromBiblionumber($biblionumber);
  76 is( $count, $borrowers_count, "Test GetReserves()" );
  77
  78
  79 my ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
  80 ok($reserve_id, "Test GetReservesFromItemnumber()");
  81
  82
  83 my ( $reserve ) = GetReservesFromBorrowernumber($borrowernumbers[0]);
  84 ok( $reserve->{'borrowernumber'} eq $borrowernumbers[0], "Test GetReservesFromBorrowernumber()");
  85
  86
  87 ok( GetReserveCount( $borrowernumbers[0] ), "Test GetReserveCount()" );
  88
  89
  90 CancelReserve({ 'reserve_id' => $reserve_id });
  91 ($count, $reserves) = GetReservesFromBiblionumber($biblionumber);
  92 ok( $count == $borrowers_count - 1, "Test CancelReserve()" );
  93
  94
  95 ( $reservedate, $borrowernumber, $branchcode, $reserve_id ) = GetReservesFromItemnumber($itemnumber);
  96 ModReserve({
  97     reserve_id    => $reserve_id,
  98     rank          => '4',
  99     branchcode    => $branch,
 100     itemnumber    => $itemnumber,
 101     suspend_until => C4::Dates->new("2013-01-01","iso")->output(),
 102 });
 103 $reserve = GetReserve( $reserve_id );
 104 ok( $reserve->{'priority'} eq '4', "Test GetReserve(), priority changed correctly" );
 105 ok( $reserve->{'suspend'}, "Test GetReserve(), suspend hold" );
 106 ok( $reserve->{'suspend_until'} eq '2013-01-01 00:00:00', "Test GetReserve(), suspend until date" );
 107
 108 ToggleSuspend( $reserve_id );
 109 $reserve = GetReserve( $reserve_id );
 110 ok( !$reserve->{'suspend'}, "Test ToggleSuspend(), no date" );
 111
 112 ToggleSuspend( $reserve_id, '2012-01-01' );
 113 $reserve = GetReserve( $reserve_id );
 114 ok( $reserve->{'suspend_until'} eq '2012-01-01 00:00:00', "Test ToggleSuspend(), with date" );
 115
 116 AutoUnsuspendReserves();
 117 $reserve = GetReserve( $reserve_id );
 118 ok( !$reserve->{'suspend'}, "Test AutoUnsuspendReserves()" );
 119
 120 # Add a new hold for the borrower whose hold we canceled earlier, this time at the bib level
 121 AddReserve(
 122     $branch,
 123     $borrowernumber,
 124     $biblionumber,
 125     my $constraint = 'a',
 126     my $bibitems = q{},
 127     my $priority,
 128     my $resdate,
 129     my $expdate,
 130     my $notes = q{},
 131     $title,
 132     my $checkitem,
 133     my $found,
 134 );
 135 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
 136 my $reserveid = C4::Reserves::GetReserveId(
 137     {
 138         biblionumber => $biblionumber,
 139         borrowernumber => $borrowernumber
 140     }
 141 );
 142 is( $reserveid, $reserve->{reserve_id}, "Test GetReserveId" );
 143 ModReserveMinusPriority( $itemnumber, $reserve->{'reserve_id'} );
 144 ( $reserve ) = GetReservesFromBorrowernumber($borrowernumber);
 145 ok( $reserve->{'itemnumber'} eq $itemnumber, "Test ModReserveMinusPriority()" );
 146
 147
 148 my $reserve2 = GetReserveInfo( $reserve->{'reserve_id'} );
 149 ok( $reserve->{'reserve_id'} eq $reserve2->{'reserve_id'}, "Test GetReserveInfo()" );
 150
 151
 152 ($count, $reserves) = GetReservesFromBiblionumber($biblionumber,1);
 153 $reserve = $reserves->[1];
 154 AlterPriority( 'top', $reserve->{'reserve_id'} );
 155 $reserve = GetReserve( $reserve->{'reserve_id'} );
 156 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move to top" );
 157
 158 AlterPriority( 'down', $reserve->{'reserve_id'} );
 159 $reserve = GetReserve( $reserve->{'reserve_id'} );
 160 ok( $reserve->{'priority'} eq '2', "Test AlterPriority(), move down" );
 161
 162 AlterPriority( 'up', $reserve->{'reserve_id'} );
 163 $reserve = GetReserve( $reserve->{'reserve_id'} );
 164 ok( $reserve->{'priority'} eq '1', "Test AlterPriority(), move up" );
 165
 166 AlterPriority( 'bottom', $reserve->{'reserve_id'} );
 167 $reserve = GetReserve( $reserve->{'reserve_id'} );
 168 ok( $reserve->{'priority'} eq '5', "Test AlterPriority(), move to bottom" );
 169
 170 # Regression test for bug 2394
 171 #
 172 # If IndependentBranches is ON and canreservefromotherbranches is OFF,
 173 # a patron is not permittedo to request an item whose homebranch (i.e.,
 174 # owner of the item) is different from the patron's own library.
 175 # However, if canreservefromotherbranches is turned ON, the patron can
 176 # create such hold requests.
 177 #
 178 # Note that canreservefromotherbranches has no effect if
 179 # IndependentBranches is OFF.
 180
 181 my ($foreign_bibnum, $foreign_title, $foreign_bibitemnum) = create_helper_biblio();
 182 my ($foreign_item_bibnum, $foreign_item_bibitemnum, $foreign_itemnumber)
 183   = AddItem({ homebranch => 'MPL', holdingbranch => 'MPL' } , $foreign_bibnum);
 184 $dbh->do('DELETE FROM issuingrules');
 185 $dbh->do(
 186     q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed)
 187       VALUES (?, ?, ?, ?)},
 188     {},
 189     '*', '*', '*', 25
 190 );
 191
 192 # make sure some basic sysprefs are set
 193 t::lib::Mocks::mock_preference('ReservesControlBranch', 'homebranch');
 194 t::lib::Mocks::mock_preference('item-level_itypes', 1);
 195
 196 # if IndependentBranches is OFF, a CPL patron can reserve an MPL item
 197 t::lib::Mocks::mock_preference('IndependentBranches', 0);
 198 ok(
 199     CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
 200     'CPL patron allowed to reserve MPL item with IndependentBranches OFF (bug 2394)'
 201 );
 202
 203 # if IndependentBranches is OFF, a CPL patron cannot reserve an MPL item
 204 t::lib::Mocks::mock_preference('IndependentBranches', 1);
 205 t::lib::Mocks::mock_preference('canreservefromotherbranches', 0);
 206 ok(
 207     ! CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
 208     'CPL patron NOT allowed to reserve MPL item with IndependentBranches ON ... (bug 2394)'
 209 );
 210
 211 # ... unless canreservefromotherbranches is ON
 212 t::lib::Mocks::mock_preference('canreservefromotherbranches', 1);
 213 ok(
 214     CanItemBeReserved($borrowernumbers[0], $foreign_itemnumber),
 215     '... unless canreservefromotherbranches is ON (bug 2394)'
 216 );
 217
 218 # Helper method to set up a Biblio.
 219 sub create_helper_biblio {
 220     my $bib = MARC::Record->new();
 221     my $title = 'Silence in the library';
 222     $bib->append_fields(
 223         MARC::Field->new('100', ' ', ' ', a => 'Moffat, Steven'),
 224         MARC::Field->new('245', ' ', ' ', a => $title),
 225     );
 226     return ($bibnum, $title, $bibitemnum) = AddBiblio($bib, '');
 227 }