t/db_dependent/Circulation/Branch.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19
  20 use C4::Circulation;
  21 use C4::Items;
  22 use C4::Biblio;
  23 use C4::Context;
  24 use Koha::CirculationRules;
  25
  26 use Koha::Patrons;
  27
  28 use Test::More tests => 14;
  29 use t::lib::Mocks;
  30 use t::lib::TestBuilder;
  31
  32 BEGIN {
  33     use_ok('C4::Circulation');
  34 }
  35
  36 can_ok( 'C4::Circulation', qw(
  37     AddIssue
  38     AddReturn
  39     GetBranchBorrowerCircRule
  40     GetBranchItemRule
  41     )
  42 );
  43
  44 my $schema = Koha::Database->schema;
  45 $schema->storage->txn_begin;
  46 my $dbh = C4::Context->dbh;
  47 my $query;
  48
  49 $dbh->do(q|DELETE FROM issues|);
  50 $dbh->do(q|DELETE FROM items|);
  51 $dbh->do(q|DELETE FROM borrowers|);
  52 $dbh->do(q|DELETE FROM clubs|);
  53 $dbh->do(q|DELETE FROM branches|);
  54 $dbh->do(q|DELETE FROM categories|);
  55 $dbh->do(q|DELETE FROM accountlines|);
  56 $dbh->do(q|DELETE FROM itemtypes|);
  57 $dbh->do(q|DELETE FROM circulation_rules|);
  58
  59 my $builder = t::lib::TestBuilder->new();
  60
  61 # Add branch
  62 my $samplebranch1 = $builder->build({ source => 'Branch' });
  63 my $samplebranch2 = $builder->build({ source => 'Branch' });
  64 # Add itemtypes
  65 my $no_circ_itemtype = $builder->build({
  66     source => 'Itemtype',
  67     value => {
  68         rentalcharge => '0',
  69         notforloan   => 0
  70     }
  71 });
  72 my $sampleitemtype1 = $builder->build({
  73     source => 'Itemtype',
  74     value => {
  75         rentalcharge => '10.0',
  76         notforloan   => 1
  77     }
  78 });
  79 my $sampleitemtype2 = $builder->build({
  80     source => 'Itemtype',
  81     value => {
  82         rentalcharge => '5.0',
  83         notforloan   => 0
  84     }
  85 });
  86 # Add Category
  87 my $samplecat     = $builder->build({
  88     source => 'Category',
  89     value => {
  90         hidelostitems => 0
  91     }
  92 });
  93
  94 #Add biblio and item
  95 my $record = MARC::Record->new();
  96 $record->append_fields(
  97     MARC::Field->new( '952', '0', '0', a => $samplebranch1->{branchcode} ) );
  98 my ( $biblionumber, $biblioitemnumber ) = C4::Biblio::AddBiblio( $record, '' );
  99
 100 # item 1 has home branch and holding branch samplebranch1
 101 my $item_id1 = Koha::Item->new(
 102     {
 103         biblionumber   => $biblionumber,
 104         barcode        => 'barcode_1',
 105         itemcallnumber => 'callnumber1',
 106         homebranch     => $samplebranch1->{branchcode},
 107         holdingbranch  => $samplebranch1->{branchcode},
 108         itype          => $no_circ_itemtype->{ itemtype }
 109     }
 110 )->store->itemnumber;
 111
 112 # item 2 has holding branch samplebranch2
 113 my $item_id2 = Koha::Item->new(
 114     {
 115         biblionumber   => $biblionumber,
 116         barcode        => 'barcode_2',
 117         itemcallnumber => 'callnumber2',
 118         homebranch     => $samplebranch2->{branchcode},
 119         holdingbranch  => $samplebranch1->{branchcode},
 120         itype          => $no_circ_itemtype->{ itemtype }
 121     },
 122 )->store->itemnumber;
 123
 124 # item 3 has item type sampleitemtype2 with noreturn policy
 125 my $item_id3 = Koha::Item->new(
 126     {
 127         biblionumber   => $biblionumber,
 128         barcode        => 'barcode_3',
 129         itemcallnumber => 'callnumber3',
 130         homebranch     => $samplebranch2->{branchcode},
 131         holdingbranch  => $samplebranch2->{branchcode},
 132         itype          => $sampleitemtype2->{itemtype}
 133     }
 134 )->store->itemnumber;
 135
 136 #Add borrower
 137 my $borrower_id1 = Koha::Patron->new({
 138     firstname    => 'firstname1',
 139     surname      => 'surname1 ',
 140     categorycode => $samplecat->{categorycode},
 141     branchcode   => $samplebranch1->{branchcode},
 142 })->store->borrowernumber;
 143
 144 is_deeply(
 145     GetBranchBorrowerCircRule(),
 146     { patron_maxissueqty => undef, patron_maxonsiteissueqty => undef },
 147 "Without parameter, GetBranchBorrower returns undef (unilimited) for patron_maxissueqty and patron_maxonsiteissueqty if no rules defined"
 148 );
 149
 150 Koha::CirculationRules->set_rules(
 151     {
 152         branchcode   => $samplebranch1->{branchcode},
 153         categorycode => $samplecat->{categorycode},
 154         rules        => {
 155             patron_maxissueqty       => 5,
 156             patron_maxonsiteissueqty => 6,
 157         }
 158     }
 159 );
 160
 161
 162 Koha::CirculationRules->set_rules(
 163     {
 164         branchcode   => $samplebranch2->{branchcode},
 165         categorycode => undef,
 166         rules        => {
 167             patron_maxissueqty       => 3,
 168             patron_maxonsiteissueqty => 2,
 169         }
 170     }
 171 );
 172 Koha::CirculationRules->set_rules(
 173     {
 174         branchcode   => $samplebranch2->{branchcode},
 175         itemtype     => undef,
 176         rules        => {
 177             holdallowed       => 1,
 178             returnbranch      => 'holdingbranch',
 179         }
 180     }
 181 );
 182
 183 Koha::CirculationRules->set_rules(
 184     {
 185         branchcode   => undef,
 186         categorycode => undef,
 187         rules        => {
 188             patron_maxissueqty       => 4,
 189             patron_maxonsiteissueqty => 5,
 190         }
 191     }
 192 );
 193 Koha::CirculationRules->set_rules(
 194     {
 195         branchcode   => undef,
 196         itemtype     => undef,
 197         rules        => {
 198             holdallowed       => 3,
 199             returnbranch      => 'homebranch',
 200         }
 201     }
 202 );
 203
 204 Koha::CirculationRules->set_rules(
 205     {
 206         branchcode   => $samplebranch1->{branchcode},
 207         itemtype     => $sampleitemtype1->{itemtype},
 208         rules        => {
 209             holdallowed       => 5,
 210             returnbranch      => 'homebranch',
 211         }
 212     }
 213 );
 214 Koha::CirculationRules->set_rules(
 215     {
 216         branchcode   => $samplebranch2->{branchcode},
 217         itemtype     => $sampleitemtype1->{itemtype},
 218         rules        => {
 219             holdallowed       => 5,
 220             returnbranch      => 'holdingbranch',
 221         }
 222     }
 223 );
 224 Koha::CirculationRules->set_rules(
 225     {
 226         branchcode   => $samplebranch2->{branchcode},
 227         itemtype     => $sampleitemtype2->{itemtype},
 228         rules        => {
 229             holdallowed       => 5,
 230             returnbranch      => 'noreturn',
 231         }
 232     }
 233 );
 234
 235 #Test GetBranchBorrowerCircRule
 236 is_deeply(
 237     GetBranchBorrowerCircRule(),
 238     { patron_maxissueqty => 4, patron_maxonsiteissueqty => 5 },
 239 "Without parameter, GetBranchBorrower returns the patron_maxissueqty and patron_maxonsiteissueqty of default_circ_rules"
 240 );
 241 is_deeply(
 242     GetBranchBorrowerCircRule( $samplebranch2->{branchcode} ),
 243     { patron_maxissueqty => 3, patron_maxonsiteissueqty => 2 },
 244 "Without only the branchcode specified, GetBranchBorrower returns the patron_maxissueqty and patron_maxonsiteissueqty corresponding"
 245 );
 246 is_deeply(
 247     GetBranchBorrowerCircRule(
 248         $samplebranch1->{branchcode},
 249         $samplecat->{categorycode}
 250     ),
 251     { patron_maxissueqty => 5, patron_maxonsiteissueqty => 6 },
 252     "GetBranchBorrower returns the patron_maxissueqty and patron_maxonsiteissueqty of the branch1 and the category1"
 253 );
 254 is_deeply(
 255     GetBranchBorrowerCircRule( -1, -1 ),
 256     { patron_maxissueqty => 4, patron_maxonsiteissueqty => 5 },
 257 "GetBranchBorrower with wrong parameters returns the patron_maxissueqty and patron_maxonsiteissueqty of default_circ_rules"
 258 );
 259
 260 #Test GetBranchItemRule
 261 my @lazy_any = ( 'hold_fulfillment_policy' => 'any' );
 262 is_deeply(
 263     GetBranchItemRule(
 264         $samplebranch1->{branchcode},
 265         $sampleitemtype1->{itemtype},
 266     ),
 267     { returnbranch => 'homebranch', holdallowed => 5, @lazy_any },
 268     "GetBranchitem returns holdallowed and return branch"
 269 );
 270 is_deeply(
 271     GetBranchItemRule(),
 272     { returnbranch => 'homebranch', holdallowed => 3, @lazy_any },
 273 "Without parameters GetBranchItemRule returns the values in default_circ_rules"
 274 );
 275 is_deeply(
 276     GetBranchItemRule( $samplebranch2->{branchcode} ),
 277     { returnbranch => 'holdingbranch', holdallowed => 1, @lazy_any },
 278 "With only a branchcode GetBranchItemRule returns values in default_branch_circ_rules"
 279 );
 280 is_deeply(
 281     GetBranchItemRule( -1, -1 ),
 282     { returnbranch => 'homebranch', holdallowed => 3, @lazy_any },
 283     "With only one parametern GetBranchItemRule returns default values"
 284 );
 285
 286 # Test return policies
 287 t::lib::Mocks::mock_preference('AutomaticItemReturn','0');
 288
 289 # item1 returned at branch2 should trigger transfer to homebranch
 290 $query =
 291 "INSERT INTO issues (borrowernumber,itemnumber,branchcode) VALUES( ?,?,? )";
 292 $dbh->do( $query, {}, $borrower_id1, $item_id1, $samplebranch1->{branchcode} );
 293
 294 my ($doreturn, $messages, $iteminformation, $borrower) = AddReturn('barcode_1',
 295     $samplebranch2->{branchcode});
 296 is( $messages->{NeedsTransfer}, $samplebranch1->{branchcode}, "AddReturn respects default return policy - return to homebranch" );
 297
 298 # item2 returned at branch2 should trigger transfer to holding branch
 299 $query =
 300 "INSERT INTO issues (borrowernumber,itemnumber,branchcode) VALUES( ?,?,? )";
 301 $dbh->do( $query, {}, $borrower_id1, $item_id2, $samplebranch2->{branchcode} );
 302 ($doreturn, $messages, $iteminformation, $borrower) = AddReturn('barcode_2',
 303     $samplebranch2->{branchcode});
 304 is( $messages->{NeedsTransfer}, $samplebranch1->{branchcode}, "AddReturn respects branch return policy - item2->homebranch policy = 'holdingbranch'" );
 305
 306 # item3 should not trigger transfer - floating collection
 307 $query =
 308 "INSERT INTO issues (borrowernumber,itemnumber,branchcode) VALUES( ?,?,? )";
 309 $dbh->do( $query, {}, $borrower_id1, $item_id3, $samplebranch1->{branchcode} );
 310 t::lib::Mocks::mock_preference( 'item-level_itypes', 1 );
 311 ($doreturn, $messages, $iteminformation, $borrower) = AddReturn('barcode_3',
 312     $samplebranch1->{branchcode});
 313 is($messages->{NeedsTransfer},undef,"AddReturn respects branch item return policy - noreturn");
 314 t::lib::Mocks::mock_preference( 'item-level_itypes', 0 );
 315
 316 $schema->storage->txn_rollback;
 317