t/db_dependent/Circulation.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19 use utf8;
  20
  21 use Test::More tests => 45;
  22 use Test::MockModule;
  23
  24 use Data::Dumper;
  25 use DateTime;
  26 use Time::Fake;
  27 use POSIX qw( floor );
  28 use t::lib::Mocks;
  29 use t::lib::TestBuilder;
  30
  31 use C4::Accounts;
  32 use C4::Calendar;
  33 use C4::Circulation;
  34 use C4::Biblio;
  35 use C4::Items;
  36 use C4::Log;
  37 use C4::Reserves;
  38 use C4::Overdues qw(UpdateFine CalcFine);
  39 use Koha::DateUtils;
  40 use Koha::Database;
  41 use Koha::IssuingRules;
  42 use Koha::Items;
  43 use Koha::Checkouts;
  44 use Koha::Patrons;
  45 use Koha::CirculationRules;
  46 use Koha::Subscriptions;
  47 use Koha::Account::Lines;
  48 use Koha::Account::Offsets;
  49 use Koha::ActionLogs;
  50
  51 sub set_userenv {
  52     my ( $library ) = @_;
  53     t::lib::Mocks::mock_userenv({ branchcode => $library->{branchcode} });
  54 }
  55
  56 sub str {
  57     my ( $error, $question, $alert ) = @_;
  58     my $s;
  59     $s  = %$error    ? ' (error: '    . join( ' ', keys %$error    ) . ')' : '';
  60     $s .= %$question ? ' (question: ' . join( ' ', keys %$question ) . ')' : '';
  61     $s .= %$alert    ? ' (alert: '    . join( ' ', keys %$alert    ) . ')' : '';
  62     return $s;
  63 }
  64
  65 sub test_debarment_on_checkout {
  66     my ($params) = @_;
  67     my $item     = $params->{item};
  68     my $library  = $params->{library};
  69     my $patron   = $params->{patron};
  70     my $due_date = $params->{due_date} || dt_from_string;
  71     my $return_date = $params->{return_date} || dt_from_string;
  72     my $expected_expiration_date = $params->{expiration_date};
  73
  74     $expected_expiration_date = output_pref(
  75         {
  76             dt         => $expected_expiration_date,
  77             dateformat => 'sql',
  78             dateonly   => 1,
  79         }
  80     );
  81     my @caller      = caller;
  82     my $line_number = $caller[2];
  83     AddIssue( $patron, $item->{barcode}, $due_date );
  84
  85     my ( undef, $message ) = AddReturn( $item->{barcode}, $library->{branchcode}, undef, $return_date );
  86     is( $message->{WasReturned} && exists $message->{Debarred}, 1, 'AddReturn must have debarred the patron' )
  87         or diag('AddReturn returned message ' . Dumper $message );
  88     my $debarments = Koha::Patron::Debarments::GetDebarments(
  89         { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
  90     is( scalar(@$debarments), 1, 'Test at line ' . $line_number );
  91
  92     is( $debarments->[0]->{expiration},
  93         $expected_expiration_date, 'Test at line ' . $line_number );
  94     Koha::Patron::Debarments::DelUniqueDebarment(
  95         { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
  96 };
  97
  98 my $schema = Koha::Database->schema;
  99 $schema->storage->txn_begin;
 100 my $builder = t::lib::TestBuilder->new;
 101 my $dbh = C4::Context->dbh;
 102
 103 # Prevent random failures by mocking ->now
 104 my $now_value       = DateTime->now();
 105 my $mocked_datetime = Test::MockModule->new('DateTime');
 106 $mocked_datetime->mock( 'now', sub { return $now_value->clone; } );
 107
 108 # Start transaction
 109 $dbh->{RaiseError} = 1;
 110
 111 my $cache = Koha::Caches->get_instance();
 112 $dbh->do(q|DELETE FROM special_holidays|);
 113 $dbh->do(q|DELETE FROM repeatable_holidays|);
 114 $cache->clear_from_cache('single_holidays');
 115
 116 # Start with a clean slate
 117 $dbh->do('DELETE FROM issues');
 118 $dbh->do('DELETE FROM borrowers');
 119
 120 my $library = $builder->build({
 121     source => 'Branch',
 122 });
 123 my $library2 = $builder->build({
 124     source => 'Branch',
 125 });
 126 my $itemtype = $builder->build(
 127     {
 128         source => 'Itemtype',
 129         value  => {
 130             notforloan          => undef,
 131             rentalcharge        => 0,
 132             rentalcharge_daily => 0,
 133             defaultreplacecost  => undef,
 134             processfee          => undef
 135         }
 136     }
 137 )->{itemtype};
 138 my $patron_category = $builder->build(
 139     {
 140         source => 'Category',
 141         value  => {
 142             category_type                 => 'P',
 143             enrolmentfee                  => 0,
 144             BlockExpiredPatronOpacActions => -1, # Pick the pref value
 145         }
 146     }
 147 );
 148
 149 my $CircControl = C4::Context->preference('CircControl');
 150 my $HomeOrHoldingBranch = C4::Context->preference('HomeOrHoldingBranch');
 151
 152 my $item = {
 153     homebranch => $library2->{branchcode},
 154     holdingbranch => $library2->{branchcode}
 155 };
 156
 157 my $borrower = {
 158     branchcode => $library2->{branchcode}
 159 };
 160
 161 t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
 162
 163 # No userenv, PickupLibrary
 164 t::lib::Mocks::mock_preference('IndependentBranches', '0');
 165 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
 166 is(
 167     C4::Context->preference('CircControl'),
 168     'PickupLibrary',
 169     'CircControl changed to PickupLibrary'
 170 );
 171 is(
 172     C4::Circulation::_GetCircControlBranch($item, $borrower),
 173     $item->{$HomeOrHoldingBranch},
 174     '_GetCircControlBranch returned item branch (no userenv defined)'
 175 );
 176
 177 # No userenv, PatronLibrary
 178 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
 179 is(
 180     C4::Context->preference('CircControl'),
 181     'PatronLibrary',
 182     'CircControl changed to PatronLibrary'
 183 );
 184 is(
 185     C4::Circulation::_GetCircControlBranch($item, $borrower),
 186     $borrower->{branchcode},
 187     '_GetCircControlBranch returned borrower branch'
 188 );
 189
 190 # No userenv, ItemHomeLibrary
 191 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
 192 is(
 193     C4::Context->preference('CircControl'),
 194     'ItemHomeLibrary',
 195     'CircControl changed to ItemHomeLibrary'
 196 );
 197 is(
 198     $item->{$HomeOrHoldingBranch},
 199     C4::Circulation::_GetCircControlBranch($item, $borrower),
 200     '_GetCircControlBranch returned item branch'
 201 );
 202
 203 # Now, set a userenv
 204 t::lib::Mocks::mock_userenv({ branchcode => $library2->{branchcode} });
 205 is(C4::Context->userenv->{branch}, $library2->{branchcode}, 'userenv set');
 206
 207 # Userenv set, PickupLibrary
 208 t::lib::Mocks::mock_preference('CircControl', 'PickupLibrary');
 209 is(
 210     C4::Context->preference('CircControl'),
 211     'PickupLibrary',
 212     'CircControl changed to PickupLibrary'
 213 );
 214 is(
 215     C4::Circulation::_GetCircControlBranch($item, $borrower),
 216     $library2->{branchcode},
 217     '_GetCircControlBranch returned current branch'
 218 );
 219
 220 # Userenv set, PatronLibrary
 221 t::lib::Mocks::mock_preference('CircControl', 'PatronLibrary');
 222 is(
 223     C4::Context->preference('CircControl'),
 224     'PatronLibrary',
 225     'CircControl changed to PatronLibrary'
 226 );
 227 is(
 228     C4::Circulation::_GetCircControlBranch($item, $borrower),
 229     $borrower->{branchcode},
 230     '_GetCircControlBranch returned borrower branch'
 231 );
 232
 233 # Userenv set, ItemHomeLibrary
 234 t::lib::Mocks::mock_preference('CircControl', 'ItemHomeLibrary');
 235 is(
 236     C4::Context->preference('CircControl'),
 237     'ItemHomeLibrary',
 238     'CircControl changed to ItemHomeLibrary'
 239 );
 240 is(
 241     C4::Circulation::_GetCircControlBranch($item, $borrower),
 242     $item->{$HomeOrHoldingBranch},
 243     '_GetCircControlBranch returned item branch'
 244 );
 245
 246 # Reset initial configuration
 247 t::lib::Mocks::mock_preference('CircControl', $CircControl);
 248 is(
 249     C4::Context->preference('CircControl'),
 250     $CircControl,
 251     'CircControl reset to its initial value'
 252 );
 253
 254 # Set a simple circ policy
 255 $dbh->do('DELETE FROM issuingrules');
 256 Koha::CirculationRules->search()->delete();
 257 $dbh->do(
 258     q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
 259                                 issuelength, lengthunit,
 260                                 renewalsallowed, renewalperiod,
 261                                 norenewalbefore, auto_renew,
 262                                 fine, chargeperiod)
 263       VALUES (?, ?, ?, ?,
 264               ?, ?,
 265               ?, ?,
 266               ?, ?,
 267               ?, ?
 268              )
 269     },
 270     {},
 271     '*', '*', '*', 25,
 272     14, 'days',
 273     1, 7,
 274     undef, 0,
 275     .10, 1
 276 );
 277
 278 my ( $reused_itemnumber_1, $reused_itemnumber_2 );
 279 subtest "CanBookBeRenewed tests" => sub {
 280     plan tests => 71;
 281
 282     C4::Context->set_preference('ItemsDeniedRenewal','');
 283     # Generate test biblio
 284     my $biblio = $builder->build_sample_biblio();
 285
 286     my $branch = $library2->{branchcode};
 287
 288     my $item_1 = $builder->build_sample_item(
 289         {
 290             biblionumber     => $biblio->biblionumber,
 291             library          => $branch,
 292             replacementprice => 12.00,
 293             itype            => $itemtype
 294         }
 295     );
 296     $reused_itemnumber_1 = $item_1->itemnumber;
 297
 298     my $item_2 = $builder->build_sample_item(
 299         {
 300             biblionumber     => $biblio->biblionumber,
 301             library          => $branch,
 302             replacementprice => 23.00,
 303             itype            => $itemtype
 304         }
 305     );
 306     $reused_itemnumber_2 = $item_2->itemnumber;
 307
 308     my $item_3 = $builder->build_sample_item(
 309         {
 310             biblionumber     => $biblio->biblionumber,
 311             library          => $branch,
 312             replacementprice => 23.00,
 313             itype            => $itemtype
 314         }
 315     );
 316
 317     # Create borrowers
 318     my %renewing_borrower_data = (
 319         firstname =>  'John',
 320         surname => 'Renewal',
 321         categorycode => $patron_category->{categorycode},
 322         branchcode => $branch,
 323     );
 324
 325     my %reserving_borrower_data = (
 326         firstname =>  'Katrin',
 327         surname => 'Reservation',
 328         categorycode => $patron_category->{categorycode},
 329         branchcode => $branch,
 330     );
 331
 332     my %hold_waiting_borrower_data = (
 333         firstname =>  'Kyle',
 334         surname => 'Reservation',
 335         categorycode => $patron_category->{categorycode},
 336         branchcode => $branch,
 337     );
 338
 339     my %restricted_borrower_data = (
 340         firstname =>  'Alice',
 341         surname => 'Reservation',
 342         categorycode => $patron_category->{categorycode},
 343         debarred => '3228-01-01',
 344         branchcode => $branch,
 345     );
 346
 347     my %expired_borrower_data = (
 348         firstname =>  'Ça',
 349         surname => 'Glisse',
 350         categorycode => $patron_category->{categorycode},
 351         branchcode => $branch,
 352         dateexpiry => dt_from_string->subtract( months => 1 ),
 353     );
 354
 355     my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
 356     my $reserving_borrowernumber = Koha::Patron->new(\%reserving_borrower_data)->store->borrowernumber;
 357     my $hold_waiting_borrowernumber = Koha::Patron->new(\%hold_waiting_borrower_data)->store->borrowernumber;
 358     my $restricted_borrowernumber = Koha::Patron->new(\%restricted_borrower_data)->store->borrowernumber;
 359     my $expired_borrowernumber = Koha::Patron->new(\%expired_borrower_data)->store->borrowernumber;
 360
 361     my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
 362     my $restricted_borrower = Koha::Patrons->find( $restricted_borrowernumber )->unblessed;
 363     my $expired_borrower = Koha::Patrons->find( $expired_borrowernumber )->unblessed;
 364
 365     my $bibitems       = '';
 366     my $priority       = '1';
 367     my $resdate        = undef;
 368     my $expdate        = undef;
 369     my $notes          = '';
 370     my $checkitem      = undef;
 371     my $found          = undef;
 372
 373     my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
 374     my $datedue = dt_from_string( $issue->date_due() );
 375     is (defined $issue->date_due(), 1, "Item 1 checked out, due date: " . $issue->date_due() );
 376
 377     my $issue2 = AddIssue( $renewing_borrower, $item_2->barcode);
 378     $datedue = dt_from_string( $issue->date_due() );
 379     is (defined $issue2, 1, "Item 2 checked out, due date: " . $issue2->date_due());
 380
 381
 382     my $borrowing_borrowernumber = Koha::Checkouts->find( { itemnumber => $item_1->itemnumber } )->borrowernumber;
 383     is ($borrowing_borrowernumber, $renewing_borrowernumber, "Item checked out to $renewing_borrower->{firstname} $renewing_borrower->{surname}");
 384
 385     my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
 386     is( $renewokay, 1, 'Can renew, no holds for this title or item');
 387
 388
 389     # Biblio-level hold, renewal test
 390     AddReserve(
 391         $branch, $reserving_borrowernumber, $biblio->biblionumber,
 392         $bibitems,  $priority, $resdate, $expdate, $notes,
 393         'a title', $checkitem, $found
 394     );
 395
 396     # Testing of feature to allow the renewal of reserved items if other items on the record can fill all needed holds
 397     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
 398     t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 1 );
 399     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
 400     is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 401     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
 402     is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 403
 404     # Now let's add an item level hold, we should no longer be able to renew the item
 405     my $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
 406         {
 407             borrowernumber => $hold_waiting_borrowernumber,
 408             biblionumber   => $biblio->biblionumber,
 409             itemnumber     => $item_1->itemnumber,
 410             branchcode     => $branch,
 411             priority       => 3,
 412         }
 413     );
 414     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
 415     is( $renewokay, 0, 'Bug 13919 - Renewal possible with item level hold on item');
 416     $hold->delete();
 417
 418     # Now let's add a waiting hold on the 3rd item, it's no longer available tp check out by just anyone, so we should no longer
 419     # be able to renew these items
 420     $hold = Koha::Database->new()->schema()->resultset('Reserve')->create(
 421         {
 422             borrowernumber => $hold_waiting_borrowernumber,
 423             biblionumber   => $biblio->biblionumber,
 424             itemnumber     => $item_3->itemnumber,
 425             branchcode     => $branch,
 426             priority       => 0,
 427             found          => 'W'
 428         }
 429     );
 430     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
 431     is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 432     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
 433     is( $renewokay, 0, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds');
 434     t::lib::Mocks::mock_preference('AllowRenewalIfOtherItemsAvailable', 0 );
 435
 436     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
 437     is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
 438     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
 439
 440     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
 441     is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved');
 442     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)');
 443
 444     my $reserveid = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next->reserve_id;
 445     my $reserving_borrower = Koha::Patrons->find( $reserving_borrowernumber )->unblessed;
 446     AddIssue($reserving_borrower, $item_3->barcode);
 447     my $reserve = $dbh->selectrow_hashref(
 448         'SELECT * FROM old_reserves WHERE reserve_id = ?',
 449         { Slice => {} },
 450         $reserveid
 451     );
 452     is($reserve->{found}, 'F', 'hold marked completed when checking out item that fills it');
 453
 454     # Item-level hold, renewal test
 455     AddReserve(
 456         $branch, $reserving_borrowernumber, $biblio->biblionumber,
 457         $bibitems,  $priority, $resdate, $expdate, $notes,
 458         'a title', $item_1->itemnumber, $found
 459     );
 460
 461     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
 462     is( $renewokay, 0, '(Bug 10663) Cannot renew, item reserved');
 463     is( $error, 'on_reserve', '(Bug 10663) Cannot renew, item reserved (returned error is on_reserve)');
 464
 465     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber, 1);
 466     is( $renewokay, 1, 'Can renew item 2, item-level hold is on item 1');
 467
 468     # Items can't fill hold for reasons
 469     ModItem({ notforloan => 1 }, $biblio->biblionumber, $item_1->itemnumber);
 470     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
 471     is( $renewokay, 1, 'Can renew, item is marked not for loan, hold does not block');
 472     ModItem({ notforloan => 0, itype => $itemtype }, $biblio->biblionumber, $item_1->itemnumber);
 473
 474     # FIXME: Add more for itemtype not for loan etc.
 475
 476     # Restricted users cannot renew when RestrictionBlockRenewing is enabled
 477     my $item_5 = $builder->build_sample_item(
 478         {
 479             biblionumber     => $biblio->biblionumber,
 480             library          => $branch,
 481             replacementprice => 23.00,
 482             itype            => $itemtype,
 483         }
 484     );
 485     my $datedue5 = AddIssue($restricted_borrower, $item_5->barcode);
 486     is (defined $datedue5, 1, "Item with date due checked out, due date: $datedue5");
 487
 488     t::lib::Mocks::mock_preference('RestrictionBlockRenewing','1');
 489     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_2->itemnumber);
 490     is( $renewokay, 1, '(Bug 8236), Can renew, user is not restricted');
 491     ( $renewokay, $error ) = CanBookBeRenewed($restricted_borrowernumber, $item_5->itemnumber);
 492     is( $renewokay, 0, '(Bug 8236), Cannot renew, user is restricted');
 493
 494     # Users cannot renew an overdue item
 495     my $item_6 = $builder->build_sample_item(
 496         {
 497             biblionumber     => $biblio->biblionumber,
 498             library          => $branch,
 499             replacementprice => 23.00,
 500             itype            => $itemtype,
 501         }
 502     );
 503
 504     my $item_7 = $builder->build_sample_item(
 505         {
 506             biblionumber     => $biblio->biblionumber,
 507             library          => $branch,
 508             replacementprice => 23.00,
 509             itype            => $itemtype,
 510         }
 511     );
 512
 513     my $datedue6 = AddIssue( $renewing_borrower, $item_6->barcode);
 514     is (defined $datedue6, 1, "Item 2 checked out, due date: ".$datedue6->date_due);
 515
 516     my $now = dt_from_string();
 517     my $five_weeks = DateTime::Duration->new(weeks => 5);
 518     my $five_weeks_ago = $now - $five_weeks;
 519     t::lib::Mocks::mock_preference('finesMode', 'production');
 520
 521     my $passeddatedue1 = AddIssue($renewing_borrower, $item_7->barcode, $five_weeks_ago);
 522     is (defined $passeddatedue1, 1, "Item with passed date due checked out, due date: " . $passeddatedue1->date_due);
 523
 524     my ( $fine ) = CalcFine( $item_7->unblessed, $renewing_borrower->{categorycode}, $branch, $five_weeks_ago, $now );
 525     C4::Overdues::UpdateFine(
 526         {
 527             issue_id       => $passeddatedue1->id(),
 528             itemnumber     => $item_7->itemnumber,
 529             borrowernumber => $renewing_borrower->{borrowernumber},
 530             amount         => $fine,
 531             due            => Koha::DateUtils::output_pref($five_weeks_ago)
 532         }
 533     );
 534
 535     t::lib::Mocks::mock_preference('RenewalLog', 0);
 536     my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
 537     my %params_renewal = (
 538         timestamp => { -like => $date . "%" },
 539         module => "CIRCULATION",
 540         action => "RENEWAL",
 541     );
 542     my %params_issue = (
 543         timestamp => { -like => $date . "%" },
 544         module => "CIRCULATION",
 545         action => "ISSUE"
 546     );
 547     my $old_log_size = Koha::ActionLogs->count( \%params_renewal );
 548     my $dt = dt_from_string();
 549     Time::Fake->offset( $dt->epoch );
 550     my $datedue1 = AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
 551     my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
 552     is ($new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog');
 553     isnt (DateTime->compare($datedue1, $dt), 0, "AddRenewal returned a good duedate");
 554     Time::Fake->reset;
 555
 556     t::lib::Mocks::mock_preference('RenewalLog', 1);
 557     $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
 558     $old_log_size = Koha::ActionLogs->count( \%params_renewal );
 559     AddRenewal( $renewing_borrower->{borrowernumber}, $item_7->itemnumber, $branch );
 560     $new_log_size = Koha::ActionLogs->count( \%params_renewal );
 561     is ($new_log_size, $old_log_size + 1, 'renew log successfully added');
 562
 563     my $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
 564     is( $fines->count, 2, 'AddRenewal left both fines' );
 565     isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
 566     isnt( $fines->next->status, 'UNRETURNED', 'Fine on renewed item is closed out properly' );
 567     $fines->delete();
 568
 569
 570     my $old_issue_log_size = Koha::ActionLogs->count( \%params_issue );
 571     my $old_renew_log_size = Koha::ActionLogs->count( \%params_renewal );
 572     AddIssue( $renewing_borrower,$item_7->barcode,Koha::DateUtils::output_pref({str=>$datedue6->date_due, dateformat =>'iso'}),0,$date, 0, undef );
 573     $new_log_size = Koha::ActionLogs->count( \%params_renewal );
 574     is ($new_log_size, $old_renew_log_size + 1, 'renew log successfully added when renewed via issuing');
 575     $new_log_size = Koha::ActionLogs->count( \%params_issue );
 576     is ($new_log_size, $old_issue_log_size, 'renew not logged as issue when renewed via issuing');
 577
 578     $fines = Koha::Account::Lines->search( { borrowernumber => $renewing_borrower->{borrowernumber}, itemnumber => $item_7->itemnumber } );
 579     $fines->delete();
 580
 581     t::lib::Mocks::mock_preference('OverduesBlockRenewing','blockitem');
 582     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
 583     is( $renewokay, 1, '(Bug 8236), Can renew, this item is not overdue');
 584     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
 585     is( $renewokay, 0, '(Bug 8236), Cannot renew, this item is overdue');
 586
 587
 588     $hold = Koha::Holds->search({ biblionumber => $biblio->biblionumber, borrowernumber => $reserving_borrowernumber })->next;
 589     $hold->cancel;
 590
 591     # Bug 14101
 592     # Test automatic renewal before value for "norenewalbefore" in policy is set
 593     # In this case automatic renewal is not permitted prior to due date
 594     my $item_4 = $builder->build_sample_item(
 595         {
 596             biblionumber     => $biblio->biblionumber,
 597             library          => $branch,
 598             replacementprice => 16.00,
 599             itype            => $itemtype,
 600         }
 601     );
 602
 603     $issue = AddIssue( $renewing_borrower, $item_4->barcode, undef, undef, undef, undef, { auto_renew => 1 } );
 604     ( $renewokay, $error ) =
 605       CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
 606     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
 607     is( $error, 'auto_too_soon',
 608         'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = undef (returned code is auto_too_soon)' );
 609
 610     # Bug 7413
 611     # Test premature manual renewal
 612     $dbh->do('UPDATE issuingrules SET norenewalbefore = 7');
 613
 614     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
 615     is( $renewokay, 0, 'Bug 7413: Cannot renew, renewal is premature');
 616     is( $error, 'too_soon', 'Bug 7413: Cannot renew, renewal is premature (returned code is too_soon)');
 617
 618     # Bug 14395
 619     # Test 'exact time' setting for syspref NoRenewalBeforePrecision
 620     t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'exact_time' );
 621     is(
 622         GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
 623         $datedue->clone->add( days => -7 ),
 624         'Bug 14395: Renewals permitted 7 days before due date, as expected'
 625     );
 626
 627     # Bug 14395
 628     # Test 'date' setting for syspref NoRenewalBeforePrecision
 629     t::lib::Mocks::mock_preference( 'NoRenewalBeforePrecision', 'date' );
 630     is(
 631         GetSoonestRenewDate( $renewing_borrowernumber, $item_1->itemnumber ),
 632         $datedue->clone->add( days => -7 )->truncate( to => 'day' ),
 633         'Bug 14395: Renewals permitted 7 days before due date, as expected'
 634     );
 635
 636     # Bug 14101
 637     # Test premature automatic renewal
 638     ( $renewokay, $error ) =
 639       CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
 640     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
 641     is( $error, 'auto_too_soon',
 642         'Bug 14101: Cannot renew, renewal is automatic and premature (returned code is auto_too_soon)'
 643     );
 644
 645     # Change policy so that loans can only be renewed exactly on due date (0 days prior to due date)
 646     # and test automatic renewal again
 647     $dbh->do('UPDATE issuingrules SET norenewalbefore = 0');
 648     ( $renewokay, $error ) =
 649       CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
 650     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic and premature' );
 651     is( $error, 'auto_too_soon',
 652         'Bug 14101: Cannot renew, renewal is automatic and premature, "No renewal before" = 0 (returned code is auto_too_soon)'
 653     );
 654
 655     # Change policy so that loans can be renewed 99 days prior to the due date
 656     # and test automatic renewal again
 657     $dbh->do('UPDATE issuingrules SET norenewalbefore = 99');
 658     ( $renewokay, $error ) =
 659       CanBookBeRenewed( $renewing_borrowernumber, $item_4->itemnumber );
 660     is( $renewokay, 0, 'Bug 14101: Cannot renew, renewal is automatic' );
 661     is( $error, 'auto_renew',
 662         'Bug 14101: Cannot renew, renewal is automatic (returned code is auto_renew)'
 663     );
 664
 665     subtest "too_late_renewal / no_auto_renewal_after" => sub {
 666         plan tests => 14;
 667         my $item_to_auto_renew = $builder->build(
 668             {   source => 'Item',
 669                 value  => {
 670                     biblionumber  => $biblio->biblionumber,
 671                     homebranch    => $branch,
 672                     holdingbranch => $branch,
 673                 }
 674             }
 675         );
 676
 677         my $ten_days_before = dt_from_string->add( days => -10 );
 678         my $ten_days_ahead  = dt_from_string->add( days => 10 );
 679         AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
 680
 681         $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 9');
 682         ( $renewokay, $error ) =
 683           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 684         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 685         is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
 686
 687         $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 10');
 688         ( $renewokay, $error ) =
 689           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 690         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 691         is( $error, 'auto_too_late', 'Cannot auto renew, too late - no_auto_renewal_after is inclusive(returned code is auto_too_late)' );
 692
 693         $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 11');
 694         ( $renewokay, $error ) =
 695           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 696         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 697         is( $error, 'auto_too_soon', 'Cannot auto renew, too soon - no_auto_renewal_after is defined(returned code is auto_too_soon)' );
 698
 699         $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
 700         ( $renewokay, $error ) =
 701           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 702         is( $renewokay, 0,            'Do not renew, renewal is automatic' );
 703         is( $error,     'auto_renew', 'Cannot renew, renew is automatic' );
 704
 705         $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => -1 ) );
 706         ( $renewokay, $error ) =
 707           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 708         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 709         is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
 710
 711         $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => -1 ) );
 712         ( $renewokay, $error ) =
 713           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 714         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 715         is( $error, 'auto_too_late', 'Cannot renew, too late(returned code is auto_too_late)' );
 716
 717         $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 1 ) );
 718         ( $renewokay, $error ) =
 719           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 720         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 721         is( $error, 'auto_renew', 'Cannot renew, renew is automatic' );
 722     };
 723
 724     subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew" => sub {
 725         plan tests => 6;
 726         my $item_to_auto_renew = $builder->build({
 727             source => 'Item',
 728             value => {
 729                 biblionumber => $biblio->biblionumber,
 730                 homebranch       => $branch,
 731                 holdingbranch    => $branch,
 732             }
 733         });
 734
 735         my $ten_days_before = dt_from_string->add( days => -10 );
 736         my $ten_days_ahead = dt_from_string->add( days => 10 );
 737         AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
 738
 739         $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
 740         C4::Context->set_preference('OPACFineNoRenewalsBlockAutoRenew','1');
 741         C4::Context->set_preference('OPACFineNoRenewals','10');
 742         my $fines_amount = 5;
 743         my $account = Koha::Account->new({patron_id => $renewing_borrowernumber});
 744         $account->add_debit(
 745             {
 746                 amount      => $fines_amount,
 747                 interface   => 'test',
 748                 type        => 'overdue',
 749                 item_id     => $item_to_auto_renew->{itemnumber},
 750                 description => "Some fines"
 751             }
 752         )->status('RETURNED')->store;
 753         ( $renewokay, $error ) =
 754           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 755         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 756         is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 5' );
 757
 758         $account->add_debit(
 759             {
 760                 amount      => $fines_amount,
 761                 interface   => 'test',
 762                 type        => 'overdue',
 763                 item_id     => $item_to_auto_renew->{itemnumber},
 764                 description => "Some fines"
 765             }
 766         )->status('RETURNED')->store;
 767         ( $renewokay, $error ) =
 768           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 769         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 770         is( $error, 'auto_renew', 'Can auto renew, OPACFineNoRenewals=10, patron has 10' );
 771
 772         $account->add_debit(
 773             {
 774                 amount      => $fines_amount,
 775                 interface   => 'test',
 776                 type        => 'overdue',
 777                 item_id     => $item_to_auto_renew->{itemnumber},
 778                 description => "Some fines"
 779             }
 780         )->status('RETURNED')->store;
 781         ( $renewokay, $error ) =
 782           CanBookBeRenewed( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 783         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 784         is( $error, 'auto_too_much_oweing', 'Cannot auto renew, OPACFineNoRenewals=10, patron has 15' );
 785
 786         $dbh->do('DELETE FROM accountlines WHERE borrowernumber=?', undef, $renewing_borrowernumber);
 787     };
 788
 789     subtest "auto_account_expired | BlockExpiredPatronOpacActions" => sub {
 790         plan tests => 6;
 791         my $item_to_auto_renew = $builder->build({
 792             source => 'Item',
 793             value => {
 794                 biblionumber => $biblio->biblionumber,
 795                 homebranch       => $branch,
 796                 holdingbranch    => $branch,
 797             }
 798         });
 799
 800         $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 11');
 801
 802         my $ten_days_before = dt_from_string->add( days => -10 );
 803         my $ten_days_ahead = dt_from_string->add( days => 10 );
 804
 805         # Patron is expired and BlockExpiredPatronOpacActions=0
 806         # => auto renew is allowed
 807         t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 0);
 808         my $patron = $expired_borrower;
 809         my $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
 810         ( $renewokay, $error ) =
 811           CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
 812         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 813         is( $error, 'auto_renew', 'Can auto renew, patron is expired but BlockExpiredPatronOpacActions=0' );
 814         Koha::Checkouts->find( $checkout->issue_id )->delete;
 815
 816
 817         # Patron is expired and BlockExpiredPatronOpacActions=1
 818         # => auto renew is not allowed
 819         t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
 820         $patron = $expired_borrower;
 821         $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
 822         ( $renewokay, $error ) =
 823           CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
 824         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 825         is( $error, 'auto_account_expired', 'Can not auto renew, lockExpiredPatronOpacActions=1 and patron is expired' );
 826         Koha::Checkouts->find( $checkout->issue_id )->delete;
 827
 828
 829         # Patron is not expired and BlockExpiredPatronOpacActions=1
 830         # => auto renew is allowed
 831         t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
 832         $patron = $renewing_borrower;
 833         $checkout = AddIssue( $patron, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
 834         ( $renewokay, $error ) =
 835           CanBookBeRenewed( $patron->{borrowernumber}, $item_to_auto_renew->{itemnumber} );
 836         is( $renewokay, 0, 'Do not renew, renewal is automatic' );
 837         is( $error, 'auto_renew', 'Can auto renew, BlockExpiredPatronOpacActions=1 but patron is not expired' );
 838         Koha::Checkouts->find( $checkout->issue_id )->delete;
 839     };
 840
 841     subtest "GetLatestAutoRenewDate" => sub {
 842         plan tests => 5;
 843         my $item_to_auto_renew = $builder->build(
 844             {   source => 'Item',
 845                 value  => {
 846                     biblionumber  => $biblio->biblionumber,
 847                     homebranch    => $branch,
 848                     holdingbranch => $branch,
 849                 }
 850             }
 851         );
 852
 853         my $ten_days_before = dt_from_string->add( days => -10 );
 854         my $ten_days_ahead  = dt_from_string->add( days => 10 );
 855         AddIssue( $renewing_borrower, $item_to_auto_renew->{barcode}, $ten_days_ahead, undef, $ten_days_before, undef, { auto_renew => 1 } );
 856         $dbh->do('UPDATE issuingrules SET norenewalbefore = 7, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = NULL');
 857         my $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 858         is( $latest_auto_renew_date, undef, 'GetLatestAutoRenewDate should return undef if no_auto_renewal_after or no_auto_renewal_after_hard_limit are not defined' );
 859         my $five_days_before = dt_from_string->add( days => -5 );
 860         $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 5, no_auto_renewal_after_hard_limit = NULL');
 861         $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 862         is( $latest_auto_renew_date->truncate( to => 'minute' ),
 863             $five_days_before->truncate( to => 'minute' ),
 864             'GetLatestAutoRenewDate should return -5 days if no_auto_renewal_after = 5 and date_due is 10 days before'
 865         );
 866         my $five_days_ahead = dt_from_string->add( days => 5 );
 867         $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = NULL');
 868         $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 869         is( $latest_auto_renew_date->truncate( to => 'minute' ),
 870             $five_days_ahead->truncate( to => 'minute' ),
 871             'GetLatestAutoRenewDate should return +5 days if no_auto_renewal_after = 15 and date_due is 10 days before'
 872         );
 873         my $two_days_ahead = dt_from_string->add( days => 2 );
 874         $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = NULL, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 2 ) );
 875         $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 876         is( $latest_auto_renew_date->truncate( to => 'day' ),
 877             $two_days_ahead->truncate( to => 'day' ),
 878             'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is defined and not no_auto_renewal_after'
 879         );
 880         $dbh->do('UPDATE issuingrules SET norenewalbefore = 10, no_auto_renewal_after = 15, no_auto_renewal_after_hard_limit = ?', undef, dt_from_string->add( days => 2 ) );
 881         $latest_auto_renew_date = GetLatestAutoRenewDate( $renewing_borrowernumber, $item_to_auto_renew->{itemnumber} );
 882         is( $latest_auto_renew_date->truncate( to => 'day' ),
 883             $two_days_ahead->truncate( to => 'day' ),
 884             'GetLatestAutoRenewDate should return +2 days if no_auto_renewal_after_hard_limit is < no_auto_renewal_after'
 885         );
 886
 887     };
 888
 889     # Too many renewals
 890
 891     # set policy to forbid renewals
 892     $dbh->do('UPDATE issuingrules SET norenewalbefore = NULL, renewalsallowed = 0');
 893
 894     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber);
 895     is( $renewokay, 0, 'Cannot renew, 0 renewals allowed');
 896     is( $error, 'too_many', 'Cannot renew, 0 renewals allowed (returned code is too_many)');
 897
 898     # Test WhenLostForgiveFine and WhenLostChargeReplacementFee
 899     t::lib::Mocks::mock_preference('WhenLostForgiveFine','1');
 900     t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
 901
 902     C4::Overdues::UpdateFine(
 903         {
 904             issue_id       => $issue->id(),
 905             itemnumber     => $item_1->itemnumber,
 906             borrowernumber => $renewing_borrower->{borrowernumber},
 907             amount         => 15.00,
 908             type           => q{},
 909             due            => Koha::DateUtils::output_pref($datedue)
 910         }
 911     );
 912
 913     my $line = Koha::Account::Lines->search({ borrowernumber => $renewing_borrower->{borrowernumber} })->next();
 914     is( $line->accounttype, 'OVERDUE', 'Account line type is OVERDUE' );
 915     is( $line->status, 'UNRETURNED', 'Account line status is UNRETURNED' );
 916     is( $line->amountoutstanding, '15.000000', 'Account line amount outstanding is 15.00' );
 917     is( $line->amount, '15.000000', 'Account line amount is 15.00' );
 918     is( $line->issue_id, $issue->id, 'Account line issue id matches' );
 919
 920     my $offset = Koha::Account::Offsets->search({ debit_id => $line->id })->next();
 921     is( $offset->type, 'OVERDUE', 'Account offset type is Fine' );
 922     is( $offset->amount, '15.000000', 'Account offset amount is 15.00' );
 923
 924     t::lib::Mocks::mock_preference('WhenLostForgiveFine','0');
 925     t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','0');
 926
 927     LostItem( $item_1->itemnumber, 'test', 1 );
 928
 929     $line = Koha::Account::Lines->find($line->id);
 930     is( $line->accounttype, 'OVERDUE', 'Account type remains as OVERDUE' );
 931     isnt( $line->status, 'UNRETURNED', 'Account status correctly changed from UNRETURNED to RETURNED' );
 932
 933     my $item = Koha::Items->find($item_1->itemnumber);
 934     ok( !$item->onloan(), "Lost item marked as returned has false onloan value" );
 935     my $checkout = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber });
 936     is( $checkout, undef, 'LostItem called with forced return has checked in the item' );
 937
 938     my $total_due = $dbh->selectrow_array(
 939         'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
 940         undef, $renewing_borrower->{borrowernumber}
 941     );
 942
 943     is( $total_due, '15.000000', 'Borrower only charged replacement fee with both WhenLostForgiveFine and WhenLostChargeReplacementFee enabled' );
 944
 945     C4::Context->dbh->do("DELETE FROM accountlines");
 946
 947     C4::Overdues::UpdateFine(
 948         {
 949             issue_id       => $issue2->id(),
 950             itemnumber     => $item_2->itemnumber,
 951             borrowernumber => $renewing_borrower->{borrowernumber},
 952             amount         => 15.00,
 953             type           => q{},
 954             due            => Koha::DateUtils::output_pref($datedue)
 955         }
 956     );
 957
 958     LostItem( $item_2->itemnumber, 'test', 0 );
 959
 960     my $item2 = Koha::Items->find($item_2->itemnumber);
 961     ok( $item2->onloan(), "Lost item *not* marked as returned has true onloan value" );
 962     ok( Koha::Checkouts->find({ itemnumber => $item_2->itemnumber }), 'LostItem called without forced return has checked in the item' );
 963
 964     $total_due = $dbh->selectrow_array(
 965         'SELECT SUM( amountoutstanding ) FROM accountlines WHERE borrowernumber = ?',
 966         undef, $renewing_borrower->{borrowernumber}
 967     );
 968
 969     ok( $total_due == 15, 'Borrower only charged fine with both WhenLostForgiveFine and WhenLostChargeReplacementFee disabled' );
 970
 971     my $future = dt_from_string();
 972     $future->add( days => 7 );
 973     my $units = C4::Overdues::get_chargeable_units('days', $future, $now, $library2->{branchcode});
 974     ok( $units == 0, '_get_chargeable_units returns 0 for items not past due date (Bug 12596)' );
 975
 976     # Users cannot renew any item if there is an overdue item
 977     t::lib::Mocks::mock_preference('OverduesBlockRenewing','block');
 978     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_6->itemnumber);
 979     is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
 980     ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_7->itemnumber);
 981     is( $renewokay, 0, '(Bug 8236), Cannot renew, one of the items is overdue');
 982
 983     my $manager = $builder->build_object({ class => "Koha::Patrons" });
 984     t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
 985     t::lib::Mocks::mock_preference('WhenLostChargeReplacementFee','1');
 986     $checkout = Koha::Checkouts->find( { itemnumber => $item_3->itemnumber } );
 987     LostItem( $item_3->itemnumber, 'test', 0 );
 988     my $accountline = Koha::Account::Lines->find( { itemnumber => $item_3->itemnumber } );
 989     is( $accountline->issue_id, $checkout->id, "Issue id added for lost replacement fee charge" );
 990     is(
 991         $accountline->description,
 992         sprintf( "%s %s %s",
 993             $item_3->biblio->title  || '',
 994             $item_3->barcode        || '',
 995             $item_3->itemcallnumber || '' ),
 996         "Account line description must not contain 'Lost Items ', but be title, barcode, itemcallnumber"
 997     );
 998 };
 999
1000 subtest "GetUpcomingDueIssues" => sub {
1001     plan tests => 12;
1002
1003     my $branch   = $library2->{branchcode};
1004
1005     #Create another record
1006     my $biblio2 = $builder->build_sample_biblio();
1007
1008     #Create third item
1009     my $item_1 = Koha::Items->find($reused_itemnumber_1);
1010     my $item_2 = Koha::Items->find($reused_itemnumber_2);
1011     my $item_3 = $builder->build_sample_item(
1012         {
1013             biblionumber     => $biblio2->biblionumber,
1014             library          => $branch,
1015             itype            => $itemtype,
1016         }
1017     );
1018
1019
1020     # Create a borrower
1021     my %a_borrower_data = (
1022         firstname =>  'Fridolyn',
1023         surname => 'SOMERS',
1024         categorycode => $patron_category->{categorycode},
1025         branchcode => $branch,
1026     );
1027
1028     my $a_borrower_borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1029     my $a_borrower = Koha::Patrons->find( $a_borrower_borrowernumber )->unblessed;
1030
1031     my $yesterday = DateTime->today(time_zone => C4::Context->tz())->add( days => -1 );
1032     my $two_days_ahead = DateTime->today(time_zone => C4::Context->tz())->add( days => 2 );
1033     my $today = DateTime->today(time_zone => C4::Context->tz());
1034
1035     my $issue = AddIssue( $a_borrower, $item_1->barcode, $yesterday );
1036     my $datedue = dt_from_string( $issue->date_due() );
1037     my $issue2 = AddIssue( $a_borrower, $item_2->barcode, $two_days_ahead );
1038     my $datedue2 = dt_from_string( $issue->date_due() );
1039
1040     my $upcoming_dues;
1041
1042     # GetUpcomingDueIssues tests
1043     for my $i(0..1) {
1044         $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1045         is ( scalar( @$upcoming_dues ), 0, "No items due in less than one day ($i days in advance)" );
1046     }
1047
1048     #days_in_advance needs to be inclusive, so 1 matches items due tomorrow, 0 items due today etc.
1049     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 } );
1050     is ( scalar ( @$upcoming_dues), 1, "Only one item due in 2 days or less" );
1051
1052     for my $i(3..5) {
1053         $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => $i } );
1054         is ( scalar( @$upcoming_dues ), 1,
1055             "Bug 9362: Only one item due in more than 2 days ($i days in advance)" );
1056     }
1057
1058     # Bug 11218 - Due notices not generated - GetUpcomingDueIssues needs to select due today items as well
1059
1060     my $issue3 = AddIssue( $a_borrower, $item_3->barcode, $today );
1061
1062     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => -1 } );
1063     is ( scalar ( @$upcoming_dues), 0, "Overdues can not be selected" );
1064
1065     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 0 } );
1066     is ( scalar ( @$upcoming_dues), 1, "1 item is due today" );
1067
1068     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 1 } );
1069     is ( scalar ( @$upcoming_dues), 1, "1 item is due today, none tomorrow" );
1070
1071     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 2 }  );
1072     is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1073
1074     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues( { days_in_advance => 3 } );
1075     is ( scalar ( @$upcoming_dues), 2, "2 items are due withing 2 days" );
1076
1077     $upcoming_dues = C4::Circulation::GetUpcomingDueIssues();
1078     is ( scalar ( @$upcoming_dues), 2, "days_in_advance is 7 in GetUpcomingDueIssues if not provided" );
1079
1080 };
1081
1082 subtest "Bug 13841 - Do not create new 0 amount fines" => sub {
1083     my $branch   = $library2->{branchcode};
1084
1085     my $biblio = $builder->build_sample_biblio();
1086
1087     #Create third item
1088     my $item = $builder->build_sample_item(
1089         {
1090             biblionumber     => $biblio->biblionumber,
1091             library          => $branch,
1092             itype            => $itemtype,
1093         }
1094     );
1095
1096     # Create a borrower
1097     my %a_borrower_data = (
1098         firstname =>  'Kyle',
1099         surname => 'Hall',
1100         categorycode => $patron_category->{categorycode},
1101         branchcode => $branch,
1102     );
1103
1104     my $borrowernumber = Koha::Patron->new(\%a_borrower_data)->store->borrowernumber;
1105
1106     my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1107     my $issue = AddIssue( $borrower, $item->barcode );
1108     UpdateFine(
1109         {
1110             issue_id       => $issue->id(),
1111             itemnumber     => $item->itemnumber,
1112             borrowernumber => $borrowernumber,
1113             amount         => 0,
1114             type           => q{}
1115         }
1116     );
1117
1118     my $hr = $dbh->selectrow_hashref(q{SELECT COUNT(*) AS count FROM accountlines WHERE borrowernumber = ? AND itemnumber = ?}, undef, $borrowernumber, $item->itemnumber );
1119     my $count = $hr->{count};
1120
1121     is ( $count, 0, "Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine" );
1122 };
1123
1124 subtest "AllowRenewalIfOtherItemsAvailable tests" => sub {
1125     $dbh->do('DELETE FROM issues');
1126     $dbh->do('DELETE FROM items');
1127     $dbh->do('DELETE FROM issuingrules');
1128     Koha::CirculationRules->search()->delete();
1129     $dbh->do(
1130         q{
1131         INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, issuelength, lengthunit, renewalsallowed, renewalperiod,
1132                     norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
1133         },
1134         {},
1135         '*', '*', '*', 25,
1136         14,  'days',
1137         1,   7,
1138         undef,  0,
1139         .10, 1
1140     );
1141     Koha::CirculationRules->set_rules(
1142         {
1143             categorycode => '*',
1144             itemtype     => '*',
1145             branchcode   => '*',
1146             rules        => {
1147                 maxissueqty => 20
1148             }
1149         }
1150     );
1151     my $biblio = $builder->build_sample_biblio();
1152
1153     my $item_1 = $builder->build_sample_item(
1154         {
1155             biblionumber     => $biblio->biblionumber,
1156             library          => $library2->{branchcode},
1157             itype            => $itemtype,
1158         }
1159     );
1160
1161     my $item_2= $builder->build_sample_item(
1162         {
1163             biblionumber     => $biblio->biblionumber,
1164             library          => $library2->{branchcode},
1165             itype            => $itemtype,
1166         }
1167     );
1168
1169     my $borrowernumber1 = Koha::Patron->new({
1170         firstname    => 'Kyle',
1171         surname      => 'Hall',
1172         categorycode => $patron_category->{categorycode},
1173         branchcode   => $library2->{branchcode},
1174     })->store->borrowernumber;
1175     my $borrowernumber2 = Koha::Patron->new({
1176         firstname    => 'Chelsea',
1177         surname      => 'Hall',
1178         categorycode => $patron_category->{categorycode},
1179         branchcode   => $library2->{branchcode},
1180     })->store->borrowernumber;
1181
1182     my $borrower1 = Koha::Patrons->find( $borrowernumber1 )->unblessed;
1183     my $borrower2 = Koha::Patrons->find( $borrowernumber2 )->unblessed;
1184
1185     my $issue = AddIssue( $borrower1, $item_1->barcode );
1186
1187     my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1188     is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with no hold on the record' );
1189
1190     AddReserve(
1191         $library2->{branchcode}, $borrowernumber2, $biblio->biblionumber,
1192         '',  1, undef, undef, '',
1193         undef, undef, undef
1194     );
1195
1196     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
1197     t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1198     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1199     is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfholds are disabled' );
1200
1201     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 0");
1202     t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1203     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1204     is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled and onshelfholds is disabled' );
1205
1206     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
1207     t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 0 );
1208     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1209     is( $renewokay, 0, 'Bug 14337 - Verify the borrower cannot renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is disabled and onshelfhold is enabled' );
1210
1211     C4::Context->dbh->do("UPDATE issuingrules SET onshelfholds = 1");
1212     t::lib::Mocks::mock_preference( 'AllowRenewalIfOtherItemsAvailable', 1 );
1213     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1214     is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable and onshelfhold are enabled' );
1215
1216     # Setting item not checked out to be not for loan but holdable
1217     ModItem({ notforloan => -1 }, $biblio->biblionumber, $item_2->itemnumber);
1218
1219     ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber1, $item_1->itemnumber );
1220     is( $renewokay, 0, 'Bug 14337 - Verify the borrower can not renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled but the only available item is notforloan' );
1221 };
1222
1223 {
1224     # Don't allow renewing onsite checkout
1225     my $branch   = $library->{branchcode};
1226
1227     #Create another record
1228     my $biblio = $builder->build_sample_biblio();
1229
1230     my $item = $builder->build_sample_item(
1231         {
1232             biblionumber     => $biblio->biblionumber,
1233             library          => $branch,
1234             itype            => $itemtype,
1235         }
1236     );
1237
1238     my $borrowernumber = Koha::Patron->new({
1239         firstname =>  'fn',
1240         surname => 'dn',
1241         categorycode => $patron_category->{categorycode},
1242         branchcode => $branch,
1243     })->store->borrowernumber;
1244
1245     my $borrower = Koha::Patrons->find( $borrowernumber )->unblessed;
1246
1247     my $issue = AddIssue( $borrower, $item->barcode, undef, undef, undef, undef, { onsite_checkout => 1 } );
1248     my ( $renewed, $error ) = CanBookBeRenewed( $borrowernumber, $item->itemnumber );
1249     is( $renewed, 0, 'CanBookBeRenewed should not allow to renew on-site checkout' );
1250     is( $error, 'onsite_checkout', 'A correct error code should be returned by CanBookBeRenewed for on-site checkout' );
1251 }
1252
1253 {
1254     my $library = $builder->build({ source => 'Branch' });
1255
1256     my $biblio = $builder->build_sample_biblio();
1257
1258     my $item = $builder->build_sample_item(
1259         {
1260             biblionumber     => $biblio->biblionumber,
1261             library          => $library->{branchcode},
1262             itype            => $itemtype,
1263         }
1264     );
1265
1266     my $patron = $builder->build({ source => 'Borrower', value => { branchcode => $library->{branchcode}, categorycode => $patron_category->{categorycode} } } );
1267
1268     my $issue = AddIssue( $patron, $item->barcode );
1269     UpdateFine(
1270         {
1271             issue_id       => $issue->id(),
1272             itemnumber     => $item->itemnumber,
1273             borrowernumber => $patron->{borrowernumber},
1274             amount         => 1,
1275             type           => q{}
1276         }
1277     );
1278     UpdateFine(
1279         {
1280             issue_id       => $issue->id(),
1281             itemnumber     => $item->itemnumber,
1282             borrowernumber => $patron->{borrowernumber},
1283             amount         => 2,
1284             type           => q{}
1285         }
1286     );
1287     is( Koha::Account::Lines->search({ issue_id => $issue->id })->count, 1, 'UpdateFine should not create a new accountline when updating an existing fine');
1288 }
1289
1290 subtest 'CanBookBeIssued & AllowReturnToBranch' => sub {
1291     plan tests => 24;
1292
1293     my $homebranch    = $builder->build( { source => 'Branch' } );
1294     my $holdingbranch = $builder->build( { source => 'Branch' } );
1295     my $otherbranch   = $builder->build( { source => 'Branch' } );
1296     my $patron_1      = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1297     my $patron_2      = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1298
1299     my $item = $builder->build_sample_item(
1300         {
1301             homebranch    => $homebranch->{branchcode},
1302             holdingbranch => $holdingbranch->{branchcode},
1303         }
1304     )->unblessed;
1305
1306     set_userenv($holdingbranch);
1307
1308     my $issue = AddIssue( $patron_1->unblessed, $item->{barcode} );
1309     is( ref($issue), 'Koha::Checkout', 'AddIssue should return a Koha::Checkout object' );
1310
1311     my ( $error, $question, $alerts );
1312
1313     # AllowReturnToBranch == anywhere
1314     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1315     ## Test that unknown barcodes don't generate internal server errors
1316     set_userenv($homebranch);
1317     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, 'KohaIsAwesome' );
1318     ok( $error->{UNKNOWN_BARCODE}, '"KohaIsAwesome" is not a valid barcode as expected.' );
1319     ## Can be issued from homebranch
1320     set_userenv($homebranch);
1321     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1322     is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1323     is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1324     ## Can be issued from holdingbranch
1325     set_userenv($holdingbranch);
1326     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1327     is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1328     is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1329     ## Can be issued from another branch
1330     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1331     is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1332     is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1333
1334     # AllowReturnToBranch == holdingbranch
1335     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1336     ## Cannot be issued from homebranch
1337     set_userenv($homebranch);
1338     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1339     is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1340     is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1341     is( $error->{branch_to_return},         $holdingbranch->{branchcode}, 'branch_to_return matched holdingbranch' );
1342     ## Can be issued from holdinbranch
1343     set_userenv($holdingbranch);
1344     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1345     is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1346     is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1347     ## Cannot be issued from another branch
1348     set_userenv($otherbranch);
1349     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1350     is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1351     is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1352     is( $error->{branch_to_return},         $holdingbranch->{branchcode}, 'branch_to_return matches holdingbranch' );
1353
1354     # AllowReturnToBranch == homebranch
1355     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1356     ## Can be issued from holdinbranch
1357     set_userenv($homebranch);
1358     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1359     is( keys(%$error) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1360     is( exists $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER must be set' );
1361     ## Cannot be issued from holdinbranch
1362     set_userenv($holdingbranch);
1363     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1364     is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1365     is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1366     is( $error->{branch_to_return},         $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1367     ## Cannot be issued from holdinbranch
1368     set_userenv($otherbranch);
1369     ( $error, $question, $alerts ) = CanBookBeIssued( $patron_2, $item->{barcode} );
1370     is( keys(%$question) + keys(%$alerts), 0, 'There should not be any errors or alerts (impossible)' . str($error, $question, $alerts) );
1371     is( exists $error->{RETURN_IMPOSSIBLE}, 1, 'RETURN_IMPOSSIBLE must be set' );
1372     is( $error->{branch_to_return},         $homebranch->{branchcode}, 'branch_to_return matches homebranch' );
1373
1374     # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1375 };
1376
1377 subtest 'AddIssue & AllowReturnToBranch' => sub {
1378     plan tests => 9;
1379
1380     my $homebranch    = $builder->build( { source => 'Branch' } );
1381     my $holdingbranch = $builder->build( { source => 'Branch' } );
1382     my $otherbranch   = $builder->build( { source => 'Branch' } );
1383     my $patron_1      = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1384     my $patron_2      = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1385
1386     my $item = $builder->build_sample_item(
1387         {
1388             homebranch    => $homebranch->{branchcode},
1389             holdingbranch => $holdingbranch->{branchcode},
1390         }
1391     )->unblessed;
1392
1393     set_userenv($holdingbranch);
1394
1395     my $ref_issue = 'Koha::Checkout';
1396     my $issue = AddIssue( $patron_1, $item->{barcode} );
1397
1398     my ( $error, $question, $alerts );
1399
1400     # AllowReturnToBranch == homebranch
1401     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'anywhere' );
1402     ## Can be issued from homebranch
1403     set_userenv($homebranch);
1404     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from homebranch');
1405     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1406     ## Can be issued from holdinbranch
1407     set_userenv($holdingbranch);
1408     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from holdingbranch');
1409     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1410     ## Can be issued from another branch
1411     set_userenv($otherbranch);
1412     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - anywhere | Can be issued from otherbranch');
1413     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1414
1415     # AllowReturnToBranch == holdinbranch
1416     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'holdingbranch' );
1417     ## Cannot be issued from homebranch
1418     set_userenv($homebranch);
1419     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from homebranch');
1420     ## Can be issued from holdingbranch
1421     set_userenv($holdingbranch);
1422     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - holdingbranch | Can be issued from holdingbranch');
1423     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1424     ## Cannot be issued from another branch
1425     set_userenv($otherbranch);
1426     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - holdingbranch | Cannot be issued from otherbranch');
1427
1428     # AllowReturnToBranch == homebranch
1429     t::lib::Mocks::mock_preference( 'AllowReturnToBranch', 'homebranch' );
1430     ## Can be issued from homebranch
1431     set_userenv($homebranch);
1432     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), $ref_issue, 'AllowReturnToBranch - homebranch | Can be issued from homebranch' );
1433     set_userenv($holdingbranch); AddIssue( $patron_1, $item->{barcode} ); # Reinsert the original issue
1434     ## Cannot be issued from holdinbranch
1435     set_userenv($holdingbranch);
1436     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from holdingbranch' );
1437     ## Cannot be issued from another branch
1438     set_userenv($otherbranch);
1439     is ( ref( AddIssue( $patron_2, $item->{barcode} ) ), '', 'AllowReturnToBranch - homebranch | Cannot be issued from otherbranch' );
1440     # TODO t::lib::Mocks::mock_preference('AllowReturnToBranch', 'homeorholdingbranch');
1441 };
1442
1443 subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub {
1444     plan tests => 8;
1445
1446     my $library = $builder->build( { source => 'Branch' } );
1447     my $patron  = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1448     my $item_1 = $builder->build_sample_item(
1449         {
1450             library => $library->{branchcode},
1451         }
1452     )->unblessed;
1453     my $item_2 = $builder->build_sample_item(
1454         {
1455             library => $library->{branchcode},
1456         }
1457     )->unblessed;
1458
1459     my ( $error, $question, $alerts );
1460
1461     # Patron cannot issue item_1, they have overdues
1462     my $yesterday = DateTime->today( time_zone => C4::Context->tz() )->add( days => -1 );
1463     my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, $yesterday );    # Add an overdue
1464
1465     t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'confirmation' );
1466     ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1467     is( keys(%$error) + keys(%$alerts),  0, 'No key for error and alert' . str($error, $question, $alerts) );
1468     is( $question->{USERBLOCKEDOVERDUE}, 1, 'OverduesBlockCirc=confirmation, USERBLOCKEDOVERDUE should be set for question' );
1469
1470     t::lib::Mocks::mock_preference( 'OverduesBlockCirc', 'block' );
1471     ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1472     is( keys(%$question) + keys(%$alerts),  0, 'No key for question and alert ' . str($error, $question, $alerts) );
1473     is( $error->{USERBLOCKEDOVERDUE},      1, 'OverduesBlockCirc=block, USERBLOCKEDOVERDUE should be set for error' );
1474
1475     # Patron cannot issue item_1, they are debarred
1476     my $tomorrow = DateTime->today( time_zone => C4::Context->tz() )->add( days => 1 );
1477     Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber, expiration => $tomorrow } );
1478     ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1479     is( keys(%$question) + keys(%$alerts),  0, 'No key for question and alert ' . str($error, $question, $alerts) );
1480     is( $error->{USERBLOCKEDWITHENDDATE}, output_pref( { dt => $tomorrow, dateformat => 'sql', dateonly => 1 } ), 'USERBLOCKEDWITHENDDATE should be tomorrow' );
1481
1482     Koha::Patron::Debarments::AddDebarment( { borrowernumber => $patron->borrowernumber } );
1483     ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1484     is( keys(%$question) + keys(%$alerts),  0, 'No key for question and alert ' . str($error, $question, $alerts) );
1485     is( $error->{USERBLOCKEDNOENDDATE},    '9999-12-31', 'USERBLOCKEDNOENDDATE should be 9999-12-31 for unlimited debarments' );
1486 };
1487
1488 subtest 'CanBookBeIssued + Statistic patrons "X"' => sub {
1489     plan tests => 1;
1490
1491     my $library = $builder->build_object( { class => 'Koha::Libraries' } );
1492     my $patron_category_x = $builder->build_object(
1493         {
1494             class => 'Koha::Patron::Categories',
1495             value => { category_type => 'X' }
1496         }
1497     );
1498     my $patron = $builder->build_object(
1499         {
1500             class => 'Koha::Patrons',
1501             value => {
1502                 categorycode  => $patron_category_x->categorycode,
1503                 gonenoaddress => undef,
1504                 lost          => undef,
1505                 debarred      => undef,
1506                 borrowernotes => ""
1507             }
1508         }
1509     );
1510     my $item_1 = $builder->build_sample_item(
1511         {
1512             library => $library->{branchcode},
1513         }
1514     )->unblessed;
1515
1516     my ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_1->{barcode} );
1517     is( $error->{STATS}, 1, '"Error" flag "STATS" must be set if CanBookBeIssued is called with a statistic patron (category_type=X)' );
1518
1519     # TODO There are other tests to provide here
1520 };
1521
1522 subtest 'MultipleReserves' => sub {
1523     plan tests => 3;
1524
1525     my $biblio = $builder->build_sample_biblio();
1526
1527     my $branch = $library2->{branchcode};
1528
1529     my $item_1 = $builder->build_sample_item(
1530         {
1531             biblionumber     => $biblio->biblionumber,
1532             library          => $branch,
1533             replacementprice => 12.00,
1534             itype            => $itemtype,
1535         }
1536     );
1537
1538     my $item_2 = $builder->build_sample_item(
1539         {
1540             biblionumber     => $biblio->biblionumber,
1541             library          => $branch,
1542             replacementprice => 12.00,
1543             itype            => $itemtype,
1544         }
1545     );
1546
1547     my $bibitems       = '';
1548     my $priority       = '1';
1549     my $resdate        = undef;
1550     my $expdate        = undef;
1551     my $notes          = '';
1552     my $checkitem      = undef;
1553     my $found          = undef;
1554
1555     my %renewing_borrower_data = (
1556         firstname =>  'John',
1557         surname => 'Renewal',
1558         categorycode => $patron_category->{categorycode},
1559         branchcode => $branch,
1560     );
1561     my $renewing_borrowernumber = Koha::Patron->new(\%renewing_borrower_data)->store->borrowernumber;
1562     my $renewing_borrower = Koha::Patrons->find( $renewing_borrowernumber )->unblessed;
1563     my $issue = AddIssue( $renewing_borrower, $item_1->barcode);
1564     my $datedue = dt_from_string( $issue->date_due() );
1565     is (defined $issue->date_due(), 1, "item 1 checked out");
1566     my $borrowing_borrowernumber = Koha::Checkouts->find({ itemnumber => $item_1->itemnumber })->borrowernumber;
1567
1568     my %reserving_borrower_data1 = (
1569         firstname =>  'Katrin',
1570         surname => 'Reservation',
1571         categorycode => $patron_category->{categorycode},
1572         branchcode => $branch,
1573     );
1574     my $reserving_borrowernumber1 = Koha::Patron->new(\%reserving_borrower_data1)->store->borrowernumber;
1575     AddReserve(
1576         $branch, $reserving_borrowernumber1, $biblio->biblionumber,
1577         $bibitems,  $priority, $resdate, $expdate, $notes,
1578         'a title', $checkitem, $found
1579     );
1580
1581     my %reserving_borrower_data2 = (
1582         firstname =>  'Kirk',
1583         surname => 'Reservation',
1584         categorycode => $patron_category->{categorycode},
1585         branchcode => $branch,
1586     );
1587     my $reserving_borrowernumber2 = Koha::Patron->new(\%reserving_borrower_data2)->store->borrowernumber;
1588     AddReserve(
1589         $branch, $reserving_borrowernumber2, $biblio->biblionumber,
1590         $bibitems,  $priority, $resdate, $expdate, $notes,
1591         'a title', $checkitem, $found
1592     );
1593
1594     {
1595         my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
1596         is($renewokay, 0, 'Bug 17941 - should cover the case where 2 books are both reserved, so failing');
1597     }
1598
1599     my $item_3 = $builder->build_sample_item(
1600         {
1601             biblionumber     => $biblio->biblionumber,
1602             library          => $branch,
1603             replacementprice => 12.00,
1604             itype            => $itemtype,
1605         }
1606     );
1607
1608     {
1609         my ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $item_1->itemnumber, 1);
1610         is($renewokay, 1, 'Bug 17941 - should cover the case where 2 books are reserved, but a third one is available');
1611     }
1612 };
1613
1614 subtest 'CanBookBeIssued + AllowMultipleIssuesOnABiblio' => sub {
1615     plan tests => 5;
1616
1617     my $library = $builder->build( { source => 'Branch' } );
1618     my $patron  = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
1619
1620     my $biblionumber = $builder->build_sample_biblio(
1621         {
1622             branchcode => $library->{branchcode},
1623         }
1624     )->biblionumber;
1625     my $item_1 = $builder->build_sample_item(
1626         {
1627             biblionumber => $biblionumber,
1628             library      => $library->{branchcode},
1629         }
1630     )->unblessed;
1631
1632     my $item_2 = $builder->build_sample_item(
1633         {
1634             biblionumber => $biblionumber,
1635             library      => $library->{branchcode},
1636         }
1637     )->unblessed;
1638
1639     my ( $error, $question, $alerts );
1640     my $issue = AddIssue( $patron->unblessed, $item_1->{barcode}, dt_from_string->add( days => 1 ) );
1641
1642     t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1643     ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1644     is( keys(%$error) + keys(%$alerts),  0, 'No error or alert should be raised' . str($error, $question, $alerts) );
1645     is( $question->{BIBLIO_ALREADY_ISSUED}, 1, 'BIBLIO_ALREADY_ISSUED question flag should be set if AllowMultipleIssuesOnABiblio=0 and issue already exists' . str($error, $question, $alerts) );
1646
1647     t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1648     ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1649     is( keys(%$error) + keys(%$question) + keys(%$alerts),  0, 'No BIBLIO_ALREADY_ISSUED flag should be set if AllowMultipleIssuesOnABiblio=1' . str($error, $question, $alerts) );
1650
1651     # Add a subscription
1652     Koha::Subscription->new({ biblionumber => $biblionumber })->store;
1653
1654     t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 0);
1655     ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1656     is( keys(%$error) + keys(%$question) + keys(%$alerts),  0, 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription' . str($error, $question, $alerts) );
1657
1658     t::lib::Mocks::mock_preference('AllowMultipleIssuesOnABiblio', 1);
1659     ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->{barcode} );
1660     is( keys(%$error) + keys(%$question) + keys(%$alerts),  0, 'No BIBLIO_ALREADY_ISSUED flag should be set if it is a subscription' . str($error, $question, $alerts) );
1661 };
1662
1663 subtest 'AddReturn + CumulativeRestrictionPeriods' => sub {
1664     plan tests => 8;
1665
1666     my $library = $builder->build( { source => 'Branch' } );
1667     my $patron  = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1668
1669     # Add 2 items
1670     my $biblionumber = $builder->build_sample_biblio(
1671         {
1672             branchcode => $library->{branchcode},
1673         }
1674     )->biblionumber;
1675     my $item_1 = $builder->build_sample_item(
1676         {
1677             biblionumber => $biblionumber,
1678             library      => $library->{branchcode},
1679         }
1680     )->unblessed;
1681     my $item_2 = $builder->build_sample_item(
1682         {
1683             biblionumber => $biblionumber,
1684             library      => $library->{branchcode},
1685         }
1686     )->unblessed;
1687
1688     # And the issuing rule
1689     Koha::IssuingRules->search->delete;
1690     my $rule = Koha::IssuingRule->new(
1691         {
1692             categorycode => '*',
1693             itemtype     => '*',
1694             branchcode   => '*',
1695             issuelength  => 1,
1696             firstremind  => 1,        # 1 day of grace
1697             finedays     => 2,        # 2 days of fine per day of overdue
1698             lengthunit   => 'days',
1699         }
1700     );
1701     $rule->store();
1702
1703     # Patron cannot issue item_1, they have overdues
1704     my $five_days_ago = dt_from_string->subtract( days => 5 );
1705     my $ten_days_ago  = dt_from_string->subtract( days => 10 );
1706     AddIssue( $patron, $item_1->{barcode}, $five_days_ago );    # Add an overdue
1707     AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
1708       ;    # Add another overdue
1709
1710     t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '0' );
1711     AddReturn( $item_1->{barcode}, $library->{branchcode}, undef, dt_from_string );
1712     my $debarments = Koha::Patron::Debarments::GetDebarments(
1713         { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1714     is( scalar(@$debarments), 1 );
1715
1716     # FIXME Is it right? I'd have expected 5 * 2 - 1 instead
1717     # Same for the others
1718     my $expected_expiration = output_pref(
1719         {
1720             dt         => dt_from_string->add( days => ( 5 - 1 ) * 2 ),
1721             dateformat => 'sql',
1722             dateonly   => 1
1723         }
1724     );
1725     is( $debarments->[0]->{expiration}, $expected_expiration );
1726
1727     AddReturn( $item_2->{barcode}, $library->{branchcode}, undef, dt_from_string );
1728     $debarments = Koha::Patron::Debarments::GetDebarments(
1729         { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1730     is( scalar(@$debarments), 1 );
1731     $expected_expiration = output_pref(
1732         {
1733             dt         => dt_from_string->add( days => ( 10 - 1 ) * 2 ),
1734             dateformat => 'sql',
1735             dateonly   => 1
1736         }
1737     );
1738     is( $debarments->[0]->{expiration}, $expected_expiration );
1739
1740     Koha::Patron::Debarments::DelUniqueDebarment(
1741         { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1742
1743     t::lib::Mocks::mock_preference( 'CumulativeRestrictionPeriods', '1' );
1744     AddIssue( $patron, $item_1->{barcode}, $five_days_ago );    # Add an overdue
1745     AddIssue( $patron, $item_2->{barcode}, $ten_days_ago )
1746       ;    # Add another overdue
1747     AddReturn( $item_1->{barcode}, $library->{branchcode}, undef, dt_from_string );
1748     $debarments = Koha::Patron::Debarments::GetDebarments(
1749         { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1750     is( scalar(@$debarments), 1 );
1751     $expected_expiration = output_pref(
1752         {
1753             dt         => dt_from_string->add( days => ( 5 - 1 ) * 2 ),
1754             dateformat => 'sql',
1755             dateonly   => 1
1756         }
1757     );
1758     is( $debarments->[0]->{expiration}, $expected_expiration );
1759
1760     AddReturn( $item_2->{barcode}, $library->{branchcode}, undef, dt_from_string );
1761     $debarments = Koha::Patron::Debarments::GetDebarments(
1762         { borrowernumber => $patron->{borrowernumber}, type => 'SUSPENSION' } );
1763     is( scalar(@$debarments), 1 );
1764     $expected_expiration = output_pref(
1765         {
1766             dt => dt_from_string->add( days => ( 5 - 1 ) * 2 + ( 10 - 1 ) * 2 ),
1767             dateformat => 'sql',
1768             dateonly   => 1
1769         }
1770     );
1771     is( $debarments->[0]->{expiration}, $expected_expiration );
1772 };
1773
1774 subtest 'AddReturn + suspension_chargeperiod' => sub {
1775     plan tests => 21;
1776
1777     my $library = $builder->build( { source => 'Branch' } );
1778     my $patron  = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1779
1780     my $biblionumber = $builder->build_sample_biblio(
1781         {
1782             branchcode => $library->{branchcode},
1783         }
1784     )->biblionumber;
1785     my $item_1 = $builder->build_sample_item(
1786         {
1787             biblionumber => $biblionumber,
1788             library      => $library->{branchcode},
1789         }
1790     )->unblessed;
1791
1792     # And the issuing rule
1793     Koha::IssuingRules->search->delete;
1794     my $rule = Koha::IssuingRule->new(
1795         {
1796             categorycode => '*',
1797             itemtype     => '*',
1798             branchcode   => '*',
1799             issuelength  => 1,
1800             firstremind  => 0,        # 0 day of grace
1801             finedays     => 2,        # 2 days of fine per day of overdue
1802             suspension_chargeperiod => 1,
1803             lengthunit   => 'days',
1804         }
1805     );
1806     $rule->store();
1807
1808     my $five_days_ago = dt_from_string->subtract( days => 5 );
1809     # We want to charge 2 days every day, without grace
1810     # With 5 days of overdue: 5 * Z
1811     my $expected_expiration = dt_from_string->add( days => ( 5 * 2 ) / 1 );
1812     test_debarment_on_checkout(
1813         {
1814             item            => $item_1,
1815             library         => $library,
1816             patron          => $patron,
1817             due_date        => $five_days_ago,
1818             expiration_date => $expected_expiration,
1819         }
1820     );
1821
1822     # We want to charge 2 days every 2 days, without grace
1823     # With 5 days of overdue: (5 * 2) / 2
1824     $rule->suspension_chargeperiod(2)->store;
1825     $expected_expiration = dt_from_string->add( days => floor( 5 * 2 ) / 2 );
1826     test_debarment_on_checkout(
1827         {
1828             item            => $item_1,
1829             library         => $library,
1830             patron          => $patron,
1831             due_date        => $five_days_ago,
1832             expiration_date => $expected_expiration,
1833         }
1834     );
1835
1836     # We want to charge 2 days every 3 days, with 1 day of grace
1837     # With 5 days of overdue: ((5-1) / 3 ) * 2
1838     $rule->suspension_chargeperiod(3)->store;
1839     $rule->firstremind(1)->store;
1840     $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 1 ) / 3 ) * 2 ) );
1841     test_debarment_on_checkout(
1842         {
1843             item            => $item_1,
1844             library         => $library,
1845             patron          => $patron,
1846             due_date        => $five_days_ago,
1847             expiration_date => $expected_expiration,
1848         }
1849     );
1850
1851     # Use finesCalendar to know if holiday must be skipped to calculate the due date
1852     # We want to charge 2 days every days, with 0 day of grace (to not burn brains)
1853     $rule->finedays(2)->store;
1854     $rule->suspension_chargeperiod(1)->store;
1855     $rule->firstremind(0)->store;
1856     t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
1857
1858     # Adding a holiday 2 days ago
1859     my $calendar = C4::Calendar->new(branchcode => $library->{branchcode});
1860     my $two_days_ago = dt_from_string->subtract( days => 2 );
1861     $calendar->insert_single_holiday(
1862         day             => $two_days_ago->day,
1863         month           => $two_days_ago->month,
1864         year            => $two_days_ago->year,
1865         title           => 'holidayTest-2d',
1866         description     => 'holidayDesc 2 days ago'
1867     );
1868     # With 5 days of overdue, only 4 (x finedays=2) days must charged (one was an holiday)
1869     $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) );
1870     test_debarment_on_checkout(
1871         {
1872             item            => $item_1,
1873             library         => $library,
1874             patron          => $patron,
1875             due_date        => $five_days_ago,
1876             expiration_date => $expected_expiration,
1877         }
1878     );
1879
1880     # Adding a holiday 2 days ahead, with finesCalendar=noFinesWhenClosed it should be skipped
1881     my $two_days_ahead = dt_from_string->add( days => 2 );
1882     $calendar->insert_single_holiday(
1883         day             => $two_days_ahead->day,
1884         month           => $two_days_ahead->month,
1885         year            => $two_days_ahead->year,
1886         title           => 'holidayTest+2d',
1887         description     => 'holidayDesc 2 days ahead'
1888     );
1889
1890     # Same as above, but we should skip D+2
1891     $expected_expiration = dt_from_string->add( days => floor( ( ( 5 - 0 - 1 ) / 1 ) * 2 ) + 1 );
1892     test_debarment_on_checkout(
1893         {
1894             item            => $item_1,
1895             library         => $library,
1896             patron          => $patron,
1897             due_date        => $five_days_ago,
1898             expiration_date => $expected_expiration,
1899         }
1900     );
1901
1902     # Adding another holiday, day of expiration date
1903     my $expected_expiration_dt = dt_from_string($expected_expiration);
1904     $calendar->insert_single_holiday(
1905         day             => $expected_expiration_dt->day,
1906         month           => $expected_expiration_dt->month,
1907         year            => $expected_expiration_dt->year,
1908         title           => 'holidayTest_exp',
1909         description     => 'holidayDesc on expiration date'
1910     );
1911     # Expiration date will be the day after
1912     test_debarment_on_checkout(
1913         {
1914             item            => $item_1,
1915             library         => $library,
1916             patron          => $patron,
1917             due_date        => $five_days_ago,
1918             expiration_date => $expected_expiration_dt->clone->add( days => 1 ),
1919         }
1920     );
1921
1922     test_debarment_on_checkout(
1923         {
1924             item            => $item_1,
1925             library         => $library,
1926             patron          => $patron,
1927             return_date     => dt_from_string->add(days => 5),
1928             expiration_date => dt_from_string->add(days => 5 + (5 * 2 - 1) ),
1929         }
1930     );
1931 };
1932
1933 subtest 'CanBookBeIssued + AutoReturnCheckedOutItems' => sub {
1934     plan tests => 2;
1935
1936     my $library = $builder->build( { source => 'Branch' } );
1937     my $patron1 = $builder->build_object(
1938         {
1939             class => 'Koha::Patrons',
1940             value  => {
1941                 branchcode => $library->{branchcode},
1942                 firstname => "Happy",
1943                 surname => "Gilmore",
1944             }
1945         }
1946     );
1947     my $patron2 = $builder->build_object(
1948         {
1949             class => 'Koha::Patrons',
1950             value  => {
1951                 branchcode => $library->{branchcode},
1952                 firstname => "Billy",
1953                 surname => "Madison",
1954             }
1955         }
1956     );
1957
1958     C4::Context->_new_userenv('xxx');
1959     C4::Context->set_userenv(0,0,0,'firstname','surname', $library->{branchcode}, 'Random Library', '', '', '');
1960
1961     my $item = $builder->build_sample_item(
1962         {
1963             library      => $library->{branchcode},
1964         }
1965     )->unblessed;
1966
1967     my ( $error, $question, $alerts );
1968     my $issue = AddIssue( $patron1->unblessed, $item->{barcode} );
1969
1970     t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
1971     ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->{barcode} );
1972     is( $question->{ISSUED_TO_ANOTHER}, 1, 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' );
1973
1974     t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 1);
1975     ( $error, $question, $alerts ) = CanBookBeIssued( $patron2, $item->{barcode} );
1976     is( $alerts->{RETURNED_FROM_ANOTHER}->{patron}->borrowernumber, $patron1->borrowernumber, 'RETURNED_FROM_ANOTHER alert flag should be set if AutoReturnCheckedOutItems is enabled and item is checked out to another' );
1977
1978     t::lib::Mocks::mock_preference('AutoReturnCheckedOutItems', 0);
1979 };
1980
1981
1982 subtest 'AddReturn | is_overdue' => sub {
1983     plan tests => 5;
1984
1985     t::lib::Mocks::mock_preference('CalculateFinesOnReturn', 1);
1986     t::lib::Mocks::mock_preference('finesMode', 'production');
1987     t::lib::Mocks::mock_preference('MaxFine', '100');
1988
1989     my $library = $builder->build( { source => 'Branch' } );
1990     my $patron  = $builder->build( { source => 'Borrower', value => { categorycode => $patron_category->{categorycode} } } );
1991     my $manager = $builder->build_object({ class => "Koha::Patrons" });
1992     t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
1993
1994     my $item = $builder->build_sample_item(
1995         {
1996             library      => $library->{branchcode},
1997             replacementprice => 7
1998         }
1999     )->unblessed;
2000
2001     Koha::IssuingRules->search->delete;
2002     my $rule = Koha::IssuingRule->new(
2003         {
2004             categorycode => '*',
2005             itemtype     => '*',
2006             branchcode   => '*',
2007             issuelength  => 6,
2008             lengthunit   => 'days',
2009             fine         => 1, # Charge 1 every day of overdue
2010             chargeperiod => 1,
2011         }
2012     );
2013     $rule->store();
2014
2015     my $now   = dt_from_string;
2016     my $one_day_ago   = dt_from_string->subtract( days => 1 );
2017     my $five_days_ago = dt_from_string->subtract( days => 5 );
2018     my $ten_days_ago  = dt_from_string->subtract( days => 10 );
2019     $patron = Koha::Patrons->find( $patron->{borrowernumber} );
2020
2021     # No return date specified, today will be used => 10 days overdue charged
2022     AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2023     AddReturn( $item->{barcode}, $library->{branchcode} );
2024     is( int($patron->account->balance()), 10, 'Patron should have a charge of 10 (10 days x 1)' );
2025     Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2026
2027     # specify return date 5 days before => no overdue charged
2028     AddIssue( $patron->unblessed, $item->{barcode}, $five_days_ago ); # date due was 5d ago
2029     AddReturn( $item->{barcode}, $library->{branchcode}, undef, $ten_days_ago );
2030     is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2031     Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2032
2033     # specify return date 5 days later => 5 days overdue charged
2034     AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2035     AddReturn( $item->{barcode}, $library->{branchcode}, undef, $five_days_ago );
2036     is( int($patron->account->balance()), 5, 'AddReturn: pass return_date => overdue' );
2037     Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2038
2039     # specify return date 5 days later, specify exemptfine => no overdue charge
2040     AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago ); # date due was 10d ago
2041     AddReturn( $item->{barcode}, $library->{branchcode}, 1, $five_days_ago );
2042     is( int($patron->account->balance()), 0, 'AddReturn: pass return_date => no overdue' );
2043     Koha::Account::Lines->search({ borrowernumber => $patron->borrowernumber })->delete;
2044
2045     subtest 'bug 22877' => sub {
2046
2047         plan tests => 3;
2048
2049         my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $ten_days_ago );    # date due was 10d ago
2050
2051         # Fake fines cronjob on this checkout
2052         my ($fine) =
2053           CalcFine( $item, $patron->categorycode, $library->{branchcode},
2054             $ten_days_ago, $now );
2055         UpdateFine(
2056             {
2057                 issue_id       => $issue->issue_id,
2058                 itemnumber     => $item->{itemnumber},
2059                 borrowernumber => $patron->borrowernumber,
2060                 amount         => $fine,
2061                 due            => output_pref($ten_days_ago)
2062             }
2063         );
2064         is( int( $patron->account->balance() ),
2065             10, "Overdue fine of 10 days overdue" );
2066
2067         # Fake longoverdue with charge and not marking returned
2068         LostItem( $item->{itemnumber}, 'cronjob', 0 );
2069         is( int( $patron->account->balance() ),
2070             17, "Lost fine of 7 plus 10 days overdue" );
2071
2072         # Now we return it today
2073         AddReturn( $item->{barcode}, $library->{branchcode} );
2074         is( int( $patron->account->balance() ),
2075             17, "Should have a single 10 days overdue fine and lost charge" );
2076       }
2077 };
2078
2079 subtest '_FixAccountForLostAndReturned' => sub {
2080
2081     plan tests => 5;
2082
2083     t::lib::Mocks::mock_preference( 'WhenLostChargeReplacementFee', 1 );
2084     t::lib::Mocks::mock_preference( 'WhenLostForgiveFine',          0 );
2085
2086     my $processfee_amount  = 20;
2087     my $replacement_amount = 99.00;
2088     my $item_type          = $builder->build_object(
2089         {   class => 'Koha::ItemTypes',
2090             value => {
2091                 notforloan         => undef,
2092                 rentalcharge       => 0,
2093                 defaultreplacecost => undef,
2094                 processfee         => $processfee_amount,
2095                 rentalcharge_daily => 0,
2096             }
2097         }
2098     );
2099     my $library = $builder->build_object( { class => 'Koha::Libraries' } );
2100
2101     my $biblio = $builder->build_sample_biblio({ author => 'Hall, Daria' });
2102
2103     subtest 'Full write-off tests' => sub {
2104
2105         plan tests => 12;
2106
2107         my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2108         my $manager = $builder->build_object({ class => "Koha::Patrons" });
2109         t::lib::Mocks::mock_userenv({ patron => $manager,branchcode => $manager->branchcode });
2110
2111         my $item = $builder->build_sample_item(
2112             {
2113                 biblionumber     => $biblio->biblionumber,
2114                 library          => $library->branchcode,
2115                 replacementprice => $replacement_amount,
2116                 itype            => $item_type->itemtype,
2117             }
2118         );
2119
2120         AddIssue( $patron->unblessed, $item->barcode );
2121
2122         # Simulate item marked as lost
2123         ModItem( { itemlost => 3 }, $biblio->biblionumber, $item->itemnumber );
2124         LostItem( $item->itemnumber, 1 );
2125
2126         my $processing_fee_lines = Koha::Account::Lines->search(
2127             { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'PF' } );
2128         is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2129         my $processing_fee_line = $processing_fee_lines->next;
2130         is( $processing_fee_line->amount + 0,
2131             $processfee_amount, 'The right PF amount is generated' );
2132         is( $processing_fee_line->amountoutstanding + 0,
2133             $processfee_amount, 'The right PF amountoutstanding is generated' );
2134
2135         my $lost_fee_lines = Koha::Account::Lines->search(
2136             { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'LOST' } );
2137         is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2138         my $lost_fee_line = $lost_fee_lines->next;
2139         is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2140         is( $lost_fee_line->amountoutstanding + 0,
2141             $replacement_amount, 'The right LOST amountoutstanding is generated' );
2142         is( $lost_fee_line->status,
2143             undef, 'The LOST status was not set' );
2144
2145         my $account = $patron->account;
2146         my $debts   = $account->outstanding_debits;
2147
2148         # Write off the debt
2149         my $credit = $account->add_credit(
2150             {   amount => $account->balance,
2151                 type   => 'writeoff',
2152                 interface => 'test',
2153             }
2154         );
2155         $credit->apply( { debits => [ $debts->as_list ], offset_type => 'Writeoff' } );
2156
2157         my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item->itemnumber, $patron->id );
2158         is( $credit_return_id, undef, 'No LOST_RETURN account line added' );
2159
2160         $lost_fee_line->discard_changes; # reload from DB
2161         is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2162         is( $lost_fee_line->accounttype,
2163             'LOST', 'Lost fee now still has account type of LOST' );
2164         is( $lost_fee_line->status, 'RETURNED', "Lost fee now has account status of RETURNED");
2165
2166         is( $patron->account->balance, -0, 'The patron balance is 0, everything was written off' );
2167     };
2168
2169     subtest 'Full payment tests' => sub {
2170
2171         plan tests => 13;
2172
2173         my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2174
2175         my $item = $builder->build_sample_item(
2176             {
2177                 biblionumber     => $biblio->biblionumber,
2178                 library          => $library->branchcode,
2179                 replacementprice => $replacement_amount,
2180                 itype            => $item_type->itemtype
2181             }
2182         );
2183
2184         AddIssue( $patron->unblessed, $item->barcode );
2185
2186         # Simulate item marked as lost
2187         ModItem( { itemlost => 1 }, $biblio->biblionumber, $item->itemnumber );
2188         LostItem( $item->itemnumber, 1 );
2189
2190         my $processing_fee_lines = Koha::Account::Lines->search(
2191             { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'PF' } );
2192         is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2193         my $processing_fee_line = $processing_fee_lines->next;
2194         is( $processing_fee_line->amount + 0,
2195             $processfee_amount, 'The right PF amount is generated' );
2196         is( $processing_fee_line->amountoutstanding + 0,
2197             $processfee_amount, 'The right PF amountoutstanding is generated' );
2198
2199         my $lost_fee_lines = Koha::Account::Lines->search(
2200             { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'LOST' } );
2201         is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2202         my $lost_fee_line = $lost_fee_lines->next;
2203         is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2204         is( $lost_fee_line->amountoutstanding + 0,
2205             $replacement_amount, 'The right LOST amountountstanding is generated' );
2206
2207         my $account = $patron->account;
2208         my $debts   = $account->outstanding_debits;
2209
2210         # Write off the debt
2211         my $credit = $account->add_credit(
2212             {   amount => $account->balance,
2213                 type   => 'payment',
2214                 interface => 'test',
2215             }
2216         );
2217         $credit->apply( { debits => [ $debts->as_list ], offset_type => 'Payment' } );
2218
2219         my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item->itemnumber, $patron->id );
2220         my $credit_return = Koha::Account::Lines->find($credit_return_id);
2221
2222         is( $credit_return->accounttype, 'LOST_RETURN', 'An account line of type LOST_RETURN is added' );
2223         is( $credit_return->amount + 0,
2224             -99.00, 'The account line of type LOST_RETURN has an amount of -99' );
2225         is( $credit_return->amountoutstanding + 0,
2226             -99.00, 'The account line of type LOST_RETURN has an amountoutstanding of -99' );
2227
2228         $lost_fee_line->discard_changes;
2229         is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2230         is( $lost_fee_line->accounttype,
2231             'LOST', 'Lost fee now still has account type of LOST' );
2232         is( $lost_fee_line->status, 'RETURNED', "Lost fee now has account status of RETURNED");
2233
2234         is( $patron->account->balance,
2235             -99, 'The patron balance is -99, a credit that equals the lost fee payment' );
2236     };
2237
2238     subtest 'Test without payment or write off' => sub {
2239
2240         plan tests => 13;
2241
2242         my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2243
2244         my $item = $builder->build_sample_item(
2245             {
2246                 biblionumber     => $biblio->biblionumber,
2247                 library          => $library->branchcode,
2248                 replacementprice => 23.00,
2249                 replacementprice => $replacement_amount,
2250                 itype            => $item_type->itemtype
2251             }
2252         );
2253
2254         AddIssue( $patron->unblessed, $item->barcode );
2255
2256         # Simulate item marked as lost
2257         ModItem( { itemlost => 3 }, $biblio->biblionumber, $item->itemnumber );
2258         LostItem( $item->itemnumber, 1 );
2259
2260         my $processing_fee_lines = Koha::Account::Lines->search(
2261             { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'PF' } );
2262         is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2263         my $processing_fee_line = $processing_fee_lines->next;
2264         is( $processing_fee_line->amount + 0,
2265             $processfee_amount, 'The right PF amount is generated' );
2266         is( $processing_fee_line->amountoutstanding + 0,
2267             $processfee_amount, 'The right PF amountoutstanding is generated' );
2268
2269         my $lost_fee_lines = Koha::Account::Lines->search(
2270             { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'LOST' } );
2271         is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2272         my $lost_fee_line = $lost_fee_lines->next;
2273         is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2274         is( $lost_fee_line->amountoutstanding + 0,
2275             $replacement_amount, 'The right LOST amountountstanding is generated' );
2276
2277         my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item->itemnumber, $patron->id );
2278         my $credit_return = Koha::Account::Lines->find($credit_return_id);
2279
2280         is( $credit_return->accounttype, 'LOST_RETURN', 'An account line of type LOST_RETURN is added' );
2281         is( $credit_return->amount + 0, -99.00, 'The account line of type LOST_RETURN has an amount of -99' );
2282         is( $credit_return->amountoutstanding + 0, 0, 'The account line of type LOST_RETURN has an amountoutstanding of 0' );
2283
2284         $lost_fee_line->discard_changes;
2285         is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2286         is( $lost_fee_line->accounttype,
2287             'LOST', 'Lost fee now still has account type of LOST' );
2288         is( $lost_fee_line->status, 'RETURNED', "Lost fee now has account status of RETURNED");
2289
2290         is( $patron->account->balance, 20, 'The patron balance is 20, still owes the processing fee' );
2291     };
2292
2293     subtest 'Test with partial payement and write off, and remaining debt' => sub {
2294
2295         plan tests => 16;
2296
2297         my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2298         my $item = $builder->build_sample_item(
2299             {
2300                 biblionumber     => $biblio->biblionumber,
2301                 library          => $library->branchcode,
2302                 replacementprice => $replacement_amount,
2303                 itype            => $item_type->itemtype
2304             }
2305         );
2306
2307         AddIssue( $patron->unblessed, $item->barcode );
2308
2309         # Simulate item marked as lost
2310         ModItem( { itemlost => 1 }, $biblio->biblionumber, $item->itemnumber );
2311         LostItem( $item->itemnumber, 1 );
2312
2313         my $processing_fee_lines = Koha::Account::Lines->search(
2314             { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'PF' } );
2315         is( $processing_fee_lines->count, 1, 'Only one processing fee produced' );
2316         my $processing_fee_line = $processing_fee_lines->next;
2317         is( $processing_fee_line->amount + 0,
2318             $processfee_amount, 'The right PF amount is generated' );
2319         is( $processing_fee_line->amountoutstanding + 0,
2320             $processfee_amount, 'The right PF amountoutstanding is generated' );
2321
2322         my $lost_fee_lines = Koha::Account::Lines->search(
2323             { borrowernumber => $patron->id, itemnumber => $item->itemnumber, accounttype => 'LOST' } );
2324         is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2325         my $lost_fee_line = $lost_fee_lines->next;
2326         is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2327         is( $lost_fee_line->amountoutstanding + 0,
2328             $replacement_amount, 'The right LOST amountountstanding is generated' );
2329
2330         my $account = $patron->account;
2331         is( $account->balance, $processfee_amount + $replacement_amount, 'Balance is PF + L' );
2332
2333         # Partially pay fee
2334         my $payment_amount = 27;
2335         my $payment        = $account->add_credit(
2336             {   amount => $payment_amount,
2337                 type   => 'payment',
2338                 interface => 'test',
2339             }
2340         );
2341
2342         $payment->apply( { debits => [ $lost_fee_line ], offset_type => 'Payment' } );
2343
2344         # Partially write off fee
2345         my $write_off_amount = 25;
2346         my $write_off        = $account->add_credit(
2347             {   amount => $write_off_amount,
2348                 type   => 'writeoff',
2349                 interface => 'test',
2350             }
2351         );
2352         $write_off->apply( { debits => [ $lost_fee_line ], offset_type => 'Writeoff' } );
2353
2354         is( $account->balance,
2355             $processfee_amount + $replacement_amount - $payment_amount - $write_off_amount,
2356             'Payment and write off applied'
2357         );
2358
2359         # Store the amountoutstanding value
2360         $lost_fee_line->discard_changes;
2361         my $outstanding = $lost_fee_line->amountoutstanding;
2362
2363         my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item->itemnumber, $patron->id );
2364         my $credit_return = Koha::Account::Lines->find($credit_return_id);
2365
2366         is( $account->balance, $processfee_amount - $payment_amount, 'Balance is PF - payment (LOST_RETURN)' );
2367
2368         $lost_fee_line->discard_changes;
2369         is( $lost_fee_line->amountoutstanding + 0, 0, 'Lost fee has no outstanding amount' );
2370         is( $lost_fee_line->accounttype,
2371             'LOST', 'Lost fee now still has account type of LOST' );
2372         is( $lost_fee_line->status, 'RETURNED', "Lost fee now has account status of RETURNED");
2373
2374         is( $credit_return->accounttype, 'LOST_RETURN', 'An account line of type LOST_RETURN is added' );
2375         is( $credit_return->amount + 0,
2376             ($payment_amount + $outstanding ) * -1,
2377             'The account line of type LOST_RETURN has an amount equal to the payment + outstanding'
2378         );
2379         is( $credit_return->amountoutstanding + 0,
2380             $payment_amount * -1,
2381             'The account line of type LOST_RETURN has an amountoutstanding equal to the payment'
2382         );
2383
2384         is( $account->balance,
2385             $processfee_amount - $payment_amount,
2386             'The patron balance is the difference between the PF and the credit'
2387         );
2388     };
2389
2390     subtest 'Partial payement, existing debits and AccountAutoReconcile' => sub {
2391
2392         plan tests => 8;
2393
2394         my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2395         my $barcode = 'KD123456793';
2396         my $replacement_amount = 100;
2397         my $processfee_amount  = 20;
2398
2399         my $item_type          = $builder->build_object(
2400             {   class => 'Koha::ItemTypes',
2401                 value => {
2402                     notforloan         => undef,
2403                     rentalcharge       => 0,
2404                     defaultreplacecost => undef,
2405                     processfee         => 0,
2406                     rentalcharge_daily => 0,
2407                 }
2408             }
2409         );
2410         my ( undef, undef, $item_id ) = AddItem(
2411             {   homebranch       => $library->branchcode,
2412                 holdingbranch    => $library->branchcode,
2413                 barcode          => $barcode,
2414                 replacementprice => $replacement_amount,
2415                 itype            => $item_type->itemtype
2416             },
2417             $biblio->biblionumber
2418         );
2419
2420         AddIssue( $patron->unblessed, $barcode );
2421
2422         # Simulate item marked as lost
2423         ModItem( { itemlost => 1 }, $biblio->biblionumber, $item_id );
2424         LostItem( $item_id, 1 );
2425
2426         my $lost_fee_lines = Koha::Account::Lines->search(
2427             { borrowernumber => $patron->id, itemnumber => $item_id, accounttype => 'LOST' } );
2428         is( $lost_fee_lines->count, 1, 'Only one lost item fee produced' );
2429         my $lost_fee_line = $lost_fee_lines->next;
2430         is( $lost_fee_line->amount + 0, $replacement_amount, 'The right LOST amount is generated' );
2431         is( $lost_fee_line->amountoutstanding + 0,
2432             $replacement_amount, 'The right LOST amountountstanding is generated' );
2433
2434         my $account = $patron->account;
2435         is( $account->balance, $replacement_amount, 'Balance is L' );
2436
2437         # Partially pay fee
2438         my $payment_amount = 27;
2439         my $payment        = $account->add_credit(
2440             {   amount => $payment_amount,
2441                 type   => 'payment',
2442                 interface => 'test',
2443             }
2444         );
2445         $payment->apply({ debits => [ $lost_fee_line ], offset_type => 'Payment' });
2446
2447         is( $account->balance,
2448             $replacement_amount - $payment_amount,
2449             'Payment applied'
2450         );
2451
2452         my $manual_debit_amount = 80;
2453         $account->add_debit( { amount => $manual_debit_amount, type => 'overdue', interface =>'test' } );
2454
2455         is( $account->balance, $manual_debit_amount + $replacement_amount - $payment_amount, 'Manual debit applied' );
2456
2457         t::lib::Mocks::mock_preference( 'AccountAutoReconcile', 1 );
2458
2459         my $credit_return_id = C4::Circulation::_FixAccountForLostAndReturned( $item_id, $patron->id );
2460         my $credit_return = Koha::Account::Lines->find($credit_return_id);
2461
2462         is( $account->balance, $manual_debit_amount - $payment_amount, 'Balance is PF - payment (LOST_RETURN)' );
2463
2464         my $manual_debit = Koha::Account::Lines->search({ borrowernumber => $patron->id, accounttype => 'OVERDUE', status => 'UNRETURNED' })->next;
2465         is( $manual_debit->amountoutstanding + 0, $manual_debit_amount - $payment_amount, 'reconcile_balance was called' );
2466     };
2467 };
2468
2469 subtest '_FixOverduesOnReturn' => sub {
2470     plan tests => 11;
2471
2472     my $manager = $builder->build_object({ class => "Koha::Patrons" });
2473     t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2474
2475     my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
2476
2477     my $branchcode  = $library2->{branchcode};
2478
2479     my $item = $builder->build_sample_item(
2480         {
2481             biblionumber     => $biblio->biblionumber,
2482             library          => $branchcode,
2483             replacementprice => 99.00,
2484             itype            => $itemtype,
2485         }
2486     );
2487
2488     my $patron = $builder->build( { source => 'Borrower' } );
2489
2490     ## Start with basic call, should just close out the open fine
2491     my $accountline = Koha::Account::Line->new(
2492         {
2493             borrowernumber => $patron->{borrowernumber},
2494             accounttype    => 'OVERDUE',
2495             status         => 'UNRETURNED',
2496             itemnumber     => $item->itemnumber,
2497             amount => 99.00,
2498             amountoutstanding => 99.00,
2499             interface => 'test',
2500         }
2501     )->store();
2502
2503     C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, undef, 'RETURNED' );
2504
2505     $accountline->_result()->discard_changes();
2506
2507     is( $accountline->amountoutstanding, '99.000000', 'Fine has the same amount outstanding as previously' );
2508     isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
2509     is( $accountline->status, 'RETURNED', 'Passed status has been used to set as RETURNED )');
2510
2511     ## Run again, with exemptfine enabled
2512     $accountline->set(
2513         {
2514             accounttype    => 'OVERDUE',
2515             status         => 'UNRETURNED',
2516             amountoutstanding => 99.00,
2517         }
2518     )->store();
2519
2520     C4::Circulation::_FixOverduesOnReturn( $patron->{borrowernumber}, $item->itemnumber, 1, 'RETURNED' );
2521
2522     $accountline->_result()->discard_changes();
2523     my $offset = Koha::Account::Offsets->search({ debit_id => $accountline->id, type => 'Forgiven' })->next();
2524
2525     is( $accountline->amountoutstanding + 0, 0, 'Fine amountoutstanding has been reduced to 0' );
2526     isnt( $accountline->status, 'UNRETURNED', 'Open fine ( account type OVERDUE ) has been closed out ( status not UNRETURNED )');
2527     is( $accountline->status, 'FORGIVEN', 'Open fine ( account type OVERDUE ) has been set to fine forgiven ( status FORGIVEN )');
2528     is( ref $offset, "Koha::Account::Offset", "Found matching offset for fine reduction via forgiveness" );
2529     is( $offset->amount + 0, -99, "Amount of offset is correct" );
2530     my $credit = $offset->credit;
2531     is( ref $credit, "Koha::Account::Line", "Found matching credit for fine forgiveness" );
2532     is( $credit->amount + 0, -99, "Credit amount is set correctly" );
2533     is( $credit->amountoutstanding + 0, 0, "Credit amountoutstanding is correctly set to 0" );
2534 };
2535
2536 subtest '_FixAccountForLostAndReturned returns undef if patron is deleted' => sub {
2537     plan tests => 1;
2538
2539     my $manager = $builder->build_object({ class => "Koha::Patrons" });
2540     t::lib::Mocks::mock_userenv({ patron => $manager, branchcode => $manager->branchcode });
2541
2542     my $biblio = $builder->build_sample_biblio({ author => 'Hall, Kylie' });
2543
2544     my $branchcode  = $library2->{branchcode};
2545
2546     my $item = $builder->build_sample_item(
2547         {
2548             biblionumber     => $biblio->biblionumber,
2549             library          => $branchcode,
2550             replacementprice => 99.00,
2551             itype            => $itemtype,
2552         }
2553     );
2554
2555     my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
2556
2557     ## Start with basic call, should just close out the open fine
2558     my $accountline = Koha::Account::Line->new(
2559         {
2560             borrowernumber => $patron->id,
2561             accounttype    => 'L',
2562             status         => undef,
2563             itemnumber     => $item->itemnumber,
2564             amount => 99.00,
2565             amountoutstanding => 99.00,
2566             interface => 'test',
2567         }
2568     )->store();
2569
2570     $patron->delete();
2571
2572     my $return_value = C4::Circulation::_FixAccountForLostAndReturned( $patron->id, $item->itemnumber );
2573
2574     is( $return_value, undef, "_FixAccountForLostAndReturned returns undef if patron is deleted" );
2575
2576 };
2577
2578 subtest 'Set waiting flag' => sub {
2579     plan tests => 4;
2580
2581     my $library_1 = $builder->build( { source => 'Branch' } );
2582     my $patron_1  = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2583     my $library_2 = $builder->build( { source => 'Branch' } );
2584     my $patron_2  = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2585
2586     my $item = $builder->build_sample_item(
2587         {
2588             library      => $library_1->{branchcode},
2589         }
2590     )->unblessed;
2591
2592     set_userenv( $library_2 );
2593     my $reserve_id = AddReserve(
2594         $library_2->{branchcode}, $patron_2->{borrowernumber}, $item->{biblionumber},
2595         '', 1, undef, undef, '', undef, $item->{itemnumber},
2596     );
2597
2598     set_userenv( $library_1 );
2599     my $do_transfer = 1;
2600     my ( $res, $rr ) = AddReturn( $item->{barcode}, $library_1->{branchcode} );
2601     ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2602     my $hold = Koha::Holds->find( $reserve_id );
2603     is( $hold->found, 'T', 'Hold is in transit' );
2604
2605     my ( $status ) = CheckReserves($item->{itemnumber});
2606     is( $status, 'Reserved', 'Hold is not waiting yet');
2607
2608     set_userenv( $library_2 );
2609     $do_transfer = 0;
2610     AddReturn( $item->{barcode}, $library_2->{branchcode} );
2611     ModReserveAffect( $item->{itemnumber}, undef, $do_transfer, $reserve_id );
2612     $hold = Koha::Holds->find( $reserve_id );
2613     is( $hold->found, 'W', 'Hold is waiting' );
2614     ( $status ) = CheckReserves($item->{itemnumber});
2615     is( $status, 'Waiting', 'Now the hold is waiting');
2616 };
2617
2618 subtest 'Cancel transfers on lost items' => sub {
2619     plan tests => 5;
2620     my $library_1 = $builder->build( { source => 'Branch' } );
2621     my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2622     my $library_2 = $builder->build( { source => 'Branch' } );
2623     my $patron_2  = $builder->build( { source => 'Borrower', value => { branchcode => $library_2->{branchcode}, categorycode => $patron_category->{categorycode} } } );
2624     my $biblio = $builder->build_sample_biblio({branchcode => $library->{branchcode}});
2625     my $item   = $builder->build_sample_item({
2626         biblionumber  => $biblio->biblionumber,
2627         library    => $library_1->{branchcode},
2628     });
2629
2630     set_userenv( $library_2 );
2631     my $reserve_id = AddReserve(
2632         $library_2->{branchcode}, $patron_2->{borrowernumber}, $item->biblionumber, '', 1, undef, undef, '', undef, $item->itemnumber,
2633     );
2634
2635     #Return book and add transfer
2636     set_userenv( $library_1 );
2637     my $do_transfer = 1;
2638     my ( $res, $rr ) = AddReturn( $item->barcode, $library_1->{branchcode} );
2639     ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id );
2640     C4::Circulation::transferbook( $library_2->{branchcode}, $item->barcode );
2641     my $hold = Koha::Holds->find( $reserve_id );
2642     is( $hold->found, 'T', 'Hold is in transit' );
2643
2644     #Check transfer exists and the items holding branch is the transfer destination branch before marking it as lost
2645     my ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber);
2646     is( $tobranch, $library_2->{branchcode}, 'The transfer record exists in the branchtransfers table');
2647     my $itemcheck = Koha::Items->find($item->itemnumber);
2648     is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Items holding branch is the transfers origin branch before it is marked as lost' );
2649
2650     #Simulate item being marked as lost and confirm the transfer is deleted and the items holding branch is the transfers source branch
2651     ModItem( { itemlost => 1 }, $item->biblionumber, $item->itemnumber );
2652     LostItem( $item->itemnumber, 'test', 1 );
2653     ($datesent,$frombranch,$tobranch) = GetTransfers($item->itemnumber);
2654     is( $tobranch, undef, 'The transfer on the lost item has been deleted as the LostItemCancelOutstandingTransfer is enabled');
2655     $itemcheck = Koha::Items->find($item->itemnumber);
2656     is( $itemcheck->holdingbranch, $library_1->{branchcode}, 'Lost item with cancelled hold has holding branch equallying the transfers source branch' );
2657 };
2658
2659 subtest 'CanBookBeIssued | is_overdue' => sub {
2660     plan tests => 3;
2661
2662     # Set a simple circ policy
2663     $dbh->do('DELETE FROM issuingrules');
2664     $dbh->do(
2665     q{INSERT INTO issuingrules (categorycode, branchcode, itemtype, reservesallowed,
2666                                     issuelength, lengthunit,
2667                                     renewalsallowed, renewalperiod,
2668                                     norenewalbefore, auto_renew,
2669                                     fine, chargeperiod)
2670           VALUES (?, ?, ?, ?,
2671                   ?, ?,
2672                   ?, ?,
2673                   ?, ?,
2674                   ?, ?
2675                  )
2676         },
2677         {},
2678         '*',   '*', '*', 25,
2679         14,  'days',
2680         1,     7,
2681         undef, 0,
2682         .10,   1
2683     );
2684
2685     my $five_days_go = output_pref({ dt => dt_from_string->add( days => 5 ), dateonly => 1});
2686     my $ten_days_go  = output_pref({ dt => dt_from_string->add( days => 10), dateonly => 1 });
2687     my $library = $builder->build( { source => 'Branch' } );
2688     my $patron  = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } );
2689
2690     my $item = $builder->build_sample_item(
2691         {
2692             library      => $library->{branchcode},
2693         }
2694     )->unblessed;
2695
2696     my $issue = AddIssue( $patron->unblessed, $item->{barcode}, $five_days_go ); # date due was 10d ago
2697     my $actualissue = Koha::Checkouts->find( { itemnumber => $item->{itemnumber} } );
2698     is( output_pref({ str => $actualissue->date_due, dateonly => 1}), $five_days_go, "First issue works");
2699     my ($issuingimpossible, $needsconfirmation) = CanBookBeIssued($patron,$item->{barcode},$ten_days_go, undef, undef, undef);
2700     is( $needsconfirmation->{RENEW_ISSUE}, 1, "This is a renewal");
2701     is( $needsconfirmation->{TOO_MANY}, undef, "Not too many, is a renewal");
2702 };
2703
2704 subtest 'ItemsDeniedRenewal preference' => sub {
2705     plan tests => 18;
2706
2707     C4::Context->set_preference('ItemsDeniedRenewal','');
2708
2709     my $idr_lib = $builder->build_object({ class => 'Koha::Libraries'});
2710     $dbh->do(
2711         q{
2712         INSERT INTO issuingrules ( categorycode, branchcode, itemtype, reservesallowed, issuelength, lengthunit, renewalsallowed, renewalperiod,
2713                     norenewalbefore, auto_renew, fine, chargeperiod ) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )
2714         },
2715         {},
2716         '*', $idr_lib->branchcode, '*', 25,
2717         14,  'days',
2718         10,   7,
2719         undef,  0,
2720         .10, 1
2721     );
2722
2723     my $deny_book = $builder->build_object({ class => 'Koha::Items', value => {
2724         homebranch => $idr_lib->branchcode,
2725         withdrawn => 1,
2726         itype => 'HIDE',
2727         location => 'PROC',
2728         itemcallnumber => undef,
2729         itemnotes => "",
2730         }
2731     });
2732     my $allow_book = $builder->build_object({ class => 'Koha::Items', value => {
2733         homebranch => $idr_lib->branchcode,
2734         withdrawn => 0,
2735         itype => 'NOHIDE',
2736         location => 'NOPROC'
2737         }
2738     });
2739
2740     my $idr_borrower = $builder->build_object({ class => 'Koha::Patrons', value=> {
2741         branchcode => $idr_lib->branchcode,
2742         }
2743     });
2744     my $future = dt_from_string->add( days => 1 );
2745     my $deny_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
2746         returndate => undef,
2747         renewals => 0,
2748         auto_renew => 0,
2749         borrowernumber => $idr_borrower->borrowernumber,
2750         itemnumber => $deny_book->itemnumber,
2751         onsite_checkout => 0,
2752         date_due => $future,
2753         }
2754     });
2755     my $allow_issue = $builder->build_object({ class => 'Koha::Checkouts', value => {
2756         returndate => undef,
2757         renewals => 0,
2758         auto_renew => 0,
2759         borrowernumber => $idr_borrower->borrowernumber,
2760         itemnumber => $allow_book->itemnumber,
2761         onsite_checkout => 0,
2762         date_due => $future,
2763         }
2764     });
2765
2766     my $idr_rules;
2767
2768     my ( $idr_mayrenew, $idr_error ) =
2769     CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2770     is( $idr_mayrenew, 1, 'Renewal allowed when no rules' );
2771     is( $idr_error, undef, 'Renewal allowed when no rules' );
2772
2773     $idr_rules="withdrawn: [1]";
2774
2775     C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2776     ( $idr_mayrenew, $idr_error ) =
2777     CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2778     is( $idr_mayrenew, 0, 'Renewal blocked when 1 rules (withdrawn)' );
2779     is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 1 rule (withdrawn)' );
2780     ( $idr_mayrenew, $idr_error ) =
2781     CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2782     is( $idr_mayrenew, 1, 'Renewal allowed when 1 rules not matched (withdrawn)' );
2783     is( $idr_error, undef, 'Renewal allowed when 1 rules not matched (withdrawn)' );
2784
2785     $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]";
2786
2787     C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2788     ( $idr_mayrenew, $idr_error ) =
2789     CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2790     is( $idr_mayrenew, 0, 'Renewal blocked when 2 rules matched (withdrawn, itype)' );
2791     is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 2 rules matched (withdrawn,itype)' );
2792     ( $idr_mayrenew, $idr_error ) =
2793     CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2794     is( $idr_mayrenew, 1, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
2795     is( $idr_error, undef, 'Renewal allowed when 2 rules not matched (withdrawn, itype)' );
2796
2797     $idr_rules="withdrawn: [1]\nitype: [HIDE,INVISIBLE]\nlocation: [PROC]";
2798
2799     C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2800     ( $idr_mayrenew, $idr_error ) =
2801     CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2802     is( $idr_mayrenew, 0, 'Renewal blocked when 3 rules matched (withdrawn, itype, location)' );
2803     is( $idr_error, 'item_denied_renewal', 'Renewal blocked when 3 rules matched (withdrawn,itype, location)' );
2804     ( $idr_mayrenew, $idr_error ) =
2805     CanBookBeRenewed( $idr_borrower->borrowernumber, $allow_issue->itemnumber );
2806     is( $idr_mayrenew, 1, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
2807     is( $idr_error, undef, 'Renewal allowed when 3 rules not matched (withdrawn, itype, location)' );
2808
2809     $idr_rules="itemcallnumber: [NULL]";
2810     C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2811     ( $idr_mayrenew, $idr_error ) =
2812     CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2813     is( $idr_mayrenew, 0, 'Renewal blocked for undef when NULL in pref' );
2814     $idr_rules="itemcallnumber: ['']";
2815     C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2816     ( $idr_mayrenew, $idr_error ) =
2817     CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2818     is( $idr_mayrenew, 1, 'Renewal not blocked for undef when "" in pref' );
2819
2820     $idr_rules="itemnotes: [NULL]";
2821     C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2822     ( $idr_mayrenew, $idr_error ) =
2823     CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2824     is( $idr_mayrenew, 1, 'Renewal not blocked for "" when NULL in pref' );
2825     $idr_rules="itemnotes: ['']";
2826     C4::Context->set_preference('ItemsDeniedRenewal',$idr_rules);
2827     ( $idr_mayrenew, $idr_error ) =
2828     CanBookBeRenewed( $idr_borrower->borrowernumber, $deny_issue->itemnumber );
2829     is( $idr_mayrenew, 0, 'Renewal blocked for empty string when "" in pref' );
2830 };
2831
2832 subtest 'CanBookBeIssued | item-level_itypes=biblio' => sub {
2833     plan tests => 2;
2834
2835     t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
2836     my $library = $builder->build( { source => 'Branch' } );
2837     my $patron  = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
2838
2839     my $item = $builder->build_sample_item(
2840         {
2841             library      => $library->{branchcode},
2842         }
2843     );
2844
2845     my ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2846     is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2847     is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2848 };
2849
2850 subtest 'CanBookBeIssued | notforloan' => sub {
2851     plan tests => 2;
2852
2853     t::lib::Mocks::mock_preference('AllowNotForLoanOverride', 0);
2854
2855     my $library = $builder->build( { source => 'Branch' } );
2856     my $patron  = $builder->build_object( { class => 'Koha::Patrons', value => { categorycode => $patron_category->{categorycode} } } )->store;
2857
2858     my $itemtype = $builder->build(
2859         {
2860             source => 'Itemtype',
2861             value  => { notforloan => undef, }
2862         }
2863     );
2864     my $item = $builder->build_sample_item(
2865         {
2866             library  => $library->{branchcode},
2867             itype    => $itemtype->{itemtype},
2868         }
2869     );
2870     $item->biblioitem->itemtype($itemtype->{itemtype})->store;
2871
2872     my ( $issuingimpossible, $needsconfirmation );
2873
2874
2875     subtest 'item-level_itypes = 1' => sub {
2876         plan tests => 6;
2877
2878         t::lib::Mocks::mock_preference('item-level_itypes', 1); # item
2879         # Is for loan at item type and item level
2880         ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2881         is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2882         is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2883
2884         # not for loan at item type level
2885         Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
2886         ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2887         is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2888         is_deeply(
2889             $issuingimpossible,
2890             { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
2891             'Item can not be issued, not for loan at item type level'
2892         );
2893
2894         # not for loan at item level
2895         Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
2896         $item->notforloan( 1 )->store;
2897         ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2898         is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2899         is_deeply(
2900             $issuingimpossible,
2901             { NOT_FOR_LOAN => 1, item_notforloan => 1 },
2902             'Item can not be issued, not for loan at item type level'
2903         );
2904     };
2905
2906     subtest 'item-level_itypes = 0' => sub {
2907         plan tests => 6;
2908
2909         t::lib::Mocks::mock_preference('item-level_itypes', 0); # biblio
2910
2911         # We set another itemtype for biblioitem
2912         my $itemtype = $builder->build(
2913             {
2914                 source => 'Itemtype',
2915                 value  => { notforloan => undef, }
2916             }
2917         );
2918
2919         # for loan at item type and item level
2920         $item->notforloan(0)->store;
2921         $item->biblioitem->itemtype($itemtype->{itemtype})->store;
2922         ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2923         is_deeply( $needsconfirmation, {}, 'Item can be issued to this patron' );
2924         is_deeply( $issuingimpossible, {}, 'Item can be issued to this patron' );
2925
2926         # not for loan at item type level
2927         Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(1)->store;
2928         ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2929         is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2930         is_deeply(
2931             $issuingimpossible,
2932             { NOT_FOR_LOAN => 1, itemtype_notforloan => $itemtype->{itemtype} },
2933             'Item can not be issued, not for loan at item type level'
2934         );
2935
2936         # not for loan at item level
2937         Koha::ItemTypes->find( $itemtype->{itemtype} )->notforloan(undef)->store;
2938         $item->notforloan( 1 )->store;
2939         ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, undef, undef, undef, undef );
2940         is_deeply( $needsconfirmation, {}, 'No confirmation needed, AllowNotForLoanOverride=0' );
2941         is_deeply(
2942             $issuingimpossible,
2943             { NOT_FOR_LOAN => 1, item_notforloan => 1 },
2944             'Item can not be issued, not for loan at item type level'
2945         );
2946     };
2947
2948     # TODO test with AllowNotForLoanOverride = 1
2949 };
2950
2951 subtest 'AddReturn should clear items.onloan for unissued items' => sub {
2952     plan tests => 1;
2953
2954     t::lib::Mocks::mock_preference( "AllowReturnToBranch", 'anywhere' );
2955     my $item = $builder->build_sample_item(
2956         {
2957             onloan => '2018-01-01',
2958         }
2959     );
2960
2961     AddReturn( $item->barcode, $item->homebranch );
2962     $item->discard_changes; # refresh
2963     is( $item->onloan, undef, 'AddReturn did clear items.onloan' );
2964 };
2965
2966
2967 subtest 'AddRenewal and AddIssuingCharge tests' => sub {
2968
2969     plan tests => 10;
2970
2971
2972     t::lib::Mocks::mock_preference('item-level_itypes', 1);
2973
2974     my $issuing_charges = 15;
2975     my $title   = 'A title';
2976     my $author  = 'Author, An';
2977     my $barcode = 'WHATARETHEODDS';
2978
2979     my $circ = Test::MockModule->new('C4::Circulation');
2980     $circ->mock(
2981         'GetIssuingCharges',
2982         sub {
2983             return $issuing_charges;
2984         }
2985     );
2986
2987     my $library  = $builder->build_object({ class => 'Koha::Libraries' });
2988     my $itemtype = $builder->build_object({ class => 'Koha::ItemTypes', value => { rentalcharge_daily => 0.00 }});
2989     my $patron   = $builder->build_object({
2990         class => 'Koha::Patrons',
2991         value => { branchcode => $library->id }
2992     });
2993
2994     my $biblio = $builder->build_sample_biblio({ title=> $title, author => $author });
2995     my ( undef, undef, $item_id ) = AddItem(
2996         {
2997             homebranch       => $library->id,
2998             holdingbranch    => $library->id,
2999             barcode          => $barcode,
3000             replacementprice => 23.00,
3001             itype            => $itemtype->id
3002         },
3003         $biblio->biblionumber
3004     );
3005     my $item = Koha::Items->find( $item_id );
3006
3007     my $context = Test::MockModule->new('C4::Context');
3008     $context->mock( userenv => { branch => $library->id } );
3009
3010     # Check the item out
3011     AddIssue( $patron->unblessed, $item->barcode );
3012     t::lib::Mocks::mock_preference( 'RenewalLog', 0 );
3013     my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
3014     my %params_renewal = (
3015         timestamp => { -like => $date . "%" },
3016         module => "CIRCULATION",
3017         action => "RENEWAL",
3018     );
3019     my $old_log_size = Koha::ActionLogs->count( \%params_renewal );;
3020     AddRenewal( $patron->id, $item->id, $library->id );
3021     my $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3022     is( $new_log_size, $old_log_size, 'renew log not added because of the syspref RenewalLog' );
3023
3024     my $checkouts = $patron->checkouts;
3025     # The following will fail if run on 00:00:00
3026     unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part');
3027
3028     my $lines = Koha::Account::Lines->search({
3029         borrowernumber => $patron->id,
3030         itemnumber     => $item->id
3031     });
3032
3033     is( $lines->count, 2 );
3034
3035     my $line = $lines->next;
3036     is( $line->accounttype, 'RENT',       'The issue of item with issuing charge generates an accountline of the correct type' );
3037     is( $line->branchcode,  $library->id, 'AddIssuingCharge correctly sets branchcode' );
3038     is( $line->description, '',     'AddIssue does not set a hardcoded description for the accountline' );
3039
3040     $line = $lines->next;
3041     is( $line->accounttype, 'RENT_RENEW', 'The renewal of item with issuing charge generates an accountline of the correct type' );
3042     is( $line->branchcode,  $library->id, 'AddRenewal correctly sets branchcode' );
3043     is( $line->description, '', 'AddRenewal does not set a hardcoded description for the accountline' );
3044
3045     t::lib::Mocks::mock_preference( 'RenewalLog', 1 );
3046     $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } );
3047     $old_log_size = Koha::ActionLogs->count( \%params_renewal );
3048     AddRenewal( $patron->id, $item->id, $library->id );
3049     $new_log_size = Koha::ActionLogs->count( \%params_renewal );
3050     is( $new_log_size, $old_log_size + 1, 'renew log successfully added' );
3051
3052 };
3053
3054 subtest 'ProcessOfflinePayment() tests' => sub {
3055
3056     plan tests => 4;
3057
3058
3059     my $amount = 123;
3060
3061     my $patron  = $builder->build_object({ class => 'Koha::Patrons' });
3062     my $library = $builder->build_object({ class => 'Koha::Libraries' });
3063     my $result  = C4::Circulation::ProcessOfflinePayment({ cardnumber => $patron->cardnumber, amount => $amount, branchcode => $library->id });
3064
3065     is( $result, 'Success.', 'The right string is returned' );
3066
3067     my $lines = $patron->account->lines;
3068     is( $lines->count, 1, 'line created correctly');
3069
3070     my $line = $lines->next;
3071     is( $line->amount+0, $amount * -1, 'amount picked from params' );
3072     is( $line->branchcode, $library->id, 'branchcode set correctly' );
3073
3074 };
3075
3076 subtest 'Incremented fee tests' => sub {
3077     plan tests => 11;
3078
3079     t::lib::Mocks::mock_preference('item-level_itypes', 1);
3080
3081     my $library = $builder->build_object( { class => 'Koha::Libraries' } )->store;
3082
3083     my $module = new Test::MockModule('C4::Context');
3084     $module->mock('userenv', sub { { branch => $library->id } });
3085
3086     my $patron = $builder->build_object(
3087         {
3088             class => 'Koha::Patrons',
3089             value => { categorycode => $patron_category->{categorycode} }
3090         }
3091     )->store;
3092
3093     my $itemtype = $builder->build_object(
3094         {
3095             class => 'Koha::ItemTypes',
3096             value  => {
3097                 notforloan          => undef,
3098                 rentalcharge        => 0,
3099                 rentalcharge_daily => 1.000000
3100             }
3101         }
3102     )->store;
3103
3104     my $item = $builder->build_sample_item(
3105         {
3106             library  => $library->{branchcode},
3107             itype    => $itemtype->id,
3108         }
3109     );
3110
3111     is( $itemtype->rentalcharge_daily, '1.000000', 'Daily rental charge stored and retreived correctly' );
3112     is( $item->effective_itemtype, $itemtype->id, "Itemtype set correctly for item");
3113
3114     my $dt_from = dt_from_string();
3115     my $dt_to = dt_from_string()->add( days => 7 );
3116     my $dt_to_renew = dt_from_string()->add( days => 13 );
3117
3118     t::lib::Mocks::mock_preference('finesCalendar', 'ignoreCalendar');
3119     my $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3120     my $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3121     is( $accountline->amount, '7.000000', "Daily rental charge calculated correctly with finesCalendar = ignoreCalendar" );
3122     $accountline->delete();
3123     AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3124     $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3125     is( $accountline->amount, '6.000000', "Daily rental charge calculated correctly with finesCalendar = ignoreCalendar, for renewal" );
3126     $accountline->delete();
3127     $issue->delete();
3128
3129     t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
3130     $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3131     $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3132     is( $accountline->amount, '7.000000', "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed" );
3133     $accountline->delete();
3134     AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3135     $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3136     is( $accountline->amount, '6.000000', "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed, for renewal" );
3137     $accountline->delete();
3138     $issue->delete();
3139
3140     my $calendar = C4::Calendar->new( branchcode => $library->id );
3141     $calendar->insert_week_day_holiday(
3142         weekday     => 3,
3143         title       => 'Test holiday',
3144         description => 'Test holiday'
3145     );
3146     $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from );
3147     $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3148     is( $accountline->amount, '6.000000', "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Wednesdays" );
3149     $accountline->delete();
3150     AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3151     $accountline = Koha::Account::Lines->find({ itemnumber => $item->id });
3152     is( $accountline->amount, '5.000000', "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Wednesdays, for renewal" );
3153     $accountline->delete();
3154     $issue->delete();
3155
3156     $itemtype->rentalcharge('2.000000')->store;
3157     is( $itemtype->rentalcharge, '2.000000', 'Rental charge updated and retreived correctly' );
3158     $issue = AddIssue( $patron->unblessed, $item->barcode, $dt_to, undef, $dt_from);
3159     my $accountlines = Koha::Account::Lines->search({ itemnumber => $item->id });
3160     is( $accountlines->count, '2', "Fixed charge and accrued charge recorded distinctly");
3161     $accountlines->delete();
3162     AddRenewal( $patron->id, $item->id, $library->id, $dt_to_renew, $dt_to );
3163     $accountlines = Koha::Account::Lines->search({ itemnumber => $item->id });
3164     is( $accountlines->count, '2', "Fixed charge and accrued charge recorded distinctly, for renewal");
3165     $accountlines->delete();
3166     $issue->delete();
3167 };
3168
3169 subtest 'CanBookBeIssued & RentalFeesCheckoutConfirmation' => sub {
3170     plan tests => 2;
3171
3172     t::lib::Mocks::mock_preference('RentalFeesCheckoutConfirmation', 1);
3173     t::lib::Mocks::mock_preference('item-level_itypes', 1);
3174
3175     my $library =
3176       $builder->build_object( { class => 'Koha::Libraries' } )->store;
3177     my $patron = $builder->build_object(
3178         {
3179             class => 'Koha::Patrons',
3180             value => { categorycode => $patron_category->{categorycode} }
3181         }
3182     )->store;
3183
3184     my $itemtype = $builder->build_object(
3185         {
3186             class => 'Koha::ItemTypes',
3187             value => {
3188                 notforloan             => 0,
3189                 rentalcharge           => 0,
3190                 rentalcharge_daily => 0
3191             }
3192         }
3193     );
3194
3195     my $biblioitem = $builder->build( { source => 'Biblioitem' } );
3196     my $item = $builder->build_object(
3197         {
3198             class => 'Koha::Items',
3199             value  => {
3200                 homebranch    => $library->id,
3201                 holdingbranch => $library->id,
3202                 notforloan    => 0,
3203                 itemlost      => 0,
3204                 withdrawn     => 0,
3205                 itype         => $itemtype->id,
3206                 biblionumber  => $biblioitem->{biblionumber},
3207                 biblioitemnumber => $biblioitem->{biblioitemnumber},
3208             }
3209         }
3210     )->store;
3211
3212     my ( $issuingimpossible, $needsconfirmation );
3213     my $dt_from = dt_from_string();
3214     my $dt_due = dt_from_string()->add( days => 3 );
3215
3216     $itemtype->rentalcharge('1.000000')->store;
3217     ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
3218     is_deeply( $needsconfirmation, { RENTALCHARGE => '1' }, 'Item needs rentalcharge confirmation to be issued' );
3219     $itemtype->rentalcharge('0')->store;
3220     $itemtype->rentalcharge_daily('1.000000')->store;
3221     ( $issuingimpossible, $needsconfirmation ) = CanBookBeIssued( $patron, $item->barcode, $dt_due, undef, undef, undef );
3222     is_deeply( $needsconfirmation, { RENTALCHARGE => '3' }, 'Item needs rentalcharge confirmation to be issued, increment' );
3223     $itemtype->rentalcharge_daily('0')->store;
3224 };
3225
3226 $schema->storage->txn_rollback;
3227 C4::Context->clear_syspref_cache();
3228 $cache->clear_from_cache('single_holidays');