3 # This Koha test module is a stub!
4 # Add more tests here!!!
7 use POSIX
qw(strftime);
9 use C4
::Bookseller
qw( GetBookSellerFromId );
11 use Test
::More tests
=> 87;
14 use_ok
('C4::Acquisition');
15 use_ok
('C4::Bookseller');
17 use_ok
('C4::Budgets');
18 use_ok
('C4::Bookseller');
19 use_ok
('Koha::Acquisition::Order');
22 # Sub used for testing C4::Acquisition subs returning order(s):
23 # GetOrdersByStatus, GetOrders, GetDeletedOrders, GetOrder etc.
24 # (\@test_missing_fields,\@test_extra_fields,\@test_different_fields,$test_nbr_fields) =
25 # _check_fields_of_order ($exp_fields, $original_order_content, $order_to_check);
27 # $exp_fields : arrayref whose elements are the keys we expect to find
28 # $original_order_content : hashref whose 2 keys str and num contains hashrefs
29 # containing content fields of the order created with Koha::Acquisition::Order
30 # $order_to_check : hashref whose keys/values are the content of an order
31 # returned by the C4::Acquisition sub we are testing
33 # \@test_missing_fields : arrayref void if ok ; otherwise contains the list of
34 # fields missing in $order_to_check
35 # \@test_extra_fields : arrayref void if ok ; otherwise contains the list of
36 # fields unexpected in $order_to_check
37 # \@test_different_fields : arrayref void if ok ; otherwise contains the list of
38 # fields which value is not the same in between $order_to_check and
39 # $test_nbr_fields : contains the number of fields of $order_to_check
41 sub _check_fields_of_order
{
42 my ( $exp_fields, $original_order_content, $order_to_check ) = @_;
43 my @test_missing_fields = ();
44 my @test_extra_fields = ();
45 my @test_different_fields = ();
46 my $test_nbr_fields = scalar( keys %$order_to_check );
47 foreach my $field (@
$exp_fields) {
48 push @test_missing_fields, $field
49 unless exists( $order_to_check->{$field} );
51 foreach my $field ( keys %$order_to_check ) {
52 push @test_extra_fields, $field
53 unless grep ( /^$field$/, @
$exp_fields );
55 foreach my $field ( keys %{ $original_order_content->{str
} } ) {
56 push @test_different_fields, $field
57 unless ( !exists $order_to_check->{$field} )
58 or ( $original_order_content->{str
}->{$field} eq
59 $order_to_check->{$field} );
61 foreach my $field ( keys %{ $original_order_content->{num
} } ) {
62 push @test_different_fields, $field
63 unless ( !exists $order_to_check->{$field} )
64 or ( $original_order_content->{num
}->{$field} ==
65 $order_to_check->{$field} );
68 \
@test_missing_fields, \
@test_extra_fields,
69 \
@test_different_fields, $test_nbr_fields
73 # Sub used for testing C4::Acquisition subs returning several orders
74 # (\@test_missing_fields,\@test_extra_fields,\@test_different_fields,\@test_nbr_fields) =
75 # _check_fields_of_orders ($exp_fields, $original_orders_content, $orders_to_check)
76 sub _check_fields_of_orders
{
77 my ( $exp_fields, $original_orders_content, $orders_to_check ) = @_;
78 my @test_missing_fields = ();
79 my @test_extra_fields = ();
80 my @test_different_fields = ();
81 my @test_nbr_fields = ();
82 foreach my $order_to_check (@
$orders_to_check) {
83 my $original_order_content =
84 ( grep { $_->{str
}->{ordernumber
} eq $order_to_check->{ordernumber
} }
85 @
$original_orders_content )[0];
87 $t_missing_fields, $t_extra_fields,
88 $t_different_fields, $t_nbr_fields
90 = _check_fields_of_order
( $exp_fields, $original_order_content,
92 push @test_missing_fields, @
$t_missing_fields;
93 push @test_extra_fields, @
$t_extra_fields;
94 push @test_different_fields, @
$t_different_fields;
95 push @test_nbr_fields, $t_nbr_fields;
97 @test_missing_fields = keys %{ { map { $_ => 1 } @test_missing_fields } };
98 @test_extra_fields = keys %{ { map { $_ => 1 } @test_extra_fields } };
99 @test_different_fields =
100 keys %{ { map { $_ => 1 } @test_different_fields } };
102 \
@test_missing_fields, \
@test_extra_fields,
103 \
@test_different_fields, \
@test_nbr_fields
107 my $dbh = C4
::Context
->dbh;
108 $dbh->{AutoCommit
} = 0;
109 $dbh->{RaiseError
} = 1;
111 # Creating some orders
112 my $booksellerid = C4
::Bookseller
::AddBookseller
(
115 address1
=> "bookseller's address",
122 my $booksellerinfo = C4
::Bookseller
::GetBookSellerFromId
($booksellerid);
124 is
( $booksellerinfo->{deliverytime
},
125 5, 'set deliverytime when creating vendor (Bug 10556)' );
127 my ( $basket, $basketno );
129 $basketno = NewBasket
( $booksellerid, 1 ),
130 "NewBasket( $booksellerid , 1 ) returns $basketno"
132 ok
( $basket = GetBasket
($basketno), "GetBasket($basketno) returns $basket" );
134 my $budgetid = C4
::Budgets
::AddBudget
(
136 budget_code
=> "budget_code_test_getordersbybib",
137 budget_name
=> "budget_name_test_getordersbybib",
140 my $budget = C4
::Budgets
::GetBudget
($budgetid);
143 my ( $biblionumber1, $biblioitemnumber1 ) = AddBiblio
( MARC
::Record
->new, '' );
144 my ( $biblionumber2, $biblioitemnumber2 ) = AddBiblio
( MARC
::Record
->new, '' );
145 my ( $biblionumber3, $biblioitemnumber3 ) = AddBiblio
( MARC
::Record
->new, '' );
146 my ( $biblionumber4, $biblioitemnumber4 ) = AddBiblio
( MARC
::Record
->new, '' );
148 # Prepare 5 orders, and make distinction beween fields to be tested with eq and with ==
149 # Ex : a price of 50.1 will be stored internally as 5.100000
151 my @order_content = (
154 basketno
=> $basketno,
155 biblionumber
=> $biblionumber1,
156 budget_id
=> $budget->{budget_id
},
158 order_internalnote
=> "internal note",
159 order_vendornote
=> "vendor note",
164 listprice
=> 50.121111,
173 basketno
=> $basketno,
174 biblionumber
=> $biblionumber2,
175 budget_id
=> $budget->{budget_id
}
177 num
=> { quantity
=> 42 }
181 basketno
=> $basketno,
182 biblionumber
=> $biblionumber2,
183 budget_id
=> $budget->{budget_id
},
185 order_internalnote
=> "internal note",
186 order_vendornote
=> "vendor note"
201 basketno
=> $basketno,
202 biblionumber
=> $biblionumber3,
203 budget_id
=> $budget->{budget_id
},
204 order_internalnote
=> "internal note",
205 order_vendornote
=> "vendor note"
221 basketno
=> $basketno,
222 biblionumber
=> $biblionumber4,
223 budget_id
=> $budget->{budget_id
},
224 order_internalnote
=> "internal note",
225 order_vendornote
=> "vendor note"
241 # Create 4 orders in database
244 @ocontent{ keys %{ $order_content[$_]->{num
} } } =
245 values %{ $order_content[$_]->{num
} };
246 @ocontent{ keys %{ $order_content[$_]->{str
} } } =
247 values %{ $order_content[$_]->{str
} };
248 $ordernumbers[$_] = Koha
::Acquisition
::Order
->new( \
%ocontent )->insert->{ordernumber
};
249 $order_content[$_]->{str
}->{ordernumber
} = $ordernumbers[$_];
252 # Test UT sub _check_fields_of_order
255 $test_missing_fields, $test_extra_fields,
256 $test_different_fields, $test_nbr_fields
258 = _check_fields_of_order
(
260 { str
=> { a
=> "bla", b
=> "105" }, num
=> { c
=> 15.12 } },
261 { a
=> "blabla", f
=> "f", b
=> "105", c
=> 15.1200, g
=> '' }
265 ( $test_nbr_fields == 5 )
266 and ( join( " ", sort @
$test_missing_fields ) eq 'd e' )
267 and ( join( " ", sort @
$test_extra_fields ) eq 'f g' )
268 and ( join( " ", @
$test_different_fields ) eq 'a' )
270 "_check_fields_of_order can check an order (test 1)"
273 $test_missing_fields, $test_extra_fields,
274 $test_different_fields, $test_nbr_fields
276 = _check_fields_of_order
(
278 { str
=> { a
=> "bla", b
=> "105" }, num
=> { c
=> 15.00 } },
279 { a
=> "bla", b
=> "105", c
=> 15 }
283 ( $test_nbr_fields == 3 )
284 and ( scalar @
$test_missing_fields == 0 )
285 and ( scalar @
$test_extra_fields == 0 )
286 and ( scalar @
$test_different_fields == 0 )
288 "_check_fields_of_order can check an order (test 2)"
291 $test_missing_fields, $test_extra_fields,
292 $test_different_fields, $test_nbr_fields
294 = _check_fields_of_order
(
296 { str
=> { a
=> "bla", b
=> "105" }, num
=> { c
=> 15.12 } },
297 { a
=> "blabla", b
=> "105", c
=> 15, d
=> "error" }
301 ( $test_nbr_fields == 4 )
302 and ( join( " ", sort @
$test_missing_fields ) eq 'e' )
303 and ( scalar @
$test_extra_fields == 0 )
304 and ( join( " ", @
$test_different_fields ) eq 'a c' )
306 "_check_fields_of_order can check an order (test 3)"
313 my @expectedfields = qw(
328 datecancellationprinted
367 estimateddeliverydate
374 $test_missing_fields, $test_extra_fields,
375 $test_different_fields, $test_nbr_fields
377 = _check_fields_of_order
( \
@expectedfields, $order_content[0],
378 GetOrder
( $ordernumbers[0] ) );
381 scalar @expectedfields,
382 "GetOrder gets an order with the right number of fields"
384 is
( join( " ", @
$test_missing_fields ),
385 '', "GetOrder gets an order with no missing fields" );
386 is
( join( " ", @
$test_extra_fields ),
387 '', "GetOrder gets an order with no unexpected fields" );
388 is
( join( " ", @
$test_different_fields ),
389 '', "GetOrder gets an order with the right content in every fields" );
395 my @base_expectedfields = qw(
437 editionresponsibility
483 datecancellationprinted
486 ( @base_expectedfields,
487 ( 'transferred_from_timestamp', 'transferred_from' ) );
488 is
( GetOrders
(), undef, "GetOrders with no params returns undef" );
489 DelOrder
( $order_content[3]->{str
}->{biblionumber
}, $ordernumbers[3] );
490 my @get_orders = GetOrders
($basketno);
492 $test_missing_fields, $test_extra_fields,
493 $test_different_fields, $test_nbr_fields
495 = _check_fields_of_orders
( \
@expectedfields, \
@order_content, \
@get_orders );
497 $$test_nbr_fields[0],
498 scalar @expectedfields,
499 "GetOrders gets orders with the right number of fields"
501 is
( join( " ", @
$test_missing_fields ),
502 '', "GetOrders gets orders with no missing fields" );
503 is
( join( " ", @
$test_extra_fields ),
504 '', "GetOrders gets orders with no unexpected fields" );
505 is
( join( " ", @
$test_different_fields ),
506 '', "GetOrders gets orders with the right content in every fields" );
509 ( scalar @get_orders == 4 )
510 and !grep ( $_->{ordernumber
} eq $ordernumbers[3], @get_orders )
512 "GetOrders only gets non-cancelled orders"
516 # Test GetCancelledOrders
520 ( @base_expectedfields, ( 'transferred_to_timestamp', 'transferred_to' ) );
521 is
( GetCancelledOrders
(), undef,
522 "GetCancelledOrders with no params returns undef" );
523 @get_orders = GetCancelledOrders
($basketno);
525 $test_missing_fields, $test_extra_fields,
526 $test_different_fields, $test_nbr_fields
528 = _check_fields_of_orders
( \
@expectedfields, \
@order_content, \
@get_orders );
530 $$test_nbr_fields[0],
531 scalar @expectedfields,
532 "GetCancelledOrders gets orders with the right number of fields"
534 is
( join( " ", @
$test_missing_fields ),
535 '', "GetCancelledOrders gets orders with no missing fields" );
536 is
( join( " ", @
$test_extra_fields ),
537 '', "GetCancelledOrders gets orders with no unexpected fields" );
538 is
( join( " ", @
$test_different_fields ),
540 "GetCancelledOrders gets orders with the right content in every fields" );
543 ( scalar @get_orders == 1 )
544 and grep ( $_->{ordernumber
} eq $ordernumbers[3], @get_orders )
546 "GetCancelledOrders only gets cancelled orders"
553 @expectedfields = qw
(
607 datecancellationprinted
613 # note that authorisedby was added to the return of SearchOrder by the
614 # patch for bug 11777
616 my $invoiceid = AddInvoice
(
617 invoicenumber
=> 'invoice',
618 booksellerid
=> $booksellerid,
622 my ($datereceived, $new_ordernumber) = ModReceiveOrder
(
624 biblionumber
=> $biblionumber4,
625 ordernumber
=> $ordernumbers[4],
626 quantityreceived
=> 1,
629 invoiceid
=> $invoiceid,
631 budget_id
=> $order_content[4]->{str
}->{budget_id
},
635 my $search_orders = SearchOrders
({
636 booksellerid
=> $booksellerid,
637 basketno
=> $basketno
639 isa_ok
( $search_orders, 'ARRAY' );
641 $test_missing_fields, $test_extra_fields,
642 $test_different_fields, $test_nbr_fields
644 = _check_fields_of_orders
( \
@expectedfields, \
@order_content,
647 $$test_nbr_fields[0],
648 scalar @expectedfields,
649 "SearchOrders gets orders with the right number of fields"
651 is
( join( " ", @
$test_missing_fields ),
652 '', "SearchOrders gets orders with no missing fields" );
653 is
( join( " ", @
$test_extra_fields ),
654 '', "SearchOrders gets orders with no unexpected fields" );
655 is
( join( " ", @
$test_different_fields ),
656 '', "SearchOrders gets orders with the right content in every fields" );
659 ( scalar @
$search_orders == 4 )
660 and !grep ( $_->{ordernumber
} eq $ordernumbers[3], @
$search_orders )
662 "SearchOrders only gets non-cancelled orders"
665 $search_orders = SearchOrders
({
666 booksellerid
=> $booksellerid,
667 basketno
=> $basketno,
672 ( scalar @
$search_orders == 3 ) and !grep ( (
673 ( $_->{ordernumber
} eq $ordernumbers[3] )
674 or ( $_->{ordernumber
} eq $ordernumbers[4] )
678 "SearchOrders with pending params gets only pending orders (bug 10723)"
681 $search_orders = SearchOrders
({
682 booksellerid
=> $booksellerid,
683 basketno
=> $basketno,
687 is
( scalar (@
$search_orders), 0, "SearchOrders with pending and ordered params gets only pending ordered orders (bug 11170)" );
689 $search_orders = SearchOrders
({
690 ordernumber
=> $ordernumbers[4]
692 is
( scalar (@
$search_orders), 1, "SearchOrders takes into account the ordernumber filter" );
694 $search_orders = SearchOrders
({
695 biblionumber
=> $biblionumber4
697 is
( scalar (@
$search_orders), 1, "SearchOrders takes into account the biblionumber filter" );
699 $search_orders = SearchOrders
({
700 biblionumber
=> $biblionumber4,
703 is
( scalar (@
$search_orders), 0, "SearchOrders takes into account the biblionumber and pending filters" );
706 # Test GetBudgetByOrderNumber
708 ok
( GetBudgetByOrderNumber
( $ordernumbers[0] )->{'budget_id'} eq $budgetid,
709 "GetBudgetByOrderNumber returns expected budget" );
715 @expectedfields = qw
(
728 estimateddeliverydate
739 my @lateorders = GetLateOrders
(0);
740 is
( scalar grep ( $_->{basketno
} eq $basketno, @lateorders ),
741 0, "GetLateOrders does not get orders from opened baskets" );
742 C4
::Acquisition
::CloseBasket
($basketno);
743 @lateorders = GetLateOrders
(0);
744 isnt
( scalar grep ( $_->{basketno
} eq $basketno, @lateorders ),
745 0, "GetLateOrders gets orders from closed baskets" );
746 ok
( !grep ( $_->{ordernumber
} eq $ordernumbers[3], @lateorders ),
747 "GetLateOrders does not gets cancelled orders" );
748 ok
( !grep ( $_->{ordernumber
} eq $ordernumbers[4], @lateorders ),
749 "GetLateOrders does not gets reveived orders" );
751 $test_missing_fields, $test_extra_fields,
752 $test_different_fields, $test_nbr_fields
754 = _check_fields_of_orders
( \
@expectedfields, \
@order_content, \
@lateorders );
756 $$test_nbr_fields[0],
757 scalar @expectedfields,
758 "GetLateOrders gets orders with the right number of fields"
760 is
( join( " ", @
$test_missing_fields ),
761 '', "GetLateOrders gets orders with no missing fields" );
762 is
( join( " ", @
$test_extra_fields ),
763 '', "GetLateOrders gets orders with no unexpected fields" );
764 is
( join( " ", @
$test_different_fields ),
765 '', "GetLateOrders gets orders with the right content in every fields" );
767 $search_orders = SearchOrders
({
768 booksellerid
=> $booksellerid,
769 basketno
=> $basketno,
773 is
( scalar (@
$search_orders), 3, "SearchOrders with pending and ordered params gets only pending ordered orders. After closing the basket, orders are marked as 'ordered' (bug 11170)" );
779 my $order = $lateorders[0];
780 AddClaim
( $order->{ordernumber
} );
781 my $neworder = GetOrder
( $order->{ordernumber
} );
783 $neworder->{claimed_date
},
784 strftime
( "%Y-%m-%d", localtime(time) ),
785 "AddClaim : Check claimed_date"
788 ( $datereceived, $new_ordernumber ) = ModReceiveOrder
(
790 biblionumber
=> $biblionumber2,
791 ordernumber
=> $ordernumbers[1],
792 quantityreceived
=> 2,
795 invoiceid
=> $invoiceid,
797 order_internalnote
=> "my notes",
798 order_vendornote
=> "my vendor notes",
801 my $order2 = GetOrder
( $ordernumbers[1] );
802 is
( $order2->{'quantityreceived'},
803 0, 'Splitting up order did not receive any on original order' );
804 is
( $order2->{'quantity'}, 40, '40 items on original order' );
805 is
( $order2->{'budget_id'}, $budgetid,
806 'Budget on original order is unchanged' );
807 is
( $order2->{order_internalnote
}, "my notes",
808 'ModReceiveOrder and GetOrder deal with internal notes' );
809 is
( $order2->{order_vendornote
}, "my vendor notes",
810 'ModReceiveOrder and GetOrder deal with vendor notes' );
812 $neworder = GetOrder
($new_ordernumber);
813 is
( $neworder->{'quantity'}, 2, '2 items on new order' );
814 is
( $neworder->{'quantityreceived'},
815 2, 'Splitting up order received items on new order' );
816 is
( $neworder->{'budget_id'}, $budgetid, 'Budget on new order is unchanged' );
818 is
( $neworder->{ordernumber
}, $new_ordernumber, 'Split: test ordernumber' );
819 is
( $neworder->{parent_ordernumber
}, $ordernumbers[1], 'Split: test parent_ordernumber' );
821 my ( $orders ) = GetHistory
( ordernumber
=> $ordernumbers[1] );
822 is
( scalar( @
$orders ), 1, 'GetHistory with a given ordernumber returns 1 order' );
823 ( $orders ) = GetHistory
( ordernumber
=> $ordernumbers[1], search_children_too
=> 1 );
824 is
( scalar( @
$orders ), 2, 'GetHistory with a given ordernumber and search_children_too set returns 2 orders' );
826 my $budgetid2 = C4
::Budgets
::AddBudget
(
828 budget_code
=> "budget_code_test_modrecv",
829 budget_name
=> "budget_name_test_modrecv",
833 ( $datereceived, $new_ordernumber ) = ModReceiveOrder
(
835 biblionumber
=> $biblionumber2,
836 ordernumber
=> $ordernumbers[2],
837 quantityreceived
=> 2,
840 invoiceid
=> $invoiceid,
842 budget_id
=> $budgetid2,
843 order_internalnote
=> "my other notes",
847 my $order3 = GetOrder
( $ordernumbers[2] );
848 is
( $order3->{'quantityreceived'},
849 0, 'Splitting up order did not receive any on original order' );
850 is
( $order3->{'quantity'}, 2, '2 items on original order' );
851 is
( $order3->{'budget_id'}, $budgetid,
852 'Budget on original order is unchanged' );
853 is
( $order3->{order_internalnote
}, "my other notes",
854 'ModReceiveOrder and GetOrder deal with notes' );
856 $neworder = GetOrder
($new_ordernumber);
857 is
( $neworder->{'quantity'}, 2, '2 items on new order' );
858 is
( $neworder->{'quantityreceived'},
859 2, 'Splitting up order received items on new order' );
860 is
( $neworder->{'budget_id'}, $budgetid2, 'Budget on new order is changed' );
862 ( $datereceived, $new_ordernumber ) = ModReceiveOrder
(
864 biblionumber
=> $biblionumber2,
865 ordernumber
=> $ordernumbers[2],
866 quantityreceived
=> 2,
869 invoiceid
=> $invoiceid,
871 budget_id
=> $budgetid2,
872 order_internalnote
=> "my third notes",
876 $order3 = GetOrder
( $ordernumbers[2] );
877 is
( $order3->{'quantityreceived'}, 2, 'Order not split up' );
878 is
( $order3->{'quantity'}, 2, '2 items on order' );
879 is
( $order3->{'budget_id'}, $budgetid2, 'Budget has changed' );
880 is
( $order3->{order_internalnote
}, "my third notes", 'ModReceiveOrder and GetOrder deal with notes' );
882 my $nonexistent_order = GetOrder
();
883 is
( $nonexistent_order, undef, 'GetOrder returns undef if no ordernumber is given' );
884 $nonexistent_order = GetOrder
( 424242424242 );
885 is
( $nonexistent_order, undef, 'GetOrder returns undef if a nonexistent ordernumber is given' );
888 my $order1 = GetOrder
($ordernumbers[0]);
889 my $error = DelOrder
($order1->{biblionumber
}, $order1->{ordernumber
});
890 ok
((not defined $error), "DelOrder does not fail");
891 $order1 = GetOrder
($order1->{ordernumber
});
892 ok
((defined $order1->{datecancellationprinted
}), "order is cancelled");
893 ok
((not defined $order1->{cancellationreason
}), "order has no cancellation reason");
894 ok
((defined GetBiblio
($order1->{biblionumber
})), "biblio still exists");
896 my $order2 = GetOrder
($ordernumbers[1]);
897 my $error = DelOrder
($order2->{biblionumber
}, $order2->{ordernumber
}, 1);
898 ok
((not defined $error), "DelOrder does not fail");
899 $order2 = GetOrder
($order2->{ordernumber
});
900 ok
((defined $order2->{datecancellationprinted
}), "order is cancelled");
901 ok
((not defined $order2->{cancellationreason
}), "order has no cancellation reason");
902 ok
((not defined GetBiblio
($order2->{biblionumber
})), "biblio does not exist anymore");
904 my $order4 = GetOrder
($ordernumbers[3]);
905 my $error = DelOrder
($order4->{biblionumber
}, $order4->{ordernumber
}, 1, "foobar");
906 ok
((not defined $error), "DelOrder does not fail");
907 $order4 = GetOrder
($order4->{ordernumber
});
908 ok
((defined $order4->{datecancellationprinted
}), "order is cancelled");
909 ok
(($order4->{cancellationreason
} eq "foobar"), "order has cancellation reason \"foobar\"");
910 ok
((not defined GetBiblio
($order4->{biblionumber
})), "biblio does not exist anymore");
911 # End of tests for DelOrder