t/db_dependent/Suggestions.t

   1 #!/usr/bin/perl
   2
   3 # This file is part of Koha.
   4 #
   5 # Koha is free software; you can redistribute it and/or modify it
   6 # under the terms of the GNU General Public License as published by
   7 # the Free Software Foundation; either version 3 of the License, or
   8 # (at your option) any later version.
   9 #
  10 # Koha is distributed in the hope that it will be useful, but
  11 # WITHOUT ANY WARRANTY; without even the implied warranty of
  12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  13 # GNU General Public License for more details.
  14 #
  15 # You should have received a copy of the GNU General Public License
  16 # along with Koha; if not, see <http://www.gnu.org/licenses>.
  17
  18 use Modern::Perl;
  19
  20 use DateTime::Duration;
  21 use Test::More tests => 107;
  22 use Test::Warn;
  23
  24 use t::lib::Mocks;
  25 use t::lib::TestBuilder;
  26
  27 use C4::Context;
  28 use C4::Letters;
  29 use C4::Budgets qw( AddBudgetPeriod AddBudget );
  30 use Koha::Database;
  31 use Koha::DateUtils qw( dt_from_string output_pref );
  32 use Koha::Libraries;
  33 use Koha::Patrons;
  34 use Koha::Suggestions;
  35
  36 BEGIN {
  37     use_ok('C4::Suggestions');
  38 }
  39
  40 my $schema  = Koha::Database->new->schema;
  41 $schema->storage->txn_begin;
  42 my $dbh = C4::Context->dbh;
  43 my $builder = t::lib::TestBuilder->new;
  44
  45 t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0");
  46
  47 # Reset item types to only the default ones
  48 $dbh->do(q|DELETE FROM itemtypes;|);
  49 my $sql = qq|
  50 INSERT INTO itemtypes (itemtype, description, rentalcharge, notforloan, imageurl, summary) VALUES
  51 ('BK', 'Books',5,0,'bridge/book.gif',''),
  52 ('MX', 'Mixed Materials',5,0,'bridge/kit.gif',''),
  53 ('CF', 'Computer Files',5,0,'bridge/computer_file.gif',''),
  54 ('MP', 'Maps',5,0,'bridge/map.gif',''),
  55 ('VM', 'Visual Materials',5,1,'bridge/dvd.gif',''),
  56 ('MU', 'Music',5,0,'bridge/sound.gif',''),
  57 ('CR', 'Continuing Resources',5,0,'bridge/periodical.gif',''),
  58 ('REF', 'Reference',0,1,'bridge/reference.gif','');|;
  59 $dbh->do($sql);
  60 $dbh->do(q|DELETE FROM suggestions|);
  61 $dbh->do(q|DELETE FROM issues|);
  62 $dbh->do(q|DELETE FROM borrowers|);
  63 $dbh->do(q|DELETE FROM letter|);
  64 $dbh->do(q|DELETE FROM message_queue|);
  65 $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'CHECKED', 'my content')|);
  66 $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'NEW_SUGGESTION', 'Content for new suggestion')|);
  67
  68 # Add CPL if missing.
  69 if (not defined Koha::Libraries->find('CPL')) {
  70     Koha::Library->new({ branchcode => 'CPL', branchname => 'Centerville' })->store;
  71 }
  72
  73 my $patron_category = $builder->build({ source => 'Category' });
  74
  75 my $member = {
  76     firstname => 'my firstname',
  77     surname => 'my surname',
  78     categorycode => $patron_category->{categorycode},
  79     branchcode => 'CPL',
  80     smsalertnumber => 12345,
  81 };
  82
  83 my $member2 = {
  84     firstname => 'my firstname',
  85     surname => 'my surname',
  86     categorycode => $patron_category->{categorycode},
  87     branchcode => 'CPL',
  88     email => 'to@example.com',
  89 };
  90
  91 my $borrowernumber = Koha::Patron->new($member)->store->borrowernumber;
  92 my $borrowernumber2 = Koha::Patron->new($member2)->store->borrowernumber;
  93
  94 my $biblionumber1 = 1;
  95 my $my_suggestion = {
  96     title         => 'my title',
  97     author        => 'my author',
  98     publishercode => 'my publishercode',
  99     suggestedby   => $borrowernumber,
 100     biblionumber  => $biblionumber1,
 101     branchcode    => 'CPL',
 102     managedby     => '',
 103     manageddate   => '',
 104     accepteddate  => dt_from_string,
 105     note          => 'my note',
 106 };
 107
 108 my $budgetperiod_id = AddBudgetPeriod({
 109     budget_period_startdate   => '2008-01-01',
 110     budget_period_enddate     => '2008-12-31',
 111     budget_period_description => 'MAPERI',
 112     budget_period_active      => 1,
 113 });
 114
 115 my $budget_id = AddBudget({
 116     budget_code      => 'ABCD',
 117     budget_amount    => '123.132000',
 118     budget_name      => 'ABCD',
 119     budget_notes     => 'This is a note',
 120     budget_period_id => $budgetperiod_id,
 121 });
 122 my $my_suggestion_with_budget = {
 123     title         => 'my title 2',
 124     author        => 'my author 2',
 125     publishercode => 'my publishercode 2',
 126     suggestedby   => $borrowernumber,
 127     biblionumber  => $biblionumber1,
 128     managedby     => '',
 129     manageddate   => '',
 130     accepteddate  => dt_from_string,
 131     note          => 'my note',
 132     budgetid      => $budget_id,
 133 };
 134 my $my_suggestion_with_budget2 = {
 135     title         => 'my title 3',
 136     author        => 'my author 3',
 137     publishercode => 'my publishercode 3',
 138     suggestedby   => $borrowernumber2,
 139     biblionumber  => $biblionumber1,
 140     managedby     => '',
 141     manageddate   => '',
 142     accepteddate  => dt_from_string,
 143     note          => 'my note',
 144     budgetid      => $budget_id,
 145 };
 146
 147 is( CountSuggestion(), 0, 'CountSuggestion without the status returns 0' );
 148 is( CountSuggestion('ASKED'), 0, 'CountSuggestion returns the correct number of suggestions' );
 149 is( CountSuggestion('CHECKED'), 0, 'CountSuggestion returns the correct number of suggestions' );
 150 is( CountSuggestion('ACCEPTED'), 0, 'CountSuggestion returns the correct number of suggestions' );
 151 is( CountSuggestion('REJECTED'), 0, 'CountSuggestion returns the correct number of suggestions' );
 152
 153 my $my_suggestionid = NewSuggestion($my_suggestion);
 154 isnt( $my_suggestionid, 0, 'NewSuggestion returns an not null id' );
 155 my $my_suggestionid_with_budget = NewSuggestion($my_suggestion_with_budget);
 156
 157 is( GetSuggestion(), undef, 'GetSuggestion without the suggestion id returns undef' );
 158 my $suggestion = GetSuggestion($my_suggestionid);
 159 is( $suggestion->{title}, $my_suggestion->{title}, 'NewSuggestion stores the title correctly' );
 160 is( $suggestion->{author}, $my_suggestion->{author}, 'NewSuggestion stores the author correctly' );
 161 is( $suggestion->{publishercode}, $my_suggestion->{publishercode}, 'NewSuggestion stores the publishercode correctly' );
 162 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'NewSuggestion stores the borrower number correctly' );
 163 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'NewSuggestion stores the biblio number correctly' );
 164 is( $suggestion->{STATUS}, 'ASKED', 'NewSuggestion stores a suggestion with the status ASKED by default' );
 165 is( $suggestion->{managedby}, undef, 'NewSuggestion stores empty string as undef for non existent foreign key (integer)' );
 166 is( $suggestion->{manageddate}, undef, 'NewSuggestion stores empty string as undef for date' );
 167 is( $suggestion->{budgetid}, undef, 'NewSuggestion should set budgetid to NULL if not given' );
 168
 169 is( CountSuggestion('ASKED'), 2, 'CountSuggestion returns the correct number of suggestions' );
 170
 171
 172 is( ModSuggestion(), undef, 'ModSuggestion without the suggestion returns undef' );
 173 my $mod_suggestion1 = {
 174     title         => 'my modified title',
 175     author        => 'my modified author',
 176     publishercode => 'my modified publishercode',
 177     managedby     => '',
 178     manageddate   => '',
 179 };
 180 my $status = ModSuggestion($mod_suggestion1);
 181 is( $status, undef, 'ModSuggestion without the suggestion id returns undef' );
 182
 183 $mod_suggestion1->{suggestionid} = $my_suggestionid;
 184 $status = ModSuggestion($mod_suggestion1);
 185 is( $status, 1, 'ModSuggestion modifies one entry' );
 186 $suggestion = GetSuggestion($my_suggestionid);
 187 is( $suggestion->{title}, $mod_suggestion1->{title}, 'ModSuggestion modifies the title  correctly' );
 188 is( $suggestion->{author}, $mod_suggestion1->{author}, 'ModSuggestion modifies the author correctly' );
 189 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'ModSuggestion modifies the publishercode correctly' );
 190 is( $suggestion->{managedby}, undef, 'ModSuggestion stores empty string as undef for non existent foreign key (integer)' );
 191 is( $suggestion->{manageddate}, undef, 'ModSuggestion stores empty string as undef for date' );
 192 isnt( $suggestion->{accepteddate}, undef, 'ModSuggestion does not update a non given date value' );
 193 is( $suggestion->{note}, 'my note', 'ModSuggestion should not erase data if not given' );
 194
 195 my $messages = C4::Letters::GetQueuedMessages({
 196     borrowernumber => $borrowernumber
 197 });
 198 is( @$messages, 0, 'ModSuggestions does not send an email if the status is not updated' );
 199
 200 my $mod_suggestion2 = {
 201     STATUS       => 'STALLED',
 202     suggestionid => $my_suggestionid,
 203 };
 204 warning_is { $status = ModSuggestion($mod_suggestion2) }
 205            "No suggestions STALLED letter transported by email",
 206            "ModSuggestion status warning is correct";
 207 is( $status, 1, "ModSuggestion Status OK");
 208
 209 my $mod_suggestion3 = {
 210     STATUS       => 'CHECKED',
 211     suggestionid => $my_suggestionid,
 212 };
 213
 214 #Test the message_transport_type of suggestion notices
 215
 216 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is disabled
 217 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 0 );
 218 $status = ModSuggestion($mod_suggestion3);
 219 is( $status, 1, 'ModSuggestion modifies one entry' );
 220 $suggestion = GetSuggestion($my_suggestionid);
 221 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'ModSuggestion modifies the status correctly' );
 222 $messages = C4::Letters::GetQueuedMessages({
 223     borrowernumber => $borrowernumber
 224 });
 225 is( @$messages, 1, 'ModSuggestion sends an email if the status is updated' );
 226 is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is disabled the suggestion message_transport_type is always email');
 227 is( CountSuggestion('CHECKED'), 1, 'CountSuggestion returns the correct number of suggestions' );
 228
 229 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is enabled and the borrower has a smsalertnumber and no email
 230 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 1 );
 231 ModSuggestion($mod_suggestion3);
 232 $messages = C4::Letters::GetQueuedMessages({
 233     borrowernumber => $borrowernumber
 234 });
 235 is ($messages->[1]->{message_transport_type}, 'sms', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is sms if the borrower has no email');
 236
 237 #Make a new suggestion for a borrower with defined email and no smsalertnumber
 238 my $my_suggestion_2_id = NewSuggestion($my_suggestion_with_budget2);
 239
 240 #Check the message_transport_type when the 'FallbackToSMSIfNoEmail' syspref is enabled and the borrower has a defined email and no smsalertnumber
 241 t::lib::Mocks::mock_preference( 'FallbackToSMSIfNoEmail', 1 );
 242 my $mod_suggestion4 = {
 243     STATUS       => 'CHECKED',
 244     suggestionid => $my_suggestion_2_id,
 245 };
 246 ModSuggestion($mod_suggestion4);
 247 $messages = C4::Letters::GetQueuedMessages({
 248     borrowernumber => $borrowernumber2
 249 });
 250 is ($messages->[0]->{message_transport_type}, 'email', 'When FallbackToSMSIfNoEmail syspref is enabled the suggestion message_transport_type is email if the borrower has an email');
 251
 252 is( GetSuggestionInfo(), undef, 'GetSuggestionInfo without the suggestion id returns undef' );
 253 $suggestion = GetSuggestionInfo($my_suggestionid);
 254 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfo returns the suggestion id correctly' );
 255 is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfo returns the title correctly' );
 256 is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfo returns the author correctly' );
 257 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfo returns the publisher code correctly' );
 258 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
 259 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfo returns the biblio number correctly' );
 260 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfo returns the status correctly' );
 261 is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfo returns the surname correctly' );
 262 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfo returns the firstname correctly' );
 263 is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' );
 264
 265
 266 is( GetSuggestionFromBiblionumber(), undef, 'GetSuggestionFromBiblionumber without the biblio number returns undef' );
 267 is( GetSuggestionFromBiblionumber(2), undef, 'GetSuggestionFromBiblionumber with an invalid biblio number returns undef' );
 268 is( GetSuggestionFromBiblionumber($biblionumber1), $my_suggestionid, 'GetSuggestionFromBiblionumber functions correctly' );
 269
 270
 271 is( GetSuggestionInfoFromBiblionumber(), undef, 'GetSuggestionInfoFromBiblionumber without the biblio number returns undef' );
 272 is( GetSuggestionInfoFromBiblionumber(2), undef, 'GetSuggestionInfoFromBiblionumber with an invalid biblio number returns undef' );
 273 $suggestion = GetSuggestionInfoFromBiblionumber($biblionumber1);
 274 is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfoFromBiblionumber returns the suggestion id correctly' );
 275 is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfoFromBiblionumber returns the title correctly' );
 276 is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfoFromBiblionumber returns the author correctly' );
 277 is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfoFromBiblionumber returns the publisher code correctly' );
 278 is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumber returns the borrower number correctly' );
 279 is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfoFromBiblionumber returns the biblio number correctly' );
 280 is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfoFromBiblionumber returns the status correctly' );
 281 is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfoFromBiblionumber returns the surname correctly' );
 282 is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfoFromBiblionumber returns the firstname correctly' );
 283 is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumeber returns the borrower number correctly' );
 284
 285
 286 my $suggestions = GetSuggestionByStatus();
 287 is( @$suggestions, 0, 'GetSuggestionByStatus without the status returns an empty array' );
 288 $suggestions = GetSuggestionByStatus('CHECKED');
 289 is( @$suggestions, 2, 'GetSuggestionByStatus returns the correct number of suggestions' );
 290 is( $suggestions->[0]->{suggestionid}, $my_suggestionid, 'GetSuggestionByStatus returns the suggestion id correctly' );
 291 is( $suggestions->[0]->{title}, $mod_suggestion1->{title}, 'GetSuggestionByStatus returns the title correctly' );
 292 is( $suggestions->[0]->{author}, $mod_suggestion1->{author}, 'GetSuggestionByStatus returns the author correctly' );
 293 is( $suggestions->[0]->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionByStatus returns the publisher code correctly' );
 294 is( $suggestions->[0]->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' );
 295 is( $suggestions->[0]->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionByStatus returns the biblio number correctly' );
 296 is( $suggestions->[0]->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionByStatus returns the status correctly' );
 297 is( $suggestions->[0]->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionByStatus returns the surname correctly' );
 298 is( $suggestions->[0]->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionByStatus returns the firstname correctly' );
 299 is( $suggestions->[0]->{branchcodesuggestedby}, $member->{branchcode}, 'GetSuggestionByStatus returns the branch code correctly' );
 300 is( $suggestions->[0]->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' );
 301 is( $suggestions->[0]->{categorycodesuggestedby}, $member->{categorycode}, 'GetSuggestionByStatus returns the category code correctly' );
 302
 303
 304 is( ConnectSuggestionAndBiblio(), '0E0', 'ConnectSuggestionAndBiblio without arguments returns 0E0' );
 305 my $biblionumber2 = 2;
 306 my $connect_suggestion_and_biblio = ConnectSuggestionAndBiblio($my_suggestionid, $biblionumber2);
 307 is( $connect_suggestion_and_biblio, '1', 'ConnectSuggestionAndBiblio returns 1' );
 308 $suggestion = GetSuggestion($my_suggestionid);
 309 is( $suggestion->{biblionumber}, $biblionumber2, 'ConnectSuggestionAndBiblio updates the biblio number correctly' );
 310
 311 my $search_suggestion = SearchSuggestion();
 312 is( @$search_suggestion, 3, 'SearchSuggestion without arguments returns all suggestions' );
 313
 314 $search_suggestion = SearchSuggestion({
 315     title => $mod_suggestion1->{title},
 316 });
 317 is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' );
 318 $search_suggestion = SearchSuggestion({
 319     title => 'another title',
 320 });
 321 is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' );
 322
 323 $search_suggestion = SearchSuggestion({
 324     author => $mod_suggestion1->{author},
 325 });
 326 is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' );
 327 $search_suggestion = SearchSuggestion({
 328     author => 'another author',
 329 });
 330 is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' );
 331
 332 $search_suggestion = SearchSuggestion({
 333     publishercode => $mod_suggestion1->{publishercode},
 334 });
 335 is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' );
 336 $search_suggestion = SearchSuggestion({
 337     publishercode => 'another publishercode',
 338 });
 339 is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' );
 340
 341 $search_suggestion = SearchSuggestion({
 342     STATUS => $mod_suggestion3->{STATUS},
 343 });
 344 is( @$search_suggestion, 2, 'SearchSuggestion returns the correct number of suggestions' );
 345
 346 $search_suggestion = SearchSuggestion({
 347     STATUS => q||
 348 });
 349 is( @$search_suggestion, 0, 'SearchSuggestion should not return all suggestions if we want the suggestions with a STATUS=""' );
 350 $search_suggestion = SearchSuggestion({
 351     STATUS => 'REJECTED',
 352 });
 353 is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' );
 354
 355 $search_suggestion = SearchSuggestion({
 356     budgetid => '',
 357 });
 358 is( @$search_suggestion, 3, 'SearchSuggestion (budgetid = "") returns the correct number of suggestions' );
 359 $search_suggestion = SearchSuggestion({
 360     budgetid => $budget_id,
 361 });
 362 is( @$search_suggestion, 2, 'SearchSuggestion (budgetid = $budgetid) returns the correct number of suggestions' );
 363 $search_suggestion = SearchSuggestion({
 364     budgetid => '__NONE__',
 365 });
 366 is( @$search_suggestion, 1, 'SearchSuggestion (budgetid = "__NONE__") returns the correct number of suggestions' );
 367 $search_suggestion = SearchSuggestion({
 368     budgetid => '__ANY__',
 369 });
 370 is( @$search_suggestion, 3, 'SearchSuggestion (budgetid = "__ANY__") returns the correct number of suggestions' );
 371
 372 my $del_suggestion = {
 373     title => 'my deleted title',
 374     STATUS => 'CHECKED',
 375     suggestedby => $borrowernumber,
 376 };
 377 my $del_suggestionid = NewSuggestion($del_suggestion);
 378
 379 is( CountSuggestion('CHECKED'), 3, 'CountSuggestion returns the correct number of suggestions' );
 380
 381 is( DelSuggestion(), '0E0', 'DelSuggestion without arguments returns 0E0' );
 382 is( DelSuggestion($borrowernumber), '', 'DelSuggestion without the suggestion id returns an empty string' );
 383 is( DelSuggestion(undef, $my_suggestionid), '', 'DelSuggestion with an invalid borrower number returns an empty string' );
 384 $suggestion = DelSuggestion($borrowernumber, $my_suggestionid);
 385 is( $suggestion, 1, 'DelSuggestion deletes one suggestion' );
 386
 387 $suggestions = GetSuggestionByStatus('CHECKED');
 388 is( @$suggestions, 2, 'DelSuggestion deletes one suggestion' );
 389 is( $suggestions->[1]->{title}, $del_suggestion->{title}, 'DelSuggestion deletes the correct suggestion' );
 390
 391 # Test budgetid fk
 392 $my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
 393 my $my_suggestionid_test_budgetid = NewSuggestion($my_suggestion);
 394 $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
 395 is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' );
 396
 397 $my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
 398 ModSuggestion( $my_suggestion );
 399 $suggestion = GetSuggestion($my_suggestionid_test_budgetid);
 400 is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' );
 401
 402 subtest 'GetUnprocessedSuggestions' => sub {
 403     plan tests => 11;
 404     $dbh->do(q|DELETE FROM suggestions|);
 405     my $my_suggestionid         = NewSuggestion($my_suggestion);
 406     my $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 407     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return 0 if a suggestion has been processed but not linked to a fund' );
 408     my $status     = ModSuggestion($mod_suggestion1);
 409     my $suggestion = GetSuggestion($my_suggestionid);
 410     is( $suggestion->{budgetid}, undef, 'ModSuggestion should set budgetid to NULL if not given' );
 411     ModSuggestion( { suggestionid => $my_suggestionid, budgetid => $budget_id } );
 412     $suggestion = GetSuggestion($my_suggestionid);
 413     is( $suggestion->{budgetid}, $budget_id, 'ModSuggestion should modify budgetid if given' );
 414
 415     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 416     is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
 417
 418     warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } ) }
 419                 'No suggestions REJECTED letter transported by email',
 420                 'Warning raised if no REJECTED letter by email';
 421     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 422     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
 423
 424     warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } ); }
 425                 'No suggestions ASKED letter transported by email',
 426                 'Warning raised if no ASKED letter by email';
 427     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
 428     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should use 0 as default value for days' );
 429     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(4);
 430     is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion suggested 4 days ago' );
 431     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(3);
 432     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should not return the suggestion, it has not been suggested 3 days ago' );
 433     $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(5);
 434     is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should not return the suggestion, it has not been suggested 5 days ago' );
 435 };
 436
 437 subtest 'DelSuggestionsOlderThan' => sub {
 438     plan tests => 6;
 439
 440     Koha::Suggestions->delete;
 441
 442     # Add four suggestions; note that STATUS needs uppercase (FIXME)
 443     my $d1 = output_pref({ dt => dt_from_string->add(days => -2), dateformat => 'sql' });
 444     my $d2 = output_pref({ dt => dt_from_string->add(days => -4), dateformat => 'sql' });
 445     my $sugg01 = $builder->build({ source => 'Suggestion', value => { date => $d1, STATUS => 'ASKED' }});
 446     my $sugg02 = $builder->build({ source => 'Suggestion', value => { date => $d1, STATUS => 'CHECKED' }});
 447     my $sugg03 = $builder->build({ source => 'Suggestion', value => { date => $d2, STATUS => 'ASKED' }});
 448     my $sugg04 = $builder->build({ source => 'Suggestion', value => { date => $d2, STATUS => 'ACCEPTED' }});
 449
 450     # Test no parameter: should do nothing
 451     C4::Suggestions::DelSuggestionsOlderThan();
 452     is( Koha::Suggestions->count, 4, 'No suggestions deleted' );
 453     # Test zero: should do nothing too
 454     C4::Suggestions::DelSuggestionsOlderThan(0);
 455     is( Koha::Suggestions->count, 4, 'No suggestions deleted again' );
 456     # Test negative value
 457     C4::Suggestions::DelSuggestionsOlderThan(-1);
 458     is( Koha::Suggestions->count, 4, 'No suggestions deleted for -1' );
 459
 460     # Test positive values
 461     C4::Suggestions::DelSuggestionsOlderThan(5);
 462     is( Koha::Suggestions->count, 4, 'No suggestions>5d deleted' );
 463     C4::Suggestions::DelSuggestionsOlderThan(3);
 464     is( Koha::Suggestions->count, 3, '1 suggestions>3d deleted' );
 465     C4::Suggestions::DelSuggestionsOlderThan(1);
 466     is( Koha::Suggestions->count, 2, '1 suggestions>1d deleted' );
 467 };
 468
 469 subtest 'EmailPurchaseSuggestions' => sub {
 470     plan tests => 11;
 471
 472     $dbh->do(q|DELETE FROM message_queue|);
 473
 474     t::lib::Mocks::mock_preference( "KohaAdminEmailAddress",
 475         'noreply@hosting.com' );
 476
 477     # EmailPurchaseSuggestions set to disabled
 478     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions", "0" );
 479     NewSuggestion($my_suggestion);
 480     my $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 481         {
 482             borrowernumber => $borrowernumber
 483         }
 484     );
 485     is( @$newsuggestions_messages, 0,
 486         'NewSuggestions does not send an email when disabled' );
 487
 488     # EmailPurchaseSuggestions set to BranchEmailAddress
 489     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 490         "BranchEmailAddress" );
 491     NewSuggestion($my_suggestion);
 492
 493     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 494     NewSuggestion($my_suggestion);
 495
 496     Koha::Libraries->find('CPL')->update( { branchemail => 'branchemail@hosting.com' } );
 497     NewSuggestion($my_suggestion);
 498
 499     Koha::Libraries->find('CPL')->update( { branchreplyto => 'branchemail@b.c' } );
 500     NewSuggestion($my_suggestion);
 501
 502     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 503         {
 504             borrowernumber => $borrowernumber
 505         }
 506     );
 507     isnt( @$newsuggestions_messages, 0, 'NewSuggestions sends an email' );
 508     my $message1 =
 509       C4::Letters::GetMessage( $newsuggestions_messages->[0]->{message_id} );
 510     is( $message1->{to_address}, 'noreply@hosting.com',
 511 'BranchEmailAddress falls back to KohaAdminEmailAddress if branchreplyto, branchemail and ReplytoDefault are not set'
 512     );
 513     my $message2 =
 514       C4::Letters::GetMessage( $newsuggestions_messages->[1]->{message_id} );
 515     is( $message2->{to_address}, 'library@b.c',
 516 'BranchEmailAddress falls back to ReplytoDefault if neither branchreplyto or branchemail are set'
 517     );
 518     my $message3 =
 519       C4::Letters::GetMessage( $newsuggestions_messages->[2]->{message_id} );
 520     is( $message3->{to_address}, 'branchemail@hosting.com',
 521 'BranchEmailAddress uses branchemail if branch_replto is not set'
 522     );
 523     my $message4 =
 524       C4::Letters::GetMessage( $newsuggestions_messages->[3]->{message_id} );
 525     is( $message4->{to_address}, 'branchemail@b.c',
 526 'BranchEmailAddress uses branchreplyto in preference to branchemail when set'
 527     );
 528
 529     # EmailPurchaseSuggestions set to KohaAdminEmailAddress
 530     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 531         "KohaAdminEmailAddress" );
 532
 533     t::lib::Mocks::mock_preference( "ReplytoDefault", undef );
 534     NewSuggestion($my_suggestion);
 535
 536     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 537     NewSuggestion($my_suggestion);
 538
 539     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 540         {
 541             borrowernumber => $borrowernumber
 542         }
 543     );
 544     my $message5 =
 545       C4::Letters::GetMessage( $newsuggestions_messages->[4]->{message_id} );
 546     is( $message5->{to_address},
 547         'noreply@hosting.com', 'KohaAdminEmailAddress uses KohaAdminEmailAddress when ReplytoDefault is not set' );
 548     my $message6 =
 549       C4::Letters::GetMessage( $newsuggestions_messages->[5]->{message_id} );
 550     is( $message6->{to_address},
 551         'library@b.c', 'KohaAdminEmailAddress uses ReplytoDefualt when ReplytoDefault is set' );
 552
 553     # EmailPurchaseSuggestions set to EmailAddressForSuggestions
 554     t::lib::Mocks::mock_preference( "EmailPurchaseSuggestions",
 555         "EmailAddressForSuggestions" );
 556
 557     t::lib::Mocks::mock_preference( "ReplytoDefault", undef );
 558     NewSuggestion($my_suggestion);
 559
 560     t::lib::Mocks::mock_preference( "ReplytoDefault", 'library@b.c' );
 561     NewSuggestion($my_suggestion);
 562
 563     t::lib::Mocks::mock_preference( "EmailAddressForSuggestions",
 564         'suggestions@b.c' );
 565     NewSuggestion($my_suggestion);
 566
 567     $newsuggestions_messages = C4::Letters::GetQueuedMessages(
 568         {
 569             borrowernumber => $borrowernumber
 570         }
 571     );
 572     my $message7 =
 573       C4::Letters::GetMessage( $newsuggestions_messages->[6]->{message_id} );
 574     is( $message7->{to_address},
 575         'noreply@hosting.com', 'EmailAddressForSuggestions uses KohaAdminEmailAddress when neither EmailAddressForSuggestions or ReplytoDefault are set' );
 576
 577     my $message8 =
 578       C4::Letters::GetMessage( $newsuggestions_messages->[7]->{message_id} );
 579     is( $message8->{to_address},
 580         'library@b.c', 'EmailAddressForSuggestions uses ReplytoDefault when EmailAddressForSuggestions is not set' );
 581
 582     my $message9 =
 583       C4::Letters::GetMessage( $newsuggestions_messages->[8]->{message_id} );
 584     is( $message9->{to_address},
 585         'suggestions@b.c', 'EmailAddressForSuggestions uses EmailAddressForSuggestions when set' );
 586 };
 587
 588 $schema->storage->txn_rollback;