| commit | f9f85c714db9f8e3ee1bb78186ca5b443e3de918 | |
| author | Lucian Wischik <ljw@fb.com> | |
| Thu, 15 Jul 2021 23:10:59 +0000 (15 16:10 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Thu, 15 Jul 2021 23:13:12 +0000 (15 16:13 -0700) | ||
| tree | 1c87f10c4c9b33cc273e6109185df1ef9c3325c5 | treesnapshot (tar.gz zip) |
| parent | 44eed04c0a58facb9898f50d1d4f9d7e960a0ebd | commitdiff |
dead code - ClientDebug, DerverDebug
Summary:
clientDebug and serverDebug are both dead code.
They were only ever used by one test (removed in the previous diff), which invoked "hh_client debug" to start the server with a side-channel. clientDebug was the hh_client side of this, and serverDebug was the server side.
Note the following:
```
type 'a command =
| Rpc of cmd_metadata * 'a t
| Debug_DO_NOT_USE
(** this unused constructor is part of the binary protocol
between client and server; removing it would alter the protocol. *)
```
To see what would happen if we did remove the now-unused constructor, see following diff D29716704.
Reviewed By: dabek
Differential Revision: D29705509
fbshipit-source-id: 2f9268c54421377793ceb610d826940ac153f1ab
Summary:
clientDebug and serverDebug are both dead code.
They were only ever used by one test (removed in the previous diff), which invoked "hh_client debug" to start the server with a side-channel. clientDebug was the hh_client side of this, and serverDebug was the server side.
Note the following:
```
type 'a command =
| Rpc of cmd_metadata * 'a t
| Debug_DO_NOT_USE
(** this unused constructor is part of the binary protocol
between client and server; removing it would alter the protocol. *)
```
To see what would happen if we did remove the now-unused constructor, see following diff D29716704.
Reviewed By: dabek
Differential Revision: D29705509
fbshipit-source-id: 2f9268c54421377793ceb610d826940ac153f1ab