Fix wordwrap. It wasn't matching Zend.
commite1314ffc614edd75c46fccfd66e4d1c05fac4218
authorJoel Marcey <joelm@fb.com>
Fri, 15 Nov 2013 15:48:09 +0000 (15 07:48 -0800)
committerSara Golemon <sgolemon@fb.com>
Fri, 15 Nov 2013 23:04:09 +0000 (15 15:04 -0800)
tree9732412a6b7abe0df660240dd45d90b9ab9d15c5
parentc14d9fce0b14a38ceb9241be741da6367d0d847f
Fix wordwrap. It wasn't matching Zend.

Zf2 tests were failing wordwrap with input like:

wordwrap('foobar*foobar', 6, '*', true);

HHVM would print: foobar**foobar
Zend would print: foobar*foobar

Reimplement wordwrap in PHP-land

Reviewed By: @ptarjan

Differential Revision: D1047300
hphp/runtime/debugger/debugger_client.cpp
hphp/runtime/ext/ext_string.cpp
hphp/runtime/ext/ext_string.h
hphp/system/idl/string.idl.json
hphp/system/php.txt
hphp/system/php/string/wordwrap.php [new file with mode: 0644]
hphp/test/slow/ext_string/ext_string.php
hphp/test/slow/ext_string/ext_string.php.expectf
hphp/test/slow/invalid_argument/1381.php.expectf
hphp/test/zend/bad/ext/standard/tests/strings/wordwrap_error.php [moved from hphp/test/zend/good/ext/standard/tests/strings/wordwrap_error.php with 99% similarity]
hphp/test/zend/bad/ext/standard/tests/strings/wordwrap_error.php.expectf [moved from hphp/test/zend/good/ext/standard/tests/strings/wordwrap_error.php.expectf with 100% similarity]