| commit | e053d80ee738b38b2b252ddc35f478d5800f880f | |
| author | Lucian Wischik <ljw@meta.com> | |
| Fri, 21 Oct 2022 00:50:41 +0000 (20 17:50 -0700) | ||
| committer | Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> | |
| Fri, 21 Oct 2022 00:50:41 +0000 (20 17:50 -0700) | ||
| tree | 35865f2ba10733d8c01dc49914664423e7303cab | treesnapshot (tar.gz zip) |
| parent | d2e4fb0f1d2bcf46814e9b57d8535fdf00b13e8b | commitdiff |
remove outproc for hh
Summary:
This diff...
1. Removes HhOutproc. We felt that outproc was a burden, not a benefit
2. Simplifies the "hh_api::Hh" trait into something simpler, now that it doesn't have to support outproc.
3. Switches from thiserror to anyhow
4. Including, switch to callback instead of iterator for incremental output.
5. Regularizes hh.rs, the main binary
6. Moves hh tests from src/facebook/hh/lib/test.rs to test/facebook/hh/update.rs
7. Simplified the test code, and changed it all to return anyhow rather than panic
8. Now that the code is shorter and simpler, it's short enough to fit hh/api and hh/lib into single files. So I did that.
Reviewed By: zhyty
Differential Revision: D40456166
fbshipit-source-id: 8048222f37929b52b164f418a39e28fababb8c52
Summary:
This diff...
1. Removes HhOutproc. We felt that outproc was a burden, not a benefit
2. Simplifies the "hh_api::Hh" trait into something simpler, now that it doesn't have to support outproc.
3. Switches from thiserror to anyhow
4. Including, switch to callback instead of iterator for incremental output.
5. Regularizes hh.rs, the main binary
6. Moves hh tests from src/facebook/hh/lib/test.rs to test/facebook/hh/update.rs
7. Simplified the test code, and changed it all to return anyhow rather than panic
8. Now that the code is shorter and simpler, it's short enough to fit hh/api and hh/lib into single files. So I did that.
Reviewed By: zhyty
Differential Revision: D40456166
fbshipit-source-id: 8048222f37929b52b164f418a39e28fababb8c52
| hphp/hack/src/naming/names_rust/naming_sqlite.rs | diffblobblamehistory |