From e053d80ee738b38b2b252ddc35f478d5800f880f Mon Sep 17 00:00:00 2001 From: Lucian Wischik Date: Thu, 20 Oct 2022 17:50:41 -0700 Subject: [PATCH] remove outproc for hh Summary: This diff... 1. Removes HhOutproc. We felt that outproc was a burden, not a benefit 2. Simplifies the "hh_api::Hh" trait into something simpler, now that it doesn't have to support outproc. 3. Switches from thiserror to anyhow 4. Including, switch to callback instead of iterator for incremental output. 5. Regularizes hh.rs, the main binary 6. Moves hh tests from src/facebook/hh/lib/test.rs to test/facebook/hh/update.rs 7. Simplified the test code, and changed it all to return anyhow rather than panic 8. Now that the code is shorter and simpler, it's short enough to fit hh/api and hh/lib into single files. So I did that. Reviewed By: zhyty Differential Revision: D40456166 fbshipit-source-id: 8048222f37929b52b164f418a39e28fababb8c52 --- hphp/hack/src/naming/names_rust/naming_sqlite.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hphp/hack/src/naming/names_rust/naming_sqlite.rs b/hphp/hack/src/naming/names_rust/naming_sqlite.rs index 63ce19eca51..8df067aae8a 100644 --- a/hphp/hack/src/naming/names_rust/naming_sqlite.rs +++ b/hphp/hack/src/naming/names_rust/naming_sqlite.rs @@ -793,6 +793,8 @@ impl Names { Ok(()) } + /// This creates a sqlite directory at the specified path. + /// It will fail if the directory containing that path doesn't exist. pub fn build_at_path( path: impl AsRef, file_summaries: impl IntoIterator, -- 2.11.4.GIT