| commit | cf91da04b83614fd50a2a33e1eee437ce6f73139 | |
| author | Joseph Griego <jgriego@fb.com> | |
| Fri, 5 Apr 2019 21:25:40 +0000 (5 14:25 -0700) | ||
| committer | Hhvm Bot <hhvm-bot@users.noreply.github.com> | |
| Fri, 5 Apr 2019 21:30:28 +0000 (5 14:30 -0700) | ||
| tree | b87cec1a84ace9f662bc5a2b1416ec0884214a4e | treesnapshot (tar.gz zip) |
| parent | 806292dcd7c3e0d11e727b81e56d107cc08e6e9d | commitdiff |
Allow users to specify part of a mangled closure name
Summary:
The HHJS transpiler emits a godawful number of closures--we'd like to profile
the output code but it's difficult to do with the default name-mangling; and it
seems like overkill to do our own closure conversion that names things more sensibly.
This adds support for a user attribute `__ClosureName` that inserts a
user-provided string into the mangled closure name.
Not sure if this is a kosher thing to do or not--feedback on this approach is
more than welcome.
Reviewed By: oulgen
Differential Revision: D13975389
fbshipit-source-id: b83da6beb570bbc94b2a723d7904daf9cfadcf8c
Summary:
The HHJS transpiler emits a godawful number of closures--we'd like to profile
the output code but it's difficult to do with the default name-mangling; and it
seems like overkill to do our own closure conversion that names things more sensibly.
This adds support for a user attribute `__ClosureName` that inserts a
user-provided string into the mangled closure name.
Not sure if this is a kosher thing to do or not--feedback on this approach is
more than welcome.
Reviewed By: oulgen
Differential Revision: D13975389
fbshipit-source-id: b83da6beb570bbc94b2a723d7904daf9cfadcf8c